1 2010-02-24 Marek Safar <marek.safar@gmail.com>
4 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
7 2010-02-24 Marek Safar <marek.safar@gmail.com>
10 * ecore.cs: Fixed type comparison.
12 2010-02-08 Miguel de Icaza <miguel@novell.com>
14 * namespace.cs (CompletionGetTypesStartingWith): Do not include
15 private types in the completion results.
17 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
20 2010-02-17 Marek Safar <marek.safar@gmail.com>
22 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
25 2010-02-14 Miguel de Icaza <miguel@novell.com>
27 * eval.cs: Do not do the report printer dance unless the user has
28 set the DescribeTypes feature.
30 2010-02-10 Marek Safar <marek.safar@gmail.com>
32 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
34 2010-02-08 Marek Safar <marek.safar@gmail.com>
37 * anonymous.cs: Fixed TypeBuilder* check.
39 2010-02-06 Miguel de Icaza <miguel@novell.com>
41 * eval.cs (CompileBlock): Also undo if there are problems during
42 semantic analysis, fixes various cases where invalid C# code would
43 be reported, but the internal changes would not be undone.
45 2010-02-03 Miguel de Icaza <miguel@novell.com>
47 * driver.cs: Change the --fatal flag to allow a number to be
48 passed, this ignores the first N fatal errors. Useful to debug
49 errors that do not happen on the first hit.
51 * cs-parser.jay (invocation_expression): accept both the
52 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
55 * driver.cs: Expose FatalErrors.
57 * eval.cs: Initialize the printer's Fatal property from the
58 Driver's FatalError flag, this allows csharp --fatal to work
61 Add support for calling Describe (typeof (TYPE)) if the expression
64 2010-02-02 Marek Safar <marek.safar@gmail.com>
67 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
70 2010-02-02 Marek Safar <marek.safar@gmail.com>
73 * expression.cs: Don't mutate typeof type definitions.
75 2010-01-28 Marek Safar <marek.safar@gmail.com>
77 * decl.cs: Use only one set of modifiers.
79 2010-01-26 Marek Safar <marek.safar@gmail.com>
82 * eval.cs: Don't disable error reporting completely on silent mode.
84 2010-01-25 Marek Safar <marek.safar@gmail.com>
87 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
88 pointer index of unknown size types greater than 2.
90 2010-01-15 Marek Safar <marek.safar@gmail.com>
92 * *.cs: Use only 1 member kind enum.
94 2010-01-15 Marek Safar <marek.safar@gmail.com>
96 * *.cs: Add event specification.
98 2010-01-14 Marek Safar <marek.safar@gmail.com>
100 * membercache.cs: Extracted from decl.cs.
102 * *.cs: Put more infrastructure in place.
104 2010-01-13 Marek Safar <marek.safar@gmail.com>
106 * *.cs: Add property specification, unused yet.
108 2010-01-13 Marek Safar <marek.safar@gmail.com>
110 * property.cs: Move all property based declarations into a new file.
112 2010-01-13 Marek Safar <marek.safar at gmail.com>
114 * expression.cs (Conditional): Resolve reduced expression.
116 2010-01-13 Marek Safar <marek.safar at gmail.com>
118 * *.cs: Introduced non-generic method specification.
120 2010-01-07 Marek Safar <marek.safar@gmail.com>
122 * method.cs: Move all method based declarations into a new file.
124 2010-01-07 Marek Safar <marek.safar@gmail.com>
126 * *.cs: Extract field specification.
128 2009-12-17 Marek Safar <marek.safar@gmail.com>
130 * field.cs: Extracted from class.cs
132 2009-12-15 Marek Safar <marek.safar@gmail.com>
134 * attribute.cs (GetFixedBuffer): Work on field definition only.
136 2009-12-15 Marek Safar <marek.safar@gmail.com>
138 * *.cs: Clean up NET_4_0 conditional where possible.
140 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
142 support.cs (DynamicType): Assembly property returns the assembly builder.
143 This is required due to how compiler context works in corlib.
145 2009-12-14 Marek Safar <marek.safar@gmail.com>
147 A fix for bug #564376
148 * assign.cs (LocalTemporary): Removed no longer needed special
151 2009-12-11 Marek Safar <marek.safar@gmail.com>
153 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
154 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
155 enum for easier debugging.
157 2009-12-10 Marek Safar <marek.safar@gmail.com>
159 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
162 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
165 2009-12-10 Marek Safar <marek.safar@gmail.com>
167 * cs-parser.jay, statement.cs: Handle parser error in code
170 2009-12-10 Marek Safar <marek.safar@gmail.com>
172 * ecore.cs: Ignore base imported methods when they are already
175 * eval.cs: Handle non-existent keys.
177 * report.cs, driver.cs: Make fatal work with console printer only.
179 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
181 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
183 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
185 * typemanager.cs: Add MakeGenericMethod that checks if the method
186 is really the generic method definition.
188 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
189 to inflate generic methods.
191 2009-12-08 Marek Safar <marek.safar@gmail.com>
193 A fix for bug #561149
194 * anonymous.cs: Use actual type parameters when checking for generic
197 2009-12-08 Marek Safar <marek.safar@gmail.com>
199 A fix for bug #561369
200 * expression.cs (DoNumericPromotion): Fixed typo.
202 2009-12-08 Marek Safar <marek.safar@gmail.com>
204 *.cs: Moving to generics world.
206 cs-parser.jay: Removed current_array_type.
208 2009-12-07 Marek Safar <marek.safar@gmail.com>
210 *.cs: Moving to generics world.
212 2009-12-04 Marek Safar <marek.safar@gmail.com>
214 *.cs: Moving to generics world (day 2).
216 2009-12-03 Marek Safar <marek.safar@gmail.com>
218 *.cs: Moving to generics world.
220 2009-12-02 Marek Safar <marek.safar@gmail.com>
222 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
223 Encode dynamic type attribute for elements where attributes cannot
226 2009-12-01 Marek Safar <marek.safar@gmail.com>
228 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
231 2009-12-01 Marek Safar <marek.safar@gmail.com>
233 A fix for bug #360455
234 * class.cs: Never report a unused warning for generic events to
235 workaround wrong expression type.
237 2009-11-30 Marek Safar <marek.safar@gmail.com>
239 A fix for bug #558305
240 * decl.cs, class.cs: Check partial method definitions using correct
243 2009-11-30 Marek Safar <marek.safar@gmail.com>
245 * argument.cs: Don't cache rarely used dynamic flag.
247 2009-11-27 Marek Safar <marek.safar@gmail.com>
249 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
251 2009-11-27 Marek Safar <marek.safar@gmail.com>
253 * ecore.cs (SimpleName): Removed no longer needed in_transit as
254 Resolve is now non-reentrant (saves ~0.6MB for corlib).
256 2009-11-26 Marek Safar <marek.safar@gmail.com>
258 A fix for bug #545081
259 * decl.cs: Check private nested types of nested types recursively.
261 2009-11-26 Marek Safar <marek.safar@gmail.com>
263 A fix for bug #558305
264 * location.cs: Ignore self referencing #line directive
266 2009-11-26 Marek Safar <marek.safar@gmail.com>
268 A fix for bug #558292
269 * class.cs: Allow single unsafe fixed buffer fields.
271 2009-11-26 Marek Safar <marek.safar@gmail.com>
273 * expression: Optimize few more zero-based operations.
275 2009-11-26 Marek Safar <marek.safar@gmail.com>
277 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
278 avoids boxing of literal values.
280 2009-11-26 Marek Safar <marek.safar@gmail.com>
282 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
283 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
284 codegen.cs: LocatedToken redesing to avoid excessive allocation and
285 boxing (saves ~7MB for corlib). Also fixes presise token location.
287 2009-11-25 Marek Safar <marek.safar@gmail.com>
289 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
292 2009-11-24 Marek Safar <marek.safar@gmail.com>
294 * expression.cs: Lower static array initializer barrier.
296 * support.cs, driver.cs: Share reader buffer.
298 2009-11-23 Marek Safar <marek.safar@gmail.com>
300 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
302 2009-11-23 Marek Safar <marek.safar@gmail.com>
304 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
305 cleanup some obsolete code.
307 2009-11-20 Marek Safar <marek.safar@gmail.com>
309 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
312 2009-11-20 Marek Safar <marek.safar@gmail.com>
314 * *.cs: Resolved expressions are never resolved again, this helps to
315 uncover some not easy to find bugs and improve the performance.
317 2009-11-19 Marek Safar <marek.safar@gmail.com>
319 * *.cs: Made constant expressions fully compatible with any other
322 2009-11-19 Marek Safar <marek.safar@gmail.com>
324 * *.cs: DoResolve is a worker method and has to be protected.
326 2009-11-18 Marek Safar <marek.safar@gmail.com>
328 * *.cs: More context specific handling.
330 2009-11-17 Marek Safar <marek.safar@gmail.com>
332 * *.cs: More context specific handling.
334 2009-11-16 Marek Safar <marek.safar@gmail.com>
336 * dynamic.cs, class.cs: Removed few fixed user types conversions.
338 * symbolwriter.cs: Uses public ILOffset.
340 2009-11-13 Marek Safar <marek.safar@gmail.com>
342 A fix for bug #553650
343 * generic.cs: Another missing TypeToCoreType, still too many to fix.
345 2009-11-13 Marek Safar <marek.safar@gmail.com>
347 A fix for bug #555170
349 * class.cs, delegate.cs, enum.cs: Constants have to be available
350 for parameters resolve.
352 2009-11-12 Marek Safar <marek.safar@gmail.com>
354 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
357 2009-11-12 Marek Safar <marek.safar@gmail.com>
359 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
360 with a statically known candidate set.
362 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
364 * generic.cs: Made type inflation for generic constraint checks
365 recursive. This fixes BGO #553655.
367 2009-11-11 Marek Safar <marek.safar@gmail.com>
369 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
372 2009-11-10 Marek Safar <marek.safar@gmail.com>
374 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
375 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
376 attribute.cs: Add some dynamic error checking.
378 2009-11-07 Marek Safar <marek.safar@gmail.com>
380 A fix for bug #553465
382 * expression.cs: Fixed mixed version of expression tree anonymous
385 2009-11-06 Marek Safar <marek.safar@gmail.com>
387 A fix for bug #553031
389 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
390 expression tree version of anonymous type with members declaration.
392 2009-11-05 Marek Safar <marek.safar@gmail.com>
394 * parameter.cs: Handle nullable parameter default expression.
396 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
397 class.cs, attribute.cs: Check for wrong dynamic arguments.
399 2009-11-05 Marek Safar <marek.safar@gmail.com>
401 * statement.cs: Dynamic statements.
403 2009-11-04 Marek Safar <marek.safar@gmail.com>
405 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
406 Compound assignments over dynamic type.
408 2009-11-03 Marek Safar <marek.safar@gmail.com>
410 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
411 constructor arguments.
413 2009-10-30 Marek Safar <marek.safar@gmail.com>
415 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
416 codegen.cs: Unary mutator on dynamic member access expression.
418 2009-10-29 Marek Safar <marek.safar@gmail.com>
420 A fix for bug #550580
421 * convert.cs: Don't eliminate explicit precission casts.
423 2009-10-28 Marek Safar <marek.safar@gmail.com>
425 A fix for bug #550404
427 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
428 expression.cs, statement.cs, ecore.cs: Quote any nested expression
431 2009-10-27 Marek Safar <marek.safar@gmail.com>
433 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
436 * class.cs: Allow nullable binary user operators.
438 2009-10-26 Marek Safar <marek.safar@gmail.com>
440 * expression.cs: Move binary expression optimization at the end of
443 2009-10-23 Marek Safar <marek.safar@gmail.com>
445 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
446 Separate NullConstant from NullLiteral.
448 2009-10-23 Marek Safar <marek.safar@gmail.com>
450 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
451 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
452 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
453 ModuleContainer. Add common unclosed member check routine.
455 2009-10-22 Marek Safar <marek.safar@gmail.com>
457 * argument.cs: Use literal flag for real literals only.
459 * dynamic.cs: Use correct return type for custom delegates.
461 2009-10-22 Marek Safar <marek.safar@gmail.com>
463 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
466 2009-10-22 Marek Safar <marek.safar@gmail.com>
468 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
470 2009-10-21 Marek Safar <marek.safar@gmail.com>
472 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
475 2009-10-21 Marek Safar <marek.safar@gmail.com>
477 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
480 2009-10-20 Marek Safar <marek.safar@gmail.com>
482 * argument.cs, dynamic.cs, expression.cs: Latest API update.
484 2009-10-19 Marek Safar <marek.safar@gmail.com>
486 * typemanager.cs, expression.cs: Dynamic array initializer.
488 2009-10-16 Marek Safar <marek.safar@gmail.com>
490 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
493 2009-10-16 Marek Safar <marek.safar@gmail.com>
495 A fix for bug #493523, #507067
496 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
497 standard nullable conversion using underlying standard conversion
498 and not full conversion.
500 2009-10-15 Marek Safar <marek.safar@gmail.com>
502 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
503 type in VerifyArgumentsCompat.
505 2009-10-15 Marek Safar <marek.safar@gmail.com>
507 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
508 Reject variable used with type arguments.
510 2009-10-14 Marek Safar <marek.safar@gmail.com>
512 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
513 Implement dynamic expressions assignment.
515 2009-10-14 Marek Safar <marek.safar@gmail.com>
517 * expression.cs: Build underlying expression when resolving unary
520 2009-10-14 Marek Safar <marek.safar@gmail.com>
522 * expression.cs: Emit enum array initializer using binary blob.
524 2009-10-08 Marek Safar <marek.safar@gmail.com>
526 * typemanager.cs, constant.cs: Optimize decimal constants which fit
529 2009-10-07 Marek Safar <marek.safar@gmail.com>
531 * typemanager.cs: Reset object_type.
533 * assign: Made SimpleAssign public.
535 2009-10-06 Marek Safar <marek.safar@gmail.com>
537 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
538 invocation assembly to IsThisOrFriendAssembly.
540 2009-10-05 Marek Safar <marek.safar@gmail.com>
542 * expression.cs: Equality comparison of generic parameter with
545 2009-10-05 Marek Safar <marek.safar@gmail.com>
547 A fix for bug #543570
548 * generic.cs: Import predefined constraints correctly.
550 2009-10-02 Marek Safar <marek.safar@gmail.com>
552 * ecore.cs: Don't crash on overloads with optional paremeters where
553 arguments count overflows.
555 * parameter.cs: Import optional parameter constants using optional
558 2009-10-01 Marek Safar <marek.safar@gmail.com>
560 * Makefile: Default is gmcs compiler.
562 2009-10-01 Marek Safar <marek.safar@gmail.com>
564 * cs-parser.jay: Fixed few NRE.
566 2009-10-01 Marek Safar <marek.safar@gmail.com>
568 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
570 2009-09-30 Marek Safar <marek.safar@gmail.com>
572 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
573 ShimExpression, ImplicitCast.
575 2009-09-30 Marek Safar <marek.safar@gmail.com>
577 A fix for bug #542959
578 * delegate.cs: Emit correct delegate instance variable when there
579 are static and non-static overloads.
581 2009-09-29 Marek Safar <marek.safar@gmail.com>
583 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
584 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
586 2009-09-28 Marek Safar <marek.safar@gmail.com>
588 A fix for bug #542487
589 * ecore.cs: Resolve extension methods hidden by properties.
591 2009-09-25 Marek Safar <marek.safar@gmail.com>
593 * expression.cs, ecore.cs: More dynamic binary expressions.
595 2009-09-22 Marek Safar <marek.safar@gmail.com>
597 * nullable.cs, expression.cs: Fixed null lifted conversion for
598 bitwise enum operations.
600 2009-09-22 Marek Safar <marek.safar@gmail.com>
602 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
603 values in checked context.
605 2009-09-22 Marek Safar <marek.safar@gmail.com>
607 * expression.cs, ecore.cs: Fixed array index constant conversion.
609 2009-09-20 Miguel de Icaza <miguel@novell.com>
611 * expression.cs: Do not crash when MemberLookup returns something
612 that is not a MemberExpr here. Report error 582 instead.
616 2009-09-18 Marek Safar <marek.safar@gmail.com>
618 * decl.cs, class.cs: Check protected property accessors.
620 2009-09-18 Marek Safar <marek.safar@gmail.com>
622 * dynamic.cs, assign.cs: Dynamic compound assignment.
624 2009-09-17 Marek Safar <marek.safar@gmail.com>
626 * expression.cs: Fixed compound assignment explicit conversion.
628 2009-09-17 Marek Safar <marek.safar@gmail.com>
630 * expression.cs, ecore.cs: Cannot infer variables from method group.
632 2009-09-16 Marek Safar <marek.safar@gmail.com>
634 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
635 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
636 codegen.cs: Dynamic binary operations scaffolding.
638 2009-09-15 Marek Safar <marek.safar@gmail.com>
640 * expression.cs: Fixes nullable promotion for enum type variables.
642 2009-09-11 Marek Safar <marek.safar@gmail.com>
644 * driver.cs, dynamic.cs: Reset more static variables.
646 2009-09-11 Marek Safar <marek.safar@gmail.com>
648 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
649 driver.cs: Introduced Expression::MakeExpression.
651 2009-09-11 Marek Safar <marek.safar@gmail.com>
653 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
655 2009-09-09 Marek Safar <marek.safar@gmail.com>
657 * eval.cs, report.cs: Use Console.Out for all eval error or warning
660 2009-09-09 Marek Safar <marek.safar@gmail.com>
662 A fix for bug #518707
663 * expression.cs (Is): Optimize only generic parameter type
664 expression probing value type generic parameter.
666 2009-09-09 Marek Safar <marek.safar@gmail.com>
668 A fix for bug #532571
669 * ecore.cs: Check for simple name type arguments used with
672 2009-09-08 Marek Safar <marek.safar@gmail.com>
674 A fix for bug #497421
675 * generic.cs (CheckConstraint): Don't use buildin types to check for
676 parameterless constructor.
678 2009-09-08 Marek Safar <marek.safar@gmail.com>
680 A fix for bug #537402
681 * generic.cs (CheckConstraint): Correctly inflate generic type
682 arguments when checking generic method.
684 2009-09-08 Marek Safar <marek.safar@gmail.com>
686 A fix for bug #536463
687 * decl.cs (AddToContainer): Don't report collision between explicit
688 and parameterless non-explicit members.
690 2009-09-08 Marek Safar <marek.safar@gmail.com>
692 * eval.cs: Reset more static stuff.
694 2009-09-07 Marek Safar <marek.safar@gmail.com>
696 A fix for bug #324625
697 * expression.cs, ecore.cs: Create nested generic type expression
698 using declaring and not current type.
700 2009-09-07 Marek Safar <marek.safar@gmail.com>
702 * *.cs: Changed Report class to accept various output printers and
703 be an instance class. An expression resolver can now use different
704 message reporter for each call and Report.Error can safely throw
705 an exception. Part of ongoing work to turn mcs into proper library.
707 2009-09-04 Marek Safar <marek.safar@gmail.com>
709 * statement.cs, ecore.cs: Removed error reporting from emit code.
711 2009-09-04 Marek Safar <marek.safar@gmail.com>
713 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
715 2009-09-03 Marek Safar <marek.safar@gmail.com>
717 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
718 parser checks out of constructors.
720 2009-09-02 Marek Safar <marek.safar@gmail.com>
722 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
724 2009-09-02 Marek Safar <marek.safar@gmail.com>
726 A fix for bug #535448
727 * anonymous.cs, class.cs: Copy return label between all contexts.
729 2009-09-02 Marek Safar <marek.safar@gmail.com>
731 A fix for bug #535395
732 * namespace.cs: Resolve context can be null.
734 2009-08-25 Marek Safar <marek.safar@gmail.com>
736 A fix for bug #533912
737 * generic.cs: Use correct context for constraints resolving.
739 2009-08-25 Marek Safar <marek.safar@gmail.com>
741 A fix for bug #532630
742 * driver.cs: Trim conditional symbols.
744 2009-08-25 Marek Safar <marek.safar@gmail.com>
746 * context.cs: New file.
748 * *.exe.sources, *.csproj: Updated.
750 2009-08-25 Marek Safar <marek.safar@gmail.com>
752 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
753 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
754 IMembercontext, some small cleanups.
756 2009-08-24 Marek Safar <marek.safar@gmail.com>
758 * *.cs: Split ResolveContext and EmitContext.
760 2009-08-24 Marek Safar <marek.safar@gmail.com>
762 * *.cs: Only ResolveContext implements IMemberContext.
764 2009-08-21 Marek Safar <marek.safar@gmail.com>
766 * *.cs: Renamed IResolveContext to IMemberContext.
768 2009-08-21 Marek Safar <marek.safar@gmail.com>
770 * *.cs: Detached ResolveContext from EmitContext.
772 2009-08-21 Marek Safar <marek.safar@gmail.com>
774 * codegen.cs: Moved flow-analysis to BlockContext.
776 2009-08-21 Marek Safar <marek.safar@gmail.com>
778 * *.cs: Detached BlockContext from EmitContext.
780 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
782 * statement.cs: avoid nullref when the return value of GetEnumerator()
783 does not contain any MoveNext() method.
785 2009-08-19 Marek Safar <marek.safar@gmail.com>
787 * *.cs: Removed IResolveContext::GenericDeclContainer.
789 2009-08-19 Marek Safar <marek.safar@gmail.com>
791 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
793 2009-08-19 Marek Safar <marek.safar@gmail.com>
795 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
796 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
798 2009-08-18 Marek Safar <marek.safar@gmail.com>
800 * *.cs: Removed boolean fields from EmitContext.
802 2009-08-18 Marek Safar <marek.safar@gmail.com>
804 * *.cs: Add IResolveContext::IsStatic.
806 2009-08-18 Marek Safar <marek.safar@gmail.com>
808 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
810 2009-08-17 Marek Safar <marek.safar@gmail.com>
812 * *.cs: Removed DeclContainer from EmitContext.
814 2009-08-17 Marek Safar <marek.safar@gmail.com>
816 * *.cs: Add IResolveContext::CurrentTypeParameters.
818 2009-08-14 Marek Safar <marek.safar@gmail.com>
820 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
822 2009-08-14 Marek Safar <marek.safar@gmail.com>
824 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
825 codegen.cs: Add IResolveContext::LookupExtensionMethod.
827 2009-08-13 Marek Safar <marek.safar@gmail.com>
829 * decl.cs: Look in PartialContainer for parent type parameters.
831 2009-08-13 Marek Safar <marek.safar@gmail.com>
833 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
834 codegen.cs: Add IResolveContext::LookupTypeParameter.
836 2009-08-13 Marek Safar <marek.safar@gmail.com>
838 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
839 Moved resolved logic from Emit to Resolve.
841 2009-08-13 Marek Safar <marek.safar@gmail.com>
843 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
844 codegen.cs: Reworked atttributes handling of ResolveContext.
846 2009-08-12 Marek Safar <marek.safar@gmail.com>
848 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
849 LookupNamespaceOrType to ResolveContext.
851 2009-08-12 Marek Safar <marek.safar@gmail.com>
853 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
854 class.cs: Removed unused parameters and methods.
856 2009-08-11 Marek Safar <marek.safar@gmail.com>
858 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
859 codegen.cs: Finding the best common type of a set of expressions for
862 2009-08-07 Marek Safar <marek.safar@gmail.com>
864 * dynamic.cs, expression.cs: More dynamic conversions.
866 2009-08-06 Miguel de Icaza <miguel@novell.com>
868 * generic.cs: This loop was incorrect, it was increment ii, but
869 checking for `i'. This was a change introduced to fix #327497,
872 * class.cs: Catch another case for cs0533 error, fixes #324782.
874 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
876 * typemanager.cs (GetGenericArguments): SRE returns null for
877 generic methods on type builder instances if they are not generic
878 themselves. For example, for Foo<int>::Bar() it returns null, but
879 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
881 2009-08-05 Marek Safar <marek.safar@gmail.com>
883 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
884 delegate.cs: Work on dynamic binding.
886 2009-08-04 Marek Safar <marek.safar@gmail.com>
888 A second fix for bug #525342
889 * class.cs: Attach partial method attributes to method
892 2009-08-03 Marek Safar <marek.safar@gmail.com>
894 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
897 * rootcontext.cs: Default to langversion v4.
899 2009-08-03 Marek Safar <marek.safar@gmail.com>
901 * pending.cs: Check return type before member info is set.
903 2009-08-03 Marek Safar <marek.safar@gmail.com>
905 * anonymous.cs: Fully initialize generic hoisted field expression.
907 2009-08-02 Miguel de Icaza <miguel@novell.com>
909 * cs-parser.jay: Flag variables declared on the interactive shell
910 as used to prevent the 168 warning about local variable not being
913 2009-07-31 Marek Safar <marek.safar@gmail.com>
915 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
916 attribute.cs: Emit dynamic export attribute.
918 2009-07-30 Marek Safar <marek.safar@gmail.com>
920 * expression.cs: More verifier work.
922 2009-07-29 Marek Safar <marek.safar@gmail.com>
924 * nullable.cs: Fixed SRE crash during corlib compilation.
926 2009-07-29 Marek Safar <marek.safar@gmail.com>
928 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
929 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
930 More TypeManager.TypeToCoreType needed.
932 2009-07-29 Marek Safar <marek.safar@gmail.com>
934 * anonymous.cs: Update after recent SRE fixes.
936 2009-07-28 Marek Safar <marek.safar@gmail.com>
938 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
939 version of GetFieldHandle for fields of generic types.
941 2009-07-27 Marek Safar <marek.safar@gmail.com>
943 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
944 ecore.cs: Add TypeManager.IsDynamicType,
945 PredefinedAttributes.Dynamic.
947 2009-07-27 Marek Safar <marek.safar@gmail.com>
949 A fix for bug #415375
950 * expression.cs: Fixed object and reference type parameter
953 2009-07-27 Marek Safar <marek.safar@gmail.com>
955 A fix for bug #525342
956 * class.cs: Attach partial method attributes to method
959 2009-07-24 Marek Safar <marek.safar@gmail.com>
961 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
964 2009-07-24 Marek Safar <marek.safar@gmail.com>
966 * anonymous.cs (MutateField): Add imported types handling.
968 2009-07-23 Marek Safar <marek.safar@gmail.com>
970 * expression.cs, delegate.cs: Moved arguments resolve into their
971 counterparts expressions. Removed argument resolve from
972 CollectionElementInitializer.
974 2009-07-23 Marek Safar <marek.safar@gmail.com>
976 A fix for bug #523683
977 * convert.cs, delegate.cs: Use common overload mechanism for method
978 group conversion check.
980 2009-07-22 Marek Safar <marek.safar@gmail.com>
982 A fix for bug #523899
983 * generics.cs: Exact type inference with other bound types.
985 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
987 Don't complain when the same type is implemented by the output
988 assembly as well as multiple referenced assemblies
989 * namespace.cs (RootNamespace.LookupTypeReflection): Add
990 'must_be_unique' flag.
991 (GlobalRootNamespace): Update to changes.
992 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
993 already have a type in hand.
995 2009-07-22 Marek Safar <marek.safar@gmail.com>
997 * expression.cs: More verifier instrumentation.
999 * statement.cs: Do proper throw expression conversion.
1001 2009-07-22 Marek Safar <marek.safar@gmail.com>
1003 A fix for bug #522789
1004 * expression.cs: Mutate invocation return type.
1006 2009-07-16 Marek Safar <marek.safar@gmail.com>
1008 * anonymous.cs: Split assignable and readonly generated variable
1011 2009-07-16 Marek Safar <marek.safar@gmail.com>
1013 A fix for bug #521671
1014 * statement.cs: Fixed crash when checking missing type.
1016 2009-07-16 Marek Safar <marek.safar@gmail.com>
1018 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1019 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1020 class.cs, driver.cs: Work on dynamic binding.
1022 * dynamic.cs: New file.
1024 * *.sources, *.proj: Updated.
1026 2009-07-15 Marek Safar <marek.safar@gmail.com>
1028 * expression.cs (Conditional): Avoid double Resolve.
1030 2009-07-13 Marcus Griep <marcus@griep.us>
1032 * ecore.cs: Fix obscure bug with resolving members of interfaces
1033 that hide parent interface members. Fixes bug #444388 and corrects
1036 2009-07-13 Marek Safar <marek.safar@gmail.com>
1038 * expression.cs (LocalVariableReference): Bounce resolve.
1040 2009-07-10 Marek Safar <marek.safar@gmail.com>
1042 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1043 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1046 * support.cs: New dynamic type wrapper.
1048 2009-07-08 Marek Safar <marek.safar@gmail.com>
1050 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1051 typed local variable.
1053 2009-07-06 Marek Safar <marek.safar@gmail.com>
1055 A fix for bug #519005
1056 * anonymous.cs: Use null_type as no return type placeholder.
1058 2009-07-02 Marek Safar <marek.safar@gmail.com>
1060 * generic.cs: Handle type inference of identical type parameters
1061 with different bounds.
1063 2009-07-01 Marek Safar <marek.safar@gmail.com>
1065 * expression.cs, class.cs: Events variance.
1067 * cs-parser.jay: Interface events error messages.
1069 2009-07-01 Marek Safar <marek.safar@gmail.com>
1071 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1073 2009-06-29 Marek Safar <marek.safar@gmail.com>
1075 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1076 parameter expression can be value-type New.
1078 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1080 2009-06-26 Marek Safar <marek.safar@gmail.com>
1082 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1083 Implemented C# 4.0 named arguments.
1085 2009-06-24 Marek Safar <marek.safar@gmail.com>
1087 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1088 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1089 parameter modifier. Also fixes bug #515497.
1091 2009-06-24 Marek Safar <marek.safar@gmail.com>
1093 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1094 arguments expression to be implemented.
1096 *.sources: Add argument.cs
1098 2009-06-23 Marek Safar <marek.safar@gmail.com>
1100 * parameter.cs: Moved GetParameterIndexByName to base class.
1102 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1103 unused AType. Use argument's version of GetExpressionTree.
1105 2009-06-22 Marek Safar <marek.safar@gmail.com>
1107 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1110 2009-06-17 Marek Safar <marek.safar@gmail.com>
1112 A fix for bug #514096
1113 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1115 2009-06-17 Marek Safar <marek.safar@gmail.com>
1117 * expression.cs: The first multi-dimensional array nested array
1118 initializers was not checked.
1120 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1122 2009-06-17 Marek Safar <marek.safar@gmail.com>
1124 A fix for bug #513400
1125 * nullable.cs (EmitEquality): Operands emit could be simplified for
1126 built-in types when we now emit user operators differently.
1128 2009-06-16 Marek Safar <marek.safar@gmail.com>
1130 * ecore.cs: Report inaccessible delegate methods correctly.
1132 2009-06-16 Marek Safar <marek.safar@gmail.com>
1134 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1135 cs-parser.jay: Implemented C# 4.0 optional parameters.
1137 2009-06-16 Marek Safar <marek.safar@gmail.com>
1139 * driver.cs: Removed broken DefineManifestResource.
1141 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1143 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1144 Use $(BOOTSTRAP_PROFILE) instead.
1146 2009-06-12 Jb Evain <jbevain@novell.com>
1148 * rootcontext.cs: add a Platform field.
1149 * driver.cs: handle /platform.
1150 * codegen.cs: pass the proper flags according to
1151 the platform when saving the assembly.
1153 2009-06-11 Marek Safar <marek.safar@gmail.com>
1155 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1156 Add optional parameters grammar.
1158 2009-06-10 Marek Safar <marek.safar@gmail.com>
1160 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1161 driver.cs: Split lang version and metadata version.
1163 2009-06-10 Marek Safar <marek.safar@gmail.com>
1165 * decl.cs: Better overload ctor collision error message.
1167 2009-06-05 Jb Evain <jbevain@novell.com>
1169 * driver.cs (EmbededResource): avoid using an internal method
1170 in gmcs to embed manifest resources.
1172 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1174 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1175 the compiler from older mono versions (like moon's bots)
1177 2009-06-04 Marek Safar <marek.safar@gmail.com>
1179 * namespace.cs (LookupTypeReflection): Ignore collisions between
1182 2009-06-04 Marek Safar <marek.safar@gmail.com>
1184 * codegen.cs: Enabled generic type forwarders.
1186 2009-06-04 Marek Safar <marek.safar@gmail.com>
1188 * dmcs.*: Add another version of SRE compiler.
1190 2009-06-03 Marek Safar <marek.safar@gmail.com>
1192 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1193 generic-mcs.cs: Fixed variant type conversions.
1195 2009-06-02 Marek Safar <marek.safar@gmail.com>
1197 A fix for bug #507863
1198 * codegen.cs: Fixes a crash on invalid string value attribute.
1200 2009-06-01 Marek Safar <marek.safar@gmail.com>
1202 A fix for bug #508334
1203 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1204 cs-parser.jay: Fully import __arglist modifier.
1206 2009-05-29 Marek Safar <marek.safar@gmail.com>
1208 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1209 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1210 actually work with closed generic types.
1212 2009-05-27 Alan McGovern <amcgovern@novell.com>
1214 * class.cs, decl.cs, delegate.cs, parameter.cs:
1215 Fix the build by replacing the use of 'var' with the actual type.
1217 2009-05-27 Marek Safar <marek.safar@gmail.com>
1219 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1220 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1223 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1226 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1227 Marek Safar <marek.safar@gmail.com>
1229 A fix for bug #377509
1230 * parameter.cs: Use predefined and not empty name for implicit
1233 2009-05-21 Marek Safar <marek.safar@gmail.com>
1235 * class.cs: Don't report wrong warnings for event fields.
1237 2009-05-21 Marek Safar <marek.safar@gmail.com>
1239 A fix for bug #504667
1240 * class.cs: Check for static class using parent container instead of
1243 2009-05-08 Marek Safar <marek.safar@gmail.com>
1245 A fix for bug #496922
1246 * expression.cs: Always use temporary variable when using object
1249 2009-04-28 Marek Safar <marek.safar@gmail.com>
1251 A fix for bug #495112
1252 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1255 2009-04-27 Miguel de Icaza <miguel@novell.com>
1257 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1259 2009-04-24 Miguel de Icaza <miguel@novell.com>
1261 * complete.cs: No idea how gonzalo got a null in the list, but
1264 2009-04-24 Miguel de Icaza <miguel@novell.com>
1266 * complete.cs (CompletionElementInitializer): New completion class
1267 to support completing inside a C# 3 element initializer, so this
1268 allows completion for Silverlight situations where it is very
1271 new TextBlock () { Fo<TAB>
1273 (CompletionSimpleName): Expose the prefix that was
1274 passed to the simple name.
1276 * cs-parser.jay (object_or_collection_initializer): Add support
1277 for element_initializers.
1279 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1280 special case completion expressions as this method aggressively
1281 collects data before it operates, and errors were being thrown
1282 earlier than we were able to complete.
1284 2009-04-23 Miguel de Icaza <miguel@novell.com>
1286 * eval.cs: Make getcompletions silent and enable debugging output
1287 if the -v option is passed.
1289 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1290 Consider looking up the namespace that matches the prefix being
1293 This is part of the support for allowing completions like:
1294 `System.Co<TAB>' to complete to System.Console.
1296 * complete.cs (CompletionSimpleName.AppendResults): Make this
1299 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1301 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1302 COMPLETE_COMPLETION as internal.
1304 2009-04-17 Miguel de Icaza <miguel@novell.com>
1306 * complete.cs: Include namespace resolution in simple names as
1307 well as global types and types in the using scope in the
1310 * namespace.cs: Supporting infrastrcture to provide completions
1311 based on the current using scope.
1313 * eval.cs: Introduce an entry point that allows for initialization
1314 to return a list of the files passed on the command line.
1316 2009-04-14 Marek Safar <marek.safar@gmail.com>
1318 A fix for bug #494243
1319 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1321 2009-04-13 Marek Safar <marek.safar@gmail.com>
1323 A fix for bug #493887
1324 * statement.cs: Don't skip string multi-section with default or
1325 null label when populating string hashtable.
1327 2009-04-06 Marek Safar <marek.safar@gmail.com>
1329 A fix for bug #492329
1330 * expression.cs (New): Load variable when assigning type parameter
1333 2009-04-06 Marek Safar <marek.safar@gmail.com>
1335 A fix for bug #488960
1336 * decl.cs: Compare MVAR types using non-null values.
1338 2009-03-27 Marek Safar <marek.safar@gmail.com>
1340 * typemanager.cs, expression.cs: Removed unused nullable checks.
1342 2009-03-27 Marek Safar <marek.safar@gmail.com>
1344 * *.cs: Removed some gmcs conditionals.
1346 2009-03-26 Marek Safar <marek.safar@gmail.com>
1348 * generic.cs, support.cs: Moved generics stuff out of support.cs
1350 2009-03-24 Marek Safar <marek.safar@gmail.com>
1352 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1355 2009-03-23 Marek Safar <marek.safar@gmail.com>
1357 * attribute.cs: Consider all members for error reporting when
1358 checking named arguments.
1360 2009-03-23 Marek Safar <marek.safar@gmail.com>
1362 A fix for bug #487625
1363 * namespace.cs: Use a warning for all predefined type conflicts.
1365 2009-03-23 Marek Safar <marek.safar@gmail.com>
1367 A fix for bug #485706
1368 * statement.cs: Explicitly type catch type argument to pass verifier
1371 2009-03-22 Miguel de Icaza <miguel@novell.com>
1373 Initial support to provide code completion facilities to consumers
1374 of the evaluator API.
1376 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1377 support the completion engine. When we reach the end of the
1378 input stream instead of returning EOF, when this flag is true the
1379 tokenizer instead produces:
1381 One GENERATE_COMPLETION token: this token then must be
1382 handled in the grammar at every point where the user
1383 would likely request a completion.
1385 As many COMPLETE_COMPLETION tokens as necessary. These
1386 tokens are generated to assist the parser in unwinding and
1387 producing a valid parse tree.
1389 The parser rules do not have to be perfect, the parser needs to be
1390 augmented with judicious use of GENERATE_COMPLETION tokens to
1391 improve the areas where we can provide completion and the parser
1392 needs to add support for COMPLETE_COMPLETION tokens in productions
1395 It is common to not have enough support for COMPLETE_COMPLETION
1396 under certain rules and that even if we generated the
1397 GENERATE_COMPLETION token that the resulting tree will be invalid
1398 due to the missing rules that support COMPLETE_COMPLETION.
1400 The final EOF token is produced by having the parser notify the
1401 tokenizer when it reaches the root production that the next token
1404 * support.cs (CompletionResult): New Exception. This exception
1405 is thrown to return the completion results when one of the special
1406 completion expressions is reached.
1408 This exception is thrown by the completing ExpressionStatements
1409 classes that live in complete.cs
1411 * complete.cs (CompletingExpression): a new base class for
1412 completing expressions. This derives from the
1413 ExpressionStatement class and not from Expression as it allows
1414 completion to happen not only where expressions are expected in
1415 the grammar, but also where statements are expected.
1417 (CompletionSimpleName): A new class used to provide completions
1418 for SimpleNames. This currently only resolves to local
1419 variables from the evaluator context (GetVars call).
1421 (CompletionMemberAccess): Implements support for completing member
1424 * cs-parser.jay: Add support for completion in a few places.
1426 * eval.cs (GetCompletions): New public API for the evaluator that
1427 returns a list of possible completions given the input. The
1428 return value is an array of completions
1430 * anonymous.cs (Compatible): If the exception thrown from the
1431 resolved expression is a CompletionResult exception let that one
1432 through instead of printing a diagnostic error in the try/catch.
1434 2009-03-22 Miguel de Icaza <miguel@novell.com>
1438 * driver.cs (Main): Use Environment.Exit to quit quickly and
1439 prevent the compiler from doing the usual wait for helper thread
1442 This is to prevent a slowdown that was reported by Gonzalo on
1445 2009-03-19 Marek Safar <marek.safar@gmail.com>
1447 * ecore.cs: Load build-in types directly instead of accessing
1450 2009-03-18 Marek Safar <marek.safar@gmail.com>
1452 * ecore.cs: Always use unbox.any when available.
1454 2009-03-18 Marek Safar <marek.safar@gmail.com>
1456 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1458 2009-03-17 Marek Safar <marek.safar@gmail.com>
1460 * generic.cs: Removed obsolete version of type inference.
1462 2009-03-16 Marek Safar <marek.safar@gmail.com>
1464 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1465 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1466 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1467 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1469 2009-03-11 Marek Safar <marek.safar@gmail.com>
1471 A fix for bug #482996
1472 * anonymous.cs: Make sure we are not infering return type when
1473 checking type compatibility.
1475 2009-03-11 Marek Safar <marek.safar@gmail.com>
1477 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1478 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1479 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1480 attributes in their own structure. Needed when accessing their
1481 properties before they are resolved.
1483 2009-03-09 Marek Safar <marek.safar@gmail.com>
1485 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1486 hashtable (~10x faster).
1488 * driver.cs: Removed wrong Reset.
1490 2009-03-08 Marek Safar <marek.safar@gmail.com>
1492 * class.cs: Use correct common base type for unmanaged delayed
1495 * rootcontext.cs: Wrap unhandled exception.
1497 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1499 Make SeekableStreamReader self-tuning and arbitrarily seekable
1500 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1502 (SeekableStreamReader.Position.set): Use it. Simplify logic
1503 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1504 buffer size when the stream needs to be re-read from the beginning.
1506 2009-03-05 Marek Safar <marek.safar@gmail.com>
1508 A fix for bug #480100
1509 * parameter.cs: A parameter is not hoisted when used directly as ET.
1511 2009-03-04 Marek Safar <marek.safar@gmail.com>
1513 * statement.cs: Fixed an issue when using variable is of interface
1516 2009-03-03 Marek Safar <marek.safar@gmail.com>
1518 A fix for bug #480319
1519 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1521 2009-03-03 Marek Safar <marek.safar@gmail.com>
1523 A fix for bug #480867
1524 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1525 expression to have no valid type.
1527 2009-03-03 Marek Safar <marek.safar@gmail.com>
1529 A fix for bug #481258
1530 * class.cs: Set extension method flag in partial container.
1532 2009-03-03 Marek Safar <marek.safar@gmail.com>
1534 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1536 * attribute.cs: Add sanity check.
1538 2009-02-27 Marek Safar <marek.safar@gmail.com>
1540 * class.cs: Add external constructor error.
1542 2009-02-26 Marek Safar <marek.safar@gmail.com>
1544 A fix for bug #475354
1545 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1546 correctly user defined nullable equality operators.
1548 2009-02-25 Marek Safar <marek.safar@gmail.com>
1550 A fix for bug #479532
1551 * expression.cs: Implement NewInitialize::AddressOf.
1553 2009-02-25 Marek Safar <marek.safar@gmail.com>
1555 A fix for bug #413633
1556 * expression.cs: Iterate all base class-constraint types.
1558 2009-02-24 Marek Safar <marek.safar@gmail.com>
1560 A fix for bug #479209
1561 * literal.cs: Mutate null underlying type.
1563 2009-02-24 Marek Safar <marek.safar@gmail.com>
1565 A fix for bug #476295
1566 * convert.cs: Avoid wrapping implicitly convertible reference type.
1568 2009-02-23 Marek Safar <marek.safar@gmail.com>
1570 * iterators.cs: Create MemberName correctly.
1572 2009-02-23 Marek Safar <marek.safar@gmail.com>
1574 A fix for bug #478655
1575 * literal.cs: Check also underlying null type conversion.
1577 2009-02-21 Marek Safar <marek.safar@gmail.com>
1579 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1581 2009-02-20 Marek Safar <marek.safar@gmail.com>
1583 A fix for bug #477447
1584 * statement.cs: Add reference to correct parent storey when this
1585 is accessible from deep children storey (more than 1 level).
1587 2009-02-19 Marek Safar <marek.safar@gmail.com>
1589 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1590 * class.cs: Define base type members before setting up member cache.
1592 2009-02-18 Marek Safar <marek.safar@gmail.com>
1594 A fix for bug #477378
1595 * nullable.cs, expression.cs, statement.cs: More precise null type
1598 2009-02-18 Marek Safar <marek.safar@gmail.com>
1600 A fix for bug #472805
1601 * typemanager.cs, namespace.cs: Import only visible extension method
1604 2009-02-18 Marek Safar <marek.safar@gmail.com>
1606 A fix for bug #476895
1607 * attribute.cs: Use correct resolve context for attribute type.
1609 2009-02-18 Marek Safar <marek.safar@gmail.com>
1611 A fix for bug #476266
1612 * anonymous.cs: Mutate multi-dimensional arrays.
1614 2009-02-18 Marek Safar <marek.safar@gmail.com>
1616 A fix for bug #476400
1617 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1619 2009-02-18 Marek Safar <marek.safar@gmail.com>
1621 A fix for bug #476811
1622 * generics.cs: Fixed null-literal check.
1624 2009-02-17 Marek Safar <marek.safar@gmail.com>
1626 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1627 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1628 messing with static variables.
1630 2009-02-16 Marek Safar <marek.safar@gmail.com>
1632 A fix for bug #475965
1633 * generics.cs: Check generic parameter type after extracting from
1636 2009-02-16 Marek Safar <marek.safar@gmail.com>
1638 A fix for bug #475823
1639 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1642 2009-02-14 Marek Safar <marek.safar@gmail.com>
1644 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1645 Simplified event field definition using backing field and not
1646 field builder directly.
1648 * expression.cs (EmitLdArg): Optimize fast paths.
1650 2009-02-13 Marek Safar <marek.safar@gmail.com>
1652 A fix for bug #475327
1653 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1655 2009-02-13 Marek Safar <marek.safar@gmail.com>
1657 A fix for bug #475342
1658 * cs-parser.jay: Using 'super' instead of 'base' to call base
1659 constructor crashes compiler.
1661 2009-02-13 Marek Safar <marek.safar@gmail.com>
1663 A fix for bug #475354
1664 * expression.cs (Constantify): Add nullable types.
1666 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1668 2009-02-12 Marek Safar <marek.safar@gmail.com>
1670 A fix for bug #475246
1671 * expression.cs: More broken flowanalysis hacking needed.
1673 2009-02-12 Marek Safar <marek.safar@gmail.com>
1675 * attribute.cs: Compare only ref/out array modifiers.
1677 2009-02-11 Marek Safar <marek.safar@gmail.com>
1679 * statement.cs: Use member cache when looking for foreach members.
1681 2009-02-11 Marek Safar <marek.safar@gmail.com>
1683 * expression.cs: Don't expose internal initializer types.
1685 * statement.cs: Check also explicit conversions for goto case.
1687 2009-02-11 Marek Safar <marek.safar@gmail.com>
1689 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1691 2009-02-10 Marek Safar <marek.safar@gmail.com>
1693 * *.cs: Replace null-type with NullLiteral where appropriate.
1695 2009-02-09 Marek Safar <marek.safar@gmail.com>
1697 * expression.cs: Initializer of reference argument use temporary
1698 variable to be verifiable.
1700 * parameter.cs: Share EmitLdArg.
1702 2009-02-09 Marek Safar <marek.safar@gmail.com>
1704 A fix for bug #473559
1705 * class.cs: Fixed: Not reporting error about nested class with the
1708 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1710 Contributed under the MIT/X11 license.
1712 * generic.cs: Added VerifyVariantTypeParameters which performs new
1713 variance verification logic. The old logic, based on the spec, was
1714 wrong because the spec is full of LIES!
1716 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1718 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1721 * ecore.cs: Added calls to the new variance verification logic.
1724 * delegate.cs: Removed calls to the old variance verification logic.
1726 2009-02-06 Marek Safar <marek.safar@gmail.com>
1728 * delegate.cs: Use cached Invoke method directly.
1730 2009-02-06 Marek Safar <marek.safar@gmail.com>
1732 * expression.cs: Emit expression tree for hoisted variable access.
1734 2009-02-04 Marek Safar <marek.safar@gmail.com>
1736 * namespace.cs: Add better extension class check.
1738 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
1740 * generic.cs: Fixed typeo (TypeParameter.Variacne).
1742 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
1744 This patch adds initial generic variance support to the compiler.
1745 It is contributed under the MIT/X11 license.
1747 * typemanager.cs: Modified ImplementsInterface to check variance.
1748 Added VerifyVariantTypeParameters which checks the specified type to see
1749 if it uses a variant type parameter as a type argument (which is not
1750 allowed). Added IsVariantOf which determins if the first type is a
1751 variant of the second. NOTE: This only supports reference types at
1752 the moment to conform with the current level of VM support. When the
1753 VM supports value types, this will follow step.
1755 * generic.cs: Added the Variance enum. Added a Variance property to
1756 TypeParameter and added variance support to definition phase. Added a
1757 Variance property to TypeParameterName. Also check to make sure that
1758 no variant types appear in generic method parameters.
1760 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
1761 keywords if the langversion supports it.
1763 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
1764 that variant types are only used in legal positions. Also added
1765 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
1768 * decl.cs: Construct TypeParameter with the variance information.
1770 * convert.cs: Checks variance in ImplicitReferenceConversionExists
1771 and ImplicitConversionStandard.
1773 * rootcontext.cs: Added new "Future" language version.
1775 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
1776 type parameters are not used as type arguments in interface inheritance.
1777 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
1778 parameters are not used as method return types. In MemberBase.
1779 ResolveMemberType, ensure that variant type parameters are not used
1780 as type arguments. Also call VerifyNoVariantTypeParameters on every
1781 set of parameters which are resolved.
1783 * delegate.cs: Modified Delegate.Define to ensure that variant
1784 parameters are not used as type arguments and that a contravariant
1785 parameter is not used as the return type. Also call
1786 VerifyNoVariantTypeParameters on the delegate parameters.
1788 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
1789 to specify generic variance.
1791 * driver.cs: Added support for LanguageVersion.Future in the form of
1792 "-langversion:future".
1794 * generic-mcs.cs: Stubbed out new members in generic.cs.
1796 2009-02-03 Marek Safar <marek.safar@gmail.com>
1798 * class.cs, generic.cs: Emit type parameter constraints for nested
1801 2009-02-02 Marek Safar <marek.safar@gmail.com>
1803 A fix for bug #471213
1804 * class.cs: Avoid emitting backing field for abstract event fields.
1806 2009-02-01 Marek Safar <marek.safar@gmail.com>
1808 A fix for bug #359731
1809 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
1812 2009-01-30 Marek Safar <marek.safar@gmail.com>
1814 A fix for bug #470767
1815 * statement.cs: Introduced BlockScopeExpression, needed when
1816 expression tree conversion has to emit scope variables.
1818 2009-01-29 Marek Safar <marek.safar@gmail.com>
1820 * class.cs: Remove duplicate CallingConvention.
1822 2009-01-29 Marek Safar <marek.safar@gmail.com>
1824 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
1825 when I finally found the right naming convention.
1827 2009-01-29 Marek Safar <marek.safar@gmail.com>
1829 * cs-tokenizer.cs: Put back different open parens optimization.
1831 2009-01-28 Marek Safar <marek.safar@gmail.com>
1833 A fix for bug #470227
1834 * cs-tokenizer.cs: Remove too agressive parser optimization.
1836 2009-01-28 Marek Safar <marek.safar@gmail.com>
1838 A fix for bug #324319
1839 * class.cs: Remove too early base type resolve.
1841 2009-01-27 Marek Safar <marek.safar@gmail.com>
1843 A fix for bug #324319
1844 * ecore.cs: Explicitly type null when assigning to type argument to
1845 make pass verifier check.
1847 2009-01-27 Marek Safar <marek.safar@gmail.com>
1849 * anonymous.cs: Fixed recent regression when initializing captured
1852 2009-01-26 Marek Safar <marek.safar@gmail.com>
1854 A fix for bug #469019
1855 * anonymous.cs: Use all parent type parameters when instantiating
1856 nested generic storey.
1858 2009-01-26 Marek Safar <marek.safar@gmail.com>
1860 * expression.cs: Check for null instance methodgroup expression.
1862 2009-01-26 Marek Safar <marek.safar@gmail.com>
1864 A fix for bug #469244
1865 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
1866 instance inside a conditional expression.
1868 2009-01-23 Marek Safar <marek.safar@gmail.com>
1870 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
1871 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
1872 GetElementType and HasElementType. IsValueType clean up.
1874 2009-01-23 Marek Safar <marek.safar@gmail.com>
1876 * nullable.cs: Use common EmitCall.
1878 * expression.cs: Emit constraint. for virtual calls only.
1880 2009-01-23 Marek Safar <marek.safar@gmail.com>
1882 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
1883 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
1884 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
1887 2009-01-22 Jb Evain <jbevain@novell.com>
1889 * anonymous.cs: make anonymous types' ToString implementation
1890 match what csc outputs.
1892 2009-01-21 Marek Safar <marek.safar@gmail.com>
1894 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
1897 2009-01-17 Marek Safar <marek.safar@gmail.com>
1899 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
1902 2009-01-16 Marek Safar <marek.safar@gmail.com>
1904 * nullable.cs (LiftedBinaryOperator): Check for all possible null
1907 2009-01-15 Marek Safar <marek.safar@gmail.com>
1909 A fix for bug #466634
1910 * statement.cs: Add reference for nested storey when only this
1913 2009-01-15 Marek Safar <marek.safar@gmail.com>
1915 A fix for bug #466474
1916 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
1919 2009-01-15 Marek Safar <marek.safar@gmail.com>
1921 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
1922 Fixed nested stories parent referencing process. Also fixes #463985.
1924 2009-01-06 Marek Safar <marek.safar@gmail.com>
1926 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
1927 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
1928 implementation. Also fixes #463108.
1930 2009-01-05 Marek Safar <marek.safar@gmail.com>
1932 A fix for bug #416109
1933 * decl.cs: Issue correct CLSAttribute warning location.
1935 2009-01-05 Marek Safar <marek.safar@gmail.com>
1937 A fix for bug #456775
1938 * attribute.cs: Use attribute owner scope when resolving attribute
1941 2009-01-05 Marek Safar <marek.safar@gmail.com>
1943 A fix for bug #457257
1944 * decl.cs: Fixed incorrect member declaring type comparison.
1946 2009-01-05 Marek Safar <marek.safar@gmail.com>
1948 A fix for bug #460896
1949 * driver.cs: Handle /RES resources as embeddable.
1951 2009-01-05 Marek Safar <marek.safar@gmail.com>
1953 A fix for bug #462515
1954 * ecore.cs: Report inacessible members upwards.
1956 2009-01-05 Marek Safar <marek.safar@gmail.com>
1958 A fix for bug #463190, #463192
1959 * decl.cs, namespace.cs: Also import internal extension classes.
1961 2009-01-04 Marek Safar <marek.safar@gmail.com>
1963 A fix for bug #463415
1964 * generic.cs: Use right index for RemoveDependentTypes.
1966 2009-01-02 Marek Safar <marek.safar@gmail.com>
1968 A fix for bug #463196
1969 * expression.cs: Fixed enum to null comparison.
1971 2009-01-02 Marek Safar <marek.safar@gmail.com>
1973 A fix for bug #463121
1974 * nullable.cs: Fixed nullable user equality operator comparison.
1976 2009-01-02 Marek Safar <marek.safar@gmail.com>
1978 A fix for bug #462950
1979 * class.cs, decl.cs: Use full explicit name when defining automatic
1980 property backing field.
1982 2009-01-02 Marek Safar <marek.safar@gmail.com>
1984 A fix for bug #462592
1985 * pending.cs: Emit type arguments for generic proxy method.
1987 2008-12-30 Marek Safar <marek.safar@gmail.com>
1989 * expression.cs (As): Mutate all type arguments.
1991 2008-12-29 Marek Safar <marek.safar@gmail.com>
1993 A fix for bug #462622
1994 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
1997 2008-12-29 Marek Safar <marek.safar@gmail.com>
1999 A fix for bug #450782
2000 * ecore.cs: Consider more variables of form V.I to be fixed.
2002 2008-12-29 Marek Safar <marek.safar@gmail.com>
2004 A fix for bug #460712
2005 * typemanager.cs: Core types could be imported.
2007 2008-12-28 Marek Safar <marek.safar@gmail.com>
2009 A fix for bugs #460847, #460772, #458049, #457339, #447807
2010 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2011 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2012 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2013 user lambdas used inside query clauses.
2015 2008-12-18 Marek Safar <marek.safar@gmail.com>
2017 A fix for bug #460229
2018 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2020 2008-12-18 Marek Safar <marek.safar@gmail.com>
2022 A fix for bug #459952
2023 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2025 2008-12-18 Marek Safar <marek.safar@gmail.com>
2027 A fix for bug #459630
2028 * convert.cs: Enum to valuetype conversion is not allowed.
2030 2008-12-18 Marek Safar <marek.safar@gmail.com>
2032 A fix for bug #457087
2033 * generic.cs: Don't crash when constraint comes from type
2036 2008-12-16 Marek Safar <marek.safar@gmail.com>
2038 A fix for bug #459221
2039 * anonymous.cs, statement.cs: Delay only captured this
2042 2008-12-12 Marek Safar <marek.safar@gmail.com>
2044 A fix for bug #457489
2045 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2046 and initialization to capture scope initializers correctly.
2048 2008-12-11 Marek Safar <marek.safar@gmail.com>
2050 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2051 ParameterReference refactoring.
2053 2008-12-03 Marek Safar <marek.safar@gmail.com>
2055 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2056 to be imported from any assembly.
2058 2008-12-03 Marek Safar <marek.safar@gmail.com>
2060 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2061 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2062 from anonymous method and lambda expression.
2064 2008-12-01 Marek Safar <marek.safar@gmail.com>
2066 A fix for bug #448560
2067 * expression.cs (As): Box any generic type arguments to be
2070 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2072 Add tripwire for implicit conversion bugs
2073 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2075 (MethodGroupExpr.OverloadResolve): Add sanity check between
2076 IsApplicable and VerifyArgumentsCompat.
2077 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2079 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2081 Fix build break in System.Data_test
2082 * convert.cs (ImplicitConversionExists): Move NullLiteral
2084 (ImplicitStandardConversionExists): ... here.
2086 2008-11-28 Marek Safar <marek.safar@gmail.com>
2088 * literal.cs: Emit correctly explicit null to nullable cast.
2090 2008-11-28 Marek Safar <marek.safar@gmail.com>
2092 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2095 2008-11-28 Marek Safar <marek.safar@gmail.com>
2097 A fix for bug #449005
2098 * convert.cs, nullable.cs: Use only one implicit nullable
2101 2008-11-27 Marek Safar <marek.safar@gmail.com>
2103 * convert.cs, literal.cs: More Convert cleanup is needed.
2105 2008-11-27 Marek Safar <marek.safar@gmail.com>
2107 * decl.cs, class.cs: Fixed misleading error message.
2109 2008-11-26 Marek Safar <marek.safar@gmail.com>
2111 A fix for bug #449005
2112 * nullable.cs (EmitEquality): Disable optimization for user operator
2115 2008-11-25 Marek Safar <marek.safar@gmail.com>
2117 A fix for bug #447027
2118 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2119 with context variables stored as expression instances.
2121 2008-11-25 Marek Safar <marek.safar@gmail.com>
2123 A fix for bug #447027
2124 * delegate.cs: Fixed delegate VerifyMethod logic.
2126 2008-11-24 Marek Safar <marek.safar@gmail.com>
2128 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2131 2008-11-21 Marek Safar <marek.safar@gmail.com>
2133 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2134 member type resolve to follow normal flow, instead of random
2137 2008-11-21 Marek Safar <marek.safar@gmail.com>
2139 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2142 2008-11-21 Marek Safar <marek.safar@gmail.com>
2144 * const.cs: Emit decimal array constant as literal.
2146 2008-11-20 Marek Safar <marek.safar@gmail.com>
2148 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2150 2008-11-19 Marek Safar <marek.safar@gmail.com>
2152 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2153 into real property (saves 8 MB for corlib compilation).
2155 2008-11-19 Marek Safar <marek.safar@gmail.com>
2157 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2158 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2159 generic-mcs.cs: Small cleanup of TypeArguments.
2161 2008-11-18 Marek Safar <marek.safar@gmail.com>
2163 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2164 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2165 of ConstructedType expression, renamed to GenericTypeExpr.
2167 2008-11-17 Marek Safar <marek.safar@gmail.com>
2169 A fix for bug #445303
2170 * location.cs (IsConditionalDefined): Handle undefined global
2173 2008-11-17 Marek Safar <marek.safar@gmail.com>
2175 A fix for bug #444678
2176 * expression.cs (TryReduceConstant): Always create new constant
2179 2008-11-17 Marek Safar <marek.safar@gmail.com>
2181 A fix for bug #444673
2182 * ecore.cs: Ignore open generic types when used as generic type
2185 2008-11-17 Marek Safar <marek.safar@gmail.com>
2187 A fix for bug #445458
2188 * expression.cs, cs-parser.jay: Don't crash when an expression
2191 2008-11-17 Marek Safar <marek.safar@gmail.com>
2193 A fix for bug #445464
2194 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2195 inside unbound type.
2197 2008-11-14 Jb Evain <jbevain@novell.com>
2199 * driver.cs: ignore empty -nowarn argument such as
2200 the one in -nowarn:12,13,,.
2202 2008-11-13 Marek Safar <marek.safar@gmail.com>
2204 A fix for bug #444271
2205 * anonymous.cs: Rescan parent storeys when best candidate was
2208 2008-11-13 Marek Safar <marek.safar@gmail.com>
2210 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2211 useless UnboundTypeExpression.
2213 * attribute.cs: Do check obsolete attribute on generic types.
2215 2008-11-12 Marek Safar <marek.safar@gmail.com>
2217 A fix for bugs #425680, #400139
2218 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2221 2008-11-11 Marek Safar <marek.safar@gmail.com>
2223 A fix for bug #435747
2224 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2225 compound value types assignment. Few micro optimizations added.
2227 2008-11-10 Marek Safar <marek.safar@gmail.com>
2229 A fix for bug #442610
2230 * anonymous.cs (MutateConstructor): More SRE hacking.
2232 2008-11-10 Marek Safar <marek.safar@gmail.com>
2234 A fix for bug #442579
2235 * ecore.cs: Also initialize expanded form of a method with 1 params
2238 2008-11-06 Marek Safar <marek.safar@gmail.com>
2240 * expression.cs (UnaryMutator): Do early l-side check.
2242 2008-11-05 Miguel de Icaza <miguel@novell.com>
2244 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2245 Init, otherwise we would crash later on when checking for friend
2248 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2249 Otherwise we never get any meaningful information as to what
2252 2008-11-05 Marek Safar <marek.safar@gmail.com>
2254 A fix for bug #436318
2255 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2257 2008-11-05 Miguel de Icaza <miguel@novell.com>
2259 * namespace.cs: Turns out that it was a really bad idea to hide
2260 the errors for namespaces not found here in eval mode.
2262 * eval.cs: When we process using clauses, only enter those into
2263 the list of valid using clauses after they have been validated.
2265 The above change gives the proper semantics: it does not
2266 senselessly report the same errors with broken using statements by
2267 never storing them in the first place when they are invalid.
2269 2008-11-05 Marek Safar <marek.safar@gmail.com>
2271 A fix for bug #421839
2272 * cs-parser.jay: Remove expression from coalesce rule to force lower
2273 priority than the assignment operator.
2275 2008-11-05 Marek Safar <marek.safar@gmail.com>
2277 A fix for bug #437875
2278 * nullable.cs: Compile correctly method group operand used with null
2279 coalescing operator.
2281 2008-11-04 Marek Safar <marek.safar@gmail.com>
2283 A fix for bug #434589
2284 * expression.cs (Binary): Ignore lifted conversions when at least
2285 one operand is of reference type.
2287 2008-11-04 Marek Safar <marek.safar@gmail.com>
2289 * cs-parser.jay: Better syntax error report.
2291 2008-11-03 Marek Safar <marek.safar@gmail.com>
2293 A fix for bug #436792
2294 * cs-parser.jay: Use GetLocation to access location.
2296 2008-11-03 Marek Safar <marek.safar@gmail.com>
2298 A fix for bug #440774
2299 * cs-parser.jay: Also set current_array_type when parsing local
2302 2008-11-03 Marek Safar <marek.safar@gmail.com>
2304 A fix for bug #440785
2305 * expression.cs (As): Don't resolve self modifing expression
2308 2008-11-03 Marek Safar <marek.safar@gmail.com>
2310 A fix for bug #439447
2311 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2313 2008-11-03 Marek Safar <marek.safar@gmail.com>
2315 A fix for bug #437571
2316 * cs-parser.jay: Fixes internal error for invalid expression
2319 2008-10-17 Marek Safar <marek.safar@gmail.com>
2321 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2323 2008-10-17 Marek Safar <marek.safar@gmail.com>
2325 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2327 2008-10-17 Marek Safar <marek.safar@gmail.com>
2329 * cs-tokenizer.cs: More precise cast parsing.
2331 2008-10-16 Martin Baulig <martin@ximian.com>
2333 * anonymous.cs (AnonymousMethodStorey): Put back the
2334 `hoisted_locals' hashtable and use it in EmitType().
2336 2008-10-15 Marek Safar <marek.safar@gmail.com>
2338 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2339 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2342 2008-10-14 Marek Safar <marek.safar@gmail.com>
2344 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2346 2008-10-14 Marek Safar <marek.safar@gmail.com>
2348 * statement.cs: Mutate scope initializers.
2350 2008-10-14 Marek Safar <marek.safar@gmail.com>
2352 * expression.cs: Use typeless value for This constant.
2354 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2356 2008-10-14 Marek Safar <marek.safar@gmail.com>
2358 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2361 2008-10-13 Marek Safar <marek.safar@gmail.com>
2363 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2366 2008-10-13 Marek Safar <marek.safar@gmail.com>
2368 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2369 parser and tokenizer. Fixes many ambiguities including #433258.
2371 2008-10-10 Marek Safar <marek.safar@gmail.com>
2373 * cs-parser.jay: Fixed missing accessor recovery.
2375 2008-10-10 Marek Safar <marek.safar@gmail.com>
2377 A fix for bug #433701
2378 * expression.cs: Better error message.
2380 2008-10-10 Marek Safar <marek.safar@gmail.com>
2382 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2384 * Makefile: Disabled unused debug symbols.
2386 Also fixes: #320556, #321097, #321656, #321876, #351316
2388 2008-10-09 Miguel de Icaza <miguel@novell.com>
2390 * eval.cs: rename "<interactive>" to "{interactive}", to work
2391 around a requirement in the compiler that this be a valid
2392 filename, and in Windows it is not (433886).
2394 2008-10-09 Marek Safar <marek.safar@gmail.com>
2396 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2398 2008-10-08 Marek Safar <marek.safar@gmail.com>
2400 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2401 cs-parser.jay: Generic type declaration and type arguments cleanup.
2403 2008-10-05 Marek Safar <marek.safar@gmail.com>
2405 * cs-parser.jay: Allow parsing weird array creation construct.
2407 2008-10-05 Marek Safar <marek.safar@gmail.com>
2409 * cs-parser.jay: Conflicts reduction.
2411 2008-10-04 Marek Safar <marek.safar@gmail.com>
2413 * cs-parser.jay: Conflicts reduction.
2415 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2418 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2419 property. Add a 'count' hint about the use of the shared vector.
2420 Ensure that we don't leak out dirty bits.
2421 (UsageVector.MergeChild): Throw away information about variables
2423 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2425 2008-10-03 Marek Safar <marek.safar@gmail.com>
2427 A fix for bug #431746
2428 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2429 parameters when iterator is created.
2431 2008-10-03 Marek Safar <marek.safar@gmail.com>
2433 A fix for bug #431827
2434 * expression.cs: Fixed right based pointer arithmetic operations
2437 2008-10-03 Marek Safar <marek.safar@gmail.com>
2439 A fix for bug #353779
2440 * assign.cs, expression.cs: Fixed compound assignment conversions.
2442 2008-10-02 Marek Safar <marek.safar@gmail.com>
2444 A fix for bug #375262
2445 * statement.cs: Refactor ArrayForeach to be usable with string
2446 indexer. Optimized single dimentional arrays foreach.
2448 2008-10-02 Marek Safar <marek.safar@gmail.com>
2450 A fix for bug #431255
2451 * anonymous.cs, expression.cs: Removed broken optimization.
2453 2008-10-01 Marek Safar <marek.safar@gmail.com>
2455 * anonymous.cs: Use full type parameters of parent generic
2456 containers. Removed unnecessary AddParentStoreyReference call.
2458 2008-10-01 Marek Safar <marek.safar@gmail.com>
2460 A fix for bug #324702
2461 * class.cs: Use better shorter names for explicit interface member
2464 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2466 2008-10-01 Marek Safar <marek.safar@gmail.com>
2468 * expression.cs: Use new interface to check fixed expression.
2470 2008-10-01 Marek Safar <marek.safar@gmail.com>
2472 A fix for bug #421101
2473 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2474 interface to check for fixed fixed-buffers.
2476 2008-10-01 Marek Safar <marek.safar@gmail.com>
2478 A fix for bug #429264
2479 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2481 * delegate.cs: Removed unnecessary casts.
2483 2008-09-30 Marek Safar <marek.safar@gmail.com>
2485 A fix for bug #352151
2486 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2487 class.cs: Fixed already defined explicit interface members check.
2489 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2491 cs-tokenizer.cs: Fix typo.
2493 2008-09-28 Miguel de Icaza <miguel@novell.com>
2495 * eval.cs (InteractiveBase): The quit command now just sets a
2496 flag, instead of calling Environment.Exit(), it is milder on
2499 CompiledMethod is now in Mono.CSharp, not nested inside
2500 the Evaluator, it was inconvenient to use.
2502 2008-09-27 Miguel de Icaza <miguel@novell.com>
2504 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2505 code to be invoked without having to reparse.
2507 2008-09-27 Miguel de Icaza <miguel@novell.com>
2509 * ecore.cs: The recent changes to FieldExpr broke this as well.
2510 Fixes LINQ queries in the interactive shell.
2512 * Multiple files: indentation fixing for the Mono coding
2513 guidelines for the switch statement.
2515 * eval.cs: Make the Evaluator API thread safe.
2517 2008-09-26 Marek Safar <marek.safar@gmail.com>
2519 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2520 constructor parsing.
2522 2008-09-26 Marek Safar <marek.safar@gmail.com>
2524 A fix for bug #325326
2525 * statement.cs: Check possible mistaken empty statement using
2526 explicit blocks only.
2528 2008-09-25 Miguel de Icaza <miguel@novell.com>
2530 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2531 RootNamespace.ComputeNamespaces to update the internal list of
2532 namespaces, this is no longer done for us.
2534 (InteractiveBase): Use the Evaluator APIs instead of calling into
2537 2008-09-25 Marek Safar <marek.safar@gmail.com>
2539 A fix for bug #429264
2540 * expression.cs: Missing mutator for access to multidimensional
2543 2008-09-25 Marek Safar <marek.safar@gmail.com>
2545 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2548 * driver.cs: Missing input argument check.
2550 2008-09-25 Marek Safar <marek.safar@gmail.com>
2552 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2553 expression.cs, statement.cs, rootcontext.cs, class.cs,
2554 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2557 2008-09-24 Miguel de Icaza <miguel@novell.com>
2559 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2560 fully constructed FieldExpr, fixes the regression introduced in
2563 * ecore.cs, expression.cs: Plug back the eclass initialization as
2564 otherwise it regresses `csharp'.
2566 2008-09-24 Marek Safar <marek.safar@gmail.com>
2568 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2569 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2570 phase to resolve phase. It resolves problems with expression trees
2571 and fixes bugs #323796, #325156.
2573 2008-09-23 Marek Safar <marek.safar@gmail.com>
2575 * codegen.cs: Report better error when symbol writer is missing.
2577 2008-09-23 Marek Safar <marek.safar@gmail.com>
2579 * codegen.cs: Set .NET symbol writer.
2581 * decl.cs: Guard against null generic arguments.
2583 * report.cs: Don't report exactly same additional details.
2585 2008-09-22 Marek Safar <marek.safar@gmail.com>
2587 A fix for bug #324917
2588 * cs-parser.jay: Add missing multidimensional non-expression type
2591 2008-09-22 Marek Safar <marek.safar@gmail.com>
2593 A fix for bug #428191
2594 * anonymous.cs: Create an outer generic fields also for non-storey
2597 2008-09-22 Marek Safar <marek.safar@gmail.com>
2599 A fix for bug #378294
2600 * class.cs: Make fixed size buffers gmcs feature only.
2602 2008-09-22 Marek Safar <marek.safar@gmail.com>
2604 A fix for bug #355622, #324993
2605 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2608 2008-09-19 Marek Safar <marek.safar@gmail.com>
2610 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2613 2008-09-19 Marek Safar <marek.safar@gmail.com>
2615 A fix for bug #416110
2616 * generic.cs: Struct constraint results in default ctor and
2617 ValueType base type constraint to be set.
2619 2008-09-19 Marek Safar <marek.safar@gmail.com>
2621 A fix for bug #423791
2622 * generic.cs: Fixed params output type type-inference.
2624 2008-09-19 Marek Safar <marek.safar@gmail.com>
2626 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2628 2008-09-19 Marek Safar <marek.safar@gmail.com>
2630 * cs-tokenizer.cs: Don't break on extra partial modifier.
2632 2008-09-19 Marek Safar <marek.safar@gmail.com>
2634 A fix for bug #427592
2635 * generic.cs: Use common parameter resolve method.
2637 2008-09-18 Marek Safar <marek.safar@gmail.com>
2639 A fix for bug #414758
2640 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2643 2008-09-18 Marek Safar <marek.safar@gmail.com>
2645 * driver.cs, namespace.cs: Read types and namespaces after all
2646 requested assemblies are loaded, fixes issues with System.Core
2647 auto-reference, and #419888.
2649 2008-09-18 Marek Safar <marek.safar@gmail.com>
2651 A fix for bug #417705
2652 * cs-parser.jay: Fixed as/is operator expression split.
2654 2008-09-18 Marek Safar <marek.safar@gmail.com>
2656 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2657 Fixed expression tree representation of empty new expression and
2658 new initializer expression.
2660 2008-09-18 Miguel de Icaza <miguel@novell.com>
2662 * eval.cs: Remove warning, keep reference to driver around.
2664 * Hide fields that do not need to be public.
2666 2008-09-17 Marek Safar <marek.safar@gmail.com>
2668 A fix for bug #426385
2669 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2670 conversion for array elements.
2672 2008-09-17 Marek Safar <marek.safar@gmail.com>
2674 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2675 void parsing conflicts.
2677 2008-09-15 Marek Safar <marek.safar@gmail.com>
2679 A fix for bug #425601
2680 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2681 System.Core only when there is no custom ExtensionAttribute
2684 2008-09-15 Miguel de Icaza <miguel@novell.com>
2686 * namespace.cs: Do not report CS0246 (name
2688 2008-09-12 Marek Safar <marek.safar@gmail.com>
2690 A fix for bug #425669
2691 * generic.cs: Don't cache generic static anonymous method
2694 2008-09-12 Marek Safar <marek.safar@gmail.com>
2696 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2697 conflicting constraints.
2699 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2701 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2704 2008-09-12 Marek Safar <marek.safar@gmail.com>
2706 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2707 to null pointer conversion fixes.
2709 2008-09-11 Marek Safar <marek.safar@gmail.com>
2711 * cs-parser.jay, expression.cs: An implicitly typed local variable
2712 declarator cannot use an array initializer.
2714 2008-09-11 Marek Safar <marek.safar@gmail.com>
2716 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2718 2008-09-11 Marek Safar <marek.safar@gmail.com>
2720 * generic.cs (InflatedConstraints): Don't crash when constraints
2723 * cs-parser.jay: const_declarator is a block.
2725 * constant.cs: Check for not allowed NaN conversions.
2727 2008-09-10 Miguel de Icaza <miguel@novell.com>
2729 * driver.cs: Drop --shell argument, the compiler is no longer a
2732 * eval.cs: Move most of the code that deals with evaluation into
2733 this file and document the public API from repl.cs
2735 * repl.cs: Remove from here.
2737 2008-09-10 Marek Safar <marek.safar@gmail.com>
2739 A fix for bug #424684
2740 * generic.cs: Generic class constraints must come first.
2742 2008-09-09 Miguel de Icaza <miguel@novell.com>
2744 * cs-parser.jay: Improve error reporting for syntax errors in
2745 statements and expressions, we now report the expected tokens
2746 instead of reporting the useless "; expected".
2748 Drop the strings from the token declaration, it turns out that
2749 they did not do what I thought they did. Instead they were adding
2750 two sets of tokens to the tables.
2752 2008-09-09 Marek Safar <marek.safar@gmail.com>
2754 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
2755 delegate.cs: Share special type check.
2757 2008-09-09 Marek Safar <marek.safar@gmail.com>
2759 A fix for bug #423981
2760 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
2762 2008-09-09 Marek Safar <marek.safar@gmail.com>
2764 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
2767 2008-09-09 Marek Safar <marek.safar@gmail.com>
2769 A fix for bugs: #324750, #335946
2770 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
2771 lookup rule to determine ?-based tokens.
2773 2008-09-08 Miguel de Icaza <miguel@novell.com>
2775 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
2776 expressions (like event adding or removing) end up here, so we
2777 need to treat those as statements.
2779 Add LoadAssembly method.
2781 2008-09-04 Miguel de Icaza <miguel@novell.com>
2783 * repl.cs: Add Time method.
2785 2008-09-05 Marek Safar <marek.safar@gmail.com>
2787 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
2789 2008-09-05 Miguel de Icaza <miguel@novell.com>
2791 * repl.cs: Add workaround for old compilers.
2793 2008-09-04 Jb Evain <jbevain@novell.com>
2795 * repl.cs (PrettyPrint): pretty print everything that
2796 implements IDictionary, as well as IEnumerables. Also,
2797 add a quit helper property.
2799 2008-09-04 Marek Safar <marek.safar@gmail.com>
2801 * constant.cs: Better error reporting for decimal literals.
2803 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
2806 2008-09-04 Marek Safar <marek.safar@gmail.com>
2807 Miguel de Icaza <miguel@novell.com>
2809 A fix for bug #422951
2810 * assign.cs (Assign.DoResolve): Perform the type conversions
2811 checks before we attempt to initialize `New' initializers.
2813 2008-09-04 Marek Safar <marek.safar@gmail.com>
2815 A fix for bug #422853
2816 * delegate.cs (DelegateCreation): Add special handling for
2817 EmptyExpression.Null instance expression which is just another
2818 hack for undecided member instance exression.
2820 2008-09-04 Marek Safar <marek.safar@gmail.com>
2822 * expression.cs, ecore.cs: Emit full expression tree for reduced
2825 2008-09-04 Marek Safar <marek.safar@gmail.com>
2827 * expression.cs (This): Guard against multi-resolving.
2829 * ecore.cs, statement.cs (Throw): Simplified.
2831 * flowanalysis.cs: Also verify event fields.
2833 2008-09-04 Miguel de Icaza <miguel@novell.com>
2835 * assign.cs (Assign.DoResolve): Perform the type conversions
2836 checks before we attempt to initialize `New' initializers.
2838 * repl.cs (PrettyPrint): Add Hashtable prettyprint
2840 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
2843 * repl.cs: Update help.
2845 2008-09-03 Miguel de Icaza <miguel@novell.com>
2847 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
2848 handling of the default config handling, including the special
2849 treatment of System.Core assembly.
2851 Fixes the REPL processing for LINQ.
2853 2008-09-03 Marek Safar <marek.safar@gmail.com>
2855 A fix for bug #422507
2856 * expression.cs (UnboxCast): Add missing child expression mutator.
2858 2008-09-03 Marek Safar <marek.safar@gmail.com>
2860 * driver.cs: Don't self reference System.Core assembly.
2862 2008-09-03 Marek Safar <marek.safar@gmail.com>
2864 A fix for bug #422507
2865 * expression.cs (StringConcat): Add missing type mutator.
2867 2008-09-03 Marek Safar <marek.safar@gmail.com>
2869 * generic.cs (TypeInferenceContext): Follow equality rule for
2870 constructed type lower bound type inference.
2872 2008-09-02 Miguel de Icaza <miguel@novell.com>
2874 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
2875 <dblank@cs.brynmawr.edu> which updates the cursor position on
2878 2008-09-02 Marek Safar <marek.safar@gmail.com>
2880 A fix for bug #367145
2881 * driver.cs: Fixed import of extension methods when using -noconfig
2884 2008-09-02 Marek Safar <marek.safar@gmail.com>
2886 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
2887 version from non-generic implementation instead.
2889 2008-09-01 Marek Safar <marek.safar@gmail.com>
2891 A fix for bug #418908
2892 * class.cs: Use AddScopeStatement for field initializers.
2894 2008-09-01 Marek Safar <marek.safar@gmail.com>
2896 A fix for bug #415385
2897 * ecore.cs, convert.cs: Do method group conversion for equal group types.
2899 2008-09-01 Marek Safar <marek.safar@gmail.com>
2901 A fix for bug #421736
2902 * iterators.cs: Don't crash on unreachable iterators.
2904 2008-09-01 Marek Safar <marek.safar@gmail.com>
2906 A fix for bug #421628
2907 * parameter.cs, attribute.cs: Clone also parameter attributes.
2909 2008-08-30 Miguel de Icaza <miguel@novell.com>
2911 * namespace.cs (LookupType): In EvalMode, try to replace
2912 the TypeBuilder from our cache with a Type as Reflection.Emit does
2913 not like to mix code from older assemblies emitted and new
2916 This sounds like a serious Mono bug that prevents multiple
2917 assemblies to be generated and consumed at the same time.
2919 * cs-parser.jay (push_current_class): Do not make interactive
2920 classes internal or private, make them public as we currently
2921 generate each new class in a new assembly.
2923 2008-08-29 Miguel de Icaza <miguel@novell.com>
2925 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
2926 remove types that are entered into the global namespace during
2927 parsing so that we can remove them on failure.
2929 * cs-parser.jay: Parsing: we now keep track of types that are
2930 entered into global variables and queue those in case the parsing
2933 This happens in a few situations: during partial-input, we invoke
2934 the parser repeatedly for example with the string "class X", this
2935 would cause X to be registed, and we need to remove this
2936 registration so that another parse attempt later with say "class X {"
2937 would actually work.
2939 Additionally, if there is an error in the resolution phase, for
2940 example: "class X : NonExistant {}" th
2942 * cs-parser.jay: Be more precise with the errors being raised,
2943 instead of flagging all exceptions during parsing to be attributed
2944 to the parsing process, distinguish those from errors happening in
2945 the actions and hint that using -v would produce the actual
2948 * repl.cs: Do not load all compiler references on each reset,
2949 doing the partial reset takes care of this.
2951 2008-08-28 Miguel de Icaza <miguel@novell.com>
2953 * repl.cs: Add support for loading all the files from
2954 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
2957 Introduce a micro-parser that is able to deambiguate on its input
2958 whether we are dealing with a compilation unit (namespace, class,
2959 interface, struct, delegate) declaration or a statement. This
2960 allows both declarations and statements to be entered.
2962 Set history size by default to 300 lines.
2964 Instead of distinguishing based on the parser.InteractiveResult,
2965 have only two cases: statements were parsed, or a compilation unit
2966 was. Always pull the Using statement additions from the
2967 compilation unit parse.
2969 * cs-tokenizer.cs: Rename tokens to better describe their intent
2970 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
2972 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
2973 EvalMode is used to trigger the lookup of global variables while
2974 StatementMode is used turn variable declarations into static
2977 * getline.cs: Allow history size to be set.
2979 2008-08-29 Marek Safar <marek.safar@gmail.com>
2981 A fix for bug #360755
2982 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
2984 2008-08-29 Marek Safar <marek.safar@gmail.com>
2986 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
2988 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
2989 member name, it is too confusing
2991 * decl.cs, class.cs: Don't report unused fields with attached attribute.
2993 * rootcontext.cs: Finally default to warning level 4.
2995 2008-08-28 Marek Safar <marek.safar@gmail.com>
2997 * class.cs (CheckBase): Ignore overloaded operators.
2999 2008-08-28 Marek Safar <marek.safar@gmail.com>
3001 A fix for bug #420830
3002 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3004 2008-08-28 Marek Safar <marek.safar@gmail.com>
3006 A fix for bug #420832
3007 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3009 2008-08-28 Marek Safar <marek.safar@gmail.com>
3011 A fix for bug #420386
3012 * nullables.cs: Fixed logic of nullable user comparison operators involving
3015 2008-08-28 Marek Safar <marek.safar@gmail.com>
3017 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3019 2008-08-27 Miguel de Icaza <miguel@novell.com>
3021 * repl.cs: Add support for aborting the running code with C-c.
3023 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3025 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3027 2008-08-27 Miguel de Icaza <miguel@novell.com>
3029 * cs-parser.jay (interactive_statement_list): A new set of rules
3030 for hosting statements that uses the "interactive_" prefix.
3032 * repl.cs: Add support for parsing `using' as a statement or as a
3033 directive. Deambiguating before passing this to the parser.
3035 We need to distinguish statement_expressions that occur at the
3036 toplevel vs those that occur embedded into expressions.
3038 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3039 that fixes the cursor key handling, and a history bug.
3041 2008-08-26 Miguel de Icaza <miguel@novell.com>
3043 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3044 limitations in Console, instead the 2.0 bootstrap libraries now
3045 include the Console bits.
3047 Also, remove the use of Nullables from getline.cs
3051 Interactive support for the C# compiler. Use gmcs --shell to
3052 enter a read-eval-print loop shell.
3054 Docs: http://www.mono-project.com/CsharpRepl
3056 * sources: include repl.cs here and getline.cs for gmcs.exe,
3057 everything else is getline.cs impaired.
3059 * Makefile: when bootstrapping pass a special flag
3060 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3061 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3062 This distinguishes those two cases.
3064 * repl.cs: Support for a read-eval-print loop. Will be soon
3065 refactored into eval support and then REPL on top of it.
3067 * ecore.cs: If a simplename lookup fails, before erroring out,
3068 if we are in EvalMode to resolve the name to a declaration in the
3071 This means that variable declarations that happened in previous
3072 classes (as repl puts every statement in a separate class) are
3073 made visible in this way.
3075 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3076 triggered an error due to the end of file being reached. This is
3077 used to do multi-line input, and notify the caller that the user
3078 needs to provide more text before a successful parse.
3080 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3081 to drive the evaluation with a custom wrapper.
3083 * driver.cs: Add support for --shell, and refactor some code to be
3086 * namespace.cs: Add support for serializing the contents of the
3087 namespaces and reloading them.
3089 * getline.cs: A managed implementation of ReadLine under
3090 X11/Apache2 license terms. Easy to embed in other applications as
3093 * namespace.cs: Add some functions to save and restore the
3096 * rootcontext.cs: New public field.
3098 * cs-tokenizer.cs: Add support for one of the possible characters
3099 we introduce into the token stream.
3101 This patch does not affect the regular tokenization process, the
3102 only performance hit would happen if there is an invalid character
3103 on the input string.
3105 * support.cs: Move isatty helper routine here.
3107 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3108 code generator for in-memory assemblies.
3110 2008-08-26 Marek Safar <marek.safar@gmail.com>
3112 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3113 parameter cannot be always used as a type.
3115 2008-08-21 Marek Safar <marek.safar@gmail.com>
3117 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3119 2008-08-21 Marek Safar <marek.safar@gmail.com>
3121 * convert.cs: Implement explicit array to IList<T> conversion.
3123 2008-08-20 Marek Safar <marek.safar@gmail.com>
3125 A fix for bug #362740
3126 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3128 2008-08-20 Marek Safar <marek.safar@gmail.com>
3130 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3131 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3132 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3133 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3134 handling to use just one type of infrastructure and deal with generics
3137 2008-07-23 Martin Baulig <martin@ximian.com>
3139 *** Merged this from trunk revision 108527 ***
3142 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3143 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3146 2008-08-15 Marek Safar <marek.safar@gmail.com>
3148 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3151 2008-08-15 Marek Safar <marek.safar@gmail.com>
3153 * delegate.cs: Fixed compiler crash when creating delegate using partial
3156 * typemanager.cs: MulticastDelegate is not a delegate.
3158 2008-08-14 Marek Safar <marek.safar@gmail.com>
3160 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3163 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3165 * cs-parser.jay (type): Allow 'var' in mcs too.
3166 (local_variable_type): Likewise.
3168 2008-08-14 Marek Safar <marek.safar@gmail.com>
3170 * driver.cs: Removed broken -noconfig variants.
3172 2008-08-14 Marek Safar <marek.safar@gmail.com>
3174 A fix for bug #417078
3175 * expression.cs: Emit correctly left side pointer operators.
3177 2008-08-13 Marek Safar <marek.safar@gmail.com>
3179 * generic.cs, lambda.cs: Inflate method generic arguments only.
3181 2008-08-12 Marek Safar <marek.safar@gmail.com>
3183 * class.cs: Fixed struct layout check regression.
3185 2008-08-12 Marek Safar <marek.safar@gmail.com>
3187 * cs-parser.jay, enum.cs: Simplified enum parsing.
3189 * decl.cs: Check all type parameters conflicts.
3191 * expression.cs, statement.cs, attribute.cs: More expression checks.
3193 2008-08-11 Marek Safar <marek.safar@gmail.com>
3195 * generic.cs: Add type inference types restriction.
3197 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3198 anonymous.cs, expression.cs: Allocate less accessor parameters.
3200 2008-08-08 Marek Safar <marek.safar@gmail.com>
3202 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3205 2008-08-08 Marek Safar <marek.safar@gmail.com>
3207 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3209 2008-08-07 Marek Safar <marek.safar@gmail.com>
3211 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3212 Also fixes #362146 and #381592.
3214 2008-08-07 Marek Safar <marek.safar@gmail.com>
3216 * ecore.cs: Reduced constant cannot be used as an attribute value.
3218 * cs-parser.jay: Base expression has to be a type.
3220 * expression.cs (Conditional): Uses ReducedExpression.
3222 2008-08-06 Marek Safar <marek.safar@gmail.com>
3224 A fix for bug #376826
3225 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3226 address of hoisted local variable or parameter cannot be taken.
3228 2008-08-05 Marek Safar <marek.safar@gmail.com>
3230 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3231 anonymous method inside checked/unchecked expression.
3233 2008-08-05 Marek Safar <marek.safar@gmail.com>
3235 * typemanager.cs (IsEqual): Guard against null.
3237 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3238 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3239 routine. Fixed few misleading conversion errors.
3241 2008-08-04 Marek Safar <marek.safar@gmail.com>
3243 * class.cs: Consider generics when checking cycles in struct layout.
3245 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3247 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3249 2008-08-04 Marek Safar <marek.safar@gmail.com>
3251 A fix for bug #414165
3252 * anonymous.cs: Use same anonymous implementation method for all anonymous
3255 2008-08-04 Marek Safar <marek.safar@gmail.com>
3257 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3260 2008-08-04 Marek Safar <marek.safar@gmail.com>
3262 * cs-parser.jay: Typeof argument has to be a type expression.
3264 * namespace.cs: Check alias and namespace definitions collisions.
3266 * class.cs, pending.cs: Moved explicit interface accessor implementation
3269 * delegate.cs, expression.cs: Verify special name invocations.
3271 2008-08-01 Marek Safar <marek.safar@gmail.com>
3273 * cs-parser.jay: Don't choke on empty generic type arguments.
3275 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3277 * expression.cs, ecore.cs: Minor expressions bugs.
3279 2008-08-01 Marek Safar <marek.safar@gmail.com>
3281 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3282 and added more error handling.
3284 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3286 * modifiers.cs, enum.cs: Fixed.
3288 2008-07-31 Jb Evain <jbevain@novell.com>
3290 * driver.cs: remove -pkg ability of smcs.
3292 2008-07-30 Marek Safar <marek.safar@gmail.com>
3294 * statement.cs (Switch): Correctly set empty default target for single
3297 2008-07-30 Marek Safar <marek.safar@gmail.com>
3299 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3300 string switch statement implementation to use string dictionary which
3301 significantly (2-8x) improves performance of generated code.
3303 2008-07-29 Marek Safar <marek.safar@gmail.com>
3305 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3306 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3308 2008-07-29 Marek Safar <marek.safar@gmail.com>
3310 A fix for bug #412595
3311 * typemanager.cs, convert.cs, expression.cs: Some types are never
3312 convertible to each other.
3314 2008-07-29 Marek Safar <marek.safar@gmail.com>
3316 * nullable.cs (CreateNullConstant): An error messages update.
3318 2008-07-29 Marek Safar <marek.safar@gmail.com>
3320 A fix for bug #412595
3321 * cfold.cs: Don't cast undefined bool constant.
3323 2008-07-29 Martin Baulig <martin@ximian.com>
3326 (SymbolWriter.Reset): New public static method.
3329 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3331 2008-07-28 Marek Safar <marek.safar@gmail.com>
3333 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3335 * expression.cs (ElementAccess): Exact size allocation.
3337 2008-07-26 Marek Safar <marek.safar@gmail.com>
3339 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3341 2008-07-25 Marek Safar <marek.safar@gmail.com>
3343 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3345 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3348 2008-07-25 Marek Safar <marek.safar@gmail.com>
3350 A fix for bug #412217
3351 * assign.cs: Mutate also assignment type.
3353 2008-07-25 Marek Safar <marek.safar@gmail.com>
3355 A fix for bug #323644
3356 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3359 2008-07-25 Marek Safar <marek.safar@gmail.com>
3361 A fix for bug #412134
3362 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3363 non-enumerable operands when overloading equality or bitwise operators.
3365 2008-07-25 Marek Safar <marek.safar@gmail.com>
3367 * anonymous.cs: Cache closed generic anonymous method delegates.
3369 2008-07-24 Marek Safar <marek.safar@gmail.com>
3371 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3372 anonymous.cs, statement.cs: Always emit anonymous method as static method
3373 when is instance free. Use nesting for nested anynomous methods blocks.
3375 2008-07-23 Marek Safar <marek.safar@gmail.com>
3377 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3380 2008-07-23 Marek Safar <marek.safar@gmail.com>
3382 * expression.cs: Removed MakeSimpleCall.
3384 2008-07-23 Marek Safar <marek.safar@gmail.com>
3386 A fix for bug #323012
3387 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3388 Base method implementing interface has to be public.
3390 2008-07-23 Marek Safar <marek.safar@gmail.com>
3392 * cs-parser.jay: Don't break on missing argument.
3394 2008-07-22 Marek Safar <marek.safar@gmail.com>
3396 A fix for bug #320993
3397 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3398 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3400 2008-07-22 Marek Safar <marek.safar@gmail.com>
3402 A fix for bug #320748
3403 * convert.cs: Implicit user operators cannot convert to interfaces
3405 2008-07-22 Marek Safar <marek.safar@gmail.com>
3407 A fix for bug #312686
3408 * driver.cs: Ignore empty assembly references.
3410 2008-07-22 Marek Safar <marek.safar@gmail.com>
3412 A fix for bug #387040
3413 * ecore.cs: Skip constrains check for an explicit implementation.
3415 2008-07-21 Marek Safar <marek.safar@gmail.com>
3417 A fix for bug #409045
3418 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3419 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3420 identifiers are file specific unless passed as input arguments.
3422 2008-07-21 Marek Safar <marek.safar@gmail.com>
3424 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3425 to emit UnmanagedMarshal data under 2.0 profile.
3427 2008-07-21 Marek Safar <marek.safar@gmail.com>
3429 A fix for bug #410369
3430 * parameter.cs: Clone correctly ParamsParameter.
3432 2008-07-21 Marek Safar <marek.safar@gmail.com>
3434 * expression.cs (Argument): Always report type for type based expressions
3437 2008-07-18 Marek Safar <marek.safar@gmail.com>
3439 A fix for bug #410666
3440 * anonymous.cs: Correctly initialize generic storey reference.
3442 2008-07-18 Marek Safar <marek.safar@gmail.com>
3444 * convert.cs: Don't box same type arguments.
3446 2008-07-18 Marek Safar <marek.safar@gmail.com>
3448 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3449 Finished missing generic type mutators.
3451 2008-07-18 Marek Safar <marek.safar@gmail.com>
3453 * iterators.cs, statement.cs: Finished statements CloneTo.
3455 2008-07-18 Marek Safar <marek.safar@gmail.com>
3457 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3459 * expression.cs: Emit optimized default value expressions in expression tree
3462 2008-07-18 Marek Safar <marek.safar@gmail.com>
3464 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3466 2008-07-17 Marek Safar <marek.safar@gmail.com>
3468 A fix for bug #367536
3469 * cs-parser.jay: Check static constructor of generic types for an access
3472 2008-07-17 Marek Safar <marek.safar@gmail.com>
3474 A fix for bug #353800
3475 * lambda.cs: Emit ret for contextual statements.
3477 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3478 up emitting redundant ret for all anonymous methods with return.
3480 2008-07-17 Marek Safar <marek.safar@gmail.com>
3482 A fix for bug #365188
3483 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3484 create anonymous method storey in unreachable block.
3486 2008-07-17 Marek Safar <marek.safar@gmail.com>
3488 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3489 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3490 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3491 statement.cs: Fixed relevant defects found by Gendarme.
3493 2008-07-17 Marek Safar <marek.safar@gmail.com>
3495 A fix for bug #325291
3496 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3497 statement.cs: Replaced IAnonymousHost with top level block flag.
3499 2008-07-17 Marek Safar <marek.safar@gmail.com>
3501 * cs-parser.jay: Clean up unused open_parens.
3503 2008-07-17 Marek Safar <marek.safar@gmail.com>
3505 * ecore.cs: Custom error message for a range variable assignment.
3507 2008-07-16 Marek Safar <marek.safar@gmail.com>
3509 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3512 2008-07-16 Marek Safar <marek.safar@gmail.com>
3514 * literal.cs: Null literal is of object type.
3516 2008-07-16 Marek Safar <marek.safar@gmail.com>
3518 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3519 expression of nullable equality comparison.
3521 2008-07-15 Marek Safar <marek.safar@gmail.com>
3523 * expression.cs(PointerArithmetic): Removed redundant assignment.
3525 2008-07-15 Marek Safar <marek.safar@gmail.com>
3527 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3529 2008-07-14 Marek Safar <marek.safar@gmail.com>
3531 A fix for bug #408361
3532 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3533 they are replaced by GetMethod.
3535 2008-07-14 Marek Safar <marek.safar@gmail.com>
3537 A fix for bug #408721 by jeremie.laval@gmail.com
3538 * expression.cs (Indirection): Implemented CloneTo.
3540 2008-07-14 Marek Safar <marek.safar@gmail.com>
3542 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3545 2008-07-14 Marek Safar <marek.safar@gmail.com>
3547 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3549 2008-07-11 Marek Safar <marek.safar@gmail.com>
3551 * linq.cs: Reset tranparent parameter counter in probing mode.
3553 2008-07-11 Marek Safar <marek.safar@gmail.com>
3555 * anonymous.cs: Mutate anonymous method type.
3557 2008-07-11 Marek Safar <marek.safar@gmail.com>
3559 * ecore.cs, anonymous.cs: Mutate field expressions.
3561 2008-07-10 Marek Safar <marek.safar@gmail.com>
3563 A fix for bug #369670
3564 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3566 2008-07-10 Marek Safar <marek.safar@gmail.com>
3568 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3570 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3573 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3574 only one '>', and finds a '>>', abort the generic lookahead.
3576 2008-07-10 Marek Safar <marek.safar@gmail.com>
3578 A fix for bug #319902
3579 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3581 2008-07-10 Marek Safar <marek.safar@gmail.com>
3583 A fix for bug #406371
3584 * statement.cs: Moved EmitSymbolInfo to Block.
3586 2008-07-09 Marek Safar <marek.safar@gmail.com>
3588 * ecore.cs: Report better error for extension method overload failures.
3590 2008-07-09 Marek Safar <marek.safar@gmail.com>
3592 * expression.cs (Is): No need to box reference values.
3594 2008-07-09 Marek Safar <marek.safar@gmail.com>
3596 * class.cs: Use event resolve context when initializing CreateEmitContext.
3598 2008-07-09 Marek Safar <marek.safar@gmail.com>
3600 A fix for bug #394436
3601 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3602 method used inside expression trees. Added more LINQ to expression tree
3605 2008-07-08 Marek Safar <marek.safar@gmail.com>
3607 A fix for bug #378189, #370577
3608 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3611 2008-07-08 Marek Safar <marek.safar@gmail.com>
3613 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3616 2008-07-08 Marek Safar <marek.safar@gmail.com>
3618 A fix for bug #406702
3619 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3621 2008-07-07 Marek Safar <marek.safar@gmail.com>
3623 A fix for bug #406648
3624 * cs-parser.jay: Report nullable use in mcs for some cases.
3626 2008-07-07 Marek Safar <marek.safar@gmail.com>
3628 * ecore.cs: Improved argument mismatch error messages.
3630 2008-07-07 Marek Safar <marek.safar@gmail.com>
3632 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3634 2008-07-07 Marek Safar <marek.safar@gmail.com>
3636 * expression.cs (TypeOf): Mutate type argument.
3638 2008-07-04 Marek Safar <marek.safar@gmail.com>
3640 * class.cs: Report missing partial modifier for correct type.
3642 2008-07-04 Marek Safar <marek.safar@gmail.com>
3644 * ecore.cs, expression.cs (VariableReference): Variable property is
3647 2008-07-04 Marek Safar <marek.safar@gmail.com>
3649 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3651 2008-07-04 Marek Safar <marek.safar@gmail.com>
3653 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3656 2008-07-04 Marek Safar <marek.safar@gmail.com>
3658 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3659 anonymous method storey to an instance method when only "this" is hoisted.
3661 2008-07-03 Marek Safar <marek.safar@gmail.com>
3663 A fix for bug #321615
3664 * expression.cs: Pointer comparisons use unsigned operator.
3666 2008-07-03 Marek Safar <marek.safar@gmail.com>
3668 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3670 2008-07-02 Marek Safar <marek.safar@gmail.com>
3672 A fix for bug #404905
3673 * class.cs: Always initialize local unsafe variables.
3675 2008-06-30 Marek Safar <marek.safar@gmail.com>
3677 A fix for bug #396987
3678 * expression.cs (NewInitialize): Clear local temporary variable for next run
3680 2008-06-27 Marek Safar <marek.safar@gmail.com>
3682 A fix for bug #401020
3683 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3685 2008-06-27 Marek Safar <marek.safar@gmail.com>
3687 A fix for bug #398319
3688 * cs-parser.jay: Implemented undocumented base access expression inside
3691 2008-06-26 Marek Safar <marek.safar@gmail.com>
3693 A fix for bug #404227
3694 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3696 2008-06-26 Marek Safar <marek.safar@gmail.com>
3698 A fix for bug #404227
3699 * convert.cs: Fixed explicit array to interface cast.
3701 2008-06-26 Marek Safar <marek.safar@gmail.com>
3703 A fix for bug #403894
3704 * delegate.cs: Mutate DelegateInvocation type.
3706 2008-06-26 Marek Safar <marek.safar@gmail.com>
3708 A fix for bug #379348
3709 * delegate.cs: Box a load of generic parameters.
3711 2008-06-26 Marek Safar <marek.safar@gmail.com>
3713 * expression.cs: Add an array creation arguments mutate.
3715 2008-06-26 Marek Safar <marek.safar@gmail.com>
3717 A fix for bug #386068
3718 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3721 2008-06-25 Marek Safar <marek.safar@gmail.com>
3723 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
3726 2008-06-25 Marek Safar <marek.safar@gmail.com>
3728 A fix for bug #403518
3729 * delegate.cs: Type correctly anonymous method new invocation.
3731 2008-06-24 Marek Safar <marek.safar@gmail.com>
3733 A fix for bug #394826
3734 * anonymous.cs: Fully qualify members when resolving anonymous type internal
3737 2008-06-24 Marek Safar <marek.safar@gmail.com>
3739 A fix for bug #394826
3740 * anonymous.cs, iterators.cs: Construct generic storey only when is really
3743 2008-06-24 Marek Safar <marek.safar@gmail.com>
3745 * class.cs: Clone indexer parameters for localized capturing.
3747 2008-06-24 Marek Safar <marek.safar@gmail.com>
3749 A fix for bug #402379
3750 * expression.cs: Don't crash when an object initializer resolve fails.
3752 2008-06-24 Marek Safar <marek.safar@gmail.com>
3754 A fix for bug #402888
3755 * expression.cs: Mutate conditional expression.
3757 2008-06-24 Marek Safar <marek.safar@gmail.com>
3759 A fix for bug #401012
3760 * class.cs: Keep StructLayout in shared container.
3762 2008-06-24 Marek Safar <marek.safar@gmail.com>
3764 A fix for bug #400438
3765 * decl.cs, class.cs: Only properties can be automatically implemented.
3767 2008-06-24 Marek Safar <marek.safar@gmail.com>
3769 * statement.cs (ChangeToIterator): Copy also labels.
3771 2008-06-23 Marek Safar <marek.safar@gmail.com>
3773 * ecore.cs: Pass type argument details to parent extension method.
3775 2008-06-23 Marek Safar <marek.safar@gmail.com>
3777 A fix for bug #375966
3778 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
3780 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
3782 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
3784 2008-06-22 Marek Safar <marek.safar@gmail.com>
3786 A fix for bug #394347
3787 * anonymous.cs: Cache compatible delegates as compatibility check produces
3788 a new method every time.
3790 2008-06-20 Marek Safar <marek.safar@gmail.com>
3792 * anonymous.cs: Propagate storey reference for single references.
3794 2008-06-20 Marek Safar <marek.safar@gmail.com>
3796 A fix for bug #387615
3797 * assign.cs, expression.cs: Correctly clone compound assignment.
3799 2008-06-19 Marek Safar <marek.safar@gmail.com>
3801 A fix for bug #359611, #359604
3802 * anonymous.cs: Mutate all types of hoisted parameters.
3804 2008-06-19 Marek Safar <marek.safar@gmail.com>
3806 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
3807 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
3808 expression.cs, codegen.cs, statement.cs
3810 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
3811 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
3813 ** Anonymous methods, lambda expressions rewrite **
3815 Anonymous expressions are now resolved when an explicit block is resolved
3816 and they don't require any registration procedure anymore. Further,
3817 anonymous methods are defined when explicit block is emitted which allows
3818 better control of whole process and opens possibilities for more
3819 optimizations as well as alternative to reverse whole process.
3821 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
3822 process consistent and to correctly emit hoisted generic methods when they
3823 have at least 1 hoisted variable.
3825 2008-06-17 Martin Baulig <martin@ximian.com>
3827 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
3829 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
3830 virtual property; check it in Emit().
3831 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
3833 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
3835 (Indexer.Define): Likewise.
3837 2008-06-17 Marek Safar <marek.safar@gmail.com>
3839 * convert.cs: Don't use IsInterface on type arguments.
3841 * delegate.cs: DelegateInvocation uses MethodInfo.
3843 * parameter.cs: Removed IsTypeParameter.
3845 * generic-mcs.cs: More missing stuff.
3847 2008-06-16 Martin Baulig <martin@ximian.com>
3850 (Modifiers.DEBUGGER_HIDDEN): New public const.
3853 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
3856 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
3857 (AbstractPropertyEventMethod): Likewise.
3858 (Constructor.Emit): Likewise.
3859 (SourceMethod.SetCompilerGenerated): Removed.
3861 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
3865 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
3866 if we're an `IteratorHost'.
3867 (AnonymousMethodMethod..ctor): Don't set
3868 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
3871 2008-06-16 Marek Safar <marek.safar@gmail.com>
3873 * statement.cs: Clean-up foreach statements.
3875 2008-06-12 Marek Safar <marek.safar@gmail.com>
3877 * class.cs: Stop using public method which should not exist
3878 (MethodBuilder.SetGenericMethodSignature).
3880 2008-06-11 Martin Baulig <martin@ximian.com>
3883 (Location.LookupFile): Add `CompilationUnit' argument; when given
3884 a relative file name, make it relative to the directory the .cs
3885 file is located in instead of using the current directory.
3887 2008-06-11 Martin Baulig <martin@ximian.com>
3890 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
3891 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
3892 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
3893 (SourceMethod.SetCompilerGenerated): Likewise.
3895 2008-06-11 Marek Safar <marek.safar@gmail.com>
3897 * codegen.cs, driver: Only write symbol file when it's asked for.
3899 2008-06-11 Marek Safar <marek.safar@gmail.com>
3901 * codegen.cs: Don't use assembly writer error handling for symbol writer.
3903 2008-06-10 Martin Baulig <martin@ximian.com>
3905 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
3907 2008-06-09 Marek Safar <marek.safar@gmail.com>
3909 A fix for bug #316290
3910 * expression.cs: Include decimal operators in predefined table.
3912 * parameters.cs: More readonlyness.
3914 2008-06-09 Marek Safar <marek.safar@gmail.com>
3916 A fix for bug #397213
3917 * cs-parser.jay: One more missing current_local_parameters reset.
3919 2008-06-09 Marek Safar <marek.safar@gmail.com>
3921 A fix for bug #396633
3922 * class.cs: Host backing field in partial container.
3924 2008-06-09 Marek Safar <marek.safar@gmail.com>
3926 A fix for bug #397068
3927 * expression.cs: Check both operand types when predefined operator is used.
3929 2008-06-05 Martin Baulig <martin@ximian.com>
3931 Merged the `debugger-kahalo' branch.
3934 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
3935 we're an iterator method.
3936 (SourceMethod): Reflect latest symbol writer changes;
3937 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
3938 now `start_row' and `end_row'.
3939 (Constructor.Emit): Fix the logic whether to emit symbol information.
3941 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
3945 (CompilationUnit): New public class; derives from `SourceFile'.
3946 (SourceFileEntry.DefineSymbolInfo): New public method.
3947 (SourceFileEntry.SetChecksum): New public method.
3948 (Location): Encode hidden line numbers by using `column == 255';
3949 the .ctor now accepts `column == -1' to mark a hidden line number.
3950 (Location.Hidden): New public property.
3951 (Location.CheckPoint): Add `CompilationUnit'.
3952 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
3953 (Location.Push): Add `CompilationUnit compile_unit' argument.
3954 (Location.CompilationUnit): New public property.
3957 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
3959 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
3961 * driver.cs: `SourceFile' -> `CompilationUnit'.
3963 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
3965 * namespace.cs: `SourceFile' -> `CompilationUnit'.
3967 * cs-tokenizer.cs: Add support for `#pragma checksum' and
3971 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
3972 new symbol writer API to also pass the file.
3974 2008-06-05 Marek Safar <marek.safar@gmail.com>
3976 * statement.cs: Emit catch variable assignment using variable expression.
3978 2008-06-05 Marek Safar <marek.safar@gmail.com>
3980 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
3981 with other variable types.
3983 2008-06-04 Marek Safar <marek.safar@gmail.com>
3985 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
3986 GetLength method emit, it breaks resolve rules.
3988 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
3989 Marek Safar <marek.safar@gmail.com>
3991 A fix for bug #395542
3992 * cs-parser.jay: The trailing comma is allowed in anonymous type member
3995 2008-06-02 Marek Safar <marek.safar@gmail.com>
3997 A fix for bug #395287
3998 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4000 2008-05-31 Marek Safar <marek.safar@gmail.com>
4002 A fix for bug #395845
4003 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4004 non-nullable parameter type.
4006 2008-05-31 Marek Safar <marek.safar@gmail.com>
4008 * class.cs: Handle contructor initializer as a statement in top-level block.
4010 2008-05-30 Marek Safar <marek.safar@gmail.com>
4012 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4013 security attributes.
4015 2008-05-24 Marek Safar <marek.safar@gmail.com>
4017 * ecore.cs, expression.cs: Small IVariable refactoring.
4019 2008-05-22 Marek Safar <marek.safar@gmail.com>
4021 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4023 2008-05-21 Marek Safar <marek.safar@gmail.com>
4025 * cs-parser.jay: Removed redundant catch type check.
4027 2008-05-21 Marek Safar <marek.safar@gmail.com>
4029 A fix for bug #390372
4030 * nullable.cs: Set correct return type.
4032 2008-05-21 Marek Safar <marek.safar@gmail.com>
4034 A fix for bug #391062
4035 * typemanager.cs: Fixed crash when comparing null types.
4037 2008-05-21 Marek Safar <marek.safar@gmail.com>
4039 A fix for bug #391871
4040 * cs-parser.jay: Better error handling for invalid catch type.
4042 2008-05-20 Marek Safar <marek.safar@gmail.com>
4044 A fix for bug #392155
4045 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4047 2008-05-15 Marek Safar <marek.safar@gmail.com>
4049 A fix for bug #390666
4050 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4053 2008-05-15 Marek Safar <marek.safar@gmail.com>
4055 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4058 2008-05-13 Marek Safar <marek.safar@gmail.com>
4060 A fix for bug #389625
4061 * delegate.cs, generic.cs: Some progress on method group return type
4064 2008-05-13 Marek Safar <marek.safar@gmail.com>
4066 A fix for bug #378419
4067 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4069 2008-05-12 Marek Safar <marek.safar@gmail.com>
4071 * class.cs (Constructor): Added IsCompilerGenerated.
4073 2008-05-12 Marek Safar <marek.safar@gmail.com>
4075 * expression.cs: Enum binary operators can accept non-enum operand only when
4076 is implicitly convertible to underlying type.
4078 2008-05-12 Marek Safar <marek.safar@gmail.com>
4080 A fix for bug #389272
4081 * support.cs: Workaround System.InvalidOperationException for enums.
4083 2008-05-12 Marek Safar <marek.safar@gmail.com>
4085 A fix for bug #389073
4086 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4088 2008-05-10 Marek Safar <marek.safar@gmail.com>
4090 * driver.cs: Split Parse.
4092 * location.cs (LookupFile): Uses string.Empty.
4094 2008-05-07 Marek Safar <marek.safar@gmail.com>
4096 * expression.cs, parameter.cs: Small ParameterReference clean up.
4098 2008-05-07 Marek Safar <marek.safar@gmail.com>
4100 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4101 hack. Fixes #387502.
4103 2008-05-06 Martin Baulig <martin@ximian.com>
4105 * class.cs (Constructor.Emit): Fix the logic whether to emit
4108 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4111 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4112 InvalidOperationException when the iterator is before the start or
4115 2008-05-06 Marek Safar <marek.safar@gmail.com>
4117 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4118 when left is nullable type.
4120 2008-05-06 Marek Safar <marek.safar@gmail.com>
4122 A fix for bug #386628
4123 * expression.cs (LocalVariableReference): Continue in resolving when
4124 variable is not assigned.
4126 2008-05-05 Marek Safar <marek.safar@gmail.com>
4128 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4129 nullable operations.
4131 2008-05-04 Marek Safar <marek.safar@gmail.com>
4133 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4134 it saves many redundant temporary variables for nullable operations.
4136 2008-05-03 Marek Safar <marek.safar@gmail.com>
4138 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4140 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4143 * nullable.cs: Constant coalescing operator optimizations.
4145 2008-05-03 Marek Safar <marek.safar@gmail.com>
4147 * constant.cs: Use unsigned conversion for values which are unsigned only.
4149 2008-05-03 Marek Safar <marek.safar@gmail.com>
4151 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4152 coalescing operator as it should be.
4154 2008-05-02 Marek Safar <marek.safar@gmail.com>
4156 A fix for bug #371016
4157 * expression.cs: All predefined delegate operators require implicit method
4160 2008-05-02 Marek Safar <marek.safar@gmail.com>
4162 * constant.cs: Emit long constant as uint when fits the range.
4164 * convert.cs, expression.cs: Fixed few unsafe conversions.
4166 2008-05-02 Marek Safar <marek.safar@gmail.com>
4168 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4170 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4173 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4175 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4177 2008-05-01 Marek Safar <marek.safar@gmail.com>
4179 * constant.cs, literal.cs: IsLiteral property for error reporting.
4181 * ecore.cs, expression.cs: Implemented Property expression.
4183 2008-05-01 Marek Safar <marek.safar@gmail.com>
4185 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4187 * nullable.cs: Implemented nullable coalescing null operator.
4189 * ecore.cs, expression.cs: Expression trees work.
4191 2008-05-01 Marek Safar <marek.safar@gmail.com>
4193 * ecore.cs: CreateExpressionTree is finally abstract.
4195 * expression.cs, linq.cs: Updated.
4197 2008-05-01 Marek Safar <marek.safar@gmail.com>
4199 * expression.cs, ecore.cs: Block base access expression inside expression
4202 2008-05-01 Marek Safar <marek.safar@gmail.com>
4204 A fix for bug #385058
4205 * expression.cs: User-defined operator implementations always take
4206 precedence over predefined operator implementations.
4208 2008-04-30 Marek Safar <marek.safar@gmail.com>
4210 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4211 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4212 expression tree conversions.
4214 2008-04-30 Marek Safar <marek.safar@gmail.com>
4216 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4217 operators method details to Operator class.
4219 2008-04-30 Marek Safar <marek.safar@gmail.com>
4221 * anonymous.cs: Pass unsafe flags to anonymous container.
4223 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4224 inside expression tree.
4226 2008-04-29 Martin Baulig <martin@ximian.com>
4228 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4229 (Tokenizer.PopPosition): Also restore the `line'.
4231 2008-04-29 Marek Safar <marek.safar@gmail.com>
4233 * delegate.cs: Implemented Invoke expression.
4235 2008-04-29 Marek Safar <marek.safar@gmail.com>
4237 * expression.cs: Fixed equality reference comparison regression.
4239 2008-04-29 Marek Safar <marek.safar@gmail.com>
4241 * ecore.cs: Clean up EmptyCast hack.
4243 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4244 using correct conversion rules. Also fixes #383993.
4246 2008-04-28 Martin Baulig <martin@ximian.com>
4248 * class.cs (Constructor.Emit): Don't emit debugging information
4249 for generated default .ctor's.
4251 2008-04-28 Marek Safar <marek.safar@gmail.com>
4253 * convert.cs: Empty-cast ushort to int conversion.
4255 2008-04-28 Marek Safar <marek.safar@gmail.com>
4257 A fix for bug #384191
4258 * ecore.cs, expression.cs: Fixed expression cloning.
4260 2008-04-28 Marek Safar <marek.safar@gmail.com>
4262 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4264 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4266 Fix #381559, test-638.cs, test-639.cs
4267 * assign.cs (CompoundAssign.Helper): New wrapper.
4268 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4270 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4271 Pass unconverted expressions to the params array creation expression.
4272 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4273 (PropertyExpr.EmitAssign): Likewise.
4274 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4275 element if it is of kind CompoundAssign.Helper.
4276 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4277 first before anything else.
4278 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4279 (ArrayAccess.LoadArrayAndArguments): Simplify.
4281 2008-04-27 Marek Safar <marek.safar@gmail.com>
4283 * expression.cs: Fixed cloning of typeof(void).
4285 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4287 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4288 (Assign.Emit): Likewise. Move it to ...
4289 (CompoundAssign.DoResolve): ... here and ...
4290 (CompoundAssign.Emit): ... here.
4291 (EventAddOrRemove): New helper to handle += and -= on events, and
4292 avoid the use of BinaryDelegates.
4293 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4294 (EventExpr.EmitAddOrRemove): Improve.
4295 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4297 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4298 create VarExprs for 'foo.bar.var'.
4299 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4300 is a highly inappropriate name for its functionality.
4302 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4304 Simplify handling of multiple assignments
4305 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4307 (SimpleAssign): New. Class to be used for normal assignments.
4308 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4309 * expression.cs, parameter.cs, statement.cs: Likewise.
4311 2008-04-25 Marek Safar <marek.safar@gmail.com>
4313 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4314 for incompatible underlying types, more to come, uff.
4316 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4319 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4320 Handle 'leave_copy'.
4322 2008-04-25 Marek Safar <marek.safar@gmail.com>
4324 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4326 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4328 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4329 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4330 * statement.cs (While, Do, For): Allow test to have side effects.
4331 (For.DoEmit): Always emit InitStatement.
4334 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4335 Always create SideEffectConstant.
4336 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4337 of type EnumConstant.
4339 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4340 Handle 'right' being SideEffectConstant of type 'bool'.
4342 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4343 Use left.EmitBranchable instead of open coding it, so as to
4344 improve optimization opportunities.
4346 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4348 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4350 (Expression.EmitSideEffect): Document.
4352 2008-04-23 Marek Safar <marek.safar@gmail.com>
4354 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4356 2008-04-23 Marek Safar <marek.safar@gmail.com>
4358 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4360 2008-04-23 Marek Safar <marek.safar@gmail.com>
4362 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4363 conversion to expression tree.
4365 2008-04-23 Marek Safar <marek.safar@gmail.com>
4367 * ecore.cs: Removed unused expression.
4369 2008-04-22 Marek Safar <marek.safar@gmail.com>
4371 * expression.cs: Implemented NegateChecked and New expressions.
4373 2008-04-22 Marek Safar <marek.safar@gmail.com>
4375 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4377 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4380 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4381 needing final 'ret' instruction.
4383 2008-04-22 Marek Safar <marek.safar@gmail.com>
4385 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4387 2008-04-21 Marek Safar <marek.safar@gmail.com>
4389 * expression.cs: Emit ldnull and not null expression as an instance argument
4390 of static method expression calls.
4392 2008-04-21 Marek Safar <marek.safar@gmail.com>
4394 A fix for bug #378200
4395 * expression.cs: Fixed crash when creating parameterless expression tree
4398 2008-04-21 Marek Safar <marek.safar@gmail.com>
4400 A fix for bug #375297
4401 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4404 2008-04-21 Marek Safar <marek.safar@gmail.com>
4406 A fix for bug #377596
4407 * decl.cs, class.cs: Emit delegate type argument attributes.
4409 2008-04-21 Marek Safar <marek.safar@gmail.com>
4411 A fix for bug #365314
4412 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4414 2008-04-21 Marek Safar <marek.safar@gmail.com>
4416 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4419 2008-04-21 Marek Safar <marek.safar@gmail.com>
4421 * generic.cs (TypeParameter): Removed redundant location.
4423 2008-04-19 Marek Safar <marek.safar@gmail.com>
4425 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4426 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4427 FullNamedExpression in all declaration type expression, statements will come
4430 2008-04-18 Marek Safar <marek.safar@gmail.com>
4432 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4433 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4435 2008-04-18 Marek Safar <marek.safar@gmail.com>
4437 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4440 2008-04-17 Marek Safar <marek.safar@gmail.com>
4442 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4445 2008-04-17 Marek Safar <marek.safar@gmail.com>
4447 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4451 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4453 Hook up 'EmitSideEffect'
4454 * constant.cs (Constant.EmitSideEffect): New.
4455 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4456 (SideEffectConstant.EmitSideEffect): New.
4457 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4458 unconditional branch in EmitBranchable.
4459 (FieldExpr.EmitBranchable): New.
4460 * expression.cs (Unary.EmitSideEffect): New.
4461 (Binary.EmitSideEffect): New.
4462 (VariableReference.EmitSideEffect): New. Do nothing.
4464 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4466 Introduce 'EmitSideEffect'
4467 * ecore.cs (Expression.EmitSideEffect): New.
4468 (TypeCast): Rename from EmptyCast.
4470 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4471 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4472 * convert.cs, nullable.cs: Update to changes.
4474 2008-04-16 Marek Safar <marek.safar@gmail.com>
4476 * class.cs, cs-parser.jay: Early check for base types expression.
4478 2008-04-16 Marek Safar <marek.safar@gmail.com>
4480 * decl.cs (MemberName): Declare PrettyName as obsolete.
4482 2008-04-16 Marek Safar <marek.safar@gmail.com>
4484 * namespace.cs: Use MemberName comparison.
4486 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4489 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4491 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4492 (MemberName.FullyQualifiedName): New. Provides the functionality
4493 that users assume FullName would have.
4494 * ecore.cs, namespace.cs: Update to changes.
4496 * statement.cs (Using.assign): Make into ExpressionStatement.
4497 (Using.EmitPreTryBody): Simplify.
4499 2008-04-16 Marek Safar <marek.safar@gmail.com>
4501 * report.cs: ColorFormat is protected.
4503 * rootcontext.cs: Unused fields clean-up.
4505 * namespace.cs: Made UsingEntry name private.
4507 2008-04-16 Marek Safar <marek.safar@gmail.com>
4509 * cs-tokenizer.cs, location.cs: Removed unused field.
4511 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4512 Raja R Harinath <harinath@hurrynot.org>
4515 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4516 (SideEffectConstant.side_effect): Rename from 'right'.
4517 (SideEffectConstant..ctor): Normalize 'side_effect'.
4518 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4519 value of this constant.
4520 * cfold.cs: Update to changes.
4522 2008-04-15 Marek Safar <marek.safar@gmail.com>
4524 * cs-paser.jay: Removed unused variable.
4526 * driver.cs: Made Compile instance method.
4528 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4530 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4532 2008-04-15 Marek Safar <marek.safar@gmail.com>
4534 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4536 2008-04-13 Jb Evain <jbevain@novell.com>
4538 * namespace.cs: update the System.Core fullname for 2.1
4539 * driver.cs: update the list of required assemblies for 2.1.
4540 Merged from the Moonlight 2 branch.
4542 2008-04-11 Marek Safar <marek.safar@gmail.com>
4544 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4545 types and user defined operators. User operators arguments has to be checked
4546 for null value before invocation, which also means no operator is called
4547 when any argument is not convertible to unwrapped nullable type.
4549 2008-04-09 Marek Safar <marek.safar@gmail.com>
4551 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4552 of Unary expressions to follow operator overloading rules precisely.
4553 Also fixes #321794, #323794
4555 2008-04-08 Marek Safar <marek.safar@gmail.com>
4557 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4560 2008-04-08 Marek Safar <marek.safar@gmail.com>
4562 * expression.cs, ecore.cs: Implemented MemberInit expression.
4564 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4566 Fix mono/tests/exception4.cs
4567 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4568 ec.NeedReturnLabel () rather emitting a 'nop'.
4570 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4572 (TryCatch.SomeCodeFollows): Likewise.
4573 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4574 for 'break', 'continue' and 'return' statements inside a try.
4575 We're fairly sure that the generated IL stream will have more
4576 instructions textually following the try.
4577 (FlowBranchingTryCatch): Likewise.
4579 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4580 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4583 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4584 wrapper -- forward everything to CollectionForeach.
4585 (CollectionForeach.NonDisposableWrapper): New.
4586 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4587 instead of a pop + branch to end.
4589 2008-04-07 Marek Safar <marek.safar@gmail.com>
4591 A fix for bug #377485
4592 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4593 Propagate location for extension method groups. Report conversion failure at
4596 2008-04-07 Marek Safar <marek.safar@gmail.com>
4598 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4599 ListInit and Field expressions.
4601 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4603 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4604 Since $PC is always -1 inside the body of MoveNext, the fault
4606 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4607 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4608 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4610 The denouement! Fix #324708
4611 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4612 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4613 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4614 'finally' inside the finally clause.
4616 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4617 inside an iterator. Don't emit the body of the 'finally' inside
4618 the finally clause yet.
4620 Use the ResumableStatement infrastructure for MoveNext ()
4621 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4622 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4623 'old_resume_points'. Move dispatcher upfront.
4624 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4625 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4626 in an enumerator. This encodes the main fix in this patch series
4627 -- we can only jump into the first instruction of a try from the
4628 outside, but we want to emit try/finally regions in iterators and
4629 resume in the middle of them.
4631 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4633 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4634 of NeedReturnLabel here.
4636 Introduce a common point for emitting try/finally to IL
4637 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4638 features of the various subclasses, which are now driven by ...
4639 (ExceptionStatement.EmitPreTryBody): ... this and ...
4640 (ExceptionStatement.EmitTryBody): ... this and the original
4642 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4643 Remove DoEmit and update to follow above protocol.
4645 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4646 of the dispatcher are the same, skip emitting the 'switch'.
4647 * iterator.cs (Iterator.EmitDispose): Update to changes.
4649 Clean up handling of 'using' statement
4650 * statement.cs (UsingTemporary): New. Carved out of ...
4651 (Using): ... this. Simplify drastically. Handle exactly
4653 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4654 or Using as appropriate. If there are multiple variable declared,
4655 create nested Using statements.
4656 (resource_acquisition): Kill.
4658 * statement.cs (ExceptionStatement.EmitForDispose): Use
4659 EmitFinallyBody, not EmitFinally.
4661 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4662 * iterator.cs: Update to changes.
4664 Start using the ResumableStatement infrastructure
4665 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4666 (ResumableStatement.EmitForDispose): New.
4667 (ExceptionStatement): Override them.
4668 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4669 EmitForDispose to create the body of the Dispose method. Don't
4672 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4673 * statement.cs (Toplevel.AddResumePoint): ... here.
4674 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4675 * flowanalysis.cs (FlowBranchingIterator): New.
4676 * codegen.cs (EmitContext): Update to changes.
4678 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4679 (Iterator.old_resume_points): Rename from 'resume_points'.
4680 (Iterator.MoveNextStatement): Remove unused class.
4682 New infrastructure for try/finally in iterators (still unused)
4683 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4684 (FlowBranchingToplevel.AddResumePoint): Hook into
4685 ToplevelBlock.AddResumePoint.
4686 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4687 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4688 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4689 resume points and assign program-counter values.
4690 (ExceptionBlock.AddResumePoint): Collect resume points for
4691 de-muxer at the top of try block.
4692 * iterators.cs (Yield.CheckContext): Simplify.
4693 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4695 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4697 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4698 argument to an ExitStatement.
4699 (FlowBranchingException): Refactor saved origins code.
4700 * statement.cs (ExitStatement): Update to cahges.
4701 * iterator.cs (YieldBreak): Likewise.
4703 * statement.cs (ResumableStatement): New. Common base class for
4704 YieldReturn and ExceptionStatement.
4705 (ExitStatement): New. Common base class for Return and YieldBreak.
4706 (Return): Update to changes.
4707 * iterator.cs (YieldBreak): Likewise.
4708 * lambda.cs (ContextualReturn): Likewise.
4711 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4712 emit a meaningful error message.
4714 Fix #324765, #319508
4715 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4716 (VariableInfo.SetAssigned): Set it.
4717 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4718 determine if CS0219 or CS0168 is appropriate. Don't use
4719 flow-analysis information.
4720 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4721 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4722 (EmitContext.EndFlowBranching): ... this.
4724 2008-04-03 Marek Safar <marek.safar@gmail.com>
4726 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
4728 2008-04-03 Marek Safar <marek.safar@gmail.com>
4730 A fix for bug #376508
4731 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
4732 ImplicitConversionExists.
4734 2008-04-03 Marek Safar <marek.safar@gmail.com>
4736 * expression.cs (Binary): Added remaining binary operators to expression
4739 * nullable.cs: Optimize shift with null argument.
4741 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
4743 Fix minor IL regression
4744 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
4745 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
4746 * cs-parser.jay (try_statement): Update to changes.
4748 * statement.cs (TryFinally.need_exc_block): Delete.
4749 (TryFinally): Update to changes.
4751 Now all ExceptionStatements are unconditional
4752 * statement.cs (CollectionForeach.DisposableWrapper): New.
4753 Extract out the try/finally code into a new wrapper.
4754 (CollectionForeach.Resolve): Use it to simplify the code.
4756 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
4758 Start at simplifying ExceptionStatement semantics a bit
4759 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
4760 * cs-parser.jay (try_statement): Update to changes.
4761 (opt_catch_clauses): Remove.
4762 * flowanalysis.cs: Update to changes.
4763 (FlowBranching.BranchingType.TryCatch): New.
4764 (FlowBranchingTryCatch): New.
4766 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
4767 (FlowBranching.CreateBranching): Update to changes.
4768 (FlowBranchingBlock.AddSibling): Add sanity check.
4769 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
4772 * iterators.cs (Iterator.MarkFinally): Remove.
4773 * statement.cs (ExceptionStatement): Update to changes.
4775 Add support for skipping over finally blocks at runtime. First
4776 in a series to fix #324708
4777 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
4778 (Iterator.EmitMoveNext): Initialize it.
4779 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
4780 branch over the body of the 'finally' clause.
4782 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
4784 Avoid lopsided use of Foo/DoFoo names
4785 * statement.cs (ExpressionStatement.EmitFinallyBody):
4786 Rename from EmitFinally.
4787 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
4788 * iterator.cs: Update to changes.
4790 2008-04-02 Marek Safar <marek.safar@gmail.com>
4792 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
4793 based on UserOperatorCall. More binary nullable operators clean up.
4795 2008-04-02 Martin Baulig <martin@ximian.com>
4797 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
4799 2008-04-02 Marek Safar <marek.safar@gmail.com>
4801 * nullable.cs: Merge user and empty conversions when lifting expression
4804 * expression.cs (StringConcat): Implemented expression tree representation.
4806 2008-04-01 Marek Safar <marek.safar@gmail.com>
4808 * nullable.cs: When lifting null literal and a user operator exists, no call
4811 2008-04-01 Marek Safar <marek.safar@gmail.com>
4813 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
4816 2008-04-01 Marek Safar <marek.safar@gmail.com>
4818 * nullable.cs, expression.cs: Use namespace instead heavily nested
4819 monster abstract class.
4821 2008-04-01 Marek Safar <marek.safar@gmail.com>
4823 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
4824 lifting of null literal and user operators. Clean up of some temporary
4827 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
4829 Fix #368224, test-629.cs
4830 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
4831 if it crossed an unwind-protect boundary.
4832 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
4833 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
4834 inside an unwind-protected region.
4835 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
4836 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
4837 'leave' instead of a 'br' if unwind-protected.
4838 (Iterator.EmitYieldBreak): Likewise.
4840 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
4842 * driver.cs: Only define versioninfo resources if no win32 resource
4845 2008-03-28 Marek Safar <marek.safar@gmail.com>
4847 A fix for bug #372375
4848 * convert.cs: Fixed boxing of nullable types.
4850 2008-03-28 Marek Safar <marek.safar@gmail.com>
4852 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
4855 2008-03-28 Marek Safar <marek.safar@gmail.com>
4857 A fix for bug #374619
4858 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
4860 2008-03-27 Marek Safar <marek.safar@gmail.com>
4862 * lambda.cs: Check return type only for invocation.
4864 2008-03-27 Marek Safar <marek.safar@gmail.com>
4866 A fix for bug #374214
4867 * ecore.cs: Correctly report argument type mismatch.
4869 2008-03-27 Marek Safar <marek.safar@gmail.com>
4871 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
4872 and not rely on broken IsEnum.
4874 2008-03-27 Marek Safar <marek.safar@gmail.com>
4876 * nullable.cs: New file, extracted from generic.cs.
4878 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
4880 2008-03-27 Marek Safar <marek.safar@gmail.com>
4882 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
4883 predefined comparison operators and null literals.
4885 * report.cs: New warning ID.
4887 2008-03-25 Marek Safar <marek.safar@gmail.com>
4889 A fix for bug #370577
4890 * lambda.cs: Check return type too.
4892 2008-03-25 Marek Safar <marek.safar@gmail.com>
4894 A fix for bug #372846
4895 * class.cs: Automatic properties can be declared as unsafe.
4897 2008-03-20 Marek Safar <marek.safar@gmail.com>
4899 * location.cs: Use string based concatenation.
4901 * expression.cs: LiftedBinaryOperator is gmcs only.
4903 2008-03-20 Marek Safar <marek.safar@gmail.com>
4905 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
4906 conversions rules and expression trees.
4908 2008-03-19 Marek Safar <marek.safar@gmail.com>
4910 * delegate.cs: Use extension method source as delegate target.
4912 2008-03-19 Marek Safar <marek.safar@gmail.com>
4914 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
4915 binary operations to be purely based on binary operations and optimized
4916 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
4917 and other ET refactoring.
4919 * typemanager.cs: Fixed warning.
4921 2008-03-17 Marek Safar <marek.safar@gmail.com>
4923 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
4925 * symbolwriter.cs: Fixed.
4927 2008-03-17 Marek Safar <marek.safar@gmail.com>
4929 * anonymous.cs, driver.cs: Reset anonymous types counters.
4931 2008-03-17 Marek Safar <marek.safar@gmail.com>
4933 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
4935 * class.cs: Use fullname for all type member definitions.
4937 2008-02-19 Martin Baulig <martin@ximian.com>
4940 (IMethodData.EmitExtraSymbolInfo): New interface method.
4941 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
4942 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
4943 interface method here as an empty public virtual method.
4946 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
4947 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
4948 CodeGen.SymbolWriter.SetRealMethodName().
4950 2008-02-18 Martin Baulig <martin@ximian.com>
4953 (ScopeInfo.EmitType): Override this and emit debugging
4954 information for captured variables.
4955 (RootScopeInfo.EmitType): Override this and emit symbol
4956 information for a captured `this'.
4958 2008-02-15 Martin Baulig <martin@ximian.com>
4960 * iterators.cs: Emit debugging info.
4963 (EmitContext.Flags): Add `OmitDebuggingInfo'.
4964 (EmitContext.OmitDebuggingInfo): New public property.
4967 (While): Override Emit() and don't emit symbol info there; do it
4968 inside DoEmit() instead.
4969 (Block.Emit): Omit symbol information while emitting the scope
4970 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
4972 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
4973 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
4974 .ctor to make `IsIterator' work.
4976 2008-03-14 Martin Baulig <martin@ximian.com>
4978 * symbolwriter.cs: Added the new symbol writer function from the
4979 debugger's `terrania' branch; temporarily enclose them inside
4980 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
4983 2008-03-14 Martin Baulig <martin@ximian.com>
4986 (SymbolWriter): Make this a public static class.
4989 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
4990 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
4992 2008-03-14 Marek Safar <marek.safar@gmail.com>
4994 A fix for bug #370577
4995 * statement.cs, lambda.cs: Added extra limitations when dealing with void
4998 2008-03-14 Marek Safar <marek.safar@gmail.com>
5000 * typemanager.cs (CSharpName): Made 250 times faster.
5002 2008-03-13 Marek Safar <marek.safar@gmail.com>
5004 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5006 2008-03-12 Marek Safar <marek.safar@gmail.com>
5008 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5009 crash when predefined field does not exist.
5011 2008-03-12 Marek Safar <marek.safar@gmail.com>
5013 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5015 2008-03-12 Marek Safar <marek.safar@gmail.com>
5017 * class.cs (FixedField): Don't crash when contructors are missing.
5019 2008-03-11 Marek Safar <marek.safar@gmail.com>
5021 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5022 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5023 check internal types accessibility for internal and external types.
5024 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5026 2008-03-11 Marek Safar <marek.safar@gmail.com>
5028 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5029 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5030 attribute.cs, statement: Use corect instance of predefined types (work
5031 related to #364674).
5033 2008-03-07 Marek Safar <marek.safar@gmail.com>
5035 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5037 2008-03-07 Marek Safar <marek.safar@gmail.com>
5039 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5040 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5041 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5042 predefined types clean up, delayed predefined types members initialization
5043 (work related to #364674).
5045 2008-03-05 Marek Safar <marek.safar@gmail.com>
5047 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5049 2008-03-05 Marek Safar <marek.safar@gmail.com>
5051 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5052 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5053 predefined types clean up (work related to #364674).
5055 2008-03-04 Marek Safar <marek.safar@gmail.com>
5057 * ecore.cs: Print an error message instead of throwing exception.
5059 2008-03-04 Marek Safar <marek.safar@gmail.com>
5061 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5062 expression.cs, statement.cs: Unififed null literal representation.
5064 2008-03-03 Marek Safar <marek.safar@gmail.com>
5066 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5067 expression.cs: Refactored binary operators resolve phase and improved speed.
5068 The nullable code is still missing and won't work correctly, more fixes
5071 It also fixes #323726, #324312, #324248, and many other unreported issues.
5073 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5075 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5078 2008-02-27 Marek Safar <marek.safar@gmail.com>
5080 * ecore.cs: Clean-up and split BetterConversion.
5082 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5085 * enum.cs (EnumMember.Value): Only access 'value' if
5086 ResolveValue says it's ok.
5087 (EnumMember.DoResolveValue): Don't set prev_member.value.
5088 (Enum.GetDefinition): Reverse arguments of Equals --
5089 EnumMember.Value can return 'null'.
5091 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5093 2008-02-22 Marek Safar <marek.safar@gmail.com>
5095 * generic.cs, expression.cs: More ongoing work on expression trees.
5097 2008-02-21 Marek Safar <marek.safar@gmail.com>
5099 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5100 handle missing matches when mutiple operators exist.
5102 2008-02-20 Marek Safar <marek.safar@gmail.com>
5104 A fix for bug #363218
5105 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5108 2008-02-20 Marek Safar <marek.safar@gmail.com>
5110 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5111 update. This time to deal correctly with SideEffectConstant expression used
5112 as an argument for another constant folding.
5114 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5116 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5119 2008-02-19 Marek Safar <marek.safar@gmail.com>
5121 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5123 2008-02-19 Marek Safar <marek.safar@gmail.com>
5125 A fix for bug #328136
5126 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5127 side is a false constant, because we still need to evaluate the right-hand
5130 * statement.cs (If): Emit two types of boolean constants (simple constant,
5131 side-effect constant).
5133 2008-02-19 Marek Safar <marek.safar@gmail.com>
5135 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5137 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5140 2008-02-18 Marek Safar <marek.safar@gmail.com>
5142 A fix for bug #361457
5143 * ecore.cs (IsApplicable): Params methods have lower priority.
5145 * support.cs: Return correct parameter modifier for params types.
5147 2008-02-18 Marek Safar <marek.safar@gmail.com>
5149 * generic.cs (TypeParameter): Cache attribute target name.
5151 * support.cs: Removed unused variable.
5153 * typemanager.cs: Removed debugging leftover.
5155 * ecore.cs: Use local type instead of a property;
5157 * class.cs (VerifyMembers): Consider also parent to test whether type member
5160 * expression.cs (FullMethodDesc): Removed.
5162 * attribute.cs (IsValidArgumentType): Made static.
5164 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5166 Cleanup to be more readable.
5167 * Makefile (GMCS_PROFILE): Remove.
5168 (COMPILER_NAME): New helper.
5170 2008-02-15 Miguel de Icaza <miguel@novell.com>
5172 * cs-tokenizer.cs: if a conditional expression happens inside a
5173 (...) this also means that we do not need to de-ambiguate between
5174 an parenthesized expression and a cast.
5178 * constant.cs (SideEffectConstant): a constant value that happens
5179 to have a side effect.
5181 Fixes the build regressions introduced by the fix for #359789
5183 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5185 * expression.cs (Conditional.Emit): when emitting the ternary
5186 operator, use local variables to generate code verifiable code.
5188 The verifier cannot infer that the type on stack before the
5189 stloc.0 is executed is of type ParentB. This happens because the
5190 stack merge algorithm uses only parent types when deciding which
5191 is the common type. This is described in Part III 1.8.1.3 of ECMA
5194 This code compiled with mcs is not verifiable under MS. The MS
5195 verifier picks the first common interface of Foo and Bar, which is
5196 wrong, but doesn't use a full join type of the 2 interfaces.
5198 CSC uses a clever hack to compile such code in a verifiable
5199 way. It stores the intermediate values in a local variable with
5204 2008-02-14 Miguel de Icaza <miguel@novell.com>
5206 * expression.cs: Do not fold BitwiseAnd operators when the left
5207 side is a false constant, because we still need to evaluate the
5212 * support.cs: Instead of throwing an InternalErrorException when
5213 the position of the stream is outside the boundary of our buffer,
5214 reset the state of the reader, and restart the reading from the
5215 beginning of the file.
5217 2008-02-14 Marek Safar <marek.safar@gmail.com>
5219 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5221 2008-02-14 Marek Safar <marek.safar@gmail.com>
5223 A fix for bug #361686
5224 * decl.cs: A protected types used inside a private class which parents
5225 derives from the protected class are accessible.
5227 2008-02-13 Marek Safar <marek.safar@gmail.com>
5229 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5230 the parameterless constructor.
5232 2008-02-13 Marek Safar <marek.safar@gmail.com>
5234 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5235 lookup methods to use standard member cache when doing member lookup.
5237 2008-02-12 Marek Safar <marek.safar@gmail.com>
5239 * driver.cs: Don't report full path for referenced module as assembly error.
5241 2008-02-12 Marek Safar <marek.safar@gmail.com>
5243 * Makefile: Fixed `qh' target to work on all machines.
5245 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5246 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5247 and HasElementType with TypeManager implementation.
5249 2008-02-08 Marek Safar <marek.safar@gmail.com>
5251 A fix for bugs #325134, #359749
5252 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5253 first binds point to non-method member expression.
5255 2008-02-08 Marek Safar <marek.safar@gmail.com>
5257 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5259 2008-02-08 Marek Safar <marek.safar@gmail.com>
5261 A fix for bugs #321394, #323028
5262 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5263 Reworked naive IsAccessibleAs implementation to handle nested types.
5265 2008-02-05 Jb Evain <jbevain@novell.com>
5267 * class.cs: use generic type comparison for parameters
5270 2008-02-05 Marek Safar <marek.safar@gmail.com>
5272 A fix for bug #325372
5273 * class.cs: Use generic type comparison when testing method signatures.
5275 2008-02-05 Marek Safar <marek.safar@gmail.com>
5277 A fix for bug #357047
5278 * ecore.cs: Applied C# 3.0 changes to better conversion.
5280 2008-02-05 Marek Safar <marek.safar@gmail.com>
5282 A fix for bug #358374
5283 * cs-parser.jay: Correctly set modifiers for all constructor types.
5285 2008-02-04 Marek Safar <marek.safar@gmail.com>
5287 A fix for bug #355251
5288 * generic.cs: Added base class constraint based type inference.
5290 2008-02-01 Marek Safar <marek.safar@gmail.com>
5292 A fix for bug #357255
5293 * decl.cs: One more missing visibility check.
5295 2008-02-01 Marek Safar <marek.safar@gmail.com>
5297 * support.cs: Fixed broken return.
5299 2008-01-25 Marek Safar <marek.safar@gmail.com>
5301 * report.cs: Correctly reset warnings count after probing.
5303 2008-01-25 Martin Baulig <martin@ximian.com>
5306 (NamespaceEntry.SymbolFileID): Make this work again after
5307 MemberName.ToString() is gone.
5309 2008-01-25 Marek Safar <marek.safar@gmail.com>
5311 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5314 2008-01-25 Marek Safar <marek.safar@gmail.com>
5316 * generic.cs: Use full implicit conversion for type inference fixing.
5318 2008-01-24 Marek Safar <marek.safar@gmail.com>
5320 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5321 Fixed user operator conversions.
5323 2008-01-24 Marek Safar <marek.safar@gmail.com>
5325 * generic.cs: Do nullable type to null comparison optimization during
5328 2008-01-24 Marek Safar <marek.safar@gmail.com>
5330 A fix for bug #355163
5331 * generic.cs: Enabled l-value resolve on nullable expressions.
5333 2008-01-24 Marek Safar <marek.safar@gmail.com>
5335 A fix for bug #353986
5336 * class.cs: Ingore static ctors with parameters for any further checks.
5338 2008-01-24 Marek Safar <marek.safar@gmail.com>
5340 A fix for bug #354310
5341 * namespace.cs: Removed redundant check.
5343 2008-01-24 Marek Safar <marek.safar@gmail.com>
5345 A fix for bug #354928
5346 * expression.cs: ElementInitializers can be resolved only once.
5348 2008-01-24 Marek Safar <marek.safar@gmail.com>
5350 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5351 Condition expressions.
5353 2008-01-23 Marek Safar <marek.safar@gmail.com>
5355 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5357 2008-01-22 Marek Safar <marek.safar@gmail.com>
5359 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5362 * generic.cs: Implemented coalesce expression.
5364 2008-01-22 Marek Safar <marek.safar@gmail.com>
5366 A fix for bug #355145
5367 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5368 expression tree type inference.
5370 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5373 * expression.cs (Binary.IsUnsignedType): Fix typo.
5375 2008-01-22 Marek Safar <marek.safar@gmail.com>
5377 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5379 2008-01-22 Marek Safar <marek.safar@gmail.com>
5381 A fix for bug #355161
5382 * ecore.cs, expression.cs: Wider range of extension method supported
5385 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5387 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5388 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5391 2008-01-22 Marek Safar <marek.safar@gmail.com>
5393 A fix for bug #355148
5394 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5396 2008-01-22 Miguel de Icaza <miguel@novell.com>
5398 * expression.cs (CreateExpressionTree): Add support for or and
5399 logical or, and indent following the coding conventions.
5401 * typemanager.cs (LinqExpression): renamed from
5402 ExpressionTreeManager, for a shorter name.
5404 Use TypeManager.CoreLookupType to lookup types from our core
5405 assemblies and turn those into "Type" variables.
5407 Consumers that previously used "Namespace" and "Type" from this
5408 class should instead use the TypeExpression which is a type that
5409 is fully resolved (without involving the regular C# resolution
5412 This typically looks like this:
5414 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5415 new MemberAccess (texpr, name, type_arguments, loc)
5417 This avoids the problem in: #355178
5419 2008-01-21 Marek Safar <marek.safar@gmail.com>
5421 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5422 feature in parser only as we do in other cases.
5424 2008-01-21 Marek Safar <marek.safar@gmail.com>
5426 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5427 typemanager.cs: A refactoring of params arguments to reuse existing
5428 expressions (params -> array initializer) to emit params argument instead
5429 of specialized handling.
5430 It was required by expression tree implementation and it has other benefits
5431 as well, we now apply same optimization for params arguments as we do for
5434 2008-01-18 Marek Safar <marek.safar@gmail.com>
5436 A fix for bug #353526
5437 * generic.cs: A type inference of params arguments may not required any
5438 temporary array creation.
5440 2008-01-18 Marek Safar <marek.safar@gmail.com>
5442 A fix for bug #353534
5443 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5444 supported for delegates only.
5446 2008-01-18 Marek Safar <marek.safar@gmail.com>
5448 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5449 type for more than 1 candidates.
5451 2008-01-18 Marek Safar <marek.safar@gmail.com>
5453 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5456 2008-01-16 Marek Safar <marek.safar@gmail.com>
5458 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5459 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5460 operator) expressions.
5462 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5464 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5465 not accessed from the generated IL.
5467 2008-01-14 Marek Safar <marek.safar@gmail.com>
5469 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5470 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5471 statement.cs: The first expression tree implementation drop, mostly
5472 infrastructure work.
5474 2008-01-14 Marek Safar <marek.safar@gmail.com>
5476 * ecore.cs (IsNestedChild): Refactored.
5478 2008-01-11 Marek Safar <marek.safar@gmail.com>
5480 * lambda.cs: Don't use a cast on unknown expression statement.
5482 2008-01-10 Geoff Norton <gnorton@novell.com>
5484 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5487 2008-01-09 Marek Safar <marek.safar@gmail.com>
5489 * doc.cs: Report better /doc crash details.
5491 2008-01-09 Marek Safar <marek.safar@gmail.com>
5493 A fix for bug #352536
5494 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5496 2008-01-08 Marek Safar <marek.safar@gmail.com>
5498 A fix for bug #352287
5499 * ecore.cs, expression.cs: Do `this' access checking in all member access
5502 2008-01-08 Marek Safar <marek.safar@gmail.com>
5504 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5506 * report.cs: Reset message stacks.
5508 2008-01-08 Marek Safar <marek.safar@gmail.com>
5510 * generic.cs (InferInPhases): Correctly calculate params position.
5512 2008-01-08 Marek Safar <marek.safar@gmail.com>
5514 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5517 2008-01-07 Marek Safar <marek.safar@gmail.com>
5519 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5521 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5523 * driver.cs: Updated --help option.
5525 2008-01-07 Marek Safar <marek.safar@gmail.com>
5527 * generic.cs (InferParamsTypeArguments): Removed.
5528 (InferInPhases): Add params type inference.
5529 (LowerBoundInference): Fixed scoring mechanism.
5531 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5533 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5535 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5536 byte array for unsigned "baked" assemblies.
5538 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5540 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5541 array for assemblies that are not strongnamed.
5543 2008-01-04 Marek Safar <marek.safar@gmail.com>
5545 A fix for bug #351481
5546 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5547 declaring type for nested generic types.
5549 2008-01-04 Marek Safar <marek.safar@gmail.com>
5551 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5552 instead of ToString.
5554 2008-01-03 Marek Safar <marek.safar@gmail.com>
5556 A fix for bug #351047
5557 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5558 null and structs only when equality and inequality operators are defined
5559 either as an user-operators or predefined operators.
5561 2008-01-03 Marek Safar <marek.safar@gmail.com>
5563 A fix for bug #351047
5564 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5566 2008-01-03 Marek Safar <marek.safar@gmail.com>
5568 A fix for bug #351257
5569 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5571 2008-01-03 Marek Safar <marek.safar@gmail.com>
5573 A fix for bug #351157
5574 * class.cs (Using): Fixed yet another broken cloning.
5576 (Block): Put back more sensible default value for statements.
5578 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5580 * codegen.cs: Allow AssemblyVersion with only major version component.
5583 2007-12-29 Marek Safar <marek.safar@gmail.com>
5585 A fix for bug #324654
5586 * class.cs: Use FullName property as member name.
5588 2007-12-28 Marek Safar <marek.safar@gmail.com>
5590 A fix for bug #342117
5591 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5592 constructor constraint.
5594 2007-12-28 Marek Safar <marek.safar@gmail.com>
5596 A fix for bug #338273
5597 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5600 2007-12-28 Marek Safar <marek.safar@gmail.com>
5602 A fix for bug #350839
5603 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5605 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5607 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5610 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5612 * statement.cs: Changed some Hashtables to use HybridDictionaries
5613 instead. It was observed that some HashTables only contained a few
5614 items in the vast majority of cases. Since HybridDictionary is
5615 more efficient on small sets (<10 elements), "known_variables"
5616 from class ExplicitBlock as well as "labels" and "constants " from
5617 class Block were changed to HybridDictionaries.
5619 Atsai results: (56216kb->54987kb)
5621 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5624 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5626 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5629 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5631 * expression.cs: foreach loop to for loop, saved on allocation of
5632 enumerator (59333kb->59141kb)
5634 * statement.cs. Changed foreach loops to for loops, saved on
5635 allocation of enumerator (59141kb->59006kb)
5637 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5638 when constructed with no specified capacity. This was causing a
5639 few ArrayLists to allocate more memory than they would potentially
5640 need in the Block class and MemberCache class. Setting the
5641 ArrayLists to construct with a capacity of 1 saves some
5642 memory. (56216kb->55585kb)
5644 2007-12-27 Marek Safar <marek.safar@gmail.com>
5646 A fix for bug #347189 (2nd issue)
5647 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5650 2007-12-27 Miguel de Icaza <miguel@novell.com>
5652 * report.cs: Do not use colors if stdout and stderr are not a
5655 2007-12-27 Marek Safar <marek.safar@gmail.com>
5657 A fix for bug #346998
5658 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5661 2007-12-27 Marek Safar <marek.safar@gmail.com>
5663 A fix for bug #343465
5664 * class.cs: Explicit method name for nested types uses dots only.
5666 2007-12-27 Marek Safar <marek.safar@gmail.com>
5668 A fix for bug #343707
5669 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5671 2007-12-27 Marek Safar <marek.safar@gmail.com>
5673 * ecore.cs: Report type inference errors only when arguments count matches
5676 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5678 * expression.cs, report.cs: New warning.
5680 * typemanager.cs: Catch anonymous method type too.
5682 2007-12-23 Marek Safar <marek.safar@gmail.com>
5684 A fix for bug #346379
5685 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5687 2007-12-23 Marek Safar <marek.safar@gmail.com>
5689 A fix for bug #347359
5690 * expression.cs (Invocation): Don't resolve already resolved expression.
5692 2007-12-23 Marek Safar <marek.safar@gmail.com>
5694 A fix for bug #347189
5695 * class.cs (FixedField): Use non-dependent code only in the define phase.
5697 2007-12-23 Marek Safar <marek.safar@gmail.com>
5699 A fix for bug #348076
5700 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5702 2007-12-22 Marek Safar <marek.safar@gmail.com>
5704 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5705 discovered extension methods.
5707 2007-12-22 Marek Safar <marek.safar@gmail.com>
5709 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5712 2007-12-21 Miguel de Icaza <miguel@novell.com>
5714 * report.cs (ErrorMessage): Add support for using colors on
5715 terminals that support it.
5717 2007-12-21 Marek Safar <marek.safar@gmail.com>
5719 * ecore.cs: Use information about expanded params for error reporting.
5721 2007-12-21 Marek Safar <marek.safar@gmail.com>
5723 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5724 and logic for params overloads.
5726 2007-12-15 Miguel de Icaza <miguel@novell.com>
5728 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
5729 as this is also created from the parser. Fixes #349034
5731 2007-12-12 Miguel de Icaza <miguel@novell.com>
5733 * statement.cs (Throw.CloneTo): it is valid to have empty
5734 expressions for throw.
5736 2007-12-03 Marek Safar <marek.safar@gmail.com>
5738 * cs-parser.jay: Set delegate constraint parsing region correctly.
5740 2007-12-03 Marek Safar <marek.safar@gmail.com>
5742 A fix for bug #345467
5743 * typemanager.cs (IsEqual): Compare generic parameters position only.
5745 2007-11-28 Marek Safar <marek.safar@gmail.com>
5747 * expression.cs (BaseAccess): Type arguments can be null.
5749 2007-11-27 Raja R Harinath <harinath@gmail.com>
5751 * statement.cs (Block.Resolve): Ensure flow-branching tree is
5752 consistent even when an error has occured.
5753 (Switch.Resolve): Likewise.
5755 2007-11-22 Marek Safar <marek.safar@gmail.com>
5757 A fix for bug #334505
5758 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
5761 2007-11-22 Marek Safar <marek.safar@gmail.com>
5763 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
5764 refactorings required to resolve extension methods correctly when mixing
5765 generics and non-generics members.
5767 2007-11-20 Marek Safar <marek.safar@gmail.com>
5769 A fix for bug #342584
5770 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
5773 2007-11-19 Marek Safar <marek.safar@gmail.com>
5775 A fix for bug #342512
5776 * delegate.cs: Use delegate argument expression when is available. Don't
5777 emit virtual call when class is sealed.
5779 2007-11-16 Marek Safar <marek.safar@gmail.com>
5781 A fix for bug #325423
5782 * assign.cs (FieldInitializer): Use resolved expression for emit.
5784 * class.cs: Print less confusing error message.
5786 2007-11-16 Marek Safar <marek.safar@gmail.com>
5788 * cs-tokenizer.cs: Removed GMCS ifdefs.
5790 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
5793 * cs-parser.jay: Disabled nullable check.
5795 * generic-mcs: Copied more generic stuff.
5797 2007-11-16 Marek Safar <marek.safar@gmail.com>
5799 * gcs-parser.jay: Merged to cs-parser.jay.
5801 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
5802 * *.csproj, *.sources: Updated to use only jay parser file.
5804 2007-11-16 Marek Safar <marek.safar@gmail.com>
5806 * gcs-parser.jay: Added nullable and default expression feature checks.
5808 2007-11-16 Marek Safar <marek.safar@gmail.com>
5810 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
5811 it fixes many TODOs and hidden bugs.
5813 * expression: Removed duplicate error check.
5815 2007-11-15 Marek Safar <marek.safar@gmail.com>
5817 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
5818 implicitly type local variable only when it is used in a declaration.
5820 2007-11-15 Marek Safar <marek.safar@gmail.com>
5822 * attribute.cs: Use CS0612 for empty strings.
5824 2007-11-14 Marek Safar <marek.safar@gmail.com>
5826 * lambda.cs, statement.cs: Contextual return may act as a statement.
5828 2007-11-14 Marek Safar <marek.safar@gmail.com>
5830 A fix for a regression cause by #324222
5831 * class.cs: Don't report unused even when it implements an interface.
5833 2007-11-13 Marek Safar <marek.safar@gmail.com>
5835 A fix for bug #341205
5836 * ecore.cs, expression.cs: Method group expression cannot do static
5837 method access with an instance reference check before overloading takes
5840 2007-11-13 Marek Safar <marek.safar@gmail.com>
5842 A fix for bug #325359
5843 * class.cs: Use predictable name for automatically generated property.
5845 2007-11-12 Marek Safar <marek.safar@gmail.com>
5847 A fix for bug #324996
5848 * expression.cs (Is): Handle case where D is nullable and T is not
5851 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
5853 2007-11-12 Marek Safar <marek.safar@gmail.com>
5855 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
5856 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
5857 Flush small error reporting changes.
5859 2007-11-09 Marek Safar <marek.safar@gmail.com>
5861 A fix for bug #324996
5862 * expression.cs: Rewrote Is expression implementation to work with
5863 generics, nullable types, anonymous method. A const result expression
5864 uses existing infrastructure instead of custom not fully-featured one.
5866 2007-11-08 Marek Safar <marek.safar@gmail.com>
5868 A fix for bug #340202
5869 * class.cs: Consider generics for volatile field.
5871 2007-11-08 Marek Safar <marek.safar@gmail.com>
5873 A fix for bug #335594
5874 * expression.cs: Use conversion rules when handling string addition.
5876 2007-11-07 Marek Safar <marek.safar@gmail.com>
5878 A fix for bug #336651
5879 * expression.cs: Fixed a crash when probing is on.
5881 2007-11-07 Marek Safar <marek.safar@gmail.com>
5883 A fix for bug #324242
5884 * covert.cs: Added a conversion from any nullable-type with an
5885 underlying enum-type to the type System.Enum.
5887 2007-11-07 Marek Safar <marek.safar@gmail.com>
5889 A fix for bug #324222
5890 * class.cs: Report all non-used event fields.
5892 2007-11-07 Marek Safar <marek.safar@gmail.com>
5894 A fix for bug #325161
5895 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
5896 qualifier for generic types.
5898 2007-11-07 Marek Safar <marek.safar@gmail.com>
5900 A fix for bug #322971
5901 * expression.cs, ecore.cs: Added intermediate result value check for
5904 2007-11-07 Marek Safar <marek.safar@gmail.com>
5906 A fix for bug #324754
5907 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
5908 when it was requested.
5910 2007-11-07 Marek Safar <marek.safar@gmail.com>
5912 A fix for bug #325101
5913 * expression.cs: Do type not value comparison for `is' expression.
5915 2007-11-07 Marek Safar <marek.safar@gmail.com>
5917 A fix for bug #320236
5918 * convert.cs: Don't apply user conversion on underlying target type.
5920 2007-11-06 Marek Safar <marek.safar@gmail.com>
5922 * expression.cs: Don't use unresolved expression for error reporting.
5924 2007-11-06 Marek Safar <marek.safar@gmail.com>
5926 A fix for bugs #337712, #324490
5927 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
5928 overloading resolution too.
5930 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
5931 the process consistent and more robust.
5933 * expression.cs, linq.cs, report.cs: Update.
5935 2007-11-02 Marek Safar <marek.safar@gmail.com>
5937 A fix for bug #332909
5938 * attribute.cs: Resolve attributes in correct context using error
5941 * rootcontext.cs: Define Obsolete attribute members as core members.
5943 2007-11-02 Marek Safar <marek.safar@gmail.com>
5945 * statement.cs: Removed unused methods.
5947 2007-10-31 Wade Berrier <wberrier@novell.com>
5949 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
5950 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
5953 2007-10-31 Marek Safar <marek.safar@gmail.com>
5955 A fix for bug #338102
5956 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
5957 methods registered as non-generics.
5959 2007-10-31 Marek Safar <marek.safar@gmail.com>
5961 A fix for bugs #337712, #324490
5962 * delegate.cs: Delegate covariance and contravariance is not allowed for
5965 2007-10-31 Marek Safar <marek.safar@gmail.com>
5967 A fix for bug #337719
5968 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
5971 2007-10-30 Marek Safar <marek.safar@gmail.com>
5973 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
5975 2007-10-29 Marek Safar <marek.safar@gmail.com>
5977 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
5980 2007-10-29 Raja R Harinath <rharinath@novell.com>
5982 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
5984 2007-10-29 Marek Safar <marek.safar@gmail.com>
5986 A fix for bug #334652
5987 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
5988 extension methods when we have not found the best candidate in normal
5991 2007-10-27 Marek Safar <marek.safar@gmail.com>
5993 * AssemblyInfo.cs: Keep up-to-date.
5995 2007-10-27 Marek Safar <marek.safar@gmail.com>
5997 * Makefile: Fixed generics compiler name.
5999 2007-10-27 Marek Safar <marek.safar@gmail.com>
6001 * lambda.test: removed, lambda parsing is done differently.
6003 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6005 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6007 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6009 2007-10-27 Marek Safar <marek.safar@gmail.com>
6011 * Makefile, *.sources : All C# compilers are in mcs folder.
6013 * *.cs: Use existing 2_1 define for smcs.
6015 2007-10-26 Marek Safar <marek.safar@gmail.com>
6017 A fix for bug #335847
6018 * assign.cs, expression.cs: Couple of changes to avoid creating a
6019 temporary variable for each object initializer assignment statement. It
6020 simplifies struct initialization too, otherwise two temporary variables
6022 Implemented optimization of redundant default element initializers.
6024 2007-10-25 Marek Safar <marek.safar@gmail.com>
6026 A fix for bug #336766
6027 * expression.cs (Class.CheckBase): Use generic name when method is
6030 2007-10-25 Marek Safar <marek.safar@gmail.com>
6032 A fix for bug #334737
6033 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6034 variable and not variable argument for prepared copies.
6036 2007-10-24 Marek Safar <marek.safar@gmail.com>
6038 A fix for bug #325110
6039 * class.cs, expression.cs, attribute.cs: Use open generic method when
6040 checking conditional attribute.
6042 2007-10-24 Marek Safar <marek.safar@gmail.com>
6044 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6045 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6046 FeatureIsNotAvailable.
6048 2007-10-24 Marek Safar <marek.safar@gmail.com>
6050 ** C# 3.0 Partial methods
6052 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6053 methods support. Because of member cache issue with generics only
6054 non-generics partial methods are fully supported.
6056 2007-10-23 Marek Safar <marek.safar@gmail.com>
6058 * class.cs, decl.cs: Rewrote member overloads check to cope with
6059 generics and to use member cache for member checking. It also improves
6060 performance and fixes remaining overloads issues.
6062 2007-10-20 Marek Safar <marek.safar@gmail.com>
6064 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6065 roottypes.cs, typemanager.cs:
6067 A member cache creation logic changed to add members immediately and
6068 not rely on fallback. The member cache is now only prefered way
6069 how to access and find type declaration members. It saves 5 MB of memory
6070 during MWF compilation and makes code ready for more optimizations and
6071 clean-ups, it's also a pre-requirement for partial methods.
6073 2007-10-18 Raja R Harinath <harinath@gmail.com>
6075 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6076 handling for generic parameters.
6078 2007-10-15 Marek Safar <marek.safar@gmail.com>
6080 * class.cs (FixedField): Removed redundant volatile check.
6082 2007-10-15 Marek Safar <marek.safar@gmail.com>
6084 * class.cs, decl.cs: Fixed overload members verification to do only one
6085 check per possible collision.
6087 2007-10-13 Marek Safar <marek.safar@gmail.com>
6089 A fix for bug #325478
6090 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6091 and create only one disposable flags container.
6093 2007-10-12 Marek Safar <marek.safar@gmail.com>
6095 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6096 * statement.cs (Fixed): Fixed variables cloning.
6098 2007-10-12 Marek Safar <marek.safar@gmail.com>
6100 A fix for bug #333342
6101 * class.cs (EventField): Don't mark value type event as synchronized.
6103 2007-10-12 Marek Safar <marek.safar@gmail.com>
6105 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6106 inference to identify best candidate method correctly.
6107 (ProperyExpr): A range variable is read only and cannot be modified.
6109 2007-10-11 Marek Safar <marek.safar@gmail.com>
6111 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6112 logic to identify best candidate method correctly.
6114 2007-10-11 Marek Safar <marek.safar@gmail.com>
6116 * location.cs (Equals, GetHashCode): Removed.
6118 2007-10-11 Marek Safar <marek.safar@gmail.com>
6120 * report.cs: Implemented message recorder. It is used mainly for lambda
6121 expressions to capture otherwise swallowed error messages.
6123 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6125 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6127 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6129 * expression.cs (MemberAccess): Always report lookup failure.
6131 * location.cs: Implemented Equals, GetHashCode.
6133 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6135 2007-10-10 Jb Evain <jbevain@novell.com>
6137 * codegen.cs: re-enable assembly version check.
6139 2007-10-09 Marek Safar <marek.safar@gmail.com>
6141 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6144 * namespace.cs (UsingAlias): Do correct version check.
6146 2007-10-08 Marek Safar <marek.safar@gmail.com>
6148 * expresison.cs, ecore.cs: Issue extension method error message when
6151 * rootcontext.cs: Added ISO_2 compiler mode option.
6153 2007-10-08 Marek Safar <marek.safar@gmail.com>
6155 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6158 2007-10-08 Marek Safar <marek.safar@gmail.com>
6160 * attribute.cs (GetString, GetBoolean): Work with both literal and
6163 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6164 Moved method overload specific methods to MethodGroupExpr.
6166 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6167 it should be less memory consuming.
6169 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6171 * codegen.cs: remove the assembly version check until the buildbot is
6174 2007-10-07 Jb Evain <jbevain@novell.com>
6176 * attribute.cs (Attribute.GetString): if the value
6177 expression is a StringConstant, return its string value.
6179 2007-10-07 Jb Evain <jbevain@novell.com>
6181 * typemanager.cs: add `assembly_version_attribute_type`.
6182 * codegen.cs: on attribute emission, check that the
6183 AssemblyVersionAttribute doesn't overflow.
6185 2007-10-05 Marek Safar <marek.safar@gmail.com>
6187 A fix for bug #324677
6188 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6189 parent container of a scope container with currently resolved one.
6191 2007-10-05 Marek Safar <marek.safar@gmail.com>
6193 A fix for bug #325534
6194 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6197 2007-10-05 Marek Safar <marek.safar@gmail.com>
6199 A fix for bug #327504
6200 * class.cs (Operator.Define): Refactored implicit and explicit user
6201 operator conversion rules.
6203 2007-10-05 Marek Safar <marek.safar@gmail.com>
6205 A fix for bug #327520
6206 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6208 2007-10-04 Marek Safar <marek.safar@gmail.com>
6210 A fix for bug #328022
6211 * class.cs (MethodData.Define): Use correct method to check whether
6212 a method implementents an accessor.
6214 2007-10-04 Marek Safar <marek.safar@gmail.com>
6216 A fix for bug #330069
6217 * statement.cs (Fixed.Resolve): Read the first array element only when
6218 an array is instantiated.
6220 2007-10-04 Marek Safar <marek.safar@gmail.com>
6222 * expression.cs, assign.cs, generics.cs: Print correct operator when
6223 compound assignment is used.
6225 2007-10-04 Marek Safar <marek.safar@gmail.com>
6227 A fix for bug #325841
6228 * expression.cs (ArrayAccess): Use full argument cloning only for
6229 string compound concatenation.
6231 2007-10-03 Marek Safar <marek.safar@gmail.com>
6233 A fix for bug #328774
6234 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6236 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6239 2007-10-03 Raja R Harinath <rharinath@novell.com>
6242 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6243 Event accessibility checks here. Remove some bogus code that
6244 accidently made GenericMethods work.
6245 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6247 2007-09-25 Marek Safar <marek.safar@gmail.com>
6249 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6251 * statement.cs (Block): Refactored AddVariable to allow error handling
6254 * generic.cs: New stub.
6256 2007-09-23 Marek Safar <marek.safar@gmail.com>
6258 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6261 2007-09-17 Marek Safar <marek.safar@gmail.com>
6263 * class.cs: Use partial container to record whether any partial part
6264 contains static field initializer and therefore default contructor has
6267 2007-09-14 Marek Safar <marek.safar@gmail.com>
6269 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6270 mono-list when only one of two partial parts has defined accessibility
6273 2007-09-14 Marek Safar <marek.safar@gmail.com>
6275 A fix for bug #82845
6277 * class.cs (TypeContainer): Set correct resolve context for all field
6280 2007-09-13 Marek Safar <marek.safar@gmail.com>
6282 * assign.cs: Fixed a crash when field is resolved twice with an error.
6284 * codegen.cs: Changed InFieldInitializer to be flag.
6286 * anonymous.cs, ecore.cs, expression.cs: Update after
6287 IsInFieldInitializer rename.
6289 * const.cs: Removed unused parameter.
6291 * class.cs: Changed the way how we resolve and emit field initializers.
6292 The field initilizers have to have access to contructor block to emit
6293 compiler generated code.
6295 2007-09-13 Marek Safar <marek.safar@gmail.com>
6297 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6298 generics use TypeContainer instead.
6300 2007-09-12 Marek Safar <marek.safar@gmail.com>
6302 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6304 * lambda.cs (ResolveParameters): Use more powerful
6305 InflateGenericArgument.
6307 * parameters.cs: Better exception message.
6309 2007-09-10 Marek Safar <marek.safar@gmail.com>
6311 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6312 correct expression block type.
6314 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6316 * expression.cs (Invocation): Extracted method group resolve to
6319 2007-09-07 Marek Safar <marek.safar@gmail.com>
6321 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6322 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6324 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6325 generic extension methods.
6327 2007-09-06 Marek Safar <marek.safar@gmail.com>
6329 A fix for bug #82676 (Do I get it right now?)
6330 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6331 object before a standard conversion is applied.
6333 2007-09-06 Marek Safar <marek.safar@gmail.com>
6335 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6338 2007-09-05 Marek Safar <marek.safar@gmail.com>
6340 A fix for bug #82676
6341 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6342 non-generic interface types.
6344 2007-09-05 Marek Safar <marek.safar@gmail.com>
6346 A fix for bug #82690
6347 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6349 2007-09-05 Marek Safar <marek.safar@gmail.com>
6351 A fix for bug #82571
6352 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6353 modifier for container based methods.
6355 2007-09-05 Marek Safar <marek.safar@gmail.com>
6357 A fix for bug #82676
6358 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6359 any interface-type T means to any of interface type T.
6361 2007-09-04 Marek Safar <marek.safar@gmail.com>
6363 * namespace.cs: We have 2 versions of System.Core assembly.
6365 2007-09-04 Marek Safar <marek.safar@gmail.com>
6367 A fix for bug #82652
6368 * class.cs (Class.GetClassBases): Compare types and not expressions.
6370 2007-09-04 Marek Safar <marek.safar@gmail.com>
6372 A fix for bug #82620
6373 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6374 actually never worked before.
6375 (IndexerAccess): Emit prepared arguments before they are modified.
6377 2007-09-04 Marek Safar <marek.safar@gmail.com>
6379 A fix for bug #82563
6380 * assign.cs: Revert wrong fix.
6382 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6384 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6385 Instead of ldelema/stdind we have to use temporary variables to handle
6386 cases like String.Concat (params string[]).
6388 2007-08-31 Marek Safar <marek.safar@gmail.com>
6390 * class.cs: EmitAttributes to Emit rename.
6392 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6394 (MemberCore.HasClsCompliantAttribute): Don't depend on
6395 GetClsCompliantAttributeValue execution.
6397 2007-08-31 Marek Safar <marek.safar@gmail.com>
6399 * anonymous.cs: Use shorter type prefix.
6401 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6404 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6405 variables when probing is on.
6407 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6408 unresolved variables.
6409 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6410 handle transparent identifiers.
6412 2007-08-26 Marek Safar <marek.safar@gmail.com>
6414 * attribute.cs (IsClsCompliant): Add nullable types test.
6416 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6418 * doc.cs : catch other types of exception than XmlException to
6419 report CS1570. Fixed bug #82565.
6421 2007-08-23 Marek Safar <marek.safar@gmail.com>
6423 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6424 The number of delegate parameters has to match.
6425 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6428 2007-08-21 Marek Safar <marek.safar@gmail.com>
6430 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6431 to fix problem with private arguments.
6433 2007-08-20 Marek Safar <marek.safar@gmail.com>
6435 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6437 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6439 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6440 empty. Add cloning suport.
6442 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6444 2007-08-20 Marek Safar <marek.safar@gmail.com>
6446 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6447 to create EmptyCast. It handles EmptyConstantCast specialization for
6450 2007-08-18 Marek Safar <marek.safar@gmail.com>
6452 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6453 (EmitArrayArgument): One routine for array arguments.
6454 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6456 2007-08-17 Marek Safar <marek.safar@gmail.com>
6458 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6460 2007-08-17 Marek Safar <marek.safar@gmail.com>
6462 * anonymous.cs: MemberLookupFinal update.
6464 * class.cs (ConstructorInitializer): Is expression based.
6466 * delegate.cs: MethodGroupExpr update.
6468 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6470 (Error_MemberLookupFailed): Customizable error override.
6471 (MethodGroupExpr): Keep queried type for later usage.
6472 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6475 * expression.cs: Error_MemberLookupFailed refactoring.
6476 (New.DoResolve): Resolve as much as possible.
6477 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6478 customization for invalid member types.
6480 * statement.cs: MethodGroupExpr update.
6482 2007-08-16 Marek Safar <marek.safar@gmail.com>
6484 * modifier.cs (Check): Check all modifiers and not only accessibility
6487 2007-08-16 Marek Safar <marek.safar@gmail.com>
6489 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6490 type and not an expression.
6492 2007-08-16 Marek Safar <marek.safar@gmail.com>
6494 * statement.cs (Catch.Clone): Type and variable can be null.
6496 2007-08-16 Marek Safar <marek.safar@gmail.com>
6498 A fix for bug #81979
6499 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6500 I am really not sure whether this is the best fix.
6502 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6505 2007-08-14 Marek Safar <marek.safar@gmail.com>
6507 ** C# 3.0 Object and collection initializers (major re-write)
6509 * assign.cs (DoResolve): Initializers are not assign related.
6511 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6512 used during collection or object initialization.
6514 * expression.cs (Error_InvalidArguments): Add initializers specific
6515 messages. More will come later because it requires some general
6517 (New.DoResolve): Better error handling for unsafe types.
6518 (EmptyExpressionStatement): New class.
6519 (ElementInitializer): An object initializer expression.
6520 (CollectionElementInitializer): A collection initializer expression.
6521 (CollectionOrObjectInitializers): A block of object or collection
6523 (NewInitialize): New expression with element/object initializers.
6525 * statement.cs: Reverted object/collection initializer hacks.
6527 * typemanager.cs (CSharpName): Filter __arglist type.
6529 2007-08-09 Marek Safar <marek.safar@gmail.com>
6531 ** C# 3.0 Anonymous Types (update to the latest standard)
6533 * expression.cs (Binary.ResolveOperator): Threat all null based types
6535 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6536 (AnonymousTypeParameter): Updated.
6538 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6539 (AnonymousTypeClass): New anonymous type container.
6541 * class.cs (AddField): Return operation result.
6543 * generic.cs: Another empty TypeArguments overload.
6545 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6546 are stored at top of normal hierarchy.
6548 * typemanager.cs (CSharpName): Filter anonymous types.
6550 2007-08-09 Marek Safar <marek.safar@gmail.com>
6552 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6553 as single Concat call. How could we miss that :-(
6555 2007-08-08 Marek Safar <marek.safar@gmail.com>
6557 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6559 2007-08-07 Miguel de Icaza <miguel@novell.com>
6561 * expression.cs: Fix the previous commit, the creation of the
6562 arguments array list needs also to be conditional on the arguments
6565 * class.cs: Add a little bit of help to help narrow down problems.
6567 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6568 not try to copy in that case.
6570 * driver.cs: When building SMCS, include a new different set of
6571 default assemblies here. Do this here so we can control whether
6572 to include the default assemblies with /noconfig.
6574 2007-08-03 Marek Safar <marek.safar@gmail.com>
6576 A fix for bug #81979
6577 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6580 2007-08-03 Marek Safar <marek.safar@gmail.com>
6582 A fix for bug #82300
6584 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6585 we are in probing scope.
6587 2007-08-03 Marek Safar <marek.safar@gmail.com>
6589 A fix for bug #82301
6591 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6592 (Statement.CloneTo): Clone and not map children blocks.
6594 2007-08-03 Marek Safar <marek.safar@gmail.com>
6596 A fix for bug #82299
6598 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6601 * statement.cs (Statement.CloneTo): Clone variables before statements
6602 to allow remaping of local variables.
6604 2007-08-03 Marek Safar <marek.safar@gmail.com>
6606 A fix for bug #82296
6609 * report.cs: Log crash details for future clone problems.
6611 * statement.cs (Return.Clone): Don't clone non-existent expression.
6613 2007-08-03 Raja R Harinath <harinath@gmail.com>
6615 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6616 (Class.AddBasesForPart): Move CS0537 check here from ...
6617 * cs-parser.jay (class_declaration): ... here. Move calling of
6618 'AddBasesForPart' to ...
6619 (class_bases): ... here.
6620 (struct_declaration, interface_declaration): Update to changes.
6622 2007-08-02 Marek Safar <marek.safar@gmail.com>
6624 A fix for bug #81923
6626 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6627 conversion is allowed.
6629 2007-08-02 Marek Safar <marek.safar@gmail.com>
6631 A fix for bug #81564
6633 * ecore.cs (EventExpr): Add IsBase handling.
6635 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6638 2007-08-02 Raja R Harinath <harinath@gmail.com>
6640 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6641 * cs-parser.jay: Some whitespace cleanups.
6642 (current_delegate): New.
6644 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6645 a dummy code block, and use 'type_name' instead of 'member_name'.
6646 (interface_declaration, class_declaration): Likewise.
6647 (delegate_declaration): Likewise. Rearrange slightly and use
6649 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6650 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6652 2007-08-02 Marek Safar <marek.safar@gmail.com>
6654 A fix for bug #82039
6656 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6659 * typemanager.cs (CSharpName): Split to string overload.
6661 2007-08-02 Marek Safar <marek.safar@gmail.com>
6664 * report.cs: Updated warning CS0472.
6666 2007-08-01 Marek Safar <marek.safar@gmail.com>
6668 A fix for bug #82181
6670 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6672 2007-08-01 Marek Safar <marek.safar@gmail.com>
6674 A fix for bug #82277
6675 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6677 2007-08-01 Marek Safar <marek.safar@gmail.com>
6679 ** C# 3.0 Type Inference (major bits are working)
6681 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6682 (.ImplicitStandardConversionExists): Uses compatible.
6683 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6684 (.InferReturnType): New method.
6685 (.Compatible): Refactored.
6686 (.ResolveParameters): Uses factory to create resolved parameters.
6687 (.CompatibleMethod): Add probing mode support.
6688 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6689 clearly distinguish between 2 different operations.
6690 (LambdaMethod): Moved to lambda.cs.
6691 (AnonymousMethod): Removed unused fields and methods.
6692 (AnonymousDelegate): Simplified.
6694 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6696 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6698 * delegate.cs (Delegate): New mehods to reduce code duplication.
6699 (.GetConstructor): New method.
6700 (.GetInvokeMethod): New method.
6701 (DelegateCreation): Updated.
6703 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6705 (OverloadResolve): Made probing little bit faster.
6707 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6710 * generic.cs (TypeInferenceContext): Dummy implementation.
6712 * iterators.cs: Updated after Resolve/Define rename.
6714 * lambda.cs (LambdaExpression)
6715 (.ResolveParameters): Handles both type of arguments and type inference too.
6717 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6718 (InflateTypes): Updated.
6720 * support.cs (InflateTypes): Changed signature and updated.
6722 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6723 (MemberLookup_FindMembers): More MS tricks.
6724 (GetParameterData): Ditto.
6725 (GetDelegateParameters): Uses quick path for dynamic types.
6727 2007-08-01 Marek Safar <marek.safar@gmail.com>
6729 * class.cs (MethodData.Define): EmitContext is required for generic stuff
6732 2007-07-31 Marek Safar <marek.safar@gmail.com>
6734 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
6737 2007-07-26 Jb Evain <jbevain@novell.com>
6739 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
6740 which takes a boolean 'report_errors', similar to the GetMethod.
6741 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
6742 in .net 2.1, do not report errors here.
6744 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
6745 System.Runtime.CompilerServices.RequiredAttributeAttribute and
6746 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
6749 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
6750 of the type InternalsVisibleToAttribute before the first call
6751 to CoreLookupType which is allowed to fail (third boolean parameter
6752 to true). Because, during the resolution for a type that is not
6753 immediately found, we try to check if the type is not defined in
6754 a friend assembly, and to do so, we need the
6755 InternalVisibleToAttribute.
6757 2007-07-23 Miguel de Icaza <miguel@novell.com>
6759 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
6760 feature that allows structs to be compared against null and inline
6761 the result as true or false.
6763 Notice that the same code is not permitted inside a generic block
6764 of code that would do:
6766 class Foo<T> where T : struct {
6773 It is only allowed if the type of T is not bound (no where
6774 clause). In my opinion, this CSC 2 behavior is broken but people
6775 seem to be using it (IronRuby does, a few bug reports on bugzilla
6776 have it and some people have complained about it).
6778 All of the users that depend on this behavior have code that is
6781 * report.cs (Warning, Error): make these take object arguments,
6782 not strings, as that allows us to take advantage of Format.
6784 2007-07-20 William Holmes <billholmes54@gmail.com>
6786 * decl.cs: Changed MemberName.CountTypeArguments to also check the
6787 Left member variable for the Count.
6788 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
6789 MemberName.CountTypeArguments to avoid a NRE.
6791 This code is contributed under the MIT X11 license
6793 2007-07-18 Marek Safar <marek.safar@gmail.com>
6795 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
6797 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6799 * doc.cs : generic method arguments are written as ``x while generic
6800 type arguments are `x. Combined with the previous change, fixed bug
6803 2007-07-18 Raja R Harinath <rharinath@novell.com>
6806 * expression.cs (Binary.ResolveOperator): When converting
6807 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
6809 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6811 * doc.cs : when T: or whatever x: is specified, it does not really
6812 check the doc comment's syntax correctness. Fixed bug #82006.
6814 2007-07-18 Marek Safar <marek.safar@gmail.com>
6816 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
6817 LambdaExpression better.
6819 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
6821 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
6823 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
6824 as it can be generated.
6826 * expression.cs (Invocation.Error_InvalidArguments): Show correct
6829 * lambda.cs (LambdaExpression): Refactored to share same code with
6830 AnonymousMethodExpression.
6832 2007-07-17 Marek Safar <marek.safar@gmail.com>
6834 * anonymous.cs (MakeName): Include host name for easier debugging.
6835 (LambdaMethod): New class for lambda spcecific stuff.
6837 * attribute.cs: Set EmitContext return type.
6839 * class.cs: Set EmitContext return type.
6841 * codegen.cs (EmitContext): Return type cannot be null to stop messing
6842 with null/void meaning.
6844 * iterators.cs (ContainerType): Implemented.
6846 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
6848 * statement.cs (Return): Updated to lambda expressions.
6849 (Block.CloneTo): Parent can be null.
6851 2007-07-13 Marek Safar <marek.safar@gmail.com>
6853 A fix for bug #81917
6854 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
6856 * class.cs (FixedField): Check whether field is in unsafe scope.
6858 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
6859 (FieldExpr.Emit): Fixed buffers cannot be volatile.
6861 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
6864 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
6866 2007-07-13 Marek Safar <marek.safar@gmail.com>
6868 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
6869 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
6872 2007-07-13 Marek Safar <marek.safar@gmail.com>
6874 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
6876 2007-07-13 Marek Safar <marek.safar@gmail.com>
6878 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
6879 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
6881 * codegen.cs(EmitContext): Add ProbingMode flag.
6883 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
6885 * driver.cs: For now set both warning values.
6887 * ecore.cs (SimpleName): Name is readonly.
6888 (MethodGroup.OverloadResolve): One quick path for probing.
6890 * expression.cs (Unary): Set Oper r/o.
6891 (Binary): Set Oper r/o.
6892 (ParameterReference): Set few instance variables as r/o.
6893 (ParameterReference.DoResolveBase): Don't capture aruments when
6895 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
6896 (Arglist): arguments are private.
6897 (SizeOf): type is private and r/o.
6898 (MemberAccess): arguments are private.
6900 * report.cs: Enhanced reporting on/off capabilities.
6902 * lambda.cs: Uses ec.IsInProbingMode.
6903 (ContextualReturn): Derives from return.
6905 * rootcontext.cs: For now set both warning values.
6907 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
6909 (Return.Resolve): Don't die immediately.
6910 (Block.Resolve): Speed-up probing.
6911 (Block.CloneTo): Clone only child blocks.
6913 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
6915 * iterators.cs: reverted Miguel's latest change (r81925) as it
6916 breaks the build in System.
6918 2007-07-13 Miguel de Icaza <miguel@novell.com>
6920 * iterators.cs (Yield.CheckContext): Check for the iterator type
6921 also here as we can call into Yield even in codepaths that are not
6923 (MethodOrOperator is the only path that was checked).
6925 In addition to the standard check, use a more specific check for
6926 constructors to report a more verbose error.
6928 2007-07-12 Miguel de Icaza <miguel@novell.com>
6930 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
6931 report the warning and continue
6933 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
6934 values on the stack on the call to Emit. Use EmitStatement if
6935 possible, or using Emit + Pop if not possible. Fixes #82064
6937 2007-07-12 Raja R Harinath <rharinath@novell.com>
6939 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
6940 avoid try...finally in some cases.
6942 2007-07-10 Marek Safar <marek.safar@gmail.com>
6944 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
6946 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
6947 instead of method. Re-use standard error handling.
6948 (ConstructorInitializer.Emit): Simplified.
6950 * delegate.cs: Updated after Invocation.EmitCall change.
6952 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
6953 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
6954 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
6955 method and don't permanently changing input arguments.
6956 (MethodGroupExpr): Introduced resolved best_candidate, when method group
6957 is resolved it has one of the candidates is the best one which is later
6958 used to emit. Removed a few unused method.
6959 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
6961 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
6962 (Binary.ResolveOperator): Ditto.
6963 (ConditionalLogicalOperator.DoResolve): Ditto.
6964 (Invocation): Uses method group.
6965 (Invocation.DoResolve): Simplified.
6966 (Invocation.EmitCall): Removed useless is_static.
6967 (Invocation.Emit): Delegate to method group.
6968 (Invocation.EmitStatement): Simplified.
6969 (New): Uses method group.
6970 (MemberAccess.DoResolve): Don't destroy original expression.
6972 * statement.cs (ForEach.Resolve): Use null for no method arguments.
6974 2007-07-04 Marek Safar <marek.safar@gmail.com>
6976 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
6979 * lambda.cs: Add custom error message type.
6981 2007-07-03 Marek Safar <marek.safar@gmail.com>
6983 * lambda.cs: Simplified little bit.
6985 * parameter.cs: Introduced ImplicitLambdaParameter.
6986 (Parameters.CreateFullyResolved): New factory instead of ctor.
6990 * delegate.cs: Updated parameter creation.
6992 2007-07-03 Marek Safar <marek.safar@gmail.com>
6994 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
6997 * generic.cs: Synchronized with gmcs.
6999 2007-07-03 Marek Safar <marek.safar@gmail.com>
7001 * class.cs (Indexer): Check return type as soon as possible.
7003 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7006 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7008 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7010 * parameter.cs (Parameter): Use expression type when it is available.
7012 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7013 method modifier for the first parameter only.
7015 2007-06-24 Marek Safar <marek.safar@gmail.com>
7017 A fix for bug #81938
7018 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7020 * constant.cs: Tide up an exception message.
7022 2007-06-22 Marek Safar <marek.safar@gmail.com>
7024 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7025 an uninitialized variable is used.
7027 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7029 2007-06-22 Marek Safar <marek.safar@gmail.com>
7031 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7032 not found error handling.
7034 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7036 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7037 (ArrayCreation.DoResolve): Simplified.
7038 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7039 its own resolve process.
7040 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7042 2007-06-20 Marek Safar <marek.safar@gmail.com>
7044 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7047 2007-06-20 Marek Safar <marek.safar@gmail.com>
7049 * cs-tokenizer.cs: Removed var related stuff.
7051 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7052 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7053 a type and a keyword at same time.
7055 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7058 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7059 implicitly typed arrays, more changes will follow.
7061 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7063 2007-06-19 Marek Safar <marek.safar@gmail.com>
7065 * ecore.cs (VarExpr): Removed Handled field.
7067 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7068 build-in assign functionality.
7069 (ForEach.Resolve): Removed all implicitly typed local variable code and
7071 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7072 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7074 2007-06-18 Marek Safar <marek.safar@gmail.com>
7076 * assign.cs: Removed implicitly typed local variable check.
7078 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7079 referencing implicitly typed local variable.
7080 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7083 * statement.cs (Fixed): Removed unsupported implicitly typed local
7086 2007-06-15 Marek Safar <marek.safar@gmail.com>
7088 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7090 2007-06-14 Marek Safar <marek.safar@gmail.com>
7092 A fix for bugs #81855 and #76274
7093 * attribute.cs (AttachTo): Always set owner for global attributes to
7096 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7099 * cs-parser.jay: Assembly and module attributes must precede all other
7100 elements except using clauses and extern alias declarations.
7102 2007-06-13 Marek Safar <marek.safar@gmail.com>
7104 A fix for bug #81748
7106 * expression.cs: More checks for non ISO-1 features.
7108 2007-06-12 Marek Safar <marek.safar@gmail.com>
7110 A fix for bug #81807
7111 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7112 present inside switch statement and it is required by nullable check.
7114 2007-06-12 Marek Safar <marek.safar@gmail.com>
7116 A fix for bug #81840
7117 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7118 when type matching fails.
7120 * namespace.cs: Tiny error message change.
7122 2007-06-12 Marek Safar <marek.safar@gmail.com>
7124 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7125 reporting. Added automatic property check.
7127 * class.cs: Updated after CheckAbstractAndExtern relocation.
7128 (AEventPropertyAccessor.GetSignatureForError): Customized.
7130 2007-06-11 Marek Safar <marek.safar@gmail.com>
7132 * class.cs (DefineBaseTypes): Base type can be undefined.
7134 * ecore.cs (TypeLookup): Minor refactoring.
7135 (DoResolveAsTypeStep): Removed redundant check.
7137 * namespace.cs (Lookup): Removed redundant check.
7139 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7140 ResolveAsTypeTerminal step.
7141 (BootstrapCorlib_*): Simplified.
7142 (PopulateCoreType): Core types can be now external.
7144 2007-06-07 Marek Safar <marek.safar@gmail.com>
7146 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7148 (InferTypeArguments): Infers anonymous expression type arguments.
7149 (Compatible): Split to Compatible and InferTypeArguments.
7151 * lambda.cs: Updated.
7153 2007-06-08 Marek Safar <marek.safar@gmail.com>
7155 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7157 2007-06-07 Raja R Harinath <harinath@gmail.com>
7159 Fix #80477, cs0135-2.cs, cs0135-3.cs
7160 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7161 names to the "known" variables list.
7162 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7163 parameter names are also "known".
7164 (Block.CheckError136): Remove.
7165 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7168 2007-06-07 Marek Safar <marek.safar@gmail.com>
7170 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7172 2007-06-06 Marek Safar <marek.safar@gmail.com>
7174 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7175 internal error not an user error.
7177 * expression.cs (IsApplicable): Refactored to make debugging easier.
7179 * support.cs: More tricks for non-mono runtimes.
7181 * typemanager.cs (CoreLookupType): Made public.
7182 (InitSystemCore): All linq specific stuff moved to linq.cs
7184 2007-06-05 Marek Safar <marek.safar@gmail.com>
7186 * typemanager.cs (CSharpSignature): One more missing build-in types
7188 More tricks for non-mono runtime.
7190 2007-06-05 Raja R Harinath <harinath@gmail.com>
7192 * statement.cs (Block.CheckError136_InParents): Remove.
7193 (Block.AddVariable): Use GetParameterInfo instead.
7194 (ToplevelBlock.ProcessArguments): Likewise.
7196 2007-06-04 Raja R Harinath <rharinath@novell.com>
7198 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7200 (ToplevelBlock.GetParameterInfo): Split out of ...
7201 (ToplevelBlock.GetParameterRefernce): ... this.
7202 (ToplevelBlock.ParameterMap): Remove.
7203 * expression.cs (ParameterReference): Update to use
7204 ToplevelParameterInfo.
7206 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7209 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7210 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7212 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7213 (ToplevelBlock.ProcessParameters) ... here.
7214 (ToplevelBlock..ctor): Invoke it.
7216 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7219 * statement.cs (IKnownVariable): New interface.
7220 (LocalInfo): Implement it.
7221 (ToplevelParameterInfo): New class.
7222 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7223 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7224 GetKnownVariableInfo.
7226 2007-06-03 Raja R Harinath <harinath@gmail.com>
7228 Partly speed up CS0136 error checks.
7229 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7230 'recurse' parameter.
7231 (Block.DoCheckError136): Only check errors in parameters. Move
7232 local variable checks ...
7233 (Block.AddVariable): ... here, and ...
7234 (ToplevelBlock.ResolveMeta): ... here.
7236 2007-06-02 Raja R Harinath <harinath@gmail.com>
7238 * statement.cs (Block.IsChildOf): Remove.
7240 * statement.cs (Statement.Clone): Move special case code ...
7241 (Block.CloneTo): ... here.
7243 2007-05-29 Raja R Harinath <rharinath@novell.com>
7245 * statement.cs (ToplevelBlock.container): Remove field. It's
7246 redundant with 'Parent'.
7247 (ToplevelBlock.ContainerBlock): Remove accessor.
7248 (ToplevelBlock..ctor): Update to changes. Register anonymous
7249 child with parent here, ...
7250 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7252 (start_anonymous): Don't save current_block.
7253 (top_current_block): Remove.
7255 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7256 (Block.Resolve): Update to changes.
7257 (Block..ctor): Move setting of "correct" 'Toplevel'
7258 and 'Explicit' fields to ...
7259 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7261 2007-05-27 Raja R Harinath <harinath@gmail.com>
7264 * statement.cs (Block.Implicit): Remove.
7265 (Block): Update to changes.
7266 * flowanalysis.cs: Likewise.
7268 Mildly speed up CheckInvariantMeaningInBlock
7269 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7270 Recursively call AddKnownVariable to all enclosing blocks.
7271 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7272 Remove recursive calls.
7273 (Block): Update to changes.
7275 New ExplicitBlock invariants
7276 * statement.cs (Block.Explicit): New field. It points to the
7277 immediately enclosing non-implicit block.
7278 (Block..ctor): Maintain the invariant.
7279 * cs-parser.jay: Take advantage of invariant.
7281 Introduce ExplicitBlock
7282 * statement.cs (ExplicitBlock): New.
7283 (ToplevelBlock): Derive from it.
7284 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7286 (Block.Implicit): Update to changes.
7287 * cs-parser.jay: Update to changes.
7290 * codegen.cs (EmitContext.IsLastStatement): Remove.
7291 * statement.cs (Block.DoEmit): Update to changes.
7293 2007-05-25 Raja R Harinath <rharinath@novell.com>
7295 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7296 modifying current_block directly.
7298 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7300 * class.cs: Implemented automatic properties (C# 3.0)
7301 Thanks to Marek for the help.
7303 2007-05-23 Raja R Harinath <rharinath@novell.com>
7305 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7306 variable as assigned, note also that all its components are
7308 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7310 2007-05-19 Marek Safar <marek.safar@gmail.com>
7312 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7313 member is marked as compiler generated.
7315 * decl.cs (MemberCore): Refactored ModFlags into property.
7317 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7318 (Check): Check only accessibility modifiers.
7320 2007-05-18 Raja R Harinath <rharinath@novell.com>
7322 Track all assignable slots in one bit array
7323 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7324 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7325 logic from VariableMap constructor here. Use the same 'offset'
7326 variable that's later used for computing offsets of local
7328 * flowanalysis.cs (UsageVector.parameters): Remove.
7329 (UsageVector): Update to changes.
7330 (VariableMap): Remove.
7332 Avoid creating ParameterMap in every block
7333 * statement.cs (Block.ParameterMap): Move ...
7334 (ToplevelBlock.ParameterMap): ... here.
7335 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7337 * flowanalysis.cs (FlowBranching.param_map): Remove.
7338 (FlowBranching.UsageVector): Update to changes.
7339 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7341 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7343 * expression.cs (ParameterReference): Distinguish between block
7344 where parameter was referenced and declared.
7346 2007-05-18 Marek Safar <marek.safar@gmail.com>
7348 * flowanalysis.cs, statement.cs: Put back improved error handling.
7350 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7354 Imporved object and collection initialization (C# 3.0).
7356 2007-05-15 Marek Safar <marek.safar@gmail.com>
7358 A fix for bug #81380
7359 * expression.cs (Is.DoResolve): Only value types have constant `is'
7362 2007-05-15 Raja R Harinath <rharinath@novell.com>
7364 * statement.cs (ToplevelBlock.child): Remove.
7366 2007-05-15 Raja R Harinath <harinath@gmail.com>
7368 Rationalize ResolveMeta: refactoring
7369 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7370 out constant handling code into ...
7371 (Block.DoResolveConstants): ... this.
7373 Rationalize ResolveMeta: kill local_map
7374 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7375 (Block.AssignableSlots): New.
7376 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7377 for locals -- move code from VariableMap here. Avoid unnecessary
7379 * flowanalysis.cs (FlowBranching.local_map): Remove.
7380 (FlowBranching..ctor): Use Block.AssignableSlots.
7381 (VariableMap): Remove unused constructors.
7383 2007-05-11 Raja R Harinath <rharinath@novell.com>
7385 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7387 2007-05-11 Marek Safar <marek.safar@gmail.com>
7389 * typemanager.cs (IsFriendAssembly): Should not be called for building
7392 2007-05-09 Marek Safar <marek.safar@gmail.com>
7394 * literal.cs (NullConstant): Print null in all cases.
7396 * expression.cs (Binary.ResolveOperator): Implemented delegate
7397 comparison based on C# 2.0 changes.
7399 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7401 This code is contributed under the MIT X11 license
7403 The following enables support for several C# 3.0 language features:
7405 * cs-tokenizer.cs: Added support for the "var" keyword.
7407 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7408 Added VarExpr class to facilitate type inferencing.
7410 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7411 to support anonymous types.
7413 * assign.cs: Added support for type inferencing and initialization.
7415 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7417 * expression.cs: Added implicit array support to ArrayCreation.
7418 Added 5 types and 1 interface:
7420 IInitializable Implementing classes can inject initializing
7421 statements after object instantiation.
7423 Initializer Stores data for object initialization.
7425 AnonymousType An expression for anonymous types.
7427 AnonymousTypeParameter Stores data about an anonymous type's field.
7429 NewInitialize An expression for object initialization.
7431 CollectionInitialize An expression for collection initialization.
7433 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7436 2007-05-06 Marek Safar <marek.safar@gmail.com>
7438 A fix for bug #81500
7439 * cs-tokenizer.cs: Add special handling for coalescing operator.
7441 2007-05-06 Marek Safar <marek.safar@gmail.com>
7443 A fix for bug #81529
7444 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7445 its value from base class until it is redefined.
7447 2007-05-02 Raja R Harinath <rharinath@novell.com>
7449 Fix regression in cs0631-3.cs
7450 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7451 fallback. Make error fallback catch more cases.
7453 2007-05-01 Miguel de Icaza <miguel@novell.com>
7455 * cs-parser.jay: Allow parameters in operator declarations to have
7458 2007-04-27 Miguel de Icaza <miguel@novell.com>
7460 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7463 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7464 inside the ContextualReturn, it does not have to be an
7465 ExpressionStatement.
7467 2007-04-24 Miguel de Icaza <miguel@novell.com>
7469 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7472 2007-04-23 Miguel de Icaza <miguel@novell.com>
7474 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7475 method in two methods: ResolveNoDefine and Resolve.
7477 ResolveNoDefine will stop just after ResolveTopBlock has been
7480 Resolve will then continue by creating a method and issuing the
7481 call to method.Define ().
7483 (AnonymousMethod): Split and implement the new Resolve and
7484 ResolveNoDefine as well.
7486 * lambda.cs (LambdaExpression): Split the anonymous method
7487 resolution code into a separate routine (CoreCompatibilityTest)
7488 from DoCompatibleTest.
7490 (LambdaExpression.TryBuild): New method, this method tries to
7491 build the LambdaExpression with the given set of types to be used
7492 as the types for the various parameters of the lambda expression.
7494 If the compilation succeed with the given types, the infered type
7495 of the Anonymous method is returned, otherwise null is returned.
7497 2007-04-23 Marek Safar <marek.safar@gmail.com>
7499 A fix for bug #81414
7500 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7502 2007-04-22 Miguel de Icaza <miguel@novell.com>
7504 * cs-tokenizer.cs: Change various identifiers here from the
7505 camelCasing to the recommended Linux-like style for instance
7506 variables from the Coding Guidelines.
7508 2007-04-19 Martin Baulig <martin@ximian.com>
7511 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7512 System.Enum to System.ValueType.
7514 2007-04-13 Martin Baulig <martin@ximian.com>
7516 Rewrote implicit reference conversions. We need to distinguish
7517 between implicit reference conversions (13.1.4) and implicit
7518 boxing conversions (13.1.5).
7520 According to the spec, there's an an implicit conversion
7521 "From a one-dimensional array-type S[] to IList<T> and base
7522 interfaces of this interface, provided there is an implicit
7523 reference conversion from S to T." Note that this does not
7524 include boxing conversions.
7527 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7528 (Convert.ImplicitReferenceConversion): Split into
7529 ImplicitReferenceConversionCore() and
7530 ImplicitBoxingConversionExist().
7531 (Convert.ImplicitReferenceConversionExists): Use the new
7532 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7534 2007-04-12 Martin Baulig <martin@ximian.com>
7536 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7537 `TypeManager.null_type' checks up to the top of the method.
7539 2007-04-11 Marek Safar <marek.safar@gmail.com>
7541 A fix for bug #81350
7542 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7545 2007-04-11 Martin Baulig <martin@ximian.com>
7547 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7548 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7549 to make this work for generic classes; fixes #79561.
7551 2007-04-11 Martin Baulig <martin@ximian.com>
7553 * expression.cs (As): Add support for nullable types; fixes #79371.
7555 2007-04-11 Martin Baulig <martin@ximian.com>
7557 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7558 `type.FullName' is null; fixes #80243.
7560 2007-04-11 Martin Baulig <martin@ximian.com>
7562 * expression.cs (Invocation.IsApplicable): Don't modify the method
7563 if type inference succeeded, but the method was not applicable.
7566 2007-04-10 Marek Safar <marek.safar@gmail.com>
7568 A fix for bug #81324
7569 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7570 internal and external namespaces containers.
7572 2007-04-10 Martin Baulig <martin@ximian.com>
7574 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7575 TypeManager.DropGenericMethodArguments() so we also call
7576 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7578 2007-04-10 Martin Baulig <martin@ximian.com>
7580 * iterators.cs (Iterator.CreateIterator): Don't crash if
7581 `method.ReturnType' is null. This happens if something went wrong
7582 while resolving that typ (we already reported an error in this case).
7584 2007-04-10 Martin Baulig <martin@ximian.com>
7586 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7587 generic interfaces; report the CS0144 directly.
7589 2007-04-10 Martin Baulig <martin@ximian.com>
7591 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7592 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7594 2007-04-10 Martin Baulig <martin@ximian.com>
7596 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7598 2007-04-09 Raja R Harinath <rharinath@novell.com>
7601 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7602 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7605 * statement.cs (For.Resolve): If resolution fails, use
7608 2007-04-08 Marek Safar <marek.safar@gmail.com>
7610 * anonymous.cs (MakeName): Make faster and zero-based.
7611 (VerifyExplicitParameterCompatibility): Back to mode where generic
7612 parameter is ignored.
7613 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7615 * class.cs (EmitType): Method can emit another new method.
7617 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7619 * driver.cs: Updated.
7621 * lambda.cs: Reuse predefined empty parameters.
7623 * parameter.cs: Updated
7625 * support.cs: Implemented InflateTypes.
7627 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7628 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7630 2007-04-03 Martin Baulig <martin@ximian.com>
7634 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7635 version of TypeManager.IsOverride() which also works with generic
7638 2007-04-03 Martin Baulig <martin@ximian.com>
7643 (Convert.ExplicitReferenceConversion): We need to cast when
7644 converting from IList<T> to S[].
7646 2007-04-01 Marek Safar <marek.safar@gmail.com>
7648 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7651 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7653 2007-03-31 Marek Safar <marek.safar@gmail.com>
7655 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7656 argument and return type inferring.
7658 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7659 (ReturnType): Turned to property.
7661 * statement.cs (Return): Implemented return type inferring.
7663 * support.cs (ReflectionParameters): Use local types if possible.
7665 2007-03-30 Raja R Harinath <rharinath@novell.com>
7667 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7668 (FlowBranching.UsageVector): Update to changes.
7670 Prepare to kill 'Reachability'
7671 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7672 argument of constructor.
7674 2007-03-29 Raja R Harinath <rharinath@novell.com>
7676 Prepare to kill 'Reachability'
7677 * flowanalysis.cs (UsageVector.is_unreachable): New.
7678 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7679 'reachability', and verify they're consistent.
7682 * expression.cs (New.EmitStatement): Handle type parameters here too.
7684 2007-03-29 Martin Baulig <martin@ximian.com>
7689 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7690 CompilerGeneratedClass.
7691 (ScopeInfo.EmitScopeInstance): Make this protected.
7692 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7693 `ec.CurrentAnonymousMethod.Scope == Scope'.
7695 * statement.cs (Block.ScopeInfo): Make this a property.
7697 2007-03-27 Raja R Harinath <harinath@gmail.com>
7699 Prepare to kill 'Reachability'
7700 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7701 (FlowBranching.UsageVector.Reachability): Remove property.
7702 (FlowBranching.UsageVector.IsUnreachable): New property.
7703 (FlowBranching.UsageVector.ResetBarrier): New.
7704 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7705 * codegen.cs, statement.cs: Update to changes.
7707 2007-03-27 Martin Baulig <martin@ximian.com>
7712 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7715 2007-03-26 Raja R Harinath <rharinath@novell.com>
7717 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7718 instead of TriState. Remove all mention of TriState.
7720 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7721 replaced by a boolean. Add boolean 'is_unreachable' field, check
7722 and maintain invariants.
7724 2007-03-25 Marek Safar <marek.safar@gmail.com>
7726 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
7728 2007-03-25 Marek Safar <marek.safar@gmail.com>
7730 * expression.cs: Stop using obsolete 2.0 opcodes.
7732 2007-03-25 Marek Safar <marek.safar@gmail.com>
7734 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
7735 one of the latests Martin's fixes.
7737 2007-03-23 Miguel de Icaza <miguel@novell.com>
7739 * expression.cs: On BigEndian systems, swap the bytes, temporary
7740 solution until we get a new bitconverter class.
7742 2007-03-23 Martin Baulig <martin@ximian.com>
7746 * decl.cs (MemberCache.AddMembers): Add generic methods both as
7747 "Method" and "Method`1". Normally, a cache lookup is done on the
7748 "Method" form (ie. without the generic arity), but this one makes
7749 lookups on the full form work as well.
7751 2007-03-22 Raja R Harinath <rharinath@novell.com>
7753 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
7756 2007-03-20 Bill Holmes <billholmes54@gmail.com>
7758 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
7759 ordered_member_list, to TypeBuilder to store members to be defined
7760 in the order they were parsed in.
7761 - ordered_explicit_member_list contains all properties indexers
7762 and methods that are defined as explicit implementation of an
7763 interface or base class.
7764 - ordered_member_list contains all properties indexers and methods
7765 that are not defined as explicit implementation of an interface
7768 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
7769 functionality in these removed classes has been replaced with
7770 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
7771 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
7773 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
7774 to CheckForDuplications inside GetMethod and SetMethod Define Method
7775 to handle method property and indexer name conflicts.
7779 All code is contributed under the MIT/X11 license.
7781 2007-03-20 Martin Baulig <martin@ximian.com>
7783 * class.cs (TypeContainer.Interfaces): Removed; they're now
7784 included in `TypeContainer.Types'.
7786 2007-03-20 Martin Baulig <martin@ximian.com>
7788 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
7790 * class.cs (TypeContainer.CreateType): New public method. This is
7791 now called before DefineType() to create the TypeBuilders.
7792 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
7793 has already been created by CreateType().
7794 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
7795 don't resolve our base classes here; this has been moved into
7796 DefineBaseTypes(). We're now called from CreateType().
7797 (TypeContainer.DefineBaseTypes): New private method; resolve our
7798 base classes here. We're now called from DefineType().
7801 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
7802 our types first to create all the TypeBuilders. After that, call
7803 TypeContainer.DefineType() on all the types which'll resolve their
7804 base classes and setup the resolve order.
7806 2007-03-20 Martin Baulig <martin@ximian.com>
7808 * class.cs (TypeContainer.Enums): Removed; they're now included in
7809 `TypeContainer.Types'.
7811 2007-03-20 Martin Baulig <martin@ximian.com>
7814 (TypeContainer.DefineType): Don't call ResolveMembers() here.
7815 (TypeContainer.DoResolveMembers): Call DefineType() on our
7816 `compiler_generated' classes; moved here from DefineNestedTypes().
7819 (RootContext.ResolveTree): Call ResolveMembers() on all
7820 TypeContainer's in the `type_container_resolve_order'.
7822 2007-03-19 Marek Safar <marek.safar@gmail.com>
7824 * class.cs: Use corlib to handle InternalMethodImplAttribute.
7826 2007-03-17 Marek Safar <marek.safar@gmail.com>
7828 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
7829 implementation flags.
7831 2007-03-17 Marek Safar <marek.safar@gmail.com>
7833 * class.cs: More optimizations for type parameters.
7835 2007-03-15 Marek Safar <marek.safar@gmail.com>
7837 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
7839 * ecore.cs, parameter.cs: More common code for both corlibs.
7841 * typemanager.cs (IsGenericMethod): Simplified.
7843 2007-03-15 Raja R Harinath <rharinath@novell.com>
7845 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7847 * statement.cs, iterators.cs, lambda.cs: Update to changes.
7849 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
7850 unconditionally. Simplify explanation.
7851 (Try.Resolve, Using.Resolve): Likewise.
7853 2007-03-15 Martin Baulig <martin@ximian.com>
7857 * decl.cs (DeclSpace): If we're a partial class, use our
7858 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
7860 2007-03-15 Raja R Harinath <rharinath@novell.com>
7862 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7864 (FlowBranching.UsageVector): Update to changes.
7865 (FlowBranching.MergeSiblings): Likewise.
7866 * statement.cs: Likewise.
7868 2007-03-15 Martin Baulig <martin@ximian.com>
7873 (MemberCache): Added a special .ctor for type parameters.
7876 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
7879 2007-03-09 Martin Baulig <martin@ximian.com>
7881 * enum.cs (Enum): Make this a TypeContainer.
7882 (EnumMember): Derive from `Const'.
7885 (Const.DoResolveValue): New protected virtual method; move most of
7886 the functionality of ResolveValue() here so we can override it in
7888 (Const.CreateConstantReference): Make this virtual.
7890 * class.cs (Kind): Add `Kind.Enum'.
7891 (TypeContainer.Emit): Don't emit the enums here; they're already
7892 in the `RootContext.typecontainer_resolve_order'.
7894 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
7895 here; they're already in the `typecontainer_resolve_order'.
7897 * ecore.cs (EnumConstant.ConvertImplicitly): Add
7898 TypeManager.DropGenericTypeArguments().
7901 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
7902 (TypeManager.IsEnumType): Likewise.
7903 (TypeManager.EnumToUnderlying): Likewise.
7904 (TypeManager.IsEqual): Add support for enums.
7906 2007-03-12 Raja R Harinath <rharinath@novell.com>
7908 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
7909 DefaultParameterValueAttribute to be undefined, say if System.dll
7912 2007-03-11 Marek Safar <marek.safar@gmail.com>
7914 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
7917 2007-03-10 Marek Safar <marek.safar@gmail.com>
7919 * class.cs, parameter.cs: Unified parameters verification.
7921 2007-03-08 Martin Baulig <martin@ximian.com>
7923 * cs-parser.jay (constructor_header): Pass the location to the
7924 newly created TopLevelBlock.
7926 2007-03-07 Martin Baulig <martin@ximian.com>
7928 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
7930 2007-03-06 Miguel de Icaza <miguel@novell.com>
7932 * convert.cs (ExplicitReferenceConversionExists): Sync this method
7933 with the changes from David, fixes the build.
7935 2007-03-05 David Mitchell <dmitchell@logos.com>
7937 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
7938 and its base interfaces to a one-dimensional array type S[],
7939 provided there is an implicit or explicit reference conversion
7942 2007-03-03 Marek Safar <marek.safar@gmail.com>
7944 * cs-tokenizer.cs: Implemented basic linq grammar.
7946 * driver.cs: Set linq lang version on demand.
7948 2007-02-26 Marek Safar <marek.safar@gmail.com>
7950 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
7952 2007-02-25 Marek Safar <marek.safar@gmail.com>
7954 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
7957 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
7959 Check property and event extern attributes.
7961 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
7964 2007-02-24 Marek Safar <marek.safar@gmail.com>
7966 A fix for bug #80407
7967 * ecore.cs: Don't report ambiguity error when methods have same parent.
7969 2007-02-23 Marek Safar <marek.safar@gmail.com>
7971 A fix for bug #80878
7972 * class.cs, cs-parser.jay: Event property can host anonymous methods.
7974 2007-02-22 Marek Safar <marek.safar@gmail.com>
7976 * attribute.cs: Enable ExtensionAttribute presence test.
7978 2007-02-22 Marek Safar <marek.safar@gmail.com>
7980 * class.cs: Warn about missing GetHashCode only when Equals is override.
7982 * decl.cs: Check accessibility of type arguments.
7984 * typemanager.cs: Correctly report nullable array.
7986 2007-02-20 Marek Safar <marek.safar@gmail.com>
7988 * class.cs, report.cs: Capture more details when things go wrong.
7990 2007-02-20 Marek Safar <marek.safar@gmail.com>
7992 A fix for bug #80650
7993 * cs-parser.jay: Anonymous container starts at constructor declaration
7994 and not at block beginning because it has to be usable in constructor
7997 * statement.cs: Use context location and not block one for error reporting.
7999 2007-02-18 Marek Safar <marek.safar@gmail.com>
8001 A fix for bug #78712
8002 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8005 2007-02-18 Marek Safar <marek.safar@gmail.com>
8007 A fix for bug #80493 by Atsushi Enomoto
8008 * cs-parser.jay: Ignore invalid attribute target.
8010 2007-02-18 Marek Safar <marek.safar@gmail.com>
8012 * cs-tokenizer.cs: Ignore '\0' as white space character.
8014 2007-02-17 Miguel de Icaza <miguel@novell.com>
8016 * cs-parser.jay: Add support for lambda expressions to the mcs
8019 * lambda.cs: Only clone when we are probing, not on the final call
8020 (Compatible is the final call).
8022 * statement.cs (CloneContext): Introduce class to provide block
8023 remapping during clone.
8025 All statements Clone themselves now.
8027 (Clone): special handling for blocks, when we clone a block, we
8028 register the block inside this routine, as children of the block
8029 might trigger a lookup.
8031 * expression.cs: Add support for CloneContext in all expressions.
8033 2007-02-17 Marek Safar <marek.safar@gmail.com>
8035 A fix for bug #80493
8036 * statement.cs: Report ambiguous warning when interfaces are not related.
8038 2007-02-15 Marek Safar <marek.safar@gmail.com>
8040 C# 3.0 extension methods.
8042 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8043 cannot be used directly.
8045 * class.cs (Class.Emit): Emit extension attribute if any class method
8046 is extension method.
8047 (Method.Define): Add basic extension method validation conditions.
8048 (Method.Emit): Emit extension attribute for method.
8050 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8051 extension method exists. Currently we follow same approach as Microsoft
8052 does, emit even if a method or a class are private but this can change
8055 * cs-parser.jay: Add handling of `this' keyword in method parameters
8058 * decl.cs (DeclSpace.IsStaticClass): New property.
8059 (MemberCache.FindExtensionMethods): Looks for extension methods with
8060 defined name and extension type.
8062 * doc.cs: Updated after OverloadResolve changes.
8064 * driver.cs: Add new soft reference to System.Core.dll.
8066 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8067 (ExtensionMethodGroupExpr): Represents group of extension methods.
8069 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8070 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8071 to MethodGroupExpr and made non-static for easier customization.
8072 (Invocation.DoResolve): Add extension method lookup when no standard
8074 (MemberAccess.DoResolve): Try extension methods if no member exists.
8076 * modifiers.cs: Add METHOD_EXTENSION modifier.
8078 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8079 as well as candidate extension type.
8080 (ComputeNamespaces): When assembly constains extension methods registers
8082 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8083 extension method lookup.
8084 (Namespace.LookupExtensionMethod): Looks for extension method in this
8086 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8087 find a method which matches name and extensionType.
8089 * parameter.cs (Parameter): Add This modifer.
8090 (HasExtensionMethodModifier): New property.
8091 (Resolve): Add extension parameter check.
8092 (ModFlags): turned to property to exclude this modifier as it is not real
8094 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8096 * support.cs (ParameterData): Add ExtensionMethodType.
8097 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8099 * typemanager.cs: Add type and ctor extension attribute type.
8101 2007-02-15 Miguel de Icaza <miguel@novell.com>
8103 * report.cs (DisableErrors, EnableErrors): used to prevent error
8104 output when we are "trying" to compile various methods with
8107 * ecore.cs (Expression): Add Clone method that calls the virtual
8108 CloneTo method. The current CloneTo method in Expression throws
8109 an exception so we can track down all the places where this must
8110 be implemented (not using abstract, because that would be a lot of
8111 up-front-work before we can start testing the implementation
8114 Important: we only need Clone capabilities for expressions created
8115 by the parser, as the expressions we will be cloning are
8116 expressions in the pre-resolved state. This vastly simplifies
8119 (SimpleName): Add CloneTo that does nothing.
8120 (EmptyCast): Add CloneTo.
8122 * expression.cs (Binary): Implement CloneTo.
8123 (Invocation.IsApplicable): Store the current ec in
8124 EmitContext.TempEc and restore it on return. This is used so we
8125 do not have to sprinkle hundres of methods with an extra
8126 EmitContext, we know that the only user is the lambda expression
8127 ImplicitConversionExists code.
8129 (Argument): Add Cloning capabilities.
8130 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8131 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8132 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8133 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8134 IndexerAccess): Add Clone capability.
8136 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8138 (Argument): Add cloning capability.
8140 * assign.cs (Assign): Implement CloneTo.
8142 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8144 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8145 version by calling Convert with the EmitContext (that we are
8146 currently storing in ec, this is not great, but will do for now,
8147 to avoid passing EmitContext parameters to hundreds of functions
8148 that do not need them now).
8150 (SetExpression): Remove, it is not needed.
8152 (ContextualReturn): Implement CloneTo.
8154 * statement.cs (Statement): Implement cloning infrastructure,
8155 similar to expressions.
8157 (Block): Partial implementation of Clone for statements.
8159 (Return): Implement clone.
8161 * constant.cs (Constant.CloneTo): New method, does nothing.
8163 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8164 solution, until we decide how to exactly do this.
8166 2007-02-14 Marek Safar <marek.safar@gmail.com>
8168 A fix for bug #80493
8169 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8170 a property is override we need to use second accessor.
8172 2007-02-13 Marek Safar <marek.safar@gmail.com>
8174 A fix for bug #80418
8175 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8178 2007-02-13 Marek Safar <marek.safar@gmail.com>
8180 Another fix for bug #80749
8181 * pending.cs: Abstract class has priority over interfaces.
8183 2007-02-13 Marek Safar <marek.safar@gmail.com>
8185 Another fix for bug #80749
8186 * pending.cs: Abstract class has priority over interfaces.
8188 2007-02-13 Marek Safar <marek.safar@gmail.com>
8190 Another fix for bug #80749
8191 * pending.cs: Abstract class has priority over interfaces.
8193 2007-02-13 Marek Safar <marek.safar@gmail.com>
8195 Another fix for bug #80749
8196 * pending.cs: Abstract class has priority over interfaces.
8198 2007-02-13 Marek Safar <marek.safar@gmail.com>
8200 * class.cs Better error message.
8202 * driver.cs: Add shorter versions of -optimize option.
8204 2007-02-13 Martin Baulig <martin@ximian.com>
8206 * class.cs (Constructor.Emit): Check the return value of
8207 ec.ResolveTopBlock() and return on error.
8209 2007-02-13 Raja R Harinath <rharinath@novell.com>
8211 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8212 message to fix error message regression.
8214 2007-02-12 Marek Safar <marek.safar@gmail.com>
8216 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8218 2007-02-12 Marek Safar <marek.safar@gmail.com>
8220 A fix for bug #80749
8221 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8222 its parent container.
8224 * class.cs (DefineFieldInitializers): Each initializer can has different
8227 * const.cs: Updated.
8229 2007-02-11 Miguel de Icaza <miguel@novell.com>
8231 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8232 now all the heavy lifting to check that embedded statements or
8233 expressions have the right form is done in the ContextualReturn.
8235 (ContextualReturn): New class.
8237 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8238 method that can be invoked to report 201, so we do not replicate
8241 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8243 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8244 treating tabs as spaces.
8246 2007-02-09 Marek Safar <marek.safar@gmail.com>
8248 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8249 * assign.cs: Use full implicit conversion for right side check.
8251 2007-02-09 Marek Safar <marek.safar@gmail.com>
8253 * statement.cs (Switch): Switch over boolean type is not standardized.
8255 2007-02-08 Marek Safar <marek.safar@gmail.com>
8257 A fix for bug #80755
8258 * decl.cs (FindBaseEvent): Don't use method cache for events.
8260 2007-02-07 Marek Safar <marek.safar@gmail.com>
8262 * cs-parser.jay: Better syntax error handling.
8264 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8265 instead of underlying type value.
8267 2007-02-06 Marek Safar <marek.safar@gmail.com>
8269 * driver.cs: Check define identifier before is registered.
8271 * namespace.cs: Use existing error message.
8273 * report.cs: New warning.
8275 2007-02-06 Marek Safar <marek.safar@gmail.com>
8277 A fix for bug #80742
8278 * expression.cs: Delegate Invoke method can be called directly.
8280 2007-02-06 Marek Safar <marek.safar@gmail.com>
8282 A fix for bug #80676
8283 * class.cs (IsEntryPoint): The Main method can have params modifier.
8285 2007-02-04 Miguel de Icaza <miguel@novell.com>
8287 * parameter.cs (Parameter, Parameters): Add Clone method.
8289 * anonymous.cs (Compatible): Turn method into virtual method, so
8290 LambdaExpression can implement a different behavior.
8292 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8293 out the basic checking here, so it can be used by
8296 * lambda.cs: Introduce "Compatible" function that will do the
8299 2007-02-02 Marek Safar <marek.safar@gmail.com>
8301 * attribute.cs: Unified one error message.
8303 * class.cs (Class): Use type attributes and not properties to test static
8305 (IsEntryPoint): Don's pass local variable.
8307 * convert.cs: Removed duplicate check.
8309 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8311 * driver.cs: Don't crash when soft reference does not exist.
8313 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8314 (UsingEntry): Removed redundant allocation.
8316 * parameter.cs: Add fast path for type parameters.
8318 * support.cs: Don't allocate attribute when it's not used.
8320 2007-01-30 Miguel de Icaza <miguel@novell.com>
8323 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8324 this into a virtual method, so we can override it in LambdaExpression.
8326 * driver.cs: Improve diagnostics in case of failure.
8328 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8329 write a function that is slightly more complex and that parses:
8331 type identifier [, type identifier]* )
8333 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8336 (canEmpty ? i >= 0 : i > 0)
8338 2007-01-30 Raja R Harinath <rharinath@novell.com>
8340 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8341 exception on possibly valid code.
8343 2007-01-29 Raja R Harinath <rharinath@novell.com>
8345 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8347 (parse_opt_type_arguments): Remove. It's almost the same as
8349 (parse_namespace_or_typename): Use parse_less_than.
8351 2007-01-28 Miguel de Icaza <miguel@novell.com>
8353 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8354 this bug took a few hours to find, because the state saved and
8355 restored by PushPosition and PopPosition was ignoring the state of
8356 parse_generic_less_than.
8358 I can also now remove the handling of OP_LT and OP_GT, this solves
8361 * cs-tokenizer.cs: store the location for the ARROW token, we use
8364 (PushPosition, PopPosition): save/restore also `current_token',
8365 restore `parse_generic_less_than' (was missing).
8367 (parse_opt_type_arguments): use parse_type, not
8368 parse_namespace_or_typename to parse types.
8370 * lambda.cs: Empty new file, will eventually have the lambda
8371 expression implementation.
8373 * lambda.test: used to test the internal tokenizer.
8375 * report.cs (FeatureIsNotISO1): Rename from
8376 FeatureIsNotStandardized, because it was about the language level
8377 (1 vs 2) it was not about standarization.
8379 (FeatureRequiresLINQ): New.
8381 * support.cs (SeekableStreamReader): Only require that the reader
8382 is a TextReader, not a StreamReader, so we can plug StringReader.
8384 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8385 given position in the input stream the following tokens can be
8386 parsed as a type followed by an identifier.
8388 (is_punct): after a '(' if parse_type_and_parameter returns true,
8389 then return a special token OPEN_PARENS_LAMBDA which is used to
8390 avoid reduce/reduce errors in the grammar for the
8391 lambda_expression rules.
8393 (parse_type): implement a type parser inside the
8394 tokenizer, the parser only returns true or false depending on
8395 whether the input at a given position can be parsed as a type.
8397 (peek_token): new method used during type parsing.
8399 2007-01-28 Raja R Harinath <rharinath@novell.com>
8402 * anonymous.cs (ScopeInfo.InflateParameters): New.
8403 (AnonymousContainer.Resolve): Use it to redirect types of
8404 delegate parameters.
8406 2007-01-27 Raja R Harinath <rharinath@novell.com>
8409 * expression.cs (Error_InvalidArguments): Don't use two different
8410 messages for CS1503. Use ExtraInformation and
8411 SymbolRelatedToPreviousError instead.
8414 * decl.cs (DeclSpace.initialize_type_params): Don't access
8415 'type_params' of a partial class directly.
8417 2007-01-26 Miguel de Icaza <miguel@novell.com>
8419 * constant.cs: Removed a handful of out-of-range checks that were
8422 2007-01-25 Marek Safar <marek.safar@gmail.com>
8424 * expression.cs (CheckUselessComparison): Add additional check for char
8427 * namespace.cs: Fixed typo.
8429 2007-01-23 Miguel de Icaza <miguel@novell.com>
8431 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8432 gone, instead we inline the test, preventing the needless casts to
8433 longs, ulongs and doubles for the parameters, avoiding calls to
8434 methods that overchecked stuff, and instead inlined things
8437 2007-01-20 Marek Safar <marek.safar@gmail.com>
8439 * cs-parser.jay: Better parameter error handling.
8441 2007-01-17 Marek Safar <marek.safar@gmail.com>
8443 A fix for bug #80368, #80522
8444 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8445 whether array initializer contains constants only.
8446 (ArrayCreation.Emit): Use better formula to decide when
8447 are array initializers for static initialization.
8448 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8449 have to emit even constants otherwise they are pre-initialized.
8451 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8452 Raja R Harinath <rharinath@novell.com>
8454 Fix emit order of 'get' vs. 'set'.
8455 * support.cs (Accessors): New.
8456 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8457 Note the order in which accessors are declared in the source.
8458 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8459 Refactored from Property.Define and Indexer.Define.
8460 (PropertyBase.DefineAccessors): New helper that calls the above in
8461 appropriate order as noted by the parser.
8462 (Property.Define, Indexer.Define): Update to changes.
8463 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8465 2007-01-17 Raja R Harinath <rharinath@novell.com>
8467 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8468 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8469 there's an implicit conversion from the current type to the target
8470 type before converting the underlying constant.
8472 2007-01-16 Marek Safar <marek.safar@gmail.com>
8474 * const.cs (ResolveValue): Updated after constant conversion was made more
8477 * constant.cs (GetAttributableValue): constant to object conversion is
8478 used for attributes only.
8479 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8480 constant conversions.
8481 (LongConstant.ConvertImplicitly): Ditto.
8483 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8484 (ImplicitConversionStandard): Handle constant conversion as extra step.
8485 It solves the issue when constant conversion was called indirectly like
8486 inside array initializer and constant folding was skipped.
8488 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8491 * statement.cs(ImplicitConversionStandard): Updated after constant
8492 conversion was made more generic.
8494 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8496 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8497 Constraints, solves the problem where the compiler incorrectly
8498 reported that a type parameter was not constrained to a class (Bug
8501 2007-01-14 Marek Habersack <grendello@gmail.com>
8503 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8505 2007-01-14 Marek Safar <marek.safar@gmail.com>
8507 A fix for bug #80368
8508 * assign.cs (FieldInitializer): New class implements field
8509 initializer statement.
8511 * attribute.cs: Update after FieldMember rename.
8513 * class.cs (PropertyBasedMember): New common class for property based
8515 (InterfaceMemberBase): New base class for all members which can be used as
8516 an interface members.
8517 (MethodCore): Moved really common code to InterfaceMemberBase.
8518 (Method.Define): Equal and GetHasCode detection is relevant for methods
8520 (MethodData.Define): Don't assume that public event implements an
8521 interface automatically.
8522 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8524 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8525 (FieldMember): Merged with FieldBase.
8526 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8527 event extern modifier can be used.
8528 (EventField.EventFieldAccessor): Moved event field specific code here.
8529 (Event.AllowedModifiers): Even event can be extern.
8530 (Event.FindOutBaseMethod): New override specific to events.
8531 (Indexer.parameters): Reintroduce parameters because base class holds
8532 only properties common data.
8533 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8534 need do extra parameters check.
8536 * const.cs: Update after FieldMember rename.
8538 * decl.cs (MemberCache.FindBaseEvent): New method.
8540 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8541 to reflect that indexer is now derived from PropertyBased.
8543 * ecore.cs (GetMemberType): Made public.
8544 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8547 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8549 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8550 (RegisterEvent): Removed.
8551 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8552 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8554 2007-01-11 Raja R Harinath <rharinath@novell.com>
8557 * statement.cs (CollectionForeach.TryType): Prefer generic
8558 GetEnumerator over non-generic variant. Fix code to follow comments.
8560 2007-01-09 Raja R Harinath <rharinath@novell.com>
8563 * support.cs (ReflectionParameter): Don't use an invalid index on
8564 the generic parameter data.
8566 2007-01-08 Miguel de Icaza <miguel@novell.com>
8568 * driver.cs: Just add a tiny bit of infrastructure.
8570 2007-01-02 Marek Safar <marek.safar@gmail.com>
8572 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8573 where field type is struct from current assembly.
8575 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8578 2007-01-02 Marek Safar <marek.safar@gmail.com>
8580 A fix for bug #80381
8581 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8584 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8586 (Namespace.LookupType): Always use core types from corlib when speficied.
8588 * report.cs: A new warning.
8590 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8591 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8592 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8594 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8595 (InitCoreTypes): Set expression type of object_type and value_type
8596 immediately after lookup.
8598 2007-01-01 Miguel de Icaza <miguel@novell.com>
8600 * cs-tokenizer.cs: Accept Pc class characters (Connector
8601 Punctuation) as valid identifiers. Fixes #78259
8603 * expression.cs (Invocation.DoResolve): Moved the check for the
8604 use of `this' for doing method calls to the Invocation resolution
8605 step, after overload resolution has taken place instead of doing
8606 the check at the low-level `This.DoResolve' level.
8608 The `This.DoResolve'(appens before overload resolution, so it has
8609 no way of knowing if the method that will be called will be
8610 instace or static, triggering an erroneous report for cs0188 (Bug
8613 We now do the check for instance method invocations after we know
8614 what method will be called.
8616 (This.CheckThisUsage): Move the actual use of this structure
8617 checking into its own method and expose it.
8619 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8622 Exceptions: Null.ConvertImplicitly,
8623 Constant.ImplicitConversionRequired as there are too many call
8624 sites for passing the ec.
8626 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8627 EmitContext, if the value is null, then we do not try to provide
8628 the extra information from the error (If a userdefined conversion
8629 exists, as UserDefinedConversion requires a non null-EmitContext).
8633 2006-12-30 Raja R Harinath <rharinath@novell.com>
8635 * flowanalysis.cs (MyBitVector): Document some invariants.
8636 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8637 introduced below, and add a couple of others,
8639 2006-12-30 Marek Safar <marek.safar@gmail.com>
8641 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8642 GetPropertyFromAccessor and GetEventFromAccessor.
8644 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8645 overrides non-obsolete one.
8646 (Indexer.Define): Error message has been moved to the parser.
8648 * cs-parser.jay: Better syntax errors handling.
8650 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8651 when an invocation has no arguments.
8653 * ecore.cs: Removed not used caching.
8655 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8658 * report.cs: Add a new warning.
8660 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8662 * typemanager.cs (enumeration_type): Removed.
8663 (CSharpSignature): Reuses IsSpecialMethod.
8664 (IsEqual): Hack for MS BCL.
8665 (GetPropertyFromAccessor): New method.
8666 (GetEventFromAccessor): New method.
8667 (IsSpecialMethod): Fixed to handle more cases.
8669 2006-12-30 Marek Safar <marek.safar@gmail.com>
8671 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8672 Made white spaces array static.
8674 * ecore.cs (RemoveGenericArity): Optimized.
8676 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8678 (MyBitVector.initialize_vector): Simplified.
8680 2006-12-22 Miguel de Icaza <miguel@novell.com>
8682 * ecore.cs: Am not entirely happy with this hack, but it seems to
8683 address the issue in 80257 (a small test case for
8686 I set the MethodGroupExpr.Type to an internal compiler type
8687 (itself in this case) to force the resolution to take place. Why
8688 it does not take place with a null is beyond me.
8690 2006-12-20 Marek Safar <marek.safar@gmail.com>
8692 A fix for bug #80288
8693 * expression.cs (ResolveOperator): Consider user defined conversion for
8694 logical and operator too.
8695 (EmitBranchable): Optimization for logical and when full constant folding
8696 could not be applied but one operand is constant.
8698 2006-12-19 Marek Safar <marek.safar@gmail.com>
8700 * class.cs (GetClassBases): Write 5 times every day, will never use
8701 FullName for error reporting.
8703 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8705 2006-12-19 Martin Baulig <martin@ximian.com>
8707 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8708 the symbol file info here.
8710 2006-12-18 Marek Safar <marek.safar@gmail.com>
8712 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8713 of `elseif' is taking then following sections are not taking.
8714 Fixes an issue reported on mono mailing list.
8716 2006-12-18 Marek Safar <marek.safar@gmail.com>
8718 A fix for bug #80300
8719 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8720 a caller is not taking.
8722 2006-12-18 Raja R Harinath <rharinath@novell.com>
8724 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
8725 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
8726 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
8727 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
8728 * class.cs: Update to changes.
8730 2006-12-17 Marek Safar <marek.safar@gmail.com>
8732 A fix for bug #79934
8733 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
8736 * class.cs (ResolveMembers): Register an iterator in current container and
8739 2006-12-16 Raja R Harinath <rharinath@novell.com>
8742 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
8743 satisfy a params annotated parameter.
8745 2006-12-16 Marek Safar <marek.safar@gmail.com>
8747 A fix for bug #77014
8748 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
8749 paramters correctly and not rely on hacks in Parameters class.
8750 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
8752 (Invocation.VerifyArgumentsCompat): Ditto.
8753 (Invocation.EmitArguments): Changed to correctly emit params arguments at
8756 * parameter.cs (HasParams): Don't assume that params is the last one.
8758 * support.cs (ReflectionParameters.ctor): Look for params attribute
8760 (ReflectionParameters.ParameterType): Removed hack when we returned last
8761 parameter for out of range parameters.
8762 (ParameterName, ParameterModifier): Ditto.
8764 2006-12-14 Marek Safar <marek.safar@gmail.com>
8766 A fix for bug #79987
8767 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
8768 when assembly is not CLS compliant but type is. I have no idea why is this
8771 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
8773 2006-12-13 Miguel de Icaza <miguel@novell.com>
8775 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
8776 in struct constructors, they are basically no-ops.
8778 2006-12-12 Marek Safar <marek.safar@gmail.com>
8780 * cs-tokenizer.cs (Position): Save preprocessor status too.
8782 2006-12-12 Marek Safar <marek.safar@gmail.com>
8784 A fix for bug #77794
8785 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
8787 2006-12-12 Marek Safar <marek.safar@gmail.com>
8789 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
8791 (pp_expr): Report error for an invalid expression.
8792 (handle_preprocessing_directive): Simplified; add more error checking.
8794 2006-12-11 Marek Safar <marek.safar@gmail.com>
8796 A fix for bug #74939
8797 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
8798 directives handling.
8800 2006-12-10 Marek Safar <marek.safar@gmail.com>
8802 A fix for bugs #80093, and #75984
8803 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
8804 logic, it seems to me as it worked before "by coincidence".
8805 (xtoken): Simplified to use reworked handle_preprocessing_directive.
8806 (cleanup): Enabled endif check.
8808 2006-12-09 Marek Safar <marek.safar@gmail.com>
8810 A fix for bug #80162
8811 * statement.cs (CollectionForeach.TryType): Generics and non-generics
8812 enumerators are never ambiguous.
8814 2006-12-08 Raja R Harinath <rharinath@novell.com>
8817 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
8819 2006-12-06 Marek Safar <marek.safar@gmail.com>
8821 A fix for bug #80144
8822 * class.cs (EventProperty.Define): Explicit implementation means
8823 that an even is used.
8825 2006-12-06 Marek Safar <marek.safar@gmail.com>
8827 Fixes the operators implementation (part II)
8829 * cfold.cs (DoConstantNumericPromotions): Renamed to
8830 DoBinaryNumericPromotions and simplified.
8831 (BinaryFold): Couple of conversion fixes; simplified.
8833 * constant.cs, ecore.cs, literal.cs
8834 (ToType): Renamed to ConvertImplicitly.
8835 (Reduce): Renamed to ConvertExplicitly.
8837 * class.cs, convert.cs: Updated.
8839 * expression.cs: TryReduce doesn't throw an exception.
8841 2006-12-01 Marek Safar <marek.safar@gmail.com>
8843 A fix for bug #80108
8844 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
8847 2006-11-30 Marek Safar <marek.safar@gmail.com>
8849 Fixes unary operators implementation (part I)
8852 * cfold.cs (Error_CompileTimeOverflow): Made internal
8854 * const.cs (IConstant): Changed to use reference to constant and
8855 not constant itself.
8856 Updated IConstant implementations.
8858 * constant.cs (CreateConstant): New factory method.
8859 Updated IConstant implementation.
8861 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
8863 * ecore.cs: Updated to use CreateConstantReference.
8865 * enum.cs: Reflects IConstant changes.
8867 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
8869 * literal.cs (NullConstant): Change to be independently usable.
8871 2006-11-29 Martin Baulig <martin@ximian.com>
8873 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
8874 we need to emit the scope initializer before calling the base .ctor.
8876 * anonymous.cs: Merged back from the new anonymous methods branch.
8877 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
8879 * expression.cs (ParameterReference.DoResolveBase): Create a
8880 "normal" ScopeInfo when capturing parameters rather than using the
8881 root scope; this makes things work with anonymous methods having
8885 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
8887 2006-11-22 Marek Safar <marek.safar@gmail.com>
8889 A fix for bug #79987
8890 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
8891 check to a base class.
8892 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
8893 only when assembly has missing attribute.
8894 * report.cs: Update.
8896 2006-11-21 Marek Safar <marek.safar@gmail.com>
8898 * cs-tokenizer.cs: Merged with gmcs version.
8900 2006-11-20 Marek Safar <marek.safar@gmail.com>
8903 * cs-parser.jay: Better error message when partial keyword is misplaced.
8905 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
8907 A fix for bug #79810
8908 report.cs: CS1058 only applies to 2.0 profile (gmcs).
8909 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
8910 a RuntimeWrappedException by default.
8912 2006-11-18 Marek Safar <marek.safar@gmail.com>
8914 A fix for bug #79843
8915 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
8917 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
8919 2006-11-18 Marek Safar <marek.safar@gmail.com>
8921 * driver.cs, namespace.cs: Uses faster IndexOf version.
8923 2006-11-17 Marek Safar <marek.safar@gmail.com>
8925 A fix for bug #79941
8926 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
8928 (Operator.Define): Implicit/Explicit operator of same type is duplicate
8929 even if internal name is different.
8930 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
8931 (UserDefinedConversion): Simplified as the operators cannot be internal.
8932 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
8934 (MethodLookup): Replaced EmitContext with parentType.
8935 * expression.cs: Updated.
8937 2006-11-09 Raja R Harinath <rharinath@novell.com>
8939 * driver.cs (BadAssembly): Handle all the ugliness of
8940 DefineDynamicAssembly.
8942 2006-11-08 Raja R Harinath <rharinath@novell.com>
8944 Address parts of #58244 -- most of what's left is in the runtime
8945 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
8946 CS1509 error checks, and handle them for all assembly loads, not
8947 just the first invocation.
8948 (LoadModule): Likewise. Move handling of 'adder_method' ...
8949 * codegen.cs (AssemblyClass.AddModule): ... here.
8951 2006-11-02 Marek Safar <marek.safar@gmail.com>
8953 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
8954 IEnumerable<T> is ambiguous.
8956 2006-10-31 Marek Safar <marek.safar@gmail.com>
8958 A fix for bug #67689
8959 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
8960 GetEnumerator is ambiguous.
8962 * report.cs: Add new warning.
8964 2006-10-29 Marek Safar <marek.safar@gmail.com>
8966 A fix for bug #78602
8967 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8968 to protected member can be nested type.
8970 2006-10-28 Marek Safar <marek.safar@gmail.com>
8972 A fix for bug #78965
8973 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8974 to protected member must derive from current type.
8976 2006-10-27 Marek Safar <marek.safar@gmail.com>
8978 assign.cs: Reuses error method.
8980 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
8981 instead of type for constants.
8982 (Expression.Error_ValueAssignment): Common error method.
8984 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
8987 2006-10-27 Marek Safar <marek.safar@gmail.com>
8989 A fix for bug #79081
8990 * expression.cs (MemberAccess.DoResolve): Check nested type
8993 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
8995 * doc.cs : nested delegates were not handled. Fixed bug #79754.
8997 2006-10-26 Marek Safar <marek.safar@gmail.com>
8999 A fix for bug #76591
9000 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9002 2006-10-26 Marek Safar <marek.safar@gmail.com>
9004 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9005 type forwarder of the same type multiple times.
9007 2006-10-26 Raja R Harinath <rharinath@novell.com>
9010 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9011 instance as an rvalue, even when we later resolve as an lvalue.
9013 2006-10-25 Martin Baulig <martin@ximian.com>
9015 * anonymous.cs: Fix #79673.
9017 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9019 A fix for bug #79666
9020 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9021 ignored when is optimized (= default value) as its value is already set.
9023 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9025 A fix for bug #79724
9026 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9027 TypeContainer for type lookup.
9029 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9031 A fix for bug #79231
9032 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9033 * expression.cs (OverloadResolve): Always convert type name for
9035 (ResolveNamespaceOrType): Don't confuse a nested type with any
9038 2006-10-18 Martin Baulig <martin@ximian.com>
9040 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9042 2006-10-17 Miguel de Icaza <miguel@novell.com>
9044 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9045 an int32, but requesting an int64 from the conversion
9047 2006-10-12 Martin Baulig <martin@ximian.com>
9050 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9052 2006-10-12 Martin Baulig <martin@ximian.com>
9055 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9057 2006-10-11 Miguel de Icaza <miguel@novell.com>
9059 * convert.cs: Remove broken code: I was doing the "Existance"
9060 tests for Implicit conversions.
9062 2006-10-10 Miguel de Icaza <miguel@novell.com>
9064 * convert.cs: Added one missing case in
9065 ImplicitStandardConversionExists uint64 to intptr.
9069 * typemanager.cs (uintptr_type): another core known type.
9071 * ecore.cs (OperatorCast): routine used to do cast operations that
9072 depend on op_Explicit. We could change some of the Decimal
9073 conversions to use this.
9075 This one has a probe mechanism that checks both types for an op_
9076 which it coudl be used to eliminate two classes: CastToDecimal
9077 and CastFromDecimal.
9079 * convert.cs: Implement the conversions documented in #59800
9081 2006-10-10 Martin Baulig <martin@ximian.com>
9083 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9084 before RootScope.ResolveMembers().
9086 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9087 `CurrentType' if appropriate.
9089 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9091 A fix for bug #78568
9092 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9093 when contains binary operators.
9094 * cs-parser.jay: Updated.
9096 2006-10-09 Martin Baulig <martin@ximian.com>
9099 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9100 moved that into Define() and also do the other type parameter
9101 checks there. Fixes #79094. Added gtest-292.cs.
9104 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9105 since that doesn't include type parameters; don't use `Ldelema'
9106 for type parameters. Fixes #78980. Added gtest-293.cs.
9108 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9111 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9112 conversion is allowed.
9114 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9116 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9117 error reporting when no error occurs.
9119 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9121 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9124 2006-10-06 Raja R Harinath <rharinath@novell.com>
9127 * class.cs (DefineTypeBuilder): Check circular dependencies before
9128 setting the parent of the TypeBuilder.
9129 (CheckRecursiveDefinition): Don't use 'BaseType', since
9130 it may not be valid until after DefineTypeBuilder. Use
9131 'base_type' instead.
9133 2006-10-04 Martin Baulig <martin@ximian.com>
9135 Merged the Anonymous Methods patch.
9137 * anonymous.cs, iterators.cs: The new anonymous methods code.
9139 * statement.cs (Variable): New public abstract class.
9140 (LocalInfo.Variable): New public property.
9141 (LocalInfo.ResolveVariable): New public method.
9142 (Block.Flags): Add `IsIterator'.
9143 (Block.AddVariable): Improved the CS0136 check.
9144 (Block.AnonymousChildren): New public property.
9145 (Block.AddAnonymousChild): New public method.
9146 (ToplevelBlock): Update to use the new anonymous method framework.
9147 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9148 `ToplevelBlock'; this is required to correctly implement the
9150 (Fixed, Using): Use `TemporaryVariable' instead of directly
9151 creating the `LocalBuilder'.
9153 * parameter.cs (Parameter.ResolveVariable): New public method.
9154 (Parameters.ResolveVariable): Likewise.
9156 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9158 * class.cs (TypeContainer): Replaced the `iterators' list and
9159 corresponding methods with a list of `CompilerGeneratedClass'es.
9160 (TypeContainer.ResolveMembers): New public method.
9161 (Method): `IIteratorContainer' has been replaced by
9164 * expression.cs (VariableReference): New public abstract base
9165 class for `LocalVariableReference', `ParameterReference' and
9168 * codegen.cs (EmitContext): Removed `capture_context',
9169 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9170 (EmitContext.EmitThis): Removed.
9172 * cs-parser.jay: Replace `iterator_container' with
9175 2006-10-04 Martin Baulig <martin@ximian.com>
9177 * generic.cs (GenericMethod): Don't make this abstract.
9178 (Constraints.Clone): Added dummy implementation.
9180 2006-10-04 Raja R Harinath <harinath@gmail.com>
9183 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9184 'declspaces'. Avoid allocating arrays willy-nilly.
9187 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9188 cases out of the switch.
9190 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9192 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9193 message when non-generic type is used with the type arguments.
9194 * expression.cs: Updated.
9196 2006-09-28 Raja R Harinath <rharinath@novell.com>
9199 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9200 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9201 Change semantics slightly. Don't insist on having only one
9202 temporary EmptyExpression -- just throttle the creation of new ones.
9205 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9206 non-interfaces too. If no methods are found, don't try to create
9209 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9211 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9214 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9215 us produce better error message.
9217 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9219 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9220 of the `|' operator.
9222 * report.cs: A new warning added.
9224 2006-09-27 Martin Baulig <martin@ximian.com>
9226 * generic.cs (GenericMethod): Don't make this abstract.
9228 2006-09-27 Martin Baulig <martin@ximian.com>
9231 (InternalErrorException): Added overloaded ctor taking a params array.
9233 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9235 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9236 Fixed the cases when same error was reported twice.
9238 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9239 now report symbol information.
9241 2006-09-25 Martin Baulig <martin@ximian.com>
9243 * class.cs: Completely unified with the gmcs version.
9245 2006-09-25 Martin Baulig <martin@ximian.com>
9247 * typemanager.cs (TypeManager.IsNullableType): New public function.
9248 (TypeManager.IsNullableTypeOf): Likewise.
9249 (TypeManager.IsNullableValueType): Likewise.
9251 * class.cs (MethodCore): Added the `GenericMethod' argument from
9252 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9254 2006-09-24 Raja R Harinath <harinath@gmail.com>
9256 * convert.cs: Unify with gmcs version.
9258 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9260 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9261 verify them as well.
9263 * report.cs: New warning.
9265 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9267 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9268 for anonymous block with out argument.
9270 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9272 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9273 not used private events only.
9275 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9277 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9279 * const.cs (Const.Define): Check for constant type.
9280 (Const.IsConstantTypeValid): Looks for valid constant types.
9282 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9284 * ecore.cs (EmptyConstantCast): New common class for all constant based
9287 * expression.cs (Is.DoResolve): Handle null constant especially.
9288 (New.DoResolve): Check for new void().
9289 (MemberAccess.DoResolve): Cope with all kind of nulls.
9291 * literal.cs (NullConstant): Uses EmptyConstantCast.
9292 (NullDefault): Based on EmptyConstantCast.
9293 (NullLiteral): Uses EmptyConstantCast.
9295 * statement.cs (Block.ResolveMeta): Check for constant type.
9297 2006-09-22 Martin Baulig <martin@ximian.com>
9299 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9301 2006-09-22 Raja R Harinath <rharinath@novell.com>
9303 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9307 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9308 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9311 2006-09-22 Martin Baulig <martin@ximian.com>
9313 * ecore.cs: Merged with the gmcs version.
9315 * generic.cs (ConstructedType): New dummy class.
9316 (TypeArguments): Don't make this abstract.
9319 (TypeManager.IsGenericTypeDefinition): New method.
9320 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9322 2006-09-22 Raja R Harinath <rharinath@novell.com>
9324 * expression.cs (ComposedCast): Check for arrays of TypedReference
9325 before creating the type, not after.
9327 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9329 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9330 after ToType change.
9332 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9333 when constant must be implicitly convertible.
9335 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9337 * ecore.cs (NullCast): Derives from NullConstant.
9339 * expression.cs (Is.DoResolve): Removed useless variables.
9340 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9341 (New.Constantify): Add enum support.
9342 (MemberAccess.DoResolve): Add warning when accessing null constant or
9345 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9348 * literal.cs (NullConstant): New abstract class with common
9349 functionality for all null specializations.
9350 (NullDefault): Represents default(X) when result can be
9352 (NullLiteral): Updated.
9354 * report.cs: Add new warning.
9356 2006-09-21 Martin Baulig <martin@ximian.com>
9358 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9360 2006-09-21 Martin Baulig <martin@ximian.com>
9362 * generic.cs (GenericConstraints): New dummy class.
9363 (Constraints): Likewise.
9364 (TypeParameter): Likewise.
9365 (TypeParameterName): Likewise.
9366 (GenericMethod): Likewise.
9368 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9370 * decl.cs: Merged with the gmcs version.
9372 2006-09-21 Raja R Harinath <rharinath@novell.com>
9374 * generic.cs (TypeParameter): Implement IMemberContainer.
9375 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9377 * rootcontext.cs: Unify with gmcs version.
9379 * report.cs: Unify with gmcs version.
9380 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9381 from gmcs/generics.cs.
9382 * generics.cs (TypeParameter): New dummy class.
9384 * support.cs: Unify with gmcs version.
9386 2006-09-20 Raja R Harinath <rharinath@novell.com>
9388 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9389 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9391 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9392 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9393 * mcs.exe.sources: Add generic.cs.
9395 * codegen.cs: Unify with gmcs version.
9397 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9398 (EmitContext): Add GenericDeclContainer implementation.
9399 * decl.cs (MemberCore, DeclSpace): Likewise.
9400 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9402 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9403 MCS TypeManager has a corresponding dummy method.
9405 2006-09-19 Martin Baulig <martin@ximian.com>
9407 * expression.cs: Completely merged with the gmcs version.
9409 2006-09-19 Martin Baulig <martin@ximian.com>
9411 * expression.cs (Invocation): Merged with the gmcs version.
9412 (ArrayAccess.GetStoreOpcode): Likewise.
9414 2006-09-19 Martin Baulig <martin@ximian.com>
9417 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9418 (TypeManager.IsGenericMethodDefinition): Likewise.
9420 2006-09-19 Martin Baulig <martin@ximian.com>
9423 (TypeManager.IsEqual): Moved the gmcs implementation here.
9424 (TypeManager.DropGenericTypeArguments): Likewise.
9425 (TypeManager.DropGenericMethodArguments): Likewise.
9426 (TypeManager.GetTypeArguments): Moved here from gmcs.
9427 (TypeManager.HasGenericArguments): Likewise.
9429 2006-09-19 Martin Baulig <martin@ximian.com>
9431 * expression.cs (Binary): Merged with the gmcs version.
9433 2006-09-19 Martin Baulig <martin@ximian.com>
9435 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9437 2006-09-19 Martin Baulig <martin@ximian.com>
9439 * typemanager.cs: Merged with the gmcs version.
9441 2006-09-16 Raja R Harinath <rharinath@novell.com>
9443 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9444 * driver.cs: Likewise.
9446 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9449 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9450 only if parent type is class.
9451 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9454 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9457 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9459 * typemanager.cs(CSharpName): Converts NullType to null.
9461 2006-09-15 Martin Baulig <martin@ximian.com>
9464 (TypeManager.GetMethodName): Added mcs implementation.
9465 (TypeManager.IsEqual): Likewise.
9468 (SimpleName.RemoveGenericArity): Added dummy implementation.
9470 * pending.cs: Merged with the gmcs version.
9472 2006-09-15 Martin Baulig <martin@ximian.com>
9474 * statement.cs: Merge with the gmcs version.
9476 2006-09-15 Martin Baulig <martin@ximian.com>
9478 * statement.cs (Switch): Merge with the gmcs implementation
9479 (without nullables), which is newer.
9481 2006-09-15 Martin Baulig <martin@ximian.com>
9483 * statement.cs (Block.Variables): Make this public.
9484 (ToplevelBlock.Parameters): Make this a property.
9485 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9487 2006-09-15 Martin Baulig <martin@ximian.com>
9489 * namespace.cs: Merge with the gmcs version.
9491 2006-09-15 Martin Baulig <martin@ximian.com>
9493 * decl.cs (MemberName): Minor code cleanups.
9495 2006-09-15 Martin Baulig <martin@ximian.com>
9497 * parameter.cs: Merge with the gmcs version.
9499 2006-09-15 Martin Baulig <martin@ximian.com>
9501 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9502 and an error in mcs.
9504 2006-09-15 Martin Baulig <martin@ximian.com>
9506 * flowanalysis.cs: Merged from GMCS; added the generics code into
9507 a `GMCS_SOURCE' conditional so we can share this file.
9509 2006-09-08 Martin Baulig <martin@ximian.com>
9511 * typemanager.cs (TypeManager.interlocked_type): New public field.
9512 (TypeManager.int_interlocked_compare-exchange): New public field.
9513 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9514 enumerator types here and call InitGenericCoreTypes().
9515 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9516 after calling InitEnumUnderlyingTypes().
9519 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9520 `classes_second_stage'.
9522 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9524 * assign.cs, ecore.cs, expression.cs: Share error message text.
9525 * class.cs (FieldMember.Define): Check for varible of static type.
9526 * driver.cs (LoadAssembly): Uses error output for errors.
9527 * statement.cs: Updated.
9529 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9531 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9534 2006-09-07 Martin Baulig <martin@ximian.com>
9537 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9539 2006-08-29 Miguel de Icaza <miguel@novell.com>
9541 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9543 2006-08-17 Miguel de Icaza <miguel@novell.com>
9545 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9546 #52019 and #79064, the use of the \uXXXX sequence in source code
9547 to represent unicode characters.
9549 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9551 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9553 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9555 2006-08-13 Miguel de Icaza <miguel@novell.com>
9557 * assign.cs: Catch attempts to assign to a method groups in += and
9560 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9563 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9565 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9567 * class.cs (Method.Define): Issue a warning when generic method looks like
9569 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9572 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9574 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9576 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9577 search all base interfaces as a member can be ambiguous.
9578 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9579 Constructor member type filter.
9580 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9581 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9582 reporting for returned memberinfos.
9583 * report.cs: Updated.
9584 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9585 version to work on all runtimes.
9586 (TypeManager.RealMemberLookup): Removed members filtering.
9588 2006-08-08 Raja R Harinath <rharinath@novell.com>
9590 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9591 (PropertyExpr.EmitAssign): Likewise.
9592 * expression.cs (Indirection.EmitAssign): Likewise.
9593 (LocalVariableReference.EmitAssign): Likewise.
9594 (ParameterReference.EmitAssign): Likewise.
9595 (Invocation.EmitArguments): Likewise.
9596 (ArrayAccess.EmitAssign): Likewise.
9597 (IndexerAccess.EmitAssign): Likewise.
9598 (This.EmitAssign): Likewise.
9599 (ConditionalLogicalOperator.Emit): Likewise.
9602 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9603 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9604 leave it in after returning it.
9605 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9607 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9609 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9612 2006-08-03 Raja R Harinath <rharinath@novell.com>
9614 Fix cs0146-3.cs and cs0146-4.cs.
9615 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9616 enclosing types don't depend on the current type.
9618 2006-08-02 Raja R Harinath <rharinath@novell.com>
9621 * class.cs (TypeContainer.DoDefineMembers): Use
9622 FindBaseMemberWithSameName on Parent, since we're interested in
9623 whether we hide inherited members or not.
9624 (FindBaseMemberWithSameName): Make slightly more robust.
9626 Fix the non-generic testcase from #77396
9627 * decl.cs (DeclSpace.DeclContainer): Remove override.
9629 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9630 declspaces for doppelgangers too.
9631 (UsingEntry): Implement IResolveContext.
9632 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9633 'this' as the resolve context.
9634 (LocalAliasEntry): Likewise.
9636 Implement parts of #77403
9637 * roottypes.cs (RootDeclSpace): New. Used to represent the
9638 toplevel declaration space. Each namespace declaration introduces
9639 a "partial" root declaretion space.
9640 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9641 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9642 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9643 from 'current_namespace.SlaveDeclSpace'.
9644 (namespace_declaration): Likewise.
9645 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9646 check. It can't happen now.
9647 * decl.cs (DeclSpace.LookupType): Likewise.
9648 * driver.cs (MainDriver): Sanity check.
9650 2006-08-01 Raja R Harinath <rharinath@novell.com>
9652 * decl.cs (DeclSpace.FindNestedType): Remove.
9653 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9654 LookupTypeContainer to get the container of the nested type.
9655 * class.cs (TypeContainer.FindNestedType): Make non-override.
9657 2006-07-31 Raja R Harinath <rharinath@novell.com>
9659 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9660 * class.cs (TypeContainer.PartialContainer): ... here.
9661 (TypeContainer.AddBasesForPart): New helper.
9662 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9664 * cs-parser.jay (current_class): Convert to DeclSpace.
9665 (struct_declaration, interface_declaration, class_declaration):
9666 Use AddBasesForPart instead of .Bases directly.
9667 * const.cs, iterators.cs: Update to changes.
9669 2006-07-28 Raja R Harinath <rharinath@novell.com>
9671 * class.cs (TypeContainer.AddMemberType): Rename from
9673 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9674 (AddTypeContainer): New. Combine AddClassOrStruct and
9676 (AddPartial): Update. Add 'is_partial' argument.
9677 * roottypes.cs: Update to changes.
9678 * cs-parser.jay (push_current_class): New helper for handling
9679 current_container and current_class.
9680 (struct_declaration, interface_declaration, class_declaration):
9683 2006-07-26 Raja R Harinath <rharinath@novell.com>
9685 * roottypes.cs: Rename from tree.cs.
9687 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9688 * tree.cs (Tree, ITreeDump): Remove types.
9689 * rootcontext.cs (tree, Tree): Remove fields.
9690 (root, ToplevelTypes): New.
9691 * *.cs: Update to rename.
9693 * tree.cs (Tree.RecordDecl): Remove.
9694 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9696 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9698 2006-07-23 Raja R Harinath <harinath@gmail.com>
9700 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9701 DoFlowAnalysis and OmitStructFlowAnalysis here.
9702 (ec.With): Rename from WithUnsafe and generalize.
9703 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9704 (ec.WithFlowAnalyis): New.
9705 * ecore.cs, expression.cs, statement.cs: Update.
9707 2006-07-22 Raja R Harinath <harinath@gmail.com>
9709 * statement.cs (Block.ResolveMeta): Simplify slightly.
9711 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9712 multiple boolean fields. Convert InUnsafe, constant_check_state,
9713 check_state to flags.
9714 (CheckState, ConstantCheckState): Update.
9715 (InUnsafe): New read-only property.
9716 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9718 (WithUnsafe): New helper similar to WithCheckState.
9719 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9720 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9722 2006-07-21 Raja R Harinath <rharinath@novell.com>
9724 Make comparisons use the same IL irrespective of whether they're
9725 in a 'checked' or 'unchecked' context: one of the issues in #78899
9726 * codegen.cs (EmitContext.CheckState): Make read-only property.
9727 (EmitContext.ConstantCheckState): Likewise.
9728 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
9729 helper that implement a save/restore stack for CheckState
9730 values. This is the only way to change check-state.
9731 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
9732 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
9733 (CheckedExpr.EmitBranchable): New forwarding method.
9734 (UnCheckedExpr): Likewise.
9735 * statement.cs (Block.ResolveMeta): Use WithCheckState.
9736 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
9737 (Checked.Resolve, checked.DoEmit): Likewise.
9739 2006-07-20 Miguel de Icaza <miguel@novell.com>
9741 * anonymous.cs: Cache the resolved anonymous delegate, and return
9742 this so that the ResolveTopBlock is only triggered once, not
9745 Currently we trigger ResolvetopBlock twice due to a first pass of
9746 argument check compatibility, and a second pass that does the
9749 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9751 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
9753 * rootcontext.cs (Reset): Add helper_classes.
9755 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9758 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
9761 2006-07-13 Miguel de Icaza <miguel@novell.com>
9763 * statement.cs (Lock): Handle expressions of type
9764 TypeManager.null_type specially. Fixes #78770
9766 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9768 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
9771 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9773 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
9774 for accessors as well.
9775 * ecore.cs (EventExpr): Add AccessorTable.
9777 2006-07-01 Marek Safar <marek.safar@seznam.cz>
9780 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
9781 for CS0122 where appropriate.
9782 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
9784 (Filter): Assembly can be null in the case of top level attributes.
9786 2006-06-25 Marek Safar <marek.safar@seznam.cz>
9790 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
9791 is done at global level.
9793 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9795 A fix for #77002, Implemented TypeForwarder support.
9797 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
9798 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
9799 * typemanager.cs (): Add type_forwarder_attr_type.
9801 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9803 * report.cs: Add CS0469 warning.
9805 2006-06-21 Martin Baulig <martin@ximian.com>
9807 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
9808 the `try'-block, so we also report CS0016 etc. there.
9810 2006-06-21 Martin Baulig <martin@ximian.com>
9813 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
9815 2006-06-21 Martin Baulig <martin@ximian.com>
9817 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
9818 also report CS1686 for parameters.
9820 2006-06-21 Martin Baulig <martin@ximian.com>
9822 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
9823 instead of an error if the value is not implicitly convertible to
9824 the switch types; fixes #77964.
9826 2006-06-21 Raja R Harinath <rharinath@novell.com>
9829 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
9830 FieldBuilder is null.
9833 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
9834 'left' and 'right' before error-checking.
9836 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
9838 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
9840 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
9841 (FieldExpr.DoResolve): likewise.
9842 (PropertyExpr.InstanceResolve): likewise.
9843 (EventExpr.InstanceResolve): likewise.
9845 2006-06-04 Marek Safar <marek.safar@seznam.cz>
9847 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
9848 attribute applicable tests for attribute argument.
9850 2006-06-02 Raja R Harinath <rharinath@novell.com>
9853 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
9854 (Binary.OverloadResolve_PredefinedIntegral): New.
9855 (Binary.OverloadResolve_PredefinedFloating): New.
9856 (Binary.OverloadResolve_PredefinedString): New.
9857 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
9858 Follow the standard more closely, and treat numeric promotions in
9859 terms of overload resolution.
9860 (Binary.CheckShiftArguments): Simplify.
9862 2006-06-01 Raja R Harinath <rharinath@novell.com>
9864 * flowanalysis.cs (MyBitVector): Simplify representation.
9865 (MyBitVector.Clone): Avoid allocating BitArray.
9866 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
9867 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
9868 (*): Update. Change all references to MyBitVector.And and
9869 MyBitVector.Or to &= and |=.
9871 2006-05-29 Raja R Harinath <rharinath@novell.com>
9874 * cs-parser.jay (formal_parameter_list): Extend the pattern below
9875 to param arguments too.
9877 2006-05-26 Miguel de Icaza <miguel@novell.com>
9879 * cs-parser.jay: Catch another parsing form for arglist being
9880 followed by other arguments. Fixes #78313.
9882 2006-05-24 Raja R Harinath <rharinath@novell.com>
9884 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
9885 checking of out parameters to ...
9886 (FlowBranchingToplevel.Merge): ... here.
9887 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
9888 set, propagate the origin upward, and only complain if there was
9890 (FlowBranchingException.AddContinueOrigin): Likewise.
9891 (FlowBranchingException.AddReturnOrigin): Likewise.
9892 (FlowBranchingException.AddGotoOrigin): Likewise.
9894 2006-05-23 Raja R Harinath <rharinath@novell.com>
9896 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
9897 unreachable, skip it.
9898 (FlowBranchingException.Merge): Always propagate jumps, even if
9899 the finally block renders subsequent code unreachable.
9901 2006-05-18 Raja R Harinath <rharinath@novell.com>
9904 * statement.cs (Goto.Resolve): Move responsibility for resolving
9905 'goto' to FlowBranching.AddGotoOrigin.
9906 (Goto.SetResolvedTarget): New. Callback to set the
9907 LabeledStatement that's the target of the goto.
9908 (Goto.DoEmit): Use Leave instead of Br when crossing an
9909 unwind-protect boundary.
9910 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
9911 LookupLabel and adjust to new semantics.
9912 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
9913 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
9914 Goto.SetResolvedTarget to update target.
9915 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
9916 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
9917 AddBreakOrigin & co. Delay propagation until ...
9918 (FlowBranchingException.Merge): ... this.
9920 * statement.cs (Block.Resolve): Always depend on flow-branching to
9921 determine unreachability. Kill workaround that originally emitted
9922 only one statement after an "unreachable" label (see infloop in
9925 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
9926 This is still "wrong", but anything better would probably need a
9927 multi-pass algorithm.
9928 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
9929 usage vector. Force current usage vector to be reachable, to
9930 optimistically signify backward jumps.
9931 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
9933 (FlowBranchingLabeled.Merge): New. If no backward jump was
9934 detected, return the original salted-away usage vector instead,
9935 updated with appropriate changes. Print unreachable warning if
9937 * statement.cs (Block.Resolve): Don't print unreachable warning on
9938 a labeled statement.
9940 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
9942 * driver.cs: Pass filename without path to AssemblyBuilder's
9943 AddResourceFile. Fixes bug #78407.
9945 2006-05-17 Raja R Harinath <rharinath@novell.com>
9947 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
9948 * flowanalysis.cs (FlowBranchingLabeled): ... here.
9949 (FlowBranching.MergeChild): Overwrite
9950 reachability information from Labeled branchings too.
9952 2006-05-16 Raja R Harinath <rharinath@novell.com>
9954 * statement.cs (Goto.Resolve): Merge jump origins here ...
9955 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
9957 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
9958 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
9959 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
9960 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
9962 * statement.cs (Goto.Resolve): ... not here.
9963 (Goto.Emit): Remove CS1632 check.
9965 2006-05-14 Marek Safar <marek.safar@seznam.cz>
9967 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
9970 2006-05-11 Raja R Harinath <rharinath@novell.com>
9972 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
9973 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
9974 (FlowBranchingException.Label): Likewise.
9976 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
9978 (MyBitVector.Or): Use it to avoid losing information (Count).
9979 (FlowBranching.MergeOrigins): Likewise.
9981 * flowanalysis.cs (UsageVector.IsDirty): Remove.
9982 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
9983 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
9984 (UsageVector.ToString): Simplify.
9985 (UsageVector.MergeSiblings): Move here from ...
9986 (FlowBranching.Merge): ... here.
9987 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
9990 2006-05-10 Raja R Harinath <rharinath@novell.com>
9992 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
9993 null bitvector is treated as all-true.
9995 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
9996 (MyBitVector): Rationalize invariants. 'vector != null' implies
9997 that we have our own copy of the bitvector. Otherwise,
9998 'InheritsFrom == null' implies all inherited bits are true.
10000 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10002 * statement.cs (LocalInfo): Add IsConstant.
10003 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10004 local variable for constants.
10006 2006-05-09 Raja R Harinath <rharinath@novell.com>
10008 * flowanalysis.cs (MyBitVector.Empty): New.
10009 (MyBitVector): Don't allow InheritedFrom to be null.
10010 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10011 (UsageVector, FlowBranching): Update to changes.
10013 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10014 recursion. The 'Parent == null' condition isn't sufficient for
10016 (FlowBranching.AddBreakOrigin): Likewise.
10017 (FlowBranching.AddContinueOrigin): Likewise.
10018 (FlowBranching.AddReturnOrigin): Likewise.
10019 (FlowBranching.StealFinallyClauses): Likewise.
10020 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10021 (FlowBranching.CheckOutParameters): Likewise.
10022 (FlowBranchingToplevel): Terminate all the above recursions here.
10023 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10024 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10026 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10028 (FlowBranchingToplevel): New. Empty for now.
10029 (FlowBranching.MergeTopBlock): Update.
10030 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10031 branching for the anonymous delegate.
10032 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10034 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10035 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10036 information at the start of the merge. Reorganize.
10038 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10040 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10042 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10044 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10045 to newly introduced ctor.
10047 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10048 message to one place.
10049 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10052 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10054 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10056 * ecore.cs (Expression.ResolveAsConstant): Updated.
10058 * statement.cs (ResolveMeta): Updated.
10060 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10062 * cs-parser.jay: __arglist cannot be used in initializer.
10064 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10067 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10070 2006-05-05 Raja R Harinath <rharinath@novell.com>
10072 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10073 (LabeledStatement): Add 'name' parameter.
10074 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10075 (Block.AddLabel): Update to changes.
10076 * cs-parser.jay (labeled_statement): Likewise.
10078 * flowanalysis.cs (BranchingType.Labeled): New.
10079 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10080 (FlowBranchingLabeled): New. Does nothing for now, but will
10081 eventually handle 'goto' flows.
10082 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10083 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10084 that's terminated ...
10085 (Block.Resolve): ... here.
10087 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10088 (UsageVector.MergeFinallyOrigins): Likewise.
10089 (FlowBranching.InTryOrCatch): Likewise.
10090 (FlowBranching.AddFinallyVector): Likewise.
10091 (FlowBranchingException): Update to changes.
10094 * statement.cs (Return.Resolve): Move error checking to ...
10095 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10096 (FlowBranchingException): Handle return origins like break and
10098 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10100 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10103 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10106 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10109 * class.cs (MethodData.Define): Do public accessor check only when method
10110 implements an interface.
10112 2006-05-04 Raja R Harinath <rharinath@novell.com>
10114 Remove special handling of 'break'
10115 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10116 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10117 (UsageVector.Break): Remove.
10118 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10120 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10122 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10123 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10125 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10128 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10129 be the interface member.
10131 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10134 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10135 for emitting small (int) values.
10137 2006-05-03 Raja R Harinath <rharinath@novell.com>
10140 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10141 control-flow passes through the 'finally' after merging-in all the
10142 control-flows from 'try' and the 'catch' clauses.
10144 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10145 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10146 always true at the only non-recursive entry point.
10147 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10148 FlowBranchingBreakable.
10149 (FlowBranchingLoop): Remove.
10150 * statement.cs (Return.DoResolve): Update to changes.
10153 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10154 (FlowBranching.CreateBranching): Handle it: create a
10155 FlowBranchingContinuable.
10156 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10157 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10158 except that it handles the 'continue' command.
10159 (FlowBranching.UsageVector.MergeOrigins): Rename from
10161 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10162 except that it overrides AddContinueOrigin.
10163 (FlowBranchingException): Override AddContinueOrigin, similar to
10165 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10166 Create a new branching around the embedded statement.
10167 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10168 control flow after the embedded statement.
10169 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10171 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10172 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10173 FlowBranchingBreakable.
10174 (FlowBranchingSwitch): Remove.
10177 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10178 error reporting to ...
10179 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10180 Rename from 'AddBreakVector'. Add new location argument. Return
10181 a bool indicating whether the 'break' crosses an unwind-protect.
10182 (FlowBranchingException.AddBreakOrigin): Add.
10183 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10184 flowbranching after updating with the effects of the 'finally'
10186 (FlowBranchingBreakable): New common base class for
10187 FlowBranchingLoop and FlowBranchingSwitch.
10189 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10190 embedded statement.
10191 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10193 2006-05-02 Raja R Harinath <rharinath@novell.com>
10195 * statement.cs (Do.Resolve): If the loop is infinite, set the
10197 (While.Resolve, For.Resolve): Set a barrier after the embedded
10198 statement. There's no direct control flow that goes from the end
10199 of the embedded statement to the end of the loop.
10200 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10201 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10202 above ensure that the reachability is correctly computed.
10204 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10205 (UsageVector.MergeBreakOrigins): If the current path is
10206 unreachable, treat it as if all parameters/locals are initialized.
10207 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10208 infinite loops before merging-in break origins.
10210 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10211 (Reachability.Reachable): Split part into ...
10212 (Reachability.Unreachable): ... this. Simplify.
10213 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10215 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10216 (Reachability.SetThrowsSometimes): Likewise.
10217 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10218 TriState.Always, use corresponding property.
10219 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10220 (Block.Resolve): Likewise. Remove some redundant checks.
10222 2006-05-02 Raja R Harinath <harinath@gmail.com>
10224 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10225 (Reachability.Meet): Don't bother checking AlwaysThrows --
10226 barrier is always set.
10227 (FlowBranchingBlock.Merge): Likewise.
10229 2006-05-01 Raja R Harinath <harinath@gmail.com>
10231 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10232 checks for unreachable.
10234 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10237 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10239 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10240 whether field is really assigned.
10242 2006-04-30 Raja R Harinath <harinath@gmail.com>
10244 * flowanalysis.cs (Reachability): Make 4-argument constructor
10246 (Reachability.Meet): Rename from 'And'. Remove static variant.
10247 (Reachability.Always): Rename from the highly misleading
10248 'Reachability.Never'.
10249 (FlowBranching.Merge): Update to changes. Mark an impossible
10250 situation with a 'throw'.
10251 (*): Update to changes.
10253 2006-04-29 Raja R Harinath <harinath@gmail.com>
10255 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10256 Remove 'Undefined'.
10257 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10258 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10259 (*): Update to changes.
10260 * statement.cs: Update to changes.
10262 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10265 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10267 2006-04-28 Raja R Harinath <harinath@gmail.com>
10269 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10272 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10273 argument to two arguments: an usage-vector and a bool. Move call
10274 to FlowBranching.Merge () ...
10275 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10277 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10278 handling of loop and switch reachability to ...
10279 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10281 2006-04-27 Raja R Harinath <harinath@gmail.com>
10283 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10284 handling to FlowBranchingLoop.InLoop.
10285 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10287 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10290 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10291 anonymous method is allowed from AnonymousContainer here.
10293 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10295 2006-04-24 Raja R Harinath <rharinath@novell.com>
10298 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10300 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10303 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10304 (DoubleConstant.Reduce): Ditto.
10306 2006-04-23 Raja R Harinath <rharinath@novell.com>
10308 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10309 Remove 'lvalue_right_side' argument. Move parts to ...
10310 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10311 (LocalVariable.DoResolveLValue): ... these.
10313 2006-04-21 Raja R Harinath <rharinath@novell.com>
10316 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10317 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10318 (LocalVariableReference.DoResolveBase): Use it to implement new
10320 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10321 (Argument.Resolve): Simplify. Move CS1510 check ...
10322 * ecore.cs (Expression.ResolveLValue): ... here.
10323 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10324 (PropertyExpr.DoResolveLValue): Likewise.
10325 (FieldExpr.Report_AssignToReadonly): Likewise.
10326 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10327 LValueMemberAccess or LValueMemberOutAccess on instance depending
10329 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10330 DoResolve as appropriate.
10332 2006-04-20 Raja R Harinath <rharinath@novell.com>
10335 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10336 implicit conversions on 'out' and 'ref' arguments.
10338 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10339 improve clarity. Remove dead code.
10342 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10343 (Catch.Resolve): Resolve VarBlock if it exists.
10345 2006-04-19 Miguel de Icaza <miguel@novell.com>
10347 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10348 twice, this was some residual code, the enumerator was emitted
10349 properly in the two branche of if later.
10351 2006-04-19 Raja R Harinath <rharinath@novell.com>
10353 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10354 cast is never an lvalue.
10355 (Cast.DoResolve, Cast.ResolveRest): Combine.
10356 (Argument.Emit): Simplify slightly. Move 'Expr is
10357 IMemoryLocation' check ...
10358 (Argument.Resolve): ... here.
10359 (Argument.Error_LValueRequired): Remove. Inline into only user.
10361 Simplifications. Fix cs0191-2.cs
10362 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10363 CS1649 and CS1651 to ...
10364 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10365 the actual selection of the error code and message to a lookup
10366 table. Add a dummy return value to simplify callsites.
10367 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10368 readonly fields of other instances of the same type. Move CS0197
10370 * expression.cs (Argument.Resolve): ... here. Simplify code.
10371 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10372 resolution of an out or ref argument. The code simplification
10373 above uses this invariant.
10375 2006-04-18 Raja R Harinath <rharinath@novell.com>
10377 Possibly fix #77752. Fix cs1690-[4-7].cs.
10378 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10379 CheckMarshallByRefAccess. Drop parameter.
10380 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10382 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10383 InstanceExpression.
10384 * report.cs (AllWarnings): Add CS1690.
10385 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10386 for ref access too.
10387 (LocalVariableReference.DoResolveBase): Update.
10389 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10391 * class.cs (MethodOrOperator): Moved common parts from method class.
10392 detect obsolete attributes.
10393 (Method.Define): Simplified as it reuses code from base.
10394 (Constructor.ValidAttributeTargets): Fixed issue found during
10396 (Destructor.ValidAttributeTargets): Fixed issue found during
10398 (Operator): Finished refactoring set off by #78020. Operator class is now
10399 ordinary method class.
10401 * anonymous.cs: Updated.
10403 * decl.cs (DeclSpace): Add IsGeneric
10405 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10407 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10409 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10411 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10412 detect obsolete attributes.
10413 (Method.CreateEmitContext): Moved to MethodOrOperator.
10415 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10418 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10419 customized exception to make crash detection easier.
10420 (MethodOrOperator): Started to work on new base class for methods and
10422 (Method): Derives from MethodOrOperator.
10423 (Constructor.Emit): Emits its own attributes.
10424 (AbstractPropertyEventMethod.Emit): Ditto.
10425 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10427 (Operator.Emit): It's temporary more tricky than should be.
10429 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10431 * report.cs (InternalErrorException): Add ctor with inner exception.
10433 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10436 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10439 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10442 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10445 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10447 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10448 attribute is present and Guid not.
10449 (Interface.ApplyAttributeBuilder): Ditto.
10451 * attribute.cs: Add error message.
10453 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10457 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10458 sources (it's composite) so hold them in extra array as they are used in
10459 Emit phase only. It worked in the previous versions by mistake.
10460 (Attribute.Emit): Emit attribute for more owners when exist.
10462 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10463 it has now different behaviour.
10465 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10467 * constant.cs (Constant.IsDefaultInitializer): New method.
10469 * class.cs: Updated.
10471 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10472 re-initialize default values. It saves KBs almost for every assembly.
10473 Thanks Zoltan for the idea.
10474 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10475 (ArrayCreation.DoResolve): Resolve only once.
10476 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10477 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10479 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10481 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10484 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10486 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10487 in an embedded statement too.
10489 2006-04-01 Raja R Harinath <rharinath@novell.com>
10492 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10494 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10498 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10501 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10503 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10505 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10508 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10509 LocalTemporary change.
10511 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10513 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10514 initializers optimization.
10515 (ClassOrStruct.TypeAttr): Moved from modifiers.
10516 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10517 (FieldBase.ResolveInitializer): Resolves initializer.
10518 (FieldBase.HasDefaultInitializer): New property.
10520 * cs-parser.jay: Removed message.
10522 * expression.cs (CompilerGeneratedThis): New specialization.
10524 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10526 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10528 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10530 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10532 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10533 be now EnumConstants only.
10535 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10537 * attribute.cs, driver.cs: Reset more caches.
10539 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10541 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10543 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10545 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10546 for easier reuse. Updated all overrides.
10547 (IntegralConstant): New base class for all integral constants.
10548 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10549 of the constant range, report custom error.
10550 (UIntConstant.Reduce): Fixed uint conversion.
10552 * ecore.cs, literal.cs: Reduce updates.
10554 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10558 * class.cs (Constructor.Define): Removed extra if for default ctors.
10559 A patch from Atsushi Enomoto.
10561 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10563 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10564 GetAttributableValue.
10566 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10569 * convert.cs (ImplicitConversionRequired): Error message moved to
10572 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10573 automatic implicit conversion of an output value.
10574 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10576 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10578 (TypeOf.GetAttributableValue): Add extra handling for object type.
10580 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10581 special error message.
10583 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10585 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10587 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10588 compatible with MS runtime.
10590 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10592 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10593 attribute arguments here.
10595 * class.cs (Indexer.Define): The check was moved to attribute class.
10597 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10599 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10600 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10603 2006-03-22 Raja R Harinath <rharinath@novell.com>
10605 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10606 mcs to keep code differences small.
10607 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10608 * typemanager.cs (parameter_default_value_attribute_type): New.
10609 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10612 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10614 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10616 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10618 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10620 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10623 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10625 * doc-bootstrap.cs : fix build.
10627 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10629 * expression.cs (StringConcat.Append): Issue a warning when empty string
10630 is going to append.
10632 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10634 * assign.cs (CompoundAssign.ResolveSource): Removed.
10636 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10639 * class.cs (TypeContainer.FindMethods): Removed.
10640 (TypeContainer.CheckMemberUsage): Made static.
10642 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10644 * constant.cs (CheckRange): Removed unused type argument.
10645 (CheckUnsigned): Removed unused type argument.
10647 * cs-parser.jay: Updated after MemberAccess clean up.
10648 Uses Length for empty string test.
10650 * cs-tokenizer.cs: Uses Length for empty string test.
10651 (IsCastToken): Made static.
10652 (is_hex): Made static.
10653 (real_type_suffix): Made static.
10655 * decl.cs (SetupCache): Made static.
10656 (OnGenerateDocComment): Removed unused ds argument.
10658 * delegate.cs (VerifyDelegate): Removed unused argument.
10660 * doc.cs: Uses Length for empty string test.
10662 * driver.cs: Uses Length for empty string test.
10664 * enum.cs (IsValidEnumType): Made static
10666 * expression.cs (EnumLiftUp): Removed unused argument.
10667 (ResolveMethodGroup): Ditto.
10668 (BetterConversion): Ditto.
10669 (GetVarargsTypes): Ditto.
10670 (UpdateIndices): Ditto.
10671 (ValidateInitializers): Ditto.
10672 (MemberAccess.ctor): Ditto.
10673 (GetIndexersForType): Ditto.
10675 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10677 * iterators.cs: Updated after MemberAccess clean up.
10679 * location.cs: Uses Length for empty string test.
10681 * namespace.cs: Uses Length for empty string test.
10683 * report.cs (CheckWarningCode): Made static.
10685 * statement.cs (LabeledStatement): Removed unused argument.
10687 * typemanager.cs (FilterNone): Removed.
10689 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10691 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10694 * class.cs: Updated.
10696 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10698 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10700 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10704 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10705 reporting, it's more tricky than I thought.
10707 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10711 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10713 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10714 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10715 Add more error reporting; Fixed issue with params.
10717 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10719 * cs-parser.jay: AnonymousMethod requires host container.
10721 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10723 2006-03-18 Raja R Harinath <harinath@gmail.com>
10725 * class.cs: Change 'TypeContainer ds' constructor argument to
10726 'DeclSpace parent'. Some classes were missed below due to
10727 different naming convention.
10729 * class.cs (MemberCore.Parent): Delete. This makes the
10730 ParentContainer changes below enforceable by the compiler.
10732 Treat pointers to enclosing declaration space as 'DeclSpace', not
10734 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
10735 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
10737 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
10739 (Block.AddThisVariable): Likewise.
10740 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
10741 (AbstractPropertyEventMethod.Emit): Likewise.
10742 (AbstractPropertyEventMethod.EmitMethod): Likewise.
10743 (GetMethod.Define, SetMethod.Define): Likewise.
10744 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
10745 (DelegateMethod.EmitMethod): Likewise.
10747 Fix regression test-partial-13.cs.
10748 Rationalize use of PartialContainer. Ensure that the partial
10749 class semantics can be tied to type-correctness, i.e., any
10750 violation will cause a compile error.
10751 * class.cs, const.cs: Access all fields that belong to class
10752 TypeContainer via ParentContainer. Arguments of EmitContexts and
10753 Resolve()-like functions still use 'Parent'.
10755 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
10756 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
10757 (PropertyMethod.CheckModifiers): Remove unused argument.
10758 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
10761 2006-03-17 Raja R Harinath <harinath@gmail.com>
10763 Make semantics of PartialContainer simpler.
10764 * decl.cs (DeclSpace.IsPartial): Remove.
10765 * class.cs (TypeContainer.IsPartial): Likewise.
10766 (TypeContainer..ctor): Set PartialContainer to point to self.
10767 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
10768 (TypeContainer.FindNestedType): Likewise.
10769 (MemberCore.ParentContainer): Simplify. Remove deprecation.
10771 2006-03-17 Marek Safar <marek.safar@seznam.cz>
10773 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
10775 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10777 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
10780 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10782 * class.cs (Operator.Define): An error for base conversion was not
10783 reported correctly.
10785 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
10787 * iterator.cs : yield break is allowed in try statement which has
10788 catch clauses. Fixed bug #77767.
10790 2006-03-13 Marek Safar <marek.safar@seznam.cz>
10792 A fix for #77593, #77574.
10794 * class.cs (MethodCore.CheckBase): Another if for operator.
10796 2006-03-09 Marek Safar <marek.safar@seznam.cz>
10798 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
10801 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
10802 (DelegateCreation.ImplicitStandardConversionExists): New method for just
10805 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
10808 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
10809 Updated after another emitcontext usage was clean up. It should help us to
10810 synchronize with gmcs easier.
10812 2006-03-04 Marek Safar <marek.safar@seznam.cz>
10816 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
10817 (Event.Define): ditto
10818 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
10820 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
10821 Removed redundant code and set NewSlot for Invoke method too.
10823 * parameter.cs (Parameters.ctor): Add custom, type ctor.
10824 (Parameters.MergeGenerated): New method. Use this method when you merge
10825 compiler generated argument with user arguments.
10827 2006-03-03 Marek Safar <marek.safar@seznam.cz>
10829 * attribute.cs (ResolveAsTypeTerminal): Removed.
10831 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
10832 specialization for predefined types; 30% speed up.
10833 Finally placed obsolete check to right place.
10834 (Expression.ResolveType): Removed.
10836 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
10837 Updated after ResolveType was removed.
10839 * expression.cs (Cast.ctor): Check void cast.
10840 (Binary.ResolveAsTypeTerminal): Is never type.
10841 (Conditional.ResolveAsTypeTerminal): Is never type.
10843 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
10845 2006-03-01 Raja R Harinath <rharinath@novell.com>
10848 * expression.cs (ParameterReference.DoResolveBase): Change return
10850 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
10854 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
10857 * typemanager.cs (GetFullNameSignature): Don't nullref on
10858 protected accessors.
10860 2006-02-27 Marek Safar <marek.safar@seznam.cz>
10862 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
10863 these two separated members to simplify the code.
10864 (Attribute.Resolve): Refactored to use new fields and methods.
10865 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
10866 implemented obsolete attribute checking.
10867 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
10868 implemented obsolete checking again. It look line never ending quest ;-)
10869 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
10871 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
10873 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
10875 *class.cs (Property.Define): Add RegisterProperty call.
10877 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
10878 argument groups (only 2).
10880 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
10881 encoding expression to arguments.
10882 (Expression.ExprClassToResolveFlags): Just turned to property.
10884 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
10885 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
10886 optimized as well as implemented support for zero-length attributes.
10888 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
10889 Add caching of PropertyInfo's.
10891 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10893 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
10894 error multiple times.
10896 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10898 New partial class implementation.
10899 A fix for #77027, #77029, #77403
10901 * attribute.cs (Attributable): Made attributes protected.
10903 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
10904 the replacements of ClassPart and PartialContainer.
10905 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
10906 (TypeContainer.AddInterface): Ditto.
10907 (TypeContainer.AddPartial): The main method for partial classes. It checks
10908 for errors and merges ModFlags and attributes. At the end class is added to
10909 partial_parts list.
10910 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
10912 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
10913 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
10914 from the rest of partial classes.
10915 (TypeContainer.GetClassBases): Simplified.
10916 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
10918 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
10919 (TypeContainer.HasExplicitLayout): Uses Flags now.
10920 (PartialContainer): Removed.
10921 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
10922 (StaticClass): Was merged with Class.
10923 (Class.GetClassBases): class and static class bases are verified here.
10924 (Class.TypeAttr): Added static attributes when class is static.
10925 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
10926 (MemberBase): In some cases we need to call parent container for partial
10927 class. It should be eliminated but it's not easy now.
10929 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
10931 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
10932 partial classed to accumulate class comments.
10933 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
10935 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
10937 * driver.cs (MainDriver): Tree.GetDecl was removed.
10939 * modifiers.cs (Modifiers): Add partial modifier.
10941 * tree.cs (Tree.decl): Removed.
10942 (RootTypes): Started to use this class more often for root types
10945 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10949 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
10950 external interface does not have an attribute.
10952 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10954 Another prerequisites for new partial classs implementation.
10956 * attribute.cs (Attribute.Equal): Implemented.
10957 (Attribute.Emit): Changed as attributes can be applied more than twice.
10958 (Attributes.Emit): Check for duplicate attributes here.
10960 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
10961 as a parameter, clean-up.
10963 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10967 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
10968 contains obsolete attribute check which can in some cases look for base
10969 type of current class which is not initialized yet.
10970 (TypeContainer.BaseType): Replacement of ptype.
10972 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
10974 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10976 First of prerequisites for new partial classs implemention.
10978 * attribute.cs (Attributable): Extended by ResolveContext;
10979 Attributes finally have correct context for resolving in all cases.
10980 (AttachTo): Attribute owner is assigned here.
10982 * codegen.cs (IResolveContext): Introduce new interface to hold
10983 all information needed in resolving phase.
10984 (EmitContext): Implements IResolveContext; more clean-up needed here.
10986 * decl.cs (MemberCore): Implemented IResolveContext.
10988 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
10989 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
10990 parameter.cs, statement.cs, tree.cs, typemanager.cs:
10991 Refactored to use new IResolveContext instead of EmitContext; cleanup
10993 2006-02-06 Miguel de Icaza <miguel@novell.com>
10995 * codegen.cs (EmitScopeInitFromBlock): check here the
10996 capture_context, there is no need to make two calls to the
10999 * anonymous.cs: Add some debugging messages that might help me
11000 track other instances of this problem in the future (the
11001 regression of test 467).
11003 * cs-parser.jay: track the variable block, as we need to initalize
11004 any captured variables declared in this block for the "catch"
11005 portion of the "Try" statement.
11007 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11008 scope initialization for captured variables.
11010 Also, move the emit for the variables after the block location has
11013 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11015 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11017 2006-02-02 Miguel de Icaza <miguel@novell.com>
11019 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11020 commit yesterday, the initialization for the roots is necessary.
11021 What is not necessary is the scope activation.
11023 2006-02-02 Raja R Harinath <rharinath@novell.com>
11025 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11026 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11028 (Argument.Resolve): Remove CS0206 checks.
11030 2006-02-01 Miguel de Icaza <miguel@novell.com>
11032 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11033 scopes for all the roots, the scopes will now be emitted when the
11034 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11036 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11037 code. This reduces a lot of existing cruft.
11039 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11040 that the ScopeInfo is generated as we enter the scope, not at the
11041 time of use, which is what we used to do before.
11043 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11044 every time a Block is about to be emitted if we have a
11047 2006-02-01 Raja R Harinath <rharinath@novell.com>
11049 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11051 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11053 * typemanager.cs (cons_param_array_attribute): Make private.
11054 (Reset): Set it to null.
11055 (InitCoreHelpers): Don't initialize it.
11056 (ConsParamArrayAttribute): New. Initialize it as needed.
11057 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11059 2006-01-31 Miguel de Icaza <miguel@novell.com>
11061 * expression.cs: There might be errors reported during the
11062 selection of applicable methods. If there are errors, do not
11063 continue execution as it will lead the compiler to crash.
11065 2006-01-30 Miguel de Icaza <miguel@novell.com>
11067 * expression.cs: Member access is not allowed on anonymous
11068 methods. Fixes #77402.
11070 2006-01-30 Raja R Harinath <rharinath@novell.com>
11073 * cs-parser.jay (VariableDeclaration): Don't set
11074 current_array_type to null.
11075 (field_declaration, event_declaration, declaration_statement):
11076 Set it to null here.
11078 2006-01-28 Raja R Harinath <harinath@gmail.com>
11080 * typemanager.cs (GenericParameterPosition): New.
11083 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11085 * doc.cs : To process "include" elements, first we should create
11086 another list than XmlNodeList, because it could result in node
11087 removal, which could result in that the XmlNodeList gives up
11088 yielding next node.
11090 (Also made code identical to gmcs again.)
11092 2006-01-25 Miguel de Icaza <miguel@novell.com>
11094 * ecore.cs: Introduce an error report that we were not catching
11095 before, if not silent, we must report the error. Gonzalo ran into
11098 2006-01-23 Miguel de Icaza <miguel@novell.com>
11100 A fix for bug: #76957
11102 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11103 ComputeMethodHost before creating the method, this is a new
11106 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11107 that this method references (RegisterScope). The actual scope
11108 where the method is hosted is computed with the ComputeMethodHost
11109 before we create the method.
11111 Moved the Deepest routine here.
11113 (AnonymousContainer.ComputeMethodHost): New routine used to
11114 compute the proper ScopeInfo that will host the anonymous method.
11116 (ScopeInfo): Deal with multiple roots. The problem was that we
11117 did not have a unique root where all ScopeInfos could be hanged
11118 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11121 Remove AdjustMethodScope which is now computed at the end. Remove
11122 LinkScope which did a partial link, instead link all ScopeInfos
11123 before code generation from the new "LinkScopes" routine.
11125 Simplify all the Add* routines as they no longer need to maintain
11126 the tree, they just need to record that they are using variables
11129 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11130 routines to produce the forest of ScopeInfo trees.
11132 * class.cs (TypeContainer.AppendMethod): This is just like
11133 AddMethod, but ensures that an interface implementation method
11134 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11135 methods, but at the end.
11137 We use this functionality to ensure that the generated MoveNext
11138 method in the iterator class is resolved/emitted before the
11139 enumerator methods created.
11141 This is required because the MoveNext method computes the right
11142 ScopeInfo for the method. And the other methods will eventually
11143 need to resolve and fetch information computed from the anonymous
11146 2006-01-21 Raja R Harinath <harinath@gmail.com>
11147 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11149 Fix rest of #76995.
11150 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11151 the 'aliases' hash.
11152 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11153 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11155 2006-01-18 Raja R Harinath <rharinath@novell.com>
11157 Fix #76656, cs0231-2.cs.
11158 * cs-parser.jay (formal_parameter_list): Make error case catch
11160 (parenthesized_expression_0): Add CS1026 check.
11161 (invocation_expression): Remove unused { $$ = lexer.Location }.
11163 2006-01-17 Raja R Harinath <rharinath@novell.com>
11166 * cs-parser.jay (statement_expression): Don't list out the
11167 individual statement-expressions. Convert syntax error into
11170 2006-01-16 Raja R Harinath <rharinath@novell.com>
11173 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11174 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11175 CheckIntermediateModification.
11176 (FieldExpr.DoResolve): Add new two-argument version that
11177 allows us to resolve the InstanceExpression as an lvalue.
11178 The one-argument variant is now just a wrapper.
11179 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11180 Resolve the lhs as an lvalue if the it has a value type.
11181 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11182 from Assign.DoResolve.
11183 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11184 resolved as an lvalue.
11185 (PropertyExpr.DoResolve): Update.
11186 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11187 has a value type. Move CS1612 check here from
11188 CheckIntermediateModification.
11189 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11190 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11191 'right_side' of a ResolveLValue on an 'out' argument.
11192 (EmptyExpression.LValueMemberAccess): New. Used as the
11193 'right_side' of a propagated ResolveLValue on a value type.
11194 (LocalVariableReference.DoResolveBase): Recognize
11195 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11197 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11198 EmptyExpression.Null.
11200 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11202 * typemanager.cs : added IsGenericParameter(). In mcs it always
11204 * doc.cs : for generic parameters, use GenericParameterPosition,
11207 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11209 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11211 2006-01-12 Miguel de Icaza <miguel@novell.com>
11213 This fixes the problem where we used ldfld instead of ldflda to
11214 load the "THIS" pointer on captured parameters, when THIS is a
11215 value type. See bug #77205.
11217 * iterators.cs (CapturedThisReference.Emit): Pass false to
11218 EmitThis (we do not need the address).
11220 * codegen.cs (EmitThis): it needs to know whether we need the
11221 address of `this' or not. This is used by value types.
11223 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11224 every other call passes false.
11226 2006-01-12 Raja R Harinath <rharinath@novell.com>
11229 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11231 * expression.cs (Invocation.OverloadResolve): Update.
11232 (Invocation.DoResolve): Avoid double resolution of invocation.
11234 2006-01-11 Raja R Harinath <rharinath@novell.com>
11237 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11238 unary negation of floating point types as 0-expr; negation cannot
11239 overflow in floating point types.
11242 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11243 on operands of 'void' type.
11246 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11247 and ExclusiveOr for boolean constants too.
11249 2006-01-09 Raja R Harinath <rharinath@novell.com>
11252 * expression.cs (Invocation.OverloadResolve): Replace reflected
11253 override methods with their base virtual methods, rather than
11254 skipping over them.
11255 * typemanager.cs (TypeManager.GetOverride): New.
11257 2006-01-05 Jb Evain <jbevain@gmail.com>
11259 * class.cs (Property.Define, Indexer.Define): do not tag the
11260 properties as SpecialName | RTSpecialName.
11262 2006-01-04 Miguel de Icaza <miguel@novell.com>
11264 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11265 doing a low-level comparission of parameter types. It was lacking
11266 a check for __argslist.
11268 2005-12-30 Miguel de Icaza <miguel@novell.com>
11270 * expression.cs (ParameterReference.DoResolveBase): Allow
11271 reference parameters if they are local to this block.
11273 This allows the ref and out parameters of a delegate to be used in
11274 an anonymous method, for example:
11276 delegate void set (out int x);
11278 set s = delegate (out int x){
11282 This is used by functionality introduced late in the C# language.
11284 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11285 method that take ref and out parameters.
11287 Fixes #77119 which was a late change in the spec.
11289 2005-12-23 Miguel de Icaza <miguel@novell.com>
11291 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11292 parent if its the same scope. Fixes #77060.
11294 2005-12-21 Miguel de Icaza <miguel@novell.com>
11296 * driver.cs: Report the case of no source files and no -out:
11299 2005-12-20 Raja R Harinath <rharinath@novell.com>
11302 * expression.cs (ComposedCast.GetSignatureForError): Define.
11304 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11308 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11309 ListDictionary, to contain the ExternAliasEntry entries (in
11310 addition to the NamespaceEntry.aliases hashtable). This field is
11311 shared between the original entry and its doppelganger (bodyless
11313 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11314 extern_aliases field.
11315 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11316 lookup in extern_aliases.
11318 2005-12-16 Raja R Harinath <rharinath@novell.com>
11321 * class.cs (TypeContainer.Mark_HasEquals): New.
11322 (TypeContainer.Mark_HasGetHashCode): New.
11323 (ClassPart): Override them.
11324 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11327 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11328 'parent' argument to the base constructor.
11330 Remove all mention of TypeContainer from decl.cs.
11331 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11332 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11333 (DeclSpace.DeclSpace): Likewise.
11334 (DeclSpace.DefineMembers): Remove unused argument.
11335 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11336 debugging check -- we don't care if the debug code throws an
11337 InvalidCastException instead of an InternalErrorException.
11338 * class.cs (TypeContainer.DefineMembers): Update to changes.
11339 (TypeContainer.DoDefineMembers): Likewise.
11340 (TypeContainer.GetMethods): Likewise.
11341 (PropertyMember.Define): Likewise.
11342 (MemberBase.Parent): New property that forwards to
11343 MemberCore.Parent, but ensures that we get a TypeContainer.
11344 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11345 (RootContext.PopulateTypes): Likewise. Remove special case code
11346 for !RootContext.StdLib: DefineMembers is idempotent.
11348 2005-12-14 Miguel de Icaza <miguel@novell.com>
11350 * convert.cs (ExplicitConversionCore): Check the return value from
11351 ExplicitConversionCore which can return null on failure. Fixes #76914
11353 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11355 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11357 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11359 * doc.cs : The search for referenced namespace was insufficient to
11360 get global one as it used to do. Fixed bug #76965.
11362 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11364 * doc.cs : check name in cref in the last phase that whether it is
11367 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11369 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11372 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11374 * doc.cs : so it turned out that we cannot skip override check for
11375 interface members. Fixed bug #76954.
11377 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11379 * cs-tokenizer.cs : fixed bug #75984:
11380 - #warning and #error should not be handled when the source line
11382 - #line is not checked strictly when the source line is disabled.
11383 - #define and #undef is on the other hand checked strictly at any
11386 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11388 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11391 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11393 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11395 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11396 event initializers.
11397 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11398 (FieldBase.Initializer): Initializer is now optional.
11399 (EventField.Define): Only event field can have initializer.
11401 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11403 * const.cs (Const): Reuse initializer.
11405 * cs-parser.jay: Updated after FieldBase changes.
11406 Added current_array_type to simplify array initializers.
11408 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11410 * expression.cs, iterators.cs: Updated.
11412 * namespace.cs (NamespaceEntry): Made UsingFound private.
11414 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11416 * parameterCollection.cs: Obsolete, removed.
11417 * parser.cs: Obsolete, removed.
11419 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11422 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11424 * enum.cs (Enum.Define): Set obsolete context here.
11426 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11429 - FindDocumentedMember() now expects 1) paramList as null
11430 when "we don't have to check the number of parameters" and
11431 2) Type.EmptyTypes when "there is no arguments".
11432 - Introduced FoundMember struct to hold the exact type which was
11433 used to find the documented member (the above change broke
11434 test-xml-044; it might be better just to use DeclaringType than
11435 what MS does, like this change does, but it depends on usage.)
11437 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11439 * doc.cs : documented member might be from DeclaringType for nested
11440 types. Fixed bug #76782.
11442 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11444 * anonymous.cs: Have the param code handle leaving copies on the
11445 stack etc. Allows anonymous params to take part in the assignment
11446 code (++, +=, etc). Fixes bug #76550
11448 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11449 it down to the anon code.
11451 * iterators.cs: Use dummy var here
11453 * codegen.cs: Handle new vars
11455 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11458 * class.cs (MethodData.Define): Set proper Obsolete context.
11460 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11462 (FieldExpr.DoResolve): Ditto.
11464 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11467 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11468 parent is not obsolete.
11470 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11472 * doc.cs : (FindDocumentedMember) find parameterless members first
11473 and get CS0419 in the early stage. Fixed first case of bug #76727.
11475 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11478 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11479 no error was reported.
11481 *expression.cs (Binary.DoResolve): left can be null.
11483 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11486 * class.cs (MethodData.Emit): Parameters should be labeled first.
11488 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11491 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11493 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11495 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11497 * class.cs (MethodCore): Parameter clean up.
11498 (IMethodData): Added ParameterInfo.
11499 (MethodData): Parameter clean up.
11500 (Indexer.Define): Parameter clean up.
11512 * typemanager.cs: Parameter clean up.
11514 * delegate.cs (Define): Get rid of duplicated code.
11516 * expression.cs (ParameterReference): Removed useless parameters
11518 (Invocation): Ditto.
11520 * parameter.cs (ParamsParameter): New class, params specialization.
11521 (ArglistParameter): Attemp to separate arglist.
11522 (Parameter): Refactored to be reusable and faster.
11523 (Parameter.Modifier): Made understandable.
11524 (Parameters): Changed to be used as a class for `this' assembly
11525 parameters. Refactored to use new specialized classes.
11527 * support.cs (ParameterData): Added Types property.
11528 (InternalParameters): Deleted.
11530 2005-08-20 Martin Baulig <martin@ximian.com>
11532 Merging this patch from GMCS to fix #75867.
11534 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11535 scope if we don't already have it.
11537 2005-11-17 Martin Baulig <martin@ximian.com>
11540 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11541 inherit the scope from our parent. Fixes #76653.
11543 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11545 * doc.cs : the previous patch does not actually fix the bug.
11546 PropertyInfo override check is now implemented and really fixed it.
11547 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11549 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11551 * doc.cs : apply "override filter" also to properties.
11554 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11556 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11557 no need to check overrides. For classes, omit those results from
11558 interfaces since they must exist in the class. Fixed bug #76726.
11560 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11562 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11563 with different parameters. Fixed the second problem in #76685.
11565 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11567 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11568 get expected 'protected' access in CheckValidFamilyAccess()).
11571 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11573 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11574 Fixed bug #76705. CS1569 was incorrectly commented out.
11576 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11578 * doc.cs : use Invocation.IsOverride() to do real override check.
11579 * expression.cs : made Invocation.IsOverride() internal.
11581 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11583 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11584 TypeBuilder.FindMembers() and filter overriden base members out.
11587 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11589 * doc.cs : ref/out parameters are represented as '@' (instead of
11590 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11592 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11594 * doc.cs : when there was no '.' in cref to methods in doc comment,
11595 then parameters were missing in the output. Fixed bug #76691.
11597 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11599 * driver.cs : don't output docs when there is an error.
11602 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11605 Now it should detect indexers. Fixed primary concern in bug #76685.
11606 Fixed CS0419 message to not show the identical member signature in
11609 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11611 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11612 instead of Type.FindMembers() since it does not handle events.
11615 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11617 * codegen.cs: Fixed typo (speficied -> specified).
11619 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11622 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11624 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11626 * attribute.cs: Changed error message.
11628 * cs-tokenizer.cs: One more check.
11630 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11632 * statement.cs (Block.Resolve): Ignore empty statement.
11634 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11636 * report.cs: Made error/warning methods more strict to avoid
11639 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11640 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11641 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11642 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11644 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11646 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11647 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11649 * class.cs (TypeContainer.IsComImport): New property.
11650 (Constructor.Define): Create proper ctor for ComImport types.
11652 * expression.cs (New.CheckComImport): Fixed.
11654 2005-11-07 Miguel de Icaza <miguel@novell.com>
11656 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11657 that a parameter has been captured does not mean that we do not
11658 have to do the rest of the processing. This fixes the second part
11659 of #76592. If there was another anonymous method capturing
11660 values in the past, the Scope would never be set for the second
11661 method that captured the same parameter.
11663 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11664 properly manipulate the stack. Second part of fix for #76592.
11666 * expression.cs (New): Add support for invoking "new" on
11667 interfaces that have been flagged with the ComImport attribute and
11668 the CoClass. Fixes #76637
11670 * statement.cs (Try.DoEmit): When a variable is captured, do not
11671 try to emit the vi.LocalBuilder variable as it has been captured.
11672 Create a temporary variable and store the results on the
11673 FieldBuilder. Fixes #76642
11675 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11677 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11679 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11681 * expression.cs (Binary.DoResolve): Added && optimalization.
11683 * typemanager.cs (AddUserType): Removed useless argument.
11685 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11687 * statement.cs (Block.variables): Uses ListDictionary.
11689 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11692 * class.cs (PartialContainer.EmitType): Customized to emit
11693 security attributes.
11694 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11695 for partial classes.
11697 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11700 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11701 access has to be fixed.
11703 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11705 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11708 * ecore.cs (NullCast.Reduce): Implemented.
11710 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11713 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11715 (Foreach.Resolve): Catch null properly.
11717 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11719 * cs-tokenizer.cs: Warning text fix.
11721 * driver.cs: AllWarningNumbers exposed on public interface.
11723 * report.cs (): Reviewed warning numbers.
11724 (IsValidWarning): Use binary search.
11726 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11728 * driver.cs: Implemeted resource visibility.
11729 (Resources): New class for code sharing between /res: and
11732 2005-10-28 Marek Safar <marek.safar@seznam.cz>
11735 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
11738 * convert (Convert.ImplicitReferenceConversion): NullCast holds
11741 * ecore.cs (NullCast): Child is contant only.
11743 * literal.cs (NullLiteral.Reduce): null can be converted to any
11746 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
11748 * driver.cs: Use Encoding.Default as default code page instead
11751 2005-10-27 Raja R Harinath <rharinath@novell.com>
11754 * expression.cs (Invocation.Error_InvalidArguments): Handle
11755 __arglist parameters.
11756 (Invocation.VerifyArgumentsCompat): Likewise.
11757 * support.cs (ReflectionParameters.GetSignatureForError): Print
11758 __arglist parameters.
11759 (InternalParamters.GetSignatureForError): Likewise.
11760 * parameter.cs (Parameters.GetSignatureForError): Likewise.
11762 2005-10-26 Marek Safar <marek.safar@seznam.cz>
11764 * attribute.cs (GetPropertyValue): Made public.
11766 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
11768 Add new property WrapNonExceptionThrows to handle 2.0 assembly
11770 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
11773 * driver.cs: Reflect method name change.
11775 * statement.cs (Try.Resolve): Warn when try has both general
11776 exception handlers.
11778 * typemanager.cs: runtime_compatibility_attr_type new predefined
11781 2005-10-26 Raja R Harinath <harinath@gmail.com>
11784 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
11785 treat it as an empty parameter list.
11787 2005-10-26 Raja R Harinath <rharinath@novell.com>
11790 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
11791 ResolveAsTypeStep silent.
11792 * statement.cs (Block.AddConstant): Mark block as used.
11793 (Block.ResolveMeta): Avoid piling on error messages
11794 if a constant initializer resolution fails.
11796 2005-10-25 Raja R Harinath <rharinath@novell.com>
11798 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
11800 (NamespaceEntry.VerifyAllUsing): New.
11801 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
11802 behaviour. Delegates actual resolution of alias to ...
11803 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
11804 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
11806 * driver.cs (Driver.MainDriver): Update.
11808 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
11809 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
11811 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
11813 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
11814 RootNamespace.DefineNamespacesForAll.
11816 2005-10-24 Raja R Harinath <harinath@gmail.com>
11818 * typemanager.cs (assemblies, external_aliases, modules)
11819 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
11820 (ComputeNamespaces, GetRootNamespace): Remove extra staging
11821 overhead. Move resposibility ...
11822 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
11823 * driver.cs, attribute.cs, codegen.cs: Update to changes.
11825 2005-10-23 Raja R Harinath <harinath@gmail.com>
11827 * namespace.cs (RootNamespace.all_namespaces): Renamed from
11828 cached_namespaces. Improve usage.
11829 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
11830 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
11831 Move from GlobalRootNamespace and simplify.
11832 (RootNamespace.Global): Make instance variable.
11833 (RootNamespace.RootNamespace): Add "alias name" parameter.
11834 (GlobalRootNamespace): Simplify drastically.
11835 (Namespace.Lookup): Don't use GetNamespace.
11836 * typemanager.cs (GetRootNamespace): Rename from
11837 ComputeNamespaceForAlias.
11838 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
11840 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11842 * anonymous.cs (AnonymousContainer): Don't crash when container
11845 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11847 * expression.cs (Binary.DoResolve): Warn when comparing same
11850 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11853 * expression.cs (Binary.DoResolve): It looks like there are no
11854 convetsion rules in enum context.
11856 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11858 Add support for extern alias qualifiers.
11859 * typemanager.cs: Move some LookupTypeReflection code
11860 to namespace.cs, to have cleaner code. Added some methods
11861 to help us keep track of the extern aliased references.
11862 * driver.cs: Add suport for extern alias assemblies on command
11863 line and check for their warnings/errors. Also keep track of the
11864 extern aliased assemblies.
11865 * namespace.cs: Move the global functionality of Namespace
11866 to GlobalRootNamespace/RootNamespace. Now the global namespace
11867 is GlobalRootNamespace.Globa. Also the code moved from
11868 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
11869 Finally added LocalAliasEntry (AliasEntry before) and
11870 ExternAliasEntry, to handle alias statements.
11871 * cs-parser.jay: Add support in the grammar for extern alias
11873 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
11874 Update callings to Namespace (now in GlobalRootNamespace).
11876 2005-10-18 Raja R Harinath <rharinath@novell.com>
11879 * class.cs (TypeContainer.DefineType): Move updating of
11880 topological sort earlier in the code.
11881 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
11883 2005-10-18 Marek Safar <marek.safar@seznam.cz>
11886 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
11888 * constant.cs (Constant.TryReduce): Moved from Cast class.
11889 (Reduce): Made little bit more OO and fixed missing conversions.
11891 * ecore.cs (Reduce): Implemented.
11892 (Binary.EnumLiftUp): New method to upgrade values to enum values.
11894 * literal.cs (Reduce): Implemented.
11896 * class.cs: Reverted Miguel's wrong commit.
11898 2005-10-14 Miguel de Icaza <miguel@novell.com>
11900 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
11902 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
11904 * cs-parser.jay, expression.cs : CS0214 was missing error location
11905 for constants. Fixed bug #76404.
11907 2005-10-11 Marek Safar <marek.safar@seznam.cz>
11910 * convert.cs (ExplicitConversionCore): Fixed object->enum
11913 2005-10-10 Raja R Harinath <rharinath@novell.com>
11915 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
11916 InstanceExpression.
11917 (PropertyExpr.EmitCall): Likewise.
11918 * expression.cs (Invocation.EmitArguments): Handle case where
11920 (Invocation.EmitCall): Avoid allocating temporary variable if
11921 there are no arguments.
11923 2005-10-07 Raja R Harinath <rharinath@novell.com>
11926 * convert.cs (ImplicitConversionStandard): Move conversion of
11927 void* to arbitrary pointer types ...
11928 (ExplicitConversionStandard): .. here.
11929 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
11930 error to always print typenames.
11932 2005-10-07 Raja R Harinath <rharinath@novell.com>
11934 * convert.cs (GetConversionOperator): Rename from
11935 GetConversionOperators. Move operator selection code from ...
11936 (UserDefinedConversion): ... here.
11938 2005-10-06 Marek Safar <marek.safar@seznam.cz>
11940 * convert.cs (ExplicitConversionCore): Removed duplicate enum
11943 2005-10-05 Marek Safar <marek.safar@seznam.cz>
11945 * assign.cs (Assign.DoResolve): Error method changed.
11947 * cfold.cs (DoConstantNumericPromotions): Error method changed.
11949 * const.cs (ResolveValue): Reset in_transit immediately.
11951 * constant.cs: Error method changed.
11953 * convert.cs: Removed useless location parameter.
11954 (ExplicitNumericConversion): Don't do double enum check.
11955 (ExplicitConversionCore): Renamed from ExplicitConversion.
11956 (ExplicitUnsafe): Extracted from ExplicitConversion.
11957 (ExplicitConversion): Uses for error reporting.
11959 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
11961 (ResolveBoolean): Uses common error method.
11962 (CastToDecimal): Get rid of ec.
11963 (CastFromDecimal): Optimized.
11964 (ConvCast): Get rid of ec.
11966 * enum.cs (ResolveValue): Reset in_transit immediately.
11967 (Emit): Return after first error.
11969 * expression.cs: Convert changes.
11971 * literal.cs: Error method changed.
11973 * statement.cs: Error method changed.
11975 2005-10-03 Raja R Harinath <rharinath@novell.com>
11977 * support.cs (SeekableStreamReader.Position): Don't error out when
11978 the requested position is just beyond the end of the current
11981 2005-09-28 Raja R Harinath <rharinath@novell.com>
11983 * support.cs (SeekableStreamReader): Simplify drastically. Don't
11984 try to keep in sync with the byte count of the underlying Stream.
11985 However, this limits us to a window size of 2048 characters: i.e.,
11986 the maximum lookahead of our lexer/parser can be 2048 characters.
11988 2005-09-28 Marek Safar <marek.safar@seznam.cz>
11991 * driver.cs: Fix compilation files with full root path.
11993 2005-09-25 Miguel de Icaza <miguel@novell.com>
11995 * report.cs (SymbolRelatedToPreviousError): Format the output so
11996 it does not use an open parenthesis that is never closed.
11998 * driver.cs: Follow coding guidelines
12000 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12003 * const.cs (Const.ResolveValue): Check for assigning non-null
12004 value to reference type.
12006 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12008 * anonymous.cs: Implemented ExprClassName.
12010 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12013 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12016 * class.cs (StaticClass.DefineContainerMembers): Report protected
12019 * codegen.cs: if(ed) PRODUCTION.
12021 * convert.cs (Error_CannotImplicitConversion): Better error
12024 * cs-parser.jay: More error checks.
12026 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12028 * driver.cs (CSCParseOption): Enabled wrong option check.
12030 * ecore.cs (Expression.ExprClassName): Turned to property.
12031 (MemberExpr.CheckIntermediateModification): For checking boxed
12032 value types modification.
12034 * statement.cs (Fixed.Resolve): Expression type must be
12035 convertible to fixed type.
12036 (CollectionForeach.GetEnumeratorFilter,TryType):
12037 Small refactoring for easier error checking.
12039 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12041 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12044 * class.cs (GeneratedBaseInitializer): New class for customization
12045 compiler generated initializers.
12046 (MemberBase.DoDefine): Check Obsolete attribute here.
12047 (FieldMember.DoDefine): Ditto.
12049 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12052 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12053 (MemberCore.GetObsoleteAttribute): Removed argument.
12054 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12055 (MemberCore.CheckObsoleteType): New helper.
12059 * statement.cs: Updates after MemberCore changes.
12061 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12062 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12064 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12065 obsolete attribute for compiler construct.
12066 (As.DoResolve): Cache result.
12068 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12070 2005-09-26 Raja R Harinath <rharinath@novell.com>
12073 * expression.cs (This.VerifyFixed): In a value type T, the type of
12074 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12075 value type R, 'this' is treated as a value parameter.
12077 2005-09-22 Miguel de Icaza <miguel@novell.com>
12079 * statement.cs (Lock): Use the TemporaryVariable class instead of
12080 manually using local variables as those do not work when variables
12083 * ecore.cs: Moved the TemporaryVariable class from being a nested
12084 class inside Foreach to be a public class that can be employed in
12087 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12089 * cs-parser.jay: interface_accessors replaced by
12090 accessor_declarations.
12092 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12095 * statement.cs (GotoCase.Resolve): Convert null constant to
12097 (SwitchLabel.ResolveAndReduce): Ditto.
12098 (SwitchLabel.NullStringCase): Custom null stamp.
12099 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12101 typemanager.cs (CSharpSignature): Don't skip first argument
12104 2005-09-18 Miguel de Icaza <miguel@novell.com>
12106 * driver.cs: Set InEmacs based on the environment variable EMACS.
12108 * location.cs (InEmacs): in this mode, do not report column
12109 location as it confuses Emacs.
12111 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12113 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12114 expression.cs, iterators.cs, literal.cs: Store constants and
12117 * class.cs (MemberBase.ShortName): Pass location.
12119 * cs-parser.jay: Some location fixes.
12121 * ecore.cs (Expression.Location): Made virtual.
12123 2005-09-05 Miguel de Icaza <miguel@novell.com>
12125 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12126 if the underlying types are the same, otherwise we need to produce
12127 code that will do the proper cast.
12129 This was exposed by Marek's constant rewrite which produced
12130 invalid code for the call site:
12132 enum X : long { a }
12133 void Method (X v) {}
12137 This fixes test-49.cs
12139 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12141 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12142 Type/Object should be allowed as well. Fixed bug #75968.
12144 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12146 * expression.cs : (Binary.DoResolve): when one is enum constant and
12147 another is constant 0, then return enum one *as enum type*.
12150 2005-09-02 Raja R Harinath <rharinath@novell.com>
12152 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12156 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12157 flow-branching for LocalVariableReferences in case we were invoked
12158 from a MemberAccess.
12159 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12161 (LocalVariableReference.DoResolveBase): ... this.
12162 (MemberAccess.Resolve): Do the check that was disabled during
12165 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12168 (PartialContainer.Create): check abstract/sealed/static strictly
12169 but abstract/sealed can exist only at one side. Fixed bug #75883.
12171 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12174 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12175 specified, don't default to UnmanagedType.I4.
12177 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12179 * expression.cs : conditional operator should check possibly
12180 incorrect assign expression. Fixed bug #75946.
12182 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12184 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12185 Reverting the change. gmcs is much complex than mcs on this matter.
12187 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12189 * cs-tokenizer.cs : To read another token ahead of the actual
12190 consumption, use new SavedToken and cache token instead of moving
12191 back the stream with SeekableStreamReader (it seemed problematic).
12193 driver.cs : Thus use StreamReader directly.
12194 * support.cs : Thus removed SeekableStreamReader.
12196 2005-08-30 Raja R Harinath <rharinath@novell.com>
12199 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12200 (ScopeInfo.EmitScopeType): Use it to construct field names from
12201 names of captured locals.
12204 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12205 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12206 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12207 (ExplicitConversion): Remove enum cases already handled by
12208 implicit conversion. Move implicit conversion check to the beginning.
12209 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12210 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12211 Don't treat System.Enum as a struct.
12213 2005-08-30 Jb Evain <jbevain@gmail.com>
12215 * attribute.cs: handles as expression in parameters.
12217 2005-08-30 Raja R Harinath <rharinath@novell.com>
12220 * class.cs (TypeContainer.VerifyClsName): Don't use a
12221 PartialContainer when verifying CLS compliance.
12222 (AbstractPropertyEventMethod): Set Parent here, ...
12223 (PropertyMethod): ... not here.
12225 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12227 * attribute.cs : escaped attribute name should not be allowed to be
12228 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12230 2005-08-29 Raja R Harinath <rharinath@novell.com>
12233 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12234 when converting a long constant to unsigned long.
12235 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12236 detect where IsApplicable and VerifyArgumentsCompat disagree.
12238 2005-08-29 Raja R Harinath <rharinath@novell.com>
12239 and Carlos Alberto Cortez <carlos@unixmexico.org>
12242 * class.cs (TypeContainer.CanElideInitializer): New helper.
12243 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12244 can safely emitting the initializer of a field.
12246 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12248 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12249 allowed inside a switch (without loop). Fixed bug #75433.
12251 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12253 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12254 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12256 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12258 * driver.cs : kinda reverting the default encoding changes (not exact
12259 revert since I noticed that "codepage:reset" might not work fine).
12261 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12263 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12264 Location. Now getter and setter store location correctly.
12265 (errors/cs0111-12.cs now reports the expected location.)
12267 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12269 * driver.cs : Use default encoding on the environment.
12270 Removed (now that) extra parameter for SeekableStreamReader.
12271 * support.cs : (SeekableStreamReader) third .ctor() argument for
12272 StreamReader is not required (always true). preamble size could
12273 be acquired in simpler and safe way.
12275 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12277 * cs-parser.jay: report CS0642 at warning level 3
12278 and report CS0642 for an if else statement also
12279 fixes bug #74745. Patch by John Luke (and a bit
12281 Removed extra CS0642 warning check for "while",
12283 * statement.cs: In Block.Resolve(), CS0642 check
12284 is reimplemented to check a sequence of an empty
12285 statement and a block.
12287 Both fix bug #66777.
12289 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12291 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12292 detection until I fix it.
12294 * cs-tokenizer.cs: Changed error message.
12296 * cs-parser.jay: Fixed 2 error locations.
12298 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12299 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12302 * enum.cs (GetSignatureForError): Fixed.
12304 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12308 * typemanager.cs (RegisterProperty): Removed.
12310 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12312 2005-08-24 Raja R Harinath <rharinath@novell.com>
12315 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12316 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12318 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12320 * expression.cs : tiny fix is required for not warning positive ulong.
12323 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12325 * expression.cs : add CS0652 check for constant and integral
12326 expression. Fixed bug #53974.
12328 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12330 * expression.cs : in DoNumericPromotions(), check if there is implicit
12331 conversion overload for string (to check CS0034). Fixed bug #52492.
12333 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12335 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12337 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12339 * ecore.cs : report location when it is *not* Null.
12341 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12347 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12348 correctly. Fixed bug #75721.
12350 2005-08-23 Raja R Harinath <rharinath@novell.com>
12352 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12353 loop that performs 'min (pos, char_count)'.
12356 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12357 converted value in Operator.OnesComplement.
12359 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12361 * anonymous.cs: If the anon method is pulled into a helper class,
12362 it needs to be `internal' not `private'. Fixes runtime behavior on
12365 2005-08-20 Martin Baulig <martin@ximian.com>
12367 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12368 scope if we don't already have it.
12370 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12371 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12374 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12377 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12378 is a partial class.
12380 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12382 The big constants rewrite
12383 Fix #75746, #75685 and more
12384 As a side effect saved 1MB for MWF ;-)
12386 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12387 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12388 enum based for corlib compilation.
12390 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12393 * class.cs (FixedField.Define): Use ResolveAsConstant.
12395 * const.cs (IConstant): Interface constants and enums.
12396 (Const.ResolveValue): New method for constant resolvning.
12397 (ExternalConstant): Constants from imported assemblies.
12399 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12400 conversion; like enums.
12401 (Constant.ToType): Converts this constant to different type.
12402 (Constant.Increment): Adds 1.
12404 * convert.cs (ImplicitConversionRequired): Simplified.
12406 * cs-parser.jay: Create EnumMember directly.
12408 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12410 * doc.cs (GenerateEnumDocComment): Removed.
12412 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12413 (ConvertIntLiteral): Removed.
12414 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12416 * enum.cs (EnumMember): Implement IConstant.
12417 (Enum.IsValidEnumConstant): Removed.
12418 (Enum.GetNextDefaultValue): Removed.
12419 (Enum.FindMembers): Updated.
12420 (Enum.GenerateDocComment): Iterate enum members.
12422 * expression.cs (Cast.TryReduce): Handle enums correctly.
12423 (New.Constantify): Made public.
12424 (MemberAccess.DoResolve): Removed contant specific if(s).
12426 * literal.cs (NullLiteral): Implement new abstract methods.
12428 * statement.cs (GotoCase.Resolve): Use new constant methods.
12429 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12431 * typemanager.cs (LookupEnum): Removed.
12432 (IsEnumType): Fixed to work with corlib.
12433 (RegisterConstant): Removed.
12434 (LookupConstant): Removed.
12435 (GetConstant): Changed to work with IConstant.
12437 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12439 * location.cs : Fixed overflown (>255) column number.
12441 2005-08-03 Raja R Harinath <rharinath@novell.com>
12443 First cut of the qualified-alias-member feature.
12444 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12446 * cs-parser.jay (DOUBLE_COLON): New token.
12447 (namespace_or_type_name): Add rule for recognizing
12448 qualified-alias-members.
12449 (primary_expression): Likewise.
12450 (element_access): Allow QualifiedAliasMember as a possible
12451 type-bearing expression.
12452 (local_variable_type, local_variable_pointer_type): Likewise.
12453 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12454 aliases in the current and enclosing namespace declarations.
12455 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12456 * decl.cs (MemberName.is_double_colon): New.
12457 (MemberName.MemberName): Add new constructor for alias-member.
12458 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12459 * expression.cs (QualifiedAliasMember): New expression type.
12461 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12463 * location.cs : it borked when no argument was specified.
12465 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12467 * location.cs : tiny ToString() format fix.
12469 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12471 * statement.cs : oops, it was missing.
12473 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12475 A set of fixes for precise line/column location.
12478 "token" field now holds a file/line "delta", a line number offset
12479 from the segment, and a column number. See also:
12480 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12481 December/009508.html
12482 Removed static IsNull. Use instance IsNull property instead.
12483 * cs-tokenizer.cs :
12484 For some tokens it stores Location. For Identifier it stores
12485 LocatedToken which is a pair of string name and location.
12486 Column numbers are adjusted only at getChar().
12488 Use Location.ToString() for reporting (it now contains column).
12490 Largely modified to use LocatedToken instead of
12491 string (IDENTIFIER), and to acquire Location from some tokens.
12492 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12493 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12495 Now MemberName holds Location. DeclSpace.ctor() receives Location
12496 as a parameter. Removed extra parameters to all derived classes.
12497 Replaced Location.IsNull() with instance property.
12498 * assign.cs, expression.cs :
12499 Added .ctor() overload that omits Location.
12501 Added "nameEscaped" flag that indicates the identifier was escaped
12502 in the source file. This fixes bug #57047.
12504 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12506 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12507 New method, looking for lo-case imported cls type.
12509 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12512 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12514 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12516 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12517 all_imported_types.
12518 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12520 Optimized to save 3.5 MB for SWF compilation.
12522 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12524 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12525 (PartialContainer.Create): Moved logic AddToContainer.
12526 (PartialContainer.MarkForDuplicationCheck): Shares name.
12528 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12531 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12533 (Namespace.GetSignatureForError): New method.
12535 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12536 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12538 2005-08-01 Raja R Harinath <rharinath@novell.com>
12541 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12542 member lookup rather than qualifier_type, since qualifier_type can
12545 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12547 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12550 2005-07-31 Miguel de Icaza <miguel@novell.com>
12552 * statement.cs: Copy the local exception into the exception
12553 captured local. Fixes 75674
12555 2005-07-31 Raja R Harinath <harinath@gmail.com>
12558 * expression.cs (Invocation.OverloadResolve): Don't report error
12559 CS1501 if error CS1502 has been reported.
12560 (New.DoResolve): Delegate CS1501 reporting to
12561 Invocation.OverloadResolve.
12564 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12565 invariant-meaning-in-block property in an enclosing block if
12568 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12570 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12571 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12572 (Switch.CheckSwitch): Just save 50kb for SWF.
12574 2005-07-27 Martin Baulig <martin@ximian.com>
12576 * anonymous.cs (CaptureContext.AddField): Added
12577 `AnonymousContainer am' argument; compute its toplevel scope if
12578 it's not already computed. Fixes #75649.
12580 2005-07-26 Raja R Harinath <rharinath@novell.com>
12583 * class.cs (Constructor.Emit): Reset block to null if the block
12586 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12588 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12590 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12592 * class.cs (MethodData.Define): Check whether accessor implementing
12593 interface is public.
12595 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12597 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12600 * namespace.cs (LookupType): Moved same type check to...
12602 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12603 with the same name.
12605 2005-07-21 Raja R Harinath <rharinath@novell.com>
12607 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12608 already found a typebuilder.
12609 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12610 MemberNames, not strings.
12612 * const.cs (Error_ExpressionMustBeConst):
12613 Rename from Error_EpressionMustBeConst.
12614 * const.cs, class.cs, statement.cd: Update.
12616 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12620 * const.cs (Const.LookupConstantValue): Report missing contant expression
12622 (Error_EpressionMustBeConstant): Only one error method.
12624 * class.cs, statement.c: Updated.
12626 2005-07-20 Raja R Harinath <rharinath@novell.com>
12628 * statement.cs (Block.Flags): Add back HasVarargs.
12629 (Block.flags): Make protected.
12630 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12632 * typemanager.cs (types, typecontainers, user_types): Remove.
12633 (UserTypes, TypeContainers): Likewise.
12634 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12635 (CleanUp, Reset): Update.
12636 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12637 (GetNestedType): Use Type.GetNestedType.
12638 (CoreLookupType): Take two arguments, the namespace and the
12639 basename of the type. Update to use the Namespace.Lookup
12641 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12642 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12643 string concatenation and substring matches.
12644 * class.cs, enum.cs, delegate.cs: Update to changes.
12646 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12648 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12649 Expression and made virtual.
12651 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12652 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12654 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12656 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12659 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12662 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12665 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12666 AssemblyCultureAttribute is not used on executable.
12669 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12671 2005-07-16 Raja R Harinath <rharinath@novell.com>
12674 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12675 New. Reports CS0252/CS0253.
12676 Mostly taken from preliminary patch by Duncak Mak.
12677 (Binary.DoResolveOperator): Store results of operator lookup.
12678 Use them to detect if we need to warn about unintended reference
12681 2005-07-15 Raja R Harinath <rharinath@novell.com>
12684 * namespace.cs (Namespace.Lookup): Add back location parameter.
12685 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12686 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12688 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12689 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12690 (Namespace.LookupType): ... this.
12691 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12693 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12694 purported to handle pointers.
12695 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12698 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12700 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12703 2005-07-15 Raja R Harinath <rharinath@novell.com>
12705 * namespace.cs (Namespace.Lookup): Drop location parameter.
12706 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12707 (NamespaceEntry.Lookup): ... this.
12708 (NamespaceEntry.Error_AmbiguousTypeReference):
12709 Move here from DeclSpace.
12710 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12712 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12713 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12714 Move to NamespaceEntry.
12715 * delegate.cs, expression.cs: Update to changes.
12717 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12719 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12720 CheckAttributeType and refactored.
12721 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12722 ResolveAsTypeTerminal error handling.
12723 (ResolveAsTypeTerminal): Introduced because of global attributes extra
12725 (GetSignatureForError): Print errors in same way.
12728 * codegen.cs: Reflect attribute GetSignatureForError change.
12731 * expression.cs: Add silent parameter to ResolveAsTypeStep.
12733 * namespace.cs (UsingEntry): Refactored to make fields private.
12736 statement.cs: Error_UnexpectedKind has extra parameter.
12738 2005-07-14 Raja R Harinath <rharinath@novell.com>
12740 * ecore.cs (IAlias): Remove.
12741 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
12742 that implement the interface.
12743 * namespace.cs (Namespace): Likewise.
12744 (Namespace.declspaces): Renamed from 'defined_names'.
12745 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
12746 DeclSpace instead of an IAlias.
12747 * tree.cs (Tree.AddDecl): Update.
12749 2005-07-12 Raja R Harinath <rharinath@novell.com>
12751 * statement.cs (Block.Flags); Remove HasVarargs.
12752 (Block.HasVarargs): Move to ToplevelBlock.
12753 (Block.ThisVariable, Block.AddThisVariable): Likewise.
12754 (Block.Variables): Make protected. Initialize variable hashtable
12756 (Block.AddVariable): Update.
12757 (Block.Resolve): Update to changes.
12758 (ToplevelBlock.HasVarargs): New boolean.
12759 (ToplevelBlock.ThisVariable): Move here from Block.
12760 (ToplevelBlock.AddThisVariable): Likewise.
12761 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
12762 * expression.cs (This.ResolveBase): Update to changes.
12763 (ArglistAccess.DoResolve): Likewise.
12765 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12768 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
12770 * class.cs (TypeContainer.VerifyMembers): Distinguish between
12771 not used and not used & assigned.
12772 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
12774 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12777 * expression.cs (Is.DoResolve): null is never provided type.
12779 2005-07-08 Marek Safar <marek.safar@seznam.cz>
12782 * cs-parser.jay: Less strict event error rule to catch more errors.
12784 2005-07-08 Martin Baulig <martin@ximian.com>
12786 Fix test-iter-10.cs - distinguish whether we `yield' in a property
12787 gettter (allowed) or setter (not allowed).
12789 * class.cs (Accessor): Implement IIteratorContainer.
12790 (Accessor.Yields): New public field.
12791 (PropertyBase.PropertyMethod.Define): Handle iterators on a
12792 per-accessor basis.
12795 (get_accessor_declaration, set_accessor_declaration): Set the
12796 `yields' flag on the accessor, not the property.
12797 (property_declaration): Do the iterators check on a per-accessor
12798 basis and not for the whole property.
12800 2005-07-08 Martin Baulig <martin@ximian.com>
12802 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
12803 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
12805 2005-07-07 Marek Safar <marek.safar@seznam.cz>
12808 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
12809 (ExtractSecurityPermissionSet): Cope with self referencing security
12810 attributes properly.
12812 * driver.cs (SetOutputFile): Made public property OutputFile.
12814 2005-07-07 Raja R Harinath <rharinath@novell.com>
12817 * class.cs (TypeContainer.first_nonstatic_field): Rename from
12818 has_nonstatic_fields. Make into a FieldBase pointer.
12819 (TypeContainer.AddField): Add CS0282 check.
12820 (TypeContainer.EmitType): Update.
12822 2005-07-06 Miguel de Icaza <miguel@novell.com>
12824 * cs-tokenizer.cs (consume_identifier): Do not create strings to
12825 compare if they start with __.
12827 2005-07-06 Raja R Harinath <rharinath@novell.com>
12829 * statement.cs (Switch.SwitchGoverningType): Only look at
12830 UserCasts that don't need implicit standard conversions to one of
12831 the allowed switch types (Fixes test-322.cs).
12832 (LocalInfo.Resolve): Re-enable sanity-test.
12834 2005-07-06 Marek Safar <marek.safar@seznam.cz>
12836 * cs-tokenizer.cs (consume_identifier): Detect double undescores
12838 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
12840 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
12842 2005-07-06 Raja R Harinath <rharinath@novell.com>
12845 * ecore.cs (SimpleName.GetSignatureForError): Add.
12846 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
12847 (MemberAccess.GetSignatureForError): Add.
12849 2005-07-05 Marek Safar <marek.safar@seznam.cz>
12851 The big error and warning messages review.
12881 * typemanager.cs: Updated.
12883 * class.cs: (MethodCore.SetYields): Moved here to share.
12884 (PropertyMethod.Define): Moved iterator setup here.
12886 * iterators.cs: Add orig_method to have full access to parent
12889 2005-07-05 Raja R Harinath <rharinath@novell.com>
12891 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
12892 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
12893 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
12894 variable of struct type.
12895 * expression.cs (Unary.ResolveOperator): Update to change.
12896 (Indirection.VerifyFixed): Likewise.
12897 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
12898 (ParameterReference.VerifyFixed): Value parameters are fixed.
12899 (This.VerifyFixed): Treat 'this' as a value parameter.
12900 * statement.cs (LocalInfo.IsFixed): Remove.
12902 2005-07-01 Martin Baulig <martin@ximian.com>
12904 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
12905 `ec.EmitThis ()' to get the correct scope.
12907 2005-07-01 Martin Baulig <martin@ximian.com>
12909 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
12910 instance is a ParameterReference; fixes #75299.
12912 2005-07-01 Martin Baulig <martin@ximian.com>
12914 Reverted Marek's latest patch (r46725):
12915 - it contains structural changes which are neither mentioned in
12916 the ChangeLog nor explained anywhere; for example the additional
12917 argument of EmitContext's and Iterator's .ctor's and the
12918 TypeContainer.DefineMembers() change.
12919 - structural changes like this should go in in seperate patches
12920 and not be hidden in a huge patch which just seems to affect
12921 warnings and errors.
12922 a big and hard to understand patch.
12923 - it breaks iterators and causes regressions, for instance in
12926 2005-06-30 Raja R Harinath <rharinath@novell.com>
12929 * expression.cs (Indexers.map): Remove.
12930 (Indexers.Append): Filter out inaccessible setters and getters.
12931 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
12934 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
12935 Refactored from ...
12936 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
12937 (FieldExpr.Emit, PropertyExpr.Emit): Update.
12938 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
12939 * expression.cs (Invocation.EmitCall): Add CS0120 check.
12941 2005-06-30 Marek Safar <marek.safar@seznam.cz>
12944 * class.cs (FieldBase.GetInitializerExpression): One more field
12947 2005-06-28 Miguel de Icaza <miguel@novell.com>
12949 * pending.cs: Do not define a proxy if the base method is virtual,
12950 it will be picked up by the runtime (bug 75270).
12952 2005-06-08 Martin Baulig <martin@ximian.com>
12954 The big Iterators rewrite :-)
12956 * iterators.cs: Rewrite this to use the anonymous methods framework.
12958 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
12959 before the TypeContainers; see 2test-21.cs.
12962 (TypeContainer.DefineType): Don't create a new EmitContext if we
12963 already have one (this only happens if we're an Iterator).
12964 (TypeContainer.Define): Also call Define() on all our iterators.
12965 (Method.CreateEmitContext): Added support for iterators.
12968 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
12969 (AnonymousContainer.CreateMethodHost): Moved here from
12970 AnonymousMethod and made abstract.
12971 (AnonymousContainer.CreateScopeType): New abstract method.
12972 (AnonymousContainer.IsIterator): New public property.
12973 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
12974 get the ScopeTypeBuilder rather than manually defining it here.
12975 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
12978 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
12979 before RootContext.DefineTypes().
12981 * codegen.cs (EmitContext.RemapToProxy): Removed.
12982 (EmitContext.CurrentAnonymousMethod): Changed type from
12983 AnonymousMethod -> AnonymousContainer.
12984 (EmitContext.ResolveTopBlock): Protect from being called twice.
12985 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
12986 (EmitContext.EmitThis): Removed the iterators hacks; use the
12987 anonymous methods framework for that.
12990 (ToplevelBlock.Container): Make this a property, not a field.
12991 (ToplevelBlock.ReParent): New public method; move the
12992 ToplevelBlock into a new container.
12993 (Foreach.TemporaryVariable): Simplify.
12995 2005-06-05 Martin Baulig <martin@ximian.com>
12997 * statement.cs (LocalInfo.CompilerGenerated): New flag.
12998 (Block.AddTemporaryVariable): New public method; creates a new
12999 `LocalInfo' for a temporary variable.
13000 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13002 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13003 non-iterator variables.
13005 2005-06-05 Martin Baulig <martin@ximian.com>
13007 * statement.cs (Foreach.TemporaryVariable): Create the
13008 LocalBuilder in the Emit phase and not in Resolve since in some
13009 situations, we don't have an ILGenerator during Resolve; see
13010 2test-19.cs for an example.
13012 2005-06-04 Martin Baulig <martin@ximian.com>
13014 **** Merged r45395 from GCS ****
13016 The big Foreach rewrite - Part II.
13018 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13019 with `PropertyInfo ienumerator_getcurrent'.
13021 * codegen.cs (VariableStorage): Removed.
13024 (Foreach): Derive from Statement, not ExceptionStatement.
13025 (Foreach.CollectionForeach): New nested class. Moved all the code
13026 dealing with collection foreach here.
13027 (Foreach.ForeachHelperMethods): Removed.
13028 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13030 2005-05-23 Martin Baulig <martin@ximian.com>
13032 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13033 don't need to. Fix #75014.
13035 2005-05-20 Martin Baulig <martin@ximian.com>
13037 Merged r44808 from GMCS.
13039 * class.cs (TypeContainer.CircularDepException): Removed.
13040 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13041 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13042 (CS0146) and interface (CS0529) dependencies here.
13044 2005-06-21 Raja R Harinath <rharinath@novell.com>
13046 * expression.cs (Invocation.EmitCall): Fix initialization
13047 'this_call' to reflect current behaviour. Fix indentation.
13049 * convert.cs (FindMostEncompassedType): Add two trivial special
13050 cases (number_of_types == 0 || number_of_types == 1).
13051 (FindMostEncompasingType): Likewise.
13053 2005-06-17 Raja R Harinath <rharinath@novell.com>
13055 Some cleanups preparing for the fix of #75283.
13056 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13058 (EventExpr.InstanceResolve): Likewise.
13059 (EventExpr.DoResolve): Remove redundant checks.
13061 2005-06-10 Duncan Mak <duncan@novell.com>
13063 * cs-tokenizer.cs (process_directives): New flag for controlling
13064 the processing of preprocessor directives.
13065 (x_token): After seeing a '#', return Token.NONE instead of going
13066 to handle_preprocessing_directive() when not processing
13067 directives. This avoids unnecessary processing during the token peek in
13072 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13073 the existing error reporting methods instead of Report.Error.
13075 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13076 after Raja's rewrite.
13078 2005-06-08 Miguel de Icaza <miguel@novell.com>
13080 * class.cs: Small fix.
13082 2005-06-08 Raja R Harinath <rharinath@novell.com>
13085 * class.cs (GetPartialBases): Fix return value check of
13086 part.GetClassBases.
13088 2005-06-07 Raja R Harinath <rharinath@novell.com>
13090 Ensure that partial classes are registered in their enclosing
13091 namespace. Initial part of fix of #75160.
13092 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13093 Register declspace with namespace here, not in
13094 DeclSpace.RecordDecl.
13095 * cs-parser.jay: Pass namespace to RecordDecl.
13096 * class.cs (PartialContainer.Create): Likewise.
13097 (ClassPart.DefineType): New sanity-check. Throws an exception if
13099 * decl.cs (Declspace.RecordDecl): Remove.
13100 * namespace.cs (NamespaceEntry.DefineName): Remove.
13102 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13104 * rootcontext.cs: Reset TargetExt as well.
13106 2005-06-03 Raja R Harinath <rharinath@novell.com>
13108 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13109 -langversion:ISO-1.
13111 2005-06-02 Raja R Harinath <rharinath@novell.com>
13113 Fix #75080, cs0119.cs.
13114 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13116 (Expression.Resolve): ... this. Use it. Remove bogus code
13117 allowing ExprClass.Type and ExprClass.Namespace for
13118 ResolveFlags.VariableOrValue.
13119 (Expression.Resolve) [1-argument variant]: Change default resolve
13120 flags based on language version.
13121 (Expression.Error_UnexpectedKind): Use a simple string array
13122 rather than an ArrayList.
13123 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13124 not ExprClass.Type.
13125 (TypeOfVoid.DoResolve): Likewise.
13126 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13127 flags argument -- it always has the same value.
13129 2005-05-31 Raja R Harinath <rharinath@novell.com>
13132 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13133 Use it in the error message.
13134 * assign.cs, expression.cs, statement.cs: Update.
13136 2005-05-30 Raja R Harinath <rharinath@novell.com>
13139 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13140 the "almostMatchedMember" case too.
13141 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13142 that failed the accessibility checks to 'almost_match'.
13144 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13146 * attribute.cs: Use internal MethodBuilder methods to set
13147 ExactSpelling and SetLastError on PInvoke methods, instead
13148 of passing them via charset. Fixes #75060.
13150 2005-05-27 Raja R Harinath <rharinath@novell.com>
13152 * parameter.cs (Parameter): Remove TODO comment.
13153 (Parameter.DefineParameter): Remove Location parameter.
13154 (Parameters.LabelParameters): Likewise.
13155 * class.cs (Constructor.Emit): Update to change.
13156 (MethodData.Emit): Likewise.
13157 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13158 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13160 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13163 Removed Parameters.Location and added Parameter.Location instead.
13164 Removed Location parameter from Emit() and GetSignature().
13171 Modified all related calls.
13173 2005-05-26 Raja R Harinath <rharinath@novell.com>
13175 Improve user-defined conversion handling.
13176 * convert.cs (GetConversionOperators): Rewrite. Return only the
13177 applicable operators.
13178 (AddConversionOperators): New. Helper for GetConversionOperators.
13179 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13180 there is only one most encompassed/encompassing type.
13181 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13182 "applicable operator" handling.
13183 (UserConversion): Move cache here from GetConversionOperators.
13184 Directly cache the chosen operator, rather than the whole
13186 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13187 case. Allow conversion of decimal to sbyte and byte too.
13188 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13189 New static methods. Used to avoid allocating EmptyExpressions in
13192 2005-05-24 Duncan Mak <duncan@novell.com>
13194 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13195 another class, used in Convert.ExplicitNumericConversion.
13196 (CastToDecimal): New class, similar to above, but casts to
13197 System.Decimal, used in Convert.ImplicitNumericConversion and also
13198 in explicit convesion from double/float to decimal.
13200 * convert.cs (ImplicitNumericConversion): Handle implicit
13201 conversions to System.Decimal.
13202 (ExplicitNumericConversion): handle explicit conversions to
13207 2005-05-20 Miguel de Icaza <miguel@novell.com>
13209 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13210 know the type at this stage, just break through. Fixes #75008
13212 2005-05-19 Martin Baulig <martin@ximian.com>
13215 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13216 to disable error reporting.
13218 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13219 here since we don't want to report an error; see the new test-336.cs.
13221 2005-05-19 Raja R Harinath <rharinath@novell.com>
13223 * statement.cs (ToplevelBlock.GetParameterReference)
13224 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13225 Move here from class Block.
13226 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13227 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13229 2005-05-18 Martin Baulig <martin@ximian.com>
13234 (FlowBranching.Reachability): Add non-static public And() and Or()
13236 (FlowBranchingSwitch): New class; do the `break_origins' thing
13237 like in FlowBranchingLoop.
13238 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13239 reachability, not just locals and parameters.
13240 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13241 switch; MergeBreakOrigins() now takes care of that.
13243 2005-05-18 Martin Baulig <martin@ximian.com>
13245 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13246 a loop and may leave it, reset the barrier; fixes #74974.
13248 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13250 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13253 * cs-parser.jay: Catch more lexical errors.
13255 * report.cs: Add one more Error method.
13258 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13260 2005-05-17 Martin Baulig <martin@ximian.com>
13262 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13265 2005-05-16 Raja R Harinath <rharinath@novell.com>
13267 Fix test-382.cs. Emit values of decimal constants.
13268 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13270 (TypeContainer.AddField): ... this.
13271 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13272 with initializers to include 'Const's.
13273 (ClassPart.RegisterFieldForInitialization): Forward to
13275 * const.cs (Const.Const): Pass initializer to base class.
13276 (Const.Define): In case of decimal constants, register them for
13277 initialization in a static constructor.
13279 2005-05-14 Martin Baulig <martin@ximian.com>
13281 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13282 do not call ResolveUnreachable() on unreachable statements in
13283 here, see the comment in the source code.
13285 2005-05-13 Raja R Harinath <rharinath@novell.com>
13288 * expression.cs (BinaryResolveOperator): If one of the operands of
13289 an equality comparison is 'null' and the other is a pointer type,
13290 convert the null to a NullPointer.
13291 * convert.cs (ImplicitReferenceConversion): If the expression is a
13292 NullLiteral and the target type is a pointer type, return a
13293 NullPointer instead.
13294 (ImplicitConversionStandard): Likewise.
13296 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13298 * cs-parser.jay: Set readonly context based on special constructs.
13300 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13301 readonly variable error handling.
13303 * rootcontext.cs (EmitCode): Don't verify members when error
13306 * statement.cs (LocalInfo): Add reaodnly context information.
13307 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13309 2005-05-13 Raja R Harinath <rharinath@novell.com>
13311 * statement.cs (Block.Resolve): Revert change below. Modify fix
13312 for #74041 to initialize 'resolved' to false only for explicit
13313 blocks. Fixes #74873.
13315 2005-05-12 Raja R Harinath <harinath@gmail.com>
13318 * typemanager.cs (unmanaged_enclosing_types): New.
13319 (IsUnmanagedType): Avoid infloops by using
13320 'unmanaged_enclosing_types' to talk with recursive invocations.
13322 2005-05-13 Martin Baulig <martin@ximian.com>
13324 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13325 instance variable, not a local. Fix #74873.
13326 (Block.ResolveUnreachable): Set it to true here.
13328 2005-05-11 Duncan Mak <duncan@novell.com>
13330 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13331 continuing to process for 'arg'.
13332 (handle_preprocessing_directive): Check the argument of the #endif
13333 directive and report error CS1025 if there are any trailing
13336 According to the C# spec, having even whitespace after the #endif
13337 directive is illegal; however, because we call arg.TrimEnd ()
13338 beforehand, we have the same behavior as csc, allowing whitespace
13339 after the directive.
13343 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13347 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13348 (Constructor.GetObsoleteAttribute): Implemented correctly.
13350 2005-05-10 Martin Baulig <martin@ximian.com>
13352 * support.cs (ReflectionParameters.ParameterModifier): Use
13353 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13354 and `ParameterAttributes.In'. Fixes #74884.
13356 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13358 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13360 * expression.cs (Argument.GetParameterModifier): Turned to property.
13361 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13363 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13366 2005-05-09 Raja R Harinath <rharinath@novell.com>
13369 * decl.cs (MemberCache.AddMethods): Register override methods,
13370 rather than non-override methods.
13371 * typemanager.cs (RegisterOverride): New.
13372 (IsOverride): Update.
13374 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13378 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13379 recursive declaration.
13381 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13383 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13385 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13387 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13389 2005-05-05 Raja R Harinath <rharinath@novell.com>
13392 * decl.cs (DeclSpace.FamilyAccessible):
13393 Use TypeManager.IsNestedFamilyAccessible.
13395 Fix reopened #64812.
13396 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13399 2005-05-04 Raja R Harinath <rharinath@novell.com>
13400 Abin Thomas <projectmonokochi@rediffmail.com>
13401 Anoob V E <projectmonokochi@rediffmail.com>
13402 Harilal P R <projectmonokochi@rediffmail.com>
13405 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13406 allow access to all static members.
13408 2005-05-04 Martin Baulig <martin@ximian.com>
13410 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13412 2005-05-04 Martin Baulig <martin@ximian.com>
13416 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13417 section at the end; make things work if `default' is not the last
13420 2005-05-04 Martin Baulig <martin@ximian.com>
13424 * statement.cs (Switch): Replaced the `got_default' field with a
13425 `default_section' one.
13426 (Switch.CheckSwitch): Set `default_section' here.
13427 (Switch.Resolve): If we're a constant switch and the constant is
13428 not found, use the default section.
13430 2005-05-03 Martin Baulig <martin@ximian.com>
13432 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13434 * statement.cs (Foreach.ArrayForeach): New nested class.
13435 (Foreach.TemporaryVariable): New nested class.
13436 (Foreach.EmitArrayForeach): Removed; this is now in the new
13437 ArrayForeach class.
13439 2005-05-03 Raja R Harinath <rharinath@novell.com>
13441 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13443 (VerifyPendingMethods): Revert change below.
13445 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13446 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13447 that used to trigger warning -28. Remove warning -28.
13448 * expression.cs (Invocation.OverloadResolve): Use
13449 TypeManager.IsOverride to distinguish override methods.
13452 * pending.cs (VerifyPendingMethods): If a base type implements the
13453 requested interface, don't bother checking individual methods of
13454 the base type. As a side-effect, this prevents the creation of
13455 unnecessary proxies.
13457 2005-05-02 Martin Baulig <martin@ximian.com>
13461 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13462 Also `And' the locals if the old vector is null.
13463 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13464 null; in this case we basically reset all the variables.
13466 2005-05-02 Martin Baulig <martin@ximian.com>
13470 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13471 Added `FlowBranching branching' argument; always `and' the
13472 variables instead of `or'ing them unless we're an infinite loop.
13474 * statement.cs (While.Resolve): Create a new sibling unless we're
13477 2005-05-02 Martin Baulig <martin@ximian.com>
13481 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13482 arguments; use it instead of creating a new TopLevelBlock.
13483 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13484 our ConstructorInitializer.
13487 (TopLevelBlock.TopLevelBranching): New public property.
13488 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13489 and create our `TopLevelBranching'.
13491 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13492 anonymous method host, use `block.TopLevelBranching' rather than
13493 creating a new branching.
13495 2005-04-20 Miguel de Icaza <miguel@novell.com>
13497 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13498 a ScopeInfo, if any of the current children is a child of the new
13499 entry, move those children there.
13501 2005-04-30 Martin Baulig <martin@ximian.com>
13503 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13504 at the beginning of a SwitchSection. Fix #73335.
13506 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13509 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13511 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13512 (FieldExpr.DoResolve): Obsolete members are ignored for field
13515 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13517 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13518 of arrays detection.
13520 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13522 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13524 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13527 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13529 * cs-parser.jay: Use the prefered version of -unsafe in error
13532 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13534 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13537 2005-04-20 John Luke <john.luke@gmail.com>
13539 * driver.cs: fix typo in error message, --outout to --output
13541 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13543 * codegen.cs (InRefOutArgumentResolving): New field.
13545 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13546 fields outside contructor.
13548 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13550 2005-04-19 Miguel de Icaza <miguel@novell.com>
13552 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13553 parameter code was not completed ever, so it was not as up-to-date
13554 as local variables. Must finish it.
13556 The bug fix was to compare the Toplevel of the block, not the
13557 current block. Thanks for Ben for pointing this out.
13559 2005-04-19 Raja R Harinath <rharinath@novell.com>
13561 * decl.cs (AddMethods): Use the declaring type of the problem
13562 method to determine if we want to squash a warning.
13564 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13566 * attribute.cs: Removed debug output.
13568 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13570 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13573 2005-04-18 Raja R Harinath <rharinath@novell.com>
13576 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13577 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13578 all null comparisons against reference types.
13580 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13583 * class.cs (TypeContainer.CircularDepException) New nested
13585 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13586 (TypeContainer.DefineType): Removed error, reset InTransit before
13588 (Class.DefineType): Throw exception when is in Transit.
13589 Catch exception and report error.
13590 (Struct.DefineType): Throw exception when is in Transit.
13591 Catch exception and report error.
13592 (Interface.DefineType): Throw exception when is in Transit.
13593 Catch exception and report error.
13595 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13596 handle nested exception handlers.
13598 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13601 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13602 InFinally and InCatch storage.
13604 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13605 (Catch.Resolve): Set and Restore ec.InCatch.
13606 (Try.Resolve): Set and Restore ec.InFinally.
13607 (Try.HasCatch): True when try has catch.
13609 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13611 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13612 for the same event member, so exclude such cases from warning 419.
13615 2005-04-16 Miguel de Icaza <miguel@novell.com>
13617 * expression.cs (Binary.ResolveOperator): Apply patch from John
13618 Luke to fix bug 59864: operators &, | and ^ on enumerations
13619 require that the same enum type on both sides.
13621 * driver.cs: Add warnings to old flag usage, this is to assist
13622 people who produce Makefiles and hope that the Makefiles will be
13625 * class.cs (TypeContainer.EmitType): Moved the definition of the
13626 special $PRIVATE$ field from the resolve phase to the Emit phase.
13627 During resolve we do not know if we are a struct with
13628 HasExplicitLayout, we know this only after the attributes for the
13631 Set the FieldOffset to zero on the dummy field that we create for
13632 the class. Fixes 74590.
13634 2005-04-16 Raja R Harinath <rharinath@novell.com>
13637 * ecore.cs (PropertyExpr.resolved): New.
13638 (DoResolve): Use it to handle a case of double resolution here.
13639 Handle a case of identical-name-and-type-name.
13640 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13641 resolution by storing the results of expression resolution back
13642 into the "probes" array.
13644 2005-04-15 Raja R Harinath <rharinath@novell.com>
13646 Fix cs0208-7.cs and cs0208-8.cs.
13647 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13648 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13649 error reporting to point out the reason a struct is not unmanaged.
13651 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13653 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13654 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13656 2005-04-13 Raja R Harinath <rharinath@novell.com>
13659 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13660 IdenticalNameAndTypeName here.
13661 (EventExpr.InstanceResolve): Likewise.
13663 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13665 C# 2.0 DefaultCharSetAttribute implementation
13667 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13668 which allows us to set GlobalNamespace for every resolve.
13669 (Attribute.ResolveArguments): Cut from Resolve.
13670 (Attribute.GetCharSetValue): Returns CharSet named argument.
13671 (Attribute.DefinePInvokeMethod): Gets default charset from
13673 (GlobalAttribute.ResolveAsTypeStep): Override.
13674 (GlobalAttribute.ResolveArguments): Override.
13676 * class.cs (TypeAttr): Is protected.
13678 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13679 (ModuleClass.DefaultCharSetType): New memeber.
13680 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13682 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13683 charset from module.
13685 * delegate.cs (TypeAttr): Override.
13686 (Delegate.DefineType): Use this TypeAttr.
13688 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13689 at very early stage (before types are defined) to resolve model
13690 module attributes. It will probably not work with corlib but it
13693 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13694 charset from module.
13696 * typemanager.cs (default_charset_type): New type.
13698 2005-04-13 Raja R Harinath <rharinath@novell.com>
13700 * decl.cs (MemberCache.AddMethods): Don't warn if
13701 System.Object.Finalize has buggy MethodAttributes.
13703 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13706 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13708 * doc.cs : detect ambiguous reference to overloaded members.
13709 Fixed bug #71603. MS 1.1 csc does not detect it.
13711 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13713 * doc.cs : delegates must not be referenced with parameters.
13716 2005-04-12 Miguel de Icaza <miguel@novell.com>
13718 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13720 2005-04-10 Miguel de Icaza <miguel@novell.com>
13722 * driver.cs (MainDriver): Stop processing if the CLS stage found
13725 (CompilerCallableEntryPoint.InvokeCompiler): Always
13726 reset after execution; Take a TextWriter argument for the
13729 * report.cs: Use the error stream instead of hardcoding stderr.
13731 2005-04-09 Miguel de Icaza <miguel@novell.com>
13733 * class.cs: Reduce code paths to test, too small of an
13734 optimization to make it worth the extra testing. Always perform
13737 2005-04-08 Raja R Harinath <rharinath@novell.com>
13740 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
13741 operators that had errors reported on them.
13743 2005-04-08 Marek Safar <marek.safar@seznam.cz>
13745 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
13747 (Attribute.Resolve): Add named argument type checking.
13749 * class.cs (FixedField.Define): Use IsPrimitiveType
13751 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
13753 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
13754 unsafe parameter types.
13756 * statement.cs (Using.ResolveExpression): Add better error description.
13758 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
13760 2005-04-08 Raja R Harinath <rharinath@novell.com>
13763 * attribute.cs (Attribute.GetAttributeUsage): Resolve
13764 AttributeUsageAttribute in the emitcontext of the attribute class,
13765 not in the emitcontext of the attributable entity it was attached to.
13766 * cs-parser.jay: Use 'current_class', not 'current_container',
13767 when creating a GlobalAttribute.
13769 2005-04-08 Alp Toker <alp@atoker.com>
13771 * pending.cs: The fix to #58413 failed to compile methods implementing
13772 interfaces with/without params modifiers and vice versa, even though
13773 params modifiers aren't part of the signature. Make the modifier check
13774 less strict as in csc.
13776 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
13777 Anoob V E <projectmonokochi@rediffmail.com>
13778 Harilal P R <projectmonokochi@rediffmail.com>
13781 * pending.cs (TypeAndMethods.mods): New. Store the parameter
13782 modifiers of pending methods.
13783 (PendingImplementation.PendingImplementation): Initialize it.
13784 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
13785 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
13786 with ParameterData. Add check for modifiers.
13787 * class.cs (MethodData.Define): Update to changes.
13789 2005-04-07 Raja R Harinath <rharinath@novell.com>
13791 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
13793 2005-04-07 Marek Safar <marek.safar@seznam.cz>
13795 * class.cs (PropertyMethod.Define): Check private accessor in abstract
13798 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
13801 * typemanager.cs: Registered RequiredAttributeAttribute.
13803 2005-04-06 Marek Safar <marek.safar@seznam.cz>
13805 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
13806 Warning CS0169 is back at level 3.
13807 (IMethodData.SetMemberIsUsed): New method.
13809 * decl.cs (IsUsed): New value; moved from FieldBase.Status
13810 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
13812 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
13814 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
13816 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
13819 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
13822 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
13823 to avoid the problems with nested types.
13825 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
13826 Anoob V.E <projectmonokochi@rediffmail.com>
13827 Harilal P.R <projectmonokochi@rediffmail.com>
13828 Raja R Harinath <rharinath@novell.com>
13831 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
13833 * typemanager (GetConstructor): Make public.
13835 2005-04-05 John Luke <john.luke@gmail.com>
13836 Raja R Harinath <rharinath@novell.com>
13839 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
13840 struct too. Return false quicker in a few cases.
13841 (VerifyUnManaged): Use it.
13843 2005-04-05 Raja R Harinath <rharinath@novell.com>
13846 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
13847 not 'unreachable_seen'.
13849 2005-04-04 Marek Safar <marek.safar@seznam.cz>
13851 * attribute.cs (Attribute.GetValue): Removed unused.
13853 * codegen.cs (CodeGen.TrimExt): Removed unused.
13855 * cs-parser.jay (output): Removed unused.
13857 * cs-tokenizer.cs (hex_digits): Removed unused.
13859 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
13861 * expression.cs (Indirection.LoadExprValue): Removed unused.
13862 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
13864 * iterators.cs (Iterator.param_types): Removed unused.
13866 * statement.cs (Goto.block): Removed unused.
13867 (ToplevelBlock.did): Removed unused.
13868 (Switch.ResolveConstantSwitch): Removed unused.
13870 2005-04-01 Ben Maurer <bmaurer@ximian.com>
13872 * rootcontext.cs: Allow mcs to bootstrap with the compilation
13875 2005-04-01 Raja R Harinath <rharinath@novell.com>
13877 Fix #74232 and cs0208-3.cs.
13878 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
13879 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
13880 unmanaged type. Don't use FieldBuilders when 't' is a
13881 TypeBuilder. Use ModFlags and MemberType fields.
13882 * class.cs (MemberBase.member_type): Rename from MemberType.
13883 (MemberBase.MemberType): New property. Determines member_type on
13885 (MemberBase.DoDefine): Don't initialize MemberType here.
13886 (FieldMember.Define): Likewise.
13888 2005-04-01 Marek Safar <marek.safar@seznam.cz>
13891 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
13892 Attributes are emitted there.
13894 2005-04-01 Raja R Harinath <rharinath@novell.com>
13896 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
13897 keyword in 'partial enum' too.
13898 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
13900 Report from Kamil Skalski <nazgul@omega.pl>.
13903 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
13904 have partial containers too.
13906 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
13907 in block' checks to Block.CheckInvariantMeaningInBlock.
13908 * statement.cs (Block.GetKnownVariableInfo): Make private.
13909 (Block.IsVariableUsedInChildBlock): Remove.
13910 (Block.IsVariableUsedInBlock): Likewise.
13911 (Block.CheckInvariantMeaningInBlock): New. Show location of
13912 conflicting declaration.
13913 (Block.AddVariable): Make error messages less long-winded and more
13914 specific. Show location of conflicting declaration.
13915 * parameter.cs (Parameters.Location): New readonly property.
13917 2005-03-31 Raja R Harinath <rharinath@novell.com>
13919 Clean up semantics of invoking ResolveMemberAccess.
13920 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
13921 can have an instance, ensure that we pass in a non-TypeExpression
13922 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
13923 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
13924 argument. Update to changes and simplify.
13925 (FieldExpr.Emitinstance): Remove CS0120 check.
13926 (PropertyExpr.EmitInstance): Likewise.
13927 * expression.cs (Argument.Resolve): Likewise.
13928 (Invocation.DoResolve): Update to changes in semantics of
13929 InstanceExpression.
13931 2005-03-31 Marek Safar <marek.safar@seznam.cz>
13934 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
13937 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
13939 2005-03-31 Raja R Harinath <rharinath@novell.com>
13941 Fix difference in behaviour with commandline invocation.
13942 * driver.cs (Driver.Reset): New.
13943 (CompilerCallableEntryPoint): Call it.
13945 * statement.cs (If.Resolve): Avoid spurious "uninitialized
13946 variable" warnings if the boolean expression failed to resolve.
13948 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
13950 * attribute.cs: Fix the union of several permissions when some of them
13951 are unrestricted (so the result isn't an unrestricted permission set).
13954 2005-03-30 Raja R Harinath <rharinath@novell.com>
13956 * ecore.cs (MemberExpr): New class. Convert from interface
13958 (MemberExpr.ResolveMemberAccess): Refactor and move here from
13959 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
13961 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
13962 (MethodGroupExpr.IsExplicitImpl): Remove.
13963 (Expression.GetFieldFromEvent): Remove.
13964 (SimpleName.MemberStaticCheck): Remove.
13965 (SimpleName.DoSimpleNameResolve): Update to changes.
13966 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
13967 (MemberAccess.IdenticalNameAndTypeName): Remove.
13968 (MemberAccess.error176): Move to MemberExpr.
13969 (MemberAccess.DoResolve): Update to changes.
13970 (BaseAccess.DoResolve): Likewise.
13972 2005-03-30 Marek Safar <marek.safar@seznam.cz>
13974 C# 2.0 Conditional attribute class implementation
13976 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
13977 Analyzes class whether it has attribute which has ConditionalAttribute
13978 and its condition is not defined.
13980 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
13981 (Class.IsExcluded): New method. Search for at least one defined
13982 condition in ConditionalAttribute of attribute class.
13984 2005-03-30 Raja R Harinath <rharinath@novell.com>
13986 * ecore.cs (PropertyExpr): Derive from Expression, not
13987 ExpressionStatement.
13988 (PropertyExpr.EmitStatement): Remove.
13990 2005-03-29 Raja R Harinath <rharinath@novell.com>
13993 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
13994 internal field "value__" of an enum be private. The examples for
13995 "value__" that I found on MSDN all used FieldAttributes.Private.
13997 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
13998 Don't mention IL method attribute names.
14000 Fix #47991. Remove a TODO.
14001 * statement.cs (Block.Toplevel): Make into a field.
14002 (Block.Parameters): Move into ToplevelBlock.
14003 (Block.known_variables): Rename from child_variable_names.
14004 (Block.Block): Remove variants that take Parameters. Initialize
14005 'Toplevel' with the immediately surrounding toplevel block.
14006 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14007 LocalInfo parameter.
14008 (Block.GetKnownVariableInfo): New.
14009 (Block.IsVariableNameUsedInChildBlock): Update.
14010 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14011 the block, even though it may not be in scope.
14012 (Block.AddVariable): Remove Parameters parameter. Use
14013 Toplevel.Parameters instead.
14014 (Block.AddConstant): Remove Parameters parameter.
14015 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14016 (Block.IsParamaterReference): Likewise.
14017 (Block.IsLocalParameter): Likewise. Simplify a lot.
14018 (ToplevelBlock.Parameters): New. Moved from Block.
14019 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14020 initialize Parameters to a non-null value.
14021 * cs-parser.jay: Update to changes.
14022 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14023 simple names that mean different things in the same block. Use
14024 Block.IsVariableNameUsedInBlock.
14026 2005-03-28 Raja R Harinath <rharinath@novell.com>
14028 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14029 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14030 GetTypeHandle. It is possible for a reflected type to derive from
14031 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14032 System.Array during mscorlib compilation).
14033 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14034 contain a method_hash, don't create one either. Don't create a
14035 deep copy of the base cache's method_hash.
14036 (MemberCache.SetupCache): Rename back from DeepCopy.
14037 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14038 already initialized. If we see an override function, add its
14039 underlying base virtual function to the member_hash too.
14041 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14043 2005-03-26 Raja R Harinath <harinath@acm.org>
14046 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14047 fails to resolve, ensure that the LHS is still resolved as an
14050 2005-03-25 Raja R Harinath <harinath@acm.org>
14052 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14054 (Enum.current_ec): Remove.
14055 (Enum.LookupEnumValue): Remove EmitContext argument.
14056 Just uses the one created during DefineType.
14057 (Enum.FindMembers): Update.
14058 * expression.cs (MemberAccess.DoResolve): Update.
14060 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14062 * assign.cs (Assign.DoResolve): Check for CS1717 when
14063 source and target are same (uses Equals).
14065 * expression.cs (LocalVariableReference, ParameterReference,
14066 This): Implemented Equals, GetHashCode.
14068 * statement.cs (Block.GetParameterReference): Removed useless
14071 2005-03-22 Raja R Harinath <rharinath@novell.com>
14074 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14075 blocks before deciding whether the error is cs0136 or cs0128.
14077 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14078 (using_alias_directive, using_namespace_directive): Pass
14079 MemberName, not an expression to Namespace.UsingAlias and
14081 (MakeName): Use the MemberName of the namespace.
14082 * namespace.cs (Namespace.MemberName): New.
14083 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14084 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14086 * decl.cs (MemberName.Name): Make readonly.
14087 (MemberName.FromDotted): New "constructor".
14088 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14089 (MemberCore.Name): Compute from MemberName on demand.
14090 (MemberCore.SetMemberName): Provide a way to change the
14092 (MemberCore.AddToContainer): Don't take a fullname parameter.
14093 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14094 fully qualified name of the container to the member name.
14095 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14096 only if the type is a member of the root container.
14097 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14098 MemberName.Left rather than searching for an embedded ".".
14099 (PartialContainer.CreatePart): Update to changes in RootContext.
14100 (MemberBase.ShortName): Turn into a property. Use
14101 MemberCore.SetMemberName.
14102 (MemberBase.ExplicitInterfaceName): Remove.
14103 (MemberBase.UpdateMemberName): Remove.
14104 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14105 (PropertyBase.SetMemberName): New override.
14106 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14107 (Tree.GetDecl): New.
14108 (Tree.AllDecls): Rename from Decls.
14109 * attribute.cs, enum.cs, report.cs: Update to changes.
14110 * driver.cs (MainDriver): Use MemberName.FromDotted on
14111 RootContext.MainClass.
14113 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14115 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14118 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14120 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14122 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14123 property accessor modifiers.
14125 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14126 fixed buffer attribute (CS1716).
14127 (PropertyMethod.HasCustomAccessModifier): When property accessor
14128 has custom modifier.
14130 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14132 (PropertyExpr.DoResolveLValue): Add CS0272.
14134 2005-03-17 Miguel de Icaza <miguel@novell.com>
14136 * convert.cs: When converting to a pointer, use the proper Conv.U
14137 or Conv.I depending on the source data type.
14139 * cs-tokenizer.cs: Make the size for large decimal constants,
14142 2005-03-17 Martin Baulig <martin@ximian.com>
14144 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14145 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14147 2005-03-17 Martin Baulig <martin@ximian.com>
14149 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14150 to bool so we can return an error condition.
14151 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14154 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14156 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14159 2005-03-16 Raja R Harinath <rharinath@novell.com>
14161 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14162 Refactor to avoid traversing the list of assemblies, and to avoid
14163 string concatenation.
14164 * typemanager.cs (guid_attr_type): Remove.
14165 (negative_hits, pointers, references): Remove hashes.
14167 (GetConstructedType): New. Uses type_hash to handle constructed
14168 types (arrays, references, pointers).
14169 (GetReferenceType, GetPointerType): Use it.
14170 (GetNestedType): New. Uses type_hash to handle nested types of
14172 (LookupType, LookupTypeDirect): Remove.
14173 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14174 'types' hash and LookupTypeReflection directly.
14175 (params_string, params_object): Use GetConstructedType.
14176 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14178 (Namespace.Lookup): Use cached_types.
14179 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14180 provided by old TypeManager.LookupType.
14181 * rootcontext.cs (MakeFQN): Remove.
14182 * decl.cs (DeclSpace.MakeFQN): Likewise.
14183 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14184 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14185 TypeManager.GetConstructedType.
14186 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14188 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14190 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14193 * cs-parser.jay: Reports CS1527 for any namespace element.
14195 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14198 * expression.cs (ParameterReference.IsAssigned): Changed error to
14200 (Error_WrongNumArguments): Moved CS0245 detection here.
14202 * statement.cs (Return.Resolve): Add CS1622 report.
14204 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14206 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14208 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14210 * attribute.cs expression.cs: Get rid of some allocations.
14212 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14214 * doc.cs : just eliminate the latest change.
14216 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14218 * doc.cs : commented out the latest change. It breaks xml-030.cs
14220 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14222 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14223 fail. So invoke CreateType() in FindDocumentedType().
14225 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14227 * cs-tokenizer.cs : added IsKeyword().
14228 * doc.cs : Detect keyword incorrectly used as identifier.
14229 Allow identifiers prefixed by @.
14231 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14233 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14234 It caused exception in namespace resolving (again!).
14236 * class.cs (Class.ctor): Removed exit.
14237 (PropertyMethod.ctor): ditto.
14239 * codegen.cs (Codegen.Reset): Reset static data.
14240 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14242 * cs-tokenizer.cs (Cleanup): Removed.
14244 * driver.cs (GetSystemDir): Rewrote to one line command.
14245 It caused problem with unloaded dynamic modules.
14246 (UnixParseOption): Removed Exit.
14247 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14248 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14249 Now can be mcs used as library.
14251 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14254 * location.cs (Reset): Reset static data.
14256 * namespace.cs (Reset): Reset static data.
14258 * report.cs (Report.Reset): Reset static data.
14260 * rootcontext.cs (RootContext.Reset): Reset static data.
14262 * tree.cs (RootTypes.ctor): Use Location.Null
14264 * typemanager.cs (TypeManager.Reset): Reset static data.
14265 (CoreLookupType): Removed Exit.
14266 (TypeHandle.Reset): Reset static data.
14268 2005-03-10 Raja R Harinath <rharinath@novell.com>
14271 * typemanager.cs (ComputeNamespaces): Import namespaces from
14272 referenced modules too.
14274 2005-03-09 Raja R Harinath <rharinath@novell.com>
14276 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14279 2005-03-09 Raja R Harinath <rharinath@novell.com>
14281 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14282 enclosing DeclSpace. This ensures that a name-lookup populates
14283 more caches and there are fewer 'TypeExpression's. Carve out
14284 nested type lookup into ...
14285 (LookupNestedTypeInHierarchy): ... this.
14287 2005-03-09 Raja R Harinath <rharinath@novell.com>
14289 Clean up a few partial-class semantics.
14290 Fixes test-357.cs and cs1618-2.cs.
14291 * cs-parser.jay (struct_declaration): Use 'current_class' as
14292 parent of newly-created struct. Remove call to Register ().
14293 Use 'pop_current_class' to complete handing the current struct.
14294 (interface_declaration): Likewise.
14295 (class_declaration): Likewise.
14296 (enum_declaration): Use 'current_class' as parent of newly created
14298 (delegate_declaration): Likewise.
14299 (pop_current_class): New function. This is used to handle closing
14300 up the 'current_class' and 'current_container', and pointing them
14301 to the enclosing class/container.
14302 (CSharpParser): Initialize 'current_class' too.
14303 * decl.cs (MemberCore): Add check for invariant: a partial
14304 container is not a parsed entity, and thus does not enclose any
14306 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14307 (DeclSpace.BaseTypeExpr): Use it.
14308 (DeclSpace.LookupType): Add check for invariant.
14309 * class.cs (TypeContainer): Add check for invariant: a nested
14310 class should have the same NamespaceEntry as its enclosing class.
14311 (TypeContainer.EmitFieldInitializers): Make virtual.
14312 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14314 (TypeContainer.Register): Remove.
14315 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14316 null. Use TypeResolveEmitContext for resolving base types and
14317 interfaces. Move initialization of Parts.TypeBuilder here from
14319 (TypeContainer.DefineNestedTypes): ... here.
14320 (PartialContainer): Take a Namespace not a NamespaceEntry.
14321 (PartialContainer.Create): Don't use Register. Call the
14322 appropriate Add... function directly.
14323 (ClassPart): Take both the PartialContainer and the enclosing
14324 class as constructor arguments.
14325 (ClassPart.EmitFieldInitializers): Override.
14326 (ClassPart.PartFindNestedTypes): Remove.
14327 (FieldBase.GetInitializerExpression): Resolve the initializer
14328 expression in the emit context of the enclosing class.
14329 * tree.cs (RootTypes): Remove Register ().
14331 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14333 * cs-parser.jay: Removed CS0134.
14335 * driver.cs: Removed CS1901.
14337 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14338 for predefined types.
14340 2005-03-07 Duncan Mak <duncan@novell.com>
14342 * codegen.cs (Save): Catch UnauthorizedAccessException as
14343 well. Fixes bug #73454.
14345 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14347 * cs-tokenizer.cs (xtoken): Add CS1035.
14349 * class.cs (MethodData.Define): Add CS0683.
14350 (FieldMember.ctor): Add CS0681.
14352 2005-03-07 Raja R Harinath <rharinath@novell.com>
14354 * ecore.cs (SimpleName.DoResolve): Rename from
14355 SimpleName.DoResolveAllowStatic.
14356 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14357 Pass 'intermediate' flag to MemberStaticCheck.
14358 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14359 of "intermediate" lookups via MemberAccess.
14360 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14361 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14363 2005-03-07 Raja R Harinath <rharinath@novell.com>
14366 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14367 slipped in because of variable names that are identical to a
14368 builtin type's BCL equivalent ('string String;', 'int Int32;').
14369 (PropertyExpr.EmitInstance): Likewise.
14371 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14373 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14375 * report.cs (warning_ignore_table): Made public.
14377 2005-03-04 Raja R Harinath <rharinath@novell.com>
14380 * class.cs (MethodData.Emit): Pass 'container' to
14381 container.GetObsoleteAttribute instead of 'container.Parent'.
14383 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14385 * cs-parser.jay: Add 1534 error test.
14387 * iterators.cs (Yield.CheckContext): Add error 1629.
14388 (Iterator.ctor): Save unsafe modifier.
14389 (MoveNextMethod.DoEmit): Restore unsafe context.
14391 * namespace.cs (UsingAlias): Better error message.
14393 2005-03-03 Dan Winship <danw@novell.com>
14395 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14396 the warning message [#73219]
14398 2005-03-03 Raja R Harinath <rharinath@novell.com>
14400 Fix compile with MCS 1.0.0.0.
14401 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14402 w_restore to not depend on string constant folding.
14404 2005-03-03 Raja R Harinath <rharinath@novell.com>
14406 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14407 CS0246 check to users who passed 'silent = false'.
14408 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14410 (SimpleName.SimpleNameResolve): Update.
14411 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14412 (MemberAccess.IdenticalNameAndTypeName): Update.
14413 * doc.cs (FindDocumentedTypeNonArray): Update.
14415 2005-03-03 Raja R Harinath <rharinath@novell.com>
14417 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14418 * parameters.cs (ComputeAndDefineParameters): Remove.
14419 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14420 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14421 Use GetParameterInfo.
14423 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14425 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14427 2005-03-02 Raja R Harinath <rharinath@novell.com>
14429 Unify DeclSpace.LookupType and DeclSpace.FindType.
14430 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14431 is in charge of defining nested types on demand.
14432 (DeclSpace.LookupType): Use it when the current_type is a
14433 TypeBuilder. Use LookupTypeDirect for reflected types.
14434 (DeclSpace.FindType): Remove.
14435 (DeclSpace.LookupInterfaceOrClass): Likewise.
14436 (DeclSpace.DefineTypeAndParents): Likewise.
14437 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14438 DeclSpace.LookupType.
14439 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14440 * typemanager.cs (LookupType): Simplify.
14441 (AddUserType): Remove type from negative_hits.
14442 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14443 * class.cs (TypeContainer.FindMembers): Move handling of nested
14445 (TypeContainer.FindMembers_NestedTypes): ... here.
14446 (TypeContainer.FindNestedType): Implement override.
14447 (ClassPart.FindNestedType): Delegate to PartialContainer.
14448 (ClassPart.PartFindNestedType): Looks up the nested types of the
14451 2005-03-02 Martin Baulig <martin@ximian.com>
14453 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14454 static constructor in static classes.
14456 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14458 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14459 sizeParamIndex is not specified.
14461 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14464 * report.cs (WarningMessage.IsEnabled): Missing null check.
14466 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14468 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14469 in the fields and not in the properties.
14471 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14473 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14476 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14478 * attribute.cs: Small refactoring (improved robustness).
14479 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14480 (ValidateGuid): Removed.
14481 (Resolve): Removed referenced to above mentioned.
14482 (GetAttributeUsage): Made private and changed to work without
14484 (GetIndexerAttributeValue): Don't crash.
14485 (GetConditionalAttributeValue): Ditto.
14486 (GetClsCompliantAttributeValue): Ditto.
14487 (ExtractSecurityPermissionSet): All attributes exceptions are
14489 (GetPropertyValue): New helper.
14490 (GetMethodImplOptions): New method.
14491 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14492 some missing properties.
14494 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14495 (Method.ApplyAttributeBuilder): Updated.
14497 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14500 2005-02-28 Raja R Harinath <rharinath@novell.com>
14503 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14504 non-simple types (array, pointer, reference).
14506 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14508 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14510 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14512 (Method.CheckBase): Catch wrong destructor here.
14513 (MethodData.Define): Add errors 550, 668.
14515 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14517 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14519 * pending.cs (VerifyPendingMethods): Add error 551.
14521 * typemanager.cs (CSharpName): Next error report helper.
14523 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14525 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14526 attributes. Removed useless attribute double check.
14527 It saves almost 2MBs for corlib.
14529 2005-02-25 Raja R Harinath <rharinath@novell.com>
14532 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14533 called twice in case of error.
14535 2005-02-23 Chris Toshok <toshok@ximian.com>
14537 Fix compiler portions of #72827.
14538 * statement.cs (Block.Emit): call Begin/EndScope on the
14539 EmitContext instead of the ILGenerator.
14541 * codegen.cs (EmitContext.BeginScope): new method, call
14542 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14544 (EmitContext.BeginScope): same, but EndScope and CloseScope
14546 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14547 offset and call the superclass's OpenScope(int) with it.
14548 (SymbolWriter.CloseScope): get the current il
14549 offset and call superclass's CloseScope(int) with it.
14551 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14553 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14554 CS1677 for out and ref as well.
14556 * class.cs (Method.Define): Add error CS1599 detection.
14558 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14560 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14562 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14564 * support.cs.cs (ModifierDesc): New helper method.
14566 2005-02-23 Raja R Harinath <rharinath@novell.com>
14567 Abin Thomas <projectmonokochi@rediffmail.com>
14568 Anoob V E <projectmonokochi@rediffmail.com>
14569 Harilal P R <projectmonokochi@rediffmail.com>
14571 Fix #57851, #72718.
14572 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14573 MemberLookup (used for error reporting) actually returns a result.
14574 Fix error report number (122, not 112).
14576 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14577 Anoob V E <projectmonokochi@rediffmail.com>
14578 Harilal P R <projectmonokochi@rediffmail.com>
14581 * pending.cs (PendingImplementation.GetAbstractMethods):
14582 Find NonPublic members too.
14584 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14586 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14589 * class.cs (MethodCore.CheckMethodAgainstBase):
14590 Add error 239 report.
14592 2005-02-21 Raja R Harinath <rharinath@novell.com>
14595 * expression.cs (Invocation.IsApplicable): Make public.
14596 (Invocation.IsParamsMethodApplicable): Likewise.
14597 * delegate.cs (Delegate.VerifyApplicability): Don't use
14598 Invocation.VerifyArgumentCompat for parameter applicability
14599 testing. Use Invocation.IsApplicable and
14600 Invocation.IsParamsMethodApplicable.
14602 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14604 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14606 * class.cs (Operator.Define): Add error 217 report.
14608 2005-02-21 Raja R Harinath <rharinath@novell.com>
14610 * namespace.cs (UsingEntry.Resolve): Undo change below.
14612 2005-02-21 Raja R Harinath <rharinath@novell.com>
14615 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14616 disable the error message when the extended MemberLookup also
14618 (Expression.MemberLookupFinal): Update.
14619 (SimpleName.DoSimpleNameResolve): Update.
14620 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14621 Don't use MemberLookupFinal.
14622 (New.DoResolve): Update.
14623 (BaseAccess.CommonResolve): Update.
14625 2005-02-21 Raja R Harinath <rharinath@novell.com>
14628 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14629 occured previously, don't resolve again.
14631 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14634 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14635 argument. Call ResolveAttributeUsage for unresolved.
14636 when types doesn't match ctor arguments.
14638 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14639 for nested attribute classes.
14640 (Class.attribute_usage): Removed.
14641 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14642 for attribute class.
14644 * ecore.cs (IsAttribute): Removed.
14646 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14648 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14650 (attribute_types): Removed.
14651 (EmitCode): Global attributes are emited as the latest.
14653 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14655 * class.cs (EmitFieldInitializers): Don't emit field initializer
14656 for default values when optimilization is on.
14658 * constant.cs (Constant.IsDefaultValue): New property.
14660 * driver.cs: Add /optimize handling.
14664 * literal.cs: Implement new IsDefaultValue property.
14666 * rootcontext.cs (Optimize): New field, holds /optimize option.
14668 2005-02-18 Raja R Harinath <rharinath@novell.com>
14670 Fix crasher in re-opened #72347.
14671 * namespace.cs (Namespace.Lookup): Return null if
14672 DeclSpace.DefineType returns null.
14675 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14677 2005-02-18 Raja R Harinath <rharinath@novell.com>
14679 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14680 now returns null if it cannot resolve to an lvalue.
14681 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14682 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14683 returned null. Remove check for SimpleName.
14684 (EventExpr.DoResolveLValue): New.
14685 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14686 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14688 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14689 avoid CS0131 error.
14690 (Unary.ResolveOperator): Move CS0211 check ...
14691 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14693 (Unary.DoResolveLValue): Simplify.
14694 (AddressOf.DoResolveLValue): New.
14695 (ArrayAccess.DoResolveLValue): New.
14697 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14699 * attribute.cs (Attribute.Resolve): Add arguments casting for
14700 when types doesn't match ctor arguments.
14702 2005-02-16 Raja R Harinath <rharinath@novell.com>
14704 Fix parts of #63202.
14705 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14706 lookup of operator in base type. Ensure that all checks happen
14707 when the operator resolves to an "op_..." method.
14709 2005-02-15 Raja R Harinath <rharinath@novell.com>
14712 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14713 'ignore_cs0104' parameter. Pass it to ...
14714 (NamespaceEntry.Lookup): ... this.
14715 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14716 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14717 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14718 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14719 Update. Request that cs0104 errors be ignored.
14720 (ComposedCast.ResolveAsTypeStep): Update.
14722 2005-02-14 Raja R Harinath <rharinath@novell.com>
14725 * expression.cs (Invocation.BetterFunction): Remove support for
14726 comparing virtual functions and their overrides.
14727 (Invocation.IsOverride): New.
14728 (Invocation.OverloadResolve): Don't consider 'override' functions
14729 during candidate selection. Store them in a lookaside list.
14730 If the selected method is a 'virtual' function, use the list to
14731 find any overrides that are closer to the LHS type.
14733 2005-02-14 Marek Safar <marek.safar@seznam.cz>
14735 * expression.cs (New.DoResolve): Add complex core type reduction.
14736 (New.Constantify): Converts complex core type syntax like 'new int ()'
14737 to simple constant.
14739 2005-02-14 Raja R Harinath <rharinath@novell.com>
14741 * decl.cs (EntryType.EntryType): New constructor to create an
14742 updated copy of a cache entry.
14743 (MemberCache.AddMethods): Use it.
14744 (MemberCache.ClearDeclaredOnly): Remove.
14745 (MemberCache.MemberCache): Update.
14747 2005-02-11 Miguel de Icaza <miguel@novell.com>
14749 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
14750 variable. This one is represents the actual low-level declaration
14751 of the method, as opposed to the semantic level `IsStatic'.
14753 An anonymous method which is hosted into a static method might be
14754 actually an instance method. IsStatic would reflect the
14755 container, while MethodIsStatic represents the actual code
14758 * expression.cs (ParameterReference): Use the new MethodIsStatic
14759 instead of IsStatic.
14761 * anonymous.cs (AnonymousMethod.Compatible): Pass the
14762 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
14763 set on the current EmitContext.
14765 * expression.cs (Cast): Overload DoResolveLValue so we can pass
14766 resolve our casted expression as an LValue. This triggers the
14767 proper LValue processing that is later required by Assign.
14771 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
14773 2005-02-11 Marek Safar <marek.safar@seznam.cz>
14775 C# 2.0 Fixed buffer implementation
14777 * anonymous.cs: Update after RegisterHelperClass renaming.
14779 * attribute.cs (AttributeTester.fixed_buffer_cache):
14780 Cache of external fixed buffers.
14781 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
14782 implementation if field is fixed buffer else null.
14785 (TypeContainer.AddField): Accept FieldMember instead of Field.
14786 (FieldBase.IsFieldClsCompliant): Extracted code from
14787 VerifyClsCompliance descendant customization.
14788 (FixedField): New class handles fixed buffer fields.
14789 (FixedFieldExternal): Keeps information about imported fixed
14791 (IFixedField): Make access to internal or external fixed buffer
14794 * cs-parser.jay: Add fixed buffer parsing.
14796 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
14799 * expression.cs (Indirection): Extended implementation to accept
14800 fixed buffer field.
14801 (PointerArithmetic.Emit): Get element from fixed buffer as well.
14802 (ElementAccess.MakePointerAccess): Get type as parameter.
14803 (DoResolve): Add fixed buffer field expression conversion.
14804 (DoResolveLValue): Ditto.
14805 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
14806 (ArrayPtr): Derives from FixedBufferPtr.
14807 (ArrayPtr.Emit): Add extra emit for array elements.
14809 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
14811 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
14812 for compiler generated types.
14813 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
14815 * statement.cs (Fixed): Refactored to be easier add fixed buffer
14816 and consume less memory.
14817 (Fixed.Resolve): Add fixed buffer case.
14819 * typemanager.cs (compiler_generated_attr_ctor,
14820 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
14821 (HasElementType): Add our own implementation to work on every
14824 2005-02-11 Miguel de Icaza <miguel@novell.com>
14826 * anonymous.cs (CaptureContext): Track whether `this' has been
14829 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
14830 only captured `this' if it was implicitly done (instance
14831 methods/variables were used).
14833 * codegen.cs (EmitContext.CaptureThis): New method to flag that
14834 `this' must be captured.
14836 2005-01-30 Miguel de Icaza <miguel@novell.com>
14838 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
14839 is null it means that there has been no need to capture anything,
14840 so we just create a sibling.
14842 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
14844 Just a partial fix. The other half is fairly elusive.
14846 2005-02-10 Raja R Harinath <rharinath@novell.com>
14848 Fix #52586, cs0121-4.cs.
14849 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
14850 and return a hashtable.
14851 (MemberCache.ClearDeclaredOnly): New.
14852 (MemberCache.MemberCache): Update to change. Make a deep copy of
14853 the method_hash of a base type too.
14854 (MemberCache.AddMethods): Adapt to having a deep copy of the base
14855 type methods. Overwrite entries with the same MethodHandle so
14856 that the ReflectedType is correct. The process leaves in base
14857 virtual functions and their overrides as distinct entries.
14858 (CacheEntry): Now a class instead of a struct. It shouldn't alter
14859 matters since it was boxed in a ArrayList before.
14860 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
14862 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
14863 case of a virtual function and its override (choose the overload
14865 (Invocation.OverloadResolve): Avoid 'override' members during
14866 'applicable_type' calculation.
14868 2005-02-09 Raja R Harinath <rharinath@novell.com>
14870 Combine two near-redundant caches.
14871 * typemanager.cs (method_params): Rename from method_internal_params.
14872 (TypeManager.GetParameterData): New. Replace
14873 Invocation.GetParameterData.
14874 (TypeManager.LookupParametersByBuilder): Remove.
14875 * expression.cs (Invocation.method_parameter_cache): Remove.
14876 (Invocation.GetParameterData): Remove.
14878 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
14881 2005-02-08 Raja R Harinath <rharinath@novell.com>
14884 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
14885 TypeManager.multicast_delegate_type is null, resolve it by looking
14886 up "System.MulticastDelegate".
14887 * rootcontext.cs (RootContext.ResolveCore): Simplify.
14889 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
14890 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
14891 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
14894 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
14895 (LabeledStatement.AddReference): New. Set 'referenced'.
14896 (Goto.Resolve): Use it.
14898 2005-02-05 John Luke <john.luke@gmail.com>
14900 * driver.cs: remove duplicate -doc line in Usage ()
14902 2005-02-04 Raja R Harinath <rharinath@novell.com>
14904 * location.cs (Location.AddFile): Fix CS2002 error report.
14906 2005-02-02 Martin Baulig <martin@ximian.com>
14908 * delegate.cs (Delegate.DefineType): Report an internal error if
14909 TypeManager.multicast_delegate_type is null. See bug #72015 for
14912 2005-02-02 Raja R Harinath <rharinath@novell.com>
14914 Fix a crasher in a variant of #31984.
14915 * const.cs (Constant.CheckBase): New override that defers the
14916 new-or-override check in case the base type hasn't been populated
14918 (Constant.Define): Ensure the new-or-override check is performed.
14920 2005-02-01 Duncan Mak <duncan@ximian.com>
14922 * const.cs (LookupConstantValue): Check that `ce' is not null
14923 before calling GetValue ().
14925 2005-02-01 Raja R Harinath <rharinath@novell.com>
14927 Fix test-334.cs (#69519).
14928 * cs-parser.jay (using_alias_directive): Pass in an expression to
14929 NamespaceEntry.UsingAlias.
14930 (using_namespace_directive): Pass in an expression to
14931 NamespaceEntry.Using.
14932 (namespace_name): Don't flatten to a string.
14933 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
14934 (NamespaceEntry.AliasEntry.Resolve): Lookup using
14936 (NamespaceEntry.UsingEntry): Likewise.
14937 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
14939 (NamespaceEntry.LookupForUsing): Remove.
14940 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
14942 (NamespaceEntry.Lookup): Remove support for dotted names.
14944 2005-02-01 Raja R Harinath <rharinath@novell.com>
14946 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
14948 (NamespaceEntry.ImplicitParent): Compute on demand.
14949 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
14950 parallels the current.
14951 (NamespaceEntry.LookupForUsing): Use it.
14952 (NamespaceEntry.Lookup): If the current namespace-entry is
14953 implicit, don't search aliases and using tables.
14955 2005-02-01 Raja R Harinath <rharinath@novell.com>
14958 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
14960 (TypeContainer.BaseCache): Compute on demand.
14961 (TypeContainer.FindMembers): Define constants and types if they're
14962 not already created.
14963 (FieldMember.Define): Move resetting of ec.InUnsafe before error
14965 * const.cs (Constant.Define): Make idempotent.
14967 2005-01-29 Miguel de Icaza <miguel@novell.com>
14969 * pending.cs: Produce better code (no nops produced by using Ldarg
14972 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
14973 i - 1' it should be arg + 1.
14977 2005-01-28 Raja R Harinath <rharinath@novell.com>
14979 * attribute.cs (Attribute.CheckAttributeType): Make private
14981 (Attribute.ResolveType): Make virtual.
14982 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
14983 handling of RootContext.Tree.Types.
14985 2005-01-27 Raja R Harinath <rharinath@novell.com>
14987 Update attribute-handling to use the SimpleName/MemberAccess
14989 * cs-parser.jay (attribute): Pass in an expression to the
14990 constructors of Attribute and GlobalAttribute.
14991 * attribute.cs (Attribute): Take an expression for the name.
14992 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
14993 passed in attribute name expression.
14994 (Attribute.CheckAttributeType): Use it.
14995 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
14996 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
14997 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
14998 argument to prevent error messages if the lookup fails.
15000 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15002 * expression.cs (Indirection): Implemented IVariable interface
15003 to support indirection in AddressOf operator.
15004 (PointerArithmetic.Emit): Add optimalization for case where
15005 result can be precomputed.
15007 2005-01-26 Martin Baulig <martin@ximian.com>
15009 * class.cs (TypeContainer.AttributeTargets): Return the correct
15010 AttributeTargets depending on our `Kind' instead of throwing an
15011 exception; fixes #71632.
15013 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15016 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15019 2005-01-25 Raja R Harinath <rharinath@novell.com>
15022 * expression.cs (MemberAccess.DoResolve): Don't complain with
15023 cs0572 when the LHS of a member access has identical name and type
15026 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15029 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15031 Create custom PermissionSet only for PermissionSetAttribute.
15033 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15036 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15037 delegates in static class.
15039 2005-01-24 Martin Baulig <martin@ximian.com>
15041 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15042 merging an implicit block, just use its reachability.
15044 * statement.cs (Block.Resolve): Make the unreachable code check
15045 work wrt. implicit blocks; see test-337 from #63842.
15047 2005-01-21 Alp Toker <alp@atoker.com>
15049 * cs-parser.jay: destructor_declaration's container is PartialContainer
15050 not Class when partial types are used, so use Kind prop instead of
15053 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15055 * cs-parser.jay: Improve error reporting when an interface
15056 declares new types.
15058 2005-01-20 Dick Porter <dick@ximian.com>
15060 * support.cs: SeekableStreamReader fix from Sandor Dobos
15061 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15062 chars are read. Fixes bug 70369.
15064 2005-01-20 Raja R Harinath <rharinath@novell.com>
15066 * cs-parser.jay (catch_clause): Simplify current_block handling
15069 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15071 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15072 code with ImplicitStandardConversion to handle the implicit
15073 conversion of method groups into valid delegate invocations.
15075 The problem is that in parameter handling we were using this code
15076 path. Fixes bug #64698
15078 2005-01-19 Raja R Harinath <rharinath@novell.com>
15080 * cs-parser.jay: Fix several infelicities.
15081 - Avoid assigning to the parser value stack. Code like
15082 '$3 = null' is unclean. Synthesize a value for the code block
15084 - Avoid using oob_stack for storing location information. Use ...
15085 (_mark_): ... this. New (empty) rule. Saves the current location
15087 (foreach_statement): Avoid using oob_stack for current_block
15088 handling. Use technique used in for_statement and
15089 using_statement. Synthesize a value for the code block to store
15090 additional intermediate information.
15092 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15094 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15095 of a different type is only allowed to private fields of a
15096 containing type, not on fields of a base class.
15098 See test-174.cs and error cs0122-9.cs
15100 2005-01-13 Raja R Harinath <rharinath@novell.com>
15102 Fix test-335.cs (bug #58126).
15103 * cs-parser.jay (argument): Split out non-expression parts of the
15104 rule into 'non_simple_argument'.
15105 (invocation_expression): Support parenthesized invocations with
15106 multiple arguments, and with single non-simple arguments.
15108 2005-01-13 Raja R Harinath <rharinath@novell.com>
15110 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15113 2005-01-12 Raja R Harinath <rharinath@novell.com>
15115 Fix cs0038-1.cs, cs1640-6.cs.
15116 * ecore.cs (Expression.Resolve): Remove special-case for
15117 SimpleName in error-handling.
15118 (Expression.almostMatchedMembers): Relax access permission to
15120 (Expression.MemberLookupFailed): Handle duplicates in
15121 almostMatchedMembers list.
15122 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15123 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15124 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15125 overload if the passed in MemberInfo is a MethodBase.
15127 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15130 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15131 for non-CAS & merge permission sets properly.
15133 2005-01-11 Raja R Harinath <rharinath@novell.com>
15135 Improve standard-compliance of simple name and member access
15136 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15137 * ecore.cs (FullNamedExpression): New abstract base class
15138 for Namespaces and TypeExpressions.
15139 (ResolveFlags.SimpleName): Remove.
15140 (SimpleName): Remove support for dotted names.
15141 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15142 DeclSpace.FindType and DeclSpace.LookupType.
15143 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15144 (Expression.ExprClassName): Make member function.
15145 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15146 a namespace. Remove creation of dotted "SimpleName"s.
15147 (MemberAccess.DoResolve): Likewise.
15148 * decl.cs (DeclSpace.Cache): Make private.
15149 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15150 (DeclSpace.FindType): Update.
15151 (DeclSpace.LookupType): Move here from RootContext. Return a
15152 FullNamedExpression.
15153 * namespace.cs (Namespace): Derive from FullNamedExpression
15154 so that it can be part of expression resolution.
15155 (Namespace.Lookup): Return an FullNamedExpression.
15156 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15158 * rootcontext.cs (NamespaceLookup): Remove.
15159 (LookupType): Move to DeclSpace.
15160 * attribute.cs (CheckAttributeType): Update.
15161 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15162 (FindDocumentedTypeNonArray): Likewise.
15164 2005-01-11 Raja R Harinath <rharinath@novell.com>
15166 Fix cs0509.cs, cs1632.cs.
15167 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15168 is the same as IsInterface.
15169 (TypeContainer.GetClassBases): Likewise.
15170 * statement.cs (LabeledStatement.ig): New field.
15171 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15173 (LabeledStatement.DoEmit): Check that the label was created with
15174 the same ILGenerator.
15176 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15179 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15180 accessors to its properties.
15182 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15183 from accessors to property.
15185 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15188 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15189 only for overrides.
15191 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15193 * attribute.cs: Check for null and empty strings.
15195 I have lost another battle to Paolo.
15197 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15200 * class.cs (PropertyMethod): Set Parent field in ctors.
15201 (SetMethod.InternalParameters): Add unsafe switch hack.
15202 Override MarkForDuplicationCheck where it is appropriate.
15204 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15205 It says whether container allows members with the same name.
15206 Base default is no.
15207 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15208 Removed is_method parameter.
15210 2005-01-06 Duncan Mak <duncan@ximian.com>
15212 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15213 because the previous change led to incorrect reporting of CS1032
15214 ("Cannot define/undefine preprocessor symbols after first token in
15215 file"). Instead of using `tokens_seen' as the only flag that
15216 triggers CS1040, introduce `comments_seen'. This new flag is used
15217 to signify having seen comments on the current line, so it is
15218 unset after a newline.
15220 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15222 * doc.cs : When searching for a type, find nested type too.
15223 This fixes bug #71040.
15225 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15228 - Warn missing member comment on those classes which also does not
15229 have doc comments. Fixed bug #71041.
15230 - Don't warn missing doc comment on default constructor.
15233 2005-01-06 Duncan Mak <duncan@ximian.com>
15235 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15236 comments, set `tokens_seen' to true. This allows us to detect
15237 misplaced preprocessor directives (i.e. not at the beginning of
15238 the a line, nor after whitespaces). In that case, report error
15239 CS1040. This fixes bug #56460.
15241 * cs-parser.jay (interface_member_declaration): Add checks for
15242 IsExplicitImpl, and report CS0541 error if an interface member is
15243 defined as an explicit interface declaration.
15245 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15248 * class.cs (PropertyMethod): Set Parent field in ctors.
15249 (SetMethod.InternalParameters): Add unsafe switch hack.
15251 * decl.cs (MemberCore.Parent): Cannot be readonly.
15253 2005-01-06 Raja R Harinath <rharinath@novell.com>
15255 * decl.cs (DeclSpace.ResolveType): Remove.
15256 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15257 Merge in code from ...
15258 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15259 * class.cs, enum.cs: Update to changes.
15261 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15263 * anonymous.cs: Ensure that we init the scope of our parent if it
15264 has not been initialized yet.
15266 2004-12-30 Duncan Mak <duncan@ximian.com>
15268 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15269 if field.FieldBuilder is null. Fixes #70758.
15271 * convert.cs: Fixed some typos and updated some of the comments.
15272 (ImplicitStandardConversionExists):
15273 (TryImplicitIntConversion): If `target_type' is an interface and
15274 the type of `ic' implements this interface, return true or a new
15275 BoxedCast instead of null. This fixes #70468.
15277 2004-12-29 Duncan Mak <duncan@ximian.com>
15279 * expression.cs (Argument.Emit): Check that Expr is
15280 IMemoryLocation before casting to it, and report CS1510 otherwise.
15284 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15286 * statement.cs (Block.ThisVariable): remove the recursion here, to
15287 make the --profile more sane.
15289 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15291 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15292 assembly, by JB Evain.
15294 2004-12-17 Raja R Harinath <rharinath@novell.com>
15296 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15297 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15298 "parent" refers to enclosing type/class. "base" refers to superclass.
15300 2004-12-17 Raja R Harinath <rharinath@novell.com>
15302 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15303 Ensure that we only have GlobalAttributes.
15304 * attribute.cs (Attribute.Emit): Make non-virtual.
15305 (GlobalAttribute.Emit): Remove.
15306 (Attribute.Resolve): Make virtual.
15307 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15308 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15309 the argument. Don't create one.
15310 (Attribute.GetObsoleteAttribute): Likewise.
15311 (Attribute.GetClsCompliantAttributeValue): Likewise.
15312 * class.cs, decl.cs: Update to changes.
15314 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15316 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15318 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15320 * statement.cs (Foreach.Resolve): Add error 186 report.
15322 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15324 * expression.cs (Conditional.DoResolve): Add warning 429.
15326 * statement.cs (If.Resolve): Add warning 665.
15328 2004-12-16 Raja R Harinath <rharinath@novell.com>
15330 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15331 except when in the parser, and in GlobalAttribute.
15332 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15333 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15334 RootContext.Tree.Types.NamespaceEntry once work is done.
15335 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15336 and resets RootContext.Tree.Types.NamespaceEntry.
15338 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15340 * cs-parser.jay: Don't create a block for every variable.
15342 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15344 * location.cs: Provide extra information.
15346 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15347 variables from the captured environment, it is the ldarg_0.
15349 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15351 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15354 * class.cs: Changed warning level for 169 to avoid developer
15355 displeasure from warning flooding. It will be changed back when they
15356 fix most of current BCL warnings.
15358 * RootContext.cs: Pushed default WarningLevel to 3.
15360 * statement.cs: Removed unused variable.
15362 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15364 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15365 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15366 Add error 502 report.
15367 (StaticClass.DefineType): Add error 441 report.
15368 (Class.AllowedModifiersProp): New virtual property as temporary
15369 extension to AllowedModifiers.
15370 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15371 to share implementation with StaticClass and don't call virtual
15374 * driver.cs (MainDriver): Add error 1558 test.
15376 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15377 report. Moved error 36 test here.
15379 * statement.cs (Throw.Resolve): Add error 724 report.
15381 * typemanager.cs: Add out_attribute_type core type.
15383 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15385 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15387 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15389 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15392 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15394 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15395 Add error 3023 report.
15396 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15398 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15401 2004-12-12 John Luke <john.luke@gmail.com>
15403 * driver.cs (AddArgs): take -- into account when
15404 adding arguments, fixes bug 65710
15406 2004-12-12 Martin Baulig <martin@ximian.com>
15408 * expression.cs (Unary.TryReduceNegative): Added support for
15409 SByteConstant and ByteConstant.
15410 (Unary.Reduce): Check error values from TryReduceNegative().
15412 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15414 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15415 and report exception as error 182.
15417 2004-12-10 Raja R Harinath <rharinath@novell.com>
15419 * driver.cs (Main): Fix message when there are warnings.
15421 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15423 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15425 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15427 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15428 Reduced number of warnings.
15430 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15432 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15434 * driver.cs: Removed message.
15436 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15438 2004-12-08 <vargaz@freemail.hu>
15440 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15442 2004-12-08 Martin Baulig <martin@ximian.com>
15444 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15445 instead of a CS3002 for properties and indexer.
15447 2004-12-08 Martin Baulig <martin@ximian.com>
15449 * decl.cs (MemberName.ToString): Make this work again.
15451 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15453 * attribute.cs (Resolve): Add error 591 detection.
15455 * class.cs (FieldMember.Define): Add error 1547 detection.
15456 (Indexer.Define): Add error 620 detection.
15457 (Operator.Define): Add error 590 detection.
15459 * ecore.cs: Missing argument for error 79.
15461 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15464 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15467 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15470 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15472 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15473 Some operator comments were suppressed.
15474 * doc.cs : Implicit/explicit operator name in doc comments are like
15475 "op_Explicit(type)~returnType", so added suffix handling.
15477 2004-12-07 Martin Baulig <martin@ximian.com>
15480 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15481 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15482 (DeclSpace.ec): New protected field; store the EmitContext here.
15483 (DeclSpace.EmitContext): New public property; moved here from
15485 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15488 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15489 (Enum.Emit): Don't create a new EmitContext.
15491 * delegate.cs (Delegate.DefineType): Always create the
15494 * iterators.cs (Iterators.DefineIterator): Create a new
15495 EmitContext and store it in `ec'.
15497 2004-08-24 Martin Baulig <martin@ximian.com>
15500 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15501 this for accessibility checks.
15502 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15503 IsNestedFamilyAccessible.
15504 (TypeManager.IsSubclassOf): New method, do what the name actually
15507 2004-12-06 Raja R Harinath <rharinath@novell.com>
15509 Fix crash on cs0657-17.cs.
15510 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15511 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15512 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15513 the case where the NamespaceEntry gets overwritten.
15515 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15517 Fixed #69195, #56821
15518 * ecore.cs (ResolveBoolean): Tiny refactoring.
15520 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15521 of right expression resolving when left is false constant and
15522 operator is LogicalAnd OR true constant and operator is LogicalOr.
15524 * statement.cs (ResolveUnreachable): Always reports warning.
15526 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15528 * class.cs: Distinguish between 1721 and 1722 (just a little help
15529 for the programmer).
15531 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15533 * delegate.cs: Only allow this on new versions of the language.
15535 2004-12-02 Duncan Mak <duncan@ximian.com>
15537 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15539 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15540 here as a static method. Take an additional bool out parameter
15541 `must_do_cs1540_check' for signaling to InstanceResolve.
15542 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15543 member field from PropertyExpr class and made it an argument of
15544 the method instead.
15545 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15546 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15547 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15548 and `remove_accessor' as well as InstanceResolve: report CS0122
15553 2004-12-03 Raja R Harinath <rharinath@novell.com>
15555 Fix test-327.cs, test-328.cs, and put in early infrastructure
15556 for eventually fixing #52697.
15557 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15558 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15559 from other methods.
15560 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15561 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15562 (VerifyUsing, error246): Update.
15563 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15564 'NamespaceEntry.LookupNamespaceOrType'.
15566 2004-12-03 Martin Baulig <martin@ximian.com>
15568 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15569 method as our child, call AnonymousMethod.Compatible() on it.
15571 2004-12-03 Raja R Harinath <rharinath@novell.com>
15573 Disable XML documentation support in 'basic' profile.
15574 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15575 Redirect XmlElement to System.Object.
15576 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15577 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15578 * mcs.exe.sources: Add doc-bootstrap.cs.
15579 * doc-bootstrap.cs: New file. Contains empty stub implementation
15582 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15584 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15585 comments are allowed.
15587 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15589 * delegate.cs: Add checks for subtypes in paramaters and return values
15590 in VerifyMethod () to add support for Covariance/Contravariance
15593 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15595 * report.cs: Remove extra closing parenthesis.
15597 * convert.cs (Error_CannotImplicitConversion): If the name of the
15598 types are the same, provide some extra information.
15600 * class.cs (FieldBase): Use an unused bit field from the field to
15601 encode the `has_offset' property from the FieldMember. This saves
15602 a couple of Ks on bootstrap compilation.
15604 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15605 method as our child, return the AnonymousMethod resolved
15608 * expression.cs (New.DoResolve): Allow return values from
15609 NewDelegate to also include AnonymousMethods.
15613 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15616 * attribute.cs (Resolve): Improved implementation of params
15617 attribute arguments.
15619 * support.cs (ParameterData): Add HasParams to be faster.
15621 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15623 all things are for /doc support:
15625 * doc.cs: new file that supports XML documentation generation.
15626 * mcs.exe.sources: added doc.cs.
15628 Handle /doc command line option.
15629 Report error 2006 instead of 5 for missing file name for /doc.
15630 Generate XML documentation when required, after type resolution.
15632 Added support for picking up documentation (/// and /** ... */),
15633 including a new XmlCommentState enumeration.
15635 Added lines to fill Documentation element for field, constant,
15636 property, indexer, method, constructor, destructor, operator, event
15637 and class, struct, interface, delegate, enum.
15638 Added lines to warn incorrect comment.
15640 Added Documentation field (passed only when /doc was specified).
15642 Added DocComment, DocCommentHeader, GenerateDocComment() and
15643 OnGenerateDocComment() and some supporting private members for
15644 /doc feature to MemberCore.
15646 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15648 Added overriden DocCommentHeader.
15650 Added overriden DocCommentHeader and GenerateDocComment().
15652 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15654 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15655 unwrapping the enumeration values, chain to
15656 DoConstantNumericPromotions again, so we can promote things to the
15657 fundamental types (takes care of enums that are bytes, sbytes).
15661 2004-12-01 Raja R Harinath <rharinath@novell.com>
15663 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15664 Fix long-standing bug in type-lookup. Use FindType instead of
15665 LookupType when ec.ResolvingTypeTree.
15666 (Attribute.ResolveType, Attribute.Resolve)
15667 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15669 (Attributes.Search): Remove internal version. Update.
15670 (Attributes.SearchMulti): Update.
15671 (Attributes.GetClsCompliantAttribute): Remove.
15672 (Attributes.GetIndexerNameAttribute): Remove.
15673 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15674 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15675 * class.cs (Indexer.Define): Likewise.
15677 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15680 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15681 MarshallByReference members access.
15683 * expression.cs: Use CheckMarshallByRefAccess;
15684 Better error CS0197 message.
15686 * report.cs: Print whole related error message.
15688 2004-11-30 Raja R Harinath <rharinath@novell.com>
15690 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15691 the current directory to help debugging.
15693 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15695 * class (GetClassBases): Better error 60 report.
15696 (EventProperty): Disabled warning 67 detection.
15698 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15701 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15703 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15706 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15709 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15711 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15713 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15715 * attribute.cs (Attribute.Resolve): Refine error reporting and
15716 report a cs0117 if the identifier does not exist, to distinguish
15717 from 0617 which is a miss-use of the actual identifier.
15719 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15720 between cs0070 and cs0079.
15722 * class.cs (MemberBase.DoDefine): When reporting a wrong
15723 accessibility level, we use MethodCore to compare instead of
15724 Method (this was a regression in some refactoring effort).
15726 So now we correctly report cs0056 again.
15728 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
15729 testing the target_type (which was known to be object_type) and
15730 not the source type (which is anonymous_method).
15732 Fixed reporting of error cs1660.
15734 * expression.cs (UserCast.Source): Expose the underlying cast.
15736 * statement.cs (Switch.SwitchGoverningType): Sort the list of
15737 allowed types to find a match to int32 first (most common).
15739 In addition, it ignores any ImplicitUserConversions that did an
15740 internal implicit conversion (as the switch statement allows only
15741 one integral conversion to exist).
15743 * class.cs (PartialContainer.Create): rename `name' to
15744 `member_name' for clarity. Then replace the string calls with a
15745 call to MemberName.GetPartialName, as now using
15746 MemberName.ToString is an error (this is due to the side effects
15747 it had, that were fixed in the past).
15749 This will restore the error reporting on a number of partial class
15750 errors that were missusing this (and getting an exception as a
15751 results, which is now just a plain textual warning, because
15752 yyparse debug output would crash otherwise).
15754 2004-11-26 Raja R Harinath <rharinath@novell.com>
15756 * Makefile (PROGRAM_INSTALL_DIR): Remove.
15758 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15760 * rootcontext.cs (LookupType): Make sure to cache lookups that
15761 don't give us a negative result. This saves about 5% of corlib
15764 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15766 * report.cs (AbstractMessage.Print): messages are sent to stderr
15768 * class.cs (TypeContainer.GetClassBases): It is an error to have a
15769 non-interface in the list of interfaces (at this point, either
15770 parent was properly set, or a base class is being listed in the
15771 interfaces section).
15773 This flags error 1722, and resolves the crash from bug 69259.
15775 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15777 * statement.cs (Using.EmitExpressionFinally): make this work right
15778 for valuetypes. Fixes 69926.
15780 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15782 * const.cs (Const.ChangeType): Cope with the "0 literal can be
15783 converted to an enum" here, before we try to change the underlying
15784 type. This code exists, but it is a different code path than the
15785 one used while encoding constants.
15787 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
15788 old bug: when converting from the null literal to a pointer,
15789 return an EmptyCast, not the NullLiteral.
15791 This fixes #69921, the recent null_type changes probably made this
15792 bug more prominent.
15794 (ImplicitReferenceConversionExists): In addition, resynchronized
15795 the code here, so it matches the same code in
15796 ImplicitReferenceConversionExists for the `from any class-type S
15797 to any interface-type T'.
15800 2004-11-25 Marek Safar <marek.safar@seznam.cz>
15802 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
15804 2004-11-24 Miguel de Icaza <miguel@ximian.com>
15806 * cs-parser.jay: Use verbosity accordingly.
15808 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15810 * expression.cs (Unary.ResolveOperator): Do not report warning;
15811 AddressOf reads from variable.
15813 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
15815 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15819 * attribute.cs (Attributable): Removed CheckTargets.
15820 (Attributes.Emit): Explicit attribute targets are tested here.
15822 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
15823 not enabled for interfaces.
15825 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
15826 (GetAssemblyName): Ouch next bug there.
15828 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15830 * expression.cs: Error 275 added.
15832 2004-11-23 Marek Safar <marek.safar@seznam.cz>
15834 Fix bug #69177 (Implemented decimal constant support)
15836 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
15837 (BinaryFold): Add DecimalConstant.
15839 * const.cs (Define): Decimal constant
15841 (ChangeType): Add decimal type handling.
15842 (LookupConstantValue): Don't set value for decimal type but
15843 emit DecimalConstantAttribute. Needed for constant optimization.
15845 * constant.cs (ToDecimal): New method.
15846 (ConvertToDecimal): New method.
15847 (IntConstant): Implemented ConvertToDecimal.
15848 (DecimalConstant.Emit): Emit optimized version for decimals in
15851 * expression.cs (ResolveOperator): Changed order of constant
15852 reduction to work correctly with native types which have
15853 overloaded operators.
15854 (ResolveMemberAccess): Extract constant value from attribute
15857 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
15859 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
15860 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
15861 (ChangeType): Decimal is special.
15862 (TypeToCoreType): Add decimal type.
15864 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15866 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
15869 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15871 * class.cs (EventField.ApplyAttributeBuilder): Fix error
15874 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15876 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
15878 * pending.cs (PendingImplementation): Grab only interfaces.
15880 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15882 * statement.cs (ForeachHelperMethods): Add location member and
15883 error 202 detection.
15885 2004-11-19 Raja R Harinath <rharinath@novell.com>
15887 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
15888 automatically handled by executable.make.
15889 (PROGRAM): Make profile-specific.
15891 2004-11-18 Marek Safar <marek.safar@seznam.cz>
15893 * expression.cs (DoResolveBase): Fixed wrong warning for out
15896 2004-11-18 Martin Baulig <martin@ximian.com>
15898 Merged latest changes into gmcs. Please keep this comment in
15899 here, it makes it easier for me to see what changed in MCS since
15900 the last time I merged.
15902 2004-11-17 Raja R Harinath <rharinath@novell.com>
15904 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
15905 (TypeHandle.GetMemberCache): New.
15906 (TypeHandle.TypeHandle): Update.
15907 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
15908 (TypeManager.LookupParentInterfacesCache):
15909 Rename from LookupInterfaceCache. Optimize slightly.
15910 (TypeManager.MemberLookup_FindMembers): Update.
15911 * decl.cs (MemberCache.MemberCache): Set Container to null in the
15912 multi-type variant.
15913 (AddCacheContents): Rename from AddHashtable.
15914 * class.cs (TypeContainer.parent_container): Remove.
15915 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
15916 (TypeContainer.DoDefineMembers): Don't initialize it.
15917 Update to name changes.
15919 2004-11-17 Miguel de Icaza <miguel@ximian.com>
15921 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
15922 that factors the code to check access modifiers on override.
15924 (PropertyBase): Use the code here.
15926 Patch from Lluis S'anchez, fixes bug #69361.
15928 2004-11-15 Miguel de Icaza <miguel@ximian.com>
15930 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
15931 routine that is used to report the use of a captured variable
15932 whose address has been taken.
15934 There are two checks: one when variables are being captured and
15935 the other check is when the address of a variable is taken.
15937 (because an anonymous methods might be resolved before *or* after
15938 the address has been taken) and
15940 * expression.cs (Conditional.DoResolve): Remove the special
15941 casing that Martin added to trueExpr and falseExpr being both
15942 NullLiteral. We get the right behavior now just by introducing
15943 the null_type into the compiler.
15945 * convert.cs (ExplicitConversion): Change the code to use
15946 null_type instead of testing `expr is NullLiteral'.
15947 (ImplicitConversionStandard): use null_type too.
15948 (ImplicitReferenceConversionExists): use null_type too.
15949 (ImplicitReferenceConversion): use null_type too.
15951 * literal.cs: The type of `NullLiteral' is now null_type instead
15953 (Resolve): Set the type here.
15955 * typemanager.cs: Introduce null_type.
15957 2004-11-17 Martin Baulig <martin@ximian.com>
15959 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
15960 direction, like FindMembers() does. Fixes #69546, testcase is in
15963 2004-11-16 Martin Baulig <martin@ximian.com>
15965 This is based on a patch from Marek Safar, see bug #69082.
15966 Fixes bugs #63705 and #67130.
15968 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
15969 method; create a MemberCache for an interface type and cache the
15972 * decl.cs (IMemberContainer.ParentContainer): Removed.
15973 (IMemberContainer.ParentCache): New property.
15974 (MemberCache.SetupCacheForInterface): Removed.
15975 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
15976 to create a cache for an interface's "parent".
15978 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
15981 2004-11-16 Martin Baulig <martin@ximian.com>
15983 Merged back from gmcs; these changes already went into gmcs a
15984 couple of weeks ago.
15987 (TypeManager.AddUserType): Removed the `ifaces' argument.
15988 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
15990 (TypeManager.AddUserInterface): Removed.
15991 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
15993 (TypeManager.GetInterfaces): Likewise.
15994 (TypeManager.GetExplicitInterfaces): Likewise.
15996 * ecore.cs (TypeExpr.GetInterfaces): Removed.
15998 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
15999 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16001 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16003 * statement.cs: Avoid adding bools to a hashtable.
16005 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16007 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16008 calling an unsafe method from a safe location.
16010 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16013 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16015 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16017 * namespace.cs (VerifyUsing): use GetPartialName instead of
16020 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16022 * statement.cs (Return.Resolve): Fix regression in typo: if
16023 `in_exc', we have to request a NeedReturnLabel, this was a typo
16024 introduced in the anonymous method check-in. Fixes #69131.
16026 * Indexers were using the ShortName when defining themselves,
16027 causing a regression in the compiler bootstrap when applying the
16028 patch from 2004-11-02 (first part), now they use their full name
16029 and the bug is gone.
16031 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16033 * driver.cs: Strip the path from the names of embedded resources. Fixes
16036 2004-11-04 Raja R Harinath <rharinath@novell.com>
16038 Fix error message regression: cs0104-2.cs.
16039 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16040 (AliasEntry.Resolve): Update.
16041 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16043 (RootContext.LookupType): Update.
16045 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16047 * cs-parser.jay: Add support for handling accessor modifiers
16048 * class: Add support port accessor modifiers and error checking,
16049 define PropertyMethod.Define as virtual (not abstract anymore)
16050 * ecore.cs: Add checking for proeprties access with access modifiers
16051 * iterators.cs: Modify Accessor constructor call based in the modified
16053 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16055 * expression.cs (StringConcat): Handle being called twice,
16056 as when we have a concat in a field init with more than two
16059 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16061 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16062 special case explicit implementations, we should always produce
16063 the .property or .event declaration.
16065 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16066 since it will not return correct data if people use this
16067 unresolved in the presence of using statements (see test-313).
16069 * class.cs (MethodData.Define): If we are an explicit interface
16070 implementation, set the method name to the full name of the
16071 interface plus the name of the method.
16073 Notice that using the method.MethodName.GetFullName() does not
16074 work, as it will only contain the name as declared on the source
16075 file (it can be a shorthand in the presence of using statements)
16076 and not the fully qualifed type name, for example:
16080 class D : ICloneable {
16081 object ICloneable.Clone () {
16085 Would produce a method called `ICloneable.Clone' instead of
16086 `System.ICloneable.Clone'.
16088 * namespace.cs (Alias.Resolve): Use GetPartialName.
16090 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16092 * cs-parser.jay: Add error 1055 report.
16094 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16096 * assign.cs (Assign.DoResolve): Only do the transform of
16097 assignment into a New if the types are compatible, if not, fall
16098 through and let the implicit code deal with the errors and with
16099 the necessary conversions.
16101 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16103 * cs-parser.jay: Add error 1031 report.
16105 * cs-tokenizer.cs: Add location for error 1038.
16107 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16109 * cs-parser.jay: Add error 1016 report.
16111 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16113 * cs-parser.jay: Add errors 1575,1611 report.
16115 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16117 * cs-parser.jay: Add error 1001 report.
16119 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16122 * attribute.cs (GetMarshal): Add method argument for
16123 caller identification.
16125 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16126 agument for GetMarshal and RuntimeMissingSupport.
16128 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16130 * attribute.cs (ExtractSecurityPermissionSet): Removed
16131 TypeManager.code_access_permission_type.
16133 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16135 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16137 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16138 for obsolete use of a variable here. Fixes regression on errors
16139 cs0619-25 and cs0619-26.
16141 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16143 Fix #62358, implemented security attribute encoding.
16145 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16146 Tests permitted SecurityAction for assembly or other types.
16147 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16148 data from SecurityPermissionAttribute to PermisionSet class.
16150 * class.cs (ApplyAttributeBuilder): Added special handling
16151 for System.Security.Permissions.SecurityAttribute based types.
16153 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16154 special handling for System.Security.Permissions.SecurityAttribute
16157 * enum.cs (ApplyAttributeBuilder): Added special handling
16158 for System.Security.Permissions.SecurityAttribute based types.
16160 * parameter.cs (ApplyAttributeBuilder): Added special handling
16161 for System.Security.Permissions.SecurityAttribute based types.
16163 * rootcontext.cs: Next 2 core types.
16165 * typemanager.cs (TypeManager.security_permission_attr_type):
16166 Built in type for the SecurityPermission Attribute.
16167 (code_access_permission_type): Build in type.
16169 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16171 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16172 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16173 all of this information into
16174 EmitContext.EmitCapturedVariableInstance.
16176 * codegen.cs (EmitCapturedVariableInstance): move here the
16177 funcionality of emitting an ldarg.0 in the presence of a
16178 remapping. This centralizes the instance emit code.
16180 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16181 then emit a load of this: it means that we have reached the
16182 topmost ScopeInfo: the one that contains the pointer to the
16183 instance of the class hosting the anonymous method.
16185 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16186 captures to the topmost CaptureContext.
16188 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16190 * expression.cs (LocalVariableReference): Move the knowledge about
16191 the iterators into codegen's EmitCapturedVariableInstance.
16193 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16195 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16196 all code paths return a value from an anonymous method (it is the
16197 same as the 161 error, but for anonymous methods).
16199 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16201 The introduction of anonymous methods in the compiler changed
16202 various ways of doing things in the compiler. The most
16203 significant one is the hard split between the resolution phase
16204 and the emission phases of the compiler.
16206 For instance, routines that referenced local variables no
16207 longer can safely create temporary variables during the
16208 resolution phase: they must do so from the emission phase,
16209 since the variable might have been "captured", hence access to
16210 it can not be done with the local-variable operations from the runtime.
16214 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16215 is a toplevel block.
16217 (ToplevelBlock): A new kind of Block, these are the blocks that
16218 are created by the parser for all toplevel method bodies. These
16219 include methods, accessors and anonymous methods.
16221 These contain some extra information not found in regular blocks:
16222 A pointer to an optional CaptureContext (for tracking captured
16223 local variables and parameters). A pointer to the parent
16226 (Return.Resolve): Catch missmatches when returning a value from an
16227 anonymous method (error 1662).
16228 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16231 (Break.Resolve): ditto.
16233 (SwitchLabel): instead of defining the labels during the
16234 resolution phase, we now turned the public ILLabel and ILLabelCode
16235 labels into methods called GetILLabelCode() and GetILLabel() that
16236 only define the label during the Emit phase.
16238 (GotoCase): Track the SwitchLabel instead of the computed label
16239 (its contained therein). Emit the code by using
16240 SwitchLabel.GetILLabelCode ().
16242 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16243 whether the Local has been captured or not.
16245 (LocalInfo.IsCaptured): New property, used to tell whether the
16246 local has been captured.
16248 * anonymous.cs: Vastly updated to contain the anonymous method
16251 The main classes here are: CaptureContext which tracks any
16252 captured information for a toplevel block and ScopeInfo used to
16253 track the activation frames for various local variables.
16255 Each toplevel block has an optional capture context associated
16256 with it. When a method contains an anonymous method both the
16257 toplevel method and the anonymous method will create a capture
16258 context. When variables or parameters are captured, they are
16259 recorded on the CaptureContext that owns them, for example:
16263 MyDelegate d = delegate {
16268 Here `a' will be recorded as captured on the toplevel
16269 CapturedContext, the inner captured context will not have anything
16270 (it will only have data if local variables or parameters from it
16271 are captured in a nested anonymous method.
16273 The ScopeInfo is used to track the activation frames for local
16274 variables, for example:
16276 for (int i = 0; i < 10; i++)
16277 for (int j = 0; j < 10; j++){
16278 MyDelegate d = delegate {
16283 At runtime this captures a single captured variable `i', but it
16284 captures 10 different versions of the variable `j'. The variable
16285 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16286 recorded on a child.
16288 The toplevel ScopeInfo will also track information like the `this'
16289 pointer if instance variables were referenced (this is necessary
16290 as the anonymous method lives inside a nested class in the host
16291 type of the method).
16293 (AnonymousMethod): Expanded to track the Toplevel, implement
16294 `AnonymousMethod.Compatible' to tell whether an anonymous method
16295 can be converted to a target delegate type.
16297 The routine now also produces the anonymous method content
16299 (AnonymousDelegate): A helper class that derives from
16300 DelegateCreation, this is used to generate the code necessary to
16301 produce the delegate for the anonymous method that was created.
16303 * assign.cs: API adjustments for new changes in
16304 Convert.ImplicitStandardConversionExists.
16306 * class.cs: Adjustments to cope with the fact that now toplevel
16307 blocks are of type `ToplevelBlock'.
16309 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16310 insteda of standard blocks.
16312 Flag errors if params arguments are passed to anonymous methods.
16314 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16315 `CurrentAnonymousMethod' which points to the current Anonymous
16316 Method. The variable points to the AnonymousMethod class that
16317 holds the code being compiled. It is set in the new EmitContext
16318 created for the anonymous method.
16320 (EmitContext.Phase): Introduce a variable and an enumeration to
16321 assist in enforcing some rules about when and where we are allowed
16322 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16323 only one that enfonces this right now).
16325 (EmitContext.HaveCaptureInfo): new helper method that returns
16326 whether we have a CapturedContext initialized.
16328 (EmitContext.CaptureVariable): New method used to register that a
16329 LocalInfo must be flagged for capturing.
16331 (EmitContext.CapturedParameter): New method used to register that a
16332 parameters must be flagged for capturing.
16334 (EmitContext.CapturedField): New method used to register that a
16335 field must be flagged for capturing.
16337 (EmitContext.HaveCapturedVariables,
16338 EmitContext.HaveCapturedFields): Return whether there are captured
16339 variables or fields.
16341 (EmitContext.EmitMethodHostInstance): This is used to emit the
16342 instance for the anonymous method. The instance might be null
16343 (static methods), this (for anonymous methods that capture nothing
16344 and happen to live side-by-side with the current method body) or a
16345 more complicated expression if the method has a CaptureContext.
16347 (EmitContext.EmitTopBlock): Routine that drives the emission of
16348 code: it will first resolve the top block, then emit any metadata
16349 and then emit the code. The split is done so that we can extract
16350 any anonymous methods and flag any captured variables/parameters.
16352 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16353 during this phase, the ILGenerator should not be used as labels
16354 and local variables declared here might not be accessible to any
16355 code that is part of an anonymous method.
16357 Exceptions to this include the temporary variables that are
16358 created by some statements internally for holding temporary
16361 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16364 (EmitContext.TemporaryReturn): This method is typically called
16365 from the Emit phase, and its the only place where we allow the
16366 ReturnLabel to be defined other than the EmitMeta. The reason is
16367 that otherwise we would have to duplicate a lot of logic in the
16368 Resolve phases of various methods that today is on the Emit
16371 (EmitContext.NeedReturnLabel): This no longer creates the label,
16372 as the ILGenerator is not valid during the resolve phase.
16374 (EmitContext.EmitThis): Extended the knowledge in this class to
16375 work in anonymous methods in addition to iterators.
16377 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16378 code is necessary on the stack to access the instance to a local
16379 variable (the variable will be accessed as a field).
16381 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16382 EmitContext.EmitAddressOfParameter): Routines to support
16383 parameters (not completed at this point).
16385 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16386 will also remove the parameters.
16388 * convert.cs (Convert): Define a `ConstantEC' which points to a
16389 null. This is just to prefity some code that uses
16390 ImplicitStandardConversion code and do not have an EmitContext
16393 The idea is to flag explicitly that at that point in time, it is
16394 known that the conversion will not trigger the delegate checking
16395 code in implicit conversions (which requires a valid
16398 Everywhere: pass new EmitContext parameter since
16399 ImplicitStandardConversionExists now requires it to check for
16400 anonymous method conversions.
16402 (Convert.ImplicitStandardConversionExists): If the type of an
16403 expression is the anonymous_method_type, and the type is a
16404 delegate, we invoke the AnonymousMethod.Compatible method to check
16405 whether an implicit conversion is possible.
16407 (Convert.ImplicitConversionStandard): Only do implicit method
16408 group conversions if the language level is not ISO_1.
16410 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16411 MethodInfo for the Invoke method. used by Delegate and
16414 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16415 method conversions if the target type is a delegate.
16417 Removed extra debugging nops.
16419 (LocalVariableReference): Turn the `local_info' into a public
16422 Add `prepared' field, the same hack used for FieldExprs to cope
16423 with composed assignments, as Local variables do not necessarily
16424 operate purely on the stack as they used to: they can be captured
16427 Add `temp' for a temporary result, like fields.
16429 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16431 It now copes with Local variables that are captured and emits the
16432 proper instance variable to load it from a field in the captured
16435 (ParameterReference.DoResolveBase): During the resolve phase,
16436 capture parameters if we are in an anonymous method.
16438 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16439 anonymous method, use the EmitContext helper routines to emit the
16440 parameter reference.
16442 * iterators.cs: Set RemapToProxy to true/false during the
16445 * parameters.cs (GetParameterByName): New helper method.
16447 * typemanager.cs (anonymous_method_type) a new type that
16448 represents an anonyous method. This is always an internal type,
16449 used as a fencepost to test against the anonymous-methodness of an
16452 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16454 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16456 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16458 2004-10-18 Martin Baulig <martin@ximian.com>
16460 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16461 `Type' directly, but call ResolveType() on it.
16462 (Catch.Resolve): Likewise.
16463 (Foreach.Resolve): Likewise.
16465 2004-10-18 Martin Baulig <martin@ximian.com>
16467 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16468 `Type' directly, but call ResolveType() on it.
16469 (Probe.DoResolve): Likewise.
16470 (ArrayCreation.LookupType): Likewise.
16471 (TypeOf.DoResolve): Likewise.
16472 (SizeOf.DoResolve): Likewise.
16474 2004-10-18 Martin Baulig <martin@ximian.com>
16476 * expression.cs (Invocation.BetterFunction): Put back
16477 TypeManager.TypeToCoreType().
16479 2004-10-18 Raja R Harinath <rharinath@novell.com>
16481 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16484 2004-10-18 Martin Baulig <martin@ximian.com>
16486 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16487 `Type' directly, but call ResolveType() on it.
16489 2004-10-18 Martin Baulig <martin@ximian.com>
16491 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16492 `Type' directly, but call ResolveType() on it.
16493 (MemberBase.DoDefine): Likewise.
16495 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16496 `Type' directly, but call ResolveType() on it.
16497 (ComposedCast.DoResolveAsTypeStep): Likewise.
16499 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16500 `Type' directly, but call ResolveType() on it.
16502 2004-10-17 John Luke <john.luke@gmail.com>
16504 * class.cs (Operator.GetSignatureForError): use CSharpName
16506 * parameter.cs (Parameter.GetSignatureForError): Returns
16507 correct name even if was not defined.
16509 2004-10-13 Raja R Harinath <rharinath@novell.com>
16512 * class.cs (TypeContainer.EmitContext): New property.
16513 (DefineNestedTypes): Create an emitcontext for each part.
16514 (MethodCore.DoDefineParameters): Use container's emitcontext.
16515 Pass type array to InternalParameters.
16516 (MemberBase.DoDefine): Use container's emitcontext.
16517 (FieldMember.Define): Likewise.
16518 (Event.Define): Likewise.
16519 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16520 Pass type array to InternalParameters.
16521 (SetIndexerMethod.GetParameterInfo): Likewise.
16522 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16523 * delegate.cs (Define): Pass emitcontext to
16524 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16525 array to InternalParameters.
16526 * expression.cs (ParameterReference.DoResolveBase): Pass
16527 emitcontext to GetParameterInfo.
16528 (ComposedCast.DoResolveAsTypeStep): Remove check on
16529 ec.ResolvingTypeTree.
16530 * parameter.cs (Parameter.Resolve): Change argument to
16531 EmitContext. Use ResolveAsTypeTerminal.
16532 (Parameter.GetSignature): Change argument to EmitContext.
16533 (Parameters.ComputeSignature): Likewise.
16534 (Parameters.ComputeParameterTypes): Likewise.
16535 (Parameters.GetParameterInfo): Likewise.
16536 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16537 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16538 * support.cs (InternalParameters..ctor): Remove variant that takes
16540 * typemanager.cs (system_intptr_expr): New.
16541 (InitExpressionTypes): Initialize it.
16543 2004-10-12 Chris Toshok <toshok@ximian.com>
16545 * cs-parser.jay: fix location for try_statement and catch_clause.
16547 2004-10-11 Martin Baulig <martin@ximian.com>
16549 * report.cs: Don't make --fatal abort on warnings, we have
16550 -warnaserror for that.
16552 2004-10-07 Raja R Harinath <rharinath@novell.com>
16554 More DeclSpace.ResolveType avoidance.
16555 * decl.cs (MemberCore.InUnsafe): New property.
16556 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16557 with newly created EmitContext.
16558 (FieldMember.Define): Likewise.
16559 * delegate.cs (Delegate.Define): Likewise.
16560 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16561 only if normal name-lookup fails.
16562 (TypeExpr.DoResolve): Enable error-checking.
16563 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16564 (SizeOf.DoResolve): Likewise.
16565 (ComposedCast.DoResolveAsTypeStep): Likewise.
16566 (StackAlloc.DoResolve): Likewise.
16567 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16568 (Block.Unsafe): New property.
16569 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16570 (Unsafe): Set 'unsafe' flag of contained block.
16571 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16572 (Fixed.Resolve): Likewise.
16573 (Catch.Resolve): Likewise.
16574 (Using.ResolveLocalVariableDecls): Likewise.
16575 (Foreach.Resolve): Likewise.
16577 2004-10-05 John Luke <john.luke@gmail.com>
16579 * cs-parser.jay: add location to error CS0175
16581 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16583 * ecore.cs (Expression.Constantity): Add support for turning null
16586 * const.cs (Const.Define): Allow constants to be reference types
16587 as long as the value is Null.
16589 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16591 * namespace.cs (NamespaceEntry.Using): No matter which warning
16592 level is set, check if this namespace name has already been added.
16594 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16596 * expression.cs: reftype [!=]= null should always use br[true,false].
16599 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16602 * attribute.cs: Enum conversion moved to
16603 GetAttributeArgumentExpression to be applied to the all
16606 2004-10-01 Raja R Harinath <rharinath@novell.com>
16608 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16609 * class.c (TypeContainer.DefineType): Flag error if
16610 base types aren't accessible due to access permissions.
16611 * decl.cs (DeclSpace.ResolveType): Move logic to
16612 Expression.ResolveAsTypeTerminal.
16613 (DeclSpace.ResolveTypeExpr): Thin layer over
16614 Expression.ResolveAsTypeTerminal.
16615 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16616 Refactor code into NestedAccess. Use it.
16617 (DeclSpace.NestedAccess): New.
16618 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16619 argument to silence errors. Check access permissions.
16620 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16621 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16622 (Cast.DoResolve): Likewise.
16623 (New.DoResolve): Likewise.
16624 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16625 (TypeOf.DoResolve): Likewise.
16627 * expression.cs (Invocation.BetterConversion): Return the Type of
16628 the better conversion. Implement section 14.4.2.3 more faithfully.
16629 (Invocation.BetterFunction): Make boolean. Make correspondence to
16630 section 14.4.2.2 explicit.
16631 (Invocation.OverloadResolve): Update.
16632 (Invocation): Remove is_base field.
16633 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16634 (Invocation.Emit): Likewise.
16636 2004-09-27 Raja R Harinath <rharinath@novell.com>
16638 * README: Update to changes.
16640 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16642 * cs-parser.jay: Reverted 642 warning fix.
16644 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16647 * decl.cs (FindMemberWithSameName): Indexer can have more than
16650 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16652 * expression.cs (LocalVariableReference.DoResolveLValue):
16653 Do not report warning 219 for out values.
16654 (EmptyExpression.Null): New member to avoid extra allocations.
16656 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16658 * cs-parser.jay: Fix wrong warning 642 report.
16660 * cs-tokenizer.cs (CheckNextToken): New helper;
16661 Inspect next character if is same as expected.
16663 2004-09-23 Martin Baulig <martin@ximian.com>
16665 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16666 (Convert.ImplicitReferenceConversionExists): Likewise.
16668 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16670 * class.cs (Operator.Define): Add error 448 and 559 report.
16672 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16674 * class.cs (MemberBase.IsTypePermitted): New protected
16675 method for checking error CS0610.
16677 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16679 * class.cs (TypeContainer.HasExplicitLayout): New property
16680 Returns whether container has StructLayout attribute set Explicit.
16681 (FieldMember): New abstract class for consts and fields.
16682 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16683 (Field): Reuse FieldMember.
16685 * const.cs (Const): Reuse FieldMember.
16687 * rootcontext.cs: EmitConstants call moved to class.
16689 2004-09-22 Martin Baulig <martin@ximian.com>
16691 Thanks to Peter Sestoft for this bug report.
16693 * expression.cs (Conditional): If both the `trueExpr' and the
16694 `falseExpr' is a NullLiteral, return a NullLiteral.
16696 2004-09-22 Martin Baulig <martin@ximian.com>
16698 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16699 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16700 for the "get_Current" call.
16702 2004-09-22 Martin Baulig <martin@ximian.com>
16704 Marek and me just fixed one of our oldest bugs: #28562 :-)
16706 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16708 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16709 we're an EnumConstant, just return that.
16710 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16711 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16712 to get the value which'll actually be written into the attribute.
16713 However, we have to use GetValue() to access the attribute's value
16716 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16718 * constant.cs (Constant.IsNegative): New abstract property
16721 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16722 (StackAlloc.DoResolve): Reused IsNegative.
16724 2004-09-21 Martin Baulig <martin@ximian.com>
16726 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
16727 if we're used in an iterator, we may be called from different
16730 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
16731 we actually have an exception block.
16733 2004-09-20 John Luke <jluke@cfl.rr.com>
16735 * class.cs, cs-parser.jay: Improve the error report for 1520:
16736 report the actual line where the error happens, not where the
16737 class was declared.
16739 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
16740 Pass location information that was available elsewhere.
16742 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
16744 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
16745 runtime to delay sign assemblies.
16747 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16749 * cs-parser.jay: Do not report the stack trace, this is barely
16752 2004-08-22 John Luke <john.luke@gmail.com>
16754 * driver.cs : check that a resource id is not already used
16755 before adding it, report CS1508 if it is, bug #63637
16757 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16759 * ecore.cs: Removed dead code.
16761 2004-09-18 Marek Safar <marek.safar@seznam.cz>
16763 * class.cs: Do not report warning CS0067 on the interfaces.
16765 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16767 * cs-parser.jay: Add error 504 report.
16769 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16771 * rootcontext.cs: WarningLevel is 4 by default now.
16773 * statement.cs (Fixed.Resolve): Do not null
16776 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16779 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
16780 deep search when property is not virtual.
16781 (PropertyExpr.ResolveAccessors): Make one call for both
16784 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16787 * statement.cs: Error 152 report constains also location.
16789 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16792 * const.cs: Explicitly set constant as static.
16794 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16797 * cs-parser.jay: Add error 1017 report.
16799 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16801 Fixed bug #59980, #64224
16802 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
16804 * typemanager.cs (IsSpecialMethod): Simplified
16806 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16808 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
16809 condition with better params.
16811 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16814 * attribute.cs (Resolve): Property has to have both
16817 2004-09-14 Martin Baulig <martin@ximian.com>
16819 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
16821 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16824 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
16825 called and is obsolete then this member suppress message
16826 when call is inside next [Obsolete] method or type.
16828 * expression.cs: Use TestObsoleteMethodUsage member.
16830 2004-09-14 Martin Baulig <martin@ximian.com>
16832 * cs-parser.jay: Sync a bit with the GMCS version.
16834 2004-09-14 Martin Baulig <martin@ximian.com>
16836 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
16837 (CSharpParser.yacc_verbose_flag): New public field.
16839 * genericparser.cs: Removed.
16841 2004-09-14 Raja R Harinath <rharinath@novell.com>
16843 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
16845 2004-09-13 Marek Safar <marek.safar@seznam.cz>
16847 * class.cs (MethodCore.CheckBase): Fix bug #65757.
16849 2004-09-10 Martin Baulig <martin@ximian.com>
16851 Backported my MemberName changes from GMCS into MCS.
16853 - we are now using a special `MemberName' class instead of using
16854 strings; in GMCS, the `MemberName' also contains the type
16857 - changed the grammar rules a bit:
16858 * the old `member_name' is now a `namespace_or_type_name':
16859 The rule is that we use `namespace_or_type_name' everywhere
16860 where we expect either a "member name" (GetEnumerator) or a
16861 "member name" with an explicit interface name
16862 (IEnumerable.GetEnumerator).
16863 In GMCS, the explicit interface name may include type arguments
16864 (IEnumerable<T>.GetEnumerator).
16865 * we use `member_name' instead of just `IDENTIFIER' for
16867 The rule is that we use `member_name' wherever a member may
16868 have type parameters in GMCS.
16870 * decl.cs (MemberName): New public class.
16871 (MemberCore.MemberName): New public readonly field.
16872 (MemberCore.ctor): Take a `MemberName' argument, not a string.
16873 (DeclSpace): Likewise.
16875 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
16876 * enum.cs (Enum.ctor): Likewise.
16878 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
16880 (AliasEntry.ctor): Take a MemberName, not an Expression.
16881 (AliasEntry.UsingAlias): Likewise.
16883 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
16884 (IMethodData.MemberName): Changed type from string to MemberName.
16885 (MemberBase.ExplicitInterfaceName): Likewise.
16886 (AbstractPropertyEventMethod.SetupName): Make this private.
16887 (AbstractPropertyEventMethod.ctor): Added `string prefix'
16888 argument; compute the member name here.
16889 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
16890 on the `member.MemberName' and the `prefix'.
16892 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
16894 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
16895 thus, we get a `MemberName' instead of a `string'. These
16896 declarations may have type parameters in GMCS.
16897 (interface_method_declaration, delegate_declaration): Likewise.
16898 (class_declaration, interface_declaration): Likewise.
16899 (method_header): Use `namespace_or_type_name' instead of
16900 `member_name'. We may be an explicit interface implementation.
16901 (property_declaration, event_declaration): Likewise.
16902 (member_name): This is now just an `IDENTIFIER', not a
16903 `namespace_or_type_name'.
16904 (type_name, interface_type): Removed.
16905 (namespace_or_type_name): Return a MemberName, not an Expression.
16906 (primary_expression): Use `member_name' instead of `IDENTIFIER';
16907 call GetTypeExpression() on the MemberName to get an expression.
16908 (IndexerDeclaration.interface_type): Changed type from string to
16910 (MakeName): Operate on MemberName's instead of string's.
16912 2004-09-13 Raja R Harinath <rharinath@novell.com>
16915 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
16916 (NamespaceEntry.Lookup): Add new argument to flag if we want the
16917 lookup to avoid symbols introduced by 'using'.
16918 * rootcontext.cs (NamespaceLookup): Update.
16920 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16922 * class.cs (TypeContainer.DoDefineMembers): Do not call
16923 DefineDefaultConstructor for static classes.
16925 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16927 * attribute.cs (Attribute.Resolve): Add error 653 report.
16929 * class.cs (Class.ApplyAttributeBuilder): Add error 641
16931 (Method.ApplyAttributeBuilder): Add error 685 report.
16932 (Operator.Define): Add error 564 report.
16934 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
16936 * expression.cs (Invocation.DoResolve): Add error
16937 245 and 250 report.
16939 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
16942 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16944 * class.cs (ConstructorInitializer.Resolve):
16945 Wrong error number (515->516).
16947 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16949 * class.cs (Indexer.Define): Add error 631 report.
16951 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16953 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
16955 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16957 * expression.cs (Probe.DoResolve): Add error CS0241 report.
16959 2004-09-10 Marek Safar <marek.safar@seznam.cz>
16961 * cs-parser.jay: Added error CS0241 report.
16963 2004-09-10 Raja R Harinath <rharinath@novell.com>
16965 * cs-parser.jay (fixed_statement): Introduce a scope for the
16966 declaration in the 'fixed' statement.
16968 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16970 * cs-parser.jay: Added CS0230 error report.
16972 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16974 * cs-parser.jay: Added errors CS0231 and CS0257 report.
16976 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16978 * expression.cs (Argument.Resolve): Added error CS0192 and
16981 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16983 C# 2.0 #pragma warning feature
16985 * cs-tokenizer.cs (PreProcessPragma): New method;
16986 Handles #pragma directive.
16988 * report.cs (WarningRegions): New class; Support
16989 class for #pragma warning directive. It tests whether
16990 warning is enabled for a given line.
16992 2004-09-08 Miguel de Icaza <miguel@ximian.com>
16994 * const.cs: Add more descriptive error report, tahnks to
16997 2004-09-08 Marek Safar <marek.safar@seznam.cz>
16999 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17001 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17003 * expression.cs: Apply patch from Ben: Remove dead code from
17004 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17005 as that code just threw an exception anwyays.
17007 * const.cs: Remove the call to the turnintoconstant, for details
17010 * literal.cs: The type of the null-literal is the null type; So
17011 we use a placeholder type (literal.cs:System.Null, defined here)
17014 * expression.cs (Conditional.DoResolve): Remove some old code that
17015 is no longer needed, conversions have been fixed.
17017 (ArrayCreationExpression.DoResolve): Return false if we fail to
17018 resolve the inner expression.
17020 2004-09-07 Raja R Harinath <rharinath@novell.com>
17023 * cs-parser.jay (delegate_declaration): Record a delegate
17024 declaration as a type declaration.
17025 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17027 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17029 * parameter.cs: Do not crash if the type can not be resolved.
17031 * expression.cs: Report errors with unsafe pointers, fixes #64896
17033 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17035 * expression.cs: Pointer arith always needs to do a conv.i
17036 if the operand is a long. fix 65320
17038 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17040 Fixed cs0619-37.cs, cs0619-38.cs
17042 * enum.cs (GetObsoleteAttribute): Removed.
17044 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17045 on Enum member is double staged. The first is tested member
17048 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17050 Fixed #56986, #63631, #65231
17052 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17053 adds member to name container.
17054 (TypeContainer.AddToTypeContainer): New method, adds type to
17056 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17057 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17058 AddOperator): Simplified by reusing AddToMemberContainer.
17059 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17061 (Method.CheckForDuplications): Fixed implementation to test all
17063 (MemberBase): Detection whether member is explicit interface
17064 implementation is now in constructor.
17065 (MemberBase.UpdateMemberName): Handles IndexerName.
17066 (Accessor): Changed to keep also location information.
17067 (AbstractPropertyEventMethod): Is derived from MemberCore.
17068 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17069 will be emited or not.
17070 (PropertyBase.AreAccessorsDuplicateImplementation):
17071 Tests whether accessors are not in collision with some method.
17072 (Operator): Is derived from MethodCore to simplify common
17075 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17077 (DeclSpace.AddToContainer): Adds the member to defined_names
17078 table. It tests for duplications and enclosing name conflicts.
17080 * enum.cs (EnumMember): Clean up to reuse the base structures
17082 2004-09-03 Martin Baulig <martin@ximian.com>
17084 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17085 into TypeContainer, to make partial classes work again.
17087 2004-09-03 Martin Baulig <martin@ximian.com>
17089 * rootcontext.cs (RootContext.V2): Removed.
17091 2004-03-23 Martin Baulig <martin@ximian.com>
17093 * expression.cs (Invocation.OverloadResolve): Added `bool
17094 may_fail' argument and use it instead of the Location.IsNull() hack.
17096 2004-09-03 Martin Baulig <martin@ximian.com>
17098 Merged latest changes into gmcs. Please keep this comment in
17099 here, it makes it easier for me to see what changed in MCS since
17100 the last time I merged.
17102 2004-09-03 Raja R Harinath <rharinath@novell.com>
17105 * expression.cs (BetterConversion): Don't allow either conversion
17106 to be null. Remove redundant implicit conversion test when 'q ==
17107 null' -- when this function is invoked, we already know that the
17108 implicit conversion exists.
17109 (BetterFunction): Assume that 'best' is non-null. Remove
17110 redundant reimplementation of IsApplicable when 'best' is null.
17111 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17112 number of arguments.
17113 (IsAncestralType): Extract from OverloadResolve.
17114 (OverloadResolve): Make robust to the MethodGroupExpr being
17115 unsorted. Implement all the logic of Section 14.5.5.1, and
17116 support overloading of methods from multiple applicable types.
17117 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17119 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17120 (RealError, Warning): Append type of report to related symbol.
17122 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17124 * enum.cs: Fixed CLS-Compliance checks for enum members.
17125 Error tests cs3008-8.cs, cs3014-8.cs
17127 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17129 Fixed bug #62342, #63102
17130 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17131 like ImplementMethod.
17133 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17135 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17138 2004-09-02 Martin Baulig <martin@ximian.com>
17140 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17141 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17144 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17146 C# 2.0 Static classes implemented
17148 * class.cs (TypeContainer): instance_constructors,
17149 initialized_fields, initialized_static_fields,
17150 default_constructor, base_inteface_types are protected to be
17151 accessible from StaticClass.
17152 (TypeContainer.DefineDefaultConstructor): New virtual method
17153 for custom default constructor generating
17154 (StaticClass): New class to handle "Static classes" feature.
17156 * cs-parser.jay: Handle static keyword on class like instance
17159 * driver.cs: Added "/langversion" command line switch with two
17160 options (iso-1, default).
17162 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17164 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17166 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17168 * delegate.cs: Style.
17170 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17172 * delegate.cs: Add seperate instance expr field for miguel.
17174 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17176 * PointerArithmetic (Resolve): make sure we are not doing
17177 pointer arith on void*. Also, make sure we are resolved
17178 by not setting eclass until resolve.
17180 All callers: Make sure that PointerArithmetic gets resolved.
17182 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17184 * ArrayCreation (LookupType): If the type does not resolve
17185 to an array, give an error.
17187 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17189 * statement.cs (Try.Resolve): Fixed bug #64222
17191 2004-08-27 Martin Baulig <martin@ximian.com>
17194 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17197 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17199 * ecore.cs (Constantify): Get underlying type via
17200 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17201 Windows in special cases.
17203 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17205 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17206 for obtaining also private methods.
17207 (GetRemoveMethod): Used GetRemoveMethod (true)
17208 for obtaining also private methods.
17210 2004-08-24 Martin Baulig <martin@ximian.com>
17212 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17213 MethodAttributes.HideBySig for operators.
17215 2004-08-23 Martin Baulig <martin@ximian.com>
17217 Back to the old error reporting system :-)
17219 * report.cs (Message): Removed.
17220 (Report.MessageData, ErrorData, WarningData): Removed.
17221 (Report.Error, Warning): Back to the old system.
17223 2004-08-23 Martin Baulig <martin@ximian.com>
17225 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17227 * class.cs (TypeContainer.ParentContainer): New public virtual
17228 method; replaces the explicit interface implementation.
17229 (ClassPart.ParentContainer): Override.
17231 2004-08-23 Martin Baulig <martin@ximian.com>
17233 * statement.cs (Switch): Added support for constant switches; see
17234 #59428 or test-285.cs.
17236 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17239 * statement.cs (GetEnumeratorFilter): Removed useless
17240 logic because C# specs is strict. GetEnumerator must be
17243 2004-08-22 Martin Baulig <martin@ximian.com>
17245 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17246 a switch and may break, reset the barrier. Fixes #59867.
17248 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17250 CLS-Compliance speed up (~5% for corlib)
17252 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17253 New method. Tests container for CLS-Compliant names
17255 * class.cs (TypeContainer.VerifyClsName): New method.
17256 Checks whether container name is CLS Compliant.
17257 (Constructor): Implements IMethodData.
17259 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17260 low-case table for CLS Compliance test.
17261 (MemberCache.VerifyClsParameterConflict): New method.
17262 Checks method parameters for CS3006 error.
17264 * enum.cs (EnumMember): Is derived from MemberCore.
17265 (Enum.VerifyClsName): Optimized for better performance.
17267 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17269 * report.cs: Renamed Error_T to Error and changed all
17272 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17274 * class.cs (TypeContainer.IndexerArrayList): New inner class
17275 container for indexers.
17276 (TypeContainer.DefaultIndexerName): New constant for default
17277 indexer name. Replaced all "Item" with this constant.
17278 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17280 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17281 DefaultMemberAttribute constructor.
17283 2004-08-05 Martin Baulig <martin@ximian.com>
17285 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17288 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17290 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17291 multi platforms problem.
17293 * compiler.csproj: Included shared files.
17295 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17297 Fix bug 60333, 55971 in the more general way
17298 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17299 Added arg_type argument for constant conversion.
17300 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17302 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17305 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17306 OperatorArrayList, MethodCoreArrayList for typecontainer
17307 containers. Changed class member types to these new types.
17308 (MethodArrayList.DefineMembers): Added test for CS0659.
17310 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17312 * cfold.cs: Synchronize the folding with the code in expression.cs
17313 Binary.DoNumericPromotions for uint operands.
17315 * attribute.cs: Revert patch from Raja, it introduced a regression
17316 while building Blam-1.2.1 (hard to isolate a test case).
17318 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17322 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17324 (MethodCore.parent_method): New member. The method we're overriding
17325 if this is an override method.
17326 (MethodCore.CheckBase): Moved from Method class and made common.
17327 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17329 (MethodCore.CheckForDuplications): New abstract method. For custom
17330 member duplication search in a container
17331 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17332 method and its return type.
17333 (Event.conflict_symbol): New member. Symbol with same name in the
17337 (MemberCache.FindMemberWithSameName): New method. The method
17338 is looking for conflict with inherited symbols.
17340 2004-08-04 Martin Baulig <martin@ximian.com>
17342 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17344 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17346 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17348 * report.cs (Message): New enum for better error, warning reference in
17350 (MessageData): New inner abstract class. It generally handles printing of
17351 error and warning messages.
17352 Removed unused Error, Warning, Message methods.
17354 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17356 Fix for cs0592-8.cs test
17358 (Attributable.ValidAttributeTargets): Made public.
17359 (Attribute.ExplicitTarget): New member for explicit target value.
17360 (Attribute.CheckTargets): Now we translate explicit attribute
17361 target to Target here.
17363 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17365 * ecore.cs (MethodGroupExpr): new IsBase property.
17367 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17369 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17370 rather than an instance expr.
17372 (DelegateCreation.Emit): Use the method group rather than
17373 the instance expression. Also, if you have base.Foo as the
17374 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17376 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17378 (NewDelegate.DoResolve): Only check for the existance of Invoke
17379 if the method is going to be needed. Use MethodGroupExpr.
17381 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17383 * expression.cs: For pointer arith., make sure to use
17384 the size of the type, not the size of the pointer to
17387 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17390 * class.cs (Class): Added error CS0502 test.
17392 2004-08-03 John Luke <jluke@cfl.rr.com>
17393 Raja R Harinath <rharinath@novell.com>
17396 * attribute.cs (Attribute.complained_before): New flag.
17397 (Attribute.ResolveType, Attribute.Resolve),
17398 (Attribute.DefinePInvokeMethod): Set it.
17399 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17401 2004-08-03 Martin Baulig <martin@ximian.com>
17403 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17404 use a user-defined operator; we still need to do numeric
17405 promotions in case one argument is a builtin type and the other
17406 one has an implicit conversion to that type. Fixes #62322.
17408 2004-08-02 Martin Baulig <martin@ximian.com>
17410 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17411 (LocalInfo.IsThis): New public property.
17412 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17414 2004-08-01 Martin Baulig <martin@ximian.com>
17416 * class.cs (TypeContainer.GetClassBases): Don't set the default
17417 here since we may get called from GetPartialBases().
17418 (TypeContainer.DefineType): If GetClassBases() didn't return a
17419 parent, use the default one.
17421 2004-07-30 Duncan Mak <duncan@ximian.com>
17423 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17425 2004-07-30 Martin Baulig <martin@ximian.com>
17427 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17429 * class.cs (SourceMethod): New public class, derive from the
17430 symbol writer's ISourceMethod.
17431 (Method): Use the new symbol writer API.
17433 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17434 as argument and use the new symbol writer.
17437 (SourceFile): Implement the symbol writer's ISourceFile.
17438 (Location.SymbolDocument): Removed.
17439 (Location.SourceFile): New public property.
17441 * symbolwriter.cs: Use the new symbol writer API.
17443 2004-07-30 Raja R Harinath <rharinath@novell.com>
17445 * Makefile (install-local): Remove. Functionality moved to
17448 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17450 * Makefile: Install mcs.exe.config file together with mcs.exe.
17451 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17452 correct runtime version.
17454 2004-07-25 Martin Baulig <martin@ximian.com>
17457 (TypeContainer.RegisterOrder): Removed, this was unused.
17458 (TypeContainer, interface_order): Removed.
17459 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17460 TypeContainer as argument since we can also be called with a
17461 `PartialContainer' for a partial class/struct/interface.
17462 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17463 of checking whether we're an `Interface' - we could be a
17464 `PartialContainer'.
17465 (PartialContainer.Register): Override; call
17466 AddClass()/AddStruct()/AddInterface() on our parent.
17468 * cs-parser.jay (interface_member_declaration): Add things to the
17469 `current_container', not the `current_class'.
17471 * rootcontext.cs (RegisterOrder): The overloaded version which
17472 takes an `Interface' was unused, removed.
17474 * typemanager.cs (TypeManager.LookupInterface): Return a
17475 `TypeContainer', not an `Interface'.
17476 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17477 contain a `PartialContainer' for an interface, so check it's
17478 `Kind' to figure out what it is.
17480 2004-07-25 Martin Baulig <martin@ximian.com>
17482 * class.cs (Class.DefaultTypeAttributes): New public constant.
17483 (Struct.DefaultTypeAttributes): Likewise.
17484 (Interface.DefaultTypeAttributes): Likewise.
17485 (PartialContainer.TypeAttr): Override this and add the
17486 DefaultTypeAttributes.
17488 2004-07-25 Martin Baulig <martin@ximian.com>
17490 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17491 we can just use the `Parent' field instead.
17493 2004-07-25 Martin Baulig <martin@ximian.com>
17495 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17497 2004-07-25 Martin Baulig <martin@ximian.com>
17499 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17500 our parts before defining any methods.
17501 (TypeContainer.VerifyImplements): Make this virtual.
17502 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17503 on our PartialContainer.
17505 2004-07-25 Martin Baulig <martin@ximian.com>
17507 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17509 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17510 argument, we can just use the `Parent' field instead.
17513 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17514 (MemberBase.DoDefine): Likewise.
17516 2004-07-24 Martin Baulig <martin@ximian.com>
17518 * decl.cs (MemberCore.Parent): New public field.
17519 (DeclSpace.Parent): Moved to MemberCore.
17521 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17522 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17524 (FieldBase, Field, Operator): Likewise.
17525 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17526 (EventField, Event): Likewise.
17528 2004-07-23 Martin Baulig <martin@ximian.com>
17530 * class.cs (PartialContainer): New public class.
17531 (ClassPart): New public class.
17532 (TypeContainer): Added support for partial classes.
17533 (TypeContainer.GetClassBases): Splitted some of the functionality
17534 out into GetNormalBases() and GetPartialBases().
17536 * cs-tokenizer.cs (Token.PARTIAL): New token.
17537 (Tokenizer.consume_identifier): Added some hacks to recognize
17538 `partial', but only if it's immediately followed by `class',
17539 `struct' or `interface'.
17541 * cs-parser.jay: Added support for partial clases.
17543 2004-07-23 Martin Baulig <martin@ximian.com>
17545 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17546 a `DeclSpace' and also made it readonly.
17547 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17548 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17549 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17551 * cs-parser.jay: Pass the `current_class', not the
17552 `current_container' (at the moment, this is still the same thing)
17553 to a new Method, Property, Event, Indexer or Constructor.
17555 2004-07-23 Martin Baulig <martin@ximian.com>
17557 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17558 and removed the `current_interface' one.
17559 (struct_declaration, class_declaration, interface_declaration):
17560 Set `current_class' to the newly created class/struct/interface;
17561 set their `Bases' and call Register() before parsing their body.
17563 2004-07-23 Martin Baulig <martin@ximian.com>
17565 * class.cs (Kind): New public enum.
17566 (TypeContainer): Made this class abstract.
17567 (TypeContainer.Kind): New public readonly field.
17568 (TypeContainer.CheckDef): New public method; moved here from
17570 (TypeContainer.Register): New public abstract method.
17571 (TypeContainer.GetPendingImplementations): New public abstract
17573 (TypeContainer.GetClassBases): Removed the `is_class' and
17574 `is_iface' parameters.
17575 (TypeContainer.DefineNestedTypes): Formerly known as
17577 (ClassOrStruct): Made this class abstract.
17579 * tree.cs (RootTypes): New public type.
17581 2004-07-20 Martin Baulig <martin@ximian.com>
17583 * tree.cs (Tree.RecordNamespace): Removed.
17584 (Tree.Namespaces): Removed.
17586 * rootcontext.cs (RootContext.IsNamespace): Removed.
17588 * cs-parser.jay (namespace_declaration): Just create a new
17589 NamespaceEntry here.
17591 2004-07-20 Martin Baulig <martin@ximian.com>
17593 * statement.cs (ExceptionStatement): New abstract class. This is
17594 now used as a base class for everyone who's using `finally'.
17595 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17596 our local variables before using them.
17598 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17599 virtual method. This is used by Yield.Resolve() to "steal" an
17600 outer block's `finally' clauses.
17601 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17604 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17605 version which takes an ExceptionStatement. This version must be
17606 used to create exception branchings.
17609 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17610 (Iterator.EmitMoveNext): Added exception support; protect the
17611 block with a `fault' clause, properly handle 'finally' clauses.
17612 (Iterator.EmitDispose): Run all the `finally' clauses here.
17614 2004-07-20 Martin Baulig <martin@ximian.com>
17616 * iterator.cs: This is the first of a set of changes in the
17617 iterator code. Match the spec more closely: if we're an
17618 IEnumerable, then GetEnumerator() must be called. The first time
17619 GetEnumerator() is called, it returns the current instance; all
17620 subsequent invocations (if any) must create a copy.
17622 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17624 * expression.cs: Resolve the constant expression before returning
17627 2004-07-19 Martin Baulig <martin@ximian.com>
17629 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17630 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17631 the return type of the new EmitContext.
17633 2004-07-18 Martin Baulig <martin@ximian.com>
17635 * class.cs (Property.Define): Fix iterators.
17637 * iterators.cs (Iterator.Define): Moved the
17638 `container.AddInterator (this)' call here from the .ctor; only do
17639 it if we resolved successfully.
17641 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17643 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17644 `true' for preprocessing directives that we parse. The return
17645 value indicates whether we should return to regular tokenizing or
17646 not, not whether it was parsed successfully.
17648 In the past if we were in: #if false ... #line #endif, we would
17649 resume parsing after `#line'. See bug 61604.
17651 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17652 building: IsEnumType should return true only for enums, not for
17653 enums or System.Enum itself. This fixes #61593.
17655 Likely what happened is that corlib was wrong: mcs depended on
17656 this bug in some places. The bug got fixed, we had to add the
17657 hack, which caused bug 61593.
17659 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17660 that was a workaround for the older conditions.
17662 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17664 * assign.cs: IAssignMethod has a new interface, as documented
17665 inline. All assignment code now uses this new api.
17667 * ecore.cs, expression.cs: All classes which implement
17668 IAssignMethod now use the new interface.
17670 * expression.cs (Invocation): add a hack to EmitCall so that
17671 IndexerAccess can be the target of a compound assignment without
17672 evaluating its arguments twice.
17674 * statement.cs: Handle changes in Invocation api.
17676 2004-07-16 Martin Baulig <martin@ximian.com>
17678 * iterators.cs: Rewrote this. We're now using one single Proxy
17679 class for both the IEnumerable and the IEnumerator interface and
17680 `Iterator' derives from Class so we can use the high-level API.
17682 * class.cs (TypeContainer.AddIterator): New method.
17683 (TypeContainer.DoDefineType): New protected virtual method, which
17684 is called from DefineType().
17685 (TypeContainer.DoDefineMembers): Call DefineType() and
17686 DefineMembers() on all our iterators.
17687 (TypeContainer.Emit): Call Emit() on all our iterators.
17688 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17690 * codegen.cs (EmitContext.CurrentIterator): New public field.
17692 2004-07-15 Martin Baulig <martin@ximian.com>
17695 (TypeManager.not_supported_exception_type): New type.
17697 2004-07-14 Martin Baulig <martin@ximian.com>
17699 * iterators.cs: Use real error numbers.
17701 2004-07-14 Martin Baulig <martin@ximian.com>
17703 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17704 requires this to be a System.Collection.IEnumerable and not a
17705 class implementing that interface.
17706 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17708 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17710 * class.cs: Fixed previous fix, it broke some error tests.
17712 2004-07-12 Martin Baulig <martin@ximian.com>
17714 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17717 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17719 * assign.cs (LocalTemporary): Add new argument: is_address,If
17720 `is_address' is true, then the value that we store is the address
17721 to the real value, and not the value itself.
17723 * ecore.cs (PropertyExpr): use the new local temporary
17724 stuff to allow us to handle X.Y += z (where X is a struct)
17726 2004-07-08 Martin Baulig <martin@ximian.com>
17728 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
17729 not always return, just like we're doing in Using.Resolve().
17731 2004-07-07 Miguel de Icaza <miguel@ximian.com>
17733 * cs-parser.jay (fixed_statement): flag this as Pinned.
17735 2004-07-06 Miguel de Icaza <miguel@ximian.com>
17737 * typemanager.cs (TypeManager): Removed MakePinned method, this
17738 mechanism is replaced with the .NET 2.x compatible mechanism of
17739 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
17741 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
17742 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
17743 `IsFixed' property which has a different meaning.
17745 2004-07-02 Raja R Harinath <rharinath@novell.com>
17747 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
17748 visible from inside a nested class, not just the names of the
17749 immediately enclosing class.
17750 Fix for bug #60730.
17752 2004-06-24 Raja R Harinath <rharinath@novell.com>
17754 * expression.cs (BetterConversion): Remove buggy special-case
17755 handling of "implicit constant expression conversions". At this
17756 point, we already know that the conversion is possible -- we're
17757 only checking to see which is better.
17759 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17761 * cs-parser.jay: Added error CS0210 test.
17763 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17765 * cs-parser.jay: Added error CS0134 test.
17767 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17770 * cs-parser.jay: Added error CS0145 test.
17772 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17774 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
17776 2004-06-23 Ben Maurer <bmaurer@ximian.com>
17778 * expression.cs (StackAlloc.Resolve): The argument may not
17779 be a constant; deal with this case.
17781 2004-06-23 Marek Safar <marek.safar@seznam.cz>
17783 * attribute.cs (IndexerName_GetIndexerName): Renamed to
17784 GetIndexerAttributeValue.
17785 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
17787 * class.cs (Indexer.Define): Added error tests for CS0415,
17790 2004-06-23 Miguel de Icaza <miguel@ximian.com>
17792 * attribute.cs (Attribute.Resolve): Keep field code in sync with
17795 2004-06-23 Martin Baulig <martin@ximian.com>
17797 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
17798 neither return nor throw, reset the barrier as well. Fixes #60457.
17800 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
17802 * class.cs : EventAttributes is now set to None by default.
17803 This fixes bug #60459.
17805 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17808 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17809 Don't throw exception but return null (it's sufficient now).
17811 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17813 * typemanager.cs (GetArgumentTypes): Faster implementation.
17815 2004-06-18 Martin Baulig <martin@ximian.com>
17817 * attribute.cs (Attribute.Resolve): Check whether we're an
17818 EmptyCast which a Constant child. Fixes #60333.
17820 2004-06-17 Ben Maurer <bmaurer@ximian.com>
17822 * statement.cs (EmitCollectionForeach): Account for the fact that
17823 not all valuetypes are in areas which we can take the address of.
17824 For these variables, we store to a temporary variable. Also, make
17825 sure that we dont emit a `callvirt' on a valuetype method.
17827 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17829 * expression.cs (StackAlloc.DoReSolve): Added test for
17830 negative parameter (CS0247).
17832 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17835 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
17837 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17840 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
17843 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17845 Fix bug #58254 & cs1555.cs, cs1556.cs
17846 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
17848 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17850 * cs-parser.jay: Added error CS1669 test for indexers.
17852 2004-06-11 Martin Baulig <martin@ximian.com>
17854 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
17855 call this twice: for params and varargs methods.
17857 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17860 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
17862 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17864 * attribute.cs (Attribute.GetValidTargets): Made public.
17867 (AbstractPropertyEventMethod): New class for better code sharing.
17868 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
17870 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
17872 2004-06-11 Raja R Harinath <rharinath@novell.com>
17875 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
17876 that the call to Resolve is part of a MemberAccess.
17877 (Expression.Resolve): Use it for SimpleName resolution.
17878 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
17879 Add 'intermediate' boolean argument.
17880 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
17881 error message when the SimpleName can be resolved ambiguously
17882 between an expression and a type.
17883 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
17885 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
17886 call on the left-side.
17888 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17891 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
17893 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17895 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
17897 2004-06-11 Martin Baulig <martin@ximian.com>
17899 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
17900 varargs methods if applicable.
17902 2004-06-11 Martin Baulig <martin@ximian.com>
17904 * expression.cs (Invocation.EmitCall): Don't use
17905 `method.CallingConvention == CallingConventions.VarArgs' since the
17906 method could also have `CallingConventions.HasThis'.
17908 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17910 * class.cs (Event.GetSignatureForError): Implemented.
17911 Fixed crash in error test cs3010.cs
17913 2004-06-10 Miguel de Icaza <miguel@ximian.com>
17915 * cs-tokenizer.cs: Change the way we track __arglist to be
17916 consistent with the other keywords.
17918 2004-06-09 Miguel de Icaza <miguel@ximian.com>
17920 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
17923 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
17925 * codegen.cs: Check that all referenced assemblies have a strongname
17926 before strongnaming the compiled assembly. If not report error CS1577.
17927 Fix bug #56563. Patch by Jackson Harper.
17928 * typemanager.cs: Added a method to return all referenced assemblies.
17929 Fix bug #56563. Patch by Jackson Harper.
17931 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17934 (Method.ApplyAttributeBuilder): Moved and added conditional
17935 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
17938 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
17940 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17943 * class.cs: (EventField.attribute_targets): Changed default target.
17945 2004-06-08 Martin Baulig <martin@ximian.com>
17947 * expression.cs (Invocation.EmitCall): Enable varargs methods.
17949 2004-06-08 Martin Baulig <martin@ximian.com>
17951 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
17953 2004-06-07 Martin Baulig <martin@ximian.com>
17955 Added support for varargs methods.
17957 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
17960 * cs-parser.jay: Added support for `__arglist'.
17962 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
17964 * expression.cs (Argument.AType): Added `ArgList'.
17965 (Invocation): Added support for varargs methods.
17966 (ArglistAccess): New public class.
17967 (Arglist): New public class.
17969 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
17971 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
17972 a method's top-level block if the method has varargs.
17974 * support.cs (ReflectionParameters, InternalParameters): Added
17975 support for varargs methods.
17977 2004-06-07 Miguel de Icaza <miguel@ximian.com>
17979 * class.cs: Provide location in indexer error report.
17981 * driver.cs: Use standard names.
17983 * namespace.cs: Catch the use of using after a namespace has been
17984 declared also on using aliases.
17986 2004-06-03 Raja R Harinath <rharinath@novell.com>
17989 * typemanager.cs (closure_private_ok, closure_invocation_type)
17990 (closure_qualifier_type, closure_invocation_assembly)
17991 (FilterWithClosure): Move to ...
17992 (Closure): New internal nested class.
17993 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
17994 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
17995 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
17996 (MemberLookup, MemberLookupFailed): Use it.
17997 * expression.cs (New.DoResolve): Treat the lookup for the
17998 constructor as being qualified by the 'new'ed type.
17999 (Indexers.GetIndexersForTypeOrInterface): Update.
18001 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18004 (GetConditionalAttributeValue): New method. Returns
18005 condition of ConditionalAttribute.
18006 (SearchMulti): New method. Returns all attributes of type 't'.
18007 Use it when attribute is AllowMultiple = true.
18008 (IsConditionalMethodExcluded): New method.
18011 (Method.IsExcluded): Implemented. Returns true if method has conditional
18012 attribute and the conditions is not defined (method is excluded).
18013 (IMethodData): Extended interface for ConditionalAttribute support.
18014 (PropertyMethod.IsExcluded): Implemented.
18017 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18020 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18023 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18025 * expression.cs (ArrayCreationExpression): Make this just an
18026 `expression'. It can't be a statement, so the code here was
18029 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18032 * typemanager.cs (GetFullNameSignature): New method for
18035 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18038 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18039 Use this method when MethodBuilder is null.
18040 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18041 Added test for error CS0626 (MONO reports error for this situation).
18042 (IMethodData.GetSignatureForError): Extended interface.
18044 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18047 (AttributeTester.GetObsoleteAttribute): Returns instance of
18048 ObsoleteAttribute when type is obsolete.
18051 (TypeContainer.VerifyObsoleteAttribute): Override.
18052 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18053 (MethodCode.VerifyObsoleteAttribute): Override.
18054 (MemberBase.VerifyObsoleteAttribute): Override.
18057 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18058 and report proper error.
18061 Delegate.VerifyObsoleteAttribute): Override.
18064 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18065 and report proper error.
18066 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18069 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18073 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18074 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18075 Added test for ObsoleteAttribute.
18078 (Catch): Derived from Statement.
18080 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18082 Fixed bug #59071 & cs0160.cs
18084 * statement.cs (Try.Resolve): Check here whether order of catch
18085 clauses matches their dependencies.
18087 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18089 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18090 caused a regression: #59343. Referencing nested classes from an
18091 assembly stopped working.
18093 2004-05-31 Martin Baulig <martin@ximian.com>
18095 MCS is now frozen for beta 2.
18097 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18099 * convert.cs: add a trivial cache for overload operator resolution.
18101 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18103 * decl.cs: If possible, use lookuptypedirect here. We can only do
18104 this if there is no `.' after the namespace. Avoids using
18105 LookupType, which does lots of slow processing.
18106 (FindNestedType) New method, does what it says :-).
18107 * namespace.cs: use LookupTypeDirect.
18108 * rootcontext.cs: use membercache, if possible.
18109 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18111 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18114 According to the spec,
18116 In a member access of the form E.I, if E is a single identifier,
18117 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18118 field, property, localvariable, or parameter with the same type as
18119 the meaning of E as a type-name (§3.8), then both possible
18120 meanings of E are permitted.
18122 We did not check that E as a simple-name had the same type as E as
18125 This trivial check gives us 5-7% on bootstrap time.
18127 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18129 * expression.cs (Invocation.OverloadResolve): Avoid the
18130 use of hashtables and boxing here by allocating on demand.
18132 2004-05-30 Martin Baulig <martin@ximian.com>
18134 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18135 we're doing a silent lookup. Don't try to lookup nested types in
18136 TypeManager.object_type (thanks to Ben Maurer).
18138 2004-05-30 Martin Baulig <martin@ximian.com>
18140 Committing a patch from Ben Maurer.
18142 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18144 2004-05-29 Martin Baulig <martin@ximian.com>
18146 * class.cs (IMethodData.ShouldIgnore): New method.
18148 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18149 `Location' argument, we don't need it anywhere. Use
18150 `IMethodData.ShouldIgnore ()' instead of
18151 `MethodData.GetMethodFlags ()'.
18152 (TypeManager.AddMethod): Removed.
18153 (TypeManager.AddMethod2): Renamed to AddMethod.
18155 2004-05-29 Martin Baulig <martin@ximian.com>
18157 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18159 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18160 converting from a class type S to an interface type and we already
18161 have an object on the stack, don't box it again. Fixes #52578.
18163 2004-05-29 Martin Baulig <martin@ximian.com>
18165 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18166 Added support for `params' parameters. Fixes #59267.
18168 2004-05-29 Martin Baulig <martin@ximian.com>
18170 * literal.cs (NullPointer): Provide a private .ctor which sets
18171 `type' to TypeManager.object_type. Fixes #59048.
18173 2004-05-29 Martin Baulig <martin@ximian.com>
18175 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18176 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18178 * ecore.cs (EventExpr.instance_expr): Make the field private.
18180 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18182 Fixed bug #50080 & cs0214-2.cs
18183 * expression.cs (Cast.DoResolve): Check unsafe context here.
18185 * statement.cs (Resolve.DoResolve): Likewise.
18187 2004-05-26 Martin Baulig <martin@ximian.com>
18189 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18191 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18192 (RootContext.LookupType): Pass down the `silent' flag.
18194 2004-05-25 Martin Baulig <martin@ximian.com>
18197 (MethodGroupExpr.IdenticalTypeName): New public property.
18198 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18199 expression actually refers to a type.
18201 2004-05-25 Martin Baulig <martin@ximian.com>
18203 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18204 for #56176 and made it actually work.
18206 2004-05-25 Martin Baulig <martin@ximian.com>
18208 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18209 (FieldExpr, PropertyExpr): Override and implement
18210 CacheTemporaries. Fixes #52279.
18212 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18214 * location.cs: In the new compiler listing a file twice is a
18215 warning, not an error.
18217 2004-05-24 Martin Baulig <martin@ximian.com>
18219 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18220 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18222 2004-05-24 Martin Baulig <martin@ximian.com>
18224 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18225 walking the `using' list. Fixes #53921.
18227 2004-05-24 Martin Baulig <martin@ximian.com>
18229 * const.cs (Const.LookupConstantValue): Added support for
18230 EmptyCast's; fixes #55251.
18232 2004-05-24 Martin Baulig <martin@ximian.com>
18234 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18235 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18236 which does the CS0135 check. The reason is that we first need to
18237 check whether the variable actually exists.
18239 2004-05-24 Martin Baulig <martin@ximian.com>
18241 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18242 than RootContext.LookupType() to find the explicit interface
18243 type. Fixes #58584.
18245 2004-05-24 Raja R Harinath <rharinath@novell.com>
18247 * Makefile: Simplify. Use executable.make.
18248 * mcs.exe.sources: New file. List of sources of mcs.exe.
18250 2004-05-24 Anders Carlsson <andersca@gnome.org>
18254 Use the invariant culture when doing String.Compare for CLS case
18257 2004-05-23 Martin Baulig <martin@ximian.com>
18259 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18260 don't have any dots. Fixes #52622, added cs0246-8.cs.
18262 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18264 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18266 * class.cs (MemberBase.Define): Reuse MemberType member for
18267 resolved type. Other methods can use it too.
18269 2004-05-23 Martin Baulig <martin@ximian.com>
18271 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18272 the variable also exists in the current block (otherwise, we need
18273 to report a CS0103). Fixes #58670.
18275 2004-05-23 Martin Baulig <martin@ximian.com>
18277 * flowanalysis.cs (Reachability.Reachable): Compute this
18278 on-the-fly rather than storing it as a field.
18280 2004-05-23 Martin Baulig <martin@ximian.com>
18282 * flowanalysis.cs (Reachability.And): Manually compute the
18283 resulting `barrier' from the reachability.
18285 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18288 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18289 instance of ObsoleteAttribute when symbol is obsolete.
18292 (IMethodData): Extended interface for ObsoleteAttribute support.
18294 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18296 * attribute.cs: Fix bug #55970
18298 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18302 (GetObsoleteAttribute): New method. Creates the instance of
18304 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18305 ObsoleteAttribute when member is obsolete.
18306 (AttributeTester.Report_ObsoleteMessage): Common method for
18307 Obsolete error/warning reporting.
18310 (TypeContainer.base_classs_type): New member for storing parent type.
18313 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18314 for this MemberCore.
18316 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18318 * attribute.cs, const.cs: Fix bug #58590
18320 2004-05-21 Martin Baulig <martin@ximian.com>
18322 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18323 out parameters if the end of the method is unreachable. Fixes
18326 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18328 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18329 Hari was right, why extra method.
18331 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18333 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18335 2004-05-20 Martin Baulig <martin@ximian.com>
18337 Merged this back from gmcs to keep the differences to a minumum.
18339 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18340 instead of a Declspace.
18341 (Attribute.ResolveType): Likewise.
18342 (Attributes.Search): Likewise.
18343 (Attributes.Contains): Likewise.
18344 (Attributes.GetClsCompliantAttribute): Likewise.
18346 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18348 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18351 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18353 Fix bug #58688 (MCS does not report error when the same attribute
18356 * attribute.cs (Attribute.Emit): Distinction between null and default.
18358 2004-05-19 Raja R Harinath <rharinath@novell.com>
18360 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18361 of a top-level attribute without an attribute target.
18362 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18364 (Attribute.Conditional_GetConditionName),
18365 (Attribute.Obsolete_GetObsoleteMessage): Update.
18366 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18367 part of ScanForIndexerName.
18368 (Attribute.CanIgnoreInvalidAttribute): New function.
18369 (Attribute.ScanForIndexerName): Move to ...
18370 (Attributes.ScanForIndexerName): ... here.
18371 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18372 (Attributes.Search): New internal variant that can choose not to
18373 complain if types aren't resolved. The original signature now
18375 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18376 complaints suppressed.
18377 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18378 only if it not useful.
18379 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18380 top-level for attributes that are shared between the assembly
18381 and a top-level class.
18382 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18383 * class.cs: Update to reflect changes.
18384 (DefineIndexers): Fuse loops.
18385 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18386 a couple more variants of attribute names.
18388 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18390 Fix bug #52585 (Implemented explicit attribute declaration)
18393 (Attributable.ValidAttributeTargets): New abstract method. It gets
18394 list of valid attribute targets for explicit target declaration.
18395 (Attribute.Target): It holds target itself.
18396 (AttributeSection): Removed.
18397 (Attribute.CheckTargets): New method. It checks whether attribute
18398 target is valid for the current element.
18401 (EventProperty): New class. For events that are declared like
18402 property (with add and remove accessors).
18403 (EventField): New class. For events that are declared like field.
18406 * cs-parser.jay: Implemented explicit attribute target declaration.
18408 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18409 Override ValidAttributeTargets.
18412 (ReturnParameter): Class for applying custom attributes on
18414 (ParameterAtribute): New class. Class for applying custom
18415 attributes on the parameter type.
18417 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18419 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18422 (Method): Allow UNSAFE here.
18424 * modifiers.cs: Support unsafe reporting.
18426 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18428 * decl.cs: Fix bug #58478.
18430 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18432 * statement.cs: When checking for unreachable code on an EmptyStatement,
18433 set the location. Fixes bug #58488.
18435 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18437 * driver.cs: Add -pkg handling.
18439 From Gonzalo: UseShelLExecute=false
18441 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18444 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18446 (Attribute.IsClsCompliaceRequired): Moved to base for better
18448 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18449 when attribute is AttributeUsageAttribute.
18450 (Attribute.GetValidTargets): Simplified.
18451 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18452 attribute for this type.
18453 (Attribute.ApplyAttributes): Method renamed to Emit and make
18455 (GlobalAttributeSection): New class for special handling of global
18456 attributes (assembly, module).
18457 (AttributeSection.Emit): New method.
18459 * class.cs: Implemented Attributable abstract methods.
18460 (MethodCore.LabelParameters): Moved to Parameter class.
18461 (Accessor): Is back simple class.
18462 (PropertyMethod): Implemented Attributable abstract class.
18463 (DelegateMethod): Implemented Attributable abstract class.
18464 (Event): New constructor for disctintion between normal Event
18465 and Event with accessors.
18467 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18469 * codegen.cs, const.cs, decl.cs, delegate.cs:
18470 (CommonAssemblyModulClass): Implemented Attributable abstract class
18473 * enum.cs: Implement IAttributeSupport interface.
18474 (EnumMember): New class for emum members. Implemented Attributable
18478 (ParameterBase): Is abstract.
18479 (ReturnParameter): New class for easier [return:] attribute handling.
18481 * typemanager.cs: Removed builder_to_attr.
18483 2004-05-11 Raja R Harinath <rharinath@novell.com>
18486 * attribute.cs (Attribute.GetPositionalValue): New function.
18487 * class.cs (TypeContainer.VerifyMembers): New function.
18488 (TypeContainer.Emit): Use it.
18489 (ClassOrStruct): New base class for Class and Struct.
18490 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18491 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18493 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18494 then each non-static field should have a FieldOffset attribute.
18495 Otherwise, none of the fields should have a FieldOffset attribute.
18496 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18497 and FieldOffset attributes.
18498 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18499 (TypeManager.field_offset_attribute_type): New core types.
18500 (TypeManager.InitCoreTypes): Initialize them.
18502 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18504 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18505 Return correct type.
18508 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18510 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18511 be implicitly converted to ulong.
18513 * expression.cs: The logic for allowing operator &, | and ^ worked
18514 was wrong, it worked before because we did not report an error in
18515 an else branch. Fixes 57895.
18517 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18518 allow volatile fields to be reference types.
18520 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18522 * driver.cs: Add support for /debug-
18524 2004-05-07 Raja R Harinath <rharinath@novell.com>
18526 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18527 Add a 'complain' parameter to silence errors.
18528 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18529 silently overlooked type-resolutions.
18530 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18531 to reflect changes.
18532 (Attributes.Search): New function.
18533 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18534 (Attributes.GetAttributeFullName): Remove hack.
18535 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18536 Update to reflect changes.
18537 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18538 Use Attributes.Search instead of nested loops.
18540 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18543 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18544 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18545 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18547 * report.cs: (Report.Warning): Renamed to Warning_T because of
18548 parameter collision.
18550 2004-05-05 Raja R Harinath <rharinath@novell.com>
18552 * expression.cs (MemberAccess.ResolveMemberAccess):
18553 Exit with non-zero status after Report.Error.
18554 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18556 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18558 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18560 * support.cs: Don't hang when the file is empty.
18562 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18564 * support.cs: In SeekableStreamReader, compute the preamble size of the
18565 underlying stream. Position changes should take into account that initial
18568 2004-05-03 Todd Berman <tberman@sevenl.net>
18570 * driver.cs: remove unused GetSysVersion function.
18572 2004-05-03 Todd Berman <tberman@sevenl.net>
18574 * driver.cs: Remove the hack from saturday, as well as the hack
18575 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18576 link_paths to get that bit proper.
18578 2004-05-01 Todd Berman <tberman@sevenl.net>
18580 * driver.cs: Try a LoadFrom before a Load, this checks the current
18581 path. This is currently a bug in mono that is be fixed, however, this
18582 provides a workaround for now. This will be removed when the bug
18585 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18587 * CryptoConvert.cs: Updated to latest version. Fix issue with
18588 incomplete key pairs (#57941).
18590 2004-05-01 Todd Berman <tberman@sevenl.net>
18592 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18595 2004-04-30 Jackson Harper <jackson@ximian.com>
18597 * codegen.cs: Open keys readonly.
18599 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18601 * typemanager.cs: don't report cyclic struct layout when a struct
18602 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18603 which has 2 Pango.Rectangle fields.
18605 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18607 * expression.cs: Handle IntPtr comparisons with IL code
18608 rather than a method call.
18610 2004-04-29 Martin Baulig <martin@ximian.com>
18612 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18613 the list of PropertyInfo's in class hierarchy and find the
18614 accessor. Fixes #56013.
18616 2004-04-29 Martin Baulig <martin@ximian.com>
18618 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18620 2004-04-29 Martin Baulig <martin@ximian.com>
18622 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18624 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18626 2004-04-29 Martin Baulig <martin@ximian.com>
18628 * class.cs (ConstructorInitializer.Resolve): Check whether the
18629 parent .ctor is accessible. Fixes #52146.
18631 2004-04-29 Martin Baulig <martin@ximian.com>
18633 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18635 * statement.cs (Using.EmitLocalVariableDecls): Use
18636 TypeManager.idisposable_type, not typeof (IDisposable).
18637 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18639 2004-04-29 Martin Baulig <martin@ximian.com>
18641 * class.cs (Event.Define): Don't emit the field and don't set
18642 RTSpecialName and SpecialName for events on interfaces. Fixes
18645 2004-04-29 Raja R Harinath <rharinath@novell.com>
18647 Refactor Attribute.ApplyAttributes.
18648 * attribute.cs (Attributable): New base class for objects that can
18649 have Attributes applied on them.
18650 (Attribute): Make AttributeUsage fields public.
18651 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18652 (Attribute.IsInternalCall): New property.
18653 (Attribute.UsageAttr): Convert to a public read-only property.
18654 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18655 (Attribute.ResolveType, Attribute.Resolve)
18656 (Attribute.ScanForIndexerName): Update to reflect changes.
18657 (Attribute.CheckAttributeTarget): Re-format.
18658 (Attribute.ApplyAttributes): Refactor, to various
18659 Attributable.ApplyAttributeBuilder methods.
18660 * decl.cs (MemberCore): Make Attributable.
18661 * class.cs (Accessor): Make Attributable.
18662 (MethodData.ApplyAttributes): Use proper attribute types, not
18664 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18665 (TypeContainer.ApplyAttributeBuilder)
18666 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18667 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18668 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18669 (Operator.ApplyAttributeBuilder): New factored-out methods.
18670 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18671 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18672 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18673 * parameter.cs (ParameterBase): New Attributable base class
18674 that can also represent Return types.
18675 (Parameter): Update to the changes.
18677 2004-04-29 Jackson Harper <jackson@ximian.com>
18679 * driver.cs: Prefer the corlib system version when looking for
18680 assemblies in the GAC. This is still a hack, but its a better hack
18683 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18685 * decl.cs, enum.cs: Improved error 3005 reporting.
18687 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18688 (related_symbols): New private member for list of symbols
18689 related to reported error/warning.
18691 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18693 2004-04-29 Martin Baulig <martin@ximian.com>
18695 * ecore.cs (Expression.Constantify): If we're an enum and
18696 TypeManager.TypeToCoreType() doesn't give us another type, use
18697 t.UnderlyingSystemType. Fixes #56178.
18699 2004-04-29 Martin Baulig <martin@ximian.com>
18701 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18702 interfaces and for each interface, only add members directly
18703 declared in that interface. Fixes #53255.
18705 2004-04-28 Martin Baulig <martin@ximian.com>
18707 * expression.cs (ConditionalLogicalOperator): Use a temporary
18708 variable for `left' to avoid that we evaluate it more than once;
18711 2004-04-28 Martin Baulig <martin@ximian.com>
18713 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18716 2004-04-28 Martin Baulig <martin@ximian.com>
18718 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18721 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18722 whether the type is not void (CS1547).
18724 2004-04-28 Martin Baulig <martin@ximian.com>
18726 * expression.cs (Unary.DoResolveLValue): Override this and report
18727 CS0131 for anything but Operator.Indirection.
18729 2004-04-28 Martin Baulig <martin@ximian.com>
18731 Committing a patch from Ben Maurer; see bug #50820.
18733 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18736 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18739 2004-04-28 Martin Baulig <martin@ximian.com>
18741 Committing a patch from Ben Maurer; see bug #50820.
18743 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18746 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18749 2004-04-28 Martin Baulig <martin@ximian.com>
18751 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
18752 (Block.AddLabel): Call DoLookupLabel() to only search in the
18755 2004-04-28 Martin Baulig <martin@ximian.com>
18757 * cfold.cs (ConstantFold.BinaryFold): Added special support for
18758 comparing StringConstants and NullLiterals in Equality and Inequality.
18760 2004-04-28 Jackson Harper <jackson@ximian.com>
18762 * driver.cs: Attempt to load referenced assemblies from the
18763 GAC. This is the quick and dirty version of this method that
18764 doesnt take into account versions and just takes the first
18765 canidate found. Will be good enough for now as we will not have more
18766 then one version installed into the GAC until I update this method.
18768 2004-04-28 Martin Baulig <martin@ximian.com>
18770 * typemanager.cs (TypeManager.CheckStructCycles): New public
18771 static method to check for cycles in the struct layout.
18773 * rootcontext.cs (RootContext.PopulateTypes): Call
18774 TypeManager.CheckStructCycles() for each TypeContainer.
18775 [Note: We only need to visit each type once.]
18777 2004-04-28 Martin Baulig <martin@ximian.com>
18779 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
18781 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
18782 success and added `out object value'. Use a `bool resolved' field
18783 to check whether we've already been called rather than
18784 `ConstantValue != null' since this breaks for NullLiterals.
18786 2004-04-28 Raja R Harinath <rharinath@novell.com>
18788 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
18789 setting of this flag, since the 'set' method may be non-public.
18791 2004-04-28 Raja R Harinath <rharinath@novell.com>
18793 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
18794 check on current_vector.Block.
18796 2004-04-27 Martin Baulig <martin@ximian.com>
18798 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
18799 a field initializer. Fixes #56459.
18801 2004-04-27 Martin Baulig <martin@ximian.com>
18803 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
18804 we're not attempting to use an indexer. Fixes #52154.
18806 2004-04-27 Martin Baulig <martin@ximian.com>
18808 * statement.cs (Return): Don't create a return label if we don't
18809 need it; reverts my change from January 20th. Thanks to Ben
18812 2004-04-27 Martin Baulig <martin@ximian.com>
18814 According to the spec, `goto' can only leave a nested scope, but
18817 * statement.cs (Block.LookupLabel): Only lookup in the current
18818 block, don't recurse into parent or child blocks.
18819 (Block.AddLabel): Check in parent and child blocks, report
18820 CS0140/CS0158 if we find a duplicate.
18821 (Block): Removed this indexer for label lookups.
18822 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
18823 this already does the error reporting for us.
18826 (FlowBranching.UsageVector.Block): New public variable; may be null.
18827 (FlowBranching.CreateSibling): Added `Block' argument.
18828 (FlowBranching.LookupLabel): New public virtual method. Lookup a
18829 label for the target of a `goto' and check whether we're not
18830 leaving a `finally'.
18832 2004-04-27 Martin Baulig <martin@ximian.com>
18834 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
18835 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
18838 2004-04-27 Martin Baulig <martin@ximian.com>
18840 * statement.cs (Block.AddLabel): Also check for implicit blocks
18841 and added a CS0158 check.
18843 2004-04-27 Martin Baulig <martin@ximian.com>
18845 * flowanalysis.cs (FlowBranchingLoop): New class.
18846 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
18847 UsageVector's instead of an ArrayList.
18848 (FlowBranching.Label): Likewise.
18849 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
18850 (FlowBranching.AddBreakVector): New method.
18852 2004-04-27 Miguel de Icaza <miguel@ximian.com>
18854 * attribute.cs: Small regression fix: only convert the type if we
18855 the type is different, fixes System.Drawing build.
18857 2004-04-27 Martin Baulig <martin@ximian.com>
18859 * attribute.cs (Attribute.Resolve): If we have a constant value
18860 for a named field or property, implicity convert it to the correct
18863 2004-04-27 Raja R Harinath <rharinath@novell.com>
18865 * statement.cs (Block.Block): Implicit blocks share
18866 'child_variable_names' fields with parent blocks.
18867 (Block.AddChildVariableNames): Remove.
18868 (Block.AddVariable): Mark variable as "used by a child block" in
18869 every surrounding block.
18870 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
18871 been used in a child block, complain about violation of "Invariant
18872 meaning in blocks" rule.
18873 * cs-parser.jay (declare_local_variables): Don't use
18874 AddChildVariableNames.
18875 (foreach_statement): Don't create an implicit block: 'foreach'
18876 introduces a scope.
18878 2004-04-23 Miguel de Icaza <miguel@ximian.com>
18880 * convert.cs (ImplicitNumericConversion): 0 is also positive when
18881 converting from 0L to ulong. Fixes 57522.
18883 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18885 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
18886 derived class hides via 'new' keyword field from base class (test-242.cs).
18887 TODO: Handle this in the more general way.
18889 * class.cs (CheckBase): Ditto.
18891 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18893 * decl.cs (caching_flags): New member for storing cached values
18895 (MemberCore.Flags): New enum where bit flags for caching_flags
18897 (MemberCore.cls_compliance): Moved to caching_flags.
18898 (DeclSpace.Created): Moved to caching_flags.
18900 * class.cs: Use caching_flags instead of DeclSpace.Created
18902 2004-04-21 Miguel de Icaza <miguel@ximian.com>
18904 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
18905 if we are only a derived class, not a nested class.
18907 * typemanager.cs: Same as above, but do this at the MemberLookup
18908 level (used by field and methods, properties are handled in
18909 PropertyExpr). Allow for the qualified access if we are a nested
18912 2004-04-21 Marek Safar <marek.safar@seznam.cz>
18914 * class.cs: Refactoring.
18915 (IMethodData): New inteface; Holds links to parent members
18916 to avoid member duplication (reduced memory allocation).
18917 (Method): Implemented IMethodData interface.
18918 (PropertyBase): New inner classes for get/set methods.
18919 (PropertyBase.PropertyMethod): Implemented IMethodData interface
18920 (Event): New inner classes for add/remove methods.
18921 (Event.DelegateMethod): Implemented IMethodData interface.
18923 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
18924 EmitContext (related to class.cs refactoring).
18926 2004-04-21 Raja R Harinath <rharinath@novell.com>
18928 * delegate.cs (Delegate.VerifyApplicability): If the number of
18929 arguments are the same as the number of parameters, first try to
18930 verify applicability ignoring any 'params' modifier on the last
18934 2004-04-16 Raja R Harinath <rharinath@novell.com>
18936 * class.cs (TypeContainer.AddIndexer): Use
18937 'ExplicitInterfaceName' to determine if interface name was
18938 explicitly specified. 'InterfaceType' is not initialized at this time.
18939 (TypeContainer.DefineIndexers): Remove use of temporary list. The
18940 Indexers array is already in the required order. Initialize
18941 'IndexerName' only if there are normal indexers.
18942 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
18943 (TypeContainer.Emit): Emit DefaultMember attribute only if
18944 IndexerName is initialized.
18947 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
18949 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
18952 2004-04-15 Raja R Harinath <rharinath@novell.com>
18954 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
18958 * attribute.cs (Attribute.Resolve): Check for duplicate named
18962 2004-04-15 Miguel de Icaza <miguel@ximian.com>
18964 * iterators.cs (MarkYield): track whether we are in an exception,
18965 and generate code accordingly. Use a temporary value to store the
18966 result for our state.
18968 I had ignored a bit the interaction of try/catch with iterators
18969 since their behavior was not entirely obvious, but now it is
18970 possible to verify that our behavior is the same as MS .NET 2.0
18974 2004-04-14 Miguel de Icaza <miguel@ximian.com>
18976 * iterators.cs: Avoid creating temporaries if there is no work to
18979 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
18980 Enumerations, use TypeManager.EnumToUnderlying and call
18983 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
18986 (This.Emit): Use EmitContext.EmitThis to emit our
18989 (This.EmitAssign): Ditto.
18991 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
18992 codepaths, we will move all the functionality into
18995 (FieldExpr.EmitAssign): Ditto.
18997 This fixes several hidden bugs that I uncovered while doing a code
18998 review of this today.
19000 * codegen.cs (EmitThis): reworked so the semantics are more clear
19001 and also support value types "this" instances.
19003 * iterators.cs: Changed so that for iterators in value types, we
19004 do not pass the value type as a parameter.
19006 Initialization of the enumerator helpers is now done in the caller
19007 instead of passing the parameters to the constructors and having
19008 the constructor set the fields.
19010 The fields have now `assembly' visibility instead of private.
19012 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19014 * expression.cs (Argument.Resolve): Check if fields passed as ref
19015 or out are contained in a MarshalByRefObject.
19017 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19018 another compiler type.
19020 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19022 * class.cs (Indexer.Define): use the new name checking method.
19023 Also, return false on an error.
19024 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19025 (is_identifier_[start/part]_character): make static.
19027 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19029 * expression.cs (Binary.ResolveOperator): Do no append strings
19030 twice: since we can be invoked more than once (array evaluation)
19031 on the same concatenation, take care of this here. Based on a fix
19032 from Ben (bug #56454)
19034 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19036 * codegen.cs: Fix another case where CS1548 must be reported (when
19037 delay-sign isn't specified and no private is available #56564). Fix
19038 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19039 error when MCS is used on the MS runtime and we need to delay-sign
19040 (which seems unsupported by AssemblyBuilder - see #56621).
19042 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19044 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19045 (TypeManager.ComputeNamespaces): Faster implementation for
19048 * compiler.csproj: Updated AssemblyName to mcs.
19050 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19052 * rootcontext.cs: Add new types to the boot resolution.
19054 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19055 MulticastDelegate is not allowed.
19057 * typemanager.cs: Add new types to lookup: System.TypedReference
19060 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19061 check for TypedReference or ArgIterator, they are not allowed.
19063 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19064 makes us properly catch 1510 in some conditions (see bug 56016 for
19067 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19069 * CryptoConvert.cs: update from corlib version
19072 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19074 * class.cs (Indexer.Define): Check indexername declaration
19076 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19078 * attribute.cs (IsClsCompliant): Fixed problem with handling
19079 all three states (compliant, not-compliant, undetected).
19081 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19083 * attribute.cs (Attribute): Location is now public.
19084 (Resolve): Store resolved arguments (pos_values) in attribute class.
19085 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19086 (GetClsCompliantAttributeValue): New method that gets
19087 CLSCompliantAttribute value.
19088 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19089 if exists else null.
19090 (AttributeTester): New class for CLS-Compliant verification routines.
19092 * class.cs (Emit): Add CLS-Compliant verification.
19093 (Method.GetSignatureForError): Implemented.
19094 (Constructor.GetSignatureForError): Implemented
19095 (Constructor.HasCompliantArgs): Returns if constructor has
19096 CLS-Compliant arguments.
19097 (Constructor.Emit): Override.
19098 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19099 is needed to test only parameters.
19100 (FieldBase.GetSignatureForError): Implemented.
19101 (TypeContainer): New member for storing base interfaces.
19102 (TypeContainer.FindMembers): Search in base interfaces too.
19104 * codegen.cs (GetClsComplianceAttribute): New method that gets
19105 assembly or module CLSCompliantAttribute value.
19106 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19108 (ModuleClass.Emit): Add error 3012 test.
19110 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19112 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19113 state for all decl types.
19114 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19115 if CLS-Compliant tests are required.
19116 (IsClsCompliaceRequired): New method. Analyze whether code
19117 must be CLS-Compliant.
19118 (IsExposedFromAssembly): New method. Returns true when MemberCore
19119 is exposed from assembly.
19120 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19121 value or gets cached value.
19122 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19123 is explicitly marked with CLSCompliantAttribute.
19124 (IsIdentifierClsCompliant): New abstract method. This method is
19125 used to testing error 3005.
19126 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19127 for identifier and parameters CLS-Compliant testing.
19128 (VerifyClsCompliance): New method. The main virtual method for
19129 CLS-Compliant verifications.
19130 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19131 null. I don't know why is null (too many public members !).
19132 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19133 and get value of first CLSCompliantAttribute that found.
19135 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19136 (VerifyClsCompliance): Override and add extra tests.
19138 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19139 clscheck- disable CLS-Compliant verification event if assembly is has
19140 CLSCompliantAttribute(true).
19142 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19143 ApllyAttribute is now called in emit section as in the other cases.
19144 Possible future Emit integration.
19145 (IsIdentifierClsCompliant): New override.
19146 (VerifyClsCompliance): New override.
19147 (GetEnumeratorName): Returns full enum name.
19149 * parameter.cs (GetSignatureForError): Implemented.
19151 * report.cs (WarningData): New struct for Warning message information.
19152 (LocationOfPreviousError): New method.
19153 (Warning): New method. Reports warning based on the warning table.
19154 (Error_T): New method. Reports error based on the error table.
19156 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19157 verifications are done here.
19159 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19161 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19162 CLSCompliantAttribute.
19163 (all_imported_types): New member holds all imported types from other
19165 (LoadAllImportedTypes): New method fills static table with exported types
19166 from all referenced assemblies.
19167 (Modules): New property returns all assembly modules.
19169 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19171 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19172 throwing a parser error.
19174 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19175 which removes the hardcoded get_/set_ prefixes for properties, as
19176 IL allows for the properties to be named something else.
19180 * expression.cs: Do not override operand before we know if it is
19181 non-null. Fix 56207
19183 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19185 * typemanager.cs: support for pinned variables.
19187 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19189 * decl.cs, typemanager.cs: Avoid using an arraylist
19190 as a buffer if there is only one result set.
19192 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19194 * expression.cs: Make sure you cant call a static method
19195 with an instance expression, bug #56174.
19197 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19199 * class.cs (IsDuplicateImplementation): Improve error reporting to
19200 flag 663 (method only differs in parameter modifier).
19202 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19203 in preprocessor directives.
19205 * location.cs (LookupFile): Allow for the empty path.
19207 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19208 better approach for some of that patch, but its failing with the
19209 CharSet enumeration. For now try/catch will do.
19211 * typemanager.cs: Do not crash if a struct does not have fields.
19214 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19216 * expression.cs: cs0213, cant fix a fixed expression.
19219 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19221 * cs-parser.jay: detect invalid embeded statements gracefully.
19224 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19226 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19229 the invocation type may not be a subclass of the tye of the item/
19230 The type of the item must be a subclass of the invocation item.
19235 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19237 * attribute.cs: Added methods to get a string and a bool from an
19238 attribute. Required to information from AssemblyKeyFileAttribute,
19239 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19240 * codegen.cs: Modified AssemblyName creation to include support for
19241 strongnames. Catch additional exceptions to report them as CS1548.
19242 * compiler.csproj: Updated include CryptoConvert.cs.
19243 * compiler.csproj.user: Removed file - user specific configuration.
19244 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19245 Mono.Security assembly. The original class is maintained and tested in
19246 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19247 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19248 like CSC 8.0 (C# v2) supports.
19249 * Makefile: Added CryptoConvert.cs to mcs sources.
19250 * rootcontext.cs: Added new options for strongnames.
19252 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19254 * driver.cs: For --expect-error, report error code `2'
19255 if the program compiled with no errors, error code `1' if
19256 it compiled with an error other than the one expected.
19258 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19260 * compiler.csproj: Updated for Visual Studio .NET 2003.
19261 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19262 * compiler.sln: Updated for Visual Studio .NET 2003.
19264 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19266 * expression.cs: Fix bug #47234. We basically need to apply the
19267 rule that we prefer the conversion of null to a reference type
19268 when faced with a conversion to 'object' (csc behaviour).
19270 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19272 * statement.cs: Shorter form for foreach, eliminates
19273 a local variable. r=Martin.
19275 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19277 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19278 checks if we can use brtrue/brfalse to test for 0.
19279 * expression.cs: use the above in the test for using brtrue/brfalse.
19280 cleanup code a bit.
19282 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19284 * expression.cs: Rewrite string concat stuff. Benefits:
19286 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19287 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19288 rather than a concat chain.
19290 * typemanager.cs: Add lookups for more concat overloads.
19292 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19294 * expression.cs: Emit shorter il code for array init.
19311 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19313 * statement.cs: Before, two switch blocks would be merged if the
19314 total size of the blocks (end_item - begin_item + 1) was less than
19315 two times the combined sizes of the blocks.
19317 Now, it will only merge if after the merge at least half of the
19322 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19324 * class.cs : csc build fix for GetMethods(). See bug #52503.
19326 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19328 * expression.cs: Make sure fp comparisons work with NaN.
19329 This fixes bug #54303. Mig approved this patch a long
19330 time ago, but we were not able to test b/c the runtime
19333 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19335 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19337 2004-03-19 Martin Baulig <martin@ximian.com>
19339 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19340 error here and not in our caller.
19342 2004-03-19 Martin Baulig <martin@ximian.com>
19344 * interface.cs: Completely killed this file.
19345 (Interface): We're now a TypeContainer and live in class.cs.
19347 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19348 argument; we're now also called for interfaces.
19349 (TypeContainer.DefineMembers): Allow this method being called
19351 (TypeContainer.GetMethods): New public method; formerly known as
19352 Interface.GetMethod(). This is used by PendingImplementation.
19353 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19354 it's now private and non-static.
19355 (Interface): Moved this here; it's now implemented similar to
19357 (Method, Property, Event, Indexer): Added `bool is_interface'
19358 argument to their .ctor's.
19359 (MemberBase.IsInterface): New public field.
19361 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19362 instances instead of InterfaceMethod, InterfaceProperty, etc.
19363 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19364 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19366 2004-03-19 Martin Baulig <martin@ximian.com>
19368 * class.cs (MethodCore.IsDuplicateImplementation): New private
19369 method which does the CS0111 checking.
19370 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19371 Use IsDuplicateImplementation().
19373 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19375 * decl.cs (FindMemberToOverride): New method to find the correct
19376 method or property to override in the base class.
19378 - Make Method/Property use the above method to find the
19379 version in the base class.
19380 - Remove the InheritableMemberSignatureCompare as it is now
19383 This patch makes large code bases much faster to compile, as it is
19384 O(n) rather than O(n^2) to do this validation.
19386 Also, it fixes bug 52458 which is that nested classes are not
19387 taken into account when finding the base class member.
19389 Reviewed/Approved by Martin.
19391 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19393 * interface.cs: In all interface classes removed redundant
19394 member initialization.
19396 2004-03-16 Martin Baulig <martin@ximian.com>
19398 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19400 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19402 * decl.cs (DefineTypeAndParents): New helper method to define a
19403 type's containers before the type itself is defined; This is a
19404 bug exposed by the recent changes to Windows.Forms when an
19405 implemented interface was defined inside a class that had not been
19408 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19410 (Check): Loop correctly to report errors modifiers
19411 (UNSAFE was not in the loop, since it was the same as TOP).
19413 * interface.cs: Every interface member now takes a ModFlags,
19414 instead of a "is_new" bool, which we set on the base MemberCore.
19416 Every place where we called "UnsafeOk" in the interface, now we
19417 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19418 the unsafe settings from the member declaration instead of the
19419 container interface.
19421 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19423 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19424 `set_indexer_name' to the pending bits (one per type).
19426 We fixed a bug today that was picking the wrong method to
19427 override, since for properties the existing InterfaceMethod code
19428 basically ignored the method name. Now we make sure that the
19429 method name is one of the valid indexer names.
19431 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19433 * support.cs (SeekableStreamReader): Keep track of stream byte
19434 positions and don't mix them with character offsets to the buffer.
19436 Patch from Gustavo Giráldez
19438 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19440 * interface.cs (InterfaceSetGetBase): Removed double member
19441 initialization, base class does it as well.
19443 2004-03-13 Martin Baulig <martin@ximian.com>
19445 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19446 when compiling corlib.
19448 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19450 * convert.cs (ExplicitConversion): We were reporting an error on
19451 certain conversions (object_type source to a value type, when the
19452 expression was `null') before we had a chance to pass it through
19453 the user defined conversions.
19455 * driver.cs: Replace / and \ in resource specifications to dots.
19458 * class.cs: Add check for duplicate operators. Fixes 52477
19460 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19462 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19463 that are in the middle of the statements, not only at the end.
19466 * class.cs (TypeContainer.AddField): No longer set the
19467 `HaveStaticConstructor' flag, now we call it
19468 `UserDefineStaticConstructor' to diferentiate the slightly
19469 semantic difference.
19471 The situation is that we were not adding BeforeFieldInit (from
19472 Modifiers.TypeAttr) to classes that could have it.
19473 BeforeFieldInit should be set to classes that have no static
19478 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19480 And most importantly Zoltan's comment:
19482 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19484 "I think beforefieldinit means 'it's ok to initialize the type sometime
19485 before its static fields are used', i.e. initialization does not need
19486 to be triggered by the first access to the type. Setting this flag
19487 helps the JIT to compile better code, since it can run the static
19488 constructor at JIT time, and does not need to generate code to call it
19489 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19490 this flag for lots of classes like String.
19492 csc sets this flag if the type does not have an explicit static
19493 constructor. The reasoning seems to be that if there are only static
19494 initalizers for a type, and no static constructor, then the programmer
19495 does not care when this initialization happens, so beforefieldinit
19498 This bug prevents the AOT compiler from being usable, since it
19499 generates so many calls to mono_runtime_class_init that the AOT code
19500 is much slower than the JITted code. The JITted code is faster,
19501 because it does not generate these calls if the vtable is type is
19502 already initialized, which is true in the majority of cases. But the
19503 AOT compiler can't do this."
19505 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19507 * class.cs (MethodData.Emit): Refactor the code so symbolic
19508 information is generated for destructors; For some reasons we
19509 were taking a code path that did not generate symbolic information
19512 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19514 * class.cs: Create a Constructor.CheckBase method that
19515 takes care of all validation type code. The method
19516 contains some code that was moved from Define.
19518 It also includes new code that checks for duplicate ctors.
19519 This fixes bug #55148.
19521 2004-03-09 Joshua Tauberer <tauberer@for.net>
19523 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19524 a { ... }-style array creation invokes EmitStaticInitializers
19525 which is not good for reference-type arrays. String, decimal
19526 and now null constants (NullCast) are not counted toward
19527 static initializers.
19529 2004-03-05 Martin Baulig <martin@ximian.com>
19531 * location.cs (SourceFile.HasLineDirective): New public field;
19532 specifies whether the file contains or is referenced by a "#line"
19534 (Location.DefineSymbolDocuments): Ignore source files which
19535 either contain or are referenced by a "#line" directive.
19537 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19539 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19540 direct access to our parent, so check the method inline there.
19542 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19544 * expression.cs (Invocation.EmitCall): Miguel's last commit
19545 caused a regression. If you had:
19550 In Foo the implict this would be null.
19552 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19554 * expression.cs (Invocation.EmitCall): If the method is not
19555 virtual, do not emit a CallVirt to it, use Call.
19557 * typemanager.cs (GetFullNameSignature): Improve the method to
19558 cope with ".ctor" and replace it with the type name.
19560 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19561 as an argument the ConstructorBuilder where it is being defined,
19562 to catch the recursive constructor invocations.
19564 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19566 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19567 routines to check if a type is an enumerable/enumerator allow
19568 classes that implement the IEnumerable or IEnumerator interfaces.
19570 * class.cs (Property, Operator): Implement IIteratorContainer, and
19571 implement SetYields.
19573 (Property.Define): Do the block swapping for get_methods in the
19574 context of iterators. We need to check if Properties also
19575 include indexers or not.
19577 (Operator): Assign the Block before invoking the
19578 OperatorMethod.Define, so we can trigger the Iterator code
19581 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19582 Property and Operator classes are not created when we parse the
19583 declarator but until we have the block completed, so we use a
19584 singleton SimpleIteratorContainer.Simple to flag whether the
19585 SetYields has been invoked.
19587 We propagate this setting then to the Property or the Operator to
19588 allow the `yield' to function.
19590 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19592 * codegen.cs: Implemented attribute support for modules.
19593 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19594 Assembly/Module functionality.
19596 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19597 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19598 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19600 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19602 * interface.cs (FindMembers): The operation is performed on all base
19603 interfaces and not only on the first. It is required for future CLS Compliance patch.
19605 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19607 * statement.cs, codegen.cs:
19608 This patch deals with patterns such as:
19610 public class List : IEnumerable {
19612 public MyEnumerator GetEnumerator () {
19613 return new MyEnumerator(this);
19616 IEnumerator IEnumerable.GetEnumerator () {
19620 public struct MyEnumerator : IEnumerator {
19625 Before, there were a few things we did wrong:
19626 1) we would emit callvirt on a struct, which is illegal
19627 2) we emited ldarg when we needed to emit ldarga
19628 3) we would mistakenly call the interface methods on an enumerator
19629 type that derived from IEnumerator and was in another assembly. For example:
19631 public class MyEnumerator : IEnumerator
19633 Would have the interface methods called, even if there were public impls of the
19634 method. In a struct, this lead to invalid IL code.
19636 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19638 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19641 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19643 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19645 * cs-parser.jay: Fix small regression: we were not testing V2
19646 compiler features correctly.
19648 * interface.cs: If the emit context is null, then create one
19650 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19652 * decl.cs (GetSignatureForError): New virtual method to get full name
19653 for error messages.
19655 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19656 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19658 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19659 Duplicated members and code in these classes has been removed.
19660 Better encapsulation in these classes.
19662 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19664 * assign.cs (Assign.DoResolve): When dealing with compound
19665 assignments, there is a new rule in ECMA C# 2.4 (might have been
19666 there before, but it is documented here) that states that in:
19670 If b is of type int, and the `op' is a shift-operator, then the
19671 above is evaluated as:
19675 * expression.cs (Binary.ResolveOperator): Instead of testing for
19676 int/uint/long/ulong, try to implicitly convert to any of those
19677 types and use that in pointer arithmetic.
19679 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19680 method to print information for from the type, not from the
19681 null-method we were given.
19683 2004-02-01 Duncan Mak <duncan@ximian.com>
19685 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19686 parsing for cmd, fixes bug #53694.
19688 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19690 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19691 in the member name duplication tests. Property and operator name duplication
19692 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19694 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19696 * interface.cs (PopulateMethod): Fixed crash when interface method
19697 returns not existing type (error test cs0246-3.cs).
19699 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19701 * cs-parser.jay (interface_accessors): Re-write actions to also
19702 store attributes attached to get and set methods. Fix spelling
19705 (inteface_property_declaration): Modify accordingly.
19707 (InterfaceAccessorInfo): New helper class to store information to pass
19708 around between rules that use interface_accessors.
19710 * interface.cs (Emit): Apply attributes on the get and set
19711 accessors of properties and indexers too.
19713 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19714 right MethodBuilder when applying attributes to the get and set accessors.
19716 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19718 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19720 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19722 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19724 2004-01-25 Miguel de Icaza <miguel@ximian.com>
19726 * cs-parser.jay: Remove YIELD token, instead use the new grammar
19727 changes that treat `yield' specially when present before `break'
19728 or `return' tokens.
19730 * cs-tokenizer.cs: yield is no longer a keyword.
19732 2004-01-23 Marek Safar <marek.safar@seznam.cz>
19734 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
19735 setting for default constructors.
19736 For default constructors are almost every time set wrong Modifier. The
19737 generated IL code has been alright. But inside mcs this values was
19738 wrong and this was reason why several of my CLS Compliance tests
19741 2004-01-22 Martin Baulig <martin@ximian.com>
19743 * cs-parser.jay (namespace_or_type_name): Return an Expression,
19744 not a QualifiedIdentifier. This is what `type_name_expression'
19745 was previously doing.
19746 (type_name_expression): Removed; the code is now in
19747 `namespace_or_type_name'.
19748 (qualified_identifier): Removed, use `namespace_or_type_name'
19750 (QualifiedIdentifier): Removed this class.
19752 2004-01-22 Martin Baulig <martin@ximian.com>
19754 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
19755 not a string as alias name.
19757 2004-01-21 Miguel de Icaza <miguel@ximian.com>
19759 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
19760 #52730 bug, and instead compute correctly the need to use a
19761 temporary variable when requesting an address based on the
19762 static/instace modified of the field and the constructor.
19764 2004-01-21 Martin Baulig <martin@ximian.com>
19766 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
19767 class and namespace before looking up aliases. Fixes #52517.
19769 2004-01-21 Martin Baulig <martin@ximian.com>
19771 * flowanalysis.cs (UsageVector.Merge): Allow variables being
19772 assinged in a 'try'; fixes exception4.cs.
19774 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19775 * class.cs : Implemented parameter-less constructor for TypeContainer
19777 * decl.cs: Attributes are now stored here. New property OptAttributes
19779 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
19781 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
19783 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19785 * typemanager.cs (CSharpSignature): Now reports also inner class name.
19786 (CSharpSignature): New method for indexer and property signature.
19788 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19790 * pending.cs (IsVirtualFilter): Faster implementation.
19792 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19794 * typemanager.cs: Avoid inclusion of same assembly more than once.
19796 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19798 * cs-parser.jay: Fixed problem where the last assembly attribute
19799 has been applied also to following declaration (class, struct, etc.)
19801 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19803 * class.cs: Added error CS0538, CS0539 reporting.
19804 Fixed crash on Microsoft runtime when field type is void.
19806 * cs-parser.jay: Added error CS0537 reporting.
19808 * pending.cs: Added error CS0535 reporting.
19809 Improved error report for errors CS0536, CS0534.
19811 2004-01-20 Miguel de Icaza <miguel@ximian.com>
19813 Merge a few bits from the Anonymous Method MCS tree.
19815 * statement.cs (ToplevelBlock): New class for toplevel methods,
19816 will hold anonymous methods, lifted variables.
19818 * cs-parser.jay: Create toplevel blocks for delegates and for
19819 regular blocks of code.
19821 2004-01-20 Martin Baulig <martin@ximian.com>
19823 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
19824 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
19825 and `NeedExplicitReturn'; added `IsLastStatement'.
19826 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
19827 have a `ReturnLabel' or we're not unreachable.
19829 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
19830 child's reachability; don't just override ours with it. Fixes
19831 #58058 (lluis's example).
19832 (FlowBranching): Added public InTryOrCatch(), InCatch(),
19833 InFinally(), InLoop(), InSwitch() and
19834 BreakCrossesTryCatchBoundary() methods.
19836 * statement.cs (Return): Do all error checking in Resolve().
19837 Unless we are the last statement in a top-level block, always
19838 create a return label and jump to it.
19839 (Break, Continue): Do all error checking in Resolve(); also make
19840 sure we aren't leaving a `finally'.
19841 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
19842 statement in a top-level block.
19843 (Block.Flags): Added `IsDestructor'.
19844 (Block.IsDestructor): New public property.
19846 2004-01-20 Martin Baulig <martin@ximian.com>
19848 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
19850 2004-01-20 Martin Baulig <martin@ximian.com>
19852 * statement.cs (Statement.ResolveUnreachable): New public method.
19853 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
19854 (Block.Resolve): Resolve unreachable statements.
19856 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19858 * expression.cs: We need to fix the case where we do
19859 not have a temp variable here.
19861 * assign.cs: Only expression compound assignments need
19862 temporary variables.
19864 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19866 * flowanalysis.cs: Reduce memory allocation in a few ways:
19867 - A block with no variables should not allocate a bit
19869 - A method with no out parameters does not need any tracking
19870 for assignment of the parameters, so we need not allocate
19873 public readonly Type[] VariableTypes;
19874 public readonly string[] VariableNames;
19875 Are redundant. The data is already stored in the variable
19876 map, so we need not allocate another array for it.
19877 - We need to add alot of checks for if (params | locals) == null
19878 due to the first two changes.
19880 2004-01-18 Miguel de Icaza <miguel@ximian.com>
19882 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
19883 implement IMemoryLocation, we store a copy on a local variable and
19884 take the address of it. Patch from Benjamin Jemlich
19886 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
19887 to use a special "type_name_expression" rule which reduces the
19888 number of "QualifiedIdentifier" classes created, and instead
19889 directly creates MemberAccess expressions.
19891 2004-01-17 Miguel de Icaza <miguel@ximian.com>
19893 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
19894 that fixes #52853. Null literal assignment to ValueType
19896 * class.cs (MethodData.Emit): Instead of checking the name of the
19897 method to determine if its a destructor, create a new derived
19898 class from Method called Destructor, and test for that.
19900 * cs-parser.jay: Create a Destructor object instead of a Method.
19902 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
19906 2004-01-16 Miguel de Icaza <miguel@ximian.com>
19908 * expression.cs (Binary.ResolveOperator): Perform an implicit
19909 conversion from MethodGroups to their delegate types on the
19910 Addition operation.
19912 * delegate.cs: Introduce a new class DelegateCreation that is the
19913 base class for `NewDelegate' and `ImplicitDelegateCreation',
19914 factor some code in here.
19916 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
19917 conversion from MethodGroups to compatible delegate types.
19919 * ecore.cs (Expression.Resolve): Do not flag error 654
19920 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
19921 we allow conversions from MethodGroups to delegate types now.
19923 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
19924 assignments in v2 either.
19926 2004-01-10 Miguel de Icaza <miguel@ximian.com>
19928 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
19929 static read-only fields in ctors.
19931 Applied patch from Benjamin Jemlich
19933 * expression.cs (UnaryMutator): Avoid leaking local variables.
19935 2004-01-09 Miguel de Icaza <miguel@ximian.com>
19937 * cs-tokenizer.cs (IsCastToken): Allow the various native types
19938 here to return true, as they can be used like this:
19940 (XXX) int.MEMBER ()
19942 Fixed 49836 and all the other dups
19944 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
19946 * driver.cs: Implement /win32res and /win32icon.
19948 2004-01-08 Miguel de Icaza <miguel@ximian.com>
19950 * cs-parser.jay: Add a rule to improve error handling for the
19951 common mistake of placing modifiers after the type.
19953 2004-01-07 Miguel de Icaza <miguel@ximian.com>
19955 * cs-parser.jay (interface_event_declaration): Catch
19956 initialization of events on interfaces, and report cs0068
19958 * cs-parser.jay (interface_event_declaration): Catch
19959 initialization of events.
19961 * ecore.cs: Better report missing constructors.
19963 * expression.cs (Binary.ResolveOperator): My previous bug fix had
19964 the error reporting done in the wrong place. Fix.
19966 * expression.cs (Binary.ResolveOperator): Catch the
19967 operator + (E x, E y) error earlier, and later allow for implicit
19968 conversions in operator +/- (E e, U x) from U to the underlying
19971 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
19972 52596, if the container class is abstract, the default constructor
19973 is protected otherwise its public (before, we were always public).
19975 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
19978 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
19979 Jemlich that fixes bug #52597, MCS was generating invalid code for
19980 idisposable structs. Thanks to Ben for following up with this
19983 2004-01-06 Miguel de Icaza <miguel@ximian.com>
19985 * driver.cs: Allow assemblies without code to be generated, fixes
19988 2004-01-07 Nick Drochak <ndrochak@gol.com>
19990 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
19992 2004-01-05 Miguel de Icaza <miguel@ximian.com>
19994 * cs-parser.jay: Add rules to improve error reporting if fields or
19995 methods are declared at the namespace level (error 116)
19997 * Add rules to catch event add/remove
19999 2004-01-04 David Sheldon <dave-mono@earth.li>
20001 * expression.cs: Added matching ")" to error message for
20004 2004-01-03 Todd Berman <tberman@gentoo.org>
20006 * ecore.cs, attribute.cs:
20007 Applying fix from #52429.
20009 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20011 * ecore.cs, expression.cs, statement.cs:
20012 Total rewrite of how we handle branching. We
20013 now handle complex boolean expressions with fewer
20014 jumps. As well if (x == 0) no longer emits a ceq.
20016 if (x is Foo) is much faster now, because we generate
20019 Overall, we get a pretty big improvement on our benchmark
20020 tests. The code we generate is smaller and more readable.
20022 I did a full two-stage bootstrap. The patch was reviewed
20023 by Martin and Miguel.
20025 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20027 * cs-parser.jay: Make primary_expression not take a QI.
20028 we dont need this because the member_access rule covers
20029 us here. So we replace the rule with just IDENTIFIER.
20031 This has two good effects. First, we remove a s/r conflict.
20032 Second, we allocate many fewer QualifiedIdentifier objects.
20034 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20036 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20037 set the correct information via SRE. This prevents
20038 hanging on the MS runtime. Fixes #29374.
20040 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20042 * convert.cs: correctly handle conversions to value types
20043 from Enum and ValueType as unboxing conversions.
20045 Fixes bug #52569. Patch by Benjamin Jemlich.
20047 2004-01-02 Ravi Pratap <ravi@ximian.com>
20049 * expression.cs (BetterConversion): Prefer int -> uint
20050 over int -> ulong (csc's behaviour). This fixed bug #52046.
20052 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20054 * decl.cs (MemberCache.FindMembers): now returns a
20057 * typemanager.cs: In general, go with with ^^.
20058 (CopyNewMethods): take an IList.
20059 (RealMemberLookup): Only allocate an arraylist
20060 if we copy from two sets of methods.
20062 This change basically does two things:
20063 1) Fewer array lists allocated due to CopyNewMethods.
20064 2) the explicit cast in MemberList costed ALOT.
20066 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20068 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20069 a hashtable to avoid needless string allocations when an identifier is
20070 used more than once (the common case).
20072 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20074 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20075 is broken, it will not return anything. So, we
20076 have to use the information we have in mcs to
20079 * typemanager.cs: Add a cache for GetInterfaces,
20080 since this will now be used more often (due to ^^)
20082 (GetExplicitInterfaces) New method that gets the
20083 declared, not effective, interfaces on a type
20084 builder (eg, if you have interface IFoo, interface
20085 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20088 This patch makes MCS able to bootstrap itself on
20091 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20093 * expression.cs: Remove the Nop's that Miguel put
20096 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20098 * report.cs, codegen.cs: Give the real stack trace to
20099 the error when an exception is thrown.
20101 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20103 * decl.cs: only allocate hashtables for ifaces if
20106 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20108 * expression.cs: fix the error from cs0121-2.cs
20109 (a parent interface has two child interfaces that
20110 have a function with the same name and 0 params
20111 and the function is called through the parent).
20113 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20115 * class.cs, rootcontext.cs, typmanager.cs: do not
20118 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20120 * codegen.cs: remove stack for the ec flow branching.
20121 It is already a linked list, so no need.
20123 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20125 * Makefile: Allow custom profiler here.
20127 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20129 * typemanager.cs (LookupType):
20130 - Use a static char [], because split takes
20131 a param array for args, so it was allocating
20133 - Do not store true in a hashtable, it boxes.
20135 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20137 * flowanalysis.cs: bytify common enums.
20139 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20141 * modifiers.cs: Add a new set of flags for the
20142 flags allowed on explicit interface impls.
20143 * cs-parser.jay: catch the use of modifiers in
20144 interfaces correctly.
20145 * class.cs: catch private void IFoo.Blah ().
20147 All related to bug #50572.
20149 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20151 * decl.cs: Rewrite the consistant accessability checking.
20152 Accessability is not linear, it must be implemented in
20153 a tableish way. Fixes #49704.
20155 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20157 * expression.cs: Handle negation in a checked context.
20158 We must use subtraction from zero. Fixes #38674.
20160 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20162 * class.cs: Ignore static void main in DLLs.
20163 * rootcontext.cs: Handle the target type here,
20164 since we are have to access it from class.cs
20165 * driver.cs: account for the above.
20167 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20169 * report.cs: Give line numbers and files if available.
20171 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20173 * driver.cs: Implement /addmodule.
20175 * typemanager.cs: Change 'modules' field so it now contains Modules not
20178 2003-12-20 Martin Baulig <martin@ximian.com>
20180 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20181 (FieldBase.IsAssigned): Removed this field.
20182 (FieldBase.SetAssigned): New public method.
20183 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20185 2003-12-20 Martin Baulig <martin@ximian.com>
20187 * expression.cs (LocalVariableReference.DoResolve): Don't set
20188 `vi.Used' if we're called from DoResolveLValue().
20190 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20191 returns the usage vector it just merged into the current one -
20192 pass this one to UsageWarning().
20193 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20194 of the `EmitContext', don't call this recursively on our children.
20196 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20198 * driver.cs: Implement /target:module.
20200 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20202 * support.cs (CharArrayHashtable): New helper class.
20204 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20205 char arrays, not strings, so we can avoid creating a string in
20206 consume_identifier if the identifier is a keyword.
20208 2003-12-16 Martin Baulig <martin@ximian.com>
20210 * statement.cs (LocalInfo.Assigned): Removed this property.
20211 (LocalInfo.Flags): Removed `Assigned'.
20212 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20213 and uses flow analysis.
20214 (Block.UsageWarning): Made this method private.
20215 (Block.Resolve): Call UsageWarning() if appropriate.
20217 * expression.cs (LocalVariableReference.DoResolve): Always set
20218 LocalInfo.Used here.
20220 2003-12-13 Martin Baulig <martin@ximian.com>
20222 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20223 any value here; we're now using flow analysis to figure out
20224 whether a statement/block returns a value.
20226 2003-12-13 Martin Baulig <martin@ximian.com>
20228 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20230 (FlowBranching.MergeFinally): Don't call
20231 `branching.CheckOutParameters()' here, this is called in
20233 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20234 when adding the `finally' vector.
20236 2003-12-13 Martin Baulig <martin@ximian.com>
20239 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20240 actually work and also fix #48962.
20242 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20244 * decl.cs: Do not check System.Object for nested types,
20245 since we know it does not have any. Big bang for buck:
20248 Run 1: 8.35 seconds
20249 Run 2: 8.32 seconds
20250 corlib: 17.99 seconds
20252 Run 1: 8.17 seconds
20253 Run 2: 8.17 seconds
20254 corlib: 17.39 seconds
20256 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20258 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20259 time we are returning 0 members, so we save alot here.
20261 2003-12-11 Martin Baulig <martin@ximian.com>
20263 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20264 `MergeChild()', also just take the `FlowBranching' as argument;
20265 call Merge() on it and return the result.
20266 (FlowBranching.Merge): We don't need to do anything if we just
20269 2003-12-11 Martin Baulig <martin@ximian.com>
20271 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20272 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20273 Maurer for this idea.
20275 2003-12-11 Martin Baulig <martin@ximian.com>
20277 * flowanalysis.cs (MergeResult): This class is now gone; we now
20278 use the `UsageVector' for this. The reason for this is that if a
20279 branching just has one sibling, we don't need to "merge" them at
20280 all - that's the next step to do.
20281 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20284 2003-12-11 Martin Baulig <martin@ximian.com>
20286 Reworked flow analyis and made it more precise and bug-free. The
20287 most important change is that we're now using a special `Reachability'
20288 class instead of having "magic" meanings of `FlowReturns'. I'll
20289 do some more cleanups and optimizations and also add some more
20290 documentation this week.
20292 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20293 largely reworked this class.
20294 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20295 the new `Reachability' class instead of having "magic" values here.
20296 (FlowBranching): We're now using an instance of `Reachability'
20297 instead of having separate `Returns', `Breaks' etc. fields.
20299 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20300 based on flow analysis; ignore the return value of block.Emit ().
20302 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20304 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20305 if they are private.
20307 2003-12-09 Martin Baulig <martin@ximian.com>
20309 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20310 call them directly on the UsageVector.
20312 2003-12-09 Martin Baulig <martin@ximian.com>
20314 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20315 Changed return type from `FlowReturns' to `Reachability'.
20317 2003-12-09 Martin Baulig <martin@ximian.com>
20319 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20320 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20321 `Reachable' fields with a single `Reachability' one.
20323 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20325 * class.cs (FindMembers): Remove foreach's.
20330 Run 1: 8.74 seconds
20331 Run 2: 8.71 seconds
20334 Run 1: 8.64 seconds
20335 Run 2: 8.58 seconds
20338 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20343 This patch does a few things:
20344 1. EmptyStatement is now a singleton, so it is never reallocated.
20345 2. All blah is EmptyStatement constructs have been changed to
20346 blah == EmptyStatement.Value, which is much faster and valid
20347 now that EmptyStatement is a singleton.
20348 3. When resolving a block, rather than allocating a new array for
20349 the non-empty statements, empty statements are replaced with
20350 EmptyStatement.Value
20351 4. Some recursive functions have been made non-recursive.
20352 Mainly the performance impact is from (3), however (1) and (2) are needed for
20353 this to work. (4) does not make a big difference in normal situations, however
20354 it makes the profile look saner.
20359 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20360 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20361 Total memory allocated: 56397 KB
20364 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20365 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20366 Total memory allocated: 55666 KB
20368 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20370 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20371 than the hashtable in a hashtable version
20373 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20374 we always end up concating a string. This results in a huge perf
20375 loss, because many strings have to be tracked by the GC. In this
20376 patch, we first use a hashtable that works with two keys, so that
20377 the strings do not need to be concat'ed.
20381 Run 1: 8.74 seconds
20382 Run 2: 8.71 seconds
20385 Run 1: 8.65 seconds
20386 Run 2: 8.56 seconds
20388 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20390 * Makefile: Add a new target `do-time' that does a quick and simple
20391 profile, leaving easy to parse output.
20393 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20395 * codegen.cs (Init): Create the dynamic assembly with
20396 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20398 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20400 * support.cs: Make the PtrHashtable use only one
20401 instance of its comparer.
20403 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20405 * typemanager.cs: Fix lookup of GetNamespaces.
20407 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20409 * expression.cs: Removed redundant line.
20411 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20412 ArrayLists, use for loops with bounds.
20414 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20417 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20418 arraylists, use for loop with bounds.
20420 The above three changes give us a 0.071 second performance
20421 improvement out of 3.294 seconds down to 3.223. On my machine
20422 the above changes reduced the memory usage by 1,387 KB during
20423 compiler bootstrap.
20425 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20426 QualifiedIdentifiers. Before we created a new string through
20427 concatenation, and mostly later on, the result would be
20428 manipulated by DecomposeQI through string manipulation.
20430 This reduced the compiler memory usage for bootstrapping from
20431 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20432 compile times in 0.05 seconds.
20434 2003-11-28 Dick Porter <dick@ximian.com>
20436 * support.cs: Do string compares with the Invariant culture.
20444 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20445 the comparison is done with the Invariant culture.
20447 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20449 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20450 GetEnumerator method.
20452 (ProbeCollectionType): Iterate starting at the most specific type
20453 upwards looking for a GetEnumerator
20455 * expression.cs: Shift count can be up to 31 for int/uint and 63
20458 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20460 * statement.cs (Block.LookupLabel): Also look for the label on the
20461 children blocks. Use a hash table to keep track of visited
20464 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20465 we actually did transform the other operand, otherwise fall back
20466 to the common codepath that casts to long.
20468 * cs-tokenizer.cs: Use the same code pattern as the int case.
20469 Maybe I should do the parsing myself, and avoid depending on the
20470 Parse routines to get this done.
20472 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20474 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20475 which fixes bug 51347. This time test it.
20477 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20478 attributes for example can not tell the difference between these.
20479 The difference was only a syntax feature of the language.
20481 * attribute.cs: Apply attributes to delegates.
20483 * delegate.cs: Call the apply attributes method.
20485 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20487 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20488 comparing 0 vs Byte.MinValue, not the value
20490 (ImplicitConversionRequired): When reporting a conversion error,
20491 use error 31 to print out the constant error instead of the
20494 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20495 which fixes bug 51347.
20497 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20499 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20500 which fixes the -warnaserror command line option.
20502 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20504 * cfold.cs (DoNumericPromotions): During constant folding of
20505 additions on UIntConstant, special case intconstants with
20506 IntConstants like we do on the expression binary operator.
20508 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20510 * convert.cs (ImplicitReferenceConversion): We were missing a case
20511 (System.Enum are not value types or class types, so we need to
20512 classify them separatedly).
20514 * driver.cs: We do not support error 2007.
20516 2003-11-12 Jackson Harper <jackson@ximian.com>
20518 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20519 system directory. Also use the full file name so users can
20520 libraries names mscorlib-o-tron.dll in a non system dir.
20522 2003-11-10 Martin Baulig <martin@ximian.com>
20524 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20525 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20526 calling `ResolveType()' on them, directly assign their `Type'.
20528 2003-11-08 Martin Baulig <martin@ximian.com>
20530 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20531 return value and the `out parent' parameter.
20532 (TypeContainer.DefineType): Moved the CS0644 check into
20533 GetClassBases(). Don't pass the interface types to the
20534 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20535 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20537 * ecore.cs (TypeExpr.IsAttribute): New property.
20538 (TypeExpr.GetInterfaces): New method.
20540 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20541 TypeExpr instead of a Type.
20542 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20543 (Interface.DefineType): Don't pass the interface types to the
20544 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20545 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20547 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20548 instead of a `Type[]'.
20549 (TypeManager.RegisterBuilder): Likewise.
20550 (TypeManager.AddUserInterface): Likewise.
20551 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20552 `Type[]' and also return a `TypeExpr[]'.
20553 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20555 2003-11-08 Martin Baulig <martin@ximian.com>
20557 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20560 2003-11-08 Martin Baulig <martin@ximian.com>
20562 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20563 TypeManager.ResolveExpressionTypes().
20565 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20566 instead of an Expression.
20567 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20568 (TypeExpression): New public class; formerly known as `TypeExpr'.
20570 * expression.cs (ComposedCast): Derive from TypeExpr.
20572 * typemanager.cs (TypeManager.system_*_expr): These are now
20573 TypExpr's instead of Expression's.
20574 (TypeManager.ResolveExpressionTypes): New public static function;
20575 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20578 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20580 * expression.cs (New.DoResolve): Do not dereference value that
20581 might be a null return.
20583 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20584 sure that the constant value has the right type. Fixes an
20585 unreported bug, similar to 50425.
20587 * const.cs (Const.LookupConstantValue): Call
20588 ImplicitStandardConversionExists before doing a conversion to
20589 avoid havng the TypeManager.ChangeType do conversions.
20591 Reduced the number of casts used
20593 (Const.ChangeType): New routine to enable reuse of the constant
20594 type changing code from statement.
20596 * typemanager.cs (ChangeType): Move common initialization to
20597 static global variables.
20601 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20602 every value type to go through, even if it was void. Fix that.
20604 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20605 character of the define, and the is_identifier_part_character for
20606 the rest of the string.
20608 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20610 * expression.cs (UnaryMutator.EmitCode): When I updated
20611 LocalVariableReference.DoResolve, I overdid it, and dropped an
20612 optimization done on local variable references.
20614 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20616 * ecore.cs: Convert the return from Ldlen into an int.
20618 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20620 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20621 the accessibility, this is a special case for toplevel non-public
20622 classes (internal for instance).
20624 2003-10-20 Nick Drochak <ndrochak@gol.com>
20626 * ecore.cs: Fix typo and build. Needed another right paren.
20628 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20630 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20631 `internal' case regular and protected, but not allowing protected
20632 to be evaluated later. Bug 49840
20634 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20636 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20637 to kb.Nlast, and not the kb.nFirst to isolate the switch
20640 Extract the underlying type, so enumerations of long/ulong are
20641 treated like long/ulong.
20643 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20645 * expression.cs (New): Overload the meaning of RequestedType to
20646 track the possible creation of the NewDelegate type, since
20647 DoResolve is invoked more than once for new constructors on field
20650 See bugs: #48800 and #37014
20652 * cs-parser.jay (declare_local_constants): Take an arraylist
20653 instead of a single constant.
20655 (local_constant_declaration): It should take a
20656 constant_declarators, not a constant_declarator. Fixes 49487
20658 * convert.cs: Fix error report.
20660 2003-10-13 Jackson Harper <jackson@ximian.com>
20662 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20665 2003-10-09 Martin Baulig <martin@ximian.com>
20667 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20669 (MethodCore.DoDefineParameters): Removed the TypeContainer
20670 argument; use the DeclSpace which was passed to the .ctor instead.
20671 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20672 TypeContainer; we only need a DeclSpace here.
20674 2003-10-09 Martin Baulig <martin@ximian.com>
20676 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20678 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20679 EmitContext's .ctor.
20681 2003-10-09 Martin Baulig <martin@ximian.com>
20683 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20684 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20685 AsAccessible(), moved them as well.
20687 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20689 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20691 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20693 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20695 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20696 generation for >=, as spotted by Paolo, bug 48679.
20697 Patch from David Waite.
20699 * cs-tokenizer.cs: Add handling for #pragma.
20701 * cs-parser.jay: Allow for both yield and yield return in the
20702 syntax. The anti-cobolization of C# fight will go on!
20704 * class.cs (TypeBuilder.DefineType): Catch error condition here
20705 (Parent.DefineType erroring out and returning null).
20707 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20708 coping with enumerations variables, we were mistakenly processing
20709 them as a regular value type instead of built-in types. Fixes the
20712 * typemanager.cs (IsBuiltinOrEnum): New method.
20714 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20716 * cs-parser.jay: Upgrade: yield now needs the return clause.
20718 2003-09-19 Martin Baulig <martin@ximian.com>
20720 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20721 `MemberCache parent' argument. Normally, an interface doesn't
20722 have a parent type except System.Object, but we use this in gmcs
20723 for generic type parameters.
20725 2003-09-18 Martin Baulig <martin@ximian.com>
20727 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
20728 on `type.IsInterface'; don't check whether the type has a parent
20729 to determine whether it's an interface.
20731 2003-09-15 Martin Baulig <martin@ximian.com>
20733 * class.cs (TypeContainer.DefineType): Added an error flag to
20734 avoid reporting duplicate CS0146's ("class definition is
20737 * driver.cs (Driver.MainDriver): Abort if
20738 RootContext.ResolveTree() reported any errors.
20740 2003-09-07 Martin Baulig <martin@ximian.com>
20742 * report.cs (Error, Warning): Added overloaded versions which take
20743 a `params object[] args' and call String.Format().
20745 2003-09-07 Martin Baulig <martin@ximian.com>
20747 * decl.cs (DeclSpace..ctor): Don't call
20748 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
20749 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
20750 (DeclSpace.RecordDecl): New method.
20752 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
20754 2003-09-02 Ravi Pratap <ravi@ximian.com>
20756 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
20757 value attributes to be applied to ParameterBuilders.
20759 * class.cs (MethodCore.LabelParameters): Make static and more
20760 generic so that it can be used from other places - like interface
20761 methods, for instance.
20763 * interface.cs (Interface.Emit): Call LabelParameters before
20764 emitting attributes on the InterfaceMethod.
20766 2003-08-26 Martin Baulig <martin@ximian.com>
20768 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
20769 resolving aliases; fixes #47927.
20771 2003-08-26 Martin Baulig <martin@ximian.com>
20773 * statement.cs (Using.DoResolve): This is internally emitting a
20774 try/finally clause, so we need to set ec.NeedExplicitReturn if we
20775 do not always return. Fixes #47681.
20777 2003-08-26 Martin Baulig <martin@ximian.com>
20779 * decl.cs (MemberCore): Moved WarningNotHiding(),
20780 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
20782 (AdditionResult): Make this nested in DeclSpace.
20783 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
20784 argument; call NamespaceEntry.Define() unless we're nested in a
20787 * namespace.cs (Namespace.DefineName): New public function. This
20788 is called from DeclSpace's .ctor to add
20789 (Namespace.Lookup): Include DeclSpaces in the lookup.
20791 * class.cs (Operator): Derive from MemberBase, not MemberCore.
20793 * const.cs (Const): Derive from MemberBase, not MemberCore.
20795 2003-08-25 Martin Baulig <martin@ximian.com>
20797 * convert.cs (Convert.ExplicitReferenceConversion): When
20798 converting from an interface type to a class, unbox if the target
20799 type is a struct type. Fixes #47822.
20801 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20803 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
20806 2003-08-22 Martin Baulig <martin@ximian.com>
20808 * class.cs (TypeManager.DefineType): When defining a nested type,
20809 call DefineType() on our parent; fixes #47801.
20811 2003-08-22 Martin Baulig <martin@ximian.com>
20813 * class.cs (MethodData.Define): While checking if a method is an
20814 interface implementation, improve the test a bit more to fix #47654.
20816 2003-08-22 Martin Baulig <martin@ximian.com>
20818 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
20819 correctly; fixes #47722.
20821 2003-08-22 Martin Baulig <martin@ximian.com>
20823 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
20824 LocalVariableReference, ensure it's not read-only. Fixes #47536.
20826 * statement.cs (Fixed.DoResolve): Make all variables read-only.
20828 2003-08-22 Martin Baulig <martin@ximian.com>
20830 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
20831 can only be assigned in static constructors. Fixes #47161.
20833 2003-08-22 Martin Baulig <martin@ximian.com>
20835 Rewrote and improved the flow analysis code.
20837 * flowbranching.cs (FlowBranching): Make this class abstract.
20838 (FlowBranching.CreateBranching): New static function to create a
20839 new flow branching.
20840 (FlowBranchingBlock, FlowBranchingException): New classes.
20841 (FlowBranching.UsageVector.Type): New public readonly field.
20842 (FlowBranching.UsageVector.Breaks): Removed the setter.
20843 (FlowBranching.UsageVector.Returns): Removed the setter.
20844 (FlowBranching.UsageVector): Added Break(), Return(),
20845 NeverReachable() and Throw() methods to modify the reachability.
20846 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
20847 done by FlowBranching.Merge().
20848 (FlowBranching.UsageVector.MergeChild): New method; merges the
20849 merge result into the current vector.
20850 (FlowBranching.Merge): New abstract method to merge a branching.
20852 2003-08-12 Martin Baulig <martin@ximian.com>
20854 * expression.cs (Indirection.CacheTemporaries): Create the
20855 LocalTemporary with the pointer type, not its element type.
20857 2003-08-10 Miguel de Icaza <miguel@ximian.com>
20859 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
20860 token was a keyword or not.
20862 Add `error' options where an IDENTIFIER was expected; Provide
20863 CheckToken and CheckIdentifierToken convenience error reporting
20866 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
20868 * decl.cs: Rename `NamespaceEntry Namespace' public field into
20869 NameSpaceEntry NameSpaceEntry.
20871 (LookupInterfaceOrClass): Avoid creating a full qualified name
20872 from namespace and name: avoid doing lookups when we know the
20873 namespace is non-existant. Use new Tree.LookupByNamespace which
20874 looks up DeclSpaces based on their namespace, name pair.
20876 * driver.cs: Provide a new `parser verbose' to display the
20877 exception thrown during parsing. This is turned off by default
20878 now, so the output of a failure from mcs is more graceful.
20880 * namespace.cs: Track all the namespaces defined in a hashtable
20883 (IsNamespace): New method
20885 2003-08-09 Miguel de Icaza <miguel@ximian.com>
20887 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
20888 we know that we need to concatenate (full typename can never be
20893 * statement.cs: Use a bitfield; Do not initialize to null things
20894 which are done by the constructor by default.
20896 * cs-parser.jay: bug fix, parameter was 4, not 3.
20898 * expression.cs: Just use the property;
20900 * statement.cs: No need for GetVariableInfo method.
20902 2003-08-08 Martin Baulig <martin@ximian.com>
20904 * flowanalysis.cs (FlowReturns): This is now nested in the
20905 `FlowBranching' class.
20906 (MyBitVector): Moved this here from statement.cs.
20907 (FlowBranching.SiblingType): New enum type.
20908 (FlowBranching.CreateSibling): Added `SiblingType' argument.
20910 2003-08-07 Martin Baulig <martin@ximian.com>
20912 * flowanalysis.cs (FlowBranchingType): This is now nested in the
20913 `FlowBranching' class and called `BranchingType'.
20915 2003-08-07 Martin Baulig <martin@ximian.com>
20917 * flowanalysis.cs: Moved all the control flow analysis code into
20920 2003-08-07 Martin Baulig <martin@ximian.com>
20922 * assign.cs (Assign.DoResolve): `target' must either be an
20923 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
20926 2003-08-07 Miguel de Icaza <miguel@ximian.com>
20928 * expression.cs (BinaryMethod): This kind of expression is created by the
20929 Binary class if it determines that the operator has to be handled
20932 (BinaryDelegate): This kind of expression is created if we are
20933 dealing with a + or - operator on delegates.
20935 (Binary): remove method, argumetns, and DelegateOperator: when
20936 dealing with methods,
20938 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
20940 * statement.cs (Block): use bitfields for the three extra booleans
20941 we had in use. Remove unused topblock parameter.
20943 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
20945 * assign.cs: Drop extra unneeded tests.
20947 2003-08-06 Miguel de Icaza <miguel@ximian.com>
20949 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
20951 * statement.cs (Foreach): Use VariableStorage instead of
20954 * codegen.cs (VariableStorage): New class used by clients that
20955 require a variable stored: locals or fields for variables that
20956 need to live across yield.
20958 Maybe provide a convenience api for EmitThis+EmitLoad?
20960 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
20963 2003-08-05 Miguel de Icaza <miguel@ximian.com>
20965 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
20966 RemapParameterLValue): New methods that are used to turn a
20967 precomputed FieldInfo into an expression like this:
20971 The idea is to use this instead of making LocalVariableReference
20972 have more than one meaning.
20974 * cs-parser.jay: Add error production to BASE.
20976 * ecore.cs: Deal with TypeManager.GetField returning null, which
20977 is now a valid return value.
20979 (FieldExprNoAddress): New expression for Fields whose address can
20982 * expression.cs (LocalVariableReference): During the resolve
20983 phases, create new expressions if we are in a remapping context.
20984 Remove code that dealt with remapping here.
20986 (ParameterReference): same.
20988 (ProxyInstance): New expression, like the `This' expression, but
20989 it is born fully resolved. We know what we are doing, so remove
20990 the errors that are targeted to user-provided uses of `this'.
20992 * statement.cs (Foreach): our variable is now stored as an
20993 Expression; During resolution, follow the protocol, dont just
20994 assume it will return this.
20996 2003-08-06 Martin Baulig <martin@ximian.com>
20998 * support.cs (SeekableStreamReader.cs): New public class.
21000 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21001 SeekableStreamReader instead of the normal StreamReader.
21003 2003-08-04 Martin Baulig <martin@ximian.com>
21005 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21006 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21007 deambiguate casts and delegate invocations.
21008 (parenthesized_expression): Use the new tokens to ensure this is
21009 not a cast of method invocation.
21011 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21012 when reading a `)' and Deambiguate_CloseParens () was previously
21015 * expression.cs (ParenthesizedExpression): New class. This is
21016 just used for the CS0075 test.
21017 (Binary.DoResolve): Check for CS0075.
21019 2003-07-29 Ravi Pratap <ravi@ximian.com>
21021 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21022 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21023 reference comparison.
21025 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21026 examine the ReturnType for equality - this is necessary in the
21027 cases of implicit and explicit operators whose signature also
21028 includes the return type.
21030 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21032 * namespace.cs: Cache the result of the namespace computation,
21033 instead of computing it every time.
21035 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21037 * decl.cs: Use a global arraylist that we reuse over invocations
21038 to avoid excesive memory consumption. Reduces memory usage on an
21039 mcs compile by one meg (45 average).
21041 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21042 private, work around that.
21044 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21046 * literal.cs (IntLiteral): Define Zero and One static literals.
21048 * cs-parser.jay (integer_literal): use static literals to reduce
21049 memory usage for the most used literals (0, 1 and -1). 211kb
21050 reduced in memory usage.
21052 Replace all calls to `new ArrayList' with `new
21053 ArrayList(4)' which is a good average number for most allocations,
21054 and also requires only 16 bytes of memory for its buffer by
21057 This reduced MCS memory usage in seven megabytes for the RSS after
21060 2003-07-28 Ravi Pratap <ravi@ximian.com>
21062 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21063 handle params methods the correct way by forming only one
21064 applicable set with params and normal methods in them. Earlier we
21065 were looking at params methods only if we found no normal methods
21066 which was not the correct thing to do.
21068 (Invocation.BetterFunction): Take separate arguments indicating
21069 when candidate and the best method are params methods in their
21072 This fixes bugs #43367 and #46199.
21074 * attribute.cs: Documentation updates.
21076 (CheckAttribute): Rename to CheckAttributeTarget.
21077 (GetValidPlaces): Rename to GetValidTargets.
21079 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21080 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21084 2003-07-28 Martin Baulig <martin@ximian.com>
21086 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21087 name when looking up the base class of a nested class. Fixes #46977.
21089 2003-07-26 Martin Baulig <martin@ximian.com>
21091 * expression.cs (Indexers.Indexer): New nested struct; contains
21092 getter, setter and the indexer's type.
21093 (Indexers.Properties): This is now an ArrayList of
21094 Indexers.Indexer's.
21095 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21096 indexer doesn't have any getters.
21098 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21099 for embedded property and indexer assignments.
21101 2003-07-26 Martin Baulig <martin@ximian.com>
21103 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21104 preprocessor directive is not the first non-whitespace character
21107 2003-07-26 Martin Baulig <martin@ximian.com>
21109 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21110 namespace parsing, follow the spec more closely.
21112 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21113 NamespaceEntry.Lookup().
21115 2003-07-25 Martin Baulig <martin@ximian.com>
21117 * MethodCore.cs (OverridesSomething): New public field; it's set
21118 from TypeContainer.DefineMembers if this method overrides
21119 something (which doesn't need to be a method). Fix #39462.
21121 2003-07-25 Ravi Pratap <ravi@ximian.com>
21123 * typemanager.cs (GetMembers): Ensure that the list of members is
21124 reversed. This keeps things in sync.
21126 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21127 find an AttributeUsage attribute.
21129 * expression.cs (Invocation.OverloadResolve): Perform the check
21130 which disallows Invoke to be directly called on a Delegate.
21132 (Error_InvokeOnDelegate): Report error cs1533.
21134 2003-07-25 Martin Baulig <martin@ximian.com>
21136 * expression.cs (Indexers.GetIndexersForType): Only look in the
21137 interface hierarchy if the requested type is already an
21138 interface. Fixes #46788 while keeping #46502 fixed.
21140 2003-07-25 Martin Baulig <martin@ximian.com>
21142 * class.cs (TypeContainer.DefineMembers): Check whether all
21143 readonly fields have been assigned and report warning CS0649 if
21146 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21149 2003-07-24 Ravi Pratap <ravi@ximian.com>
21151 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21152 returned from GetMethods to make things consistent with the
21153 assumptions MCS makes about ordering of methods.
21155 This should comprehensively fix bug #45127 and it does :-)
21157 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21158 ordering is actually reverse.
21160 * Clean up some debug messages I left lying around.
21162 * interface.cs (Populate*): Get rid of code which emits attributes
21163 since the stage in which we emit attributes is the 'Emit' stage,
21164 not the define stage.
21166 (Emit): Move attribute emission for interface members here.
21168 2003-07-22 Ravi Pratap <ravi@ximian.com>
21170 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21171 closely: we eliminate methods in base types when we have an
21172 applicable method in a top-level type.
21174 Please see section 14.5.5.1 for an exact description of what goes
21177 This fixes bug #45127 and a host of other related to corlib compilation.
21179 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21180 array is the method corresponding to the top-level type (this is
21181 because of the changes made to icall.c) so we change this
21184 (MethodGroupExpr.Name): This too.
21186 * typemanager.cs (GetElementType): New method which does the right
21187 thing when compiling corlib.
21189 * everywhere: Make use of the above in the relevant places.
21191 2003-07-22 Martin Baulig <martin@ximian.com>
21193 * cs-parser.jay (invocation_expression): Moved
21194 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21195 `cast_expression', but create a InvocationOrCast which later
21196 resolves to either an Invocation or a Cast.
21198 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21199 method; call this before EmitStatement() to make sure that this
21200 expression can be used as a statement.
21202 * expression.cs (InvocationOrCast): New class; resolves to either
21203 an Invocation or a Cast.
21205 * statement.cs (StatementExpression): Call ResolveStatement() on
21206 the ExpressionStatement before emitting it.
21208 2003-07-21 Martin Baulig <martin@ximian.com>
21210 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21211 `ref' and `out' attributes match; fixes #46220.
21212 (MemberAccess.ResolveMemberAccess): You can't reference a type
21213 through an expression; fixes #33180.
21214 (Indexers.GetIndexersForType): Don't return the indexers from
21215 interfaces the class implements; fixes #46502.
21217 2003-07-21 Martin Baulig <martin@ximian.com>
21219 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21220 CS0661 checks; fixes bug #30442.
21222 2003-07-21 Martin Baulig <martin@ximian.com>
21224 * decl.cs (AdditionResult): Added `Error'.
21226 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21228 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21229 makes cs0031.cs actually work.
21231 2003-07-20 Martin Baulig <martin@ximian.com>
21233 * namespace.cs: Fixed that bug which caused a crash when compiling
21234 the debugger's GUI.
21236 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21238 * typemanager.cs (LookupTypeReflection): Never expose types which
21239 are NotPublic, NestedPrivate, NestedAssembly, or
21240 NestedFamANDAssem. We used to return these, and later do a check
21241 that would report a meaningful error, but the problem is that we
21242 would not get the real match, if there was a name override.
21244 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21246 * namespace.cs (Namespace, Name): Do not compute the namespace
21247 name dynamically, compute it in the constructor. This reduced
21248 memory usage by 1697 KB.
21250 * driver.cs: Use --pause to pause at the end.
21252 2003-07-17 Peter Williams <peter@newton.cx>
21254 * Makefile: Change the name of the test target so that it doesn't
21255 conflict with the recursive test target.
21257 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21259 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21260 AddressOf): Do not use EmitThis, that was wrong, use the actual
21263 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21265 * class.cs (MethodData.Define): While checking if a method is an
21266 interface implementation, improve the test: If we are not public
21267 (use new test here: use the computed MethodAttributes directly,
21268 instead of the parsed modifier flags) check if the `implementing'
21269 method comes from an interface or not.
21271 * pending.cs (VerifyPendingMethods): Slightly better error
21274 * makefile: add test target that does the mcs bootstrap.
21276 2003-07-16 Ravi Pratap <ravi@ximian.com>
21278 * interface.cs (Define): Do nothing here since there are no
21279 members to populate etc. Move the attribute emission out of here
21280 since this was just totally the wrong place to put it. Attribute
21281 application happens during the 'Emit' phase, not in the 'Define'
21284 (Emit): Add this method and move the attribute emission here
21286 * rootcontext.cs (EmitCode): Call the Emit method on interface
21289 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21291 * expression.cs (OverloadResolve): Report error only if Location
21292 is not 'Null' which means that there was a probe going on.
21294 2003-07-14 Martin Baulig <martin@ximian.com>
21296 * expression.cs (ConditionalLogicalOperator): New public class to
21297 implement user defined conditional logical operators.
21298 This is section 14.11.2 in the spec and bug #40505.
21300 2003-07-14 Martin Baulig <martin@ximian.com>
21302 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21304 2003-07-14 Martin Baulig <martin@ximian.com>
21306 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21308 * ecore.cs (IVariable.VerifyFixed): New interface method.
21310 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21311 operator, check whether the variable is actually fixed. Fixes bug
21312 #36055. Set a variable definitely assigned when taking its
21313 address as required by the spec.
21315 * statement.cs (LocalInfo.IsFixed): New field.
21316 (LocalInfo.MakePinned): Set `IsFixed' to true.
21318 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21320 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21321 for .ctors, ensure that we only ask for members declared in the
21322 attribute type (BindingFlags.DeclaredOnly).
21326 * expression.cs (Error_WrongNumArguments): Report error 1501
21327 correctly the way CSC does.
21329 2003-07-13 Martin Baulig <martin@ximian.com>
21331 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21332 lookup on the fully qualified name, to make things like "X.X" work
21333 where "X.X" is a fully qualified type name, but we also have a
21334 namespace "X" in the using list. Fixes #41975.
21336 2003-07-13 Martin Baulig <martin@ximian.com>
21338 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21339 function. If we're a CompoundAssign, we need to create an embedded
21340 CompoundAssign, not an embedded Assign.
21341 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21344 2003-07-13 Martin Baulig <martin@ximian.com>
21346 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21347 work to fix bug #46088.
21349 2003-07-13 Ravi Pratap <ravi@ximian.com>
21351 * class.cs (Operator.Emit): Do not emit attributes here - it is
21352 taken care of by the Method class that we delegate too. This takes
21353 care of bug #45876.
21355 2003-07-10 Martin Baulig <martin@ximian.com>
21357 * expression.cs (TypeOfVoid): New class.
21358 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21360 2003-07-10 Martin Baulig <martin@ximian.com>
21362 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21365 2003-07-10 Martin Baulig <martin@ximian.com>
21367 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21368 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21370 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21372 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21374 2003-07-10 Martin Baulig <martin@ximian.com>
21376 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21377 of decimal. Fixes #42850.
21379 NOTE: I also fixed the created byte blob, but this doesn't work on
21380 the MS runtime and csc never produces any byte blobs for decimal
21383 2003-07-10 Martin Baulig <martin@ximian.com>
21385 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21386 structs; fixes #32068.
21387 (Block.AddChildVariableNames): Fixed #44302.
21389 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21391 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21393 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21395 * attribute.cs: And this test is onger needed.
21397 2003-07-08 Martin Baulig <martin@ximian.com>
21399 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21400 inaccessible types. Fixes #36313.
21402 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21404 * namespace.cs (NamespaceEntry): Create implicit entries for all
21405 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21406 implicit entries for N1.N2 and N1.
21408 2003-07-08 Martin Baulig <martin@ximian.com>
21410 Rewrote the handling of namespaces to fix a lot of the issues
21411 wrt. `using' aliases etc.
21413 * namespace.cs (Namespace): Splitted this class into a
21414 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21416 * typemanager.cs (TypeManager.IsNamespace): Removed.
21417 (TypeManager.ComputeNamespaces): Only compute namespaces from
21418 loaded assemblies here, not the namespaces from the assembly we're
21419 currently compiling.
21421 2003-07-08 Martin Baulig <martin@ximian.com>
21423 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21425 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21427 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21430 I thought about the memory savings here, but LookupTypeReflection
21431 is used under already very constrained scenarios. Compiling
21432 corlib or mcs only exposes one hit, so it would not really reduce
21433 any memory consumption.
21435 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21437 * typemanager.cs: fixes bug #45889 by only adding public types from
21438 other assemblies to the list of known types.
21440 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21442 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21443 on the type we resolved.
21445 2003-07-05 Martin Baulig <martin@ximian.com>
21447 * pending.cs (PendingImplementation.ParentImplements): Don't
21448 create the proxy if the parent is abstract.
21450 * class.cs (TypeContainer.DefineIndexers): Process explicit
21451 interface implementations first. Fixes #37714.
21453 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21455 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21456 defined recursively; but since we modify the input parameters
21457 (left is set to `this' temporarily), we reset this value if the
21458 left_is_explicit is false, which gives the original semantics to
21461 * literal.cs (NullPointer): new class used to represent a null
21462 literal in a pointer context.
21464 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21465 type is a pointer, use a NullPointer object instead of a
21466 NullLiteral. Closes 43687
21468 (ExplicitConversion): Convert pointer values using
21469 the conv opcode to the proper type.
21471 * ecore.cs (New): change ValueTypeVariable property into a method,
21472 that returns whether the valuetype is suitable for being used.
21474 * expression.cs (Binary.DoNumericPromotions): Only return if we
21475 the int constant was a valid uint, and we can return both left and
21476 right as uints. If not, we continue processing, to trigger the
21477 type conversion. This fixes 39018.
21479 * statement.cs (Block.EmitMeta): During constant resolution, set
21480 the CurrentBlock property on the emitcontext, so that we resolve
21481 constants propertly.
21483 2003-07-02 Martin Baulig <martin@ximian.com>
21485 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21486 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21488 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21489 than emitting it here.
21491 * statement.cs: Fixed some more flow analysis bugs.
21493 2003-07-02 Martin Baulig <martin@ximian.com>
21495 * class.cs (MethodData.Define): When implementing interface
21496 methods, set Final unless we're Virtual.
21498 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21499 check work for interface methods.
21501 2003-07-01 Martin Baulig <martin@ximian.com>
21503 * ecore.cs (EmitContext.This): Replaced this property with a
21504 GetThis() method which takes a Location argument. This ensures
21505 that we get the correct error location for a CS0188.
21507 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21509 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21510 ImplicitStandardConversion.
21512 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21514 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21516 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21519 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21521 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21524 (MethodData.Define): Turn off initlocals for unsafe methods.
21526 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21528 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21529 complete; Fixes #37521.
21531 * delegate.cs: Use Modifiers.TypeAttr to compute the
21532 TypeAttributes, instead of rolling our own. This makes the flags
21533 correct for the delegates.
21535 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21537 * class.cs (Constructor.Define): Set the private flag for static
21538 constructors as well.
21540 * cs-parser.jay (statement_expression): Set the return value to
21541 null, to avoid a crash when we catch an error.
21543 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21545 * cs-parser.jay: Applied patch from Jackson that adds support for
21546 extern and unsafe modifiers to destructor declarations.
21548 * expression.cs: Report error 21 if the user is trying to index a
21551 * driver.cs: Add an error message, suggested by the bug report.
21553 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21554 if we do not have a ": this ()" constructor initializer. Fixes 45149
21556 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21558 * namespace.cs: Add some information to reduce FAQs.
21560 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21562 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21563 underlying enumeration types. Fixes #43915.
21565 * expression.cs: Treat ushort/short as legal values to be used in
21566 bitwise operations.
21568 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21570 * delegate.cs: transfer custom attributes for paramenters from
21571 the delegate declaration to Invoke and BeginInvoke.
21573 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21575 * attribute.cs: handle custom marshalers and emit marshal info
21578 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21580 * makefile.gnu: Added anonymous.cs to the compiler sources.
21582 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21584 * iterators.cs: Change the name of the proxy class to include two
21587 * cs-parser.jay: Update grammar to include anonymous methods.
21589 * anonymous.cs: new file.
21591 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21593 * class.cs (Field.Define): Add missing test for pointers and
21596 2003-05-27 Ravi Pratap <ravi@ximian.com>
21598 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21599 we use the stobj opcode.
21601 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21602 since it wasn't the correct fix.
21604 It still is puzzling that we are required to use stobj for IntPtr
21605 which seems to be a ValueType.
21607 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21609 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21610 during regular simple name resolution. Now, the trick is that
21611 instead of returning for processing the simplename, we do a
21612 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21613 contextual lookup type). If a match is found, return that, if
21614 not, return for further composition.
21616 This fixes long-standing 30485.
21618 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21619 using the address to initialize an object, do an Stobj instead of
21620 using the regular Stelem.
21622 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21623 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21624 Because if we are a BaseIndexerAccess that value will be true.
21627 * statement.cs (GotoCase.Resolve): Return after reporting an
21628 error, do not attempt to continue.
21630 * expression.cs (PointerArithmetic.Emit): If our operand is a
21631 long, convert our constants to match the operand before
21632 multiplying. Convert to I type before adding. Fixes 43670.
21634 2003-05-14 Ravi Pratap <ravi@ximian.com>
21636 * enum.cs (ImplicitConversionExists) : Rename to
21637 ImplicitEnumConversionExists to remove ambiguity.
21639 * ecore.cs (NullCast): New type of cast expression class which
21640 basically is very similar to EmptyCast with the difference being
21641 it still is a constant since it is used only to cast a null to
21643 (eg. (string) null)
21645 * convert.cs (ImplicitReferenceConversion): When casting a null
21646 literal, we return a NullCast.
21648 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21649 should be around anymore.
21651 The renaming (reported was slightly wrong). Corrections:
21653 ConvertImplicitStandard -> ImplicitConversionStandard
21654 ConvertExplicitStandard -> ExplicitConversionStandard
21656 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21657 before passing them in !
21659 * convert.cs (ImplicitConversionStandard): When comparing for
21660 equal expr and target types, ensure that expr is not a
21663 In general, we must not be checking (expr_type ==
21664 target_type) in the top level conversion methods
21665 (ImplicitConversion, ExplicitConversion etc). This checking is
21666 done in the methods that they delegate to.
21668 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21670 * convert.cs: Move Error_CannotConvertType,
21671 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21672 ImplicitNumericConversion, ImplicitConversionExists,
21673 ImplicitUserConversionExists, StandardConversionExists,
21674 FindMostEncompassedType, FindMostSpecificSource,
21675 FindMostSpecificTarget, ImplicitUserConversion,
21676 ExplicitUserConversion, GetConversionOperators,
21677 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21678 TryImplicitIntConversion, Error_CannotConvertImplicit,
21679 ConvertImplicitRequired, ConvertNumericExplicit,
21680 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21681 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21684 Perform the following renames:
21686 StandardConversionExists -> ImplicitStandardConversionExists
21687 ConvertImplicit -> ImplicitConversion
21688 ConvertImplicitStandard -> ImplicitStandardConversion
21689 TryImplicitIntConversion -> ImplicitIntConversion
21690 ConvertImplicitRequired -> ImplicitConversionRequired
21691 ConvertNumericExplicit -> ExplicitNumericConversion
21692 ConvertReferenceExplicit -> ExplicitReferenceConversion
21693 ConvertExplicit -> ExplicitConversion
21694 ConvertExplicitStandard -> ExplicitStandardConversion
21696 2003-05-19 Martin Baulig <martin@ximian.com>
21698 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21699 (TypeInfo): Added support for structs having structs as fields.
21701 * ecore.cs (FieldExpr): Implement IVariable.
21702 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21703 VariableInfo for the field.
21705 2003-05-18 Martin Baulig <martin@ximian.com>
21707 * expression.cs (This.DoResolve): Report a CS0027 if we're
21708 emitting a field initializer.
21710 2003-05-18 Martin Baulig <martin@ximian.com>
21712 * expression.cs (This.ResolveBase): New public function.
21713 (This.DoResolve): Check for CS0188.
21715 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21718 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21719 `instance_expression' to null if we don't have any non-static
21722 2003-05-18 Martin Baulig <martin@ximian.com>
21724 Reworked the way how local variables and parameters are handled by
21725 the flow analysis code.
21727 * statement.cs (TypeInfo, VariableMap): New public classes.
21728 (VariableInfo): New public class. This is now responsible for
21729 checking whether a variable has been assigned. It is used for
21730 parameters and local variables.
21731 (Block.EmitMeta): Take the InternalParameters as argument; compute
21732 the layout of the flow vectors here.
21733 (Block.LocalMap, Block.ParameterMap): New public properties.
21734 (FlowBranching): The .ctor doesn't get the InternalParameters
21735 anymore since Block.EmitMeta() now computes the layout of the flow
21737 (MyStructInfo): This class is now known as `StructInfo' and nested
21738 in `TypeInfo'; we don't access this directly anymore.
21740 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
21741 property and removed IsAssigned(), IsFieldAssigned(),
21742 SetAssigned() and SetFieldAssigned(); we now call them on the
21743 VariableInfo so we don't need to duplicate this code everywhere.
21745 * expression.cs (ParameterReference): Added `Block block' argument
21747 (LocalVariableReference, ParameterReference, This): The new
21748 VariableInfo class is now responsible for all the definite
21751 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
21752 IsParameterAssigned, SetParameterAssigned): Removed.
21754 2003-05-18 Martin Baulig <martin@ximian.com>
21756 * typemanager.cs (InitCoreTypes): Try calling
21757 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
21758 the 3-args-version. Corlib now also needs our `void_type'.
21759 (GetMethod): Added overloaded version which takes an optional
21760 `bool report_errors' to allow lookups of optional methods.
21762 2003-05-12 Martin Baulig <martin@ximian.com>
21764 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
21765 only used for locals and not for parameters.
21767 2003-05-12 Miguel de Icaza <miguel@ximian.com>
21769 * support.cs (InternalParameters.ParameterType): Return the
21770 ExternalType of the parameter.
21772 * parameter.cs (Parameter.ExternalType): drop the two arguments,
21775 2003-05-11 Miguel de Icaza <miguel@ximian.com>
21777 * class.cs (MethodData.Define): Do not set the `newslot' on
21778 interface members, if they are also flagged as "override".
21780 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
21781 better code for ++i and i++. This only works for static fields
21782 and local variables.
21784 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
21785 want to pull the DeclSpace out of the builder_to_declspace instead
21786 of the TypeBuilder (like in TypeContainer.FindMembers).
21788 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
21789 instead of LookupTypeContainer. Fixes the crash on .NET for
21790 looking up interface members.
21792 * const.cs: Create our own emit context during the Definition
21793 stage, so that constants are evaluated in the proper context, when
21794 a recursive definition happens.
21796 2003-05-11 Martin Baulig <martin@ximian.com>
21798 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
21799 new block for a switch section.
21800 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
21801 the adding/lookup in the switch block. Fixes #39828.
21803 2003-05-09 Miguel de Icaza <miguel@ximian.com>
21805 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
21806 functionality: I needed to convert the data after I had performed
21807 the add/sub operation into the operands type size.
21809 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
21810 pass the type for the box operation, otherwise the resulting
21811 object would have been of type object.
21813 (BoxedCast): Add constructor to specify the type to box as.
21815 2003-05-07 Miguel de Icaza <miguel@ximian.com>
21817 * iterators.cs: I was reusing the `count' variable inadvertently,
21818 take steps to not allow this to happen.
21820 2003-05-06 Miguel de Icaza <miguel@ximian.com>
21822 * attribute.cs (Attribute.Resolve): Params attributes are encoded
21823 by creating an array at the point where the params starts and
21824 putting all those arguments there, then adjusting the size of the
21827 2003-05-05 Miguel de Icaza <miguel@ximian.com>
21829 * expression.cs (New.AddressOf): Implement interface
21830 IMemoryLocation. This is used when the `new' operator is used in
21831 the context of an invocation to a method on a value type.
21833 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
21836 * namespace.cs: Also check the using aliases here.
21838 * driver.cs: Move the test for using validity after the types have
21839 been entered, so we do a single pass that also includes the using
21842 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
21843 in the regular case. CreateSiblingForFinally is doing extra
21846 * attribute.cs (GetAttributeArgumentExpression): Store the result
21847 on an out value, and use the return value to indicate failure
21848 instead of using null (which is a valid return for Constant.GetValue).
21850 * statement.cs: Perform the analysis flow for the increment
21851 portion after the statement, because this will be the real flow of
21852 execution. Fixes #42385
21854 * codegen.cs (EmitContext.EmitArgument,
21855 EmitContext.EmitStoreArgument): New helper functions when the
21856 RemapToProxy flag is set.
21858 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
21861 Add support for remapping parameters.
21863 * iterators.cs: Propagate parameter values; Store parameter
21864 values in the proxy classes.
21866 2003-05-04 Miguel de Icaza <miguel@ximian.com>
21868 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
21869 need a proxy reference; I do not know what I was thinking
21871 * cs-parser.jay (constructor_initializer): catch another error,
21872 and display nice message.
21874 (field_declaration): catch void field declaration
21875 to flag a better error.
21877 * class.cs (MemberBase.CheckBase): Report an error instead of a
21878 warning if a new protected member is declared in a struct.
21879 (Field.Define): catch the error of readonly/volatile.
21881 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
21883 (FieldExpr.AddressOf): ditto. Catch error where the address of a
21884 volatile variable is taken
21886 2003-05-02 Miguel de Icaza <miguel@ximian.com>
21888 * statement.cs (Fixed.Resolve): Report an error if we are not in
21891 2003-05-01 Miguel de Icaza <miguel@ximian.com>
21893 * typemanager.cs: reuse the code that handles type clashes for
21894 delegates and enumerations.
21896 * class.cs (Report28): Always report.
21898 * expression.cs (EncodeAsAttribute): Allow nulls here.
21900 2003-04-28 Miguel de Icaza <miguel@ximian.com>
21902 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
21903 the functionality for testing whether an expression is valid for
21904 an attribute here. Also handle the case of arrays of elements
21907 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
21908 encoding a linear array into an array of objects that are suitable
21909 to be passed to an CustomAttributeBuilder.
21911 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
21913 * ecore.cs: (FieldExpr): Handle field remapping here.
21915 * iteratators.cs: Pass the instance variable (if the method is an
21916 instance method) to the constructors, so we can access the field
21917 variables on the class.
21919 TODO: Test this with structs. I think the THIS variable on
21920 structs might have to be a pointer, and not a refenrece
21922 2003-04-27 Miguel de Icaza <miguel@ximian.com>
21924 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
21925 local variables to fields in a proxy class.
21927 * iterators.cs (PopulateProxy): Rename our internal fields to
21929 Create a <THIS> field if we are an instance method, so we can
21930 reference our parent container variables.
21931 (MapVariable): Called back from the EmitContext code to enter a
21932 new variable to field mapping into the proxy class (we just create
21936 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
21937 for using the remapped locals to fields.
21939 I placed the code here, because that gives the same semantics to
21940 local variables, and only changes the Emit code.
21942 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
21943 statements inside iterators.
21944 (VariableInfo): Add a FieldBuilder for the cases when we are
21945 remapping local variables to fields in a proxy class
21947 * ecore.cs (SimpleNameResolve): Avoid testing two times for
21948 current_block != null.
21950 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
21951 not cope with strings, as it has been moved to the
21952 TableSwitchEmit. Fixed bug in switch generation.
21954 * expression.cs (New.DoResolve): Provide more context for the user
21955 when reporting an error.
21957 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
21960 * expression.cs (MemberAccess.DoResolve): When we get a type back,
21961 check the permissions for it. Note than in a type-resolution
21962 context the check was already present in DeclSpace.ResolveType,
21963 but was missing from the MemberAccess.
21965 (ArrayCreation.CheckIndices): warn if the user has
21966 more nested levels of expressions, but there are no more
21967 dimensions specified. Avoids crash on bug 41906.
21969 2003-04-26 Miguel de Icaza <miguel@ximian.com>
21971 * statement.cs (Block): replace Implicit bool, for a generic
21973 New flag: `Unchecked'. This is used during the EmitMeta phase
21974 (which is out-of-line with the regular Resolve/Emit process for a
21975 statement, as this is done ahead of time, but still gets a chance
21976 to call constant resolve).
21978 (Block.Flags): new enum for adding a new flag.
21980 (Block.EmitMeta): track the state of unchecked.
21982 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
21983 to enable constant resolution to work there as well.
21985 2003-04-22 Miguel de Icaza <miguel@ximian.com>
21987 * typemanager.cs (ienumerable_type): Also look up
21988 System.Collections.IEnumerable.
21990 2003-04-21 Miguel de Icaza <miguel@ximian.com>
21992 TODO: Test more than one conditional per method.
21994 * class.cs (Indexer.Define): Report the location where the user is
21995 referencing the unsupported feature.
21997 (MethodData): Overload the use of `conditionals' to
21998 minimize the creation of needless ArrayLists. This saves roughly
21999 212kb on my machine.
22001 (Method): Implement the new IIteratorContainer interface.
22002 (Method.SetYields): Implement the method by setting the ModFlags
22003 to contain METHOD_YIELDS.
22005 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22006 which just got set to null.
22008 * iterators.cs: New file.
22010 (Yield, YieldBreak): New statements.
22012 * statement.cs (Return.Resolve): Flag an error if we are used in
22013 an iterator method.
22015 * codegen.cs (InIterator): New flag set if the code is being
22016 compiled in an iterator method.
22018 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22019 internal modifier, and we just use it to avoid adding extra
22020 fields, as this is seldom used.
22022 * cs-parser.jay: Add yield_statement (yield and yield break).
22024 * driver.cs: New flag -v2 to turn on version 2 features.
22026 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22027 hashtable when v2 is enabled.
22029 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22031 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22032 there is already a namespace defined with this name.
22034 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22035 people upgraded their corlibs.
22037 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22038 always use fully qualified types, no need to use the compiler
22041 (TypeManager.IsNamespace): Use binarysearch.
22043 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22044 AddDelegate): I did not quite use the new IsValid API properly: I
22045 have to pass the short-name and the fullname. I was passing only
22046 the basename instead of the fullname sometimes.
22048 (TypeContainer.DefineType): call NamespaceClash.
22050 * interface.cs (Interface.DefineType): use NamespaceClash before
22053 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22056 * enum.cs: (Enum.DefineType): use NamespaceClash before
22059 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22060 speed increase. First, use the negative_hits cache when we get a
22061 negative. Second, add the type with its full original name
22062 instead of the new . and + encoded name (reflection uses + to
22063 separate type from a nested type). Use LookupTypeReflection
22064 directly which bypasses the type->name hashtable (that we already
22065 know does not contain the type.
22067 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22068 location/container type.
22070 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22072 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22074 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22076 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22077 method is being referenced in the method group from a static
22078 context, and report error 120 if so.
22080 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22083 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22084 is created, we create the A namespace).
22086 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22089 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22091 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22092 invocation to ModuleBuilder.GetType with the same values will
22093 return a new type instance, so we need to cache its return
22096 * expression.cs (Binary.ResolveOperator): Only allow the compare
22097 operators on enums if they are of the same type.
22099 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22100 types of ValueType on their own case. Before we were giving them
22101 the same treatment as objects.
22103 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22104 fullname. Short name is used to compare against container name.
22105 Fullname is used to check against defined namespace names.
22107 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22108 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22110 (Method.CheckBase): Call parent.
22111 (MemberBase.CheckBase): Check for protected members on sealed
22113 (PropertyBase.CheckBase): Call parent.
22114 (Field.Define): Call parent.
22116 * report.cs: Negative error codes are now mapped to 8000 - code,
22117 so that the display is render more nicely.
22119 * typemanager.cs: Do not use try/catch, instead report a regular
22122 (GetPointerType, GetReferenceType): These methods provide
22123 mechanisms to obtain the T* and T& from a T. We had the code
22124 previously scattered around the code base, and it also used
22125 TypeManager.LookupType that would go through plenty of caches.
22126 This one goes directly to the type source.
22128 In some places we did the Type.GetType followed by
22129 ModuleBuilder.GetType, but not in others, so this unifies the
22130 processing as well.
22132 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22133 statements now that we have namespace information.
22135 * typemanager.cs (IsNamespace): New method, returns whether the
22136 string presented is a namespace or not.
22138 (ComputeNamespaces): New public entry point, computes the list of
22139 available namespaces, using the GetNamespaces API call in Mono, or
22140 the slower version in MS.NET.
22142 Now before we start the semantic analysis phase, we have a
22143 complete list of namespaces including everything that the user has
22146 Deleted old code to cache namespaces in .nsc files.
22148 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22150 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22151 class/struct location definition Location for the implicit
22152 constructor location.
22154 (Operator.Define): Use the location of the operator for the
22155 implicit Method definition.
22157 (Constructor.Emit): use the constructor location for the implicit
22158 base initializer constructor.
22160 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22161 and the Expression class now contains two new methods:
22163 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22164 isolate type lookup from the rest of the resolution process.
22166 Since we use Expressions to hold type definitions due to the way
22167 we parse the input we have historically overloaded Resolve to
22168 perform the Type lookups if a special flag is passed. Now this is
22169 eliminated and two methods take their place.
22171 The differences in the two methods between xStep and xTerminal is
22172 that xStep is involved in our current lookup system that uses
22173 SimpleNames to compose a name, while xTerminal is used just to
22174 catch the case where the simplename lookup failed.
22176 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22178 * expression.cs (ResolveMemberAccess): Remove redundant code.
22179 TypeExpr expressions are always born fully resolved.
22181 * interface.cs (PopulateMethod): Do not lookup the types twice.
22182 We were doing it once during SemanticAnalysis and once during
22185 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22186 in local variable type definitions, were being returned as a
22187 SimpleName (we decomposed everything into a string), that is
22188 because primary_expression was being used instead of a type in the
22189 grammar (reduce/reduce conflicts).
22191 The part that was wrong is that we converted the expression into a
22192 string (an oversimplification in one hand, compounded with primary
22193 expressions doing string concatenation).
22199 Would return "A.B.C[]" as a SimpleName. This stopped things like
22200 using clauses from working on this particular context. And a type
22201 was being matched directly against "A.B.C[]".
22203 We now use the correct approach, and allow for ComposedCast to be
22204 part of the unary expression. So the "A.B.C []" become a composed
22205 cast of "A.B.C" (as a nested group of MemberAccess with a
22206 SimpleName at the end) plus the rank composition "[]".
22210 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22212 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22213 for the access level checking.
22215 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22216 `TypeContainer container', because I kept getting confused when I
22217 was debugging this code.
22219 * expression.cs (Indexers): Instead of tracking getters/setters,
22220 we now track them in parallel. We create one arraylist less, but
22221 most importantly it is possible now for the LValue code to find a
22222 matching get for a set.
22224 (IndexerAccess.DoResolveLValue): Update the code.
22225 GetIndexersForType has been modified already to extract all the
22226 indexers from a type. The code assumed it did not.
22228 Also make the code set the correct return type for the indexer.
22229 This was fixed a long time ago for properties, but was missing for
22230 indexers. It used to be void_type.
22232 (Binary.Emit): Test first for doubles instead of
22233 floats, as they are more common.
22235 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22236 when dealing with floats and the <=, >= operators. This fixes bug
22239 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22240 to load the array value by emitting a load on the foreach variable
22241 type. This was incorrect.
22243 We now emit the code to load an element using the the array
22244 variable type, and then we emit the conversion operator.
22248 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22250 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22252 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22254 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22255 test for protection before we test for signatures.
22257 (MethodSignature.ToString): implement.
22259 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22260 to the case where we reduced into a LongConstant.
22262 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22263 depend on whether the information is acurrate, because the
22264 Microsoft runtime will always claim that the array type is public,
22265 regardless of the real state.
22267 If the type is a pointer, another problem happens: the type is
22268 reported as non-public in Microsoft.
22270 In both cases we have to call CheckAccessLevel recursively with
22271 the underlying type as the argument to be tested.
22273 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22275 * assign.cs (Assign.Emit): If we are dealing with a compound
22276 assignment expression, we should use the code path that stores the
22277 intermediate result in a temporary value. This fixes #40903.
22279 *expression.cs (Indirection.ToString): Provide ToString method for
22282 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22284 * class.cs: Null out fields holding references to Block objects so
22285 they can be garbage collected.
22287 * expression.cs (OverloadResolve): Remove unused local.
22289 2003-04-07 Martin Baulig <martin@ximian.com>
22291 * codegen.cs (EmitContext.CurrentFile): New public field.
22292 (EmitContext.Mark): Use the CurrentFile to check whether the
22293 location is in the correct file.
22294 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22296 2003-04-07 Martin Baulig <martin@ximian.com>
22298 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22300 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22301 location. [FIXME: The location argument which gets passed to this
22302 method is sometimes wrong!]
22304 2003-04-07 Nick Drochak <ndrochak@gol.com>
22306 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22308 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22310 * expression.cs (Indirection.EmitAssign): We were using the
22311 temporary, but returning immediately instead of continuing the
22314 2003-04-06 Martin Baulig <martin@ximian.com>
22316 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22317 if it's a nested child, but also deriving from the outer class.
22320 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22321 nested child, but also deriving from the outer class. See
22323 (FilterWithClosure): We may access private members of the outer
22324 class if we're a nested child and deriving from the outer class.
22325 (RealMemberLookup): Only set `closure_private_ok' if the
22326 `original_bf' contained BindingFlags.NonPublic.
22328 2003-04-05 Martin Baulig <martin@ximian.com>
22330 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22332 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22334 * class.cs (Event.Define): Do not allow abstract events to have
22337 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22339 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22340 block in event declarations.
22342 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22343 value type, get its address.
22345 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22346 leaving a class on the stack instead of a boolean value (int
22347 0/1). Change the code so we compare against null, and then the
22348 result against zero.
22350 * class.cs (TypeContainer.GetClassBases): We were checking for the
22351 parent class being sealed too late.
22353 * expression.cs (Binary.Emit): For <= and >= when dealing with
22354 floating point values, use cgt.un and clt.un instead of cgt and
22357 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22359 * statement.cs: Apply the same optimization as MS: skip the
22360 GetEnumerator returning an IEnumerator, and use the one returning a
22361 CharEnumerator instead. This allows us to avoid the try-finally block
22364 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22366 * cs-parser.jay: Attributes cannot be applied to
22367 namespaces. Fixes #40473
22369 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22372 (Add*): check if the name is valid using the full name for constants,
22373 fields, properties and events.
22375 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22377 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22378 char constants to be part of the enumeration.
22380 * expression.cs (Conditional.DoResolve): Add support for operator
22381 true. Implements the missing functionality from 14.12
22383 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22384 operator true/false as required by the spec.
22386 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22387 implicit conversion to boolean.
22389 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22390 also one where the type implements `operator true'.
22392 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22393 get an expression that will invoke operator true based on an
22396 (GetConversionOperators): Removed the hack that called op_True
22399 (Expression.ResolveBoolean): Move this from Statement.
22401 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22403 * ecore.cs (FieldExpr): do not allow initialization of initonly
22404 fields on derived classes
22406 2003-03-13 Martin Baulig <martin@ximian.com>
22408 * statement.cs (Block.Emit): Call ig.BeginScope() and
22409 ig.EndScope() when compiling with debugging info; call
22410 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22412 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22414 * expression.cs (Indexers): Do not construct immediately, allow
22415 for new members to be appended as we go. Fixes 38143
22417 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22419 * expression.cs: save/restore context when resolving an unchecked
22422 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22424 * cfold.cs: Catch division by zero in modulus operator during
22427 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22429 * interface.cs (Interface.DefineMembers): Avoid defining members
22432 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22434 * driver.cs: handle the +/- options for -noconfig
22436 * statement.cs (Unckeched.Resolve): Also track the state of
22437 unchecked in the Resolve phase.
22439 2003-02-27 Martin Baulig <martin@ximian.com>
22441 * ecore.cs (Expression.MemberLookup): Don't create a
22442 MethodGroupExpr for something which is not a method. Fixes #38291.
22444 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22446 * class.cs (MemberBase.CheckParameters): Also check that the type
22447 is unmanaged if it is a pointer.
22449 * expression.cs (SizeOf.Resolve): Add location information.
22451 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22452 a managed type is declared.
22454 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22455 parameter modifiers as well. Fixes bug 38606
22457 * class.cs: Very sad. Am backing out the speed up changes
22458 introduced by the ArrayList -> Array in the TypeContainer, as they
22459 were not actually that much faster, and introduced a bug (no error
22460 reports on duplicated methods).
22462 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22463 source first, this will guarantee that we have a valid expression
22464 before calling in lower levels functions that will require a
22465 resolved object. Then use this original_source in the
22466 target.ResolveLValue instead of the original source that was
22469 Another change. Use target.Resolve instead of LValueResolve.
22470 Although we are resolving for LValues, we will let the Assign code
22471 take care of that (it will be called again from Resolve). This
22472 basically allows code like this:
22474 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22475 class Y { void A (X x) { x [0] += o; }
22477 The problem was that the indexer was trying to resolve for
22478 set_Item (idx, object o) and never finding one. The real set_Item
22479 was set_Item (idx, X). By delaying the process we get the right
22484 2003-02-23 Martin Baulig <martin@ximian.com>
22486 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22487 while calling DoEmit ().
22489 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22490 source files; if you use the #line directive inside a method, the
22491 compiler stops emitting line numbers for the debugger until it
22492 reaches the end of the method or another #line directive which
22493 restores the original file.
22495 2003-02-23 Martin Baulig <martin@ximian.com>
22497 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22499 2003-02-23 Martin Baulig <martin@ximian.com>
22501 * statement.cs (Block.AddChildVariableNames): We need to call this
22502 recursively, not just for our immediate children.
22504 2003-02-23 Martin Baulig <martin@ximian.com>
22506 * class.cs (Event.Define): Always make the field private, like csc does.
22508 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22509 actually work, fixes bug #37521.
22511 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22513 * delegate.cs: When creating the various temporary "Parameters"
22514 classes, make sure that we call the ComputeAndDefineParameterTypes
22515 on those new parameters (just like we do with the formal ones), to
22516 allow them to be resolved in the context of the DeclSpace.
22518 This fixes the bug that Dick observed in Bugzilla #38530.
22520 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22522 * expression.cs (ResolveMemberAccess): When resolving a constant,
22523 do not attempt to pull a constant if the value was not able to
22524 generate a valid constant.
22526 * const.cs (LookupConstantValue): Do not report more errors than required.
22528 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22530 * expression.cs: fixes bug #38328.
22532 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22534 * class.cs: Changed all the various members that can be part of a
22535 class from being an ArrayList to be an Array of the right type.
22536 During the DefineType type_list, interface_list, delegate_list and
22537 enum_list are turned into types, interfaces, delegates and enums
22540 And during the member population, indexer_list, event_list,
22541 constant_list, field_list, instance_constructor_list, method_list,
22542 operator_list and property_list are turned into their real arrays.
22544 Although we could probably perform this operation earlier, for
22545 good error reporting we need to keep the lists and remove the
22546 lists for longer than required.
22548 This optimization was triggered by Paolo profiling the compiler
22549 speed on the output of `gen-sample-program.pl' perl script.
22551 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22552 not crash in methods like MemberLookupFailed that use this field.
22554 This problem arises when the compiler fails to resolve a type
22555 during interface type definition for example.
22557 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22559 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22560 inherit from System.Object, so we have to stop at null, not only
22561 when reaching System.Object.
22563 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22565 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22566 DeclaredOnly because the parent indexer might have had a different
22567 name, but did not loop until the top of the hierarchy was reached.
22569 The problem this one fixes is 35492: when a class implemented an
22570 indexer from an interface, we were getting the interface method
22571 (which was abstract) and we were flagging an error (can not invoke
22574 This also keeps bug 33089 functioning, and test-148 functioning.
22576 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22577 out if a method is special is to see if it is declared in a
22578 property or event, or whether it is one of the predefined operator
22579 names. This should fix correctly #36804.
22581 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22583 The goal here is to remove the dependency on EmptyCast.Peel ().
22584 Killing it completely.
22586 The problem is that currently in a number of places where
22587 constants are expected, we have to "probe" for an EmptyCast, and
22588 Peel, which is not the correct thing to do, as this will be
22589 repetitive and will likely lead to errors.
22591 The idea is to remove any EmptyCasts that are used in casts that
22592 can be reduced to constants, so we only have to cope with
22595 This bug hunt was triggered by Bug 37363 and the desire to remove
22596 the duplicate pattern where we were "peeling" emptycasts to check
22597 whether they were constants. Now constants will always be
22600 * ecore.cs: Use an enumconstant here instead of wrapping with
22603 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22604 throwing me off. By handling this we can get rid of a few hacks.
22606 * statement.cs (Switch): Removed Peel() code.
22608 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22610 * class.cs: Location information for error 508
22612 * expression.cs (New.DoResolve): Add a guard against double
22613 resolution of an expression.
22615 The New DoResolve might be called twice when initializing field
22616 expressions (see EmitFieldInitializers, the call to
22617 GetInitializerExpression will perform a resolve on the expression,
22618 and later the assign will trigger another resolution
22620 This leads to bugs (#37014)
22622 * delegate.cs: The signature for EndInvoke should contain any ref
22623 or out parameters as well. We were not doing this in the past.
22625 * class.cs (Field.Define): Do not overwrite the type definition
22626 inside the `volatile' group. Turns out that volatile enumerations
22627 were changing the type here to perform a validity test, which
22630 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22632 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22633 and structs, we do not want to load the instance variable
22635 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22636 enum_type has to be handled like an object reference (implicit
22637 conversions exists from this to object), but the regular IsClass
22638 and IsValueType tests will never return true for this one.
22640 Also we use TypeManager.IsValueType instead of type.IsValueType,
22641 just for consistency with the rest of the code (this is only
22642 needed if we ever use the construct exposed by test-180.cs inside
22643 corlib, which we dont today).
22645 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22647 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22650 2003-02-09 Martin Baulig <martin@ximian.com>
22652 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22653 (Namespace.DefineNamespaces): New static public method; this is
22654 called when we're compiling with debugging to add all namespaces
22655 to the symbol file.
22657 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22658 pass it to the Namespace's .ctor.
22660 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22661 and MethodBase arguments; pass the namespace ID to the symwriter;
22662 pass the MethodBase instead of the token to the symwriter.
22663 (SymbolWriter.DefineNamespace): New method to add a namespace to
22666 2003-02-09 Martin Baulig <martin@ximian.com>
22668 * symbolwriter.cs: New file. This is a wrapper around
22669 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22670 methods here in near future.
22672 2003-02-09 Martin Baulig <martin@ximian.com>
22674 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22675 ILGenerator.MarkSequencePoint() which are actually used by the
22678 2003-02-09 Martin Baulig <martin@ximian.com>
22680 * location.cs (SourceFile): New public sealed class. This
22681 contains the name and an index which is used in the location's token.
22682 (Location): Reserve an appropriate number of bits in the token for
22683 the source file instead of walking over that list, this gives us a
22684 really huge performance improvement when compiling with debugging.
22686 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22687 `SourceFile' argument instead of a string.
22688 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22689 but don't parse/tokenize here, we need to generate the list of all
22690 source files before we do that.
22691 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22694 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22695 instead of a string.
22697 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22700 2003-02-09 Martin Baulig <martin@ximian.com>
22702 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22703 filename on `#line default'.
22705 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22707 * statement.cs: don't clear the pinned var when the fixed statement
22708 returns from the method (fixes bug#37752).
22710 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22712 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22715 2003-02-07 Martin Baulig <martin@ximian.com>
22717 * driver.cs: Removed the `--debug-args' command line argument.
22719 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22720 automatically by the AsssemblyBuilder.
22721 (CodeGen.InitializeSymbolWriter): We don't need to call any
22722 initialization function on the symbol writer anymore. This method
22723 doesn't take any arguments.
22725 2003-02-03 Miguel de Icaza <miguel@ximian.com>
22727 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
22728 from referenced assemblies as well.
22730 2003-02-02 Martin Baulig <martin@ximian.com>
22732 * class.cs (MethodData.Emit): Generate debugging info for external methods.
22734 2003-02-02 Martin Baulig <martin@ximian.com>
22736 * class.cs (Constructor.Emit): Open the symbol writer before
22737 emitting the constructor initializer.
22738 (ConstructorInitializer.Emit): Call ec.Mark() to allow
22739 single-stepping through constructor initializers.
22741 2003-01-30 Miguel de Icaza <miguel@ximian.com>
22743 * class.cs: Handle error 549: do not allow virtual methods in
22746 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
22748 * decl.cs: Check access levels when resolving types
22750 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
22752 * statement.cs: Add parameters and locals set in catch blocks that might
22753 return to set vector
22755 2003-01-29 Miguel de Icaza <miguel@ximian.com>
22757 * class.cs (Operator): Set the SpecialName flags for operators.
22759 * expression.cs (Invocation.DoResolve): Only block calls to
22760 accessors and operators on SpecialName methods.
22762 (Cast.TryReduce): Handle conversions from char constants.
22765 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
22767 * statement.cs: small memory and time optimization in FlowBranching.
22769 2003-01-28 Pedro Mart <yoros@wanadoo.es>
22771 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
22772 problem that the last fix but in the other sid (Set).
22774 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
22775 access when there is no indexer in the hierarchy.
22777 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
22779 * class.cs: Combine some if statements.
22781 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22783 * driver.cs: fixed bug #37187.
22785 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
22787 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
22788 any indexer, it's needed to build a list with all the indexers in the
22789 hierarchy (AllGetters), else we have problems. Fixes #35653.
22791 2003-01-23 Miguel de Icaza <miguel@ximian.com>
22793 * class.cs (MethodData.Define): It is wrong for an interface
22794 implementation to be static in both cases: explicit and implicit.
22795 We were only handling this in one case.
22797 Improve the if situation there to not have negations.
22799 * class.cs (Field.Define): Turns out that we do not need to check
22800 the unsafe bit on field definition, only on usage. Remove the test.
22802 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22804 * driver.cs: use assembly.Location instead of Codebase (the latest
22805 patch made mcs fail when using MS assemblies).
22807 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
22809 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
22810 get the path to *corlib.dll.
22812 2003-01-21 Nick Drochak <ndrochak@gol.com>
22816 * typemanager.cs: Remove compiler warnings
22818 2003-01-20 Duncan Mak <duncan@ximian.com>
22820 * AssemblyInfo.cs: Bump the version number to 0.19.
22822 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22824 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
22826 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
22828 * class.cs (Constructor::Emit): Emit debugging info for constructors.
22830 2003-01-17 Miguel de Icaza <miguel@ximian.com>
22832 * cs-parser.jay: Small fix: we were not comparing the constructor
22833 name correctly. Thanks to Zoltan for the initial pointer.
22835 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
22837 * cs-tokenizer.cs: Set file name when specified with #line
22839 2003-01-15 Miguel de Icaza <miguel@ximian.com>
22841 * cs-parser.jay: Only perform the constructor checks here if we
22842 are named like the class; This will help provider a better
22843 error. The constructor path is taken when a type definition is
22844 not found, but most likely the user forgot to add the type, so
22845 report that rather than the constructor error.
22847 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
22849 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
22852 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22854 * cs-parser.jay: Add cleanup call.
22856 2003-01-13 Duncan Mak <duncan@ximian.com>
22858 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
22859 consistent with other methods.
22861 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22863 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
22865 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
22867 * attribute.cs: only set GuidAttr to true when we have a
22870 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22874 * typemanager.cs: fixes to allow mcs compile corlib with the new
22875 Type.IsSubclassOf fix.
22877 2003-01-08 Miguel de Icaza <miguel@ximian.com>
22879 * expression.cs (LocalVariableReference.DoResolve): Classify a
22880 constant as a value, not as a variable. Also, set the type for
22883 * cs-parser.jay (fixed_statement): take a type instead of a
22884 pointer_type, so we can produce a better error message later.
22886 * statement.cs (Fixed.Resolve): Flag types that are not pointers
22889 (For.DoEmit): Make inifinite loops have a
22890 non-conditional branch back.
22892 (Fixed.DoEmit): First populate the pinned variables, then emit the
22893 statement, then clear the variables. Before I was emitting the
22894 code once for each fixed piece.
22897 2003-01-08 Martin Baulig <martin@ximian.com>
22899 * statement.cs (FlowBranching.MergeChild): A break in a
22900 SWITCH_SECTION does not leave a loop. Fixes #36155.
22902 2003-01-08 Martin Baulig <martin@ximian.com>
22904 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
22905 lives in the same number space than `param_map'. Fixes #36154.
22907 2003-01-07 Miguel de Icaza <miguel@ximian.com>
22909 * cs-parser.jay (constructor_declaration): Set the
22910 Constructor.ModFlags before probing for it. This makes the
22911 compiler report 514, 515 and 132 (the code was there, but got
22914 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
22915 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
22916 (GotoCase.Resolve): Set `Returns' to ALWAYS.
22918 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
22920 * enum.cs: create the enum static fields using the enum type.
22922 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
22924 * class.cs: don't try to create the ParamBuilder for the return
22925 type if it's not needed (and handle it breaking for the ms runtime
22928 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
22930 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
22932 2002-12-29 Miguel de Icaza <miguel@ximian.com>
22934 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
22935 the command. This showed up while compiling the JANET source
22936 code, which used \r as its only newline separator.
22938 2002-12-28 Miguel de Icaza <miguel@ximian.com>
22940 * class.cs (Method.Define): If we are an operator (because it
22941 reuses our code), then set the SpecialName and HideBySig. #36128
22943 2002-12-22 Miguel de Icaza <miguel@ximian.com>
22945 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
22946 exception, report error 120 `object reference required'.
22948 * driver.cs: Add --pause option, used during to measure the size
22949 of the process as it goes with --timestamp.
22951 * expression.cs (Invocation.DoResolve): Do not allow methods with
22952 SpecialName to be invoked.
22954 2002-12-21 Miguel de Icaza <miguel@ximian.com>
22956 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
22957 number before adding it.
22959 2002-12-21 Ravi Pratap <ravi@ximian.com>
22961 * ecore.cs (StandardImplicitConversion): When in an unsafe
22962 context, we allow conversion between void * to any other pointer
22963 type. This fixes bug #35973.
22965 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
22967 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
22968 is not thrown when extensionless outputs are used
22970 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22972 * rootcontext.cs: fixed compilation of corlib.
22974 2002-12-19 Miguel de Icaza <miguel@ximian.com>
22976 * attribute.cs (Attributes.Contains): Add new method.
22978 * class.cs (MethodCore.LabelParameters): if the parameter is an
22979 `out' parameter, check that no attribute `[In]' has been passed.
22981 * enum.cs: Handle the `value__' name in an enumeration.
22983 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
22985 * decl.cs: Added special case to allow overrides on "protected
22988 2002-12-18 Ravi Pratap <ravi@ximian.com>
22990 * attribute.cs (Attributes.AddAttributeSection): Rename to this
22991 since it makes much more sense.
22993 (Attributes.ctor): Don't require a Location parameter.
22995 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
22997 * attribute.cs (ApplyAttributes): Remove extra Location parameters
22998 since we already have that information per attribute.
23000 * everywhere : make appropriate changes.
23002 * class.cs (LabelParameters): Write the code which actually
23003 applies attributes to the return type. We can't do this on the MS
23004 .NET runtime so we flag a warning in the case an exception is
23007 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23009 * const.cs: Handle implicit null conversions here too.
23011 2002-12-17 Ravi Pratap <ravi@ximian.com>
23013 * class.cs (MethodCore.LabelParameters): Remove the extra
23014 Type [] parameter since it is completely unnecessary. Instead
23015 pass in the method's attributes so that we can extract
23016 the "return" attribute.
23018 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23020 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23021 of ignoring it and letting the compile continue.
23023 * typemanager.cs (ChangeType): use an extra argument to return an
23024 error condition instead of throwing an exception.
23026 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23028 * expression.cs (Unary.TryReduce): mimic the code for the regular
23029 code path. Perform an implicit cast in the cases where we can
23030 implicitly convert to one of the integral types, and then reduce
23031 based on that constant. This fixes bug #35483.
23033 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23035 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23037 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23039 * namespace.cs: fixed bug #35489.
23041 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23043 * class.cs: Remove some dead code.
23045 * cs-parser.jay: Estimate the number of methods needed
23046 (RootContext.MethodCount);
23048 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23049 numbers instead of StringBuilders.
23051 * support.cs (PtrHashtable): Add constructor with initial size;
23052 We can now reduce reallocations of the method table.
23054 2002-12-10 Ravi Pratap <ravi@ximian.com>
23056 * attribute.cs (ApplyAttributes): Keep track of the emitted
23057 attributes on a per-target basis. This fixes bug #35413.
23059 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23061 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23062 default to the Windows 1252 encoding.
23064 (UnixParseOption): Support version, thanks to Alp for the missing
23067 * AssemblyInfo.cs: Add nice assembly information.
23069 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23072 * cs-parser.jay: Allow a trailing comma before the close bracked
23073 in the attribute_section production.
23075 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23076 address of the instance was being taken, I will take this out,
23077 because we take the address of the object immediately here.
23079 2002-12-09 Ravi Pratap <ravi@ximian.com>
23081 * typemanager.cs (AreMultipleAllowed): Take care of the most
23082 obvious case where attribute type is not in the current assembly -
23085 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23087 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23088 definitions, instead of doing that afterwards.
23090 Also we use a nice little hack, depending on the constructor, we
23091 know if we are a "composed" name or a simple name. Hence, we
23092 avoid the IndexOf test, and we avoid
23094 * codegen.cs: Add code to assist in a bug reporter to track down
23095 the source of a compiler crash.
23097 2002-12-07 Ravi Pratap <ravi@ximian.com>
23099 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23100 types have been emitted for a given element and flag an error
23101 if something which does not have AllowMultiple set is used more
23104 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23105 attribute types and their corresponding AllowMultiple properties
23107 (AreMultipleAllowed): Check the property for a given type.
23109 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23110 property in the case we have a TypeContainer.
23112 (Attributes.AddAttribute): Detect duplicates and just skip on
23113 adding them. This trivial fix catches a pretty gross error in our
23114 attribute emission - global attributes were being emitted twice!
23116 Bugzilla bug #33187 is now fixed.
23118 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23120 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23121 instead of pp_and).
23123 * expression.cs (Binary.ResolveOperator): I can only use the
23124 Concat (string, string, string) and Concat (string, string,
23125 string, string) if the child is actually a concatenation of
23128 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23130 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23131 context where we need a 2-character lookahead.
23133 * pending.cs (PendingImplementation): Rework so we can keep track
23134 of interface types all the time, and flag those which were
23135 implemented by parents as optional.
23137 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23139 * expression.cs (Binary.ResolveOperator): Use
23140 String.Concat(string,string,string) or
23141 String.Concat(string,string,string,string) when possible.
23143 * typemanager: More helper methods.
23146 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23148 * pending.cs: remove the bogus return from GetMissingInterfaces()
23149 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23151 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23153 * namespace.cs: avoid duplicated 'using xxx' being added to
23154 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23155 when we get more than one 'using' statement for the same namespace.
23156 Report a CS0105 warning for it.
23158 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23160 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23161 of calling getChar/putback, uses internal knowledge of it.
23163 (xtoken): Reorder tokenizer so most common patterns are checked
23164 first. This reduces the compilation time in another 5% (from 8.11s
23165 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23167 The parsing time is 22% of the compilation in mcs, and from that
23168 64% is spent on the tokenization process.
23170 I tried using a binary search for keywords, but this is slower
23171 than the hashtable. Another option would be to do a couple of
23174 * Not use a StringBuilder, instead use an array of chars,
23175 with a set value. Notice that this way we could catch
23176 the 645 error without having to do it *afterwards*.
23178 * We could write a hand-parser to avoid the hashtable
23179 compares altogether.
23181 The identifier consumption process takes 37% of the tokenization
23182 time. Another 15% is spent on is_number. 56% of the time spent
23183 on is_number is spent on Int64.Parse:
23185 * We could probably choose based on the string length to
23186 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23189 Another 3% is spend on wrapping `xtoken' in the `token' function.
23191 Handle 0xa0 as whitespace (#34752)
23193 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23195 * typemanager.cs (IsCLRType): New routine to tell whether a type
23196 is one of the builtin types.
23198 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23199 typecode in more places instead of doing pointer comparissions.
23200 We could leverage some knowledge about the way the typecodes are
23203 New code to cache namespaces in assemblies, it is currently not
23204 invoked, to be used soon.
23206 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23208 * expression.cs (Binary.ResolveOperator): specially handle
23209 strings, and do not perform user-defined operator overloading for
23212 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23214 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23215 internalcall as it is a pretty simple operation; Avoid whenever
23216 possible to call Char.IsLetter.
23218 (consume_identifier): Cut by half the number of
23219 hashtable calls by merging the is_keyword and GetKeyword behavior.
23221 Do not short-circuit, because if we do, we
23222 report errors (ie, #if false && true would produce an invalid
23226 2002-11-24 Martin Baulig <martin@ximian.com>
23228 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23229 check constant ranges and report a CS0221. Fixes #33186.
23231 2002-11-24 Martin Baulig <martin@ximian.com>
23233 * cs-parser.jay: Make this work for uninitialized variable
23234 declarations in the `for' initializer. Fixes #32416.
23236 2002-11-24 Martin Baulig <martin@ximian.com>
23238 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23239 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23241 2002-11-24 Martin Baulig <martin@ximian.com>
23243 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23244 argument; if true, we also check for user-defined conversions.
23245 This is only needed if both arguments are of a user-defined type.
23246 Fixes #30443, added test-175.cs.
23247 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23249 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23251 2002-11-24 Martin Baulig <martin@ximian.com>
23253 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23254 function to get the store opcode.
23255 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23256 only emit the Ldelema if the store opcode is Stobj. You must run
23257 both test-34 and test-167 to test this. Fixes #34529.
23259 2002-11-23 Martin Baulig <martin@ximian.com>
23261 * ecore.cs (Expression.MemberLookup): Added additional
23262 `qualifier_type' argument which is used when we're being called
23263 from MemberAccess.DoResolve() and null if we're called from a
23265 (Expression.MemberLookupFailed): New method to report errors; this
23266 does the CS1540 check and reports the correct error message.
23268 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23269 argument for the CS1540 check and redone the way how we're dealing
23270 with private members. See the comment in the source code for details.
23271 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23272 `closure_start_type' to `closure_qualifier_type' and check whether
23273 it's not null. It was not this filter being broken, it was just
23274 being called with the wrong arguments.
23276 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23277 and pass it the correct `qualifier_type'; this also does the error
23280 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23282 * expression.cs (Invocation.EmitParams): If the we are dealing
23283 with a non-built-in value type, load its address as well.
23285 (ArrayCreation): Use a a pretty constant instead
23286 of the hardcoded value 2. Use 6 instead of 2 for the number of
23287 static initializers.
23289 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23290 because they are not really value types, just glorified integers.
23292 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23294 * ecore.cs: Remove redundant code for enumerations, make them use
23295 the same code path as everything else, fixes the casting issue
23296 with enumerations in Windows.Forms.
23298 * attribute.cs: Do only cast to string if it is a string, the
23299 validation happens later.
23301 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23302 people upgrade their corlibs.
23304 * ecore.cs: Oops, enumerations were not following the entire code path
23306 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23308 * typemanager.cs (FilterWithClosure): Commented out the test for
23309 1540 in typemanager.cs, as it has problems when accessing
23310 protected methods from a parent class (see test-174.cs).
23312 * attribute.cs (Attribute.ValidateGuid): new method.
23313 (Attribute.Resolve): Use above.
23315 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23317 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23319 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23320 handling for enumerations, as we only needed the TypeContainer
23321 functionality to begin with (this is required for the fix below to
23322 work for enums that reference constants in a container class for
23325 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23327 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23328 a valid TypeBuilder to perform lookups on.o
23330 * class.cs (InheritableMemberSignatureCompare): Use true in the
23331 call to GetGetMethod and GetSetMethod, because we are comparing
23332 the signature, and we need to get the methods *even* if they are
23335 (PropertyBase.CheckBase): ditto.
23337 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23338 GotoCase.Resolve): Use Peel on EmpytCasts.
23340 * ecore.cs (EmptyCast): drop child, add Peel method.
23342 2002-11-17 Martin Baulig <martin@ximian.com>
23344 * ecore.cs (EmptyCast.Child): New public property.
23346 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23347 label resolved to an EmptyCast. Fixes #34162.
23348 (GotoCase.Resolve): Likewise.
23349 (Block.EmitMeta): Likewise.
23351 2002-11-17 Martin Baulig <martin@ximian.com>
23353 * expression.cs (Invocation.BetterConversion): Prefer int over
23354 uint; short over ushort; long over ulong for integer literals.
23355 Use ImplicitConversionExists instead of StandardConversionExists
23356 since we also need to check for user-defined implicit conversions.
23357 Fixes #34165. Added test-173.cs.
23359 2002-11-16 Martin Baulig <martin@ximian.com>
23361 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23362 with the `true' and `false' literals. Fixes #33151.
23364 2002-11-16 Martin Baulig <martin@ximian.com>
23366 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23367 October 22nd; don't do the cs1540 check for static members.
23369 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23370 now using our own filter here and doing the cs1540 check again.
23372 2002-11-16 Martin Baulig <martin@ximian.com>
23374 * support.cs (InternalParameters): Don't crash if we don't have
23375 any fixed parameters. Fixes #33532.
23377 2002-11-16 Martin Baulig <martin@ximian.com>
23379 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23380 when looking up static methods to make this work on Windows.
23383 2002-11-16 Martin Baulig <martin@ximian.com>
23385 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23386 a setter rather than using PropertyInfo.CanWrite.
23388 2002-11-15 Nick Drochak <ndrochak@gol.com>
23390 * class.cs: Allow acces to block member by subclasses. Fixes build
23393 2002-11-14 Martin Baulig <martin@ximian.com>
23395 * class.cs (Constructor.Emit): Added the extern/block check.
23398 2002-11-14 Martin Baulig <martin@ximian.com>
23400 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23401 iteration while looking for indexers, this is needed because the
23402 indexer may have a different name in our base classes. Fixed the
23403 error reporting (no indexers at all, not get accessor, no
23404 overloaded match). Fixes bug #33089.
23405 (IndexerAccess.DoResolveLValue): Likewise.
23407 2002-11-14 Martin Baulig <martin@ximian.com>
23409 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23410 indexers. Fixes the first part of bug #33089.
23411 (MethodSignature.InheritableMemberSignatureCompare): Added support
23414 2002-11-13 Ravi Pratap <ravi@ximian.com>
23416 * attribute.cs (Attribute.Resolve): Catch the
23417 NullReferenceException and report it since it isn't supposed to
23420 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23422 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23423 LogicalOr and LogicalAnd that can benefit from recursively
23424 handling EmitBranchable. The code now should be nice for Paolo.
23426 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23428 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23429 the Type lookups, as we perform quite a number of lookups on
23430 non-Types. This can be removed once we can deterministically tell
23431 whether we have a type or a namespace in advance.
23433 But this might require special hacks from our corlib.
23437 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23438 and double which avoids a conversion from an integer to a double.
23440 * expression.cs: tiny optimization, avoid calling IsConstant,
23441 because it effectively performs the lookup twice.
23443 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23445 But a bogus return here to keep the semantics of the old code
23446 until the Mono runtime is fixed.
23448 * pending.cs (GetMissingInterfaces): New method used to remove all
23449 the interfaces that are already implemented by our parent
23450 classes from the list of pending methods.
23452 * interface.cs: Add checks for calls after ResolveTypeExpr.
23454 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23456 * class.cs (Class.Emit): Report warning 67: event not used if the
23457 warning level is beyond 3.
23459 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23460 being a NullLiteral.
23462 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23465 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23466 path that might fail if a type can not be resolved.
23468 * expression.cs (Binary.Emit): Emit unsigned versions of the
23471 * driver.cs: use error 5.
23473 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23475 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23477 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23479 * cs-parser.jay (switch_section): A beautiful patch from Martin
23480 Baulig that fixed 33094.
23482 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23484 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23485 Check whether the base is abstract and report an error if so.
23487 * expression.cs (IndexerAccess.DoResolveLValue,
23488 IndexerAccess.DoResolve): ditto.
23490 (Invocation.DoResolve): ditto.
23492 (Invocation.FullMethodDesc): Improve the report string.
23494 * statement.cs (Block): Eliminate IsVariableDefined as it is
23495 basically just a wrapper for GetVariableInfo.
23497 * ecore.cs (SimpleName): Use new
23499 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23500 type, as we return the actual parameter ref/unref state on a
23503 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23505 * support.cs: Return proper flags REF/OUT fixing the previous
23508 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23509 not used to mean `ref' but `ref or out' in ParameterReference
23511 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23512 full type signature instead of calling TypeManger.CSharpName
23515 * support.cs (InternalParameters.ParameterDesc): Do not compare
23516 directly to the modflags, because REF/OUT will actually be bitsets
23519 * delegate.cs (VerifyMethod): Check also the modifiers.
23521 * cs-tokenizer.cs: Fix bug where floating point values with an
23522 exponent where a sign was missing was ignored.
23524 * driver.cs: Allow multiple assemblies to be specified in a single
23527 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23529 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23530 because identifiers after a parenthesis would end up in this kind
23531 of production, and we needed to desamiguate it for having casts
23534 (UserDefinedType *) xxx
23536 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23538 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23539 we should set on the Bindingflags.NonPublic, but not turn on
23540 private_ok. private_ok controls whether a Private member is
23541 returned (this is chekced on the filter routine), while the
23542 BindingFlags.NonPublic just controls whether private/protected
23543 will be allowed. This fixes the problem part of the problem of
23544 private properties being allowed to be used in derived classes.
23546 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23547 so we can call the children DoResolveLValue method (this will
23548 properly signal errors on lvalue assignments to base properties)
23550 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23551 getter are null, and we have a property info, we know that this
23552 happened because the lookup failed, so we report an error 122 for
23553 protection level violation.
23555 We also silently return if setter and getter are null in the
23556 resolve functions, this condition only happens if we have flagged
23557 the error before. This is the other half of the problem.
23559 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23560 not have accessibility information, that is why we were returning
23561 true in the filter function in typemanager.cs.
23563 To properly report 122 (property is inaccessible because of its
23564 protection level) correctly, we report this error in ResolveAccess
23565 by failing if both the setter and the getter are lacking (ie, the
23568 DoResolve and DoLResolve have been modified to check for both
23569 setter/getter being null and returning silently, the reason being
23570 that I did not want to put the knowledge about this error in upper
23573 int old = Report.Errors;
23574 x = new PropertyExpr (...);
23575 if (old != Report.Errors)
23580 So the property expr is returned, but it is invalid, so the error
23581 will be flagged during the resolve process.
23583 * class.cs: Remove InheritablePropertySignatureCompare from the
23584 class, as we no longer depend on the property signature to compute
23585 whether it is possible to implement a method or not.
23587 The reason is that calling PropertyInfo.GetGetMethod will return
23588 null (in .NET, in Mono it works, and we should change this), in
23589 cases where the Get Method does not exist in that particular
23594 class X { public virtual int A { get { return 1; } } }
23596 class Z : Y { public override int A { get { return 2; } } }
23598 Would fail in Z because the parent (Y) would not have the property
23599 defined. So we avoid this completely now (because the alternative
23600 fix was ugly and slow), and we now depend exclusively on the
23603 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23604 reference method, instead of using the property.
23606 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23607 routines are gone now.
23609 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23610 names, they were incorrectly named.
23612 * cs-tokenizer.cs: Return are more gentle token on failure.
23614 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23615 had an out-of-sync index variable, which caused it to remove from
23616 the list of pending methods the wrong method sometimes.
23618 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23620 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23621 CanWrite, because those refer to this particular instance of the
23622 property, and do not take into account the fact that we can
23623 override single members of a property.
23625 Constructor requires an EmitContext. The resolution process does
23626 not happen here, but we need to compute the accessors before,
23627 because the resolution does not always happen for properties.
23629 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23630 subclass, before we did not update this flag, but we did update
23633 (GetAccessors): Drop this routine, as it did not work in the
23634 presence of partially overwritten set/get methods.
23636 Notice that this broke the cs1540 detection, but that will require
23639 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23643 * driver.cs: issue a warning instead of an error if we don't support
23644 debugging for the platform. Also ignore a couple of errors that may
23645 arise when trying to write the symbols. Undo my previous patch.
23647 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23649 * driver.cs: ignore /debug switch except for Unix platforms.
23651 2002-10-23 Nick Drochak <ndrochak@gol.com>
23653 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23655 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23657 * driver.cs: Do not make mcs-debug conditional, so we do not break
23658 builds that use it.
23660 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23661 review this patch. But basically after all the children variables
23662 have been merged, the value of "Breaks" was not being set to
23663 new_breaks for Switch blocks. I think that it should be set after
23664 it has executed. Currently I set this to the value of new_breaks,
23665 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23666 conservative, but I do not understand this code very well.
23668 I did not break anything in the build, so that is good ;-)
23670 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23672 2002-10-20 Mark Crichton <crichton@gimp.org>
23674 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23676 2002-10-20 Nick Drochak <ndrochak@gol.com>
23678 * cfold.cs: Fixed compile blocker.
23680 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23682 * driver.cs: I was chekcing the key, not the file.
23684 2002-10-19 Ravi Pratap <ravi@ximian.com>
23686 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23687 message that we were generating - we just need to silently return
23690 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23692 * class.cs (Event.Define): Change my previous commit, as this
23693 breaks the debugger. This is a temporary hack, as it seems like
23694 the compiler is generating events incorrectly to begin with.
23696 * expression.cs (Binary.ResolveOperator): Added support for
23697 "U operator - (E x, E y)"
23699 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23702 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23703 init-only variables, but this path did not take into account that
23704 there might be also instance readonly variables. Correct this
23707 This fixes bug 32253
23709 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23712 * driver.cs: Change the extension for modules to `netmodule'
23714 * cs-parser.jay: Improved slightly the location tracking for
23715 the debugger symbols.
23717 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23718 modifiers that were specified instead of the hardcoded value
23719 (FamAndAssem). This was basically ignoring the static modifier,
23720 and others. Fixes 32429.
23722 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23723 fixed a bug in the process (32476)
23725 * expression.cs (ArrayAccess.EmitAssign): Patch from
23726 hwang_rob@yahoo.ca that fixes bug 31834.3
23728 2002-10-18 Miguel de Icaza <miguel@ximian.com>
23730 * driver.cs: Make the module extension .netmodule.
23732 2002-10-16 Miguel de Icaza <miguel@ximian.com>
23734 * driver.cs: Report an error if the resource file is not found
23735 instead of crashing.
23737 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
23738 false, like Emit does.
23740 2002-10-16 Nick Drochak <ndrochak@gol.com>
23742 * typemanager.cs: Remove unused private member. Also reported mcs
23743 bug to report this as a warning like csc.
23745 2002-10-15 Martin Baulig <martin@gnome.org>
23747 * statement.cs (Statement.Emit): Made this a virtual method; emits
23748 the line number info and calls DoEmit().
23749 (Statement.DoEmit): New protected abstract method, formerly knows
23750 as Statement.Emit().
23752 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
23754 2002-10-11 Miguel de Icaza <miguel@ximian.com>
23756 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
23757 have fixed a remaining problem: not every AddXXXX was adding a
23758 fully qualified name.
23760 Now everyone registers a fully qualified name in the DeclSpace as
23761 being defined instead of the partial name.
23763 Downsides: we are slower than we need to be due to the excess
23764 copies and the names being registered this way.
23766 The reason for this is that we currently depend (on the corlib
23767 bootstrap for instance) that types are fully qualified, because
23768 we dump all the types in the namespace, and we should really have
23769 types inserted into the proper namespace, so we can only store the
23770 basenames in the defined_names array.
23772 2002-10-10 Martin Baulig <martin@gnome.org>
23774 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
23775 from bug #31834, see the bug report for a testcase which is
23778 2002-10-10 Martin Baulig <martin@gnome.org>
23780 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
23781 flow analysis code for this.
23783 * statement.cs (Do, While, For): Tell the flow analysis code about
23785 (FlowBranching.UsageVector): Added support for infinite loops.
23786 (Block.Resolve): Moved the dead code elimination here and use flow
23789 2002-10-09 Miguel de Icaza <miguel@ximian.com>
23791 * class.cs (Field.Define): Catch cycles on struct type
23794 * typemanager.cs (IsUnmanagedtype): Do not recursively check
23795 fields if the fields are static. We only need to check instance
23798 * expression.cs (As.DoResolve): Test for reference type.
23800 * statement.cs (Using.ResolveExpression): Use
23801 ConvertImplicitRequired, not ConvertImplicit which reports an
23803 (Using.ResolveLocalVariableDecls): ditto.
23805 * expression.cs (Binary.ResolveOperator): Report errors in a few
23806 places where we had to.
23808 * typemanager.cs (IsUnmanagedtype): Finish implementation.
23810 2002-10-08 Miguel de Icaza <miguel@ximian.com>
23812 * expression.cs: Use StoreFromPtr instead of extracting the type
23813 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
23815 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
23816 an enumeration value to a System.Enum, but System.Enum is not a
23817 value type, but an class type, so we need to box.
23819 (Expression.ConvertExplicit): One codepath could return
23820 errors but not flag them. Fix this. Fixes #31853
23822 * parameter.cs (Resolve): Do not allow void as a parameter type.
23824 2002-10-06 Martin Baulig <martin@gnome.org>
23826 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
23827 if it's a class type and not a struct. Fixes #31815.
23829 2002-10-06 Martin Baulig <martin@gnome.org>
23831 * statement.cs: Reworked the flow analysis code a bit to make it
23832 usable for dead code elimination.
23834 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23836 * cs-parser.jay: allow empty source files. Fixes bug #31781.
23838 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23840 * expression.cs (ComposedCast.DoResolveType): A quick workaround
23841 to fix the test 165, will investigate deeper.
23843 2002-10-04 Martin Baulig <martin@gnome.org>
23845 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
23846 finally blocks actually work.
23847 (Try.Resolve): We don't need to create a sibling for `finally' if
23848 there is no finally block.
23850 2002-10-04 Martin Baulig <martin@gnome.org>
23852 * class.cs (Constructor.Define): The default accessibility for a
23853 non-default constructor is private, not public.
23855 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23857 * class.cs (Constructor): Make AllowedModifiers public, add
23860 * cs-parser.jay: Perform the modifiers test here, as the
23861 constructor for the Constructor class usually receives a zero
23862 because of the way we create it (first we create, later we
23863 customize, and we were never checking the modifiers).
23865 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
23866 is a version of LookupTypeReflection that includes the type-name
23867 cache. This can be used as a fast path for functions that know
23868 the fully qualified name and are only calling into *.GetType() to
23869 obtain a composed type.
23871 This is also used by TypeManager.LookupType during its type
23874 (LookupType): We now also track the real type name, as sometimes
23875 we can get a quey for the real type name from things like
23876 ComposedCast. This fixes bug 31422.
23878 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
23879 complete type fullname, it does not have to go through the type
23880 resolution system to obtain the composed version of the type (for
23881 obtaining arrays or pointers).
23883 (Conditional.Emit): Use the EmitBoolExpression to
23884 generate nicer code, as requested by Paolo.
23886 (ArrayCreation.CheckIndices): Use the patch from
23887 hwang_rob@yahoo.ca to validate the array initializers.
23889 2002-10-03 Miguel de Icaza <miguel@ximian.com>
23891 * class.cs (ConstructorInitializer.Emit): simplify code by using
23892 Invocation.EmitCall, and at the same time, fix the bugs in calling
23893 parent constructors that took variable arguments.
23895 * ecore.cs (Expression.ConvertNumericExplicit,
23896 Expression.ImplicitNumericConversion): Remove the code that
23897 manually wrapped decimal (InternalTypeConstructor call is now gone
23900 * expression.cs (Cast.TryReduce): Also handle decimal types when
23901 trying to perform a constant fold on the type.
23903 * typemanager.cs (IsUnmanagedtype): Partially implemented.
23905 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
23906 that only turned off an error report, and did nothing else.
23908 2002-10-02 Miguel de Icaza <miguel@ximian.com>
23910 * driver.cs: Handle and ignore /fullpaths
23912 2002-10-01 Miguel de Icaza <miguel@ximian.com>
23914 * expression.cs (Binary.ResolveOperator): Catch the case where
23915 DoNumericPromotions returns true,
23917 (Binary.DoNumericPromotions): Simplify the code, and the tests.
23919 2002-09-27 Miguel de Icaza <miguel@ximian.com>
23921 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
23924 2002-09-26 Miguel de Icaza <miguel@ximian.com>
23926 * ecore.cs (ConvertNumericExplicit): It is not enough that the
23927 conversion exists, but it is also required that the conversion be
23928 performed. This manifested in "(Type64Enum) 2".
23930 * class.cs (TypeManager.AddMethod): The fix is not to change
23931 AddEnum, because that one was using a fully qualified name (every
23932 DeclSpace derivative does), but to change the AddMethod routine
23933 that was using an un-namespaced name. This now correctly reports
23934 the duplicated name.
23936 Revert patch until I can properly fix it. The issue
23937 is that we have a shared Type space across all namespaces
23938 currently, which is wrong.
23940 Options include making the Namespace a DeclSpace, and merge
23941 current_namespace/current_container in the parser.
23943 2002-09-25 Miguel de Icaza <miguel@ximian.com>
23945 * cs-parser.jay: Improve error reporting when we get a different
23946 kind of expression in local_variable_type and
23947 local_variable_pointer_type.
23949 Propagate this to avoid missleading errors being reported.
23951 * ecore.cs (ImplicitReferenceConversion): treat
23952 TypeManager.value_type as a target just like object_type. As
23957 Is valid, and needs to result in the int 1 being boxed before it
23958 is assigned to the value type v.
23960 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
23961 to validate the enumeration name.
23963 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
23964 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
23965 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
23967 * ecore.cs (TryImplicitIntConversion): When doing an
23968 implicit-enumeration-conversion, check if the type is 64-bits and
23969 perform a conversion before passing to EnumConstant.
23971 2002-09-23 Miguel de Icaza <miguel@ximian.com>
23973 * decl.cs (Error_AmbiguousTypeReference); New routine used to
23974 report ambiguous type references. Unlike the MS version, we
23975 report what the ambiguity is. Innovation at work ;-)
23977 (DeclSpace.FindType): Require a location argument to
23978 display when we display an ambiguous error.
23980 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
23982 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
23984 * expression.cs (EmitDynamicInitializers): Apply patch from
23985 hwang_rob@yahoo.ca that fixes the order in which we emit our
23988 2002-09-21 Martin Baulig <martin@gnome.org>
23990 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
23991 delegate takes no arguments.
23993 2002-09-20 Miguel de Icaza <miguel@ximian.com>
23995 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
23998 * expression.cs: Extract the underlying type.
24000 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24002 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24004 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24006 * class.cs (TypeContainer.DefineType): We can not use the nice
24007 PackingSize with the size set to 1 DefineType method, because it
24008 will not allow us to define the interfaces that the struct
24011 This completes the fixing of bug 27287
24013 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24014 means also structs. This fixes part of the problem.
24015 (Expresion.ImplicitReferenceConversionExists): ditto.
24017 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24018 error if there were no errors reported during the type lookup
24019 process, to avoid duplicates or redundant errors. Without this
24020 you would get an ambiguous errors plus a type not found. We have
24021 beaten the user enough with the first error.
24023 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24026 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24027 during the resolution process, stop the lookup, this avoids
24028 repeated error reports (same error twice).
24030 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24032 * typemanager.cs (LookupType): Redo the type lookup code to match
24033 the needs of System.Reflection.
24035 The issue is that System.Reflection requires references to nested
24036 types to begin with a "+" sign instead of a dot. So toplevel
24037 types look like: "NameSpace.TopLevelClass", and nested ones look
24038 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24041 2002-09-19 Martin Baulig <martin@gnome.org>
24043 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24044 says that a method always returns or always throws an exception,
24045 don't report the CS0161.
24047 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24048 set `Returns = new_returns'.
24050 2002-09-19 Martin Baulig <martin@gnome.org>
24052 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24053 to an enum constant, check for a CS0176.
24055 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24057 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24058 for operators that must be in pairs and report errors.
24060 * ecore.cs (SimpleName.DoResolveType): During the initial type
24061 resolution process, when we define types recursively, we must
24062 check first for types in our current scope before we perform
24063 lookups in the enclosing scopes.
24065 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24067 (Invocation.VerifyArgumentsCompat): Call
24068 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24069 I thought we were supposed to always call this, but there are a
24070 few places in the code where we dont do it.
24072 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24074 * driver.cs: Add support in -linkres and -resource to specify the
24075 name of the identifier.
24077 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24079 * ecore.cs (StandardConversionExists): Sync with the conversion
24080 code: allow anything-* to void* conversions.
24082 (FindMostSpecificSource): Use an Expression argument
24083 instead of a Type, because we might be handed over a Literal which
24084 gets a few more implicit conversions that plain types do not. So
24085 this information was being lost.
24087 Also, we drop the temporary type-holder expression when not
24090 2002-09-17 Martin Baulig <martin@gnome.org>
24092 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24093 this is an explicit interface implementation.
24095 2002-09-17 Martin Baulig <martin@gnome.org>
24097 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24098 different `IndexerName' attributes.
24100 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24101 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24102 virtual CommonResolve().
24104 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24106 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24107 and convert that to the UnderlyingType.
24109 * statement.cs (Foreach.Resolve): Indexers are just like variables
24110 or PropertyAccesses.
24112 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24113 inside quoted strings, we were not doing this before.
24115 2002-09-16 Martin Baulig <martin@gnome.org>
24117 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24118 resolve it. This is needed for the definite assignment check of the
24119 instance expression, fixes bug #29846.
24120 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24122 2002-09-16 Nick Drochak <ndrochak@gol.com>
24124 * parameter.cs: Fix compile error. Cannot reference static member
24125 from an instance object. Is this an mcs bug?
24127 2002-09-14 Martin Baulig <martin@gnome.org>
24129 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24130 multiple times. Fixes bug #30295, added test-166.cs.
24132 2002-09-14 Martin Baulig <martin@gnome.org>
24134 * statement.cs (Block.Emit): Don't emit unreachable code.
24135 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24136 `break' statements.
24137 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24139 2002-09-14 Martin Baulig <martin@gnome.org>
24141 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24144 2002-09-14 Martin Baulig <martin@gnome.org>
24146 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24147 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24148 be false on the ms runtime.
24150 2002-09-13 Martin Baulig <martin@gnome.org>
24152 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24153 the CS0038 error message.
24155 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24157 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24158 constant inside, return it.
24160 2002-09-12 Martin Baulig <martin@gnome.org>
24162 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24163 implicit conversion can be done between enum types.
24165 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24166 check whether an implicit conversion to the current enum's UnderlyingType
24167 exists and report an error if not.
24169 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24170 without debugging support.
24172 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24173 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24175 2002-09-12 Martin Baulig <martin@gnome.org>
24177 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24179 * ecore.cs (IMemberExpr.DeclaringType): New property.
24180 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24181 nonstatic member of an outer type (CS0038).
24183 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24185 * driver.cs: Activate the using-error detector at warning level
24186 4 (at least for MS-compatible APIs).
24188 * namespace.cs (VerifyUsing): Small buglett fix.
24190 * pending.cs (PendingImplementation): pass the container pointer.
24192 * interface.cs (GetMethods): Allow for recursive definition. Long
24193 term, I would like to move every type to support recursive
24194 definitions, not the current ordering mechanism that we have right
24197 The situation is this: Attributes are handled before interfaces,
24198 so we can apply attributes to interfaces. But some attributes
24199 implement interfaces, we will now handle the simple cases
24200 (recursive definitions will just get an error).
24202 * parameter.cs: Only invalidate types at the end if we fail to
24205 2002-09-09 Martin Baulig <martin@gnome.org>
24207 * ecore.cs (PropertyExpr.Emit): Also check for
24208 TypeManager.system_int_array_get_length so this'll also work when
24209 compiling corlib. Fixes #30003.
24211 2002-09-09 Martin Baulig <martin@gnome.org>
24213 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24214 and throw an exception if we can't get the type's size. Fixed #30040,
24217 2002-09-09 Martin Baulig <martin@gnome.org>
24219 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24221 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24222 context. Fixes bug #30027.
24224 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24225 virtual functions. Fixes bug #30043, added test-164.cs.
24227 2002-09-08 Ravi Pratap <ravi@ximian.com>
24229 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24231 2002-09-08 Nick Drochak <ndrochak@gol.com>
24233 * driver.cs: Use an object to get the windows codepage since it's not a
24236 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24238 * statement.cs (For.Emit): for infinite loops (test == null)
24239 return whether there is a break inside, not always "true".
24241 * namespace.cs (UsingEntry): New struct to hold the name of the
24242 using definition, the location where it is defined, and whether it
24243 has been used in a successful type lookup.
24245 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24250 2002-09-06 Ravi Pratap <ravi@ximian.com>
24252 * attribute.cs : Fix incorrect code which relied on catching
24253 a NullReferenceException to detect a null being passed in
24254 where an object was expected.
24256 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24258 * statement.cs (Try): flag the catch variable as assigned
24260 * expression.cs (Cast): Simplified by using ResolveType instead of
24261 manually resolving.
24263 * statement.cs (Catch): Fix bug by using ResolveType.
24265 2002-09-06 Ravi Pratap <ravi@ximian.com>
24267 * expression.cs (BetterConversion): Special case for when we have
24268 a NullLiteral as the argument and we have to choose between string
24269 and object types - we choose string the way csc does.
24271 * attribute.cs (Attribute.Resolve): Catch the
24272 NullReferenceException and report error #182 since the Mono
24273 runtime no more has the bug and having this exception raised means
24274 we tried to select a constructor which takes an object and is
24277 2002-09-05 Ravi Pratap <ravi@ximian.com>
24279 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24280 message (1502, 1503) when we can't locate a method after overload
24281 resolution. This is much more informative and closes the bug
24284 * interface.cs (PopulateMethod): Return if there are no argument
24285 types. Fixes a NullReferenceException bug.
24287 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24288 expressions too. Previously we were checking only in one place for
24289 positional arguments leaving out named arguments.
24291 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24292 type to the enum type is not allowed. Remove code corresponding to
24295 (ConvertNumericExplicit): Allow explicit conversions from
24296 the underlying type to enum type. This precisely follows the spec
24297 and closes a bug filed by Gonzalo.
24299 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24302 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24304 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24306 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24307 it was important that we stored the right value after the
24308 reduction in `converted'.
24310 2002-09-04 Martin Baulig <martin@gnome.org>
24312 * location.cs (Location.SymbolDocument): Use full pathnames for the
24315 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24317 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24318 of the expression resolve mechanism, because that will catch the
24319 SimpleName error failures.
24321 (Conditional): If we can not resolve the
24322 expression, return, do not crash.
24324 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24327 (location): display token name instead of its number.
24329 2002-08-28 Martin Baulig <martin@gnome.org>
24331 * expression.cs (Binary.ResolveOperator): Don't silently return
24332 but return an error if an operator cannot be applied between two
24335 2002-08-28 Martin Baulig <martin@gnome.org>
24337 * class.cs (Constructor.Define): Set the permission attributes
24338 correctly instead of making all constructors public.
24340 2002-08-28 Martin Baulig <martin@gnome.org>
24342 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24343 for private members before reporting a CS0103; if we find anything,
24346 2002-08-28 Martin Baulig <martin@gnome.org>
24348 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24349 to check whether `closure_start_type == closure_invocation_type',
24350 we also need to check whether `m.DeclaringType == closure_invocation_type'
24351 before bypassing the permission checks. We might be accessing
24352 protected/private members from the base class.
24353 (TypeManager.RealMemberLookup): Only set private_ok if private
24354 members were requested via BindingFlags.NonPublic.
24356 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24358 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24359 MethodGroupExpr.IsExplicitImpl if appropriate.
24360 (Invocation.DoResolve): Don't report the CS0120 for explicit
24361 interface implementations.
24363 2002-08-27 Martin Baulig <martin@gnome.org>
24365 * expression.cs (Invocation.DoResolve): If this is a static
24366 method and we don't have an InstanceExpression, we must report
24369 2002-08-25 Martin Baulig <martin@gnome.org>
24371 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24372 `==' between a valuetype and an object.
24374 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24376 * ecore.cs (TypeExpr): Provide a ToString method.
24378 2002-08-24 Martin Baulig <martin@gnome.org>
24380 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24381 now called proggie.dbg and it's a binary file.
24383 2002-08-23 Martin Baulig <martin@gnome.org>
24385 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24387 2002-08-23 Martin Baulig <martin@gnome.org>
24389 * struct.cs (MyStructInfo.ctor): Make this work with empty
24390 structs; it's not allowed to use foreach() on null.
24392 2002-08-23 Martin Baulig <martin@gnome.org>
24394 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24395 writer the full pathname of the generated assembly.
24397 2002-08-23 Martin Baulig <martin@gnome.org>
24399 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24400 A `finally' block never returns or breaks; improved handling of
24403 2002-08-23 Martin Baulig <martin@gnome.org>
24405 * statement.cs (Throw.Resolve): Allow `throw null'.
24407 2002-08-23 Martin Baulig <martin@gnome.org>
24409 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24410 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24411 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24412 MemberLookup would return a wrong event if this is an explicit
24413 interface implementation and the class has an event with the same
24416 2002-08-23 Martin Baulig <martin@gnome.org>
24418 * statement.cs (Block.AddChildVariableNames): New public method.
24419 (Block.AddChildVariableName): Likewise.
24420 (Block.IsVariableNameUsedInChildBlock): Likewise.
24421 (Block.AddVariable): Check whether a variable name has already
24422 been used in a child block.
24424 * cs-parser.jay (declare_local_variables): Mark all variable names
24425 from the current block as being used in a child block in the
24428 2002-08-23 Martin Baulig <martin@gnome.org>
24430 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24431 find the symbol writer.
24433 * driver.cs: csc also allows the arguments to /define being
24434 separated by commas, not only by semicolons.
24436 2002-08-23 Martin Baulig <martin@gnome.org>
24438 * interface.cs (Interface.GetMembers): Added static check for events.
24440 2002-08-15 Martin Baulig <martin@gnome.org>
24442 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24443 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24445 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24446 why the MethodData.EmitDestructor() change was necessary.
24448 2002-08-20 Martin Baulig <martin@gnome.org>
24450 * class.cs (TypeContainer.FindMembers): Added static check for events.
24452 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24454 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24455 use Type.GetEvents(), not Type.FindMembers().
24457 2002-08-20 Martin Baulig <martin@gnome.org>
24459 * decl.cs (MemberCache): Added a special method cache which will
24460 be used for method-only searched. This ensures that a method
24461 search will return a MethodInfo with the correct ReflectedType for
24464 2002-08-20 Martin Baulig <martin@gnome.org>
24466 * decl.cs (DeclSpace.FindMembers): Made this public.
24468 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24470 * delegate.cs: fixed build on windows.
24471 [FIXME: Filed as bug #29150: MCS must report these errors.]
24473 2002-08-19 Ravi Pratap <ravi@ximian.com>
24475 * ecore.cs (StandardConversionExists): Return a false
24476 if we are trying to convert the void type to anything else
24477 since that is not allowed.
24479 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24480 we flag error 70 in the event an event is trying to be accessed
24481 directly from outside the declaring type.
24483 2002-08-20 Martin Baulig <martin@gnome.org>
24485 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24486 MemberCache from typemanager.cs to decl.cs.
24488 2002-08-19 Martin Baulig <martin@gnome.org>
24490 * class.cs (TypeContainer): Implement IMemberContainer.
24491 (TypeContainer.DefineMembers): Create the MemberCache.
24492 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24493 return public members if BindingFlags.Public was given, check
24494 whether members are static.
24496 2002-08-16 Martin Baulig <martin@gnome.org>
24498 * decl.cs (DeclSpace.Define): Splitted this in Define and
24499 DefineMembers. DefineMembers is called first and initializes the
24502 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24503 DefineMembers() on all our DeclSpaces.
24505 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24506 but call DefineMembers() on all nested interfaces. We call their
24507 Define() in our new Define() function.
24509 * interface.cs (Interface): Implement IMemberContainer.
24510 (Interface.Define): Moved all code except the attribute stuf to
24512 (Interface.DefineMembers): Initialize the member cache.
24514 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24515 need this anymore since we can use MemberCache.FindMembers directly.
24517 2002-08-19 Martin Baulig <martin@gnome.org>
24519 * typemanager.cs (MemberCache): When creating the cache for an
24520 interface type, add all inherited members.
24521 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24522 to `out bool used_cache' and documented it.
24523 (TypeManager.MemberLookup): If we already used the cache in the first
24524 iteration, we don't need to do the interfaces check.
24526 2002-08-19 Martin Baulig <martin@gnome.org>
24528 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24529 here from IMemberFinder and don't implement this interface anymore.
24530 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24532 * typemanager.cs (IMemberFinder): This interface is now only used by
24533 classes which actually support the member cache.
24534 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24535 since we only put DeclSpaces into this Hashtable.
24536 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24537 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24539 2002-08-16 Martin Baulig <martin@gnome.org>
24541 * typemanager.cs (ICachingMemberFinder): Removed.
24542 (IMemberFinder.MemberCache): New property.
24543 (TypeManager.FindMembers): Merged this with RealFindMembers().
24544 This function will never be called from TypeManager.MemberLookup()
24545 so we can't use the cache here, just the IMemberFinder.
24546 (TypeManager.MemberLookup_FindMembers): Check whether the
24547 IMemberFinder has a MemberCache and call the cache's FindMembers
24549 (MemberCache): Rewrote larger parts of this yet another time and
24550 cleaned it up a bit.
24552 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24554 * driver.cs (LoadArgs): Support quoting.
24556 (Usage): Show the CSC-like command line arguments.
24558 Improved a few error messages.
24560 2002-08-15 Martin Baulig <martin@gnome.org>
24562 * typemanager.cs (IMemberContainer.Type): New property.
24563 (IMemberContainer.IsInterface): New property.
24565 The following changes are conditional to BROKEN_RUNTIME, which is
24566 defined at the top of the file.
24568 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24569 class'es members, but add all members from TypeHandle.ObjectType
24570 if we're an interface.
24571 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24572 is the current type.
24573 (MemberCache.CacheEntry.Container): Removed this field.
24574 (TypeHandle.GetMembers): Include inherited members.
24576 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24578 * typemanager.cs: fixed compilation and added a comment on a field that
24581 2002-08-15 Martin Baulig <martin@gnome.org>
24583 * class.cs (ConstructorInitializer.Resolve): In the
24584 Expression.MemberLookup call, use the queried_type as
24587 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24588 declared' attribute, it's always true.
24589 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24590 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24591 temporary wrapper for FindMembers which tells MemberLookup whether
24592 members from the base classes are included in the return value.
24593 This will go away soon.
24594 (TypeManager.MemberLookup): Use this temporary hack here; once the
24595 new MemberCache is completed, we don't need to do the DeclaredOnly
24596 looping here anymore since the MemberCache will take care of this.
24597 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24598 (MemberCache): When creating the MemberCache for a class, get
24599 members from the current class and all its base classes.
24600 (MemberCache.CacheEntry.Container): New field. This is a
24601 temporary hack until the Mono runtime is fixed to distinguish
24602 between ReflectedType and DeclaringType. It allows us to use MCS
24603 with both the MS runtime and the unfixed Mono runtime without
24604 problems and without accecting performance.
24605 (MemberCache.SearchMembers): The DeclaredOnly looping from
24606 TypeManager.MemberLookup is now done here.
24608 2002-08-14 Martin Baulig <martin@gnome.org>
24610 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24611 Type.GetFields on dynamic types but get the fields from the
24612 corresponding TypeContainer.
24613 (MyStructInfo.GetStructInfo): Added check for enum types.
24615 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24616 (MemberList.SyncRoot): Implemented.
24617 (TypeManager.FilterWithClosure): No need to check permissions if
24618 closure_start_type == closure_invocation_type, don't crash if
24619 closure_invocation_type is null.
24621 2002-08-13 Martin Baulig <martin@gnome.org>
24623 Rewrote TypeContainer.FindMembers to use a member cache. This
24624 gives us a speed increase of about 35% for the self-hosting MCS
24625 build and of about 15-20% for the class libs (both on GNU/Linux).
24627 * report.cs (Timer): New class to get enhanced profiling. This
24628 whole class is "TIMER" conditional since it remarkably slows down
24631 * class.cs (MemberList): New class. This is an IList wrapper
24632 which we're now using instead of passing MemberInfo[]'s around to
24633 avoid copying this array unnecessarily.
24634 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24635 (ICachingMemberFinder, IMemberContainer): New interface.
24636 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24637 has already been checked, otherwise use it for the name comparision.
24638 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24639 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24640 if possible. Returns a MemberList, not a MemberInfo [].
24641 (TypeHandle): New class, implements IMemberContainer. We create
24642 one instance of this class per type, it contains a MemberCache
24643 which is used to do the member lookups.
24644 (MemberCache): New class. Each instance of this class contains
24645 all members of a type and a name-based hash table.
24646 (MemberCache.FindMembers): This is our new member lookup
24647 function. First, it looks up all members of the requested name in
24648 the hash table. Then, it walks this list and sorts out all
24649 applicable members and returns them.
24651 2002-08-13 Martin Baulig <martin@gnome.org>
24653 In addition to a nice code cleanup, this gives us a performance
24654 increase of about 1.4% on GNU/Linux - not much, but it's already
24655 half a second for the self-hosting MCS compilation.
24657 * typemanager.cs (IMemberFinder): New interface. It is used by
24658 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24659 Enum, Delegate or Interface.
24660 (TypeManager.finder_to_member_finder): New PtrHashtable.
24661 (TypeManager.finder_to_container): Removed.
24662 (TypeManager.finder_to_delegate): Removed.
24663 (TypeManager.finder_to_interface): Removed.
24664 (TypeManager.finder_to_enum): Removed.
24666 * interface.cs (Interface): Implement IMemberFinder.
24668 * delegate.cs (Delegate): Implement IMemberFinder.
24670 * enum.cs (Enum): Implement IMemberFinder.
24672 * class.cs (TypeContainer): Implement IMemberFinder.
24674 2002-08-12 Martin Baulig <martin@gnome.org>
24676 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24678 2002-08-12 Martin Baulig <martin@gnome.org>
24680 * ecore.cs (ITypeExpression): New interface for expressions which
24682 (TypeExpression): Renamed to TypeLookupExpression.
24683 (Expression.DoResolve): If we're doing a types-only lookup, the
24684 expression must implement the ITypeExpression interface and we
24685 call DoResolveType() on it.
24686 (SimpleName): Implement the new ITypeExpression interface.
24687 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24688 hack, the situation that we're only looking up types can't happen
24689 anymore when this method is called. Moved the type lookup code to
24690 DoResolveType() and call it.
24691 (SimpleName.DoResolveType): This ITypeExpression interface method
24692 is now doing the types-only lookup.
24693 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24694 (ResolveFlags): Added MaskExprClass.
24696 * expression.cs (MemberAccess): Implement the ITypeExpression
24698 (MemberAccess.DoResolve): Added support for a types-only lookup
24699 when we're called via ITypeExpression.DoResolveType().
24700 (ComposedCast): Implement the ITypeExpression interface.
24702 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24703 Expression.Resolve() with ResolveFlags.Type instead.
24705 2002-08-12 Martin Baulig <martin@gnome.org>
24707 * interface.cs (Interface.Define): Apply attributes.
24709 * attribute.cs (Attribute.ApplyAttributes): Added support for
24710 interface attributes.
24712 2002-08-11 Martin Baulig <martin@gnome.org>
24714 * statement.cs (Block.Emit): Only check the "this" variable if we
24715 do not always throw an exception.
24717 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24718 whether the property has a set accessor.
24720 2002-08-11 Martin Baulig <martin@gnome.org>
24722 Added control flow analysis support for structs.
24724 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
24725 with control flow analysis turned off.
24726 (IVariable): New interface.
24727 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
24728 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
24729 (FieldExpr.DoResolve): Resolve the instance expression with flow
24730 analysis turned off and do the definite assignment check after the
24731 resolving when we know what the expression will resolve to.
24733 * expression.cs (LocalVariableReference, ParameterReference):
24734 Implement the new IVariable interface, only call the flow analysis
24735 code if ec.DoFlowAnalysis is true.
24736 (This): Added constructor which takes a Block argument. Implement
24737 the new IVariable interface.
24738 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
24739 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
24740 This does the definite assignment checks for struct members.
24742 * class.cs (Constructor.Emit): If this is a non-static `struct'
24743 constructor which doesn't have any initializer, call
24744 Block.AddThisVariable() to tell the flow analysis code that all
24745 struct elements must be initialized before control returns from
24748 * statement.cs (MyStructInfo): New public class.
24749 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
24750 argument to this indexer. If non-zero, check an individual struct
24751 member, not the whole struct.
24752 (FlowBranching.CheckOutParameters): Check struct members.
24753 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
24754 overloaded versions of these methods which take an additional
24755 `int field_idx' argument to check struct members.
24756 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
24757 overloaded versions of these methods which take an additional
24758 `string field_name' argument to check struct member.s
24759 (VariableInfo): Implement the IVariable interface.
24760 (VariableInfo.StructInfo): New public property. Returns the
24761 MyStructInfo instance of the variable if it's a struct or null.
24762 (Block.AddThisVariable): New public method. This is called from
24763 Constructor.Emit() for non-static `struct' constructor which do
24764 not have any initializer. It creates a special variable for the
24765 "this" instance variable which will be checked by the flow
24766 analysis code to ensure that all of the struct's fields are
24767 initialized before control returns from the constructor.
24768 (UsageVector): Added support for struct members. If a
24769 variable/parameter is a struct with N members, we reserve a slot
24770 in the usage vector for each member. A struct is considered fully
24771 initialized if either the struct itself (slot 0) or all its
24772 members are initialized.
24774 2002-08-08 Martin Baulig <martin@gnome.org>
24776 * driver.cs (Driver.MainDriver): Only report an error CS5001
24777 if there were no compilation errors.
24779 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
24780 `UnsafeContext' property to determine whether the parent is in
24781 unsafe context rather than checking the parent's ModFlags:
24782 classes nested in an unsafe class are unsafe as well.
24784 2002-08-08 Martin Baulig <martin@gnome.org>
24786 * statement.cs (UsageVector.MergeChildren): Distinguish between
24787 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
24788 we return. Added test17() and test18() to test-154.cs.
24790 2002-08-08 Martin Baulig <martin@gnome.org>
24792 * typemanager.cs (TypeManager.FilterWithClosure): If we have
24793 Family access, make sure the invoking type isn't a subclass of the
24794 queried type (that'd be a CS1540).
24796 * ecore.cs (Expression.MemberLookup): Added overloaded version of
24797 this method which takes an additional `Type invocation_type'.
24799 * expression.cs (BaseAccess.DoResolve): Use the base type as
24800 invocation and query type.
24801 (MemberAccess.DoResolve): If the lookup failed and we're about to
24802 report a CS0122, try a lookup with the ec.ContainerType - if this
24803 succeeds, we must report a CS1540.
24805 2002-08-08 Martin Baulig <martin@gnome.org>
24807 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
24808 (MethodGroupExpr): Implement the IMemberExpr interface.
24810 * expression (MemberAccess.ResolveMemberAccess): No need to have
24811 any special code for MethodGroupExprs anymore, they're now
24814 2002-08-08 Martin Baulig <martin@gnome.org>
24816 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
24817 Family, FamANDAssem and FamORAssem permissions.
24818 (TypeManager.IsSubclassOrNestedChildOf): New public method.
24820 2002-08-08 Martin Baulig <martin@gnome.org>
24822 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
24823 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
24826 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
24828 * driver.cs: implemented /resource option to embed managed resources.
24830 2002-08-07 Martin Baulig <martin@gnome.org>
24832 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
24833 (FieldBase.HasFieldInitializer): New public property.
24834 (FieldBase.GetInitializerExpression): New public method. Resolves and
24835 returns the field initializer and makes sure it is only resolved once.
24836 (TypeContainer.EmitFieldInitializers): Call
24837 FieldBase.GetInitializerExpression to get the initializer, this ensures
24838 that it isn't resolved multiple times.
24840 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
24841 the resolving process (SimpleName/MemberLookup) that we're currently
24842 emitting a field initializer (which must not access any instance members,
24843 this is an error CS0236).
24845 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
24846 argument, if the `IsFieldInitializer' flag is set, we must report and
24847 error CS0236 and not an error CS0120.
24849 2002-08-07 Martin Baulig <martin@gnome.org>
24851 * ecore.cs (IMemberExpr): New public interface.
24852 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
24853 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
24854 if the expression is an IMemberExpr.
24856 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
24857 to be null, implicitly default to `this' if we're non-static in
24858 this case. Simplified the code a lot by using the new IMemberExpr
24859 interface. Also fixed bug #28176 here.
24861 2002-08-06 Martin Baulig <martin@gnome.org>
24863 * cs-parser.jay (SimpleLookup): Removed. We need to create
24864 ParameterReferences during semantic analysis so that we can do a
24865 type-only search when resolving Cast, TypeOf and SizeOf.
24866 (block): Pass the `current_local_parameters' to the Block's
24869 * class.cs (ConstructorInitializer): Added `Parameters parameters'
24870 argument to the constructor.
24871 (ConstructorInitializer.Resolve): Create a temporary implicit
24872 block with the parameters.
24874 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
24875 references here if we aren't doing a type-only search.
24877 * statement.cs (Block): Added constructor which takes a
24878 `Parameters parameters' argument.
24879 (Block.Parameters): New public property.
24881 * support.cs (InternalParameters.Parameters): Renamed `parameters'
24882 to `Parameters' and made it public readonly.
24884 2002-08-06 Martin Baulig <martin@gnome.org>
24886 * ecore.cs (Expression.Warning): Made this public as well.
24888 * report.cs (Report.Debug): Print the contents of collections.
24890 2002-08-06 Martin Baulig <martin@gnome.org>
24892 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
24893 used to tell Resolve() which kinds of expressions it may return.
24894 (Expression.Resolve): Added overloaded version of this method which
24895 takes a `ResolveFlags flags' argument. This can be used to tell
24896 Resolve() which kinds of expressions it may return. Reports a
24898 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
24899 ResolveFlags.SimpleName.
24900 (Expression.Error118): Added overloaded version of this method which
24901 takes a `ResolveFlags flags' argument. It uses the flags to determine
24902 which kinds of expressions are allowed.
24904 * expression.cs (Argument.ResolveMethodGroup): New public method.
24905 Resolves an argument, but allows a MethodGroup to be returned.
24906 This is used when invoking a delegate.
24908 * TODO: Updated a bit.
24910 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24912 Fixed compilation with csc.
24914 * ecore.cs: Expression.Error made public. Is this correct? Should
24915 Warning be made public too?
24917 * expression.cs: use ea.Location instead of ea.loc.
24918 [FIXME: Filed as bug #28607: MCS must report these errors.]
24920 2002-08-06 Martin Baulig <martin@gnome.org>
24922 * ecore.cs (Expression.loc): Moved the location here instead of
24923 duplicating it in all derived classes.
24924 (Expression.Location): New public property.
24925 (Expression.Error, Expression.Warning): Made them non-static and
24926 removed the location argument.
24927 (Expression.Warning): Added overloaded version which takes an
24928 `int level' argument.
24929 (Expression.Error118): Make this non-static and removed the
24930 expression and location arguments.
24931 (TypeExpr): Added location argument to the constructor.
24933 * expression.cs (StaticCallExpr): Added location argument to
24935 (Indirection, PointerArithmetic): Likewise.
24936 (CheckedExpr, UnCheckedExpr): Likewise.
24937 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
24938 (StringPtr): Likewise.
24941 2002-08-05 Martin Baulig <martin@gnome.org>
24943 * expression.cs (BaseAccess.DoResolve): Actually report errors.
24945 * assign.cs (Assign.DoResolve): Check whether the source
24946 expression is a value or variable.
24948 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
24949 while resolving the corresponding blocks.
24951 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
24952 an error, don't silently return null.
24954 * statement.cs (Block.AddVariable): Do the error reporting here
24955 and distinguish between CS0128 and CS0136.
24956 (Block.DoResolve): Report all unused labels (warning CS0164).
24957 (LabeledStatement): Pass the location to the constructor.
24958 (LabeledStatement.HasBeenReferenced): New property.
24959 (LabeledStatement.Resolve): Set it to true here.
24961 * statement.cs (Return.Emit): Return success even after reporting
24962 a type mismatch error (CS0126 or CS0127), this is what csc does and
24963 it avoids confusing the users with any consecutive errors.
24965 2002-08-05 Martin Baulig <martin@gnome.org>
24967 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
24969 * const.cs (Const.LookupConstantValue): Catch circular definitions.
24971 * expression.cs (MemberAccess.DoResolve): Silently return if an
24972 error has already been reported.
24974 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
24975 error has already been reported.
24977 2002-08-05 Martin Baulig <martin@gnome.org>
24979 * statement.cs (UsageVector): Only initialize the `parameters'
24980 vector if we actually have any "out" parameters.
24982 2002-08-05 Martin Baulig <martin@gnome.org>
24984 * expression.cs (Binary.ResolveOperator): When combining delegates,
24985 they must have the same type.
24987 2002-08-05 Martin Baulig <martin@gnome.org>
24989 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
24990 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
24991 work with the ms runtime and we also don't need it: if we're a
24992 PropertyBuilder and not in the `indexer_arguments' hash, then we
24993 are a property and not an indexer.
24995 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
24996 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
24997 since the latter one doesn't work with the ms runtime.
24999 2002-08-03 Martin Baulig <martin@gnome.org>
25001 Fixed bugs #27998 and #22735.
25003 * class.cs (Method.IsOperator): New public field.
25004 (Method.CheckBase): Report CS0111 if there's already a method
25005 with the same parameters in the current class. Report CS0508 when
25006 attempting to change the return type of an inherited method.
25007 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25008 and it's not marked abstract or extern.
25009 (PropertyBase): New abstract base class for Property and Indexer.
25010 (PropertyBase.CheckBase): Moved here from Property and made it work
25012 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25013 the same so we can reuse it there.
25014 (Property, Indexer): Derive from PropertyBase.
25015 (MethodSignature.inheritable_property_signature_filter): New delegate
25016 to find properties and indexers.
25018 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25019 argument and improved error reporting.
25021 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25022 EmptyReadOnlyParameters and made it a property.
25024 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25025 version of this method which takes a `PropertyInfo indexer'.
25026 (TypeManager.RegisterIndexer): New method.
25028 * class.cs: Added myself as author of this file :-)
25030 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25032 * class.cs: fixed compilation on windoze.
25034 2002-08-03 Martin Baulig <martin@gnome.org>
25036 * interface.cs (Interface.GetInterfaceBases): Check whether all
25037 base interfaces are at least as accessible than the current one.
25039 * class.cs (TypeContainer.GetClassBases): Check whether base types
25040 are at least as accessible than the current type.
25041 (TypeContainer.AsAccessible): Implemented and made non-static.
25042 (MemberBase.CheckParameters): Report errors if the accessibility
25045 * delegate.cs (Delegate.Delegate): The default visibility is
25046 internal for top-level types and private for nested types.
25047 (Delegate.Define): Report errors if the accessibility checks fail.
25049 * enum.cs (Enum.Enum): The default visibility is internal for
25050 top-level types and private for nested types.
25051 (Enum.DefineType): Compute the correct visibility.
25053 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25054 function which takes a `bool is_toplevel' instead of a TypeContainer.
25056 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25059 2002-08-02 Martin Baulig <martin@gnome.org>
25061 * expression.cs (LocalVariableReferenc): Added constructor which
25062 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25063 (LocalVariableReference.IsReadOnly): New property.
25064 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25065 variable is readonly, use our own readonly flag to do this; you can
25066 use the new constructor to get a writable reference to a read-only
25069 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25070 reference to the local variable.
25072 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25074 * rootcontext.cs (ResolveCore): Also include System.Exception
25076 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25077 we reach an EmptyStatement.
25079 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25082 * expression.cs (Binary.ResolveOperator): Check error result in
25085 use brtrue/brfalse directly and avoid compares to null.
25087 2002-08-02 Martin Baulig <martin@gnome.org>
25089 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25090 Fixes bug #28407, added test-155.cs.
25092 2002-08-01 Martin Baulig <martin@gnome.org>
25094 * class.cs (Event.EmitDefaultMethod): Make this work with static
25095 events. Fixes #28311, added verify-3.cs.
25097 2002-08-01 Martin Baulig <martin@gnome.org>
25099 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25100 `is_disposable' fields.
25101 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25102 `hm.is_disposable' if we're using the collection pattern.
25103 (Foreach.EmitCollectionForeach): Use the correct type for the
25104 enumerator's local variable, only emit the try/finally block if
25105 necessary (fixes #27713).
25107 2002-08-01 Martin Baulig <martin@gnome.org>
25109 * ecore.cs (Expression.report118): Renamed to Error118 and made
25112 * statement.cs (Throw.Resolve): Check whether the expression is of
25113 the correct type (CS0118) and whether the type derives from
25114 System.Exception (CS0155).
25115 (Catch.Resolve): New method. Do the type lookup here and check
25116 whether it derives from System.Exception (CS0155).
25117 (Catch.CatchType, Catch.IsGeneral): New public properties.
25119 * typemanager.cs (TypeManager.exception_type): Added.
25121 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25123 * driver.cs: Updated About function.
25125 2002-07-31 Martin Baulig <martin@gnome.org>
25127 Implemented Control Flow Analysis.
25129 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25130 (EmitContext.CurrentBranching): Added.
25131 (EmitContext.StartFlowBranching): Added.
25132 (EmitContext.EndFlowBranching): Added.
25133 (EmitContext.KillFlowBranching): Added.
25134 (EmitContext.IsVariableAssigned): Added.
25135 (EmitContext.SetVariableAssigned): Added.
25136 (EmitContext.IsParameterAssigned): Added.
25137 (EmitContext.SetParameterAssigned): Added.
25138 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25139 Added control flow analysis stuff here.
25141 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25142 resolve the expression as lvalue.
25143 (LocalVariableReference.DoResolve): Check whether the variable has
25144 already been assigned.
25145 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25146 the parameter as assigned here.
25147 (ParameterReference.DoResolve): Check whether the parameter has already
25149 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25150 expression as lvalue.
25152 * statement.cs (FlowBranching): New class for the flow analysis code.
25153 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25154 (LabeledStatement.IsDefined): New public property.
25155 (LabeledStatement.AddUsageVector): New public method to tell flow
25156 analyis that the label may be reached via a forward jump.
25157 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25159 (VariableInfo.Number): New public field. This is used by flow analysis
25160 to number all locals of a block.
25161 (Block.CountVariables): New public property. This is the number of
25162 local variables in this block (including the locals from all parent
25164 (Block.EmitMeta): Number all the variables.
25166 * statement.cs: Added flow analysis support to all classes.
25168 2002-07-31 Martin Baulig <martin@gnome.org>
25170 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25171 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25172 then use this argument.
25174 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25176 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25177 use this to specify /define options.
25179 2002-07-29 Martin Baulig <martin@gnome.org>
25181 * statement.cs (Fixed): Moved all code that does variable lookups
25182 and resolvings from Emit to Resolve.
25184 * statement.cs (For): Moved all code that does variable lookups
25185 and resolvings from Emit to Resolve.
25187 * statement.cs (Using): Moved all code that does variable lookups
25188 and resolvings from Emit to Resolve.
25190 2002-07-29 Martin Baulig <martin@gnome.org>
25192 * attribute.cs (Attribute.Resolve): Explicitly catch a
25193 System.NullReferenceException when creating the
25194 CustromAttributeBuilder and report a different warning message.
25196 2002-07-29 Martin Baulig <martin@gnome.org>
25198 * support.cs (ParameterData.ParameterName): Added method to
25199 get the name of a parameter.
25201 * typemanager.cs (TypeManager.IsValueType): New public method.
25203 2002-07-29 Martin Baulig <martin@gnome.org>
25205 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25206 is a flag which specifies that it's either ref or out.
25207 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25208 the out parameter to `out Parameter.Modifier mod', also set the
25209 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25211 * support.cs (InternalParameters.ParameterModifier): Distinguish
25212 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25213 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25215 * expression.cs (Argument.GetParameterModifier): Distinguish
25216 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25217 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25219 2002-07-29 Martin Baulig <martin@gnome.org>
25221 * expression.cs (ParameterReference.ParameterReference): Added
25222 `Location loc' argument to the constructor.
25224 * cs-parser.jay: Pass location to ParameterReference.
25226 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25228 * statement.cs (Try): Initialize the location.
25230 * cs-parser.jay: pass location to Try.
25232 * expression.cs (Unary.Reduce): Change the prototype to return
25233 whether a constant fold could be performed or not. The result is
25234 returned in an out parameters. In the case of Indirection and
25235 AddressOf, we want to perform the full tests.
25237 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25239 * statement.cs (Statement.Emit): Flag dead code.
25241 2002-07-27 Andrew Birkett <andy@nobugs.org>
25243 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25245 2002-07-27 Martin Baulig <martin@gnome.org>
25247 * class.cs (MethodData.Define): Put back call to
25248 TypeManager.AddMethod(), accidentally commented this out.
25250 * report.cs (Debug): New public method to print debugging information,
25251 this is `[Conditional ("DEBUG")]'.
25253 2002-07-26 Martin Baulig <martin@gnome.org>
25255 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25256 (switch_statement): Push the current_block to the switch_stack and
25257 pop it again when we're done with the switch.
25258 (switch_section): The new block is a child of the current_block.
25259 Fixes bug #24007, added test-152.cs.
25261 2002-07-27 Martin Baulig <martin@gnome.org>
25263 * expression.cs (Invocation.EmitArguments): When calling a varargs
25264 function with only its fixed arguments, we need to pass an empty
25267 2002-07-27 Martin Baulig <martin@gnome.org>
25269 Mono 0.13 has been released.
25271 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25273 * driver.cs: Rename --resource to --linkres, because that is what
25274 we do currently, we dont support --resource yet.
25276 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25278 2002-07-25 Martin Baulig <martin@gnome.org>
25280 * class.cs (MethodData): New public class. This is a `method builder'
25281 class for a method or one accessor of a Property/Indexer/Event.
25282 (MethodData.GetMethodFlags): Moved here from MemberBase.
25283 (MethodData.ApplyAttributes): Likewise.
25284 (MethodData.ApplyObsoleteAttribute): Likewise.
25285 (MethodData.ApplyConditionalAttribute): Likewise.
25286 (MethodData.ApplyDllImportAttribute): Likewise.
25287 (MethodData.CheckAbstractAndExternal): Likewise.
25288 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25289 (MethodData.Emit): Formerly known as Method.Emit().
25290 (MemberBase): Moved everything which was specific to a single
25291 accessor/method to MethodData.
25292 (Method): Create a new MethodData and call Define() and Emit() on it.
25293 (Property, Indexer, Event): Create a new MethodData objects for each
25294 accessor and call Define() and Emit() on them.
25296 2002-07-25 Martin Baulig <martin@gnome.org>
25298 Made MethodCore derive from MemberBase to reuse the code from there.
25299 MemberBase now also checks for attributes.
25301 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25302 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25304 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25305 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25306 (MemberBase.ApplyAttributes): New virtual method; applies the
25307 attributes to a method or accessor.
25308 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25309 (MemberBase.ApplyConditionalAttribute): Likewise.
25310 (MemberBase.ApplyDllImportAttribute): Likewise.
25311 (MemberBase.CheckAbstractAndExternal): Likewise.
25312 (MethodCore.ParameterTypes): This is now a property instead of a
25313 method, it's initialized from DoDefineParameters().
25314 (MethodCore.ParameterInfo): Removed the set accessor.
25315 (MethodCore.DoDefineParameters): New protected virtual method to
25316 initialize ParameterTypes and ParameterInfo.
25317 (Method.GetReturnType): We can now simply return the MemberType.
25318 (Method.GetMethodFlags): Override the MemberBase version and add
25319 the conditional flags.
25320 (Method.CheckBase): Moved some code from Define() here, call
25321 DoDefineParameters() here.
25322 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25323 here to avoid some larger code duplication.
25324 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25325 ensure that abstract and external accessors don't declare a body.
25327 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25328 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25329 lookup in the attribute's parent classes, so we need to abort as soon
25330 as we found the first match.
25331 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25332 the attribute has no arguments.
25334 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25337 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25339 * cs-parser.jay: reverted previous patch.
25341 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25343 * cs-parser.jay: fixed bug #22119.
25345 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25347 * attribute.cs: fixed compilation. The error was:
25348 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25349 be assigned to before control leaves the current method."
25350 [FIXME: Filed as bug #28186: MCS must report this error.]
25352 2002-07-25 Martin Baulig <martin@gnome.org>
25354 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25355 method to pull the condition name ouf of a Conditional attribute.
25356 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25357 the obsolete message and error flag out of an Obsolete attribute.
25359 * class.cs (Method.GetMethodFlags): New public method to get the
25360 TypeManager.MethodFlags for this method.
25361 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25363 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25364 if we're overriding a virtual function, set the new private variable
25365 `parent_method'; call the new TypeManager.AddMethod().
25367 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25368 the MethodBuilder and the Method in a PtrHashtable.
25369 (TypeManager.builder_to_method): Added for this purpose.
25370 (TypeManager.MethodFlags): Added IsObsoleteError.
25371 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25372 Obsolete and Conditional arguments in MethodBuilders. If we discover
25373 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25374 the message from the attribute.
25376 2002-07-24 Martin Baulig <martin@gnome.org>
25378 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25379 preprocessor directives, ensure that the argument to #define/#undef is
25380 exactly one identifier and that it's actually an identifier.
25382 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25385 2002-07-24 Martin Baulig <martin@gnome.org>
25387 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25388 initialize it to TypeManager.object_type in the constructor.
25389 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25390 of the `hm.get_current' method if we're using the collection pattern.
25391 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25392 for the explicit conversion to make it work when we're using the collection
25393 pattern and the `Current' property has a different return type than `object'.
25396 2002-07-24 Martin Baulig <martin@gnome.org>
25398 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25399 does not match, but don't report any errors. This method is called in
25400 order for all methods in a MethodGroupExpr until a matching method is
25401 found, so we don't want to bail out if the first method doesn't match.
25402 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25403 matches, report the 123. Fixes #28070.
25405 2002-07-24 Martin Baulig <martin@gnome.org>
25407 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25408 TypeManager.TypeToCoreType() to the top of the method so the
25409 following equality checks will work. Fixes #28107.
25411 2002-07-24 Martin Baulig <martin@gnome.org>
25413 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25414 operand is of type uint, and the other operand is of type sbyte,
25415 short or int, the operands are converted to type long." -
25416 Actually do what this comment already told us. Fixes bug #28106,
25419 2002-07-24 Martin Baulig <martin@gnome.org>
25421 * class.cs (MethodBase): New abstract class. This is now a base
25422 class for Property, Indexer and Event to avoid some code duplication
25423 in their Define() and DefineMethods() methods.
25424 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25425 generic methods for Define() and DefineMethods().
25426 (FieldBase): Derive from MemberBase, not MemberCore.
25427 (Property): Derive from MemberBase, not MemberCore.
25428 (Property.DefineMethod): Moved all the code from this method to the
25429 new MethodBase.DefineAccessor(), just call it with appropriate
25431 (Property.Define): Call the new Property.DoDefine(), this does some
25432 sanity checks and we don't need to duplicate the code everywhere.
25433 (Event): Derive from MemberBase, not MemberCore.
25434 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25435 accessors, this will also make them work with interface events.
25436 (Indexer): Derive from MemberBase, not MemberCore.
25437 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25438 (Indexer.Define): Use the new MethodBase functions.
25440 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25441 argument to the constructor.
25442 (Interface.FindMembers): Added support for interface events.
25443 (Interface.PopluateEvent): Implemented.
25445 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25447 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25449 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25450 but this is required to check for a method name being the same as
25451 the containing class.
25455 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25457 * interface.cs: initialize variable.
25459 2002-07-23 Martin Baulig <martin@gnome.org>
25461 Implemented the IndexerName attribute in interfaces.
25463 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25464 name if this is an explicit interface implementation.
25465 (Indexer.InterfaceIndexerName): New public variable. If we're
25466 implementing an interface indexer, this is the IndexerName in that
25467 interface. Otherwise, it's the IndexerName.
25468 (Indexer.DefineMethod): If we're implementing interface indexer,
25469 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25470 and Pending.ImplementIndexer methods.
25471 (Indexer.Define): Also define the PropertyBuilder if we're
25472 implementing an interface indexer and this is neither an explicit
25473 interface implementation nor do the IndexerName match the one in
25476 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25477 If a method is defined here, then we always need to create a proxy
25478 for it. This is used when implementing interface indexers.
25479 (Pending.IsInterfaceIndexer): New public method.
25480 (Pending.ImplementIndexer): New public method.
25481 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25482 This is used when implementing interface indexers to define a proxy
25484 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25485 define a proxy if necessary.
25487 * interface.cs (Interface.IndexerName): New public variable.
25488 (Interface.PopulateIndexer): Set the IndexerName.
25489 (Interface.DefineIndexers): New private method. Populate all the
25490 indexers and make sure their IndexerNames match.
25492 * typemanager.cs (IndexerPropertyName): Added support for interface
25495 2002-07-22 Martin Baulig <martin@gnome.org>
25497 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25498 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25499 ret if HasReturnLabel.
25500 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25503 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25504 and set the ec.LoopBeginTryCatchLevel.
25505 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25506 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25507 the current ec.TryCatchLevel, the branch goes out of an exception
25508 block. In this case, we need to use Leave and not Br.
25510 2002-07-22 Martin Baulig <martin@gnome.org>
25512 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25513 block unless the block does not always return or it is contained in
25514 another try { ... } catch { ... } block. Fixes bug #26506.
25515 Added verify-1.cs to the test suite.
25517 2002-07-22 Martin Baulig <martin@gnome.org>
25519 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25520 then we do not always return. Fixes bug #24985.
25522 2002-07-22 Martin Baulig <martin@gnome.org>
25524 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25525 lookup on a per-class level; ie. walk up the class hierarchy until we
25526 found at least one applicable method, then choose the best among them.
25527 Fixes bug #24463 and test-29.cs.
25529 2002-07-22 Martin Baulig <martin@gnome.org>
25531 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25532 return types of the methods. The return type is not part of the
25533 signature and we must not check it to make the `new' modifier work.
25534 Fixes bug #27999, also added test-147.cs.
25535 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25537 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25538 on the method's return type.
25540 2002-07-21 Martin Baulig <martin@gnome.org>
25542 * assign.cs: Make this work if the rightmost source is a constant and
25543 we need to do an implicit type conversion. Also adding a few more tests
25544 to test-38.cs which should have caught this.
25546 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25547 target in the makefile for this. The makefile.gnu is primarily intended
25548 for end-users who don't want to debug the compiler.
25550 2002-07-21 Martin Baulig <martin@gnome.org>
25552 * assign.cs: Improved the Assign class so it can now handle embedded
25553 assignments (X = Y = Z = something). As a side-effect this'll now also
25554 consume less local variables. test-38.cs now passes with MCS, added
25555 a few new test cases to that test.
25557 2002-07-20 Martin Baulig <martin@gnome.org>
25559 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25560 instructions. Fixes bug #27977, also added test-146.cs.
25562 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25564 * cs-tokenizer.cs: fixed getHex ().
25566 2002-07-19 Martin Baulig <martin@gnome.org>
25568 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25569 not Type.GetType() to lookup the array type. This is needed when
25570 we're constructing an array of a user-defined type.
25571 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25572 single-dimensional arrays, but also for single-dimensial arrays of
25575 2002-07-19 Martin Baulig <martin@gnome.org>
25577 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25578 this function is called, it's not allowed to share LocalBuilders
25579 among ILGenerators.
25581 2002-07-19 Martin Baulig <martin@gnome.org>
25583 * expression.cs (Argument.Resolve): Report an error 118 when trying
25584 to pass a type as argument.
25586 2002-07-18 Martin Baulig <martin@gnome.org>
25588 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25589 Conv_R_Un for the signed `long' type.
25591 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25593 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25594 `expr' for the temporary result, as that will fail if we do
25595 multiple resolves on the same expression.
25597 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25599 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25600 ec.TypeContainer for looking up aliases.
25602 * class.cs (TypeContainer): Remove LookupAlias from here.
25604 * decl.cs (DeclSpace); Move here.
25606 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25608 * class.cs (FindMembers): Only call filter if the constructor
25609 bulider is not null.
25611 Also handle delegates in `NestedTypes' now. Now we will perform
25612 type lookups using the standard resolution process. This also
25615 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25616 This uses Expressions (the limited kind that can be parsed by the
25617 tree) instead of strings.
25619 * expression.cs (ComposedCast.ToString): Implement, used to flag
25620 errors since now we have to render expressions.
25622 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25625 * ecore.cs (SimpleName.ToString): ditto.
25627 * cs-parser.jay: Instead of using strings to assemble types, use
25628 Expressions to assemble the type (using SimpleName, ComposedCast,
25629 MemberAccess). This should fix the type lookups in declarations,
25630 because we were using a different code path for this.
25632 * statement.cs (Block.Resolve): Continue processing statements
25633 even when there is an error.
25635 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25637 * class.cs (Event.Define): Also remove the `remove' method from
25638 the list of pending items.
25640 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25641 generate more compact code.
25643 2002-07-17 Martin Baulig <martin@gnome.org>
25645 * const.cs (Const.LookupConstantValue): Add support for constant
25646 `unchecked' and `checked' expressions.
25647 Also adding test case test-140.cs for this.
25649 2002-07-17 Martin Baulig <martin@gnome.org>
25651 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25652 check whether mi.ReturnType implements the IEnumerator interface; the
25653 `==' and the IsAssignableFrom() will fail in this situation.
25655 2002-07-16 Ravi Pratap <ravi@ximian.com>
25657 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25660 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25662 * expression.cs: fixed bug #27811.
25664 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25666 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25667 Molaro: when we are a ref, the value already contains a pointer
25668 value, do not take the address of it.
25670 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25671 * removed mb-parser.jay and mb-tokenizer.cs
25673 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25675 * expression.cs: check against the building corlib void type.
25677 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25679 * ecore.cs: fix for valuetype static readonly fields: when
25680 initializing them, we need their address, not the address of a copy.
25682 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25684 * typemanager.cs: register also enum_type in corlib.
25686 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25688 * class.cs: allow calling this (but not base) initializers in structs.
25690 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25692 * ecore.cs: make sure we compare against the building base types
25695 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25697 * typemanager.cs: fix TypeToCoreType() to handle void and object
25698 (corlib gets no more typerefs after this change).
25700 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25702 * expression.cs (ArrayCreation.EmitArrayArguments): use
25703 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25705 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25706 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25707 array indexes, the runtime actually forbids them.
25709 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25710 for array arguments here.
25712 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25713 instead of the default for ValueTypes.
25715 (New.DoEmit): Use IsValueType instead of
25716 IsSubclassOf (value_type)
25717 (New.DoResolve): ditto.
25718 (Invocation.EmitCall): ditto.
25720 * assign.cs (Assign): ditto.
25722 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25723 Statements *are* currently doing part of their resolution during
25726 Expressions do always resolve during resolve, but statements are
25727 only required to propagate resolution to their children.
25729 2002-07-11 Miguel de Icaza <miguel@ximian.com>
25731 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
25733 (LoadAssembly): Do not add the dll if it is already specified
25735 (MainDriver): Add the System directory to the link path at the end,
25736 after all the other -L arguments.
25738 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
25739 wrong opcode for loading bytes and bools (ldelem.i1 instead of
25740 ldelem.u1) and using the opposite for sbytes.
25742 This fixes Digger, and we can finally run it.
25744 * driver.cs (UnixParseOption): Move the option parsing here.
25745 (CSCParseOption): Implement CSC-like parsing of options.
25747 We now support both modes of operation, the old Unix way, and the
25748 new CSC-like way. This should help those who wanted to make cross
25749 platform makefiles.
25751 The only thing broken is that /r:, /reference: and /lib: are not
25752 implemented, because I want to make those have the same semantics
25753 as the CSC compiler has, and kill once and for all the confussion
25754 around this. Will be doing this tomorrow.
25756 * statement.cs (Unsafe.Resolve): The state is checked during
25757 resolve, not emit, so we have to set the flags for IsUnsfe here.
25759 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25761 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
25762 not catch the Error_ObjectRefRequired in SimpleName (as it is
25763 possible to have a class/instance variable name that later gets
25764 deambiguated), we have to check this here.
25766 2002-07-10 Ravi Pratap <ravi@ximian.com>
25768 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
25769 make static and put into Expression.
25771 (Event.Define): Register the private field of the event with the
25772 TypeManager so that GetFieldFromEvent can get at it.
25774 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
25775 keep track of the private field associated with an event which
25778 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
25781 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
25783 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25785 * expression.cs (Binary.EmitBranchable): this routine emits the
25786 Binary expression in a branchable context. This basically means:
25787 we need to branch somewhere, not just get the value on the stack.
25789 This works together with Statement.EmitBoolExpression.
25791 * statement.cs (Statement.EmitBoolExpression): Use
25794 2002-07-09 Miguel de Icaza <miguel@ximian.com>
25796 * statement.cs (For): Reduce the number of jumps in loops.
25798 (For): Implement loop inversion for the For statement.
25800 (Break): We can be breaking out of a Try/Catch controlled section
25801 (foreach might have an implicit try/catch clause), so we need to
25802 use Leave instead of Br.
25804 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
25805 now). If the instace expression supports IMemoryLocation, we use
25806 the AddressOf method from the IMemoryLocation to extract the
25807 address instead of emitting the instance.
25809 This showed up with `This', as we were emitting the instance
25810 always (Emit) instead of the Address of This. Particularly
25811 interesting when This is a value type, as we dont want the Emit
25812 effect (which was to load the object).
25814 2002-07-08 Miguel de Icaza <miguel@ximian.com>
25816 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
25818 * statement.cs (Checked): Set the CheckedState during the resolve
25819 process too, as the ConvCast operations track the checked state on
25820 the resolve process, and not emit.
25822 * cs-parser.jay (namespace_member_declaration): Flag that we have
25823 found a declaration when we do. This is used to flag error 1529
25825 * driver.cs: Report ok when we display the help only.
25827 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
25829 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
25831 2002-07-04 Miguel de Icaza <miguel@ximian.com>
25833 * cs-tokenizer.cs (define): We also have to track locally the
25834 defines. AllDefines is just used for the Conditional Attribute,
25835 but we also need the local defines for the current source code.
25837 2002-07-03 Miguel de Icaza <miguel@ximian.com>
25839 * statement.cs (While, For, Do): These loops can exit through a
25840 Break statement, use this information to tell whether the
25841 statement is the last piece of code.
25843 (Break): Flag that we break.
25845 * codegen.cs (EmitContexts): New `Breaks' state variable.
25847 2002-07-03 Martin Baulig <martin@gnome.org>
25849 * class.cs (TypeContainer.MethodModifiersValid): Allow override
25850 modifiers in method declarations in structs. Otherwise, you won't
25851 be able to override things like Object.Equals().
25853 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25855 * class.cs (Method, Property, Indexer): Do not allow the public
25856 modifier to be used in explicit interface implementations.
25858 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
25859 override modifiers in method declarations in structs
25861 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
25863 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
25864 integer or real overflow, report an error
25866 2002-07-02 Martin Baulig <martin@gnome.org>
25868 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
25869 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
25870 to tell the runtime about our newly created System.Object and
25871 System.ValueType types.
25873 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25875 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
25876 struct instead of Ldarg/Starg.
25878 2002-07-02 Martin Baulig <martin@gnome.org>
25880 * expression.cs (Indirection.Indirection): Call
25881 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
25883 2002-07-02 Martin Baulig <martin@gnome.org>
25885 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
25886 ValueType, call TypeManager.TypeToCoreType() on it.
25887 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
25888 the OpCodes.Newarr argument.
25890 2002-07-02 Martin Baulig <martin@gnome.org>
25892 * expression.cs (Invocation.EmitCall): When compiling corlib,
25893 replace all calls to the system's System.Array type to calls to
25894 the newly created one.
25896 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
25897 System.Array methods.
25898 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
25899 from the system's System.Array type which must be replaced.
25901 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
25903 * typemanager.cs: load unverifiable_code_ctor so we can build
25904 corlib using the correct type. Avoid using GetTypeCode() with
25906 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
25907 TypeManager.object_type to allow building corlib.
25909 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
25911 * ecore.cs: handle System.Enum separately in LoadFromPtr().
25913 2002-07-01 Martin Baulig <martin@gnome.org>
25915 * class.cs: Make the last change actually work, we need to check
25916 whether `ifaces != null' to avoid a crash.
25918 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25920 * class.cs: when we build structs without fields that implement
25921 interfaces, we need to add the interfaces separately, since there is
25922 no API to both set the size and add the interfaces at type creation
25925 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25927 * expression.cs: the dimension arguments to the array constructors
25928 need to be converted if they are a long.
25930 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
25932 * class.cs: don't emit ldarg.0 if there is no parent constructor
25933 (fixes showstopper for corlib).
25935 2002-06-29 Martin Baulig <martin@gnome.org>
25937 MCS now compiles corlib on GNU/Linux :-)
25939 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
25940 ie. check for MethodImplOptions.InternalCall.
25942 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
25943 and TypeManager.attribute_type are null, so we must explicitly check
25944 whether parent is not null to find out whether it's an attribute type.
25945 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
25946 and SetBuilder, not only if the property is neither abstract nor external.
25947 This is necessary to set the MethodImplOptions on the accessor methods.
25948 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
25949 SetBuilder, see Property.Emit().
25951 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
25952 populate "System.Object", "System.ValueType" and "System.Attribute" since
25953 they've already been populated from BootCorlib_PopulateCoreTypes().
25955 2002-06-29 Martin Baulig <martin@gnome.org>
25957 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
25958 is the NullLiteral, we also need to make sure that target_type is not
25961 2002-06-29 Martin Baulig <martin@gnome.org>
25963 * rootcontext.cs (RootContext.ResolveCore): We must initialize
25964 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
25965 before calling BootstrapCorlib_ResolveDelegate ().
25967 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25969 * statement.cs: fixed build-breaker. All tests passed ok.
25971 2002-06-27 Martin Baulig <martin@gnome.org>
25973 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
25974 for System.Decimal when compiling corlib.
25976 2002-06-27 Martin Baulig <martin@gnome.org>
25978 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
25979 switch blocks which contain nothing but a default clause.
25981 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
25983 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
25985 2002-06-27 Martin Baulig <martin@gnome.org>
25987 * ecore.cs (PropertyExpr.PropertyExpr): Call
25988 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
25990 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
25991 is already a TypeBuilder.
25993 2002-06-27 Martin Baulig <martin@gnome.org>
25995 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
25996 `target_type == TypeManager.array_type', not IsAssignableFrom() in
25997 the "from an array-type to System.Array" case. This makes it work
25998 when compiling corlib.
26000 2002-06-27 Martin Baulig <martin@gnome.org>
26002 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26003 non-static PropertyExpr, set its InstanceExpression. This makes
26004 the `ICollection.Count' property work in System/Array.cs.
26006 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26008 * driver.cs: Made error handling more consistent. Errors now
26009 tracked by Report class, so many methods which used to return int
26010 now return void. Main() now prints success/failure and
26011 errors/warnings message.
26013 Renamed '--probe' compiler argument to '--expect-error'. Removed
26014 the magic number return values (123 and 124). Now, if the
26015 expected error occurs, the compiler exits with success (exit value
26016 0). If the compilation completes without seeing that particular
26017 error, the compiler exits with failure (exit value 1). The
26018 makefile in mcs/errors has been changed to handle the new behaviour.
26020 * report.cs: Made 'expected error' number a property and renamed
26021 it from 'Probe' to 'ExpectedError'.
26023 * genericparser.cs: Removed error handling support, since it is
26024 now all done by Report class.
26026 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26027 class, so parse() no longer returns an int.
26029 * namespace.cs: Use Report.Error instead of GenericParser.error
26031 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26033 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26034 TypeContainer.AddOperator): At the front of the list put the
26035 explicit implementations, so they get resolved/defined first.
26037 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26039 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26040 interface type is implemented by this TypeContainer. Used during
26041 explicit interface implementation.
26043 (Property.Define, Indexer.Define, Method.Define): Validate that
26044 the given interface in the explicit implementation is one of the
26045 base classes for the containing type.
26047 Also if we are explicitly implementing an interface, but there is
26048 no match in the pending implementation table, report an error.
26050 (Property.Define): Only define the property if we are
26051 not explicitly implementing a property from an interface. Use the
26052 correct name also for those properties (the same CSC uses,
26053 although that is really not needed).
26055 (Property.Emit): Do not emit attributes for explicitly implemented
26056 properties, as there is no TypeBuilder.
26058 (Indexer.Emit): ditto.
26060 Hiding then means that we do not really *implement* a pending
26061 implementation, which makes code fail.
26063 2002-06-22 Martin Baulig <martin@gnome.org>
26065 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26066 the return value of Object.GetType(). [FIXME: we need to do this whenever
26067 we get a type back from the reflection library].
26069 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26071 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26073 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26075 * attribute.cs: Return null if we can not look up the type.
26077 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26078 the interface types found.
26080 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26081 interface types found.
26083 * typemanager.cs (GetInterfaces): Make this routine returns alll
26084 the interfaces and work around the lame differences between
26085 System.Type and System.Reflection.Emit.TypeBuilder in the results
26086 result for GetInterfaces.
26088 (ExpandInterfaces): Given an array of interface types, expand and
26089 eliminate repeated ocurrences of an interface. This expands in
26090 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26093 2002-06-21 Martin Baulig <martin@gnome.org>
26095 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26098 2002-06-21 Martin Baulig <martin@gnome.org>
26100 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26101 and called with one of the core types, return the corresponding typebuilder for
26104 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26107 2002-06-21 Martin Baulig <martin@gnome.org>
26109 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26110 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26111 (Expression.ConvertReferenceExplicit): Likewise.
26113 * expression.cs (ElementAccess.DoResolve): Likewise.
26114 (ElementAccess.DoResolveLValue): Likewise.
26116 2002-06-10 Martin Baulig <martin@gnome.org>
26118 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26119 add the "value" parameter to the parameter list.
26121 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26124 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26126 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26127 the argument to an int, uint, long or ulong, per the spec. Also
26128 catch negative constants in array creation.
26130 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26132 * class.cs: do not allow the same interface to appear twice in
26133 the definition list.
26135 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26137 * ecore.cs: don't use ldlen with System.Array.
26139 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26141 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26143 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26145 * modifiers.cs: produce correct field attributes for protected
26146 internal. Easy fix so miguel can work on ther harder stuff:-)
26148 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26150 * pending.cs: New file. Move the code from class.cs here.
26151 Support clearning the pending flag for all methods (when not doing
26152 explicit interface implementation).
26154 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26156 * rootcontext.cs: added a couple more types needed to bootstrap.
26158 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26160 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26161 constructor in the type, instead of any constructor in the type
26162 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26163 a bug in the Mono runtime when applying the params attribute).
26165 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26166 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26168 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26170 * expression.cs (Unary.ResolveOperator): Use TypeManager
26171 to resolve the type.
26173 2002-06-13 Ravi Pratap <ravi@ximian.com>
26175 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26178 * enum.cs (AddEnumMember): Add support to store the attributes associated
26179 with each member too.
26181 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26182 field builders too - this takes care of the enum member case.
26184 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26186 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26187 address-of operator on both value types and pointers.
26189 2002-06-10 Martin Baulig <martin@gnome.org>
26191 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26192 PropertyBuilder to the `property_builders' list.
26194 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26195 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26196 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26197 find any indexers which are inherited from an interface.
26199 2002-06-09 Martin Baulig <martin@gnome.org>
26201 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26202 the same type as the constant if necessary. There's also a test-130.cs
26205 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26207 * typemanager.cs (TypeManager.ChangeType): Previously known as
26208 Enum.ChangeEnumType().
26210 2002-06-09 Martin Baulig <martin@gnome.org>
26212 * expression.cs (Cast.TryReduce): Added support for consts.
26214 2002-06-08 Ravi Pratap <ravi@ximian.com>
26216 * class.cs (Accessor): Hold attributes information so we can pass
26219 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26220 Modify to pass in attributes attached to the methods.
26222 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26224 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26225 to handle the Accessor kind :-)
26227 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26229 2002-06-08 Martin Baulig <martin@gnome.org>
26231 * expression.cs (Unary.TryReduceNegative): Added support for
26234 2002-06-08 Martin Baulig <martin@gnome.org>
26236 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26237 name can't be found in the `defined_names' - the caller will do a
26238 MemberLookup in this case and thus find methods in System.Enum
26239 such as Enum.IsDefined().
26241 2002-06-08 Martin Baulig <martin@gnome.org>
26243 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26244 Convert.ChangeType() which works with TypeBuilder created types.
26245 (Enum.LookupEnumValue, Enum.Define): Use it here.
26247 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26248 `TypeBuilder.BaseType != null' check.
26249 (TypeContainer.FindMembers): Only lookup parent members if we
26250 actually have a parent.
26251 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26252 (ConstructorInitializer.Resolve): Likewise.
26254 * interface.cs (Interface.FindMembers): Added
26255 `TypeBuilder.BaseType != null' check.
26257 * rootcontext.cs (RootContext.ResolveCore): Added
26258 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26259 classes_second_stage.
26261 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26262 debug_type and trace_type when compiling with --nostdlib.
26264 2002-06-07 Martin Baulig <martin@gnome.org>
26266 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26267 (AddField): Set it to true when adding a non-static field.
26268 (DefineType): Use `have_nonstatic_fields' to find out whether we
26269 have non-static fields, not `Fields != null'.
26271 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26273 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26274 dereferencing a null on the static-field code path)
26276 2002-05-30 Martin Baulig <martin@gnome.org>
26278 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26279 to take command line arguments. Use reflection to call the new
26280 custom `Initialize' function on the symbol writer and pass it the
26281 command line arguments.
26283 * driver.cs (--debug-args): New command line argument to pass command
26284 line arguments to the symbol writer.
26286 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26288 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26289 the target type for indexers and properties. Thanks to Joe for
26292 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26294 * typemanager.cs (MethodFlags): returns the method flags
26295 (Obsolete/ShouldIgnore) that control warning emission and whether
26296 the invocation should be made, or ignored.
26298 * expression.cs (Invocation.Emit): Remove previous hack, we should
26299 not do this on matching a base type, we should do this based on an attribute
26301 Only emit calls to System.Diagnostics.Debug and
26302 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26303 on the command line.
26305 * rootcontext.cs: Global settings for tracing and debugging.
26307 * cs-tokenizer.cs (define): New utility function to track
26308 defines. Set the global settings for TRACE and DEBUG if found.
26310 2002-05-25 Ravi Pratap <ravi@ximian.com>
26312 * interface.cs (Populate*): Pass in the TypeContainer as well as
26313 the DeclSpace as parameters so that we can create EmitContexts and
26314 then use that to apply attributes etc.
26316 (PopulateMethod, PopulateEvent, PopulateProperty)
26317 (PopulateIndexer): Apply attributes everywhere.
26319 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26322 (ApplyAttributes): Update accordingly.
26324 We now apply interface attributes for all members too.
26326 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26328 * class.cs (Indexer.Define); Correctly check if we are explicit
26329 implementation (instead of checking the Name for a ".", we
26330 directly look up if the InterfaceType was specified).
26332 Delay the creation of the PropertyBuilder.
26334 Only create the PropertyBuilder if we are not an explicit
26335 interface implementation. This means that explicit interface
26336 implementation members do not participate in regular function
26337 lookups, and hence fixes another major ambiguity problem in
26338 overload resolution (that was the visible effect).
26340 (DefineMethod): Return whether we are doing an interface
26343 * typemanager.cs: Temporary hack until we get attributes in
26344 interfaces (Ravi is working on that) and we get IndexerName
26345 support in interfaces.
26347 * interface.cs: Register the indexers as properties.
26349 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26350 warning, I have verified that this is a bug in the .NET runtime
26351 (JavaScript suffers of the same problem).
26353 * typemanager.cs (MemberLookup): When looking up members for
26354 interfaces, the parent of an interface is the implicit
26355 System.Object (so we succeed in searches of Object methods in an
26356 interface method invocation. Example: IEnumerable x; x.ToString
26359 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26361 * class.cs (Event): Events should also register if they do
26362 implement the methods that an interface requires.
26364 * typemanager.cs (MemberLookup); use the new GetInterfaces
26367 (GetInterfaces): The code used to lookup interfaces for a type is
26368 used in more than one place, factor it here.
26370 * driver.cs: Track the errors at the bottom of the file, we kept
26373 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26374 instance if the method we are calling is static!
26376 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26378 * attribute.cs (ApplyAttributes): Make this function filter out
26379 the IndexerName attribute (as that attribute in reality is never
26380 applied) and return the string constant for the IndexerName
26383 * class.cs (TypeContainer.Emit): Validate that all the indexers
26384 have the same IndexerName attribute, and if so, set the
26385 DefaultName attribute on the class.
26387 * typemanager.cs: The return value might contain other stuff (not
26388 only methods). For instance, consider a method with an "Item"
26389 property and an Item method.
26391 * class.cs: If there is a problem with the parameter types,
26394 2002-05-24 Ravi Pratap <ravi@ximian.com>
26396 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26397 looks at user defined conversion after making a call to
26398 StandardConversionExists - we need this for overload resolution.
26400 * expression.cs : Update accordingly the various method calls.
26402 This fixes 2 bugs filed against implicit user defined conversions
26404 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26406 * statement.cs: Track the result of the assignment.
26408 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26410 * expression.cs (MemberAccess): Improved error reporting for
26411 inaccessible members.
26413 2002-05-22 Martin Baulig <martin@gnome.org>
26415 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26416 itself with debugging support.
26418 2002-05-22 Martin Baulig <martin@gnome.org>
26420 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26421 Removed, this isn't needed anymore.
26423 2002-05-20 Martin Baulig <martin@gnome.org>
26425 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26426 be underlying type for an enum.
26428 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26430 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26431 that splits out the loading of just the core types.
26433 * rootcontext.cs (ResolveCore): Split the struct resolution in
26434 two, so we can load the enumeration underlying types before any
26437 * expression.cs (Is): Bandaid until we fix properly Switch (see
26438 bug #24985 for details).
26440 * typemanager.cs (ImplementsInterface): The hashtable will contain
26441 a null if there are no interfaces implemented.
26443 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26445 * cs-parser.jay (indexer_declarator): It is fine to have array
26448 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26450 * typemanager.cs: (RegisterBuilder): New function used to register
26451 TypeBuilders that implement interfaces. Since
26452 TypeBuilder.GetInterfaces (as usual) does not work with lame
26454 (AddUserType): register interfaces.
26456 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26457 dealing with TypeBuilder. Also, arrays are showing up as
26458 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26459 methods can not be invoked on them!
26461 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26462 (ImplicitReferenceConversionExists): Split out from
26463 StandardConversionExists.
26465 * expression.cs (As): We were only implementing one of the three
26466 cases for the as operator. We now implement them all.
26467 (Is): Implement the various other cases for Is as well.
26469 * typemanager.cs (CACHE): New define used to control if we want or
26470 not the FindMembers cache. Seems to have a negative impact on
26471 performance currently
26473 (MemberLookup): Nested types have full acess to
26474 enclosing type members
26476 Remove code that coped with instance/static returns for events, we
26477 now catch this in RealFindMembers.
26479 (RealFindMembers): only perform static lookup if the instance
26480 lookup did not return a type or an event.
26482 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26484 * assign.cs (CompoundAssign): We pass more semantic information
26485 now to Compound Assignments than we did before: now we have all
26486 the information at hand, and now we resolve the target *before* we
26487 do the expression expansion, which allows the "CacheValue" method
26488 to have the effect we intended (before, a [x] += 1 would generate
26489 two differen ArrayAccess expressions from the ElementAccess,
26490 during the resolution process).
26492 (CompoundAssign.DoResolve): Resolve target and original_source here.
26494 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26496 * expression.cs (ArrayAccess): dropped debugging information.
26498 * typemanager.cs: Small bug fix: I was always returning i_members,
26499 instead of one of i_members or s_members (depending on which had
26502 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26503 method is invoked before any code generation takes place, and it
26504 is a mechanism to inform that the expression will be invoked more
26505 than once, and that the method should use temporary values to
26506 avoid having side effects
26508 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26510 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26513 * expression.cs (Indirection, ArrayAccess): Add support for
26514 CacheTemporaries in these two bad boys.
26516 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26517 ldobj or ldind_ref.
26518 (StoreFromPtr): Handle stobj as well.
26520 * expression.cs (UnaryMutator): Share more code.
26522 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26523 down: I was not tracking the Filter function as well, which
26524 was affecting the results of the cache.
26526 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26528 * attribute.cs: Remove the hack to handle the CharSet property on
26531 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26533 * attribute.cs (DoResolve): More uglyness, we now only try to
26534 resolve the attribute partially, to extract the CharSet
26535 information (only if we are a StructLayout attribute). Otherwise
26537 (GetExtraTypeInfo): Add some code to conditionally kill in the
26538 future this. I am more and more convinced that the .NET
26539 framework has special code to handle the attribute setting on
26542 * expression.cs (IsParamsMethodApplicable): Revert my previous
26543 foreach change here, it was wrong.
26545 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26547 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26548 (pp_expr): do not abort on unknown input, just return.
26549 (eval): abort if there are pending chars.
26551 * attribute.cs (Attribute.Resolve): Positional parameters are
26552 optional. Deal with that case.
26554 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26555 the Ansi/Unicode/Auto information for the type.
26557 (TypeContainer.DefineType): instantiate the EmitContext here, as
26558 we will be using it during the type definition (to resolve
26559 attributes) and during the emit phase.
26561 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26562 to pull type information out of the attributes
26564 (Attribute.Resolve): track the constructor builder, and allow for
26565 multiple invocations (structs and classes will use this).
26567 * ecore.cs (MemberLookupFinal): new version with all the
26568 parameters customizable.
26570 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26571 constructors. Return if the result value is null (as the error
26572 would have been flagged already by MemberLookupFinal)
26574 Do not allow instances of abstract classes or interfaces to be
26577 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26578 We have to compare the assembly property here when dealing with
26579 FamANDAssem and Assembly access modifiers, because we might be
26580 creating an assembly from *modules* (that means that we are not
26581 getting TypeBuilders for types defined in other modules that are
26582 part of this assembly).
26584 (Method.Emit): If the method is marked abstract and has a body,
26587 (TypeContainer.DefineMembers): If both the defined member and the
26588 parent name match are methods, then do not emit any warnings: let
26589 the Method.Define routine take care of flagging warnings. But if
26590 there is a mismatch (method overrides something else, or method is
26591 overriwritten by something, then emit warning).
26593 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26594 set to null, this means `do not check for the return type on the
26597 (Method.Define): set the return type for the method signature to
26598 null, so that we get methods with the same name and parameters and
26599 different return types. This is used to flag warning 114 (you are
26600 hiding a method, and you probably want to use the new/override
26603 * typemanager.cs (MemberLookup): Implemented proper access
26604 control, closing a long standing set of bug reports. The problem
26605 was that the Framework only has two bits: Public and NonPublic,
26606 and NonPublic includes private and protected methods, but we need
26607 to enforce the FamANDAssem, FamOrAssem and Family.
26609 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26611 * statement.cs (GotoCase): Return true: Ammounts to giving up
26612 knowledge on whether we return or not, and letting the other case
26613 be responsible for it.
26615 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26617 * driver.cs: Do not load directories for each file processed, only
26618 do it if there is a pattern.
26620 * ecore.cs: Report readonly assigns here as well, as we might have
26621 been resolved only by MemberAccess.
26623 (SimpleName.SimpleNameResolve): Also be useful for LValue
26624 resolution. We need this to propagate assign to local readonly variables
26626 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26627 do not want to reuse potential criteria memory.
26629 * class.cs (MyEventBuilder): Set reflected_type;
26631 * ecore.cs (Constantify): Added support for constifying bools.
26633 (RootContext.LookupType): Added a cache for values looked up in
26634 the declaration space.
26636 * typemanager.cs (FindMembers): Now is a front-end to
26637 RealFindMembers, and provides a two-level hashtable-based cache to
26640 15% performance improvement: from 22.5 to 19.2 seconds.
26642 * expression.cs (IsParamsMethodApplicable): use foreach.
26643 (Invocation.DoResolve): ditto.
26644 (New.DoResolve): ditto.
26645 (ArrayCreation.DoResolve): ditto.
26647 * ecore.cs (FindMostEncompassingType): use foreach.
26649 * delegate.cs (NewDelegate.DoResolve): Use foreach
26651 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26652 (RemoveMethods): use foreach.
26654 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26655 nested foreach statements instead of for, and also break out of
26656 the inner loop once a match is found.
26658 (Invocation.OverloadResolve): Use foreach, simplify the code.
26660 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26662 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26663 we actually unwrap the expression to allow for extra information
26666 * expression.cs: Use Shr_Un on unsigned operations.
26668 2002-05-08 Ravi Pratap <ravi@ximian.com>
26670 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26671 applicable operators was not being considered correctly. This closes
26672 the bug Miguel reported.
26674 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26676 * attribute.cs: check that the type derives from System.Attribute
26677 and report the correct error in that case (moved the duplicate code to
26678 its own method, too).
26680 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26682 * attribute.cs: lookup attribute type name as the spec says: first the
26683 bare attribute name and then name + "Attribute" (nant compiles with
26684 mcs after this fix).
26686 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26688 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26689 Because of the way we parse things, we should try to see if a
26690 UIntConstant can fit in an integer.
26692 2002-05-07 Ravi Pratap <ravi@ximian.com>
26694 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26695 when we are in an explicit context.
26697 (ConvertReferenceExplicit): When converting from Iface type S to Class
26698 T make sure the rules are implemented as an OR.
26700 * parameter.cs (ParameterType): Make it a property for now although the
26701 purpose really isn't anything immediate.
26703 * expression.cs (Is*Applicable): Do better checking on the parameter type
26704 of a ref/out parameter. The ones from the system assemblies are already
26705 marked with the correct type so we don't need to do any correction.
26707 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26708 the object type is standard too so include that.
26710 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26712 * ecore.cs (StandardConversionExists): Augment with missing code:
26713 deal with IntConstant, LongConstants and Enumerations.
26715 * assign.cs: Report the error, instead of failing silently
26717 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26718 typecontainer that they are declared, because the
26719 typecontainer/namespace will have the list of using clauses that
26720 need to be applied.
26722 Assembly Attributes were escaping the normal registration
26725 (EmitCode): Apply attributes within an EmitContext that represents
26726 the container they were declared on.
26728 * cs-parser.jay: Track bases for structs. How did I get this wrong?
26730 2002-05-06 Ravi Pratap <ravi@ximian.com>
26732 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
26733 Revamp completely - make much cleaner as we now operate only
26736 (FindMostSpecificSource, FindMostSpecificTarget): New methods
26737 to implement the logic detailed in the spec more correctly.
26739 (UserDefinedConversion): Update accordingly.
26741 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26743 * statement.cs: Return flow analysis information up.
26745 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
26748 (token): Do not consume an extra character before calling
26751 2002-05-06 Piers Haken <piersh@friskit.com>
26753 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
26755 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26757 * class.cs (Constructor.Emit): Set the IsStatic flag in the
26758 EmitContext during the instance constructor initializer
26759 resolution, to stop access to instance variables.
26761 This is mandated by the spec, last paragraph of the `constructor
26762 initializers' section.
26764 2002-05-05 Miguel de Icaza <miguel@ximian.com>
26766 * cs-parser.jay, class.cs (Accessor): new class used to represent
26767 an accessor (get or set). In the past we used `null' to represent
26768 a missing accessor. But this is ambiguous because there was no
26769 way to tell in abstract indexers/properties if one of them was
26772 Now there is a way of addressing that.
26774 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
26775 instead of FindMembers.
26777 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
26778 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
26780 * attribute.cs: Treat indexers and properties as the same in terms
26781 of applying attributes
26783 * ecore.cs (FindMostEncompassedType): Use statically initialized
26784 EmptyExpressions()s like we do elsewhere to avoid creating useless
26785 objects (and we take this out of the tight loop).
26787 (GetConversionOperators): Move the code to extract the actual
26788 operators to a separate routine to clean things up.
26790 2002-05-04 Miguel de Icaza <miguel@ximian.com>
26792 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
26793 events are always registered FieldBuilders.
26795 * class.cs (FieldBase): New class shared by Fields
26797 * delegate.cs: If we are a toplevel delegate, use our full name.
26798 If we are a nested delegate, then only use our tail name.
26800 2002-05-02 Ravi Pratap <ravi@ximian.com>
26802 * expression.cs (IsApplicable): Ensure that we add the "&" to
26803 ref/out types before comparing it with the type of the argument.
26805 (IsParamsMethodApplicable): Ditto.
26807 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
26810 * delegate.cs : Handle the case when we have more than one applicable
26811 method. Flag an error only when we finish checking all.
26813 2002-05-02 Miguel de Icaza <miguel@ximian.com>
26815 * expression.cs: Add support for boolean static initializers.
26817 2002-05-01 Miguel de Icaza <miguel@ximian.com>
26819 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
26821 * parameter.cs (ComputeParameterTypes,
26822 ComputeAndDefineParameterTypes): Better error handling: now we
26823 clear the `types' cache if we fail during any of the type lookups.
26824 We also return the status code correctly to our caller
26826 * delegate.cs: If we fail to define a delegate, abort the extra
26829 * expression.cs (Binary.ResolveOperator): for
26830 operator==(object,object) and operator !=(object, object) we also
26831 have to verify that there is an implicit conversion from one to
26834 (ArrayAccess.DoResolve): Array Access can operate on
26837 2002-04-30 Miguel de Icaza <miguel@ximian.com>
26839 * assign.cs (CompoundAssign): A new class used as a "flag" that
26840 the assignment actually is happening as part of a compound
26841 assignment operator.
26843 During compound assignment, a few new rules exist to enable things
26850 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
26851 to the type of x) if y is implicitly convertible to the type of x,
26852 and the operator is a builtin operator and the return type of the
26853 operator is explicitly convertible to the type of x.
26855 * rootcontext.cs: Reset warning level to 2. 4 catches various
26856 "interesting" features in mcs, we must clean this up at some
26857 point, but currently am trying to kill other bugs ;-)
26859 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
26860 in container classes as well.
26862 * expression.cs (Binary.ResolveOperator): Handle string case
26863 before anything else (as operator overloading does emit an error
26864 before doing anything else).
26866 This code could go away when we move to a table driven model, but
26867 i could not come up with a good plan last night.
26869 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
26871 * typemanager.cs (CSharpName): reimplementation using regex.
26872 * class.cs: added null check for fields in Emit
26873 * rootcontext.cs: set warninglevel to 4
26875 2002-04-29 Miguel de Icaza <miguel@ximian.com>
26877 * typemanager.cs (CSharpName): reimplemented with Lupus
26880 2002-04-28 Miguel de Icaza <miguel@ximian.com>
26882 * statement.cs (If): correclty implement Resolve, because we were
26883 not catching sem errors in there. The same process is needed
26885 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
26888 (Statement.Warning_DeadCodeFound): Factorize code.
26889 (While): Report dead code here too.
26891 (Statement): Added Resolve virtual method to allow
26892 for resolution split from the emit code.
26894 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26896 * statement.cs (EmitBoolExpression): No longer try to resolve the
26898 (MakeBoolean): New utility function that resolve, implicitly
26899 converts to boolean and tags the expression.
26902 (If, Do): Implement dead code elimination.
26903 (While): Implement loop inversion
26905 (Do, While, For, If): Resolve the expression prior to calling our
26908 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
26911 - added method Report28 (warning: program has more than one entry point)
26912 - added method IsEntryPoint, implements paragraph 10.1 of the spec
26913 - modified method Method.Define, the part at the end of the method
26915 * rootcontext.cs: added static public Location EntryPointLocation;
26917 * ../errors/cs0028.cs : Add test case for the above warning.
26920 - modified method CSharpName to allow arrays of primitive type to
26921 be printed nicely (e.g. instead of System.Int32[][] it now prints
26923 - added method CSharpSignature: returns the signature of a method
26924 in string format to be used in reporting errors, warnings, etc.
26926 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
26929 2002-04-26 Ravi Pratap <ravi@ximian.com>
26931 * delegate.cs (Define): Fix extremely silly bug where I was
26932 setting the type of the 'object' parameter of the BeginInvoke
26933 method to System.IAsyncResult instead of System.Object ;-)
26935 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26937 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
26940 (Constructor.Emit): return if we fail to initialize the
26941 constructor. Another door closed!
26943 * expression.cs (New.DoResolve): Improve error message (from -6 to
26944 1501). Use DeclaredOnly lookup to find the exact constructor.
26946 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
26947 loop. This is useful.
26949 * cs-parser.jay: Adjust the default parameters so that destructors
26950 have the proper signature.
26952 2002-04-26 Martin Baulig <martin@gnome.org>
26954 * driver.cs (LoadAssembly): If `assembly' contains any characters
26955 which are only valid in path names and not in assembly names
26956 (currently slash, backslash and point), use Assembly.LoadFrom ()
26957 instead of Assembly.Load () on the `assembly' (before iteration
26958 over the link_paths).
26960 2002-04-26 Martin Baulig <martin@gnome.org>
26962 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
26964 2002-04-25 Miguel de Icaza <miguel@ximian.com>
26966 * class.cs (Property): use the new typemanager.MemberLookup
26968 (TypeContainer.MemberLookup): Implement using the
26969 TypeManager.MemberLookup now.
26971 * typemanager.cs: Make MemberLookup a function of the TypeManager,
26972 and return MemberInfos, so that these can be used without an
26973 EmitContext (what we had before).
26975 2002-04-24 Miguel de Icaza <miguel@ximian.com>
26977 * expression.cs: Fix the case where the argument to params if the
26978 type of the params. I omitted handling this before. Fixed
26980 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26982 * driver.cs: Call BootCorlib_PopulateCoreType
26984 * class.cs (Property.CheckBase): Check for properties only, not
26987 * interface.cs: Temporary hack: try/catch around the
26988 CustomAttributeBuilder, because I am getting an exception that I
26991 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
26992 types whose definitions are required to be there (attributes are
26993 defined before standard types).
26995 Compute definitions as we boot the various types, as they are used
26996 immediately (value_type class will need object_type, but if we do
26997 not initialize object_type, we will pass a null, which will let
26998 the runtime pick the System.Object from the existing corlib, which
26999 is not what we want).
27001 2002-04-22 Patrik Torstensson <totte@labs2.com>
27003 * cs-tokenizer.cs: fixed a number of trim() issues.
27005 2002-04-22 Ravi Pratap <ravi@ximian.com>
27007 * expression.cs (Argument.Type): Ensure that we return the correct
27008 type when we have out or ref parameters [in which case we
27011 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27013 * class.cs (Property, Indexer): Allow extern modifier in there.
27015 * typemanager.cs (InitBaseTypes): Initializes object_type and
27016 value_type, since those will be used early on during the bootstrap
27017 process to compile corlib.
27019 (InitCoreTypes): Move code from here to InitBaseTypes.
27021 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27023 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27024 single-dimension arrays as using the ldlen opcode.
27026 Daniel Lewis discovered this optimization.
27028 * typemanager.cs: Add signature for System.Array::get_Length
27030 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27032 * statement.cs: report the error when the foreach does not apply to an
27033 array nor a collection.
27035 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27037 * expression.cs: Add implicit conversions to the operator ~.
27039 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27041 * typemanager.cs: Locate the decimal constructor.
27043 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27045 * attribute.cs: use the new property of TypeOf.
27046 * expression.cs: added 'get' property around typearg.
27048 These changes fix a build breaker reported by NickD. Is this the
27049 correct way to fix? If not, please, revert my changes and make it
27052 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27054 * attribute.cs: Add support for typeof in attribute invocations.
27055 I am not sure that this is right though.
27057 2002-04-14 Duncan Mak <duncan@ximian.com>
27059 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27060 Binary.Operator.Division case.
27062 2002-04-13 Ravi Pratap <ravi@ximian.com>
27064 * class.cs (DefineType): Ensure that we do a proper check on
27065 attribute types and also register it with the TypeManager.
27067 (TypeContainer.Targets): The default for attribute types is
27068 AttributeTargets.All.
27070 * attribute.cs (ApplyAttributes): Registering the attribute type
27071 is done elsewhere, not when we discover we have a Usage attribute.
27073 2002-04-12 Ravi Pratap <ravi@ximian.com>
27075 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27076 and get rid of is_delegate parameter.
27078 * everywhere : update.
27080 2002-04-12 Ravi Pratap <ravi@ximian.com>
27082 * cs-parser.jay (compilation_unit): Revamp completely to use
27083 some new ideas that I got from Rhys' grammar to solve the problems
27084 with assembly level attributes.
27086 (outer_declaration): New grammar production.
27088 (attribute_sections): Add.
27090 (opt_attributes): Base on attribute_sections
27092 (namespace_declaration): Allow opt_attributes to tackle the case
27093 when we have assembly level attributes - we are clever in this
27096 * attribute.cs (ApplyAttributes): Do not worry about assembly
27097 attributes in the non-global context.
27099 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27100 instead of SetGlobalAttributes.
27102 * class.cs, rootcontext.cs : Ensure we define and generate
27103 attribute types before anything else.
27105 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27106 and flag the new error -20 for the case when the attribute type
27107 does not have valid targets specified. csc does not catch this.
27109 * ../errors/errors.txt : update for error # -20
27111 2002-04-11 Ravi Pratap <ravi@ximian.com>
27113 * support.cs (InternalParameters.ParameterModifier): Do some null
27114 checking and return sane values.
27116 * class.cs (Method.Define): If we are a PInvoke method, ensure
27117 that we are static and extern. Report error # 601
27119 * ../errors/cs0601.cs : Add test case for the above error.
27121 2002-04-07 Ravi Pratap <ravi@ximian.com>
27123 * rootcontext.cs (attribute_types): We need to keep type of
27124 all attribute types separately and emit code for them first.
27126 (RegisterAttribute) : Implement.
27128 * class.cs (DefineType): Check if the current Type is a custom
27129 attribute type and register it accordingly.
27131 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27132 adding the first attribute twice and rename to
27134 (SetGlobalAttributes): this.
27136 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27139 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27140 if we are processing global arguments. Hmm, I am unsure of this.
27142 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27144 * expression.cs: added static array of strings to avoid calling
27145 Enum.ToString () for Operator in Binary. Significant recover of
27148 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27150 * class.cs (FindMembers): Allow the Builders of the various
27151 members to be null. If they are skip them. This only happens
27152 during the PInvoke declaration.
27154 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27156 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27157 failure, so we do not keep going afterwards.
27159 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27160 wanted to pass `false' as the `is_delegate' argument. If this is
27161 the case, why not use delegate_type == null to mean `is_delegate =
27162 false' and anything else as is_delegate = true.
27164 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27166 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27167 code for the section, not the beginning of the tests.
27169 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27171 * cfold.cs: Handle operator + (Enum x, Underlying x)
27173 * expression.cs (Binary): same. Warn about errors where we have
27174 Enum/Enum in operator + as well.
27176 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27179 - added support for switch(bool)
27180 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27181 - add TableSwitchEmit() to handle table-based switch statements
27183 2002-04-05 Ravi Pratap <ravi@ximian.com>
27185 * expression.cs (Invocation.OverloadResolve): Factor out code which
27186 does parameter compatibility checking with arguments so that we can
27187 re-use the code even from Delegate.VerifyApplicability
27189 (VerifyArgumentsCompat): Move above code here.
27191 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27192 and instead make a call to the above method.
27194 2002-03-31 Ravi Pratap <ravi@ximian.com>
27196 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27197 We use it to keep track of classes which are attribute types.
27199 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27201 * delegate.cs (Delegate.Define): Correctly define the types in the
27202 presence of fixed and array parameters.
27204 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27207 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27208 include NonPublic after the first iteration.
27210 * class.cs (Indexer.CheckBase): Only check if both parents are
27213 * cs-parser.jay (accessor_body): If empty, set to null.
27215 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27216 same code path here to resolve constants names that we did have in
27217 MemberAccess.DoResolve. There is too much code duplicated here.
27219 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27221 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27223 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27226 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27227 tokens, numbers and strings.
27229 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27232 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27233 asyncronous parameters and the regular parameters.
27235 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27236 specify the target directory.
27238 * expression.cs: (This.DoResolve): Simplify
27239 (As.Emit): Optimize, do not generate IsInst if the expression is
27240 always of the given type.
27242 (Is.DoResolve): Bug fix, we were reporting both always/never for
27245 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27246 creating too many unnecessary arrays.
27248 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27250 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27251 fields instead of rolling our own initializer. Takes care of all
27252 implicit conversions, and drops unnecessary static checks/argument.
27254 2002-03-31 Dick Porter <dick@ximian.com>
27256 * driver.cs: use the GetDirectories() return values properly, and
27257 use "/" as path separator.
27259 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27261 * expression.cs (Unary): Optimize - - expr into expr.
27262 (Binary): Optimize a + (-b) into a -b.
27264 * codegen.cs (CodeGen): Made all methods static.
27266 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27270 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27271 TypeBuilder property.
27273 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27276 * tree.cs: Removed the various RecordXXXX, and replaced with a
27277 single RecordDecl. Removed all the accessor methods, and just
27278 left a single access point Type
27280 * enum.cs: Rename DefineEnum to DefineType.
27282 * decl.cs: New abstract method `DefineType' used to unify the
27283 Defines for Enumerations, Interfaces, TypeContainers and
27286 (FindType): Moved LookupInterfaceOrClass here. Moved the
27287 LookupBaseClasses method that used to live in class.cs and
27288 interface.cs here, and renamed to FindType.
27290 * delegate.cs: Implement DefineType. Take advantage of the
27291 refactored pattern for locating the parent builder without taking
27292 the parent_builder argument (which we know does not work if we are
27293 nested, and triggering a toplevel definition).
27295 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27297 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27298 accessibility of a member has changed during override and report
27301 * class.cs (Method.Define, Property.Define): Only complain on
27302 overrides if the method is private, any other accessibility is
27303 fine (and since we just checked the permission is the same, we are
27306 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27307 and elif are processed always. The other pre-processing
27308 directives are only processed if we are "taking" the path
27310 2002-03-29 Martin Baulig <martin@gnome.org>
27312 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27313 current location is not Null.
27315 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27316 a separate method so we can profile it.
27318 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27319 `span.Seconds' are just seconds, but no minutes or hours.
27320 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27322 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27324 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27325 Remove the gratuitous set of Final:
27327 // If an interface implementation, then we can set Final.
27328 if (((flags & MethodAttributes.Abstract) == 0) &&
27329 implementing.DeclaringType.IsInterface)
27330 flags |= MethodAttributes.Final;
27332 I do not know what I was smoking when I used that.
27335 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27336 step into fixing the name resolution issues for delegates and
27337 unifying the toplevel name resolution.
27339 2002-03-28 Martin Baulig <martin@gnome.org>
27341 * class.cs (Method.Emit): If we have a symbol writer, call its
27342 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27343 tell it about the current method.
27345 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27346 writer that we're going to emit the first byte of IL code for a new
27347 statement (a new source line).
27348 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27349 EmitContext.Mark() before emitting any code.
27351 * location.cs (SymbolDocument): Return null when we're Null.
27353 * statement.cs (Statement): Moved the `Location loc' variable here.
27354 (Statement.EmitBoolExpression): If we have a symbol writer, call
27355 ec.Mark() before emitting any code to tell it that we're at the
27356 beginning of a new statement.
27357 (StatementExpression): Added `Location' argument to the constructor.
27358 (Block): Added public readonly variable `StartLocation' and public
27359 variable `EndLocation'. The latter is to be set using SetEndLocation().
27360 (Block): Added constructor which takes a start and end location.
27361 (Block.SetEndLocation): New method. This sets the end location.
27362 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27363 local variables we create.
27364 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27365 each statement and do also mark the begin and end of the block.
27367 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27368 tell it the current lexer.Location, use Location.Null for the end of the
27370 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27371 current block, set its end location using SetEndLocation().
27372 (statement_expression): StatementExpression constructor now takes the
27373 lexer.Location as additional argument.
27374 (for_statement, declare_local_variables): Likewise.
27375 (declare_local_variables): When creating a new implicit block, use the
27376 new Block constructor and pass it the lexer.Location.
27378 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27380 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27381 members also on the parent interfaces recursively.
27383 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27385 * report.cs: Use new formats, since Gonzalo finished the missing
27388 * expression.cs (Binary.ResolveOperator): added missing operator|
27389 operator& and operator^ for bool/bool.
27391 * cs-parser.jay: CheckDef now takes a Location argument that is
27392 used to report errors more precisly (instead of reporting the end
27393 of a definition, we try to track something which is a lot closer
27394 to the source of the problem).
27396 * cs-tokenizer.cs: Track global token use, so we can properly flag
27397 the use of #define/#undef after the first token has been seen.
27399 Also, rename the reportXXXX to Error_DescriptiveName
27401 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27402 TypeContainer, so that Enum and Interface can use this too.
27404 * class.cs (TypeContainer.LookupInterfaceOrClass,
27405 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27406 `builder' argument. Typically this was used to pass the parent
27407 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27410 The problem is that a nested class could trigger the definition of
27411 a toplevel class, and the builder would be obviously wrong in that
27414 So we drop this argument, and we compute dynamically the
27415 TypeBuilder/ModuleBuilder (the correct information was available
27416 to us anyways from DeclSpace.Parent)
27418 * interface.cs (Interface.DefineInterface): Drop builder
27419 parameter cleanup like class.cs
27421 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27424 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27427 (Try.Emit): Propagate the returns value from the statement.
27429 (Return.Emit): Even if we are leavning
27431 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27433 * modifiers.cs: Fix the computation of MethodAttributes flags.
27435 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27437 * driver.cs: allow compilation of files that start with '/'.
27438 Add a default case when checking the argument of --target.
27440 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27442 * interface.cs: Implement the same search algorithm for types in
27443 the interface code.
27445 * delegate.cs: Do not allow multiple definition.
27447 * Recovered ChangeLog that got accidentally amputated
27449 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27451 * rootcontext.cs: Load manually enum to allow core classes to
27452 contain enumerations.
27454 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27455 Update to new static methods in TypeManager.
27457 * typemanager.cs (GetMethod, GetConstructor): Use our
27458 implementation of FindMembers to find the members, since during
27459 corlib compilation, the types are TypeBuilders and GetMethod and
27460 GetConstructor do not work.
27462 Make all methods in TypeManager static.
27464 (InitCodeHelpers): Split the functionality from
27465 the InitCodeTypes function.
27467 * driver.cs: Call InitCodeHelpers after we have populated the
27470 * cs-parser.jay (delegate_declaration): we did not used to compute
27471 the delegate name correctly for void delegates.
27473 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27475 * rootcontext.cs (RootContext): Init the interface_resolve_order
27476 and type_container_resolve_order always.
27478 (ResolveCore, BootstrapCorlib_ResolveClass,
27479 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27480 compiler when compiling with --nostdlib
27482 * class.cs (TypeContainer.DefineType): Check that our parent is
27483 not null. This test is most important when we are bootstraping
27486 * codegen.cs: Split out the symbol writing code.
27488 2002-03-25 Martin Baulig <martin@gnome.org>
27490 * driver.cs (-g): Made -g an alias for --debug.
27492 2002-03-24 Martin Baulig <martin@gnome.org>
27494 * codegen.cs (SymbolWriter): New public variable. Returns the
27495 current symbol writer.
27496 (CodeGen): Added `bool want_debugging_support' argument to the
27497 constructor. If true, tell the ModuleBuild that we want debugging
27498 support and ask it for the ISymbolWriter.
27499 (Save): If we have a symbol writer, call it's Close() method after
27500 saving the assembly.
27502 * driver.c (--debug): New command line argument to create a
27503 debugger information file.
27505 * location.cs (SymbolDocument): New public property. Returns an
27506 ISymbolDocumentWriter object for the current source file or null
27507 if we don't have a symbol writer.
27509 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27511 * driver.cs (LoadAssembly): Correctly return when all the paths
27512 have been tried and not before.
27514 * statement.cs (Switch.Emit): return the actual coverage for this
27515 statement (returns/not-returns)
27517 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27518 switch of the statement if we are the last switch section. That
27519 kills two problems: try/catch problems (we used to emit an empty
27520 nop at the end) and switch statements where all branches would
27523 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27525 * driver.cs: Add default assemblies (the equivalent to the
27526 Microsoft CSC.RSP file)
27528 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27529 also update tokens_seen and set it to false.
27531 * driver.cs: Implement --recurse for Mike.
27533 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27534 correctly splitting out the paths.
27536 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27538 * interface.cs (Interface.PopulateProperty): Instead of using
27539 `parent' as the declaration space for the set parameters, use
27542 * support.cs (InternalParameters): InternalParameters constructor
27543 takes a DeclSpace instead of a TypeContainer.
27545 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27546 types are being initialized, load the address of it before calling
27549 (New): Provide a mechanism to disable the generation of local
27550 value type temporaries when the caller will be providing us with
27551 an address to store it.
27553 (ArrayCreation.EmitDynamicInitializers): Use it.
27555 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27557 * expression.cs (Invocation.EmitArguments): Only probe for array
27558 property if there is more than one argument. Sorry about that.
27560 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27561 empty param arrays.
27563 * class.cs (Method.LabelParameters): Fix incorrect code path that
27564 prevented the `ParamArrayAttribute' from being applied to the
27567 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27569 * support.cs (ReflectionParameters): Correctly compute whether the
27570 last argument is a params array. Fixes the problem with
27573 * typemanager.cs: Make the assemblies array always be non-null
27574 (empty, but non-null)
27576 * tree.cs (RecordDecl): New function that abstracts the recording
27577 of names. This reports error 101, and provides a pointer to the
27578 previous declaration. Fixes a crash in the compiler.
27580 * cs-parser.jay (constructor_declaration): Update to new grammar,
27581 and provide a constructor_body that can be empty.
27583 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27585 * driver.cs: Add support for --resources.
27587 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27588 Make all types for the various array helper methods be integer.
27590 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27591 CheckState to ConvCast.
27593 (ConvCast): Now it takes a `checked' state argument, to avoid
27594 depending on the emit context for the conversion, and just using
27595 the resolve time setting.
27597 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27598 instead of Invocation.EmitArguments. We do not emit the original
27599 arguments, instead we emit those which have been converted to
27600 unsigned int expressions.
27602 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27604 * codegen.cs: ditto.
27606 * expression.cs (LocalVariableReference): Drop the use of the
27607 Store function that depended on the variable index.
27609 * statement.cs (VariableInfo): Drop the `Idx' property from this
27610 class, as this is not taking into account the indexes for
27611 temporaries tat we generate during the execution, getting the
27614 * class.cs: First emit class initializers, then call the parent
27617 * expression.cs (Binary): Fix opcode emision.
27618 (UnaryMutator.EmitCode): Support checked code generation
27620 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27621 matches for events for both the Static and Instance scans,
27622 pointing to the same element. Fix that.
27624 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27626 * rootcontext.cs (ResolveTree): Always set the
27627 interface_resolve_order, because nested interfaces will be calling
27630 * class.cs (GetInterfaceOrClass): Track the same resolution
27631 process used by TypeManager.LookupType. This fixes the nested
27632 type lookups in class declarations (separate path from
27635 (TypeContainer.DefineType): Also define nested interfaces.
27636 (TypeContainer.RegisterOrder): New public function used to
27637 register the order in which child interfaces need to be closed.
27639 Nested interfaces need to be closed after their parents have been
27642 * interface.cs (InterfaceAttr): Put all the logic for computing
27643 the interface attribute here.
27645 (DefineInterface): Register our interface order with the
27646 RootContext or with the TypeContainer depending on the case.
27648 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27650 * cs-parser.jay: rework foreach statement to work with the new
27651 changes to the policy on SimpleNames.
27653 * report.cs: support Stacktrace on warnings as well.
27655 * makefile: drop --unsafe and /unsafe from the compile.
27657 2002-03-13 Ravi Pratap <ravi@ximian.com>
27659 * ecore.cs (StandardConversionExists): Modify to take an Expression
27660 as the first parameter. Ensure we do null -> reference type conversion
27663 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27664 temporary Expression objects.
27666 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27668 * interface.cs: workaround bug in method overloading resolution
27669 (there is already a bugzilla bug for it).
27671 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27673 We could also solve this problem by having a separate path for
27674 performing type lookups, instead of DoResolve, we could have a
27675 ResolveType entry point, and only participating pieces of the
27676 production (simplename, deref, array) would implement this.
27678 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27679 signal SimpleName to only resolve type names and not attempt to
27680 resolve anything else.
27682 * expression.cs (Cast): Set the flag.
27684 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27686 * class.cs: Only report 108 if there is no `new' modifier.
27688 * cs-parser.jay: rework foreach statement to work with the new
27689 changes to the policy on SimpleNames.
27691 * report.cs: support Stacktrace on warnings as well.
27693 * makefile: drop --unsafe and /unsafe from the compile.
27695 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27697 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27698 lookups here, instead of doing that at parse time. This means
27699 that our grammar will not introduce `LocalVariableReferences' as
27700 expressions at this point. That solves the problem of code like
27704 static void Main ()
27708 This is only half the fix. The full fix requires parameters to
27709 also be handled in this way.
27711 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27712 makes the use more obvious of the DeclSpace. The
27713 ec.TypeContainer.TypeBuilder is now only used to pull the
27714 TypeBuilder for it.
27716 My theory is that I can get rid of the TypeBuilder completely from
27717 the EmitContext, and have typecasts where it is used (from
27718 DeclSpace to where it matters).
27720 The only pending problem is that the code that implements Aliases
27721 is on TypeContainer, and probably should go in DeclSpace.
27723 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27724 lookups here, instead of doing that at parse time. This means
27725 that our grammar will not introduce `LocalVariableReferences' as
27726 expressions at this point. That solves the problem of code like
27730 static void Main ()
27734 This is only half the fix. The full fix requires parameters to
27735 also be handled in this way.
27737 * class.cs (Property.DefineMethod): When implementing an interface
27738 method, set newslot, when implementing an abstract method, do not
27739 set the flag (before we tried never setting it, or always setting
27740 it, which is the difference).
27741 (Indexer.DefineMethod): same.
27742 (Method.DefineMethod): same.
27744 * ecore.cs: Only set the status used flag if we get back a Field.
27746 * attribute.cs: Temporary hack, so Paolo can keep working.
27748 2002-03-08 Ravi Pratap <ravi@ximian.com>
27750 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
27751 the unmanaged type in the case we have a MarshalAs attribute.
27753 (Resolve): Handle the case when we are parsing the special MarshalAs
27754 attribute [we need to store the unmanaged type to use later]
27756 * typemanager.cs (marshal_as_attr_type): Built in type for the
27757 MarshalAs Attribute.
27759 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
27760 on parameters and accordingly set the marshalling info.
27762 2002-03-09 Miguel de Icaza <miguel@ximian.com>
27764 * class.cs: Optimizing slightly by removing redundant code after
27765 we switched to the `NoTypes' return value.
27766 (Property.DefineMethod): use NoTypes here too.
27768 This fixes the bug I introduced in my last batch of changes.
27770 2002-03-05 Ravi Pratap <ravi@ximian.com>
27772 * tree.cs (RecordEnum): Add. We now keep track of enums too.
27774 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
27775 Enums since those are types too.
27777 * cs-parser.jay (enum_declaration): Record enums as we parse them.
27779 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
27780 thanks to a call during the lookup process.
27782 2002-03-07 Miguel de Icaza <miguel@ximian.com>
27784 * statement.cs (Foreach): Lots of work to accomodate a particular
27785 kind of foreach statement that I had not kept in mind. It is
27786 possible to have foreachs on classes that provide a GetEnumerator
27787 method that return objects that implement the "pattern" for using
27788 a foreach, there is no need to support GetEnumerator
27791 This is needed to compile nant.
27793 * decl.cs: Only report 114 if the member is not `Finalize' and if
27794 the warning level is at least 2.
27796 * class.cs: Moved the compare function from Method to
27799 (MethodSignature.InheritableMemberSignatureCompare): Add new
27800 filter function that is used to extract inheritable methods from a
27803 (Method.Define): Use the new `inheritable_method_signature_filter'
27806 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
27809 2002-03-06 Miguel de Icaza <miguel@ximian.com>
27811 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
27813 * cs-parser.jay: Add opt_semicolon to the interface declaration.
27815 * expression.cs: Pass location information to
27816 ConvertImplicitStandard.
27818 * class.cs: Added debugging code to track return values from
27821 2002-03-05 Miguel de Icaza <miguel@ximian.com>
27823 * expression.cs (Is.DoResolve): If either side of the `is' is an
27824 interface, do not flag the warning.
27826 * ecore.cs (ImplicitReferenceConversion): We need a separate test
27829 * report.cs: Allow for --fatal to be used with --probe.
27831 * typemanager.cs (NoTypes): Move the definition for the empty Type
27834 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
27836 (TypeContainer.DefineProxy): New function used to proxy to parent
27837 implementations when implementing interfaces.
27838 (TypeContainer.ParentImplements): used to lookup if our parent
27839 implements a public function that is required by an interface.
27840 (TypeContainer.VerifyPendingMethods): Hook this up.
27842 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
27843 `modules' and `assemblies' arraylists into arrays. We only grow
27844 these are the very early start up of the program, so this improves
27845 the speedof LookupType (nicely measured).
27847 * expression.cs (MakeByteBlob): Replaced unsafe code with
27848 BitConverter, as suggested by Paolo.
27850 * cfold.cs (ConstantFold.Binary): Special case: perform constant
27851 folding of string concatenation, but if either side is a string,
27852 and the other is not, then return null, and let the runtime use
27853 the concatenation on the string plus the object (using
27854 `Object.ToString').
27856 2002-03-04 Miguel de Icaza <miguel@ximian.com>
27858 Constant Folding has been implemented now.
27860 * expression.cs (Unary.Reduce): Do not throw an exception, catch
27861 the error instead on types that are not supported in one's
27864 * constant.cs (Constant and all children): New set of functions to
27865 perform implict and explicit conversions.
27867 * ecore.cs (EnumConstant): Implement the new functions to perform
27868 conversion by proxying to the child expression.
27870 * codegen.cs: (ConstantCheckState): Constant evaluation has its
27871 own separate setting that can not be turned off from the command
27872 line using --unchecked or --checked and is only controlled using
27873 the checked/unchecked statements and expressions. This setting is
27874 used by the constant folder to flag errors.
27876 * expression.cs (CheckedExpr, UncheckedExpr): Set the
27877 ConstantCheckState as well.
27879 During Resolve, they also have to flag the state, because the
27880 constant folder runs completely in the Resolve phase.
27882 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
27885 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27887 * cfold.cs: New file, this file contains the constant folder.
27889 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
27890 argument to track whether we are using the resulting address to
27891 load or store a value and provide better error messages.
27893 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
27894 new AddressOf arguments.
27896 * statement.cs (Foreach.EmitCollectionForeach): Update
27898 * expression.cs (Argument.Emit): Call AddressOf with proper
27899 arguments to track usage.
27901 (New.DoEmit): Call AddressOf with new arguments.
27903 (Unary.Emit): Adjust AddressOf call.
27905 2002-03-01 Ravi Pratap <ravi@ximian.com>
27907 * cs-parser.jay (member_access): Change the case for pre-defined types
27908 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
27911 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
27914 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
27915 essentially like methods and apply attributes like MethodImplOptions to them too.
27917 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
27920 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
27921 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
27924 * Update code everywhere accordingly.
27926 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
27928 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
27930 2002-02-28 Ravi Pratap <ravi@ximian.com>
27932 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
27933 try performing lookups against those instead of jumping straight into using
27934 the 'using' clauses.
27936 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
27938 (LookupType): Perform lookups in implicit parents too.
27940 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
27941 sequence as RootContext.LookupType.
27943 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
27944 the various cases of namespace lookups into this method.
27946 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27948 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
27949 in positional arguments)
27951 * class.cs (Operator): Update the AllowedModifiers to contain
27954 * cs-parser.jay: Update operator declaration to allow for the
27955 operator body to be empty.
27957 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
27960 2002-02-27 Miguel de Icaza <miguel@ximian.com>
27962 * class.cs (Method.Emit): Label parameters.
27964 * driver.cs: Return 1 or 0 as the program exit code.
27966 2002-02-26 Miguel de Icaza <miguel@ximian.com>
27968 * expression.cs: Special case the `null' object when trying to
27969 auto-compute the type, as anything can be explicitly converted to
27972 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
27973 spotting this Paolo.
27975 (Expression.ImplicitNumericConversion): Perform comparissions of
27976 the type using the underlying type in the case of an enumeration
27977 rather than using the enumeration type for the compare.
27979 Cope with the underlying == type case, which is not possible to
27982 (Expression.ConvertNumericExplicit): Perform comparissions of
27983 the type using the underlying type in the case of an enumeration
27984 rather than using the enumeration type for the compare.
27986 * driver.cs: If the user does not supply an extension, assume .exe
27988 * cs-parser.jay (if_statement): Rewrote so that we can track the
27989 location for the if statement.
27991 * expression.cs (Binary.ConstantFold): Only concat strings when
27992 the operation is "+", not everything ;-)
27994 * statement.cs (Statement.EmitBoolExpression): Take a location
27996 (If, While, Do): Track location.
27998 * expression.cs (Binary.ResolveOperator): In the object + string
27999 case, I was missing a call to ConvertImplicit
28001 2002-02-25 Ravi Pratap <ravi@ximian.com>
28003 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28004 Location arguments. Ensure we use RootContext.LookupType to do our work
28005 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28007 * interface.cs (PopulateMethod): Handle the type of the parameter being
28010 * expression.cs (Invocation.BetterFunction): Handle the case when we
28011 have a params method with no fixed arguments and a call is made with no
28014 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28016 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28017 the verbatim-string-literal
28019 * support.cs (InternalParameters.ParameterModifier): handle null
28021 (InternalParameters.ParameterType): ditto.
28023 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28024 duplicating the name of the variable parameter.
28025 (GetParameterByName): Fix bug where we were not looking up array
28026 paramters if they were the only present (thanks Paolo!).
28027 (GetParameterInfo): We only have an empty set of types if both
28028 fixed and array are set to null.
28029 (GetParameterInfo-idx): Handle FixedParameter == null
28031 * cs-parser.jay: Handle the case where there is no catch
28032 statements (missing null test).
28034 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28036 * driver.cs (MainDriver): Be conservative on our command line
28039 Catch DirectoryNotFoundException when calling GetFiles.
28041 (SplitPathAndPattern): Used to split the input specification into
28042 a path and a pattern that we can feed to Directory.GetFiles.
28044 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28046 * statement.cs (Fixed): Implement the last case of the Fixed
28047 statement (string handling).
28049 * expression.cs (StringPtr): New class used to return a char * to
28050 a string; Used by the Fixed statement.
28052 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28054 * expression.cs (Binary.ResolveOperator): Remove redundant
28055 MemberLookup pn parent type.
28056 Optimize union call, we do not need a union if the types are the same.
28057 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28060 Specialize the use of MemberLookup everywhere, instead of using
28061 the default settings.
28063 (StackAlloc): Implement stackalloc keyword.
28065 * cs-parser.jay: Add rule to parse stackalloc.
28067 * driver.cs: Handle /h, /help, /?
28069 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28070 before we supported unsafe code.
28072 * makefile: add --unsafe to the self compilation of mcs.
28074 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28076 * expression.cs (PointerArithmetic): New class that is used to
28077 perform pointer arithmetic.
28078 (Binary.Resolve): Handle pointer arithmetic
28079 Handle pointer comparission.
28080 (ArrayPtr): Utility expression class that is used to take the
28081 address of an array.
28083 (ElementAccess): Implement array access for pointers
28085 * statement.cs (Fixed): Implement fixed statement for arrays, we
28086 are missing one more case before we are done.
28088 * expression.cs (Indirection): Implement EmitAssign and set the
28089 ExprClass to Variable. This allows pointer dereferences to be
28090 treated as variables, and to have values assigned to them.
28092 * ecore.cs (Expression.StoreFromPtr): New utility function to
28093 store values dereferencing.
28095 2002-02-20 Ravi Pratap <ravi@ximian.com>
28097 * expression.cs (Binary.ResolveOperator): Ensure that we are
28098 not trying to operate on a void type - this fixes the reported
28101 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28102 the parent implementation is sealed.
28104 * ../errors/cs0239.cs : Add.
28106 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28108 * typemanager.cs (unverifiable_code_type): Corresponds to
28109 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28110 which have unsafe code in them.
28112 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28115 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28117 * cs-tokenizer.cs: Add support for @"litreal strings"
28119 Make tokenizer accept pre-processor directives
28120 on any column (remove the old C-like limitation).
28122 * rootcontext.cs (EmitCode): Emit any global attributes.
28123 (AddGlobalAttributes): Used to keep track of assembly attributes.
28125 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28127 * cs-parser.jay: Add support for global attributes.
28129 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28131 * expression.cs (Indirection): New helper class. Unary will
28132 create Indirection classes to be able to implement the
28133 IMemoryLocation interface on it.
28135 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28137 * cs-parser.jay (fixed_statement): reference the right statement.
28139 * statement.cs (Fixed.Emit): Finish implementing the fixed
28140 statement for the &x case.
28142 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28144 * class.cs (Property.Define, Method.Define): Remove newslot when
28147 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28148 wrong. NewSlot should only be used if the `new' keyword is present.
28150 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28151 locating our system dir. Sorry about this.
28153 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28155 * driver.cs (GetSystemDir): Compute correctly the location of our
28156 system assemblies. I was using the compiler directory instead of
28157 the library directory.
28159 2002-02-13 Ravi Pratap <ravi@ximian.com>
28161 * expression.cs (BetterFunction): Put back in what Miguel commented out
28162 since it is the correct fix. The problem is elsewhere ;-)
28164 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28165 parameters of the parms method are themselves compatible or not !
28167 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28168 to check that a class implements an interface before saying that an implicit
28169 conversion was allowed. Use ImplementsInterface to do the checking.
28171 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28173 * class.cs (Method.Define): Track whether we are an explicit
28174 implementation or not. And only call DefineMethodOverride if we
28175 are an explicit implementation.
28177 (Property.DefineMethod): Ditto.
28179 2002-02-11 Ravi Pratap <ravi@ximian.com>
28181 * expression.cs (BetterFunction): Catch hideous bug which was
28182 preventing us from detecting ambiguous calls due to implicit casts i.e
28185 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28187 * support.cs (Pair): Remove un-needed method. I figured why I was
28188 getting the error in cs-parser.jay, the variable in a foreach loop
28189 is readonly, and the compiler does not really treat this as a variable.
28191 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28192 instead of EQUALS in grammar.
28194 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28196 * expression.cs (Unary.DoResolve): Check whether the argument is
28199 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28201 * support.cs: Api for Pair to set a value. Despite the fact that
28202 the variables are public the MS C# compiler refuses to compile
28203 code that accesses the field if the variable is part of a foreach
28206 * statement.cs (Fixed): Begin implementation of the fixed
28209 (Block.AddVariable): Return the VariableInfo on success and null
28210 on failure instead of true/false.
28212 * cs-parser.jay (foreach): Catch errors on variables already
28213 defined (we were ignoring this value before) and properly unwind
28214 the block hierarchy
28216 (fixed_statement): grammar for the fixed statement.
28218 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28220 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28221 pointer types to be incretemented.
28223 (SizeOf): Implement.
28225 * cs-parser.jay (pointer_member_access): Implement
28226 expr->IDENTIFIER production.
28228 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28229 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28232 (Unary): Implement indirection.
28234 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28235 use in non-unsafe context).
28237 (SimpleName.DoResolve): Check for pointers in field access on safe
28240 (Expression.LoadFromPtr): Factor the load-indirect code in this
28241 function. This was duplicated in UnboxCast and ParameterReference
28243 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28245 * expression.cs (ComposedCast): report an error if a pointer cast
28246 is used in a safe region.
28248 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28249 pointer type casts in unsafe context.
28251 * codegen.cs (EmitContext): Set up IsUnsafe.
28253 * cs-parser.jay (non_expression_type): Add productions for pointer
28256 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28257 code. We should not use force into static mode if the method is
28258 not virtual. Fixes bug in MIS
28260 * statement.cs (Do.Emit, While.Emit, For.Emit,
28261 Statement.EmitBoolExpression): Add support to Do and While to
28262 propagate infinite loop as `I do return' semantics.
28264 Improve the For case to also test for boolean constants.
28266 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28267 to the list of attributes we can add.
28269 Remove `EmitContext' argument.
28271 * class.cs (Method.Define): Apply parameter attributes.
28272 (Constructor.Define): Apply parameter attributes.
28273 (MethodCore.LabelParameters): Move here the core of labeling
28276 * support.cs (ReflectionParameters.ParameterModifier,
28277 InternalParameters.ParameterModifier): Use IsByRef on the type and
28278 only return the OUT bit for these parameters instead of in/out/ref
28281 This is because I miss-understood things. The ParameterInfo.IsIn
28282 and IsOut represent whether the parameter has the [In] and [Out]
28285 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28287 * ecore.cs (FieldExpr.Emit): Release temporaries.
28289 * assign.cs (LocalTemporary.Release): new function.
28291 * codegen.cs (EmitContext.GetTemporaryStorage,
28292 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28293 temporary storage. Now we can "put back" localbuilders when we
28296 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28298 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28299 need to make a copy of the variable to generate verifiable code.
28301 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28303 * driver.cs: Compute dynamically the system directory.
28305 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28306 Slower, but more generally useful. Used by the abstract
28307 registering implementation.
28309 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28310 the rules for the special rule on Type/instances. First check if
28311 we have the same name, and if so, try that special static path
28312 rather than the instance path.
28314 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28316 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28319 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28320 Enum, ValueType, Delegate or Array for non-corlib compiles.
28322 * cs-tokenizer.cs: Catch long identifiers (645)
28324 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28327 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28328 fix, we were returning too early, so we were not registering
28329 pending methods from abstract classes.
28331 Do not register pending methods if the class is abstract.
28333 * expression.cs (Conditional.DoResolve): Report circular implicit
28334 conversions when we neecd to compute it for conditional
28337 (Is.DoResolve): If the expression is always of the provided type,
28338 flag warning 183. If the expression can not ever be of the
28339 provided type flag warning 184.
28341 * class.cs: Catch 169 as well.
28343 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28346 2002-01-18 Nick Drochak <ndrochak@gol.com>
28348 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28350 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28352 * interface.cs: (PopulateMethod): Check for pointers being defined
28353 only if the unsafe context is active.
28354 (PopulateProperty): ditto.
28355 (PopulateIndexer): ditto.
28357 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28358 specified. If pointers are present, make sure that they are
28359 present in an unsafe context.
28360 (Constructor, Constructor.Define): ditto.
28361 (Field, Field.Define): ditto.
28362 (Property, Property.Define): ditto.
28363 (Event, Event.Define): ditto.
28365 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28366 hashtable if there are classes or structs defined.
28368 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28369 code, as the constant resolution moved.
28371 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28372 the metadata, so we can flag error 133.
28374 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28375 pointer is being declared in an unsafe context.
28377 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28379 * modifiers.cs (Modifiers.Check): Require a Location argument.
28380 Report error 227 for Unsafe use.
28382 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28384 * statement.cs (For.Emit): If the test is null, then report that
28385 we do `return', as we wont reach anything afterwards.
28387 (Switch.SwitchGoverningType): Track the expression that matched
28390 * driver.cs: Allow negative numbers as an error code to flag.
28392 * cs-parser.jay: Handle 1551.
28394 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28396 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28398 * cs-parser.jay: Report 1518 (type declaration can only contain
28399 class, struct, interface, enum or delegate)
28401 (switch_label): Report 1523 (keywords `case' or `default' must
28404 (opt_switch_sections): Report 1522 (empty switch)
28406 * driver.cs: Report 1515 (response file specified multiple times)
28407 Report 1516 (Source file specified multiple times).
28409 * expression.cs (Argument.Resolve): Signal 1510
28411 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28412 access not allowed in static code)
28414 2002-01-11 Ravi Pratap <ravi@ximian.com>
28416 * typemanager.cs (IsPointerType): Utility method which we are going
28419 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28420 the object type, so we take care of that.
28422 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28424 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28425 added to non-params parameters :-)
28427 * typemanager.cs (CSharpName): Include 'void' type too.
28429 (void_ptr_type): Include in the set of core types.
28431 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28434 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28437 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28438 completely forgotten about it.
28440 2002-01-10 Ravi Pratap <ravi@ximian.com>
28442 * cs-parser.jay (pointer_type): Add. This begins our implementation
28443 of parsing rules for unsafe code.
28445 (unsafe_statement): Implement.
28447 (embedded_statement): Modify to include the above.
28449 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28451 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28452 if the current context is an unsafe one.
28454 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28455 are handled differently, we need separate rules for them.
28457 (local_variable_declaration): Update to use local_variable_pointer_type
28458 to allow variable declarations of unmanaged pointer types.
28460 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28461 in unsafe contexts.
28463 * ../errors/cs0214.cs : Add.
28465 2002-01-16 Nick Drochak <ndrochak@gol.com>
28467 * makefile: remove 'response' file when cleaning.
28469 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28471 * cs-parser.jay: Report 1524.
28473 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28475 * typemanager.cs (RegisterMethod): drop checking if we have
28476 registered this from here
28478 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28480 * class.cs (Method.EmitDestructor): Implement calling our base
28483 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28484 value of InFinally.
28486 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28487 this routine and will wrap the call in a try/catch block. Deal
28490 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28492 * ecore.cs (Expression.MemberLookup): instead of taking a
28493 parameter `same_type' that was used to tell whether we could
28494 access private members we compute our containing type from the
28497 (FieldExpr): Added partial support for volatile fields. This does
28498 not work for volatile fields exposed from assemblies, as I can not
28499 figure out how to extract the modreq from it.
28501 Updated all the source files to use this.
28503 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28504 because it is referenced by MemberLookup very often.
28506 2002-01-09 Ravi Pratap <ravi@ximian.com>
28508 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28509 TypeBuilder.GetCustomAttributes to retrieve what we need.
28511 Get rid of redundant default_member_attr_type as this is the same as
28512 default_member_type which already exists.
28514 * interface.cs, attribute.cs : Update accordingly.
28516 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28518 * typemanager.cs: Enable IndexerPropertyName again. It does not
28519 work for TYpeBuilders though. Ravi, can you please fix this?
28521 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28523 * expression.cs (Argument.Emit): Handle the case of ref objects
28524 being passed to ref functions;
28526 (ParameterReference.EmitLoad): Loads the content of the pointer
28527 without dereferencing.
28529 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28531 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28533 2002-01-08 Ravi Pratap <ravi@ximian.com>
28535 * class.cs (Indexer.DefineMethod): Incorporate the interface
28536 type in the name of the method if we are doing explicit interface
28539 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28541 (BetterConversion): Fix extremely trivial bug where we were referring to
28542 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28545 * ../errors/bug16.cs : Add although we have fixed it.
28547 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28549 * expression.cs (BaseIndexer): Begin implementation.
28551 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28553 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28554 production directly to remove a shift/reduce, and implement
28555 explicit interface implementation.
28557 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28558 after a floating point suffix.
28560 * expression.cs (DoNumericPromotions): Improved the conversion for
28561 uint/uint. If we have a constant, we avoid doing a typecast to a
28564 * class.cs (Indexer): Implement explicit interface implementation
28567 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28569 * class.cs: make the default instance constructor public and hidebysig.
28571 2001-01-03 Ravi Pratap <ravi@ximian.com>
28573 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28574 so we can call it from elsewhere.
28576 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28577 we emit it internally if the class has a defined indexer; otherwise the user
28578 emits it by decorating the class definition with the DefaultMemberAttribute.
28580 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28581 attribute is not used on a type which defines an indexer.
28583 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28584 character when we skip whitespace.
28586 * ../errors/cs0646.cs : Add.
28588 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28590 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28593 * makefile: Add practical target `mcs3.exe' which builds the third
28594 generation compiler.
28596 * expression.cs (New): Fix structures constructor calling.
28598 * class.cs (Property, Method, Indexer): Emit Final flag on the
28599 method if we are an interface implementation and we are not
28602 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28603 whether this property is referencing a `base' method.
28605 * expression.cs (Invocation.EmitCall): take an extra argument:
28606 is_base, this is used to determine whether the `call' or
28607 `callvirt' opcode should be used.
28610 * delegate.cs: update EmitCall.
28612 * class.cs (Method.Define): Set NewSlot for the cases where we are
28613 not implementing an interface method.
28615 (Property.Define): ditto.
28617 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28619 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28620 'r'. Allows mcs to parse itself fully.
28622 2002-01-02 Ravi Pratap <ravi@ximian.com>
28624 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28625 of the number of initializers that require the InitializeArray method.
28627 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28628 update the above field where necessary.
28630 (MakeByteBlob): Update accordingly.
28632 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28635 (EmitDynamicInitializers): Update in accordance with the new optimization.
28637 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28638 same OpCode applies.
28640 * cs-parser.jay : Fix some glaring errors I introduced.
28642 2002-01-01 Ravi Pratap <ravi@ximian.com>
28644 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28645 so that we can check for name clashes there too.
28647 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28648 for interface indexers.
28650 * interfaces.cs (Define): Emit the default member attribute.
28652 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28653 variable was being referred to while setting the value ;-)
28655 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28657 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28658 byte-by-byte information when we know the data is zero.
28660 Make the block always a multiple of 4, because
28661 DefineInitializedData has a bug.
28663 * assign.cs: Fix, we should assign from the temporary, not from
28666 * expression.cs (MakeByteBlob): Fix my incorrect code.
28668 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28670 * typemanager.cs (EnumToUnderlying): This function is used to get
28671 the underlying type from an enumeration, because it does not
28674 * constant.cs: Use the I4_S form for values between -128 and 127.
28676 * statement.cs (Block.LookupLabel): Looks up a label.
28677 (Block): Drop support for labeled blocks.
28679 (LabeledStatement): New kind of statement that represents a label
28682 (Goto): Finally implement this bad boy.
28684 * cs-parser.jay: Update to reflect new mechanism to implement
28687 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28689 * codegen.cs (EmitContext.This): a codegen property that keeps the
28690 a single instance of this instead of creating many different this
28693 * delegate.cs (Delegate.DoResolve): Update to use the property;
28695 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28697 * expression.cs (BaseAccess.DoResolve): Ditto.
28699 2001-12-29 Ravi Pratap <ravi@ximian.com>
28701 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28702 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28704 (InitCoreTypes): Update accordingly.
28706 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28707 so we can quickly store the state.
28709 (ApplyAttributes): Set the correct implementation flags
28710 for InternalCall methods.
28712 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28714 * expression.cs (EmitCall): if a method is not virtual, then do
28715 not use callvirt on it.
28717 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28718 user defined stuff) requires the use of stobj, which takes an
28719 address on the stack instead of an array and an index. So emit
28720 the Ldelema operation for it.
28722 (EmitStoreOpcode): Use stobj for valuetypes.
28724 (UnaryMutator.EmitCode): Use the right 1 value depending on
28725 whether we are dealing with int64/uint64, float or doubles.
28727 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
28728 constructors that I implemented last night.
28730 (Constructor.IsDefault): Fix to work properly for static
28733 * cs-parser.jay (CheckDef): report method signature errors.
28734 Update error number 103 to be 132.
28736 * decl.cs: New AdditionResult enumeration value: MethodExists.
28737 Although we do this check for methods later on in the semantic
28738 analysis, catching repeated default constructors is so easy that
28739 we catch these here.
28741 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
28744 (ParameterReference.EmitAssign, Emit): handle
28747 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
28748 (ArrayAccess.EmitStoreOpcode): ditto.
28750 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
28752 * expression.cs (MakeByteBlob): Complete all the missing types
28753 (uint, short, ushort, byte, sbyte)
28755 * class.cs: Only init instance field initializers on instance
28758 Rename `constructors' to instance_constructors.
28760 (TypeContainer.AddConstructor): Only add constructors to the list
28761 if it is not static.
28763 Make sure that we handle default_static_constructor independently
28764 everywhere where we handle instance_constructors
28766 2001-12-28 Miguel de Icaza <miguel@ximian.com>
28768 * class.cs: Do not lookup or create a base initializer for a
28769 static constructor.
28771 (ConstructorInitializer.Resolve): use the proper type to lookup
28774 * cs-parser.jay: Report error 1585 (modifiers between type and name).
28776 * enum.cs, interface.cs: Remove CloseType, this is taken care by
28779 * decl.cs: CloseType is now an virtual method, the default
28780 implementation just closes this type.
28782 2001-12-28 Ravi Pratap <ravi@ximian.com>
28784 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
28785 to PreserveSig by default. Also emit HideBySig on such methods.
28787 Basically, set the defaults to standard values.
28789 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
28790 argument, if candidate is better, it can't be worse than the best !
28792 (Invocation): Re-write bits to differentiate between methods being
28793 applicable in their expanded form and their normal form - for params
28796 Get rid of use_standard everywhere as only standard conversions are allowed
28797 in overload resolution.
28799 More spec conformance.
28801 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28803 * driver.cs: Add --timestamp, to see where the compiler spends
28806 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
28807 `this' in static code.
28809 (SimpleName.DoResolve): Implement in terms of a helper function
28810 that allows static-references to be passed upstream to
28813 (Expression.ResolveWithSimpleName): Resolve specially simple
28814 names when called by MemberAccess to implement the special
28817 (Expression.ImplicitReferenceConversion): Handle conversions from
28818 Null to reference types before others, as Null's type is
28821 * expression.cs (Invocation.EmitCall): Handle the special case of
28822 calling methods declared on a reference type from a ValueType
28823 (Base classes System.Object and System.Enum)
28825 (MemberAccess.Resolve): Only perform lookups on Enumerations if
28826 the left hand side is a TypeExpr, not on every enumeration.
28828 (Binary.Resolve): If types are reference types, then do a cast to
28829 object on operators != and == of both arguments.
28831 * typemanager.cs (FindMembers): Extract instance and static
28832 members if requested.
28834 * interface.cs (PopulateProperty): Use void_type instead of null
28835 as the return type for the setter method.
28837 (PopulateIndexer): ditto.
28839 2001-12-27 Ravi Pratap <ravi@ximian.com>
28841 * support.cs (ReflectionParameters): Fix minor bug where we
28842 were examining the wrong parameter for the ParamArray attribute.
28844 Cope with requests for the type of the parameter at position
28845 greater than the params parameter's. We now return the element
28846 type of the params array as that makes more sense.
28848 * expression.cs (Invocation.IsParamsMethodApplicable): Update
28849 accordingly as we no longer have to extract the element type
28852 (Invocation.OverloadResolve): Update.
28854 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28856 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
28857 against IEnumerator, test whether the return value is a descendant
28858 of the IEnumerator interface.
28860 * class.cs (Indexer.Define): Use an auxiliary method to implement
28861 the other bits of the method definition. Begin support for
28862 explicit interface implementation.
28864 (Property.DefineMethod): Use TypeManager.void_type instead of null
28865 for an empty return value.
28867 2001-12-26 Miguel de Icaza <miguel@ximian.com>
28869 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
28870 dealing with a FieldExpr which is composed of a FieldBuilder, in
28871 the code path we did extract the constant, but we should have
28872 obtained the underlying value to be able to cast it (otherwise we
28873 end up in an infinite loop, this is what Ravi was running into).
28875 (ArrayCreation.UpdateIndices): Arrays might be empty.
28877 (MemberAccess.ResolveMemberAccess): Add support for section
28878 14.5.4.1 that deals with the special case of E.I when E is a type
28879 and something else, that I can be a reference to a static member.
28881 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
28882 handle a particular array type to create byte blobs, it is just
28883 something we dont generate byteblobs for.
28885 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
28888 * location.cs (Push): remove the key from the hashtable that we
28889 are about to add. This happens for empty files.
28891 * driver.cs: Dispose files after we have parsed them.
28893 (tokenize): new function that only runs the tokenizer on its
28894 input, for speed testing.
28896 2001-12-26 Ravi Pratap <ravi@ximian.com>
28898 * class.cs (Event.Define): Define the private field only if there
28899 are no accessors defined.
28901 * expression.cs (ResolveMemberAccess): If there is no associated
28902 field with the event, that means we have an event defined with its
28903 own accessors and we should flag error cs0070 since transforming
28904 ourselves into a field is not valid in that case.
28906 * ecore.cs (SimpleName.DoResolve): Same as above.
28908 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
28909 and charset to sane values.
28911 2001-12-25 Ravi Pratap <ravi@ximian.com>
28913 * assign.cs (DoResolve): Perform check on events only if they
28914 are being accessed outside the declaring type.
28916 * cs-parser.jay (event_declarations): Update rules to correctly
28917 set the type of the implicit parameter etc.
28919 (add_accessor, remove_accessor): Set current local parameters.
28921 * expression.cs (Binary): For delegate addition and subtraction,
28922 cast the return value from the method into the appropriate delegate
28925 2001-12-24 Ravi Pratap <ravi@ximian.com>
28927 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
28928 of these as the workaround is unnecessary.
28930 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
28931 delegate data - none of that is needed at all.
28933 Re-write bits to extract the instance expression and the delegate method
28936 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
28939 * attribute.cs (ApplyAttributes): New method to take care of common tasks
28940 of attaching attributes instead of duplicating code everywhere.
28942 * everywhere : Update code to do attribute emission using the above method.
28944 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28946 * expression.cs (IsParamsMethodApplicable): if there are not
28947 parameters, return immediately.
28949 * ecore.cs: The 0 literal can be implicity converted to an enum
28952 (SimpleName.DoResolve): First lookup the type, then lookup the
28955 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
28956 want to get its address. If the InstanceExpression is not
28957 addressable, store the result in a temporary variable, then get
28960 * codegen.cs: Only display 219 errors on warning level or above.
28962 * expression.cs (ArrayAccess): Make it implement the
28963 IMemoryLocation interface.
28965 (Binary.DoResolve): handle the operator == (object a, object b)
28966 and operator != (object a, object b) without incurring into a
28967 BoxedCast (because 5 != o should never be performed).
28969 Handle binary enumerator operators.
28971 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
28972 value type, otherwise use Ldelem_ref.
28974 Use precomputed names;
28976 (AddressOf): Implement address of
28978 * cs-parser.jay (labeled_statement): Fix recursive block
28979 addition by reworking the production.
28981 * expression.cs (New.DoEmit): New has a special case:
28983 If we are dealing with a ValueType, we have a few
28984 situations to deal with:
28986 * The target of New is a ValueType variable, that is
28987 easy, we just pass this as the variable reference
28989 * The target of New is being passed as an argument,
28990 to a boxing operation or a function that takes a
28993 In this case, we need to create a temporary variable
28994 that is the argument of New.
28997 2001-12-23 Ravi Pratap <ravi@ximian.com>
28999 * rootcontext.cs (LookupType): Check that current_type is not null before
29000 going about looking at nested types.
29002 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29003 not implement the IAssignMethod interface any more.
29005 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29006 where we tranform them into FieldExprs if they are being resolved from within
29007 the declaring type.
29009 * ecore.cs (SimpleName.DoResolve): Do the same here.
29011 * assign.cs (DoResolve, Emit): Clean up code considerably.
29013 * ../errors/bug10.cs : Add.
29015 * ../errors/cs0070.cs : Add.
29017 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29019 * assign.cs : Get rid of EventIsLocal everywhere.
29021 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29023 * ecore.cs (ConvertIntLiteral): finished the implementation.
29025 * statement.cs (SwitchLabel): Convert the value we are using as a
29026 key before looking up the table.
29028 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29030 * codegen.cs (EmitTopBlock): Require a Location argument now.
29032 * cs-parser.jay (constructor_declarator): We need to setup
29033 current_local_parameters before we parse the
29034 opt_constructor_initializer, to allow the variables to be bound
29035 to the constructor arguments.
29037 * rootcontext.cs (LookupType): First lookup nested classes in our
29038 class and our parents before we go looking outside our class.
29040 * expression.cs (ConstantFold): Extract/debox the values at the
29043 * rootcontext.cs (EmitCode): Resolve the constants first before we
29044 resolve the types. This is not really needed, but it helps debugging.
29046 * statement.cs: report location.
29048 * cs-parser.jay: pass location to throw statement.
29050 * driver.cs: Small bug fix.
29052 * report.cs: Updated format to be 4-zero filled digits.
29054 2001-12-22 Ravi Pratap <ravi@ximian.com>
29056 * expression.cs (CheckIndices): Fix minor bug where the wrong
29057 variable was being referred to ;-)
29059 (DoEmit): Do not call EmitStaticInitializers when the
29060 underlying type is System.Object.
29062 2001-12-21 Ravi Pratap <ravi@ximian.com>
29064 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29065 and do the usual workaround for SRE.
29067 * class.cs (MyEventBuilder.EventType): New member to get at the type
29068 of the event, quickly.
29070 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29072 * assign.cs (Assign.DoResolve): Handle the case when the target
29073 is an EventExpr and perform the necessary checks.
29075 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29078 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29080 (EventExpr): Set the type in the constructor itself since we
29081 are meant to be born fully resolved.
29083 (EventExpr.Define): Revert code I wrote earlier.
29085 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29086 instance expression is null. The instance expression is a This in that case
29087 or a null, depending on whether it is a static method or not.
29089 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29090 refers to more than one method.
29092 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29093 and accordingly flag errors.
29095 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29097 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29099 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29101 * location.cs (ToString): Provide useful rutine.
29103 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29105 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29106 objects, return the actual integral boxed.
29108 * statement.cs (SwitchLabel): define an ILLabel for each
29111 (Switch.CheckSwitch): If the value is a Literal, extract
29112 the underlying literal.
29114 Also in the unused hashtable we had, add the SwitchLabel so we can
29115 quickly look this value up.
29117 * constant.cs: Implement a bunch of new constants. Rewrite
29118 Literal based on this. Made changes everywhere to adapt to this.
29120 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29121 dereferencing array only once, and also copes with enumrations.
29123 bytes are two bytes wide, not one.
29125 (Cast): Perform constant conversions.
29127 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29128 wrappers to the literals here.
29130 * expression.cs (DoNumericPromotions): long literals can converted
29131 to ulong implicity (this is taken care of elsewhere, but I was
29132 missing this spot).
29134 * ecore.cs (Expression.Literalize): Make the return type Literal,
29135 to improve type checking.
29137 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29139 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29141 * literal.cs: Revert code from ravi that checked the bounds. The
29142 bounds are sane by the definition of the type itself.
29144 * typemanager.cs: Fix implementation of ImplementsInterface. We
29145 need to actually look up in our parent hierarchy for interfaces
29148 * const.cs: Use the underlying type for enumerations
29150 * delegate.cs: Compute the basename for the delegate creation,
29151 that should fix the delegate test case, and restore the correct
29152 Type Lookup semantics in rootcontext
29154 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29155 referencing a nested type with the Reflection API is using the "+"
29158 * cs-parser.jay: Do not require EOF token at the end.
29160 2001-12-20 Ravi Pratap <ravi@ximian.com>
29162 * rootcontext.cs (LookupType): Concatenate type names with
29163 a '.' instead of a '+' The test suite passes again.
29165 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29166 field of the enumeration.
29168 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29169 the case when the member is an EventExpr.
29171 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29172 static has an associated instance expression.
29174 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29176 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29178 * class.cs (Event.Define): Register event and perform appropriate checks
29181 We define the Add and Remove methods even if the use provides none because
29182 in that case, we provide default implementations ourselves.
29184 Define a private field of the type of the event. This is done by the CSC compiler
29185 and we should be doing it too ;-)
29187 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29188 More methods we use in code we generate.
29190 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29193 (InitCoreTypes): Update accordingly for the above.
29195 * class.cs (Event.Emit): Generate code for default accessors that we provide
29197 (EmitDefaultMethod): Do the job in the above.
29199 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29202 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29204 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29205 builders even if we were missing one.
29207 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29208 pass the Basename as our class name instead of the Name. The
29209 basename will be correctly composed for us.
29211 * parameter.cs (Paramters): Now takes a Location argument.
29213 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29214 make all the code call directly LookupType in RootContext and take
29215 this chance to pass the Location information everywhere.
29217 * Everywhere: pass Location information.
29219 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29221 * class.cs (Constructor.Define): Updated way of detecting the
29222 length of the parameters.
29224 (TypeContainer.DefineType): Use basename as the type name for
29227 (TypeContainer.Define): Do not recursively define types here, as
29228 definition is taken care in order by the RootContext.
29230 * tree.cs: Keep track of namespaces in a per-file basis.
29232 * parameter.cs (Parameter.ComputeSignature): Update to use
29235 (Parameters.GetSignature): ditto.
29237 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29238 instead of a TypeContainer.
29240 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29241 resolve names. Because we need to be resolve in our context, not
29244 * driver.cs: Implement response files.
29246 * class.cs (TypeContainer.DefineType): If we are defined, do not
29247 redefine ourselves.
29249 (Event.Emit): Emit the code for add/remove handlers.
29250 (Event.Define): Save the MethodBuilders for add/remove.
29252 * typemanager.cs: Use pair here too.
29254 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29255 DictionaryEntry requires the first argument to be non-null.
29257 (enum_declaration): Compute full name for registering the
29260 (delegate_declaration): Instead of using
29261 formal_parameter_list, use opt_formal_parameter_list as the list
29264 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29265 (EventParsing): New property that controls whether `add' and
29266 `remove' are returned as tokens or identifiers (for events);
29268 2001-12-19 Ravi Pratap <ravi@ximian.com>
29270 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29271 use MyEventBuilder only and let it wrap the real builder for us.
29273 (MyEventBuilder): Revamp constructor etc.
29275 Implement all operations that we perform on EventBuilder in precisely the same
29278 (FindMembers): Update to use the EventBuilder member.
29280 (Event.Emit): Update accordingly.
29282 2001-12-18 Ravi Pratap <ravi@ximian.com>
29284 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29285 by calling the appropriate methods.
29287 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29290 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29292 2001-12-17 Ravi Pratap <ravi@ximian.com>
29294 * delegate.cs (Delegate.Populate): Check that the return type
29295 and various parameters types are indeed accessible.
29297 * class.cs (Constructor.Define): Same here.
29299 (Field.Define): Ditto.
29301 (Event.Define): Ditto.
29303 (Operator.Define): Check that the underlying Method defined itself
29304 correctly - so it's MethodBuilder should not be null.
29306 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29307 expression happens to be null.
29309 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29310 members but as of now we don't seem to be able to do anything really useful with it.
29312 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29313 not the EventBuilder.
29315 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29317 * cs-tokenizer.cs: Add support for defines.
29318 Add support for #if, #elif, #else, #endif
29320 (eval_var): evaluates a variable.
29321 (eval): stubbed for evaluating functions.
29323 * cs-parser.jay: Pass the defines information
29325 * driver.cs: Add --define command line option.
29327 * decl.cs: Move MemberCore here.
29329 Make it the base class for DeclSpace. This allows us to catch and
29330 report 108 and 109 for everything now.
29332 * class.cs (TypeContainer.Define): Extract all the members
29333 before populating and emit the warning 108 (new keyword required
29334 to override) instead of having each member implement this.
29336 (MemberCore.Define): New abstract method, we will be using this in
29337 the warning reporting engine in Populate.
29339 (Operator.Define): Adjust to new MemberCore protocol.
29341 * const.cs (Const): This does not derive from Expression, it is a
29342 temporary object we use to create fields, it is a MemberCore.
29344 * class.cs (Method.Define): Allow the entry point to be in a
29347 * driver.cs: Rewrite the argument handler to clean it up a bit.
29349 * rootcontext.cs: Made it just an auxiliary namespace feature by
29350 making everything static.
29352 * driver.cs: Adapt code to use RootContext type name instead of
29355 * delegate.cs: Remove RootContext argument.
29357 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29360 * class.cs (Event.Define): The lookup can fail.
29362 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29364 * expression.cs: Resolve the this instance before invoking the code.
29366 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29368 * cs-parser.jay: Add a production in element_access that allows
29369 the thing to become a "type" reference. This way we can parse
29370 things like "(string [])" as a type.
29372 Note that this still does not handle the more complex rules of
29376 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29378 * ecore.cs: (CopyNewMethods): new utility function used to
29379 assemble the list of methods from running FindMembers.
29381 (MemberLookup): Rework FindMembers so that
29383 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29385 * class.cs (TypeContainer): Remove Delegates who fail to be
29388 * delegate.cs (Populate): Verify that we dont get null return
29389 values. TODO: Check for AsAccessible.
29391 * cs-parser.jay: Use basename to emit error 574 (destructor should
29392 have the same name as container class), not the full name.
29394 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29395 possible representation.
29397 Also implements integer type suffixes U and L.
29399 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29401 * expression.cs (ArrayCreation.DoResolve): We need to do the
29402 argument resolution *always*.
29404 * decl.cs: Make this hold the namespace. Hold the root context as
29406 (LookupType): Move here.
29408 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29410 * location.cs (Row, Name): Fixed the code, it was always returning
29411 references to the first file.
29413 * interface.cs: Register properties defined through interfaces.
29415 * driver.cs: Add support for globbing on the command line
29417 * class.cs (Field): Make it derive from MemberCore as well.
29420 2001-12-15 Ravi Pratap <ravi@ximian.com>
29422 * class.cs (Event::Define): Check that the type of the event is a delegate
29423 type else flag error #66.
29425 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29428 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29429 values of EntryPoint, CharSet etc etc.
29431 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29433 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29434 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29435 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29436 which needs this to do its work.
29438 * ../errors/cs0066.cs : Add.
29440 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29442 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29445 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29446 clears out the parameters field.
29447 (MemberSignatureCompare): Cleanup
29449 (MemberCore): New base class used to share code between MethodCore
29452 (RegisterRequiredImplementations) BindingFlags.Public requires
29453 either BindingFlags.Instace or Static. Use instance here.
29455 (Property): Refactored code to cope better with the full spec.
29457 * parameter.cs (GetParameterInfo): Return an empty array instead
29460 * class.cs (Property): Abstract or extern properties have no bodies.
29462 * parameter.cs (GetParameterInfo): return a zero-sized array.
29464 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29465 method modifier validation to the typecontainer so we can reuse
29466 this on properties.
29468 (MethodCore.ParameterTypes): return an empty sized array of types.
29470 (Property.Define): Test property modifier validity.
29472 Add tests for sealed/override too.
29474 (Method.Emit): abstract or extern methods have no bodies.
29476 2001-12-14 Ravi Pratap <ravi@ximian.com>
29478 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29481 (Method::Define, ::Emit): Modify accordingly.
29483 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29485 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29487 * makefile: Pass in /unsafe.
29489 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29491 * class.cs (MakeKey): Kill routine.
29493 * class.cs (TypeContainer.Define): Correctly define explicit
29494 method implementations (they require the full interface name plus
29497 * typemanager.cs: Deply the PtrHashtable here and stop using the
29498 lame keys. Things work so much better.
29500 This of course broke everyone who depended on `RegisterMethod' to
29501 do the `test for existance' test. This has to be done elsewhere.
29503 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29504 the object stupid Equals method (because, that like fails all over
29505 the place). We still do not use it.
29507 * class.cs (TypeContainer.SetRequiredInterface,
29508 TypeContainer.RequireMethods): Killed these two routines and moved
29509 all the functionality to RegisterRequiredImplementations.
29511 (TypeContainer.RegisterRequiredImplementations): This routine now
29512 registers all the implementations required in an array for the
29513 interfaces and abstract methods. We use an array of structures
29514 which can be computed ahead of time to reduce memory usage and we
29515 also assume that lookups are cheap as most classes will not
29516 implement too many interfaces.
29518 We also avoid creating too many MethodSignatures.
29520 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29521 clear the "pending" bit if we find that there are problems with
29524 (TypeContainer.VerifyPendingMethods): Update to report errors of
29525 methods that look like implementations but are not.
29527 (TypeContainer.Define): Add support for explicit interface method
29530 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29532 * typemanager.cs: Keep track of the parameters here instead of
29533 being a feature of the TypeContainer.
29535 * class.cs: Drop the registration of parameters here, as
29536 InterfaceMethods are also interface declarations.
29538 * delegate.cs: Register methods with the TypeManager not only with
29539 the TypeContainer. This code was buggy.
29541 * interface.cs: Full registation here.
29543 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29545 * expression.cs: Remove reducer for binary expressions, it can not
29548 * const.cs: Put here the code that used to go into constant.cs
29550 * constant.cs: Put here the code for constants, this is a new base
29551 class for Literals.
29553 * literal.cs: Make Literal derive from Constant.
29555 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29557 * statement.cs (Return.Emit): Report error 157 if the user
29558 attempts to return from a finally block.
29560 (Return.Emit): Instead of emitting a return, jump to the end of
29563 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29564 LocalBuilder to store the result of the function. ReturnLabel is
29565 the target where we jump.
29568 2001-12-09 Radek Doulik <rodo@ximian.com>
29570 * cs-parser.jay: remember alias in current namespace
29572 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29575 * class.cs (LookupAlias): lookup alias in my_namespace
29577 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29579 (LookupAlias): lookup alias in this and if needed in parent
29582 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29586 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29587 making things static. I need this to avoid passing the
29588 TypeContainer when calling ParameterType.
29590 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29591 that did string manipulation to compute the type and then call
29592 GetType. Use Parameter.ParameterType instead.
29594 * cs-tokenizer.cs: Consume the suffix for floating values.
29596 * expression.cs (ParameterReference): figure out whether this is a
29597 reference parameter or not. Kill an extra variable by computing
29598 the arg_idx during emission.
29600 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29601 function that returns whether a parameter is an out/ref value or not.
29603 (Parameter.ParameterType): The type of the parameter (base,
29604 without ref/out applied).
29606 (Parameter.Resolve): Perform resolution here.
29607 (Parameter.ExternalType): The full type (with ref/out applied).
29609 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29610 support for expressions on the using statement.
29612 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29614 * statement.cs (Using.EmitLocalVariableDecls): Split the
29615 localvariable handling of the using statement.
29617 (Block.EmitMeta): Keep track of variable count across blocks. We
29618 were reusing slots on separate branches of blocks.
29620 (Try.Emit): Emit the general code block, we were not emitting it.
29622 Check the type of the declaration to be an IDisposable or
29623 something that can be implicity converted to it.
29625 Emit conversions if required.
29627 * ecore.cs (EmptyExpression): New utility class.
29628 (Expression.ImplicitConversionExists): New utility function.
29630 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29632 * statement.cs (Using): Implement.
29634 * expression.cs (LocalVariableReference): Support read only variables.
29636 * statement.cs: Remove the explicit emit for the Leave opcode.
29637 (VariableInfo): Add a readonly field.
29639 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29641 * ecore.cs (ConvCast): new class used to encapsulate the various
29642 explicit integer conversions that works in both checked and
29643 unchecked contexts.
29645 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29646 properly generate the overflow opcodes.
29648 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29650 * statement.cs: The correct type for the EmptyExpression is the
29651 element_type, not the variable type. Ravi pointed this out.
29653 2001-12-04 Ravi Pratap <ravi@ximian.com>
29655 * class.cs (Method::Define): Handle PInvoke methods specially
29656 by using DefinePInvokeMethod instead of the usual one.
29658 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29659 above to do the task of extracting information and defining the method.
29661 2001-12-04 Ravi Pratap <ravi@ximian.com>
29663 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29664 of the condition for string type.
29666 (Emit): Move that here.
29668 (ArrayCreation::CheckIndices): Keep string literals in their expression
29671 (EmitDynamicInitializers): Handle strings appropriately.
29673 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29675 * codegen.cs (EmitContext): Replace multiple variables with a
29676 single pointer to the current Switch statement.
29678 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29681 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29685 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29688 (Foreach.Emit): Foreach on arrays was not setting
29689 up the loop variables (for break/continue).
29691 (GotoCase): Semi-implented.
29693 2001-12-03 Ravi Pratap <ravi@ximian.com>
29695 * attribute.cs (CheckAttribute): Handle system attributes by using
29696 Attribute.GetAttributes to examine information we need.
29698 (GetValidPlaces): Same here.
29700 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29702 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29704 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29706 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29708 (Method::Emit): Handle the case when we are a PInvoke method.
29710 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29712 * expression.cs: Use ResolveWithSimpleName on compound names.
29714 2001-12-02 Ravi Pratap <ravi@ximian.com>
29716 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29717 before trying to reduce it.
29719 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29721 * constant.cs (LookupConstantValue): Implement.
29723 (EmitConstant): Use the above in emitting the constant.
29725 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
29726 that are user-defined by doing a LookupConstantValue on them.
29728 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
29731 2001-11-29 Miguel de Icaza <miguel@ximian.com>
29733 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
29735 (BaseAccess.DoResolve): Implement.
29737 (MemberAccess.DoResolve): Split this routine into a
29738 ResolveMemberAccess routine that can be used independently
29740 2001-11-28 Miguel de Icaza <miguel@ximian.com>
29742 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
29743 As that share bits of the implementation. Is returns a boolean,
29744 while As returns the Type that is being probed.
29746 2001-12-01 Ravi Pratap <ravi@ximian.com>
29748 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
29749 instead of a Literal - much easier.
29751 (EnumInTransit): Remove - utterly useless :-)
29753 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
29755 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
29757 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
29758 chain when we have no associated expression.
29760 2001-11-30 Ravi Pratap <ravi@ximian.com>
29762 * constant.cs (Define): Use Location while reporting the errror.
29764 Also emit a warning when 'new' is used and there is no inherited
29767 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
29770 (LookupEnumValue): Implement to lookup an enum member's value and define it
29773 (Populate): Re-write accordingly to use the above routine.
29775 2001-11-27 Miguel de Icaza <miguel@ximian.com>
29777 * expression.cs (This): Fix prototype for DoResolveLValue to
29778 override the base class DoResolveLValue.
29780 * cs-parser.cs: Report errors cs574 and cs575 (destructor
29783 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
29784 (we need to load the address of the field here). This fixes
29787 (FieldExpr.DoResolveLValue): Call the DoResolve
29788 function to initialize the Instance expression.
29790 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
29791 correctly the GetEnumerator operation on a value type.
29793 * cs-parser.jay: Add more simple parsing error catches.
29795 * statement.cs (Switch): Add support for string switches.
29796 Handle null specially.
29798 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
29800 2001-11-28 Ravi Pratap <ravi@ximian.com>
29802 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
29804 (declare_local_constant): New helper function.
29806 * statement.cs (AddConstant): Keep a separate record of constants
29808 (IsConstant): Implement to determine if a variable is a constant.
29810 (GetConstantExpression): Implement.
29812 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
29814 * statement.cs (IsVariableDefined): Re-write.
29816 2001-11-27 Ravi Pratap <ravi@ximian.com>
29818 * class.cs (TypeContainer::FindMembers): Look for constants
29819 in the case when we are looking for MemberTypes.Field
29821 * expression.cs (MemberAccess::DoResolve): Check that in the
29822 case we are a FieldExpr and a Literal, we are not being accessed
29823 by an instance reference.
29825 * cs-parser.jay (local_constant_declaration): Implement.
29827 (declaration_statement): Implement for constant declarations.
29829 2001-11-26 Miguel de Icaza <miguel@ximian.com>
29831 * statement.cs (Switch): Catch double defaults.
29833 (Switch): More work on the switch() statement
29834 implementation. It works for integral values now, need to finish
29838 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29840 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
29841 integer literals into other integer literals. To be used by
29844 2001-11-24 Ravi Pratap <ravi@ximian.com>
29846 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
29849 (EmitDynamicInitializers): Cope with the above since we extract data
29850 directly from ArrayData now.
29852 (ExpectInitializers): Keep track of whether initializers are mandatory
29855 (Bounds): Make it a hashtable to prevent the same dimension being
29856 recorded for every element in that dimension.
29858 (EmitDynamicInitializers): Fix bug which prevented the Set array method
29861 Also fix bug which was causing the indices to be emitted in the reverse
29864 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29866 * expression.cs (ArrayCreation): Implement the bits that Ravi left
29867 unfinished. They do not work, because the underlying code is
29870 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29872 * cs-parser.jay: Remove bogus fixme.
29874 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
29875 on Switch statement.
29877 2001-11-23 Ravi Pratap <ravi@ximian.com>
29879 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
29882 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
29883 parameter. Apparently, any expression is allowed.
29885 (ValidateInitializers): Update accordingly.
29887 (CheckIndices): Fix some tricky bugs thanks to recursion.
29889 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
29890 I was being completely brain-dead.
29892 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
29893 and re-write acordingly.
29895 (DelegateInvocation): Re-write accordingly.
29897 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
29899 (MakeByteBlob): Handle types more correctly.
29901 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
29902 initialization from expressions but it is incomplete because I am a complete
29905 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29907 * statement.cs (If.Emit): Fix a bug that generated incorrect code
29908 on If. Basically, we have to return `true' (ie, we do return to
29909 our caller) only if both branches of the if return.
29911 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
29912 short-circuit operators, handle them as short circuit operators.
29914 (Cast.DoResolve): Resolve type.
29915 (Cast.Cast): Take an expression as the target type.
29917 * cs-parser.jay (cast_expression): Remove old hack that only
29918 allowed a limited set of types to be handled. Now we take a
29919 unary_expression and we resolve to a type during semantic
29922 Use the grammar productions from Rhys to handle casts (this is
29923 not complete like Rhys syntax yet, we fail to handle that corner
29924 case that C# has regarding (-x), but we will get there.
29926 2001-11-22 Ravi Pratap <ravi@ximian.com>
29928 * class.cs (EmitFieldInitializer): Take care of the case when we have a
29929 field which is an array type.
29931 * cs-parser.jay (declare_local_variables): Support array initialization too.
29933 * typemanager.cs (MakeKey): Implement.
29935 (everywhere): Use the above appropriately.
29937 * cs-parser.jay (for_statement): Update for array initialization while
29938 declaring variables.
29940 * ecore.cs : The error message was correct, it's the variable's names that
29941 were misleading ;-) Make the code more readable.
29943 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
29944 the correct type etc.
29946 (ConvertExplicit): Handle Enum types by examining the underlying type.
29948 2001-11-21 Ravi Pratap <ravi@ximian.com>
29950 * parameter.cs (GetCallingConvention): Always return
29951 CallingConventions.Standard for now.
29953 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29955 * expression.cs (Binary.ResolveOperator): Update the values of `l'
29956 and `r' after calling DoNumericPromotions.
29958 * ecore.cs: Fix error message (the types were in the wrong order).
29960 * statement.cs (Foreach.ProbeCollectionType): Need to pass
29961 BindingFlags.Instance as well
29963 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
29964 implicit int literal conversion in an empty cast so that we
29965 propagate the right type upstream.
29967 (UnboxCast): new class used to unbox value types.
29968 (Expression.ConvertExplicit): Add explicit type conversions done
29971 (Expression.ImplicitNumericConversion): Oops, forgot to test for
29972 the target type before applying the implicit LongLiterals to ULong
29975 2001-11-21 Miguel de Icaza <miguel@ximian.com>
29977 * cs-parser.jay (for_statement): Reworked the way For works: now
29978 we declare manually any variables that are introduced in
29979 for_initializer to solve the problem of having out-of-band code
29980 emition (that is what got for broken).
29982 (declaration_statement): Perform the actual variable declaration
29983 that used to be done in local_variable_declaration here.
29985 (local_variable_declaration): Do not declare anything, just pass
29986 the information on a DictionaryEntry
29988 2001-11-20 Ravi Pratap <ravi@ximian.com>
29990 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
29991 re-write of the logic to now make it recursive.
29993 (UpdateIndices): Re-write accordingly.
29995 Store element data in a separate ArrayData list in the above methods.
29997 (MakeByteBlob): Implement to dump the array data into a byte array.
29999 2001-11-19 Ravi Pratap <ravi@ximian.com>
30001 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30004 * constant.cs (Define): Implement.
30006 (EmitConstant): Re-write fully.
30008 Pass in location info.
30010 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30013 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30014 DictionaryEntry since we need location info too.
30016 (constant_declaration): Update accordingly.
30018 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30019 code into another method : UpdateIndices.
30021 2001-11-18 Ravi Pratap <ravi@ximian.com>
30023 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30024 some type checking etc.
30026 2001-11-17 Ravi Pratap <ravi@ximian.com>
30028 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30029 bits to provide dimension info if the user skips doing that.
30031 Update second constructor to store the rank correctly.
30033 2001-11-16 Ravi Pratap <ravi@ximian.com>
30035 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30036 and try to implement.
30038 * ../errors/cs0150.cs : Add.
30040 * ../errors/cs0178.cs : Add.
30042 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30044 * statement.cs: Implement foreach on multi-dimensional arrays.
30046 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30047 name of the params argument.
30049 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30050 initializing the array.
30052 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30053 we can use this elsewhere.
30055 * statement.cs: Finish implementation of foreach for single
30058 * cs-parser.jay: Use an out-of-band stack to pass information
30059 around, I wonder why I need this.
30061 foreach_block: Make the new foreach_block the current_block.
30063 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30064 function used to return a static Parameters structure. Used for
30065 empty parameters, as those are created very frequently.
30067 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30069 2001-11-15 Ravi Pratap <ravi@ximian.com>
30071 * interface.cs : Default modifier is private, not public. The
30072 make verify test passes again.
30074 2001-11-15 Ravi Pratap <ravi@ximian.com>
30076 * support.cs (ReflectionParameters): Fix logic to determine
30077 whether the last parameter is a params one. Test 9 passes again.
30079 * delegate.cs (Populate): Register the builders we define with
30080 RegisterParameterForBuilder. Test 19 passes again.
30082 * cs-parser.jay (property_declaration): Reference $6 instead
30083 of $$ to get at the location.
30085 (indexer_declaration): Similar stuff.
30087 (attribute): Ditto.
30089 * class.cs (Property): Register parameters for the Get and Set methods
30090 if they exist. Test 23 passes again.
30092 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30093 call to EmitArguments as we are sure there aren't any params arguments.
30094 Test 32 passes again.
30096 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30097 IndexOutOfRangeException.
30099 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30100 Test 33 now passes again.
30102 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30104 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30105 broke a bunch of things. Will have to come up with a better way
30106 of tracking locations.
30108 * statement.cs: Implemented foreach for single dimension arrays.
30110 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30112 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30113 an error. This removes the lookup from the critical path.
30115 * cs-parser.jay: Removed use of temporary_loc, which is completely
30118 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30120 * support.cs (ReflectionParameters.ParameterModifier): Report
30121 whether the argument is a PARAMS argument or not.
30123 * class.cs: Set the attribute `ParamArrayAttribute' on the
30124 parameter argument.
30126 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30127 and cons_param_array_attribute (ConstructorInfo for
30128 ParamArrayAttribute).,
30130 * codegen.cs: Emit the return using the `Return' statement, that
30131 way we can report the error correctly for missing return values.
30133 * class.cs (Method.Emit): Clean up.
30135 * expression.cs (Argument.Resolve): Take another argument: the
30136 location where this argument is used. Notice that this is not
30137 part of the "Argument" class as to reduce the size of the
30138 structure (we know the approximate location anyways).
30140 Test if the argument is a variable-reference, if not, then
30141 complain with a 206.
30143 (Argument.Emit): Emit addresses of variables.
30145 (Argument.FullDesc): Simplify.
30147 (Invocation.DoResolve): Update for Argument.Resolve.
30149 (ElementAccess.DoResolve): ditto.
30151 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30152 method should be virtual, as this method is always virtual.
30154 (NewDelegate.DoResolve): Update for Argument.Resolve.
30156 * class.cs (ConstructorInitializer.DoResolve): ditto.
30158 * attribute.cs (Attribute.Resolve): ditto.
30160 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30162 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30164 * expression.cs (ParameterReference): Drop IStackStorage and implement
30165 IAssignMethod instead.
30167 (LocalVariableReference): ditto.
30169 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30170 IAssignMethod instead.
30172 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30174 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30175 enumerations that are used in heavily used structures derive from
30176 byte in a laughable and pathetic attempt to reduce memory usage.
30177 This is the kind of pre-optimzations that you should not do at
30178 home without adult supervision.
30180 * expression.cs (UnaryMutator): New class, used to handle ++ and
30181 -- separatedly from the other unary operators. Cleans up the
30182 code, and kills the ExpressionStatement dependency in Unary.
30184 (Unary): Removed `method' and `Arguments' from this class, making
30185 it smaller, and moving it all to SimpleCall, so I can reuse this
30186 code in other locations and avoid creating a lot of transient data
30187 strucutres when not required.
30189 * cs-parser.jay: Adjust for new changes.
30191 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30193 * enum.cs (Enum.Populate): If there is a failure during
30196 * cs-parser.jay (opt_enum_base): we used to catch type errors
30197 here, but this is really incorrect. The type error should be
30198 catched during semantic analysis.
30200 2001-12-11 Ravi Pratap <ravi@ximian.com>
30202 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30203 current_local_parameters as expected since I, in my stupidity, had forgotten
30206 * attribute.cs (GetValidPlaces): Fix stupid bug.
30208 * class.cs (Method::Emit): Perform check on applicability of attributes.
30210 (Constructor::Emit): Ditto.
30212 (Field::Emit): Ditto.
30214 (Field.Location): Store location information.
30216 (Property, Event, Indexer, Operator): Ditto.
30218 * cs-parser.jay (field_declaration): Pass in location for each field.
30220 * ../errors/cs0592.cs : Add.
30222 2001-11-12 Ravi Pratap <ravi@ximian.com>
30224 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30226 (InitCoreTypes): Update accordingly.
30228 (RegisterAttrType, LookupAttr): Implement.
30230 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30231 info about the same.
30233 (Resolve): Update to populate the above as necessary.
30235 (Error592): Helper.
30237 (GetValidPlaces): Helper to the above.
30239 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30241 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30243 2001-11-12 Ravi Pratap <ravi@ximian.com>
30245 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30247 * ../errors/cs0617.cs : Add.
30249 2001-11-11 Ravi Pratap <ravi@ximian.com>
30251 * enum.cs (Emit): Rename to Populate to be more consistent with what
30252 we expect it to do and when exactly it is called.
30254 * class.cs, rootcontext.cs : Update accordingly.
30256 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30257 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30259 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30261 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30262 of a fieldinfo using the above, when dealing with a FieldBuilder.
30264 2001-11-10 Ravi Pratap <ravi@ximian.com>
30266 * ../errors/cs0031.cs : Add.
30268 * ../errors/cs1008.cs : Add.
30270 * ../errrors/cs0543.cs : Add.
30272 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30275 (FindMembers): Implement.
30277 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30278 enums and delegates too.
30280 (enum_types): Rename to builder_to_enum.
30282 (delegate_types): Rename to builder_to_delegate.
30284 * delegate.cs (FindMembers): Implement.
30286 2001-11-09 Ravi Pratap <ravi@ximian.com>
30288 * typemanager.cs (IsEnumType): Implement.
30290 * enum.cs (Emit): Re-write parts to account for the underlying type
30291 better and perform checking etc.
30293 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30294 of the underlying type.
30296 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30299 * enum.cs (error31): Helper to report error #31.
30301 * cs-parser.jay (enum_declaration): Store location of each member too.
30303 * enum.cs (member_to_location): New hashtable.
30305 (AddEnumMember): Update location hashtable.
30307 (Emit): Use the location of each member while reporting errors.
30309 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30311 * cs-parser.jay: A for_initializer if is a
30312 local_variable_declaration really ammount to have an implicit
30313 block with the variable declaration and no initializer for for.
30315 * statement.cs (For.Emit): Cope with null initializers.
30317 This fixes the infinite loop on for initializers.
30319 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30321 * enum.cs: More cleanup.
30323 * ecore.cs: Remove dead code.
30325 * class.cs (Property.Emit): More simplification.
30326 (Event.Emit): ditto.
30328 Reworked to have less levels of indentation.
30330 2001-11-08 Ravi Pratap <ravi@ximian.com>
30332 * class.cs (Property): Emit attributes.
30342 * enum.cs (Emit): Ditto.
30344 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30347 * class.cs (Field, Event, etc.): Move attribute generation into the
30348 Emit method everywhere.
30350 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30351 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30352 as we had no way of defining nested enums !
30354 * rootcontext.cs : Adjust code accordingly.
30356 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30358 2001-11-07 Ravi Pratap <ravi@ximian.com>
30360 * expression.cs (EvalConstantExpression): Move into ecore.cs
30362 * enum.cs (Enum): Rename some members and make them public and readonly
30363 according to our convention.
30365 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30368 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30370 (Enum::Emit): Write a simple version for now which doesn't try to compute
30371 expressions. I shall modify this to be more robust in just a while.
30373 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30375 (TypeContainer::CloseType): Create the Enum types too.
30377 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30379 * expression.cs (EvalConstantExpression): Get rid of completely.
30381 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30382 user-defined values and other cases.
30384 (IsValidEnumLiteral): Helper function.
30386 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30387 out there in the case we had a literal FieldExpr.
30389 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30391 (Literalize): Revamp a bit to take two arguments.
30393 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30395 2001-11-06 Ravi Pratap <ravi@ximian.com>
30397 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30399 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30401 (Resolve): Use the above to ensure we have proper initializers.
30403 2001-11-05 Ravi Pratap <ravi@ximian.com>
30405 * expression.cs (Expression::EvalConstantExpression): New method to
30406 evaluate constant expressions.
30408 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30410 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30412 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30415 (Binary.ResolveOperator): Handle operator != (object a, object b)
30416 and operator == (object a, object b);
30418 (Binary.DoNumericPromotions): Indicate whether the numeric
30419 promotion was possible.
30421 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30424 Made the ArrayAccess implement interface IAssignMethod instead of
30425 IStackStore as the order in which arguments are passed reflects
30428 * assign.cs: Instead of using expr.ExprClass to select the way of
30429 assinging, probe for the IStackStore/IAssignMethod interfaces.
30431 * typemanager.cs: Load InitializeArray definition.
30433 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30434 static data that can be used to initialize arrays.
30436 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30438 * expression.cs: Handle operator== and operator!= for booleans.
30440 (Conditioal.Reduce): Implement reducer for the ?: operator.
30442 (Conditional.Resolve): Implement dead code elimination.
30444 (Binary.Resolve): Catch string literals and return a new
30445 concatenated string.
30447 (Unary.Reduce): Implement reduction of unary expressions.
30449 * ecore.cs: Split out the expression core handling here.
30451 (Expression.Reduce): New method used to perform constant folding
30452 and CSE. This is needed to support constant-expressions.
30454 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30455 targets, and optimize for !x.
30457 2001-11-04 Ravi Pratap <ravi@ximian.com>
30459 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30460 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30461 set custom atttributes.
30463 * literal.cs (Literal::GetValue): New abstract method to return the actual
30464 value of the literal, cast as an object.
30466 (*Literal): Implement GetValue method.
30468 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30469 expressions to the arraylist but objects of type Argument.
30471 * class.cs (TypeContainer::Emit): Emit our attributes too.
30473 (Method::Emit, Constructor::Emit): Ditto.
30475 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30476 to be ignoring earlier.
30478 2001-11-03 Ravi Pratap <ravi@ximian.com>
30480 * attribute.cs (AttributeSection::Define): Implement to do the business
30481 of constructing a CustomAttributeBuilder.
30483 (Attribute): New trivial class. Increases readability of code.
30485 * cs-parser.jay : Update accordingly.
30487 (positional_argument_list, named_argument_list, named_argument): New rules
30489 (attribute_arguments): Use the above so that we are more correct.
30491 2001-11-02 Ravi Pratap <ravi@ximian.com>
30493 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30494 to perform all checks for a method with a params parameter.
30496 (Invocation::OverloadResolve): Update to use the above method and therefore
30497 cope correctly with params method invocations.
30499 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30502 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30503 constructors in our parent too because we can't afford to miss out on
30506 * attribute.cs (AttributeSection): New name for the class Attribute
30508 Other trivial changes to improve readability.
30510 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30511 use the new class names.
30513 2001-11-01 Ravi Pratap <ravi@ximian.com>
30515 * class.cs (Method::Define): Complete definition for params types too
30517 (Indexer::Define): Ditto.
30519 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30520 Cope everywhere with a request for info about the array parameter.
30522 2001-11-01 Ravi Pratap <ravi@ximian.com>
30524 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30526 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30527 local_variable_type to extract the string corresponding to the type.
30529 (local_variable_type): Fixup the action to use the new helper method.
30531 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30534 * expression.cs : Clean out code which uses the above.
30536 2001-10-31 Ravi Pratap <ravi@ximian.com>
30538 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30539 and bale out if necessary by returning a false.
30541 (RegisterProperty): Ditto.
30543 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30544 and print out appropriate error messages.
30546 * interface.cs (everywhere): Ditto.
30548 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30549 location to constructor.
30551 * class.cs (Property, Event, Indexer): Update accordingly.
30553 * ../errors/cs111.cs : Added.
30555 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30556 of a method, as laid down by the spec.
30558 (Invocation::OverloadResolve): Use the above method.
30560 2001-10-31 Ravi Pratap <ravi@ximian.com>
30562 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30563 now take a TypeContainer and a Parameters object.
30565 (ParameterData): Modify return type of ParameterModifier method to be
30566 Parameter.Modifier and not a string.
30568 (ReflectionParameters, InternalParameters): Update accordingly.
30570 * expression.cs (Argument::GetParameterModifier): Same here.
30572 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30573 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30574 symbol in it at all so maybe this is only for now.
30576 2001-10-30 Ravi Pratap <ravi@ximian.com>
30578 * support.cs (InternalParameters): Constructor now takes an extra argument
30579 which is the actual Parameters class.
30581 (ParameterDesc): Update to provide info on ref/out modifiers.
30583 * class.cs (everywhere): Update call to InternalParameters to pass in
30584 the second argument too.
30586 * support.cs (ParameterData): Add ParameterModifier, which is a method
30587 to return the modifier info [ref/out etc]
30589 (InternalParameters, ReflectionParameters): Implement the above.
30591 * expression.cs (Argument::ParameterModifier): Similar function to return
30592 info about the argument's modifiers.
30594 (Invocation::OverloadResolve): Update to take into account matching modifiers
30597 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30598 a new SetFormalParameters object which we pass to InternalParameters.
30600 2001-10-30 Ravi Pratap <ravi@ximian.com>
30602 * expression.cs (NewArray): Merge into the ArrayCreation class.
30604 2001-10-29 Ravi Pratap <ravi@ximian.com>
30606 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30607 NewUserdefinedArray into one as there wasn't much of a use in having
30610 * expression.cs (Argument): Change field's name to ArgType from Type.
30612 (Type): New readonly property which returns the proper type, taking into
30613 account ref/out modifiers.
30615 (everywhere): Adjust code accordingly for the above.
30617 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30618 whether we are emitting for a ref or out parameter.
30620 * expression.cs (Argument::Emit): Use the above field to set the state.
30622 (LocalVariableReference::Emit): Update to honour the flag and emit the
30625 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30627 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30629 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30631 (ReflectionParameters, InternalParameters): Implement the above method.
30633 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30636 (Invocation::FullMethodDesc): Ditto.
30638 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30640 * cs-parser.jay: Add extra production for the second form of array
30643 * expression.cs (ArrayCreation): Update to reflect the above
30646 * Small changes to prepare for Array initialization.
30648 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30650 * typemanager.cs (ImplementsInterface): interface might be null;
30651 Deal with this problem;
30653 Also, we do store negative hits on the cache (null values), so use
30654 this instead of calling t.GetInterfaces on the type everytime.
30656 2001-10-28 Ravi Pratap <ravi@ximian.com>
30658 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30660 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30661 split functionality out into different classes.
30663 (New::FormArrayType): Move into NewBuiltinArray.
30665 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30668 (NewBuiltinArray): New class to handle creation of built-in arrays.
30670 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30671 account creation of one-dimensional arrays.
30673 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30675 (NewUserdefinedArray::DoResolve): Implement.
30677 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30679 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30680 we maintain inside the TypeManager. This is necessary to perform lookups on the
30683 (LookupType): Update to perform GetType on the module builders too.
30685 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30687 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30689 2001-10-23 Ravi Pratap <ravi@ximian.com>
30691 * expression.cs (New::DoResolve): Implement guts of array creation.
30693 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30695 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30697 * expression.cs: Fix bug I introduced lsat night that broke
30700 (Expression.Resolve): Report a 246 error (can not resolve name)
30701 if we find a SimpleName in the stream.
30703 (Expression.ResolveLValue): Ditto.
30705 (Expression.ResolveWithSimpleName): This function is a variant of
30706 ResolveName, this one allows SimpleNames to be returned without a
30707 warning. The only consumer of SimpleNames is MemberAccess
30709 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30711 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30712 might arrive here. I have my doubts that this is correct.
30714 * statement.cs (Lock): Implement lock statement.
30716 * cs-parser.jay: Small fixes to support `lock' and `using'
30718 * cs-tokenizer.cs: Remove extra space
30720 * driver.cs: New flag --checked, allows to turn on integer math
30723 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30724 Threading.Monitor.Exit
30726 2001-10-23 Miguel de Icaza <miguel@ximian.com>
30728 * expression.cs (IndexerAccess::DoResolveLValue): Set the
30729 Expression Class to be IndexerAccess.
30731 Notice that Indexer::DoResolve sets the eclass to Value.
30733 2001-10-22 Miguel de Icaza <miguel@ximian.com>
30735 * class.cs (TypeContainer::Emit): Emit code for indexers.
30737 * assign.cs (IAssignMethod): New interface implemented by Indexers
30738 and Properties for handling assignment.
30740 (Assign::Emit): Simplify and reuse code.
30742 * expression.cs (IndexerAccess, PropertyExpr): Implement
30743 IAssignMethod, clean up old code.
30745 2001-10-22 Ravi Pratap <ravi@ximian.com>
30747 * typemanager.cs (ImplementsInterface): New method to determine if a type
30748 implements a given interface. Provides a nice cache too.
30750 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
30753 (ConvertReferenceExplicit): Ditto.
30755 * delegate.cs (Delegate::Populate): Update to define the parameters on the
30756 various methods, with correct names etc.
30758 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
30759 Operator.UnaryNegation.
30761 * cs-parser.jay (operator_declarator): Be a little clever in the case where
30762 we have a unary plus or minus operator.
30764 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
30767 * everywhere : update accordingly.
30769 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
30772 * class.cs (Method::Define): For the case where we are implementing a method
30773 inherited from an interface, we need to set the MethodAttributes.Final flag too.
30774 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
30776 2001-10-21 Ravi Pratap <ravi@ximian.com>
30778 * interface.cs (FindMembers): Implement to work around S.R.E
30781 * typemanager.cs (IsInterfaceType): Implement.
30783 (FindMembers): Update to handle interface types too.
30785 * expression.cs (ImplicitReferenceConversion): Re-write bits which
30786 use IsAssignableFrom as that is not correct - it doesn't work.
30788 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
30789 and accordingly override EmitStatement.
30791 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
30792 using the correct logic :-)
30794 2001-10-19 Ravi Pratap <ravi@ximian.com>
30796 * ../errors/cs-11.cs : Add to demonstrate error -11
30798 2001-10-17 Miguel de Icaza <miguel@ximian.com>
30800 * assign.cs (Assign::Resolve): Resolve right hand side first, and
30801 then pass this as a hint to ResolveLValue.
30803 * expression.cs (FieldExpr): Add Location information
30805 (FieldExpr::LValueResolve): Report assignment to readonly
30808 (Expression::ExprClassFromMemberInfo): Pass location information.
30810 (Expression::ResolveLValue): Add new method that resolves an
30813 (Expression::DoResolveLValue): Default invocation calls
30816 (Indexers): New class used to keep track of indexers in a given
30819 (IStackStore): Renamed from LValue, as it did not really describe
30820 what this did. Also ResolveLValue is gone from this interface and
30821 now is part of Expression.
30823 (ElementAccess): Depending on the element access type
30825 * typemanager.cs: Add `indexer_name_type' as a Core type
30826 (System.Runtime.CompilerServices.IndexerNameAttribute)
30828 * statement.cs (Goto): Take a location.
30830 2001-10-18 Ravi Pratap <ravi@ximian.com>
30832 * delegate.cs (Delegate::VerifyDelegate): New method to verify
30833 if two delegates are compatible.
30835 (NewDelegate::DoResolve): Update to take care of the case when
30836 we instantiate a delegate from another delegate.
30838 * typemanager.cs (FindMembers): Don't even try to look up members
30839 of Delegate types for now.
30841 2001-10-18 Ravi Pratap <ravi@ximian.com>
30843 * delegate.cs (NewDelegate): New class to take care of delegate
30846 * expression.cs (New): Split the delegate related code out into
30847 the NewDelegate class.
30849 * delegate.cs (DelegateInvocation): New class to handle delegate
30852 * expression.cs (Invocation): Split out delegate related code into
30853 the DelegateInvocation class.
30855 2001-10-17 Ravi Pratap <ravi@ximian.com>
30857 * expression.cs (New::DoResolve): Implement delegate creation fully
30858 and according to the spec.
30860 (New::DoEmit): Update to handle delegates differently.
30862 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
30863 because of which we were printing out arguments in reverse order !
30865 * delegate.cs (VerifyMethod): Implement to check if the given method
30866 matches the delegate.
30868 (FullDelegateDesc): Implement.
30870 (VerifyApplicability): Implement.
30872 * expression.cs (Invocation::DoResolve): Update to accordingly handle
30873 delegate invocations too.
30875 (Invocation::Emit): Ditto.
30877 * ../errors/cs1593.cs : Added.
30879 * ../errors/cs1594.cs : Added.
30881 * delegate.cs (InstanceExpression, TargetMethod): New properties.
30883 2001-10-16 Ravi Pratap <ravi@ximian.com>
30885 * typemanager.cs (intptr_type): Core type for System.IntPtr
30887 (InitCoreTypes): Update for the same.
30889 (iasyncresult_type, asynccallback_type): Ditto.
30891 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
30894 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
30897 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
30898 the builders for the 4 members of a delegate type :-)
30900 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
30903 * expression.cs (New::DoResolve): Implement guts for delegate creation.
30905 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
30907 2001-10-15 Miguel de Icaza <miguel@ximian.com>
30909 * statement.cs (Break::Emit): Implement.
30910 (Continue::Emit): Implement.
30912 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
30913 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
30914 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
30915 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
30918 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
30919 properties that track the label for the current loop (begin of the
30920 loop and end of the loop).
30922 2001-10-15 Ravi Pratap <ravi@ximian.com>
30924 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
30925 use of emitting anything at all.
30927 * class.cs, rootcontext.cs : Get rid of calls to the same.
30929 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
30931 (Populate): Define the constructor correctly and set the implementation
30934 * typemanager.cs (delegate_types): New hashtable to hold delegates that
30937 (AddDelegateType): Implement.
30939 (IsDelegateType): Implement helper method.
30941 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
30943 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
30944 and accordingly handle it.
30946 * delegate.cs (Populate): Take TypeContainer argument.
30947 Implement bits to define the Invoke method. However, I still haven't figured out
30948 how to take care of the native int bit :-(
30950 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
30951 Qualify the name of the delegate, not its return type !
30953 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
30956 (StandardConversionExists): Checking for array types turns out to be recursive.
30958 (ConvertReferenceExplicit): Implement array conversion.
30960 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
30962 2001-10-12 Ravi Pratap <ravi@ximian.com>
30964 * cs-parser.jay (delegate_declaration): Store the fully qualified
30965 name as it is a type declaration.
30967 * delegate.cs (ReturnType, Name): Rename members to these. Make them
30970 (DefineDelegate): Renamed from Define. Does the same thing essentially,
30971 as TypeContainer::DefineType.
30973 (Populate): Method in which all the definition of the various methods (Invoke)
30976 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
30979 (CloseDelegate): Finally creates the delegate.
30981 * class.cs (TypeContainer::DefineType): Update to define delegates.
30982 (Populate, Emit and CloseType): Do the same thing here too.
30984 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
30985 delegates in all these operations.
30987 2001-10-14 Miguel de Icaza <miguel@ximian.com>
30989 * expression.cs: LocalTemporary: a new expression used to
30990 reference a temporary that has been created.
30992 * assign.cs: Handle PropertyAccess back here, so that we can
30993 provide the proper semantic access to properties.
30995 * expression.cs (Expression::ConvertReferenceExplicit): Implement
30996 a few more explicit conversions.
30998 * modifiers.cs: `NEW' modifier maps to HideBySig.
31000 * expression.cs (PropertyExpr): Make this into an
31001 ExpressionStatement, and support the EmitStatement code path.
31003 Perform get/set error checking, clean up the interface.
31005 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31006 them into toplevel access objects.
31008 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31010 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31013 * typemanager.cs: Keep track here of our PropertyBuilders again to
31014 work around lameness in SRE.
31016 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31018 * expression.cs (LValue::LValueResolve): New method in the
31019 interface, used to perform a second resolution pass for LValues.
31021 (This::DoResolve): Catch the use of this in static methods.
31023 (This::LValueResolve): Implement.
31025 (This::Store): Remove warning, assigning to `this' in structures
31028 (Invocation::Emit): Deal with invocation of
31029 methods on value types. We need to pass the address to structure
31030 methods rather than the object itself. (The equivalent code to
31031 emit "this" for structures leaves the entire structure on the
31032 stack instead of a pointer to it).
31034 (ParameterReference::DoResolve): Compute the real index for the
31035 argument based on whether the method takes or not a `this' pointer
31036 (ie, the method is static).
31038 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31039 value types returned from functions when we need to invoke a
31040 method on the sturcture.
31043 2001-10-11 Ravi Pratap <ravi@ximian.com>
31045 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31046 defining the type in the Modulebuilder or Typebuilder. This is to take
31047 care of nested types which need to be defined on the TypeBuilder using
31048 DefineNestedMethod.
31050 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31051 methods in RootContext, only ported to be part of TypeContainer.
31053 (TypeContainer::GetInterfaceOrClass): Ditto.
31055 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31057 * interface.cs (Interface::DefineInterface): New method. Does exactly
31058 what RootContext.CreateInterface did earlier, only it takes care of nested types
31061 (Interface::GetInterfaces): Move from RootContext here and port.
31063 (Interface::GetInterfaceByName): Same here.
31065 * rootcontext.cs (ResolveTree): Re-write.
31067 (PopulateTypes): Re-write.
31069 * class.cs (TypeContainer::Populate): Populate nested types too.
31070 (TypeContainer::Emit): Emit nested members too.
31072 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31073 instead just use the name argument passed in as it is already fully
31076 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31077 to TypeContainer mapping to see if a type is user-defined.
31079 * class.cs (TypeContainer::CloseType): Implement.
31081 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31082 the default constructor.
31084 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31087 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31089 * interface.cs (CloseType): Create the type here.
31091 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31094 Remove all the methods which are now in TypeContainer.
31096 2001-10-10 Ravi Pratap <ravi@ximian.com>
31098 * delegate.cs (Define): Re-write bits to define the delegate
31101 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31103 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31105 * expression.cs (ImplicitReferenceConversion): handle null as well
31106 as a source to convert to any reference type.
31108 * statement.cs (Return): Perform any implicit conversions to
31109 expected return type.
31111 Validate use of return statement.
31113 * codegen.cs (EmitContext): Pass the expected return type here.
31115 * class.cs (Method, Constructor, Property): Pass expected return
31116 type to EmitContext.
31118 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31120 * expression.cs: Make DoResolve take an EmitContext instead of a
31123 Replaced `l' and `location' for `loc', for consistency.
31125 (Error, Warning): Remove unneeded Tc argument.
31127 * assign.cs, literal.cs, constant.cs: Update to new calling
31130 * codegen.cs: EmitContext now contains a flag indicating whether
31131 code is being generated in a static method or not.
31133 * cs-parser.jay: DecomposeQI, new function that replaces the old
31134 QualifiedIdentifier. Now we always decompose the assembled
31135 strings from qualified_identifier productions into a group of
31138 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31140 * rootcontext.cs: Deal with field-less struct types correctly now
31141 by passing the size option to Define Type.
31143 * class.cs: Removed hack that created one static field.
31145 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31147 * statement.cs: Moved most of the code generation here.
31149 2001-10-09 Ravi Pratap <ravi@ximian.com>
31151 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31154 (ElementAccess): Remove useless bits for now - keep checks as the spec
31157 2001-10-08 Ravi Pratap <ravi@ximian.com>
31159 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31160 and start performing checks according to the spec.
31162 2001-10-07 Ravi Pratap <ravi@ximian.com>
31164 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31165 rank_specifiers instead.
31167 (rank_specifiers): Change the order in which the rank specifiers are stored
31169 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31171 * expression.cs (ElementAccess): Implement the LValue interface too.
31173 2001-10-06 Ravi Pratap <ravi@ximian.com>
31175 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31176 except that user defined conversions are not included.
31178 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31179 perform the conversion of the return type, if necessary.
31181 (New::DoResolve): Check whether we are creating an array or an object
31182 and accordingly do the needful.
31184 (New::Emit): Same here.
31186 (New::DoResolve): Implement guts of array creation.
31188 (New::FormLookupType): Helper function.
31190 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31192 * codegen.cs: Removed most of the code generation here, and move the
31193 corresponding code generation bits to the statement classes.
31195 Added support for try/catch/finalize and throw.
31197 * cs-parser.jay: Added support for try/catch/finalize.
31199 * class.cs: Catch static methods having the flags override,
31200 virtual or abstract.
31202 * expression.cs (UserCast): This user cast was not really doing
31203 what it was supposed to do. Which is to be born in fully resolved
31204 state. Parts of the resolution were being performed at Emit time!
31208 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31210 * expression.cs: Implicity convert the result from UserCast.
31212 2001-10-05 Ravi Pratap <ravi@ximian.com>
31214 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31215 prevented it from working correctly.
31217 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31218 merely ConvertImplicit.
31220 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31222 * typemanager.cs: Make the LookupTypeContainer function static,
31223 and not per-instance.
31225 * class.cs: Make static FindMembers (the one that takes a Type
31228 * codegen.cs: Add EmitForeach here.
31230 * cs-parser.jay: Make foreach a toplevel object instead of the
31231 inline expansion, as we need to perform semantic analysis on it.
31233 2001-10-05 Ravi Pratap <ravi@ximian.com>
31235 * expression.cs (Expression::ImplicitUserConversion): Rename to
31236 UserDefinedConversion.
31238 (Expression::UserDefinedConversion): Take an extra argument specifying
31239 whether we look for explicit user conversions too.
31241 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31243 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31245 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31246 with the appropriate arguments.
31248 * cs-parser.jay (cast_expression): Record location too.
31250 * expression.cs (Cast): Record location info.
31252 (Expression::ConvertExplicit): Take location argument.
31254 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31255 to determine if we are doing explicit conversions.
31257 (UserCast::Emit): Update accordingly.
31259 (Expression::ConvertExplicit): Report an error if everything fails.
31261 * ../errors/cs0030.cs : Add.
31263 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31265 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31266 virtual and newslot bits.
31268 * class.cs (TypeContainer::RegisterRequiredImplementations):
31269 Record methods we need.
31271 (TypeContainer::MakeKey): Helper function to make keys for
31272 MethodBases, since the Methodbase key is useless.
31274 (TypeContainer::Populate): Call RegisterRequiredImplementations
31275 before defining the methods.
31277 Create a mapping for method_builders_to_methods ahead of time
31278 instead of inside a tight loop.
31280 (::RequireMethods): Accept an object as the data to set into the
31281 hashtable so we can report interface vs abstract method mismatch.
31283 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31285 * report.cs: Make all of it static.
31287 * rootcontext.cs: Drop object_type and value_type computations, as
31288 we have those in the TypeManager anyways.
31290 Drop report instance variable too, now it is a global.
31292 * driver.cs: Use try/catch on command line handling.
31294 Add --probe option to debug the error reporting system with a test
31297 * report.cs: Add support for exiting program when a probe
31298 condition is reached.
31300 2001-10-03 Ravi Pratap <ravi@ximian.com>
31302 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31303 we do a forcible conversion regardless of type, to check if
31304 ForceConversion returns a null.
31306 (Binary::error19): Use location to report error.
31308 (Unary::error23): Use location here too.
31310 * ../errors/cs0019.cs : Check in.
31312 * ../errors/cs0023.cs : Check in.
31314 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31315 case of a non-null MethodInfo object with a length of 0 !
31317 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31318 an applicable member - according to the spec :-)
31319 Also fix logic to find members in base types.
31321 (Unary::ResolveOperator): Same here.
31323 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31324 as I was getting thoroughly confused between this and error19 :-)
31326 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31327 (::FindMostEncompassedType): Implement.
31328 (::FindMostEncompassingType): Implement.
31329 (::StandardConversionExists): Implement.
31331 (UserImplicitCast): Re-vamp. We now need info about most specific
31332 source and target types so that we can do the necessary conversions.
31334 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31335 mathematical union with no duplicates.
31337 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31339 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31340 in order from base classes to child classes, so that we can in
31341 child classes look up in our parent for method names and
31342 attributes (required for handling abstract, virtual, new, override
31343 constructs: we need to instrospect our base class, and if we dont
31344 populate the classes in order, the introspection might be
31345 incorrect. For example, a method could query its parent before
31346 the parent has any methods and would determine that the parent has
31347 no abstract methods (while it could have had them)).
31349 (RootContext::CreateType): Record the order in which we define the
31352 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31354 * class.cs (TypeContainer::Populate): Also method definitions can
31355 fail now, keep track of this.
31357 (TypeContainer::FindMembers): Implement support for
31358 DeclaredOnly/noDeclaredOnly flag.
31360 (Constructor::Emit) Return the ConstructorBuilder.
31362 (Method::Emit) Return the MethodBuilder.
31363 Check for abstract or virtual methods to be public.
31365 * rootcontext.cs (RootContext::CreateType): Register all the
31366 abstract methods required for the class to be complete and the
31367 interface methods that must be implemented.
31369 * cs-parser.jay: Report error 501 (method requires body if it is
31370 not marked abstract or extern).
31372 * expression.cs (TypeOf::Emit): Implement.
31374 * typemanager.cs: runtime_handle_type, new global type.
31376 * class.cs (Property::Emit): Generate code for properties.
31378 2001-10-02 Ravi Pratap <ravi@ximian.com>
31380 * expression.cs (Unary::ResolveOperator): Find operators on base type
31381 too - we now conform exactly to the spec.
31383 (Binary::ResolveOperator): Same here.
31385 * class.cs (Operator::Define): Fix minor quirk in the tests.
31387 * ../errors/cs0215.cs : Added.
31389 * ../errors/cs0556.cs : Added.
31391 * ../errors/cs0555.cs : Added.
31393 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31395 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31396 single integer which is really efficient
31398 2001-10-01 Ravi Pratap <ravi@ximian.com>
31400 * expression.cs (Expression::ImplicitUserConversion): Use location
31401 even in the case when we are examining True operators.
31403 * class.cs (Operator::Define): Perform extensive checks to conform
31404 with the rules for operator overloading in the spec.
31406 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31407 some of the other conversions mentioned in the spec.
31409 * typemanager.cs (array_type): New static member for the System.Array built-in
31412 (cloneable_interface): For System.ICloneable interface.
31414 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31415 we start resolving the tree and populating types.
31417 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31419 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31421 * expression.cs (Expression::ExprClassFromMemberInfo,
31422 Expression::Literalize): Create literal expressions from
31423 FieldInfos which are literals.
31425 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31426 type casts, because they were wrong. The test suite in tests
31429 (ImplicitNumericConversion): ushort to ulong requires a widening
31432 Int32 constant to long requires widening cast as well.
31434 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31435 for integers because the type on the stack is not i4.
31437 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31439 * expression.cs (report118): require location argument.
31441 * parameter.cs: Do not dereference potential null value.
31443 * class.cs: Catch methods that lack the `new' keyword when
31444 overriding a name. Report warnings when `new' is used without
31445 anything being there to override.
31447 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31449 * class.cs: Only add constructor to hashtable if it is non-null
31450 (as now constructors can fail on define).
31452 (TypeManager, Class, Struct): Take location arguments.
31454 Catch field instance initialization in structs as errors.
31456 accepting_filter: a new filter for FindMembers that is static so
31457 that we dont create an instance per invocation.
31459 (Constructor::Define): Catch errors where a struct constructor is
31462 * cs-parser.jay: Pass location information for various new
31465 * delegate.cs (Delegate): take a location argument.
31467 * driver.cs: Do not call EmitCode if there were problesm in the
31468 Definition of the types, as many Builders wont be there.
31470 * decl.cs (Decl::Decl): Require a location argument.
31472 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31473 into integers, and find the most appropiate integer for it.
31475 * literal.cs: Implement ULongLiteral.
31477 * rootcontext.cs: Provide better information about the location of
31478 failure when CreateType fails.
31480 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31482 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31485 * expression.cs (Binary::CheckShiftArguments): Add missing type
31487 (Binary::ResolveOperator): Add type to the logical and and logical
31488 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31491 (Binary::DoNumericPromotions): In the case where either argument
31492 is ulong (and most signed types combined with ulong cause an
31493 error) perform implicit integer constant conversions as well.
31495 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31497 * expression.cs (UserImplicitCast): Method should always be
31499 (Invocation::BetterConversion): Simplified test for IntLiteral.
31501 (Expression::ImplicitNumericConversion): Split this routine out.
31502 Put the code that performs implicit constant integer conversions
31505 (Expression::Resolve): Become a wrapper around DoResolve so we can
31506 check eclass and type being set after resolve.
31508 (Invocation::Badness): Remove this dead function
31510 (Binary::ResolveOperator): Do not compute the expensive argumnets
31511 unless we have a union for it.
31513 (Probe::Emit): Is needs to do an isinst and then
31514 compare against null.
31516 (::CanConvert): Added Location argument. If the Location argument
31517 is null (Location.Null), then we do not report errors. This is
31518 used by the `probe' mechanism of the Explicit conversion. We do
31519 not want to generate an error for something that the user
31520 explicitly requested to be casted. But the pipeline for an
31521 explicit cast first tests for potential implicit casts.
31523 So for now, if the Location is null, it means `Probe only' to
31524 avoid adding another argument. Might have to revise this
31527 (ClassCast): New class used to type cast objects into arbitrary
31528 classes (used in Explicit Reference Conversions).
31530 Implement `as' as well.
31532 Reverted all the patches from Ravi below: they were broken:
31534 * The use of `level' as a mechanism to stop recursive
31535 invocations is wrong. That was there just to catch the
31536 bug with a strack trace but not as a way of addressing
31539 To fix the problem we have to *understand* what is going
31540 on and the interactions and come up with a plan, not
31541 just get things going.
31543 * The use of the type conversion cache that I proposed
31544 last night had an open topic: How does this work across
31545 protection domains. A user defined conversion might not
31546 be public in the location where we are applying the
31547 conversion, a different conversion might be selected
31548 (ie, private A->B (better) but public B->A (worse),
31549 inside A, A->B applies, but outside it, B->A will
31552 * On top of that (ie, even if the above is solved),
31553 conversions in a cache need to be abstract. Ie, `To
31554 convert from an Int to a Short use an OpcodeCast', not
31555 `To convert from an Int to a Short use the OpcodeCast on
31556 the variable 5' (which is what this patch was doing).
31558 2001-09-28 Ravi Pratap <ravi@ximian.com>
31560 * expression.cs (Invocation::ConversionExists): Re-write to use
31561 the conversion cache
31563 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31564 cache all conversions done, not just user-defined ones.
31566 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31567 to determine if a conversion exists instead of acutually trying to
31568 perform the conversion. It's faster too.
31570 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31571 and only then attempt the implicit conversion.
31573 2001-09-28 Ravi Pratap <ravi@ximian.com>
31575 * expression.cs (ConvertImplicit): Use a cache for conversions
31576 already found. Check level of recursion and bail out if necessary.
31578 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31580 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31581 Export standard methods that we expect for string operations.
31583 * statement.cs (Block::UsageWarning): Track usage of variables and
31584 report the errors for not used variables.
31586 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31589 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31591 * codegen.cs: remove unnneded code
31593 * expression.cs: Removed BuiltinTypeAccess class
31595 Fix the order in which implicit conversions are
31598 The previous fixed dropped support for boxed conversions (adding a
31599 test to the test suite now)
31601 (UserImplicitCast::CanConvert): Remove test for source being null,
31602 that code is broken. We should not feed a null to begin with, if
31603 we do, then we should track the bug where the problem originates
31604 and not try to cover it up here.
31606 Return a resolved expression of type UserImplicitCast on success
31607 rather than true/false. Ravi: this is what I was talking about,
31608 the pattern is to use a static method as a "constructor" for
31611 Also, do not create arguments until the very last minute,
31612 otherwise we always create the arguments even for lookups that
31613 will never be performed.
31615 (UserImplicitCast::Resolve): Eliminate, objects of type
31616 UserImplicitCast are born in a fully resolved state.
31618 * typemanager.cs (InitCoreTypes): Init also value_type
31619 (System.ValueType).
31621 * expression.cs (Cast::Resolve): First resolve the child expression.
31623 (LValue): Add new method AddressOf to be used by
31626 Change the argument of Store to take an EmitContext instead of an
31627 ILGenerator, because things like FieldExpr need to be able to call
31628 their children expression to generate the instance code.
31630 (Expression::Error, Expression::Warning): Sugar functions for
31633 (Expression::MemberLookup): Accept a TypeContainer instead of a
31634 Report as the first argument.
31636 (Expression::ResolvePrimary): Killed. I still want to improve
31637 this as currently the code is just not right.
31639 (Expression::ResolveMemberAccess): Simplify, but it is still
31642 (Unary::Resolve): Catch errors in AddressOf operators.
31644 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31645 index to a byte for the short-version, or the compiler will choose
31646 the wrong Emit call, which generates the wrong data.
31648 (ParameterReference::Emit, ::Store): same.
31650 (FieldExpr::AddressOf): Implement.
31652 * typemanager.cs: TypeManager: made public variable instead of
31655 * driver.cs: document --fatal.
31657 * report.cs (ErrorMessage, WarningMessage): new names for the old
31658 Error and Warning classes.
31660 * cs-parser.jay (member_access): Turn built-in access to types
31661 into a normal simplename
31663 2001-09-27 Ravi Pratap <ravi@ximian.com>
31665 * expression.cs (Invocation::BetterConversion): Fix to cope
31666 with q being null, since this was introducing a bug.
31668 * expression.cs (ConvertImplicit): Do built-in conversions first.
31670 2001-09-27 Ravi Pratap <ravi@ximian.com>
31672 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31674 2001-09-27 Ravi Pratap <ravi@ximian.com>
31676 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31677 I had introduced long ago (what's new ?).
31679 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31680 the work of all the checking.
31681 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31682 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31684 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31685 that is the right way.
31687 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31688 overloading resolution. Use everywhere instead of cutting and pasting code.
31690 (Binary::ResolveOperator): Use MakeUnionSet.
31692 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31693 we have to convert to bool types. Not complete yet.
31695 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31697 * typemanager.cs (TypeManager::CSharpName): support ushort.
31699 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31700 to provide an expression that performsn an implicit constant int
31701 conversion (section 6.1.6).
31702 (Expression::ConvertImplicitRequired): Reworked to include
31703 implicit constant expression conversions.
31705 (Expression::ConvertNumericExplicit): Finished.
31707 (Invocation::Emit): If InstanceExpression is null, then it means
31708 that we perform a call on this.
31710 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31712 * expression.cs (Unary::Emit): Remove some dead code.
31713 (Probe): Implement Resolve and Emit for `is'.
31714 (Expression::ConvertImplicitRequired): Attempt to do constant
31715 expression conversions here. Maybe should be moved to
31716 ConvertImplicit, but I am not sure.
31717 (Expression::ImplicitLongConstantConversionPossible,
31718 Expression::ImplicitIntConstantConversionPossible): New functions
31719 that tell whether is it possible to apply an implicit constant
31720 expression conversion.
31722 (ConvertNumericExplicit): Started work on explicit numeric
31725 * cs-parser.jay: Update operator constants.
31727 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
31728 (Parameters::GetSignature): Hook up VerifyArgs here.
31729 (Parameters::VerifyArgs): Verifies that no two arguments have the
31732 * class.cs (Operator): Update the operator names to reflect the
31733 ones that the spec expects (as we are just stringizing the
31736 * expression.cs (Unary::ResolveOperator): Fix bug: Use
31737 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
31738 previous usage did only work for our methods.
31739 (Expression::ConvertImplicit): Handle decimal implicit numeric
31740 conversions as well.
31741 (Expression::InternalTypeConstructor): Used to invoke constructors
31742 on internal types for default promotions.
31744 (Unary::Emit): Implement special handling for the pre/post
31745 increment/decrement for overloaded operators, as they need to have
31746 the same semantics as the other operators.
31748 (Binary::ResolveOperator): ditto.
31749 (Invocation::ConversionExists): ditto.
31750 (UserImplicitCast::Resolve): ditto.
31752 2001-09-26 Ravi Pratap <ravi@ximian.com>
31754 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
31755 operator, return after emitting body. Regression tests pass again !
31757 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
31758 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
31759 (Invocation::OverloadResolve): Ditto.
31760 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
31762 * everywhere : update calls to the above methods accordingly.
31764 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31766 * assign.cs (Assign): Make it inherit from ExpressionStatement.
31768 * expression.cs (ExpressionStatement): New base class used for
31769 expressions that can appear in statements, so that we can provide
31770 an alternate path to generate expression that do not leave a value
31773 (Expression::Emit, and all the derivatives): We no longer return
31774 whether a value is left on the stack or not. Every expression
31775 after being emitted leaves a single value on the stack.
31777 * codegen.cs (EmitContext::EmitStatementExpression): Use the
31778 facilties of ExpressionStatement if possible.
31780 * cs-parser.jay: Update statement_expression.
31782 2001-09-25 Miguel de Icaza <miguel@ximian.com>
31784 * driver.cs: Change the wording of message
31786 2001-09-25 Ravi Pratap <ravi@ximian.com>
31788 * expression.cs (Binary::ResolveOperator): Had forgottten to set
31789 the type of the expression to the return type of the method if
31790 we have an overloaded operator match ! The regression tests pass again !
31791 (Unary::ResolveOperator): Ditto.
31793 * expression.cs (Invocation::ConversionExists): Correct the member lookup
31794 to find "op_Implicit", not "implicit" ;-)
31795 (UserImplicitCast): New class to take care of user-defined implicit conversions.
31796 (ConvertImplicit, ForceConversion): Take TypeContainer argument
31798 * everywhere : Correct calls to the above accordingly.
31800 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
31801 (ConvertImplicit): Do user-defined conversion if it exists.
31803 2001-09-24 Miguel de Icaza <miguel@ximian.com>
31805 * assign.cs: track location.
31806 (Resolve): Use implicit conversions on assignment.
31808 * literal.cs: Oops. Not good, Emit of short access values should
31809 pass (Bytes) or the wrong argument will be selected.
31811 * expression.cs (Unary::Emit): Emit code for -expr.
31813 (Unary::ResolveOperator): Handle `Substract' for non-constants
31814 (substract from zero from the non-constants).
31815 Deal with Doubles as well.
31817 (Expression::ConvertImplicitRequired): New routine that reports an
31818 error if no implicit conversion exists.
31820 (Invocation::OverloadResolve): Store the converted implicit
31821 expressions if we make them
31823 2001-09-24 Ravi Pratap <ravi@ximian.com>
31825 * class.cs (ConstructorInitializer): Take a Location argument.
31826 (ConstructorBaseInitializer): Same here.
31827 (ConstructorThisInitializer): Same here.
31829 * cs-parser.jay : Update all calls accordingly.
31831 * expression.cs (Unary, Binary, New): Take location argument.
31832 Update accordingly everywhere.
31834 * cs-parser.jay : Update all calls to the above to take a location
31837 * class.cs : Ditto.
31839 2001-09-24 Ravi Pratap <ravi@ximian.com>
31841 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
31842 (Invocation::BetterConversion): Same here
31843 (Invocation::ConversionExists): Ditto.
31845 (Invocation::ConversionExists): Implement.
31847 2001-09-22 Ravi Pratap <ravi@ximian.com>
31849 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
31850 Also take an additional TypeContainer argument.
31852 * All over : Pass in TypeContainer as argument to OverloadResolve.
31854 * typemanager.cs (CSharpName): Update to check for the string type and return
31857 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
31860 2001-09-21 Ravi Pratap <ravi@ximian.com>
31862 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
31863 (Invocation::BetterFunction): Implement.
31864 (Invocation::BetterConversion): Implement.
31865 (Invocation::ConversionExists): Skeleton, no implementation yet.
31867 Okay, things work fine !
31869 2001-09-21 Miguel de Icaza <miguel@ximian.com>
31871 * typemanager.cs: declare and load enum_type, delegate_type and
31874 * expression.cs (Expression::Emit): Now emit returns a value that
31875 tells whether a value is left on the stack or not. This strategy
31876 might be reveted tomorrow with a mechanism that would address
31877 multiple assignments.
31878 (Expression::report118): Utility routine to report mismatches on
31881 (Unary::Report23): Report impossible type/operator combination
31884 (Unary::IsIncrementableNumber): Whether the type can be
31885 incremented or decremented with add.
31886 (Unary::ResolveOperator): Also allow enumerations to be bitwise
31888 (Unary::ResolveOperator): Implement ++, !, ~,
31890 (Invocation::Emit): Deal with new Emit convetion.
31892 * All Expression derivatives: Updated their Emit method to return
31893 whether they leave values on the stack or not.
31895 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
31896 stack for expressions that are statements.
31898 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31900 * expression.cs (LValue): New interface. Must be implemented by
31902 (LocalVariableReference, ParameterReference, FieldExpr): Implement
31905 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
31906 interface for generating code, simplifies the code.
31908 2001-09-20 Ravi Pratap <ravi@ximian.com>
31910 * expression.cs (everywhere): Comment out return statements in ::Resolve
31911 methods to avoid the warnings.
31913 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31915 * driver.cs (parse): Report error 2001 if we can not open the
31918 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
31921 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
31924 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
31925 otherwise nested blocks end up with the same index.
31927 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
31929 * expression.cs: Instead of having FIXMEs in the Resolve
31930 functions, throw exceptions so it is obvious that we are facing a
31933 * cs-parser.jay (invocation_expression): Pass Location information.
31935 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
31936 Use a basename for those routines because .NET does not like paths
31939 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
31942 2001-09-19 Miguel de Icaza <miguel@ximian.com>
31944 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
31945 are loading the correct data types (throws an exception if not).
31946 (TypeManager::InitCoreTypes): Use CoreLookupType
31948 * expression.cs (Unary::ResolveOperator): return the child
31949 expression for expressions which are just +expr.
31950 (Unary::ResolveOperator): Return negative literals for -LITERAL
31951 expressions (otherwise they are Unary {Literal}).
31952 (Invocation::Badness): Take into account `Implicit constant
31953 expression conversions'.
31955 * literal.cs (LongLiteral): Implement long literal class.
31956 (IntLiteral): export the `Value' of the intliteral.
31958 2001-09-19 Ravi Pratap <ravi@ximian.com>
31960 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
31962 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
31963 instead of 'Operator'
31965 * expression.cs (Binary::ResolveOperator): Update accordingly.
31966 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
31969 * cs-parser.jay (unary_expression): Update to use the new names.
31971 * gen-treedump.cs (GetUnary): Same here.
31973 * expression.cs (Unary::Resolve): Implement.
31974 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
31975 operators are found instead of making noise ;-)
31976 (Unary::ResolveOperator): New method to do precisely the same thing which
31977 Binary::ResolveOperator does for Binary expressions.
31978 (Unary.method, .Arguments): Add.
31979 (Unary::OperName): Implement.
31980 (Unary::ForceConversion): Copy and Paste !
31982 * class.cs (Operator::Define): Fix a small bug for the case when we have
31985 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
31986 for the inbuilt operators. Only overloading works for now ;-)
31988 2001-09-18 Miguel de Icaza <miguel@ximian.com>
31990 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
31991 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
31993 * expression.cs (This::Emit): Implement.
31994 (This::Resolve): Implement.
31995 (TypeOf:Resolve): Implement.
31996 (Expression::ResolveSimpleName): Add an implicit this to instance
31998 (MemberAccess::Resolve): Deal with Parameters and Fields.
31999 Bind instance variable to Field expressions.
32000 (FieldExpr::Instance): New field used to track the expression that
32001 represents the object instance.
32002 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32004 (FieldExpr::Emit): Implement.
32006 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32007 the last instruction contains a return opcode to avoid generating
32008 the last `ret' instruction (this generates correct code, and it is
32009 nice to pass the peverify output).
32011 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32012 initializer for static and instance variables.
32013 (Constructor::Emit): Allow initializer to be null in the case of
32014 static constructors. Only emit initializer for instance
32017 (TypeContainer::FindMembers): Return a null array if there are no
32020 Also fix the code for the MemberTypes.Method branch, as it was not
32021 scanning that for operators (or tried to access null variables before).
32023 * assign.cs (Assign::Emit): Handle instance and static fields.
32027 * driver.cs: Stop compilation if there are parse errors.
32029 * cs-parser.jay (constructor_declaration): Provide default base
32030 initializer for non-static constructors.
32031 (constructor_declarator): Do not provide a default base
32032 initializers if none was specified.
32033 Catch the fact that constructors should not have parameters.
32035 * class.cs: Do not emit parent class initializers for static
32036 constructors, that should be flagged as an error.
32038 2001-09-18 Ravi Pratap <ravi@ximian.com>
32040 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32041 Move back code into TypeContainer::Populate.
32043 2001-09-18 Ravi Pratap <ravi@ximian.com>
32045 * class.cs (TypeContainer::AddConstructor): Fix the check to
32046 compare against Name, not Basename.
32047 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32049 * cs-parser.jay : Update accordingly.
32051 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32052 for methods, don't forget to look into the operators too.
32053 (RegisterMethodBuilder): Helper method to take care of this for
32054 methods, constructors and operators.
32055 (Operator::Define): Completely revamp.
32056 (Operator.OperatorMethod, MethodName): New fields.
32057 (TypeContainer::Populate): Move the registering of builders into
32058 RegisterMethodBuilder.
32059 (Operator::Emit): Re-write.
32061 * expression.cs (Binary::Emit): Comment out code path to emit method
32062 invocation stuff for the case when we have a user defined operator. I am
32063 just not able to get it right !
32065 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32067 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32070 (Expression::MemberLookup): Provide a version that allows to
32071 specify the MemberTypes and BindingFlags.
32073 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32074 so it was not fetching variable information from outer blocks.
32076 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32077 Beforefieldinit as it was buggy.
32079 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32080 that Ravi put here.
32082 * class.cs (Constructor::Emit): Only emit if block is not null.
32083 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32084 deal with this by semantically definining it as if the user had
32087 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32088 constructors as we now "emit" them at a higher level.
32090 (TypeContainer::DefineDefaultConstructor): Used to define the
32091 default constructors if none was provided.
32093 (ConstructorInitializer): Add methods Resolve and Emit.
32095 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32097 2001-09-17 Ravi Pratap <ravi@ximian.com>
32099 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32100 the default constructor builder with our hashtable for methodbuilders
32103 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32104 and argument_count is 0 in which case we have a match.
32105 (Binary::ResolveOperator): More null checking and miscellaneous coding
32108 2001-09-17 Ravi Pratap <ravi@ximian.com>
32110 * rootcontext.cs (IsNameSpace): Compare against null.
32112 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32114 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32115 and Unary::Operator.
32117 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32120 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32121 we have overloaded operators.
32122 (Binary::ResolveOperator): Implement the part which does the operator overload
32125 * class.cs (Operator::Emit): Implement.
32126 (TypeContainer::Emit): Emit the operators we have too.
32128 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32129 the case when we have a user-defined operator.
32131 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32133 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32135 2001-09-16 Ravi Pratap <ravi@ximian.com>
32137 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32138 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32139 (Constructor::Emit): Implement.
32140 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32141 if we have no work to do.
32142 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32145 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32146 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32148 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32151 2001-09-15 Ravi Pratap <ravi@ximian.com>
32153 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32155 (Tree::RecordNamespace): Method to do what the name says ;-)
32156 (Tree::Namespaces): Property to get at the namespaces hashtable.
32158 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32161 * rootcontext.cs (IsNamespace): Fixed it :-)
32163 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32165 * class.cs (TypeContainer::FindMembers): Add support for
32167 (MethodCore): New class that encapsulates both the shared aspects
32168 of a Constructor and a Method.
32169 (Method, Constructor): Factored pieces into MethodCore.
32171 * driver.cs: Added --fatal which makes errors throw exceptions.
32172 Load System assembly as well as part of the standard library.
32174 * report.cs: Allow throwing exceptions on errors for debugging.
32176 * modifiers.cs: Do not use `parent', instead use the real type
32177 container to evaluate permission settings.
32179 * class.cs: Put Ravi's patch back in. He is right, and we will
32180 have to cope with the
32182 2001-09-14 Ravi Pratap <ravi@ximian.com>
32184 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32185 FamORAssem, not FamANDAssem.
32187 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32189 * driver.cs: Added --parse option that only parses its input files
32192 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32193 incorrect. IsTopLevel is not used to tell whether an object is
32194 root_types or not (that can be achieved by testing this ==
32195 root_types). But to see if this is a top-level *class* (not
32196 necessarly our "toplevel" container).
32198 2001-09-14 Ravi Pratap <ravi@ximian.com>
32200 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32201 parent instead of a direct call to GetType.
32203 2001-09-14 Ravi Pratap <ravi@ximian.com>
32205 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32206 Modifiers.TypeAttr. This should just be a call to that method.
32208 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32209 object so that we can determine if we are top-level or not.
32211 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32214 * enum.cs (Enum::Define): Ditto.
32216 * modifiers.cs (FieldAttr): Re-write.
32218 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32219 (TypeContainer::HaveStaticConstructor): New property to provide access
32220 to precisely that info.
32222 * modifiers.cs (MethodAttr): Re-write.
32223 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32225 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32226 of top-level types as claimed.
32228 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32230 * expression.cs (MemberLookup): Fruitless attempt to lookup
32231 constructors. Maybe I need to emit default constructors? That
32232 might be it (currently .NET emits this for me automatically).
32233 (Invocation::OverloadResolve): Cope with Arguments == null.
32234 (Invocation::EmitArguments): new function, shared by the new
32235 constructor and us.
32236 (Invocation::Emit): Handle static and instance methods. Emit
32237 proper call instruction for virtual or non-virtual invocations.
32238 (New::Emit): Implement.
32239 (New::Resolve): Implement.
32240 (MemberAccess:Resolve): Implement.
32241 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32242 to track instances.
32243 (FieldExpr::Resolve): Set type.
32245 * support.cs: Handle empty arguments.
32247 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32248 SimpleLookup): Auxiliary routines to help parse a qualifier
32251 Update qualifier_identifier rule.
32253 * codegen.cs: Removed debugging messages.
32255 * class.cs: Make this a global thing, this acts just as a "key" to
32256 objects that we might have around.
32258 (Populate): Only initialize method_builders_to_methods once.
32260 * expression.cs (PropertyExpr): Initialize type from the
32263 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32264 Resolve pattern. Attempt to implicitly convert value to boolean.
32267 * expression.cs: Set the type for the int32/int32 argument case.
32268 (Binary::ResolveOperator): Set the return type to boolean for
32269 comparission operators
32271 * typemanager.cs: Remove debugging print code.
32273 (Invocation::Resolve): resolve type.
32275 * class.cs: Allocate a MemberInfo of the correct size, as the code
32276 elsewhere depends on the test to reflect the correct contents.
32278 (Method::) Keep track of parameters, due to System.Reflection holes
32280 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32283 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32284 of the exact size and return that.
32286 (Class::LookupMethodByBuilder): New function that maps
32287 MethodBuilders to its methods. Required to locate the information
32288 on methods because System.Reflection bit us again.
32290 * support.cs: New file, contains an interface ParameterData and
32291 two implementations: ReflectionParameters and InternalParameters
32292 used to access Parameter information. We will need to grow this
32295 * expression.cs (Invocation::GetParameterData): implement a cache
32296 and a wrapper around the ParameterData creation for methods.
32297 (Invocation::OverloadResolve): Use new code.
32299 2001-09-13 Ravi Pratap <ravi@ximian.com>
32301 * class.cs (TypeContainer::EmitField): Remove and move into
32302 (Field::Define): here and modify accordingly.
32303 (Field.FieldBuilder): New member.
32304 (TypeContainer::Populate): Update accordingly.
32305 (TypeContainer::FindMembers): Implement.
32307 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32309 * statement.cs: (VariableInfo::VariableType): New field to be
32310 initialized with the full type once it is resolved.
32312 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32314 * parameter.cs (GetParameterInfo): Use a type cache to compute
32315 things only once, and to reuse this information
32317 * expression.cs (LocalVariableReference::Emit): Implement.
32318 (OpcodeCast::Emit): fix.
32320 (ParameterReference::Resolve): Implement.
32321 (ParameterReference::Emit): Implement.
32323 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32324 that are expressions need to stay as Expressions.
32326 * typemanager.cs (CSharpName): Returns the C# name of a type if
32329 * expression.cs (Expression::ConvertImplicit): New function that
32330 implements implicit type conversions.
32332 (Expression::ImplicitReferenceConversion): Implements implicit
32333 reference conversions.
32335 (EmptyCast): New type for transparent casts.
32337 (OpcodeCast): New type for casts of types that are performed with
32338 a sequence of bytecodes.
32340 (BoxedCast): New type used for casting value types into reference
32341 types. Emits a box opcode.
32343 (Binary::DoNumericPromotions): Implements numeric promotions of
32344 and computation of the Binary::Type.
32346 (Binary::EmitBranchable): Optimization.
32348 (Binary::Emit): Implement code emission for expressions.
32350 * typemanager.cs (TypeManager): Added two new core types: sbyte
32353 2001-09-12 Ravi Pratap <ravi@ximian.com>
32355 * class.cs (TypeContainer::FindMembers): Method which does exactly
32356 what Type.FindMembers does, only we don't have to use reflection. No
32357 implementation yet.
32359 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32360 typecontainer objects as we need to get at them.
32361 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32363 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32364 typecontainer object.
32366 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32367 of just a Report object.
32369 2001-09-11 Ravi Pratap <ravi@ximian.com>
32371 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32373 (TypeContainer::Populate): Now define the delegates of the type too.
32374 (TypeContainer.Delegates): Property to access the list of delegates defined
32377 * delegates.cs (Delegate::Define): Implement partially.
32379 * modifiers.cs (TypeAttr): Handle more flags.
32381 2001-09-11 Ravi Pratap <ravi@ximian.com>
32383 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32385 (Operator::Define): Re-write logic to get types by using the LookupType method
32386 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32387 (Indexer::Define): Ditto.
32388 (Event::Define): Ditto.
32389 (Property::Define): Ditto.
32391 2001-09-10 Ravi Pratap <ravi@ximian.com>
32393 * class.cs (TypeContainer::Populate): Now define operators too.
32394 (TypeContainer.Operators): New property to access the list of operators
32396 (Operator.OperatorMethodBuilder): New member to hold the method builder
32397 for the operator we are defining.
32398 (Operator::Define): Implement.
32400 2001-09-10 Ravi Pratap <ravi@ximian.com>
32402 * class.cs (Event::Define): Make the prefixes of the accessor methods
32403 addOn_ and removeOn_
32405 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32406 of the location being passed in too. Ideally, this should go later since all
32407 error reporting should be done through the Report object.
32409 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32410 (Populate): Iterate thru the indexers we have and define them too.
32411 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32412 for the get and set accessors.
32413 (Indexer::Define): Implement.
32415 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32417 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32418 my previous implementation, did not work.
32420 * typemanager.cs: Add a couple of missing types (the longs).
32422 * literal.cs: Use TypeManager.bool_type instead of getting it.
32424 * expression.cs (EventExpr): New kind of expressions.
32425 (Expressio::ExprClassFromMemberInfo): finish
32427 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32429 * assign.cs: Emit stores to static fields differently.
32431 2001-09-08 Ravi Pratap <ravi@ximian.com>
32433 * Merge in changes and adjust code to tackle conflicts. Backed out my
32434 code in Assign::Resolve ;-)
32436 2001-09-08 Ravi Pratap <ravi@ximian.com>
32438 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32439 instead Report.Error and also pass in the location.
32440 (CSharpParser::Lexer): New readonly property to return the reference
32441 to the Tokenizer object.
32442 (declare_local_variables): Use Report.Error with location instead of plain
32446 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32447 (Operator.CheckBinaryOperator): Ditto.
32449 * cs-parser.jay (operator_declarator): Update accordingly.
32451 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32452 (CheckBinaryOperator): Same here.
32454 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32455 on the name without any prefixes of namespace names etc. This is because we
32456 already might have something already fully qualified like
32457 'System.Console.WriteLine'
32459 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32461 2001-09-07 Ravi Pratap <ravi@ximian.com>
32463 * cs-tokenizer.cs (location): Return a string which also contains
32466 * expression.cs (ElementAccess): New class for expressions of the
32467 type 'element access.'
32468 (BaseAccess): New class for expressions of the type 'base access.'
32469 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32472 * cs-parser.jay (element_access): Implement action.
32473 (base_access): Implement actions.
32474 (checked_expression, unchecked_expression): Implement.
32476 * cs-parser.jay (local_variable_type): Correct and implement.
32477 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32479 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32481 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32482 name and the specifiers.
32484 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32486 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32487 making them all public ;-)
32489 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32492 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32494 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32496 (FieldExpr, PropertyExprs): New resolved expressions.
32497 (SimpleName::MemberStaticCheck): Perform static checks for access
32498 to non-static fields on static methods. Maybe this should be
32499 generalized for MemberAccesses.
32500 (SimpleName::ResolveSimpleName): More work on simple name
32503 * cs-parser.jay (primary_expression/qualified_identifier): track
32504 the parameter index.
32506 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32507 (EmitContext::EmitBoolExpression): Chain to expression generation
32508 instead of temporary hack.
32509 (::EmitStatementExpression): Put generic expression code generation.
32511 * assign.cs (Assign::Emit): Implement variable assignments to
32512 local variables, parameters and fields.
32514 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32516 * statement.cs (Block::GetVariableInfo): New method, returns the
32517 VariableInfo for a variable name in a block.
32518 (Block::GetVariableType): Implement in terms of GetVariableInfo
32520 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32521 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32523 2001-09-06 Ravi Pratap <ravi@ximian.com>
32525 * cs-parser.jay (operator_declaration): Continue on my quest : update
32526 to take attributes argument.
32527 (event_declaration): Ditto.
32528 (enum_declaration): Ditto.
32529 (indexer_declaration): Ditto.
32531 * class.cs (Operator::Operator): Update constructor accordingly.
32532 (Event::Event): Ditto.
32534 * delegate.cs (Delegate::Delegate): Same here.
32536 * enum.cs (Enum::Enum): Same here.
32538 2001-09-05 Ravi Pratap <ravi@ximian.com>
32540 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32542 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32544 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32545 being passed around as an arraylist.
32546 (Attributes::AddAttribute): Method to add attribute sections.
32548 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32549 (struct_declaration): Update accordingly.
32550 (constant_declaration): Update.
32551 (field_declaration): Update.
32552 (method_header): Update.
32553 (fixed_parameter): Update.
32554 (parameter_array): Ditto.
32555 (property_declaration): Ditto.
32556 (destructor_declaration): Ditto.
32558 * class.cs (Struct::Struct): Update constructors accordingly.
32559 (Class::Class): Ditto.
32560 (Field::Field): Ditto.
32561 (Method::Method): Ditto.
32562 (Property::Property): Ditto.
32563 (TypeContainer::OptAttribute): update property's return type.
32565 * interface.cs (Interface.opt_attributes): New member.
32566 (Interface::Interface): Update to take the extra Attributes argument.
32568 * parameter.cs (Parameter::Parameter): Ditto.
32570 * constant.cs (Constant::Constant): Ditto.
32572 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32573 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32574 the attributes as a parameter.
32575 (InterfaceProperty): Update constructor call.
32576 (InterfaceEvent): Ditto.
32577 (InterfaceMethod): Ditto.
32578 (InterfaceIndexer): Ditto.
32580 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32581 pass the attributes too.
32582 (interface_event_declaration): Ditto.
32583 (interface_property_declaration): Ditto.
32584 (interface_method_declaration): Ditto.
32585 (interface_declaration): Ditto.
32587 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32589 * class.cs (Method::Define): Track the "static Main" definition to
32590 create an entry point.
32592 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32593 EntryPoint if we find it.
32595 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32596 (EmitContext::ig): Make this variable public.
32598 * driver.cs: Make the default output file be the first file name
32599 with the .exe extension.
32601 Detect empty compilations
32603 Handle various kinds of output targets. Handle --target and
32604 rename -t to --dumper.
32606 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32607 methods inherited from Expression return now an Expression. This
32608 will is used during the tree rewriting as we resolve them during
32611 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32612 the spec. Missing entirely is the information about
32613 accessability of elements of it.
32615 (Expression::ExprClassFromMemberInfo): New constructor for
32616 Expressions that creates a fully initialized Expression based on
32617 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32620 (Invocation::Resolve): Begin implementing resolution of invocations.
32622 * literal.cs (StringLiteral): Implement Emit.
32624 2001-09-05 Ravi Pratap <ravi@ximian.com>
32626 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32629 2001-09-04 Ravi Pratap <ravi@ximian.com>
32631 * cs-parser.jay (attribute_arguments): Implement actions.
32632 (attribute): Fix bug in production. Implement action.
32633 (attribute_list): Implement.
32634 (attribute_target): Implement.
32635 (attribute_target_specifier, opt_target_specifier): Implement
32636 (CheckAttributeTarget): New method to check if the attribute target
32638 (attribute_section): Implement.
32639 (opt_attributes): Implement.
32641 * attribute.cs : New file to handle attributes.
32642 (Attribute): Class to hold attribute info.
32644 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32645 (attribute_section): Modify production to use 2 different rules to
32646 achieve the same thing. 1 s/r conflict down !
32647 Clean out commented, useless, non-reducing dimension_separator rules.
32649 * class.cs (TypeContainer.attributes): New member to hold list
32650 of attributes for a type.
32651 (Struct::Struct): Modify to take one more argument, the attribute list.
32652 (Class::Class): Ditto.
32653 (Field::Field): Ditto.
32654 (Method::Method): Ditto.
32655 (Property::Property): Ditto.
32657 * cs-parser.jay (struct_declaration): Update constructor call to
32658 pass in the attributes too.
32659 (class_declaration): Ditto.
32660 (constant_declaration): Ditto.
32661 (field_declaration): Ditto.
32662 (method_header): Ditto.
32663 (fixed_parameter): Ditto.
32664 (parameter_array): Ditto.
32665 (property_declaration): Ditto.
32667 * constant.cs (Constant::Constant): Update constructor similarly.
32668 Use System.Collections.
32670 * parameter.cs (Parameter::Parameter): Update as above.
32672 2001-09-02 Ravi Pratap <ravi@ximian.com>
32674 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32675 (TypeContainer.delegates): New member to hold list of delegates.
32677 * cs-parser.jay (delegate_declaration): Implement the action correctly
32678 this time as I seem to be on crack ;-)
32680 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32682 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32683 tell whether an identifier represents a namespace.
32685 * expression.cs (NamespaceExpr): A namespace expression, used only
32686 temporarly during expression resolution.
32687 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32688 utility functions to resolve names on expressions.
32690 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32692 * codegen.cs: Add hook for StatementExpressions.
32694 * class.cs: Fix inverted test for static flag in methods.
32696 2001-09-02 Ravi Pratap <ravi@ximian.com>
32698 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32699 to make it coincide with MS' number.
32700 (Operator::CheckBinaryOperator): Ditto.
32702 * ../errors/errors.txt : Remove error numbers added earlier.
32704 * ../errors/cs1019.cs : Test case for error # 1019
32706 * ../errros/cs1020.cs : Test case for error # 1020
32708 * cs-parser.jay : Clean out commented cruft.
32709 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32710 used anywhere - non-reducing rule.
32711 (namespace_declarations): Non-reducing rule - comment out.
32713 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32714 with TypeContainer::AddEnum.
32716 * delegate.cs : New file for delegate handling classes.
32717 (Delegate): Class for declaring delegates.
32719 * makefile : Update.
32721 * cs-parser.jay (delegate_declaration): Implement.
32723 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
32725 * class.cs (Event::Define): Implement.
32726 (Event.EventBuilder): New member.
32728 * class.cs (TypeContainer::Populate): Update to define all enums and events
32730 (Events): New property for the events arraylist we hold. Shouldn't we move to using
32731 readonly fields for all these cases ?
32733 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32735 * class.cs (Property): Revamp to use the convention of making fields readonly.
32736 Accordingly modify code elsewhere.
32738 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
32739 the Define method of the Property class.
32741 * class.cs : Clean up applied patch and update references to variables etc. Fix
32743 (TypeContainer::Populate): Update to define all the properties we have. Also
32744 define all enumerations.
32746 * enum.cs (Define): Implement.
32748 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32750 * cs-parser.jay (overloadable_operator): The semantic value is an
32751 enum of the Operator class.
32752 (operator_declarator): Implement actions.
32753 (operator_declaration): Implement.
32755 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
32756 validity of definitions.
32757 (Operator::CheckBinaryOperator): Static method to check for binary operators
32758 (TypeContainer::AddOperator): New method to add an operator to a type.
32760 * cs-parser.jay (indexer_declaration): Added line to actually call the
32761 AddIndexer method so it gets added ;-)
32763 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
32764 already taken care of by the MS compiler ?
32766 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32768 * class.cs (Operator): New class for operator declarations.
32769 (Operator::OpType): Enum for the various operators.
32771 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32773 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
32774 ostensibly handle this in semantic analysis.
32776 * cs-parser.jay (general_catch_clause): Comment out
32777 (specific_catch_clauses, specific_catch_clause): Ditto.
32778 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
32779 (catch_args, opt_catch_args): New productions.
32780 (catch_clause): Rewrite to use the new productions above
32781 (catch_clauses): Modify accordingly.
32782 (opt_catch_clauses): New production to use in try_statement
32783 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
32784 and re-write the code in the actions to extract the specific and
32785 general catch clauses by being a little smart ;-)
32787 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
32788 Hooray, try and catch statements parse fine !
32790 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32792 * statement.cs (Block::GetVariableType): Fix logic to extract the type
32793 string from the hashtable of variables.
32795 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
32796 I end up making that mistake ;-)
32797 (catch_clauses): Fixed gross error which made Key and Value of the
32798 DictionaryEntry the same : $1 !!
32800 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32802 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
32804 * cs-parser.jay (event_declaration): Correct to remove the semicolon
32805 when the add and remove accessors are specified.
32807 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32809 * cs-parser.jay (IndexerDeclaration): New helper class to hold
32810 information about indexer_declarator.
32811 (indexer_declarator): Implement actions.
32812 (parsing_indexer): New local boolean used to keep track of whether
32813 we are parsing indexers or properties. This is necessary because
32814 implicit_parameters come into picture even for the get accessor in the
32815 case of an indexer.
32816 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
32818 * class.cs (Indexer): New class for indexer declarations.
32819 (TypeContainer::AddIndexer): New method to add an indexer to a type.
32820 (TypeContainer::indexers): New member to hold list of indexers for the
32823 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32825 * cs-parser.jay (add_accessor_declaration): Implement action.
32826 (remove_accessor_declaration): Implement action.
32827 (event_accessors_declaration): Implement
32828 (variable_declarators): swap statements for first rule - trivial.
32830 * class.cs (Event): New class to hold information about event
32832 (TypeContainer::AddEvent): New method to add an event to a type
32833 (TypeContainer::events): New member to hold list of events.
32835 * cs-parser.jay (event_declaration): Implement actions.
32837 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32839 * cs-parser.jay (dim_separators): Implement. Make it a string
32840 concatenating all the commas together, just as they appear.
32841 (opt_dim_separators): Modify accordingly
32842 (rank_specifiers): Update accordingly. Basically do the same
32843 thing - instead, collect the brackets here.
32844 (opt_rank_sepcifiers): Modify accordingly.
32845 (array_type): Modify to actually return the complete type string
32846 instead of ignoring the rank_specifiers.
32847 (expression_list): Implement to collect the expressions
32848 (variable_initializer): Implement. We make it a list of expressions
32849 essentially so that we can handle the array_initializer case neatly too.
32850 (variable_initializer_list): Implement.
32851 (array_initializer): Make it a list of variable_initializers
32852 (opt_array_initializer): Modify accordingly.
32854 * expression.cs (New::NType): Add enumeration to help us
32855 keep track of whether we have an object/delegate creation
32856 or an array creation.
32857 (New:NewType, New::Rank, New::Indices, New::Initializers): New
32858 members to hold data about array creation.
32859 (New:New): Modify to update NewType
32860 (New:New): New Overloaded contructor for the array creation
32863 * cs-parser.jay (array_creation_expression): Implement to call
32864 the overloaded New constructor.
32866 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
32868 * class.cs (TypeContainer::Constructors): Return member
32869 constructors instead of returning null.
32871 2001-08-26 Miguel de Icaza <miguel@ximian.com>
32873 * typemanager.cs (InitCoreTypes): Initialize the various core
32874 types after we have populated the type manager with the user
32875 defined types (this distinction will be important later while
32876 compiling corlib.dll)
32878 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
32879 on Expression Classification. Now all expressions have a method
32880 `Resolve' and a method `Emit'.
32882 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
32883 generation from working. Also add some temporary debugging
32886 2001-08-24 Miguel de Icaza <miguel@ximian.com>
32888 * codegen.cs: Lots of code generation pieces. This is only the
32889 beginning, will continue tomorrow with more touches of polish. We
32890 handle the fundamentals of if, while, do, for, return. Others are
32891 trickier and I need to start working on invocations soon.
32893 * gen-treedump.cs: Bug fix, use s.Increment here instead of
32896 * codegen.cs (EmitContext): New struct, used during code
32897 emission to keep a context. Most of the code generation will be
32900 * cs-parser.jay: Add embedded blocks to the list of statements of
32901 this block. So code generation proceeds in a top down fashion.
32903 2001-08-23 Miguel de Icaza <miguel@ximian.com>
32905 * statement.cs: Add support for multiple child blocks.
32907 2001-08-22 Miguel de Icaza <miguel@ximian.com>
32909 * codegen.cs (EmitCode): New function, will emit the code for a
32910 Block of code given a TypeContainer and its ILGenerator.
32912 * statement.cs (Block): Standard public readonly optimization.
32913 (Block::Block constructors): Link children.
32914 (Block::Child): Child Linker.
32915 (Block::EmitVariables): Emits IL variable declarations.
32917 * class.cs: Drop support for MethodGroups here, delay until
32919 (Method::): Applied the same simplification that I did before, and
32920 move from Properties to public readonly fields.
32921 (Method::ParameterTypes): Returns the parameter types for the
32922 function, and implements a cache that will be useful later when I
32923 do error checking and the semantic analysis on the methods is
32925 (Constructor::GetCallingConvention): Renamed from CallingConvetion
32926 and made a method, optional argument tells whether this is a class
32927 or a structure to apply the `has-this' bit.
32928 (Method::GetCallingConvention): Implement, returns the calling
32930 (Method::Define): Defines the type, a second pass is performed
32931 later to populate the methods.
32933 (Constructor::ParameterTypes): implement a cache similar to the
32934 one on Method::ParameterTypes, useful later when we do semantic
32937 (TypeContainer::EmitMethod): New method. Emits methods.
32939 * expression.cs: Removed MethodGroup class from here.
32941 * parameter.cs (Parameters::GetCallingConvention): new method.
32943 2001-08-21 Miguel de Icaza <miguel@ximian.com>
32945 * class.cs (TypeContainer::Populate): Drop RootContext from the
32948 (Constructor::CallingConvention): Returns the calling convention.
32949 (Constructor::ParameterTypes): Returns the constructor parameter
32952 (TypeContainer::AddConstructor): Keep track of default constructor
32953 and the default static constructor.
32955 (Constructor::) Another class that starts using `public readonly'
32956 instead of properties.
32958 (Constructor::IsDefault): Whether this is a default constructor.
32960 (Field::) use readonly public fields instead of properties also.
32962 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
32963 track of static constructors; If none is used, turn on
32964 BeforeFieldInit in the TypeAttributes.
32966 * cs-parser.jay (opt_argument_list): now the return can be null
32967 for the cases where there are no arguments.
32969 (constructor_declarator): If there is no implicit `base' or
32970 `this', then invoke the default parent constructor.
32972 * modifiers.cs (MethodAttr): New static function maps a set of
32973 modifiers flags into a MethodAttributes enum
32974 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
32975 MethodAttr, TypeAttr to represent the various mappings where the
32976 modifiers are used.
32977 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
32979 2001-08-19 Miguel de Icaza <miguel@ximian.com>
32981 * parameter.cs (GetParameterInfo): Fix bug where there would be no
32984 * interface.cs (PopulateIndexer): Implemented the code generator
32985 for interface indexers.
32987 2001-08-17 Miguel de Icaza <miguel@ximian.com>
32989 * interface.cs (InterfaceMemberBase): Now we track the new status
32992 (PopulateProperty): Implement property population. Woohoo! Got
32993 Methods and Properties going today.
32995 Removed all the properties for interfaces, and replaced them with
32996 `public readonly' fields.
32998 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33000 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33001 initialize their hashtables/arraylists only when they are needed
33002 instead of doing this always.
33004 * parameter.cs: Handle refs and out parameters.
33006 * cs-parser.jay: Use an ArrayList to construct the arguments
33007 instead of the ParameterCollection, and then cast that to a
33010 * parameter.cs: Drop the use of ParameterCollection and use
33011 instead arrays of Parameters.
33013 (GetParameterInfo): Use the Type, not the Name when resolving
33016 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33018 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33019 and instead use public readonly fields.
33021 * class.cs: Put back walking code for type containers.
33023 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33025 * class.cs (MakeConstant): Code to define constants.
33027 * rootcontext.cs (LookupType): New function. Used to locate types
33030 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33032 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33033 this System.Reflection code is. Kudos to Microsoft
33035 * typemanager.cs: Implement a type cache and avoid loading all
33036 types at boot time. Wrap in LookupType the internals. This made
33037 the compiler so much faster. Wow. I rule!
33039 * driver.cs: Make sure we always load mscorlib first (for
33040 debugging purposes, nothing really important).
33042 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33043 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33045 * rootcontext.cs: Lookup types on their namespace; Lookup types
33046 on namespaces that have been imported using the `using' keyword.
33048 * class.cs (TypeContainer::TypeAttr): Virtualize.
33049 (Class::TypeAttr): Return attributes suitable for this bad boy.
33050 (Struct::TypeAttr): ditto.
33051 Handle nested classes.
33052 (TypeContainer::) Remove all the type visiting code, it is now
33053 replaced with the rootcontext.cs code
33055 * rootcontext.cs (GetClassBases): Added support for structs.
33057 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33059 * interface.cs, statement.cs, class.cs, parameter.cs,
33060 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33061 Drop use of TypeRefs, and use strings instead.
33063 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33067 * class.cs (Struct::Struct): set the SEALED flags after
33068 checking the modifiers.
33069 (TypeContainer::TypeAttr): new property, returns the
33070 TypeAttributes for a class.
33072 * cs-parser.jay (type_list): Oops, list production was creating a
33073 new list of base types.
33075 * rootcontext.cs (StdLib): New property.
33076 (GetInterfaceTypeByName): returns an interface by type name, and
33077 encapsulates error handling here.
33078 (GetInterfaces): simplified.
33079 (ResolveTree): Encapsulated all the tree resolution here.
33080 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33083 * driver.cs: Add support for --nostdlib, to avoid loading the
33084 default assemblies.
33085 (Main): Do not put tree resolution here.
33087 * rootcontext.cs: Beginning of the class resolution.
33089 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33091 * rootcontext.cs: Provide better error reporting.
33093 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33095 * rootcontext.cs (CreateInterface): Handle the case where there
33096 are no parent interfaces.
33098 (CloseTypes): Routine to flush types at the end.
33099 (CreateInterface): Track types.
33100 (GetInterfaces): Returns an array of Types from the list of
33101 defined interfaces.
33103 * typemanager.c (AddUserType): Mechanism to track user types (puts
33104 the type on the global type hash, and allows us to close it at the
33107 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33109 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33110 RecordInterface instead.
33112 * cs-parser.jay: Updated to reflect changes above.
33114 * decl.cs (Definition): Keep track of the TypeBuilder type that
33115 represents this type here. Not sure we will use it in the long
33116 run, but wont hurt for now.
33118 * driver.cs: Smaller changes to accomodate the new code.
33120 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33123 * rootcontext.cs (CreateInterface): New method, used to create
33124 the System.TypeBuilder type for interfaces.
33125 (ResolveInterfaces): new entry point to resolve the interface
33127 (CodeGen): Property, used to keep track of the code generator.
33129 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33131 * cs-parser.jay: Add a second production for delegate_declaration
33134 (enum_body): Put an opt_comma here instead of putting it on
33135 enum_body or enum_member_declarations so we can handle trailing
33136 commas on enumeration members. Gets rid of a shift/reduce.
33138 (type_list): Need a COMMA in the middle.
33140 (indexer_declaration): Tell tokenizer to recognize get/set
33142 * Remove old targets.
33144 * Re-add the parser target.
33146 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33148 * cs-parser.jay: Add precendence rules for a number of operators
33149 ot reduce the number of shift/reduce conflicts in the grammar.
33151 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33153 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33156 Get rid of old crufty code.
33158 * rootcontext.cs: Use this to keep track of the parsed
33159 representation and the defined types available to the program.
33161 * gen-treedump.cs: adjust for new convention.
33163 * type.cs: Split out the type manager, and the assembly builder
33166 * typemanager.cs: the type manager will live here now.
33168 * cil-codegen.cs: And the code generator here.
33170 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33172 * makefile: Fixed up for easy making.
33174 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33176 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33179 (unary_expression): Expand pre_increment_expression and
33180 post_decrement_expression to reduce a shift/reduce.
33182 2001-07-11 Simon Cozens
33184 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33186 Improve allow_keyword_as_indent name.
33188 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33190 * Adjustments for Beta2.
33192 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33194 * decl.cs: Added `Define' abstract method.
33195 (InTransit): new property, used to catch recursive definitions.
33197 * interface.cs: Implement `Define'.
33199 * modifiers.cs: Map Modifiers.constants to
33200 System.Reflection.TypeAttribute flags.
33202 * class.cs: Keep track of types and user-defined types.
33203 (BuilderInit): New method for creating an assembly
33204 (ResolveType): New function to launch the resolution process, only
33205 used by interfaces for now.
33207 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33208 that are inserted into the name space.
33210 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33212 * ARGH. I have screwed up my tree so many times due to the use of
33213 rsync rather than using CVS. Going to fix this at once.
33215 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33218 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33220 * Experiment successful: Use System.Type rather that our own
33223 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33225 * cs-parser.jay: Removed nsAliases from here.
33227 Use new namespaces, handle `using XXX;'
33229 * namespace.cs: Reimplemented namespace handling, use a recursive
33230 definition of the class. Now we can keep track of using clauses
33231 and catch invalid using clauses.
33233 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33235 * gen-treedump.cs: Adapted for all the renaming.
33237 * expression.cs (Expression): this class now has a Type property
33238 which returns an expression Type.
33240 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33241 `Type', as this has a different meaning now in the base
33243 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33245 * interface.cs, class.cs: Removed from all the sources the
33246 references to signature computation, as we can not do method
33247 signature computation during the parsing time, as we are not
33248 trying to solve at that point distinguishing:
33252 void a (NS.Blah x) {}
33255 Which depending on the context might be valid or not, as we do not
33256 know if Blah is the same thing as NS.Blah at that point.
33258 * Redid everything so the code uses TypeRefs now instead of
33259 Types. TypeRefs are just temporary type placeholders, that need
33260 to be resolved. They initially have a pointer to a string and the
33261 current scope in which they are used. This is used later by the
33262 compiler to resolve the reference to an actual Type.
33264 * DeclSpace is no longer a CIR.Type, and neither are
33265 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33266 are all DeclSpaces, but no Types.
33268 * type.cs (TypeRefManager): This implements the TypeRef manager,
33269 which keeps track of all the types that need to be resolved after
33270 the parsing has finished.
33272 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33274 * ARGH. We are going to have to store `foreach' as a class rather
33275 than resolving it, as we need to verify error 1579 after name
33276 resolution. *OR* we could keep a flag that says `This request to
33277 IEnumerator comes from a foreach statement' which we can then use
33278 to generate the error.
33280 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33282 * class.cs (TypeContainer.AddMethod): we now add methods to the
33283 MethodGroup instead of the method hashtable.
33285 * expression.cs: Add MethodGroup abstraction, which gets us one
33286 step closer to the specification in the way we handle method
33289 * cs-parser.jay (primary_expression): qualified_identifier now
33290 tried to match up an identifier to a local variable reference or
33291 to a parameter reference.
33293 current_local_parameters is now a parser global variable that
33294 points to the current parameters for the block, used during name
33297 (property_declaration): Now creates an implicit `value' argument to
33300 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33302 * parameter.cs: Do not use `param' arguments as part of the
33303 signature, per the spec.
33305 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33307 * decl.cs: Base class for classes, structs and interfaces. This
33308 is the "Declaration Space"
33310 * cs-parser.jay: Use CheckDef for checking declaration errors
33311 instead of having one on each function.
33313 * class.cs: Factor out some code for handling error handling in
33314 accordance to the "Declarations" section in the "Basic Concepts"
33315 chapter in the ECMA C# spec.
33317 * interface.cs: Make all interface member classes derive from
33318 InterfaceMemberBase.
33320 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33322 * Many things: all interfaces are parsed and generated in
33323 gen-treedump. Support for member variables, constructors,
33324 destructors, properties, constants is there.
33326 Beginning of the IL backend, but very little done, just there for
33329 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33331 * cs-parser.jay: Fix labeled statement.
33333 * cs-tokenizer.cs (escape): Escape " and ' always.
33334 ref_line, ref_name: keep track of the line/filename as instructed
33335 by #line by the compiler.
33338 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33340 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33341 to match the values in System.CodeDOM.
33343 Divid renamed to Divide.
33345 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33347 (Statements.set): remove.
33349 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33352 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33353 falseStatements always have valid values.
33355 * cs-parser.jay: Use System.CodeDOM now.