1 2010-04-15 Jb Evain <jbevain@novell.com>
3 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
5 2010-04-12 Marek Safar <marek.safar@gmail.com>
7 * expression.cs, attribute.cs, parameter.cs: More attribute type
10 2010-04-12 Marek Safar <marek.safar@gmail.com>
14 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
15 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
16 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
17 codegen.cs: Add custom attribute encoder to deal with unfinished
18 types and easier corlib bootstrap from its own types.
20 2010-03-26 Marek Safar <marek.safar@gmail.com>
22 * cs-parser.jay: Report invalid constraint types.
24 2010-03-16 Jb Evain <jbevain@novell.com>
26 * Makefile: rename the net_2_1 profile to moonlight.
28 2010-03-11 Marek Safar <marek.safar@gmail.com>
30 * statement.cs, cs-parser.jay: Use correct location for empty
33 2010-03-11 Marek Safar <marek.safar@gmail.com>
35 * cs-parser.jay: Disable Location from expression.
37 * generic.cs: Check constraints for overrides in the parser.
39 2010-03-09 Marek Safar <marek.safar@gmail.com>
41 * cs-parser.jay (GetLocation): Use an expression when available.
43 2010-03-04 Marek Safar <marek.safar@gmail.com>
46 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
48 2010-03-04 Marek Safar <marek.safar@gmail.com>
50 A patch by kornelpal@gmail.com
52 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
53 compiler generated classes sealed by default. Emit and close top
54 level compiler generated classes as well.
56 * support.cs: Use RuntimeHelpers.GetHashCode.
58 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
60 * Makefile: We need to use the internal bootstrapping gmcs for
61 net_2_1_bootstrap too now.
63 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
65 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
67 2010-03-02 Marek Safar <marek.safar@gmail.com>
69 * cs-tokenizer.cs: Missed few locations in previous fix.
71 2010-03-02 Marek Safar <marek.safar@gmail.com>
73 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
74 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
75 Report correct location for operator errors.
77 2010-03-02 Marek Safar <marek.safar@gmail.com>
79 * typemanager.cs (IsDynamicType): Don't check external types when
80 the attribute is not external.
82 2010-02-24 Marek Safar <marek.safar@gmail.com>
85 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
88 2010-02-24 Marek Safar <marek.safar@gmail.com>
91 * ecore.cs: Fixed type comparison.
93 2010-02-08 Miguel de Icaza <miguel@novell.com>
95 * namespace.cs (CompletionGetTypesStartingWith): Do not include
96 private types in the completion results.
98 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
101 2010-02-17 Marek Safar <marek.safar@gmail.com>
103 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
106 2010-02-14 Miguel de Icaza <miguel@novell.com>
108 * eval.cs: Do not do the report printer dance unless the user has
109 set the DescribeTypes feature.
111 2010-02-10 Marek Safar <marek.safar@gmail.com>
113 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
115 2010-02-08 Marek Safar <marek.safar@gmail.com>
117 A fix for bug #577029
118 * anonymous.cs: Fixed TypeBuilder* check.
120 2010-02-06 Miguel de Icaza <miguel@novell.com>
122 * eval.cs (CompileBlock): Also undo if there are problems during
123 semantic analysis, fixes various cases where invalid C# code would
124 be reported, but the internal changes would not be undone.
126 2010-02-03 Miguel de Icaza <miguel@novell.com>
128 * driver.cs: Change the --fatal flag to allow a number to be
129 passed, this ignores the first N fatal errors. Useful to debug
130 errors that do not happen on the first hit.
132 * cs-parser.jay (invocation_expression): accept both the
133 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
134 inside an invocation.
136 * driver.cs: Expose FatalErrors.
138 * eval.cs: Initialize the printer's Fatal property from the
139 Driver's FatalError flag, this allows csharp --fatal to work
142 Add support for calling Describe (typeof (TYPE)) if the expression
145 2010-02-02 Marek Safar <marek.safar@gmail.com>
147 A fix for bug #574991
148 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
151 2010-02-02 Marek Safar <marek.safar@gmail.com>
153 A fix for bug #575986
154 * expression.cs: Don't mutate typeof type definitions.
156 2010-01-28 Marek Safar <marek.safar@gmail.com>
158 * decl.cs: Use only one set of modifiers.
160 2010-01-26 Marek Safar <marek.safar@gmail.com>
162 A fix for bug #573329
163 * eval.cs: Don't disable error reporting completely on silent mode.
165 2010-01-25 Marek Safar <marek.safar@gmail.com>
167 A fix for bug #573312
168 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
169 pointer index of unknown size types greater than 2.
171 2010-01-15 Marek Safar <marek.safar@gmail.com>
173 * *.cs: Use only 1 member kind enum.
175 2010-01-15 Marek Safar <marek.safar@gmail.com>
177 * *.cs: Add event specification.
179 2010-01-14 Marek Safar <marek.safar@gmail.com>
181 * membercache.cs: Extracted from decl.cs.
183 * *.cs: Put more infrastructure in place.
185 2010-01-13 Marek Safar <marek.safar@gmail.com>
187 * *.cs: Add property specification, unused yet.
189 2010-01-13 Marek Safar <marek.safar@gmail.com>
191 * property.cs: Move all property based declarations into a new file.
193 2010-01-13 Marek Safar <marek.safar at gmail.com>
195 * expression.cs (Conditional): Resolve reduced expression.
197 2010-01-13 Marek Safar <marek.safar at gmail.com>
199 * *.cs: Introduced non-generic method specification.
201 2010-01-07 Marek Safar <marek.safar@gmail.com>
203 * method.cs: Move all method based declarations into a new file.
205 2010-01-07 Marek Safar <marek.safar@gmail.com>
207 * *.cs: Extract field specification.
209 2009-12-17 Marek Safar <marek.safar@gmail.com>
211 * field.cs: Extracted from class.cs
213 2009-12-15 Marek Safar <marek.safar@gmail.com>
215 * attribute.cs (GetFixedBuffer): Work on field definition only.
217 2009-12-15 Marek Safar <marek.safar@gmail.com>
219 * *.cs: Clean up NET_4_0 conditional where possible.
221 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
223 support.cs (DynamicType): Assembly property returns the assembly builder.
224 This is required due to how compiler context works in corlib.
226 2009-12-14 Marek Safar <marek.safar@gmail.com>
228 A fix for bug #564376
229 * assign.cs (LocalTemporary): Removed no longer needed special
232 2009-12-11 Marek Safar <marek.safar@gmail.com>
234 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
235 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
236 enum for easier debugging.
238 2009-12-10 Marek Safar <marek.safar@gmail.com>
240 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
243 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
246 2009-12-10 Marek Safar <marek.safar@gmail.com>
248 * cs-parser.jay, statement.cs: Handle parser error in code
251 2009-12-10 Marek Safar <marek.safar@gmail.com>
253 * ecore.cs: Ignore base imported methods when they are already
256 * eval.cs: Handle non-existent keys.
258 * report.cs, driver.cs: Make fatal work with console printer only.
260 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
262 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
264 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
266 * typemanager.cs: Add MakeGenericMethod that checks if the method
267 is really the generic method definition.
269 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
270 to inflate generic methods.
272 2009-12-08 Marek Safar <marek.safar@gmail.com>
274 A fix for bug #561149
275 * anonymous.cs: Use actual type parameters when checking for generic
278 2009-12-08 Marek Safar <marek.safar@gmail.com>
280 A fix for bug #561369
281 * expression.cs (DoNumericPromotion): Fixed typo.
283 2009-12-08 Marek Safar <marek.safar@gmail.com>
285 *.cs: Moving to generics world.
287 cs-parser.jay: Removed current_array_type.
289 2009-12-07 Marek Safar <marek.safar@gmail.com>
291 *.cs: Moving to generics world.
293 2009-12-04 Marek Safar <marek.safar@gmail.com>
295 *.cs: Moving to generics world (day 2).
297 2009-12-03 Marek Safar <marek.safar@gmail.com>
299 *.cs: Moving to generics world.
301 2009-12-02 Marek Safar <marek.safar@gmail.com>
303 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
304 Encode dynamic type attribute for elements where attributes cannot
307 2009-12-01 Marek Safar <marek.safar@gmail.com>
309 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
312 2009-12-01 Marek Safar <marek.safar@gmail.com>
314 A fix for bug #360455
315 * class.cs: Never report a unused warning for generic events to
316 workaround wrong expression type.
318 2009-11-30 Marek Safar <marek.safar@gmail.com>
320 A fix for bug #558305
321 * decl.cs, class.cs: Check partial method definitions using correct
324 2009-11-30 Marek Safar <marek.safar@gmail.com>
326 * argument.cs: Don't cache rarely used dynamic flag.
328 2009-11-27 Marek Safar <marek.safar@gmail.com>
330 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
332 2009-11-27 Marek Safar <marek.safar@gmail.com>
334 * ecore.cs (SimpleName): Removed no longer needed in_transit as
335 Resolve is now non-reentrant (saves ~0.6MB for corlib).
337 2009-11-26 Marek Safar <marek.safar@gmail.com>
339 A fix for bug #545081
340 * decl.cs: Check private nested types of nested types recursively.
342 2009-11-26 Marek Safar <marek.safar@gmail.com>
344 A fix for bug #558305
345 * location.cs: Ignore self referencing #line directive
347 2009-11-26 Marek Safar <marek.safar@gmail.com>
349 A fix for bug #558292
350 * class.cs: Allow single unsafe fixed buffer fields.
352 2009-11-26 Marek Safar <marek.safar@gmail.com>
354 * expression: Optimize few more zero-based operations.
356 2009-11-26 Marek Safar <marek.safar@gmail.com>
358 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
359 avoids boxing of literal values.
361 2009-11-26 Marek Safar <marek.safar@gmail.com>
363 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
364 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
365 codegen.cs: LocatedToken redesing to avoid excessive allocation and
366 boxing (saves ~7MB for corlib). Also fixes presise token location.
368 2009-11-25 Marek Safar <marek.safar@gmail.com>
370 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
373 2009-11-24 Marek Safar <marek.safar@gmail.com>
375 * expression.cs: Lower static array initializer barrier.
377 * support.cs, driver.cs: Share reader buffer.
379 2009-11-23 Marek Safar <marek.safar@gmail.com>
381 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
383 2009-11-23 Marek Safar <marek.safar@gmail.com>
385 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
386 cleanup some obsolete code.
388 2009-11-20 Marek Safar <marek.safar@gmail.com>
390 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
393 2009-11-20 Marek Safar <marek.safar@gmail.com>
395 * *.cs: Resolved expressions are never resolved again, this helps to
396 uncover some not easy to find bugs and improve the performance.
398 2009-11-19 Marek Safar <marek.safar@gmail.com>
400 * *.cs: Made constant expressions fully compatible with any other
403 2009-11-19 Marek Safar <marek.safar@gmail.com>
405 * *.cs: DoResolve is a worker method and has to be protected.
407 2009-11-18 Marek Safar <marek.safar@gmail.com>
409 * *.cs: More context specific handling.
411 2009-11-17 Marek Safar <marek.safar@gmail.com>
413 * *.cs: More context specific handling.
415 2009-11-16 Marek Safar <marek.safar@gmail.com>
417 * dynamic.cs, class.cs: Removed few fixed user types conversions.
419 * symbolwriter.cs: Uses public ILOffset.
421 2009-11-13 Marek Safar <marek.safar@gmail.com>
423 A fix for bug #553650
424 * generic.cs: Another missing TypeToCoreType, still too many to fix.
426 2009-11-13 Marek Safar <marek.safar@gmail.com>
428 A fix for bug #555170
430 * class.cs, delegate.cs, enum.cs: Constants have to be available
431 for parameters resolve.
433 2009-11-12 Marek Safar <marek.safar@gmail.com>
435 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
438 2009-11-12 Marek Safar <marek.safar@gmail.com>
440 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
441 with a statically known candidate set.
443 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
445 * generic.cs: Made type inflation for generic constraint checks
446 recursive. This fixes BGO #553655.
448 2009-11-11 Marek Safar <marek.safar@gmail.com>
450 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
453 2009-11-10 Marek Safar <marek.safar@gmail.com>
455 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
456 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
457 attribute.cs: Add some dynamic error checking.
459 2009-11-07 Marek Safar <marek.safar@gmail.com>
461 A fix for bug #553465
463 * expression.cs: Fixed mixed version of expression tree anonymous
466 2009-11-06 Marek Safar <marek.safar@gmail.com>
468 A fix for bug #553031
470 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
471 expression tree version of anonymous type with members declaration.
473 2009-11-05 Marek Safar <marek.safar@gmail.com>
475 * parameter.cs: Handle nullable parameter default expression.
477 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
478 class.cs, attribute.cs: Check for wrong dynamic arguments.
480 2009-11-05 Marek Safar <marek.safar@gmail.com>
482 * statement.cs: Dynamic statements.
484 2009-11-04 Marek Safar <marek.safar@gmail.com>
486 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
487 Compound assignments over dynamic type.
489 2009-11-03 Marek Safar <marek.safar@gmail.com>
491 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
492 constructor arguments.
494 2009-10-30 Marek Safar <marek.safar@gmail.com>
496 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
497 codegen.cs: Unary mutator on dynamic member access expression.
499 2009-10-29 Marek Safar <marek.safar@gmail.com>
501 A fix for bug #550580
502 * convert.cs: Don't eliminate explicit precission casts.
504 2009-10-28 Marek Safar <marek.safar@gmail.com>
506 A fix for bug #550404
508 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
509 expression.cs, statement.cs, ecore.cs: Quote any nested expression
512 2009-10-27 Marek Safar <marek.safar@gmail.com>
514 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
517 * class.cs: Allow nullable binary user operators.
519 2009-10-26 Marek Safar <marek.safar@gmail.com>
521 * expression.cs: Move binary expression optimization at the end of
524 2009-10-23 Marek Safar <marek.safar@gmail.com>
526 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
527 Separate NullConstant from NullLiteral.
529 2009-10-23 Marek Safar <marek.safar@gmail.com>
531 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
532 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
533 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
534 ModuleContainer. Add common unclosed member check routine.
536 2009-10-22 Marek Safar <marek.safar@gmail.com>
538 * argument.cs: Use literal flag for real literals only.
540 * dynamic.cs: Use correct return type for custom delegates.
542 2009-10-22 Marek Safar <marek.safar@gmail.com>
544 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
547 2009-10-22 Marek Safar <marek.safar@gmail.com>
549 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
551 2009-10-21 Marek Safar <marek.safar@gmail.com>
553 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
556 2009-10-21 Marek Safar <marek.safar@gmail.com>
558 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
561 2009-10-20 Marek Safar <marek.safar@gmail.com>
563 * argument.cs, dynamic.cs, expression.cs: Latest API update.
565 2009-10-19 Marek Safar <marek.safar@gmail.com>
567 * typemanager.cs, expression.cs: Dynamic array initializer.
569 2009-10-16 Marek Safar <marek.safar@gmail.com>
571 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
574 2009-10-16 Marek Safar <marek.safar@gmail.com>
576 A fix for bug #493523, #507067
577 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
578 standard nullable conversion using underlying standard conversion
579 and not full conversion.
581 2009-10-15 Marek Safar <marek.safar@gmail.com>
583 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
584 type in VerifyArgumentsCompat.
586 2009-10-15 Marek Safar <marek.safar@gmail.com>
588 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
589 Reject variable used with type arguments.
591 2009-10-14 Marek Safar <marek.safar@gmail.com>
593 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
594 Implement dynamic expressions assignment.
596 2009-10-14 Marek Safar <marek.safar@gmail.com>
598 * expression.cs: Build underlying expression when resolving unary
601 2009-10-14 Marek Safar <marek.safar@gmail.com>
603 * expression.cs: Emit enum array initializer using binary blob.
605 2009-10-08 Marek Safar <marek.safar@gmail.com>
607 * typemanager.cs, constant.cs: Optimize decimal constants which fit
610 2009-10-07 Marek Safar <marek.safar@gmail.com>
612 * typemanager.cs: Reset object_type.
614 * assign: Made SimpleAssign public.
616 2009-10-06 Marek Safar <marek.safar@gmail.com>
618 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
619 invocation assembly to IsThisOrFriendAssembly.
621 2009-10-05 Marek Safar <marek.safar@gmail.com>
623 * expression.cs: Equality comparison of generic parameter with
626 2009-10-05 Marek Safar <marek.safar@gmail.com>
628 A fix for bug #543570
629 * generic.cs: Import predefined constraints correctly.
631 2009-10-02 Marek Safar <marek.safar@gmail.com>
633 * ecore.cs: Don't crash on overloads with optional paremeters where
634 arguments count overflows.
636 * parameter.cs: Import optional parameter constants using optional
639 2009-10-01 Marek Safar <marek.safar@gmail.com>
641 * Makefile: Default is gmcs compiler.
643 2009-10-01 Marek Safar <marek.safar@gmail.com>
645 * cs-parser.jay: Fixed few NRE.
647 2009-10-01 Marek Safar <marek.safar@gmail.com>
649 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
651 2009-09-30 Marek Safar <marek.safar@gmail.com>
653 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
654 ShimExpression, ImplicitCast.
656 2009-09-30 Marek Safar <marek.safar@gmail.com>
658 A fix for bug #542959
659 * delegate.cs: Emit correct delegate instance variable when there
660 are static and non-static overloads.
662 2009-09-29 Marek Safar <marek.safar@gmail.com>
664 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
665 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
667 2009-09-28 Marek Safar <marek.safar@gmail.com>
669 A fix for bug #542487
670 * ecore.cs: Resolve extension methods hidden by properties.
672 2009-09-25 Marek Safar <marek.safar@gmail.com>
674 * expression.cs, ecore.cs: More dynamic binary expressions.
676 2009-09-22 Marek Safar <marek.safar@gmail.com>
678 * nullable.cs, expression.cs: Fixed null lifted conversion for
679 bitwise enum operations.
681 2009-09-22 Marek Safar <marek.safar@gmail.com>
683 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
684 values in checked context.
686 2009-09-22 Marek Safar <marek.safar@gmail.com>
688 * expression.cs, ecore.cs: Fixed array index constant conversion.
690 2009-09-20 Miguel de Icaza <miguel@novell.com>
692 * expression.cs: Do not crash when MemberLookup returns something
693 that is not a MemberExpr here. Report error 582 instead.
697 2009-09-18 Marek Safar <marek.safar@gmail.com>
699 * decl.cs, class.cs: Check protected property accessors.
701 2009-09-18 Marek Safar <marek.safar@gmail.com>
703 * dynamic.cs, assign.cs: Dynamic compound assignment.
705 2009-09-17 Marek Safar <marek.safar@gmail.com>
707 * expression.cs: Fixed compound assignment explicit conversion.
709 2009-09-17 Marek Safar <marek.safar@gmail.com>
711 * expression.cs, ecore.cs: Cannot infer variables from method group.
713 2009-09-16 Marek Safar <marek.safar@gmail.com>
715 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
716 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
717 codegen.cs: Dynamic binary operations scaffolding.
719 2009-09-15 Marek Safar <marek.safar@gmail.com>
721 * expression.cs: Fixes nullable promotion for enum type variables.
723 2009-09-11 Marek Safar <marek.safar@gmail.com>
725 * driver.cs, dynamic.cs: Reset more static variables.
727 2009-09-11 Marek Safar <marek.safar@gmail.com>
729 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
730 driver.cs: Introduced Expression::MakeExpression.
732 2009-09-11 Marek Safar <marek.safar@gmail.com>
734 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
736 2009-09-09 Marek Safar <marek.safar@gmail.com>
738 * eval.cs, report.cs: Use Console.Out for all eval error or warning
741 2009-09-09 Marek Safar <marek.safar@gmail.com>
743 A fix for bug #518707
744 * expression.cs (Is): Optimize only generic parameter type
745 expression probing value type generic parameter.
747 2009-09-09 Marek Safar <marek.safar@gmail.com>
749 A fix for bug #532571
750 * ecore.cs: Check for simple name type arguments used with
753 2009-09-08 Marek Safar <marek.safar@gmail.com>
755 A fix for bug #497421
756 * generic.cs (CheckConstraint): Don't use buildin types to check for
757 parameterless constructor.
759 2009-09-08 Marek Safar <marek.safar@gmail.com>
761 A fix for bug #537402
762 * generic.cs (CheckConstraint): Correctly inflate generic type
763 arguments when checking generic method.
765 2009-09-08 Marek Safar <marek.safar@gmail.com>
767 A fix for bug #536463
768 * decl.cs (AddToContainer): Don't report collision between explicit
769 and parameterless non-explicit members.
771 2009-09-08 Marek Safar <marek.safar@gmail.com>
773 * eval.cs: Reset more static stuff.
775 2009-09-07 Marek Safar <marek.safar@gmail.com>
777 A fix for bug #324625
778 * expression.cs, ecore.cs: Create nested generic type expression
779 using declaring and not current type.
781 2009-09-07 Marek Safar <marek.safar@gmail.com>
783 * *.cs: Changed Report class to accept various output printers and
784 be an instance class. An expression resolver can now use different
785 message reporter for each call and Report.Error can safely throw
786 an exception. Part of ongoing work to turn mcs into proper library.
788 2009-09-04 Marek Safar <marek.safar@gmail.com>
790 * statement.cs, ecore.cs: Removed error reporting from emit code.
792 2009-09-04 Marek Safar <marek.safar@gmail.com>
794 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
796 2009-09-03 Marek Safar <marek.safar@gmail.com>
798 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
799 parser checks out of constructors.
801 2009-09-02 Marek Safar <marek.safar@gmail.com>
803 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
805 2009-09-02 Marek Safar <marek.safar@gmail.com>
807 A fix for bug #535448
808 * anonymous.cs, class.cs: Copy return label between all contexts.
810 2009-09-02 Marek Safar <marek.safar@gmail.com>
812 A fix for bug #535395
813 * namespace.cs: Resolve context can be null.
815 2009-08-25 Marek Safar <marek.safar@gmail.com>
817 A fix for bug #533912
818 * generic.cs: Use correct context for constraints resolving.
820 2009-08-25 Marek Safar <marek.safar@gmail.com>
822 A fix for bug #532630
823 * driver.cs: Trim conditional symbols.
825 2009-08-25 Marek Safar <marek.safar@gmail.com>
827 * context.cs: New file.
829 * *.exe.sources, *.csproj: Updated.
831 2009-08-25 Marek Safar <marek.safar@gmail.com>
833 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
834 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
835 IMembercontext, some small cleanups.
837 2009-08-24 Marek Safar <marek.safar@gmail.com>
839 * *.cs: Split ResolveContext and EmitContext.
841 2009-08-24 Marek Safar <marek.safar@gmail.com>
843 * *.cs: Only ResolveContext implements IMemberContext.
845 2009-08-21 Marek Safar <marek.safar@gmail.com>
847 * *.cs: Renamed IResolveContext to IMemberContext.
849 2009-08-21 Marek Safar <marek.safar@gmail.com>
851 * *.cs: Detached ResolveContext from EmitContext.
853 2009-08-21 Marek Safar <marek.safar@gmail.com>
855 * codegen.cs: Moved flow-analysis to BlockContext.
857 2009-08-21 Marek Safar <marek.safar@gmail.com>
859 * *.cs: Detached BlockContext from EmitContext.
861 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
863 * statement.cs: avoid nullref when the return value of GetEnumerator()
864 does not contain any MoveNext() method.
866 2009-08-19 Marek Safar <marek.safar@gmail.com>
868 * *.cs: Removed IResolveContext::GenericDeclContainer.
870 2009-08-19 Marek Safar <marek.safar@gmail.com>
872 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
874 2009-08-19 Marek Safar <marek.safar@gmail.com>
876 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
877 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
879 2009-08-18 Marek Safar <marek.safar@gmail.com>
881 * *.cs: Removed boolean fields from EmitContext.
883 2009-08-18 Marek Safar <marek.safar@gmail.com>
885 * *.cs: Add IResolveContext::IsStatic.
887 2009-08-18 Marek Safar <marek.safar@gmail.com>
889 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
891 2009-08-17 Marek Safar <marek.safar@gmail.com>
893 * *.cs: Removed DeclContainer from EmitContext.
895 2009-08-17 Marek Safar <marek.safar@gmail.com>
897 * *.cs: Add IResolveContext::CurrentTypeParameters.
899 2009-08-14 Marek Safar <marek.safar@gmail.com>
901 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
903 2009-08-14 Marek Safar <marek.safar@gmail.com>
905 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
906 codegen.cs: Add IResolveContext::LookupExtensionMethod.
908 2009-08-13 Marek Safar <marek.safar@gmail.com>
910 * decl.cs: Look in PartialContainer for parent type parameters.
912 2009-08-13 Marek Safar <marek.safar@gmail.com>
914 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
915 codegen.cs: Add IResolveContext::LookupTypeParameter.
917 2009-08-13 Marek Safar <marek.safar@gmail.com>
919 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
920 Moved resolved logic from Emit to Resolve.
922 2009-08-13 Marek Safar <marek.safar@gmail.com>
924 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
925 codegen.cs: Reworked atttributes handling of ResolveContext.
927 2009-08-12 Marek Safar <marek.safar@gmail.com>
929 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
930 LookupNamespaceOrType to ResolveContext.
932 2009-08-12 Marek Safar <marek.safar@gmail.com>
934 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
935 class.cs: Removed unused parameters and methods.
937 2009-08-11 Marek Safar <marek.safar@gmail.com>
939 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
940 codegen.cs: Finding the best common type of a set of expressions for
943 2009-08-07 Marek Safar <marek.safar@gmail.com>
945 * dynamic.cs, expression.cs: More dynamic conversions.
947 2009-08-06 Miguel de Icaza <miguel@novell.com>
949 * generic.cs: This loop was incorrect, it was increment ii, but
950 checking for `i'. This was a change introduced to fix #327497,
953 * class.cs: Catch another case for cs0533 error, fixes #324782.
955 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
957 * typemanager.cs (GetGenericArguments): SRE returns null for
958 generic methods on type builder instances if they are not generic
959 themselves. For example, for Foo<int>::Bar() it returns null, but
960 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
962 2009-08-05 Marek Safar <marek.safar@gmail.com>
964 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
965 delegate.cs: Work on dynamic binding.
967 2009-08-04 Marek Safar <marek.safar@gmail.com>
969 A second fix for bug #525342
970 * class.cs: Attach partial method attributes to method
973 2009-08-03 Marek Safar <marek.safar@gmail.com>
975 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
978 * rootcontext.cs: Default to langversion v4.
980 2009-08-03 Marek Safar <marek.safar@gmail.com>
982 * pending.cs: Check return type before member info is set.
984 2009-08-03 Marek Safar <marek.safar@gmail.com>
986 * anonymous.cs: Fully initialize generic hoisted field expression.
988 2009-08-02 Miguel de Icaza <miguel@novell.com>
990 * cs-parser.jay: Flag variables declared on the interactive shell
991 as used to prevent the 168 warning about local variable not being
994 2009-07-31 Marek Safar <marek.safar@gmail.com>
996 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
997 attribute.cs: Emit dynamic export attribute.
999 2009-07-30 Marek Safar <marek.safar@gmail.com>
1001 * expression.cs: More verifier work.
1003 2009-07-29 Marek Safar <marek.safar@gmail.com>
1005 * nullable.cs: Fixed SRE crash during corlib compilation.
1007 2009-07-29 Marek Safar <marek.safar@gmail.com>
1009 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1010 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1011 More TypeManager.TypeToCoreType needed.
1013 2009-07-29 Marek Safar <marek.safar@gmail.com>
1015 * anonymous.cs: Update after recent SRE fixes.
1017 2009-07-28 Marek Safar <marek.safar@gmail.com>
1019 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1020 version of GetFieldHandle for fields of generic types.
1022 2009-07-27 Marek Safar <marek.safar@gmail.com>
1024 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1025 ecore.cs: Add TypeManager.IsDynamicType,
1026 PredefinedAttributes.Dynamic.
1028 2009-07-27 Marek Safar <marek.safar@gmail.com>
1030 A fix for bug #415375
1031 * expression.cs: Fixed object and reference type parameter
1034 2009-07-27 Marek Safar <marek.safar@gmail.com>
1036 A fix for bug #525342
1037 * class.cs: Attach partial method attributes to method
1040 2009-07-24 Marek Safar <marek.safar@gmail.com>
1042 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1045 2009-07-24 Marek Safar <marek.safar@gmail.com>
1047 * anonymous.cs (MutateField): Add imported types handling.
1049 2009-07-23 Marek Safar <marek.safar@gmail.com>
1051 * expression.cs, delegate.cs: Moved arguments resolve into their
1052 counterparts expressions. Removed argument resolve from
1053 CollectionElementInitializer.
1055 2009-07-23 Marek Safar <marek.safar@gmail.com>
1057 A fix for bug #523683
1058 * convert.cs, delegate.cs: Use common overload mechanism for method
1059 group conversion check.
1061 2009-07-22 Marek Safar <marek.safar@gmail.com>
1063 A fix for bug #523899
1064 * generics.cs: Exact type inference with other bound types.
1066 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1068 Don't complain when the same type is implemented by the output
1069 assembly as well as multiple referenced assemblies
1070 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1071 'must_be_unique' flag.
1072 (GlobalRootNamespace): Update to changes.
1073 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1074 already have a type in hand.
1076 2009-07-22 Marek Safar <marek.safar@gmail.com>
1078 * expression.cs: More verifier instrumentation.
1080 * statement.cs: Do proper throw expression conversion.
1082 2009-07-22 Marek Safar <marek.safar@gmail.com>
1084 A fix for bug #522789
1085 * expression.cs: Mutate invocation return type.
1087 2009-07-16 Marek Safar <marek.safar@gmail.com>
1089 * anonymous.cs: Split assignable and readonly generated variable
1092 2009-07-16 Marek Safar <marek.safar@gmail.com>
1094 A fix for bug #521671
1095 * statement.cs: Fixed crash when checking missing type.
1097 2009-07-16 Marek Safar <marek.safar@gmail.com>
1099 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1100 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1101 class.cs, driver.cs: Work on dynamic binding.
1103 * dynamic.cs: New file.
1105 * *.sources, *.proj: Updated.
1107 2009-07-15 Marek Safar <marek.safar@gmail.com>
1109 * expression.cs (Conditional): Avoid double Resolve.
1111 2009-07-13 Marcus Griep <marcus@griep.us>
1113 * ecore.cs: Fix obscure bug with resolving members of interfaces
1114 that hide parent interface members. Fixes bug #444388 and corrects
1117 2009-07-13 Marek Safar <marek.safar@gmail.com>
1119 * expression.cs (LocalVariableReference): Bounce resolve.
1121 2009-07-10 Marek Safar <marek.safar@gmail.com>
1123 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1124 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1127 * support.cs: New dynamic type wrapper.
1129 2009-07-08 Marek Safar <marek.safar@gmail.com>
1131 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1132 typed local variable.
1134 2009-07-06 Marek Safar <marek.safar@gmail.com>
1136 A fix for bug #519005
1137 * anonymous.cs: Use null_type as no return type placeholder.
1139 2009-07-02 Marek Safar <marek.safar@gmail.com>
1141 * generic.cs: Handle type inference of identical type parameters
1142 with different bounds.
1144 2009-07-01 Marek Safar <marek.safar@gmail.com>
1146 * expression.cs, class.cs: Events variance.
1148 * cs-parser.jay: Interface events error messages.
1150 2009-07-01 Marek Safar <marek.safar@gmail.com>
1152 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1154 2009-06-29 Marek Safar <marek.safar@gmail.com>
1156 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1157 parameter expression can be value-type New.
1159 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1161 2009-06-26 Marek Safar <marek.safar@gmail.com>
1163 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1164 Implemented C# 4.0 named arguments.
1166 2009-06-24 Marek Safar <marek.safar@gmail.com>
1168 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1169 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1170 parameter modifier. Also fixes bug #515497.
1172 2009-06-24 Marek Safar <marek.safar@gmail.com>
1174 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1175 arguments expression to be implemented.
1177 *.sources: Add argument.cs
1179 2009-06-23 Marek Safar <marek.safar@gmail.com>
1181 * parameter.cs: Moved GetParameterIndexByName to base class.
1183 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1184 unused AType. Use argument's version of GetExpressionTree.
1186 2009-06-22 Marek Safar <marek.safar@gmail.com>
1188 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1191 2009-06-17 Marek Safar <marek.safar@gmail.com>
1193 A fix for bug #514096
1194 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1196 2009-06-17 Marek Safar <marek.safar@gmail.com>
1198 * expression.cs: The first multi-dimensional array nested array
1199 initializers was not checked.
1201 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1203 2009-06-17 Marek Safar <marek.safar@gmail.com>
1205 A fix for bug #513400
1206 * nullable.cs (EmitEquality): Operands emit could be simplified for
1207 built-in types when we now emit user operators differently.
1209 2009-06-16 Marek Safar <marek.safar@gmail.com>
1211 * ecore.cs: Report inaccessible delegate methods correctly.
1213 2009-06-16 Marek Safar <marek.safar@gmail.com>
1215 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1216 cs-parser.jay: Implemented C# 4.0 optional parameters.
1218 2009-06-16 Marek Safar <marek.safar@gmail.com>
1220 * driver.cs: Removed broken DefineManifestResource.
1222 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1224 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1225 Use $(BOOTSTRAP_PROFILE) instead.
1227 2009-06-12 Jb Evain <jbevain@novell.com>
1229 * rootcontext.cs: add a Platform field.
1230 * driver.cs: handle /platform.
1231 * codegen.cs: pass the proper flags according to
1232 the platform when saving the assembly.
1234 2009-06-11 Marek Safar <marek.safar@gmail.com>
1236 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1237 Add optional parameters grammar.
1239 2009-06-10 Marek Safar <marek.safar@gmail.com>
1241 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1242 driver.cs: Split lang version and metadata version.
1244 2009-06-10 Marek Safar <marek.safar@gmail.com>
1246 * decl.cs: Better overload ctor collision error message.
1248 2009-06-05 Jb Evain <jbevain@novell.com>
1250 * driver.cs (EmbededResource): avoid using an internal method
1251 in gmcs to embed manifest resources.
1253 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1255 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1256 the compiler from older mono versions (like moon's bots)
1258 2009-06-04 Marek Safar <marek.safar@gmail.com>
1260 * namespace.cs (LookupTypeReflection): Ignore collisions between
1263 2009-06-04 Marek Safar <marek.safar@gmail.com>
1265 * codegen.cs: Enabled generic type forwarders.
1267 2009-06-04 Marek Safar <marek.safar@gmail.com>
1269 * dmcs.*: Add another version of SRE compiler.
1271 2009-06-03 Marek Safar <marek.safar@gmail.com>
1273 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1274 generic-mcs.cs: Fixed variant type conversions.
1276 2009-06-02 Marek Safar <marek.safar@gmail.com>
1278 A fix for bug #507863
1279 * codegen.cs: Fixes a crash on invalid string value attribute.
1281 2009-06-01 Marek Safar <marek.safar@gmail.com>
1283 A fix for bug #508334
1284 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1285 cs-parser.jay: Fully import __arglist modifier.
1287 2009-05-29 Marek Safar <marek.safar@gmail.com>
1289 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1290 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1291 actually work with closed generic types.
1293 2009-05-27 Alan McGovern <amcgovern@novell.com>
1295 * class.cs, decl.cs, delegate.cs, parameter.cs:
1296 Fix the build by replacing the use of 'var' with the actual type.
1298 2009-05-27 Marek Safar <marek.safar@gmail.com>
1300 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1301 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1304 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1307 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1308 Marek Safar <marek.safar@gmail.com>
1310 A fix for bug #377509
1311 * parameter.cs: Use predefined and not empty name for implicit
1314 2009-05-21 Marek Safar <marek.safar@gmail.com>
1316 * class.cs: Don't report wrong warnings for event fields.
1318 2009-05-21 Marek Safar <marek.safar@gmail.com>
1320 A fix for bug #504667
1321 * class.cs: Check for static class using parent container instead of
1324 2009-05-08 Marek Safar <marek.safar@gmail.com>
1326 A fix for bug #496922
1327 * expression.cs: Always use temporary variable when using object
1330 2009-04-28 Marek Safar <marek.safar@gmail.com>
1332 A fix for bug #495112
1333 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1336 2009-04-27 Miguel de Icaza <miguel@novell.com>
1338 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1340 2009-04-24 Miguel de Icaza <miguel@novell.com>
1342 * complete.cs: No idea how gonzalo got a null in the list, but
1345 2009-04-24 Miguel de Icaza <miguel@novell.com>
1347 * complete.cs (CompletionElementInitializer): New completion class
1348 to support completing inside a C# 3 element initializer, so this
1349 allows completion for Silverlight situations where it is very
1352 new TextBlock () { Fo<TAB>
1354 (CompletionSimpleName): Expose the prefix that was
1355 passed to the simple name.
1357 * cs-parser.jay (object_or_collection_initializer): Add support
1358 for element_initializers.
1360 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1361 special case completion expressions as this method aggressively
1362 collects data before it operates, and errors were being thrown
1363 earlier than we were able to complete.
1365 2009-04-23 Miguel de Icaza <miguel@novell.com>
1367 * eval.cs: Make getcompletions silent and enable debugging output
1368 if the -v option is passed.
1370 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1371 Consider looking up the namespace that matches the prefix being
1374 This is part of the support for allowing completions like:
1375 `System.Co<TAB>' to complete to System.Console.
1377 * complete.cs (CompletionSimpleName.AppendResults): Make this
1380 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1382 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1383 COMPLETE_COMPLETION as internal.
1385 2009-04-17 Miguel de Icaza <miguel@novell.com>
1387 * complete.cs: Include namespace resolution in simple names as
1388 well as global types and types in the using scope in the
1391 * namespace.cs: Supporting infrastrcture to provide completions
1392 based on the current using scope.
1394 * eval.cs: Introduce an entry point that allows for initialization
1395 to return a list of the files passed on the command line.
1397 2009-04-14 Marek Safar <marek.safar@gmail.com>
1399 A fix for bug #494243
1400 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1402 2009-04-13 Marek Safar <marek.safar@gmail.com>
1404 A fix for bug #493887
1405 * statement.cs: Don't skip string multi-section with default or
1406 null label when populating string hashtable.
1408 2009-04-06 Marek Safar <marek.safar@gmail.com>
1410 A fix for bug #492329
1411 * expression.cs (New): Load variable when assigning type parameter
1414 2009-04-06 Marek Safar <marek.safar@gmail.com>
1416 A fix for bug #488960
1417 * decl.cs: Compare MVAR types using non-null values.
1419 2009-03-27 Marek Safar <marek.safar@gmail.com>
1421 * typemanager.cs, expression.cs: Removed unused nullable checks.
1423 2009-03-27 Marek Safar <marek.safar@gmail.com>
1425 * *.cs: Removed some gmcs conditionals.
1427 2009-03-26 Marek Safar <marek.safar@gmail.com>
1429 * generic.cs, support.cs: Moved generics stuff out of support.cs
1431 2009-03-24 Marek Safar <marek.safar@gmail.com>
1433 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1436 2009-03-23 Marek Safar <marek.safar@gmail.com>
1438 * attribute.cs: Consider all members for error reporting when
1439 checking named arguments.
1441 2009-03-23 Marek Safar <marek.safar@gmail.com>
1443 A fix for bug #487625
1444 * namespace.cs: Use a warning for all predefined type conflicts.
1446 2009-03-23 Marek Safar <marek.safar@gmail.com>
1448 A fix for bug #485706
1449 * statement.cs: Explicitly type catch type argument to pass verifier
1452 2009-03-22 Miguel de Icaza <miguel@novell.com>
1454 Initial support to provide code completion facilities to consumers
1455 of the evaluator API.
1457 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1458 support the completion engine. When we reach the end of the
1459 input stream instead of returning EOF, when this flag is true the
1460 tokenizer instead produces:
1462 One GENERATE_COMPLETION token: this token then must be
1463 handled in the grammar at every point where the user
1464 would likely request a completion.
1466 As many COMPLETE_COMPLETION tokens as necessary. These
1467 tokens are generated to assist the parser in unwinding and
1468 producing a valid parse tree.
1470 The parser rules do not have to be perfect, the parser needs to be
1471 augmented with judicious use of GENERATE_COMPLETION tokens to
1472 improve the areas where we can provide completion and the parser
1473 needs to add support for COMPLETE_COMPLETION tokens in productions
1476 It is common to not have enough support for COMPLETE_COMPLETION
1477 under certain rules and that even if we generated the
1478 GENERATE_COMPLETION token that the resulting tree will be invalid
1479 due to the missing rules that support COMPLETE_COMPLETION.
1481 The final EOF token is produced by having the parser notify the
1482 tokenizer when it reaches the root production that the next token
1485 * support.cs (CompletionResult): New Exception. This exception
1486 is thrown to return the completion results when one of the special
1487 completion expressions is reached.
1489 This exception is thrown by the completing ExpressionStatements
1490 classes that live in complete.cs
1492 * complete.cs (CompletingExpression): a new base class for
1493 completing expressions. This derives from the
1494 ExpressionStatement class and not from Expression as it allows
1495 completion to happen not only where expressions are expected in
1496 the grammar, but also where statements are expected.
1498 (CompletionSimpleName): A new class used to provide completions
1499 for SimpleNames. This currently only resolves to local
1500 variables from the evaluator context (GetVars call).
1502 (CompletionMemberAccess): Implements support for completing member
1505 * cs-parser.jay: Add support for completion in a few places.
1507 * eval.cs (GetCompletions): New public API for the evaluator that
1508 returns a list of possible completions given the input. The
1509 return value is an array of completions
1511 * anonymous.cs (Compatible): If the exception thrown from the
1512 resolved expression is a CompletionResult exception let that one
1513 through instead of printing a diagnostic error in the try/catch.
1515 2009-03-22 Miguel de Icaza <miguel@novell.com>
1519 * driver.cs (Main): Use Environment.Exit to quit quickly and
1520 prevent the compiler from doing the usual wait for helper thread
1523 This is to prevent a slowdown that was reported by Gonzalo on
1526 2009-03-19 Marek Safar <marek.safar@gmail.com>
1528 * ecore.cs: Load build-in types directly instead of accessing
1531 2009-03-18 Marek Safar <marek.safar@gmail.com>
1533 * ecore.cs: Always use unbox.any when available.
1535 2009-03-18 Marek Safar <marek.safar@gmail.com>
1537 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1539 2009-03-17 Marek Safar <marek.safar@gmail.com>
1541 * generic.cs: Removed obsolete version of type inference.
1543 2009-03-16 Marek Safar <marek.safar@gmail.com>
1545 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1546 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1547 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1548 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1550 2009-03-11 Marek Safar <marek.safar@gmail.com>
1552 A fix for bug #482996
1553 * anonymous.cs: Make sure we are not infering return type when
1554 checking type compatibility.
1556 2009-03-11 Marek Safar <marek.safar@gmail.com>
1558 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1559 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1560 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1561 attributes in their own structure. Needed when accessing their
1562 properties before they are resolved.
1564 2009-03-09 Marek Safar <marek.safar@gmail.com>
1566 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1567 hashtable (~10x faster).
1569 * driver.cs: Removed wrong Reset.
1571 2009-03-08 Marek Safar <marek.safar@gmail.com>
1573 * class.cs: Use correct common base type for unmanaged delayed
1576 * rootcontext.cs: Wrap unhandled exception.
1578 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1580 Make SeekableStreamReader self-tuning and arbitrarily seekable
1581 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1583 (SeekableStreamReader.Position.set): Use it. Simplify logic
1584 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1585 buffer size when the stream needs to be re-read from the beginning.
1587 2009-03-05 Marek Safar <marek.safar@gmail.com>
1589 A fix for bug #480100
1590 * parameter.cs: A parameter is not hoisted when used directly as ET.
1592 2009-03-04 Marek Safar <marek.safar@gmail.com>
1594 * statement.cs: Fixed an issue when using variable is of interface
1597 2009-03-03 Marek Safar <marek.safar@gmail.com>
1599 A fix for bug #480319
1600 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1602 2009-03-03 Marek Safar <marek.safar@gmail.com>
1604 A fix for bug #480867
1605 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1606 expression to have no valid type.
1608 2009-03-03 Marek Safar <marek.safar@gmail.com>
1610 A fix for bug #481258
1611 * class.cs: Set extension method flag in partial container.
1613 2009-03-03 Marek Safar <marek.safar@gmail.com>
1615 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1617 * attribute.cs: Add sanity check.
1619 2009-02-27 Marek Safar <marek.safar@gmail.com>
1621 * class.cs: Add external constructor error.
1623 2009-02-26 Marek Safar <marek.safar@gmail.com>
1625 A fix for bug #475354
1626 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1627 correctly user defined nullable equality operators.
1629 2009-02-25 Marek Safar <marek.safar@gmail.com>
1631 A fix for bug #479532
1632 * expression.cs: Implement NewInitialize::AddressOf.
1634 2009-02-25 Marek Safar <marek.safar@gmail.com>
1636 A fix for bug #413633
1637 * expression.cs: Iterate all base class-constraint types.
1639 2009-02-24 Marek Safar <marek.safar@gmail.com>
1641 A fix for bug #479209
1642 * literal.cs: Mutate null underlying type.
1644 2009-02-24 Marek Safar <marek.safar@gmail.com>
1646 A fix for bug #476295
1647 * convert.cs: Avoid wrapping implicitly convertible reference type.
1649 2009-02-23 Marek Safar <marek.safar@gmail.com>
1651 * iterators.cs: Create MemberName correctly.
1653 2009-02-23 Marek Safar <marek.safar@gmail.com>
1655 A fix for bug #478655
1656 * literal.cs: Check also underlying null type conversion.
1658 2009-02-21 Marek Safar <marek.safar@gmail.com>
1660 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1662 2009-02-20 Marek Safar <marek.safar@gmail.com>
1664 A fix for bug #477447
1665 * statement.cs: Add reference to correct parent storey when this
1666 is accessible from deep children storey (more than 1 level).
1668 2009-02-19 Marek Safar <marek.safar@gmail.com>
1670 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1671 * class.cs: Define base type members before setting up member cache.
1673 2009-02-18 Marek Safar <marek.safar@gmail.com>
1675 A fix for bug #477378
1676 * nullable.cs, expression.cs, statement.cs: More precise null type
1679 2009-02-18 Marek Safar <marek.safar@gmail.com>
1681 A fix for bug #472805
1682 * typemanager.cs, namespace.cs: Import only visible extension method
1685 2009-02-18 Marek Safar <marek.safar@gmail.com>
1687 A fix for bug #476895
1688 * attribute.cs: Use correct resolve context for attribute type.
1690 2009-02-18 Marek Safar <marek.safar@gmail.com>
1692 A fix for bug #476266
1693 * anonymous.cs: Mutate multi-dimensional arrays.
1695 2009-02-18 Marek Safar <marek.safar@gmail.com>
1697 A fix for bug #476400
1698 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1700 2009-02-18 Marek Safar <marek.safar@gmail.com>
1702 A fix for bug #476811
1703 * generics.cs: Fixed null-literal check.
1705 2009-02-17 Marek Safar <marek.safar@gmail.com>
1707 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1708 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1709 messing with static variables.
1711 2009-02-16 Marek Safar <marek.safar@gmail.com>
1713 A fix for bug #475965
1714 * generics.cs: Check generic parameter type after extracting from
1717 2009-02-16 Marek Safar <marek.safar@gmail.com>
1719 A fix for bug #475823
1720 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1723 2009-02-14 Marek Safar <marek.safar@gmail.com>
1725 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1726 Simplified event field definition using backing field and not
1727 field builder directly.
1729 * expression.cs (EmitLdArg): Optimize fast paths.
1731 2009-02-13 Marek Safar <marek.safar@gmail.com>
1733 A fix for bug #475327
1734 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1736 2009-02-13 Marek Safar <marek.safar@gmail.com>
1738 A fix for bug #475342
1739 * cs-parser.jay: Using 'super' instead of 'base' to call base
1740 constructor crashes compiler.
1742 2009-02-13 Marek Safar <marek.safar@gmail.com>
1744 A fix for bug #475354
1745 * expression.cs (Constantify): Add nullable types.
1747 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1749 2009-02-12 Marek Safar <marek.safar@gmail.com>
1751 A fix for bug #475246
1752 * expression.cs: More broken flowanalysis hacking needed.
1754 2009-02-12 Marek Safar <marek.safar@gmail.com>
1756 * attribute.cs: Compare only ref/out array modifiers.
1758 2009-02-11 Marek Safar <marek.safar@gmail.com>
1760 * statement.cs: Use member cache when looking for foreach members.
1762 2009-02-11 Marek Safar <marek.safar@gmail.com>
1764 * expression.cs: Don't expose internal initializer types.
1766 * statement.cs: Check also explicit conversions for goto case.
1768 2009-02-11 Marek Safar <marek.safar@gmail.com>
1770 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1772 2009-02-10 Marek Safar <marek.safar@gmail.com>
1774 * *.cs: Replace null-type with NullLiteral where appropriate.
1776 2009-02-09 Marek Safar <marek.safar@gmail.com>
1778 * expression.cs: Initializer of reference argument use temporary
1779 variable to be verifiable.
1781 * parameter.cs: Share EmitLdArg.
1783 2009-02-09 Marek Safar <marek.safar@gmail.com>
1785 A fix for bug #473559
1786 * class.cs: Fixed: Not reporting error about nested class with the
1789 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1791 Contributed under the MIT/X11 license.
1793 * generic.cs: Added VerifyVariantTypeParameters which performs new
1794 variance verification logic. The old logic, based on the spec, was
1795 wrong because the spec is full of LIES!
1797 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1799 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1802 * ecore.cs: Added calls to the new variance verification logic.
1805 * delegate.cs: Removed calls to the old variance verification logic.
1807 2009-02-06 Marek Safar <marek.safar@gmail.com>
1809 * delegate.cs: Use cached Invoke method directly.
1811 2009-02-06 Marek Safar <marek.safar@gmail.com>
1813 * expression.cs: Emit expression tree for hoisted variable access.
1815 2009-02-04 Marek Safar <marek.safar@gmail.com>
1817 * namespace.cs: Add better extension class check.
1819 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
1821 * generic.cs: Fixed typeo (TypeParameter.Variacne).
1823 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
1825 This patch adds initial generic variance support to the compiler.
1826 It is contributed under the MIT/X11 license.
1828 * typemanager.cs: Modified ImplementsInterface to check variance.
1829 Added VerifyVariantTypeParameters which checks the specified type to see
1830 if it uses a variant type parameter as a type argument (which is not
1831 allowed). Added IsVariantOf which determins if the first type is a
1832 variant of the second. NOTE: This only supports reference types at
1833 the moment to conform with the current level of VM support. When the
1834 VM supports value types, this will follow step.
1836 * generic.cs: Added the Variance enum. Added a Variance property to
1837 TypeParameter and added variance support to definition phase. Added a
1838 Variance property to TypeParameterName. Also check to make sure that
1839 no variant types appear in generic method parameters.
1841 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
1842 keywords if the langversion supports it.
1844 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
1845 that variant types are only used in legal positions. Also added
1846 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
1849 * decl.cs: Construct TypeParameter with the variance information.
1851 * convert.cs: Checks variance in ImplicitReferenceConversionExists
1852 and ImplicitConversionStandard.
1854 * rootcontext.cs: Added new "Future" language version.
1856 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
1857 type parameters are not used as type arguments in interface inheritance.
1858 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
1859 parameters are not used as method return types. In MemberBase.
1860 ResolveMemberType, ensure that variant type parameters are not used
1861 as type arguments. Also call VerifyNoVariantTypeParameters on every
1862 set of parameters which are resolved.
1864 * delegate.cs: Modified Delegate.Define to ensure that variant
1865 parameters are not used as type arguments and that a contravariant
1866 parameter is not used as the return type. Also call
1867 VerifyNoVariantTypeParameters on the delegate parameters.
1869 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
1870 to specify generic variance.
1872 * driver.cs: Added support for LanguageVersion.Future in the form of
1873 "-langversion:future".
1875 * generic-mcs.cs: Stubbed out new members in generic.cs.
1877 2009-02-03 Marek Safar <marek.safar@gmail.com>
1879 * class.cs, generic.cs: Emit type parameter constraints for nested
1882 2009-02-02 Marek Safar <marek.safar@gmail.com>
1884 A fix for bug #471213
1885 * class.cs: Avoid emitting backing field for abstract event fields.
1887 2009-02-01 Marek Safar <marek.safar@gmail.com>
1889 A fix for bug #359731
1890 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
1893 2009-01-30 Marek Safar <marek.safar@gmail.com>
1895 A fix for bug #470767
1896 * statement.cs: Introduced BlockScopeExpression, needed when
1897 expression tree conversion has to emit scope variables.
1899 2009-01-29 Marek Safar <marek.safar@gmail.com>
1901 * class.cs: Remove duplicate CallingConvention.
1903 2009-01-29 Marek Safar <marek.safar@gmail.com>
1905 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
1906 when I finally found the right naming convention.
1908 2009-01-29 Marek Safar <marek.safar@gmail.com>
1910 * cs-tokenizer.cs: Put back different open parens optimization.
1912 2009-01-28 Marek Safar <marek.safar@gmail.com>
1914 A fix for bug #470227
1915 * cs-tokenizer.cs: Remove too agressive parser optimization.
1917 2009-01-28 Marek Safar <marek.safar@gmail.com>
1919 A fix for bug #324319
1920 * class.cs: Remove too early base type resolve.
1922 2009-01-27 Marek Safar <marek.safar@gmail.com>
1924 A fix for bug #324319
1925 * ecore.cs: Explicitly type null when assigning to type argument to
1926 make pass verifier check.
1928 2009-01-27 Marek Safar <marek.safar@gmail.com>
1930 * anonymous.cs: Fixed recent regression when initializing captured
1933 2009-01-26 Marek Safar <marek.safar@gmail.com>
1935 A fix for bug #469019
1936 * anonymous.cs: Use all parent type parameters when instantiating
1937 nested generic storey.
1939 2009-01-26 Marek Safar <marek.safar@gmail.com>
1941 * expression.cs: Check for null instance methodgroup expression.
1943 2009-01-26 Marek Safar <marek.safar@gmail.com>
1945 A fix for bug #469244
1946 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
1947 instance inside a conditional expression.
1949 2009-01-23 Marek Safar <marek.safar@gmail.com>
1951 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
1952 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
1953 GetElementType and HasElementType. IsValueType clean up.
1955 2009-01-23 Marek Safar <marek.safar@gmail.com>
1957 * nullable.cs: Use common EmitCall.
1959 * expression.cs: Emit constraint. for virtual calls only.
1961 2009-01-23 Marek Safar <marek.safar@gmail.com>
1963 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
1964 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
1965 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
1968 2009-01-22 Jb Evain <jbevain@novell.com>
1970 * anonymous.cs: make anonymous types' ToString implementation
1971 match what csc outputs.
1973 2009-01-21 Marek Safar <marek.safar@gmail.com>
1975 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
1978 2009-01-17 Marek Safar <marek.safar@gmail.com>
1980 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
1983 2009-01-16 Marek Safar <marek.safar@gmail.com>
1985 * nullable.cs (LiftedBinaryOperator): Check for all possible null
1988 2009-01-15 Marek Safar <marek.safar@gmail.com>
1990 A fix for bug #466634
1991 * statement.cs: Add reference for nested storey when only this
1994 2009-01-15 Marek Safar <marek.safar@gmail.com>
1996 A fix for bug #466474
1997 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2000 2009-01-15 Marek Safar <marek.safar@gmail.com>
2002 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2003 Fixed nested stories parent referencing process. Also fixes #463985.
2005 2009-01-06 Marek Safar <marek.safar@gmail.com>
2007 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2008 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2009 implementation. Also fixes #463108.
2011 2009-01-05 Marek Safar <marek.safar@gmail.com>
2013 A fix for bug #416109
2014 * decl.cs: Issue correct CLSAttribute warning location.
2016 2009-01-05 Marek Safar <marek.safar@gmail.com>
2018 A fix for bug #456775
2019 * attribute.cs: Use attribute owner scope when resolving attribute
2022 2009-01-05 Marek Safar <marek.safar@gmail.com>
2024 A fix for bug #457257
2025 * decl.cs: Fixed incorrect member declaring type comparison.
2027 2009-01-05 Marek Safar <marek.safar@gmail.com>
2029 A fix for bug #460896
2030 * driver.cs: Handle /RES resources as embeddable.
2032 2009-01-05 Marek Safar <marek.safar@gmail.com>
2034 A fix for bug #462515
2035 * ecore.cs: Report inacessible members upwards.
2037 2009-01-05 Marek Safar <marek.safar@gmail.com>
2039 A fix for bug #463190, #463192
2040 * decl.cs, namespace.cs: Also import internal extension classes.
2042 2009-01-04 Marek Safar <marek.safar@gmail.com>
2044 A fix for bug #463415
2045 * generic.cs: Use right index for RemoveDependentTypes.
2047 2009-01-02 Marek Safar <marek.safar@gmail.com>
2049 A fix for bug #463196
2050 * expression.cs: Fixed enum to null comparison.
2052 2009-01-02 Marek Safar <marek.safar@gmail.com>
2054 A fix for bug #463121
2055 * nullable.cs: Fixed nullable user equality operator comparison.
2057 2009-01-02 Marek Safar <marek.safar@gmail.com>
2059 A fix for bug #462950
2060 * class.cs, decl.cs: Use full explicit name when defining automatic
2061 property backing field.
2063 2009-01-02 Marek Safar <marek.safar@gmail.com>
2065 A fix for bug #462592
2066 * pending.cs: Emit type arguments for generic proxy method.
2068 2008-12-30 Marek Safar <marek.safar@gmail.com>
2070 * expression.cs (As): Mutate all type arguments.
2072 2008-12-29 Marek Safar <marek.safar@gmail.com>
2074 A fix for bug #462622
2075 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2078 2008-12-29 Marek Safar <marek.safar@gmail.com>
2080 A fix for bug #450782
2081 * ecore.cs: Consider more variables of form V.I to be fixed.
2083 2008-12-29 Marek Safar <marek.safar@gmail.com>
2085 A fix for bug #460712
2086 * typemanager.cs: Core types could be imported.
2088 2008-12-28 Marek Safar <marek.safar@gmail.com>
2090 A fix for bugs #460847, #460772, #458049, #457339, #447807
2091 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2092 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2093 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2094 user lambdas used inside query clauses.
2096 2008-12-18 Marek Safar <marek.safar@gmail.com>
2098 A fix for bug #460229
2099 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2101 2008-12-18 Marek Safar <marek.safar@gmail.com>
2103 A fix for bug #459952
2104 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2106 2008-12-18 Marek Safar <marek.safar@gmail.com>
2108 A fix for bug #459630
2109 * convert.cs: Enum to valuetype conversion is not allowed.
2111 2008-12-18 Marek Safar <marek.safar@gmail.com>
2113 A fix for bug #457087
2114 * generic.cs: Don't crash when constraint comes from type
2117 2008-12-16 Marek Safar <marek.safar@gmail.com>
2119 A fix for bug #459221
2120 * anonymous.cs, statement.cs: Delay only captured this
2123 2008-12-12 Marek Safar <marek.safar@gmail.com>
2125 A fix for bug #457489
2126 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2127 and initialization to capture scope initializers correctly.
2129 2008-12-11 Marek Safar <marek.safar@gmail.com>
2131 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2132 ParameterReference refactoring.
2134 2008-12-03 Marek Safar <marek.safar@gmail.com>
2136 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2137 to be imported from any assembly.
2139 2008-12-03 Marek Safar <marek.safar@gmail.com>
2141 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2142 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2143 from anonymous method and lambda expression.
2145 2008-12-01 Marek Safar <marek.safar@gmail.com>
2147 A fix for bug #448560
2148 * expression.cs (As): Box any generic type arguments to be
2151 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2153 Add tripwire for implicit conversion bugs
2154 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2156 (MethodGroupExpr.OverloadResolve): Add sanity check between
2157 IsApplicable and VerifyArgumentsCompat.
2158 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2160 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2162 Fix build break in System.Data_test
2163 * convert.cs (ImplicitConversionExists): Move NullLiteral
2165 (ImplicitStandardConversionExists): ... here.
2167 2008-11-28 Marek Safar <marek.safar@gmail.com>
2169 * literal.cs: Emit correctly explicit null to nullable cast.
2171 2008-11-28 Marek Safar <marek.safar@gmail.com>
2173 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2176 2008-11-28 Marek Safar <marek.safar@gmail.com>
2178 A fix for bug #449005
2179 * convert.cs, nullable.cs: Use only one implicit nullable
2182 2008-11-27 Marek Safar <marek.safar@gmail.com>
2184 * convert.cs, literal.cs: More Convert cleanup is needed.
2186 2008-11-27 Marek Safar <marek.safar@gmail.com>
2188 * decl.cs, class.cs: Fixed misleading error message.
2190 2008-11-26 Marek Safar <marek.safar@gmail.com>
2192 A fix for bug #449005
2193 * nullable.cs (EmitEquality): Disable optimization for user operator
2196 2008-11-25 Marek Safar <marek.safar@gmail.com>
2198 A fix for bug #447027
2199 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2200 with context variables stored as expression instances.
2202 2008-11-25 Marek Safar <marek.safar@gmail.com>
2204 A fix for bug #447027
2205 * delegate.cs: Fixed delegate VerifyMethod logic.
2207 2008-11-24 Marek Safar <marek.safar@gmail.com>
2209 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2212 2008-11-21 Marek Safar <marek.safar@gmail.com>
2214 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2215 member type resolve to follow normal flow, instead of random
2218 2008-11-21 Marek Safar <marek.safar@gmail.com>
2220 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2223 2008-11-21 Marek Safar <marek.safar@gmail.com>
2225 * const.cs: Emit decimal array constant as literal.
2227 2008-11-20 Marek Safar <marek.safar@gmail.com>
2229 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2231 2008-11-19 Marek Safar <marek.safar@gmail.com>
2233 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2234 into real property (saves 8 MB for corlib compilation).
2236 2008-11-19 Marek Safar <marek.safar@gmail.com>
2238 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2239 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2240 generic-mcs.cs: Small cleanup of TypeArguments.
2242 2008-11-18 Marek Safar <marek.safar@gmail.com>
2244 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2245 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2246 of ConstructedType expression, renamed to GenericTypeExpr.
2248 2008-11-17 Marek Safar <marek.safar@gmail.com>
2250 A fix for bug #445303
2251 * location.cs (IsConditionalDefined): Handle undefined global
2254 2008-11-17 Marek Safar <marek.safar@gmail.com>
2256 A fix for bug #444678
2257 * expression.cs (TryReduceConstant): Always create new constant
2260 2008-11-17 Marek Safar <marek.safar@gmail.com>
2262 A fix for bug #444673
2263 * ecore.cs: Ignore open generic types when used as generic type
2266 2008-11-17 Marek Safar <marek.safar@gmail.com>
2268 A fix for bug #445458
2269 * expression.cs, cs-parser.jay: Don't crash when an expression
2272 2008-11-17 Marek Safar <marek.safar@gmail.com>
2274 A fix for bug #445464
2275 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2276 inside unbound type.
2278 2008-11-14 Jb Evain <jbevain@novell.com>
2280 * driver.cs: ignore empty -nowarn argument such as
2281 the one in -nowarn:12,13,,.
2283 2008-11-13 Marek Safar <marek.safar@gmail.com>
2285 A fix for bug #444271
2286 * anonymous.cs: Rescan parent storeys when best candidate was
2289 2008-11-13 Marek Safar <marek.safar@gmail.com>
2291 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2292 useless UnboundTypeExpression.
2294 * attribute.cs: Do check obsolete attribute on generic types.
2296 2008-11-12 Marek Safar <marek.safar@gmail.com>
2298 A fix for bugs #425680, #400139
2299 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2302 2008-11-11 Marek Safar <marek.safar@gmail.com>
2304 A fix for bug #435747
2305 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2306 compound value types assignment. Few micro optimizations added.
2308 2008-11-10 Marek Safar <marek.safar@gmail.com>
2310 A fix for bug #442610
2311 * anonymous.cs (MutateConstructor): More SRE hacking.
2313 2008-11-10 Marek Safar <marek.safar@gmail.com>
2315 A fix for bug #442579
2316 * ecore.cs: Also initialize expanded form of a method with 1 params
2319 2008-11-06 Marek Safar <marek.safar@gmail.com>
2321 * expression.cs (UnaryMutator): Do early l-side check.
2323 2008-11-05 Miguel de Icaza <miguel@novell.com>
2325 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2326 Init, otherwise we would crash later on when checking for friend
2329 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2330 Otherwise we never get any meaningful information as to what
2333 2008-11-05 Marek Safar <marek.safar@gmail.com>
2335 A fix for bug #436318
2336 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2338 2008-11-05 Miguel de Icaza <miguel@novell.com>
2340 * namespace.cs: Turns out that it was a really bad idea to hide
2341 the errors for namespaces not found here in eval mode.
2343 * eval.cs: When we process using clauses, only enter those into
2344 the list of valid using clauses after they have been validated.
2346 The above change gives the proper semantics: it does not
2347 senselessly report the same errors with broken using statements by
2348 never storing them in the first place when they are invalid.
2350 2008-11-05 Marek Safar <marek.safar@gmail.com>
2352 A fix for bug #421839
2353 * cs-parser.jay: Remove expression from coalesce rule to force lower
2354 priority than the assignment operator.
2356 2008-11-05 Marek Safar <marek.safar@gmail.com>
2358 A fix for bug #437875
2359 * nullable.cs: Compile correctly method group operand used with null
2360 coalescing operator.
2362 2008-11-04 Marek Safar <marek.safar@gmail.com>
2364 A fix for bug #434589
2365 * expression.cs (Binary): Ignore lifted conversions when at least
2366 one operand is of reference type.
2368 2008-11-04 Marek Safar <marek.safar@gmail.com>
2370 * cs-parser.jay: Better syntax error report.
2372 2008-11-03 Marek Safar <marek.safar@gmail.com>
2374 A fix for bug #436792
2375 * cs-parser.jay: Use GetLocation to access location.
2377 2008-11-03 Marek Safar <marek.safar@gmail.com>
2379 A fix for bug #440774
2380 * cs-parser.jay: Also set current_array_type when parsing local
2383 2008-11-03 Marek Safar <marek.safar@gmail.com>
2385 A fix for bug #440785
2386 * expression.cs (As): Don't resolve self modifing expression
2389 2008-11-03 Marek Safar <marek.safar@gmail.com>
2391 A fix for bug #439447
2392 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2394 2008-11-03 Marek Safar <marek.safar@gmail.com>
2396 A fix for bug #437571
2397 * cs-parser.jay: Fixes internal error for invalid expression
2400 2008-10-17 Marek Safar <marek.safar@gmail.com>
2402 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2404 2008-10-17 Marek Safar <marek.safar@gmail.com>
2406 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2408 2008-10-17 Marek Safar <marek.safar@gmail.com>
2410 * cs-tokenizer.cs: More precise cast parsing.
2412 2008-10-16 Martin Baulig <martin@ximian.com>
2414 * anonymous.cs (AnonymousMethodStorey): Put back the
2415 `hoisted_locals' hashtable and use it in EmitType().
2417 2008-10-15 Marek Safar <marek.safar@gmail.com>
2419 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2420 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2423 2008-10-14 Marek Safar <marek.safar@gmail.com>
2425 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2427 2008-10-14 Marek Safar <marek.safar@gmail.com>
2429 * statement.cs: Mutate scope initializers.
2431 2008-10-14 Marek Safar <marek.safar@gmail.com>
2433 * expression.cs: Use typeless value for This constant.
2435 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2437 2008-10-14 Marek Safar <marek.safar@gmail.com>
2439 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2442 2008-10-13 Marek Safar <marek.safar@gmail.com>
2444 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2447 2008-10-13 Marek Safar <marek.safar@gmail.com>
2449 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2450 parser and tokenizer. Fixes many ambiguities including #433258.
2452 2008-10-10 Marek Safar <marek.safar@gmail.com>
2454 * cs-parser.jay: Fixed missing accessor recovery.
2456 2008-10-10 Marek Safar <marek.safar@gmail.com>
2458 A fix for bug #433701
2459 * expression.cs: Better error message.
2461 2008-10-10 Marek Safar <marek.safar@gmail.com>
2463 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2465 * Makefile: Disabled unused debug symbols.
2467 Also fixes: #320556, #321097, #321656, #321876, #351316
2469 2008-10-09 Miguel de Icaza <miguel@novell.com>
2471 * eval.cs: rename "<interactive>" to "{interactive}", to work
2472 around a requirement in the compiler that this be a valid
2473 filename, and in Windows it is not (433886).
2475 2008-10-09 Marek Safar <marek.safar@gmail.com>
2477 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2479 2008-10-08 Marek Safar <marek.safar@gmail.com>
2481 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2482 cs-parser.jay: Generic type declaration and type arguments cleanup.
2484 2008-10-05 Marek Safar <marek.safar@gmail.com>
2486 * cs-parser.jay: Allow parsing weird array creation construct.
2488 2008-10-05 Marek Safar <marek.safar@gmail.com>
2490 * cs-parser.jay: Conflicts reduction.
2492 2008-10-04 Marek Safar <marek.safar@gmail.com>
2494 * cs-parser.jay: Conflicts reduction.
2496 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2499 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2500 property. Add a 'count' hint about the use of the shared vector.
2501 Ensure that we don't leak out dirty bits.
2502 (UsageVector.MergeChild): Throw away information about variables
2504 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2506 2008-10-03 Marek Safar <marek.safar@gmail.com>
2508 A fix for bug #431746
2509 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2510 parameters when iterator is created.
2512 2008-10-03 Marek Safar <marek.safar@gmail.com>
2514 A fix for bug #431827
2515 * expression.cs: Fixed right based pointer arithmetic operations
2518 2008-10-03 Marek Safar <marek.safar@gmail.com>
2520 A fix for bug #353779
2521 * assign.cs, expression.cs: Fixed compound assignment conversions.
2523 2008-10-02 Marek Safar <marek.safar@gmail.com>
2525 A fix for bug #375262
2526 * statement.cs: Refactor ArrayForeach to be usable with string
2527 indexer. Optimized single dimentional arrays foreach.
2529 2008-10-02 Marek Safar <marek.safar@gmail.com>
2531 A fix for bug #431255
2532 * anonymous.cs, expression.cs: Removed broken optimization.
2534 2008-10-01 Marek Safar <marek.safar@gmail.com>
2536 * anonymous.cs: Use full type parameters of parent generic
2537 containers. Removed unnecessary AddParentStoreyReference call.
2539 2008-10-01 Marek Safar <marek.safar@gmail.com>
2541 A fix for bug #324702
2542 * class.cs: Use better shorter names for explicit interface member
2545 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2547 2008-10-01 Marek Safar <marek.safar@gmail.com>
2549 * expression.cs: Use new interface to check fixed expression.
2551 2008-10-01 Marek Safar <marek.safar@gmail.com>
2553 A fix for bug #421101
2554 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2555 interface to check for fixed fixed-buffers.
2557 2008-10-01 Marek Safar <marek.safar@gmail.com>
2559 A fix for bug #429264
2560 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2562 * delegate.cs: Removed unnecessary casts.
2564 2008-09-30 Marek Safar <marek.safar@gmail.com>
2566 A fix for bug #352151
2567 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2568 class.cs: Fixed already defined explicit interface members check.
2570 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2572 cs-tokenizer.cs: Fix typo.
2574 2008-09-28 Miguel de Icaza <miguel@novell.com>
2576 * eval.cs (InteractiveBase): The quit command now just sets a
2577 flag, instead of calling Environment.Exit(), it is milder on
2580 CompiledMethod is now in Mono.CSharp, not nested inside
2581 the Evaluator, it was inconvenient to use.
2583 2008-09-27 Miguel de Icaza <miguel@novell.com>
2585 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2586 code to be invoked without having to reparse.
2588 2008-09-27 Miguel de Icaza <miguel@novell.com>
2590 * ecore.cs: The recent changes to FieldExpr broke this as well.
2591 Fixes LINQ queries in the interactive shell.
2593 * Multiple files: indentation fixing for the Mono coding
2594 guidelines for the switch statement.
2596 * eval.cs: Make the Evaluator API thread safe.
2598 2008-09-26 Marek Safar <marek.safar@gmail.com>
2600 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2601 constructor parsing.
2603 2008-09-26 Marek Safar <marek.safar@gmail.com>
2605 A fix for bug #325326
2606 * statement.cs: Check possible mistaken empty statement using
2607 explicit blocks only.
2609 2008-09-25 Miguel de Icaza <miguel@novell.com>
2611 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2612 RootNamespace.ComputeNamespaces to update the internal list of
2613 namespaces, this is no longer done for us.
2615 (InteractiveBase): Use the Evaluator APIs instead of calling into
2618 2008-09-25 Marek Safar <marek.safar@gmail.com>
2620 A fix for bug #429264
2621 * expression.cs: Missing mutator for access to multidimensional
2624 2008-09-25 Marek Safar <marek.safar@gmail.com>
2626 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2629 * driver.cs: Missing input argument check.
2631 2008-09-25 Marek Safar <marek.safar@gmail.com>
2633 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2634 expression.cs, statement.cs, rootcontext.cs, class.cs,
2635 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2638 2008-09-24 Miguel de Icaza <miguel@novell.com>
2640 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2641 fully constructed FieldExpr, fixes the regression introduced in
2644 * ecore.cs, expression.cs: Plug back the eclass initialization as
2645 otherwise it regresses `csharp'.
2647 2008-09-24 Marek Safar <marek.safar@gmail.com>
2649 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2650 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2651 phase to resolve phase. It resolves problems with expression trees
2652 and fixes bugs #323796, #325156.
2654 2008-09-23 Marek Safar <marek.safar@gmail.com>
2656 * codegen.cs: Report better error when symbol writer is missing.
2658 2008-09-23 Marek Safar <marek.safar@gmail.com>
2660 * codegen.cs: Set .NET symbol writer.
2662 * decl.cs: Guard against null generic arguments.
2664 * report.cs: Don't report exactly same additional details.
2666 2008-09-22 Marek Safar <marek.safar@gmail.com>
2668 A fix for bug #324917
2669 * cs-parser.jay: Add missing multidimensional non-expression type
2672 2008-09-22 Marek Safar <marek.safar@gmail.com>
2674 A fix for bug #428191
2675 * anonymous.cs: Create an outer generic fields also for non-storey
2678 2008-09-22 Marek Safar <marek.safar@gmail.com>
2680 A fix for bug #378294
2681 * class.cs: Make fixed size buffers gmcs feature only.
2683 2008-09-22 Marek Safar <marek.safar@gmail.com>
2685 A fix for bug #355622, #324993
2686 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2689 2008-09-19 Marek Safar <marek.safar@gmail.com>
2691 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2694 2008-09-19 Marek Safar <marek.safar@gmail.com>
2696 A fix for bug #416110
2697 * generic.cs: Struct constraint results in default ctor and
2698 ValueType base type constraint to be set.
2700 2008-09-19 Marek Safar <marek.safar@gmail.com>
2702 A fix for bug #423791
2703 * generic.cs: Fixed params output type type-inference.
2705 2008-09-19 Marek Safar <marek.safar@gmail.com>
2707 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2709 2008-09-19 Marek Safar <marek.safar@gmail.com>
2711 * cs-tokenizer.cs: Don't break on extra partial modifier.
2713 2008-09-19 Marek Safar <marek.safar@gmail.com>
2715 A fix for bug #427592
2716 * generic.cs: Use common parameter resolve method.
2718 2008-09-18 Marek Safar <marek.safar@gmail.com>
2720 A fix for bug #414758
2721 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2724 2008-09-18 Marek Safar <marek.safar@gmail.com>
2726 * driver.cs, namespace.cs: Read types and namespaces after all
2727 requested assemblies are loaded, fixes issues with System.Core
2728 auto-reference, and #419888.
2730 2008-09-18 Marek Safar <marek.safar@gmail.com>
2732 A fix for bug #417705
2733 * cs-parser.jay: Fixed as/is operator expression split.
2735 2008-09-18 Marek Safar <marek.safar@gmail.com>
2737 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2738 Fixed expression tree representation of empty new expression and
2739 new initializer expression.
2741 2008-09-18 Miguel de Icaza <miguel@novell.com>
2743 * eval.cs: Remove warning, keep reference to driver around.
2745 * Hide fields that do not need to be public.
2747 2008-09-17 Marek Safar <marek.safar@gmail.com>
2749 A fix for bug #426385
2750 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2751 conversion for array elements.
2753 2008-09-17 Marek Safar <marek.safar@gmail.com>
2755 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2756 void parsing conflicts.
2758 2008-09-15 Marek Safar <marek.safar@gmail.com>
2760 A fix for bug #425601
2761 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2762 System.Core only when there is no custom ExtensionAttribute
2765 2008-09-15 Miguel de Icaza <miguel@novell.com>
2767 * namespace.cs: Do not report CS0246 (name
2769 2008-09-12 Marek Safar <marek.safar@gmail.com>
2771 A fix for bug #425669
2772 * generic.cs: Don't cache generic static anonymous method
2775 2008-09-12 Marek Safar <marek.safar@gmail.com>
2777 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2778 conflicting constraints.
2780 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2782 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2785 2008-09-12 Marek Safar <marek.safar@gmail.com>
2787 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2788 to null pointer conversion fixes.
2790 2008-09-11 Marek Safar <marek.safar@gmail.com>
2792 * cs-parser.jay, expression.cs: An implicitly typed local variable
2793 declarator cannot use an array initializer.
2795 2008-09-11 Marek Safar <marek.safar@gmail.com>
2797 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2799 2008-09-11 Marek Safar <marek.safar@gmail.com>
2801 * generic.cs (InflatedConstraints): Don't crash when constraints
2804 * cs-parser.jay: const_declarator is a block.
2806 * constant.cs: Check for not allowed NaN conversions.
2808 2008-09-10 Miguel de Icaza <miguel@novell.com>
2810 * driver.cs: Drop --shell argument, the compiler is no longer a
2813 * eval.cs: Move most of the code that deals with evaluation into
2814 this file and document the public API from repl.cs
2816 * repl.cs: Remove from here.
2818 2008-09-10 Marek Safar <marek.safar@gmail.com>
2820 A fix for bug #424684
2821 * generic.cs: Generic class constraints must come first.
2823 2008-09-09 Miguel de Icaza <miguel@novell.com>
2825 * cs-parser.jay: Improve error reporting for syntax errors in
2826 statements and expressions, we now report the expected tokens
2827 instead of reporting the useless "; expected".
2829 Drop the strings from the token declaration, it turns out that
2830 they did not do what I thought they did. Instead they were adding
2831 two sets of tokens to the tables.
2833 2008-09-09 Marek Safar <marek.safar@gmail.com>
2835 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
2836 delegate.cs: Share special type check.
2838 2008-09-09 Marek Safar <marek.safar@gmail.com>
2840 A fix for bug #423981
2841 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
2843 2008-09-09 Marek Safar <marek.safar@gmail.com>
2845 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
2848 2008-09-09 Marek Safar <marek.safar@gmail.com>
2850 A fix for bugs: #324750, #335946
2851 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
2852 lookup rule to determine ?-based tokens.
2854 2008-09-08 Miguel de Icaza <miguel@novell.com>
2856 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
2857 expressions (like event adding or removing) end up here, so we
2858 need to treat those as statements.
2860 Add LoadAssembly method.
2862 2008-09-04 Miguel de Icaza <miguel@novell.com>
2864 * repl.cs: Add Time method.
2866 2008-09-05 Marek Safar <marek.safar@gmail.com>
2868 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
2870 2008-09-05 Miguel de Icaza <miguel@novell.com>
2872 * repl.cs: Add workaround for old compilers.
2874 2008-09-04 Jb Evain <jbevain@novell.com>
2876 * repl.cs (PrettyPrint): pretty print everything that
2877 implements IDictionary, as well as IEnumerables. Also,
2878 add a quit helper property.
2880 2008-09-04 Marek Safar <marek.safar@gmail.com>
2882 * constant.cs: Better error reporting for decimal literals.
2884 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
2887 2008-09-04 Marek Safar <marek.safar@gmail.com>
2888 Miguel de Icaza <miguel@novell.com>
2890 A fix for bug #422951
2891 * assign.cs (Assign.DoResolve): Perform the type conversions
2892 checks before we attempt to initialize `New' initializers.
2894 2008-09-04 Marek Safar <marek.safar@gmail.com>
2896 A fix for bug #422853
2897 * delegate.cs (DelegateCreation): Add special handling for
2898 EmptyExpression.Null instance expression which is just another
2899 hack for undecided member instance exression.
2901 2008-09-04 Marek Safar <marek.safar@gmail.com>
2903 * expression.cs, ecore.cs: Emit full expression tree for reduced
2906 2008-09-04 Marek Safar <marek.safar@gmail.com>
2908 * expression.cs (This): Guard against multi-resolving.
2910 * ecore.cs, statement.cs (Throw): Simplified.
2912 * flowanalysis.cs: Also verify event fields.
2914 2008-09-04 Miguel de Icaza <miguel@novell.com>
2916 * assign.cs (Assign.DoResolve): Perform the type conversions
2917 checks before we attempt to initialize `New' initializers.
2919 * repl.cs (PrettyPrint): Add Hashtable prettyprint
2921 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
2924 * repl.cs: Update help.
2926 2008-09-03 Miguel de Icaza <miguel@novell.com>
2928 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
2929 handling of the default config handling, including the special
2930 treatment of System.Core assembly.
2932 Fixes the REPL processing for LINQ.
2934 2008-09-03 Marek Safar <marek.safar@gmail.com>
2936 A fix for bug #422507
2937 * expression.cs (UnboxCast): Add missing child expression mutator.
2939 2008-09-03 Marek Safar <marek.safar@gmail.com>
2941 * driver.cs: Don't self reference System.Core assembly.
2943 2008-09-03 Marek Safar <marek.safar@gmail.com>
2945 A fix for bug #422507
2946 * expression.cs (StringConcat): Add missing type mutator.
2948 2008-09-03 Marek Safar <marek.safar@gmail.com>
2950 * generic.cs (TypeInferenceContext): Follow equality rule for
2951 constructed type lower bound type inference.
2953 2008-09-02 Miguel de Icaza <miguel@novell.com>
2955 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
2956 <dblank@cs.brynmawr.edu> which updates the cursor position on
2959 2008-09-02 Marek Safar <marek.safar@gmail.com>
2961 A fix for bug #367145
2962 * driver.cs: Fixed import of extension methods when using -noconfig
2965 2008-09-02 Marek Safar <marek.safar@gmail.com>
2967 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
2968 version from non-generic implementation instead.
2970 2008-09-01 Marek Safar <marek.safar@gmail.com>
2972 A fix for bug #418908
2973 * class.cs: Use AddScopeStatement for field initializers.
2975 2008-09-01 Marek Safar <marek.safar@gmail.com>
2977 A fix for bug #415385
2978 * ecore.cs, convert.cs: Do method group conversion for equal group types.
2980 2008-09-01 Marek Safar <marek.safar@gmail.com>
2982 A fix for bug #421736
2983 * iterators.cs: Don't crash on unreachable iterators.
2985 2008-09-01 Marek Safar <marek.safar@gmail.com>
2987 A fix for bug #421628
2988 * parameter.cs, attribute.cs: Clone also parameter attributes.
2990 2008-08-30 Miguel de Icaza <miguel@novell.com>
2992 * namespace.cs (LookupType): In EvalMode, try to replace
2993 the TypeBuilder from our cache with a Type as Reflection.Emit does
2994 not like to mix code from older assemblies emitted and new
2997 This sounds like a serious Mono bug that prevents multiple
2998 assemblies to be generated and consumed at the same time.
3000 * cs-parser.jay (push_current_class): Do not make interactive
3001 classes internal or private, make them public as we currently
3002 generate each new class in a new assembly.
3004 2008-08-29 Miguel de Icaza <miguel@novell.com>
3006 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3007 remove types that are entered into the global namespace during
3008 parsing so that we can remove them on failure.
3010 * cs-parser.jay: Parsing: we now keep track of types that are
3011 entered into global variables and queue those in case the parsing
3014 This happens in a few situations: during partial-input, we invoke
3015 the parser repeatedly for example with the string "class X", this
3016 would cause X to be registed, and we need to remove this
3017 registration so that another parse attempt later with say "class X {"
3018 would actually work.
3020 Additionally, if there is an error in the resolution phase, for
3021 example: "class X : NonExistant {}" th
3023 * cs-parser.jay: Be more precise with the errors being raised,
3024 instead of flagging all exceptions during parsing to be attributed
3025 to the parsing process, distinguish those from errors happening in
3026 the actions and hint that using -v would produce the actual
3029 * repl.cs: Do not load all compiler references on each reset,
3030 doing the partial reset takes care of this.
3032 2008-08-28 Miguel de Icaza <miguel@novell.com>
3034 * repl.cs: Add support for loading all the files from
3035 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3038 Introduce a micro-parser that is able to deambiguate on its input
3039 whether we are dealing with a compilation unit (namespace, class,
3040 interface, struct, delegate) declaration or a statement. This
3041 allows both declarations and statements to be entered.
3043 Set history size by default to 300 lines.
3045 Instead of distinguishing based on the parser.InteractiveResult,
3046 have only two cases: statements were parsed, or a compilation unit
3047 was. Always pull the Using statement additions from the
3048 compilation unit parse.
3050 * cs-tokenizer.cs: Rename tokens to better describe their intent
3051 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3053 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3054 EvalMode is used to trigger the lookup of global variables while
3055 StatementMode is used turn variable declarations into static
3058 * getline.cs: Allow history size to be set.
3060 2008-08-29 Marek Safar <marek.safar@gmail.com>
3062 A fix for bug #360755
3063 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3065 2008-08-29 Marek Safar <marek.safar@gmail.com>
3067 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3069 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3070 member name, it is too confusing
3072 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3074 * rootcontext.cs: Finally default to warning level 4.
3076 2008-08-28 Marek Safar <marek.safar@gmail.com>
3078 * class.cs (CheckBase): Ignore overloaded operators.
3080 2008-08-28 Marek Safar <marek.safar@gmail.com>
3082 A fix for bug #420830
3083 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3085 2008-08-28 Marek Safar <marek.safar@gmail.com>
3087 A fix for bug #420832
3088 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3090 2008-08-28 Marek Safar <marek.safar@gmail.com>
3092 A fix for bug #420386
3093 * nullables.cs: Fixed logic of nullable user comparison operators involving
3096 2008-08-28 Marek Safar <marek.safar@gmail.com>
3098 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3100 2008-08-27 Miguel de Icaza <miguel@novell.com>
3102 * repl.cs: Add support for aborting the running code with C-c.
3104 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3106 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3108 2008-08-27 Miguel de Icaza <miguel@novell.com>
3110 * cs-parser.jay (interactive_statement_list): A new set of rules
3111 for hosting statements that uses the "interactive_" prefix.
3113 * repl.cs: Add support for parsing `using' as a statement or as a
3114 directive. Deambiguating before passing this to the parser.
3116 We need to distinguish statement_expressions that occur at the
3117 toplevel vs those that occur embedded into expressions.
3119 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3120 that fixes the cursor key handling, and a history bug.
3122 2008-08-26 Miguel de Icaza <miguel@novell.com>
3124 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3125 limitations in Console, instead the 2.0 bootstrap libraries now
3126 include the Console bits.
3128 Also, remove the use of Nullables from getline.cs
3132 Interactive support for the C# compiler. Use gmcs --shell to
3133 enter a read-eval-print loop shell.
3135 Docs: http://www.mono-project.com/CsharpRepl
3137 * sources: include repl.cs here and getline.cs for gmcs.exe,
3138 everything else is getline.cs impaired.
3140 * Makefile: when bootstrapping pass a special flag
3141 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3142 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3143 This distinguishes those two cases.
3145 * repl.cs: Support for a read-eval-print loop. Will be soon
3146 refactored into eval support and then REPL on top of it.
3148 * ecore.cs: If a simplename lookup fails, before erroring out,
3149 if we are in EvalMode to resolve the name to a declaration in the
3152 This means that variable declarations that happened in previous
3153 classes (as repl puts every statement in a separate class) are
3154 made visible in this way.
3156 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3157 triggered an error due to the end of file being reached. This is
3158 used to do multi-line input, and notify the caller that the user
3159 needs to provide more text before a successful parse.
3161 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3162 to drive the evaluation with a custom wrapper.
3164 * driver.cs: Add support for --shell, and refactor some code to be
3167 * namespace.cs: Add support for serializing the contents of the
3168 namespaces and reloading them.
3170 * getline.cs: A managed implementation of ReadLine under
3171 X11/Apache2 license terms. Easy to embed in other applications as
3174 * namespace.cs: Add some functions to save and restore the
3177 * rootcontext.cs: New public field.
3179 * cs-tokenizer.cs: Add support for one of the possible characters
3180 we introduce into the token stream.
3182 This patch does not affect the regular tokenization process, the
3183 only performance hit would happen if there is an invalid character
3184 on the input string.
3186 * support.cs: Move isatty helper routine here.
3188 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3189 code generator for in-memory assemblies.
3191 2008-08-26 Marek Safar <marek.safar@gmail.com>
3193 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3194 parameter cannot be always used as a type.
3196 2008-08-21 Marek Safar <marek.safar@gmail.com>
3198 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3200 2008-08-21 Marek Safar <marek.safar@gmail.com>
3202 * convert.cs: Implement explicit array to IList<T> conversion.
3204 2008-08-20 Marek Safar <marek.safar@gmail.com>
3206 A fix for bug #362740
3207 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3209 2008-08-20 Marek Safar <marek.safar@gmail.com>
3211 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3212 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3213 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3214 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3215 handling to use just one type of infrastructure and deal with generics
3218 2008-07-23 Martin Baulig <martin@ximian.com>
3220 *** Merged this from trunk revision 108527 ***
3223 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3224 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3227 2008-08-15 Marek Safar <marek.safar@gmail.com>
3229 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3232 2008-08-15 Marek Safar <marek.safar@gmail.com>
3234 * delegate.cs: Fixed compiler crash when creating delegate using partial
3237 * typemanager.cs: MulticastDelegate is not a delegate.
3239 2008-08-14 Marek Safar <marek.safar@gmail.com>
3241 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3244 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3246 * cs-parser.jay (type): Allow 'var' in mcs too.
3247 (local_variable_type): Likewise.
3249 2008-08-14 Marek Safar <marek.safar@gmail.com>
3251 * driver.cs: Removed broken -noconfig variants.
3253 2008-08-14 Marek Safar <marek.safar@gmail.com>
3255 A fix for bug #417078
3256 * expression.cs: Emit correctly left side pointer operators.
3258 2008-08-13 Marek Safar <marek.safar@gmail.com>
3260 * generic.cs, lambda.cs: Inflate method generic arguments only.
3262 2008-08-12 Marek Safar <marek.safar@gmail.com>
3264 * class.cs: Fixed struct layout check regression.
3266 2008-08-12 Marek Safar <marek.safar@gmail.com>
3268 * cs-parser.jay, enum.cs: Simplified enum parsing.
3270 * decl.cs: Check all type parameters conflicts.
3272 * expression.cs, statement.cs, attribute.cs: More expression checks.
3274 2008-08-11 Marek Safar <marek.safar@gmail.com>
3276 * generic.cs: Add type inference types restriction.
3278 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3279 anonymous.cs, expression.cs: Allocate less accessor parameters.
3281 2008-08-08 Marek Safar <marek.safar@gmail.com>
3283 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3286 2008-08-08 Marek Safar <marek.safar@gmail.com>
3288 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3290 2008-08-07 Marek Safar <marek.safar@gmail.com>
3292 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3293 Also fixes #362146 and #381592.
3295 2008-08-07 Marek Safar <marek.safar@gmail.com>
3297 * ecore.cs: Reduced constant cannot be used as an attribute value.
3299 * cs-parser.jay: Base expression has to be a type.
3301 * expression.cs (Conditional): Uses ReducedExpression.
3303 2008-08-06 Marek Safar <marek.safar@gmail.com>
3305 A fix for bug #376826
3306 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3307 address of hoisted local variable or parameter cannot be taken.
3309 2008-08-05 Marek Safar <marek.safar@gmail.com>
3311 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3312 anonymous method inside checked/unchecked expression.
3314 2008-08-05 Marek Safar <marek.safar@gmail.com>
3316 * typemanager.cs (IsEqual): Guard against null.
3318 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3319 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3320 routine. Fixed few misleading conversion errors.
3322 2008-08-04 Marek Safar <marek.safar@gmail.com>
3324 * class.cs: Consider generics when checking cycles in struct layout.
3326 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3328 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3330 2008-08-04 Marek Safar <marek.safar@gmail.com>
3332 A fix for bug #414165
3333 * anonymous.cs: Use same anonymous implementation method for all anonymous
3336 2008-08-04 Marek Safar <marek.safar@gmail.com>
3338 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3341 2008-08-04 Marek Safar <marek.safar@gmail.com>
3343 * cs-parser.jay: Typeof argument has to be a type expression.
3345 * namespace.cs: Check alias and namespace definitions collisions.
3347 * class.cs, pending.cs: Moved explicit interface accessor implementation
3350 * delegate.cs, expression.cs: Verify special name invocations.
3352 2008-08-01 Marek Safar <marek.safar@gmail.com>
3354 * cs-parser.jay: Don't choke on empty generic type arguments.
3356 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3358 * expression.cs, ecore.cs: Minor expressions bugs.
3360 2008-08-01 Marek Safar <marek.safar@gmail.com>
3362 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3363 and added more error handling.
3365 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3367 * modifiers.cs, enum.cs: Fixed.
3369 2008-07-31 Jb Evain <jbevain@novell.com>
3371 * driver.cs: remove -pkg ability of smcs.
3373 2008-07-30 Marek Safar <marek.safar@gmail.com>
3375 * statement.cs (Switch): Correctly set empty default target for single
3378 2008-07-30 Marek Safar <marek.safar@gmail.com>
3380 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3381 string switch statement implementation to use string dictionary which
3382 significantly (2-8x) improves performance of generated code.
3384 2008-07-29 Marek Safar <marek.safar@gmail.com>
3386 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3387 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3389 2008-07-29 Marek Safar <marek.safar@gmail.com>
3391 A fix for bug #412595
3392 * typemanager.cs, convert.cs, expression.cs: Some types are never
3393 convertible to each other.
3395 2008-07-29 Marek Safar <marek.safar@gmail.com>
3397 * nullable.cs (CreateNullConstant): An error messages update.
3399 2008-07-29 Marek Safar <marek.safar@gmail.com>
3401 A fix for bug #412595
3402 * cfold.cs: Don't cast undefined bool constant.
3404 2008-07-29 Martin Baulig <martin@ximian.com>
3407 (SymbolWriter.Reset): New public static method.
3410 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3412 2008-07-28 Marek Safar <marek.safar@gmail.com>
3414 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3416 * expression.cs (ElementAccess): Exact size allocation.
3418 2008-07-26 Marek Safar <marek.safar@gmail.com>
3420 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3422 2008-07-25 Marek Safar <marek.safar@gmail.com>
3424 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3426 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3429 2008-07-25 Marek Safar <marek.safar@gmail.com>
3431 A fix for bug #412217
3432 * assign.cs: Mutate also assignment type.
3434 2008-07-25 Marek Safar <marek.safar@gmail.com>
3436 A fix for bug #323644
3437 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3440 2008-07-25 Marek Safar <marek.safar@gmail.com>
3442 A fix for bug #412134
3443 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3444 non-enumerable operands when overloading equality or bitwise operators.
3446 2008-07-25 Marek Safar <marek.safar@gmail.com>
3448 * anonymous.cs: Cache closed generic anonymous method delegates.
3450 2008-07-24 Marek Safar <marek.safar@gmail.com>
3452 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3453 anonymous.cs, statement.cs: Always emit anonymous method as static method
3454 when is instance free. Use nesting for nested anynomous methods blocks.
3456 2008-07-23 Marek Safar <marek.safar@gmail.com>
3458 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3461 2008-07-23 Marek Safar <marek.safar@gmail.com>
3463 * expression.cs: Removed MakeSimpleCall.
3465 2008-07-23 Marek Safar <marek.safar@gmail.com>
3467 A fix for bug #323012
3468 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3469 Base method implementing interface has to be public.
3471 2008-07-23 Marek Safar <marek.safar@gmail.com>
3473 * cs-parser.jay: Don't break on missing argument.
3475 2008-07-22 Marek Safar <marek.safar@gmail.com>
3477 A fix for bug #320993
3478 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3479 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3481 2008-07-22 Marek Safar <marek.safar@gmail.com>
3483 A fix for bug #320748
3484 * convert.cs: Implicit user operators cannot convert to interfaces
3486 2008-07-22 Marek Safar <marek.safar@gmail.com>
3488 A fix for bug #312686
3489 * driver.cs: Ignore empty assembly references.
3491 2008-07-22 Marek Safar <marek.safar@gmail.com>
3493 A fix for bug #387040
3494 * ecore.cs: Skip constrains check for an explicit implementation.
3496 2008-07-21 Marek Safar <marek.safar@gmail.com>
3498 A fix for bug #409045
3499 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3500 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3501 identifiers are file specific unless passed as input arguments.
3503 2008-07-21 Marek Safar <marek.safar@gmail.com>
3505 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3506 to emit UnmanagedMarshal data under 2.0 profile.
3508 2008-07-21 Marek Safar <marek.safar@gmail.com>
3510 A fix for bug #410369
3511 * parameter.cs: Clone correctly ParamsParameter.
3513 2008-07-21 Marek Safar <marek.safar@gmail.com>
3515 * expression.cs (Argument): Always report type for type based expressions
3518 2008-07-18 Marek Safar <marek.safar@gmail.com>
3520 A fix for bug #410666
3521 * anonymous.cs: Correctly initialize generic storey reference.
3523 2008-07-18 Marek Safar <marek.safar@gmail.com>
3525 * convert.cs: Don't box same type arguments.
3527 2008-07-18 Marek Safar <marek.safar@gmail.com>
3529 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3530 Finished missing generic type mutators.
3532 2008-07-18 Marek Safar <marek.safar@gmail.com>
3534 * iterators.cs, statement.cs: Finished statements CloneTo.
3536 2008-07-18 Marek Safar <marek.safar@gmail.com>
3538 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3540 * expression.cs: Emit optimized default value expressions in expression tree
3543 2008-07-18 Marek Safar <marek.safar@gmail.com>
3545 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3547 2008-07-17 Marek Safar <marek.safar@gmail.com>
3549 A fix for bug #367536
3550 * cs-parser.jay: Check static constructor of generic types for an access
3553 2008-07-17 Marek Safar <marek.safar@gmail.com>
3555 A fix for bug #353800
3556 * lambda.cs: Emit ret for contextual statements.
3558 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3559 up emitting redundant ret for all anonymous methods with return.
3561 2008-07-17 Marek Safar <marek.safar@gmail.com>
3563 A fix for bug #365188
3564 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3565 create anonymous method storey in unreachable block.
3567 2008-07-17 Marek Safar <marek.safar@gmail.com>
3569 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3570 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3571 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3572 statement.cs: Fixed relevant defects found by Gendarme.
3574 2008-07-17 Marek Safar <marek.safar@gmail.com>
3576 A fix for bug #325291
3577 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3578 statement.cs: Replaced IAnonymousHost with top level block flag.
3580 2008-07-17 Marek Safar <marek.safar@gmail.com>
3582 * cs-parser.jay: Clean up unused open_parens.
3584 2008-07-17 Marek Safar <marek.safar@gmail.com>
3586 * ecore.cs: Custom error message for a range variable assignment.
3588 2008-07-16 Marek Safar <marek.safar@gmail.com>
3590 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3593 2008-07-16 Marek Safar <marek.safar@gmail.com>
3595 * literal.cs: Null literal is of object type.
3597 2008-07-16 Marek Safar <marek.safar@gmail.com>
3599 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3600 expression of nullable equality comparison.
3602 2008-07-15 Marek Safar <marek.safar@gmail.com>
3604 * expression.cs(PointerArithmetic): Removed redundant assignment.
3606 2008-07-15 Marek Safar <marek.safar@gmail.com>
3608 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3610 2008-07-14 Marek Safar <marek.safar@gmail.com>
3612 A fix for bug #408361
3613 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3614 they are replaced by GetMethod.
3616 2008-07-14 Marek Safar <marek.safar@gmail.com>
3618 A fix for bug #408721 by jeremie.laval@gmail.com
3619 * expression.cs (Indirection): Implemented CloneTo.
3621 2008-07-14 Marek Safar <marek.safar@gmail.com>
3623 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3626 2008-07-14 Marek Safar <marek.safar@gmail.com>
3628 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3630 2008-07-11 Marek Safar <marek.safar@gmail.com>
3632 * linq.cs: Reset tranparent parameter counter in probing mode.
3634 2008-07-11 Marek Safar <marek.safar@gmail.com>
3636 * anonymous.cs: Mutate anonymous method type.
3638 2008-07-11 Marek Safar <marek.safar@gmail.com>
3640 * ecore.cs, anonymous.cs: Mutate field expressions.
3642 2008-07-10 Marek Safar <marek.safar@gmail.com>
3644 A fix for bug #369670
3645 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3647 2008-07-10 Marek Safar <marek.safar@gmail.com>
3649 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3651 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3654 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3655 only one '>', and finds a '>>', abort the generic lookahead.
3657 2008-07-10 Marek Safar <marek.safar@gmail.com>
3659 A fix for bug #319902
3660 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3662 2008-07-10 Marek Safar <marek.safar@gmail.com>
3664 A fix for bug #406371
3665 * statement.cs: Moved EmitSymbolInfo to Block.
3667 2008-07-09 Marek Safar <marek.safar@gmail.com>
3669 * ecore.cs: Report better error for extension method overload failures.
3671 2008-07-09 Marek Safar <marek.safar@gmail.com>
3673 * expression.cs (Is): No need to box reference values.
3675 2008-07-09 Marek Safar <marek.safar@gmail.com>
3677 * class.cs: Use event resolve context when initializing CreateEmitContext.
3679 2008-07-09 Marek Safar <marek.safar@gmail.com>
3681 A fix for bug #394436
3682 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3683 method used inside expression trees. Added more LINQ to expression tree
3686 2008-07-08 Marek Safar <marek.safar@gmail.com>
3688 A fix for bug #378189, #370577
3689 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3692 2008-07-08 Marek Safar <marek.safar@gmail.com>
3694 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3697 2008-07-08 Marek Safar <marek.safar@gmail.com>
3699 A fix for bug #406702
3700 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3702 2008-07-07 Marek Safar <marek.safar@gmail.com>
3704 A fix for bug #406648
3705 * cs-parser.jay: Report nullable use in mcs for some cases.
3707 2008-07-07 Marek Safar <marek.safar@gmail.com>
3709 * ecore.cs: Improved argument mismatch error messages.
3711 2008-07-07 Marek Safar <marek.safar@gmail.com>
3713 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3715 2008-07-07 Marek Safar <marek.safar@gmail.com>
3717 * expression.cs (TypeOf): Mutate type argument.
3719 2008-07-04 Marek Safar <marek.safar@gmail.com>
3721 * class.cs: Report missing partial modifier for correct type.
3723 2008-07-04 Marek Safar <marek.safar@gmail.com>
3725 * ecore.cs, expression.cs (VariableReference): Variable property is
3728 2008-07-04 Marek Safar <marek.safar@gmail.com>
3730 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3732 2008-07-04 Marek Safar <marek.safar@gmail.com>
3734 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3737 2008-07-04 Marek Safar <marek.safar@gmail.com>
3739 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3740 anonymous method storey to an instance method when only "this" is hoisted.
3742 2008-07-03 Marek Safar <marek.safar@gmail.com>
3744 A fix for bug #321615
3745 * expression.cs: Pointer comparisons use unsigned operator.
3747 2008-07-03 Marek Safar <marek.safar@gmail.com>
3749 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3751 2008-07-02 Marek Safar <marek.safar@gmail.com>
3753 A fix for bug #404905
3754 * class.cs: Always initialize local unsafe variables.
3756 2008-06-30 Marek Safar <marek.safar@gmail.com>
3758 A fix for bug #396987
3759 * expression.cs (NewInitialize): Clear local temporary variable for next run
3761 2008-06-27 Marek Safar <marek.safar@gmail.com>
3763 A fix for bug #401020
3764 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3766 2008-06-27 Marek Safar <marek.safar@gmail.com>
3768 A fix for bug #398319
3769 * cs-parser.jay: Implemented undocumented base access expression inside
3772 2008-06-26 Marek Safar <marek.safar@gmail.com>
3774 A fix for bug #404227
3775 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3777 2008-06-26 Marek Safar <marek.safar@gmail.com>
3779 A fix for bug #404227
3780 * convert.cs: Fixed explicit array to interface cast.
3782 2008-06-26 Marek Safar <marek.safar@gmail.com>
3784 A fix for bug #403894
3785 * delegate.cs: Mutate DelegateInvocation type.
3787 2008-06-26 Marek Safar <marek.safar@gmail.com>
3789 A fix for bug #379348
3790 * delegate.cs: Box a load of generic parameters.
3792 2008-06-26 Marek Safar <marek.safar@gmail.com>
3794 * expression.cs: Add an array creation arguments mutate.
3796 2008-06-26 Marek Safar <marek.safar@gmail.com>
3798 A fix for bug #386068
3799 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3802 2008-06-25 Marek Safar <marek.safar@gmail.com>
3804 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
3807 2008-06-25 Marek Safar <marek.safar@gmail.com>
3809 A fix for bug #403518
3810 * delegate.cs: Type correctly anonymous method new invocation.
3812 2008-06-24 Marek Safar <marek.safar@gmail.com>
3814 A fix for bug #394826
3815 * anonymous.cs: Fully qualify members when resolving anonymous type internal
3818 2008-06-24 Marek Safar <marek.safar@gmail.com>
3820 A fix for bug #394826
3821 * anonymous.cs, iterators.cs: Construct generic storey only when is really
3824 2008-06-24 Marek Safar <marek.safar@gmail.com>
3826 * class.cs: Clone indexer parameters for localized capturing.
3828 2008-06-24 Marek Safar <marek.safar@gmail.com>
3830 A fix for bug #402379
3831 * expression.cs: Don't crash when an object initializer resolve fails.
3833 2008-06-24 Marek Safar <marek.safar@gmail.com>
3835 A fix for bug #402888
3836 * expression.cs: Mutate conditional expression.
3838 2008-06-24 Marek Safar <marek.safar@gmail.com>
3840 A fix for bug #401012
3841 * class.cs: Keep StructLayout in shared container.
3843 2008-06-24 Marek Safar <marek.safar@gmail.com>
3845 A fix for bug #400438
3846 * decl.cs, class.cs: Only properties can be automatically implemented.
3848 2008-06-24 Marek Safar <marek.safar@gmail.com>
3850 * statement.cs (ChangeToIterator): Copy also labels.
3852 2008-06-23 Marek Safar <marek.safar@gmail.com>
3854 * ecore.cs: Pass type argument details to parent extension method.
3856 2008-06-23 Marek Safar <marek.safar@gmail.com>
3858 A fix for bug #375966
3859 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
3861 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
3863 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
3865 2008-06-22 Marek Safar <marek.safar@gmail.com>
3867 A fix for bug #394347
3868 * anonymous.cs: Cache compatible delegates as compatibility check produces
3869 a new method every time.
3871 2008-06-20 Marek Safar <marek.safar@gmail.com>
3873 * anonymous.cs: Propagate storey reference for single references.
3875 2008-06-20 Marek Safar <marek.safar@gmail.com>
3877 A fix for bug #387615
3878 * assign.cs, expression.cs: Correctly clone compound assignment.
3880 2008-06-19 Marek Safar <marek.safar@gmail.com>
3882 A fix for bug #359611, #359604
3883 * anonymous.cs: Mutate all types of hoisted parameters.
3885 2008-06-19 Marek Safar <marek.safar@gmail.com>
3887 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
3888 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
3889 expression.cs, codegen.cs, statement.cs
3891 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
3892 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
3894 ** Anonymous methods, lambda expressions rewrite **
3896 Anonymous expressions are now resolved when an explicit block is resolved
3897 and they don't require any registration procedure anymore. Further,
3898 anonymous methods are defined when explicit block is emitted which allows
3899 better control of whole process and opens possibilities for more
3900 optimizations as well as alternative to reverse whole process.
3902 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
3903 process consistent and to correctly emit hoisted generic methods when they
3904 have at least 1 hoisted variable.
3906 2008-06-17 Martin Baulig <martin@ximian.com>
3908 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
3910 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
3911 virtual property; check it in Emit().
3912 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
3914 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
3916 (Indexer.Define): Likewise.
3918 2008-06-17 Marek Safar <marek.safar@gmail.com>
3920 * convert.cs: Don't use IsInterface on type arguments.
3922 * delegate.cs: DelegateInvocation uses MethodInfo.
3924 * parameter.cs: Removed IsTypeParameter.
3926 * generic-mcs.cs: More missing stuff.
3928 2008-06-16 Martin Baulig <martin@ximian.com>
3931 (Modifiers.DEBUGGER_HIDDEN): New public const.
3934 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
3937 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
3938 (AbstractPropertyEventMethod): Likewise.
3939 (Constructor.Emit): Likewise.
3940 (SourceMethod.SetCompilerGenerated): Removed.
3942 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
3946 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
3947 if we're an `IteratorHost'.
3948 (AnonymousMethodMethod..ctor): Don't set
3949 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
3952 2008-06-16 Marek Safar <marek.safar@gmail.com>
3954 * statement.cs: Clean-up foreach statements.
3956 2008-06-12 Marek Safar <marek.safar@gmail.com>
3958 * class.cs: Stop using public method which should not exist
3959 (MethodBuilder.SetGenericMethodSignature).
3961 2008-06-11 Martin Baulig <martin@ximian.com>
3964 (Location.LookupFile): Add `CompilationUnit' argument; when given
3965 a relative file name, make it relative to the directory the .cs
3966 file is located in instead of using the current directory.
3968 2008-06-11 Martin Baulig <martin@ximian.com>
3971 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
3972 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
3973 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
3974 (SourceMethod.SetCompilerGenerated): Likewise.
3976 2008-06-11 Marek Safar <marek.safar@gmail.com>
3978 * codegen.cs, driver: Only write symbol file when it's asked for.
3980 2008-06-11 Marek Safar <marek.safar@gmail.com>
3982 * codegen.cs: Don't use assembly writer error handling for symbol writer.
3984 2008-06-10 Martin Baulig <martin@ximian.com>
3986 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
3988 2008-06-09 Marek Safar <marek.safar@gmail.com>
3990 A fix for bug #316290
3991 * expression.cs: Include decimal operators in predefined table.
3993 * parameters.cs: More readonlyness.
3995 2008-06-09 Marek Safar <marek.safar@gmail.com>
3997 A fix for bug #397213
3998 * cs-parser.jay: One more missing current_local_parameters reset.
4000 2008-06-09 Marek Safar <marek.safar@gmail.com>
4002 A fix for bug #396633
4003 * class.cs: Host backing field in partial container.
4005 2008-06-09 Marek Safar <marek.safar@gmail.com>
4007 A fix for bug #397068
4008 * expression.cs: Check both operand types when predefined operator is used.
4010 2008-06-05 Martin Baulig <martin@ximian.com>
4012 Merged the `debugger-kahalo' branch.
4015 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4016 we're an iterator method.
4017 (SourceMethod): Reflect latest symbol writer changes;
4018 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4019 now `start_row' and `end_row'.
4020 (Constructor.Emit): Fix the logic whether to emit symbol information.
4022 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4026 (CompilationUnit): New public class; derives from `SourceFile'.
4027 (SourceFileEntry.DefineSymbolInfo): New public method.
4028 (SourceFileEntry.SetChecksum): New public method.
4029 (Location): Encode hidden line numbers by using `column == 255';
4030 the .ctor now accepts `column == -1' to mark a hidden line number.
4031 (Location.Hidden): New public property.
4032 (Location.CheckPoint): Add `CompilationUnit'.
4033 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4034 (Location.Push): Add `CompilationUnit compile_unit' argument.
4035 (Location.CompilationUnit): New public property.
4038 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4040 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4042 * driver.cs: `SourceFile' -> `CompilationUnit'.
4044 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4046 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4048 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4052 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4053 new symbol writer API to also pass the file.
4055 2008-06-05 Marek Safar <marek.safar@gmail.com>
4057 * statement.cs: Emit catch variable assignment using variable expression.
4059 2008-06-05 Marek Safar <marek.safar@gmail.com>
4061 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4062 with other variable types.
4064 2008-06-04 Marek Safar <marek.safar@gmail.com>
4066 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4067 GetLength method emit, it breaks resolve rules.
4069 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4070 Marek Safar <marek.safar@gmail.com>
4072 A fix for bug #395542
4073 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4076 2008-06-02 Marek Safar <marek.safar@gmail.com>
4078 A fix for bug #395287
4079 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4081 2008-05-31 Marek Safar <marek.safar@gmail.com>
4083 A fix for bug #395845
4084 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4085 non-nullable parameter type.
4087 2008-05-31 Marek Safar <marek.safar@gmail.com>
4089 * class.cs: Handle contructor initializer as a statement in top-level block.
4091 2008-05-30 Marek Safar <marek.safar@gmail.com>
4093 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4094 security attributes.
4096 2008-05-24 Marek Safar <marek.safar@gmail.com>
4098 * ecore.cs, expression.cs: Small IVariable refactoring.
4100 2008-05-22 Marek Safar <marek.safar@gmail.com>
4102 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4104 2008-05-21 Marek Safar <marek.safar@gmail.com>
4106 * cs-parser.jay: Removed redundant catch type check.
4108 2008-05-21 Marek Safar <marek.safar@gmail.com>
4110 A fix for bug #390372
4111 * nullable.cs: Set correct return type.
4113 2008-05-21 Marek Safar <marek.safar@gmail.com>
4115 A fix for bug #391062
4116 * typemanager.cs: Fixed crash when comparing null types.
4118 2008-05-21 Marek Safar <marek.safar@gmail.com>
4120 A fix for bug #391871
4121 * cs-parser.jay: Better error handling for invalid catch type.
4123 2008-05-20 Marek Safar <marek.safar@gmail.com>
4125 A fix for bug #392155
4126 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4128 2008-05-15 Marek Safar <marek.safar@gmail.com>
4130 A fix for bug #390666
4131 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4134 2008-05-15 Marek Safar <marek.safar@gmail.com>
4136 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4139 2008-05-13 Marek Safar <marek.safar@gmail.com>
4141 A fix for bug #389625
4142 * delegate.cs, generic.cs: Some progress on method group return type
4145 2008-05-13 Marek Safar <marek.safar@gmail.com>
4147 A fix for bug #378419
4148 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4150 2008-05-12 Marek Safar <marek.safar@gmail.com>
4152 * class.cs (Constructor): Added IsCompilerGenerated.
4154 2008-05-12 Marek Safar <marek.safar@gmail.com>
4156 * expression.cs: Enum binary operators can accept non-enum operand only when
4157 is implicitly convertible to underlying type.
4159 2008-05-12 Marek Safar <marek.safar@gmail.com>
4161 A fix for bug #389272
4162 * support.cs: Workaround System.InvalidOperationException for enums.
4164 2008-05-12 Marek Safar <marek.safar@gmail.com>
4166 A fix for bug #389073
4167 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4169 2008-05-10 Marek Safar <marek.safar@gmail.com>
4171 * driver.cs: Split Parse.
4173 * location.cs (LookupFile): Uses string.Empty.
4175 2008-05-07 Marek Safar <marek.safar@gmail.com>
4177 * expression.cs, parameter.cs: Small ParameterReference clean up.
4179 2008-05-07 Marek Safar <marek.safar@gmail.com>
4181 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4182 hack. Fixes #387502.
4184 2008-05-06 Martin Baulig <martin@ximian.com>
4186 * class.cs (Constructor.Emit): Fix the logic whether to emit
4189 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4192 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4193 InvalidOperationException when the iterator is before the start or
4196 2008-05-06 Marek Safar <marek.safar@gmail.com>
4198 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4199 when left is nullable type.
4201 2008-05-06 Marek Safar <marek.safar@gmail.com>
4203 A fix for bug #386628
4204 * expression.cs (LocalVariableReference): Continue in resolving when
4205 variable is not assigned.
4207 2008-05-05 Marek Safar <marek.safar@gmail.com>
4209 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4210 nullable operations.
4212 2008-05-04 Marek Safar <marek.safar@gmail.com>
4214 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4215 it saves many redundant temporary variables for nullable operations.
4217 2008-05-03 Marek Safar <marek.safar@gmail.com>
4219 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4221 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4224 * nullable.cs: Constant coalescing operator optimizations.
4226 2008-05-03 Marek Safar <marek.safar@gmail.com>
4228 * constant.cs: Use unsigned conversion for values which are unsigned only.
4230 2008-05-03 Marek Safar <marek.safar@gmail.com>
4232 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4233 coalescing operator as it should be.
4235 2008-05-02 Marek Safar <marek.safar@gmail.com>
4237 A fix for bug #371016
4238 * expression.cs: All predefined delegate operators require implicit method
4241 2008-05-02 Marek Safar <marek.safar@gmail.com>
4243 * constant.cs: Emit long constant as uint when fits the range.
4245 * convert.cs, expression.cs: Fixed few unsafe conversions.
4247 2008-05-02 Marek Safar <marek.safar@gmail.com>
4249 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4251 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4254 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4256 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4258 2008-05-01 Marek Safar <marek.safar@gmail.com>
4260 * constant.cs, literal.cs: IsLiteral property for error reporting.
4262 * ecore.cs, expression.cs: Implemented Property expression.
4264 2008-05-01 Marek Safar <marek.safar@gmail.com>
4266 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4268 * nullable.cs: Implemented nullable coalescing null operator.
4270 * ecore.cs, expression.cs: Expression trees work.
4272 2008-05-01 Marek Safar <marek.safar@gmail.com>
4274 * ecore.cs: CreateExpressionTree is finally abstract.
4276 * expression.cs, linq.cs: Updated.
4278 2008-05-01 Marek Safar <marek.safar@gmail.com>
4280 * expression.cs, ecore.cs: Block base access expression inside expression
4283 2008-05-01 Marek Safar <marek.safar@gmail.com>
4285 A fix for bug #385058
4286 * expression.cs: User-defined operator implementations always take
4287 precedence over predefined operator implementations.
4289 2008-04-30 Marek Safar <marek.safar@gmail.com>
4291 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4292 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4293 expression tree conversions.
4295 2008-04-30 Marek Safar <marek.safar@gmail.com>
4297 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4298 operators method details to Operator class.
4300 2008-04-30 Marek Safar <marek.safar@gmail.com>
4302 * anonymous.cs: Pass unsafe flags to anonymous container.
4304 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4305 inside expression tree.
4307 2008-04-29 Martin Baulig <martin@ximian.com>
4309 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4310 (Tokenizer.PopPosition): Also restore the `line'.
4312 2008-04-29 Marek Safar <marek.safar@gmail.com>
4314 * delegate.cs: Implemented Invoke expression.
4316 2008-04-29 Marek Safar <marek.safar@gmail.com>
4318 * expression.cs: Fixed equality reference comparison regression.
4320 2008-04-29 Marek Safar <marek.safar@gmail.com>
4322 * ecore.cs: Clean up EmptyCast hack.
4324 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4325 using correct conversion rules. Also fixes #383993.
4327 2008-04-28 Martin Baulig <martin@ximian.com>
4329 * class.cs (Constructor.Emit): Don't emit debugging information
4330 for generated default .ctor's.
4332 2008-04-28 Marek Safar <marek.safar@gmail.com>
4334 * convert.cs: Empty-cast ushort to int conversion.
4336 2008-04-28 Marek Safar <marek.safar@gmail.com>
4338 A fix for bug #384191
4339 * ecore.cs, expression.cs: Fixed expression cloning.
4341 2008-04-28 Marek Safar <marek.safar@gmail.com>
4343 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4345 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4347 Fix #381559, test-638.cs, test-639.cs
4348 * assign.cs (CompoundAssign.Helper): New wrapper.
4349 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4351 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4352 Pass unconverted expressions to the params array creation expression.
4353 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4354 (PropertyExpr.EmitAssign): Likewise.
4355 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4356 element if it is of kind CompoundAssign.Helper.
4357 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4358 first before anything else.
4359 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4360 (ArrayAccess.LoadArrayAndArguments): Simplify.
4362 2008-04-27 Marek Safar <marek.safar@gmail.com>
4364 * expression.cs: Fixed cloning of typeof(void).
4366 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4368 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4369 (Assign.Emit): Likewise. Move it to ...
4370 (CompoundAssign.DoResolve): ... here and ...
4371 (CompoundAssign.Emit): ... here.
4372 (EventAddOrRemove): New helper to handle += and -= on events, and
4373 avoid the use of BinaryDelegates.
4374 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4375 (EventExpr.EmitAddOrRemove): Improve.
4376 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4378 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4379 create VarExprs for 'foo.bar.var'.
4380 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4381 is a highly inappropriate name for its functionality.
4383 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4385 Simplify handling of multiple assignments
4386 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4388 (SimpleAssign): New. Class to be used for normal assignments.
4389 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4390 * expression.cs, parameter.cs, statement.cs: Likewise.
4392 2008-04-25 Marek Safar <marek.safar@gmail.com>
4394 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4395 for incompatible underlying types, more to come, uff.
4397 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4400 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4401 Handle 'leave_copy'.
4403 2008-04-25 Marek Safar <marek.safar@gmail.com>
4405 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4407 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4409 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4410 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4411 * statement.cs (While, Do, For): Allow test to have side effects.
4412 (For.DoEmit): Always emit InitStatement.
4415 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4416 Always create SideEffectConstant.
4417 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4418 of type EnumConstant.
4420 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4421 Handle 'right' being SideEffectConstant of type 'bool'.
4423 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4424 Use left.EmitBranchable instead of open coding it, so as to
4425 improve optimization opportunities.
4427 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4429 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4431 (Expression.EmitSideEffect): Document.
4433 2008-04-23 Marek Safar <marek.safar@gmail.com>
4435 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4437 2008-04-23 Marek Safar <marek.safar@gmail.com>
4439 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4441 2008-04-23 Marek Safar <marek.safar@gmail.com>
4443 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4444 conversion to expression tree.
4446 2008-04-23 Marek Safar <marek.safar@gmail.com>
4448 * ecore.cs: Removed unused expression.
4450 2008-04-22 Marek Safar <marek.safar@gmail.com>
4452 * expression.cs: Implemented NegateChecked and New expressions.
4454 2008-04-22 Marek Safar <marek.safar@gmail.com>
4456 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4458 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4461 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4462 needing final 'ret' instruction.
4464 2008-04-22 Marek Safar <marek.safar@gmail.com>
4466 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4468 2008-04-21 Marek Safar <marek.safar@gmail.com>
4470 * expression.cs: Emit ldnull and not null expression as an instance argument
4471 of static method expression calls.
4473 2008-04-21 Marek Safar <marek.safar@gmail.com>
4475 A fix for bug #378200
4476 * expression.cs: Fixed crash when creating parameterless expression tree
4479 2008-04-21 Marek Safar <marek.safar@gmail.com>
4481 A fix for bug #375297
4482 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4485 2008-04-21 Marek Safar <marek.safar@gmail.com>
4487 A fix for bug #377596
4488 * decl.cs, class.cs: Emit delegate type argument attributes.
4490 2008-04-21 Marek Safar <marek.safar@gmail.com>
4492 A fix for bug #365314
4493 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4495 2008-04-21 Marek Safar <marek.safar@gmail.com>
4497 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4500 2008-04-21 Marek Safar <marek.safar@gmail.com>
4502 * generic.cs (TypeParameter): Removed redundant location.
4504 2008-04-19 Marek Safar <marek.safar@gmail.com>
4506 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4507 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4508 FullNamedExpression in all declaration type expression, statements will come
4511 2008-04-18 Marek Safar <marek.safar@gmail.com>
4513 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4514 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4516 2008-04-18 Marek Safar <marek.safar@gmail.com>
4518 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4521 2008-04-17 Marek Safar <marek.safar@gmail.com>
4523 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4526 2008-04-17 Marek Safar <marek.safar@gmail.com>
4528 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4532 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4534 Hook up 'EmitSideEffect'
4535 * constant.cs (Constant.EmitSideEffect): New.
4536 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4537 (SideEffectConstant.EmitSideEffect): New.
4538 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4539 unconditional branch in EmitBranchable.
4540 (FieldExpr.EmitBranchable): New.
4541 * expression.cs (Unary.EmitSideEffect): New.
4542 (Binary.EmitSideEffect): New.
4543 (VariableReference.EmitSideEffect): New. Do nothing.
4545 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4547 Introduce 'EmitSideEffect'
4548 * ecore.cs (Expression.EmitSideEffect): New.
4549 (TypeCast): Rename from EmptyCast.
4551 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4552 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4553 * convert.cs, nullable.cs: Update to changes.
4555 2008-04-16 Marek Safar <marek.safar@gmail.com>
4557 * class.cs, cs-parser.jay: Early check for base types expression.
4559 2008-04-16 Marek Safar <marek.safar@gmail.com>
4561 * decl.cs (MemberName): Declare PrettyName as obsolete.
4563 2008-04-16 Marek Safar <marek.safar@gmail.com>
4565 * namespace.cs: Use MemberName comparison.
4567 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4570 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4572 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4573 (MemberName.FullyQualifiedName): New. Provides the functionality
4574 that users assume FullName would have.
4575 * ecore.cs, namespace.cs: Update to changes.
4577 * statement.cs (Using.assign): Make into ExpressionStatement.
4578 (Using.EmitPreTryBody): Simplify.
4580 2008-04-16 Marek Safar <marek.safar@gmail.com>
4582 * report.cs: ColorFormat is protected.
4584 * rootcontext.cs: Unused fields clean-up.
4586 * namespace.cs: Made UsingEntry name private.
4588 2008-04-16 Marek Safar <marek.safar@gmail.com>
4590 * cs-tokenizer.cs, location.cs: Removed unused field.
4592 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4593 Raja R Harinath <harinath@hurrynot.org>
4596 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4597 (SideEffectConstant.side_effect): Rename from 'right'.
4598 (SideEffectConstant..ctor): Normalize 'side_effect'.
4599 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4600 value of this constant.
4601 * cfold.cs: Update to changes.
4603 2008-04-15 Marek Safar <marek.safar@gmail.com>
4605 * cs-paser.jay: Removed unused variable.
4607 * driver.cs: Made Compile instance method.
4609 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4611 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4613 2008-04-15 Marek Safar <marek.safar@gmail.com>
4615 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4617 2008-04-13 Jb Evain <jbevain@novell.com>
4619 * namespace.cs: update the System.Core fullname for 2.1
4620 * driver.cs: update the list of required assemblies for 2.1.
4621 Merged from the Moonlight 2 branch.
4623 2008-04-11 Marek Safar <marek.safar@gmail.com>
4625 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4626 types and user defined operators. User operators arguments has to be checked
4627 for null value before invocation, which also means no operator is called
4628 when any argument is not convertible to unwrapped nullable type.
4630 2008-04-09 Marek Safar <marek.safar@gmail.com>
4632 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4633 of Unary expressions to follow operator overloading rules precisely.
4634 Also fixes #321794, #323794
4636 2008-04-08 Marek Safar <marek.safar@gmail.com>
4638 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4641 2008-04-08 Marek Safar <marek.safar@gmail.com>
4643 * expression.cs, ecore.cs: Implemented MemberInit expression.
4645 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4647 Fix mono/tests/exception4.cs
4648 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4649 ec.NeedReturnLabel () rather emitting a 'nop'.
4651 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4653 (TryCatch.SomeCodeFollows): Likewise.
4654 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4655 for 'break', 'continue' and 'return' statements inside a try.
4656 We're fairly sure that the generated IL stream will have more
4657 instructions textually following the try.
4658 (FlowBranchingTryCatch): Likewise.
4660 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4661 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4664 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4665 wrapper -- forward everything to CollectionForeach.
4666 (CollectionForeach.NonDisposableWrapper): New.
4667 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4668 instead of a pop + branch to end.
4670 2008-04-07 Marek Safar <marek.safar@gmail.com>
4672 A fix for bug #377485
4673 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4674 Propagate location for extension method groups. Report conversion failure at
4677 2008-04-07 Marek Safar <marek.safar@gmail.com>
4679 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4680 ListInit and Field expressions.
4682 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4684 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4685 Since $PC is always -1 inside the body of MoveNext, the fault
4687 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4688 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4689 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4691 The denouement! Fix #324708
4692 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4693 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4694 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4695 'finally' inside the finally clause.
4697 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4698 inside an iterator. Don't emit the body of the 'finally' inside
4699 the finally clause yet.
4701 Use the ResumableStatement infrastructure for MoveNext ()
4702 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4703 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4704 'old_resume_points'. Move dispatcher upfront.
4705 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4706 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4707 in an enumerator. This encodes the main fix in this patch series
4708 -- we can only jump into the first instruction of a try from the
4709 outside, but we want to emit try/finally regions in iterators and
4710 resume in the middle of them.
4712 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4714 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4715 of NeedReturnLabel here.
4717 Introduce a common point for emitting try/finally to IL
4718 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4719 features of the various subclasses, which are now driven by ...
4720 (ExceptionStatement.EmitPreTryBody): ... this and ...
4721 (ExceptionStatement.EmitTryBody): ... this and the original
4723 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4724 Remove DoEmit and update to follow above protocol.
4726 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4727 of the dispatcher are the same, skip emitting the 'switch'.
4728 * iterator.cs (Iterator.EmitDispose): Update to changes.
4730 Clean up handling of 'using' statement
4731 * statement.cs (UsingTemporary): New. Carved out of ...
4732 (Using): ... this. Simplify drastically. Handle exactly
4734 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4735 or Using as appropriate. If there are multiple variable declared,
4736 create nested Using statements.
4737 (resource_acquisition): Kill.
4739 * statement.cs (ExceptionStatement.EmitForDispose): Use
4740 EmitFinallyBody, not EmitFinally.
4742 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4743 * iterator.cs: Update to changes.
4745 Start using the ResumableStatement infrastructure
4746 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4747 (ResumableStatement.EmitForDispose): New.
4748 (ExceptionStatement): Override them.
4749 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4750 EmitForDispose to create the body of the Dispose method. Don't
4753 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4754 * statement.cs (Toplevel.AddResumePoint): ... here.
4755 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4756 * flowanalysis.cs (FlowBranchingIterator): New.
4757 * codegen.cs (EmitContext): Update to changes.
4759 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4760 (Iterator.old_resume_points): Rename from 'resume_points'.
4761 (Iterator.MoveNextStatement): Remove unused class.
4763 New infrastructure for try/finally in iterators (still unused)
4764 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4765 (FlowBranchingToplevel.AddResumePoint): Hook into
4766 ToplevelBlock.AddResumePoint.
4767 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4768 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4769 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4770 resume points and assign program-counter values.
4771 (ExceptionBlock.AddResumePoint): Collect resume points for
4772 de-muxer at the top of try block.
4773 * iterators.cs (Yield.CheckContext): Simplify.
4774 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4776 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4778 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4779 argument to an ExitStatement.
4780 (FlowBranchingException): Refactor saved origins code.
4781 * statement.cs (ExitStatement): Update to cahges.
4782 * iterator.cs (YieldBreak): Likewise.
4784 * statement.cs (ResumableStatement): New. Common base class for
4785 YieldReturn and ExceptionStatement.
4786 (ExitStatement): New. Common base class for Return and YieldBreak.
4787 (Return): Update to changes.
4788 * iterator.cs (YieldBreak): Likewise.
4789 * lambda.cs (ContextualReturn): Likewise.
4792 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4793 emit a meaningful error message.
4795 Fix #324765, #319508
4796 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4797 (VariableInfo.SetAssigned): Set it.
4798 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4799 determine if CS0219 or CS0168 is appropriate. Don't use
4800 flow-analysis information.
4801 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4802 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4803 (EmitContext.EndFlowBranching): ... this.
4805 2008-04-03 Marek Safar <marek.safar@gmail.com>
4807 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
4809 2008-04-03 Marek Safar <marek.safar@gmail.com>
4811 A fix for bug #376508
4812 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
4813 ImplicitConversionExists.
4815 2008-04-03 Marek Safar <marek.safar@gmail.com>
4817 * expression.cs (Binary): Added remaining binary operators to expression
4820 * nullable.cs: Optimize shift with null argument.
4822 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
4824 Fix minor IL regression
4825 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
4826 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
4827 * cs-parser.jay (try_statement): Update to changes.
4829 * statement.cs (TryFinally.need_exc_block): Delete.
4830 (TryFinally): Update to changes.
4832 Now all ExceptionStatements are unconditional
4833 * statement.cs (CollectionForeach.DisposableWrapper): New.
4834 Extract out the try/finally code into a new wrapper.
4835 (CollectionForeach.Resolve): Use it to simplify the code.
4837 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
4839 Start at simplifying ExceptionStatement semantics a bit
4840 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
4841 * cs-parser.jay (try_statement): Update to changes.
4842 (opt_catch_clauses): Remove.
4843 * flowanalysis.cs: Update to changes.
4844 (FlowBranching.BranchingType.TryCatch): New.
4845 (FlowBranchingTryCatch): New.
4847 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
4848 (FlowBranching.CreateBranching): Update to changes.
4849 (FlowBranchingBlock.AddSibling): Add sanity check.
4850 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
4853 * iterators.cs (Iterator.MarkFinally): Remove.
4854 * statement.cs (ExceptionStatement): Update to changes.
4856 Add support for skipping over finally blocks at runtime. First
4857 in a series to fix #324708
4858 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
4859 (Iterator.EmitMoveNext): Initialize it.
4860 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
4861 branch over the body of the 'finally' clause.
4863 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
4865 Avoid lopsided use of Foo/DoFoo names
4866 * statement.cs (ExpressionStatement.EmitFinallyBody):
4867 Rename from EmitFinally.
4868 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
4869 * iterator.cs: Update to changes.
4871 2008-04-02 Marek Safar <marek.safar@gmail.com>
4873 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
4874 based on UserOperatorCall. More binary nullable operators clean up.
4876 2008-04-02 Martin Baulig <martin@ximian.com>
4878 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
4880 2008-04-02 Marek Safar <marek.safar@gmail.com>
4882 * nullable.cs: Merge user and empty conversions when lifting expression
4885 * expression.cs (StringConcat): Implemented expression tree representation.
4887 2008-04-01 Marek Safar <marek.safar@gmail.com>
4889 * nullable.cs: When lifting null literal and a user operator exists, no call
4892 2008-04-01 Marek Safar <marek.safar@gmail.com>
4894 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
4897 2008-04-01 Marek Safar <marek.safar@gmail.com>
4899 * nullable.cs, expression.cs: Use namespace instead heavily nested
4900 monster abstract class.
4902 2008-04-01 Marek Safar <marek.safar@gmail.com>
4904 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
4905 lifting of null literal and user operators. Clean up of some temporary
4908 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
4910 Fix #368224, test-629.cs
4911 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
4912 if it crossed an unwind-protect boundary.
4913 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
4914 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
4915 inside an unwind-protected region.
4916 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
4917 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
4918 'leave' instead of a 'br' if unwind-protected.
4919 (Iterator.EmitYieldBreak): Likewise.
4921 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
4923 * driver.cs: Only define versioninfo resources if no win32 resource
4926 2008-03-28 Marek Safar <marek.safar@gmail.com>
4928 A fix for bug #372375
4929 * convert.cs: Fixed boxing of nullable types.
4931 2008-03-28 Marek Safar <marek.safar@gmail.com>
4933 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
4936 2008-03-28 Marek Safar <marek.safar@gmail.com>
4938 A fix for bug #374619
4939 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
4941 2008-03-27 Marek Safar <marek.safar@gmail.com>
4943 * lambda.cs: Check return type only for invocation.
4945 2008-03-27 Marek Safar <marek.safar@gmail.com>
4947 A fix for bug #374214
4948 * ecore.cs: Correctly report argument type mismatch.
4950 2008-03-27 Marek Safar <marek.safar@gmail.com>
4952 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
4953 and not rely on broken IsEnum.
4955 2008-03-27 Marek Safar <marek.safar@gmail.com>
4957 * nullable.cs: New file, extracted from generic.cs.
4959 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
4961 2008-03-27 Marek Safar <marek.safar@gmail.com>
4963 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
4964 predefined comparison operators and null literals.
4966 * report.cs: New warning ID.
4968 2008-03-25 Marek Safar <marek.safar@gmail.com>
4970 A fix for bug #370577
4971 * lambda.cs: Check return type too.
4973 2008-03-25 Marek Safar <marek.safar@gmail.com>
4975 A fix for bug #372846
4976 * class.cs: Automatic properties can be declared as unsafe.
4978 2008-03-20 Marek Safar <marek.safar@gmail.com>
4980 * location.cs: Use string based concatenation.
4982 * expression.cs: LiftedBinaryOperator is gmcs only.
4984 2008-03-20 Marek Safar <marek.safar@gmail.com>
4986 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
4987 conversions rules and expression trees.
4989 2008-03-19 Marek Safar <marek.safar@gmail.com>
4991 * delegate.cs: Use extension method source as delegate target.
4993 2008-03-19 Marek Safar <marek.safar@gmail.com>
4995 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
4996 binary operations to be purely based on binary operations and optimized
4997 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
4998 and other ET refactoring.
5000 * typemanager.cs: Fixed warning.
5002 2008-03-17 Marek Safar <marek.safar@gmail.com>
5004 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5006 * symbolwriter.cs: Fixed.
5008 2008-03-17 Marek Safar <marek.safar@gmail.com>
5010 * anonymous.cs, driver.cs: Reset anonymous types counters.
5012 2008-03-17 Marek Safar <marek.safar@gmail.com>
5014 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5016 * class.cs: Use fullname for all type member definitions.
5018 2008-02-19 Martin Baulig <martin@ximian.com>
5021 (IMethodData.EmitExtraSymbolInfo): New interface method.
5022 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5023 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5024 interface method here as an empty public virtual method.
5027 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5028 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5029 CodeGen.SymbolWriter.SetRealMethodName().
5031 2008-02-18 Martin Baulig <martin@ximian.com>
5034 (ScopeInfo.EmitType): Override this and emit debugging
5035 information for captured variables.
5036 (RootScopeInfo.EmitType): Override this and emit symbol
5037 information for a captured `this'.
5039 2008-02-15 Martin Baulig <martin@ximian.com>
5041 * iterators.cs: Emit debugging info.
5044 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5045 (EmitContext.OmitDebuggingInfo): New public property.
5048 (While): Override Emit() and don't emit symbol info there; do it
5049 inside DoEmit() instead.
5050 (Block.Emit): Omit symbol information while emitting the scope
5051 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5053 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5054 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5055 .ctor to make `IsIterator' work.
5057 2008-03-14 Martin Baulig <martin@ximian.com>
5059 * symbolwriter.cs: Added the new symbol writer function from the
5060 debugger's `terrania' branch; temporarily enclose them inside
5061 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5064 2008-03-14 Martin Baulig <martin@ximian.com>
5067 (SymbolWriter): Make this a public static class.
5070 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5071 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5073 2008-03-14 Marek Safar <marek.safar@gmail.com>
5075 A fix for bug #370577
5076 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5079 2008-03-14 Marek Safar <marek.safar@gmail.com>
5081 * typemanager.cs (CSharpName): Made 250 times faster.
5083 2008-03-13 Marek Safar <marek.safar@gmail.com>
5085 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5087 2008-03-12 Marek Safar <marek.safar@gmail.com>
5089 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5090 crash when predefined field does not exist.
5092 2008-03-12 Marek Safar <marek.safar@gmail.com>
5094 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5096 2008-03-12 Marek Safar <marek.safar@gmail.com>
5098 * class.cs (FixedField): Don't crash when contructors are missing.
5100 2008-03-11 Marek Safar <marek.safar@gmail.com>
5102 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5103 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5104 check internal types accessibility for internal and external types.
5105 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5107 2008-03-11 Marek Safar <marek.safar@gmail.com>
5109 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5110 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5111 attribute.cs, statement: Use corect instance of predefined types (work
5112 related to #364674).
5114 2008-03-07 Marek Safar <marek.safar@gmail.com>
5116 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5118 2008-03-07 Marek Safar <marek.safar@gmail.com>
5120 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5121 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5122 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5123 predefined types clean up, delayed predefined types members initialization
5124 (work related to #364674).
5126 2008-03-05 Marek Safar <marek.safar@gmail.com>
5128 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5130 2008-03-05 Marek Safar <marek.safar@gmail.com>
5132 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5133 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5134 predefined types clean up (work related to #364674).
5136 2008-03-04 Marek Safar <marek.safar@gmail.com>
5138 * ecore.cs: Print an error message instead of throwing exception.
5140 2008-03-04 Marek Safar <marek.safar@gmail.com>
5142 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5143 expression.cs, statement.cs: Unififed null literal representation.
5145 2008-03-03 Marek Safar <marek.safar@gmail.com>
5147 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5148 expression.cs: Refactored binary operators resolve phase and improved speed.
5149 The nullable code is still missing and won't work correctly, more fixes
5152 It also fixes #323726, #324312, #324248, and many other unreported issues.
5154 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5156 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5159 2008-02-27 Marek Safar <marek.safar@gmail.com>
5161 * ecore.cs: Clean-up and split BetterConversion.
5163 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5166 * enum.cs (EnumMember.Value): Only access 'value' if
5167 ResolveValue says it's ok.
5168 (EnumMember.DoResolveValue): Don't set prev_member.value.
5169 (Enum.GetDefinition): Reverse arguments of Equals --
5170 EnumMember.Value can return 'null'.
5172 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5174 2008-02-22 Marek Safar <marek.safar@gmail.com>
5176 * generic.cs, expression.cs: More ongoing work on expression trees.
5178 2008-02-21 Marek Safar <marek.safar@gmail.com>
5180 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5181 handle missing matches when mutiple operators exist.
5183 2008-02-20 Marek Safar <marek.safar@gmail.com>
5185 A fix for bug #363218
5186 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5189 2008-02-20 Marek Safar <marek.safar@gmail.com>
5191 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5192 update. This time to deal correctly with SideEffectConstant expression used
5193 as an argument for another constant folding.
5195 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5197 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5200 2008-02-19 Marek Safar <marek.safar@gmail.com>
5202 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5204 2008-02-19 Marek Safar <marek.safar@gmail.com>
5206 A fix for bug #328136
5207 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5208 side is a false constant, because we still need to evaluate the right-hand
5211 * statement.cs (If): Emit two types of boolean constants (simple constant,
5212 side-effect constant).
5214 2008-02-19 Marek Safar <marek.safar@gmail.com>
5216 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5218 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5221 2008-02-18 Marek Safar <marek.safar@gmail.com>
5223 A fix for bug #361457
5224 * ecore.cs (IsApplicable): Params methods have lower priority.
5226 * support.cs: Return correct parameter modifier for params types.
5228 2008-02-18 Marek Safar <marek.safar@gmail.com>
5230 * generic.cs (TypeParameter): Cache attribute target name.
5232 * support.cs: Removed unused variable.
5234 * typemanager.cs: Removed debugging leftover.
5236 * ecore.cs: Use local type instead of a property;
5238 * class.cs (VerifyMembers): Consider also parent to test whether type member
5241 * expression.cs (FullMethodDesc): Removed.
5243 * attribute.cs (IsValidArgumentType): Made static.
5245 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5247 Cleanup to be more readable.
5248 * Makefile (GMCS_PROFILE): Remove.
5249 (COMPILER_NAME): New helper.
5251 2008-02-15 Miguel de Icaza <miguel@novell.com>
5253 * cs-tokenizer.cs: if a conditional expression happens inside a
5254 (...) this also means that we do not need to de-ambiguate between
5255 an parenthesized expression and a cast.
5259 * constant.cs (SideEffectConstant): a constant value that happens
5260 to have a side effect.
5262 Fixes the build regressions introduced by the fix for #359789
5264 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5266 * expression.cs (Conditional.Emit): when emitting the ternary
5267 operator, use local variables to generate code verifiable code.
5269 The verifier cannot infer that the type on stack before the
5270 stloc.0 is executed is of type ParentB. This happens because the
5271 stack merge algorithm uses only parent types when deciding which
5272 is the common type. This is described in Part III 1.8.1.3 of ECMA
5275 This code compiled with mcs is not verifiable under MS. The MS
5276 verifier picks the first common interface of Foo and Bar, which is
5277 wrong, but doesn't use a full join type of the 2 interfaces.
5279 CSC uses a clever hack to compile such code in a verifiable
5280 way. It stores the intermediate values in a local variable with
5285 2008-02-14 Miguel de Icaza <miguel@novell.com>
5287 * expression.cs: Do not fold BitwiseAnd operators when the left
5288 side is a false constant, because we still need to evaluate the
5293 * support.cs: Instead of throwing an InternalErrorException when
5294 the position of the stream is outside the boundary of our buffer,
5295 reset the state of the reader, and restart the reading from the
5296 beginning of the file.
5298 2008-02-14 Marek Safar <marek.safar@gmail.com>
5300 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5302 2008-02-14 Marek Safar <marek.safar@gmail.com>
5304 A fix for bug #361686
5305 * decl.cs: A protected types used inside a private class which parents
5306 derives from the protected class are accessible.
5308 2008-02-13 Marek Safar <marek.safar@gmail.com>
5310 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5311 the parameterless constructor.
5313 2008-02-13 Marek Safar <marek.safar@gmail.com>
5315 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5316 lookup methods to use standard member cache when doing member lookup.
5318 2008-02-12 Marek Safar <marek.safar@gmail.com>
5320 * driver.cs: Don't report full path for referenced module as assembly error.
5322 2008-02-12 Marek Safar <marek.safar@gmail.com>
5324 * Makefile: Fixed `qh' target to work on all machines.
5326 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5327 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5328 and HasElementType with TypeManager implementation.
5330 2008-02-08 Marek Safar <marek.safar@gmail.com>
5332 A fix for bugs #325134, #359749
5333 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5334 first binds point to non-method member expression.
5336 2008-02-08 Marek Safar <marek.safar@gmail.com>
5338 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5340 2008-02-08 Marek Safar <marek.safar@gmail.com>
5342 A fix for bugs #321394, #323028
5343 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5344 Reworked naive IsAccessibleAs implementation to handle nested types.
5346 2008-02-05 Jb Evain <jbevain@novell.com>
5348 * class.cs: use generic type comparison for parameters
5351 2008-02-05 Marek Safar <marek.safar@gmail.com>
5353 A fix for bug #325372
5354 * class.cs: Use generic type comparison when testing method signatures.
5356 2008-02-05 Marek Safar <marek.safar@gmail.com>
5358 A fix for bug #357047
5359 * ecore.cs: Applied C# 3.0 changes to better conversion.
5361 2008-02-05 Marek Safar <marek.safar@gmail.com>
5363 A fix for bug #358374
5364 * cs-parser.jay: Correctly set modifiers for all constructor types.
5366 2008-02-04 Marek Safar <marek.safar@gmail.com>
5368 A fix for bug #355251
5369 * generic.cs: Added base class constraint based type inference.
5371 2008-02-01 Marek Safar <marek.safar@gmail.com>
5373 A fix for bug #357255
5374 * decl.cs: One more missing visibility check.
5376 2008-02-01 Marek Safar <marek.safar@gmail.com>
5378 * support.cs: Fixed broken return.
5380 2008-01-25 Marek Safar <marek.safar@gmail.com>
5382 * report.cs: Correctly reset warnings count after probing.
5384 2008-01-25 Martin Baulig <martin@ximian.com>
5387 (NamespaceEntry.SymbolFileID): Make this work again after
5388 MemberName.ToString() is gone.
5390 2008-01-25 Marek Safar <marek.safar@gmail.com>
5392 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5395 2008-01-25 Marek Safar <marek.safar@gmail.com>
5397 * generic.cs: Use full implicit conversion for type inference fixing.
5399 2008-01-24 Marek Safar <marek.safar@gmail.com>
5401 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5402 Fixed user operator conversions.
5404 2008-01-24 Marek Safar <marek.safar@gmail.com>
5406 * generic.cs: Do nullable type to null comparison optimization during
5409 2008-01-24 Marek Safar <marek.safar@gmail.com>
5411 A fix for bug #355163
5412 * generic.cs: Enabled l-value resolve on nullable expressions.
5414 2008-01-24 Marek Safar <marek.safar@gmail.com>
5416 A fix for bug #353986
5417 * class.cs: Ingore static ctors with parameters for any further checks.
5419 2008-01-24 Marek Safar <marek.safar@gmail.com>
5421 A fix for bug #354310
5422 * namespace.cs: Removed redundant check.
5424 2008-01-24 Marek Safar <marek.safar@gmail.com>
5426 A fix for bug #354928
5427 * expression.cs: ElementInitializers can be resolved only once.
5429 2008-01-24 Marek Safar <marek.safar@gmail.com>
5431 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5432 Condition expressions.
5434 2008-01-23 Marek Safar <marek.safar@gmail.com>
5436 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5438 2008-01-22 Marek Safar <marek.safar@gmail.com>
5440 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5443 * generic.cs: Implemented coalesce expression.
5445 2008-01-22 Marek Safar <marek.safar@gmail.com>
5447 A fix for bug #355145
5448 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5449 expression tree type inference.
5451 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5454 * expression.cs (Binary.IsUnsignedType): Fix typo.
5456 2008-01-22 Marek Safar <marek.safar@gmail.com>
5458 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5460 2008-01-22 Marek Safar <marek.safar@gmail.com>
5462 A fix for bug #355161
5463 * ecore.cs, expression.cs: Wider range of extension method supported
5466 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5468 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5469 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5472 2008-01-22 Marek Safar <marek.safar@gmail.com>
5474 A fix for bug #355148
5475 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5477 2008-01-22 Miguel de Icaza <miguel@novell.com>
5479 * expression.cs (CreateExpressionTree): Add support for or and
5480 logical or, and indent following the coding conventions.
5482 * typemanager.cs (LinqExpression): renamed from
5483 ExpressionTreeManager, for a shorter name.
5485 Use TypeManager.CoreLookupType to lookup types from our core
5486 assemblies and turn those into "Type" variables.
5488 Consumers that previously used "Namespace" and "Type" from this
5489 class should instead use the TypeExpression which is a type that
5490 is fully resolved (without involving the regular C# resolution
5493 This typically looks like this:
5495 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5496 new MemberAccess (texpr, name, type_arguments, loc)
5498 This avoids the problem in: #355178
5500 2008-01-21 Marek Safar <marek.safar@gmail.com>
5502 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5503 feature in parser only as we do in other cases.
5505 2008-01-21 Marek Safar <marek.safar@gmail.com>
5507 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5508 typemanager.cs: A refactoring of params arguments to reuse existing
5509 expressions (params -> array initializer) to emit params argument instead
5510 of specialized handling.
5511 It was required by expression tree implementation and it has other benefits
5512 as well, we now apply same optimization for params arguments as we do for
5515 2008-01-18 Marek Safar <marek.safar@gmail.com>
5517 A fix for bug #353526
5518 * generic.cs: A type inference of params arguments may not required any
5519 temporary array creation.
5521 2008-01-18 Marek Safar <marek.safar@gmail.com>
5523 A fix for bug #353534
5524 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5525 supported for delegates only.
5527 2008-01-18 Marek Safar <marek.safar@gmail.com>
5529 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5530 type for more than 1 candidates.
5532 2008-01-18 Marek Safar <marek.safar@gmail.com>
5534 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5537 2008-01-16 Marek Safar <marek.safar@gmail.com>
5539 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5540 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5541 operator) expressions.
5543 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5545 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5546 not accessed from the generated IL.
5548 2008-01-14 Marek Safar <marek.safar@gmail.com>
5550 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5551 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5552 statement.cs: The first expression tree implementation drop, mostly
5553 infrastructure work.
5555 2008-01-14 Marek Safar <marek.safar@gmail.com>
5557 * ecore.cs (IsNestedChild): Refactored.
5559 2008-01-11 Marek Safar <marek.safar@gmail.com>
5561 * lambda.cs: Don't use a cast on unknown expression statement.
5563 2008-01-10 Geoff Norton <gnorton@novell.com>
5565 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5568 2008-01-09 Marek Safar <marek.safar@gmail.com>
5570 * doc.cs: Report better /doc crash details.
5572 2008-01-09 Marek Safar <marek.safar@gmail.com>
5574 A fix for bug #352536
5575 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5577 2008-01-08 Marek Safar <marek.safar@gmail.com>
5579 A fix for bug #352287
5580 * ecore.cs, expression.cs: Do `this' access checking in all member access
5583 2008-01-08 Marek Safar <marek.safar@gmail.com>
5585 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5587 * report.cs: Reset message stacks.
5589 2008-01-08 Marek Safar <marek.safar@gmail.com>
5591 * generic.cs (InferInPhases): Correctly calculate params position.
5593 2008-01-08 Marek Safar <marek.safar@gmail.com>
5595 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5598 2008-01-07 Marek Safar <marek.safar@gmail.com>
5600 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5602 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5604 * driver.cs: Updated --help option.
5606 2008-01-07 Marek Safar <marek.safar@gmail.com>
5608 * generic.cs (InferParamsTypeArguments): Removed.
5609 (InferInPhases): Add params type inference.
5610 (LowerBoundInference): Fixed scoring mechanism.
5612 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5614 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5616 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5617 byte array for unsigned "baked" assemblies.
5619 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5621 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5622 array for assemblies that are not strongnamed.
5624 2008-01-04 Marek Safar <marek.safar@gmail.com>
5626 A fix for bug #351481
5627 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5628 declaring type for nested generic types.
5630 2008-01-04 Marek Safar <marek.safar@gmail.com>
5632 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5633 instead of ToString.
5635 2008-01-03 Marek Safar <marek.safar@gmail.com>
5637 A fix for bug #351047
5638 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5639 null and structs only when equality and inequality operators are defined
5640 either as an user-operators or predefined operators.
5642 2008-01-03 Marek Safar <marek.safar@gmail.com>
5644 A fix for bug #351047
5645 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5647 2008-01-03 Marek Safar <marek.safar@gmail.com>
5649 A fix for bug #351257
5650 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5652 2008-01-03 Marek Safar <marek.safar@gmail.com>
5654 A fix for bug #351157
5655 * class.cs (Using): Fixed yet another broken cloning.
5657 (Block): Put back more sensible default value for statements.
5659 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5661 * codegen.cs: Allow AssemblyVersion with only major version component.
5664 2007-12-29 Marek Safar <marek.safar@gmail.com>
5666 A fix for bug #324654
5667 * class.cs: Use FullName property as member name.
5669 2007-12-28 Marek Safar <marek.safar@gmail.com>
5671 A fix for bug #342117
5672 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5673 constructor constraint.
5675 2007-12-28 Marek Safar <marek.safar@gmail.com>
5677 A fix for bug #338273
5678 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5681 2007-12-28 Marek Safar <marek.safar@gmail.com>
5683 A fix for bug #350839
5684 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5686 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5688 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5691 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5693 * statement.cs: Changed some Hashtables to use HybridDictionaries
5694 instead. It was observed that some HashTables only contained a few
5695 items in the vast majority of cases. Since HybridDictionary is
5696 more efficient on small sets (<10 elements), "known_variables"
5697 from class ExplicitBlock as well as "labels" and "constants " from
5698 class Block were changed to HybridDictionaries.
5700 Atsai results: (56216kb->54987kb)
5702 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5705 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5707 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5710 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5712 * expression.cs: foreach loop to for loop, saved on allocation of
5713 enumerator (59333kb->59141kb)
5715 * statement.cs. Changed foreach loops to for loops, saved on
5716 allocation of enumerator (59141kb->59006kb)
5718 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5719 when constructed with no specified capacity. This was causing a
5720 few ArrayLists to allocate more memory than they would potentially
5721 need in the Block class and MemberCache class. Setting the
5722 ArrayLists to construct with a capacity of 1 saves some
5723 memory. (56216kb->55585kb)
5725 2007-12-27 Marek Safar <marek.safar@gmail.com>
5727 A fix for bug #347189 (2nd issue)
5728 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5731 2007-12-27 Miguel de Icaza <miguel@novell.com>
5733 * report.cs: Do not use colors if stdout and stderr are not a
5736 2007-12-27 Marek Safar <marek.safar@gmail.com>
5738 A fix for bug #346998
5739 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5742 2007-12-27 Marek Safar <marek.safar@gmail.com>
5744 A fix for bug #343465
5745 * class.cs: Explicit method name for nested types uses dots only.
5747 2007-12-27 Marek Safar <marek.safar@gmail.com>
5749 A fix for bug #343707
5750 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5752 2007-12-27 Marek Safar <marek.safar@gmail.com>
5754 * ecore.cs: Report type inference errors only when arguments count matches
5757 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5759 * expression.cs, report.cs: New warning.
5761 * typemanager.cs: Catch anonymous method type too.
5763 2007-12-23 Marek Safar <marek.safar@gmail.com>
5765 A fix for bug #346379
5766 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5768 2007-12-23 Marek Safar <marek.safar@gmail.com>
5770 A fix for bug #347359
5771 * expression.cs (Invocation): Don't resolve already resolved expression.
5773 2007-12-23 Marek Safar <marek.safar@gmail.com>
5775 A fix for bug #347189
5776 * class.cs (FixedField): Use non-dependent code only in the define phase.
5778 2007-12-23 Marek Safar <marek.safar@gmail.com>
5780 A fix for bug #348076
5781 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5783 2007-12-22 Marek Safar <marek.safar@gmail.com>
5785 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5786 discovered extension methods.
5788 2007-12-22 Marek Safar <marek.safar@gmail.com>
5790 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5793 2007-12-21 Miguel de Icaza <miguel@novell.com>
5795 * report.cs (ErrorMessage): Add support for using colors on
5796 terminals that support it.
5798 2007-12-21 Marek Safar <marek.safar@gmail.com>
5800 * ecore.cs: Use information about expanded params for error reporting.
5802 2007-12-21 Marek Safar <marek.safar@gmail.com>
5804 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5805 and logic for params overloads.
5807 2007-12-15 Miguel de Icaza <miguel@novell.com>
5809 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
5810 as this is also created from the parser. Fixes #349034
5812 2007-12-12 Miguel de Icaza <miguel@novell.com>
5814 * statement.cs (Throw.CloneTo): it is valid to have empty
5815 expressions for throw.
5817 2007-12-03 Marek Safar <marek.safar@gmail.com>
5819 * cs-parser.jay: Set delegate constraint parsing region correctly.
5821 2007-12-03 Marek Safar <marek.safar@gmail.com>
5823 A fix for bug #345467
5824 * typemanager.cs (IsEqual): Compare generic parameters position only.
5826 2007-11-28 Marek Safar <marek.safar@gmail.com>
5828 * expression.cs (BaseAccess): Type arguments can be null.
5830 2007-11-27 Raja R Harinath <harinath@gmail.com>
5832 * statement.cs (Block.Resolve): Ensure flow-branching tree is
5833 consistent even when an error has occured.
5834 (Switch.Resolve): Likewise.
5836 2007-11-22 Marek Safar <marek.safar@gmail.com>
5838 A fix for bug #334505
5839 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
5842 2007-11-22 Marek Safar <marek.safar@gmail.com>
5844 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
5845 refactorings required to resolve extension methods correctly when mixing
5846 generics and non-generics members.
5848 2007-11-20 Marek Safar <marek.safar@gmail.com>
5850 A fix for bug #342584
5851 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
5854 2007-11-19 Marek Safar <marek.safar@gmail.com>
5856 A fix for bug #342512
5857 * delegate.cs: Use delegate argument expression when is available. Don't
5858 emit virtual call when class is sealed.
5860 2007-11-16 Marek Safar <marek.safar@gmail.com>
5862 A fix for bug #325423
5863 * assign.cs (FieldInitializer): Use resolved expression for emit.
5865 * class.cs: Print less confusing error message.
5867 2007-11-16 Marek Safar <marek.safar@gmail.com>
5869 * cs-tokenizer.cs: Removed GMCS ifdefs.
5871 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
5874 * cs-parser.jay: Disabled nullable check.
5876 * generic-mcs: Copied more generic stuff.
5878 2007-11-16 Marek Safar <marek.safar@gmail.com>
5880 * gcs-parser.jay: Merged to cs-parser.jay.
5882 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
5883 * *.csproj, *.sources: Updated to use only jay parser file.
5885 2007-11-16 Marek Safar <marek.safar@gmail.com>
5887 * gcs-parser.jay: Added nullable and default expression feature checks.
5889 2007-11-16 Marek Safar <marek.safar@gmail.com>
5891 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
5892 it fixes many TODOs and hidden bugs.
5894 * expression: Removed duplicate error check.
5896 2007-11-15 Marek Safar <marek.safar@gmail.com>
5898 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
5899 implicitly type local variable only when it is used in a declaration.
5901 2007-11-15 Marek Safar <marek.safar@gmail.com>
5903 * attribute.cs: Use CS0612 for empty strings.
5905 2007-11-14 Marek Safar <marek.safar@gmail.com>
5907 * lambda.cs, statement.cs: Contextual return may act as a statement.
5909 2007-11-14 Marek Safar <marek.safar@gmail.com>
5911 A fix for a regression cause by #324222
5912 * class.cs: Don't report unused even when it implements an interface.
5914 2007-11-13 Marek Safar <marek.safar@gmail.com>
5916 A fix for bug #341205
5917 * ecore.cs, expression.cs: Method group expression cannot do static
5918 method access with an instance reference check before overloading takes
5921 2007-11-13 Marek Safar <marek.safar@gmail.com>
5923 A fix for bug #325359
5924 * class.cs: Use predictable name for automatically generated property.
5926 2007-11-12 Marek Safar <marek.safar@gmail.com>
5928 A fix for bug #324996
5929 * expression.cs (Is): Handle case where D is nullable and T is not
5932 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
5934 2007-11-12 Marek Safar <marek.safar@gmail.com>
5936 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
5937 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
5938 Flush small error reporting changes.
5940 2007-11-09 Marek Safar <marek.safar@gmail.com>
5942 A fix for bug #324996
5943 * expression.cs: Rewrote Is expression implementation to work with
5944 generics, nullable types, anonymous method. A const result expression
5945 uses existing infrastructure instead of custom not fully-featured one.
5947 2007-11-08 Marek Safar <marek.safar@gmail.com>
5949 A fix for bug #340202
5950 * class.cs: Consider generics for volatile field.
5952 2007-11-08 Marek Safar <marek.safar@gmail.com>
5954 A fix for bug #335594
5955 * expression.cs: Use conversion rules when handling string addition.
5957 2007-11-07 Marek Safar <marek.safar@gmail.com>
5959 A fix for bug #336651
5960 * expression.cs: Fixed a crash when probing is on.
5962 2007-11-07 Marek Safar <marek.safar@gmail.com>
5964 A fix for bug #324242
5965 * covert.cs: Added a conversion from any nullable-type with an
5966 underlying enum-type to the type System.Enum.
5968 2007-11-07 Marek Safar <marek.safar@gmail.com>
5970 A fix for bug #324222
5971 * class.cs: Report all non-used event fields.
5973 2007-11-07 Marek Safar <marek.safar@gmail.com>
5975 A fix for bug #325161
5976 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
5977 qualifier for generic types.
5979 2007-11-07 Marek Safar <marek.safar@gmail.com>
5981 A fix for bug #322971
5982 * expression.cs, ecore.cs: Added intermediate result value check for
5985 2007-11-07 Marek Safar <marek.safar@gmail.com>
5987 A fix for bug #324754
5988 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
5989 when it was requested.
5991 2007-11-07 Marek Safar <marek.safar@gmail.com>
5993 A fix for bug #325101
5994 * expression.cs: Do type not value comparison for `is' expression.
5996 2007-11-07 Marek Safar <marek.safar@gmail.com>
5998 A fix for bug #320236
5999 * convert.cs: Don't apply user conversion on underlying target type.
6001 2007-11-06 Marek Safar <marek.safar@gmail.com>
6003 * expression.cs: Don't use unresolved expression for error reporting.
6005 2007-11-06 Marek Safar <marek.safar@gmail.com>
6007 A fix for bugs #337712, #324490
6008 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6009 overloading resolution too.
6011 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6012 the process consistent and more robust.
6014 * expression.cs, linq.cs, report.cs: Update.
6016 2007-11-02 Marek Safar <marek.safar@gmail.com>
6018 A fix for bug #332909
6019 * attribute.cs: Resolve attributes in correct context using error
6022 * rootcontext.cs: Define Obsolete attribute members as core members.
6024 2007-11-02 Marek Safar <marek.safar@gmail.com>
6026 * statement.cs: Removed unused methods.
6028 2007-10-31 Wade Berrier <wberrier@novell.com>
6030 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6031 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6034 2007-10-31 Marek Safar <marek.safar@gmail.com>
6036 A fix for bug #338102
6037 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6038 methods registered as non-generics.
6040 2007-10-31 Marek Safar <marek.safar@gmail.com>
6042 A fix for bugs #337712, #324490
6043 * delegate.cs: Delegate covariance and contravariance is not allowed for
6046 2007-10-31 Marek Safar <marek.safar@gmail.com>
6048 A fix for bug #337719
6049 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6052 2007-10-30 Marek Safar <marek.safar@gmail.com>
6054 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6056 2007-10-29 Marek Safar <marek.safar@gmail.com>
6058 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6061 2007-10-29 Raja R Harinath <rharinath@novell.com>
6063 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6065 2007-10-29 Marek Safar <marek.safar@gmail.com>
6067 A fix for bug #334652
6068 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6069 extension methods when we have not found the best candidate in normal
6072 2007-10-27 Marek Safar <marek.safar@gmail.com>
6074 * AssemblyInfo.cs: Keep up-to-date.
6076 2007-10-27 Marek Safar <marek.safar@gmail.com>
6078 * Makefile: Fixed generics compiler name.
6080 2007-10-27 Marek Safar <marek.safar@gmail.com>
6082 * lambda.test: removed, lambda parsing is done differently.
6084 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6086 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6088 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6090 2007-10-27 Marek Safar <marek.safar@gmail.com>
6092 * Makefile, *.sources : All C# compilers are in mcs folder.
6094 * *.cs: Use existing 2_1 define for smcs.
6096 2007-10-26 Marek Safar <marek.safar@gmail.com>
6098 A fix for bug #335847
6099 * assign.cs, expression.cs: Couple of changes to avoid creating a
6100 temporary variable for each object initializer assignment statement. It
6101 simplifies struct initialization too, otherwise two temporary variables
6103 Implemented optimization of redundant default element initializers.
6105 2007-10-25 Marek Safar <marek.safar@gmail.com>
6107 A fix for bug #336766
6108 * expression.cs (Class.CheckBase): Use generic name when method is
6111 2007-10-25 Marek Safar <marek.safar@gmail.com>
6113 A fix for bug #334737
6114 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6115 variable and not variable argument for prepared copies.
6117 2007-10-24 Marek Safar <marek.safar@gmail.com>
6119 A fix for bug #325110
6120 * class.cs, expression.cs, attribute.cs: Use open generic method when
6121 checking conditional attribute.
6123 2007-10-24 Marek Safar <marek.safar@gmail.com>
6125 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6126 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6127 FeatureIsNotAvailable.
6129 2007-10-24 Marek Safar <marek.safar@gmail.com>
6131 ** C# 3.0 Partial methods
6133 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6134 methods support. Because of member cache issue with generics only
6135 non-generics partial methods are fully supported.
6137 2007-10-23 Marek Safar <marek.safar@gmail.com>
6139 * class.cs, decl.cs: Rewrote member overloads check to cope with
6140 generics and to use member cache for member checking. It also improves
6141 performance and fixes remaining overloads issues.
6143 2007-10-20 Marek Safar <marek.safar@gmail.com>
6145 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6146 roottypes.cs, typemanager.cs:
6148 A member cache creation logic changed to add members immediately and
6149 not rely on fallback. The member cache is now only prefered way
6150 how to access and find type declaration members. It saves 5 MB of memory
6151 during MWF compilation and makes code ready for more optimizations and
6152 clean-ups, it's also a pre-requirement for partial methods.
6154 2007-10-18 Raja R Harinath <harinath@gmail.com>
6156 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6157 handling for generic parameters.
6159 2007-10-15 Marek Safar <marek.safar@gmail.com>
6161 * class.cs (FixedField): Removed redundant volatile check.
6163 2007-10-15 Marek Safar <marek.safar@gmail.com>
6165 * class.cs, decl.cs: Fixed overload members verification to do only one
6166 check per possible collision.
6168 2007-10-13 Marek Safar <marek.safar@gmail.com>
6170 A fix for bug #325478
6171 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6172 and create only one disposable flags container.
6174 2007-10-12 Marek Safar <marek.safar@gmail.com>
6176 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6177 * statement.cs (Fixed): Fixed variables cloning.
6179 2007-10-12 Marek Safar <marek.safar@gmail.com>
6181 A fix for bug #333342
6182 * class.cs (EventField): Don't mark value type event as synchronized.
6184 2007-10-12 Marek Safar <marek.safar@gmail.com>
6186 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6187 inference to identify best candidate method correctly.
6188 (ProperyExpr): A range variable is read only and cannot be modified.
6190 2007-10-11 Marek Safar <marek.safar@gmail.com>
6192 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6193 logic to identify best candidate method correctly.
6195 2007-10-11 Marek Safar <marek.safar@gmail.com>
6197 * location.cs (Equals, GetHashCode): Removed.
6199 2007-10-11 Marek Safar <marek.safar@gmail.com>
6201 * report.cs: Implemented message recorder. It is used mainly for lambda
6202 expressions to capture otherwise swallowed error messages.
6204 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6206 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6208 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6210 * expression.cs (MemberAccess): Always report lookup failure.
6212 * location.cs: Implemented Equals, GetHashCode.
6214 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6216 2007-10-10 Jb Evain <jbevain@novell.com>
6218 * codegen.cs: re-enable assembly version check.
6220 2007-10-09 Marek Safar <marek.safar@gmail.com>
6222 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6225 * namespace.cs (UsingAlias): Do correct version check.
6227 2007-10-08 Marek Safar <marek.safar@gmail.com>
6229 * expresison.cs, ecore.cs: Issue extension method error message when
6232 * rootcontext.cs: Added ISO_2 compiler mode option.
6234 2007-10-08 Marek Safar <marek.safar@gmail.com>
6236 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6239 2007-10-08 Marek Safar <marek.safar@gmail.com>
6241 * attribute.cs (GetString, GetBoolean): Work with both literal and
6244 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6245 Moved method overload specific methods to MethodGroupExpr.
6247 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6248 it should be less memory consuming.
6250 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6252 * codegen.cs: remove the assembly version check until the buildbot is
6255 2007-10-07 Jb Evain <jbevain@novell.com>
6257 * attribute.cs (Attribute.GetString): if the value
6258 expression is a StringConstant, return its string value.
6260 2007-10-07 Jb Evain <jbevain@novell.com>
6262 * typemanager.cs: add `assembly_version_attribute_type`.
6263 * codegen.cs: on attribute emission, check that the
6264 AssemblyVersionAttribute doesn't overflow.
6266 2007-10-05 Marek Safar <marek.safar@gmail.com>
6268 A fix for bug #324677
6269 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6270 parent container of a scope container with currently resolved one.
6272 2007-10-05 Marek Safar <marek.safar@gmail.com>
6274 A fix for bug #325534
6275 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6278 2007-10-05 Marek Safar <marek.safar@gmail.com>
6280 A fix for bug #327504
6281 * class.cs (Operator.Define): Refactored implicit and explicit user
6282 operator conversion rules.
6284 2007-10-05 Marek Safar <marek.safar@gmail.com>
6286 A fix for bug #327520
6287 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6289 2007-10-04 Marek Safar <marek.safar@gmail.com>
6291 A fix for bug #328022
6292 * class.cs (MethodData.Define): Use correct method to check whether
6293 a method implementents an accessor.
6295 2007-10-04 Marek Safar <marek.safar@gmail.com>
6297 A fix for bug #330069
6298 * statement.cs (Fixed.Resolve): Read the first array element only when
6299 an array is instantiated.
6301 2007-10-04 Marek Safar <marek.safar@gmail.com>
6303 * expression.cs, assign.cs, generics.cs: Print correct operator when
6304 compound assignment is used.
6306 2007-10-04 Marek Safar <marek.safar@gmail.com>
6308 A fix for bug #325841
6309 * expression.cs (ArrayAccess): Use full argument cloning only for
6310 string compound concatenation.
6312 2007-10-03 Marek Safar <marek.safar@gmail.com>
6314 A fix for bug #328774
6315 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6317 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6320 2007-10-03 Raja R Harinath <rharinath@novell.com>
6323 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6324 Event accessibility checks here. Remove some bogus code that
6325 accidently made GenericMethods work.
6326 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6328 2007-09-25 Marek Safar <marek.safar@gmail.com>
6330 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6332 * statement.cs (Block): Refactored AddVariable to allow error handling
6335 * generic.cs: New stub.
6337 2007-09-23 Marek Safar <marek.safar@gmail.com>
6339 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6342 2007-09-17 Marek Safar <marek.safar@gmail.com>
6344 * class.cs: Use partial container to record whether any partial part
6345 contains static field initializer and therefore default contructor has
6348 2007-09-14 Marek Safar <marek.safar@gmail.com>
6350 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6351 mono-list when only one of two partial parts has defined accessibility
6354 2007-09-14 Marek Safar <marek.safar@gmail.com>
6356 A fix for bug #82845
6358 * class.cs (TypeContainer): Set correct resolve context for all field
6361 2007-09-13 Marek Safar <marek.safar@gmail.com>
6363 * assign.cs: Fixed a crash when field is resolved twice with an error.
6365 * codegen.cs: Changed InFieldInitializer to be flag.
6367 * anonymous.cs, ecore.cs, expression.cs: Update after
6368 IsInFieldInitializer rename.
6370 * const.cs: Removed unused parameter.
6372 * class.cs: Changed the way how we resolve and emit field initializers.
6373 The field initilizers have to have access to contructor block to emit
6374 compiler generated code.
6376 2007-09-13 Marek Safar <marek.safar@gmail.com>
6378 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6379 generics use TypeContainer instead.
6381 2007-09-12 Marek Safar <marek.safar@gmail.com>
6383 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6385 * lambda.cs (ResolveParameters): Use more powerful
6386 InflateGenericArgument.
6388 * parameters.cs: Better exception message.
6390 2007-09-10 Marek Safar <marek.safar@gmail.com>
6392 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6393 correct expression block type.
6395 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6397 * expression.cs (Invocation): Extracted method group resolve to
6400 2007-09-07 Marek Safar <marek.safar@gmail.com>
6402 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6403 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6405 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6406 generic extension methods.
6408 2007-09-06 Marek Safar <marek.safar@gmail.com>
6410 A fix for bug #82676 (Do I get it right now?)
6411 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6412 object before a standard conversion is applied.
6414 2007-09-06 Marek Safar <marek.safar@gmail.com>
6416 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6419 2007-09-05 Marek Safar <marek.safar@gmail.com>
6421 A fix for bug #82676
6422 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6423 non-generic interface types.
6425 2007-09-05 Marek Safar <marek.safar@gmail.com>
6427 A fix for bug #82690
6428 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6430 2007-09-05 Marek Safar <marek.safar@gmail.com>
6432 A fix for bug #82571
6433 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6434 modifier for container based methods.
6436 2007-09-05 Marek Safar <marek.safar@gmail.com>
6438 A fix for bug #82676
6439 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6440 any interface-type T means to any of interface type T.
6442 2007-09-04 Marek Safar <marek.safar@gmail.com>
6444 * namespace.cs: We have 2 versions of System.Core assembly.
6446 2007-09-04 Marek Safar <marek.safar@gmail.com>
6448 A fix for bug #82652
6449 * class.cs (Class.GetClassBases): Compare types and not expressions.
6451 2007-09-04 Marek Safar <marek.safar@gmail.com>
6453 A fix for bug #82620
6454 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6455 actually never worked before.
6456 (IndexerAccess): Emit prepared arguments before they are modified.
6458 2007-09-04 Marek Safar <marek.safar@gmail.com>
6460 A fix for bug #82563
6461 * assign.cs: Revert wrong fix.
6463 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6465 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6466 Instead of ldelema/stdind we have to use temporary variables to handle
6467 cases like String.Concat (params string[]).
6469 2007-08-31 Marek Safar <marek.safar@gmail.com>
6471 * class.cs: EmitAttributes to Emit rename.
6473 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6475 (MemberCore.HasClsCompliantAttribute): Don't depend on
6476 GetClsCompliantAttributeValue execution.
6478 2007-08-31 Marek Safar <marek.safar@gmail.com>
6480 * anonymous.cs: Use shorter type prefix.
6482 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6485 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6486 variables when probing is on.
6488 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6489 unresolved variables.
6490 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6491 handle transparent identifiers.
6493 2007-08-26 Marek Safar <marek.safar@gmail.com>
6495 * attribute.cs (IsClsCompliant): Add nullable types test.
6497 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6499 * doc.cs : catch other types of exception than XmlException to
6500 report CS1570. Fixed bug #82565.
6502 2007-08-23 Marek Safar <marek.safar@gmail.com>
6504 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6505 The number of delegate parameters has to match.
6506 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6509 2007-08-21 Marek Safar <marek.safar@gmail.com>
6511 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6512 to fix problem with private arguments.
6514 2007-08-20 Marek Safar <marek.safar@gmail.com>
6516 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6518 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6520 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6521 empty. Add cloning suport.
6523 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6525 2007-08-20 Marek Safar <marek.safar@gmail.com>
6527 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6528 to create EmptyCast. It handles EmptyConstantCast specialization for
6531 2007-08-18 Marek Safar <marek.safar@gmail.com>
6533 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6534 (EmitArrayArgument): One routine for array arguments.
6535 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6537 2007-08-17 Marek Safar <marek.safar@gmail.com>
6539 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6541 2007-08-17 Marek Safar <marek.safar@gmail.com>
6543 * anonymous.cs: MemberLookupFinal update.
6545 * class.cs (ConstructorInitializer): Is expression based.
6547 * delegate.cs: MethodGroupExpr update.
6549 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6551 (Error_MemberLookupFailed): Customizable error override.
6552 (MethodGroupExpr): Keep queried type for later usage.
6553 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6556 * expression.cs: Error_MemberLookupFailed refactoring.
6557 (New.DoResolve): Resolve as much as possible.
6558 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6559 customization for invalid member types.
6561 * statement.cs: MethodGroupExpr update.
6563 2007-08-16 Marek Safar <marek.safar@gmail.com>
6565 * modifier.cs (Check): Check all modifiers and not only accessibility
6568 2007-08-16 Marek Safar <marek.safar@gmail.com>
6570 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6571 type and not an expression.
6573 2007-08-16 Marek Safar <marek.safar@gmail.com>
6575 * statement.cs (Catch.Clone): Type and variable can be null.
6577 2007-08-16 Marek Safar <marek.safar@gmail.com>
6579 A fix for bug #81979
6580 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6581 I am really not sure whether this is the best fix.
6583 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6586 2007-08-14 Marek Safar <marek.safar@gmail.com>
6588 ** C# 3.0 Object and collection initializers (major re-write)
6590 * assign.cs (DoResolve): Initializers are not assign related.
6592 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6593 used during collection or object initialization.
6595 * expression.cs (Error_InvalidArguments): Add initializers specific
6596 messages. More will come later because it requires some general
6598 (New.DoResolve): Better error handling for unsafe types.
6599 (EmptyExpressionStatement): New class.
6600 (ElementInitializer): An object initializer expression.
6601 (CollectionElementInitializer): A collection initializer expression.
6602 (CollectionOrObjectInitializers): A block of object or collection
6604 (NewInitialize): New expression with element/object initializers.
6606 * statement.cs: Reverted object/collection initializer hacks.
6608 * typemanager.cs (CSharpName): Filter __arglist type.
6610 2007-08-09 Marek Safar <marek.safar@gmail.com>
6612 ** C# 3.0 Anonymous Types (update to the latest standard)
6614 * expression.cs (Binary.ResolveOperator): Threat all null based types
6616 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6617 (AnonymousTypeParameter): Updated.
6619 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6620 (AnonymousTypeClass): New anonymous type container.
6622 * class.cs (AddField): Return operation result.
6624 * generic.cs: Another empty TypeArguments overload.
6626 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6627 are stored at top of normal hierarchy.
6629 * typemanager.cs (CSharpName): Filter anonymous types.
6631 2007-08-09 Marek Safar <marek.safar@gmail.com>
6633 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6634 as single Concat call. How could we miss that :-(
6636 2007-08-08 Marek Safar <marek.safar@gmail.com>
6638 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6640 2007-08-07 Miguel de Icaza <miguel@novell.com>
6642 * expression.cs: Fix the previous commit, the creation of the
6643 arguments array list needs also to be conditional on the arguments
6646 * class.cs: Add a little bit of help to help narrow down problems.
6648 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6649 not try to copy in that case.
6651 * driver.cs: When building SMCS, include a new different set of
6652 default assemblies here. Do this here so we can control whether
6653 to include the default assemblies with /noconfig.
6655 2007-08-03 Marek Safar <marek.safar@gmail.com>
6657 A fix for bug #81979
6658 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6661 2007-08-03 Marek Safar <marek.safar@gmail.com>
6663 A fix for bug #82300
6665 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6666 we are in probing scope.
6668 2007-08-03 Marek Safar <marek.safar@gmail.com>
6670 A fix for bug #82301
6672 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6673 (Statement.CloneTo): Clone and not map children blocks.
6675 2007-08-03 Marek Safar <marek.safar@gmail.com>
6677 A fix for bug #82299
6679 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6682 * statement.cs (Statement.CloneTo): Clone variables before statements
6683 to allow remaping of local variables.
6685 2007-08-03 Marek Safar <marek.safar@gmail.com>
6687 A fix for bug #82296
6690 * report.cs: Log crash details for future clone problems.
6692 * statement.cs (Return.Clone): Don't clone non-existent expression.
6694 2007-08-03 Raja R Harinath <harinath@gmail.com>
6696 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6697 (Class.AddBasesForPart): Move CS0537 check here from ...
6698 * cs-parser.jay (class_declaration): ... here. Move calling of
6699 'AddBasesForPart' to ...
6700 (class_bases): ... here.
6701 (struct_declaration, interface_declaration): Update to changes.
6703 2007-08-02 Marek Safar <marek.safar@gmail.com>
6705 A fix for bug #81923
6707 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6708 conversion is allowed.
6710 2007-08-02 Marek Safar <marek.safar@gmail.com>
6712 A fix for bug #81564
6714 * ecore.cs (EventExpr): Add IsBase handling.
6716 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6719 2007-08-02 Raja R Harinath <harinath@gmail.com>
6721 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6722 * cs-parser.jay: Some whitespace cleanups.
6723 (current_delegate): New.
6725 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6726 a dummy code block, and use 'type_name' instead of 'member_name'.
6727 (interface_declaration, class_declaration): Likewise.
6728 (delegate_declaration): Likewise. Rearrange slightly and use
6730 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6731 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6733 2007-08-02 Marek Safar <marek.safar@gmail.com>
6735 A fix for bug #82039
6737 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6740 * typemanager.cs (CSharpName): Split to string overload.
6742 2007-08-02 Marek Safar <marek.safar@gmail.com>
6745 * report.cs: Updated warning CS0472.
6747 2007-08-01 Marek Safar <marek.safar@gmail.com>
6749 A fix for bug #82181
6751 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6753 2007-08-01 Marek Safar <marek.safar@gmail.com>
6755 A fix for bug #82277
6756 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6758 2007-08-01 Marek Safar <marek.safar@gmail.com>
6760 ** C# 3.0 Type Inference (major bits are working)
6762 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6763 (.ImplicitStandardConversionExists): Uses compatible.
6764 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6765 (.InferReturnType): New method.
6766 (.Compatible): Refactored.
6767 (.ResolveParameters): Uses factory to create resolved parameters.
6768 (.CompatibleMethod): Add probing mode support.
6769 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6770 clearly distinguish between 2 different operations.
6771 (LambdaMethod): Moved to lambda.cs.
6772 (AnonymousMethod): Removed unused fields and methods.
6773 (AnonymousDelegate): Simplified.
6775 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6777 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6779 * delegate.cs (Delegate): New mehods to reduce code duplication.
6780 (.GetConstructor): New method.
6781 (.GetInvokeMethod): New method.
6782 (DelegateCreation): Updated.
6784 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6786 (OverloadResolve): Made probing little bit faster.
6788 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6791 * generic.cs (TypeInferenceContext): Dummy implementation.
6793 * iterators.cs: Updated after Resolve/Define rename.
6795 * lambda.cs (LambdaExpression)
6796 (.ResolveParameters): Handles both type of arguments and type inference too.
6798 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6799 (InflateTypes): Updated.
6801 * support.cs (InflateTypes): Changed signature and updated.
6803 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6804 (MemberLookup_FindMembers): More MS tricks.
6805 (GetParameterData): Ditto.
6806 (GetDelegateParameters): Uses quick path for dynamic types.
6808 2007-08-01 Marek Safar <marek.safar@gmail.com>
6810 * class.cs (MethodData.Define): EmitContext is required for generic stuff
6813 2007-07-31 Marek Safar <marek.safar@gmail.com>
6815 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
6818 2007-07-26 Jb Evain <jbevain@novell.com>
6820 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
6821 which takes a boolean 'report_errors', similar to the GetMethod.
6822 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
6823 in .net 2.1, do not report errors here.
6825 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
6826 System.Runtime.CompilerServices.RequiredAttributeAttribute and
6827 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
6830 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
6831 of the type InternalsVisibleToAttribute before the first call
6832 to CoreLookupType which is allowed to fail (third boolean parameter
6833 to true). Because, during the resolution for a type that is not
6834 immediately found, we try to check if the type is not defined in
6835 a friend assembly, and to do so, we need the
6836 InternalVisibleToAttribute.
6838 2007-07-23 Miguel de Icaza <miguel@novell.com>
6840 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
6841 feature that allows structs to be compared against null and inline
6842 the result as true or false.
6844 Notice that the same code is not permitted inside a generic block
6845 of code that would do:
6847 class Foo<T> where T : struct {
6854 It is only allowed if the type of T is not bound (no where
6855 clause). In my opinion, this CSC 2 behavior is broken but people
6856 seem to be using it (IronRuby does, a few bug reports on bugzilla
6857 have it and some people have complained about it).
6859 All of the users that depend on this behavior have code that is
6862 * report.cs (Warning, Error): make these take object arguments,
6863 not strings, as that allows us to take advantage of Format.
6865 2007-07-20 William Holmes <billholmes54@gmail.com>
6867 * decl.cs: Changed MemberName.CountTypeArguments to also check the
6868 Left member variable for the Count.
6869 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
6870 MemberName.CountTypeArguments to avoid a NRE.
6872 This code is contributed under the MIT X11 license
6874 2007-07-18 Marek Safar <marek.safar@gmail.com>
6876 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
6878 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6880 * doc.cs : generic method arguments are written as ``x while generic
6881 type arguments are `x. Combined with the previous change, fixed bug
6884 2007-07-18 Raja R Harinath <rharinath@novell.com>
6887 * expression.cs (Binary.ResolveOperator): When converting
6888 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
6890 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6892 * doc.cs : when T: or whatever x: is specified, it does not really
6893 check the doc comment's syntax correctness. Fixed bug #82006.
6895 2007-07-18 Marek Safar <marek.safar@gmail.com>
6897 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
6898 LambdaExpression better.
6900 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
6902 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
6904 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
6905 as it can be generated.
6907 * expression.cs (Invocation.Error_InvalidArguments): Show correct
6910 * lambda.cs (LambdaExpression): Refactored to share same code with
6911 AnonymousMethodExpression.
6913 2007-07-17 Marek Safar <marek.safar@gmail.com>
6915 * anonymous.cs (MakeName): Include host name for easier debugging.
6916 (LambdaMethod): New class for lambda spcecific stuff.
6918 * attribute.cs: Set EmitContext return type.
6920 * class.cs: Set EmitContext return type.
6922 * codegen.cs (EmitContext): Return type cannot be null to stop messing
6923 with null/void meaning.
6925 * iterators.cs (ContainerType): Implemented.
6927 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
6929 * statement.cs (Return): Updated to lambda expressions.
6930 (Block.CloneTo): Parent can be null.
6932 2007-07-13 Marek Safar <marek.safar@gmail.com>
6934 A fix for bug #81917
6935 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
6937 * class.cs (FixedField): Check whether field is in unsafe scope.
6939 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
6940 (FieldExpr.Emit): Fixed buffers cannot be volatile.
6942 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
6945 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
6947 2007-07-13 Marek Safar <marek.safar@gmail.com>
6949 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
6950 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
6953 2007-07-13 Marek Safar <marek.safar@gmail.com>
6955 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
6957 2007-07-13 Marek Safar <marek.safar@gmail.com>
6959 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
6960 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
6962 * codegen.cs(EmitContext): Add ProbingMode flag.
6964 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
6966 * driver.cs: For now set both warning values.
6968 * ecore.cs (SimpleName): Name is readonly.
6969 (MethodGroup.OverloadResolve): One quick path for probing.
6971 * expression.cs (Unary): Set Oper r/o.
6972 (Binary): Set Oper r/o.
6973 (ParameterReference): Set few instance variables as r/o.
6974 (ParameterReference.DoResolveBase): Don't capture aruments when
6976 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
6977 (Arglist): arguments are private.
6978 (SizeOf): type is private and r/o.
6979 (MemberAccess): arguments are private.
6981 * report.cs: Enhanced reporting on/off capabilities.
6983 * lambda.cs: Uses ec.IsInProbingMode.
6984 (ContextualReturn): Derives from return.
6986 * rootcontext.cs: For now set both warning values.
6988 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
6990 (Return.Resolve): Don't die immediately.
6991 (Block.Resolve): Speed-up probing.
6992 (Block.CloneTo): Clone only child blocks.
6994 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
6996 * iterators.cs: reverted Miguel's latest change (r81925) as it
6997 breaks the build in System.
6999 2007-07-13 Miguel de Icaza <miguel@novell.com>
7001 * iterators.cs (Yield.CheckContext): Check for the iterator type
7002 also here as we can call into Yield even in codepaths that are not
7004 (MethodOrOperator is the only path that was checked).
7006 In addition to the standard check, use a more specific check for
7007 constructors to report a more verbose error.
7009 2007-07-12 Miguel de Icaza <miguel@novell.com>
7011 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7012 report the warning and continue
7014 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7015 values on the stack on the call to Emit. Use EmitStatement if
7016 possible, or using Emit + Pop if not possible. Fixes #82064
7018 2007-07-12 Raja R Harinath <rharinath@novell.com>
7020 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7021 avoid try...finally in some cases.
7023 2007-07-10 Marek Safar <marek.safar@gmail.com>
7025 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7027 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7028 instead of method. Re-use standard error handling.
7029 (ConstructorInitializer.Emit): Simplified.
7031 * delegate.cs: Updated after Invocation.EmitCall change.
7033 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7034 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7035 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7036 method and don't permanently changing input arguments.
7037 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7038 is resolved it has one of the candidates is the best one which is later
7039 used to emit. Removed a few unused method.
7040 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7042 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7043 (Binary.ResolveOperator): Ditto.
7044 (ConditionalLogicalOperator.DoResolve): Ditto.
7045 (Invocation): Uses method group.
7046 (Invocation.DoResolve): Simplified.
7047 (Invocation.EmitCall): Removed useless is_static.
7048 (Invocation.Emit): Delegate to method group.
7049 (Invocation.EmitStatement): Simplified.
7050 (New): Uses method group.
7051 (MemberAccess.DoResolve): Don't destroy original expression.
7053 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7055 2007-07-04 Marek Safar <marek.safar@gmail.com>
7057 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7060 * lambda.cs: Add custom error message type.
7062 2007-07-03 Marek Safar <marek.safar@gmail.com>
7064 * lambda.cs: Simplified little bit.
7066 * parameter.cs: Introduced ImplicitLambdaParameter.
7067 (Parameters.CreateFullyResolved): New factory instead of ctor.
7071 * delegate.cs: Updated parameter creation.
7073 2007-07-03 Marek Safar <marek.safar@gmail.com>
7075 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7078 * generic.cs: Synchronized with gmcs.
7080 2007-07-03 Marek Safar <marek.safar@gmail.com>
7082 * class.cs (Indexer): Check return type as soon as possible.
7084 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7087 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7089 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7091 * parameter.cs (Parameter): Use expression type when it is available.
7093 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7094 method modifier for the first parameter only.
7096 2007-06-24 Marek Safar <marek.safar@gmail.com>
7098 A fix for bug #81938
7099 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7101 * constant.cs: Tide up an exception message.
7103 2007-06-22 Marek Safar <marek.safar@gmail.com>
7105 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7106 an uninitialized variable is used.
7108 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7110 2007-06-22 Marek Safar <marek.safar@gmail.com>
7112 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7113 not found error handling.
7115 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7117 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7118 (ArrayCreation.DoResolve): Simplified.
7119 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7120 its own resolve process.
7121 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7123 2007-06-20 Marek Safar <marek.safar@gmail.com>
7125 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7128 2007-06-20 Marek Safar <marek.safar@gmail.com>
7130 * cs-tokenizer.cs: Removed var related stuff.
7132 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7133 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7134 a type and a keyword at same time.
7136 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7139 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7140 implicitly typed arrays, more changes will follow.
7142 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7144 2007-06-19 Marek Safar <marek.safar@gmail.com>
7146 * ecore.cs (VarExpr): Removed Handled field.
7148 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7149 build-in assign functionality.
7150 (ForEach.Resolve): Removed all implicitly typed local variable code and
7152 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7153 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7155 2007-06-18 Marek Safar <marek.safar@gmail.com>
7157 * assign.cs: Removed implicitly typed local variable check.
7159 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7160 referencing implicitly typed local variable.
7161 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7164 * statement.cs (Fixed): Removed unsupported implicitly typed local
7167 2007-06-15 Marek Safar <marek.safar@gmail.com>
7169 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7171 2007-06-14 Marek Safar <marek.safar@gmail.com>
7173 A fix for bugs #81855 and #76274
7174 * attribute.cs (AttachTo): Always set owner for global attributes to
7177 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7180 * cs-parser.jay: Assembly and module attributes must precede all other
7181 elements except using clauses and extern alias declarations.
7183 2007-06-13 Marek Safar <marek.safar@gmail.com>
7185 A fix for bug #81748
7187 * expression.cs: More checks for non ISO-1 features.
7189 2007-06-12 Marek Safar <marek.safar@gmail.com>
7191 A fix for bug #81807
7192 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7193 present inside switch statement and it is required by nullable check.
7195 2007-06-12 Marek Safar <marek.safar@gmail.com>
7197 A fix for bug #81840
7198 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7199 when type matching fails.
7201 * namespace.cs: Tiny error message change.
7203 2007-06-12 Marek Safar <marek.safar@gmail.com>
7205 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7206 reporting. Added automatic property check.
7208 * class.cs: Updated after CheckAbstractAndExtern relocation.
7209 (AEventPropertyAccessor.GetSignatureForError): Customized.
7211 2007-06-11 Marek Safar <marek.safar@gmail.com>
7213 * class.cs (DefineBaseTypes): Base type can be undefined.
7215 * ecore.cs (TypeLookup): Minor refactoring.
7216 (DoResolveAsTypeStep): Removed redundant check.
7218 * namespace.cs (Lookup): Removed redundant check.
7220 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7221 ResolveAsTypeTerminal step.
7222 (BootstrapCorlib_*): Simplified.
7223 (PopulateCoreType): Core types can be now external.
7225 2007-06-07 Marek Safar <marek.safar@gmail.com>
7227 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7229 (InferTypeArguments): Infers anonymous expression type arguments.
7230 (Compatible): Split to Compatible and InferTypeArguments.
7232 * lambda.cs: Updated.
7234 2007-06-08 Marek Safar <marek.safar@gmail.com>
7236 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7238 2007-06-07 Raja R Harinath <harinath@gmail.com>
7240 Fix #80477, cs0135-2.cs, cs0135-3.cs
7241 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7242 names to the "known" variables list.
7243 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7244 parameter names are also "known".
7245 (Block.CheckError136): Remove.
7246 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7249 2007-06-07 Marek Safar <marek.safar@gmail.com>
7251 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7253 2007-06-06 Marek Safar <marek.safar@gmail.com>
7255 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7256 internal error not an user error.
7258 * expression.cs (IsApplicable): Refactored to make debugging easier.
7260 * support.cs: More tricks for non-mono runtimes.
7262 * typemanager.cs (CoreLookupType): Made public.
7263 (InitSystemCore): All linq specific stuff moved to linq.cs
7265 2007-06-05 Marek Safar <marek.safar@gmail.com>
7267 * typemanager.cs (CSharpSignature): One more missing build-in types
7269 More tricks for non-mono runtime.
7271 2007-06-05 Raja R Harinath <harinath@gmail.com>
7273 * statement.cs (Block.CheckError136_InParents): Remove.
7274 (Block.AddVariable): Use GetParameterInfo instead.
7275 (ToplevelBlock.ProcessArguments): Likewise.
7277 2007-06-04 Raja R Harinath <rharinath@novell.com>
7279 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7281 (ToplevelBlock.GetParameterInfo): Split out of ...
7282 (ToplevelBlock.GetParameterRefernce): ... this.
7283 (ToplevelBlock.ParameterMap): Remove.
7284 * expression.cs (ParameterReference): Update to use
7285 ToplevelParameterInfo.
7287 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7290 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7291 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7293 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7294 (ToplevelBlock.ProcessParameters) ... here.
7295 (ToplevelBlock..ctor): Invoke it.
7297 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7300 * statement.cs (IKnownVariable): New interface.
7301 (LocalInfo): Implement it.
7302 (ToplevelParameterInfo): New class.
7303 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7304 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7305 GetKnownVariableInfo.
7307 2007-06-03 Raja R Harinath <harinath@gmail.com>
7309 Partly speed up CS0136 error checks.
7310 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7311 'recurse' parameter.
7312 (Block.DoCheckError136): Only check errors in parameters. Move
7313 local variable checks ...
7314 (Block.AddVariable): ... here, and ...
7315 (ToplevelBlock.ResolveMeta): ... here.
7317 2007-06-02 Raja R Harinath <harinath@gmail.com>
7319 * statement.cs (Block.IsChildOf): Remove.
7321 * statement.cs (Statement.Clone): Move special case code ...
7322 (Block.CloneTo): ... here.
7324 2007-05-29 Raja R Harinath <rharinath@novell.com>
7326 * statement.cs (ToplevelBlock.container): Remove field. It's
7327 redundant with 'Parent'.
7328 (ToplevelBlock.ContainerBlock): Remove accessor.
7329 (ToplevelBlock..ctor): Update to changes. Register anonymous
7330 child with parent here, ...
7331 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7333 (start_anonymous): Don't save current_block.
7334 (top_current_block): Remove.
7336 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7337 (Block.Resolve): Update to changes.
7338 (Block..ctor): Move setting of "correct" 'Toplevel'
7339 and 'Explicit' fields to ...
7340 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7342 2007-05-27 Raja R Harinath <harinath@gmail.com>
7345 * statement.cs (Block.Implicit): Remove.
7346 (Block): Update to changes.
7347 * flowanalysis.cs: Likewise.
7349 Mildly speed up CheckInvariantMeaningInBlock
7350 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7351 Recursively call AddKnownVariable to all enclosing blocks.
7352 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7353 Remove recursive calls.
7354 (Block): Update to changes.
7356 New ExplicitBlock invariants
7357 * statement.cs (Block.Explicit): New field. It points to the
7358 immediately enclosing non-implicit block.
7359 (Block..ctor): Maintain the invariant.
7360 * cs-parser.jay: Take advantage of invariant.
7362 Introduce ExplicitBlock
7363 * statement.cs (ExplicitBlock): New.
7364 (ToplevelBlock): Derive from it.
7365 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7367 (Block.Implicit): Update to changes.
7368 * cs-parser.jay: Update to changes.
7371 * codegen.cs (EmitContext.IsLastStatement): Remove.
7372 * statement.cs (Block.DoEmit): Update to changes.
7374 2007-05-25 Raja R Harinath <rharinath@novell.com>
7376 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7377 modifying current_block directly.
7379 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7381 * class.cs: Implemented automatic properties (C# 3.0)
7382 Thanks to Marek for the help.
7384 2007-05-23 Raja R Harinath <rharinath@novell.com>
7386 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7387 variable as assigned, note also that all its components are
7389 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7391 2007-05-19 Marek Safar <marek.safar@gmail.com>
7393 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7394 member is marked as compiler generated.
7396 * decl.cs (MemberCore): Refactored ModFlags into property.
7398 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7399 (Check): Check only accessibility modifiers.
7401 2007-05-18 Raja R Harinath <rharinath@novell.com>
7403 Track all assignable slots in one bit array
7404 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7405 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7406 logic from VariableMap constructor here. Use the same 'offset'
7407 variable that's later used for computing offsets of local
7409 * flowanalysis.cs (UsageVector.parameters): Remove.
7410 (UsageVector): Update to changes.
7411 (VariableMap): Remove.
7413 Avoid creating ParameterMap in every block
7414 * statement.cs (Block.ParameterMap): Move ...
7415 (ToplevelBlock.ParameterMap): ... here.
7416 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7418 * flowanalysis.cs (FlowBranching.param_map): Remove.
7419 (FlowBranching.UsageVector): Update to changes.
7420 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7422 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7424 * expression.cs (ParameterReference): Distinguish between block
7425 where parameter was referenced and declared.
7427 2007-05-18 Marek Safar <marek.safar@gmail.com>
7429 * flowanalysis.cs, statement.cs: Put back improved error handling.
7431 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7435 Imporved object and collection initialization (C# 3.0).
7437 2007-05-15 Marek Safar <marek.safar@gmail.com>
7439 A fix for bug #81380
7440 * expression.cs (Is.DoResolve): Only value types have constant `is'
7443 2007-05-15 Raja R Harinath <rharinath@novell.com>
7445 * statement.cs (ToplevelBlock.child): Remove.
7447 2007-05-15 Raja R Harinath <harinath@gmail.com>
7449 Rationalize ResolveMeta: refactoring
7450 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7451 out constant handling code into ...
7452 (Block.DoResolveConstants): ... this.
7454 Rationalize ResolveMeta: kill local_map
7455 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7456 (Block.AssignableSlots): New.
7457 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7458 for locals -- move code from VariableMap here. Avoid unnecessary
7460 * flowanalysis.cs (FlowBranching.local_map): Remove.
7461 (FlowBranching..ctor): Use Block.AssignableSlots.
7462 (VariableMap): Remove unused constructors.
7464 2007-05-11 Raja R Harinath <rharinath@novell.com>
7466 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7468 2007-05-11 Marek Safar <marek.safar@gmail.com>
7470 * typemanager.cs (IsFriendAssembly): Should not be called for building
7473 2007-05-09 Marek Safar <marek.safar@gmail.com>
7475 * literal.cs (NullConstant): Print null in all cases.
7477 * expression.cs (Binary.ResolveOperator): Implemented delegate
7478 comparison based on C# 2.0 changes.
7480 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7482 This code is contributed under the MIT X11 license
7484 The following enables support for several C# 3.0 language features:
7486 * cs-tokenizer.cs: Added support for the "var" keyword.
7488 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7489 Added VarExpr class to facilitate type inferencing.
7491 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7492 to support anonymous types.
7494 * assign.cs: Added support for type inferencing and initialization.
7496 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7498 * expression.cs: Added implicit array support to ArrayCreation.
7499 Added 5 types and 1 interface:
7501 IInitializable Implementing classes can inject initializing
7502 statements after object instantiation.
7504 Initializer Stores data for object initialization.
7506 AnonymousType An expression for anonymous types.
7508 AnonymousTypeParameter Stores data about an anonymous type's field.
7510 NewInitialize An expression for object initialization.
7512 CollectionInitialize An expression for collection initialization.
7514 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7517 2007-05-06 Marek Safar <marek.safar@gmail.com>
7519 A fix for bug #81500
7520 * cs-tokenizer.cs: Add special handling for coalescing operator.
7522 2007-05-06 Marek Safar <marek.safar@gmail.com>
7524 A fix for bug #81529
7525 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7526 its value from base class until it is redefined.
7528 2007-05-02 Raja R Harinath <rharinath@novell.com>
7530 Fix regression in cs0631-3.cs
7531 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7532 fallback. Make error fallback catch more cases.
7534 2007-05-01 Miguel de Icaza <miguel@novell.com>
7536 * cs-parser.jay: Allow parameters in operator declarations to have
7539 2007-04-27 Miguel de Icaza <miguel@novell.com>
7541 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7544 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7545 inside the ContextualReturn, it does not have to be an
7546 ExpressionStatement.
7548 2007-04-24 Miguel de Icaza <miguel@novell.com>
7550 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7553 2007-04-23 Miguel de Icaza <miguel@novell.com>
7555 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7556 method in two methods: ResolveNoDefine and Resolve.
7558 ResolveNoDefine will stop just after ResolveTopBlock has been
7561 Resolve will then continue by creating a method and issuing the
7562 call to method.Define ().
7564 (AnonymousMethod): Split and implement the new Resolve and
7565 ResolveNoDefine as well.
7567 * lambda.cs (LambdaExpression): Split the anonymous method
7568 resolution code into a separate routine (CoreCompatibilityTest)
7569 from DoCompatibleTest.
7571 (LambdaExpression.TryBuild): New method, this method tries to
7572 build the LambdaExpression with the given set of types to be used
7573 as the types for the various parameters of the lambda expression.
7575 If the compilation succeed with the given types, the infered type
7576 of the Anonymous method is returned, otherwise null is returned.
7578 2007-04-23 Marek Safar <marek.safar@gmail.com>
7580 A fix for bug #81414
7581 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7583 2007-04-22 Miguel de Icaza <miguel@novell.com>
7585 * cs-tokenizer.cs: Change various identifiers here from the
7586 camelCasing to the recommended Linux-like style for instance
7587 variables from the Coding Guidelines.
7589 2007-04-19 Martin Baulig <martin@ximian.com>
7592 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7593 System.Enum to System.ValueType.
7595 2007-04-13 Martin Baulig <martin@ximian.com>
7597 Rewrote implicit reference conversions. We need to distinguish
7598 between implicit reference conversions (13.1.4) and implicit
7599 boxing conversions (13.1.5).
7601 According to the spec, there's an an implicit conversion
7602 "From a one-dimensional array-type S[] to IList<T> and base
7603 interfaces of this interface, provided there is an implicit
7604 reference conversion from S to T." Note that this does not
7605 include boxing conversions.
7608 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7609 (Convert.ImplicitReferenceConversion): Split into
7610 ImplicitReferenceConversionCore() and
7611 ImplicitBoxingConversionExist().
7612 (Convert.ImplicitReferenceConversionExists): Use the new
7613 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7615 2007-04-12 Martin Baulig <martin@ximian.com>
7617 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7618 `TypeManager.null_type' checks up to the top of the method.
7620 2007-04-11 Marek Safar <marek.safar@gmail.com>
7622 A fix for bug #81350
7623 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7626 2007-04-11 Martin Baulig <martin@ximian.com>
7628 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7629 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7630 to make this work for generic classes; fixes #79561.
7632 2007-04-11 Martin Baulig <martin@ximian.com>
7634 * expression.cs (As): Add support for nullable types; fixes #79371.
7636 2007-04-11 Martin Baulig <martin@ximian.com>
7638 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7639 `type.FullName' is null; fixes #80243.
7641 2007-04-11 Martin Baulig <martin@ximian.com>
7643 * expression.cs (Invocation.IsApplicable): Don't modify the method
7644 if type inference succeeded, but the method was not applicable.
7647 2007-04-10 Marek Safar <marek.safar@gmail.com>
7649 A fix for bug #81324
7650 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7651 internal and external namespaces containers.
7653 2007-04-10 Martin Baulig <martin@ximian.com>
7655 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7656 TypeManager.DropGenericMethodArguments() so we also call
7657 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7659 2007-04-10 Martin Baulig <martin@ximian.com>
7661 * iterators.cs (Iterator.CreateIterator): Don't crash if
7662 `method.ReturnType' is null. This happens if something went wrong
7663 while resolving that typ (we already reported an error in this case).
7665 2007-04-10 Martin Baulig <martin@ximian.com>
7667 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7668 generic interfaces; report the CS0144 directly.
7670 2007-04-10 Martin Baulig <martin@ximian.com>
7672 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7673 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7675 2007-04-10 Martin Baulig <martin@ximian.com>
7677 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7679 2007-04-09 Raja R Harinath <rharinath@novell.com>
7682 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7683 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7686 * statement.cs (For.Resolve): If resolution fails, use
7689 2007-04-08 Marek Safar <marek.safar@gmail.com>
7691 * anonymous.cs (MakeName): Make faster and zero-based.
7692 (VerifyExplicitParameterCompatibility): Back to mode where generic
7693 parameter is ignored.
7694 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7696 * class.cs (EmitType): Method can emit another new method.
7698 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7700 * driver.cs: Updated.
7702 * lambda.cs: Reuse predefined empty parameters.
7704 * parameter.cs: Updated
7706 * support.cs: Implemented InflateTypes.
7708 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7709 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7711 2007-04-03 Martin Baulig <martin@ximian.com>
7715 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7716 version of TypeManager.IsOverride() which also works with generic
7719 2007-04-03 Martin Baulig <martin@ximian.com>
7724 (Convert.ExplicitReferenceConversion): We need to cast when
7725 converting from IList<T> to S[].
7727 2007-04-01 Marek Safar <marek.safar@gmail.com>
7729 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7732 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7734 2007-03-31 Marek Safar <marek.safar@gmail.com>
7736 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7737 argument and return type inferring.
7739 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7740 (ReturnType): Turned to property.
7742 * statement.cs (Return): Implemented return type inferring.
7744 * support.cs (ReflectionParameters): Use local types if possible.
7746 2007-03-30 Raja R Harinath <rharinath@novell.com>
7748 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7749 (FlowBranching.UsageVector): Update to changes.
7751 Prepare to kill 'Reachability'
7752 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7753 argument of constructor.
7755 2007-03-29 Raja R Harinath <rharinath@novell.com>
7757 Prepare to kill 'Reachability'
7758 * flowanalysis.cs (UsageVector.is_unreachable): New.
7759 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7760 'reachability', and verify they're consistent.
7763 * expression.cs (New.EmitStatement): Handle type parameters here too.
7765 2007-03-29 Martin Baulig <martin@ximian.com>
7770 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7771 CompilerGeneratedClass.
7772 (ScopeInfo.EmitScopeInstance): Make this protected.
7773 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7774 `ec.CurrentAnonymousMethod.Scope == Scope'.
7776 * statement.cs (Block.ScopeInfo): Make this a property.
7778 2007-03-27 Raja R Harinath <harinath@gmail.com>
7780 Prepare to kill 'Reachability'
7781 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7782 (FlowBranching.UsageVector.Reachability): Remove property.
7783 (FlowBranching.UsageVector.IsUnreachable): New property.
7784 (FlowBranching.UsageVector.ResetBarrier): New.
7785 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7786 * codegen.cs, statement.cs: Update to changes.
7788 2007-03-27 Martin Baulig <martin@ximian.com>
7793 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7796 2007-03-26 Raja R Harinath <rharinath@novell.com>
7798 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7799 instead of TriState. Remove all mention of TriState.
7801 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7802 replaced by a boolean. Add boolean 'is_unreachable' field, check
7803 and maintain invariants.
7805 2007-03-25 Marek Safar <marek.safar@gmail.com>
7807 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
7809 2007-03-25 Marek Safar <marek.safar@gmail.com>
7811 * expression.cs: Stop using obsolete 2.0 opcodes.
7813 2007-03-25 Marek Safar <marek.safar@gmail.com>
7815 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
7816 one of the latests Martin's fixes.
7818 2007-03-23 Miguel de Icaza <miguel@novell.com>
7820 * expression.cs: On BigEndian systems, swap the bytes, temporary
7821 solution until we get a new bitconverter class.
7823 2007-03-23 Martin Baulig <martin@ximian.com>
7827 * decl.cs (MemberCache.AddMembers): Add generic methods both as
7828 "Method" and "Method`1". Normally, a cache lookup is done on the
7829 "Method" form (ie. without the generic arity), but this one makes
7830 lookups on the full form work as well.
7832 2007-03-22 Raja R Harinath <rharinath@novell.com>
7834 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
7837 2007-03-20 Bill Holmes <billholmes54@gmail.com>
7839 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
7840 ordered_member_list, to TypeBuilder to store members to be defined
7841 in the order they were parsed in.
7842 - ordered_explicit_member_list contains all properties indexers
7843 and methods that are defined as explicit implementation of an
7844 interface or base class.
7845 - ordered_member_list contains all properties indexers and methods
7846 that are not defined as explicit implementation of an interface
7849 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
7850 functionality in these removed classes has been replaced with
7851 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
7852 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
7854 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
7855 to CheckForDuplications inside GetMethod and SetMethod Define Method
7856 to handle method property and indexer name conflicts.
7860 All code is contributed under the MIT/X11 license.
7862 2007-03-20 Martin Baulig <martin@ximian.com>
7864 * class.cs (TypeContainer.Interfaces): Removed; they're now
7865 included in `TypeContainer.Types'.
7867 2007-03-20 Martin Baulig <martin@ximian.com>
7869 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
7871 * class.cs (TypeContainer.CreateType): New public method. This is
7872 now called before DefineType() to create the TypeBuilders.
7873 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
7874 has already been created by CreateType().
7875 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
7876 don't resolve our base classes here; this has been moved into
7877 DefineBaseTypes(). We're now called from CreateType().
7878 (TypeContainer.DefineBaseTypes): New private method; resolve our
7879 base classes here. We're now called from DefineType().
7882 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
7883 our types first to create all the TypeBuilders. After that, call
7884 TypeContainer.DefineType() on all the types which'll resolve their
7885 base classes and setup the resolve order.
7887 2007-03-20 Martin Baulig <martin@ximian.com>
7889 * class.cs (TypeContainer.Enums): Removed; they're now included in
7890 `TypeContainer.Types'.
7892 2007-03-20 Martin Baulig <martin@ximian.com>
7895 (TypeContainer.DefineType): Don't call ResolveMembers() here.
7896 (TypeContainer.DoResolveMembers): Call DefineType() on our
7897 `compiler_generated' classes; moved here from DefineNestedTypes().
7900 (RootContext.ResolveTree): Call ResolveMembers() on all
7901 TypeContainer's in the `type_container_resolve_order'.
7903 2007-03-19 Marek Safar <marek.safar@gmail.com>
7905 * class.cs: Use corlib to handle InternalMethodImplAttribute.
7907 2007-03-17 Marek Safar <marek.safar@gmail.com>
7909 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
7910 implementation flags.
7912 2007-03-17 Marek Safar <marek.safar@gmail.com>
7914 * class.cs: More optimizations for type parameters.
7916 2007-03-15 Marek Safar <marek.safar@gmail.com>
7918 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
7920 * ecore.cs, parameter.cs: More common code for both corlibs.
7922 * typemanager.cs (IsGenericMethod): Simplified.
7924 2007-03-15 Raja R Harinath <rharinath@novell.com>
7926 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7928 * statement.cs, iterators.cs, lambda.cs: Update to changes.
7930 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
7931 unconditionally. Simplify explanation.
7932 (Try.Resolve, Using.Resolve): Likewise.
7934 2007-03-15 Martin Baulig <martin@ximian.com>
7938 * decl.cs (DeclSpace): If we're a partial class, use our
7939 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
7941 2007-03-15 Raja R Harinath <rharinath@novell.com>
7943 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7945 (FlowBranching.UsageVector): Update to changes.
7946 (FlowBranching.MergeSiblings): Likewise.
7947 * statement.cs: Likewise.
7949 2007-03-15 Martin Baulig <martin@ximian.com>
7954 (MemberCache): Added a special .ctor for type parameters.
7957 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
7960 2007-03-09 Martin Baulig <martin@ximian.com>
7962 * enum.cs (Enum): Make this a TypeContainer.
7963 (EnumMember): Derive from `Const'.
7966 (Const.DoResolveValue): New protected virtual method; move most of
7967 the functionality of ResolveValue() here so we can override it in
7969 (Const.CreateConstantReference): Make this virtual.
7971 * class.cs (Kind): Add `Kind.Enum'.
7972 (TypeContainer.Emit): Don't emit the enums here; they're already
7973 in the `RootContext.typecontainer_resolve_order'.
7975 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
7976 here; they're already in the `typecontainer_resolve_order'.
7978 * ecore.cs (EnumConstant.ConvertImplicitly): Add
7979 TypeManager.DropGenericTypeArguments().
7982 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
7983 (TypeManager.IsEnumType): Likewise.
7984 (TypeManager.EnumToUnderlying): Likewise.
7985 (TypeManager.IsEqual): Add support for enums.
7987 2007-03-12 Raja R Harinath <rharinath@novell.com>
7989 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
7990 DefaultParameterValueAttribute to be undefined, say if System.dll
7993 2007-03-11 Marek Safar <marek.safar@gmail.com>
7995 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
7998 2007-03-10 Marek Safar <marek.safar@gmail.com>
8000 * class.cs, parameter.cs: Unified parameters verification.
8002 2007-03-08 Martin Baulig <martin@ximian.com>
8004 * cs-parser.jay (constructor_header): Pass the location to the
8005 newly created TopLevelBlock.
8007 2007-03-07 Martin Baulig <martin@ximian.com>
8009 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8011 2007-03-06 Miguel de Icaza <miguel@novell.com>
8013 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8014 with the changes from David, fixes the build.
8016 2007-03-05 David Mitchell <dmitchell@logos.com>
8018 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8019 and its base interfaces to a one-dimensional array type S[],
8020 provided there is an implicit or explicit reference conversion
8023 2007-03-03 Marek Safar <marek.safar@gmail.com>
8025 * cs-tokenizer.cs: Implemented basic linq grammar.
8027 * driver.cs: Set linq lang version on demand.
8029 2007-02-26 Marek Safar <marek.safar@gmail.com>
8031 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8033 2007-02-25 Marek Safar <marek.safar@gmail.com>
8035 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8038 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8040 Check property and event extern attributes.
8042 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8045 2007-02-24 Marek Safar <marek.safar@gmail.com>
8047 A fix for bug #80407
8048 * ecore.cs: Don't report ambiguity error when methods have same parent.
8050 2007-02-23 Marek Safar <marek.safar@gmail.com>
8052 A fix for bug #80878
8053 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8055 2007-02-22 Marek Safar <marek.safar@gmail.com>
8057 * attribute.cs: Enable ExtensionAttribute presence test.
8059 2007-02-22 Marek Safar <marek.safar@gmail.com>
8061 * class.cs: Warn about missing GetHashCode only when Equals is override.
8063 * decl.cs: Check accessibility of type arguments.
8065 * typemanager.cs: Correctly report nullable array.
8067 2007-02-20 Marek Safar <marek.safar@gmail.com>
8069 * class.cs, report.cs: Capture more details when things go wrong.
8071 2007-02-20 Marek Safar <marek.safar@gmail.com>
8073 A fix for bug #80650
8074 * cs-parser.jay: Anonymous container starts at constructor declaration
8075 and not at block beginning because it has to be usable in constructor
8078 * statement.cs: Use context location and not block one for error reporting.
8080 2007-02-18 Marek Safar <marek.safar@gmail.com>
8082 A fix for bug #78712
8083 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8086 2007-02-18 Marek Safar <marek.safar@gmail.com>
8088 A fix for bug #80493 by Atsushi Enomoto
8089 * cs-parser.jay: Ignore invalid attribute target.
8091 2007-02-18 Marek Safar <marek.safar@gmail.com>
8093 * cs-tokenizer.cs: Ignore '\0' as white space character.
8095 2007-02-17 Miguel de Icaza <miguel@novell.com>
8097 * cs-parser.jay: Add support for lambda expressions to the mcs
8100 * lambda.cs: Only clone when we are probing, not on the final call
8101 (Compatible is the final call).
8103 * statement.cs (CloneContext): Introduce class to provide block
8104 remapping during clone.
8106 All statements Clone themselves now.
8108 (Clone): special handling for blocks, when we clone a block, we
8109 register the block inside this routine, as children of the block
8110 might trigger a lookup.
8112 * expression.cs: Add support for CloneContext in all expressions.
8114 2007-02-17 Marek Safar <marek.safar@gmail.com>
8116 A fix for bug #80493
8117 * statement.cs: Report ambiguous warning when interfaces are not related.
8119 2007-02-15 Marek Safar <marek.safar@gmail.com>
8121 C# 3.0 extension methods.
8123 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8124 cannot be used directly.
8126 * class.cs (Class.Emit): Emit extension attribute if any class method
8127 is extension method.
8128 (Method.Define): Add basic extension method validation conditions.
8129 (Method.Emit): Emit extension attribute for method.
8131 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8132 extension method exists. Currently we follow same approach as Microsoft
8133 does, emit even if a method or a class are private but this can change
8136 * cs-parser.jay: Add handling of `this' keyword in method parameters
8139 * decl.cs (DeclSpace.IsStaticClass): New property.
8140 (MemberCache.FindExtensionMethods): Looks for extension methods with
8141 defined name and extension type.
8143 * doc.cs: Updated after OverloadResolve changes.
8145 * driver.cs: Add new soft reference to System.Core.dll.
8147 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8148 (ExtensionMethodGroupExpr): Represents group of extension methods.
8150 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8151 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8152 to MethodGroupExpr and made non-static for easier customization.
8153 (Invocation.DoResolve): Add extension method lookup when no standard
8155 (MemberAccess.DoResolve): Try extension methods if no member exists.
8157 * modifiers.cs: Add METHOD_EXTENSION modifier.
8159 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8160 as well as candidate extension type.
8161 (ComputeNamespaces): When assembly constains extension methods registers
8163 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8164 extension method lookup.
8165 (Namespace.LookupExtensionMethod): Looks for extension method in this
8167 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8168 find a method which matches name and extensionType.
8170 * parameter.cs (Parameter): Add This modifer.
8171 (HasExtensionMethodModifier): New property.
8172 (Resolve): Add extension parameter check.
8173 (ModFlags): turned to property to exclude this modifier as it is not real
8175 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8177 * support.cs (ParameterData): Add ExtensionMethodType.
8178 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8180 * typemanager.cs: Add type and ctor extension attribute type.
8182 2007-02-15 Miguel de Icaza <miguel@novell.com>
8184 * report.cs (DisableErrors, EnableErrors): used to prevent error
8185 output when we are "trying" to compile various methods with
8188 * ecore.cs (Expression): Add Clone method that calls the virtual
8189 CloneTo method. The current CloneTo method in Expression throws
8190 an exception so we can track down all the places where this must
8191 be implemented (not using abstract, because that would be a lot of
8192 up-front-work before we can start testing the implementation
8195 Important: we only need Clone capabilities for expressions created
8196 by the parser, as the expressions we will be cloning are
8197 expressions in the pre-resolved state. This vastly simplifies
8200 (SimpleName): Add CloneTo that does nothing.
8201 (EmptyCast): Add CloneTo.
8203 * expression.cs (Binary): Implement CloneTo.
8204 (Invocation.IsApplicable): Store the current ec in
8205 EmitContext.TempEc and restore it on return. This is used so we
8206 do not have to sprinkle hundres of methods with an extra
8207 EmitContext, we know that the only user is the lambda expression
8208 ImplicitConversionExists code.
8210 (Argument): Add Cloning capabilities.
8211 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8212 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8213 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8214 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8215 IndexerAccess): Add Clone capability.
8217 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8219 (Argument): Add cloning capability.
8221 * assign.cs (Assign): Implement CloneTo.
8223 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8225 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8226 version by calling Convert with the EmitContext (that we are
8227 currently storing in ec, this is not great, but will do for now,
8228 to avoid passing EmitContext parameters to hundreds of functions
8229 that do not need them now).
8231 (SetExpression): Remove, it is not needed.
8233 (ContextualReturn): Implement CloneTo.
8235 * statement.cs (Statement): Implement cloning infrastructure,
8236 similar to expressions.
8238 (Block): Partial implementation of Clone for statements.
8240 (Return): Implement clone.
8242 * constant.cs (Constant.CloneTo): New method, does nothing.
8244 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8245 solution, until we decide how to exactly do this.
8247 2007-02-14 Marek Safar <marek.safar@gmail.com>
8249 A fix for bug #80493
8250 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8251 a property is override we need to use second accessor.
8253 2007-02-13 Marek Safar <marek.safar@gmail.com>
8255 A fix for bug #80418
8256 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8259 2007-02-13 Marek Safar <marek.safar@gmail.com>
8261 Another fix for bug #80749
8262 * pending.cs: Abstract class has priority over interfaces.
8264 2007-02-13 Marek Safar <marek.safar@gmail.com>
8266 Another fix for bug #80749
8267 * pending.cs: Abstract class has priority over interfaces.
8269 2007-02-13 Marek Safar <marek.safar@gmail.com>
8271 Another fix for bug #80749
8272 * pending.cs: Abstract class has priority over interfaces.
8274 2007-02-13 Marek Safar <marek.safar@gmail.com>
8276 Another fix for bug #80749
8277 * pending.cs: Abstract class has priority over interfaces.
8279 2007-02-13 Marek Safar <marek.safar@gmail.com>
8281 * class.cs Better error message.
8283 * driver.cs: Add shorter versions of -optimize option.
8285 2007-02-13 Martin Baulig <martin@ximian.com>
8287 * class.cs (Constructor.Emit): Check the return value of
8288 ec.ResolveTopBlock() and return on error.
8290 2007-02-13 Raja R Harinath <rharinath@novell.com>
8292 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8293 message to fix error message regression.
8295 2007-02-12 Marek Safar <marek.safar@gmail.com>
8297 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8299 2007-02-12 Marek Safar <marek.safar@gmail.com>
8301 A fix for bug #80749
8302 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8303 its parent container.
8305 * class.cs (DefineFieldInitializers): Each initializer can has different
8308 * const.cs: Updated.
8310 2007-02-11 Miguel de Icaza <miguel@novell.com>
8312 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8313 now all the heavy lifting to check that embedded statements or
8314 expressions have the right form is done in the ContextualReturn.
8316 (ContextualReturn): New class.
8318 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8319 method that can be invoked to report 201, so we do not replicate
8322 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8324 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8325 treating tabs as spaces.
8327 2007-02-09 Marek Safar <marek.safar@gmail.com>
8329 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8330 * assign.cs: Use full implicit conversion for right side check.
8332 2007-02-09 Marek Safar <marek.safar@gmail.com>
8334 * statement.cs (Switch): Switch over boolean type is not standardized.
8336 2007-02-08 Marek Safar <marek.safar@gmail.com>
8338 A fix for bug #80755
8339 * decl.cs (FindBaseEvent): Don't use method cache for events.
8341 2007-02-07 Marek Safar <marek.safar@gmail.com>
8343 * cs-parser.jay: Better syntax error handling.
8345 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8346 instead of underlying type value.
8348 2007-02-06 Marek Safar <marek.safar@gmail.com>
8350 * driver.cs: Check define identifier before is registered.
8352 * namespace.cs: Use existing error message.
8354 * report.cs: New warning.
8356 2007-02-06 Marek Safar <marek.safar@gmail.com>
8358 A fix for bug #80742
8359 * expression.cs: Delegate Invoke method can be called directly.
8361 2007-02-06 Marek Safar <marek.safar@gmail.com>
8363 A fix for bug #80676
8364 * class.cs (IsEntryPoint): The Main method can have params modifier.
8366 2007-02-04 Miguel de Icaza <miguel@novell.com>
8368 * parameter.cs (Parameter, Parameters): Add Clone method.
8370 * anonymous.cs (Compatible): Turn method into virtual method, so
8371 LambdaExpression can implement a different behavior.
8373 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8374 out the basic checking here, so it can be used by
8377 * lambda.cs: Introduce "Compatible" function that will do the
8380 2007-02-02 Marek Safar <marek.safar@gmail.com>
8382 * attribute.cs: Unified one error message.
8384 * class.cs (Class): Use type attributes and not properties to test static
8386 (IsEntryPoint): Don's pass local variable.
8388 * convert.cs: Removed duplicate check.
8390 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8392 * driver.cs: Don't crash when soft reference does not exist.
8394 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8395 (UsingEntry): Removed redundant allocation.
8397 * parameter.cs: Add fast path for type parameters.
8399 * support.cs: Don't allocate attribute when it's not used.
8401 2007-01-30 Miguel de Icaza <miguel@novell.com>
8404 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8405 this into a virtual method, so we can override it in LambdaExpression.
8407 * driver.cs: Improve diagnostics in case of failure.
8409 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8410 write a function that is slightly more complex and that parses:
8412 type identifier [, type identifier]* )
8414 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8417 (canEmpty ? i >= 0 : i > 0)
8419 2007-01-30 Raja R Harinath <rharinath@novell.com>
8421 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8422 exception on possibly valid code.
8424 2007-01-29 Raja R Harinath <rharinath@novell.com>
8426 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8428 (parse_opt_type_arguments): Remove. It's almost the same as
8430 (parse_namespace_or_typename): Use parse_less_than.
8432 2007-01-28 Miguel de Icaza <miguel@novell.com>
8434 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8435 this bug took a few hours to find, because the state saved and
8436 restored by PushPosition and PopPosition was ignoring the state of
8437 parse_generic_less_than.
8439 I can also now remove the handling of OP_LT and OP_GT, this solves
8442 * cs-tokenizer.cs: store the location for the ARROW token, we use
8445 (PushPosition, PopPosition): save/restore also `current_token',
8446 restore `parse_generic_less_than' (was missing).
8448 (parse_opt_type_arguments): use parse_type, not
8449 parse_namespace_or_typename to parse types.
8451 * lambda.cs: Empty new file, will eventually have the lambda
8452 expression implementation.
8454 * lambda.test: used to test the internal tokenizer.
8456 * report.cs (FeatureIsNotISO1): Rename from
8457 FeatureIsNotStandardized, because it was about the language level
8458 (1 vs 2) it was not about standarization.
8460 (FeatureRequiresLINQ): New.
8462 * support.cs (SeekableStreamReader): Only require that the reader
8463 is a TextReader, not a StreamReader, so we can plug StringReader.
8465 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8466 given position in the input stream the following tokens can be
8467 parsed as a type followed by an identifier.
8469 (is_punct): after a '(' if parse_type_and_parameter returns true,
8470 then return a special token OPEN_PARENS_LAMBDA which is used to
8471 avoid reduce/reduce errors in the grammar for the
8472 lambda_expression rules.
8474 (parse_type): implement a type parser inside the
8475 tokenizer, the parser only returns true or false depending on
8476 whether the input at a given position can be parsed as a type.
8478 (peek_token): new method used during type parsing.
8480 2007-01-28 Raja R Harinath <rharinath@novell.com>
8483 * anonymous.cs (ScopeInfo.InflateParameters): New.
8484 (AnonymousContainer.Resolve): Use it to redirect types of
8485 delegate parameters.
8487 2007-01-27 Raja R Harinath <rharinath@novell.com>
8490 * expression.cs (Error_InvalidArguments): Don't use two different
8491 messages for CS1503. Use ExtraInformation and
8492 SymbolRelatedToPreviousError instead.
8495 * decl.cs (DeclSpace.initialize_type_params): Don't access
8496 'type_params' of a partial class directly.
8498 2007-01-26 Miguel de Icaza <miguel@novell.com>
8500 * constant.cs: Removed a handful of out-of-range checks that were
8503 2007-01-25 Marek Safar <marek.safar@gmail.com>
8505 * expression.cs (CheckUselessComparison): Add additional check for char
8508 * namespace.cs: Fixed typo.
8510 2007-01-23 Miguel de Icaza <miguel@novell.com>
8512 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8513 gone, instead we inline the test, preventing the needless casts to
8514 longs, ulongs and doubles for the parameters, avoiding calls to
8515 methods that overchecked stuff, and instead inlined things
8518 2007-01-20 Marek Safar <marek.safar@gmail.com>
8520 * cs-parser.jay: Better parameter error handling.
8522 2007-01-17 Marek Safar <marek.safar@gmail.com>
8524 A fix for bug #80368, #80522
8525 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8526 whether array initializer contains constants only.
8527 (ArrayCreation.Emit): Use better formula to decide when
8528 are array initializers for static initialization.
8529 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8530 have to emit even constants otherwise they are pre-initialized.
8532 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8533 Raja R Harinath <rharinath@novell.com>
8535 Fix emit order of 'get' vs. 'set'.
8536 * support.cs (Accessors): New.
8537 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8538 Note the order in which accessors are declared in the source.
8539 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8540 Refactored from Property.Define and Indexer.Define.
8541 (PropertyBase.DefineAccessors): New helper that calls the above in
8542 appropriate order as noted by the parser.
8543 (Property.Define, Indexer.Define): Update to changes.
8544 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8546 2007-01-17 Raja R Harinath <rharinath@novell.com>
8548 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8549 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8550 there's an implicit conversion from the current type to the target
8551 type before converting the underlying constant.
8553 2007-01-16 Marek Safar <marek.safar@gmail.com>
8555 * const.cs (ResolveValue): Updated after constant conversion was made more
8558 * constant.cs (GetAttributableValue): constant to object conversion is
8559 used for attributes only.
8560 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8561 constant conversions.
8562 (LongConstant.ConvertImplicitly): Ditto.
8564 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8565 (ImplicitConversionStandard): Handle constant conversion as extra step.
8566 It solves the issue when constant conversion was called indirectly like
8567 inside array initializer and constant folding was skipped.
8569 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8572 * statement.cs(ImplicitConversionStandard): Updated after constant
8573 conversion was made more generic.
8575 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8577 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8578 Constraints, solves the problem where the compiler incorrectly
8579 reported that a type parameter was not constrained to a class (Bug
8582 2007-01-14 Marek Habersack <grendello@gmail.com>
8584 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8586 2007-01-14 Marek Safar <marek.safar@gmail.com>
8588 A fix for bug #80368
8589 * assign.cs (FieldInitializer): New class implements field
8590 initializer statement.
8592 * attribute.cs: Update after FieldMember rename.
8594 * class.cs (PropertyBasedMember): New common class for property based
8596 (InterfaceMemberBase): New base class for all members which can be used as
8597 an interface members.
8598 (MethodCore): Moved really common code to InterfaceMemberBase.
8599 (Method.Define): Equal and GetHasCode detection is relevant for methods
8601 (MethodData.Define): Don't assume that public event implements an
8602 interface automatically.
8603 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8605 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8606 (FieldMember): Merged with FieldBase.
8607 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8608 event extern modifier can be used.
8609 (EventField.EventFieldAccessor): Moved event field specific code here.
8610 (Event.AllowedModifiers): Even event can be extern.
8611 (Event.FindOutBaseMethod): New override specific to events.
8612 (Indexer.parameters): Reintroduce parameters because base class holds
8613 only properties common data.
8614 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8615 need do extra parameters check.
8617 * const.cs: Update after FieldMember rename.
8619 * decl.cs (MemberCache.FindBaseEvent): New method.
8621 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8622 to reflect that indexer is now derived from PropertyBased.
8624 * ecore.cs (GetMemberType): Made public.
8625 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8628 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8630 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8631 (RegisterEvent): Removed.
8632 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8633 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8635 2007-01-11 Raja R Harinath <rharinath@novell.com>
8638 * statement.cs (CollectionForeach.TryType): Prefer generic
8639 GetEnumerator over non-generic variant. Fix code to follow comments.
8641 2007-01-09 Raja R Harinath <rharinath@novell.com>
8644 * support.cs (ReflectionParameter): Don't use an invalid index on
8645 the generic parameter data.
8647 2007-01-08 Miguel de Icaza <miguel@novell.com>
8649 * driver.cs: Just add a tiny bit of infrastructure.
8651 2007-01-02 Marek Safar <marek.safar@gmail.com>
8653 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8654 where field type is struct from current assembly.
8656 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8659 2007-01-02 Marek Safar <marek.safar@gmail.com>
8661 A fix for bug #80381
8662 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8665 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8667 (Namespace.LookupType): Always use core types from corlib when speficied.
8669 * report.cs: A new warning.
8671 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8672 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8673 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8675 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8676 (InitCoreTypes): Set expression type of object_type and value_type
8677 immediately after lookup.
8679 2007-01-01 Miguel de Icaza <miguel@novell.com>
8681 * cs-tokenizer.cs: Accept Pc class characters (Connector
8682 Punctuation) as valid identifiers. Fixes #78259
8684 * expression.cs (Invocation.DoResolve): Moved the check for the
8685 use of `this' for doing method calls to the Invocation resolution
8686 step, after overload resolution has taken place instead of doing
8687 the check at the low-level `This.DoResolve' level.
8689 The `This.DoResolve'(appens before overload resolution, so it has
8690 no way of knowing if the method that will be called will be
8691 instace or static, triggering an erroneous report for cs0188 (Bug
8694 We now do the check for instance method invocations after we know
8695 what method will be called.
8697 (This.CheckThisUsage): Move the actual use of this structure
8698 checking into its own method and expose it.
8700 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8703 Exceptions: Null.ConvertImplicitly,
8704 Constant.ImplicitConversionRequired as there are too many call
8705 sites for passing the ec.
8707 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8708 EmitContext, if the value is null, then we do not try to provide
8709 the extra information from the error (If a userdefined conversion
8710 exists, as UserDefinedConversion requires a non null-EmitContext).
8714 2006-12-30 Raja R Harinath <rharinath@novell.com>
8716 * flowanalysis.cs (MyBitVector): Document some invariants.
8717 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8718 introduced below, and add a couple of others,
8720 2006-12-30 Marek Safar <marek.safar@gmail.com>
8722 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8723 GetPropertyFromAccessor and GetEventFromAccessor.
8725 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8726 overrides non-obsolete one.
8727 (Indexer.Define): Error message has been moved to the parser.
8729 * cs-parser.jay: Better syntax errors handling.
8731 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8732 when an invocation has no arguments.
8734 * ecore.cs: Removed not used caching.
8736 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8739 * report.cs: Add a new warning.
8741 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8743 * typemanager.cs (enumeration_type): Removed.
8744 (CSharpSignature): Reuses IsSpecialMethod.
8745 (IsEqual): Hack for MS BCL.
8746 (GetPropertyFromAccessor): New method.
8747 (GetEventFromAccessor): New method.
8748 (IsSpecialMethod): Fixed to handle more cases.
8750 2006-12-30 Marek Safar <marek.safar@gmail.com>
8752 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8753 Made white spaces array static.
8755 * ecore.cs (RemoveGenericArity): Optimized.
8757 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8759 (MyBitVector.initialize_vector): Simplified.
8761 2006-12-22 Miguel de Icaza <miguel@novell.com>
8763 * ecore.cs: Am not entirely happy with this hack, but it seems to
8764 address the issue in 80257 (a small test case for
8767 I set the MethodGroupExpr.Type to an internal compiler type
8768 (itself in this case) to force the resolution to take place. Why
8769 it does not take place with a null is beyond me.
8771 2006-12-20 Marek Safar <marek.safar@gmail.com>
8773 A fix for bug #80288
8774 * expression.cs (ResolveOperator): Consider user defined conversion for
8775 logical and operator too.
8776 (EmitBranchable): Optimization for logical and when full constant folding
8777 could not be applied but one operand is constant.
8779 2006-12-19 Marek Safar <marek.safar@gmail.com>
8781 * class.cs (GetClassBases): Write 5 times every day, will never use
8782 FullName for error reporting.
8784 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8786 2006-12-19 Martin Baulig <martin@ximian.com>
8788 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8789 the symbol file info here.
8791 2006-12-18 Marek Safar <marek.safar@gmail.com>
8793 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8794 of `elseif' is taking then following sections are not taking.
8795 Fixes an issue reported on mono mailing list.
8797 2006-12-18 Marek Safar <marek.safar@gmail.com>
8799 A fix for bug #80300
8800 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8801 a caller is not taking.
8803 2006-12-18 Raja R Harinath <rharinath@novell.com>
8805 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
8806 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
8807 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
8808 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
8809 * class.cs: Update to changes.
8811 2006-12-17 Marek Safar <marek.safar@gmail.com>
8813 A fix for bug #79934
8814 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
8817 * class.cs (ResolveMembers): Register an iterator in current container and
8820 2006-12-16 Raja R Harinath <rharinath@novell.com>
8823 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
8824 satisfy a params annotated parameter.
8826 2006-12-16 Marek Safar <marek.safar@gmail.com>
8828 A fix for bug #77014
8829 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
8830 paramters correctly and not rely on hacks in Parameters class.
8831 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
8833 (Invocation.VerifyArgumentsCompat): Ditto.
8834 (Invocation.EmitArguments): Changed to correctly emit params arguments at
8837 * parameter.cs (HasParams): Don't assume that params is the last one.
8839 * support.cs (ReflectionParameters.ctor): Look for params attribute
8841 (ReflectionParameters.ParameterType): Removed hack when we returned last
8842 parameter for out of range parameters.
8843 (ParameterName, ParameterModifier): Ditto.
8845 2006-12-14 Marek Safar <marek.safar@gmail.com>
8847 A fix for bug #79987
8848 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
8849 when assembly is not CLS compliant but type is. I have no idea why is this
8852 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
8854 2006-12-13 Miguel de Icaza <miguel@novell.com>
8856 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
8857 in struct constructors, they are basically no-ops.
8859 2006-12-12 Marek Safar <marek.safar@gmail.com>
8861 * cs-tokenizer.cs (Position): Save preprocessor status too.
8863 2006-12-12 Marek Safar <marek.safar@gmail.com>
8865 A fix for bug #77794
8866 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
8868 2006-12-12 Marek Safar <marek.safar@gmail.com>
8870 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
8872 (pp_expr): Report error for an invalid expression.
8873 (handle_preprocessing_directive): Simplified; add more error checking.
8875 2006-12-11 Marek Safar <marek.safar@gmail.com>
8877 A fix for bug #74939
8878 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
8879 directives handling.
8881 2006-12-10 Marek Safar <marek.safar@gmail.com>
8883 A fix for bugs #80093, and #75984
8884 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
8885 logic, it seems to me as it worked before "by coincidence".
8886 (xtoken): Simplified to use reworked handle_preprocessing_directive.
8887 (cleanup): Enabled endif check.
8889 2006-12-09 Marek Safar <marek.safar@gmail.com>
8891 A fix for bug #80162
8892 * statement.cs (CollectionForeach.TryType): Generics and non-generics
8893 enumerators are never ambiguous.
8895 2006-12-08 Raja R Harinath <rharinath@novell.com>
8898 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
8900 2006-12-06 Marek Safar <marek.safar@gmail.com>
8902 A fix for bug #80144
8903 * class.cs (EventProperty.Define): Explicit implementation means
8904 that an even is used.
8906 2006-12-06 Marek Safar <marek.safar@gmail.com>
8908 Fixes the operators implementation (part II)
8910 * cfold.cs (DoConstantNumericPromotions): Renamed to
8911 DoBinaryNumericPromotions and simplified.
8912 (BinaryFold): Couple of conversion fixes; simplified.
8914 * constant.cs, ecore.cs, literal.cs
8915 (ToType): Renamed to ConvertImplicitly.
8916 (Reduce): Renamed to ConvertExplicitly.
8918 * class.cs, convert.cs: Updated.
8920 * expression.cs: TryReduce doesn't throw an exception.
8922 2006-12-01 Marek Safar <marek.safar@gmail.com>
8924 A fix for bug #80108
8925 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
8928 2006-11-30 Marek Safar <marek.safar@gmail.com>
8930 Fixes unary operators implementation (part I)
8933 * cfold.cs (Error_CompileTimeOverflow): Made internal
8935 * const.cs (IConstant): Changed to use reference to constant and
8936 not constant itself.
8937 Updated IConstant implementations.
8939 * constant.cs (CreateConstant): New factory method.
8940 Updated IConstant implementation.
8942 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
8944 * ecore.cs: Updated to use CreateConstantReference.
8946 * enum.cs: Reflects IConstant changes.
8948 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
8950 * literal.cs (NullConstant): Change to be independently usable.
8952 2006-11-29 Martin Baulig <martin@ximian.com>
8954 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
8955 we need to emit the scope initializer before calling the base .ctor.
8957 * anonymous.cs: Merged back from the new anonymous methods branch.
8958 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
8960 * expression.cs (ParameterReference.DoResolveBase): Create a
8961 "normal" ScopeInfo when capturing parameters rather than using the
8962 root scope; this makes things work with anonymous methods having
8966 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
8968 2006-11-22 Marek Safar <marek.safar@gmail.com>
8970 A fix for bug #79987
8971 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
8972 check to a base class.
8973 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
8974 only when assembly has missing attribute.
8975 * report.cs: Update.
8977 2006-11-21 Marek Safar <marek.safar@gmail.com>
8979 * cs-tokenizer.cs: Merged with gmcs version.
8981 2006-11-20 Marek Safar <marek.safar@gmail.com>
8984 * cs-parser.jay: Better error message when partial keyword is misplaced.
8986 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
8988 A fix for bug #79810
8989 report.cs: CS1058 only applies to 2.0 profile (gmcs).
8990 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
8991 a RuntimeWrappedException by default.
8993 2006-11-18 Marek Safar <marek.safar@gmail.com>
8995 A fix for bug #79843
8996 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
8998 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9000 2006-11-18 Marek Safar <marek.safar@gmail.com>
9002 * driver.cs, namespace.cs: Uses faster IndexOf version.
9004 2006-11-17 Marek Safar <marek.safar@gmail.com>
9006 A fix for bug #79941
9007 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9009 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9010 even if internal name is different.
9011 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9012 (UserDefinedConversion): Simplified as the operators cannot be internal.
9013 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9015 (MethodLookup): Replaced EmitContext with parentType.
9016 * expression.cs: Updated.
9018 2006-11-09 Raja R Harinath <rharinath@novell.com>
9020 * driver.cs (BadAssembly): Handle all the ugliness of
9021 DefineDynamicAssembly.
9023 2006-11-08 Raja R Harinath <rharinath@novell.com>
9025 Address parts of #58244 -- most of what's left is in the runtime
9026 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9027 CS1509 error checks, and handle them for all assembly loads, not
9028 just the first invocation.
9029 (LoadModule): Likewise. Move handling of 'adder_method' ...
9030 * codegen.cs (AssemblyClass.AddModule): ... here.
9032 2006-11-02 Marek Safar <marek.safar@gmail.com>
9034 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9035 IEnumerable<T> is ambiguous.
9037 2006-10-31 Marek Safar <marek.safar@gmail.com>
9039 A fix for bug #67689
9040 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9041 GetEnumerator is ambiguous.
9043 * report.cs: Add new warning.
9045 2006-10-29 Marek Safar <marek.safar@gmail.com>
9047 A fix for bug #78602
9048 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9049 to protected member can be nested type.
9051 2006-10-28 Marek Safar <marek.safar@gmail.com>
9053 A fix for bug #78965
9054 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9055 to protected member must derive from current type.
9057 2006-10-27 Marek Safar <marek.safar@gmail.com>
9059 assign.cs: Reuses error method.
9061 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9062 instead of type for constants.
9063 (Expression.Error_ValueAssignment): Common error method.
9065 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9068 2006-10-27 Marek Safar <marek.safar@gmail.com>
9070 A fix for bug #79081
9071 * expression.cs (MemberAccess.DoResolve): Check nested type
9074 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9076 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9078 2006-10-26 Marek Safar <marek.safar@gmail.com>
9080 A fix for bug #76591
9081 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9083 2006-10-26 Marek Safar <marek.safar@gmail.com>
9085 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9086 type forwarder of the same type multiple times.
9088 2006-10-26 Raja R Harinath <rharinath@novell.com>
9091 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9092 instance as an rvalue, even when we later resolve as an lvalue.
9094 2006-10-25 Martin Baulig <martin@ximian.com>
9096 * anonymous.cs: Fix #79673.
9098 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9100 A fix for bug #79666
9101 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9102 ignored when is optimized (= default value) as its value is already set.
9104 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9106 A fix for bug #79724
9107 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9108 TypeContainer for type lookup.
9110 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9112 A fix for bug #79231
9113 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9114 * expression.cs (OverloadResolve): Always convert type name for
9116 (ResolveNamespaceOrType): Don't confuse a nested type with any
9119 2006-10-18 Martin Baulig <martin@ximian.com>
9121 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9123 2006-10-17 Miguel de Icaza <miguel@novell.com>
9125 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9126 an int32, but requesting an int64 from the conversion
9128 2006-10-12 Martin Baulig <martin@ximian.com>
9131 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9133 2006-10-12 Martin Baulig <martin@ximian.com>
9136 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9138 2006-10-11 Miguel de Icaza <miguel@novell.com>
9140 * convert.cs: Remove broken code: I was doing the "Existance"
9141 tests for Implicit conversions.
9143 2006-10-10 Miguel de Icaza <miguel@novell.com>
9145 * convert.cs: Added one missing case in
9146 ImplicitStandardConversionExists uint64 to intptr.
9150 * typemanager.cs (uintptr_type): another core known type.
9152 * ecore.cs (OperatorCast): routine used to do cast operations that
9153 depend on op_Explicit. We could change some of the Decimal
9154 conversions to use this.
9156 This one has a probe mechanism that checks both types for an op_
9157 which it coudl be used to eliminate two classes: CastToDecimal
9158 and CastFromDecimal.
9160 * convert.cs: Implement the conversions documented in #59800
9162 2006-10-10 Martin Baulig <martin@ximian.com>
9164 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9165 before RootScope.ResolveMembers().
9167 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9168 `CurrentType' if appropriate.
9170 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9172 A fix for bug #78568
9173 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9174 when contains binary operators.
9175 * cs-parser.jay: Updated.
9177 2006-10-09 Martin Baulig <martin@ximian.com>
9180 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9181 moved that into Define() and also do the other type parameter
9182 checks there. Fixes #79094. Added gtest-292.cs.
9185 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9186 since that doesn't include type parameters; don't use `Ldelema'
9187 for type parameters. Fixes #78980. Added gtest-293.cs.
9189 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9192 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9193 conversion is allowed.
9195 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9197 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9198 error reporting when no error occurs.
9200 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9202 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9205 2006-10-06 Raja R Harinath <rharinath@novell.com>
9208 * class.cs (DefineTypeBuilder): Check circular dependencies before
9209 setting the parent of the TypeBuilder.
9210 (CheckRecursiveDefinition): Don't use 'BaseType', since
9211 it may not be valid until after DefineTypeBuilder. Use
9212 'base_type' instead.
9214 2006-10-04 Martin Baulig <martin@ximian.com>
9216 Merged the Anonymous Methods patch.
9218 * anonymous.cs, iterators.cs: The new anonymous methods code.
9220 * statement.cs (Variable): New public abstract class.
9221 (LocalInfo.Variable): New public property.
9222 (LocalInfo.ResolveVariable): New public method.
9223 (Block.Flags): Add `IsIterator'.
9224 (Block.AddVariable): Improved the CS0136 check.
9225 (Block.AnonymousChildren): New public property.
9226 (Block.AddAnonymousChild): New public method.
9227 (ToplevelBlock): Update to use the new anonymous method framework.
9228 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9229 `ToplevelBlock'; this is required to correctly implement the
9231 (Fixed, Using): Use `TemporaryVariable' instead of directly
9232 creating the `LocalBuilder'.
9234 * parameter.cs (Parameter.ResolveVariable): New public method.
9235 (Parameters.ResolveVariable): Likewise.
9237 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9239 * class.cs (TypeContainer): Replaced the `iterators' list and
9240 corresponding methods with a list of `CompilerGeneratedClass'es.
9241 (TypeContainer.ResolveMembers): New public method.
9242 (Method): `IIteratorContainer' has been replaced by
9245 * expression.cs (VariableReference): New public abstract base
9246 class for `LocalVariableReference', `ParameterReference' and
9249 * codegen.cs (EmitContext): Removed `capture_context',
9250 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9251 (EmitContext.EmitThis): Removed.
9253 * cs-parser.jay: Replace `iterator_container' with
9256 2006-10-04 Martin Baulig <martin@ximian.com>
9258 * generic.cs (GenericMethod): Don't make this abstract.
9259 (Constraints.Clone): Added dummy implementation.
9261 2006-10-04 Raja R Harinath <harinath@gmail.com>
9264 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9265 'declspaces'. Avoid allocating arrays willy-nilly.
9268 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9269 cases out of the switch.
9271 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9273 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9274 message when non-generic type is used with the type arguments.
9275 * expression.cs: Updated.
9277 2006-09-28 Raja R Harinath <rharinath@novell.com>
9280 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9281 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9282 Change semantics slightly. Don't insist on having only one
9283 temporary EmptyExpression -- just throttle the creation of new ones.
9286 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9287 non-interfaces too. If no methods are found, don't try to create
9290 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9292 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9295 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9296 us produce better error message.
9298 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9300 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9301 of the `|' operator.
9303 * report.cs: A new warning added.
9305 2006-09-27 Martin Baulig <martin@ximian.com>
9307 * generic.cs (GenericMethod): Don't make this abstract.
9309 2006-09-27 Martin Baulig <martin@ximian.com>
9312 (InternalErrorException): Added overloaded ctor taking a params array.
9314 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9316 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9317 Fixed the cases when same error was reported twice.
9319 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9320 now report symbol information.
9322 2006-09-25 Martin Baulig <martin@ximian.com>
9324 * class.cs: Completely unified with the gmcs version.
9326 2006-09-25 Martin Baulig <martin@ximian.com>
9328 * typemanager.cs (TypeManager.IsNullableType): New public function.
9329 (TypeManager.IsNullableTypeOf): Likewise.
9330 (TypeManager.IsNullableValueType): Likewise.
9332 * class.cs (MethodCore): Added the `GenericMethod' argument from
9333 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9335 2006-09-24 Raja R Harinath <harinath@gmail.com>
9337 * convert.cs: Unify with gmcs version.
9339 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9341 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9342 verify them as well.
9344 * report.cs: New warning.
9346 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9348 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9349 for anonymous block with out argument.
9351 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9353 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9354 not used private events only.
9356 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9358 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9360 * const.cs (Const.Define): Check for constant type.
9361 (Const.IsConstantTypeValid): Looks for valid constant types.
9363 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9365 * ecore.cs (EmptyConstantCast): New common class for all constant based
9368 * expression.cs (Is.DoResolve): Handle null constant especially.
9369 (New.DoResolve): Check for new void().
9370 (MemberAccess.DoResolve): Cope with all kind of nulls.
9372 * literal.cs (NullConstant): Uses EmptyConstantCast.
9373 (NullDefault): Based on EmptyConstantCast.
9374 (NullLiteral): Uses EmptyConstantCast.
9376 * statement.cs (Block.ResolveMeta): Check for constant type.
9378 2006-09-22 Martin Baulig <martin@ximian.com>
9380 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9382 2006-09-22 Raja R Harinath <rharinath@novell.com>
9384 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9388 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9389 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9392 2006-09-22 Martin Baulig <martin@ximian.com>
9394 * ecore.cs: Merged with the gmcs version.
9396 * generic.cs (ConstructedType): New dummy class.
9397 (TypeArguments): Don't make this abstract.
9400 (TypeManager.IsGenericTypeDefinition): New method.
9401 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9403 2006-09-22 Raja R Harinath <rharinath@novell.com>
9405 * expression.cs (ComposedCast): Check for arrays of TypedReference
9406 before creating the type, not after.
9408 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9410 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9411 after ToType change.
9413 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9414 when constant must be implicitly convertible.
9416 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9418 * ecore.cs (NullCast): Derives from NullConstant.
9420 * expression.cs (Is.DoResolve): Removed useless variables.
9421 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9422 (New.Constantify): Add enum support.
9423 (MemberAccess.DoResolve): Add warning when accessing null constant or
9426 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9429 * literal.cs (NullConstant): New abstract class with common
9430 functionality for all null specializations.
9431 (NullDefault): Represents default(X) when result can be
9433 (NullLiteral): Updated.
9435 * report.cs: Add new warning.
9437 2006-09-21 Martin Baulig <martin@ximian.com>
9439 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9441 2006-09-21 Martin Baulig <martin@ximian.com>
9443 * generic.cs (GenericConstraints): New dummy class.
9444 (Constraints): Likewise.
9445 (TypeParameter): Likewise.
9446 (TypeParameterName): Likewise.
9447 (GenericMethod): Likewise.
9449 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9451 * decl.cs: Merged with the gmcs version.
9453 2006-09-21 Raja R Harinath <rharinath@novell.com>
9455 * generic.cs (TypeParameter): Implement IMemberContainer.
9456 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9458 * rootcontext.cs: Unify with gmcs version.
9460 * report.cs: Unify with gmcs version.
9461 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9462 from gmcs/generics.cs.
9463 * generics.cs (TypeParameter): New dummy class.
9465 * support.cs: Unify with gmcs version.
9467 2006-09-20 Raja R Harinath <rharinath@novell.com>
9469 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9470 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9472 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9473 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9474 * mcs.exe.sources: Add generic.cs.
9476 * codegen.cs: Unify with gmcs version.
9478 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9479 (EmitContext): Add GenericDeclContainer implementation.
9480 * decl.cs (MemberCore, DeclSpace): Likewise.
9481 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9483 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9484 MCS TypeManager has a corresponding dummy method.
9486 2006-09-19 Martin Baulig <martin@ximian.com>
9488 * expression.cs: Completely merged with the gmcs version.
9490 2006-09-19 Martin Baulig <martin@ximian.com>
9492 * expression.cs (Invocation): Merged with the gmcs version.
9493 (ArrayAccess.GetStoreOpcode): Likewise.
9495 2006-09-19 Martin Baulig <martin@ximian.com>
9498 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9499 (TypeManager.IsGenericMethodDefinition): Likewise.
9501 2006-09-19 Martin Baulig <martin@ximian.com>
9504 (TypeManager.IsEqual): Moved the gmcs implementation here.
9505 (TypeManager.DropGenericTypeArguments): Likewise.
9506 (TypeManager.DropGenericMethodArguments): Likewise.
9507 (TypeManager.GetTypeArguments): Moved here from gmcs.
9508 (TypeManager.HasGenericArguments): Likewise.
9510 2006-09-19 Martin Baulig <martin@ximian.com>
9512 * expression.cs (Binary): Merged with the gmcs version.
9514 2006-09-19 Martin Baulig <martin@ximian.com>
9516 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9518 2006-09-19 Martin Baulig <martin@ximian.com>
9520 * typemanager.cs: Merged with the gmcs version.
9522 2006-09-16 Raja R Harinath <rharinath@novell.com>
9524 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9525 * driver.cs: Likewise.
9527 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9530 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9531 only if parent type is class.
9532 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9535 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9538 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9540 * typemanager.cs(CSharpName): Converts NullType to null.
9542 2006-09-15 Martin Baulig <martin@ximian.com>
9545 (TypeManager.GetMethodName): Added mcs implementation.
9546 (TypeManager.IsEqual): Likewise.
9549 (SimpleName.RemoveGenericArity): Added dummy implementation.
9551 * pending.cs: Merged with the gmcs version.
9553 2006-09-15 Martin Baulig <martin@ximian.com>
9555 * statement.cs: Merge with the gmcs version.
9557 2006-09-15 Martin Baulig <martin@ximian.com>
9559 * statement.cs (Switch): Merge with the gmcs implementation
9560 (without nullables), which is newer.
9562 2006-09-15 Martin Baulig <martin@ximian.com>
9564 * statement.cs (Block.Variables): Make this public.
9565 (ToplevelBlock.Parameters): Make this a property.
9566 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9568 2006-09-15 Martin Baulig <martin@ximian.com>
9570 * namespace.cs: Merge with the gmcs version.
9572 2006-09-15 Martin Baulig <martin@ximian.com>
9574 * decl.cs (MemberName): Minor code cleanups.
9576 2006-09-15 Martin Baulig <martin@ximian.com>
9578 * parameter.cs: Merge with the gmcs version.
9580 2006-09-15 Martin Baulig <martin@ximian.com>
9582 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9583 and an error in mcs.
9585 2006-09-15 Martin Baulig <martin@ximian.com>
9587 * flowanalysis.cs: Merged from GMCS; added the generics code into
9588 a `GMCS_SOURCE' conditional so we can share this file.
9590 2006-09-08 Martin Baulig <martin@ximian.com>
9592 * typemanager.cs (TypeManager.interlocked_type): New public field.
9593 (TypeManager.int_interlocked_compare-exchange): New public field.
9594 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9595 enumerator types here and call InitGenericCoreTypes().
9596 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9597 after calling InitEnumUnderlyingTypes().
9600 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9601 `classes_second_stage'.
9603 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9605 * assign.cs, ecore.cs, expression.cs: Share error message text.
9606 * class.cs (FieldMember.Define): Check for varible of static type.
9607 * driver.cs (LoadAssembly): Uses error output for errors.
9608 * statement.cs: Updated.
9610 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9612 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9615 2006-09-07 Martin Baulig <martin@ximian.com>
9618 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9620 2006-08-29 Miguel de Icaza <miguel@novell.com>
9622 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9624 2006-08-17 Miguel de Icaza <miguel@novell.com>
9626 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9627 #52019 and #79064, the use of the \uXXXX sequence in source code
9628 to represent unicode characters.
9630 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9632 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9634 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9636 2006-08-13 Miguel de Icaza <miguel@novell.com>
9638 * assign.cs: Catch attempts to assign to a method groups in += and
9641 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9644 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9646 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9648 * class.cs (Method.Define): Issue a warning when generic method looks like
9650 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9653 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9655 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9657 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9658 search all base interfaces as a member can be ambiguous.
9659 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9660 Constructor member type filter.
9661 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9662 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9663 reporting for returned memberinfos.
9664 * report.cs: Updated.
9665 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9666 version to work on all runtimes.
9667 (TypeManager.RealMemberLookup): Removed members filtering.
9669 2006-08-08 Raja R Harinath <rharinath@novell.com>
9671 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9672 (PropertyExpr.EmitAssign): Likewise.
9673 * expression.cs (Indirection.EmitAssign): Likewise.
9674 (LocalVariableReference.EmitAssign): Likewise.
9675 (ParameterReference.EmitAssign): Likewise.
9676 (Invocation.EmitArguments): Likewise.
9677 (ArrayAccess.EmitAssign): Likewise.
9678 (IndexerAccess.EmitAssign): Likewise.
9679 (This.EmitAssign): Likewise.
9680 (ConditionalLogicalOperator.Emit): Likewise.
9683 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9684 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9685 leave it in after returning it.
9686 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9688 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9690 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9693 2006-08-03 Raja R Harinath <rharinath@novell.com>
9695 Fix cs0146-3.cs and cs0146-4.cs.
9696 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9697 enclosing types don't depend on the current type.
9699 2006-08-02 Raja R Harinath <rharinath@novell.com>
9702 * class.cs (TypeContainer.DoDefineMembers): Use
9703 FindBaseMemberWithSameName on Parent, since we're interested in
9704 whether we hide inherited members or not.
9705 (FindBaseMemberWithSameName): Make slightly more robust.
9707 Fix the non-generic testcase from #77396
9708 * decl.cs (DeclSpace.DeclContainer): Remove override.
9710 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9711 declspaces for doppelgangers too.
9712 (UsingEntry): Implement IResolveContext.
9713 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9714 'this' as the resolve context.
9715 (LocalAliasEntry): Likewise.
9717 Implement parts of #77403
9718 * roottypes.cs (RootDeclSpace): New. Used to represent the
9719 toplevel declaration space. Each namespace declaration introduces
9720 a "partial" root declaretion space.
9721 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9722 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9723 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9724 from 'current_namespace.SlaveDeclSpace'.
9725 (namespace_declaration): Likewise.
9726 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9727 check. It can't happen now.
9728 * decl.cs (DeclSpace.LookupType): Likewise.
9729 * driver.cs (MainDriver): Sanity check.
9731 2006-08-01 Raja R Harinath <rharinath@novell.com>
9733 * decl.cs (DeclSpace.FindNestedType): Remove.
9734 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9735 LookupTypeContainer to get the container of the nested type.
9736 * class.cs (TypeContainer.FindNestedType): Make non-override.
9738 2006-07-31 Raja R Harinath <rharinath@novell.com>
9740 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9741 * class.cs (TypeContainer.PartialContainer): ... here.
9742 (TypeContainer.AddBasesForPart): New helper.
9743 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9745 * cs-parser.jay (current_class): Convert to DeclSpace.
9746 (struct_declaration, interface_declaration, class_declaration):
9747 Use AddBasesForPart instead of .Bases directly.
9748 * const.cs, iterators.cs: Update to changes.
9750 2006-07-28 Raja R Harinath <rharinath@novell.com>
9752 * class.cs (TypeContainer.AddMemberType): Rename from
9754 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9755 (AddTypeContainer): New. Combine AddClassOrStruct and
9757 (AddPartial): Update. Add 'is_partial' argument.
9758 * roottypes.cs: Update to changes.
9759 * cs-parser.jay (push_current_class): New helper for handling
9760 current_container and current_class.
9761 (struct_declaration, interface_declaration, class_declaration):
9764 2006-07-26 Raja R Harinath <rharinath@novell.com>
9766 * roottypes.cs: Rename from tree.cs.
9768 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9769 * tree.cs (Tree, ITreeDump): Remove types.
9770 * rootcontext.cs (tree, Tree): Remove fields.
9771 (root, ToplevelTypes): New.
9772 * *.cs: Update to rename.
9774 * tree.cs (Tree.RecordDecl): Remove.
9775 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9777 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9779 2006-07-23 Raja R Harinath <harinath@gmail.com>
9781 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9782 DoFlowAnalysis and OmitStructFlowAnalysis here.
9783 (ec.With): Rename from WithUnsafe and generalize.
9784 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9785 (ec.WithFlowAnalyis): New.
9786 * ecore.cs, expression.cs, statement.cs: Update.
9788 2006-07-22 Raja R Harinath <harinath@gmail.com>
9790 * statement.cs (Block.ResolveMeta): Simplify slightly.
9792 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9793 multiple boolean fields. Convert InUnsafe, constant_check_state,
9794 check_state to flags.
9795 (CheckState, ConstantCheckState): Update.
9796 (InUnsafe): New read-only property.
9797 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9799 (WithUnsafe): New helper similar to WithCheckState.
9800 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9801 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9803 2006-07-21 Raja R Harinath <rharinath@novell.com>
9805 Make comparisons use the same IL irrespective of whether they're
9806 in a 'checked' or 'unchecked' context: one of the issues in #78899
9807 * codegen.cs (EmitContext.CheckState): Make read-only property.
9808 (EmitContext.ConstantCheckState): Likewise.
9809 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
9810 helper that implement a save/restore stack for CheckState
9811 values. This is the only way to change check-state.
9812 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
9813 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
9814 (CheckedExpr.EmitBranchable): New forwarding method.
9815 (UnCheckedExpr): Likewise.
9816 * statement.cs (Block.ResolveMeta): Use WithCheckState.
9817 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
9818 (Checked.Resolve, checked.DoEmit): Likewise.
9820 2006-07-20 Miguel de Icaza <miguel@novell.com>
9822 * anonymous.cs: Cache the resolved anonymous delegate, and return
9823 this so that the ResolveTopBlock is only triggered once, not
9826 Currently we trigger ResolvetopBlock twice due to a first pass of
9827 argument check compatibility, and a second pass that does the
9830 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9832 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
9834 * rootcontext.cs (Reset): Add helper_classes.
9836 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9839 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
9842 2006-07-13 Miguel de Icaza <miguel@novell.com>
9844 * statement.cs (Lock): Handle expressions of type
9845 TypeManager.null_type specially. Fixes #78770
9847 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9849 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
9852 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9854 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
9855 for accessors as well.
9856 * ecore.cs (EventExpr): Add AccessorTable.
9858 2006-07-01 Marek Safar <marek.safar@seznam.cz>
9861 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
9862 for CS0122 where appropriate.
9863 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
9865 (Filter): Assembly can be null in the case of top level attributes.
9867 2006-06-25 Marek Safar <marek.safar@seznam.cz>
9871 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
9872 is done at global level.
9874 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9876 A fix for #77002, Implemented TypeForwarder support.
9878 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
9879 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
9880 * typemanager.cs (): Add type_forwarder_attr_type.
9882 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9884 * report.cs: Add CS0469 warning.
9886 2006-06-21 Martin Baulig <martin@ximian.com>
9888 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
9889 the `try'-block, so we also report CS0016 etc. there.
9891 2006-06-21 Martin Baulig <martin@ximian.com>
9894 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
9896 2006-06-21 Martin Baulig <martin@ximian.com>
9898 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
9899 also report CS1686 for parameters.
9901 2006-06-21 Martin Baulig <martin@ximian.com>
9903 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
9904 instead of an error if the value is not implicitly convertible to
9905 the switch types; fixes #77964.
9907 2006-06-21 Raja R Harinath <rharinath@novell.com>
9910 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
9911 FieldBuilder is null.
9914 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
9915 'left' and 'right' before error-checking.
9917 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
9919 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
9921 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
9922 (FieldExpr.DoResolve): likewise.
9923 (PropertyExpr.InstanceResolve): likewise.
9924 (EventExpr.InstanceResolve): likewise.
9926 2006-06-04 Marek Safar <marek.safar@seznam.cz>
9928 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
9929 attribute applicable tests for attribute argument.
9931 2006-06-02 Raja R Harinath <rharinath@novell.com>
9934 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
9935 (Binary.OverloadResolve_PredefinedIntegral): New.
9936 (Binary.OverloadResolve_PredefinedFloating): New.
9937 (Binary.OverloadResolve_PredefinedString): New.
9938 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
9939 Follow the standard more closely, and treat numeric promotions in
9940 terms of overload resolution.
9941 (Binary.CheckShiftArguments): Simplify.
9943 2006-06-01 Raja R Harinath <rharinath@novell.com>
9945 * flowanalysis.cs (MyBitVector): Simplify representation.
9946 (MyBitVector.Clone): Avoid allocating BitArray.
9947 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
9948 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
9949 (*): Update. Change all references to MyBitVector.And and
9950 MyBitVector.Or to &= and |=.
9952 2006-05-29 Raja R Harinath <rharinath@novell.com>
9955 * cs-parser.jay (formal_parameter_list): Extend the pattern below
9956 to param arguments too.
9958 2006-05-26 Miguel de Icaza <miguel@novell.com>
9960 * cs-parser.jay: Catch another parsing form for arglist being
9961 followed by other arguments. Fixes #78313.
9963 2006-05-24 Raja R Harinath <rharinath@novell.com>
9965 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
9966 checking of out parameters to ...
9967 (FlowBranchingToplevel.Merge): ... here.
9968 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
9969 set, propagate the origin upward, and only complain if there was
9971 (FlowBranchingException.AddContinueOrigin): Likewise.
9972 (FlowBranchingException.AddReturnOrigin): Likewise.
9973 (FlowBranchingException.AddGotoOrigin): Likewise.
9975 2006-05-23 Raja R Harinath <rharinath@novell.com>
9977 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
9978 unreachable, skip it.
9979 (FlowBranchingException.Merge): Always propagate jumps, even if
9980 the finally block renders subsequent code unreachable.
9982 2006-05-18 Raja R Harinath <rharinath@novell.com>
9985 * statement.cs (Goto.Resolve): Move responsibility for resolving
9986 'goto' to FlowBranching.AddGotoOrigin.
9987 (Goto.SetResolvedTarget): New. Callback to set the
9988 LabeledStatement that's the target of the goto.
9989 (Goto.DoEmit): Use Leave instead of Br when crossing an
9990 unwind-protect boundary.
9991 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
9992 LookupLabel and adjust to new semantics.
9993 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
9994 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
9995 Goto.SetResolvedTarget to update target.
9996 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
9997 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
9998 AddBreakOrigin & co. Delay propagation until ...
9999 (FlowBranchingException.Merge): ... this.
10001 * statement.cs (Block.Resolve): Always depend on flow-branching to
10002 determine unreachability. Kill workaround that originally emitted
10003 only one statement after an "unreachable" label (see infloop in
10006 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10007 This is still "wrong", but anything better would probably need a
10008 multi-pass algorithm.
10009 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10010 usage vector. Force current usage vector to be reachable, to
10011 optimistically signify backward jumps.
10012 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10014 (FlowBranchingLabeled.Merge): New. If no backward jump was
10015 detected, return the original salted-away usage vector instead,
10016 updated with appropriate changes. Print unreachable warning if
10018 * statement.cs (Block.Resolve): Don't print unreachable warning on
10019 a labeled statement.
10021 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10023 * driver.cs: Pass filename without path to AssemblyBuilder's
10024 AddResourceFile. Fixes bug #78407.
10026 2006-05-17 Raja R Harinath <rharinath@novell.com>
10028 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10029 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10030 (FlowBranching.MergeChild): Overwrite
10031 reachability information from Labeled branchings too.
10033 2006-05-16 Raja R Harinath <rharinath@novell.com>
10035 * statement.cs (Goto.Resolve): Merge jump origins here ...
10036 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10038 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10039 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10040 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10041 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10043 * statement.cs (Goto.Resolve): ... not here.
10044 (Goto.Emit): Remove CS1632 check.
10046 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10048 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10051 2006-05-11 Raja R Harinath <rharinath@novell.com>
10053 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10054 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10055 (FlowBranchingException.Label): Likewise.
10057 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10059 (MyBitVector.Or): Use it to avoid losing information (Count).
10060 (FlowBranching.MergeOrigins): Likewise.
10062 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10063 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10064 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10065 (UsageVector.ToString): Simplify.
10066 (UsageVector.MergeSiblings): Move here from ...
10067 (FlowBranching.Merge): ... here.
10068 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10071 2006-05-10 Raja R Harinath <rharinath@novell.com>
10073 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10074 null bitvector is treated as all-true.
10076 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10077 (MyBitVector): Rationalize invariants. 'vector != null' implies
10078 that we have our own copy of the bitvector. Otherwise,
10079 'InheritsFrom == null' implies all inherited bits are true.
10081 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10083 * statement.cs (LocalInfo): Add IsConstant.
10084 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10085 local variable for constants.
10087 2006-05-09 Raja R Harinath <rharinath@novell.com>
10089 * flowanalysis.cs (MyBitVector.Empty): New.
10090 (MyBitVector): Don't allow InheritedFrom to be null.
10091 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10092 (UsageVector, FlowBranching): Update to changes.
10094 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10095 recursion. The 'Parent == null' condition isn't sufficient for
10097 (FlowBranching.AddBreakOrigin): Likewise.
10098 (FlowBranching.AddContinueOrigin): Likewise.
10099 (FlowBranching.AddReturnOrigin): Likewise.
10100 (FlowBranching.StealFinallyClauses): Likewise.
10101 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10102 (FlowBranching.CheckOutParameters): Likewise.
10103 (FlowBranchingToplevel): Terminate all the above recursions here.
10104 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10105 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10107 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10109 (FlowBranchingToplevel): New. Empty for now.
10110 (FlowBranching.MergeTopBlock): Update.
10111 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10112 branching for the anonymous delegate.
10113 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10115 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10116 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10117 information at the start of the merge. Reorganize.
10119 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10121 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10123 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10125 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10126 to newly introduced ctor.
10128 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10129 message to one place.
10130 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10133 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10135 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10137 * ecore.cs (Expression.ResolveAsConstant): Updated.
10139 * statement.cs (ResolveMeta): Updated.
10141 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10143 * cs-parser.jay: __arglist cannot be used in initializer.
10145 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10148 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10151 2006-05-05 Raja R Harinath <rharinath@novell.com>
10153 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10154 (LabeledStatement): Add 'name' parameter.
10155 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10156 (Block.AddLabel): Update to changes.
10157 * cs-parser.jay (labeled_statement): Likewise.
10159 * flowanalysis.cs (BranchingType.Labeled): New.
10160 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10161 (FlowBranchingLabeled): New. Does nothing for now, but will
10162 eventually handle 'goto' flows.
10163 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10164 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10165 that's terminated ...
10166 (Block.Resolve): ... here.
10168 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10169 (UsageVector.MergeFinallyOrigins): Likewise.
10170 (FlowBranching.InTryOrCatch): Likewise.
10171 (FlowBranching.AddFinallyVector): Likewise.
10172 (FlowBranchingException): Update to changes.
10175 * statement.cs (Return.Resolve): Move error checking to ...
10176 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10177 (FlowBranchingException): Handle return origins like break and
10179 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10181 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10184 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10187 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10190 * class.cs (MethodData.Define): Do public accessor check only when method
10191 implements an interface.
10193 2006-05-04 Raja R Harinath <rharinath@novell.com>
10195 Remove special handling of 'break'
10196 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10197 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10198 (UsageVector.Break): Remove.
10199 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10201 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10203 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10204 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10206 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10209 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10210 be the interface member.
10212 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10215 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10216 for emitting small (int) values.
10218 2006-05-03 Raja R Harinath <rharinath@novell.com>
10221 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10222 control-flow passes through the 'finally' after merging-in all the
10223 control-flows from 'try' and the 'catch' clauses.
10225 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10226 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10227 always true at the only non-recursive entry point.
10228 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10229 FlowBranchingBreakable.
10230 (FlowBranchingLoop): Remove.
10231 * statement.cs (Return.DoResolve): Update to changes.
10234 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10235 (FlowBranching.CreateBranching): Handle it: create a
10236 FlowBranchingContinuable.
10237 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10238 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10239 except that it handles the 'continue' command.
10240 (FlowBranching.UsageVector.MergeOrigins): Rename from
10242 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10243 except that it overrides AddContinueOrigin.
10244 (FlowBranchingException): Override AddContinueOrigin, similar to
10246 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10247 Create a new branching around the embedded statement.
10248 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10249 control flow after the embedded statement.
10250 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10252 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10253 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10254 FlowBranchingBreakable.
10255 (FlowBranchingSwitch): Remove.
10258 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10259 error reporting to ...
10260 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10261 Rename from 'AddBreakVector'. Add new location argument. Return
10262 a bool indicating whether the 'break' crosses an unwind-protect.
10263 (FlowBranchingException.AddBreakOrigin): Add.
10264 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10265 flowbranching after updating with the effects of the 'finally'
10267 (FlowBranchingBreakable): New common base class for
10268 FlowBranchingLoop and FlowBranchingSwitch.
10270 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10271 embedded statement.
10272 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10274 2006-05-02 Raja R Harinath <rharinath@novell.com>
10276 * statement.cs (Do.Resolve): If the loop is infinite, set the
10278 (While.Resolve, For.Resolve): Set a barrier after the embedded
10279 statement. There's no direct control flow that goes from the end
10280 of the embedded statement to the end of the loop.
10281 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10282 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10283 above ensure that the reachability is correctly computed.
10285 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10286 (UsageVector.MergeBreakOrigins): If the current path is
10287 unreachable, treat it as if all parameters/locals are initialized.
10288 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10289 infinite loops before merging-in break origins.
10291 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10292 (Reachability.Reachable): Split part into ...
10293 (Reachability.Unreachable): ... this. Simplify.
10294 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10296 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10297 (Reachability.SetThrowsSometimes): Likewise.
10298 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10299 TriState.Always, use corresponding property.
10300 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10301 (Block.Resolve): Likewise. Remove some redundant checks.
10303 2006-05-02 Raja R Harinath <harinath@gmail.com>
10305 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10306 (Reachability.Meet): Don't bother checking AlwaysThrows --
10307 barrier is always set.
10308 (FlowBranchingBlock.Merge): Likewise.
10310 2006-05-01 Raja R Harinath <harinath@gmail.com>
10312 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10313 checks for unreachable.
10315 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10318 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10320 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10321 whether field is really assigned.
10323 2006-04-30 Raja R Harinath <harinath@gmail.com>
10325 * flowanalysis.cs (Reachability): Make 4-argument constructor
10327 (Reachability.Meet): Rename from 'And'. Remove static variant.
10328 (Reachability.Always): Rename from the highly misleading
10329 'Reachability.Never'.
10330 (FlowBranching.Merge): Update to changes. Mark an impossible
10331 situation with a 'throw'.
10332 (*): Update to changes.
10334 2006-04-29 Raja R Harinath <harinath@gmail.com>
10336 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10337 Remove 'Undefined'.
10338 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10339 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10340 (*): Update to changes.
10341 * statement.cs: Update to changes.
10343 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10346 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10348 2006-04-28 Raja R Harinath <harinath@gmail.com>
10350 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10353 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10354 argument to two arguments: an usage-vector and a bool. Move call
10355 to FlowBranching.Merge () ...
10356 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10358 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10359 handling of loop and switch reachability to ...
10360 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10362 2006-04-27 Raja R Harinath <harinath@gmail.com>
10364 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10365 handling to FlowBranchingLoop.InLoop.
10366 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10368 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10371 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10372 anonymous method is allowed from AnonymousContainer here.
10374 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10376 2006-04-24 Raja R Harinath <rharinath@novell.com>
10379 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10381 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10384 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10385 (DoubleConstant.Reduce): Ditto.
10387 2006-04-23 Raja R Harinath <rharinath@novell.com>
10389 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10390 Remove 'lvalue_right_side' argument. Move parts to ...
10391 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10392 (LocalVariable.DoResolveLValue): ... these.
10394 2006-04-21 Raja R Harinath <rharinath@novell.com>
10397 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10398 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10399 (LocalVariableReference.DoResolveBase): Use it to implement new
10401 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10402 (Argument.Resolve): Simplify. Move CS1510 check ...
10403 * ecore.cs (Expression.ResolveLValue): ... here.
10404 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10405 (PropertyExpr.DoResolveLValue): Likewise.
10406 (FieldExpr.Report_AssignToReadonly): Likewise.
10407 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10408 LValueMemberAccess or LValueMemberOutAccess on instance depending
10410 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10411 DoResolve as appropriate.
10413 2006-04-20 Raja R Harinath <rharinath@novell.com>
10416 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10417 implicit conversions on 'out' and 'ref' arguments.
10419 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10420 improve clarity. Remove dead code.
10423 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10424 (Catch.Resolve): Resolve VarBlock if it exists.
10426 2006-04-19 Miguel de Icaza <miguel@novell.com>
10428 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10429 twice, this was some residual code, the enumerator was emitted
10430 properly in the two branche of if later.
10432 2006-04-19 Raja R Harinath <rharinath@novell.com>
10434 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10435 cast is never an lvalue.
10436 (Cast.DoResolve, Cast.ResolveRest): Combine.
10437 (Argument.Emit): Simplify slightly. Move 'Expr is
10438 IMemoryLocation' check ...
10439 (Argument.Resolve): ... here.
10440 (Argument.Error_LValueRequired): Remove. Inline into only user.
10442 Simplifications. Fix cs0191-2.cs
10443 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10444 CS1649 and CS1651 to ...
10445 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10446 the actual selection of the error code and message to a lookup
10447 table. Add a dummy return value to simplify callsites.
10448 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10449 readonly fields of other instances of the same type. Move CS0197
10451 * expression.cs (Argument.Resolve): ... here. Simplify code.
10452 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10453 resolution of an out or ref argument. The code simplification
10454 above uses this invariant.
10456 2006-04-18 Raja R Harinath <rharinath@novell.com>
10458 Possibly fix #77752. Fix cs1690-[4-7].cs.
10459 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10460 CheckMarshallByRefAccess. Drop parameter.
10461 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10463 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10464 InstanceExpression.
10465 * report.cs (AllWarnings): Add CS1690.
10466 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10467 for ref access too.
10468 (LocalVariableReference.DoResolveBase): Update.
10470 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10472 * class.cs (MethodOrOperator): Moved common parts from method class.
10473 detect obsolete attributes.
10474 (Method.Define): Simplified as it reuses code from base.
10475 (Constructor.ValidAttributeTargets): Fixed issue found during
10477 (Destructor.ValidAttributeTargets): Fixed issue found during
10479 (Operator): Finished refactoring set off by #78020. Operator class is now
10480 ordinary method class.
10482 * anonymous.cs: Updated.
10484 * decl.cs (DeclSpace): Add IsGeneric
10486 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10488 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10490 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10492 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10493 detect obsolete attributes.
10494 (Method.CreateEmitContext): Moved to MethodOrOperator.
10496 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10499 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10500 customized exception to make crash detection easier.
10501 (MethodOrOperator): Started to work on new base class for methods and
10503 (Method): Derives from MethodOrOperator.
10504 (Constructor.Emit): Emits its own attributes.
10505 (AbstractPropertyEventMethod.Emit): Ditto.
10506 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10508 (Operator.Emit): It's temporary more tricky than should be.
10510 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10512 * report.cs (InternalErrorException): Add ctor with inner exception.
10514 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10517 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10520 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10523 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10526 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10528 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10529 attribute is present and Guid not.
10530 (Interface.ApplyAttributeBuilder): Ditto.
10532 * attribute.cs: Add error message.
10534 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10538 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10539 sources (it's composite) so hold them in extra array as they are used in
10540 Emit phase only. It worked in the previous versions by mistake.
10541 (Attribute.Emit): Emit attribute for more owners when exist.
10543 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10544 it has now different behaviour.
10546 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10548 * constant.cs (Constant.IsDefaultInitializer): New method.
10550 * class.cs: Updated.
10552 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10553 re-initialize default values. It saves KBs almost for every assembly.
10554 Thanks Zoltan for the idea.
10555 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10556 (ArrayCreation.DoResolve): Resolve only once.
10557 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10558 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10560 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10562 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10565 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10567 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10568 in an embedded statement too.
10570 2006-04-01 Raja R Harinath <rharinath@novell.com>
10573 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10575 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10579 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10582 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10584 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10586 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10589 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10590 LocalTemporary change.
10592 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10594 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10595 initializers optimization.
10596 (ClassOrStruct.TypeAttr): Moved from modifiers.
10597 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10598 (FieldBase.ResolveInitializer): Resolves initializer.
10599 (FieldBase.HasDefaultInitializer): New property.
10601 * cs-parser.jay: Removed message.
10603 * expression.cs (CompilerGeneratedThis): New specialization.
10605 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10607 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10609 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10611 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10613 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10614 be now EnumConstants only.
10616 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10618 * attribute.cs, driver.cs: Reset more caches.
10620 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10622 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10624 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10626 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10627 for easier reuse. Updated all overrides.
10628 (IntegralConstant): New base class for all integral constants.
10629 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10630 of the constant range, report custom error.
10631 (UIntConstant.Reduce): Fixed uint conversion.
10633 * ecore.cs, literal.cs: Reduce updates.
10635 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10639 * class.cs (Constructor.Define): Removed extra if for default ctors.
10640 A patch from Atsushi Enomoto.
10642 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10644 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10645 GetAttributableValue.
10647 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10650 * convert.cs (ImplicitConversionRequired): Error message moved to
10653 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10654 automatic implicit conversion of an output value.
10655 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10657 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10659 (TypeOf.GetAttributableValue): Add extra handling for object type.
10661 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10662 special error message.
10664 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10666 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10668 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10669 compatible with MS runtime.
10671 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10673 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10674 attribute arguments here.
10676 * class.cs (Indexer.Define): The check was moved to attribute class.
10678 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10680 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10681 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10684 2006-03-22 Raja R Harinath <rharinath@novell.com>
10686 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10687 mcs to keep code differences small.
10688 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10689 * typemanager.cs (parameter_default_value_attribute_type): New.
10690 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10693 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10695 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10697 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10699 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10701 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10704 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10706 * doc-bootstrap.cs : fix build.
10708 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10710 * expression.cs (StringConcat.Append): Issue a warning when empty string
10711 is going to append.
10713 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10715 * assign.cs (CompoundAssign.ResolveSource): Removed.
10717 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10720 * class.cs (TypeContainer.FindMethods): Removed.
10721 (TypeContainer.CheckMemberUsage): Made static.
10723 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10725 * constant.cs (CheckRange): Removed unused type argument.
10726 (CheckUnsigned): Removed unused type argument.
10728 * cs-parser.jay: Updated after MemberAccess clean up.
10729 Uses Length for empty string test.
10731 * cs-tokenizer.cs: Uses Length for empty string test.
10732 (IsCastToken): Made static.
10733 (is_hex): Made static.
10734 (real_type_suffix): Made static.
10736 * decl.cs (SetupCache): Made static.
10737 (OnGenerateDocComment): Removed unused ds argument.
10739 * delegate.cs (VerifyDelegate): Removed unused argument.
10741 * doc.cs: Uses Length for empty string test.
10743 * driver.cs: Uses Length for empty string test.
10745 * enum.cs (IsValidEnumType): Made static
10747 * expression.cs (EnumLiftUp): Removed unused argument.
10748 (ResolveMethodGroup): Ditto.
10749 (BetterConversion): Ditto.
10750 (GetVarargsTypes): Ditto.
10751 (UpdateIndices): Ditto.
10752 (ValidateInitializers): Ditto.
10753 (MemberAccess.ctor): Ditto.
10754 (GetIndexersForType): Ditto.
10756 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10758 * iterators.cs: Updated after MemberAccess clean up.
10760 * location.cs: Uses Length for empty string test.
10762 * namespace.cs: Uses Length for empty string test.
10764 * report.cs (CheckWarningCode): Made static.
10766 * statement.cs (LabeledStatement): Removed unused argument.
10768 * typemanager.cs (FilterNone): Removed.
10770 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10772 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10775 * class.cs: Updated.
10777 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10779 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10781 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10785 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10786 reporting, it's more tricky than I thought.
10788 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10792 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10794 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10795 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10796 Add more error reporting; Fixed issue with params.
10798 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10800 * cs-parser.jay: AnonymousMethod requires host container.
10802 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10804 2006-03-18 Raja R Harinath <harinath@gmail.com>
10806 * class.cs: Change 'TypeContainer ds' constructor argument to
10807 'DeclSpace parent'. Some classes were missed below due to
10808 different naming convention.
10810 * class.cs (MemberCore.Parent): Delete. This makes the
10811 ParentContainer changes below enforceable by the compiler.
10813 Treat pointers to enclosing declaration space as 'DeclSpace', not
10815 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
10816 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
10818 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
10820 (Block.AddThisVariable): Likewise.
10821 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
10822 (AbstractPropertyEventMethod.Emit): Likewise.
10823 (AbstractPropertyEventMethod.EmitMethod): Likewise.
10824 (GetMethod.Define, SetMethod.Define): Likewise.
10825 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
10826 (DelegateMethod.EmitMethod): Likewise.
10828 Fix regression test-partial-13.cs.
10829 Rationalize use of PartialContainer. Ensure that the partial
10830 class semantics can be tied to type-correctness, i.e., any
10831 violation will cause a compile error.
10832 * class.cs, const.cs: Access all fields that belong to class
10833 TypeContainer via ParentContainer. Arguments of EmitContexts and
10834 Resolve()-like functions still use 'Parent'.
10836 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
10837 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
10838 (PropertyMethod.CheckModifiers): Remove unused argument.
10839 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
10842 2006-03-17 Raja R Harinath <harinath@gmail.com>
10844 Make semantics of PartialContainer simpler.
10845 * decl.cs (DeclSpace.IsPartial): Remove.
10846 * class.cs (TypeContainer.IsPartial): Likewise.
10847 (TypeContainer..ctor): Set PartialContainer to point to self.
10848 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
10849 (TypeContainer.FindNestedType): Likewise.
10850 (MemberCore.ParentContainer): Simplify. Remove deprecation.
10852 2006-03-17 Marek Safar <marek.safar@seznam.cz>
10854 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
10856 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10858 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
10861 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10863 * class.cs (Operator.Define): An error for base conversion was not
10864 reported correctly.
10866 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
10868 * iterator.cs : yield break is allowed in try statement which has
10869 catch clauses. Fixed bug #77767.
10871 2006-03-13 Marek Safar <marek.safar@seznam.cz>
10873 A fix for #77593, #77574.
10875 * class.cs (MethodCore.CheckBase): Another if for operator.
10877 2006-03-09 Marek Safar <marek.safar@seznam.cz>
10879 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
10882 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
10883 (DelegateCreation.ImplicitStandardConversionExists): New method for just
10886 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
10889 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
10890 Updated after another emitcontext usage was clean up. It should help us to
10891 synchronize with gmcs easier.
10893 2006-03-04 Marek Safar <marek.safar@seznam.cz>
10897 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
10898 (Event.Define): ditto
10899 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
10901 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
10902 Removed redundant code and set NewSlot for Invoke method too.
10904 * parameter.cs (Parameters.ctor): Add custom, type ctor.
10905 (Parameters.MergeGenerated): New method. Use this method when you merge
10906 compiler generated argument with user arguments.
10908 2006-03-03 Marek Safar <marek.safar@seznam.cz>
10910 * attribute.cs (ResolveAsTypeTerminal): Removed.
10912 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
10913 specialization for predefined types; 30% speed up.
10914 Finally placed obsolete check to right place.
10915 (Expression.ResolveType): Removed.
10917 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
10918 Updated after ResolveType was removed.
10920 * expression.cs (Cast.ctor): Check void cast.
10921 (Binary.ResolveAsTypeTerminal): Is never type.
10922 (Conditional.ResolveAsTypeTerminal): Is never type.
10924 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
10926 2006-03-01 Raja R Harinath <rharinath@novell.com>
10929 * expression.cs (ParameterReference.DoResolveBase): Change return
10931 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
10935 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
10938 * typemanager.cs (GetFullNameSignature): Don't nullref on
10939 protected accessors.
10941 2006-02-27 Marek Safar <marek.safar@seznam.cz>
10943 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
10944 these two separated members to simplify the code.
10945 (Attribute.Resolve): Refactored to use new fields and methods.
10946 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
10947 implemented obsolete attribute checking.
10948 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
10949 implemented obsolete checking again. It look line never ending quest ;-)
10950 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
10952 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
10954 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
10956 *class.cs (Property.Define): Add RegisterProperty call.
10958 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
10959 argument groups (only 2).
10961 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
10962 encoding expression to arguments.
10963 (Expression.ExprClassToResolveFlags): Just turned to property.
10965 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
10966 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
10967 optimized as well as implemented support for zero-length attributes.
10969 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
10970 Add caching of PropertyInfo's.
10972 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10974 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
10975 error multiple times.
10977 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10979 New partial class implementation.
10980 A fix for #77027, #77029, #77403
10982 * attribute.cs (Attributable): Made attributes protected.
10984 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
10985 the replacements of ClassPart and PartialContainer.
10986 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
10987 (TypeContainer.AddInterface): Ditto.
10988 (TypeContainer.AddPartial): The main method for partial classes. It checks
10989 for errors and merges ModFlags and attributes. At the end class is added to
10990 partial_parts list.
10991 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
10993 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
10994 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
10995 from the rest of partial classes.
10996 (TypeContainer.GetClassBases): Simplified.
10997 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
10999 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11000 (TypeContainer.HasExplicitLayout): Uses Flags now.
11001 (PartialContainer): Removed.
11002 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11003 (StaticClass): Was merged with Class.
11004 (Class.GetClassBases): class and static class bases are verified here.
11005 (Class.TypeAttr): Added static attributes when class is static.
11006 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11007 (MemberBase): In some cases we need to call parent container for partial
11008 class. It should be eliminated but it's not easy now.
11010 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11012 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11013 partial classed to accumulate class comments.
11014 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11016 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11018 * driver.cs (MainDriver): Tree.GetDecl was removed.
11020 * modifiers.cs (Modifiers): Add partial modifier.
11022 * tree.cs (Tree.decl): Removed.
11023 (RootTypes): Started to use this class more often for root types
11026 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11030 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11031 external interface does not have an attribute.
11033 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11035 Another prerequisites for new partial classs implementation.
11037 * attribute.cs (Attribute.Equal): Implemented.
11038 (Attribute.Emit): Changed as attributes can be applied more than twice.
11039 (Attributes.Emit): Check for duplicate attributes here.
11041 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11042 as a parameter, clean-up.
11044 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11048 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11049 contains obsolete attribute check which can in some cases look for base
11050 type of current class which is not initialized yet.
11051 (TypeContainer.BaseType): Replacement of ptype.
11053 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11055 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11057 First of prerequisites for new partial classs implemention.
11059 * attribute.cs (Attributable): Extended by ResolveContext;
11060 Attributes finally have correct context for resolving in all cases.
11061 (AttachTo): Attribute owner is assigned here.
11063 * codegen.cs (IResolveContext): Introduce new interface to hold
11064 all information needed in resolving phase.
11065 (EmitContext): Implements IResolveContext; more clean-up needed here.
11067 * decl.cs (MemberCore): Implemented IResolveContext.
11069 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11070 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11071 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11072 Refactored to use new IResolveContext instead of EmitContext; cleanup
11074 2006-02-06 Miguel de Icaza <miguel@novell.com>
11076 * codegen.cs (EmitScopeInitFromBlock): check here the
11077 capture_context, there is no need to make two calls to the
11080 * anonymous.cs: Add some debugging messages that might help me
11081 track other instances of this problem in the future (the
11082 regression of test 467).
11084 * cs-parser.jay: track the variable block, as we need to initalize
11085 any captured variables declared in this block for the "catch"
11086 portion of the "Try" statement.
11088 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11089 scope initialization for captured variables.
11091 Also, move the emit for the variables after the block location has
11094 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11096 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11098 2006-02-02 Miguel de Icaza <miguel@novell.com>
11100 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11101 commit yesterday, the initialization for the roots is necessary.
11102 What is not necessary is the scope activation.
11104 2006-02-02 Raja R Harinath <rharinath@novell.com>
11106 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11107 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11109 (Argument.Resolve): Remove CS0206 checks.
11111 2006-02-01 Miguel de Icaza <miguel@novell.com>
11113 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11114 scopes for all the roots, the scopes will now be emitted when the
11115 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11117 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11118 code. This reduces a lot of existing cruft.
11120 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11121 that the ScopeInfo is generated as we enter the scope, not at the
11122 time of use, which is what we used to do before.
11124 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11125 every time a Block is about to be emitted if we have a
11128 2006-02-01 Raja R Harinath <rharinath@novell.com>
11130 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11132 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11134 * typemanager.cs (cons_param_array_attribute): Make private.
11135 (Reset): Set it to null.
11136 (InitCoreHelpers): Don't initialize it.
11137 (ConsParamArrayAttribute): New. Initialize it as needed.
11138 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11140 2006-01-31 Miguel de Icaza <miguel@novell.com>
11142 * expression.cs: There might be errors reported during the
11143 selection of applicable methods. If there are errors, do not
11144 continue execution as it will lead the compiler to crash.
11146 2006-01-30 Miguel de Icaza <miguel@novell.com>
11148 * expression.cs: Member access is not allowed on anonymous
11149 methods. Fixes #77402.
11151 2006-01-30 Raja R Harinath <rharinath@novell.com>
11154 * cs-parser.jay (VariableDeclaration): Don't set
11155 current_array_type to null.
11156 (field_declaration, event_declaration, declaration_statement):
11157 Set it to null here.
11159 2006-01-28 Raja R Harinath <harinath@gmail.com>
11161 * typemanager.cs (GenericParameterPosition): New.
11164 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11166 * doc.cs : To process "include" elements, first we should create
11167 another list than XmlNodeList, because it could result in node
11168 removal, which could result in that the XmlNodeList gives up
11169 yielding next node.
11171 (Also made code identical to gmcs again.)
11173 2006-01-25 Miguel de Icaza <miguel@novell.com>
11175 * ecore.cs: Introduce an error report that we were not catching
11176 before, if not silent, we must report the error. Gonzalo ran into
11179 2006-01-23 Miguel de Icaza <miguel@novell.com>
11181 A fix for bug: #76957
11183 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11184 ComputeMethodHost before creating the method, this is a new
11187 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11188 that this method references (RegisterScope). The actual scope
11189 where the method is hosted is computed with the ComputeMethodHost
11190 before we create the method.
11192 Moved the Deepest routine here.
11194 (AnonymousContainer.ComputeMethodHost): New routine used to
11195 compute the proper ScopeInfo that will host the anonymous method.
11197 (ScopeInfo): Deal with multiple roots. The problem was that we
11198 did not have a unique root where all ScopeInfos could be hanged
11199 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11202 Remove AdjustMethodScope which is now computed at the end. Remove
11203 LinkScope which did a partial link, instead link all ScopeInfos
11204 before code generation from the new "LinkScopes" routine.
11206 Simplify all the Add* routines as they no longer need to maintain
11207 the tree, they just need to record that they are using variables
11210 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11211 routines to produce the forest of ScopeInfo trees.
11213 * class.cs (TypeContainer.AppendMethod): This is just like
11214 AddMethod, but ensures that an interface implementation method
11215 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11216 methods, but at the end.
11218 We use this functionality to ensure that the generated MoveNext
11219 method in the iterator class is resolved/emitted before the
11220 enumerator methods created.
11222 This is required because the MoveNext method computes the right
11223 ScopeInfo for the method. And the other methods will eventually
11224 need to resolve and fetch information computed from the anonymous
11227 2006-01-21 Raja R Harinath <harinath@gmail.com>
11228 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11230 Fix rest of #76995.
11231 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11232 the 'aliases' hash.
11233 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11234 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11236 2006-01-18 Raja R Harinath <rharinath@novell.com>
11238 Fix #76656, cs0231-2.cs.
11239 * cs-parser.jay (formal_parameter_list): Make error case catch
11241 (parenthesized_expression_0): Add CS1026 check.
11242 (invocation_expression): Remove unused { $$ = lexer.Location }.
11244 2006-01-17 Raja R Harinath <rharinath@novell.com>
11247 * cs-parser.jay (statement_expression): Don't list out the
11248 individual statement-expressions. Convert syntax error into
11251 2006-01-16 Raja R Harinath <rharinath@novell.com>
11254 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11255 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11256 CheckIntermediateModification.
11257 (FieldExpr.DoResolve): Add new two-argument version that
11258 allows us to resolve the InstanceExpression as an lvalue.
11259 The one-argument variant is now just a wrapper.
11260 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11261 Resolve the lhs as an lvalue if the it has a value type.
11262 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11263 from Assign.DoResolve.
11264 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11265 resolved as an lvalue.
11266 (PropertyExpr.DoResolve): Update.
11267 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11268 has a value type. Move CS1612 check here from
11269 CheckIntermediateModification.
11270 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11271 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11272 'right_side' of a ResolveLValue on an 'out' argument.
11273 (EmptyExpression.LValueMemberAccess): New. Used as the
11274 'right_side' of a propagated ResolveLValue on a value type.
11275 (LocalVariableReference.DoResolveBase): Recognize
11276 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11278 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11279 EmptyExpression.Null.
11281 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11283 * typemanager.cs : added IsGenericParameter(). In mcs it always
11285 * doc.cs : for generic parameters, use GenericParameterPosition,
11288 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11290 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11292 2006-01-12 Miguel de Icaza <miguel@novell.com>
11294 This fixes the problem where we used ldfld instead of ldflda to
11295 load the "THIS" pointer on captured parameters, when THIS is a
11296 value type. See bug #77205.
11298 * iterators.cs (CapturedThisReference.Emit): Pass false to
11299 EmitThis (we do not need the address).
11301 * codegen.cs (EmitThis): it needs to know whether we need the
11302 address of `this' or not. This is used by value types.
11304 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11305 every other call passes false.
11307 2006-01-12 Raja R Harinath <rharinath@novell.com>
11310 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11312 * expression.cs (Invocation.OverloadResolve): Update.
11313 (Invocation.DoResolve): Avoid double resolution of invocation.
11315 2006-01-11 Raja R Harinath <rharinath@novell.com>
11318 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11319 unary negation of floating point types as 0-expr; negation cannot
11320 overflow in floating point types.
11323 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11324 on operands of 'void' type.
11327 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11328 and ExclusiveOr for boolean constants too.
11330 2006-01-09 Raja R Harinath <rharinath@novell.com>
11333 * expression.cs (Invocation.OverloadResolve): Replace reflected
11334 override methods with their base virtual methods, rather than
11335 skipping over them.
11336 * typemanager.cs (TypeManager.GetOverride): New.
11338 2006-01-05 Jb Evain <jbevain@gmail.com>
11340 * class.cs (Property.Define, Indexer.Define): do not tag the
11341 properties as SpecialName | RTSpecialName.
11343 2006-01-04 Miguel de Icaza <miguel@novell.com>
11345 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11346 doing a low-level comparission of parameter types. It was lacking
11347 a check for __argslist.
11349 2005-12-30 Miguel de Icaza <miguel@novell.com>
11351 * expression.cs (ParameterReference.DoResolveBase): Allow
11352 reference parameters if they are local to this block.
11354 This allows the ref and out parameters of a delegate to be used in
11355 an anonymous method, for example:
11357 delegate void set (out int x);
11359 set s = delegate (out int x){
11363 This is used by functionality introduced late in the C# language.
11365 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11366 method that take ref and out parameters.
11368 Fixes #77119 which was a late change in the spec.
11370 2005-12-23 Miguel de Icaza <miguel@novell.com>
11372 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11373 parent if its the same scope. Fixes #77060.
11375 2005-12-21 Miguel de Icaza <miguel@novell.com>
11377 * driver.cs: Report the case of no source files and no -out:
11380 2005-12-20 Raja R Harinath <rharinath@novell.com>
11383 * expression.cs (ComposedCast.GetSignatureForError): Define.
11385 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11389 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11390 ListDictionary, to contain the ExternAliasEntry entries (in
11391 addition to the NamespaceEntry.aliases hashtable). This field is
11392 shared between the original entry and its doppelganger (bodyless
11394 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11395 extern_aliases field.
11396 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11397 lookup in extern_aliases.
11399 2005-12-16 Raja R Harinath <rharinath@novell.com>
11402 * class.cs (TypeContainer.Mark_HasEquals): New.
11403 (TypeContainer.Mark_HasGetHashCode): New.
11404 (ClassPart): Override them.
11405 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11408 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11409 'parent' argument to the base constructor.
11411 Remove all mention of TypeContainer from decl.cs.
11412 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11413 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11414 (DeclSpace.DeclSpace): Likewise.
11415 (DeclSpace.DefineMembers): Remove unused argument.
11416 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11417 debugging check -- we don't care if the debug code throws an
11418 InvalidCastException instead of an InternalErrorException.
11419 * class.cs (TypeContainer.DefineMembers): Update to changes.
11420 (TypeContainer.DoDefineMembers): Likewise.
11421 (TypeContainer.GetMethods): Likewise.
11422 (PropertyMember.Define): Likewise.
11423 (MemberBase.Parent): New property that forwards to
11424 MemberCore.Parent, but ensures that we get a TypeContainer.
11425 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11426 (RootContext.PopulateTypes): Likewise. Remove special case code
11427 for !RootContext.StdLib: DefineMembers is idempotent.
11429 2005-12-14 Miguel de Icaza <miguel@novell.com>
11431 * convert.cs (ExplicitConversionCore): Check the return value from
11432 ExplicitConversionCore which can return null on failure. Fixes #76914
11434 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11436 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11438 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11440 * doc.cs : The search for referenced namespace was insufficient to
11441 get global one as it used to do. Fixed bug #76965.
11443 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11445 * doc.cs : check name in cref in the last phase that whether it is
11448 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11450 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11453 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11455 * doc.cs : so it turned out that we cannot skip override check for
11456 interface members. Fixed bug #76954.
11458 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11460 * cs-tokenizer.cs : fixed bug #75984:
11461 - #warning and #error should not be handled when the source line
11463 - #line is not checked strictly when the source line is disabled.
11464 - #define and #undef is on the other hand checked strictly at any
11467 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11469 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11472 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11474 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11476 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11477 event initializers.
11478 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11479 (FieldBase.Initializer): Initializer is now optional.
11480 (EventField.Define): Only event field can have initializer.
11482 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11484 * const.cs (Const): Reuse initializer.
11486 * cs-parser.jay: Updated after FieldBase changes.
11487 Added current_array_type to simplify array initializers.
11489 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11491 * expression.cs, iterators.cs: Updated.
11493 * namespace.cs (NamespaceEntry): Made UsingFound private.
11495 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11497 * parameterCollection.cs: Obsolete, removed.
11498 * parser.cs: Obsolete, removed.
11500 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11503 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11505 * enum.cs (Enum.Define): Set obsolete context here.
11507 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11510 - FindDocumentedMember() now expects 1) paramList as null
11511 when "we don't have to check the number of parameters" and
11512 2) Type.EmptyTypes when "there is no arguments".
11513 - Introduced FoundMember struct to hold the exact type which was
11514 used to find the documented member (the above change broke
11515 test-xml-044; it might be better just to use DeclaringType than
11516 what MS does, like this change does, but it depends on usage.)
11518 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11520 * doc.cs : documented member might be from DeclaringType for nested
11521 types. Fixed bug #76782.
11523 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11525 * anonymous.cs: Have the param code handle leaving copies on the
11526 stack etc. Allows anonymous params to take part in the assignment
11527 code (++, +=, etc). Fixes bug #76550
11529 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11530 it down to the anon code.
11532 * iterators.cs: Use dummy var here
11534 * codegen.cs: Handle new vars
11536 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11539 * class.cs (MethodData.Define): Set proper Obsolete context.
11541 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11543 (FieldExpr.DoResolve): Ditto.
11545 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11548 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11549 parent is not obsolete.
11551 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11553 * doc.cs : (FindDocumentedMember) find parameterless members first
11554 and get CS0419 in the early stage. Fixed first case of bug #76727.
11556 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11559 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11560 no error was reported.
11562 *expression.cs (Binary.DoResolve): left can be null.
11564 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11567 * class.cs (MethodData.Emit): Parameters should be labeled first.
11569 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11572 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11574 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11576 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11578 * class.cs (MethodCore): Parameter clean up.
11579 (IMethodData): Added ParameterInfo.
11580 (MethodData): Parameter clean up.
11581 (Indexer.Define): Parameter clean up.
11593 * typemanager.cs: Parameter clean up.
11595 * delegate.cs (Define): Get rid of duplicated code.
11597 * expression.cs (ParameterReference): Removed useless parameters
11599 (Invocation): Ditto.
11601 * parameter.cs (ParamsParameter): New class, params specialization.
11602 (ArglistParameter): Attemp to separate arglist.
11603 (Parameter): Refactored to be reusable and faster.
11604 (Parameter.Modifier): Made understandable.
11605 (Parameters): Changed to be used as a class for `this' assembly
11606 parameters. Refactored to use new specialized classes.
11608 * support.cs (ParameterData): Added Types property.
11609 (InternalParameters): Deleted.
11611 2005-08-20 Martin Baulig <martin@ximian.com>
11613 Merging this patch from GMCS to fix #75867.
11615 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11616 scope if we don't already have it.
11618 2005-11-17 Martin Baulig <martin@ximian.com>
11621 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11622 inherit the scope from our parent. Fixes #76653.
11624 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11626 * doc.cs : the previous patch does not actually fix the bug.
11627 PropertyInfo override check is now implemented and really fixed it.
11628 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11630 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11632 * doc.cs : apply "override filter" also to properties.
11635 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11637 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11638 no need to check overrides. For classes, omit those results from
11639 interfaces since they must exist in the class. Fixed bug #76726.
11641 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11643 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11644 with different parameters. Fixed the second problem in #76685.
11646 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11648 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11649 get expected 'protected' access in CheckValidFamilyAccess()).
11652 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11654 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11655 Fixed bug #76705. CS1569 was incorrectly commented out.
11657 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11659 * doc.cs : use Invocation.IsOverride() to do real override check.
11660 * expression.cs : made Invocation.IsOverride() internal.
11662 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11664 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11665 TypeBuilder.FindMembers() and filter overriden base members out.
11668 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11670 * doc.cs : ref/out parameters are represented as '@' (instead of
11671 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11673 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11675 * doc.cs : when there was no '.' in cref to methods in doc comment,
11676 then parameters were missing in the output. Fixed bug #76691.
11678 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11680 * driver.cs : don't output docs when there is an error.
11683 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11686 Now it should detect indexers. Fixed primary concern in bug #76685.
11687 Fixed CS0419 message to not show the identical member signature in
11690 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11692 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11693 instead of Type.FindMembers() since it does not handle events.
11696 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11698 * codegen.cs: Fixed typo (speficied -> specified).
11700 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11703 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11705 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11707 * attribute.cs: Changed error message.
11709 * cs-tokenizer.cs: One more check.
11711 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11713 * statement.cs (Block.Resolve): Ignore empty statement.
11715 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11717 * report.cs: Made error/warning methods more strict to avoid
11720 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11721 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11722 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11723 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11725 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11727 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11728 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11730 * class.cs (TypeContainer.IsComImport): New property.
11731 (Constructor.Define): Create proper ctor for ComImport types.
11733 * expression.cs (New.CheckComImport): Fixed.
11735 2005-11-07 Miguel de Icaza <miguel@novell.com>
11737 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11738 that a parameter has been captured does not mean that we do not
11739 have to do the rest of the processing. This fixes the second part
11740 of #76592. If there was another anonymous method capturing
11741 values in the past, the Scope would never be set for the second
11742 method that captured the same parameter.
11744 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11745 properly manipulate the stack. Second part of fix for #76592.
11747 * expression.cs (New): Add support for invoking "new" on
11748 interfaces that have been flagged with the ComImport attribute and
11749 the CoClass. Fixes #76637
11751 * statement.cs (Try.DoEmit): When a variable is captured, do not
11752 try to emit the vi.LocalBuilder variable as it has been captured.
11753 Create a temporary variable and store the results on the
11754 FieldBuilder. Fixes #76642
11756 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11758 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11760 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11762 * expression.cs (Binary.DoResolve): Added && optimalization.
11764 * typemanager.cs (AddUserType): Removed useless argument.
11766 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11768 * statement.cs (Block.variables): Uses ListDictionary.
11770 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11773 * class.cs (PartialContainer.EmitType): Customized to emit
11774 security attributes.
11775 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11776 for partial classes.
11778 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11781 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11782 access has to be fixed.
11784 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11786 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11789 * ecore.cs (NullCast.Reduce): Implemented.
11791 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11794 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11796 (Foreach.Resolve): Catch null properly.
11798 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11800 * cs-tokenizer.cs: Warning text fix.
11802 * driver.cs: AllWarningNumbers exposed on public interface.
11804 * report.cs (): Reviewed warning numbers.
11805 (IsValidWarning): Use binary search.
11807 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11809 * driver.cs: Implemeted resource visibility.
11810 (Resources): New class for code sharing between /res: and
11813 2005-10-28 Marek Safar <marek.safar@seznam.cz>
11816 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
11819 * convert (Convert.ImplicitReferenceConversion): NullCast holds
11822 * ecore.cs (NullCast): Child is contant only.
11824 * literal.cs (NullLiteral.Reduce): null can be converted to any
11827 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
11829 * driver.cs: Use Encoding.Default as default code page instead
11832 2005-10-27 Raja R Harinath <rharinath@novell.com>
11835 * expression.cs (Invocation.Error_InvalidArguments): Handle
11836 __arglist parameters.
11837 (Invocation.VerifyArgumentsCompat): Likewise.
11838 * support.cs (ReflectionParameters.GetSignatureForError): Print
11839 __arglist parameters.
11840 (InternalParamters.GetSignatureForError): Likewise.
11841 * parameter.cs (Parameters.GetSignatureForError): Likewise.
11843 2005-10-26 Marek Safar <marek.safar@seznam.cz>
11845 * attribute.cs (GetPropertyValue): Made public.
11847 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
11849 Add new property WrapNonExceptionThrows to handle 2.0 assembly
11851 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
11854 * driver.cs: Reflect method name change.
11856 * statement.cs (Try.Resolve): Warn when try has both general
11857 exception handlers.
11859 * typemanager.cs: runtime_compatibility_attr_type new predefined
11862 2005-10-26 Raja R Harinath <harinath@gmail.com>
11865 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
11866 treat it as an empty parameter list.
11868 2005-10-26 Raja R Harinath <rharinath@novell.com>
11871 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
11872 ResolveAsTypeStep silent.
11873 * statement.cs (Block.AddConstant): Mark block as used.
11874 (Block.ResolveMeta): Avoid piling on error messages
11875 if a constant initializer resolution fails.
11877 2005-10-25 Raja R Harinath <rharinath@novell.com>
11879 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
11881 (NamespaceEntry.VerifyAllUsing): New.
11882 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
11883 behaviour. Delegates actual resolution of alias to ...
11884 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
11885 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
11887 * driver.cs (Driver.MainDriver): Update.
11889 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
11890 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
11892 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
11894 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
11895 RootNamespace.DefineNamespacesForAll.
11897 2005-10-24 Raja R Harinath <harinath@gmail.com>
11899 * typemanager.cs (assemblies, external_aliases, modules)
11900 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
11901 (ComputeNamespaces, GetRootNamespace): Remove extra staging
11902 overhead. Move resposibility ...
11903 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
11904 * driver.cs, attribute.cs, codegen.cs: Update to changes.
11906 2005-10-23 Raja R Harinath <harinath@gmail.com>
11908 * namespace.cs (RootNamespace.all_namespaces): Renamed from
11909 cached_namespaces. Improve usage.
11910 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
11911 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
11912 Move from GlobalRootNamespace and simplify.
11913 (RootNamespace.Global): Make instance variable.
11914 (RootNamespace.RootNamespace): Add "alias name" parameter.
11915 (GlobalRootNamespace): Simplify drastically.
11916 (Namespace.Lookup): Don't use GetNamespace.
11917 * typemanager.cs (GetRootNamespace): Rename from
11918 ComputeNamespaceForAlias.
11919 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
11921 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11923 * anonymous.cs (AnonymousContainer): Don't crash when container
11926 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11928 * expression.cs (Binary.DoResolve): Warn when comparing same
11931 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11934 * expression.cs (Binary.DoResolve): It looks like there are no
11935 convetsion rules in enum context.
11937 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11939 Add support for extern alias qualifiers.
11940 * typemanager.cs: Move some LookupTypeReflection code
11941 to namespace.cs, to have cleaner code. Added some methods
11942 to help us keep track of the extern aliased references.
11943 * driver.cs: Add suport for extern alias assemblies on command
11944 line and check for their warnings/errors. Also keep track of the
11945 extern aliased assemblies.
11946 * namespace.cs: Move the global functionality of Namespace
11947 to GlobalRootNamespace/RootNamespace. Now the global namespace
11948 is GlobalRootNamespace.Globa. Also the code moved from
11949 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
11950 Finally added LocalAliasEntry (AliasEntry before) and
11951 ExternAliasEntry, to handle alias statements.
11952 * cs-parser.jay: Add support in the grammar for extern alias
11954 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
11955 Update callings to Namespace (now in GlobalRootNamespace).
11957 2005-10-18 Raja R Harinath <rharinath@novell.com>
11960 * class.cs (TypeContainer.DefineType): Move updating of
11961 topological sort earlier in the code.
11962 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
11964 2005-10-18 Marek Safar <marek.safar@seznam.cz>
11967 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
11969 * constant.cs (Constant.TryReduce): Moved from Cast class.
11970 (Reduce): Made little bit more OO and fixed missing conversions.
11972 * ecore.cs (Reduce): Implemented.
11973 (Binary.EnumLiftUp): New method to upgrade values to enum values.
11975 * literal.cs (Reduce): Implemented.
11977 * class.cs: Reverted Miguel's wrong commit.
11979 2005-10-14 Miguel de Icaza <miguel@novell.com>
11981 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
11983 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
11985 * cs-parser.jay, expression.cs : CS0214 was missing error location
11986 for constants. Fixed bug #76404.
11988 2005-10-11 Marek Safar <marek.safar@seznam.cz>
11991 * convert.cs (ExplicitConversionCore): Fixed object->enum
11994 2005-10-10 Raja R Harinath <rharinath@novell.com>
11996 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
11997 InstanceExpression.
11998 (PropertyExpr.EmitCall): Likewise.
11999 * expression.cs (Invocation.EmitArguments): Handle case where
12001 (Invocation.EmitCall): Avoid allocating temporary variable if
12002 there are no arguments.
12004 2005-10-07 Raja R Harinath <rharinath@novell.com>
12007 * convert.cs (ImplicitConversionStandard): Move conversion of
12008 void* to arbitrary pointer types ...
12009 (ExplicitConversionStandard): .. here.
12010 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12011 error to always print typenames.
12013 2005-10-07 Raja R Harinath <rharinath@novell.com>
12015 * convert.cs (GetConversionOperator): Rename from
12016 GetConversionOperators. Move operator selection code from ...
12017 (UserDefinedConversion): ... here.
12019 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12021 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12024 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12026 * assign.cs (Assign.DoResolve): Error method changed.
12028 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12030 * const.cs (ResolveValue): Reset in_transit immediately.
12032 * constant.cs: Error method changed.
12034 * convert.cs: Removed useless location parameter.
12035 (ExplicitNumericConversion): Don't do double enum check.
12036 (ExplicitConversionCore): Renamed from ExplicitConversion.
12037 (ExplicitUnsafe): Extracted from ExplicitConversion.
12038 (ExplicitConversion): Uses for error reporting.
12040 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12042 (ResolveBoolean): Uses common error method.
12043 (CastToDecimal): Get rid of ec.
12044 (CastFromDecimal): Optimized.
12045 (ConvCast): Get rid of ec.
12047 * enum.cs (ResolveValue): Reset in_transit immediately.
12048 (Emit): Return after first error.
12050 * expression.cs: Convert changes.
12052 * literal.cs: Error method changed.
12054 * statement.cs: Error method changed.
12056 2005-10-03 Raja R Harinath <rharinath@novell.com>
12058 * support.cs (SeekableStreamReader.Position): Don't error out when
12059 the requested position is just beyond the end of the current
12062 2005-09-28 Raja R Harinath <rharinath@novell.com>
12064 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12065 try to keep in sync with the byte count of the underlying Stream.
12066 However, this limits us to a window size of 2048 characters: i.e.,
12067 the maximum lookahead of our lexer/parser can be 2048 characters.
12069 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12072 * driver.cs: Fix compilation files with full root path.
12074 2005-09-25 Miguel de Icaza <miguel@novell.com>
12076 * report.cs (SymbolRelatedToPreviousError): Format the output so
12077 it does not use an open parenthesis that is never closed.
12079 * driver.cs: Follow coding guidelines
12081 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12084 * const.cs (Const.ResolveValue): Check for assigning non-null
12085 value to reference type.
12087 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12089 * anonymous.cs: Implemented ExprClassName.
12091 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12094 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12097 * class.cs (StaticClass.DefineContainerMembers): Report protected
12100 * codegen.cs: if(ed) PRODUCTION.
12102 * convert.cs (Error_CannotImplicitConversion): Better error
12105 * cs-parser.jay: More error checks.
12107 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12109 * driver.cs (CSCParseOption): Enabled wrong option check.
12111 * ecore.cs (Expression.ExprClassName): Turned to property.
12112 (MemberExpr.CheckIntermediateModification): For checking boxed
12113 value types modification.
12115 * statement.cs (Fixed.Resolve): Expression type must be
12116 convertible to fixed type.
12117 (CollectionForeach.GetEnumeratorFilter,TryType):
12118 Small refactoring for easier error checking.
12120 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12122 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12125 * class.cs (GeneratedBaseInitializer): New class for customization
12126 compiler generated initializers.
12127 (MemberBase.DoDefine): Check Obsolete attribute here.
12128 (FieldMember.DoDefine): Ditto.
12130 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12133 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12134 (MemberCore.GetObsoleteAttribute): Removed argument.
12135 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12136 (MemberCore.CheckObsoleteType): New helper.
12140 * statement.cs: Updates after MemberCore changes.
12142 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12143 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12145 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12146 obsolete attribute for compiler construct.
12147 (As.DoResolve): Cache result.
12149 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12151 2005-09-26 Raja R Harinath <rharinath@novell.com>
12154 * expression.cs (This.VerifyFixed): In a value type T, the type of
12155 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12156 value type R, 'this' is treated as a value parameter.
12158 2005-09-22 Miguel de Icaza <miguel@novell.com>
12160 * statement.cs (Lock): Use the TemporaryVariable class instead of
12161 manually using local variables as those do not work when variables
12164 * ecore.cs: Moved the TemporaryVariable class from being a nested
12165 class inside Foreach to be a public class that can be employed in
12168 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12170 * cs-parser.jay: interface_accessors replaced by
12171 accessor_declarations.
12173 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12176 * statement.cs (GotoCase.Resolve): Convert null constant to
12178 (SwitchLabel.ResolveAndReduce): Ditto.
12179 (SwitchLabel.NullStringCase): Custom null stamp.
12180 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12182 typemanager.cs (CSharpSignature): Don't skip first argument
12185 2005-09-18 Miguel de Icaza <miguel@novell.com>
12187 * driver.cs: Set InEmacs based on the environment variable EMACS.
12189 * location.cs (InEmacs): in this mode, do not report column
12190 location as it confuses Emacs.
12192 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12194 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12195 expression.cs, iterators.cs, literal.cs: Store constants and
12198 * class.cs (MemberBase.ShortName): Pass location.
12200 * cs-parser.jay: Some location fixes.
12202 * ecore.cs (Expression.Location): Made virtual.
12204 2005-09-05 Miguel de Icaza <miguel@novell.com>
12206 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12207 if the underlying types are the same, otherwise we need to produce
12208 code that will do the proper cast.
12210 This was exposed by Marek's constant rewrite which produced
12211 invalid code for the call site:
12213 enum X : long { a }
12214 void Method (X v) {}
12218 This fixes test-49.cs
12220 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12222 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12223 Type/Object should be allowed as well. Fixed bug #75968.
12225 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12227 * expression.cs : (Binary.DoResolve): when one is enum constant and
12228 another is constant 0, then return enum one *as enum type*.
12231 2005-09-02 Raja R Harinath <rharinath@novell.com>
12233 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12237 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12238 flow-branching for LocalVariableReferences in case we were invoked
12239 from a MemberAccess.
12240 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12242 (LocalVariableReference.DoResolveBase): ... this.
12243 (MemberAccess.Resolve): Do the check that was disabled during
12246 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12249 (PartialContainer.Create): check abstract/sealed/static strictly
12250 but abstract/sealed can exist only at one side. Fixed bug #75883.
12252 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12255 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12256 specified, don't default to UnmanagedType.I4.
12258 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12260 * expression.cs : conditional operator should check possibly
12261 incorrect assign expression. Fixed bug #75946.
12263 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12265 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12266 Reverting the change. gmcs is much complex than mcs on this matter.
12268 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12270 * cs-tokenizer.cs : To read another token ahead of the actual
12271 consumption, use new SavedToken and cache token instead of moving
12272 back the stream with SeekableStreamReader (it seemed problematic).
12274 driver.cs : Thus use StreamReader directly.
12275 * support.cs : Thus removed SeekableStreamReader.
12277 2005-08-30 Raja R Harinath <rharinath@novell.com>
12280 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12281 (ScopeInfo.EmitScopeType): Use it to construct field names from
12282 names of captured locals.
12285 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12286 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12287 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12288 (ExplicitConversion): Remove enum cases already handled by
12289 implicit conversion. Move implicit conversion check to the beginning.
12290 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12291 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12292 Don't treat System.Enum as a struct.
12294 2005-08-30 Jb Evain <jbevain@gmail.com>
12296 * attribute.cs: handles as expression in parameters.
12298 2005-08-30 Raja R Harinath <rharinath@novell.com>
12301 * class.cs (TypeContainer.VerifyClsName): Don't use a
12302 PartialContainer when verifying CLS compliance.
12303 (AbstractPropertyEventMethod): Set Parent here, ...
12304 (PropertyMethod): ... not here.
12306 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12308 * attribute.cs : escaped attribute name should not be allowed to be
12309 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12311 2005-08-29 Raja R Harinath <rharinath@novell.com>
12314 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12315 when converting a long constant to unsigned long.
12316 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12317 detect where IsApplicable and VerifyArgumentsCompat disagree.
12319 2005-08-29 Raja R Harinath <rharinath@novell.com>
12320 and Carlos Alberto Cortez <carlos@unixmexico.org>
12323 * class.cs (TypeContainer.CanElideInitializer): New helper.
12324 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12325 can safely emitting the initializer of a field.
12327 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12329 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12330 allowed inside a switch (without loop). Fixed bug #75433.
12332 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12334 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12335 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12337 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12339 * driver.cs : kinda reverting the default encoding changes (not exact
12340 revert since I noticed that "codepage:reset" might not work fine).
12342 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12344 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12345 Location. Now getter and setter store location correctly.
12346 (errors/cs0111-12.cs now reports the expected location.)
12348 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12350 * driver.cs : Use default encoding on the environment.
12351 Removed (now that) extra parameter for SeekableStreamReader.
12352 * support.cs : (SeekableStreamReader) third .ctor() argument for
12353 StreamReader is not required (always true). preamble size could
12354 be acquired in simpler and safe way.
12356 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12358 * cs-parser.jay: report CS0642 at warning level 3
12359 and report CS0642 for an if else statement also
12360 fixes bug #74745. Patch by John Luke (and a bit
12362 Removed extra CS0642 warning check for "while",
12364 * statement.cs: In Block.Resolve(), CS0642 check
12365 is reimplemented to check a sequence of an empty
12366 statement and a block.
12368 Both fix bug #66777.
12370 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12372 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12373 detection until I fix it.
12375 * cs-tokenizer.cs: Changed error message.
12377 * cs-parser.jay: Fixed 2 error locations.
12379 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12380 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12383 * enum.cs (GetSignatureForError): Fixed.
12385 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12389 * typemanager.cs (RegisterProperty): Removed.
12391 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12393 2005-08-24 Raja R Harinath <rharinath@novell.com>
12396 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12397 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12399 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12401 * expression.cs : tiny fix is required for not warning positive ulong.
12404 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12406 * expression.cs : add CS0652 check for constant and integral
12407 expression. Fixed bug #53974.
12409 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12411 * expression.cs : in DoNumericPromotions(), check if there is implicit
12412 conversion overload for string (to check CS0034). Fixed bug #52492.
12414 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12416 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12418 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12420 * ecore.cs : report location when it is *not* Null.
12422 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12428 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12429 correctly. Fixed bug #75721.
12431 2005-08-23 Raja R Harinath <rharinath@novell.com>
12433 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12434 loop that performs 'min (pos, char_count)'.
12437 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12438 converted value in Operator.OnesComplement.
12440 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12442 * anonymous.cs: If the anon method is pulled into a helper class,
12443 it needs to be `internal' not `private'. Fixes runtime behavior on
12446 2005-08-20 Martin Baulig <martin@ximian.com>
12448 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12449 scope if we don't already have it.
12451 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12452 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12455 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12458 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12459 is a partial class.
12461 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12463 The big constants rewrite
12464 Fix #75746, #75685 and more
12465 As a side effect saved 1MB for MWF ;-)
12467 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12468 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12469 enum based for corlib compilation.
12471 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12474 * class.cs (FixedField.Define): Use ResolveAsConstant.
12476 * const.cs (IConstant): Interface constants and enums.
12477 (Const.ResolveValue): New method for constant resolvning.
12478 (ExternalConstant): Constants from imported assemblies.
12480 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12481 conversion; like enums.
12482 (Constant.ToType): Converts this constant to different type.
12483 (Constant.Increment): Adds 1.
12485 * convert.cs (ImplicitConversionRequired): Simplified.
12487 * cs-parser.jay: Create EnumMember directly.
12489 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12491 * doc.cs (GenerateEnumDocComment): Removed.
12493 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12494 (ConvertIntLiteral): Removed.
12495 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12497 * enum.cs (EnumMember): Implement IConstant.
12498 (Enum.IsValidEnumConstant): Removed.
12499 (Enum.GetNextDefaultValue): Removed.
12500 (Enum.FindMembers): Updated.
12501 (Enum.GenerateDocComment): Iterate enum members.
12503 * expression.cs (Cast.TryReduce): Handle enums correctly.
12504 (New.Constantify): Made public.
12505 (MemberAccess.DoResolve): Removed contant specific if(s).
12507 * literal.cs (NullLiteral): Implement new abstract methods.
12509 * statement.cs (GotoCase.Resolve): Use new constant methods.
12510 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12512 * typemanager.cs (LookupEnum): Removed.
12513 (IsEnumType): Fixed to work with corlib.
12514 (RegisterConstant): Removed.
12515 (LookupConstant): Removed.
12516 (GetConstant): Changed to work with IConstant.
12518 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12520 * location.cs : Fixed overflown (>255) column number.
12522 2005-08-03 Raja R Harinath <rharinath@novell.com>
12524 First cut of the qualified-alias-member feature.
12525 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12527 * cs-parser.jay (DOUBLE_COLON): New token.
12528 (namespace_or_type_name): Add rule for recognizing
12529 qualified-alias-members.
12530 (primary_expression): Likewise.
12531 (element_access): Allow QualifiedAliasMember as a possible
12532 type-bearing expression.
12533 (local_variable_type, local_variable_pointer_type): Likewise.
12534 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12535 aliases in the current and enclosing namespace declarations.
12536 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12537 * decl.cs (MemberName.is_double_colon): New.
12538 (MemberName.MemberName): Add new constructor for alias-member.
12539 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12540 * expression.cs (QualifiedAliasMember): New expression type.
12542 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12544 * location.cs : it borked when no argument was specified.
12546 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12548 * location.cs : tiny ToString() format fix.
12550 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12552 * statement.cs : oops, it was missing.
12554 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12556 A set of fixes for precise line/column location.
12559 "token" field now holds a file/line "delta", a line number offset
12560 from the segment, and a column number. See also:
12561 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12562 December/009508.html
12563 Removed static IsNull. Use instance IsNull property instead.
12564 * cs-tokenizer.cs :
12565 For some tokens it stores Location. For Identifier it stores
12566 LocatedToken which is a pair of string name and location.
12567 Column numbers are adjusted only at getChar().
12569 Use Location.ToString() for reporting (it now contains column).
12571 Largely modified to use LocatedToken instead of
12572 string (IDENTIFIER), and to acquire Location from some tokens.
12573 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12574 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12576 Now MemberName holds Location. DeclSpace.ctor() receives Location
12577 as a parameter. Removed extra parameters to all derived classes.
12578 Replaced Location.IsNull() with instance property.
12579 * assign.cs, expression.cs :
12580 Added .ctor() overload that omits Location.
12582 Added "nameEscaped" flag that indicates the identifier was escaped
12583 in the source file. This fixes bug #57047.
12585 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12587 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12588 New method, looking for lo-case imported cls type.
12590 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12593 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12595 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12597 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12598 all_imported_types.
12599 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12601 Optimized to save 3.5 MB for SWF compilation.
12603 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12605 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12606 (PartialContainer.Create): Moved logic AddToContainer.
12607 (PartialContainer.MarkForDuplicationCheck): Shares name.
12609 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12612 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12614 (Namespace.GetSignatureForError): New method.
12616 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12617 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12619 2005-08-01 Raja R Harinath <rharinath@novell.com>
12622 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12623 member lookup rather than qualifier_type, since qualifier_type can
12626 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12628 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12631 2005-07-31 Miguel de Icaza <miguel@novell.com>
12633 * statement.cs: Copy the local exception into the exception
12634 captured local. Fixes 75674
12636 2005-07-31 Raja R Harinath <harinath@gmail.com>
12639 * expression.cs (Invocation.OverloadResolve): Don't report error
12640 CS1501 if error CS1502 has been reported.
12641 (New.DoResolve): Delegate CS1501 reporting to
12642 Invocation.OverloadResolve.
12645 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12646 invariant-meaning-in-block property in an enclosing block if
12649 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12651 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12652 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12653 (Switch.CheckSwitch): Just save 50kb for SWF.
12655 2005-07-27 Martin Baulig <martin@ximian.com>
12657 * anonymous.cs (CaptureContext.AddField): Added
12658 `AnonymousContainer am' argument; compute its toplevel scope if
12659 it's not already computed. Fixes #75649.
12661 2005-07-26 Raja R Harinath <rharinath@novell.com>
12664 * class.cs (Constructor.Emit): Reset block to null if the block
12667 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12669 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12671 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12673 * class.cs (MethodData.Define): Check whether accessor implementing
12674 interface is public.
12676 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12678 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12681 * namespace.cs (LookupType): Moved same type check to...
12683 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12684 with the same name.
12686 2005-07-21 Raja R Harinath <rharinath@novell.com>
12688 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12689 already found a typebuilder.
12690 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12691 MemberNames, not strings.
12693 * const.cs (Error_ExpressionMustBeConst):
12694 Rename from Error_EpressionMustBeConst.
12695 * const.cs, class.cs, statement.cd: Update.
12697 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12701 * const.cs (Const.LookupConstantValue): Report missing contant expression
12703 (Error_EpressionMustBeConstant): Only one error method.
12705 * class.cs, statement.c: Updated.
12707 2005-07-20 Raja R Harinath <rharinath@novell.com>
12709 * statement.cs (Block.Flags): Add back HasVarargs.
12710 (Block.flags): Make protected.
12711 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12713 * typemanager.cs (types, typecontainers, user_types): Remove.
12714 (UserTypes, TypeContainers): Likewise.
12715 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12716 (CleanUp, Reset): Update.
12717 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12718 (GetNestedType): Use Type.GetNestedType.
12719 (CoreLookupType): Take two arguments, the namespace and the
12720 basename of the type. Update to use the Namespace.Lookup
12722 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12723 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12724 string concatenation and substring matches.
12725 * class.cs, enum.cs, delegate.cs: Update to changes.
12727 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12729 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12730 Expression and made virtual.
12732 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12733 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12735 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12737 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12740 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12743 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12746 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12747 AssemblyCultureAttribute is not used on executable.
12750 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12752 2005-07-16 Raja R Harinath <rharinath@novell.com>
12755 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12756 New. Reports CS0252/CS0253.
12757 Mostly taken from preliminary patch by Duncak Mak.
12758 (Binary.DoResolveOperator): Store results of operator lookup.
12759 Use them to detect if we need to warn about unintended reference
12762 2005-07-15 Raja R Harinath <rharinath@novell.com>
12765 * namespace.cs (Namespace.Lookup): Add back location parameter.
12766 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12767 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12769 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12770 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12771 (Namespace.LookupType): ... this.
12772 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12774 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12775 purported to handle pointers.
12776 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12779 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12781 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12784 2005-07-15 Raja R Harinath <rharinath@novell.com>
12786 * namespace.cs (Namespace.Lookup): Drop location parameter.
12787 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12788 (NamespaceEntry.Lookup): ... this.
12789 (NamespaceEntry.Error_AmbiguousTypeReference):
12790 Move here from DeclSpace.
12791 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12793 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12794 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12795 Move to NamespaceEntry.
12796 * delegate.cs, expression.cs: Update to changes.
12798 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12800 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12801 CheckAttributeType and refactored.
12802 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12803 ResolveAsTypeTerminal error handling.
12804 (ResolveAsTypeTerminal): Introduced because of global attributes extra
12806 (GetSignatureForError): Print errors in same way.
12809 * codegen.cs: Reflect attribute GetSignatureForError change.
12812 * expression.cs: Add silent parameter to ResolveAsTypeStep.
12814 * namespace.cs (UsingEntry): Refactored to make fields private.
12817 statement.cs: Error_UnexpectedKind has extra parameter.
12819 2005-07-14 Raja R Harinath <rharinath@novell.com>
12821 * ecore.cs (IAlias): Remove.
12822 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
12823 that implement the interface.
12824 * namespace.cs (Namespace): Likewise.
12825 (Namespace.declspaces): Renamed from 'defined_names'.
12826 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
12827 DeclSpace instead of an IAlias.
12828 * tree.cs (Tree.AddDecl): Update.
12830 2005-07-12 Raja R Harinath <rharinath@novell.com>
12832 * statement.cs (Block.Flags); Remove HasVarargs.
12833 (Block.HasVarargs): Move to ToplevelBlock.
12834 (Block.ThisVariable, Block.AddThisVariable): Likewise.
12835 (Block.Variables): Make protected. Initialize variable hashtable
12837 (Block.AddVariable): Update.
12838 (Block.Resolve): Update to changes.
12839 (ToplevelBlock.HasVarargs): New boolean.
12840 (ToplevelBlock.ThisVariable): Move here from Block.
12841 (ToplevelBlock.AddThisVariable): Likewise.
12842 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
12843 * expression.cs (This.ResolveBase): Update to changes.
12844 (ArglistAccess.DoResolve): Likewise.
12846 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12849 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
12851 * class.cs (TypeContainer.VerifyMembers): Distinguish between
12852 not used and not used & assigned.
12853 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
12855 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12858 * expression.cs (Is.DoResolve): null is never provided type.
12860 2005-07-08 Marek Safar <marek.safar@seznam.cz>
12863 * cs-parser.jay: Less strict event error rule to catch more errors.
12865 2005-07-08 Martin Baulig <martin@ximian.com>
12867 Fix test-iter-10.cs - distinguish whether we `yield' in a property
12868 gettter (allowed) or setter (not allowed).
12870 * class.cs (Accessor): Implement IIteratorContainer.
12871 (Accessor.Yields): New public field.
12872 (PropertyBase.PropertyMethod.Define): Handle iterators on a
12873 per-accessor basis.
12876 (get_accessor_declaration, set_accessor_declaration): Set the
12877 `yields' flag on the accessor, not the property.
12878 (property_declaration): Do the iterators check on a per-accessor
12879 basis and not for the whole property.
12881 2005-07-08 Martin Baulig <martin@ximian.com>
12883 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
12884 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
12886 2005-07-07 Marek Safar <marek.safar@seznam.cz>
12889 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
12890 (ExtractSecurityPermissionSet): Cope with self referencing security
12891 attributes properly.
12893 * driver.cs (SetOutputFile): Made public property OutputFile.
12895 2005-07-07 Raja R Harinath <rharinath@novell.com>
12898 * class.cs (TypeContainer.first_nonstatic_field): Rename from
12899 has_nonstatic_fields. Make into a FieldBase pointer.
12900 (TypeContainer.AddField): Add CS0282 check.
12901 (TypeContainer.EmitType): Update.
12903 2005-07-06 Miguel de Icaza <miguel@novell.com>
12905 * cs-tokenizer.cs (consume_identifier): Do not create strings to
12906 compare if they start with __.
12908 2005-07-06 Raja R Harinath <rharinath@novell.com>
12910 * statement.cs (Switch.SwitchGoverningType): Only look at
12911 UserCasts that don't need implicit standard conversions to one of
12912 the allowed switch types (Fixes test-322.cs).
12913 (LocalInfo.Resolve): Re-enable sanity-test.
12915 2005-07-06 Marek Safar <marek.safar@seznam.cz>
12917 * cs-tokenizer.cs (consume_identifier): Detect double undescores
12919 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
12921 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
12923 2005-07-06 Raja R Harinath <rharinath@novell.com>
12926 * ecore.cs (SimpleName.GetSignatureForError): Add.
12927 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
12928 (MemberAccess.GetSignatureForError): Add.
12930 2005-07-05 Marek Safar <marek.safar@seznam.cz>
12932 The big error and warning messages review.
12962 * typemanager.cs: Updated.
12964 * class.cs: (MethodCore.SetYields): Moved here to share.
12965 (PropertyMethod.Define): Moved iterator setup here.
12967 * iterators.cs: Add orig_method to have full access to parent
12970 2005-07-05 Raja R Harinath <rharinath@novell.com>
12972 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
12973 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
12974 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
12975 variable of struct type.
12976 * expression.cs (Unary.ResolveOperator): Update to change.
12977 (Indirection.VerifyFixed): Likewise.
12978 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
12979 (ParameterReference.VerifyFixed): Value parameters are fixed.
12980 (This.VerifyFixed): Treat 'this' as a value parameter.
12981 * statement.cs (LocalInfo.IsFixed): Remove.
12983 2005-07-01 Martin Baulig <martin@ximian.com>
12985 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
12986 `ec.EmitThis ()' to get the correct scope.
12988 2005-07-01 Martin Baulig <martin@ximian.com>
12990 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
12991 instance is a ParameterReference; fixes #75299.
12993 2005-07-01 Martin Baulig <martin@ximian.com>
12995 Reverted Marek's latest patch (r46725):
12996 - it contains structural changes which are neither mentioned in
12997 the ChangeLog nor explained anywhere; for example the additional
12998 argument of EmitContext's and Iterator's .ctor's and the
12999 TypeContainer.DefineMembers() change.
13000 - structural changes like this should go in in seperate patches
13001 and not be hidden in a huge patch which just seems to affect
13002 warnings and errors.
13003 a big and hard to understand patch.
13004 - it breaks iterators and causes regressions, for instance in
13007 2005-06-30 Raja R Harinath <rharinath@novell.com>
13010 * expression.cs (Indexers.map): Remove.
13011 (Indexers.Append): Filter out inaccessible setters and getters.
13012 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13015 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13016 Refactored from ...
13017 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13018 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13019 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13020 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13022 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13025 * class.cs (FieldBase.GetInitializerExpression): One more field
13028 2005-06-28 Miguel de Icaza <miguel@novell.com>
13030 * pending.cs: Do not define a proxy if the base method is virtual,
13031 it will be picked up by the runtime (bug 75270).
13033 2005-06-08 Martin Baulig <martin@ximian.com>
13035 The big Iterators rewrite :-)
13037 * iterators.cs: Rewrite this to use the anonymous methods framework.
13039 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13040 before the TypeContainers; see 2test-21.cs.
13043 (TypeContainer.DefineType): Don't create a new EmitContext if we
13044 already have one (this only happens if we're an Iterator).
13045 (TypeContainer.Define): Also call Define() on all our iterators.
13046 (Method.CreateEmitContext): Added support for iterators.
13049 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13050 (AnonymousContainer.CreateMethodHost): Moved here from
13051 AnonymousMethod and made abstract.
13052 (AnonymousContainer.CreateScopeType): New abstract method.
13053 (AnonymousContainer.IsIterator): New public property.
13054 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13055 get the ScopeTypeBuilder rather than manually defining it here.
13056 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13059 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13060 before RootContext.DefineTypes().
13062 * codegen.cs (EmitContext.RemapToProxy): Removed.
13063 (EmitContext.CurrentAnonymousMethod): Changed type from
13064 AnonymousMethod -> AnonymousContainer.
13065 (EmitContext.ResolveTopBlock): Protect from being called twice.
13066 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13067 (EmitContext.EmitThis): Removed the iterators hacks; use the
13068 anonymous methods framework for that.
13071 (ToplevelBlock.Container): Make this a property, not a field.
13072 (ToplevelBlock.ReParent): New public method; move the
13073 ToplevelBlock into a new container.
13074 (Foreach.TemporaryVariable): Simplify.
13076 2005-06-05 Martin Baulig <martin@ximian.com>
13078 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13079 (Block.AddTemporaryVariable): New public method; creates a new
13080 `LocalInfo' for a temporary variable.
13081 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13083 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13084 non-iterator variables.
13086 2005-06-05 Martin Baulig <martin@ximian.com>
13088 * statement.cs (Foreach.TemporaryVariable): Create the
13089 LocalBuilder in the Emit phase and not in Resolve since in some
13090 situations, we don't have an ILGenerator during Resolve; see
13091 2test-19.cs for an example.
13093 2005-06-04 Martin Baulig <martin@ximian.com>
13095 **** Merged r45395 from GCS ****
13097 The big Foreach rewrite - Part II.
13099 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13100 with `PropertyInfo ienumerator_getcurrent'.
13102 * codegen.cs (VariableStorage): Removed.
13105 (Foreach): Derive from Statement, not ExceptionStatement.
13106 (Foreach.CollectionForeach): New nested class. Moved all the code
13107 dealing with collection foreach here.
13108 (Foreach.ForeachHelperMethods): Removed.
13109 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13111 2005-05-23 Martin Baulig <martin@ximian.com>
13113 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13114 don't need to. Fix #75014.
13116 2005-05-20 Martin Baulig <martin@ximian.com>
13118 Merged r44808 from GMCS.
13120 * class.cs (TypeContainer.CircularDepException): Removed.
13121 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13122 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13123 (CS0146) and interface (CS0529) dependencies here.
13125 2005-06-21 Raja R Harinath <rharinath@novell.com>
13127 * expression.cs (Invocation.EmitCall): Fix initialization
13128 'this_call' to reflect current behaviour. Fix indentation.
13130 * convert.cs (FindMostEncompassedType): Add two trivial special
13131 cases (number_of_types == 0 || number_of_types == 1).
13132 (FindMostEncompasingType): Likewise.
13134 2005-06-17 Raja R Harinath <rharinath@novell.com>
13136 Some cleanups preparing for the fix of #75283.
13137 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13139 (EventExpr.InstanceResolve): Likewise.
13140 (EventExpr.DoResolve): Remove redundant checks.
13142 2005-06-10 Duncan Mak <duncan@novell.com>
13144 * cs-tokenizer.cs (process_directives): New flag for controlling
13145 the processing of preprocessor directives.
13146 (x_token): After seeing a '#', return Token.NONE instead of going
13147 to handle_preprocessing_directive() when not processing
13148 directives. This avoids unnecessary processing during the token peek in
13153 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13154 the existing error reporting methods instead of Report.Error.
13156 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13157 after Raja's rewrite.
13159 2005-06-08 Miguel de Icaza <miguel@novell.com>
13161 * class.cs: Small fix.
13163 2005-06-08 Raja R Harinath <rharinath@novell.com>
13166 * class.cs (GetPartialBases): Fix return value check of
13167 part.GetClassBases.
13169 2005-06-07 Raja R Harinath <rharinath@novell.com>
13171 Ensure that partial classes are registered in their enclosing
13172 namespace. Initial part of fix of #75160.
13173 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13174 Register declspace with namespace here, not in
13175 DeclSpace.RecordDecl.
13176 * cs-parser.jay: Pass namespace to RecordDecl.
13177 * class.cs (PartialContainer.Create): Likewise.
13178 (ClassPart.DefineType): New sanity-check. Throws an exception if
13180 * decl.cs (Declspace.RecordDecl): Remove.
13181 * namespace.cs (NamespaceEntry.DefineName): Remove.
13183 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13185 * rootcontext.cs: Reset TargetExt as well.
13187 2005-06-03 Raja R Harinath <rharinath@novell.com>
13189 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13190 -langversion:ISO-1.
13192 2005-06-02 Raja R Harinath <rharinath@novell.com>
13194 Fix #75080, cs0119.cs.
13195 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13197 (Expression.Resolve): ... this. Use it. Remove bogus code
13198 allowing ExprClass.Type and ExprClass.Namespace for
13199 ResolveFlags.VariableOrValue.
13200 (Expression.Resolve) [1-argument variant]: Change default resolve
13201 flags based on language version.
13202 (Expression.Error_UnexpectedKind): Use a simple string array
13203 rather than an ArrayList.
13204 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13205 not ExprClass.Type.
13206 (TypeOfVoid.DoResolve): Likewise.
13207 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13208 flags argument -- it always has the same value.
13210 2005-05-31 Raja R Harinath <rharinath@novell.com>
13213 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13214 Use it in the error message.
13215 * assign.cs, expression.cs, statement.cs: Update.
13217 2005-05-30 Raja R Harinath <rharinath@novell.com>
13220 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13221 the "almostMatchedMember" case too.
13222 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13223 that failed the accessibility checks to 'almost_match'.
13225 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13227 * attribute.cs: Use internal MethodBuilder methods to set
13228 ExactSpelling and SetLastError on PInvoke methods, instead
13229 of passing them via charset. Fixes #75060.
13231 2005-05-27 Raja R Harinath <rharinath@novell.com>
13233 * parameter.cs (Parameter): Remove TODO comment.
13234 (Parameter.DefineParameter): Remove Location parameter.
13235 (Parameters.LabelParameters): Likewise.
13236 * class.cs (Constructor.Emit): Update to change.
13237 (MethodData.Emit): Likewise.
13238 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13239 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13241 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13244 Removed Parameters.Location and added Parameter.Location instead.
13245 Removed Location parameter from Emit() and GetSignature().
13252 Modified all related calls.
13254 2005-05-26 Raja R Harinath <rharinath@novell.com>
13256 Improve user-defined conversion handling.
13257 * convert.cs (GetConversionOperators): Rewrite. Return only the
13258 applicable operators.
13259 (AddConversionOperators): New. Helper for GetConversionOperators.
13260 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13261 there is only one most encompassed/encompassing type.
13262 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13263 "applicable operator" handling.
13264 (UserConversion): Move cache here from GetConversionOperators.
13265 Directly cache the chosen operator, rather than the whole
13267 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13268 case. Allow conversion of decimal to sbyte and byte too.
13269 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13270 New static methods. Used to avoid allocating EmptyExpressions in
13273 2005-05-24 Duncan Mak <duncan@novell.com>
13275 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13276 another class, used in Convert.ExplicitNumericConversion.
13277 (CastToDecimal): New class, similar to above, but casts to
13278 System.Decimal, used in Convert.ImplicitNumericConversion and also
13279 in explicit convesion from double/float to decimal.
13281 * convert.cs (ImplicitNumericConversion): Handle implicit
13282 conversions to System.Decimal.
13283 (ExplicitNumericConversion): handle explicit conversions to
13288 2005-05-20 Miguel de Icaza <miguel@novell.com>
13290 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13291 know the type at this stage, just break through. Fixes #75008
13293 2005-05-19 Martin Baulig <martin@ximian.com>
13296 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13297 to disable error reporting.
13299 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13300 here since we don't want to report an error; see the new test-336.cs.
13302 2005-05-19 Raja R Harinath <rharinath@novell.com>
13304 * statement.cs (ToplevelBlock.GetParameterReference)
13305 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13306 Move here from class Block.
13307 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13308 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13310 2005-05-18 Martin Baulig <martin@ximian.com>
13315 (FlowBranching.Reachability): Add non-static public And() and Or()
13317 (FlowBranchingSwitch): New class; do the `break_origins' thing
13318 like in FlowBranchingLoop.
13319 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13320 reachability, not just locals and parameters.
13321 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13322 switch; MergeBreakOrigins() now takes care of that.
13324 2005-05-18 Martin Baulig <martin@ximian.com>
13326 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13327 a loop and may leave it, reset the barrier; fixes #74974.
13329 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13331 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13334 * cs-parser.jay: Catch more lexical errors.
13336 * report.cs: Add one more Error method.
13339 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13341 2005-05-17 Martin Baulig <martin@ximian.com>
13343 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13346 2005-05-16 Raja R Harinath <rharinath@novell.com>
13348 Fix test-382.cs. Emit values of decimal constants.
13349 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13351 (TypeContainer.AddField): ... this.
13352 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13353 with initializers to include 'Const's.
13354 (ClassPart.RegisterFieldForInitialization): Forward to
13356 * const.cs (Const.Const): Pass initializer to base class.
13357 (Const.Define): In case of decimal constants, register them for
13358 initialization in a static constructor.
13360 2005-05-14 Martin Baulig <martin@ximian.com>
13362 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13363 do not call ResolveUnreachable() on unreachable statements in
13364 here, see the comment in the source code.
13366 2005-05-13 Raja R Harinath <rharinath@novell.com>
13369 * expression.cs (BinaryResolveOperator): If one of the operands of
13370 an equality comparison is 'null' and the other is a pointer type,
13371 convert the null to a NullPointer.
13372 * convert.cs (ImplicitReferenceConversion): If the expression is a
13373 NullLiteral and the target type is a pointer type, return a
13374 NullPointer instead.
13375 (ImplicitConversionStandard): Likewise.
13377 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13379 * cs-parser.jay: Set readonly context based on special constructs.
13381 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13382 readonly variable error handling.
13384 * rootcontext.cs (EmitCode): Don't verify members when error
13387 * statement.cs (LocalInfo): Add reaodnly context information.
13388 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13390 2005-05-13 Raja R Harinath <rharinath@novell.com>
13392 * statement.cs (Block.Resolve): Revert change below. Modify fix
13393 for #74041 to initialize 'resolved' to false only for explicit
13394 blocks. Fixes #74873.
13396 2005-05-12 Raja R Harinath <harinath@gmail.com>
13399 * typemanager.cs (unmanaged_enclosing_types): New.
13400 (IsUnmanagedType): Avoid infloops by using
13401 'unmanaged_enclosing_types' to talk with recursive invocations.
13403 2005-05-13 Martin Baulig <martin@ximian.com>
13405 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13406 instance variable, not a local. Fix #74873.
13407 (Block.ResolveUnreachable): Set it to true here.
13409 2005-05-11 Duncan Mak <duncan@novell.com>
13411 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13412 continuing to process for 'arg'.
13413 (handle_preprocessing_directive): Check the argument of the #endif
13414 directive and report error CS1025 if there are any trailing
13417 According to the C# spec, having even whitespace after the #endif
13418 directive is illegal; however, because we call arg.TrimEnd ()
13419 beforehand, we have the same behavior as csc, allowing whitespace
13420 after the directive.
13424 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13428 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13429 (Constructor.GetObsoleteAttribute): Implemented correctly.
13431 2005-05-10 Martin Baulig <martin@ximian.com>
13433 * support.cs (ReflectionParameters.ParameterModifier): Use
13434 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13435 and `ParameterAttributes.In'. Fixes #74884.
13437 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13439 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13441 * expression.cs (Argument.GetParameterModifier): Turned to property.
13442 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13444 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13447 2005-05-09 Raja R Harinath <rharinath@novell.com>
13450 * decl.cs (MemberCache.AddMethods): Register override methods,
13451 rather than non-override methods.
13452 * typemanager.cs (RegisterOverride): New.
13453 (IsOverride): Update.
13455 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13459 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13460 recursive declaration.
13462 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13464 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13466 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13468 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13470 2005-05-05 Raja R Harinath <rharinath@novell.com>
13473 * decl.cs (DeclSpace.FamilyAccessible):
13474 Use TypeManager.IsNestedFamilyAccessible.
13476 Fix reopened #64812.
13477 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13480 2005-05-04 Raja R Harinath <rharinath@novell.com>
13481 Abin Thomas <projectmonokochi@rediffmail.com>
13482 Anoob V E <projectmonokochi@rediffmail.com>
13483 Harilal P R <projectmonokochi@rediffmail.com>
13486 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13487 allow access to all static members.
13489 2005-05-04 Martin Baulig <martin@ximian.com>
13491 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13493 2005-05-04 Martin Baulig <martin@ximian.com>
13497 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13498 section at the end; make things work if `default' is not the last
13501 2005-05-04 Martin Baulig <martin@ximian.com>
13505 * statement.cs (Switch): Replaced the `got_default' field with a
13506 `default_section' one.
13507 (Switch.CheckSwitch): Set `default_section' here.
13508 (Switch.Resolve): If we're a constant switch and the constant is
13509 not found, use the default section.
13511 2005-05-03 Martin Baulig <martin@ximian.com>
13513 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13515 * statement.cs (Foreach.ArrayForeach): New nested class.
13516 (Foreach.TemporaryVariable): New nested class.
13517 (Foreach.EmitArrayForeach): Removed; this is now in the new
13518 ArrayForeach class.
13520 2005-05-03 Raja R Harinath <rharinath@novell.com>
13522 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13524 (VerifyPendingMethods): Revert change below.
13526 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13527 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13528 that used to trigger warning -28. Remove warning -28.
13529 * expression.cs (Invocation.OverloadResolve): Use
13530 TypeManager.IsOverride to distinguish override methods.
13533 * pending.cs (VerifyPendingMethods): If a base type implements the
13534 requested interface, don't bother checking individual methods of
13535 the base type. As a side-effect, this prevents the creation of
13536 unnecessary proxies.
13538 2005-05-02 Martin Baulig <martin@ximian.com>
13542 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13543 Also `And' the locals if the old vector is null.
13544 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13545 null; in this case we basically reset all the variables.
13547 2005-05-02 Martin Baulig <martin@ximian.com>
13551 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13552 Added `FlowBranching branching' argument; always `and' the
13553 variables instead of `or'ing them unless we're an infinite loop.
13555 * statement.cs (While.Resolve): Create a new sibling unless we're
13558 2005-05-02 Martin Baulig <martin@ximian.com>
13562 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13563 arguments; use it instead of creating a new TopLevelBlock.
13564 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13565 our ConstructorInitializer.
13568 (TopLevelBlock.TopLevelBranching): New public property.
13569 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13570 and create our `TopLevelBranching'.
13572 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13573 anonymous method host, use `block.TopLevelBranching' rather than
13574 creating a new branching.
13576 2005-04-20 Miguel de Icaza <miguel@novell.com>
13578 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13579 a ScopeInfo, if any of the current children is a child of the new
13580 entry, move those children there.
13582 2005-04-30 Martin Baulig <martin@ximian.com>
13584 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13585 at the beginning of a SwitchSection. Fix #73335.
13587 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13590 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13592 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13593 (FieldExpr.DoResolve): Obsolete members are ignored for field
13596 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13598 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13599 of arrays detection.
13601 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13603 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13605 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13608 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13610 * cs-parser.jay: Use the prefered version of -unsafe in error
13613 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13615 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13618 2005-04-20 John Luke <john.luke@gmail.com>
13620 * driver.cs: fix typo in error message, --outout to --output
13622 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13624 * codegen.cs (InRefOutArgumentResolving): New field.
13626 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13627 fields outside contructor.
13629 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13631 2005-04-19 Miguel de Icaza <miguel@novell.com>
13633 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13634 parameter code was not completed ever, so it was not as up-to-date
13635 as local variables. Must finish it.
13637 The bug fix was to compare the Toplevel of the block, not the
13638 current block. Thanks for Ben for pointing this out.
13640 2005-04-19 Raja R Harinath <rharinath@novell.com>
13642 * decl.cs (AddMethods): Use the declaring type of the problem
13643 method to determine if we want to squash a warning.
13645 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13647 * attribute.cs: Removed debug output.
13649 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13651 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13654 2005-04-18 Raja R Harinath <rharinath@novell.com>
13657 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13658 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13659 all null comparisons against reference types.
13661 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13664 * class.cs (TypeContainer.CircularDepException) New nested
13666 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13667 (TypeContainer.DefineType): Removed error, reset InTransit before
13669 (Class.DefineType): Throw exception when is in Transit.
13670 Catch exception and report error.
13671 (Struct.DefineType): Throw exception when is in Transit.
13672 Catch exception and report error.
13673 (Interface.DefineType): Throw exception when is in Transit.
13674 Catch exception and report error.
13676 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13677 handle nested exception handlers.
13679 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13682 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13683 InFinally and InCatch storage.
13685 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13686 (Catch.Resolve): Set and Restore ec.InCatch.
13687 (Try.Resolve): Set and Restore ec.InFinally.
13688 (Try.HasCatch): True when try has catch.
13690 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13692 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13693 for the same event member, so exclude such cases from warning 419.
13696 2005-04-16 Miguel de Icaza <miguel@novell.com>
13698 * expression.cs (Binary.ResolveOperator): Apply patch from John
13699 Luke to fix bug 59864: operators &, | and ^ on enumerations
13700 require that the same enum type on both sides.
13702 * driver.cs: Add warnings to old flag usage, this is to assist
13703 people who produce Makefiles and hope that the Makefiles will be
13706 * class.cs (TypeContainer.EmitType): Moved the definition of the
13707 special $PRIVATE$ field from the resolve phase to the Emit phase.
13708 During resolve we do not know if we are a struct with
13709 HasExplicitLayout, we know this only after the attributes for the
13712 Set the FieldOffset to zero on the dummy field that we create for
13713 the class. Fixes 74590.
13715 2005-04-16 Raja R Harinath <rharinath@novell.com>
13718 * ecore.cs (PropertyExpr.resolved): New.
13719 (DoResolve): Use it to handle a case of double resolution here.
13720 Handle a case of identical-name-and-type-name.
13721 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13722 resolution by storing the results of expression resolution back
13723 into the "probes" array.
13725 2005-04-15 Raja R Harinath <rharinath@novell.com>
13727 Fix cs0208-7.cs and cs0208-8.cs.
13728 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13729 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13730 error reporting to point out the reason a struct is not unmanaged.
13732 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13734 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13735 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13737 2005-04-13 Raja R Harinath <rharinath@novell.com>
13740 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13741 IdenticalNameAndTypeName here.
13742 (EventExpr.InstanceResolve): Likewise.
13744 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13746 C# 2.0 DefaultCharSetAttribute implementation
13748 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13749 which allows us to set GlobalNamespace for every resolve.
13750 (Attribute.ResolveArguments): Cut from Resolve.
13751 (Attribute.GetCharSetValue): Returns CharSet named argument.
13752 (Attribute.DefinePInvokeMethod): Gets default charset from
13754 (GlobalAttribute.ResolveAsTypeStep): Override.
13755 (GlobalAttribute.ResolveArguments): Override.
13757 * class.cs (TypeAttr): Is protected.
13759 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13760 (ModuleClass.DefaultCharSetType): New memeber.
13761 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13763 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13764 charset from module.
13766 * delegate.cs (TypeAttr): Override.
13767 (Delegate.DefineType): Use this TypeAttr.
13769 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13770 at very early stage (before types are defined) to resolve model
13771 module attributes. It will probably not work with corlib but it
13774 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13775 charset from module.
13777 * typemanager.cs (default_charset_type): New type.
13779 2005-04-13 Raja R Harinath <rharinath@novell.com>
13781 * decl.cs (MemberCache.AddMethods): Don't warn if
13782 System.Object.Finalize has buggy MethodAttributes.
13784 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13787 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13789 * doc.cs : detect ambiguous reference to overloaded members.
13790 Fixed bug #71603. MS 1.1 csc does not detect it.
13792 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13794 * doc.cs : delegates must not be referenced with parameters.
13797 2005-04-12 Miguel de Icaza <miguel@novell.com>
13799 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13801 2005-04-10 Miguel de Icaza <miguel@novell.com>
13803 * driver.cs (MainDriver): Stop processing if the CLS stage found
13806 (CompilerCallableEntryPoint.InvokeCompiler): Always
13807 reset after execution; Take a TextWriter argument for the
13810 * report.cs: Use the error stream instead of hardcoding stderr.
13812 2005-04-09 Miguel de Icaza <miguel@novell.com>
13814 * class.cs: Reduce code paths to test, too small of an
13815 optimization to make it worth the extra testing. Always perform
13818 2005-04-08 Raja R Harinath <rharinath@novell.com>
13821 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
13822 operators that had errors reported on them.
13824 2005-04-08 Marek Safar <marek.safar@seznam.cz>
13826 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
13828 (Attribute.Resolve): Add named argument type checking.
13830 * class.cs (FixedField.Define): Use IsPrimitiveType
13832 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
13834 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
13835 unsafe parameter types.
13837 * statement.cs (Using.ResolveExpression): Add better error description.
13839 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
13841 2005-04-08 Raja R Harinath <rharinath@novell.com>
13844 * attribute.cs (Attribute.GetAttributeUsage): Resolve
13845 AttributeUsageAttribute in the emitcontext of the attribute class,
13846 not in the emitcontext of the attributable entity it was attached to.
13847 * cs-parser.jay: Use 'current_class', not 'current_container',
13848 when creating a GlobalAttribute.
13850 2005-04-08 Alp Toker <alp@atoker.com>
13852 * pending.cs: The fix to #58413 failed to compile methods implementing
13853 interfaces with/without params modifiers and vice versa, even though
13854 params modifiers aren't part of the signature. Make the modifier check
13855 less strict as in csc.
13857 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
13858 Anoob V E <projectmonokochi@rediffmail.com>
13859 Harilal P R <projectmonokochi@rediffmail.com>
13862 * pending.cs (TypeAndMethods.mods): New. Store the parameter
13863 modifiers of pending methods.
13864 (PendingImplementation.PendingImplementation): Initialize it.
13865 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
13866 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
13867 with ParameterData. Add check for modifiers.
13868 * class.cs (MethodData.Define): Update to changes.
13870 2005-04-07 Raja R Harinath <rharinath@novell.com>
13872 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
13874 2005-04-07 Marek Safar <marek.safar@seznam.cz>
13876 * class.cs (PropertyMethod.Define): Check private accessor in abstract
13879 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
13882 * typemanager.cs: Registered RequiredAttributeAttribute.
13884 2005-04-06 Marek Safar <marek.safar@seznam.cz>
13886 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
13887 Warning CS0169 is back at level 3.
13888 (IMethodData.SetMemberIsUsed): New method.
13890 * decl.cs (IsUsed): New value; moved from FieldBase.Status
13891 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
13893 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
13895 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
13897 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
13900 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
13903 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
13904 to avoid the problems with nested types.
13906 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
13907 Anoob V.E <projectmonokochi@rediffmail.com>
13908 Harilal P.R <projectmonokochi@rediffmail.com>
13909 Raja R Harinath <rharinath@novell.com>
13912 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
13914 * typemanager (GetConstructor): Make public.
13916 2005-04-05 John Luke <john.luke@gmail.com>
13917 Raja R Harinath <rharinath@novell.com>
13920 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
13921 struct too. Return false quicker in a few cases.
13922 (VerifyUnManaged): Use it.
13924 2005-04-05 Raja R Harinath <rharinath@novell.com>
13927 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
13928 not 'unreachable_seen'.
13930 2005-04-04 Marek Safar <marek.safar@seznam.cz>
13932 * attribute.cs (Attribute.GetValue): Removed unused.
13934 * codegen.cs (CodeGen.TrimExt): Removed unused.
13936 * cs-parser.jay (output): Removed unused.
13938 * cs-tokenizer.cs (hex_digits): Removed unused.
13940 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
13942 * expression.cs (Indirection.LoadExprValue): Removed unused.
13943 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
13945 * iterators.cs (Iterator.param_types): Removed unused.
13947 * statement.cs (Goto.block): Removed unused.
13948 (ToplevelBlock.did): Removed unused.
13949 (Switch.ResolveConstantSwitch): Removed unused.
13951 2005-04-01 Ben Maurer <bmaurer@ximian.com>
13953 * rootcontext.cs: Allow mcs to bootstrap with the compilation
13956 2005-04-01 Raja R Harinath <rharinath@novell.com>
13958 Fix #74232 and cs0208-3.cs.
13959 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
13960 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
13961 unmanaged type. Don't use FieldBuilders when 't' is a
13962 TypeBuilder. Use ModFlags and MemberType fields.
13963 * class.cs (MemberBase.member_type): Rename from MemberType.
13964 (MemberBase.MemberType): New property. Determines member_type on
13966 (MemberBase.DoDefine): Don't initialize MemberType here.
13967 (FieldMember.Define): Likewise.
13969 2005-04-01 Marek Safar <marek.safar@seznam.cz>
13972 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
13973 Attributes are emitted there.
13975 2005-04-01 Raja R Harinath <rharinath@novell.com>
13977 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
13978 keyword in 'partial enum' too.
13979 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
13981 Report from Kamil Skalski <nazgul@omega.pl>.
13984 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
13985 have partial containers too.
13987 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
13988 in block' checks to Block.CheckInvariantMeaningInBlock.
13989 * statement.cs (Block.GetKnownVariableInfo): Make private.
13990 (Block.IsVariableUsedInChildBlock): Remove.
13991 (Block.IsVariableUsedInBlock): Likewise.
13992 (Block.CheckInvariantMeaningInBlock): New. Show location of
13993 conflicting declaration.
13994 (Block.AddVariable): Make error messages less long-winded and more
13995 specific. Show location of conflicting declaration.
13996 * parameter.cs (Parameters.Location): New readonly property.
13998 2005-03-31 Raja R Harinath <rharinath@novell.com>
14000 Clean up semantics of invoking ResolveMemberAccess.
14001 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14002 can have an instance, ensure that we pass in a non-TypeExpression
14003 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14004 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14005 argument. Update to changes and simplify.
14006 (FieldExpr.Emitinstance): Remove CS0120 check.
14007 (PropertyExpr.EmitInstance): Likewise.
14008 * expression.cs (Argument.Resolve): Likewise.
14009 (Invocation.DoResolve): Update to changes in semantics of
14010 InstanceExpression.
14012 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14015 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14018 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14020 2005-03-31 Raja R Harinath <rharinath@novell.com>
14022 Fix difference in behaviour with commandline invocation.
14023 * driver.cs (Driver.Reset): New.
14024 (CompilerCallableEntryPoint): Call it.
14026 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14027 variable" warnings if the boolean expression failed to resolve.
14029 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14031 * attribute.cs: Fix the union of several permissions when some of them
14032 are unrestricted (so the result isn't an unrestricted permission set).
14035 2005-03-30 Raja R Harinath <rharinath@novell.com>
14037 * ecore.cs (MemberExpr): New class. Convert from interface
14039 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14040 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14042 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14043 (MethodGroupExpr.IsExplicitImpl): Remove.
14044 (Expression.GetFieldFromEvent): Remove.
14045 (SimpleName.MemberStaticCheck): Remove.
14046 (SimpleName.DoSimpleNameResolve): Update to changes.
14047 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14048 (MemberAccess.IdenticalNameAndTypeName): Remove.
14049 (MemberAccess.error176): Move to MemberExpr.
14050 (MemberAccess.DoResolve): Update to changes.
14051 (BaseAccess.DoResolve): Likewise.
14053 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14055 C# 2.0 Conditional attribute class implementation
14057 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14058 Analyzes class whether it has attribute which has ConditionalAttribute
14059 and its condition is not defined.
14061 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14062 (Class.IsExcluded): New method. Search for at least one defined
14063 condition in ConditionalAttribute of attribute class.
14065 2005-03-30 Raja R Harinath <rharinath@novell.com>
14067 * ecore.cs (PropertyExpr): Derive from Expression, not
14068 ExpressionStatement.
14069 (PropertyExpr.EmitStatement): Remove.
14071 2005-03-29 Raja R Harinath <rharinath@novell.com>
14074 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14075 internal field "value__" of an enum be private. The examples for
14076 "value__" that I found on MSDN all used FieldAttributes.Private.
14078 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14079 Don't mention IL method attribute names.
14081 Fix #47991. Remove a TODO.
14082 * statement.cs (Block.Toplevel): Make into a field.
14083 (Block.Parameters): Move into ToplevelBlock.
14084 (Block.known_variables): Rename from child_variable_names.
14085 (Block.Block): Remove variants that take Parameters. Initialize
14086 'Toplevel' with the immediately surrounding toplevel block.
14087 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14088 LocalInfo parameter.
14089 (Block.GetKnownVariableInfo): New.
14090 (Block.IsVariableNameUsedInChildBlock): Update.
14091 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14092 the block, even though it may not be in scope.
14093 (Block.AddVariable): Remove Parameters parameter. Use
14094 Toplevel.Parameters instead.
14095 (Block.AddConstant): Remove Parameters parameter.
14096 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14097 (Block.IsParamaterReference): Likewise.
14098 (Block.IsLocalParameter): Likewise. Simplify a lot.
14099 (ToplevelBlock.Parameters): New. Moved from Block.
14100 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14101 initialize Parameters to a non-null value.
14102 * cs-parser.jay: Update to changes.
14103 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14104 simple names that mean different things in the same block. Use
14105 Block.IsVariableNameUsedInBlock.
14107 2005-03-28 Raja R Harinath <rharinath@novell.com>
14109 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14110 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14111 GetTypeHandle. It is possible for a reflected type to derive from
14112 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14113 System.Array during mscorlib compilation).
14114 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14115 contain a method_hash, don't create one either. Don't create a
14116 deep copy of the base cache's method_hash.
14117 (MemberCache.SetupCache): Rename back from DeepCopy.
14118 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14119 already initialized. If we see an override function, add its
14120 underlying base virtual function to the member_hash too.
14122 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14124 2005-03-26 Raja R Harinath <harinath@acm.org>
14127 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14128 fails to resolve, ensure that the LHS is still resolved as an
14131 2005-03-25 Raja R Harinath <harinath@acm.org>
14133 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14135 (Enum.current_ec): Remove.
14136 (Enum.LookupEnumValue): Remove EmitContext argument.
14137 Just uses the one created during DefineType.
14138 (Enum.FindMembers): Update.
14139 * expression.cs (MemberAccess.DoResolve): Update.
14141 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14143 * assign.cs (Assign.DoResolve): Check for CS1717 when
14144 source and target are same (uses Equals).
14146 * expression.cs (LocalVariableReference, ParameterReference,
14147 This): Implemented Equals, GetHashCode.
14149 * statement.cs (Block.GetParameterReference): Removed useless
14152 2005-03-22 Raja R Harinath <rharinath@novell.com>
14155 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14156 blocks before deciding whether the error is cs0136 or cs0128.
14158 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14159 (using_alias_directive, using_namespace_directive): Pass
14160 MemberName, not an expression to Namespace.UsingAlias and
14162 (MakeName): Use the MemberName of the namespace.
14163 * namespace.cs (Namespace.MemberName): New.
14164 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14165 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14167 * decl.cs (MemberName.Name): Make readonly.
14168 (MemberName.FromDotted): New "constructor".
14169 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14170 (MemberCore.Name): Compute from MemberName on demand.
14171 (MemberCore.SetMemberName): Provide a way to change the
14173 (MemberCore.AddToContainer): Don't take a fullname parameter.
14174 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14175 fully qualified name of the container to the member name.
14176 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14177 only if the type is a member of the root container.
14178 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14179 MemberName.Left rather than searching for an embedded ".".
14180 (PartialContainer.CreatePart): Update to changes in RootContext.
14181 (MemberBase.ShortName): Turn into a property. Use
14182 MemberCore.SetMemberName.
14183 (MemberBase.ExplicitInterfaceName): Remove.
14184 (MemberBase.UpdateMemberName): Remove.
14185 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14186 (PropertyBase.SetMemberName): New override.
14187 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14188 (Tree.GetDecl): New.
14189 (Tree.AllDecls): Rename from Decls.
14190 * attribute.cs, enum.cs, report.cs: Update to changes.
14191 * driver.cs (MainDriver): Use MemberName.FromDotted on
14192 RootContext.MainClass.
14194 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14196 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14199 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14201 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14203 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14204 property accessor modifiers.
14206 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14207 fixed buffer attribute (CS1716).
14208 (PropertyMethod.HasCustomAccessModifier): When property accessor
14209 has custom modifier.
14211 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14213 (PropertyExpr.DoResolveLValue): Add CS0272.
14215 2005-03-17 Miguel de Icaza <miguel@novell.com>
14217 * convert.cs: When converting to a pointer, use the proper Conv.U
14218 or Conv.I depending on the source data type.
14220 * cs-tokenizer.cs: Make the size for large decimal constants,
14223 2005-03-17 Martin Baulig <martin@ximian.com>
14225 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14226 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14228 2005-03-17 Martin Baulig <martin@ximian.com>
14230 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14231 to bool so we can return an error condition.
14232 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14235 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14237 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14240 2005-03-16 Raja R Harinath <rharinath@novell.com>
14242 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14243 Refactor to avoid traversing the list of assemblies, and to avoid
14244 string concatenation.
14245 * typemanager.cs (guid_attr_type): Remove.
14246 (negative_hits, pointers, references): Remove hashes.
14248 (GetConstructedType): New. Uses type_hash to handle constructed
14249 types (arrays, references, pointers).
14250 (GetReferenceType, GetPointerType): Use it.
14251 (GetNestedType): New. Uses type_hash to handle nested types of
14253 (LookupType, LookupTypeDirect): Remove.
14254 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14255 'types' hash and LookupTypeReflection directly.
14256 (params_string, params_object): Use GetConstructedType.
14257 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14259 (Namespace.Lookup): Use cached_types.
14260 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14261 provided by old TypeManager.LookupType.
14262 * rootcontext.cs (MakeFQN): Remove.
14263 * decl.cs (DeclSpace.MakeFQN): Likewise.
14264 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14265 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14266 TypeManager.GetConstructedType.
14267 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14269 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14271 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14274 * cs-parser.jay: Reports CS1527 for any namespace element.
14276 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14279 * expression.cs (ParameterReference.IsAssigned): Changed error to
14281 (Error_WrongNumArguments): Moved CS0245 detection here.
14283 * statement.cs (Return.Resolve): Add CS1622 report.
14285 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14287 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14289 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14291 * attribute.cs expression.cs: Get rid of some allocations.
14293 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14295 * doc.cs : just eliminate the latest change.
14297 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14299 * doc.cs : commented out the latest change. It breaks xml-030.cs
14301 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14303 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14304 fail. So invoke CreateType() in FindDocumentedType().
14306 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14308 * cs-tokenizer.cs : added IsKeyword().
14309 * doc.cs : Detect keyword incorrectly used as identifier.
14310 Allow identifiers prefixed by @.
14312 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14314 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14315 It caused exception in namespace resolving (again!).
14317 * class.cs (Class.ctor): Removed exit.
14318 (PropertyMethod.ctor): ditto.
14320 * codegen.cs (Codegen.Reset): Reset static data.
14321 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14323 * cs-tokenizer.cs (Cleanup): Removed.
14325 * driver.cs (GetSystemDir): Rewrote to one line command.
14326 It caused problem with unloaded dynamic modules.
14327 (UnixParseOption): Removed Exit.
14328 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14329 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14330 Now can be mcs used as library.
14332 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14335 * location.cs (Reset): Reset static data.
14337 * namespace.cs (Reset): Reset static data.
14339 * report.cs (Report.Reset): Reset static data.
14341 * rootcontext.cs (RootContext.Reset): Reset static data.
14343 * tree.cs (RootTypes.ctor): Use Location.Null
14345 * typemanager.cs (TypeManager.Reset): Reset static data.
14346 (CoreLookupType): Removed Exit.
14347 (TypeHandle.Reset): Reset static data.
14349 2005-03-10 Raja R Harinath <rharinath@novell.com>
14352 * typemanager.cs (ComputeNamespaces): Import namespaces from
14353 referenced modules too.
14355 2005-03-09 Raja R Harinath <rharinath@novell.com>
14357 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14360 2005-03-09 Raja R Harinath <rharinath@novell.com>
14362 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14363 enclosing DeclSpace. This ensures that a name-lookup populates
14364 more caches and there are fewer 'TypeExpression's. Carve out
14365 nested type lookup into ...
14366 (LookupNestedTypeInHierarchy): ... this.
14368 2005-03-09 Raja R Harinath <rharinath@novell.com>
14370 Clean up a few partial-class semantics.
14371 Fixes test-357.cs and cs1618-2.cs.
14372 * cs-parser.jay (struct_declaration): Use 'current_class' as
14373 parent of newly-created struct. Remove call to Register ().
14374 Use 'pop_current_class' to complete handing the current struct.
14375 (interface_declaration): Likewise.
14376 (class_declaration): Likewise.
14377 (enum_declaration): Use 'current_class' as parent of newly created
14379 (delegate_declaration): Likewise.
14380 (pop_current_class): New function. This is used to handle closing
14381 up the 'current_class' and 'current_container', and pointing them
14382 to the enclosing class/container.
14383 (CSharpParser): Initialize 'current_class' too.
14384 * decl.cs (MemberCore): Add check for invariant: a partial
14385 container is not a parsed entity, and thus does not enclose any
14387 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14388 (DeclSpace.BaseTypeExpr): Use it.
14389 (DeclSpace.LookupType): Add check for invariant.
14390 * class.cs (TypeContainer): Add check for invariant: a nested
14391 class should have the same NamespaceEntry as its enclosing class.
14392 (TypeContainer.EmitFieldInitializers): Make virtual.
14393 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14395 (TypeContainer.Register): Remove.
14396 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14397 null. Use TypeResolveEmitContext for resolving base types and
14398 interfaces. Move initialization of Parts.TypeBuilder here from
14400 (TypeContainer.DefineNestedTypes): ... here.
14401 (PartialContainer): Take a Namespace not a NamespaceEntry.
14402 (PartialContainer.Create): Don't use Register. Call the
14403 appropriate Add... function directly.
14404 (ClassPart): Take both the PartialContainer and the enclosing
14405 class as constructor arguments.
14406 (ClassPart.EmitFieldInitializers): Override.
14407 (ClassPart.PartFindNestedTypes): Remove.
14408 (FieldBase.GetInitializerExpression): Resolve the initializer
14409 expression in the emit context of the enclosing class.
14410 * tree.cs (RootTypes): Remove Register ().
14412 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14414 * cs-parser.jay: Removed CS0134.
14416 * driver.cs: Removed CS1901.
14418 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14419 for predefined types.
14421 2005-03-07 Duncan Mak <duncan@novell.com>
14423 * codegen.cs (Save): Catch UnauthorizedAccessException as
14424 well. Fixes bug #73454.
14426 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14428 * cs-tokenizer.cs (xtoken): Add CS1035.
14430 * class.cs (MethodData.Define): Add CS0683.
14431 (FieldMember.ctor): Add CS0681.
14433 2005-03-07 Raja R Harinath <rharinath@novell.com>
14435 * ecore.cs (SimpleName.DoResolve): Rename from
14436 SimpleName.DoResolveAllowStatic.
14437 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14438 Pass 'intermediate' flag to MemberStaticCheck.
14439 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14440 of "intermediate" lookups via MemberAccess.
14441 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14442 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14444 2005-03-07 Raja R Harinath <rharinath@novell.com>
14447 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14448 slipped in because of variable names that are identical to a
14449 builtin type's BCL equivalent ('string String;', 'int Int32;').
14450 (PropertyExpr.EmitInstance): Likewise.
14452 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14454 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14456 * report.cs (warning_ignore_table): Made public.
14458 2005-03-04 Raja R Harinath <rharinath@novell.com>
14461 * class.cs (MethodData.Emit): Pass 'container' to
14462 container.GetObsoleteAttribute instead of 'container.Parent'.
14464 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14466 * cs-parser.jay: Add 1534 error test.
14468 * iterators.cs (Yield.CheckContext): Add error 1629.
14469 (Iterator.ctor): Save unsafe modifier.
14470 (MoveNextMethod.DoEmit): Restore unsafe context.
14472 * namespace.cs (UsingAlias): Better error message.
14474 2005-03-03 Dan Winship <danw@novell.com>
14476 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14477 the warning message [#73219]
14479 2005-03-03 Raja R Harinath <rharinath@novell.com>
14481 Fix compile with MCS 1.0.0.0.
14482 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14483 w_restore to not depend on string constant folding.
14485 2005-03-03 Raja R Harinath <rharinath@novell.com>
14487 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14488 CS0246 check to users who passed 'silent = false'.
14489 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14491 (SimpleName.SimpleNameResolve): Update.
14492 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14493 (MemberAccess.IdenticalNameAndTypeName): Update.
14494 * doc.cs (FindDocumentedTypeNonArray): Update.
14496 2005-03-03 Raja R Harinath <rharinath@novell.com>
14498 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14499 * parameters.cs (ComputeAndDefineParameters): Remove.
14500 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14501 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14502 Use GetParameterInfo.
14504 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14506 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14508 2005-03-02 Raja R Harinath <rharinath@novell.com>
14510 Unify DeclSpace.LookupType and DeclSpace.FindType.
14511 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14512 is in charge of defining nested types on demand.
14513 (DeclSpace.LookupType): Use it when the current_type is a
14514 TypeBuilder. Use LookupTypeDirect for reflected types.
14515 (DeclSpace.FindType): Remove.
14516 (DeclSpace.LookupInterfaceOrClass): Likewise.
14517 (DeclSpace.DefineTypeAndParents): Likewise.
14518 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14519 DeclSpace.LookupType.
14520 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14521 * typemanager.cs (LookupType): Simplify.
14522 (AddUserType): Remove type from negative_hits.
14523 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14524 * class.cs (TypeContainer.FindMembers): Move handling of nested
14526 (TypeContainer.FindMembers_NestedTypes): ... here.
14527 (TypeContainer.FindNestedType): Implement override.
14528 (ClassPart.FindNestedType): Delegate to PartialContainer.
14529 (ClassPart.PartFindNestedType): Looks up the nested types of the
14532 2005-03-02 Martin Baulig <martin@ximian.com>
14534 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14535 static constructor in static classes.
14537 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14539 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14540 sizeParamIndex is not specified.
14542 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14545 * report.cs (WarningMessage.IsEnabled): Missing null check.
14547 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14549 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14550 in the fields and not in the properties.
14552 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14554 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14557 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14559 * attribute.cs: Small refactoring (improved robustness).
14560 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14561 (ValidateGuid): Removed.
14562 (Resolve): Removed referenced to above mentioned.
14563 (GetAttributeUsage): Made private and changed to work without
14565 (GetIndexerAttributeValue): Don't crash.
14566 (GetConditionalAttributeValue): Ditto.
14567 (GetClsCompliantAttributeValue): Ditto.
14568 (ExtractSecurityPermissionSet): All attributes exceptions are
14570 (GetPropertyValue): New helper.
14571 (GetMethodImplOptions): New method.
14572 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14573 some missing properties.
14575 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14576 (Method.ApplyAttributeBuilder): Updated.
14578 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14581 2005-02-28 Raja R Harinath <rharinath@novell.com>
14584 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14585 non-simple types (array, pointer, reference).
14587 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14589 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14591 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14593 (Method.CheckBase): Catch wrong destructor here.
14594 (MethodData.Define): Add errors 550, 668.
14596 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14598 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14600 * pending.cs (VerifyPendingMethods): Add error 551.
14602 * typemanager.cs (CSharpName): Next error report helper.
14604 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14606 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14607 attributes. Removed useless attribute double check.
14608 It saves almost 2MBs for corlib.
14610 2005-02-25 Raja R Harinath <rharinath@novell.com>
14613 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14614 called twice in case of error.
14616 2005-02-23 Chris Toshok <toshok@ximian.com>
14618 Fix compiler portions of #72827.
14619 * statement.cs (Block.Emit): call Begin/EndScope on the
14620 EmitContext instead of the ILGenerator.
14622 * codegen.cs (EmitContext.BeginScope): new method, call
14623 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14625 (EmitContext.BeginScope): same, but EndScope and CloseScope
14627 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14628 offset and call the superclass's OpenScope(int) with it.
14629 (SymbolWriter.CloseScope): get the current il
14630 offset and call superclass's CloseScope(int) with it.
14632 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14634 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14635 CS1677 for out and ref as well.
14637 * class.cs (Method.Define): Add error CS1599 detection.
14639 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14641 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14643 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14645 * support.cs.cs (ModifierDesc): New helper method.
14647 2005-02-23 Raja R Harinath <rharinath@novell.com>
14648 Abin Thomas <projectmonokochi@rediffmail.com>
14649 Anoob V E <projectmonokochi@rediffmail.com>
14650 Harilal P R <projectmonokochi@rediffmail.com>
14652 Fix #57851, #72718.
14653 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14654 MemberLookup (used for error reporting) actually returns a result.
14655 Fix error report number (122, not 112).
14657 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14658 Anoob V E <projectmonokochi@rediffmail.com>
14659 Harilal P R <projectmonokochi@rediffmail.com>
14662 * pending.cs (PendingImplementation.GetAbstractMethods):
14663 Find NonPublic members too.
14665 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14667 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14670 * class.cs (MethodCore.CheckMethodAgainstBase):
14671 Add error 239 report.
14673 2005-02-21 Raja R Harinath <rharinath@novell.com>
14676 * expression.cs (Invocation.IsApplicable): Make public.
14677 (Invocation.IsParamsMethodApplicable): Likewise.
14678 * delegate.cs (Delegate.VerifyApplicability): Don't use
14679 Invocation.VerifyArgumentCompat for parameter applicability
14680 testing. Use Invocation.IsApplicable and
14681 Invocation.IsParamsMethodApplicable.
14683 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14685 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14687 * class.cs (Operator.Define): Add error 217 report.
14689 2005-02-21 Raja R Harinath <rharinath@novell.com>
14691 * namespace.cs (UsingEntry.Resolve): Undo change below.
14693 2005-02-21 Raja R Harinath <rharinath@novell.com>
14696 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14697 disable the error message when the extended MemberLookup also
14699 (Expression.MemberLookupFinal): Update.
14700 (SimpleName.DoSimpleNameResolve): Update.
14701 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14702 Don't use MemberLookupFinal.
14703 (New.DoResolve): Update.
14704 (BaseAccess.CommonResolve): Update.
14706 2005-02-21 Raja R Harinath <rharinath@novell.com>
14709 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14710 occured previously, don't resolve again.
14712 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14715 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14716 argument. Call ResolveAttributeUsage for unresolved.
14717 when types doesn't match ctor arguments.
14719 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14720 for nested attribute classes.
14721 (Class.attribute_usage): Removed.
14722 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14723 for attribute class.
14725 * ecore.cs (IsAttribute): Removed.
14727 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14729 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14731 (attribute_types): Removed.
14732 (EmitCode): Global attributes are emited as the latest.
14734 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14736 * class.cs (EmitFieldInitializers): Don't emit field initializer
14737 for default values when optimilization is on.
14739 * constant.cs (Constant.IsDefaultValue): New property.
14741 * driver.cs: Add /optimize handling.
14745 * literal.cs: Implement new IsDefaultValue property.
14747 * rootcontext.cs (Optimize): New field, holds /optimize option.
14749 2005-02-18 Raja R Harinath <rharinath@novell.com>
14751 Fix crasher in re-opened #72347.
14752 * namespace.cs (Namespace.Lookup): Return null if
14753 DeclSpace.DefineType returns null.
14756 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14758 2005-02-18 Raja R Harinath <rharinath@novell.com>
14760 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14761 now returns null if it cannot resolve to an lvalue.
14762 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14763 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14764 returned null. Remove check for SimpleName.
14765 (EventExpr.DoResolveLValue): New.
14766 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14767 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14769 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14770 avoid CS0131 error.
14771 (Unary.ResolveOperator): Move CS0211 check ...
14772 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14774 (Unary.DoResolveLValue): Simplify.
14775 (AddressOf.DoResolveLValue): New.
14776 (ArrayAccess.DoResolveLValue): New.
14778 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14780 * attribute.cs (Attribute.Resolve): Add arguments casting for
14781 when types doesn't match ctor arguments.
14783 2005-02-16 Raja R Harinath <rharinath@novell.com>
14785 Fix parts of #63202.
14786 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14787 lookup of operator in base type. Ensure that all checks happen
14788 when the operator resolves to an "op_..." method.
14790 2005-02-15 Raja R Harinath <rharinath@novell.com>
14793 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14794 'ignore_cs0104' parameter. Pass it to ...
14795 (NamespaceEntry.Lookup): ... this.
14796 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14797 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14798 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14799 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14800 Update. Request that cs0104 errors be ignored.
14801 (ComposedCast.ResolveAsTypeStep): Update.
14803 2005-02-14 Raja R Harinath <rharinath@novell.com>
14806 * expression.cs (Invocation.BetterFunction): Remove support for
14807 comparing virtual functions and their overrides.
14808 (Invocation.IsOverride): New.
14809 (Invocation.OverloadResolve): Don't consider 'override' functions
14810 during candidate selection. Store them in a lookaside list.
14811 If the selected method is a 'virtual' function, use the list to
14812 find any overrides that are closer to the LHS type.
14814 2005-02-14 Marek Safar <marek.safar@seznam.cz>
14816 * expression.cs (New.DoResolve): Add complex core type reduction.
14817 (New.Constantify): Converts complex core type syntax like 'new int ()'
14818 to simple constant.
14820 2005-02-14 Raja R Harinath <rharinath@novell.com>
14822 * decl.cs (EntryType.EntryType): New constructor to create an
14823 updated copy of a cache entry.
14824 (MemberCache.AddMethods): Use it.
14825 (MemberCache.ClearDeclaredOnly): Remove.
14826 (MemberCache.MemberCache): Update.
14828 2005-02-11 Miguel de Icaza <miguel@novell.com>
14830 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
14831 variable. This one is represents the actual low-level declaration
14832 of the method, as opposed to the semantic level `IsStatic'.
14834 An anonymous method which is hosted into a static method might be
14835 actually an instance method. IsStatic would reflect the
14836 container, while MethodIsStatic represents the actual code
14839 * expression.cs (ParameterReference): Use the new MethodIsStatic
14840 instead of IsStatic.
14842 * anonymous.cs (AnonymousMethod.Compatible): Pass the
14843 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
14844 set on the current EmitContext.
14846 * expression.cs (Cast): Overload DoResolveLValue so we can pass
14847 resolve our casted expression as an LValue. This triggers the
14848 proper LValue processing that is later required by Assign.
14852 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
14854 2005-02-11 Marek Safar <marek.safar@seznam.cz>
14856 C# 2.0 Fixed buffer implementation
14858 * anonymous.cs: Update after RegisterHelperClass renaming.
14860 * attribute.cs (AttributeTester.fixed_buffer_cache):
14861 Cache of external fixed buffers.
14862 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
14863 implementation if field is fixed buffer else null.
14866 (TypeContainer.AddField): Accept FieldMember instead of Field.
14867 (FieldBase.IsFieldClsCompliant): Extracted code from
14868 VerifyClsCompliance descendant customization.
14869 (FixedField): New class handles fixed buffer fields.
14870 (FixedFieldExternal): Keeps information about imported fixed
14872 (IFixedField): Make access to internal or external fixed buffer
14875 * cs-parser.jay: Add fixed buffer parsing.
14877 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
14880 * expression.cs (Indirection): Extended implementation to accept
14881 fixed buffer field.
14882 (PointerArithmetic.Emit): Get element from fixed buffer as well.
14883 (ElementAccess.MakePointerAccess): Get type as parameter.
14884 (DoResolve): Add fixed buffer field expression conversion.
14885 (DoResolveLValue): Ditto.
14886 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
14887 (ArrayPtr): Derives from FixedBufferPtr.
14888 (ArrayPtr.Emit): Add extra emit for array elements.
14890 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
14892 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
14893 for compiler generated types.
14894 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
14896 * statement.cs (Fixed): Refactored to be easier add fixed buffer
14897 and consume less memory.
14898 (Fixed.Resolve): Add fixed buffer case.
14900 * typemanager.cs (compiler_generated_attr_ctor,
14901 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
14902 (HasElementType): Add our own implementation to work on every
14905 2005-02-11 Miguel de Icaza <miguel@novell.com>
14907 * anonymous.cs (CaptureContext): Track whether `this' has been
14910 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
14911 only captured `this' if it was implicitly done (instance
14912 methods/variables were used).
14914 * codegen.cs (EmitContext.CaptureThis): New method to flag that
14915 `this' must be captured.
14917 2005-01-30 Miguel de Icaza <miguel@novell.com>
14919 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
14920 is null it means that there has been no need to capture anything,
14921 so we just create a sibling.
14923 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
14925 Just a partial fix. The other half is fairly elusive.
14927 2005-02-10 Raja R Harinath <rharinath@novell.com>
14929 Fix #52586, cs0121-4.cs.
14930 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
14931 and return a hashtable.
14932 (MemberCache.ClearDeclaredOnly): New.
14933 (MemberCache.MemberCache): Update to change. Make a deep copy of
14934 the method_hash of a base type too.
14935 (MemberCache.AddMethods): Adapt to having a deep copy of the base
14936 type methods. Overwrite entries with the same MethodHandle so
14937 that the ReflectedType is correct. The process leaves in base
14938 virtual functions and their overrides as distinct entries.
14939 (CacheEntry): Now a class instead of a struct. It shouldn't alter
14940 matters since it was boxed in a ArrayList before.
14941 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
14943 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
14944 case of a virtual function and its override (choose the overload
14946 (Invocation.OverloadResolve): Avoid 'override' members during
14947 'applicable_type' calculation.
14949 2005-02-09 Raja R Harinath <rharinath@novell.com>
14951 Combine two near-redundant caches.
14952 * typemanager.cs (method_params): Rename from method_internal_params.
14953 (TypeManager.GetParameterData): New. Replace
14954 Invocation.GetParameterData.
14955 (TypeManager.LookupParametersByBuilder): Remove.
14956 * expression.cs (Invocation.method_parameter_cache): Remove.
14957 (Invocation.GetParameterData): Remove.
14959 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
14962 2005-02-08 Raja R Harinath <rharinath@novell.com>
14965 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
14966 TypeManager.multicast_delegate_type is null, resolve it by looking
14967 up "System.MulticastDelegate".
14968 * rootcontext.cs (RootContext.ResolveCore): Simplify.
14970 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
14971 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
14972 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
14975 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
14976 (LabeledStatement.AddReference): New. Set 'referenced'.
14977 (Goto.Resolve): Use it.
14979 2005-02-05 John Luke <john.luke@gmail.com>
14981 * driver.cs: remove duplicate -doc line in Usage ()
14983 2005-02-04 Raja R Harinath <rharinath@novell.com>
14985 * location.cs (Location.AddFile): Fix CS2002 error report.
14987 2005-02-02 Martin Baulig <martin@ximian.com>
14989 * delegate.cs (Delegate.DefineType): Report an internal error if
14990 TypeManager.multicast_delegate_type is null. See bug #72015 for
14993 2005-02-02 Raja R Harinath <rharinath@novell.com>
14995 Fix a crasher in a variant of #31984.
14996 * const.cs (Constant.CheckBase): New override that defers the
14997 new-or-override check in case the base type hasn't been populated
14999 (Constant.Define): Ensure the new-or-override check is performed.
15001 2005-02-01 Duncan Mak <duncan@ximian.com>
15003 * const.cs (LookupConstantValue): Check that `ce' is not null
15004 before calling GetValue ().
15006 2005-02-01 Raja R Harinath <rharinath@novell.com>
15008 Fix test-334.cs (#69519).
15009 * cs-parser.jay (using_alias_directive): Pass in an expression to
15010 NamespaceEntry.UsingAlias.
15011 (using_namespace_directive): Pass in an expression to
15012 NamespaceEntry.Using.
15013 (namespace_name): Don't flatten to a string.
15014 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15015 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15017 (NamespaceEntry.UsingEntry): Likewise.
15018 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15020 (NamespaceEntry.LookupForUsing): Remove.
15021 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15023 (NamespaceEntry.Lookup): Remove support for dotted names.
15025 2005-02-01 Raja R Harinath <rharinath@novell.com>
15027 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15029 (NamespaceEntry.ImplicitParent): Compute on demand.
15030 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15031 parallels the current.
15032 (NamespaceEntry.LookupForUsing): Use it.
15033 (NamespaceEntry.Lookup): If the current namespace-entry is
15034 implicit, don't search aliases and using tables.
15036 2005-02-01 Raja R Harinath <rharinath@novell.com>
15039 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15041 (TypeContainer.BaseCache): Compute on demand.
15042 (TypeContainer.FindMembers): Define constants and types if they're
15043 not already created.
15044 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15046 * const.cs (Constant.Define): Make idempotent.
15048 2005-01-29 Miguel de Icaza <miguel@novell.com>
15050 * pending.cs: Produce better code (no nops produced by using Ldarg
15053 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15054 i - 1' it should be arg + 1.
15058 2005-01-28 Raja R Harinath <rharinath@novell.com>
15060 * attribute.cs (Attribute.CheckAttributeType): Make private
15062 (Attribute.ResolveType): Make virtual.
15063 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15064 handling of RootContext.Tree.Types.
15066 2005-01-27 Raja R Harinath <rharinath@novell.com>
15068 Update attribute-handling to use the SimpleName/MemberAccess
15070 * cs-parser.jay (attribute): Pass in an expression to the
15071 constructors of Attribute and GlobalAttribute.
15072 * attribute.cs (Attribute): Take an expression for the name.
15073 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15074 passed in attribute name expression.
15075 (Attribute.CheckAttributeType): Use it.
15076 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15077 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15078 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15079 argument to prevent error messages if the lookup fails.
15081 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15083 * expression.cs (Indirection): Implemented IVariable interface
15084 to support indirection in AddressOf operator.
15085 (PointerArithmetic.Emit): Add optimalization for case where
15086 result can be precomputed.
15088 2005-01-26 Martin Baulig <martin@ximian.com>
15090 * class.cs (TypeContainer.AttributeTargets): Return the correct
15091 AttributeTargets depending on our `Kind' instead of throwing an
15092 exception; fixes #71632.
15094 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15097 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15100 2005-01-25 Raja R Harinath <rharinath@novell.com>
15103 * expression.cs (MemberAccess.DoResolve): Don't complain with
15104 cs0572 when the LHS of a member access has identical name and type
15107 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15110 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15112 Create custom PermissionSet only for PermissionSetAttribute.
15114 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15117 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15118 delegates in static class.
15120 2005-01-24 Martin Baulig <martin@ximian.com>
15122 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15123 merging an implicit block, just use its reachability.
15125 * statement.cs (Block.Resolve): Make the unreachable code check
15126 work wrt. implicit blocks; see test-337 from #63842.
15128 2005-01-21 Alp Toker <alp@atoker.com>
15130 * cs-parser.jay: destructor_declaration's container is PartialContainer
15131 not Class when partial types are used, so use Kind prop instead of
15134 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15136 * cs-parser.jay: Improve error reporting when an interface
15137 declares new types.
15139 2005-01-20 Dick Porter <dick@ximian.com>
15141 * support.cs: SeekableStreamReader fix from Sandor Dobos
15142 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15143 chars are read. Fixes bug 70369.
15145 2005-01-20 Raja R Harinath <rharinath@novell.com>
15147 * cs-parser.jay (catch_clause): Simplify current_block handling
15150 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15152 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15153 code with ImplicitStandardConversion to handle the implicit
15154 conversion of method groups into valid delegate invocations.
15156 The problem is that in parameter handling we were using this code
15157 path. Fixes bug #64698
15159 2005-01-19 Raja R Harinath <rharinath@novell.com>
15161 * cs-parser.jay: Fix several infelicities.
15162 - Avoid assigning to the parser value stack. Code like
15163 '$3 = null' is unclean. Synthesize a value for the code block
15165 - Avoid using oob_stack for storing location information. Use ...
15166 (_mark_): ... this. New (empty) rule. Saves the current location
15168 (foreach_statement): Avoid using oob_stack for current_block
15169 handling. Use technique used in for_statement and
15170 using_statement. Synthesize a value for the code block to store
15171 additional intermediate information.
15173 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15175 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15176 of a different type is only allowed to private fields of a
15177 containing type, not on fields of a base class.
15179 See test-174.cs and error cs0122-9.cs
15181 2005-01-13 Raja R Harinath <rharinath@novell.com>
15183 Fix test-335.cs (bug #58126).
15184 * cs-parser.jay (argument): Split out non-expression parts of the
15185 rule into 'non_simple_argument'.
15186 (invocation_expression): Support parenthesized invocations with
15187 multiple arguments, and with single non-simple arguments.
15189 2005-01-13 Raja R Harinath <rharinath@novell.com>
15191 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15194 2005-01-12 Raja R Harinath <rharinath@novell.com>
15196 Fix cs0038-1.cs, cs1640-6.cs.
15197 * ecore.cs (Expression.Resolve): Remove special-case for
15198 SimpleName in error-handling.
15199 (Expression.almostMatchedMembers): Relax access permission to
15201 (Expression.MemberLookupFailed): Handle duplicates in
15202 almostMatchedMembers list.
15203 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15204 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15205 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15206 overload if the passed in MemberInfo is a MethodBase.
15208 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15211 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15212 for non-CAS & merge permission sets properly.
15214 2005-01-11 Raja R Harinath <rharinath@novell.com>
15216 Improve standard-compliance of simple name and member access
15217 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15218 * ecore.cs (FullNamedExpression): New abstract base class
15219 for Namespaces and TypeExpressions.
15220 (ResolveFlags.SimpleName): Remove.
15221 (SimpleName): Remove support for dotted names.
15222 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15223 DeclSpace.FindType and DeclSpace.LookupType.
15224 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15225 (Expression.ExprClassName): Make member function.
15226 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15227 a namespace. Remove creation of dotted "SimpleName"s.
15228 (MemberAccess.DoResolve): Likewise.
15229 * decl.cs (DeclSpace.Cache): Make private.
15230 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15231 (DeclSpace.FindType): Update.
15232 (DeclSpace.LookupType): Move here from RootContext. Return a
15233 FullNamedExpression.
15234 * namespace.cs (Namespace): Derive from FullNamedExpression
15235 so that it can be part of expression resolution.
15236 (Namespace.Lookup): Return an FullNamedExpression.
15237 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15239 * rootcontext.cs (NamespaceLookup): Remove.
15240 (LookupType): Move to DeclSpace.
15241 * attribute.cs (CheckAttributeType): Update.
15242 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15243 (FindDocumentedTypeNonArray): Likewise.
15245 2005-01-11 Raja R Harinath <rharinath@novell.com>
15247 Fix cs0509.cs, cs1632.cs.
15248 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15249 is the same as IsInterface.
15250 (TypeContainer.GetClassBases): Likewise.
15251 * statement.cs (LabeledStatement.ig): New field.
15252 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15254 (LabeledStatement.DoEmit): Check that the label was created with
15255 the same ILGenerator.
15257 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15260 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15261 accessors to its properties.
15263 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15264 from accessors to property.
15266 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15269 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15270 only for overrides.
15272 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15274 * attribute.cs: Check for null and empty strings.
15276 I have lost another battle to Paolo.
15278 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15281 * class.cs (PropertyMethod): Set Parent field in ctors.
15282 (SetMethod.InternalParameters): Add unsafe switch hack.
15283 Override MarkForDuplicationCheck where it is appropriate.
15285 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15286 It says whether container allows members with the same name.
15287 Base default is no.
15288 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15289 Removed is_method parameter.
15291 2005-01-06 Duncan Mak <duncan@ximian.com>
15293 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15294 because the previous change led to incorrect reporting of CS1032
15295 ("Cannot define/undefine preprocessor symbols after first token in
15296 file"). Instead of using `tokens_seen' as the only flag that
15297 triggers CS1040, introduce `comments_seen'. This new flag is used
15298 to signify having seen comments on the current line, so it is
15299 unset after a newline.
15301 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15303 * doc.cs : When searching for a type, find nested type too.
15304 This fixes bug #71040.
15306 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15309 - Warn missing member comment on those classes which also does not
15310 have doc comments. Fixed bug #71041.
15311 - Don't warn missing doc comment on default constructor.
15314 2005-01-06 Duncan Mak <duncan@ximian.com>
15316 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15317 comments, set `tokens_seen' to true. This allows us to detect
15318 misplaced preprocessor directives (i.e. not at the beginning of
15319 the a line, nor after whitespaces). In that case, report error
15320 CS1040. This fixes bug #56460.
15322 * cs-parser.jay (interface_member_declaration): Add checks for
15323 IsExplicitImpl, and report CS0541 error if an interface member is
15324 defined as an explicit interface declaration.
15326 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15329 * class.cs (PropertyMethod): Set Parent field in ctors.
15330 (SetMethod.InternalParameters): Add unsafe switch hack.
15332 * decl.cs (MemberCore.Parent): Cannot be readonly.
15334 2005-01-06 Raja R Harinath <rharinath@novell.com>
15336 * decl.cs (DeclSpace.ResolveType): Remove.
15337 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15338 Merge in code from ...
15339 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15340 * class.cs, enum.cs: Update to changes.
15342 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15344 * anonymous.cs: Ensure that we init the scope of our parent if it
15345 has not been initialized yet.
15347 2004-12-30 Duncan Mak <duncan@ximian.com>
15349 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15350 if field.FieldBuilder is null. Fixes #70758.
15352 * convert.cs: Fixed some typos and updated some of the comments.
15353 (ImplicitStandardConversionExists):
15354 (TryImplicitIntConversion): If `target_type' is an interface and
15355 the type of `ic' implements this interface, return true or a new
15356 BoxedCast instead of null. This fixes #70468.
15358 2004-12-29 Duncan Mak <duncan@ximian.com>
15360 * expression.cs (Argument.Emit): Check that Expr is
15361 IMemoryLocation before casting to it, and report CS1510 otherwise.
15365 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15367 * statement.cs (Block.ThisVariable): remove the recursion here, to
15368 make the --profile more sane.
15370 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15372 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15373 assembly, by JB Evain.
15375 2004-12-17 Raja R Harinath <rharinath@novell.com>
15377 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15378 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15379 "parent" refers to enclosing type/class. "base" refers to superclass.
15381 2004-12-17 Raja R Harinath <rharinath@novell.com>
15383 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15384 Ensure that we only have GlobalAttributes.
15385 * attribute.cs (Attribute.Emit): Make non-virtual.
15386 (GlobalAttribute.Emit): Remove.
15387 (Attribute.Resolve): Make virtual.
15388 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15389 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15390 the argument. Don't create one.
15391 (Attribute.GetObsoleteAttribute): Likewise.
15392 (Attribute.GetClsCompliantAttributeValue): Likewise.
15393 * class.cs, decl.cs: Update to changes.
15395 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15397 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15399 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15401 * statement.cs (Foreach.Resolve): Add error 186 report.
15403 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15405 * expression.cs (Conditional.DoResolve): Add warning 429.
15407 * statement.cs (If.Resolve): Add warning 665.
15409 2004-12-16 Raja R Harinath <rharinath@novell.com>
15411 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15412 except when in the parser, and in GlobalAttribute.
15413 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15414 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15415 RootContext.Tree.Types.NamespaceEntry once work is done.
15416 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15417 and resets RootContext.Tree.Types.NamespaceEntry.
15419 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15421 * cs-parser.jay: Don't create a block for every variable.
15423 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15425 * location.cs: Provide extra information.
15427 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15428 variables from the captured environment, it is the ldarg_0.
15430 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15432 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15435 * class.cs: Changed warning level for 169 to avoid developer
15436 displeasure from warning flooding. It will be changed back when they
15437 fix most of current BCL warnings.
15439 * RootContext.cs: Pushed default WarningLevel to 3.
15441 * statement.cs: Removed unused variable.
15443 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15445 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15446 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15447 Add error 502 report.
15448 (StaticClass.DefineType): Add error 441 report.
15449 (Class.AllowedModifiersProp): New virtual property as temporary
15450 extension to AllowedModifiers.
15451 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15452 to share implementation with StaticClass and don't call virtual
15455 * driver.cs (MainDriver): Add error 1558 test.
15457 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15458 report. Moved error 36 test here.
15460 * statement.cs (Throw.Resolve): Add error 724 report.
15462 * typemanager.cs: Add out_attribute_type core type.
15464 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15466 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15468 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15470 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15473 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15475 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15476 Add error 3023 report.
15477 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15479 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15482 2004-12-12 John Luke <john.luke@gmail.com>
15484 * driver.cs (AddArgs): take -- into account when
15485 adding arguments, fixes bug 65710
15487 2004-12-12 Martin Baulig <martin@ximian.com>
15489 * expression.cs (Unary.TryReduceNegative): Added support for
15490 SByteConstant and ByteConstant.
15491 (Unary.Reduce): Check error values from TryReduceNegative().
15493 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15495 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15496 and report exception as error 182.
15498 2004-12-10 Raja R Harinath <rharinath@novell.com>
15500 * driver.cs (Main): Fix message when there are warnings.
15502 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15504 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15506 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15508 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15509 Reduced number of warnings.
15511 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15513 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15515 * driver.cs: Removed message.
15517 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15519 2004-12-08 <vargaz@freemail.hu>
15521 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15523 2004-12-08 Martin Baulig <martin@ximian.com>
15525 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15526 instead of a CS3002 for properties and indexer.
15528 2004-12-08 Martin Baulig <martin@ximian.com>
15530 * decl.cs (MemberName.ToString): Make this work again.
15532 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15534 * attribute.cs (Resolve): Add error 591 detection.
15536 * class.cs (FieldMember.Define): Add error 1547 detection.
15537 (Indexer.Define): Add error 620 detection.
15538 (Operator.Define): Add error 590 detection.
15540 * ecore.cs: Missing argument for error 79.
15542 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15545 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15548 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15551 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15553 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15554 Some operator comments were suppressed.
15555 * doc.cs : Implicit/explicit operator name in doc comments are like
15556 "op_Explicit(type)~returnType", so added suffix handling.
15558 2004-12-07 Martin Baulig <martin@ximian.com>
15561 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15562 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15563 (DeclSpace.ec): New protected field; store the EmitContext here.
15564 (DeclSpace.EmitContext): New public property; moved here from
15566 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15569 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15570 (Enum.Emit): Don't create a new EmitContext.
15572 * delegate.cs (Delegate.DefineType): Always create the
15575 * iterators.cs (Iterators.DefineIterator): Create a new
15576 EmitContext and store it in `ec'.
15578 2004-08-24 Martin Baulig <martin@ximian.com>
15581 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15582 this for accessibility checks.
15583 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15584 IsNestedFamilyAccessible.
15585 (TypeManager.IsSubclassOf): New method, do what the name actually
15588 2004-12-06 Raja R Harinath <rharinath@novell.com>
15590 Fix crash on cs0657-17.cs.
15591 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15592 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15593 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15594 the case where the NamespaceEntry gets overwritten.
15596 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15598 Fixed #69195, #56821
15599 * ecore.cs (ResolveBoolean): Tiny refactoring.
15601 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15602 of right expression resolving when left is false constant and
15603 operator is LogicalAnd OR true constant and operator is LogicalOr.
15605 * statement.cs (ResolveUnreachable): Always reports warning.
15607 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15609 * class.cs: Distinguish between 1721 and 1722 (just a little help
15610 for the programmer).
15612 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15614 * delegate.cs: Only allow this on new versions of the language.
15616 2004-12-02 Duncan Mak <duncan@ximian.com>
15618 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15620 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15621 here as a static method. Take an additional bool out parameter
15622 `must_do_cs1540_check' for signaling to InstanceResolve.
15623 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15624 member field from PropertyExpr class and made it an argument of
15625 the method instead.
15626 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15627 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15628 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15629 and `remove_accessor' as well as InstanceResolve: report CS0122
15634 2004-12-03 Raja R Harinath <rharinath@novell.com>
15636 Fix test-327.cs, test-328.cs, and put in early infrastructure
15637 for eventually fixing #52697.
15638 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15639 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15640 from other methods.
15641 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15642 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15643 (VerifyUsing, error246): Update.
15644 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15645 'NamespaceEntry.LookupNamespaceOrType'.
15647 2004-12-03 Martin Baulig <martin@ximian.com>
15649 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15650 method as our child, call AnonymousMethod.Compatible() on it.
15652 2004-12-03 Raja R Harinath <rharinath@novell.com>
15654 Disable XML documentation support in 'basic' profile.
15655 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15656 Redirect XmlElement to System.Object.
15657 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15658 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15659 * mcs.exe.sources: Add doc-bootstrap.cs.
15660 * doc-bootstrap.cs: New file. Contains empty stub implementation
15663 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15665 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15666 comments are allowed.
15668 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15670 * delegate.cs: Add checks for subtypes in paramaters and return values
15671 in VerifyMethod () to add support for Covariance/Contravariance
15674 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15676 * report.cs: Remove extra closing parenthesis.
15678 * convert.cs (Error_CannotImplicitConversion): If the name of the
15679 types are the same, provide some extra information.
15681 * class.cs (FieldBase): Use an unused bit field from the field to
15682 encode the `has_offset' property from the FieldMember. This saves
15683 a couple of Ks on bootstrap compilation.
15685 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15686 method as our child, return the AnonymousMethod resolved
15689 * expression.cs (New.DoResolve): Allow return values from
15690 NewDelegate to also include AnonymousMethods.
15694 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15697 * attribute.cs (Resolve): Improved implementation of params
15698 attribute arguments.
15700 * support.cs (ParameterData): Add HasParams to be faster.
15702 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15704 all things are for /doc support:
15706 * doc.cs: new file that supports XML documentation generation.
15707 * mcs.exe.sources: added doc.cs.
15709 Handle /doc command line option.
15710 Report error 2006 instead of 5 for missing file name for /doc.
15711 Generate XML documentation when required, after type resolution.
15713 Added support for picking up documentation (/// and /** ... */),
15714 including a new XmlCommentState enumeration.
15716 Added lines to fill Documentation element for field, constant,
15717 property, indexer, method, constructor, destructor, operator, event
15718 and class, struct, interface, delegate, enum.
15719 Added lines to warn incorrect comment.
15721 Added Documentation field (passed only when /doc was specified).
15723 Added DocComment, DocCommentHeader, GenerateDocComment() and
15724 OnGenerateDocComment() and some supporting private members for
15725 /doc feature to MemberCore.
15727 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15729 Added overriden DocCommentHeader.
15731 Added overriden DocCommentHeader and GenerateDocComment().
15733 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15735 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15736 unwrapping the enumeration values, chain to
15737 DoConstantNumericPromotions again, so we can promote things to the
15738 fundamental types (takes care of enums that are bytes, sbytes).
15742 2004-12-01 Raja R Harinath <rharinath@novell.com>
15744 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15745 Fix long-standing bug in type-lookup. Use FindType instead of
15746 LookupType when ec.ResolvingTypeTree.
15747 (Attribute.ResolveType, Attribute.Resolve)
15748 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15750 (Attributes.Search): Remove internal version. Update.
15751 (Attributes.SearchMulti): Update.
15752 (Attributes.GetClsCompliantAttribute): Remove.
15753 (Attributes.GetIndexerNameAttribute): Remove.
15754 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15755 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15756 * class.cs (Indexer.Define): Likewise.
15758 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15761 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15762 MarshallByReference members access.
15764 * expression.cs: Use CheckMarshallByRefAccess;
15765 Better error CS0197 message.
15767 * report.cs: Print whole related error message.
15769 2004-11-30 Raja R Harinath <rharinath@novell.com>
15771 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15772 the current directory to help debugging.
15774 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15776 * class (GetClassBases): Better error 60 report.
15777 (EventProperty): Disabled warning 67 detection.
15779 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15782 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15784 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15787 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15790 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15792 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15794 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15796 * attribute.cs (Attribute.Resolve): Refine error reporting and
15797 report a cs0117 if the identifier does not exist, to distinguish
15798 from 0617 which is a miss-use of the actual identifier.
15800 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15801 between cs0070 and cs0079.
15803 * class.cs (MemberBase.DoDefine): When reporting a wrong
15804 accessibility level, we use MethodCore to compare instead of
15805 Method (this was a regression in some refactoring effort).
15807 So now we correctly report cs0056 again.
15809 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
15810 testing the target_type (which was known to be object_type) and
15811 not the source type (which is anonymous_method).
15813 Fixed reporting of error cs1660.
15815 * expression.cs (UserCast.Source): Expose the underlying cast.
15817 * statement.cs (Switch.SwitchGoverningType): Sort the list of
15818 allowed types to find a match to int32 first (most common).
15820 In addition, it ignores any ImplicitUserConversions that did an
15821 internal implicit conversion (as the switch statement allows only
15822 one integral conversion to exist).
15824 * class.cs (PartialContainer.Create): rename `name' to
15825 `member_name' for clarity. Then replace the string calls with a
15826 call to MemberName.GetPartialName, as now using
15827 MemberName.ToString is an error (this is due to the side effects
15828 it had, that were fixed in the past).
15830 This will restore the error reporting on a number of partial class
15831 errors that were missusing this (and getting an exception as a
15832 results, which is now just a plain textual warning, because
15833 yyparse debug output would crash otherwise).
15835 2004-11-26 Raja R Harinath <rharinath@novell.com>
15837 * Makefile (PROGRAM_INSTALL_DIR): Remove.
15839 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15841 * rootcontext.cs (LookupType): Make sure to cache lookups that
15842 don't give us a negative result. This saves about 5% of corlib
15845 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15847 * report.cs (AbstractMessage.Print): messages are sent to stderr
15849 * class.cs (TypeContainer.GetClassBases): It is an error to have a
15850 non-interface in the list of interfaces (at this point, either
15851 parent was properly set, or a base class is being listed in the
15852 interfaces section).
15854 This flags error 1722, and resolves the crash from bug 69259.
15856 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15858 * statement.cs (Using.EmitExpressionFinally): make this work right
15859 for valuetypes. Fixes 69926.
15861 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15863 * const.cs (Const.ChangeType): Cope with the "0 literal can be
15864 converted to an enum" here, before we try to change the underlying
15865 type. This code exists, but it is a different code path than the
15866 one used while encoding constants.
15868 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
15869 old bug: when converting from the null literal to a pointer,
15870 return an EmptyCast, not the NullLiteral.
15872 This fixes #69921, the recent null_type changes probably made this
15873 bug more prominent.
15875 (ImplicitReferenceConversionExists): In addition, resynchronized
15876 the code here, so it matches the same code in
15877 ImplicitReferenceConversionExists for the `from any class-type S
15878 to any interface-type T'.
15881 2004-11-25 Marek Safar <marek.safar@seznam.cz>
15883 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
15885 2004-11-24 Miguel de Icaza <miguel@ximian.com>
15887 * cs-parser.jay: Use verbosity accordingly.
15889 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15891 * expression.cs (Unary.ResolveOperator): Do not report warning;
15892 AddressOf reads from variable.
15894 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
15896 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15900 * attribute.cs (Attributable): Removed CheckTargets.
15901 (Attributes.Emit): Explicit attribute targets are tested here.
15903 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
15904 not enabled for interfaces.
15906 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
15907 (GetAssemblyName): Ouch next bug there.
15909 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15911 * expression.cs: Error 275 added.
15913 2004-11-23 Marek Safar <marek.safar@seznam.cz>
15915 Fix bug #69177 (Implemented decimal constant support)
15917 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
15918 (BinaryFold): Add DecimalConstant.
15920 * const.cs (Define): Decimal constant
15922 (ChangeType): Add decimal type handling.
15923 (LookupConstantValue): Don't set value for decimal type but
15924 emit DecimalConstantAttribute. Needed for constant optimization.
15926 * constant.cs (ToDecimal): New method.
15927 (ConvertToDecimal): New method.
15928 (IntConstant): Implemented ConvertToDecimal.
15929 (DecimalConstant.Emit): Emit optimized version for decimals in
15932 * expression.cs (ResolveOperator): Changed order of constant
15933 reduction to work correctly with native types which have
15934 overloaded operators.
15935 (ResolveMemberAccess): Extract constant value from attribute
15938 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
15940 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
15941 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
15942 (ChangeType): Decimal is special.
15943 (TypeToCoreType): Add decimal type.
15945 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15947 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
15950 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15952 * class.cs (EventField.ApplyAttributeBuilder): Fix error
15955 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15957 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
15959 * pending.cs (PendingImplementation): Grab only interfaces.
15961 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15963 * statement.cs (ForeachHelperMethods): Add location member and
15964 error 202 detection.
15966 2004-11-19 Raja R Harinath <rharinath@novell.com>
15968 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
15969 automatically handled by executable.make.
15970 (PROGRAM): Make profile-specific.
15972 2004-11-18 Marek Safar <marek.safar@seznam.cz>
15974 * expression.cs (DoResolveBase): Fixed wrong warning for out
15977 2004-11-18 Martin Baulig <martin@ximian.com>
15979 Merged latest changes into gmcs. Please keep this comment in
15980 here, it makes it easier for me to see what changed in MCS since
15981 the last time I merged.
15983 2004-11-17 Raja R Harinath <rharinath@novell.com>
15985 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
15986 (TypeHandle.GetMemberCache): New.
15987 (TypeHandle.TypeHandle): Update.
15988 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
15989 (TypeManager.LookupParentInterfacesCache):
15990 Rename from LookupInterfaceCache. Optimize slightly.
15991 (TypeManager.MemberLookup_FindMembers): Update.
15992 * decl.cs (MemberCache.MemberCache): Set Container to null in the
15993 multi-type variant.
15994 (AddCacheContents): Rename from AddHashtable.
15995 * class.cs (TypeContainer.parent_container): Remove.
15996 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
15997 (TypeContainer.DoDefineMembers): Don't initialize it.
15998 Update to name changes.
16000 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16002 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16003 that factors the code to check access modifiers on override.
16005 (PropertyBase): Use the code here.
16007 Patch from Lluis S'anchez, fixes bug #69361.
16009 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16011 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16012 routine that is used to report the use of a captured variable
16013 whose address has been taken.
16015 There are two checks: one when variables are being captured and
16016 the other check is when the address of a variable is taken.
16018 (because an anonymous methods might be resolved before *or* after
16019 the address has been taken) and
16021 * expression.cs (Conditional.DoResolve): Remove the special
16022 casing that Martin added to trueExpr and falseExpr being both
16023 NullLiteral. We get the right behavior now just by introducing
16024 the null_type into the compiler.
16026 * convert.cs (ExplicitConversion): Change the code to use
16027 null_type instead of testing `expr is NullLiteral'.
16028 (ImplicitConversionStandard): use null_type too.
16029 (ImplicitReferenceConversionExists): use null_type too.
16030 (ImplicitReferenceConversion): use null_type too.
16032 * literal.cs: The type of `NullLiteral' is now null_type instead
16034 (Resolve): Set the type here.
16036 * typemanager.cs: Introduce null_type.
16038 2004-11-17 Martin Baulig <martin@ximian.com>
16040 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16041 direction, like FindMembers() does. Fixes #69546, testcase is in
16044 2004-11-16 Martin Baulig <martin@ximian.com>
16046 This is based on a patch from Marek Safar, see bug #69082.
16047 Fixes bugs #63705 and #67130.
16049 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16050 method; create a MemberCache for an interface type and cache the
16053 * decl.cs (IMemberContainer.ParentContainer): Removed.
16054 (IMemberContainer.ParentCache): New property.
16055 (MemberCache.SetupCacheForInterface): Removed.
16056 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16057 to create a cache for an interface's "parent".
16059 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16062 2004-11-16 Martin Baulig <martin@ximian.com>
16064 Merged back from gmcs; these changes already went into gmcs a
16065 couple of weeks ago.
16068 (TypeManager.AddUserType): Removed the `ifaces' argument.
16069 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16071 (TypeManager.AddUserInterface): Removed.
16072 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16074 (TypeManager.GetInterfaces): Likewise.
16075 (TypeManager.GetExplicitInterfaces): Likewise.
16077 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16079 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16080 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16082 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16084 * statement.cs: Avoid adding bools to a hashtable.
16086 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16088 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16089 calling an unsafe method from a safe location.
16091 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16094 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16096 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16098 * namespace.cs (VerifyUsing): use GetPartialName instead of
16101 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16103 * statement.cs (Return.Resolve): Fix regression in typo: if
16104 `in_exc', we have to request a NeedReturnLabel, this was a typo
16105 introduced in the anonymous method check-in. Fixes #69131.
16107 * Indexers were using the ShortName when defining themselves,
16108 causing a regression in the compiler bootstrap when applying the
16109 patch from 2004-11-02 (first part), now they use their full name
16110 and the bug is gone.
16112 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16114 * driver.cs: Strip the path from the names of embedded resources. Fixes
16117 2004-11-04 Raja R Harinath <rharinath@novell.com>
16119 Fix error message regression: cs0104-2.cs.
16120 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16121 (AliasEntry.Resolve): Update.
16122 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16124 (RootContext.LookupType): Update.
16126 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16128 * cs-parser.jay: Add support for handling accessor modifiers
16129 * class: Add support port accessor modifiers and error checking,
16130 define PropertyMethod.Define as virtual (not abstract anymore)
16131 * ecore.cs: Add checking for proeprties access with access modifiers
16132 * iterators.cs: Modify Accessor constructor call based in the modified
16134 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16136 * expression.cs (StringConcat): Handle being called twice,
16137 as when we have a concat in a field init with more than two
16140 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16142 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16143 special case explicit implementations, we should always produce
16144 the .property or .event declaration.
16146 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16147 since it will not return correct data if people use this
16148 unresolved in the presence of using statements (see test-313).
16150 * class.cs (MethodData.Define): If we are an explicit interface
16151 implementation, set the method name to the full name of the
16152 interface plus the name of the method.
16154 Notice that using the method.MethodName.GetFullName() does not
16155 work, as it will only contain the name as declared on the source
16156 file (it can be a shorthand in the presence of using statements)
16157 and not the fully qualifed type name, for example:
16161 class D : ICloneable {
16162 object ICloneable.Clone () {
16166 Would produce a method called `ICloneable.Clone' instead of
16167 `System.ICloneable.Clone'.
16169 * namespace.cs (Alias.Resolve): Use GetPartialName.
16171 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16173 * cs-parser.jay: Add error 1055 report.
16175 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16177 * assign.cs (Assign.DoResolve): Only do the transform of
16178 assignment into a New if the types are compatible, if not, fall
16179 through and let the implicit code deal with the errors and with
16180 the necessary conversions.
16182 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16184 * cs-parser.jay: Add error 1031 report.
16186 * cs-tokenizer.cs: Add location for error 1038.
16188 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16190 * cs-parser.jay: Add error 1016 report.
16192 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16194 * cs-parser.jay: Add errors 1575,1611 report.
16196 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16198 * cs-parser.jay: Add error 1001 report.
16200 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16203 * attribute.cs (GetMarshal): Add method argument for
16204 caller identification.
16206 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16207 agument for GetMarshal and RuntimeMissingSupport.
16209 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16211 * attribute.cs (ExtractSecurityPermissionSet): Removed
16212 TypeManager.code_access_permission_type.
16214 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16216 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16218 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16219 for obsolete use of a variable here. Fixes regression on errors
16220 cs0619-25 and cs0619-26.
16222 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16224 Fix #62358, implemented security attribute encoding.
16226 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16227 Tests permitted SecurityAction for assembly or other types.
16228 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16229 data from SecurityPermissionAttribute to PermisionSet class.
16231 * class.cs (ApplyAttributeBuilder): Added special handling
16232 for System.Security.Permissions.SecurityAttribute based types.
16234 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16235 special handling for System.Security.Permissions.SecurityAttribute
16238 * enum.cs (ApplyAttributeBuilder): Added special handling
16239 for System.Security.Permissions.SecurityAttribute based types.
16241 * parameter.cs (ApplyAttributeBuilder): Added special handling
16242 for System.Security.Permissions.SecurityAttribute based types.
16244 * rootcontext.cs: Next 2 core types.
16246 * typemanager.cs (TypeManager.security_permission_attr_type):
16247 Built in type for the SecurityPermission Attribute.
16248 (code_access_permission_type): Build in type.
16250 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16252 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16253 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16254 all of this information into
16255 EmitContext.EmitCapturedVariableInstance.
16257 * codegen.cs (EmitCapturedVariableInstance): move here the
16258 funcionality of emitting an ldarg.0 in the presence of a
16259 remapping. This centralizes the instance emit code.
16261 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16262 then emit a load of this: it means that we have reached the
16263 topmost ScopeInfo: the one that contains the pointer to the
16264 instance of the class hosting the anonymous method.
16266 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16267 captures to the topmost CaptureContext.
16269 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16271 * expression.cs (LocalVariableReference): Move the knowledge about
16272 the iterators into codegen's EmitCapturedVariableInstance.
16274 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16276 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16277 all code paths return a value from an anonymous method (it is the
16278 same as the 161 error, but for anonymous methods).
16280 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16282 The introduction of anonymous methods in the compiler changed
16283 various ways of doing things in the compiler. The most
16284 significant one is the hard split between the resolution phase
16285 and the emission phases of the compiler.
16287 For instance, routines that referenced local variables no
16288 longer can safely create temporary variables during the
16289 resolution phase: they must do so from the emission phase,
16290 since the variable might have been "captured", hence access to
16291 it can not be done with the local-variable operations from the runtime.
16295 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16296 is a toplevel block.
16298 (ToplevelBlock): A new kind of Block, these are the blocks that
16299 are created by the parser for all toplevel method bodies. These
16300 include methods, accessors and anonymous methods.
16302 These contain some extra information not found in regular blocks:
16303 A pointer to an optional CaptureContext (for tracking captured
16304 local variables and parameters). A pointer to the parent
16307 (Return.Resolve): Catch missmatches when returning a value from an
16308 anonymous method (error 1662).
16309 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16312 (Break.Resolve): ditto.
16314 (SwitchLabel): instead of defining the labels during the
16315 resolution phase, we now turned the public ILLabel and ILLabelCode
16316 labels into methods called GetILLabelCode() and GetILLabel() that
16317 only define the label during the Emit phase.
16319 (GotoCase): Track the SwitchLabel instead of the computed label
16320 (its contained therein). Emit the code by using
16321 SwitchLabel.GetILLabelCode ().
16323 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16324 whether the Local has been captured or not.
16326 (LocalInfo.IsCaptured): New property, used to tell whether the
16327 local has been captured.
16329 * anonymous.cs: Vastly updated to contain the anonymous method
16332 The main classes here are: CaptureContext which tracks any
16333 captured information for a toplevel block and ScopeInfo used to
16334 track the activation frames for various local variables.
16336 Each toplevel block has an optional capture context associated
16337 with it. When a method contains an anonymous method both the
16338 toplevel method and the anonymous method will create a capture
16339 context. When variables or parameters are captured, they are
16340 recorded on the CaptureContext that owns them, for example:
16344 MyDelegate d = delegate {
16349 Here `a' will be recorded as captured on the toplevel
16350 CapturedContext, the inner captured context will not have anything
16351 (it will only have data if local variables or parameters from it
16352 are captured in a nested anonymous method.
16354 The ScopeInfo is used to track the activation frames for local
16355 variables, for example:
16357 for (int i = 0; i < 10; i++)
16358 for (int j = 0; j < 10; j++){
16359 MyDelegate d = delegate {
16364 At runtime this captures a single captured variable `i', but it
16365 captures 10 different versions of the variable `j'. The variable
16366 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16367 recorded on a child.
16369 The toplevel ScopeInfo will also track information like the `this'
16370 pointer if instance variables were referenced (this is necessary
16371 as the anonymous method lives inside a nested class in the host
16372 type of the method).
16374 (AnonymousMethod): Expanded to track the Toplevel, implement
16375 `AnonymousMethod.Compatible' to tell whether an anonymous method
16376 can be converted to a target delegate type.
16378 The routine now also produces the anonymous method content
16380 (AnonymousDelegate): A helper class that derives from
16381 DelegateCreation, this is used to generate the code necessary to
16382 produce the delegate for the anonymous method that was created.
16384 * assign.cs: API adjustments for new changes in
16385 Convert.ImplicitStandardConversionExists.
16387 * class.cs: Adjustments to cope with the fact that now toplevel
16388 blocks are of type `ToplevelBlock'.
16390 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16391 insteda of standard blocks.
16393 Flag errors if params arguments are passed to anonymous methods.
16395 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16396 `CurrentAnonymousMethod' which points to the current Anonymous
16397 Method. The variable points to the AnonymousMethod class that
16398 holds the code being compiled. It is set in the new EmitContext
16399 created for the anonymous method.
16401 (EmitContext.Phase): Introduce a variable and an enumeration to
16402 assist in enforcing some rules about when and where we are allowed
16403 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16404 only one that enfonces this right now).
16406 (EmitContext.HaveCaptureInfo): new helper method that returns
16407 whether we have a CapturedContext initialized.
16409 (EmitContext.CaptureVariable): New method used to register that a
16410 LocalInfo must be flagged for capturing.
16412 (EmitContext.CapturedParameter): New method used to register that a
16413 parameters must be flagged for capturing.
16415 (EmitContext.CapturedField): New method used to register that a
16416 field must be flagged for capturing.
16418 (EmitContext.HaveCapturedVariables,
16419 EmitContext.HaveCapturedFields): Return whether there are captured
16420 variables or fields.
16422 (EmitContext.EmitMethodHostInstance): This is used to emit the
16423 instance for the anonymous method. The instance might be null
16424 (static methods), this (for anonymous methods that capture nothing
16425 and happen to live side-by-side with the current method body) or a
16426 more complicated expression if the method has a CaptureContext.
16428 (EmitContext.EmitTopBlock): Routine that drives the emission of
16429 code: it will first resolve the top block, then emit any metadata
16430 and then emit the code. The split is done so that we can extract
16431 any anonymous methods and flag any captured variables/parameters.
16433 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16434 during this phase, the ILGenerator should not be used as labels
16435 and local variables declared here might not be accessible to any
16436 code that is part of an anonymous method.
16438 Exceptions to this include the temporary variables that are
16439 created by some statements internally for holding temporary
16442 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16445 (EmitContext.TemporaryReturn): This method is typically called
16446 from the Emit phase, and its the only place where we allow the
16447 ReturnLabel to be defined other than the EmitMeta. The reason is
16448 that otherwise we would have to duplicate a lot of logic in the
16449 Resolve phases of various methods that today is on the Emit
16452 (EmitContext.NeedReturnLabel): This no longer creates the label,
16453 as the ILGenerator is not valid during the resolve phase.
16455 (EmitContext.EmitThis): Extended the knowledge in this class to
16456 work in anonymous methods in addition to iterators.
16458 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16459 code is necessary on the stack to access the instance to a local
16460 variable (the variable will be accessed as a field).
16462 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16463 EmitContext.EmitAddressOfParameter): Routines to support
16464 parameters (not completed at this point).
16466 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16467 will also remove the parameters.
16469 * convert.cs (Convert): Define a `ConstantEC' which points to a
16470 null. This is just to prefity some code that uses
16471 ImplicitStandardConversion code and do not have an EmitContext
16474 The idea is to flag explicitly that at that point in time, it is
16475 known that the conversion will not trigger the delegate checking
16476 code in implicit conversions (which requires a valid
16479 Everywhere: pass new EmitContext parameter since
16480 ImplicitStandardConversionExists now requires it to check for
16481 anonymous method conversions.
16483 (Convert.ImplicitStandardConversionExists): If the type of an
16484 expression is the anonymous_method_type, and the type is a
16485 delegate, we invoke the AnonymousMethod.Compatible method to check
16486 whether an implicit conversion is possible.
16488 (Convert.ImplicitConversionStandard): Only do implicit method
16489 group conversions if the language level is not ISO_1.
16491 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16492 MethodInfo for the Invoke method. used by Delegate and
16495 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16496 method conversions if the target type is a delegate.
16498 Removed extra debugging nops.
16500 (LocalVariableReference): Turn the `local_info' into a public
16503 Add `prepared' field, the same hack used for FieldExprs to cope
16504 with composed assignments, as Local variables do not necessarily
16505 operate purely on the stack as they used to: they can be captured
16508 Add `temp' for a temporary result, like fields.
16510 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16512 It now copes with Local variables that are captured and emits the
16513 proper instance variable to load it from a field in the captured
16516 (ParameterReference.DoResolveBase): During the resolve phase,
16517 capture parameters if we are in an anonymous method.
16519 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16520 anonymous method, use the EmitContext helper routines to emit the
16521 parameter reference.
16523 * iterators.cs: Set RemapToProxy to true/false during the
16526 * parameters.cs (GetParameterByName): New helper method.
16528 * typemanager.cs (anonymous_method_type) a new type that
16529 represents an anonyous method. This is always an internal type,
16530 used as a fencepost to test against the anonymous-methodness of an
16533 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16535 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16537 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16539 2004-10-18 Martin Baulig <martin@ximian.com>
16541 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16542 `Type' directly, but call ResolveType() on it.
16543 (Catch.Resolve): Likewise.
16544 (Foreach.Resolve): Likewise.
16546 2004-10-18 Martin Baulig <martin@ximian.com>
16548 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16549 `Type' directly, but call ResolveType() on it.
16550 (Probe.DoResolve): Likewise.
16551 (ArrayCreation.LookupType): Likewise.
16552 (TypeOf.DoResolve): Likewise.
16553 (SizeOf.DoResolve): Likewise.
16555 2004-10-18 Martin Baulig <martin@ximian.com>
16557 * expression.cs (Invocation.BetterFunction): Put back
16558 TypeManager.TypeToCoreType().
16560 2004-10-18 Raja R Harinath <rharinath@novell.com>
16562 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16565 2004-10-18 Martin Baulig <martin@ximian.com>
16567 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16568 `Type' directly, but call ResolveType() on it.
16570 2004-10-18 Martin Baulig <martin@ximian.com>
16572 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16573 `Type' directly, but call ResolveType() on it.
16574 (MemberBase.DoDefine): Likewise.
16576 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16577 `Type' directly, but call ResolveType() on it.
16578 (ComposedCast.DoResolveAsTypeStep): Likewise.
16580 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16581 `Type' directly, but call ResolveType() on it.
16583 2004-10-17 John Luke <john.luke@gmail.com>
16585 * class.cs (Operator.GetSignatureForError): use CSharpName
16587 * parameter.cs (Parameter.GetSignatureForError): Returns
16588 correct name even if was not defined.
16590 2004-10-13 Raja R Harinath <rharinath@novell.com>
16593 * class.cs (TypeContainer.EmitContext): New property.
16594 (DefineNestedTypes): Create an emitcontext for each part.
16595 (MethodCore.DoDefineParameters): Use container's emitcontext.
16596 Pass type array to InternalParameters.
16597 (MemberBase.DoDefine): Use container's emitcontext.
16598 (FieldMember.Define): Likewise.
16599 (Event.Define): Likewise.
16600 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16601 Pass type array to InternalParameters.
16602 (SetIndexerMethod.GetParameterInfo): Likewise.
16603 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16604 * delegate.cs (Define): Pass emitcontext to
16605 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16606 array to InternalParameters.
16607 * expression.cs (ParameterReference.DoResolveBase): Pass
16608 emitcontext to GetParameterInfo.
16609 (ComposedCast.DoResolveAsTypeStep): Remove check on
16610 ec.ResolvingTypeTree.
16611 * parameter.cs (Parameter.Resolve): Change argument to
16612 EmitContext. Use ResolveAsTypeTerminal.
16613 (Parameter.GetSignature): Change argument to EmitContext.
16614 (Parameters.ComputeSignature): Likewise.
16615 (Parameters.ComputeParameterTypes): Likewise.
16616 (Parameters.GetParameterInfo): Likewise.
16617 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16618 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16619 * support.cs (InternalParameters..ctor): Remove variant that takes
16621 * typemanager.cs (system_intptr_expr): New.
16622 (InitExpressionTypes): Initialize it.
16624 2004-10-12 Chris Toshok <toshok@ximian.com>
16626 * cs-parser.jay: fix location for try_statement and catch_clause.
16628 2004-10-11 Martin Baulig <martin@ximian.com>
16630 * report.cs: Don't make --fatal abort on warnings, we have
16631 -warnaserror for that.
16633 2004-10-07 Raja R Harinath <rharinath@novell.com>
16635 More DeclSpace.ResolveType avoidance.
16636 * decl.cs (MemberCore.InUnsafe): New property.
16637 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16638 with newly created EmitContext.
16639 (FieldMember.Define): Likewise.
16640 * delegate.cs (Delegate.Define): Likewise.
16641 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16642 only if normal name-lookup fails.
16643 (TypeExpr.DoResolve): Enable error-checking.
16644 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16645 (SizeOf.DoResolve): Likewise.
16646 (ComposedCast.DoResolveAsTypeStep): Likewise.
16647 (StackAlloc.DoResolve): Likewise.
16648 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16649 (Block.Unsafe): New property.
16650 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16651 (Unsafe): Set 'unsafe' flag of contained block.
16652 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16653 (Fixed.Resolve): Likewise.
16654 (Catch.Resolve): Likewise.
16655 (Using.ResolveLocalVariableDecls): Likewise.
16656 (Foreach.Resolve): Likewise.
16658 2004-10-05 John Luke <john.luke@gmail.com>
16660 * cs-parser.jay: add location to error CS0175
16662 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16664 * ecore.cs (Expression.Constantity): Add support for turning null
16667 * const.cs (Const.Define): Allow constants to be reference types
16668 as long as the value is Null.
16670 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16672 * namespace.cs (NamespaceEntry.Using): No matter which warning
16673 level is set, check if this namespace name has already been added.
16675 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16677 * expression.cs: reftype [!=]= null should always use br[true,false].
16680 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16683 * attribute.cs: Enum conversion moved to
16684 GetAttributeArgumentExpression to be applied to the all
16687 2004-10-01 Raja R Harinath <rharinath@novell.com>
16689 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16690 * class.c (TypeContainer.DefineType): Flag error if
16691 base types aren't accessible due to access permissions.
16692 * decl.cs (DeclSpace.ResolveType): Move logic to
16693 Expression.ResolveAsTypeTerminal.
16694 (DeclSpace.ResolveTypeExpr): Thin layer over
16695 Expression.ResolveAsTypeTerminal.
16696 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16697 Refactor code into NestedAccess. Use it.
16698 (DeclSpace.NestedAccess): New.
16699 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16700 argument to silence errors. Check access permissions.
16701 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16702 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16703 (Cast.DoResolve): Likewise.
16704 (New.DoResolve): Likewise.
16705 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16706 (TypeOf.DoResolve): Likewise.
16708 * expression.cs (Invocation.BetterConversion): Return the Type of
16709 the better conversion. Implement section 14.4.2.3 more faithfully.
16710 (Invocation.BetterFunction): Make boolean. Make correspondence to
16711 section 14.4.2.2 explicit.
16712 (Invocation.OverloadResolve): Update.
16713 (Invocation): Remove is_base field.
16714 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16715 (Invocation.Emit): Likewise.
16717 2004-09-27 Raja R Harinath <rharinath@novell.com>
16719 * README: Update to changes.
16721 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16723 * cs-parser.jay: Reverted 642 warning fix.
16725 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16728 * decl.cs (FindMemberWithSameName): Indexer can have more than
16731 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16733 * expression.cs (LocalVariableReference.DoResolveLValue):
16734 Do not report warning 219 for out values.
16735 (EmptyExpression.Null): New member to avoid extra allocations.
16737 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16739 * cs-parser.jay: Fix wrong warning 642 report.
16741 * cs-tokenizer.cs (CheckNextToken): New helper;
16742 Inspect next character if is same as expected.
16744 2004-09-23 Martin Baulig <martin@ximian.com>
16746 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16747 (Convert.ImplicitReferenceConversionExists): Likewise.
16749 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16751 * class.cs (Operator.Define): Add error 448 and 559 report.
16753 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16755 * class.cs (MemberBase.IsTypePermitted): New protected
16756 method for checking error CS0610.
16758 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16760 * class.cs (TypeContainer.HasExplicitLayout): New property
16761 Returns whether container has StructLayout attribute set Explicit.
16762 (FieldMember): New abstract class for consts and fields.
16763 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16764 (Field): Reuse FieldMember.
16766 * const.cs (Const): Reuse FieldMember.
16768 * rootcontext.cs: EmitConstants call moved to class.
16770 2004-09-22 Martin Baulig <martin@ximian.com>
16772 Thanks to Peter Sestoft for this bug report.
16774 * expression.cs (Conditional): If both the `trueExpr' and the
16775 `falseExpr' is a NullLiteral, return a NullLiteral.
16777 2004-09-22 Martin Baulig <martin@ximian.com>
16779 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16780 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16781 for the "get_Current" call.
16783 2004-09-22 Martin Baulig <martin@ximian.com>
16785 Marek and me just fixed one of our oldest bugs: #28562 :-)
16787 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16789 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16790 we're an EnumConstant, just return that.
16791 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16792 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16793 to get the value which'll actually be written into the attribute.
16794 However, we have to use GetValue() to access the attribute's value
16797 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16799 * constant.cs (Constant.IsNegative): New abstract property
16802 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16803 (StackAlloc.DoResolve): Reused IsNegative.
16805 2004-09-21 Martin Baulig <martin@ximian.com>
16807 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
16808 if we're used in an iterator, we may be called from different
16811 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
16812 we actually have an exception block.
16814 2004-09-20 John Luke <jluke@cfl.rr.com>
16816 * class.cs, cs-parser.jay: Improve the error report for 1520:
16817 report the actual line where the error happens, not where the
16818 class was declared.
16820 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
16821 Pass location information that was available elsewhere.
16823 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
16825 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
16826 runtime to delay sign assemblies.
16828 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16830 * cs-parser.jay: Do not report the stack trace, this is barely
16833 2004-08-22 John Luke <john.luke@gmail.com>
16835 * driver.cs : check that a resource id is not already used
16836 before adding it, report CS1508 if it is, bug #63637
16838 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16840 * ecore.cs: Removed dead code.
16842 2004-09-18 Marek Safar <marek.safar@seznam.cz>
16844 * class.cs: Do not report warning CS0067 on the interfaces.
16846 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16848 * cs-parser.jay: Add error 504 report.
16850 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16852 * rootcontext.cs: WarningLevel is 4 by default now.
16854 * statement.cs (Fixed.Resolve): Do not null
16857 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16860 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
16861 deep search when property is not virtual.
16862 (PropertyExpr.ResolveAccessors): Make one call for both
16865 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16868 * statement.cs: Error 152 report constains also location.
16870 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16873 * const.cs: Explicitly set constant as static.
16875 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16878 * cs-parser.jay: Add error 1017 report.
16880 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16882 Fixed bug #59980, #64224
16883 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
16885 * typemanager.cs (IsSpecialMethod): Simplified
16887 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16889 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
16890 condition with better params.
16892 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16895 * attribute.cs (Resolve): Property has to have both
16898 2004-09-14 Martin Baulig <martin@ximian.com>
16900 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
16902 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16905 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
16906 called and is obsolete then this member suppress message
16907 when call is inside next [Obsolete] method or type.
16909 * expression.cs: Use TestObsoleteMethodUsage member.
16911 2004-09-14 Martin Baulig <martin@ximian.com>
16913 * cs-parser.jay: Sync a bit with the GMCS version.
16915 2004-09-14 Martin Baulig <martin@ximian.com>
16917 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
16918 (CSharpParser.yacc_verbose_flag): New public field.
16920 * genericparser.cs: Removed.
16922 2004-09-14 Raja R Harinath <rharinath@novell.com>
16924 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
16926 2004-09-13 Marek Safar <marek.safar@seznam.cz>
16928 * class.cs (MethodCore.CheckBase): Fix bug #65757.
16930 2004-09-10 Martin Baulig <martin@ximian.com>
16932 Backported my MemberName changes from GMCS into MCS.
16934 - we are now using a special `MemberName' class instead of using
16935 strings; in GMCS, the `MemberName' also contains the type
16938 - changed the grammar rules a bit:
16939 * the old `member_name' is now a `namespace_or_type_name':
16940 The rule is that we use `namespace_or_type_name' everywhere
16941 where we expect either a "member name" (GetEnumerator) or a
16942 "member name" with an explicit interface name
16943 (IEnumerable.GetEnumerator).
16944 In GMCS, the explicit interface name may include type arguments
16945 (IEnumerable<T>.GetEnumerator).
16946 * we use `member_name' instead of just `IDENTIFIER' for
16948 The rule is that we use `member_name' wherever a member may
16949 have type parameters in GMCS.
16951 * decl.cs (MemberName): New public class.
16952 (MemberCore.MemberName): New public readonly field.
16953 (MemberCore.ctor): Take a `MemberName' argument, not a string.
16954 (DeclSpace): Likewise.
16956 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
16957 * enum.cs (Enum.ctor): Likewise.
16959 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
16961 (AliasEntry.ctor): Take a MemberName, not an Expression.
16962 (AliasEntry.UsingAlias): Likewise.
16964 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
16965 (IMethodData.MemberName): Changed type from string to MemberName.
16966 (MemberBase.ExplicitInterfaceName): Likewise.
16967 (AbstractPropertyEventMethod.SetupName): Make this private.
16968 (AbstractPropertyEventMethod.ctor): Added `string prefix'
16969 argument; compute the member name here.
16970 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
16971 on the `member.MemberName' and the `prefix'.
16973 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
16975 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
16976 thus, we get a `MemberName' instead of a `string'. These
16977 declarations may have type parameters in GMCS.
16978 (interface_method_declaration, delegate_declaration): Likewise.
16979 (class_declaration, interface_declaration): Likewise.
16980 (method_header): Use `namespace_or_type_name' instead of
16981 `member_name'. We may be an explicit interface implementation.
16982 (property_declaration, event_declaration): Likewise.
16983 (member_name): This is now just an `IDENTIFIER', not a
16984 `namespace_or_type_name'.
16985 (type_name, interface_type): Removed.
16986 (namespace_or_type_name): Return a MemberName, not an Expression.
16987 (primary_expression): Use `member_name' instead of `IDENTIFIER';
16988 call GetTypeExpression() on the MemberName to get an expression.
16989 (IndexerDeclaration.interface_type): Changed type from string to
16991 (MakeName): Operate on MemberName's instead of string's.
16993 2004-09-13 Raja R Harinath <rharinath@novell.com>
16996 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
16997 (NamespaceEntry.Lookup): Add new argument to flag if we want the
16998 lookup to avoid symbols introduced by 'using'.
16999 * rootcontext.cs (NamespaceLookup): Update.
17001 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17003 * class.cs (TypeContainer.DoDefineMembers): Do not call
17004 DefineDefaultConstructor for static classes.
17006 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17008 * attribute.cs (Attribute.Resolve): Add error 653 report.
17010 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17012 (Method.ApplyAttributeBuilder): Add error 685 report.
17013 (Operator.Define): Add error 564 report.
17015 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17017 * expression.cs (Invocation.DoResolve): Add error
17018 245 and 250 report.
17020 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17023 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17025 * class.cs (ConstructorInitializer.Resolve):
17026 Wrong error number (515->516).
17028 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17030 * class.cs (Indexer.Define): Add error 631 report.
17032 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17034 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17036 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17038 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17040 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17042 * cs-parser.jay: Added error CS0241 report.
17044 2004-09-10 Raja R Harinath <rharinath@novell.com>
17046 * cs-parser.jay (fixed_statement): Introduce a scope for the
17047 declaration in the 'fixed' statement.
17049 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17051 * cs-parser.jay: Added CS0230 error report.
17053 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17055 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17057 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17059 * expression.cs (Argument.Resolve): Added error CS0192 and
17062 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17064 C# 2.0 #pragma warning feature
17066 * cs-tokenizer.cs (PreProcessPragma): New method;
17067 Handles #pragma directive.
17069 * report.cs (WarningRegions): New class; Support
17070 class for #pragma warning directive. It tests whether
17071 warning is enabled for a given line.
17073 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17075 * const.cs: Add more descriptive error report, tahnks to
17078 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17080 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17082 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17084 * expression.cs: Apply patch from Ben: Remove dead code from
17085 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17086 as that code just threw an exception anwyays.
17088 * const.cs: Remove the call to the turnintoconstant, for details
17091 * literal.cs: The type of the null-literal is the null type; So
17092 we use a placeholder type (literal.cs:System.Null, defined here)
17095 * expression.cs (Conditional.DoResolve): Remove some old code that
17096 is no longer needed, conversions have been fixed.
17098 (ArrayCreationExpression.DoResolve): Return false if we fail to
17099 resolve the inner expression.
17101 2004-09-07 Raja R Harinath <rharinath@novell.com>
17104 * cs-parser.jay (delegate_declaration): Record a delegate
17105 declaration as a type declaration.
17106 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17108 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17110 * parameter.cs: Do not crash if the type can not be resolved.
17112 * expression.cs: Report errors with unsafe pointers, fixes #64896
17114 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17116 * expression.cs: Pointer arith always needs to do a conv.i
17117 if the operand is a long. fix 65320
17119 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17121 Fixed cs0619-37.cs, cs0619-38.cs
17123 * enum.cs (GetObsoleteAttribute): Removed.
17125 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17126 on Enum member is double staged. The first is tested member
17129 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17131 Fixed #56986, #63631, #65231
17133 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17134 adds member to name container.
17135 (TypeContainer.AddToTypeContainer): New method, adds type to
17137 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17138 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17139 AddOperator): Simplified by reusing AddToMemberContainer.
17140 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17142 (Method.CheckForDuplications): Fixed implementation to test all
17144 (MemberBase): Detection whether member is explicit interface
17145 implementation is now in constructor.
17146 (MemberBase.UpdateMemberName): Handles IndexerName.
17147 (Accessor): Changed to keep also location information.
17148 (AbstractPropertyEventMethod): Is derived from MemberCore.
17149 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17150 will be emited or not.
17151 (PropertyBase.AreAccessorsDuplicateImplementation):
17152 Tests whether accessors are not in collision with some method.
17153 (Operator): Is derived from MethodCore to simplify common
17156 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17158 (DeclSpace.AddToContainer): Adds the member to defined_names
17159 table. It tests for duplications and enclosing name conflicts.
17161 * enum.cs (EnumMember): Clean up to reuse the base structures
17163 2004-09-03 Martin Baulig <martin@ximian.com>
17165 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17166 into TypeContainer, to make partial classes work again.
17168 2004-09-03 Martin Baulig <martin@ximian.com>
17170 * rootcontext.cs (RootContext.V2): Removed.
17172 2004-03-23 Martin Baulig <martin@ximian.com>
17174 * expression.cs (Invocation.OverloadResolve): Added `bool
17175 may_fail' argument and use it instead of the Location.IsNull() hack.
17177 2004-09-03 Martin Baulig <martin@ximian.com>
17179 Merged latest changes into gmcs. Please keep this comment in
17180 here, it makes it easier for me to see what changed in MCS since
17181 the last time I merged.
17183 2004-09-03 Raja R Harinath <rharinath@novell.com>
17186 * expression.cs (BetterConversion): Don't allow either conversion
17187 to be null. Remove redundant implicit conversion test when 'q ==
17188 null' -- when this function is invoked, we already know that the
17189 implicit conversion exists.
17190 (BetterFunction): Assume that 'best' is non-null. Remove
17191 redundant reimplementation of IsApplicable when 'best' is null.
17192 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17193 number of arguments.
17194 (IsAncestralType): Extract from OverloadResolve.
17195 (OverloadResolve): Make robust to the MethodGroupExpr being
17196 unsorted. Implement all the logic of Section 14.5.5.1, and
17197 support overloading of methods from multiple applicable types.
17198 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17200 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17201 (RealError, Warning): Append type of report to related symbol.
17203 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17205 * enum.cs: Fixed CLS-Compliance checks for enum members.
17206 Error tests cs3008-8.cs, cs3014-8.cs
17208 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17210 Fixed bug #62342, #63102
17211 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17212 like ImplementMethod.
17214 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17216 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17219 2004-09-02 Martin Baulig <martin@ximian.com>
17221 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17222 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17225 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17227 C# 2.0 Static classes implemented
17229 * class.cs (TypeContainer): instance_constructors,
17230 initialized_fields, initialized_static_fields,
17231 default_constructor, base_inteface_types are protected to be
17232 accessible from StaticClass.
17233 (TypeContainer.DefineDefaultConstructor): New virtual method
17234 for custom default constructor generating
17235 (StaticClass): New class to handle "Static classes" feature.
17237 * cs-parser.jay: Handle static keyword on class like instance
17240 * driver.cs: Added "/langversion" command line switch with two
17241 options (iso-1, default).
17243 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17245 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17247 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17249 * delegate.cs: Style.
17251 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17253 * delegate.cs: Add seperate instance expr field for miguel.
17255 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17257 * PointerArithmetic (Resolve): make sure we are not doing
17258 pointer arith on void*. Also, make sure we are resolved
17259 by not setting eclass until resolve.
17261 All callers: Make sure that PointerArithmetic gets resolved.
17263 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17265 * ArrayCreation (LookupType): If the type does not resolve
17266 to an array, give an error.
17268 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17270 * statement.cs (Try.Resolve): Fixed bug #64222
17272 2004-08-27 Martin Baulig <martin@ximian.com>
17275 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17278 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17280 * ecore.cs (Constantify): Get underlying type via
17281 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17282 Windows in special cases.
17284 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17286 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17287 for obtaining also private methods.
17288 (GetRemoveMethod): Used GetRemoveMethod (true)
17289 for obtaining also private methods.
17291 2004-08-24 Martin Baulig <martin@ximian.com>
17293 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17294 MethodAttributes.HideBySig for operators.
17296 2004-08-23 Martin Baulig <martin@ximian.com>
17298 Back to the old error reporting system :-)
17300 * report.cs (Message): Removed.
17301 (Report.MessageData, ErrorData, WarningData): Removed.
17302 (Report.Error, Warning): Back to the old system.
17304 2004-08-23 Martin Baulig <martin@ximian.com>
17306 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17308 * class.cs (TypeContainer.ParentContainer): New public virtual
17309 method; replaces the explicit interface implementation.
17310 (ClassPart.ParentContainer): Override.
17312 2004-08-23 Martin Baulig <martin@ximian.com>
17314 * statement.cs (Switch): Added support for constant switches; see
17315 #59428 or test-285.cs.
17317 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17320 * statement.cs (GetEnumeratorFilter): Removed useless
17321 logic because C# specs is strict. GetEnumerator must be
17324 2004-08-22 Martin Baulig <martin@ximian.com>
17326 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17327 a switch and may break, reset the barrier. Fixes #59867.
17329 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17331 CLS-Compliance speed up (~5% for corlib)
17333 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17334 New method. Tests container for CLS-Compliant names
17336 * class.cs (TypeContainer.VerifyClsName): New method.
17337 Checks whether container name is CLS Compliant.
17338 (Constructor): Implements IMethodData.
17340 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17341 low-case table for CLS Compliance test.
17342 (MemberCache.VerifyClsParameterConflict): New method.
17343 Checks method parameters for CS3006 error.
17345 * enum.cs (EnumMember): Is derived from MemberCore.
17346 (Enum.VerifyClsName): Optimized for better performance.
17348 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17350 * report.cs: Renamed Error_T to Error and changed all
17353 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17355 * class.cs (TypeContainer.IndexerArrayList): New inner class
17356 container for indexers.
17357 (TypeContainer.DefaultIndexerName): New constant for default
17358 indexer name. Replaced all "Item" with this constant.
17359 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17361 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17362 DefaultMemberAttribute constructor.
17364 2004-08-05 Martin Baulig <martin@ximian.com>
17366 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17369 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17371 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17372 multi platforms problem.
17374 * compiler.csproj: Included shared files.
17376 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17378 Fix bug 60333, 55971 in the more general way
17379 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17380 Added arg_type argument for constant conversion.
17381 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17383 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17386 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17387 OperatorArrayList, MethodCoreArrayList for typecontainer
17388 containers. Changed class member types to these new types.
17389 (MethodArrayList.DefineMembers): Added test for CS0659.
17391 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17393 * cfold.cs: Synchronize the folding with the code in expression.cs
17394 Binary.DoNumericPromotions for uint operands.
17396 * attribute.cs: Revert patch from Raja, it introduced a regression
17397 while building Blam-1.2.1 (hard to isolate a test case).
17399 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17403 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17405 (MethodCore.parent_method): New member. The method we're overriding
17406 if this is an override method.
17407 (MethodCore.CheckBase): Moved from Method class and made common.
17408 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17410 (MethodCore.CheckForDuplications): New abstract method. For custom
17411 member duplication search in a container
17412 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17413 method and its return type.
17414 (Event.conflict_symbol): New member. Symbol with same name in the
17418 (MemberCache.FindMemberWithSameName): New method. The method
17419 is looking for conflict with inherited symbols.
17421 2004-08-04 Martin Baulig <martin@ximian.com>
17423 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17425 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17427 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17429 * report.cs (Message): New enum for better error, warning reference in
17431 (MessageData): New inner abstract class. It generally handles printing of
17432 error and warning messages.
17433 Removed unused Error, Warning, Message methods.
17435 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17437 Fix for cs0592-8.cs test
17439 (Attributable.ValidAttributeTargets): Made public.
17440 (Attribute.ExplicitTarget): New member for explicit target value.
17441 (Attribute.CheckTargets): Now we translate explicit attribute
17442 target to Target here.
17444 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17446 * ecore.cs (MethodGroupExpr): new IsBase property.
17448 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17450 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17451 rather than an instance expr.
17453 (DelegateCreation.Emit): Use the method group rather than
17454 the instance expression. Also, if you have base.Foo as the
17455 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17457 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17459 (NewDelegate.DoResolve): Only check for the existance of Invoke
17460 if the method is going to be needed. Use MethodGroupExpr.
17462 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17464 * expression.cs: For pointer arith., make sure to use
17465 the size of the type, not the size of the pointer to
17468 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17471 * class.cs (Class): Added error CS0502 test.
17473 2004-08-03 John Luke <jluke@cfl.rr.com>
17474 Raja R Harinath <rharinath@novell.com>
17477 * attribute.cs (Attribute.complained_before): New flag.
17478 (Attribute.ResolveType, Attribute.Resolve),
17479 (Attribute.DefinePInvokeMethod): Set it.
17480 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17482 2004-08-03 Martin Baulig <martin@ximian.com>
17484 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17485 use a user-defined operator; we still need to do numeric
17486 promotions in case one argument is a builtin type and the other
17487 one has an implicit conversion to that type. Fixes #62322.
17489 2004-08-02 Martin Baulig <martin@ximian.com>
17491 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17492 (LocalInfo.IsThis): New public property.
17493 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17495 2004-08-01 Martin Baulig <martin@ximian.com>
17497 * class.cs (TypeContainer.GetClassBases): Don't set the default
17498 here since we may get called from GetPartialBases().
17499 (TypeContainer.DefineType): If GetClassBases() didn't return a
17500 parent, use the default one.
17502 2004-07-30 Duncan Mak <duncan@ximian.com>
17504 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17506 2004-07-30 Martin Baulig <martin@ximian.com>
17508 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17510 * class.cs (SourceMethod): New public class, derive from the
17511 symbol writer's ISourceMethod.
17512 (Method): Use the new symbol writer API.
17514 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17515 as argument and use the new symbol writer.
17518 (SourceFile): Implement the symbol writer's ISourceFile.
17519 (Location.SymbolDocument): Removed.
17520 (Location.SourceFile): New public property.
17522 * symbolwriter.cs: Use the new symbol writer API.
17524 2004-07-30 Raja R Harinath <rharinath@novell.com>
17526 * Makefile (install-local): Remove. Functionality moved to
17529 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17531 * Makefile: Install mcs.exe.config file together with mcs.exe.
17532 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17533 correct runtime version.
17535 2004-07-25 Martin Baulig <martin@ximian.com>
17538 (TypeContainer.RegisterOrder): Removed, this was unused.
17539 (TypeContainer, interface_order): Removed.
17540 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17541 TypeContainer as argument since we can also be called with a
17542 `PartialContainer' for a partial class/struct/interface.
17543 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17544 of checking whether we're an `Interface' - we could be a
17545 `PartialContainer'.
17546 (PartialContainer.Register): Override; call
17547 AddClass()/AddStruct()/AddInterface() on our parent.
17549 * cs-parser.jay (interface_member_declaration): Add things to the
17550 `current_container', not the `current_class'.
17552 * rootcontext.cs (RegisterOrder): The overloaded version which
17553 takes an `Interface' was unused, removed.
17555 * typemanager.cs (TypeManager.LookupInterface): Return a
17556 `TypeContainer', not an `Interface'.
17557 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17558 contain a `PartialContainer' for an interface, so check it's
17559 `Kind' to figure out what it is.
17561 2004-07-25 Martin Baulig <martin@ximian.com>
17563 * class.cs (Class.DefaultTypeAttributes): New public constant.
17564 (Struct.DefaultTypeAttributes): Likewise.
17565 (Interface.DefaultTypeAttributes): Likewise.
17566 (PartialContainer.TypeAttr): Override this and add the
17567 DefaultTypeAttributes.
17569 2004-07-25 Martin Baulig <martin@ximian.com>
17571 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17572 we can just use the `Parent' field instead.
17574 2004-07-25 Martin Baulig <martin@ximian.com>
17576 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17578 2004-07-25 Martin Baulig <martin@ximian.com>
17580 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17581 our parts before defining any methods.
17582 (TypeContainer.VerifyImplements): Make this virtual.
17583 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17584 on our PartialContainer.
17586 2004-07-25 Martin Baulig <martin@ximian.com>
17588 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17590 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17591 argument, we can just use the `Parent' field instead.
17594 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17595 (MemberBase.DoDefine): Likewise.
17597 2004-07-24 Martin Baulig <martin@ximian.com>
17599 * decl.cs (MemberCore.Parent): New public field.
17600 (DeclSpace.Parent): Moved to MemberCore.
17602 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17603 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17605 (FieldBase, Field, Operator): Likewise.
17606 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17607 (EventField, Event): Likewise.
17609 2004-07-23 Martin Baulig <martin@ximian.com>
17611 * class.cs (PartialContainer): New public class.
17612 (ClassPart): New public class.
17613 (TypeContainer): Added support for partial classes.
17614 (TypeContainer.GetClassBases): Splitted some of the functionality
17615 out into GetNormalBases() and GetPartialBases().
17617 * cs-tokenizer.cs (Token.PARTIAL): New token.
17618 (Tokenizer.consume_identifier): Added some hacks to recognize
17619 `partial', but only if it's immediately followed by `class',
17620 `struct' or `interface'.
17622 * cs-parser.jay: Added support for partial clases.
17624 2004-07-23 Martin Baulig <martin@ximian.com>
17626 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17627 a `DeclSpace' and also made it readonly.
17628 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17629 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17630 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17632 * cs-parser.jay: Pass the `current_class', not the
17633 `current_container' (at the moment, this is still the same thing)
17634 to a new Method, Property, Event, Indexer or Constructor.
17636 2004-07-23 Martin Baulig <martin@ximian.com>
17638 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17639 and removed the `current_interface' one.
17640 (struct_declaration, class_declaration, interface_declaration):
17641 Set `current_class' to the newly created class/struct/interface;
17642 set their `Bases' and call Register() before parsing their body.
17644 2004-07-23 Martin Baulig <martin@ximian.com>
17646 * class.cs (Kind): New public enum.
17647 (TypeContainer): Made this class abstract.
17648 (TypeContainer.Kind): New public readonly field.
17649 (TypeContainer.CheckDef): New public method; moved here from
17651 (TypeContainer.Register): New public abstract method.
17652 (TypeContainer.GetPendingImplementations): New public abstract
17654 (TypeContainer.GetClassBases): Removed the `is_class' and
17655 `is_iface' parameters.
17656 (TypeContainer.DefineNestedTypes): Formerly known as
17658 (ClassOrStruct): Made this class abstract.
17660 * tree.cs (RootTypes): New public type.
17662 2004-07-20 Martin Baulig <martin@ximian.com>
17664 * tree.cs (Tree.RecordNamespace): Removed.
17665 (Tree.Namespaces): Removed.
17667 * rootcontext.cs (RootContext.IsNamespace): Removed.
17669 * cs-parser.jay (namespace_declaration): Just create a new
17670 NamespaceEntry here.
17672 2004-07-20 Martin Baulig <martin@ximian.com>
17674 * statement.cs (ExceptionStatement): New abstract class. This is
17675 now used as a base class for everyone who's using `finally'.
17676 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17677 our local variables before using them.
17679 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17680 virtual method. This is used by Yield.Resolve() to "steal" an
17681 outer block's `finally' clauses.
17682 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17685 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17686 version which takes an ExceptionStatement. This version must be
17687 used to create exception branchings.
17690 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17691 (Iterator.EmitMoveNext): Added exception support; protect the
17692 block with a `fault' clause, properly handle 'finally' clauses.
17693 (Iterator.EmitDispose): Run all the `finally' clauses here.
17695 2004-07-20 Martin Baulig <martin@ximian.com>
17697 * iterator.cs: This is the first of a set of changes in the
17698 iterator code. Match the spec more closely: if we're an
17699 IEnumerable, then GetEnumerator() must be called. The first time
17700 GetEnumerator() is called, it returns the current instance; all
17701 subsequent invocations (if any) must create a copy.
17703 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17705 * expression.cs: Resolve the constant expression before returning
17708 2004-07-19 Martin Baulig <martin@ximian.com>
17710 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17711 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17712 the return type of the new EmitContext.
17714 2004-07-18 Martin Baulig <martin@ximian.com>
17716 * class.cs (Property.Define): Fix iterators.
17718 * iterators.cs (Iterator.Define): Moved the
17719 `container.AddInterator (this)' call here from the .ctor; only do
17720 it if we resolved successfully.
17722 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17724 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17725 `true' for preprocessing directives that we parse. The return
17726 value indicates whether we should return to regular tokenizing or
17727 not, not whether it was parsed successfully.
17729 In the past if we were in: #if false ... #line #endif, we would
17730 resume parsing after `#line'. See bug 61604.
17732 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17733 building: IsEnumType should return true only for enums, not for
17734 enums or System.Enum itself. This fixes #61593.
17736 Likely what happened is that corlib was wrong: mcs depended on
17737 this bug in some places. The bug got fixed, we had to add the
17738 hack, which caused bug 61593.
17740 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17741 that was a workaround for the older conditions.
17743 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17745 * assign.cs: IAssignMethod has a new interface, as documented
17746 inline. All assignment code now uses this new api.
17748 * ecore.cs, expression.cs: All classes which implement
17749 IAssignMethod now use the new interface.
17751 * expression.cs (Invocation): add a hack to EmitCall so that
17752 IndexerAccess can be the target of a compound assignment without
17753 evaluating its arguments twice.
17755 * statement.cs: Handle changes in Invocation api.
17757 2004-07-16 Martin Baulig <martin@ximian.com>
17759 * iterators.cs: Rewrote this. We're now using one single Proxy
17760 class for both the IEnumerable and the IEnumerator interface and
17761 `Iterator' derives from Class so we can use the high-level API.
17763 * class.cs (TypeContainer.AddIterator): New method.
17764 (TypeContainer.DoDefineType): New protected virtual method, which
17765 is called from DefineType().
17766 (TypeContainer.DoDefineMembers): Call DefineType() and
17767 DefineMembers() on all our iterators.
17768 (TypeContainer.Emit): Call Emit() on all our iterators.
17769 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17771 * codegen.cs (EmitContext.CurrentIterator): New public field.
17773 2004-07-15 Martin Baulig <martin@ximian.com>
17776 (TypeManager.not_supported_exception_type): New type.
17778 2004-07-14 Martin Baulig <martin@ximian.com>
17780 * iterators.cs: Use real error numbers.
17782 2004-07-14 Martin Baulig <martin@ximian.com>
17784 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17785 requires this to be a System.Collection.IEnumerable and not a
17786 class implementing that interface.
17787 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17789 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17791 * class.cs: Fixed previous fix, it broke some error tests.
17793 2004-07-12 Martin Baulig <martin@ximian.com>
17795 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17798 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17800 * assign.cs (LocalTemporary): Add new argument: is_address,If
17801 `is_address' is true, then the value that we store is the address
17802 to the real value, and not the value itself.
17804 * ecore.cs (PropertyExpr): use the new local temporary
17805 stuff to allow us to handle X.Y += z (where X is a struct)
17807 2004-07-08 Martin Baulig <martin@ximian.com>
17809 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
17810 not always return, just like we're doing in Using.Resolve().
17812 2004-07-07 Miguel de Icaza <miguel@ximian.com>
17814 * cs-parser.jay (fixed_statement): flag this as Pinned.
17816 2004-07-06 Miguel de Icaza <miguel@ximian.com>
17818 * typemanager.cs (TypeManager): Removed MakePinned method, this
17819 mechanism is replaced with the .NET 2.x compatible mechanism of
17820 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
17822 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
17823 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
17824 `IsFixed' property which has a different meaning.
17826 2004-07-02 Raja R Harinath <rharinath@novell.com>
17828 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
17829 visible from inside a nested class, not just the names of the
17830 immediately enclosing class.
17831 Fix for bug #60730.
17833 2004-06-24 Raja R Harinath <rharinath@novell.com>
17835 * expression.cs (BetterConversion): Remove buggy special-case
17836 handling of "implicit constant expression conversions". At this
17837 point, we already know that the conversion is possible -- we're
17838 only checking to see which is better.
17840 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17842 * cs-parser.jay: Added error CS0210 test.
17844 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17846 * cs-parser.jay: Added error CS0134 test.
17848 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17851 * cs-parser.jay: Added error CS0145 test.
17853 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17855 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
17857 2004-06-23 Ben Maurer <bmaurer@ximian.com>
17859 * expression.cs (StackAlloc.Resolve): The argument may not
17860 be a constant; deal with this case.
17862 2004-06-23 Marek Safar <marek.safar@seznam.cz>
17864 * attribute.cs (IndexerName_GetIndexerName): Renamed to
17865 GetIndexerAttributeValue.
17866 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
17868 * class.cs (Indexer.Define): Added error tests for CS0415,
17871 2004-06-23 Miguel de Icaza <miguel@ximian.com>
17873 * attribute.cs (Attribute.Resolve): Keep field code in sync with
17876 2004-06-23 Martin Baulig <martin@ximian.com>
17878 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
17879 neither return nor throw, reset the barrier as well. Fixes #60457.
17881 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
17883 * class.cs : EventAttributes is now set to None by default.
17884 This fixes bug #60459.
17886 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17889 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17890 Don't throw exception but return null (it's sufficient now).
17892 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17894 * typemanager.cs (GetArgumentTypes): Faster implementation.
17896 2004-06-18 Martin Baulig <martin@ximian.com>
17898 * attribute.cs (Attribute.Resolve): Check whether we're an
17899 EmptyCast which a Constant child. Fixes #60333.
17901 2004-06-17 Ben Maurer <bmaurer@ximian.com>
17903 * statement.cs (EmitCollectionForeach): Account for the fact that
17904 not all valuetypes are in areas which we can take the address of.
17905 For these variables, we store to a temporary variable. Also, make
17906 sure that we dont emit a `callvirt' on a valuetype method.
17908 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17910 * expression.cs (StackAlloc.DoReSolve): Added test for
17911 negative parameter (CS0247).
17913 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17916 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
17918 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17921 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
17924 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17926 Fix bug #58254 & cs1555.cs, cs1556.cs
17927 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
17929 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17931 * cs-parser.jay: Added error CS1669 test for indexers.
17933 2004-06-11 Martin Baulig <martin@ximian.com>
17935 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
17936 call this twice: for params and varargs methods.
17938 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17941 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
17943 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17945 * attribute.cs (Attribute.GetValidTargets): Made public.
17948 (AbstractPropertyEventMethod): New class for better code sharing.
17949 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
17951 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
17953 2004-06-11 Raja R Harinath <rharinath@novell.com>
17956 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
17957 that the call to Resolve is part of a MemberAccess.
17958 (Expression.Resolve): Use it for SimpleName resolution.
17959 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
17960 Add 'intermediate' boolean argument.
17961 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
17962 error message when the SimpleName can be resolved ambiguously
17963 between an expression and a type.
17964 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
17966 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
17967 call on the left-side.
17969 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17972 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
17974 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17976 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
17978 2004-06-11 Martin Baulig <martin@ximian.com>
17980 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
17981 varargs methods if applicable.
17983 2004-06-11 Martin Baulig <martin@ximian.com>
17985 * expression.cs (Invocation.EmitCall): Don't use
17986 `method.CallingConvention == CallingConventions.VarArgs' since the
17987 method could also have `CallingConventions.HasThis'.
17989 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17991 * class.cs (Event.GetSignatureForError): Implemented.
17992 Fixed crash in error test cs3010.cs
17994 2004-06-10 Miguel de Icaza <miguel@ximian.com>
17996 * cs-tokenizer.cs: Change the way we track __arglist to be
17997 consistent with the other keywords.
17999 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18001 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18004 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18006 * codegen.cs: Check that all referenced assemblies have a strongname
18007 before strongnaming the compiled assembly. If not report error CS1577.
18008 Fix bug #56563. Patch by Jackson Harper.
18009 * typemanager.cs: Added a method to return all referenced assemblies.
18010 Fix bug #56563. Patch by Jackson Harper.
18012 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18015 (Method.ApplyAttributeBuilder): Moved and added conditional
18016 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18019 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18021 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18024 * class.cs: (EventField.attribute_targets): Changed default target.
18026 2004-06-08 Martin Baulig <martin@ximian.com>
18028 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18030 2004-06-08 Martin Baulig <martin@ximian.com>
18032 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18034 2004-06-07 Martin Baulig <martin@ximian.com>
18036 Added support for varargs methods.
18038 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18041 * cs-parser.jay: Added support for `__arglist'.
18043 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18045 * expression.cs (Argument.AType): Added `ArgList'.
18046 (Invocation): Added support for varargs methods.
18047 (ArglistAccess): New public class.
18048 (Arglist): New public class.
18050 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18052 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18053 a method's top-level block if the method has varargs.
18055 * support.cs (ReflectionParameters, InternalParameters): Added
18056 support for varargs methods.
18058 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18060 * class.cs: Provide location in indexer error report.
18062 * driver.cs: Use standard names.
18064 * namespace.cs: Catch the use of using after a namespace has been
18065 declared also on using aliases.
18067 2004-06-03 Raja R Harinath <rharinath@novell.com>
18070 * typemanager.cs (closure_private_ok, closure_invocation_type)
18071 (closure_qualifier_type, closure_invocation_assembly)
18072 (FilterWithClosure): Move to ...
18073 (Closure): New internal nested class.
18074 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18075 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18076 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18077 (MemberLookup, MemberLookupFailed): Use it.
18078 * expression.cs (New.DoResolve): Treat the lookup for the
18079 constructor as being qualified by the 'new'ed type.
18080 (Indexers.GetIndexersForTypeOrInterface): Update.
18082 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18085 (GetConditionalAttributeValue): New method. Returns
18086 condition of ConditionalAttribute.
18087 (SearchMulti): New method. Returns all attributes of type 't'.
18088 Use it when attribute is AllowMultiple = true.
18089 (IsConditionalMethodExcluded): New method.
18092 (Method.IsExcluded): Implemented. Returns true if method has conditional
18093 attribute and the conditions is not defined (method is excluded).
18094 (IMethodData): Extended interface for ConditionalAttribute support.
18095 (PropertyMethod.IsExcluded): Implemented.
18098 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18101 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18104 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18106 * expression.cs (ArrayCreationExpression): Make this just an
18107 `expression'. It can't be a statement, so the code here was
18110 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18113 * typemanager.cs (GetFullNameSignature): New method for
18116 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18119 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18120 Use this method when MethodBuilder is null.
18121 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18122 Added test for error CS0626 (MONO reports error for this situation).
18123 (IMethodData.GetSignatureForError): Extended interface.
18125 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18128 (AttributeTester.GetObsoleteAttribute): Returns instance of
18129 ObsoleteAttribute when type is obsolete.
18132 (TypeContainer.VerifyObsoleteAttribute): Override.
18133 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18134 (MethodCode.VerifyObsoleteAttribute): Override.
18135 (MemberBase.VerifyObsoleteAttribute): Override.
18138 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18139 and report proper error.
18142 Delegate.VerifyObsoleteAttribute): Override.
18145 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18146 and report proper error.
18147 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18150 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18154 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18155 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18156 Added test for ObsoleteAttribute.
18159 (Catch): Derived from Statement.
18161 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18163 Fixed bug #59071 & cs0160.cs
18165 * statement.cs (Try.Resolve): Check here whether order of catch
18166 clauses matches their dependencies.
18168 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18170 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18171 caused a regression: #59343. Referencing nested classes from an
18172 assembly stopped working.
18174 2004-05-31 Martin Baulig <martin@ximian.com>
18176 MCS is now frozen for beta 2.
18178 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18180 * convert.cs: add a trivial cache for overload operator resolution.
18182 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18184 * decl.cs: If possible, use lookuptypedirect here. We can only do
18185 this if there is no `.' after the namespace. Avoids using
18186 LookupType, which does lots of slow processing.
18187 (FindNestedType) New method, does what it says :-).
18188 * namespace.cs: use LookupTypeDirect.
18189 * rootcontext.cs: use membercache, if possible.
18190 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18192 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18195 According to the spec,
18197 In a member access of the form E.I, if E is a single identifier,
18198 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18199 field, property, localvariable, or parameter with the same type as
18200 the meaning of E as a type-name (§3.8), then both possible
18201 meanings of E are permitted.
18203 We did not check that E as a simple-name had the same type as E as
18206 This trivial check gives us 5-7% on bootstrap time.
18208 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18210 * expression.cs (Invocation.OverloadResolve): Avoid the
18211 use of hashtables and boxing here by allocating on demand.
18213 2004-05-30 Martin Baulig <martin@ximian.com>
18215 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18216 we're doing a silent lookup. Don't try to lookup nested types in
18217 TypeManager.object_type (thanks to Ben Maurer).
18219 2004-05-30 Martin Baulig <martin@ximian.com>
18221 Committing a patch from Ben Maurer.
18223 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18225 2004-05-29 Martin Baulig <martin@ximian.com>
18227 * class.cs (IMethodData.ShouldIgnore): New method.
18229 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18230 `Location' argument, we don't need it anywhere. Use
18231 `IMethodData.ShouldIgnore ()' instead of
18232 `MethodData.GetMethodFlags ()'.
18233 (TypeManager.AddMethod): Removed.
18234 (TypeManager.AddMethod2): Renamed to AddMethod.
18236 2004-05-29 Martin Baulig <martin@ximian.com>
18238 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18240 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18241 converting from a class type S to an interface type and we already
18242 have an object on the stack, don't box it again. Fixes #52578.
18244 2004-05-29 Martin Baulig <martin@ximian.com>
18246 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18247 Added support for `params' parameters. Fixes #59267.
18249 2004-05-29 Martin Baulig <martin@ximian.com>
18251 * literal.cs (NullPointer): Provide a private .ctor which sets
18252 `type' to TypeManager.object_type. Fixes #59048.
18254 2004-05-29 Martin Baulig <martin@ximian.com>
18256 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18257 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18259 * ecore.cs (EventExpr.instance_expr): Make the field private.
18261 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18263 Fixed bug #50080 & cs0214-2.cs
18264 * expression.cs (Cast.DoResolve): Check unsafe context here.
18266 * statement.cs (Resolve.DoResolve): Likewise.
18268 2004-05-26 Martin Baulig <martin@ximian.com>
18270 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18272 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18273 (RootContext.LookupType): Pass down the `silent' flag.
18275 2004-05-25 Martin Baulig <martin@ximian.com>
18278 (MethodGroupExpr.IdenticalTypeName): New public property.
18279 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18280 expression actually refers to a type.
18282 2004-05-25 Martin Baulig <martin@ximian.com>
18284 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18285 for #56176 and made it actually work.
18287 2004-05-25 Martin Baulig <martin@ximian.com>
18289 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18290 (FieldExpr, PropertyExpr): Override and implement
18291 CacheTemporaries. Fixes #52279.
18293 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18295 * location.cs: In the new compiler listing a file twice is a
18296 warning, not an error.
18298 2004-05-24 Martin Baulig <martin@ximian.com>
18300 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18301 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18303 2004-05-24 Martin Baulig <martin@ximian.com>
18305 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18306 walking the `using' list. Fixes #53921.
18308 2004-05-24 Martin Baulig <martin@ximian.com>
18310 * const.cs (Const.LookupConstantValue): Added support for
18311 EmptyCast's; fixes #55251.
18313 2004-05-24 Martin Baulig <martin@ximian.com>
18315 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18316 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18317 which does the CS0135 check. The reason is that we first need to
18318 check whether the variable actually exists.
18320 2004-05-24 Martin Baulig <martin@ximian.com>
18322 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18323 than RootContext.LookupType() to find the explicit interface
18324 type. Fixes #58584.
18326 2004-05-24 Raja R Harinath <rharinath@novell.com>
18328 * Makefile: Simplify. Use executable.make.
18329 * mcs.exe.sources: New file. List of sources of mcs.exe.
18331 2004-05-24 Anders Carlsson <andersca@gnome.org>
18335 Use the invariant culture when doing String.Compare for CLS case
18338 2004-05-23 Martin Baulig <martin@ximian.com>
18340 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18341 don't have any dots. Fixes #52622, added cs0246-8.cs.
18343 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18345 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18347 * class.cs (MemberBase.Define): Reuse MemberType member for
18348 resolved type. Other methods can use it too.
18350 2004-05-23 Martin Baulig <martin@ximian.com>
18352 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18353 the variable also exists in the current block (otherwise, we need
18354 to report a CS0103). Fixes #58670.
18356 2004-05-23 Martin Baulig <martin@ximian.com>
18358 * flowanalysis.cs (Reachability.Reachable): Compute this
18359 on-the-fly rather than storing it as a field.
18361 2004-05-23 Martin Baulig <martin@ximian.com>
18363 * flowanalysis.cs (Reachability.And): Manually compute the
18364 resulting `barrier' from the reachability.
18366 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18369 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18370 instance of ObsoleteAttribute when symbol is obsolete.
18373 (IMethodData): Extended interface for ObsoleteAttribute support.
18375 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18377 * attribute.cs: Fix bug #55970
18379 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18383 (GetObsoleteAttribute): New method. Creates the instance of
18385 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18386 ObsoleteAttribute when member is obsolete.
18387 (AttributeTester.Report_ObsoleteMessage): Common method for
18388 Obsolete error/warning reporting.
18391 (TypeContainer.base_classs_type): New member for storing parent type.
18394 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18395 for this MemberCore.
18397 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18399 * attribute.cs, const.cs: Fix bug #58590
18401 2004-05-21 Martin Baulig <martin@ximian.com>
18403 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18404 out parameters if the end of the method is unreachable. Fixes
18407 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18409 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18410 Hari was right, why extra method.
18412 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18414 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18416 2004-05-20 Martin Baulig <martin@ximian.com>
18418 Merged this back from gmcs to keep the differences to a minumum.
18420 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18421 instead of a Declspace.
18422 (Attribute.ResolveType): Likewise.
18423 (Attributes.Search): Likewise.
18424 (Attributes.Contains): Likewise.
18425 (Attributes.GetClsCompliantAttribute): Likewise.
18427 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18429 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18432 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18434 Fix bug #58688 (MCS does not report error when the same attribute
18437 * attribute.cs (Attribute.Emit): Distinction between null and default.
18439 2004-05-19 Raja R Harinath <rharinath@novell.com>
18441 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18442 of a top-level attribute without an attribute target.
18443 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18445 (Attribute.Conditional_GetConditionName),
18446 (Attribute.Obsolete_GetObsoleteMessage): Update.
18447 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18448 part of ScanForIndexerName.
18449 (Attribute.CanIgnoreInvalidAttribute): New function.
18450 (Attribute.ScanForIndexerName): Move to ...
18451 (Attributes.ScanForIndexerName): ... here.
18452 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18453 (Attributes.Search): New internal variant that can choose not to
18454 complain if types aren't resolved. The original signature now
18456 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18457 complaints suppressed.
18458 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18459 only if it not useful.
18460 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18461 top-level for attributes that are shared between the assembly
18462 and a top-level class.
18463 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18464 * class.cs: Update to reflect changes.
18465 (DefineIndexers): Fuse loops.
18466 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18467 a couple more variants of attribute names.
18469 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18471 Fix bug #52585 (Implemented explicit attribute declaration)
18474 (Attributable.ValidAttributeTargets): New abstract method. It gets
18475 list of valid attribute targets for explicit target declaration.
18476 (Attribute.Target): It holds target itself.
18477 (AttributeSection): Removed.
18478 (Attribute.CheckTargets): New method. It checks whether attribute
18479 target is valid for the current element.
18482 (EventProperty): New class. For events that are declared like
18483 property (with add and remove accessors).
18484 (EventField): New class. For events that are declared like field.
18487 * cs-parser.jay: Implemented explicit attribute target declaration.
18489 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18490 Override ValidAttributeTargets.
18493 (ReturnParameter): Class for applying custom attributes on
18495 (ParameterAtribute): New class. Class for applying custom
18496 attributes on the parameter type.
18498 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18500 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18503 (Method): Allow UNSAFE here.
18505 * modifiers.cs: Support unsafe reporting.
18507 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18509 * decl.cs: Fix bug #58478.
18511 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18513 * statement.cs: When checking for unreachable code on an EmptyStatement,
18514 set the location. Fixes bug #58488.
18516 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18518 * driver.cs: Add -pkg handling.
18520 From Gonzalo: UseShelLExecute=false
18522 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18525 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18527 (Attribute.IsClsCompliaceRequired): Moved to base for better
18529 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18530 when attribute is AttributeUsageAttribute.
18531 (Attribute.GetValidTargets): Simplified.
18532 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18533 attribute for this type.
18534 (Attribute.ApplyAttributes): Method renamed to Emit and make
18536 (GlobalAttributeSection): New class for special handling of global
18537 attributes (assembly, module).
18538 (AttributeSection.Emit): New method.
18540 * class.cs: Implemented Attributable abstract methods.
18541 (MethodCore.LabelParameters): Moved to Parameter class.
18542 (Accessor): Is back simple class.
18543 (PropertyMethod): Implemented Attributable abstract class.
18544 (DelegateMethod): Implemented Attributable abstract class.
18545 (Event): New constructor for disctintion between normal Event
18546 and Event with accessors.
18548 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18550 * codegen.cs, const.cs, decl.cs, delegate.cs:
18551 (CommonAssemblyModulClass): Implemented Attributable abstract class
18554 * enum.cs: Implement IAttributeSupport interface.
18555 (EnumMember): New class for emum members. Implemented Attributable
18559 (ParameterBase): Is abstract.
18560 (ReturnParameter): New class for easier [return:] attribute handling.
18562 * typemanager.cs: Removed builder_to_attr.
18564 2004-05-11 Raja R Harinath <rharinath@novell.com>
18567 * attribute.cs (Attribute.GetPositionalValue): New function.
18568 * class.cs (TypeContainer.VerifyMembers): New function.
18569 (TypeContainer.Emit): Use it.
18570 (ClassOrStruct): New base class for Class and Struct.
18571 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18572 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18574 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18575 then each non-static field should have a FieldOffset attribute.
18576 Otherwise, none of the fields should have a FieldOffset attribute.
18577 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18578 and FieldOffset attributes.
18579 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18580 (TypeManager.field_offset_attribute_type): New core types.
18581 (TypeManager.InitCoreTypes): Initialize them.
18583 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18585 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18586 Return correct type.
18589 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18591 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18592 be implicitly converted to ulong.
18594 * expression.cs: The logic for allowing operator &, | and ^ worked
18595 was wrong, it worked before because we did not report an error in
18596 an else branch. Fixes 57895.
18598 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18599 allow volatile fields to be reference types.
18601 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18603 * driver.cs: Add support for /debug-
18605 2004-05-07 Raja R Harinath <rharinath@novell.com>
18607 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18608 Add a 'complain' parameter to silence errors.
18609 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18610 silently overlooked type-resolutions.
18611 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18612 to reflect changes.
18613 (Attributes.Search): New function.
18614 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18615 (Attributes.GetAttributeFullName): Remove hack.
18616 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18617 Update to reflect changes.
18618 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18619 Use Attributes.Search instead of nested loops.
18621 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18624 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18625 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18626 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18628 * report.cs: (Report.Warning): Renamed to Warning_T because of
18629 parameter collision.
18631 2004-05-05 Raja R Harinath <rharinath@novell.com>
18633 * expression.cs (MemberAccess.ResolveMemberAccess):
18634 Exit with non-zero status after Report.Error.
18635 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18637 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18639 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18641 * support.cs: Don't hang when the file is empty.
18643 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18645 * support.cs: In SeekableStreamReader, compute the preamble size of the
18646 underlying stream. Position changes should take into account that initial
18649 2004-05-03 Todd Berman <tberman@sevenl.net>
18651 * driver.cs: remove unused GetSysVersion function.
18653 2004-05-03 Todd Berman <tberman@sevenl.net>
18655 * driver.cs: Remove the hack from saturday, as well as the hack
18656 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18657 link_paths to get that bit proper.
18659 2004-05-01 Todd Berman <tberman@sevenl.net>
18661 * driver.cs: Try a LoadFrom before a Load, this checks the current
18662 path. This is currently a bug in mono that is be fixed, however, this
18663 provides a workaround for now. This will be removed when the bug
18666 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18668 * CryptoConvert.cs: Updated to latest version. Fix issue with
18669 incomplete key pairs (#57941).
18671 2004-05-01 Todd Berman <tberman@sevenl.net>
18673 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18676 2004-04-30 Jackson Harper <jackson@ximian.com>
18678 * codegen.cs: Open keys readonly.
18680 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18682 * typemanager.cs: don't report cyclic struct layout when a struct
18683 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18684 which has 2 Pango.Rectangle fields.
18686 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18688 * expression.cs: Handle IntPtr comparisons with IL code
18689 rather than a method call.
18691 2004-04-29 Martin Baulig <martin@ximian.com>
18693 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18694 the list of PropertyInfo's in class hierarchy and find the
18695 accessor. Fixes #56013.
18697 2004-04-29 Martin Baulig <martin@ximian.com>
18699 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18701 2004-04-29 Martin Baulig <martin@ximian.com>
18703 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18705 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18707 2004-04-29 Martin Baulig <martin@ximian.com>
18709 * class.cs (ConstructorInitializer.Resolve): Check whether the
18710 parent .ctor is accessible. Fixes #52146.
18712 2004-04-29 Martin Baulig <martin@ximian.com>
18714 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18716 * statement.cs (Using.EmitLocalVariableDecls): Use
18717 TypeManager.idisposable_type, not typeof (IDisposable).
18718 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18720 2004-04-29 Martin Baulig <martin@ximian.com>
18722 * class.cs (Event.Define): Don't emit the field and don't set
18723 RTSpecialName and SpecialName for events on interfaces. Fixes
18726 2004-04-29 Raja R Harinath <rharinath@novell.com>
18728 Refactor Attribute.ApplyAttributes.
18729 * attribute.cs (Attributable): New base class for objects that can
18730 have Attributes applied on them.
18731 (Attribute): Make AttributeUsage fields public.
18732 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18733 (Attribute.IsInternalCall): New property.
18734 (Attribute.UsageAttr): Convert to a public read-only property.
18735 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18736 (Attribute.ResolveType, Attribute.Resolve)
18737 (Attribute.ScanForIndexerName): Update to reflect changes.
18738 (Attribute.CheckAttributeTarget): Re-format.
18739 (Attribute.ApplyAttributes): Refactor, to various
18740 Attributable.ApplyAttributeBuilder methods.
18741 * decl.cs (MemberCore): Make Attributable.
18742 * class.cs (Accessor): Make Attributable.
18743 (MethodData.ApplyAttributes): Use proper attribute types, not
18745 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18746 (TypeContainer.ApplyAttributeBuilder)
18747 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18748 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18749 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18750 (Operator.ApplyAttributeBuilder): New factored-out methods.
18751 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18752 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18753 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18754 * parameter.cs (ParameterBase): New Attributable base class
18755 that can also represent Return types.
18756 (Parameter): Update to the changes.
18758 2004-04-29 Jackson Harper <jackson@ximian.com>
18760 * driver.cs: Prefer the corlib system version when looking for
18761 assemblies in the GAC. This is still a hack, but its a better hack
18764 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18766 * decl.cs, enum.cs: Improved error 3005 reporting.
18768 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18769 (related_symbols): New private member for list of symbols
18770 related to reported error/warning.
18772 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18774 2004-04-29 Martin Baulig <martin@ximian.com>
18776 * ecore.cs (Expression.Constantify): If we're an enum and
18777 TypeManager.TypeToCoreType() doesn't give us another type, use
18778 t.UnderlyingSystemType. Fixes #56178.
18780 2004-04-29 Martin Baulig <martin@ximian.com>
18782 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18783 interfaces and for each interface, only add members directly
18784 declared in that interface. Fixes #53255.
18786 2004-04-28 Martin Baulig <martin@ximian.com>
18788 * expression.cs (ConditionalLogicalOperator): Use a temporary
18789 variable for `left' to avoid that we evaluate it more than once;
18792 2004-04-28 Martin Baulig <martin@ximian.com>
18794 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18797 2004-04-28 Martin Baulig <martin@ximian.com>
18799 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18802 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18803 whether the type is not void (CS1547).
18805 2004-04-28 Martin Baulig <martin@ximian.com>
18807 * expression.cs (Unary.DoResolveLValue): Override this and report
18808 CS0131 for anything but Operator.Indirection.
18810 2004-04-28 Martin Baulig <martin@ximian.com>
18812 Committing a patch from Ben Maurer; see bug #50820.
18814 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18817 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18820 2004-04-28 Martin Baulig <martin@ximian.com>
18822 Committing a patch from Ben Maurer; see bug #50820.
18824 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18827 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18830 2004-04-28 Martin Baulig <martin@ximian.com>
18832 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
18833 (Block.AddLabel): Call DoLookupLabel() to only search in the
18836 2004-04-28 Martin Baulig <martin@ximian.com>
18838 * cfold.cs (ConstantFold.BinaryFold): Added special support for
18839 comparing StringConstants and NullLiterals in Equality and Inequality.
18841 2004-04-28 Jackson Harper <jackson@ximian.com>
18843 * driver.cs: Attempt to load referenced assemblies from the
18844 GAC. This is the quick and dirty version of this method that
18845 doesnt take into account versions and just takes the first
18846 canidate found. Will be good enough for now as we will not have more
18847 then one version installed into the GAC until I update this method.
18849 2004-04-28 Martin Baulig <martin@ximian.com>
18851 * typemanager.cs (TypeManager.CheckStructCycles): New public
18852 static method to check for cycles in the struct layout.
18854 * rootcontext.cs (RootContext.PopulateTypes): Call
18855 TypeManager.CheckStructCycles() for each TypeContainer.
18856 [Note: We only need to visit each type once.]
18858 2004-04-28 Martin Baulig <martin@ximian.com>
18860 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
18862 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
18863 success and added `out object value'. Use a `bool resolved' field
18864 to check whether we've already been called rather than
18865 `ConstantValue != null' since this breaks for NullLiterals.
18867 2004-04-28 Raja R Harinath <rharinath@novell.com>
18869 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
18870 setting of this flag, since the 'set' method may be non-public.
18872 2004-04-28 Raja R Harinath <rharinath@novell.com>
18874 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
18875 check on current_vector.Block.
18877 2004-04-27 Martin Baulig <martin@ximian.com>
18879 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
18880 a field initializer. Fixes #56459.
18882 2004-04-27 Martin Baulig <martin@ximian.com>
18884 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
18885 we're not attempting to use an indexer. Fixes #52154.
18887 2004-04-27 Martin Baulig <martin@ximian.com>
18889 * statement.cs (Return): Don't create a return label if we don't
18890 need it; reverts my change from January 20th. Thanks to Ben
18893 2004-04-27 Martin Baulig <martin@ximian.com>
18895 According to the spec, `goto' can only leave a nested scope, but
18898 * statement.cs (Block.LookupLabel): Only lookup in the current
18899 block, don't recurse into parent or child blocks.
18900 (Block.AddLabel): Check in parent and child blocks, report
18901 CS0140/CS0158 if we find a duplicate.
18902 (Block): Removed this indexer for label lookups.
18903 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
18904 this already does the error reporting for us.
18907 (FlowBranching.UsageVector.Block): New public variable; may be null.
18908 (FlowBranching.CreateSibling): Added `Block' argument.
18909 (FlowBranching.LookupLabel): New public virtual method. Lookup a
18910 label for the target of a `goto' and check whether we're not
18911 leaving a `finally'.
18913 2004-04-27 Martin Baulig <martin@ximian.com>
18915 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
18916 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
18919 2004-04-27 Martin Baulig <martin@ximian.com>
18921 * statement.cs (Block.AddLabel): Also check for implicit blocks
18922 and added a CS0158 check.
18924 2004-04-27 Martin Baulig <martin@ximian.com>
18926 * flowanalysis.cs (FlowBranchingLoop): New class.
18927 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
18928 UsageVector's instead of an ArrayList.
18929 (FlowBranching.Label): Likewise.
18930 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
18931 (FlowBranching.AddBreakVector): New method.
18933 2004-04-27 Miguel de Icaza <miguel@ximian.com>
18935 * attribute.cs: Small regression fix: only convert the type if we
18936 the type is different, fixes System.Drawing build.
18938 2004-04-27 Martin Baulig <martin@ximian.com>
18940 * attribute.cs (Attribute.Resolve): If we have a constant value
18941 for a named field or property, implicity convert it to the correct
18944 2004-04-27 Raja R Harinath <rharinath@novell.com>
18946 * statement.cs (Block.Block): Implicit blocks share
18947 'child_variable_names' fields with parent blocks.
18948 (Block.AddChildVariableNames): Remove.
18949 (Block.AddVariable): Mark variable as "used by a child block" in
18950 every surrounding block.
18951 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
18952 been used in a child block, complain about violation of "Invariant
18953 meaning in blocks" rule.
18954 * cs-parser.jay (declare_local_variables): Don't use
18955 AddChildVariableNames.
18956 (foreach_statement): Don't create an implicit block: 'foreach'
18957 introduces a scope.
18959 2004-04-23 Miguel de Icaza <miguel@ximian.com>
18961 * convert.cs (ImplicitNumericConversion): 0 is also positive when
18962 converting from 0L to ulong. Fixes 57522.
18964 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18966 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
18967 derived class hides via 'new' keyword field from base class (test-242.cs).
18968 TODO: Handle this in the more general way.
18970 * class.cs (CheckBase): Ditto.
18972 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18974 * decl.cs (caching_flags): New member for storing cached values
18976 (MemberCore.Flags): New enum where bit flags for caching_flags
18978 (MemberCore.cls_compliance): Moved to caching_flags.
18979 (DeclSpace.Created): Moved to caching_flags.
18981 * class.cs: Use caching_flags instead of DeclSpace.Created
18983 2004-04-21 Miguel de Icaza <miguel@ximian.com>
18985 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
18986 if we are only a derived class, not a nested class.
18988 * typemanager.cs: Same as above, but do this at the MemberLookup
18989 level (used by field and methods, properties are handled in
18990 PropertyExpr). Allow for the qualified access if we are a nested
18993 2004-04-21 Marek Safar <marek.safar@seznam.cz>
18995 * class.cs: Refactoring.
18996 (IMethodData): New inteface; Holds links to parent members
18997 to avoid member duplication (reduced memory allocation).
18998 (Method): Implemented IMethodData interface.
18999 (PropertyBase): New inner classes for get/set methods.
19000 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19001 (Event): New inner classes for add/remove methods.
19002 (Event.DelegateMethod): Implemented IMethodData interface.
19004 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19005 EmitContext (related to class.cs refactoring).
19007 2004-04-21 Raja R Harinath <rharinath@novell.com>
19009 * delegate.cs (Delegate.VerifyApplicability): If the number of
19010 arguments are the same as the number of parameters, first try to
19011 verify applicability ignoring any 'params' modifier on the last
19015 2004-04-16 Raja R Harinath <rharinath@novell.com>
19017 * class.cs (TypeContainer.AddIndexer): Use
19018 'ExplicitInterfaceName' to determine if interface name was
19019 explicitly specified. 'InterfaceType' is not initialized at this time.
19020 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19021 Indexers array is already in the required order. Initialize
19022 'IndexerName' only if there are normal indexers.
19023 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19024 (TypeContainer.Emit): Emit DefaultMember attribute only if
19025 IndexerName is initialized.
19028 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19030 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19033 2004-04-15 Raja R Harinath <rharinath@novell.com>
19035 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19039 * attribute.cs (Attribute.Resolve): Check for duplicate named
19043 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19045 * iterators.cs (MarkYield): track whether we are in an exception,
19046 and generate code accordingly. Use a temporary value to store the
19047 result for our state.
19049 I had ignored a bit the interaction of try/catch with iterators
19050 since their behavior was not entirely obvious, but now it is
19051 possible to verify that our behavior is the same as MS .NET 2.0
19055 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19057 * iterators.cs: Avoid creating temporaries if there is no work to
19060 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19061 Enumerations, use TypeManager.EnumToUnderlying and call
19064 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19067 (This.Emit): Use EmitContext.EmitThis to emit our
19070 (This.EmitAssign): Ditto.
19072 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19073 codepaths, we will move all the functionality into
19076 (FieldExpr.EmitAssign): Ditto.
19078 This fixes several hidden bugs that I uncovered while doing a code
19079 review of this today.
19081 * codegen.cs (EmitThis): reworked so the semantics are more clear
19082 and also support value types "this" instances.
19084 * iterators.cs: Changed so that for iterators in value types, we
19085 do not pass the value type as a parameter.
19087 Initialization of the enumerator helpers is now done in the caller
19088 instead of passing the parameters to the constructors and having
19089 the constructor set the fields.
19091 The fields have now `assembly' visibility instead of private.
19093 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19095 * expression.cs (Argument.Resolve): Check if fields passed as ref
19096 or out are contained in a MarshalByRefObject.
19098 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19099 another compiler type.
19101 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19103 * class.cs (Indexer.Define): use the new name checking method.
19104 Also, return false on an error.
19105 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19106 (is_identifier_[start/part]_character): make static.
19108 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19110 * expression.cs (Binary.ResolveOperator): Do no append strings
19111 twice: since we can be invoked more than once (array evaluation)
19112 on the same concatenation, take care of this here. Based on a fix
19113 from Ben (bug #56454)
19115 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19117 * codegen.cs: Fix another case where CS1548 must be reported (when
19118 delay-sign isn't specified and no private is available #56564). Fix
19119 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19120 error when MCS is used on the MS runtime and we need to delay-sign
19121 (which seems unsupported by AssemblyBuilder - see #56621).
19123 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19125 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19126 (TypeManager.ComputeNamespaces): Faster implementation for
19129 * compiler.csproj: Updated AssemblyName to mcs.
19131 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19133 * rootcontext.cs: Add new types to the boot resolution.
19135 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19136 MulticastDelegate is not allowed.
19138 * typemanager.cs: Add new types to lookup: System.TypedReference
19141 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19142 check for TypedReference or ArgIterator, they are not allowed.
19144 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19145 makes us properly catch 1510 in some conditions (see bug 56016 for
19148 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19150 * CryptoConvert.cs: update from corlib version
19153 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19155 * class.cs (Indexer.Define): Check indexername declaration
19157 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19159 * attribute.cs (IsClsCompliant): Fixed problem with handling
19160 all three states (compliant, not-compliant, undetected).
19162 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19164 * attribute.cs (Attribute): Location is now public.
19165 (Resolve): Store resolved arguments (pos_values) in attribute class.
19166 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19167 (GetClsCompliantAttributeValue): New method that gets
19168 CLSCompliantAttribute value.
19169 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19170 if exists else null.
19171 (AttributeTester): New class for CLS-Compliant verification routines.
19173 * class.cs (Emit): Add CLS-Compliant verification.
19174 (Method.GetSignatureForError): Implemented.
19175 (Constructor.GetSignatureForError): Implemented
19176 (Constructor.HasCompliantArgs): Returns if constructor has
19177 CLS-Compliant arguments.
19178 (Constructor.Emit): Override.
19179 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19180 is needed to test only parameters.
19181 (FieldBase.GetSignatureForError): Implemented.
19182 (TypeContainer): New member for storing base interfaces.
19183 (TypeContainer.FindMembers): Search in base interfaces too.
19185 * codegen.cs (GetClsComplianceAttribute): New method that gets
19186 assembly or module CLSCompliantAttribute value.
19187 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19189 (ModuleClass.Emit): Add error 3012 test.
19191 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19193 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19194 state for all decl types.
19195 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19196 if CLS-Compliant tests are required.
19197 (IsClsCompliaceRequired): New method. Analyze whether code
19198 must be CLS-Compliant.
19199 (IsExposedFromAssembly): New method. Returns true when MemberCore
19200 is exposed from assembly.
19201 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19202 value or gets cached value.
19203 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19204 is explicitly marked with CLSCompliantAttribute.
19205 (IsIdentifierClsCompliant): New abstract method. This method is
19206 used to testing error 3005.
19207 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19208 for identifier and parameters CLS-Compliant testing.
19209 (VerifyClsCompliance): New method. The main virtual method for
19210 CLS-Compliant verifications.
19211 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19212 null. I don't know why is null (too many public members !).
19213 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19214 and get value of first CLSCompliantAttribute that found.
19216 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19217 (VerifyClsCompliance): Override and add extra tests.
19219 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19220 clscheck- disable CLS-Compliant verification event if assembly is has
19221 CLSCompliantAttribute(true).
19223 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19224 ApllyAttribute is now called in emit section as in the other cases.
19225 Possible future Emit integration.
19226 (IsIdentifierClsCompliant): New override.
19227 (VerifyClsCompliance): New override.
19228 (GetEnumeratorName): Returns full enum name.
19230 * parameter.cs (GetSignatureForError): Implemented.
19232 * report.cs (WarningData): New struct for Warning message information.
19233 (LocationOfPreviousError): New method.
19234 (Warning): New method. Reports warning based on the warning table.
19235 (Error_T): New method. Reports error based on the error table.
19237 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19238 verifications are done here.
19240 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19242 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19243 CLSCompliantAttribute.
19244 (all_imported_types): New member holds all imported types from other
19246 (LoadAllImportedTypes): New method fills static table with exported types
19247 from all referenced assemblies.
19248 (Modules): New property returns all assembly modules.
19250 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19252 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19253 throwing a parser error.
19255 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19256 which removes the hardcoded get_/set_ prefixes for properties, as
19257 IL allows for the properties to be named something else.
19261 * expression.cs: Do not override operand before we know if it is
19262 non-null. Fix 56207
19264 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19266 * typemanager.cs: support for pinned variables.
19268 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19270 * decl.cs, typemanager.cs: Avoid using an arraylist
19271 as a buffer if there is only one result set.
19273 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19275 * expression.cs: Make sure you cant call a static method
19276 with an instance expression, bug #56174.
19278 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19280 * class.cs (IsDuplicateImplementation): Improve error reporting to
19281 flag 663 (method only differs in parameter modifier).
19283 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19284 in preprocessor directives.
19286 * location.cs (LookupFile): Allow for the empty path.
19288 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19289 better approach for some of that patch, but its failing with the
19290 CharSet enumeration. For now try/catch will do.
19292 * typemanager.cs: Do not crash if a struct does not have fields.
19295 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19297 * expression.cs: cs0213, cant fix a fixed expression.
19300 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19302 * cs-parser.jay: detect invalid embeded statements gracefully.
19305 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19307 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19310 the invocation type may not be a subclass of the tye of the item/
19311 The type of the item must be a subclass of the invocation item.
19316 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19318 * attribute.cs: Added methods to get a string and a bool from an
19319 attribute. Required to information from AssemblyKeyFileAttribute,
19320 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19321 * codegen.cs: Modified AssemblyName creation to include support for
19322 strongnames. Catch additional exceptions to report them as CS1548.
19323 * compiler.csproj: Updated include CryptoConvert.cs.
19324 * compiler.csproj.user: Removed file - user specific configuration.
19325 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19326 Mono.Security assembly. The original class is maintained and tested in
19327 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19328 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19329 like CSC 8.0 (C# v2) supports.
19330 * Makefile: Added CryptoConvert.cs to mcs sources.
19331 * rootcontext.cs: Added new options for strongnames.
19333 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19335 * driver.cs: For --expect-error, report error code `2'
19336 if the program compiled with no errors, error code `1' if
19337 it compiled with an error other than the one expected.
19339 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19341 * compiler.csproj: Updated for Visual Studio .NET 2003.
19342 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19343 * compiler.sln: Updated for Visual Studio .NET 2003.
19345 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19347 * expression.cs: Fix bug #47234. We basically need to apply the
19348 rule that we prefer the conversion of null to a reference type
19349 when faced with a conversion to 'object' (csc behaviour).
19351 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19353 * statement.cs: Shorter form for foreach, eliminates
19354 a local variable. r=Martin.
19356 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19358 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19359 checks if we can use brtrue/brfalse to test for 0.
19360 * expression.cs: use the above in the test for using brtrue/brfalse.
19361 cleanup code a bit.
19363 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19365 * expression.cs: Rewrite string concat stuff. Benefits:
19367 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19368 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19369 rather than a concat chain.
19371 * typemanager.cs: Add lookups for more concat overloads.
19373 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19375 * expression.cs: Emit shorter il code for array init.
19392 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19394 * statement.cs: Before, two switch blocks would be merged if the
19395 total size of the blocks (end_item - begin_item + 1) was less than
19396 two times the combined sizes of the blocks.
19398 Now, it will only merge if after the merge at least half of the
19403 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19405 * class.cs : csc build fix for GetMethods(). See bug #52503.
19407 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19409 * expression.cs: Make sure fp comparisons work with NaN.
19410 This fixes bug #54303. Mig approved this patch a long
19411 time ago, but we were not able to test b/c the runtime
19414 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19416 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19418 2004-03-19 Martin Baulig <martin@ximian.com>
19420 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19421 error here and not in our caller.
19423 2004-03-19 Martin Baulig <martin@ximian.com>
19425 * interface.cs: Completely killed this file.
19426 (Interface): We're now a TypeContainer and live in class.cs.
19428 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19429 argument; we're now also called for interfaces.
19430 (TypeContainer.DefineMembers): Allow this method being called
19432 (TypeContainer.GetMethods): New public method; formerly known as
19433 Interface.GetMethod(). This is used by PendingImplementation.
19434 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19435 it's now private and non-static.
19436 (Interface): Moved this here; it's now implemented similar to
19438 (Method, Property, Event, Indexer): Added `bool is_interface'
19439 argument to their .ctor's.
19440 (MemberBase.IsInterface): New public field.
19442 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19443 instances instead of InterfaceMethod, InterfaceProperty, etc.
19444 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19445 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19447 2004-03-19 Martin Baulig <martin@ximian.com>
19449 * class.cs (MethodCore.IsDuplicateImplementation): New private
19450 method which does the CS0111 checking.
19451 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19452 Use IsDuplicateImplementation().
19454 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19456 * decl.cs (FindMemberToOverride): New method to find the correct
19457 method or property to override in the base class.
19459 - Make Method/Property use the above method to find the
19460 version in the base class.
19461 - Remove the InheritableMemberSignatureCompare as it is now
19464 This patch makes large code bases much faster to compile, as it is
19465 O(n) rather than O(n^2) to do this validation.
19467 Also, it fixes bug 52458 which is that nested classes are not
19468 taken into account when finding the base class member.
19470 Reviewed/Approved by Martin.
19472 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19474 * interface.cs: In all interface classes removed redundant
19475 member initialization.
19477 2004-03-16 Martin Baulig <martin@ximian.com>
19479 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19481 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19483 * decl.cs (DefineTypeAndParents): New helper method to define a
19484 type's containers before the type itself is defined; This is a
19485 bug exposed by the recent changes to Windows.Forms when an
19486 implemented interface was defined inside a class that had not been
19489 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19491 (Check): Loop correctly to report errors modifiers
19492 (UNSAFE was not in the loop, since it was the same as TOP).
19494 * interface.cs: Every interface member now takes a ModFlags,
19495 instead of a "is_new" bool, which we set on the base MemberCore.
19497 Every place where we called "UnsafeOk" in the interface, now we
19498 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19499 the unsafe settings from the member declaration instead of the
19500 container interface.
19502 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19504 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19505 `set_indexer_name' to the pending bits (one per type).
19507 We fixed a bug today that was picking the wrong method to
19508 override, since for properties the existing InterfaceMethod code
19509 basically ignored the method name. Now we make sure that the
19510 method name is one of the valid indexer names.
19512 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19514 * support.cs (SeekableStreamReader): Keep track of stream byte
19515 positions and don't mix them with character offsets to the buffer.
19517 Patch from Gustavo Giráldez
19519 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19521 * interface.cs (InterfaceSetGetBase): Removed double member
19522 initialization, base class does it as well.
19524 2004-03-13 Martin Baulig <martin@ximian.com>
19526 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19527 when compiling corlib.
19529 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19531 * convert.cs (ExplicitConversion): We were reporting an error on
19532 certain conversions (object_type source to a value type, when the
19533 expression was `null') before we had a chance to pass it through
19534 the user defined conversions.
19536 * driver.cs: Replace / and \ in resource specifications to dots.
19539 * class.cs: Add check for duplicate operators. Fixes 52477
19541 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19543 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19544 that are in the middle of the statements, not only at the end.
19547 * class.cs (TypeContainer.AddField): No longer set the
19548 `HaveStaticConstructor' flag, now we call it
19549 `UserDefineStaticConstructor' to diferentiate the slightly
19550 semantic difference.
19552 The situation is that we were not adding BeforeFieldInit (from
19553 Modifiers.TypeAttr) to classes that could have it.
19554 BeforeFieldInit should be set to classes that have no static
19559 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19561 And most importantly Zoltan's comment:
19563 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19565 "I think beforefieldinit means 'it's ok to initialize the type sometime
19566 before its static fields are used', i.e. initialization does not need
19567 to be triggered by the first access to the type. Setting this flag
19568 helps the JIT to compile better code, since it can run the static
19569 constructor at JIT time, and does not need to generate code to call it
19570 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19571 this flag for lots of classes like String.
19573 csc sets this flag if the type does not have an explicit static
19574 constructor. The reasoning seems to be that if there are only static
19575 initalizers for a type, and no static constructor, then the programmer
19576 does not care when this initialization happens, so beforefieldinit
19579 This bug prevents the AOT compiler from being usable, since it
19580 generates so many calls to mono_runtime_class_init that the AOT code
19581 is much slower than the JITted code. The JITted code is faster,
19582 because it does not generate these calls if the vtable is type is
19583 already initialized, which is true in the majority of cases. But the
19584 AOT compiler can't do this."
19586 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19588 * class.cs (MethodData.Emit): Refactor the code so symbolic
19589 information is generated for destructors; For some reasons we
19590 were taking a code path that did not generate symbolic information
19593 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19595 * class.cs: Create a Constructor.CheckBase method that
19596 takes care of all validation type code. The method
19597 contains some code that was moved from Define.
19599 It also includes new code that checks for duplicate ctors.
19600 This fixes bug #55148.
19602 2004-03-09 Joshua Tauberer <tauberer@for.net>
19604 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19605 a { ... }-style array creation invokes EmitStaticInitializers
19606 which is not good for reference-type arrays. String, decimal
19607 and now null constants (NullCast) are not counted toward
19608 static initializers.
19610 2004-03-05 Martin Baulig <martin@ximian.com>
19612 * location.cs (SourceFile.HasLineDirective): New public field;
19613 specifies whether the file contains or is referenced by a "#line"
19615 (Location.DefineSymbolDocuments): Ignore source files which
19616 either contain or are referenced by a "#line" directive.
19618 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19620 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19621 direct access to our parent, so check the method inline there.
19623 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19625 * expression.cs (Invocation.EmitCall): Miguel's last commit
19626 caused a regression. If you had:
19631 In Foo the implict this would be null.
19633 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19635 * expression.cs (Invocation.EmitCall): If the method is not
19636 virtual, do not emit a CallVirt to it, use Call.
19638 * typemanager.cs (GetFullNameSignature): Improve the method to
19639 cope with ".ctor" and replace it with the type name.
19641 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19642 as an argument the ConstructorBuilder where it is being defined,
19643 to catch the recursive constructor invocations.
19645 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19647 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19648 routines to check if a type is an enumerable/enumerator allow
19649 classes that implement the IEnumerable or IEnumerator interfaces.
19651 * class.cs (Property, Operator): Implement IIteratorContainer, and
19652 implement SetYields.
19654 (Property.Define): Do the block swapping for get_methods in the
19655 context of iterators. We need to check if Properties also
19656 include indexers or not.
19658 (Operator): Assign the Block before invoking the
19659 OperatorMethod.Define, so we can trigger the Iterator code
19662 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19663 Property and Operator classes are not created when we parse the
19664 declarator but until we have the block completed, so we use a
19665 singleton SimpleIteratorContainer.Simple to flag whether the
19666 SetYields has been invoked.
19668 We propagate this setting then to the Property or the Operator to
19669 allow the `yield' to function.
19671 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19673 * codegen.cs: Implemented attribute support for modules.
19674 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19675 Assembly/Module functionality.
19677 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19678 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19679 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19681 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19683 * interface.cs (FindMembers): The operation is performed on all base
19684 interfaces and not only on the first. It is required for future CLS Compliance patch.
19686 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19688 * statement.cs, codegen.cs:
19689 This patch deals with patterns such as:
19691 public class List : IEnumerable {
19693 public MyEnumerator GetEnumerator () {
19694 return new MyEnumerator(this);
19697 IEnumerator IEnumerable.GetEnumerator () {
19701 public struct MyEnumerator : IEnumerator {
19706 Before, there were a few things we did wrong:
19707 1) we would emit callvirt on a struct, which is illegal
19708 2) we emited ldarg when we needed to emit ldarga
19709 3) we would mistakenly call the interface methods on an enumerator
19710 type that derived from IEnumerator and was in another assembly. For example:
19712 public class MyEnumerator : IEnumerator
19714 Would have the interface methods called, even if there were public impls of the
19715 method. In a struct, this lead to invalid IL code.
19717 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19719 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19722 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19724 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19726 * cs-parser.jay: Fix small regression: we were not testing V2
19727 compiler features correctly.
19729 * interface.cs: If the emit context is null, then create one
19731 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19733 * decl.cs (GetSignatureForError): New virtual method to get full name
19734 for error messages.
19736 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19737 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19739 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19740 Duplicated members and code in these classes has been removed.
19741 Better encapsulation in these classes.
19743 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19745 * assign.cs (Assign.DoResolve): When dealing with compound
19746 assignments, there is a new rule in ECMA C# 2.4 (might have been
19747 there before, but it is documented here) that states that in:
19751 If b is of type int, and the `op' is a shift-operator, then the
19752 above is evaluated as:
19756 * expression.cs (Binary.ResolveOperator): Instead of testing for
19757 int/uint/long/ulong, try to implicitly convert to any of those
19758 types and use that in pointer arithmetic.
19760 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19761 method to print information for from the type, not from the
19762 null-method we were given.
19764 2004-02-01 Duncan Mak <duncan@ximian.com>
19766 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19767 parsing for cmd, fixes bug #53694.
19769 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19771 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19772 in the member name duplication tests. Property and operator name duplication
19773 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19775 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19777 * interface.cs (PopulateMethod): Fixed crash when interface method
19778 returns not existing type (error test cs0246-3.cs).
19780 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19782 * cs-parser.jay (interface_accessors): Re-write actions to also
19783 store attributes attached to get and set methods. Fix spelling
19786 (inteface_property_declaration): Modify accordingly.
19788 (InterfaceAccessorInfo): New helper class to store information to pass
19789 around between rules that use interface_accessors.
19791 * interface.cs (Emit): Apply attributes on the get and set
19792 accessors of properties and indexers too.
19794 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19795 right MethodBuilder when applying attributes to the get and set accessors.
19797 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19799 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19801 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19803 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19805 2004-01-25 Miguel de Icaza <miguel@ximian.com>
19807 * cs-parser.jay: Remove YIELD token, instead use the new grammar
19808 changes that treat `yield' specially when present before `break'
19809 or `return' tokens.
19811 * cs-tokenizer.cs: yield is no longer a keyword.
19813 2004-01-23 Marek Safar <marek.safar@seznam.cz>
19815 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
19816 setting for default constructors.
19817 For default constructors are almost every time set wrong Modifier. The
19818 generated IL code has been alright. But inside mcs this values was
19819 wrong and this was reason why several of my CLS Compliance tests
19822 2004-01-22 Martin Baulig <martin@ximian.com>
19824 * cs-parser.jay (namespace_or_type_name): Return an Expression,
19825 not a QualifiedIdentifier. This is what `type_name_expression'
19826 was previously doing.
19827 (type_name_expression): Removed; the code is now in
19828 `namespace_or_type_name'.
19829 (qualified_identifier): Removed, use `namespace_or_type_name'
19831 (QualifiedIdentifier): Removed this class.
19833 2004-01-22 Martin Baulig <martin@ximian.com>
19835 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
19836 not a string as alias name.
19838 2004-01-21 Miguel de Icaza <miguel@ximian.com>
19840 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
19841 #52730 bug, and instead compute correctly the need to use a
19842 temporary variable when requesting an address based on the
19843 static/instace modified of the field and the constructor.
19845 2004-01-21 Martin Baulig <martin@ximian.com>
19847 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
19848 class and namespace before looking up aliases. Fixes #52517.
19850 2004-01-21 Martin Baulig <martin@ximian.com>
19852 * flowanalysis.cs (UsageVector.Merge): Allow variables being
19853 assinged in a 'try'; fixes exception4.cs.
19855 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19856 * class.cs : Implemented parameter-less constructor for TypeContainer
19858 * decl.cs: Attributes are now stored here. New property OptAttributes
19860 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
19862 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
19864 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19866 * typemanager.cs (CSharpSignature): Now reports also inner class name.
19867 (CSharpSignature): New method for indexer and property signature.
19869 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19871 * pending.cs (IsVirtualFilter): Faster implementation.
19873 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19875 * typemanager.cs: Avoid inclusion of same assembly more than once.
19877 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19879 * cs-parser.jay: Fixed problem where the last assembly attribute
19880 has been applied also to following declaration (class, struct, etc.)
19882 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19884 * class.cs: Added error CS0538, CS0539 reporting.
19885 Fixed crash on Microsoft runtime when field type is void.
19887 * cs-parser.jay: Added error CS0537 reporting.
19889 * pending.cs: Added error CS0535 reporting.
19890 Improved error report for errors CS0536, CS0534.
19892 2004-01-20 Miguel de Icaza <miguel@ximian.com>
19894 Merge a few bits from the Anonymous Method MCS tree.
19896 * statement.cs (ToplevelBlock): New class for toplevel methods,
19897 will hold anonymous methods, lifted variables.
19899 * cs-parser.jay: Create toplevel blocks for delegates and for
19900 regular blocks of code.
19902 2004-01-20 Martin Baulig <martin@ximian.com>
19904 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
19905 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
19906 and `NeedExplicitReturn'; added `IsLastStatement'.
19907 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
19908 have a `ReturnLabel' or we're not unreachable.
19910 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
19911 child's reachability; don't just override ours with it. Fixes
19912 #58058 (lluis's example).
19913 (FlowBranching): Added public InTryOrCatch(), InCatch(),
19914 InFinally(), InLoop(), InSwitch() and
19915 BreakCrossesTryCatchBoundary() methods.
19917 * statement.cs (Return): Do all error checking in Resolve().
19918 Unless we are the last statement in a top-level block, always
19919 create a return label and jump to it.
19920 (Break, Continue): Do all error checking in Resolve(); also make
19921 sure we aren't leaving a `finally'.
19922 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
19923 statement in a top-level block.
19924 (Block.Flags): Added `IsDestructor'.
19925 (Block.IsDestructor): New public property.
19927 2004-01-20 Martin Baulig <martin@ximian.com>
19929 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
19931 2004-01-20 Martin Baulig <martin@ximian.com>
19933 * statement.cs (Statement.ResolveUnreachable): New public method.
19934 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
19935 (Block.Resolve): Resolve unreachable statements.
19937 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19939 * expression.cs: We need to fix the case where we do
19940 not have a temp variable here.
19942 * assign.cs: Only expression compound assignments need
19943 temporary variables.
19945 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19947 * flowanalysis.cs: Reduce memory allocation in a few ways:
19948 - A block with no variables should not allocate a bit
19950 - A method with no out parameters does not need any tracking
19951 for assignment of the parameters, so we need not allocate
19954 public readonly Type[] VariableTypes;
19955 public readonly string[] VariableNames;
19956 Are redundant. The data is already stored in the variable
19957 map, so we need not allocate another array for it.
19958 - We need to add alot of checks for if (params | locals) == null
19959 due to the first two changes.
19961 2004-01-18 Miguel de Icaza <miguel@ximian.com>
19963 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
19964 implement IMemoryLocation, we store a copy on a local variable and
19965 take the address of it. Patch from Benjamin Jemlich
19967 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
19968 to use a special "type_name_expression" rule which reduces the
19969 number of "QualifiedIdentifier" classes created, and instead
19970 directly creates MemberAccess expressions.
19972 2004-01-17 Miguel de Icaza <miguel@ximian.com>
19974 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
19975 that fixes #52853. Null literal assignment to ValueType
19977 * class.cs (MethodData.Emit): Instead of checking the name of the
19978 method to determine if its a destructor, create a new derived
19979 class from Method called Destructor, and test for that.
19981 * cs-parser.jay: Create a Destructor object instead of a Method.
19983 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
19987 2004-01-16 Miguel de Icaza <miguel@ximian.com>
19989 * expression.cs (Binary.ResolveOperator): Perform an implicit
19990 conversion from MethodGroups to their delegate types on the
19991 Addition operation.
19993 * delegate.cs: Introduce a new class DelegateCreation that is the
19994 base class for `NewDelegate' and `ImplicitDelegateCreation',
19995 factor some code in here.
19997 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
19998 conversion from MethodGroups to compatible delegate types.
20000 * ecore.cs (Expression.Resolve): Do not flag error 654
20001 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20002 we allow conversions from MethodGroups to delegate types now.
20004 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20005 assignments in v2 either.
20007 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20009 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20010 static read-only fields in ctors.
20012 Applied patch from Benjamin Jemlich
20014 * expression.cs (UnaryMutator): Avoid leaking local variables.
20016 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20018 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20019 here to return true, as they can be used like this:
20021 (XXX) int.MEMBER ()
20023 Fixed 49836 and all the other dups
20025 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20027 * driver.cs: Implement /win32res and /win32icon.
20029 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20031 * cs-parser.jay: Add a rule to improve error handling for the
20032 common mistake of placing modifiers after the type.
20034 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20036 * cs-parser.jay (interface_event_declaration): Catch
20037 initialization of events on interfaces, and report cs0068
20039 * cs-parser.jay (interface_event_declaration): Catch
20040 initialization of events.
20042 * ecore.cs: Better report missing constructors.
20044 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20045 the error reporting done in the wrong place. Fix.
20047 * expression.cs (Binary.ResolveOperator): Catch the
20048 operator + (E x, E y) error earlier, and later allow for implicit
20049 conversions in operator +/- (E e, U x) from U to the underlying
20052 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20053 52596, if the container class is abstract, the default constructor
20054 is protected otherwise its public (before, we were always public).
20056 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20059 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20060 Jemlich that fixes bug #52597, MCS was generating invalid code for
20061 idisposable structs. Thanks to Ben for following up with this
20064 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20066 * driver.cs: Allow assemblies without code to be generated, fixes
20069 2004-01-07 Nick Drochak <ndrochak@gol.com>
20071 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20073 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20075 * cs-parser.jay: Add rules to improve error reporting if fields or
20076 methods are declared at the namespace level (error 116)
20078 * Add rules to catch event add/remove
20080 2004-01-04 David Sheldon <dave-mono@earth.li>
20082 * expression.cs: Added matching ")" to error message for
20085 2004-01-03 Todd Berman <tberman@gentoo.org>
20087 * ecore.cs, attribute.cs:
20088 Applying fix from #52429.
20090 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20092 * ecore.cs, expression.cs, statement.cs:
20093 Total rewrite of how we handle branching. We
20094 now handle complex boolean expressions with fewer
20095 jumps. As well if (x == 0) no longer emits a ceq.
20097 if (x is Foo) is much faster now, because we generate
20100 Overall, we get a pretty big improvement on our benchmark
20101 tests. The code we generate is smaller and more readable.
20103 I did a full two-stage bootstrap. The patch was reviewed
20104 by Martin and Miguel.
20106 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20108 * cs-parser.jay: Make primary_expression not take a QI.
20109 we dont need this because the member_access rule covers
20110 us here. So we replace the rule with just IDENTIFIER.
20112 This has two good effects. First, we remove a s/r conflict.
20113 Second, we allocate many fewer QualifiedIdentifier objects.
20115 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20117 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20118 set the correct information via SRE. This prevents
20119 hanging on the MS runtime. Fixes #29374.
20121 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20123 * convert.cs: correctly handle conversions to value types
20124 from Enum and ValueType as unboxing conversions.
20126 Fixes bug #52569. Patch by Benjamin Jemlich.
20128 2004-01-02 Ravi Pratap <ravi@ximian.com>
20130 * expression.cs (BetterConversion): Prefer int -> uint
20131 over int -> ulong (csc's behaviour). This fixed bug #52046.
20133 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20135 * decl.cs (MemberCache.FindMembers): now returns a
20138 * typemanager.cs: In general, go with with ^^.
20139 (CopyNewMethods): take an IList.
20140 (RealMemberLookup): Only allocate an arraylist
20141 if we copy from two sets of methods.
20143 This change basically does two things:
20144 1) Fewer array lists allocated due to CopyNewMethods.
20145 2) the explicit cast in MemberList costed ALOT.
20147 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20149 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20150 a hashtable to avoid needless string allocations when an identifier is
20151 used more than once (the common case).
20153 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20155 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20156 is broken, it will not return anything. So, we
20157 have to use the information we have in mcs to
20160 * typemanager.cs: Add a cache for GetInterfaces,
20161 since this will now be used more often (due to ^^)
20163 (GetExplicitInterfaces) New method that gets the
20164 declared, not effective, interfaces on a type
20165 builder (eg, if you have interface IFoo, interface
20166 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20169 This patch makes MCS able to bootstrap itself on
20172 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20174 * expression.cs: Remove the Nop's that Miguel put
20177 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20179 * report.cs, codegen.cs: Give the real stack trace to
20180 the error when an exception is thrown.
20182 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20184 * decl.cs: only allocate hashtables for ifaces if
20187 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20189 * expression.cs: fix the error from cs0121-2.cs
20190 (a parent interface has two child interfaces that
20191 have a function with the same name and 0 params
20192 and the function is called through the parent).
20194 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20196 * class.cs, rootcontext.cs, typmanager.cs: do not
20199 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20201 * codegen.cs: remove stack for the ec flow branching.
20202 It is already a linked list, so no need.
20204 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20206 * Makefile: Allow custom profiler here.
20208 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20210 * typemanager.cs (LookupType):
20211 - Use a static char [], because split takes
20212 a param array for args, so it was allocating
20214 - Do not store true in a hashtable, it boxes.
20216 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20218 * flowanalysis.cs: bytify common enums.
20220 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20222 * modifiers.cs: Add a new set of flags for the
20223 flags allowed on explicit interface impls.
20224 * cs-parser.jay: catch the use of modifiers in
20225 interfaces correctly.
20226 * class.cs: catch private void IFoo.Blah ().
20228 All related to bug #50572.
20230 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20232 * decl.cs: Rewrite the consistant accessability checking.
20233 Accessability is not linear, it must be implemented in
20234 a tableish way. Fixes #49704.
20236 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20238 * expression.cs: Handle negation in a checked context.
20239 We must use subtraction from zero. Fixes #38674.
20241 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20243 * class.cs: Ignore static void main in DLLs.
20244 * rootcontext.cs: Handle the target type here,
20245 since we are have to access it from class.cs
20246 * driver.cs: account for the above.
20248 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20250 * report.cs: Give line numbers and files if available.
20252 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20254 * driver.cs: Implement /addmodule.
20256 * typemanager.cs: Change 'modules' field so it now contains Modules not
20259 2003-12-20 Martin Baulig <martin@ximian.com>
20261 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20262 (FieldBase.IsAssigned): Removed this field.
20263 (FieldBase.SetAssigned): New public method.
20264 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20266 2003-12-20 Martin Baulig <martin@ximian.com>
20268 * expression.cs (LocalVariableReference.DoResolve): Don't set
20269 `vi.Used' if we're called from DoResolveLValue().
20271 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20272 returns the usage vector it just merged into the current one -
20273 pass this one to UsageWarning().
20274 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20275 of the `EmitContext', don't call this recursively on our children.
20277 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20279 * driver.cs: Implement /target:module.
20281 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20283 * support.cs (CharArrayHashtable): New helper class.
20285 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20286 char arrays, not strings, so we can avoid creating a string in
20287 consume_identifier if the identifier is a keyword.
20289 2003-12-16 Martin Baulig <martin@ximian.com>
20291 * statement.cs (LocalInfo.Assigned): Removed this property.
20292 (LocalInfo.Flags): Removed `Assigned'.
20293 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20294 and uses flow analysis.
20295 (Block.UsageWarning): Made this method private.
20296 (Block.Resolve): Call UsageWarning() if appropriate.
20298 * expression.cs (LocalVariableReference.DoResolve): Always set
20299 LocalInfo.Used here.
20301 2003-12-13 Martin Baulig <martin@ximian.com>
20303 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20304 any value here; we're now using flow analysis to figure out
20305 whether a statement/block returns a value.
20307 2003-12-13 Martin Baulig <martin@ximian.com>
20309 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20311 (FlowBranching.MergeFinally): Don't call
20312 `branching.CheckOutParameters()' here, this is called in
20314 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20315 when adding the `finally' vector.
20317 2003-12-13 Martin Baulig <martin@ximian.com>
20320 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20321 actually work and also fix #48962.
20323 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20325 * decl.cs: Do not check System.Object for nested types,
20326 since we know it does not have any. Big bang for buck:
20329 Run 1: 8.35 seconds
20330 Run 2: 8.32 seconds
20331 corlib: 17.99 seconds
20333 Run 1: 8.17 seconds
20334 Run 2: 8.17 seconds
20335 corlib: 17.39 seconds
20337 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20339 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20340 time we are returning 0 members, so we save alot here.
20342 2003-12-11 Martin Baulig <martin@ximian.com>
20344 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20345 `MergeChild()', also just take the `FlowBranching' as argument;
20346 call Merge() on it and return the result.
20347 (FlowBranching.Merge): We don't need to do anything if we just
20350 2003-12-11 Martin Baulig <martin@ximian.com>
20352 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20353 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20354 Maurer for this idea.
20356 2003-12-11 Martin Baulig <martin@ximian.com>
20358 * flowanalysis.cs (MergeResult): This class is now gone; we now
20359 use the `UsageVector' for this. The reason for this is that if a
20360 branching just has one sibling, we don't need to "merge" them at
20361 all - that's the next step to do.
20362 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20365 2003-12-11 Martin Baulig <martin@ximian.com>
20367 Reworked flow analyis and made it more precise and bug-free. The
20368 most important change is that we're now using a special `Reachability'
20369 class instead of having "magic" meanings of `FlowReturns'. I'll
20370 do some more cleanups and optimizations and also add some more
20371 documentation this week.
20373 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20374 largely reworked this class.
20375 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20376 the new `Reachability' class instead of having "magic" values here.
20377 (FlowBranching): We're now using an instance of `Reachability'
20378 instead of having separate `Returns', `Breaks' etc. fields.
20380 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20381 based on flow analysis; ignore the return value of block.Emit ().
20383 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20385 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20386 if they are private.
20388 2003-12-09 Martin Baulig <martin@ximian.com>
20390 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20391 call them directly on the UsageVector.
20393 2003-12-09 Martin Baulig <martin@ximian.com>
20395 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20396 Changed return type from `FlowReturns' to `Reachability'.
20398 2003-12-09 Martin Baulig <martin@ximian.com>
20400 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20401 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20402 `Reachable' fields with a single `Reachability' one.
20404 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20406 * class.cs (FindMembers): Remove foreach's.
20411 Run 1: 8.74 seconds
20412 Run 2: 8.71 seconds
20415 Run 1: 8.64 seconds
20416 Run 2: 8.58 seconds
20419 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20424 This patch does a few things:
20425 1. EmptyStatement is now a singleton, so it is never reallocated.
20426 2. All blah is EmptyStatement constructs have been changed to
20427 blah == EmptyStatement.Value, which is much faster and valid
20428 now that EmptyStatement is a singleton.
20429 3. When resolving a block, rather than allocating a new array for
20430 the non-empty statements, empty statements are replaced with
20431 EmptyStatement.Value
20432 4. Some recursive functions have been made non-recursive.
20433 Mainly the performance impact is from (3), however (1) and (2) are needed for
20434 this to work. (4) does not make a big difference in normal situations, however
20435 it makes the profile look saner.
20440 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20441 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20442 Total memory allocated: 56397 KB
20445 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20446 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20447 Total memory allocated: 55666 KB
20449 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20451 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20452 than the hashtable in a hashtable version
20454 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20455 we always end up concating a string. This results in a huge perf
20456 loss, because many strings have to be tracked by the GC. In this
20457 patch, we first use a hashtable that works with two keys, so that
20458 the strings do not need to be concat'ed.
20462 Run 1: 8.74 seconds
20463 Run 2: 8.71 seconds
20466 Run 1: 8.65 seconds
20467 Run 2: 8.56 seconds
20469 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20471 * Makefile: Add a new target `do-time' that does a quick and simple
20472 profile, leaving easy to parse output.
20474 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20476 * codegen.cs (Init): Create the dynamic assembly with
20477 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20479 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20481 * support.cs: Make the PtrHashtable use only one
20482 instance of its comparer.
20484 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20486 * typemanager.cs: Fix lookup of GetNamespaces.
20488 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20490 * expression.cs: Removed redundant line.
20492 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20493 ArrayLists, use for loops with bounds.
20495 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20498 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20499 arraylists, use for loop with bounds.
20501 The above three changes give us a 0.071 second performance
20502 improvement out of 3.294 seconds down to 3.223. On my machine
20503 the above changes reduced the memory usage by 1,387 KB during
20504 compiler bootstrap.
20506 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20507 QualifiedIdentifiers. Before we created a new string through
20508 concatenation, and mostly later on, the result would be
20509 manipulated by DecomposeQI through string manipulation.
20511 This reduced the compiler memory usage for bootstrapping from
20512 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20513 compile times in 0.05 seconds.
20515 2003-11-28 Dick Porter <dick@ximian.com>
20517 * support.cs: Do string compares with the Invariant culture.
20525 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20526 the comparison is done with the Invariant culture.
20528 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20530 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20531 GetEnumerator method.
20533 (ProbeCollectionType): Iterate starting at the most specific type
20534 upwards looking for a GetEnumerator
20536 * expression.cs: Shift count can be up to 31 for int/uint and 63
20539 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20541 * statement.cs (Block.LookupLabel): Also look for the label on the
20542 children blocks. Use a hash table to keep track of visited
20545 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20546 we actually did transform the other operand, otherwise fall back
20547 to the common codepath that casts to long.
20549 * cs-tokenizer.cs: Use the same code pattern as the int case.
20550 Maybe I should do the parsing myself, and avoid depending on the
20551 Parse routines to get this done.
20553 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20555 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20556 which fixes bug 51347. This time test it.
20558 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20559 attributes for example can not tell the difference between these.
20560 The difference was only a syntax feature of the language.
20562 * attribute.cs: Apply attributes to delegates.
20564 * delegate.cs: Call the apply attributes method.
20566 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20568 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20569 comparing 0 vs Byte.MinValue, not the value
20571 (ImplicitConversionRequired): When reporting a conversion error,
20572 use error 31 to print out the constant error instead of the
20575 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20576 which fixes bug 51347.
20578 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20580 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20581 which fixes the -warnaserror command line option.
20583 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20585 * cfold.cs (DoNumericPromotions): During constant folding of
20586 additions on UIntConstant, special case intconstants with
20587 IntConstants like we do on the expression binary operator.
20589 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20591 * convert.cs (ImplicitReferenceConversion): We were missing a case
20592 (System.Enum are not value types or class types, so we need to
20593 classify them separatedly).
20595 * driver.cs: We do not support error 2007.
20597 2003-11-12 Jackson Harper <jackson@ximian.com>
20599 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20600 system directory. Also use the full file name so users can
20601 libraries names mscorlib-o-tron.dll in a non system dir.
20603 2003-11-10 Martin Baulig <martin@ximian.com>
20605 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20606 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20607 calling `ResolveType()' on them, directly assign their `Type'.
20609 2003-11-08 Martin Baulig <martin@ximian.com>
20611 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20612 return value and the `out parent' parameter.
20613 (TypeContainer.DefineType): Moved the CS0644 check into
20614 GetClassBases(). Don't pass the interface types to the
20615 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20616 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20618 * ecore.cs (TypeExpr.IsAttribute): New property.
20619 (TypeExpr.GetInterfaces): New method.
20621 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20622 TypeExpr instead of a Type.
20623 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20624 (Interface.DefineType): Don't pass the interface types to the
20625 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20626 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20628 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20629 instead of a `Type[]'.
20630 (TypeManager.RegisterBuilder): Likewise.
20631 (TypeManager.AddUserInterface): Likewise.
20632 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20633 `Type[]' and also return a `TypeExpr[]'.
20634 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20636 2003-11-08 Martin Baulig <martin@ximian.com>
20638 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20641 2003-11-08 Martin Baulig <martin@ximian.com>
20643 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20644 TypeManager.ResolveExpressionTypes().
20646 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20647 instead of an Expression.
20648 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20649 (TypeExpression): New public class; formerly known as `TypeExpr'.
20651 * expression.cs (ComposedCast): Derive from TypeExpr.
20653 * typemanager.cs (TypeManager.system_*_expr): These are now
20654 TypExpr's instead of Expression's.
20655 (TypeManager.ResolveExpressionTypes): New public static function;
20656 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20659 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20661 * expression.cs (New.DoResolve): Do not dereference value that
20662 might be a null return.
20664 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20665 sure that the constant value has the right type. Fixes an
20666 unreported bug, similar to 50425.
20668 * const.cs (Const.LookupConstantValue): Call
20669 ImplicitStandardConversionExists before doing a conversion to
20670 avoid havng the TypeManager.ChangeType do conversions.
20672 Reduced the number of casts used
20674 (Const.ChangeType): New routine to enable reuse of the constant
20675 type changing code from statement.
20677 * typemanager.cs (ChangeType): Move common initialization to
20678 static global variables.
20682 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20683 every value type to go through, even if it was void. Fix that.
20685 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20686 character of the define, and the is_identifier_part_character for
20687 the rest of the string.
20689 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20691 * expression.cs (UnaryMutator.EmitCode): When I updated
20692 LocalVariableReference.DoResolve, I overdid it, and dropped an
20693 optimization done on local variable references.
20695 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20697 * ecore.cs: Convert the return from Ldlen into an int.
20699 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20701 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20702 the accessibility, this is a special case for toplevel non-public
20703 classes (internal for instance).
20705 2003-10-20 Nick Drochak <ndrochak@gol.com>
20707 * ecore.cs: Fix typo and build. Needed another right paren.
20709 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20711 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20712 `internal' case regular and protected, but not allowing protected
20713 to be evaluated later. Bug 49840
20715 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20717 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20718 to kb.Nlast, and not the kb.nFirst to isolate the switch
20721 Extract the underlying type, so enumerations of long/ulong are
20722 treated like long/ulong.
20724 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20726 * expression.cs (New): Overload the meaning of RequestedType to
20727 track the possible creation of the NewDelegate type, since
20728 DoResolve is invoked more than once for new constructors on field
20731 See bugs: #48800 and #37014
20733 * cs-parser.jay (declare_local_constants): Take an arraylist
20734 instead of a single constant.
20736 (local_constant_declaration): It should take a
20737 constant_declarators, not a constant_declarator. Fixes 49487
20739 * convert.cs: Fix error report.
20741 2003-10-13 Jackson Harper <jackson@ximian.com>
20743 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20746 2003-10-09 Martin Baulig <martin@ximian.com>
20748 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20750 (MethodCore.DoDefineParameters): Removed the TypeContainer
20751 argument; use the DeclSpace which was passed to the .ctor instead.
20752 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20753 TypeContainer; we only need a DeclSpace here.
20755 2003-10-09 Martin Baulig <martin@ximian.com>
20757 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20759 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20760 EmitContext's .ctor.
20762 2003-10-09 Martin Baulig <martin@ximian.com>
20764 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20765 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20766 AsAccessible(), moved them as well.
20768 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20770 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20772 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20774 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20776 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20777 generation for >=, as spotted by Paolo, bug 48679.
20778 Patch from David Waite.
20780 * cs-tokenizer.cs: Add handling for #pragma.
20782 * cs-parser.jay: Allow for both yield and yield return in the
20783 syntax. The anti-cobolization of C# fight will go on!
20785 * class.cs (TypeBuilder.DefineType): Catch error condition here
20786 (Parent.DefineType erroring out and returning null).
20788 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20789 coping with enumerations variables, we were mistakenly processing
20790 them as a regular value type instead of built-in types. Fixes the
20793 * typemanager.cs (IsBuiltinOrEnum): New method.
20795 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20797 * cs-parser.jay: Upgrade: yield now needs the return clause.
20799 2003-09-19 Martin Baulig <martin@ximian.com>
20801 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20802 `MemberCache parent' argument. Normally, an interface doesn't
20803 have a parent type except System.Object, but we use this in gmcs
20804 for generic type parameters.
20806 2003-09-18 Martin Baulig <martin@ximian.com>
20808 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
20809 on `type.IsInterface'; don't check whether the type has a parent
20810 to determine whether it's an interface.
20812 2003-09-15 Martin Baulig <martin@ximian.com>
20814 * class.cs (TypeContainer.DefineType): Added an error flag to
20815 avoid reporting duplicate CS0146's ("class definition is
20818 * driver.cs (Driver.MainDriver): Abort if
20819 RootContext.ResolveTree() reported any errors.
20821 2003-09-07 Martin Baulig <martin@ximian.com>
20823 * report.cs (Error, Warning): Added overloaded versions which take
20824 a `params object[] args' and call String.Format().
20826 2003-09-07 Martin Baulig <martin@ximian.com>
20828 * decl.cs (DeclSpace..ctor): Don't call
20829 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
20830 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
20831 (DeclSpace.RecordDecl): New method.
20833 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
20835 2003-09-02 Ravi Pratap <ravi@ximian.com>
20837 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
20838 value attributes to be applied to ParameterBuilders.
20840 * class.cs (MethodCore.LabelParameters): Make static and more
20841 generic so that it can be used from other places - like interface
20842 methods, for instance.
20844 * interface.cs (Interface.Emit): Call LabelParameters before
20845 emitting attributes on the InterfaceMethod.
20847 2003-08-26 Martin Baulig <martin@ximian.com>
20849 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
20850 resolving aliases; fixes #47927.
20852 2003-08-26 Martin Baulig <martin@ximian.com>
20854 * statement.cs (Using.DoResolve): This is internally emitting a
20855 try/finally clause, so we need to set ec.NeedExplicitReturn if we
20856 do not always return. Fixes #47681.
20858 2003-08-26 Martin Baulig <martin@ximian.com>
20860 * decl.cs (MemberCore): Moved WarningNotHiding(),
20861 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
20863 (AdditionResult): Make this nested in DeclSpace.
20864 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
20865 argument; call NamespaceEntry.Define() unless we're nested in a
20868 * namespace.cs (Namespace.DefineName): New public function. This
20869 is called from DeclSpace's .ctor to add
20870 (Namespace.Lookup): Include DeclSpaces in the lookup.
20872 * class.cs (Operator): Derive from MemberBase, not MemberCore.
20874 * const.cs (Const): Derive from MemberBase, not MemberCore.
20876 2003-08-25 Martin Baulig <martin@ximian.com>
20878 * convert.cs (Convert.ExplicitReferenceConversion): When
20879 converting from an interface type to a class, unbox if the target
20880 type is a struct type. Fixes #47822.
20882 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20884 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
20887 2003-08-22 Martin Baulig <martin@ximian.com>
20889 * class.cs (TypeManager.DefineType): When defining a nested type,
20890 call DefineType() on our parent; fixes #47801.
20892 2003-08-22 Martin Baulig <martin@ximian.com>
20894 * class.cs (MethodData.Define): While checking if a method is an
20895 interface implementation, improve the test a bit more to fix #47654.
20897 2003-08-22 Martin Baulig <martin@ximian.com>
20899 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
20900 correctly; fixes #47722.
20902 2003-08-22 Martin Baulig <martin@ximian.com>
20904 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
20905 LocalVariableReference, ensure it's not read-only. Fixes #47536.
20907 * statement.cs (Fixed.DoResolve): Make all variables read-only.
20909 2003-08-22 Martin Baulig <martin@ximian.com>
20911 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
20912 can only be assigned in static constructors. Fixes #47161.
20914 2003-08-22 Martin Baulig <martin@ximian.com>
20916 Rewrote and improved the flow analysis code.
20918 * flowbranching.cs (FlowBranching): Make this class abstract.
20919 (FlowBranching.CreateBranching): New static function to create a
20920 new flow branching.
20921 (FlowBranchingBlock, FlowBranchingException): New classes.
20922 (FlowBranching.UsageVector.Type): New public readonly field.
20923 (FlowBranching.UsageVector.Breaks): Removed the setter.
20924 (FlowBranching.UsageVector.Returns): Removed the setter.
20925 (FlowBranching.UsageVector): Added Break(), Return(),
20926 NeverReachable() and Throw() methods to modify the reachability.
20927 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
20928 done by FlowBranching.Merge().
20929 (FlowBranching.UsageVector.MergeChild): New method; merges the
20930 merge result into the current vector.
20931 (FlowBranching.Merge): New abstract method to merge a branching.
20933 2003-08-12 Martin Baulig <martin@ximian.com>
20935 * expression.cs (Indirection.CacheTemporaries): Create the
20936 LocalTemporary with the pointer type, not its element type.
20938 2003-08-10 Miguel de Icaza <miguel@ximian.com>
20940 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
20941 token was a keyword or not.
20943 Add `error' options where an IDENTIFIER was expected; Provide
20944 CheckToken and CheckIdentifierToken convenience error reporting
20947 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
20949 * decl.cs: Rename `NamespaceEntry Namespace' public field into
20950 NameSpaceEntry NameSpaceEntry.
20952 (LookupInterfaceOrClass): Avoid creating a full qualified name
20953 from namespace and name: avoid doing lookups when we know the
20954 namespace is non-existant. Use new Tree.LookupByNamespace which
20955 looks up DeclSpaces based on their namespace, name pair.
20957 * driver.cs: Provide a new `parser verbose' to display the
20958 exception thrown during parsing. This is turned off by default
20959 now, so the output of a failure from mcs is more graceful.
20961 * namespace.cs: Track all the namespaces defined in a hashtable
20964 (IsNamespace): New method
20966 2003-08-09 Miguel de Icaza <miguel@ximian.com>
20968 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
20969 we know that we need to concatenate (full typename can never be
20974 * statement.cs: Use a bitfield; Do not initialize to null things
20975 which are done by the constructor by default.
20977 * cs-parser.jay: bug fix, parameter was 4, not 3.
20979 * expression.cs: Just use the property;
20981 * statement.cs: No need for GetVariableInfo method.
20983 2003-08-08 Martin Baulig <martin@ximian.com>
20985 * flowanalysis.cs (FlowReturns): This is now nested in the
20986 `FlowBranching' class.
20987 (MyBitVector): Moved this here from statement.cs.
20988 (FlowBranching.SiblingType): New enum type.
20989 (FlowBranching.CreateSibling): Added `SiblingType' argument.
20991 2003-08-07 Martin Baulig <martin@ximian.com>
20993 * flowanalysis.cs (FlowBranchingType): This is now nested in the
20994 `FlowBranching' class and called `BranchingType'.
20996 2003-08-07 Martin Baulig <martin@ximian.com>
20998 * flowanalysis.cs: Moved all the control flow analysis code into
21001 2003-08-07 Martin Baulig <martin@ximian.com>
21003 * assign.cs (Assign.DoResolve): `target' must either be an
21004 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21007 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21009 * expression.cs (BinaryMethod): This kind of expression is created by the
21010 Binary class if it determines that the operator has to be handled
21013 (BinaryDelegate): This kind of expression is created if we are
21014 dealing with a + or - operator on delegates.
21016 (Binary): remove method, argumetns, and DelegateOperator: when
21017 dealing with methods,
21019 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21021 * statement.cs (Block): use bitfields for the three extra booleans
21022 we had in use. Remove unused topblock parameter.
21024 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21026 * assign.cs: Drop extra unneeded tests.
21028 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21030 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21032 * statement.cs (Foreach): Use VariableStorage instead of
21035 * codegen.cs (VariableStorage): New class used by clients that
21036 require a variable stored: locals or fields for variables that
21037 need to live across yield.
21039 Maybe provide a convenience api for EmitThis+EmitLoad?
21041 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21044 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21046 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21047 RemapParameterLValue): New methods that are used to turn a
21048 precomputed FieldInfo into an expression like this:
21052 The idea is to use this instead of making LocalVariableReference
21053 have more than one meaning.
21055 * cs-parser.jay: Add error production to BASE.
21057 * ecore.cs: Deal with TypeManager.GetField returning null, which
21058 is now a valid return value.
21060 (FieldExprNoAddress): New expression for Fields whose address can
21063 * expression.cs (LocalVariableReference): During the resolve
21064 phases, create new expressions if we are in a remapping context.
21065 Remove code that dealt with remapping here.
21067 (ParameterReference): same.
21069 (ProxyInstance): New expression, like the `This' expression, but
21070 it is born fully resolved. We know what we are doing, so remove
21071 the errors that are targeted to user-provided uses of `this'.
21073 * statement.cs (Foreach): our variable is now stored as an
21074 Expression; During resolution, follow the protocol, dont just
21075 assume it will return this.
21077 2003-08-06 Martin Baulig <martin@ximian.com>
21079 * support.cs (SeekableStreamReader.cs): New public class.
21081 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21082 SeekableStreamReader instead of the normal StreamReader.
21084 2003-08-04 Martin Baulig <martin@ximian.com>
21086 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21087 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21088 deambiguate casts and delegate invocations.
21089 (parenthesized_expression): Use the new tokens to ensure this is
21090 not a cast of method invocation.
21092 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21093 when reading a `)' and Deambiguate_CloseParens () was previously
21096 * expression.cs (ParenthesizedExpression): New class. This is
21097 just used for the CS0075 test.
21098 (Binary.DoResolve): Check for CS0075.
21100 2003-07-29 Ravi Pratap <ravi@ximian.com>
21102 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21103 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21104 reference comparison.
21106 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21107 examine the ReturnType for equality - this is necessary in the
21108 cases of implicit and explicit operators whose signature also
21109 includes the return type.
21111 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21113 * namespace.cs: Cache the result of the namespace computation,
21114 instead of computing it every time.
21116 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21118 * decl.cs: Use a global arraylist that we reuse over invocations
21119 to avoid excesive memory consumption. Reduces memory usage on an
21120 mcs compile by one meg (45 average).
21122 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21123 private, work around that.
21125 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21127 * literal.cs (IntLiteral): Define Zero and One static literals.
21129 * cs-parser.jay (integer_literal): use static literals to reduce
21130 memory usage for the most used literals (0, 1 and -1). 211kb
21131 reduced in memory usage.
21133 Replace all calls to `new ArrayList' with `new
21134 ArrayList(4)' which is a good average number for most allocations,
21135 and also requires only 16 bytes of memory for its buffer by
21138 This reduced MCS memory usage in seven megabytes for the RSS after
21141 2003-07-28 Ravi Pratap <ravi@ximian.com>
21143 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21144 handle params methods the correct way by forming only one
21145 applicable set with params and normal methods in them. Earlier we
21146 were looking at params methods only if we found no normal methods
21147 which was not the correct thing to do.
21149 (Invocation.BetterFunction): Take separate arguments indicating
21150 when candidate and the best method are params methods in their
21153 This fixes bugs #43367 and #46199.
21155 * attribute.cs: Documentation updates.
21157 (CheckAttribute): Rename to CheckAttributeTarget.
21158 (GetValidPlaces): Rename to GetValidTargets.
21160 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21161 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21165 2003-07-28 Martin Baulig <martin@ximian.com>
21167 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21168 name when looking up the base class of a nested class. Fixes #46977.
21170 2003-07-26 Martin Baulig <martin@ximian.com>
21172 * expression.cs (Indexers.Indexer): New nested struct; contains
21173 getter, setter and the indexer's type.
21174 (Indexers.Properties): This is now an ArrayList of
21175 Indexers.Indexer's.
21176 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21177 indexer doesn't have any getters.
21179 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21180 for embedded property and indexer assignments.
21182 2003-07-26 Martin Baulig <martin@ximian.com>
21184 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21185 preprocessor directive is not the first non-whitespace character
21188 2003-07-26 Martin Baulig <martin@ximian.com>
21190 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21191 namespace parsing, follow the spec more closely.
21193 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21194 NamespaceEntry.Lookup().
21196 2003-07-25 Martin Baulig <martin@ximian.com>
21198 * MethodCore.cs (OverridesSomething): New public field; it's set
21199 from TypeContainer.DefineMembers if this method overrides
21200 something (which doesn't need to be a method). Fix #39462.
21202 2003-07-25 Ravi Pratap <ravi@ximian.com>
21204 * typemanager.cs (GetMembers): Ensure that the list of members is
21205 reversed. This keeps things in sync.
21207 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21208 find an AttributeUsage attribute.
21210 * expression.cs (Invocation.OverloadResolve): Perform the check
21211 which disallows Invoke to be directly called on a Delegate.
21213 (Error_InvokeOnDelegate): Report error cs1533.
21215 2003-07-25 Martin Baulig <martin@ximian.com>
21217 * expression.cs (Indexers.GetIndexersForType): Only look in the
21218 interface hierarchy if the requested type is already an
21219 interface. Fixes #46788 while keeping #46502 fixed.
21221 2003-07-25 Martin Baulig <martin@ximian.com>
21223 * class.cs (TypeContainer.DefineMembers): Check whether all
21224 readonly fields have been assigned and report warning CS0649 if
21227 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21230 2003-07-24 Ravi Pratap <ravi@ximian.com>
21232 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21233 returned from GetMethods to make things consistent with the
21234 assumptions MCS makes about ordering of methods.
21236 This should comprehensively fix bug #45127 and it does :-)
21238 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21239 ordering is actually reverse.
21241 * Clean up some debug messages I left lying around.
21243 * interface.cs (Populate*): Get rid of code which emits attributes
21244 since the stage in which we emit attributes is the 'Emit' stage,
21245 not the define stage.
21247 (Emit): Move attribute emission for interface members here.
21249 2003-07-22 Ravi Pratap <ravi@ximian.com>
21251 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21252 closely: we eliminate methods in base types when we have an
21253 applicable method in a top-level type.
21255 Please see section 14.5.5.1 for an exact description of what goes
21258 This fixes bug #45127 and a host of other related to corlib compilation.
21260 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21261 array is the method corresponding to the top-level type (this is
21262 because of the changes made to icall.c) so we change this
21265 (MethodGroupExpr.Name): This too.
21267 * typemanager.cs (GetElementType): New method which does the right
21268 thing when compiling corlib.
21270 * everywhere: Make use of the above in the relevant places.
21272 2003-07-22 Martin Baulig <martin@ximian.com>
21274 * cs-parser.jay (invocation_expression): Moved
21275 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21276 `cast_expression', but create a InvocationOrCast which later
21277 resolves to either an Invocation or a Cast.
21279 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21280 method; call this before EmitStatement() to make sure that this
21281 expression can be used as a statement.
21283 * expression.cs (InvocationOrCast): New class; resolves to either
21284 an Invocation or a Cast.
21286 * statement.cs (StatementExpression): Call ResolveStatement() on
21287 the ExpressionStatement before emitting it.
21289 2003-07-21 Martin Baulig <martin@ximian.com>
21291 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21292 `ref' and `out' attributes match; fixes #46220.
21293 (MemberAccess.ResolveMemberAccess): You can't reference a type
21294 through an expression; fixes #33180.
21295 (Indexers.GetIndexersForType): Don't return the indexers from
21296 interfaces the class implements; fixes #46502.
21298 2003-07-21 Martin Baulig <martin@ximian.com>
21300 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21301 CS0661 checks; fixes bug #30442.
21303 2003-07-21 Martin Baulig <martin@ximian.com>
21305 * decl.cs (AdditionResult): Added `Error'.
21307 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21309 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21310 makes cs0031.cs actually work.
21312 2003-07-20 Martin Baulig <martin@ximian.com>
21314 * namespace.cs: Fixed that bug which caused a crash when compiling
21315 the debugger's GUI.
21317 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21319 * typemanager.cs (LookupTypeReflection): Never expose types which
21320 are NotPublic, NestedPrivate, NestedAssembly, or
21321 NestedFamANDAssem. We used to return these, and later do a check
21322 that would report a meaningful error, but the problem is that we
21323 would not get the real match, if there was a name override.
21325 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21327 * namespace.cs (Namespace, Name): Do not compute the namespace
21328 name dynamically, compute it in the constructor. This reduced
21329 memory usage by 1697 KB.
21331 * driver.cs: Use --pause to pause at the end.
21333 2003-07-17 Peter Williams <peter@newton.cx>
21335 * Makefile: Change the name of the test target so that it doesn't
21336 conflict with the recursive test target.
21338 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21340 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21341 AddressOf): Do not use EmitThis, that was wrong, use the actual
21344 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21346 * class.cs (MethodData.Define): While checking if a method is an
21347 interface implementation, improve the test: If we are not public
21348 (use new test here: use the computed MethodAttributes directly,
21349 instead of the parsed modifier flags) check if the `implementing'
21350 method comes from an interface or not.
21352 * pending.cs (VerifyPendingMethods): Slightly better error
21355 * makefile: add test target that does the mcs bootstrap.
21357 2003-07-16 Ravi Pratap <ravi@ximian.com>
21359 * interface.cs (Define): Do nothing here since there are no
21360 members to populate etc. Move the attribute emission out of here
21361 since this was just totally the wrong place to put it. Attribute
21362 application happens during the 'Emit' phase, not in the 'Define'
21365 (Emit): Add this method and move the attribute emission here
21367 * rootcontext.cs (EmitCode): Call the Emit method on interface
21370 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21372 * expression.cs (OverloadResolve): Report error only if Location
21373 is not 'Null' which means that there was a probe going on.
21375 2003-07-14 Martin Baulig <martin@ximian.com>
21377 * expression.cs (ConditionalLogicalOperator): New public class to
21378 implement user defined conditional logical operators.
21379 This is section 14.11.2 in the spec and bug #40505.
21381 2003-07-14 Martin Baulig <martin@ximian.com>
21383 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21385 2003-07-14 Martin Baulig <martin@ximian.com>
21387 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21389 * ecore.cs (IVariable.VerifyFixed): New interface method.
21391 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21392 operator, check whether the variable is actually fixed. Fixes bug
21393 #36055. Set a variable definitely assigned when taking its
21394 address as required by the spec.
21396 * statement.cs (LocalInfo.IsFixed): New field.
21397 (LocalInfo.MakePinned): Set `IsFixed' to true.
21399 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21401 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21402 for .ctors, ensure that we only ask for members declared in the
21403 attribute type (BindingFlags.DeclaredOnly).
21407 * expression.cs (Error_WrongNumArguments): Report error 1501
21408 correctly the way CSC does.
21410 2003-07-13 Martin Baulig <martin@ximian.com>
21412 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21413 lookup on the fully qualified name, to make things like "X.X" work
21414 where "X.X" is a fully qualified type name, but we also have a
21415 namespace "X" in the using list. Fixes #41975.
21417 2003-07-13 Martin Baulig <martin@ximian.com>
21419 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21420 function. If we're a CompoundAssign, we need to create an embedded
21421 CompoundAssign, not an embedded Assign.
21422 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21425 2003-07-13 Martin Baulig <martin@ximian.com>
21427 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21428 work to fix bug #46088.
21430 2003-07-13 Ravi Pratap <ravi@ximian.com>
21432 * class.cs (Operator.Emit): Do not emit attributes here - it is
21433 taken care of by the Method class that we delegate too. This takes
21434 care of bug #45876.
21436 2003-07-10 Martin Baulig <martin@ximian.com>
21438 * expression.cs (TypeOfVoid): New class.
21439 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21441 2003-07-10 Martin Baulig <martin@ximian.com>
21443 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21446 2003-07-10 Martin Baulig <martin@ximian.com>
21448 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21449 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21451 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21453 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21455 2003-07-10 Martin Baulig <martin@ximian.com>
21457 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21458 of decimal. Fixes #42850.
21460 NOTE: I also fixed the created byte blob, but this doesn't work on
21461 the MS runtime and csc never produces any byte blobs for decimal
21464 2003-07-10 Martin Baulig <martin@ximian.com>
21466 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21467 structs; fixes #32068.
21468 (Block.AddChildVariableNames): Fixed #44302.
21470 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21472 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21474 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21476 * attribute.cs: And this test is onger needed.
21478 2003-07-08 Martin Baulig <martin@ximian.com>
21480 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21481 inaccessible types. Fixes #36313.
21483 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21485 * namespace.cs (NamespaceEntry): Create implicit entries for all
21486 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21487 implicit entries for N1.N2 and N1.
21489 2003-07-08 Martin Baulig <martin@ximian.com>
21491 Rewrote the handling of namespaces to fix a lot of the issues
21492 wrt. `using' aliases etc.
21494 * namespace.cs (Namespace): Splitted this class into a
21495 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21497 * typemanager.cs (TypeManager.IsNamespace): Removed.
21498 (TypeManager.ComputeNamespaces): Only compute namespaces from
21499 loaded assemblies here, not the namespaces from the assembly we're
21500 currently compiling.
21502 2003-07-08 Martin Baulig <martin@ximian.com>
21504 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21506 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21508 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21511 I thought about the memory savings here, but LookupTypeReflection
21512 is used under already very constrained scenarios. Compiling
21513 corlib or mcs only exposes one hit, so it would not really reduce
21514 any memory consumption.
21516 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21518 * typemanager.cs: fixes bug #45889 by only adding public types from
21519 other assemblies to the list of known types.
21521 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21523 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21524 on the type we resolved.
21526 2003-07-05 Martin Baulig <martin@ximian.com>
21528 * pending.cs (PendingImplementation.ParentImplements): Don't
21529 create the proxy if the parent is abstract.
21531 * class.cs (TypeContainer.DefineIndexers): Process explicit
21532 interface implementations first. Fixes #37714.
21534 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21536 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21537 defined recursively; but since we modify the input parameters
21538 (left is set to `this' temporarily), we reset this value if the
21539 left_is_explicit is false, which gives the original semantics to
21542 * literal.cs (NullPointer): new class used to represent a null
21543 literal in a pointer context.
21545 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21546 type is a pointer, use a NullPointer object instead of a
21547 NullLiteral. Closes 43687
21549 (ExplicitConversion): Convert pointer values using
21550 the conv opcode to the proper type.
21552 * ecore.cs (New): change ValueTypeVariable property into a method,
21553 that returns whether the valuetype is suitable for being used.
21555 * expression.cs (Binary.DoNumericPromotions): Only return if we
21556 the int constant was a valid uint, and we can return both left and
21557 right as uints. If not, we continue processing, to trigger the
21558 type conversion. This fixes 39018.
21560 * statement.cs (Block.EmitMeta): During constant resolution, set
21561 the CurrentBlock property on the emitcontext, so that we resolve
21562 constants propertly.
21564 2003-07-02 Martin Baulig <martin@ximian.com>
21566 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21567 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21569 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21570 than emitting it here.
21572 * statement.cs: Fixed some more flow analysis bugs.
21574 2003-07-02 Martin Baulig <martin@ximian.com>
21576 * class.cs (MethodData.Define): When implementing interface
21577 methods, set Final unless we're Virtual.
21579 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21580 check work for interface methods.
21582 2003-07-01 Martin Baulig <martin@ximian.com>
21584 * ecore.cs (EmitContext.This): Replaced this property with a
21585 GetThis() method which takes a Location argument. This ensures
21586 that we get the correct error location for a CS0188.
21588 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21590 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21591 ImplicitStandardConversion.
21593 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21595 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21597 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21600 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21602 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21605 (MethodData.Define): Turn off initlocals for unsafe methods.
21607 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21609 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21610 complete; Fixes #37521.
21612 * delegate.cs: Use Modifiers.TypeAttr to compute the
21613 TypeAttributes, instead of rolling our own. This makes the flags
21614 correct for the delegates.
21616 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21618 * class.cs (Constructor.Define): Set the private flag for static
21619 constructors as well.
21621 * cs-parser.jay (statement_expression): Set the return value to
21622 null, to avoid a crash when we catch an error.
21624 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21626 * cs-parser.jay: Applied patch from Jackson that adds support for
21627 extern and unsafe modifiers to destructor declarations.
21629 * expression.cs: Report error 21 if the user is trying to index a
21632 * driver.cs: Add an error message, suggested by the bug report.
21634 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21635 if we do not have a ": this ()" constructor initializer. Fixes 45149
21637 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21639 * namespace.cs: Add some information to reduce FAQs.
21641 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21643 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21644 underlying enumeration types. Fixes #43915.
21646 * expression.cs: Treat ushort/short as legal values to be used in
21647 bitwise operations.
21649 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21651 * delegate.cs: transfer custom attributes for paramenters from
21652 the delegate declaration to Invoke and BeginInvoke.
21654 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21656 * attribute.cs: handle custom marshalers and emit marshal info
21659 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21661 * makefile.gnu: Added anonymous.cs to the compiler sources.
21663 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21665 * iterators.cs: Change the name of the proxy class to include two
21668 * cs-parser.jay: Update grammar to include anonymous methods.
21670 * anonymous.cs: new file.
21672 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21674 * class.cs (Field.Define): Add missing test for pointers and
21677 2003-05-27 Ravi Pratap <ravi@ximian.com>
21679 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21680 we use the stobj opcode.
21682 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21683 since it wasn't the correct fix.
21685 It still is puzzling that we are required to use stobj for IntPtr
21686 which seems to be a ValueType.
21688 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21690 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21691 during regular simple name resolution. Now, the trick is that
21692 instead of returning for processing the simplename, we do a
21693 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21694 contextual lookup type). If a match is found, return that, if
21695 not, return for further composition.
21697 This fixes long-standing 30485.
21699 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21700 using the address to initialize an object, do an Stobj instead of
21701 using the regular Stelem.
21703 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21704 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21705 Because if we are a BaseIndexerAccess that value will be true.
21708 * statement.cs (GotoCase.Resolve): Return after reporting an
21709 error, do not attempt to continue.
21711 * expression.cs (PointerArithmetic.Emit): If our operand is a
21712 long, convert our constants to match the operand before
21713 multiplying. Convert to I type before adding. Fixes 43670.
21715 2003-05-14 Ravi Pratap <ravi@ximian.com>
21717 * enum.cs (ImplicitConversionExists) : Rename to
21718 ImplicitEnumConversionExists to remove ambiguity.
21720 * ecore.cs (NullCast): New type of cast expression class which
21721 basically is very similar to EmptyCast with the difference being
21722 it still is a constant since it is used only to cast a null to
21724 (eg. (string) null)
21726 * convert.cs (ImplicitReferenceConversion): When casting a null
21727 literal, we return a NullCast.
21729 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21730 should be around anymore.
21732 The renaming (reported was slightly wrong). Corrections:
21734 ConvertImplicitStandard -> ImplicitConversionStandard
21735 ConvertExplicitStandard -> ExplicitConversionStandard
21737 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21738 before passing them in !
21740 * convert.cs (ImplicitConversionStandard): When comparing for
21741 equal expr and target types, ensure that expr is not a
21744 In general, we must not be checking (expr_type ==
21745 target_type) in the top level conversion methods
21746 (ImplicitConversion, ExplicitConversion etc). This checking is
21747 done in the methods that they delegate to.
21749 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21751 * convert.cs: Move Error_CannotConvertType,
21752 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21753 ImplicitNumericConversion, ImplicitConversionExists,
21754 ImplicitUserConversionExists, StandardConversionExists,
21755 FindMostEncompassedType, FindMostSpecificSource,
21756 FindMostSpecificTarget, ImplicitUserConversion,
21757 ExplicitUserConversion, GetConversionOperators,
21758 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21759 TryImplicitIntConversion, Error_CannotConvertImplicit,
21760 ConvertImplicitRequired, ConvertNumericExplicit,
21761 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21762 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21765 Perform the following renames:
21767 StandardConversionExists -> ImplicitStandardConversionExists
21768 ConvertImplicit -> ImplicitConversion
21769 ConvertImplicitStandard -> ImplicitStandardConversion
21770 TryImplicitIntConversion -> ImplicitIntConversion
21771 ConvertImplicitRequired -> ImplicitConversionRequired
21772 ConvertNumericExplicit -> ExplicitNumericConversion
21773 ConvertReferenceExplicit -> ExplicitReferenceConversion
21774 ConvertExplicit -> ExplicitConversion
21775 ConvertExplicitStandard -> ExplicitStandardConversion
21777 2003-05-19 Martin Baulig <martin@ximian.com>
21779 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21780 (TypeInfo): Added support for structs having structs as fields.
21782 * ecore.cs (FieldExpr): Implement IVariable.
21783 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21784 VariableInfo for the field.
21786 2003-05-18 Martin Baulig <martin@ximian.com>
21788 * expression.cs (This.DoResolve): Report a CS0027 if we're
21789 emitting a field initializer.
21791 2003-05-18 Martin Baulig <martin@ximian.com>
21793 * expression.cs (This.ResolveBase): New public function.
21794 (This.DoResolve): Check for CS0188.
21796 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21799 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21800 `instance_expression' to null if we don't have any non-static
21803 2003-05-18 Martin Baulig <martin@ximian.com>
21805 Reworked the way how local variables and parameters are handled by
21806 the flow analysis code.
21808 * statement.cs (TypeInfo, VariableMap): New public classes.
21809 (VariableInfo): New public class. This is now responsible for
21810 checking whether a variable has been assigned. It is used for
21811 parameters and local variables.
21812 (Block.EmitMeta): Take the InternalParameters as argument; compute
21813 the layout of the flow vectors here.
21814 (Block.LocalMap, Block.ParameterMap): New public properties.
21815 (FlowBranching): The .ctor doesn't get the InternalParameters
21816 anymore since Block.EmitMeta() now computes the layout of the flow
21818 (MyStructInfo): This class is now known as `StructInfo' and nested
21819 in `TypeInfo'; we don't access this directly anymore.
21821 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
21822 property and removed IsAssigned(), IsFieldAssigned(),
21823 SetAssigned() and SetFieldAssigned(); we now call them on the
21824 VariableInfo so we don't need to duplicate this code everywhere.
21826 * expression.cs (ParameterReference): Added `Block block' argument
21828 (LocalVariableReference, ParameterReference, This): The new
21829 VariableInfo class is now responsible for all the definite
21832 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
21833 IsParameterAssigned, SetParameterAssigned): Removed.
21835 2003-05-18 Martin Baulig <martin@ximian.com>
21837 * typemanager.cs (InitCoreTypes): Try calling
21838 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
21839 the 3-args-version. Corlib now also needs our `void_type'.
21840 (GetMethod): Added overloaded version which takes an optional
21841 `bool report_errors' to allow lookups of optional methods.
21843 2003-05-12 Martin Baulig <martin@ximian.com>
21845 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
21846 only used for locals and not for parameters.
21848 2003-05-12 Miguel de Icaza <miguel@ximian.com>
21850 * support.cs (InternalParameters.ParameterType): Return the
21851 ExternalType of the parameter.
21853 * parameter.cs (Parameter.ExternalType): drop the two arguments,
21856 2003-05-11 Miguel de Icaza <miguel@ximian.com>
21858 * class.cs (MethodData.Define): Do not set the `newslot' on
21859 interface members, if they are also flagged as "override".
21861 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
21862 better code for ++i and i++. This only works for static fields
21863 and local variables.
21865 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
21866 want to pull the DeclSpace out of the builder_to_declspace instead
21867 of the TypeBuilder (like in TypeContainer.FindMembers).
21869 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
21870 instead of LookupTypeContainer. Fixes the crash on .NET for
21871 looking up interface members.
21873 * const.cs: Create our own emit context during the Definition
21874 stage, so that constants are evaluated in the proper context, when
21875 a recursive definition happens.
21877 2003-05-11 Martin Baulig <martin@ximian.com>
21879 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
21880 new block for a switch section.
21881 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
21882 the adding/lookup in the switch block. Fixes #39828.
21884 2003-05-09 Miguel de Icaza <miguel@ximian.com>
21886 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
21887 functionality: I needed to convert the data after I had performed
21888 the add/sub operation into the operands type size.
21890 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
21891 pass the type for the box operation, otherwise the resulting
21892 object would have been of type object.
21894 (BoxedCast): Add constructor to specify the type to box as.
21896 2003-05-07 Miguel de Icaza <miguel@ximian.com>
21898 * iterators.cs: I was reusing the `count' variable inadvertently,
21899 take steps to not allow this to happen.
21901 2003-05-06 Miguel de Icaza <miguel@ximian.com>
21903 * attribute.cs (Attribute.Resolve): Params attributes are encoded
21904 by creating an array at the point where the params starts and
21905 putting all those arguments there, then adjusting the size of the
21908 2003-05-05 Miguel de Icaza <miguel@ximian.com>
21910 * expression.cs (New.AddressOf): Implement interface
21911 IMemoryLocation. This is used when the `new' operator is used in
21912 the context of an invocation to a method on a value type.
21914 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
21917 * namespace.cs: Also check the using aliases here.
21919 * driver.cs: Move the test for using validity after the types have
21920 been entered, so we do a single pass that also includes the using
21923 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
21924 in the regular case. CreateSiblingForFinally is doing extra
21927 * attribute.cs (GetAttributeArgumentExpression): Store the result
21928 on an out value, and use the return value to indicate failure
21929 instead of using null (which is a valid return for Constant.GetValue).
21931 * statement.cs: Perform the analysis flow for the increment
21932 portion after the statement, because this will be the real flow of
21933 execution. Fixes #42385
21935 * codegen.cs (EmitContext.EmitArgument,
21936 EmitContext.EmitStoreArgument): New helper functions when the
21937 RemapToProxy flag is set.
21939 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
21942 Add support for remapping parameters.
21944 * iterators.cs: Propagate parameter values; Store parameter
21945 values in the proxy classes.
21947 2003-05-04 Miguel de Icaza <miguel@ximian.com>
21949 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
21950 need a proxy reference; I do not know what I was thinking
21952 * cs-parser.jay (constructor_initializer): catch another error,
21953 and display nice message.
21955 (field_declaration): catch void field declaration
21956 to flag a better error.
21958 * class.cs (MemberBase.CheckBase): Report an error instead of a
21959 warning if a new protected member is declared in a struct.
21960 (Field.Define): catch the error of readonly/volatile.
21962 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
21964 (FieldExpr.AddressOf): ditto. Catch error where the address of a
21965 volatile variable is taken
21967 2003-05-02 Miguel de Icaza <miguel@ximian.com>
21969 * statement.cs (Fixed.Resolve): Report an error if we are not in
21972 2003-05-01 Miguel de Icaza <miguel@ximian.com>
21974 * typemanager.cs: reuse the code that handles type clashes for
21975 delegates and enumerations.
21977 * class.cs (Report28): Always report.
21979 * expression.cs (EncodeAsAttribute): Allow nulls here.
21981 2003-04-28 Miguel de Icaza <miguel@ximian.com>
21983 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
21984 the functionality for testing whether an expression is valid for
21985 an attribute here. Also handle the case of arrays of elements
21988 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
21989 encoding a linear array into an array of objects that are suitable
21990 to be passed to an CustomAttributeBuilder.
21992 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
21994 * ecore.cs: (FieldExpr): Handle field remapping here.
21996 * iteratators.cs: Pass the instance variable (if the method is an
21997 instance method) to the constructors, so we can access the field
21998 variables on the class.
22000 TODO: Test this with structs. I think the THIS variable on
22001 structs might have to be a pointer, and not a refenrece
22003 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22005 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22006 local variables to fields in a proxy class.
22008 * iterators.cs (PopulateProxy): Rename our internal fields to
22010 Create a <THIS> field if we are an instance method, so we can
22011 reference our parent container variables.
22012 (MapVariable): Called back from the EmitContext code to enter a
22013 new variable to field mapping into the proxy class (we just create
22017 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22018 for using the remapped locals to fields.
22020 I placed the code here, because that gives the same semantics to
22021 local variables, and only changes the Emit code.
22023 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22024 statements inside iterators.
22025 (VariableInfo): Add a FieldBuilder for the cases when we are
22026 remapping local variables to fields in a proxy class
22028 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22029 current_block != null.
22031 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22032 not cope with strings, as it has been moved to the
22033 TableSwitchEmit. Fixed bug in switch generation.
22035 * expression.cs (New.DoResolve): Provide more context for the user
22036 when reporting an error.
22038 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22041 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22042 check the permissions for it. Note than in a type-resolution
22043 context the check was already present in DeclSpace.ResolveType,
22044 but was missing from the MemberAccess.
22046 (ArrayCreation.CheckIndices): warn if the user has
22047 more nested levels of expressions, but there are no more
22048 dimensions specified. Avoids crash on bug 41906.
22050 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22052 * statement.cs (Block): replace Implicit bool, for a generic
22054 New flag: `Unchecked'. This is used during the EmitMeta phase
22055 (which is out-of-line with the regular Resolve/Emit process for a
22056 statement, as this is done ahead of time, but still gets a chance
22057 to call constant resolve).
22059 (Block.Flags): new enum for adding a new flag.
22061 (Block.EmitMeta): track the state of unchecked.
22063 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22064 to enable constant resolution to work there as well.
22066 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22068 * typemanager.cs (ienumerable_type): Also look up
22069 System.Collections.IEnumerable.
22071 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22073 TODO: Test more than one conditional per method.
22075 * class.cs (Indexer.Define): Report the location where the user is
22076 referencing the unsupported feature.
22078 (MethodData): Overload the use of `conditionals' to
22079 minimize the creation of needless ArrayLists. This saves roughly
22080 212kb on my machine.
22082 (Method): Implement the new IIteratorContainer interface.
22083 (Method.SetYields): Implement the method by setting the ModFlags
22084 to contain METHOD_YIELDS.
22086 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22087 which just got set to null.
22089 * iterators.cs: New file.
22091 (Yield, YieldBreak): New statements.
22093 * statement.cs (Return.Resolve): Flag an error if we are used in
22094 an iterator method.
22096 * codegen.cs (InIterator): New flag set if the code is being
22097 compiled in an iterator method.
22099 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22100 internal modifier, and we just use it to avoid adding extra
22101 fields, as this is seldom used.
22103 * cs-parser.jay: Add yield_statement (yield and yield break).
22105 * driver.cs: New flag -v2 to turn on version 2 features.
22107 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22108 hashtable when v2 is enabled.
22110 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22112 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22113 there is already a namespace defined with this name.
22115 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22116 people upgraded their corlibs.
22118 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22119 always use fully qualified types, no need to use the compiler
22122 (TypeManager.IsNamespace): Use binarysearch.
22124 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22125 AddDelegate): I did not quite use the new IsValid API properly: I
22126 have to pass the short-name and the fullname. I was passing only
22127 the basename instead of the fullname sometimes.
22129 (TypeContainer.DefineType): call NamespaceClash.
22131 * interface.cs (Interface.DefineType): use NamespaceClash before
22134 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22137 * enum.cs: (Enum.DefineType): use NamespaceClash before
22140 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22141 speed increase. First, use the negative_hits cache when we get a
22142 negative. Second, add the type with its full original name
22143 instead of the new . and + encoded name (reflection uses + to
22144 separate type from a nested type). Use LookupTypeReflection
22145 directly which bypasses the type->name hashtable (that we already
22146 know does not contain the type.
22148 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22149 location/container type.
22151 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22153 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22155 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22157 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22158 method is being referenced in the method group from a static
22159 context, and report error 120 if so.
22161 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22164 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22165 is created, we create the A namespace).
22167 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22170 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22172 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22173 invocation to ModuleBuilder.GetType with the same values will
22174 return a new type instance, so we need to cache its return
22177 * expression.cs (Binary.ResolveOperator): Only allow the compare
22178 operators on enums if they are of the same type.
22180 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22181 types of ValueType on their own case. Before we were giving them
22182 the same treatment as objects.
22184 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22185 fullname. Short name is used to compare against container name.
22186 Fullname is used to check against defined namespace names.
22188 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22189 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22191 (Method.CheckBase): Call parent.
22192 (MemberBase.CheckBase): Check for protected members on sealed
22194 (PropertyBase.CheckBase): Call parent.
22195 (Field.Define): Call parent.
22197 * report.cs: Negative error codes are now mapped to 8000 - code,
22198 so that the display is render more nicely.
22200 * typemanager.cs: Do not use try/catch, instead report a regular
22203 (GetPointerType, GetReferenceType): These methods provide
22204 mechanisms to obtain the T* and T& from a T. We had the code
22205 previously scattered around the code base, and it also used
22206 TypeManager.LookupType that would go through plenty of caches.
22207 This one goes directly to the type source.
22209 In some places we did the Type.GetType followed by
22210 ModuleBuilder.GetType, but not in others, so this unifies the
22211 processing as well.
22213 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22214 statements now that we have namespace information.
22216 * typemanager.cs (IsNamespace): New method, returns whether the
22217 string presented is a namespace or not.
22219 (ComputeNamespaces): New public entry point, computes the list of
22220 available namespaces, using the GetNamespaces API call in Mono, or
22221 the slower version in MS.NET.
22223 Now before we start the semantic analysis phase, we have a
22224 complete list of namespaces including everything that the user has
22227 Deleted old code to cache namespaces in .nsc files.
22229 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22231 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22232 class/struct location definition Location for the implicit
22233 constructor location.
22235 (Operator.Define): Use the location of the operator for the
22236 implicit Method definition.
22238 (Constructor.Emit): use the constructor location for the implicit
22239 base initializer constructor.
22241 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22242 and the Expression class now contains two new methods:
22244 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22245 isolate type lookup from the rest of the resolution process.
22247 Since we use Expressions to hold type definitions due to the way
22248 we parse the input we have historically overloaded Resolve to
22249 perform the Type lookups if a special flag is passed. Now this is
22250 eliminated and two methods take their place.
22252 The differences in the two methods between xStep and xTerminal is
22253 that xStep is involved in our current lookup system that uses
22254 SimpleNames to compose a name, while xTerminal is used just to
22255 catch the case where the simplename lookup failed.
22257 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22259 * expression.cs (ResolveMemberAccess): Remove redundant code.
22260 TypeExpr expressions are always born fully resolved.
22262 * interface.cs (PopulateMethod): Do not lookup the types twice.
22263 We were doing it once during SemanticAnalysis and once during
22266 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22267 in local variable type definitions, were being returned as a
22268 SimpleName (we decomposed everything into a string), that is
22269 because primary_expression was being used instead of a type in the
22270 grammar (reduce/reduce conflicts).
22272 The part that was wrong is that we converted the expression into a
22273 string (an oversimplification in one hand, compounded with primary
22274 expressions doing string concatenation).
22280 Would return "A.B.C[]" as a SimpleName. This stopped things like
22281 using clauses from working on this particular context. And a type
22282 was being matched directly against "A.B.C[]".
22284 We now use the correct approach, and allow for ComposedCast to be
22285 part of the unary expression. So the "A.B.C []" become a composed
22286 cast of "A.B.C" (as a nested group of MemberAccess with a
22287 SimpleName at the end) plus the rank composition "[]".
22291 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22293 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22294 for the access level checking.
22296 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22297 `TypeContainer container', because I kept getting confused when I
22298 was debugging this code.
22300 * expression.cs (Indexers): Instead of tracking getters/setters,
22301 we now track them in parallel. We create one arraylist less, but
22302 most importantly it is possible now for the LValue code to find a
22303 matching get for a set.
22305 (IndexerAccess.DoResolveLValue): Update the code.
22306 GetIndexersForType has been modified already to extract all the
22307 indexers from a type. The code assumed it did not.
22309 Also make the code set the correct return type for the indexer.
22310 This was fixed a long time ago for properties, but was missing for
22311 indexers. It used to be void_type.
22313 (Binary.Emit): Test first for doubles instead of
22314 floats, as they are more common.
22316 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22317 when dealing with floats and the <=, >= operators. This fixes bug
22320 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22321 to load the array value by emitting a load on the foreach variable
22322 type. This was incorrect.
22324 We now emit the code to load an element using the the array
22325 variable type, and then we emit the conversion operator.
22329 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22331 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22333 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22335 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22336 test for protection before we test for signatures.
22338 (MethodSignature.ToString): implement.
22340 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22341 to the case where we reduced into a LongConstant.
22343 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22344 depend on whether the information is acurrate, because the
22345 Microsoft runtime will always claim that the array type is public,
22346 regardless of the real state.
22348 If the type is a pointer, another problem happens: the type is
22349 reported as non-public in Microsoft.
22351 In both cases we have to call CheckAccessLevel recursively with
22352 the underlying type as the argument to be tested.
22354 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22356 * assign.cs (Assign.Emit): If we are dealing with a compound
22357 assignment expression, we should use the code path that stores the
22358 intermediate result in a temporary value. This fixes #40903.
22360 *expression.cs (Indirection.ToString): Provide ToString method for
22363 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22365 * class.cs: Null out fields holding references to Block objects so
22366 they can be garbage collected.
22368 * expression.cs (OverloadResolve): Remove unused local.
22370 2003-04-07 Martin Baulig <martin@ximian.com>
22372 * codegen.cs (EmitContext.CurrentFile): New public field.
22373 (EmitContext.Mark): Use the CurrentFile to check whether the
22374 location is in the correct file.
22375 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22377 2003-04-07 Martin Baulig <martin@ximian.com>
22379 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22381 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22382 location. [FIXME: The location argument which gets passed to this
22383 method is sometimes wrong!]
22385 2003-04-07 Nick Drochak <ndrochak@gol.com>
22387 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22389 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22391 * expression.cs (Indirection.EmitAssign): We were using the
22392 temporary, but returning immediately instead of continuing the
22395 2003-04-06 Martin Baulig <martin@ximian.com>
22397 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22398 if it's a nested child, but also deriving from the outer class.
22401 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22402 nested child, but also deriving from the outer class. See
22404 (FilterWithClosure): We may access private members of the outer
22405 class if we're a nested child and deriving from the outer class.
22406 (RealMemberLookup): Only set `closure_private_ok' if the
22407 `original_bf' contained BindingFlags.NonPublic.
22409 2003-04-05 Martin Baulig <martin@ximian.com>
22411 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22413 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22415 * class.cs (Event.Define): Do not allow abstract events to have
22418 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22420 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22421 block in event declarations.
22423 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22424 value type, get its address.
22426 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22427 leaving a class on the stack instead of a boolean value (int
22428 0/1). Change the code so we compare against null, and then the
22429 result against zero.
22431 * class.cs (TypeContainer.GetClassBases): We were checking for the
22432 parent class being sealed too late.
22434 * expression.cs (Binary.Emit): For <= and >= when dealing with
22435 floating point values, use cgt.un and clt.un instead of cgt and
22438 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22440 * statement.cs: Apply the same optimization as MS: skip the
22441 GetEnumerator returning an IEnumerator, and use the one returning a
22442 CharEnumerator instead. This allows us to avoid the try-finally block
22445 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22447 * cs-parser.jay: Attributes cannot be applied to
22448 namespaces. Fixes #40473
22450 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22453 (Add*): check if the name is valid using the full name for constants,
22454 fields, properties and events.
22456 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22458 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22459 char constants to be part of the enumeration.
22461 * expression.cs (Conditional.DoResolve): Add support for operator
22462 true. Implements the missing functionality from 14.12
22464 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22465 operator true/false as required by the spec.
22467 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22468 implicit conversion to boolean.
22470 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22471 also one where the type implements `operator true'.
22473 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22474 get an expression that will invoke operator true based on an
22477 (GetConversionOperators): Removed the hack that called op_True
22480 (Expression.ResolveBoolean): Move this from Statement.
22482 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22484 * ecore.cs (FieldExpr): do not allow initialization of initonly
22485 fields on derived classes
22487 2003-03-13 Martin Baulig <martin@ximian.com>
22489 * statement.cs (Block.Emit): Call ig.BeginScope() and
22490 ig.EndScope() when compiling with debugging info; call
22491 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22493 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22495 * expression.cs (Indexers): Do not construct immediately, allow
22496 for new members to be appended as we go. Fixes 38143
22498 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22500 * expression.cs: save/restore context when resolving an unchecked
22503 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22505 * cfold.cs: Catch division by zero in modulus operator during
22508 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22510 * interface.cs (Interface.DefineMembers): Avoid defining members
22513 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22515 * driver.cs: handle the +/- options for -noconfig
22517 * statement.cs (Unckeched.Resolve): Also track the state of
22518 unchecked in the Resolve phase.
22520 2003-02-27 Martin Baulig <martin@ximian.com>
22522 * ecore.cs (Expression.MemberLookup): Don't create a
22523 MethodGroupExpr for something which is not a method. Fixes #38291.
22525 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22527 * class.cs (MemberBase.CheckParameters): Also check that the type
22528 is unmanaged if it is a pointer.
22530 * expression.cs (SizeOf.Resolve): Add location information.
22532 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22533 a managed type is declared.
22535 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22536 parameter modifiers as well. Fixes bug 38606
22538 * class.cs: Very sad. Am backing out the speed up changes
22539 introduced by the ArrayList -> Array in the TypeContainer, as they
22540 were not actually that much faster, and introduced a bug (no error
22541 reports on duplicated methods).
22543 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22544 source first, this will guarantee that we have a valid expression
22545 before calling in lower levels functions that will require a
22546 resolved object. Then use this original_source in the
22547 target.ResolveLValue instead of the original source that was
22550 Another change. Use target.Resolve instead of LValueResolve.
22551 Although we are resolving for LValues, we will let the Assign code
22552 take care of that (it will be called again from Resolve). This
22553 basically allows code like this:
22555 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22556 class Y { void A (X x) { x [0] += o; }
22558 The problem was that the indexer was trying to resolve for
22559 set_Item (idx, object o) and never finding one. The real set_Item
22560 was set_Item (idx, X). By delaying the process we get the right
22565 2003-02-23 Martin Baulig <martin@ximian.com>
22567 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22568 while calling DoEmit ().
22570 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22571 source files; if you use the #line directive inside a method, the
22572 compiler stops emitting line numbers for the debugger until it
22573 reaches the end of the method or another #line directive which
22574 restores the original file.
22576 2003-02-23 Martin Baulig <martin@ximian.com>
22578 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22580 2003-02-23 Martin Baulig <martin@ximian.com>
22582 * statement.cs (Block.AddChildVariableNames): We need to call this
22583 recursively, not just for our immediate children.
22585 2003-02-23 Martin Baulig <martin@ximian.com>
22587 * class.cs (Event.Define): Always make the field private, like csc does.
22589 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22590 actually work, fixes bug #37521.
22592 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22594 * delegate.cs: When creating the various temporary "Parameters"
22595 classes, make sure that we call the ComputeAndDefineParameterTypes
22596 on those new parameters (just like we do with the formal ones), to
22597 allow them to be resolved in the context of the DeclSpace.
22599 This fixes the bug that Dick observed in Bugzilla #38530.
22601 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22603 * expression.cs (ResolveMemberAccess): When resolving a constant,
22604 do not attempt to pull a constant if the value was not able to
22605 generate a valid constant.
22607 * const.cs (LookupConstantValue): Do not report more errors than required.
22609 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22611 * expression.cs: fixes bug #38328.
22613 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22615 * class.cs: Changed all the various members that can be part of a
22616 class from being an ArrayList to be an Array of the right type.
22617 During the DefineType type_list, interface_list, delegate_list and
22618 enum_list are turned into types, interfaces, delegates and enums
22621 And during the member population, indexer_list, event_list,
22622 constant_list, field_list, instance_constructor_list, method_list,
22623 operator_list and property_list are turned into their real arrays.
22625 Although we could probably perform this operation earlier, for
22626 good error reporting we need to keep the lists and remove the
22627 lists for longer than required.
22629 This optimization was triggered by Paolo profiling the compiler
22630 speed on the output of `gen-sample-program.pl' perl script.
22632 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22633 not crash in methods like MemberLookupFailed that use this field.
22635 This problem arises when the compiler fails to resolve a type
22636 during interface type definition for example.
22638 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22640 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22641 inherit from System.Object, so we have to stop at null, not only
22642 when reaching System.Object.
22644 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22646 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22647 DeclaredOnly because the parent indexer might have had a different
22648 name, but did not loop until the top of the hierarchy was reached.
22650 The problem this one fixes is 35492: when a class implemented an
22651 indexer from an interface, we were getting the interface method
22652 (which was abstract) and we were flagging an error (can not invoke
22655 This also keeps bug 33089 functioning, and test-148 functioning.
22657 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22658 out if a method is special is to see if it is declared in a
22659 property or event, or whether it is one of the predefined operator
22660 names. This should fix correctly #36804.
22662 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22664 The goal here is to remove the dependency on EmptyCast.Peel ().
22665 Killing it completely.
22667 The problem is that currently in a number of places where
22668 constants are expected, we have to "probe" for an EmptyCast, and
22669 Peel, which is not the correct thing to do, as this will be
22670 repetitive and will likely lead to errors.
22672 The idea is to remove any EmptyCasts that are used in casts that
22673 can be reduced to constants, so we only have to cope with
22676 This bug hunt was triggered by Bug 37363 and the desire to remove
22677 the duplicate pattern where we were "peeling" emptycasts to check
22678 whether they were constants. Now constants will always be
22681 * ecore.cs: Use an enumconstant here instead of wrapping with
22684 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22685 throwing me off. By handling this we can get rid of a few hacks.
22687 * statement.cs (Switch): Removed Peel() code.
22689 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22691 * class.cs: Location information for error 508
22693 * expression.cs (New.DoResolve): Add a guard against double
22694 resolution of an expression.
22696 The New DoResolve might be called twice when initializing field
22697 expressions (see EmitFieldInitializers, the call to
22698 GetInitializerExpression will perform a resolve on the expression,
22699 and later the assign will trigger another resolution
22701 This leads to bugs (#37014)
22703 * delegate.cs: The signature for EndInvoke should contain any ref
22704 or out parameters as well. We were not doing this in the past.
22706 * class.cs (Field.Define): Do not overwrite the type definition
22707 inside the `volatile' group. Turns out that volatile enumerations
22708 were changing the type here to perform a validity test, which
22711 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22713 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22714 and structs, we do not want to load the instance variable
22716 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22717 enum_type has to be handled like an object reference (implicit
22718 conversions exists from this to object), but the regular IsClass
22719 and IsValueType tests will never return true for this one.
22721 Also we use TypeManager.IsValueType instead of type.IsValueType,
22722 just for consistency with the rest of the code (this is only
22723 needed if we ever use the construct exposed by test-180.cs inside
22724 corlib, which we dont today).
22726 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22728 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22731 2003-02-09 Martin Baulig <martin@ximian.com>
22733 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22734 (Namespace.DefineNamespaces): New static public method; this is
22735 called when we're compiling with debugging to add all namespaces
22736 to the symbol file.
22738 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22739 pass it to the Namespace's .ctor.
22741 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22742 and MethodBase arguments; pass the namespace ID to the symwriter;
22743 pass the MethodBase instead of the token to the symwriter.
22744 (SymbolWriter.DefineNamespace): New method to add a namespace to
22747 2003-02-09 Martin Baulig <martin@ximian.com>
22749 * symbolwriter.cs: New file. This is a wrapper around
22750 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22751 methods here in near future.
22753 2003-02-09 Martin Baulig <martin@ximian.com>
22755 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22756 ILGenerator.MarkSequencePoint() which are actually used by the
22759 2003-02-09 Martin Baulig <martin@ximian.com>
22761 * location.cs (SourceFile): New public sealed class. This
22762 contains the name and an index which is used in the location's token.
22763 (Location): Reserve an appropriate number of bits in the token for
22764 the source file instead of walking over that list, this gives us a
22765 really huge performance improvement when compiling with debugging.
22767 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22768 `SourceFile' argument instead of a string.
22769 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22770 but don't parse/tokenize here, we need to generate the list of all
22771 source files before we do that.
22772 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22775 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22776 instead of a string.
22778 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22781 2003-02-09 Martin Baulig <martin@ximian.com>
22783 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22784 filename on `#line default'.
22786 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22788 * statement.cs: don't clear the pinned var when the fixed statement
22789 returns from the method (fixes bug#37752).
22791 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22793 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22796 2003-02-07 Martin Baulig <martin@ximian.com>
22798 * driver.cs: Removed the `--debug-args' command line argument.
22800 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22801 automatically by the AsssemblyBuilder.
22802 (CodeGen.InitializeSymbolWriter): We don't need to call any
22803 initialization function on the symbol writer anymore. This method
22804 doesn't take any arguments.
22806 2003-02-03 Miguel de Icaza <miguel@ximian.com>
22808 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
22809 from referenced assemblies as well.
22811 2003-02-02 Martin Baulig <martin@ximian.com>
22813 * class.cs (MethodData.Emit): Generate debugging info for external methods.
22815 2003-02-02 Martin Baulig <martin@ximian.com>
22817 * class.cs (Constructor.Emit): Open the symbol writer before
22818 emitting the constructor initializer.
22819 (ConstructorInitializer.Emit): Call ec.Mark() to allow
22820 single-stepping through constructor initializers.
22822 2003-01-30 Miguel de Icaza <miguel@ximian.com>
22824 * class.cs: Handle error 549: do not allow virtual methods in
22827 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
22829 * decl.cs: Check access levels when resolving types
22831 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
22833 * statement.cs: Add parameters and locals set in catch blocks that might
22834 return to set vector
22836 2003-01-29 Miguel de Icaza <miguel@ximian.com>
22838 * class.cs (Operator): Set the SpecialName flags for operators.
22840 * expression.cs (Invocation.DoResolve): Only block calls to
22841 accessors and operators on SpecialName methods.
22843 (Cast.TryReduce): Handle conversions from char constants.
22846 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
22848 * statement.cs: small memory and time optimization in FlowBranching.
22850 2003-01-28 Pedro Mart <yoros@wanadoo.es>
22852 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
22853 problem that the last fix but in the other sid (Set).
22855 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
22856 access when there is no indexer in the hierarchy.
22858 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
22860 * class.cs: Combine some if statements.
22862 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22864 * driver.cs: fixed bug #37187.
22866 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
22868 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
22869 any indexer, it's needed to build a list with all the indexers in the
22870 hierarchy (AllGetters), else we have problems. Fixes #35653.
22872 2003-01-23 Miguel de Icaza <miguel@ximian.com>
22874 * class.cs (MethodData.Define): It is wrong for an interface
22875 implementation to be static in both cases: explicit and implicit.
22876 We were only handling this in one case.
22878 Improve the if situation there to not have negations.
22880 * class.cs (Field.Define): Turns out that we do not need to check
22881 the unsafe bit on field definition, only on usage. Remove the test.
22883 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22885 * driver.cs: use assembly.Location instead of Codebase (the latest
22886 patch made mcs fail when using MS assemblies).
22888 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
22890 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
22891 get the path to *corlib.dll.
22893 2003-01-21 Nick Drochak <ndrochak@gol.com>
22897 * typemanager.cs: Remove compiler warnings
22899 2003-01-20 Duncan Mak <duncan@ximian.com>
22901 * AssemblyInfo.cs: Bump the version number to 0.19.
22903 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22905 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
22907 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
22909 * class.cs (Constructor::Emit): Emit debugging info for constructors.
22911 2003-01-17 Miguel de Icaza <miguel@ximian.com>
22913 * cs-parser.jay: Small fix: we were not comparing the constructor
22914 name correctly. Thanks to Zoltan for the initial pointer.
22916 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
22918 * cs-tokenizer.cs: Set file name when specified with #line
22920 2003-01-15 Miguel de Icaza <miguel@ximian.com>
22922 * cs-parser.jay: Only perform the constructor checks here if we
22923 are named like the class; This will help provider a better
22924 error. The constructor path is taken when a type definition is
22925 not found, but most likely the user forgot to add the type, so
22926 report that rather than the constructor error.
22928 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
22930 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
22933 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22935 * cs-parser.jay: Add cleanup call.
22937 2003-01-13 Duncan Mak <duncan@ximian.com>
22939 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
22940 consistent with other methods.
22942 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22944 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
22946 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
22948 * attribute.cs: only set GuidAttr to true when we have a
22951 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22955 * typemanager.cs: fixes to allow mcs compile corlib with the new
22956 Type.IsSubclassOf fix.
22958 2003-01-08 Miguel de Icaza <miguel@ximian.com>
22960 * expression.cs (LocalVariableReference.DoResolve): Classify a
22961 constant as a value, not as a variable. Also, set the type for
22964 * cs-parser.jay (fixed_statement): take a type instead of a
22965 pointer_type, so we can produce a better error message later.
22967 * statement.cs (Fixed.Resolve): Flag types that are not pointers
22970 (For.DoEmit): Make inifinite loops have a
22971 non-conditional branch back.
22973 (Fixed.DoEmit): First populate the pinned variables, then emit the
22974 statement, then clear the variables. Before I was emitting the
22975 code once for each fixed piece.
22978 2003-01-08 Martin Baulig <martin@ximian.com>
22980 * statement.cs (FlowBranching.MergeChild): A break in a
22981 SWITCH_SECTION does not leave a loop. Fixes #36155.
22983 2003-01-08 Martin Baulig <martin@ximian.com>
22985 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
22986 lives in the same number space than `param_map'. Fixes #36154.
22988 2003-01-07 Miguel de Icaza <miguel@ximian.com>
22990 * cs-parser.jay (constructor_declaration): Set the
22991 Constructor.ModFlags before probing for it. This makes the
22992 compiler report 514, 515 and 132 (the code was there, but got
22995 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
22996 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
22997 (GotoCase.Resolve): Set `Returns' to ALWAYS.
22999 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23001 * enum.cs: create the enum static fields using the enum type.
23003 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23005 * class.cs: don't try to create the ParamBuilder for the return
23006 type if it's not needed (and handle it breaking for the ms runtime
23009 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23011 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23013 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23015 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23016 the command. This showed up while compiling the JANET source
23017 code, which used \r as its only newline separator.
23019 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23021 * class.cs (Method.Define): If we are an operator (because it
23022 reuses our code), then set the SpecialName and HideBySig. #36128
23024 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23026 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23027 exception, report error 120 `object reference required'.
23029 * driver.cs: Add --pause option, used during to measure the size
23030 of the process as it goes with --timestamp.
23032 * expression.cs (Invocation.DoResolve): Do not allow methods with
23033 SpecialName to be invoked.
23035 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23037 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23038 number before adding it.
23040 2002-12-21 Ravi Pratap <ravi@ximian.com>
23042 * ecore.cs (StandardImplicitConversion): When in an unsafe
23043 context, we allow conversion between void * to any other pointer
23044 type. This fixes bug #35973.
23046 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23048 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23049 is not thrown when extensionless outputs are used
23051 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23053 * rootcontext.cs: fixed compilation of corlib.
23055 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23057 * attribute.cs (Attributes.Contains): Add new method.
23059 * class.cs (MethodCore.LabelParameters): if the parameter is an
23060 `out' parameter, check that no attribute `[In]' has been passed.
23062 * enum.cs: Handle the `value__' name in an enumeration.
23064 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23066 * decl.cs: Added special case to allow overrides on "protected
23069 2002-12-18 Ravi Pratap <ravi@ximian.com>
23071 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23072 since it makes much more sense.
23074 (Attributes.ctor): Don't require a Location parameter.
23076 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23078 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23079 since we already have that information per attribute.
23081 * everywhere : make appropriate changes.
23083 * class.cs (LabelParameters): Write the code which actually
23084 applies attributes to the return type. We can't do this on the MS
23085 .NET runtime so we flag a warning in the case an exception is
23088 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23090 * const.cs: Handle implicit null conversions here too.
23092 2002-12-17 Ravi Pratap <ravi@ximian.com>
23094 * class.cs (MethodCore.LabelParameters): Remove the extra
23095 Type [] parameter since it is completely unnecessary. Instead
23096 pass in the method's attributes so that we can extract
23097 the "return" attribute.
23099 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23101 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23102 of ignoring it and letting the compile continue.
23104 * typemanager.cs (ChangeType): use an extra argument to return an
23105 error condition instead of throwing an exception.
23107 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23109 * expression.cs (Unary.TryReduce): mimic the code for the regular
23110 code path. Perform an implicit cast in the cases where we can
23111 implicitly convert to one of the integral types, and then reduce
23112 based on that constant. This fixes bug #35483.
23114 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23116 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23118 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23120 * namespace.cs: fixed bug #35489.
23122 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23124 * class.cs: Remove some dead code.
23126 * cs-parser.jay: Estimate the number of methods needed
23127 (RootContext.MethodCount);
23129 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23130 numbers instead of StringBuilders.
23132 * support.cs (PtrHashtable): Add constructor with initial size;
23133 We can now reduce reallocations of the method table.
23135 2002-12-10 Ravi Pratap <ravi@ximian.com>
23137 * attribute.cs (ApplyAttributes): Keep track of the emitted
23138 attributes on a per-target basis. This fixes bug #35413.
23140 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23142 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23143 default to the Windows 1252 encoding.
23145 (UnixParseOption): Support version, thanks to Alp for the missing
23148 * AssemblyInfo.cs: Add nice assembly information.
23150 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23153 * cs-parser.jay: Allow a trailing comma before the close bracked
23154 in the attribute_section production.
23156 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23157 address of the instance was being taken, I will take this out,
23158 because we take the address of the object immediately here.
23160 2002-12-09 Ravi Pratap <ravi@ximian.com>
23162 * typemanager.cs (AreMultipleAllowed): Take care of the most
23163 obvious case where attribute type is not in the current assembly -
23166 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23168 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23169 definitions, instead of doing that afterwards.
23171 Also we use a nice little hack, depending on the constructor, we
23172 know if we are a "composed" name or a simple name. Hence, we
23173 avoid the IndexOf test, and we avoid
23175 * codegen.cs: Add code to assist in a bug reporter to track down
23176 the source of a compiler crash.
23178 2002-12-07 Ravi Pratap <ravi@ximian.com>
23180 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23181 types have been emitted for a given element and flag an error
23182 if something which does not have AllowMultiple set is used more
23185 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23186 attribute types and their corresponding AllowMultiple properties
23188 (AreMultipleAllowed): Check the property for a given type.
23190 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23191 property in the case we have a TypeContainer.
23193 (Attributes.AddAttribute): Detect duplicates and just skip on
23194 adding them. This trivial fix catches a pretty gross error in our
23195 attribute emission - global attributes were being emitted twice!
23197 Bugzilla bug #33187 is now fixed.
23199 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23201 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23202 instead of pp_and).
23204 * expression.cs (Binary.ResolveOperator): I can only use the
23205 Concat (string, string, string) and Concat (string, string,
23206 string, string) if the child is actually a concatenation of
23209 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23211 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23212 context where we need a 2-character lookahead.
23214 * pending.cs (PendingImplementation): Rework so we can keep track
23215 of interface types all the time, and flag those which were
23216 implemented by parents as optional.
23218 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23220 * expression.cs (Binary.ResolveOperator): Use
23221 String.Concat(string,string,string) or
23222 String.Concat(string,string,string,string) when possible.
23224 * typemanager: More helper methods.
23227 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23229 * pending.cs: remove the bogus return from GetMissingInterfaces()
23230 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23232 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23234 * namespace.cs: avoid duplicated 'using xxx' being added to
23235 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23236 when we get more than one 'using' statement for the same namespace.
23237 Report a CS0105 warning for it.
23239 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23241 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23242 of calling getChar/putback, uses internal knowledge of it.
23244 (xtoken): Reorder tokenizer so most common patterns are checked
23245 first. This reduces the compilation time in another 5% (from 8.11s
23246 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23248 The parsing time is 22% of the compilation in mcs, and from that
23249 64% is spent on the tokenization process.
23251 I tried using a binary search for keywords, but this is slower
23252 than the hashtable. Another option would be to do a couple of
23255 * Not use a StringBuilder, instead use an array of chars,
23256 with a set value. Notice that this way we could catch
23257 the 645 error without having to do it *afterwards*.
23259 * We could write a hand-parser to avoid the hashtable
23260 compares altogether.
23262 The identifier consumption process takes 37% of the tokenization
23263 time. Another 15% is spent on is_number. 56% of the time spent
23264 on is_number is spent on Int64.Parse:
23266 * We could probably choose based on the string length to
23267 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23270 Another 3% is spend on wrapping `xtoken' in the `token' function.
23272 Handle 0xa0 as whitespace (#34752)
23274 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23276 * typemanager.cs (IsCLRType): New routine to tell whether a type
23277 is one of the builtin types.
23279 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23280 typecode in more places instead of doing pointer comparissions.
23281 We could leverage some knowledge about the way the typecodes are
23284 New code to cache namespaces in assemblies, it is currently not
23285 invoked, to be used soon.
23287 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23289 * expression.cs (Binary.ResolveOperator): specially handle
23290 strings, and do not perform user-defined operator overloading for
23293 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23295 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23296 internalcall as it is a pretty simple operation; Avoid whenever
23297 possible to call Char.IsLetter.
23299 (consume_identifier): Cut by half the number of
23300 hashtable calls by merging the is_keyword and GetKeyword behavior.
23302 Do not short-circuit, because if we do, we
23303 report errors (ie, #if false && true would produce an invalid
23307 2002-11-24 Martin Baulig <martin@ximian.com>
23309 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23310 check constant ranges and report a CS0221. Fixes #33186.
23312 2002-11-24 Martin Baulig <martin@ximian.com>
23314 * cs-parser.jay: Make this work for uninitialized variable
23315 declarations in the `for' initializer. Fixes #32416.
23317 2002-11-24 Martin Baulig <martin@ximian.com>
23319 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23320 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23322 2002-11-24 Martin Baulig <martin@ximian.com>
23324 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23325 argument; if true, we also check for user-defined conversions.
23326 This is only needed if both arguments are of a user-defined type.
23327 Fixes #30443, added test-175.cs.
23328 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23330 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23332 2002-11-24 Martin Baulig <martin@ximian.com>
23334 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23335 function to get the store opcode.
23336 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23337 only emit the Ldelema if the store opcode is Stobj. You must run
23338 both test-34 and test-167 to test this. Fixes #34529.
23340 2002-11-23 Martin Baulig <martin@ximian.com>
23342 * ecore.cs (Expression.MemberLookup): Added additional
23343 `qualifier_type' argument which is used when we're being called
23344 from MemberAccess.DoResolve() and null if we're called from a
23346 (Expression.MemberLookupFailed): New method to report errors; this
23347 does the CS1540 check and reports the correct error message.
23349 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23350 argument for the CS1540 check and redone the way how we're dealing
23351 with private members. See the comment in the source code for details.
23352 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23353 `closure_start_type' to `closure_qualifier_type' and check whether
23354 it's not null. It was not this filter being broken, it was just
23355 being called with the wrong arguments.
23357 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23358 and pass it the correct `qualifier_type'; this also does the error
23361 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23363 * expression.cs (Invocation.EmitParams): If the we are dealing
23364 with a non-built-in value type, load its address as well.
23366 (ArrayCreation): Use a a pretty constant instead
23367 of the hardcoded value 2. Use 6 instead of 2 for the number of
23368 static initializers.
23370 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23371 because they are not really value types, just glorified integers.
23373 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23375 * ecore.cs: Remove redundant code for enumerations, make them use
23376 the same code path as everything else, fixes the casting issue
23377 with enumerations in Windows.Forms.
23379 * attribute.cs: Do only cast to string if it is a string, the
23380 validation happens later.
23382 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23383 people upgrade their corlibs.
23385 * ecore.cs: Oops, enumerations were not following the entire code path
23387 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23389 * typemanager.cs (FilterWithClosure): Commented out the test for
23390 1540 in typemanager.cs, as it has problems when accessing
23391 protected methods from a parent class (see test-174.cs).
23393 * attribute.cs (Attribute.ValidateGuid): new method.
23394 (Attribute.Resolve): Use above.
23396 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23398 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23400 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23401 handling for enumerations, as we only needed the TypeContainer
23402 functionality to begin with (this is required for the fix below to
23403 work for enums that reference constants in a container class for
23406 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23408 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23409 a valid TypeBuilder to perform lookups on.o
23411 * class.cs (InheritableMemberSignatureCompare): Use true in the
23412 call to GetGetMethod and GetSetMethod, because we are comparing
23413 the signature, and we need to get the methods *even* if they are
23416 (PropertyBase.CheckBase): ditto.
23418 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23419 GotoCase.Resolve): Use Peel on EmpytCasts.
23421 * ecore.cs (EmptyCast): drop child, add Peel method.
23423 2002-11-17 Martin Baulig <martin@ximian.com>
23425 * ecore.cs (EmptyCast.Child): New public property.
23427 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23428 label resolved to an EmptyCast. Fixes #34162.
23429 (GotoCase.Resolve): Likewise.
23430 (Block.EmitMeta): Likewise.
23432 2002-11-17 Martin Baulig <martin@ximian.com>
23434 * expression.cs (Invocation.BetterConversion): Prefer int over
23435 uint; short over ushort; long over ulong for integer literals.
23436 Use ImplicitConversionExists instead of StandardConversionExists
23437 since we also need to check for user-defined implicit conversions.
23438 Fixes #34165. Added test-173.cs.
23440 2002-11-16 Martin Baulig <martin@ximian.com>
23442 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23443 with the `true' and `false' literals. Fixes #33151.
23445 2002-11-16 Martin Baulig <martin@ximian.com>
23447 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23448 October 22nd; don't do the cs1540 check for static members.
23450 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23451 now using our own filter here and doing the cs1540 check again.
23453 2002-11-16 Martin Baulig <martin@ximian.com>
23455 * support.cs (InternalParameters): Don't crash if we don't have
23456 any fixed parameters. Fixes #33532.
23458 2002-11-16 Martin Baulig <martin@ximian.com>
23460 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23461 when looking up static methods to make this work on Windows.
23464 2002-11-16 Martin Baulig <martin@ximian.com>
23466 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23467 a setter rather than using PropertyInfo.CanWrite.
23469 2002-11-15 Nick Drochak <ndrochak@gol.com>
23471 * class.cs: Allow acces to block member by subclasses. Fixes build
23474 2002-11-14 Martin Baulig <martin@ximian.com>
23476 * class.cs (Constructor.Emit): Added the extern/block check.
23479 2002-11-14 Martin Baulig <martin@ximian.com>
23481 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23482 iteration while looking for indexers, this is needed because the
23483 indexer may have a different name in our base classes. Fixed the
23484 error reporting (no indexers at all, not get accessor, no
23485 overloaded match). Fixes bug #33089.
23486 (IndexerAccess.DoResolveLValue): Likewise.
23488 2002-11-14 Martin Baulig <martin@ximian.com>
23490 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23491 indexers. Fixes the first part of bug #33089.
23492 (MethodSignature.InheritableMemberSignatureCompare): Added support
23495 2002-11-13 Ravi Pratap <ravi@ximian.com>
23497 * attribute.cs (Attribute.Resolve): Catch the
23498 NullReferenceException and report it since it isn't supposed to
23501 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23503 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23504 LogicalOr and LogicalAnd that can benefit from recursively
23505 handling EmitBranchable. The code now should be nice for Paolo.
23507 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23509 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23510 the Type lookups, as we perform quite a number of lookups on
23511 non-Types. This can be removed once we can deterministically tell
23512 whether we have a type or a namespace in advance.
23514 But this might require special hacks from our corlib.
23518 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23519 and double which avoids a conversion from an integer to a double.
23521 * expression.cs: tiny optimization, avoid calling IsConstant,
23522 because it effectively performs the lookup twice.
23524 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23526 But a bogus return here to keep the semantics of the old code
23527 until the Mono runtime is fixed.
23529 * pending.cs (GetMissingInterfaces): New method used to remove all
23530 the interfaces that are already implemented by our parent
23531 classes from the list of pending methods.
23533 * interface.cs: Add checks for calls after ResolveTypeExpr.
23535 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23537 * class.cs (Class.Emit): Report warning 67: event not used if the
23538 warning level is beyond 3.
23540 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23541 being a NullLiteral.
23543 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23546 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23547 path that might fail if a type can not be resolved.
23549 * expression.cs (Binary.Emit): Emit unsigned versions of the
23552 * driver.cs: use error 5.
23554 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23556 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23558 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23560 * cs-parser.jay (switch_section): A beautiful patch from Martin
23561 Baulig that fixed 33094.
23563 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23565 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23566 Check whether the base is abstract and report an error if so.
23568 * expression.cs (IndexerAccess.DoResolveLValue,
23569 IndexerAccess.DoResolve): ditto.
23571 (Invocation.DoResolve): ditto.
23573 (Invocation.FullMethodDesc): Improve the report string.
23575 * statement.cs (Block): Eliminate IsVariableDefined as it is
23576 basically just a wrapper for GetVariableInfo.
23578 * ecore.cs (SimpleName): Use new
23580 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23581 type, as we return the actual parameter ref/unref state on a
23584 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23586 * support.cs: Return proper flags REF/OUT fixing the previous
23589 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23590 not used to mean `ref' but `ref or out' in ParameterReference
23592 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23593 full type signature instead of calling TypeManger.CSharpName
23596 * support.cs (InternalParameters.ParameterDesc): Do not compare
23597 directly to the modflags, because REF/OUT will actually be bitsets
23600 * delegate.cs (VerifyMethod): Check also the modifiers.
23602 * cs-tokenizer.cs: Fix bug where floating point values with an
23603 exponent where a sign was missing was ignored.
23605 * driver.cs: Allow multiple assemblies to be specified in a single
23608 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23610 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23611 because identifiers after a parenthesis would end up in this kind
23612 of production, and we needed to desamiguate it for having casts
23615 (UserDefinedType *) xxx
23617 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23619 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23620 we should set on the Bindingflags.NonPublic, but not turn on
23621 private_ok. private_ok controls whether a Private member is
23622 returned (this is chekced on the filter routine), while the
23623 BindingFlags.NonPublic just controls whether private/protected
23624 will be allowed. This fixes the problem part of the problem of
23625 private properties being allowed to be used in derived classes.
23627 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23628 so we can call the children DoResolveLValue method (this will
23629 properly signal errors on lvalue assignments to base properties)
23631 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23632 getter are null, and we have a property info, we know that this
23633 happened because the lookup failed, so we report an error 122 for
23634 protection level violation.
23636 We also silently return if setter and getter are null in the
23637 resolve functions, this condition only happens if we have flagged
23638 the error before. This is the other half of the problem.
23640 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23641 not have accessibility information, that is why we were returning
23642 true in the filter function in typemanager.cs.
23644 To properly report 122 (property is inaccessible because of its
23645 protection level) correctly, we report this error in ResolveAccess
23646 by failing if both the setter and the getter are lacking (ie, the
23649 DoResolve and DoLResolve have been modified to check for both
23650 setter/getter being null and returning silently, the reason being
23651 that I did not want to put the knowledge about this error in upper
23654 int old = Report.Errors;
23655 x = new PropertyExpr (...);
23656 if (old != Report.Errors)
23661 So the property expr is returned, but it is invalid, so the error
23662 will be flagged during the resolve process.
23664 * class.cs: Remove InheritablePropertySignatureCompare from the
23665 class, as we no longer depend on the property signature to compute
23666 whether it is possible to implement a method or not.
23668 The reason is that calling PropertyInfo.GetGetMethod will return
23669 null (in .NET, in Mono it works, and we should change this), in
23670 cases where the Get Method does not exist in that particular
23675 class X { public virtual int A { get { return 1; } } }
23677 class Z : Y { public override int A { get { return 2; } } }
23679 Would fail in Z because the parent (Y) would not have the property
23680 defined. So we avoid this completely now (because the alternative
23681 fix was ugly and slow), and we now depend exclusively on the
23684 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23685 reference method, instead of using the property.
23687 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23688 routines are gone now.
23690 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23691 names, they were incorrectly named.
23693 * cs-tokenizer.cs: Return are more gentle token on failure.
23695 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23696 had an out-of-sync index variable, which caused it to remove from
23697 the list of pending methods the wrong method sometimes.
23699 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23701 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23702 CanWrite, because those refer to this particular instance of the
23703 property, and do not take into account the fact that we can
23704 override single members of a property.
23706 Constructor requires an EmitContext. The resolution process does
23707 not happen here, but we need to compute the accessors before,
23708 because the resolution does not always happen for properties.
23710 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23711 subclass, before we did not update this flag, but we did update
23714 (GetAccessors): Drop this routine, as it did not work in the
23715 presence of partially overwritten set/get methods.
23717 Notice that this broke the cs1540 detection, but that will require
23720 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23724 * driver.cs: issue a warning instead of an error if we don't support
23725 debugging for the platform. Also ignore a couple of errors that may
23726 arise when trying to write the symbols. Undo my previous patch.
23728 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23730 * driver.cs: ignore /debug switch except for Unix platforms.
23732 2002-10-23 Nick Drochak <ndrochak@gol.com>
23734 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23736 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23738 * driver.cs: Do not make mcs-debug conditional, so we do not break
23739 builds that use it.
23741 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23742 review this patch. But basically after all the children variables
23743 have been merged, the value of "Breaks" was not being set to
23744 new_breaks for Switch blocks. I think that it should be set after
23745 it has executed. Currently I set this to the value of new_breaks,
23746 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23747 conservative, but I do not understand this code very well.
23749 I did not break anything in the build, so that is good ;-)
23751 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23753 2002-10-20 Mark Crichton <crichton@gimp.org>
23755 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23757 2002-10-20 Nick Drochak <ndrochak@gol.com>
23759 * cfold.cs: Fixed compile blocker.
23761 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23763 * driver.cs: I was chekcing the key, not the file.
23765 2002-10-19 Ravi Pratap <ravi@ximian.com>
23767 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23768 message that we were generating - we just need to silently return
23771 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23773 * class.cs (Event.Define): Change my previous commit, as this
23774 breaks the debugger. This is a temporary hack, as it seems like
23775 the compiler is generating events incorrectly to begin with.
23777 * expression.cs (Binary.ResolveOperator): Added support for
23778 "U operator - (E x, E y)"
23780 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23783 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23784 init-only variables, but this path did not take into account that
23785 there might be also instance readonly variables. Correct this
23788 This fixes bug 32253
23790 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23793 * driver.cs: Change the extension for modules to `netmodule'
23795 * cs-parser.jay: Improved slightly the location tracking for
23796 the debugger symbols.
23798 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23799 modifiers that were specified instead of the hardcoded value
23800 (FamAndAssem). This was basically ignoring the static modifier,
23801 and others. Fixes 32429.
23803 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23804 fixed a bug in the process (32476)
23806 * expression.cs (ArrayAccess.EmitAssign): Patch from
23807 hwang_rob@yahoo.ca that fixes bug 31834.3
23809 2002-10-18 Miguel de Icaza <miguel@ximian.com>
23811 * driver.cs: Make the module extension .netmodule.
23813 2002-10-16 Miguel de Icaza <miguel@ximian.com>
23815 * driver.cs: Report an error if the resource file is not found
23816 instead of crashing.
23818 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
23819 false, like Emit does.
23821 2002-10-16 Nick Drochak <ndrochak@gol.com>
23823 * typemanager.cs: Remove unused private member. Also reported mcs
23824 bug to report this as a warning like csc.
23826 2002-10-15 Martin Baulig <martin@gnome.org>
23828 * statement.cs (Statement.Emit): Made this a virtual method; emits
23829 the line number info and calls DoEmit().
23830 (Statement.DoEmit): New protected abstract method, formerly knows
23831 as Statement.Emit().
23833 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
23835 2002-10-11 Miguel de Icaza <miguel@ximian.com>
23837 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
23838 have fixed a remaining problem: not every AddXXXX was adding a
23839 fully qualified name.
23841 Now everyone registers a fully qualified name in the DeclSpace as
23842 being defined instead of the partial name.
23844 Downsides: we are slower than we need to be due to the excess
23845 copies and the names being registered this way.
23847 The reason for this is that we currently depend (on the corlib
23848 bootstrap for instance) that types are fully qualified, because
23849 we dump all the types in the namespace, and we should really have
23850 types inserted into the proper namespace, so we can only store the
23851 basenames in the defined_names array.
23853 2002-10-10 Martin Baulig <martin@gnome.org>
23855 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
23856 from bug #31834, see the bug report for a testcase which is
23859 2002-10-10 Martin Baulig <martin@gnome.org>
23861 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
23862 flow analysis code for this.
23864 * statement.cs (Do, While, For): Tell the flow analysis code about
23866 (FlowBranching.UsageVector): Added support for infinite loops.
23867 (Block.Resolve): Moved the dead code elimination here and use flow
23870 2002-10-09 Miguel de Icaza <miguel@ximian.com>
23872 * class.cs (Field.Define): Catch cycles on struct type
23875 * typemanager.cs (IsUnmanagedtype): Do not recursively check
23876 fields if the fields are static. We only need to check instance
23879 * expression.cs (As.DoResolve): Test for reference type.
23881 * statement.cs (Using.ResolveExpression): Use
23882 ConvertImplicitRequired, not ConvertImplicit which reports an
23884 (Using.ResolveLocalVariableDecls): ditto.
23886 * expression.cs (Binary.ResolveOperator): Report errors in a few
23887 places where we had to.
23889 * typemanager.cs (IsUnmanagedtype): Finish implementation.
23891 2002-10-08 Miguel de Icaza <miguel@ximian.com>
23893 * expression.cs: Use StoreFromPtr instead of extracting the type
23894 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
23896 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
23897 an enumeration value to a System.Enum, but System.Enum is not a
23898 value type, but an class type, so we need to box.
23900 (Expression.ConvertExplicit): One codepath could return
23901 errors but not flag them. Fix this. Fixes #31853
23903 * parameter.cs (Resolve): Do not allow void as a parameter type.
23905 2002-10-06 Martin Baulig <martin@gnome.org>
23907 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
23908 if it's a class type and not a struct. Fixes #31815.
23910 2002-10-06 Martin Baulig <martin@gnome.org>
23912 * statement.cs: Reworked the flow analysis code a bit to make it
23913 usable for dead code elimination.
23915 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23917 * cs-parser.jay: allow empty source files. Fixes bug #31781.
23919 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23921 * expression.cs (ComposedCast.DoResolveType): A quick workaround
23922 to fix the test 165, will investigate deeper.
23924 2002-10-04 Martin Baulig <martin@gnome.org>
23926 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
23927 finally blocks actually work.
23928 (Try.Resolve): We don't need to create a sibling for `finally' if
23929 there is no finally block.
23931 2002-10-04 Martin Baulig <martin@gnome.org>
23933 * class.cs (Constructor.Define): The default accessibility for a
23934 non-default constructor is private, not public.
23936 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23938 * class.cs (Constructor): Make AllowedModifiers public, add
23941 * cs-parser.jay: Perform the modifiers test here, as the
23942 constructor for the Constructor class usually receives a zero
23943 because of the way we create it (first we create, later we
23944 customize, and we were never checking the modifiers).
23946 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
23947 is a version of LookupTypeReflection that includes the type-name
23948 cache. This can be used as a fast path for functions that know
23949 the fully qualified name and are only calling into *.GetType() to
23950 obtain a composed type.
23952 This is also used by TypeManager.LookupType during its type
23955 (LookupType): We now also track the real type name, as sometimes
23956 we can get a quey for the real type name from things like
23957 ComposedCast. This fixes bug 31422.
23959 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
23960 complete type fullname, it does not have to go through the type
23961 resolution system to obtain the composed version of the type (for
23962 obtaining arrays or pointers).
23964 (Conditional.Emit): Use the EmitBoolExpression to
23965 generate nicer code, as requested by Paolo.
23967 (ArrayCreation.CheckIndices): Use the patch from
23968 hwang_rob@yahoo.ca to validate the array initializers.
23970 2002-10-03 Miguel de Icaza <miguel@ximian.com>
23972 * class.cs (ConstructorInitializer.Emit): simplify code by using
23973 Invocation.EmitCall, and at the same time, fix the bugs in calling
23974 parent constructors that took variable arguments.
23976 * ecore.cs (Expression.ConvertNumericExplicit,
23977 Expression.ImplicitNumericConversion): Remove the code that
23978 manually wrapped decimal (InternalTypeConstructor call is now gone
23981 * expression.cs (Cast.TryReduce): Also handle decimal types when
23982 trying to perform a constant fold on the type.
23984 * typemanager.cs (IsUnmanagedtype): Partially implemented.
23986 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
23987 that only turned off an error report, and did nothing else.
23989 2002-10-02 Miguel de Icaza <miguel@ximian.com>
23991 * driver.cs: Handle and ignore /fullpaths
23993 2002-10-01 Miguel de Icaza <miguel@ximian.com>
23995 * expression.cs (Binary.ResolveOperator): Catch the case where
23996 DoNumericPromotions returns true,
23998 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24000 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24002 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24005 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24007 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24008 conversion exists, but it is also required that the conversion be
24009 performed. This manifested in "(Type64Enum) 2".
24011 * class.cs (TypeManager.AddMethod): The fix is not to change
24012 AddEnum, because that one was using a fully qualified name (every
24013 DeclSpace derivative does), but to change the AddMethod routine
24014 that was using an un-namespaced name. This now correctly reports
24015 the duplicated name.
24017 Revert patch until I can properly fix it. The issue
24018 is that we have a shared Type space across all namespaces
24019 currently, which is wrong.
24021 Options include making the Namespace a DeclSpace, and merge
24022 current_namespace/current_container in the parser.
24024 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24026 * cs-parser.jay: Improve error reporting when we get a different
24027 kind of expression in local_variable_type and
24028 local_variable_pointer_type.
24030 Propagate this to avoid missleading errors being reported.
24032 * ecore.cs (ImplicitReferenceConversion): treat
24033 TypeManager.value_type as a target just like object_type. As
24038 Is valid, and needs to result in the int 1 being boxed before it
24039 is assigned to the value type v.
24041 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24042 to validate the enumeration name.
24044 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24045 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24046 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24048 * ecore.cs (TryImplicitIntConversion): When doing an
24049 implicit-enumeration-conversion, check if the type is 64-bits and
24050 perform a conversion before passing to EnumConstant.
24052 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24054 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24055 report ambiguous type references. Unlike the MS version, we
24056 report what the ambiguity is. Innovation at work ;-)
24058 (DeclSpace.FindType): Require a location argument to
24059 display when we display an ambiguous error.
24061 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24063 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24065 * expression.cs (EmitDynamicInitializers): Apply patch from
24066 hwang_rob@yahoo.ca that fixes the order in which we emit our
24069 2002-09-21 Martin Baulig <martin@gnome.org>
24071 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24072 delegate takes no arguments.
24074 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24076 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24079 * expression.cs: Extract the underlying type.
24081 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24083 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24085 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24087 * class.cs (TypeContainer.DefineType): We can not use the nice
24088 PackingSize with the size set to 1 DefineType method, because it
24089 will not allow us to define the interfaces that the struct
24092 This completes the fixing of bug 27287
24094 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24095 means also structs. This fixes part of the problem.
24096 (Expresion.ImplicitReferenceConversionExists): ditto.
24098 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24099 error if there were no errors reported during the type lookup
24100 process, to avoid duplicates or redundant errors. Without this
24101 you would get an ambiguous errors plus a type not found. We have
24102 beaten the user enough with the first error.
24104 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24107 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24108 during the resolution process, stop the lookup, this avoids
24109 repeated error reports (same error twice).
24111 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24113 * typemanager.cs (LookupType): Redo the type lookup code to match
24114 the needs of System.Reflection.
24116 The issue is that System.Reflection requires references to nested
24117 types to begin with a "+" sign instead of a dot. So toplevel
24118 types look like: "NameSpace.TopLevelClass", and nested ones look
24119 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24122 2002-09-19 Martin Baulig <martin@gnome.org>
24124 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24125 says that a method always returns or always throws an exception,
24126 don't report the CS0161.
24128 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24129 set `Returns = new_returns'.
24131 2002-09-19 Martin Baulig <martin@gnome.org>
24133 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24134 to an enum constant, check for a CS0176.
24136 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24138 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24139 for operators that must be in pairs and report errors.
24141 * ecore.cs (SimpleName.DoResolveType): During the initial type
24142 resolution process, when we define types recursively, we must
24143 check first for types in our current scope before we perform
24144 lookups in the enclosing scopes.
24146 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24148 (Invocation.VerifyArgumentsCompat): Call
24149 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24150 I thought we were supposed to always call this, but there are a
24151 few places in the code where we dont do it.
24153 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24155 * driver.cs: Add support in -linkres and -resource to specify the
24156 name of the identifier.
24158 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24160 * ecore.cs (StandardConversionExists): Sync with the conversion
24161 code: allow anything-* to void* conversions.
24163 (FindMostSpecificSource): Use an Expression argument
24164 instead of a Type, because we might be handed over a Literal which
24165 gets a few more implicit conversions that plain types do not. So
24166 this information was being lost.
24168 Also, we drop the temporary type-holder expression when not
24171 2002-09-17 Martin Baulig <martin@gnome.org>
24173 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24174 this is an explicit interface implementation.
24176 2002-09-17 Martin Baulig <martin@gnome.org>
24178 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24179 different `IndexerName' attributes.
24181 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24182 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24183 virtual CommonResolve().
24185 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24187 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24188 and convert that to the UnderlyingType.
24190 * statement.cs (Foreach.Resolve): Indexers are just like variables
24191 or PropertyAccesses.
24193 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24194 inside quoted strings, we were not doing this before.
24196 2002-09-16 Martin Baulig <martin@gnome.org>
24198 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24199 resolve it. This is needed for the definite assignment check of the
24200 instance expression, fixes bug #29846.
24201 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24203 2002-09-16 Nick Drochak <ndrochak@gol.com>
24205 * parameter.cs: Fix compile error. Cannot reference static member
24206 from an instance object. Is this an mcs bug?
24208 2002-09-14 Martin Baulig <martin@gnome.org>
24210 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24211 multiple times. Fixes bug #30295, added test-166.cs.
24213 2002-09-14 Martin Baulig <martin@gnome.org>
24215 * statement.cs (Block.Emit): Don't emit unreachable code.
24216 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24217 `break' statements.
24218 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24220 2002-09-14 Martin Baulig <martin@gnome.org>
24222 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24225 2002-09-14 Martin Baulig <martin@gnome.org>
24227 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24228 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24229 be false on the ms runtime.
24231 2002-09-13 Martin Baulig <martin@gnome.org>
24233 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24234 the CS0038 error message.
24236 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24238 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24239 constant inside, return it.
24241 2002-09-12 Martin Baulig <martin@gnome.org>
24243 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24244 implicit conversion can be done between enum types.
24246 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24247 check whether an implicit conversion to the current enum's UnderlyingType
24248 exists and report an error if not.
24250 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24251 without debugging support.
24253 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24254 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24256 2002-09-12 Martin Baulig <martin@gnome.org>
24258 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24260 * ecore.cs (IMemberExpr.DeclaringType): New property.
24261 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24262 nonstatic member of an outer type (CS0038).
24264 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24266 * driver.cs: Activate the using-error detector at warning level
24267 4 (at least for MS-compatible APIs).
24269 * namespace.cs (VerifyUsing): Small buglett fix.
24271 * pending.cs (PendingImplementation): pass the container pointer.
24273 * interface.cs (GetMethods): Allow for recursive definition. Long
24274 term, I would like to move every type to support recursive
24275 definitions, not the current ordering mechanism that we have right
24278 The situation is this: Attributes are handled before interfaces,
24279 so we can apply attributes to interfaces. But some attributes
24280 implement interfaces, we will now handle the simple cases
24281 (recursive definitions will just get an error).
24283 * parameter.cs: Only invalidate types at the end if we fail to
24286 2002-09-09 Martin Baulig <martin@gnome.org>
24288 * ecore.cs (PropertyExpr.Emit): Also check for
24289 TypeManager.system_int_array_get_length so this'll also work when
24290 compiling corlib. Fixes #30003.
24292 2002-09-09 Martin Baulig <martin@gnome.org>
24294 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24295 and throw an exception if we can't get the type's size. Fixed #30040,
24298 2002-09-09 Martin Baulig <martin@gnome.org>
24300 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24302 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24303 context. Fixes bug #30027.
24305 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24306 virtual functions. Fixes bug #30043, added test-164.cs.
24308 2002-09-08 Ravi Pratap <ravi@ximian.com>
24310 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24312 2002-09-08 Nick Drochak <ndrochak@gol.com>
24314 * driver.cs: Use an object to get the windows codepage since it's not a
24317 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24319 * statement.cs (For.Emit): for infinite loops (test == null)
24320 return whether there is a break inside, not always "true".
24322 * namespace.cs (UsingEntry): New struct to hold the name of the
24323 using definition, the location where it is defined, and whether it
24324 has been used in a successful type lookup.
24326 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24331 2002-09-06 Ravi Pratap <ravi@ximian.com>
24333 * attribute.cs : Fix incorrect code which relied on catching
24334 a NullReferenceException to detect a null being passed in
24335 where an object was expected.
24337 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24339 * statement.cs (Try): flag the catch variable as assigned
24341 * expression.cs (Cast): Simplified by using ResolveType instead of
24342 manually resolving.
24344 * statement.cs (Catch): Fix bug by using ResolveType.
24346 2002-09-06 Ravi Pratap <ravi@ximian.com>
24348 * expression.cs (BetterConversion): Special case for when we have
24349 a NullLiteral as the argument and we have to choose between string
24350 and object types - we choose string the way csc does.
24352 * attribute.cs (Attribute.Resolve): Catch the
24353 NullReferenceException and report error #182 since the Mono
24354 runtime no more has the bug and having this exception raised means
24355 we tried to select a constructor which takes an object and is
24358 2002-09-05 Ravi Pratap <ravi@ximian.com>
24360 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24361 message (1502, 1503) when we can't locate a method after overload
24362 resolution. This is much more informative and closes the bug
24365 * interface.cs (PopulateMethod): Return if there are no argument
24366 types. Fixes a NullReferenceException bug.
24368 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24369 expressions too. Previously we were checking only in one place for
24370 positional arguments leaving out named arguments.
24372 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24373 type to the enum type is not allowed. Remove code corresponding to
24376 (ConvertNumericExplicit): Allow explicit conversions from
24377 the underlying type to enum type. This precisely follows the spec
24378 and closes a bug filed by Gonzalo.
24380 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24383 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24385 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24387 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24388 it was important that we stored the right value after the
24389 reduction in `converted'.
24391 2002-09-04 Martin Baulig <martin@gnome.org>
24393 * location.cs (Location.SymbolDocument): Use full pathnames for the
24396 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24398 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24399 of the expression resolve mechanism, because that will catch the
24400 SimpleName error failures.
24402 (Conditional): If we can not resolve the
24403 expression, return, do not crash.
24405 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24408 (location): display token name instead of its number.
24410 2002-08-28 Martin Baulig <martin@gnome.org>
24412 * expression.cs (Binary.ResolveOperator): Don't silently return
24413 but return an error if an operator cannot be applied between two
24416 2002-08-28 Martin Baulig <martin@gnome.org>
24418 * class.cs (Constructor.Define): Set the permission attributes
24419 correctly instead of making all constructors public.
24421 2002-08-28 Martin Baulig <martin@gnome.org>
24423 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24424 for private members before reporting a CS0103; if we find anything,
24427 2002-08-28 Martin Baulig <martin@gnome.org>
24429 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24430 to check whether `closure_start_type == closure_invocation_type',
24431 we also need to check whether `m.DeclaringType == closure_invocation_type'
24432 before bypassing the permission checks. We might be accessing
24433 protected/private members from the base class.
24434 (TypeManager.RealMemberLookup): Only set private_ok if private
24435 members were requested via BindingFlags.NonPublic.
24437 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24439 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24440 MethodGroupExpr.IsExplicitImpl if appropriate.
24441 (Invocation.DoResolve): Don't report the CS0120 for explicit
24442 interface implementations.
24444 2002-08-27 Martin Baulig <martin@gnome.org>
24446 * expression.cs (Invocation.DoResolve): If this is a static
24447 method and we don't have an InstanceExpression, we must report
24450 2002-08-25 Martin Baulig <martin@gnome.org>
24452 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24453 `==' between a valuetype and an object.
24455 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24457 * ecore.cs (TypeExpr): Provide a ToString method.
24459 2002-08-24 Martin Baulig <martin@gnome.org>
24461 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24462 now called proggie.dbg and it's a binary file.
24464 2002-08-23 Martin Baulig <martin@gnome.org>
24466 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24468 2002-08-23 Martin Baulig <martin@gnome.org>
24470 * struct.cs (MyStructInfo.ctor): Make this work with empty
24471 structs; it's not allowed to use foreach() on null.
24473 2002-08-23 Martin Baulig <martin@gnome.org>
24475 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24476 writer the full pathname of the generated assembly.
24478 2002-08-23 Martin Baulig <martin@gnome.org>
24480 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24481 A `finally' block never returns or breaks; improved handling of
24484 2002-08-23 Martin Baulig <martin@gnome.org>
24486 * statement.cs (Throw.Resolve): Allow `throw null'.
24488 2002-08-23 Martin Baulig <martin@gnome.org>
24490 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24491 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24492 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24493 MemberLookup would return a wrong event if this is an explicit
24494 interface implementation and the class has an event with the same
24497 2002-08-23 Martin Baulig <martin@gnome.org>
24499 * statement.cs (Block.AddChildVariableNames): New public method.
24500 (Block.AddChildVariableName): Likewise.
24501 (Block.IsVariableNameUsedInChildBlock): Likewise.
24502 (Block.AddVariable): Check whether a variable name has already
24503 been used in a child block.
24505 * cs-parser.jay (declare_local_variables): Mark all variable names
24506 from the current block as being used in a child block in the
24509 2002-08-23 Martin Baulig <martin@gnome.org>
24511 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24512 find the symbol writer.
24514 * driver.cs: csc also allows the arguments to /define being
24515 separated by commas, not only by semicolons.
24517 2002-08-23 Martin Baulig <martin@gnome.org>
24519 * interface.cs (Interface.GetMembers): Added static check for events.
24521 2002-08-15 Martin Baulig <martin@gnome.org>
24523 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24524 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24526 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24527 why the MethodData.EmitDestructor() change was necessary.
24529 2002-08-20 Martin Baulig <martin@gnome.org>
24531 * class.cs (TypeContainer.FindMembers): Added static check for events.
24533 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24535 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24536 use Type.GetEvents(), not Type.FindMembers().
24538 2002-08-20 Martin Baulig <martin@gnome.org>
24540 * decl.cs (MemberCache): Added a special method cache which will
24541 be used for method-only searched. This ensures that a method
24542 search will return a MethodInfo with the correct ReflectedType for
24545 2002-08-20 Martin Baulig <martin@gnome.org>
24547 * decl.cs (DeclSpace.FindMembers): Made this public.
24549 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24551 * delegate.cs: fixed build on windows.
24552 [FIXME: Filed as bug #29150: MCS must report these errors.]
24554 2002-08-19 Ravi Pratap <ravi@ximian.com>
24556 * ecore.cs (StandardConversionExists): Return a false
24557 if we are trying to convert the void type to anything else
24558 since that is not allowed.
24560 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24561 we flag error 70 in the event an event is trying to be accessed
24562 directly from outside the declaring type.
24564 2002-08-20 Martin Baulig <martin@gnome.org>
24566 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24567 MemberCache from typemanager.cs to decl.cs.
24569 2002-08-19 Martin Baulig <martin@gnome.org>
24571 * class.cs (TypeContainer): Implement IMemberContainer.
24572 (TypeContainer.DefineMembers): Create the MemberCache.
24573 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24574 return public members if BindingFlags.Public was given, check
24575 whether members are static.
24577 2002-08-16 Martin Baulig <martin@gnome.org>
24579 * decl.cs (DeclSpace.Define): Splitted this in Define and
24580 DefineMembers. DefineMembers is called first and initializes the
24583 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24584 DefineMembers() on all our DeclSpaces.
24586 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24587 but call DefineMembers() on all nested interfaces. We call their
24588 Define() in our new Define() function.
24590 * interface.cs (Interface): Implement IMemberContainer.
24591 (Interface.Define): Moved all code except the attribute stuf to
24593 (Interface.DefineMembers): Initialize the member cache.
24595 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24596 need this anymore since we can use MemberCache.FindMembers directly.
24598 2002-08-19 Martin Baulig <martin@gnome.org>
24600 * typemanager.cs (MemberCache): When creating the cache for an
24601 interface type, add all inherited members.
24602 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24603 to `out bool used_cache' and documented it.
24604 (TypeManager.MemberLookup): If we already used the cache in the first
24605 iteration, we don't need to do the interfaces check.
24607 2002-08-19 Martin Baulig <martin@gnome.org>
24609 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24610 here from IMemberFinder and don't implement this interface anymore.
24611 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24613 * typemanager.cs (IMemberFinder): This interface is now only used by
24614 classes which actually support the member cache.
24615 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24616 since we only put DeclSpaces into this Hashtable.
24617 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24618 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24620 2002-08-16 Martin Baulig <martin@gnome.org>
24622 * typemanager.cs (ICachingMemberFinder): Removed.
24623 (IMemberFinder.MemberCache): New property.
24624 (TypeManager.FindMembers): Merged this with RealFindMembers().
24625 This function will never be called from TypeManager.MemberLookup()
24626 so we can't use the cache here, just the IMemberFinder.
24627 (TypeManager.MemberLookup_FindMembers): Check whether the
24628 IMemberFinder has a MemberCache and call the cache's FindMembers
24630 (MemberCache): Rewrote larger parts of this yet another time and
24631 cleaned it up a bit.
24633 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24635 * driver.cs (LoadArgs): Support quoting.
24637 (Usage): Show the CSC-like command line arguments.
24639 Improved a few error messages.
24641 2002-08-15 Martin Baulig <martin@gnome.org>
24643 * typemanager.cs (IMemberContainer.Type): New property.
24644 (IMemberContainer.IsInterface): New property.
24646 The following changes are conditional to BROKEN_RUNTIME, which is
24647 defined at the top of the file.
24649 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24650 class'es members, but add all members from TypeHandle.ObjectType
24651 if we're an interface.
24652 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24653 is the current type.
24654 (MemberCache.CacheEntry.Container): Removed this field.
24655 (TypeHandle.GetMembers): Include inherited members.
24657 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24659 * typemanager.cs: fixed compilation and added a comment on a field that
24662 2002-08-15 Martin Baulig <martin@gnome.org>
24664 * class.cs (ConstructorInitializer.Resolve): In the
24665 Expression.MemberLookup call, use the queried_type as
24668 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24669 declared' attribute, it's always true.
24670 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24671 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24672 temporary wrapper for FindMembers which tells MemberLookup whether
24673 members from the base classes are included in the return value.
24674 This will go away soon.
24675 (TypeManager.MemberLookup): Use this temporary hack here; once the
24676 new MemberCache is completed, we don't need to do the DeclaredOnly
24677 looping here anymore since the MemberCache will take care of this.
24678 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24679 (MemberCache): When creating the MemberCache for a class, get
24680 members from the current class and all its base classes.
24681 (MemberCache.CacheEntry.Container): New field. This is a
24682 temporary hack until the Mono runtime is fixed to distinguish
24683 between ReflectedType and DeclaringType. It allows us to use MCS
24684 with both the MS runtime and the unfixed Mono runtime without
24685 problems and without accecting performance.
24686 (MemberCache.SearchMembers): The DeclaredOnly looping from
24687 TypeManager.MemberLookup is now done here.
24689 2002-08-14 Martin Baulig <martin@gnome.org>
24691 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24692 Type.GetFields on dynamic types but get the fields from the
24693 corresponding TypeContainer.
24694 (MyStructInfo.GetStructInfo): Added check for enum types.
24696 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24697 (MemberList.SyncRoot): Implemented.
24698 (TypeManager.FilterWithClosure): No need to check permissions if
24699 closure_start_type == closure_invocation_type, don't crash if
24700 closure_invocation_type is null.
24702 2002-08-13 Martin Baulig <martin@gnome.org>
24704 Rewrote TypeContainer.FindMembers to use a member cache. This
24705 gives us a speed increase of about 35% for the self-hosting MCS
24706 build and of about 15-20% for the class libs (both on GNU/Linux).
24708 * report.cs (Timer): New class to get enhanced profiling. This
24709 whole class is "TIMER" conditional since it remarkably slows down
24712 * class.cs (MemberList): New class. This is an IList wrapper
24713 which we're now using instead of passing MemberInfo[]'s around to
24714 avoid copying this array unnecessarily.
24715 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24716 (ICachingMemberFinder, IMemberContainer): New interface.
24717 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24718 has already been checked, otherwise use it for the name comparision.
24719 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24720 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24721 if possible. Returns a MemberList, not a MemberInfo [].
24722 (TypeHandle): New class, implements IMemberContainer. We create
24723 one instance of this class per type, it contains a MemberCache
24724 which is used to do the member lookups.
24725 (MemberCache): New class. Each instance of this class contains
24726 all members of a type and a name-based hash table.
24727 (MemberCache.FindMembers): This is our new member lookup
24728 function. First, it looks up all members of the requested name in
24729 the hash table. Then, it walks this list and sorts out all
24730 applicable members and returns them.
24732 2002-08-13 Martin Baulig <martin@gnome.org>
24734 In addition to a nice code cleanup, this gives us a performance
24735 increase of about 1.4% on GNU/Linux - not much, but it's already
24736 half a second for the self-hosting MCS compilation.
24738 * typemanager.cs (IMemberFinder): New interface. It is used by
24739 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24740 Enum, Delegate or Interface.
24741 (TypeManager.finder_to_member_finder): New PtrHashtable.
24742 (TypeManager.finder_to_container): Removed.
24743 (TypeManager.finder_to_delegate): Removed.
24744 (TypeManager.finder_to_interface): Removed.
24745 (TypeManager.finder_to_enum): Removed.
24747 * interface.cs (Interface): Implement IMemberFinder.
24749 * delegate.cs (Delegate): Implement IMemberFinder.
24751 * enum.cs (Enum): Implement IMemberFinder.
24753 * class.cs (TypeContainer): Implement IMemberFinder.
24755 2002-08-12 Martin Baulig <martin@gnome.org>
24757 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24759 2002-08-12 Martin Baulig <martin@gnome.org>
24761 * ecore.cs (ITypeExpression): New interface for expressions which
24763 (TypeExpression): Renamed to TypeLookupExpression.
24764 (Expression.DoResolve): If we're doing a types-only lookup, the
24765 expression must implement the ITypeExpression interface and we
24766 call DoResolveType() on it.
24767 (SimpleName): Implement the new ITypeExpression interface.
24768 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24769 hack, the situation that we're only looking up types can't happen
24770 anymore when this method is called. Moved the type lookup code to
24771 DoResolveType() and call it.
24772 (SimpleName.DoResolveType): This ITypeExpression interface method
24773 is now doing the types-only lookup.
24774 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24775 (ResolveFlags): Added MaskExprClass.
24777 * expression.cs (MemberAccess): Implement the ITypeExpression
24779 (MemberAccess.DoResolve): Added support for a types-only lookup
24780 when we're called via ITypeExpression.DoResolveType().
24781 (ComposedCast): Implement the ITypeExpression interface.
24783 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24784 Expression.Resolve() with ResolveFlags.Type instead.
24786 2002-08-12 Martin Baulig <martin@gnome.org>
24788 * interface.cs (Interface.Define): Apply attributes.
24790 * attribute.cs (Attribute.ApplyAttributes): Added support for
24791 interface attributes.
24793 2002-08-11 Martin Baulig <martin@gnome.org>
24795 * statement.cs (Block.Emit): Only check the "this" variable if we
24796 do not always throw an exception.
24798 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24799 whether the property has a set accessor.
24801 2002-08-11 Martin Baulig <martin@gnome.org>
24803 Added control flow analysis support for structs.
24805 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
24806 with control flow analysis turned off.
24807 (IVariable): New interface.
24808 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
24809 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
24810 (FieldExpr.DoResolve): Resolve the instance expression with flow
24811 analysis turned off and do the definite assignment check after the
24812 resolving when we know what the expression will resolve to.
24814 * expression.cs (LocalVariableReference, ParameterReference):
24815 Implement the new IVariable interface, only call the flow analysis
24816 code if ec.DoFlowAnalysis is true.
24817 (This): Added constructor which takes a Block argument. Implement
24818 the new IVariable interface.
24819 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
24820 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
24821 This does the definite assignment checks for struct members.
24823 * class.cs (Constructor.Emit): If this is a non-static `struct'
24824 constructor which doesn't have any initializer, call
24825 Block.AddThisVariable() to tell the flow analysis code that all
24826 struct elements must be initialized before control returns from
24829 * statement.cs (MyStructInfo): New public class.
24830 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
24831 argument to this indexer. If non-zero, check an individual struct
24832 member, not the whole struct.
24833 (FlowBranching.CheckOutParameters): Check struct members.
24834 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
24835 overloaded versions of these methods which take an additional
24836 `int field_idx' argument to check struct members.
24837 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
24838 overloaded versions of these methods which take an additional
24839 `string field_name' argument to check struct member.s
24840 (VariableInfo): Implement the IVariable interface.
24841 (VariableInfo.StructInfo): New public property. Returns the
24842 MyStructInfo instance of the variable if it's a struct or null.
24843 (Block.AddThisVariable): New public method. This is called from
24844 Constructor.Emit() for non-static `struct' constructor which do
24845 not have any initializer. It creates a special variable for the
24846 "this" instance variable which will be checked by the flow
24847 analysis code to ensure that all of the struct's fields are
24848 initialized before control returns from the constructor.
24849 (UsageVector): Added support for struct members. If a
24850 variable/parameter is a struct with N members, we reserve a slot
24851 in the usage vector for each member. A struct is considered fully
24852 initialized if either the struct itself (slot 0) or all its
24853 members are initialized.
24855 2002-08-08 Martin Baulig <martin@gnome.org>
24857 * driver.cs (Driver.MainDriver): Only report an error CS5001
24858 if there were no compilation errors.
24860 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
24861 `UnsafeContext' property to determine whether the parent is in
24862 unsafe context rather than checking the parent's ModFlags:
24863 classes nested in an unsafe class are unsafe as well.
24865 2002-08-08 Martin Baulig <martin@gnome.org>
24867 * statement.cs (UsageVector.MergeChildren): Distinguish between
24868 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
24869 we return. Added test17() and test18() to test-154.cs.
24871 2002-08-08 Martin Baulig <martin@gnome.org>
24873 * typemanager.cs (TypeManager.FilterWithClosure): If we have
24874 Family access, make sure the invoking type isn't a subclass of the
24875 queried type (that'd be a CS1540).
24877 * ecore.cs (Expression.MemberLookup): Added overloaded version of
24878 this method which takes an additional `Type invocation_type'.
24880 * expression.cs (BaseAccess.DoResolve): Use the base type as
24881 invocation and query type.
24882 (MemberAccess.DoResolve): If the lookup failed and we're about to
24883 report a CS0122, try a lookup with the ec.ContainerType - if this
24884 succeeds, we must report a CS1540.
24886 2002-08-08 Martin Baulig <martin@gnome.org>
24888 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
24889 (MethodGroupExpr): Implement the IMemberExpr interface.
24891 * expression (MemberAccess.ResolveMemberAccess): No need to have
24892 any special code for MethodGroupExprs anymore, they're now
24895 2002-08-08 Martin Baulig <martin@gnome.org>
24897 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
24898 Family, FamANDAssem and FamORAssem permissions.
24899 (TypeManager.IsSubclassOrNestedChildOf): New public method.
24901 2002-08-08 Martin Baulig <martin@gnome.org>
24903 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
24904 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
24907 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
24909 * driver.cs: implemented /resource option to embed managed resources.
24911 2002-08-07 Martin Baulig <martin@gnome.org>
24913 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
24914 (FieldBase.HasFieldInitializer): New public property.
24915 (FieldBase.GetInitializerExpression): New public method. Resolves and
24916 returns the field initializer and makes sure it is only resolved once.
24917 (TypeContainer.EmitFieldInitializers): Call
24918 FieldBase.GetInitializerExpression to get the initializer, this ensures
24919 that it isn't resolved multiple times.
24921 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
24922 the resolving process (SimpleName/MemberLookup) that we're currently
24923 emitting a field initializer (which must not access any instance members,
24924 this is an error CS0236).
24926 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
24927 argument, if the `IsFieldInitializer' flag is set, we must report and
24928 error CS0236 and not an error CS0120.
24930 2002-08-07 Martin Baulig <martin@gnome.org>
24932 * ecore.cs (IMemberExpr): New public interface.
24933 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
24934 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
24935 if the expression is an IMemberExpr.
24937 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
24938 to be null, implicitly default to `this' if we're non-static in
24939 this case. Simplified the code a lot by using the new IMemberExpr
24940 interface. Also fixed bug #28176 here.
24942 2002-08-06 Martin Baulig <martin@gnome.org>
24944 * cs-parser.jay (SimpleLookup): Removed. We need to create
24945 ParameterReferences during semantic analysis so that we can do a
24946 type-only search when resolving Cast, TypeOf and SizeOf.
24947 (block): Pass the `current_local_parameters' to the Block's
24950 * class.cs (ConstructorInitializer): Added `Parameters parameters'
24951 argument to the constructor.
24952 (ConstructorInitializer.Resolve): Create a temporary implicit
24953 block with the parameters.
24955 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
24956 references here if we aren't doing a type-only search.
24958 * statement.cs (Block): Added constructor which takes a
24959 `Parameters parameters' argument.
24960 (Block.Parameters): New public property.
24962 * support.cs (InternalParameters.Parameters): Renamed `parameters'
24963 to `Parameters' and made it public readonly.
24965 2002-08-06 Martin Baulig <martin@gnome.org>
24967 * ecore.cs (Expression.Warning): Made this public as well.
24969 * report.cs (Report.Debug): Print the contents of collections.
24971 2002-08-06 Martin Baulig <martin@gnome.org>
24973 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
24974 used to tell Resolve() which kinds of expressions it may return.
24975 (Expression.Resolve): Added overloaded version of this method which
24976 takes a `ResolveFlags flags' argument. This can be used to tell
24977 Resolve() which kinds of expressions it may return. Reports a
24979 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
24980 ResolveFlags.SimpleName.
24981 (Expression.Error118): Added overloaded version of this method which
24982 takes a `ResolveFlags flags' argument. It uses the flags to determine
24983 which kinds of expressions are allowed.
24985 * expression.cs (Argument.ResolveMethodGroup): New public method.
24986 Resolves an argument, but allows a MethodGroup to be returned.
24987 This is used when invoking a delegate.
24989 * TODO: Updated a bit.
24991 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24993 Fixed compilation with csc.
24995 * ecore.cs: Expression.Error made public. Is this correct? Should
24996 Warning be made public too?
24998 * expression.cs: use ea.Location instead of ea.loc.
24999 [FIXME: Filed as bug #28607: MCS must report these errors.]
25001 2002-08-06 Martin Baulig <martin@gnome.org>
25003 * ecore.cs (Expression.loc): Moved the location here instead of
25004 duplicating it in all derived classes.
25005 (Expression.Location): New public property.
25006 (Expression.Error, Expression.Warning): Made them non-static and
25007 removed the location argument.
25008 (Expression.Warning): Added overloaded version which takes an
25009 `int level' argument.
25010 (Expression.Error118): Make this non-static and removed the
25011 expression and location arguments.
25012 (TypeExpr): Added location argument to the constructor.
25014 * expression.cs (StaticCallExpr): Added location argument to
25016 (Indirection, PointerArithmetic): Likewise.
25017 (CheckedExpr, UnCheckedExpr): Likewise.
25018 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25019 (StringPtr): Likewise.
25022 2002-08-05 Martin Baulig <martin@gnome.org>
25024 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25026 * assign.cs (Assign.DoResolve): Check whether the source
25027 expression is a value or variable.
25029 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25030 while resolving the corresponding blocks.
25032 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25033 an error, don't silently return null.
25035 * statement.cs (Block.AddVariable): Do the error reporting here
25036 and distinguish between CS0128 and CS0136.
25037 (Block.DoResolve): Report all unused labels (warning CS0164).
25038 (LabeledStatement): Pass the location to the constructor.
25039 (LabeledStatement.HasBeenReferenced): New property.
25040 (LabeledStatement.Resolve): Set it to true here.
25042 * statement.cs (Return.Emit): Return success even after reporting
25043 a type mismatch error (CS0126 or CS0127), this is what csc does and
25044 it avoids confusing the users with any consecutive errors.
25046 2002-08-05 Martin Baulig <martin@gnome.org>
25048 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25050 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25052 * expression.cs (MemberAccess.DoResolve): Silently return if an
25053 error has already been reported.
25055 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25056 error has already been reported.
25058 2002-08-05 Martin Baulig <martin@gnome.org>
25060 * statement.cs (UsageVector): Only initialize the `parameters'
25061 vector if we actually have any "out" parameters.
25063 2002-08-05 Martin Baulig <martin@gnome.org>
25065 * expression.cs (Binary.ResolveOperator): When combining delegates,
25066 they must have the same type.
25068 2002-08-05 Martin Baulig <martin@gnome.org>
25070 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25071 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25072 work with the ms runtime and we also don't need it: if we're a
25073 PropertyBuilder and not in the `indexer_arguments' hash, then we
25074 are a property and not an indexer.
25076 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25077 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25078 since the latter one doesn't work with the ms runtime.
25080 2002-08-03 Martin Baulig <martin@gnome.org>
25082 Fixed bugs #27998 and #22735.
25084 * class.cs (Method.IsOperator): New public field.
25085 (Method.CheckBase): Report CS0111 if there's already a method
25086 with the same parameters in the current class. Report CS0508 when
25087 attempting to change the return type of an inherited method.
25088 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25089 and it's not marked abstract or extern.
25090 (PropertyBase): New abstract base class for Property and Indexer.
25091 (PropertyBase.CheckBase): Moved here from Property and made it work
25093 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25094 the same so we can reuse it there.
25095 (Property, Indexer): Derive from PropertyBase.
25096 (MethodSignature.inheritable_property_signature_filter): New delegate
25097 to find properties and indexers.
25099 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25100 argument and improved error reporting.
25102 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25103 EmptyReadOnlyParameters and made it a property.
25105 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25106 version of this method which takes a `PropertyInfo indexer'.
25107 (TypeManager.RegisterIndexer): New method.
25109 * class.cs: Added myself as author of this file :-)
25111 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25113 * class.cs: fixed compilation on windoze.
25115 2002-08-03 Martin Baulig <martin@gnome.org>
25117 * interface.cs (Interface.GetInterfaceBases): Check whether all
25118 base interfaces are at least as accessible than the current one.
25120 * class.cs (TypeContainer.GetClassBases): Check whether base types
25121 are at least as accessible than the current type.
25122 (TypeContainer.AsAccessible): Implemented and made non-static.
25123 (MemberBase.CheckParameters): Report errors if the accessibility
25126 * delegate.cs (Delegate.Delegate): The default visibility is
25127 internal for top-level types and private for nested types.
25128 (Delegate.Define): Report errors if the accessibility checks fail.
25130 * enum.cs (Enum.Enum): The default visibility is internal for
25131 top-level types and private for nested types.
25132 (Enum.DefineType): Compute the correct visibility.
25134 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25135 function which takes a `bool is_toplevel' instead of a TypeContainer.
25137 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25140 2002-08-02 Martin Baulig <martin@gnome.org>
25142 * expression.cs (LocalVariableReferenc): Added constructor which
25143 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25144 (LocalVariableReference.IsReadOnly): New property.
25145 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25146 variable is readonly, use our own readonly flag to do this; you can
25147 use the new constructor to get a writable reference to a read-only
25150 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25151 reference to the local variable.
25153 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25155 * rootcontext.cs (ResolveCore): Also include System.Exception
25157 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25158 we reach an EmptyStatement.
25160 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25163 * expression.cs (Binary.ResolveOperator): Check error result in
25166 use brtrue/brfalse directly and avoid compares to null.
25168 2002-08-02 Martin Baulig <martin@gnome.org>
25170 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25171 Fixes bug #28407, added test-155.cs.
25173 2002-08-01 Martin Baulig <martin@gnome.org>
25175 * class.cs (Event.EmitDefaultMethod): Make this work with static
25176 events. Fixes #28311, added verify-3.cs.
25178 2002-08-01 Martin Baulig <martin@gnome.org>
25180 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25181 `is_disposable' fields.
25182 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25183 `hm.is_disposable' if we're using the collection pattern.
25184 (Foreach.EmitCollectionForeach): Use the correct type for the
25185 enumerator's local variable, only emit the try/finally block if
25186 necessary (fixes #27713).
25188 2002-08-01 Martin Baulig <martin@gnome.org>
25190 * ecore.cs (Expression.report118): Renamed to Error118 and made
25193 * statement.cs (Throw.Resolve): Check whether the expression is of
25194 the correct type (CS0118) and whether the type derives from
25195 System.Exception (CS0155).
25196 (Catch.Resolve): New method. Do the type lookup here and check
25197 whether it derives from System.Exception (CS0155).
25198 (Catch.CatchType, Catch.IsGeneral): New public properties.
25200 * typemanager.cs (TypeManager.exception_type): Added.
25202 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25204 * driver.cs: Updated About function.
25206 2002-07-31 Martin Baulig <martin@gnome.org>
25208 Implemented Control Flow Analysis.
25210 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25211 (EmitContext.CurrentBranching): Added.
25212 (EmitContext.StartFlowBranching): Added.
25213 (EmitContext.EndFlowBranching): Added.
25214 (EmitContext.KillFlowBranching): Added.
25215 (EmitContext.IsVariableAssigned): Added.
25216 (EmitContext.SetVariableAssigned): Added.
25217 (EmitContext.IsParameterAssigned): Added.
25218 (EmitContext.SetParameterAssigned): Added.
25219 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25220 Added control flow analysis stuff here.
25222 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25223 resolve the expression as lvalue.
25224 (LocalVariableReference.DoResolve): Check whether the variable has
25225 already been assigned.
25226 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25227 the parameter as assigned here.
25228 (ParameterReference.DoResolve): Check whether the parameter has already
25230 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25231 expression as lvalue.
25233 * statement.cs (FlowBranching): New class for the flow analysis code.
25234 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25235 (LabeledStatement.IsDefined): New public property.
25236 (LabeledStatement.AddUsageVector): New public method to tell flow
25237 analyis that the label may be reached via a forward jump.
25238 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25240 (VariableInfo.Number): New public field. This is used by flow analysis
25241 to number all locals of a block.
25242 (Block.CountVariables): New public property. This is the number of
25243 local variables in this block (including the locals from all parent
25245 (Block.EmitMeta): Number all the variables.
25247 * statement.cs: Added flow analysis support to all classes.
25249 2002-07-31 Martin Baulig <martin@gnome.org>
25251 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25252 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25253 then use this argument.
25255 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25257 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25258 use this to specify /define options.
25260 2002-07-29 Martin Baulig <martin@gnome.org>
25262 * statement.cs (Fixed): Moved all code that does variable lookups
25263 and resolvings from Emit to Resolve.
25265 * statement.cs (For): Moved all code that does variable lookups
25266 and resolvings from Emit to Resolve.
25268 * statement.cs (Using): Moved all code that does variable lookups
25269 and resolvings from Emit to Resolve.
25271 2002-07-29 Martin Baulig <martin@gnome.org>
25273 * attribute.cs (Attribute.Resolve): Explicitly catch a
25274 System.NullReferenceException when creating the
25275 CustromAttributeBuilder and report a different warning message.
25277 2002-07-29 Martin Baulig <martin@gnome.org>
25279 * support.cs (ParameterData.ParameterName): Added method to
25280 get the name of a parameter.
25282 * typemanager.cs (TypeManager.IsValueType): New public method.
25284 2002-07-29 Martin Baulig <martin@gnome.org>
25286 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25287 is a flag which specifies that it's either ref or out.
25288 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25289 the out parameter to `out Parameter.Modifier mod', also set the
25290 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25292 * support.cs (InternalParameters.ParameterModifier): Distinguish
25293 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25294 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25296 * expression.cs (Argument.GetParameterModifier): Distinguish
25297 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25298 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25300 2002-07-29 Martin Baulig <martin@gnome.org>
25302 * expression.cs (ParameterReference.ParameterReference): Added
25303 `Location loc' argument to the constructor.
25305 * cs-parser.jay: Pass location to ParameterReference.
25307 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25309 * statement.cs (Try): Initialize the location.
25311 * cs-parser.jay: pass location to Try.
25313 * expression.cs (Unary.Reduce): Change the prototype to return
25314 whether a constant fold could be performed or not. The result is
25315 returned in an out parameters. In the case of Indirection and
25316 AddressOf, we want to perform the full tests.
25318 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25320 * statement.cs (Statement.Emit): Flag dead code.
25322 2002-07-27 Andrew Birkett <andy@nobugs.org>
25324 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25326 2002-07-27 Martin Baulig <martin@gnome.org>
25328 * class.cs (MethodData.Define): Put back call to
25329 TypeManager.AddMethod(), accidentally commented this out.
25331 * report.cs (Debug): New public method to print debugging information,
25332 this is `[Conditional ("DEBUG")]'.
25334 2002-07-26 Martin Baulig <martin@gnome.org>
25336 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25337 (switch_statement): Push the current_block to the switch_stack and
25338 pop it again when we're done with the switch.
25339 (switch_section): The new block is a child of the current_block.
25340 Fixes bug #24007, added test-152.cs.
25342 2002-07-27 Martin Baulig <martin@gnome.org>
25344 * expression.cs (Invocation.EmitArguments): When calling a varargs
25345 function with only its fixed arguments, we need to pass an empty
25348 2002-07-27 Martin Baulig <martin@gnome.org>
25350 Mono 0.13 has been released.
25352 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25354 * driver.cs: Rename --resource to --linkres, because that is what
25355 we do currently, we dont support --resource yet.
25357 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25359 2002-07-25 Martin Baulig <martin@gnome.org>
25361 * class.cs (MethodData): New public class. This is a `method builder'
25362 class for a method or one accessor of a Property/Indexer/Event.
25363 (MethodData.GetMethodFlags): Moved here from MemberBase.
25364 (MethodData.ApplyAttributes): Likewise.
25365 (MethodData.ApplyObsoleteAttribute): Likewise.
25366 (MethodData.ApplyConditionalAttribute): Likewise.
25367 (MethodData.ApplyDllImportAttribute): Likewise.
25368 (MethodData.CheckAbstractAndExternal): Likewise.
25369 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25370 (MethodData.Emit): Formerly known as Method.Emit().
25371 (MemberBase): Moved everything which was specific to a single
25372 accessor/method to MethodData.
25373 (Method): Create a new MethodData and call Define() and Emit() on it.
25374 (Property, Indexer, Event): Create a new MethodData objects for each
25375 accessor and call Define() and Emit() on them.
25377 2002-07-25 Martin Baulig <martin@gnome.org>
25379 Made MethodCore derive from MemberBase to reuse the code from there.
25380 MemberBase now also checks for attributes.
25382 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25383 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25385 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25386 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25387 (MemberBase.ApplyAttributes): New virtual method; applies the
25388 attributes to a method or accessor.
25389 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25390 (MemberBase.ApplyConditionalAttribute): Likewise.
25391 (MemberBase.ApplyDllImportAttribute): Likewise.
25392 (MemberBase.CheckAbstractAndExternal): Likewise.
25393 (MethodCore.ParameterTypes): This is now a property instead of a
25394 method, it's initialized from DoDefineParameters().
25395 (MethodCore.ParameterInfo): Removed the set accessor.
25396 (MethodCore.DoDefineParameters): New protected virtual method to
25397 initialize ParameterTypes and ParameterInfo.
25398 (Method.GetReturnType): We can now simply return the MemberType.
25399 (Method.GetMethodFlags): Override the MemberBase version and add
25400 the conditional flags.
25401 (Method.CheckBase): Moved some code from Define() here, call
25402 DoDefineParameters() here.
25403 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25404 here to avoid some larger code duplication.
25405 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25406 ensure that abstract and external accessors don't declare a body.
25408 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25409 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25410 lookup in the attribute's parent classes, so we need to abort as soon
25411 as we found the first match.
25412 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25413 the attribute has no arguments.
25415 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25418 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25420 * cs-parser.jay: reverted previous patch.
25422 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25424 * cs-parser.jay: fixed bug #22119.
25426 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25428 * attribute.cs: fixed compilation. The error was:
25429 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25430 be assigned to before control leaves the current method."
25431 [FIXME: Filed as bug #28186: MCS must report this error.]
25433 2002-07-25 Martin Baulig <martin@gnome.org>
25435 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25436 method to pull the condition name ouf of a Conditional attribute.
25437 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25438 the obsolete message and error flag out of an Obsolete attribute.
25440 * class.cs (Method.GetMethodFlags): New public method to get the
25441 TypeManager.MethodFlags for this method.
25442 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25444 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25445 if we're overriding a virtual function, set the new private variable
25446 `parent_method'; call the new TypeManager.AddMethod().
25448 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25449 the MethodBuilder and the Method in a PtrHashtable.
25450 (TypeManager.builder_to_method): Added for this purpose.
25451 (TypeManager.MethodFlags): Added IsObsoleteError.
25452 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25453 Obsolete and Conditional arguments in MethodBuilders. If we discover
25454 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25455 the message from the attribute.
25457 2002-07-24 Martin Baulig <martin@gnome.org>
25459 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25460 preprocessor directives, ensure that the argument to #define/#undef is
25461 exactly one identifier and that it's actually an identifier.
25463 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25466 2002-07-24 Martin Baulig <martin@gnome.org>
25468 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25469 initialize it to TypeManager.object_type in the constructor.
25470 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25471 of the `hm.get_current' method if we're using the collection pattern.
25472 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25473 for the explicit conversion to make it work when we're using the collection
25474 pattern and the `Current' property has a different return type than `object'.
25477 2002-07-24 Martin Baulig <martin@gnome.org>
25479 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25480 does not match, but don't report any errors. This method is called in
25481 order for all methods in a MethodGroupExpr until a matching method is
25482 found, so we don't want to bail out if the first method doesn't match.
25483 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25484 matches, report the 123. Fixes #28070.
25486 2002-07-24 Martin Baulig <martin@gnome.org>
25488 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25489 TypeManager.TypeToCoreType() to the top of the method so the
25490 following equality checks will work. Fixes #28107.
25492 2002-07-24 Martin Baulig <martin@gnome.org>
25494 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25495 operand is of type uint, and the other operand is of type sbyte,
25496 short or int, the operands are converted to type long." -
25497 Actually do what this comment already told us. Fixes bug #28106,
25500 2002-07-24 Martin Baulig <martin@gnome.org>
25502 * class.cs (MethodBase): New abstract class. This is now a base
25503 class for Property, Indexer and Event to avoid some code duplication
25504 in their Define() and DefineMethods() methods.
25505 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25506 generic methods for Define() and DefineMethods().
25507 (FieldBase): Derive from MemberBase, not MemberCore.
25508 (Property): Derive from MemberBase, not MemberCore.
25509 (Property.DefineMethod): Moved all the code from this method to the
25510 new MethodBase.DefineAccessor(), just call it with appropriate
25512 (Property.Define): Call the new Property.DoDefine(), this does some
25513 sanity checks and we don't need to duplicate the code everywhere.
25514 (Event): Derive from MemberBase, not MemberCore.
25515 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25516 accessors, this will also make them work with interface events.
25517 (Indexer): Derive from MemberBase, not MemberCore.
25518 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25519 (Indexer.Define): Use the new MethodBase functions.
25521 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25522 argument to the constructor.
25523 (Interface.FindMembers): Added support for interface events.
25524 (Interface.PopluateEvent): Implemented.
25526 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25528 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25530 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25531 but this is required to check for a method name being the same as
25532 the containing class.
25536 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25538 * interface.cs: initialize variable.
25540 2002-07-23 Martin Baulig <martin@gnome.org>
25542 Implemented the IndexerName attribute in interfaces.
25544 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25545 name if this is an explicit interface implementation.
25546 (Indexer.InterfaceIndexerName): New public variable. If we're
25547 implementing an interface indexer, this is the IndexerName in that
25548 interface. Otherwise, it's the IndexerName.
25549 (Indexer.DefineMethod): If we're implementing interface indexer,
25550 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25551 and Pending.ImplementIndexer methods.
25552 (Indexer.Define): Also define the PropertyBuilder if we're
25553 implementing an interface indexer and this is neither an explicit
25554 interface implementation nor do the IndexerName match the one in
25557 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25558 If a method is defined here, then we always need to create a proxy
25559 for it. This is used when implementing interface indexers.
25560 (Pending.IsInterfaceIndexer): New public method.
25561 (Pending.ImplementIndexer): New public method.
25562 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25563 This is used when implementing interface indexers to define a proxy
25565 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25566 define a proxy if necessary.
25568 * interface.cs (Interface.IndexerName): New public variable.
25569 (Interface.PopulateIndexer): Set the IndexerName.
25570 (Interface.DefineIndexers): New private method. Populate all the
25571 indexers and make sure their IndexerNames match.
25573 * typemanager.cs (IndexerPropertyName): Added support for interface
25576 2002-07-22 Martin Baulig <martin@gnome.org>
25578 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25579 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25580 ret if HasReturnLabel.
25581 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25584 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25585 and set the ec.LoopBeginTryCatchLevel.
25586 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25587 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25588 the current ec.TryCatchLevel, the branch goes out of an exception
25589 block. In this case, we need to use Leave and not Br.
25591 2002-07-22 Martin Baulig <martin@gnome.org>
25593 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25594 block unless the block does not always return or it is contained in
25595 another try { ... } catch { ... } block. Fixes bug #26506.
25596 Added verify-1.cs to the test suite.
25598 2002-07-22 Martin Baulig <martin@gnome.org>
25600 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25601 then we do not always return. Fixes bug #24985.
25603 2002-07-22 Martin Baulig <martin@gnome.org>
25605 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25606 lookup on a per-class level; ie. walk up the class hierarchy until we
25607 found at least one applicable method, then choose the best among them.
25608 Fixes bug #24463 and test-29.cs.
25610 2002-07-22 Martin Baulig <martin@gnome.org>
25612 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25613 return types of the methods. The return type is not part of the
25614 signature and we must not check it to make the `new' modifier work.
25615 Fixes bug #27999, also added test-147.cs.
25616 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25618 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25619 on the method's return type.
25621 2002-07-21 Martin Baulig <martin@gnome.org>
25623 * assign.cs: Make this work if the rightmost source is a constant and
25624 we need to do an implicit type conversion. Also adding a few more tests
25625 to test-38.cs which should have caught this.
25627 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25628 target in the makefile for this. The makefile.gnu is primarily intended
25629 for end-users who don't want to debug the compiler.
25631 2002-07-21 Martin Baulig <martin@gnome.org>
25633 * assign.cs: Improved the Assign class so it can now handle embedded
25634 assignments (X = Y = Z = something). As a side-effect this'll now also
25635 consume less local variables. test-38.cs now passes with MCS, added
25636 a few new test cases to that test.
25638 2002-07-20 Martin Baulig <martin@gnome.org>
25640 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25641 instructions. Fixes bug #27977, also added test-146.cs.
25643 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25645 * cs-tokenizer.cs: fixed getHex ().
25647 2002-07-19 Martin Baulig <martin@gnome.org>
25649 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25650 not Type.GetType() to lookup the array type. This is needed when
25651 we're constructing an array of a user-defined type.
25652 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25653 single-dimensional arrays, but also for single-dimensial arrays of
25656 2002-07-19 Martin Baulig <martin@gnome.org>
25658 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25659 this function is called, it's not allowed to share LocalBuilders
25660 among ILGenerators.
25662 2002-07-19 Martin Baulig <martin@gnome.org>
25664 * expression.cs (Argument.Resolve): Report an error 118 when trying
25665 to pass a type as argument.
25667 2002-07-18 Martin Baulig <martin@gnome.org>
25669 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25670 Conv_R_Un for the signed `long' type.
25672 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25674 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25675 `expr' for the temporary result, as that will fail if we do
25676 multiple resolves on the same expression.
25678 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25680 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25681 ec.TypeContainer for looking up aliases.
25683 * class.cs (TypeContainer): Remove LookupAlias from here.
25685 * decl.cs (DeclSpace); Move here.
25687 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25689 * class.cs (FindMembers): Only call filter if the constructor
25690 bulider is not null.
25692 Also handle delegates in `NestedTypes' now. Now we will perform
25693 type lookups using the standard resolution process. This also
25696 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25697 This uses Expressions (the limited kind that can be parsed by the
25698 tree) instead of strings.
25700 * expression.cs (ComposedCast.ToString): Implement, used to flag
25701 errors since now we have to render expressions.
25703 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25706 * ecore.cs (SimpleName.ToString): ditto.
25708 * cs-parser.jay: Instead of using strings to assemble types, use
25709 Expressions to assemble the type (using SimpleName, ComposedCast,
25710 MemberAccess). This should fix the type lookups in declarations,
25711 because we were using a different code path for this.
25713 * statement.cs (Block.Resolve): Continue processing statements
25714 even when there is an error.
25716 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25718 * class.cs (Event.Define): Also remove the `remove' method from
25719 the list of pending items.
25721 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25722 generate more compact code.
25724 2002-07-17 Martin Baulig <martin@gnome.org>
25726 * const.cs (Const.LookupConstantValue): Add support for constant
25727 `unchecked' and `checked' expressions.
25728 Also adding test case test-140.cs for this.
25730 2002-07-17 Martin Baulig <martin@gnome.org>
25732 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25733 check whether mi.ReturnType implements the IEnumerator interface; the
25734 `==' and the IsAssignableFrom() will fail in this situation.
25736 2002-07-16 Ravi Pratap <ravi@ximian.com>
25738 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25741 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25743 * expression.cs: fixed bug #27811.
25745 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25747 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25748 Molaro: when we are a ref, the value already contains a pointer
25749 value, do not take the address of it.
25751 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25752 * removed mb-parser.jay and mb-tokenizer.cs
25754 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25756 * expression.cs: check against the building corlib void type.
25758 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25760 * ecore.cs: fix for valuetype static readonly fields: when
25761 initializing them, we need their address, not the address of a copy.
25763 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25765 * typemanager.cs: register also enum_type in corlib.
25767 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25769 * class.cs: allow calling this (but not base) initializers in structs.
25771 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25773 * ecore.cs: make sure we compare against the building base types
25776 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25778 * typemanager.cs: fix TypeToCoreType() to handle void and object
25779 (corlib gets no more typerefs after this change).
25781 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25783 * expression.cs (ArrayCreation.EmitArrayArguments): use
25784 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25786 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25787 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25788 array indexes, the runtime actually forbids them.
25790 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25791 for array arguments here.
25793 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25794 instead of the default for ValueTypes.
25796 (New.DoEmit): Use IsValueType instead of
25797 IsSubclassOf (value_type)
25798 (New.DoResolve): ditto.
25799 (Invocation.EmitCall): ditto.
25801 * assign.cs (Assign): ditto.
25803 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25804 Statements *are* currently doing part of their resolution during
25807 Expressions do always resolve during resolve, but statements are
25808 only required to propagate resolution to their children.
25810 2002-07-11 Miguel de Icaza <miguel@ximian.com>
25812 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
25814 (LoadAssembly): Do not add the dll if it is already specified
25816 (MainDriver): Add the System directory to the link path at the end,
25817 after all the other -L arguments.
25819 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
25820 wrong opcode for loading bytes and bools (ldelem.i1 instead of
25821 ldelem.u1) and using the opposite for sbytes.
25823 This fixes Digger, and we can finally run it.
25825 * driver.cs (UnixParseOption): Move the option parsing here.
25826 (CSCParseOption): Implement CSC-like parsing of options.
25828 We now support both modes of operation, the old Unix way, and the
25829 new CSC-like way. This should help those who wanted to make cross
25830 platform makefiles.
25832 The only thing broken is that /r:, /reference: and /lib: are not
25833 implemented, because I want to make those have the same semantics
25834 as the CSC compiler has, and kill once and for all the confussion
25835 around this. Will be doing this tomorrow.
25837 * statement.cs (Unsafe.Resolve): The state is checked during
25838 resolve, not emit, so we have to set the flags for IsUnsfe here.
25840 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25842 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
25843 not catch the Error_ObjectRefRequired in SimpleName (as it is
25844 possible to have a class/instance variable name that later gets
25845 deambiguated), we have to check this here.
25847 2002-07-10 Ravi Pratap <ravi@ximian.com>
25849 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
25850 make static and put into Expression.
25852 (Event.Define): Register the private field of the event with the
25853 TypeManager so that GetFieldFromEvent can get at it.
25855 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
25856 keep track of the private field associated with an event which
25859 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
25862 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
25864 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25866 * expression.cs (Binary.EmitBranchable): this routine emits the
25867 Binary expression in a branchable context. This basically means:
25868 we need to branch somewhere, not just get the value on the stack.
25870 This works together with Statement.EmitBoolExpression.
25872 * statement.cs (Statement.EmitBoolExpression): Use
25875 2002-07-09 Miguel de Icaza <miguel@ximian.com>
25877 * statement.cs (For): Reduce the number of jumps in loops.
25879 (For): Implement loop inversion for the For statement.
25881 (Break): We can be breaking out of a Try/Catch controlled section
25882 (foreach might have an implicit try/catch clause), so we need to
25883 use Leave instead of Br.
25885 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
25886 now). If the instace expression supports IMemoryLocation, we use
25887 the AddressOf method from the IMemoryLocation to extract the
25888 address instead of emitting the instance.
25890 This showed up with `This', as we were emitting the instance
25891 always (Emit) instead of the Address of This. Particularly
25892 interesting when This is a value type, as we dont want the Emit
25893 effect (which was to load the object).
25895 2002-07-08 Miguel de Icaza <miguel@ximian.com>
25897 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
25899 * statement.cs (Checked): Set the CheckedState during the resolve
25900 process too, as the ConvCast operations track the checked state on
25901 the resolve process, and not emit.
25903 * cs-parser.jay (namespace_member_declaration): Flag that we have
25904 found a declaration when we do. This is used to flag error 1529
25906 * driver.cs: Report ok when we display the help only.
25908 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
25910 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
25912 2002-07-04 Miguel de Icaza <miguel@ximian.com>
25914 * cs-tokenizer.cs (define): We also have to track locally the
25915 defines. AllDefines is just used for the Conditional Attribute,
25916 but we also need the local defines for the current source code.
25918 2002-07-03 Miguel de Icaza <miguel@ximian.com>
25920 * statement.cs (While, For, Do): These loops can exit through a
25921 Break statement, use this information to tell whether the
25922 statement is the last piece of code.
25924 (Break): Flag that we break.
25926 * codegen.cs (EmitContexts): New `Breaks' state variable.
25928 2002-07-03 Martin Baulig <martin@gnome.org>
25930 * class.cs (TypeContainer.MethodModifiersValid): Allow override
25931 modifiers in method declarations in structs. Otherwise, you won't
25932 be able to override things like Object.Equals().
25934 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25936 * class.cs (Method, Property, Indexer): Do not allow the public
25937 modifier to be used in explicit interface implementations.
25939 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
25940 override modifiers in method declarations in structs
25942 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
25944 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
25945 integer or real overflow, report an error
25947 2002-07-02 Martin Baulig <martin@gnome.org>
25949 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
25950 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
25951 to tell the runtime about our newly created System.Object and
25952 System.ValueType types.
25954 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25956 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
25957 struct instead of Ldarg/Starg.
25959 2002-07-02 Martin Baulig <martin@gnome.org>
25961 * expression.cs (Indirection.Indirection): Call
25962 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
25964 2002-07-02 Martin Baulig <martin@gnome.org>
25966 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
25967 ValueType, call TypeManager.TypeToCoreType() on it.
25968 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
25969 the OpCodes.Newarr argument.
25971 2002-07-02 Martin Baulig <martin@gnome.org>
25973 * expression.cs (Invocation.EmitCall): When compiling corlib,
25974 replace all calls to the system's System.Array type to calls to
25975 the newly created one.
25977 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
25978 System.Array methods.
25979 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
25980 from the system's System.Array type which must be replaced.
25982 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
25984 * typemanager.cs: load unverifiable_code_ctor so we can build
25985 corlib using the correct type. Avoid using GetTypeCode() with
25987 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
25988 TypeManager.object_type to allow building corlib.
25990 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
25992 * ecore.cs: handle System.Enum separately in LoadFromPtr().
25994 2002-07-01 Martin Baulig <martin@gnome.org>
25996 * class.cs: Make the last change actually work, we need to check
25997 whether `ifaces != null' to avoid a crash.
25999 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26001 * class.cs: when we build structs without fields that implement
26002 interfaces, we need to add the interfaces separately, since there is
26003 no API to both set the size and add the interfaces at type creation
26006 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26008 * expression.cs: the dimension arguments to the array constructors
26009 need to be converted if they are a long.
26011 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26013 * class.cs: don't emit ldarg.0 if there is no parent constructor
26014 (fixes showstopper for corlib).
26016 2002-06-29 Martin Baulig <martin@gnome.org>
26018 MCS now compiles corlib on GNU/Linux :-)
26020 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26021 ie. check for MethodImplOptions.InternalCall.
26023 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26024 and TypeManager.attribute_type are null, so we must explicitly check
26025 whether parent is not null to find out whether it's an attribute type.
26026 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26027 and SetBuilder, not only if the property is neither abstract nor external.
26028 This is necessary to set the MethodImplOptions on the accessor methods.
26029 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26030 SetBuilder, see Property.Emit().
26032 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26033 populate "System.Object", "System.ValueType" and "System.Attribute" since
26034 they've already been populated from BootCorlib_PopulateCoreTypes().
26036 2002-06-29 Martin Baulig <martin@gnome.org>
26038 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26039 is the NullLiteral, we also need to make sure that target_type is not
26042 2002-06-29 Martin Baulig <martin@gnome.org>
26044 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26045 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26046 before calling BootstrapCorlib_ResolveDelegate ().
26048 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26050 * statement.cs: fixed build-breaker. All tests passed ok.
26052 2002-06-27 Martin Baulig <martin@gnome.org>
26054 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26055 for System.Decimal when compiling corlib.
26057 2002-06-27 Martin Baulig <martin@gnome.org>
26059 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26060 switch blocks which contain nothing but a default clause.
26062 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26064 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26066 2002-06-27 Martin Baulig <martin@gnome.org>
26068 * ecore.cs (PropertyExpr.PropertyExpr): Call
26069 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26071 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26072 is already a TypeBuilder.
26074 2002-06-27 Martin Baulig <martin@gnome.org>
26076 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26077 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26078 the "from an array-type to System.Array" case. This makes it work
26079 when compiling corlib.
26081 2002-06-27 Martin Baulig <martin@gnome.org>
26083 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26084 non-static PropertyExpr, set its InstanceExpression. This makes
26085 the `ICollection.Count' property work in System/Array.cs.
26087 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26089 * driver.cs: Made error handling more consistent. Errors now
26090 tracked by Report class, so many methods which used to return int
26091 now return void. Main() now prints success/failure and
26092 errors/warnings message.
26094 Renamed '--probe' compiler argument to '--expect-error'. Removed
26095 the magic number return values (123 and 124). Now, if the
26096 expected error occurs, the compiler exits with success (exit value
26097 0). If the compilation completes without seeing that particular
26098 error, the compiler exits with failure (exit value 1). The
26099 makefile in mcs/errors has been changed to handle the new behaviour.
26101 * report.cs: Made 'expected error' number a property and renamed
26102 it from 'Probe' to 'ExpectedError'.
26104 * genericparser.cs: Removed error handling support, since it is
26105 now all done by Report class.
26107 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26108 class, so parse() no longer returns an int.
26110 * namespace.cs: Use Report.Error instead of GenericParser.error
26112 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26114 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26115 TypeContainer.AddOperator): At the front of the list put the
26116 explicit implementations, so they get resolved/defined first.
26118 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26120 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26121 interface type is implemented by this TypeContainer. Used during
26122 explicit interface implementation.
26124 (Property.Define, Indexer.Define, Method.Define): Validate that
26125 the given interface in the explicit implementation is one of the
26126 base classes for the containing type.
26128 Also if we are explicitly implementing an interface, but there is
26129 no match in the pending implementation table, report an error.
26131 (Property.Define): Only define the property if we are
26132 not explicitly implementing a property from an interface. Use the
26133 correct name also for those properties (the same CSC uses,
26134 although that is really not needed).
26136 (Property.Emit): Do not emit attributes for explicitly implemented
26137 properties, as there is no TypeBuilder.
26139 (Indexer.Emit): ditto.
26141 Hiding then means that we do not really *implement* a pending
26142 implementation, which makes code fail.
26144 2002-06-22 Martin Baulig <martin@gnome.org>
26146 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26147 the return value of Object.GetType(). [FIXME: we need to do this whenever
26148 we get a type back from the reflection library].
26150 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26152 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26154 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26156 * attribute.cs: Return null if we can not look up the type.
26158 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26159 the interface types found.
26161 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26162 interface types found.
26164 * typemanager.cs (GetInterfaces): Make this routine returns alll
26165 the interfaces and work around the lame differences between
26166 System.Type and System.Reflection.Emit.TypeBuilder in the results
26167 result for GetInterfaces.
26169 (ExpandInterfaces): Given an array of interface types, expand and
26170 eliminate repeated ocurrences of an interface. This expands in
26171 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26174 2002-06-21 Martin Baulig <martin@gnome.org>
26176 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26179 2002-06-21 Martin Baulig <martin@gnome.org>
26181 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26182 and called with one of the core types, return the corresponding typebuilder for
26185 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26188 2002-06-21 Martin Baulig <martin@gnome.org>
26190 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26191 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26192 (Expression.ConvertReferenceExplicit): Likewise.
26194 * expression.cs (ElementAccess.DoResolve): Likewise.
26195 (ElementAccess.DoResolveLValue): Likewise.
26197 2002-06-10 Martin Baulig <martin@gnome.org>
26199 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26200 add the "value" parameter to the parameter list.
26202 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26205 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26207 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26208 the argument to an int, uint, long or ulong, per the spec. Also
26209 catch negative constants in array creation.
26211 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26213 * class.cs: do not allow the same interface to appear twice in
26214 the definition list.
26216 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26218 * ecore.cs: don't use ldlen with System.Array.
26220 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26222 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26224 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26226 * modifiers.cs: produce correct field attributes for protected
26227 internal. Easy fix so miguel can work on ther harder stuff:-)
26229 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26231 * pending.cs: New file. Move the code from class.cs here.
26232 Support clearning the pending flag for all methods (when not doing
26233 explicit interface implementation).
26235 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26237 * rootcontext.cs: added a couple more types needed to bootstrap.
26239 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26241 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26242 constructor in the type, instead of any constructor in the type
26243 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26244 a bug in the Mono runtime when applying the params attribute).
26246 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26247 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26249 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26251 * expression.cs (Unary.ResolveOperator): Use TypeManager
26252 to resolve the type.
26254 2002-06-13 Ravi Pratap <ravi@ximian.com>
26256 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26259 * enum.cs (AddEnumMember): Add support to store the attributes associated
26260 with each member too.
26262 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26263 field builders too - this takes care of the enum member case.
26265 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26267 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26268 address-of operator on both value types and pointers.
26270 2002-06-10 Martin Baulig <martin@gnome.org>
26272 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26273 PropertyBuilder to the `property_builders' list.
26275 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26276 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26277 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26278 find any indexers which are inherited from an interface.
26280 2002-06-09 Martin Baulig <martin@gnome.org>
26282 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26283 the same type as the constant if necessary. There's also a test-130.cs
26286 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26288 * typemanager.cs (TypeManager.ChangeType): Previously known as
26289 Enum.ChangeEnumType().
26291 2002-06-09 Martin Baulig <martin@gnome.org>
26293 * expression.cs (Cast.TryReduce): Added support for consts.
26295 2002-06-08 Ravi Pratap <ravi@ximian.com>
26297 * class.cs (Accessor): Hold attributes information so we can pass
26300 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26301 Modify to pass in attributes attached to the methods.
26303 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26305 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26306 to handle the Accessor kind :-)
26308 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26310 2002-06-08 Martin Baulig <martin@gnome.org>
26312 * expression.cs (Unary.TryReduceNegative): Added support for
26315 2002-06-08 Martin Baulig <martin@gnome.org>
26317 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26318 name can't be found in the `defined_names' - the caller will do a
26319 MemberLookup in this case and thus find methods in System.Enum
26320 such as Enum.IsDefined().
26322 2002-06-08 Martin Baulig <martin@gnome.org>
26324 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26325 Convert.ChangeType() which works with TypeBuilder created types.
26326 (Enum.LookupEnumValue, Enum.Define): Use it here.
26328 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26329 `TypeBuilder.BaseType != null' check.
26330 (TypeContainer.FindMembers): Only lookup parent members if we
26331 actually have a parent.
26332 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26333 (ConstructorInitializer.Resolve): Likewise.
26335 * interface.cs (Interface.FindMembers): Added
26336 `TypeBuilder.BaseType != null' check.
26338 * rootcontext.cs (RootContext.ResolveCore): Added
26339 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26340 classes_second_stage.
26342 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26343 debug_type and trace_type when compiling with --nostdlib.
26345 2002-06-07 Martin Baulig <martin@gnome.org>
26347 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26348 (AddField): Set it to true when adding a non-static field.
26349 (DefineType): Use `have_nonstatic_fields' to find out whether we
26350 have non-static fields, not `Fields != null'.
26352 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26354 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26355 dereferencing a null on the static-field code path)
26357 2002-05-30 Martin Baulig <martin@gnome.org>
26359 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26360 to take command line arguments. Use reflection to call the new
26361 custom `Initialize' function on the symbol writer and pass it the
26362 command line arguments.
26364 * driver.cs (--debug-args): New command line argument to pass command
26365 line arguments to the symbol writer.
26367 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26369 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26370 the target type for indexers and properties. Thanks to Joe for
26373 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26375 * typemanager.cs (MethodFlags): returns the method flags
26376 (Obsolete/ShouldIgnore) that control warning emission and whether
26377 the invocation should be made, or ignored.
26379 * expression.cs (Invocation.Emit): Remove previous hack, we should
26380 not do this on matching a base type, we should do this based on an attribute
26382 Only emit calls to System.Diagnostics.Debug and
26383 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26384 on the command line.
26386 * rootcontext.cs: Global settings for tracing and debugging.
26388 * cs-tokenizer.cs (define): New utility function to track
26389 defines. Set the global settings for TRACE and DEBUG if found.
26391 2002-05-25 Ravi Pratap <ravi@ximian.com>
26393 * interface.cs (Populate*): Pass in the TypeContainer as well as
26394 the DeclSpace as parameters so that we can create EmitContexts and
26395 then use that to apply attributes etc.
26397 (PopulateMethod, PopulateEvent, PopulateProperty)
26398 (PopulateIndexer): Apply attributes everywhere.
26400 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26403 (ApplyAttributes): Update accordingly.
26405 We now apply interface attributes for all members too.
26407 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26409 * class.cs (Indexer.Define); Correctly check if we are explicit
26410 implementation (instead of checking the Name for a ".", we
26411 directly look up if the InterfaceType was specified).
26413 Delay the creation of the PropertyBuilder.
26415 Only create the PropertyBuilder if we are not an explicit
26416 interface implementation. This means that explicit interface
26417 implementation members do not participate in regular function
26418 lookups, and hence fixes another major ambiguity problem in
26419 overload resolution (that was the visible effect).
26421 (DefineMethod): Return whether we are doing an interface
26424 * typemanager.cs: Temporary hack until we get attributes in
26425 interfaces (Ravi is working on that) and we get IndexerName
26426 support in interfaces.
26428 * interface.cs: Register the indexers as properties.
26430 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26431 warning, I have verified that this is a bug in the .NET runtime
26432 (JavaScript suffers of the same problem).
26434 * typemanager.cs (MemberLookup): When looking up members for
26435 interfaces, the parent of an interface is the implicit
26436 System.Object (so we succeed in searches of Object methods in an
26437 interface method invocation. Example: IEnumerable x; x.ToString
26440 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26442 * class.cs (Event): Events should also register if they do
26443 implement the methods that an interface requires.
26445 * typemanager.cs (MemberLookup); use the new GetInterfaces
26448 (GetInterfaces): The code used to lookup interfaces for a type is
26449 used in more than one place, factor it here.
26451 * driver.cs: Track the errors at the bottom of the file, we kept
26454 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26455 instance if the method we are calling is static!
26457 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26459 * attribute.cs (ApplyAttributes): Make this function filter out
26460 the IndexerName attribute (as that attribute in reality is never
26461 applied) and return the string constant for the IndexerName
26464 * class.cs (TypeContainer.Emit): Validate that all the indexers
26465 have the same IndexerName attribute, and if so, set the
26466 DefaultName attribute on the class.
26468 * typemanager.cs: The return value might contain other stuff (not
26469 only methods). For instance, consider a method with an "Item"
26470 property and an Item method.
26472 * class.cs: If there is a problem with the parameter types,
26475 2002-05-24 Ravi Pratap <ravi@ximian.com>
26477 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26478 looks at user defined conversion after making a call to
26479 StandardConversionExists - we need this for overload resolution.
26481 * expression.cs : Update accordingly the various method calls.
26483 This fixes 2 bugs filed against implicit user defined conversions
26485 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26487 * statement.cs: Track the result of the assignment.
26489 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26491 * expression.cs (MemberAccess): Improved error reporting for
26492 inaccessible members.
26494 2002-05-22 Martin Baulig <martin@gnome.org>
26496 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26497 itself with debugging support.
26499 2002-05-22 Martin Baulig <martin@gnome.org>
26501 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26502 Removed, this isn't needed anymore.
26504 2002-05-20 Martin Baulig <martin@gnome.org>
26506 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26507 be underlying type for an enum.
26509 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26511 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26512 that splits out the loading of just the core types.
26514 * rootcontext.cs (ResolveCore): Split the struct resolution in
26515 two, so we can load the enumeration underlying types before any
26518 * expression.cs (Is): Bandaid until we fix properly Switch (see
26519 bug #24985 for details).
26521 * typemanager.cs (ImplementsInterface): The hashtable will contain
26522 a null if there are no interfaces implemented.
26524 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26526 * cs-parser.jay (indexer_declarator): It is fine to have array
26529 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26531 * typemanager.cs: (RegisterBuilder): New function used to register
26532 TypeBuilders that implement interfaces. Since
26533 TypeBuilder.GetInterfaces (as usual) does not work with lame
26535 (AddUserType): register interfaces.
26537 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26538 dealing with TypeBuilder. Also, arrays are showing up as
26539 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26540 methods can not be invoked on them!
26542 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26543 (ImplicitReferenceConversionExists): Split out from
26544 StandardConversionExists.
26546 * expression.cs (As): We were only implementing one of the three
26547 cases for the as operator. We now implement them all.
26548 (Is): Implement the various other cases for Is as well.
26550 * typemanager.cs (CACHE): New define used to control if we want or
26551 not the FindMembers cache. Seems to have a negative impact on
26552 performance currently
26554 (MemberLookup): Nested types have full acess to
26555 enclosing type members
26557 Remove code that coped with instance/static returns for events, we
26558 now catch this in RealFindMembers.
26560 (RealFindMembers): only perform static lookup if the instance
26561 lookup did not return a type or an event.
26563 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26565 * assign.cs (CompoundAssign): We pass more semantic information
26566 now to Compound Assignments than we did before: now we have all
26567 the information at hand, and now we resolve the target *before* we
26568 do the expression expansion, which allows the "CacheValue" method
26569 to have the effect we intended (before, a [x] += 1 would generate
26570 two differen ArrayAccess expressions from the ElementAccess,
26571 during the resolution process).
26573 (CompoundAssign.DoResolve): Resolve target and original_source here.
26575 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26577 * expression.cs (ArrayAccess): dropped debugging information.
26579 * typemanager.cs: Small bug fix: I was always returning i_members,
26580 instead of one of i_members or s_members (depending on which had
26583 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26584 method is invoked before any code generation takes place, and it
26585 is a mechanism to inform that the expression will be invoked more
26586 than once, and that the method should use temporary values to
26587 avoid having side effects
26589 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26591 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26594 * expression.cs (Indirection, ArrayAccess): Add support for
26595 CacheTemporaries in these two bad boys.
26597 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26598 ldobj or ldind_ref.
26599 (StoreFromPtr): Handle stobj as well.
26601 * expression.cs (UnaryMutator): Share more code.
26603 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26604 down: I was not tracking the Filter function as well, which
26605 was affecting the results of the cache.
26607 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26609 * attribute.cs: Remove the hack to handle the CharSet property on
26612 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26614 * attribute.cs (DoResolve): More uglyness, we now only try to
26615 resolve the attribute partially, to extract the CharSet
26616 information (only if we are a StructLayout attribute). Otherwise
26618 (GetExtraTypeInfo): Add some code to conditionally kill in the
26619 future this. I am more and more convinced that the .NET
26620 framework has special code to handle the attribute setting on
26623 * expression.cs (IsParamsMethodApplicable): Revert my previous
26624 foreach change here, it was wrong.
26626 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26628 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26629 (pp_expr): do not abort on unknown input, just return.
26630 (eval): abort if there are pending chars.
26632 * attribute.cs (Attribute.Resolve): Positional parameters are
26633 optional. Deal with that case.
26635 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26636 the Ansi/Unicode/Auto information for the type.
26638 (TypeContainer.DefineType): instantiate the EmitContext here, as
26639 we will be using it during the type definition (to resolve
26640 attributes) and during the emit phase.
26642 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26643 to pull type information out of the attributes
26645 (Attribute.Resolve): track the constructor builder, and allow for
26646 multiple invocations (structs and classes will use this).
26648 * ecore.cs (MemberLookupFinal): new version with all the
26649 parameters customizable.
26651 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26652 constructors. Return if the result value is null (as the error
26653 would have been flagged already by MemberLookupFinal)
26655 Do not allow instances of abstract classes or interfaces to be
26658 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26659 We have to compare the assembly property here when dealing with
26660 FamANDAssem and Assembly access modifiers, because we might be
26661 creating an assembly from *modules* (that means that we are not
26662 getting TypeBuilders for types defined in other modules that are
26663 part of this assembly).
26665 (Method.Emit): If the method is marked abstract and has a body,
26668 (TypeContainer.DefineMembers): If both the defined member and the
26669 parent name match are methods, then do not emit any warnings: let
26670 the Method.Define routine take care of flagging warnings. But if
26671 there is a mismatch (method overrides something else, or method is
26672 overriwritten by something, then emit warning).
26674 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26675 set to null, this means `do not check for the return type on the
26678 (Method.Define): set the return type for the method signature to
26679 null, so that we get methods with the same name and parameters and
26680 different return types. This is used to flag warning 114 (you are
26681 hiding a method, and you probably want to use the new/override
26684 * typemanager.cs (MemberLookup): Implemented proper access
26685 control, closing a long standing set of bug reports. The problem
26686 was that the Framework only has two bits: Public and NonPublic,
26687 and NonPublic includes private and protected methods, but we need
26688 to enforce the FamANDAssem, FamOrAssem and Family.
26690 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26692 * statement.cs (GotoCase): Return true: Ammounts to giving up
26693 knowledge on whether we return or not, and letting the other case
26694 be responsible for it.
26696 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26698 * driver.cs: Do not load directories for each file processed, only
26699 do it if there is a pattern.
26701 * ecore.cs: Report readonly assigns here as well, as we might have
26702 been resolved only by MemberAccess.
26704 (SimpleName.SimpleNameResolve): Also be useful for LValue
26705 resolution. We need this to propagate assign to local readonly variables
26707 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26708 do not want to reuse potential criteria memory.
26710 * class.cs (MyEventBuilder): Set reflected_type;
26712 * ecore.cs (Constantify): Added support for constifying bools.
26714 (RootContext.LookupType): Added a cache for values looked up in
26715 the declaration space.
26717 * typemanager.cs (FindMembers): Now is a front-end to
26718 RealFindMembers, and provides a two-level hashtable-based cache to
26721 15% performance improvement: from 22.5 to 19.2 seconds.
26723 * expression.cs (IsParamsMethodApplicable): use foreach.
26724 (Invocation.DoResolve): ditto.
26725 (New.DoResolve): ditto.
26726 (ArrayCreation.DoResolve): ditto.
26728 * ecore.cs (FindMostEncompassingType): use foreach.
26730 * delegate.cs (NewDelegate.DoResolve): Use foreach
26732 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26733 (RemoveMethods): use foreach.
26735 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26736 nested foreach statements instead of for, and also break out of
26737 the inner loop once a match is found.
26739 (Invocation.OverloadResolve): Use foreach, simplify the code.
26741 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26743 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26744 we actually unwrap the expression to allow for extra information
26747 * expression.cs: Use Shr_Un on unsigned operations.
26749 2002-05-08 Ravi Pratap <ravi@ximian.com>
26751 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26752 applicable operators was not being considered correctly. This closes
26753 the bug Miguel reported.
26755 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26757 * attribute.cs: check that the type derives from System.Attribute
26758 and report the correct error in that case (moved the duplicate code to
26759 its own method, too).
26761 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26763 * attribute.cs: lookup attribute type name as the spec says: first the
26764 bare attribute name and then name + "Attribute" (nant compiles with
26765 mcs after this fix).
26767 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26769 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26770 Because of the way we parse things, we should try to see if a
26771 UIntConstant can fit in an integer.
26773 2002-05-07 Ravi Pratap <ravi@ximian.com>
26775 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26776 when we are in an explicit context.
26778 (ConvertReferenceExplicit): When converting from Iface type S to Class
26779 T make sure the rules are implemented as an OR.
26781 * parameter.cs (ParameterType): Make it a property for now although the
26782 purpose really isn't anything immediate.
26784 * expression.cs (Is*Applicable): Do better checking on the parameter type
26785 of a ref/out parameter. The ones from the system assemblies are already
26786 marked with the correct type so we don't need to do any correction.
26788 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26789 the object type is standard too so include that.
26791 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26793 * ecore.cs (StandardConversionExists): Augment with missing code:
26794 deal with IntConstant, LongConstants and Enumerations.
26796 * assign.cs: Report the error, instead of failing silently
26798 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26799 typecontainer that they are declared, because the
26800 typecontainer/namespace will have the list of using clauses that
26801 need to be applied.
26803 Assembly Attributes were escaping the normal registration
26806 (EmitCode): Apply attributes within an EmitContext that represents
26807 the container they were declared on.
26809 * cs-parser.jay: Track bases for structs. How did I get this wrong?
26811 2002-05-06 Ravi Pratap <ravi@ximian.com>
26813 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
26814 Revamp completely - make much cleaner as we now operate only
26817 (FindMostSpecificSource, FindMostSpecificTarget): New methods
26818 to implement the logic detailed in the spec more correctly.
26820 (UserDefinedConversion): Update accordingly.
26822 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26824 * statement.cs: Return flow analysis information up.
26826 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
26829 (token): Do not consume an extra character before calling
26832 2002-05-06 Piers Haken <piersh@friskit.com>
26834 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
26836 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26838 * class.cs (Constructor.Emit): Set the IsStatic flag in the
26839 EmitContext during the instance constructor initializer
26840 resolution, to stop access to instance variables.
26842 This is mandated by the spec, last paragraph of the `constructor
26843 initializers' section.
26845 2002-05-05 Miguel de Icaza <miguel@ximian.com>
26847 * cs-parser.jay, class.cs (Accessor): new class used to represent
26848 an accessor (get or set). In the past we used `null' to represent
26849 a missing accessor. But this is ambiguous because there was no
26850 way to tell in abstract indexers/properties if one of them was
26853 Now there is a way of addressing that.
26855 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
26856 instead of FindMembers.
26858 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
26859 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
26861 * attribute.cs: Treat indexers and properties as the same in terms
26862 of applying attributes
26864 * ecore.cs (FindMostEncompassedType): Use statically initialized
26865 EmptyExpressions()s like we do elsewhere to avoid creating useless
26866 objects (and we take this out of the tight loop).
26868 (GetConversionOperators): Move the code to extract the actual
26869 operators to a separate routine to clean things up.
26871 2002-05-04 Miguel de Icaza <miguel@ximian.com>
26873 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
26874 events are always registered FieldBuilders.
26876 * class.cs (FieldBase): New class shared by Fields
26878 * delegate.cs: If we are a toplevel delegate, use our full name.
26879 If we are a nested delegate, then only use our tail name.
26881 2002-05-02 Ravi Pratap <ravi@ximian.com>
26883 * expression.cs (IsApplicable): Ensure that we add the "&" to
26884 ref/out types before comparing it with the type of the argument.
26886 (IsParamsMethodApplicable): Ditto.
26888 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
26891 * delegate.cs : Handle the case when we have more than one applicable
26892 method. Flag an error only when we finish checking all.
26894 2002-05-02 Miguel de Icaza <miguel@ximian.com>
26896 * expression.cs: Add support for boolean static initializers.
26898 2002-05-01 Miguel de Icaza <miguel@ximian.com>
26900 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
26902 * parameter.cs (ComputeParameterTypes,
26903 ComputeAndDefineParameterTypes): Better error handling: now we
26904 clear the `types' cache if we fail during any of the type lookups.
26905 We also return the status code correctly to our caller
26907 * delegate.cs: If we fail to define a delegate, abort the extra
26910 * expression.cs (Binary.ResolveOperator): for
26911 operator==(object,object) and operator !=(object, object) we also
26912 have to verify that there is an implicit conversion from one to
26915 (ArrayAccess.DoResolve): Array Access can operate on
26918 2002-04-30 Miguel de Icaza <miguel@ximian.com>
26920 * assign.cs (CompoundAssign): A new class used as a "flag" that
26921 the assignment actually is happening as part of a compound
26922 assignment operator.
26924 During compound assignment, a few new rules exist to enable things
26931 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
26932 to the type of x) if y is implicitly convertible to the type of x,
26933 and the operator is a builtin operator and the return type of the
26934 operator is explicitly convertible to the type of x.
26936 * rootcontext.cs: Reset warning level to 2. 4 catches various
26937 "interesting" features in mcs, we must clean this up at some
26938 point, but currently am trying to kill other bugs ;-)
26940 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
26941 in container classes as well.
26943 * expression.cs (Binary.ResolveOperator): Handle string case
26944 before anything else (as operator overloading does emit an error
26945 before doing anything else).
26947 This code could go away when we move to a table driven model, but
26948 i could not come up with a good plan last night.
26950 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
26952 * typemanager.cs (CSharpName): reimplementation using regex.
26953 * class.cs: added null check for fields in Emit
26954 * rootcontext.cs: set warninglevel to 4
26956 2002-04-29 Miguel de Icaza <miguel@ximian.com>
26958 * typemanager.cs (CSharpName): reimplemented with Lupus
26961 2002-04-28 Miguel de Icaza <miguel@ximian.com>
26963 * statement.cs (If): correclty implement Resolve, because we were
26964 not catching sem errors in there. The same process is needed
26966 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
26969 (Statement.Warning_DeadCodeFound): Factorize code.
26970 (While): Report dead code here too.
26972 (Statement): Added Resolve virtual method to allow
26973 for resolution split from the emit code.
26975 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26977 * statement.cs (EmitBoolExpression): No longer try to resolve the
26979 (MakeBoolean): New utility function that resolve, implicitly
26980 converts to boolean and tags the expression.
26983 (If, Do): Implement dead code elimination.
26984 (While): Implement loop inversion
26986 (Do, While, For, If): Resolve the expression prior to calling our
26989 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
26992 - added method Report28 (warning: program has more than one entry point)
26993 - added method IsEntryPoint, implements paragraph 10.1 of the spec
26994 - modified method Method.Define, the part at the end of the method
26996 * rootcontext.cs: added static public Location EntryPointLocation;
26998 * ../errors/cs0028.cs : Add test case for the above warning.
27001 - modified method CSharpName to allow arrays of primitive type to
27002 be printed nicely (e.g. instead of System.Int32[][] it now prints
27004 - added method CSharpSignature: returns the signature of a method
27005 in string format to be used in reporting errors, warnings, etc.
27007 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27010 2002-04-26 Ravi Pratap <ravi@ximian.com>
27012 * delegate.cs (Define): Fix extremely silly bug where I was
27013 setting the type of the 'object' parameter of the BeginInvoke
27014 method to System.IAsyncResult instead of System.Object ;-)
27016 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27018 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27021 (Constructor.Emit): return if we fail to initialize the
27022 constructor. Another door closed!
27024 * expression.cs (New.DoResolve): Improve error message (from -6 to
27025 1501). Use DeclaredOnly lookup to find the exact constructor.
27027 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27028 loop. This is useful.
27030 * cs-parser.jay: Adjust the default parameters so that destructors
27031 have the proper signature.
27033 2002-04-26 Martin Baulig <martin@gnome.org>
27035 * driver.cs (LoadAssembly): If `assembly' contains any characters
27036 which are only valid in path names and not in assembly names
27037 (currently slash, backslash and point), use Assembly.LoadFrom ()
27038 instead of Assembly.Load () on the `assembly' (before iteration
27039 over the link_paths).
27041 2002-04-26 Martin Baulig <martin@gnome.org>
27043 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27045 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27047 * class.cs (Property): use the new typemanager.MemberLookup
27049 (TypeContainer.MemberLookup): Implement using the
27050 TypeManager.MemberLookup now.
27052 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27053 and return MemberInfos, so that these can be used without an
27054 EmitContext (what we had before).
27056 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27058 * expression.cs: Fix the case where the argument to params if the
27059 type of the params. I omitted handling this before. Fixed
27061 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27063 * driver.cs: Call BootCorlib_PopulateCoreType
27065 * class.cs (Property.CheckBase): Check for properties only, not
27068 * interface.cs: Temporary hack: try/catch around the
27069 CustomAttributeBuilder, because I am getting an exception that I
27072 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27073 types whose definitions are required to be there (attributes are
27074 defined before standard types).
27076 Compute definitions as we boot the various types, as they are used
27077 immediately (value_type class will need object_type, but if we do
27078 not initialize object_type, we will pass a null, which will let
27079 the runtime pick the System.Object from the existing corlib, which
27080 is not what we want).
27082 2002-04-22 Patrik Torstensson <totte@labs2.com>
27084 * cs-tokenizer.cs: fixed a number of trim() issues.
27086 2002-04-22 Ravi Pratap <ravi@ximian.com>
27088 * expression.cs (Argument.Type): Ensure that we return the correct
27089 type when we have out or ref parameters [in which case we
27092 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27094 * class.cs (Property, Indexer): Allow extern modifier in there.
27096 * typemanager.cs (InitBaseTypes): Initializes object_type and
27097 value_type, since those will be used early on during the bootstrap
27098 process to compile corlib.
27100 (InitCoreTypes): Move code from here to InitBaseTypes.
27102 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27104 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27105 single-dimension arrays as using the ldlen opcode.
27107 Daniel Lewis discovered this optimization.
27109 * typemanager.cs: Add signature for System.Array::get_Length
27111 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27113 * statement.cs: report the error when the foreach does not apply to an
27114 array nor a collection.
27116 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27118 * expression.cs: Add implicit conversions to the operator ~.
27120 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27122 * typemanager.cs: Locate the decimal constructor.
27124 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27126 * attribute.cs: use the new property of TypeOf.
27127 * expression.cs: added 'get' property around typearg.
27129 These changes fix a build breaker reported by NickD. Is this the
27130 correct way to fix? If not, please, revert my changes and make it
27133 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27135 * attribute.cs: Add support for typeof in attribute invocations.
27136 I am not sure that this is right though.
27138 2002-04-14 Duncan Mak <duncan@ximian.com>
27140 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27141 Binary.Operator.Division case.
27143 2002-04-13 Ravi Pratap <ravi@ximian.com>
27145 * class.cs (DefineType): Ensure that we do a proper check on
27146 attribute types and also register it with the TypeManager.
27148 (TypeContainer.Targets): The default for attribute types is
27149 AttributeTargets.All.
27151 * attribute.cs (ApplyAttributes): Registering the attribute type
27152 is done elsewhere, not when we discover we have a Usage attribute.
27154 2002-04-12 Ravi Pratap <ravi@ximian.com>
27156 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27157 and get rid of is_delegate parameter.
27159 * everywhere : update.
27161 2002-04-12 Ravi Pratap <ravi@ximian.com>
27163 * cs-parser.jay (compilation_unit): Revamp completely to use
27164 some new ideas that I got from Rhys' grammar to solve the problems
27165 with assembly level attributes.
27167 (outer_declaration): New grammar production.
27169 (attribute_sections): Add.
27171 (opt_attributes): Base on attribute_sections
27173 (namespace_declaration): Allow opt_attributes to tackle the case
27174 when we have assembly level attributes - we are clever in this
27177 * attribute.cs (ApplyAttributes): Do not worry about assembly
27178 attributes in the non-global context.
27180 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27181 instead of SetGlobalAttributes.
27183 * class.cs, rootcontext.cs : Ensure we define and generate
27184 attribute types before anything else.
27186 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27187 and flag the new error -20 for the case when the attribute type
27188 does not have valid targets specified. csc does not catch this.
27190 * ../errors/errors.txt : update for error # -20
27192 2002-04-11 Ravi Pratap <ravi@ximian.com>
27194 * support.cs (InternalParameters.ParameterModifier): Do some null
27195 checking and return sane values.
27197 * class.cs (Method.Define): If we are a PInvoke method, ensure
27198 that we are static and extern. Report error # 601
27200 * ../errors/cs0601.cs : Add test case for the above error.
27202 2002-04-07 Ravi Pratap <ravi@ximian.com>
27204 * rootcontext.cs (attribute_types): We need to keep type of
27205 all attribute types separately and emit code for them first.
27207 (RegisterAttribute) : Implement.
27209 * class.cs (DefineType): Check if the current Type is a custom
27210 attribute type and register it accordingly.
27212 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27213 adding the first attribute twice and rename to
27215 (SetGlobalAttributes): this.
27217 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27220 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27221 if we are processing global arguments. Hmm, I am unsure of this.
27223 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27225 * expression.cs: added static array of strings to avoid calling
27226 Enum.ToString () for Operator in Binary. Significant recover of
27229 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27231 * class.cs (FindMembers): Allow the Builders of the various
27232 members to be null. If they are skip them. This only happens
27233 during the PInvoke declaration.
27235 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27237 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27238 failure, so we do not keep going afterwards.
27240 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27241 wanted to pass `false' as the `is_delegate' argument. If this is
27242 the case, why not use delegate_type == null to mean `is_delegate =
27243 false' and anything else as is_delegate = true.
27245 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27247 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27248 code for the section, not the beginning of the tests.
27250 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27252 * cfold.cs: Handle operator + (Enum x, Underlying x)
27254 * expression.cs (Binary): same. Warn about errors where we have
27255 Enum/Enum in operator + as well.
27257 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27260 - added support for switch(bool)
27261 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27262 - add TableSwitchEmit() to handle table-based switch statements
27264 2002-04-05 Ravi Pratap <ravi@ximian.com>
27266 * expression.cs (Invocation.OverloadResolve): Factor out code which
27267 does parameter compatibility checking with arguments so that we can
27268 re-use the code even from Delegate.VerifyApplicability
27270 (VerifyArgumentsCompat): Move above code here.
27272 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27273 and instead make a call to the above method.
27275 2002-03-31 Ravi Pratap <ravi@ximian.com>
27277 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27278 We use it to keep track of classes which are attribute types.
27280 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27282 * delegate.cs (Delegate.Define): Correctly define the types in the
27283 presence of fixed and array parameters.
27285 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27288 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27289 include NonPublic after the first iteration.
27291 * class.cs (Indexer.CheckBase): Only check if both parents are
27294 * cs-parser.jay (accessor_body): If empty, set to null.
27296 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27297 same code path here to resolve constants names that we did have in
27298 MemberAccess.DoResolve. There is too much code duplicated here.
27300 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27302 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27304 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27307 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27308 tokens, numbers and strings.
27310 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27313 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27314 asyncronous parameters and the regular parameters.
27316 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27317 specify the target directory.
27319 * expression.cs: (This.DoResolve): Simplify
27320 (As.Emit): Optimize, do not generate IsInst if the expression is
27321 always of the given type.
27323 (Is.DoResolve): Bug fix, we were reporting both always/never for
27326 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27327 creating too many unnecessary arrays.
27329 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27331 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27332 fields instead of rolling our own initializer. Takes care of all
27333 implicit conversions, and drops unnecessary static checks/argument.
27335 2002-03-31 Dick Porter <dick@ximian.com>
27337 * driver.cs: use the GetDirectories() return values properly, and
27338 use "/" as path separator.
27340 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27342 * expression.cs (Unary): Optimize - - expr into expr.
27343 (Binary): Optimize a + (-b) into a -b.
27345 * codegen.cs (CodeGen): Made all methods static.
27347 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27351 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27352 TypeBuilder property.
27354 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27357 * tree.cs: Removed the various RecordXXXX, and replaced with a
27358 single RecordDecl. Removed all the accessor methods, and just
27359 left a single access point Type
27361 * enum.cs: Rename DefineEnum to DefineType.
27363 * decl.cs: New abstract method `DefineType' used to unify the
27364 Defines for Enumerations, Interfaces, TypeContainers and
27367 (FindType): Moved LookupInterfaceOrClass here. Moved the
27368 LookupBaseClasses method that used to live in class.cs and
27369 interface.cs here, and renamed to FindType.
27371 * delegate.cs: Implement DefineType. Take advantage of the
27372 refactored pattern for locating the parent builder without taking
27373 the parent_builder argument (which we know does not work if we are
27374 nested, and triggering a toplevel definition).
27376 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27378 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27379 accessibility of a member has changed during override and report
27382 * class.cs (Method.Define, Property.Define): Only complain on
27383 overrides if the method is private, any other accessibility is
27384 fine (and since we just checked the permission is the same, we are
27387 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27388 and elif are processed always. The other pre-processing
27389 directives are only processed if we are "taking" the path
27391 2002-03-29 Martin Baulig <martin@gnome.org>
27393 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27394 current location is not Null.
27396 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27397 a separate method so we can profile it.
27399 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27400 `span.Seconds' are just seconds, but no minutes or hours.
27401 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27403 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27405 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27406 Remove the gratuitous set of Final:
27408 // If an interface implementation, then we can set Final.
27409 if (((flags & MethodAttributes.Abstract) == 0) &&
27410 implementing.DeclaringType.IsInterface)
27411 flags |= MethodAttributes.Final;
27413 I do not know what I was smoking when I used that.
27416 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27417 step into fixing the name resolution issues for delegates and
27418 unifying the toplevel name resolution.
27420 2002-03-28 Martin Baulig <martin@gnome.org>
27422 * class.cs (Method.Emit): If we have a symbol writer, call its
27423 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27424 tell it about the current method.
27426 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27427 writer that we're going to emit the first byte of IL code for a new
27428 statement (a new source line).
27429 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27430 EmitContext.Mark() before emitting any code.
27432 * location.cs (SymbolDocument): Return null when we're Null.
27434 * statement.cs (Statement): Moved the `Location loc' variable here.
27435 (Statement.EmitBoolExpression): If we have a symbol writer, call
27436 ec.Mark() before emitting any code to tell it that we're at the
27437 beginning of a new statement.
27438 (StatementExpression): Added `Location' argument to the constructor.
27439 (Block): Added public readonly variable `StartLocation' and public
27440 variable `EndLocation'. The latter is to be set using SetEndLocation().
27441 (Block): Added constructor which takes a start and end location.
27442 (Block.SetEndLocation): New method. This sets the end location.
27443 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27444 local variables we create.
27445 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27446 each statement and do also mark the begin and end of the block.
27448 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27449 tell it the current lexer.Location, use Location.Null for the end of the
27451 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27452 current block, set its end location using SetEndLocation().
27453 (statement_expression): StatementExpression constructor now takes the
27454 lexer.Location as additional argument.
27455 (for_statement, declare_local_variables): Likewise.
27456 (declare_local_variables): When creating a new implicit block, use the
27457 new Block constructor and pass it the lexer.Location.
27459 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27461 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27462 members also on the parent interfaces recursively.
27464 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27466 * report.cs: Use new formats, since Gonzalo finished the missing
27469 * expression.cs (Binary.ResolveOperator): added missing operator|
27470 operator& and operator^ for bool/bool.
27472 * cs-parser.jay: CheckDef now takes a Location argument that is
27473 used to report errors more precisly (instead of reporting the end
27474 of a definition, we try to track something which is a lot closer
27475 to the source of the problem).
27477 * cs-tokenizer.cs: Track global token use, so we can properly flag
27478 the use of #define/#undef after the first token has been seen.
27480 Also, rename the reportXXXX to Error_DescriptiveName
27482 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27483 TypeContainer, so that Enum and Interface can use this too.
27485 * class.cs (TypeContainer.LookupInterfaceOrClass,
27486 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27487 `builder' argument. Typically this was used to pass the parent
27488 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27491 The problem is that a nested class could trigger the definition of
27492 a toplevel class, and the builder would be obviously wrong in that
27495 So we drop this argument, and we compute dynamically the
27496 TypeBuilder/ModuleBuilder (the correct information was available
27497 to us anyways from DeclSpace.Parent)
27499 * interface.cs (Interface.DefineInterface): Drop builder
27500 parameter cleanup like class.cs
27502 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27505 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27508 (Try.Emit): Propagate the returns value from the statement.
27510 (Return.Emit): Even if we are leavning
27512 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27514 * modifiers.cs: Fix the computation of MethodAttributes flags.
27516 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27518 * driver.cs: allow compilation of files that start with '/'.
27519 Add a default case when checking the argument of --target.
27521 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27523 * interface.cs: Implement the same search algorithm for types in
27524 the interface code.
27526 * delegate.cs: Do not allow multiple definition.
27528 * Recovered ChangeLog that got accidentally amputated
27530 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27532 * rootcontext.cs: Load manually enum to allow core classes to
27533 contain enumerations.
27535 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27536 Update to new static methods in TypeManager.
27538 * typemanager.cs (GetMethod, GetConstructor): Use our
27539 implementation of FindMembers to find the members, since during
27540 corlib compilation, the types are TypeBuilders and GetMethod and
27541 GetConstructor do not work.
27543 Make all methods in TypeManager static.
27545 (InitCodeHelpers): Split the functionality from
27546 the InitCodeTypes function.
27548 * driver.cs: Call InitCodeHelpers after we have populated the
27551 * cs-parser.jay (delegate_declaration): we did not used to compute
27552 the delegate name correctly for void delegates.
27554 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27556 * rootcontext.cs (RootContext): Init the interface_resolve_order
27557 and type_container_resolve_order always.
27559 (ResolveCore, BootstrapCorlib_ResolveClass,
27560 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27561 compiler when compiling with --nostdlib
27563 * class.cs (TypeContainer.DefineType): Check that our parent is
27564 not null. This test is most important when we are bootstraping
27567 * codegen.cs: Split out the symbol writing code.
27569 2002-03-25 Martin Baulig <martin@gnome.org>
27571 * driver.cs (-g): Made -g an alias for --debug.
27573 2002-03-24 Martin Baulig <martin@gnome.org>
27575 * codegen.cs (SymbolWriter): New public variable. Returns the
27576 current symbol writer.
27577 (CodeGen): Added `bool want_debugging_support' argument to the
27578 constructor. If true, tell the ModuleBuild that we want debugging
27579 support and ask it for the ISymbolWriter.
27580 (Save): If we have a symbol writer, call it's Close() method after
27581 saving the assembly.
27583 * driver.c (--debug): New command line argument to create a
27584 debugger information file.
27586 * location.cs (SymbolDocument): New public property. Returns an
27587 ISymbolDocumentWriter object for the current source file or null
27588 if we don't have a symbol writer.
27590 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27592 * driver.cs (LoadAssembly): Correctly return when all the paths
27593 have been tried and not before.
27595 * statement.cs (Switch.Emit): return the actual coverage for this
27596 statement (returns/not-returns)
27598 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27599 switch of the statement if we are the last switch section. That
27600 kills two problems: try/catch problems (we used to emit an empty
27601 nop at the end) and switch statements where all branches would
27604 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27606 * driver.cs: Add default assemblies (the equivalent to the
27607 Microsoft CSC.RSP file)
27609 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27610 also update tokens_seen and set it to false.
27612 * driver.cs: Implement --recurse for Mike.
27614 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27615 correctly splitting out the paths.
27617 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27619 * interface.cs (Interface.PopulateProperty): Instead of using
27620 `parent' as the declaration space for the set parameters, use
27623 * support.cs (InternalParameters): InternalParameters constructor
27624 takes a DeclSpace instead of a TypeContainer.
27626 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27627 types are being initialized, load the address of it before calling
27630 (New): Provide a mechanism to disable the generation of local
27631 value type temporaries when the caller will be providing us with
27632 an address to store it.
27634 (ArrayCreation.EmitDynamicInitializers): Use it.
27636 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27638 * expression.cs (Invocation.EmitArguments): Only probe for array
27639 property if there is more than one argument. Sorry about that.
27641 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27642 empty param arrays.
27644 * class.cs (Method.LabelParameters): Fix incorrect code path that
27645 prevented the `ParamArrayAttribute' from being applied to the
27648 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27650 * support.cs (ReflectionParameters): Correctly compute whether the
27651 last argument is a params array. Fixes the problem with
27654 * typemanager.cs: Make the assemblies array always be non-null
27655 (empty, but non-null)
27657 * tree.cs (RecordDecl): New function that abstracts the recording
27658 of names. This reports error 101, and provides a pointer to the
27659 previous declaration. Fixes a crash in the compiler.
27661 * cs-parser.jay (constructor_declaration): Update to new grammar,
27662 and provide a constructor_body that can be empty.
27664 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27666 * driver.cs: Add support for --resources.
27668 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27669 Make all types for the various array helper methods be integer.
27671 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27672 CheckState to ConvCast.
27674 (ConvCast): Now it takes a `checked' state argument, to avoid
27675 depending on the emit context for the conversion, and just using
27676 the resolve time setting.
27678 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27679 instead of Invocation.EmitArguments. We do not emit the original
27680 arguments, instead we emit those which have been converted to
27681 unsigned int expressions.
27683 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27685 * codegen.cs: ditto.
27687 * expression.cs (LocalVariableReference): Drop the use of the
27688 Store function that depended on the variable index.
27690 * statement.cs (VariableInfo): Drop the `Idx' property from this
27691 class, as this is not taking into account the indexes for
27692 temporaries tat we generate during the execution, getting the
27695 * class.cs: First emit class initializers, then call the parent
27698 * expression.cs (Binary): Fix opcode emision.
27699 (UnaryMutator.EmitCode): Support checked code generation
27701 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27702 matches for events for both the Static and Instance scans,
27703 pointing to the same element. Fix that.
27705 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27707 * rootcontext.cs (ResolveTree): Always set the
27708 interface_resolve_order, because nested interfaces will be calling
27711 * class.cs (GetInterfaceOrClass): Track the same resolution
27712 process used by TypeManager.LookupType. This fixes the nested
27713 type lookups in class declarations (separate path from
27716 (TypeContainer.DefineType): Also define nested interfaces.
27717 (TypeContainer.RegisterOrder): New public function used to
27718 register the order in which child interfaces need to be closed.
27720 Nested interfaces need to be closed after their parents have been
27723 * interface.cs (InterfaceAttr): Put all the logic for computing
27724 the interface attribute here.
27726 (DefineInterface): Register our interface order with the
27727 RootContext or with the TypeContainer depending on the case.
27729 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27731 * cs-parser.jay: rework foreach statement to work with the new
27732 changes to the policy on SimpleNames.
27734 * report.cs: support Stacktrace on warnings as well.
27736 * makefile: drop --unsafe and /unsafe from the compile.
27738 2002-03-13 Ravi Pratap <ravi@ximian.com>
27740 * ecore.cs (StandardConversionExists): Modify to take an Expression
27741 as the first parameter. Ensure we do null -> reference type conversion
27744 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27745 temporary Expression objects.
27747 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27749 * interface.cs: workaround bug in method overloading resolution
27750 (there is already a bugzilla bug for it).
27752 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27754 We could also solve this problem by having a separate path for
27755 performing type lookups, instead of DoResolve, we could have a
27756 ResolveType entry point, and only participating pieces of the
27757 production (simplename, deref, array) would implement this.
27759 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27760 signal SimpleName to only resolve type names and not attempt to
27761 resolve anything else.
27763 * expression.cs (Cast): Set the flag.
27765 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27767 * class.cs: Only report 108 if there is no `new' modifier.
27769 * cs-parser.jay: rework foreach statement to work with the new
27770 changes to the policy on SimpleNames.
27772 * report.cs: support Stacktrace on warnings as well.
27774 * makefile: drop --unsafe and /unsafe from the compile.
27776 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27778 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27779 lookups here, instead of doing that at parse time. This means
27780 that our grammar will not introduce `LocalVariableReferences' as
27781 expressions at this point. That solves the problem of code like
27785 static void Main ()
27789 This is only half the fix. The full fix requires parameters to
27790 also be handled in this way.
27792 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27793 makes the use more obvious of the DeclSpace. The
27794 ec.TypeContainer.TypeBuilder is now only used to pull the
27795 TypeBuilder for it.
27797 My theory is that I can get rid of the TypeBuilder completely from
27798 the EmitContext, and have typecasts where it is used (from
27799 DeclSpace to where it matters).
27801 The only pending problem is that the code that implements Aliases
27802 is on TypeContainer, and probably should go in DeclSpace.
27804 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27805 lookups here, instead of doing that at parse time. This means
27806 that our grammar will not introduce `LocalVariableReferences' as
27807 expressions at this point. That solves the problem of code like
27811 static void Main ()
27815 This is only half the fix. The full fix requires parameters to
27816 also be handled in this way.
27818 * class.cs (Property.DefineMethod): When implementing an interface
27819 method, set newslot, when implementing an abstract method, do not
27820 set the flag (before we tried never setting it, or always setting
27821 it, which is the difference).
27822 (Indexer.DefineMethod): same.
27823 (Method.DefineMethod): same.
27825 * ecore.cs: Only set the status used flag if we get back a Field.
27827 * attribute.cs: Temporary hack, so Paolo can keep working.
27829 2002-03-08 Ravi Pratap <ravi@ximian.com>
27831 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
27832 the unmanaged type in the case we have a MarshalAs attribute.
27834 (Resolve): Handle the case when we are parsing the special MarshalAs
27835 attribute [we need to store the unmanaged type to use later]
27837 * typemanager.cs (marshal_as_attr_type): Built in type for the
27838 MarshalAs Attribute.
27840 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
27841 on parameters and accordingly set the marshalling info.
27843 2002-03-09 Miguel de Icaza <miguel@ximian.com>
27845 * class.cs: Optimizing slightly by removing redundant code after
27846 we switched to the `NoTypes' return value.
27847 (Property.DefineMethod): use NoTypes here too.
27849 This fixes the bug I introduced in my last batch of changes.
27851 2002-03-05 Ravi Pratap <ravi@ximian.com>
27853 * tree.cs (RecordEnum): Add. We now keep track of enums too.
27855 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
27856 Enums since those are types too.
27858 * cs-parser.jay (enum_declaration): Record enums as we parse them.
27860 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
27861 thanks to a call during the lookup process.
27863 2002-03-07 Miguel de Icaza <miguel@ximian.com>
27865 * statement.cs (Foreach): Lots of work to accomodate a particular
27866 kind of foreach statement that I had not kept in mind. It is
27867 possible to have foreachs on classes that provide a GetEnumerator
27868 method that return objects that implement the "pattern" for using
27869 a foreach, there is no need to support GetEnumerator
27872 This is needed to compile nant.
27874 * decl.cs: Only report 114 if the member is not `Finalize' and if
27875 the warning level is at least 2.
27877 * class.cs: Moved the compare function from Method to
27880 (MethodSignature.InheritableMemberSignatureCompare): Add new
27881 filter function that is used to extract inheritable methods from a
27884 (Method.Define): Use the new `inheritable_method_signature_filter'
27887 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
27890 2002-03-06 Miguel de Icaza <miguel@ximian.com>
27892 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
27894 * cs-parser.jay: Add opt_semicolon to the interface declaration.
27896 * expression.cs: Pass location information to
27897 ConvertImplicitStandard.
27899 * class.cs: Added debugging code to track return values from
27902 2002-03-05 Miguel de Icaza <miguel@ximian.com>
27904 * expression.cs (Is.DoResolve): If either side of the `is' is an
27905 interface, do not flag the warning.
27907 * ecore.cs (ImplicitReferenceConversion): We need a separate test
27910 * report.cs: Allow for --fatal to be used with --probe.
27912 * typemanager.cs (NoTypes): Move the definition for the empty Type
27915 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
27917 (TypeContainer.DefineProxy): New function used to proxy to parent
27918 implementations when implementing interfaces.
27919 (TypeContainer.ParentImplements): used to lookup if our parent
27920 implements a public function that is required by an interface.
27921 (TypeContainer.VerifyPendingMethods): Hook this up.
27923 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
27924 `modules' and `assemblies' arraylists into arrays. We only grow
27925 these are the very early start up of the program, so this improves
27926 the speedof LookupType (nicely measured).
27928 * expression.cs (MakeByteBlob): Replaced unsafe code with
27929 BitConverter, as suggested by Paolo.
27931 * cfold.cs (ConstantFold.Binary): Special case: perform constant
27932 folding of string concatenation, but if either side is a string,
27933 and the other is not, then return null, and let the runtime use
27934 the concatenation on the string plus the object (using
27935 `Object.ToString').
27937 2002-03-04 Miguel de Icaza <miguel@ximian.com>
27939 Constant Folding has been implemented now.
27941 * expression.cs (Unary.Reduce): Do not throw an exception, catch
27942 the error instead on types that are not supported in one's
27945 * constant.cs (Constant and all children): New set of functions to
27946 perform implict and explicit conversions.
27948 * ecore.cs (EnumConstant): Implement the new functions to perform
27949 conversion by proxying to the child expression.
27951 * codegen.cs: (ConstantCheckState): Constant evaluation has its
27952 own separate setting that can not be turned off from the command
27953 line using --unchecked or --checked and is only controlled using
27954 the checked/unchecked statements and expressions. This setting is
27955 used by the constant folder to flag errors.
27957 * expression.cs (CheckedExpr, UncheckedExpr): Set the
27958 ConstantCheckState as well.
27960 During Resolve, they also have to flag the state, because the
27961 constant folder runs completely in the Resolve phase.
27963 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
27966 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27968 * cfold.cs: New file, this file contains the constant folder.
27970 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
27971 argument to track whether we are using the resulting address to
27972 load or store a value and provide better error messages.
27974 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
27975 new AddressOf arguments.
27977 * statement.cs (Foreach.EmitCollectionForeach): Update
27979 * expression.cs (Argument.Emit): Call AddressOf with proper
27980 arguments to track usage.
27982 (New.DoEmit): Call AddressOf with new arguments.
27984 (Unary.Emit): Adjust AddressOf call.
27986 2002-03-01 Ravi Pratap <ravi@ximian.com>
27988 * cs-parser.jay (member_access): Change the case for pre-defined types
27989 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
27992 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
27995 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
27996 essentially like methods and apply attributes like MethodImplOptions to them too.
27998 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28001 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28002 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28005 * Update code everywhere accordingly.
28007 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28009 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28011 2002-02-28 Ravi Pratap <ravi@ximian.com>
28013 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28014 try performing lookups against those instead of jumping straight into using
28015 the 'using' clauses.
28017 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28019 (LookupType): Perform lookups in implicit parents too.
28021 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28022 sequence as RootContext.LookupType.
28024 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28025 the various cases of namespace lookups into this method.
28027 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28029 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28030 in positional arguments)
28032 * class.cs (Operator): Update the AllowedModifiers to contain
28035 * cs-parser.jay: Update operator declaration to allow for the
28036 operator body to be empty.
28038 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28041 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28043 * class.cs (Method.Emit): Label parameters.
28045 * driver.cs: Return 1 or 0 as the program exit code.
28047 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28049 * expression.cs: Special case the `null' object when trying to
28050 auto-compute the type, as anything can be explicitly converted to
28053 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28054 spotting this Paolo.
28056 (Expression.ImplicitNumericConversion): Perform comparissions of
28057 the type using the underlying type in the case of an enumeration
28058 rather than using the enumeration type for the compare.
28060 Cope with the underlying == type case, which is not possible to
28063 (Expression.ConvertNumericExplicit): Perform comparissions of
28064 the type using the underlying type in the case of an enumeration
28065 rather than using the enumeration type for the compare.
28067 * driver.cs: If the user does not supply an extension, assume .exe
28069 * cs-parser.jay (if_statement): Rewrote so that we can track the
28070 location for the if statement.
28072 * expression.cs (Binary.ConstantFold): Only concat strings when
28073 the operation is "+", not everything ;-)
28075 * statement.cs (Statement.EmitBoolExpression): Take a location
28077 (If, While, Do): Track location.
28079 * expression.cs (Binary.ResolveOperator): In the object + string
28080 case, I was missing a call to ConvertImplicit
28082 2002-02-25 Ravi Pratap <ravi@ximian.com>
28084 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28085 Location arguments. Ensure we use RootContext.LookupType to do our work
28086 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28088 * interface.cs (PopulateMethod): Handle the type of the parameter being
28091 * expression.cs (Invocation.BetterFunction): Handle the case when we
28092 have a params method with no fixed arguments and a call is made with no
28095 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28097 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28098 the verbatim-string-literal
28100 * support.cs (InternalParameters.ParameterModifier): handle null
28102 (InternalParameters.ParameterType): ditto.
28104 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28105 duplicating the name of the variable parameter.
28106 (GetParameterByName): Fix bug where we were not looking up array
28107 paramters if they were the only present (thanks Paolo!).
28108 (GetParameterInfo): We only have an empty set of types if both
28109 fixed and array are set to null.
28110 (GetParameterInfo-idx): Handle FixedParameter == null
28112 * cs-parser.jay: Handle the case where there is no catch
28113 statements (missing null test).
28115 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28117 * driver.cs (MainDriver): Be conservative on our command line
28120 Catch DirectoryNotFoundException when calling GetFiles.
28122 (SplitPathAndPattern): Used to split the input specification into
28123 a path and a pattern that we can feed to Directory.GetFiles.
28125 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28127 * statement.cs (Fixed): Implement the last case of the Fixed
28128 statement (string handling).
28130 * expression.cs (StringPtr): New class used to return a char * to
28131 a string; Used by the Fixed statement.
28133 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28135 * expression.cs (Binary.ResolveOperator): Remove redundant
28136 MemberLookup pn parent type.
28137 Optimize union call, we do not need a union if the types are the same.
28138 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28141 Specialize the use of MemberLookup everywhere, instead of using
28142 the default settings.
28144 (StackAlloc): Implement stackalloc keyword.
28146 * cs-parser.jay: Add rule to parse stackalloc.
28148 * driver.cs: Handle /h, /help, /?
28150 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28151 before we supported unsafe code.
28153 * makefile: add --unsafe to the self compilation of mcs.
28155 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28157 * expression.cs (PointerArithmetic): New class that is used to
28158 perform pointer arithmetic.
28159 (Binary.Resolve): Handle pointer arithmetic
28160 Handle pointer comparission.
28161 (ArrayPtr): Utility expression class that is used to take the
28162 address of an array.
28164 (ElementAccess): Implement array access for pointers
28166 * statement.cs (Fixed): Implement fixed statement for arrays, we
28167 are missing one more case before we are done.
28169 * expression.cs (Indirection): Implement EmitAssign and set the
28170 ExprClass to Variable. This allows pointer dereferences to be
28171 treated as variables, and to have values assigned to them.
28173 * ecore.cs (Expression.StoreFromPtr): New utility function to
28174 store values dereferencing.
28176 2002-02-20 Ravi Pratap <ravi@ximian.com>
28178 * expression.cs (Binary.ResolveOperator): Ensure that we are
28179 not trying to operate on a void type - this fixes the reported
28182 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28183 the parent implementation is sealed.
28185 * ../errors/cs0239.cs : Add.
28187 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28189 * typemanager.cs (unverifiable_code_type): Corresponds to
28190 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28191 which have unsafe code in them.
28193 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28196 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28198 * cs-tokenizer.cs: Add support for @"litreal strings"
28200 Make tokenizer accept pre-processor directives
28201 on any column (remove the old C-like limitation).
28203 * rootcontext.cs (EmitCode): Emit any global attributes.
28204 (AddGlobalAttributes): Used to keep track of assembly attributes.
28206 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28208 * cs-parser.jay: Add support for global attributes.
28210 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28212 * expression.cs (Indirection): New helper class. Unary will
28213 create Indirection classes to be able to implement the
28214 IMemoryLocation interface on it.
28216 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28218 * cs-parser.jay (fixed_statement): reference the right statement.
28220 * statement.cs (Fixed.Emit): Finish implementing the fixed
28221 statement for the &x case.
28223 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28225 * class.cs (Property.Define, Method.Define): Remove newslot when
28228 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28229 wrong. NewSlot should only be used if the `new' keyword is present.
28231 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28232 locating our system dir. Sorry about this.
28234 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28236 * driver.cs (GetSystemDir): Compute correctly the location of our
28237 system assemblies. I was using the compiler directory instead of
28238 the library directory.
28240 2002-02-13 Ravi Pratap <ravi@ximian.com>
28242 * expression.cs (BetterFunction): Put back in what Miguel commented out
28243 since it is the correct fix. The problem is elsewhere ;-)
28245 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28246 parameters of the parms method are themselves compatible or not !
28248 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28249 to check that a class implements an interface before saying that an implicit
28250 conversion was allowed. Use ImplementsInterface to do the checking.
28252 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28254 * class.cs (Method.Define): Track whether we are an explicit
28255 implementation or not. And only call DefineMethodOverride if we
28256 are an explicit implementation.
28258 (Property.DefineMethod): Ditto.
28260 2002-02-11 Ravi Pratap <ravi@ximian.com>
28262 * expression.cs (BetterFunction): Catch hideous bug which was
28263 preventing us from detecting ambiguous calls due to implicit casts i.e
28266 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28268 * support.cs (Pair): Remove un-needed method. I figured why I was
28269 getting the error in cs-parser.jay, the variable in a foreach loop
28270 is readonly, and the compiler does not really treat this as a variable.
28272 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28273 instead of EQUALS in grammar.
28275 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28277 * expression.cs (Unary.DoResolve): Check whether the argument is
28280 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28282 * support.cs: Api for Pair to set a value. Despite the fact that
28283 the variables are public the MS C# compiler refuses to compile
28284 code that accesses the field if the variable is part of a foreach
28287 * statement.cs (Fixed): Begin implementation of the fixed
28290 (Block.AddVariable): Return the VariableInfo on success and null
28291 on failure instead of true/false.
28293 * cs-parser.jay (foreach): Catch errors on variables already
28294 defined (we were ignoring this value before) and properly unwind
28295 the block hierarchy
28297 (fixed_statement): grammar for the fixed statement.
28299 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28301 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28302 pointer types to be incretemented.
28304 (SizeOf): Implement.
28306 * cs-parser.jay (pointer_member_access): Implement
28307 expr->IDENTIFIER production.
28309 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28310 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28313 (Unary): Implement indirection.
28315 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28316 use in non-unsafe context).
28318 (SimpleName.DoResolve): Check for pointers in field access on safe
28321 (Expression.LoadFromPtr): Factor the load-indirect code in this
28322 function. This was duplicated in UnboxCast and ParameterReference
28324 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28326 * expression.cs (ComposedCast): report an error if a pointer cast
28327 is used in a safe region.
28329 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28330 pointer type casts in unsafe context.
28332 * codegen.cs (EmitContext): Set up IsUnsafe.
28334 * cs-parser.jay (non_expression_type): Add productions for pointer
28337 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28338 code. We should not use force into static mode if the method is
28339 not virtual. Fixes bug in MIS
28341 * statement.cs (Do.Emit, While.Emit, For.Emit,
28342 Statement.EmitBoolExpression): Add support to Do and While to
28343 propagate infinite loop as `I do return' semantics.
28345 Improve the For case to also test for boolean constants.
28347 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28348 to the list of attributes we can add.
28350 Remove `EmitContext' argument.
28352 * class.cs (Method.Define): Apply parameter attributes.
28353 (Constructor.Define): Apply parameter attributes.
28354 (MethodCore.LabelParameters): Move here the core of labeling
28357 * support.cs (ReflectionParameters.ParameterModifier,
28358 InternalParameters.ParameterModifier): Use IsByRef on the type and
28359 only return the OUT bit for these parameters instead of in/out/ref
28362 This is because I miss-understood things. The ParameterInfo.IsIn
28363 and IsOut represent whether the parameter has the [In] and [Out]
28366 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28368 * ecore.cs (FieldExpr.Emit): Release temporaries.
28370 * assign.cs (LocalTemporary.Release): new function.
28372 * codegen.cs (EmitContext.GetTemporaryStorage,
28373 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28374 temporary storage. Now we can "put back" localbuilders when we
28377 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28379 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28380 need to make a copy of the variable to generate verifiable code.
28382 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28384 * driver.cs: Compute dynamically the system directory.
28386 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28387 Slower, but more generally useful. Used by the abstract
28388 registering implementation.
28390 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28391 the rules for the special rule on Type/instances. First check if
28392 we have the same name, and if so, try that special static path
28393 rather than the instance path.
28395 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28397 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28400 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28401 Enum, ValueType, Delegate or Array for non-corlib compiles.
28403 * cs-tokenizer.cs: Catch long identifiers (645)
28405 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28408 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28409 fix, we were returning too early, so we were not registering
28410 pending methods from abstract classes.
28412 Do not register pending methods if the class is abstract.
28414 * expression.cs (Conditional.DoResolve): Report circular implicit
28415 conversions when we neecd to compute it for conditional
28418 (Is.DoResolve): If the expression is always of the provided type,
28419 flag warning 183. If the expression can not ever be of the
28420 provided type flag warning 184.
28422 * class.cs: Catch 169 as well.
28424 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28427 2002-01-18 Nick Drochak <ndrochak@gol.com>
28429 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28431 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28433 * interface.cs: (PopulateMethod): Check for pointers being defined
28434 only if the unsafe context is active.
28435 (PopulateProperty): ditto.
28436 (PopulateIndexer): ditto.
28438 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28439 specified. If pointers are present, make sure that they are
28440 present in an unsafe context.
28441 (Constructor, Constructor.Define): ditto.
28442 (Field, Field.Define): ditto.
28443 (Property, Property.Define): ditto.
28444 (Event, Event.Define): ditto.
28446 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28447 hashtable if there are classes or structs defined.
28449 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28450 code, as the constant resolution moved.
28452 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28453 the metadata, so we can flag error 133.
28455 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28456 pointer is being declared in an unsafe context.
28458 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28460 * modifiers.cs (Modifiers.Check): Require a Location argument.
28461 Report error 227 for Unsafe use.
28463 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28465 * statement.cs (For.Emit): If the test is null, then report that
28466 we do `return', as we wont reach anything afterwards.
28468 (Switch.SwitchGoverningType): Track the expression that matched
28471 * driver.cs: Allow negative numbers as an error code to flag.
28473 * cs-parser.jay: Handle 1551.
28475 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28477 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28479 * cs-parser.jay: Report 1518 (type declaration can only contain
28480 class, struct, interface, enum or delegate)
28482 (switch_label): Report 1523 (keywords `case' or `default' must
28485 (opt_switch_sections): Report 1522 (empty switch)
28487 * driver.cs: Report 1515 (response file specified multiple times)
28488 Report 1516 (Source file specified multiple times).
28490 * expression.cs (Argument.Resolve): Signal 1510
28492 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28493 access not allowed in static code)
28495 2002-01-11 Ravi Pratap <ravi@ximian.com>
28497 * typemanager.cs (IsPointerType): Utility method which we are going
28500 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28501 the object type, so we take care of that.
28503 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28505 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28506 added to non-params parameters :-)
28508 * typemanager.cs (CSharpName): Include 'void' type too.
28510 (void_ptr_type): Include in the set of core types.
28512 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28515 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28518 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28519 completely forgotten about it.
28521 2002-01-10 Ravi Pratap <ravi@ximian.com>
28523 * cs-parser.jay (pointer_type): Add. This begins our implementation
28524 of parsing rules for unsafe code.
28526 (unsafe_statement): Implement.
28528 (embedded_statement): Modify to include the above.
28530 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28532 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28533 if the current context is an unsafe one.
28535 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28536 are handled differently, we need separate rules for them.
28538 (local_variable_declaration): Update to use local_variable_pointer_type
28539 to allow variable declarations of unmanaged pointer types.
28541 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28542 in unsafe contexts.
28544 * ../errors/cs0214.cs : Add.
28546 2002-01-16 Nick Drochak <ndrochak@gol.com>
28548 * makefile: remove 'response' file when cleaning.
28550 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28552 * cs-parser.jay: Report 1524.
28554 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28556 * typemanager.cs (RegisterMethod): drop checking if we have
28557 registered this from here
28559 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28561 * class.cs (Method.EmitDestructor): Implement calling our base
28564 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28565 value of InFinally.
28567 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28568 this routine and will wrap the call in a try/catch block. Deal
28571 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28573 * ecore.cs (Expression.MemberLookup): instead of taking a
28574 parameter `same_type' that was used to tell whether we could
28575 access private members we compute our containing type from the
28578 (FieldExpr): Added partial support for volatile fields. This does
28579 not work for volatile fields exposed from assemblies, as I can not
28580 figure out how to extract the modreq from it.
28582 Updated all the source files to use this.
28584 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28585 because it is referenced by MemberLookup very often.
28587 2002-01-09 Ravi Pratap <ravi@ximian.com>
28589 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28590 TypeBuilder.GetCustomAttributes to retrieve what we need.
28592 Get rid of redundant default_member_attr_type as this is the same as
28593 default_member_type which already exists.
28595 * interface.cs, attribute.cs : Update accordingly.
28597 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28599 * typemanager.cs: Enable IndexerPropertyName again. It does not
28600 work for TYpeBuilders though. Ravi, can you please fix this?
28602 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28604 * expression.cs (Argument.Emit): Handle the case of ref objects
28605 being passed to ref functions;
28607 (ParameterReference.EmitLoad): Loads the content of the pointer
28608 without dereferencing.
28610 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28612 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28614 2002-01-08 Ravi Pratap <ravi@ximian.com>
28616 * class.cs (Indexer.DefineMethod): Incorporate the interface
28617 type in the name of the method if we are doing explicit interface
28620 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28622 (BetterConversion): Fix extremely trivial bug where we were referring to
28623 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28626 * ../errors/bug16.cs : Add although we have fixed it.
28628 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28630 * expression.cs (BaseIndexer): Begin implementation.
28632 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28634 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28635 production directly to remove a shift/reduce, and implement
28636 explicit interface implementation.
28638 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28639 after a floating point suffix.
28641 * expression.cs (DoNumericPromotions): Improved the conversion for
28642 uint/uint. If we have a constant, we avoid doing a typecast to a
28645 * class.cs (Indexer): Implement explicit interface implementation
28648 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28650 * class.cs: make the default instance constructor public and hidebysig.
28652 2001-01-03 Ravi Pratap <ravi@ximian.com>
28654 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28655 so we can call it from elsewhere.
28657 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28658 we emit it internally if the class has a defined indexer; otherwise the user
28659 emits it by decorating the class definition with the DefaultMemberAttribute.
28661 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28662 attribute is not used on a type which defines an indexer.
28664 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28665 character when we skip whitespace.
28667 * ../errors/cs0646.cs : Add.
28669 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28671 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28674 * makefile: Add practical target `mcs3.exe' which builds the third
28675 generation compiler.
28677 * expression.cs (New): Fix structures constructor calling.
28679 * class.cs (Property, Method, Indexer): Emit Final flag on the
28680 method if we are an interface implementation and we are not
28683 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28684 whether this property is referencing a `base' method.
28686 * expression.cs (Invocation.EmitCall): take an extra argument:
28687 is_base, this is used to determine whether the `call' or
28688 `callvirt' opcode should be used.
28691 * delegate.cs: update EmitCall.
28693 * class.cs (Method.Define): Set NewSlot for the cases where we are
28694 not implementing an interface method.
28696 (Property.Define): ditto.
28698 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28700 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28701 'r'. Allows mcs to parse itself fully.
28703 2002-01-02 Ravi Pratap <ravi@ximian.com>
28705 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28706 of the number of initializers that require the InitializeArray method.
28708 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28709 update the above field where necessary.
28711 (MakeByteBlob): Update accordingly.
28713 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28716 (EmitDynamicInitializers): Update in accordance with the new optimization.
28718 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28719 same OpCode applies.
28721 * cs-parser.jay : Fix some glaring errors I introduced.
28723 2002-01-01 Ravi Pratap <ravi@ximian.com>
28725 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28726 so that we can check for name clashes there too.
28728 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28729 for interface indexers.
28731 * interfaces.cs (Define): Emit the default member attribute.
28733 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28734 variable was being referred to while setting the value ;-)
28736 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28738 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28739 byte-by-byte information when we know the data is zero.
28741 Make the block always a multiple of 4, because
28742 DefineInitializedData has a bug.
28744 * assign.cs: Fix, we should assign from the temporary, not from
28747 * expression.cs (MakeByteBlob): Fix my incorrect code.
28749 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28751 * typemanager.cs (EnumToUnderlying): This function is used to get
28752 the underlying type from an enumeration, because it does not
28755 * constant.cs: Use the I4_S form for values between -128 and 127.
28757 * statement.cs (Block.LookupLabel): Looks up a label.
28758 (Block): Drop support for labeled blocks.
28760 (LabeledStatement): New kind of statement that represents a label
28763 (Goto): Finally implement this bad boy.
28765 * cs-parser.jay: Update to reflect new mechanism to implement
28768 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28770 * codegen.cs (EmitContext.This): a codegen property that keeps the
28771 a single instance of this instead of creating many different this
28774 * delegate.cs (Delegate.DoResolve): Update to use the property;
28776 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28778 * expression.cs (BaseAccess.DoResolve): Ditto.
28780 2001-12-29 Ravi Pratap <ravi@ximian.com>
28782 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28783 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28785 (InitCoreTypes): Update accordingly.
28787 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28788 so we can quickly store the state.
28790 (ApplyAttributes): Set the correct implementation flags
28791 for InternalCall methods.
28793 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28795 * expression.cs (EmitCall): if a method is not virtual, then do
28796 not use callvirt on it.
28798 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28799 user defined stuff) requires the use of stobj, which takes an
28800 address on the stack instead of an array and an index. So emit
28801 the Ldelema operation for it.
28803 (EmitStoreOpcode): Use stobj for valuetypes.
28805 (UnaryMutator.EmitCode): Use the right 1 value depending on
28806 whether we are dealing with int64/uint64, float or doubles.
28808 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
28809 constructors that I implemented last night.
28811 (Constructor.IsDefault): Fix to work properly for static
28814 * cs-parser.jay (CheckDef): report method signature errors.
28815 Update error number 103 to be 132.
28817 * decl.cs: New AdditionResult enumeration value: MethodExists.
28818 Although we do this check for methods later on in the semantic
28819 analysis, catching repeated default constructors is so easy that
28820 we catch these here.
28822 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
28825 (ParameterReference.EmitAssign, Emit): handle
28828 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
28829 (ArrayAccess.EmitStoreOpcode): ditto.
28831 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
28833 * expression.cs (MakeByteBlob): Complete all the missing types
28834 (uint, short, ushort, byte, sbyte)
28836 * class.cs: Only init instance field initializers on instance
28839 Rename `constructors' to instance_constructors.
28841 (TypeContainer.AddConstructor): Only add constructors to the list
28842 if it is not static.
28844 Make sure that we handle default_static_constructor independently
28845 everywhere where we handle instance_constructors
28847 2001-12-28 Miguel de Icaza <miguel@ximian.com>
28849 * class.cs: Do not lookup or create a base initializer for a
28850 static constructor.
28852 (ConstructorInitializer.Resolve): use the proper type to lookup
28855 * cs-parser.jay: Report error 1585 (modifiers between type and name).
28857 * enum.cs, interface.cs: Remove CloseType, this is taken care by
28860 * decl.cs: CloseType is now an virtual method, the default
28861 implementation just closes this type.
28863 2001-12-28 Ravi Pratap <ravi@ximian.com>
28865 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
28866 to PreserveSig by default. Also emit HideBySig on such methods.
28868 Basically, set the defaults to standard values.
28870 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
28871 argument, if candidate is better, it can't be worse than the best !
28873 (Invocation): Re-write bits to differentiate between methods being
28874 applicable in their expanded form and their normal form - for params
28877 Get rid of use_standard everywhere as only standard conversions are allowed
28878 in overload resolution.
28880 More spec conformance.
28882 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28884 * driver.cs: Add --timestamp, to see where the compiler spends
28887 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
28888 `this' in static code.
28890 (SimpleName.DoResolve): Implement in terms of a helper function
28891 that allows static-references to be passed upstream to
28894 (Expression.ResolveWithSimpleName): Resolve specially simple
28895 names when called by MemberAccess to implement the special
28898 (Expression.ImplicitReferenceConversion): Handle conversions from
28899 Null to reference types before others, as Null's type is
28902 * expression.cs (Invocation.EmitCall): Handle the special case of
28903 calling methods declared on a reference type from a ValueType
28904 (Base classes System.Object and System.Enum)
28906 (MemberAccess.Resolve): Only perform lookups on Enumerations if
28907 the left hand side is a TypeExpr, not on every enumeration.
28909 (Binary.Resolve): If types are reference types, then do a cast to
28910 object on operators != and == of both arguments.
28912 * typemanager.cs (FindMembers): Extract instance and static
28913 members if requested.
28915 * interface.cs (PopulateProperty): Use void_type instead of null
28916 as the return type for the setter method.
28918 (PopulateIndexer): ditto.
28920 2001-12-27 Ravi Pratap <ravi@ximian.com>
28922 * support.cs (ReflectionParameters): Fix minor bug where we
28923 were examining the wrong parameter for the ParamArray attribute.
28925 Cope with requests for the type of the parameter at position
28926 greater than the params parameter's. We now return the element
28927 type of the params array as that makes more sense.
28929 * expression.cs (Invocation.IsParamsMethodApplicable): Update
28930 accordingly as we no longer have to extract the element type
28933 (Invocation.OverloadResolve): Update.
28935 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28937 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
28938 against IEnumerator, test whether the return value is a descendant
28939 of the IEnumerator interface.
28941 * class.cs (Indexer.Define): Use an auxiliary method to implement
28942 the other bits of the method definition. Begin support for
28943 explicit interface implementation.
28945 (Property.DefineMethod): Use TypeManager.void_type instead of null
28946 for an empty return value.
28948 2001-12-26 Miguel de Icaza <miguel@ximian.com>
28950 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
28951 dealing with a FieldExpr which is composed of a FieldBuilder, in
28952 the code path we did extract the constant, but we should have
28953 obtained the underlying value to be able to cast it (otherwise we
28954 end up in an infinite loop, this is what Ravi was running into).
28956 (ArrayCreation.UpdateIndices): Arrays might be empty.
28958 (MemberAccess.ResolveMemberAccess): Add support for section
28959 14.5.4.1 that deals with the special case of E.I when E is a type
28960 and something else, that I can be a reference to a static member.
28962 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
28963 handle a particular array type to create byte blobs, it is just
28964 something we dont generate byteblobs for.
28966 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
28969 * location.cs (Push): remove the key from the hashtable that we
28970 are about to add. This happens for empty files.
28972 * driver.cs: Dispose files after we have parsed them.
28974 (tokenize): new function that only runs the tokenizer on its
28975 input, for speed testing.
28977 2001-12-26 Ravi Pratap <ravi@ximian.com>
28979 * class.cs (Event.Define): Define the private field only if there
28980 are no accessors defined.
28982 * expression.cs (ResolveMemberAccess): If there is no associated
28983 field with the event, that means we have an event defined with its
28984 own accessors and we should flag error cs0070 since transforming
28985 ourselves into a field is not valid in that case.
28987 * ecore.cs (SimpleName.DoResolve): Same as above.
28989 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
28990 and charset to sane values.
28992 2001-12-25 Ravi Pratap <ravi@ximian.com>
28994 * assign.cs (DoResolve): Perform check on events only if they
28995 are being accessed outside the declaring type.
28997 * cs-parser.jay (event_declarations): Update rules to correctly
28998 set the type of the implicit parameter etc.
29000 (add_accessor, remove_accessor): Set current local parameters.
29002 * expression.cs (Binary): For delegate addition and subtraction,
29003 cast the return value from the method into the appropriate delegate
29006 2001-12-24 Ravi Pratap <ravi@ximian.com>
29008 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29009 of these as the workaround is unnecessary.
29011 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29012 delegate data - none of that is needed at all.
29014 Re-write bits to extract the instance expression and the delegate method
29017 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29020 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29021 of attaching attributes instead of duplicating code everywhere.
29023 * everywhere : Update code to do attribute emission using the above method.
29025 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29027 * expression.cs (IsParamsMethodApplicable): if there are not
29028 parameters, return immediately.
29030 * ecore.cs: The 0 literal can be implicity converted to an enum
29033 (SimpleName.DoResolve): First lookup the type, then lookup the
29036 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29037 want to get its address. If the InstanceExpression is not
29038 addressable, store the result in a temporary variable, then get
29041 * codegen.cs: Only display 219 errors on warning level or above.
29043 * expression.cs (ArrayAccess): Make it implement the
29044 IMemoryLocation interface.
29046 (Binary.DoResolve): handle the operator == (object a, object b)
29047 and operator != (object a, object b) without incurring into a
29048 BoxedCast (because 5 != o should never be performed).
29050 Handle binary enumerator operators.
29052 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29053 value type, otherwise use Ldelem_ref.
29055 Use precomputed names;
29057 (AddressOf): Implement address of
29059 * cs-parser.jay (labeled_statement): Fix recursive block
29060 addition by reworking the production.
29062 * expression.cs (New.DoEmit): New has a special case:
29064 If we are dealing with a ValueType, we have a few
29065 situations to deal with:
29067 * The target of New is a ValueType variable, that is
29068 easy, we just pass this as the variable reference
29070 * The target of New is being passed as an argument,
29071 to a boxing operation or a function that takes a
29074 In this case, we need to create a temporary variable
29075 that is the argument of New.
29078 2001-12-23 Ravi Pratap <ravi@ximian.com>
29080 * rootcontext.cs (LookupType): Check that current_type is not null before
29081 going about looking at nested types.
29083 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29084 not implement the IAssignMethod interface any more.
29086 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29087 where we tranform them into FieldExprs if they are being resolved from within
29088 the declaring type.
29090 * ecore.cs (SimpleName.DoResolve): Do the same here.
29092 * assign.cs (DoResolve, Emit): Clean up code considerably.
29094 * ../errors/bug10.cs : Add.
29096 * ../errors/cs0070.cs : Add.
29098 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29100 * assign.cs : Get rid of EventIsLocal everywhere.
29102 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29104 * ecore.cs (ConvertIntLiteral): finished the implementation.
29106 * statement.cs (SwitchLabel): Convert the value we are using as a
29107 key before looking up the table.
29109 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29111 * codegen.cs (EmitTopBlock): Require a Location argument now.
29113 * cs-parser.jay (constructor_declarator): We need to setup
29114 current_local_parameters before we parse the
29115 opt_constructor_initializer, to allow the variables to be bound
29116 to the constructor arguments.
29118 * rootcontext.cs (LookupType): First lookup nested classes in our
29119 class and our parents before we go looking outside our class.
29121 * expression.cs (ConstantFold): Extract/debox the values at the
29124 * rootcontext.cs (EmitCode): Resolve the constants first before we
29125 resolve the types. This is not really needed, but it helps debugging.
29127 * statement.cs: report location.
29129 * cs-parser.jay: pass location to throw statement.
29131 * driver.cs: Small bug fix.
29133 * report.cs: Updated format to be 4-zero filled digits.
29135 2001-12-22 Ravi Pratap <ravi@ximian.com>
29137 * expression.cs (CheckIndices): Fix minor bug where the wrong
29138 variable was being referred to ;-)
29140 (DoEmit): Do not call EmitStaticInitializers when the
29141 underlying type is System.Object.
29143 2001-12-21 Ravi Pratap <ravi@ximian.com>
29145 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29146 and do the usual workaround for SRE.
29148 * class.cs (MyEventBuilder.EventType): New member to get at the type
29149 of the event, quickly.
29151 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29153 * assign.cs (Assign.DoResolve): Handle the case when the target
29154 is an EventExpr and perform the necessary checks.
29156 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29159 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29161 (EventExpr): Set the type in the constructor itself since we
29162 are meant to be born fully resolved.
29164 (EventExpr.Define): Revert code I wrote earlier.
29166 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29167 instance expression is null. The instance expression is a This in that case
29168 or a null, depending on whether it is a static method or not.
29170 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29171 refers to more than one method.
29173 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29174 and accordingly flag errors.
29176 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29178 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29180 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29182 * location.cs (ToString): Provide useful rutine.
29184 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29186 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29187 objects, return the actual integral boxed.
29189 * statement.cs (SwitchLabel): define an ILLabel for each
29192 (Switch.CheckSwitch): If the value is a Literal, extract
29193 the underlying literal.
29195 Also in the unused hashtable we had, add the SwitchLabel so we can
29196 quickly look this value up.
29198 * constant.cs: Implement a bunch of new constants. Rewrite
29199 Literal based on this. Made changes everywhere to adapt to this.
29201 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29202 dereferencing array only once, and also copes with enumrations.
29204 bytes are two bytes wide, not one.
29206 (Cast): Perform constant conversions.
29208 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29209 wrappers to the literals here.
29211 * expression.cs (DoNumericPromotions): long literals can converted
29212 to ulong implicity (this is taken care of elsewhere, but I was
29213 missing this spot).
29215 * ecore.cs (Expression.Literalize): Make the return type Literal,
29216 to improve type checking.
29218 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29220 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29222 * literal.cs: Revert code from ravi that checked the bounds. The
29223 bounds are sane by the definition of the type itself.
29225 * typemanager.cs: Fix implementation of ImplementsInterface. We
29226 need to actually look up in our parent hierarchy for interfaces
29229 * const.cs: Use the underlying type for enumerations
29231 * delegate.cs: Compute the basename for the delegate creation,
29232 that should fix the delegate test case, and restore the correct
29233 Type Lookup semantics in rootcontext
29235 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29236 referencing a nested type with the Reflection API is using the "+"
29239 * cs-parser.jay: Do not require EOF token at the end.
29241 2001-12-20 Ravi Pratap <ravi@ximian.com>
29243 * rootcontext.cs (LookupType): Concatenate type names with
29244 a '.' instead of a '+' The test suite passes again.
29246 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29247 field of the enumeration.
29249 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29250 the case when the member is an EventExpr.
29252 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29253 static has an associated instance expression.
29255 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29257 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29259 * class.cs (Event.Define): Register event and perform appropriate checks
29262 We define the Add and Remove methods even if the use provides none because
29263 in that case, we provide default implementations ourselves.
29265 Define a private field of the type of the event. This is done by the CSC compiler
29266 and we should be doing it too ;-)
29268 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29269 More methods we use in code we generate.
29271 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29274 (InitCoreTypes): Update accordingly for the above.
29276 * class.cs (Event.Emit): Generate code for default accessors that we provide
29278 (EmitDefaultMethod): Do the job in the above.
29280 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29283 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29285 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29286 builders even if we were missing one.
29288 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29289 pass the Basename as our class name instead of the Name. The
29290 basename will be correctly composed for us.
29292 * parameter.cs (Paramters): Now takes a Location argument.
29294 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29295 make all the code call directly LookupType in RootContext and take
29296 this chance to pass the Location information everywhere.
29298 * Everywhere: pass Location information.
29300 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29302 * class.cs (Constructor.Define): Updated way of detecting the
29303 length of the parameters.
29305 (TypeContainer.DefineType): Use basename as the type name for
29308 (TypeContainer.Define): Do not recursively define types here, as
29309 definition is taken care in order by the RootContext.
29311 * tree.cs: Keep track of namespaces in a per-file basis.
29313 * parameter.cs (Parameter.ComputeSignature): Update to use
29316 (Parameters.GetSignature): ditto.
29318 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29319 instead of a TypeContainer.
29321 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29322 resolve names. Because we need to be resolve in our context, not
29325 * driver.cs: Implement response files.
29327 * class.cs (TypeContainer.DefineType): If we are defined, do not
29328 redefine ourselves.
29330 (Event.Emit): Emit the code for add/remove handlers.
29331 (Event.Define): Save the MethodBuilders for add/remove.
29333 * typemanager.cs: Use pair here too.
29335 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29336 DictionaryEntry requires the first argument to be non-null.
29338 (enum_declaration): Compute full name for registering the
29341 (delegate_declaration): Instead of using
29342 formal_parameter_list, use opt_formal_parameter_list as the list
29345 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29346 (EventParsing): New property that controls whether `add' and
29347 `remove' are returned as tokens or identifiers (for events);
29349 2001-12-19 Ravi Pratap <ravi@ximian.com>
29351 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29352 use MyEventBuilder only and let it wrap the real builder for us.
29354 (MyEventBuilder): Revamp constructor etc.
29356 Implement all operations that we perform on EventBuilder in precisely the same
29359 (FindMembers): Update to use the EventBuilder member.
29361 (Event.Emit): Update accordingly.
29363 2001-12-18 Ravi Pratap <ravi@ximian.com>
29365 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29366 by calling the appropriate methods.
29368 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29371 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29373 2001-12-17 Ravi Pratap <ravi@ximian.com>
29375 * delegate.cs (Delegate.Populate): Check that the return type
29376 and various parameters types are indeed accessible.
29378 * class.cs (Constructor.Define): Same here.
29380 (Field.Define): Ditto.
29382 (Event.Define): Ditto.
29384 (Operator.Define): Check that the underlying Method defined itself
29385 correctly - so it's MethodBuilder should not be null.
29387 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29388 expression happens to be null.
29390 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29391 members but as of now we don't seem to be able to do anything really useful with it.
29393 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29394 not the EventBuilder.
29396 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29398 * cs-tokenizer.cs: Add support for defines.
29399 Add support for #if, #elif, #else, #endif
29401 (eval_var): evaluates a variable.
29402 (eval): stubbed for evaluating functions.
29404 * cs-parser.jay: Pass the defines information
29406 * driver.cs: Add --define command line option.
29408 * decl.cs: Move MemberCore here.
29410 Make it the base class for DeclSpace. This allows us to catch and
29411 report 108 and 109 for everything now.
29413 * class.cs (TypeContainer.Define): Extract all the members
29414 before populating and emit the warning 108 (new keyword required
29415 to override) instead of having each member implement this.
29417 (MemberCore.Define): New abstract method, we will be using this in
29418 the warning reporting engine in Populate.
29420 (Operator.Define): Adjust to new MemberCore protocol.
29422 * const.cs (Const): This does not derive from Expression, it is a
29423 temporary object we use to create fields, it is a MemberCore.
29425 * class.cs (Method.Define): Allow the entry point to be in a
29428 * driver.cs: Rewrite the argument handler to clean it up a bit.
29430 * rootcontext.cs: Made it just an auxiliary namespace feature by
29431 making everything static.
29433 * driver.cs: Adapt code to use RootContext type name instead of
29436 * delegate.cs: Remove RootContext argument.
29438 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29441 * class.cs (Event.Define): The lookup can fail.
29443 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29445 * expression.cs: Resolve the this instance before invoking the code.
29447 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29449 * cs-parser.jay: Add a production in element_access that allows
29450 the thing to become a "type" reference. This way we can parse
29451 things like "(string [])" as a type.
29453 Note that this still does not handle the more complex rules of
29457 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29459 * ecore.cs: (CopyNewMethods): new utility function used to
29460 assemble the list of methods from running FindMembers.
29462 (MemberLookup): Rework FindMembers so that
29464 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29466 * class.cs (TypeContainer): Remove Delegates who fail to be
29469 * delegate.cs (Populate): Verify that we dont get null return
29470 values. TODO: Check for AsAccessible.
29472 * cs-parser.jay: Use basename to emit error 574 (destructor should
29473 have the same name as container class), not the full name.
29475 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29476 possible representation.
29478 Also implements integer type suffixes U and L.
29480 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29482 * expression.cs (ArrayCreation.DoResolve): We need to do the
29483 argument resolution *always*.
29485 * decl.cs: Make this hold the namespace. Hold the root context as
29487 (LookupType): Move here.
29489 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29491 * location.cs (Row, Name): Fixed the code, it was always returning
29492 references to the first file.
29494 * interface.cs: Register properties defined through interfaces.
29496 * driver.cs: Add support for globbing on the command line
29498 * class.cs (Field): Make it derive from MemberCore as well.
29501 2001-12-15 Ravi Pratap <ravi@ximian.com>
29503 * class.cs (Event::Define): Check that the type of the event is a delegate
29504 type else flag error #66.
29506 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29509 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29510 values of EntryPoint, CharSet etc etc.
29512 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29514 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29515 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29516 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29517 which needs this to do its work.
29519 * ../errors/cs0066.cs : Add.
29521 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29523 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29526 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29527 clears out the parameters field.
29528 (MemberSignatureCompare): Cleanup
29530 (MemberCore): New base class used to share code between MethodCore
29533 (RegisterRequiredImplementations) BindingFlags.Public requires
29534 either BindingFlags.Instace or Static. Use instance here.
29536 (Property): Refactored code to cope better with the full spec.
29538 * parameter.cs (GetParameterInfo): Return an empty array instead
29541 * class.cs (Property): Abstract or extern properties have no bodies.
29543 * parameter.cs (GetParameterInfo): return a zero-sized array.
29545 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29546 method modifier validation to the typecontainer so we can reuse
29547 this on properties.
29549 (MethodCore.ParameterTypes): return an empty sized array of types.
29551 (Property.Define): Test property modifier validity.
29553 Add tests for sealed/override too.
29555 (Method.Emit): abstract or extern methods have no bodies.
29557 2001-12-14 Ravi Pratap <ravi@ximian.com>
29559 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29562 (Method::Define, ::Emit): Modify accordingly.
29564 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29566 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29568 * makefile: Pass in /unsafe.
29570 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29572 * class.cs (MakeKey): Kill routine.
29574 * class.cs (TypeContainer.Define): Correctly define explicit
29575 method implementations (they require the full interface name plus
29578 * typemanager.cs: Deply the PtrHashtable here and stop using the
29579 lame keys. Things work so much better.
29581 This of course broke everyone who depended on `RegisterMethod' to
29582 do the `test for existance' test. This has to be done elsewhere.
29584 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29585 the object stupid Equals method (because, that like fails all over
29586 the place). We still do not use it.
29588 * class.cs (TypeContainer.SetRequiredInterface,
29589 TypeContainer.RequireMethods): Killed these two routines and moved
29590 all the functionality to RegisterRequiredImplementations.
29592 (TypeContainer.RegisterRequiredImplementations): This routine now
29593 registers all the implementations required in an array for the
29594 interfaces and abstract methods. We use an array of structures
29595 which can be computed ahead of time to reduce memory usage and we
29596 also assume that lookups are cheap as most classes will not
29597 implement too many interfaces.
29599 We also avoid creating too many MethodSignatures.
29601 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29602 clear the "pending" bit if we find that there are problems with
29605 (TypeContainer.VerifyPendingMethods): Update to report errors of
29606 methods that look like implementations but are not.
29608 (TypeContainer.Define): Add support for explicit interface method
29611 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29613 * typemanager.cs: Keep track of the parameters here instead of
29614 being a feature of the TypeContainer.
29616 * class.cs: Drop the registration of parameters here, as
29617 InterfaceMethods are also interface declarations.
29619 * delegate.cs: Register methods with the TypeManager not only with
29620 the TypeContainer. This code was buggy.
29622 * interface.cs: Full registation here.
29624 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29626 * expression.cs: Remove reducer for binary expressions, it can not
29629 * const.cs: Put here the code that used to go into constant.cs
29631 * constant.cs: Put here the code for constants, this is a new base
29632 class for Literals.
29634 * literal.cs: Make Literal derive from Constant.
29636 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29638 * statement.cs (Return.Emit): Report error 157 if the user
29639 attempts to return from a finally block.
29641 (Return.Emit): Instead of emitting a return, jump to the end of
29644 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29645 LocalBuilder to store the result of the function. ReturnLabel is
29646 the target where we jump.
29649 2001-12-09 Radek Doulik <rodo@ximian.com>
29651 * cs-parser.jay: remember alias in current namespace
29653 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29656 * class.cs (LookupAlias): lookup alias in my_namespace
29658 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29660 (LookupAlias): lookup alias in this and if needed in parent
29663 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29667 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29668 making things static. I need this to avoid passing the
29669 TypeContainer when calling ParameterType.
29671 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29672 that did string manipulation to compute the type and then call
29673 GetType. Use Parameter.ParameterType instead.
29675 * cs-tokenizer.cs: Consume the suffix for floating values.
29677 * expression.cs (ParameterReference): figure out whether this is a
29678 reference parameter or not. Kill an extra variable by computing
29679 the arg_idx during emission.
29681 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29682 function that returns whether a parameter is an out/ref value or not.
29684 (Parameter.ParameterType): The type of the parameter (base,
29685 without ref/out applied).
29687 (Parameter.Resolve): Perform resolution here.
29688 (Parameter.ExternalType): The full type (with ref/out applied).
29690 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29691 support for expressions on the using statement.
29693 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29695 * statement.cs (Using.EmitLocalVariableDecls): Split the
29696 localvariable handling of the using statement.
29698 (Block.EmitMeta): Keep track of variable count across blocks. We
29699 were reusing slots on separate branches of blocks.
29701 (Try.Emit): Emit the general code block, we were not emitting it.
29703 Check the type of the declaration to be an IDisposable or
29704 something that can be implicity converted to it.
29706 Emit conversions if required.
29708 * ecore.cs (EmptyExpression): New utility class.
29709 (Expression.ImplicitConversionExists): New utility function.
29711 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29713 * statement.cs (Using): Implement.
29715 * expression.cs (LocalVariableReference): Support read only variables.
29717 * statement.cs: Remove the explicit emit for the Leave opcode.
29718 (VariableInfo): Add a readonly field.
29720 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29722 * ecore.cs (ConvCast): new class used to encapsulate the various
29723 explicit integer conversions that works in both checked and
29724 unchecked contexts.
29726 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29727 properly generate the overflow opcodes.
29729 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29731 * statement.cs: The correct type for the EmptyExpression is the
29732 element_type, not the variable type. Ravi pointed this out.
29734 2001-12-04 Ravi Pratap <ravi@ximian.com>
29736 * class.cs (Method::Define): Handle PInvoke methods specially
29737 by using DefinePInvokeMethod instead of the usual one.
29739 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29740 above to do the task of extracting information and defining the method.
29742 2001-12-04 Ravi Pratap <ravi@ximian.com>
29744 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29745 of the condition for string type.
29747 (Emit): Move that here.
29749 (ArrayCreation::CheckIndices): Keep string literals in their expression
29752 (EmitDynamicInitializers): Handle strings appropriately.
29754 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29756 * codegen.cs (EmitContext): Replace multiple variables with a
29757 single pointer to the current Switch statement.
29759 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29762 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29766 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29769 (Foreach.Emit): Foreach on arrays was not setting
29770 up the loop variables (for break/continue).
29772 (GotoCase): Semi-implented.
29774 2001-12-03 Ravi Pratap <ravi@ximian.com>
29776 * attribute.cs (CheckAttribute): Handle system attributes by using
29777 Attribute.GetAttributes to examine information we need.
29779 (GetValidPlaces): Same here.
29781 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29783 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29785 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29787 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29789 (Method::Emit): Handle the case when we are a PInvoke method.
29791 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29793 * expression.cs: Use ResolveWithSimpleName on compound names.
29795 2001-12-02 Ravi Pratap <ravi@ximian.com>
29797 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29798 before trying to reduce it.
29800 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29802 * constant.cs (LookupConstantValue): Implement.
29804 (EmitConstant): Use the above in emitting the constant.
29806 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
29807 that are user-defined by doing a LookupConstantValue on them.
29809 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
29812 2001-11-29 Miguel de Icaza <miguel@ximian.com>
29814 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
29816 (BaseAccess.DoResolve): Implement.
29818 (MemberAccess.DoResolve): Split this routine into a
29819 ResolveMemberAccess routine that can be used independently
29821 2001-11-28 Miguel de Icaza <miguel@ximian.com>
29823 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
29824 As that share bits of the implementation. Is returns a boolean,
29825 while As returns the Type that is being probed.
29827 2001-12-01 Ravi Pratap <ravi@ximian.com>
29829 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
29830 instead of a Literal - much easier.
29832 (EnumInTransit): Remove - utterly useless :-)
29834 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
29836 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
29838 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
29839 chain when we have no associated expression.
29841 2001-11-30 Ravi Pratap <ravi@ximian.com>
29843 * constant.cs (Define): Use Location while reporting the errror.
29845 Also emit a warning when 'new' is used and there is no inherited
29848 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
29851 (LookupEnumValue): Implement to lookup an enum member's value and define it
29854 (Populate): Re-write accordingly to use the above routine.
29856 2001-11-27 Miguel de Icaza <miguel@ximian.com>
29858 * expression.cs (This): Fix prototype for DoResolveLValue to
29859 override the base class DoResolveLValue.
29861 * cs-parser.cs: Report errors cs574 and cs575 (destructor
29864 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
29865 (we need to load the address of the field here). This fixes
29868 (FieldExpr.DoResolveLValue): Call the DoResolve
29869 function to initialize the Instance expression.
29871 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
29872 correctly the GetEnumerator operation on a value type.
29874 * cs-parser.jay: Add more simple parsing error catches.
29876 * statement.cs (Switch): Add support for string switches.
29877 Handle null specially.
29879 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
29881 2001-11-28 Ravi Pratap <ravi@ximian.com>
29883 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
29885 (declare_local_constant): New helper function.
29887 * statement.cs (AddConstant): Keep a separate record of constants
29889 (IsConstant): Implement to determine if a variable is a constant.
29891 (GetConstantExpression): Implement.
29893 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
29895 * statement.cs (IsVariableDefined): Re-write.
29897 2001-11-27 Ravi Pratap <ravi@ximian.com>
29899 * class.cs (TypeContainer::FindMembers): Look for constants
29900 in the case when we are looking for MemberTypes.Field
29902 * expression.cs (MemberAccess::DoResolve): Check that in the
29903 case we are a FieldExpr and a Literal, we are not being accessed
29904 by an instance reference.
29906 * cs-parser.jay (local_constant_declaration): Implement.
29908 (declaration_statement): Implement for constant declarations.
29910 2001-11-26 Miguel de Icaza <miguel@ximian.com>
29912 * statement.cs (Switch): Catch double defaults.
29914 (Switch): More work on the switch() statement
29915 implementation. It works for integral values now, need to finish
29919 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29921 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
29922 integer literals into other integer literals. To be used by
29925 2001-11-24 Ravi Pratap <ravi@ximian.com>
29927 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
29930 (EmitDynamicInitializers): Cope with the above since we extract data
29931 directly from ArrayData now.
29933 (ExpectInitializers): Keep track of whether initializers are mandatory
29936 (Bounds): Make it a hashtable to prevent the same dimension being
29937 recorded for every element in that dimension.
29939 (EmitDynamicInitializers): Fix bug which prevented the Set array method
29942 Also fix bug which was causing the indices to be emitted in the reverse
29945 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29947 * expression.cs (ArrayCreation): Implement the bits that Ravi left
29948 unfinished. They do not work, because the underlying code is
29951 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29953 * cs-parser.jay: Remove bogus fixme.
29955 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
29956 on Switch statement.
29958 2001-11-23 Ravi Pratap <ravi@ximian.com>
29960 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
29963 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
29964 parameter. Apparently, any expression is allowed.
29966 (ValidateInitializers): Update accordingly.
29968 (CheckIndices): Fix some tricky bugs thanks to recursion.
29970 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
29971 I was being completely brain-dead.
29973 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
29974 and re-write acordingly.
29976 (DelegateInvocation): Re-write accordingly.
29978 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
29980 (MakeByteBlob): Handle types more correctly.
29982 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
29983 initialization from expressions but it is incomplete because I am a complete
29986 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29988 * statement.cs (If.Emit): Fix a bug that generated incorrect code
29989 on If. Basically, we have to return `true' (ie, we do return to
29990 our caller) only if both branches of the if return.
29992 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
29993 short-circuit operators, handle them as short circuit operators.
29995 (Cast.DoResolve): Resolve type.
29996 (Cast.Cast): Take an expression as the target type.
29998 * cs-parser.jay (cast_expression): Remove old hack that only
29999 allowed a limited set of types to be handled. Now we take a
30000 unary_expression and we resolve to a type during semantic
30003 Use the grammar productions from Rhys to handle casts (this is
30004 not complete like Rhys syntax yet, we fail to handle that corner
30005 case that C# has regarding (-x), but we will get there.
30007 2001-11-22 Ravi Pratap <ravi@ximian.com>
30009 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30010 field which is an array type.
30012 * cs-parser.jay (declare_local_variables): Support array initialization too.
30014 * typemanager.cs (MakeKey): Implement.
30016 (everywhere): Use the above appropriately.
30018 * cs-parser.jay (for_statement): Update for array initialization while
30019 declaring variables.
30021 * ecore.cs : The error message was correct, it's the variable's names that
30022 were misleading ;-) Make the code more readable.
30024 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30025 the correct type etc.
30027 (ConvertExplicit): Handle Enum types by examining the underlying type.
30029 2001-11-21 Ravi Pratap <ravi@ximian.com>
30031 * parameter.cs (GetCallingConvention): Always return
30032 CallingConventions.Standard for now.
30034 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30036 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30037 and `r' after calling DoNumericPromotions.
30039 * ecore.cs: Fix error message (the types were in the wrong order).
30041 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30042 BindingFlags.Instance as well
30044 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30045 implicit int literal conversion in an empty cast so that we
30046 propagate the right type upstream.
30048 (UnboxCast): new class used to unbox value types.
30049 (Expression.ConvertExplicit): Add explicit type conversions done
30052 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30053 the target type before applying the implicit LongLiterals to ULong
30056 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30058 * cs-parser.jay (for_statement): Reworked the way For works: now
30059 we declare manually any variables that are introduced in
30060 for_initializer to solve the problem of having out-of-band code
30061 emition (that is what got for broken).
30063 (declaration_statement): Perform the actual variable declaration
30064 that used to be done in local_variable_declaration here.
30066 (local_variable_declaration): Do not declare anything, just pass
30067 the information on a DictionaryEntry
30069 2001-11-20 Ravi Pratap <ravi@ximian.com>
30071 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30072 re-write of the logic to now make it recursive.
30074 (UpdateIndices): Re-write accordingly.
30076 Store element data in a separate ArrayData list in the above methods.
30078 (MakeByteBlob): Implement to dump the array data into a byte array.
30080 2001-11-19 Ravi Pratap <ravi@ximian.com>
30082 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30085 * constant.cs (Define): Implement.
30087 (EmitConstant): Re-write fully.
30089 Pass in location info.
30091 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30094 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30095 DictionaryEntry since we need location info too.
30097 (constant_declaration): Update accordingly.
30099 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30100 code into another method : UpdateIndices.
30102 2001-11-18 Ravi Pratap <ravi@ximian.com>
30104 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30105 some type checking etc.
30107 2001-11-17 Ravi Pratap <ravi@ximian.com>
30109 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30110 bits to provide dimension info if the user skips doing that.
30112 Update second constructor to store the rank correctly.
30114 2001-11-16 Ravi Pratap <ravi@ximian.com>
30116 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30117 and try to implement.
30119 * ../errors/cs0150.cs : Add.
30121 * ../errors/cs0178.cs : Add.
30123 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30125 * statement.cs: Implement foreach on multi-dimensional arrays.
30127 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30128 name of the params argument.
30130 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30131 initializing the array.
30133 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30134 we can use this elsewhere.
30136 * statement.cs: Finish implementation of foreach for single
30139 * cs-parser.jay: Use an out-of-band stack to pass information
30140 around, I wonder why I need this.
30142 foreach_block: Make the new foreach_block the current_block.
30144 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30145 function used to return a static Parameters structure. Used for
30146 empty parameters, as those are created very frequently.
30148 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30150 2001-11-15 Ravi Pratap <ravi@ximian.com>
30152 * interface.cs : Default modifier is private, not public. The
30153 make verify test passes again.
30155 2001-11-15 Ravi Pratap <ravi@ximian.com>
30157 * support.cs (ReflectionParameters): Fix logic to determine
30158 whether the last parameter is a params one. Test 9 passes again.
30160 * delegate.cs (Populate): Register the builders we define with
30161 RegisterParameterForBuilder. Test 19 passes again.
30163 * cs-parser.jay (property_declaration): Reference $6 instead
30164 of $$ to get at the location.
30166 (indexer_declaration): Similar stuff.
30168 (attribute): Ditto.
30170 * class.cs (Property): Register parameters for the Get and Set methods
30171 if they exist. Test 23 passes again.
30173 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30174 call to EmitArguments as we are sure there aren't any params arguments.
30175 Test 32 passes again.
30177 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30178 IndexOutOfRangeException.
30180 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30181 Test 33 now passes again.
30183 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30185 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30186 broke a bunch of things. Will have to come up with a better way
30187 of tracking locations.
30189 * statement.cs: Implemented foreach for single dimension arrays.
30191 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30193 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30194 an error. This removes the lookup from the critical path.
30196 * cs-parser.jay: Removed use of temporary_loc, which is completely
30199 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30201 * support.cs (ReflectionParameters.ParameterModifier): Report
30202 whether the argument is a PARAMS argument or not.
30204 * class.cs: Set the attribute `ParamArrayAttribute' on the
30205 parameter argument.
30207 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30208 and cons_param_array_attribute (ConstructorInfo for
30209 ParamArrayAttribute).,
30211 * codegen.cs: Emit the return using the `Return' statement, that
30212 way we can report the error correctly for missing return values.
30214 * class.cs (Method.Emit): Clean up.
30216 * expression.cs (Argument.Resolve): Take another argument: the
30217 location where this argument is used. Notice that this is not
30218 part of the "Argument" class as to reduce the size of the
30219 structure (we know the approximate location anyways).
30221 Test if the argument is a variable-reference, if not, then
30222 complain with a 206.
30224 (Argument.Emit): Emit addresses of variables.
30226 (Argument.FullDesc): Simplify.
30228 (Invocation.DoResolve): Update for Argument.Resolve.
30230 (ElementAccess.DoResolve): ditto.
30232 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30233 method should be virtual, as this method is always virtual.
30235 (NewDelegate.DoResolve): Update for Argument.Resolve.
30237 * class.cs (ConstructorInitializer.DoResolve): ditto.
30239 * attribute.cs (Attribute.Resolve): ditto.
30241 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30243 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30245 * expression.cs (ParameterReference): Drop IStackStorage and implement
30246 IAssignMethod instead.
30248 (LocalVariableReference): ditto.
30250 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30251 IAssignMethod instead.
30253 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30255 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30256 enumerations that are used in heavily used structures derive from
30257 byte in a laughable and pathetic attempt to reduce memory usage.
30258 This is the kind of pre-optimzations that you should not do at
30259 home without adult supervision.
30261 * expression.cs (UnaryMutator): New class, used to handle ++ and
30262 -- separatedly from the other unary operators. Cleans up the
30263 code, and kills the ExpressionStatement dependency in Unary.
30265 (Unary): Removed `method' and `Arguments' from this class, making
30266 it smaller, and moving it all to SimpleCall, so I can reuse this
30267 code in other locations and avoid creating a lot of transient data
30268 strucutres when not required.
30270 * cs-parser.jay: Adjust for new changes.
30272 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30274 * enum.cs (Enum.Populate): If there is a failure during
30277 * cs-parser.jay (opt_enum_base): we used to catch type errors
30278 here, but this is really incorrect. The type error should be
30279 catched during semantic analysis.
30281 2001-12-11 Ravi Pratap <ravi@ximian.com>
30283 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30284 current_local_parameters as expected since I, in my stupidity, had forgotten
30287 * attribute.cs (GetValidPlaces): Fix stupid bug.
30289 * class.cs (Method::Emit): Perform check on applicability of attributes.
30291 (Constructor::Emit): Ditto.
30293 (Field::Emit): Ditto.
30295 (Field.Location): Store location information.
30297 (Property, Event, Indexer, Operator): Ditto.
30299 * cs-parser.jay (field_declaration): Pass in location for each field.
30301 * ../errors/cs0592.cs : Add.
30303 2001-11-12 Ravi Pratap <ravi@ximian.com>
30305 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30307 (InitCoreTypes): Update accordingly.
30309 (RegisterAttrType, LookupAttr): Implement.
30311 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30312 info about the same.
30314 (Resolve): Update to populate the above as necessary.
30316 (Error592): Helper.
30318 (GetValidPlaces): Helper to the above.
30320 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30322 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30324 2001-11-12 Ravi Pratap <ravi@ximian.com>
30326 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30328 * ../errors/cs0617.cs : Add.
30330 2001-11-11 Ravi Pratap <ravi@ximian.com>
30332 * enum.cs (Emit): Rename to Populate to be more consistent with what
30333 we expect it to do and when exactly it is called.
30335 * class.cs, rootcontext.cs : Update accordingly.
30337 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30338 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30340 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30342 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30343 of a fieldinfo using the above, when dealing with a FieldBuilder.
30345 2001-11-10 Ravi Pratap <ravi@ximian.com>
30347 * ../errors/cs0031.cs : Add.
30349 * ../errors/cs1008.cs : Add.
30351 * ../errrors/cs0543.cs : Add.
30353 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30356 (FindMembers): Implement.
30358 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30359 enums and delegates too.
30361 (enum_types): Rename to builder_to_enum.
30363 (delegate_types): Rename to builder_to_delegate.
30365 * delegate.cs (FindMembers): Implement.
30367 2001-11-09 Ravi Pratap <ravi@ximian.com>
30369 * typemanager.cs (IsEnumType): Implement.
30371 * enum.cs (Emit): Re-write parts to account for the underlying type
30372 better and perform checking etc.
30374 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30375 of the underlying type.
30377 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30380 * enum.cs (error31): Helper to report error #31.
30382 * cs-parser.jay (enum_declaration): Store location of each member too.
30384 * enum.cs (member_to_location): New hashtable.
30386 (AddEnumMember): Update location hashtable.
30388 (Emit): Use the location of each member while reporting errors.
30390 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30392 * cs-parser.jay: A for_initializer if is a
30393 local_variable_declaration really ammount to have an implicit
30394 block with the variable declaration and no initializer for for.
30396 * statement.cs (For.Emit): Cope with null initializers.
30398 This fixes the infinite loop on for initializers.
30400 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30402 * enum.cs: More cleanup.
30404 * ecore.cs: Remove dead code.
30406 * class.cs (Property.Emit): More simplification.
30407 (Event.Emit): ditto.
30409 Reworked to have less levels of indentation.
30411 2001-11-08 Ravi Pratap <ravi@ximian.com>
30413 * class.cs (Property): Emit attributes.
30423 * enum.cs (Emit): Ditto.
30425 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30428 * class.cs (Field, Event, etc.): Move attribute generation into the
30429 Emit method everywhere.
30431 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30432 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30433 as we had no way of defining nested enums !
30435 * rootcontext.cs : Adjust code accordingly.
30437 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30439 2001-11-07 Ravi Pratap <ravi@ximian.com>
30441 * expression.cs (EvalConstantExpression): Move into ecore.cs
30443 * enum.cs (Enum): Rename some members and make them public and readonly
30444 according to our convention.
30446 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30449 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30451 (Enum::Emit): Write a simple version for now which doesn't try to compute
30452 expressions. I shall modify this to be more robust in just a while.
30454 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30456 (TypeContainer::CloseType): Create the Enum types too.
30458 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30460 * expression.cs (EvalConstantExpression): Get rid of completely.
30462 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30463 user-defined values and other cases.
30465 (IsValidEnumLiteral): Helper function.
30467 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30468 out there in the case we had a literal FieldExpr.
30470 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30472 (Literalize): Revamp a bit to take two arguments.
30474 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30476 2001-11-06 Ravi Pratap <ravi@ximian.com>
30478 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30480 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30482 (Resolve): Use the above to ensure we have proper initializers.
30484 2001-11-05 Ravi Pratap <ravi@ximian.com>
30486 * expression.cs (Expression::EvalConstantExpression): New method to
30487 evaluate constant expressions.
30489 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30491 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30493 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30496 (Binary.ResolveOperator): Handle operator != (object a, object b)
30497 and operator == (object a, object b);
30499 (Binary.DoNumericPromotions): Indicate whether the numeric
30500 promotion was possible.
30502 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30505 Made the ArrayAccess implement interface IAssignMethod instead of
30506 IStackStore as the order in which arguments are passed reflects
30509 * assign.cs: Instead of using expr.ExprClass to select the way of
30510 assinging, probe for the IStackStore/IAssignMethod interfaces.
30512 * typemanager.cs: Load InitializeArray definition.
30514 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30515 static data that can be used to initialize arrays.
30517 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30519 * expression.cs: Handle operator== and operator!= for booleans.
30521 (Conditioal.Reduce): Implement reducer for the ?: operator.
30523 (Conditional.Resolve): Implement dead code elimination.
30525 (Binary.Resolve): Catch string literals and return a new
30526 concatenated string.
30528 (Unary.Reduce): Implement reduction of unary expressions.
30530 * ecore.cs: Split out the expression core handling here.
30532 (Expression.Reduce): New method used to perform constant folding
30533 and CSE. This is needed to support constant-expressions.
30535 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30536 targets, and optimize for !x.
30538 2001-11-04 Ravi Pratap <ravi@ximian.com>
30540 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30541 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30542 set custom atttributes.
30544 * literal.cs (Literal::GetValue): New abstract method to return the actual
30545 value of the literal, cast as an object.
30547 (*Literal): Implement GetValue method.
30549 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30550 expressions to the arraylist but objects of type Argument.
30552 * class.cs (TypeContainer::Emit): Emit our attributes too.
30554 (Method::Emit, Constructor::Emit): Ditto.
30556 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30557 to be ignoring earlier.
30559 2001-11-03 Ravi Pratap <ravi@ximian.com>
30561 * attribute.cs (AttributeSection::Define): Implement to do the business
30562 of constructing a CustomAttributeBuilder.
30564 (Attribute): New trivial class. Increases readability of code.
30566 * cs-parser.jay : Update accordingly.
30568 (positional_argument_list, named_argument_list, named_argument): New rules
30570 (attribute_arguments): Use the above so that we are more correct.
30572 2001-11-02 Ravi Pratap <ravi@ximian.com>
30574 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30575 to perform all checks for a method with a params parameter.
30577 (Invocation::OverloadResolve): Update to use the above method and therefore
30578 cope correctly with params method invocations.
30580 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30583 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30584 constructors in our parent too because we can't afford to miss out on
30587 * attribute.cs (AttributeSection): New name for the class Attribute
30589 Other trivial changes to improve readability.
30591 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30592 use the new class names.
30594 2001-11-01 Ravi Pratap <ravi@ximian.com>
30596 * class.cs (Method::Define): Complete definition for params types too
30598 (Indexer::Define): Ditto.
30600 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30601 Cope everywhere with a request for info about the array parameter.
30603 2001-11-01 Ravi Pratap <ravi@ximian.com>
30605 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30607 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30608 local_variable_type to extract the string corresponding to the type.
30610 (local_variable_type): Fixup the action to use the new helper method.
30612 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30615 * expression.cs : Clean out code which uses the above.
30617 2001-10-31 Ravi Pratap <ravi@ximian.com>
30619 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30620 and bale out if necessary by returning a false.
30622 (RegisterProperty): Ditto.
30624 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30625 and print out appropriate error messages.
30627 * interface.cs (everywhere): Ditto.
30629 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30630 location to constructor.
30632 * class.cs (Property, Event, Indexer): Update accordingly.
30634 * ../errors/cs111.cs : Added.
30636 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30637 of a method, as laid down by the spec.
30639 (Invocation::OverloadResolve): Use the above method.
30641 2001-10-31 Ravi Pratap <ravi@ximian.com>
30643 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30644 now take a TypeContainer and a Parameters object.
30646 (ParameterData): Modify return type of ParameterModifier method to be
30647 Parameter.Modifier and not a string.
30649 (ReflectionParameters, InternalParameters): Update accordingly.
30651 * expression.cs (Argument::GetParameterModifier): Same here.
30653 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30654 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30655 symbol in it at all so maybe this is only for now.
30657 2001-10-30 Ravi Pratap <ravi@ximian.com>
30659 * support.cs (InternalParameters): Constructor now takes an extra argument
30660 which is the actual Parameters class.
30662 (ParameterDesc): Update to provide info on ref/out modifiers.
30664 * class.cs (everywhere): Update call to InternalParameters to pass in
30665 the second argument too.
30667 * support.cs (ParameterData): Add ParameterModifier, which is a method
30668 to return the modifier info [ref/out etc]
30670 (InternalParameters, ReflectionParameters): Implement the above.
30672 * expression.cs (Argument::ParameterModifier): Similar function to return
30673 info about the argument's modifiers.
30675 (Invocation::OverloadResolve): Update to take into account matching modifiers
30678 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30679 a new SetFormalParameters object which we pass to InternalParameters.
30681 2001-10-30 Ravi Pratap <ravi@ximian.com>
30683 * expression.cs (NewArray): Merge into the ArrayCreation class.
30685 2001-10-29 Ravi Pratap <ravi@ximian.com>
30687 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30688 NewUserdefinedArray into one as there wasn't much of a use in having
30691 * expression.cs (Argument): Change field's name to ArgType from Type.
30693 (Type): New readonly property which returns the proper type, taking into
30694 account ref/out modifiers.
30696 (everywhere): Adjust code accordingly for the above.
30698 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30699 whether we are emitting for a ref or out parameter.
30701 * expression.cs (Argument::Emit): Use the above field to set the state.
30703 (LocalVariableReference::Emit): Update to honour the flag and emit the
30706 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30708 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30710 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30712 (ReflectionParameters, InternalParameters): Implement the above method.
30714 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30717 (Invocation::FullMethodDesc): Ditto.
30719 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30721 * cs-parser.jay: Add extra production for the second form of array
30724 * expression.cs (ArrayCreation): Update to reflect the above
30727 * Small changes to prepare for Array initialization.
30729 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30731 * typemanager.cs (ImplementsInterface): interface might be null;
30732 Deal with this problem;
30734 Also, we do store negative hits on the cache (null values), so use
30735 this instead of calling t.GetInterfaces on the type everytime.
30737 2001-10-28 Ravi Pratap <ravi@ximian.com>
30739 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30741 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30742 split functionality out into different classes.
30744 (New::FormArrayType): Move into NewBuiltinArray.
30746 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30749 (NewBuiltinArray): New class to handle creation of built-in arrays.
30751 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30752 account creation of one-dimensional arrays.
30754 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30756 (NewUserdefinedArray::DoResolve): Implement.
30758 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30760 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30761 we maintain inside the TypeManager. This is necessary to perform lookups on the
30764 (LookupType): Update to perform GetType on the module builders too.
30766 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30768 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30770 2001-10-23 Ravi Pratap <ravi@ximian.com>
30772 * expression.cs (New::DoResolve): Implement guts of array creation.
30774 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30776 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30778 * expression.cs: Fix bug I introduced lsat night that broke
30781 (Expression.Resolve): Report a 246 error (can not resolve name)
30782 if we find a SimpleName in the stream.
30784 (Expression.ResolveLValue): Ditto.
30786 (Expression.ResolveWithSimpleName): This function is a variant of
30787 ResolveName, this one allows SimpleNames to be returned without a
30788 warning. The only consumer of SimpleNames is MemberAccess
30790 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30792 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30793 might arrive here. I have my doubts that this is correct.
30795 * statement.cs (Lock): Implement lock statement.
30797 * cs-parser.jay: Small fixes to support `lock' and `using'
30799 * cs-tokenizer.cs: Remove extra space
30801 * driver.cs: New flag --checked, allows to turn on integer math
30804 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30805 Threading.Monitor.Exit
30807 2001-10-23 Miguel de Icaza <miguel@ximian.com>
30809 * expression.cs (IndexerAccess::DoResolveLValue): Set the
30810 Expression Class to be IndexerAccess.
30812 Notice that Indexer::DoResolve sets the eclass to Value.
30814 2001-10-22 Miguel de Icaza <miguel@ximian.com>
30816 * class.cs (TypeContainer::Emit): Emit code for indexers.
30818 * assign.cs (IAssignMethod): New interface implemented by Indexers
30819 and Properties for handling assignment.
30821 (Assign::Emit): Simplify and reuse code.
30823 * expression.cs (IndexerAccess, PropertyExpr): Implement
30824 IAssignMethod, clean up old code.
30826 2001-10-22 Ravi Pratap <ravi@ximian.com>
30828 * typemanager.cs (ImplementsInterface): New method to determine if a type
30829 implements a given interface. Provides a nice cache too.
30831 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
30834 (ConvertReferenceExplicit): Ditto.
30836 * delegate.cs (Delegate::Populate): Update to define the parameters on the
30837 various methods, with correct names etc.
30839 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
30840 Operator.UnaryNegation.
30842 * cs-parser.jay (operator_declarator): Be a little clever in the case where
30843 we have a unary plus or minus operator.
30845 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
30848 * everywhere : update accordingly.
30850 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
30853 * class.cs (Method::Define): For the case where we are implementing a method
30854 inherited from an interface, we need to set the MethodAttributes.Final flag too.
30855 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
30857 2001-10-21 Ravi Pratap <ravi@ximian.com>
30859 * interface.cs (FindMembers): Implement to work around S.R.E
30862 * typemanager.cs (IsInterfaceType): Implement.
30864 (FindMembers): Update to handle interface types too.
30866 * expression.cs (ImplicitReferenceConversion): Re-write bits which
30867 use IsAssignableFrom as that is not correct - it doesn't work.
30869 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
30870 and accordingly override EmitStatement.
30872 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
30873 using the correct logic :-)
30875 2001-10-19 Ravi Pratap <ravi@ximian.com>
30877 * ../errors/cs-11.cs : Add to demonstrate error -11
30879 2001-10-17 Miguel de Icaza <miguel@ximian.com>
30881 * assign.cs (Assign::Resolve): Resolve right hand side first, and
30882 then pass this as a hint to ResolveLValue.
30884 * expression.cs (FieldExpr): Add Location information
30886 (FieldExpr::LValueResolve): Report assignment to readonly
30889 (Expression::ExprClassFromMemberInfo): Pass location information.
30891 (Expression::ResolveLValue): Add new method that resolves an
30894 (Expression::DoResolveLValue): Default invocation calls
30897 (Indexers): New class used to keep track of indexers in a given
30900 (IStackStore): Renamed from LValue, as it did not really describe
30901 what this did. Also ResolveLValue is gone from this interface and
30902 now is part of Expression.
30904 (ElementAccess): Depending on the element access type
30906 * typemanager.cs: Add `indexer_name_type' as a Core type
30907 (System.Runtime.CompilerServices.IndexerNameAttribute)
30909 * statement.cs (Goto): Take a location.
30911 2001-10-18 Ravi Pratap <ravi@ximian.com>
30913 * delegate.cs (Delegate::VerifyDelegate): New method to verify
30914 if two delegates are compatible.
30916 (NewDelegate::DoResolve): Update to take care of the case when
30917 we instantiate a delegate from another delegate.
30919 * typemanager.cs (FindMembers): Don't even try to look up members
30920 of Delegate types for now.
30922 2001-10-18 Ravi Pratap <ravi@ximian.com>
30924 * delegate.cs (NewDelegate): New class to take care of delegate
30927 * expression.cs (New): Split the delegate related code out into
30928 the NewDelegate class.
30930 * delegate.cs (DelegateInvocation): New class to handle delegate
30933 * expression.cs (Invocation): Split out delegate related code into
30934 the DelegateInvocation class.
30936 2001-10-17 Ravi Pratap <ravi@ximian.com>
30938 * expression.cs (New::DoResolve): Implement delegate creation fully
30939 and according to the spec.
30941 (New::DoEmit): Update to handle delegates differently.
30943 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
30944 because of which we were printing out arguments in reverse order !
30946 * delegate.cs (VerifyMethod): Implement to check if the given method
30947 matches the delegate.
30949 (FullDelegateDesc): Implement.
30951 (VerifyApplicability): Implement.
30953 * expression.cs (Invocation::DoResolve): Update to accordingly handle
30954 delegate invocations too.
30956 (Invocation::Emit): Ditto.
30958 * ../errors/cs1593.cs : Added.
30960 * ../errors/cs1594.cs : Added.
30962 * delegate.cs (InstanceExpression, TargetMethod): New properties.
30964 2001-10-16 Ravi Pratap <ravi@ximian.com>
30966 * typemanager.cs (intptr_type): Core type for System.IntPtr
30968 (InitCoreTypes): Update for the same.
30970 (iasyncresult_type, asynccallback_type): Ditto.
30972 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
30975 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
30978 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
30979 the builders for the 4 members of a delegate type :-)
30981 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
30984 * expression.cs (New::DoResolve): Implement guts for delegate creation.
30986 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
30988 2001-10-15 Miguel de Icaza <miguel@ximian.com>
30990 * statement.cs (Break::Emit): Implement.
30991 (Continue::Emit): Implement.
30993 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
30994 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
30995 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
30996 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
30999 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31000 properties that track the label for the current loop (begin of the
31001 loop and end of the loop).
31003 2001-10-15 Ravi Pratap <ravi@ximian.com>
31005 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31006 use of emitting anything at all.
31008 * class.cs, rootcontext.cs : Get rid of calls to the same.
31010 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31012 (Populate): Define the constructor correctly and set the implementation
31015 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31018 (AddDelegateType): Implement.
31020 (IsDelegateType): Implement helper method.
31022 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31024 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31025 and accordingly handle it.
31027 * delegate.cs (Populate): Take TypeContainer argument.
31028 Implement bits to define the Invoke method. However, I still haven't figured out
31029 how to take care of the native int bit :-(
31031 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31032 Qualify the name of the delegate, not its return type !
31034 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31037 (StandardConversionExists): Checking for array types turns out to be recursive.
31039 (ConvertReferenceExplicit): Implement array conversion.
31041 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31043 2001-10-12 Ravi Pratap <ravi@ximian.com>
31045 * cs-parser.jay (delegate_declaration): Store the fully qualified
31046 name as it is a type declaration.
31048 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31051 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31052 as TypeContainer::DefineType.
31054 (Populate): Method in which all the definition of the various methods (Invoke)
31057 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31060 (CloseDelegate): Finally creates the delegate.
31062 * class.cs (TypeContainer::DefineType): Update to define delegates.
31063 (Populate, Emit and CloseType): Do the same thing here too.
31065 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31066 delegates in all these operations.
31068 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31070 * expression.cs: LocalTemporary: a new expression used to
31071 reference a temporary that has been created.
31073 * assign.cs: Handle PropertyAccess back here, so that we can
31074 provide the proper semantic access to properties.
31076 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31077 a few more explicit conversions.
31079 * modifiers.cs: `NEW' modifier maps to HideBySig.
31081 * expression.cs (PropertyExpr): Make this into an
31082 ExpressionStatement, and support the EmitStatement code path.
31084 Perform get/set error checking, clean up the interface.
31086 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31087 them into toplevel access objects.
31089 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31091 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31094 * typemanager.cs: Keep track here of our PropertyBuilders again to
31095 work around lameness in SRE.
31097 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31099 * expression.cs (LValue::LValueResolve): New method in the
31100 interface, used to perform a second resolution pass for LValues.
31102 (This::DoResolve): Catch the use of this in static methods.
31104 (This::LValueResolve): Implement.
31106 (This::Store): Remove warning, assigning to `this' in structures
31109 (Invocation::Emit): Deal with invocation of
31110 methods on value types. We need to pass the address to structure
31111 methods rather than the object itself. (The equivalent code to
31112 emit "this" for structures leaves the entire structure on the
31113 stack instead of a pointer to it).
31115 (ParameterReference::DoResolve): Compute the real index for the
31116 argument based on whether the method takes or not a `this' pointer
31117 (ie, the method is static).
31119 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31120 value types returned from functions when we need to invoke a
31121 method on the sturcture.
31124 2001-10-11 Ravi Pratap <ravi@ximian.com>
31126 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31127 defining the type in the Modulebuilder or Typebuilder. This is to take
31128 care of nested types which need to be defined on the TypeBuilder using
31129 DefineNestedMethod.
31131 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31132 methods in RootContext, only ported to be part of TypeContainer.
31134 (TypeContainer::GetInterfaceOrClass): Ditto.
31136 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31138 * interface.cs (Interface::DefineInterface): New method. Does exactly
31139 what RootContext.CreateInterface did earlier, only it takes care of nested types
31142 (Interface::GetInterfaces): Move from RootContext here and port.
31144 (Interface::GetInterfaceByName): Same here.
31146 * rootcontext.cs (ResolveTree): Re-write.
31148 (PopulateTypes): Re-write.
31150 * class.cs (TypeContainer::Populate): Populate nested types too.
31151 (TypeContainer::Emit): Emit nested members too.
31153 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31154 instead just use the name argument passed in as it is already fully
31157 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31158 to TypeContainer mapping to see if a type is user-defined.
31160 * class.cs (TypeContainer::CloseType): Implement.
31162 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31163 the default constructor.
31165 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31168 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31170 * interface.cs (CloseType): Create the type here.
31172 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31175 Remove all the methods which are now in TypeContainer.
31177 2001-10-10 Ravi Pratap <ravi@ximian.com>
31179 * delegate.cs (Define): Re-write bits to define the delegate
31182 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31184 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31186 * expression.cs (ImplicitReferenceConversion): handle null as well
31187 as a source to convert to any reference type.
31189 * statement.cs (Return): Perform any implicit conversions to
31190 expected return type.
31192 Validate use of return statement.
31194 * codegen.cs (EmitContext): Pass the expected return type here.
31196 * class.cs (Method, Constructor, Property): Pass expected return
31197 type to EmitContext.
31199 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31201 * expression.cs: Make DoResolve take an EmitContext instead of a
31204 Replaced `l' and `location' for `loc', for consistency.
31206 (Error, Warning): Remove unneeded Tc argument.
31208 * assign.cs, literal.cs, constant.cs: Update to new calling
31211 * codegen.cs: EmitContext now contains a flag indicating whether
31212 code is being generated in a static method or not.
31214 * cs-parser.jay: DecomposeQI, new function that replaces the old
31215 QualifiedIdentifier. Now we always decompose the assembled
31216 strings from qualified_identifier productions into a group of
31219 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31221 * rootcontext.cs: Deal with field-less struct types correctly now
31222 by passing the size option to Define Type.
31224 * class.cs: Removed hack that created one static field.
31226 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31228 * statement.cs: Moved most of the code generation here.
31230 2001-10-09 Ravi Pratap <ravi@ximian.com>
31232 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31235 (ElementAccess): Remove useless bits for now - keep checks as the spec
31238 2001-10-08 Ravi Pratap <ravi@ximian.com>
31240 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31241 and start performing checks according to the spec.
31243 2001-10-07 Ravi Pratap <ravi@ximian.com>
31245 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31246 rank_specifiers instead.
31248 (rank_specifiers): Change the order in which the rank specifiers are stored
31250 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31252 * expression.cs (ElementAccess): Implement the LValue interface too.
31254 2001-10-06 Ravi Pratap <ravi@ximian.com>
31256 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31257 except that user defined conversions are not included.
31259 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31260 perform the conversion of the return type, if necessary.
31262 (New::DoResolve): Check whether we are creating an array or an object
31263 and accordingly do the needful.
31265 (New::Emit): Same here.
31267 (New::DoResolve): Implement guts of array creation.
31269 (New::FormLookupType): Helper function.
31271 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31273 * codegen.cs: Removed most of the code generation here, and move the
31274 corresponding code generation bits to the statement classes.
31276 Added support for try/catch/finalize and throw.
31278 * cs-parser.jay: Added support for try/catch/finalize.
31280 * class.cs: Catch static methods having the flags override,
31281 virtual or abstract.
31283 * expression.cs (UserCast): This user cast was not really doing
31284 what it was supposed to do. Which is to be born in fully resolved
31285 state. Parts of the resolution were being performed at Emit time!
31289 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31291 * expression.cs: Implicity convert the result from UserCast.
31293 2001-10-05 Ravi Pratap <ravi@ximian.com>
31295 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31296 prevented it from working correctly.
31298 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31299 merely ConvertImplicit.
31301 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31303 * typemanager.cs: Make the LookupTypeContainer function static,
31304 and not per-instance.
31306 * class.cs: Make static FindMembers (the one that takes a Type
31309 * codegen.cs: Add EmitForeach here.
31311 * cs-parser.jay: Make foreach a toplevel object instead of the
31312 inline expansion, as we need to perform semantic analysis on it.
31314 2001-10-05 Ravi Pratap <ravi@ximian.com>
31316 * expression.cs (Expression::ImplicitUserConversion): Rename to
31317 UserDefinedConversion.
31319 (Expression::UserDefinedConversion): Take an extra argument specifying
31320 whether we look for explicit user conversions too.
31322 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31324 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31326 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31327 with the appropriate arguments.
31329 * cs-parser.jay (cast_expression): Record location too.
31331 * expression.cs (Cast): Record location info.
31333 (Expression::ConvertExplicit): Take location argument.
31335 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31336 to determine if we are doing explicit conversions.
31338 (UserCast::Emit): Update accordingly.
31340 (Expression::ConvertExplicit): Report an error if everything fails.
31342 * ../errors/cs0030.cs : Add.
31344 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31346 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31347 virtual and newslot bits.
31349 * class.cs (TypeContainer::RegisterRequiredImplementations):
31350 Record methods we need.
31352 (TypeContainer::MakeKey): Helper function to make keys for
31353 MethodBases, since the Methodbase key is useless.
31355 (TypeContainer::Populate): Call RegisterRequiredImplementations
31356 before defining the methods.
31358 Create a mapping for method_builders_to_methods ahead of time
31359 instead of inside a tight loop.
31361 (::RequireMethods): Accept an object as the data to set into the
31362 hashtable so we can report interface vs abstract method mismatch.
31364 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31366 * report.cs: Make all of it static.
31368 * rootcontext.cs: Drop object_type and value_type computations, as
31369 we have those in the TypeManager anyways.
31371 Drop report instance variable too, now it is a global.
31373 * driver.cs: Use try/catch on command line handling.
31375 Add --probe option to debug the error reporting system with a test
31378 * report.cs: Add support for exiting program when a probe
31379 condition is reached.
31381 2001-10-03 Ravi Pratap <ravi@ximian.com>
31383 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31384 we do a forcible conversion regardless of type, to check if
31385 ForceConversion returns a null.
31387 (Binary::error19): Use location to report error.
31389 (Unary::error23): Use location here too.
31391 * ../errors/cs0019.cs : Check in.
31393 * ../errors/cs0023.cs : Check in.
31395 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31396 case of a non-null MethodInfo object with a length of 0 !
31398 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31399 an applicable member - according to the spec :-)
31400 Also fix logic to find members in base types.
31402 (Unary::ResolveOperator): Same here.
31404 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31405 as I was getting thoroughly confused between this and error19 :-)
31407 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31408 (::FindMostEncompassedType): Implement.
31409 (::FindMostEncompassingType): Implement.
31410 (::StandardConversionExists): Implement.
31412 (UserImplicitCast): Re-vamp. We now need info about most specific
31413 source and target types so that we can do the necessary conversions.
31415 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31416 mathematical union with no duplicates.
31418 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31420 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31421 in order from base classes to child classes, so that we can in
31422 child classes look up in our parent for method names and
31423 attributes (required for handling abstract, virtual, new, override
31424 constructs: we need to instrospect our base class, and if we dont
31425 populate the classes in order, the introspection might be
31426 incorrect. For example, a method could query its parent before
31427 the parent has any methods and would determine that the parent has
31428 no abstract methods (while it could have had them)).
31430 (RootContext::CreateType): Record the order in which we define the
31433 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31435 * class.cs (TypeContainer::Populate): Also method definitions can
31436 fail now, keep track of this.
31438 (TypeContainer::FindMembers): Implement support for
31439 DeclaredOnly/noDeclaredOnly flag.
31441 (Constructor::Emit) Return the ConstructorBuilder.
31443 (Method::Emit) Return the MethodBuilder.
31444 Check for abstract or virtual methods to be public.
31446 * rootcontext.cs (RootContext::CreateType): Register all the
31447 abstract methods required for the class to be complete and the
31448 interface methods that must be implemented.
31450 * cs-parser.jay: Report error 501 (method requires body if it is
31451 not marked abstract or extern).
31453 * expression.cs (TypeOf::Emit): Implement.
31455 * typemanager.cs: runtime_handle_type, new global type.
31457 * class.cs (Property::Emit): Generate code for properties.
31459 2001-10-02 Ravi Pratap <ravi@ximian.com>
31461 * expression.cs (Unary::ResolveOperator): Find operators on base type
31462 too - we now conform exactly to the spec.
31464 (Binary::ResolveOperator): Same here.
31466 * class.cs (Operator::Define): Fix minor quirk in the tests.
31468 * ../errors/cs0215.cs : Added.
31470 * ../errors/cs0556.cs : Added.
31472 * ../errors/cs0555.cs : Added.
31474 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31476 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31477 single integer which is really efficient
31479 2001-10-01 Ravi Pratap <ravi@ximian.com>
31481 * expression.cs (Expression::ImplicitUserConversion): Use location
31482 even in the case when we are examining True operators.
31484 * class.cs (Operator::Define): Perform extensive checks to conform
31485 with the rules for operator overloading in the spec.
31487 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31488 some of the other conversions mentioned in the spec.
31490 * typemanager.cs (array_type): New static member for the System.Array built-in
31493 (cloneable_interface): For System.ICloneable interface.
31495 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31496 we start resolving the tree and populating types.
31498 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31500 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31502 * expression.cs (Expression::ExprClassFromMemberInfo,
31503 Expression::Literalize): Create literal expressions from
31504 FieldInfos which are literals.
31506 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31507 type casts, because they were wrong. The test suite in tests
31510 (ImplicitNumericConversion): ushort to ulong requires a widening
31513 Int32 constant to long requires widening cast as well.
31515 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31516 for integers because the type on the stack is not i4.
31518 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31520 * expression.cs (report118): require location argument.
31522 * parameter.cs: Do not dereference potential null value.
31524 * class.cs: Catch methods that lack the `new' keyword when
31525 overriding a name. Report warnings when `new' is used without
31526 anything being there to override.
31528 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31530 * class.cs: Only add constructor to hashtable if it is non-null
31531 (as now constructors can fail on define).
31533 (TypeManager, Class, Struct): Take location arguments.
31535 Catch field instance initialization in structs as errors.
31537 accepting_filter: a new filter for FindMembers that is static so
31538 that we dont create an instance per invocation.
31540 (Constructor::Define): Catch errors where a struct constructor is
31543 * cs-parser.jay: Pass location information for various new
31546 * delegate.cs (Delegate): take a location argument.
31548 * driver.cs: Do not call EmitCode if there were problesm in the
31549 Definition of the types, as many Builders wont be there.
31551 * decl.cs (Decl::Decl): Require a location argument.
31553 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31554 into integers, and find the most appropiate integer for it.
31556 * literal.cs: Implement ULongLiteral.
31558 * rootcontext.cs: Provide better information about the location of
31559 failure when CreateType fails.
31561 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31563 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31566 * expression.cs (Binary::CheckShiftArguments): Add missing type
31568 (Binary::ResolveOperator): Add type to the logical and and logical
31569 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31572 (Binary::DoNumericPromotions): In the case where either argument
31573 is ulong (and most signed types combined with ulong cause an
31574 error) perform implicit integer constant conversions as well.
31576 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31578 * expression.cs (UserImplicitCast): Method should always be
31580 (Invocation::BetterConversion): Simplified test for IntLiteral.
31582 (Expression::ImplicitNumericConversion): Split this routine out.
31583 Put the code that performs implicit constant integer conversions
31586 (Expression::Resolve): Become a wrapper around DoResolve so we can
31587 check eclass and type being set after resolve.
31589 (Invocation::Badness): Remove this dead function
31591 (Binary::ResolveOperator): Do not compute the expensive argumnets
31592 unless we have a union for it.
31594 (Probe::Emit): Is needs to do an isinst and then
31595 compare against null.
31597 (::CanConvert): Added Location argument. If the Location argument
31598 is null (Location.Null), then we do not report errors. This is
31599 used by the `probe' mechanism of the Explicit conversion. We do
31600 not want to generate an error for something that the user
31601 explicitly requested to be casted. But the pipeline for an
31602 explicit cast first tests for potential implicit casts.
31604 So for now, if the Location is null, it means `Probe only' to
31605 avoid adding another argument. Might have to revise this
31608 (ClassCast): New class used to type cast objects into arbitrary
31609 classes (used in Explicit Reference Conversions).
31611 Implement `as' as well.
31613 Reverted all the patches from Ravi below: they were broken:
31615 * The use of `level' as a mechanism to stop recursive
31616 invocations is wrong. That was there just to catch the
31617 bug with a strack trace but not as a way of addressing
31620 To fix the problem we have to *understand* what is going
31621 on and the interactions and come up with a plan, not
31622 just get things going.
31624 * The use of the type conversion cache that I proposed
31625 last night had an open topic: How does this work across
31626 protection domains. A user defined conversion might not
31627 be public in the location where we are applying the
31628 conversion, a different conversion might be selected
31629 (ie, private A->B (better) but public B->A (worse),
31630 inside A, A->B applies, but outside it, B->A will
31633 * On top of that (ie, even if the above is solved),
31634 conversions in a cache need to be abstract. Ie, `To
31635 convert from an Int to a Short use an OpcodeCast', not
31636 `To convert from an Int to a Short use the OpcodeCast on
31637 the variable 5' (which is what this patch was doing).
31639 2001-09-28 Ravi Pratap <ravi@ximian.com>
31641 * expression.cs (Invocation::ConversionExists): Re-write to use
31642 the conversion cache
31644 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31645 cache all conversions done, not just user-defined ones.
31647 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31648 to determine if a conversion exists instead of acutually trying to
31649 perform the conversion. It's faster too.
31651 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31652 and only then attempt the implicit conversion.
31654 2001-09-28 Ravi Pratap <ravi@ximian.com>
31656 * expression.cs (ConvertImplicit): Use a cache for conversions
31657 already found. Check level of recursion and bail out if necessary.
31659 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31661 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31662 Export standard methods that we expect for string operations.
31664 * statement.cs (Block::UsageWarning): Track usage of variables and
31665 report the errors for not used variables.
31667 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31670 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31672 * codegen.cs: remove unnneded code
31674 * expression.cs: Removed BuiltinTypeAccess class
31676 Fix the order in which implicit conversions are
31679 The previous fixed dropped support for boxed conversions (adding a
31680 test to the test suite now)
31682 (UserImplicitCast::CanConvert): Remove test for source being null,
31683 that code is broken. We should not feed a null to begin with, if
31684 we do, then we should track the bug where the problem originates
31685 and not try to cover it up here.
31687 Return a resolved expression of type UserImplicitCast on success
31688 rather than true/false. Ravi: this is what I was talking about,
31689 the pattern is to use a static method as a "constructor" for
31692 Also, do not create arguments until the very last minute,
31693 otherwise we always create the arguments even for lookups that
31694 will never be performed.
31696 (UserImplicitCast::Resolve): Eliminate, objects of type
31697 UserImplicitCast are born in a fully resolved state.
31699 * typemanager.cs (InitCoreTypes): Init also value_type
31700 (System.ValueType).
31702 * expression.cs (Cast::Resolve): First resolve the child expression.
31704 (LValue): Add new method AddressOf to be used by
31707 Change the argument of Store to take an EmitContext instead of an
31708 ILGenerator, because things like FieldExpr need to be able to call
31709 their children expression to generate the instance code.
31711 (Expression::Error, Expression::Warning): Sugar functions for
31714 (Expression::MemberLookup): Accept a TypeContainer instead of a
31715 Report as the first argument.
31717 (Expression::ResolvePrimary): Killed. I still want to improve
31718 this as currently the code is just not right.
31720 (Expression::ResolveMemberAccess): Simplify, but it is still
31723 (Unary::Resolve): Catch errors in AddressOf operators.
31725 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31726 index to a byte for the short-version, or the compiler will choose
31727 the wrong Emit call, which generates the wrong data.
31729 (ParameterReference::Emit, ::Store): same.
31731 (FieldExpr::AddressOf): Implement.
31733 * typemanager.cs: TypeManager: made public variable instead of
31736 * driver.cs: document --fatal.
31738 * report.cs (ErrorMessage, WarningMessage): new names for the old
31739 Error and Warning classes.
31741 * cs-parser.jay (member_access): Turn built-in access to types
31742 into a normal simplename
31744 2001-09-27 Ravi Pratap <ravi@ximian.com>
31746 * expression.cs (Invocation::BetterConversion): Fix to cope
31747 with q being null, since this was introducing a bug.
31749 * expression.cs (ConvertImplicit): Do built-in conversions first.
31751 2001-09-27 Ravi Pratap <ravi@ximian.com>
31753 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31755 2001-09-27 Ravi Pratap <ravi@ximian.com>
31757 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31758 I had introduced long ago (what's new ?).
31760 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31761 the work of all the checking.
31762 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31763 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31765 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31766 that is the right way.
31768 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31769 overloading resolution. Use everywhere instead of cutting and pasting code.
31771 (Binary::ResolveOperator): Use MakeUnionSet.
31773 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31774 we have to convert to bool types. Not complete yet.
31776 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31778 * typemanager.cs (TypeManager::CSharpName): support ushort.
31780 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31781 to provide an expression that performsn an implicit constant int
31782 conversion (section 6.1.6).
31783 (Expression::ConvertImplicitRequired): Reworked to include
31784 implicit constant expression conversions.
31786 (Expression::ConvertNumericExplicit): Finished.
31788 (Invocation::Emit): If InstanceExpression is null, then it means
31789 that we perform a call on this.
31791 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31793 * expression.cs (Unary::Emit): Remove some dead code.
31794 (Probe): Implement Resolve and Emit for `is'.
31795 (Expression::ConvertImplicitRequired): Attempt to do constant
31796 expression conversions here. Maybe should be moved to
31797 ConvertImplicit, but I am not sure.
31798 (Expression::ImplicitLongConstantConversionPossible,
31799 Expression::ImplicitIntConstantConversionPossible): New functions
31800 that tell whether is it possible to apply an implicit constant
31801 expression conversion.
31803 (ConvertNumericExplicit): Started work on explicit numeric
31806 * cs-parser.jay: Update operator constants.
31808 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
31809 (Parameters::GetSignature): Hook up VerifyArgs here.
31810 (Parameters::VerifyArgs): Verifies that no two arguments have the
31813 * class.cs (Operator): Update the operator names to reflect the
31814 ones that the spec expects (as we are just stringizing the
31817 * expression.cs (Unary::ResolveOperator): Fix bug: Use
31818 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
31819 previous usage did only work for our methods.
31820 (Expression::ConvertImplicit): Handle decimal implicit numeric
31821 conversions as well.
31822 (Expression::InternalTypeConstructor): Used to invoke constructors
31823 on internal types for default promotions.
31825 (Unary::Emit): Implement special handling for the pre/post
31826 increment/decrement for overloaded operators, as they need to have
31827 the same semantics as the other operators.
31829 (Binary::ResolveOperator): ditto.
31830 (Invocation::ConversionExists): ditto.
31831 (UserImplicitCast::Resolve): ditto.
31833 2001-09-26 Ravi Pratap <ravi@ximian.com>
31835 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
31836 operator, return after emitting body. Regression tests pass again !
31838 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
31839 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
31840 (Invocation::OverloadResolve): Ditto.
31841 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
31843 * everywhere : update calls to the above methods accordingly.
31845 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31847 * assign.cs (Assign): Make it inherit from ExpressionStatement.
31849 * expression.cs (ExpressionStatement): New base class used for
31850 expressions that can appear in statements, so that we can provide
31851 an alternate path to generate expression that do not leave a value
31854 (Expression::Emit, and all the derivatives): We no longer return
31855 whether a value is left on the stack or not. Every expression
31856 after being emitted leaves a single value on the stack.
31858 * codegen.cs (EmitContext::EmitStatementExpression): Use the
31859 facilties of ExpressionStatement if possible.
31861 * cs-parser.jay: Update statement_expression.
31863 2001-09-25 Miguel de Icaza <miguel@ximian.com>
31865 * driver.cs: Change the wording of message
31867 2001-09-25 Ravi Pratap <ravi@ximian.com>
31869 * expression.cs (Binary::ResolveOperator): Had forgottten to set
31870 the type of the expression to the return type of the method if
31871 we have an overloaded operator match ! The regression tests pass again !
31872 (Unary::ResolveOperator): Ditto.
31874 * expression.cs (Invocation::ConversionExists): Correct the member lookup
31875 to find "op_Implicit", not "implicit" ;-)
31876 (UserImplicitCast): New class to take care of user-defined implicit conversions.
31877 (ConvertImplicit, ForceConversion): Take TypeContainer argument
31879 * everywhere : Correct calls to the above accordingly.
31881 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
31882 (ConvertImplicit): Do user-defined conversion if it exists.
31884 2001-09-24 Miguel de Icaza <miguel@ximian.com>
31886 * assign.cs: track location.
31887 (Resolve): Use implicit conversions on assignment.
31889 * literal.cs: Oops. Not good, Emit of short access values should
31890 pass (Bytes) or the wrong argument will be selected.
31892 * expression.cs (Unary::Emit): Emit code for -expr.
31894 (Unary::ResolveOperator): Handle `Substract' for non-constants
31895 (substract from zero from the non-constants).
31896 Deal with Doubles as well.
31898 (Expression::ConvertImplicitRequired): New routine that reports an
31899 error if no implicit conversion exists.
31901 (Invocation::OverloadResolve): Store the converted implicit
31902 expressions if we make them
31904 2001-09-24 Ravi Pratap <ravi@ximian.com>
31906 * class.cs (ConstructorInitializer): Take a Location argument.
31907 (ConstructorBaseInitializer): Same here.
31908 (ConstructorThisInitializer): Same here.
31910 * cs-parser.jay : Update all calls accordingly.
31912 * expression.cs (Unary, Binary, New): Take location argument.
31913 Update accordingly everywhere.
31915 * cs-parser.jay : Update all calls to the above to take a location
31918 * class.cs : Ditto.
31920 2001-09-24 Ravi Pratap <ravi@ximian.com>
31922 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
31923 (Invocation::BetterConversion): Same here
31924 (Invocation::ConversionExists): Ditto.
31926 (Invocation::ConversionExists): Implement.
31928 2001-09-22 Ravi Pratap <ravi@ximian.com>
31930 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
31931 Also take an additional TypeContainer argument.
31933 * All over : Pass in TypeContainer as argument to OverloadResolve.
31935 * typemanager.cs (CSharpName): Update to check for the string type and return
31938 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
31941 2001-09-21 Ravi Pratap <ravi@ximian.com>
31943 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
31944 (Invocation::BetterFunction): Implement.
31945 (Invocation::BetterConversion): Implement.
31946 (Invocation::ConversionExists): Skeleton, no implementation yet.
31948 Okay, things work fine !
31950 2001-09-21 Miguel de Icaza <miguel@ximian.com>
31952 * typemanager.cs: declare and load enum_type, delegate_type and
31955 * expression.cs (Expression::Emit): Now emit returns a value that
31956 tells whether a value is left on the stack or not. This strategy
31957 might be reveted tomorrow with a mechanism that would address
31958 multiple assignments.
31959 (Expression::report118): Utility routine to report mismatches on
31962 (Unary::Report23): Report impossible type/operator combination
31965 (Unary::IsIncrementableNumber): Whether the type can be
31966 incremented or decremented with add.
31967 (Unary::ResolveOperator): Also allow enumerations to be bitwise
31969 (Unary::ResolveOperator): Implement ++, !, ~,
31971 (Invocation::Emit): Deal with new Emit convetion.
31973 * All Expression derivatives: Updated their Emit method to return
31974 whether they leave values on the stack or not.
31976 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
31977 stack for expressions that are statements.
31979 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31981 * expression.cs (LValue): New interface. Must be implemented by
31983 (LocalVariableReference, ParameterReference, FieldExpr): Implement
31986 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
31987 interface for generating code, simplifies the code.
31989 2001-09-20 Ravi Pratap <ravi@ximian.com>
31991 * expression.cs (everywhere): Comment out return statements in ::Resolve
31992 methods to avoid the warnings.
31994 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31996 * driver.cs (parse): Report error 2001 if we can not open the
31999 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32002 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32005 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32006 otherwise nested blocks end up with the same index.
32008 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32010 * expression.cs: Instead of having FIXMEs in the Resolve
32011 functions, throw exceptions so it is obvious that we are facing a
32014 * cs-parser.jay (invocation_expression): Pass Location information.
32016 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32017 Use a basename for those routines because .NET does not like paths
32020 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32023 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32025 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32026 are loading the correct data types (throws an exception if not).
32027 (TypeManager::InitCoreTypes): Use CoreLookupType
32029 * expression.cs (Unary::ResolveOperator): return the child
32030 expression for expressions which are just +expr.
32031 (Unary::ResolveOperator): Return negative literals for -LITERAL
32032 expressions (otherwise they are Unary {Literal}).
32033 (Invocation::Badness): Take into account `Implicit constant
32034 expression conversions'.
32036 * literal.cs (LongLiteral): Implement long literal class.
32037 (IntLiteral): export the `Value' of the intliteral.
32039 2001-09-19 Ravi Pratap <ravi@ximian.com>
32041 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32043 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32044 instead of 'Operator'
32046 * expression.cs (Binary::ResolveOperator): Update accordingly.
32047 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32050 * cs-parser.jay (unary_expression): Update to use the new names.
32052 * gen-treedump.cs (GetUnary): Same here.
32054 * expression.cs (Unary::Resolve): Implement.
32055 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32056 operators are found instead of making noise ;-)
32057 (Unary::ResolveOperator): New method to do precisely the same thing which
32058 Binary::ResolveOperator does for Binary expressions.
32059 (Unary.method, .Arguments): Add.
32060 (Unary::OperName): Implement.
32061 (Unary::ForceConversion): Copy and Paste !
32063 * class.cs (Operator::Define): Fix a small bug for the case when we have
32066 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32067 for the inbuilt operators. Only overloading works for now ;-)
32069 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32071 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32072 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32074 * expression.cs (This::Emit): Implement.
32075 (This::Resolve): Implement.
32076 (TypeOf:Resolve): Implement.
32077 (Expression::ResolveSimpleName): Add an implicit this to instance
32079 (MemberAccess::Resolve): Deal with Parameters and Fields.
32080 Bind instance variable to Field expressions.
32081 (FieldExpr::Instance): New field used to track the expression that
32082 represents the object instance.
32083 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32085 (FieldExpr::Emit): Implement.
32087 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32088 the last instruction contains a return opcode to avoid generating
32089 the last `ret' instruction (this generates correct code, and it is
32090 nice to pass the peverify output).
32092 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32093 initializer for static and instance variables.
32094 (Constructor::Emit): Allow initializer to be null in the case of
32095 static constructors. Only emit initializer for instance
32098 (TypeContainer::FindMembers): Return a null array if there are no
32101 Also fix the code for the MemberTypes.Method branch, as it was not
32102 scanning that for operators (or tried to access null variables before).
32104 * assign.cs (Assign::Emit): Handle instance and static fields.
32108 * driver.cs: Stop compilation if there are parse errors.
32110 * cs-parser.jay (constructor_declaration): Provide default base
32111 initializer for non-static constructors.
32112 (constructor_declarator): Do not provide a default base
32113 initializers if none was specified.
32114 Catch the fact that constructors should not have parameters.
32116 * class.cs: Do not emit parent class initializers for static
32117 constructors, that should be flagged as an error.
32119 2001-09-18 Ravi Pratap <ravi@ximian.com>
32121 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32122 Move back code into TypeContainer::Populate.
32124 2001-09-18 Ravi Pratap <ravi@ximian.com>
32126 * class.cs (TypeContainer::AddConstructor): Fix the check to
32127 compare against Name, not Basename.
32128 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32130 * cs-parser.jay : Update accordingly.
32132 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32133 for methods, don't forget to look into the operators too.
32134 (RegisterMethodBuilder): Helper method to take care of this for
32135 methods, constructors and operators.
32136 (Operator::Define): Completely revamp.
32137 (Operator.OperatorMethod, MethodName): New fields.
32138 (TypeContainer::Populate): Move the registering of builders into
32139 RegisterMethodBuilder.
32140 (Operator::Emit): Re-write.
32142 * expression.cs (Binary::Emit): Comment out code path to emit method
32143 invocation stuff for the case when we have a user defined operator. I am
32144 just not able to get it right !
32146 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32148 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32151 (Expression::MemberLookup): Provide a version that allows to
32152 specify the MemberTypes and BindingFlags.
32154 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32155 so it was not fetching variable information from outer blocks.
32157 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32158 Beforefieldinit as it was buggy.
32160 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32161 that Ravi put here.
32163 * class.cs (Constructor::Emit): Only emit if block is not null.
32164 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32165 deal with this by semantically definining it as if the user had
32168 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32169 constructors as we now "emit" them at a higher level.
32171 (TypeContainer::DefineDefaultConstructor): Used to define the
32172 default constructors if none was provided.
32174 (ConstructorInitializer): Add methods Resolve and Emit.
32176 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32178 2001-09-17 Ravi Pratap <ravi@ximian.com>
32180 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32181 the default constructor builder with our hashtable for methodbuilders
32184 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32185 and argument_count is 0 in which case we have a match.
32186 (Binary::ResolveOperator): More null checking and miscellaneous coding
32189 2001-09-17 Ravi Pratap <ravi@ximian.com>
32191 * rootcontext.cs (IsNameSpace): Compare against null.
32193 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32195 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32196 and Unary::Operator.
32198 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32201 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32202 we have overloaded operators.
32203 (Binary::ResolveOperator): Implement the part which does the operator overload
32206 * class.cs (Operator::Emit): Implement.
32207 (TypeContainer::Emit): Emit the operators we have too.
32209 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32210 the case when we have a user-defined operator.
32212 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32214 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32216 2001-09-16 Ravi Pratap <ravi@ximian.com>
32218 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32219 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32220 (Constructor::Emit): Implement.
32221 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32222 if we have no work to do.
32223 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32226 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32227 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32229 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32232 2001-09-15 Ravi Pratap <ravi@ximian.com>
32234 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32236 (Tree::RecordNamespace): Method to do what the name says ;-)
32237 (Tree::Namespaces): Property to get at the namespaces hashtable.
32239 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32242 * rootcontext.cs (IsNamespace): Fixed it :-)
32244 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32246 * class.cs (TypeContainer::FindMembers): Add support for
32248 (MethodCore): New class that encapsulates both the shared aspects
32249 of a Constructor and a Method.
32250 (Method, Constructor): Factored pieces into MethodCore.
32252 * driver.cs: Added --fatal which makes errors throw exceptions.
32253 Load System assembly as well as part of the standard library.
32255 * report.cs: Allow throwing exceptions on errors for debugging.
32257 * modifiers.cs: Do not use `parent', instead use the real type
32258 container to evaluate permission settings.
32260 * class.cs: Put Ravi's patch back in. He is right, and we will
32261 have to cope with the
32263 2001-09-14 Ravi Pratap <ravi@ximian.com>
32265 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32266 FamORAssem, not FamANDAssem.
32268 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32270 * driver.cs: Added --parse option that only parses its input files
32273 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32274 incorrect. IsTopLevel is not used to tell whether an object is
32275 root_types or not (that can be achieved by testing this ==
32276 root_types). But to see if this is a top-level *class* (not
32277 necessarly our "toplevel" container).
32279 2001-09-14 Ravi Pratap <ravi@ximian.com>
32281 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32282 parent instead of a direct call to GetType.
32284 2001-09-14 Ravi Pratap <ravi@ximian.com>
32286 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32287 Modifiers.TypeAttr. This should just be a call to that method.
32289 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32290 object so that we can determine if we are top-level or not.
32292 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32295 * enum.cs (Enum::Define): Ditto.
32297 * modifiers.cs (FieldAttr): Re-write.
32299 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32300 (TypeContainer::HaveStaticConstructor): New property to provide access
32301 to precisely that info.
32303 * modifiers.cs (MethodAttr): Re-write.
32304 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32306 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32307 of top-level types as claimed.
32309 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32311 * expression.cs (MemberLookup): Fruitless attempt to lookup
32312 constructors. Maybe I need to emit default constructors? That
32313 might be it (currently .NET emits this for me automatically).
32314 (Invocation::OverloadResolve): Cope with Arguments == null.
32315 (Invocation::EmitArguments): new function, shared by the new
32316 constructor and us.
32317 (Invocation::Emit): Handle static and instance methods. Emit
32318 proper call instruction for virtual or non-virtual invocations.
32319 (New::Emit): Implement.
32320 (New::Resolve): Implement.
32321 (MemberAccess:Resolve): Implement.
32322 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32323 to track instances.
32324 (FieldExpr::Resolve): Set type.
32326 * support.cs: Handle empty arguments.
32328 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32329 SimpleLookup): Auxiliary routines to help parse a qualifier
32332 Update qualifier_identifier rule.
32334 * codegen.cs: Removed debugging messages.
32336 * class.cs: Make this a global thing, this acts just as a "key" to
32337 objects that we might have around.
32339 (Populate): Only initialize method_builders_to_methods once.
32341 * expression.cs (PropertyExpr): Initialize type from the
32344 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32345 Resolve pattern. Attempt to implicitly convert value to boolean.
32348 * expression.cs: Set the type for the int32/int32 argument case.
32349 (Binary::ResolveOperator): Set the return type to boolean for
32350 comparission operators
32352 * typemanager.cs: Remove debugging print code.
32354 (Invocation::Resolve): resolve type.
32356 * class.cs: Allocate a MemberInfo of the correct size, as the code
32357 elsewhere depends on the test to reflect the correct contents.
32359 (Method::) Keep track of parameters, due to System.Reflection holes
32361 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32364 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32365 of the exact size and return that.
32367 (Class::LookupMethodByBuilder): New function that maps
32368 MethodBuilders to its methods. Required to locate the information
32369 on methods because System.Reflection bit us again.
32371 * support.cs: New file, contains an interface ParameterData and
32372 two implementations: ReflectionParameters and InternalParameters
32373 used to access Parameter information. We will need to grow this
32376 * expression.cs (Invocation::GetParameterData): implement a cache
32377 and a wrapper around the ParameterData creation for methods.
32378 (Invocation::OverloadResolve): Use new code.
32380 2001-09-13 Ravi Pratap <ravi@ximian.com>
32382 * class.cs (TypeContainer::EmitField): Remove and move into
32383 (Field::Define): here and modify accordingly.
32384 (Field.FieldBuilder): New member.
32385 (TypeContainer::Populate): Update accordingly.
32386 (TypeContainer::FindMembers): Implement.
32388 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32390 * statement.cs: (VariableInfo::VariableType): New field to be
32391 initialized with the full type once it is resolved.
32393 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32395 * parameter.cs (GetParameterInfo): Use a type cache to compute
32396 things only once, and to reuse this information
32398 * expression.cs (LocalVariableReference::Emit): Implement.
32399 (OpcodeCast::Emit): fix.
32401 (ParameterReference::Resolve): Implement.
32402 (ParameterReference::Emit): Implement.
32404 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32405 that are expressions need to stay as Expressions.
32407 * typemanager.cs (CSharpName): Returns the C# name of a type if
32410 * expression.cs (Expression::ConvertImplicit): New function that
32411 implements implicit type conversions.
32413 (Expression::ImplicitReferenceConversion): Implements implicit
32414 reference conversions.
32416 (EmptyCast): New type for transparent casts.
32418 (OpcodeCast): New type for casts of types that are performed with
32419 a sequence of bytecodes.
32421 (BoxedCast): New type used for casting value types into reference
32422 types. Emits a box opcode.
32424 (Binary::DoNumericPromotions): Implements numeric promotions of
32425 and computation of the Binary::Type.
32427 (Binary::EmitBranchable): Optimization.
32429 (Binary::Emit): Implement code emission for expressions.
32431 * typemanager.cs (TypeManager): Added two new core types: sbyte
32434 2001-09-12 Ravi Pratap <ravi@ximian.com>
32436 * class.cs (TypeContainer::FindMembers): Method which does exactly
32437 what Type.FindMembers does, only we don't have to use reflection. No
32438 implementation yet.
32440 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32441 typecontainer objects as we need to get at them.
32442 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32444 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32445 typecontainer object.
32447 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32448 of just a Report object.
32450 2001-09-11 Ravi Pratap <ravi@ximian.com>
32452 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32454 (TypeContainer::Populate): Now define the delegates of the type too.
32455 (TypeContainer.Delegates): Property to access the list of delegates defined
32458 * delegates.cs (Delegate::Define): Implement partially.
32460 * modifiers.cs (TypeAttr): Handle more flags.
32462 2001-09-11 Ravi Pratap <ravi@ximian.com>
32464 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32466 (Operator::Define): Re-write logic to get types by using the LookupType method
32467 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32468 (Indexer::Define): Ditto.
32469 (Event::Define): Ditto.
32470 (Property::Define): Ditto.
32472 2001-09-10 Ravi Pratap <ravi@ximian.com>
32474 * class.cs (TypeContainer::Populate): Now define operators too.
32475 (TypeContainer.Operators): New property to access the list of operators
32477 (Operator.OperatorMethodBuilder): New member to hold the method builder
32478 for the operator we are defining.
32479 (Operator::Define): Implement.
32481 2001-09-10 Ravi Pratap <ravi@ximian.com>
32483 * class.cs (Event::Define): Make the prefixes of the accessor methods
32484 addOn_ and removeOn_
32486 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32487 of the location being passed in too. Ideally, this should go later since all
32488 error reporting should be done through the Report object.
32490 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32491 (Populate): Iterate thru the indexers we have and define them too.
32492 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32493 for the get and set accessors.
32494 (Indexer::Define): Implement.
32496 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32498 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32499 my previous implementation, did not work.
32501 * typemanager.cs: Add a couple of missing types (the longs).
32503 * literal.cs: Use TypeManager.bool_type instead of getting it.
32505 * expression.cs (EventExpr): New kind of expressions.
32506 (Expressio::ExprClassFromMemberInfo): finish
32508 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32510 * assign.cs: Emit stores to static fields differently.
32512 2001-09-08 Ravi Pratap <ravi@ximian.com>
32514 * Merge in changes and adjust code to tackle conflicts. Backed out my
32515 code in Assign::Resolve ;-)
32517 2001-09-08 Ravi Pratap <ravi@ximian.com>
32519 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32520 instead Report.Error and also pass in the location.
32521 (CSharpParser::Lexer): New readonly property to return the reference
32522 to the Tokenizer object.
32523 (declare_local_variables): Use Report.Error with location instead of plain
32527 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32528 (Operator.CheckBinaryOperator): Ditto.
32530 * cs-parser.jay (operator_declarator): Update accordingly.
32532 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32533 (CheckBinaryOperator): Same here.
32535 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32536 on the name without any prefixes of namespace names etc. This is because we
32537 already might have something already fully qualified like
32538 'System.Console.WriteLine'
32540 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32542 2001-09-07 Ravi Pratap <ravi@ximian.com>
32544 * cs-tokenizer.cs (location): Return a string which also contains
32547 * expression.cs (ElementAccess): New class for expressions of the
32548 type 'element access.'
32549 (BaseAccess): New class for expressions of the type 'base access.'
32550 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32553 * cs-parser.jay (element_access): Implement action.
32554 (base_access): Implement actions.
32555 (checked_expression, unchecked_expression): Implement.
32557 * cs-parser.jay (local_variable_type): Correct and implement.
32558 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32560 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32562 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32563 name and the specifiers.
32565 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32567 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32568 making them all public ;-)
32570 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32573 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32575 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32577 (FieldExpr, PropertyExprs): New resolved expressions.
32578 (SimpleName::MemberStaticCheck): Perform static checks for access
32579 to non-static fields on static methods. Maybe this should be
32580 generalized for MemberAccesses.
32581 (SimpleName::ResolveSimpleName): More work on simple name
32584 * cs-parser.jay (primary_expression/qualified_identifier): track
32585 the parameter index.
32587 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32588 (EmitContext::EmitBoolExpression): Chain to expression generation
32589 instead of temporary hack.
32590 (::EmitStatementExpression): Put generic expression code generation.
32592 * assign.cs (Assign::Emit): Implement variable assignments to
32593 local variables, parameters and fields.
32595 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32597 * statement.cs (Block::GetVariableInfo): New method, returns the
32598 VariableInfo for a variable name in a block.
32599 (Block::GetVariableType): Implement in terms of GetVariableInfo
32601 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32602 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32604 2001-09-06 Ravi Pratap <ravi@ximian.com>
32606 * cs-parser.jay (operator_declaration): Continue on my quest : update
32607 to take attributes argument.
32608 (event_declaration): Ditto.
32609 (enum_declaration): Ditto.
32610 (indexer_declaration): Ditto.
32612 * class.cs (Operator::Operator): Update constructor accordingly.
32613 (Event::Event): Ditto.
32615 * delegate.cs (Delegate::Delegate): Same here.
32617 * enum.cs (Enum::Enum): Same here.
32619 2001-09-05 Ravi Pratap <ravi@ximian.com>
32621 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32623 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32625 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32626 being passed around as an arraylist.
32627 (Attributes::AddAttribute): Method to add attribute sections.
32629 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32630 (struct_declaration): Update accordingly.
32631 (constant_declaration): Update.
32632 (field_declaration): Update.
32633 (method_header): Update.
32634 (fixed_parameter): Update.
32635 (parameter_array): Ditto.
32636 (property_declaration): Ditto.
32637 (destructor_declaration): Ditto.
32639 * class.cs (Struct::Struct): Update constructors accordingly.
32640 (Class::Class): Ditto.
32641 (Field::Field): Ditto.
32642 (Method::Method): Ditto.
32643 (Property::Property): Ditto.
32644 (TypeContainer::OptAttribute): update property's return type.
32646 * interface.cs (Interface.opt_attributes): New member.
32647 (Interface::Interface): Update to take the extra Attributes argument.
32649 * parameter.cs (Parameter::Parameter): Ditto.
32651 * constant.cs (Constant::Constant): Ditto.
32653 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32654 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32655 the attributes as a parameter.
32656 (InterfaceProperty): Update constructor call.
32657 (InterfaceEvent): Ditto.
32658 (InterfaceMethod): Ditto.
32659 (InterfaceIndexer): Ditto.
32661 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32662 pass the attributes too.
32663 (interface_event_declaration): Ditto.
32664 (interface_property_declaration): Ditto.
32665 (interface_method_declaration): Ditto.
32666 (interface_declaration): Ditto.
32668 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32670 * class.cs (Method::Define): Track the "static Main" definition to
32671 create an entry point.
32673 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32674 EntryPoint if we find it.
32676 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32677 (EmitContext::ig): Make this variable public.
32679 * driver.cs: Make the default output file be the first file name
32680 with the .exe extension.
32682 Detect empty compilations
32684 Handle various kinds of output targets. Handle --target and
32685 rename -t to --dumper.
32687 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32688 methods inherited from Expression return now an Expression. This
32689 will is used during the tree rewriting as we resolve them during
32692 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32693 the spec. Missing entirely is the information about
32694 accessability of elements of it.
32696 (Expression::ExprClassFromMemberInfo): New constructor for
32697 Expressions that creates a fully initialized Expression based on
32698 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32701 (Invocation::Resolve): Begin implementing resolution of invocations.
32703 * literal.cs (StringLiteral): Implement Emit.
32705 2001-09-05 Ravi Pratap <ravi@ximian.com>
32707 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32710 2001-09-04 Ravi Pratap <ravi@ximian.com>
32712 * cs-parser.jay (attribute_arguments): Implement actions.
32713 (attribute): Fix bug in production. Implement action.
32714 (attribute_list): Implement.
32715 (attribute_target): Implement.
32716 (attribute_target_specifier, opt_target_specifier): Implement
32717 (CheckAttributeTarget): New method to check if the attribute target
32719 (attribute_section): Implement.
32720 (opt_attributes): Implement.
32722 * attribute.cs : New file to handle attributes.
32723 (Attribute): Class to hold attribute info.
32725 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32726 (attribute_section): Modify production to use 2 different rules to
32727 achieve the same thing. 1 s/r conflict down !
32728 Clean out commented, useless, non-reducing dimension_separator rules.
32730 * class.cs (TypeContainer.attributes): New member to hold list
32731 of attributes for a type.
32732 (Struct::Struct): Modify to take one more argument, the attribute list.
32733 (Class::Class): Ditto.
32734 (Field::Field): Ditto.
32735 (Method::Method): Ditto.
32736 (Property::Property): Ditto.
32738 * cs-parser.jay (struct_declaration): Update constructor call to
32739 pass in the attributes too.
32740 (class_declaration): Ditto.
32741 (constant_declaration): Ditto.
32742 (field_declaration): Ditto.
32743 (method_header): Ditto.
32744 (fixed_parameter): Ditto.
32745 (parameter_array): Ditto.
32746 (property_declaration): Ditto.
32748 * constant.cs (Constant::Constant): Update constructor similarly.
32749 Use System.Collections.
32751 * parameter.cs (Parameter::Parameter): Update as above.
32753 2001-09-02 Ravi Pratap <ravi@ximian.com>
32755 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32756 (TypeContainer.delegates): New member to hold list of delegates.
32758 * cs-parser.jay (delegate_declaration): Implement the action correctly
32759 this time as I seem to be on crack ;-)
32761 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32763 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32764 tell whether an identifier represents a namespace.
32766 * expression.cs (NamespaceExpr): A namespace expression, used only
32767 temporarly during expression resolution.
32768 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32769 utility functions to resolve names on expressions.
32771 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32773 * codegen.cs: Add hook for StatementExpressions.
32775 * class.cs: Fix inverted test for static flag in methods.
32777 2001-09-02 Ravi Pratap <ravi@ximian.com>
32779 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32780 to make it coincide with MS' number.
32781 (Operator::CheckBinaryOperator): Ditto.
32783 * ../errors/errors.txt : Remove error numbers added earlier.
32785 * ../errors/cs1019.cs : Test case for error # 1019
32787 * ../errros/cs1020.cs : Test case for error # 1020
32789 * cs-parser.jay : Clean out commented cruft.
32790 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32791 used anywhere - non-reducing rule.
32792 (namespace_declarations): Non-reducing rule - comment out.
32794 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32795 with TypeContainer::AddEnum.
32797 * delegate.cs : New file for delegate handling classes.
32798 (Delegate): Class for declaring delegates.
32800 * makefile : Update.
32802 * cs-parser.jay (delegate_declaration): Implement.
32804 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
32806 * class.cs (Event::Define): Implement.
32807 (Event.EventBuilder): New member.
32809 * class.cs (TypeContainer::Populate): Update to define all enums and events
32811 (Events): New property for the events arraylist we hold. Shouldn't we move to using
32812 readonly fields for all these cases ?
32814 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32816 * class.cs (Property): Revamp to use the convention of making fields readonly.
32817 Accordingly modify code elsewhere.
32819 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
32820 the Define method of the Property class.
32822 * class.cs : Clean up applied patch and update references to variables etc. Fix
32824 (TypeContainer::Populate): Update to define all the properties we have. Also
32825 define all enumerations.
32827 * enum.cs (Define): Implement.
32829 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32831 * cs-parser.jay (overloadable_operator): The semantic value is an
32832 enum of the Operator class.
32833 (operator_declarator): Implement actions.
32834 (operator_declaration): Implement.
32836 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
32837 validity of definitions.
32838 (Operator::CheckBinaryOperator): Static method to check for binary operators
32839 (TypeContainer::AddOperator): New method to add an operator to a type.
32841 * cs-parser.jay (indexer_declaration): Added line to actually call the
32842 AddIndexer method so it gets added ;-)
32844 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
32845 already taken care of by the MS compiler ?
32847 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32849 * class.cs (Operator): New class for operator declarations.
32850 (Operator::OpType): Enum for the various operators.
32852 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32854 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
32855 ostensibly handle this in semantic analysis.
32857 * cs-parser.jay (general_catch_clause): Comment out
32858 (specific_catch_clauses, specific_catch_clause): Ditto.
32859 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
32860 (catch_args, opt_catch_args): New productions.
32861 (catch_clause): Rewrite to use the new productions above
32862 (catch_clauses): Modify accordingly.
32863 (opt_catch_clauses): New production to use in try_statement
32864 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
32865 and re-write the code in the actions to extract the specific and
32866 general catch clauses by being a little smart ;-)
32868 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
32869 Hooray, try and catch statements parse fine !
32871 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32873 * statement.cs (Block::GetVariableType): Fix logic to extract the type
32874 string from the hashtable of variables.
32876 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
32877 I end up making that mistake ;-)
32878 (catch_clauses): Fixed gross error which made Key and Value of the
32879 DictionaryEntry the same : $1 !!
32881 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32883 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
32885 * cs-parser.jay (event_declaration): Correct to remove the semicolon
32886 when the add and remove accessors are specified.
32888 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32890 * cs-parser.jay (IndexerDeclaration): New helper class to hold
32891 information about indexer_declarator.
32892 (indexer_declarator): Implement actions.
32893 (parsing_indexer): New local boolean used to keep track of whether
32894 we are parsing indexers or properties. This is necessary because
32895 implicit_parameters come into picture even for the get accessor in the
32896 case of an indexer.
32897 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
32899 * class.cs (Indexer): New class for indexer declarations.
32900 (TypeContainer::AddIndexer): New method to add an indexer to a type.
32901 (TypeContainer::indexers): New member to hold list of indexers for the
32904 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32906 * cs-parser.jay (add_accessor_declaration): Implement action.
32907 (remove_accessor_declaration): Implement action.
32908 (event_accessors_declaration): Implement
32909 (variable_declarators): swap statements for first rule - trivial.
32911 * class.cs (Event): New class to hold information about event
32913 (TypeContainer::AddEvent): New method to add an event to a type
32914 (TypeContainer::events): New member to hold list of events.
32916 * cs-parser.jay (event_declaration): Implement actions.
32918 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32920 * cs-parser.jay (dim_separators): Implement. Make it a string
32921 concatenating all the commas together, just as they appear.
32922 (opt_dim_separators): Modify accordingly
32923 (rank_specifiers): Update accordingly. Basically do the same
32924 thing - instead, collect the brackets here.
32925 (opt_rank_sepcifiers): Modify accordingly.
32926 (array_type): Modify to actually return the complete type string
32927 instead of ignoring the rank_specifiers.
32928 (expression_list): Implement to collect the expressions
32929 (variable_initializer): Implement. We make it a list of expressions
32930 essentially so that we can handle the array_initializer case neatly too.
32931 (variable_initializer_list): Implement.
32932 (array_initializer): Make it a list of variable_initializers
32933 (opt_array_initializer): Modify accordingly.
32935 * expression.cs (New::NType): Add enumeration to help us
32936 keep track of whether we have an object/delegate creation
32937 or an array creation.
32938 (New:NewType, New::Rank, New::Indices, New::Initializers): New
32939 members to hold data about array creation.
32940 (New:New): Modify to update NewType
32941 (New:New): New Overloaded contructor for the array creation
32944 * cs-parser.jay (array_creation_expression): Implement to call
32945 the overloaded New constructor.
32947 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
32949 * class.cs (TypeContainer::Constructors): Return member
32950 constructors instead of returning null.
32952 2001-08-26 Miguel de Icaza <miguel@ximian.com>
32954 * typemanager.cs (InitCoreTypes): Initialize the various core
32955 types after we have populated the type manager with the user
32956 defined types (this distinction will be important later while
32957 compiling corlib.dll)
32959 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
32960 on Expression Classification. Now all expressions have a method
32961 `Resolve' and a method `Emit'.
32963 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
32964 generation from working. Also add some temporary debugging
32967 2001-08-24 Miguel de Icaza <miguel@ximian.com>
32969 * codegen.cs: Lots of code generation pieces. This is only the
32970 beginning, will continue tomorrow with more touches of polish. We
32971 handle the fundamentals of if, while, do, for, return. Others are
32972 trickier and I need to start working on invocations soon.
32974 * gen-treedump.cs: Bug fix, use s.Increment here instead of
32977 * codegen.cs (EmitContext): New struct, used during code
32978 emission to keep a context. Most of the code generation will be
32981 * cs-parser.jay: Add embedded blocks to the list of statements of
32982 this block. So code generation proceeds in a top down fashion.
32984 2001-08-23 Miguel de Icaza <miguel@ximian.com>
32986 * statement.cs: Add support for multiple child blocks.
32988 2001-08-22 Miguel de Icaza <miguel@ximian.com>
32990 * codegen.cs (EmitCode): New function, will emit the code for a
32991 Block of code given a TypeContainer and its ILGenerator.
32993 * statement.cs (Block): Standard public readonly optimization.
32994 (Block::Block constructors): Link children.
32995 (Block::Child): Child Linker.
32996 (Block::EmitVariables): Emits IL variable declarations.
32998 * class.cs: Drop support for MethodGroups here, delay until
33000 (Method::): Applied the same simplification that I did before, and
33001 move from Properties to public readonly fields.
33002 (Method::ParameterTypes): Returns the parameter types for the
33003 function, and implements a cache that will be useful later when I
33004 do error checking and the semantic analysis on the methods is
33006 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33007 and made a method, optional argument tells whether this is a class
33008 or a structure to apply the `has-this' bit.
33009 (Method::GetCallingConvention): Implement, returns the calling
33011 (Method::Define): Defines the type, a second pass is performed
33012 later to populate the methods.
33014 (Constructor::ParameterTypes): implement a cache similar to the
33015 one on Method::ParameterTypes, useful later when we do semantic
33018 (TypeContainer::EmitMethod): New method. Emits methods.
33020 * expression.cs: Removed MethodGroup class from here.
33022 * parameter.cs (Parameters::GetCallingConvention): new method.
33024 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33026 * class.cs (TypeContainer::Populate): Drop RootContext from the
33029 (Constructor::CallingConvention): Returns the calling convention.
33030 (Constructor::ParameterTypes): Returns the constructor parameter
33033 (TypeContainer::AddConstructor): Keep track of default constructor
33034 and the default static constructor.
33036 (Constructor::) Another class that starts using `public readonly'
33037 instead of properties.
33039 (Constructor::IsDefault): Whether this is a default constructor.
33041 (Field::) use readonly public fields instead of properties also.
33043 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33044 track of static constructors; If none is used, turn on
33045 BeforeFieldInit in the TypeAttributes.
33047 * cs-parser.jay (opt_argument_list): now the return can be null
33048 for the cases where there are no arguments.
33050 (constructor_declarator): If there is no implicit `base' or
33051 `this', then invoke the default parent constructor.
33053 * modifiers.cs (MethodAttr): New static function maps a set of
33054 modifiers flags into a MethodAttributes enum
33055 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33056 MethodAttr, TypeAttr to represent the various mappings where the
33057 modifiers are used.
33058 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33060 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33062 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33065 * interface.cs (PopulateIndexer): Implemented the code generator
33066 for interface indexers.
33068 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33070 * interface.cs (InterfaceMemberBase): Now we track the new status
33073 (PopulateProperty): Implement property population. Woohoo! Got
33074 Methods and Properties going today.
33076 Removed all the properties for interfaces, and replaced them with
33077 `public readonly' fields.
33079 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33081 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33082 initialize their hashtables/arraylists only when they are needed
33083 instead of doing this always.
33085 * parameter.cs: Handle refs and out parameters.
33087 * cs-parser.jay: Use an ArrayList to construct the arguments
33088 instead of the ParameterCollection, and then cast that to a
33091 * parameter.cs: Drop the use of ParameterCollection and use
33092 instead arrays of Parameters.
33094 (GetParameterInfo): Use the Type, not the Name when resolving
33097 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33099 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33100 and instead use public readonly fields.
33102 * class.cs: Put back walking code for type containers.
33104 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33106 * class.cs (MakeConstant): Code to define constants.
33108 * rootcontext.cs (LookupType): New function. Used to locate types
33111 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33113 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33114 this System.Reflection code is. Kudos to Microsoft
33116 * typemanager.cs: Implement a type cache and avoid loading all
33117 types at boot time. Wrap in LookupType the internals. This made
33118 the compiler so much faster. Wow. I rule!
33120 * driver.cs: Make sure we always load mscorlib first (for
33121 debugging purposes, nothing really important).
33123 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33124 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33126 * rootcontext.cs: Lookup types on their namespace; Lookup types
33127 on namespaces that have been imported using the `using' keyword.
33129 * class.cs (TypeContainer::TypeAttr): Virtualize.
33130 (Class::TypeAttr): Return attributes suitable for this bad boy.
33131 (Struct::TypeAttr): ditto.
33132 Handle nested classes.
33133 (TypeContainer::) Remove all the type visiting code, it is now
33134 replaced with the rootcontext.cs code
33136 * rootcontext.cs (GetClassBases): Added support for structs.
33138 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33140 * interface.cs, statement.cs, class.cs, parameter.cs,
33141 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33142 Drop use of TypeRefs, and use strings instead.
33144 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33148 * class.cs (Struct::Struct): set the SEALED flags after
33149 checking the modifiers.
33150 (TypeContainer::TypeAttr): new property, returns the
33151 TypeAttributes for a class.
33153 * cs-parser.jay (type_list): Oops, list production was creating a
33154 new list of base types.
33156 * rootcontext.cs (StdLib): New property.
33157 (GetInterfaceTypeByName): returns an interface by type name, and
33158 encapsulates error handling here.
33159 (GetInterfaces): simplified.
33160 (ResolveTree): Encapsulated all the tree resolution here.
33161 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33164 * driver.cs: Add support for --nostdlib, to avoid loading the
33165 default assemblies.
33166 (Main): Do not put tree resolution here.
33168 * rootcontext.cs: Beginning of the class resolution.
33170 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33172 * rootcontext.cs: Provide better error reporting.
33174 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33176 * rootcontext.cs (CreateInterface): Handle the case where there
33177 are no parent interfaces.
33179 (CloseTypes): Routine to flush types at the end.
33180 (CreateInterface): Track types.
33181 (GetInterfaces): Returns an array of Types from the list of
33182 defined interfaces.
33184 * typemanager.c (AddUserType): Mechanism to track user types (puts
33185 the type on the global type hash, and allows us to close it at the
33188 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33190 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33191 RecordInterface instead.
33193 * cs-parser.jay: Updated to reflect changes above.
33195 * decl.cs (Definition): Keep track of the TypeBuilder type that
33196 represents this type here. Not sure we will use it in the long
33197 run, but wont hurt for now.
33199 * driver.cs: Smaller changes to accomodate the new code.
33201 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33204 * rootcontext.cs (CreateInterface): New method, used to create
33205 the System.TypeBuilder type for interfaces.
33206 (ResolveInterfaces): new entry point to resolve the interface
33208 (CodeGen): Property, used to keep track of the code generator.
33210 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33212 * cs-parser.jay: Add a second production for delegate_declaration
33215 (enum_body): Put an opt_comma here instead of putting it on
33216 enum_body or enum_member_declarations so we can handle trailing
33217 commas on enumeration members. Gets rid of a shift/reduce.
33219 (type_list): Need a COMMA in the middle.
33221 (indexer_declaration): Tell tokenizer to recognize get/set
33223 * Remove old targets.
33225 * Re-add the parser target.
33227 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33229 * cs-parser.jay: Add precendence rules for a number of operators
33230 ot reduce the number of shift/reduce conflicts in the grammar.
33232 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33234 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33237 Get rid of old crufty code.
33239 * rootcontext.cs: Use this to keep track of the parsed
33240 representation and the defined types available to the program.
33242 * gen-treedump.cs: adjust for new convention.
33244 * type.cs: Split out the type manager, and the assembly builder
33247 * typemanager.cs: the type manager will live here now.
33249 * cil-codegen.cs: And the code generator here.
33251 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33253 * makefile: Fixed up for easy making.
33255 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33257 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33260 (unary_expression): Expand pre_increment_expression and
33261 post_decrement_expression to reduce a shift/reduce.
33263 2001-07-11 Simon Cozens
33265 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33267 Improve allow_keyword_as_indent name.
33269 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33271 * Adjustments for Beta2.
33273 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33275 * decl.cs: Added `Define' abstract method.
33276 (InTransit): new property, used to catch recursive definitions.
33278 * interface.cs: Implement `Define'.
33280 * modifiers.cs: Map Modifiers.constants to
33281 System.Reflection.TypeAttribute flags.
33283 * class.cs: Keep track of types and user-defined types.
33284 (BuilderInit): New method for creating an assembly
33285 (ResolveType): New function to launch the resolution process, only
33286 used by interfaces for now.
33288 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33289 that are inserted into the name space.
33291 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33293 * ARGH. I have screwed up my tree so many times due to the use of
33294 rsync rather than using CVS. Going to fix this at once.
33296 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33299 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33301 * Experiment successful: Use System.Type rather that our own
33304 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33306 * cs-parser.jay: Removed nsAliases from here.
33308 Use new namespaces, handle `using XXX;'
33310 * namespace.cs: Reimplemented namespace handling, use a recursive
33311 definition of the class. Now we can keep track of using clauses
33312 and catch invalid using clauses.
33314 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33316 * gen-treedump.cs: Adapted for all the renaming.
33318 * expression.cs (Expression): this class now has a Type property
33319 which returns an expression Type.
33321 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33322 `Type', as this has a different meaning now in the base
33324 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33326 * interface.cs, class.cs: Removed from all the sources the
33327 references to signature computation, as we can not do method
33328 signature computation during the parsing time, as we are not
33329 trying to solve at that point distinguishing:
33333 void a (NS.Blah x) {}
33336 Which depending on the context might be valid or not, as we do not
33337 know if Blah is the same thing as NS.Blah at that point.
33339 * Redid everything so the code uses TypeRefs now instead of
33340 Types. TypeRefs are just temporary type placeholders, that need
33341 to be resolved. They initially have a pointer to a string and the
33342 current scope in which they are used. This is used later by the
33343 compiler to resolve the reference to an actual Type.
33345 * DeclSpace is no longer a CIR.Type, and neither are
33346 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33347 are all DeclSpaces, but no Types.
33349 * type.cs (TypeRefManager): This implements the TypeRef manager,
33350 which keeps track of all the types that need to be resolved after
33351 the parsing has finished.
33353 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33355 * ARGH. We are going to have to store `foreach' as a class rather
33356 than resolving it, as we need to verify error 1579 after name
33357 resolution. *OR* we could keep a flag that says `This request to
33358 IEnumerator comes from a foreach statement' which we can then use
33359 to generate the error.
33361 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33363 * class.cs (TypeContainer.AddMethod): we now add methods to the
33364 MethodGroup instead of the method hashtable.
33366 * expression.cs: Add MethodGroup abstraction, which gets us one
33367 step closer to the specification in the way we handle method
33370 * cs-parser.jay (primary_expression): qualified_identifier now
33371 tried to match up an identifier to a local variable reference or
33372 to a parameter reference.
33374 current_local_parameters is now a parser global variable that
33375 points to the current parameters for the block, used during name
33378 (property_declaration): Now creates an implicit `value' argument to
33381 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33383 * parameter.cs: Do not use `param' arguments as part of the
33384 signature, per the spec.
33386 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33388 * decl.cs: Base class for classes, structs and interfaces. This
33389 is the "Declaration Space"
33391 * cs-parser.jay: Use CheckDef for checking declaration errors
33392 instead of having one on each function.
33394 * class.cs: Factor out some code for handling error handling in
33395 accordance to the "Declarations" section in the "Basic Concepts"
33396 chapter in the ECMA C# spec.
33398 * interface.cs: Make all interface member classes derive from
33399 InterfaceMemberBase.
33401 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33403 * Many things: all interfaces are parsed and generated in
33404 gen-treedump. Support for member variables, constructors,
33405 destructors, properties, constants is there.
33407 Beginning of the IL backend, but very little done, just there for
33410 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33412 * cs-parser.jay: Fix labeled statement.
33414 * cs-tokenizer.cs (escape): Escape " and ' always.
33415 ref_line, ref_name: keep track of the line/filename as instructed
33416 by #line by the compiler.
33419 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33421 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33422 to match the values in System.CodeDOM.
33424 Divid renamed to Divide.
33426 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33428 (Statements.set): remove.
33430 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33433 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33434 falseStatements always have valid values.
33436 * cs-parser.jay: Use System.CodeDOM now.