1 2010-04-29 Marek Safar <marek.safar@gmail.com>
4 * statements.cs: Handle recursive scope initializers.
6 2010-04-28 Marek Safar <marek.safar@gmail.com>
9 * anonymous.cs: Always get inflated version of hoisted variable
10 on generic type definition.
12 2010-04-28 Marek Safar <marek.safar@gmail.com>
14 * import.cs, membercache.cs: Relax rules for valid properties.
16 2010-04-28 Marek Safar <marek.safar@gmail.com>
18 * import.cs: Intern arrays used in generic arguments.
20 2010-04-28 Marek Safar <marek.safar@gmail.com>
23 * convert.cs: Actually use effective base type for the comparison.
25 2010-04-28 Marek Safar <marek.safar@gmail.com>
28 * ecore.cs: Pass arity to base member lookup.
30 2010-04-28 Marek Safar <marek.safar@gmail.com>
33 * expression.cs: MemberAccess is of generic type based on right
36 2010-05-28 Marek Safar <marek.safar@gmail.com>
38 * cs-tokenizer.cs: Made tab size configurable.
40 2010-05-27 Marek Safar <marek.safar@gmail.com>
42 * attribute.cs: Ensure Obsolete members are defined before doing
45 2010-05-27 Marek Safar <marek.safar@gmail.com>
47 * visit.cs: Add DOM visitor skeleton.
51 2010-05-27 Marek Safar <marek.safar@gmail.com>
53 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
55 2010-05-27 Marek Safar <marek.safar@gmail.com>
57 * *.cs: Major rewrite of compiler internals to better work with
58 unmodified System.Reflection.Emit. Some of the key changes are
59 - TypeSpec replaces reflection specific System.Type.
60 - All Type(TypeSpec) operations are now done in compiler therefore
61 no dependency on SRE to inflate generic members and types or to
63 - MemberCache is now the only and full hierarchical topology.
64 - Generic constraints are implemented properly.
65 - And as a bonus compilation is on average 30% faster.
67 2010-04-15 Jb Evain <jbevain@novell.com>
69 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
71 2010-04-12 Marek Safar <marek.safar@gmail.com>
73 * expression.cs, attribute.cs, parameter.cs: More attribute type
76 2010-04-12 Marek Safar <marek.safar@gmail.com>
80 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
81 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
82 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
83 codegen.cs: Add custom attribute encoder to deal with unfinished
84 types and easier corlib bootstrap from its own types.
86 2010-03-26 Marek Safar <marek.safar@gmail.com>
88 * cs-parser.jay: Report invalid constraint types.
90 2010-03-16 Jb Evain <jbevain@novell.com>
92 * Makefile: rename the net_2_1 profile to moonlight.
94 2010-03-11 Marek Safar <marek.safar@gmail.com>
96 * statement.cs, cs-parser.jay: Use correct location for empty
99 2010-03-11 Marek Safar <marek.safar@gmail.com>
101 * cs-parser.jay: Disable Location from expression.
103 * generic.cs: Check constraints for overrides in the parser.
105 2010-03-09 Marek Safar <marek.safar@gmail.com>
107 * cs-parser.jay (GetLocation): Use an expression when available.
109 2010-03-04 Marek Safar <marek.safar@gmail.com>
111 A fix for bug #582579
112 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
114 2010-03-04 Marek Safar <marek.safar@gmail.com>
116 A patch by kornelpal@gmail.com
118 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
119 compiler generated classes sealed by default. Emit and close top
120 level compiler generated classes as well.
122 * support.cs: Use RuntimeHelpers.GetHashCode.
124 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
126 * Makefile: We need to use the internal bootstrapping gmcs for
127 net_2_1_bootstrap too now.
129 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
131 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
133 2010-03-02 Marek Safar <marek.safar@gmail.com>
135 * cs-tokenizer.cs: Missed few locations in previous fix.
137 2010-03-02 Marek Safar <marek.safar@gmail.com>
139 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
140 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
141 Report correct location for operator errors.
143 2010-03-02 Marek Safar <marek.safar@gmail.com>
145 * typemanager.cs (IsDynamicType): Don't check external types when
146 the attribute is not external.
148 2010-02-24 Marek Safar <marek.safar@gmail.com>
150 A fix for bug #582579
151 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
154 2010-02-24 Marek Safar <marek.safar@gmail.com>
156 A fix for bug #581804
157 * ecore.cs: Fixed type comparison.
159 2010-02-08 Miguel de Icaza <miguel@novell.com>
161 * namespace.cs (CompletionGetTypesStartingWith): Do not include
162 private types in the completion results.
164 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
167 2010-02-17 Marek Safar <marek.safar@gmail.com>
169 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
172 2010-02-14 Miguel de Icaza <miguel@novell.com>
174 * eval.cs: Do not do the report printer dance unless the user has
175 set the DescribeTypes feature.
177 2010-02-10 Marek Safar <marek.safar@gmail.com>
179 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
181 2010-02-08 Marek Safar <marek.safar@gmail.com>
183 A fix for bug #577029
184 * anonymous.cs: Fixed TypeBuilder* check.
186 2010-02-06 Miguel de Icaza <miguel@novell.com>
188 * eval.cs (CompileBlock): Also undo if there are problems during
189 semantic analysis, fixes various cases where invalid C# code would
190 be reported, but the internal changes would not be undone.
192 2010-02-03 Miguel de Icaza <miguel@novell.com>
194 * driver.cs: Change the --fatal flag to allow a number to be
195 passed, this ignores the first N fatal errors. Useful to debug
196 errors that do not happen on the first hit.
198 * cs-parser.jay (invocation_expression): accept both the
199 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
200 inside an invocation.
202 * driver.cs: Expose FatalErrors.
204 * eval.cs: Initialize the printer's Fatal property from the
205 Driver's FatalError flag, this allows csharp --fatal to work
208 Add support for calling Describe (typeof (TYPE)) if the expression
211 2010-02-02 Marek Safar <marek.safar@gmail.com>
213 A fix for bug #574991
214 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
217 2010-02-02 Marek Safar <marek.safar@gmail.com>
219 A fix for bug #575986
220 * expression.cs: Don't mutate typeof type definitions.
222 2010-01-28 Marek Safar <marek.safar@gmail.com>
224 * decl.cs: Use only one set of modifiers.
226 2010-01-26 Marek Safar <marek.safar@gmail.com>
228 A fix for bug #573329
229 * eval.cs: Don't disable error reporting completely on silent mode.
231 2010-01-25 Marek Safar <marek.safar@gmail.com>
233 A fix for bug #573312
234 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
235 pointer index of unknown size types greater than 2.
237 2010-01-15 Marek Safar <marek.safar@gmail.com>
239 * *.cs: Use only 1 member kind enum.
241 2010-01-15 Marek Safar <marek.safar@gmail.com>
243 * *.cs: Add event specification.
245 2010-01-14 Marek Safar <marek.safar@gmail.com>
247 * membercache.cs: Extracted from decl.cs.
249 * *.cs: Put more infrastructure in place.
251 2010-01-13 Marek Safar <marek.safar@gmail.com>
253 * *.cs: Add property specification, unused yet.
255 2010-01-13 Marek Safar <marek.safar@gmail.com>
257 * property.cs: Move all property based declarations into a new file.
259 2010-01-13 Marek Safar <marek.safar at gmail.com>
261 * expression.cs (Conditional): Resolve reduced expression.
263 2010-01-13 Marek Safar <marek.safar at gmail.com>
265 * *.cs: Introduced non-generic method specification.
267 2010-01-07 Marek Safar <marek.safar@gmail.com>
269 * method.cs: Move all method based declarations into a new file.
271 2010-01-07 Marek Safar <marek.safar@gmail.com>
273 * *.cs: Extract field specification.
275 2009-12-17 Marek Safar <marek.safar@gmail.com>
277 * field.cs: Extracted from class.cs
279 2009-12-15 Marek Safar <marek.safar@gmail.com>
281 * attribute.cs (GetFixedBuffer): Work on field definition only.
283 2009-12-15 Marek Safar <marek.safar@gmail.com>
285 * *.cs: Clean up NET_4_0 conditional where possible.
287 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
289 support.cs (DynamicType): Assembly property returns the assembly builder.
290 This is required due to how compiler context works in corlib.
292 2009-12-14 Marek Safar <marek.safar@gmail.com>
294 A fix for bug #564376
295 * assign.cs (LocalTemporary): Removed no longer needed special
298 2009-12-11 Marek Safar <marek.safar@gmail.com>
300 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
301 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
302 enum for easier debugging.
304 2009-12-10 Marek Safar <marek.safar@gmail.com>
306 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
309 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
312 2009-12-10 Marek Safar <marek.safar@gmail.com>
314 * cs-parser.jay, statement.cs: Handle parser error in code
317 2009-12-10 Marek Safar <marek.safar@gmail.com>
319 * ecore.cs: Ignore base imported methods when they are already
322 * eval.cs: Handle non-existent keys.
324 * report.cs, driver.cs: Make fatal work with console printer only.
326 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
328 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
330 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
332 * typemanager.cs: Add MakeGenericMethod that checks if the method
333 is really the generic method definition.
335 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
336 to inflate generic methods.
338 2009-12-08 Marek Safar <marek.safar@gmail.com>
340 A fix for bug #561149
341 * anonymous.cs: Use actual type parameters when checking for generic
344 2009-12-08 Marek Safar <marek.safar@gmail.com>
346 A fix for bug #561369
347 * expression.cs (DoNumericPromotion): Fixed typo.
349 2009-12-08 Marek Safar <marek.safar@gmail.com>
351 *.cs: Moving to generics world.
353 cs-parser.jay: Removed current_array_type.
355 2009-12-07 Marek Safar <marek.safar@gmail.com>
357 *.cs: Moving to generics world.
359 2009-12-04 Marek Safar <marek.safar@gmail.com>
361 *.cs: Moving to generics world (day 2).
363 2009-12-03 Marek Safar <marek.safar@gmail.com>
365 *.cs: Moving to generics world.
367 2009-12-02 Marek Safar <marek.safar@gmail.com>
369 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
370 Encode dynamic type attribute for elements where attributes cannot
373 2009-12-01 Marek Safar <marek.safar@gmail.com>
375 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
378 2009-12-01 Marek Safar <marek.safar@gmail.com>
380 A fix for bug #360455
381 * class.cs: Never report a unused warning for generic events to
382 workaround wrong expression type.
384 2009-11-30 Marek Safar <marek.safar@gmail.com>
386 A fix for bug #558305
387 * decl.cs, class.cs: Check partial method definitions using correct
390 2009-11-30 Marek Safar <marek.safar@gmail.com>
392 * argument.cs: Don't cache rarely used dynamic flag.
394 2009-11-27 Marek Safar <marek.safar@gmail.com>
396 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
398 2009-11-27 Marek Safar <marek.safar@gmail.com>
400 * ecore.cs (SimpleName): Removed no longer needed in_transit as
401 Resolve is now non-reentrant (saves ~0.6MB for corlib).
403 2009-11-26 Marek Safar <marek.safar@gmail.com>
405 A fix for bug #545081
406 * decl.cs: Check private nested types of nested types recursively.
408 2009-11-26 Marek Safar <marek.safar@gmail.com>
410 A fix for bug #558305
411 * location.cs: Ignore self referencing #line directive
413 2009-11-26 Marek Safar <marek.safar@gmail.com>
415 A fix for bug #558292
416 * class.cs: Allow single unsafe fixed buffer fields.
418 2009-11-26 Marek Safar <marek.safar@gmail.com>
420 * expression: Optimize few more zero-based operations.
422 2009-11-26 Marek Safar <marek.safar@gmail.com>
424 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
425 avoids boxing of literal values.
427 2009-11-26 Marek Safar <marek.safar@gmail.com>
429 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
430 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
431 codegen.cs: LocatedToken redesing to avoid excessive allocation and
432 boxing (saves ~7MB for corlib). Also fixes presise token location.
434 2009-11-25 Marek Safar <marek.safar@gmail.com>
436 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
439 2009-11-24 Marek Safar <marek.safar@gmail.com>
441 * expression.cs: Lower static array initializer barrier.
443 * support.cs, driver.cs: Share reader buffer.
445 2009-11-23 Marek Safar <marek.safar@gmail.com>
447 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
449 2009-11-23 Marek Safar <marek.safar@gmail.com>
451 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
452 cleanup some obsolete code.
454 2009-11-20 Marek Safar <marek.safar@gmail.com>
456 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
459 2009-11-20 Marek Safar <marek.safar@gmail.com>
461 * *.cs: Resolved expressions are never resolved again, this helps to
462 uncover some not easy to find bugs and improve the performance.
464 2009-11-19 Marek Safar <marek.safar@gmail.com>
466 * *.cs: Made constant expressions fully compatible with any other
469 2009-11-19 Marek Safar <marek.safar@gmail.com>
471 * *.cs: DoResolve is a worker method and has to be protected.
473 2009-11-18 Marek Safar <marek.safar@gmail.com>
475 * *.cs: More context specific handling.
477 2009-11-17 Marek Safar <marek.safar@gmail.com>
479 * *.cs: More context specific handling.
481 2009-11-16 Marek Safar <marek.safar@gmail.com>
483 * dynamic.cs, class.cs: Removed few fixed user types conversions.
485 * symbolwriter.cs: Uses public ILOffset.
487 2009-11-13 Marek Safar <marek.safar@gmail.com>
489 A fix for bug #553650
490 * generic.cs: Another missing TypeToCoreType, still too many to fix.
492 2009-11-13 Marek Safar <marek.safar@gmail.com>
494 A fix for bug #555170
496 * class.cs, delegate.cs, enum.cs: Constants have to be available
497 for parameters resolve.
499 2009-11-12 Marek Safar <marek.safar@gmail.com>
501 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
504 2009-11-12 Marek Safar <marek.safar@gmail.com>
506 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
507 with a statically known candidate set.
509 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
511 * generic.cs: Made type inflation for generic constraint checks
512 recursive. This fixes BGO #553655.
514 2009-11-11 Marek Safar <marek.safar@gmail.com>
516 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
519 2009-11-10 Marek Safar <marek.safar@gmail.com>
521 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
522 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
523 attribute.cs: Add some dynamic error checking.
525 2009-11-07 Marek Safar <marek.safar@gmail.com>
527 A fix for bug #553465
529 * expression.cs: Fixed mixed version of expression tree anonymous
532 2009-11-06 Marek Safar <marek.safar@gmail.com>
534 A fix for bug #553031
536 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
537 expression tree version of anonymous type with members declaration.
539 2009-11-05 Marek Safar <marek.safar@gmail.com>
541 * parameter.cs: Handle nullable parameter default expression.
543 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
544 class.cs, attribute.cs: Check for wrong dynamic arguments.
546 2009-11-05 Marek Safar <marek.safar@gmail.com>
548 * statement.cs: Dynamic statements.
550 2009-11-04 Marek Safar <marek.safar@gmail.com>
552 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
553 Compound assignments over dynamic type.
555 2009-11-03 Marek Safar <marek.safar@gmail.com>
557 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
558 constructor arguments.
560 2009-10-30 Marek Safar <marek.safar@gmail.com>
562 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
563 codegen.cs: Unary mutator on dynamic member access expression.
565 2009-10-29 Marek Safar <marek.safar@gmail.com>
567 A fix for bug #550580
568 * convert.cs: Don't eliminate explicit precission casts.
570 2009-10-28 Marek Safar <marek.safar@gmail.com>
572 A fix for bug #550404
574 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
575 expression.cs, statement.cs, ecore.cs: Quote any nested expression
578 2009-10-27 Marek Safar <marek.safar@gmail.com>
580 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
583 * class.cs: Allow nullable binary user operators.
585 2009-10-26 Marek Safar <marek.safar@gmail.com>
587 * expression.cs: Move binary expression optimization at the end of
590 2009-10-23 Marek Safar <marek.safar@gmail.com>
592 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
593 Separate NullConstant from NullLiteral.
595 2009-10-23 Marek Safar <marek.safar@gmail.com>
597 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
598 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
599 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
600 ModuleContainer. Add common unclosed member check routine.
602 2009-10-22 Marek Safar <marek.safar@gmail.com>
604 * argument.cs: Use literal flag for real literals only.
606 * dynamic.cs: Use correct return type for custom delegates.
608 2009-10-22 Marek Safar <marek.safar@gmail.com>
610 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
613 2009-10-22 Marek Safar <marek.safar@gmail.com>
615 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
617 2009-10-21 Marek Safar <marek.safar@gmail.com>
619 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
622 2009-10-21 Marek Safar <marek.safar@gmail.com>
624 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
627 2009-10-20 Marek Safar <marek.safar@gmail.com>
629 * argument.cs, dynamic.cs, expression.cs: Latest API update.
631 2009-10-19 Marek Safar <marek.safar@gmail.com>
633 * typemanager.cs, expression.cs: Dynamic array initializer.
635 2009-10-16 Marek Safar <marek.safar@gmail.com>
637 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
640 2009-10-16 Marek Safar <marek.safar@gmail.com>
642 A fix for bug #493523, #507067
643 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
644 standard nullable conversion using underlying standard conversion
645 and not full conversion.
647 2009-10-15 Marek Safar <marek.safar@gmail.com>
649 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
650 type in VerifyArgumentsCompat.
652 2009-10-15 Marek Safar <marek.safar@gmail.com>
654 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
655 Reject variable used with type arguments.
657 2009-10-14 Marek Safar <marek.safar@gmail.com>
659 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
660 Implement dynamic expressions assignment.
662 2009-10-14 Marek Safar <marek.safar@gmail.com>
664 * expression.cs: Build underlying expression when resolving unary
667 2009-10-14 Marek Safar <marek.safar@gmail.com>
669 * expression.cs: Emit enum array initializer using binary blob.
671 2009-10-08 Marek Safar <marek.safar@gmail.com>
673 * typemanager.cs, constant.cs: Optimize decimal constants which fit
676 2009-10-07 Marek Safar <marek.safar@gmail.com>
678 * typemanager.cs: Reset object_type.
680 * assign: Made SimpleAssign public.
682 2009-10-06 Marek Safar <marek.safar@gmail.com>
684 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
685 invocation assembly to IsThisOrFriendAssembly.
687 2009-10-05 Marek Safar <marek.safar@gmail.com>
689 * expression.cs: Equality comparison of generic parameter with
692 2009-10-05 Marek Safar <marek.safar@gmail.com>
694 A fix for bug #543570
695 * generic.cs: Import predefined constraints correctly.
697 2009-10-02 Marek Safar <marek.safar@gmail.com>
699 * ecore.cs: Don't crash on overloads with optional paremeters where
700 arguments count overflows.
702 * parameter.cs: Import optional parameter constants using optional
705 2009-10-01 Marek Safar <marek.safar@gmail.com>
707 * Makefile: Default is gmcs compiler.
709 2009-10-01 Marek Safar <marek.safar@gmail.com>
711 * cs-parser.jay: Fixed few NRE.
713 2009-10-01 Marek Safar <marek.safar@gmail.com>
715 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
717 2009-09-30 Marek Safar <marek.safar@gmail.com>
719 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
720 ShimExpression, ImplicitCast.
722 2009-09-30 Marek Safar <marek.safar@gmail.com>
724 A fix for bug #542959
725 * delegate.cs: Emit correct delegate instance variable when there
726 are static and non-static overloads.
728 2009-09-29 Marek Safar <marek.safar@gmail.com>
730 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
731 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
733 2009-09-28 Marek Safar <marek.safar@gmail.com>
735 A fix for bug #542487
736 * ecore.cs: Resolve extension methods hidden by properties.
738 2009-09-25 Marek Safar <marek.safar@gmail.com>
740 * expression.cs, ecore.cs: More dynamic binary expressions.
742 2009-09-22 Marek Safar <marek.safar@gmail.com>
744 * nullable.cs, expression.cs: Fixed null lifted conversion for
745 bitwise enum operations.
747 2009-09-22 Marek Safar <marek.safar@gmail.com>
749 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
750 values in checked context.
752 2009-09-22 Marek Safar <marek.safar@gmail.com>
754 * expression.cs, ecore.cs: Fixed array index constant conversion.
756 2009-09-20 Miguel de Icaza <miguel@novell.com>
758 * expression.cs: Do not crash when MemberLookup returns something
759 that is not a MemberExpr here. Report error 582 instead.
763 2009-09-18 Marek Safar <marek.safar@gmail.com>
765 * decl.cs, class.cs: Check protected property accessors.
767 2009-09-18 Marek Safar <marek.safar@gmail.com>
769 * dynamic.cs, assign.cs: Dynamic compound assignment.
771 2009-09-17 Marek Safar <marek.safar@gmail.com>
773 * expression.cs: Fixed compound assignment explicit conversion.
775 2009-09-17 Marek Safar <marek.safar@gmail.com>
777 * expression.cs, ecore.cs: Cannot infer variables from method group.
779 2009-09-16 Marek Safar <marek.safar@gmail.com>
781 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
782 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
783 codegen.cs: Dynamic binary operations scaffolding.
785 2009-09-15 Marek Safar <marek.safar@gmail.com>
787 * expression.cs: Fixes nullable promotion for enum type variables.
789 2009-09-11 Marek Safar <marek.safar@gmail.com>
791 * driver.cs, dynamic.cs: Reset more static variables.
793 2009-09-11 Marek Safar <marek.safar@gmail.com>
795 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
796 driver.cs: Introduced Expression::MakeExpression.
798 2009-09-11 Marek Safar <marek.safar@gmail.com>
800 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
802 2009-09-09 Marek Safar <marek.safar@gmail.com>
804 * eval.cs, report.cs: Use Console.Out for all eval error or warning
807 2009-09-09 Marek Safar <marek.safar@gmail.com>
809 A fix for bug #518707
810 * expression.cs (Is): Optimize only generic parameter type
811 expression probing value type generic parameter.
813 2009-09-09 Marek Safar <marek.safar@gmail.com>
815 A fix for bug #532571
816 * ecore.cs: Check for simple name type arguments used with
819 2009-09-08 Marek Safar <marek.safar@gmail.com>
821 A fix for bug #497421
822 * generic.cs (CheckConstraint): Don't use buildin types to check for
823 parameterless constructor.
825 2009-09-08 Marek Safar <marek.safar@gmail.com>
827 A fix for bug #537402
828 * generic.cs (CheckConstraint): Correctly inflate generic type
829 arguments when checking generic method.
831 2009-09-08 Marek Safar <marek.safar@gmail.com>
833 A fix for bug #536463
834 * decl.cs (AddToContainer): Don't report collision between explicit
835 and parameterless non-explicit members.
837 2009-09-08 Marek Safar <marek.safar@gmail.com>
839 * eval.cs: Reset more static stuff.
841 2009-09-07 Marek Safar <marek.safar@gmail.com>
843 A fix for bug #324625
844 * expression.cs, ecore.cs: Create nested generic type expression
845 using declaring and not current type.
847 2009-09-07 Marek Safar <marek.safar@gmail.com>
849 * *.cs: Changed Report class to accept various output printers and
850 be an instance class. An expression resolver can now use different
851 message reporter for each call and Report.Error can safely throw
852 an exception. Part of ongoing work to turn mcs into proper library.
854 2009-09-04 Marek Safar <marek.safar@gmail.com>
856 * statement.cs, ecore.cs: Removed error reporting from emit code.
858 2009-09-04 Marek Safar <marek.safar@gmail.com>
860 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
862 2009-09-03 Marek Safar <marek.safar@gmail.com>
864 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
865 parser checks out of constructors.
867 2009-09-02 Marek Safar <marek.safar@gmail.com>
869 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
871 2009-09-02 Marek Safar <marek.safar@gmail.com>
873 A fix for bug #535448
874 * anonymous.cs, class.cs: Copy return label between all contexts.
876 2009-09-02 Marek Safar <marek.safar@gmail.com>
878 A fix for bug #535395
879 * namespace.cs: Resolve context can be null.
881 2009-08-25 Marek Safar <marek.safar@gmail.com>
883 A fix for bug #533912
884 * generic.cs: Use correct context for constraints resolving.
886 2009-08-25 Marek Safar <marek.safar@gmail.com>
888 A fix for bug #532630
889 * driver.cs: Trim conditional symbols.
891 2009-08-25 Marek Safar <marek.safar@gmail.com>
893 * context.cs: New file.
895 * *.exe.sources, *.csproj: Updated.
897 2009-08-25 Marek Safar <marek.safar@gmail.com>
899 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
900 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
901 IMembercontext, some small cleanups.
903 2009-08-24 Marek Safar <marek.safar@gmail.com>
905 * *.cs: Split ResolveContext and EmitContext.
907 2009-08-24 Marek Safar <marek.safar@gmail.com>
909 * *.cs: Only ResolveContext implements IMemberContext.
911 2009-08-21 Marek Safar <marek.safar@gmail.com>
913 * *.cs: Renamed IResolveContext to IMemberContext.
915 2009-08-21 Marek Safar <marek.safar@gmail.com>
917 * *.cs: Detached ResolveContext from EmitContext.
919 2009-08-21 Marek Safar <marek.safar@gmail.com>
921 * codegen.cs: Moved flow-analysis to BlockContext.
923 2009-08-21 Marek Safar <marek.safar@gmail.com>
925 * *.cs: Detached BlockContext from EmitContext.
927 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
929 * statement.cs: avoid nullref when the return value of GetEnumerator()
930 does not contain any MoveNext() method.
932 2009-08-19 Marek Safar <marek.safar@gmail.com>
934 * *.cs: Removed IResolveContext::GenericDeclContainer.
936 2009-08-19 Marek Safar <marek.safar@gmail.com>
938 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
940 2009-08-19 Marek Safar <marek.safar@gmail.com>
942 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
943 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
945 2009-08-18 Marek Safar <marek.safar@gmail.com>
947 * *.cs: Removed boolean fields from EmitContext.
949 2009-08-18 Marek Safar <marek.safar@gmail.com>
951 * *.cs: Add IResolveContext::IsStatic.
953 2009-08-18 Marek Safar <marek.safar@gmail.com>
955 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
957 2009-08-17 Marek Safar <marek.safar@gmail.com>
959 * *.cs: Removed DeclContainer from EmitContext.
961 2009-08-17 Marek Safar <marek.safar@gmail.com>
963 * *.cs: Add IResolveContext::CurrentTypeParameters.
965 2009-08-14 Marek Safar <marek.safar@gmail.com>
967 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
969 2009-08-14 Marek Safar <marek.safar@gmail.com>
971 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
972 codegen.cs: Add IResolveContext::LookupExtensionMethod.
974 2009-08-13 Marek Safar <marek.safar@gmail.com>
976 * decl.cs: Look in PartialContainer for parent type parameters.
978 2009-08-13 Marek Safar <marek.safar@gmail.com>
980 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
981 codegen.cs: Add IResolveContext::LookupTypeParameter.
983 2009-08-13 Marek Safar <marek.safar@gmail.com>
985 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
986 Moved resolved logic from Emit to Resolve.
988 2009-08-13 Marek Safar <marek.safar@gmail.com>
990 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
991 codegen.cs: Reworked atttributes handling of ResolveContext.
993 2009-08-12 Marek Safar <marek.safar@gmail.com>
995 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
996 LookupNamespaceOrType to ResolveContext.
998 2009-08-12 Marek Safar <marek.safar@gmail.com>
1000 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1001 class.cs: Removed unused parameters and methods.
1003 2009-08-11 Marek Safar <marek.safar@gmail.com>
1005 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1006 codegen.cs: Finding the best common type of a set of expressions for
1009 2009-08-07 Marek Safar <marek.safar@gmail.com>
1011 * dynamic.cs, expression.cs: More dynamic conversions.
1013 2009-08-06 Miguel de Icaza <miguel@novell.com>
1015 * generic.cs: This loop was incorrect, it was increment ii, but
1016 checking for `i'. This was a change introduced to fix #327497,
1019 * class.cs: Catch another case for cs0533 error, fixes #324782.
1021 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1023 * typemanager.cs (GetGenericArguments): SRE returns null for
1024 generic methods on type builder instances if they are not generic
1025 themselves. For example, for Foo<int>::Bar() it returns null, but
1026 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1028 2009-08-05 Marek Safar <marek.safar@gmail.com>
1030 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1031 delegate.cs: Work on dynamic binding.
1033 2009-08-04 Marek Safar <marek.safar@gmail.com>
1035 A second fix for bug #525342
1036 * class.cs: Attach partial method attributes to method
1039 2009-08-03 Marek Safar <marek.safar@gmail.com>
1041 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1044 * rootcontext.cs: Default to langversion v4.
1046 2009-08-03 Marek Safar <marek.safar@gmail.com>
1048 * pending.cs: Check return type before member info is set.
1050 2009-08-03 Marek Safar <marek.safar@gmail.com>
1052 * anonymous.cs: Fully initialize generic hoisted field expression.
1054 2009-08-02 Miguel de Icaza <miguel@novell.com>
1056 * cs-parser.jay: Flag variables declared on the interactive shell
1057 as used to prevent the 168 warning about local variable not being
1060 2009-07-31 Marek Safar <marek.safar@gmail.com>
1062 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1063 attribute.cs: Emit dynamic export attribute.
1065 2009-07-30 Marek Safar <marek.safar@gmail.com>
1067 * expression.cs: More verifier work.
1069 2009-07-29 Marek Safar <marek.safar@gmail.com>
1071 * nullable.cs: Fixed SRE crash during corlib compilation.
1073 2009-07-29 Marek Safar <marek.safar@gmail.com>
1075 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1076 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1077 More TypeManager.TypeToCoreType needed.
1079 2009-07-29 Marek Safar <marek.safar@gmail.com>
1081 * anonymous.cs: Update after recent SRE fixes.
1083 2009-07-28 Marek Safar <marek.safar@gmail.com>
1085 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1086 version of GetFieldHandle for fields of generic types.
1088 2009-07-27 Marek Safar <marek.safar@gmail.com>
1090 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1091 ecore.cs: Add TypeManager.IsDynamicType,
1092 PredefinedAttributes.Dynamic.
1094 2009-07-27 Marek Safar <marek.safar@gmail.com>
1096 A fix for bug #415375
1097 * expression.cs: Fixed object and reference type parameter
1100 2009-07-27 Marek Safar <marek.safar@gmail.com>
1102 A fix for bug #525342
1103 * class.cs: Attach partial method attributes to method
1106 2009-07-24 Marek Safar <marek.safar@gmail.com>
1108 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1111 2009-07-24 Marek Safar <marek.safar@gmail.com>
1113 * anonymous.cs (MutateField): Add imported types handling.
1115 2009-07-23 Marek Safar <marek.safar@gmail.com>
1117 * expression.cs, delegate.cs: Moved arguments resolve into their
1118 counterparts expressions. Removed argument resolve from
1119 CollectionElementInitializer.
1121 2009-07-23 Marek Safar <marek.safar@gmail.com>
1123 A fix for bug #523683
1124 * convert.cs, delegate.cs: Use common overload mechanism for method
1125 group conversion check.
1127 2009-07-22 Marek Safar <marek.safar@gmail.com>
1129 A fix for bug #523899
1130 * generics.cs: Exact type inference with other bound types.
1132 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1134 Don't complain when the same type is implemented by the output
1135 assembly as well as multiple referenced assemblies
1136 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1137 'must_be_unique' flag.
1138 (GlobalRootNamespace): Update to changes.
1139 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1140 already have a type in hand.
1142 2009-07-22 Marek Safar <marek.safar@gmail.com>
1144 * expression.cs: More verifier instrumentation.
1146 * statement.cs: Do proper throw expression conversion.
1148 2009-07-22 Marek Safar <marek.safar@gmail.com>
1150 A fix for bug #522789
1151 * expression.cs: Mutate invocation return type.
1153 2009-07-16 Marek Safar <marek.safar@gmail.com>
1155 * anonymous.cs: Split assignable and readonly generated variable
1158 2009-07-16 Marek Safar <marek.safar@gmail.com>
1160 A fix for bug #521671
1161 * statement.cs: Fixed crash when checking missing type.
1163 2009-07-16 Marek Safar <marek.safar@gmail.com>
1165 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1166 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1167 class.cs, driver.cs: Work on dynamic binding.
1169 * dynamic.cs: New file.
1171 * *.sources, *.proj: Updated.
1173 2009-07-15 Marek Safar <marek.safar@gmail.com>
1175 * expression.cs (Conditional): Avoid double Resolve.
1177 2009-07-13 Marcus Griep <marcus@griep.us>
1179 * ecore.cs: Fix obscure bug with resolving members of interfaces
1180 that hide parent interface members. Fixes bug #444388 and corrects
1183 2009-07-13 Marek Safar <marek.safar@gmail.com>
1185 * expression.cs (LocalVariableReference): Bounce resolve.
1187 2009-07-10 Marek Safar <marek.safar@gmail.com>
1189 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1190 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1193 * support.cs: New dynamic type wrapper.
1195 2009-07-08 Marek Safar <marek.safar@gmail.com>
1197 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1198 typed local variable.
1200 2009-07-06 Marek Safar <marek.safar@gmail.com>
1202 A fix for bug #519005
1203 * anonymous.cs: Use null_type as no return type placeholder.
1205 2009-07-02 Marek Safar <marek.safar@gmail.com>
1207 * generic.cs: Handle type inference of identical type parameters
1208 with different bounds.
1210 2009-07-01 Marek Safar <marek.safar@gmail.com>
1212 * expression.cs, class.cs: Events variance.
1214 * cs-parser.jay: Interface events error messages.
1216 2009-07-01 Marek Safar <marek.safar@gmail.com>
1218 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1220 2009-06-29 Marek Safar <marek.safar@gmail.com>
1222 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1223 parameter expression can be value-type New.
1225 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1227 2009-06-26 Marek Safar <marek.safar@gmail.com>
1229 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1230 Implemented C# 4.0 named arguments.
1232 2009-06-24 Marek Safar <marek.safar@gmail.com>
1234 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1235 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1236 parameter modifier. Also fixes bug #515497.
1238 2009-06-24 Marek Safar <marek.safar@gmail.com>
1240 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1241 arguments expression to be implemented.
1243 *.sources: Add argument.cs
1245 2009-06-23 Marek Safar <marek.safar@gmail.com>
1247 * parameter.cs: Moved GetParameterIndexByName to base class.
1249 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1250 unused AType. Use argument's version of GetExpressionTree.
1252 2009-06-22 Marek Safar <marek.safar@gmail.com>
1254 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1257 2009-06-17 Marek Safar <marek.safar@gmail.com>
1259 A fix for bug #514096
1260 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1262 2009-06-17 Marek Safar <marek.safar@gmail.com>
1264 * expression.cs: The first multi-dimensional array nested array
1265 initializers was not checked.
1267 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1269 2009-06-17 Marek Safar <marek.safar@gmail.com>
1271 A fix for bug #513400
1272 * nullable.cs (EmitEquality): Operands emit could be simplified for
1273 built-in types when we now emit user operators differently.
1275 2009-06-16 Marek Safar <marek.safar@gmail.com>
1277 * ecore.cs: Report inaccessible delegate methods correctly.
1279 2009-06-16 Marek Safar <marek.safar@gmail.com>
1281 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1282 cs-parser.jay: Implemented C# 4.0 optional parameters.
1284 2009-06-16 Marek Safar <marek.safar@gmail.com>
1286 * driver.cs: Removed broken DefineManifestResource.
1288 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1290 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1291 Use $(BOOTSTRAP_PROFILE) instead.
1293 2009-06-12 Jb Evain <jbevain@novell.com>
1295 * rootcontext.cs: add a Platform field.
1296 * driver.cs: handle /platform.
1297 * codegen.cs: pass the proper flags according to
1298 the platform when saving the assembly.
1300 2009-06-11 Marek Safar <marek.safar@gmail.com>
1302 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1303 Add optional parameters grammar.
1305 2009-06-10 Marek Safar <marek.safar@gmail.com>
1307 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1308 driver.cs: Split lang version and metadata version.
1310 2009-06-10 Marek Safar <marek.safar@gmail.com>
1312 * decl.cs: Better overload ctor collision error message.
1314 2009-06-05 Jb Evain <jbevain@novell.com>
1316 * driver.cs (EmbededResource): avoid using an internal method
1317 in gmcs to embed manifest resources.
1319 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1321 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1322 the compiler from older mono versions (like moon's bots)
1324 2009-06-04 Marek Safar <marek.safar@gmail.com>
1326 * namespace.cs (LookupTypeReflection): Ignore collisions between
1329 2009-06-04 Marek Safar <marek.safar@gmail.com>
1331 * codegen.cs: Enabled generic type forwarders.
1333 2009-06-04 Marek Safar <marek.safar@gmail.com>
1335 * dmcs.*: Add another version of SRE compiler.
1337 2009-06-03 Marek Safar <marek.safar@gmail.com>
1339 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1340 generic-mcs.cs: Fixed variant type conversions.
1342 2009-06-02 Marek Safar <marek.safar@gmail.com>
1344 A fix for bug #507863
1345 * codegen.cs: Fixes a crash on invalid string value attribute.
1347 2009-06-01 Marek Safar <marek.safar@gmail.com>
1349 A fix for bug #508334
1350 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1351 cs-parser.jay: Fully import __arglist modifier.
1353 2009-05-29 Marek Safar <marek.safar@gmail.com>
1355 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1356 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1357 actually work with closed generic types.
1359 2009-05-27 Alan McGovern <amcgovern@novell.com>
1361 * class.cs, decl.cs, delegate.cs, parameter.cs:
1362 Fix the build by replacing the use of 'var' with the actual type.
1364 2009-05-27 Marek Safar <marek.safar@gmail.com>
1366 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1367 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1370 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1373 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1374 Marek Safar <marek.safar@gmail.com>
1376 A fix for bug #377509
1377 * parameter.cs: Use predefined and not empty name for implicit
1380 2009-05-21 Marek Safar <marek.safar@gmail.com>
1382 * class.cs: Don't report wrong warnings for event fields.
1384 2009-05-21 Marek Safar <marek.safar@gmail.com>
1386 A fix for bug #504667
1387 * class.cs: Check for static class using parent container instead of
1390 2009-05-08 Marek Safar <marek.safar@gmail.com>
1392 A fix for bug #496922
1393 * expression.cs: Always use temporary variable when using object
1396 2009-04-28 Marek Safar <marek.safar@gmail.com>
1398 A fix for bug #495112
1399 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1402 2009-04-27 Miguel de Icaza <miguel@novell.com>
1404 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1406 2009-04-24 Miguel de Icaza <miguel@novell.com>
1408 * complete.cs: No idea how gonzalo got a null in the list, but
1411 2009-04-24 Miguel de Icaza <miguel@novell.com>
1413 * complete.cs (CompletionElementInitializer): New completion class
1414 to support completing inside a C# 3 element initializer, so this
1415 allows completion for Silverlight situations where it is very
1418 new TextBlock () { Fo<TAB>
1420 (CompletionSimpleName): Expose the prefix that was
1421 passed to the simple name.
1423 * cs-parser.jay (object_or_collection_initializer): Add support
1424 for element_initializers.
1426 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1427 special case completion expressions as this method aggressively
1428 collects data before it operates, and errors were being thrown
1429 earlier than we were able to complete.
1431 2009-04-23 Miguel de Icaza <miguel@novell.com>
1433 * eval.cs: Make getcompletions silent and enable debugging output
1434 if the -v option is passed.
1436 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1437 Consider looking up the namespace that matches the prefix being
1440 This is part of the support for allowing completions like:
1441 `System.Co<TAB>' to complete to System.Console.
1443 * complete.cs (CompletionSimpleName.AppendResults): Make this
1446 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1448 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1449 COMPLETE_COMPLETION as internal.
1451 2009-04-17 Miguel de Icaza <miguel@novell.com>
1453 * complete.cs: Include namespace resolution in simple names as
1454 well as global types and types in the using scope in the
1457 * namespace.cs: Supporting infrastrcture to provide completions
1458 based on the current using scope.
1460 * eval.cs: Introduce an entry point that allows for initialization
1461 to return a list of the files passed on the command line.
1463 2009-04-14 Marek Safar <marek.safar@gmail.com>
1465 A fix for bug #494243
1466 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1468 2009-04-13 Marek Safar <marek.safar@gmail.com>
1470 A fix for bug #493887
1471 * statement.cs: Don't skip string multi-section with default or
1472 null label when populating string hashtable.
1474 2009-04-06 Marek Safar <marek.safar@gmail.com>
1476 A fix for bug #492329
1477 * expression.cs (New): Load variable when assigning type parameter
1480 2009-04-06 Marek Safar <marek.safar@gmail.com>
1482 A fix for bug #488960
1483 * decl.cs: Compare MVAR types using non-null values.
1485 2009-03-27 Marek Safar <marek.safar@gmail.com>
1487 * typemanager.cs, expression.cs: Removed unused nullable checks.
1489 2009-03-27 Marek Safar <marek.safar@gmail.com>
1491 * *.cs: Removed some gmcs conditionals.
1493 2009-03-26 Marek Safar <marek.safar@gmail.com>
1495 * generic.cs, support.cs: Moved generics stuff out of support.cs
1497 2009-03-24 Marek Safar <marek.safar@gmail.com>
1499 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1502 2009-03-23 Marek Safar <marek.safar@gmail.com>
1504 * attribute.cs: Consider all members for error reporting when
1505 checking named arguments.
1507 2009-03-23 Marek Safar <marek.safar@gmail.com>
1509 A fix for bug #487625
1510 * namespace.cs: Use a warning for all predefined type conflicts.
1512 2009-03-23 Marek Safar <marek.safar@gmail.com>
1514 A fix for bug #485706
1515 * statement.cs: Explicitly type catch type argument to pass verifier
1518 2009-03-22 Miguel de Icaza <miguel@novell.com>
1520 Initial support to provide code completion facilities to consumers
1521 of the evaluator API.
1523 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1524 support the completion engine. When we reach the end of the
1525 input stream instead of returning EOF, when this flag is true the
1526 tokenizer instead produces:
1528 One GENERATE_COMPLETION token: this token then must be
1529 handled in the grammar at every point where the user
1530 would likely request a completion.
1532 As many COMPLETE_COMPLETION tokens as necessary. These
1533 tokens are generated to assist the parser in unwinding and
1534 producing a valid parse tree.
1536 The parser rules do not have to be perfect, the parser needs to be
1537 augmented with judicious use of GENERATE_COMPLETION tokens to
1538 improve the areas where we can provide completion and the parser
1539 needs to add support for COMPLETE_COMPLETION tokens in productions
1542 It is common to not have enough support for COMPLETE_COMPLETION
1543 under certain rules and that even if we generated the
1544 GENERATE_COMPLETION token that the resulting tree will be invalid
1545 due to the missing rules that support COMPLETE_COMPLETION.
1547 The final EOF token is produced by having the parser notify the
1548 tokenizer when it reaches the root production that the next token
1551 * support.cs (CompletionResult): New Exception. This exception
1552 is thrown to return the completion results when one of the special
1553 completion expressions is reached.
1555 This exception is thrown by the completing ExpressionStatements
1556 classes that live in complete.cs
1558 * complete.cs (CompletingExpression): a new base class for
1559 completing expressions. This derives from the
1560 ExpressionStatement class and not from Expression as it allows
1561 completion to happen not only where expressions are expected in
1562 the grammar, but also where statements are expected.
1564 (CompletionSimpleName): A new class used to provide completions
1565 for SimpleNames. This currently only resolves to local
1566 variables from the evaluator context (GetVars call).
1568 (CompletionMemberAccess): Implements support for completing member
1571 * cs-parser.jay: Add support for completion in a few places.
1573 * eval.cs (GetCompletions): New public API for the evaluator that
1574 returns a list of possible completions given the input. The
1575 return value is an array of completions
1577 * anonymous.cs (Compatible): If the exception thrown from the
1578 resolved expression is a CompletionResult exception let that one
1579 through instead of printing a diagnostic error in the try/catch.
1581 2009-03-22 Miguel de Icaza <miguel@novell.com>
1585 * driver.cs (Main): Use Environment.Exit to quit quickly and
1586 prevent the compiler from doing the usual wait for helper thread
1589 This is to prevent a slowdown that was reported by Gonzalo on
1592 2009-03-19 Marek Safar <marek.safar@gmail.com>
1594 * ecore.cs: Load build-in types directly instead of accessing
1597 2009-03-18 Marek Safar <marek.safar@gmail.com>
1599 * ecore.cs: Always use unbox.any when available.
1601 2009-03-18 Marek Safar <marek.safar@gmail.com>
1603 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1605 2009-03-17 Marek Safar <marek.safar@gmail.com>
1607 * generic.cs: Removed obsolete version of type inference.
1609 2009-03-16 Marek Safar <marek.safar@gmail.com>
1611 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1612 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1613 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1614 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1616 2009-03-11 Marek Safar <marek.safar@gmail.com>
1618 A fix for bug #482996
1619 * anonymous.cs: Make sure we are not infering return type when
1620 checking type compatibility.
1622 2009-03-11 Marek Safar <marek.safar@gmail.com>
1624 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1625 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1626 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1627 attributes in their own structure. Needed when accessing their
1628 properties before they are resolved.
1630 2009-03-09 Marek Safar <marek.safar@gmail.com>
1632 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1633 hashtable (~10x faster).
1635 * driver.cs: Removed wrong Reset.
1637 2009-03-08 Marek Safar <marek.safar@gmail.com>
1639 * class.cs: Use correct common base type for unmanaged delayed
1642 * rootcontext.cs: Wrap unhandled exception.
1644 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1646 Make SeekableStreamReader self-tuning and arbitrarily seekable
1647 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1649 (SeekableStreamReader.Position.set): Use it. Simplify logic
1650 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1651 buffer size when the stream needs to be re-read from the beginning.
1653 2009-03-05 Marek Safar <marek.safar@gmail.com>
1655 A fix for bug #480100
1656 * parameter.cs: A parameter is not hoisted when used directly as ET.
1658 2009-03-04 Marek Safar <marek.safar@gmail.com>
1660 * statement.cs: Fixed an issue when using variable is of interface
1663 2009-03-03 Marek Safar <marek.safar@gmail.com>
1665 A fix for bug #480319
1666 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1668 2009-03-03 Marek Safar <marek.safar@gmail.com>
1670 A fix for bug #480867
1671 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1672 expression to have no valid type.
1674 2009-03-03 Marek Safar <marek.safar@gmail.com>
1676 A fix for bug #481258
1677 * class.cs: Set extension method flag in partial container.
1679 2009-03-03 Marek Safar <marek.safar@gmail.com>
1681 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1683 * attribute.cs: Add sanity check.
1685 2009-02-27 Marek Safar <marek.safar@gmail.com>
1687 * class.cs: Add external constructor error.
1689 2009-02-26 Marek Safar <marek.safar@gmail.com>
1691 A fix for bug #475354
1692 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1693 correctly user defined nullable equality operators.
1695 2009-02-25 Marek Safar <marek.safar@gmail.com>
1697 A fix for bug #479532
1698 * expression.cs: Implement NewInitialize::AddressOf.
1700 2009-02-25 Marek Safar <marek.safar@gmail.com>
1702 A fix for bug #413633
1703 * expression.cs: Iterate all base class-constraint types.
1705 2009-02-24 Marek Safar <marek.safar@gmail.com>
1707 A fix for bug #479209
1708 * literal.cs: Mutate null underlying type.
1710 2009-02-24 Marek Safar <marek.safar@gmail.com>
1712 A fix for bug #476295
1713 * convert.cs: Avoid wrapping implicitly convertible reference type.
1715 2009-02-23 Marek Safar <marek.safar@gmail.com>
1717 * iterators.cs: Create MemberName correctly.
1719 2009-02-23 Marek Safar <marek.safar@gmail.com>
1721 A fix for bug #478655
1722 * literal.cs: Check also underlying null type conversion.
1724 2009-02-21 Marek Safar <marek.safar@gmail.com>
1726 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1728 2009-02-20 Marek Safar <marek.safar@gmail.com>
1730 A fix for bug #477447
1731 * statement.cs: Add reference to correct parent storey when this
1732 is accessible from deep children storey (more than 1 level).
1734 2009-02-19 Marek Safar <marek.safar@gmail.com>
1736 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1737 * class.cs: Define base type members before setting up member cache.
1739 2009-02-18 Marek Safar <marek.safar@gmail.com>
1741 A fix for bug #477378
1742 * nullable.cs, expression.cs, statement.cs: More precise null type
1745 2009-02-18 Marek Safar <marek.safar@gmail.com>
1747 A fix for bug #472805
1748 * typemanager.cs, namespace.cs: Import only visible extension method
1751 2009-02-18 Marek Safar <marek.safar@gmail.com>
1753 A fix for bug #476895
1754 * attribute.cs: Use correct resolve context for attribute type.
1756 2009-02-18 Marek Safar <marek.safar@gmail.com>
1758 A fix for bug #476266
1759 * anonymous.cs: Mutate multi-dimensional arrays.
1761 2009-02-18 Marek Safar <marek.safar@gmail.com>
1763 A fix for bug #476400
1764 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1766 2009-02-18 Marek Safar <marek.safar@gmail.com>
1768 A fix for bug #476811
1769 * generics.cs: Fixed null-literal check.
1771 2009-02-17 Marek Safar <marek.safar@gmail.com>
1773 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1774 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1775 messing with static variables.
1777 2009-02-16 Marek Safar <marek.safar@gmail.com>
1779 A fix for bug #475965
1780 * generics.cs: Check generic parameter type after extracting from
1783 2009-02-16 Marek Safar <marek.safar@gmail.com>
1785 A fix for bug #475823
1786 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1789 2009-02-14 Marek Safar <marek.safar@gmail.com>
1791 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1792 Simplified event field definition using backing field and not
1793 field builder directly.
1795 * expression.cs (EmitLdArg): Optimize fast paths.
1797 2009-02-13 Marek Safar <marek.safar@gmail.com>
1799 A fix for bug #475327
1800 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1802 2009-02-13 Marek Safar <marek.safar@gmail.com>
1804 A fix for bug #475342
1805 * cs-parser.jay: Using 'super' instead of 'base' to call base
1806 constructor crashes compiler.
1808 2009-02-13 Marek Safar <marek.safar@gmail.com>
1810 A fix for bug #475354
1811 * expression.cs (Constantify): Add nullable types.
1813 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1815 2009-02-12 Marek Safar <marek.safar@gmail.com>
1817 A fix for bug #475246
1818 * expression.cs: More broken flowanalysis hacking needed.
1820 2009-02-12 Marek Safar <marek.safar@gmail.com>
1822 * attribute.cs: Compare only ref/out array modifiers.
1824 2009-02-11 Marek Safar <marek.safar@gmail.com>
1826 * statement.cs: Use member cache when looking for foreach members.
1828 2009-02-11 Marek Safar <marek.safar@gmail.com>
1830 * expression.cs: Don't expose internal initializer types.
1832 * statement.cs: Check also explicit conversions for goto case.
1834 2009-02-11 Marek Safar <marek.safar@gmail.com>
1836 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1838 2009-02-10 Marek Safar <marek.safar@gmail.com>
1840 * *.cs: Replace null-type with NullLiteral where appropriate.
1842 2009-02-09 Marek Safar <marek.safar@gmail.com>
1844 * expression.cs: Initializer of reference argument use temporary
1845 variable to be verifiable.
1847 * parameter.cs: Share EmitLdArg.
1849 2009-02-09 Marek Safar <marek.safar@gmail.com>
1851 A fix for bug #473559
1852 * class.cs: Fixed: Not reporting error about nested class with the
1855 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1857 Contributed under the MIT/X11 license.
1859 * generic.cs: Added VerifyVariantTypeParameters which performs new
1860 variance verification logic. The old logic, based on the spec, was
1861 wrong because the spec is full of LIES!
1863 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1865 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1868 * ecore.cs: Added calls to the new variance verification logic.
1871 * delegate.cs: Removed calls to the old variance verification logic.
1873 2009-02-06 Marek Safar <marek.safar@gmail.com>
1875 * delegate.cs: Use cached Invoke method directly.
1877 2009-02-06 Marek Safar <marek.safar@gmail.com>
1879 * expression.cs: Emit expression tree for hoisted variable access.
1881 2009-02-04 Marek Safar <marek.safar@gmail.com>
1883 * namespace.cs: Add better extension class check.
1885 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
1887 * generic.cs: Fixed typeo (TypeParameter.Variacne).
1889 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
1891 This patch adds initial generic variance support to the compiler.
1892 It is contributed under the MIT/X11 license.
1894 * typemanager.cs: Modified ImplementsInterface to check variance.
1895 Added VerifyVariantTypeParameters which checks the specified type to see
1896 if it uses a variant type parameter as a type argument (which is not
1897 allowed). Added IsVariantOf which determins if the first type is a
1898 variant of the second. NOTE: This only supports reference types at
1899 the moment to conform with the current level of VM support. When the
1900 VM supports value types, this will follow step.
1902 * generic.cs: Added the Variance enum. Added a Variance property to
1903 TypeParameter and added variance support to definition phase. Added a
1904 Variance property to TypeParameterName. Also check to make sure that
1905 no variant types appear in generic method parameters.
1907 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
1908 keywords if the langversion supports it.
1910 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
1911 that variant types are only used in legal positions. Also added
1912 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
1915 * decl.cs: Construct TypeParameter with the variance information.
1917 * convert.cs: Checks variance in ImplicitReferenceConversionExists
1918 and ImplicitConversionStandard.
1920 * rootcontext.cs: Added new "Future" language version.
1922 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
1923 type parameters are not used as type arguments in interface inheritance.
1924 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
1925 parameters are not used as method return types. In MemberBase.
1926 ResolveMemberType, ensure that variant type parameters are not used
1927 as type arguments. Also call VerifyNoVariantTypeParameters on every
1928 set of parameters which are resolved.
1930 * delegate.cs: Modified Delegate.Define to ensure that variant
1931 parameters are not used as type arguments and that a contravariant
1932 parameter is not used as the return type. Also call
1933 VerifyNoVariantTypeParameters on the delegate parameters.
1935 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
1936 to specify generic variance.
1938 * driver.cs: Added support for LanguageVersion.Future in the form of
1939 "-langversion:future".
1941 * generic-mcs.cs: Stubbed out new members in generic.cs.
1943 2009-02-03 Marek Safar <marek.safar@gmail.com>
1945 * class.cs, generic.cs: Emit type parameter constraints for nested
1948 2009-02-02 Marek Safar <marek.safar@gmail.com>
1950 A fix for bug #471213
1951 * class.cs: Avoid emitting backing field for abstract event fields.
1953 2009-02-01 Marek Safar <marek.safar@gmail.com>
1955 A fix for bug #359731
1956 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
1959 2009-01-30 Marek Safar <marek.safar@gmail.com>
1961 A fix for bug #470767
1962 * statement.cs: Introduced BlockScopeExpression, needed when
1963 expression tree conversion has to emit scope variables.
1965 2009-01-29 Marek Safar <marek.safar@gmail.com>
1967 * class.cs: Remove duplicate CallingConvention.
1969 2009-01-29 Marek Safar <marek.safar@gmail.com>
1971 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
1972 when I finally found the right naming convention.
1974 2009-01-29 Marek Safar <marek.safar@gmail.com>
1976 * cs-tokenizer.cs: Put back different open parens optimization.
1978 2009-01-28 Marek Safar <marek.safar@gmail.com>
1980 A fix for bug #470227
1981 * cs-tokenizer.cs: Remove too agressive parser optimization.
1983 2009-01-28 Marek Safar <marek.safar@gmail.com>
1985 A fix for bug #324319
1986 * class.cs: Remove too early base type resolve.
1988 2009-01-27 Marek Safar <marek.safar@gmail.com>
1990 A fix for bug #324319
1991 * ecore.cs: Explicitly type null when assigning to type argument to
1992 make pass verifier check.
1994 2009-01-27 Marek Safar <marek.safar@gmail.com>
1996 * anonymous.cs: Fixed recent regression when initializing captured
1999 2009-01-26 Marek Safar <marek.safar@gmail.com>
2001 A fix for bug #469019
2002 * anonymous.cs: Use all parent type parameters when instantiating
2003 nested generic storey.
2005 2009-01-26 Marek Safar <marek.safar@gmail.com>
2007 * expression.cs: Check for null instance methodgroup expression.
2009 2009-01-26 Marek Safar <marek.safar@gmail.com>
2011 A fix for bug #469244
2012 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2013 instance inside a conditional expression.
2015 2009-01-23 Marek Safar <marek.safar@gmail.com>
2017 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2018 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2019 GetElementType and HasElementType. IsValueType clean up.
2021 2009-01-23 Marek Safar <marek.safar@gmail.com>
2023 * nullable.cs: Use common EmitCall.
2025 * expression.cs: Emit constraint. for virtual calls only.
2027 2009-01-23 Marek Safar <marek.safar@gmail.com>
2029 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2030 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2031 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2034 2009-01-22 Jb Evain <jbevain@novell.com>
2036 * anonymous.cs: make anonymous types' ToString implementation
2037 match what csc outputs.
2039 2009-01-21 Marek Safar <marek.safar@gmail.com>
2041 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2044 2009-01-17 Marek Safar <marek.safar@gmail.com>
2046 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2049 2009-01-16 Marek Safar <marek.safar@gmail.com>
2051 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2054 2009-01-15 Marek Safar <marek.safar@gmail.com>
2056 A fix for bug #466634
2057 * statement.cs: Add reference for nested storey when only this
2060 2009-01-15 Marek Safar <marek.safar@gmail.com>
2062 A fix for bug #466474
2063 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2066 2009-01-15 Marek Safar <marek.safar@gmail.com>
2068 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2069 Fixed nested stories parent referencing process. Also fixes #463985.
2071 2009-01-06 Marek Safar <marek.safar@gmail.com>
2073 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2074 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2075 implementation. Also fixes #463108.
2077 2009-01-05 Marek Safar <marek.safar@gmail.com>
2079 A fix for bug #416109
2080 * decl.cs: Issue correct CLSAttribute warning location.
2082 2009-01-05 Marek Safar <marek.safar@gmail.com>
2084 A fix for bug #456775
2085 * attribute.cs: Use attribute owner scope when resolving attribute
2088 2009-01-05 Marek Safar <marek.safar@gmail.com>
2090 A fix for bug #457257
2091 * decl.cs: Fixed incorrect member declaring type comparison.
2093 2009-01-05 Marek Safar <marek.safar@gmail.com>
2095 A fix for bug #460896
2096 * driver.cs: Handle /RES resources as embeddable.
2098 2009-01-05 Marek Safar <marek.safar@gmail.com>
2100 A fix for bug #462515
2101 * ecore.cs: Report inacessible members upwards.
2103 2009-01-05 Marek Safar <marek.safar@gmail.com>
2105 A fix for bug #463190, #463192
2106 * decl.cs, namespace.cs: Also import internal extension classes.
2108 2009-01-04 Marek Safar <marek.safar@gmail.com>
2110 A fix for bug #463415
2111 * generic.cs: Use right index for RemoveDependentTypes.
2113 2009-01-02 Marek Safar <marek.safar@gmail.com>
2115 A fix for bug #463196
2116 * expression.cs: Fixed enum to null comparison.
2118 2009-01-02 Marek Safar <marek.safar@gmail.com>
2120 A fix for bug #463121
2121 * nullable.cs: Fixed nullable user equality operator comparison.
2123 2009-01-02 Marek Safar <marek.safar@gmail.com>
2125 A fix for bug #462950
2126 * class.cs, decl.cs: Use full explicit name when defining automatic
2127 property backing field.
2129 2009-01-02 Marek Safar <marek.safar@gmail.com>
2131 A fix for bug #462592
2132 * pending.cs: Emit type arguments for generic proxy method.
2134 2008-12-30 Marek Safar <marek.safar@gmail.com>
2136 * expression.cs (As): Mutate all type arguments.
2138 2008-12-29 Marek Safar <marek.safar@gmail.com>
2140 A fix for bug #462622
2141 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2144 2008-12-29 Marek Safar <marek.safar@gmail.com>
2146 A fix for bug #450782
2147 * ecore.cs: Consider more variables of form V.I to be fixed.
2149 2008-12-29 Marek Safar <marek.safar@gmail.com>
2151 A fix for bug #460712
2152 * typemanager.cs: Core types could be imported.
2154 2008-12-28 Marek Safar <marek.safar@gmail.com>
2156 A fix for bugs #460847, #460772, #458049, #457339, #447807
2157 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2158 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2159 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2160 user lambdas used inside query clauses.
2162 2008-12-18 Marek Safar <marek.safar@gmail.com>
2164 A fix for bug #460229
2165 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2167 2008-12-18 Marek Safar <marek.safar@gmail.com>
2169 A fix for bug #459952
2170 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2172 2008-12-18 Marek Safar <marek.safar@gmail.com>
2174 A fix for bug #459630
2175 * convert.cs: Enum to valuetype conversion is not allowed.
2177 2008-12-18 Marek Safar <marek.safar@gmail.com>
2179 A fix for bug #457087
2180 * generic.cs: Don't crash when constraint comes from type
2183 2008-12-16 Marek Safar <marek.safar@gmail.com>
2185 A fix for bug #459221
2186 * anonymous.cs, statement.cs: Delay only captured this
2189 2008-12-12 Marek Safar <marek.safar@gmail.com>
2191 A fix for bug #457489
2192 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2193 and initialization to capture scope initializers correctly.
2195 2008-12-11 Marek Safar <marek.safar@gmail.com>
2197 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2198 ParameterReference refactoring.
2200 2008-12-03 Marek Safar <marek.safar@gmail.com>
2202 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2203 to be imported from any assembly.
2205 2008-12-03 Marek Safar <marek.safar@gmail.com>
2207 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2208 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2209 from anonymous method and lambda expression.
2211 2008-12-01 Marek Safar <marek.safar@gmail.com>
2213 A fix for bug #448560
2214 * expression.cs (As): Box any generic type arguments to be
2217 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2219 Add tripwire for implicit conversion bugs
2220 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2222 (MethodGroupExpr.OverloadResolve): Add sanity check between
2223 IsApplicable and VerifyArgumentsCompat.
2224 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2226 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2228 Fix build break in System.Data_test
2229 * convert.cs (ImplicitConversionExists): Move NullLiteral
2231 (ImplicitStandardConversionExists): ... here.
2233 2008-11-28 Marek Safar <marek.safar@gmail.com>
2235 * literal.cs: Emit correctly explicit null to nullable cast.
2237 2008-11-28 Marek Safar <marek.safar@gmail.com>
2239 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2242 2008-11-28 Marek Safar <marek.safar@gmail.com>
2244 A fix for bug #449005
2245 * convert.cs, nullable.cs: Use only one implicit nullable
2248 2008-11-27 Marek Safar <marek.safar@gmail.com>
2250 * convert.cs, literal.cs: More Convert cleanup is needed.
2252 2008-11-27 Marek Safar <marek.safar@gmail.com>
2254 * decl.cs, class.cs: Fixed misleading error message.
2256 2008-11-26 Marek Safar <marek.safar@gmail.com>
2258 A fix for bug #449005
2259 * nullable.cs (EmitEquality): Disable optimization for user operator
2262 2008-11-25 Marek Safar <marek.safar@gmail.com>
2264 A fix for bug #447027
2265 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2266 with context variables stored as expression instances.
2268 2008-11-25 Marek Safar <marek.safar@gmail.com>
2270 A fix for bug #447027
2271 * delegate.cs: Fixed delegate VerifyMethod logic.
2273 2008-11-24 Marek Safar <marek.safar@gmail.com>
2275 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2278 2008-11-21 Marek Safar <marek.safar@gmail.com>
2280 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2281 member type resolve to follow normal flow, instead of random
2284 2008-11-21 Marek Safar <marek.safar@gmail.com>
2286 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2289 2008-11-21 Marek Safar <marek.safar@gmail.com>
2291 * const.cs: Emit decimal array constant as literal.
2293 2008-11-20 Marek Safar <marek.safar@gmail.com>
2295 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2297 2008-11-19 Marek Safar <marek.safar@gmail.com>
2299 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2300 into real property (saves 8 MB for corlib compilation).
2302 2008-11-19 Marek Safar <marek.safar@gmail.com>
2304 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2305 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2306 generic-mcs.cs: Small cleanup of TypeArguments.
2308 2008-11-18 Marek Safar <marek.safar@gmail.com>
2310 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2311 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2312 of ConstructedType expression, renamed to GenericTypeExpr.
2314 2008-11-17 Marek Safar <marek.safar@gmail.com>
2316 A fix for bug #445303
2317 * location.cs (IsConditionalDefined): Handle undefined global
2320 2008-11-17 Marek Safar <marek.safar@gmail.com>
2322 A fix for bug #444678
2323 * expression.cs (TryReduceConstant): Always create new constant
2326 2008-11-17 Marek Safar <marek.safar@gmail.com>
2328 A fix for bug #444673
2329 * ecore.cs: Ignore open generic types when used as generic type
2332 2008-11-17 Marek Safar <marek.safar@gmail.com>
2334 A fix for bug #445458
2335 * expression.cs, cs-parser.jay: Don't crash when an expression
2338 2008-11-17 Marek Safar <marek.safar@gmail.com>
2340 A fix for bug #445464
2341 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2342 inside unbound type.
2344 2008-11-14 Jb Evain <jbevain@novell.com>
2346 * driver.cs: ignore empty -nowarn argument such as
2347 the one in -nowarn:12,13,,.
2349 2008-11-13 Marek Safar <marek.safar@gmail.com>
2351 A fix for bug #444271
2352 * anonymous.cs: Rescan parent storeys when best candidate was
2355 2008-11-13 Marek Safar <marek.safar@gmail.com>
2357 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2358 useless UnboundTypeExpression.
2360 * attribute.cs: Do check obsolete attribute on generic types.
2362 2008-11-12 Marek Safar <marek.safar@gmail.com>
2364 A fix for bugs #425680, #400139
2365 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2368 2008-11-11 Marek Safar <marek.safar@gmail.com>
2370 A fix for bug #435747
2371 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2372 compound value types assignment. Few micro optimizations added.
2374 2008-11-10 Marek Safar <marek.safar@gmail.com>
2376 A fix for bug #442610
2377 * anonymous.cs (MutateConstructor): More SRE hacking.
2379 2008-11-10 Marek Safar <marek.safar@gmail.com>
2381 A fix for bug #442579
2382 * ecore.cs: Also initialize expanded form of a method with 1 params
2385 2008-11-06 Marek Safar <marek.safar@gmail.com>
2387 * expression.cs (UnaryMutator): Do early l-side check.
2389 2008-11-05 Miguel de Icaza <miguel@novell.com>
2391 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2392 Init, otherwise we would crash later on when checking for friend
2395 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2396 Otherwise we never get any meaningful information as to what
2399 2008-11-05 Marek Safar <marek.safar@gmail.com>
2401 A fix for bug #436318
2402 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2404 2008-11-05 Miguel de Icaza <miguel@novell.com>
2406 * namespace.cs: Turns out that it was a really bad idea to hide
2407 the errors for namespaces not found here in eval mode.
2409 * eval.cs: When we process using clauses, only enter those into
2410 the list of valid using clauses after they have been validated.
2412 The above change gives the proper semantics: it does not
2413 senselessly report the same errors with broken using statements by
2414 never storing them in the first place when they are invalid.
2416 2008-11-05 Marek Safar <marek.safar@gmail.com>
2418 A fix for bug #421839
2419 * cs-parser.jay: Remove expression from coalesce rule to force lower
2420 priority than the assignment operator.
2422 2008-11-05 Marek Safar <marek.safar@gmail.com>
2424 A fix for bug #437875
2425 * nullable.cs: Compile correctly method group operand used with null
2426 coalescing operator.
2428 2008-11-04 Marek Safar <marek.safar@gmail.com>
2430 A fix for bug #434589
2431 * expression.cs (Binary): Ignore lifted conversions when at least
2432 one operand is of reference type.
2434 2008-11-04 Marek Safar <marek.safar@gmail.com>
2436 * cs-parser.jay: Better syntax error report.
2438 2008-11-03 Marek Safar <marek.safar@gmail.com>
2440 A fix for bug #436792
2441 * cs-parser.jay: Use GetLocation to access location.
2443 2008-11-03 Marek Safar <marek.safar@gmail.com>
2445 A fix for bug #440774
2446 * cs-parser.jay: Also set current_array_type when parsing local
2449 2008-11-03 Marek Safar <marek.safar@gmail.com>
2451 A fix for bug #440785
2452 * expression.cs (As): Don't resolve self modifing expression
2455 2008-11-03 Marek Safar <marek.safar@gmail.com>
2457 A fix for bug #439447
2458 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2460 2008-11-03 Marek Safar <marek.safar@gmail.com>
2462 A fix for bug #437571
2463 * cs-parser.jay: Fixes internal error for invalid expression
2466 2008-10-17 Marek Safar <marek.safar@gmail.com>
2468 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2470 2008-10-17 Marek Safar <marek.safar@gmail.com>
2472 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2474 2008-10-17 Marek Safar <marek.safar@gmail.com>
2476 * cs-tokenizer.cs: More precise cast parsing.
2478 2008-10-16 Martin Baulig <martin@ximian.com>
2480 * anonymous.cs (AnonymousMethodStorey): Put back the
2481 `hoisted_locals' hashtable and use it in EmitType().
2483 2008-10-15 Marek Safar <marek.safar@gmail.com>
2485 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2486 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2489 2008-10-14 Marek Safar <marek.safar@gmail.com>
2491 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2493 2008-10-14 Marek Safar <marek.safar@gmail.com>
2495 * statement.cs: Mutate scope initializers.
2497 2008-10-14 Marek Safar <marek.safar@gmail.com>
2499 * expression.cs: Use typeless value for This constant.
2501 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2503 2008-10-14 Marek Safar <marek.safar@gmail.com>
2505 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2508 2008-10-13 Marek Safar <marek.safar@gmail.com>
2510 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2513 2008-10-13 Marek Safar <marek.safar@gmail.com>
2515 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2516 parser and tokenizer. Fixes many ambiguities including #433258.
2518 2008-10-10 Marek Safar <marek.safar@gmail.com>
2520 * cs-parser.jay: Fixed missing accessor recovery.
2522 2008-10-10 Marek Safar <marek.safar@gmail.com>
2524 A fix for bug #433701
2525 * expression.cs: Better error message.
2527 2008-10-10 Marek Safar <marek.safar@gmail.com>
2529 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2531 * Makefile: Disabled unused debug symbols.
2533 Also fixes: #320556, #321097, #321656, #321876, #351316
2535 2008-10-09 Miguel de Icaza <miguel@novell.com>
2537 * eval.cs: rename "<interactive>" to "{interactive}", to work
2538 around a requirement in the compiler that this be a valid
2539 filename, and in Windows it is not (433886).
2541 2008-10-09 Marek Safar <marek.safar@gmail.com>
2543 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2545 2008-10-08 Marek Safar <marek.safar@gmail.com>
2547 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2548 cs-parser.jay: Generic type declaration and type arguments cleanup.
2550 2008-10-05 Marek Safar <marek.safar@gmail.com>
2552 * cs-parser.jay: Allow parsing weird array creation construct.
2554 2008-10-05 Marek Safar <marek.safar@gmail.com>
2556 * cs-parser.jay: Conflicts reduction.
2558 2008-10-04 Marek Safar <marek.safar@gmail.com>
2560 * cs-parser.jay: Conflicts reduction.
2562 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2565 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2566 property. Add a 'count' hint about the use of the shared vector.
2567 Ensure that we don't leak out dirty bits.
2568 (UsageVector.MergeChild): Throw away information about variables
2570 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2572 2008-10-03 Marek Safar <marek.safar@gmail.com>
2574 A fix for bug #431746
2575 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2576 parameters when iterator is created.
2578 2008-10-03 Marek Safar <marek.safar@gmail.com>
2580 A fix for bug #431827
2581 * expression.cs: Fixed right based pointer arithmetic operations
2584 2008-10-03 Marek Safar <marek.safar@gmail.com>
2586 A fix for bug #353779
2587 * assign.cs, expression.cs: Fixed compound assignment conversions.
2589 2008-10-02 Marek Safar <marek.safar@gmail.com>
2591 A fix for bug #375262
2592 * statement.cs: Refactor ArrayForeach to be usable with string
2593 indexer. Optimized single dimentional arrays foreach.
2595 2008-10-02 Marek Safar <marek.safar@gmail.com>
2597 A fix for bug #431255
2598 * anonymous.cs, expression.cs: Removed broken optimization.
2600 2008-10-01 Marek Safar <marek.safar@gmail.com>
2602 * anonymous.cs: Use full type parameters of parent generic
2603 containers. Removed unnecessary AddParentStoreyReference call.
2605 2008-10-01 Marek Safar <marek.safar@gmail.com>
2607 A fix for bug #324702
2608 * class.cs: Use better shorter names for explicit interface member
2611 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2613 2008-10-01 Marek Safar <marek.safar@gmail.com>
2615 * expression.cs: Use new interface to check fixed expression.
2617 2008-10-01 Marek Safar <marek.safar@gmail.com>
2619 A fix for bug #421101
2620 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2621 interface to check for fixed fixed-buffers.
2623 2008-10-01 Marek Safar <marek.safar@gmail.com>
2625 A fix for bug #429264
2626 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2628 * delegate.cs: Removed unnecessary casts.
2630 2008-09-30 Marek Safar <marek.safar@gmail.com>
2632 A fix for bug #352151
2633 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2634 class.cs: Fixed already defined explicit interface members check.
2636 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2638 cs-tokenizer.cs: Fix typo.
2640 2008-09-28 Miguel de Icaza <miguel@novell.com>
2642 * eval.cs (InteractiveBase): The quit command now just sets a
2643 flag, instead of calling Environment.Exit(), it is milder on
2646 CompiledMethod is now in Mono.CSharp, not nested inside
2647 the Evaluator, it was inconvenient to use.
2649 2008-09-27 Miguel de Icaza <miguel@novell.com>
2651 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2652 code to be invoked without having to reparse.
2654 2008-09-27 Miguel de Icaza <miguel@novell.com>
2656 * ecore.cs: The recent changes to FieldExpr broke this as well.
2657 Fixes LINQ queries in the interactive shell.
2659 * Multiple files: indentation fixing for the Mono coding
2660 guidelines for the switch statement.
2662 * eval.cs: Make the Evaluator API thread safe.
2664 2008-09-26 Marek Safar <marek.safar@gmail.com>
2666 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2667 constructor parsing.
2669 2008-09-26 Marek Safar <marek.safar@gmail.com>
2671 A fix for bug #325326
2672 * statement.cs: Check possible mistaken empty statement using
2673 explicit blocks only.
2675 2008-09-25 Miguel de Icaza <miguel@novell.com>
2677 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2678 RootNamespace.ComputeNamespaces to update the internal list of
2679 namespaces, this is no longer done for us.
2681 (InteractiveBase): Use the Evaluator APIs instead of calling into
2684 2008-09-25 Marek Safar <marek.safar@gmail.com>
2686 A fix for bug #429264
2687 * expression.cs: Missing mutator for access to multidimensional
2690 2008-09-25 Marek Safar <marek.safar@gmail.com>
2692 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2695 * driver.cs: Missing input argument check.
2697 2008-09-25 Marek Safar <marek.safar@gmail.com>
2699 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2700 expression.cs, statement.cs, rootcontext.cs, class.cs,
2701 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2704 2008-09-24 Miguel de Icaza <miguel@novell.com>
2706 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2707 fully constructed FieldExpr, fixes the regression introduced in
2710 * ecore.cs, expression.cs: Plug back the eclass initialization as
2711 otherwise it regresses `csharp'.
2713 2008-09-24 Marek Safar <marek.safar@gmail.com>
2715 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2716 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2717 phase to resolve phase. It resolves problems with expression trees
2718 and fixes bugs #323796, #325156.
2720 2008-09-23 Marek Safar <marek.safar@gmail.com>
2722 * codegen.cs: Report better error when symbol writer is missing.
2724 2008-09-23 Marek Safar <marek.safar@gmail.com>
2726 * codegen.cs: Set .NET symbol writer.
2728 * decl.cs: Guard against null generic arguments.
2730 * report.cs: Don't report exactly same additional details.
2732 2008-09-22 Marek Safar <marek.safar@gmail.com>
2734 A fix for bug #324917
2735 * cs-parser.jay: Add missing multidimensional non-expression type
2738 2008-09-22 Marek Safar <marek.safar@gmail.com>
2740 A fix for bug #428191
2741 * anonymous.cs: Create an outer generic fields also for non-storey
2744 2008-09-22 Marek Safar <marek.safar@gmail.com>
2746 A fix for bug #378294
2747 * class.cs: Make fixed size buffers gmcs feature only.
2749 2008-09-22 Marek Safar <marek.safar@gmail.com>
2751 A fix for bug #355622, #324993
2752 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2755 2008-09-19 Marek Safar <marek.safar@gmail.com>
2757 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2760 2008-09-19 Marek Safar <marek.safar@gmail.com>
2762 A fix for bug #416110
2763 * generic.cs: Struct constraint results in default ctor and
2764 ValueType base type constraint to be set.
2766 2008-09-19 Marek Safar <marek.safar@gmail.com>
2768 A fix for bug #423791
2769 * generic.cs: Fixed params output type type-inference.
2771 2008-09-19 Marek Safar <marek.safar@gmail.com>
2773 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2775 2008-09-19 Marek Safar <marek.safar@gmail.com>
2777 * cs-tokenizer.cs: Don't break on extra partial modifier.
2779 2008-09-19 Marek Safar <marek.safar@gmail.com>
2781 A fix for bug #427592
2782 * generic.cs: Use common parameter resolve method.
2784 2008-09-18 Marek Safar <marek.safar@gmail.com>
2786 A fix for bug #414758
2787 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2790 2008-09-18 Marek Safar <marek.safar@gmail.com>
2792 * driver.cs, namespace.cs: Read types and namespaces after all
2793 requested assemblies are loaded, fixes issues with System.Core
2794 auto-reference, and #419888.
2796 2008-09-18 Marek Safar <marek.safar@gmail.com>
2798 A fix for bug #417705
2799 * cs-parser.jay: Fixed as/is operator expression split.
2801 2008-09-18 Marek Safar <marek.safar@gmail.com>
2803 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2804 Fixed expression tree representation of empty new expression and
2805 new initializer expression.
2807 2008-09-18 Miguel de Icaza <miguel@novell.com>
2809 * eval.cs: Remove warning, keep reference to driver around.
2811 * Hide fields that do not need to be public.
2813 2008-09-17 Marek Safar <marek.safar@gmail.com>
2815 A fix for bug #426385
2816 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2817 conversion for array elements.
2819 2008-09-17 Marek Safar <marek.safar@gmail.com>
2821 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2822 void parsing conflicts.
2824 2008-09-15 Marek Safar <marek.safar@gmail.com>
2826 A fix for bug #425601
2827 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2828 System.Core only when there is no custom ExtensionAttribute
2831 2008-09-15 Miguel de Icaza <miguel@novell.com>
2833 * namespace.cs: Do not report CS0246 (name
2835 2008-09-12 Marek Safar <marek.safar@gmail.com>
2837 A fix for bug #425669
2838 * generic.cs: Don't cache generic static anonymous method
2841 2008-09-12 Marek Safar <marek.safar@gmail.com>
2843 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2844 conflicting constraints.
2846 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2848 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2851 2008-09-12 Marek Safar <marek.safar@gmail.com>
2853 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2854 to null pointer conversion fixes.
2856 2008-09-11 Marek Safar <marek.safar@gmail.com>
2858 * cs-parser.jay, expression.cs: An implicitly typed local variable
2859 declarator cannot use an array initializer.
2861 2008-09-11 Marek Safar <marek.safar@gmail.com>
2863 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2865 2008-09-11 Marek Safar <marek.safar@gmail.com>
2867 * generic.cs (InflatedConstraints): Don't crash when constraints
2870 * cs-parser.jay: const_declarator is a block.
2872 * constant.cs: Check for not allowed NaN conversions.
2874 2008-09-10 Miguel de Icaza <miguel@novell.com>
2876 * driver.cs: Drop --shell argument, the compiler is no longer a
2879 * eval.cs: Move most of the code that deals with evaluation into
2880 this file and document the public API from repl.cs
2882 * repl.cs: Remove from here.
2884 2008-09-10 Marek Safar <marek.safar@gmail.com>
2886 A fix for bug #424684
2887 * generic.cs: Generic class constraints must come first.
2889 2008-09-09 Miguel de Icaza <miguel@novell.com>
2891 * cs-parser.jay: Improve error reporting for syntax errors in
2892 statements and expressions, we now report the expected tokens
2893 instead of reporting the useless "; expected".
2895 Drop the strings from the token declaration, it turns out that
2896 they did not do what I thought they did. Instead they were adding
2897 two sets of tokens to the tables.
2899 2008-09-09 Marek Safar <marek.safar@gmail.com>
2901 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
2902 delegate.cs: Share special type check.
2904 2008-09-09 Marek Safar <marek.safar@gmail.com>
2906 A fix for bug #423981
2907 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
2909 2008-09-09 Marek Safar <marek.safar@gmail.com>
2911 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
2914 2008-09-09 Marek Safar <marek.safar@gmail.com>
2916 A fix for bugs: #324750, #335946
2917 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
2918 lookup rule to determine ?-based tokens.
2920 2008-09-08 Miguel de Icaza <miguel@novell.com>
2922 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
2923 expressions (like event adding or removing) end up here, so we
2924 need to treat those as statements.
2926 Add LoadAssembly method.
2928 2008-09-04 Miguel de Icaza <miguel@novell.com>
2930 * repl.cs: Add Time method.
2932 2008-09-05 Marek Safar <marek.safar@gmail.com>
2934 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
2936 2008-09-05 Miguel de Icaza <miguel@novell.com>
2938 * repl.cs: Add workaround for old compilers.
2940 2008-09-04 Jb Evain <jbevain@novell.com>
2942 * repl.cs (PrettyPrint): pretty print everything that
2943 implements IDictionary, as well as IEnumerables. Also,
2944 add a quit helper property.
2946 2008-09-04 Marek Safar <marek.safar@gmail.com>
2948 * constant.cs: Better error reporting for decimal literals.
2950 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
2953 2008-09-04 Marek Safar <marek.safar@gmail.com>
2954 Miguel de Icaza <miguel@novell.com>
2956 A fix for bug #422951
2957 * assign.cs (Assign.DoResolve): Perform the type conversions
2958 checks before we attempt to initialize `New' initializers.
2960 2008-09-04 Marek Safar <marek.safar@gmail.com>
2962 A fix for bug #422853
2963 * delegate.cs (DelegateCreation): Add special handling for
2964 EmptyExpression.Null instance expression which is just another
2965 hack for undecided member instance exression.
2967 2008-09-04 Marek Safar <marek.safar@gmail.com>
2969 * expression.cs, ecore.cs: Emit full expression tree for reduced
2972 2008-09-04 Marek Safar <marek.safar@gmail.com>
2974 * expression.cs (This): Guard against multi-resolving.
2976 * ecore.cs, statement.cs (Throw): Simplified.
2978 * flowanalysis.cs: Also verify event fields.
2980 2008-09-04 Miguel de Icaza <miguel@novell.com>
2982 * assign.cs (Assign.DoResolve): Perform the type conversions
2983 checks before we attempt to initialize `New' initializers.
2985 * repl.cs (PrettyPrint): Add Hashtable prettyprint
2987 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
2990 * repl.cs: Update help.
2992 2008-09-03 Miguel de Icaza <miguel@novell.com>
2994 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
2995 handling of the default config handling, including the special
2996 treatment of System.Core assembly.
2998 Fixes the REPL processing for LINQ.
3000 2008-09-03 Marek Safar <marek.safar@gmail.com>
3002 A fix for bug #422507
3003 * expression.cs (UnboxCast): Add missing child expression mutator.
3005 2008-09-03 Marek Safar <marek.safar@gmail.com>
3007 * driver.cs: Don't self reference System.Core assembly.
3009 2008-09-03 Marek Safar <marek.safar@gmail.com>
3011 A fix for bug #422507
3012 * expression.cs (StringConcat): Add missing type mutator.
3014 2008-09-03 Marek Safar <marek.safar@gmail.com>
3016 * generic.cs (TypeInferenceContext): Follow equality rule for
3017 constructed type lower bound type inference.
3019 2008-09-02 Miguel de Icaza <miguel@novell.com>
3021 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3022 <dblank@cs.brynmawr.edu> which updates the cursor position on
3025 2008-09-02 Marek Safar <marek.safar@gmail.com>
3027 A fix for bug #367145
3028 * driver.cs: Fixed import of extension methods when using -noconfig
3031 2008-09-02 Marek Safar <marek.safar@gmail.com>
3033 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3034 version from non-generic implementation instead.
3036 2008-09-01 Marek Safar <marek.safar@gmail.com>
3038 A fix for bug #418908
3039 * class.cs: Use AddScopeStatement for field initializers.
3041 2008-09-01 Marek Safar <marek.safar@gmail.com>
3043 A fix for bug #415385
3044 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3046 2008-09-01 Marek Safar <marek.safar@gmail.com>
3048 A fix for bug #421736
3049 * iterators.cs: Don't crash on unreachable iterators.
3051 2008-09-01 Marek Safar <marek.safar@gmail.com>
3053 A fix for bug #421628
3054 * parameter.cs, attribute.cs: Clone also parameter attributes.
3056 2008-08-30 Miguel de Icaza <miguel@novell.com>
3058 * namespace.cs (LookupType): In EvalMode, try to replace
3059 the TypeBuilder from our cache with a Type as Reflection.Emit does
3060 not like to mix code from older assemblies emitted and new
3063 This sounds like a serious Mono bug that prevents multiple
3064 assemblies to be generated and consumed at the same time.
3066 * cs-parser.jay (push_current_class): Do not make interactive
3067 classes internal or private, make them public as we currently
3068 generate each new class in a new assembly.
3070 2008-08-29 Miguel de Icaza <miguel@novell.com>
3072 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3073 remove types that are entered into the global namespace during
3074 parsing so that we can remove them on failure.
3076 * cs-parser.jay: Parsing: we now keep track of types that are
3077 entered into global variables and queue those in case the parsing
3080 This happens in a few situations: during partial-input, we invoke
3081 the parser repeatedly for example with the string "class X", this
3082 would cause X to be registed, and we need to remove this
3083 registration so that another parse attempt later with say "class X {"
3084 would actually work.
3086 Additionally, if there is an error in the resolution phase, for
3087 example: "class X : NonExistant {}" th
3089 * cs-parser.jay: Be more precise with the errors being raised,
3090 instead of flagging all exceptions during parsing to be attributed
3091 to the parsing process, distinguish those from errors happening in
3092 the actions and hint that using -v would produce the actual
3095 * repl.cs: Do not load all compiler references on each reset,
3096 doing the partial reset takes care of this.
3098 2008-08-28 Miguel de Icaza <miguel@novell.com>
3100 * repl.cs: Add support for loading all the files from
3101 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3104 Introduce a micro-parser that is able to deambiguate on its input
3105 whether we are dealing with a compilation unit (namespace, class,
3106 interface, struct, delegate) declaration or a statement. This
3107 allows both declarations and statements to be entered.
3109 Set history size by default to 300 lines.
3111 Instead of distinguishing based on the parser.InteractiveResult,
3112 have only two cases: statements were parsed, or a compilation unit
3113 was. Always pull the Using statement additions from the
3114 compilation unit parse.
3116 * cs-tokenizer.cs: Rename tokens to better describe their intent
3117 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3119 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3120 EvalMode is used to trigger the lookup of global variables while
3121 StatementMode is used turn variable declarations into static
3124 * getline.cs: Allow history size to be set.
3126 2008-08-29 Marek Safar <marek.safar@gmail.com>
3128 A fix for bug #360755
3129 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3131 2008-08-29 Marek Safar <marek.safar@gmail.com>
3133 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3135 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3136 member name, it is too confusing
3138 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3140 * rootcontext.cs: Finally default to warning level 4.
3142 2008-08-28 Marek Safar <marek.safar@gmail.com>
3144 * class.cs (CheckBase): Ignore overloaded operators.
3146 2008-08-28 Marek Safar <marek.safar@gmail.com>
3148 A fix for bug #420830
3149 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3151 2008-08-28 Marek Safar <marek.safar@gmail.com>
3153 A fix for bug #420832
3154 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3156 2008-08-28 Marek Safar <marek.safar@gmail.com>
3158 A fix for bug #420386
3159 * nullables.cs: Fixed logic of nullable user comparison operators involving
3162 2008-08-28 Marek Safar <marek.safar@gmail.com>
3164 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3166 2008-08-27 Miguel de Icaza <miguel@novell.com>
3168 * repl.cs: Add support for aborting the running code with C-c.
3170 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3172 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3174 2008-08-27 Miguel de Icaza <miguel@novell.com>
3176 * cs-parser.jay (interactive_statement_list): A new set of rules
3177 for hosting statements that uses the "interactive_" prefix.
3179 * repl.cs: Add support for parsing `using' as a statement or as a
3180 directive. Deambiguating before passing this to the parser.
3182 We need to distinguish statement_expressions that occur at the
3183 toplevel vs those that occur embedded into expressions.
3185 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3186 that fixes the cursor key handling, and a history bug.
3188 2008-08-26 Miguel de Icaza <miguel@novell.com>
3190 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3191 limitations in Console, instead the 2.0 bootstrap libraries now
3192 include the Console bits.
3194 Also, remove the use of Nullables from getline.cs
3198 Interactive support for the C# compiler. Use gmcs --shell to
3199 enter a read-eval-print loop shell.
3201 Docs: http://www.mono-project.com/CsharpRepl
3203 * sources: include repl.cs here and getline.cs for gmcs.exe,
3204 everything else is getline.cs impaired.
3206 * Makefile: when bootstrapping pass a special flag
3207 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3208 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3209 This distinguishes those two cases.
3211 * repl.cs: Support for a read-eval-print loop. Will be soon
3212 refactored into eval support and then REPL on top of it.
3214 * ecore.cs: If a simplename lookup fails, before erroring out,
3215 if we are in EvalMode to resolve the name to a declaration in the
3218 This means that variable declarations that happened in previous
3219 classes (as repl puts every statement in a separate class) are
3220 made visible in this way.
3222 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3223 triggered an error due to the end of file being reached. This is
3224 used to do multi-line input, and notify the caller that the user
3225 needs to provide more text before a successful parse.
3227 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3228 to drive the evaluation with a custom wrapper.
3230 * driver.cs: Add support for --shell, and refactor some code to be
3233 * namespace.cs: Add support for serializing the contents of the
3234 namespaces and reloading them.
3236 * getline.cs: A managed implementation of ReadLine under
3237 X11/Apache2 license terms. Easy to embed in other applications as
3240 * namespace.cs: Add some functions to save and restore the
3243 * rootcontext.cs: New public field.
3245 * cs-tokenizer.cs: Add support for one of the possible characters
3246 we introduce into the token stream.
3248 This patch does not affect the regular tokenization process, the
3249 only performance hit would happen if there is an invalid character
3250 on the input string.
3252 * support.cs: Move isatty helper routine here.
3254 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3255 code generator for in-memory assemblies.
3257 2008-08-26 Marek Safar <marek.safar@gmail.com>
3259 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3260 parameter cannot be always used as a type.
3262 2008-08-21 Marek Safar <marek.safar@gmail.com>
3264 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3266 2008-08-21 Marek Safar <marek.safar@gmail.com>
3268 * convert.cs: Implement explicit array to IList<T> conversion.
3270 2008-08-20 Marek Safar <marek.safar@gmail.com>
3272 A fix for bug #362740
3273 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3275 2008-08-20 Marek Safar <marek.safar@gmail.com>
3277 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3278 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3279 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3280 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3281 handling to use just one type of infrastructure and deal with generics
3284 2008-07-23 Martin Baulig <martin@ximian.com>
3286 *** Merged this from trunk revision 108527 ***
3289 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3290 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3293 2008-08-15 Marek Safar <marek.safar@gmail.com>
3295 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3298 2008-08-15 Marek Safar <marek.safar@gmail.com>
3300 * delegate.cs: Fixed compiler crash when creating delegate using partial
3303 * typemanager.cs: MulticastDelegate is not a delegate.
3305 2008-08-14 Marek Safar <marek.safar@gmail.com>
3307 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3310 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3312 * cs-parser.jay (type): Allow 'var' in mcs too.
3313 (local_variable_type): Likewise.
3315 2008-08-14 Marek Safar <marek.safar@gmail.com>
3317 * driver.cs: Removed broken -noconfig variants.
3319 2008-08-14 Marek Safar <marek.safar@gmail.com>
3321 A fix for bug #417078
3322 * expression.cs: Emit correctly left side pointer operators.
3324 2008-08-13 Marek Safar <marek.safar@gmail.com>
3326 * generic.cs, lambda.cs: Inflate method generic arguments only.
3328 2008-08-12 Marek Safar <marek.safar@gmail.com>
3330 * class.cs: Fixed struct layout check regression.
3332 2008-08-12 Marek Safar <marek.safar@gmail.com>
3334 * cs-parser.jay, enum.cs: Simplified enum parsing.
3336 * decl.cs: Check all type parameters conflicts.
3338 * expression.cs, statement.cs, attribute.cs: More expression checks.
3340 2008-08-11 Marek Safar <marek.safar@gmail.com>
3342 * generic.cs: Add type inference types restriction.
3344 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3345 anonymous.cs, expression.cs: Allocate less accessor parameters.
3347 2008-08-08 Marek Safar <marek.safar@gmail.com>
3349 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3352 2008-08-08 Marek Safar <marek.safar@gmail.com>
3354 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3356 2008-08-07 Marek Safar <marek.safar@gmail.com>
3358 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3359 Also fixes #362146 and #381592.
3361 2008-08-07 Marek Safar <marek.safar@gmail.com>
3363 * ecore.cs: Reduced constant cannot be used as an attribute value.
3365 * cs-parser.jay: Base expression has to be a type.
3367 * expression.cs (Conditional): Uses ReducedExpression.
3369 2008-08-06 Marek Safar <marek.safar@gmail.com>
3371 A fix for bug #376826
3372 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3373 address of hoisted local variable or parameter cannot be taken.
3375 2008-08-05 Marek Safar <marek.safar@gmail.com>
3377 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3378 anonymous method inside checked/unchecked expression.
3380 2008-08-05 Marek Safar <marek.safar@gmail.com>
3382 * typemanager.cs (IsEqual): Guard against null.
3384 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3385 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3386 routine. Fixed few misleading conversion errors.
3388 2008-08-04 Marek Safar <marek.safar@gmail.com>
3390 * class.cs: Consider generics when checking cycles in struct layout.
3392 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3394 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3396 2008-08-04 Marek Safar <marek.safar@gmail.com>
3398 A fix for bug #414165
3399 * anonymous.cs: Use same anonymous implementation method for all anonymous
3402 2008-08-04 Marek Safar <marek.safar@gmail.com>
3404 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3407 2008-08-04 Marek Safar <marek.safar@gmail.com>
3409 * cs-parser.jay: Typeof argument has to be a type expression.
3411 * namespace.cs: Check alias and namespace definitions collisions.
3413 * class.cs, pending.cs: Moved explicit interface accessor implementation
3416 * delegate.cs, expression.cs: Verify special name invocations.
3418 2008-08-01 Marek Safar <marek.safar@gmail.com>
3420 * cs-parser.jay: Don't choke on empty generic type arguments.
3422 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3424 * expression.cs, ecore.cs: Minor expressions bugs.
3426 2008-08-01 Marek Safar <marek.safar@gmail.com>
3428 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3429 and added more error handling.
3431 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3433 * modifiers.cs, enum.cs: Fixed.
3435 2008-07-31 Jb Evain <jbevain@novell.com>
3437 * driver.cs: remove -pkg ability of smcs.
3439 2008-07-30 Marek Safar <marek.safar@gmail.com>
3441 * statement.cs (Switch): Correctly set empty default target for single
3444 2008-07-30 Marek Safar <marek.safar@gmail.com>
3446 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3447 string switch statement implementation to use string dictionary which
3448 significantly (2-8x) improves performance of generated code.
3450 2008-07-29 Marek Safar <marek.safar@gmail.com>
3452 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3453 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3455 2008-07-29 Marek Safar <marek.safar@gmail.com>
3457 A fix for bug #412595
3458 * typemanager.cs, convert.cs, expression.cs: Some types are never
3459 convertible to each other.
3461 2008-07-29 Marek Safar <marek.safar@gmail.com>
3463 * nullable.cs (CreateNullConstant): An error messages update.
3465 2008-07-29 Marek Safar <marek.safar@gmail.com>
3467 A fix for bug #412595
3468 * cfold.cs: Don't cast undefined bool constant.
3470 2008-07-29 Martin Baulig <martin@ximian.com>
3473 (SymbolWriter.Reset): New public static method.
3476 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3478 2008-07-28 Marek Safar <marek.safar@gmail.com>
3480 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3482 * expression.cs (ElementAccess): Exact size allocation.
3484 2008-07-26 Marek Safar <marek.safar@gmail.com>
3486 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3488 2008-07-25 Marek Safar <marek.safar@gmail.com>
3490 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3492 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3495 2008-07-25 Marek Safar <marek.safar@gmail.com>
3497 A fix for bug #412217
3498 * assign.cs: Mutate also assignment type.
3500 2008-07-25 Marek Safar <marek.safar@gmail.com>
3502 A fix for bug #323644
3503 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3506 2008-07-25 Marek Safar <marek.safar@gmail.com>
3508 A fix for bug #412134
3509 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3510 non-enumerable operands when overloading equality or bitwise operators.
3512 2008-07-25 Marek Safar <marek.safar@gmail.com>
3514 * anonymous.cs: Cache closed generic anonymous method delegates.
3516 2008-07-24 Marek Safar <marek.safar@gmail.com>
3518 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3519 anonymous.cs, statement.cs: Always emit anonymous method as static method
3520 when is instance free. Use nesting for nested anynomous methods blocks.
3522 2008-07-23 Marek Safar <marek.safar@gmail.com>
3524 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3527 2008-07-23 Marek Safar <marek.safar@gmail.com>
3529 * expression.cs: Removed MakeSimpleCall.
3531 2008-07-23 Marek Safar <marek.safar@gmail.com>
3533 A fix for bug #323012
3534 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3535 Base method implementing interface has to be public.
3537 2008-07-23 Marek Safar <marek.safar@gmail.com>
3539 * cs-parser.jay: Don't break on missing argument.
3541 2008-07-22 Marek Safar <marek.safar@gmail.com>
3543 A fix for bug #320993
3544 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3545 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3547 2008-07-22 Marek Safar <marek.safar@gmail.com>
3549 A fix for bug #320748
3550 * convert.cs: Implicit user operators cannot convert to interfaces
3552 2008-07-22 Marek Safar <marek.safar@gmail.com>
3554 A fix for bug #312686
3555 * driver.cs: Ignore empty assembly references.
3557 2008-07-22 Marek Safar <marek.safar@gmail.com>
3559 A fix for bug #387040
3560 * ecore.cs: Skip constrains check for an explicit implementation.
3562 2008-07-21 Marek Safar <marek.safar@gmail.com>
3564 A fix for bug #409045
3565 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3566 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3567 identifiers are file specific unless passed as input arguments.
3569 2008-07-21 Marek Safar <marek.safar@gmail.com>
3571 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3572 to emit UnmanagedMarshal data under 2.0 profile.
3574 2008-07-21 Marek Safar <marek.safar@gmail.com>
3576 A fix for bug #410369
3577 * parameter.cs: Clone correctly ParamsParameter.
3579 2008-07-21 Marek Safar <marek.safar@gmail.com>
3581 * expression.cs (Argument): Always report type for type based expressions
3584 2008-07-18 Marek Safar <marek.safar@gmail.com>
3586 A fix for bug #410666
3587 * anonymous.cs: Correctly initialize generic storey reference.
3589 2008-07-18 Marek Safar <marek.safar@gmail.com>
3591 * convert.cs: Don't box same type arguments.
3593 2008-07-18 Marek Safar <marek.safar@gmail.com>
3595 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3596 Finished missing generic type mutators.
3598 2008-07-18 Marek Safar <marek.safar@gmail.com>
3600 * iterators.cs, statement.cs: Finished statements CloneTo.
3602 2008-07-18 Marek Safar <marek.safar@gmail.com>
3604 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3606 * expression.cs: Emit optimized default value expressions in expression tree
3609 2008-07-18 Marek Safar <marek.safar@gmail.com>
3611 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3613 2008-07-17 Marek Safar <marek.safar@gmail.com>
3615 A fix for bug #367536
3616 * cs-parser.jay: Check static constructor of generic types for an access
3619 2008-07-17 Marek Safar <marek.safar@gmail.com>
3621 A fix for bug #353800
3622 * lambda.cs: Emit ret for contextual statements.
3624 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3625 up emitting redundant ret for all anonymous methods with return.
3627 2008-07-17 Marek Safar <marek.safar@gmail.com>
3629 A fix for bug #365188
3630 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3631 create anonymous method storey in unreachable block.
3633 2008-07-17 Marek Safar <marek.safar@gmail.com>
3635 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3636 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3637 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3638 statement.cs: Fixed relevant defects found by Gendarme.
3640 2008-07-17 Marek Safar <marek.safar@gmail.com>
3642 A fix for bug #325291
3643 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3644 statement.cs: Replaced IAnonymousHost with top level block flag.
3646 2008-07-17 Marek Safar <marek.safar@gmail.com>
3648 * cs-parser.jay: Clean up unused open_parens.
3650 2008-07-17 Marek Safar <marek.safar@gmail.com>
3652 * ecore.cs: Custom error message for a range variable assignment.
3654 2008-07-16 Marek Safar <marek.safar@gmail.com>
3656 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3659 2008-07-16 Marek Safar <marek.safar@gmail.com>
3661 * literal.cs: Null literal is of object type.
3663 2008-07-16 Marek Safar <marek.safar@gmail.com>
3665 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3666 expression of nullable equality comparison.
3668 2008-07-15 Marek Safar <marek.safar@gmail.com>
3670 * expression.cs(PointerArithmetic): Removed redundant assignment.
3672 2008-07-15 Marek Safar <marek.safar@gmail.com>
3674 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3676 2008-07-14 Marek Safar <marek.safar@gmail.com>
3678 A fix for bug #408361
3679 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3680 they are replaced by GetMethod.
3682 2008-07-14 Marek Safar <marek.safar@gmail.com>
3684 A fix for bug #408721 by jeremie.laval@gmail.com
3685 * expression.cs (Indirection): Implemented CloneTo.
3687 2008-07-14 Marek Safar <marek.safar@gmail.com>
3689 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3692 2008-07-14 Marek Safar <marek.safar@gmail.com>
3694 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3696 2008-07-11 Marek Safar <marek.safar@gmail.com>
3698 * linq.cs: Reset tranparent parameter counter in probing mode.
3700 2008-07-11 Marek Safar <marek.safar@gmail.com>
3702 * anonymous.cs: Mutate anonymous method type.
3704 2008-07-11 Marek Safar <marek.safar@gmail.com>
3706 * ecore.cs, anonymous.cs: Mutate field expressions.
3708 2008-07-10 Marek Safar <marek.safar@gmail.com>
3710 A fix for bug #369670
3711 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3713 2008-07-10 Marek Safar <marek.safar@gmail.com>
3715 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3717 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3720 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3721 only one '>', and finds a '>>', abort the generic lookahead.
3723 2008-07-10 Marek Safar <marek.safar@gmail.com>
3725 A fix for bug #319902
3726 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3728 2008-07-10 Marek Safar <marek.safar@gmail.com>
3730 A fix for bug #406371
3731 * statement.cs: Moved EmitSymbolInfo to Block.
3733 2008-07-09 Marek Safar <marek.safar@gmail.com>
3735 * ecore.cs: Report better error for extension method overload failures.
3737 2008-07-09 Marek Safar <marek.safar@gmail.com>
3739 * expression.cs (Is): No need to box reference values.
3741 2008-07-09 Marek Safar <marek.safar@gmail.com>
3743 * class.cs: Use event resolve context when initializing CreateEmitContext.
3745 2008-07-09 Marek Safar <marek.safar@gmail.com>
3747 A fix for bug #394436
3748 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3749 method used inside expression trees. Added more LINQ to expression tree
3752 2008-07-08 Marek Safar <marek.safar@gmail.com>
3754 A fix for bug #378189, #370577
3755 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3758 2008-07-08 Marek Safar <marek.safar@gmail.com>
3760 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3763 2008-07-08 Marek Safar <marek.safar@gmail.com>
3765 A fix for bug #406702
3766 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3768 2008-07-07 Marek Safar <marek.safar@gmail.com>
3770 A fix for bug #406648
3771 * cs-parser.jay: Report nullable use in mcs for some cases.
3773 2008-07-07 Marek Safar <marek.safar@gmail.com>
3775 * ecore.cs: Improved argument mismatch error messages.
3777 2008-07-07 Marek Safar <marek.safar@gmail.com>
3779 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3781 2008-07-07 Marek Safar <marek.safar@gmail.com>
3783 * expression.cs (TypeOf): Mutate type argument.
3785 2008-07-04 Marek Safar <marek.safar@gmail.com>
3787 * class.cs: Report missing partial modifier for correct type.
3789 2008-07-04 Marek Safar <marek.safar@gmail.com>
3791 * ecore.cs, expression.cs (VariableReference): Variable property is
3794 2008-07-04 Marek Safar <marek.safar@gmail.com>
3796 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3798 2008-07-04 Marek Safar <marek.safar@gmail.com>
3800 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3803 2008-07-04 Marek Safar <marek.safar@gmail.com>
3805 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3806 anonymous method storey to an instance method when only "this" is hoisted.
3808 2008-07-03 Marek Safar <marek.safar@gmail.com>
3810 A fix for bug #321615
3811 * expression.cs: Pointer comparisons use unsigned operator.
3813 2008-07-03 Marek Safar <marek.safar@gmail.com>
3815 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3817 2008-07-02 Marek Safar <marek.safar@gmail.com>
3819 A fix for bug #404905
3820 * class.cs: Always initialize local unsafe variables.
3822 2008-06-30 Marek Safar <marek.safar@gmail.com>
3824 A fix for bug #396987
3825 * expression.cs (NewInitialize): Clear local temporary variable for next run
3827 2008-06-27 Marek Safar <marek.safar@gmail.com>
3829 A fix for bug #401020
3830 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3832 2008-06-27 Marek Safar <marek.safar@gmail.com>
3834 A fix for bug #398319
3835 * cs-parser.jay: Implemented undocumented base access expression inside
3838 2008-06-26 Marek Safar <marek.safar@gmail.com>
3840 A fix for bug #404227
3841 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3843 2008-06-26 Marek Safar <marek.safar@gmail.com>
3845 A fix for bug #404227
3846 * convert.cs: Fixed explicit array to interface cast.
3848 2008-06-26 Marek Safar <marek.safar@gmail.com>
3850 A fix for bug #403894
3851 * delegate.cs: Mutate DelegateInvocation type.
3853 2008-06-26 Marek Safar <marek.safar@gmail.com>
3855 A fix for bug #379348
3856 * delegate.cs: Box a load of generic parameters.
3858 2008-06-26 Marek Safar <marek.safar@gmail.com>
3860 * expression.cs: Add an array creation arguments mutate.
3862 2008-06-26 Marek Safar <marek.safar@gmail.com>
3864 A fix for bug #386068
3865 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3868 2008-06-25 Marek Safar <marek.safar@gmail.com>
3870 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
3873 2008-06-25 Marek Safar <marek.safar@gmail.com>
3875 A fix for bug #403518
3876 * delegate.cs: Type correctly anonymous method new invocation.
3878 2008-06-24 Marek Safar <marek.safar@gmail.com>
3880 A fix for bug #394826
3881 * anonymous.cs: Fully qualify members when resolving anonymous type internal
3884 2008-06-24 Marek Safar <marek.safar@gmail.com>
3886 A fix for bug #394826
3887 * anonymous.cs, iterators.cs: Construct generic storey only when is really
3890 2008-06-24 Marek Safar <marek.safar@gmail.com>
3892 * class.cs: Clone indexer parameters for localized capturing.
3894 2008-06-24 Marek Safar <marek.safar@gmail.com>
3896 A fix for bug #402379
3897 * expression.cs: Don't crash when an object initializer resolve fails.
3899 2008-06-24 Marek Safar <marek.safar@gmail.com>
3901 A fix for bug #402888
3902 * expression.cs: Mutate conditional expression.
3904 2008-06-24 Marek Safar <marek.safar@gmail.com>
3906 A fix for bug #401012
3907 * class.cs: Keep StructLayout in shared container.
3909 2008-06-24 Marek Safar <marek.safar@gmail.com>
3911 A fix for bug #400438
3912 * decl.cs, class.cs: Only properties can be automatically implemented.
3914 2008-06-24 Marek Safar <marek.safar@gmail.com>
3916 * statement.cs (ChangeToIterator): Copy also labels.
3918 2008-06-23 Marek Safar <marek.safar@gmail.com>
3920 * ecore.cs: Pass type argument details to parent extension method.
3922 2008-06-23 Marek Safar <marek.safar@gmail.com>
3924 A fix for bug #375966
3925 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
3927 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
3929 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
3931 2008-06-22 Marek Safar <marek.safar@gmail.com>
3933 A fix for bug #394347
3934 * anonymous.cs: Cache compatible delegates as compatibility check produces
3935 a new method every time.
3937 2008-06-20 Marek Safar <marek.safar@gmail.com>
3939 * anonymous.cs: Propagate storey reference for single references.
3941 2008-06-20 Marek Safar <marek.safar@gmail.com>
3943 A fix for bug #387615
3944 * assign.cs, expression.cs: Correctly clone compound assignment.
3946 2008-06-19 Marek Safar <marek.safar@gmail.com>
3948 A fix for bug #359611, #359604
3949 * anonymous.cs: Mutate all types of hoisted parameters.
3951 2008-06-19 Marek Safar <marek.safar@gmail.com>
3953 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
3954 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
3955 expression.cs, codegen.cs, statement.cs
3957 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
3958 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
3960 ** Anonymous methods, lambda expressions rewrite **
3962 Anonymous expressions are now resolved when an explicit block is resolved
3963 and they don't require any registration procedure anymore. Further,
3964 anonymous methods are defined when explicit block is emitted which allows
3965 better control of whole process and opens possibilities for more
3966 optimizations as well as alternative to reverse whole process.
3968 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
3969 process consistent and to correctly emit hoisted generic methods when they
3970 have at least 1 hoisted variable.
3972 2008-06-17 Martin Baulig <martin@ximian.com>
3974 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
3976 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
3977 virtual property; check it in Emit().
3978 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
3980 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
3982 (Indexer.Define): Likewise.
3984 2008-06-17 Marek Safar <marek.safar@gmail.com>
3986 * convert.cs: Don't use IsInterface on type arguments.
3988 * delegate.cs: DelegateInvocation uses MethodInfo.
3990 * parameter.cs: Removed IsTypeParameter.
3992 * generic-mcs.cs: More missing stuff.
3994 2008-06-16 Martin Baulig <martin@ximian.com>
3997 (Modifiers.DEBUGGER_HIDDEN): New public const.
4000 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4003 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4004 (AbstractPropertyEventMethod): Likewise.
4005 (Constructor.Emit): Likewise.
4006 (SourceMethod.SetCompilerGenerated): Removed.
4008 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4012 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4013 if we're an `IteratorHost'.
4014 (AnonymousMethodMethod..ctor): Don't set
4015 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4018 2008-06-16 Marek Safar <marek.safar@gmail.com>
4020 * statement.cs: Clean-up foreach statements.
4022 2008-06-12 Marek Safar <marek.safar@gmail.com>
4024 * class.cs: Stop using public method which should not exist
4025 (MethodBuilder.SetGenericMethodSignature).
4027 2008-06-11 Martin Baulig <martin@ximian.com>
4030 (Location.LookupFile): Add `CompilationUnit' argument; when given
4031 a relative file name, make it relative to the directory the .cs
4032 file is located in instead of using the current directory.
4034 2008-06-11 Martin Baulig <martin@ximian.com>
4037 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4038 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4039 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4040 (SourceMethod.SetCompilerGenerated): Likewise.
4042 2008-06-11 Marek Safar <marek.safar@gmail.com>
4044 * codegen.cs, driver: Only write symbol file when it's asked for.
4046 2008-06-11 Marek Safar <marek.safar@gmail.com>
4048 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4050 2008-06-10 Martin Baulig <martin@ximian.com>
4052 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4054 2008-06-09 Marek Safar <marek.safar@gmail.com>
4056 A fix for bug #316290
4057 * expression.cs: Include decimal operators in predefined table.
4059 * parameters.cs: More readonlyness.
4061 2008-06-09 Marek Safar <marek.safar@gmail.com>
4063 A fix for bug #397213
4064 * cs-parser.jay: One more missing current_local_parameters reset.
4066 2008-06-09 Marek Safar <marek.safar@gmail.com>
4068 A fix for bug #396633
4069 * class.cs: Host backing field in partial container.
4071 2008-06-09 Marek Safar <marek.safar@gmail.com>
4073 A fix for bug #397068
4074 * expression.cs: Check both operand types when predefined operator is used.
4076 2008-06-05 Martin Baulig <martin@ximian.com>
4078 Merged the `debugger-kahalo' branch.
4081 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4082 we're an iterator method.
4083 (SourceMethod): Reflect latest symbol writer changes;
4084 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4085 now `start_row' and `end_row'.
4086 (Constructor.Emit): Fix the logic whether to emit symbol information.
4088 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4092 (CompilationUnit): New public class; derives from `SourceFile'.
4093 (SourceFileEntry.DefineSymbolInfo): New public method.
4094 (SourceFileEntry.SetChecksum): New public method.
4095 (Location): Encode hidden line numbers by using `column == 255';
4096 the .ctor now accepts `column == -1' to mark a hidden line number.
4097 (Location.Hidden): New public property.
4098 (Location.CheckPoint): Add `CompilationUnit'.
4099 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4100 (Location.Push): Add `CompilationUnit compile_unit' argument.
4101 (Location.CompilationUnit): New public property.
4104 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4106 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4108 * driver.cs: `SourceFile' -> `CompilationUnit'.
4110 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4112 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4114 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4118 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4119 new symbol writer API to also pass the file.
4121 2008-06-05 Marek Safar <marek.safar@gmail.com>
4123 * statement.cs: Emit catch variable assignment using variable expression.
4125 2008-06-05 Marek Safar <marek.safar@gmail.com>
4127 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4128 with other variable types.
4130 2008-06-04 Marek Safar <marek.safar@gmail.com>
4132 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4133 GetLength method emit, it breaks resolve rules.
4135 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4136 Marek Safar <marek.safar@gmail.com>
4138 A fix for bug #395542
4139 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4142 2008-06-02 Marek Safar <marek.safar@gmail.com>
4144 A fix for bug #395287
4145 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4147 2008-05-31 Marek Safar <marek.safar@gmail.com>
4149 A fix for bug #395845
4150 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4151 non-nullable parameter type.
4153 2008-05-31 Marek Safar <marek.safar@gmail.com>
4155 * class.cs: Handle contructor initializer as a statement in top-level block.
4157 2008-05-30 Marek Safar <marek.safar@gmail.com>
4159 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4160 security attributes.
4162 2008-05-24 Marek Safar <marek.safar@gmail.com>
4164 * ecore.cs, expression.cs: Small IVariable refactoring.
4166 2008-05-22 Marek Safar <marek.safar@gmail.com>
4168 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4170 2008-05-21 Marek Safar <marek.safar@gmail.com>
4172 * cs-parser.jay: Removed redundant catch type check.
4174 2008-05-21 Marek Safar <marek.safar@gmail.com>
4176 A fix for bug #390372
4177 * nullable.cs: Set correct return type.
4179 2008-05-21 Marek Safar <marek.safar@gmail.com>
4181 A fix for bug #391062
4182 * typemanager.cs: Fixed crash when comparing null types.
4184 2008-05-21 Marek Safar <marek.safar@gmail.com>
4186 A fix for bug #391871
4187 * cs-parser.jay: Better error handling for invalid catch type.
4189 2008-05-20 Marek Safar <marek.safar@gmail.com>
4191 A fix for bug #392155
4192 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4194 2008-05-15 Marek Safar <marek.safar@gmail.com>
4196 A fix for bug #390666
4197 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4200 2008-05-15 Marek Safar <marek.safar@gmail.com>
4202 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4205 2008-05-13 Marek Safar <marek.safar@gmail.com>
4207 A fix for bug #389625
4208 * delegate.cs, generic.cs: Some progress on method group return type
4211 2008-05-13 Marek Safar <marek.safar@gmail.com>
4213 A fix for bug #378419
4214 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4216 2008-05-12 Marek Safar <marek.safar@gmail.com>
4218 * class.cs (Constructor): Added IsCompilerGenerated.
4220 2008-05-12 Marek Safar <marek.safar@gmail.com>
4222 * expression.cs: Enum binary operators can accept non-enum operand only when
4223 is implicitly convertible to underlying type.
4225 2008-05-12 Marek Safar <marek.safar@gmail.com>
4227 A fix for bug #389272
4228 * support.cs: Workaround System.InvalidOperationException for enums.
4230 2008-05-12 Marek Safar <marek.safar@gmail.com>
4232 A fix for bug #389073
4233 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4235 2008-05-10 Marek Safar <marek.safar@gmail.com>
4237 * driver.cs: Split Parse.
4239 * location.cs (LookupFile): Uses string.Empty.
4241 2008-05-07 Marek Safar <marek.safar@gmail.com>
4243 * expression.cs, parameter.cs: Small ParameterReference clean up.
4245 2008-05-07 Marek Safar <marek.safar@gmail.com>
4247 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4248 hack. Fixes #387502.
4250 2008-05-06 Martin Baulig <martin@ximian.com>
4252 * class.cs (Constructor.Emit): Fix the logic whether to emit
4255 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4258 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4259 InvalidOperationException when the iterator is before the start or
4262 2008-05-06 Marek Safar <marek.safar@gmail.com>
4264 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4265 when left is nullable type.
4267 2008-05-06 Marek Safar <marek.safar@gmail.com>
4269 A fix for bug #386628
4270 * expression.cs (LocalVariableReference): Continue in resolving when
4271 variable is not assigned.
4273 2008-05-05 Marek Safar <marek.safar@gmail.com>
4275 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4276 nullable operations.
4278 2008-05-04 Marek Safar <marek.safar@gmail.com>
4280 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4281 it saves many redundant temporary variables for nullable operations.
4283 2008-05-03 Marek Safar <marek.safar@gmail.com>
4285 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4287 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4290 * nullable.cs: Constant coalescing operator optimizations.
4292 2008-05-03 Marek Safar <marek.safar@gmail.com>
4294 * constant.cs: Use unsigned conversion for values which are unsigned only.
4296 2008-05-03 Marek Safar <marek.safar@gmail.com>
4298 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4299 coalescing operator as it should be.
4301 2008-05-02 Marek Safar <marek.safar@gmail.com>
4303 A fix for bug #371016
4304 * expression.cs: All predefined delegate operators require implicit method
4307 2008-05-02 Marek Safar <marek.safar@gmail.com>
4309 * constant.cs: Emit long constant as uint when fits the range.
4311 * convert.cs, expression.cs: Fixed few unsafe conversions.
4313 2008-05-02 Marek Safar <marek.safar@gmail.com>
4315 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4317 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4320 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4322 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4324 2008-05-01 Marek Safar <marek.safar@gmail.com>
4326 * constant.cs, literal.cs: IsLiteral property for error reporting.
4328 * ecore.cs, expression.cs: Implemented Property expression.
4330 2008-05-01 Marek Safar <marek.safar@gmail.com>
4332 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4334 * nullable.cs: Implemented nullable coalescing null operator.
4336 * ecore.cs, expression.cs: Expression trees work.
4338 2008-05-01 Marek Safar <marek.safar@gmail.com>
4340 * ecore.cs: CreateExpressionTree is finally abstract.
4342 * expression.cs, linq.cs: Updated.
4344 2008-05-01 Marek Safar <marek.safar@gmail.com>
4346 * expression.cs, ecore.cs: Block base access expression inside expression
4349 2008-05-01 Marek Safar <marek.safar@gmail.com>
4351 A fix for bug #385058
4352 * expression.cs: User-defined operator implementations always take
4353 precedence over predefined operator implementations.
4355 2008-04-30 Marek Safar <marek.safar@gmail.com>
4357 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4358 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4359 expression tree conversions.
4361 2008-04-30 Marek Safar <marek.safar@gmail.com>
4363 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4364 operators method details to Operator class.
4366 2008-04-30 Marek Safar <marek.safar@gmail.com>
4368 * anonymous.cs: Pass unsafe flags to anonymous container.
4370 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4371 inside expression tree.
4373 2008-04-29 Martin Baulig <martin@ximian.com>
4375 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4376 (Tokenizer.PopPosition): Also restore the `line'.
4378 2008-04-29 Marek Safar <marek.safar@gmail.com>
4380 * delegate.cs: Implemented Invoke expression.
4382 2008-04-29 Marek Safar <marek.safar@gmail.com>
4384 * expression.cs: Fixed equality reference comparison regression.
4386 2008-04-29 Marek Safar <marek.safar@gmail.com>
4388 * ecore.cs: Clean up EmptyCast hack.
4390 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4391 using correct conversion rules. Also fixes #383993.
4393 2008-04-28 Martin Baulig <martin@ximian.com>
4395 * class.cs (Constructor.Emit): Don't emit debugging information
4396 for generated default .ctor's.
4398 2008-04-28 Marek Safar <marek.safar@gmail.com>
4400 * convert.cs: Empty-cast ushort to int conversion.
4402 2008-04-28 Marek Safar <marek.safar@gmail.com>
4404 A fix for bug #384191
4405 * ecore.cs, expression.cs: Fixed expression cloning.
4407 2008-04-28 Marek Safar <marek.safar@gmail.com>
4409 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4411 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4413 Fix #381559, test-638.cs, test-639.cs
4414 * assign.cs (CompoundAssign.Helper): New wrapper.
4415 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4417 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4418 Pass unconverted expressions to the params array creation expression.
4419 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4420 (PropertyExpr.EmitAssign): Likewise.
4421 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4422 element if it is of kind CompoundAssign.Helper.
4423 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4424 first before anything else.
4425 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4426 (ArrayAccess.LoadArrayAndArguments): Simplify.
4428 2008-04-27 Marek Safar <marek.safar@gmail.com>
4430 * expression.cs: Fixed cloning of typeof(void).
4432 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4434 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4435 (Assign.Emit): Likewise. Move it to ...
4436 (CompoundAssign.DoResolve): ... here and ...
4437 (CompoundAssign.Emit): ... here.
4438 (EventAddOrRemove): New helper to handle += and -= on events, and
4439 avoid the use of BinaryDelegates.
4440 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4441 (EventExpr.EmitAddOrRemove): Improve.
4442 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4444 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4445 create VarExprs for 'foo.bar.var'.
4446 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4447 is a highly inappropriate name for its functionality.
4449 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4451 Simplify handling of multiple assignments
4452 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4454 (SimpleAssign): New. Class to be used for normal assignments.
4455 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4456 * expression.cs, parameter.cs, statement.cs: Likewise.
4458 2008-04-25 Marek Safar <marek.safar@gmail.com>
4460 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4461 for incompatible underlying types, more to come, uff.
4463 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4466 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4467 Handle 'leave_copy'.
4469 2008-04-25 Marek Safar <marek.safar@gmail.com>
4471 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4473 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4475 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4476 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4477 * statement.cs (While, Do, For): Allow test to have side effects.
4478 (For.DoEmit): Always emit InitStatement.
4481 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4482 Always create SideEffectConstant.
4483 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4484 of type EnumConstant.
4486 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4487 Handle 'right' being SideEffectConstant of type 'bool'.
4489 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4490 Use left.EmitBranchable instead of open coding it, so as to
4491 improve optimization opportunities.
4493 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4495 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4497 (Expression.EmitSideEffect): Document.
4499 2008-04-23 Marek Safar <marek.safar@gmail.com>
4501 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4503 2008-04-23 Marek Safar <marek.safar@gmail.com>
4505 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4507 2008-04-23 Marek Safar <marek.safar@gmail.com>
4509 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4510 conversion to expression tree.
4512 2008-04-23 Marek Safar <marek.safar@gmail.com>
4514 * ecore.cs: Removed unused expression.
4516 2008-04-22 Marek Safar <marek.safar@gmail.com>
4518 * expression.cs: Implemented NegateChecked and New expressions.
4520 2008-04-22 Marek Safar <marek.safar@gmail.com>
4522 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4524 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4527 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4528 needing final 'ret' instruction.
4530 2008-04-22 Marek Safar <marek.safar@gmail.com>
4532 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4534 2008-04-21 Marek Safar <marek.safar@gmail.com>
4536 * expression.cs: Emit ldnull and not null expression as an instance argument
4537 of static method expression calls.
4539 2008-04-21 Marek Safar <marek.safar@gmail.com>
4541 A fix for bug #378200
4542 * expression.cs: Fixed crash when creating parameterless expression tree
4545 2008-04-21 Marek Safar <marek.safar@gmail.com>
4547 A fix for bug #375297
4548 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4551 2008-04-21 Marek Safar <marek.safar@gmail.com>
4553 A fix for bug #377596
4554 * decl.cs, class.cs: Emit delegate type argument attributes.
4556 2008-04-21 Marek Safar <marek.safar@gmail.com>
4558 A fix for bug #365314
4559 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4561 2008-04-21 Marek Safar <marek.safar@gmail.com>
4563 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4566 2008-04-21 Marek Safar <marek.safar@gmail.com>
4568 * generic.cs (TypeParameter): Removed redundant location.
4570 2008-04-19 Marek Safar <marek.safar@gmail.com>
4572 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4573 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4574 FullNamedExpression in all declaration type expression, statements will come
4577 2008-04-18 Marek Safar <marek.safar@gmail.com>
4579 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4580 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4582 2008-04-18 Marek Safar <marek.safar@gmail.com>
4584 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4587 2008-04-17 Marek Safar <marek.safar@gmail.com>
4589 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4592 2008-04-17 Marek Safar <marek.safar@gmail.com>
4594 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4598 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4600 Hook up 'EmitSideEffect'
4601 * constant.cs (Constant.EmitSideEffect): New.
4602 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4603 (SideEffectConstant.EmitSideEffect): New.
4604 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4605 unconditional branch in EmitBranchable.
4606 (FieldExpr.EmitBranchable): New.
4607 * expression.cs (Unary.EmitSideEffect): New.
4608 (Binary.EmitSideEffect): New.
4609 (VariableReference.EmitSideEffect): New. Do nothing.
4611 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4613 Introduce 'EmitSideEffect'
4614 * ecore.cs (Expression.EmitSideEffect): New.
4615 (TypeCast): Rename from EmptyCast.
4617 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4618 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4619 * convert.cs, nullable.cs: Update to changes.
4621 2008-04-16 Marek Safar <marek.safar@gmail.com>
4623 * class.cs, cs-parser.jay: Early check for base types expression.
4625 2008-04-16 Marek Safar <marek.safar@gmail.com>
4627 * decl.cs (MemberName): Declare PrettyName as obsolete.
4629 2008-04-16 Marek Safar <marek.safar@gmail.com>
4631 * namespace.cs: Use MemberName comparison.
4633 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4636 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4638 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4639 (MemberName.FullyQualifiedName): New. Provides the functionality
4640 that users assume FullName would have.
4641 * ecore.cs, namespace.cs: Update to changes.
4643 * statement.cs (Using.assign): Make into ExpressionStatement.
4644 (Using.EmitPreTryBody): Simplify.
4646 2008-04-16 Marek Safar <marek.safar@gmail.com>
4648 * report.cs: ColorFormat is protected.
4650 * rootcontext.cs: Unused fields clean-up.
4652 * namespace.cs: Made UsingEntry name private.
4654 2008-04-16 Marek Safar <marek.safar@gmail.com>
4656 * cs-tokenizer.cs, location.cs: Removed unused field.
4658 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4659 Raja R Harinath <harinath@hurrynot.org>
4662 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4663 (SideEffectConstant.side_effect): Rename from 'right'.
4664 (SideEffectConstant..ctor): Normalize 'side_effect'.
4665 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4666 value of this constant.
4667 * cfold.cs: Update to changes.
4669 2008-04-15 Marek Safar <marek.safar@gmail.com>
4671 * cs-paser.jay: Removed unused variable.
4673 * driver.cs: Made Compile instance method.
4675 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4677 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4679 2008-04-15 Marek Safar <marek.safar@gmail.com>
4681 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4683 2008-04-13 Jb Evain <jbevain@novell.com>
4685 * namespace.cs: update the System.Core fullname for 2.1
4686 * driver.cs: update the list of required assemblies for 2.1.
4687 Merged from the Moonlight 2 branch.
4689 2008-04-11 Marek Safar <marek.safar@gmail.com>
4691 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4692 types and user defined operators. User operators arguments has to be checked
4693 for null value before invocation, which also means no operator is called
4694 when any argument is not convertible to unwrapped nullable type.
4696 2008-04-09 Marek Safar <marek.safar@gmail.com>
4698 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4699 of Unary expressions to follow operator overloading rules precisely.
4700 Also fixes #321794, #323794
4702 2008-04-08 Marek Safar <marek.safar@gmail.com>
4704 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4707 2008-04-08 Marek Safar <marek.safar@gmail.com>
4709 * expression.cs, ecore.cs: Implemented MemberInit expression.
4711 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4713 Fix mono/tests/exception4.cs
4714 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4715 ec.NeedReturnLabel () rather emitting a 'nop'.
4717 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4719 (TryCatch.SomeCodeFollows): Likewise.
4720 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4721 for 'break', 'continue' and 'return' statements inside a try.
4722 We're fairly sure that the generated IL stream will have more
4723 instructions textually following the try.
4724 (FlowBranchingTryCatch): Likewise.
4726 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4727 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4730 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4731 wrapper -- forward everything to CollectionForeach.
4732 (CollectionForeach.NonDisposableWrapper): New.
4733 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4734 instead of a pop + branch to end.
4736 2008-04-07 Marek Safar <marek.safar@gmail.com>
4738 A fix for bug #377485
4739 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4740 Propagate location for extension method groups. Report conversion failure at
4743 2008-04-07 Marek Safar <marek.safar@gmail.com>
4745 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4746 ListInit and Field expressions.
4748 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4750 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4751 Since $PC is always -1 inside the body of MoveNext, the fault
4753 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4754 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4755 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4757 The denouement! Fix #324708
4758 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4759 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4760 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4761 'finally' inside the finally clause.
4763 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4764 inside an iterator. Don't emit the body of the 'finally' inside
4765 the finally clause yet.
4767 Use the ResumableStatement infrastructure for MoveNext ()
4768 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4769 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4770 'old_resume_points'. Move dispatcher upfront.
4771 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4772 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4773 in an enumerator. This encodes the main fix in this patch series
4774 -- we can only jump into the first instruction of a try from the
4775 outside, but we want to emit try/finally regions in iterators and
4776 resume in the middle of them.
4778 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4780 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4781 of NeedReturnLabel here.
4783 Introduce a common point for emitting try/finally to IL
4784 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4785 features of the various subclasses, which are now driven by ...
4786 (ExceptionStatement.EmitPreTryBody): ... this and ...
4787 (ExceptionStatement.EmitTryBody): ... this and the original
4789 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4790 Remove DoEmit and update to follow above protocol.
4792 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4793 of the dispatcher are the same, skip emitting the 'switch'.
4794 * iterator.cs (Iterator.EmitDispose): Update to changes.
4796 Clean up handling of 'using' statement
4797 * statement.cs (UsingTemporary): New. Carved out of ...
4798 (Using): ... this. Simplify drastically. Handle exactly
4800 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4801 or Using as appropriate. If there are multiple variable declared,
4802 create nested Using statements.
4803 (resource_acquisition): Kill.
4805 * statement.cs (ExceptionStatement.EmitForDispose): Use
4806 EmitFinallyBody, not EmitFinally.
4808 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4809 * iterator.cs: Update to changes.
4811 Start using the ResumableStatement infrastructure
4812 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4813 (ResumableStatement.EmitForDispose): New.
4814 (ExceptionStatement): Override them.
4815 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4816 EmitForDispose to create the body of the Dispose method. Don't
4819 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4820 * statement.cs (Toplevel.AddResumePoint): ... here.
4821 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4822 * flowanalysis.cs (FlowBranchingIterator): New.
4823 * codegen.cs (EmitContext): Update to changes.
4825 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4826 (Iterator.old_resume_points): Rename from 'resume_points'.
4827 (Iterator.MoveNextStatement): Remove unused class.
4829 New infrastructure for try/finally in iterators (still unused)
4830 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4831 (FlowBranchingToplevel.AddResumePoint): Hook into
4832 ToplevelBlock.AddResumePoint.
4833 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4834 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4835 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4836 resume points and assign program-counter values.
4837 (ExceptionBlock.AddResumePoint): Collect resume points for
4838 de-muxer at the top of try block.
4839 * iterators.cs (Yield.CheckContext): Simplify.
4840 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4842 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4844 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4845 argument to an ExitStatement.
4846 (FlowBranchingException): Refactor saved origins code.
4847 * statement.cs (ExitStatement): Update to cahges.
4848 * iterator.cs (YieldBreak): Likewise.
4850 * statement.cs (ResumableStatement): New. Common base class for
4851 YieldReturn and ExceptionStatement.
4852 (ExitStatement): New. Common base class for Return and YieldBreak.
4853 (Return): Update to changes.
4854 * iterator.cs (YieldBreak): Likewise.
4855 * lambda.cs (ContextualReturn): Likewise.
4858 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4859 emit a meaningful error message.
4861 Fix #324765, #319508
4862 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4863 (VariableInfo.SetAssigned): Set it.
4864 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4865 determine if CS0219 or CS0168 is appropriate. Don't use
4866 flow-analysis information.
4867 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4868 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4869 (EmitContext.EndFlowBranching): ... this.
4871 2008-04-03 Marek Safar <marek.safar@gmail.com>
4873 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
4875 2008-04-03 Marek Safar <marek.safar@gmail.com>
4877 A fix for bug #376508
4878 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
4879 ImplicitConversionExists.
4881 2008-04-03 Marek Safar <marek.safar@gmail.com>
4883 * expression.cs (Binary): Added remaining binary operators to expression
4886 * nullable.cs: Optimize shift with null argument.
4888 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
4890 Fix minor IL regression
4891 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
4892 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
4893 * cs-parser.jay (try_statement): Update to changes.
4895 * statement.cs (TryFinally.need_exc_block): Delete.
4896 (TryFinally): Update to changes.
4898 Now all ExceptionStatements are unconditional
4899 * statement.cs (CollectionForeach.DisposableWrapper): New.
4900 Extract out the try/finally code into a new wrapper.
4901 (CollectionForeach.Resolve): Use it to simplify the code.
4903 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
4905 Start at simplifying ExceptionStatement semantics a bit
4906 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
4907 * cs-parser.jay (try_statement): Update to changes.
4908 (opt_catch_clauses): Remove.
4909 * flowanalysis.cs: Update to changes.
4910 (FlowBranching.BranchingType.TryCatch): New.
4911 (FlowBranchingTryCatch): New.
4913 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
4914 (FlowBranching.CreateBranching): Update to changes.
4915 (FlowBranchingBlock.AddSibling): Add sanity check.
4916 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
4919 * iterators.cs (Iterator.MarkFinally): Remove.
4920 * statement.cs (ExceptionStatement): Update to changes.
4922 Add support for skipping over finally blocks at runtime. First
4923 in a series to fix #324708
4924 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
4925 (Iterator.EmitMoveNext): Initialize it.
4926 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
4927 branch over the body of the 'finally' clause.
4929 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
4931 Avoid lopsided use of Foo/DoFoo names
4932 * statement.cs (ExpressionStatement.EmitFinallyBody):
4933 Rename from EmitFinally.
4934 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
4935 * iterator.cs: Update to changes.
4937 2008-04-02 Marek Safar <marek.safar@gmail.com>
4939 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
4940 based on UserOperatorCall. More binary nullable operators clean up.
4942 2008-04-02 Martin Baulig <martin@ximian.com>
4944 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
4946 2008-04-02 Marek Safar <marek.safar@gmail.com>
4948 * nullable.cs: Merge user and empty conversions when lifting expression
4951 * expression.cs (StringConcat): Implemented expression tree representation.
4953 2008-04-01 Marek Safar <marek.safar@gmail.com>
4955 * nullable.cs: When lifting null literal and a user operator exists, no call
4958 2008-04-01 Marek Safar <marek.safar@gmail.com>
4960 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
4963 2008-04-01 Marek Safar <marek.safar@gmail.com>
4965 * nullable.cs, expression.cs: Use namespace instead heavily nested
4966 monster abstract class.
4968 2008-04-01 Marek Safar <marek.safar@gmail.com>
4970 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
4971 lifting of null literal and user operators. Clean up of some temporary
4974 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
4976 Fix #368224, test-629.cs
4977 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
4978 if it crossed an unwind-protect boundary.
4979 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
4980 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
4981 inside an unwind-protected region.
4982 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
4983 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
4984 'leave' instead of a 'br' if unwind-protected.
4985 (Iterator.EmitYieldBreak): Likewise.
4987 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
4989 * driver.cs: Only define versioninfo resources if no win32 resource
4992 2008-03-28 Marek Safar <marek.safar@gmail.com>
4994 A fix for bug #372375
4995 * convert.cs: Fixed boxing of nullable types.
4997 2008-03-28 Marek Safar <marek.safar@gmail.com>
4999 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5002 2008-03-28 Marek Safar <marek.safar@gmail.com>
5004 A fix for bug #374619
5005 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5007 2008-03-27 Marek Safar <marek.safar@gmail.com>
5009 * lambda.cs: Check return type only for invocation.
5011 2008-03-27 Marek Safar <marek.safar@gmail.com>
5013 A fix for bug #374214
5014 * ecore.cs: Correctly report argument type mismatch.
5016 2008-03-27 Marek Safar <marek.safar@gmail.com>
5018 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5019 and not rely on broken IsEnum.
5021 2008-03-27 Marek Safar <marek.safar@gmail.com>
5023 * nullable.cs: New file, extracted from generic.cs.
5025 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5027 2008-03-27 Marek Safar <marek.safar@gmail.com>
5029 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5030 predefined comparison operators and null literals.
5032 * report.cs: New warning ID.
5034 2008-03-25 Marek Safar <marek.safar@gmail.com>
5036 A fix for bug #370577
5037 * lambda.cs: Check return type too.
5039 2008-03-25 Marek Safar <marek.safar@gmail.com>
5041 A fix for bug #372846
5042 * class.cs: Automatic properties can be declared as unsafe.
5044 2008-03-20 Marek Safar <marek.safar@gmail.com>
5046 * location.cs: Use string based concatenation.
5048 * expression.cs: LiftedBinaryOperator is gmcs only.
5050 2008-03-20 Marek Safar <marek.safar@gmail.com>
5052 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5053 conversions rules and expression trees.
5055 2008-03-19 Marek Safar <marek.safar@gmail.com>
5057 * delegate.cs: Use extension method source as delegate target.
5059 2008-03-19 Marek Safar <marek.safar@gmail.com>
5061 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5062 binary operations to be purely based on binary operations and optimized
5063 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5064 and other ET refactoring.
5066 * typemanager.cs: Fixed warning.
5068 2008-03-17 Marek Safar <marek.safar@gmail.com>
5070 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5072 * symbolwriter.cs: Fixed.
5074 2008-03-17 Marek Safar <marek.safar@gmail.com>
5076 * anonymous.cs, driver.cs: Reset anonymous types counters.
5078 2008-03-17 Marek Safar <marek.safar@gmail.com>
5080 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5082 * class.cs: Use fullname for all type member definitions.
5084 2008-02-19 Martin Baulig <martin@ximian.com>
5087 (IMethodData.EmitExtraSymbolInfo): New interface method.
5088 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5089 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5090 interface method here as an empty public virtual method.
5093 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5094 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5095 CodeGen.SymbolWriter.SetRealMethodName().
5097 2008-02-18 Martin Baulig <martin@ximian.com>
5100 (ScopeInfo.EmitType): Override this and emit debugging
5101 information for captured variables.
5102 (RootScopeInfo.EmitType): Override this and emit symbol
5103 information for a captured `this'.
5105 2008-02-15 Martin Baulig <martin@ximian.com>
5107 * iterators.cs: Emit debugging info.
5110 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5111 (EmitContext.OmitDebuggingInfo): New public property.
5114 (While): Override Emit() and don't emit symbol info there; do it
5115 inside DoEmit() instead.
5116 (Block.Emit): Omit symbol information while emitting the scope
5117 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5119 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5120 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5121 .ctor to make `IsIterator' work.
5123 2008-03-14 Martin Baulig <martin@ximian.com>
5125 * symbolwriter.cs: Added the new symbol writer function from the
5126 debugger's `terrania' branch; temporarily enclose them inside
5127 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5130 2008-03-14 Martin Baulig <martin@ximian.com>
5133 (SymbolWriter): Make this a public static class.
5136 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5137 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5139 2008-03-14 Marek Safar <marek.safar@gmail.com>
5141 A fix for bug #370577
5142 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5145 2008-03-14 Marek Safar <marek.safar@gmail.com>
5147 * typemanager.cs (CSharpName): Made 250 times faster.
5149 2008-03-13 Marek Safar <marek.safar@gmail.com>
5151 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5153 2008-03-12 Marek Safar <marek.safar@gmail.com>
5155 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5156 crash when predefined field does not exist.
5158 2008-03-12 Marek Safar <marek.safar@gmail.com>
5160 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5162 2008-03-12 Marek Safar <marek.safar@gmail.com>
5164 * class.cs (FixedField): Don't crash when contructors are missing.
5166 2008-03-11 Marek Safar <marek.safar@gmail.com>
5168 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5169 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5170 check internal types accessibility for internal and external types.
5171 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5173 2008-03-11 Marek Safar <marek.safar@gmail.com>
5175 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5176 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5177 attribute.cs, statement: Use corect instance of predefined types (work
5178 related to #364674).
5180 2008-03-07 Marek Safar <marek.safar@gmail.com>
5182 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5184 2008-03-07 Marek Safar <marek.safar@gmail.com>
5186 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5187 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5188 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5189 predefined types clean up, delayed predefined types members initialization
5190 (work related to #364674).
5192 2008-03-05 Marek Safar <marek.safar@gmail.com>
5194 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5196 2008-03-05 Marek Safar <marek.safar@gmail.com>
5198 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5199 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5200 predefined types clean up (work related to #364674).
5202 2008-03-04 Marek Safar <marek.safar@gmail.com>
5204 * ecore.cs: Print an error message instead of throwing exception.
5206 2008-03-04 Marek Safar <marek.safar@gmail.com>
5208 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5209 expression.cs, statement.cs: Unififed null literal representation.
5211 2008-03-03 Marek Safar <marek.safar@gmail.com>
5213 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5214 expression.cs: Refactored binary operators resolve phase and improved speed.
5215 The nullable code is still missing and won't work correctly, more fixes
5218 It also fixes #323726, #324312, #324248, and many other unreported issues.
5220 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5222 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5225 2008-02-27 Marek Safar <marek.safar@gmail.com>
5227 * ecore.cs: Clean-up and split BetterConversion.
5229 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5232 * enum.cs (EnumMember.Value): Only access 'value' if
5233 ResolveValue says it's ok.
5234 (EnumMember.DoResolveValue): Don't set prev_member.value.
5235 (Enum.GetDefinition): Reverse arguments of Equals --
5236 EnumMember.Value can return 'null'.
5238 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5240 2008-02-22 Marek Safar <marek.safar@gmail.com>
5242 * generic.cs, expression.cs: More ongoing work on expression trees.
5244 2008-02-21 Marek Safar <marek.safar@gmail.com>
5246 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5247 handle missing matches when mutiple operators exist.
5249 2008-02-20 Marek Safar <marek.safar@gmail.com>
5251 A fix for bug #363218
5252 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5255 2008-02-20 Marek Safar <marek.safar@gmail.com>
5257 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5258 update. This time to deal correctly with SideEffectConstant expression used
5259 as an argument for another constant folding.
5261 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5263 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5266 2008-02-19 Marek Safar <marek.safar@gmail.com>
5268 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5270 2008-02-19 Marek Safar <marek.safar@gmail.com>
5272 A fix for bug #328136
5273 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5274 side is a false constant, because we still need to evaluate the right-hand
5277 * statement.cs (If): Emit two types of boolean constants (simple constant,
5278 side-effect constant).
5280 2008-02-19 Marek Safar <marek.safar@gmail.com>
5282 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5284 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5287 2008-02-18 Marek Safar <marek.safar@gmail.com>
5289 A fix for bug #361457
5290 * ecore.cs (IsApplicable): Params methods have lower priority.
5292 * support.cs: Return correct parameter modifier for params types.
5294 2008-02-18 Marek Safar <marek.safar@gmail.com>
5296 * generic.cs (TypeParameter): Cache attribute target name.
5298 * support.cs: Removed unused variable.
5300 * typemanager.cs: Removed debugging leftover.
5302 * ecore.cs: Use local type instead of a property;
5304 * class.cs (VerifyMembers): Consider also parent to test whether type member
5307 * expression.cs (FullMethodDesc): Removed.
5309 * attribute.cs (IsValidArgumentType): Made static.
5311 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5313 Cleanup to be more readable.
5314 * Makefile (GMCS_PROFILE): Remove.
5315 (COMPILER_NAME): New helper.
5317 2008-02-15 Miguel de Icaza <miguel@novell.com>
5319 * cs-tokenizer.cs: if a conditional expression happens inside a
5320 (...) this also means that we do not need to de-ambiguate between
5321 an parenthesized expression and a cast.
5325 * constant.cs (SideEffectConstant): a constant value that happens
5326 to have a side effect.
5328 Fixes the build regressions introduced by the fix for #359789
5330 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5332 * expression.cs (Conditional.Emit): when emitting the ternary
5333 operator, use local variables to generate code verifiable code.
5335 The verifier cannot infer that the type on stack before the
5336 stloc.0 is executed is of type ParentB. This happens because the
5337 stack merge algorithm uses only parent types when deciding which
5338 is the common type. This is described in Part III 1.8.1.3 of ECMA
5341 This code compiled with mcs is not verifiable under MS. The MS
5342 verifier picks the first common interface of Foo and Bar, which is
5343 wrong, but doesn't use a full join type of the 2 interfaces.
5345 CSC uses a clever hack to compile such code in a verifiable
5346 way. It stores the intermediate values in a local variable with
5351 2008-02-14 Miguel de Icaza <miguel@novell.com>
5353 * expression.cs: Do not fold BitwiseAnd operators when the left
5354 side is a false constant, because we still need to evaluate the
5359 * support.cs: Instead of throwing an InternalErrorException when
5360 the position of the stream is outside the boundary of our buffer,
5361 reset the state of the reader, and restart the reading from the
5362 beginning of the file.
5364 2008-02-14 Marek Safar <marek.safar@gmail.com>
5366 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5368 2008-02-14 Marek Safar <marek.safar@gmail.com>
5370 A fix for bug #361686
5371 * decl.cs: A protected types used inside a private class which parents
5372 derives from the protected class are accessible.
5374 2008-02-13 Marek Safar <marek.safar@gmail.com>
5376 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5377 the parameterless constructor.
5379 2008-02-13 Marek Safar <marek.safar@gmail.com>
5381 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5382 lookup methods to use standard member cache when doing member lookup.
5384 2008-02-12 Marek Safar <marek.safar@gmail.com>
5386 * driver.cs: Don't report full path for referenced module as assembly error.
5388 2008-02-12 Marek Safar <marek.safar@gmail.com>
5390 * Makefile: Fixed `qh' target to work on all machines.
5392 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5393 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5394 and HasElementType with TypeManager implementation.
5396 2008-02-08 Marek Safar <marek.safar@gmail.com>
5398 A fix for bugs #325134, #359749
5399 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5400 first binds point to non-method member expression.
5402 2008-02-08 Marek Safar <marek.safar@gmail.com>
5404 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5406 2008-02-08 Marek Safar <marek.safar@gmail.com>
5408 A fix for bugs #321394, #323028
5409 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5410 Reworked naive IsAccessibleAs implementation to handle nested types.
5412 2008-02-05 Jb Evain <jbevain@novell.com>
5414 * class.cs: use generic type comparison for parameters
5417 2008-02-05 Marek Safar <marek.safar@gmail.com>
5419 A fix for bug #325372
5420 * class.cs: Use generic type comparison when testing method signatures.
5422 2008-02-05 Marek Safar <marek.safar@gmail.com>
5424 A fix for bug #357047
5425 * ecore.cs: Applied C# 3.0 changes to better conversion.
5427 2008-02-05 Marek Safar <marek.safar@gmail.com>
5429 A fix for bug #358374
5430 * cs-parser.jay: Correctly set modifiers for all constructor types.
5432 2008-02-04 Marek Safar <marek.safar@gmail.com>
5434 A fix for bug #355251
5435 * generic.cs: Added base class constraint based type inference.
5437 2008-02-01 Marek Safar <marek.safar@gmail.com>
5439 A fix for bug #357255
5440 * decl.cs: One more missing visibility check.
5442 2008-02-01 Marek Safar <marek.safar@gmail.com>
5444 * support.cs: Fixed broken return.
5446 2008-01-25 Marek Safar <marek.safar@gmail.com>
5448 * report.cs: Correctly reset warnings count after probing.
5450 2008-01-25 Martin Baulig <martin@ximian.com>
5453 (NamespaceEntry.SymbolFileID): Make this work again after
5454 MemberName.ToString() is gone.
5456 2008-01-25 Marek Safar <marek.safar@gmail.com>
5458 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5461 2008-01-25 Marek Safar <marek.safar@gmail.com>
5463 * generic.cs: Use full implicit conversion for type inference fixing.
5465 2008-01-24 Marek Safar <marek.safar@gmail.com>
5467 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5468 Fixed user operator conversions.
5470 2008-01-24 Marek Safar <marek.safar@gmail.com>
5472 * generic.cs: Do nullable type to null comparison optimization during
5475 2008-01-24 Marek Safar <marek.safar@gmail.com>
5477 A fix for bug #355163
5478 * generic.cs: Enabled l-value resolve on nullable expressions.
5480 2008-01-24 Marek Safar <marek.safar@gmail.com>
5482 A fix for bug #353986
5483 * class.cs: Ingore static ctors with parameters for any further checks.
5485 2008-01-24 Marek Safar <marek.safar@gmail.com>
5487 A fix for bug #354310
5488 * namespace.cs: Removed redundant check.
5490 2008-01-24 Marek Safar <marek.safar@gmail.com>
5492 A fix for bug #354928
5493 * expression.cs: ElementInitializers can be resolved only once.
5495 2008-01-24 Marek Safar <marek.safar@gmail.com>
5497 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5498 Condition expressions.
5500 2008-01-23 Marek Safar <marek.safar@gmail.com>
5502 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5504 2008-01-22 Marek Safar <marek.safar@gmail.com>
5506 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5509 * generic.cs: Implemented coalesce expression.
5511 2008-01-22 Marek Safar <marek.safar@gmail.com>
5513 A fix for bug #355145
5514 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5515 expression tree type inference.
5517 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5520 * expression.cs (Binary.IsUnsignedType): Fix typo.
5522 2008-01-22 Marek Safar <marek.safar@gmail.com>
5524 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5526 2008-01-22 Marek Safar <marek.safar@gmail.com>
5528 A fix for bug #355161
5529 * ecore.cs, expression.cs: Wider range of extension method supported
5532 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5534 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5535 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5538 2008-01-22 Marek Safar <marek.safar@gmail.com>
5540 A fix for bug #355148
5541 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5543 2008-01-22 Miguel de Icaza <miguel@novell.com>
5545 * expression.cs (CreateExpressionTree): Add support for or and
5546 logical or, and indent following the coding conventions.
5548 * typemanager.cs (LinqExpression): renamed from
5549 ExpressionTreeManager, for a shorter name.
5551 Use TypeManager.CoreLookupType to lookup types from our core
5552 assemblies and turn those into "Type" variables.
5554 Consumers that previously used "Namespace" and "Type" from this
5555 class should instead use the TypeExpression which is a type that
5556 is fully resolved (without involving the regular C# resolution
5559 This typically looks like this:
5561 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5562 new MemberAccess (texpr, name, type_arguments, loc)
5564 This avoids the problem in: #355178
5566 2008-01-21 Marek Safar <marek.safar@gmail.com>
5568 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5569 feature in parser only as we do in other cases.
5571 2008-01-21 Marek Safar <marek.safar@gmail.com>
5573 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5574 typemanager.cs: A refactoring of params arguments to reuse existing
5575 expressions (params -> array initializer) to emit params argument instead
5576 of specialized handling.
5577 It was required by expression tree implementation and it has other benefits
5578 as well, we now apply same optimization for params arguments as we do for
5581 2008-01-18 Marek Safar <marek.safar@gmail.com>
5583 A fix for bug #353526
5584 * generic.cs: A type inference of params arguments may not required any
5585 temporary array creation.
5587 2008-01-18 Marek Safar <marek.safar@gmail.com>
5589 A fix for bug #353534
5590 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5591 supported for delegates only.
5593 2008-01-18 Marek Safar <marek.safar@gmail.com>
5595 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5596 type for more than 1 candidates.
5598 2008-01-18 Marek Safar <marek.safar@gmail.com>
5600 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5603 2008-01-16 Marek Safar <marek.safar@gmail.com>
5605 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5606 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5607 operator) expressions.
5609 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5611 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5612 not accessed from the generated IL.
5614 2008-01-14 Marek Safar <marek.safar@gmail.com>
5616 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5617 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5618 statement.cs: The first expression tree implementation drop, mostly
5619 infrastructure work.
5621 2008-01-14 Marek Safar <marek.safar@gmail.com>
5623 * ecore.cs (IsNestedChild): Refactored.
5625 2008-01-11 Marek Safar <marek.safar@gmail.com>
5627 * lambda.cs: Don't use a cast on unknown expression statement.
5629 2008-01-10 Geoff Norton <gnorton@novell.com>
5631 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5634 2008-01-09 Marek Safar <marek.safar@gmail.com>
5636 * doc.cs: Report better /doc crash details.
5638 2008-01-09 Marek Safar <marek.safar@gmail.com>
5640 A fix for bug #352536
5641 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5643 2008-01-08 Marek Safar <marek.safar@gmail.com>
5645 A fix for bug #352287
5646 * ecore.cs, expression.cs: Do `this' access checking in all member access
5649 2008-01-08 Marek Safar <marek.safar@gmail.com>
5651 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5653 * report.cs: Reset message stacks.
5655 2008-01-08 Marek Safar <marek.safar@gmail.com>
5657 * generic.cs (InferInPhases): Correctly calculate params position.
5659 2008-01-08 Marek Safar <marek.safar@gmail.com>
5661 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5664 2008-01-07 Marek Safar <marek.safar@gmail.com>
5666 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5668 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5670 * driver.cs: Updated --help option.
5672 2008-01-07 Marek Safar <marek.safar@gmail.com>
5674 * generic.cs (InferParamsTypeArguments): Removed.
5675 (InferInPhases): Add params type inference.
5676 (LowerBoundInference): Fixed scoring mechanism.
5678 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5680 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5682 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5683 byte array for unsigned "baked" assemblies.
5685 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5687 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5688 array for assemblies that are not strongnamed.
5690 2008-01-04 Marek Safar <marek.safar@gmail.com>
5692 A fix for bug #351481
5693 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5694 declaring type for nested generic types.
5696 2008-01-04 Marek Safar <marek.safar@gmail.com>
5698 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5699 instead of ToString.
5701 2008-01-03 Marek Safar <marek.safar@gmail.com>
5703 A fix for bug #351047
5704 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5705 null and structs only when equality and inequality operators are defined
5706 either as an user-operators or predefined operators.
5708 2008-01-03 Marek Safar <marek.safar@gmail.com>
5710 A fix for bug #351047
5711 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5713 2008-01-03 Marek Safar <marek.safar@gmail.com>
5715 A fix for bug #351257
5716 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5718 2008-01-03 Marek Safar <marek.safar@gmail.com>
5720 A fix for bug #351157
5721 * class.cs (Using): Fixed yet another broken cloning.
5723 (Block): Put back more sensible default value for statements.
5725 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5727 * codegen.cs: Allow AssemblyVersion with only major version component.
5730 2007-12-29 Marek Safar <marek.safar@gmail.com>
5732 A fix for bug #324654
5733 * class.cs: Use FullName property as member name.
5735 2007-12-28 Marek Safar <marek.safar@gmail.com>
5737 A fix for bug #342117
5738 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5739 constructor constraint.
5741 2007-12-28 Marek Safar <marek.safar@gmail.com>
5743 A fix for bug #338273
5744 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5747 2007-12-28 Marek Safar <marek.safar@gmail.com>
5749 A fix for bug #350839
5750 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5752 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5754 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5757 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5759 * statement.cs: Changed some Hashtables to use HybridDictionaries
5760 instead. It was observed that some HashTables only contained a few
5761 items in the vast majority of cases. Since HybridDictionary is
5762 more efficient on small sets (<10 elements), "known_variables"
5763 from class ExplicitBlock as well as "labels" and "constants " from
5764 class Block were changed to HybridDictionaries.
5766 Atsai results: (56216kb->54987kb)
5768 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5771 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5773 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5776 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5778 * expression.cs: foreach loop to for loop, saved on allocation of
5779 enumerator (59333kb->59141kb)
5781 * statement.cs. Changed foreach loops to for loops, saved on
5782 allocation of enumerator (59141kb->59006kb)
5784 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5785 when constructed with no specified capacity. This was causing a
5786 few ArrayLists to allocate more memory than they would potentially
5787 need in the Block class and MemberCache class. Setting the
5788 ArrayLists to construct with a capacity of 1 saves some
5789 memory. (56216kb->55585kb)
5791 2007-12-27 Marek Safar <marek.safar@gmail.com>
5793 A fix for bug #347189 (2nd issue)
5794 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5797 2007-12-27 Miguel de Icaza <miguel@novell.com>
5799 * report.cs: Do not use colors if stdout and stderr are not a
5802 2007-12-27 Marek Safar <marek.safar@gmail.com>
5804 A fix for bug #346998
5805 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5808 2007-12-27 Marek Safar <marek.safar@gmail.com>
5810 A fix for bug #343465
5811 * class.cs: Explicit method name for nested types uses dots only.
5813 2007-12-27 Marek Safar <marek.safar@gmail.com>
5815 A fix for bug #343707
5816 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5818 2007-12-27 Marek Safar <marek.safar@gmail.com>
5820 * ecore.cs: Report type inference errors only when arguments count matches
5823 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5825 * expression.cs, report.cs: New warning.
5827 * typemanager.cs: Catch anonymous method type too.
5829 2007-12-23 Marek Safar <marek.safar@gmail.com>
5831 A fix for bug #346379
5832 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5834 2007-12-23 Marek Safar <marek.safar@gmail.com>
5836 A fix for bug #347359
5837 * expression.cs (Invocation): Don't resolve already resolved expression.
5839 2007-12-23 Marek Safar <marek.safar@gmail.com>
5841 A fix for bug #347189
5842 * class.cs (FixedField): Use non-dependent code only in the define phase.
5844 2007-12-23 Marek Safar <marek.safar@gmail.com>
5846 A fix for bug #348076
5847 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5849 2007-12-22 Marek Safar <marek.safar@gmail.com>
5851 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5852 discovered extension methods.
5854 2007-12-22 Marek Safar <marek.safar@gmail.com>
5856 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5859 2007-12-21 Miguel de Icaza <miguel@novell.com>
5861 * report.cs (ErrorMessage): Add support for using colors on
5862 terminals that support it.
5864 2007-12-21 Marek Safar <marek.safar@gmail.com>
5866 * ecore.cs: Use information about expanded params for error reporting.
5868 2007-12-21 Marek Safar <marek.safar@gmail.com>
5870 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5871 and logic for params overloads.
5873 2007-12-15 Miguel de Icaza <miguel@novell.com>
5875 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
5876 as this is also created from the parser. Fixes #349034
5878 2007-12-12 Miguel de Icaza <miguel@novell.com>
5880 * statement.cs (Throw.CloneTo): it is valid to have empty
5881 expressions for throw.
5883 2007-12-03 Marek Safar <marek.safar@gmail.com>
5885 * cs-parser.jay: Set delegate constraint parsing region correctly.
5887 2007-12-03 Marek Safar <marek.safar@gmail.com>
5889 A fix for bug #345467
5890 * typemanager.cs (IsEqual): Compare generic parameters position only.
5892 2007-11-28 Marek Safar <marek.safar@gmail.com>
5894 * expression.cs (BaseAccess): Type arguments can be null.
5896 2007-11-27 Raja R Harinath <harinath@gmail.com>
5898 * statement.cs (Block.Resolve): Ensure flow-branching tree is
5899 consistent even when an error has occured.
5900 (Switch.Resolve): Likewise.
5902 2007-11-22 Marek Safar <marek.safar@gmail.com>
5904 A fix for bug #334505
5905 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
5908 2007-11-22 Marek Safar <marek.safar@gmail.com>
5910 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
5911 refactorings required to resolve extension methods correctly when mixing
5912 generics and non-generics members.
5914 2007-11-20 Marek Safar <marek.safar@gmail.com>
5916 A fix for bug #342584
5917 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
5920 2007-11-19 Marek Safar <marek.safar@gmail.com>
5922 A fix for bug #342512
5923 * delegate.cs: Use delegate argument expression when is available. Don't
5924 emit virtual call when class is sealed.
5926 2007-11-16 Marek Safar <marek.safar@gmail.com>
5928 A fix for bug #325423
5929 * assign.cs (FieldInitializer): Use resolved expression for emit.
5931 * class.cs: Print less confusing error message.
5933 2007-11-16 Marek Safar <marek.safar@gmail.com>
5935 * cs-tokenizer.cs: Removed GMCS ifdefs.
5937 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
5940 * cs-parser.jay: Disabled nullable check.
5942 * generic-mcs: Copied more generic stuff.
5944 2007-11-16 Marek Safar <marek.safar@gmail.com>
5946 * gcs-parser.jay: Merged to cs-parser.jay.
5948 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
5949 * *.csproj, *.sources: Updated to use only jay parser file.
5951 2007-11-16 Marek Safar <marek.safar@gmail.com>
5953 * gcs-parser.jay: Added nullable and default expression feature checks.
5955 2007-11-16 Marek Safar <marek.safar@gmail.com>
5957 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
5958 it fixes many TODOs and hidden bugs.
5960 * expression: Removed duplicate error check.
5962 2007-11-15 Marek Safar <marek.safar@gmail.com>
5964 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
5965 implicitly type local variable only when it is used in a declaration.
5967 2007-11-15 Marek Safar <marek.safar@gmail.com>
5969 * attribute.cs: Use CS0612 for empty strings.
5971 2007-11-14 Marek Safar <marek.safar@gmail.com>
5973 * lambda.cs, statement.cs: Contextual return may act as a statement.
5975 2007-11-14 Marek Safar <marek.safar@gmail.com>
5977 A fix for a regression cause by #324222
5978 * class.cs: Don't report unused even when it implements an interface.
5980 2007-11-13 Marek Safar <marek.safar@gmail.com>
5982 A fix for bug #341205
5983 * ecore.cs, expression.cs: Method group expression cannot do static
5984 method access with an instance reference check before overloading takes
5987 2007-11-13 Marek Safar <marek.safar@gmail.com>
5989 A fix for bug #325359
5990 * class.cs: Use predictable name for automatically generated property.
5992 2007-11-12 Marek Safar <marek.safar@gmail.com>
5994 A fix for bug #324996
5995 * expression.cs (Is): Handle case where D is nullable and T is not
5998 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6000 2007-11-12 Marek Safar <marek.safar@gmail.com>
6002 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6003 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6004 Flush small error reporting changes.
6006 2007-11-09 Marek Safar <marek.safar@gmail.com>
6008 A fix for bug #324996
6009 * expression.cs: Rewrote Is expression implementation to work with
6010 generics, nullable types, anonymous method. A const result expression
6011 uses existing infrastructure instead of custom not fully-featured one.
6013 2007-11-08 Marek Safar <marek.safar@gmail.com>
6015 A fix for bug #340202
6016 * class.cs: Consider generics for volatile field.
6018 2007-11-08 Marek Safar <marek.safar@gmail.com>
6020 A fix for bug #335594
6021 * expression.cs: Use conversion rules when handling string addition.
6023 2007-11-07 Marek Safar <marek.safar@gmail.com>
6025 A fix for bug #336651
6026 * expression.cs: Fixed a crash when probing is on.
6028 2007-11-07 Marek Safar <marek.safar@gmail.com>
6030 A fix for bug #324242
6031 * covert.cs: Added a conversion from any nullable-type with an
6032 underlying enum-type to the type System.Enum.
6034 2007-11-07 Marek Safar <marek.safar@gmail.com>
6036 A fix for bug #324222
6037 * class.cs: Report all non-used event fields.
6039 2007-11-07 Marek Safar <marek.safar@gmail.com>
6041 A fix for bug #325161
6042 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6043 qualifier for generic types.
6045 2007-11-07 Marek Safar <marek.safar@gmail.com>
6047 A fix for bug #322971
6048 * expression.cs, ecore.cs: Added intermediate result value check for
6051 2007-11-07 Marek Safar <marek.safar@gmail.com>
6053 A fix for bug #324754
6054 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6055 when it was requested.
6057 2007-11-07 Marek Safar <marek.safar@gmail.com>
6059 A fix for bug #325101
6060 * expression.cs: Do type not value comparison for `is' expression.
6062 2007-11-07 Marek Safar <marek.safar@gmail.com>
6064 A fix for bug #320236
6065 * convert.cs: Don't apply user conversion on underlying target type.
6067 2007-11-06 Marek Safar <marek.safar@gmail.com>
6069 * expression.cs: Don't use unresolved expression for error reporting.
6071 2007-11-06 Marek Safar <marek.safar@gmail.com>
6073 A fix for bugs #337712, #324490
6074 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6075 overloading resolution too.
6077 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6078 the process consistent and more robust.
6080 * expression.cs, linq.cs, report.cs: Update.
6082 2007-11-02 Marek Safar <marek.safar@gmail.com>
6084 A fix for bug #332909
6085 * attribute.cs: Resolve attributes in correct context using error
6088 * rootcontext.cs: Define Obsolete attribute members as core members.
6090 2007-11-02 Marek Safar <marek.safar@gmail.com>
6092 * statement.cs: Removed unused methods.
6094 2007-10-31 Wade Berrier <wberrier@novell.com>
6096 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6097 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6100 2007-10-31 Marek Safar <marek.safar@gmail.com>
6102 A fix for bug #338102
6103 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6104 methods registered as non-generics.
6106 2007-10-31 Marek Safar <marek.safar@gmail.com>
6108 A fix for bugs #337712, #324490
6109 * delegate.cs: Delegate covariance and contravariance is not allowed for
6112 2007-10-31 Marek Safar <marek.safar@gmail.com>
6114 A fix for bug #337719
6115 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6118 2007-10-30 Marek Safar <marek.safar@gmail.com>
6120 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6122 2007-10-29 Marek Safar <marek.safar@gmail.com>
6124 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6127 2007-10-29 Raja R Harinath <rharinath@novell.com>
6129 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6131 2007-10-29 Marek Safar <marek.safar@gmail.com>
6133 A fix for bug #334652
6134 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6135 extension methods when we have not found the best candidate in normal
6138 2007-10-27 Marek Safar <marek.safar@gmail.com>
6140 * AssemblyInfo.cs: Keep up-to-date.
6142 2007-10-27 Marek Safar <marek.safar@gmail.com>
6144 * Makefile: Fixed generics compiler name.
6146 2007-10-27 Marek Safar <marek.safar@gmail.com>
6148 * lambda.test: removed, lambda parsing is done differently.
6150 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6152 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6154 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6156 2007-10-27 Marek Safar <marek.safar@gmail.com>
6158 * Makefile, *.sources : All C# compilers are in mcs folder.
6160 * *.cs: Use existing 2_1 define for smcs.
6162 2007-10-26 Marek Safar <marek.safar@gmail.com>
6164 A fix for bug #335847
6165 * assign.cs, expression.cs: Couple of changes to avoid creating a
6166 temporary variable for each object initializer assignment statement. It
6167 simplifies struct initialization too, otherwise two temporary variables
6169 Implemented optimization of redundant default element initializers.
6171 2007-10-25 Marek Safar <marek.safar@gmail.com>
6173 A fix for bug #336766
6174 * expression.cs (Class.CheckBase): Use generic name when method is
6177 2007-10-25 Marek Safar <marek.safar@gmail.com>
6179 A fix for bug #334737
6180 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6181 variable and not variable argument for prepared copies.
6183 2007-10-24 Marek Safar <marek.safar@gmail.com>
6185 A fix for bug #325110
6186 * class.cs, expression.cs, attribute.cs: Use open generic method when
6187 checking conditional attribute.
6189 2007-10-24 Marek Safar <marek.safar@gmail.com>
6191 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6192 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6193 FeatureIsNotAvailable.
6195 2007-10-24 Marek Safar <marek.safar@gmail.com>
6197 ** C# 3.0 Partial methods
6199 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6200 methods support. Because of member cache issue with generics only
6201 non-generics partial methods are fully supported.
6203 2007-10-23 Marek Safar <marek.safar@gmail.com>
6205 * class.cs, decl.cs: Rewrote member overloads check to cope with
6206 generics and to use member cache for member checking. It also improves
6207 performance and fixes remaining overloads issues.
6209 2007-10-20 Marek Safar <marek.safar@gmail.com>
6211 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6212 roottypes.cs, typemanager.cs:
6214 A member cache creation logic changed to add members immediately and
6215 not rely on fallback. The member cache is now only prefered way
6216 how to access and find type declaration members. It saves 5 MB of memory
6217 during MWF compilation and makes code ready for more optimizations and
6218 clean-ups, it's also a pre-requirement for partial methods.
6220 2007-10-18 Raja R Harinath <harinath@gmail.com>
6222 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6223 handling for generic parameters.
6225 2007-10-15 Marek Safar <marek.safar@gmail.com>
6227 * class.cs (FixedField): Removed redundant volatile check.
6229 2007-10-15 Marek Safar <marek.safar@gmail.com>
6231 * class.cs, decl.cs: Fixed overload members verification to do only one
6232 check per possible collision.
6234 2007-10-13 Marek Safar <marek.safar@gmail.com>
6236 A fix for bug #325478
6237 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6238 and create only one disposable flags container.
6240 2007-10-12 Marek Safar <marek.safar@gmail.com>
6242 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6243 * statement.cs (Fixed): Fixed variables cloning.
6245 2007-10-12 Marek Safar <marek.safar@gmail.com>
6247 A fix for bug #333342
6248 * class.cs (EventField): Don't mark value type event as synchronized.
6250 2007-10-12 Marek Safar <marek.safar@gmail.com>
6252 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6253 inference to identify best candidate method correctly.
6254 (ProperyExpr): A range variable is read only and cannot be modified.
6256 2007-10-11 Marek Safar <marek.safar@gmail.com>
6258 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6259 logic to identify best candidate method correctly.
6261 2007-10-11 Marek Safar <marek.safar@gmail.com>
6263 * location.cs (Equals, GetHashCode): Removed.
6265 2007-10-11 Marek Safar <marek.safar@gmail.com>
6267 * report.cs: Implemented message recorder. It is used mainly for lambda
6268 expressions to capture otherwise swallowed error messages.
6270 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6272 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6274 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6276 * expression.cs (MemberAccess): Always report lookup failure.
6278 * location.cs: Implemented Equals, GetHashCode.
6280 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6282 2007-10-10 Jb Evain <jbevain@novell.com>
6284 * codegen.cs: re-enable assembly version check.
6286 2007-10-09 Marek Safar <marek.safar@gmail.com>
6288 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6291 * namespace.cs (UsingAlias): Do correct version check.
6293 2007-10-08 Marek Safar <marek.safar@gmail.com>
6295 * expresison.cs, ecore.cs: Issue extension method error message when
6298 * rootcontext.cs: Added ISO_2 compiler mode option.
6300 2007-10-08 Marek Safar <marek.safar@gmail.com>
6302 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6305 2007-10-08 Marek Safar <marek.safar@gmail.com>
6307 * attribute.cs (GetString, GetBoolean): Work with both literal and
6310 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6311 Moved method overload specific methods to MethodGroupExpr.
6313 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6314 it should be less memory consuming.
6316 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6318 * codegen.cs: remove the assembly version check until the buildbot is
6321 2007-10-07 Jb Evain <jbevain@novell.com>
6323 * attribute.cs (Attribute.GetString): if the value
6324 expression is a StringConstant, return its string value.
6326 2007-10-07 Jb Evain <jbevain@novell.com>
6328 * typemanager.cs: add `assembly_version_attribute_type`.
6329 * codegen.cs: on attribute emission, check that the
6330 AssemblyVersionAttribute doesn't overflow.
6332 2007-10-05 Marek Safar <marek.safar@gmail.com>
6334 A fix for bug #324677
6335 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6336 parent container of a scope container with currently resolved one.
6338 2007-10-05 Marek Safar <marek.safar@gmail.com>
6340 A fix for bug #325534
6341 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6344 2007-10-05 Marek Safar <marek.safar@gmail.com>
6346 A fix for bug #327504
6347 * class.cs (Operator.Define): Refactored implicit and explicit user
6348 operator conversion rules.
6350 2007-10-05 Marek Safar <marek.safar@gmail.com>
6352 A fix for bug #327520
6353 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6355 2007-10-04 Marek Safar <marek.safar@gmail.com>
6357 A fix for bug #328022
6358 * class.cs (MethodData.Define): Use correct method to check whether
6359 a method implementents an accessor.
6361 2007-10-04 Marek Safar <marek.safar@gmail.com>
6363 A fix for bug #330069
6364 * statement.cs (Fixed.Resolve): Read the first array element only when
6365 an array is instantiated.
6367 2007-10-04 Marek Safar <marek.safar@gmail.com>
6369 * expression.cs, assign.cs, generics.cs: Print correct operator when
6370 compound assignment is used.
6372 2007-10-04 Marek Safar <marek.safar@gmail.com>
6374 A fix for bug #325841
6375 * expression.cs (ArrayAccess): Use full argument cloning only for
6376 string compound concatenation.
6378 2007-10-03 Marek Safar <marek.safar@gmail.com>
6380 A fix for bug #328774
6381 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6383 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6386 2007-10-03 Raja R Harinath <rharinath@novell.com>
6389 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6390 Event accessibility checks here. Remove some bogus code that
6391 accidently made GenericMethods work.
6392 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6394 2007-09-25 Marek Safar <marek.safar@gmail.com>
6396 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6398 * statement.cs (Block): Refactored AddVariable to allow error handling
6401 * generic.cs: New stub.
6403 2007-09-23 Marek Safar <marek.safar@gmail.com>
6405 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6408 2007-09-17 Marek Safar <marek.safar@gmail.com>
6410 * class.cs: Use partial container to record whether any partial part
6411 contains static field initializer and therefore default contructor has
6414 2007-09-14 Marek Safar <marek.safar@gmail.com>
6416 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6417 mono-list when only one of two partial parts has defined accessibility
6420 2007-09-14 Marek Safar <marek.safar@gmail.com>
6422 A fix for bug #82845
6424 * class.cs (TypeContainer): Set correct resolve context for all field
6427 2007-09-13 Marek Safar <marek.safar@gmail.com>
6429 * assign.cs: Fixed a crash when field is resolved twice with an error.
6431 * codegen.cs: Changed InFieldInitializer to be flag.
6433 * anonymous.cs, ecore.cs, expression.cs: Update after
6434 IsInFieldInitializer rename.
6436 * const.cs: Removed unused parameter.
6438 * class.cs: Changed the way how we resolve and emit field initializers.
6439 The field initilizers have to have access to contructor block to emit
6440 compiler generated code.
6442 2007-09-13 Marek Safar <marek.safar@gmail.com>
6444 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6445 generics use TypeContainer instead.
6447 2007-09-12 Marek Safar <marek.safar@gmail.com>
6449 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6451 * lambda.cs (ResolveParameters): Use more powerful
6452 InflateGenericArgument.
6454 * parameters.cs: Better exception message.
6456 2007-09-10 Marek Safar <marek.safar@gmail.com>
6458 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6459 correct expression block type.
6461 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6463 * expression.cs (Invocation): Extracted method group resolve to
6466 2007-09-07 Marek Safar <marek.safar@gmail.com>
6468 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6469 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6471 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6472 generic extension methods.
6474 2007-09-06 Marek Safar <marek.safar@gmail.com>
6476 A fix for bug #82676 (Do I get it right now?)
6477 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6478 object before a standard conversion is applied.
6480 2007-09-06 Marek Safar <marek.safar@gmail.com>
6482 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6485 2007-09-05 Marek Safar <marek.safar@gmail.com>
6487 A fix for bug #82676
6488 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6489 non-generic interface types.
6491 2007-09-05 Marek Safar <marek.safar@gmail.com>
6493 A fix for bug #82690
6494 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6496 2007-09-05 Marek Safar <marek.safar@gmail.com>
6498 A fix for bug #82571
6499 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6500 modifier for container based methods.
6502 2007-09-05 Marek Safar <marek.safar@gmail.com>
6504 A fix for bug #82676
6505 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6506 any interface-type T means to any of interface type T.
6508 2007-09-04 Marek Safar <marek.safar@gmail.com>
6510 * namespace.cs: We have 2 versions of System.Core assembly.
6512 2007-09-04 Marek Safar <marek.safar@gmail.com>
6514 A fix for bug #82652
6515 * class.cs (Class.GetClassBases): Compare types and not expressions.
6517 2007-09-04 Marek Safar <marek.safar@gmail.com>
6519 A fix for bug #82620
6520 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6521 actually never worked before.
6522 (IndexerAccess): Emit prepared arguments before they are modified.
6524 2007-09-04 Marek Safar <marek.safar@gmail.com>
6526 A fix for bug #82563
6527 * assign.cs: Revert wrong fix.
6529 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6531 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6532 Instead of ldelema/stdind we have to use temporary variables to handle
6533 cases like String.Concat (params string[]).
6535 2007-08-31 Marek Safar <marek.safar@gmail.com>
6537 * class.cs: EmitAttributes to Emit rename.
6539 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6541 (MemberCore.HasClsCompliantAttribute): Don't depend on
6542 GetClsCompliantAttributeValue execution.
6544 2007-08-31 Marek Safar <marek.safar@gmail.com>
6546 * anonymous.cs: Use shorter type prefix.
6548 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6551 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6552 variables when probing is on.
6554 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6555 unresolved variables.
6556 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6557 handle transparent identifiers.
6559 2007-08-26 Marek Safar <marek.safar@gmail.com>
6561 * attribute.cs (IsClsCompliant): Add nullable types test.
6563 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6565 * doc.cs : catch other types of exception than XmlException to
6566 report CS1570. Fixed bug #82565.
6568 2007-08-23 Marek Safar <marek.safar@gmail.com>
6570 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6571 The number of delegate parameters has to match.
6572 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6575 2007-08-21 Marek Safar <marek.safar@gmail.com>
6577 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6578 to fix problem with private arguments.
6580 2007-08-20 Marek Safar <marek.safar@gmail.com>
6582 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6584 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6586 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6587 empty. Add cloning suport.
6589 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6591 2007-08-20 Marek Safar <marek.safar@gmail.com>
6593 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6594 to create EmptyCast. It handles EmptyConstantCast specialization for
6597 2007-08-18 Marek Safar <marek.safar@gmail.com>
6599 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6600 (EmitArrayArgument): One routine for array arguments.
6601 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6603 2007-08-17 Marek Safar <marek.safar@gmail.com>
6605 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6607 2007-08-17 Marek Safar <marek.safar@gmail.com>
6609 * anonymous.cs: MemberLookupFinal update.
6611 * class.cs (ConstructorInitializer): Is expression based.
6613 * delegate.cs: MethodGroupExpr update.
6615 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6617 (Error_MemberLookupFailed): Customizable error override.
6618 (MethodGroupExpr): Keep queried type for later usage.
6619 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6622 * expression.cs: Error_MemberLookupFailed refactoring.
6623 (New.DoResolve): Resolve as much as possible.
6624 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6625 customization for invalid member types.
6627 * statement.cs: MethodGroupExpr update.
6629 2007-08-16 Marek Safar <marek.safar@gmail.com>
6631 * modifier.cs (Check): Check all modifiers and not only accessibility
6634 2007-08-16 Marek Safar <marek.safar@gmail.com>
6636 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6637 type and not an expression.
6639 2007-08-16 Marek Safar <marek.safar@gmail.com>
6641 * statement.cs (Catch.Clone): Type and variable can be null.
6643 2007-08-16 Marek Safar <marek.safar@gmail.com>
6645 A fix for bug #81979
6646 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6647 I am really not sure whether this is the best fix.
6649 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6652 2007-08-14 Marek Safar <marek.safar@gmail.com>
6654 ** C# 3.0 Object and collection initializers (major re-write)
6656 * assign.cs (DoResolve): Initializers are not assign related.
6658 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6659 used during collection or object initialization.
6661 * expression.cs (Error_InvalidArguments): Add initializers specific
6662 messages. More will come later because it requires some general
6664 (New.DoResolve): Better error handling for unsafe types.
6665 (EmptyExpressionStatement): New class.
6666 (ElementInitializer): An object initializer expression.
6667 (CollectionElementInitializer): A collection initializer expression.
6668 (CollectionOrObjectInitializers): A block of object or collection
6670 (NewInitialize): New expression with element/object initializers.
6672 * statement.cs: Reverted object/collection initializer hacks.
6674 * typemanager.cs (CSharpName): Filter __arglist type.
6676 2007-08-09 Marek Safar <marek.safar@gmail.com>
6678 ** C# 3.0 Anonymous Types (update to the latest standard)
6680 * expression.cs (Binary.ResolveOperator): Threat all null based types
6682 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6683 (AnonymousTypeParameter): Updated.
6685 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6686 (AnonymousTypeClass): New anonymous type container.
6688 * class.cs (AddField): Return operation result.
6690 * generic.cs: Another empty TypeArguments overload.
6692 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6693 are stored at top of normal hierarchy.
6695 * typemanager.cs (CSharpName): Filter anonymous types.
6697 2007-08-09 Marek Safar <marek.safar@gmail.com>
6699 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6700 as single Concat call. How could we miss that :-(
6702 2007-08-08 Marek Safar <marek.safar@gmail.com>
6704 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6706 2007-08-07 Miguel de Icaza <miguel@novell.com>
6708 * expression.cs: Fix the previous commit, the creation of the
6709 arguments array list needs also to be conditional on the arguments
6712 * class.cs: Add a little bit of help to help narrow down problems.
6714 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6715 not try to copy in that case.
6717 * driver.cs: When building SMCS, include a new different set of
6718 default assemblies here. Do this here so we can control whether
6719 to include the default assemblies with /noconfig.
6721 2007-08-03 Marek Safar <marek.safar@gmail.com>
6723 A fix for bug #81979
6724 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6727 2007-08-03 Marek Safar <marek.safar@gmail.com>
6729 A fix for bug #82300
6731 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6732 we are in probing scope.
6734 2007-08-03 Marek Safar <marek.safar@gmail.com>
6736 A fix for bug #82301
6738 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6739 (Statement.CloneTo): Clone and not map children blocks.
6741 2007-08-03 Marek Safar <marek.safar@gmail.com>
6743 A fix for bug #82299
6745 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6748 * statement.cs (Statement.CloneTo): Clone variables before statements
6749 to allow remaping of local variables.
6751 2007-08-03 Marek Safar <marek.safar@gmail.com>
6753 A fix for bug #82296
6756 * report.cs: Log crash details for future clone problems.
6758 * statement.cs (Return.Clone): Don't clone non-existent expression.
6760 2007-08-03 Raja R Harinath <harinath@gmail.com>
6762 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6763 (Class.AddBasesForPart): Move CS0537 check here from ...
6764 * cs-parser.jay (class_declaration): ... here. Move calling of
6765 'AddBasesForPart' to ...
6766 (class_bases): ... here.
6767 (struct_declaration, interface_declaration): Update to changes.
6769 2007-08-02 Marek Safar <marek.safar@gmail.com>
6771 A fix for bug #81923
6773 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6774 conversion is allowed.
6776 2007-08-02 Marek Safar <marek.safar@gmail.com>
6778 A fix for bug #81564
6780 * ecore.cs (EventExpr): Add IsBase handling.
6782 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6785 2007-08-02 Raja R Harinath <harinath@gmail.com>
6787 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6788 * cs-parser.jay: Some whitespace cleanups.
6789 (current_delegate): New.
6791 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6792 a dummy code block, and use 'type_name' instead of 'member_name'.
6793 (interface_declaration, class_declaration): Likewise.
6794 (delegate_declaration): Likewise. Rearrange slightly and use
6796 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6797 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6799 2007-08-02 Marek Safar <marek.safar@gmail.com>
6801 A fix for bug #82039
6803 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6806 * typemanager.cs (CSharpName): Split to string overload.
6808 2007-08-02 Marek Safar <marek.safar@gmail.com>
6811 * report.cs: Updated warning CS0472.
6813 2007-08-01 Marek Safar <marek.safar@gmail.com>
6815 A fix for bug #82181
6817 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6819 2007-08-01 Marek Safar <marek.safar@gmail.com>
6821 A fix for bug #82277
6822 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6824 2007-08-01 Marek Safar <marek.safar@gmail.com>
6826 ** C# 3.0 Type Inference (major bits are working)
6828 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6829 (.ImplicitStandardConversionExists): Uses compatible.
6830 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6831 (.InferReturnType): New method.
6832 (.Compatible): Refactored.
6833 (.ResolveParameters): Uses factory to create resolved parameters.
6834 (.CompatibleMethod): Add probing mode support.
6835 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6836 clearly distinguish between 2 different operations.
6837 (LambdaMethod): Moved to lambda.cs.
6838 (AnonymousMethod): Removed unused fields and methods.
6839 (AnonymousDelegate): Simplified.
6841 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6843 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6845 * delegate.cs (Delegate): New mehods to reduce code duplication.
6846 (.GetConstructor): New method.
6847 (.GetInvokeMethod): New method.
6848 (DelegateCreation): Updated.
6850 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6852 (OverloadResolve): Made probing little bit faster.
6854 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6857 * generic.cs (TypeInferenceContext): Dummy implementation.
6859 * iterators.cs: Updated after Resolve/Define rename.
6861 * lambda.cs (LambdaExpression)
6862 (.ResolveParameters): Handles both type of arguments and type inference too.
6864 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6865 (InflateTypes): Updated.
6867 * support.cs (InflateTypes): Changed signature and updated.
6869 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6870 (MemberLookup_FindMembers): More MS tricks.
6871 (GetParameterData): Ditto.
6872 (GetDelegateParameters): Uses quick path for dynamic types.
6874 2007-08-01 Marek Safar <marek.safar@gmail.com>
6876 * class.cs (MethodData.Define): EmitContext is required for generic stuff
6879 2007-07-31 Marek Safar <marek.safar@gmail.com>
6881 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
6884 2007-07-26 Jb Evain <jbevain@novell.com>
6886 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
6887 which takes a boolean 'report_errors', similar to the GetMethod.
6888 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
6889 in .net 2.1, do not report errors here.
6891 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
6892 System.Runtime.CompilerServices.RequiredAttributeAttribute and
6893 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
6896 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
6897 of the type InternalsVisibleToAttribute before the first call
6898 to CoreLookupType which is allowed to fail (third boolean parameter
6899 to true). Because, during the resolution for a type that is not
6900 immediately found, we try to check if the type is not defined in
6901 a friend assembly, and to do so, we need the
6902 InternalVisibleToAttribute.
6904 2007-07-23 Miguel de Icaza <miguel@novell.com>
6906 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
6907 feature that allows structs to be compared against null and inline
6908 the result as true or false.
6910 Notice that the same code is not permitted inside a generic block
6911 of code that would do:
6913 class Foo<T> where T : struct {
6920 It is only allowed if the type of T is not bound (no where
6921 clause). In my opinion, this CSC 2 behavior is broken but people
6922 seem to be using it (IronRuby does, a few bug reports on bugzilla
6923 have it and some people have complained about it).
6925 All of the users that depend on this behavior have code that is
6928 * report.cs (Warning, Error): make these take object arguments,
6929 not strings, as that allows us to take advantage of Format.
6931 2007-07-20 William Holmes <billholmes54@gmail.com>
6933 * decl.cs: Changed MemberName.CountTypeArguments to also check the
6934 Left member variable for the Count.
6935 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
6936 MemberName.CountTypeArguments to avoid a NRE.
6938 This code is contributed under the MIT X11 license
6940 2007-07-18 Marek Safar <marek.safar@gmail.com>
6942 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
6944 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6946 * doc.cs : generic method arguments are written as ``x while generic
6947 type arguments are `x. Combined with the previous change, fixed bug
6950 2007-07-18 Raja R Harinath <rharinath@novell.com>
6953 * expression.cs (Binary.ResolveOperator): When converting
6954 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
6956 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6958 * doc.cs : when T: or whatever x: is specified, it does not really
6959 check the doc comment's syntax correctness. Fixed bug #82006.
6961 2007-07-18 Marek Safar <marek.safar@gmail.com>
6963 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
6964 LambdaExpression better.
6966 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
6968 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
6970 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
6971 as it can be generated.
6973 * expression.cs (Invocation.Error_InvalidArguments): Show correct
6976 * lambda.cs (LambdaExpression): Refactored to share same code with
6977 AnonymousMethodExpression.
6979 2007-07-17 Marek Safar <marek.safar@gmail.com>
6981 * anonymous.cs (MakeName): Include host name for easier debugging.
6982 (LambdaMethod): New class for lambda spcecific stuff.
6984 * attribute.cs: Set EmitContext return type.
6986 * class.cs: Set EmitContext return type.
6988 * codegen.cs (EmitContext): Return type cannot be null to stop messing
6989 with null/void meaning.
6991 * iterators.cs (ContainerType): Implemented.
6993 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
6995 * statement.cs (Return): Updated to lambda expressions.
6996 (Block.CloneTo): Parent can be null.
6998 2007-07-13 Marek Safar <marek.safar@gmail.com>
7000 A fix for bug #81917
7001 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7003 * class.cs (FixedField): Check whether field is in unsafe scope.
7005 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7006 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7008 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7011 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7013 2007-07-13 Marek Safar <marek.safar@gmail.com>
7015 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7016 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7019 2007-07-13 Marek Safar <marek.safar@gmail.com>
7021 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7023 2007-07-13 Marek Safar <marek.safar@gmail.com>
7025 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7026 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7028 * codegen.cs(EmitContext): Add ProbingMode flag.
7030 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7032 * driver.cs: For now set both warning values.
7034 * ecore.cs (SimpleName): Name is readonly.
7035 (MethodGroup.OverloadResolve): One quick path for probing.
7037 * expression.cs (Unary): Set Oper r/o.
7038 (Binary): Set Oper r/o.
7039 (ParameterReference): Set few instance variables as r/o.
7040 (ParameterReference.DoResolveBase): Don't capture aruments when
7042 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7043 (Arglist): arguments are private.
7044 (SizeOf): type is private and r/o.
7045 (MemberAccess): arguments are private.
7047 * report.cs: Enhanced reporting on/off capabilities.
7049 * lambda.cs: Uses ec.IsInProbingMode.
7050 (ContextualReturn): Derives from return.
7052 * rootcontext.cs: For now set both warning values.
7054 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7056 (Return.Resolve): Don't die immediately.
7057 (Block.Resolve): Speed-up probing.
7058 (Block.CloneTo): Clone only child blocks.
7060 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7062 * iterators.cs: reverted Miguel's latest change (r81925) as it
7063 breaks the build in System.
7065 2007-07-13 Miguel de Icaza <miguel@novell.com>
7067 * iterators.cs (Yield.CheckContext): Check for the iterator type
7068 also here as we can call into Yield even in codepaths that are not
7070 (MethodOrOperator is the only path that was checked).
7072 In addition to the standard check, use a more specific check for
7073 constructors to report a more verbose error.
7075 2007-07-12 Miguel de Icaza <miguel@novell.com>
7077 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7078 report the warning and continue
7080 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7081 values on the stack on the call to Emit. Use EmitStatement if
7082 possible, or using Emit + Pop if not possible. Fixes #82064
7084 2007-07-12 Raja R Harinath <rharinath@novell.com>
7086 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7087 avoid try...finally in some cases.
7089 2007-07-10 Marek Safar <marek.safar@gmail.com>
7091 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7093 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7094 instead of method. Re-use standard error handling.
7095 (ConstructorInitializer.Emit): Simplified.
7097 * delegate.cs: Updated after Invocation.EmitCall change.
7099 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7100 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7101 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7102 method and don't permanently changing input arguments.
7103 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7104 is resolved it has one of the candidates is the best one which is later
7105 used to emit. Removed a few unused method.
7106 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7108 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7109 (Binary.ResolveOperator): Ditto.
7110 (ConditionalLogicalOperator.DoResolve): Ditto.
7111 (Invocation): Uses method group.
7112 (Invocation.DoResolve): Simplified.
7113 (Invocation.EmitCall): Removed useless is_static.
7114 (Invocation.Emit): Delegate to method group.
7115 (Invocation.EmitStatement): Simplified.
7116 (New): Uses method group.
7117 (MemberAccess.DoResolve): Don't destroy original expression.
7119 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7121 2007-07-04 Marek Safar <marek.safar@gmail.com>
7123 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7126 * lambda.cs: Add custom error message type.
7128 2007-07-03 Marek Safar <marek.safar@gmail.com>
7130 * lambda.cs: Simplified little bit.
7132 * parameter.cs: Introduced ImplicitLambdaParameter.
7133 (Parameters.CreateFullyResolved): New factory instead of ctor.
7137 * delegate.cs: Updated parameter creation.
7139 2007-07-03 Marek Safar <marek.safar@gmail.com>
7141 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7144 * generic.cs: Synchronized with gmcs.
7146 2007-07-03 Marek Safar <marek.safar@gmail.com>
7148 * class.cs (Indexer): Check return type as soon as possible.
7150 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7153 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7155 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7157 * parameter.cs (Parameter): Use expression type when it is available.
7159 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7160 method modifier for the first parameter only.
7162 2007-06-24 Marek Safar <marek.safar@gmail.com>
7164 A fix for bug #81938
7165 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7167 * constant.cs: Tide up an exception message.
7169 2007-06-22 Marek Safar <marek.safar@gmail.com>
7171 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7172 an uninitialized variable is used.
7174 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7176 2007-06-22 Marek Safar <marek.safar@gmail.com>
7178 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7179 not found error handling.
7181 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7183 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7184 (ArrayCreation.DoResolve): Simplified.
7185 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7186 its own resolve process.
7187 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7189 2007-06-20 Marek Safar <marek.safar@gmail.com>
7191 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7194 2007-06-20 Marek Safar <marek.safar@gmail.com>
7196 * cs-tokenizer.cs: Removed var related stuff.
7198 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7199 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7200 a type and a keyword at same time.
7202 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7205 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7206 implicitly typed arrays, more changes will follow.
7208 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7210 2007-06-19 Marek Safar <marek.safar@gmail.com>
7212 * ecore.cs (VarExpr): Removed Handled field.
7214 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7215 build-in assign functionality.
7216 (ForEach.Resolve): Removed all implicitly typed local variable code and
7218 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7219 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7221 2007-06-18 Marek Safar <marek.safar@gmail.com>
7223 * assign.cs: Removed implicitly typed local variable check.
7225 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7226 referencing implicitly typed local variable.
7227 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7230 * statement.cs (Fixed): Removed unsupported implicitly typed local
7233 2007-06-15 Marek Safar <marek.safar@gmail.com>
7235 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7237 2007-06-14 Marek Safar <marek.safar@gmail.com>
7239 A fix for bugs #81855 and #76274
7240 * attribute.cs (AttachTo): Always set owner for global attributes to
7243 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7246 * cs-parser.jay: Assembly and module attributes must precede all other
7247 elements except using clauses and extern alias declarations.
7249 2007-06-13 Marek Safar <marek.safar@gmail.com>
7251 A fix for bug #81748
7253 * expression.cs: More checks for non ISO-1 features.
7255 2007-06-12 Marek Safar <marek.safar@gmail.com>
7257 A fix for bug #81807
7258 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7259 present inside switch statement and it is required by nullable check.
7261 2007-06-12 Marek Safar <marek.safar@gmail.com>
7263 A fix for bug #81840
7264 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7265 when type matching fails.
7267 * namespace.cs: Tiny error message change.
7269 2007-06-12 Marek Safar <marek.safar@gmail.com>
7271 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7272 reporting. Added automatic property check.
7274 * class.cs: Updated after CheckAbstractAndExtern relocation.
7275 (AEventPropertyAccessor.GetSignatureForError): Customized.
7277 2007-06-11 Marek Safar <marek.safar@gmail.com>
7279 * class.cs (DefineBaseTypes): Base type can be undefined.
7281 * ecore.cs (TypeLookup): Minor refactoring.
7282 (DoResolveAsTypeStep): Removed redundant check.
7284 * namespace.cs (Lookup): Removed redundant check.
7286 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7287 ResolveAsTypeTerminal step.
7288 (BootstrapCorlib_*): Simplified.
7289 (PopulateCoreType): Core types can be now external.
7291 2007-06-07 Marek Safar <marek.safar@gmail.com>
7293 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7295 (InferTypeArguments): Infers anonymous expression type arguments.
7296 (Compatible): Split to Compatible and InferTypeArguments.
7298 * lambda.cs: Updated.
7300 2007-06-08 Marek Safar <marek.safar@gmail.com>
7302 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7304 2007-06-07 Raja R Harinath <harinath@gmail.com>
7306 Fix #80477, cs0135-2.cs, cs0135-3.cs
7307 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7308 names to the "known" variables list.
7309 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7310 parameter names are also "known".
7311 (Block.CheckError136): Remove.
7312 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7315 2007-06-07 Marek Safar <marek.safar@gmail.com>
7317 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7319 2007-06-06 Marek Safar <marek.safar@gmail.com>
7321 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7322 internal error not an user error.
7324 * expression.cs (IsApplicable): Refactored to make debugging easier.
7326 * support.cs: More tricks for non-mono runtimes.
7328 * typemanager.cs (CoreLookupType): Made public.
7329 (InitSystemCore): All linq specific stuff moved to linq.cs
7331 2007-06-05 Marek Safar <marek.safar@gmail.com>
7333 * typemanager.cs (CSharpSignature): One more missing build-in types
7335 More tricks for non-mono runtime.
7337 2007-06-05 Raja R Harinath <harinath@gmail.com>
7339 * statement.cs (Block.CheckError136_InParents): Remove.
7340 (Block.AddVariable): Use GetParameterInfo instead.
7341 (ToplevelBlock.ProcessArguments): Likewise.
7343 2007-06-04 Raja R Harinath <rharinath@novell.com>
7345 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7347 (ToplevelBlock.GetParameterInfo): Split out of ...
7348 (ToplevelBlock.GetParameterRefernce): ... this.
7349 (ToplevelBlock.ParameterMap): Remove.
7350 * expression.cs (ParameterReference): Update to use
7351 ToplevelParameterInfo.
7353 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7356 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7357 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7359 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7360 (ToplevelBlock.ProcessParameters) ... here.
7361 (ToplevelBlock..ctor): Invoke it.
7363 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7366 * statement.cs (IKnownVariable): New interface.
7367 (LocalInfo): Implement it.
7368 (ToplevelParameterInfo): New class.
7369 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7370 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7371 GetKnownVariableInfo.
7373 2007-06-03 Raja R Harinath <harinath@gmail.com>
7375 Partly speed up CS0136 error checks.
7376 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7377 'recurse' parameter.
7378 (Block.DoCheckError136): Only check errors in parameters. Move
7379 local variable checks ...
7380 (Block.AddVariable): ... here, and ...
7381 (ToplevelBlock.ResolveMeta): ... here.
7383 2007-06-02 Raja R Harinath <harinath@gmail.com>
7385 * statement.cs (Block.IsChildOf): Remove.
7387 * statement.cs (Statement.Clone): Move special case code ...
7388 (Block.CloneTo): ... here.
7390 2007-05-29 Raja R Harinath <rharinath@novell.com>
7392 * statement.cs (ToplevelBlock.container): Remove field. It's
7393 redundant with 'Parent'.
7394 (ToplevelBlock.ContainerBlock): Remove accessor.
7395 (ToplevelBlock..ctor): Update to changes. Register anonymous
7396 child with parent here, ...
7397 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7399 (start_anonymous): Don't save current_block.
7400 (top_current_block): Remove.
7402 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7403 (Block.Resolve): Update to changes.
7404 (Block..ctor): Move setting of "correct" 'Toplevel'
7405 and 'Explicit' fields to ...
7406 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7408 2007-05-27 Raja R Harinath <harinath@gmail.com>
7411 * statement.cs (Block.Implicit): Remove.
7412 (Block): Update to changes.
7413 * flowanalysis.cs: Likewise.
7415 Mildly speed up CheckInvariantMeaningInBlock
7416 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7417 Recursively call AddKnownVariable to all enclosing blocks.
7418 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7419 Remove recursive calls.
7420 (Block): Update to changes.
7422 New ExplicitBlock invariants
7423 * statement.cs (Block.Explicit): New field. It points to the
7424 immediately enclosing non-implicit block.
7425 (Block..ctor): Maintain the invariant.
7426 * cs-parser.jay: Take advantage of invariant.
7428 Introduce ExplicitBlock
7429 * statement.cs (ExplicitBlock): New.
7430 (ToplevelBlock): Derive from it.
7431 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7433 (Block.Implicit): Update to changes.
7434 * cs-parser.jay: Update to changes.
7437 * codegen.cs (EmitContext.IsLastStatement): Remove.
7438 * statement.cs (Block.DoEmit): Update to changes.
7440 2007-05-25 Raja R Harinath <rharinath@novell.com>
7442 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7443 modifying current_block directly.
7445 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7447 * class.cs: Implemented automatic properties (C# 3.0)
7448 Thanks to Marek for the help.
7450 2007-05-23 Raja R Harinath <rharinath@novell.com>
7452 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7453 variable as assigned, note also that all its components are
7455 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7457 2007-05-19 Marek Safar <marek.safar@gmail.com>
7459 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7460 member is marked as compiler generated.
7462 * decl.cs (MemberCore): Refactored ModFlags into property.
7464 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7465 (Check): Check only accessibility modifiers.
7467 2007-05-18 Raja R Harinath <rharinath@novell.com>
7469 Track all assignable slots in one bit array
7470 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7471 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7472 logic from VariableMap constructor here. Use the same 'offset'
7473 variable that's later used for computing offsets of local
7475 * flowanalysis.cs (UsageVector.parameters): Remove.
7476 (UsageVector): Update to changes.
7477 (VariableMap): Remove.
7479 Avoid creating ParameterMap in every block
7480 * statement.cs (Block.ParameterMap): Move ...
7481 (ToplevelBlock.ParameterMap): ... here.
7482 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7484 * flowanalysis.cs (FlowBranching.param_map): Remove.
7485 (FlowBranching.UsageVector): Update to changes.
7486 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7488 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7490 * expression.cs (ParameterReference): Distinguish between block
7491 where parameter was referenced and declared.
7493 2007-05-18 Marek Safar <marek.safar@gmail.com>
7495 * flowanalysis.cs, statement.cs: Put back improved error handling.
7497 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7501 Imporved object and collection initialization (C# 3.0).
7503 2007-05-15 Marek Safar <marek.safar@gmail.com>
7505 A fix for bug #81380
7506 * expression.cs (Is.DoResolve): Only value types have constant `is'
7509 2007-05-15 Raja R Harinath <rharinath@novell.com>
7511 * statement.cs (ToplevelBlock.child): Remove.
7513 2007-05-15 Raja R Harinath <harinath@gmail.com>
7515 Rationalize ResolveMeta: refactoring
7516 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7517 out constant handling code into ...
7518 (Block.DoResolveConstants): ... this.
7520 Rationalize ResolveMeta: kill local_map
7521 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7522 (Block.AssignableSlots): New.
7523 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7524 for locals -- move code from VariableMap here. Avoid unnecessary
7526 * flowanalysis.cs (FlowBranching.local_map): Remove.
7527 (FlowBranching..ctor): Use Block.AssignableSlots.
7528 (VariableMap): Remove unused constructors.
7530 2007-05-11 Raja R Harinath <rharinath@novell.com>
7532 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7534 2007-05-11 Marek Safar <marek.safar@gmail.com>
7536 * typemanager.cs (IsFriendAssembly): Should not be called for building
7539 2007-05-09 Marek Safar <marek.safar@gmail.com>
7541 * literal.cs (NullConstant): Print null in all cases.
7543 * expression.cs (Binary.ResolveOperator): Implemented delegate
7544 comparison based on C# 2.0 changes.
7546 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7548 This code is contributed under the MIT X11 license
7550 The following enables support for several C# 3.0 language features:
7552 * cs-tokenizer.cs: Added support for the "var" keyword.
7554 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7555 Added VarExpr class to facilitate type inferencing.
7557 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7558 to support anonymous types.
7560 * assign.cs: Added support for type inferencing and initialization.
7562 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7564 * expression.cs: Added implicit array support to ArrayCreation.
7565 Added 5 types and 1 interface:
7567 IInitializable Implementing classes can inject initializing
7568 statements after object instantiation.
7570 Initializer Stores data for object initialization.
7572 AnonymousType An expression for anonymous types.
7574 AnonymousTypeParameter Stores data about an anonymous type's field.
7576 NewInitialize An expression for object initialization.
7578 CollectionInitialize An expression for collection initialization.
7580 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7583 2007-05-06 Marek Safar <marek.safar@gmail.com>
7585 A fix for bug #81500
7586 * cs-tokenizer.cs: Add special handling for coalescing operator.
7588 2007-05-06 Marek Safar <marek.safar@gmail.com>
7590 A fix for bug #81529
7591 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7592 its value from base class until it is redefined.
7594 2007-05-02 Raja R Harinath <rharinath@novell.com>
7596 Fix regression in cs0631-3.cs
7597 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7598 fallback. Make error fallback catch more cases.
7600 2007-05-01 Miguel de Icaza <miguel@novell.com>
7602 * cs-parser.jay: Allow parameters in operator declarations to have
7605 2007-04-27 Miguel de Icaza <miguel@novell.com>
7607 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7610 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7611 inside the ContextualReturn, it does not have to be an
7612 ExpressionStatement.
7614 2007-04-24 Miguel de Icaza <miguel@novell.com>
7616 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7619 2007-04-23 Miguel de Icaza <miguel@novell.com>
7621 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7622 method in two methods: ResolveNoDefine and Resolve.
7624 ResolveNoDefine will stop just after ResolveTopBlock has been
7627 Resolve will then continue by creating a method and issuing the
7628 call to method.Define ().
7630 (AnonymousMethod): Split and implement the new Resolve and
7631 ResolveNoDefine as well.
7633 * lambda.cs (LambdaExpression): Split the anonymous method
7634 resolution code into a separate routine (CoreCompatibilityTest)
7635 from DoCompatibleTest.
7637 (LambdaExpression.TryBuild): New method, this method tries to
7638 build the LambdaExpression with the given set of types to be used
7639 as the types for the various parameters of the lambda expression.
7641 If the compilation succeed with the given types, the infered type
7642 of the Anonymous method is returned, otherwise null is returned.
7644 2007-04-23 Marek Safar <marek.safar@gmail.com>
7646 A fix for bug #81414
7647 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7649 2007-04-22 Miguel de Icaza <miguel@novell.com>
7651 * cs-tokenizer.cs: Change various identifiers here from the
7652 camelCasing to the recommended Linux-like style for instance
7653 variables from the Coding Guidelines.
7655 2007-04-19 Martin Baulig <martin@ximian.com>
7658 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7659 System.Enum to System.ValueType.
7661 2007-04-13 Martin Baulig <martin@ximian.com>
7663 Rewrote implicit reference conversions. We need to distinguish
7664 between implicit reference conversions (13.1.4) and implicit
7665 boxing conversions (13.1.5).
7667 According to the spec, there's an an implicit conversion
7668 "From a one-dimensional array-type S[] to IList<T> and base
7669 interfaces of this interface, provided there is an implicit
7670 reference conversion from S to T." Note that this does not
7671 include boxing conversions.
7674 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7675 (Convert.ImplicitReferenceConversion): Split into
7676 ImplicitReferenceConversionCore() and
7677 ImplicitBoxingConversionExist().
7678 (Convert.ImplicitReferenceConversionExists): Use the new
7679 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7681 2007-04-12 Martin Baulig <martin@ximian.com>
7683 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7684 `TypeManager.null_type' checks up to the top of the method.
7686 2007-04-11 Marek Safar <marek.safar@gmail.com>
7688 A fix for bug #81350
7689 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7692 2007-04-11 Martin Baulig <martin@ximian.com>
7694 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7695 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7696 to make this work for generic classes; fixes #79561.
7698 2007-04-11 Martin Baulig <martin@ximian.com>
7700 * expression.cs (As): Add support for nullable types; fixes #79371.
7702 2007-04-11 Martin Baulig <martin@ximian.com>
7704 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7705 `type.FullName' is null; fixes #80243.
7707 2007-04-11 Martin Baulig <martin@ximian.com>
7709 * expression.cs (Invocation.IsApplicable): Don't modify the method
7710 if type inference succeeded, but the method was not applicable.
7713 2007-04-10 Marek Safar <marek.safar@gmail.com>
7715 A fix for bug #81324
7716 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7717 internal and external namespaces containers.
7719 2007-04-10 Martin Baulig <martin@ximian.com>
7721 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7722 TypeManager.DropGenericMethodArguments() so we also call
7723 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7725 2007-04-10 Martin Baulig <martin@ximian.com>
7727 * iterators.cs (Iterator.CreateIterator): Don't crash if
7728 `method.ReturnType' is null. This happens if something went wrong
7729 while resolving that typ (we already reported an error in this case).
7731 2007-04-10 Martin Baulig <martin@ximian.com>
7733 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7734 generic interfaces; report the CS0144 directly.
7736 2007-04-10 Martin Baulig <martin@ximian.com>
7738 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7739 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7741 2007-04-10 Martin Baulig <martin@ximian.com>
7743 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7745 2007-04-09 Raja R Harinath <rharinath@novell.com>
7748 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7749 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7752 * statement.cs (For.Resolve): If resolution fails, use
7755 2007-04-08 Marek Safar <marek.safar@gmail.com>
7757 * anonymous.cs (MakeName): Make faster and zero-based.
7758 (VerifyExplicitParameterCompatibility): Back to mode where generic
7759 parameter is ignored.
7760 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7762 * class.cs (EmitType): Method can emit another new method.
7764 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7766 * driver.cs: Updated.
7768 * lambda.cs: Reuse predefined empty parameters.
7770 * parameter.cs: Updated
7772 * support.cs: Implemented InflateTypes.
7774 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7775 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7777 2007-04-03 Martin Baulig <martin@ximian.com>
7781 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7782 version of TypeManager.IsOverride() which also works with generic
7785 2007-04-03 Martin Baulig <martin@ximian.com>
7790 (Convert.ExplicitReferenceConversion): We need to cast when
7791 converting from IList<T> to S[].
7793 2007-04-01 Marek Safar <marek.safar@gmail.com>
7795 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7798 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7800 2007-03-31 Marek Safar <marek.safar@gmail.com>
7802 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7803 argument and return type inferring.
7805 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7806 (ReturnType): Turned to property.
7808 * statement.cs (Return): Implemented return type inferring.
7810 * support.cs (ReflectionParameters): Use local types if possible.
7812 2007-03-30 Raja R Harinath <rharinath@novell.com>
7814 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7815 (FlowBranching.UsageVector): Update to changes.
7817 Prepare to kill 'Reachability'
7818 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7819 argument of constructor.
7821 2007-03-29 Raja R Harinath <rharinath@novell.com>
7823 Prepare to kill 'Reachability'
7824 * flowanalysis.cs (UsageVector.is_unreachable): New.
7825 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7826 'reachability', and verify they're consistent.
7829 * expression.cs (New.EmitStatement): Handle type parameters here too.
7831 2007-03-29 Martin Baulig <martin@ximian.com>
7836 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7837 CompilerGeneratedClass.
7838 (ScopeInfo.EmitScopeInstance): Make this protected.
7839 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7840 `ec.CurrentAnonymousMethod.Scope == Scope'.
7842 * statement.cs (Block.ScopeInfo): Make this a property.
7844 2007-03-27 Raja R Harinath <harinath@gmail.com>
7846 Prepare to kill 'Reachability'
7847 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7848 (FlowBranching.UsageVector.Reachability): Remove property.
7849 (FlowBranching.UsageVector.IsUnreachable): New property.
7850 (FlowBranching.UsageVector.ResetBarrier): New.
7851 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7852 * codegen.cs, statement.cs: Update to changes.
7854 2007-03-27 Martin Baulig <martin@ximian.com>
7859 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7862 2007-03-26 Raja R Harinath <rharinath@novell.com>
7864 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7865 instead of TriState. Remove all mention of TriState.
7867 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7868 replaced by a boolean. Add boolean 'is_unreachable' field, check
7869 and maintain invariants.
7871 2007-03-25 Marek Safar <marek.safar@gmail.com>
7873 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
7875 2007-03-25 Marek Safar <marek.safar@gmail.com>
7877 * expression.cs: Stop using obsolete 2.0 opcodes.
7879 2007-03-25 Marek Safar <marek.safar@gmail.com>
7881 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
7882 one of the latests Martin's fixes.
7884 2007-03-23 Miguel de Icaza <miguel@novell.com>
7886 * expression.cs: On BigEndian systems, swap the bytes, temporary
7887 solution until we get a new bitconverter class.
7889 2007-03-23 Martin Baulig <martin@ximian.com>
7893 * decl.cs (MemberCache.AddMembers): Add generic methods both as
7894 "Method" and "Method`1". Normally, a cache lookup is done on the
7895 "Method" form (ie. without the generic arity), but this one makes
7896 lookups on the full form work as well.
7898 2007-03-22 Raja R Harinath <rharinath@novell.com>
7900 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
7903 2007-03-20 Bill Holmes <billholmes54@gmail.com>
7905 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
7906 ordered_member_list, to TypeBuilder to store members to be defined
7907 in the order they were parsed in.
7908 - ordered_explicit_member_list contains all properties indexers
7909 and methods that are defined as explicit implementation of an
7910 interface or base class.
7911 - ordered_member_list contains all properties indexers and methods
7912 that are not defined as explicit implementation of an interface
7915 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
7916 functionality in these removed classes has been replaced with
7917 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
7918 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
7920 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
7921 to CheckForDuplications inside GetMethod and SetMethod Define Method
7922 to handle method property and indexer name conflicts.
7926 All code is contributed under the MIT/X11 license.
7928 2007-03-20 Martin Baulig <martin@ximian.com>
7930 * class.cs (TypeContainer.Interfaces): Removed; they're now
7931 included in `TypeContainer.Types'.
7933 2007-03-20 Martin Baulig <martin@ximian.com>
7935 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
7937 * class.cs (TypeContainer.CreateType): New public method. This is
7938 now called before DefineType() to create the TypeBuilders.
7939 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
7940 has already been created by CreateType().
7941 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
7942 don't resolve our base classes here; this has been moved into
7943 DefineBaseTypes(). We're now called from CreateType().
7944 (TypeContainer.DefineBaseTypes): New private method; resolve our
7945 base classes here. We're now called from DefineType().
7948 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
7949 our types first to create all the TypeBuilders. After that, call
7950 TypeContainer.DefineType() on all the types which'll resolve their
7951 base classes and setup the resolve order.
7953 2007-03-20 Martin Baulig <martin@ximian.com>
7955 * class.cs (TypeContainer.Enums): Removed; they're now included in
7956 `TypeContainer.Types'.
7958 2007-03-20 Martin Baulig <martin@ximian.com>
7961 (TypeContainer.DefineType): Don't call ResolveMembers() here.
7962 (TypeContainer.DoResolveMembers): Call DefineType() on our
7963 `compiler_generated' classes; moved here from DefineNestedTypes().
7966 (RootContext.ResolveTree): Call ResolveMembers() on all
7967 TypeContainer's in the `type_container_resolve_order'.
7969 2007-03-19 Marek Safar <marek.safar@gmail.com>
7971 * class.cs: Use corlib to handle InternalMethodImplAttribute.
7973 2007-03-17 Marek Safar <marek.safar@gmail.com>
7975 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
7976 implementation flags.
7978 2007-03-17 Marek Safar <marek.safar@gmail.com>
7980 * class.cs: More optimizations for type parameters.
7982 2007-03-15 Marek Safar <marek.safar@gmail.com>
7984 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
7986 * ecore.cs, parameter.cs: More common code for both corlibs.
7988 * typemanager.cs (IsGenericMethod): Simplified.
7990 2007-03-15 Raja R Harinath <rharinath@novell.com>
7992 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7994 * statement.cs, iterators.cs, lambda.cs: Update to changes.
7996 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
7997 unconditionally. Simplify explanation.
7998 (Try.Resolve, Using.Resolve): Likewise.
8000 2007-03-15 Martin Baulig <martin@ximian.com>
8004 * decl.cs (DeclSpace): If we're a partial class, use our
8005 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8007 2007-03-15 Raja R Harinath <rharinath@novell.com>
8009 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8011 (FlowBranching.UsageVector): Update to changes.
8012 (FlowBranching.MergeSiblings): Likewise.
8013 * statement.cs: Likewise.
8015 2007-03-15 Martin Baulig <martin@ximian.com>
8020 (MemberCache): Added a special .ctor for type parameters.
8023 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8026 2007-03-09 Martin Baulig <martin@ximian.com>
8028 * enum.cs (Enum): Make this a TypeContainer.
8029 (EnumMember): Derive from `Const'.
8032 (Const.DoResolveValue): New protected virtual method; move most of
8033 the functionality of ResolveValue() here so we can override it in
8035 (Const.CreateConstantReference): Make this virtual.
8037 * class.cs (Kind): Add `Kind.Enum'.
8038 (TypeContainer.Emit): Don't emit the enums here; they're already
8039 in the `RootContext.typecontainer_resolve_order'.
8041 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8042 here; they're already in the `typecontainer_resolve_order'.
8044 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8045 TypeManager.DropGenericTypeArguments().
8048 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8049 (TypeManager.IsEnumType): Likewise.
8050 (TypeManager.EnumToUnderlying): Likewise.
8051 (TypeManager.IsEqual): Add support for enums.
8053 2007-03-12 Raja R Harinath <rharinath@novell.com>
8055 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8056 DefaultParameterValueAttribute to be undefined, say if System.dll
8059 2007-03-11 Marek Safar <marek.safar@gmail.com>
8061 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8064 2007-03-10 Marek Safar <marek.safar@gmail.com>
8066 * class.cs, parameter.cs: Unified parameters verification.
8068 2007-03-08 Martin Baulig <martin@ximian.com>
8070 * cs-parser.jay (constructor_header): Pass the location to the
8071 newly created TopLevelBlock.
8073 2007-03-07 Martin Baulig <martin@ximian.com>
8075 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8077 2007-03-06 Miguel de Icaza <miguel@novell.com>
8079 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8080 with the changes from David, fixes the build.
8082 2007-03-05 David Mitchell <dmitchell@logos.com>
8084 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8085 and its base interfaces to a one-dimensional array type S[],
8086 provided there is an implicit or explicit reference conversion
8089 2007-03-03 Marek Safar <marek.safar@gmail.com>
8091 * cs-tokenizer.cs: Implemented basic linq grammar.
8093 * driver.cs: Set linq lang version on demand.
8095 2007-02-26 Marek Safar <marek.safar@gmail.com>
8097 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8099 2007-02-25 Marek Safar <marek.safar@gmail.com>
8101 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8104 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8106 Check property and event extern attributes.
8108 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8111 2007-02-24 Marek Safar <marek.safar@gmail.com>
8113 A fix for bug #80407
8114 * ecore.cs: Don't report ambiguity error when methods have same parent.
8116 2007-02-23 Marek Safar <marek.safar@gmail.com>
8118 A fix for bug #80878
8119 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8121 2007-02-22 Marek Safar <marek.safar@gmail.com>
8123 * attribute.cs: Enable ExtensionAttribute presence test.
8125 2007-02-22 Marek Safar <marek.safar@gmail.com>
8127 * class.cs: Warn about missing GetHashCode only when Equals is override.
8129 * decl.cs: Check accessibility of type arguments.
8131 * typemanager.cs: Correctly report nullable array.
8133 2007-02-20 Marek Safar <marek.safar@gmail.com>
8135 * class.cs, report.cs: Capture more details when things go wrong.
8137 2007-02-20 Marek Safar <marek.safar@gmail.com>
8139 A fix for bug #80650
8140 * cs-parser.jay: Anonymous container starts at constructor declaration
8141 and not at block beginning because it has to be usable in constructor
8144 * statement.cs: Use context location and not block one for error reporting.
8146 2007-02-18 Marek Safar <marek.safar@gmail.com>
8148 A fix for bug #78712
8149 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8152 2007-02-18 Marek Safar <marek.safar@gmail.com>
8154 A fix for bug #80493 by Atsushi Enomoto
8155 * cs-parser.jay: Ignore invalid attribute target.
8157 2007-02-18 Marek Safar <marek.safar@gmail.com>
8159 * cs-tokenizer.cs: Ignore '\0' as white space character.
8161 2007-02-17 Miguel de Icaza <miguel@novell.com>
8163 * cs-parser.jay: Add support for lambda expressions to the mcs
8166 * lambda.cs: Only clone when we are probing, not on the final call
8167 (Compatible is the final call).
8169 * statement.cs (CloneContext): Introduce class to provide block
8170 remapping during clone.
8172 All statements Clone themselves now.
8174 (Clone): special handling for blocks, when we clone a block, we
8175 register the block inside this routine, as children of the block
8176 might trigger a lookup.
8178 * expression.cs: Add support for CloneContext in all expressions.
8180 2007-02-17 Marek Safar <marek.safar@gmail.com>
8182 A fix for bug #80493
8183 * statement.cs: Report ambiguous warning when interfaces are not related.
8185 2007-02-15 Marek Safar <marek.safar@gmail.com>
8187 C# 3.0 extension methods.
8189 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8190 cannot be used directly.
8192 * class.cs (Class.Emit): Emit extension attribute if any class method
8193 is extension method.
8194 (Method.Define): Add basic extension method validation conditions.
8195 (Method.Emit): Emit extension attribute for method.
8197 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8198 extension method exists. Currently we follow same approach as Microsoft
8199 does, emit even if a method or a class are private but this can change
8202 * cs-parser.jay: Add handling of `this' keyword in method parameters
8205 * decl.cs (DeclSpace.IsStaticClass): New property.
8206 (MemberCache.FindExtensionMethods): Looks for extension methods with
8207 defined name and extension type.
8209 * doc.cs: Updated after OverloadResolve changes.
8211 * driver.cs: Add new soft reference to System.Core.dll.
8213 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8214 (ExtensionMethodGroupExpr): Represents group of extension methods.
8216 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8217 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8218 to MethodGroupExpr and made non-static for easier customization.
8219 (Invocation.DoResolve): Add extension method lookup when no standard
8221 (MemberAccess.DoResolve): Try extension methods if no member exists.
8223 * modifiers.cs: Add METHOD_EXTENSION modifier.
8225 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8226 as well as candidate extension type.
8227 (ComputeNamespaces): When assembly constains extension methods registers
8229 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8230 extension method lookup.
8231 (Namespace.LookupExtensionMethod): Looks for extension method in this
8233 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8234 find a method which matches name and extensionType.
8236 * parameter.cs (Parameter): Add This modifer.
8237 (HasExtensionMethodModifier): New property.
8238 (Resolve): Add extension parameter check.
8239 (ModFlags): turned to property to exclude this modifier as it is not real
8241 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8243 * support.cs (ParameterData): Add ExtensionMethodType.
8244 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8246 * typemanager.cs: Add type and ctor extension attribute type.
8248 2007-02-15 Miguel de Icaza <miguel@novell.com>
8250 * report.cs (DisableErrors, EnableErrors): used to prevent error
8251 output when we are "trying" to compile various methods with
8254 * ecore.cs (Expression): Add Clone method that calls the virtual
8255 CloneTo method. The current CloneTo method in Expression throws
8256 an exception so we can track down all the places where this must
8257 be implemented (not using abstract, because that would be a lot of
8258 up-front-work before we can start testing the implementation
8261 Important: we only need Clone capabilities for expressions created
8262 by the parser, as the expressions we will be cloning are
8263 expressions in the pre-resolved state. This vastly simplifies
8266 (SimpleName): Add CloneTo that does nothing.
8267 (EmptyCast): Add CloneTo.
8269 * expression.cs (Binary): Implement CloneTo.
8270 (Invocation.IsApplicable): Store the current ec in
8271 EmitContext.TempEc and restore it on return. This is used so we
8272 do not have to sprinkle hundres of methods with an extra
8273 EmitContext, we know that the only user is the lambda expression
8274 ImplicitConversionExists code.
8276 (Argument): Add Cloning capabilities.
8277 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8278 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8279 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8280 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8281 IndexerAccess): Add Clone capability.
8283 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8285 (Argument): Add cloning capability.
8287 * assign.cs (Assign): Implement CloneTo.
8289 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8291 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8292 version by calling Convert with the EmitContext (that we are
8293 currently storing in ec, this is not great, but will do for now,
8294 to avoid passing EmitContext parameters to hundreds of functions
8295 that do not need them now).
8297 (SetExpression): Remove, it is not needed.
8299 (ContextualReturn): Implement CloneTo.
8301 * statement.cs (Statement): Implement cloning infrastructure,
8302 similar to expressions.
8304 (Block): Partial implementation of Clone for statements.
8306 (Return): Implement clone.
8308 * constant.cs (Constant.CloneTo): New method, does nothing.
8310 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8311 solution, until we decide how to exactly do this.
8313 2007-02-14 Marek Safar <marek.safar@gmail.com>
8315 A fix for bug #80493
8316 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8317 a property is override we need to use second accessor.
8319 2007-02-13 Marek Safar <marek.safar@gmail.com>
8321 A fix for bug #80418
8322 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8325 2007-02-13 Marek Safar <marek.safar@gmail.com>
8327 Another fix for bug #80749
8328 * pending.cs: Abstract class has priority over interfaces.
8330 2007-02-13 Marek Safar <marek.safar@gmail.com>
8332 Another fix for bug #80749
8333 * pending.cs: Abstract class has priority over interfaces.
8335 2007-02-13 Marek Safar <marek.safar@gmail.com>
8337 Another fix for bug #80749
8338 * pending.cs: Abstract class has priority over interfaces.
8340 2007-02-13 Marek Safar <marek.safar@gmail.com>
8342 Another fix for bug #80749
8343 * pending.cs: Abstract class has priority over interfaces.
8345 2007-02-13 Marek Safar <marek.safar@gmail.com>
8347 * class.cs Better error message.
8349 * driver.cs: Add shorter versions of -optimize option.
8351 2007-02-13 Martin Baulig <martin@ximian.com>
8353 * class.cs (Constructor.Emit): Check the return value of
8354 ec.ResolveTopBlock() and return on error.
8356 2007-02-13 Raja R Harinath <rharinath@novell.com>
8358 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8359 message to fix error message regression.
8361 2007-02-12 Marek Safar <marek.safar@gmail.com>
8363 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8365 2007-02-12 Marek Safar <marek.safar@gmail.com>
8367 A fix for bug #80749
8368 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8369 its parent container.
8371 * class.cs (DefineFieldInitializers): Each initializer can has different
8374 * const.cs: Updated.
8376 2007-02-11 Miguel de Icaza <miguel@novell.com>
8378 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8379 now all the heavy lifting to check that embedded statements or
8380 expressions have the right form is done in the ContextualReturn.
8382 (ContextualReturn): New class.
8384 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8385 method that can be invoked to report 201, so we do not replicate
8388 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8390 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8391 treating tabs as spaces.
8393 2007-02-09 Marek Safar <marek.safar@gmail.com>
8395 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8396 * assign.cs: Use full implicit conversion for right side check.
8398 2007-02-09 Marek Safar <marek.safar@gmail.com>
8400 * statement.cs (Switch): Switch over boolean type is not standardized.
8402 2007-02-08 Marek Safar <marek.safar@gmail.com>
8404 A fix for bug #80755
8405 * decl.cs (FindBaseEvent): Don't use method cache for events.
8407 2007-02-07 Marek Safar <marek.safar@gmail.com>
8409 * cs-parser.jay: Better syntax error handling.
8411 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8412 instead of underlying type value.
8414 2007-02-06 Marek Safar <marek.safar@gmail.com>
8416 * driver.cs: Check define identifier before is registered.
8418 * namespace.cs: Use existing error message.
8420 * report.cs: New warning.
8422 2007-02-06 Marek Safar <marek.safar@gmail.com>
8424 A fix for bug #80742
8425 * expression.cs: Delegate Invoke method can be called directly.
8427 2007-02-06 Marek Safar <marek.safar@gmail.com>
8429 A fix for bug #80676
8430 * class.cs (IsEntryPoint): The Main method can have params modifier.
8432 2007-02-04 Miguel de Icaza <miguel@novell.com>
8434 * parameter.cs (Parameter, Parameters): Add Clone method.
8436 * anonymous.cs (Compatible): Turn method into virtual method, so
8437 LambdaExpression can implement a different behavior.
8439 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8440 out the basic checking here, so it can be used by
8443 * lambda.cs: Introduce "Compatible" function that will do the
8446 2007-02-02 Marek Safar <marek.safar@gmail.com>
8448 * attribute.cs: Unified one error message.
8450 * class.cs (Class): Use type attributes and not properties to test static
8452 (IsEntryPoint): Don's pass local variable.
8454 * convert.cs: Removed duplicate check.
8456 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8458 * driver.cs: Don't crash when soft reference does not exist.
8460 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8461 (UsingEntry): Removed redundant allocation.
8463 * parameter.cs: Add fast path for type parameters.
8465 * support.cs: Don't allocate attribute when it's not used.
8467 2007-01-30 Miguel de Icaza <miguel@novell.com>
8470 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8471 this into a virtual method, so we can override it in LambdaExpression.
8473 * driver.cs: Improve diagnostics in case of failure.
8475 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8476 write a function that is slightly more complex and that parses:
8478 type identifier [, type identifier]* )
8480 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8483 (canEmpty ? i >= 0 : i > 0)
8485 2007-01-30 Raja R Harinath <rharinath@novell.com>
8487 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8488 exception on possibly valid code.
8490 2007-01-29 Raja R Harinath <rharinath@novell.com>
8492 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8494 (parse_opt_type_arguments): Remove. It's almost the same as
8496 (parse_namespace_or_typename): Use parse_less_than.
8498 2007-01-28 Miguel de Icaza <miguel@novell.com>
8500 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8501 this bug took a few hours to find, because the state saved and
8502 restored by PushPosition and PopPosition was ignoring the state of
8503 parse_generic_less_than.
8505 I can also now remove the handling of OP_LT and OP_GT, this solves
8508 * cs-tokenizer.cs: store the location for the ARROW token, we use
8511 (PushPosition, PopPosition): save/restore also `current_token',
8512 restore `parse_generic_less_than' (was missing).
8514 (parse_opt_type_arguments): use parse_type, not
8515 parse_namespace_or_typename to parse types.
8517 * lambda.cs: Empty new file, will eventually have the lambda
8518 expression implementation.
8520 * lambda.test: used to test the internal tokenizer.
8522 * report.cs (FeatureIsNotISO1): Rename from
8523 FeatureIsNotStandardized, because it was about the language level
8524 (1 vs 2) it was not about standarization.
8526 (FeatureRequiresLINQ): New.
8528 * support.cs (SeekableStreamReader): Only require that the reader
8529 is a TextReader, not a StreamReader, so we can plug StringReader.
8531 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8532 given position in the input stream the following tokens can be
8533 parsed as a type followed by an identifier.
8535 (is_punct): after a '(' if parse_type_and_parameter returns true,
8536 then return a special token OPEN_PARENS_LAMBDA which is used to
8537 avoid reduce/reduce errors in the grammar for the
8538 lambda_expression rules.
8540 (parse_type): implement a type parser inside the
8541 tokenizer, the parser only returns true or false depending on
8542 whether the input at a given position can be parsed as a type.
8544 (peek_token): new method used during type parsing.
8546 2007-01-28 Raja R Harinath <rharinath@novell.com>
8549 * anonymous.cs (ScopeInfo.InflateParameters): New.
8550 (AnonymousContainer.Resolve): Use it to redirect types of
8551 delegate parameters.
8553 2007-01-27 Raja R Harinath <rharinath@novell.com>
8556 * expression.cs (Error_InvalidArguments): Don't use two different
8557 messages for CS1503. Use ExtraInformation and
8558 SymbolRelatedToPreviousError instead.
8561 * decl.cs (DeclSpace.initialize_type_params): Don't access
8562 'type_params' of a partial class directly.
8564 2007-01-26 Miguel de Icaza <miguel@novell.com>
8566 * constant.cs: Removed a handful of out-of-range checks that were
8569 2007-01-25 Marek Safar <marek.safar@gmail.com>
8571 * expression.cs (CheckUselessComparison): Add additional check for char
8574 * namespace.cs: Fixed typo.
8576 2007-01-23 Miguel de Icaza <miguel@novell.com>
8578 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8579 gone, instead we inline the test, preventing the needless casts to
8580 longs, ulongs and doubles for the parameters, avoiding calls to
8581 methods that overchecked stuff, and instead inlined things
8584 2007-01-20 Marek Safar <marek.safar@gmail.com>
8586 * cs-parser.jay: Better parameter error handling.
8588 2007-01-17 Marek Safar <marek.safar@gmail.com>
8590 A fix for bug #80368, #80522
8591 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8592 whether array initializer contains constants only.
8593 (ArrayCreation.Emit): Use better formula to decide when
8594 are array initializers for static initialization.
8595 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8596 have to emit even constants otherwise they are pre-initialized.
8598 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8599 Raja R Harinath <rharinath@novell.com>
8601 Fix emit order of 'get' vs. 'set'.
8602 * support.cs (Accessors): New.
8603 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8604 Note the order in which accessors are declared in the source.
8605 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8606 Refactored from Property.Define and Indexer.Define.
8607 (PropertyBase.DefineAccessors): New helper that calls the above in
8608 appropriate order as noted by the parser.
8609 (Property.Define, Indexer.Define): Update to changes.
8610 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8612 2007-01-17 Raja R Harinath <rharinath@novell.com>
8614 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8615 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8616 there's an implicit conversion from the current type to the target
8617 type before converting the underlying constant.
8619 2007-01-16 Marek Safar <marek.safar@gmail.com>
8621 * const.cs (ResolveValue): Updated after constant conversion was made more
8624 * constant.cs (GetAttributableValue): constant to object conversion is
8625 used for attributes only.
8626 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8627 constant conversions.
8628 (LongConstant.ConvertImplicitly): Ditto.
8630 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8631 (ImplicitConversionStandard): Handle constant conversion as extra step.
8632 It solves the issue when constant conversion was called indirectly like
8633 inside array initializer and constant folding was skipped.
8635 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8638 * statement.cs(ImplicitConversionStandard): Updated after constant
8639 conversion was made more generic.
8641 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8643 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8644 Constraints, solves the problem where the compiler incorrectly
8645 reported that a type parameter was not constrained to a class (Bug
8648 2007-01-14 Marek Habersack <grendello@gmail.com>
8650 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8652 2007-01-14 Marek Safar <marek.safar@gmail.com>
8654 A fix for bug #80368
8655 * assign.cs (FieldInitializer): New class implements field
8656 initializer statement.
8658 * attribute.cs: Update after FieldMember rename.
8660 * class.cs (PropertyBasedMember): New common class for property based
8662 (InterfaceMemberBase): New base class for all members which can be used as
8663 an interface members.
8664 (MethodCore): Moved really common code to InterfaceMemberBase.
8665 (Method.Define): Equal and GetHasCode detection is relevant for methods
8667 (MethodData.Define): Don't assume that public event implements an
8668 interface automatically.
8669 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8671 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8672 (FieldMember): Merged with FieldBase.
8673 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8674 event extern modifier can be used.
8675 (EventField.EventFieldAccessor): Moved event field specific code here.
8676 (Event.AllowedModifiers): Even event can be extern.
8677 (Event.FindOutBaseMethod): New override specific to events.
8678 (Indexer.parameters): Reintroduce parameters because base class holds
8679 only properties common data.
8680 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8681 need do extra parameters check.
8683 * const.cs: Update after FieldMember rename.
8685 * decl.cs (MemberCache.FindBaseEvent): New method.
8687 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8688 to reflect that indexer is now derived from PropertyBased.
8690 * ecore.cs (GetMemberType): Made public.
8691 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8694 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8696 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8697 (RegisterEvent): Removed.
8698 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8699 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8701 2007-01-11 Raja R Harinath <rharinath@novell.com>
8704 * statement.cs (CollectionForeach.TryType): Prefer generic
8705 GetEnumerator over non-generic variant. Fix code to follow comments.
8707 2007-01-09 Raja R Harinath <rharinath@novell.com>
8710 * support.cs (ReflectionParameter): Don't use an invalid index on
8711 the generic parameter data.
8713 2007-01-08 Miguel de Icaza <miguel@novell.com>
8715 * driver.cs: Just add a tiny bit of infrastructure.
8717 2007-01-02 Marek Safar <marek.safar@gmail.com>
8719 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8720 where field type is struct from current assembly.
8722 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8725 2007-01-02 Marek Safar <marek.safar@gmail.com>
8727 A fix for bug #80381
8728 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8731 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8733 (Namespace.LookupType): Always use core types from corlib when speficied.
8735 * report.cs: A new warning.
8737 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8738 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8739 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8741 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8742 (InitCoreTypes): Set expression type of object_type and value_type
8743 immediately after lookup.
8745 2007-01-01 Miguel de Icaza <miguel@novell.com>
8747 * cs-tokenizer.cs: Accept Pc class characters (Connector
8748 Punctuation) as valid identifiers. Fixes #78259
8750 * expression.cs (Invocation.DoResolve): Moved the check for the
8751 use of `this' for doing method calls to the Invocation resolution
8752 step, after overload resolution has taken place instead of doing
8753 the check at the low-level `This.DoResolve' level.
8755 The `This.DoResolve'(appens before overload resolution, so it has
8756 no way of knowing if the method that will be called will be
8757 instace or static, triggering an erroneous report for cs0188 (Bug
8760 We now do the check for instance method invocations after we know
8761 what method will be called.
8763 (This.CheckThisUsage): Move the actual use of this structure
8764 checking into its own method and expose it.
8766 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8769 Exceptions: Null.ConvertImplicitly,
8770 Constant.ImplicitConversionRequired as there are too many call
8771 sites for passing the ec.
8773 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8774 EmitContext, if the value is null, then we do not try to provide
8775 the extra information from the error (If a userdefined conversion
8776 exists, as UserDefinedConversion requires a non null-EmitContext).
8780 2006-12-30 Raja R Harinath <rharinath@novell.com>
8782 * flowanalysis.cs (MyBitVector): Document some invariants.
8783 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8784 introduced below, and add a couple of others,
8786 2006-12-30 Marek Safar <marek.safar@gmail.com>
8788 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8789 GetPropertyFromAccessor and GetEventFromAccessor.
8791 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8792 overrides non-obsolete one.
8793 (Indexer.Define): Error message has been moved to the parser.
8795 * cs-parser.jay: Better syntax errors handling.
8797 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8798 when an invocation has no arguments.
8800 * ecore.cs: Removed not used caching.
8802 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8805 * report.cs: Add a new warning.
8807 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8809 * typemanager.cs (enumeration_type): Removed.
8810 (CSharpSignature): Reuses IsSpecialMethod.
8811 (IsEqual): Hack for MS BCL.
8812 (GetPropertyFromAccessor): New method.
8813 (GetEventFromAccessor): New method.
8814 (IsSpecialMethod): Fixed to handle more cases.
8816 2006-12-30 Marek Safar <marek.safar@gmail.com>
8818 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8819 Made white spaces array static.
8821 * ecore.cs (RemoveGenericArity): Optimized.
8823 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8825 (MyBitVector.initialize_vector): Simplified.
8827 2006-12-22 Miguel de Icaza <miguel@novell.com>
8829 * ecore.cs: Am not entirely happy with this hack, but it seems to
8830 address the issue in 80257 (a small test case for
8833 I set the MethodGroupExpr.Type to an internal compiler type
8834 (itself in this case) to force the resolution to take place. Why
8835 it does not take place with a null is beyond me.
8837 2006-12-20 Marek Safar <marek.safar@gmail.com>
8839 A fix for bug #80288
8840 * expression.cs (ResolveOperator): Consider user defined conversion for
8841 logical and operator too.
8842 (EmitBranchable): Optimization for logical and when full constant folding
8843 could not be applied but one operand is constant.
8845 2006-12-19 Marek Safar <marek.safar@gmail.com>
8847 * class.cs (GetClassBases): Write 5 times every day, will never use
8848 FullName for error reporting.
8850 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8852 2006-12-19 Martin Baulig <martin@ximian.com>
8854 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8855 the symbol file info here.
8857 2006-12-18 Marek Safar <marek.safar@gmail.com>
8859 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8860 of `elseif' is taking then following sections are not taking.
8861 Fixes an issue reported on mono mailing list.
8863 2006-12-18 Marek Safar <marek.safar@gmail.com>
8865 A fix for bug #80300
8866 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8867 a caller is not taking.
8869 2006-12-18 Raja R Harinath <rharinath@novell.com>
8871 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
8872 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
8873 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
8874 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
8875 * class.cs: Update to changes.
8877 2006-12-17 Marek Safar <marek.safar@gmail.com>
8879 A fix for bug #79934
8880 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
8883 * class.cs (ResolveMembers): Register an iterator in current container and
8886 2006-12-16 Raja R Harinath <rharinath@novell.com>
8889 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
8890 satisfy a params annotated parameter.
8892 2006-12-16 Marek Safar <marek.safar@gmail.com>
8894 A fix for bug #77014
8895 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
8896 paramters correctly and not rely on hacks in Parameters class.
8897 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
8899 (Invocation.VerifyArgumentsCompat): Ditto.
8900 (Invocation.EmitArguments): Changed to correctly emit params arguments at
8903 * parameter.cs (HasParams): Don't assume that params is the last one.
8905 * support.cs (ReflectionParameters.ctor): Look for params attribute
8907 (ReflectionParameters.ParameterType): Removed hack when we returned last
8908 parameter for out of range parameters.
8909 (ParameterName, ParameterModifier): Ditto.
8911 2006-12-14 Marek Safar <marek.safar@gmail.com>
8913 A fix for bug #79987
8914 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
8915 when assembly is not CLS compliant but type is. I have no idea why is this
8918 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
8920 2006-12-13 Miguel de Icaza <miguel@novell.com>
8922 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
8923 in struct constructors, they are basically no-ops.
8925 2006-12-12 Marek Safar <marek.safar@gmail.com>
8927 * cs-tokenizer.cs (Position): Save preprocessor status too.
8929 2006-12-12 Marek Safar <marek.safar@gmail.com>
8931 A fix for bug #77794
8932 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
8934 2006-12-12 Marek Safar <marek.safar@gmail.com>
8936 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
8938 (pp_expr): Report error for an invalid expression.
8939 (handle_preprocessing_directive): Simplified; add more error checking.
8941 2006-12-11 Marek Safar <marek.safar@gmail.com>
8943 A fix for bug #74939
8944 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
8945 directives handling.
8947 2006-12-10 Marek Safar <marek.safar@gmail.com>
8949 A fix for bugs #80093, and #75984
8950 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
8951 logic, it seems to me as it worked before "by coincidence".
8952 (xtoken): Simplified to use reworked handle_preprocessing_directive.
8953 (cleanup): Enabled endif check.
8955 2006-12-09 Marek Safar <marek.safar@gmail.com>
8957 A fix for bug #80162
8958 * statement.cs (CollectionForeach.TryType): Generics and non-generics
8959 enumerators are never ambiguous.
8961 2006-12-08 Raja R Harinath <rharinath@novell.com>
8964 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
8966 2006-12-06 Marek Safar <marek.safar@gmail.com>
8968 A fix for bug #80144
8969 * class.cs (EventProperty.Define): Explicit implementation means
8970 that an even is used.
8972 2006-12-06 Marek Safar <marek.safar@gmail.com>
8974 Fixes the operators implementation (part II)
8976 * cfold.cs (DoConstantNumericPromotions): Renamed to
8977 DoBinaryNumericPromotions and simplified.
8978 (BinaryFold): Couple of conversion fixes; simplified.
8980 * constant.cs, ecore.cs, literal.cs
8981 (ToType): Renamed to ConvertImplicitly.
8982 (Reduce): Renamed to ConvertExplicitly.
8984 * class.cs, convert.cs: Updated.
8986 * expression.cs: TryReduce doesn't throw an exception.
8988 2006-12-01 Marek Safar <marek.safar@gmail.com>
8990 A fix for bug #80108
8991 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
8994 2006-11-30 Marek Safar <marek.safar@gmail.com>
8996 Fixes unary operators implementation (part I)
8999 * cfold.cs (Error_CompileTimeOverflow): Made internal
9001 * const.cs (IConstant): Changed to use reference to constant and
9002 not constant itself.
9003 Updated IConstant implementations.
9005 * constant.cs (CreateConstant): New factory method.
9006 Updated IConstant implementation.
9008 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9010 * ecore.cs: Updated to use CreateConstantReference.
9012 * enum.cs: Reflects IConstant changes.
9014 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9016 * literal.cs (NullConstant): Change to be independently usable.
9018 2006-11-29 Martin Baulig <martin@ximian.com>
9020 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9021 we need to emit the scope initializer before calling the base .ctor.
9023 * anonymous.cs: Merged back from the new anonymous methods branch.
9024 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9026 * expression.cs (ParameterReference.DoResolveBase): Create a
9027 "normal" ScopeInfo when capturing parameters rather than using the
9028 root scope; this makes things work with anonymous methods having
9032 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9034 2006-11-22 Marek Safar <marek.safar@gmail.com>
9036 A fix for bug #79987
9037 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9038 check to a base class.
9039 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9040 only when assembly has missing attribute.
9041 * report.cs: Update.
9043 2006-11-21 Marek Safar <marek.safar@gmail.com>
9045 * cs-tokenizer.cs: Merged with gmcs version.
9047 2006-11-20 Marek Safar <marek.safar@gmail.com>
9050 * cs-parser.jay: Better error message when partial keyword is misplaced.
9052 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9054 A fix for bug #79810
9055 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9056 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9057 a RuntimeWrappedException by default.
9059 2006-11-18 Marek Safar <marek.safar@gmail.com>
9061 A fix for bug #79843
9062 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9064 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9066 2006-11-18 Marek Safar <marek.safar@gmail.com>
9068 * driver.cs, namespace.cs: Uses faster IndexOf version.
9070 2006-11-17 Marek Safar <marek.safar@gmail.com>
9072 A fix for bug #79941
9073 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9075 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9076 even if internal name is different.
9077 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9078 (UserDefinedConversion): Simplified as the operators cannot be internal.
9079 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9081 (MethodLookup): Replaced EmitContext with parentType.
9082 * expression.cs: Updated.
9084 2006-11-09 Raja R Harinath <rharinath@novell.com>
9086 * driver.cs (BadAssembly): Handle all the ugliness of
9087 DefineDynamicAssembly.
9089 2006-11-08 Raja R Harinath <rharinath@novell.com>
9091 Address parts of #58244 -- most of what's left is in the runtime
9092 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9093 CS1509 error checks, and handle them for all assembly loads, not
9094 just the first invocation.
9095 (LoadModule): Likewise. Move handling of 'adder_method' ...
9096 * codegen.cs (AssemblyClass.AddModule): ... here.
9098 2006-11-02 Marek Safar <marek.safar@gmail.com>
9100 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9101 IEnumerable<T> is ambiguous.
9103 2006-10-31 Marek Safar <marek.safar@gmail.com>
9105 A fix for bug #67689
9106 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9107 GetEnumerator is ambiguous.
9109 * report.cs: Add new warning.
9111 2006-10-29 Marek Safar <marek.safar@gmail.com>
9113 A fix for bug #78602
9114 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9115 to protected member can be nested type.
9117 2006-10-28 Marek Safar <marek.safar@gmail.com>
9119 A fix for bug #78965
9120 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9121 to protected member must derive from current type.
9123 2006-10-27 Marek Safar <marek.safar@gmail.com>
9125 assign.cs: Reuses error method.
9127 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9128 instead of type for constants.
9129 (Expression.Error_ValueAssignment): Common error method.
9131 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9134 2006-10-27 Marek Safar <marek.safar@gmail.com>
9136 A fix for bug #79081
9137 * expression.cs (MemberAccess.DoResolve): Check nested type
9140 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9142 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9144 2006-10-26 Marek Safar <marek.safar@gmail.com>
9146 A fix for bug #76591
9147 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9149 2006-10-26 Marek Safar <marek.safar@gmail.com>
9151 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9152 type forwarder of the same type multiple times.
9154 2006-10-26 Raja R Harinath <rharinath@novell.com>
9157 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9158 instance as an rvalue, even when we later resolve as an lvalue.
9160 2006-10-25 Martin Baulig <martin@ximian.com>
9162 * anonymous.cs: Fix #79673.
9164 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9166 A fix for bug #79666
9167 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9168 ignored when is optimized (= default value) as its value is already set.
9170 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9172 A fix for bug #79724
9173 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9174 TypeContainer for type lookup.
9176 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9178 A fix for bug #79231
9179 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9180 * expression.cs (OverloadResolve): Always convert type name for
9182 (ResolveNamespaceOrType): Don't confuse a nested type with any
9185 2006-10-18 Martin Baulig <martin@ximian.com>
9187 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9189 2006-10-17 Miguel de Icaza <miguel@novell.com>
9191 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9192 an int32, but requesting an int64 from the conversion
9194 2006-10-12 Martin Baulig <martin@ximian.com>
9197 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9199 2006-10-12 Martin Baulig <martin@ximian.com>
9202 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9204 2006-10-11 Miguel de Icaza <miguel@novell.com>
9206 * convert.cs: Remove broken code: I was doing the "Existance"
9207 tests for Implicit conversions.
9209 2006-10-10 Miguel de Icaza <miguel@novell.com>
9211 * convert.cs: Added one missing case in
9212 ImplicitStandardConversionExists uint64 to intptr.
9216 * typemanager.cs (uintptr_type): another core known type.
9218 * ecore.cs (OperatorCast): routine used to do cast operations that
9219 depend on op_Explicit. We could change some of the Decimal
9220 conversions to use this.
9222 This one has a probe mechanism that checks both types for an op_
9223 which it coudl be used to eliminate two classes: CastToDecimal
9224 and CastFromDecimal.
9226 * convert.cs: Implement the conversions documented in #59800
9228 2006-10-10 Martin Baulig <martin@ximian.com>
9230 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9231 before RootScope.ResolveMembers().
9233 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9234 `CurrentType' if appropriate.
9236 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9238 A fix for bug #78568
9239 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9240 when contains binary operators.
9241 * cs-parser.jay: Updated.
9243 2006-10-09 Martin Baulig <martin@ximian.com>
9246 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9247 moved that into Define() and also do the other type parameter
9248 checks there. Fixes #79094. Added gtest-292.cs.
9251 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9252 since that doesn't include type parameters; don't use `Ldelema'
9253 for type parameters. Fixes #78980. Added gtest-293.cs.
9255 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9258 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9259 conversion is allowed.
9261 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9263 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9264 error reporting when no error occurs.
9266 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9268 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9271 2006-10-06 Raja R Harinath <rharinath@novell.com>
9274 * class.cs (DefineTypeBuilder): Check circular dependencies before
9275 setting the parent of the TypeBuilder.
9276 (CheckRecursiveDefinition): Don't use 'BaseType', since
9277 it may not be valid until after DefineTypeBuilder. Use
9278 'base_type' instead.
9280 2006-10-04 Martin Baulig <martin@ximian.com>
9282 Merged the Anonymous Methods patch.
9284 * anonymous.cs, iterators.cs: The new anonymous methods code.
9286 * statement.cs (Variable): New public abstract class.
9287 (LocalInfo.Variable): New public property.
9288 (LocalInfo.ResolveVariable): New public method.
9289 (Block.Flags): Add `IsIterator'.
9290 (Block.AddVariable): Improved the CS0136 check.
9291 (Block.AnonymousChildren): New public property.
9292 (Block.AddAnonymousChild): New public method.
9293 (ToplevelBlock): Update to use the new anonymous method framework.
9294 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9295 `ToplevelBlock'; this is required to correctly implement the
9297 (Fixed, Using): Use `TemporaryVariable' instead of directly
9298 creating the `LocalBuilder'.
9300 * parameter.cs (Parameter.ResolveVariable): New public method.
9301 (Parameters.ResolveVariable): Likewise.
9303 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9305 * class.cs (TypeContainer): Replaced the `iterators' list and
9306 corresponding methods with a list of `CompilerGeneratedClass'es.
9307 (TypeContainer.ResolveMembers): New public method.
9308 (Method): `IIteratorContainer' has been replaced by
9311 * expression.cs (VariableReference): New public abstract base
9312 class for `LocalVariableReference', `ParameterReference' and
9315 * codegen.cs (EmitContext): Removed `capture_context',
9316 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9317 (EmitContext.EmitThis): Removed.
9319 * cs-parser.jay: Replace `iterator_container' with
9322 2006-10-04 Martin Baulig <martin@ximian.com>
9324 * generic.cs (GenericMethod): Don't make this abstract.
9325 (Constraints.Clone): Added dummy implementation.
9327 2006-10-04 Raja R Harinath <harinath@gmail.com>
9330 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9331 'declspaces'. Avoid allocating arrays willy-nilly.
9334 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9335 cases out of the switch.
9337 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9339 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9340 message when non-generic type is used with the type arguments.
9341 * expression.cs: Updated.
9343 2006-09-28 Raja R Harinath <rharinath@novell.com>
9346 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9347 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9348 Change semantics slightly. Don't insist on having only one
9349 temporary EmptyExpression -- just throttle the creation of new ones.
9352 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9353 non-interfaces too. If no methods are found, don't try to create
9356 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9358 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9361 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9362 us produce better error message.
9364 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9366 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9367 of the `|' operator.
9369 * report.cs: A new warning added.
9371 2006-09-27 Martin Baulig <martin@ximian.com>
9373 * generic.cs (GenericMethod): Don't make this abstract.
9375 2006-09-27 Martin Baulig <martin@ximian.com>
9378 (InternalErrorException): Added overloaded ctor taking a params array.
9380 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9382 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9383 Fixed the cases when same error was reported twice.
9385 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9386 now report symbol information.
9388 2006-09-25 Martin Baulig <martin@ximian.com>
9390 * class.cs: Completely unified with the gmcs version.
9392 2006-09-25 Martin Baulig <martin@ximian.com>
9394 * typemanager.cs (TypeManager.IsNullableType): New public function.
9395 (TypeManager.IsNullableTypeOf): Likewise.
9396 (TypeManager.IsNullableValueType): Likewise.
9398 * class.cs (MethodCore): Added the `GenericMethod' argument from
9399 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9401 2006-09-24 Raja R Harinath <harinath@gmail.com>
9403 * convert.cs: Unify with gmcs version.
9405 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9407 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9408 verify them as well.
9410 * report.cs: New warning.
9412 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9414 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9415 for anonymous block with out argument.
9417 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9419 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9420 not used private events only.
9422 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9424 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9426 * const.cs (Const.Define): Check for constant type.
9427 (Const.IsConstantTypeValid): Looks for valid constant types.
9429 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9431 * ecore.cs (EmptyConstantCast): New common class for all constant based
9434 * expression.cs (Is.DoResolve): Handle null constant especially.
9435 (New.DoResolve): Check for new void().
9436 (MemberAccess.DoResolve): Cope with all kind of nulls.
9438 * literal.cs (NullConstant): Uses EmptyConstantCast.
9439 (NullDefault): Based on EmptyConstantCast.
9440 (NullLiteral): Uses EmptyConstantCast.
9442 * statement.cs (Block.ResolveMeta): Check for constant type.
9444 2006-09-22 Martin Baulig <martin@ximian.com>
9446 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9448 2006-09-22 Raja R Harinath <rharinath@novell.com>
9450 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9454 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9455 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9458 2006-09-22 Martin Baulig <martin@ximian.com>
9460 * ecore.cs: Merged with the gmcs version.
9462 * generic.cs (ConstructedType): New dummy class.
9463 (TypeArguments): Don't make this abstract.
9466 (TypeManager.IsGenericTypeDefinition): New method.
9467 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9469 2006-09-22 Raja R Harinath <rharinath@novell.com>
9471 * expression.cs (ComposedCast): Check for arrays of TypedReference
9472 before creating the type, not after.
9474 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9476 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9477 after ToType change.
9479 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9480 when constant must be implicitly convertible.
9482 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9484 * ecore.cs (NullCast): Derives from NullConstant.
9486 * expression.cs (Is.DoResolve): Removed useless variables.
9487 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9488 (New.Constantify): Add enum support.
9489 (MemberAccess.DoResolve): Add warning when accessing null constant or
9492 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9495 * literal.cs (NullConstant): New abstract class with common
9496 functionality for all null specializations.
9497 (NullDefault): Represents default(X) when result can be
9499 (NullLiteral): Updated.
9501 * report.cs: Add new warning.
9503 2006-09-21 Martin Baulig <martin@ximian.com>
9505 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9507 2006-09-21 Martin Baulig <martin@ximian.com>
9509 * generic.cs (GenericConstraints): New dummy class.
9510 (Constraints): Likewise.
9511 (TypeParameter): Likewise.
9512 (TypeParameterName): Likewise.
9513 (GenericMethod): Likewise.
9515 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9517 * decl.cs: Merged with the gmcs version.
9519 2006-09-21 Raja R Harinath <rharinath@novell.com>
9521 * generic.cs (TypeParameter): Implement IMemberContainer.
9522 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9524 * rootcontext.cs: Unify with gmcs version.
9526 * report.cs: Unify with gmcs version.
9527 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9528 from gmcs/generics.cs.
9529 * generics.cs (TypeParameter): New dummy class.
9531 * support.cs: Unify with gmcs version.
9533 2006-09-20 Raja R Harinath <rharinath@novell.com>
9535 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9536 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9538 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9539 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9540 * mcs.exe.sources: Add generic.cs.
9542 * codegen.cs: Unify with gmcs version.
9544 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9545 (EmitContext): Add GenericDeclContainer implementation.
9546 * decl.cs (MemberCore, DeclSpace): Likewise.
9547 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9549 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9550 MCS TypeManager has a corresponding dummy method.
9552 2006-09-19 Martin Baulig <martin@ximian.com>
9554 * expression.cs: Completely merged with the gmcs version.
9556 2006-09-19 Martin Baulig <martin@ximian.com>
9558 * expression.cs (Invocation): Merged with the gmcs version.
9559 (ArrayAccess.GetStoreOpcode): Likewise.
9561 2006-09-19 Martin Baulig <martin@ximian.com>
9564 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9565 (TypeManager.IsGenericMethodDefinition): Likewise.
9567 2006-09-19 Martin Baulig <martin@ximian.com>
9570 (TypeManager.IsEqual): Moved the gmcs implementation here.
9571 (TypeManager.DropGenericTypeArguments): Likewise.
9572 (TypeManager.DropGenericMethodArguments): Likewise.
9573 (TypeManager.GetTypeArguments): Moved here from gmcs.
9574 (TypeManager.HasGenericArguments): Likewise.
9576 2006-09-19 Martin Baulig <martin@ximian.com>
9578 * expression.cs (Binary): Merged with the gmcs version.
9580 2006-09-19 Martin Baulig <martin@ximian.com>
9582 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9584 2006-09-19 Martin Baulig <martin@ximian.com>
9586 * typemanager.cs: Merged with the gmcs version.
9588 2006-09-16 Raja R Harinath <rharinath@novell.com>
9590 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9591 * driver.cs: Likewise.
9593 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9596 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9597 only if parent type is class.
9598 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9601 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9604 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9606 * typemanager.cs(CSharpName): Converts NullType to null.
9608 2006-09-15 Martin Baulig <martin@ximian.com>
9611 (TypeManager.GetMethodName): Added mcs implementation.
9612 (TypeManager.IsEqual): Likewise.
9615 (SimpleName.RemoveGenericArity): Added dummy implementation.
9617 * pending.cs: Merged with the gmcs version.
9619 2006-09-15 Martin Baulig <martin@ximian.com>
9621 * statement.cs: Merge with the gmcs version.
9623 2006-09-15 Martin Baulig <martin@ximian.com>
9625 * statement.cs (Switch): Merge with the gmcs implementation
9626 (without nullables), which is newer.
9628 2006-09-15 Martin Baulig <martin@ximian.com>
9630 * statement.cs (Block.Variables): Make this public.
9631 (ToplevelBlock.Parameters): Make this a property.
9632 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9634 2006-09-15 Martin Baulig <martin@ximian.com>
9636 * namespace.cs: Merge with the gmcs version.
9638 2006-09-15 Martin Baulig <martin@ximian.com>
9640 * decl.cs (MemberName): Minor code cleanups.
9642 2006-09-15 Martin Baulig <martin@ximian.com>
9644 * parameter.cs: Merge with the gmcs version.
9646 2006-09-15 Martin Baulig <martin@ximian.com>
9648 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9649 and an error in mcs.
9651 2006-09-15 Martin Baulig <martin@ximian.com>
9653 * flowanalysis.cs: Merged from GMCS; added the generics code into
9654 a `GMCS_SOURCE' conditional so we can share this file.
9656 2006-09-08 Martin Baulig <martin@ximian.com>
9658 * typemanager.cs (TypeManager.interlocked_type): New public field.
9659 (TypeManager.int_interlocked_compare-exchange): New public field.
9660 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9661 enumerator types here and call InitGenericCoreTypes().
9662 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9663 after calling InitEnumUnderlyingTypes().
9666 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9667 `classes_second_stage'.
9669 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9671 * assign.cs, ecore.cs, expression.cs: Share error message text.
9672 * class.cs (FieldMember.Define): Check for varible of static type.
9673 * driver.cs (LoadAssembly): Uses error output for errors.
9674 * statement.cs: Updated.
9676 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9678 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9681 2006-09-07 Martin Baulig <martin@ximian.com>
9684 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9686 2006-08-29 Miguel de Icaza <miguel@novell.com>
9688 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9690 2006-08-17 Miguel de Icaza <miguel@novell.com>
9692 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9693 #52019 and #79064, the use of the \uXXXX sequence in source code
9694 to represent unicode characters.
9696 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9698 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9700 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9702 2006-08-13 Miguel de Icaza <miguel@novell.com>
9704 * assign.cs: Catch attempts to assign to a method groups in += and
9707 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9710 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9712 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9714 * class.cs (Method.Define): Issue a warning when generic method looks like
9716 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9719 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9721 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9723 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9724 search all base interfaces as a member can be ambiguous.
9725 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9726 Constructor member type filter.
9727 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9728 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9729 reporting for returned memberinfos.
9730 * report.cs: Updated.
9731 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9732 version to work on all runtimes.
9733 (TypeManager.RealMemberLookup): Removed members filtering.
9735 2006-08-08 Raja R Harinath <rharinath@novell.com>
9737 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9738 (PropertyExpr.EmitAssign): Likewise.
9739 * expression.cs (Indirection.EmitAssign): Likewise.
9740 (LocalVariableReference.EmitAssign): Likewise.
9741 (ParameterReference.EmitAssign): Likewise.
9742 (Invocation.EmitArguments): Likewise.
9743 (ArrayAccess.EmitAssign): Likewise.
9744 (IndexerAccess.EmitAssign): Likewise.
9745 (This.EmitAssign): Likewise.
9746 (ConditionalLogicalOperator.Emit): Likewise.
9749 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9750 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9751 leave it in after returning it.
9752 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9754 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9756 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9759 2006-08-03 Raja R Harinath <rharinath@novell.com>
9761 Fix cs0146-3.cs and cs0146-4.cs.
9762 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9763 enclosing types don't depend on the current type.
9765 2006-08-02 Raja R Harinath <rharinath@novell.com>
9768 * class.cs (TypeContainer.DoDefineMembers): Use
9769 FindBaseMemberWithSameName on Parent, since we're interested in
9770 whether we hide inherited members or not.
9771 (FindBaseMemberWithSameName): Make slightly more robust.
9773 Fix the non-generic testcase from #77396
9774 * decl.cs (DeclSpace.DeclContainer): Remove override.
9776 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9777 declspaces for doppelgangers too.
9778 (UsingEntry): Implement IResolveContext.
9779 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9780 'this' as the resolve context.
9781 (LocalAliasEntry): Likewise.
9783 Implement parts of #77403
9784 * roottypes.cs (RootDeclSpace): New. Used to represent the
9785 toplevel declaration space. Each namespace declaration introduces
9786 a "partial" root declaretion space.
9787 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9788 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9789 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9790 from 'current_namespace.SlaveDeclSpace'.
9791 (namespace_declaration): Likewise.
9792 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9793 check. It can't happen now.
9794 * decl.cs (DeclSpace.LookupType): Likewise.
9795 * driver.cs (MainDriver): Sanity check.
9797 2006-08-01 Raja R Harinath <rharinath@novell.com>
9799 * decl.cs (DeclSpace.FindNestedType): Remove.
9800 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9801 LookupTypeContainer to get the container of the nested type.
9802 * class.cs (TypeContainer.FindNestedType): Make non-override.
9804 2006-07-31 Raja R Harinath <rharinath@novell.com>
9806 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9807 * class.cs (TypeContainer.PartialContainer): ... here.
9808 (TypeContainer.AddBasesForPart): New helper.
9809 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9811 * cs-parser.jay (current_class): Convert to DeclSpace.
9812 (struct_declaration, interface_declaration, class_declaration):
9813 Use AddBasesForPart instead of .Bases directly.
9814 * const.cs, iterators.cs: Update to changes.
9816 2006-07-28 Raja R Harinath <rharinath@novell.com>
9818 * class.cs (TypeContainer.AddMemberType): Rename from
9820 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9821 (AddTypeContainer): New. Combine AddClassOrStruct and
9823 (AddPartial): Update. Add 'is_partial' argument.
9824 * roottypes.cs: Update to changes.
9825 * cs-parser.jay (push_current_class): New helper for handling
9826 current_container and current_class.
9827 (struct_declaration, interface_declaration, class_declaration):
9830 2006-07-26 Raja R Harinath <rharinath@novell.com>
9832 * roottypes.cs: Rename from tree.cs.
9834 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9835 * tree.cs (Tree, ITreeDump): Remove types.
9836 * rootcontext.cs (tree, Tree): Remove fields.
9837 (root, ToplevelTypes): New.
9838 * *.cs: Update to rename.
9840 * tree.cs (Tree.RecordDecl): Remove.
9841 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9843 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9845 2006-07-23 Raja R Harinath <harinath@gmail.com>
9847 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9848 DoFlowAnalysis and OmitStructFlowAnalysis here.
9849 (ec.With): Rename from WithUnsafe and generalize.
9850 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9851 (ec.WithFlowAnalyis): New.
9852 * ecore.cs, expression.cs, statement.cs: Update.
9854 2006-07-22 Raja R Harinath <harinath@gmail.com>
9856 * statement.cs (Block.ResolveMeta): Simplify slightly.
9858 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9859 multiple boolean fields. Convert InUnsafe, constant_check_state,
9860 check_state to flags.
9861 (CheckState, ConstantCheckState): Update.
9862 (InUnsafe): New read-only property.
9863 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9865 (WithUnsafe): New helper similar to WithCheckState.
9866 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9867 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9869 2006-07-21 Raja R Harinath <rharinath@novell.com>
9871 Make comparisons use the same IL irrespective of whether they're
9872 in a 'checked' or 'unchecked' context: one of the issues in #78899
9873 * codegen.cs (EmitContext.CheckState): Make read-only property.
9874 (EmitContext.ConstantCheckState): Likewise.
9875 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
9876 helper that implement a save/restore stack for CheckState
9877 values. This is the only way to change check-state.
9878 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
9879 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
9880 (CheckedExpr.EmitBranchable): New forwarding method.
9881 (UnCheckedExpr): Likewise.
9882 * statement.cs (Block.ResolveMeta): Use WithCheckState.
9883 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
9884 (Checked.Resolve, checked.DoEmit): Likewise.
9886 2006-07-20 Miguel de Icaza <miguel@novell.com>
9888 * anonymous.cs: Cache the resolved anonymous delegate, and return
9889 this so that the ResolveTopBlock is only triggered once, not
9892 Currently we trigger ResolvetopBlock twice due to a first pass of
9893 argument check compatibility, and a second pass that does the
9896 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9898 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
9900 * rootcontext.cs (Reset): Add helper_classes.
9902 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9905 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
9908 2006-07-13 Miguel de Icaza <miguel@novell.com>
9910 * statement.cs (Lock): Handle expressions of type
9911 TypeManager.null_type specially. Fixes #78770
9913 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9915 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
9918 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9920 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
9921 for accessors as well.
9922 * ecore.cs (EventExpr): Add AccessorTable.
9924 2006-07-01 Marek Safar <marek.safar@seznam.cz>
9927 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
9928 for CS0122 where appropriate.
9929 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
9931 (Filter): Assembly can be null in the case of top level attributes.
9933 2006-06-25 Marek Safar <marek.safar@seznam.cz>
9937 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
9938 is done at global level.
9940 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9942 A fix for #77002, Implemented TypeForwarder support.
9944 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
9945 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
9946 * typemanager.cs (): Add type_forwarder_attr_type.
9948 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9950 * report.cs: Add CS0469 warning.
9952 2006-06-21 Martin Baulig <martin@ximian.com>
9954 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
9955 the `try'-block, so we also report CS0016 etc. there.
9957 2006-06-21 Martin Baulig <martin@ximian.com>
9960 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
9962 2006-06-21 Martin Baulig <martin@ximian.com>
9964 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
9965 also report CS1686 for parameters.
9967 2006-06-21 Martin Baulig <martin@ximian.com>
9969 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
9970 instead of an error if the value is not implicitly convertible to
9971 the switch types; fixes #77964.
9973 2006-06-21 Raja R Harinath <rharinath@novell.com>
9976 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
9977 FieldBuilder is null.
9980 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
9981 'left' and 'right' before error-checking.
9983 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
9985 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
9987 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
9988 (FieldExpr.DoResolve): likewise.
9989 (PropertyExpr.InstanceResolve): likewise.
9990 (EventExpr.InstanceResolve): likewise.
9992 2006-06-04 Marek Safar <marek.safar@seznam.cz>
9994 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
9995 attribute applicable tests for attribute argument.
9997 2006-06-02 Raja R Harinath <rharinath@novell.com>
10000 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10001 (Binary.OverloadResolve_PredefinedIntegral): New.
10002 (Binary.OverloadResolve_PredefinedFloating): New.
10003 (Binary.OverloadResolve_PredefinedString): New.
10004 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10005 Follow the standard more closely, and treat numeric promotions in
10006 terms of overload resolution.
10007 (Binary.CheckShiftArguments): Simplify.
10009 2006-06-01 Raja R Harinath <rharinath@novell.com>
10011 * flowanalysis.cs (MyBitVector): Simplify representation.
10012 (MyBitVector.Clone): Avoid allocating BitArray.
10013 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10014 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10015 (*): Update. Change all references to MyBitVector.And and
10016 MyBitVector.Or to &= and |=.
10018 2006-05-29 Raja R Harinath <rharinath@novell.com>
10020 Fix cs0231-[34].cs.
10021 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10022 to param arguments too.
10024 2006-05-26 Miguel de Icaza <miguel@novell.com>
10026 * cs-parser.jay: Catch another parsing form for arglist being
10027 followed by other arguments. Fixes #78313.
10029 2006-05-24 Raja R Harinath <rharinath@novell.com>
10031 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10032 checking of out parameters to ...
10033 (FlowBranchingToplevel.Merge): ... here.
10034 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10035 set, propagate the origin upward, and only complain if there was
10037 (FlowBranchingException.AddContinueOrigin): Likewise.
10038 (FlowBranchingException.AddReturnOrigin): Likewise.
10039 (FlowBranchingException.AddGotoOrigin): Likewise.
10041 2006-05-23 Raja R Harinath <rharinath@novell.com>
10043 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10044 unreachable, skip it.
10045 (FlowBranchingException.Merge): Always propagate jumps, even if
10046 the finally block renders subsequent code unreachable.
10048 2006-05-18 Raja R Harinath <rharinath@novell.com>
10051 * statement.cs (Goto.Resolve): Move responsibility for resolving
10052 'goto' to FlowBranching.AddGotoOrigin.
10053 (Goto.SetResolvedTarget): New. Callback to set the
10054 LabeledStatement that's the target of the goto.
10055 (Goto.DoEmit): Use Leave instead of Br when crossing an
10056 unwind-protect boundary.
10057 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10058 LookupLabel and adjust to new semantics.
10059 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10060 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10061 Goto.SetResolvedTarget to update target.
10062 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10063 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10064 AddBreakOrigin & co. Delay propagation until ...
10065 (FlowBranchingException.Merge): ... this.
10067 * statement.cs (Block.Resolve): Always depend on flow-branching to
10068 determine unreachability. Kill workaround that originally emitted
10069 only one statement after an "unreachable" label (see infloop in
10072 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10073 This is still "wrong", but anything better would probably need a
10074 multi-pass algorithm.
10075 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10076 usage vector. Force current usage vector to be reachable, to
10077 optimistically signify backward jumps.
10078 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10080 (FlowBranchingLabeled.Merge): New. If no backward jump was
10081 detected, return the original salted-away usage vector instead,
10082 updated with appropriate changes. Print unreachable warning if
10084 * statement.cs (Block.Resolve): Don't print unreachable warning on
10085 a labeled statement.
10087 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10089 * driver.cs: Pass filename without path to AssemblyBuilder's
10090 AddResourceFile. Fixes bug #78407.
10092 2006-05-17 Raja R Harinath <rharinath@novell.com>
10094 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10095 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10096 (FlowBranching.MergeChild): Overwrite
10097 reachability information from Labeled branchings too.
10099 2006-05-16 Raja R Harinath <rharinath@novell.com>
10101 * statement.cs (Goto.Resolve): Merge jump origins here ...
10102 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10104 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10105 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10106 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10107 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10109 * statement.cs (Goto.Resolve): ... not here.
10110 (Goto.Emit): Remove CS1632 check.
10112 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10114 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10117 2006-05-11 Raja R Harinath <rharinath@novell.com>
10119 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10120 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10121 (FlowBranchingException.Label): Likewise.
10123 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10125 (MyBitVector.Or): Use it to avoid losing information (Count).
10126 (FlowBranching.MergeOrigins): Likewise.
10128 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10129 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10130 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10131 (UsageVector.ToString): Simplify.
10132 (UsageVector.MergeSiblings): Move here from ...
10133 (FlowBranching.Merge): ... here.
10134 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10137 2006-05-10 Raja R Harinath <rharinath@novell.com>
10139 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10140 null bitvector is treated as all-true.
10142 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10143 (MyBitVector): Rationalize invariants. 'vector != null' implies
10144 that we have our own copy of the bitvector. Otherwise,
10145 'InheritsFrom == null' implies all inherited bits are true.
10147 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10149 * statement.cs (LocalInfo): Add IsConstant.
10150 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10151 local variable for constants.
10153 2006-05-09 Raja R Harinath <rharinath@novell.com>
10155 * flowanalysis.cs (MyBitVector.Empty): New.
10156 (MyBitVector): Don't allow InheritedFrom to be null.
10157 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10158 (UsageVector, FlowBranching): Update to changes.
10160 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10161 recursion. The 'Parent == null' condition isn't sufficient for
10163 (FlowBranching.AddBreakOrigin): Likewise.
10164 (FlowBranching.AddContinueOrigin): Likewise.
10165 (FlowBranching.AddReturnOrigin): Likewise.
10166 (FlowBranching.StealFinallyClauses): Likewise.
10167 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10168 (FlowBranching.CheckOutParameters): Likewise.
10169 (FlowBranchingToplevel): Terminate all the above recursions here.
10170 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10171 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10173 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10175 (FlowBranchingToplevel): New. Empty for now.
10176 (FlowBranching.MergeTopBlock): Update.
10177 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10178 branching for the anonymous delegate.
10179 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10181 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10182 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10183 information at the start of the merge. Reorganize.
10185 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10187 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10189 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10191 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10192 to newly introduced ctor.
10194 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10195 message to one place.
10196 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10199 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10201 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10203 * ecore.cs (Expression.ResolveAsConstant): Updated.
10205 * statement.cs (ResolveMeta): Updated.
10207 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10209 * cs-parser.jay: __arglist cannot be used in initializer.
10211 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10214 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10217 2006-05-05 Raja R Harinath <rharinath@novell.com>
10219 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10220 (LabeledStatement): Add 'name' parameter.
10221 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10222 (Block.AddLabel): Update to changes.
10223 * cs-parser.jay (labeled_statement): Likewise.
10225 * flowanalysis.cs (BranchingType.Labeled): New.
10226 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10227 (FlowBranchingLabeled): New. Does nothing for now, but will
10228 eventually handle 'goto' flows.
10229 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10230 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10231 that's terminated ...
10232 (Block.Resolve): ... here.
10234 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10235 (UsageVector.MergeFinallyOrigins): Likewise.
10236 (FlowBranching.InTryOrCatch): Likewise.
10237 (FlowBranching.AddFinallyVector): Likewise.
10238 (FlowBranchingException): Update to changes.
10241 * statement.cs (Return.Resolve): Move error checking to ...
10242 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10243 (FlowBranchingException): Handle return origins like break and
10245 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10247 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10250 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10253 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10256 * class.cs (MethodData.Define): Do public accessor check only when method
10257 implements an interface.
10259 2006-05-04 Raja R Harinath <rharinath@novell.com>
10261 Remove special handling of 'break'
10262 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10263 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10264 (UsageVector.Break): Remove.
10265 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10267 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10269 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10270 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10272 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10275 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10276 be the interface member.
10278 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10281 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10282 for emitting small (int) values.
10284 2006-05-03 Raja R Harinath <rharinath@novell.com>
10287 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10288 control-flow passes through the 'finally' after merging-in all the
10289 control-flows from 'try' and the 'catch' clauses.
10291 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10292 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10293 always true at the only non-recursive entry point.
10294 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10295 FlowBranchingBreakable.
10296 (FlowBranchingLoop): Remove.
10297 * statement.cs (Return.DoResolve): Update to changes.
10300 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10301 (FlowBranching.CreateBranching): Handle it: create a
10302 FlowBranchingContinuable.
10303 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10304 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10305 except that it handles the 'continue' command.
10306 (FlowBranching.UsageVector.MergeOrigins): Rename from
10308 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10309 except that it overrides AddContinueOrigin.
10310 (FlowBranchingException): Override AddContinueOrigin, similar to
10312 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10313 Create a new branching around the embedded statement.
10314 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10315 control flow after the embedded statement.
10316 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10318 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10319 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10320 FlowBranchingBreakable.
10321 (FlowBranchingSwitch): Remove.
10324 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10325 error reporting to ...
10326 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10327 Rename from 'AddBreakVector'. Add new location argument. Return
10328 a bool indicating whether the 'break' crosses an unwind-protect.
10329 (FlowBranchingException.AddBreakOrigin): Add.
10330 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10331 flowbranching after updating with the effects of the 'finally'
10333 (FlowBranchingBreakable): New common base class for
10334 FlowBranchingLoop and FlowBranchingSwitch.
10336 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10337 embedded statement.
10338 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10340 2006-05-02 Raja R Harinath <rharinath@novell.com>
10342 * statement.cs (Do.Resolve): If the loop is infinite, set the
10344 (While.Resolve, For.Resolve): Set a barrier after the embedded
10345 statement. There's no direct control flow that goes from the end
10346 of the embedded statement to the end of the loop.
10347 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10348 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10349 above ensure that the reachability is correctly computed.
10351 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10352 (UsageVector.MergeBreakOrigins): If the current path is
10353 unreachable, treat it as if all parameters/locals are initialized.
10354 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10355 infinite loops before merging-in break origins.
10357 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10358 (Reachability.Reachable): Split part into ...
10359 (Reachability.Unreachable): ... this. Simplify.
10360 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10362 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10363 (Reachability.SetThrowsSometimes): Likewise.
10364 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10365 TriState.Always, use corresponding property.
10366 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10367 (Block.Resolve): Likewise. Remove some redundant checks.
10369 2006-05-02 Raja R Harinath <harinath@gmail.com>
10371 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10372 (Reachability.Meet): Don't bother checking AlwaysThrows --
10373 barrier is always set.
10374 (FlowBranchingBlock.Merge): Likewise.
10376 2006-05-01 Raja R Harinath <harinath@gmail.com>
10378 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10379 checks for unreachable.
10381 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10384 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10386 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10387 whether field is really assigned.
10389 2006-04-30 Raja R Harinath <harinath@gmail.com>
10391 * flowanalysis.cs (Reachability): Make 4-argument constructor
10393 (Reachability.Meet): Rename from 'And'. Remove static variant.
10394 (Reachability.Always): Rename from the highly misleading
10395 'Reachability.Never'.
10396 (FlowBranching.Merge): Update to changes. Mark an impossible
10397 situation with a 'throw'.
10398 (*): Update to changes.
10400 2006-04-29 Raja R Harinath <harinath@gmail.com>
10402 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10403 Remove 'Undefined'.
10404 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10405 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10406 (*): Update to changes.
10407 * statement.cs: Update to changes.
10409 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10412 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10414 2006-04-28 Raja R Harinath <harinath@gmail.com>
10416 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10419 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10420 argument to two arguments: an usage-vector and a bool. Move call
10421 to FlowBranching.Merge () ...
10422 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10424 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10425 handling of loop and switch reachability to ...
10426 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10428 2006-04-27 Raja R Harinath <harinath@gmail.com>
10430 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10431 handling to FlowBranchingLoop.InLoop.
10432 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10434 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10437 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10438 anonymous method is allowed from AnonymousContainer here.
10440 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10442 2006-04-24 Raja R Harinath <rharinath@novell.com>
10445 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10447 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10450 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10451 (DoubleConstant.Reduce): Ditto.
10453 2006-04-23 Raja R Harinath <rharinath@novell.com>
10455 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10456 Remove 'lvalue_right_side' argument. Move parts to ...
10457 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10458 (LocalVariable.DoResolveLValue): ... these.
10460 2006-04-21 Raja R Harinath <rharinath@novell.com>
10463 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10464 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10465 (LocalVariableReference.DoResolveBase): Use it to implement new
10467 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10468 (Argument.Resolve): Simplify. Move CS1510 check ...
10469 * ecore.cs (Expression.ResolveLValue): ... here.
10470 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10471 (PropertyExpr.DoResolveLValue): Likewise.
10472 (FieldExpr.Report_AssignToReadonly): Likewise.
10473 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10474 LValueMemberAccess or LValueMemberOutAccess on instance depending
10476 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10477 DoResolve as appropriate.
10479 2006-04-20 Raja R Harinath <rharinath@novell.com>
10482 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10483 implicit conversions on 'out' and 'ref' arguments.
10485 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10486 improve clarity. Remove dead code.
10489 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10490 (Catch.Resolve): Resolve VarBlock if it exists.
10492 2006-04-19 Miguel de Icaza <miguel@novell.com>
10494 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10495 twice, this was some residual code, the enumerator was emitted
10496 properly in the two branche of if later.
10498 2006-04-19 Raja R Harinath <rharinath@novell.com>
10500 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10501 cast is never an lvalue.
10502 (Cast.DoResolve, Cast.ResolveRest): Combine.
10503 (Argument.Emit): Simplify slightly. Move 'Expr is
10504 IMemoryLocation' check ...
10505 (Argument.Resolve): ... here.
10506 (Argument.Error_LValueRequired): Remove. Inline into only user.
10508 Simplifications. Fix cs0191-2.cs
10509 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10510 CS1649 and CS1651 to ...
10511 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10512 the actual selection of the error code and message to a lookup
10513 table. Add a dummy return value to simplify callsites.
10514 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10515 readonly fields of other instances of the same type. Move CS0197
10517 * expression.cs (Argument.Resolve): ... here. Simplify code.
10518 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10519 resolution of an out or ref argument. The code simplification
10520 above uses this invariant.
10522 2006-04-18 Raja R Harinath <rharinath@novell.com>
10524 Possibly fix #77752. Fix cs1690-[4-7].cs.
10525 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10526 CheckMarshallByRefAccess. Drop parameter.
10527 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10529 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10530 InstanceExpression.
10531 * report.cs (AllWarnings): Add CS1690.
10532 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10533 for ref access too.
10534 (LocalVariableReference.DoResolveBase): Update.
10536 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10538 * class.cs (MethodOrOperator): Moved common parts from method class.
10539 detect obsolete attributes.
10540 (Method.Define): Simplified as it reuses code from base.
10541 (Constructor.ValidAttributeTargets): Fixed issue found during
10543 (Destructor.ValidAttributeTargets): Fixed issue found during
10545 (Operator): Finished refactoring set off by #78020. Operator class is now
10546 ordinary method class.
10548 * anonymous.cs: Updated.
10550 * decl.cs (DeclSpace): Add IsGeneric
10552 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10554 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10556 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10558 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10559 detect obsolete attributes.
10560 (Method.CreateEmitContext): Moved to MethodOrOperator.
10562 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10565 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10566 customized exception to make crash detection easier.
10567 (MethodOrOperator): Started to work on new base class for methods and
10569 (Method): Derives from MethodOrOperator.
10570 (Constructor.Emit): Emits its own attributes.
10571 (AbstractPropertyEventMethod.Emit): Ditto.
10572 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10574 (Operator.Emit): It's temporary more tricky than should be.
10576 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10578 * report.cs (InternalErrorException): Add ctor with inner exception.
10580 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10583 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10586 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10589 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10592 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10594 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10595 attribute is present and Guid not.
10596 (Interface.ApplyAttributeBuilder): Ditto.
10598 * attribute.cs: Add error message.
10600 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10604 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10605 sources (it's composite) so hold them in extra array as they are used in
10606 Emit phase only. It worked in the previous versions by mistake.
10607 (Attribute.Emit): Emit attribute for more owners when exist.
10609 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10610 it has now different behaviour.
10612 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10614 * constant.cs (Constant.IsDefaultInitializer): New method.
10616 * class.cs: Updated.
10618 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10619 re-initialize default values. It saves KBs almost for every assembly.
10620 Thanks Zoltan for the idea.
10621 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10622 (ArrayCreation.DoResolve): Resolve only once.
10623 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10624 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10626 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10628 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10631 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10633 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10634 in an embedded statement too.
10636 2006-04-01 Raja R Harinath <rharinath@novell.com>
10639 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10641 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10645 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10648 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10650 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10652 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10655 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10656 LocalTemporary change.
10658 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10660 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10661 initializers optimization.
10662 (ClassOrStruct.TypeAttr): Moved from modifiers.
10663 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10664 (FieldBase.ResolveInitializer): Resolves initializer.
10665 (FieldBase.HasDefaultInitializer): New property.
10667 * cs-parser.jay: Removed message.
10669 * expression.cs (CompilerGeneratedThis): New specialization.
10671 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10673 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10675 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10677 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10679 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10680 be now EnumConstants only.
10682 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10684 * attribute.cs, driver.cs: Reset more caches.
10686 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10688 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10690 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10692 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10693 for easier reuse. Updated all overrides.
10694 (IntegralConstant): New base class for all integral constants.
10695 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10696 of the constant range, report custom error.
10697 (UIntConstant.Reduce): Fixed uint conversion.
10699 * ecore.cs, literal.cs: Reduce updates.
10701 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10705 * class.cs (Constructor.Define): Removed extra if for default ctors.
10706 A patch from Atsushi Enomoto.
10708 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10710 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10711 GetAttributableValue.
10713 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10716 * convert.cs (ImplicitConversionRequired): Error message moved to
10719 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10720 automatic implicit conversion of an output value.
10721 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10723 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10725 (TypeOf.GetAttributableValue): Add extra handling for object type.
10727 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10728 special error message.
10730 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10732 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10734 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10735 compatible with MS runtime.
10737 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10739 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10740 attribute arguments here.
10742 * class.cs (Indexer.Define): The check was moved to attribute class.
10744 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10746 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10747 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10750 2006-03-22 Raja R Harinath <rharinath@novell.com>
10752 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10753 mcs to keep code differences small.
10754 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10755 * typemanager.cs (parameter_default_value_attribute_type): New.
10756 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10759 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10761 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10763 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10765 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10767 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10770 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10772 * doc-bootstrap.cs : fix build.
10774 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10776 * expression.cs (StringConcat.Append): Issue a warning when empty string
10777 is going to append.
10779 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10781 * assign.cs (CompoundAssign.ResolveSource): Removed.
10783 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10786 * class.cs (TypeContainer.FindMethods): Removed.
10787 (TypeContainer.CheckMemberUsage): Made static.
10789 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10791 * constant.cs (CheckRange): Removed unused type argument.
10792 (CheckUnsigned): Removed unused type argument.
10794 * cs-parser.jay: Updated after MemberAccess clean up.
10795 Uses Length for empty string test.
10797 * cs-tokenizer.cs: Uses Length for empty string test.
10798 (IsCastToken): Made static.
10799 (is_hex): Made static.
10800 (real_type_suffix): Made static.
10802 * decl.cs (SetupCache): Made static.
10803 (OnGenerateDocComment): Removed unused ds argument.
10805 * delegate.cs (VerifyDelegate): Removed unused argument.
10807 * doc.cs: Uses Length for empty string test.
10809 * driver.cs: Uses Length for empty string test.
10811 * enum.cs (IsValidEnumType): Made static
10813 * expression.cs (EnumLiftUp): Removed unused argument.
10814 (ResolveMethodGroup): Ditto.
10815 (BetterConversion): Ditto.
10816 (GetVarargsTypes): Ditto.
10817 (UpdateIndices): Ditto.
10818 (ValidateInitializers): Ditto.
10819 (MemberAccess.ctor): Ditto.
10820 (GetIndexersForType): Ditto.
10822 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10824 * iterators.cs: Updated after MemberAccess clean up.
10826 * location.cs: Uses Length for empty string test.
10828 * namespace.cs: Uses Length for empty string test.
10830 * report.cs (CheckWarningCode): Made static.
10832 * statement.cs (LabeledStatement): Removed unused argument.
10834 * typemanager.cs (FilterNone): Removed.
10836 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10838 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10841 * class.cs: Updated.
10843 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10845 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10847 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10851 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10852 reporting, it's more tricky than I thought.
10854 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10858 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10860 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10861 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10862 Add more error reporting; Fixed issue with params.
10864 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10866 * cs-parser.jay: AnonymousMethod requires host container.
10868 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10870 2006-03-18 Raja R Harinath <harinath@gmail.com>
10872 * class.cs: Change 'TypeContainer ds' constructor argument to
10873 'DeclSpace parent'. Some classes were missed below due to
10874 different naming convention.
10876 * class.cs (MemberCore.Parent): Delete. This makes the
10877 ParentContainer changes below enforceable by the compiler.
10879 Treat pointers to enclosing declaration space as 'DeclSpace', not
10881 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
10882 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
10884 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
10886 (Block.AddThisVariable): Likewise.
10887 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
10888 (AbstractPropertyEventMethod.Emit): Likewise.
10889 (AbstractPropertyEventMethod.EmitMethod): Likewise.
10890 (GetMethod.Define, SetMethod.Define): Likewise.
10891 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
10892 (DelegateMethod.EmitMethod): Likewise.
10894 Fix regression test-partial-13.cs.
10895 Rationalize use of PartialContainer. Ensure that the partial
10896 class semantics can be tied to type-correctness, i.e., any
10897 violation will cause a compile error.
10898 * class.cs, const.cs: Access all fields that belong to class
10899 TypeContainer via ParentContainer. Arguments of EmitContexts and
10900 Resolve()-like functions still use 'Parent'.
10902 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
10903 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
10904 (PropertyMethod.CheckModifiers): Remove unused argument.
10905 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
10908 2006-03-17 Raja R Harinath <harinath@gmail.com>
10910 Make semantics of PartialContainer simpler.
10911 * decl.cs (DeclSpace.IsPartial): Remove.
10912 * class.cs (TypeContainer.IsPartial): Likewise.
10913 (TypeContainer..ctor): Set PartialContainer to point to self.
10914 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
10915 (TypeContainer.FindNestedType): Likewise.
10916 (MemberCore.ParentContainer): Simplify. Remove deprecation.
10918 2006-03-17 Marek Safar <marek.safar@seznam.cz>
10920 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
10922 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10924 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
10927 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10929 * class.cs (Operator.Define): An error for base conversion was not
10930 reported correctly.
10932 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
10934 * iterator.cs : yield break is allowed in try statement which has
10935 catch clauses. Fixed bug #77767.
10937 2006-03-13 Marek Safar <marek.safar@seznam.cz>
10939 A fix for #77593, #77574.
10941 * class.cs (MethodCore.CheckBase): Another if for operator.
10943 2006-03-09 Marek Safar <marek.safar@seznam.cz>
10945 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
10948 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
10949 (DelegateCreation.ImplicitStandardConversionExists): New method for just
10952 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
10955 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
10956 Updated after another emitcontext usage was clean up. It should help us to
10957 synchronize with gmcs easier.
10959 2006-03-04 Marek Safar <marek.safar@seznam.cz>
10963 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
10964 (Event.Define): ditto
10965 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
10967 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
10968 Removed redundant code and set NewSlot for Invoke method too.
10970 * parameter.cs (Parameters.ctor): Add custom, type ctor.
10971 (Parameters.MergeGenerated): New method. Use this method when you merge
10972 compiler generated argument with user arguments.
10974 2006-03-03 Marek Safar <marek.safar@seznam.cz>
10976 * attribute.cs (ResolveAsTypeTerminal): Removed.
10978 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
10979 specialization for predefined types; 30% speed up.
10980 Finally placed obsolete check to right place.
10981 (Expression.ResolveType): Removed.
10983 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
10984 Updated after ResolveType was removed.
10986 * expression.cs (Cast.ctor): Check void cast.
10987 (Binary.ResolveAsTypeTerminal): Is never type.
10988 (Conditional.ResolveAsTypeTerminal): Is never type.
10990 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
10992 2006-03-01 Raja R Harinath <rharinath@novell.com>
10995 * expression.cs (ParameterReference.DoResolveBase): Change return
10997 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11001 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11004 * typemanager.cs (GetFullNameSignature): Don't nullref on
11005 protected accessors.
11007 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11009 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11010 these two separated members to simplify the code.
11011 (Attribute.Resolve): Refactored to use new fields and methods.
11012 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11013 implemented obsolete attribute checking.
11014 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11015 implemented obsolete checking again. It look line never ending quest ;-)
11016 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11018 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11020 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11022 *class.cs (Property.Define): Add RegisterProperty call.
11024 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11025 argument groups (only 2).
11027 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11028 encoding expression to arguments.
11029 (Expression.ExprClassToResolveFlags): Just turned to property.
11031 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11032 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11033 optimized as well as implemented support for zero-length attributes.
11035 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11036 Add caching of PropertyInfo's.
11038 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11040 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11041 error multiple times.
11043 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11045 New partial class implementation.
11046 A fix for #77027, #77029, #77403
11048 * attribute.cs (Attributable): Made attributes protected.
11050 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11051 the replacements of ClassPart and PartialContainer.
11052 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11053 (TypeContainer.AddInterface): Ditto.
11054 (TypeContainer.AddPartial): The main method for partial classes. It checks
11055 for errors and merges ModFlags and attributes. At the end class is added to
11056 partial_parts list.
11057 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11059 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11060 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11061 from the rest of partial classes.
11062 (TypeContainer.GetClassBases): Simplified.
11063 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11065 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11066 (TypeContainer.HasExplicitLayout): Uses Flags now.
11067 (PartialContainer): Removed.
11068 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11069 (StaticClass): Was merged with Class.
11070 (Class.GetClassBases): class and static class bases are verified here.
11071 (Class.TypeAttr): Added static attributes when class is static.
11072 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11073 (MemberBase): In some cases we need to call parent container for partial
11074 class. It should be eliminated but it's not easy now.
11076 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11078 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11079 partial classed to accumulate class comments.
11080 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11082 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11084 * driver.cs (MainDriver): Tree.GetDecl was removed.
11086 * modifiers.cs (Modifiers): Add partial modifier.
11088 * tree.cs (Tree.decl): Removed.
11089 (RootTypes): Started to use this class more often for root types
11092 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11096 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11097 external interface does not have an attribute.
11099 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11101 Another prerequisites for new partial classs implementation.
11103 * attribute.cs (Attribute.Equal): Implemented.
11104 (Attribute.Emit): Changed as attributes can be applied more than twice.
11105 (Attributes.Emit): Check for duplicate attributes here.
11107 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11108 as a parameter, clean-up.
11110 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11114 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11115 contains obsolete attribute check which can in some cases look for base
11116 type of current class which is not initialized yet.
11117 (TypeContainer.BaseType): Replacement of ptype.
11119 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11121 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11123 First of prerequisites for new partial classs implemention.
11125 * attribute.cs (Attributable): Extended by ResolveContext;
11126 Attributes finally have correct context for resolving in all cases.
11127 (AttachTo): Attribute owner is assigned here.
11129 * codegen.cs (IResolveContext): Introduce new interface to hold
11130 all information needed in resolving phase.
11131 (EmitContext): Implements IResolveContext; more clean-up needed here.
11133 * decl.cs (MemberCore): Implemented IResolveContext.
11135 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11136 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11137 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11138 Refactored to use new IResolveContext instead of EmitContext; cleanup
11140 2006-02-06 Miguel de Icaza <miguel@novell.com>
11142 * codegen.cs (EmitScopeInitFromBlock): check here the
11143 capture_context, there is no need to make two calls to the
11146 * anonymous.cs: Add some debugging messages that might help me
11147 track other instances of this problem in the future (the
11148 regression of test 467).
11150 * cs-parser.jay: track the variable block, as we need to initalize
11151 any captured variables declared in this block for the "catch"
11152 portion of the "Try" statement.
11154 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11155 scope initialization for captured variables.
11157 Also, move the emit for the variables after the block location has
11160 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11162 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11164 2006-02-02 Miguel de Icaza <miguel@novell.com>
11166 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11167 commit yesterday, the initialization for the roots is necessary.
11168 What is not necessary is the scope activation.
11170 2006-02-02 Raja R Harinath <rharinath@novell.com>
11172 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11173 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11175 (Argument.Resolve): Remove CS0206 checks.
11177 2006-02-01 Miguel de Icaza <miguel@novell.com>
11179 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11180 scopes for all the roots, the scopes will now be emitted when the
11181 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11183 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11184 code. This reduces a lot of existing cruft.
11186 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11187 that the ScopeInfo is generated as we enter the scope, not at the
11188 time of use, which is what we used to do before.
11190 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11191 every time a Block is about to be emitted if we have a
11194 2006-02-01 Raja R Harinath <rharinath@novell.com>
11196 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11198 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11200 * typemanager.cs (cons_param_array_attribute): Make private.
11201 (Reset): Set it to null.
11202 (InitCoreHelpers): Don't initialize it.
11203 (ConsParamArrayAttribute): New. Initialize it as needed.
11204 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11206 2006-01-31 Miguel de Icaza <miguel@novell.com>
11208 * expression.cs: There might be errors reported during the
11209 selection of applicable methods. If there are errors, do not
11210 continue execution as it will lead the compiler to crash.
11212 2006-01-30 Miguel de Icaza <miguel@novell.com>
11214 * expression.cs: Member access is not allowed on anonymous
11215 methods. Fixes #77402.
11217 2006-01-30 Raja R Harinath <rharinath@novell.com>
11220 * cs-parser.jay (VariableDeclaration): Don't set
11221 current_array_type to null.
11222 (field_declaration, event_declaration, declaration_statement):
11223 Set it to null here.
11225 2006-01-28 Raja R Harinath <harinath@gmail.com>
11227 * typemanager.cs (GenericParameterPosition): New.
11230 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11232 * doc.cs : To process "include" elements, first we should create
11233 another list than XmlNodeList, because it could result in node
11234 removal, which could result in that the XmlNodeList gives up
11235 yielding next node.
11237 (Also made code identical to gmcs again.)
11239 2006-01-25 Miguel de Icaza <miguel@novell.com>
11241 * ecore.cs: Introduce an error report that we were not catching
11242 before, if not silent, we must report the error. Gonzalo ran into
11245 2006-01-23 Miguel de Icaza <miguel@novell.com>
11247 A fix for bug: #76957
11249 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11250 ComputeMethodHost before creating the method, this is a new
11253 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11254 that this method references (RegisterScope). The actual scope
11255 where the method is hosted is computed with the ComputeMethodHost
11256 before we create the method.
11258 Moved the Deepest routine here.
11260 (AnonymousContainer.ComputeMethodHost): New routine used to
11261 compute the proper ScopeInfo that will host the anonymous method.
11263 (ScopeInfo): Deal with multiple roots. The problem was that we
11264 did not have a unique root where all ScopeInfos could be hanged
11265 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11268 Remove AdjustMethodScope which is now computed at the end. Remove
11269 LinkScope which did a partial link, instead link all ScopeInfos
11270 before code generation from the new "LinkScopes" routine.
11272 Simplify all the Add* routines as they no longer need to maintain
11273 the tree, they just need to record that they are using variables
11276 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11277 routines to produce the forest of ScopeInfo trees.
11279 * class.cs (TypeContainer.AppendMethod): This is just like
11280 AddMethod, but ensures that an interface implementation method
11281 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11282 methods, but at the end.
11284 We use this functionality to ensure that the generated MoveNext
11285 method in the iterator class is resolved/emitted before the
11286 enumerator methods created.
11288 This is required because the MoveNext method computes the right
11289 ScopeInfo for the method. And the other methods will eventually
11290 need to resolve and fetch information computed from the anonymous
11293 2006-01-21 Raja R Harinath <harinath@gmail.com>
11294 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11296 Fix rest of #76995.
11297 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11298 the 'aliases' hash.
11299 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11300 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11302 2006-01-18 Raja R Harinath <rharinath@novell.com>
11304 Fix #76656, cs0231-2.cs.
11305 * cs-parser.jay (formal_parameter_list): Make error case catch
11307 (parenthesized_expression_0): Add CS1026 check.
11308 (invocation_expression): Remove unused { $$ = lexer.Location }.
11310 2006-01-17 Raja R Harinath <rharinath@novell.com>
11313 * cs-parser.jay (statement_expression): Don't list out the
11314 individual statement-expressions. Convert syntax error into
11317 2006-01-16 Raja R Harinath <rharinath@novell.com>
11320 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11321 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11322 CheckIntermediateModification.
11323 (FieldExpr.DoResolve): Add new two-argument version that
11324 allows us to resolve the InstanceExpression as an lvalue.
11325 The one-argument variant is now just a wrapper.
11326 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11327 Resolve the lhs as an lvalue if the it has a value type.
11328 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11329 from Assign.DoResolve.
11330 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11331 resolved as an lvalue.
11332 (PropertyExpr.DoResolve): Update.
11333 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11334 has a value type. Move CS1612 check here from
11335 CheckIntermediateModification.
11336 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11337 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11338 'right_side' of a ResolveLValue on an 'out' argument.
11339 (EmptyExpression.LValueMemberAccess): New. Used as the
11340 'right_side' of a propagated ResolveLValue on a value type.
11341 (LocalVariableReference.DoResolveBase): Recognize
11342 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11344 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11345 EmptyExpression.Null.
11347 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11349 * typemanager.cs : added IsGenericParameter(). In mcs it always
11351 * doc.cs : for generic parameters, use GenericParameterPosition,
11354 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11356 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11358 2006-01-12 Miguel de Icaza <miguel@novell.com>
11360 This fixes the problem where we used ldfld instead of ldflda to
11361 load the "THIS" pointer on captured parameters, when THIS is a
11362 value type. See bug #77205.
11364 * iterators.cs (CapturedThisReference.Emit): Pass false to
11365 EmitThis (we do not need the address).
11367 * codegen.cs (EmitThis): it needs to know whether we need the
11368 address of `this' or not. This is used by value types.
11370 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11371 every other call passes false.
11373 2006-01-12 Raja R Harinath <rharinath@novell.com>
11376 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11378 * expression.cs (Invocation.OverloadResolve): Update.
11379 (Invocation.DoResolve): Avoid double resolution of invocation.
11381 2006-01-11 Raja R Harinath <rharinath@novell.com>
11384 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11385 unary negation of floating point types as 0-expr; negation cannot
11386 overflow in floating point types.
11389 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11390 on operands of 'void' type.
11393 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11394 and ExclusiveOr for boolean constants too.
11396 2006-01-09 Raja R Harinath <rharinath@novell.com>
11399 * expression.cs (Invocation.OverloadResolve): Replace reflected
11400 override methods with their base virtual methods, rather than
11401 skipping over them.
11402 * typemanager.cs (TypeManager.GetOverride): New.
11404 2006-01-05 Jb Evain <jbevain@gmail.com>
11406 * class.cs (Property.Define, Indexer.Define): do not tag the
11407 properties as SpecialName | RTSpecialName.
11409 2006-01-04 Miguel de Icaza <miguel@novell.com>
11411 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11412 doing a low-level comparission of parameter types. It was lacking
11413 a check for __argslist.
11415 2005-12-30 Miguel de Icaza <miguel@novell.com>
11417 * expression.cs (ParameterReference.DoResolveBase): Allow
11418 reference parameters if they are local to this block.
11420 This allows the ref and out parameters of a delegate to be used in
11421 an anonymous method, for example:
11423 delegate void set (out int x);
11425 set s = delegate (out int x){
11429 This is used by functionality introduced late in the C# language.
11431 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11432 method that take ref and out parameters.
11434 Fixes #77119 which was a late change in the spec.
11436 2005-12-23 Miguel de Icaza <miguel@novell.com>
11438 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11439 parent if its the same scope. Fixes #77060.
11441 2005-12-21 Miguel de Icaza <miguel@novell.com>
11443 * driver.cs: Report the case of no source files and no -out:
11446 2005-12-20 Raja R Harinath <rharinath@novell.com>
11449 * expression.cs (ComposedCast.GetSignatureForError): Define.
11451 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11455 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11456 ListDictionary, to contain the ExternAliasEntry entries (in
11457 addition to the NamespaceEntry.aliases hashtable). This field is
11458 shared between the original entry and its doppelganger (bodyless
11460 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11461 extern_aliases field.
11462 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11463 lookup in extern_aliases.
11465 2005-12-16 Raja R Harinath <rharinath@novell.com>
11468 * class.cs (TypeContainer.Mark_HasEquals): New.
11469 (TypeContainer.Mark_HasGetHashCode): New.
11470 (ClassPart): Override them.
11471 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11474 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11475 'parent' argument to the base constructor.
11477 Remove all mention of TypeContainer from decl.cs.
11478 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11479 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11480 (DeclSpace.DeclSpace): Likewise.
11481 (DeclSpace.DefineMembers): Remove unused argument.
11482 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11483 debugging check -- we don't care if the debug code throws an
11484 InvalidCastException instead of an InternalErrorException.
11485 * class.cs (TypeContainer.DefineMembers): Update to changes.
11486 (TypeContainer.DoDefineMembers): Likewise.
11487 (TypeContainer.GetMethods): Likewise.
11488 (PropertyMember.Define): Likewise.
11489 (MemberBase.Parent): New property that forwards to
11490 MemberCore.Parent, but ensures that we get a TypeContainer.
11491 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11492 (RootContext.PopulateTypes): Likewise. Remove special case code
11493 for !RootContext.StdLib: DefineMembers is idempotent.
11495 2005-12-14 Miguel de Icaza <miguel@novell.com>
11497 * convert.cs (ExplicitConversionCore): Check the return value from
11498 ExplicitConversionCore which can return null on failure. Fixes #76914
11500 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11502 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11504 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11506 * doc.cs : The search for referenced namespace was insufficient to
11507 get global one as it used to do. Fixed bug #76965.
11509 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11511 * doc.cs : check name in cref in the last phase that whether it is
11514 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11516 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11519 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11521 * doc.cs : so it turned out that we cannot skip override check for
11522 interface members. Fixed bug #76954.
11524 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11526 * cs-tokenizer.cs : fixed bug #75984:
11527 - #warning and #error should not be handled when the source line
11529 - #line is not checked strictly when the source line is disabled.
11530 - #define and #undef is on the other hand checked strictly at any
11533 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11535 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11538 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11540 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11542 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11543 event initializers.
11544 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11545 (FieldBase.Initializer): Initializer is now optional.
11546 (EventField.Define): Only event field can have initializer.
11548 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11550 * const.cs (Const): Reuse initializer.
11552 * cs-parser.jay: Updated after FieldBase changes.
11553 Added current_array_type to simplify array initializers.
11555 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11557 * expression.cs, iterators.cs: Updated.
11559 * namespace.cs (NamespaceEntry): Made UsingFound private.
11561 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11563 * parameterCollection.cs: Obsolete, removed.
11564 * parser.cs: Obsolete, removed.
11566 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11569 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11571 * enum.cs (Enum.Define): Set obsolete context here.
11573 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11576 - FindDocumentedMember() now expects 1) paramList as null
11577 when "we don't have to check the number of parameters" and
11578 2) Type.EmptyTypes when "there is no arguments".
11579 - Introduced FoundMember struct to hold the exact type which was
11580 used to find the documented member (the above change broke
11581 test-xml-044; it might be better just to use DeclaringType than
11582 what MS does, like this change does, but it depends on usage.)
11584 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11586 * doc.cs : documented member might be from DeclaringType for nested
11587 types. Fixed bug #76782.
11589 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11591 * anonymous.cs: Have the param code handle leaving copies on the
11592 stack etc. Allows anonymous params to take part in the assignment
11593 code (++, +=, etc). Fixes bug #76550
11595 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11596 it down to the anon code.
11598 * iterators.cs: Use dummy var here
11600 * codegen.cs: Handle new vars
11602 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11605 * class.cs (MethodData.Define): Set proper Obsolete context.
11607 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11609 (FieldExpr.DoResolve): Ditto.
11611 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11614 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11615 parent is not obsolete.
11617 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11619 * doc.cs : (FindDocumentedMember) find parameterless members first
11620 and get CS0419 in the early stage. Fixed first case of bug #76727.
11622 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11625 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11626 no error was reported.
11628 *expression.cs (Binary.DoResolve): left can be null.
11630 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11633 * class.cs (MethodData.Emit): Parameters should be labeled first.
11635 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11638 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11640 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11642 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11644 * class.cs (MethodCore): Parameter clean up.
11645 (IMethodData): Added ParameterInfo.
11646 (MethodData): Parameter clean up.
11647 (Indexer.Define): Parameter clean up.
11659 * typemanager.cs: Parameter clean up.
11661 * delegate.cs (Define): Get rid of duplicated code.
11663 * expression.cs (ParameterReference): Removed useless parameters
11665 (Invocation): Ditto.
11667 * parameter.cs (ParamsParameter): New class, params specialization.
11668 (ArglistParameter): Attemp to separate arglist.
11669 (Parameter): Refactored to be reusable and faster.
11670 (Parameter.Modifier): Made understandable.
11671 (Parameters): Changed to be used as a class for `this' assembly
11672 parameters. Refactored to use new specialized classes.
11674 * support.cs (ParameterData): Added Types property.
11675 (InternalParameters): Deleted.
11677 2005-08-20 Martin Baulig <martin@ximian.com>
11679 Merging this patch from GMCS to fix #75867.
11681 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11682 scope if we don't already have it.
11684 2005-11-17 Martin Baulig <martin@ximian.com>
11687 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11688 inherit the scope from our parent. Fixes #76653.
11690 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11692 * doc.cs : the previous patch does not actually fix the bug.
11693 PropertyInfo override check is now implemented and really fixed it.
11694 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11696 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11698 * doc.cs : apply "override filter" also to properties.
11701 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11703 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11704 no need to check overrides. For classes, omit those results from
11705 interfaces since they must exist in the class. Fixed bug #76726.
11707 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11709 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11710 with different parameters. Fixed the second problem in #76685.
11712 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11714 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11715 get expected 'protected' access in CheckValidFamilyAccess()).
11718 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11720 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11721 Fixed bug #76705. CS1569 was incorrectly commented out.
11723 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11725 * doc.cs : use Invocation.IsOverride() to do real override check.
11726 * expression.cs : made Invocation.IsOverride() internal.
11728 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11730 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11731 TypeBuilder.FindMembers() and filter overriden base members out.
11734 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11736 * doc.cs : ref/out parameters are represented as '@' (instead of
11737 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11739 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11741 * doc.cs : when there was no '.' in cref to methods in doc comment,
11742 then parameters were missing in the output. Fixed bug #76691.
11744 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11746 * driver.cs : don't output docs when there is an error.
11749 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11752 Now it should detect indexers. Fixed primary concern in bug #76685.
11753 Fixed CS0419 message to not show the identical member signature in
11756 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11758 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11759 instead of Type.FindMembers() since it does not handle events.
11762 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11764 * codegen.cs: Fixed typo (speficied -> specified).
11766 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11769 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11771 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11773 * attribute.cs: Changed error message.
11775 * cs-tokenizer.cs: One more check.
11777 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11779 * statement.cs (Block.Resolve): Ignore empty statement.
11781 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11783 * report.cs: Made error/warning methods more strict to avoid
11786 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11787 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11788 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11789 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11791 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11793 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11794 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11796 * class.cs (TypeContainer.IsComImport): New property.
11797 (Constructor.Define): Create proper ctor for ComImport types.
11799 * expression.cs (New.CheckComImport): Fixed.
11801 2005-11-07 Miguel de Icaza <miguel@novell.com>
11803 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11804 that a parameter has been captured does not mean that we do not
11805 have to do the rest of the processing. This fixes the second part
11806 of #76592. If there was another anonymous method capturing
11807 values in the past, the Scope would never be set for the second
11808 method that captured the same parameter.
11810 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11811 properly manipulate the stack. Second part of fix for #76592.
11813 * expression.cs (New): Add support for invoking "new" on
11814 interfaces that have been flagged with the ComImport attribute and
11815 the CoClass. Fixes #76637
11817 * statement.cs (Try.DoEmit): When a variable is captured, do not
11818 try to emit the vi.LocalBuilder variable as it has been captured.
11819 Create a temporary variable and store the results on the
11820 FieldBuilder. Fixes #76642
11822 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11824 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11826 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11828 * expression.cs (Binary.DoResolve): Added && optimalization.
11830 * typemanager.cs (AddUserType): Removed useless argument.
11832 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11834 * statement.cs (Block.variables): Uses ListDictionary.
11836 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11839 * class.cs (PartialContainer.EmitType): Customized to emit
11840 security attributes.
11841 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11842 for partial classes.
11844 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11847 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11848 access has to be fixed.
11850 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11852 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11855 * ecore.cs (NullCast.Reduce): Implemented.
11857 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11860 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11862 (Foreach.Resolve): Catch null properly.
11864 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11866 * cs-tokenizer.cs: Warning text fix.
11868 * driver.cs: AllWarningNumbers exposed on public interface.
11870 * report.cs (): Reviewed warning numbers.
11871 (IsValidWarning): Use binary search.
11873 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11875 * driver.cs: Implemeted resource visibility.
11876 (Resources): New class for code sharing between /res: and
11879 2005-10-28 Marek Safar <marek.safar@seznam.cz>
11882 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
11885 * convert (Convert.ImplicitReferenceConversion): NullCast holds
11888 * ecore.cs (NullCast): Child is contant only.
11890 * literal.cs (NullLiteral.Reduce): null can be converted to any
11893 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
11895 * driver.cs: Use Encoding.Default as default code page instead
11898 2005-10-27 Raja R Harinath <rharinath@novell.com>
11901 * expression.cs (Invocation.Error_InvalidArguments): Handle
11902 __arglist parameters.
11903 (Invocation.VerifyArgumentsCompat): Likewise.
11904 * support.cs (ReflectionParameters.GetSignatureForError): Print
11905 __arglist parameters.
11906 (InternalParamters.GetSignatureForError): Likewise.
11907 * parameter.cs (Parameters.GetSignatureForError): Likewise.
11909 2005-10-26 Marek Safar <marek.safar@seznam.cz>
11911 * attribute.cs (GetPropertyValue): Made public.
11913 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
11915 Add new property WrapNonExceptionThrows to handle 2.0 assembly
11917 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
11920 * driver.cs: Reflect method name change.
11922 * statement.cs (Try.Resolve): Warn when try has both general
11923 exception handlers.
11925 * typemanager.cs: runtime_compatibility_attr_type new predefined
11928 2005-10-26 Raja R Harinath <harinath@gmail.com>
11931 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
11932 treat it as an empty parameter list.
11934 2005-10-26 Raja R Harinath <rharinath@novell.com>
11937 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
11938 ResolveAsTypeStep silent.
11939 * statement.cs (Block.AddConstant): Mark block as used.
11940 (Block.ResolveMeta): Avoid piling on error messages
11941 if a constant initializer resolution fails.
11943 2005-10-25 Raja R Harinath <rharinath@novell.com>
11945 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
11947 (NamespaceEntry.VerifyAllUsing): New.
11948 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
11949 behaviour. Delegates actual resolution of alias to ...
11950 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
11951 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
11953 * driver.cs (Driver.MainDriver): Update.
11955 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
11956 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
11958 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
11960 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
11961 RootNamespace.DefineNamespacesForAll.
11963 2005-10-24 Raja R Harinath <harinath@gmail.com>
11965 * typemanager.cs (assemblies, external_aliases, modules)
11966 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
11967 (ComputeNamespaces, GetRootNamespace): Remove extra staging
11968 overhead. Move resposibility ...
11969 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
11970 * driver.cs, attribute.cs, codegen.cs: Update to changes.
11972 2005-10-23 Raja R Harinath <harinath@gmail.com>
11974 * namespace.cs (RootNamespace.all_namespaces): Renamed from
11975 cached_namespaces. Improve usage.
11976 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
11977 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
11978 Move from GlobalRootNamespace and simplify.
11979 (RootNamespace.Global): Make instance variable.
11980 (RootNamespace.RootNamespace): Add "alias name" parameter.
11981 (GlobalRootNamespace): Simplify drastically.
11982 (Namespace.Lookup): Don't use GetNamespace.
11983 * typemanager.cs (GetRootNamespace): Rename from
11984 ComputeNamespaceForAlias.
11985 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
11987 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11989 * anonymous.cs (AnonymousContainer): Don't crash when container
11992 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11994 * expression.cs (Binary.DoResolve): Warn when comparing same
11997 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12000 * expression.cs (Binary.DoResolve): It looks like there are no
12001 convetsion rules in enum context.
12003 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12005 Add support for extern alias qualifiers.
12006 * typemanager.cs: Move some LookupTypeReflection code
12007 to namespace.cs, to have cleaner code. Added some methods
12008 to help us keep track of the extern aliased references.
12009 * driver.cs: Add suport for extern alias assemblies on command
12010 line and check for their warnings/errors. Also keep track of the
12011 extern aliased assemblies.
12012 * namespace.cs: Move the global functionality of Namespace
12013 to GlobalRootNamespace/RootNamespace. Now the global namespace
12014 is GlobalRootNamespace.Globa. Also the code moved from
12015 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12016 Finally added LocalAliasEntry (AliasEntry before) and
12017 ExternAliasEntry, to handle alias statements.
12018 * cs-parser.jay: Add support in the grammar for extern alias
12020 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12021 Update callings to Namespace (now in GlobalRootNamespace).
12023 2005-10-18 Raja R Harinath <rharinath@novell.com>
12026 * class.cs (TypeContainer.DefineType): Move updating of
12027 topological sort earlier in the code.
12028 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12030 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12033 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12035 * constant.cs (Constant.TryReduce): Moved from Cast class.
12036 (Reduce): Made little bit more OO and fixed missing conversions.
12038 * ecore.cs (Reduce): Implemented.
12039 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12041 * literal.cs (Reduce): Implemented.
12043 * class.cs: Reverted Miguel's wrong commit.
12045 2005-10-14 Miguel de Icaza <miguel@novell.com>
12047 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12049 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12051 * cs-parser.jay, expression.cs : CS0214 was missing error location
12052 for constants. Fixed bug #76404.
12054 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12057 * convert.cs (ExplicitConversionCore): Fixed object->enum
12060 2005-10-10 Raja R Harinath <rharinath@novell.com>
12062 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12063 InstanceExpression.
12064 (PropertyExpr.EmitCall): Likewise.
12065 * expression.cs (Invocation.EmitArguments): Handle case where
12067 (Invocation.EmitCall): Avoid allocating temporary variable if
12068 there are no arguments.
12070 2005-10-07 Raja R Harinath <rharinath@novell.com>
12073 * convert.cs (ImplicitConversionStandard): Move conversion of
12074 void* to arbitrary pointer types ...
12075 (ExplicitConversionStandard): .. here.
12076 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12077 error to always print typenames.
12079 2005-10-07 Raja R Harinath <rharinath@novell.com>
12081 * convert.cs (GetConversionOperator): Rename from
12082 GetConversionOperators. Move operator selection code from ...
12083 (UserDefinedConversion): ... here.
12085 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12087 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12090 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12092 * assign.cs (Assign.DoResolve): Error method changed.
12094 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12096 * const.cs (ResolveValue): Reset in_transit immediately.
12098 * constant.cs: Error method changed.
12100 * convert.cs: Removed useless location parameter.
12101 (ExplicitNumericConversion): Don't do double enum check.
12102 (ExplicitConversionCore): Renamed from ExplicitConversion.
12103 (ExplicitUnsafe): Extracted from ExplicitConversion.
12104 (ExplicitConversion): Uses for error reporting.
12106 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12108 (ResolveBoolean): Uses common error method.
12109 (CastToDecimal): Get rid of ec.
12110 (CastFromDecimal): Optimized.
12111 (ConvCast): Get rid of ec.
12113 * enum.cs (ResolveValue): Reset in_transit immediately.
12114 (Emit): Return after first error.
12116 * expression.cs: Convert changes.
12118 * literal.cs: Error method changed.
12120 * statement.cs: Error method changed.
12122 2005-10-03 Raja R Harinath <rharinath@novell.com>
12124 * support.cs (SeekableStreamReader.Position): Don't error out when
12125 the requested position is just beyond the end of the current
12128 2005-09-28 Raja R Harinath <rharinath@novell.com>
12130 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12131 try to keep in sync with the byte count of the underlying Stream.
12132 However, this limits us to a window size of 2048 characters: i.e.,
12133 the maximum lookahead of our lexer/parser can be 2048 characters.
12135 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12138 * driver.cs: Fix compilation files with full root path.
12140 2005-09-25 Miguel de Icaza <miguel@novell.com>
12142 * report.cs (SymbolRelatedToPreviousError): Format the output so
12143 it does not use an open parenthesis that is never closed.
12145 * driver.cs: Follow coding guidelines
12147 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12150 * const.cs (Const.ResolveValue): Check for assigning non-null
12151 value to reference type.
12153 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12155 * anonymous.cs: Implemented ExprClassName.
12157 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12160 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12163 * class.cs (StaticClass.DefineContainerMembers): Report protected
12166 * codegen.cs: if(ed) PRODUCTION.
12168 * convert.cs (Error_CannotImplicitConversion): Better error
12171 * cs-parser.jay: More error checks.
12173 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12175 * driver.cs (CSCParseOption): Enabled wrong option check.
12177 * ecore.cs (Expression.ExprClassName): Turned to property.
12178 (MemberExpr.CheckIntermediateModification): For checking boxed
12179 value types modification.
12181 * statement.cs (Fixed.Resolve): Expression type must be
12182 convertible to fixed type.
12183 (CollectionForeach.GetEnumeratorFilter,TryType):
12184 Small refactoring for easier error checking.
12186 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12188 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12191 * class.cs (GeneratedBaseInitializer): New class for customization
12192 compiler generated initializers.
12193 (MemberBase.DoDefine): Check Obsolete attribute here.
12194 (FieldMember.DoDefine): Ditto.
12196 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12199 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12200 (MemberCore.GetObsoleteAttribute): Removed argument.
12201 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12202 (MemberCore.CheckObsoleteType): New helper.
12206 * statement.cs: Updates after MemberCore changes.
12208 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12209 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12211 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12212 obsolete attribute for compiler construct.
12213 (As.DoResolve): Cache result.
12215 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12217 2005-09-26 Raja R Harinath <rharinath@novell.com>
12220 * expression.cs (This.VerifyFixed): In a value type T, the type of
12221 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12222 value type R, 'this' is treated as a value parameter.
12224 2005-09-22 Miguel de Icaza <miguel@novell.com>
12226 * statement.cs (Lock): Use the TemporaryVariable class instead of
12227 manually using local variables as those do not work when variables
12230 * ecore.cs: Moved the TemporaryVariable class from being a nested
12231 class inside Foreach to be a public class that can be employed in
12234 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12236 * cs-parser.jay: interface_accessors replaced by
12237 accessor_declarations.
12239 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12242 * statement.cs (GotoCase.Resolve): Convert null constant to
12244 (SwitchLabel.ResolveAndReduce): Ditto.
12245 (SwitchLabel.NullStringCase): Custom null stamp.
12246 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12248 typemanager.cs (CSharpSignature): Don't skip first argument
12251 2005-09-18 Miguel de Icaza <miguel@novell.com>
12253 * driver.cs: Set InEmacs based on the environment variable EMACS.
12255 * location.cs (InEmacs): in this mode, do not report column
12256 location as it confuses Emacs.
12258 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12260 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12261 expression.cs, iterators.cs, literal.cs: Store constants and
12264 * class.cs (MemberBase.ShortName): Pass location.
12266 * cs-parser.jay: Some location fixes.
12268 * ecore.cs (Expression.Location): Made virtual.
12270 2005-09-05 Miguel de Icaza <miguel@novell.com>
12272 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12273 if the underlying types are the same, otherwise we need to produce
12274 code that will do the proper cast.
12276 This was exposed by Marek's constant rewrite which produced
12277 invalid code for the call site:
12279 enum X : long { a }
12280 void Method (X v) {}
12284 This fixes test-49.cs
12286 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12288 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12289 Type/Object should be allowed as well. Fixed bug #75968.
12291 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12293 * expression.cs : (Binary.DoResolve): when one is enum constant and
12294 another is constant 0, then return enum one *as enum type*.
12297 2005-09-02 Raja R Harinath <rharinath@novell.com>
12299 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12303 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12304 flow-branching for LocalVariableReferences in case we were invoked
12305 from a MemberAccess.
12306 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12308 (LocalVariableReference.DoResolveBase): ... this.
12309 (MemberAccess.Resolve): Do the check that was disabled during
12312 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12315 (PartialContainer.Create): check abstract/sealed/static strictly
12316 but abstract/sealed can exist only at one side. Fixed bug #75883.
12318 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12321 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12322 specified, don't default to UnmanagedType.I4.
12324 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12326 * expression.cs : conditional operator should check possibly
12327 incorrect assign expression. Fixed bug #75946.
12329 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12331 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12332 Reverting the change. gmcs is much complex than mcs on this matter.
12334 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12336 * cs-tokenizer.cs : To read another token ahead of the actual
12337 consumption, use new SavedToken and cache token instead of moving
12338 back the stream with SeekableStreamReader (it seemed problematic).
12340 driver.cs : Thus use StreamReader directly.
12341 * support.cs : Thus removed SeekableStreamReader.
12343 2005-08-30 Raja R Harinath <rharinath@novell.com>
12346 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12347 (ScopeInfo.EmitScopeType): Use it to construct field names from
12348 names of captured locals.
12351 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12352 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12353 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12354 (ExplicitConversion): Remove enum cases already handled by
12355 implicit conversion. Move implicit conversion check to the beginning.
12356 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12357 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12358 Don't treat System.Enum as a struct.
12360 2005-08-30 Jb Evain <jbevain@gmail.com>
12362 * attribute.cs: handles as expression in parameters.
12364 2005-08-30 Raja R Harinath <rharinath@novell.com>
12367 * class.cs (TypeContainer.VerifyClsName): Don't use a
12368 PartialContainer when verifying CLS compliance.
12369 (AbstractPropertyEventMethod): Set Parent here, ...
12370 (PropertyMethod): ... not here.
12372 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12374 * attribute.cs : escaped attribute name should not be allowed to be
12375 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12377 2005-08-29 Raja R Harinath <rharinath@novell.com>
12380 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12381 when converting a long constant to unsigned long.
12382 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12383 detect where IsApplicable and VerifyArgumentsCompat disagree.
12385 2005-08-29 Raja R Harinath <rharinath@novell.com>
12386 and Carlos Alberto Cortez <carlos@unixmexico.org>
12389 * class.cs (TypeContainer.CanElideInitializer): New helper.
12390 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12391 can safely emitting the initializer of a field.
12393 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12395 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12396 allowed inside a switch (without loop). Fixed bug #75433.
12398 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12400 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12401 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12403 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12405 * driver.cs : kinda reverting the default encoding changes (not exact
12406 revert since I noticed that "codepage:reset" might not work fine).
12408 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12410 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12411 Location. Now getter and setter store location correctly.
12412 (errors/cs0111-12.cs now reports the expected location.)
12414 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12416 * driver.cs : Use default encoding on the environment.
12417 Removed (now that) extra parameter for SeekableStreamReader.
12418 * support.cs : (SeekableStreamReader) third .ctor() argument for
12419 StreamReader is not required (always true). preamble size could
12420 be acquired in simpler and safe way.
12422 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12424 * cs-parser.jay: report CS0642 at warning level 3
12425 and report CS0642 for an if else statement also
12426 fixes bug #74745. Patch by John Luke (and a bit
12428 Removed extra CS0642 warning check for "while",
12430 * statement.cs: In Block.Resolve(), CS0642 check
12431 is reimplemented to check a sequence of an empty
12432 statement and a block.
12434 Both fix bug #66777.
12436 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12438 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12439 detection until I fix it.
12441 * cs-tokenizer.cs: Changed error message.
12443 * cs-parser.jay: Fixed 2 error locations.
12445 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12446 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12449 * enum.cs (GetSignatureForError): Fixed.
12451 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12455 * typemanager.cs (RegisterProperty): Removed.
12457 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12459 2005-08-24 Raja R Harinath <rharinath@novell.com>
12462 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12463 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12465 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12467 * expression.cs : tiny fix is required for not warning positive ulong.
12470 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12472 * expression.cs : add CS0652 check for constant and integral
12473 expression. Fixed bug #53974.
12475 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12477 * expression.cs : in DoNumericPromotions(), check if there is implicit
12478 conversion overload for string (to check CS0034). Fixed bug #52492.
12480 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12482 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12484 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12486 * ecore.cs : report location when it is *not* Null.
12488 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12494 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12495 correctly. Fixed bug #75721.
12497 2005-08-23 Raja R Harinath <rharinath@novell.com>
12499 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12500 loop that performs 'min (pos, char_count)'.
12503 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12504 converted value in Operator.OnesComplement.
12506 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12508 * anonymous.cs: If the anon method is pulled into a helper class,
12509 it needs to be `internal' not `private'. Fixes runtime behavior on
12512 2005-08-20 Martin Baulig <martin@ximian.com>
12514 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12515 scope if we don't already have it.
12517 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12518 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12521 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12524 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12525 is a partial class.
12527 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12529 The big constants rewrite
12530 Fix #75746, #75685 and more
12531 As a side effect saved 1MB for MWF ;-)
12533 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12534 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12535 enum based for corlib compilation.
12537 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12540 * class.cs (FixedField.Define): Use ResolveAsConstant.
12542 * const.cs (IConstant): Interface constants and enums.
12543 (Const.ResolveValue): New method for constant resolvning.
12544 (ExternalConstant): Constants from imported assemblies.
12546 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12547 conversion; like enums.
12548 (Constant.ToType): Converts this constant to different type.
12549 (Constant.Increment): Adds 1.
12551 * convert.cs (ImplicitConversionRequired): Simplified.
12553 * cs-parser.jay: Create EnumMember directly.
12555 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12557 * doc.cs (GenerateEnumDocComment): Removed.
12559 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12560 (ConvertIntLiteral): Removed.
12561 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12563 * enum.cs (EnumMember): Implement IConstant.
12564 (Enum.IsValidEnumConstant): Removed.
12565 (Enum.GetNextDefaultValue): Removed.
12566 (Enum.FindMembers): Updated.
12567 (Enum.GenerateDocComment): Iterate enum members.
12569 * expression.cs (Cast.TryReduce): Handle enums correctly.
12570 (New.Constantify): Made public.
12571 (MemberAccess.DoResolve): Removed contant specific if(s).
12573 * literal.cs (NullLiteral): Implement new abstract methods.
12575 * statement.cs (GotoCase.Resolve): Use new constant methods.
12576 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12578 * typemanager.cs (LookupEnum): Removed.
12579 (IsEnumType): Fixed to work with corlib.
12580 (RegisterConstant): Removed.
12581 (LookupConstant): Removed.
12582 (GetConstant): Changed to work with IConstant.
12584 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12586 * location.cs : Fixed overflown (>255) column number.
12588 2005-08-03 Raja R Harinath <rharinath@novell.com>
12590 First cut of the qualified-alias-member feature.
12591 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12593 * cs-parser.jay (DOUBLE_COLON): New token.
12594 (namespace_or_type_name): Add rule for recognizing
12595 qualified-alias-members.
12596 (primary_expression): Likewise.
12597 (element_access): Allow QualifiedAliasMember as a possible
12598 type-bearing expression.
12599 (local_variable_type, local_variable_pointer_type): Likewise.
12600 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12601 aliases in the current and enclosing namespace declarations.
12602 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12603 * decl.cs (MemberName.is_double_colon): New.
12604 (MemberName.MemberName): Add new constructor for alias-member.
12605 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12606 * expression.cs (QualifiedAliasMember): New expression type.
12608 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12610 * location.cs : it borked when no argument was specified.
12612 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12614 * location.cs : tiny ToString() format fix.
12616 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12618 * statement.cs : oops, it was missing.
12620 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12622 A set of fixes for precise line/column location.
12625 "token" field now holds a file/line "delta", a line number offset
12626 from the segment, and a column number. See also:
12627 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12628 December/009508.html
12629 Removed static IsNull. Use instance IsNull property instead.
12630 * cs-tokenizer.cs :
12631 For some tokens it stores Location. For Identifier it stores
12632 LocatedToken which is a pair of string name and location.
12633 Column numbers are adjusted only at getChar().
12635 Use Location.ToString() for reporting (it now contains column).
12637 Largely modified to use LocatedToken instead of
12638 string (IDENTIFIER), and to acquire Location from some tokens.
12639 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12640 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12642 Now MemberName holds Location. DeclSpace.ctor() receives Location
12643 as a parameter. Removed extra parameters to all derived classes.
12644 Replaced Location.IsNull() with instance property.
12645 * assign.cs, expression.cs :
12646 Added .ctor() overload that omits Location.
12648 Added "nameEscaped" flag that indicates the identifier was escaped
12649 in the source file. This fixes bug #57047.
12651 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12653 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12654 New method, looking for lo-case imported cls type.
12656 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12659 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12661 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12663 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12664 all_imported_types.
12665 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12667 Optimized to save 3.5 MB for SWF compilation.
12669 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12671 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12672 (PartialContainer.Create): Moved logic AddToContainer.
12673 (PartialContainer.MarkForDuplicationCheck): Shares name.
12675 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12678 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12680 (Namespace.GetSignatureForError): New method.
12682 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12683 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12685 2005-08-01 Raja R Harinath <rharinath@novell.com>
12688 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12689 member lookup rather than qualifier_type, since qualifier_type can
12692 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12694 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12697 2005-07-31 Miguel de Icaza <miguel@novell.com>
12699 * statement.cs: Copy the local exception into the exception
12700 captured local. Fixes 75674
12702 2005-07-31 Raja R Harinath <harinath@gmail.com>
12705 * expression.cs (Invocation.OverloadResolve): Don't report error
12706 CS1501 if error CS1502 has been reported.
12707 (New.DoResolve): Delegate CS1501 reporting to
12708 Invocation.OverloadResolve.
12711 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12712 invariant-meaning-in-block property in an enclosing block if
12715 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12717 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12718 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12719 (Switch.CheckSwitch): Just save 50kb for SWF.
12721 2005-07-27 Martin Baulig <martin@ximian.com>
12723 * anonymous.cs (CaptureContext.AddField): Added
12724 `AnonymousContainer am' argument; compute its toplevel scope if
12725 it's not already computed. Fixes #75649.
12727 2005-07-26 Raja R Harinath <rharinath@novell.com>
12730 * class.cs (Constructor.Emit): Reset block to null if the block
12733 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12735 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12737 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12739 * class.cs (MethodData.Define): Check whether accessor implementing
12740 interface is public.
12742 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12744 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12747 * namespace.cs (LookupType): Moved same type check to...
12749 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12750 with the same name.
12752 2005-07-21 Raja R Harinath <rharinath@novell.com>
12754 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12755 already found a typebuilder.
12756 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12757 MemberNames, not strings.
12759 * const.cs (Error_ExpressionMustBeConst):
12760 Rename from Error_EpressionMustBeConst.
12761 * const.cs, class.cs, statement.cd: Update.
12763 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12767 * const.cs (Const.LookupConstantValue): Report missing contant expression
12769 (Error_EpressionMustBeConstant): Only one error method.
12771 * class.cs, statement.c: Updated.
12773 2005-07-20 Raja R Harinath <rharinath@novell.com>
12775 * statement.cs (Block.Flags): Add back HasVarargs.
12776 (Block.flags): Make protected.
12777 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12779 * typemanager.cs (types, typecontainers, user_types): Remove.
12780 (UserTypes, TypeContainers): Likewise.
12781 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12782 (CleanUp, Reset): Update.
12783 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12784 (GetNestedType): Use Type.GetNestedType.
12785 (CoreLookupType): Take two arguments, the namespace and the
12786 basename of the type. Update to use the Namespace.Lookup
12788 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12789 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12790 string concatenation and substring matches.
12791 * class.cs, enum.cs, delegate.cs: Update to changes.
12793 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12795 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12796 Expression and made virtual.
12798 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12799 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12801 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12803 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12806 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12809 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12812 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12813 AssemblyCultureAttribute is not used on executable.
12816 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12818 2005-07-16 Raja R Harinath <rharinath@novell.com>
12821 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12822 New. Reports CS0252/CS0253.
12823 Mostly taken from preliminary patch by Duncak Mak.
12824 (Binary.DoResolveOperator): Store results of operator lookup.
12825 Use them to detect if we need to warn about unintended reference
12828 2005-07-15 Raja R Harinath <rharinath@novell.com>
12831 * namespace.cs (Namespace.Lookup): Add back location parameter.
12832 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12833 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12835 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12836 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12837 (Namespace.LookupType): ... this.
12838 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12840 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12841 purported to handle pointers.
12842 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12845 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12847 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12850 2005-07-15 Raja R Harinath <rharinath@novell.com>
12852 * namespace.cs (Namespace.Lookup): Drop location parameter.
12853 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12854 (NamespaceEntry.Lookup): ... this.
12855 (NamespaceEntry.Error_AmbiguousTypeReference):
12856 Move here from DeclSpace.
12857 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12859 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12860 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12861 Move to NamespaceEntry.
12862 * delegate.cs, expression.cs: Update to changes.
12864 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12866 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12867 CheckAttributeType and refactored.
12868 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12869 ResolveAsTypeTerminal error handling.
12870 (ResolveAsTypeTerminal): Introduced because of global attributes extra
12872 (GetSignatureForError): Print errors in same way.
12875 * codegen.cs: Reflect attribute GetSignatureForError change.
12878 * expression.cs: Add silent parameter to ResolveAsTypeStep.
12880 * namespace.cs (UsingEntry): Refactored to make fields private.
12883 statement.cs: Error_UnexpectedKind has extra parameter.
12885 2005-07-14 Raja R Harinath <rharinath@novell.com>
12887 * ecore.cs (IAlias): Remove.
12888 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
12889 that implement the interface.
12890 * namespace.cs (Namespace): Likewise.
12891 (Namespace.declspaces): Renamed from 'defined_names'.
12892 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
12893 DeclSpace instead of an IAlias.
12894 * tree.cs (Tree.AddDecl): Update.
12896 2005-07-12 Raja R Harinath <rharinath@novell.com>
12898 * statement.cs (Block.Flags); Remove HasVarargs.
12899 (Block.HasVarargs): Move to ToplevelBlock.
12900 (Block.ThisVariable, Block.AddThisVariable): Likewise.
12901 (Block.Variables): Make protected. Initialize variable hashtable
12903 (Block.AddVariable): Update.
12904 (Block.Resolve): Update to changes.
12905 (ToplevelBlock.HasVarargs): New boolean.
12906 (ToplevelBlock.ThisVariable): Move here from Block.
12907 (ToplevelBlock.AddThisVariable): Likewise.
12908 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
12909 * expression.cs (This.ResolveBase): Update to changes.
12910 (ArglistAccess.DoResolve): Likewise.
12912 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12915 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
12917 * class.cs (TypeContainer.VerifyMembers): Distinguish between
12918 not used and not used & assigned.
12919 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
12921 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12924 * expression.cs (Is.DoResolve): null is never provided type.
12926 2005-07-08 Marek Safar <marek.safar@seznam.cz>
12929 * cs-parser.jay: Less strict event error rule to catch more errors.
12931 2005-07-08 Martin Baulig <martin@ximian.com>
12933 Fix test-iter-10.cs - distinguish whether we `yield' in a property
12934 gettter (allowed) or setter (not allowed).
12936 * class.cs (Accessor): Implement IIteratorContainer.
12937 (Accessor.Yields): New public field.
12938 (PropertyBase.PropertyMethod.Define): Handle iterators on a
12939 per-accessor basis.
12942 (get_accessor_declaration, set_accessor_declaration): Set the
12943 `yields' flag on the accessor, not the property.
12944 (property_declaration): Do the iterators check on a per-accessor
12945 basis and not for the whole property.
12947 2005-07-08 Martin Baulig <martin@ximian.com>
12949 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
12950 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
12952 2005-07-07 Marek Safar <marek.safar@seznam.cz>
12955 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
12956 (ExtractSecurityPermissionSet): Cope with self referencing security
12957 attributes properly.
12959 * driver.cs (SetOutputFile): Made public property OutputFile.
12961 2005-07-07 Raja R Harinath <rharinath@novell.com>
12964 * class.cs (TypeContainer.first_nonstatic_field): Rename from
12965 has_nonstatic_fields. Make into a FieldBase pointer.
12966 (TypeContainer.AddField): Add CS0282 check.
12967 (TypeContainer.EmitType): Update.
12969 2005-07-06 Miguel de Icaza <miguel@novell.com>
12971 * cs-tokenizer.cs (consume_identifier): Do not create strings to
12972 compare if they start with __.
12974 2005-07-06 Raja R Harinath <rharinath@novell.com>
12976 * statement.cs (Switch.SwitchGoverningType): Only look at
12977 UserCasts that don't need implicit standard conversions to one of
12978 the allowed switch types (Fixes test-322.cs).
12979 (LocalInfo.Resolve): Re-enable sanity-test.
12981 2005-07-06 Marek Safar <marek.safar@seznam.cz>
12983 * cs-tokenizer.cs (consume_identifier): Detect double undescores
12985 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
12987 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
12989 2005-07-06 Raja R Harinath <rharinath@novell.com>
12992 * ecore.cs (SimpleName.GetSignatureForError): Add.
12993 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
12994 (MemberAccess.GetSignatureForError): Add.
12996 2005-07-05 Marek Safar <marek.safar@seznam.cz>
12998 The big error and warning messages review.
13028 * typemanager.cs: Updated.
13030 * class.cs: (MethodCore.SetYields): Moved here to share.
13031 (PropertyMethod.Define): Moved iterator setup here.
13033 * iterators.cs: Add orig_method to have full access to parent
13036 2005-07-05 Raja R Harinath <rharinath@novell.com>
13038 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13039 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13040 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13041 variable of struct type.
13042 * expression.cs (Unary.ResolveOperator): Update to change.
13043 (Indirection.VerifyFixed): Likewise.
13044 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13045 (ParameterReference.VerifyFixed): Value parameters are fixed.
13046 (This.VerifyFixed): Treat 'this' as a value parameter.
13047 * statement.cs (LocalInfo.IsFixed): Remove.
13049 2005-07-01 Martin Baulig <martin@ximian.com>
13051 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13052 `ec.EmitThis ()' to get the correct scope.
13054 2005-07-01 Martin Baulig <martin@ximian.com>
13056 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13057 instance is a ParameterReference; fixes #75299.
13059 2005-07-01 Martin Baulig <martin@ximian.com>
13061 Reverted Marek's latest patch (r46725):
13062 - it contains structural changes which are neither mentioned in
13063 the ChangeLog nor explained anywhere; for example the additional
13064 argument of EmitContext's and Iterator's .ctor's and the
13065 TypeContainer.DefineMembers() change.
13066 - structural changes like this should go in in seperate patches
13067 and not be hidden in a huge patch which just seems to affect
13068 warnings and errors.
13069 a big and hard to understand patch.
13070 - it breaks iterators and causes regressions, for instance in
13073 2005-06-30 Raja R Harinath <rharinath@novell.com>
13076 * expression.cs (Indexers.map): Remove.
13077 (Indexers.Append): Filter out inaccessible setters and getters.
13078 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13081 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13082 Refactored from ...
13083 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13084 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13085 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13086 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13088 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13091 * class.cs (FieldBase.GetInitializerExpression): One more field
13094 2005-06-28 Miguel de Icaza <miguel@novell.com>
13096 * pending.cs: Do not define a proxy if the base method is virtual,
13097 it will be picked up by the runtime (bug 75270).
13099 2005-06-08 Martin Baulig <martin@ximian.com>
13101 The big Iterators rewrite :-)
13103 * iterators.cs: Rewrite this to use the anonymous methods framework.
13105 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13106 before the TypeContainers; see 2test-21.cs.
13109 (TypeContainer.DefineType): Don't create a new EmitContext if we
13110 already have one (this only happens if we're an Iterator).
13111 (TypeContainer.Define): Also call Define() on all our iterators.
13112 (Method.CreateEmitContext): Added support for iterators.
13115 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13116 (AnonymousContainer.CreateMethodHost): Moved here from
13117 AnonymousMethod and made abstract.
13118 (AnonymousContainer.CreateScopeType): New abstract method.
13119 (AnonymousContainer.IsIterator): New public property.
13120 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13121 get the ScopeTypeBuilder rather than manually defining it here.
13122 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13125 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13126 before RootContext.DefineTypes().
13128 * codegen.cs (EmitContext.RemapToProxy): Removed.
13129 (EmitContext.CurrentAnonymousMethod): Changed type from
13130 AnonymousMethod -> AnonymousContainer.
13131 (EmitContext.ResolveTopBlock): Protect from being called twice.
13132 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13133 (EmitContext.EmitThis): Removed the iterators hacks; use the
13134 anonymous methods framework for that.
13137 (ToplevelBlock.Container): Make this a property, not a field.
13138 (ToplevelBlock.ReParent): New public method; move the
13139 ToplevelBlock into a new container.
13140 (Foreach.TemporaryVariable): Simplify.
13142 2005-06-05 Martin Baulig <martin@ximian.com>
13144 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13145 (Block.AddTemporaryVariable): New public method; creates a new
13146 `LocalInfo' for a temporary variable.
13147 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13149 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13150 non-iterator variables.
13152 2005-06-05 Martin Baulig <martin@ximian.com>
13154 * statement.cs (Foreach.TemporaryVariable): Create the
13155 LocalBuilder in the Emit phase and not in Resolve since in some
13156 situations, we don't have an ILGenerator during Resolve; see
13157 2test-19.cs for an example.
13159 2005-06-04 Martin Baulig <martin@ximian.com>
13161 **** Merged r45395 from GCS ****
13163 The big Foreach rewrite - Part II.
13165 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13166 with `PropertyInfo ienumerator_getcurrent'.
13168 * codegen.cs (VariableStorage): Removed.
13171 (Foreach): Derive from Statement, not ExceptionStatement.
13172 (Foreach.CollectionForeach): New nested class. Moved all the code
13173 dealing with collection foreach here.
13174 (Foreach.ForeachHelperMethods): Removed.
13175 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13177 2005-05-23 Martin Baulig <martin@ximian.com>
13179 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13180 don't need to. Fix #75014.
13182 2005-05-20 Martin Baulig <martin@ximian.com>
13184 Merged r44808 from GMCS.
13186 * class.cs (TypeContainer.CircularDepException): Removed.
13187 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13188 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13189 (CS0146) and interface (CS0529) dependencies here.
13191 2005-06-21 Raja R Harinath <rharinath@novell.com>
13193 * expression.cs (Invocation.EmitCall): Fix initialization
13194 'this_call' to reflect current behaviour. Fix indentation.
13196 * convert.cs (FindMostEncompassedType): Add two trivial special
13197 cases (number_of_types == 0 || number_of_types == 1).
13198 (FindMostEncompasingType): Likewise.
13200 2005-06-17 Raja R Harinath <rharinath@novell.com>
13202 Some cleanups preparing for the fix of #75283.
13203 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13205 (EventExpr.InstanceResolve): Likewise.
13206 (EventExpr.DoResolve): Remove redundant checks.
13208 2005-06-10 Duncan Mak <duncan@novell.com>
13210 * cs-tokenizer.cs (process_directives): New flag for controlling
13211 the processing of preprocessor directives.
13212 (x_token): After seeing a '#', return Token.NONE instead of going
13213 to handle_preprocessing_directive() when not processing
13214 directives. This avoids unnecessary processing during the token peek in
13219 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13220 the existing error reporting methods instead of Report.Error.
13222 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13223 after Raja's rewrite.
13225 2005-06-08 Miguel de Icaza <miguel@novell.com>
13227 * class.cs: Small fix.
13229 2005-06-08 Raja R Harinath <rharinath@novell.com>
13232 * class.cs (GetPartialBases): Fix return value check of
13233 part.GetClassBases.
13235 2005-06-07 Raja R Harinath <rharinath@novell.com>
13237 Ensure that partial classes are registered in their enclosing
13238 namespace. Initial part of fix of #75160.
13239 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13240 Register declspace with namespace here, not in
13241 DeclSpace.RecordDecl.
13242 * cs-parser.jay: Pass namespace to RecordDecl.
13243 * class.cs (PartialContainer.Create): Likewise.
13244 (ClassPart.DefineType): New sanity-check. Throws an exception if
13246 * decl.cs (Declspace.RecordDecl): Remove.
13247 * namespace.cs (NamespaceEntry.DefineName): Remove.
13249 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13251 * rootcontext.cs: Reset TargetExt as well.
13253 2005-06-03 Raja R Harinath <rharinath@novell.com>
13255 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13256 -langversion:ISO-1.
13258 2005-06-02 Raja R Harinath <rharinath@novell.com>
13260 Fix #75080, cs0119.cs.
13261 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13263 (Expression.Resolve): ... this. Use it. Remove bogus code
13264 allowing ExprClass.Type and ExprClass.Namespace for
13265 ResolveFlags.VariableOrValue.
13266 (Expression.Resolve) [1-argument variant]: Change default resolve
13267 flags based on language version.
13268 (Expression.Error_UnexpectedKind): Use a simple string array
13269 rather than an ArrayList.
13270 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13271 not ExprClass.Type.
13272 (TypeOfVoid.DoResolve): Likewise.
13273 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13274 flags argument -- it always has the same value.
13276 2005-05-31 Raja R Harinath <rharinath@novell.com>
13279 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13280 Use it in the error message.
13281 * assign.cs, expression.cs, statement.cs: Update.
13283 2005-05-30 Raja R Harinath <rharinath@novell.com>
13286 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13287 the "almostMatchedMember" case too.
13288 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13289 that failed the accessibility checks to 'almost_match'.
13291 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13293 * attribute.cs: Use internal MethodBuilder methods to set
13294 ExactSpelling and SetLastError on PInvoke methods, instead
13295 of passing them via charset. Fixes #75060.
13297 2005-05-27 Raja R Harinath <rharinath@novell.com>
13299 * parameter.cs (Parameter): Remove TODO comment.
13300 (Parameter.DefineParameter): Remove Location parameter.
13301 (Parameters.LabelParameters): Likewise.
13302 * class.cs (Constructor.Emit): Update to change.
13303 (MethodData.Emit): Likewise.
13304 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13305 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13307 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13310 Removed Parameters.Location and added Parameter.Location instead.
13311 Removed Location parameter from Emit() and GetSignature().
13318 Modified all related calls.
13320 2005-05-26 Raja R Harinath <rharinath@novell.com>
13322 Improve user-defined conversion handling.
13323 * convert.cs (GetConversionOperators): Rewrite. Return only the
13324 applicable operators.
13325 (AddConversionOperators): New. Helper for GetConversionOperators.
13326 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13327 there is only one most encompassed/encompassing type.
13328 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13329 "applicable operator" handling.
13330 (UserConversion): Move cache here from GetConversionOperators.
13331 Directly cache the chosen operator, rather than the whole
13333 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13334 case. Allow conversion of decimal to sbyte and byte too.
13335 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13336 New static methods. Used to avoid allocating EmptyExpressions in
13339 2005-05-24 Duncan Mak <duncan@novell.com>
13341 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13342 another class, used in Convert.ExplicitNumericConversion.
13343 (CastToDecimal): New class, similar to above, but casts to
13344 System.Decimal, used in Convert.ImplicitNumericConversion and also
13345 in explicit convesion from double/float to decimal.
13347 * convert.cs (ImplicitNumericConversion): Handle implicit
13348 conversions to System.Decimal.
13349 (ExplicitNumericConversion): handle explicit conversions to
13354 2005-05-20 Miguel de Icaza <miguel@novell.com>
13356 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13357 know the type at this stage, just break through. Fixes #75008
13359 2005-05-19 Martin Baulig <martin@ximian.com>
13362 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13363 to disable error reporting.
13365 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13366 here since we don't want to report an error; see the new test-336.cs.
13368 2005-05-19 Raja R Harinath <rharinath@novell.com>
13370 * statement.cs (ToplevelBlock.GetParameterReference)
13371 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13372 Move here from class Block.
13373 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13374 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13376 2005-05-18 Martin Baulig <martin@ximian.com>
13381 (FlowBranching.Reachability): Add non-static public And() and Or()
13383 (FlowBranchingSwitch): New class; do the `break_origins' thing
13384 like in FlowBranchingLoop.
13385 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13386 reachability, not just locals and parameters.
13387 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13388 switch; MergeBreakOrigins() now takes care of that.
13390 2005-05-18 Martin Baulig <martin@ximian.com>
13392 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13393 a loop and may leave it, reset the barrier; fixes #74974.
13395 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13397 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13400 * cs-parser.jay: Catch more lexical errors.
13402 * report.cs: Add one more Error method.
13405 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13407 2005-05-17 Martin Baulig <martin@ximian.com>
13409 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13412 2005-05-16 Raja R Harinath <rharinath@novell.com>
13414 Fix test-382.cs. Emit values of decimal constants.
13415 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13417 (TypeContainer.AddField): ... this.
13418 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13419 with initializers to include 'Const's.
13420 (ClassPart.RegisterFieldForInitialization): Forward to
13422 * const.cs (Const.Const): Pass initializer to base class.
13423 (Const.Define): In case of decimal constants, register them for
13424 initialization in a static constructor.
13426 2005-05-14 Martin Baulig <martin@ximian.com>
13428 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13429 do not call ResolveUnreachable() on unreachable statements in
13430 here, see the comment in the source code.
13432 2005-05-13 Raja R Harinath <rharinath@novell.com>
13435 * expression.cs (BinaryResolveOperator): If one of the operands of
13436 an equality comparison is 'null' and the other is a pointer type,
13437 convert the null to a NullPointer.
13438 * convert.cs (ImplicitReferenceConversion): If the expression is a
13439 NullLiteral and the target type is a pointer type, return a
13440 NullPointer instead.
13441 (ImplicitConversionStandard): Likewise.
13443 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13445 * cs-parser.jay: Set readonly context based on special constructs.
13447 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13448 readonly variable error handling.
13450 * rootcontext.cs (EmitCode): Don't verify members when error
13453 * statement.cs (LocalInfo): Add reaodnly context information.
13454 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13456 2005-05-13 Raja R Harinath <rharinath@novell.com>
13458 * statement.cs (Block.Resolve): Revert change below. Modify fix
13459 for #74041 to initialize 'resolved' to false only for explicit
13460 blocks. Fixes #74873.
13462 2005-05-12 Raja R Harinath <harinath@gmail.com>
13465 * typemanager.cs (unmanaged_enclosing_types): New.
13466 (IsUnmanagedType): Avoid infloops by using
13467 'unmanaged_enclosing_types' to talk with recursive invocations.
13469 2005-05-13 Martin Baulig <martin@ximian.com>
13471 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13472 instance variable, not a local. Fix #74873.
13473 (Block.ResolveUnreachable): Set it to true here.
13475 2005-05-11 Duncan Mak <duncan@novell.com>
13477 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13478 continuing to process for 'arg'.
13479 (handle_preprocessing_directive): Check the argument of the #endif
13480 directive and report error CS1025 if there are any trailing
13483 According to the C# spec, having even whitespace after the #endif
13484 directive is illegal; however, because we call arg.TrimEnd ()
13485 beforehand, we have the same behavior as csc, allowing whitespace
13486 after the directive.
13490 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13494 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13495 (Constructor.GetObsoleteAttribute): Implemented correctly.
13497 2005-05-10 Martin Baulig <martin@ximian.com>
13499 * support.cs (ReflectionParameters.ParameterModifier): Use
13500 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13501 and `ParameterAttributes.In'. Fixes #74884.
13503 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13505 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13507 * expression.cs (Argument.GetParameterModifier): Turned to property.
13508 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13510 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13513 2005-05-09 Raja R Harinath <rharinath@novell.com>
13516 * decl.cs (MemberCache.AddMethods): Register override methods,
13517 rather than non-override methods.
13518 * typemanager.cs (RegisterOverride): New.
13519 (IsOverride): Update.
13521 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13525 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13526 recursive declaration.
13528 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13530 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13532 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13534 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13536 2005-05-05 Raja R Harinath <rharinath@novell.com>
13539 * decl.cs (DeclSpace.FamilyAccessible):
13540 Use TypeManager.IsNestedFamilyAccessible.
13542 Fix reopened #64812.
13543 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13546 2005-05-04 Raja R Harinath <rharinath@novell.com>
13547 Abin Thomas <projectmonokochi@rediffmail.com>
13548 Anoob V E <projectmonokochi@rediffmail.com>
13549 Harilal P R <projectmonokochi@rediffmail.com>
13552 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13553 allow access to all static members.
13555 2005-05-04 Martin Baulig <martin@ximian.com>
13557 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13559 2005-05-04 Martin Baulig <martin@ximian.com>
13563 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13564 section at the end; make things work if `default' is not the last
13567 2005-05-04 Martin Baulig <martin@ximian.com>
13571 * statement.cs (Switch): Replaced the `got_default' field with a
13572 `default_section' one.
13573 (Switch.CheckSwitch): Set `default_section' here.
13574 (Switch.Resolve): If we're a constant switch and the constant is
13575 not found, use the default section.
13577 2005-05-03 Martin Baulig <martin@ximian.com>
13579 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13581 * statement.cs (Foreach.ArrayForeach): New nested class.
13582 (Foreach.TemporaryVariable): New nested class.
13583 (Foreach.EmitArrayForeach): Removed; this is now in the new
13584 ArrayForeach class.
13586 2005-05-03 Raja R Harinath <rharinath@novell.com>
13588 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13590 (VerifyPendingMethods): Revert change below.
13592 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13593 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13594 that used to trigger warning -28. Remove warning -28.
13595 * expression.cs (Invocation.OverloadResolve): Use
13596 TypeManager.IsOverride to distinguish override methods.
13599 * pending.cs (VerifyPendingMethods): If a base type implements the
13600 requested interface, don't bother checking individual methods of
13601 the base type. As a side-effect, this prevents the creation of
13602 unnecessary proxies.
13604 2005-05-02 Martin Baulig <martin@ximian.com>
13608 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13609 Also `And' the locals if the old vector is null.
13610 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13611 null; in this case we basically reset all the variables.
13613 2005-05-02 Martin Baulig <martin@ximian.com>
13617 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13618 Added `FlowBranching branching' argument; always `and' the
13619 variables instead of `or'ing them unless we're an infinite loop.
13621 * statement.cs (While.Resolve): Create a new sibling unless we're
13624 2005-05-02 Martin Baulig <martin@ximian.com>
13628 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13629 arguments; use it instead of creating a new TopLevelBlock.
13630 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13631 our ConstructorInitializer.
13634 (TopLevelBlock.TopLevelBranching): New public property.
13635 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13636 and create our `TopLevelBranching'.
13638 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13639 anonymous method host, use `block.TopLevelBranching' rather than
13640 creating a new branching.
13642 2005-04-20 Miguel de Icaza <miguel@novell.com>
13644 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13645 a ScopeInfo, if any of the current children is a child of the new
13646 entry, move those children there.
13648 2005-04-30 Martin Baulig <martin@ximian.com>
13650 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13651 at the beginning of a SwitchSection. Fix #73335.
13653 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13656 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13658 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13659 (FieldExpr.DoResolve): Obsolete members are ignored for field
13662 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13664 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13665 of arrays detection.
13667 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13669 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13671 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13674 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13676 * cs-parser.jay: Use the prefered version of -unsafe in error
13679 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13681 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13684 2005-04-20 John Luke <john.luke@gmail.com>
13686 * driver.cs: fix typo in error message, --outout to --output
13688 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13690 * codegen.cs (InRefOutArgumentResolving): New field.
13692 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13693 fields outside contructor.
13695 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13697 2005-04-19 Miguel de Icaza <miguel@novell.com>
13699 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13700 parameter code was not completed ever, so it was not as up-to-date
13701 as local variables. Must finish it.
13703 The bug fix was to compare the Toplevel of the block, not the
13704 current block. Thanks for Ben for pointing this out.
13706 2005-04-19 Raja R Harinath <rharinath@novell.com>
13708 * decl.cs (AddMethods): Use the declaring type of the problem
13709 method to determine if we want to squash a warning.
13711 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13713 * attribute.cs: Removed debug output.
13715 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13717 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13720 2005-04-18 Raja R Harinath <rharinath@novell.com>
13723 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13724 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13725 all null comparisons against reference types.
13727 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13730 * class.cs (TypeContainer.CircularDepException) New nested
13732 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13733 (TypeContainer.DefineType): Removed error, reset InTransit before
13735 (Class.DefineType): Throw exception when is in Transit.
13736 Catch exception and report error.
13737 (Struct.DefineType): Throw exception when is in Transit.
13738 Catch exception and report error.
13739 (Interface.DefineType): Throw exception when is in Transit.
13740 Catch exception and report error.
13742 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13743 handle nested exception handlers.
13745 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13748 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13749 InFinally and InCatch storage.
13751 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13752 (Catch.Resolve): Set and Restore ec.InCatch.
13753 (Try.Resolve): Set and Restore ec.InFinally.
13754 (Try.HasCatch): True when try has catch.
13756 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13758 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13759 for the same event member, so exclude such cases from warning 419.
13762 2005-04-16 Miguel de Icaza <miguel@novell.com>
13764 * expression.cs (Binary.ResolveOperator): Apply patch from John
13765 Luke to fix bug 59864: operators &, | and ^ on enumerations
13766 require that the same enum type on both sides.
13768 * driver.cs: Add warnings to old flag usage, this is to assist
13769 people who produce Makefiles and hope that the Makefiles will be
13772 * class.cs (TypeContainer.EmitType): Moved the definition of the
13773 special $PRIVATE$ field from the resolve phase to the Emit phase.
13774 During resolve we do not know if we are a struct with
13775 HasExplicitLayout, we know this only after the attributes for the
13778 Set the FieldOffset to zero on the dummy field that we create for
13779 the class. Fixes 74590.
13781 2005-04-16 Raja R Harinath <rharinath@novell.com>
13784 * ecore.cs (PropertyExpr.resolved): New.
13785 (DoResolve): Use it to handle a case of double resolution here.
13786 Handle a case of identical-name-and-type-name.
13787 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13788 resolution by storing the results of expression resolution back
13789 into the "probes" array.
13791 2005-04-15 Raja R Harinath <rharinath@novell.com>
13793 Fix cs0208-7.cs and cs0208-8.cs.
13794 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13795 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13796 error reporting to point out the reason a struct is not unmanaged.
13798 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13800 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13801 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13803 2005-04-13 Raja R Harinath <rharinath@novell.com>
13806 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13807 IdenticalNameAndTypeName here.
13808 (EventExpr.InstanceResolve): Likewise.
13810 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13812 C# 2.0 DefaultCharSetAttribute implementation
13814 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13815 which allows us to set GlobalNamespace for every resolve.
13816 (Attribute.ResolveArguments): Cut from Resolve.
13817 (Attribute.GetCharSetValue): Returns CharSet named argument.
13818 (Attribute.DefinePInvokeMethod): Gets default charset from
13820 (GlobalAttribute.ResolveAsTypeStep): Override.
13821 (GlobalAttribute.ResolveArguments): Override.
13823 * class.cs (TypeAttr): Is protected.
13825 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13826 (ModuleClass.DefaultCharSetType): New memeber.
13827 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13829 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13830 charset from module.
13832 * delegate.cs (TypeAttr): Override.
13833 (Delegate.DefineType): Use this TypeAttr.
13835 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13836 at very early stage (before types are defined) to resolve model
13837 module attributes. It will probably not work with corlib but it
13840 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13841 charset from module.
13843 * typemanager.cs (default_charset_type): New type.
13845 2005-04-13 Raja R Harinath <rharinath@novell.com>
13847 * decl.cs (MemberCache.AddMethods): Don't warn if
13848 System.Object.Finalize has buggy MethodAttributes.
13850 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13853 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13855 * doc.cs : detect ambiguous reference to overloaded members.
13856 Fixed bug #71603. MS 1.1 csc does not detect it.
13858 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13860 * doc.cs : delegates must not be referenced with parameters.
13863 2005-04-12 Miguel de Icaza <miguel@novell.com>
13865 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13867 2005-04-10 Miguel de Icaza <miguel@novell.com>
13869 * driver.cs (MainDriver): Stop processing if the CLS stage found
13872 (CompilerCallableEntryPoint.InvokeCompiler): Always
13873 reset after execution; Take a TextWriter argument for the
13876 * report.cs: Use the error stream instead of hardcoding stderr.
13878 2005-04-09 Miguel de Icaza <miguel@novell.com>
13880 * class.cs: Reduce code paths to test, too small of an
13881 optimization to make it worth the extra testing. Always perform
13884 2005-04-08 Raja R Harinath <rharinath@novell.com>
13887 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
13888 operators that had errors reported on them.
13890 2005-04-08 Marek Safar <marek.safar@seznam.cz>
13892 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
13894 (Attribute.Resolve): Add named argument type checking.
13896 * class.cs (FixedField.Define): Use IsPrimitiveType
13898 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
13900 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
13901 unsafe parameter types.
13903 * statement.cs (Using.ResolveExpression): Add better error description.
13905 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
13907 2005-04-08 Raja R Harinath <rharinath@novell.com>
13910 * attribute.cs (Attribute.GetAttributeUsage): Resolve
13911 AttributeUsageAttribute in the emitcontext of the attribute class,
13912 not in the emitcontext of the attributable entity it was attached to.
13913 * cs-parser.jay: Use 'current_class', not 'current_container',
13914 when creating a GlobalAttribute.
13916 2005-04-08 Alp Toker <alp@atoker.com>
13918 * pending.cs: The fix to #58413 failed to compile methods implementing
13919 interfaces with/without params modifiers and vice versa, even though
13920 params modifiers aren't part of the signature. Make the modifier check
13921 less strict as in csc.
13923 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
13924 Anoob V E <projectmonokochi@rediffmail.com>
13925 Harilal P R <projectmonokochi@rediffmail.com>
13928 * pending.cs (TypeAndMethods.mods): New. Store the parameter
13929 modifiers of pending methods.
13930 (PendingImplementation.PendingImplementation): Initialize it.
13931 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
13932 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
13933 with ParameterData. Add check for modifiers.
13934 * class.cs (MethodData.Define): Update to changes.
13936 2005-04-07 Raja R Harinath <rharinath@novell.com>
13938 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
13940 2005-04-07 Marek Safar <marek.safar@seznam.cz>
13942 * class.cs (PropertyMethod.Define): Check private accessor in abstract
13945 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
13948 * typemanager.cs: Registered RequiredAttributeAttribute.
13950 2005-04-06 Marek Safar <marek.safar@seznam.cz>
13952 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
13953 Warning CS0169 is back at level 3.
13954 (IMethodData.SetMemberIsUsed): New method.
13956 * decl.cs (IsUsed): New value; moved from FieldBase.Status
13957 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
13959 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
13961 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
13963 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
13966 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
13969 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
13970 to avoid the problems with nested types.
13972 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
13973 Anoob V.E <projectmonokochi@rediffmail.com>
13974 Harilal P.R <projectmonokochi@rediffmail.com>
13975 Raja R Harinath <rharinath@novell.com>
13978 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
13980 * typemanager (GetConstructor): Make public.
13982 2005-04-05 John Luke <john.luke@gmail.com>
13983 Raja R Harinath <rharinath@novell.com>
13986 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
13987 struct too. Return false quicker in a few cases.
13988 (VerifyUnManaged): Use it.
13990 2005-04-05 Raja R Harinath <rharinath@novell.com>
13993 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
13994 not 'unreachable_seen'.
13996 2005-04-04 Marek Safar <marek.safar@seznam.cz>
13998 * attribute.cs (Attribute.GetValue): Removed unused.
14000 * codegen.cs (CodeGen.TrimExt): Removed unused.
14002 * cs-parser.jay (output): Removed unused.
14004 * cs-tokenizer.cs (hex_digits): Removed unused.
14006 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14008 * expression.cs (Indirection.LoadExprValue): Removed unused.
14009 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14011 * iterators.cs (Iterator.param_types): Removed unused.
14013 * statement.cs (Goto.block): Removed unused.
14014 (ToplevelBlock.did): Removed unused.
14015 (Switch.ResolveConstantSwitch): Removed unused.
14017 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14019 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14022 2005-04-01 Raja R Harinath <rharinath@novell.com>
14024 Fix #74232 and cs0208-3.cs.
14025 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14026 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14027 unmanaged type. Don't use FieldBuilders when 't' is a
14028 TypeBuilder. Use ModFlags and MemberType fields.
14029 * class.cs (MemberBase.member_type): Rename from MemberType.
14030 (MemberBase.MemberType): New property. Determines member_type on
14032 (MemberBase.DoDefine): Don't initialize MemberType here.
14033 (FieldMember.Define): Likewise.
14035 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14038 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14039 Attributes are emitted there.
14041 2005-04-01 Raja R Harinath <rharinath@novell.com>
14043 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14044 keyword in 'partial enum' too.
14045 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14047 Report from Kamil Skalski <nazgul@omega.pl>.
14050 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14051 have partial containers too.
14053 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14054 in block' checks to Block.CheckInvariantMeaningInBlock.
14055 * statement.cs (Block.GetKnownVariableInfo): Make private.
14056 (Block.IsVariableUsedInChildBlock): Remove.
14057 (Block.IsVariableUsedInBlock): Likewise.
14058 (Block.CheckInvariantMeaningInBlock): New. Show location of
14059 conflicting declaration.
14060 (Block.AddVariable): Make error messages less long-winded and more
14061 specific. Show location of conflicting declaration.
14062 * parameter.cs (Parameters.Location): New readonly property.
14064 2005-03-31 Raja R Harinath <rharinath@novell.com>
14066 Clean up semantics of invoking ResolveMemberAccess.
14067 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14068 can have an instance, ensure that we pass in a non-TypeExpression
14069 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14070 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14071 argument. Update to changes and simplify.
14072 (FieldExpr.Emitinstance): Remove CS0120 check.
14073 (PropertyExpr.EmitInstance): Likewise.
14074 * expression.cs (Argument.Resolve): Likewise.
14075 (Invocation.DoResolve): Update to changes in semantics of
14076 InstanceExpression.
14078 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14081 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14084 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14086 2005-03-31 Raja R Harinath <rharinath@novell.com>
14088 Fix difference in behaviour with commandline invocation.
14089 * driver.cs (Driver.Reset): New.
14090 (CompilerCallableEntryPoint): Call it.
14092 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14093 variable" warnings if the boolean expression failed to resolve.
14095 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14097 * attribute.cs: Fix the union of several permissions when some of them
14098 are unrestricted (so the result isn't an unrestricted permission set).
14101 2005-03-30 Raja R Harinath <rharinath@novell.com>
14103 * ecore.cs (MemberExpr): New class. Convert from interface
14105 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14106 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14108 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14109 (MethodGroupExpr.IsExplicitImpl): Remove.
14110 (Expression.GetFieldFromEvent): Remove.
14111 (SimpleName.MemberStaticCheck): Remove.
14112 (SimpleName.DoSimpleNameResolve): Update to changes.
14113 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14114 (MemberAccess.IdenticalNameAndTypeName): Remove.
14115 (MemberAccess.error176): Move to MemberExpr.
14116 (MemberAccess.DoResolve): Update to changes.
14117 (BaseAccess.DoResolve): Likewise.
14119 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14121 C# 2.0 Conditional attribute class implementation
14123 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14124 Analyzes class whether it has attribute which has ConditionalAttribute
14125 and its condition is not defined.
14127 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14128 (Class.IsExcluded): New method. Search for at least one defined
14129 condition in ConditionalAttribute of attribute class.
14131 2005-03-30 Raja R Harinath <rharinath@novell.com>
14133 * ecore.cs (PropertyExpr): Derive from Expression, not
14134 ExpressionStatement.
14135 (PropertyExpr.EmitStatement): Remove.
14137 2005-03-29 Raja R Harinath <rharinath@novell.com>
14140 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14141 internal field "value__" of an enum be private. The examples for
14142 "value__" that I found on MSDN all used FieldAttributes.Private.
14144 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14145 Don't mention IL method attribute names.
14147 Fix #47991. Remove a TODO.
14148 * statement.cs (Block.Toplevel): Make into a field.
14149 (Block.Parameters): Move into ToplevelBlock.
14150 (Block.known_variables): Rename from child_variable_names.
14151 (Block.Block): Remove variants that take Parameters. Initialize
14152 'Toplevel' with the immediately surrounding toplevel block.
14153 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14154 LocalInfo parameter.
14155 (Block.GetKnownVariableInfo): New.
14156 (Block.IsVariableNameUsedInChildBlock): Update.
14157 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14158 the block, even though it may not be in scope.
14159 (Block.AddVariable): Remove Parameters parameter. Use
14160 Toplevel.Parameters instead.
14161 (Block.AddConstant): Remove Parameters parameter.
14162 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14163 (Block.IsParamaterReference): Likewise.
14164 (Block.IsLocalParameter): Likewise. Simplify a lot.
14165 (ToplevelBlock.Parameters): New. Moved from Block.
14166 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14167 initialize Parameters to a non-null value.
14168 * cs-parser.jay: Update to changes.
14169 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14170 simple names that mean different things in the same block. Use
14171 Block.IsVariableNameUsedInBlock.
14173 2005-03-28 Raja R Harinath <rharinath@novell.com>
14175 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14176 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14177 GetTypeHandle. It is possible for a reflected type to derive from
14178 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14179 System.Array during mscorlib compilation).
14180 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14181 contain a method_hash, don't create one either. Don't create a
14182 deep copy of the base cache's method_hash.
14183 (MemberCache.SetupCache): Rename back from DeepCopy.
14184 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14185 already initialized. If we see an override function, add its
14186 underlying base virtual function to the member_hash too.
14188 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14190 2005-03-26 Raja R Harinath <harinath@acm.org>
14193 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14194 fails to resolve, ensure that the LHS is still resolved as an
14197 2005-03-25 Raja R Harinath <harinath@acm.org>
14199 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14201 (Enum.current_ec): Remove.
14202 (Enum.LookupEnumValue): Remove EmitContext argument.
14203 Just uses the one created during DefineType.
14204 (Enum.FindMembers): Update.
14205 * expression.cs (MemberAccess.DoResolve): Update.
14207 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14209 * assign.cs (Assign.DoResolve): Check for CS1717 when
14210 source and target are same (uses Equals).
14212 * expression.cs (LocalVariableReference, ParameterReference,
14213 This): Implemented Equals, GetHashCode.
14215 * statement.cs (Block.GetParameterReference): Removed useless
14218 2005-03-22 Raja R Harinath <rharinath@novell.com>
14221 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14222 blocks before deciding whether the error is cs0136 or cs0128.
14224 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14225 (using_alias_directive, using_namespace_directive): Pass
14226 MemberName, not an expression to Namespace.UsingAlias and
14228 (MakeName): Use the MemberName of the namespace.
14229 * namespace.cs (Namespace.MemberName): New.
14230 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14231 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14233 * decl.cs (MemberName.Name): Make readonly.
14234 (MemberName.FromDotted): New "constructor".
14235 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14236 (MemberCore.Name): Compute from MemberName on demand.
14237 (MemberCore.SetMemberName): Provide a way to change the
14239 (MemberCore.AddToContainer): Don't take a fullname parameter.
14240 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14241 fully qualified name of the container to the member name.
14242 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14243 only if the type is a member of the root container.
14244 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14245 MemberName.Left rather than searching for an embedded ".".
14246 (PartialContainer.CreatePart): Update to changes in RootContext.
14247 (MemberBase.ShortName): Turn into a property. Use
14248 MemberCore.SetMemberName.
14249 (MemberBase.ExplicitInterfaceName): Remove.
14250 (MemberBase.UpdateMemberName): Remove.
14251 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14252 (PropertyBase.SetMemberName): New override.
14253 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14254 (Tree.GetDecl): New.
14255 (Tree.AllDecls): Rename from Decls.
14256 * attribute.cs, enum.cs, report.cs: Update to changes.
14257 * driver.cs (MainDriver): Use MemberName.FromDotted on
14258 RootContext.MainClass.
14260 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14262 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14265 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14267 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14269 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14270 property accessor modifiers.
14272 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14273 fixed buffer attribute (CS1716).
14274 (PropertyMethod.HasCustomAccessModifier): When property accessor
14275 has custom modifier.
14277 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14279 (PropertyExpr.DoResolveLValue): Add CS0272.
14281 2005-03-17 Miguel de Icaza <miguel@novell.com>
14283 * convert.cs: When converting to a pointer, use the proper Conv.U
14284 or Conv.I depending on the source data type.
14286 * cs-tokenizer.cs: Make the size for large decimal constants,
14289 2005-03-17 Martin Baulig <martin@ximian.com>
14291 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14292 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14294 2005-03-17 Martin Baulig <martin@ximian.com>
14296 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14297 to bool so we can return an error condition.
14298 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14301 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14303 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14306 2005-03-16 Raja R Harinath <rharinath@novell.com>
14308 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14309 Refactor to avoid traversing the list of assemblies, and to avoid
14310 string concatenation.
14311 * typemanager.cs (guid_attr_type): Remove.
14312 (negative_hits, pointers, references): Remove hashes.
14314 (GetConstructedType): New. Uses type_hash to handle constructed
14315 types (arrays, references, pointers).
14316 (GetReferenceType, GetPointerType): Use it.
14317 (GetNestedType): New. Uses type_hash to handle nested types of
14319 (LookupType, LookupTypeDirect): Remove.
14320 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14321 'types' hash and LookupTypeReflection directly.
14322 (params_string, params_object): Use GetConstructedType.
14323 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14325 (Namespace.Lookup): Use cached_types.
14326 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14327 provided by old TypeManager.LookupType.
14328 * rootcontext.cs (MakeFQN): Remove.
14329 * decl.cs (DeclSpace.MakeFQN): Likewise.
14330 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14331 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14332 TypeManager.GetConstructedType.
14333 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14335 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14337 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14340 * cs-parser.jay: Reports CS1527 for any namespace element.
14342 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14345 * expression.cs (ParameterReference.IsAssigned): Changed error to
14347 (Error_WrongNumArguments): Moved CS0245 detection here.
14349 * statement.cs (Return.Resolve): Add CS1622 report.
14351 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14353 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14355 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14357 * attribute.cs expression.cs: Get rid of some allocations.
14359 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14361 * doc.cs : just eliminate the latest change.
14363 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14365 * doc.cs : commented out the latest change. It breaks xml-030.cs
14367 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14369 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14370 fail. So invoke CreateType() in FindDocumentedType().
14372 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14374 * cs-tokenizer.cs : added IsKeyword().
14375 * doc.cs : Detect keyword incorrectly used as identifier.
14376 Allow identifiers prefixed by @.
14378 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14380 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14381 It caused exception in namespace resolving (again!).
14383 * class.cs (Class.ctor): Removed exit.
14384 (PropertyMethod.ctor): ditto.
14386 * codegen.cs (Codegen.Reset): Reset static data.
14387 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14389 * cs-tokenizer.cs (Cleanup): Removed.
14391 * driver.cs (GetSystemDir): Rewrote to one line command.
14392 It caused problem with unloaded dynamic modules.
14393 (UnixParseOption): Removed Exit.
14394 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14395 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14396 Now can be mcs used as library.
14398 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14401 * location.cs (Reset): Reset static data.
14403 * namespace.cs (Reset): Reset static data.
14405 * report.cs (Report.Reset): Reset static data.
14407 * rootcontext.cs (RootContext.Reset): Reset static data.
14409 * tree.cs (RootTypes.ctor): Use Location.Null
14411 * typemanager.cs (TypeManager.Reset): Reset static data.
14412 (CoreLookupType): Removed Exit.
14413 (TypeHandle.Reset): Reset static data.
14415 2005-03-10 Raja R Harinath <rharinath@novell.com>
14418 * typemanager.cs (ComputeNamespaces): Import namespaces from
14419 referenced modules too.
14421 2005-03-09 Raja R Harinath <rharinath@novell.com>
14423 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14426 2005-03-09 Raja R Harinath <rharinath@novell.com>
14428 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14429 enclosing DeclSpace. This ensures that a name-lookup populates
14430 more caches and there are fewer 'TypeExpression's. Carve out
14431 nested type lookup into ...
14432 (LookupNestedTypeInHierarchy): ... this.
14434 2005-03-09 Raja R Harinath <rharinath@novell.com>
14436 Clean up a few partial-class semantics.
14437 Fixes test-357.cs and cs1618-2.cs.
14438 * cs-parser.jay (struct_declaration): Use 'current_class' as
14439 parent of newly-created struct. Remove call to Register ().
14440 Use 'pop_current_class' to complete handing the current struct.
14441 (interface_declaration): Likewise.
14442 (class_declaration): Likewise.
14443 (enum_declaration): Use 'current_class' as parent of newly created
14445 (delegate_declaration): Likewise.
14446 (pop_current_class): New function. This is used to handle closing
14447 up the 'current_class' and 'current_container', and pointing them
14448 to the enclosing class/container.
14449 (CSharpParser): Initialize 'current_class' too.
14450 * decl.cs (MemberCore): Add check for invariant: a partial
14451 container is not a parsed entity, and thus does not enclose any
14453 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14454 (DeclSpace.BaseTypeExpr): Use it.
14455 (DeclSpace.LookupType): Add check for invariant.
14456 * class.cs (TypeContainer): Add check for invariant: a nested
14457 class should have the same NamespaceEntry as its enclosing class.
14458 (TypeContainer.EmitFieldInitializers): Make virtual.
14459 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14461 (TypeContainer.Register): Remove.
14462 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14463 null. Use TypeResolveEmitContext for resolving base types and
14464 interfaces. Move initialization of Parts.TypeBuilder here from
14466 (TypeContainer.DefineNestedTypes): ... here.
14467 (PartialContainer): Take a Namespace not a NamespaceEntry.
14468 (PartialContainer.Create): Don't use Register. Call the
14469 appropriate Add... function directly.
14470 (ClassPart): Take both the PartialContainer and the enclosing
14471 class as constructor arguments.
14472 (ClassPart.EmitFieldInitializers): Override.
14473 (ClassPart.PartFindNestedTypes): Remove.
14474 (FieldBase.GetInitializerExpression): Resolve the initializer
14475 expression in the emit context of the enclosing class.
14476 * tree.cs (RootTypes): Remove Register ().
14478 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14480 * cs-parser.jay: Removed CS0134.
14482 * driver.cs: Removed CS1901.
14484 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14485 for predefined types.
14487 2005-03-07 Duncan Mak <duncan@novell.com>
14489 * codegen.cs (Save): Catch UnauthorizedAccessException as
14490 well. Fixes bug #73454.
14492 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14494 * cs-tokenizer.cs (xtoken): Add CS1035.
14496 * class.cs (MethodData.Define): Add CS0683.
14497 (FieldMember.ctor): Add CS0681.
14499 2005-03-07 Raja R Harinath <rharinath@novell.com>
14501 * ecore.cs (SimpleName.DoResolve): Rename from
14502 SimpleName.DoResolveAllowStatic.
14503 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14504 Pass 'intermediate' flag to MemberStaticCheck.
14505 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14506 of "intermediate" lookups via MemberAccess.
14507 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14508 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14510 2005-03-07 Raja R Harinath <rharinath@novell.com>
14513 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14514 slipped in because of variable names that are identical to a
14515 builtin type's BCL equivalent ('string String;', 'int Int32;').
14516 (PropertyExpr.EmitInstance): Likewise.
14518 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14520 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14522 * report.cs (warning_ignore_table): Made public.
14524 2005-03-04 Raja R Harinath <rharinath@novell.com>
14527 * class.cs (MethodData.Emit): Pass 'container' to
14528 container.GetObsoleteAttribute instead of 'container.Parent'.
14530 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14532 * cs-parser.jay: Add 1534 error test.
14534 * iterators.cs (Yield.CheckContext): Add error 1629.
14535 (Iterator.ctor): Save unsafe modifier.
14536 (MoveNextMethod.DoEmit): Restore unsafe context.
14538 * namespace.cs (UsingAlias): Better error message.
14540 2005-03-03 Dan Winship <danw@novell.com>
14542 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14543 the warning message [#73219]
14545 2005-03-03 Raja R Harinath <rharinath@novell.com>
14547 Fix compile with MCS 1.0.0.0.
14548 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14549 w_restore to not depend on string constant folding.
14551 2005-03-03 Raja R Harinath <rharinath@novell.com>
14553 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14554 CS0246 check to users who passed 'silent = false'.
14555 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14557 (SimpleName.SimpleNameResolve): Update.
14558 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14559 (MemberAccess.IdenticalNameAndTypeName): Update.
14560 * doc.cs (FindDocumentedTypeNonArray): Update.
14562 2005-03-03 Raja R Harinath <rharinath@novell.com>
14564 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14565 * parameters.cs (ComputeAndDefineParameters): Remove.
14566 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14567 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14568 Use GetParameterInfo.
14570 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14572 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14574 2005-03-02 Raja R Harinath <rharinath@novell.com>
14576 Unify DeclSpace.LookupType and DeclSpace.FindType.
14577 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14578 is in charge of defining nested types on demand.
14579 (DeclSpace.LookupType): Use it when the current_type is a
14580 TypeBuilder. Use LookupTypeDirect for reflected types.
14581 (DeclSpace.FindType): Remove.
14582 (DeclSpace.LookupInterfaceOrClass): Likewise.
14583 (DeclSpace.DefineTypeAndParents): Likewise.
14584 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14585 DeclSpace.LookupType.
14586 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14587 * typemanager.cs (LookupType): Simplify.
14588 (AddUserType): Remove type from negative_hits.
14589 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14590 * class.cs (TypeContainer.FindMembers): Move handling of nested
14592 (TypeContainer.FindMembers_NestedTypes): ... here.
14593 (TypeContainer.FindNestedType): Implement override.
14594 (ClassPart.FindNestedType): Delegate to PartialContainer.
14595 (ClassPart.PartFindNestedType): Looks up the nested types of the
14598 2005-03-02 Martin Baulig <martin@ximian.com>
14600 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14601 static constructor in static classes.
14603 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14605 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14606 sizeParamIndex is not specified.
14608 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14611 * report.cs (WarningMessage.IsEnabled): Missing null check.
14613 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14615 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14616 in the fields and not in the properties.
14618 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14620 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14623 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14625 * attribute.cs: Small refactoring (improved robustness).
14626 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14627 (ValidateGuid): Removed.
14628 (Resolve): Removed referenced to above mentioned.
14629 (GetAttributeUsage): Made private and changed to work without
14631 (GetIndexerAttributeValue): Don't crash.
14632 (GetConditionalAttributeValue): Ditto.
14633 (GetClsCompliantAttributeValue): Ditto.
14634 (ExtractSecurityPermissionSet): All attributes exceptions are
14636 (GetPropertyValue): New helper.
14637 (GetMethodImplOptions): New method.
14638 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14639 some missing properties.
14641 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14642 (Method.ApplyAttributeBuilder): Updated.
14644 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14647 2005-02-28 Raja R Harinath <rharinath@novell.com>
14650 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14651 non-simple types (array, pointer, reference).
14653 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14655 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14657 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14659 (Method.CheckBase): Catch wrong destructor here.
14660 (MethodData.Define): Add errors 550, 668.
14662 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14664 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14666 * pending.cs (VerifyPendingMethods): Add error 551.
14668 * typemanager.cs (CSharpName): Next error report helper.
14670 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14672 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14673 attributes. Removed useless attribute double check.
14674 It saves almost 2MBs for corlib.
14676 2005-02-25 Raja R Harinath <rharinath@novell.com>
14679 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14680 called twice in case of error.
14682 2005-02-23 Chris Toshok <toshok@ximian.com>
14684 Fix compiler portions of #72827.
14685 * statement.cs (Block.Emit): call Begin/EndScope on the
14686 EmitContext instead of the ILGenerator.
14688 * codegen.cs (EmitContext.BeginScope): new method, call
14689 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14691 (EmitContext.BeginScope): same, but EndScope and CloseScope
14693 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14694 offset and call the superclass's OpenScope(int) with it.
14695 (SymbolWriter.CloseScope): get the current il
14696 offset and call superclass's CloseScope(int) with it.
14698 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14700 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14701 CS1677 for out and ref as well.
14703 * class.cs (Method.Define): Add error CS1599 detection.
14705 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14707 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14709 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14711 * support.cs.cs (ModifierDesc): New helper method.
14713 2005-02-23 Raja R Harinath <rharinath@novell.com>
14714 Abin Thomas <projectmonokochi@rediffmail.com>
14715 Anoob V E <projectmonokochi@rediffmail.com>
14716 Harilal P R <projectmonokochi@rediffmail.com>
14718 Fix #57851, #72718.
14719 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14720 MemberLookup (used for error reporting) actually returns a result.
14721 Fix error report number (122, not 112).
14723 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14724 Anoob V E <projectmonokochi@rediffmail.com>
14725 Harilal P R <projectmonokochi@rediffmail.com>
14728 * pending.cs (PendingImplementation.GetAbstractMethods):
14729 Find NonPublic members too.
14731 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14733 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14736 * class.cs (MethodCore.CheckMethodAgainstBase):
14737 Add error 239 report.
14739 2005-02-21 Raja R Harinath <rharinath@novell.com>
14742 * expression.cs (Invocation.IsApplicable): Make public.
14743 (Invocation.IsParamsMethodApplicable): Likewise.
14744 * delegate.cs (Delegate.VerifyApplicability): Don't use
14745 Invocation.VerifyArgumentCompat for parameter applicability
14746 testing. Use Invocation.IsApplicable and
14747 Invocation.IsParamsMethodApplicable.
14749 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14751 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14753 * class.cs (Operator.Define): Add error 217 report.
14755 2005-02-21 Raja R Harinath <rharinath@novell.com>
14757 * namespace.cs (UsingEntry.Resolve): Undo change below.
14759 2005-02-21 Raja R Harinath <rharinath@novell.com>
14762 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14763 disable the error message when the extended MemberLookup also
14765 (Expression.MemberLookupFinal): Update.
14766 (SimpleName.DoSimpleNameResolve): Update.
14767 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14768 Don't use MemberLookupFinal.
14769 (New.DoResolve): Update.
14770 (BaseAccess.CommonResolve): Update.
14772 2005-02-21 Raja R Harinath <rharinath@novell.com>
14775 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14776 occured previously, don't resolve again.
14778 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14781 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14782 argument. Call ResolveAttributeUsage for unresolved.
14783 when types doesn't match ctor arguments.
14785 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14786 for nested attribute classes.
14787 (Class.attribute_usage): Removed.
14788 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14789 for attribute class.
14791 * ecore.cs (IsAttribute): Removed.
14793 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14795 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14797 (attribute_types): Removed.
14798 (EmitCode): Global attributes are emited as the latest.
14800 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14802 * class.cs (EmitFieldInitializers): Don't emit field initializer
14803 for default values when optimilization is on.
14805 * constant.cs (Constant.IsDefaultValue): New property.
14807 * driver.cs: Add /optimize handling.
14811 * literal.cs: Implement new IsDefaultValue property.
14813 * rootcontext.cs (Optimize): New field, holds /optimize option.
14815 2005-02-18 Raja R Harinath <rharinath@novell.com>
14817 Fix crasher in re-opened #72347.
14818 * namespace.cs (Namespace.Lookup): Return null if
14819 DeclSpace.DefineType returns null.
14822 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14824 2005-02-18 Raja R Harinath <rharinath@novell.com>
14826 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14827 now returns null if it cannot resolve to an lvalue.
14828 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14829 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14830 returned null. Remove check for SimpleName.
14831 (EventExpr.DoResolveLValue): New.
14832 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14833 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14835 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14836 avoid CS0131 error.
14837 (Unary.ResolveOperator): Move CS0211 check ...
14838 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14840 (Unary.DoResolveLValue): Simplify.
14841 (AddressOf.DoResolveLValue): New.
14842 (ArrayAccess.DoResolveLValue): New.
14844 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14846 * attribute.cs (Attribute.Resolve): Add arguments casting for
14847 when types doesn't match ctor arguments.
14849 2005-02-16 Raja R Harinath <rharinath@novell.com>
14851 Fix parts of #63202.
14852 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14853 lookup of operator in base type. Ensure that all checks happen
14854 when the operator resolves to an "op_..." method.
14856 2005-02-15 Raja R Harinath <rharinath@novell.com>
14859 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14860 'ignore_cs0104' parameter. Pass it to ...
14861 (NamespaceEntry.Lookup): ... this.
14862 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14863 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14864 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14865 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14866 Update. Request that cs0104 errors be ignored.
14867 (ComposedCast.ResolveAsTypeStep): Update.
14869 2005-02-14 Raja R Harinath <rharinath@novell.com>
14872 * expression.cs (Invocation.BetterFunction): Remove support for
14873 comparing virtual functions and their overrides.
14874 (Invocation.IsOverride): New.
14875 (Invocation.OverloadResolve): Don't consider 'override' functions
14876 during candidate selection. Store them in a lookaside list.
14877 If the selected method is a 'virtual' function, use the list to
14878 find any overrides that are closer to the LHS type.
14880 2005-02-14 Marek Safar <marek.safar@seznam.cz>
14882 * expression.cs (New.DoResolve): Add complex core type reduction.
14883 (New.Constantify): Converts complex core type syntax like 'new int ()'
14884 to simple constant.
14886 2005-02-14 Raja R Harinath <rharinath@novell.com>
14888 * decl.cs (EntryType.EntryType): New constructor to create an
14889 updated copy of a cache entry.
14890 (MemberCache.AddMethods): Use it.
14891 (MemberCache.ClearDeclaredOnly): Remove.
14892 (MemberCache.MemberCache): Update.
14894 2005-02-11 Miguel de Icaza <miguel@novell.com>
14896 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
14897 variable. This one is represents the actual low-level declaration
14898 of the method, as opposed to the semantic level `IsStatic'.
14900 An anonymous method which is hosted into a static method might be
14901 actually an instance method. IsStatic would reflect the
14902 container, while MethodIsStatic represents the actual code
14905 * expression.cs (ParameterReference): Use the new MethodIsStatic
14906 instead of IsStatic.
14908 * anonymous.cs (AnonymousMethod.Compatible): Pass the
14909 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
14910 set on the current EmitContext.
14912 * expression.cs (Cast): Overload DoResolveLValue so we can pass
14913 resolve our casted expression as an LValue. This triggers the
14914 proper LValue processing that is later required by Assign.
14918 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
14920 2005-02-11 Marek Safar <marek.safar@seznam.cz>
14922 C# 2.0 Fixed buffer implementation
14924 * anonymous.cs: Update after RegisterHelperClass renaming.
14926 * attribute.cs (AttributeTester.fixed_buffer_cache):
14927 Cache of external fixed buffers.
14928 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
14929 implementation if field is fixed buffer else null.
14932 (TypeContainer.AddField): Accept FieldMember instead of Field.
14933 (FieldBase.IsFieldClsCompliant): Extracted code from
14934 VerifyClsCompliance descendant customization.
14935 (FixedField): New class handles fixed buffer fields.
14936 (FixedFieldExternal): Keeps information about imported fixed
14938 (IFixedField): Make access to internal or external fixed buffer
14941 * cs-parser.jay: Add fixed buffer parsing.
14943 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
14946 * expression.cs (Indirection): Extended implementation to accept
14947 fixed buffer field.
14948 (PointerArithmetic.Emit): Get element from fixed buffer as well.
14949 (ElementAccess.MakePointerAccess): Get type as parameter.
14950 (DoResolve): Add fixed buffer field expression conversion.
14951 (DoResolveLValue): Ditto.
14952 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
14953 (ArrayPtr): Derives from FixedBufferPtr.
14954 (ArrayPtr.Emit): Add extra emit for array elements.
14956 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
14958 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
14959 for compiler generated types.
14960 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
14962 * statement.cs (Fixed): Refactored to be easier add fixed buffer
14963 and consume less memory.
14964 (Fixed.Resolve): Add fixed buffer case.
14966 * typemanager.cs (compiler_generated_attr_ctor,
14967 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
14968 (HasElementType): Add our own implementation to work on every
14971 2005-02-11 Miguel de Icaza <miguel@novell.com>
14973 * anonymous.cs (CaptureContext): Track whether `this' has been
14976 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
14977 only captured `this' if it was implicitly done (instance
14978 methods/variables were used).
14980 * codegen.cs (EmitContext.CaptureThis): New method to flag that
14981 `this' must be captured.
14983 2005-01-30 Miguel de Icaza <miguel@novell.com>
14985 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
14986 is null it means that there has been no need to capture anything,
14987 so we just create a sibling.
14989 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
14991 Just a partial fix. The other half is fairly elusive.
14993 2005-02-10 Raja R Harinath <rharinath@novell.com>
14995 Fix #52586, cs0121-4.cs.
14996 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
14997 and return a hashtable.
14998 (MemberCache.ClearDeclaredOnly): New.
14999 (MemberCache.MemberCache): Update to change. Make a deep copy of
15000 the method_hash of a base type too.
15001 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15002 type methods. Overwrite entries with the same MethodHandle so
15003 that the ReflectedType is correct. The process leaves in base
15004 virtual functions and their overrides as distinct entries.
15005 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15006 matters since it was boxed in a ArrayList before.
15007 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15009 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15010 case of a virtual function and its override (choose the overload
15012 (Invocation.OverloadResolve): Avoid 'override' members during
15013 'applicable_type' calculation.
15015 2005-02-09 Raja R Harinath <rharinath@novell.com>
15017 Combine two near-redundant caches.
15018 * typemanager.cs (method_params): Rename from method_internal_params.
15019 (TypeManager.GetParameterData): New. Replace
15020 Invocation.GetParameterData.
15021 (TypeManager.LookupParametersByBuilder): Remove.
15022 * expression.cs (Invocation.method_parameter_cache): Remove.
15023 (Invocation.GetParameterData): Remove.
15025 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15028 2005-02-08 Raja R Harinath <rharinath@novell.com>
15031 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15032 TypeManager.multicast_delegate_type is null, resolve it by looking
15033 up "System.MulticastDelegate".
15034 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15036 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15037 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15038 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15041 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15042 (LabeledStatement.AddReference): New. Set 'referenced'.
15043 (Goto.Resolve): Use it.
15045 2005-02-05 John Luke <john.luke@gmail.com>
15047 * driver.cs: remove duplicate -doc line in Usage ()
15049 2005-02-04 Raja R Harinath <rharinath@novell.com>
15051 * location.cs (Location.AddFile): Fix CS2002 error report.
15053 2005-02-02 Martin Baulig <martin@ximian.com>
15055 * delegate.cs (Delegate.DefineType): Report an internal error if
15056 TypeManager.multicast_delegate_type is null. See bug #72015 for
15059 2005-02-02 Raja R Harinath <rharinath@novell.com>
15061 Fix a crasher in a variant of #31984.
15062 * const.cs (Constant.CheckBase): New override that defers the
15063 new-or-override check in case the base type hasn't been populated
15065 (Constant.Define): Ensure the new-or-override check is performed.
15067 2005-02-01 Duncan Mak <duncan@ximian.com>
15069 * const.cs (LookupConstantValue): Check that `ce' is not null
15070 before calling GetValue ().
15072 2005-02-01 Raja R Harinath <rharinath@novell.com>
15074 Fix test-334.cs (#69519).
15075 * cs-parser.jay (using_alias_directive): Pass in an expression to
15076 NamespaceEntry.UsingAlias.
15077 (using_namespace_directive): Pass in an expression to
15078 NamespaceEntry.Using.
15079 (namespace_name): Don't flatten to a string.
15080 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15081 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15083 (NamespaceEntry.UsingEntry): Likewise.
15084 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15086 (NamespaceEntry.LookupForUsing): Remove.
15087 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15089 (NamespaceEntry.Lookup): Remove support for dotted names.
15091 2005-02-01 Raja R Harinath <rharinath@novell.com>
15093 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15095 (NamespaceEntry.ImplicitParent): Compute on demand.
15096 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15097 parallels the current.
15098 (NamespaceEntry.LookupForUsing): Use it.
15099 (NamespaceEntry.Lookup): If the current namespace-entry is
15100 implicit, don't search aliases and using tables.
15102 2005-02-01 Raja R Harinath <rharinath@novell.com>
15105 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15107 (TypeContainer.BaseCache): Compute on demand.
15108 (TypeContainer.FindMembers): Define constants and types if they're
15109 not already created.
15110 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15112 * const.cs (Constant.Define): Make idempotent.
15114 2005-01-29 Miguel de Icaza <miguel@novell.com>
15116 * pending.cs: Produce better code (no nops produced by using Ldarg
15119 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15120 i - 1' it should be arg + 1.
15124 2005-01-28 Raja R Harinath <rharinath@novell.com>
15126 * attribute.cs (Attribute.CheckAttributeType): Make private
15128 (Attribute.ResolveType): Make virtual.
15129 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15130 handling of RootContext.Tree.Types.
15132 2005-01-27 Raja R Harinath <rharinath@novell.com>
15134 Update attribute-handling to use the SimpleName/MemberAccess
15136 * cs-parser.jay (attribute): Pass in an expression to the
15137 constructors of Attribute and GlobalAttribute.
15138 * attribute.cs (Attribute): Take an expression for the name.
15139 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15140 passed in attribute name expression.
15141 (Attribute.CheckAttributeType): Use it.
15142 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15143 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15144 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15145 argument to prevent error messages if the lookup fails.
15147 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15149 * expression.cs (Indirection): Implemented IVariable interface
15150 to support indirection in AddressOf operator.
15151 (PointerArithmetic.Emit): Add optimalization for case where
15152 result can be precomputed.
15154 2005-01-26 Martin Baulig <martin@ximian.com>
15156 * class.cs (TypeContainer.AttributeTargets): Return the correct
15157 AttributeTargets depending on our `Kind' instead of throwing an
15158 exception; fixes #71632.
15160 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15163 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15166 2005-01-25 Raja R Harinath <rharinath@novell.com>
15169 * expression.cs (MemberAccess.DoResolve): Don't complain with
15170 cs0572 when the LHS of a member access has identical name and type
15173 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15176 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15178 Create custom PermissionSet only for PermissionSetAttribute.
15180 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15183 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15184 delegates in static class.
15186 2005-01-24 Martin Baulig <martin@ximian.com>
15188 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15189 merging an implicit block, just use its reachability.
15191 * statement.cs (Block.Resolve): Make the unreachable code check
15192 work wrt. implicit blocks; see test-337 from #63842.
15194 2005-01-21 Alp Toker <alp@atoker.com>
15196 * cs-parser.jay: destructor_declaration's container is PartialContainer
15197 not Class when partial types are used, so use Kind prop instead of
15200 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15202 * cs-parser.jay: Improve error reporting when an interface
15203 declares new types.
15205 2005-01-20 Dick Porter <dick@ximian.com>
15207 * support.cs: SeekableStreamReader fix from Sandor Dobos
15208 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15209 chars are read. Fixes bug 70369.
15211 2005-01-20 Raja R Harinath <rharinath@novell.com>
15213 * cs-parser.jay (catch_clause): Simplify current_block handling
15216 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15218 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15219 code with ImplicitStandardConversion to handle the implicit
15220 conversion of method groups into valid delegate invocations.
15222 The problem is that in parameter handling we were using this code
15223 path. Fixes bug #64698
15225 2005-01-19 Raja R Harinath <rharinath@novell.com>
15227 * cs-parser.jay: Fix several infelicities.
15228 - Avoid assigning to the parser value stack. Code like
15229 '$3 = null' is unclean. Synthesize a value for the code block
15231 - Avoid using oob_stack for storing location information. Use ...
15232 (_mark_): ... this. New (empty) rule. Saves the current location
15234 (foreach_statement): Avoid using oob_stack for current_block
15235 handling. Use technique used in for_statement and
15236 using_statement. Synthesize a value for the code block to store
15237 additional intermediate information.
15239 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15241 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15242 of a different type is only allowed to private fields of a
15243 containing type, not on fields of a base class.
15245 See test-174.cs and error cs0122-9.cs
15247 2005-01-13 Raja R Harinath <rharinath@novell.com>
15249 Fix test-335.cs (bug #58126).
15250 * cs-parser.jay (argument): Split out non-expression parts of the
15251 rule into 'non_simple_argument'.
15252 (invocation_expression): Support parenthesized invocations with
15253 multiple arguments, and with single non-simple arguments.
15255 2005-01-13 Raja R Harinath <rharinath@novell.com>
15257 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15260 2005-01-12 Raja R Harinath <rharinath@novell.com>
15262 Fix cs0038-1.cs, cs1640-6.cs.
15263 * ecore.cs (Expression.Resolve): Remove special-case for
15264 SimpleName in error-handling.
15265 (Expression.almostMatchedMembers): Relax access permission to
15267 (Expression.MemberLookupFailed): Handle duplicates in
15268 almostMatchedMembers list.
15269 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15270 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15271 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15272 overload if the passed in MemberInfo is a MethodBase.
15274 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15277 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15278 for non-CAS & merge permission sets properly.
15280 2005-01-11 Raja R Harinath <rharinath@novell.com>
15282 Improve standard-compliance of simple name and member access
15283 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15284 * ecore.cs (FullNamedExpression): New abstract base class
15285 for Namespaces and TypeExpressions.
15286 (ResolveFlags.SimpleName): Remove.
15287 (SimpleName): Remove support for dotted names.
15288 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15289 DeclSpace.FindType and DeclSpace.LookupType.
15290 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15291 (Expression.ExprClassName): Make member function.
15292 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15293 a namespace. Remove creation of dotted "SimpleName"s.
15294 (MemberAccess.DoResolve): Likewise.
15295 * decl.cs (DeclSpace.Cache): Make private.
15296 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15297 (DeclSpace.FindType): Update.
15298 (DeclSpace.LookupType): Move here from RootContext. Return a
15299 FullNamedExpression.
15300 * namespace.cs (Namespace): Derive from FullNamedExpression
15301 so that it can be part of expression resolution.
15302 (Namespace.Lookup): Return an FullNamedExpression.
15303 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15305 * rootcontext.cs (NamespaceLookup): Remove.
15306 (LookupType): Move to DeclSpace.
15307 * attribute.cs (CheckAttributeType): Update.
15308 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15309 (FindDocumentedTypeNonArray): Likewise.
15311 2005-01-11 Raja R Harinath <rharinath@novell.com>
15313 Fix cs0509.cs, cs1632.cs.
15314 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15315 is the same as IsInterface.
15316 (TypeContainer.GetClassBases): Likewise.
15317 * statement.cs (LabeledStatement.ig): New field.
15318 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15320 (LabeledStatement.DoEmit): Check that the label was created with
15321 the same ILGenerator.
15323 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15326 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15327 accessors to its properties.
15329 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15330 from accessors to property.
15332 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15335 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15336 only for overrides.
15338 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15340 * attribute.cs: Check for null and empty strings.
15342 I have lost another battle to Paolo.
15344 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15347 * class.cs (PropertyMethod): Set Parent field in ctors.
15348 (SetMethod.InternalParameters): Add unsafe switch hack.
15349 Override MarkForDuplicationCheck where it is appropriate.
15351 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15352 It says whether container allows members with the same name.
15353 Base default is no.
15354 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15355 Removed is_method parameter.
15357 2005-01-06 Duncan Mak <duncan@ximian.com>
15359 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15360 because the previous change led to incorrect reporting of CS1032
15361 ("Cannot define/undefine preprocessor symbols after first token in
15362 file"). Instead of using `tokens_seen' as the only flag that
15363 triggers CS1040, introduce `comments_seen'. This new flag is used
15364 to signify having seen comments on the current line, so it is
15365 unset after a newline.
15367 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15369 * doc.cs : When searching for a type, find nested type too.
15370 This fixes bug #71040.
15372 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15375 - Warn missing member comment on those classes which also does not
15376 have doc comments. Fixed bug #71041.
15377 - Don't warn missing doc comment on default constructor.
15380 2005-01-06 Duncan Mak <duncan@ximian.com>
15382 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15383 comments, set `tokens_seen' to true. This allows us to detect
15384 misplaced preprocessor directives (i.e. not at the beginning of
15385 the a line, nor after whitespaces). In that case, report error
15386 CS1040. This fixes bug #56460.
15388 * cs-parser.jay (interface_member_declaration): Add checks for
15389 IsExplicitImpl, and report CS0541 error if an interface member is
15390 defined as an explicit interface declaration.
15392 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15395 * class.cs (PropertyMethod): Set Parent field in ctors.
15396 (SetMethod.InternalParameters): Add unsafe switch hack.
15398 * decl.cs (MemberCore.Parent): Cannot be readonly.
15400 2005-01-06 Raja R Harinath <rharinath@novell.com>
15402 * decl.cs (DeclSpace.ResolveType): Remove.
15403 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15404 Merge in code from ...
15405 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15406 * class.cs, enum.cs: Update to changes.
15408 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15410 * anonymous.cs: Ensure that we init the scope of our parent if it
15411 has not been initialized yet.
15413 2004-12-30 Duncan Mak <duncan@ximian.com>
15415 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15416 if field.FieldBuilder is null. Fixes #70758.
15418 * convert.cs: Fixed some typos and updated some of the comments.
15419 (ImplicitStandardConversionExists):
15420 (TryImplicitIntConversion): If `target_type' is an interface and
15421 the type of `ic' implements this interface, return true or a new
15422 BoxedCast instead of null. This fixes #70468.
15424 2004-12-29 Duncan Mak <duncan@ximian.com>
15426 * expression.cs (Argument.Emit): Check that Expr is
15427 IMemoryLocation before casting to it, and report CS1510 otherwise.
15431 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15433 * statement.cs (Block.ThisVariable): remove the recursion here, to
15434 make the --profile more sane.
15436 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15438 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15439 assembly, by JB Evain.
15441 2004-12-17 Raja R Harinath <rharinath@novell.com>
15443 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15444 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15445 "parent" refers to enclosing type/class. "base" refers to superclass.
15447 2004-12-17 Raja R Harinath <rharinath@novell.com>
15449 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15450 Ensure that we only have GlobalAttributes.
15451 * attribute.cs (Attribute.Emit): Make non-virtual.
15452 (GlobalAttribute.Emit): Remove.
15453 (Attribute.Resolve): Make virtual.
15454 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15455 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15456 the argument. Don't create one.
15457 (Attribute.GetObsoleteAttribute): Likewise.
15458 (Attribute.GetClsCompliantAttributeValue): Likewise.
15459 * class.cs, decl.cs: Update to changes.
15461 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15463 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15465 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15467 * statement.cs (Foreach.Resolve): Add error 186 report.
15469 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15471 * expression.cs (Conditional.DoResolve): Add warning 429.
15473 * statement.cs (If.Resolve): Add warning 665.
15475 2004-12-16 Raja R Harinath <rharinath@novell.com>
15477 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15478 except when in the parser, and in GlobalAttribute.
15479 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15480 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15481 RootContext.Tree.Types.NamespaceEntry once work is done.
15482 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15483 and resets RootContext.Tree.Types.NamespaceEntry.
15485 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15487 * cs-parser.jay: Don't create a block for every variable.
15489 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15491 * location.cs: Provide extra information.
15493 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15494 variables from the captured environment, it is the ldarg_0.
15496 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15498 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15501 * class.cs: Changed warning level for 169 to avoid developer
15502 displeasure from warning flooding. It will be changed back when they
15503 fix most of current BCL warnings.
15505 * RootContext.cs: Pushed default WarningLevel to 3.
15507 * statement.cs: Removed unused variable.
15509 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15511 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15512 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15513 Add error 502 report.
15514 (StaticClass.DefineType): Add error 441 report.
15515 (Class.AllowedModifiersProp): New virtual property as temporary
15516 extension to AllowedModifiers.
15517 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15518 to share implementation with StaticClass and don't call virtual
15521 * driver.cs (MainDriver): Add error 1558 test.
15523 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15524 report. Moved error 36 test here.
15526 * statement.cs (Throw.Resolve): Add error 724 report.
15528 * typemanager.cs: Add out_attribute_type core type.
15530 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15532 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15534 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15536 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15539 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15541 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15542 Add error 3023 report.
15543 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15545 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15548 2004-12-12 John Luke <john.luke@gmail.com>
15550 * driver.cs (AddArgs): take -- into account when
15551 adding arguments, fixes bug 65710
15553 2004-12-12 Martin Baulig <martin@ximian.com>
15555 * expression.cs (Unary.TryReduceNegative): Added support for
15556 SByteConstant and ByteConstant.
15557 (Unary.Reduce): Check error values from TryReduceNegative().
15559 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15561 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15562 and report exception as error 182.
15564 2004-12-10 Raja R Harinath <rharinath@novell.com>
15566 * driver.cs (Main): Fix message when there are warnings.
15568 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15570 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15572 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15574 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15575 Reduced number of warnings.
15577 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15579 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15581 * driver.cs: Removed message.
15583 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15585 2004-12-08 <vargaz@freemail.hu>
15587 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15589 2004-12-08 Martin Baulig <martin@ximian.com>
15591 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15592 instead of a CS3002 for properties and indexer.
15594 2004-12-08 Martin Baulig <martin@ximian.com>
15596 * decl.cs (MemberName.ToString): Make this work again.
15598 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15600 * attribute.cs (Resolve): Add error 591 detection.
15602 * class.cs (FieldMember.Define): Add error 1547 detection.
15603 (Indexer.Define): Add error 620 detection.
15604 (Operator.Define): Add error 590 detection.
15606 * ecore.cs: Missing argument for error 79.
15608 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15611 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15614 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15617 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15619 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15620 Some operator comments were suppressed.
15621 * doc.cs : Implicit/explicit operator name in doc comments are like
15622 "op_Explicit(type)~returnType", so added suffix handling.
15624 2004-12-07 Martin Baulig <martin@ximian.com>
15627 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15628 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15629 (DeclSpace.ec): New protected field; store the EmitContext here.
15630 (DeclSpace.EmitContext): New public property; moved here from
15632 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15635 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15636 (Enum.Emit): Don't create a new EmitContext.
15638 * delegate.cs (Delegate.DefineType): Always create the
15641 * iterators.cs (Iterators.DefineIterator): Create a new
15642 EmitContext and store it in `ec'.
15644 2004-08-24 Martin Baulig <martin@ximian.com>
15647 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15648 this for accessibility checks.
15649 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15650 IsNestedFamilyAccessible.
15651 (TypeManager.IsSubclassOf): New method, do what the name actually
15654 2004-12-06 Raja R Harinath <rharinath@novell.com>
15656 Fix crash on cs0657-17.cs.
15657 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15658 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15659 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15660 the case where the NamespaceEntry gets overwritten.
15662 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15664 Fixed #69195, #56821
15665 * ecore.cs (ResolveBoolean): Tiny refactoring.
15667 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15668 of right expression resolving when left is false constant and
15669 operator is LogicalAnd OR true constant and operator is LogicalOr.
15671 * statement.cs (ResolveUnreachable): Always reports warning.
15673 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15675 * class.cs: Distinguish between 1721 and 1722 (just a little help
15676 for the programmer).
15678 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15680 * delegate.cs: Only allow this on new versions of the language.
15682 2004-12-02 Duncan Mak <duncan@ximian.com>
15684 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15686 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15687 here as a static method. Take an additional bool out parameter
15688 `must_do_cs1540_check' for signaling to InstanceResolve.
15689 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15690 member field from PropertyExpr class and made it an argument of
15691 the method instead.
15692 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15693 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15694 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15695 and `remove_accessor' as well as InstanceResolve: report CS0122
15700 2004-12-03 Raja R Harinath <rharinath@novell.com>
15702 Fix test-327.cs, test-328.cs, and put in early infrastructure
15703 for eventually fixing #52697.
15704 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15705 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15706 from other methods.
15707 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15708 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15709 (VerifyUsing, error246): Update.
15710 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15711 'NamespaceEntry.LookupNamespaceOrType'.
15713 2004-12-03 Martin Baulig <martin@ximian.com>
15715 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15716 method as our child, call AnonymousMethod.Compatible() on it.
15718 2004-12-03 Raja R Harinath <rharinath@novell.com>
15720 Disable XML documentation support in 'basic' profile.
15721 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15722 Redirect XmlElement to System.Object.
15723 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15724 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15725 * mcs.exe.sources: Add doc-bootstrap.cs.
15726 * doc-bootstrap.cs: New file. Contains empty stub implementation
15729 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15731 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15732 comments are allowed.
15734 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15736 * delegate.cs: Add checks for subtypes in paramaters and return values
15737 in VerifyMethod () to add support for Covariance/Contravariance
15740 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15742 * report.cs: Remove extra closing parenthesis.
15744 * convert.cs (Error_CannotImplicitConversion): If the name of the
15745 types are the same, provide some extra information.
15747 * class.cs (FieldBase): Use an unused bit field from the field to
15748 encode the `has_offset' property from the FieldMember. This saves
15749 a couple of Ks on bootstrap compilation.
15751 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15752 method as our child, return the AnonymousMethod resolved
15755 * expression.cs (New.DoResolve): Allow return values from
15756 NewDelegate to also include AnonymousMethods.
15760 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15763 * attribute.cs (Resolve): Improved implementation of params
15764 attribute arguments.
15766 * support.cs (ParameterData): Add HasParams to be faster.
15768 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15770 all things are for /doc support:
15772 * doc.cs: new file that supports XML documentation generation.
15773 * mcs.exe.sources: added doc.cs.
15775 Handle /doc command line option.
15776 Report error 2006 instead of 5 for missing file name for /doc.
15777 Generate XML documentation when required, after type resolution.
15779 Added support for picking up documentation (/// and /** ... */),
15780 including a new XmlCommentState enumeration.
15782 Added lines to fill Documentation element for field, constant,
15783 property, indexer, method, constructor, destructor, operator, event
15784 and class, struct, interface, delegate, enum.
15785 Added lines to warn incorrect comment.
15787 Added Documentation field (passed only when /doc was specified).
15789 Added DocComment, DocCommentHeader, GenerateDocComment() and
15790 OnGenerateDocComment() and some supporting private members for
15791 /doc feature to MemberCore.
15793 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15795 Added overriden DocCommentHeader.
15797 Added overriden DocCommentHeader and GenerateDocComment().
15799 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15801 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15802 unwrapping the enumeration values, chain to
15803 DoConstantNumericPromotions again, so we can promote things to the
15804 fundamental types (takes care of enums that are bytes, sbytes).
15808 2004-12-01 Raja R Harinath <rharinath@novell.com>
15810 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15811 Fix long-standing bug in type-lookup. Use FindType instead of
15812 LookupType when ec.ResolvingTypeTree.
15813 (Attribute.ResolveType, Attribute.Resolve)
15814 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15816 (Attributes.Search): Remove internal version. Update.
15817 (Attributes.SearchMulti): Update.
15818 (Attributes.GetClsCompliantAttribute): Remove.
15819 (Attributes.GetIndexerNameAttribute): Remove.
15820 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15821 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15822 * class.cs (Indexer.Define): Likewise.
15824 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15827 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15828 MarshallByReference members access.
15830 * expression.cs: Use CheckMarshallByRefAccess;
15831 Better error CS0197 message.
15833 * report.cs: Print whole related error message.
15835 2004-11-30 Raja R Harinath <rharinath@novell.com>
15837 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15838 the current directory to help debugging.
15840 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15842 * class (GetClassBases): Better error 60 report.
15843 (EventProperty): Disabled warning 67 detection.
15845 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15848 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15850 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15853 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15856 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15858 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15860 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15862 * attribute.cs (Attribute.Resolve): Refine error reporting and
15863 report a cs0117 if the identifier does not exist, to distinguish
15864 from 0617 which is a miss-use of the actual identifier.
15866 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15867 between cs0070 and cs0079.
15869 * class.cs (MemberBase.DoDefine): When reporting a wrong
15870 accessibility level, we use MethodCore to compare instead of
15871 Method (this was a regression in some refactoring effort).
15873 So now we correctly report cs0056 again.
15875 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
15876 testing the target_type (which was known to be object_type) and
15877 not the source type (which is anonymous_method).
15879 Fixed reporting of error cs1660.
15881 * expression.cs (UserCast.Source): Expose the underlying cast.
15883 * statement.cs (Switch.SwitchGoverningType): Sort the list of
15884 allowed types to find a match to int32 first (most common).
15886 In addition, it ignores any ImplicitUserConversions that did an
15887 internal implicit conversion (as the switch statement allows only
15888 one integral conversion to exist).
15890 * class.cs (PartialContainer.Create): rename `name' to
15891 `member_name' for clarity. Then replace the string calls with a
15892 call to MemberName.GetPartialName, as now using
15893 MemberName.ToString is an error (this is due to the side effects
15894 it had, that were fixed in the past).
15896 This will restore the error reporting on a number of partial class
15897 errors that were missusing this (and getting an exception as a
15898 results, which is now just a plain textual warning, because
15899 yyparse debug output would crash otherwise).
15901 2004-11-26 Raja R Harinath <rharinath@novell.com>
15903 * Makefile (PROGRAM_INSTALL_DIR): Remove.
15905 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15907 * rootcontext.cs (LookupType): Make sure to cache lookups that
15908 don't give us a negative result. This saves about 5% of corlib
15911 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15913 * report.cs (AbstractMessage.Print): messages are sent to stderr
15915 * class.cs (TypeContainer.GetClassBases): It is an error to have a
15916 non-interface in the list of interfaces (at this point, either
15917 parent was properly set, or a base class is being listed in the
15918 interfaces section).
15920 This flags error 1722, and resolves the crash from bug 69259.
15922 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15924 * statement.cs (Using.EmitExpressionFinally): make this work right
15925 for valuetypes. Fixes 69926.
15927 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15929 * const.cs (Const.ChangeType): Cope with the "0 literal can be
15930 converted to an enum" here, before we try to change the underlying
15931 type. This code exists, but it is a different code path than the
15932 one used while encoding constants.
15934 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
15935 old bug: when converting from the null literal to a pointer,
15936 return an EmptyCast, not the NullLiteral.
15938 This fixes #69921, the recent null_type changes probably made this
15939 bug more prominent.
15941 (ImplicitReferenceConversionExists): In addition, resynchronized
15942 the code here, so it matches the same code in
15943 ImplicitReferenceConversionExists for the `from any class-type S
15944 to any interface-type T'.
15947 2004-11-25 Marek Safar <marek.safar@seznam.cz>
15949 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
15951 2004-11-24 Miguel de Icaza <miguel@ximian.com>
15953 * cs-parser.jay: Use verbosity accordingly.
15955 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15957 * expression.cs (Unary.ResolveOperator): Do not report warning;
15958 AddressOf reads from variable.
15960 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
15962 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15966 * attribute.cs (Attributable): Removed CheckTargets.
15967 (Attributes.Emit): Explicit attribute targets are tested here.
15969 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
15970 not enabled for interfaces.
15972 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
15973 (GetAssemblyName): Ouch next bug there.
15975 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15977 * expression.cs: Error 275 added.
15979 2004-11-23 Marek Safar <marek.safar@seznam.cz>
15981 Fix bug #69177 (Implemented decimal constant support)
15983 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
15984 (BinaryFold): Add DecimalConstant.
15986 * const.cs (Define): Decimal constant
15988 (ChangeType): Add decimal type handling.
15989 (LookupConstantValue): Don't set value for decimal type but
15990 emit DecimalConstantAttribute. Needed for constant optimization.
15992 * constant.cs (ToDecimal): New method.
15993 (ConvertToDecimal): New method.
15994 (IntConstant): Implemented ConvertToDecimal.
15995 (DecimalConstant.Emit): Emit optimized version for decimals in
15998 * expression.cs (ResolveOperator): Changed order of constant
15999 reduction to work correctly with native types which have
16000 overloaded operators.
16001 (ResolveMemberAccess): Extract constant value from attribute
16004 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16006 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16007 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16008 (ChangeType): Decimal is special.
16009 (TypeToCoreType): Add decimal type.
16011 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16013 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16016 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16018 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16021 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16023 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16025 * pending.cs (PendingImplementation): Grab only interfaces.
16027 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16029 * statement.cs (ForeachHelperMethods): Add location member and
16030 error 202 detection.
16032 2004-11-19 Raja R Harinath <rharinath@novell.com>
16034 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16035 automatically handled by executable.make.
16036 (PROGRAM): Make profile-specific.
16038 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16040 * expression.cs (DoResolveBase): Fixed wrong warning for out
16043 2004-11-18 Martin Baulig <martin@ximian.com>
16045 Merged latest changes into gmcs. Please keep this comment in
16046 here, it makes it easier for me to see what changed in MCS since
16047 the last time I merged.
16049 2004-11-17 Raja R Harinath <rharinath@novell.com>
16051 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16052 (TypeHandle.GetMemberCache): New.
16053 (TypeHandle.TypeHandle): Update.
16054 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16055 (TypeManager.LookupParentInterfacesCache):
16056 Rename from LookupInterfaceCache. Optimize slightly.
16057 (TypeManager.MemberLookup_FindMembers): Update.
16058 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16059 multi-type variant.
16060 (AddCacheContents): Rename from AddHashtable.
16061 * class.cs (TypeContainer.parent_container): Remove.
16062 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16063 (TypeContainer.DoDefineMembers): Don't initialize it.
16064 Update to name changes.
16066 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16068 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16069 that factors the code to check access modifiers on override.
16071 (PropertyBase): Use the code here.
16073 Patch from Lluis S'anchez, fixes bug #69361.
16075 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16077 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16078 routine that is used to report the use of a captured variable
16079 whose address has been taken.
16081 There are two checks: one when variables are being captured and
16082 the other check is when the address of a variable is taken.
16084 (because an anonymous methods might be resolved before *or* after
16085 the address has been taken) and
16087 * expression.cs (Conditional.DoResolve): Remove the special
16088 casing that Martin added to trueExpr and falseExpr being both
16089 NullLiteral. We get the right behavior now just by introducing
16090 the null_type into the compiler.
16092 * convert.cs (ExplicitConversion): Change the code to use
16093 null_type instead of testing `expr is NullLiteral'.
16094 (ImplicitConversionStandard): use null_type too.
16095 (ImplicitReferenceConversionExists): use null_type too.
16096 (ImplicitReferenceConversion): use null_type too.
16098 * literal.cs: The type of `NullLiteral' is now null_type instead
16100 (Resolve): Set the type here.
16102 * typemanager.cs: Introduce null_type.
16104 2004-11-17 Martin Baulig <martin@ximian.com>
16106 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16107 direction, like FindMembers() does. Fixes #69546, testcase is in
16110 2004-11-16 Martin Baulig <martin@ximian.com>
16112 This is based on a patch from Marek Safar, see bug #69082.
16113 Fixes bugs #63705 and #67130.
16115 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16116 method; create a MemberCache for an interface type and cache the
16119 * decl.cs (IMemberContainer.ParentContainer): Removed.
16120 (IMemberContainer.ParentCache): New property.
16121 (MemberCache.SetupCacheForInterface): Removed.
16122 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16123 to create a cache for an interface's "parent".
16125 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16128 2004-11-16 Martin Baulig <martin@ximian.com>
16130 Merged back from gmcs; these changes already went into gmcs a
16131 couple of weeks ago.
16134 (TypeManager.AddUserType): Removed the `ifaces' argument.
16135 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16137 (TypeManager.AddUserInterface): Removed.
16138 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16140 (TypeManager.GetInterfaces): Likewise.
16141 (TypeManager.GetExplicitInterfaces): Likewise.
16143 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16145 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16146 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16148 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16150 * statement.cs: Avoid adding bools to a hashtable.
16152 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16154 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16155 calling an unsafe method from a safe location.
16157 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16160 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16162 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16164 * namespace.cs (VerifyUsing): use GetPartialName instead of
16167 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16169 * statement.cs (Return.Resolve): Fix regression in typo: if
16170 `in_exc', we have to request a NeedReturnLabel, this was a typo
16171 introduced in the anonymous method check-in. Fixes #69131.
16173 * Indexers were using the ShortName when defining themselves,
16174 causing a regression in the compiler bootstrap when applying the
16175 patch from 2004-11-02 (first part), now they use their full name
16176 and the bug is gone.
16178 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16180 * driver.cs: Strip the path from the names of embedded resources. Fixes
16183 2004-11-04 Raja R Harinath <rharinath@novell.com>
16185 Fix error message regression: cs0104-2.cs.
16186 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16187 (AliasEntry.Resolve): Update.
16188 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16190 (RootContext.LookupType): Update.
16192 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16194 * cs-parser.jay: Add support for handling accessor modifiers
16195 * class: Add support port accessor modifiers and error checking,
16196 define PropertyMethod.Define as virtual (not abstract anymore)
16197 * ecore.cs: Add checking for proeprties access with access modifiers
16198 * iterators.cs: Modify Accessor constructor call based in the modified
16200 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16202 * expression.cs (StringConcat): Handle being called twice,
16203 as when we have a concat in a field init with more than two
16206 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16208 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16209 special case explicit implementations, we should always produce
16210 the .property or .event declaration.
16212 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16213 since it will not return correct data if people use this
16214 unresolved in the presence of using statements (see test-313).
16216 * class.cs (MethodData.Define): If we are an explicit interface
16217 implementation, set the method name to the full name of the
16218 interface plus the name of the method.
16220 Notice that using the method.MethodName.GetFullName() does not
16221 work, as it will only contain the name as declared on the source
16222 file (it can be a shorthand in the presence of using statements)
16223 and not the fully qualifed type name, for example:
16227 class D : ICloneable {
16228 object ICloneable.Clone () {
16232 Would produce a method called `ICloneable.Clone' instead of
16233 `System.ICloneable.Clone'.
16235 * namespace.cs (Alias.Resolve): Use GetPartialName.
16237 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16239 * cs-parser.jay: Add error 1055 report.
16241 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16243 * assign.cs (Assign.DoResolve): Only do the transform of
16244 assignment into a New if the types are compatible, if not, fall
16245 through and let the implicit code deal with the errors and with
16246 the necessary conversions.
16248 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16250 * cs-parser.jay: Add error 1031 report.
16252 * cs-tokenizer.cs: Add location for error 1038.
16254 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16256 * cs-parser.jay: Add error 1016 report.
16258 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16260 * cs-parser.jay: Add errors 1575,1611 report.
16262 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16264 * cs-parser.jay: Add error 1001 report.
16266 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16269 * attribute.cs (GetMarshal): Add method argument for
16270 caller identification.
16272 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16273 agument for GetMarshal and RuntimeMissingSupport.
16275 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16277 * attribute.cs (ExtractSecurityPermissionSet): Removed
16278 TypeManager.code_access_permission_type.
16280 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16282 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16284 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16285 for obsolete use of a variable here. Fixes regression on errors
16286 cs0619-25 and cs0619-26.
16288 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16290 Fix #62358, implemented security attribute encoding.
16292 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16293 Tests permitted SecurityAction for assembly or other types.
16294 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16295 data from SecurityPermissionAttribute to PermisionSet class.
16297 * class.cs (ApplyAttributeBuilder): Added special handling
16298 for System.Security.Permissions.SecurityAttribute based types.
16300 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16301 special handling for System.Security.Permissions.SecurityAttribute
16304 * enum.cs (ApplyAttributeBuilder): Added special handling
16305 for System.Security.Permissions.SecurityAttribute based types.
16307 * parameter.cs (ApplyAttributeBuilder): Added special handling
16308 for System.Security.Permissions.SecurityAttribute based types.
16310 * rootcontext.cs: Next 2 core types.
16312 * typemanager.cs (TypeManager.security_permission_attr_type):
16313 Built in type for the SecurityPermission Attribute.
16314 (code_access_permission_type): Build in type.
16316 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16318 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16319 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16320 all of this information into
16321 EmitContext.EmitCapturedVariableInstance.
16323 * codegen.cs (EmitCapturedVariableInstance): move here the
16324 funcionality of emitting an ldarg.0 in the presence of a
16325 remapping. This centralizes the instance emit code.
16327 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16328 then emit a load of this: it means that we have reached the
16329 topmost ScopeInfo: the one that contains the pointer to the
16330 instance of the class hosting the anonymous method.
16332 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16333 captures to the topmost CaptureContext.
16335 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16337 * expression.cs (LocalVariableReference): Move the knowledge about
16338 the iterators into codegen's EmitCapturedVariableInstance.
16340 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16342 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16343 all code paths return a value from an anonymous method (it is the
16344 same as the 161 error, but for anonymous methods).
16346 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16348 The introduction of anonymous methods in the compiler changed
16349 various ways of doing things in the compiler. The most
16350 significant one is the hard split between the resolution phase
16351 and the emission phases of the compiler.
16353 For instance, routines that referenced local variables no
16354 longer can safely create temporary variables during the
16355 resolution phase: they must do so from the emission phase,
16356 since the variable might have been "captured", hence access to
16357 it can not be done with the local-variable operations from the runtime.
16361 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16362 is a toplevel block.
16364 (ToplevelBlock): A new kind of Block, these are the blocks that
16365 are created by the parser for all toplevel method bodies. These
16366 include methods, accessors and anonymous methods.
16368 These contain some extra information not found in regular blocks:
16369 A pointer to an optional CaptureContext (for tracking captured
16370 local variables and parameters). A pointer to the parent
16373 (Return.Resolve): Catch missmatches when returning a value from an
16374 anonymous method (error 1662).
16375 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16378 (Break.Resolve): ditto.
16380 (SwitchLabel): instead of defining the labels during the
16381 resolution phase, we now turned the public ILLabel and ILLabelCode
16382 labels into methods called GetILLabelCode() and GetILLabel() that
16383 only define the label during the Emit phase.
16385 (GotoCase): Track the SwitchLabel instead of the computed label
16386 (its contained therein). Emit the code by using
16387 SwitchLabel.GetILLabelCode ().
16389 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16390 whether the Local has been captured or not.
16392 (LocalInfo.IsCaptured): New property, used to tell whether the
16393 local has been captured.
16395 * anonymous.cs: Vastly updated to contain the anonymous method
16398 The main classes here are: CaptureContext which tracks any
16399 captured information for a toplevel block and ScopeInfo used to
16400 track the activation frames for various local variables.
16402 Each toplevel block has an optional capture context associated
16403 with it. When a method contains an anonymous method both the
16404 toplevel method and the anonymous method will create a capture
16405 context. When variables or parameters are captured, they are
16406 recorded on the CaptureContext that owns them, for example:
16410 MyDelegate d = delegate {
16415 Here `a' will be recorded as captured on the toplevel
16416 CapturedContext, the inner captured context will not have anything
16417 (it will only have data if local variables or parameters from it
16418 are captured in a nested anonymous method.
16420 The ScopeInfo is used to track the activation frames for local
16421 variables, for example:
16423 for (int i = 0; i < 10; i++)
16424 for (int j = 0; j < 10; j++){
16425 MyDelegate d = delegate {
16430 At runtime this captures a single captured variable `i', but it
16431 captures 10 different versions of the variable `j'. The variable
16432 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16433 recorded on a child.
16435 The toplevel ScopeInfo will also track information like the `this'
16436 pointer if instance variables were referenced (this is necessary
16437 as the anonymous method lives inside a nested class in the host
16438 type of the method).
16440 (AnonymousMethod): Expanded to track the Toplevel, implement
16441 `AnonymousMethod.Compatible' to tell whether an anonymous method
16442 can be converted to a target delegate type.
16444 The routine now also produces the anonymous method content
16446 (AnonymousDelegate): A helper class that derives from
16447 DelegateCreation, this is used to generate the code necessary to
16448 produce the delegate for the anonymous method that was created.
16450 * assign.cs: API adjustments for new changes in
16451 Convert.ImplicitStandardConversionExists.
16453 * class.cs: Adjustments to cope with the fact that now toplevel
16454 blocks are of type `ToplevelBlock'.
16456 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16457 insteda of standard blocks.
16459 Flag errors if params arguments are passed to anonymous methods.
16461 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16462 `CurrentAnonymousMethod' which points to the current Anonymous
16463 Method. The variable points to the AnonymousMethod class that
16464 holds the code being compiled. It is set in the new EmitContext
16465 created for the anonymous method.
16467 (EmitContext.Phase): Introduce a variable and an enumeration to
16468 assist in enforcing some rules about when and where we are allowed
16469 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16470 only one that enfonces this right now).
16472 (EmitContext.HaveCaptureInfo): new helper method that returns
16473 whether we have a CapturedContext initialized.
16475 (EmitContext.CaptureVariable): New method used to register that a
16476 LocalInfo must be flagged for capturing.
16478 (EmitContext.CapturedParameter): New method used to register that a
16479 parameters must be flagged for capturing.
16481 (EmitContext.CapturedField): New method used to register that a
16482 field must be flagged for capturing.
16484 (EmitContext.HaveCapturedVariables,
16485 EmitContext.HaveCapturedFields): Return whether there are captured
16486 variables or fields.
16488 (EmitContext.EmitMethodHostInstance): This is used to emit the
16489 instance for the anonymous method. The instance might be null
16490 (static methods), this (for anonymous methods that capture nothing
16491 and happen to live side-by-side with the current method body) or a
16492 more complicated expression if the method has a CaptureContext.
16494 (EmitContext.EmitTopBlock): Routine that drives the emission of
16495 code: it will first resolve the top block, then emit any metadata
16496 and then emit the code. The split is done so that we can extract
16497 any anonymous methods and flag any captured variables/parameters.
16499 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16500 during this phase, the ILGenerator should not be used as labels
16501 and local variables declared here might not be accessible to any
16502 code that is part of an anonymous method.
16504 Exceptions to this include the temporary variables that are
16505 created by some statements internally for holding temporary
16508 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16511 (EmitContext.TemporaryReturn): This method is typically called
16512 from the Emit phase, and its the only place where we allow the
16513 ReturnLabel to be defined other than the EmitMeta. The reason is
16514 that otherwise we would have to duplicate a lot of logic in the
16515 Resolve phases of various methods that today is on the Emit
16518 (EmitContext.NeedReturnLabel): This no longer creates the label,
16519 as the ILGenerator is not valid during the resolve phase.
16521 (EmitContext.EmitThis): Extended the knowledge in this class to
16522 work in anonymous methods in addition to iterators.
16524 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16525 code is necessary on the stack to access the instance to a local
16526 variable (the variable will be accessed as a field).
16528 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16529 EmitContext.EmitAddressOfParameter): Routines to support
16530 parameters (not completed at this point).
16532 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16533 will also remove the parameters.
16535 * convert.cs (Convert): Define a `ConstantEC' which points to a
16536 null. This is just to prefity some code that uses
16537 ImplicitStandardConversion code and do not have an EmitContext
16540 The idea is to flag explicitly that at that point in time, it is
16541 known that the conversion will not trigger the delegate checking
16542 code in implicit conversions (which requires a valid
16545 Everywhere: pass new EmitContext parameter since
16546 ImplicitStandardConversionExists now requires it to check for
16547 anonymous method conversions.
16549 (Convert.ImplicitStandardConversionExists): If the type of an
16550 expression is the anonymous_method_type, and the type is a
16551 delegate, we invoke the AnonymousMethod.Compatible method to check
16552 whether an implicit conversion is possible.
16554 (Convert.ImplicitConversionStandard): Only do implicit method
16555 group conversions if the language level is not ISO_1.
16557 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16558 MethodInfo for the Invoke method. used by Delegate and
16561 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16562 method conversions if the target type is a delegate.
16564 Removed extra debugging nops.
16566 (LocalVariableReference): Turn the `local_info' into a public
16569 Add `prepared' field, the same hack used for FieldExprs to cope
16570 with composed assignments, as Local variables do not necessarily
16571 operate purely on the stack as they used to: they can be captured
16574 Add `temp' for a temporary result, like fields.
16576 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16578 It now copes with Local variables that are captured and emits the
16579 proper instance variable to load it from a field in the captured
16582 (ParameterReference.DoResolveBase): During the resolve phase,
16583 capture parameters if we are in an anonymous method.
16585 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16586 anonymous method, use the EmitContext helper routines to emit the
16587 parameter reference.
16589 * iterators.cs: Set RemapToProxy to true/false during the
16592 * parameters.cs (GetParameterByName): New helper method.
16594 * typemanager.cs (anonymous_method_type) a new type that
16595 represents an anonyous method. This is always an internal type,
16596 used as a fencepost to test against the anonymous-methodness of an
16599 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16601 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16603 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16605 2004-10-18 Martin Baulig <martin@ximian.com>
16607 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16608 `Type' directly, but call ResolveType() on it.
16609 (Catch.Resolve): Likewise.
16610 (Foreach.Resolve): Likewise.
16612 2004-10-18 Martin Baulig <martin@ximian.com>
16614 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16615 `Type' directly, but call ResolveType() on it.
16616 (Probe.DoResolve): Likewise.
16617 (ArrayCreation.LookupType): Likewise.
16618 (TypeOf.DoResolve): Likewise.
16619 (SizeOf.DoResolve): Likewise.
16621 2004-10-18 Martin Baulig <martin@ximian.com>
16623 * expression.cs (Invocation.BetterFunction): Put back
16624 TypeManager.TypeToCoreType().
16626 2004-10-18 Raja R Harinath <rharinath@novell.com>
16628 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16631 2004-10-18 Martin Baulig <martin@ximian.com>
16633 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16634 `Type' directly, but call ResolveType() on it.
16636 2004-10-18 Martin Baulig <martin@ximian.com>
16638 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16639 `Type' directly, but call ResolveType() on it.
16640 (MemberBase.DoDefine): Likewise.
16642 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16643 `Type' directly, but call ResolveType() on it.
16644 (ComposedCast.DoResolveAsTypeStep): Likewise.
16646 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16647 `Type' directly, but call ResolveType() on it.
16649 2004-10-17 John Luke <john.luke@gmail.com>
16651 * class.cs (Operator.GetSignatureForError): use CSharpName
16653 * parameter.cs (Parameter.GetSignatureForError): Returns
16654 correct name even if was not defined.
16656 2004-10-13 Raja R Harinath <rharinath@novell.com>
16659 * class.cs (TypeContainer.EmitContext): New property.
16660 (DefineNestedTypes): Create an emitcontext for each part.
16661 (MethodCore.DoDefineParameters): Use container's emitcontext.
16662 Pass type array to InternalParameters.
16663 (MemberBase.DoDefine): Use container's emitcontext.
16664 (FieldMember.Define): Likewise.
16665 (Event.Define): Likewise.
16666 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16667 Pass type array to InternalParameters.
16668 (SetIndexerMethod.GetParameterInfo): Likewise.
16669 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16670 * delegate.cs (Define): Pass emitcontext to
16671 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16672 array to InternalParameters.
16673 * expression.cs (ParameterReference.DoResolveBase): Pass
16674 emitcontext to GetParameterInfo.
16675 (ComposedCast.DoResolveAsTypeStep): Remove check on
16676 ec.ResolvingTypeTree.
16677 * parameter.cs (Parameter.Resolve): Change argument to
16678 EmitContext. Use ResolveAsTypeTerminal.
16679 (Parameter.GetSignature): Change argument to EmitContext.
16680 (Parameters.ComputeSignature): Likewise.
16681 (Parameters.ComputeParameterTypes): Likewise.
16682 (Parameters.GetParameterInfo): Likewise.
16683 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16684 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16685 * support.cs (InternalParameters..ctor): Remove variant that takes
16687 * typemanager.cs (system_intptr_expr): New.
16688 (InitExpressionTypes): Initialize it.
16690 2004-10-12 Chris Toshok <toshok@ximian.com>
16692 * cs-parser.jay: fix location for try_statement and catch_clause.
16694 2004-10-11 Martin Baulig <martin@ximian.com>
16696 * report.cs: Don't make --fatal abort on warnings, we have
16697 -warnaserror for that.
16699 2004-10-07 Raja R Harinath <rharinath@novell.com>
16701 More DeclSpace.ResolveType avoidance.
16702 * decl.cs (MemberCore.InUnsafe): New property.
16703 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16704 with newly created EmitContext.
16705 (FieldMember.Define): Likewise.
16706 * delegate.cs (Delegate.Define): Likewise.
16707 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16708 only if normal name-lookup fails.
16709 (TypeExpr.DoResolve): Enable error-checking.
16710 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16711 (SizeOf.DoResolve): Likewise.
16712 (ComposedCast.DoResolveAsTypeStep): Likewise.
16713 (StackAlloc.DoResolve): Likewise.
16714 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16715 (Block.Unsafe): New property.
16716 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16717 (Unsafe): Set 'unsafe' flag of contained block.
16718 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16719 (Fixed.Resolve): Likewise.
16720 (Catch.Resolve): Likewise.
16721 (Using.ResolveLocalVariableDecls): Likewise.
16722 (Foreach.Resolve): Likewise.
16724 2004-10-05 John Luke <john.luke@gmail.com>
16726 * cs-parser.jay: add location to error CS0175
16728 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16730 * ecore.cs (Expression.Constantity): Add support for turning null
16733 * const.cs (Const.Define): Allow constants to be reference types
16734 as long as the value is Null.
16736 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16738 * namespace.cs (NamespaceEntry.Using): No matter which warning
16739 level is set, check if this namespace name has already been added.
16741 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16743 * expression.cs: reftype [!=]= null should always use br[true,false].
16746 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16749 * attribute.cs: Enum conversion moved to
16750 GetAttributeArgumentExpression to be applied to the all
16753 2004-10-01 Raja R Harinath <rharinath@novell.com>
16755 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16756 * class.c (TypeContainer.DefineType): Flag error if
16757 base types aren't accessible due to access permissions.
16758 * decl.cs (DeclSpace.ResolveType): Move logic to
16759 Expression.ResolveAsTypeTerminal.
16760 (DeclSpace.ResolveTypeExpr): Thin layer over
16761 Expression.ResolveAsTypeTerminal.
16762 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16763 Refactor code into NestedAccess. Use it.
16764 (DeclSpace.NestedAccess): New.
16765 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16766 argument to silence errors. Check access permissions.
16767 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16768 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16769 (Cast.DoResolve): Likewise.
16770 (New.DoResolve): Likewise.
16771 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16772 (TypeOf.DoResolve): Likewise.
16774 * expression.cs (Invocation.BetterConversion): Return the Type of
16775 the better conversion. Implement section 14.4.2.3 more faithfully.
16776 (Invocation.BetterFunction): Make boolean. Make correspondence to
16777 section 14.4.2.2 explicit.
16778 (Invocation.OverloadResolve): Update.
16779 (Invocation): Remove is_base field.
16780 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16781 (Invocation.Emit): Likewise.
16783 2004-09-27 Raja R Harinath <rharinath@novell.com>
16785 * README: Update to changes.
16787 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16789 * cs-parser.jay: Reverted 642 warning fix.
16791 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16794 * decl.cs (FindMemberWithSameName): Indexer can have more than
16797 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16799 * expression.cs (LocalVariableReference.DoResolveLValue):
16800 Do not report warning 219 for out values.
16801 (EmptyExpression.Null): New member to avoid extra allocations.
16803 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16805 * cs-parser.jay: Fix wrong warning 642 report.
16807 * cs-tokenizer.cs (CheckNextToken): New helper;
16808 Inspect next character if is same as expected.
16810 2004-09-23 Martin Baulig <martin@ximian.com>
16812 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16813 (Convert.ImplicitReferenceConversionExists): Likewise.
16815 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16817 * class.cs (Operator.Define): Add error 448 and 559 report.
16819 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16821 * class.cs (MemberBase.IsTypePermitted): New protected
16822 method for checking error CS0610.
16824 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16826 * class.cs (TypeContainer.HasExplicitLayout): New property
16827 Returns whether container has StructLayout attribute set Explicit.
16828 (FieldMember): New abstract class for consts and fields.
16829 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16830 (Field): Reuse FieldMember.
16832 * const.cs (Const): Reuse FieldMember.
16834 * rootcontext.cs: EmitConstants call moved to class.
16836 2004-09-22 Martin Baulig <martin@ximian.com>
16838 Thanks to Peter Sestoft for this bug report.
16840 * expression.cs (Conditional): If both the `trueExpr' and the
16841 `falseExpr' is a NullLiteral, return a NullLiteral.
16843 2004-09-22 Martin Baulig <martin@ximian.com>
16845 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16846 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16847 for the "get_Current" call.
16849 2004-09-22 Martin Baulig <martin@ximian.com>
16851 Marek and me just fixed one of our oldest bugs: #28562 :-)
16853 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16855 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16856 we're an EnumConstant, just return that.
16857 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16858 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16859 to get the value which'll actually be written into the attribute.
16860 However, we have to use GetValue() to access the attribute's value
16863 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16865 * constant.cs (Constant.IsNegative): New abstract property
16868 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16869 (StackAlloc.DoResolve): Reused IsNegative.
16871 2004-09-21 Martin Baulig <martin@ximian.com>
16873 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
16874 if we're used in an iterator, we may be called from different
16877 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
16878 we actually have an exception block.
16880 2004-09-20 John Luke <jluke@cfl.rr.com>
16882 * class.cs, cs-parser.jay: Improve the error report for 1520:
16883 report the actual line where the error happens, not where the
16884 class was declared.
16886 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
16887 Pass location information that was available elsewhere.
16889 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
16891 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
16892 runtime to delay sign assemblies.
16894 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16896 * cs-parser.jay: Do not report the stack trace, this is barely
16899 2004-08-22 John Luke <john.luke@gmail.com>
16901 * driver.cs : check that a resource id is not already used
16902 before adding it, report CS1508 if it is, bug #63637
16904 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16906 * ecore.cs: Removed dead code.
16908 2004-09-18 Marek Safar <marek.safar@seznam.cz>
16910 * class.cs: Do not report warning CS0067 on the interfaces.
16912 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16914 * cs-parser.jay: Add error 504 report.
16916 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16918 * rootcontext.cs: WarningLevel is 4 by default now.
16920 * statement.cs (Fixed.Resolve): Do not null
16923 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16926 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
16927 deep search when property is not virtual.
16928 (PropertyExpr.ResolveAccessors): Make one call for both
16931 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16934 * statement.cs: Error 152 report constains also location.
16936 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16939 * const.cs: Explicitly set constant as static.
16941 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16944 * cs-parser.jay: Add error 1017 report.
16946 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16948 Fixed bug #59980, #64224
16949 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
16951 * typemanager.cs (IsSpecialMethod): Simplified
16953 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16955 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
16956 condition with better params.
16958 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16961 * attribute.cs (Resolve): Property has to have both
16964 2004-09-14 Martin Baulig <martin@ximian.com>
16966 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
16968 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16971 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
16972 called and is obsolete then this member suppress message
16973 when call is inside next [Obsolete] method or type.
16975 * expression.cs: Use TestObsoleteMethodUsage member.
16977 2004-09-14 Martin Baulig <martin@ximian.com>
16979 * cs-parser.jay: Sync a bit with the GMCS version.
16981 2004-09-14 Martin Baulig <martin@ximian.com>
16983 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
16984 (CSharpParser.yacc_verbose_flag): New public field.
16986 * genericparser.cs: Removed.
16988 2004-09-14 Raja R Harinath <rharinath@novell.com>
16990 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
16992 2004-09-13 Marek Safar <marek.safar@seznam.cz>
16994 * class.cs (MethodCore.CheckBase): Fix bug #65757.
16996 2004-09-10 Martin Baulig <martin@ximian.com>
16998 Backported my MemberName changes from GMCS into MCS.
17000 - we are now using a special `MemberName' class instead of using
17001 strings; in GMCS, the `MemberName' also contains the type
17004 - changed the grammar rules a bit:
17005 * the old `member_name' is now a `namespace_or_type_name':
17006 The rule is that we use `namespace_or_type_name' everywhere
17007 where we expect either a "member name" (GetEnumerator) or a
17008 "member name" with an explicit interface name
17009 (IEnumerable.GetEnumerator).
17010 In GMCS, the explicit interface name may include type arguments
17011 (IEnumerable<T>.GetEnumerator).
17012 * we use `member_name' instead of just `IDENTIFIER' for
17014 The rule is that we use `member_name' wherever a member may
17015 have type parameters in GMCS.
17017 * decl.cs (MemberName): New public class.
17018 (MemberCore.MemberName): New public readonly field.
17019 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17020 (DeclSpace): Likewise.
17022 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17023 * enum.cs (Enum.ctor): Likewise.
17025 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17027 (AliasEntry.ctor): Take a MemberName, not an Expression.
17028 (AliasEntry.UsingAlias): Likewise.
17030 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17031 (IMethodData.MemberName): Changed type from string to MemberName.
17032 (MemberBase.ExplicitInterfaceName): Likewise.
17033 (AbstractPropertyEventMethod.SetupName): Make this private.
17034 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17035 argument; compute the member name here.
17036 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17037 on the `member.MemberName' and the `prefix'.
17039 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17041 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17042 thus, we get a `MemberName' instead of a `string'. These
17043 declarations may have type parameters in GMCS.
17044 (interface_method_declaration, delegate_declaration): Likewise.
17045 (class_declaration, interface_declaration): Likewise.
17046 (method_header): Use `namespace_or_type_name' instead of
17047 `member_name'. We may be an explicit interface implementation.
17048 (property_declaration, event_declaration): Likewise.
17049 (member_name): This is now just an `IDENTIFIER', not a
17050 `namespace_or_type_name'.
17051 (type_name, interface_type): Removed.
17052 (namespace_or_type_name): Return a MemberName, not an Expression.
17053 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17054 call GetTypeExpression() on the MemberName to get an expression.
17055 (IndexerDeclaration.interface_type): Changed type from string to
17057 (MakeName): Operate on MemberName's instead of string's.
17059 2004-09-13 Raja R Harinath <rharinath@novell.com>
17062 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17063 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17064 lookup to avoid symbols introduced by 'using'.
17065 * rootcontext.cs (NamespaceLookup): Update.
17067 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17069 * class.cs (TypeContainer.DoDefineMembers): Do not call
17070 DefineDefaultConstructor for static classes.
17072 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17074 * attribute.cs (Attribute.Resolve): Add error 653 report.
17076 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17078 (Method.ApplyAttributeBuilder): Add error 685 report.
17079 (Operator.Define): Add error 564 report.
17081 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17083 * expression.cs (Invocation.DoResolve): Add error
17084 245 and 250 report.
17086 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17089 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17091 * class.cs (ConstructorInitializer.Resolve):
17092 Wrong error number (515->516).
17094 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17096 * class.cs (Indexer.Define): Add error 631 report.
17098 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17100 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17102 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17104 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17106 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17108 * cs-parser.jay: Added error CS0241 report.
17110 2004-09-10 Raja R Harinath <rharinath@novell.com>
17112 * cs-parser.jay (fixed_statement): Introduce a scope for the
17113 declaration in the 'fixed' statement.
17115 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17117 * cs-parser.jay: Added CS0230 error report.
17119 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17121 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17123 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17125 * expression.cs (Argument.Resolve): Added error CS0192 and
17128 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17130 C# 2.0 #pragma warning feature
17132 * cs-tokenizer.cs (PreProcessPragma): New method;
17133 Handles #pragma directive.
17135 * report.cs (WarningRegions): New class; Support
17136 class for #pragma warning directive. It tests whether
17137 warning is enabled for a given line.
17139 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17141 * const.cs: Add more descriptive error report, tahnks to
17144 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17146 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17148 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17150 * expression.cs: Apply patch from Ben: Remove dead code from
17151 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17152 as that code just threw an exception anwyays.
17154 * const.cs: Remove the call to the turnintoconstant, for details
17157 * literal.cs: The type of the null-literal is the null type; So
17158 we use a placeholder type (literal.cs:System.Null, defined here)
17161 * expression.cs (Conditional.DoResolve): Remove some old code that
17162 is no longer needed, conversions have been fixed.
17164 (ArrayCreationExpression.DoResolve): Return false if we fail to
17165 resolve the inner expression.
17167 2004-09-07 Raja R Harinath <rharinath@novell.com>
17170 * cs-parser.jay (delegate_declaration): Record a delegate
17171 declaration as a type declaration.
17172 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17174 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17176 * parameter.cs: Do not crash if the type can not be resolved.
17178 * expression.cs: Report errors with unsafe pointers, fixes #64896
17180 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17182 * expression.cs: Pointer arith always needs to do a conv.i
17183 if the operand is a long. fix 65320
17185 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17187 Fixed cs0619-37.cs, cs0619-38.cs
17189 * enum.cs (GetObsoleteAttribute): Removed.
17191 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17192 on Enum member is double staged. The first is tested member
17195 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17197 Fixed #56986, #63631, #65231
17199 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17200 adds member to name container.
17201 (TypeContainer.AddToTypeContainer): New method, adds type to
17203 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17204 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17205 AddOperator): Simplified by reusing AddToMemberContainer.
17206 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17208 (Method.CheckForDuplications): Fixed implementation to test all
17210 (MemberBase): Detection whether member is explicit interface
17211 implementation is now in constructor.
17212 (MemberBase.UpdateMemberName): Handles IndexerName.
17213 (Accessor): Changed to keep also location information.
17214 (AbstractPropertyEventMethod): Is derived from MemberCore.
17215 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17216 will be emited or not.
17217 (PropertyBase.AreAccessorsDuplicateImplementation):
17218 Tests whether accessors are not in collision with some method.
17219 (Operator): Is derived from MethodCore to simplify common
17222 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17224 (DeclSpace.AddToContainer): Adds the member to defined_names
17225 table. It tests for duplications and enclosing name conflicts.
17227 * enum.cs (EnumMember): Clean up to reuse the base structures
17229 2004-09-03 Martin Baulig <martin@ximian.com>
17231 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17232 into TypeContainer, to make partial classes work again.
17234 2004-09-03 Martin Baulig <martin@ximian.com>
17236 * rootcontext.cs (RootContext.V2): Removed.
17238 2004-03-23 Martin Baulig <martin@ximian.com>
17240 * expression.cs (Invocation.OverloadResolve): Added `bool
17241 may_fail' argument and use it instead of the Location.IsNull() hack.
17243 2004-09-03 Martin Baulig <martin@ximian.com>
17245 Merged latest changes into gmcs. Please keep this comment in
17246 here, it makes it easier for me to see what changed in MCS since
17247 the last time I merged.
17249 2004-09-03 Raja R Harinath <rharinath@novell.com>
17252 * expression.cs (BetterConversion): Don't allow either conversion
17253 to be null. Remove redundant implicit conversion test when 'q ==
17254 null' -- when this function is invoked, we already know that the
17255 implicit conversion exists.
17256 (BetterFunction): Assume that 'best' is non-null. Remove
17257 redundant reimplementation of IsApplicable when 'best' is null.
17258 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17259 number of arguments.
17260 (IsAncestralType): Extract from OverloadResolve.
17261 (OverloadResolve): Make robust to the MethodGroupExpr being
17262 unsorted. Implement all the logic of Section 14.5.5.1, and
17263 support overloading of methods from multiple applicable types.
17264 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17266 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17267 (RealError, Warning): Append type of report to related symbol.
17269 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17271 * enum.cs: Fixed CLS-Compliance checks for enum members.
17272 Error tests cs3008-8.cs, cs3014-8.cs
17274 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17276 Fixed bug #62342, #63102
17277 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17278 like ImplementMethod.
17280 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17282 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17285 2004-09-02 Martin Baulig <martin@ximian.com>
17287 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17288 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17291 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17293 C# 2.0 Static classes implemented
17295 * class.cs (TypeContainer): instance_constructors,
17296 initialized_fields, initialized_static_fields,
17297 default_constructor, base_inteface_types are protected to be
17298 accessible from StaticClass.
17299 (TypeContainer.DefineDefaultConstructor): New virtual method
17300 for custom default constructor generating
17301 (StaticClass): New class to handle "Static classes" feature.
17303 * cs-parser.jay: Handle static keyword on class like instance
17306 * driver.cs: Added "/langversion" command line switch with two
17307 options (iso-1, default).
17309 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17311 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17313 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17315 * delegate.cs: Style.
17317 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17319 * delegate.cs: Add seperate instance expr field for miguel.
17321 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17323 * PointerArithmetic (Resolve): make sure we are not doing
17324 pointer arith on void*. Also, make sure we are resolved
17325 by not setting eclass until resolve.
17327 All callers: Make sure that PointerArithmetic gets resolved.
17329 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17331 * ArrayCreation (LookupType): If the type does not resolve
17332 to an array, give an error.
17334 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17336 * statement.cs (Try.Resolve): Fixed bug #64222
17338 2004-08-27 Martin Baulig <martin@ximian.com>
17341 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17344 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17346 * ecore.cs (Constantify): Get underlying type via
17347 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17348 Windows in special cases.
17350 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17352 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17353 for obtaining also private methods.
17354 (GetRemoveMethod): Used GetRemoveMethod (true)
17355 for obtaining also private methods.
17357 2004-08-24 Martin Baulig <martin@ximian.com>
17359 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17360 MethodAttributes.HideBySig for operators.
17362 2004-08-23 Martin Baulig <martin@ximian.com>
17364 Back to the old error reporting system :-)
17366 * report.cs (Message): Removed.
17367 (Report.MessageData, ErrorData, WarningData): Removed.
17368 (Report.Error, Warning): Back to the old system.
17370 2004-08-23 Martin Baulig <martin@ximian.com>
17372 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17374 * class.cs (TypeContainer.ParentContainer): New public virtual
17375 method; replaces the explicit interface implementation.
17376 (ClassPart.ParentContainer): Override.
17378 2004-08-23 Martin Baulig <martin@ximian.com>
17380 * statement.cs (Switch): Added support for constant switches; see
17381 #59428 or test-285.cs.
17383 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17386 * statement.cs (GetEnumeratorFilter): Removed useless
17387 logic because C# specs is strict. GetEnumerator must be
17390 2004-08-22 Martin Baulig <martin@ximian.com>
17392 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17393 a switch and may break, reset the barrier. Fixes #59867.
17395 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17397 CLS-Compliance speed up (~5% for corlib)
17399 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17400 New method. Tests container for CLS-Compliant names
17402 * class.cs (TypeContainer.VerifyClsName): New method.
17403 Checks whether container name is CLS Compliant.
17404 (Constructor): Implements IMethodData.
17406 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17407 low-case table for CLS Compliance test.
17408 (MemberCache.VerifyClsParameterConflict): New method.
17409 Checks method parameters for CS3006 error.
17411 * enum.cs (EnumMember): Is derived from MemberCore.
17412 (Enum.VerifyClsName): Optimized for better performance.
17414 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17416 * report.cs: Renamed Error_T to Error and changed all
17419 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17421 * class.cs (TypeContainer.IndexerArrayList): New inner class
17422 container for indexers.
17423 (TypeContainer.DefaultIndexerName): New constant for default
17424 indexer name. Replaced all "Item" with this constant.
17425 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17427 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17428 DefaultMemberAttribute constructor.
17430 2004-08-05 Martin Baulig <martin@ximian.com>
17432 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17435 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17437 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17438 multi platforms problem.
17440 * compiler.csproj: Included shared files.
17442 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17444 Fix bug 60333, 55971 in the more general way
17445 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17446 Added arg_type argument for constant conversion.
17447 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17449 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17452 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17453 OperatorArrayList, MethodCoreArrayList for typecontainer
17454 containers. Changed class member types to these new types.
17455 (MethodArrayList.DefineMembers): Added test for CS0659.
17457 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17459 * cfold.cs: Synchronize the folding with the code in expression.cs
17460 Binary.DoNumericPromotions for uint operands.
17462 * attribute.cs: Revert patch from Raja, it introduced a regression
17463 while building Blam-1.2.1 (hard to isolate a test case).
17465 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17469 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17471 (MethodCore.parent_method): New member. The method we're overriding
17472 if this is an override method.
17473 (MethodCore.CheckBase): Moved from Method class and made common.
17474 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17476 (MethodCore.CheckForDuplications): New abstract method. For custom
17477 member duplication search in a container
17478 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17479 method and its return type.
17480 (Event.conflict_symbol): New member. Symbol with same name in the
17484 (MemberCache.FindMemberWithSameName): New method. The method
17485 is looking for conflict with inherited symbols.
17487 2004-08-04 Martin Baulig <martin@ximian.com>
17489 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17491 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17493 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17495 * report.cs (Message): New enum for better error, warning reference in
17497 (MessageData): New inner abstract class. It generally handles printing of
17498 error and warning messages.
17499 Removed unused Error, Warning, Message methods.
17501 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17503 Fix for cs0592-8.cs test
17505 (Attributable.ValidAttributeTargets): Made public.
17506 (Attribute.ExplicitTarget): New member for explicit target value.
17507 (Attribute.CheckTargets): Now we translate explicit attribute
17508 target to Target here.
17510 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17512 * ecore.cs (MethodGroupExpr): new IsBase property.
17514 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17516 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17517 rather than an instance expr.
17519 (DelegateCreation.Emit): Use the method group rather than
17520 the instance expression. Also, if you have base.Foo as the
17521 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17523 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17525 (NewDelegate.DoResolve): Only check for the existance of Invoke
17526 if the method is going to be needed. Use MethodGroupExpr.
17528 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17530 * expression.cs: For pointer arith., make sure to use
17531 the size of the type, not the size of the pointer to
17534 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17537 * class.cs (Class): Added error CS0502 test.
17539 2004-08-03 John Luke <jluke@cfl.rr.com>
17540 Raja R Harinath <rharinath@novell.com>
17543 * attribute.cs (Attribute.complained_before): New flag.
17544 (Attribute.ResolveType, Attribute.Resolve),
17545 (Attribute.DefinePInvokeMethod): Set it.
17546 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17548 2004-08-03 Martin Baulig <martin@ximian.com>
17550 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17551 use a user-defined operator; we still need to do numeric
17552 promotions in case one argument is a builtin type and the other
17553 one has an implicit conversion to that type. Fixes #62322.
17555 2004-08-02 Martin Baulig <martin@ximian.com>
17557 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17558 (LocalInfo.IsThis): New public property.
17559 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17561 2004-08-01 Martin Baulig <martin@ximian.com>
17563 * class.cs (TypeContainer.GetClassBases): Don't set the default
17564 here since we may get called from GetPartialBases().
17565 (TypeContainer.DefineType): If GetClassBases() didn't return a
17566 parent, use the default one.
17568 2004-07-30 Duncan Mak <duncan@ximian.com>
17570 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17572 2004-07-30 Martin Baulig <martin@ximian.com>
17574 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17576 * class.cs (SourceMethod): New public class, derive from the
17577 symbol writer's ISourceMethod.
17578 (Method): Use the new symbol writer API.
17580 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17581 as argument and use the new symbol writer.
17584 (SourceFile): Implement the symbol writer's ISourceFile.
17585 (Location.SymbolDocument): Removed.
17586 (Location.SourceFile): New public property.
17588 * symbolwriter.cs: Use the new symbol writer API.
17590 2004-07-30 Raja R Harinath <rharinath@novell.com>
17592 * Makefile (install-local): Remove. Functionality moved to
17595 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17597 * Makefile: Install mcs.exe.config file together with mcs.exe.
17598 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17599 correct runtime version.
17601 2004-07-25 Martin Baulig <martin@ximian.com>
17604 (TypeContainer.RegisterOrder): Removed, this was unused.
17605 (TypeContainer, interface_order): Removed.
17606 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17607 TypeContainer as argument since we can also be called with a
17608 `PartialContainer' for a partial class/struct/interface.
17609 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17610 of checking whether we're an `Interface' - we could be a
17611 `PartialContainer'.
17612 (PartialContainer.Register): Override; call
17613 AddClass()/AddStruct()/AddInterface() on our parent.
17615 * cs-parser.jay (interface_member_declaration): Add things to the
17616 `current_container', not the `current_class'.
17618 * rootcontext.cs (RegisterOrder): The overloaded version which
17619 takes an `Interface' was unused, removed.
17621 * typemanager.cs (TypeManager.LookupInterface): Return a
17622 `TypeContainer', not an `Interface'.
17623 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17624 contain a `PartialContainer' for an interface, so check it's
17625 `Kind' to figure out what it is.
17627 2004-07-25 Martin Baulig <martin@ximian.com>
17629 * class.cs (Class.DefaultTypeAttributes): New public constant.
17630 (Struct.DefaultTypeAttributes): Likewise.
17631 (Interface.DefaultTypeAttributes): Likewise.
17632 (PartialContainer.TypeAttr): Override this and add the
17633 DefaultTypeAttributes.
17635 2004-07-25 Martin Baulig <martin@ximian.com>
17637 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17638 we can just use the `Parent' field instead.
17640 2004-07-25 Martin Baulig <martin@ximian.com>
17642 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17644 2004-07-25 Martin Baulig <martin@ximian.com>
17646 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17647 our parts before defining any methods.
17648 (TypeContainer.VerifyImplements): Make this virtual.
17649 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17650 on our PartialContainer.
17652 2004-07-25 Martin Baulig <martin@ximian.com>
17654 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17656 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17657 argument, we can just use the `Parent' field instead.
17660 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17661 (MemberBase.DoDefine): Likewise.
17663 2004-07-24 Martin Baulig <martin@ximian.com>
17665 * decl.cs (MemberCore.Parent): New public field.
17666 (DeclSpace.Parent): Moved to MemberCore.
17668 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17669 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17671 (FieldBase, Field, Operator): Likewise.
17672 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17673 (EventField, Event): Likewise.
17675 2004-07-23 Martin Baulig <martin@ximian.com>
17677 * class.cs (PartialContainer): New public class.
17678 (ClassPart): New public class.
17679 (TypeContainer): Added support for partial classes.
17680 (TypeContainer.GetClassBases): Splitted some of the functionality
17681 out into GetNormalBases() and GetPartialBases().
17683 * cs-tokenizer.cs (Token.PARTIAL): New token.
17684 (Tokenizer.consume_identifier): Added some hacks to recognize
17685 `partial', but only if it's immediately followed by `class',
17686 `struct' or `interface'.
17688 * cs-parser.jay: Added support for partial clases.
17690 2004-07-23 Martin Baulig <martin@ximian.com>
17692 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17693 a `DeclSpace' and also made it readonly.
17694 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17695 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17696 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17698 * cs-parser.jay: Pass the `current_class', not the
17699 `current_container' (at the moment, this is still the same thing)
17700 to a new Method, Property, Event, Indexer or Constructor.
17702 2004-07-23 Martin Baulig <martin@ximian.com>
17704 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17705 and removed the `current_interface' one.
17706 (struct_declaration, class_declaration, interface_declaration):
17707 Set `current_class' to the newly created class/struct/interface;
17708 set their `Bases' and call Register() before parsing their body.
17710 2004-07-23 Martin Baulig <martin@ximian.com>
17712 * class.cs (Kind): New public enum.
17713 (TypeContainer): Made this class abstract.
17714 (TypeContainer.Kind): New public readonly field.
17715 (TypeContainer.CheckDef): New public method; moved here from
17717 (TypeContainer.Register): New public abstract method.
17718 (TypeContainer.GetPendingImplementations): New public abstract
17720 (TypeContainer.GetClassBases): Removed the `is_class' and
17721 `is_iface' parameters.
17722 (TypeContainer.DefineNestedTypes): Formerly known as
17724 (ClassOrStruct): Made this class abstract.
17726 * tree.cs (RootTypes): New public type.
17728 2004-07-20 Martin Baulig <martin@ximian.com>
17730 * tree.cs (Tree.RecordNamespace): Removed.
17731 (Tree.Namespaces): Removed.
17733 * rootcontext.cs (RootContext.IsNamespace): Removed.
17735 * cs-parser.jay (namespace_declaration): Just create a new
17736 NamespaceEntry here.
17738 2004-07-20 Martin Baulig <martin@ximian.com>
17740 * statement.cs (ExceptionStatement): New abstract class. This is
17741 now used as a base class for everyone who's using `finally'.
17742 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17743 our local variables before using them.
17745 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17746 virtual method. This is used by Yield.Resolve() to "steal" an
17747 outer block's `finally' clauses.
17748 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17751 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17752 version which takes an ExceptionStatement. This version must be
17753 used to create exception branchings.
17756 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17757 (Iterator.EmitMoveNext): Added exception support; protect the
17758 block with a `fault' clause, properly handle 'finally' clauses.
17759 (Iterator.EmitDispose): Run all the `finally' clauses here.
17761 2004-07-20 Martin Baulig <martin@ximian.com>
17763 * iterator.cs: This is the first of a set of changes in the
17764 iterator code. Match the spec more closely: if we're an
17765 IEnumerable, then GetEnumerator() must be called. The first time
17766 GetEnumerator() is called, it returns the current instance; all
17767 subsequent invocations (if any) must create a copy.
17769 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17771 * expression.cs: Resolve the constant expression before returning
17774 2004-07-19 Martin Baulig <martin@ximian.com>
17776 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17777 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17778 the return type of the new EmitContext.
17780 2004-07-18 Martin Baulig <martin@ximian.com>
17782 * class.cs (Property.Define): Fix iterators.
17784 * iterators.cs (Iterator.Define): Moved the
17785 `container.AddInterator (this)' call here from the .ctor; only do
17786 it if we resolved successfully.
17788 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17790 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17791 `true' for preprocessing directives that we parse. The return
17792 value indicates whether we should return to regular tokenizing or
17793 not, not whether it was parsed successfully.
17795 In the past if we were in: #if false ... #line #endif, we would
17796 resume parsing after `#line'. See bug 61604.
17798 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17799 building: IsEnumType should return true only for enums, not for
17800 enums or System.Enum itself. This fixes #61593.
17802 Likely what happened is that corlib was wrong: mcs depended on
17803 this bug in some places. The bug got fixed, we had to add the
17804 hack, which caused bug 61593.
17806 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17807 that was a workaround for the older conditions.
17809 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17811 * assign.cs: IAssignMethod has a new interface, as documented
17812 inline. All assignment code now uses this new api.
17814 * ecore.cs, expression.cs: All classes which implement
17815 IAssignMethod now use the new interface.
17817 * expression.cs (Invocation): add a hack to EmitCall so that
17818 IndexerAccess can be the target of a compound assignment without
17819 evaluating its arguments twice.
17821 * statement.cs: Handle changes in Invocation api.
17823 2004-07-16 Martin Baulig <martin@ximian.com>
17825 * iterators.cs: Rewrote this. We're now using one single Proxy
17826 class for both the IEnumerable and the IEnumerator interface and
17827 `Iterator' derives from Class so we can use the high-level API.
17829 * class.cs (TypeContainer.AddIterator): New method.
17830 (TypeContainer.DoDefineType): New protected virtual method, which
17831 is called from DefineType().
17832 (TypeContainer.DoDefineMembers): Call DefineType() and
17833 DefineMembers() on all our iterators.
17834 (TypeContainer.Emit): Call Emit() on all our iterators.
17835 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17837 * codegen.cs (EmitContext.CurrentIterator): New public field.
17839 2004-07-15 Martin Baulig <martin@ximian.com>
17842 (TypeManager.not_supported_exception_type): New type.
17844 2004-07-14 Martin Baulig <martin@ximian.com>
17846 * iterators.cs: Use real error numbers.
17848 2004-07-14 Martin Baulig <martin@ximian.com>
17850 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17851 requires this to be a System.Collection.IEnumerable and not a
17852 class implementing that interface.
17853 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17855 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17857 * class.cs: Fixed previous fix, it broke some error tests.
17859 2004-07-12 Martin Baulig <martin@ximian.com>
17861 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17864 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17866 * assign.cs (LocalTemporary): Add new argument: is_address,If
17867 `is_address' is true, then the value that we store is the address
17868 to the real value, and not the value itself.
17870 * ecore.cs (PropertyExpr): use the new local temporary
17871 stuff to allow us to handle X.Y += z (where X is a struct)
17873 2004-07-08 Martin Baulig <martin@ximian.com>
17875 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
17876 not always return, just like we're doing in Using.Resolve().
17878 2004-07-07 Miguel de Icaza <miguel@ximian.com>
17880 * cs-parser.jay (fixed_statement): flag this as Pinned.
17882 2004-07-06 Miguel de Icaza <miguel@ximian.com>
17884 * typemanager.cs (TypeManager): Removed MakePinned method, this
17885 mechanism is replaced with the .NET 2.x compatible mechanism of
17886 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
17888 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
17889 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
17890 `IsFixed' property which has a different meaning.
17892 2004-07-02 Raja R Harinath <rharinath@novell.com>
17894 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
17895 visible from inside a nested class, not just the names of the
17896 immediately enclosing class.
17897 Fix for bug #60730.
17899 2004-06-24 Raja R Harinath <rharinath@novell.com>
17901 * expression.cs (BetterConversion): Remove buggy special-case
17902 handling of "implicit constant expression conversions". At this
17903 point, we already know that the conversion is possible -- we're
17904 only checking to see which is better.
17906 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17908 * cs-parser.jay: Added error CS0210 test.
17910 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17912 * cs-parser.jay: Added error CS0134 test.
17914 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17917 * cs-parser.jay: Added error CS0145 test.
17919 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17921 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
17923 2004-06-23 Ben Maurer <bmaurer@ximian.com>
17925 * expression.cs (StackAlloc.Resolve): The argument may not
17926 be a constant; deal with this case.
17928 2004-06-23 Marek Safar <marek.safar@seznam.cz>
17930 * attribute.cs (IndexerName_GetIndexerName): Renamed to
17931 GetIndexerAttributeValue.
17932 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
17934 * class.cs (Indexer.Define): Added error tests for CS0415,
17937 2004-06-23 Miguel de Icaza <miguel@ximian.com>
17939 * attribute.cs (Attribute.Resolve): Keep field code in sync with
17942 2004-06-23 Martin Baulig <martin@ximian.com>
17944 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
17945 neither return nor throw, reset the barrier as well. Fixes #60457.
17947 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
17949 * class.cs : EventAttributes is now set to None by default.
17950 This fixes bug #60459.
17952 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17955 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17956 Don't throw exception but return null (it's sufficient now).
17958 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17960 * typemanager.cs (GetArgumentTypes): Faster implementation.
17962 2004-06-18 Martin Baulig <martin@ximian.com>
17964 * attribute.cs (Attribute.Resolve): Check whether we're an
17965 EmptyCast which a Constant child. Fixes #60333.
17967 2004-06-17 Ben Maurer <bmaurer@ximian.com>
17969 * statement.cs (EmitCollectionForeach): Account for the fact that
17970 not all valuetypes are in areas which we can take the address of.
17971 For these variables, we store to a temporary variable. Also, make
17972 sure that we dont emit a `callvirt' on a valuetype method.
17974 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17976 * expression.cs (StackAlloc.DoReSolve): Added test for
17977 negative parameter (CS0247).
17979 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17982 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
17984 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17987 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
17990 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17992 Fix bug #58254 & cs1555.cs, cs1556.cs
17993 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
17995 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17997 * cs-parser.jay: Added error CS1669 test for indexers.
17999 2004-06-11 Martin Baulig <martin@ximian.com>
18001 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18002 call this twice: for params and varargs methods.
18004 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18007 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18009 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18011 * attribute.cs (Attribute.GetValidTargets): Made public.
18014 (AbstractPropertyEventMethod): New class for better code sharing.
18015 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18017 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18019 2004-06-11 Raja R Harinath <rharinath@novell.com>
18022 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18023 that the call to Resolve is part of a MemberAccess.
18024 (Expression.Resolve): Use it for SimpleName resolution.
18025 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18026 Add 'intermediate' boolean argument.
18027 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18028 error message when the SimpleName can be resolved ambiguously
18029 between an expression and a type.
18030 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18032 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18033 call on the left-side.
18035 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18038 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18040 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18042 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18044 2004-06-11 Martin Baulig <martin@ximian.com>
18046 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18047 varargs methods if applicable.
18049 2004-06-11 Martin Baulig <martin@ximian.com>
18051 * expression.cs (Invocation.EmitCall): Don't use
18052 `method.CallingConvention == CallingConventions.VarArgs' since the
18053 method could also have `CallingConventions.HasThis'.
18055 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18057 * class.cs (Event.GetSignatureForError): Implemented.
18058 Fixed crash in error test cs3010.cs
18060 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18062 * cs-tokenizer.cs: Change the way we track __arglist to be
18063 consistent with the other keywords.
18065 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18067 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18070 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18072 * codegen.cs: Check that all referenced assemblies have a strongname
18073 before strongnaming the compiled assembly. If not report error CS1577.
18074 Fix bug #56563. Patch by Jackson Harper.
18075 * typemanager.cs: Added a method to return all referenced assemblies.
18076 Fix bug #56563. Patch by Jackson Harper.
18078 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18081 (Method.ApplyAttributeBuilder): Moved and added conditional
18082 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18085 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18087 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18090 * class.cs: (EventField.attribute_targets): Changed default target.
18092 2004-06-08 Martin Baulig <martin@ximian.com>
18094 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18096 2004-06-08 Martin Baulig <martin@ximian.com>
18098 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18100 2004-06-07 Martin Baulig <martin@ximian.com>
18102 Added support for varargs methods.
18104 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18107 * cs-parser.jay: Added support for `__arglist'.
18109 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18111 * expression.cs (Argument.AType): Added `ArgList'.
18112 (Invocation): Added support for varargs methods.
18113 (ArglistAccess): New public class.
18114 (Arglist): New public class.
18116 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18118 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18119 a method's top-level block if the method has varargs.
18121 * support.cs (ReflectionParameters, InternalParameters): Added
18122 support for varargs methods.
18124 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18126 * class.cs: Provide location in indexer error report.
18128 * driver.cs: Use standard names.
18130 * namespace.cs: Catch the use of using after a namespace has been
18131 declared also on using aliases.
18133 2004-06-03 Raja R Harinath <rharinath@novell.com>
18136 * typemanager.cs (closure_private_ok, closure_invocation_type)
18137 (closure_qualifier_type, closure_invocation_assembly)
18138 (FilterWithClosure): Move to ...
18139 (Closure): New internal nested class.
18140 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18141 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18142 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18143 (MemberLookup, MemberLookupFailed): Use it.
18144 * expression.cs (New.DoResolve): Treat the lookup for the
18145 constructor as being qualified by the 'new'ed type.
18146 (Indexers.GetIndexersForTypeOrInterface): Update.
18148 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18151 (GetConditionalAttributeValue): New method. Returns
18152 condition of ConditionalAttribute.
18153 (SearchMulti): New method. Returns all attributes of type 't'.
18154 Use it when attribute is AllowMultiple = true.
18155 (IsConditionalMethodExcluded): New method.
18158 (Method.IsExcluded): Implemented. Returns true if method has conditional
18159 attribute and the conditions is not defined (method is excluded).
18160 (IMethodData): Extended interface for ConditionalAttribute support.
18161 (PropertyMethod.IsExcluded): Implemented.
18164 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18167 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18170 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18172 * expression.cs (ArrayCreationExpression): Make this just an
18173 `expression'. It can't be a statement, so the code here was
18176 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18179 * typemanager.cs (GetFullNameSignature): New method for
18182 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18185 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18186 Use this method when MethodBuilder is null.
18187 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18188 Added test for error CS0626 (MONO reports error for this situation).
18189 (IMethodData.GetSignatureForError): Extended interface.
18191 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18194 (AttributeTester.GetObsoleteAttribute): Returns instance of
18195 ObsoleteAttribute when type is obsolete.
18198 (TypeContainer.VerifyObsoleteAttribute): Override.
18199 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18200 (MethodCode.VerifyObsoleteAttribute): Override.
18201 (MemberBase.VerifyObsoleteAttribute): Override.
18204 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18205 and report proper error.
18208 Delegate.VerifyObsoleteAttribute): Override.
18211 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18212 and report proper error.
18213 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18216 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18220 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18221 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18222 Added test for ObsoleteAttribute.
18225 (Catch): Derived from Statement.
18227 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18229 Fixed bug #59071 & cs0160.cs
18231 * statement.cs (Try.Resolve): Check here whether order of catch
18232 clauses matches their dependencies.
18234 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18236 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18237 caused a regression: #59343. Referencing nested classes from an
18238 assembly stopped working.
18240 2004-05-31 Martin Baulig <martin@ximian.com>
18242 MCS is now frozen for beta 2.
18244 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18246 * convert.cs: add a trivial cache for overload operator resolution.
18248 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18250 * decl.cs: If possible, use lookuptypedirect here. We can only do
18251 this if there is no `.' after the namespace. Avoids using
18252 LookupType, which does lots of slow processing.
18253 (FindNestedType) New method, does what it says :-).
18254 * namespace.cs: use LookupTypeDirect.
18255 * rootcontext.cs: use membercache, if possible.
18256 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18258 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18261 According to the spec,
18263 In a member access of the form E.I, if E is a single identifier,
18264 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18265 field, property, localvariable, or parameter with the same type as
18266 the meaning of E as a type-name (§3.8), then both possible
18267 meanings of E are permitted.
18269 We did not check that E as a simple-name had the same type as E as
18272 This trivial check gives us 5-7% on bootstrap time.
18274 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18276 * expression.cs (Invocation.OverloadResolve): Avoid the
18277 use of hashtables and boxing here by allocating on demand.
18279 2004-05-30 Martin Baulig <martin@ximian.com>
18281 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18282 we're doing a silent lookup. Don't try to lookup nested types in
18283 TypeManager.object_type (thanks to Ben Maurer).
18285 2004-05-30 Martin Baulig <martin@ximian.com>
18287 Committing a patch from Ben Maurer.
18289 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18291 2004-05-29 Martin Baulig <martin@ximian.com>
18293 * class.cs (IMethodData.ShouldIgnore): New method.
18295 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18296 `Location' argument, we don't need it anywhere. Use
18297 `IMethodData.ShouldIgnore ()' instead of
18298 `MethodData.GetMethodFlags ()'.
18299 (TypeManager.AddMethod): Removed.
18300 (TypeManager.AddMethod2): Renamed to AddMethod.
18302 2004-05-29 Martin Baulig <martin@ximian.com>
18304 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18306 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18307 converting from a class type S to an interface type and we already
18308 have an object on the stack, don't box it again. Fixes #52578.
18310 2004-05-29 Martin Baulig <martin@ximian.com>
18312 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18313 Added support for `params' parameters. Fixes #59267.
18315 2004-05-29 Martin Baulig <martin@ximian.com>
18317 * literal.cs (NullPointer): Provide a private .ctor which sets
18318 `type' to TypeManager.object_type. Fixes #59048.
18320 2004-05-29 Martin Baulig <martin@ximian.com>
18322 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18323 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18325 * ecore.cs (EventExpr.instance_expr): Make the field private.
18327 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18329 Fixed bug #50080 & cs0214-2.cs
18330 * expression.cs (Cast.DoResolve): Check unsafe context here.
18332 * statement.cs (Resolve.DoResolve): Likewise.
18334 2004-05-26 Martin Baulig <martin@ximian.com>
18336 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18338 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18339 (RootContext.LookupType): Pass down the `silent' flag.
18341 2004-05-25 Martin Baulig <martin@ximian.com>
18344 (MethodGroupExpr.IdenticalTypeName): New public property.
18345 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18346 expression actually refers to a type.
18348 2004-05-25 Martin Baulig <martin@ximian.com>
18350 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18351 for #56176 and made it actually work.
18353 2004-05-25 Martin Baulig <martin@ximian.com>
18355 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18356 (FieldExpr, PropertyExpr): Override and implement
18357 CacheTemporaries. Fixes #52279.
18359 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18361 * location.cs: In the new compiler listing a file twice is a
18362 warning, not an error.
18364 2004-05-24 Martin Baulig <martin@ximian.com>
18366 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18367 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18369 2004-05-24 Martin Baulig <martin@ximian.com>
18371 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18372 walking the `using' list. Fixes #53921.
18374 2004-05-24 Martin Baulig <martin@ximian.com>
18376 * const.cs (Const.LookupConstantValue): Added support for
18377 EmptyCast's; fixes #55251.
18379 2004-05-24 Martin Baulig <martin@ximian.com>
18381 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18382 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18383 which does the CS0135 check. The reason is that we first need to
18384 check whether the variable actually exists.
18386 2004-05-24 Martin Baulig <martin@ximian.com>
18388 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18389 than RootContext.LookupType() to find the explicit interface
18390 type. Fixes #58584.
18392 2004-05-24 Raja R Harinath <rharinath@novell.com>
18394 * Makefile: Simplify. Use executable.make.
18395 * mcs.exe.sources: New file. List of sources of mcs.exe.
18397 2004-05-24 Anders Carlsson <andersca@gnome.org>
18401 Use the invariant culture when doing String.Compare for CLS case
18404 2004-05-23 Martin Baulig <martin@ximian.com>
18406 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18407 don't have any dots. Fixes #52622, added cs0246-8.cs.
18409 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18411 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18413 * class.cs (MemberBase.Define): Reuse MemberType member for
18414 resolved type. Other methods can use it too.
18416 2004-05-23 Martin Baulig <martin@ximian.com>
18418 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18419 the variable also exists in the current block (otherwise, we need
18420 to report a CS0103). Fixes #58670.
18422 2004-05-23 Martin Baulig <martin@ximian.com>
18424 * flowanalysis.cs (Reachability.Reachable): Compute this
18425 on-the-fly rather than storing it as a field.
18427 2004-05-23 Martin Baulig <martin@ximian.com>
18429 * flowanalysis.cs (Reachability.And): Manually compute the
18430 resulting `barrier' from the reachability.
18432 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18435 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18436 instance of ObsoleteAttribute when symbol is obsolete.
18439 (IMethodData): Extended interface for ObsoleteAttribute support.
18441 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18443 * attribute.cs: Fix bug #55970
18445 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18449 (GetObsoleteAttribute): New method. Creates the instance of
18451 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18452 ObsoleteAttribute when member is obsolete.
18453 (AttributeTester.Report_ObsoleteMessage): Common method for
18454 Obsolete error/warning reporting.
18457 (TypeContainer.base_classs_type): New member for storing parent type.
18460 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18461 for this MemberCore.
18463 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18465 * attribute.cs, const.cs: Fix bug #58590
18467 2004-05-21 Martin Baulig <martin@ximian.com>
18469 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18470 out parameters if the end of the method is unreachable. Fixes
18473 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18475 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18476 Hari was right, why extra method.
18478 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18480 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18482 2004-05-20 Martin Baulig <martin@ximian.com>
18484 Merged this back from gmcs to keep the differences to a minumum.
18486 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18487 instead of a Declspace.
18488 (Attribute.ResolveType): Likewise.
18489 (Attributes.Search): Likewise.
18490 (Attributes.Contains): Likewise.
18491 (Attributes.GetClsCompliantAttribute): Likewise.
18493 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18495 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18498 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18500 Fix bug #58688 (MCS does not report error when the same attribute
18503 * attribute.cs (Attribute.Emit): Distinction between null and default.
18505 2004-05-19 Raja R Harinath <rharinath@novell.com>
18507 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18508 of a top-level attribute without an attribute target.
18509 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18511 (Attribute.Conditional_GetConditionName),
18512 (Attribute.Obsolete_GetObsoleteMessage): Update.
18513 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18514 part of ScanForIndexerName.
18515 (Attribute.CanIgnoreInvalidAttribute): New function.
18516 (Attribute.ScanForIndexerName): Move to ...
18517 (Attributes.ScanForIndexerName): ... here.
18518 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18519 (Attributes.Search): New internal variant that can choose not to
18520 complain if types aren't resolved. The original signature now
18522 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18523 complaints suppressed.
18524 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18525 only if it not useful.
18526 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18527 top-level for attributes that are shared between the assembly
18528 and a top-level class.
18529 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18530 * class.cs: Update to reflect changes.
18531 (DefineIndexers): Fuse loops.
18532 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18533 a couple more variants of attribute names.
18535 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18537 Fix bug #52585 (Implemented explicit attribute declaration)
18540 (Attributable.ValidAttributeTargets): New abstract method. It gets
18541 list of valid attribute targets for explicit target declaration.
18542 (Attribute.Target): It holds target itself.
18543 (AttributeSection): Removed.
18544 (Attribute.CheckTargets): New method. It checks whether attribute
18545 target is valid for the current element.
18548 (EventProperty): New class. For events that are declared like
18549 property (with add and remove accessors).
18550 (EventField): New class. For events that are declared like field.
18553 * cs-parser.jay: Implemented explicit attribute target declaration.
18555 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18556 Override ValidAttributeTargets.
18559 (ReturnParameter): Class for applying custom attributes on
18561 (ParameterAtribute): New class. Class for applying custom
18562 attributes on the parameter type.
18564 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18566 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18569 (Method): Allow UNSAFE here.
18571 * modifiers.cs: Support unsafe reporting.
18573 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18575 * decl.cs: Fix bug #58478.
18577 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18579 * statement.cs: When checking for unreachable code on an EmptyStatement,
18580 set the location. Fixes bug #58488.
18582 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18584 * driver.cs: Add -pkg handling.
18586 From Gonzalo: UseShelLExecute=false
18588 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18591 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18593 (Attribute.IsClsCompliaceRequired): Moved to base for better
18595 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18596 when attribute is AttributeUsageAttribute.
18597 (Attribute.GetValidTargets): Simplified.
18598 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18599 attribute for this type.
18600 (Attribute.ApplyAttributes): Method renamed to Emit and make
18602 (GlobalAttributeSection): New class for special handling of global
18603 attributes (assembly, module).
18604 (AttributeSection.Emit): New method.
18606 * class.cs: Implemented Attributable abstract methods.
18607 (MethodCore.LabelParameters): Moved to Parameter class.
18608 (Accessor): Is back simple class.
18609 (PropertyMethod): Implemented Attributable abstract class.
18610 (DelegateMethod): Implemented Attributable abstract class.
18611 (Event): New constructor for disctintion between normal Event
18612 and Event with accessors.
18614 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18616 * codegen.cs, const.cs, decl.cs, delegate.cs:
18617 (CommonAssemblyModulClass): Implemented Attributable abstract class
18620 * enum.cs: Implement IAttributeSupport interface.
18621 (EnumMember): New class for emum members. Implemented Attributable
18625 (ParameterBase): Is abstract.
18626 (ReturnParameter): New class for easier [return:] attribute handling.
18628 * typemanager.cs: Removed builder_to_attr.
18630 2004-05-11 Raja R Harinath <rharinath@novell.com>
18633 * attribute.cs (Attribute.GetPositionalValue): New function.
18634 * class.cs (TypeContainer.VerifyMembers): New function.
18635 (TypeContainer.Emit): Use it.
18636 (ClassOrStruct): New base class for Class and Struct.
18637 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18638 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18640 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18641 then each non-static field should have a FieldOffset attribute.
18642 Otherwise, none of the fields should have a FieldOffset attribute.
18643 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18644 and FieldOffset attributes.
18645 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18646 (TypeManager.field_offset_attribute_type): New core types.
18647 (TypeManager.InitCoreTypes): Initialize them.
18649 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18651 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18652 Return correct type.
18655 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18657 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18658 be implicitly converted to ulong.
18660 * expression.cs: The logic for allowing operator &, | and ^ worked
18661 was wrong, it worked before because we did not report an error in
18662 an else branch. Fixes 57895.
18664 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18665 allow volatile fields to be reference types.
18667 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18669 * driver.cs: Add support for /debug-
18671 2004-05-07 Raja R Harinath <rharinath@novell.com>
18673 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18674 Add a 'complain' parameter to silence errors.
18675 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18676 silently overlooked type-resolutions.
18677 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18678 to reflect changes.
18679 (Attributes.Search): New function.
18680 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18681 (Attributes.GetAttributeFullName): Remove hack.
18682 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18683 Update to reflect changes.
18684 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18685 Use Attributes.Search instead of nested loops.
18687 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18690 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18691 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18692 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18694 * report.cs: (Report.Warning): Renamed to Warning_T because of
18695 parameter collision.
18697 2004-05-05 Raja R Harinath <rharinath@novell.com>
18699 * expression.cs (MemberAccess.ResolveMemberAccess):
18700 Exit with non-zero status after Report.Error.
18701 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18703 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18705 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18707 * support.cs: Don't hang when the file is empty.
18709 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18711 * support.cs: In SeekableStreamReader, compute the preamble size of the
18712 underlying stream. Position changes should take into account that initial
18715 2004-05-03 Todd Berman <tberman@sevenl.net>
18717 * driver.cs: remove unused GetSysVersion function.
18719 2004-05-03 Todd Berman <tberman@sevenl.net>
18721 * driver.cs: Remove the hack from saturday, as well as the hack
18722 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18723 link_paths to get that bit proper.
18725 2004-05-01 Todd Berman <tberman@sevenl.net>
18727 * driver.cs: Try a LoadFrom before a Load, this checks the current
18728 path. This is currently a bug in mono that is be fixed, however, this
18729 provides a workaround for now. This will be removed when the bug
18732 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18734 * CryptoConvert.cs: Updated to latest version. Fix issue with
18735 incomplete key pairs (#57941).
18737 2004-05-01 Todd Berman <tberman@sevenl.net>
18739 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18742 2004-04-30 Jackson Harper <jackson@ximian.com>
18744 * codegen.cs: Open keys readonly.
18746 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18748 * typemanager.cs: don't report cyclic struct layout when a struct
18749 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18750 which has 2 Pango.Rectangle fields.
18752 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18754 * expression.cs: Handle IntPtr comparisons with IL code
18755 rather than a method call.
18757 2004-04-29 Martin Baulig <martin@ximian.com>
18759 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18760 the list of PropertyInfo's in class hierarchy and find the
18761 accessor. Fixes #56013.
18763 2004-04-29 Martin Baulig <martin@ximian.com>
18765 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18767 2004-04-29 Martin Baulig <martin@ximian.com>
18769 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18771 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18773 2004-04-29 Martin Baulig <martin@ximian.com>
18775 * class.cs (ConstructorInitializer.Resolve): Check whether the
18776 parent .ctor is accessible. Fixes #52146.
18778 2004-04-29 Martin Baulig <martin@ximian.com>
18780 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18782 * statement.cs (Using.EmitLocalVariableDecls): Use
18783 TypeManager.idisposable_type, not typeof (IDisposable).
18784 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18786 2004-04-29 Martin Baulig <martin@ximian.com>
18788 * class.cs (Event.Define): Don't emit the field and don't set
18789 RTSpecialName and SpecialName for events on interfaces. Fixes
18792 2004-04-29 Raja R Harinath <rharinath@novell.com>
18794 Refactor Attribute.ApplyAttributes.
18795 * attribute.cs (Attributable): New base class for objects that can
18796 have Attributes applied on them.
18797 (Attribute): Make AttributeUsage fields public.
18798 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18799 (Attribute.IsInternalCall): New property.
18800 (Attribute.UsageAttr): Convert to a public read-only property.
18801 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18802 (Attribute.ResolveType, Attribute.Resolve)
18803 (Attribute.ScanForIndexerName): Update to reflect changes.
18804 (Attribute.CheckAttributeTarget): Re-format.
18805 (Attribute.ApplyAttributes): Refactor, to various
18806 Attributable.ApplyAttributeBuilder methods.
18807 * decl.cs (MemberCore): Make Attributable.
18808 * class.cs (Accessor): Make Attributable.
18809 (MethodData.ApplyAttributes): Use proper attribute types, not
18811 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18812 (TypeContainer.ApplyAttributeBuilder)
18813 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18814 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18815 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18816 (Operator.ApplyAttributeBuilder): New factored-out methods.
18817 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18818 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18819 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18820 * parameter.cs (ParameterBase): New Attributable base class
18821 that can also represent Return types.
18822 (Parameter): Update to the changes.
18824 2004-04-29 Jackson Harper <jackson@ximian.com>
18826 * driver.cs: Prefer the corlib system version when looking for
18827 assemblies in the GAC. This is still a hack, but its a better hack
18830 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18832 * decl.cs, enum.cs: Improved error 3005 reporting.
18834 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18835 (related_symbols): New private member for list of symbols
18836 related to reported error/warning.
18838 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18840 2004-04-29 Martin Baulig <martin@ximian.com>
18842 * ecore.cs (Expression.Constantify): If we're an enum and
18843 TypeManager.TypeToCoreType() doesn't give us another type, use
18844 t.UnderlyingSystemType. Fixes #56178.
18846 2004-04-29 Martin Baulig <martin@ximian.com>
18848 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18849 interfaces and for each interface, only add members directly
18850 declared in that interface. Fixes #53255.
18852 2004-04-28 Martin Baulig <martin@ximian.com>
18854 * expression.cs (ConditionalLogicalOperator): Use a temporary
18855 variable for `left' to avoid that we evaluate it more than once;
18858 2004-04-28 Martin Baulig <martin@ximian.com>
18860 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18863 2004-04-28 Martin Baulig <martin@ximian.com>
18865 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18868 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18869 whether the type is not void (CS1547).
18871 2004-04-28 Martin Baulig <martin@ximian.com>
18873 * expression.cs (Unary.DoResolveLValue): Override this and report
18874 CS0131 for anything but Operator.Indirection.
18876 2004-04-28 Martin Baulig <martin@ximian.com>
18878 Committing a patch from Ben Maurer; see bug #50820.
18880 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18883 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18886 2004-04-28 Martin Baulig <martin@ximian.com>
18888 Committing a patch from Ben Maurer; see bug #50820.
18890 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18893 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18896 2004-04-28 Martin Baulig <martin@ximian.com>
18898 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
18899 (Block.AddLabel): Call DoLookupLabel() to only search in the
18902 2004-04-28 Martin Baulig <martin@ximian.com>
18904 * cfold.cs (ConstantFold.BinaryFold): Added special support for
18905 comparing StringConstants and NullLiterals in Equality and Inequality.
18907 2004-04-28 Jackson Harper <jackson@ximian.com>
18909 * driver.cs: Attempt to load referenced assemblies from the
18910 GAC. This is the quick and dirty version of this method that
18911 doesnt take into account versions and just takes the first
18912 canidate found. Will be good enough for now as we will not have more
18913 then one version installed into the GAC until I update this method.
18915 2004-04-28 Martin Baulig <martin@ximian.com>
18917 * typemanager.cs (TypeManager.CheckStructCycles): New public
18918 static method to check for cycles in the struct layout.
18920 * rootcontext.cs (RootContext.PopulateTypes): Call
18921 TypeManager.CheckStructCycles() for each TypeContainer.
18922 [Note: We only need to visit each type once.]
18924 2004-04-28 Martin Baulig <martin@ximian.com>
18926 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
18928 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
18929 success and added `out object value'. Use a `bool resolved' field
18930 to check whether we've already been called rather than
18931 `ConstantValue != null' since this breaks for NullLiterals.
18933 2004-04-28 Raja R Harinath <rharinath@novell.com>
18935 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
18936 setting of this flag, since the 'set' method may be non-public.
18938 2004-04-28 Raja R Harinath <rharinath@novell.com>
18940 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
18941 check on current_vector.Block.
18943 2004-04-27 Martin Baulig <martin@ximian.com>
18945 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
18946 a field initializer. Fixes #56459.
18948 2004-04-27 Martin Baulig <martin@ximian.com>
18950 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
18951 we're not attempting to use an indexer. Fixes #52154.
18953 2004-04-27 Martin Baulig <martin@ximian.com>
18955 * statement.cs (Return): Don't create a return label if we don't
18956 need it; reverts my change from January 20th. Thanks to Ben
18959 2004-04-27 Martin Baulig <martin@ximian.com>
18961 According to the spec, `goto' can only leave a nested scope, but
18964 * statement.cs (Block.LookupLabel): Only lookup in the current
18965 block, don't recurse into parent or child blocks.
18966 (Block.AddLabel): Check in parent and child blocks, report
18967 CS0140/CS0158 if we find a duplicate.
18968 (Block): Removed this indexer for label lookups.
18969 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
18970 this already does the error reporting for us.
18973 (FlowBranching.UsageVector.Block): New public variable; may be null.
18974 (FlowBranching.CreateSibling): Added `Block' argument.
18975 (FlowBranching.LookupLabel): New public virtual method. Lookup a
18976 label for the target of a `goto' and check whether we're not
18977 leaving a `finally'.
18979 2004-04-27 Martin Baulig <martin@ximian.com>
18981 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
18982 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
18985 2004-04-27 Martin Baulig <martin@ximian.com>
18987 * statement.cs (Block.AddLabel): Also check for implicit blocks
18988 and added a CS0158 check.
18990 2004-04-27 Martin Baulig <martin@ximian.com>
18992 * flowanalysis.cs (FlowBranchingLoop): New class.
18993 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
18994 UsageVector's instead of an ArrayList.
18995 (FlowBranching.Label): Likewise.
18996 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
18997 (FlowBranching.AddBreakVector): New method.
18999 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19001 * attribute.cs: Small regression fix: only convert the type if we
19002 the type is different, fixes System.Drawing build.
19004 2004-04-27 Martin Baulig <martin@ximian.com>
19006 * attribute.cs (Attribute.Resolve): If we have a constant value
19007 for a named field or property, implicity convert it to the correct
19010 2004-04-27 Raja R Harinath <rharinath@novell.com>
19012 * statement.cs (Block.Block): Implicit blocks share
19013 'child_variable_names' fields with parent blocks.
19014 (Block.AddChildVariableNames): Remove.
19015 (Block.AddVariable): Mark variable as "used by a child block" in
19016 every surrounding block.
19017 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19018 been used in a child block, complain about violation of "Invariant
19019 meaning in blocks" rule.
19020 * cs-parser.jay (declare_local_variables): Don't use
19021 AddChildVariableNames.
19022 (foreach_statement): Don't create an implicit block: 'foreach'
19023 introduces a scope.
19025 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19027 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19028 converting from 0L to ulong. Fixes 57522.
19030 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19032 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19033 derived class hides via 'new' keyword field from base class (test-242.cs).
19034 TODO: Handle this in the more general way.
19036 * class.cs (CheckBase): Ditto.
19038 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19040 * decl.cs (caching_flags): New member for storing cached values
19042 (MemberCore.Flags): New enum where bit flags for caching_flags
19044 (MemberCore.cls_compliance): Moved to caching_flags.
19045 (DeclSpace.Created): Moved to caching_flags.
19047 * class.cs: Use caching_flags instead of DeclSpace.Created
19049 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19051 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19052 if we are only a derived class, not a nested class.
19054 * typemanager.cs: Same as above, but do this at the MemberLookup
19055 level (used by field and methods, properties are handled in
19056 PropertyExpr). Allow for the qualified access if we are a nested
19059 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19061 * class.cs: Refactoring.
19062 (IMethodData): New inteface; Holds links to parent members
19063 to avoid member duplication (reduced memory allocation).
19064 (Method): Implemented IMethodData interface.
19065 (PropertyBase): New inner classes for get/set methods.
19066 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19067 (Event): New inner classes for add/remove methods.
19068 (Event.DelegateMethod): Implemented IMethodData interface.
19070 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19071 EmitContext (related to class.cs refactoring).
19073 2004-04-21 Raja R Harinath <rharinath@novell.com>
19075 * delegate.cs (Delegate.VerifyApplicability): If the number of
19076 arguments are the same as the number of parameters, first try to
19077 verify applicability ignoring any 'params' modifier on the last
19081 2004-04-16 Raja R Harinath <rharinath@novell.com>
19083 * class.cs (TypeContainer.AddIndexer): Use
19084 'ExplicitInterfaceName' to determine if interface name was
19085 explicitly specified. 'InterfaceType' is not initialized at this time.
19086 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19087 Indexers array is already in the required order. Initialize
19088 'IndexerName' only if there are normal indexers.
19089 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19090 (TypeContainer.Emit): Emit DefaultMember attribute only if
19091 IndexerName is initialized.
19094 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19096 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19099 2004-04-15 Raja R Harinath <rharinath@novell.com>
19101 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19105 * attribute.cs (Attribute.Resolve): Check for duplicate named
19109 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19111 * iterators.cs (MarkYield): track whether we are in an exception,
19112 and generate code accordingly. Use a temporary value to store the
19113 result for our state.
19115 I had ignored a bit the interaction of try/catch with iterators
19116 since their behavior was not entirely obvious, but now it is
19117 possible to verify that our behavior is the same as MS .NET 2.0
19121 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19123 * iterators.cs: Avoid creating temporaries if there is no work to
19126 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19127 Enumerations, use TypeManager.EnumToUnderlying and call
19130 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19133 (This.Emit): Use EmitContext.EmitThis to emit our
19136 (This.EmitAssign): Ditto.
19138 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19139 codepaths, we will move all the functionality into
19142 (FieldExpr.EmitAssign): Ditto.
19144 This fixes several hidden bugs that I uncovered while doing a code
19145 review of this today.
19147 * codegen.cs (EmitThis): reworked so the semantics are more clear
19148 and also support value types "this" instances.
19150 * iterators.cs: Changed so that for iterators in value types, we
19151 do not pass the value type as a parameter.
19153 Initialization of the enumerator helpers is now done in the caller
19154 instead of passing the parameters to the constructors and having
19155 the constructor set the fields.
19157 The fields have now `assembly' visibility instead of private.
19159 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19161 * expression.cs (Argument.Resolve): Check if fields passed as ref
19162 or out are contained in a MarshalByRefObject.
19164 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19165 another compiler type.
19167 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19169 * class.cs (Indexer.Define): use the new name checking method.
19170 Also, return false on an error.
19171 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19172 (is_identifier_[start/part]_character): make static.
19174 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19176 * expression.cs (Binary.ResolveOperator): Do no append strings
19177 twice: since we can be invoked more than once (array evaluation)
19178 on the same concatenation, take care of this here. Based on a fix
19179 from Ben (bug #56454)
19181 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19183 * codegen.cs: Fix another case where CS1548 must be reported (when
19184 delay-sign isn't specified and no private is available #56564). Fix
19185 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19186 error when MCS is used on the MS runtime and we need to delay-sign
19187 (which seems unsupported by AssemblyBuilder - see #56621).
19189 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19191 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19192 (TypeManager.ComputeNamespaces): Faster implementation for
19195 * compiler.csproj: Updated AssemblyName to mcs.
19197 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19199 * rootcontext.cs: Add new types to the boot resolution.
19201 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19202 MulticastDelegate is not allowed.
19204 * typemanager.cs: Add new types to lookup: System.TypedReference
19207 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19208 check for TypedReference or ArgIterator, they are not allowed.
19210 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19211 makes us properly catch 1510 in some conditions (see bug 56016 for
19214 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19216 * CryptoConvert.cs: update from corlib version
19219 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19221 * class.cs (Indexer.Define): Check indexername declaration
19223 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19225 * attribute.cs (IsClsCompliant): Fixed problem with handling
19226 all three states (compliant, not-compliant, undetected).
19228 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19230 * attribute.cs (Attribute): Location is now public.
19231 (Resolve): Store resolved arguments (pos_values) in attribute class.
19232 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19233 (GetClsCompliantAttributeValue): New method that gets
19234 CLSCompliantAttribute value.
19235 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19236 if exists else null.
19237 (AttributeTester): New class for CLS-Compliant verification routines.
19239 * class.cs (Emit): Add CLS-Compliant verification.
19240 (Method.GetSignatureForError): Implemented.
19241 (Constructor.GetSignatureForError): Implemented
19242 (Constructor.HasCompliantArgs): Returns if constructor has
19243 CLS-Compliant arguments.
19244 (Constructor.Emit): Override.
19245 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19246 is needed to test only parameters.
19247 (FieldBase.GetSignatureForError): Implemented.
19248 (TypeContainer): New member for storing base interfaces.
19249 (TypeContainer.FindMembers): Search in base interfaces too.
19251 * codegen.cs (GetClsComplianceAttribute): New method that gets
19252 assembly or module CLSCompliantAttribute value.
19253 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19255 (ModuleClass.Emit): Add error 3012 test.
19257 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19259 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19260 state for all decl types.
19261 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19262 if CLS-Compliant tests are required.
19263 (IsClsCompliaceRequired): New method. Analyze whether code
19264 must be CLS-Compliant.
19265 (IsExposedFromAssembly): New method. Returns true when MemberCore
19266 is exposed from assembly.
19267 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19268 value or gets cached value.
19269 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19270 is explicitly marked with CLSCompliantAttribute.
19271 (IsIdentifierClsCompliant): New abstract method. This method is
19272 used to testing error 3005.
19273 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19274 for identifier and parameters CLS-Compliant testing.
19275 (VerifyClsCompliance): New method. The main virtual method for
19276 CLS-Compliant verifications.
19277 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19278 null. I don't know why is null (too many public members !).
19279 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19280 and get value of first CLSCompliantAttribute that found.
19282 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19283 (VerifyClsCompliance): Override and add extra tests.
19285 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19286 clscheck- disable CLS-Compliant verification event if assembly is has
19287 CLSCompliantAttribute(true).
19289 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19290 ApllyAttribute is now called in emit section as in the other cases.
19291 Possible future Emit integration.
19292 (IsIdentifierClsCompliant): New override.
19293 (VerifyClsCompliance): New override.
19294 (GetEnumeratorName): Returns full enum name.
19296 * parameter.cs (GetSignatureForError): Implemented.
19298 * report.cs (WarningData): New struct for Warning message information.
19299 (LocationOfPreviousError): New method.
19300 (Warning): New method. Reports warning based on the warning table.
19301 (Error_T): New method. Reports error based on the error table.
19303 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19304 verifications are done here.
19306 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19308 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19309 CLSCompliantAttribute.
19310 (all_imported_types): New member holds all imported types from other
19312 (LoadAllImportedTypes): New method fills static table with exported types
19313 from all referenced assemblies.
19314 (Modules): New property returns all assembly modules.
19316 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19318 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19319 throwing a parser error.
19321 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19322 which removes the hardcoded get_/set_ prefixes for properties, as
19323 IL allows for the properties to be named something else.
19327 * expression.cs: Do not override operand before we know if it is
19328 non-null. Fix 56207
19330 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19332 * typemanager.cs: support for pinned variables.
19334 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19336 * decl.cs, typemanager.cs: Avoid using an arraylist
19337 as a buffer if there is only one result set.
19339 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19341 * expression.cs: Make sure you cant call a static method
19342 with an instance expression, bug #56174.
19344 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19346 * class.cs (IsDuplicateImplementation): Improve error reporting to
19347 flag 663 (method only differs in parameter modifier).
19349 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19350 in preprocessor directives.
19352 * location.cs (LookupFile): Allow for the empty path.
19354 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19355 better approach for some of that patch, but its failing with the
19356 CharSet enumeration. For now try/catch will do.
19358 * typemanager.cs: Do not crash if a struct does not have fields.
19361 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19363 * expression.cs: cs0213, cant fix a fixed expression.
19366 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19368 * cs-parser.jay: detect invalid embeded statements gracefully.
19371 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19373 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19376 the invocation type may not be a subclass of the tye of the item/
19377 The type of the item must be a subclass of the invocation item.
19382 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19384 * attribute.cs: Added methods to get a string and a bool from an
19385 attribute. Required to information from AssemblyKeyFileAttribute,
19386 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19387 * codegen.cs: Modified AssemblyName creation to include support for
19388 strongnames. Catch additional exceptions to report them as CS1548.
19389 * compiler.csproj: Updated include CryptoConvert.cs.
19390 * compiler.csproj.user: Removed file - user specific configuration.
19391 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19392 Mono.Security assembly. The original class is maintained and tested in
19393 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19394 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19395 like CSC 8.0 (C# v2) supports.
19396 * Makefile: Added CryptoConvert.cs to mcs sources.
19397 * rootcontext.cs: Added new options for strongnames.
19399 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19401 * driver.cs: For --expect-error, report error code `2'
19402 if the program compiled with no errors, error code `1' if
19403 it compiled with an error other than the one expected.
19405 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19407 * compiler.csproj: Updated for Visual Studio .NET 2003.
19408 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19409 * compiler.sln: Updated for Visual Studio .NET 2003.
19411 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19413 * expression.cs: Fix bug #47234. We basically need to apply the
19414 rule that we prefer the conversion of null to a reference type
19415 when faced with a conversion to 'object' (csc behaviour).
19417 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19419 * statement.cs: Shorter form for foreach, eliminates
19420 a local variable. r=Martin.
19422 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19424 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19425 checks if we can use brtrue/brfalse to test for 0.
19426 * expression.cs: use the above in the test for using brtrue/brfalse.
19427 cleanup code a bit.
19429 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19431 * expression.cs: Rewrite string concat stuff. Benefits:
19433 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19434 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19435 rather than a concat chain.
19437 * typemanager.cs: Add lookups for more concat overloads.
19439 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19441 * expression.cs: Emit shorter il code for array init.
19458 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19460 * statement.cs: Before, two switch blocks would be merged if the
19461 total size of the blocks (end_item - begin_item + 1) was less than
19462 two times the combined sizes of the blocks.
19464 Now, it will only merge if after the merge at least half of the
19469 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19471 * class.cs : csc build fix for GetMethods(). See bug #52503.
19473 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19475 * expression.cs: Make sure fp comparisons work with NaN.
19476 This fixes bug #54303. Mig approved this patch a long
19477 time ago, but we were not able to test b/c the runtime
19480 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19482 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19484 2004-03-19 Martin Baulig <martin@ximian.com>
19486 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19487 error here and not in our caller.
19489 2004-03-19 Martin Baulig <martin@ximian.com>
19491 * interface.cs: Completely killed this file.
19492 (Interface): We're now a TypeContainer and live in class.cs.
19494 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19495 argument; we're now also called for interfaces.
19496 (TypeContainer.DefineMembers): Allow this method being called
19498 (TypeContainer.GetMethods): New public method; formerly known as
19499 Interface.GetMethod(). This is used by PendingImplementation.
19500 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19501 it's now private and non-static.
19502 (Interface): Moved this here; it's now implemented similar to
19504 (Method, Property, Event, Indexer): Added `bool is_interface'
19505 argument to their .ctor's.
19506 (MemberBase.IsInterface): New public field.
19508 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19509 instances instead of InterfaceMethod, InterfaceProperty, etc.
19510 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19511 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19513 2004-03-19 Martin Baulig <martin@ximian.com>
19515 * class.cs (MethodCore.IsDuplicateImplementation): New private
19516 method which does the CS0111 checking.
19517 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19518 Use IsDuplicateImplementation().
19520 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19522 * decl.cs (FindMemberToOverride): New method to find the correct
19523 method or property to override in the base class.
19525 - Make Method/Property use the above method to find the
19526 version in the base class.
19527 - Remove the InheritableMemberSignatureCompare as it is now
19530 This patch makes large code bases much faster to compile, as it is
19531 O(n) rather than O(n^2) to do this validation.
19533 Also, it fixes bug 52458 which is that nested classes are not
19534 taken into account when finding the base class member.
19536 Reviewed/Approved by Martin.
19538 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19540 * interface.cs: In all interface classes removed redundant
19541 member initialization.
19543 2004-03-16 Martin Baulig <martin@ximian.com>
19545 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19547 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19549 * decl.cs (DefineTypeAndParents): New helper method to define a
19550 type's containers before the type itself is defined; This is a
19551 bug exposed by the recent changes to Windows.Forms when an
19552 implemented interface was defined inside a class that had not been
19555 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19557 (Check): Loop correctly to report errors modifiers
19558 (UNSAFE was not in the loop, since it was the same as TOP).
19560 * interface.cs: Every interface member now takes a ModFlags,
19561 instead of a "is_new" bool, which we set on the base MemberCore.
19563 Every place where we called "UnsafeOk" in the interface, now we
19564 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19565 the unsafe settings from the member declaration instead of the
19566 container interface.
19568 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19570 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19571 `set_indexer_name' to the pending bits (one per type).
19573 We fixed a bug today that was picking the wrong method to
19574 override, since for properties the existing InterfaceMethod code
19575 basically ignored the method name. Now we make sure that the
19576 method name is one of the valid indexer names.
19578 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19580 * support.cs (SeekableStreamReader): Keep track of stream byte
19581 positions and don't mix them with character offsets to the buffer.
19583 Patch from Gustavo Giráldez
19585 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19587 * interface.cs (InterfaceSetGetBase): Removed double member
19588 initialization, base class does it as well.
19590 2004-03-13 Martin Baulig <martin@ximian.com>
19592 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19593 when compiling corlib.
19595 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19597 * convert.cs (ExplicitConversion): We were reporting an error on
19598 certain conversions (object_type source to a value type, when the
19599 expression was `null') before we had a chance to pass it through
19600 the user defined conversions.
19602 * driver.cs: Replace / and \ in resource specifications to dots.
19605 * class.cs: Add check for duplicate operators. Fixes 52477
19607 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19609 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19610 that are in the middle of the statements, not only at the end.
19613 * class.cs (TypeContainer.AddField): No longer set the
19614 `HaveStaticConstructor' flag, now we call it
19615 `UserDefineStaticConstructor' to diferentiate the slightly
19616 semantic difference.
19618 The situation is that we were not adding BeforeFieldInit (from
19619 Modifiers.TypeAttr) to classes that could have it.
19620 BeforeFieldInit should be set to classes that have no static
19625 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19627 And most importantly Zoltan's comment:
19629 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19631 "I think beforefieldinit means 'it's ok to initialize the type sometime
19632 before its static fields are used', i.e. initialization does not need
19633 to be triggered by the first access to the type. Setting this flag
19634 helps the JIT to compile better code, since it can run the static
19635 constructor at JIT time, and does not need to generate code to call it
19636 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19637 this flag for lots of classes like String.
19639 csc sets this flag if the type does not have an explicit static
19640 constructor. The reasoning seems to be that if there are only static
19641 initalizers for a type, and no static constructor, then the programmer
19642 does not care when this initialization happens, so beforefieldinit
19645 This bug prevents the AOT compiler from being usable, since it
19646 generates so many calls to mono_runtime_class_init that the AOT code
19647 is much slower than the JITted code. The JITted code is faster,
19648 because it does not generate these calls if the vtable is type is
19649 already initialized, which is true in the majority of cases. But the
19650 AOT compiler can't do this."
19652 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19654 * class.cs (MethodData.Emit): Refactor the code so symbolic
19655 information is generated for destructors; For some reasons we
19656 were taking a code path that did not generate symbolic information
19659 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19661 * class.cs: Create a Constructor.CheckBase method that
19662 takes care of all validation type code. The method
19663 contains some code that was moved from Define.
19665 It also includes new code that checks for duplicate ctors.
19666 This fixes bug #55148.
19668 2004-03-09 Joshua Tauberer <tauberer@for.net>
19670 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19671 a { ... }-style array creation invokes EmitStaticInitializers
19672 which is not good for reference-type arrays. String, decimal
19673 and now null constants (NullCast) are not counted toward
19674 static initializers.
19676 2004-03-05 Martin Baulig <martin@ximian.com>
19678 * location.cs (SourceFile.HasLineDirective): New public field;
19679 specifies whether the file contains or is referenced by a "#line"
19681 (Location.DefineSymbolDocuments): Ignore source files which
19682 either contain or are referenced by a "#line" directive.
19684 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19686 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19687 direct access to our parent, so check the method inline there.
19689 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19691 * expression.cs (Invocation.EmitCall): Miguel's last commit
19692 caused a regression. If you had:
19697 In Foo the implict this would be null.
19699 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19701 * expression.cs (Invocation.EmitCall): If the method is not
19702 virtual, do not emit a CallVirt to it, use Call.
19704 * typemanager.cs (GetFullNameSignature): Improve the method to
19705 cope with ".ctor" and replace it with the type name.
19707 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19708 as an argument the ConstructorBuilder where it is being defined,
19709 to catch the recursive constructor invocations.
19711 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19713 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19714 routines to check if a type is an enumerable/enumerator allow
19715 classes that implement the IEnumerable or IEnumerator interfaces.
19717 * class.cs (Property, Operator): Implement IIteratorContainer, and
19718 implement SetYields.
19720 (Property.Define): Do the block swapping for get_methods in the
19721 context of iterators. We need to check if Properties also
19722 include indexers or not.
19724 (Operator): Assign the Block before invoking the
19725 OperatorMethod.Define, so we can trigger the Iterator code
19728 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19729 Property and Operator classes are not created when we parse the
19730 declarator but until we have the block completed, so we use a
19731 singleton SimpleIteratorContainer.Simple to flag whether the
19732 SetYields has been invoked.
19734 We propagate this setting then to the Property or the Operator to
19735 allow the `yield' to function.
19737 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19739 * codegen.cs: Implemented attribute support for modules.
19740 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19741 Assembly/Module functionality.
19743 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19744 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19745 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19747 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19749 * interface.cs (FindMembers): The operation is performed on all base
19750 interfaces and not only on the first. It is required for future CLS Compliance patch.
19752 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19754 * statement.cs, codegen.cs:
19755 This patch deals with patterns such as:
19757 public class List : IEnumerable {
19759 public MyEnumerator GetEnumerator () {
19760 return new MyEnumerator(this);
19763 IEnumerator IEnumerable.GetEnumerator () {
19767 public struct MyEnumerator : IEnumerator {
19772 Before, there were a few things we did wrong:
19773 1) we would emit callvirt on a struct, which is illegal
19774 2) we emited ldarg when we needed to emit ldarga
19775 3) we would mistakenly call the interface methods on an enumerator
19776 type that derived from IEnumerator and was in another assembly. For example:
19778 public class MyEnumerator : IEnumerator
19780 Would have the interface methods called, even if there were public impls of the
19781 method. In a struct, this lead to invalid IL code.
19783 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19785 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19788 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19790 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19792 * cs-parser.jay: Fix small regression: we were not testing V2
19793 compiler features correctly.
19795 * interface.cs: If the emit context is null, then create one
19797 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19799 * decl.cs (GetSignatureForError): New virtual method to get full name
19800 for error messages.
19802 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19803 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19805 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19806 Duplicated members and code in these classes has been removed.
19807 Better encapsulation in these classes.
19809 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19811 * assign.cs (Assign.DoResolve): When dealing with compound
19812 assignments, there is a new rule in ECMA C# 2.4 (might have been
19813 there before, but it is documented here) that states that in:
19817 If b is of type int, and the `op' is a shift-operator, then the
19818 above is evaluated as:
19822 * expression.cs (Binary.ResolveOperator): Instead of testing for
19823 int/uint/long/ulong, try to implicitly convert to any of those
19824 types and use that in pointer arithmetic.
19826 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19827 method to print information for from the type, not from the
19828 null-method we were given.
19830 2004-02-01 Duncan Mak <duncan@ximian.com>
19832 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19833 parsing for cmd, fixes bug #53694.
19835 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19837 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19838 in the member name duplication tests. Property and operator name duplication
19839 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19841 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19843 * interface.cs (PopulateMethod): Fixed crash when interface method
19844 returns not existing type (error test cs0246-3.cs).
19846 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19848 * cs-parser.jay (interface_accessors): Re-write actions to also
19849 store attributes attached to get and set methods. Fix spelling
19852 (inteface_property_declaration): Modify accordingly.
19854 (InterfaceAccessorInfo): New helper class to store information to pass
19855 around between rules that use interface_accessors.
19857 * interface.cs (Emit): Apply attributes on the get and set
19858 accessors of properties and indexers too.
19860 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19861 right MethodBuilder when applying attributes to the get and set accessors.
19863 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19865 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19867 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19869 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19871 2004-01-25 Miguel de Icaza <miguel@ximian.com>
19873 * cs-parser.jay: Remove YIELD token, instead use the new grammar
19874 changes that treat `yield' specially when present before `break'
19875 or `return' tokens.
19877 * cs-tokenizer.cs: yield is no longer a keyword.
19879 2004-01-23 Marek Safar <marek.safar@seznam.cz>
19881 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
19882 setting for default constructors.
19883 For default constructors are almost every time set wrong Modifier. The
19884 generated IL code has been alright. But inside mcs this values was
19885 wrong and this was reason why several of my CLS Compliance tests
19888 2004-01-22 Martin Baulig <martin@ximian.com>
19890 * cs-parser.jay (namespace_or_type_name): Return an Expression,
19891 not a QualifiedIdentifier. This is what `type_name_expression'
19892 was previously doing.
19893 (type_name_expression): Removed; the code is now in
19894 `namespace_or_type_name'.
19895 (qualified_identifier): Removed, use `namespace_or_type_name'
19897 (QualifiedIdentifier): Removed this class.
19899 2004-01-22 Martin Baulig <martin@ximian.com>
19901 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
19902 not a string as alias name.
19904 2004-01-21 Miguel de Icaza <miguel@ximian.com>
19906 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
19907 #52730 bug, and instead compute correctly the need to use a
19908 temporary variable when requesting an address based on the
19909 static/instace modified of the field and the constructor.
19911 2004-01-21 Martin Baulig <martin@ximian.com>
19913 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
19914 class and namespace before looking up aliases. Fixes #52517.
19916 2004-01-21 Martin Baulig <martin@ximian.com>
19918 * flowanalysis.cs (UsageVector.Merge): Allow variables being
19919 assinged in a 'try'; fixes exception4.cs.
19921 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19922 * class.cs : Implemented parameter-less constructor for TypeContainer
19924 * decl.cs: Attributes are now stored here. New property OptAttributes
19926 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
19928 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
19930 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19932 * typemanager.cs (CSharpSignature): Now reports also inner class name.
19933 (CSharpSignature): New method for indexer and property signature.
19935 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19937 * pending.cs (IsVirtualFilter): Faster implementation.
19939 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19941 * typemanager.cs: Avoid inclusion of same assembly more than once.
19943 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19945 * cs-parser.jay: Fixed problem where the last assembly attribute
19946 has been applied also to following declaration (class, struct, etc.)
19948 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19950 * class.cs: Added error CS0538, CS0539 reporting.
19951 Fixed crash on Microsoft runtime when field type is void.
19953 * cs-parser.jay: Added error CS0537 reporting.
19955 * pending.cs: Added error CS0535 reporting.
19956 Improved error report for errors CS0536, CS0534.
19958 2004-01-20 Miguel de Icaza <miguel@ximian.com>
19960 Merge a few bits from the Anonymous Method MCS tree.
19962 * statement.cs (ToplevelBlock): New class for toplevel methods,
19963 will hold anonymous methods, lifted variables.
19965 * cs-parser.jay: Create toplevel blocks for delegates and for
19966 regular blocks of code.
19968 2004-01-20 Martin Baulig <martin@ximian.com>
19970 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
19971 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
19972 and `NeedExplicitReturn'; added `IsLastStatement'.
19973 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
19974 have a `ReturnLabel' or we're not unreachable.
19976 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
19977 child's reachability; don't just override ours with it. Fixes
19978 #58058 (lluis's example).
19979 (FlowBranching): Added public InTryOrCatch(), InCatch(),
19980 InFinally(), InLoop(), InSwitch() and
19981 BreakCrossesTryCatchBoundary() methods.
19983 * statement.cs (Return): Do all error checking in Resolve().
19984 Unless we are the last statement in a top-level block, always
19985 create a return label and jump to it.
19986 (Break, Continue): Do all error checking in Resolve(); also make
19987 sure we aren't leaving a `finally'.
19988 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
19989 statement in a top-level block.
19990 (Block.Flags): Added `IsDestructor'.
19991 (Block.IsDestructor): New public property.
19993 2004-01-20 Martin Baulig <martin@ximian.com>
19995 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
19997 2004-01-20 Martin Baulig <martin@ximian.com>
19999 * statement.cs (Statement.ResolveUnreachable): New public method.
20000 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20001 (Block.Resolve): Resolve unreachable statements.
20003 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20005 * expression.cs: We need to fix the case where we do
20006 not have a temp variable here.
20008 * assign.cs: Only expression compound assignments need
20009 temporary variables.
20011 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20013 * flowanalysis.cs: Reduce memory allocation in a few ways:
20014 - A block with no variables should not allocate a bit
20016 - A method with no out parameters does not need any tracking
20017 for assignment of the parameters, so we need not allocate
20020 public readonly Type[] VariableTypes;
20021 public readonly string[] VariableNames;
20022 Are redundant. The data is already stored in the variable
20023 map, so we need not allocate another array for it.
20024 - We need to add alot of checks for if (params | locals) == null
20025 due to the first two changes.
20027 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20029 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20030 implement IMemoryLocation, we store a copy on a local variable and
20031 take the address of it. Patch from Benjamin Jemlich
20033 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20034 to use a special "type_name_expression" rule which reduces the
20035 number of "QualifiedIdentifier" classes created, and instead
20036 directly creates MemberAccess expressions.
20038 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20040 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20041 that fixes #52853. Null literal assignment to ValueType
20043 * class.cs (MethodData.Emit): Instead of checking the name of the
20044 method to determine if its a destructor, create a new derived
20045 class from Method called Destructor, and test for that.
20047 * cs-parser.jay: Create a Destructor object instead of a Method.
20049 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20053 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20055 * expression.cs (Binary.ResolveOperator): Perform an implicit
20056 conversion from MethodGroups to their delegate types on the
20057 Addition operation.
20059 * delegate.cs: Introduce a new class DelegateCreation that is the
20060 base class for `NewDelegate' and `ImplicitDelegateCreation',
20061 factor some code in here.
20063 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20064 conversion from MethodGroups to compatible delegate types.
20066 * ecore.cs (Expression.Resolve): Do not flag error 654
20067 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20068 we allow conversions from MethodGroups to delegate types now.
20070 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20071 assignments in v2 either.
20073 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20075 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20076 static read-only fields in ctors.
20078 Applied patch from Benjamin Jemlich
20080 * expression.cs (UnaryMutator): Avoid leaking local variables.
20082 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20084 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20085 here to return true, as they can be used like this:
20087 (XXX) int.MEMBER ()
20089 Fixed 49836 and all the other dups
20091 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20093 * driver.cs: Implement /win32res and /win32icon.
20095 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20097 * cs-parser.jay: Add a rule to improve error handling for the
20098 common mistake of placing modifiers after the type.
20100 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20102 * cs-parser.jay (interface_event_declaration): Catch
20103 initialization of events on interfaces, and report cs0068
20105 * cs-parser.jay (interface_event_declaration): Catch
20106 initialization of events.
20108 * ecore.cs: Better report missing constructors.
20110 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20111 the error reporting done in the wrong place. Fix.
20113 * expression.cs (Binary.ResolveOperator): Catch the
20114 operator + (E x, E y) error earlier, and later allow for implicit
20115 conversions in operator +/- (E e, U x) from U to the underlying
20118 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20119 52596, if the container class is abstract, the default constructor
20120 is protected otherwise its public (before, we were always public).
20122 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20125 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20126 Jemlich that fixes bug #52597, MCS was generating invalid code for
20127 idisposable structs. Thanks to Ben for following up with this
20130 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20132 * driver.cs: Allow assemblies without code to be generated, fixes
20135 2004-01-07 Nick Drochak <ndrochak@gol.com>
20137 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20139 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20141 * cs-parser.jay: Add rules to improve error reporting if fields or
20142 methods are declared at the namespace level (error 116)
20144 * Add rules to catch event add/remove
20146 2004-01-04 David Sheldon <dave-mono@earth.li>
20148 * expression.cs: Added matching ")" to error message for
20151 2004-01-03 Todd Berman <tberman@gentoo.org>
20153 * ecore.cs, attribute.cs:
20154 Applying fix from #52429.
20156 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20158 * ecore.cs, expression.cs, statement.cs:
20159 Total rewrite of how we handle branching. We
20160 now handle complex boolean expressions with fewer
20161 jumps. As well if (x == 0) no longer emits a ceq.
20163 if (x is Foo) is much faster now, because we generate
20166 Overall, we get a pretty big improvement on our benchmark
20167 tests. The code we generate is smaller and more readable.
20169 I did a full two-stage bootstrap. The patch was reviewed
20170 by Martin and Miguel.
20172 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20174 * cs-parser.jay: Make primary_expression not take a QI.
20175 we dont need this because the member_access rule covers
20176 us here. So we replace the rule with just IDENTIFIER.
20178 This has two good effects. First, we remove a s/r conflict.
20179 Second, we allocate many fewer QualifiedIdentifier objects.
20181 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20183 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20184 set the correct information via SRE. This prevents
20185 hanging on the MS runtime. Fixes #29374.
20187 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20189 * convert.cs: correctly handle conversions to value types
20190 from Enum and ValueType as unboxing conversions.
20192 Fixes bug #52569. Patch by Benjamin Jemlich.
20194 2004-01-02 Ravi Pratap <ravi@ximian.com>
20196 * expression.cs (BetterConversion): Prefer int -> uint
20197 over int -> ulong (csc's behaviour). This fixed bug #52046.
20199 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20201 * decl.cs (MemberCache.FindMembers): now returns a
20204 * typemanager.cs: In general, go with with ^^.
20205 (CopyNewMethods): take an IList.
20206 (RealMemberLookup): Only allocate an arraylist
20207 if we copy from two sets of methods.
20209 This change basically does two things:
20210 1) Fewer array lists allocated due to CopyNewMethods.
20211 2) the explicit cast in MemberList costed ALOT.
20213 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20215 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20216 a hashtable to avoid needless string allocations when an identifier is
20217 used more than once (the common case).
20219 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20221 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20222 is broken, it will not return anything. So, we
20223 have to use the information we have in mcs to
20226 * typemanager.cs: Add a cache for GetInterfaces,
20227 since this will now be used more often (due to ^^)
20229 (GetExplicitInterfaces) New method that gets the
20230 declared, not effective, interfaces on a type
20231 builder (eg, if you have interface IFoo, interface
20232 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20235 This patch makes MCS able to bootstrap itself on
20238 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20240 * expression.cs: Remove the Nop's that Miguel put
20243 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20245 * report.cs, codegen.cs: Give the real stack trace to
20246 the error when an exception is thrown.
20248 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20250 * decl.cs: only allocate hashtables for ifaces if
20253 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20255 * expression.cs: fix the error from cs0121-2.cs
20256 (a parent interface has two child interfaces that
20257 have a function with the same name and 0 params
20258 and the function is called through the parent).
20260 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20262 * class.cs, rootcontext.cs, typmanager.cs: do not
20265 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20267 * codegen.cs: remove stack for the ec flow branching.
20268 It is already a linked list, so no need.
20270 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20272 * Makefile: Allow custom profiler here.
20274 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20276 * typemanager.cs (LookupType):
20277 - Use a static char [], because split takes
20278 a param array for args, so it was allocating
20280 - Do not store true in a hashtable, it boxes.
20282 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20284 * flowanalysis.cs: bytify common enums.
20286 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20288 * modifiers.cs: Add a new set of flags for the
20289 flags allowed on explicit interface impls.
20290 * cs-parser.jay: catch the use of modifiers in
20291 interfaces correctly.
20292 * class.cs: catch private void IFoo.Blah ().
20294 All related to bug #50572.
20296 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20298 * decl.cs: Rewrite the consistant accessability checking.
20299 Accessability is not linear, it must be implemented in
20300 a tableish way. Fixes #49704.
20302 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20304 * expression.cs: Handle negation in a checked context.
20305 We must use subtraction from zero. Fixes #38674.
20307 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20309 * class.cs: Ignore static void main in DLLs.
20310 * rootcontext.cs: Handle the target type here,
20311 since we are have to access it from class.cs
20312 * driver.cs: account for the above.
20314 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20316 * report.cs: Give line numbers and files if available.
20318 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20320 * driver.cs: Implement /addmodule.
20322 * typemanager.cs: Change 'modules' field so it now contains Modules not
20325 2003-12-20 Martin Baulig <martin@ximian.com>
20327 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20328 (FieldBase.IsAssigned): Removed this field.
20329 (FieldBase.SetAssigned): New public method.
20330 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20332 2003-12-20 Martin Baulig <martin@ximian.com>
20334 * expression.cs (LocalVariableReference.DoResolve): Don't set
20335 `vi.Used' if we're called from DoResolveLValue().
20337 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20338 returns the usage vector it just merged into the current one -
20339 pass this one to UsageWarning().
20340 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20341 of the `EmitContext', don't call this recursively on our children.
20343 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20345 * driver.cs: Implement /target:module.
20347 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20349 * support.cs (CharArrayHashtable): New helper class.
20351 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20352 char arrays, not strings, so we can avoid creating a string in
20353 consume_identifier if the identifier is a keyword.
20355 2003-12-16 Martin Baulig <martin@ximian.com>
20357 * statement.cs (LocalInfo.Assigned): Removed this property.
20358 (LocalInfo.Flags): Removed `Assigned'.
20359 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20360 and uses flow analysis.
20361 (Block.UsageWarning): Made this method private.
20362 (Block.Resolve): Call UsageWarning() if appropriate.
20364 * expression.cs (LocalVariableReference.DoResolve): Always set
20365 LocalInfo.Used here.
20367 2003-12-13 Martin Baulig <martin@ximian.com>
20369 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20370 any value here; we're now using flow analysis to figure out
20371 whether a statement/block returns a value.
20373 2003-12-13 Martin Baulig <martin@ximian.com>
20375 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20377 (FlowBranching.MergeFinally): Don't call
20378 `branching.CheckOutParameters()' here, this is called in
20380 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20381 when adding the `finally' vector.
20383 2003-12-13 Martin Baulig <martin@ximian.com>
20386 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20387 actually work and also fix #48962.
20389 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20391 * decl.cs: Do not check System.Object for nested types,
20392 since we know it does not have any. Big bang for buck:
20395 Run 1: 8.35 seconds
20396 Run 2: 8.32 seconds
20397 corlib: 17.99 seconds
20399 Run 1: 8.17 seconds
20400 Run 2: 8.17 seconds
20401 corlib: 17.39 seconds
20403 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20405 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20406 time we are returning 0 members, so we save alot here.
20408 2003-12-11 Martin Baulig <martin@ximian.com>
20410 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20411 `MergeChild()', also just take the `FlowBranching' as argument;
20412 call Merge() on it and return the result.
20413 (FlowBranching.Merge): We don't need to do anything if we just
20416 2003-12-11 Martin Baulig <martin@ximian.com>
20418 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20419 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20420 Maurer for this idea.
20422 2003-12-11 Martin Baulig <martin@ximian.com>
20424 * flowanalysis.cs (MergeResult): This class is now gone; we now
20425 use the `UsageVector' for this. The reason for this is that if a
20426 branching just has one sibling, we don't need to "merge" them at
20427 all - that's the next step to do.
20428 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20431 2003-12-11 Martin Baulig <martin@ximian.com>
20433 Reworked flow analyis and made it more precise and bug-free. The
20434 most important change is that we're now using a special `Reachability'
20435 class instead of having "magic" meanings of `FlowReturns'. I'll
20436 do some more cleanups and optimizations and also add some more
20437 documentation this week.
20439 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20440 largely reworked this class.
20441 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20442 the new `Reachability' class instead of having "magic" values here.
20443 (FlowBranching): We're now using an instance of `Reachability'
20444 instead of having separate `Returns', `Breaks' etc. fields.
20446 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20447 based on flow analysis; ignore the return value of block.Emit ().
20449 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20451 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20452 if they are private.
20454 2003-12-09 Martin Baulig <martin@ximian.com>
20456 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20457 call them directly on the UsageVector.
20459 2003-12-09 Martin Baulig <martin@ximian.com>
20461 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20462 Changed return type from `FlowReturns' to `Reachability'.
20464 2003-12-09 Martin Baulig <martin@ximian.com>
20466 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20467 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20468 `Reachable' fields with a single `Reachability' one.
20470 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20472 * class.cs (FindMembers): Remove foreach's.
20477 Run 1: 8.74 seconds
20478 Run 2: 8.71 seconds
20481 Run 1: 8.64 seconds
20482 Run 2: 8.58 seconds
20485 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20490 This patch does a few things:
20491 1. EmptyStatement is now a singleton, so it is never reallocated.
20492 2. All blah is EmptyStatement constructs have been changed to
20493 blah == EmptyStatement.Value, which is much faster and valid
20494 now that EmptyStatement is a singleton.
20495 3. When resolving a block, rather than allocating a new array for
20496 the non-empty statements, empty statements are replaced with
20497 EmptyStatement.Value
20498 4. Some recursive functions have been made non-recursive.
20499 Mainly the performance impact is from (3), however (1) and (2) are needed for
20500 this to work. (4) does not make a big difference in normal situations, however
20501 it makes the profile look saner.
20506 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20507 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20508 Total memory allocated: 56397 KB
20511 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20512 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20513 Total memory allocated: 55666 KB
20515 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20517 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20518 than the hashtable in a hashtable version
20520 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20521 we always end up concating a string. This results in a huge perf
20522 loss, because many strings have to be tracked by the GC. In this
20523 patch, we first use a hashtable that works with two keys, so that
20524 the strings do not need to be concat'ed.
20528 Run 1: 8.74 seconds
20529 Run 2: 8.71 seconds
20532 Run 1: 8.65 seconds
20533 Run 2: 8.56 seconds
20535 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20537 * Makefile: Add a new target `do-time' that does a quick and simple
20538 profile, leaving easy to parse output.
20540 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20542 * codegen.cs (Init): Create the dynamic assembly with
20543 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20545 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20547 * support.cs: Make the PtrHashtable use only one
20548 instance of its comparer.
20550 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20552 * typemanager.cs: Fix lookup of GetNamespaces.
20554 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20556 * expression.cs: Removed redundant line.
20558 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20559 ArrayLists, use for loops with bounds.
20561 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20564 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20565 arraylists, use for loop with bounds.
20567 The above three changes give us a 0.071 second performance
20568 improvement out of 3.294 seconds down to 3.223. On my machine
20569 the above changes reduced the memory usage by 1,387 KB during
20570 compiler bootstrap.
20572 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20573 QualifiedIdentifiers. Before we created a new string through
20574 concatenation, and mostly later on, the result would be
20575 manipulated by DecomposeQI through string manipulation.
20577 This reduced the compiler memory usage for bootstrapping from
20578 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20579 compile times in 0.05 seconds.
20581 2003-11-28 Dick Porter <dick@ximian.com>
20583 * support.cs: Do string compares with the Invariant culture.
20591 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20592 the comparison is done with the Invariant culture.
20594 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20596 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20597 GetEnumerator method.
20599 (ProbeCollectionType): Iterate starting at the most specific type
20600 upwards looking for a GetEnumerator
20602 * expression.cs: Shift count can be up to 31 for int/uint and 63
20605 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20607 * statement.cs (Block.LookupLabel): Also look for the label on the
20608 children blocks. Use a hash table to keep track of visited
20611 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20612 we actually did transform the other operand, otherwise fall back
20613 to the common codepath that casts to long.
20615 * cs-tokenizer.cs: Use the same code pattern as the int case.
20616 Maybe I should do the parsing myself, and avoid depending on the
20617 Parse routines to get this done.
20619 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20621 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20622 which fixes bug 51347. This time test it.
20624 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20625 attributes for example can not tell the difference between these.
20626 The difference was only a syntax feature of the language.
20628 * attribute.cs: Apply attributes to delegates.
20630 * delegate.cs: Call the apply attributes method.
20632 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20634 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20635 comparing 0 vs Byte.MinValue, not the value
20637 (ImplicitConversionRequired): When reporting a conversion error,
20638 use error 31 to print out the constant error instead of the
20641 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20642 which fixes bug 51347.
20644 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20646 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20647 which fixes the -warnaserror command line option.
20649 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20651 * cfold.cs (DoNumericPromotions): During constant folding of
20652 additions on UIntConstant, special case intconstants with
20653 IntConstants like we do on the expression binary operator.
20655 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20657 * convert.cs (ImplicitReferenceConversion): We were missing a case
20658 (System.Enum are not value types or class types, so we need to
20659 classify them separatedly).
20661 * driver.cs: We do not support error 2007.
20663 2003-11-12 Jackson Harper <jackson@ximian.com>
20665 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20666 system directory. Also use the full file name so users can
20667 libraries names mscorlib-o-tron.dll in a non system dir.
20669 2003-11-10 Martin Baulig <martin@ximian.com>
20671 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20672 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20673 calling `ResolveType()' on them, directly assign their `Type'.
20675 2003-11-08 Martin Baulig <martin@ximian.com>
20677 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20678 return value and the `out parent' parameter.
20679 (TypeContainer.DefineType): Moved the CS0644 check into
20680 GetClassBases(). Don't pass the interface types to the
20681 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20682 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20684 * ecore.cs (TypeExpr.IsAttribute): New property.
20685 (TypeExpr.GetInterfaces): New method.
20687 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20688 TypeExpr instead of a Type.
20689 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20690 (Interface.DefineType): Don't pass the interface types to the
20691 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20692 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20694 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20695 instead of a `Type[]'.
20696 (TypeManager.RegisterBuilder): Likewise.
20697 (TypeManager.AddUserInterface): Likewise.
20698 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20699 `Type[]' and also return a `TypeExpr[]'.
20700 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20702 2003-11-08 Martin Baulig <martin@ximian.com>
20704 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20707 2003-11-08 Martin Baulig <martin@ximian.com>
20709 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20710 TypeManager.ResolveExpressionTypes().
20712 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20713 instead of an Expression.
20714 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20715 (TypeExpression): New public class; formerly known as `TypeExpr'.
20717 * expression.cs (ComposedCast): Derive from TypeExpr.
20719 * typemanager.cs (TypeManager.system_*_expr): These are now
20720 TypExpr's instead of Expression's.
20721 (TypeManager.ResolveExpressionTypes): New public static function;
20722 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20725 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20727 * expression.cs (New.DoResolve): Do not dereference value that
20728 might be a null return.
20730 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20731 sure that the constant value has the right type. Fixes an
20732 unreported bug, similar to 50425.
20734 * const.cs (Const.LookupConstantValue): Call
20735 ImplicitStandardConversionExists before doing a conversion to
20736 avoid havng the TypeManager.ChangeType do conversions.
20738 Reduced the number of casts used
20740 (Const.ChangeType): New routine to enable reuse of the constant
20741 type changing code from statement.
20743 * typemanager.cs (ChangeType): Move common initialization to
20744 static global variables.
20748 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20749 every value type to go through, even if it was void. Fix that.
20751 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20752 character of the define, and the is_identifier_part_character for
20753 the rest of the string.
20755 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20757 * expression.cs (UnaryMutator.EmitCode): When I updated
20758 LocalVariableReference.DoResolve, I overdid it, and dropped an
20759 optimization done on local variable references.
20761 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20763 * ecore.cs: Convert the return from Ldlen into an int.
20765 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20767 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20768 the accessibility, this is a special case for toplevel non-public
20769 classes (internal for instance).
20771 2003-10-20 Nick Drochak <ndrochak@gol.com>
20773 * ecore.cs: Fix typo and build. Needed another right paren.
20775 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20777 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20778 `internal' case regular and protected, but not allowing protected
20779 to be evaluated later. Bug 49840
20781 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20783 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20784 to kb.Nlast, and not the kb.nFirst to isolate the switch
20787 Extract the underlying type, so enumerations of long/ulong are
20788 treated like long/ulong.
20790 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20792 * expression.cs (New): Overload the meaning of RequestedType to
20793 track the possible creation of the NewDelegate type, since
20794 DoResolve is invoked more than once for new constructors on field
20797 See bugs: #48800 and #37014
20799 * cs-parser.jay (declare_local_constants): Take an arraylist
20800 instead of a single constant.
20802 (local_constant_declaration): It should take a
20803 constant_declarators, not a constant_declarator. Fixes 49487
20805 * convert.cs: Fix error report.
20807 2003-10-13 Jackson Harper <jackson@ximian.com>
20809 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20812 2003-10-09 Martin Baulig <martin@ximian.com>
20814 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20816 (MethodCore.DoDefineParameters): Removed the TypeContainer
20817 argument; use the DeclSpace which was passed to the .ctor instead.
20818 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20819 TypeContainer; we only need a DeclSpace here.
20821 2003-10-09 Martin Baulig <martin@ximian.com>
20823 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20825 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20826 EmitContext's .ctor.
20828 2003-10-09 Martin Baulig <martin@ximian.com>
20830 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20831 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20832 AsAccessible(), moved them as well.
20834 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20836 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20838 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20840 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20842 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20843 generation for >=, as spotted by Paolo, bug 48679.
20844 Patch from David Waite.
20846 * cs-tokenizer.cs: Add handling for #pragma.
20848 * cs-parser.jay: Allow for both yield and yield return in the
20849 syntax. The anti-cobolization of C# fight will go on!
20851 * class.cs (TypeBuilder.DefineType): Catch error condition here
20852 (Parent.DefineType erroring out and returning null).
20854 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20855 coping with enumerations variables, we were mistakenly processing
20856 them as a regular value type instead of built-in types. Fixes the
20859 * typemanager.cs (IsBuiltinOrEnum): New method.
20861 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20863 * cs-parser.jay: Upgrade: yield now needs the return clause.
20865 2003-09-19 Martin Baulig <martin@ximian.com>
20867 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20868 `MemberCache parent' argument. Normally, an interface doesn't
20869 have a parent type except System.Object, but we use this in gmcs
20870 for generic type parameters.
20872 2003-09-18 Martin Baulig <martin@ximian.com>
20874 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
20875 on `type.IsInterface'; don't check whether the type has a parent
20876 to determine whether it's an interface.
20878 2003-09-15 Martin Baulig <martin@ximian.com>
20880 * class.cs (TypeContainer.DefineType): Added an error flag to
20881 avoid reporting duplicate CS0146's ("class definition is
20884 * driver.cs (Driver.MainDriver): Abort if
20885 RootContext.ResolveTree() reported any errors.
20887 2003-09-07 Martin Baulig <martin@ximian.com>
20889 * report.cs (Error, Warning): Added overloaded versions which take
20890 a `params object[] args' and call String.Format().
20892 2003-09-07 Martin Baulig <martin@ximian.com>
20894 * decl.cs (DeclSpace..ctor): Don't call
20895 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
20896 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
20897 (DeclSpace.RecordDecl): New method.
20899 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
20901 2003-09-02 Ravi Pratap <ravi@ximian.com>
20903 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
20904 value attributes to be applied to ParameterBuilders.
20906 * class.cs (MethodCore.LabelParameters): Make static and more
20907 generic so that it can be used from other places - like interface
20908 methods, for instance.
20910 * interface.cs (Interface.Emit): Call LabelParameters before
20911 emitting attributes on the InterfaceMethod.
20913 2003-08-26 Martin Baulig <martin@ximian.com>
20915 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
20916 resolving aliases; fixes #47927.
20918 2003-08-26 Martin Baulig <martin@ximian.com>
20920 * statement.cs (Using.DoResolve): This is internally emitting a
20921 try/finally clause, so we need to set ec.NeedExplicitReturn if we
20922 do not always return. Fixes #47681.
20924 2003-08-26 Martin Baulig <martin@ximian.com>
20926 * decl.cs (MemberCore): Moved WarningNotHiding(),
20927 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
20929 (AdditionResult): Make this nested in DeclSpace.
20930 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
20931 argument; call NamespaceEntry.Define() unless we're nested in a
20934 * namespace.cs (Namespace.DefineName): New public function. This
20935 is called from DeclSpace's .ctor to add
20936 (Namespace.Lookup): Include DeclSpaces in the lookup.
20938 * class.cs (Operator): Derive from MemberBase, not MemberCore.
20940 * const.cs (Const): Derive from MemberBase, not MemberCore.
20942 2003-08-25 Martin Baulig <martin@ximian.com>
20944 * convert.cs (Convert.ExplicitReferenceConversion): When
20945 converting from an interface type to a class, unbox if the target
20946 type is a struct type. Fixes #47822.
20948 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20950 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
20953 2003-08-22 Martin Baulig <martin@ximian.com>
20955 * class.cs (TypeManager.DefineType): When defining a nested type,
20956 call DefineType() on our parent; fixes #47801.
20958 2003-08-22 Martin Baulig <martin@ximian.com>
20960 * class.cs (MethodData.Define): While checking if a method is an
20961 interface implementation, improve the test a bit more to fix #47654.
20963 2003-08-22 Martin Baulig <martin@ximian.com>
20965 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
20966 correctly; fixes #47722.
20968 2003-08-22 Martin Baulig <martin@ximian.com>
20970 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
20971 LocalVariableReference, ensure it's not read-only. Fixes #47536.
20973 * statement.cs (Fixed.DoResolve): Make all variables read-only.
20975 2003-08-22 Martin Baulig <martin@ximian.com>
20977 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
20978 can only be assigned in static constructors. Fixes #47161.
20980 2003-08-22 Martin Baulig <martin@ximian.com>
20982 Rewrote and improved the flow analysis code.
20984 * flowbranching.cs (FlowBranching): Make this class abstract.
20985 (FlowBranching.CreateBranching): New static function to create a
20986 new flow branching.
20987 (FlowBranchingBlock, FlowBranchingException): New classes.
20988 (FlowBranching.UsageVector.Type): New public readonly field.
20989 (FlowBranching.UsageVector.Breaks): Removed the setter.
20990 (FlowBranching.UsageVector.Returns): Removed the setter.
20991 (FlowBranching.UsageVector): Added Break(), Return(),
20992 NeverReachable() and Throw() methods to modify the reachability.
20993 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
20994 done by FlowBranching.Merge().
20995 (FlowBranching.UsageVector.MergeChild): New method; merges the
20996 merge result into the current vector.
20997 (FlowBranching.Merge): New abstract method to merge a branching.
20999 2003-08-12 Martin Baulig <martin@ximian.com>
21001 * expression.cs (Indirection.CacheTemporaries): Create the
21002 LocalTemporary with the pointer type, not its element type.
21004 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21006 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21007 token was a keyword or not.
21009 Add `error' options where an IDENTIFIER was expected; Provide
21010 CheckToken and CheckIdentifierToken convenience error reporting
21013 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21015 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21016 NameSpaceEntry NameSpaceEntry.
21018 (LookupInterfaceOrClass): Avoid creating a full qualified name
21019 from namespace and name: avoid doing lookups when we know the
21020 namespace is non-existant. Use new Tree.LookupByNamespace which
21021 looks up DeclSpaces based on their namespace, name pair.
21023 * driver.cs: Provide a new `parser verbose' to display the
21024 exception thrown during parsing. This is turned off by default
21025 now, so the output of a failure from mcs is more graceful.
21027 * namespace.cs: Track all the namespaces defined in a hashtable
21030 (IsNamespace): New method
21032 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21034 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21035 we know that we need to concatenate (full typename can never be
21040 * statement.cs: Use a bitfield; Do not initialize to null things
21041 which are done by the constructor by default.
21043 * cs-parser.jay: bug fix, parameter was 4, not 3.
21045 * expression.cs: Just use the property;
21047 * statement.cs: No need for GetVariableInfo method.
21049 2003-08-08 Martin Baulig <martin@ximian.com>
21051 * flowanalysis.cs (FlowReturns): This is now nested in the
21052 `FlowBranching' class.
21053 (MyBitVector): Moved this here from statement.cs.
21054 (FlowBranching.SiblingType): New enum type.
21055 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21057 2003-08-07 Martin Baulig <martin@ximian.com>
21059 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21060 `FlowBranching' class and called `BranchingType'.
21062 2003-08-07 Martin Baulig <martin@ximian.com>
21064 * flowanalysis.cs: Moved all the control flow analysis code into
21067 2003-08-07 Martin Baulig <martin@ximian.com>
21069 * assign.cs (Assign.DoResolve): `target' must either be an
21070 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21073 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21075 * expression.cs (BinaryMethod): This kind of expression is created by the
21076 Binary class if it determines that the operator has to be handled
21079 (BinaryDelegate): This kind of expression is created if we are
21080 dealing with a + or - operator on delegates.
21082 (Binary): remove method, argumetns, and DelegateOperator: when
21083 dealing with methods,
21085 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21087 * statement.cs (Block): use bitfields for the three extra booleans
21088 we had in use. Remove unused topblock parameter.
21090 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21092 * assign.cs: Drop extra unneeded tests.
21094 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21096 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21098 * statement.cs (Foreach): Use VariableStorage instead of
21101 * codegen.cs (VariableStorage): New class used by clients that
21102 require a variable stored: locals or fields for variables that
21103 need to live across yield.
21105 Maybe provide a convenience api for EmitThis+EmitLoad?
21107 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21110 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21112 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21113 RemapParameterLValue): New methods that are used to turn a
21114 precomputed FieldInfo into an expression like this:
21118 The idea is to use this instead of making LocalVariableReference
21119 have more than one meaning.
21121 * cs-parser.jay: Add error production to BASE.
21123 * ecore.cs: Deal with TypeManager.GetField returning null, which
21124 is now a valid return value.
21126 (FieldExprNoAddress): New expression for Fields whose address can
21129 * expression.cs (LocalVariableReference): During the resolve
21130 phases, create new expressions if we are in a remapping context.
21131 Remove code that dealt with remapping here.
21133 (ParameterReference): same.
21135 (ProxyInstance): New expression, like the `This' expression, but
21136 it is born fully resolved. We know what we are doing, so remove
21137 the errors that are targeted to user-provided uses of `this'.
21139 * statement.cs (Foreach): our variable is now stored as an
21140 Expression; During resolution, follow the protocol, dont just
21141 assume it will return this.
21143 2003-08-06 Martin Baulig <martin@ximian.com>
21145 * support.cs (SeekableStreamReader.cs): New public class.
21147 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21148 SeekableStreamReader instead of the normal StreamReader.
21150 2003-08-04 Martin Baulig <martin@ximian.com>
21152 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21153 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21154 deambiguate casts and delegate invocations.
21155 (parenthesized_expression): Use the new tokens to ensure this is
21156 not a cast of method invocation.
21158 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21159 when reading a `)' and Deambiguate_CloseParens () was previously
21162 * expression.cs (ParenthesizedExpression): New class. This is
21163 just used for the CS0075 test.
21164 (Binary.DoResolve): Check for CS0075.
21166 2003-07-29 Ravi Pratap <ravi@ximian.com>
21168 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21169 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21170 reference comparison.
21172 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21173 examine the ReturnType for equality - this is necessary in the
21174 cases of implicit and explicit operators whose signature also
21175 includes the return type.
21177 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21179 * namespace.cs: Cache the result of the namespace computation,
21180 instead of computing it every time.
21182 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21184 * decl.cs: Use a global arraylist that we reuse over invocations
21185 to avoid excesive memory consumption. Reduces memory usage on an
21186 mcs compile by one meg (45 average).
21188 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21189 private, work around that.
21191 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21193 * literal.cs (IntLiteral): Define Zero and One static literals.
21195 * cs-parser.jay (integer_literal): use static literals to reduce
21196 memory usage for the most used literals (0, 1 and -1). 211kb
21197 reduced in memory usage.
21199 Replace all calls to `new ArrayList' with `new
21200 ArrayList(4)' which is a good average number for most allocations,
21201 and also requires only 16 bytes of memory for its buffer by
21204 This reduced MCS memory usage in seven megabytes for the RSS after
21207 2003-07-28 Ravi Pratap <ravi@ximian.com>
21209 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21210 handle params methods the correct way by forming only one
21211 applicable set with params and normal methods in them. Earlier we
21212 were looking at params methods only if we found no normal methods
21213 which was not the correct thing to do.
21215 (Invocation.BetterFunction): Take separate arguments indicating
21216 when candidate and the best method are params methods in their
21219 This fixes bugs #43367 and #46199.
21221 * attribute.cs: Documentation updates.
21223 (CheckAttribute): Rename to CheckAttributeTarget.
21224 (GetValidPlaces): Rename to GetValidTargets.
21226 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21227 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21231 2003-07-28 Martin Baulig <martin@ximian.com>
21233 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21234 name when looking up the base class of a nested class. Fixes #46977.
21236 2003-07-26 Martin Baulig <martin@ximian.com>
21238 * expression.cs (Indexers.Indexer): New nested struct; contains
21239 getter, setter and the indexer's type.
21240 (Indexers.Properties): This is now an ArrayList of
21241 Indexers.Indexer's.
21242 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21243 indexer doesn't have any getters.
21245 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21246 for embedded property and indexer assignments.
21248 2003-07-26 Martin Baulig <martin@ximian.com>
21250 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21251 preprocessor directive is not the first non-whitespace character
21254 2003-07-26 Martin Baulig <martin@ximian.com>
21256 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21257 namespace parsing, follow the spec more closely.
21259 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21260 NamespaceEntry.Lookup().
21262 2003-07-25 Martin Baulig <martin@ximian.com>
21264 * MethodCore.cs (OverridesSomething): New public field; it's set
21265 from TypeContainer.DefineMembers if this method overrides
21266 something (which doesn't need to be a method). Fix #39462.
21268 2003-07-25 Ravi Pratap <ravi@ximian.com>
21270 * typemanager.cs (GetMembers): Ensure that the list of members is
21271 reversed. This keeps things in sync.
21273 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21274 find an AttributeUsage attribute.
21276 * expression.cs (Invocation.OverloadResolve): Perform the check
21277 which disallows Invoke to be directly called on a Delegate.
21279 (Error_InvokeOnDelegate): Report error cs1533.
21281 2003-07-25 Martin Baulig <martin@ximian.com>
21283 * expression.cs (Indexers.GetIndexersForType): Only look in the
21284 interface hierarchy if the requested type is already an
21285 interface. Fixes #46788 while keeping #46502 fixed.
21287 2003-07-25 Martin Baulig <martin@ximian.com>
21289 * class.cs (TypeContainer.DefineMembers): Check whether all
21290 readonly fields have been assigned and report warning CS0649 if
21293 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21296 2003-07-24 Ravi Pratap <ravi@ximian.com>
21298 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21299 returned from GetMethods to make things consistent with the
21300 assumptions MCS makes about ordering of methods.
21302 This should comprehensively fix bug #45127 and it does :-)
21304 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21305 ordering is actually reverse.
21307 * Clean up some debug messages I left lying around.
21309 * interface.cs (Populate*): Get rid of code which emits attributes
21310 since the stage in which we emit attributes is the 'Emit' stage,
21311 not the define stage.
21313 (Emit): Move attribute emission for interface members here.
21315 2003-07-22 Ravi Pratap <ravi@ximian.com>
21317 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21318 closely: we eliminate methods in base types when we have an
21319 applicable method in a top-level type.
21321 Please see section 14.5.5.1 for an exact description of what goes
21324 This fixes bug #45127 and a host of other related to corlib compilation.
21326 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21327 array is the method corresponding to the top-level type (this is
21328 because of the changes made to icall.c) so we change this
21331 (MethodGroupExpr.Name): This too.
21333 * typemanager.cs (GetElementType): New method which does the right
21334 thing when compiling corlib.
21336 * everywhere: Make use of the above in the relevant places.
21338 2003-07-22 Martin Baulig <martin@ximian.com>
21340 * cs-parser.jay (invocation_expression): Moved
21341 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21342 `cast_expression', but create a InvocationOrCast which later
21343 resolves to either an Invocation or a Cast.
21345 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21346 method; call this before EmitStatement() to make sure that this
21347 expression can be used as a statement.
21349 * expression.cs (InvocationOrCast): New class; resolves to either
21350 an Invocation or a Cast.
21352 * statement.cs (StatementExpression): Call ResolveStatement() on
21353 the ExpressionStatement before emitting it.
21355 2003-07-21 Martin Baulig <martin@ximian.com>
21357 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21358 `ref' and `out' attributes match; fixes #46220.
21359 (MemberAccess.ResolveMemberAccess): You can't reference a type
21360 through an expression; fixes #33180.
21361 (Indexers.GetIndexersForType): Don't return the indexers from
21362 interfaces the class implements; fixes #46502.
21364 2003-07-21 Martin Baulig <martin@ximian.com>
21366 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21367 CS0661 checks; fixes bug #30442.
21369 2003-07-21 Martin Baulig <martin@ximian.com>
21371 * decl.cs (AdditionResult): Added `Error'.
21373 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21375 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21376 makes cs0031.cs actually work.
21378 2003-07-20 Martin Baulig <martin@ximian.com>
21380 * namespace.cs: Fixed that bug which caused a crash when compiling
21381 the debugger's GUI.
21383 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21385 * typemanager.cs (LookupTypeReflection): Never expose types which
21386 are NotPublic, NestedPrivate, NestedAssembly, or
21387 NestedFamANDAssem. We used to return these, and later do a check
21388 that would report a meaningful error, but the problem is that we
21389 would not get the real match, if there was a name override.
21391 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21393 * namespace.cs (Namespace, Name): Do not compute the namespace
21394 name dynamically, compute it in the constructor. This reduced
21395 memory usage by 1697 KB.
21397 * driver.cs: Use --pause to pause at the end.
21399 2003-07-17 Peter Williams <peter@newton.cx>
21401 * Makefile: Change the name of the test target so that it doesn't
21402 conflict with the recursive test target.
21404 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21406 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21407 AddressOf): Do not use EmitThis, that was wrong, use the actual
21410 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21412 * class.cs (MethodData.Define): While checking if a method is an
21413 interface implementation, improve the test: If we are not public
21414 (use new test here: use the computed MethodAttributes directly,
21415 instead of the parsed modifier flags) check if the `implementing'
21416 method comes from an interface or not.
21418 * pending.cs (VerifyPendingMethods): Slightly better error
21421 * makefile: add test target that does the mcs bootstrap.
21423 2003-07-16 Ravi Pratap <ravi@ximian.com>
21425 * interface.cs (Define): Do nothing here since there are no
21426 members to populate etc. Move the attribute emission out of here
21427 since this was just totally the wrong place to put it. Attribute
21428 application happens during the 'Emit' phase, not in the 'Define'
21431 (Emit): Add this method and move the attribute emission here
21433 * rootcontext.cs (EmitCode): Call the Emit method on interface
21436 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21438 * expression.cs (OverloadResolve): Report error only if Location
21439 is not 'Null' which means that there was a probe going on.
21441 2003-07-14 Martin Baulig <martin@ximian.com>
21443 * expression.cs (ConditionalLogicalOperator): New public class to
21444 implement user defined conditional logical operators.
21445 This is section 14.11.2 in the spec and bug #40505.
21447 2003-07-14 Martin Baulig <martin@ximian.com>
21449 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21451 2003-07-14 Martin Baulig <martin@ximian.com>
21453 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21455 * ecore.cs (IVariable.VerifyFixed): New interface method.
21457 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21458 operator, check whether the variable is actually fixed. Fixes bug
21459 #36055. Set a variable definitely assigned when taking its
21460 address as required by the spec.
21462 * statement.cs (LocalInfo.IsFixed): New field.
21463 (LocalInfo.MakePinned): Set `IsFixed' to true.
21465 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21467 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21468 for .ctors, ensure that we only ask for members declared in the
21469 attribute type (BindingFlags.DeclaredOnly).
21473 * expression.cs (Error_WrongNumArguments): Report error 1501
21474 correctly the way CSC does.
21476 2003-07-13 Martin Baulig <martin@ximian.com>
21478 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21479 lookup on the fully qualified name, to make things like "X.X" work
21480 where "X.X" is a fully qualified type name, but we also have a
21481 namespace "X" in the using list. Fixes #41975.
21483 2003-07-13 Martin Baulig <martin@ximian.com>
21485 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21486 function. If we're a CompoundAssign, we need to create an embedded
21487 CompoundAssign, not an embedded Assign.
21488 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21491 2003-07-13 Martin Baulig <martin@ximian.com>
21493 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21494 work to fix bug #46088.
21496 2003-07-13 Ravi Pratap <ravi@ximian.com>
21498 * class.cs (Operator.Emit): Do not emit attributes here - it is
21499 taken care of by the Method class that we delegate too. This takes
21500 care of bug #45876.
21502 2003-07-10 Martin Baulig <martin@ximian.com>
21504 * expression.cs (TypeOfVoid): New class.
21505 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21507 2003-07-10 Martin Baulig <martin@ximian.com>
21509 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21512 2003-07-10 Martin Baulig <martin@ximian.com>
21514 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21515 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21517 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21519 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21521 2003-07-10 Martin Baulig <martin@ximian.com>
21523 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21524 of decimal. Fixes #42850.
21526 NOTE: I also fixed the created byte blob, but this doesn't work on
21527 the MS runtime and csc never produces any byte blobs for decimal
21530 2003-07-10 Martin Baulig <martin@ximian.com>
21532 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21533 structs; fixes #32068.
21534 (Block.AddChildVariableNames): Fixed #44302.
21536 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21538 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21540 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21542 * attribute.cs: And this test is onger needed.
21544 2003-07-08 Martin Baulig <martin@ximian.com>
21546 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21547 inaccessible types. Fixes #36313.
21549 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21551 * namespace.cs (NamespaceEntry): Create implicit entries for all
21552 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21553 implicit entries for N1.N2 and N1.
21555 2003-07-08 Martin Baulig <martin@ximian.com>
21557 Rewrote the handling of namespaces to fix a lot of the issues
21558 wrt. `using' aliases etc.
21560 * namespace.cs (Namespace): Splitted this class into a
21561 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21563 * typemanager.cs (TypeManager.IsNamespace): Removed.
21564 (TypeManager.ComputeNamespaces): Only compute namespaces from
21565 loaded assemblies here, not the namespaces from the assembly we're
21566 currently compiling.
21568 2003-07-08 Martin Baulig <martin@ximian.com>
21570 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21572 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21574 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21577 I thought about the memory savings here, but LookupTypeReflection
21578 is used under already very constrained scenarios. Compiling
21579 corlib or mcs only exposes one hit, so it would not really reduce
21580 any memory consumption.
21582 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21584 * typemanager.cs: fixes bug #45889 by only adding public types from
21585 other assemblies to the list of known types.
21587 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21589 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21590 on the type we resolved.
21592 2003-07-05 Martin Baulig <martin@ximian.com>
21594 * pending.cs (PendingImplementation.ParentImplements): Don't
21595 create the proxy if the parent is abstract.
21597 * class.cs (TypeContainer.DefineIndexers): Process explicit
21598 interface implementations first. Fixes #37714.
21600 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21602 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21603 defined recursively; but since we modify the input parameters
21604 (left is set to `this' temporarily), we reset this value if the
21605 left_is_explicit is false, which gives the original semantics to
21608 * literal.cs (NullPointer): new class used to represent a null
21609 literal in a pointer context.
21611 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21612 type is a pointer, use a NullPointer object instead of a
21613 NullLiteral. Closes 43687
21615 (ExplicitConversion): Convert pointer values using
21616 the conv opcode to the proper type.
21618 * ecore.cs (New): change ValueTypeVariable property into a method,
21619 that returns whether the valuetype is suitable for being used.
21621 * expression.cs (Binary.DoNumericPromotions): Only return if we
21622 the int constant was a valid uint, and we can return both left and
21623 right as uints. If not, we continue processing, to trigger the
21624 type conversion. This fixes 39018.
21626 * statement.cs (Block.EmitMeta): During constant resolution, set
21627 the CurrentBlock property on the emitcontext, so that we resolve
21628 constants propertly.
21630 2003-07-02 Martin Baulig <martin@ximian.com>
21632 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21633 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21635 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21636 than emitting it here.
21638 * statement.cs: Fixed some more flow analysis bugs.
21640 2003-07-02 Martin Baulig <martin@ximian.com>
21642 * class.cs (MethodData.Define): When implementing interface
21643 methods, set Final unless we're Virtual.
21645 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21646 check work for interface methods.
21648 2003-07-01 Martin Baulig <martin@ximian.com>
21650 * ecore.cs (EmitContext.This): Replaced this property with a
21651 GetThis() method which takes a Location argument. This ensures
21652 that we get the correct error location for a CS0188.
21654 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21656 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21657 ImplicitStandardConversion.
21659 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21661 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21663 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21666 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21668 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21671 (MethodData.Define): Turn off initlocals for unsafe methods.
21673 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21675 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21676 complete; Fixes #37521.
21678 * delegate.cs: Use Modifiers.TypeAttr to compute the
21679 TypeAttributes, instead of rolling our own. This makes the flags
21680 correct for the delegates.
21682 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21684 * class.cs (Constructor.Define): Set the private flag for static
21685 constructors as well.
21687 * cs-parser.jay (statement_expression): Set the return value to
21688 null, to avoid a crash when we catch an error.
21690 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21692 * cs-parser.jay: Applied patch from Jackson that adds support for
21693 extern and unsafe modifiers to destructor declarations.
21695 * expression.cs: Report error 21 if the user is trying to index a
21698 * driver.cs: Add an error message, suggested by the bug report.
21700 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21701 if we do not have a ": this ()" constructor initializer. Fixes 45149
21703 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21705 * namespace.cs: Add some information to reduce FAQs.
21707 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21709 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21710 underlying enumeration types. Fixes #43915.
21712 * expression.cs: Treat ushort/short as legal values to be used in
21713 bitwise operations.
21715 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21717 * delegate.cs: transfer custom attributes for paramenters from
21718 the delegate declaration to Invoke and BeginInvoke.
21720 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21722 * attribute.cs: handle custom marshalers and emit marshal info
21725 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21727 * makefile.gnu: Added anonymous.cs to the compiler sources.
21729 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21731 * iterators.cs: Change the name of the proxy class to include two
21734 * cs-parser.jay: Update grammar to include anonymous methods.
21736 * anonymous.cs: new file.
21738 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21740 * class.cs (Field.Define): Add missing test for pointers and
21743 2003-05-27 Ravi Pratap <ravi@ximian.com>
21745 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21746 we use the stobj opcode.
21748 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21749 since it wasn't the correct fix.
21751 It still is puzzling that we are required to use stobj for IntPtr
21752 which seems to be a ValueType.
21754 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21756 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21757 during regular simple name resolution. Now, the trick is that
21758 instead of returning for processing the simplename, we do a
21759 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21760 contextual lookup type). If a match is found, return that, if
21761 not, return for further composition.
21763 This fixes long-standing 30485.
21765 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21766 using the address to initialize an object, do an Stobj instead of
21767 using the regular Stelem.
21769 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21770 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21771 Because if we are a BaseIndexerAccess that value will be true.
21774 * statement.cs (GotoCase.Resolve): Return after reporting an
21775 error, do not attempt to continue.
21777 * expression.cs (PointerArithmetic.Emit): If our operand is a
21778 long, convert our constants to match the operand before
21779 multiplying. Convert to I type before adding. Fixes 43670.
21781 2003-05-14 Ravi Pratap <ravi@ximian.com>
21783 * enum.cs (ImplicitConversionExists) : Rename to
21784 ImplicitEnumConversionExists to remove ambiguity.
21786 * ecore.cs (NullCast): New type of cast expression class which
21787 basically is very similar to EmptyCast with the difference being
21788 it still is a constant since it is used only to cast a null to
21790 (eg. (string) null)
21792 * convert.cs (ImplicitReferenceConversion): When casting a null
21793 literal, we return a NullCast.
21795 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21796 should be around anymore.
21798 The renaming (reported was slightly wrong). Corrections:
21800 ConvertImplicitStandard -> ImplicitConversionStandard
21801 ConvertExplicitStandard -> ExplicitConversionStandard
21803 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21804 before passing them in !
21806 * convert.cs (ImplicitConversionStandard): When comparing for
21807 equal expr and target types, ensure that expr is not a
21810 In general, we must not be checking (expr_type ==
21811 target_type) in the top level conversion methods
21812 (ImplicitConversion, ExplicitConversion etc). This checking is
21813 done in the methods that they delegate to.
21815 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21817 * convert.cs: Move Error_CannotConvertType,
21818 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21819 ImplicitNumericConversion, ImplicitConversionExists,
21820 ImplicitUserConversionExists, StandardConversionExists,
21821 FindMostEncompassedType, FindMostSpecificSource,
21822 FindMostSpecificTarget, ImplicitUserConversion,
21823 ExplicitUserConversion, GetConversionOperators,
21824 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21825 TryImplicitIntConversion, Error_CannotConvertImplicit,
21826 ConvertImplicitRequired, ConvertNumericExplicit,
21827 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21828 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21831 Perform the following renames:
21833 StandardConversionExists -> ImplicitStandardConversionExists
21834 ConvertImplicit -> ImplicitConversion
21835 ConvertImplicitStandard -> ImplicitStandardConversion
21836 TryImplicitIntConversion -> ImplicitIntConversion
21837 ConvertImplicitRequired -> ImplicitConversionRequired
21838 ConvertNumericExplicit -> ExplicitNumericConversion
21839 ConvertReferenceExplicit -> ExplicitReferenceConversion
21840 ConvertExplicit -> ExplicitConversion
21841 ConvertExplicitStandard -> ExplicitStandardConversion
21843 2003-05-19 Martin Baulig <martin@ximian.com>
21845 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21846 (TypeInfo): Added support for structs having structs as fields.
21848 * ecore.cs (FieldExpr): Implement IVariable.
21849 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21850 VariableInfo for the field.
21852 2003-05-18 Martin Baulig <martin@ximian.com>
21854 * expression.cs (This.DoResolve): Report a CS0027 if we're
21855 emitting a field initializer.
21857 2003-05-18 Martin Baulig <martin@ximian.com>
21859 * expression.cs (This.ResolveBase): New public function.
21860 (This.DoResolve): Check for CS0188.
21862 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21865 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21866 `instance_expression' to null if we don't have any non-static
21869 2003-05-18 Martin Baulig <martin@ximian.com>
21871 Reworked the way how local variables and parameters are handled by
21872 the flow analysis code.
21874 * statement.cs (TypeInfo, VariableMap): New public classes.
21875 (VariableInfo): New public class. This is now responsible for
21876 checking whether a variable has been assigned. It is used for
21877 parameters and local variables.
21878 (Block.EmitMeta): Take the InternalParameters as argument; compute
21879 the layout of the flow vectors here.
21880 (Block.LocalMap, Block.ParameterMap): New public properties.
21881 (FlowBranching): The .ctor doesn't get the InternalParameters
21882 anymore since Block.EmitMeta() now computes the layout of the flow
21884 (MyStructInfo): This class is now known as `StructInfo' and nested
21885 in `TypeInfo'; we don't access this directly anymore.
21887 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
21888 property and removed IsAssigned(), IsFieldAssigned(),
21889 SetAssigned() and SetFieldAssigned(); we now call them on the
21890 VariableInfo so we don't need to duplicate this code everywhere.
21892 * expression.cs (ParameterReference): Added `Block block' argument
21894 (LocalVariableReference, ParameterReference, This): The new
21895 VariableInfo class is now responsible for all the definite
21898 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
21899 IsParameterAssigned, SetParameterAssigned): Removed.
21901 2003-05-18 Martin Baulig <martin@ximian.com>
21903 * typemanager.cs (InitCoreTypes): Try calling
21904 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
21905 the 3-args-version. Corlib now also needs our `void_type'.
21906 (GetMethod): Added overloaded version which takes an optional
21907 `bool report_errors' to allow lookups of optional methods.
21909 2003-05-12 Martin Baulig <martin@ximian.com>
21911 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
21912 only used for locals and not for parameters.
21914 2003-05-12 Miguel de Icaza <miguel@ximian.com>
21916 * support.cs (InternalParameters.ParameterType): Return the
21917 ExternalType of the parameter.
21919 * parameter.cs (Parameter.ExternalType): drop the two arguments,
21922 2003-05-11 Miguel de Icaza <miguel@ximian.com>
21924 * class.cs (MethodData.Define): Do not set the `newslot' on
21925 interface members, if they are also flagged as "override".
21927 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
21928 better code for ++i and i++. This only works for static fields
21929 and local variables.
21931 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
21932 want to pull the DeclSpace out of the builder_to_declspace instead
21933 of the TypeBuilder (like in TypeContainer.FindMembers).
21935 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
21936 instead of LookupTypeContainer. Fixes the crash on .NET for
21937 looking up interface members.
21939 * const.cs: Create our own emit context during the Definition
21940 stage, so that constants are evaluated in the proper context, when
21941 a recursive definition happens.
21943 2003-05-11 Martin Baulig <martin@ximian.com>
21945 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
21946 new block for a switch section.
21947 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
21948 the adding/lookup in the switch block. Fixes #39828.
21950 2003-05-09 Miguel de Icaza <miguel@ximian.com>
21952 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
21953 functionality: I needed to convert the data after I had performed
21954 the add/sub operation into the operands type size.
21956 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
21957 pass the type for the box operation, otherwise the resulting
21958 object would have been of type object.
21960 (BoxedCast): Add constructor to specify the type to box as.
21962 2003-05-07 Miguel de Icaza <miguel@ximian.com>
21964 * iterators.cs: I was reusing the `count' variable inadvertently,
21965 take steps to not allow this to happen.
21967 2003-05-06 Miguel de Icaza <miguel@ximian.com>
21969 * attribute.cs (Attribute.Resolve): Params attributes are encoded
21970 by creating an array at the point where the params starts and
21971 putting all those arguments there, then adjusting the size of the
21974 2003-05-05 Miguel de Icaza <miguel@ximian.com>
21976 * expression.cs (New.AddressOf): Implement interface
21977 IMemoryLocation. This is used when the `new' operator is used in
21978 the context of an invocation to a method on a value type.
21980 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
21983 * namespace.cs: Also check the using aliases here.
21985 * driver.cs: Move the test for using validity after the types have
21986 been entered, so we do a single pass that also includes the using
21989 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
21990 in the regular case. CreateSiblingForFinally is doing extra
21993 * attribute.cs (GetAttributeArgumentExpression): Store the result
21994 on an out value, and use the return value to indicate failure
21995 instead of using null (which is a valid return for Constant.GetValue).
21997 * statement.cs: Perform the analysis flow for the increment
21998 portion after the statement, because this will be the real flow of
21999 execution. Fixes #42385
22001 * codegen.cs (EmitContext.EmitArgument,
22002 EmitContext.EmitStoreArgument): New helper functions when the
22003 RemapToProxy flag is set.
22005 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22008 Add support for remapping parameters.
22010 * iterators.cs: Propagate parameter values; Store parameter
22011 values in the proxy classes.
22013 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22015 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22016 need a proxy reference; I do not know what I was thinking
22018 * cs-parser.jay (constructor_initializer): catch another error,
22019 and display nice message.
22021 (field_declaration): catch void field declaration
22022 to flag a better error.
22024 * class.cs (MemberBase.CheckBase): Report an error instead of a
22025 warning if a new protected member is declared in a struct.
22026 (Field.Define): catch the error of readonly/volatile.
22028 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22030 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22031 volatile variable is taken
22033 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22035 * statement.cs (Fixed.Resolve): Report an error if we are not in
22038 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22040 * typemanager.cs: reuse the code that handles type clashes for
22041 delegates and enumerations.
22043 * class.cs (Report28): Always report.
22045 * expression.cs (EncodeAsAttribute): Allow nulls here.
22047 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22049 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22050 the functionality for testing whether an expression is valid for
22051 an attribute here. Also handle the case of arrays of elements
22054 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22055 encoding a linear array into an array of objects that are suitable
22056 to be passed to an CustomAttributeBuilder.
22058 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22060 * ecore.cs: (FieldExpr): Handle field remapping here.
22062 * iteratators.cs: Pass the instance variable (if the method is an
22063 instance method) to the constructors, so we can access the field
22064 variables on the class.
22066 TODO: Test this with structs. I think the THIS variable on
22067 structs might have to be a pointer, and not a refenrece
22069 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22071 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22072 local variables to fields in a proxy class.
22074 * iterators.cs (PopulateProxy): Rename our internal fields to
22076 Create a <THIS> field if we are an instance method, so we can
22077 reference our parent container variables.
22078 (MapVariable): Called back from the EmitContext code to enter a
22079 new variable to field mapping into the proxy class (we just create
22083 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22084 for using the remapped locals to fields.
22086 I placed the code here, because that gives the same semantics to
22087 local variables, and only changes the Emit code.
22089 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22090 statements inside iterators.
22091 (VariableInfo): Add a FieldBuilder for the cases when we are
22092 remapping local variables to fields in a proxy class
22094 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22095 current_block != null.
22097 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22098 not cope with strings, as it has been moved to the
22099 TableSwitchEmit. Fixed bug in switch generation.
22101 * expression.cs (New.DoResolve): Provide more context for the user
22102 when reporting an error.
22104 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22107 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22108 check the permissions for it. Note than in a type-resolution
22109 context the check was already present in DeclSpace.ResolveType,
22110 but was missing from the MemberAccess.
22112 (ArrayCreation.CheckIndices): warn if the user has
22113 more nested levels of expressions, but there are no more
22114 dimensions specified. Avoids crash on bug 41906.
22116 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22118 * statement.cs (Block): replace Implicit bool, for a generic
22120 New flag: `Unchecked'. This is used during the EmitMeta phase
22121 (which is out-of-line with the regular Resolve/Emit process for a
22122 statement, as this is done ahead of time, but still gets a chance
22123 to call constant resolve).
22125 (Block.Flags): new enum for adding a new flag.
22127 (Block.EmitMeta): track the state of unchecked.
22129 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22130 to enable constant resolution to work there as well.
22132 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22134 * typemanager.cs (ienumerable_type): Also look up
22135 System.Collections.IEnumerable.
22137 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22139 TODO: Test more than one conditional per method.
22141 * class.cs (Indexer.Define): Report the location where the user is
22142 referencing the unsupported feature.
22144 (MethodData): Overload the use of `conditionals' to
22145 minimize the creation of needless ArrayLists. This saves roughly
22146 212kb on my machine.
22148 (Method): Implement the new IIteratorContainer interface.
22149 (Method.SetYields): Implement the method by setting the ModFlags
22150 to contain METHOD_YIELDS.
22152 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22153 which just got set to null.
22155 * iterators.cs: New file.
22157 (Yield, YieldBreak): New statements.
22159 * statement.cs (Return.Resolve): Flag an error if we are used in
22160 an iterator method.
22162 * codegen.cs (InIterator): New flag set if the code is being
22163 compiled in an iterator method.
22165 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22166 internal modifier, and we just use it to avoid adding extra
22167 fields, as this is seldom used.
22169 * cs-parser.jay: Add yield_statement (yield and yield break).
22171 * driver.cs: New flag -v2 to turn on version 2 features.
22173 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22174 hashtable when v2 is enabled.
22176 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22178 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22179 there is already a namespace defined with this name.
22181 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22182 people upgraded their corlibs.
22184 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22185 always use fully qualified types, no need to use the compiler
22188 (TypeManager.IsNamespace): Use binarysearch.
22190 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22191 AddDelegate): I did not quite use the new IsValid API properly: I
22192 have to pass the short-name and the fullname. I was passing only
22193 the basename instead of the fullname sometimes.
22195 (TypeContainer.DefineType): call NamespaceClash.
22197 * interface.cs (Interface.DefineType): use NamespaceClash before
22200 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22203 * enum.cs: (Enum.DefineType): use NamespaceClash before
22206 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22207 speed increase. First, use the negative_hits cache when we get a
22208 negative. Second, add the type with its full original name
22209 instead of the new . and + encoded name (reflection uses + to
22210 separate type from a nested type). Use LookupTypeReflection
22211 directly which bypasses the type->name hashtable (that we already
22212 know does not contain the type.
22214 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22215 location/container type.
22217 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22219 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22221 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22223 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22224 method is being referenced in the method group from a static
22225 context, and report error 120 if so.
22227 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22230 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22231 is created, we create the A namespace).
22233 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22236 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22238 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22239 invocation to ModuleBuilder.GetType with the same values will
22240 return a new type instance, so we need to cache its return
22243 * expression.cs (Binary.ResolveOperator): Only allow the compare
22244 operators on enums if they are of the same type.
22246 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22247 types of ValueType on their own case. Before we were giving them
22248 the same treatment as objects.
22250 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22251 fullname. Short name is used to compare against container name.
22252 Fullname is used to check against defined namespace names.
22254 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22255 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22257 (Method.CheckBase): Call parent.
22258 (MemberBase.CheckBase): Check for protected members on sealed
22260 (PropertyBase.CheckBase): Call parent.
22261 (Field.Define): Call parent.
22263 * report.cs: Negative error codes are now mapped to 8000 - code,
22264 so that the display is render more nicely.
22266 * typemanager.cs: Do not use try/catch, instead report a regular
22269 (GetPointerType, GetReferenceType): These methods provide
22270 mechanisms to obtain the T* and T& from a T. We had the code
22271 previously scattered around the code base, and it also used
22272 TypeManager.LookupType that would go through plenty of caches.
22273 This one goes directly to the type source.
22275 In some places we did the Type.GetType followed by
22276 ModuleBuilder.GetType, but not in others, so this unifies the
22277 processing as well.
22279 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22280 statements now that we have namespace information.
22282 * typemanager.cs (IsNamespace): New method, returns whether the
22283 string presented is a namespace or not.
22285 (ComputeNamespaces): New public entry point, computes the list of
22286 available namespaces, using the GetNamespaces API call in Mono, or
22287 the slower version in MS.NET.
22289 Now before we start the semantic analysis phase, we have a
22290 complete list of namespaces including everything that the user has
22293 Deleted old code to cache namespaces in .nsc files.
22295 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22297 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22298 class/struct location definition Location for the implicit
22299 constructor location.
22301 (Operator.Define): Use the location of the operator for the
22302 implicit Method definition.
22304 (Constructor.Emit): use the constructor location for the implicit
22305 base initializer constructor.
22307 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22308 and the Expression class now contains two new methods:
22310 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22311 isolate type lookup from the rest of the resolution process.
22313 Since we use Expressions to hold type definitions due to the way
22314 we parse the input we have historically overloaded Resolve to
22315 perform the Type lookups if a special flag is passed. Now this is
22316 eliminated and two methods take their place.
22318 The differences in the two methods between xStep and xTerminal is
22319 that xStep is involved in our current lookup system that uses
22320 SimpleNames to compose a name, while xTerminal is used just to
22321 catch the case where the simplename lookup failed.
22323 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22325 * expression.cs (ResolveMemberAccess): Remove redundant code.
22326 TypeExpr expressions are always born fully resolved.
22328 * interface.cs (PopulateMethod): Do not lookup the types twice.
22329 We were doing it once during SemanticAnalysis and once during
22332 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22333 in local variable type definitions, were being returned as a
22334 SimpleName (we decomposed everything into a string), that is
22335 because primary_expression was being used instead of a type in the
22336 grammar (reduce/reduce conflicts).
22338 The part that was wrong is that we converted the expression into a
22339 string (an oversimplification in one hand, compounded with primary
22340 expressions doing string concatenation).
22346 Would return "A.B.C[]" as a SimpleName. This stopped things like
22347 using clauses from working on this particular context. And a type
22348 was being matched directly against "A.B.C[]".
22350 We now use the correct approach, and allow for ComposedCast to be
22351 part of the unary expression. So the "A.B.C []" become a composed
22352 cast of "A.B.C" (as a nested group of MemberAccess with a
22353 SimpleName at the end) plus the rank composition "[]".
22357 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22359 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22360 for the access level checking.
22362 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22363 `TypeContainer container', because I kept getting confused when I
22364 was debugging this code.
22366 * expression.cs (Indexers): Instead of tracking getters/setters,
22367 we now track them in parallel. We create one arraylist less, but
22368 most importantly it is possible now for the LValue code to find a
22369 matching get for a set.
22371 (IndexerAccess.DoResolveLValue): Update the code.
22372 GetIndexersForType has been modified already to extract all the
22373 indexers from a type. The code assumed it did not.
22375 Also make the code set the correct return type for the indexer.
22376 This was fixed a long time ago for properties, but was missing for
22377 indexers. It used to be void_type.
22379 (Binary.Emit): Test first for doubles instead of
22380 floats, as they are more common.
22382 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22383 when dealing with floats and the <=, >= operators. This fixes bug
22386 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22387 to load the array value by emitting a load on the foreach variable
22388 type. This was incorrect.
22390 We now emit the code to load an element using the the array
22391 variable type, and then we emit the conversion operator.
22395 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22397 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22399 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22401 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22402 test for protection before we test for signatures.
22404 (MethodSignature.ToString): implement.
22406 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22407 to the case where we reduced into a LongConstant.
22409 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22410 depend on whether the information is acurrate, because the
22411 Microsoft runtime will always claim that the array type is public,
22412 regardless of the real state.
22414 If the type is a pointer, another problem happens: the type is
22415 reported as non-public in Microsoft.
22417 In both cases we have to call CheckAccessLevel recursively with
22418 the underlying type as the argument to be tested.
22420 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22422 * assign.cs (Assign.Emit): If we are dealing with a compound
22423 assignment expression, we should use the code path that stores the
22424 intermediate result in a temporary value. This fixes #40903.
22426 *expression.cs (Indirection.ToString): Provide ToString method for
22429 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22431 * class.cs: Null out fields holding references to Block objects so
22432 they can be garbage collected.
22434 * expression.cs (OverloadResolve): Remove unused local.
22436 2003-04-07 Martin Baulig <martin@ximian.com>
22438 * codegen.cs (EmitContext.CurrentFile): New public field.
22439 (EmitContext.Mark): Use the CurrentFile to check whether the
22440 location is in the correct file.
22441 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22443 2003-04-07 Martin Baulig <martin@ximian.com>
22445 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22447 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22448 location. [FIXME: The location argument which gets passed to this
22449 method is sometimes wrong!]
22451 2003-04-07 Nick Drochak <ndrochak@gol.com>
22453 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22455 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22457 * expression.cs (Indirection.EmitAssign): We were using the
22458 temporary, but returning immediately instead of continuing the
22461 2003-04-06 Martin Baulig <martin@ximian.com>
22463 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22464 if it's a nested child, but also deriving from the outer class.
22467 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22468 nested child, but also deriving from the outer class. See
22470 (FilterWithClosure): We may access private members of the outer
22471 class if we're a nested child and deriving from the outer class.
22472 (RealMemberLookup): Only set `closure_private_ok' if the
22473 `original_bf' contained BindingFlags.NonPublic.
22475 2003-04-05 Martin Baulig <martin@ximian.com>
22477 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22479 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22481 * class.cs (Event.Define): Do not allow abstract events to have
22484 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22486 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22487 block in event declarations.
22489 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22490 value type, get its address.
22492 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22493 leaving a class on the stack instead of a boolean value (int
22494 0/1). Change the code so we compare against null, and then the
22495 result against zero.
22497 * class.cs (TypeContainer.GetClassBases): We were checking for the
22498 parent class being sealed too late.
22500 * expression.cs (Binary.Emit): For <= and >= when dealing with
22501 floating point values, use cgt.un and clt.un instead of cgt and
22504 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22506 * statement.cs: Apply the same optimization as MS: skip the
22507 GetEnumerator returning an IEnumerator, and use the one returning a
22508 CharEnumerator instead. This allows us to avoid the try-finally block
22511 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22513 * cs-parser.jay: Attributes cannot be applied to
22514 namespaces. Fixes #40473
22516 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22519 (Add*): check if the name is valid using the full name for constants,
22520 fields, properties and events.
22522 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22524 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22525 char constants to be part of the enumeration.
22527 * expression.cs (Conditional.DoResolve): Add support for operator
22528 true. Implements the missing functionality from 14.12
22530 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22531 operator true/false as required by the spec.
22533 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22534 implicit conversion to boolean.
22536 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22537 also one where the type implements `operator true'.
22539 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22540 get an expression that will invoke operator true based on an
22543 (GetConversionOperators): Removed the hack that called op_True
22546 (Expression.ResolveBoolean): Move this from Statement.
22548 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22550 * ecore.cs (FieldExpr): do not allow initialization of initonly
22551 fields on derived classes
22553 2003-03-13 Martin Baulig <martin@ximian.com>
22555 * statement.cs (Block.Emit): Call ig.BeginScope() and
22556 ig.EndScope() when compiling with debugging info; call
22557 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22559 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22561 * expression.cs (Indexers): Do not construct immediately, allow
22562 for new members to be appended as we go. Fixes 38143
22564 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22566 * expression.cs: save/restore context when resolving an unchecked
22569 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22571 * cfold.cs: Catch division by zero in modulus operator during
22574 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22576 * interface.cs (Interface.DefineMembers): Avoid defining members
22579 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22581 * driver.cs: handle the +/- options for -noconfig
22583 * statement.cs (Unckeched.Resolve): Also track the state of
22584 unchecked in the Resolve phase.
22586 2003-02-27 Martin Baulig <martin@ximian.com>
22588 * ecore.cs (Expression.MemberLookup): Don't create a
22589 MethodGroupExpr for something which is not a method. Fixes #38291.
22591 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22593 * class.cs (MemberBase.CheckParameters): Also check that the type
22594 is unmanaged if it is a pointer.
22596 * expression.cs (SizeOf.Resolve): Add location information.
22598 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22599 a managed type is declared.
22601 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22602 parameter modifiers as well. Fixes bug 38606
22604 * class.cs: Very sad. Am backing out the speed up changes
22605 introduced by the ArrayList -> Array in the TypeContainer, as they
22606 were not actually that much faster, and introduced a bug (no error
22607 reports on duplicated methods).
22609 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22610 source first, this will guarantee that we have a valid expression
22611 before calling in lower levels functions that will require a
22612 resolved object. Then use this original_source in the
22613 target.ResolveLValue instead of the original source that was
22616 Another change. Use target.Resolve instead of LValueResolve.
22617 Although we are resolving for LValues, we will let the Assign code
22618 take care of that (it will be called again from Resolve). This
22619 basically allows code like this:
22621 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22622 class Y { void A (X x) { x [0] += o; }
22624 The problem was that the indexer was trying to resolve for
22625 set_Item (idx, object o) and never finding one. The real set_Item
22626 was set_Item (idx, X). By delaying the process we get the right
22631 2003-02-23 Martin Baulig <martin@ximian.com>
22633 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22634 while calling DoEmit ().
22636 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22637 source files; if you use the #line directive inside a method, the
22638 compiler stops emitting line numbers for the debugger until it
22639 reaches the end of the method or another #line directive which
22640 restores the original file.
22642 2003-02-23 Martin Baulig <martin@ximian.com>
22644 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22646 2003-02-23 Martin Baulig <martin@ximian.com>
22648 * statement.cs (Block.AddChildVariableNames): We need to call this
22649 recursively, not just for our immediate children.
22651 2003-02-23 Martin Baulig <martin@ximian.com>
22653 * class.cs (Event.Define): Always make the field private, like csc does.
22655 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22656 actually work, fixes bug #37521.
22658 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22660 * delegate.cs: When creating the various temporary "Parameters"
22661 classes, make sure that we call the ComputeAndDefineParameterTypes
22662 on those new parameters (just like we do with the formal ones), to
22663 allow them to be resolved in the context of the DeclSpace.
22665 This fixes the bug that Dick observed in Bugzilla #38530.
22667 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22669 * expression.cs (ResolveMemberAccess): When resolving a constant,
22670 do not attempt to pull a constant if the value was not able to
22671 generate a valid constant.
22673 * const.cs (LookupConstantValue): Do not report more errors than required.
22675 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22677 * expression.cs: fixes bug #38328.
22679 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22681 * class.cs: Changed all the various members that can be part of a
22682 class from being an ArrayList to be an Array of the right type.
22683 During the DefineType type_list, interface_list, delegate_list and
22684 enum_list are turned into types, interfaces, delegates and enums
22687 And during the member population, indexer_list, event_list,
22688 constant_list, field_list, instance_constructor_list, method_list,
22689 operator_list and property_list are turned into their real arrays.
22691 Although we could probably perform this operation earlier, for
22692 good error reporting we need to keep the lists and remove the
22693 lists for longer than required.
22695 This optimization was triggered by Paolo profiling the compiler
22696 speed on the output of `gen-sample-program.pl' perl script.
22698 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22699 not crash in methods like MemberLookupFailed that use this field.
22701 This problem arises when the compiler fails to resolve a type
22702 during interface type definition for example.
22704 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22706 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22707 inherit from System.Object, so we have to stop at null, not only
22708 when reaching System.Object.
22710 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22712 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22713 DeclaredOnly because the parent indexer might have had a different
22714 name, but did not loop until the top of the hierarchy was reached.
22716 The problem this one fixes is 35492: when a class implemented an
22717 indexer from an interface, we were getting the interface method
22718 (which was abstract) and we were flagging an error (can not invoke
22721 This also keeps bug 33089 functioning, and test-148 functioning.
22723 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22724 out if a method is special is to see if it is declared in a
22725 property or event, or whether it is one of the predefined operator
22726 names. This should fix correctly #36804.
22728 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22730 The goal here is to remove the dependency on EmptyCast.Peel ().
22731 Killing it completely.
22733 The problem is that currently in a number of places where
22734 constants are expected, we have to "probe" for an EmptyCast, and
22735 Peel, which is not the correct thing to do, as this will be
22736 repetitive and will likely lead to errors.
22738 The idea is to remove any EmptyCasts that are used in casts that
22739 can be reduced to constants, so we only have to cope with
22742 This bug hunt was triggered by Bug 37363 and the desire to remove
22743 the duplicate pattern where we were "peeling" emptycasts to check
22744 whether they were constants. Now constants will always be
22747 * ecore.cs: Use an enumconstant here instead of wrapping with
22750 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22751 throwing me off. By handling this we can get rid of a few hacks.
22753 * statement.cs (Switch): Removed Peel() code.
22755 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22757 * class.cs: Location information for error 508
22759 * expression.cs (New.DoResolve): Add a guard against double
22760 resolution of an expression.
22762 The New DoResolve might be called twice when initializing field
22763 expressions (see EmitFieldInitializers, the call to
22764 GetInitializerExpression will perform a resolve on the expression,
22765 and later the assign will trigger another resolution
22767 This leads to bugs (#37014)
22769 * delegate.cs: The signature for EndInvoke should contain any ref
22770 or out parameters as well. We were not doing this in the past.
22772 * class.cs (Field.Define): Do not overwrite the type definition
22773 inside the `volatile' group. Turns out that volatile enumerations
22774 were changing the type here to perform a validity test, which
22777 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22779 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22780 and structs, we do not want to load the instance variable
22782 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22783 enum_type has to be handled like an object reference (implicit
22784 conversions exists from this to object), but the regular IsClass
22785 and IsValueType tests will never return true for this one.
22787 Also we use TypeManager.IsValueType instead of type.IsValueType,
22788 just for consistency with the rest of the code (this is only
22789 needed if we ever use the construct exposed by test-180.cs inside
22790 corlib, which we dont today).
22792 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22794 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22797 2003-02-09 Martin Baulig <martin@ximian.com>
22799 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22800 (Namespace.DefineNamespaces): New static public method; this is
22801 called when we're compiling with debugging to add all namespaces
22802 to the symbol file.
22804 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22805 pass it to the Namespace's .ctor.
22807 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22808 and MethodBase arguments; pass the namespace ID to the symwriter;
22809 pass the MethodBase instead of the token to the symwriter.
22810 (SymbolWriter.DefineNamespace): New method to add a namespace to
22813 2003-02-09 Martin Baulig <martin@ximian.com>
22815 * symbolwriter.cs: New file. This is a wrapper around
22816 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22817 methods here in near future.
22819 2003-02-09 Martin Baulig <martin@ximian.com>
22821 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22822 ILGenerator.MarkSequencePoint() which are actually used by the
22825 2003-02-09 Martin Baulig <martin@ximian.com>
22827 * location.cs (SourceFile): New public sealed class. This
22828 contains the name and an index which is used in the location's token.
22829 (Location): Reserve an appropriate number of bits in the token for
22830 the source file instead of walking over that list, this gives us a
22831 really huge performance improvement when compiling with debugging.
22833 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22834 `SourceFile' argument instead of a string.
22835 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22836 but don't parse/tokenize here, we need to generate the list of all
22837 source files before we do that.
22838 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22841 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22842 instead of a string.
22844 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22847 2003-02-09 Martin Baulig <martin@ximian.com>
22849 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22850 filename on `#line default'.
22852 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22854 * statement.cs: don't clear the pinned var when the fixed statement
22855 returns from the method (fixes bug#37752).
22857 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22859 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22862 2003-02-07 Martin Baulig <martin@ximian.com>
22864 * driver.cs: Removed the `--debug-args' command line argument.
22866 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22867 automatically by the AsssemblyBuilder.
22868 (CodeGen.InitializeSymbolWriter): We don't need to call any
22869 initialization function on the symbol writer anymore. This method
22870 doesn't take any arguments.
22872 2003-02-03 Miguel de Icaza <miguel@ximian.com>
22874 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
22875 from referenced assemblies as well.
22877 2003-02-02 Martin Baulig <martin@ximian.com>
22879 * class.cs (MethodData.Emit): Generate debugging info for external methods.
22881 2003-02-02 Martin Baulig <martin@ximian.com>
22883 * class.cs (Constructor.Emit): Open the symbol writer before
22884 emitting the constructor initializer.
22885 (ConstructorInitializer.Emit): Call ec.Mark() to allow
22886 single-stepping through constructor initializers.
22888 2003-01-30 Miguel de Icaza <miguel@ximian.com>
22890 * class.cs: Handle error 549: do not allow virtual methods in
22893 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
22895 * decl.cs: Check access levels when resolving types
22897 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
22899 * statement.cs: Add parameters and locals set in catch blocks that might
22900 return to set vector
22902 2003-01-29 Miguel de Icaza <miguel@ximian.com>
22904 * class.cs (Operator): Set the SpecialName flags for operators.
22906 * expression.cs (Invocation.DoResolve): Only block calls to
22907 accessors and operators on SpecialName methods.
22909 (Cast.TryReduce): Handle conversions from char constants.
22912 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
22914 * statement.cs: small memory and time optimization in FlowBranching.
22916 2003-01-28 Pedro Mart <yoros@wanadoo.es>
22918 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
22919 problem that the last fix but in the other sid (Set).
22921 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
22922 access when there is no indexer in the hierarchy.
22924 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
22926 * class.cs: Combine some if statements.
22928 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22930 * driver.cs: fixed bug #37187.
22932 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
22934 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
22935 any indexer, it's needed to build a list with all the indexers in the
22936 hierarchy (AllGetters), else we have problems. Fixes #35653.
22938 2003-01-23 Miguel de Icaza <miguel@ximian.com>
22940 * class.cs (MethodData.Define): It is wrong for an interface
22941 implementation to be static in both cases: explicit and implicit.
22942 We were only handling this in one case.
22944 Improve the if situation there to not have negations.
22946 * class.cs (Field.Define): Turns out that we do not need to check
22947 the unsafe bit on field definition, only on usage. Remove the test.
22949 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22951 * driver.cs: use assembly.Location instead of Codebase (the latest
22952 patch made mcs fail when using MS assemblies).
22954 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
22956 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
22957 get the path to *corlib.dll.
22959 2003-01-21 Nick Drochak <ndrochak@gol.com>
22963 * typemanager.cs: Remove compiler warnings
22965 2003-01-20 Duncan Mak <duncan@ximian.com>
22967 * AssemblyInfo.cs: Bump the version number to 0.19.
22969 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22971 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
22973 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
22975 * class.cs (Constructor::Emit): Emit debugging info for constructors.
22977 2003-01-17 Miguel de Icaza <miguel@ximian.com>
22979 * cs-parser.jay: Small fix: we were not comparing the constructor
22980 name correctly. Thanks to Zoltan for the initial pointer.
22982 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
22984 * cs-tokenizer.cs: Set file name when specified with #line
22986 2003-01-15 Miguel de Icaza <miguel@ximian.com>
22988 * cs-parser.jay: Only perform the constructor checks here if we
22989 are named like the class; This will help provider a better
22990 error. The constructor path is taken when a type definition is
22991 not found, but most likely the user forgot to add the type, so
22992 report that rather than the constructor error.
22994 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
22996 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
22999 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23001 * cs-parser.jay: Add cleanup call.
23003 2003-01-13 Duncan Mak <duncan@ximian.com>
23005 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23006 consistent with other methods.
23008 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23010 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23012 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23014 * attribute.cs: only set GuidAttr to true when we have a
23017 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23021 * typemanager.cs: fixes to allow mcs compile corlib with the new
23022 Type.IsSubclassOf fix.
23024 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23026 * expression.cs (LocalVariableReference.DoResolve): Classify a
23027 constant as a value, not as a variable. Also, set the type for
23030 * cs-parser.jay (fixed_statement): take a type instead of a
23031 pointer_type, so we can produce a better error message later.
23033 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23036 (For.DoEmit): Make inifinite loops have a
23037 non-conditional branch back.
23039 (Fixed.DoEmit): First populate the pinned variables, then emit the
23040 statement, then clear the variables. Before I was emitting the
23041 code once for each fixed piece.
23044 2003-01-08 Martin Baulig <martin@ximian.com>
23046 * statement.cs (FlowBranching.MergeChild): A break in a
23047 SWITCH_SECTION does not leave a loop. Fixes #36155.
23049 2003-01-08 Martin Baulig <martin@ximian.com>
23051 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23052 lives in the same number space than `param_map'. Fixes #36154.
23054 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23056 * cs-parser.jay (constructor_declaration): Set the
23057 Constructor.ModFlags before probing for it. This makes the
23058 compiler report 514, 515 and 132 (the code was there, but got
23061 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23062 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23063 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23065 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23067 * enum.cs: create the enum static fields using the enum type.
23069 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23071 * class.cs: don't try to create the ParamBuilder for the return
23072 type if it's not needed (and handle it breaking for the ms runtime
23075 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23077 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23079 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23081 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23082 the command. This showed up while compiling the JANET source
23083 code, which used \r as its only newline separator.
23085 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23087 * class.cs (Method.Define): If we are an operator (because it
23088 reuses our code), then set the SpecialName and HideBySig. #36128
23090 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23092 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23093 exception, report error 120 `object reference required'.
23095 * driver.cs: Add --pause option, used during to measure the size
23096 of the process as it goes with --timestamp.
23098 * expression.cs (Invocation.DoResolve): Do not allow methods with
23099 SpecialName to be invoked.
23101 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23103 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23104 number before adding it.
23106 2002-12-21 Ravi Pratap <ravi@ximian.com>
23108 * ecore.cs (StandardImplicitConversion): When in an unsafe
23109 context, we allow conversion between void * to any other pointer
23110 type. This fixes bug #35973.
23112 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23114 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23115 is not thrown when extensionless outputs are used
23117 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23119 * rootcontext.cs: fixed compilation of corlib.
23121 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23123 * attribute.cs (Attributes.Contains): Add new method.
23125 * class.cs (MethodCore.LabelParameters): if the parameter is an
23126 `out' parameter, check that no attribute `[In]' has been passed.
23128 * enum.cs: Handle the `value__' name in an enumeration.
23130 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23132 * decl.cs: Added special case to allow overrides on "protected
23135 2002-12-18 Ravi Pratap <ravi@ximian.com>
23137 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23138 since it makes much more sense.
23140 (Attributes.ctor): Don't require a Location parameter.
23142 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23144 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23145 since we already have that information per attribute.
23147 * everywhere : make appropriate changes.
23149 * class.cs (LabelParameters): Write the code which actually
23150 applies attributes to the return type. We can't do this on the MS
23151 .NET runtime so we flag a warning in the case an exception is
23154 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23156 * const.cs: Handle implicit null conversions here too.
23158 2002-12-17 Ravi Pratap <ravi@ximian.com>
23160 * class.cs (MethodCore.LabelParameters): Remove the extra
23161 Type [] parameter since it is completely unnecessary. Instead
23162 pass in the method's attributes so that we can extract
23163 the "return" attribute.
23165 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23167 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23168 of ignoring it and letting the compile continue.
23170 * typemanager.cs (ChangeType): use an extra argument to return an
23171 error condition instead of throwing an exception.
23173 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23175 * expression.cs (Unary.TryReduce): mimic the code for the regular
23176 code path. Perform an implicit cast in the cases where we can
23177 implicitly convert to one of the integral types, and then reduce
23178 based on that constant. This fixes bug #35483.
23180 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23182 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23184 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23186 * namespace.cs: fixed bug #35489.
23188 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23190 * class.cs: Remove some dead code.
23192 * cs-parser.jay: Estimate the number of methods needed
23193 (RootContext.MethodCount);
23195 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23196 numbers instead of StringBuilders.
23198 * support.cs (PtrHashtable): Add constructor with initial size;
23199 We can now reduce reallocations of the method table.
23201 2002-12-10 Ravi Pratap <ravi@ximian.com>
23203 * attribute.cs (ApplyAttributes): Keep track of the emitted
23204 attributes on a per-target basis. This fixes bug #35413.
23206 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23208 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23209 default to the Windows 1252 encoding.
23211 (UnixParseOption): Support version, thanks to Alp for the missing
23214 * AssemblyInfo.cs: Add nice assembly information.
23216 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23219 * cs-parser.jay: Allow a trailing comma before the close bracked
23220 in the attribute_section production.
23222 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23223 address of the instance was being taken, I will take this out,
23224 because we take the address of the object immediately here.
23226 2002-12-09 Ravi Pratap <ravi@ximian.com>
23228 * typemanager.cs (AreMultipleAllowed): Take care of the most
23229 obvious case where attribute type is not in the current assembly -
23232 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23234 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23235 definitions, instead of doing that afterwards.
23237 Also we use a nice little hack, depending on the constructor, we
23238 know if we are a "composed" name or a simple name. Hence, we
23239 avoid the IndexOf test, and we avoid
23241 * codegen.cs: Add code to assist in a bug reporter to track down
23242 the source of a compiler crash.
23244 2002-12-07 Ravi Pratap <ravi@ximian.com>
23246 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23247 types have been emitted for a given element and flag an error
23248 if something which does not have AllowMultiple set is used more
23251 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23252 attribute types and their corresponding AllowMultiple properties
23254 (AreMultipleAllowed): Check the property for a given type.
23256 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23257 property in the case we have a TypeContainer.
23259 (Attributes.AddAttribute): Detect duplicates and just skip on
23260 adding them. This trivial fix catches a pretty gross error in our
23261 attribute emission - global attributes were being emitted twice!
23263 Bugzilla bug #33187 is now fixed.
23265 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23267 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23268 instead of pp_and).
23270 * expression.cs (Binary.ResolveOperator): I can only use the
23271 Concat (string, string, string) and Concat (string, string,
23272 string, string) if the child is actually a concatenation of
23275 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23277 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23278 context where we need a 2-character lookahead.
23280 * pending.cs (PendingImplementation): Rework so we can keep track
23281 of interface types all the time, and flag those which were
23282 implemented by parents as optional.
23284 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23286 * expression.cs (Binary.ResolveOperator): Use
23287 String.Concat(string,string,string) or
23288 String.Concat(string,string,string,string) when possible.
23290 * typemanager: More helper methods.
23293 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23295 * pending.cs: remove the bogus return from GetMissingInterfaces()
23296 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23298 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23300 * namespace.cs: avoid duplicated 'using xxx' being added to
23301 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23302 when we get more than one 'using' statement for the same namespace.
23303 Report a CS0105 warning for it.
23305 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23307 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23308 of calling getChar/putback, uses internal knowledge of it.
23310 (xtoken): Reorder tokenizer so most common patterns are checked
23311 first. This reduces the compilation time in another 5% (from 8.11s
23312 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23314 The parsing time is 22% of the compilation in mcs, and from that
23315 64% is spent on the tokenization process.
23317 I tried using a binary search for keywords, but this is slower
23318 than the hashtable. Another option would be to do a couple of
23321 * Not use a StringBuilder, instead use an array of chars,
23322 with a set value. Notice that this way we could catch
23323 the 645 error without having to do it *afterwards*.
23325 * We could write a hand-parser to avoid the hashtable
23326 compares altogether.
23328 The identifier consumption process takes 37% of the tokenization
23329 time. Another 15% is spent on is_number. 56% of the time spent
23330 on is_number is spent on Int64.Parse:
23332 * We could probably choose based on the string length to
23333 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23336 Another 3% is spend on wrapping `xtoken' in the `token' function.
23338 Handle 0xa0 as whitespace (#34752)
23340 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23342 * typemanager.cs (IsCLRType): New routine to tell whether a type
23343 is one of the builtin types.
23345 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23346 typecode in more places instead of doing pointer comparissions.
23347 We could leverage some knowledge about the way the typecodes are
23350 New code to cache namespaces in assemblies, it is currently not
23351 invoked, to be used soon.
23353 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23355 * expression.cs (Binary.ResolveOperator): specially handle
23356 strings, and do not perform user-defined operator overloading for
23359 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23361 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23362 internalcall as it is a pretty simple operation; Avoid whenever
23363 possible to call Char.IsLetter.
23365 (consume_identifier): Cut by half the number of
23366 hashtable calls by merging the is_keyword and GetKeyword behavior.
23368 Do not short-circuit, because if we do, we
23369 report errors (ie, #if false && true would produce an invalid
23373 2002-11-24 Martin Baulig <martin@ximian.com>
23375 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23376 check constant ranges and report a CS0221. Fixes #33186.
23378 2002-11-24 Martin Baulig <martin@ximian.com>
23380 * cs-parser.jay: Make this work for uninitialized variable
23381 declarations in the `for' initializer. Fixes #32416.
23383 2002-11-24 Martin Baulig <martin@ximian.com>
23385 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23386 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23388 2002-11-24 Martin Baulig <martin@ximian.com>
23390 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23391 argument; if true, we also check for user-defined conversions.
23392 This is only needed if both arguments are of a user-defined type.
23393 Fixes #30443, added test-175.cs.
23394 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23396 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23398 2002-11-24 Martin Baulig <martin@ximian.com>
23400 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23401 function to get the store opcode.
23402 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23403 only emit the Ldelema if the store opcode is Stobj. You must run
23404 both test-34 and test-167 to test this. Fixes #34529.
23406 2002-11-23 Martin Baulig <martin@ximian.com>
23408 * ecore.cs (Expression.MemberLookup): Added additional
23409 `qualifier_type' argument which is used when we're being called
23410 from MemberAccess.DoResolve() and null if we're called from a
23412 (Expression.MemberLookupFailed): New method to report errors; this
23413 does the CS1540 check and reports the correct error message.
23415 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23416 argument for the CS1540 check and redone the way how we're dealing
23417 with private members. See the comment in the source code for details.
23418 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23419 `closure_start_type' to `closure_qualifier_type' and check whether
23420 it's not null. It was not this filter being broken, it was just
23421 being called with the wrong arguments.
23423 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23424 and pass it the correct `qualifier_type'; this also does the error
23427 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23429 * expression.cs (Invocation.EmitParams): If the we are dealing
23430 with a non-built-in value type, load its address as well.
23432 (ArrayCreation): Use a a pretty constant instead
23433 of the hardcoded value 2. Use 6 instead of 2 for the number of
23434 static initializers.
23436 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23437 because they are not really value types, just glorified integers.
23439 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23441 * ecore.cs: Remove redundant code for enumerations, make them use
23442 the same code path as everything else, fixes the casting issue
23443 with enumerations in Windows.Forms.
23445 * attribute.cs: Do only cast to string if it is a string, the
23446 validation happens later.
23448 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23449 people upgrade their corlibs.
23451 * ecore.cs: Oops, enumerations were not following the entire code path
23453 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23455 * typemanager.cs (FilterWithClosure): Commented out the test for
23456 1540 in typemanager.cs, as it has problems when accessing
23457 protected methods from a parent class (see test-174.cs).
23459 * attribute.cs (Attribute.ValidateGuid): new method.
23460 (Attribute.Resolve): Use above.
23462 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23464 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23466 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23467 handling for enumerations, as we only needed the TypeContainer
23468 functionality to begin with (this is required for the fix below to
23469 work for enums that reference constants in a container class for
23472 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23474 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23475 a valid TypeBuilder to perform lookups on.o
23477 * class.cs (InheritableMemberSignatureCompare): Use true in the
23478 call to GetGetMethod and GetSetMethod, because we are comparing
23479 the signature, and we need to get the methods *even* if they are
23482 (PropertyBase.CheckBase): ditto.
23484 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23485 GotoCase.Resolve): Use Peel on EmpytCasts.
23487 * ecore.cs (EmptyCast): drop child, add Peel method.
23489 2002-11-17 Martin Baulig <martin@ximian.com>
23491 * ecore.cs (EmptyCast.Child): New public property.
23493 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23494 label resolved to an EmptyCast. Fixes #34162.
23495 (GotoCase.Resolve): Likewise.
23496 (Block.EmitMeta): Likewise.
23498 2002-11-17 Martin Baulig <martin@ximian.com>
23500 * expression.cs (Invocation.BetterConversion): Prefer int over
23501 uint; short over ushort; long over ulong for integer literals.
23502 Use ImplicitConversionExists instead of StandardConversionExists
23503 since we also need to check for user-defined implicit conversions.
23504 Fixes #34165. Added test-173.cs.
23506 2002-11-16 Martin Baulig <martin@ximian.com>
23508 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23509 with the `true' and `false' literals. Fixes #33151.
23511 2002-11-16 Martin Baulig <martin@ximian.com>
23513 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23514 October 22nd; don't do the cs1540 check for static members.
23516 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23517 now using our own filter here and doing the cs1540 check again.
23519 2002-11-16 Martin Baulig <martin@ximian.com>
23521 * support.cs (InternalParameters): Don't crash if we don't have
23522 any fixed parameters. Fixes #33532.
23524 2002-11-16 Martin Baulig <martin@ximian.com>
23526 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23527 when looking up static methods to make this work on Windows.
23530 2002-11-16 Martin Baulig <martin@ximian.com>
23532 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23533 a setter rather than using PropertyInfo.CanWrite.
23535 2002-11-15 Nick Drochak <ndrochak@gol.com>
23537 * class.cs: Allow acces to block member by subclasses. Fixes build
23540 2002-11-14 Martin Baulig <martin@ximian.com>
23542 * class.cs (Constructor.Emit): Added the extern/block check.
23545 2002-11-14 Martin Baulig <martin@ximian.com>
23547 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23548 iteration while looking for indexers, this is needed because the
23549 indexer may have a different name in our base classes. Fixed the
23550 error reporting (no indexers at all, not get accessor, no
23551 overloaded match). Fixes bug #33089.
23552 (IndexerAccess.DoResolveLValue): Likewise.
23554 2002-11-14 Martin Baulig <martin@ximian.com>
23556 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23557 indexers. Fixes the first part of bug #33089.
23558 (MethodSignature.InheritableMemberSignatureCompare): Added support
23561 2002-11-13 Ravi Pratap <ravi@ximian.com>
23563 * attribute.cs (Attribute.Resolve): Catch the
23564 NullReferenceException and report it since it isn't supposed to
23567 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23569 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23570 LogicalOr and LogicalAnd that can benefit from recursively
23571 handling EmitBranchable. The code now should be nice for Paolo.
23573 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23575 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23576 the Type lookups, as we perform quite a number of lookups on
23577 non-Types. This can be removed once we can deterministically tell
23578 whether we have a type or a namespace in advance.
23580 But this might require special hacks from our corlib.
23584 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23585 and double which avoids a conversion from an integer to a double.
23587 * expression.cs: tiny optimization, avoid calling IsConstant,
23588 because it effectively performs the lookup twice.
23590 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23592 But a bogus return here to keep the semantics of the old code
23593 until the Mono runtime is fixed.
23595 * pending.cs (GetMissingInterfaces): New method used to remove all
23596 the interfaces that are already implemented by our parent
23597 classes from the list of pending methods.
23599 * interface.cs: Add checks for calls after ResolveTypeExpr.
23601 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23603 * class.cs (Class.Emit): Report warning 67: event not used if the
23604 warning level is beyond 3.
23606 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23607 being a NullLiteral.
23609 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23612 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23613 path that might fail if a type can not be resolved.
23615 * expression.cs (Binary.Emit): Emit unsigned versions of the
23618 * driver.cs: use error 5.
23620 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23622 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23624 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23626 * cs-parser.jay (switch_section): A beautiful patch from Martin
23627 Baulig that fixed 33094.
23629 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23631 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23632 Check whether the base is abstract and report an error if so.
23634 * expression.cs (IndexerAccess.DoResolveLValue,
23635 IndexerAccess.DoResolve): ditto.
23637 (Invocation.DoResolve): ditto.
23639 (Invocation.FullMethodDesc): Improve the report string.
23641 * statement.cs (Block): Eliminate IsVariableDefined as it is
23642 basically just a wrapper for GetVariableInfo.
23644 * ecore.cs (SimpleName): Use new
23646 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23647 type, as we return the actual parameter ref/unref state on a
23650 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23652 * support.cs: Return proper flags REF/OUT fixing the previous
23655 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23656 not used to mean `ref' but `ref or out' in ParameterReference
23658 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23659 full type signature instead of calling TypeManger.CSharpName
23662 * support.cs (InternalParameters.ParameterDesc): Do not compare
23663 directly to the modflags, because REF/OUT will actually be bitsets
23666 * delegate.cs (VerifyMethod): Check also the modifiers.
23668 * cs-tokenizer.cs: Fix bug where floating point values with an
23669 exponent where a sign was missing was ignored.
23671 * driver.cs: Allow multiple assemblies to be specified in a single
23674 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23676 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23677 because identifiers after a parenthesis would end up in this kind
23678 of production, and we needed to desamiguate it for having casts
23681 (UserDefinedType *) xxx
23683 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23685 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23686 we should set on the Bindingflags.NonPublic, but not turn on
23687 private_ok. private_ok controls whether a Private member is
23688 returned (this is chekced on the filter routine), while the
23689 BindingFlags.NonPublic just controls whether private/protected
23690 will be allowed. This fixes the problem part of the problem of
23691 private properties being allowed to be used in derived classes.
23693 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23694 so we can call the children DoResolveLValue method (this will
23695 properly signal errors on lvalue assignments to base properties)
23697 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23698 getter are null, and we have a property info, we know that this
23699 happened because the lookup failed, so we report an error 122 for
23700 protection level violation.
23702 We also silently return if setter and getter are null in the
23703 resolve functions, this condition only happens if we have flagged
23704 the error before. This is the other half of the problem.
23706 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23707 not have accessibility information, that is why we were returning
23708 true in the filter function in typemanager.cs.
23710 To properly report 122 (property is inaccessible because of its
23711 protection level) correctly, we report this error in ResolveAccess
23712 by failing if both the setter and the getter are lacking (ie, the
23715 DoResolve and DoLResolve have been modified to check for both
23716 setter/getter being null and returning silently, the reason being
23717 that I did not want to put the knowledge about this error in upper
23720 int old = Report.Errors;
23721 x = new PropertyExpr (...);
23722 if (old != Report.Errors)
23727 So the property expr is returned, but it is invalid, so the error
23728 will be flagged during the resolve process.
23730 * class.cs: Remove InheritablePropertySignatureCompare from the
23731 class, as we no longer depend on the property signature to compute
23732 whether it is possible to implement a method or not.
23734 The reason is that calling PropertyInfo.GetGetMethod will return
23735 null (in .NET, in Mono it works, and we should change this), in
23736 cases where the Get Method does not exist in that particular
23741 class X { public virtual int A { get { return 1; } } }
23743 class Z : Y { public override int A { get { return 2; } } }
23745 Would fail in Z because the parent (Y) would not have the property
23746 defined. So we avoid this completely now (because the alternative
23747 fix was ugly and slow), and we now depend exclusively on the
23750 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23751 reference method, instead of using the property.
23753 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23754 routines are gone now.
23756 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23757 names, they were incorrectly named.
23759 * cs-tokenizer.cs: Return are more gentle token on failure.
23761 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23762 had an out-of-sync index variable, which caused it to remove from
23763 the list of pending methods the wrong method sometimes.
23765 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23767 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23768 CanWrite, because those refer to this particular instance of the
23769 property, and do not take into account the fact that we can
23770 override single members of a property.
23772 Constructor requires an EmitContext. The resolution process does
23773 not happen here, but we need to compute the accessors before,
23774 because the resolution does not always happen for properties.
23776 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23777 subclass, before we did not update this flag, but we did update
23780 (GetAccessors): Drop this routine, as it did not work in the
23781 presence of partially overwritten set/get methods.
23783 Notice that this broke the cs1540 detection, but that will require
23786 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23790 * driver.cs: issue a warning instead of an error if we don't support
23791 debugging for the platform. Also ignore a couple of errors that may
23792 arise when trying to write the symbols. Undo my previous patch.
23794 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23796 * driver.cs: ignore /debug switch except for Unix platforms.
23798 2002-10-23 Nick Drochak <ndrochak@gol.com>
23800 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23802 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23804 * driver.cs: Do not make mcs-debug conditional, so we do not break
23805 builds that use it.
23807 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23808 review this patch. But basically after all the children variables
23809 have been merged, the value of "Breaks" was not being set to
23810 new_breaks for Switch blocks. I think that it should be set after
23811 it has executed. Currently I set this to the value of new_breaks,
23812 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23813 conservative, but I do not understand this code very well.
23815 I did not break anything in the build, so that is good ;-)
23817 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23819 2002-10-20 Mark Crichton <crichton@gimp.org>
23821 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23823 2002-10-20 Nick Drochak <ndrochak@gol.com>
23825 * cfold.cs: Fixed compile blocker.
23827 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23829 * driver.cs: I was chekcing the key, not the file.
23831 2002-10-19 Ravi Pratap <ravi@ximian.com>
23833 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23834 message that we were generating - we just need to silently return
23837 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23839 * class.cs (Event.Define): Change my previous commit, as this
23840 breaks the debugger. This is a temporary hack, as it seems like
23841 the compiler is generating events incorrectly to begin with.
23843 * expression.cs (Binary.ResolveOperator): Added support for
23844 "U operator - (E x, E y)"
23846 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23849 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23850 init-only variables, but this path did not take into account that
23851 there might be also instance readonly variables. Correct this
23854 This fixes bug 32253
23856 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23859 * driver.cs: Change the extension for modules to `netmodule'
23861 * cs-parser.jay: Improved slightly the location tracking for
23862 the debugger symbols.
23864 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23865 modifiers that were specified instead of the hardcoded value
23866 (FamAndAssem). This was basically ignoring the static modifier,
23867 and others. Fixes 32429.
23869 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23870 fixed a bug in the process (32476)
23872 * expression.cs (ArrayAccess.EmitAssign): Patch from
23873 hwang_rob@yahoo.ca that fixes bug 31834.3
23875 2002-10-18 Miguel de Icaza <miguel@ximian.com>
23877 * driver.cs: Make the module extension .netmodule.
23879 2002-10-16 Miguel de Icaza <miguel@ximian.com>
23881 * driver.cs: Report an error if the resource file is not found
23882 instead of crashing.
23884 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
23885 false, like Emit does.
23887 2002-10-16 Nick Drochak <ndrochak@gol.com>
23889 * typemanager.cs: Remove unused private member. Also reported mcs
23890 bug to report this as a warning like csc.
23892 2002-10-15 Martin Baulig <martin@gnome.org>
23894 * statement.cs (Statement.Emit): Made this a virtual method; emits
23895 the line number info and calls DoEmit().
23896 (Statement.DoEmit): New protected abstract method, formerly knows
23897 as Statement.Emit().
23899 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
23901 2002-10-11 Miguel de Icaza <miguel@ximian.com>
23903 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
23904 have fixed a remaining problem: not every AddXXXX was adding a
23905 fully qualified name.
23907 Now everyone registers a fully qualified name in the DeclSpace as
23908 being defined instead of the partial name.
23910 Downsides: we are slower than we need to be due to the excess
23911 copies and the names being registered this way.
23913 The reason for this is that we currently depend (on the corlib
23914 bootstrap for instance) that types are fully qualified, because
23915 we dump all the types in the namespace, and we should really have
23916 types inserted into the proper namespace, so we can only store the
23917 basenames in the defined_names array.
23919 2002-10-10 Martin Baulig <martin@gnome.org>
23921 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
23922 from bug #31834, see the bug report for a testcase which is
23925 2002-10-10 Martin Baulig <martin@gnome.org>
23927 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
23928 flow analysis code for this.
23930 * statement.cs (Do, While, For): Tell the flow analysis code about
23932 (FlowBranching.UsageVector): Added support for infinite loops.
23933 (Block.Resolve): Moved the dead code elimination here and use flow
23936 2002-10-09 Miguel de Icaza <miguel@ximian.com>
23938 * class.cs (Field.Define): Catch cycles on struct type
23941 * typemanager.cs (IsUnmanagedtype): Do not recursively check
23942 fields if the fields are static. We only need to check instance
23945 * expression.cs (As.DoResolve): Test for reference type.
23947 * statement.cs (Using.ResolveExpression): Use
23948 ConvertImplicitRequired, not ConvertImplicit which reports an
23950 (Using.ResolveLocalVariableDecls): ditto.
23952 * expression.cs (Binary.ResolveOperator): Report errors in a few
23953 places where we had to.
23955 * typemanager.cs (IsUnmanagedtype): Finish implementation.
23957 2002-10-08 Miguel de Icaza <miguel@ximian.com>
23959 * expression.cs: Use StoreFromPtr instead of extracting the type
23960 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
23962 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
23963 an enumeration value to a System.Enum, but System.Enum is not a
23964 value type, but an class type, so we need to box.
23966 (Expression.ConvertExplicit): One codepath could return
23967 errors but not flag them. Fix this. Fixes #31853
23969 * parameter.cs (Resolve): Do not allow void as a parameter type.
23971 2002-10-06 Martin Baulig <martin@gnome.org>
23973 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
23974 if it's a class type and not a struct. Fixes #31815.
23976 2002-10-06 Martin Baulig <martin@gnome.org>
23978 * statement.cs: Reworked the flow analysis code a bit to make it
23979 usable for dead code elimination.
23981 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23983 * cs-parser.jay: allow empty source files. Fixes bug #31781.
23985 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23987 * expression.cs (ComposedCast.DoResolveType): A quick workaround
23988 to fix the test 165, will investigate deeper.
23990 2002-10-04 Martin Baulig <martin@gnome.org>
23992 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
23993 finally blocks actually work.
23994 (Try.Resolve): We don't need to create a sibling for `finally' if
23995 there is no finally block.
23997 2002-10-04 Martin Baulig <martin@gnome.org>
23999 * class.cs (Constructor.Define): The default accessibility for a
24000 non-default constructor is private, not public.
24002 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24004 * class.cs (Constructor): Make AllowedModifiers public, add
24007 * cs-parser.jay: Perform the modifiers test here, as the
24008 constructor for the Constructor class usually receives a zero
24009 because of the way we create it (first we create, later we
24010 customize, and we were never checking the modifiers).
24012 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24013 is a version of LookupTypeReflection that includes the type-name
24014 cache. This can be used as a fast path for functions that know
24015 the fully qualified name and are only calling into *.GetType() to
24016 obtain a composed type.
24018 This is also used by TypeManager.LookupType during its type
24021 (LookupType): We now also track the real type name, as sometimes
24022 we can get a quey for the real type name from things like
24023 ComposedCast. This fixes bug 31422.
24025 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24026 complete type fullname, it does not have to go through the type
24027 resolution system to obtain the composed version of the type (for
24028 obtaining arrays or pointers).
24030 (Conditional.Emit): Use the EmitBoolExpression to
24031 generate nicer code, as requested by Paolo.
24033 (ArrayCreation.CheckIndices): Use the patch from
24034 hwang_rob@yahoo.ca to validate the array initializers.
24036 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24038 * class.cs (ConstructorInitializer.Emit): simplify code by using
24039 Invocation.EmitCall, and at the same time, fix the bugs in calling
24040 parent constructors that took variable arguments.
24042 * ecore.cs (Expression.ConvertNumericExplicit,
24043 Expression.ImplicitNumericConversion): Remove the code that
24044 manually wrapped decimal (InternalTypeConstructor call is now gone
24047 * expression.cs (Cast.TryReduce): Also handle decimal types when
24048 trying to perform a constant fold on the type.
24050 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24052 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24053 that only turned off an error report, and did nothing else.
24055 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24057 * driver.cs: Handle and ignore /fullpaths
24059 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24061 * expression.cs (Binary.ResolveOperator): Catch the case where
24062 DoNumericPromotions returns true,
24064 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24066 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24068 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24071 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24073 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24074 conversion exists, but it is also required that the conversion be
24075 performed. This manifested in "(Type64Enum) 2".
24077 * class.cs (TypeManager.AddMethod): The fix is not to change
24078 AddEnum, because that one was using a fully qualified name (every
24079 DeclSpace derivative does), but to change the AddMethod routine
24080 that was using an un-namespaced name. This now correctly reports
24081 the duplicated name.
24083 Revert patch until I can properly fix it. The issue
24084 is that we have a shared Type space across all namespaces
24085 currently, which is wrong.
24087 Options include making the Namespace a DeclSpace, and merge
24088 current_namespace/current_container in the parser.
24090 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24092 * cs-parser.jay: Improve error reporting when we get a different
24093 kind of expression in local_variable_type and
24094 local_variable_pointer_type.
24096 Propagate this to avoid missleading errors being reported.
24098 * ecore.cs (ImplicitReferenceConversion): treat
24099 TypeManager.value_type as a target just like object_type. As
24104 Is valid, and needs to result in the int 1 being boxed before it
24105 is assigned to the value type v.
24107 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24108 to validate the enumeration name.
24110 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24111 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24112 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24114 * ecore.cs (TryImplicitIntConversion): When doing an
24115 implicit-enumeration-conversion, check if the type is 64-bits and
24116 perform a conversion before passing to EnumConstant.
24118 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24120 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24121 report ambiguous type references. Unlike the MS version, we
24122 report what the ambiguity is. Innovation at work ;-)
24124 (DeclSpace.FindType): Require a location argument to
24125 display when we display an ambiguous error.
24127 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24129 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24131 * expression.cs (EmitDynamicInitializers): Apply patch from
24132 hwang_rob@yahoo.ca that fixes the order in which we emit our
24135 2002-09-21 Martin Baulig <martin@gnome.org>
24137 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24138 delegate takes no arguments.
24140 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24142 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24145 * expression.cs: Extract the underlying type.
24147 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24149 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24151 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24153 * class.cs (TypeContainer.DefineType): We can not use the nice
24154 PackingSize with the size set to 1 DefineType method, because it
24155 will not allow us to define the interfaces that the struct
24158 This completes the fixing of bug 27287
24160 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24161 means also structs. This fixes part of the problem.
24162 (Expresion.ImplicitReferenceConversionExists): ditto.
24164 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24165 error if there were no errors reported during the type lookup
24166 process, to avoid duplicates or redundant errors. Without this
24167 you would get an ambiguous errors plus a type not found. We have
24168 beaten the user enough with the first error.
24170 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24173 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24174 during the resolution process, stop the lookup, this avoids
24175 repeated error reports (same error twice).
24177 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24179 * typemanager.cs (LookupType): Redo the type lookup code to match
24180 the needs of System.Reflection.
24182 The issue is that System.Reflection requires references to nested
24183 types to begin with a "+" sign instead of a dot. So toplevel
24184 types look like: "NameSpace.TopLevelClass", and nested ones look
24185 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24188 2002-09-19 Martin Baulig <martin@gnome.org>
24190 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24191 says that a method always returns or always throws an exception,
24192 don't report the CS0161.
24194 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24195 set `Returns = new_returns'.
24197 2002-09-19 Martin Baulig <martin@gnome.org>
24199 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24200 to an enum constant, check for a CS0176.
24202 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24204 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24205 for operators that must be in pairs and report errors.
24207 * ecore.cs (SimpleName.DoResolveType): During the initial type
24208 resolution process, when we define types recursively, we must
24209 check first for types in our current scope before we perform
24210 lookups in the enclosing scopes.
24212 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24214 (Invocation.VerifyArgumentsCompat): Call
24215 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24216 I thought we were supposed to always call this, but there are a
24217 few places in the code where we dont do it.
24219 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24221 * driver.cs: Add support in -linkres and -resource to specify the
24222 name of the identifier.
24224 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24226 * ecore.cs (StandardConversionExists): Sync with the conversion
24227 code: allow anything-* to void* conversions.
24229 (FindMostSpecificSource): Use an Expression argument
24230 instead of a Type, because we might be handed over a Literal which
24231 gets a few more implicit conversions that plain types do not. So
24232 this information was being lost.
24234 Also, we drop the temporary type-holder expression when not
24237 2002-09-17 Martin Baulig <martin@gnome.org>
24239 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24240 this is an explicit interface implementation.
24242 2002-09-17 Martin Baulig <martin@gnome.org>
24244 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24245 different `IndexerName' attributes.
24247 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24248 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24249 virtual CommonResolve().
24251 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24253 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24254 and convert that to the UnderlyingType.
24256 * statement.cs (Foreach.Resolve): Indexers are just like variables
24257 or PropertyAccesses.
24259 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24260 inside quoted strings, we were not doing this before.
24262 2002-09-16 Martin Baulig <martin@gnome.org>
24264 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24265 resolve it. This is needed for the definite assignment check of the
24266 instance expression, fixes bug #29846.
24267 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24269 2002-09-16 Nick Drochak <ndrochak@gol.com>
24271 * parameter.cs: Fix compile error. Cannot reference static member
24272 from an instance object. Is this an mcs bug?
24274 2002-09-14 Martin Baulig <martin@gnome.org>
24276 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24277 multiple times. Fixes bug #30295, added test-166.cs.
24279 2002-09-14 Martin Baulig <martin@gnome.org>
24281 * statement.cs (Block.Emit): Don't emit unreachable code.
24282 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24283 `break' statements.
24284 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24286 2002-09-14 Martin Baulig <martin@gnome.org>
24288 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24291 2002-09-14 Martin Baulig <martin@gnome.org>
24293 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24294 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24295 be false on the ms runtime.
24297 2002-09-13 Martin Baulig <martin@gnome.org>
24299 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24300 the CS0038 error message.
24302 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24304 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24305 constant inside, return it.
24307 2002-09-12 Martin Baulig <martin@gnome.org>
24309 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24310 implicit conversion can be done between enum types.
24312 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24313 check whether an implicit conversion to the current enum's UnderlyingType
24314 exists and report an error if not.
24316 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24317 without debugging support.
24319 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24320 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24322 2002-09-12 Martin Baulig <martin@gnome.org>
24324 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24326 * ecore.cs (IMemberExpr.DeclaringType): New property.
24327 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24328 nonstatic member of an outer type (CS0038).
24330 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24332 * driver.cs: Activate the using-error detector at warning level
24333 4 (at least for MS-compatible APIs).
24335 * namespace.cs (VerifyUsing): Small buglett fix.
24337 * pending.cs (PendingImplementation): pass the container pointer.
24339 * interface.cs (GetMethods): Allow for recursive definition. Long
24340 term, I would like to move every type to support recursive
24341 definitions, not the current ordering mechanism that we have right
24344 The situation is this: Attributes are handled before interfaces,
24345 so we can apply attributes to interfaces. But some attributes
24346 implement interfaces, we will now handle the simple cases
24347 (recursive definitions will just get an error).
24349 * parameter.cs: Only invalidate types at the end if we fail to
24352 2002-09-09 Martin Baulig <martin@gnome.org>
24354 * ecore.cs (PropertyExpr.Emit): Also check for
24355 TypeManager.system_int_array_get_length so this'll also work when
24356 compiling corlib. Fixes #30003.
24358 2002-09-09 Martin Baulig <martin@gnome.org>
24360 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24361 and throw an exception if we can't get the type's size. Fixed #30040,
24364 2002-09-09 Martin Baulig <martin@gnome.org>
24366 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24368 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24369 context. Fixes bug #30027.
24371 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24372 virtual functions. Fixes bug #30043, added test-164.cs.
24374 2002-09-08 Ravi Pratap <ravi@ximian.com>
24376 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24378 2002-09-08 Nick Drochak <ndrochak@gol.com>
24380 * driver.cs: Use an object to get the windows codepage since it's not a
24383 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24385 * statement.cs (For.Emit): for infinite loops (test == null)
24386 return whether there is a break inside, not always "true".
24388 * namespace.cs (UsingEntry): New struct to hold the name of the
24389 using definition, the location where it is defined, and whether it
24390 has been used in a successful type lookup.
24392 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24397 2002-09-06 Ravi Pratap <ravi@ximian.com>
24399 * attribute.cs : Fix incorrect code which relied on catching
24400 a NullReferenceException to detect a null being passed in
24401 where an object was expected.
24403 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24405 * statement.cs (Try): flag the catch variable as assigned
24407 * expression.cs (Cast): Simplified by using ResolveType instead of
24408 manually resolving.
24410 * statement.cs (Catch): Fix bug by using ResolveType.
24412 2002-09-06 Ravi Pratap <ravi@ximian.com>
24414 * expression.cs (BetterConversion): Special case for when we have
24415 a NullLiteral as the argument and we have to choose between string
24416 and object types - we choose string the way csc does.
24418 * attribute.cs (Attribute.Resolve): Catch the
24419 NullReferenceException and report error #182 since the Mono
24420 runtime no more has the bug and having this exception raised means
24421 we tried to select a constructor which takes an object and is
24424 2002-09-05 Ravi Pratap <ravi@ximian.com>
24426 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24427 message (1502, 1503) when we can't locate a method after overload
24428 resolution. This is much more informative and closes the bug
24431 * interface.cs (PopulateMethod): Return if there are no argument
24432 types. Fixes a NullReferenceException bug.
24434 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24435 expressions too. Previously we were checking only in one place for
24436 positional arguments leaving out named arguments.
24438 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24439 type to the enum type is not allowed. Remove code corresponding to
24442 (ConvertNumericExplicit): Allow explicit conversions from
24443 the underlying type to enum type. This precisely follows the spec
24444 and closes a bug filed by Gonzalo.
24446 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24449 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24451 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24453 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24454 it was important that we stored the right value after the
24455 reduction in `converted'.
24457 2002-09-04 Martin Baulig <martin@gnome.org>
24459 * location.cs (Location.SymbolDocument): Use full pathnames for the
24462 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24464 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24465 of the expression resolve mechanism, because that will catch the
24466 SimpleName error failures.
24468 (Conditional): If we can not resolve the
24469 expression, return, do not crash.
24471 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24474 (location): display token name instead of its number.
24476 2002-08-28 Martin Baulig <martin@gnome.org>
24478 * expression.cs (Binary.ResolveOperator): Don't silently return
24479 but return an error if an operator cannot be applied between two
24482 2002-08-28 Martin Baulig <martin@gnome.org>
24484 * class.cs (Constructor.Define): Set the permission attributes
24485 correctly instead of making all constructors public.
24487 2002-08-28 Martin Baulig <martin@gnome.org>
24489 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24490 for private members before reporting a CS0103; if we find anything,
24493 2002-08-28 Martin Baulig <martin@gnome.org>
24495 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24496 to check whether `closure_start_type == closure_invocation_type',
24497 we also need to check whether `m.DeclaringType == closure_invocation_type'
24498 before bypassing the permission checks. We might be accessing
24499 protected/private members from the base class.
24500 (TypeManager.RealMemberLookup): Only set private_ok if private
24501 members were requested via BindingFlags.NonPublic.
24503 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24505 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24506 MethodGroupExpr.IsExplicitImpl if appropriate.
24507 (Invocation.DoResolve): Don't report the CS0120 for explicit
24508 interface implementations.
24510 2002-08-27 Martin Baulig <martin@gnome.org>
24512 * expression.cs (Invocation.DoResolve): If this is a static
24513 method and we don't have an InstanceExpression, we must report
24516 2002-08-25 Martin Baulig <martin@gnome.org>
24518 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24519 `==' between a valuetype and an object.
24521 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24523 * ecore.cs (TypeExpr): Provide a ToString method.
24525 2002-08-24 Martin Baulig <martin@gnome.org>
24527 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24528 now called proggie.dbg and it's a binary file.
24530 2002-08-23 Martin Baulig <martin@gnome.org>
24532 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24534 2002-08-23 Martin Baulig <martin@gnome.org>
24536 * struct.cs (MyStructInfo.ctor): Make this work with empty
24537 structs; it's not allowed to use foreach() on null.
24539 2002-08-23 Martin Baulig <martin@gnome.org>
24541 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24542 writer the full pathname of the generated assembly.
24544 2002-08-23 Martin Baulig <martin@gnome.org>
24546 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24547 A `finally' block never returns or breaks; improved handling of
24550 2002-08-23 Martin Baulig <martin@gnome.org>
24552 * statement.cs (Throw.Resolve): Allow `throw null'.
24554 2002-08-23 Martin Baulig <martin@gnome.org>
24556 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24557 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24558 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24559 MemberLookup would return a wrong event if this is an explicit
24560 interface implementation and the class has an event with the same
24563 2002-08-23 Martin Baulig <martin@gnome.org>
24565 * statement.cs (Block.AddChildVariableNames): New public method.
24566 (Block.AddChildVariableName): Likewise.
24567 (Block.IsVariableNameUsedInChildBlock): Likewise.
24568 (Block.AddVariable): Check whether a variable name has already
24569 been used in a child block.
24571 * cs-parser.jay (declare_local_variables): Mark all variable names
24572 from the current block as being used in a child block in the
24575 2002-08-23 Martin Baulig <martin@gnome.org>
24577 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24578 find the symbol writer.
24580 * driver.cs: csc also allows the arguments to /define being
24581 separated by commas, not only by semicolons.
24583 2002-08-23 Martin Baulig <martin@gnome.org>
24585 * interface.cs (Interface.GetMembers): Added static check for events.
24587 2002-08-15 Martin Baulig <martin@gnome.org>
24589 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24590 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24592 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24593 why the MethodData.EmitDestructor() change was necessary.
24595 2002-08-20 Martin Baulig <martin@gnome.org>
24597 * class.cs (TypeContainer.FindMembers): Added static check for events.
24599 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24601 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24602 use Type.GetEvents(), not Type.FindMembers().
24604 2002-08-20 Martin Baulig <martin@gnome.org>
24606 * decl.cs (MemberCache): Added a special method cache which will
24607 be used for method-only searched. This ensures that a method
24608 search will return a MethodInfo with the correct ReflectedType for
24611 2002-08-20 Martin Baulig <martin@gnome.org>
24613 * decl.cs (DeclSpace.FindMembers): Made this public.
24615 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24617 * delegate.cs: fixed build on windows.
24618 [FIXME: Filed as bug #29150: MCS must report these errors.]
24620 2002-08-19 Ravi Pratap <ravi@ximian.com>
24622 * ecore.cs (StandardConversionExists): Return a false
24623 if we are trying to convert the void type to anything else
24624 since that is not allowed.
24626 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24627 we flag error 70 in the event an event is trying to be accessed
24628 directly from outside the declaring type.
24630 2002-08-20 Martin Baulig <martin@gnome.org>
24632 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24633 MemberCache from typemanager.cs to decl.cs.
24635 2002-08-19 Martin Baulig <martin@gnome.org>
24637 * class.cs (TypeContainer): Implement IMemberContainer.
24638 (TypeContainer.DefineMembers): Create the MemberCache.
24639 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24640 return public members if BindingFlags.Public was given, check
24641 whether members are static.
24643 2002-08-16 Martin Baulig <martin@gnome.org>
24645 * decl.cs (DeclSpace.Define): Splitted this in Define and
24646 DefineMembers. DefineMembers is called first and initializes the
24649 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24650 DefineMembers() on all our DeclSpaces.
24652 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24653 but call DefineMembers() on all nested interfaces. We call their
24654 Define() in our new Define() function.
24656 * interface.cs (Interface): Implement IMemberContainer.
24657 (Interface.Define): Moved all code except the attribute stuf to
24659 (Interface.DefineMembers): Initialize the member cache.
24661 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24662 need this anymore since we can use MemberCache.FindMembers directly.
24664 2002-08-19 Martin Baulig <martin@gnome.org>
24666 * typemanager.cs (MemberCache): When creating the cache for an
24667 interface type, add all inherited members.
24668 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24669 to `out bool used_cache' and documented it.
24670 (TypeManager.MemberLookup): If we already used the cache in the first
24671 iteration, we don't need to do the interfaces check.
24673 2002-08-19 Martin Baulig <martin@gnome.org>
24675 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24676 here from IMemberFinder and don't implement this interface anymore.
24677 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24679 * typemanager.cs (IMemberFinder): This interface is now only used by
24680 classes which actually support the member cache.
24681 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24682 since we only put DeclSpaces into this Hashtable.
24683 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24684 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24686 2002-08-16 Martin Baulig <martin@gnome.org>
24688 * typemanager.cs (ICachingMemberFinder): Removed.
24689 (IMemberFinder.MemberCache): New property.
24690 (TypeManager.FindMembers): Merged this with RealFindMembers().
24691 This function will never be called from TypeManager.MemberLookup()
24692 so we can't use the cache here, just the IMemberFinder.
24693 (TypeManager.MemberLookup_FindMembers): Check whether the
24694 IMemberFinder has a MemberCache and call the cache's FindMembers
24696 (MemberCache): Rewrote larger parts of this yet another time and
24697 cleaned it up a bit.
24699 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24701 * driver.cs (LoadArgs): Support quoting.
24703 (Usage): Show the CSC-like command line arguments.
24705 Improved a few error messages.
24707 2002-08-15 Martin Baulig <martin@gnome.org>
24709 * typemanager.cs (IMemberContainer.Type): New property.
24710 (IMemberContainer.IsInterface): New property.
24712 The following changes are conditional to BROKEN_RUNTIME, which is
24713 defined at the top of the file.
24715 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24716 class'es members, but add all members from TypeHandle.ObjectType
24717 if we're an interface.
24718 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24719 is the current type.
24720 (MemberCache.CacheEntry.Container): Removed this field.
24721 (TypeHandle.GetMembers): Include inherited members.
24723 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24725 * typemanager.cs: fixed compilation and added a comment on a field that
24728 2002-08-15 Martin Baulig <martin@gnome.org>
24730 * class.cs (ConstructorInitializer.Resolve): In the
24731 Expression.MemberLookup call, use the queried_type as
24734 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24735 declared' attribute, it's always true.
24736 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24737 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24738 temporary wrapper for FindMembers which tells MemberLookup whether
24739 members from the base classes are included in the return value.
24740 This will go away soon.
24741 (TypeManager.MemberLookup): Use this temporary hack here; once the
24742 new MemberCache is completed, we don't need to do the DeclaredOnly
24743 looping here anymore since the MemberCache will take care of this.
24744 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24745 (MemberCache): When creating the MemberCache for a class, get
24746 members from the current class and all its base classes.
24747 (MemberCache.CacheEntry.Container): New field. This is a
24748 temporary hack until the Mono runtime is fixed to distinguish
24749 between ReflectedType and DeclaringType. It allows us to use MCS
24750 with both the MS runtime and the unfixed Mono runtime without
24751 problems and without accecting performance.
24752 (MemberCache.SearchMembers): The DeclaredOnly looping from
24753 TypeManager.MemberLookup is now done here.
24755 2002-08-14 Martin Baulig <martin@gnome.org>
24757 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24758 Type.GetFields on dynamic types but get the fields from the
24759 corresponding TypeContainer.
24760 (MyStructInfo.GetStructInfo): Added check for enum types.
24762 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24763 (MemberList.SyncRoot): Implemented.
24764 (TypeManager.FilterWithClosure): No need to check permissions if
24765 closure_start_type == closure_invocation_type, don't crash if
24766 closure_invocation_type is null.
24768 2002-08-13 Martin Baulig <martin@gnome.org>
24770 Rewrote TypeContainer.FindMembers to use a member cache. This
24771 gives us a speed increase of about 35% for the self-hosting MCS
24772 build and of about 15-20% for the class libs (both on GNU/Linux).
24774 * report.cs (Timer): New class to get enhanced profiling. This
24775 whole class is "TIMER" conditional since it remarkably slows down
24778 * class.cs (MemberList): New class. This is an IList wrapper
24779 which we're now using instead of passing MemberInfo[]'s around to
24780 avoid copying this array unnecessarily.
24781 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24782 (ICachingMemberFinder, IMemberContainer): New interface.
24783 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24784 has already been checked, otherwise use it for the name comparision.
24785 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24786 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24787 if possible. Returns a MemberList, not a MemberInfo [].
24788 (TypeHandle): New class, implements IMemberContainer. We create
24789 one instance of this class per type, it contains a MemberCache
24790 which is used to do the member lookups.
24791 (MemberCache): New class. Each instance of this class contains
24792 all members of a type and a name-based hash table.
24793 (MemberCache.FindMembers): This is our new member lookup
24794 function. First, it looks up all members of the requested name in
24795 the hash table. Then, it walks this list and sorts out all
24796 applicable members and returns them.
24798 2002-08-13 Martin Baulig <martin@gnome.org>
24800 In addition to a nice code cleanup, this gives us a performance
24801 increase of about 1.4% on GNU/Linux - not much, but it's already
24802 half a second for the self-hosting MCS compilation.
24804 * typemanager.cs (IMemberFinder): New interface. It is used by
24805 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24806 Enum, Delegate or Interface.
24807 (TypeManager.finder_to_member_finder): New PtrHashtable.
24808 (TypeManager.finder_to_container): Removed.
24809 (TypeManager.finder_to_delegate): Removed.
24810 (TypeManager.finder_to_interface): Removed.
24811 (TypeManager.finder_to_enum): Removed.
24813 * interface.cs (Interface): Implement IMemberFinder.
24815 * delegate.cs (Delegate): Implement IMemberFinder.
24817 * enum.cs (Enum): Implement IMemberFinder.
24819 * class.cs (TypeContainer): Implement IMemberFinder.
24821 2002-08-12 Martin Baulig <martin@gnome.org>
24823 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24825 2002-08-12 Martin Baulig <martin@gnome.org>
24827 * ecore.cs (ITypeExpression): New interface for expressions which
24829 (TypeExpression): Renamed to TypeLookupExpression.
24830 (Expression.DoResolve): If we're doing a types-only lookup, the
24831 expression must implement the ITypeExpression interface and we
24832 call DoResolveType() on it.
24833 (SimpleName): Implement the new ITypeExpression interface.
24834 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24835 hack, the situation that we're only looking up types can't happen
24836 anymore when this method is called. Moved the type lookup code to
24837 DoResolveType() and call it.
24838 (SimpleName.DoResolveType): This ITypeExpression interface method
24839 is now doing the types-only lookup.
24840 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24841 (ResolveFlags): Added MaskExprClass.
24843 * expression.cs (MemberAccess): Implement the ITypeExpression
24845 (MemberAccess.DoResolve): Added support for a types-only lookup
24846 when we're called via ITypeExpression.DoResolveType().
24847 (ComposedCast): Implement the ITypeExpression interface.
24849 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24850 Expression.Resolve() with ResolveFlags.Type instead.
24852 2002-08-12 Martin Baulig <martin@gnome.org>
24854 * interface.cs (Interface.Define): Apply attributes.
24856 * attribute.cs (Attribute.ApplyAttributes): Added support for
24857 interface attributes.
24859 2002-08-11 Martin Baulig <martin@gnome.org>
24861 * statement.cs (Block.Emit): Only check the "this" variable if we
24862 do not always throw an exception.
24864 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24865 whether the property has a set accessor.
24867 2002-08-11 Martin Baulig <martin@gnome.org>
24869 Added control flow analysis support for structs.
24871 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
24872 with control flow analysis turned off.
24873 (IVariable): New interface.
24874 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
24875 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
24876 (FieldExpr.DoResolve): Resolve the instance expression with flow
24877 analysis turned off and do the definite assignment check after the
24878 resolving when we know what the expression will resolve to.
24880 * expression.cs (LocalVariableReference, ParameterReference):
24881 Implement the new IVariable interface, only call the flow analysis
24882 code if ec.DoFlowAnalysis is true.
24883 (This): Added constructor which takes a Block argument. Implement
24884 the new IVariable interface.
24885 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
24886 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
24887 This does the definite assignment checks for struct members.
24889 * class.cs (Constructor.Emit): If this is a non-static `struct'
24890 constructor which doesn't have any initializer, call
24891 Block.AddThisVariable() to tell the flow analysis code that all
24892 struct elements must be initialized before control returns from
24895 * statement.cs (MyStructInfo): New public class.
24896 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
24897 argument to this indexer. If non-zero, check an individual struct
24898 member, not the whole struct.
24899 (FlowBranching.CheckOutParameters): Check struct members.
24900 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
24901 overloaded versions of these methods which take an additional
24902 `int field_idx' argument to check struct members.
24903 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
24904 overloaded versions of these methods which take an additional
24905 `string field_name' argument to check struct member.s
24906 (VariableInfo): Implement the IVariable interface.
24907 (VariableInfo.StructInfo): New public property. Returns the
24908 MyStructInfo instance of the variable if it's a struct or null.
24909 (Block.AddThisVariable): New public method. This is called from
24910 Constructor.Emit() for non-static `struct' constructor which do
24911 not have any initializer. It creates a special variable for the
24912 "this" instance variable which will be checked by the flow
24913 analysis code to ensure that all of the struct's fields are
24914 initialized before control returns from the constructor.
24915 (UsageVector): Added support for struct members. If a
24916 variable/parameter is a struct with N members, we reserve a slot
24917 in the usage vector for each member. A struct is considered fully
24918 initialized if either the struct itself (slot 0) or all its
24919 members are initialized.
24921 2002-08-08 Martin Baulig <martin@gnome.org>
24923 * driver.cs (Driver.MainDriver): Only report an error CS5001
24924 if there were no compilation errors.
24926 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
24927 `UnsafeContext' property to determine whether the parent is in
24928 unsafe context rather than checking the parent's ModFlags:
24929 classes nested in an unsafe class are unsafe as well.
24931 2002-08-08 Martin Baulig <martin@gnome.org>
24933 * statement.cs (UsageVector.MergeChildren): Distinguish between
24934 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
24935 we return. Added test17() and test18() to test-154.cs.
24937 2002-08-08 Martin Baulig <martin@gnome.org>
24939 * typemanager.cs (TypeManager.FilterWithClosure): If we have
24940 Family access, make sure the invoking type isn't a subclass of the
24941 queried type (that'd be a CS1540).
24943 * ecore.cs (Expression.MemberLookup): Added overloaded version of
24944 this method which takes an additional `Type invocation_type'.
24946 * expression.cs (BaseAccess.DoResolve): Use the base type as
24947 invocation and query type.
24948 (MemberAccess.DoResolve): If the lookup failed and we're about to
24949 report a CS0122, try a lookup with the ec.ContainerType - if this
24950 succeeds, we must report a CS1540.
24952 2002-08-08 Martin Baulig <martin@gnome.org>
24954 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
24955 (MethodGroupExpr): Implement the IMemberExpr interface.
24957 * expression (MemberAccess.ResolveMemberAccess): No need to have
24958 any special code for MethodGroupExprs anymore, they're now
24961 2002-08-08 Martin Baulig <martin@gnome.org>
24963 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
24964 Family, FamANDAssem and FamORAssem permissions.
24965 (TypeManager.IsSubclassOrNestedChildOf): New public method.
24967 2002-08-08 Martin Baulig <martin@gnome.org>
24969 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
24970 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
24973 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
24975 * driver.cs: implemented /resource option to embed managed resources.
24977 2002-08-07 Martin Baulig <martin@gnome.org>
24979 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
24980 (FieldBase.HasFieldInitializer): New public property.
24981 (FieldBase.GetInitializerExpression): New public method. Resolves and
24982 returns the field initializer and makes sure it is only resolved once.
24983 (TypeContainer.EmitFieldInitializers): Call
24984 FieldBase.GetInitializerExpression to get the initializer, this ensures
24985 that it isn't resolved multiple times.
24987 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
24988 the resolving process (SimpleName/MemberLookup) that we're currently
24989 emitting a field initializer (which must not access any instance members,
24990 this is an error CS0236).
24992 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
24993 argument, if the `IsFieldInitializer' flag is set, we must report and
24994 error CS0236 and not an error CS0120.
24996 2002-08-07 Martin Baulig <martin@gnome.org>
24998 * ecore.cs (IMemberExpr): New public interface.
24999 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25000 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25001 if the expression is an IMemberExpr.
25003 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25004 to be null, implicitly default to `this' if we're non-static in
25005 this case. Simplified the code a lot by using the new IMemberExpr
25006 interface. Also fixed bug #28176 here.
25008 2002-08-06 Martin Baulig <martin@gnome.org>
25010 * cs-parser.jay (SimpleLookup): Removed. We need to create
25011 ParameterReferences during semantic analysis so that we can do a
25012 type-only search when resolving Cast, TypeOf and SizeOf.
25013 (block): Pass the `current_local_parameters' to the Block's
25016 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25017 argument to the constructor.
25018 (ConstructorInitializer.Resolve): Create a temporary implicit
25019 block with the parameters.
25021 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25022 references here if we aren't doing a type-only search.
25024 * statement.cs (Block): Added constructor which takes a
25025 `Parameters parameters' argument.
25026 (Block.Parameters): New public property.
25028 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25029 to `Parameters' and made it public readonly.
25031 2002-08-06 Martin Baulig <martin@gnome.org>
25033 * ecore.cs (Expression.Warning): Made this public as well.
25035 * report.cs (Report.Debug): Print the contents of collections.
25037 2002-08-06 Martin Baulig <martin@gnome.org>
25039 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25040 used to tell Resolve() which kinds of expressions it may return.
25041 (Expression.Resolve): Added overloaded version of this method which
25042 takes a `ResolveFlags flags' argument. This can be used to tell
25043 Resolve() which kinds of expressions it may return. Reports a
25045 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25046 ResolveFlags.SimpleName.
25047 (Expression.Error118): Added overloaded version of this method which
25048 takes a `ResolveFlags flags' argument. It uses the flags to determine
25049 which kinds of expressions are allowed.
25051 * expression.cs (Argument.ResolveMethodGroup): New public method.
25052 Resolves an argument, but allows a MethodGroup to be returned.
25053 This is used when invoking a delegate.
25055 * TODO: Updated a bit.
25057 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25059 Fixed compilation with csc.
25061 * ecore.cs: Expression.Error made public. Is this correct? Should
25062 Warning be made public too?
25064 * expression.cs: use ea.Location instead of ea.loc.
25065 [FIXME: Filed as bug #28607: MCS must report these errors.]
25067 2002-08-06 Martin Baulig <martin@gnome.org>
25069 * ecore.cs (Expression.loc): Moved the location here instead of
25070 duplicating it in all derived classes.
25071 (Expression.Location): New public property.
25072 (Expression.Error, Expression.Warning): Made them non-static and
25073 removed the location argument.
25074 (Expression.Warning): Added overloaded version which takes an
25075 `int level' argument.
25076 (Expression.Error118): Make this non-static and removed the
25077 expression and location arguments.
25078 (TypeExpr): Added location argument to the constructor.
25080 * expression.cs (StaticCallExpr): Added location argument to
25082 (Indirection, PointerArithmetic): Likewise.
25083 (CheckedExpr, UnCheckedExpr): Likewise.
25084 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25085 (StringPtr): Likewise.
25088 2002-08-05 Martin Baulig <martin@gnome.org>
25090 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25092 * assign.cs (Assign.DoResolve): Check whether the source
25093 expression is a value or variable.
25095 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25096 while resolving the corresponding blocks.
25098 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25099 an error, don't silently return null.
25101 * statement.cs (Block.AddVariable): Do the error reporting here
25102 and distinguish between CS0128 and CS0136.
25103 (Block.DoResolve): Report all unused labels (warning CS0164).
25104 (LabeledStatement): Pass the location to the constructor.
25105 (LabeledStatement.HasBeenReferenced): New property.
25106 (LabeledStatement.Resolve): Set it to true here.
25108 * statement.cs (Return.Emit): Return success even after reporting
25109 a type mismatch error (CS0126 or CS0127), this is what csc does and
25110 it avoids confusing the users with any consecutive errors.
25112 2002-08-05 Martin Baulig <martin@gnome.org>
25114 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25116 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25118 * expression.cs (MemberAccess.DoResolve): Silently return if an
25119 error has already been reported.
25121 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25122 error has already been reported.
25124 2002-08-05 Martin Baulig <martin@gnome.org>
25126 * statement.cs (UsageVector): Only initialize the `parameters'
25127 vector if we actually have any "out" parameters.
25129 2002-08-05 Martin Baulig <martin@gnome.org>
25131 * expression.cs (Binary.ResolveOperator): When combining delegates,
25132 they must have the same type.
25134 2002-08-05 Martin Baulig <martin@gnome.org>
25136 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25137 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25138 work with the ms runtime and we also don't need it: if we're a
25139 PropertyBuilder and not in the `indexer_arguments' hash, then we
25140 are a property and not an indexer.
25142 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25143 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25144 since the latter one doesn't work with the ms runtime.
25146 2002-08-03 Martin Baulig <martin@gnome.org>
25148 Fixed bugs #27998 and #22735.
25150 * class.cs (Method.IsOperator): New public field.
25151 (Method.CheckBase): Report CS0111 if there's already a method
25152 with the same parameters in the current class. Report CS0508 when
25153 attempting to change the return type of an inherited method.
25154 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25155 and it's not marked abstract or extern.
25156 (PropertyBase): New abstract base class for Property and Indexer.
25157 (PropertyBase.CheckBase): Moved here from Property and made it work
25159 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25160 the same so we can reuse it there.
25161 (Property, Indexer): Derive from PropertyBase.
25162 (MethodSignature.inheritable_property_signature_filter): New delegate
25163 to find properties and indexers.
25165 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25166 argument and improved error reporting.
25168 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25169 EmptyReadOnlyParameters and made it a property.
25171 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25172 version of this method which takes a `PropertyInfo indexer'.
25173 (TypeManager.RegisterIndexer): New method.
25175 * class.cs: Added myself as author of this file :-)
25177 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25179 * class.cs: fixed compilation on windoze.
25181 2002-08-03 Martin Baulig <martin@gnome.org>
25183 * interface.cs (Interface.GetInterfaceBases): Check whether all
25184 base interfaces are at least as accessible than the current one.
25186 * class.cs (TypeContainer.GetClassBases): Check whether base types
25187 are at least as accessible than the current type.
25188 (TypeContainer.AsAccessible): Implemented and made non-static.
25189 (MemberBase.CheckParameters): Report errors if the accessibility
25192 * delegate.cs (Delegate.Delegate): The default visibility is
25193 internal for top-level types and private for nested types.
25194 (Delegate.Define): Report errors if the accessibility checks fail.
25196 * enum.cs (Enum.Enum): The default visibility is internal for
25197 top-level types and private for nested types.
25198 (Enum.DefineType): Compute the correct visibility.
25200 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25201 function which takes a `bool is_toplevel' instead of a TypeContainer.
25203 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25206 2002-08-02 Martin Baulig <martin@gnome.org>
25208 * expression.cs (LocalVariableReferenc): Added constructor which
25209 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25210 (LocalVariableReference.IsReadOnly): New property.
25211 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25212 variable is readonly, use our own readonly flag to do this; you can
25213 use the new constructor to get a writable reference to a read-only
25216 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25217 reference to the local variable.
25219 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25221 * rootcontext.cs (ResolveCore): Also include System.Exception
25223 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25224 we reach an EmptyStatement.
25226 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25229 * expression.cs (Binary.ResolveOperator): Check error result in
25232 use brtrue/brfalse directly and avoid compares to null.
25234 2002-08-02 Martin Baulig <martin@gnome.org>
25236 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25237 Fixes bug #28407, added test-155.cs.
25239 2002-08-01 Martin Baulig <martin@gnome.org>
25241 * class.cs (Event.EmitDefaultMethod): Make this work with static
25242 events. Fixes #28311, added verify-3.cs.
25244 2002-08-01 Martin Baulig <martin@gnome.org>
25246 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25247 `is_disposable' fields.
25248 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25249 `hm.is_disposable' if we're using the collection pattern.
25250 (Foreach.EmitCollectionForeach): Use the correct type for the
25251 enumerator's local variable, only emit the try/finally block if
25252 necessary (fixes #27713).
25254 2002-08-01 Martin Baulig <martin@gnome.org>
25256 * ecore.cs (Expression.report118): Renamed to Error118 and made
25259 * statement.cs (Throw.Resolve): Check whether the expression is of
25260 the correct type (CS0118) and whether the type derives from
25261 System.Exception (CS0155).
25262 (Catch.Resolve): New method. Do the type lookup here and check
25263 whether it derives from System.Exception (CS0155).
25264 (Catch.CatchType, Catch.IsGeneral): New public properties.
25266 * typemanager.cs (TypeManager.exception_type): Added.
25268 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25270 * driver.cs: Updated About function.
25272 2002-07-31 Martin Baulig <martin@gnome.org>
25274 Implemented Control Flow Analysis.
25276 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25277 (EmitContext.CurrentBranching): Added.
25278 (EmitContext.StartFlowBranching): Added.
25279 (EmitContext.EndFlowBranching): Added.
25280 (EmitContext.KillFlowBranching): Added.
25281 (EmitContext.IsVariableAssigned): Added.
25282 (EmitContext.SetVariableAssigned): Added.
25283 (EmitContext.IsParameterAssigned): Added.
25284 (EmitContext.SetParameterAssigned): Added.
25285 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25286 Added control flow analysis stuff here.
25288 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25289 resolve the expression as lvalue.
25290 (LocalVariableReference.DoResolve): Check whether the variable has
25291 already been assigned.
25292 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25293 the parameter as assigned here.
25294 (ParameterReference.DoResolve): Check whether the parameter has already
25296 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25297 expression as lvalue.
25299 * statement.cs (FlowBranching): New class for the flow analysis code.
25300 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25301 (LabeledStatement.IsDefined): New public property.
25302 (LabeledStatement.AddUsageVector): New public method to tell flow
25303 analyis that the label may be reached via a forward jump.
25304 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25306 (VariableInfo.Number): New public field. This is used by flow analysis
25307 to number all locals of a block.
25308 (Block.CountVariables): New public property. This is the number of
25309 local variables in this block (including the locals from all parent
25311 (Block.EmitMeta): Number all the variables.
25313 * statement.cs: Added flow analysis support to all classes.
25315 2002-07-31 Martin Baulig <martin@gnome.org>
25317 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25318 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25319 then use this argument.
25321 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25323 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25324 use this to specify /define options.
25326 2002-07-29 Martin Baulig <martin@gnome.org>
25328 * statement.cs (Fixed): Moved all code that does variable lookups
25329 and resolvings from Emit to Resolve.
25331 * statement.cs (For): Moved all code that does variable lookups
25332 and resolvings from Emit to Resolve.
25334 * statement.cs (Using): Moved all code that does variable lookups
25335 and resolvings from Emit to Resolve.
25337 2002-07-29 Martin Baulig <martin@gnome.org>
25339 * attribute.cs (Attribute.Resolve): Explicitly catch a
25340 System.NullReferenceException when creating the
25341 CustromAttributeBuilder and report a different warning message.
25343 2002-07-29 Martin Baulig <martin@gnome.org>
25345 * support.cs (ParameterData.ParameterName): Added method to
25346 get the name of a parameter.
25348 * typemanager.cs (TypeManager.IsValueType): New public method.
25350 2002-07-29 Martin Baulig <martin@gnome.org>
25352 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25353 is a flag which specifies that it's either ref or out.
25354 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25355 the out parameter to `out Parameter.Modifier mod', also set the
25356 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25358 * support.cs (InternalParameters.ParameterModifier): Distinguish
25359 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25360 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25362 * expression.cs (Argument.GetParameterModifier): Distinguish
25363 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25364 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25366 2002-07-29 Martin Baulig <martin@gnome.org>
25368 * expression.cs (ParameterReference.ParameterReference): Added
25369 `Location loc' argument to the constructor.
25371 * cs-parser.jay: Pass location to ParameterReference.
25373 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25375 * statement.cs (Try): Initialize the location.
25377 * cs-parser.jay: pass location to Try.
25379 * expression.cs (Unary.Reduce): Change the prototype to return
25380 whether a constant fold could be performed or not. The result is
25381 returned in an out parameters. In the case of Indirection and
25382 AddressOf, we want to perform the full tests.
25384 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25386 * statement.cs (Statement.Emit): Flag dead code.
25388 2002-07-27 Andrew Birkett <andy@nobugs.org>
25390 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25392 2002-07-27 Martin Baulig <martin@gnome.org>
25394 * class.cs (MethodData.Define): Put back call to
25395 TypeManager.AddMethod(), accidentally commented this out.
25397 * report.cs (Debug): New public method to print debugging information,
25398 this is `[Conditional ("DEBUG")]'.
25400 2002-07-26 Martin Baulig <martin@gnome.org>
25402 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25403 (switch_statement): Push the current_block to the switch_stack and
25404 pop it again when we're done with the switch.
25405 (switch_section): The new block is a child of the current_block.
25406 Fixes bug #24007, added test-152.cs.
25408 2002-07-27 Martin Baulig <martin@gnome.org>
25410 * expression.cs (Invocation.EmitArguments): When calling a varargs
25411 function with only its fixed arguments, we need to pass an empty
25414 2002-07-27 Martin Baulig <martin@gnome.org>
25416 Mono 0.13 has been released.
25418 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25420 * driver.cs: Rename --resource to --linkres, because that is what
25421 we do currently, we dont support --resource yet.
25423 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25425 2002-07-25 Martin Baulig <martin@gnome.org>
25427 * class.cs (MethodData): New public class. This is a `method builder'
25428 class for a method or one accessor of a Property/Indexer/Event.
25429 (MethodData.GetMethodFlags): Moved here from MemberBase.
25430 (MethodData.ApplyAttributes): Likewise.
25431 (MethodData.ApplyObsoleteAttribute): Likewise.
25432 (MethodData.ApplyConditionalAttribute): Likewise.
25433 (MethodData.ApplyDllImportAttribute): Likewise.
25434 (MethodData.CheckAbstractAndExternal): Likewise.
25435 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25436 (MethodData.Emit): Formerly known as Method.Emit().
25437 (MemberBase): Moved everything which was specific to a single
25438 accessor/method to MethodData.
25439 (Method): Create a new MethodData and call Define() and Emit() on it.
25440 (Property, Indexer, Event): Create a new MethodData objects for each
25441 accessor and call Define() and Emit() on them.
25443 2002-07-25 Martin Baulig <martin@gnome.org>
25445 Made MethodCore derive from MemberBase to reuse the code from there.
25446 MemberBase now also checks for attributes.
25448 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25449 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25451 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25452 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25453 (MemberBase.ApplyAttributes): New virtual method; applies the
25454 attributes to a method or accessor.
25455 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25456 (MemberBase.ApplyConditionalAttribute): Likewise.
25457 (MemberBase.ApplyDllImportAttribute): Likewise.
25458 (MemberBase.CheckAbstractAndExternal): Likewise.
25459 (MethodCore.ParameterTypes): This is now a property instead of a
25460 method, it's initialized from DoDefineParameters().
25461 (MethodCore.ParameterInfo): Removed the set accessor.
25462 (MethodCore.DoDefineParameters): New protected virtual method to
25463 initialize ParameterTypes and ParameterInfo.
25464 (Method.GetReturnType): We can now simply return the MemberType.
25465 (Method.GetMethodFlags): Override the MemberBase version and add
25466 the conditional flags.
25467 (Method.CheckBase): Moved some code from Define() here, call
25468 DoDefineParameters() here.
25469 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25470 here to avoid some larger code duplication.
25471 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25472 ensure that abstract and external accessors don't declare a body.
25474 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25475 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25476 lookup in the attribute's parent classes, so we need to abort as soon
25477 as we found the first match.
25478 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25479 the attribute has no arguments.
25481 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25484 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25486 * cs-parser.jay: reverted previous patch.
25488 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25490 * cs-parser.jay: fixed bug #22119.
25492 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25494 * attribute.cs: fixed compilation. The error was:
25495 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25496 be assigned to before control leaves the current method."
25497 [FIXME: Filed as bug #28186: MCS must report this error.]
25499 2002-07-25 Martin Baulig <martin@gnome.org>
25501 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25502 method to pull the condition name ouf of a Conditional attribute.
25503 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25504 the obsolete message and error flag out of an Obsolete attribute.
25506 * class.cs (Method.GetMethodFlags): New public method to get the
25507 TypeManager.MethodFlags for this method.
25508 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25510 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25511 if we're overriding a virtual function, set the new private variable
25512 `parent_method'; call the new TypeManager.AddMethod().
25514 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25515 the MethodBuilder and the Method in a PtrHashtable.
25516 (TypeManager.builder_to_method): Added for this purpose.
25517 (TypeManager.MethodFlags): Added IsObsoleteError.
25518 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25519 Obsolete and Conditional arguments in MethodBuilders. If we discover
25520 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25521 the message from the attribute.
25523 2002-07-24 Martin Baulig <martin@gnome.org>
25525 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25526 preprocessor directives, ensure that the argument to #define/#undef is
25527 exactly one identifier and that it's actually an identifier.
25529 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25532 2002-07-24 Martin Baulig <martin@gnome.org>
25534 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25535 initialize it to TypeManager.object_type in the constructor.
25536 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25537 of the `hm.get_current' method if we're using the collection pattern.
25538 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25539 for the explicit conversion to make it work when we're using the collection
25540 pattern and the `Current' property has a different return type than `object'.
25543 2002-07-24 Martin Baulig <martin@gnome.org>
25545 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25546 does not match, but don't report any errors. This method is called in
25547 order for all methods in a MethodGroupExpr until a matching method is
25548 found, so we don't want to bail out if the first method doesn't match.
25549 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25550 matches, report the 123. Fixes #28070.
25552 2002-07-24 Martin Baulig <martin@gnome.org>
25554 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25555 TypeManager.TypeToCoreType() to the top of the method so the
25556 following equality checks will work. Fixes #28107.
25558 2002-07-24 Martin Baulig <martin@gnome.org>
25560 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25561 operand is of type uint, and the other operand is of type sbyte,
25562 short or int, the operands are converted to type long." -
25563 Actually do what this comment already told us. Fixes bug #28106,
25566 2002-07-24 Martin Baulig <martin@gnome.org>
25568 * class.cs (MethodBase): New abstract class. This is now a base
25569 class for Property, Indexer and Event to avoid some code duplication
25570 in their Define() and DefineMethods() methods.
25571 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25572 generic methods for Define() and DefineMethods().
25573 (FieldBase): Derive from MemberBase, not MemberCore.
25574 (Property): Derive from MemberBase, not MemberCore.
25575 (Property.DefineMethod): Moved all the code from this method to the
25576 new MethodBase.DefineAccessor(), just call it with appropriate
25578 (Property.Define): Call the new Property.DoDefine(), this does some
25579 sanity checks and we don't need to duplicate the code everywhere.
25580 (Event): Derive from MemberBase, not MemberCore.
25581 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25582 accessors, this will also make them work with interface events.
25583 (Indexer): Derive from MemberBase, not MemberCore.
25584 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25585 (Indexer.Define): Use the new MethodBase functions.
25587 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25588 argument to the constructor.
25589 (Interface.FindMembers): Added support for interface events.
25590 (Interface.PopluateEvent): Implemented.
25592 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25594 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25596 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25597 but this is required to check for a method name being the same as
25598 the containing class.
25602 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25604 * interface.cs: initialize variable.
25606 2002-07-23 Martin Baulig <martin@gnome.org>
25608 Implemented the IndexerName attribute in interfaces.
25610 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25611 name if this is an explicit interface implementation.
25612 (Indexer.InterfaceIndexerName): New public variable. If we're
25613 implementing an interface indexer, this is the IndexerName in that
25614 interface. Otherwise, it's the IndexerName.
25615 (Indexer.DefineMethod): If we're implementing interface indexer,
25616 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25617 and Pending.ImplementIndexer methods.
25618 (Indexer.Define): Also define the PropertyBuilder if we're
25619 implementing an interface indexer and this is neither an explicit
25620 interface implementation nor do the IndexerName match the one in
25623 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25624 If a method is defined here, then we always need to create a proxy
25625 for it. This is used when implementing interface indexers.
25626 (Pending.IsInterfaceIndexer): New public method.
25627 (Pending.ImplementIndexer): New public method.
25628 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25629 This is used when implementing interface indexers to define a proxy
25631 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25632 define a proxy if necessary.
25634 * interface.cs (Interface.IndexerName): New public variable.
25635 (Interface.PopulateIndexer): Set the IndexerName.
25636 (Interface.DefineIndexers): New private method. Populate all the
25637 indexers and make sure their IndexerNames match.
25639 * typemanager.cs (IndexerPropertyName): Added support for interface
25642 2002-07-22 Martin Baulig <martin@gnome.org>
25644 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25645 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25646 ret if HasReturnLabel.
25647 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25650 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25651 and set the ec.LoopBeginTryCatchLevel.
25652 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25653 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25654 the current ec.TryCatchLevel, the branch goes out of an exception
25655 block. In this case, we need to use Leave and not Br.
25657 2002-07-22 Martin Baulig <martin@gnome.org>
25659 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25660 block unless the block does not always return or it is contained in
25661 another try { ... } catch { ... } block. Fixes bug #26506.
25662 Added verify-1.cs to the test suite.
25664 2002-07-22 Martin Baulig <martin@gnome.org>
25666 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25667 then we do not always return. Fixes bug #24985.
25669 2002-07-22 Martin Baulig <martin@gnome.org>
25671 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25672 lookup on a per-class level; ie. walk up the class hierarchy until we
25673 found at least one applicable method, then choose the best among them.
25674 Fixes bug #24463 and test-29.cs.
25676 2002-07-22 Martin Baulig <martin@gnome.org>
25678 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25679 return types of the methods. The return type is not part of the
25680 signature and we must not check it to make the `new' modifier work.
25681 Fixes bug #27999, also added test-147.cs.
25682 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25684 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25685 on the method's return type.
25687 2002-07-21 Martin Baulig <martin@gnome.org>
25689 * assign.cs: Make this work if the rightmost source is a constant and
25690 we need to do an implicit type conversion. Also adding a few more tests
25691 to test-38.cs which should have caught this.
25693 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25694 target in the makefile for this. The makefile.gnu is primarily intended
25695 for end-users who don't want to debug the compiler.
25697 2002-07-21 Martin Baulig <martin@gnome.org>
25699 * assign.cs: Improved the Assign class so it can now handle embedded
25700 assignments (X = Y = Z = something). As a side-effect this'll now also
25701 consume less local variables. test-38.cs now passes with MCS, added
25702 a few new test cases to that test.
25704 2002-07-20 Martin Baulig <martin@gnome.org>
25706 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25707 instructions. Fixes bug #27977, also added test-146.cs.
25709 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25711 * cs-tokenizer.cs: fixed getHex ().
25713 2002-07-19 Martin Baulig <martin@gnome.org>
25715 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25716 not Type.GetType() to lookup the array type. This is needed when
25717 we're constructing an array of a user-defined type.
25718 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25719 single-dimensional arrays, but also for single-dimensial arrays of
25722 2002-07-19 Martin Baulig <martin@gnome.org>
25724 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25725 this function is called, it's not allowed to share LocalBuilders
25726 among ILGenerators.
25728 2002-07-19 Martin Baulig <martin@gnome.org>
25730 * expression.cs (Argument.Resolve): Report an error 118 when trying
25731 to pass a type as argument.
25733 2002-07-18 Martin Baulig <martin@gnome.org>
25735 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25736 Conv_R_Un for the signed `long' type.
25738 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25740 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25741 `expr' for the temporary result, as that will fail if we do
25742 multiple resolves on the same expression.
25744 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25746 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25747 ec.TypeContainer for looking up aliases.
25749 * class.cs (TypeContainer): Remove LookupAlias from here.
25751 * decl.cs (DeclSpace); Move here.
25753 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25755 * class.cs (FindMembers): Only call filter if the constructor
25756 bulider is not null.
25758 Also handle delegates in `NestedTypes' now. Now we will perform
25759 type lookups using the standard resolution process. This also
25762 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25763 This uses Expressions (the limited kind that can be parsed by the
25764 tree) instead of strings.
25766 * expression.cs (ComposedCast.ToString): Implement, used to flag
25767 errors since now we have to render expressions.
25769 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25772 * ecore.cs (SimpleName.ToString): ditto.
25774 * cs-parser.jay: Instead of using strings to assemble types, use
25775 Expressions to assemble the type (using SimpleName, ComposedCast,
25776 MemberAccess). This should fix the type lookups in declarations,
25777 because we were using a different code path for this.
25779 * statement.cs (Block.Resolve): Continue processing statements
25780 even when there is an error.
25782 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25784 * class.cs (Event.Define): Also remove the `remove' method from
25785 the list of pending items.
25787 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25788 generate more compact code.
25790 2002-07-17 Martin Baulig <martin@gnome.org>
25792 * const.cs (Const.LookupConstantValue): Add support for constant
25793 `unchecked' and `checked' expressions.
25794 Also adding test case test-140.cs for this.
25796 2002-07-17 Martin Baulig <martin@gnome.org>
25798 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25799 check whether mi.ReturnType implements the IEnumerator interface; the
25800 `==' and the IsAssignableFrom() will fail in this situation.
25802 2002-07-16 Ravi Pratap <ravi@ximian.com>
25804 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25807 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25809 * expression.cs: fixed bug #27811.
25811 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25813 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25814 Molaro: when we are a ref, the value already contains a pointer
25815 value, do not take the address of it.
25817 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25818 * removed mb-parser.jay and mb-tokenizer.cs
25820 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25822 * expression.cs: check against the building corlib void type.
25824 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25826 * ecore.cs: fix for valuetype static readonly fields: when
25827 initializing them, we need their address, not the address of a copy.
25829 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25831 * typemanager.cs: register also enum_type in corlib.
25833 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25835 * class.cs: allow calling this (but not base) initializers in structs.
25837 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25839 * ecore.cs: make sure we compare against the building base types
25842 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25844 * typemanager.cs: fix TypeToCoreType() to handle void and object
25845 (corlib gets no more typerefs after this change).
25847 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25849 * expression.cs (ArrayCreation.EmitArrayArguments): use
25850 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25852 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25853 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25854 array indexes, the runtime actually forbids them.
25856 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25857 for array arguments here.
25859 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25860 instead of the default for ValueTypes.
25862 (New.DoEmit): Use IsValueType instead of
25863 IsSubclassOf (value_type)
25864 (New.DoResolve): ditto.
25865 (Invocation.EmitCall): ditto.
25867 * assign.cs (Assign): ditto.
25869 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25870 Statements *are* currently doing part of their resolution during
25873 Expressions do always resolve during resolve, but statements are
25874 only required to propagate resolution to their children.
25876 2002-07-11 Miguel de Icaza <miguel@ximian.com>
25878 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
25880 (LoadAssembly): Do not add the dll if it is already specified
25882 (MainDriver): Add the System directory to the link path at the end,
25883 after all the other -L arguments.
25885 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
25886 wrong opcode for loading bytes and bools (ldelem.i1 instead of
25887 ldelem.u1) and using the opposite for sbytes.
25889 This fixes Digger, and we can finally run it.
25891 * driver.cs (UnixParseOption): Move the option parsing here.
25892 (CSCParseOption): Implement CSC-like parsing of options.
25894 We now support both modes of operation, the old Unix way, and the
25895 new CSC-like way. This should help those who wanted to make cross
25896 platform makefiles.
25898 The only thing broken is that /r:, /reference: and /lib: are not
25899 implemented, because I want to make those have the same semantics
25900 as the CSC compiler has, and kill once and for all the confussion
25901 around this. Will be doing this tomorrow.
25903 * statement.cs (Unsafe.Resolve): The state is checked during
25904 resolve, not emit, so we have to set the flags for IsUnsfe here.
25906 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25908 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
25909 not catch the Error_ObjectRefRequired in SimpleName (as it is
25910 possible to have a class/instance variable name that later gets
25911 deambiguated), we have to check this here.
25913 2002-07-10 Ravi Pratap <ravi@ximian.com>
25915 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
25916 make static and put into Expression.
25918 (Event.Define): Register the private field of the event with the
25919 TypeManager so that GetFieldFromEvent can get at it.
25921 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
25922 keep track of the private field associated with an event which
25925 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
25928 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
25930 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25932 * expression.cs (Binary.EmitBranchable): this routine emits the
25933 Binary expression in a branchable context. This basically means:
25934 we need to branch somewhere, not just get the value on the stack.
25936 This works together with Statement.EmitBoolExpression.
25938 * statement.cs (Statement.EmitBoolExpression): Use
25941 2002-07-09 Miguel de Icaza <miguel@ximian.com>
25943 * statement.cs (For): Reduce the number of jumps in loops.
25945 (For): Implement loop inversion for the For statement.
25947 (Break): We can be breaking out of a Try/Catch controlled section
25948 (foreach might have an implicit try/catch clause), so we need to
25949 use Leave instead of Br.
25951 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
25952 now). If the instace expression supports IMemoryLocation, we use
25953 the AddressOf method from the IMemoryLocation to extract the
25954 address instead of emitting the instance.
25956 This showed up with `This', as we were emitting the instance
25957 always (Emit) instead of the Address of This. Particularly
25958 interesting when This is a value type, as we dont want the Emit
25959 effect (which was to load the object).
25961 2002-07-08 Miguel de Icaza <miguel@ximian.com>
25963 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
25965 * statement.cs (Checked): Set the CheckedState during the resolve
25966 process too, as the ConvCast operations track the checked state on
25967 the resolve process, and not emit.
25969 * cs-parser.jay (namespace_member_declaration): Flag that we have
25970 found a declaration when we do. This is used to flag error 1529
25972 * driver.cs: Report ok when we display the help only.
25974 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
25976 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
25978 2002-07-04 Miguel de Icaza <miguel@ximian.com>
25980 * cs-tokenizer.cs (define): We also have to track locally the
25981 defines. AllDefines is just used for the Conditional Attribute,
25982 but we also need the local defines for the current source code.
25984 2002-07-03 Miguel de Icaza <miguel@ximian.com>
25986 * statement.cs (While, For, Do): These loops can exit through a
25987 Break statement, use this information to tell whether the
25988 statement is the last piece of code.
25990 (Break): Flag that we break.
25992 * codegen.cs (EmitContexts): New `Breaks' state variable.
25994 2002-07-03 Martin Baulig <martin@gnome.org>
25996 * class.cs (TypeContainer.MethodModifiersValid): Allow override
25997 modifiers in method declarations in structs. Otherwise, you won't
25998 be able to override things like Object.Equals().
26000 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26002 * class.cs (Method, Property, Indexer): Do not allow the public
26003 modifier to be used in explicit interface implementations.
26005 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26006 override modifiers in method declarations in structs
26008 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26010 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26011 integer or real overflow, report an error
26013 2002-07-02 Martin Baulig <martin@gnome.org>
26015 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26016 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26017 to tell the runtime about our newly created System.Object and
26018 System.ValueType types.
26020 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26022 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26023 struct instead of Ldarg/Starg.
26025 2002-07-02 Martin Baulig <martin@gnome.org>
26027 * expression.cs (Indirection.Indirection): Call
26028 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26030 2002-07-02 Martin Baulig <martin@gnome.org>
26032 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26033 ValueType, call TypeManager.TypeToCoreType() on it.
26034 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26035 the OpCodes.Newarr argument.
26037 2002-07-02 Martin Baulig <martin@gnome.org>
26039 * expression.cs (Invocation.EmitCall): When compiling corlib,
26040 replace all calls to the system's System.Array type to calls to
26041 the newly created one.
26043 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26044 System.Array methods.
26045 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26046 from the system's System.Array type which must be replaced.
26048 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26050 * typemanager.cs: load unverifiable_code_ctor so we can build
26051 corlib using the correct type. Avoid using GetTypeCode() with
26053 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26054 TypeManager.object_type to allow building corlib.
26056 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26058 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26060 2002-07-01 Martin Baulig <martin@gnome.org>
26062 * class.cs: Make the last change actually work, we need to check
26063 whether `ifaces != null' to avoid a crash.
26065 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26067 * class.cs: when we build structs without fields that implement
26068 interfaces, we need to add the interfaces separately, since there is
26069 no API to both set the size and add the interfaces at type creation
26072 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26074 * expression.cs: the dimension arguments to the array constructors
26075 need to be converted if they are a long.
26077 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26079 * class.cs: don't emit ldarg.0 if there is no parent constructor
26080 (fixes showstopper for corlib).
26082 2002-06-29 Martin Baulig <martin@gnome.org>
26084 MCS now compiles corlib on GNU/Linux :-)
26086 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26087 ie. check for MethodImplOptions.InternalCall.
26089 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26090 and TypeManager.attribute_type are null, so we must explicitly check
26091 whether parent is not null to find out whether it's an attribute type.
26092 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26093 and SetBuilder, not only if the property is neither abstract nor external.
26094 This is necessary to set the MethodImplOptions on the accessor methods.
26095 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26096 SetBuilder, see Property.Emit().
26098 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26099 populate "System.Object", "System.ValueType" and "System.Attribute" since
26100 they've already been populated from BootCorlib_PopulateCoreTypes().
26102 2002-06-29 Martin Baulig <martin@gnome.org>
26104 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26105 is the NullLiteral, we also need to make sure that target_type is not
26108 2002-06-29 Martin Baulig <martin@gnome.org>
26110 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26111 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26112 before calling BootstrapCorlib_ResolveDelegate ().
26114 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26116 * statement.cs: fixed build-breaker. All tests passed ok.
26118 2002-06-27 Martin Baulig <martin@gnome.org>
26120 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26121 for System.Decimal when compiling corlib.
26123 2002-06-27 Martin Baulig <martin@gnome.org>
26125 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26126 switch blocks which contain nothing but a default clause.
26128 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26130 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26132 2002-06-27 Martin Baulig <martin@gnome.org>
26134 * ecore.cs (PropertyExpr.PropertyExpr): Call
26135 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26137 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26138 is already a TypeBuilder.
26140 2002-06-27 Martin Baulig <martin@gnome.org>
26142 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26143 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26144 the "from an array-type to System.Array" case. This makes it work
26145 when compiling corlib.
26147 2002-06-27 Martin Baulig <martin@gnome.org>
26149 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26150 non-static PropertyExpr, set its InstanceExpression. This makes
26151 the `ICollection.Count' property work in System/Array.cs.
26153 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26155 * driver.cs: Made error handling more consistent. Errors now
26156 tracked by Report class, so many methods which used to return int
26157 now return void. Main() now prints success/failure and
26158 errors/warnings message.
26160 Renamed '--probe' compiler argument to '--expect-error'. Removed
26161 the magic number return values (123 and 124). Now, if the
26162 expected error occurs, the compiler exits with success (exit value
26163 0). If the compilation completes without seeing that particular
26164 error, the compiler exits with failure (exit value 1). The
26165 makefile in mcs/errors has been changed to handle the new behaviour.
26167 * report.cs: Made 'expected error' number a property and renamed
26168 it from 'Probe' to 'ExpectedError'.
26170 * genericparser.cs: Removed error handling support, since it is
26171 now all done by Report class.
26173 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26174 class, so parse() no longer returns an int.
26176 * namespace.cs: Use Report.Error instead of GenericParser.error
26178 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26180 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26181 TypeContainer.AddOperator): At the front of the list put the
26182 explicit implementations, so they get resolved/defined first.
26184 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26186 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26187 interface type is implemented by this TypeContainer. Used during
26188 explicit interface implementation.
26190 (Property.Define, Indexer.Define, Method.Define): Validate that
26191 the given interface in the explicit implementation is one of the
26192 base classes for the containing type.
26194 Also if we are explicitly implementing an interface, but there is
26195 no match in the pending implementation table, report an error.
26197 (Property.Define): Only define the property if we are
26198 not explicitly implementing a property from an interface. Use the
26199 correct name also for those properties (the same CSC uses,
26200 although that is really not needed).
26202 (Property.Emit): Do not emit attributes for explicitly implemented
26203 properties, as there is no TypeBuilder.
26205 (Indexer.Emit): ditto.
26207 Hiding then means that we do not really *implement* a pending
26208 implementation, which makes code fail.
26210 2002-06-22 Martin Baulig <martin@gnome.org>
26212 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26213 the return value of Object.GetType(). [FIXME: we need to do this whenever
26214 we get a type back from the reflection library].
26216 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26218 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26220 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26222 * attribute.cs: Return null if we can not look up the type.
26224 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26225 the interface types found.
26227 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26228 interface types found.
26230 * typemanager.cs (GetInterfaces): Make this routine returns alll
26231 the interfaces and work around the lame differences between
26232 System.Type and System.Reflection.Emit.TypeBuilder in the results
26233 result for GetInterfaces.
26235 (ExpandInterfaces): Given an array of interface types, expand and
26236 eliminate repeated ocurrences of an interface. This expands in
26237 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26240 2002-06-21 Martin Baulig <martin@gnome.org>
26242 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26245 2002-06-21 Martin Baulig <martin@gnome.org>
26247 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26248 and called with one of the core types, return the corresponding typebuilder for
26251 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26254 2002-06-21 Martin Baulig <martin@gnome.org>
26256 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26257 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26258 (Expression.ConvertReferenceExplicit): Likewise.
26260 * expression.cs (ElementAccess.DoResolve): Likewise.
26261 (ElementAccess.DoResolveLValue): Likewise.
26263 2002-06-10 Martin Baulig <martin@gnome.org>
26265 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26266 add the "value" parameter to the parameter list.
26268 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26271 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26273 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26274 the argument to an int, uint, long or ulong, per the spec. Also
26275 catch negative constants in array creation.
26277 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26279 * class.cs: do not allow the same interface to appear twice in
26280 the definition list.
26282 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26284 * ecore.cs: don't use ldlen with System.Array.
26286 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26288 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26290 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26292 * modifiers.cs: produce correct field attributes for protected
26293 internal. Easy fix so miguel can work on ther harder stuff:-)
26295 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26297 * pending.cs: New file. Move the code from class.cs here.
26298 Support clearning the pending flag for all methods (when not doing
26299 explicit interface implementation).
26301 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26303 * rootcontext.cs: added a couple more types needed to bootstrap.
26305 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26307 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26308 constructor in the type, instead of any constructor in the type
26309 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26310 a bug in the Mono runtime when applying the params attribute).
26312 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26313 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26315 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26317 * expression.cs (Unary.ResolveOperator): Use TypeManager
26318 to resolve the type.
26320 2002-06-13 Ravi Pratap <ravi@ximian.com>
26322 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26325 * enum.cs (AddEnumMember): Add support to store the attributes associated
26326 with each member too.
26328 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26329 field builders too - this takes care of the enum member case.
26331 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26333 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26334 address-of operator on both value types and pointers.
26336 2002-06-10 Martin Baulig <martin@gnome.org>
26338 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26339 PropertyBuilder to the `property_builders' list.
26341 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26342 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26343 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26344 find any indexers which are inherited from an interface.
26346 2002-06-09 Martin Baulig <martin@gnome.org>
26348 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26349 the same type as the constant if necessary. There's also a test-130.cs
26352 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26354 * typemanager.cs (TypeManager.ChangeType): Previously known as
26355 Enum.ChangeEnumType().
26357 2002-06-09 Martin Baulig <martin@gnome.org>
26359 * expression.cs (Cast.TryReduce): Added support for consts.
26361 2002-06-08 Ravi Pratap <ravi@ximian.com>
26363 * class.cs (Accessor): Hold attributes information so we can pass
26366 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26367 Modify to pass in attributes attached to the methods.
26369 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26371 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26372 to handle the Accessor kind :-)
26374 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26376 2002-06-08 Martin Baulig <martin@gnome.org>
26378 * expression.cs (Unary.TryReduceNegative): Added support for
26381 2002-06-08 Martin Baulig <martin@gnome.org>
26383 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26384 name can't be found in the `defined_names' - the caller will do a
26385 MemberLookup in this case and thus find methods in System.Enum
26386 such as Enum.IsDefined().
26388 2002-06-08 Martin Baulig <martin@gnome.org>
26390 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26391 Convert.ChangeType() which works with TypeBuilder created types.
26392 (Enum.LookupEnumValue, Enum.Define): Use it here.
26394 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26395 `TypeBuilder.BaseType != null' check.
26396 (TypeContainer.FindMembers): Only lookup parent members if we
26397 actually have a parent.
26398 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26399 (ConstructorInitializer.Resolve): Likewise.
26401 * interface.cs (Interface.FindMembers): Added
26402 `TypeBuilder.BaseType != null' check.
26404 * rootcontext.cs (RootContext.ResolveCore): Added
26405 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26406 classes_second_stage.
26408 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26409 debug_type and trace_type when compiling with --nostdlib.
26411 2002-06-07 Martin Baulig <martin@gnome.org>
26413 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26414 (AddField): Set it to true when adding a non-static field.
26415 (DefineType): Use `have_nonstatic_fields' to find out whether we
26416 have non-static fields, not `Fields != null'.
26418 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26420 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26421 dereferencing a null on the static-field code path)
26423 2002-05-30 Martin Baulig <martin@gnome.org>
26425 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26426 to take command line arguments. Use reflection to call the new
26427 custom `Initialize' function on the symbol writer and pass it the
26428 command line arguments.
26430 * driver.cs (--debug-args): New command line argument to pass command
26431 line arguments to the symbol writer.
26433 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26435 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26436 the target type for indexers and properties. Thanks to Joe for
26439 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26441 * typemanager.cs (MethodFlags): returns the method flags
26442 (Obsolete/ShouldIgnore) that control warning emission and whether
26443 the invocation should be made, or ignored.
26445 * expression.cs (Invocation.Emit): Remove previous hack, we should
26446 not do this on matching a base type, we should do this based on an attribute
26448 Only emit calls to System.Diagnostics.Debug and
26449 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26450 on the command line.
26452 * rootcontext.cs: Global settings for tracing and debugging.
26454 * cs-tokenizer.cs (define): New utility function to track
26455 defines. Set the global settings for TRACE and DEBUG if found.
26457 2002-05-25 Ravi Pratap <ravi@ximian.com>
26459 * interface.cs (Populate*): Pass in the TypeContainer as well as
26460 the DeclSpace as parameters so that we can create EmitContexts and
26461 then use that to apply attributes etc.
26463 (PopulateMethod, PopulateEvent, PopulateProperty)
26464 (PopulateIndexer): Apply attributes everywhere.
26466 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26469 (ApplyAttributes): Update accordingly.
26471 We now apply interface attributes for all members too.
26473 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26475 * class.cs (Indexer.Define); Correctly check if we are explicit
26476 implementation (instead of checking the Name for a ".", we
26477 directly look up if the InterfaceType was specified).
26479 Delay the creation of the PropertyBuilder.
26481 Only create the PropertyBuilder if we are not an explicit
26482 interface implementation. This means that explicit interface
26483 implementation members do not participate in regular function
26484 lookups, and hence fixes another major ambiguity problem in
26485 overload resolution (that was the visible effect).
26487 (DefineMethod): Return whether we are doing an interface
26490 * typemanager.cs: Temporary hack until we get attributes in
26491 interfaces (Ravi is working on that) and we get IndexerName
26492 support in interfaces.
26494 * interface.cs: Register the indexers as properties.
26496 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26497 warning, I have verified that this is a bug in the .NET runtime
26498 (JavaScript suffers of the same problem).
26500 * typemanager.cs (MemberLookup): When looking up members for
26501 interfaces, the parent of an interface is the implicit
26502 System.Object (so we succeed in searches of Object methods in an
26503 interface method invocation. Example: IEnumerable x; x.ToString
26506 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26508 * class.cs (Event): Events should also register if they do
26509 implement the methods that an interface requires.
26511 * typemanager.cs (MemberLookup); use the new GetInterfaces
26514 (GetInterfaces): The code used to lookup interfaces for a type is
26515 used in more than one place, factor it here.
26517 * driver.cs: Track the errors at the bottom of the file, we kept
26520 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26521 instance if the method we are calling is static!
26523 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26525 * attribute.cs (ApplyAttributes): Make this function filter out
26526 the IndexerName attribute (as that attribute in reality is never
26527 applied) and return the string constant for the IndexerName
26530 * class.cs (TypeContainer.Emit): Validate that all the indexers
26531 have the same IndexerName attribute, and if so, set the
26532 DefaultName attribute on the class.
26534 * typemanager.cs: The return value might contain other stuff (not
26535 only methods). For instance, consider a method with an "Item"
26536 property and an Item method.
26538 * class.cs: If there is a problem with the parameter types,
26541 2002-05-24 Ravi Pratap <ravi@ximian.com>
26543 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26544 looks at user defined conversion after making a call to
26545 StandardConversionExists - we need this for overload resolution.
26547 * expression.cs : Update accordingly the various method calls.
26549 This fixes 2 bugs filed against implicit user defined conversions
26551 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26553 * statement.cs: Track the result of the assignment.
26555 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26557 * expression.cs (MemberAccess): Improved error reporting for
26558 inaccessible members.
26560 2002-05-22 Martin Baulig <martin@gnome.org>
26562 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26563 itself with debugging support.
26565 2002-05-22 Martin Baulig <martin@gnome.org>
26567 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26568 Removed, this isn't needed anymore.
26570 2002-05-20 Martin Baulig <martin@gnome.org>
26572 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26573 be underlying type for an enum.
26575 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26577 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26578 that splits out the loading of just the core types.
26580 * rootcontext.cs (ResolveCore): Split the struct resolution in
26581 two, so we can load the enumeration underlying types before any
26584 * expression.cs (Is): Bandaid until we fix properly Switch (see
26585 bug #24985 for details).
26587 * typemanager.cs (ImplementsInterface): The hashtable will contain
26588 a null if there are no interfaces implemented.
26590 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26592 * cs-parser.jay (indexer_declarator): It is fine to have array
26595 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26597 * typemanager.cs: (RegisterBuilder): New function used to register
26598 TypeBuilders that implement interfaces. Since
26599 TypeBuilder.GetInterfaces (as usual) does not work with lame
26601 (AddUserType): register interfaces.
26603 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26604 dealing with TypeBuilder. Also, arrays are showing up as
26605 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26606 methods can not be invoked on them!
26608 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26609 (ImplicitReferenceConversionExists): Split out from
26610 StandardConversionExists.
26612 * expression.cs (As): We were only implementing one of the three
26613 cases for the as operator. We now implement them all.
26614 (Is): Implement the various other cases for Is as well.
26616 * typemanager.cs (CACHE): New define used to control if we want or
26617 not the FindMembers cache. Seems to have a negative impact on
26618 performance currently
26620 (MemberLookup): Nested types have full acess to
26621 enclosing type members
26623 Remove code that coped with instance/static returns for events, we
26624 now catch this in RealFindMembers.
26626 (RealFindMembers): only perform static lookup if the instance
26627 lookup did not return a type or an event.
26629 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26631 * assign.cs (CompoundAssign): We pass more semantic information
26632 now to Compound Assignments than we did before: now we have all
26633 the information at hand, and now we resolve the target *before* we
26634 do the expression expansion, which allows the "CacheValue" method
26635 to have the effect we intended (before, a [x] += 1 would generate
26636 two differen ArrayAccess expressions from the ElementAccess,
26637 during the resolution process).
26639 (CompoundAssign.DoResolve): Resolve target and original_source here.
26641 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26643 * expression.cs (ArrayAccess): dropped debugging information.
26645 * typemanager.cs: Small bug fix: I was always returning i_members,
26646 instead of one of i_members or s_members (depending on which had
26649 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26650 method is invoked before any code generation takes place, and it
26651 is a mechanism to inform that the expression will be invoked more
26652 than once, and that the method should use temporary values to
26653 avoid having side effects
26655 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26657 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26660 * expression.cs (Indirection, ArrayAccess): Add support for
26661 CacheTemporaries in these two bad boys.
26663 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26664 ldobj or ldind_ref.
26665 (StoreFromPtr): Handle stobj as well.
26667 * expression.cs (UnaryMutator): Share more code.
26669 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26670 down: I was not tracking the Filter function as well, which
26671 was affecting the results of the cache.
26673 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26675 * attribute.cs: Remove the hack to handle the CharSet property on
26678 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26680 * attribute.cs (DoResolve): More uglyness, we now only try to
26681 resolve the attribute partially, to extract the CharSet
26682 information (only if we are a StructLayout attribute). Otherwise
26684 (GetExtraTypeInfo): Add some code to conditionally kill in the
26685 future this. I am more and more convinced that the .NET
26686 framework has special code to handle the attribute setting on
26689 * expression.cs (IsParamsMethodApplicable): Revert my previous
26690 foreach change here, it was wrong.
26692 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26694 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26695 (pp_expr): do not abort on unknown input, just return.
26696 (eval): abort if there are pending chars.
26698 * attribute.cs (Attribute.Resolve): Positional parameters are
26699 optional. Deal with that case.
26701 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26702 the Ansi/Unicode/Auto information for the type.
26704 (TypeContainer.DefineType): instantiate the EmitContext here, as
26705 we will be using it during the type definition (to resolve
26706 attributes) and during the emit phase.
26708 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26709 to pull type information out of the attributes
26711 (Attribute.Resolve): track the constructor builder, and allow for
26712 multiple invocations (structs and classes will use this).
26714 * ecore.cs (MemberLookupFinal): new version with all the
26715 parameters customizable.
26717 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26718 constructors. Return if the result value is null (as the error
26719 would have been flagged already by MemberLookupFinal)
26721 Do not allow instances of abstract classes or interfaces to be
26724 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26725 We have to compare the assembly property here when dealing with
26726 FamANDAssem and Assembly access modifiers, because we might be
26727 creating an assembly from *modules* (that means that we are not
26728 getting TypeBuilders for types defined in other modules that are
26729 part of this assembly).
26731 (Method.Emit): If the method is marked abstract and has a body,
26734 (TypeContainer.DefineMembers): If both the defined member and the
26735 parent name match are methods, then do not emit any warnings: let
26736 the Method.Define routine take care of flagging warnings. But if
26737 there is a mismatch (method overrides something else, or method is
26738 overriwritten by something, then emit warning).
26740 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26741 set to null, this means `do not check for the return type on the
26744 (Method.Define): set the return type for the method signature to
26745 null, so that we get methods with the same name and parameters and
26746 different return types. This is used to flag warning 114 (you are
26747 hiding a method, and you probably want to use the new/override
26750 * typemanager.cs (MemberLookup): Implemented proper access
26751 control, closing a long standing set of bug reports. The problem
26752 was that the Framework only has two bits: Public and NonPublic,
26753 and NonPublic includes private and protected methods, but we need
26754 to enforce the FamANDAssem, FamOrAssem and Family.
26756 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26758 * statement.cs (GotoCase): Return true: Ammounts to giving up
26759 knowledge on whether we return or not, and letting the other case
26760 be responsible for it.
26762 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26764 * driver.cs: Do not load directories for each file processed, only
26765 do it if there is a pattern.
26767 * ecore.cs: Report readonly assigns here as well, as we might have
26768 been resolved only by MemberAccess.
26770 (SimpleName.SimpleNameResolve): Also be useful for LValue
26771 resolution. We need this to propagate assign to local readonly variables
26773 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26774 do not want to reuse potential criteria memory.
26776 * class.cs (MyEventBuilder): Set reflected_type;
26778 * ecore.cs (Constantify): Added support for constifying bools.
26780 (RootContext.LookupType): Added a cache for values looked up in
26781 the declaration space.
26783 * typemanager.cs (FindMembers): Now is a front-end to
26784 RealFindMembers, and provides a two-level hashtable-based cache to
26787 15% performance improvement: from 22.5 to 19.2 seconds.
26789 * expression.cs (IsParamsMethodApplicable): use foreach.
26790 (Invocation.DoResolve): ditto.
26791 (New.DoResolve): ditto.
26792 (ArrayCreation.DoResolve): ditto.
26794 * ecore.cs (FindMostEncompassingType): use foreach.
26796 * delegate.cs (NewDelegate.DoResolve): Use foreach
26798 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26799 (RemoveMethods): use foreach.
26801 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26802 nested foreach statements instead of for, and also break out of
26803 the inner loop once a match is found.
26805 (Invocation.OverloadResolve): Use foreach, simplify the code.
26807 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26809 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26810 we actually unwrap the expression to allow for extra information
26813 * expression.cs: Use Shr_Un on unsigned operations.
26815 2002-05-08 Ravi Pratap <ravi@ximian.com>
26817 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26818 applicable operators was not being considered correctly. This closes
26819 the bug Miguel reported.
26821 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26823 * attribute.cs: check that the type derives from System.Attribute
26824 and report the correct error in that case (moved the duplicate code to
26825 its own method, too).
26827 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26829 * attribute.cs: lookup attribute type name as the spec says: first the
26830 bare attribute name and then name + "Attribute" (nant compiles with
26831 mcs after this fix).
26833 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26835 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26836 Because of the way we parse things, we should try to see if a
26837 UIntConstant can fit in an integer.
26839 2002-05-07 Ravi Pratap <ravi@ximian.com>
26841 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26842 when we are in an explicit context.
26844 (ConvertReferenceExplicit): When converting from Iface type S to Class
26845 T make sure the rules are implemented as an OR.
26847 * parameter.cs (ParameterType): Make it a property for now although the
26848 purpose really isn't anything immediate.
26850 * expression.cs (Is*Applicable): Do better checking on the parameter type
26851 of a ref/out parameter. The ones from the system assemblies are already
26852 marked with the correct type so we don't need to do any correction.
26854 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26855 the object type is standard too so include that.
26857 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26859 * ecore.cs (StandardConversionExists): Augment with missing code:
26860 deal with IntConstant, LongConstants and Enumerations.
26862 * assign.cs: Report the error, instead of failing silently
26864 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26865 typecontainer that they are declared, because the
26866 typecontainer/namespace will have the list of using clauses that
26867 need to be applied.
26869 Assembly Attributes were escaping the normal registration
26872 (EmitCode): Apply attributes within an EmitContext that represents
26873 the container they were declared on.
26875 * cs-parser.jay: Track bases for structs. How did I get this wrong?
26877 2002-05-06 Ravi Pratap <ravi@ximian.com>
26879 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
26880 Revamp completely - make much cleaner as we now operate only
26883 (FindMostSpecificSource, FindMostSpecificTarget): New methods
26884 to implement the logic detailed in the spec more correctly.
26886 (UserDefinedConversion): Update accordingly.
26888 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26890 * statement.cs: Return flow analysis information up.
26892 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
26895 (token): Do not consume an extra character before calling
26898 2002-05-06 Piers Haken <piersh@friskit.com>
26900 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
26902 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26904 * class.cs (Constructor.Emit): Set the IsStatic flag in the
26905 EmitContext during the instance constructor initializer
26906 resolution, to stop access to instance variables.
26908 This is mandated by the spec, last paragraph of the `constructor
26909 initializers' section.
26911 2002-05-05 Miguel de Icaza <miguel@ximian.com>
26913 * cs-parser.jay, class.cs (Accessor): new class used to represent
26914 an accessor (get or set). In the past we used `null' to represent
26915 a missing accessor. But this is ambiguous because there was no
26916 way to tell in abstract indexers/properties if one of them was
26919 Now there is a way of addressing that.
26921 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
26922 instead of FindMembers.
26924 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
26925 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
26927 * attribute.cs: Treat indexers and properties as the same in terms
26928 of applying attributes
26930 * ecore.cs (FindMostEncompassedType): Use statically initialized
26931 EmptyExpressions()s like we do elsewhere to avoid creating useless
26932 objects (and we take this out of the tight loop).
26934 (GetConversionOperators): Move the code to extract the actual
26935 operators to a separate routine to clean things up.
26937 2002-05-04 Miguel de Icaza <miguel@ximian.com>
26939 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
26940 events are always registered FieldBuilders.
26942 * class.cs (FieldBase): New class shared by Fields
26944 * delegate.cs: If we are a toplevel delegate, use our full name.
26945 If we are a nested delegate, then only use our tail name.
26947 2002-05-02 Ravi Pratap <ravi@ximian.com>
26949 * expression.cs (IsApplicable): Ensure that we add the "&" to
26950 ref/out types before comparing it with the type of the argument.
26952 (IsParamsMethodApplicable): Ditto.
26954 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
26957 * delegate.cs : Handle the case when we have more than one applicable
26958 method. Flag an error only when we finish checking all.
26960 2002-05-02 Miguel de Icaza <miguel@ximian.com>
26962 * expression.cs: Add support for boolean static initializers.
26964 2002-05-01 Miguel de Icaza <miguel@ximian.com>
26966 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
26968 * parameter.cs (ComputeParameterTypes,
26969 ComputeAndDefineParameterTypes): Better error handling: now we
26970 clear the `types' cache if we fail during any of the type lookups.
26971 We also return the status code correctly to our caller
26973 * delegate.cs: If we fail to define a delegate, abort the extra
26976 * expression.cs (Binary.ResolveOperator): for
26977 operator==(object,object) and operator !=(object, object) we also
26978 have to verify that there is an implicit conversion from one to
26981 (ArrayAccess.DoResolve): Array Access can operate on
26984 2002-04-30 Miguel de Icaza <miguel@ximian.com>
26986 * assign.cs (CompoundAssign): A new class used as a "flag" that
26987 the assignment actually is happening as part of a compound
26988 assignment operator.
26990 During compound assignment, a few new rules exist to enable things
26997 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
26998 to the type of x) if y is implicitly convertible to the type of x,
26999 and the operator is a builtin operator and the return type of the
27000 operator is explicitly convertible to the type of x.
27002 * rootcontext.cs: Reset warning level to 2. 4 catches various
27003 "interesting" features in mcs, we must clean this up at some
27004 point, but currently am trying to kill other bugs ;-)
27006 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27007 in container classes as well.
27009 * expression.cs (Binary.ResolveOperator): Handle string case
27010 before anything else (as operator overloading does emit an error
27011 before doing anything else).
27013 This code could go away when we move to a table driven model, but
27014 i could not come up with a good plan last night.
27016 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27018 * typemanager.cs (CSharpName): reimplementation using regex.
27019 * class.cs: added null check for fields in Emit
27020 * rootcontext.cs: set warninglevel to 4
27022 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27024 * typemanager.cs (CSharpName): reimplemented with Lupus
27027 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27029 * statement.cs (If): correclty implement Resolve, because we were
27030 not catching sem errors in there. The same process is needed
27032 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27035 (Statement.Warning_DeadCodeFound): Factorize code.
27036 (While): Report dead code here too.
27038 (Statement): Added Resolve virtual method to allow
27039 for resolution split from the emit code.
27041 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27043 * statement.cs (EmitBoolExpression): No longer try to resolve the
27045 (MakeBoolean): New utility function that resolve, implicitly
27046 converts to boolean and tags the expression.
27049 (If, Do): Implement dead code elimination.
27050 (While): Implement loop inversion
27052 (Do, While, For, If): Resolve the expression prior to calling our
27055 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27058 - added method Report28 (warning: program has more than one entry point)
27059 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27060 - modified method Method.Define, the part at the end of the method
27062 * rootcontext.cs: added static public Location EntryPointLocation;
27064 * ../errors/cs0028.cs : Add test case for the above warning.
27067 - modified method CSharpName to allow arrays of primitive type to
27068 be printed nicely (e.g. instead of System.Int32[][] it now prints
27070 - added method CSharpSignature: returns the signature of a method
27071 in string format to be used in reporting errors, warnings, etc.
27073 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27076 2002-04-26 Ravi Pratap <ravi@ximian.com>
27078 * delegate.cs (Define): Fix extremely silly bug where I was
27079 setting the type of the 'object' parameter of the BeginInvoke
27080 method to System.IAsyncResult instead of System.Object ;-)
27082 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27084 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27087 (Constructor.Emit): return if we fail to initialize the
27088 constructor. Another door closed!
27090 * expression.cs (New.DoResolve): Improve error message (from -6 to
27091 1501). Use DeclaredOnly lookup to find the exact constructor.
27093 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27094 loop. This is useful.
27096 * cs-parser.jay: Adjust the default parameters so that destructors
27097 have the proper signature.
27099 2002-04-26 Martin Baulig <martin@gnome.org>
27101 * driver.cs (LoadAssembly): If `assembly' contains any characters
27102 which are only valid in path names and not in assembly names
27103 (currently slash, backslash and point), use Assembly.LoadFrom ()
27104 instead of Assembly.Load () on the `assembly' (before iteration
27105 over the link_paths).
27107 2002-04-26 Martin Baulig <martin@gnome.org>
27109 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27111 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27113 * class.cs (Property): use the new typemanager.MemberLookup
27115 (TypeContainer.MemberLookup): Implement using the
27116 TypeManager.MemberLookup now.
27118 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27119 and return MemberInfos, so that these can be used without an
27120 EmitContext (what we had before).
27122 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27124 * expression.cs: Fix the case where the argument to params if the
27125 type of the params. I omitted handling this before. Fixed
27127 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27129 * driver.cs: Call BootCorlib_PopulateCoreType
27131 * class.cs (Property.CheckBase): Check for properties only, not
27134 * interface.cs: Temporary hack: try/catch around the
27135 CustomAttributeBuilder, because I am getting an exception that I
27138 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27139 types whose definitions are required to be there (attributes are
27140 defined before standard types).
27142 Compute definitions as we boot the various types, as they are used
27143 immediately (value_type class will need object_type, but if we do
27144 not initialize object_type, we will pass a null, which will let
27145 the runtime pick the System.Object from the existing corlib, which
27146 is not what we want).
27148 2002-04-22 Patrik Torstensson <totte@labs2.com>
27150 * cs-tokenizer.cs: fixed a number of trim() issues.
27152 2002-04-22 Ravi Pratap <ravi@ximian.com>
27154 * expression.cs (Argument.Type): Ensure that we return the correct
27155 type when we have out or ref parameters [in which case we
27158 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27160 * class.cs (Property, Indexer): Allow extern modifier in there.
27162 * typemanager.cs (InitBaseTypes): Initializes object_type and
27163 value_type, since those will be used early on during the bootstrap
27164 process to compile corlib.
27166 (InitCoreTypes): Move code from here to InitBaseTypes.
27168 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27170 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27171 single-dimension arrays as using the ldlen opcode.
27173 Daniel Lewis discovered this optimization.
27175 * typemanager.cs: Add signature for System.Array::get_Length
27177 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27179 * statement.cs: report the error when the foreach does not apply to an
27180 array nor a collection.
27182 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27184 * expression.cs: Add implicit conversions to the operator ~.
27186 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27188 * typemanager.cs: Locate the decimal constructor.
27190 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27192 * attribute.cs: use the new property of TypeOf.
27193 * expression.cs: added 'get' property around typearg.
27195 These changes fix a build breaker reported by NickD. Is this the
27196 correct way to fix? If not, please, revert my changes and make it
27199 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27201 * attribute.cs: Add support for typeof in attribute invocations.
27202 I am not sure that this is right though.
27204 2002-04-14 Duncan Mak <duncan@ximian.com>
27206 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27207 Binary.Operator.Division case.
27209 2002-04-13 Ravi Pratap <ravi@ximian.com>
27211 * class.cs (DefineType): Ensure that we do a proper check on
27212 attribute types and also register it with the TypeManager.
27214 (TypeContainer.Targets): The default for attribute types is
27215 AttributeTargets.All.
27217 * attribute.cs (ApplyAttributes): Registering the attribute type
27218 is done elsewhere, not when we discover we have a Usage attribute.
27220 2002-04-12 Ravi Pratap <ravi@ximian.com>
27222 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27223 and get rid of is_delegate parameter.
27225 * everywhere : update.
27227 2002-04-12 Ravi Pratap <ravi@ximian.com>
27229 * cs-parser.jay (compilation_unit): Revamp completely to use
27230 some new ideas that I got from Rhys' grammar to solve the problems
27231 with assembly level attributes.
27233 (outer_declaration): New grammar production.
27235 (attribute_sections): Add.
27237 (opt_attributes): Base on attribute_sections
27239 (namespace_declaration): Allow opt_attributes to tackle the case
27240 when we have assembly level attributes - we are clever in this
27243 * attribute.cs (ApplyAttributes): Do not worry about assembly
27244 attributes in the non-global context.
27246 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27247 instead of SetGlobalAttributes.
27249 * class.cs, rootcontext.cs : Ensure we define and generate
27250 attribute types before anything else.
27252 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27253 and flag the new error -20 for the case when the attribute type
27254 does not have valid targets specified. csc does not catch this.
27256 * ../errors/errors.txt : update for error # -20
27258 2002-04-11 Ravi Pratap <ravi@ximian.com>
27260 * support.cs (InternalParameters.ParameterModifier): Do some null
27261 checking and return sane values.
27263 * class.cs (Method.Define): If we are a PInvoke method, ensure
27264 that we are static and extern. Report error # 601
27266 * ../errors/cs0601.cs : Add test case for the above error.
27268 2002-04-07 Ravi Pratap <ravi@ximian.com>
27270 * rootcontext.cs (attribute_types): We need to keep type of
27271 all attribute types separately and emit code for them first.
27273 (RegisterAttribute) : Implement.
27275 * class.cs (DefineType): Check if the current Type is a custom
27276 attribute type and register it accordingly.
27278 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27279 adding the first attribute twice and rename to
27281 (SetGlobalAttributes): this.
27283 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27286 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27287 if we are processing global arguments. Hmm, I am unsure of this.
27289 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27291 * expression.cs: added static array of strings to avoid calling
27292 Enum.ToString () for Operator in Binary. Significant recover of
27295 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27297 * class.cs (FindMembers): Allow the Builders of the various
27298 members to be null. If they are skip them. This only happens
27299 during the PInvoke declaration.
27301 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27303 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27304 failure, so we do not keep going afterwards.
27306 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27307 wanted to pass `false' as the `is_delegate' argument. If this is
27308 the case, why not use delegate_type == null to mean `is_delegate =
27309 false' and anything else as is_delegate = true.
27311 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27313 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27314 code for the section, not the beginning of the tests.
27316 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27318 * cfold.cs: Handle operator + (Enum x, Underlying x)
27320 * expression.cs (Binary): same. Warn about errors where we have
27321 Enum/Enum in operator + as well.
27323 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27326 - added support for switch(bool)
27327 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27328 - add TableSwitchEmit() to handle table-based switch statements
27330 2002-04-05 Ravi Pratap <ravi@ximian.com>
27332 * expression.cs (Invocation.OverloadResolve): Factor out code which
27333 does parameter compatibility checking with arguments so that we can
27334 re-use the code even from Delegate.VerifyApplicability
27336 (VerifyArgumentsCompat): Move above code here.
27338 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27339 and instead make a call to the above method.
27341 2002-03-31 Ravi Pratap <ravi@ximian.com>
27343 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27344 We use it to keep track of classes which are attribute types.
27346 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27348 * delegate.cs (Delegate.Define): Correctly define the types in the
27349 presence of fixed and array parameters.
27351 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27354 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27355 include NonPublic after the first iteration.
27357 * class.cs (Indexer.CheckBase): Only check if both parents are
27360 * cs-parser.jay (accessor_body): If empty, set to null.
27362 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27363 same code path here to resolve constants names that we did have in
27364 MemberAccess.DoResolve. There is too much code duplicated here.
27366 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27368 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27370 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27373 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27374 tokens, numbers and strings.
27376 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27379 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27380 asyncronous parameters and the regular parameters.
27382 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27383 specify the target directory.
27385 * expression.cs: (This.DoResolve): Simplify
27386 (As.Emit): Optimize, do not generate IsInst if the expression is
27387 always of the given type.
27389 (Is.DoResolve): Bug fix, we were reporting both always/never for
27392 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27393 creating too many unnecessary arrays.
27395 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27397 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27398 fields instead of rolling our own initializer. Takes care of all
27399 implicit conversions, and drops unnecessary static checks/argument.
27401 2002-03-31 Dick Porter <dick@ximian.com>
27403 * driver.cs: use the GetDirectories() return values properly, and
27404 use "/" as path separator.
27406 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27408 * expression.cs (Unary): Optimize - - expr into expr.
27409 (Binary): Optimize a + (-b) into a -b.
27411 * codegen.cs (CodeGen): Made all methods static.
27413 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27417 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27418 TypeBuilder property.
27420 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27423 * tree.cs: Removed the various RecordXXXX, and replaced with a
27424 single RecordDecl. Removed all the accessor methods, and just
27425 left a single access point Type
27427 * enum.cs: Rename DefineEnum to DefineType.
27429 * decl.cs: New abstract method `DefineType' used to unify the
27430 Defines for Enumerations, Interfaces, TypeContainers and
27433 (FindType): Moved LookupInterfaceOrClass here. Moved the
27434 LookupBaseClasses method that used to live in class.cs and
27435 interface.cs here, and renamed to FindType.
27437 * delegate.cs: Implement DefineType. Take advantage of the
27438 refactored pattern for locating the parent builder without taking
27439 the parent_builder argument (which we know does not work if we are
27440 nested, and triggering a toplevel definition).
27442 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27444 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27445 accessibility of a member has changed during override and report
27448 * class.cs (Method.Define, Property.Define): Only complain on
27449 overrides if the method is private, any other accessibility is
27450 fine (and since we just checked the permission is the same, we are
27453 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27454 and elif are processed always. The other pre-processing
27455 directives are only processed if we are "taking" the path
27457 2002-03-29 Martin Baulig <martin@gnome.org>
27459 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27460 current location is not Null.
27462 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27463 a separate method so we can profile it.
27465 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27466 `span.Seconds' are just seconds, but no minutes or hours.
27467 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27469 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27471 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27472 Remove the gratuitous set of Final:
27474 // If an interface implementation, then we can set Final.
27475 if (((flags & MethodAttributes.Abstract) == 0) &&
27476 implementing.DeclaringType.IsInterface)
27477 flags |= MethodAttributes.Final;
27479 I do not know what I was smoking when I used that.
27482 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27483 step into fixing the name resolution issues for delegates and
27484 unifying the toplevel name resolution.
27486 2002-03-28 Martin Baulig <martin@gnome.org>
27488 * class.cs (Method.Emit): If we have a symbol writer, call its
27489 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27490 tell it about the current method.
27492 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27493 writer that we're going to emit the first byte of IL code for a new
27494 statement (a new source line).
27495 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27496 EmitContext.Mark() before emitting any code.
27498 * location.cs (SymbolDocument): Return null when we're Null.
27500 * statement.cs (Statement): Moved the `Location loc' variable here.
27501 (Statement.EmitBoolExpression): If we have a symbol writer, call
27502 ec.Mark() before emitting any code to tell it that we're at the
27503 beginning of a new statement.
27504 (StatementExpression): Added `Location' argument to the constructor.
27505 (Block): Added public readonly variable `StartLocation' and public
27506 variable `EndLocation'. The latter is to be set using SetEndLocation().
27507 (Block): Added constructor which takes a start and end location.
27508 (Block.SetEndLocation): New method. This sets the end location.
27509 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27510 local variables we create.
27511 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27512 each statement and do also mark the begin and end of the block.
27514 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27515 tell it the current lexer.Location, use Location.Null for the end of the
27517 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27518 current block, set its end location using SetEndLocation().
27519 (statement_expression): StatementExpression constructor now takes the
27520 lexer.Location as additional argument.
27521 (for_statement, declare_local_variables): Likewise.
27522 (declare_local_variables): When creating a new implicit block, use the
27523 new Block constructor and pass it the lexer.Location.
27525 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27527 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27528 members also on the parent interfaces recursively.
27530 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27532 * report.cs: Use new formats, since Gonzalo finished the missing
27535 * expression.cs (Binary.ResolveOperator): added missing operator|
27536 operator& and operator^ for bool/bool.
27538 * cs-parser.jay: CheckDef now takes a Location argument that is
27539 used to report errors more precisly (instead of reporting the end
27540 of a definition, we try to track something which is a lot closer
27541 to the source of the problem).
27543 * cs-tokenizer.cs: Track global token use, so we can properly flag
27544 the use of #define/#undef after the first token has been seen.
27546 Also, rename the reportXXXX to Error_DescriptiveName
27548 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27549 TypeContainer, so that Enum and Interface can use this too.
27551 * class.cs (TypeContainer.LookupInterfaceOrClass,
27552 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27553 `builder' argument. Typically this was used to pass the parent
27554 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27557 The problem is that a nested class could trigger the definition of
27558 a toplevel class, and the builder would be obviously wrong in that
27561 So we drop this argument, and we compute dynamically the
27562 TypeBuilder/ModuleBuilder (the correct information was available
27563 to us anyways from DeclSpace.Parent)
27565 * interface.cs (Interface.DefineInterface): Drop builder
27566 parameter cleanup like class.cs
27568 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27571 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27574 (Try.Emit): Propagate the returns value from the statement.
27576 (Return.Emit): Even if we are leavning
27578 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27580 * modifiers.cs: Fix the computation of MethodAttributes flags.
27582 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27584 * driver.cs: allow compilation of files that start with '/'.
27585 Add a default case when checking the argument of --target.
27587 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27589 * interface.cs: Implement the same search algorithm for types in
27590 the interface code.
27592 * delegate.cs: Do not allow multiple definition.
27594 * Recovered ChangeLog that got accidentally amputated
27596 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27598 * rootcontext.cs: Load manually enum to allow core classes to
27599 contain enumerations.
27601 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27602 Update to new static methods in TypeManager.
27604 * typemanager.cs (GetMethod, GetConstructor): Use our
27605 implementation of FindMembers to find the members, since during
27606 corlib compilation, the types are TypeBuilders and GetMethod and
27607 GetConstructor do not work.
27609 Make all methods in TypeManager static.
27611 (InitCodeHelpers): Split the functionality from
27612 the InitCodeTypes function.
27614 * driver.cs: Call InitCodeHelpers after we have populated the
27617 * cs-parser.jay (delegate_declaration): we did not used to compute
27618 the delegate name correctly for void delegates.
27620 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27622 * rootcontext.cs (RootContext): Init the interface_resolve_order
27623 and type_container_resolve_order always.
27625 (ResolveCore, BootstrapCorlib_ResolveClass,
27626 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27627 compiler when compiling with --nostdlib
27629 * class.cs (TypeContainer.DefineType): Check that our parent is
27630 not null. This test is most important when we are bootstraping
27633 * codegen.cs: Split out the symbol writing code.
27635 2002-03-25 Martin Baulig <martin@gnome.org>
27637 * driver.cs (-g): Made -g an alias for --debug.
27639 2002-03-24 Martin Baulig <martin@gnome.org>
27641 * codegen.cs (SymbolWriter): New public variable. Returns the
27642 current symbol writer.
27643 (CodeGen): Added `bool want_debugging_support' argument to the
27644 constructor. If true, tell the ModuleBuild that we want debugging
27645 support and ask it for the ISymbolWriter.
27646 (Save): If we have a symbol writer, call it's Close() method after
27647 saving the assembly.
27649 * driver.c (--debug): New command line argument to create a
27650 debugger information file.
27652 * location.cs (SymbolDocument): New public property. Returns an
27653 ISymbolDocumentWriter object for the current source file or null
27654 if we don't have a symbol writer.
27656 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27658 * driver.cs (LoadAssembly): Correctly return when all the paths
27659 have been tried and not before.
27661 * statement.cs (Switch.Emit): return the actual coverage for this
27662 statement (returns/not-returns)
27664 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27665 switch of the statement if we are the last switch section. That
27666 kills two problems: try/catch problems (we used to emit an empty
27667 nop at the end) and switch statements where all branches would
27670 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27672 * driver.cs: Add default assemblies (the equivalent to the
27673 Microsoft CSC.RSP file)
27675 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27676 also update tokens_seen and set it to false.
27678 * driver.cs: Implement --recurse for Mike.
27680 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27681 correctly splitting out the paths.
27683 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27685 * interface.cs (Interface.PopulateProperty): Instead of using
27686 `parent' as the declaration space for the set parameters, use
27689 * support.cs (InternalParameters): InternalParameters constructor
27690 takes a DeclSpace instead of a TypeContainer.
27692 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27693 types are being initialized, load the address of it before calling
27696 (New): Provide a mechanism to disable the generation of local
27697 value type temporaries when the caller will be providing us with
27698 an address to store it.
27700 (ArrayCreation.EmitDynamicInitializers): Use it.
27702 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27704 * expression.cs (Invocation.EmitArguments): Only probe for array
27705 property if there is more than one argument. Sorry about that.
27707 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27708 empty param arrays.
27710 * class.cs (Method.LabelParameters): Fix incorrect code path that
27711 prevented the `ParamArrayAttribute' from being applied to the
27714 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27716 * support.cs (ReflectionParameters): Correctly compute whether the
27717 last argument is a params array. Fixes the problem with
27720 * typemanager.cs: Make the assemblies array always be non-null
27721 (empty, but non-null)
27723 * tree.cs (RecordDecl): New function that abstracts the recording
27724 of names. This reports error 101, and provides a pointer to the
27725 previous declaration. Fixes a crash in the compiler.
27727 * cs-parser.jay (constructor_declaration): Update to new grammar,
27728 and provide a constructor_body that can be empty.
27730 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27732 * driver.cs: Add support for --resources.
27734 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27735 Make all types for the various array helper methods be integer.
27737 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27738 CheckState to ConvCast.
27740 (ConvCast): Now it takes a `checked' state argument, to avoid
27741 depending on the emit context for the conversion, and just using
27742 the resolve time setting.
27744 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27745 instead of Invocation.EmitArguments. We do not emit the original
27746 arguments, instead we emit those which have been converted to
27747 unsigned int expressions.
27749 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27751 * codegen.cs: ditto.
27753 * expression.cs (LocalVariableReference): Drop the use of the
27754 Store function that depended on the variable index.
27756 * statement.cs (VariableInfo): Drop the `Idx' property from this
27757 class, as this is not taking into account the indexes for
27758 temporaries tat we generate during the execution, getting the
27761 * class.cs: First emit class initializers, then call the parent
27764 * expression.cs (Binary): Fix opcode emision.
27765 (UnaryMutator.EmitCode): Support checked code generation
27767 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27768 matches for events for both the Static and Instance scans,
27769 pointing to the same element. Fix that.
27771 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27773 * rootcontext.cs (ResolveTree): Always set the
27774 interface_resolve_order, because nested interfaces will be calling
27777 * class.cs (GetInterfaceOrClass): Track the same resolution
27778 process used by TypeManager.LookupType. This fixes the nested
27779 type lookups in class declarations (separate path from
27782 (TypeContainer.DefineType): Also define nested interfaces.
27783 (TypeContainer.RegisterOrder): New public function used to
27784 register the order in which child interfaces need to be closed.
27786 Nested interfaces need to be closed after their parents have been
27789 * interface.cs (InterfaceAttr): Put all the logic for computing
27790 the interface attribute here.
27792 (DefineInterface): Register our interface order with the
27793 RootContext or with the TypeContainer depending on the case.
27795 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27797 * cs-parser.jay: rework foreach statement to work with the new
27798 changes to the policy on SimpleNames.
27800 * report.cs: support Stacktrace on warnings as well.
27802 * makefile: drop --unsafe and /unsafe from the compile.
27804 2002-03-13 Ravi Pratap <ravi@ximian.com>
27806 * ecore.cs (StandardConversionExists): Modify to take an Expression
27807 as the first parameter. Ensure we do null -> reference type conversion
27810 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27811 temporary Expression objects.
27813 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27815 * interface.cs: workaround bug in method overloading resolution
27816 (there is already a bugzilla bug for it).
27818 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27820 We could also solve this problem by having a separate path for
27821 performing type lookups, instead of DoResolve, we could have a
27822 ResolveType entry point, and only participating pieces of the
27823 production (simplename, deref, array) would implement this.
27825 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27826 signal SimpleName to only resolve type names and not attempt to
27827 resolve anything else.
27829 * expression.cs (Cast): Set the flag.
27831 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27833 * class.cs: Only report 108 if there is no `new' modifier.
27835 * cs-parser.jay: rework foreach statement to work with the new
27836 changes to the policy on SimpleNames.
27838 * report.cs: support Stacktrace on warnings as well.
27840 * makefile: drop --unsafe and /unsafe from the compile.
27842 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27844 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27845 lookups here, instead of doing that at parse time. This means
27846 that our grammar will not introduce `LocalVariableReferences' as
27847 expressions at this point. That solves the problem of code like
27851 static void Main ()
27855 This is only half the fix. The full fix requires parameters to
27856 also be handled in this way.
27858 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27859 makes the use more obvious of the DeclSpace. The
27860 ec.TypeContainer.TypeBuilder is now only used to pull the
27861 TypeBuilder for it.
27863 My theory is that I can get rid of the TypeBuilder completely from
27864 the EmitContext, and have typecasts where it is used (from
27865 DeclSpace to where it matters).
27867 The only pending problem is that the code that implements Aliases
27868 is on TypeContainer, and probably should go in DeclSpace.
27870 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27871 lookups here, instead of doing that at parse time. This means
27872 that our grammar will not introduce `LocalVariableReferences' as
27873 expressions at this point. That solves the problem of code like
27877 static void Main ()
27881 This is only half the fix. The full fix requires parameters to
27882 also be handled in this way.
27884 * class.cs (Property.DefineMethod): When implementing an interface
27885 method, set newslot, when implementing an abstract method, do not
27886 set the flag (before we tried never setting it, or always setting
27887 it, which is the difference).
27888 (Indexer.DefineMethod): same.
27889 (Method.DefineMethod): same.
27891 * ecore.cs: Only set the status used flag if we get back a Field.
27893 * attribute.cs: Temporary hack, so Paolo can keep working.
27895 2002-03-08 Ravi Pratap <ravi@ximian.com>
27897 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
27898 the unmanaged type in the case we have a MarshalAs attribute.
27900 (Resolve): Handle the case when we are parsing the special MarshalAs
27901 attribute [we need to store the unmanaged type to use later]
27903 * typemanager.cs (marshal_as_attr_type): Built in type for the
27904 MarshalAs Attribute.
27906 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
27907 on parameters and accordingly set the marshalling info.
27909 2002-03-09 Miguel de Icaza <miguel@ximian.com>
27911 * class.cs: Optimizing slightly by removing redundant code after
27912 we switched to the `NoTypes' return value.
27913 (Property.DefineMethod): use NoTypes here too.
27915 This fixes the bug I introduced in my last batch of changes.
27917 2002-03-05 Ravi Pratap <ravi@ximian.com>
27919 * tree.cs (RecordEnum): Add. We now keep track of enums too.
27921 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
27922 Enums since those are types too.
27924 * cs-parser.jay (enum_declaration): Record enums as we parse them.
27926 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
27927 thanks to a call during the lookup process.
27929 2002-03-07 Miguel de Icaza <miguel@ximian.com>
27931 * statement.cs (Foreach): Lots of work to accomodate a particular
27932 kind of foreach statement that I had not kept in mind. It is
27933 possible to have foreachs on classes that provide a GetEnumerator
27934 method that return objects that implement the "pattern" for using
27935 a foreach, there is no need to support GetEnumerator
27938 This is needed to compile nant.
27940 * decl.cs: Only report 114 if the member is not `Finalize' and if
27941 the warning level is at least 2.
27943 * class.cs: Moved the compare function from Method to
27946 (MethodSignature.InheritableMemberSignatureCompare): Add new
27947 filter function that is used to extract inheritable methods from a
27950 (Method.Define): Use the new `inheritable_method_signature_filter'
27953 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
27956 2002-03-06 Miguel de Icaza <miguel@ximian.com>
27958 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
27960 * cs-parser.jay: Add opt_semicolon to the interface declaration.
27962 * expression.cs: Pass location information to
27963 ConvertImplicitStandard.
27965 * class.cs: Added debugging code to track return values from
27968 2002-03-05 Miguel de Icaza <miguel@ximian.com>
27970 * expression.cs (Is.DoResolve): If either side of the `is' is an
27971 interface, do not flag the warning.
27973 * ecore.cs (ImplicitReferenceConversion): We need a separate test
27976 * report.cs: Allow for --fatal to be used with --probe.
27978 * typemanager.cs (NoTypes): Move the definition for the empty Type
27981 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
27983 (TypeContainer.DefineProxy): New function used to proxy to parent
27984 implementations when implementing interfaces.
27985 (TypeContainer.ParentImplements): used to lookup if our parent
27986 implements a public function that is required by an interface.
27987 (TypeContainer.VerifyPendingMethods): Hook this up.
27989 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
27990 `modules' and `assemblies' arraylists into arrays. We only grow
27991 these are the very early start up of the program, so this improves
27992 the speedof LookupType (nicely measured).
27994 * expression.cs (MakeByteBlob): Replaced unsafe code with
27995 BitConverter, as suggested by Paolo.
27997 * cfold.cs (ConstantFold.Binary): Special case: perform constant
27998 folding of string concatenation, but if either side is a string,
27999 and the other is not, then return null, and let the runtime use
28000 the concatenation on the string plus the object (using
28001 `Object.ToString').
28003 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28005 Constant Folding has been implemented now.
28007 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28008 the error instead on types that are not supported in one's
28011 * constant.cs (Constant and all children): New set of functions to
28012 perform implict and explicit conversions.
28014 * ecore.cs (EnumConstant): Implement the new functions to perform
28015 conversion by proxying to the child expression.
28017 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28018 own separate setting that can not be turned off from the command
28019 line using --unchecked or --checked and is only controlled using
28020 the checked/unchecked statements and expressions. This setting is
28021 used by the constant folder to flag errors.
28023 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28024 ConstantCheckState as well.
28026 During Resolve, they also have to flag the state, because the
28027 constant folder runs completely in the Resolve phase.
28029 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28032 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28034 * cfold.cs: New file, this file contains the constant folder.
28036 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28037 argument to track whether we are using the resulting address to
28038 load or store a value and provide better error messages.
28040 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28041 new AddressOf arguments.
28043 * statement.cs (Foreach.EmitCollectionForeach): Update
28045 * expression.cs (Argument.Emit): Call AddressOf with proper
28046 arguments to track usage.
28048 (New.DoEmit): Call AddressOf with new arguments.
28050 (Unary.Emit): Adjust AddressOf call.
28052 2002-03-01 Ravi Pratap <ravi@ximian.com>
28054 * cs-parser.jay (member_access): Change the case for pre-defined types
28055 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28058 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28061 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28062 essentially like methods and apply attributes like MethodImplOptions to them too.
28064 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28067 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28068 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28071 * Update code everywhere accordingly.
28073 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28075 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28077 2002-02-28 Ravi Pratap <ravi@ximian.com>
28079 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28080 try performing lookups against those instead of jumping straight into using
28081 the 'using' clauses.
28083 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28085 (LookupType): Perform lookups in implicit parents too.
28087 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28088 sequence as RootContext.LookupType.
28090 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28091 the various cases of namespace lookups into this method.
28093 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28095 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28096 in positional arguments)
28098 * class.cs (Operator): Update the AllowedModifiers to contain
28101 * cs-parser.jay: Update operator declaration to allow for the
28102 operator body to be empty.
28104 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28107 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28109 * class.cs (Method.Emit): Label parameters.
28111 * driver.cs: Return 1 or 0 as the program exit code.
28113 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28115 * expression.cs: Special case the `null' object when trying to
28116 auto-compute the type, as anything can be explicitly converted to
28119 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28120 spotting this Paolo.
28122 (Expression.ImplicitNumericConversion): Perform comparissions of
28123 the type using the underlying type in the case of an enumeration
28124 rather than using the enumeration type for the compare.
28126 Cope with the underlying == type case, which is not possible to
28129 (Expression.ConvertNumericExplicit): Perform comparissions of
28130 the type using the underlying type in the case of an enumeration
28131 rather than using the enumeration type for the compare.
28133 * driver.cs: If the user does not supply an extension, assume .exe
28135 * cs-parser.jay (if_statement): Rewrote so that we can track the
28136 location for the if statement.
28138 * expression.cs (Binary.ConstantFold): Only concat strings when
28139 the operation is "+", not everything ;-)
28141 * statement.cs (Statement.EmitBoolExpression): Take a location
28143 (If, While, Do): Track location.
28145 * expression.cs (Binary.ResolveOperator): In the object + string
28146 case, I was missing a call to ConvertImplicit
28148 2002-02-25 Ravi Pratap <ravi@ximian.com>
28150 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28151 Location arguments. Ensure we use RootContext.LookupType to do our work
28152 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28154 * interface.cs (PopulateMethod): Handle the type of the parameter being
28157 * expression.cs (Invocation.BetterFunction): Handle the case when we
28158 have a params method with no fixed arguments and a call is made with no
28161 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28163 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28164 the verbatim-string-literal
28166 * support.cs (InternalParameters.ParameterModifier): handle null
28168 (InternalParameters.ParameterType): ditto.
28170 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28171 duplicating the name of the variable parameter.
28172 (GetParameterByName): Fix bug where we were not looking up array
28173 paramters if they were the only present (thanks Paolo!).
28174 (GetParameterInfo): We only have an empty set of types if both
28175 fixed and array are set to null.
28176 (GetParameterInfo-idx): Handle FixedParameter == null
28178 * cs-parser.jay: Handle the case where there is no catch
28179 statements (missing null test).
28181 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28183 * driver.cs (MainDriver): Be conservative on our command line
28186 Catch DirectoryNotFoundException when calling GetFiles.
28188 (SplitPathAndPattern): Used to split the input specification into
28189 a path and a pattern that we can feed to Directory.GetFiles.
28191 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28193 * statement.cs (Fixed): Implement the last case of the Fixed
28194 statement (string handling).
28196 * expression.cs (StringPtr): New class used to return a char * to
28197 a string; Used by the Fixed statement.
28199 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28201 * expression.cs (Binary.ResolveOperator): Remove redundant
28202 MemberLookup pn parent type.
28203 Optimize union call, we do not need a union if the types are the same.
28204 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28207 Specialize the use of MemberLookup everywhere, instead of using
28208 the default settings.
28210 (StackAlloc): Implement stackalloc keyword.
28212 * cs-parser.jay: Add rule to parse stackalloc.
28214 * driver.cs: Handle /h, /help, /?
28216 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28217 before we supported unsafe code.
28219 * makefile: add --unsafe to the self compilation of mcs.
28221 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28223 * expression.cs (PointerArithmetic): New class that is used to
28224 perform pointer arithmetic.
28225 (Binary.Resolve): Handle pointer arithmetic
28226 Handle pointer comparission.
28227 (ArrayPtr): Utility expression class that is used to take the
28228 address of an array.
28230 (ElementAccess): Implement array access for pointers
28232 * statement.cs (Fixed): Implement fixed statement for arrays, we
28233 are missing one more case before we are done.
28235 * expression.cs (Indirection): Implement EmitAssign and set the
28236 ExprClass to Variable. This allows pointer dereferences to be
28237 treated as variables, and to have values assigned to them.
28239 * ecore.cs (Expression.StoreFromPtr): New utility function to
28240 store values dereferencing.
28242 2002-02-20 Ravi Pratap <ravi@ximian.com>
28244 * expression.cs (Binary.ResolveOperator): Ensure that we are
28245 not trying to operate on a void type - this fixes the reported
28248 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28249 the parent implementation is sealed.
28251 * ../errors/cs0239.cs : Add.
28253 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28255 * typemanager.cs (unverifiable_code_type): Corresponds to
28256 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28257 which have unsafe code in them.
28259 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28262 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28264 * cs-tokenizer.cs: Add support for @"litreal strings"
28266 Make tokenizer accept pre-processor directives
28267 on any column (remove the old C-like limitation).
28269 * rootcontext.cs (EmitCode): Emit any global attributes.
28270 (AddGlobalAttributes): Used to keep track of assembly attributes.
28272 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28274 * cs-parser.jay: Add support for global attributes.
28276 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28278 * expression.cs (Indirection): New helper class. Unary will
28279 create Indirection classes to be able to implement the
28280 IMemoryLocation interface on it.
28282 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28284 * cs-parser.jay (fixed_statement): reference the right statement.
28286 * statement.cs (Fixed.Emit): Finish implementing the fixed
28287 statement for the &x case.
28289 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28291 * class.cs (Property.Define, Method.Define): Remove newslot when
28294 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28295 wrong. NewSlot should only be used if the `new' keyword is present.
28297 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28298 locating our system dir. Sorry about this.
28300 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28302 * driver.cs (GetSystemDir): Compute correctly the location of our
28303 system assemblies. I was using the compiler directory instead of
28304 the library directory.
28306 2002-02-13 Ravi Pratap <ravi@ximian.com>
28308 * expression.cs (BetterFunction): Put back in what Miguel commented out
28309 since it is the correct fix. The problem is elsewhere ;-)
28311 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28312 parameters of the parms method are themselves compatible or not !
28314 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28315 to check that a class implements an interface before saying that an implicit
28316 conversion was allowed. Use ImplementsInterface to do the checking.
28318 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28320 * class.cs (Method.Define): Track whether we are an explicit
28321 implementation or not. And only call DefineMethodOverride if we
28322 are an explicit implementation.
28324 (Property.DefineMethod): Ditto.
28326 2002-02-11 Ravi Pratap <ravi@ximian.com>
28328 * expression.cs (BetterFunction): Catch hideous bug which was
28329 preventing us from detecting ambiguous calls due to implicit casts i.e
28332 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28334 * support.cs (Pair): Remove un-needed method. I figured why I was
28335 getting the error in cs-parser.jay, the variable in a foreach loop
28336 is readonly, and the compiler does not really treat this as a variable.
28338 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28339 instead of EQUALS in grammar.
28341 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28343 * expression.cs (Unary.DoResolve): Check whether the argument is
28346 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28348 * support.cs: Api for Pair to set a value. Despite the fact that
28349 the variables are public the MS C# compiler refuses to compile
28350 code that accesses the field if the variable is part of a foreach
28353 * statement.cs (Fixed): Begin implementation of the fixed
28356 (Block.AddVariable): Return the VariableInfo on success and null
28357 on failure instead of true/false.
28359 * cs-parser.jay (foreach): Catch errors on variables already
28360 defined (we were ignoring this value before) and properly unwind
28361 the block hierarchy
28363 (fixed_statement): grammar for the fixed statement.
28365 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28367 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28368 pointer types to be incretemented.
28370 (SizeOf): Implement.
28372 * cs-parser.jay (pointer_member_access): Implement
28373 expr->IDENTIFIER production.
28375 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28376 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28379 (Unary): Implement indirection.
28381 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28382 use in non-unsafe context).
28384 (SimpleName.DoResolve): Check for pointers in field access on safe
28387 (Expression.LoadFromPtr): Factor the load-indirect code in this
28388 function. This was duplicated in UnboxCast and ParameterReference
28390 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28392 * expression.cs (ComposedCast): report an error if a pointer cast
28393 is used in a safe region.
28395 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28396 pointer type casts in unsafe context.
28398 * codegen.cs (EmitContext): Set up IsUnsafe.
28400 * cs-parser.jay (non_expression_type): Add productions for pointer
28403 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28404 code. We should not use force into static mode if the method is
28405 not virtual. Fixes bug in MIS
28407 * statement.cs (Do.Emit, While.Emit, For.Emit,
28408 Statement.EmitBoolExpression): Add support to Do and While to
28409 propagate infinite loop as `I do return' semantics.
28411 Improve the For case to also test for boolean constants.
28413 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28414 to the list of attributes we can add.
28416 Remove `EmitContext' argument.
28418 * class.cs (Method.Define): Apply parameter attributes.
28419 (Constructor.Define): Apply parameter attributes.
28420 (MethodCore.LabelParameters): Move here the core of labeling
28423 * support.cs (ReflectionParameters.ParameterModifier,
28424 InternalParameters.ParameterModifier): Use IsByRef on the type and
28425 only return the OUT bit for these parameters instead of in/out/ref
28428 This is because I miss-understood things. The ParameterInfo.IsIn
28429 and IsOut represent whether the parameter has the [In] and [Out]
28432 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28434 * ecore.cs (FieldExpr.Emit): Release temporaries.
28436 * assign.cs (LocalTemporary.Release): new function.
28438 * codegen.cs (EmitContext.GetTemporaryStorage,
28439 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28440 temporary storage. Now we can "put back" localbuilders when we
28443 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28445 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28446 need to make a copy of the variable to generate verifiable code.
28448 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28450 * driver.cs: Compute dynamically the system directory.
28452 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28453 Slower, but more generally useful. Used by the abstract
28454 registering implementation.
28456 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28457 the rules for the special rule on Type/instances. First check if
28458 we have the same name, and if so, try that special static path
28459 rather than the instance path.
28461 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28463 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28466 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28467 Enum, ValueType, Delegate or Array for non-corlib compiles.
28469 * cs-tokenizer.cs: Catch long identifiers (645)
28471 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28474 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28475 fix, we were returning too early, so we were not registering
28476 pending methods from abstract classes.
28478 Do not register pending methods if the class is abstract.
28480 * expression.cs (Conditional.DoResolve): Report circular implicit
28481 conversions when we neecd to compute it for conditional
28484 (Is.DoResolve): If the expression is always of the provided type,
28485 flag warning 183. If the expression can not ever be of the
28486 provided type flag warning 184.
28488 * class.cs: Catch 169 as well.
28490 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28493 2002-01-18 Nick Drochak <ndrochak@gol.com>
28495 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28497 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28499 * interface.cs: (PopulateMethod): Check for pointers being defined
28500 only if the unsafe context is active.
28501 (PopulateProperty): ditto.
28502 (PopulateIndexer): ditto.
28504 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28505 specified. If pointers are present, make sure that they are
28506 present in an unsafe context.
28507 (Constructor, Constructor.Define): ditto.
28508 (Field, Field.Define): ditto.
28509 (Property, Property.Define): ditto.
28510 (Event, Event.Define): ditto.
28512 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28513 hashtable if there are classes or structs defined.
28515 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28516 code, as the constant resolution moved.
28518 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28519 the metadata, so we can flag error 133.
28521 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28522 pointer is being declared in an unsafe context.
28524 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28526 * modifiers.cs (Modifiers.Check): Require a Location argument.
28527 Report error 227 for Unsafe use.
28529 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28531 * statement.cs (For.Emit): If the test is null, then report that
28532 we do `return', as we wont reach anything afterwards.
28534 (Switch.SwitchGoverningType): Track the expression that matched
28537 * driver.cs: Allow negative numbers as an error code to flag.
28539 * cs-parser.jay: Handle 1551.
28541 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28543 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28545 * cs-parser.jay: Report 1518 (type declaration can only contain
28546 class, struct, interface, enum or delegate)
28548 (switch_label): Report 1523 (keywords `case' or `default' must
28551 (opt_switch_sections): Report 1522 (empty switch)
28553 * driver.cs: Report 1515 (response file specified multiple times)
28554 Report 1516 (Source file specified multiple times).
28556 * expression.cs (Argument.Resolve): Signal 1510
28558 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28559 access not allowed in static code)
28561 2002-01-11 Ravi Pratap <ravi@ximian.com>
28563 * typemanager.cs (IsPointerType): Utility method which we are going
28566 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28567 the object type, so we take care of that.
28569 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28571 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28572 added to non-params parameters :-)
28574 * typemanager.cs (CSharpName): Include 'void' type too.
28576 (void_ptr_type): Include in the set of core types.
28578 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28581 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28584 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28585 completely forgotten about it.
28587 2002-01-10 Ravi Pratap <ravi@ximian.com>
28589 * cs-parser.jay (pointer_type): Add. This begins our implementation
28590 of parsing rules for unsafe code.
28592 (unsafe_statement): Implement.
28594 (embedded_statement): Modify to include the above.
28596 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28598 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28599 if the current context is an unsafe one.
28601 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28602 are handled differently, we need separate rules for them.
28604 (local_variable_declaration): Update to use local_variable_pointer_type
28605 to allow variable declarations of unmanaged pointer types.
28607 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28608 in unsafe contexts.
28610 * ../errors/cs0214.cs : Add.
28612 2002-01-16 Nick Drochak <ndrochak@gol.com>
28614 * makefile: remove 'response' file when cleaning.
28616 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28618 * cs-parser.jay: Report 1524.
28620 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28622 * typemanager.cs (RegisterMethod): drop checking if we have
28623 registered this from here
28625 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28627 * class.cs (Method.EmitDestructor): Implement calling our base
28630 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28631 value of InFinally.
28633 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28634 this routine and will wrap the call in a try/catch block. Deal
28637 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28639 * ecore.cs (Expression.MemberLookup): instead of taking a
28640 parameter `same_type' that was used to tell whether we could
28641 access private members we compute our containing type from the
28644 (FieldExpr): Added partial support for volatile fields. This does
28645 not work for volatile fields exposed from assemblies, as I can not
28646 figure out how to extract the modreq from it.
28648 Updated all the source files to use this.
28650 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28651 because it is referenced by MemberLookup very often.
28653 2002-01-09 Ravi Pratap <ravi@ximian.com>
28655 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28656 TypeBuilder.GetCustomAttributes to retrieve what we need.
28658 Get rid of redundant default_member_attr_type as this is the same as
28659 default_member_type which already exists.
28661 * interface.cs, attribute.cs : Update accordingly.
28663 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28665 * typemanager.cs: Enable IndexerPropertyName again. It does not
28666 work for TYpeBuilders though. Ravi, can you please fix this?
28668 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28670 * expression.cs (Argument.Emit): Handle the case of ref objects
28671 being passed to ref functions;
28673 (ParameterReference.EmitLoad): Loads the content of the pointer
28674 without dereferencing.
28676 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28678 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28680 2002-01-08 Ravi Pratap <ravi@ximian.com>
28682 * class.cs (Indexer.DefineMethod): Incorporate the interface
28683 type in the name of the method if we are doing explicit interface
28686 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28688 (BetterConversion): Fix extremely trivial bug where we were referring to
28689 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28692 * ../errors/bug16.cs : Add although we have fixed it.
28694 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28696 * expression.cs (BaseIndexer): Begin implementation.
28698 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28700 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28701 production directly to remove a shift/reduce, and implement
28702 explicit interface implementation.
28704 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28705 after a floating point suffix.
28707 * expression.cs (DoNumericPromotions): Improved the conversion for
28708 uint/uint. If we have a constant, we avoid doing a typecast to a
28711 * class.cs (Indexer): Implement explicit interface implementation
28714 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28716 * class.cs: make the default instance constructor public and hidebysig.
28718 2001-01-03 Ravi Pratap <ravi@ximian.com>
28720 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28721 so we can call it from elsewhere.
28723 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28724 we emit it internally if the class has a defined indexer; otherwise the user
28725 emits it by decorating the class definition with the DefaultMemberAttribute.
28727 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28728 attribute is not used on a type which defines an indexer.
28730 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28731 character when we skip whitespace.
28733 * ../errors/cs0646.cs : Add.
28735 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28737 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28740 * makefile: Add practical target `mcs3.exe' which builds the third
28741 generation compiler.
28743 * expression.cs (New): Fix structures constructor calling.
28745 * class.cs (Property, Method, Indexer): Emit Final flag on the
28746 method if we are an interface implementation and we are not
28749 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28750 whether this property is referencing a `base' method.
28752 * expression.cs (Invocation.EmitCall): take an extra argument:
28753 is_base, this is used to determine whether the `call' or
28754 `callvirt' opcode should be used.
28757 * delegate.cs: update EmitCall.
28759 * class.cs (Method.Define): Set NewSlot for the cases where we are
28760 not implementing an interface method.
28762 (Property.Define): ditto.
28764 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28766 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28767 'r'. Allows mcs to parse itself fully.
28769 2002-01-02 Ravi Pratap <ravi@ximian.com>
28771 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28772 of the number of initializers that require the InitializeArray method.
28774 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28775 update the above field where necessary.
28777 (MakeByteBlob): Update accordingly.
28779 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28782 (EmitDynamicInitializers): Update in accordance with the new optimization.
28784 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28785 same OpCode applies.
28787 * cs-parser.jay : Fix some glaring errors I introduced.
28789 2002-01-01 Ravi Pratap <ravi@ximian.com>
28791 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28792 so that we can check for name clashes there too.
28794 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28795 for interface indexers.
28797 * interfaces.cs (Define): Emit the default member attribute.
28799 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28800 variable was being referred to while setting the value ;-)
28802 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28804 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28805 byte-by-byte information when we know the data is zero.
28807 Make the block always a multiple of 4, because
28808 DefineInitializedData has a bug.
28810 * assign.cs: Fix, we should assign from the temporary, not from
28813 * expression.cs (MakeByteBlob): Fix my incorrect code.
28815 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28817 * typemanager.cs (EnumToUnderlying): This function is used to get
28818 the underlying type from an enumeration, because it does not
28821 * constant.cs: Use the I4_S form for values between -128 and 127.
28823 * statement.cs (Block.LookupLabel): Looks up a label.
28824 (Block): Drop support for labeled blocks.
28826 (LabeledStatement): New kind of statement that represents a label
28829 (Goto): Finally implement this bad boy.
28831 * cs-parser.jay: Update to reflect new mechanism to implement
28834 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28836 * codegen.cs (EmitContext.This): a codegen property that keeps the
28837 a single instance of this instead of creating many different this
28840 * delegate.cs (Delegate.DoResolve): Update to use the property;
28842 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28844 * expression.cs (BaseAccess.DoResolve): Ditto.
28846 2001-12-29 Ravi Pratap <ravi@ximian.com>
28848 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28849 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28851 (InitCoreTypes): Update accordingly.
28853 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28854 so we can quickly store the state.
28856 (ApplyAttributes): Set the correct implementation flags
28857 for InternalCall methods.
28859 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28861 * expression.cs (EmitCall): if a method is not virtual, then do
28862 not use callvirt on it.
28864 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28865 user defined stuff) requires the use of stobj, which takes an
28866 address on the stack instead of an array and an index. So emit
28867 the Ldelema operation for it.
28869 (EmitStoreOpcode): Use stobj for valuetypes.
28871 (UnaryMutator.EmitCode): Use the right 1 value depending on
28872 whether we are dealing with int64/uint64, float or doubles.
28874 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
28875 constructors that I implemented last night.
28877 (Constructor.IsDefault): Fix to work properly for static
28880 * cs-parser.jay (CheckDef): report method signature errors.
28881 Update error number 103 to be 132.
28883 * decl.cs: New AdditionResult enumeration value: MethodExists.
28884 Although we do this check for methods later on in the semantic
28885 analysis, catching repeated default constructors is so easy that
28886 we catch these here.
28888 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
28891 (ParameterReference.EmitAssign, Emit): handle
28894 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
28895 (ArrayAccess.EmitStoreOpcode): ditto.
28897 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
28899 * expression.cs (MakeByteBlob): Complete all the missing types
28900 (uint, short, ushort, byte, sbyte)
28902 * class.cs: Only init instance field initializers on instance
28905 Rename `constructors' to instance_constructors.
28907 (TypeContainer.AddConstructor): Only add constructors to the list
28908 if it is not static.
28910 Make sure that we handle default_static_constructor independently
28911 everywhere where we handle instance_constructors
28913 2001-12-28 Miguel de Icaza <miguel@ximian.com>
28915 * class.cs: Do not lookup or create a base initializer for a
28916 static constructor.
28918 (ConstructorInitializer.Resolve): use the proper type to lookup
28921 * cs-parser.jay: Report error 1585 (modifiers between type and name).
28923 * enum.cs, interface.cs: Remove CloseType, this is taken care by
28926 * decl.cs: CloseType is now an virtual method, the default
28927 implementation just closes this type.
28929 2001-12-28 Ravi Pratap <ravi@ximian.com>
28931 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
28932 to PreserveSig by default. Also emit HideBySig on such methods.
28934 Basically, set the defaults to standard values.
28936 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
28937 argument, if candidate is better, it can't be worse than the best !
28939 (Invocation): Re-write bits to differentiate between methods being
28940 applicable in their expanded form and their normal form - for params
28943 Get rid of use_standard everywhere as only standard conversions are allowed
28944 in overload resolution.
28946 More spec conformance.
28948 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28950 * driver.cs: Add --timestamp, to see where the compiler spends
28953 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
28954 `this' in static code.
28956 (SimpleName.DoResolve): Implement in terms of a helper function
28957 that allows static-references to be passed upstream to
28960 (Expression.ResolveWithSimpleName): Resolve specially simple
28961 names when called by MemberAccess to implement the special
28964 (Expression.ImplicitReferenceConversion): Handle conversions from
28965 Null to reference types before others, as Null's type is
28968 * expression.cs (Invocation.EmitCall): Handle the special case of
28969 calling methods declared on a reference type from a ValueType
28970 (Base classes System.Object and System.Enum)
28972 (MemberAccess.Resolve): Only perform lookups on Enumerations if
28973 the left hand side is a TypeExpr, not on every enumeration.
28975 (Binary.Resolve): If types are reference types, then do a cast to
28976 object on operators != and == of both arguments.
28978 * typemanager.cs (FindMembers): Extract instance and static
28979 members if requested.
28981 * interface.cs (PopulateProperty): Use void_type instead of null
28982 as the return type for the setter method.
28984 (PopulateIndexer): ditto.
28986 2001-12-27 Ravi Pratap <ravi@ximian.com>
28988 * support.cs (ReflectionParameters): Fix minor bug where we
28989 were examining the wrong parameter for the ParamArray attribute.
28991 Cope with requests for the type of the parameter at position
28992 greater than the params parameter's. We now return the element
28993 type of the params array as that makes more sense.
28995 * expression.cs (Invocation.IsParamsMethodApplicable): Update
28996 accordingly as we no longer have to extract the element type
28999 (Invocation.OverloadResolve): Update.
29001 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29003 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29004 against IEnumerator, test whether the return value is a descendant
29005 of the IEnumerator interface.
29007 * class.cs (Indexer.Define): Use an auxiliary method to implement
29008 the other bits of the method definition. Begin support for
29009 explicit interface implementation.
29011 (Property.DefineMethod): Use TypeManager.void_type instead of null
29012 for an empty return value.
29014 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29016 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29017 dealing with a FieldExpr which is composed of a FieldBuilder, in
29018 the code path we did extract the constant, but we should have
29019 obtained the underlying value to be able to cast it (otherwise we
29020 end up in an infinite loop, this is what Ravi was running into).
29022 (ArrayCreation.UpdateIndices): Arrays might be empty.
29024 (MemberAccess.ResolveMemberAccess): Add support for section
29025 14.5.4.1 that deals with the special case of E.I when E is a type
29026 and something else, that I can be a reference to a static member.
29028 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29029 handle a particular array type to create byte blobs, it is just
29030 something we dont generate byteblobs for.
29032 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29035 * location.cs (Push): remove the key from the hashtable that we
29036 are about to add. This happens for empty files.
29038 * driver.cs: Dispose files after we have parsed them.
29040 (tokenize): new function that only runs the tokenizer on its
29041 input, for speed testing.
29043 2001-12-26 Ravi Pratap <ravi@ximian.com>
29045 * class.cs (Event.Define): Define the private field only if there
29046 are no accessors defined.
29048 * expression.cs (ResolveMemberAccess): If there is no associated
29049 field with the event, that means we have an event defined with its
29050 own accessors and we should flag error cs0070 since transforming
29051 ourselves into a field is not valid in that case.
29053 * ecore.cs (SimpleName.DoResolve): Same as above.
29055 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29056 and charset to sane values.
29058 2001-12-25 Ravi Pratap <ravi@ximian.com>
29060 * assign.cs (DoResolve): Perform check on events only if they
29061 are being accessed outside the declaring type.
29063 * cs-parser.jay (event_declarations): Update rules to correctly
29064 set the type of the implicit parameter etc.
29066 (add_accessor, remove_accessor): Set current local parameters.
29068 * expression.cs (Binary): For delegate addition and subtraction,
29069 cast the return value from the method into the appropriate delegate
29072 2001-12-24 Ravi Pratap <ravi@ximian.com>
29074 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29075 of these as the workaround is unnecessary.
29077 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29078 delegate data - none of that is needed at all.
29080 Re-write bits to extract the instance expression and the delegate method
29083 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29086 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29087 of attaching attributes instead of duplicating code everywhere.
29089 * everywhere : Update code to do attribute emission using the above method.
29091 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29093 * expression.cs (IsParamsMethodApplicable): if there are not
29094 parameters, return immediately.
29096 * ecore.cs: The 0 literal can be implicity converted to an enum
29099 (SimpleName.DoResolve): First lookup the type, then lookup the
29102 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29103 want to get its address. If the InstanceExpression is not
29104 addressable, store the result in a temporary variable, then get
29107 * codegen.cs: Only display 219 errors on warning level or above.
29109 * expression.cs (ArrayAccess): Make it implement the
29110 IMemoryLocation interface.
29112 (Binary.DoResolve): handle the operator == (object a, object b)
29113 and operator != (object a, object b) without incurring into a
29114 BoxedCast (because 5 != o should never be performed).
29116 Handle binary enumerator operators.
29118 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29119 value type, otherwise use Ldelem_ref.
29121 Use precomputed names;
29123 (AddressOf): Implement address of
29125 * cs-parser.jay (labeled_statement): Fix recursive block
29126 addition by reworking the production.
29128 * expression.cs (New.DoEmit): New has a special case:
29130 If we are dealing with a ValueType, we have a few
29131 situations to deal with:
29133 * The target of New is a ValueType variable, that is
29134 easy, we just pass this as the variable reference
29136 * The target of New is being passed as an argument,
29137 to a boxing operation or a function that takes a
29140 In this case, we need to create a temporary variable
29141 that is the argument of New.
29144 2001-12-23 Ravi Pratap <ravi@ximian.com>
29146 * rootcontext.cs (LookupType): Check that current_type is not null before
29147 going about looking at nested types.
29149 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29150 not implement the IAssignMethod interface any more.
29152 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29153 where we tranform them into FieldExprs if they are being resolved from within
29154 the declaring type.
29156 * ecore.cs (SimpleName.DoResolve): Do the same here.
29158 * assign.cs (DoResolve, Emit): Clean up code considerably.
29160 * ../errors/bug10.cs : Add.
29162 * ../errors/cs0070.cs : Add.
29164 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29166 * assign.cs : Get rid of EventIsLocal everywhere.
29168 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29170 * ecore.cs (ConvertIntLiteral): finished the implementation.
29172 * statement.cs (SwitchLabel): Convert the value we are using as a
29173 key before looking up the table.
29175 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29177 * codegen.cs (EmitTopBlock): Require a Location argument now.
29179 * cs-parser.jay (constructor_declarator): We need to setup
29180 current_local_parameters before we parse the
29181 opt_constructor_initializer, to allow the variables to be bound
29182 to the constructor arguments.
29184 * rootcontext.cs (LookupType): First lookup nested classes in our
29185 class and our parents before we go looking outside our class.
29187 * expression.cs (ConstantFold): Extract/debox the values at the
29190 * rootcontext.cs (EmitCode): Resolve the constants first before we
29191 resolve the types. This is not really needed, but it helps debugging.
29193 * statement.cs: report location.
29195 * cs-parser.jay: pass location to throw statement.
29197 * driver.cs: Small bug fix.
29199 * report.cs: Updated format to be 4-zero filled digits.
29201 2001-12-22 Ravi Pratap <ravi@ximian.com>
29203 * expression.cs (CheckIndices): Fix minor bug where the wrong
29204 variable was being referred to ;-)
29206 (DoEmit): Do not call EmitStaticInitializers when the
29207 underlying type is System.Object.
29209 2001-12-21 Ravi Pratap <ravi@ximian.com>
29211 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29212 and do the usual workaround for SRE.
29214 * class.cs (MyEventBuilder.EventType): New member to get at the type
29215 of the event, quickly.
29217 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29219 * assign.cs (Assign.DoResolve): Handle the case when the target
29220 is an EventExpr and perform the necessary checks.
29222 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29225 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29227 (EventExpr): Set the type in the constructor itself since we
29228 are meant to be born fully resolved.
29230 (EventExpr.Define): Revert code I wrote earlier.
29232 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29233 instance expression is null. The instance expression is a This in that case
29234 or a null, depending on whether it is a static method or not.
29236 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29237 refers to more than one method.
29239 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29240 and accordingly flag errors.
29242 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29244 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29246 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29248 * location.cs (ToString): Provide useful rutine.
29250 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29252 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29253 objects, return the actual integral boxed.
29255 * statement.cs (SwitchLabel): define an ILLabel for each
29258 (Switch.CheckSwitch): If the value is a Literal, extract
29259 the underlying literal.
29261 Also in the unused hashtable we had, add the SwitchLabel so we can
29262 quickly look this value up.
29264 * constant.cs: Implement a bunch of new constants. Rewrite
29265 Literal based on this. Made changes everywhere to adapt to this.
29267 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29268 dereferencing array only once, and also copes with enumrations.
29270 bytes are two bytes wide, not one.
29272 (Cast): Perform constant conversions.
29274 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29275 wrappers to the literals here.
29277 * expression.cs (DoNumericPromotions): long literals can converted
29278 to ulong implicity (this is taken care of elsewhere, but I was
29279 missing this spot).
29281 * ecore.cs (Expression.Literalize): Make the return type Literal,
29282 to improve type checking.
29284 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29286 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29288 * literal.cs: Revert code from ravi that checked the bounds. The
29289 bounds are sane by the definition of the type itself.
29291 * typemanager.cs: Fix implementation of ImplementsInterface. We
29292 need to actually look up in our parent hierarchy for interfaces
29295 * const.cs: Use the underlying type for enumerations
29297 * delegate.cs: Compute the basename for the delegate creation,
29298 that should fix the delegate test case, and restore the correct
29299 Type Lookup semantics in rootcontext
29301 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29302 referencing a nested type with the Reflection API is using the "+"
29305 * cs-parser.jay: Do not require EOF token at the end.
29307 2001-12-20 Ravi Pratap <ravi@ximian.com>
29309 * rootcontext.cs (LookupType): Concatenate type names with
29310 a '.' instead of a '+' The test suite passes again.
29312 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29313 field of the enumeration.
29315 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29316 the case when the member is an EventExpr.
29318 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29319 static has an associated instance expression.
29321 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29323 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29325 * class.cs (Event.Define): Register event and perform appropriate checks
29328 We define the Add and Remove methods even if the use provides none because
29329 in that case, we provide default implementations ourselves.
29331 Define a private field of the type of the event. This is done by the CSC compiler
29332 and we should be doing it too ;-)
29334 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29335 More methods we use in code we generate.
29337 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29340 (InitCoreTypes): Update accordingly for the above.
29342 * class.cs (Event.Emit): Generate code for default accessors that we provide
29344 (EmitDefaultMethod): Do the job in the above.
29346 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29349 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29351 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29352 builders even if we were missing one.
29354 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29355 pass the Basename as our class name instead of the Name. The
29356 basename will be correctly composed for us.
29358 * parameter.cs (Paramters): Now takes a Location argument.
29360 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29361 make all the code call directly LookupType in RootContext and take
29362 this chance to pass the Location information everywhere.
29364 * Everywhere: pass Location information.
29366 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29368 * class.cs (Constructor.Define): Updated way of detecting the
29369 length of the parameters.
29371 (TypeContainer.DefineType): Use basename as the type name for
29374 (TypeContainer.Define): Do not recursively define types here, as
29375 definition is taken care in order by the RootContext.
29377 * tree.cs: Keep track of namespaces in a per-file basis.
29379 * parameter.cs (Parameter.ComputeSignature): Update to use
29382 (Parameters.GetSignature): ditto.
29384 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29385 instead of a TypeContainer.
29387 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29388 resolve names. Because we need to be resolve in our context, not
29391 * driver.cs: Implement response files.
29393 * class.cs (TypeContainer.DefineType): If we are defined, do not
29394 redefine ourselves.
29396 (Event.Emit): Emit the code for add/remove handlers.
29397 (Event.Define): Save the MethodBuilders for add/remove.
29399 * typemanager.cs: Use pair here too.
29401 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29402 DictionaryEntry requires the first argument to be non-null.
29404 (enum_declaration): Compute full name for registering the
29407 (delegate_declaration): Instead of using
29408 formal_parameter_list, use opt_formal_parameter_list as the list
29411 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29412 (EventParsing): New property that controls whether `add' and
29413 `remove' are returned as tokens or identifiers (for events);
29415 2001-12-19 Ravi Pratap <ravi@ximian.com>
29417 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29418 use MyEventBuilder only and let it wrap the real builder for us.
29420 (MyEventBuilder): Revamp constructor etc.
29422 Implement all operations that we perform on EventBuilder in precisely the same
29425 (FindMembers): Update to use the EventBuilder member.
29427 (Event.Emit): Update accordingly.
29429 2001-12-18 Ravi Pratap <ravi@ximian.com>
29431 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29432 by calling the appropriate methods.
29434 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29437 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29439 2001-12-17 Ravi Pratap <ravi@ximian.com>
29441 * delegate.cs (Delegate.Populate): Check that the return type
29442 and various parameters types are indeed accessible.
29444 * class.cs (Constructor.Define): Same here.
29446 (Field.Define): Ditto.
29448 (Event.Define): Ditto.
29450 (Operator.Define): Check that the underlying Method defined itself
29451 correctly - so it's MethodBuilder should not be null.
29453 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29454 expression happens to be null.
29456 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29457 members but as of now we don't seem to be able to do anything really useful with it.
29459 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29460 not the EventBuilder.
29462 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29464 * cs-tokenizer.cs: Add support for defines.
29465 Add support for #if, #elif, #else, #endif
29467 (eval_var): evaluates a variable.
29468 (eval): stubbed for evaluating functions.
29470 * cs-parser.jay: Pass the defines information
29472 * driver.cs: Add --define command line option.
29474 * decl.cs: Move MemberCore here.
29476 Make it the base class for DeclSpace. This allows us to catch and
29477 report 108 and 109 for everything now.
29479 * class.cs (TypeContainer.Define): Extract all the members
29480 before populating and emit the warning 108 (new keyword required
29481 to override) instead of having each member implement this.
29483 (MemberCore.Define): New abstract method, we will be using this in
29484 the warning reporting engine in Populate.
29486 (Operator.Define): Adjust to new MemberCore protocol.
29488 * const.cs (Const): This does not derive from Expression, it is a
29489 temporary object we use to create fields, it is a MemberCore.
29491 * class.cs (Method.Define): Allow the entry point to be in a
29494 * driver.cs: Rewrite the argument handler to clean it up a bit.
29496 * rootcontext.cs: Made it just an auxiliary namespace feature by
29497 making everything static.
29499 * driver.cs: Adapt code to use RootContext type name instead of
29502 * delegate.cs: Remove RootContext argument.
29504 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29507 * class.cs (Event.Define): The lookup can fail.
29509 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29511 * expression.cs: Resolve the this instance before invoking the code.
29513 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29515 * cs-parser.jay: Add a production in element_access that allows
29516 the thing to become a "type" reference. This way we can parse
29517 things like "(string [])" as a type.
29519 Note that this still does not handle the more complex rules of
29523 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29525 * ecore.cs: (CopyNewMethods): new utility function used to
29526 assemble the list of methods from running FindMembers.
29528 (MemberLookup): Rework FindMembers so that
29530 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29532 * class.cs (TypeContainer): Remove Delegates who fail to be
29535 * delegate.cs (Populate): Verify that we dont get null return
29536 values. TODO: Check for AsAccessible.
29538 * cs-parser.jay: Use basename to emit error 574 (destructor should
29539 have the same name as container class), not the full name.
29541 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29542 possible representation.
29544 Also implements integer type suffixes U and L.
29546 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29548 * expression.cs (ArrayCreation.DoResolve): We need to do the
29549 argument resolution *always*.
29551 * decl.cs: Make this hold the namespace. Hold the root context as
29553 (LookupType): Move here.
29555 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29557 * location.cs (Row, Name): Fixed the code, it was always returning
29558 references to the first file.
29560 * interface.cs: Register properties defined through interfaces.
29562 * driver.cs: Add support for globbing on the command line
29564 * class.cs (Field): Make it derive from MemberCore as well.
29567 2001-12-15 Ravi Pratap <ravi@ximian.com>
29569 * class.cs (Event::Define): Check that the type of the event is a delegate
29570 type else flag error #66.
29572 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29575 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29576 values of EntryPoint, CharSet etc etc.
29578 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29580 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29581 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29582 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29583 which needs this to do its work.
29585 * ../errors/cs0066.cs : Add.
29587 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29589 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29592 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29593 clears out the parameters field.
29594 (MemberSignatureCompare): Cleanup
29596 (MemberCore): New base class used to share code between MethodCore
29599 (RegisterRequiredImplementations) BindingFlags.Public requires
29600 either BindingFlags.Instace or Static. Use instance here.
29602 (Property): Refactored code to cope better with the full spec.
29604 * parameter.cs (GetParameterInfo): Return an empty array instead
29607 * class.cs (Property): Abstract or extern properties have no bodies.
29609 * parameter.cs (GetParameterInfo): return a zero-sized array.
29611 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29612 method modifier validation to the typecontainer so we can reuse
29613 this on properties.
29615 (MethodCore.ParameterTypes): return an empty sized array of types.
29617 (Property.Define): Test property modifier validity.
29619 Add tests for sealed/override too.
29621 (Method.Emit): abstract or extern methods have no bodies.
29623 2001-12-14 Ravi Pratap <ravi@ximian.com>
29625 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29628 (Method::Define, ::Emit): Modify accordingly.
29630 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29632 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29634 * makefile: Pass in /unsafe.
29636 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29638 * class.cs (MakeKey): Kill routine.
29640 * class.cs (TypeContainer.Define): Correctly define explicit
29641 method implementations (they require the full interface name plus
29644 * typemanager.cs: Deply the PtrHashtable here and stop using the
29645 lame keys. Things work so much better.
29647 This of course broke everyone who depended on `RegisterMethod' to
29648 do the `test for existance' test. This has to be done elsewhere.
29650 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29651 the object stupid Equals method (because, that like fails all over
29652 the place). We still do not use it.
29654 * class.cs (TypeContainer.SetRequiredInterface,
29655 TypeContainer.RequireMethods): Killed these two routines and moved
29656 all the functionality to RegisterRequiredImplementations.
29658 (TypeContainer.RegisterRequiredImplementations): This routine now
29659 registers all the implementations required in an array for the
29660 interfaces and abstract methods. We use an array of structures
29661 which can be computed ahead of time to reduce memory usage and we
29662 also assume that lookups are cheap as most classes will not
29663 implement too many interfaces.
29665 We also avoid creating too many MethodSignatures.
29667 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29668 clear the "pending" bit if we find that there are problems with
29671 (TypeContainer.VerifyPendingMethods): Update to report errors of
29672 methods that look like implementations but are not.
29674 (TypeContainer.Define): Add support for explicit interface method
29677 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29679 * typemanager.cs: Keep track of the parameters here instead of
29680 being a feature of the TypeContainer.
29682 * class.cs: Drop the registration of parameters here, as
29683 InterfaceMethods are also interface declarations.
29685 * delegate.cs: Register methods with the TypeManager not only with
29686 the TypeContainer. This code was buggy.
29688 * interface.cs: Full registation here.
29690 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29692 * expression.cs: Remove reducer for binary expressions, it can not
29695 * const.cs: Put here the code that used to go into constant.cs
29697 * constant.cs: Put here the code for constants, this is a new base
29698 class for Literals.
29700 * literal.cs: Make Literal derive from Constant.
29702 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29704 * statement.cs (Return.Emit): Report error 157 if the user
29705 attempts to return from a finally block.
29707 (Return.Emit): Instead of emitting a return, jump to the end of
29710 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29711 LocalBuilder to store the result of the function. ReturnLabel is
29712 the target where we jump.
29715 2001-12-09 Radek Doulik <rodo@ximian.com>
29717 * cs-parser.jay: remember alias in current namespace
29719 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29722 * class.cs (LookupAlias): lookup alias in my_namespace
29724 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29726 (LookupAlias): lookup alias in this and if needed in parent
29729 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29733 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29734 making things static. I need this to avoid passing the
29735 TypeContainer when calling ParameterType.
29737 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29738 that did string manipulation to compute the type and then call
29739 GetType. Use Parameter.ParameterType instead.
29741 * cs-tokenizer.cs: Consume the suffix for floating values.
29743 * expression.cs (ParameterReference): figure out whether this is a
29744 reference parameter or not. Kill an extra variable by computing
29745 the arg_idx during emission.
29747 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29748 function that returns whether a parameter is an out/ref value or not.
29750 (Parameter.ParameterType): The type of the parameter (base,
29751 without ref/out applied).
29753 (Parameter.Resolve): Perform resolution here.
29754 (Parameter.ExternalType): The full type (with ref/out applied).
29756 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29757 support for expressions on the using statement.
29759 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29761 * statement.cs (Using.EmitLocalVariableDecls): Split the
29762 localvariable handling of the using statement.
29764 (Block.EmitMeta): Keep track of variable count across blocks. We
29765 were reusing slots on separate branches of blocks.
29767 (Try.Emit): Emit the general code block, we were not emitting it.
29769 Check the type of the declaration to be an IDisposable or
29770 something that can be implicity converted to it.
29772 Emit conversions if required.
29774 * ecore.cs (EmptyExpression): New utility class.
29775 (Expression.ImplicitConversionExists): New utility function.
29777 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29779 * statement.cs (Using): Implement.
29781 * expression.cs (LocalVariableReference): Support read only variables.
29783 * statement.cs: Remove the explicit emit for the Leave opcode.
29784 (VariableInfo): Add a readonly field.
29786 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29788 * ecore.cs (ConvCast): new class used to encapsulate the various
29789 explicit integer conversions that works in both checked and
29790 unchecked contexts.
29792 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29793 properly generate the overflow opcodes.
29795 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29797 * statement.cs: The correct type for the EmptyExpression is the
29798 element_type, not the variable type. Ravi pointed this out.
29800 2001-12-04 Ravi Pratap <ravi@ximian.com>
29802 * class.cs (Method::Define): Handle PInvoke methods specially
29803 by using DefinePInvokeMethod instead of the usual one.
29805 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29806 above to do the task of extracting information and defining the method.
29808 2001-12-04 Ravi Pratap <ravi@ximian.com>
29810 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29811 of the condition for string type.
29813 (Emit): Move that here.
29815 (ArrayCreation::CheckIndices): Keep string literals in their expression
29818 (EmitDynamicInitializers): Handle strings appropriately.
29820 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29822 * codegen.cs (EmitContext): Replace multiple variables with a
29823 single pointer to the current Switch statement.
29825 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29828 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29832 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29835 (Foreach.Emit): Foreach on arrays was not setting
29836 up the loop variables (for break/continue).
29838 (GotoCase): Semi-implented.
29840 2001-12-03 Ravi Pratap <ravi@ximian.com>
29842 * attribute.cs (CheckAttribute): Handle system attributes by using
29843 Attribute.GetAttributes to examine information we need.
29845 (GetValidPlaces): Same here.
29847 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29849 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29851 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29853 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29855 (Method::Emit): Handle the case when we are a PInvoke method.
29857 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29859 * expression.cs: Use ResolveWithSimpleName on compound names.
29861 2001-12-02 Ravi Pratap <ravi@ximian.com>
29863 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29864 before trying to reduce it.
29866 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29868 * constant.cs (LookupConstantValue): Implement.
29870 (EmitConstant): Use the above in emitting the constant.
29872 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
29873 that are user-defined by doing a LookupConstantValue on them.
29875 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
29878 2001-11-29 Miguel de Icaza <miguel@ximian.com>
29880 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
29882 (BaseAccess.DoResolve): Implement.
29884 (MemberAccess.DoResolve): Split this routine into a
29885 ResolveMemberAccess routine that can be used independently
29887 2001-11-28 Miguel de Icaza <miguel@ximian.com>
29889 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
29890 As that share bits of the implementation. Is returns a boolean,
29891 while As returns the Type that is being probed.
29893 2001-12-01 Ravi Pratap <ravi@ximian.com>
29895 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
29896 instead of a Literal - much easier.
29898 (EnumInTransit): Remove - utterly useless :-)
29900 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
29902 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
29904 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
29905 chain when we have no associated expression.
29907 2001-11-30 Ravi Pratap <ravi@ximian.com>
29909 * constant.cs (Define): Use Location while reporting the errror.
29911 Also emit a warning when 'new' is used and there is no inherited
29914 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
29917 (LookupEnumValue): Implement to lookup an enum member's value and define it
29920 (Populate): Re-write accordingly to use the above routine.
29922 2001-11-27 Miguel de Icaza <miguel@ximian.com>
29924 * expression.cs (This): Fix prototype for DoResolveLValue to
29925 override the base class DoResolveLValue.
29927 * cs-parser.cs: Report errors cs574 and cs575 (destructor
29930 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
29931 (we need to load the address of the field here). This fixes
29934 (FieldExpr.DoResolveLValue): Call the DoResolve
29935 function to initialize the Instance expression.
29937 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
29938 correctly the GetEnumerator operation on a value type.
29940 * cs-parser.jay: Add more simple parsing error catches.
29942 * statement.cs (Switch): Add support for string switches.
29943 Handle null specially.
29945 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
29947 2001-11-28 Ravi Pratap <ravi@ximian.com>
29949 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
29951 (declare_local_constant): New helper function.
29953 * statement.cs (AddConstant): Keep a separate record of constants
29955 (IsConstant): Implement to determine if a variable is a constant.
29957 (GetConstantExpression): Implement.
29959 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
29961 * statement.cs (IsVariableDefined): Re-write.
29963 2001-11-27 Ravi Pratap <ravi@ximian.com>
29965 * class.cs (TypeContainer::FindMembers): Look for constants
29966 in the case when we are looking for MemberTypes.Field
29968 * expression.cs (MemberAccess::DoResolve): Check that in the
29969 case we are a FieldExpr and a Literal, we are not being accessed
29970 by an instance reference.
29972 * cs-parser.jay (local_constant_declaration): Implement.
29974 (declaration_statement): Implement for constant declarations.
29976 2001-11-26 Miguel de Icaza <miguel@ximian.com>
29978 * statement.cs (Switch): Catch double defaults.
29980 (Switch): More work on the switch() statement
29981 implementation. It works for integral values now, need to finish
29985 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29987 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
29988 integer literals into other integer literals. To be used by
29991 2001-11-24 Ravi Pratap <ravi@ximian.com>
29993 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
29996 (EmitDynamicInitializers): Cope with the above since we extract data
29997 directly from ArrayData now.
29999 (ExpectInitializers): Keep track of whether initializers are mandatory
30002 (Bounds): Make it a hashtable to prevent the same dimension being
30003 recorded for every element in that dimension.
30005 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30008 Also fix bug which was causing the indices to be emitted in the reverse
30011 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30013 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30014 unfinished. They do not work, because the underlying code is
30017 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30019 * cs-parser.jay: Remove bogus fixme.
30021 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30022 on Switch statement.
30024 2001-11-23 Ravi Pratap <ravi@ximian.com>
30026 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30029 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30030 parameter. Apparently, any expression is allowed.
30032 (ValidateInitializers): Update accordingly.
30034 (CheckIndices): Fix some tricky bugs thanks to recursion.
30036 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30037 I was being completely brain-dead.
30039 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30040 and re-write acordingly.
30042 (DelegateInvocation): Re-write accordingly.
30044 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30046 (MakeByteBlob): Handle types more correctly.
30048 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30049 initialization from expressions but it is incomplete because I am a complete
30052 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30054 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30055 on If. Basically, we have to return `true' (ie, we do return to
30056 our caller) only if both branches of the if return.
30058 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30059 short-circuit operators, handle them as short circuit operators.
30061 (Cast.DoResolve): Resolve type.
30062 (Cast.Cast): Take an expression as the target type.
30064 * cs-parser.jay (cast_expression): Remove old hack that only
30065 allowed a limited set of types to be handled. Now we take a
30066 unary_expression and we resolve to a type during semantic
30069 Use the grammar productions from Rhys to handle casts (this is
30070 not complete like Rhys syntax yet, we fail to handle that corner
30071 case that C# has regarding (-x), but we will get there.
30073 2001-11-22 Ravi Pratap <ravi@ximian.com>
30075 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30076 field which is an array type.
30078 * cs-parser.jay (declare_local_variables): Support array initialization too.
30080 * typemanager.cs (MakeKey): Implement.
30082 (everywhere): Use the above appropriately.
30084 * cs-parser.jay (for_statement): Update for array initialization while
30085 declaring variables.
30087 * ecore.cs : The error message was correct, it's the variable's names that
30088 were misleading ;-) Make the code more readable.
30090 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30091 the correct type etc.
30093 (ConvertExplicit): Handle Enum types by examining the underlying type.
30095 2001-11-21 Ravi Pratap <ravi@ximian.com>
30097 * parameter.cs (GetCallingConvention): Always return
30098 CallingConventions.Standard for now.
30100 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30102 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30103 and `r' after calling DoNumericPromotions.
30105 * ecore.cs: Fix error message (the types were in the wrong order).
30107 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30108 BindingFlags.Instance as well
30110 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30111 implicit int literal conversion in an empty cast so that we
30112 propagate the right type upstream.
30114 (UnboxCast): new class used to unbox value types.
30115 (Expression.ConvertExplicit): Add explicit type conversions done
30118 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30119 the target type before applying the implicit LongLiterals to ULong
30122 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30124 * cs-parser.jay (for_statement): Reworked the way For works: now
30125 we declare manually any variables that are introduced in
30126 for_initializer to solve the problem of having out-of-band code
30127 emition (that is what got for broken).
30129 (declaration_statement): Perform the actual variable declaration
30130 that used to be done in local_variable_declaration here.
30132 (local_variable_declaration): Do not declare anything, just pass
30133 the information on a DictionaryEntry
30135 2001-11-20 Ravi Pratap <ravi@ximian.com>
30137 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30138 re-write of the logic to now make it recursive.
30140 (UpdateIndices): Re-write accordingly.
30142 Store element data in a separate ArrayData list in the above methods.
30144 (MakeByteBlob): Implement to dump the array data into a byte array.
30146 2001-11-19 Ravi Pratap <ravi@ximian.com>
30148 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30151 * constant.cs (Define): Implement.
30153 (EmitConstant): Re-write fully.
30155 Pass in location info.
30157 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30160 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30161 DictionaryEntry since we need location info too.
30163 (constant_declaration): Update accordingly.
30165 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30166 code into another method : UpdateIndices.
30168 2001-11-18 Ravi Pratap <ravi@ximian.com>
30170 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30171 some type checking etc.
30173 2001-11-17 Ravi Pratap <ravi@ximian.com>
30175 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30176 bits to provide dimension info if the user skips doing that.
30178 Update second constructor to store the rank correctly.
30180 2001-11-16 Ravi Pratap <ravi@ximian.com>
30182 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30183 and try to implement.
30185 * ../errors/cs0150.cs : Add.
30187 * ../errors/cs0178.cs : Add.
30189 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30191 * statement.cs: Implement foreach on multi-dimensional arrays.
30193 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30194 name of the params argument.
30196 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30197 initializing the array.
30199 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30200 we can use this elsewhere.
30202 * statement.cs: Finish implementation of foreach for single
30205 * cs-parser.jay: Use an out-of-band stack to pass information
30206 around, I wonder why I need this.
30208 foreach_block: Make the new foreach_block the current_block.
30210 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30211 function used to return a static Parameters structure. Used for
30212 empty parameters, as those are created very frequently.
30214 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30216 2001-11-15 Ravi Pratap <ravi@ximian.com>
30218 * interface.cs : Default modifier is private, not public. The
30219 make verify test passes again.
30221 2001-11-15 Ravi Pratap <ravi@ximian.com>
30223 * support.cs (ReflectionParameters): Fix logic to determine
30224 whether the last parameter is a params one. Test 9 passes again.
30226 * delegate.cs (Populate): Register the builders we define with
30227 RegisterParameterForBuilder. Test 19 passes again.
30229 * cs-parser.jay (property_declaration): Reference $6 instead
30230 of $$ to get at the location.
30232 (indexer_declaration): Similar stuff.
30234 (attribute): Ditto.
30236 * class.cs (Property): Register parameters for the Get and Set methods
30237 if they exist. Test 23 passes again.
30239 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30240 call to EmitArguments as we are sure there aren't any params arguments.
30241 Test 32 passes again.
30243 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30244 IndexOutOfRangeException.
30246 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30247 Test 33 now passes again.
30249 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30251 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30252 broke a bunch of things. Will have to come up with a better way
30253 of tracking locations.
30255 * statement.cs: Implemented foreach for single dimension arrays.
30257 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30259 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30260 an error. This removes the lookup from the critical path.
30262 * cs-parser.jay: Removed use of temporary_loc, which is completely
30265 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30267 * support.cs (ReflectionParameters.ParameterModifier): Report
30268 whether the argument is a PARAMS argument or not.
30270 * class.cs: Set the attribute `ParamArrayAttribute' on the
30271 parameter argument.
30273 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30274 and cons_param_array_attribute (ConstructorInfo for
30275 ParamArrayAttribute).,
30277 * codegen.cs: Emit the return using the `Return' statement, that
30278 way we can report the error correctly for missing return values.
30280 * class.cs (Method.Emit): Clean up.
30282 * expression.cs (Argument.Resolve): Take another argument: the
30283 location where this argument is used. Notice that this is not
30284 part of the "Argument" class as to reduce the size of the
30285 structure (we know the approximate location anyways).
30287 Test if the argument is a variable-reference, if not, then
30288 complain with a 206.
30290 (Argument.Emit): Emit addresses of variables.
30292 (Argument.FullDesc): Simplify.
30294 (Invocation.DoResolve): Update for Argument.Resolve.
30296 (ElementAccess.DoResolve): ditto.
30298 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30299 method should be virtual, as this method is always virtual.
30301 (NewDelegate.DoResolve): Update for Argument.Resolve.
30303 * class.cs (ConstructorInitializer.DoResolve): ditto.
30305 * attribute.cs (Attribute.Resolve): ditto.
30307 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30309 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30311 * expression.cs (ParameterReference): Drop IStackStorage and implement
30312 IAssignMethod instead.
30314 (LocalVariableReference): ditto.
30316 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30317 IAssignMethod instead.
30319 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30321 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30322 enumerations that are used in heavily used structures derive from
30323 byte in a laughable and pathetic attempt to reduce memory usage.
30324 This is the kind of pre-optimzations that you should not do at
30325 home without adult supervision.
30327 * expression.cs (UnaryMutator): New class, used to handle ++ and
30328 -- separatedly from the other unary operators. Cleans up the
30329 code, and kills the ExpressionStatement dependency in Unary.
30331 (Unary): Removed `method' and `Arguments' from this class, making
30332 it smaller, and moving it all to SimpleCall, so I can reuse this
30333 code in other locations and avoid creating a lot of transient data
30334 strucutres when not required.
30336 * cs-parser.jay: Adjust for new changes.
30338 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30340 * enum.cs (Enum.Populate): If there is a failure during
30343 * cs-parser.jay (opt_enum_base): we used to catch type errors
30344 here, but this is really incorrect. The type error should be
30345 catched during semantic analysis.
30347 2001-12-11 Ravi Pratap <ravi@ximian.com>
30349 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30350 current_local_parameters as expected since I, in my stupidity, had forgotten
30353 * attribute.cs (GetValidPlaces): Fix stupid bug.
30355 * class.cs (Method::Emit): Perform check on applicability of attributes.
30357 (Constructor::Emit): Ditto.
30359 (Field::Emit): Ditto.
30361 (Field.Location): Store location information.
30363 (Property, Event, Indexer, Operator): Ditto.
30365 * cs-parser.jay (field_declaration): Pass in location for each field.
30367 * ../errors/cs0592.cs : Add.
30369 2001-11-12 Ravi Pratap <ravi@ximian.com>
30371 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30373 (InitCoreTypes): Update accordingly.
30375 (RegisterAttrType, LookupAttr): Implement.
30377 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30378 info about the same.
30380 (Resolve): Update to populate the above as necessary.
30382 (Error592): Helper.
30384 (GetValidPlaces): Helper to the above.
30386 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30388 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30390 2001-11-12 Ravi Pratap <ravi@ximian.com>
30392 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30394 * ../errors/cs0617.cs : Add.
30396 2001-11-11 Ravi Pratap <ravi@ximian.com>
30398 * enum.cs (Emit): Rename to Populate to be more consistent with what
30399 we expect it to do and when exactly it is called.
30401 * class.cs, rootcontext.cs : Update accordingly.
30403 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30404 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30406 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30408 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30409 of a fieldinfo using the above, when dealing with a FieldBuilder.
30411 2001-11-10 Ravi Pratap <ravi@ximian.com>
30413 * ../errors/cs0031.cs : Add.
30415 * ../errors/cs1008.cs : Add.
30417 * ../errrors/cs0543.cs : Add.
30419 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30422 (FindMembers): Implement.
30424 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30425 enums and delegates too.
30427 (enum_types): Rename to builder_to_enum.
30429 (delegate_types): Rename to builder_to_delegate.
30431 * delegate.cs (FindMembers): Implement.
30433 2001-11-09 Ravi Pratap <ravi@ximian.com>
30435 * typemanager.cs (IsEnumType): Implement.
30437 * enum.cs (Emit): Re-write parts to account for the underlying type
30438 better and perform checking etc.
30440 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30441 of the underlying type.
30443 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30446 * enum.cs (error31): Helper to report error #31.
30448 * cs-parser.jay (enum_declaration): Store location of each member too.
30450 * enum.cs (member_to_location): New hashtable.
30452 (AddEnumMember): Update location hashtable.
30454 (Emit): Use the location of each member while reporting errors.
30456 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30458 * cs-parser.jay: A for_initializer if is a
30459 local_variable_declaration really ammount to have an implicit
30460 block with the variable declaration and no initializer for for.
30462 * statement.cs (For.Emit): Cope with null initializers.
30464 This fixes the infinite loop on for initializers.
30466 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30468 * enum.cs: More cleanup.
30470 * ecore.cs: Remove dead code.
30472 * class.cs (Property.Emit): More simplification.
30473 (Event.Emit): ditto.
30475 Reworked to have less levels of indentation.
30477 2001-11-08 Ravi Pratap <ravi@ximian.com>
30479 * class.cs (Property): Emit attributes.
30489 * enum.cs (Emit): Ditto.
30491 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30494 * class.cs (Field, Event, etc.): Move attribute generation into the
30495 Emit method everywhere.
30497 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30498 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30499 as we had no way of defining nested enums !
30501 * rootcontext.cs : Adjust code accordingly.
30503 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30505 2001-11-07 Ravi Pratap <ravi@ximian.com>
30507 * expression.cs (EvalConstantExpression): Move into ecore.cs
30509 * enum.cs (Enum): Rename some members and make them public and readonly
30510 according to our convention.
30512 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30515 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30517 (Enum::Emit): Write a simple version for now which doesn't try to compute
30518 expressions. I shall modify this to be more robust in just a while.
30520 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30522 (TypeContainer::CloseType): Create the Enum types too.
30524 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30526 * expression.cs (EvalConstantExpression): Get rid of completely.
30528 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30529 user-defined values and other cases.
30531 (IsValidEnumLiteral): Helper function.
30533 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30534 out there in the case we had a literal FieldExpr.
30536 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30538 (Literalize): Revamp a bit to take two arguments.
30540 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30542 2001-11-06 Ravi Pratap <ravi@ximian.com>
30544 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30546 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30548 (Resolve): Use the above to ensure we have proper initializers.
30550 2001-11-05 Ravi Pratap <ravi@ximian.com>
30552 * expression.cs (Expression::EvalConstantExpression): New method to
30553 evaluate constant expressions.
30555 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30557 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30559 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30562 (Binary.ResolveOperator): Handle operator != (object a, object b)
30563 and operator == (object a, object b);
30565 (Binary.DoNumericPromotions): Indicate whether the numeric
30566 promotion was possible.
30568 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30571 Made the ArrayAccess implement interface IAssignMethod instead of
30572 IStackStore as the order in which arguments are passed reflects
30575 * assign.cs: Instead of using expr.ExprClass to select the way of
30576 assinging, probe for the IStackStore/IAssignMethod interfaces.
30578 * typemanager.cs: Load InitializeArray definition.
30580 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30581 static data that can be used to initialize arrays.
30583 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30585 * expression.cs: Handle operator== and operator!= for booleans.
30587 (Conditioal.Reduce): Implement reducer for the ?: operator.
30589 (Conditional.Resolve): Implement dead code elimination.
30591 (Binary.Resolve): Catch string literals and return a new
30592 concatenated string.
30594 (Unary.Reduce): Implement reduction of unary expressions.
30596 * ecore.cs: Split out the expression core handling here.
30598 (Expression.Reduce): New method used to perform constant folding
30599 and CSE. This is needed to support constant-expressions.
30601 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30602 targets, and optimize for !x.
30604 2001-11-04 Ravi Pratap <ravi@ximian.com>
30606 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30607 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30608 set custom atttributes.
30610 * literal.cs (Literal::GetValue): New abstract method to return the actual
30611 value of the literal, cast as an object.
30613 (*Literal): Implement GetValue method.
30615 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30616 expressions to the arraylist but objects of type Argument.
30618 * class.cs (TypeContainer::Emit): Emit our attributes too.
30620 (Method::Emit, Constructor::Emit): Ditto.
30622 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30623 to be ignoring earlier.
30625 2001-11-03 Ravi Pratap <ravi@ximian.com>
30627 * attribute.cs (AttributeSection::Define): Implement to do the business
30628 of constructing a CustomAttributeBuilder.
30630 (Attribute): New trivial class. Increases readability of code.
30632 * cs-parser.jay : Update accordingly.
30634 (positional_argument_list, named_argument_list, named_argument): New rules
30636 (attribute_arguments): Use the above so that we are more correct.
30638 2001-11-02 Ravi Pratap <ravi@ximian.com>
30640 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30641 to perform all checks for a method with a params parameter.
30643 (Invocation::OverloadResolve): Update to use the above method and therefore
30644 cope correctly with params method invocations.
30646 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30649 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30650 constructors in our parent too because we can't afford to miss out on
30653 * attribute.cs (AttributeSection): New name for the class Attribute
30655 Other trivial changes to improve readability.
30657 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30658 use the new class names.
30660 2001-11-01 Ravi Pratap <ravi@ximian.com>
30662 * class.cs (Method::Define): Complete definition for params types too
30664 (Indexer::Define): Ditto.
30666 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30667 Cope everywhere with a request for info about the array parameter.
30669 2001-11-01 Ravi Pratap <ravi@ximian.com>
30671 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30673 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30674 local_variable_type to extract the string corresponding to the type.
30676 (local_variable_type): Fixup the action to use the new helper method.
30678 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30681 * expression.cs : Clean out code which uses the above.
30683 2001-10-31 Ravi Pratap <ravi@ximian.com>
30685 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30686 and bale out if necessary by returning a false.
30688 (RegisterProperty): Ditto.
30690 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30691 and print out appropriate error messages.
30693 * interface.cs (everywhere): Ditto.
30695 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30696 location to constructor.
30698 * class.cs (Property, Event, Indexer): Update accordingly.
30700 * ../errors/cs111.cs : Added.
30702 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30703 of a method, as laid down by the spec.
30705 (Invocation::OverloadResolve): Use the above method.
30707 2001-10-31 Ravi Pratap <ravi@ximian.com>
30709 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30710 now take a TypeContainer and a Parameters object.
30712 (ParameterData): Modify return type of ParameterModifier method to be
30713 Parameter.Modifier and not a string.
30715 (ReflectionParameters, InternalParameters): Update accordingly.
30717 * expression.cs (Argument::GetParameterModifier): Same here.
30719 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30720 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30721 symbol in it at all so maybe this is only for now.
30723 2001-10-30 Ravi Pratap <ravi@ximian.com>
30725 * support.cs (InternalParameters): Constructor now takes an extra argument
30726 which is the actual Parameters class.
30728 (ParameterDesc): Update to provide info on ref/out modifiers.
30730 * class.cs (everywhere): Update call to InternalParameters to pass in
30731 the second argument too.
30733 * support.cs (ParameterData): Add ParameterModifier, which is a method
30734 to return the modifier info [ref/out etc]
30736 (InternalParameters, ReflectionParameters): Implement the above.
30738 * expression.cs (Argument::ParameterModifier): Similar function to return
30739 info about the argument's modifiers.
30741 (Invocation::OverloadResolve): Update to take into account matching modifiers
30744 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30745 a new SetFormalParameters object which we pass to InternalParameters.
30747 2001-10-30 Ravi Pratap <ravi@ximian.com>
30749 * expression.cs (NewArray): Merge into the ArrayCreation class.
30751 2001-10-29 Ravi Pratap <ravi@ximian.com>
30753 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30754 NewUserdefinedArray into one as there wasn't much of a use in having
30757 * expression.cs (Argument): Change field's name to ArgType from Type.
30759 (Type): New readonly property which returns the proper type, taking into
30760 account ref/out modifiers.
30762 (everywhere): Adjust code accordingly for the above.
30764 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30765 whether we are emitting for a ref or out parameter.
30767 * expression.cs (Argument::Emit): Use the above field to set the state.
30769 (LocalVariableReference::Emit): Update to honour the flag and emit the
30772 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30774 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30776 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30778 (ReflectionParameters, InternalParameters): Implement the above method.
30780 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30783 (Invocation::FullMethodDesc): Ditto.
30785 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30787 * cs-parser.jay: Add extra production for the second form of array
30790 * expression.cs (ArrayCreation): Update to reflect the above
30793 * Small changes to prepare for Array initialization.
30795 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30797 * typemanager.cs (ImplementsInterface): interface might be null;
30798 Deal with this problem;
30800 Also, we do store negative hits on the cache (null values), so use
30801 this instead of calling t.GetInterfaces on the type everytime.
30803 2001-10-28 Ravi Pratap <ravi@ximian.com>
30805 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30807 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30808 split functionality out into different classes.
30810 (New::FormArrayType): Move into NewBuiltinArray.
30812 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30815 (NewBuiltinArray): New class to handle creation of built-in arrays.
30817 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30818 account creation of one-dimensional arrays.
30820 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30822 (NewUserdefinedArray::DoResolve): Implement.
30824 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30826 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30827 we maintain inside the TypeManager. This is necessary to perform lookups on the
30830 (LookupType): Update to perform GetType on the module builders too.
30832 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30834 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30836 2001-10-23 Ravi Pratap <ravi@ximian.com>
30838 * expression.cs (New::DoResolve): Implement guts of array creation.
30840 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30842 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30844 * expression.cs: Fix bug I introduced lsat night that broke
30847 (Expression.Resolve): Report a 246 error (can not resolve name)
30848 if we find a SimpleName in the stream.
30850 (Expression.ResolveLValue): Ditto.
30852 (Expression.ResolveWithSimpleName): This function is a variant of
30853 ResolveName, this one allows SimpleNames to be returned without a
30854 warning. The only consumer of SimpleNames is MemberAccess
30856 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30858 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30859 might arrive here. I have my doubts that this is correct.
30861 * statement.cs (Lock): Implement lock statement.
30863 * cs-parser.jay: Small fixes to support `lock' and `using'
30865 * cs-tokenizer.cs: Remove extra space
30867 * driver.cs: New flag --checked, allows to turn on integer math
30870 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30871 Threading.Monitor.Exit
30873 2001-10-23 Miguel de Icaza <miguel@ximian.com>
30875 * expression.cs (IndexerAccess::DoResolveLValue): Set the
30876 Expression Class to be IndexerAccess.
30878 Notice that Indexer::DoResolve sets the eclass to Value.
30880 2001-10-22 Miguel de Icaza <miguel@ximian.com>
30882 * class.cs (TypeContainer::Emit): Emit code for indexers.
30884 * assign.cs (IAssignMethod): New interface implemented by Indexers
30885 and Properties for handling assignment.
30887 (Assign::Emit): Simplify and reuse code.
30889 * expression.cs (IndexerAccess, PropertyExpr): Implement
30890 IAssignMethod, clean up old code.
30892 2001-10-22 Ravi Pratap <ravi@ximian.com>
30894 * typemanager.cs (ImplementsInterface): New method to determine if a type
30895 implements a given interface. Provides a nice cache too.
30897 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
30900 (ConvertReferenceExplicit): Ditto.
30902 * delegate.cs (Delegate::Populate): Update to define the parameters on the
30903 various methods, with correct names etc.
30905 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
30906 Operator.UnaryNegation.
30908 * cs-parser.jay (operator_declarator): Be a little clever in the case where
30909 we have a unary plus or minus operator.
30911 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
30914 * everywhere : update accordingly.
30916 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
30919 * class.cs (Method::Define): For the case where we are implementing a method
30920 inherited from an interface, we need to set the MethodAttributes.Final flag too.
30921 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
30923 2001-10-21 Ravi Pratap <ravi@ximian.com>
30925 * interface.cs (FindMembers): Implement to work around S.R.E
30928 * typemanager.cs (IsInterfaceType): Implement.
30930 (FindMembers): Update to handle interface types too.
30932 * expression.cs (ImplicitReferenceConversion): Re-write bits which
30933 use IsAssignableFrom as that is not correct - it doesn't work.
30935 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
30936 and accordingly override EmitStatement.
30938 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
30939 using the correct logic :-)
30941 2001-10-19 Ravi Pratap <ravi@ximian.com>
30943 * ../errors/cs-11.cs : Add to demonstrate error -11
30945 2001-10-17 Miguel de Icaza <miguel@ximian.com>
30947 * assign.cs (Assign::Resolve): Resolve right hand side first, and
30948 then pass this as a hint to ResolveLValue.
30950 * expression.cs (FieldExpr): Add Location information
30952 (FieldExpr::LValueResolve): Report assignment to readonly
30955 (Expression::ExprClassFromMemberInfo): Pass location information.
30957 (Expression::ResolveLValue): Add new method that resolves an
30960 (Expression::DoResolveLValue): Default invocation calls
30963 (Indexers): New class used to keep track of indexers in a given
30966 (IStackStore): Renamed from LValue, as it did not really describe
30967 what this did. Also ResolveLValue is gone from this interface and
30968 now is part of Expression.
30970 (ElementAccess): Depending on the element access type
30972 * typemanager.cs: Add `indexer_name_type' as a Core type
30973 (System.Runtime.CompilerServices.IndexerNameAttribute)
30975 * statement.cs (Goto): Take a location.
30977 2001-10-18 Ravi Pratap <ravi@ximian.com>
30979 * delegate.cs (Delegate::VerifyDelegate): New method to verify
30980 if two delegates are compatible.
30982 (NewDelegate::DoResolve): Update to take care of the case when
30983 we instantiate a delegate from another delegate.
30985 * typemanager.cs (FindMembers): Don't even try to look up members
30986 of Delegate types for now.
30988 2001-10-18 Ravi Pratap <ravi@ximian.com>
30990 * delegate.cs (NewDelegate): New class to take care of delegate
30993 * expression.cs (New): Split the delegate related code out into
30994 the NewDelegate class.
30996 * delegate.cs (DelegateInvocation): New class to handle delegate
30999 * expression.cs (Invocation): Split out delegate related code into
31000 the DelegateInvocation class.
31002 2001-10-17 Ravi Pratap <ravi@ximian.com>
31004 * expression.cs (New::DoResolve): Implement delegate creation fully
31005 and according to the spec.
31007 (New::DoEmit): Update to handle delegates differently.
31009 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31010 because of which we were printing out arguments in reverse order !
31012 * delegate.cs (VerifyMethod): Implement to check if the given method
31013 matches the delegate.
31015 (FullDelegateDesc): Implement.
31017 (VerifyApplicability): Implement.
31019 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31020 delegate invocations too.
31022 (Invocation::Emit): Ditto.
31024 * ../errors/cs1593.cs : Added.
31026 * ../errors/cs1594.cs : Added.
31028 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31030 2001-10-16 Ravi Pratap <ravi@ximian.com>
31032 * typemanager.cs (intptr_type): Core type for System.IntPtr
31034 (InitCoreTypes): Update for the same.
31036 (iasyncresult_type, asynccallback_type): Ditto.
31038 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31041 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31044 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31045 the builders for the 4 members of a delegate type :-)
31047 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31050 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31052 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31054 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31056 * statement.cs (Break::Emit): Implement.
31057 (Continue::Emit): Implement.
31059 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31060 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31061 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31062 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31065 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31066 properties that track the label for the current loop (begin of the
31067 loop and end of the loop).
31069 2001-10-15 Ravi Pratap <ravi@ximian.com>
31071 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31072 use of emitting anything at all.
31074 * class.cs, rootcontext.cs : Get rid of calls to the same.
31076 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31078 (Populate): Define the constructor correctly and set the implementation
31081 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31084 (AddDelegateType): Implement.
31086 (IsDelegateType): Implement helper method.
31088 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31090 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31091 and accordingly handle it.
31093 * delegate.cs (Populate): Take TypeContainer argument.
31094 Implement bits to define the Invoke method. However, I still haven't figured out
31095 how to take care of the native int bit :-(
31097 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31098 Qualify the name of the delegate, not its return type !
31100 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31103 (StandardConversionExists): Checking for array types turns out to be recursive.
31105 (ConvertReferenceExplicit): Implement array conversion.
31107 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31109 2001-10-12 Ravi Pratap <ravi@ximian.com>
31111 * cs-parser.jay (delegate_declaration): Store the fully qualified
31112 name as it is a type declaration.
31114 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31117 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31118 as TypeContainer::DefineType.
31120 (Populate): Method in which all the definition of the various methods (Invoke)
31123 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31126 (CloseDelegate): Finally creates the delegate.
31128 * class.cs (TypeContainer::DefineType): Update to define delegates.
31129 (Populate, Emit and CloseType): Do the same thing here too.
31131 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31132 delegates in all these operations.
31134 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31136 * expression.cs: LocalTemporary: a new expression used to
31137 reference a temporary that has been created.
31139 * assign.cs: Handle PropertyAccess back here, so that we can
31140 provide the proper semantic access to properties.
31142 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31143 a few more explicit conversions.
31145 * modifiers.cs: `NEW' modifier maps to HideBySig.
31147 * expression.cs (PropertyExpr): Make this into an
31148 ExpressionStatement, and support the EmitStatement code path.
31150 Perform get/set error checking, clean up the interface.
31152 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31153 them into toplevel access objects.
31155 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31157 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31160 * typemanager.cs: Keep track here of our PropertyBuilders again to
31161 work around lameness in SRE.
31163 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31165 * expression.cs (LValue::LValueResolve): New method in the
31166 interface, used to perform a second resolution pass for LValues.
31168 (This::DoResolve): Catch the use of this in static methods.
31170 (This::LValueResolve): Implement.
31172 (This::Store): Remove warning, assigning to `this' in structures
31175 (Invocation::Emit): Deal with invocation of
31176 methods on value types. We need to pass the address to structure
31177 methods rather than the object itself. (The equivalent code to
31178 emit "this" for structures leaves the entire structure on the
31179 stack instead of a pointer to it).
31181 (ParameterReference::DoResolve): Compute the real index for the
31182 argument based on whether the method takes or not a `this' pointer
31183 (ie, the method is static).
31185 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31186 value types returned from functions when we need to invoke a
31187 method on the sturcture.
31190 2001-10-11 Ravi Pratap <ravi@ximian.com>
31192 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31193 defining the type in the Modulebuilder or Typebuilder. This is to take
31194 care of nested types which need to be defined on the TypeBuilder using
31195 DefineNestedMethod.
31197 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31198 methods in RootContext, only ported to be part of TypeContainer.
31200 (TypeContainer::GetInterfaceOrClass): Ditto.
31202 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31204 * interface.cs (Interface::DefineInterface): New method. Does exactly
31205 what RootContext.CreateInterface did earlier, only it takes care of nested types
31208 (Interface::GetInterfaces): Move from RootContext here and port.
31210 (Interface::GetInterfaceByName): Same here.
31212 * rootcontext.cs (ResolveTree): Re-write.
31214 (PopulateTypes): Re-write.
31216 * class.cs (TypeContainer::Populate): Populate nested types too.
31217 (TypeContainer::Emit): Emit nested members too.
31219 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31220 instead just use the name argument passed in as it is already fully
31223 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31224 to TypeContainer mapping to see if a type is user-defined.
31226 * class.cs (TypeContainer::CloseType): Implement.
31228 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31229 the default constructor.
31231 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31234 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31236 * interface.cs (CloseType): Create the type here.
31238 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31241 Remove all the methods which are now in TypeContainer.
31243 2001-10-10 Ravi Pratap <ravi@ximian.com>
31245 * delegate.cs (Define): Re-write bits to define the delegate
31248 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31250 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31252 * expression.cs (ImplicitReferenceConversion): handle null as well
31253 as a source to convert to any reference type.
31255 * statement.cs (Return): Perform any implicit conversions to
31256 expected return type.
31258 Validate use of return statement.
31260 * codegen.cs (EmitContext): Pass the expected return type here.
31262 * class.cs (Method, Constructor, Property): Pass expected return
31263 type to EmitContext.
31265 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31267 * expression.cs: Make DoResolve take an EmitContext instead of a
31270 Replaced `l' and `location' for `loc', for consistency.
31272 (Error, Warning): Remove unneeded Tc argument.
31274 * assign.cs, literal.cs, constant.cs: Update to new calling
31277 * codegen.cs: EmitContext now contains a flag indicating whether
31278 code is being generated in a static method or not.
31280 * cs-parser.jay: DecomposeQI, new function that replaces the old
31281 QualifiedIdentifier. Now we always decompose the assembled
31282 strings from qualified_identifier productions into a group of
31285 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31287 * rootcontext.cs: Deal with field-less struct types correctly now
31288 by passing the size option to Define Type.
31290 * class.cs: Removed hack that created one static field.
31292 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31294 * statement.cs: Moved most of the code generation here.
31296 2001-10-09 Ravi Pratap <ravi@ximian.com>
31298 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31301 (ElementAccess): Remove useless bits for now - keep checks as the spec
31304 2001-10-08 Ravi Pratap <ravi@ximian.com>
31306 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31307 and start performing checks according to the spec.
31309 2001-10-07 Ravi Pratap <ravi@ximian.com>
31311 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31312 rank_specifiers instead.
31314 (rank_specifiers): Change the order in which the rank specifiers are stored
31316 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31318 * expression.cs (ElementAccess): Implement the LValue interface too.
31320 2001-10-06 Ravi Pratap <ravi@ximian.com>
31322 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31323 except that user defined conversions are not included.
31325 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31326 perform the conversion of the return type, if necessary.
31328 (New::DoResolve): Check whether we are creating an array or an object
31329 and accordingly do the needful.
31331 (New::Emit): Same here.
31333 (New::DoResolve): Implement guts of array creation.
31335 (New::FormLookupType): Helper function.
31337 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31339 * codegen.cs: Removed most of the code generation here, and move the
31340 corresponding code generation bits to the statement classes.
31342 Added support for try/catch/finalize and throw.
31344 * cs-parser.jay: Added support for try/catch/finalize.
31346 * class.cs: Catch static methods having the flags override,
31347 virtual or abstract.
31349 * expression.cs (UserCast): This user cast was not really doing
31350 what it was supposed to do. Which is to be born in fully resolved
31351 state. Parts of the resolution were being performed at Emit time!
31355 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31357 * expression.cs: Implicity convert the result from UserCast.
31359 2001-10-05 Ravi Pratap <ravi@ximian.com>
31361 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31362 prevented it from working correctly.
31364 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31365 merely ConvertImplicit.
31367 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31369 * typemanager.cs: Make the LookupTypeContainer function static,
31370 and not per-instance.
31372 * class.cs: Make static FindMembers (the one that takes a Type
31375 * codegen.cs: Add EmitForeach here.
31377 * cs-parser.jay: Make foreach a toplevel object instead of the
31378 inline expansion, as we need to perform semantic analysis on it.
31380 2001-10-05 Ravi Pratap <ravi@ximian.com>
31382 * expression.cs (Expression::ImplicitUserConversion): Rename to
31383 UserDefinedConversion.
31385 (Expression::UserDefinedConversion): Take an extra argument specifying
31386 whether we look for explicit user conversions too.
31388 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31390 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31392 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31393 with the appropriate arguments.
31395 * cs-parser.jay (cast_expression): Record location too.
31397 * expression.cs (Cast): Record location info.
31399 (Expression::ConvertExplicit): Take location argument.
31401 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31402 to determine if we are doing explicit conversions.
31404 (UserCast::Emit): Update accordingly.
31406 (Expression::ConvertExplicit): Report an error if everything fails.
31408 * ../errors/cs0030.cs : Add.
31410 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31412 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31413 virtual and newslot bits.
31415 * class.cs (TypeContainer::RegisterRequiredImplementations):
31416 Record methods we need.
31418 (TypeContainer::MakeKey): Helper function to make keys for
31419 MethodBases, since the Methodbase key is useless.
31421 (TypeContainer::Populate): Call RegisterRequiredImplementations
31422 before defining the methods.
31424 Create a mapping for method_builders_to_methods ahead of time
31425 instead of inside a tight loop.
31427 (::RequireMethods): Accept an object as the data to set into the
31428 hashtable so we can report interface vs abstract method mismatch.
31430 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31432 * report.cs: Make all of it static.
31434 * rootcontext.cs: Drop object_type and value_type computations, as
31435 we have those in the TypeManager anyways.
31437 Drop report instance variable too, now it is a global.
31439 * driver.cs: Use try/catch on command line handling.
31441 Add --probe option to debug the error reporting system with a test
31444 * report.cs: Add support for exiting program when a probe
31445 condition is reached.
31447 2001-10-03 Ravi Pratap <ravi@ximian.com>
31449 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31450 we do a forcible conversion regardless of type, to check if
31451 ForceConversion returns a null.
31453 (Binary::error19): Use location to report error.
31455 (Unary::error23): Use location here too.
31457 * ../errors/cs0019.cs : Check in.
31459 * ../errors/cs0023.cs : Check in.
31461 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31462 case of a non-null MethodInfo object with a length of 0 !
31464 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31465 an applicable member - according to the spec :-)
31466 Also fix logic to find members in base types.
31468 (Unary::ResolveOperator): Same here.
31470 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31471 as I was getting thoroughly confused between this and error19 :-)
31473 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31474 (::FindMostEncompassedType): Implement.
31475 (::FindMostEncompassingType): Implement.
31476 (::StandardConversionExists): Implement.
31478 (UserImplicitCast): Re-vamp. We now need info about most specific
31479 source and target types so that we can do the necessary conversions.
31481 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31482 mathematical union with no duplicates.
31484 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31486 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31487 in order from base classes to child classes, so that we can in
31488 child classes look up in our parent for method names and
31489 attributes (required for handling abstract, virtual, new, override
31490 constructs: we need to instrospect our base class, and if we dont
31491 populate the classes in order, the introspection might be
31492 incorrect. For example, a method could query its parent before
31493 the parent has any methods and would determine that the parent has
31494 no abstract methods (while it could have had them)).
31496 (RootContext::CreateType): Record the order in which we define the
31499 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31501 * class.cs (TypeContainer::Populate): Also method definitions can
31502 fail now, keep track of this.
31504 (TypeContainer::FindMembers): Implement support for
31505 DeclaredOnly/noDeclaredOnly flag.
31507 (Constructor::Emit) Return the ConstructorBuilder.
31509 (Method::Emit) Return the MethodBuilder.
31510 Check for abstract or virtual methods to be public.
31512 * rootcontext.cs (RootContext::CreateType): Register all the
31513 abstract methods required for the class to be complete and the
31514 interface methods that must be implemented.
31516 * cs-parser.jay: Report error 501 (method requires body if it is
31517 not marked abstract or extern).
31519 * expression.cs (TypeOf::Emit): Implement.
31521 * typemanager.cs: runtime_handle_type, new global type.
31523 * class.cs (Property::Emit): Generate code for properties.
31525 2001-10-02 Ravi Pratap <ravi@ximian.com>
31527 * expression.cs (Unary::ResolveOperator): Find operators on base type
31528 too - we now conform exactly to the spec.
31530 (Binary::ResolveOperator): Same here.
31532 * class.cs (Operator::Define): Fix minor quirk in the tests.
31534 * ../errors/cs0215.cs : Added.
31536 * ../errors/cs0556.cs : Added.
31538 * ../errors/cs0555.cs : Added.
31540 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31542 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31543 single integer which is really efficient
31545 2001-10-01 Ravi Pratap <ravi@ximian.com>
31547 * expression.cs (Expression::ImplicitUserConversion): Use location
31548 even in the case when we are examining True operators.
31550 * class.cs (Operator::Define): Perform extensive checks to conform
31551 with the rules for operator overloading in the spec.
31553 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31554 some of the other conversions mentioned in the spec.
31556 * typemanager.cs (array_type): New static member for the System.Array built-in
31559 (cloneable_interface): For System.ICloneable interface.
31561 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31562 we start resolving the tree and populating types.
31564 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31566 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31568 * expression.cs (Expression::ExprClassFromMemberInfo,
31569 Expression::Literalize): Create literal expressions from
31570 FieldInfos which are literals.
31572 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31573 type casts, because they were wrong. The test suite in tests
31576 (ImplicitNumericConversion): ushort to ulong requires a widening
31579 Int32 constant to long requires widening cast as well.
31581 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31582 for integers because the type on the stack is not i4.
31584 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31586 * expression.cs (report118): require location argument.
31588 * parameter.cs: Do not dereference potential null value.
31590 * class.cs: Catch methods that lack the `new' keyword when
31591 overriding a name. Report warnings when `new' is used without
31592 anything being there to override.
31594 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31596 * class.cs: Only add constructor to hashtable if it is non-null
31597 (as now constructors can fail on define).
31599 (TypeManager, Class, Struct): Take location arguments.
31601 Catch field instance initialization in structs as errors.
31603 accepting_filter: a new filter for FindMembers that is static so
31604 that we dont create an instance per invocation.
31606 (Constructor::Define): Catch errors where a struct constructor is
31609 * cs-parser.jay: Pass location information for various new
31612 * delegate.cs (Delegate): take a location argument.
31614 * driver.cs: Do not call EmitCode if there were problesm in the
31615 Definition of the types, as many Builders wont be there.
31617 * decl.cs (Decl::Decl): Require a location argument.
31619 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31620 into integers, and find the most appropiate integer for it.
31622 * literal.cs: Implement ULongLiteral.
31624 * rootcontext.cs: Provide better information about the location of
31625 failure when CreateType fails.
31627 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31629 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31632 * expression.cs (Binary::CheckShiftArguments): Add missing type
31634 (Binary::ResolveOperator): Add type to the logical and and logical
31635 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31638 (Binary::DoNumericPromotions): In the case where either argument
31639 is ulong (and most signed types combined with ulong cause an
31640 error) perform implicit integer constant conversions as well.
31642 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31644 * expression.cs (UserImplicitCast): Method should always be
31646 (Invocation::BetterConversion): Simplified test for IntLiteral.
31648 (Expression::ImplicitNumericConversion): Split this routine out.
31649 Put the code that performs implicit constant integer conversions
31652 (Expression::Resolve): Become a wrapper around DoResolve so we can
31653 check eclass and type being set after resolve.
31655 (Invocation::Badness): Remove this dead function
31657 (Binary::ResolveOperator): Do not compute the expensive argumnets
31658 unless we have a union for it.
31660 (Probe::Emit): Is needs to do an isinst and then
31661 compare against null.
31663 (::CanConvert): Added Location argument. If the Location argument
31664 is null (Location.Null), then we do not report errors. This is
31665 used by the `probe' mechanism of the Explicit conversion. We do
31666 not want to generate an error for something that the user
31667 explicitly requested to be casted. But the pipeline for an
31668 explicit cast first tests for potential implicit casts.
31670 So for now, if the Location is null, it means `Probe only' to
31671 avoid adding another argument. Might have to revise this
31674 (ClassCast): New class used to type cast objects into arbitrary
31675 classes (used in Explicit Reference Conversions).
31677 Implement `as' as well.
31679 Reverted all the patches from Ravi below: they were broken:
31681 * The use of `level' as a mechanism to stop recursive
31682 invocations is wrong. That was there just to catch the
31683 bug with a strack trace but not as a way of addressing
31686 To fix the problem we have to *understand* what is going
31687 on and the interactions and come up with a plan, not
31688 just get things going.
31690 * The use of the type conversion cache that I proposed
31691 last night had an open topic: How does this work across
31692 protection domains. A user defined conversion might not
31693 be public in the location where we are applying the
31694 conversion, a different conversion might be selected
31695 (ie, private A->B (better) but public B->A (worse),
31696 inside A, A->B applies, but outside it, B->A will
31699 * On top of that (ie, even if the above is solved),
31700 conversions in a cache need to be abstract. Ie, `To
31701 convert from an Int to a Short use an OpcodeCast', not
31702 `To convert from an Int to a Short use the OpcodeCast on
31703 the variable 5' (which is what this patch was doing).
31705 2001-09-28 Ravi Pratap <ravi@ximian.com>
31707 * expression.cs (Invocation::ConversionExists): Re-write to use
31708 the conversion cache
31710 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31711 cache all conversions done, not just user-defined ones.
31713 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31714 to determine if a conversion exists instead of acutually trying to
31715 perform the conversion. It's faster too.
31717 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31718 and only then attempt the implicit conversion.
31720 2001-09-28 Ravi Pratap <ravi@ximian.com>
31722 * expression.cs (ConvertImplicit): Use a cache for conversions
31723 already found. Check level of recursion and bail out if necessary.
31725 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31727 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31728 Export standard methods that we expect for string operations.
31730 * statement.cs (Block::UsageWarning): Track usage of variables and
31731 report the errors for not used variables.
31733 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31736 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31738 * codegen.cs: remove unnneded code
31740 * expression.cs: Removed BuiltinTypeAccess class
31742 Fix the order in which implicit conversions are
31745 The previous fixed dropped support for boxed conversions (adding a
31746 test to the test suite now)
31748 (UserImplicitCast::CanConvert): Remove test for source being null,
31749 that code is broken. We should not feed a null to begin with, if
31750 we do, then we should track the bug where the problem originates
31751 and not try to cover it up here.
31753 Return a resolved expression of type UserImplicitCast on success
31754 rather than true/false. Ravi: this is what I was talking about,
31755 the pattern is to use a static method as a "constructor" for
31758 Also, do not create arguments until the very last minute,
31759 otherwise we always create the arguments even for lookups that
31760 will never be performed.
31762 (UserImplicitCast::Resolve): Eliminate, objects of type
31763 UserImplicitCast are born in a fully resolved state.
31765 * typemanager.cs (InitCoreTypes): Init also value_type
31766 (System.ValueType).
31768 * expression.cs (Cast::Resolve): First resolve the child expression.
31770 (LValue): Add new method AddressOf to be used by
31773 Change the argument of Store to take an EmitContext instead of an
31774 ILGenerator, because things like FieldExpr need to be able to call
31775 their children expression to generate the instance code.
31777 (Expression::Error, Expression::Warning): Sugar functions for
31780 (Expression::MemberLookup): Accept a TypeContainer instead of a
31781 Report as the first argument.
31783 (Expression::ResolvePrimary): Killed. I still want to improve
31784 this as currently the code is just not right.
31786 (Expression::ResolveMemberAccess): Simplify, but it is still
31789 (Unary::Resolve): Catch errors in AddressOf operators.
31791 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31792 index to a byte for the short-version, or the compiler will choose
31793 the wrong Emit call, which generates the wrong data.
31795 (ParameterReference::Emit, ::Store): same.
31797 (FieldExpr::AddressOf): Implement.
31799 * typemanager.cs: TypeManager: made public variable instead of
31802 * driver.cs: document --fatal.
31804 * report.cs (ErrorMessage, WarningMessage): new names for the old
31805 Error and Warning classes.
31807 * cs-parser.jay (member_access): Turn built-in access to types
31808 into a normal simplename
31810 2001-09-27 Ravi Pratap <ravi@ximian.com>
31812 * expression.cs (Invocation::BetterConversion): Fix to cope
31813 with q being null, since this was introducing a bug.
31815 * expression.cs (ConvertImplicit): Do built-in conversions first.
31817 2001-09-27 Ravi Pratap <ravi@ximian.com>
31819 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31821 2001-09-27 Ravi Pratap <ravi@ximian.com>
31823 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31824 I had introduced long ago (what's new ?).
31826 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31827 the work of all the checking.
31828 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31829 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31831 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31832 that is the right way.
31834 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31835 overloading resolution. Use everywhere instead of cutting and pasting code.
31837 (Binary::ResolveOperator): Use MakeUnionSet.
31839 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31840 we have to convert to bool types. Not complete yet.
31842 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31844 * typemanager.cs (TypeManager::CSharpName): support ushort.
31846 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31847 to provide an expression that performsn an implicit constant int
31848 conversion (section 6.1.6).
31849 (Expression::ConvertImplicitRequired): Reworked to include
31850 implicit constant expression conversions.
31852 (Expression::ConvertNumericExplicit): Finished.
31854 (Invocation::Emit): If InstanceExpression is null, then it means
31855 that we perform a call on this.
31857 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31859 * expression.cs (Unary::Emit): Remove some dead code.
31860 (Probe): Implement Resolve and Emit for `is'.
31861 (Expression::ConvertImplicitRequired): Attempt to do constant
31862 expression conversions here. Maybe should be moved to
31863 ConvertImplicit, but I am not sure.
31864 (Expression::ImplicitLongConstantConversionPossible,
31865 Expression::ImplicitIntConstantConversionPossible): New functions
31866 that tell whether is it possible to apply an implicit constant
31867 expression conversion.
31869 (ConvertNumericExplicit): Started work on explicit numeric
31872 * cs-parser.jay: Update operator constants.
31874 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
31875 (Parameters::GetSignature): Hook up VerifyArgs here.
31876 (Parameters::VerifyArgs): Verifies that no two arguments have the
31879 * class.cs (Operator): Update the operator names to reflect the
31880 ones that the spec expects (as we are just stringizing the
31883 * expression.cs (Unary::ResolveOperator): Fix bug: Use
31884 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
31885 previous usage did only work for our methods.
31886 (Expression::ConvertImplicit): Handle decimal implicit numeric
31887 conversions as well.
31888 (Expression::InternalTypeConstructor): Used to invoke constructors
31889 on internal types for default promotions.
31891 (Unary::Emit): Implement special handling for the pre/post
31892 increment/decrement for overloaded operators, as they need to have
31893 the same semantics as the other operators.
31895 (Binary::ResolveOperator): ditto.
31896 (Invocation::ConversionExists): ditto.
31897 (UserImplicitCast::Resolve): ditto.
31899 2001-09-26 Ravi Pratap <ravi@ximian.com>
31901 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
31902 operator, return after emitting body. Regression tests pass again !
31904 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
31905 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
31906 (Invocation::OverloadResolve): Ditto.
31907 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
31909 * everywhere : update calls to the above methods accordingly.
31911 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31913 * assign.cs (Assign): Make it inherit from ExpressionStatement.
31915 * expression.cs (ExpressionStatement): New base class used for
31916 expressions that can appear in statements, so that we can provide
31917 an alternate path to generate expression that do not leave a value
31920 (Expression::Emit, and all the derivatives): We no longer return
31921 whether a value is left on the stack or not. Every expression
31922 after being emitted leaves a single value on the stack.
31924 * codegen.cs (EmitContext::EmitStatementExpression): Use the
31925 facilties of ExpressionStatement if possible.
31927 * cs-parser.jay: Update statement_expression.
31929 2001-09-25 Miguel de Icaza <miguel@ximian.com>
31931 * driver.cs: Change the wording of message
31933 2001-09-25 Ravi Pratap <ravi@ximian.com>
31935 * expression.cs (Binary::ResolveOperator): Had forgottten to set
31936 the type of the expression to the return type of the method if
31937 we have an overloaded operator match ! The regression tests pass again !
31938 (Unary::ResolveOperator): Ditto.
31940 * expression.cs (Invocation::ConversionExists): Correct the member lookup
31941 to find "op_Implicit", not "implicit" ;-)
31942 (UserImplicitCast): New class to take care of user-defined implicit conversions.
31943 (ConvertImplicit, ForceConversion): Take TypeContainer argument
31945 * everywhere : Correct calls to the above accordingly.
31947 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
31948 (ConvertImplicit): Do user-defined conversion if it exists.
31950 2001-09-24 Miguel de Icaza <miguel@ximian.com>
31952 * assign.cs: track location.
31953 (Resolve): Use implicit conversions on assignment.
31955 * literal.cs: Oops. Not good, Emit of short access values should
31956 pass (Bytes) or the wrong argument will be selected.
31958 * expression.cs (Unary::Emit): Emit code for -expr.
31960 (Unary::ResolveOperator): Handle `Substract' for non-constants
31961 (substract from zero from the non-constants).
31962 Deal with Doubles as well.
31964 (Expression::ConvertImplicitRequired): New routine that reports an
31965 error if no implicit conversion exists.
31967 (Invocation::OverloadResolve): Store the converted implicit
31968 expressions if we make them
31970 2001-09-24 Ravi Pratap <ravi@ximian.com>
31972 * class.cs (ConstructorInitializer): Take a Location argument.
31973 (ConstructorBaseInitializer): Same here.
31974 (ConstructorThisInitializer): Same here.
31976 * cs-parser.jay : Update all calls accordingly.
31978 * expression.cs (Unary, Binary, New): Take location argument.
31979 Update accordingly everywhere.
31981 * cs-parser.jay : Update all calls to the above to take a location
31984 * class.cs : Ditto.
31986 2001-09-24 Ravi Pratap <ravi@ximian.com>
31988 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
31989 (Invocation::BetterConversion): Same here
31990 (Invocation::ConversionExists): Ditto.
31992 (Invocation::ConversionExists): Implement.
31994 2001-09-22 Ravi Pratap <ravi@ximian.com>
31996 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
31997 Also take an additional TypeContainer argument.
31999 * All over : Pass in TypeContainer as argument to OverloadResolve.
32001 * typemanager.cs (CSharpName): Update to check for the string type and return
32004 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32007 2001-09-21 Ravi Pratap <ravi@ximian.com>
32009 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32010 (Invocation::BetterFunction): Implement.
32011 (Invocation::BetterConversion): Implement.
32012 (Invocation::ConversionExists): Skeleton, no implementation yet.
32014 Okay, things work fine !
32016 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32018 * typemanager.cs: declare and load enum_type, delegate_type and
32021 * expression.cs (Expression::Emit): Now emit returns a value that
32022 tells whether a value is left on the stack or not. This strategy
32023 might be reveted tomorrow with a mechanism that would address
32024 multiple assignments.
32025 (Expression::report118): Utility routine to report mismatches on
32028 (Unary::Report23): Report impossible type/operator combination
32031 (Unary::IsIncrementableNumber): Whether the type can be
32032 incremented or decremented with add.
32033 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32035 (Unary::ResolveOperator): Implement ++, !, ~,
32037 (Invocation::Emit): Deal with new Emit convetion.
32039 * All Expression derivatives: Updated their Emit method to return
32040 whether they leave values on the stack or not.
32042 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32043 stack for expressions that are statements.
32045 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32047 * expression.cs (LValue): New interface. Must be implemented by
32049 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32052 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32053 interface for generating code, simplifies the code.
32055 2001-09-20 Ravi Pratap <ravi@ximian.com>
32057 * expression.cs (everywhere): Comment out return statements in ::Resolve
32058 methods to avoid the warnings.
32060 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32062 * driver.cs (parse): Report error 2001 if we can not open the
32065 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32068 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32071 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32072 otherwise nested blocks end up with the same index.
32074 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32076 * expression.cs: Instead of having FIXMEs in the Resolve
32077 functions, throw exceptions so it is obvious that we are facing a
32080 * cs-parser.jay (invocation_expression): Pass Location information.
32082 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32083 Use a basename for those routines because .NET does not like paths
32086 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32089 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32091 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32092 are loading the correct data types (throws an exception if not).
32093 (TypeManager::InitCoreTypes): Use CoreLookupType
32095 * expression.cs (Unary::ResolveOperator): return the child
32096 expression for expressions which are just +expr.
32097 (Unary::ResolveOperator): Return negative literals for -LITERAL
32098 expressions (otherwise they are Unary {Literal}).
32099 (Invocation::Badness): Take into account `Implicit constant
32100 expression conversions'.
32102 * literal.cs (LongLiteral): Implement long literal class.
32103 (IntLiteral): export the `Value' of the intliteral.
32105 2001-09-19 Ravi Pratap <ravi@ximian.com>
32107 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32109 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32110 instead of 'Operator'
32112 * expression.cs (Binary::ResolveOperator): Update accordingly.
32113 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32116 * cs-parser.jay (unary_expression): Update to use the new names.
32118 * gen-treedump.cs (GetUnary): Same here.
32120 * expression.cs (Unary::Resolve): Implement.
32121 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32122 operators are found instead of making noise ;-)
32123 (Unary::ResolveOperator): New method to do precisely the same thing which
32124 Binary::ResolveOperator does for Binary expressions.
32125 (Unary.method, .Arguments): Add.
32126 (Unary::OperName): Implement.
32127 (Unary::ForceConversion): Copy and Paste !
32129 * class.cs (Operator::Define): Fix a small bug for the case when we have
32132 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32133 for the inbuilt operators. Only overloading works for now ;-)
32135 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32137 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32138 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32140 * expression.cs (This::Emit): Implement.
32141 (This::Resolve): Implement.
32142 (TypeOf:Resolve): Implement.
32143 (Expression::ResolveSimpleName): Add an implicit this to instance
32145 (MemberAccess::Resolve): Deal with Parameters and Fields.
32146 Bind instance variable to Field expressions.
32147 (FieldExpr::Instance): New field used to track the expression that
32148 represents the object instance.
32149 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32151 (FieldExpr::Emit): Implement.
32153 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32154 the last instruction contains a return opcode to avoid generating
32155 the last `ret' instruction (this generates correct code, and it is
32156 nice to pass the peverify output).
32158 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32159 initializer for static and instance variables.
32160 (Constructor::Emit): Allow initializer to be null in the case of
32161 static constructors. Only emit initializer for instance
32164 (TypeContainer::FindMembers): Return a null array if there are no
32167 Also fix the code for the MemberTypes.Method branch, as it was not
32168 scanning that for operators (or tried to access null variables before).
32170 * assign.cs (Assign::Emit): Handle instance and static fields.
32174 * driver.cs: Stop compilation if there are parse errors.
32176 * cs-parser.jay (constructor_declaration): Provide default base
32177 initializer for non-static constructors.
32178 (constructor_declarator): Do not provide a default base
32179 initializers if none was specified.
32180 Catch the fact that constructors should not have parameters.
32182 * class.cs: Do not emit parent class initializers for static
32183 constructors, that should be flagged as an error.
32185 2001-09-18 Ravi Pratap <ravi@ximian.com>
32187 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32188 Move back code into TypeContainer::Populate.
32190 2001-09-18 Ravi Pratap <ravi@ximian.com>
32192 * class.cs (TypeContainer::AddConstructor): Fix the check to
32193 compare against Name, not Basename.
32194 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32196 * cs-parser.jay : Update accordingly.
32198 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32199 for methods, don't forget to look into the operators too.
32200 (RegisterMethodBuilder): Helper method to take care of this for
32201 methods, constructors and operators.
32202 (Operator::Define): Completely revamp.
32203 (Operator.OperatorMethod, MethodName): New fields.
32204 (TypeContainer::Populate): Move the registering of builders into
32205 RegisterMethodBuilder.
32206 (Operator::Emit): Re-write.
32208 * expression.cs (Binary::Emit): Comment out code path to emit method
32209 invocation stuff for the case when we have a user defined operator. I am
32210 just not able to get it right !
32212 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32214 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32217 (Expression::MemberLookup): Provide a version that allows to
32218 specify the MemberTypes and BindingFlags.
32220 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32221 so it was not fetching variable information from outer blocks.
32223 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32224 Beforefieldinit as it was buggy.
32226 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32227 that Ravi put here.
32229 * class.cs (Constructor::Emit): Only emit if block is not null.
32230 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32231 deal with this by semantically definining it as if the user had
32234 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32235 constructors as we now "emit" them at a higher level.
32237 (TypeContainer::DefineDefaultConstructor): Used to define the
32238 default constructors if none was provided.
32240 (ConstructorInitializer): Add methods Resolve and Emit.
32242 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32244 2001-09-17 Ravi Pratap <ravi@ximian.com>
32246 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32247 the default constructor builder with our hashtable for methodbuilders
32250 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32251 and argument_count is 0 in which case we have a match.
32252 (Binary::ResolveOperator): More null checking and miscellaneous coding
32255 2001-09-17 Ravi Pratap <ravi@ximian.com>
32257 * rootcontext.cs (IsNameSpace): Compare against null.
32259 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32261 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32262 and Unary::Operator.
32264 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32267 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32268 we have overloaded operators.
32269 (Binary::ResolveOperator): Implement the part which does the operator overload
32272 * class.cs (Operator::Emit): Implement.
32273 (TypeContainer::Emit): Emit the operators we have too.
32275 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32276 the case when we have a user-defined operator.
32278 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32280 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32282 2001-09-16 Ravi Pratap <ravi@ximian.com>
32284 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32285 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32286 (Constructor::Emit): Implement.
32287 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32288 if we have no work to do.
32289 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32292 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32293 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32295 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32298 2001-09-15 Ravi Pratap <ravi@ximian.com>
32300 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32302 (Tree::RecordNamespace): Method to do what the name says ;-)
32303 (Tree::Namespaces): Property to get at the namespaces hashtable.
32305 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32308 * rootcontext.cs (IsNamespace): Fixed it :-)
32310 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32312 * class.cs (TypeContainer::FindMembers): Add support for
32314 (MethodCore): New class that encapsulates both the shared aspects
32315 of a Constructor and a Method.
32316 (Method, Constructor): Factored pieces into MethodCore.
32318 * driver.cs: Added --fatal which makes errors throw exceptions.
32319 Load System assembly as well as part of the standard library.
32321 * report.cs: Allow throwing exceptions on errors for debugging.
32323 * modifiers.cs: Do not use `parent', instead use the real type
32324 container to evaluate permission settings.
32326 * class.cs: Put Ravi's patch back in. He is right, and we will
32327 have to cope with the
32329 2001-09-14 Ravi Pratap <ravi@ximian.com>
32331 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32332 FamORAssem, not FamANDAssem.
32334 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32336 * driver.cs: Added --parse option that only parses its input files
32339 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32340 incorrect. IsTopLevel is not used to tell whether an object is
32341 root_types or not (that can be achieved by testing this ==
32342 root_types). But to see if this is a top-level *class* (not
32343 necessarly our "toplevel" container).
32345 2001-09-14 Ravi Pratap <ravi@ximian.com>
32347 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32348 parent instead of a direct call to GetType.
32350 2001-09-14 Ravi Pratap <ravi@ximian.com>
32352 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32353 Modifiers.TypeAttr. This should just be a call to that method.
32355 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32356 object so that we can determine if we are top-level or not.
32358 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32361 * enum.cs (Enum::Define): Ditto.
32363 * modifiers.cs (FieldAttr): Re-write.
32365 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32366 (TypeContainer::HaveStaticConstructor): New property to provide access
32367 to precisely that info.
32369 * modifiers.cs (MethodAttr): Re-write.
32370 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32372 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32373 of top-level types as claimed.
32375 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32377 * expression.cs (MemberLookup): Fruitless attempt to lookup
32378 constructors. Maybe I need to emit default constructors? That
32379 might be it (currently .NET emits this for me automatically).
32380 (Invocation::OverloadResolve): Cope with Arguments == null.
32381 (Invocation::EmitArguments): new function, shared by the new
32382 constructor and us.
32383 (Invocation::Emit): Handle static and instance methods. Emit
32384 proper call instruction for virtual or non-virtual invocations.
32385 (New::Emit): Implement.
32386 (New::Resolve): Implement.
32387 (MemberAccess:Resolve): Implement.
32388 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32389 to track instances.
32390 (FieldExpr::Resolve): Set type.
32392 * support.cs: Handle empty arguments.
32394 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32395 SimpleLookup): Auxiliary routines to help parse a qualifier
32398 Update qualifier_identifier rule.
32400 * codegen.cs: Removed debugging messages.
32402 * class.cs: Make this a global thing, this acts just as a "key" to
32403 objects that we might have around.
32405 (Populate): Only initialize method_builders_to_methods once.
32407 * expression.cs (PropertyExpr): Initialize type from the
32410 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32411 Resolve pattern. Attempt to implicitly convert value to boolean.
32414 * expression.cs: Set the type for the int32/int32 argument case.
32415 (Binary::ResolveOperator): Set the return type to boolean for
32416 comparission operators
32418 * typemanager.cs: Remove debugging print code.
32420 (Invocation::Resolve): resolve type.
32422 * class.cs: Allocate a MemberInfo of the correct size, as the code
32423 elsewhere depends on the test to reflect the correct contents.
32425 (Method::) Keep track of parameters, due to System.Reflection holes
32427 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32430 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32431 of the exact size and return that.
32433 (Class::LookupMethodByBuilder): New function that maps
32434 MethodBuilders to its methods. Required to locate the information
32435 on methods because System.Reflection bit us again.
32437 * support.cs: New file, contains an interface ParameterData and
32438 two implementations: ReflectionParameters and InternalParameters
32439 used to access Parameter information. We will need to grow this
32442 * expression.cs (Invocation::GetParameterData): implement a cache
32443 and a wrapper around the ParameterData creation for methods.
32444 (Invocation::OverloadResolve): Use new code.
32446 2001-09-13 Ravi Pratap <ravi@ximian.com>
32448 * class.cs (TypeContainer::EmitField): Remove and move into
32449 (Field::Define): here and modify accordingly.
32450 (Field.FieldBuilder): New member.
32451 (TypeContainer::Populate): Update accordingly.
32452 (TypeContainer::FindMembers): Implement.
32454 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32456 * statement.cs: (VariableInfo::VariableType): New field to be
32457 initialized with the full type once it is resolved.
32459 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32461 * parameter.cs (GetParameterInfo): Use a type cache to compute
32462 things only once, and to reuse this information
32464 * expression.cs (LocalVariableReference::Emit): Implement.
32465 (OpcodeCast::Emit): fix.
32467 (ParameterReference::Resolve): Implement.
32468 (ParameterReference::Emit): Implement.
32470 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32471 that are expressions need to stay as Expressions.
32473 * typemanager.cs (CSharpName): Returns the C# name of a type if
32476 * expression.cs (Expression::ConvertImplicit): New function that
32477 implements implicit type conversions.
32479 (Expression::ImplicitReferenceConversion): Implements implicit
32480 reference conversions.
32482 (EmptyCast): New type for transparent casts.
32484 (OpcodeCast): New type for casts of types that are performed with
32485 a sequence of bytecodes.
32487 (BoxedCast): New type used for casting value types into reference
32488 types. Emits a box opcode.
32490 (Binary::DoNumericPromotions): Implements numeric promotions of
32491 and computation of the Binary::Type.
32493 (Binary::EmitBranchable): Optimization.
32495 (Binary::Emit): Implement code emission for expressions.
32497 * typemanager.cs (TypeManager): Added two new core types: sbyte
32500 2001-09-12 Ravi Pratap <ravi@ximian.com>
32502 * class.cs (TypeContainer::FindMembers): Method which does exactly
32503 what Type.FindMembers does, only we don't have to use reflection. No
32504 implementation yet.
32506 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32507 typecontainer objects as we need to get at them.
32508 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32510 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32511 typecontainer object.
32513 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32514 of just a Report object.
32516 2001-09-11 Ravi Pratap <ravi@ximian.com>
32518 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32520 (TypeContainer::Populate): Now define the delegates of the type too.
32521 (TypeContainer.Delegates): Property to access the list of delegates defined
32524 * delegates.cs (Delegate::Define): Implement partially.
32526 * modifiers.cs (TypeAttr): Handle more flags.
32528 2001-09-11 Ravi Pratap <ravi@ximian.com>
32530 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32532 (Operator::Define): Re-write logic to get types by using the LookupType method
32533 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32534 (Indexer::Define): Ditto.
32535 (Event::Define): Ditto.
32536 (Property::Define): Ditto.
32538 2001-09-10 Ravi Pratap <ravi@ximian.com>
32540 * class.cs (TypeContainer::Populate): Now define operators too.
32541 (TypeContainer.Operators): New property to access the list of operators
32543 (Operator.OperatorMethodBuilder): New member to hold the method builder
32544 for the operator we are defining.
32545 (Operator::Define): Implement.
32547 2001-09-10 Ravi Pratap <ravi@ximian.com>
32549 * class.cs (Event::Define): Make the prefixes of the accessor methods
32550 addOn_ and removeOn_
32552 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32553 of the location being passed in too. Ideally, this should go later since all
32554 error reporting should be done through the Report object.
32556 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32557 (Populate): Iterate thru the indexers we have and define them too.
32558 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32559 for the get and set accessors.
32560 (Indexer::Define): Implement.
32562 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32564 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32565 my previous implementation, did not work.
32567 * typemanager.cs: Add a couple of missing types (the longs).
32569 * literal.cs: Use TypeManager.bool_type instead of getting it.
32571 * expression.cs (EventExpr): New kind of expressions.
32572 (Expressio::ExprClassFromMemberInfo): finish
32574 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32576 * assign.cs: Emit stores to static fields differently.
32578 2001-09-08 Ravi Pratap <ravi@ximian.com>
32580 * Merge in changes and adjust code to tackle conflicts. Backed out my
32581 code in Assign::Resolve ;-)
32583 2001-09-08 Ravi Pratap <ravi@ximian.com>
32585 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32586 instead Report.Error and also pass in the location.
32587 (CSharpParser::Lexer): New readonly property to return the reference
32588 to the Tokenizer object.
32589 (declare_local_variables): Use Report.Error with location instead of plain
32593 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32594 (Operator.CheckBinaryOperator): Ditto.
32596 * cs-parser.jay (operator_declarator): Update accordingly.
32598 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32599 (CheckBinaryOperator): Same here.
32601 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32602 on the name without any prefixes of namespace names etc. This is because we
32603 already might have something already fully qualified like
32604 'System.Console.WriteLine'
32606 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32608 2001-09-07 Ravi Pratap <ravi@ximian.com>
32610 * cs-tokenizer.cs (location): Return a string which also contains
32613 * expression.cs (ElementAccess): New class for expressions of the
32614 type 'element access.'
32615 (BaseAccess): New class for expressions of the type 'base access.'
32616 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32619 * cs-parser.jay (element_access): Implement action.
32620 (base_access): Implement actions.
32621 (checked_expression, unchecked_expression): Implement.
32623 * cs-parser.jay (local_variable_type): Correct and implement.
32624 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32626 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32628 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32629 name and the specifiers.
32631 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32633 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32634 making them all public ;-)
32636 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32639 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32641 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32643 (FieldExpr, PropertyExprs): New resolved expressions.
32644 (SimpleName::MemberStaticCheck): Perform static checks for access
32645 to non-static fields on static methods. Maybe this should be
32646 generalized for MemberAccesses.
32647 (SimpleName::ResolveSimpleName): More work on simple name
32650 * cs-parser.jay (primary_expression/qualified_identifier): track
32651 the parameter index.
32653 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32654 (EmitContext::EmitBoolExpression): Chain to expression generation
32655 instead of temporary hack.
32656 (::EmitStatementExpression): Put generic expression code generation.
32658 * assign.cs (Assign::Emit): Implement variable assignments to
32659 local variables, parameters and fields.
32661 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32663 * statement.cs (Block::GetVariableInfo): New method, returns the
32664 VariableInfo for a variable name in a block.
32665 (Block::GetVariableType): Implement in terms of GetVariableInfo
32667 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32668 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32670 2001-09-06 Ravi Pratap <ravi@ximian.com>
32672 * cs-parser.jay (operator_declaration): Continue on my quest : update
32673 to take attributes argument.
32674 (event_declaration): Ditto.
32675 (enum_declaration): Ditto.
32676 (indexer_declaration): Ditto.
32678 * class.cs (Operator::Operator): Update constructor accordingly.
32679 (Event::Event): Ditto.
32681 * delegate.cs (Delegate::Delegate): Same here.
32683 * enum.cs (Enum::Enum): Same here.
32685 2001-09-05 Ravi Pratap <ravi@ximian.com>
32687 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32689 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32691 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32692 being passed around as an arraylist.
32693 (Attributes::AddAttribute): Method to add attribute sections.
32695 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32696 (struct_declaration): Update accordingly.
32697 (constant_declaration): Update.
32698 (field_declaration): Update.
32699 (method_header): Update.
32700 (fixed_parameter): Update.
32701 (parameter_array): Ditto.
32702 (property_declaration): Ditto.
32703 (destructor_declaration): Ditto.
32705 * class.cs (Struct::Struct): Update constructors accordingly.
32706 (Class::Class): Ditto.
32707 (Field::Field): Ditto.
32708 (Method::Method): Ditto.
32709 (Property::Property): Ditto.
32710 (TypeContainer::OptAttribute): update property's return type.
32712 * interface.cs (Interface.opt_attributes): New member.
32713 (Interface::Interface): Update to take the extra Attributes argument.
32715 * parameter.cs (Parameter::Parameter): Ditto.
32717 * constant.cs (Constant::Constant): Ditto.
32719 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32720 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32721 the attributes as a parameter.
32722 (InterfaceProperty): Update constructor call.
32723 (InterfaceEvent): Ditto.
32724 (InterfaceMethod): Ditto.
32725 (InterfaceIndexer): Ditto.
32727 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32728 pass the attributes too.
32729 (interface_event_declaration): Ditto.
32730 (interface_property_declaration): Ditto.
32731 (interface_method_declaration): Ditto.
32732 (interface_declaration): Ditto.
32734 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32736 * class.cs (Method::Define): Track the "static Main" definition to
32737 create an entry point.
32739 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32740 EntryPoint if we find it.
32742 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32743 (EmitContext::ig): Make this variable public.
32745 * driver.cs: Make the default output file be the first file name
32746 with the .exe extension.
32748 Detect empty compilations
32750 Handle various kinds of output targets. Handle --target and
32751 rename -t to --dumper.
32753 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32754 methods inherited from Expression return now an Expression. This
32755 will is used during the tree rewriting as we resolve them during
32758 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32759 the spec. Missing entirely is the information about
32760 accessability of elements of it.
32762 (Expression::ExprClassFromMemberInfo): New constructor for
32763 Expressions that creates a fully initialized Expression based on
32764 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32767 (Invocation::Resolve): Begin implementing resolution of invocations.
32769 * literal.cs (StringLiteral): Implement Emit.
32771 2001-09-05 Ravi Pratap <ravi@ximian.com>
32773 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32776 2001-09-04 Ravi Pratap <ravi@ximian.com>
32778 * cs-parser.jay (attribute_arguments): Implement actions.
32779 (attribute): Fix bug in production. Implement action.
32780 (attribute_list): Implement.
32781 (attribute_target): Implement.
32782 (attribute_target_specifier, opt_target_specifier): Implement
32783 (CheckAttributeTarget): New method to check if the attribute target
32785 (attribute_section): Implement.
32786 (opt_attributes): Implement.
32788 * attribute.cs : New file to handle attributes.
32789 (Attribute): Class to hold attribute info.
32791 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32792 (attribute_section): Modify production to use 2 different rules to
32793 achieve the same thing. 1 s/r conflict down !
32794 Clean out commented, useless, non-reducing dimension_separator rules.
32796 * class.cs (TypeContainer.attributes): New member to hold list
32797 of attributes for a type.
32798 (Struct::Struct): Modify to take one more argument, the attribute list.
32799 (Class::Class): Ditto.
32800 (Field::Field): Ditto.
32801 (Method::Method): Ditto.
32802 (Property::Property): Ditto.
32804 * cs-parser.jay (struct_declaration): Update constructor call to
32805 pass in the attributes too.
32806 (class_declaration): Ditto.
32807 (constant_declaration): Ditto.
32808 (field_declaration): Ditto.
32809 (method_header): Ditto.
32810 (fixed_parameter): Ditto.
32811 (parameter_array): Ditto.
32812 (property_declaration): Ditto.
32814 * constant.cs (Constant::Constant): Update constructor similarly.
32815 Use System.Collections.
32817 * parameter.cs (Parameter::Parameter): Update as above.
32819 2001-09-02 Ravi Pratap <ravi@ximian.com>
32821 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32822 (TypeContainer.delegates): New member to hold list of delegates.
32824 * cs-parser.jay (delegate_declaration): Implement the action correctly
32825 this time as I seem to be on crack ;-)
32827 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32829 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32830 tell whether an identifier represents a namespace.
32832 * expression.cs (NamespaceExpr): A namespace expression, used only
32833 temporarly during expression resolution.
32834 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32835 utility functions to resolve names on expressions.
32837 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32839 * codegen.cs: Add hook for StatementExpressions.
32841 * class.cs: Fix inverted test for static flag in methods.
32843 2001-09-02 Ravi Pratap <ravi@ximian.com>
32845 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32846 to make it coincide with MS' number.
32847 (Operator::CheckBinaryOperator): Ditto.
32849 * ../errors/errors.txt : Remove error numbers added earlier.
32851 * ../errors/cs1019.cs : Test case for error # 1019
32853 * ../errros/cs1020.cs : Test case for error # 1020
32855 * cs-parser.jay : Clean out commented cruft.
32856 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32857 used anywhere - non-reducing rule.
32858 (namespace_declarations): Non-reducing rule - comment out.
32860 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32861 with TypeContainer::AddEnum.
32863 * delegate.cs : New file for delegate handling classes.
32864 (Delegate): Class for declaring delegates.
32866 * makefile : Update.
32868 * cs-parser.jay (delegate_declaration): Implement.
32870 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
32872 * class.cs (Event::Define): Implement.
32873 (Event.EventBuilder): New member.
32875 * class.cs (TypeContainer::Populate): Update to define all enums and events
32877 (Events): New property for the events arraylist we hold. Shouldn't we move to using
32878 readonly fields for all these cases ?
32880 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32882 * class.cs (Property): Revamp to use the convention of making fields readonly.
32883 Accordingly modify code elsewhere.
32885 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
32886 the Define method of the Property class.
32888 * class.cs : Clean up applied patch and update references to variables etc. Fix
32890 (TypeContainer::Populate): Update to define all the properties we have. Also
32891 define all enumerations.
32893 * enum.cs (Define): Implement.
32895 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32897 * cs-parser.jay (overloadable_operator): The semantic value is an
32898 enum of the Operator class.
32899 (operator_declarator): Implement actions.
32900 (operator_declaration): Implement.
32902 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
32903 validity of definitions.
32904 (Operator::CheckBinaryOperator): Static method to check for binary operators
32905 (TypeContainer::AddOperator): New method to add an operator to a type.
32907 * cs-parser.jay (indexer_declaration): Added line to actually call the
32908 AddIndexer method so it gets added ;-)
32910 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
32911 already taken care of by the MS compiler ?
32913 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32915 * class.cs (Operator): New class for operator declarations.
32916 (Operator::OpType): Enum for the various operators.
32918 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32920 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
32921 ostensibly handle this in semantic analysis.
32923 * cs-parser.jay (general_catch_clause): Comment out
32924 (specific_catch_clauses, specific_catch_clause): Ditto.
32925 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
32926 (catch_args, opt_catch_args): New productions.
32927 (catch_clause): Rewrite to use the new productions above
32928 (catch_clauses): Modify accordingly.
32929 (opt_catch_clauses): New production to use in try_statement
32930 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
32931 and re-write the code in the actions to extract the specific and
32932 general catch clauses by being a little smart ;-)
32934 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
32935 Hooray, try and catch statements parse fine !
32937 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32939 * statement.cs (Block::GetVariableType): Fix logic to extract the type
32940 string from the hashtable of variables.
32942 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
32943 I end up making that mistake ;-)
32944 (catch_clauses): Fixed gross error which made Key and Value of the
32945 DictionaryEntry the same : $1 !!
32947 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32949 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
32951 * cs-parser.jay (event_declaration): Correct to remove the semicolon
32952 when the add and remove accessors are specified.
32954 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32956 * cs-parser.jay (IndexerDeclaration): New helper class to hold
32957 information about indexer_declarator.
32958 (indexer_declarator): Implement actions.
32959 (parsing_indexer): New local boolean used to keep track of whether
32960 we are parsing indexers or properties. This is necessary because
32961 implicit_parameters come into picture even for the get accessor in the
32962 case of an indexer.
32963 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
32965 * class.cs (Indexer): New class for indexer declarations.
32966 (TypeContainer::AddIndexer): New method to add an indexer to a type.
32967 (TypeContainer::indexers): New member to hold list of indexers for the
32970 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32972 * cs-parser.jay (add_accessor_declaration): Implement action.
32973 (remove_accessor_declaration): Implement action.
32974 (event_accessors_declaration): Implement
32975 (variable_declarators): swap statements for first rule - trivial.
32977 * class.cs (Event): New class to hold information about event
32979 (TypeContainer::AddEvent): New method to add an event to a type
32980 (TypeContainer::events): New member to hold list of events.
32982 * cs-parser.jay (event_declaration): Implement actions.
32984 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32986 * cs-parser.jay (dim_separators): Implement. Make it a string
32987 concatenating all the commas together, just as they appear.
32988 (opt_dim_separators): Modify accordingly
32989 (rank_specifiers): Update accordingly. Basically do the same
32990 thing - instead, collect the brackets here.
32991 (opt_rank_sepcifiers): Modify accordingly.
32992 (array_type): Modify to actually return the complete type string
32993 instead of ignoring the rank_specifiers.
32994 (expression_list): Implement to collect the expressions
32995 (variable_initializer): Implement. We make it a list of expressions
32996 essentially so that we can handle the array_initializer case neatly too.
32997 (variable_initializer_list): Implement.
32998 (array_initializer): Make it a list of variable_initializers
32999 (opt_array_initializer): Modify accordingly.
33001 * expression.cs (New::NType): Add enumeration to help us
33002 keep track of whether we have an object/delegate creation
33003 or an array creation.
33004 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33005 members to hold data about array creation.
33006 (New:New): Modify to update NewType
33007 (New:New): New Overloaded contructor for the array creation
33010 * cs-parser.jay (array_creation_expression): Implement to call
33011 the overloaded New constructor.
33013 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33015 * class.cs (TypeContainer::Constructors): Return member
33016 constructors instead of returning null.
33018 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33020 * typemanager.cs (InitCoreTypes): Initialize the various core
33021 types after we have populated the type manager with the user
33022 defined types (this distinction will be important later while
33023 compiling corlib.dll)
33025 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33026 on Expression Classification. Now all expressions have a method
33027 `Resolve' and a method `Emit'.
33029 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33030 generation from working. Also add some temporary debugging
33033 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33035 * codegen.cs: Lots of code generation pieces. This is only the
33036 beginning, will continue tomorrow with more touches of polish. We
33037 handle the fundamentals of if, while, do, for, return. Others are
33038 trickier and I need to start working on invocations soon.
33040 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33043 * codegen.cs (EmitContext): New struct, used during code
33044 emission to keep a context. Most of the code generation will be
33047 * cs-parser.jay: Add embedded blocks to the list of statements of
33048 this block. So code generation proceeds in a top down fashion.
33050 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33052 * statement.cs: Add support for multiple child blocks.
33054 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33056 * codegen.cs (EmitCode): New function, will emit the code for a
33057 Block of code given a TypeContainer and its ILGenerator.
33059 * statement.cs (Block): Standard public readonly optimization.
33060 (Block::Block constructors): Link children.
33061 (Block::Child): Child Linker.
33062 (Block::EmitVariables): Emits IL variable declarations.
33064 * class.cs: Drop support for MethodGroups here, delay until
33066 (Method::): Applied the same simplification that I did before, and
33067 move from Properties to public readonly fields.
33068 (Method::ParameterTypes): Returns the parameter types for the
33069 function, and implements a cache that will be useful later when I
33070 do error checking and the semantic analysis on the methods is
33072 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33073 and made a method, optional argument tells whether this is a class
33074 or a structure to apply the `has-this' bit.
33075 (Method::GetCallingConvention): Implement, returns the calling
33077 (Method::Define): Defines the type, a second pass is performed
33078 later to populate the methods.
33080 (Constructor::ParameterTypes): implement a cache similar to the
33081 one on Method::ParameterTypes, useful later when we do semantic
33084 (TypeContainer::EmitMethod): New method. Emits methods.
33086 * expression.cs: Removed MethodGroup class from here.
33088 * parameter.cs (Parameters::GetCallingConvention): new method.
33090 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33092 * class.cs (TypeContainer::Populate): Drop RootContext from the
33095 (Constructor::CallingConvention): Returns the calling convention.
33096 (Constructor::ParameterTypes): Returns the constructor parameter
33099 (TypeContainer::AddConstructor): Keep track of default constructor
33100 and the default static constructor.
33102 (Constructor::) Another class that starts using `public readonly'
33103 instead of properties.
33105 (Constructor::IsDefault): Whether this is a default constructor.
33107 (Field::) use readonly public fields instead of properties also.
33109 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33110 track of static constructors; If none is used, turn on
33111 BeforeFieldInit in the TypeAttributes.
33113 * cs-parser.jay (opt_argument_list): now the return can be null
33114 for the cases where there are no arguments.
33116 (constructor_declarator): If there is no implicit `base' or
33117 `this', then invoke the default parent constructor.
33119 * modifiers.cs (MethodAttr): New static function maps a set of
33120 modifiers flags into a MethodAttributes enum
33121 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33122 MethodAttr, TypeAttr to represent the various mappings where the
33123 modifiers are used.
33124 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33126 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33128 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33131 * interface.cs (PopulateIndexer): Implemented the code generator
33132 for interface indexers.
33134 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33136 * interface.cs (InterfaceMemberBase): Now we track the new status
33139 (PopulateProperty): Implement property population. Woohoo! Got
33140 Methods and Properties going today.
33142 Removed all the properties for interfaces, and replaced them with
33143 `public readonly' fields.
33145 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33147 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33148 initialize their hashtables/arraylists only when they are needed
33149 instead of doing this always.
33151 * parameter.cs: Handle refs and out parameters.
33153 * cs-parser.jay: Use an ArrayList to construct the arguments
33154 instead of the ParameterCollection, and then cast that to a
33157 * parameter.cs: Drop the use of ParameterCollection and use
33158 instead arrays of Parameters.
33160 (GetParameterInfo): Use the Type, not the Name when resolving
33163 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33165 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33166 and instead use public readonly fields.
33168 * class.cs: Put back walking code for type containers.
33170 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33172 * class.cs (MakeConstant): Code to define constants.
33174 * rootcontext.cs (LookupType): New function. Used to locate types
33177 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33179 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33180 this System.Reflection code is. Kudos to Microsoft
33182 * typemanager.cs: Implement a type cache and avoid loading all
33183 types at boot time. Wrap in LookupType the internals. This made
33184 the compiler so much faster. Wow. I rule!
33186 * driver.cs: Make sure we always load mscorlib first (for
33187 debugging purposes, nothing really important).
33189 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33190 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33192 * rootcontext.cs: Lookup types on their namespace; Lookup types
33193 on namespaces that have been imported using the `using' keyword.
33195 * class.cs (TypeContainer::TypeAttr): Virtualize.
33196 (Class::TypeAttr): Return attributes suitable for this bad boy.
33197 (Struct::TypeAttr): ditto.
33198 Handle nested classes.
33199 (TypeContainer::) Remove all the type visiting code, it is now
33200 replaced with the rootcontext.cs code
33202 * rootcontext.cs (GetClassBases): Added support for structs.
33204 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33206 * interface.cs, statement.cs, class.cs, parameter.cs,
33207 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33208 Drop use of TypeRefs, and use strings instead.
33210 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33214 * class.cs (Struct::Struct): set the SEALED flags after
33215 checking the modifiers.
33216 (TypeContainer::TypeAttr): new property, returns the
33217 TypeAttributes for a class.
33219 * cs-parser.jay (type_list): Oops, list production was creating a
33220 new list of base types.
33222 * rootcontext.cs (StdLib): New property.
33223 (GetInterfaceTypeByName): returns an interface by type name, and
33224 encapsulates error handling here.
33225 (GetInterfaces): simplified.
33226 (ResolveTree): Encapsulated all the tree resolution here.
33227 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33230 * driver.cs: Add support for --nostdlib, to avoid loading the
33231 default assemblies.
33232 (Main): Do not put tree resolution here.
33234 * rootcontext.cs: Beginning of the class resolution.
33236 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33238 * rootcontext.cs: Provide better error reporting.
33240 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33242 * rootcontext.cs (CreateInterface): Handle the case where there
33243 are no parent interfaces.
33245 (CloseTypes): Routine to flush types at the end.
33246 (CreateInterface): Track types.
33247 (GetInterfaces): Returns an array of Types from the list of
33248 defined interfaces.
33250 * typemanager.c (AddUserType): Mechanism to track user types (puts
33251 the type on the global type hash, and allows us to close it at the
33254 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33256 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33257 RecordInterface instead.
33259 * cs-parser.jay: Updated to reflect changes above.
33261 * decl.cs (Definition): Keep track of the TypeBuilder type that
33262 represents this type here. Not sure we will use it in the long
33263 run, but wont hurt for now.
33265 * driver.cs: Smaller changes to accomodate the new code.
33267 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33270 * rootcontext.cs (CreateInterface): New method, used to create
33271 the System.TypeBuilder type for interfaces.
33272 (ResolveInterfaces): new entry point to resolve the interface
33274 (CodeGen): Property, used to keep track of the code generator.
33276 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33278 * cs-parser.jay: Add a second production for delegate_declaration
33281 (enum_body): Put an opt_comma here instead of putting it on
33282 enum_body or enum_member_declarations so we can handle trailing
33283 commas on enumeration members. Gets rid of a shift/reduce.
33285 (type_list): Need a COMMA in the middle.
33287 (indexer_declaration): Tell tokenizer to recognize get/set
33289 * Remove old targets.
33291 * Re-add the parser target.
33293 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33295 * cs-parser.jay: Add precendence rules for a number of operators
33296 ot reduce the number of shift/reduce conflicts in the grammar.
33298 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33300 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33303 Get rid of old crufty code.
33305 * rootcontext.cs: Use this to keep track of the parsed
33306 representation and the defined types available to the program.
33308 * gen-treedump.cs: adjust for new convention.
33310 * type.cs: Split out the type manager, and the assembly builder
33313 * typemanager.cs: the type manager will live here now.
33315 * cil-codegen.cs: And the code generator here.
33317 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33319 * makefile: Fixed up for easy making.
33321 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33323 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33326 (unary_expression): Expand pre_increment_expression and
33327 post_decrement_expression to reduce a shift/reduce.
33329 2001-07-11 Simon Cozens
33331 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33333 Improve allow_keyword_as_indent name.
33335 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33337 * Adjustments for Beta2.
33339 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33341 * decl.cs: Added `Define' abstract method.
33342 (InTransit): new property, used to catch recursive definitions.
33344 * interface.cs: Implement `Define'.
33346 * modifiers.cs: Map Modifiers.constants to
33347 System.Reflection.TypeAttribute flags.
33349 * class.cs: Keep track of types and user-defined types.
33350 (BuilderInit): New method for creating an assembly
33351 (ResolveType): New function to launch the resolution process, only
33352 used by interfaces for now.
33354 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33355 that are inserted into the name space.
33357 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33359 * ARGH. I have screwed up my tree so many times due to the use of
33360 rsync rather than using CVS. Going to fix this at once.
33362 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33365 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33367 * Experiment successful: Use System.Type rather that our own
33370 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33372 * cs-parser.jay: Removed nsAliases from here.
33374 Use new namespaces, handle `using XXX;'
33376 * namespace.cs: Reimplemented namespace handling, use a recursive
33377 definition of the class. Now we can keep track of using clauses
33378 and catch invalid using clauses.
33380 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33382 * gen-treedump.cs: Adapted for all the renaming.
33384 * expression.cs (Expression): this class now has a Type property
33385 which returns an expression Type.
33387 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33388 `Type', as this has a different meaning now in the base
33390 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33392 * interface.cs, class.cs: Removed from all the sources the
33393 references to signature computation, as we can not do method
33394 signature computation during the parsing time, as we are not
33395 trying to solve at that point distinguishing:
33399 void a (NS.Blah x) {}
33402 Which depending on the context might be valid or not, as we do not
33403 know if Blah is the same thing as NS.Blah at that point.
33405 * Redid everything so the code uses TypeRefs now instead of
33406 Types. TypeRefs are just temporary type placeholders, that need
33407 to be resolved. They initially have a pointer to a string and the
33408 current scope in which they are used. This is used later by the
33409 compiler to resolve the reference to an actual Type.
33411 * DeclSpace is no longer a CIR.Type, and neither are
33412 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33413 are all DeclSpaces, but no Types.
33415 * type.cs (TypeRefManager): This implements the TypeRef manager,
33416 which keeps track of all the types that need to be resolved after
33417 the parsing has finished.
33419 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33421 * ARGH. We are going to have to store `foreach' as a class rather
33422 than resolving it, as we need to verify error 1579 after name
33423 resolution. *OR* we could keep a flag that says `This request to
33424 IEnumerator comes from a foreach statement' which we can then use
33425 to generate the error.
33427 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33429 * class.cs (TypeContainer.AddMethod): we now add methods to the
33430 MethodGroup instead of the method hashtable.
33432 * expression.cs: Add MethodGroup abstraction, which gets us one
33433 step closer to the specification in the way we handle method
33436 * cs-parser.jay (primary_expression): qualified_identifier now
33437 tried to match up an identifier to a local variable reference or
33438 to a parameter reference.
33440 current_local_parameters is now a parser global variable that
33441 points to the current parameters for the block, used during name
33444 (property_declaration): Now creates an implicit `value' argument to
33447 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33449 * parameter.cs: Do not use `param' arguments as part of the
33450 signature, per the spec.
33452 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33454 * decl.cs: Base class for classes, structs and interfaces. This
33455 is the "Declaration Space"
33457 * cs-parser.jay: Use CheckDef for checking declaration errors
33458 instead of having one on each function.
33460 * class.cs: Factor out some code for handling error handling in
33461 accordance to the "Declarations" section in the "Basic Concepts"
33462 chapter in the ECMA C# spec.
33464 * interface.cs: Make all interface member classes derive from
33465 InterfaceMemberBase.
33467 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33469 * Many things: all interfaces are parsed and generated in
33470 gen-treedump. Support for member variables, constructors,
33471 destructors, properties, constants is there.
33473 Beginning of the IL backend, but very little done, just there for
33476 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33478 * cs-parser.jay: Fix labeled statement.
33480 * cs-tokenizer.cs (escape): Escape " and ' always.
33481 ref_line, ref_name: keep track of the line/filename as instructed
33482 by #line by the compiler.
33485 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33487 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33488 to match the values in System.CodeDOM.
33490 Divid renamed to Divide.
33492 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33494 (Statements.set): remove.
33496 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33499 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33500 falseStatements always have valid values.
33502 * cs-parser.jay: Use System.CodeDOM now.