1 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
3 * driver.cs: Strip the path from the names of embedded resources. Fixes
6 2004-11-04 Raja R Harinath <rharinath@novell.com>
8 Fix error message regression: cs0104-2.cs.
9 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
10 (AliasEntry.Resolve): Update.
11 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
13 (RootContext.LookupType): Update.
15 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
17 * cs-parser.jay: Add support for handling accessor modifiers
18 * class: Add support port accessor modifiers and error checking,
19 define PropertyMethod.Define as virtual (not abstract anymore)
20 * ecore.cs: Add checking for proeprties access with access modifiers
21 * iterators.cs: Modify Accessor constructor call based in the modified
23 2004-11-02 Ben Maurer <bmaurer@ximian.com>
25 * expression.cs (StringConcat): Handle being called twice,
26 as when we have a concat in a field init with more than two
29 2004-11-02 Miguel de Icaza <miguel@ximian.com>
31 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
32 since it will not return correct data if people use this
33 unresolved in the presence of using statements (see test-313).
35 * class.cs (MethodData.Define): If we are an explicit interface
36 implementation, set the method name to the full name of the
37 interface plus the name of the method.
39 Notice that using the method.MethodName.GetFullName() does not
40 work, as it will only contain the name as declared on the source
41 file (it can be a shorthand in the presence of using statements)
42 and not the fully qualifed type name, for example:
46 class D : ICloneable {
47 object ICloneable.Clone () {
51 Would produce a method called `ICloneable.Clone' instead of
52 `System.ICloneable.Clone'.
54 * namespace.cs (Alias.Resolve): Use GetPartialName.
56 2004-11-01 Marek Safar <marek.safar@seznam.cz>
58 * cs-parser.jay: Add error 1055 report.
60 2004-11-01 Miguel de Icaza <miguel@ximian.com>
62 * assign.cs (Assign.DoResolve): Only do the transform of
63 assignment into a New if the types are compatible, if not, fall
64 through and let the implicit code deal with the errors and with
65 the necessary conversions.
67 2004-11-01 Marek Safar <marek.safar@seznam.cz>
69 * cs-parser.jay: Add error 1031 report.
71 * cs-tokenizer.cs: Add location for error 1038.
73 2004-10-31 Marek Safar <marek.safar@seznam.cz>
75 * cs-parser.jay: Add error 1016 report.
77 2004-10-31 Marek Safar <marek.safar@seznam.cz>
79 * cs-parser.jay: Add errors 1575,1611 report.
81 2004-10-31 Marek Safar <marek.safar@seznam.cz>
83 * cs-parser.jay: Add error 1001 report.
85 2004-10-31 Marek Safar <marek.safar@seznam.cz>
88 * attribute.cs (GetMarshal): Add method argument for
89 caller identification.
91 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
92 agument for GetMarshal and RuntimeMissingSupport.
94 2004-10-31 Marek Safar <marek.safar@seznam.cz>
96 * attribute.cs (ExtractSecurityPermissionSet): Removed
97 TypeManager.code_access_permission_type.
99 * typemanager.cs: Removed TypeManager.code_access_permission_type.
101 2004-10-27 Miguel de Icaza <miguel@ximian.com>
103 * expression.cs (LocalVariableReference.DoResolveLValue): Check
104 for obsolete use of a variable here. Fixes regression on errors
105 cs0619-25 and cs0619-26.
107 2004-10-27 Marek Safar <marek.safar@seznam.cz>
109 Fix #62358, implemented security attribute encoding.
111 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
112 Tests permitted SecurityAction for assembly or other types.
113 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
114 data from SecurityPermissionAttribute to PermisionSet class.
116 * class.cs (ApplyAttributeBuilder): Added special handling
117 for System.Security.Permissions.SecurityAttribute based types.
119 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
120 special handling for System.Security.Permissions.SecurityAttribute
123 * enum.cs (ApplyAttributeBuilder): Added special handling
124 for System.Security.Permissions.SecurityAttribute based types.
126 * parameter.cs (ApplyAttributeBuilder): Added special handling
127 for System.Security.Permissions.SecurityAttribute based types.
129 * rootcontext.cs: Next 2 core types.
131 * typemanager.cs (TypeManager.security_permission_attr_type):
132 Built in type for the SecurityPermission Attribute.
133 (code_access_permission_type): Build in type.
135 2004-10-17 Miguel de Icaza <miguel@ximian.com>
137 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
138 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
139 all of this information into
140 EmitContext.EmitCapturedVariableInstance.
142 * codegen.cs (EmitCapturedVariableInstance): move here the
143 funcionality of emitting an ldarg.0 in the presence of a
144 remapping. This centralizes the instance emit code.
146 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
147 then emit a load of this: it means that we have reached the
148 topmost ScopeInfo: the one that contains the pointer to the
149 instance of the class hosting the anonymous method.
151 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
152 captures to the topmost CaptureContext.
154 2004-10-12 Miguel de Icaza <miguel@ximian.com>
156 * expression.cs (LocalVariableReference): Move the knowledge about
157 the iterators into codegen's EmitCapturedVariableInstance.
159 2004-10-11 Miguel de Icaza <miguel@ximian.com>
161 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
162 all code paths return a value from an anonymous method (it is the
163 same as the 161 error, but for anonymous methods).
165 2004-10-08 Miguel de Icaza <miguel@ximian.com>
167 The introduction of anonymous methods in the compiler changed
168 various ways of doing things in the compiler. The most
169 significant one is the hard split between the resolution phase
170 and the emission phases of the compiler.
172 For instance, routines that referenced local variables no
173 longer can safely create temporary variables during the
174 resolution phase: they must do so from the emission phase,
175 since the variable might have been "captured", hence access to
176 it can not be done with the local-variable operations from the runtime.
180 (Block.Flags): New flag `IsTopLevel' to indicate that this block
183 (ToplevelBlock): A new kind of Block, these are the blocks that
184 are created by the parser for all toplevel method bodies. These
185 include methods, accessors and anonymous methods.
187 These contain some extra information not found in regular blocks:
188 A pointer to an optional CaptureContext (for tracking captured
189 local variables and parameters). A pointer to the parent
192 (Return.Resolve): Catch missmatches when returning a value from an
193 anonymous method (error 1662).
194 Invoke NeedReturnLabel from the Resolve phase instead of the emit
197 (Break.Resolve): ditto.
199 (SwitchLabel): instead of defining the labels during the
200 resolution phase, we now turned the public ILLabel and ILLabelCode
201 labels into methods called GetILLabelCode() and GetILLabel() that
202 only define the label during the Emit phase.
204 (GotoCase): Track the SwitchLabel instead of the computed label
205 (its contained therein). Emit the code by using
206 SwitchLabel.GetILLabelCode ().
208 (LocalInfo.Flags.Captured): A new flag has been introduce to track
209 whether the Local has been captured or not.
211 (LocalInfo.IsCaptured): New property, used to tell whether the
212 local has been captured.
214 * anonymous.cs: Vastly updated to contain the anonymous method
217 The main classes here are: CaptureContext which tracks any
218 captured information for a toplevel block and ScopeInfo used to
219 track the activation frames for various local variables.
221 Each toplevel block has an optional capture context associated
222 with it. When a method contains an anonymous method both the
223 toplevel method and the anonymous method will create a capture
224 context. When variables or parameters are captured, they are
225 recorded on the CaptureContext that owns them, for example:
229 MyDelegate d = delegate {
234 Here `a' will be recorded as captured on the toplevel
235 CapturedContext, the inner captured context will not have anything
236 (it will only have data if local variables or parameters from it
237 are captured in a nested anonymous method.
239 The ScopeInfo is used to track the activation frames for local
240 variables, for example:
242 for (int i = 0; i < 10; i++)
243 for (int j = 0; j < 10; j++){
244 MyDelegate d = delegate {
249 At runtime this captures a single captured variable `i', but it
250 captures 10 different versions of the variable `j'. The variable
251 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
254 The toplevel ScopeInfo will also track information like the `this'
255 pointer if instance variables were referenced (this is necessary
256 as the anonymous method lives inside a nested class in the host
259 (AnonymousMethod): Expanded to track the Toplevel, implement
260 `AnonymousMethod.Compatible' to tell whether an anonymous method
261 can be converted to a target delegate type.
263 The routine now also produces the anonymous method content
265 (AnonymousDelegate): A helper class that derives from
266 DelegateCreation, this is used to generate the code necessary to
267 produce the delegate for the anonymous method that was created.
269 * assign.cs: API adjustments for new changes in
270 Convert.ImplicitStandardConversionExists.
272 * class.cs: Adjustments to cope with the fact that now toplevel
273 blocks are of type `ToplevelBlock'.
275 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
276 insteda of standard blocks.
278 Flag errors if params arguments are passed to anonymous methods.
280 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
281 `CurrentAnonymousMethod' which points to the current Anonymous
282 Method. The variable points to the AnonymousMethod class that
283 holds the code being compiled. It is set in the new EmitContext
284 created for the anonymous method.
286 (EmitContext.Phase): Introduce a variable and an enumeration to
287 assist in enforcing some rules about when and where we are allowed
288 to invoke certain methods (EmitContext.NeedsReturnLabel is the
289 only one that enfonces this right now).
291 (EmitContext.HaveCaptureInfo): new helper method that returns
292 whether we have a CapturedContext initialized.
294 (EmitContext.CaptureVariable): New method used to register that a
295 LocalInfo must be flagged for capturing.
297 (EmitContext.CapturedParameter): New method used to register that a
298 parameters must be flagged for capturing.
300 (EmitContext.CapturedField): New method used to register that a
301 field must be flagged for capturing.
303 (EmitContext.HaveCapturedVariables,
304 EmitContext.HaveCapturedFields): Return whether there are captured
307 (EmitContext.EmitMethodHostInstance): This is used to emit the
308 instance for the anonymous method. The instance might be null
309 (static methods), this (for anonymous methods that capture nothing
310 and happen to live side-by-side with the current method body) or a
311 more complicated expression if the method has a CaptureContext.
313 (EmitContext.EmitTopBlock): Routine that drives the emission of
314 code: it will first resolve the top block, then emit any metadata
315 and then emit the code. The split is done so that we can extract
316 any anonymous methods and flag any captured variables/parameters.
318 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
319 during this phase, the ILGenerator should not be used as labels
320 and local variables declared here might not be accessible to any
321 code that is part of an anonymous method.
323 Exceptions to this include the temporary variables that are
324 created by some statements internally for holding temporary
327 (EmitContext.EmitMeta): New routine, in charge of emitting all the
330 (EmitContext.TemporaryReturn): This method is typically called
331 from the Emit phase, and its the only place where we allow the
332 ReturnLabel to be defined other than the EmitMeta. The reason is
333 that otherwise we would have to duplicate a lot of logic in the
334 Resolve phases of various methods that today is on the Emit
337 (EmitContext.NeedReturnLabel): This no longer creates the label,
338 as the ILGenerator is not valid during the resolve phase.
340 (EmitContext.EmitThis): Extended the knowledge in this class to
341 work in anonymous methods in addition to iterators.
343 (EmitContext.EmitCapturedVariableInstance): This emits whatever
344 code is necessary on the stack to access the instance to a local
345 variable (the variable will be accessed as a field).
347 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
348 EmitContext.EmitAddressOfParameter): Routines to support
349 parameters (not completed at this point).
351 Removals: Removed RemapLocal and RemapLocalLValue. We probably
352 will also remove the parameters.
354 * convert.cs (Convert): Define a `ConstantEC' which points to a
355 null. This is just to prefity some code that uses
356 ImplicitStandardConversion code and do not have an EmitContext
359 The idea is to flag explicitly that at that point in time, it is
360 known that the conversion will not trigger the delegate checking
361 code in implicit conversions (which requires a valid
364 Everywhere: pass new EmitContext parameter since
365 ImplicitStandardConversionExists now requires it to check for
366 anonymous method conversions.
368 (Convert.ImplicitStandardConversionExists): If the type of an
369 expression is the anonymous_method_type, and the type is a
370 delegate, we invoke the AnonymousMethod.Compatible method to check
371 whether an implicit conversion is possible.
373 (Convert.ImplicitConversionStandard): Only do implicit method
374 group conversions if the language level is not ISO_1.
376 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
377 MethodInfo for the Invoke method. used by Delegate and
380 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
381 method conversions if the target type is a delegate.
383 Removed extra debugging nops.
385 (LocalVariableReference): Turn the `local_info' into a public
388 Add `prepared' field, the same hack used for FieldExprs to cope
389 with composed assignments, as Local variables do not necessarily
390 operate purely on the stack as they used to: they can be captured
393 Add `temp' for a temporary result, like fields.
395 Refactor DoResolve and DoResolveLValue into DoResolveBase.
397 It now copes with Local variables that are captured and emits the
398 proper instance variable to load it from a field in the captured
401 (ParameterReference.DoResolveBase): During the resolve phase,
402 capture parameters if we are in an anonymous method.
404 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
405 anonymous method, use the EmitContext helper routines to emit the
408 * iterators.cs: Set RemapToProxy to true/false during the
411 * parameters.cs (GetParameterByName): New helper method.
413 * typemanager.cs (anonymous_method_type) a new type that
414 represents an anonyous method. This is always an internal type,
415 used as a fencepost to test against the anonymous-methodness of an
418 2004-10-24 Marek Safar <marek.safar@seznam.cz>
420 Fixed bugs #63705, #67130
421 * decl.cs (MemberCache.MemberCache): Add parameter to distinguish
422 imported and defined interfaces.
423 (CacheEntry, EntryType): Changed to protected internal.
425 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
428 * typemanager.cs (LookupInterfaceContainer): New method.
429 Fills member container from base interfaces.
431 2004-10-20 Marek Safar <marek.safar@seznam.cz>
433 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
435 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
437 2004-10-18 Martin Baulig <martin@ximian.com>
439 Merged latest changes into gmcs. Please keep this comment in
440 here, it makes it easier for me to see what changed in MCS since
441 the last time I merged.
443 2004-10-18 Martin Baulig <martin@ximian.com>
445 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
446 `Type' directly, but call ResolveType() on it.
447 (Catch.Resolve): Likewise.
448 (Foreach.Resolve): Likewise.
450 2004-10-18 Martin Baulig <martin@ximian.com>
452 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
453 `Type' directly, but call ResolveType() on it.
454 (Probe.DoResolve): Likewise.
455 (ArrayCreation.LookupType): Likewise.
456 (TypeOf.DoResolve): Likewise.
457 (SizeOf.DoResolve): Likewise.
459 2004-10-18 Martin Baulig <martin@ximian.com>
461 * expression.cs (Invocation.BetterFunction): Put back
462 TypeManager.TypeToCoreType().
464 2004-10-18 Raja R Harinath <rharinath@novell.com>
466 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
469 2004-10-18 Martin Baulig <martin@ximian.com>
471 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
472 `Type' directly, but call ResolveType() on it.
474 2004-10-18 Martin Baulig <martin@ximian.com>
476 * class.cs (FieldMember.Define): Don't access the TypeExpr's
477 `Type' directly, but call ResolveType() on it.
478 (MemberBase.DoDefine): Likewise.
480 * expression.cs (New.DoResolve): Don't access the TypeExpr's
481 `Type' directly, but call ResolveType() on it.
482 (ComposedCast.DoResolveAsTypeStep): Likewise.
484 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
485 `Type' directly, but call ResolveType() on it.
487 2004-10-17 John Luke <john.luke@gmail.com>
489 * class.cs (Operator.GetSignatureForError): use CSharpName
491 * parameter.cs (Parameter.GetSignatureForError): Returns
492 correct name even if was not defined.
494 2004-10-13 Raja R Harinath <rharinath@novell.com>
497 * class.cs (TypeContainer.EmitContext): New property.
498 (DefineNestedTypes): Create an emitcontext for each part.
499 (MethodCore.DoDefineParameters): Use container's emitcontext.
500 Pass type array to InternalParameters.
501 (MemberBase.DoDefine): Use container's emitcontext.
502 (FieldMember.Define): Likewise.
503 (Event.Define): Likewise.
504 (SetMethod.GetParameterInfo): Change argument to EmitContext.
505 Pass type array to InternalParameters.
506 (SetIndexerMethod.GetParameterInfo): Likewise.
507 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
508 * delegate.cs (Define): Pass emitcontext to
509 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
510 array to InternalParameters.
511 * expression.cs (ParameterReference.DoResolveBase): Pass
512 emitcontext to GetParameterInfo.
513 (ComposedCast.DoResolveAsTypeStep): Remove check on
514 ec.ResolvingTypeTree.
515 * parameter.cs (Parameter.Resolve): Change argument to
516 EmitContext. Use ResolveAsTypeTerminal.
517 (Parameter.GetSignature): Change argument to EmitContext.
518 (Parameters.ComputeSignature): Likewise.
519 (Parameters.ComputeParameterTypes): Likewise.
520 (Parameters.GetParameterInfo): Likewise.
521 (Parameters.ComputeAndDefineParameterTypes): Likewise.
522 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
523 * support.cs (InternalParameters..ctor): Remove variant that takes
525 * typemanager.cs (system_intptr_expr): New.
526 (InitExpressionTypes): Initialize it.
528 2004-10-12 Chris Toshok <toshok@ximian.com>
530 * cs-parser.jay: fix location for try_statement and catch_clause.
532 2004-10-11 Martin Baulig <martin@ximian.com>
534 * report.cs: Don't make --fatal abort on warnings, we have
535 -warnaserror for that.
537 2004-10-07 Raja R Harinath <rharinath@novell.com>
539 More DeclSpace.ResolveType avoidance.
540 * decl.cs (MemberCore.InUnsafe): New property.
541 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
542 with newly created EmitContext.
543 (FieldMember.Define): Likewise.
544 * delegate.cs (Delegate.Define): Likewise.
545 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
546 only if normal name-lookup fails.
547 (TypeExpr.DoResolve): Enable error-checking.
548 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
549 (SizeOf.DoResolve): Likewise.
550 (ComposedCast.DoResolveAsTypeStep): Likewise.
551 (StackAlloc.DoResolve): Likewise.
552 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
553 (Block.Unsafe): New property.
554 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
555 (Unsafe): Set 'unsafe' flag of contained block.
556 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
557 (Fixed.Resolve): Likewise.
558 (Catch.Resolve): Likewise.
559 (Using.ResolveLocalVariableDecls): Likewise.
560 (Foreach.Resolve): Likewise.
562 2004-10-05 John Luke <john.luke@gmail.com>
564 * cs-parser.jay: add location to error CS0175
566 2004-10-04 Miguel de Icaza <miguel@ximian.com>
568 * ecore.cs (Expression.Constantity): Add support for turning null
571 * const.cs (Const.Define): Allow constants to be reference types
572 as long as the value is Null.
574 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
576 * namespace.cs (NamespaceEntry.Using): No matter which warning
577 level is set, check if this namespace name has already been added.
579 2004-10-03 Ben Maurer <bmaurer@ximian.com>
581 * expression.cs: reftype [!=]= null should always use br[true,false].
584 2004-10-03 Marek Safar <marek.safar@seznam.cz>
587 * attribute.cs: Enum conversion moved to
588 GetAttributeArgumentExpression to be applied to the all
591 2004-10-01 Raja R Harinath <rharinath@novell.com>
593 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
594 * class.c (TypeContainer.DefineType): Flag error if
595 base types aren't accessible due to access permissions.
596 * decl.cs (DeclSpace.ResolveType): Move logic to
597 Expression.ResolveAsTypeTerminal.
598 (DeclSpace.ResolveTypeExpr): Thin layer over
599 Expression.ResolveAsTypeTerminal.
600 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
601 Refactor code into NestedAccess. Use it.
602 (DeclSpace.NestedAccess): New.
603 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
604 argument to silence errors. Check access permissions.
605 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
606 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
607 (Cast.DoResolve): Likewise.
608 (New.DoResolve): Likewise.
609 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
610 (TypeOf.DoResolve): Likewise.
612 * expression.cs (Invocation.BetterConversion): Return the Type of
613 the better conversion. Implement section 14.4.2.3 more faithfully.
614 (Invocation.BetterFunction): Make boolean. Make correspondence to
615 section 14.4.2.2 explicit.
616 (Invocation.OverloadResolve): Update.
617 (Invocation): Remove is_base field.
618 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
619 (Invocation.Emit): Likewise.
621 2004-09-27 Raja R Harinath <rharinath@novell.com>
623 * README: Update to changes.
625 2004-09-24 Marek Safar <marek.safar@seznam.cz>
627 * cs-parser.jay: Reverted 642 warning fix.
629 2004-09-23 Marek Safar <marek.safar@seznam.cz>
632 * decl.cs (FindMemberWithSameName): Indexer can have more than
635 2004-09-23 Marek Safar <marek.safar@seznam.cz>
637 * expression.cs (LocalVariableReference.DoResolveLValue):
638 Do not report warning 219 for out values.
639 (EmptyExpression.Null): New member to avoid extra allocations.
641 2004-09-23 Marek Safar <marek.safar@seznam.cz>
643 * cs-parser.jay: Fix wrong warning 642 report.
645 * cs-tokenizer.cs (CheckNextToken): New helper;
646 Inspect next character if is same as expected.
648 2004-09-23 Martin Baulig <martin@ximian.com>
650 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
651 (Convert.ImplicitReferenceConversionExists): Likewise.
653 2004-09-23 Marek Safar <marek.safar@seznam.cz>
655 * class.cs (Operator.Define): Add error 448 and 559 report.
657 2004-09-22 Marek Safar <marek.safar@seznam.cz>
659 * class.cs (MemberBase.IsTypePermitted): New protected
660 method for checking error CS0610.
662 2004-09-22 Marek Safar <marek.safar@seznam.cz>
664 * class.cs (TypeContainer.HasExplicitLayout): New property
665 Returns whether container has StructLayout attribute set Explicit.
666 (FieldMember): New abstract class for consts and fields.
667 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
668 (Field): Reuse FieldMember.
670 * const.cs (Const): Reuse FieldMember.
672 * rootcontext.cs: EmitConstants call moved to class.
674 2004-09-22 Martin Baulig <martin@ximian.com>
676 Thanks to Peter Sestoft for this bug report.
678 * expression.cs (Conditional): If both the `trueExpr' and the
679 `falseExpr' is a NullLiteral, return a NullLiteral.
681 2004-09-22 Martin Baulig <martin@ximian.com>
683 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
684 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
685 for the "get_Current" call.
687 2004-09-22 Martin Baulig <martin@ximian.com>
689 Marek and me just fixed one of our oldest bugs: #28562 :-)
691 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
693 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
694 we're an EnumConstant, just return that.
695 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
696 an EnumConstant. In this case, we need to use GetValueAsEnumType()
697 to get the value which'll actually be written into the attribute.
698 However, we have to use GetValue() to access the attribute's value
701 2004-09-22 Marek Safar <marek.safar@seznam.cz>
703 * constant.cs (Constant.IsNegative): New abstract property
706 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
707 (StackAlloc.DoResolve): Reused IsNegative.
709 2004-09-21 Martin Baulig <martin@ximian.com>
711 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
712 if we're used in an iterator, we may be called from different
715 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
716 we actually have an exception block.
718 2004-09-20 John Luke <jluke@cfl.rr.com>
720 * class.cs, cs-parser.jay: Improve the error report for 1520:
721 report the actual line where the error happens, not where the
724 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
725 Pass location information that was available elsewhere.
727 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
729 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
730 runtime to delay sign assemblies.
732 2004-09-19 Miguel de Icaza <miguel@ximian.com>
734 * cs-parser.jay: Do not report the stack trace, this is barely
737 2004-08-22 John Luke <john.luke@gmail.com>
739 * driver.cs : check that a resource id is not already used
740 before adding it, report CS1508 if it is, bug #63637
742 2004-09-19 Miguel de Icaza <miguel@ximian.com>
744 * ecore.cs: Removed dead code.
746 2004-09-18 Marek Safar <marek.safar@seznam.cz>
748 * class.cs: Do not report warning CS0067 on the interfaces.
750 2004-09-16 Marek Safar <marek.safar@seznam.cz>
752 * cs-parser.jay: Add error 504 report.
754 2004-09-16 Marek Safar <marek.safar@seznam.cz>
756 * rootcontext.cs: WarningLevel is 4 by default now.
758 * statement.cs (Fixed.Resolve): Do not null
761 2004-09-16 Marek Safar <marek.safar@seznam.cz>
764 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
765 deep search when property is not virtual.
766 (PropertyExpr.ResolveAccessors): Make one call for both
769 2004-09-15 Marek Safar <marek.safar@seznam.cz>
772 * statement.cs: Error 152 report constains also location.
774 2004-09-15 Marek Safar <marek.safar@seznam.cz>
777 * const.cs: Explicitly set constant as static.
779 2004-09-15 Marek Safar <marek.safar@seznam.cz>
782 * cs-parser.jay: Add error 1017 report.
784 2004-09-15 Marek Safar <marek.safar@seznam.cz>
786 Fixed bug #59980, #64224
787 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
789 * typemanager.cs (IsSpecialMethod): Simplified
791 2004-09-14 Marek Safar <marek.safar@seznam.cz>
793 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
794 condition with better params.
796 2004-09-14 Marek Safar <marek.safar@seznam.cz>
799 * attribute.cs (Resolve): Property has to have both
802 2004-09-14 Martin Baulig <martin@ximian.com>
804 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
806 2004-09-14 Marek Safar <marek.safar@seznam.cz>
809 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
810 called and is obsolete then this member suppress message
811 when call is inside next [Obsolete] method or type.
813 * expression.cs: Use TestObsoleteMethodUsage member.
815 2004-09-14 Martin Baulig <martin@ximian.com>
817 * cs-parser.jay: Sync a bit with the GMCS version.
819 2004-09-14 Martin Baulig <martin@ximian.com>
821 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
822 (CSharpParser.yacc_verbose_flag): New public field.
824 * genericparser.cs: Removed.
826 2004-09-14 Raja R Harinath <rharinath@novell.com>
828 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
830 2004-09-13 Marek Safar <marek.safar@seznam.cz>
832 * class.cs (MethodCore.CheckBase): Fix bug #65757.
834 2004-09-10 Martin Baulig <martin@ximian.com>
836 Backported my MemberName changes from GMCS into MCS.
838 - we are now using a special `MemberName' class instead of using
839 strings; in GMCS, the `MemberName' also contains the type
842 - changed the grammar rules a bit:
843 * the old `member_name' is now a `namespace_or_type_name':
844 The rule is that we use `namespace_or_type_name' everywhere
845 where we expect either a "member name" (GetEnumerator) or a
846 "member name" with an explicit interface name
847 (IEnumerable.GetEnumerator).
848 In GMCS, the explicit interface name may include type arguments
849 (IEnumerable<T>.GetEnumerator).
850 * we use `member_name' instead of just `IDENTIFIER' for
852 The rule is that we use `member_name' wherever a member may
853 have type parameters in GMCS.
855 * decl.cs (MemberName): New public class.
856 (MemberCore.MemberName): New public readonly field.
857 (MemberCore.ctor): Take a `MemberName' argument, not a string.
858 (DeclSpace): Likewise.
860 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
861 * enum.cs (Enum.ctor): Likewise.
863 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
865 (AliasEntry.ctor): Take a MemberName, not an Expression.
866 (AliasEntry.UsingAlias): Likewise.
868 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
869 (IMethodData.MemberName): Changed type from string to MemberName.
870 (MemberBase.ExplicitInterfaceName): Likewise.
871 (AbstractPropertyEventMethod.SetupName): Make this private.
872 (AbstractPropertyEventMethod.ctor): Added `string prefix'
873 argument; compute the member name here.
874 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
875 on the `member.MemberName' and the `prefix'.
877 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
879 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
880 thus, we get a `MemberName' instead of a `string'. These
881 declarations may have type parameters in GMCS.
882 (interface_method_declaration, delegate_declaration): Likewise.
883 (class_declaration, interface_declaration): Likewise.
884 (method_header): Use `namespace_or_type_name' instead of
885 `member_name'. We may be an explicit interface implementation.
886 (property_declaration, event_declaration): Likewise.
887 (member_name): This is now just an `IDENTIFIER', not a
888 `namespace_or_type_name'.
889 (type_name, interface_type): Removed.
890 (namespace_or_type_name): Return a MemberName, not an Expression.
891 (primary_expression): Use `member_name' instead of `IDENTIFIER';
892 call GetTypeExpression() on the MemberName to get an expression.
893 (IndexerDeclaration.interface_type): Changed type from string to
895 (MakeName): Operate on MemberName's instead of string's.
897 2004-09-13 Raja R Harinath <rharinath@novell.com>
900 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
901 (NamespaceEntry.Lookup): Add new argument to flag if we want the
902 lookup to avoid symbols introduced by 'using'.
903 * rootcontext.cs (NamespaceLookup): Update.
905 2004-09-12 Marek Safar <marek.safar@seznam.cz>
907 * class.cs (TypeContainer.DoDefineMembers): Do not call
908 DefineDefaultConstructor for static classes.
910 2004-09-12 Marek Safar <marek.safar@seznam.cz>
912 * attribute.cs (Attribute.Resolve): Add error 653 report.
914 * class.cs (Class.ApplyAttributeBuilder): Add error 641
916 (Method.ApplyAttributeBuilder): Add error 685 report.
917 (Operator.Define): Add error 564 report.
919 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
921 * expression.cs (Invocation.DoResolve): Add error
924 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
927 2004-09-11 Marek Safar <marek.safar@seznam.cz>
929 * class.cs (ConstructorInitializer.Resolve):
930 Wrong error number (515->516).
932 2004-09-11 Marek Safar <marek.safar@seznam.cz>
934 * class.cs (Indexer.Define): Add error 631 report.
936 2004-09-11 Marek Safar <marek.safar@seznam.cz>
938 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
940 2004-09-11 Marek Safar <marek.safar@seznam.cz>
942 * expression.cs (Probe.DoResolve): Add error CS0241 report.
944 2004-09-10 Marek Safar <marek.safar@seznam.cz>
946 * cs-parser.jay: Added error CS0241 report.
948 2004-09-10 Raja R Harinath <rharinath@novell.com>
950 * cs-parser.jay (fixed_statement): Introduce a scope for the
951 declaration in the 'fixed' statement.
953 2004-09-09 Marek Safar <marek.safar@seznam.cz>
955 * cs-parser.jay: Added CS0230 error report.
957 2004-09-09 Marek Safar <marek.safar@seznam.cz>
959 * cs-parser.jay: Added errors CS0231 and CS0257 report.
961 2004-09-09 Marek Safar <marek.safar@seznam.cz>
963 * expression.cs (Argument.Resolve): Added error CS0192 and
966 2004-09-09 Marek Safar <marek.safar@seznam.cz>
968 C# 2.0 #pragma warning feature
970 * cs-tokenizer.cs (PreProcessPragma): New method;
971 Handles #pragma directive.
973 * report.cs (WarningRegions): New class; Support
974 class for #pragma warning directive. It tests whether
975 warning is enabled for a given line.
977 2004-09-08 Miguel de Icaza <miguel@ximian.com>
979 * const.cs: Add more descriptive error report, tahnks to
982 2004-09-08 Marek Safar <marek.safar@seznam.cz>
984 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
986 2004-09-07 Miguel de Icaza <miguel@ximian.com>
988 * expression.cs: Apply patch from Ben: Remove dead code from
989 ArrayCreation, and remove the TurnintoConstant call in const.cs,
990 as that code just threw an exception anwyays.
992 * const.cs: Remove the call to the turnintoconstant, for details
995 * literal.cs: The type of the null-literal is the null type; So
996 we use a placeholder type (literal.cs:System.Null, defined here)
999 * expression.cs (Conditional.DoResolve): Remove some old code that
1000 is no longer needed, conversions have been fixed.
1002 (ArrayCreationExpression.DoResolve): Return false if we fail to
1003 resolve the inner expression.
1005 2004-09-07 Raja R Harinath <rharinath@novell.com>
1008 * cs-parser.jay (delegate_declaration): Record a delegate
1009 declaration as a type declaration.
1010 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1012 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1014 * parameter.cs: Do not crash if the type can not be resolved.
1016 * expression.cs: Report errors with unsafe pointers, fixes #64896
1018 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1020 * expression.cs: Pointer arith always needs to do a conv.i
1021 if the operand is a long. fix 65320
1023 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1025 Fixed cs0619-37.cs, cs0619-38.cs
1027 * enum.cs (GetObsoleteAttribute): Removed.
1029 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1030 on Enum member is double staged. The first is tested member
1033 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1035 Fixed #56986, #63631, #65231
1037 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1038 adds member to name container.
1039 (TypeContainer.AddToTypeContainer): New method, adds type to
1041 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1042 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1043 AddOperator): Simplified by reusing AddToMemberContainer.
1044 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1046 (Method.CheckForDuplications): Fixed implementation to test all
1048 (MemberBase): Detection whether member is explicit interface
1049 implementation is now in constructor.
1050 (MemberBase.UpdateMemberName): Handles IndexerName.
1051 (Accessor): Changed to keep also location information.
1052 (AbstractPropertyEventMethod): Is derived from MemberCore.
1053 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1054 will be emited or not.
1055 (PropertyBase.AreAccessorsDuplicateImplementation):
1056 Tests whether accessors are not in collision with some method.
1057 (Operator): Is derived from MethodCore to simplify common
1060 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1062 (DeclSpace.AddToContainer): Adds the member to defined_names
1063 table. It tests for duplications and enclosing name conflicts.
1065 * enum.cs (EnumMember): Clean up to reuse the base structures
1067 2004-09-03 Martin Baulig <martin@ximian.com>
1069 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1070 into TypeContainer, to make partial classes work again.
1072 2004-09-03 Martin Baulig <martin@ximian.com>
1074 * rootcontext.cs (RootContext.V2): Removed.
1076 2004-03-23 Martin Baulig <martin@ximian.com>
1078 * expression.cs (Invocation.OverloadResolve): Added `bool
1079 may_fail' argument and use it instead of the Location.IsNull() hack.
1081 2004-09-03 Martin Baulig <martin@ximian.com>
1083 Merged latest changes into gmcs. Please keep this comment in
1084 here, it makes it easier for me to see what changed in MCS since
1085 the last time I merged.
1087 2004-09-03 Raja R Harinath <rharinath@novell.com>
1090 * expression.cs (BetterConversion): Don't allow either conversion
1091 to be null. Remove redundant implicit conversion test when 'q ==
1092 null' -- when this function is invoked, we already know that the
1093 implicit conversion exists.
1094 (BetterFunction): Assume that 'best' is non-null. Remove
1095 redundant reimplementation of IsApplicable when 'best' is null.
1096 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1097 number of arguments.
1098 (IsAncestralType): Extract from OverloadResolve.
1099 (OverloadResolve): Make robust to the MethodGroupExpr being
1100 unsorted. Implement all the logic of Section 14.5.5.1, and
1101 support overloading of methods from multiple applicable types.
1102 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1104 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1105 (RealError, Warning): Append type of report to related symbol.
1107 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1109 * enum.cs: Fixed CLS-Compliance checks for enum members.
1110 Error tests cs3008-8.cs, cs3014-8.cs
1112 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1114 Fixed bug #62342, #63102
1115 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1116 like ImplementMethod.
1118 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1120 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1123 2004-09-02 Martin Baulig <martin@ximian.com>
1125 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1126 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1129 2004-09-01 Marek Safar <marek.safar@seznam.cz>
1131 C# 2.0 Static classes implemented
1133 * class.cs (TypeContainer): instance_constructors,
1134 initialized_fields, initialized_static_fields,
1135 default_constructor, base_inteface_types are protected to be
1136 accessible from StaticClass.
1137 (TypeContainer.DefineDefaultConstructor): New virtual method
1138 for custom default constructor generating
1139 (StaticClass): New class to handle "Static classes" feature.
1141 * cs-parser.jay: Handle static keyword on class like instance
1144 * driver.cs: Added "/langversion" command line switch with two
1145 options (iso-1, default).
1147 2004-08-31 Marek Safar <marek.safar@seznam.cz>
1149 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
1151 2004-08-31 Miguel de Icaza <miguel@ximian.com>
1153 * delegate.cs: Style.
1155 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
1157 * delegate.cs: Add seperate instance expr field for miguel.
1159 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1161 * PointerArithmetic (Resolve): make sure we are not doing
1162 pointer arith on void*. Also, make sure we are resolved
1163 by not setting eclass until resolve.
1165 All callers: Make sure that PointerArithmetic gets resolved.
1167 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1169 * ArrayCreation (LookupType): If the type does not resolve
1170 to an array, give an error.
1172 2004-08-27 Marek Safar <marek.safar@seznam.cz>
1174 * statement.cs (Try.Resolve): Fixed bug #64222
1176 2004-08-27 Martin Baulig <martin@ximian.com>
1179 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1182 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1184 * ecore.cs (Constantify): Get underlying type via
1185 System.Enum.GetUnderlyingType to avoid StackOverflow on the
1186 Windows in special cases.
1188 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1190 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
1191 for obtaining also private methods.
1192 (GetRemoveMethod): Used GetRemoveMethod (true)
1193 for obtaining also private methods.
1195 2004-08-24 Martin Baulig <martin@ximian.com>
1197 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
1198 MethodAttributes.HideBySig for operators.
1200 2004-08-23 Martin Baulig <martin@ximian.com>
1202 Back to the old error reporting system :-)
1204 * report.cs (Message): Removed.
1205 (Report.MessageData, ErrorData, WarningData): Removed.
1206 (Report.Error, Warning): Back to the old system.
1208 2004-08-23 Martin Baulig <martin@ximian.com>
1210 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
1212 * class.cs (TypeContainer.ParentContainer): New public virtual
1213 method; replaces the explicit interface implementation.
1214 (ClassPart.ParentContainer): Override.
1216 2004-08-23 Martin Baulig <martin@ximian.com>
1218 * statement.cs (Switch): Added support for constant switches; see
1219 #59428 or test-285.cs.
1221 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1224 * statement.cs (GetEnumeratorFilter): Removed useless
1225 logic because C# specs is strict. GetEnumerator must be
1228 2004-08-22 Martin Baulig <martin@ximian.com>
1230 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1231 a switch and may break, reset the barrier. Fixes #59867.
1233 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1235 CLS-Compliance speed up (~5% for corlib)
1237 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
1238 New method. Tests container for CLS-Compliant names
1240 * class.cs (TypeContainer.VerifyClsName): New method.
1241 Checks whether container name is CLS Compliant.
1242 (Constructor): Implements IMethodData.
1244 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
1245 low-case table for CLS Compliance test.
1246 (MemberCache.VerifyClsParameterConflict): New method.
1247 Checks method parameters for CS3006 error.
1249 * enum.cs (EnumMember): Is derived from MemberCore.
1250 (Enum.VerifyClsName): Optimized for better performance.
1252 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1254 * report.cs: Renamed Error_T to Error and changed all
1257 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1259 * class.cs (TypeContainer.IndexerArrayList): New inner class
1260 container for indexers.
1261 (TypeContainer.DefaultIndexerName): New constant for default
1262 indexer name. Replaced all "Item" with this constant.
1263 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
1265 * typemanager.cs (TypeManager.default_member_ctor): Cache here
1266 DefaultMemberAttribute constructor.
1268 2004-08-05 Martin Baulig <martin@ximian.com>
1270 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
1273 2004-08-05 Marek Safar <marek.safar@seznam.cz>
1275 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
1276 multi platforms problem.
1278 * compiler.csproj: Included shared files.
1280 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1282 Fix bug 60333, 55971 in the more general way
1283 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1284 Added arg_type argument for constant conversion.
1285 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
1287 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1290 * class.cs (TypeContainer ): New inner classes MethodArrayList,
1291 OperatorArrayList, MethodCoreArrayList for typecontainer
1292 containers. Changed class member types to these new types.
1293 (MethodArrayList.DefineMembers): Added test for CS0659.
1295 2004-08-04 Miguel de Icaza <miguel@ximian.com>
1297 * cfold.cs: Synchronize the folding with the code in expression.cs
1298 Binary.DoNumericPromotions for uint operands.
1300 * attribute.cs: Revert patch from Raja, it introduced a regression
1301 while building Blam-1.2.1 (hard to isolate a test case).
1303 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1307 (TypeContainer.Define): Renamed to DefineContainerMembers because of
1309 (MethodCore.parent_method): New member. The method we're overriding
1310 if this is an override method.
1311 (MethodCore.CheckBase): Moved from Method class and made common.
1312 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
1314 (MethodCore.CheckForDuplications): New abstract method. For custom
1315 member duplication search in a container
1316 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
1317 method and its return type.
1318 (Event.conflict_symbol): New member. Symbol with same name in the
1322 (MemberCache.FindMemberWithSameName): New method. The method
1323 is looking for conflict with inherited symbols.
1325 2004-08-04 Martin Baulig <martin@ximian.com>
1327 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1329 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1331 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1333 * report.cs (Message): New enum for better error, warning reference in
1335 (MessageData): New inner abstract class. It generally handles printing of
1336 error and warning messages.
1337 Removed unused Error, Warning, Message methods.
1339 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1341 Fix for cs0592-8.cs test
1343 (Attributable.ValidAttributeTargets): Made public.
1344 (Attribute.ExplicitTarget): New member for explicit target value.
1345 (Attribute.CheckTargets): Now we translate explicit attribute
1346 target to Target here.
1348 2004-08-03 Ben Maurer <bmaurer@ximian.com>
1350 * ecore.cs (MethodGroupExpr): new IsBase property.
1352 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
1354 * delegate.cs (DelegateCreation): store a MethodGroupExpr
1355 rather than an instance expr.
1357 (DelegateCreation.Emit): Use the method group rather than
1358 the instance expression. Also, if you have base.Foo as the
1359 method for a delegate, make sure to emit ldftn, not ldftnvirt.
1361 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
1363 (NewDelegate.DoResolve): Only check for the existance of Invoke
1364 if the method is going to be needed. Use MethodGroupExpr.
1366 (NewDelegate.Emit): Remove, DelegateCreation implements this.
1368 * expression.cs: For pointer arith., make sure to use
1369 the size of the type, not the size of the pointer to
1372 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1375 * class.cs (Class): Added error CS0502 test.
1377 2004-08-03 John Luke <jluke@cfl.rr.com>
1378 Raja R Harinath <rharinath@novell.com>
1381 * attribute.cs (Attribute.complained_before): New flag.
1382 (Attribute.ResolveType, Attribute.Resolve),
1383 (Attribute.DefinePInvokeMethod): Set it.
1384 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
1386 2004-08-03 Martin Baulig <martin@ximian.com>
1388 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1389 use a user-defined operator; we still need to do numeric
1390 promotions in case one argument is a builtin type and the other
1391 one has an implicit conversion to that type. Fixes #62322.
1393 2004-08-02 Martin Baulig <martin@ximian.com>
1395 * statement.cs (LocalInfo.Flags): Added `IsThis'.
1396 (LocalInfo.IsThis): New public property.
1397 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
1399 2004-08-01 Martin Baulig <martin@ximian.com>
1401 * class.cs (TypeContainer.GetClassBases): Don't set the default
1402 here since we may get called from GetPartialBases().
1403 (TypeContainer.DefineType): If GetClassBases() didn't return a
1404 parent, use the default one.
1406 2004-07-30 Duncan Mak <duncan@ximian.com>
1408 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
1410 2004-07-30 Martin Baulig <martin@ximian.com>
1412 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
1414 * class.cs (SourceMethod): New public class, derive from the
1415 symbol writer's ISourceMethod.
1416 (Method): Use the new symbol writer API.
1418 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
1419 as argument and use the new symbol writer.
1422 (SourceFile): Implement the symbol writer's ISourceFile.
1423 (Location.SymbolDocument): Removed.
1424 (Location.SourceFile): New public property.
1426 * symbolwriter.cs: Use the new symbol writer API.
1428 2004-07-30 Raja R Harinath <rharinath@novell.com>
1430 * Makefile (install-local): Remove. Functionality moved to
1433 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
1435 * Makefile: Install mcs.exe.config file together with mcs.exe.
1436 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
1437 correct runtime version.
1439 2004-07-25 Martin Baulig <martin@ximian.com>
1442 (TypeContainer.RegisterOrder): Removed, this was unused.
1443 (TypeContainer, interface_order): Removed.
1444 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
1445 TypeContainer as argument since we can also be called with a
1446 `PartialContainer' for a partial class/struct/interface.
1447 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
1448 of checking whether we're an `Interface' - we could be a
1450 (PartialContainer.Register): Override; call
1451 AddClass()/AddStruct()/AddInterface() on our parent.
1453 * cs-parser.jay (interface_member_declaration): Add things to the
1454 `current_container', not the `current_class'.
1456 * rootcontext.cs (RegisterOrder): The overloaded version which
1457 takes an `Interface' was unused, removed.
1459 * typemanager.cs (TypeManager.LookupInterface): Return a
1460 `TypeContainer', not an `Interface'.
1461 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
1462 contain a `PartialContainer' for an interface, so check it's
1463 `Kind' to figure out what it is.
1465 2004-07-25 Martin Baulig <martin@ximian.com>
1467 * class.cs (Class.DefaultTypeAttributes): New public constant.
1468 (Struct.DefaultTypeAttributes): Likewise.
1469 (Interface.DefaultTypeAttributes): Likewise.
1470 (PartialContainer.TypeAttr): Override this and add the
1471 DefaultTypeAttributes.
1473 2004-07-25 Martin Baulig <martin@ximian.com>
1475 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
1476 we can just use the `Parent' field instead.
1478 2004-07-25 Martin Baulig <martin@ximian.com>
1480 * class.cs (TypeContainer.Emit): Renamed to EmitType().
1482 2004-07-25 Martin Baulig <martin@ximian.com>
1484 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
1485 our parts before defining any methods.
1486 (TypeContainer.VerifyImplements): Make this virtual.
1487 (ClassPart.VerifyImplements): Override and call VerifyImplements()
1488 on our PartialContainer.
1490 2004-07-25 Martin Baulig <martin@ximian.com>
1492 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
1494 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
1495 argument, we can just use the `Parent' field instead.
1498 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
1499 (MemberBase.DoDefine): Likewise.
1501 2004-07-24 Martin Baulig <martin@ximian.com>
1503 * decl.cs (MemberCore.Parent): New public field.
1504 (DeclSpace.Parent): Moved to MemberCore.
1506 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
1507 (MemberBase.ctor): Added TypeContainer argument, pass it to our
1509 (FieldBase, Field, Operator): Likewise.
1510 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
1511 (EventField, Event): Likewise.
1513 2004-07-23 Martin Baulig <martin@ximian.com>
1515 * class.cs (PartialContainer): New public class.
1516 (ClassPart): New public class.
1517 (TypeContainer): Added support for partial classes.
1518 (TypeContainer.GetClassBases): Splitted some of the functionality
1519 out into GetNormalBases() and GetPartialBases().
1521 * cs-tokenizer.cs (Token.PARTIAL): New token.
1522 (Tokenizer.consume_identifier): Added some hacks to recognize
1523 `partial', but only if it's immediately followed by `class',
1524 `struct' or `interface'.
1526 * cs-parser.jay: Added support for partial clases.
1528 2004-07-23 Martin Baulig <martin@ximian.com>
1530 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
1531 a `DeclSpace' and also made it readonly.
1532 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
1533 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
1534 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
1536 * cs-parser.jay: Pass the `current_class', not the
1537 `current_container' (at the moment, this is still the same thing)
1538 to a new Method, Property, Event, Indexer or Constructor.
1540 2004-07-23 Martin Baulig <martin@ximian.com>
1542 * cs-parser.jay (CSharpParser): Added a new `current_class' field
1543 and removed the `current_interface' one.
1544 (struct_declaration, class_declaration, interface_declaration):
1545 Set `current_class' to the newly created class/struct/interface;
1546 set their `Bases' and call Register() before parsing their body.
1548 2004-07-23 Martin Baulig <martin@ximian.com>
1550 * class.cs (Kind): New public enum.
1551 (TypeContainer): Made this class abstract.
1552 (TypeContainer.Kind): New public readonly field.
1553 (TypeContainer.CheckDef): New public method; moved here from
1555 (TypeContainer.Register): New public abstract method.
1556 (TypeContainer.GetPendingImplementations): New public abstract
1558 (TypeContainer.GetClassBases): Removed the `is_class' and
1559 `is_iface' parameters.
1560 (TypeContainer.DefineNestedTypes): Formerly known as
1562 (ClassOrStruct): Made this class abstract.
1564 * tree.cs (RootTypes): New public type.
1566 2004-07-20 Martin Baulig <martin@ximian.com>
1568 * tree.cs (Tree.RecordNamespace): Removed.
1569 (Tree.Namespaces): Removed.
1571 * rootcontext.cs (RootContext.IsNamespace): Removed.
1573 * cs-parser.jay (namespace_declaration): Just create a new
1574 NamespaceEntry here.
1576 2004-07-20 Martin Baulig <martin@ximian.com>
1578 * statement.cs (ExceptionStatement): New abstract class. This is
1579 now used as a base class for everyone who's using `finally'.
1580 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
1581 our local variables before using them.
1583 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
1584 virtual method. This is used by Yield.Resolve() to "steal" an
1585 outer block's `finally' clauses.
1586 (FlowBranchingException): The .ctor now takes an ExceptionStatement
1589 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
1590 version which takes an ExceptionStatement. This version must be
1591 used to create exception branchings.
1594 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
1595 (Iterator.EmitMoveNext): Added exception support; protect the
1596 block with a `fault' clause, properly handle 'finally' clauses.
1597 (Iterator.EmitDispose): Run all the `finally' clauses here.
1599 2004-07-20 Martin Baulig <martin@ximian.com>
1601 * iterator.cs: This is the first of a set of changes in the
1602 iterator code. Match the spec more closely: if we're an
1603 IEnumerable, then GetEnumerator() must be called. The first time
1604 GetEnumerator() is called, it returns the current instance; all
1605 subsequent invocations (if any) must create a copy.
1607 2004-07-19 Miguel de Icaza <miguel@ximian.com>
1609 * expression.cs: Resolve the constant expression before returning
1612 2004-07-19 Martin Baulig <martin@ximian.com>
1614 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
1615 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
1616 the return type of the new EmitContext.
1618 2004-07-18 Martin Baulig <martin@ximian.com>
1620 * class.cs (Property.Define): Fix iterators.
1622 * iterators.cs (Iterator.Define): Moved the
1623 `container.AddInterator (this)' call here from the .ctor; only do
1624 it if we resolved successfully.
1626 2004-07-17 Miguel de Icaza <miguel@ximian.com>
1628 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
1629 `true' for preprocessing directives that we parse. The return
1630 value indicates whether we should return to regular tokenizing or
1631 not, not whether it was parsed successfully.
1633 In the past if we were in: #if false ... #line #endif, we would
1634 resume parsing after `#line'. See bug 61604.
1636 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
1637 building: IsEnumType should return true only for enums, not for
1638 enums or System.Enum itself. This fixes #61593.
1640 Likely what happened is that corlib was wrong: mcs depended on
1641 this bug in some places. The bug got fixed, we had to add the
1642 hack, which caused bug 61593.
1644 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
1645 that was a workaround for the older conditions.
1647 2004-07-16 Ben Maurer <bmaurer@ximian.com>
1649 * assign.cs: IAssignMethod has a new interface, as documented
1650 inline. All assignment code now uses this new api.
1652 * ecore.cs, expression.cs: All classes which implement
1653 IAssignMethod now use the new interface.
1655 * expression.cs (Invocation): add a hack to EmitCall so that
1656 IndexerAccess can be the target of a compound assignment without
1657 evaluating its arguments twice.
1659 * statement.cs: Handle changes in Invocation api.
1661 2004-07-16 Martin Baulig <martin@ximian.com>
1663 * iterators.cs: Rewrote this. We're now using one single Proxy
1664 class for both the IEnumerable and the IEnumerator interface and
1665 `Iterator' derives from Class so we can use the high-level API.
1667 * class.cs (TypeContainer.AddIterator): New method.
1668 (TypeContainer.DoDefineType): New protected virtual method, which
1669 is called from DefineType().
1670 (TypeContainer.DoDefineMembers): Call DefineType() and
1671 DefineMembers() on all our iterators.
1672 (TypeContainer.Emit): Call Emit() on all our iterators.
1673 (TypeContainer.CloseType): Call CloseType() on all our iterators.
1675 * codegen.cs (EmitContext.CurrentIterator): New public field.
1677 2004-07-15 Martin Baulig <martin@ximian.com>
1680 (TypeManager.not_supported_exception_type): New type.
1682 2004-07-14 Martin Baulig <martin@ximian.com>
1684 * iterators.cs: Use real error numbers.
1686 2004-07-14 Martin Baulig <martin@ximian.com>
1688 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
1689 requires this to be a System.Collection.IEnumerable and not a
1690 class implementing that interface.
1691 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
1693 2004-07-13 Marek Safar <marek.safar@seznam.cz>
1695 * class.cs: Fixed previous fix, it broke some error tests.
1697 2004-07-12 Martin Baulig <martin@ximian.com>
1699 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
1702 2004-07-09 Miguel de Icaza <miguel@ximian.com>
1704 * assign.cs (LocalTemporary): Add new argument: is_address,If
1705 `is_address' is true, then the value that we store is the address
1706 to the real value, and not the value itself.
1708 * ecore.cs (PropertyExpr): use the new local temporary
1709 stuff to allow us to handle X.Y += z (where X is a struct)
1711 2004-07-08 Martin Baulig <martin@ximian.com>
1713 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
1714 not always return, just like we're doing in Using.Resolve().
1716 2004-07-07 Miguel de Icaza <miguel@ximian.com>
1718 * cs-parser.jay (fixed_statement): flag this as Pinned.
1720 2004-07-06 Miguel de Icaza <miguel@ximian.com>
1722 * typemanager.cs (TypeManager): Removed MakePinned method, this
1723 mechanism is replaced with the .NET 2.x compatible mechanism of
1724 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
1726 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
1727 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
1728 `IsFixed' property which has a different meaning.
1730 2004-07-02 Raja R Harinath <rharinath@novell.com>
1732 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
1733 visible from inside a nested class, not just the names of the
1734 immediately enclosing class.
1737 2004-06-24 Raja R Harinath <rharinath@novell.com>
1739 * expression.cs (BetterConversion): Remove buggy special-case
1740 handling of "implicit constant expression conversions". At this
1741 point, we already know that the conversion is possible -- we're
1742 only checking to see which is better.
1744 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1746 * cs-parser.jay: Added error CS0210 test.
1748 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1750 * cs-parser.jay: Added error CS0134 test.
1752 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1755 * cs-parser.jay: Added error CS0145 test.
1757 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1759 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
1761 2004-06-23 Ben Maurer <bmaurer@ximian.com>
1763 * expression.cs (StackAlloc.Resolve): The argument may not
1764 be a constant; deal with this case.
1766 2004-06-23 Marek Safar <marek.safar@seznam.cz>
1768 * attribute.cs (IndexerName_GetIndexerName): Renamed to
1769 GetIndexerAttributeValue.
1770 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
1772 * class.cs (Indexer.Define): Added error tests for CS0415,
1775 2004-06-23 Miguel de Icaza <miguel@ximian.com>
1777 * attribute.cs (Attribute.Resolve): Keep field code in sync with
1780 2004-06-23 Martin Baulig <martin@ximian.com>
1782 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
1783 neither return nor throw, reset the barrier as well. Fixes #60457.
1785 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
1787 * class.cs : EventAttributes is now set to None by default.
1788 This fixes bug #60459.
1790 2004-06-18 Marek Safar <marek.safar@seznam.cz>
1793 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
1794 Don't throw exception but return null (it's sufficient now).
1796 2004-06-18 Marek Safar <marek.safar@seznam.cz>
1798 * typemanager.cs (GetArgumentTypes): Faster implementation.
1800 2004-06-18 Martin Baulig <martin@ximian.com>
1802 * attribute.cs (Attribute.Resolve): Check whether we're an
1803 EmptyCast which a Constant child. Fixes #60333.
1805 2004-06-17 Ben Maurer <bmaurer@ximian.com>
1807 * statement.cs (EmitCollectionForeach): Account for the fact that
1808 not all valuetypes are in areas which we can take the address of.
1809 For these variables, we store to a temporary variable. Also, make
1810 sure that we dont emit a `callvirt' on a valuetype method.
1812 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1814 * expression.cs (StackAlloc.DoReSolve): Added test for
1815 negative parameter (CS0247).
1817 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1820 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
1822 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1825 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
1828 2004-06-14 Marek Safar <marek.safar@seznam.cz>
1830 Fix bug #58254 & cs1555.cs, cs1556.cs
1831 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
1833 2004-06-14 Marek Safar <marek.safar@seznam.cz>
1835 * cs-parser.jay: Added error CS1669 test for indexers.
1837 2004-06-11 Martin Baulig <martin@ximian.com>
1839 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
1840 call this twice: for params and varargs methods.
1842 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1845 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
1847 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1849 * attribute.cs (Attribute.GetValidTargets): Made public.
1852 (AbstractPropertyEventMethod): New class for better code sharing.
1853 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
1855 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
1857 2004-06-11 Raja R Harinath <rharinath@novell.com>
1860 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
1861 that the call to Resolve is part of a MemberAccess.
1862 (Expression.Resolve): Use it for SimpleName resolution.
1863 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
1864 Add 'intermediate' boolean argument.
1865 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
1866 error message when the SimpleName can be resolved ambiguously
1867 between an expression and a type.
1868 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
1870 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
1871 call on the left-side.
1873 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1876 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
1878 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1880 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
1882 2004-06-11 Martin Baulig <martin@ximian.com>
1884 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
1885 varargs methods if applicable.
1887 2004-06-11 Martin Baulig <martin@ximian.com>
1889 * expression.cs (Invocation.EmitCall): Don't use
1890 `method.CallingConvention == CallingConventions.VarArgs' since the
1891 method could also have `CallingConventions.HasThis'.
1893 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1895 * class.cs (Event.GetSignatureForError): Implemented.
1896 Fixed crash in error test cs3010.cs
1898 2004-06-10 Miguel de Icaza <miguel@ximian.com>
1900 * cs-tokenizer.cs: Change the way we track __arglist to be
1901 consistent with the other keywords.
1903 2004-06-09 Miguel de Icaza <miguel@ximian.com>
1905 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
1908 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
1910 * codegen.cs: Check that all referenced assemblies have a strongname
1911 before strongnaming the compiled assembly. If not report error CS1577.
1912 Fix bug #56563. Patch by Jackson Harper.
1913 * typemanager.cs: Added a method to return all referenced assemblies.
1914 Fix bug #56563. Patch by Jackson Harper.
1916 2004-06-08 Marek Safar <marek.safar@seznam.cz>
1919 (Method.ApplyAttributeBuilder): Moved and added conditional
1920 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
1923 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
1925 2004-06-08 Marek Safar <marek.safar@seznam.cz>
1928 * class.cs: (EventField.attribute_targets): Changed default target.
1930 2004-06-08 Martin Baulig <martin@ximian.com>
1932 * expression.cs (Invocation.EmitCall): Enable varargs methods.
1934 2004-06-08 Martin Baulig <martin@ximian.com>
1936 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
1938 2004-06-07 Martin Baulig <martin@ximian.com>
1940 Added support for varargs methods.
1942 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
1945 * cs-parser.jay: Added support for `__arglist'.
1947 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
1949 * expression.cs (Argument.AType): Added `ArgList'.
1950 (Invocation): Added support for varargs methods.
1951 (ArglistAccess): New public class.
1952 (Arglist): New public class.
1954 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
1956 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
1957 a method's top-level block if the method has varargs.
1959 * support.cs (ReflectionParameters, InternalParameters): Added
1960 support for varargs methods.
1962 2004-06-07 Miguel de Icaza <miguel@ximian.com>
1964 * class.cs: Provide location in indexer error report.
1966 * driver.cs: Use standard names.
1968 * namespace.cs: Catch the use of using after a namespace has been
1969 declared also on using aliases.
1971 2004-06-03 Raja R Harinath <rharinath@novell.com>
1974 * typemanager.cs (closure_private_ok, closure_invocation_type)
1975 (closure_qualifier_type, closure_invocation_assembly)
1976 (FilterWithClosure): Move to ...
1977 (Closure): New internal nested class.
1978 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
1979 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
1980 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
1981 (MemberLookup, MemberLookupFailed): Use it.
1982 * expression.cs (New.DoResolve): Treat the lookup for the
1983 constructor as being qualified by the 'new'ed type.
1984 (Indexers.GetIndexersForTypeOrInterface): Update.
1986 2004-06-03 Marek Safar <marek.safar@seznam.cz>
1989 (GetConditionalAttributeValue): New method. Returns
1990 condition of ConditionalAttribute.
1991 (SearchMulti): New method. Returns all attributes of type 't'.
1992 Use it when attribute is AllowMultiple = true.
1993 (IsConditionalMethodExcluded): New method.
1996 (Method.IsExcluded): Implemented. Returns true if method has conditional
1997 attribute and the conditions is not defined (method is excluded).
1998 (IMethodData): Extended interface for ConditionalAttribute support.
1999 (PropertyMethod.IsExcluded): Implemented.
2002 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
2005 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
2008 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
2010 * expression.cs (ArrayCreationExpression): Make this just an
2011 `expression'. It can't be a statement, so the code here was
2014 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2017 * typemanager.cs (GetFullNameSignature): New method for
2020 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2023 * class.cs (MemberBase.GetSignatureForError): New virtual method.
2024 Use this method when MethodBuilder is null.
2025 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
2026 Added test for error CS0626 (MONO reports error for this situation).
2027 (IMethodData.GetSignatureForError): Extended interface.
2029 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2032 (AttributeTester.GetObsoleteAttribute): Returns instance of
2033 ObsoleteAttribute when type is obsolete.
2036 (TypeContainer.VerifyObsoleteAttribute): Override.
2037 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2038 (MethodCode.VerifyObsoleteAttribute): Override.
2039 (MemberBase.VerifyObsoleteAttribute): Override.
2042 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2043 and report proper error.
2046 Delegate.VerifyObsoleteAttribute): Override.
2049 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2050 and report proper error.
2051 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2054 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2058 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2059 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2060 Added test for ObsoleteAttribute.
2063 (Catch): Derived from Statement.
2065 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2067 Fixed bug #59071 & cs0160.cs
2069 * statement.cs (Try.Resolve): Check here whether order of catch
2070 clauses matches their dependencies.
2072 2004-05-31 Miguel de Icaza <miguel@ximian.com>
2074 * Reverted patch to namespace.cs (Use lookuptypedirect). This
2075 caused a regression: #59343. Referencing nested classes from an
2076 assembly stopped working.
2078 2004-05-31 Martin Baulig <martin@ximian.com>
2080 MCS is now frozen for beta 2.
2082 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2084 * convert.cs: add a trivial cache for overload operator resolution.
2086 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2088 * decl.cs: If possible, use lookuptypedirect here. We can only do
2089 this if there is no `.' after the namespace. Avoids using
2090 LookupType, which does lots of slow processing.
2091 (FindNestedType) New method, does what it says :-).
2092 * namespace.cs: use LookupTypeDirect.
2093 * rootcontext.cs: use membercache, if possible.
2094 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2096 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2099 According to the spec,
2101 In a member access of the form E.I, if E is a single identifier,
2102 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2103 field, property, localvariable, or parameter with the same type as
2104 the meaning of E as a type-name (§3.8), then both possible
2105 meanings of E are permitted.
2107 We did not check that E as a simple-name had the same type as E as
2110 This trivial check gives us 5-7% on bootstrap time.
2112 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2114 * expression.cs (Invocation.OverloadResolve): Avoid the
2115 use of hashtables and boxing here by allocating on demand.
2117 2004-05-30 Martin Baulig <martin@ximian.com>
2119 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2120 we're doing a silent lookup. Don't try to lookup nested types in
2121 TypeManager.object_type (thanks to Ben Maurer).
2123 2004-05-30 Martin Baulig <martin@ximian.com>
2125 Committing a patch from Ben Maurer.
2127 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2129 2004-05-29 Martin Baulig <martin@ximian.com>
2131 * class.cs (IMethodData.ShouldIgnore): New method.
2133 * typemanager.cs (TypeManager.MethodFlags): Don't take a
2134 `Location' argument, we don't need it anywhere. Use
2135 `IMethodData.ShouldIgnore ()' instead of
2136 `MethodData.GetMethodFlags ()'.
2137 (TypeManager.AddMethod): Removed.
2138 (TypeManager.AddMethod2): Renamed to AddMethod.
2140 2004-05-29 Martin Baulig <martin@ximian.com>
2142 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
2144 * convert.cs (Convert.ImplicitReferenceConversion): If we're
2145 converting from a class type S to an interface type and we already
2146 have an object on the stack, don't box it again. Fixes #52578.
2148 2004-05-29 Martin Baulig <martin@ximian.com>
2150 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2151 Added support for `params' parameters. Fixes #59267.
2153 2004-05-29 Martin Baulig <martin@ximian.com>
2155 * literal.cs (NullPointer): Provide a private .ctor which sets
2156 `type' to TypeManager.object_type. Fixes #59048.
2158 2004-05-29 Martin Baulig <martin@ximian.com>
2160 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
2161 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
2163 * ecore.cs (EventExpr.instance_expr): Make the field private.
2165 2004-05-26 Marek Safar <marek.safar@seznam.cz>
2167 Fixed bug #50080 & cs0214-2.cs
2168 * expression.cs (Cast.DoResolve): Check unsafe context here.
2170 * statement.cs (Resolve.DoResolve): Likewise.
2172 2004-05-26 Martin Baulig <martin@ximian.com>
2174 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
2176 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
2177 (RootContext.LookupType): Pass down the `silent' flag.
2179 2004-05-25 Martin Baulig <martin@ximian.com>
2182 (MethodGroupExpr.IdenticalTypeName): New public property.
2183 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
2184 expression actually refers to a type.
2186 2004-05-25 Martin Baulig <martin@ximian.com>
2188 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
2189 for #56176 and made it actually work.
2191 2004-05-25 Martin Baulig <martin@ximian.com>
2193 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
2194 (FieldExpr, PropertyExpr): Override and implement
2195 CacheTemporaries. Fixes #52279.
2197 2004-05-25 Miguel de Icaza <miguel@ximian.com>
2199 * location.cs: In the new compiler listing a file twice is a
2200 warning, not an error.
2202 2004-05-24 Martin Baulig <martin@ximian.com>
2204 * enum.cs (Enum.DefineType): For the `BaseType' to be a
2205 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
2207 2004-05-24 Martin Baulig <martin@ximian.com>
2209 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
2210 walking the `using' list. Fixes #53921.
2212 2004-05-24 Martin Baulig <martin@ximian.com>
2214 * const.cs (Const.LookupConstantValue): Added support for
2215 EmptyCast's; fixes #55251.
2217 2004-05-24 Martin Baulig <martin@ximian.com>
2219 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
2220 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
2221 which does the CS0135 check. The reason is that we first need to
2222 check whether the variable actually exists.
2224 2004-05-24 Martin Baulig <martin@ximian.com>
2226 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
2227 than RootContext.LookupType() to find the explicit interface
2230 2004-05-24 Raja R Harinath <rharinath@novell.com>
2232 * Makefile: Simplify. Use executable.make.
2233 * mcs.exe.sources: New file. List of sources of mcs.exe.
2235 2004-05-24 Anders Carlsson <andersca@gnome.org>
2239 Use the invariant culture when doing String.Compare for CLS case
2242 2004-05-23 Martin Baulig <martin@ximian.com>
2244 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
2245 don't have any dots. Fixes #52622, added cs0246-8.cs.
2247 * namespace.cs (NamespaceEntry.Lookup): Likewise.
2249 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2251 * class.cs (MemberBase.Define): Reuse MemberType member for
2252 resolved type. Other methods can use it too.
2254 2004-05-23 Martin Baulig <martin@ximian.com>
2256 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
2257 the variable also exists in the current block (otherwise, we need
2258 to report a CS0103). Fixes #58670.
2260 2004-05-23 Martin Baulig <martin@ximian.com>
2262 * flowanalysis.cs (Reachability.Reachable): Compute this
2263 on-the-fly rather than storing it as a field.
2265 2004-05-23 Martin Baulig <martin@ximian.com>
2267 * flowanalysis.cs (Reachability.And): Manually compute the
2268 resulting `barrier' from the reachability.
2270 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2273 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
2274 instance of ObsoleteAttribute when symbol is obsolete.
2277 (IMethodData): Extended interface for ObsoleteAttribute support.
2279 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2281 * attribute.cs: Fix bug #55970
2283 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2287 (GetObsoleteAttribute): New method. Creates the instance of
2289 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
2290 ObsoleteAttribute when member is obsolete.
2291 (AttributeTester.Report_ObsoleteMessage): Common method for
2292 Obsolete error/warning reporting.
2295 (TypeContainer.base_classs_type): New member for storing parent type.
2298 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
2299 for this MemberCore.
2301 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2303 * attribute.cs, const.cs: Fix bug #58590
2305 2004-05-21 Martin Baulig <martin@ximian.com>
2307 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
2308 out parameters if the end of the method is unreachable. Fixes
2311 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2313 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
2314 Hari was right, why extra method.
2316 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2318 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
2320 2004-05-20 Martin Baulig <martin@ximian.com>
2322 Merged this back from gmcs to keep the differences to a minumum.
2324 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
2325 instead of a Declspace.
2326 (Attribute.ResolveType): Likewise.
2327 (Attributes.Search): Likewise.
2328 (Attributes.Contains): Likewise.
2329 (Attributes.GetClsCompliantAttribute): Likewise.
2331 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
2333 (MethodData.ApplyAttributes): Take an EmitContext instead of a
2336 2004-05-19 Marek Safar <marek.safar@seznam.cz>
2338 Fix bug #58688 (MCS does not report error when the same attribute
2341 * attribute.cs (Attribute.Emit): Distinction between null and default.
2343 2004-05-19 Raja R Harinath <rharinath@novell.com>
2345 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
2346 of a top-level attribute without an attribute target.
2347 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
2349 (Attribute.Conditional_GetConditionName),
2350 (Attribute.Obsolete_GetObsoleteMessage): Update.
2351 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
2352 part of ScanForIndexerName.
2353 (Attribute.CanIgnoreInvalidAttribute): New function.
2354 (Attribute.ScanForIndexerName): Move to ...
2355 (Attributes.ScanForIndexerName): ... here.
2356 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
2357 (Attributes.Search): New internal variant that can choose not to
2358 complain if types aren't resolved. The original signature now
2360 (Attributes.GetClsCompliantAttribute): Use internal variant, with
2361 complaints suppressed.
2362 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
2363 only if it not useful.
2364 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
2365 top-level for attributes that are shared between the assembly
2366 and a top-level class.
2367 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
2368 * class.cs: Update to reflect changes.
2369 (DefineIndexers): Fuse loops.
2370 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
2371 a couple more variants of attribute names.
2373 2004-05-18 Marek Safar <marek.safar@seznam.cz>
2375 Fix bug #52585 (Implemented explicit attribute declaration)
2378 (Attributable.ValidAttributeTargets): New abstract method. It gets
2379 list of valid attribute targets for explicit target declaration.
2380 (Attribute.Target): It holds target itself.
2381 (AttributeSection): Removed.
2382 (Attribute.CheckTargets): New method. It checks whether attribute
2383 target is valid for the current element.
2386 (EventProperty): New class. For events that are declared like
2387 property (with add and remove accessors).
2388 (EventField): New class. For events that are declared like field.
2391 * cs-parser.jay: Implemented explicit attribute target declaration.
2393 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
2394 Override ValidAttributeTargets.
2397 (ReturnParameter): Class for applying custom attributes on
2399 (ParameterAtribute): New class. Class for applying custom
2400 attributes on the parameter type.
2402 2004-05-17 Miguel de Icaza <miguel@ximian.com>
2404 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
2407 (Method): Allow UNSAFE here.
2409 * modifiers.cs: Support unsafe reporting.
2411 2004-05-17 Marek Safar <marek.safar@seznam.cz>
2413 * decl.cs: Fix bug #58478.
2415 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2417 * statement.cs: When checking for unreachable code on an EmptyStatement,
2418 set the location. Fixes bug #58488.
2420 2004-05-13 Miguel de Icaza <miguel@ximian.com>
2422 * driver.cs: Add -pkg handling.
2424 From Gonzalo: UseShelLExecute=false
2426 2004-05-12 Marek Safar <marek.safar@seznam.cz>
2429 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
2431 (Attribute.IsClsCompliaceRequired): Moved to base for better
2433 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
2434 when attribute is AttributeUsageAttribute.
2435 (Attribute.GetValidTargets): Simplified.
2436 (Attribute.GetAttributeUsage): New method returns AttributeUsage
2437 attribute for this type.
2438 (Attribute.ApplyAttributes): Method renamed to Emit and make
2440 (GlobalAttributeSection): New class for special handling of global
2441 attributes (assembly, module).
2442 (AttributeSection.Emit): New method.
2444 * class.cs: Implemented Attributable abstract methods.
2445 (MethodCore.LabelParameters): Moved to Parameter class.
2446 (Accessor): Is back simple class.
2447 (PropertyMethod): Implemented Attributable abstract class.
2448 (DelegateMethod): Implemented Attributable abstract class.
2449 (Event): New constructor for disctintion between normal Event
2450 and Event with accessors.
2452 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
2454 * codegen.cs, const.cs, decl.cs, delegate.cs:
2455 (CommonAssemblyModulClass): Implemented Attributable abstract class
2458 * enum.cs: Implement IAttributeSupport interface.
2459 (EnumMember): New class for emum members. Implemented Attributable
2463 (ParameterBase): Is abstract.
2464 (ReturnParameter): New class for easier [return:] attribute handling.
2466 * typemanager.cs: Removed builder_to_attr.
2468 2004-05-11 Raja R Harinath <rharinath@novell.com>
2471 * attribute.cs (Attribute.GetPositionalValue): New function.
2472 * class.cs (TypeContainer.VerifyMembers): New function.
2473 (TypeContainer.Emit): Use it.
2474 (ClassOrStruct): New base class for Class and Struct.
2475 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
2476 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
2478 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
2479 then each non-static field should have a FieldOffset attribute.
2480 Otherwise, none of the fields should have a FieldOffset attribute.
2481 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
2482 and FieldOffset attributes.
2483 * typemanager.cs (TypeManager.struct_layout_attribute_type)
2484 (TypeManager.field_offset_attribute_type): New core types.
2485 (TypeManager.InitCoreTypes): Initialize them.
2487 2004-05-11 Michal Moskal <malekith@pld-linux.org>
2489 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
2490 Return correct type.
2493 2004-05-09 Miguel de Icaza <miguel@ximian.com>
2495 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
2496 be implicitly converted to ulong.
2498 * expression.cs: The logic for allowing operator &, | and ^ worked
2499 was wrong, it worked before because we did not report an error in
2500 an else branch. Fixes 57895.
2502 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
2503 allow volatile fields to be reference types.
2505 2004-05-07 Miguel de Icaza <miguel@ximian.com>
2507 * driver.cs: Add support for /debug-
2509 2004-05-07 Raja R Harinath <rharinath@novell.com>
2511 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
2512 Add a 'complain' parameter to silence errors.
2513 (Attribute.Resolve): Update to changes. Put in sanity check to catch
2514 silently overlooked type-resolutions.
2515 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
2517 (Attributes.Search): New function.
2518 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
2519 (Attributes.GetAttributeFullName): Remove hack.
2520 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
2521 Update to reflect changes.
2522 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
2523 Use Attributes.Search instead of nested loops.
2525 2004-05-07 Marek Safar <marek.safar@seznam.cz>
2528 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
2529 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
2530 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
2532 * report.cs: (Report.Warning): Renamed to Warning_T because of
2533 parameter collision.
2535 2004-05-05 Raja R Harinath <rharinath@novell.com>
2537 * expression.cs (MemberAccess.ResolveMemberAccess):
2538 Exit with non-zero status after Report.Error.
2539 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
2541 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
2543 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2545 * support.cs: Don't hang when the file is empty.
2547 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2549 * support.cs: In SeekableStreamReader, compute the preamble size of the
2550 underlying stream. Position changes should take into account that initial
2553 2004-05-03 Todd Berman <tberman@sevenl.net>
2555 * driver.cs: remove unused GetSysVersion function.
2557 2004-05-03 Todd Berman <tberman@sevenl.net>
2559 * driver.cs: Remove the hack from saturday, as well as the hack
2560 from jackson (LoadAssemblyFromGac), also adds the CWD to the
2561 link_paths to get that bit proper.
2563 2004-05-01 Todd Berman <tberman@sevenl.net>
2565 * driver.cs: Try a LoadFrom before a Load, this checks the current
2566 path. This is currently a bug in mono that is be fixed, however, this
2567 provides a workaround for now. This will be removed when the bug
2570 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
2572 * CryptoConvert.cs: Updated to latest version. Fix issue with
2573 incomplete key pairs (#57941).
2575 2004-05-01 Todd Berman <tberman@sevenl.net>
2577 * driver.cs: Remove '.' from path_chars, now System.* loads properly
2580 2004-04-30 Jackson Harper <jackson@ximian.com>
2582 * codegen.cs: Open keys readonly.
2584 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2586 * typemanager.cs: don't report cyclic struct layout when a struct
2587 contains 2 or more fields of the same type. Failed for Pango.AttrShape
2588 which has 2 Pango.Rectangle fields.
2590 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
2592 * expression.cs: Handle IntPtr comparisons with IL code
2593 rather than a method call.
2595 2004-04-29 Martin Baulig <martin@ximian.com>
2597 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
2598 the list of PropertyInfo's in class hierarchy and find the
2599 accessor. Fixes #56013.
2601 2004-04-29 Martin Baulig <martin@ximian.com>
2603 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
2605 2004-04-29 Martin Baulig <martin@ximian.com>
2607 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2609 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
2611 2004-04-29 Martin Baulig <martin@ximian.com>
2613 * class.cs (ConstructorInitializer.Resolve): Check whether the
2614 parent .ctor is accessible. Fixes #52146.
2616 2004-04-29 Martin Baulig <martin@ximian.com>
2618 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2620 * statement.cs (Using.EmitLocalVariableDecls): Use
2621 TypeManager.idisposable_type, not typeof (IDisposable).
2622 (Foreach.EmitCollectionForeach): Added support for valuetypes.
2624 2004-04-29 Martin Baulig <martin@ximian.com>
2626 * class.cs (Event.Define): Don't emit the field and don't set
2627 RTSpecialName and SpecialName for events on interfaces. Fixes
2630 2004-04-29 Raja R Harinath <rharinath@novell.com>
2632 Refactor Attribute.ApplyAttributes.
2633 * attribute.cs (Attributable): New base class for objects that can
2634 have Attributes applied on them.
2635 (Attribute): Make AttributeUsage fields public.
2636 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
2637 (Attribute.IsInternalCall): New property.
2638 (Attribute.UsageAttr): Convert to a public read-only property.
2639 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
2640 (Attribute.ResolveType, Attribute.Resolve)
2641 (Attribute.ScanForIndexerName): Update to reflect changes.
2642 (Attribute.CheckAttributeTarget): Re-format.
2643 (Attribute.ApplyAttributes): Refactor, to various
2644 Attributable.ApplyAttributeBuilder methods.
2645 * decl.cs (MemberCore): Make Attributable.
2646 * class.cs (Accessor): Make Attributable.
2647 (MethodData.ApplyAttributes): Use proper attribute types, not
2649 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
2650 (TypeContainer.ApplyAttributeBuilder)
2651 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
2652 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
2653 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
2654 (Operator.ApplyAttributeBuilder): New factored-out methods.
2655 * const.cs (Const.ApplyAttributeBuilder): Likewise.
2656 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
2657 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
2658 * parameter.cs (ParameterBase): New Attributable base class
2659 that can also represent Return types.
2660 (Parameter): Update to the changes.
2662 2004-04-29 Jackson Harper <jackson@ximian.com>
2664 * driver.cs: Prefer the corlib system version when looking for
2665 assemblies in the GAC. This is still a hack, but its a better hack
2668 2004-04-29 Marek Safar <marek.safar@seznam.cz>
2670 * decl.cs, enum.cs: Improved error 3005 reporting.
2672 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
2673 (related_symbols): New private member for list of symbols
2674 related to reported error/warning.
2676 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
2678 2004-04-29 Martin Baulig <martin@ximian.com>
2680 * ecore.cs (Expression.Constantify): If we're an enum and
2681 TypeManager.TypeToCoreType() doesn't give us another type, use
2682 t.UnderlyingSystemType. Fixes #56178.
2684 2004-04-29 Martin Baulig <martin@ximian.com>
2686 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
2687 interfaces and for each interface, only add members directly
2688 declared in that interface. Fixes #53255.
2690 2004-04-28 Martin Baulig <martin@ximian.com>
2692 * expression.cs (ConditionalLogicalOperator): Use a temporary
2693 variable for `left' to avoid that we evaluate it more than once;
2696 2004-04-28 Martin Baulig <martin@ximian.com>
2698 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
2701 2004-04-28 Martin Baulig <martin@ximian.com>
2703 * statement.cs (LocalInfo.Resolve): Check whether the type is not
2706 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
2707 whether the type is not void (CS1547).
2709 2004-04-28 Martin Baulig <martin@ximian.com>
2711 * expression.cs (Unary.DoResolveLValue): Override this and report
2712 CS0131 for anything but Operator.Indirection.
2714 2004-04-28 Martin Baulig <martin@ximian.com>
2716 Committing a patch from Ben Maurer; see bug #50820.
2718 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
2721 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
2724 2004-04-28 Martin Baulig <martin@ximian.com>
2726 Committing a patch from Ben Maurer; see bug #50820.
2728 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
2731 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
2734 2004-04-28 Martin Baulig <martin@ximian.com>
2736 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
2737 (Block.AddLabel): Call DoLookupLabel() to only search in the
2740 2004-04-28 Martin Baulig <martin@ximian.com>
2742 * cfold.cs (ConstantFold.BinaryFold): Added special support for
2743 comparing StringConstants and NullLiterals in Equality and Inequality.
2745 2004-04-28 Jackson Harper <jackson@ximian.com>
2747 * driver.cs: Attempt to load referenced assemblies from the
2748 GAC. This is the quick and dirty version of this method that
2749 doesnt take into account versions and just takes the first
2750 canidate found. Will be good enough for now as we will not have more
2751 then one version installed into the GAC until I update this method.
2753 2004-04-28 Martin Baulig <martin@ximian.com>
2755 * typemanager.cs (TypeManager.CheckStructCycles): New public
2756 static method to check for cycles in the struct layout.
2758 * rootcontext.cs (RootContext.PopulateTypes): Call
2759 TypeManager.CheckStructCycles() for each TypeContainer.
2760 [Note: We only need to visit each type once.]
2762 2004-04-28 Martin Baulig <martin@ximian.com>
2764 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
2766 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
2767 success and added `out object value'. Use a `bool resolved' field
2768 to check whether we've already been called rather than
2769 `ConstantValue != null' since this breaks for NullLiterals.
2771 2004-04-28 Raja R Harinath <rharinath@novell.com>
2773 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
2774 setting of this flag, since the 'set' method may be non-public.
2776 2004-04-28 Raja R Harinath <rharinath@novell.com>
2778 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
2779 check on current_vector.Block.
2781 2004-04-27 Martin Baulig <martin@ximian.com>
2783 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
2784 a field initializer. Fixes #56459.
2786 2004-04-27 Martin Baulig <martin@ximian.com>
2788 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
2789 we're not attempting to use an indexer. Fixes #52154.
2791 2004-04-27 Martin Baulig <martin@ximian.com>
2793 * statement.cs (Return): Don't create a return label if we don't
2794 need it; reverts my change from January 20th. Thanks to Ben
2797 2004-04-27 Martin Baulig <martin@ximian.com>
2799 According to the spec, `goto' can only leave a nested scope, but
2802 * statement.cs (Block.LookupLabel): Only lookup in the current
2803 block, don't recurse into parent or child blocks.
2804 (Block.AddLabel): Check in parent and child blocks, report
2805 CS0140/CS0158 if we find a duplicate.
2806 (Block): Removed this indexer for label lookups.
2807 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
2808 this already does the error reporting for us.
2811 (FlowBranching.UsageVector.Block): New public variable; may be null.
2812 (FlowBranching.CreateSibling): Added `Block' argument.
2813 (FlowBranching.LookupLabel): New public virtual method. Lookup a
2814 label for the target of a `goto' and check whether we're not
2815 leaving a `finally'.
2817 2004-04-27 Martin Baulig <martin@ximian.com>
2819 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2820 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
2823 2004-04-27 Martin Baulig <martin@ximian.com>
2825 * statement.cs (Block.AddLabel): Also check for implicit blocks
2826 and added a CS0158 check.
2828 2004-04-27 Martin Baulig <martin@ximian.com>
2830 * flowanalysis.cs (FlowBranchingLoop): New class.
2831 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
2832 UsageVector's instead of an ArrayList.
2833 (FlowBranching.Label): Likewise.
2834 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
2835 (FlowBranching.AddBreakVector): New method.
2837 2004-04-27 Miguel de Icaza <miguel@ximian.com>
2839 * attribute.cs: Small regression fix: only convert the type if we
2840 the type is different, fixes System.Drawing build.
2842 2004-04-27 Martin Baulig <martin@ximian.com>
2844 * attribute.cs (Attribute.Resolve): If we have a constant value
2845 for a named field or property, implicity convert it to the correct
2848 2004-04-27 Raja R Harinath <rharinath@novell.com>
2850 * statement.cs (Block.Block): Implicit blocks share
2851 'child_variable_names' fields with parent blocks.
2852 (Block.AddChildVariableNames): Remove.
2853 (Block.AddVariable): Mark variable as "used by a child block" in
2854 every surrounding block.
2855 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
2856 been used in a child block, complain about violation of "Invariant
2857 meaning in blocks" rule.
2858 * cs-parser.jay (declare_local_variables): Don't use
2859 AddChildVariableNames.
2860 (foreach_statement): Don't create an implicit block: 'foreach'
2863 2004-04-23 Miguel de Icaza <miguel@ximian.com>
2865 * convert.cs (ImplicitNumericConversion): 0 is also positive when
2866 converting from 0L to ulong. Fixes 57522.
2868 2004-04-22 Marek Safar <marek.safar@seznam.cz>
2870 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
2871 derived class hides via 'new' keyword field from base class (test-242.cs).
2872 TODO: Handle this in the more general way.
2874 * class.cs (CheckBase): Ditto.
2876 2004-04-22 Marek Safar <marek.safar@seznam.cz>
2878 * decl.cs (caching_flags): New member for storing cached values
2880 (MemberCore.Flags): New enum where bit flags for caching_flags
2882 (MemberCore.cls_compliance): Moved to caching_flags.
2883 (DeclSpace.Created): Moved to caching_flags.
2885 * class.cs: Use caching_flags instead of DeclSpace.Created
2887 2004-04-21 Miguel de Icaza <miguel@ximian.com>
2889 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
2890 if we are only a derived class, not a nested class.
2892 * typemanager.cs: Same as above, but do this at the MemberLookup
2893 level (used by field and methods, properties are handled in
2894 PropertyExpr). Allow for the qualified access if we are a nested
2897 2004-04-21 Marek Safar <marek.safar@seznam.cz>
2899 * class.cs: Refactoring.
2900 (IMethodData): New inteface; Holds links to parent members
2901 to avoid member duplication (reduced memory allocation).
2902 (Method): Implemented IMethodData interface.
2903 (PropertyBase): New inner classes for get/set methods.
2904 (PropertyBase.PropertyMethod): Implemented IMethodData interface
2905 (Event): New inner classes for add/remove methods.
2906 (Event.DelegateMethod): Implemented IMethodData interface.
2908 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
2909 EmitContext (related to class.cs refactoring).
2911 2004-04-21 Raja R Harinath <rharinath@novell.com>
2913 * delegate.cs (Delegate.VerifyApplicability): If the number of
2914 arguments are the same as the number of parameters, first try to
2915 verify applicability ignoring any 'params' modifier on the last
2919 2004-04-16 Raja R Harinath <rharinath@novell.com>
2921 * class.cs (TypeContainer.AddIndexer): Use
2922 'ExplicitInterfaceName' to determine if interface name was
2923 explicitly specified. 'InterfaceType' is not initialized at this time.
2924 (TypeContainer.DefineIndexers): Remove use of temporary list. The
2925 Indexers array is already in the required order. Initialize
2926 'IndexerName' only if there are normal indexers.
2927 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
2928 (TypeContainer.Emit): Emit DefaultMember attribute only if
2929 IndexerName is initialized.
2932 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
2934 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
2937 2004-04-15 Raja R Harinath <rharinath@novell.com>
2939 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
2943 * attribute.cs (Attribute.Resolve): Check for duplicate named
2947 2004-04-15 Miguel de Icaza <miguel@ximian.com>
2949 * iterators.cs (MarkYield): track whether we are in an exception,
2950 and generate code accordingly. Use a temporary value to store the
2951 result for our state.
2953 I had ignored a bit the interaction of try/catch with iterators
2954 since their behavior was not entirely obvious, but now it is
2955 possible to verify that our behavior is the same as MS .NET 2.0
2959 2004-04-14 Miguel de Icaza <miguel@ximian.com>
2961 * iterators.cs: Avoid creating temporaries if there is no work to
2964 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
2965 Enumerations, use TypeManager.EnumToUnderlying and call
2968 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
2971 (This.Emit): Use EmitContext.EmitThis to emit our
2974 (This.EmitAssign): Ditto.
2976 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
2977 codepaths, we will move all the functionality into
2980 (FieldExpr.EmitAssign): Ditto.
2982 This fixes several hidden bugs that I uncovered while doing a code
2983 review of this today.
2985 * codegen.cs (EmitThis): reworked so the semantics are more clear
2986 and also support value types "this" instances.
2988 * iterators.cs: Changed so that for iterators in value types, we
2989 do not pass the value type as a parameter.
2991 Initialization of the enumerator helpers is now done in the caller
2992 instead of passing the parameters to the constructors and having
2993 the constructor set the fields.
2995 The fields have now `assembly' visibility instead of private.
2997 2004-04-11 Miguel de Icaza <miguel@ximian.com>
2999 * expression.cs (Argument.Resolve): Check if fields passed as ref
3000 or out are contained in a MarshalByRefObject.
3002 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3003 another compiler type.
3005 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3007 * class.cs (Indexer.Define): use the new name checking method.
3008 Also, return false on an error.
3009 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3010 (is_identifier_[start/part]_character): make static.
3012 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3014 * expression.cs (Binary.ResolveOperator): Do no append strings
3015 twice: since we can be invoked more than once (array evaluation)
3016 on the same concatenation, take care of this here. Based on a fix
3017 from Ben (bug #56454)
3019 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3021 * codegen.cs: Fix another case where CS1548 must be reported (when
3022 delay-sign isn't specified and no private is available #56564). Fix
3023 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3024 error when MCS is used on the MS runtime and we need to delay-sign
3025 (which seems unsupported by AssemblyBuilder - see #56621).
3027 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3029 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3030 (TypeManager.ComputeNamespaces): Faster implementation for
3033 * compiler.csproj: Updated AssemblyName to mcs.
3035 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3037 * rootcontext.cs: Add new types to the boot resolution.
3039 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3040 MulticastDelegate is not allowed.
3042 * typemanager.cs: Add new types to lookup: System.TypedReference
3045 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3046 check for TypedReference or ArgIterator, they are not allowed.
3048 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3049 makes us properly catch 1510 in some conditions (see bug 56016 for
3052 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3054 * CryptoConvert.cs: update from corlib version
3057 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3059 * class.cs (Indexer.Define): Check indexername declaration
3061 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3063 * attribute.cs (IsClsCompliant): Fixed problem with handling
3064 all three states (compliant, not-compliant, undetected).
3066 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3068 * attribute.cs (Attribute): Location is now public.
3069 (Resolve): Store resolved arguments (pos_values) in attribute class.
3070 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3071 (GetClsCompliantAttributeValue): New method that gets
3072 CLSCompliantAttribute value.
3073 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3074 if exists else null.
3075 (AttributeTester): New class for CLS-Compliant verification routines.
3077 * class.cs (Emit): Add CLS-Compliant verification.
3078 (Method.GetSignatureForError): Implemented.
3079 (Constructor.GetSignatureForError): Implemented
3080 (Constructor.HasCompliantArgs): Returns if constructor has
3081 CLS-Compliant arguments.
3082 (Constructor.Emit): Override.
3083 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3084 is needed to test only parameters.
3085 (FieldBase.GetSignatureForError): Implemented.
3086 (TypeContainer): New member for storing base interfaces.
3087 (TypeContainer.FindMembers): Search in base interfaces too.
3089 * codegen.cs (GetClsComplianceAttribute): New method that gets
3090 assembly or module CLSCompliantAttribute value.
3091 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3093 (ModuleClass.Emit): Add error 3012 test.
3095 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3097 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3098 state for all decl types.
3099 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3100 if CLS-Compliant tests are required.
3101 (IsClsCompliaceRequired): New method. Analyze whether code
3102 must be CLS-Compliant.
3103 (IsExposedFromAssembly): New method. Returns true when MemberCore
3104 is exposed from assembly.
3105 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3106 value or gets cached value.
3107 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3108 is explicitly marked with CLSCompliantAttribute.
3109 (IsIdentifierClsCompliant): New abstract method. This method is
3110 used to testing error 3005.
3111 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3112 for identifier and parameters CLS-Compliant testing.
3113 (VerifyClsCompliance): New method. The main virtual method for
3114 CLS-Compliant verifications.
3115 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3116 null. I don't know why is null (too many public members !).
3117 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3118 and get value of first CLSCompliantAttribute that found.
3120 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3121 (VerifyClsCompliance): Override and add extra tests.
3123 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3124 clscheck- disable CLS-Compliant verification event if assembly is has
3125 CLSCompliantAttribute(true).
3127 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3128 ApllyAttribute is now called in emit section as in the other cases.
3129 Possible future Emit integration.
3130 (IsIdentifierClsCompliant): New override.
3131 (VerifyClsCompliance): New override.
3132 (GetEnumeratorName): Returns full enum name.
3134 * parameter.cs (GetSignatureForError): Implemented.
3136 * report.cs (WarningData): New struct for Warning message information.
3137 (LocationOfPreviousError): New method.
3138 (Warning): New method. Reports warning based on the warning table.
3139 (Error_T): New method. Reports error based on the error table.
3141 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3142 verifications are done here.
3144 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3146 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3147 CLSCompliantAttribute.
3148 (all_imported_types): New member holds all imported types from other
3150 (LoadAllImportedTypes): New method fills static table with exported types
3151 from all referenced assemblies.
3152 (Modules): New property returns all assembly modules.
3154 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3156 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3157 throwing a parser error.
3159 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3160 which removes the hardcoded get_/set_ prefixes for properties, as
3161 IL allows for the properties to be named something else.
3165 * expression.cs: Do not override operand before we know if it is
3168 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3170 * typemanager.cs: support for pinned variables.
3172 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3174 * decl.cs, typemanager.cs: Avoid using an arraylist
3175 as a buffer if there is only one result set.
3177 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3179 * expression.cs: Make sure you cant call a static method
3180 with an instance expression, bug #56174.
3182 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3184 * class.cs (IsDuplicateImplementation): Improve error reporting to
3185 flag 663 (method only differs in parameter modifier).
3187 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3188 in preprocessor directives.
3190 * location.cs (LookupFile): Allow for the empty path.
3192 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3193 better approach for some of that patch, but its failing with the
3194 CharSet enumeration. For now try/catch will do.
3196 * typemanager.cs: Do not crash if a struct does not have fields.
3199 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3201 * expression.cs: cs0213, cant fix a fixed expression.
3204 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3206 * cs-parser.jay: detect invalid embeded statements gracefully.
3209 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3211 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
3214 the invocation type may not be a subclass of the tye of the item/
3215 The type of the item must be a subclass of the invocation item.
3220 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
3222 * attribute.cs: Added methods to get a string and a bool from an
3223 attribute. Required to information from AssemblyKeyFileAttribute,
3224 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
3225 * codegen.cs: Modified AssemblyName creation to include support for
3226 strongnames. Catch additional exceptions to report them as CS1548.
3227 * compiler.csproj: Updated include CryptoConvert.cs.
3228 * compiler.csproj.user: Removed file - user specific configuration.
3229 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
3230 Mono.Security assembly. The original class is maintained and tested in
3231 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
3232 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
3233 like CSC 8.0 (C# v2) supports.
3234 * Makefile: Added CryptoConvert.cs to mcs sources.
3235 * rootcontext.cs: Added new options for strongnames.
3237 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
3239 * driver.cs: For --expect-error, report error code `2'
3240 if the program compiled with no errors, error code `1' if
3241 it compiled with an error other than the one expected.
3243 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
3245 * compiler.csproj: Updated for Visual Studio .NET 2003.
3246 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
3247 * compiler.sln: Updated for Visual Studio .NET 2003.
3249 2004-03-24 Ravi Pratap M <ravi@ximian.com>
3251 * expression.cs: Fix bug #47234. We basically need to apply the
3252 rule that we prefer the conversion of null to a reference type
3253 when faced with a conversion to 'object' (csc behaviour).
3255 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3257 * statement.cs: Shorter form for foreach, eliminates
3258 a local variable. r=Martin.
3260 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3262 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
3263 checks if we can use brtrue/brfalse to test for 0.
3264 * expression.cs: use the above in the test for using brtrue/brfalse.
3267 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3269 * expression.cs: Rewrite string concat stuff. Benefits:
3271 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
3272 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
3273 rather than a concat chain.
3275 * typemanager.cs: Add lookups for more concat overloads.
3277 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3279 * expression.cs: Emit shorter il code for array init.
3296 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
3298 * statement.cs: Before, two switch blocks would be merged if the
3299 total size of the blocks (end_item - begin_item + 1) was less than
3300 two times the combined sizes of the blocks.
3302 Now, it will only merge if after the merge at least half of the
3307 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
3309 * class.cs : csc build fix for GetMethods(). See bug #52503.
3311 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
3313 * expression.cs: Make sure fp comparisons work with NaN.
3314 This fixes bug #54303. Mig approved this patch a long
3315 time ago, but we were not able to test b/c the runtime
3318 2004-03-19 Miguel de Icaza <miguel@ximian.com>
3320 * ecore.cs (TypExpr.GetHashCode): implement this overload.
3322 2004-03-19 Martin Baulig <martin@ximian.com>
3324 * class.cs (MemberCore.IsDuplicateImplementation): Report the
3325 error here and not in our caller.
3327 2004-03-19 Martin Baulig <martin@ximian.com>
3329 * interface.cs: Completely killed this file.
3330 (Interface): We're now a TypeContainer and live in class.cs.
3332 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
3333 argument; we're now also called for interfaces.
3334 (TypeContainer.DefineMembers): Allow this method being called
3336 (TypeContainer.GetMethods): New public method; formerly known as
3337 Interface.GetMethod(). This is used by PendingImplementation.
3338 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
3339 it's now private and non-static.
3340 (Interface): Moved this here; it's now implemented similar to
3342 (Method, Property, Event, Indexer): Added `bool is_interface'
3343 argument to their .ctor's.
3344 (MemberBase.IsInterface): New public field.
3346 * cs-parser.jay: Create normal Method, Property, Event, Indexer
3347 instances instead of InterfaceMethod, InterfaceProperty, etc.
3348 (opt_interface_base): Removed; we now use `opt_class_base' instead.
3349 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
3351 2004-03-19 Martin Baulig <martin@ximian.com>
3353 * class.cs (MethodCore.IsDuplicateImplementation): New private
3354 method which does the CS0111 checking.
3355 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
3356 Use IsDuplicateImplementation().
3358 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
3360 * decl.cs (FindMemberToOverride): New method to find the correct
3361 method or property to override in the base class.
3363 - Make Method/Property use the above method to find the
3364 version in the base class.
3365 - Remove the InheritableMemberSignatureCompare as it is now
3368 This patch makes large code bases much faster to compile, as it is
3369 O(n) rather than O(n^2) to do this validation.
3371 Also, it fixes bug 52458 which is that nested classes are not
3372 taken into account when finding the base class member.
3374 Reviewed/Approved by Martin.
3376 2004-03-17 Marek Safar <marek.safar@seznam.cz>
3378 * interface.cs: In all interface classes removed redundant
3379 member initialization.
3381 2004-03-16 Martin Baulig <martin@ximian.com>
3383 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
3385 2004-03-15 Miguel de Icaza <miguel@ximian.com>
3387 * decl.cs (DefineTypeAndParents): New helper method to define a
3388 type's containers before the type itself is defined; This is a
3389 bug exposed by the recent changes to Windows.Forms when an
3390 implemented interface was defined inside a class that had not been
3393 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
3395 (Check): Loop correctly to report errors modifiers
3396 (UNSAFE was not in the loop, since it was the same as TOP).
3398 * interface.cs: Every interface member now takes a ModFlags,
3399 instead of a "is_new" bool, which we set on the base MemberCore.
3401 Every place where we called "UnsafeOk" in the interface, now we
3402 call the proper member (InterfaceMethod.UnsafeOK) instead to get
3403 the unsafe settings from the member declaration instead of the
3404 container interface.
3406 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
3408 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
3409 `set_indexer_name' to the pending bits (one per type).
3411 We fixed a bug today that was picking the wrong method to
3412 override, since for properties the existing InterfaceMethod code
3413 basically ignored the method name. Now we make sure that the
3414 method name is one of the valid indexer names.
3416 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
3418 * support.cs (SeekableStreamReader): Keep track of stream byte
3419 positions and don't mix them with character offsets to the buffer.
3421 Patch from Gustavo Giráldez
3423 2004-03-15 Marek Safar <marek.safar@seznam.cz>
3425 * interface.cs (InterfaceSetGetBase): Removed double member
3426 initialization, base class does it as well.
3428 2004-03-13 Martin Baulig <martin@ximian.com>
3430 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
3431 when compiling corlib.
3433 2004-03-13 Miguel de Icaza <miguel@ximian.com>
3435 * convert.cs (ExplicitConversion): We were reporting an error on
3436 certain conversions (object_type source to a value type, when the
3437 expression was `null') before we had a chance to pass it through
3438 the user defined conversions.
3440 * driver.cs: Replace / and \ in resource specifications to dots.
3443 * class.cs: Add check for duplicate operators. Fixes 52477
3445 2004-03-11 Miguel de Icaza <miguel@ximian.com>
3447 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
3448 that are in the middle of the statements, not only at the end.
3451 * class.cs (TypeContainer.AddField): No longer set the
3452 `HaveStaticConstructor' flag, now we call it
3453 `UserDefineStaticConstructor' to diferentiate the slightly
3454 semantic difference.
3456 The situation is that we were not adding BeforeFieldInit (from
3457 Modifiers.TypeAttr) to classes that could have it.
3458 BeforeFieldInit should be set to classes that have no static
3463 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
3465 And most importantly Zoltan's comment:
3467 http://bugzilla.ximian.com/show_bug.cgi?id=44229
3469 "I think beforefieldinit means 'it's ok to initialize the type sometime
3470 before its static fields are used', i.e. initialization does not need
3471 to be triggered by the first access to the type. Setting this flag
3472 helps the JIT to compile better code, since it can run the static
3473 constructor at JIT time, and does not need to generate code to call it
3474 (possibly lots of times) at runtime. Unfortunately, mcs does not set
3475 this flag for lots of classes like String.
3477 csc sets this flag if the type does not have an explicit static
3478 constructor. The reasoning seems to be that if there are only static
3479 initalizers for a type, and no static constructor, then the programmer
3480 does not care when this initialization happens, so beforefieldinit
3483 This bug prevents the AOT compiler from being usable, since it
3484 generates so many calls to mono_runtime_class_init that the AOT code
3485 is much slower than the JITted code. The JITted code is faster,
3486 because it does not generate these calls if the vtable is type is
3487 already initialized, which is true in the majority of cases. But the
3488 AOT compiler can't do this."
3490 2004-03-10 Miguel de Icaza <miguel@ximian.com>
3492 * class.cs (MethodData.Emit): Refactor the code so symbolic
3493 information is generated for destructors; For some reasons we
3494 were taking a code path that did not generate symbolic information
3497 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
3499 * class.cs: Create a Constructor.CheckBase method that
3500 takes care of all validation type code. The method
3501 contains some code that was moved from Define.
3503 It also includes new code that checks for duplicate ctors.
3504 This fixes bug #55148.
3506 2004-03-09 Joshua Tauberer <tauberer@for.net>
3508 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
3509 a { ... }-style array creation invokes EmitStaticInitializers
3510 which is not good for reference-type arrays. String, decimal
3511 and now null constants (NullCast) are not counted toward
3512 static initializers.
3514 2004-03-05 Martin Baulig <martin@ximian.com>
3516 * location.cs (SourceFile.HasLineDirective): New public field;
3517 specifies whether the file contains or is referenced by a "#line"
3519 (Location.DefineSymbolDocuments): Ignore source files which
3520 either contain or are referenced by a "#line" directive.
3522 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
3524 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
3525 direct access to our parent, so check the method inline there.
3527 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
3529 * expression.cs (Invocation.EmitCall): Miguel's last commit
3530 caused a regression. If you had:
3535 In Foo the implict this would be null.
3537 2004-02-27 Miguel de Icaza <miguel@ximian.com>
3539 * expression.cs (Invocation.EmitCall): If the method is not
3540 virtual, do not emit a CallVirt to it, use Call.
3542 * typemanager.cs (GetFullNameSignature): Improve the method to
3543 cope with ".ctor" and replace it with the type name.
3545 * class.cs (ConstructorInitializer.Resolve): Now the method takes
3546 as an argument the ConstructorBuilder where it is being defined,
3547 to catch the recursive constructor invocations.
3549 2004-02-26 Miguel de Icaza <miguel@ximian.com>
3551 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
3552 routines to check if a type is an enumerable/enumerator allow
3553 classes that implement the IEnumerable or IEnumerator interfaces.
3555 * class.cs (Property, Operator): Implement IIteratorContainer, and
3556 implement SetYields.
3558 (Property.Define): Do the block swapping for get_methods in the
3559 context of iterators. We need to check if Properties also
3560 include indexers or not.
3562 (Operator): Assign the Block before invoking the
3563 OperatorMethod.Define, so we can trigger the Iterator code
3566 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
3567 Property and Operator classes are not created when we parse the
3568 declarator but until we have the block completed, so we use a
3569 singleton SimpleIteratorContainer.Simple to flag whether the
3570 SetYields has been invoked.
3572 We propagate this setting then to the Property or the Operator to
3573 allow the `yield' to function.
3575 2004-02-25 Marek Safar <marek.safar@seznam.cz>
3577 * codegen.cs: Implemented attribute support for modules.
3578 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
3579 Assembly/Module functionality.
3581 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
3582 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
3583 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
3585 2004-02-16 Marek Safar <marek.safar@seznam.cz>
3587 * interface.cs (FindMembers): The operation is performed on all base
3588 interfaces and not only on the first. It is required for future CLS Compliance patch.
3590 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
3592 * statement.cs, codegen.cs:
3593 This patch deals with patterns such as:
3595 public class List : IEnumerable {
3597 public MyEnumerator GetEnumerator () {
3598 return new MyEnumerator(this);
3601 IEnumerator IEnumerable.GetEnumerator () {
3605 public struct MyEnumerator : IEnumerator {
3610 Before, there were a few things we did wrong:
3611 1) we would emit callvirt on a struct, which is illegal
3612 2) we emited ldarg when we needed to emit ldarga
3613 3) we would mistakenly call the interface methods on an enumerator
3614 type that derived from IEnumerator and was in another assembly. For example:
3616 public class MyEnumerator : IEnumerator
3618 Would have the interface methods called, even if there were public impls of the
3619 method. In a struct, this lead to invalid IL code.
3621 2004-02-11 Marek Safar <marek.safar@seznam.cz>
3623 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
3626 * delegate.cs (Define): Fixed crash when delegate type is undefined.
3628 2004-02-11 Miguel de Icaza <miguel@ximian.com>
3630 * cs-parser.jay: Fix small regression: we were not testing V2
3631 compiler features correctly.
3633 * interface.cs: If the emit context is null, then create one
3635 2004-02-09 Marek Safar <marek.safar@seznam.cz>
3637 * decl.cs (GetSignatureForError): New virtual method to get full name
3640 * attribute.cs (IAttributeSupport): New interface for attribute setting.
3641 Now it is possible to rewrite ApplyAttributes method to be less if/else.
3643 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
3644 Duplicated members and code in these classes has been removed.
3645 Better encapsulation in these classes.
3647 2004-02-07 Miguel de Icaza <miguel@ximian.com>
3649 * assign.cs (Assign.DoResolve): When dealing with compound
3650 assignments, there is a new rule in ECMA C# 2.4 (might have been
3651 there before, but it is documented here) that states that in:
3655 If b is of type int, and the `op' is a shift-operator, then the
3656 above is evaluated as:
3660 * expression.cs (Binary.ResolveOperator): Instead of testing for
3661 int/uint/long/ulong, try to implicitly convert to any of those
3662 types and use that in pointer arithmetic.
3664 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
3665 method to print information for from the type, not from the
3666 null-method we were given.
3668 2004-02-01 Duncan Mak <duncan@ximian.com>
3670 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
3671 parsing for cmd, fixes bug #53694.
3673 2004-02-04 Marek Safar <marek.safar@seznam.cz>
3675 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
3676 in the member name duplication tests. Property and operator name duplication
3677 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
3679 2004-02-03 Marek Safar <marek.safar@seznam.cz>
3681 * interface.cs (PopulateMethod): Fixed crash when interface method
3682 returns not existing type (error test cs0246-3.cs).
3684 2004-02-02 Ravi Pratap M <ravi@ximian.com>
3686 * cs-parser.jay (interface_accessors): Re-write actions to also
3687 store attributes attached to get and set methods. Fix spelling
3690 (inteface_property_declaration): Modify accordingly.
3692 (InterfaceAccessorInfo): New helper class to store information to pass
3693 around between rules that use interface_accessors.
3695 * interface.cs (Emit): Apply attributes on the get and set
3696 accessors of properties and indexers too.
3698 * attribute.cs (ApplyAttributes): Modify accordingly to use the
3699 right MethodBuilder when applying attributes to the get and set accessors.
3701 2004-01-31 Miguel de Icaza <miguel@ximian.com>
3703 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
3705 2004-01-26 Miguel de Icaza <miguel@ximian.com>
3707 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
3709 2004-01-25 Miguel de Icaza <miguel@ximian.com>
3711 * cs-parser.jay: Remove YIELD token, instead use the new grammar
3712 changes that treat `yield' specially when present before `break'
3715 * cs-tokenizer.cs: yield is no longer a keyword.
3717 2004-01-23 Marek Safar <marek.safar@seznam.cz>
3719 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
3720 setting for default constructors.
3721 For default constructors are almost every time set wrong Modifier. The
3722 generated IL code has been alright. But inside mcs this values was
3723 wrong and this was reason why several of my CLS Compliance tests
3726 2004-01-22 Martin Baulig <martin@ximian.com>
3728 * cs-parser.jay (namespace_or_type_name): Return an Expression,
3729 not a QualifiedIdentifier. This is what `type_name_expression'
3730 was previously doing.
3731 (type_name_expression): Removed; the code is now in
3732 `namespace_or_type_name'.
3733 (qualified_identifier): Removed, use `namespace_or_type_name'
3735 (QualifiedIdentifier): Removed this class.
3737 2004-01-22 Martin Baulig <martin@ximian.com>
3739 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
3740 not a string as alias name.
3742 2004-01-21 Miguel de Icaza <miguel@ximian.com>
3744 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
3745 #52730 bug, and instead compute correctly the need to use a
3746 temporary variable when requesting an address based on the
3747 static/instace modified of the field and the constructor.
3749 2004-01-21 Martin Baulig <martin@ximian.com>
3751 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
3752 class and namespace before looking up aliases. Fixes #52517.
3754 2004-01-21 Martin Baulig <martin@ximian.com>
3756 * flowanalysis.cs (UsageVector.Merge): Allow variables being
3757 assinged in a 'try'; fixes exception4.cs.
3759 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3760 * class.cs : Implemented parameter-less constructor for TypeContainer
3762 * decl.cs: Attributes are now stored here. New property OptAttributes
3764 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
3766 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
3768 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3770 * typemanager.cs (CSharpSignature): Now reports also inner class name.
3771 (CSharpSignature): New method for indexer and property signature.
3773 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3775 * pending.cs (IsVirtualFilter): Faster implementation.
3777 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3779 * typemanager.cs: Avoid inclusion of same assembly more than once.
3781 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3783 * cs-parser.jay: Fixed problem where the last assembly attribute
3784 has been applied also to following declaration (class, struct, etc.)
3786 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3788 * class.cs: Added error CS0538, CS0539 reporting.
3789 Fixed crash on Microsoft runtime when field type is void.
3791 * cs-parser.jay: Added error CS0537 reporting.
3793 * pending.cs: Added error CS0535 reporting.
3794 Improved error report for errors CS0536, CS0534.
3796 2004-01-20 Miguel de Icaza <miguel@ximian.com>
3798 Merge a few bits from the Anonymous Method MCS tree.
3800 * statement.cs (ToplevelBlock): New class for toplevel methods,
3801 will hold anonymous methods, lifted variables.
3803 * cs-parser.jay: Create toplevel blocks for delegates and for
3804 regular blocks of code.
3806 2004-01-20 Martin Baulig <martin@ximian.com>
3808 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
3809 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
3810 and `NeedExplicitReturn'; added `IsLastStatement'.
3811 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
3812 have a `ReturnLabel' or we're not unreachable.
3814 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
3815 child's reachability; don't just override ours with it. Fixes
3816 #58058 (lluis's example).
3817 (FlowBranching): Added public InTryOrCatch(), InCatch(),
3818 InFinally(), InLoop(), InSwitch() and
3819 BreakCrossesTryCatchBoundary() methods.
3821 * statement.cs (Return): Do all error checking in Resolve().
3822 Unless we are the last statement in a top-level block, always
3823 create a return label and jump to it.
3824 (Break, Continue): Do all error checking in Resolve(); also make
3825 sure we aren't leaving a `finally'.
3826 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
3827 statement in a top-level block.
3828 (Block.Flags): Added `IsDestructor'.
3829 (Block.IsDestructor): New public property.
3831 2004-01-20 Martin Baulig <martin@ximian.com>
3833 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
3835 2004-01-20 Martin Baulig <martin@ximian.com>
3837 * statement.cs (Statement.ResolveUnreachable): New public method.
3838 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
3839 (Block.Resolve): Resolve unreachable statements.
3841 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
3843 * expression.cs: We need to fix the case where we do
3844 not have a temp variable here.
3846 * assign.cs: Only expression compound assignments need
3847 temporary variables.
3849 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
3851 * flowanalysis.cs: Reduce memory allocation in a few ways:
3852 - A block with no variables should not allocate a bit
3854 - A method with no out parameters does not need any tracking
3855 for assignment of the parameters, so we need not allocate
3858 public readonly Type[] VariableTypes;
3859 public readonly string[] VariableNames;
3860 Are redundant. The data is already stored in the variable
3861 map, so we need not allocate another array for it.
3862 - We need to add alot of checks for if (params | locals) == null
3863 due to the first two changes.
3865 2004-01-18 Miguel de Icaza <miguel@ximian.com>
3867 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
3868 implement IMemoryLocation, we store a copy on a local variable and
3869 take the address of it. Patch from Benjamin Jemlich
3871 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
3872 to use a special "type_name_expression" rule which reduces the
3873 number of "QualifiedIdentifier" classes created, and instead
3874 directly creates MemberAccess expressions.
3876 2004-01-17 Miguel de Icaza <miguel@ximian.com>
3878 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
3879 that fixes #52853. Null literal assignment to ValueType
3881 * class.cs (MethodData.Emit): Instead of checking the name of the
3882 method to determine if its a destructor, create a new derived
3883 class from Method called Destructor, and test for that.
3885 * cs-parser.jay: Create a Destructor object instead of a Method.
3887 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
3891 2004-01-16 Miguel de Icaza <miguel@ximian.com>
3893 * expression.cs (Binary.ResolveOperator): Perform an implicit
3894 conversion from MethodGroups to their delegate types on the
3897 * delegate.cs: Introduce a new class DelegateCreation that is the
3898 base class for `NewDelegate' and `ImplicitDelegateCreation',
3899 factor some code in here.
3901 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
3902 conversion from MethodGroups to compatible delegate types.
3904 * ecore.cs (Expression.Resolve): Do not flag error 654
3905 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
3906 we allow conversions from MethodGroups to delegate types now.
3908 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
3909 assignments in v2 either.
3911 2004-01-10 Miguel de Icaza <miguel@ximian.com>
3913 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
3914 static read-only fields in ctors.
3916 Applied patch from Benjamin Jemlich
3918 * expression.cs (UnaryMutator): Avoid leaking local variables.
3920 2004-01-09 Miguel de Icaza <miguel@ximian.com>
3922 * cs-tokenizer.cs (IsCastToken): Allow the various native types
3923 here to return true, as they can be used like this:
3927 Fixed 49836 and all the other dups
3929 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
3931 * driver.cs: Implement /win32res and /win32icon.
3933 2004-01-08 Miguel de Icaza <miguel@ximian.com>
3935 * cs-parser.jay: Add a rule to improve error handling for the
3936 common mistake of placing modifiers after the type.
3938 2004-01-07 Miguel de Icaza <miguel@ximian.com>
3940 * cs-parser.jay (interface_event_declaration): Catch
3941 initialization of events on interfaces, and report cs0068
3943 * cs-parser.jay (interface_event_declaration): Catch
3944 initialization of events.
3946 * ecore.cs: Better report missing constructors.
3948 * expression.cs (Binary.ResolveOperator): My previous bug fix had
3949 the error reporting done in the wrong place. Fix.
3951 * expression.cs (Binary.ResolveOperator): Catch the
3952 operator + (E x, E y) error earlier, and later allow for implicit
3953 conversions in operator +/- (E e, U x) from U to the underlying
3956 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
3957 52596, if the container class is abstract, the default constructor
3958 is protected otherwise its public (before, we were always public).
3960 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
3963 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
3964 Jemlich that fixes bug #52597, MCS was generating invalid code for
3965 idisposable structs. Thanks to Ben for following up with this
3968 2004-01-06 Miguel de Icaza <miguel@ximian.com>
3970 * driver.cs: Allow assemblies without code to be generated, fixes
3973 2004-01-07 Nick Drochak <ndrochak@gol.com>
3975 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
3977 2004-01-05 Miguel de Icaza <miguel@ximian.com>
3979 * cs-parser.jay: Add rules to improve error reporting if fields or
3980 methods are declared at the namespace level (error 116)
3982 * Add rules to catch event add/remove
3984 2004-01-04 David Sheldon <dave-mono@earth.li>
3986 * expression.cs: Added matching ")" to error message for
3989 2004-01-03 Todd Berman <tberman@gentoo.org>
3991 * ecore.cs, attribute.cs:
3992 Applying fix from #52429.
3994 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
3996 * ecore.cs, expression.cs, statement.cs:
3997 Total rewrite of how we handle branching. We
3998 now handle complex boolean expressions with fewer
3999 jumps. As well if (x == 0) no longer emits a ceq.
4001 if (x is Foo) is much faster now, because we generate
4004 Overall, we get a pretty big improvement on our benchmark
4005 tests. The code we generate is smaller and more readable.
4007 I did a full two-stage bootstrap. The patch was reviewed
4008 by Martin and Miguel.
4010 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4012 * cs-parser.jay: Make primary_expression not take a QI.
4013 we dont need this because the member_access rule covers
4014 us here. So we replace the rule with just IDENTIFIER.
4016 This has two good effects. First, we remove a s/r conflict.
4017 Second, we allocate many fewer QualifiedIdentifier objects.
4019 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4021 * attribute.cs: Handle MarshalAs attributes as pseudo, and
4022 set the correct information via SRE. This prevents
4023 hanging on the MS runtime. Fixes #29374.
4025 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4027 * convert.cs: correctly handle conversions to value types
4028 from Enum and ValueType as unboxing conversions.
4030 Fixes bug #52569. Patch by Benjamin Jemlich.
4032 2004-01-02 Ravi Pratap <ravi@ximian.com>
4034 * expression.cs (BetterConversion): Prefer int -> uint
4035 over int -> ulong (csc's behaviour). This fixed bug #52046.
4037 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
4039 * decl.cs (MemberCache.FindMembers): now returns a
4042 * typemanager.cs: In general, go with with ^^.
4043 (CopyNewMethods): take an IList.
4044 (RealMemberLookup): Only allocate an arraylist
4045 if we copy from two sets of methods.
4047 This change basically does two things:
4048 1) Fewer array lists allocated due to CopyNewMethods.
4049 2) the explicit cast in MemberList costed ALOT.
4051 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
4053 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
4054 a hashtable to avoid needless string allocations when an identifier is
4055 used more than once (the common case).
4057 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4059 * pending.cs: MS's TypeBuilder.GetInterfaces ()
4060 is broken, it will not return anything. So, we
4061 have to use the information we have in mcs to
4064 * typemanager.cs: Add a cache for GetInterfaces,
4065 since this will now be used more often (due to ^^)
4067 (GetExplicitInterfaces) New method that gets the
4068 declared, not effective, interfaces on a type
4069 builder (eg, if you have interface IFoo, interface
4070 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
4073 This patch makes MCS able to bootstrap itself on
4076 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4078 * expression.cs: Remove the Nop's that Miguel put
4081 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4083 * report.cs, codegen.cs: Give the real stack trace to
4084 the error when an exception is thrown.
4086 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4088 * decl.cs: only allocate hashtables for ifaces if
4091 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4093 * expression.cs: fix the error from cs0121-2.cs
4094 (a parent interface has two child interfaces that
4095 have a function with the same name and 0 params
4096 and the function is called through the parent).
4098 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
4100 * class.cs, rootcontext.cs, typmanager.cs: do not
4103 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
4105 * codegen.cs: remove stack for the ec flow branching.
4106 It is already a linked list, so no need.
4108 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
4110 * Makefile: Allow custom profiler here.
4112 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4114 * typemanager.cs (LookupType):
4115 - Use a static char [], because split takes
4116 a param array for args, so it was allocating
4118 - Do not store true in a hashtable, it boxes.
4120 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4122 * flowanalysis.cs: bytify common enums.
4124 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4126 * modifiers.cs: Add a new set of flags for the
4127 flags allowed on explicit interface impls.
4128 * cs-parser.jay: catch the use of modifiers in
4129 interfaces correctly.
4130 * class.cs: catch private void IFoo.Blah ().
4132 All related to bug #50572.
4134 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4136 * decl.cs: Rewrite the consistant accessability checking.
4137 Accessability is not linear, it must be implemented in
4138 a tableish way. Fixes #49704.
4140 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4142 * expression.cs: Handle negation in a checked context.
4143 We must use subtraction from zero. Fixes #38674.
4145 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4147 * class.cs: Ignore static void main in DLLs.
4148 * rootcontext.cs: Handle the target type here,
4149 since we are have to access it from class.cs
4150 * driver.cs: account for the above.
4152 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4154 * report.cs: Give line numbers and files if available.
4156 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
4158 * driver.cs: Implement /addmodule.
4160 * typemanager.cs: Change 'modules' field so it now contains Modules not
4163 2003-12-20 Martin Baulig <martin@ximian.com>
4165 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
4166 (FieldBase.IsAssigned): Removed this field.
4167 (FieldBase.SetAssigned): New public method.
4168 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
4170 2003-12-20 Martin Baulig <martin@ximian.com>
4172 * expression.cs (LocalVariableReference.DoResolve): Don't set
4173 `vi.Used' if we're called from DoResolveLValue().
4175 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
4176 returns the usage vector it just merged into the current one -
4177 pass this one to UsageWarning().
4178 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
4179 of the `EmitContext', don't call this recursively on our children.
4181 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
4183 * driver.cs: Implement /target:module.
4185 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
4187 * support.cs (CharArrayHashtable): New helper class.
4189 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
4190 char arrays, not strings, so we can avoid creating a string in
4191 consume_identifier if the identifier is a keyword.
4193 2003-12-16 Martin Baulig <martin@ximian.com>
4195 * statement.cs (LocalInfo.Assigned): Removed this property.
4196 (LocalInfo.Flags): Removed `Assigned'.
4197 (LocalInfo.IsAssigned): New public method; takes the EmitContext
4198 and uses flow analysis.
4199 (Block.UsageWarning): Made this method private.
4200 (Block.Resolve): Call UsageWarning() if appropriate.
4202 * expression.cs (LocalVariableReference.DoResolve): Always set
4203 LocalInfo.Used here.
4205 2003-12-13 Martin Baulig <martin@ximian.com>
4207 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
4208 any value here; we're now using flow analysis to figure out
4209 whether a statement/block returns a value.
4211 2003-12-13 Martin Baulig <martin@ximian.com>
4213 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
4215 (FlowBranching.MergeFinally): Don't call
4216 `branching.CheckOutParameters()' here, this is called in
4218 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
4219 when adding the `finally' vector.
4221 2003-12-13 Martin Baulig <martin@ximian.com>
4224 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
4225 actually work and also fix #48962.
4227 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
4229 * decl.cs: Do not check System.Object for nested types,
4230 since we know it does not have any. Big bang for buck:
4235 corlib: 17.99 seconds
4239 corlib: 17.39 seconds
4241 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
4243 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
4244 time we are returning 0 members, so we save alot here.
4246 2003-12-11 Martin Baulig <martin@ximian.com>
4248 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
4249 `MergeChild()', also just take the `FlowBranching' as argument;
4250 call Merge() on it and return the result.
4251 (FlowBranching.Merge): We don't need to do anything if we just
4254 2003-12-11 Martin Baulig <martin@ximian.com>
4256 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
4257 them in an `ArrayList' to reduce memory usage. Thanks to Ben
4258 Maurer for this idea.
4260 2003-12-11 Martin Baulig <martin@ximian.com>
4262 * flowanalysis.cs (MergeResult): This class is now gone; we now
4263 use the `UsageVector' for this. The reason for this is that if a
4264 branching just has one sibling, we don't need to "merge" them at
4265 all - that's the next step to do.
4266 (FlowBranching.Merge): We now return a `UsageVector' instead of a
4269 2003-12-11 Martin Baulig <martin@ximian.com>
4271 Reworked flow analyis and made it more precise and bug-free. The
4272 most important change is that we're now using a special `Reachability'
4273 class instead of having "magic" meanings of `FlowReturns'. I'll
4274 do some more cleanups and optimizations and also add some more
4275 documentation this week.
4277 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
4278 largely reworked this class.
4279 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
4280 the new `Reachability' class instead of having "magic" values here.
4281 (FlowBranching): We're now using an instance of `Reachability'
4282 instead of having separate `Returns', `Breaks' etc. fields.
4284 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
4285 based on flow analysis; ignore the return value of block.Emit ().
4287 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
4289 * driver.cs typemanager.cs: Find the mono extensions to corlib even
4290 if they are private.
4292 2003-12-09 Martin Baulig <martin@ximian.com>
4294 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
4295 call them directly on the UsageVector.
4297 2003-12-09 Martin Baulig <martin@ximian.com>
4299 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
4300 Changed return type from `FlowReturns' to `Reachability'.
4302 2003-12-09 Martin Baulig <martin@ximian.com>
4304 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
4305 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
4306 `Reachable' fields with a single `Reachability' one.
4308 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4310 * class.cs (FindMembers): Remove foreach's.
4323 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4328 This patch does a few things:
4329 1. EmptyStatement is now a singleton, so it is never reallocated.
4330 2. All blah is EmptyStatement constructs have been changed to
4331 blah == EmptyStatement.Value, which is much faster and valid
4332 now that EmptyStatement is a singleton.
4333 3. When resolving a block, rather than allocating a new array for
4334 the non-empty statements, empty statements are replaced with
4335 EmptyStatement.Value
4336 4. Some recursive functions have been made non-recursive.
4337 Mainly the performance impact is from (3), however (1) and (2) are needed for
4338 this to work. (4) does not make a big difference in normal situations, however
4339 it makes the profile look saner.
4344 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4345 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4346 Total memory allocated: 56397 KB
4349 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
4350 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
4351 Total memory allocated: 55666 KB
4353 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4355 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
4356 than the hashtable in a hashtable version
4358 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
4359 we always end up concating a string. This results in a huge perf
4360 loss, because many strings have to be tracked by the GC. In this
4361 patch, we first use a hashtable that works with two keys, so that
4362 the strings do not need to be concat'ed.
4373 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4375 * Makefile: Add a new target `do-time' that does a quick and simple
4376 profile, leaving easy to parse output.
4378 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
4380 * codegen.cs (Init): Create the dynamic assembly with
4381 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
4383 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
4385 * support.cs: Make the PtrHashtable use only one
4386 instance of its comparer.
4388 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
4390 * typemanager.cs: Fix lookup of GetNamespaces.
4392 2003-11-29 Miguel de Icaza <miguel@ximian.com>
4394 * expression.cs: Removed redundant line.
4396 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
4397 ArrayLists, use for loops with bounds.
4399 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
4402 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
4403 arraylists, use for loop with bounds.
4405 The above three changes give us a 0.071 second performance
4406 improvement out of 3.294 seconds down to 3.223. On my machine
4407 the above changes reduced the memory usage by 1,387 KB during
4410 * cs-parser.jay (QualifiedIdentifier): New class used to represent
4411 QualifiedIdentifiers. Before we created a new string through
4412 concatenation, and mostly later on, the result would be
4413 manipulated by DecomposeQI through string manipulation.
4415 This reduced the compiler memory usage for bootstrapping from
4416 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
4417 compile times in 0.05 seconds.
4419 2003-11-28 Dick Porter <dick@ximian.com>
4421 * support.cs: Do string compares with the Invariant culture.
4429 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
4430 the comparison is done with the Invariant culture.
4432 2003-11-27 Miguel de Icaza <miguel@ximian.com>
4434 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
4435 GetEnumerator method.
4437 (ProbeCollectionType): Iterate starting at the most specific type
4438 upwards looking for a GetEnumerator
4440 * expression.cs: Shift count can be up to 31 for int/uint and 63
4443 2003-11-26 Miguel de Icaza <miguel@ximian.com>
4445 * statement.cs (Block.LookupLabel): Also look for the label on the
4446 children blocks. Use a hash table to keep track of visited
4449 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
4450 we actually did transform the other operand, otherwise fall back
4451 to the common codepath that casts to long.
4453 * cs-tokenizer.cs: Use the same code pattern as the int case.
4454 Maybe I should do the parsing myself, and avoid depending on the
4455 Parse routines to get this done.
4457 2003-11-25 Miguel de Icaza <miguel@ximian.com>
4459 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
4460 which fixes bug 51347. This time test it.
4462 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
4463 attributes for example can not tell the difference between these.
4464 The difference was only a syntax feature of the language.
4466 * attribute.cs: Apply attributes to delegates.
4468 * delegate.cs: Call the apply attributes method.
4470 2003-11-24 Miguel de Icaza <miguel@ximian.com>
4472 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
4473 comparing 0 vs Byte.MinValue, not the value
4475 (ImplicitConversionRequired): When reporting a conversion error,
4476 use error 31 to print out the constant error instead of the
4479 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
4480 which fixes bug 51347.
4482 2003-11-22 Miguel de Icaza <miguel@ximian.com>
4484 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
4485 which fixes the -warnaserror command line option.
4487 2003-11-21 Miguel de Icaza <miguel@ximian.com>
4489 * cfold.cs (DoNumericPromotions): During constant folding of
4490 additions on UIntConstant, special case intconstants with
4491 IntConstants like we do on the expression binary operator.
4493 2003-11-12 Miguel de Icaza <miguel@ximian.com>
4495 * convert.cs (ImplicitReferenceConversion): We were missing a case
4496 (System.Enum are not value types or class types, so we need to
4497 classify them separatedly).
4499 * driver.cs: We do not support error 2007.
4501 2003-11-12 Jackson Harper <jackson@ximian.com>
4503 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
4504 system directory. Also use the full file name so users can
4505 libraries names mscorlib-o-tron.dll in a non system dir.
4507 2003-11-10 Martin Baulig <martin@ximian.com>
4509 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
4510 (TypeManager.InitCoreTypes): Initialize them here, but instead of
4511 calling `ResolveType()' on them, directly assign their `Type'.
4513 2003-11-08 Martin Baulig <martin@ximian.com>
4515 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
4516 return value and the `out parent' parameter.
4517 (TypeContainer.DefineType): Moved the CS0644 check into
4518 GetClassBases(). Don't pass the interface types to the
4519 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
4520 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
4522 * ecore.cs (TypeExpr.IsAttribute): New property.
4523 (TypeExpr.GetInterfaces): New method.
4525 * interface.cs (Interface.GetInterfaceTypeByName): Return a
4526 TypeExpr instead of a Type.
4527 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
4528 (Interface.DefineType): Don't pass the interface types to the
4529 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
4530 them later and then call `TypeBulider.AddInterfaceImplementation()'.
4532 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
4533 instead of a `Type[]'.
4534 (TypeManager.RegisterBuilder): Likewise.
4535 (TypeManager.AddUserInterface): Likewise.
4536 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
4537 `Type[]' and also return a `TypeExpr[]'.
4538 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
4540 2003-11-08 Martin Baulig <martin@ximian.com>
4542 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
4545 2003-11-08 Martin Baulig <martin@ximian.com>
4547 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
4548 TypeManager.ResolveExpressionTypes().
4550 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
4551 instead of an Expression.
4552 (TypeExpr): This is now an abstract base class for `TypeExpression'.
4553 (TypeExpression): New public class; formerly known as `TypeExpr'.
4555 * expression.cs (ComposedCast): Derive from TypeExpr.
4557 * typemanager.cs (TypeManager.system_*_expr): These are now
4558 TypExpr's instead of Expression's.
4559 (TypeManager.ResolveExpressionTypes): New public static function;
4560 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
4563 2003-11-06 Miguel de Icaza <miguel@ximian.com>
4565 * expression.cs (New.DoResolve): Do not dereference value that
4566 might be a null return.
4568 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
4569 sure that the constant value has the right type. Fixes an
4570 unreported bug, similar to 50425.
4572 * const.cs (Const.LookupConstantValue): Call
4573 ImplicitStandardConversionExists before doing a conversion to
4574 avoid havng the TypeManager.ChangeType do conversions.
4576 Reduced the number of casts used
4578 (Const.ChangeType): New routine to enable reuse of the constant
4579 type changing code from statement.
4581 * typemanager.cs (ChangeType): Move common initialization to
4582 static global variables.
4586 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
4587 every value type to go through, even if it was void. Fix that.
4589 * cs-tokenizer.cs: Use is_identifier_start_character on the start
4590 character of the define, and the is_identifier_part_character for
4591 the rest of the string.
4593 2003-11-05 Miguel de Icaza <miguel@ximian.com>
4595 * expression.cs (UnaryMutator.EmitCode): When I updated
4596 LocalVariableReference.DoResolve, I overdid it, and dropped an
4597 optimization done on local variable references.
4599 2003-11-04 Miguel de Icaza <miguel@ximian.com>
4601 * ecore.cs: Convert the return from Ldlen into an int.
4603 2003-10-20 Miguel de Icaza <miguel@ximian.com>
4605 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
4606 the accessibility, this is a special case for toplevel non-public
4607 classes (internal for instance).
4609 2003-10-20 Nick Drochak <ndrochak@gol.com>
4611 * ecore.cs: Fix typo and build. Needed another right paren.
4613 2003-10-19 Miguel de Icaza <miguel@ximian.com>
4615 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
4616 `internal' case regular and protected, but not allowing protected
4617 to be evaluated later. Bug 49840
4619 2003-10-15 Miguel de Icaza <miguel@ximian.com>
4621 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
4622 to kb.Nlast, and not the kb.nFirst to isolate the switch
4625 Extract the underlying type, so enumerations of long/ulong are
4626 treated like long/ulong.
4628 2003-10-14 Miguel de Icaza <miguel@ximian.com>
4630 * expression.cs (New): Overload the meaning of RequestedType to
4631 track the possible creation of the NewDelegate type, since
4632 DoResolve is invoked more than once for new constructors on field
4635 See bugs: #48800 and #37014
4637 * cs-parser.jay (declare_local_constants): Take an arraylist
4638 instead of a single constant.
4640 (local_constant_declaration): It should take a
4641 constant_declarators, not a constant_declarator. Fixes 49487
4643 * convert.cs: Fix error report.
4645 2003-10-13 Jackson Harper <jackson@ximian.com>
4647 * typemanager.cs (TypeToCoreType): Add float and double this fixes
4650 2003-10-09 Martin Baulig <martin@ximian.com>
4652 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
4654 (MethodCore.DoDefineParameters): Removed the TypeContainer
4655 argument; use the DeclSpace which was passed to the .ctor instead.
4656 (MethodCore.CheckParameter): Take a DeclSpace instead of a
4657 TypeContainer; we only need a DeclSpace here.
4659 2003-10-09 Martin Baulig <martin@ximian.com>
4661 * class.cs (MethodData): Added additional `DeclSpace ds' argument
4663 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
4664 EmitContext's .ctor.
4666 2003-10-09 Martin Baulig <martin@ximian.com>
4668 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
4669 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
4670 AsAccessible(), moved them as well.
4672 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
4674 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
4676 * cs-parser.jay : Renamed yyName to yyNames related to jay.
4678 2003-10-07 Miguel de Icaza <miguel@ximian.com>
4680 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
4681 generation for >=, as spotted by Paolo, bug 48679.
4682 Patch from David Waite.
4684 * cs-tokenizer.cs: Add handling for #pragma.
4686 * cs-parser.jay: Allow for both yield and yield return in the
4687 syntax. The anti-cobolization of C# fight will go on!
4689 * class.cs (TypeBuilder.DefineType): Catch error condition here
4690 (Parent.DefineType erroring out and returning null).
4692 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
4693 coping with enumerations variables, we were mistakenly processing
4694 them as a regular value type instead of built-in types. Fixes the
4697 * typemanager.cs (IsBuiltinOrEnum): New method.
4699 2003-09-30 Miguel de Icaza <miguel@ximian.com>
4701 * cs-parser.jay: Upgrade: yield now needs the return clause.
4703 2003-09-19 Martin Baulig <martin@ximian.com>
4705 * decl.cs (MemberCache.SetupCacheForInterface): Take a
4706 `MemberCache parent' argument. Normally, an interface doesn't
4707 have a parent type except System.Object, but we use this in gmcs
4708 for generic type parameters.
4710 2003-09-18 Martin Baulig <martin@ximian.com>
4712 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
4713 on `type.IsInterface'; don't check whether the type has a parent
4714 to determine whether it's an interface.
4716 2003-09-15 Martin Baulig <martin@ximian.com>
4718 * class.cs (TypeContainer.DefineType): Added an error flag to
4719 avoid reporting duplicate CS0146's ("class definition is
4722 * driver.cs (Driver.MainDriver): Abort if
4723 RootContext.ResolveTree() reported any errors.
4725 2003-09-07 Martin Baulig <martin@ximian.com>
4727 * report.cs (Error, Warning): Added overloaded versions which take
4728 a `params object[] args' and call String.Format().
4730 2003-09-07 Martin Baulig <martin@ximian.com>
4732 * decl.cs (DeclSpace..ctor): Don't call
4733 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
4734 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
4735 (DeclSpace.RecordDecl): New method.
4737 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
4739 2003-09-02 Ravi Pratap <ravi@ximian.com>
4741 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
4742 value attributes to be applied to ParameterBuilders.
4744 * class.cs (MethodCore.LabelParameters): Make static and more
4745 generic so that it can be used from other places - like interface
4746 methods, for instance.
4748 * interface.cs (Interface.Emit): Call LabelParameters before
4749 emitting attributes on the InterfaceMethod.
4751 2003-08-26 Martin Baulig <martin@ximian.com>
4753 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
4754 resolving aliases; fixes #47927.
4756 2003-08-26 Martin Baulig <martin@ximian.com>
4758 * statement.cs (Using.DoResolve): This is internally emitting a
4759 try/finally clause, so we need to set ec.NeedExplicitReturn if we
4760 do not always return. Fixes #47681.
4762 2003-08-26 Martin Baulig <martin@ximian.com>
4764 * decl.cs (MemberCore): Moved WarningNotHiding(),
4765 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
4767 (AdditionResult): Make this nested in DeclSpace.
4768 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
4769 argument; call NamespaceEntry.Define() unless we're nested in a
4772 * namespace.cs (Namespace.DefineName): New public function. This
4773 is called from DeclSpace's .ctor to add
4774 (Namespace.Lookup): Include DeclSpaces in the lookup.
4776 * class.cs (Operator): Derive from MemberBase, not MemberCore.
4778 * const.cs (Const): Derive from MemberBase, not MemberCore.
4780 2003-08-25 Martin Baulig <martin@ximian.com>
4782 * convert.cs (Convert.ExplicitReferenceConversion): When
4783 converting from an interface type to a class, unbox if the target
4784 type is a struct type. Fixes #47822.
4786 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4788 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
4791 2003-08-22 Martin Baulig <martin@ximian.com>
4793 * class.cs (TypeManager.DefineType): When defining a nested type,
4794 call DefineType() on our parent; fixes #47801.
4796 2003-08-22 Martin Baulig <martin@ximian.com>
4798 * class.cs (MethodData.Define): While checking if a method is an
4799 interface implementation, improve the test a bit more to fix #47654.
4801 2003-08-22 Martin Baulig <martin@ximian.com>
4803 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
4804 correctly; fixes #47722.
4806 2003-08-22 Martin Baulig <martin@ximian.com>
4808 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
4809 LocalVariableReference, ensure it's not read-only. Fixes #47536.
4811 * statement.cs (Fixed.DoResolve): Make all variables read-only.
4813 2003-08-22 Martin Baulig <martin@ximian.com>
4815 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
4816 can only be assigned in static constructors. Fixes #47161.
4818 2003-08-22 Martin Baulig <martin@ximian.com>
4820 Rewrote and improved the flow analysis code.
4822 * flowbranching.cs (FlowBranching): Make this class abstract.
4823 (FlowBranching.CreateBranching): New static function to create a
4825 (FlowBranchingBlock, FlowBranchingException): New classes.
4826 (FlowBranching.UsageVector.Type): New public readonly field.
4827 (FlowBranching.UsageVector.Breaks): Removed the setter.
4828 (FlowBranching.UsageVector.Returns): Removed the setter.
4829 (FlowBranching.UsageVector): Added Break(), Return(),
4830 NeverReachable() and Throw() methods to modify the reachability.
4831 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
4832 done by FlowBranching.Merge().
4833 (FlowBranching.UsageVector.MergeChild): New method; merges the
4834 merge result into the current vector.
4835 (FlowBranching.Merge): New abstract method to merge a branching.
4837 2003-08-12 Martin Baulig <martin@ximian.com>
4839 * expression.cs (Indirection.CacheTemporaries): Create the
4840 LocalTemporary with the pointer type, not its element type.
4842 2003-08-10 Miguel de Icaza <miguel@ximian.com>
4844 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
4845 token was a keyword or not.
4847 Add `error' options where an IDENTIFIER was expected; Provide
4848 CheckToken and CheckIdentifierToken convenience error reporting
4851 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
4853 * decl.cs: Rename `NamespaceEntry Namespace' public field into
4854 NameSpaceEntry NameSpaceEntry.
4856 (LookupInterfaceOrClass): Avoid creating a full qualified name
4857 from namespace and name: avoid doing lookups when we know the
4858 namespace is non-existant. Use new Tree.LookupByNamespace which
4859 looks up DeclSpaces based on their namespace, name pair.
4861 * driver.cs: Provide a new `parser verbose' to display the
4862 exception thrown during parsing. This is turned off by default
4863 now, so the output of a failure from mcs is more graceful.
4865 * namespace.cs: Track all the namespaces defined in a hashtable
4868 (IsNamespace): New method
4870 2003-08-09 Miguel de Icaza <miguel@ximian.com>
4872 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
4873 we know that we need to concatenate (full typename can never be
4878 * statement.cs: Use a bitfield; Do not initialize to null things
4879 which are done by the constructor by default.
4881 * cs-parser.jay: bug fix, parameter was 4, not 3.
4883 * expression.cs: Just use the property;
4885 * statement.cs: No need for GetVariableInfo method.
4887 2003-08-08 Martin Baulig <martin@ximian.com>
4889 * flowanalysis.cs (FlowReturns): This is now nested in the
4890 `FlowBranching' class.
4891 (MyBitVector): Moved this here from statement.cs.
4892 (FlowBranching.SiblingType): New enum type.
4893 (FlowBranching.CreateSibling): Added `SiblingType' argument.
4895 2003-08-07 Martin Baulig <martin@ximian.com>
4897 * flowanalysis.cs (FlowBranchingType): This is now nested in the
4898 `FlowBranching' class and called `BranchingType'.
4900 2003-08-07 Martin Baulig <martin@ximian.com>
4902 * flowanalysis.cs: Moved all the control flow analysis code into
4905 2003-08-07 Martin Baulig <martin@ximian.com>
4907 * assign.cs (Assign.DoResolve): `target' must either be an
4908 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
4911 2003-08-07 Miguel de Icaza <miguel@ximian.com>
4913 * expression.cs (BinaryMethod): This kind of expression is created by the
4914 Binary class if it determines that the operator has to be handled
4917 (BinaryDelegate): This kind of expression is created if we are
4918 dealing with a + or - operator on delegates.
4920 (Binary): remove method, argumetns, and DelegateOperator: when
4921 dealing with methods,
4923 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
4925 * statement.cs (Block): use bitfields for the three extra booleans
4926 we had in use. Remove unused topblock parameter.
4928 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
4930 * assign.cs: Drop extra unneeded tests.
4932 2003-08-06 Miguel de Icaza <miguel@ximian.com>
4934 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
4936 * statement.cs (Foreach): Use VariableStorage instead of
4939 * codegen.cs (VariableStorage): New class used by clients that
4940 require a variable stored: locals or fields for variables that
4941 need to live across yield.
4943 Maybe provide a convenience api for EmitThis+EmitLoad?
4945 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
4948 2003-08-05 Miguel de Icaza <miguel@ximian.com>
4950 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
4951 RemapParameterLValue): New methods that are used to turn a
4952 precomputed FieldInfo into an expression like this:
4956 The idea is to use this instead of making LocalVariableReference
4957 have more than one meaning.
4959 * cs-parser.jay: Add error production to BASE.
4961 * ecore.cs: Deal with TypeManager.GetField returning null, which
4962 is now a valid return value.
4964 (FieldExprNoAddress): New expression for Fields whose address can
4967 * expression.cs (LocalVariableReference): During the resolve
4968 phases, create new expressions if we are in a remapping context.
4969 Remove code that dealt with remapping here.
4971 (ParameterReference): same.
4973 (ProxyInstance): New expression, like the `This' expression, but
4974 it is born fully resolved. We know what we are doing, so remove
4975 the errors that are targeted to user-provided uses of `this'.
4977 * statement.cs (Foreach): our variable is now stored as an
4978 Expression; During resolution, follow the protocol, dont just
4979 assume it will return this.
4981 2003-08-06 Martin Baulig <martin@ximian.com>
4983 * support.cs (SeekableStreamReader.cs): New public class.
4985 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
4986 SeekableStreamReader instead of the normal StreamReader.
4988 2003-08-04 Martin Baulig <martin@ximian.com>
4990 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
4991 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
4992 deambiguate casts and delegate invocations.
4993 (parenthesized_expression): Use the new tokens to ensure this is
4994 not a cast of method invocation.
4996 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
4997 when reading a `)' and Deambiguate_CloseParens () was previously
5000 * expression.cs (ParenthesizedExpression): New class. This is
5001 just used for the CS0075 test.
5002 (Binary.DoResolve): Check for CS0075.
5004 2003-07-29 Ravi Pratap <ravi@ximian.com>
5006 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
5007 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
5008 reference comparison.
5010 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
5011 examine the ReturnType for equality - this is necessary in the
5012 cases of implicit and explicit operators whose signature also
5013 includes the return type.
5015 2003-07-26 Miguel de Icaza <miguel@ximian.com>
5017 * namespace.cs: Cache the result of the namespace computation,
5018 instead of computing it every time.
5020 2003-07-24 Miguel de Icaza <miguel@ximian.com>
5022 * decl.cs: Use a global arraylist that we reuse over invocations
5023 to avoid excesive memory consumption. Reduces memory usage on an
5024 mcs compile by one meg (45 average).
5026 * typemanager.cs (LookupTypeReflection): In .NET pointers are
5027 private, work around that.
5029 2003-07-23 Miguel de Icaza <miguel@ximian.com>
5031 * literal.cs (IntLiteral): Define Zero and One static literals.
5033 * cs-parser.jay (integer_literal): use static literals to reduce
5034 memory usage for the most used literals (0, 1 and -1). 211kb
5035 reduced in memory usage.
5037 Replace all calls to `new ArrayList' with `new
5038 ArrayList(4)' which is a good average number for most allocations,
5039 and also requires only 16 bytes of memory for its buffer by
5042 This reduced MCS memory usage in seven megabytes for the RSS after
5045 2003-07-28 Ravi Pratap <ravi@ximian.com>
5047 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
5048 handle params methods the correct way by forming only one
5049 applicable set with params and normal methods in them. Earlier we
5050 were looking at params methods only if we found no normal methods
5051 which was not the correct thing to do.
5053 (Invocation.BetterFunction): Take separate arguments indicating
5054 when candidate and the best method are params methods in their
5057 This fixes bugs #43367 and #46199.
5059 * attribute.cs: Documentation updates.
5061 (CheckAttribute): Rename to CheckAttributeTarget.
5062 (GetValidPlaces): Rename to GetValidTargets.
5064 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
5065 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
5069 2003-07-28 Martin Baulig <martin@ximian.com>
5071 * class.cs (TypeContainer.DefineMembers): Use the base type's full
5072 name when looking up the base class of a nested class. Fixes #46977.
5074 2003-07-26 Martin Baulig <martin@ximian.com>
5076 * expression.cs (Indexers.Indexer): New nested struct; contains
5077 getter, setter and the indexer's type.
5078 (Indexers.Properties): This is now an ArrayList of
5080 (IndexerAccess.DoResolveLValue): Correctly set the type if the
5081 indexer doesn't have any getters.
5083 * assign.cs (Assign.DoResolve): Also do the implicit conversions
5084 for embedded property and indexer assignments.
5086 2003-07-26 Martin Baulig <martin@ximian.com>
5088 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
5089 preprocessor directive is not the first non-whitespace character
5092 2003-07-26 Martin Baulig <martin@ximian.com>
5094 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
5095 namespace parsing, follow the spec more closely.
5097 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
5098 NamespaceEntry.Lookup().
5100 2003-07-25 Martin Baulig <martin@ximian.com>
5102 * MethodCore.cs (OverridesSomething): New public field; it's set
5103 from TypeContainer.DefineMembers if this method overrides
5104 something (which doesn't need to be a method). Fix #39462.
5106 2003-07-25 Ravi Pratap <ravi@ximian.com>
5108 * typemanager.cs (GetMembers): Ensure that the list of members is
5109 reversed. This keeps things in sync.
5111 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
5112 find an AttributeUsage attribute.
5114 * expression.cs (Invocation.OverloadResolve): Perform the check
5115 which disallows Invoke to be directly called on a Delegate.
5117 (Error_InvokeOnDelegate): Report error cs1533.
5119 2003-07-25 Martin Baulig <martin@ximian.com>
5121 * expression.cs (Indexers.GetIndexersForType): Only look in the
5122 interface hierarchy if the requested type is already an
5123 interface. Fixes #46788 while keeping #46502 fixed.
5125 2003-07-25 Martin Baulig <martin@ximian.com>
5127 * class.cs (TypeContainer.DefineMembers): Check whether all
5128 readonly fields have been assigned and report warning CS0649 if
5131 * statement.cs (LocalInfo.IsFixed): Always return true if this is
5134 2003-07-24 Ravi Pratap <ravi@ximian.com>
5136 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
5137 returned from GetMethods to make things consistent with the
5138 assumptions MCS makes about ordering of methods.
5140 This should comprehensively fix bug #45127 and it does :-)
5142 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
5143 ordering is actually reverse.
5145 * Clean up some debug messages I left lying around.
5147 * interface.cs (Populate*): Get rid of code which emits attributes
5148 since the stage in which we emit attributes is the 'Emit' stage,
5149 not the define stage.
5151 (Emit): Move attribute emission for interface members here.
5153 2003-07-22 Ravi Pratap <ravi@ximian.com>
5155 * expression.cs (Invocation.OverloadResolve): Follow the spec more
5156 closely: we eliminate methods in base types when we have an
5157 applicable method in a top-level type.
5159 Please see section 14.5.5.1 for an exact description of what goes
5162 This fixes bug #45127 and a host of other related to corlib compilation.
5164 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
5165 array is the method corresponding to the top-level type (this is
5166 because of the changes made to icall.c) so we change this
5169 (MethodGroupExpr.Name): This too.
5171 * typemanager.cs (GetElementType): New method which does the right
5172 thing when compiling corlib.
5174 * everywhere: Make use of the above in the relevant places.
5176 2003-07-22 Martin Baulig <martin@ximian.com>
5178 * cs-parser.jay (invocation_expression): Moved
5179 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
5180 `cast_expression', but create a InvocationOrCast which later
5181 resolves to either an Invocation or a Cast.
5183 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
5184 method; call this before EmitStatement() to make sure that this
5185 expression can be used as a statement.
5187 * expression.cs (InvocationOrCast): New class; resolves to either
5188 an Invocation or a Cast.
5190 * statement.cs (StatementExpression): Call ResolveStatement() on
5191 the ExpressionStatement before emitting it.
5193 2003-07-21 Martin Baulig <martin@ximian.com>
5195 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
5196 `ref' and `out' attributes match; fixes #46220.
5197 (MemberAccess.ResolveMemberAccess): You can't reference a type
5198 through an expression; fixes #33180.
5199 (Indexers.GetIndexersForType): Don't return the indexers from
5200 interfaces the class implements; fixes #46502.
5202 2003-07-21 Martin Baulig <martin@ximian.com>
5204 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
5205 CS0661 checks; fixes bug #30442.
5207 2003-07-21 Martin Baulig <martin@ximian.com>
5209 * decl.cs (AdditionResult): Added `Error'.
5211 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
5213 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
5214 makes cs0031.cs actually work.
5216 2003-07-20 Martin Baulig <martin@ximian.com>
5218 * namespace.cs: Fixed that bug which caused a crash when compiling
5221 2003-07-20 Miguel de Icaza <miguel@ximian.com>
5223 * typemanager.cs (LookupTypeReflection): Never expose types which
5224 are NotPublic, NestedPrivate, NestedAssembly, or
5225 NestedFamANDAssem. We used to return these, and later do a check
5226 that would report a meaningful error, but the problem is that we
5227 would not get the real match, if there was a name override.
5229 2003-07-18 Miguel de Icaza <miguel@ximian.com>
5231 * namespace.cs (Namespace, Name): Do not compute the namespace
5232 name dynamically, compute it in the constructor. This reduced
5233 memory usage by 1697 KB.
5235 * driver.cs: Use --pause to pause at the end.
5237 2003-07-17 Peter Williams <peter@newton.cx>
5239 * Makefile: Change the name of the test target so that it doesn't
5240 conflict with the recursive test target.
5242 2003-07-17 Miguel de Icaza <miguel@ximian.com>
5244 * expression.cs (LocalVariableReference.Emit, EmitAssign,
5245 AddressOf): Do not use EmitThis, that was wrong, use the actual
5248 2003-07-15 Miguel de Icaza <miguel@ximian.com>
5250 * class.cs (MethodData.Define): While checking if a method is an
5251 interface implementation, improve the test: If we are not public
5252 (use new test here: use the computed MethodAttributes directly,
5253 instead of the parsed modifier flags) check if the `implementing'
5254 method comes from an interface or not.
5256 * pending.cs (VerifyPendingMethods): Slightly better error
5259 * makefile: add test target that does the mcs bootstrap.
5261 2003-07-16 Ravi Pratap <ravi@ximian.com>
5263 * interface.cs (Define): Do nothing here since there are no
5264 members to populate etc. Move the attribute emission out of here
5265 since this was just totally the wrong place to put it. Attribute
5266 application happens during the 'Emit' phase, not in the 'Define'
5269 (Emit): Add this method and move the attribute emission here
5271 * rootcontext.cs (EmitCode): Call the Emit method on interface
5274 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5276 * expression.cs (OverloadResolve): Report error only if Location
5277 is not 'Null' which means that there was a probe going on.
5279 2003-07-14 Martin Baulig <martin@ximian.com>
5281 * expression.cs (ConditionalLogicalOperator): New public class to
5282 implement user defined conditional logical operators.
5283 This is section 14.11.2 in the spec and bug #40505.
5285 2003-07-14 Martin Baulig <martin@ximian.com>
5287 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
5289 2003-07-14 Martin Baulig <martin@ximian.com>
5291 * codegen.cs (EmitContext.InFixedInitializer): New public field.
5293 * ecore.cs (IVariable.VerifyFixed): New interface method.
5295 * expression.cs (Unary.ResolveOperator): When resolving the `&'
5296 operator, check whether the variable is actually fixed. Fixes bug
5297 #36055. Set a variable definitely assigned when taking its
5298 address as required by the spec.
5300 * statement.cs (LocalInfo.IsFixed): New field.
5301 (LocalInfo.MakePinned): Set `IsFixed' to true.
5303 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5305 * attribute.cs (Attribute.Resolve): While doing a Member lookup
5306 for .ctors, ensure that we only ask for members declared in the
5307 attribute type (BindingFlags.DeclaredOnly).
5311 * expression.cs (Error_WrongNumArguments): Report error 1501
5312 correctly the way CSC does.
5314 2003-07-13 Martin Baulig <martin@ximian.com>
5316 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
5317 lookup on the fully qualified name, to make things like "X.X" work
5318 where "X.X" is a fully qualified type name, but we also have a
5319 namespace "X" in the using list. Fixes #41975.
5321 2003-07-13 Martin Baulig <martin@ximian.com>
5323 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
5324 function. If we're a CompoundAssign, we need to create an embedded
5325 CompoundAssign, not an embedded Assign.
5326 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
5329 2003-07-13 Martin Baulig <martin@ximian.com>
5331 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
5332 work to fix bug #46088.
5334 2003-07-13 Ravi Pratap <ravi@ximian.com>
5336 * class.cs (Operator.Emit): Do not emit attributes here - it is
5337 taken care of by the Method class that we delegate too. This takes
5340 2003-07-10 Martin Baulig <martin@ximian.com>
5342 * expression.cs (TypeOfVoid): New class.
5343 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
5345 2003-07-10 Martin Baulig <martin@ximian.com>
5347 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
5350 2003-07-10 Martin Baulig <martin@ximian.com>
5352 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
5353 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
5355 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
5357 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
5359 2003-07-10 Martin Baulig <martin@ximian.com>
5361 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
5362 of decimal. Fixes #42850.
5364 NOTE: I also fixed the created byte blob, but this doesn't work on
5365 the MS runtime and csc never produces any byte blobs for decimal
5368 2003-07-10 Martin Baulig <martin@ximian.com>
5370 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
5371 structs; fixes #32068.
5372 (Block.AddChildVariableNames): Fixed #44302.
5374 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5376 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
5378 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5380 * attribute.cs: And this test is onger needed.
5382 2003-07-08 Martin Baulig <martin@ximian.com>
5384 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
5385 inaccessible types. Fixes #36313.
5387 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
5389 * namespace.cs (NamespaceEntry): Create implicit entries for all
5390 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
5391 implicit entries for N1.N2 and N1.
5393 2003-07-08 Martin Baulig <martin@ximian.com>
5395 Rewrote the handling of namespaces to fix a lot of the issues
5396 wrt. `using' aliases etc.
5398 * namespace.cs (Namespace): Splitted this class into a
5399 per-assembly `Namespace' and a per-file `NamespaceEntry'.
5401 * typemanager.cs (TypeManager.IsNamespace): Removed.
5402 (TypeManager.ComputeNamespaces): Only compute namespaces from
5403 loaded assemblies here, not the namespaces from the assembly we're
5404 currently compiling.
5406 2003-07-08 Martin Baulig <martin@ximian.com>
5408 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
5410 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5412 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
5415 I thought about the memory savings here, but LookupTypeReflection
5416 is used under already very constrained scenarios. Compiling
5417 corlib or mcs only exposes one hit, so it would not really reduce
5418 any memory consumption.
5420 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5422 * typemanager.cs: fixes bug #45889 by only adding public types from
5423 other assemblies to the list of known types.
5425 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5427 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
5428 on the type we resolved.
5430 2003-07-05 Martin Baulig <martin@ximian.com>
5432 * pending.cs (PendingImplementation.ParentImplements): Don't
5433 create the proxy if the parent is abstract.
5435 * class.cs (TypeContainer.DefineIndexers): Process explicit
5436 interface implementations first. Fixes #37714.
5438 2003-07-04 Miguel de Icaza <miguel@ximian.com>
5440 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
5441 defined recursively; but since we modify the input parameters
5442 (left is set to `this' temporarily), we reset this value if the
5443 left_is_explicit is false, which gives the original semantics to
5446 * literal.cs (NullPointer): new class used to represent a null
5447 literal in a pointer context.
5449 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
5450 type is a pointer, use a NullPointer object instead of a
5451 NullLiteral. Closes 43687
5453 (ExplicitConversion): Convert pointer values using
5454 the conv opcode to the proper type.
5456 * ecore.cs (New): change ValueTypeVariable property into a method,
5457 that returns whether the valuetype is suitable for being used.
5459 * expression.cs (Binary.DoNumericPromotions): Only return if we
5460 the int constant was a valid uint, and we can return both left and
5461 right as uints. If not, we continue processing, to trigger the
5462 type conversion. This fixes 39018.
5464 * statement.cs (Block.EmitMeta): During constant resolution, set
5465 the CurrentBlock property on the emitcontext, so that we resolve
5466 constants propertly.
5468 2003-07-02 Martin Baulig <martin@ximian.com>
5470 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
5471 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
5473 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
5474 than emitting it here.
5476 * statement.cs: Fixed some more flow analysis bugs.
5478 2003-07-02 Martin Baulig <martin@ximian.com>
5480 * class.cs (MethodData.Define): When implementing interface
5481 methods, set Final unless we're Virtual.
5483 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
5484 check work for interface methods.
5486 2003-07-01 Martin Baulig <martin@ximian.com>
5488 * ecore.cs (EmitContext.This): Replaced this property with a
5489 GetThis() method which takes a Location argument. This ensures
5490 that we get the correct error location for a CS0188.
5492 2003-07-01 Miguel de Icaza <miguel@ximian.com>
5494 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
5495 ImplicitStandardConversion.
5497 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
5499 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
5501 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
5504 2003-06-30 Miguel de Icaza <miguel@ximian.com>
5506 * class.cs (Constructor.Define): Turn off initlocals for unsafe
5509 (MethodData.Define): Turn off initlocals for unsafe methods.
5511 2003-06-29 Miguel de Icaza <miguel@ximian.com>
5513 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
5514 complete; Fixes #37521.
5516 * delegate.cs: Use Modifiers.TypeAttr to compute the
5517 TypeAttributes, instead of rolling our own. This makes the flags
5518 correct for the delegates.
5520 2003-06-28 Miguel de Icaza <miguel@ximian.com>
5522 * class.cs (Constructor.Define): Set the private flag for static
5523 constructors as well.
5525 * cs-parser.jay (statement_expression): Set the return value to
5526 null, to avoid a crash when we catch an error.
5528 2003-06-24 Miguel de Icaza <miguel@ximian.com>
5530 * cs-parser.jay: Applied patch from Jackson that adds support for
5531 extern and unsafe modifiers to destructor declarations.
5533 * expression.cs: Report error 21 if the user is trying to index a
5536 * driver.cs: Add an error message, suggested by the bug report.
5538 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
5539 if we do not have a ": this ()" constructor initializer. Fixes 45149
5541 2003-06-14 Miguel de Icaza <miguel@ximian.com>
5543 * namespace.cs: Add some information to reduce FAQs.
5545 2003-06-13 Miguel de Icaza <miguel@ximian.com>
5547 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
5548 underlying enumeration types. Fixes #43915.
5550 * expression.cs: Treat ushort/short as legal values to be used in
5553 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
5555 * delegate.cs: transfer custom attributes for paramenters from
5556 the delegate declaration to Invoke and BeginInvoke.
5558 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
5560 * attribute.cs: handle custom marshalers and emit marshal info
5563 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
5565 * makefile.gnu: Added anonymous.cs to the compiler sources.
5567 2003-05-28 Miguel de Icaza <miguel@ximian.com>
5569 * iterators.cs: Change the name of the proxy class to include two
5572 * cs-parser.jay: Update grammar to include anonymous methods.
5574 * anonymous.cs: new file.
5576 2003-05-27 Miguel de Icaza <miguel@ximian.com>
5578 * class.cs (Field.Define): Add missing test for pointers and
5581 2003-05-27 Ravi Pratap <ravi@ximian.com>
5583 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
5584 we use the stobj opcode.
5586 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
5587 since it wasn't the correct fix.
5589 It still is puzzling that we are required to use stobj for IntPtr
5590 which seems to be a ValueType.
5592 2003-05-26 Miguel de Icaza <miguel@ximian.com>
5594 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
5595 during regular simple name resolution. Now, the trick is that
5596 instead of returning for processing the simplename, we do a
5597 TypeManager.LookupType (ie, a rooted lookup as opposed to a
5598 contextual lookup type). If a match is found, return that, if
5599 not, return for further composition.
5601 This fixes long-standing 30485.
5603 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5604 using the address to initialize an object, do an Stobj instead of
5605 using the regular Stelem.
5607 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
5608 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
5609 Because if we are a BaseIndexerAccess that value will be true.
5612 * statement.cs (GotoCase.Resolve): Return after reporting an
5613 error, do not attempt to continue.
5615 * expression.cs (PointerArithmetic.Emit): If our operand is a
5616 long, convert our constants to match the operand before
5617 multiplying. Convert to I type before adding. Fixes 43670.
5619 2003-05-14 Ravi Pratap <ravi@ximian.com>
5621 * enum.cs (ImplicitConversionExists) : Rename to
5622 ImplicitEnumConversionExists to remove ambiguity.
5624 * ecore.cs (NullCast): New type of cast expression class which
5625 basically is very similar to EmptyCast with the difference being
5626 it still is a constant since it is used only to cast a null to
5630 * convert.cs (ImplicitReferenceConversion): When casting a null
5631 literal, we return a NullCast.
5633 * literal.cs (NullLiteralTyped): Remove - I don't see why this
5634 should be around anymore.
5636 The renaming (reported was slightly wrong). Corrections:
5638 ConvertImplicitStandard -> ImplicitConversionStandard
5639 ConvertExplicitStandard -> ExplicitConversionStandard
5641 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
5642 before passing them in !
5644 * convert.cs (ImplicitConversionStandard): When comparing for
5645 equal expr and target types, ensure that expr is not a
5648 In general, we must not be checking (expr_type ==
5649 target_type) in the top level conversion methods
5650 (ImplicitConversion, ExplicitConversion etc). This checking is
5651 done in the methods that they delegate to.
5653 2003-05-20 Miguel de Icaza <miguel@ximian.com>
5655 * convert.cs: Move Error_CannotConvertType,
5656 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
5657 ImplicitNumericConversion, ImplicitConversionExists,
5658 ImplicitUserConversionExists, StandardConversionExists,
5659 FindMostEncompassedType, FindMostSpecificSource,
5660 FindMostSpecificTarget, ImplicitUserConversion,
5661 ExplicitUserConversion, GetConversionOperators,
5662 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
5663 TryImplicitIntConversion, Error_CannotConvertImplicit,
5664 ConvertImplicitRequired, ConvertNumericExplicit,
5665 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
5666 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
5669 Perform the following renames:
5671 StandardConversionExists -> ImplicitStandardConversionExists
5672 ConvertImplicit -> ImplicitConversion
5673 ConvertImplicitStandard -> ImplicitStandardConversion
5674 TryImplicitIntConversion -> ImplicitIntConversion
5675 ConvertImplicitRequired -> ImplicitConversionRequired
5676 ConvertNumericExplicit -> ExplicitNumericConversion
5677 ConvertReferenceExplicit -> ExplicitReferenceConversion
5678 ConvertExplicit -> ExplicitConversion
5679 ConvertExplicitStandard -> ExplicitStandardConversion
5681 2003-05-19 Martin Baulig <martin@ximian.com>
5683 * statement.cs (TypeInfo.StructInfo): Made this type protected.
5684 (TypeInfo): Added support for structs having structs as fields.
5686 * ecore.cs (FieldExpr): Implement IVariable.
5687 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
5688 VariableInfo for the field.
5690 2003-05-18 Martin Baulig <martin@ximian.com>
5692 * expression.cs (This.DoResolve): Report a CS0027 if we're
5693 emitting a field initializer.
5695 2003-05-18 Martin Baulig <martin@ximian.com>
5697 * expression.cs (This.ResolveBase): New public function.
5698 (This.DoResolve): Check for CS0188.
5700 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
5703 * ecore.cs (MethodGroupExpr.DoResolve): Set the
5704 `instance_expression' to null if we don't have any non-static
5707 2003-05-18 Martin Baulig <martin@ximian.com>
5709 Reworked the way how local variables and parameters are handled by
5710 the flow analysis code.
5712 * statement.cs (TypeInfo, VariableMap): New public classes.
5713 (VariableInfo): New public class. This is now responsible for
5714 checking whether a variable has been assigned. It is used for
5715 parameters and local variables.
5716 (Block.EmitMeta): Take the InternalParameters as argument; compute
5717 the layout of the flow vectors here.
5718 (Block.LocalMap, Block.ParameterMap): New public properties.
5719 (FlowBranching): The .ctor doesn't get the InternalParameters
5720 anymore since Block.EmitMeta() now computes the layout of the flow
5722 (MyStructInfo): This class is now known as `StructInfo' and nested
5723 in `TypeInfo'; we don't access this directly anymore.
5725 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
5726 property and removed IsAssigned(), IsFieldAssigned(),
5727 SetAssigned() and SetFieldAssigned(); we now call them on the
5728 VariableInfo so we don't need to duplicate this code everywhere.
5730 * expression.cs (ParameterReference): Added `Block block' argument
5732 (LocalVariableReference, ParameterReference, This): The new
5733 VariableInfo class is now responsible for all the definite
5736 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
5737 IsParameterAssigned, SetParameterAssigned): Removed.
5739 2003-05-18 Martin Baulig <martin@ximian.com>
5741 * typemanager.cs (InitCoreTypes): Try calling
5742 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
5743 the 3-args-version. Corlib now also needs our `void_type'.
5744 (GetMethod): Added overloaded version which takes an optional
5745 `bool report_errors' to allow lookups of optional methods.
5747 2003-05-12 Martin Baulig <martin@ximian.com>
5749 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
5750 only used for locals and not for parameters.
5752 2003-05-12 Miguel de Icaza <miguel@ximian.com>
5754 * support.cs (InternalParameters.ParameterType): Return the
5755 ExternalType of the parameter.
5757 * parameter.cs (Parameter.ExternalType): drop the two arguments,
5760 2003-05-11 Miguel de Icaza <miguel@ximian.com>
5762 * class.cs (MethodData.Define): Do not set the `newslot' on
5763 interface members, if they are also flagged as "override".
5765 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
5766 better code for ++i and i++. This only works for static fields
5767 and local variables.
5769 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
5770 want to pull the DeclSpace out of the builder_to_declspace instead
5771 of the TypeBuilder (like in TypeContainer.FindMembers).
5773 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
5774 instead of LookupTypeContainer. Fixes the crash on .NET for
5775 looking up interface members.
5777 * const.cs: Create our own emit context during the Definition
5778 stage, so that constants are evaluated in the proper context, when
5779 a recursive definition happens.
5781 2003-05-11 Martin Baulig <martin@ximian.com>
5783 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
5784 new block for a switch section.
5785 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
5786 the adding/lookup in the switch block. Fixes #39828.
5788 2003-05-09 Miguel de Icaza <miguel@ximian.com>
5790 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
5791 functionality: I needed to convert the data after I had performed
5792 the add/sub operation into the operands type size.
5794 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
5795 pass the type for the box operation, otherwise the resulting
5796 object would have been of type object.
5798 (BoxedCast): Add constructor to specify the type to box as.
5800 2003-05-07 Miguel de Icaza <miguel@ximian.com>
5802 * iterators.cs: I was reusing the `count' variable inadvertently,
5803 take steps to not allow this to happen.
5805 2003-05-06 Miguel de Icaza <miguel@ximian.com>
5807 * attribute.cs (Attribute.Resolve): Params attributes are encoded
5808 by creating an array at the point where the params starts and
5809 putting all those arguments there, then adjusting the size of the
5812 2003-05-05 Miguel de Icaza <miguel@ximian.com>
5814 * expression.cs (New.AddressOf): Implement interface
5815 IMemoryLocation. This is used when the `new' operator is used in
5816 the context of an invocation to a method on a value type.
5818 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
5821 * namespace.cs: Also check the using aliases here.
5823 * driver.cs: Move the test for using validity after the types have
5824 been entered, so we do a single pass that also includes the using
5827 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
5828 in the regular case. CreateSiblingForFinally is doing extra
5831 * attribute.cs (GetAttributeArgumentExpression): Store the result
5832 on an out value, and use the return value to indicate failure
5833 instead of using null (which is a valid return for Constant.GetValue).
5835 * statement.cs: Perform the analysis flow for the increment
5836 portion after the statement, because this will be the real flow of
5837 execution. Fixes #42385
5839 * codegen.cs (EmitContext.EmitArgument,
5840 EmitContext.EmitStoreArgument): New helper functions when the
5841 RemapToProxy flag is set.
5843 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
5846 Add support for remapping parameters.
5848 * iterators.cs: Propagate parameter values; Store parameter
5849 values in the proxy classes.
5851 2003-05-04 Miguel de Icaza <miguel@ximian.com>
5853 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
5854 need a proxy reference; I do not know what I was thinking
5856 * cs-parser.jay (constructor_initializer): catch another error,
5857 and display nice message.
5859 (field_declaration): catch void field declaration
5860 to flag a better error.
5862 * class.cs (MemberBase.CheckBase): Report an error instead of a
5863 warning if a new protected member is declared in a struct.
5864 (Field.Define): catch the error of readonly/volatile.
5866 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
5868 (FieldExpr.AddressOf): ditto. Catch error where the address of a
5869 volatile variable is taken
5871 2003-05-02 Miguel de Icaza <miguel@ximian.com>
5873 * statement.cs (Fixed.Resolve): Report an error if we are not in
5876 2003-05-01 Miguel de Icaza <miguel@ximian.com>
5878 * typemanager.cs: reuse the code that handles type clashes for
5879 delegates and enumerations.
5881 * class.cs (Report28): Always report.
5883 * expression.cs (EncodeAsAttribute): Allow nulls here.
5885 2003-04-28 Miguel de Icaza <miguel@ximian.com>
5887 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
5888 the functionality for testing whether an expression is valid for
5889 an attribute here. Also handle the case of arrays of elements
5892 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
5893 encoding a linear array into an array of objects that are suitable
5894 to be passed to an CustomAttributeBuilder.
5896 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
5898 * ecore.cs: (FieldExpr): Handle field remapping here.
5900 * iteratators.cs: Pass the instance variable (if the method is an
5901 instance method) to the constructors, so we can access the field
5902 variables on the class.
5904 TODO: Test this with structs. I think the THIS variable on
5905 structs might have to be a pointer, and not a refenrece
5907 2003-04-27 Miguel de Icaza <miguel@ximian.com>
5909 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
5910 local variables to fields in a proxy class.
5912 * iterators.cs (PopulateProxy): Rename our internal fields to
5914 Create a <THIS> field if we are an instance method, so we can
5915 reference our parent container variables.
5916 (MapVariable): Called back from the EmitContext code to enter a
5917 new variable to field mapping into the proxy class (we just create
5921 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
5922 for using the remapped locals to fields.
5924 I placed the code here, because that gives the same semantics to
5925 local variables, and only changes the Emit code.
5927 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
5928 statements inside iterators.
5929 (VariableInfo): Add a FieldBuilder for the cases when we are
5930 remapping local variables to fields in a proxy class
5932 * ecore.cs (SimpleNameResolve): Avoid testing two times for
5933 current_block != null.
5935 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
5936 not cope with strings, as it has been moved to the
5937 TableSwitchEmit. Fixed bug in switch generation.
5939 * expression.cs (New.DoResolve): Provide more context for the user
5940 when reporting an error.
5942 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
5945 * expression.cs (MemberAccess.DoResolve): When we get a type back,
5946 check the permissions for it. Note than in a type-resolution
5947 context the check was already present in DeclSpace.ResolveType,
5948 but was missing from the MemberAccess.
5950 (ArrayCreation.CheckIndices): warn if the user has
5951 more nested levels of expressions, but there are no more
5952 dimensions specified. Avoids crash on bug 41906.
5954 2003-04-26 Miguel de Icaza <miguel@ximian.com>
5956 * statement.cs (Block): replace Implicit bool, for a generic
5958 New flag: `Unchecked'. This is used during the EmitMeta phase
5959 (which is out-of-line with the regular Resolve/Emit process for a
5960 statement, as this is done ahead of time, but still gets a chance
5961 to call constant resolve).
5963 (Block.Flags): new enum for adding a new flag.
5965 (Block.EmitMeta): track the state of unchecked.
5967 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
5968 to enable constant resolution to work there as well.
5970 2003-04-22 Miguel de Icaza <miguel@ximian.com>
5972 * typemanager.cs (ienumerable_type): Also look up
5973 System.Collections.IEnumerable.
5975 2003-04-21 Miguel de Icaza <miguel@ximian.com>
5977 TODO: Test more than one conditional per method.
5979 * class.cs (Indexer.Define): Report the location where the user is
5980 referencing the unsupported feature.
5982 (MethodData): Overload the use of `conditionals' to
5983 minimize the creation of needless ArrayLists. This saves roughly
5984 212kb on my machine.
5986 (Method): Implement the new IIteratorContainer interface.
5987 (Method.SetYields): Implement the method by setting the ModFlags
5988 to contain METHOD_YIELDS.
5990 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
5991 which just got set to null.
5993 * iterators.cs: New file.
5995 (Yield, YieldBreak): New statements.
5997 * statement.cs (Return.Resolve): Flag an error if we are used in
6000 * codegen.cs (InIterator): New flag set if the code is being
6001 compiled in an iterator method.
6003 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
6004 internal modifier, and we just use it to avoid adding extra
6005 fields, as this is seldom used.
6007 * cs-parser.jay: Add yield_statement (yield and yield break).
6009 * driver.cs: New flag -v2 to turn on version 2 features.
6011 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
6012 hashtable when v2 is enabled.
6014 2003-04-20 Miguel de Icaza <miguel@ximian.com>
6016 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
6017 there is already a namespace defined with this name.
6019 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
6020 people upgraded their corlibs.
6022 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
6023 always use fully qualified types, no need to use the compiler
6026 (TypeManager.IsNamespace): Use binarysearch.
6028 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
6029 AddDelegate): I did not quite use the new IsValid API properly: I
6030 have to pass the short-name and the fullname. I was passing only
6031 the basename instead of the fullname sometimes.
6033 (TypeContainer.DefineType): call NamespaceClash.
6035 * interface.cs (Interface.DefineType): use NamespaceClash before
6038 * delegate.cs (Delegate.DefineType): use NamespaceClash before
6041 * enum.cs: (Enum.DefineType): use NamespaceClash before
6044 * typemanager.cs (: 3-line patch that gives us some tasty 11%
6045 speed increase. First, use the negative_hits cache when we get a
6046 negative. Second, add the type with its full original name
6047 instead of the new . and + encoded name (reflection uses + to
6048 separate type from a nested type). Use LookupTypeReflection
6049 directly which bypasses the type->name hashtable (that we already
6050 know does not contain the type.
6052 * decl.cs (DeclSpace.ResolveTypeExpr): track the
6053 location/container type.
6055 * driver.cs: When passing utf8, use directly the UTF8Encoding.
6057 2003-04-19 Miguel de Icaza <miguel@ximian.com>
6059 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
6061 * delegate.cs (NewDelegate.Resolve): Test whether an instance
6062 method is being referenced in the method group from a static
6063 context, and report error 120 if so.
6065 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
6068 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
6069 is created, we create the A namespace).
6071 * cs-parser.jay: A namespace also introduces a DeclarationFound.
6074 2003-04-18 Miguel de Icaza <miguel@ximian.com>
6076 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
6077 invocation to ModuleBuilder.GetType with the same values will
6078 return a new type instance, so we need to cache its return
6081 * expression.cs (Binary.ResolveOperator): Only allow the compare
6082 operators on enums if they are of the same type.
6084 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
6085 types of ValueType on their own case. Before we were giving them
6086 the same treatment as objects.
6088 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
6089 fullname. Short name is used to compare against container name.
6090 Fullname is used to check against defined namespace names.
6092 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
6093 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
6095 (Method.CheckBase): Call parent.
6096 (MemberBase.CheckBase): Check for protected members on sealed
6098 (PropertyBase.CheckBase): Call parent.
6099 (Field.Define): Call parent.
6101 * report.cs: Negative error codes are now mapped to 8000 - code,
6102 so that the display is render more nicely.
6104 * typemanager.cs: Do not use try/catch, instead report a regular
6107 (GetPointerType, GetReferenceType): These methods provide
6108 mechanisms to obtain the T* and T& from a T. We had the code
6109 previously scattered around the code base, and it also used
6110 TypeManager.LookupType that would go through plenty of caches.
6111 This one goes directly to the type source.
6113 In some places we did the Type.GetType followed by
6114 ModuleBuilder.GetType, but not in others, so this unifies the
6117 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
6118 statements now that we have namespace information.
6120 * typemanager.cs (IsNamespace): New method, returns whether the
6121 string presented is a namespace or not.
6123 (ComputeNamespaces): New public entry point, computes the list of
6124 available namespaces, using the GetNamespaces API call in Mono, or
6125 the slower version in MS.NET.
6127 Now before we start the semantic analysis phase, we have a
6128 complete list of namespaces including everything that the user has
6131 Deleted old code to cache namespaces in .nsc files.
6133 2003-04-17 Miguel de Icaza <miguel@ximian.com>
6135 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
6136 class/struct location definition Location for the implicit
6137 constructor location.
6139 (Operator.Define): Use the location of the operator for the
6140 implicit Method definition.
6142 (Constructor.Emit): use the constructor location for the implicit
6143 base initializer constructor.
6145 * ecore.cs: Remove ITypeExpression. This interface is now gone,
6146 and the Expression class now contains two new methods:
6148 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
6149 isolate type lookup from the rest of the resolution process.
6151 Since we use Expressions to hold type definitions due to the way
6152 we parse the input we have historically overloaded Resolve to
6153 perform the Type lookups if a special flag is passed. Now this is
6154 eliminated and two methods take their place.
6156 The differences in the two methods between xStep and xTerminal is
6157 that xStep is involved in our current lookup system that uses
6158 SimpleNames to compose a name, while xTerminal is used just to
6159 catch the case where the simplename lookup failed.
6161 2003-04-16 Miguel de Icaza <miguel@ximian.com>
6163 * expression.cs (ResolveMemberAccess): Remove redundant code.
6164 TypeExpr expressions are always born fully resolved.
6166 * interface.cs (PopulateMethod): Do not lookup the types twice.
6167 We were doing it once during SemanticAnalysis and once during
6170 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
6171 in local variable type definitions, were being returned as a
6172 SimpleName (we decomposed everything into a string), that is
6173 because primary_expression was being used instead of a type in the
6174 grammar (reduce/reduce conflicts).
6176 The part that was wrong is that we converted the expression into a
6177 string (an oversimplification in one hand, compounded with primary
6178 expressions doing string concatenation).
6184 Would return "A.B.C[]" as a SimpleName. This stopped things like
6185 using clauses from working on this particular context. And a type
6186 was being matched directly against "A.B.C[]".
6188 We now use the correct approach, and allow for ComposedCast to be
6189 part of the unary expression. So the "A.B.C []" become a composed
6190 cast of "A.B.C" (as a nested group of MemberAccess with a
6191 SimpleName at the end) plus the rank composition "[]".
6195 2003-04-10 Miguel de Icaza <miguel@ximian.com>
6197 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
6198 for the access level checking.
6200 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
6201 `TypeContainer container', because I kept getting confused when I
6202 was debugging this code.
6204 * expression.cs (Indexers): Instead of tracking getters/setters,
6205 we now track them in parallel. We create one arraylist less, but
6206 most importantly it is possible now for the LValue code to find a
6207 matching get for a set.
6209 (IndexerAccess.DoResolveLValue): Update the code.
6210 GetIndexersForType has been modified already to extract all the
6211 indexers from a type. The code assumed it did not.
6213 Also make the code set the correct return type for the indexer.
6214 This was fixed a long time ago for properties, but was missing for
6215 indexers. It used to be void_type.
6217 (Binary.Emit): Test first for doubles instead of
6218 floats, as they are more common.
6220 (Binary.EmitBranchable): Use the .un version of the branch opcodes
6221 when dealing with floats and the <=, >= operators. This fixes bug
6224 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
6225 to load the array value by emitting a load on the foreach variable
6226 type. This was incorrect.
6228 We now emit the code to load an element using the the array
6229 variable type, and then we emit the conversion operator.
6233 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
6235 * attribute.cs: Avoid allocation of ArrayLists in the common case.
6237 2003-04-09 Miguel de Icaza <miguel@ximian.com>
6239 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
6240 test for protection before we test for signatures.
6242 (MethodSignature.ToString): implement.
6244 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
6245 to the case where we reduced into a LongConstant.
6247 * decl.cs (CheckAccessLevel): If the type is an array, we can not
6248 depend on whether the information is acurrate, because the
6249 Microsoft runtime will always claim that the array type is public,
6250 regardless of the real state.
6252 If the type is a pointer, another problem happens: the type is
6253 reported as non-public in Microsoft.
6255 In both cases we have to call CheckAccessLevel recursively with
6256 the underlying type as the argument to be tested.
6258 2003-04-08 Miguel de Icaza <miguel@ximian.com>
6260 * assign.cs (Assign.Emit): If we are dealing with a compound
6261 assignment expression, we should use the code path that stores the
6262 intermediate result in a temporary value. This fixes #40903.
6264 *expression.cs (Indirection.ToString): Provide ToString method for
6267 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
6269 * class.cs: Null out fields holding references to Block objects so
6270 they can be garbage collected.
6272 * expression.cs (OverloadResolve): Remove unused local.
6274 2003-04-07 Martin Baulig <martin@ximian.com>
6276 * codegen.cs (EmitContext.CurrentFile): New public field.
6277 (EmitContext.Mark): Use the CurrentFile to check whether the
6278 location is in the correct file.
6279 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
6281 2003-04-07 Martin Baulig <martin@ximian.com>
6283 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
6285 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
6286 location. [FIXME: The location argument which gets passed to this
6287 method is sometimes wrong!]
6289 2003-04-07 Nick Drochak <ndrochak@gol.com>
6291 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
6293 2003-04-07 Miguel de Icaza <miguel@ximian.com>
6295 * expression.cs (Indirection.EmitAssign): We were using the
6296 temporary, but returning immediately instead of continuing the
6299 2003-04-06 Martin Baulig <martin@ximian.com>
6301 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
6302 if it's a nested child, but also deriving from the outer class.
6305 * typemanager.cs (IsNestedChildOf): Make this work if it's a
6306 nested child, but also deriving from the outer class. See
6308 (FilterWithClosure): We may access private members of the outer
6309 class if we're a nested child and deriving from the outer class.
6310 (RealMemberLookup): Only set `closure_private_ok' if the
6311 `original_bf' contained BindingFlags.NonPublic.
6313 2003-04-05 Martin Baulig <martin@ximian.com>
6315 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
6317 2003-04-02 Miguel de Icaza <miguel@ximian.com>
6319 * class.cs (Event.Define): Do not allow abstract events to have
6322 2003-04-01 Miguel de Icaza <miguel@ximian.com>
6324 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
6325 block in event declarations.
6327 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
6328 value type, get its address.
6330 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
6331 leaving a class on the stack instead of a boolean value (int
6332 0/1). Change the code so we compare against null, and then the
6333 result against zero.
6335 * class.cs (TypeContainer.GetClassBases): We were checking for the
6336 parent class being sealed too late.
6338 * expression.cs (Binary.Emit): For <= and >= when dealing with
6339 floating point values, use cgt.un and clt.un instead of cgt and
6342 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
6344 * statement.cs: Apply the same optimization as MS: skip the
6345 GetEnumerator returning an IEnumerator, and use the one returning a
6346 CharEnumerator instead. This allows us to avoid the try-finally block
6349 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
6351 * cs-parser.jay: Attributes cannot be applied to
6352 namespaces. Fixes #40473
6354 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6357 (Add*): check if the name is valid using the full name for constants,
6358 fields, properties and events.
6360 2003-03-28 Miguel de Icaza <miguel@ximian.com>
6362 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
6363 char constants to be part of the enumeration.
6365 * expression.cs (Conditional.DoResolve): Add support for operator
6366 true. Implements the missing functionality from 14.12
6368 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
6369 operator true/false as required by the spec.
6371 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
6372 implicit conversion to boolean.
6374 * statement.cs (Statement.ResolveBoolean): A boolean expression is
6375 also one where the type implements `operator true'.
6377 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
6378 get an expression that will invoke operator true based on an
6381 (GetConversionOperators): Removed the hack that called op_True
6384 (Expression.ResolveBoolean): Move this from Statement.
6386 2003-03-17 Miguel de Icaza <miguel@ximian.com>
6388 * ecore.cs (FieldExpr): do not allow initialization of initonly
6389 fields on derived classes
6391 2003-03-13 Martin Baulig <martin@ximian.com>
6393 * statement.cs (Block.Emit): Call ig.BeginScope() and
6394 ig.EndScope() when compiling with debugging info; call
6395 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
6397 2003-03-08 Miguel de Icaza <miguel@ximian.com>
6399 * expression.cs (Indexers): Do not construct immediately, allow
6400 for new members to be appended as we go. Fixes 38143
6402 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6404 * expression.cs: save/restore context when resolving an unchecked
6407 2003-03-05 Miguel de Icaza <miguel@ximian.com>
6409 * cfold.cs: Catch division by zero in modulus operator during
6412 2003-03-03 Miguel de Icaza <miguel@ximian.com>
6414 * interface.cs (Interface.DefineMembers): Avoid defining members
6417 2003-02-27 Miguel de Icaza <miguel@ximian.com>
6419 * driver.cs: handle the +/- options for -noconfig
6421 * statement.cs (Unckeched.Resolve): Also track the state of
6422 unchecked in the Resolve phase.
6424 2003-02-27 Martin Baulig <martin@ximian.com>
6426 * ecore.cs (Expression.MemberLookup): Don't create a
6427 MethodGroupExpr for something which is not a method. Fixes #38291.
6429 2003-02-25 Miguel de Icaza <miguel@ximian.com>
6431 * class.cs (MemberBase.CheckParameters): Also check that the type
6432 is unmanaged if it is a pointer.
6434 * expression.cs (SizeOf.Resolve): Add location information.
6436 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
6437 a managed type is declared.
6439 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
6440 parameter modifiers as well. Fixes bug 38606
6442 * class.cs: Very sad. Am backing out the speed up changes
6443 introduced by the ArrayList -> Array in the TypeContainer, as they
6444 were not actually that much faster, and introduced a bug (no error
6445 reports on duplicated methods).
6447 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
6448 source first, this will guarantee that we have a valid expression
6449 before calling in lower levels functions that will require a
6450 resolved object. Then use this original_source in the
6451 target.ResolveLValue instead of the original source that was
6454 Another change. Use target.Resolve instead of LValueResolve.
6455 Although we are resolving for LValues, we will let the Assign code
6456 take care of that (it will be called again from Resolve). This
6457 basically allows code like this:
6459 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
6460 class Y { void A (X x) { x [0] += o; }
6462 The problem was that the indexer was trying to resolve for
6463 set_Item (idx, object o) and never finding one. The real set_Item
6464 was set_Item (idx, X). By delaying the process we get the right
6469 2003-02-23 Martin Baulig <martin@ximian.com>
6471 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
6472 while calling DoEmit ().
6474 * codegen.cs (EmitContext.Mark): Don't mark locations in other
6475 source files; if you use the #line directive inside a method, the
6476 compiler stops emitting line numbers for the debugger until it
6477 reaches the end of the method or another #line directive which
6478 restores the original file.
6480 2003-02-23 Martin Baulig <martin@ximian.com>
6482 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
6484 2003-02-23 Martin Baulig <martin@ximian.com>
6486 * statement.cs (Block.AddChildVariableNames): We need to call this
6487 recursively, not just for our immediate children.
6489 2003-02-23 Martin Baulig <martin@ximian.com>
6491 * class.cs (Event.Define): Always make the field private, like csc does.
6493 * typemanager.cs (TypeManager.RealMemberLookup): Make events
6494 actually work, fixes bug #37521.
6496 2003-02-23 Miguel de Icaza <miguel@ximian.com>
6498 * delegate.cs: When creating the various temporary "Parameters"
6499 classes, make sure that we call the ComputeAndDefineParameterTypes
6500 on those new parameters (just like we do with the formal ones), to
6501 allow them to be resolved in the context of the DeclSpace.
6503 This fixes the bug that Dick observed in Bugzilla #38530.
6505 2003-02-22 Miguel de Icaza <miguel@ximian.com>
6507 * expression.cs (ResolveMemberAccess): When resolving a constant,
6508 do not attempt to pull a constant if the value was not able to
6509 generate a valid constant.
6511 * const.cs (LookupConstantValue): Do not report more errors than required.
6513 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6515 * expression.cs: fixes bug #38328.
6517 2003-02-18 Miguel de Icaza <miguel@ximian.com>
6519 * class.cs: Changed all the various members that can be part of a
6520 class from being an ArrayList to be an Array of the right type.
6521 During the DefineType type_list, interface_list, delegate_list and
6522 enum_list are turned into types, interfaces, delegates and enums
6525 And during the member population, indexer_list, event_list,
6526 constant_list, field_list, instance_constructor_list, method_list,
6527 operator_list and property_list are turned into their real arrays.
6529 Although we could probably perform this operation earlier, for
6530 good error reporting we need to keep the lists and remove the
6531 lists for longer than required.
6533 This optimization was triggered by Paolo profiling the compiler
6534 speed on the output of `gen-sample-program.pl' perl script.
6536 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
6537 not crash in methods like MemberLookupFailed that use this field.
6539 This problem arises when the compiler fails to resolve a type
6540 during interface type definition for example.
6542 2003-02-18 Miguel de Icaza <miguel@ximian.com>
6544 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
6545 inherit from System.Object, so we have to stop at null, not only
6546 when reaching System.Object.
6548 2003-02-17 Miguel de Icaza <miguel@ximian.com>
6550 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
6551 DeclaredOnly because the parent indexer might have had a different
6552 name, but did not loop until the top of the hierarchy was reached.
6554 The problem this one fixes is 35492: when a class implemented an
6555 indexer from an interface, we were getting the interface method
6556 (which was abstract) and we were flagging an error (can not invoke
6559 This also keeps bug 33089 functioning, and test-148 functioning.
6561 * typemanager.cs (IsSpecialMethod): The correct way of figuring
6562 out if a method is special is to see if it is declared in a
6563 property or event, or whether it is one of the predefined operator
6564 names. This should fix correctly #36804.
6566 2003-02-15 Miguel de Icaza <miguel@ximian.com>
6568 The goal here is to remove the dependency on EmptyCast.Peel ().
6569 Killing it completely.
6571 The problem is that currently in a number of places where
6572 constants are expected, we have to "probe" for an EmptyCast, and
6573 Peel, which is not the correct thing to do, as this will be
6574 repetitive and will likely lead to errors.
6576 The idea is to remove any EmptyCasts that are used in casts that
6577 can be reduced to constants, so we only have to cope with
6580 This bug hunt was triggered by Bug 37363 and the desire to remove
6581 the duplicate pattern where we were "peeling" emptycasts to check
6582 whether they were constants. Now constants will always be
6585 * ecore.cs: Use an enumconstant here instead of wrapping with
6588 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
6589 throwing me off. By handling this we can get rid of a few hacks.
6591 * statement.cs (Switch): Removed Peel() code.
6593 2003-02-14 Miguel de Icaza <miguel@ximian.com>
6595 * class.cs: Location information for error 508
6597 * expression.cs (New.DoResolve): Add a guard against double
6598 resolution of an expression.
6600 The New DoResolve might be called twice when initializing field
6601 expressions (see EmitFieldInitializers, the call to
6602 GetInitializerExpression will perform a resolve on the expression,
6603 and later the assign will trigger another resolution
6605 This leads to bugs (#37014)
6607 * delegate.cs: The signature for EndInvoke should contain any ref
6608 or out parameters as well. We were not doing this in the past.
6610 * class.cs (Field.Define): Do not overwrite the type definition
6611 inside the `volatile' group. Turns out that volatile enumerations
6612 were changing the type here to perform a validity test, which
6615 2003-02-12 Miguel de Icaza <miguel@ximian.com>
6617 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
6618 and structs, we do not want to load the instance variable
6620 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
6621 enum_type has to be handled like an object reference (implicit
6622 conversions exists from this to object), but the regular IsClass
6623 and IsValueType tests will never return true for this one.
6625 Also we use TypeManager.IsValueType instead of type.IsValueType,
6626 just for consistency with the rest of the code (this is only
6627 needed if we ever use the construct exposed by test-180.cs inside
6628 corlib, which we dont today).
6630 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
6632 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
6635 2003-02-09 Martin Baulig <martin@ximian.com>
6637 * namespace.cs (Namespace..ctor): Added SourceFile argument.
6638 (Namespace.DefineNamespaces): New static public method; this is
6639 called when we're compiling with debugging to add all namespaces
6642 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
6643 pass it to the Namespace's .ctor.
6645 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
6646 and MethodBase arguments; pass the namespace ID to the symwriter;
6647 pass the MethodBase instead of the token to the symwriter.
6648 (SymbolWriter.DefineNamespace): New method to add a namespace to
6651 2003-02-09 Martin Baulig <martin@ximian.com>
6653 * symbolwriter.cs: New file. This is a wrapper around
6654 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
6655 methods here in near future.
6657 2003-02-09 Martin Baulig <martin@ximian.com>
6659 * codegen.cs (EmitContext.Mark): Just pass the arguments to
6660 ILGenerator.MarkSequencePoint() which are actually used by the
6663 2003-02-09 Martin Baulig <martin@ximian.com>
6665 * location.cs (SourceFile): New public sealed class. This
6666 contains the name and an index which is used in the location's token.
6667 (Location): Reserve an appropriate number of bits in the token for
6668 the source file instead of walking over that list, this gives us a
6669 really huge performance improvement when compiling with debugging.
6671 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
6672 `SourceFile' argument instead of a string.
6673 (Driver.ProcessFile): Add all the files via Location.AddFile(),
6674 but don't parse/tokenize here, we need to generate the list of all
6675 source files before we do that.
6676 (Driver.ProcessFiles): New static function. Parses/tokenizes all
6679 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
6680 instead of a string.
6682 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
6685 2003-02-09 Martin Baulig <martin@ximian.com>
6687 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
6688 filename on `#line default'.
6690 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
6692 * statement.cs: don't clear the pinned var when the fixed statement
6693 returns from the method (fixes bug#37752).
6695 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
6697 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
6700 2003-02-07 Martin Baulig <martin@ximian.com>
6702 * driver.cs: Removed the `--debug-args' command line argument.
6704 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
6705 automatically by the AsssemblyBuilder.
6706 (CodeGen.InitializeSymbolWriter): We don't need to call any
6707 initialization function on the symbol writer anymore. This method
6708 doesn't take any arguments.
6710 2003-02-03 Miguel de Icaza <miguel@ximian.com>
6712 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
6713 from referenced assemblies as well.
6715 2003-02-02 Martin Baulig <martin@ximian.com>
6717 * class.cs (MethodData.Emit): Generate debugging info for external methods.
6719 2003-02-02 Martin Baulig <martin@ximian.com>
6721 * class.cs (Constructor.Emit): Open the symbol writer before
6722 emitting the constructor initializer.
6723 (ConstructorInitializer.Emit): Call ec.Mark() to allow
6724 single-stepping through constructor initializers.
6726 2003-01-30 Miguel de Icaza <miguel@ximian.com>
6728 * class.cs: Handle error 549: do not allow virtual methods in
6731 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
6733 * decl.cs: Check access levels when resolving types
6735 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
6737 * statement.cs: Add parameters and locals set in catch blocks that might
6738 return to set vector
6740 2003-01-29 Miguel de Icaza <miguel@ximian.com>
6742 * class.cs (Operator): Set the SpecialName flags for operators.
6744 * expression.cs (Invocation.DoResolve): Only block calls to
6745 accessors and operators on SpecialName methods.
6747 (Cast.TryReduce): Handle conversions from char constants.
6750 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
6752 * statement.cs: small memory and time optimization in FlowBranching.
6754 2003-01-28 Pedro Mart <yoros@wanadoo.es>
6756 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
6757 problem that the last fix but in the other sid (Set).
6759 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
6760 access when there is no indexer in the hierarchy.
6762 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
6764 * class.cs: Combine some if statements.
6766 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6768 * driver.cs: fixed bug #37187.
6770 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
6772 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
6773 any indexer, it's needed to build a list with all the indexers in the
6774 hierarchy (AllGetters), else we have problems. Fixes #35653.
6776 2003-01-23 Miguel de Icaza <miguel@ximian.com>
6778 * class.cs (MethodData.Define): It is wrong for an interface
6779 implementation to be static in both cases: explicit and implicit.
6780 We were only handling this in one case.
6782 Improve the if situation there to not have negations.
6784 * class.cs (Field.Define): Turns out that we do not need to check
6785 the unsafe bit on field definition, only on usage. Remove the test.
6787 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6789 * driver.cs: use assembly.Location instead of Codebase (the latest
6790 patch made mcs fail when using MS assemblies).
6792 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
6794 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
6795 get the path to *corlib.dll.
6797 2003-01-21 Nick Drochak <ndrochak@gol.com>
6801 * typemanager.cs: Remove compiler warnings
6803 2003-01-20 Duncan Mak <duncan@ximian.com>
6805 * AssemblyInfo.cs: Bump the version number to 0.19.
6807 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6809 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
6811 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
6813 * class.cs (Constructor::Emit): Emit debugging info for constructors.
6815 2003-01-17 Miguel de Icaza <miguel@ximian.com>
6817 * cs-parser.jay: Small fix: we were not comparing the constructor
6818 name correctly. Thanks to Zoltan for the initial pointer.
6820 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
6822 * cs-tokenizer.cs: Set file name when specified with #line
6824 2003-01-15 Miguel de Icaza <miguel@ximian.com>
6826 * cs-parser.jay: Only perform the constructor checks here if we
6827 are named like the class; This will help provider a better
6828 error. The constructor path is taken when a type definition is
6829 not found, but most likely the user forgot to add the type, so
6830 report that rather than the constructor error.
6832 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
6834 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
6837 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
6839 * cs-parser.jay: Add cleanup call.
6841 2003-01-13 Duncan Mak <duncan@ximian.com>
6843 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
6844 consistent with other methods.
6846 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
6848 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
6850 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
6852 * attribute.cs: only set GuidAttr to true when we have a
6855 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6859 * typemanager.cs: fixes to allow mcs compile corlib with the new
6860 Type.IsSubclassOf fix.
6862 2003-01-08 Miguel de Icaza <miguel@ximian.com>
6864 * expression.cs (LocalVariableReference.DoResolve): Classify a
6865 constant as a value, not as a variable. Also, set the type for
6868 * cs-parser.jay (fixed_statement): take a type instead of a
6869 pointer_type, so we can produce a better error message later.
6871 * statement.cs (Fixed.Resolve): Flag types that are not pointers
6874 (For.DoEmit): Make inifinite loops have a
6875 non-conditional branch back.
6877 (Fixed.DoEmit): First populate the pinned variables, then emit the
6878 statement, then clear the variables. Before I was emitting the
6879 code once for each fixed piece.
6882 2003-01-08 Martin Baulig <martin@ximian.com>
6884 * statement.cs (FlowBranching.MergeChild): A break in a
6885 SWITCH_SECTION does not leave a loop. Fixes #36155.
6887 2003-01-08 Martin Baulig <martin@ximian.com>
6889 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
6890 lives in the same number space than `param_map'. Fixes #36154.
6892 2003-01-07 Miguel de Icaza <miguel@ximian.com>
6894 * cs-parser.jay (constructor_declaration): Set the
6895 Constructor.ModFlags before probing for it. This makes the
6896 compiler report 514, 515 and 132 (the code was there, but got
6899 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
6900 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
6901 (GotoCase.Resolve): Set `Returns' to ALWAYS.
6903 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
6905 * enum.cs: create the enum static fields using the enum type.
6907 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
6909 * class.cs: don't try to create the ParamBuilder for the return
6910 type if it's not needed (and handle it breaking for the ms runtime
6913 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
6915 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
6917 2002-12-29 Miguel de Icaza <miguel@ximian.com>
6919 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
6920 the command. This showed up while compiling the JANET source
6921 code, which used \r as its only newline separator.
6923 2002-12-28 Miguel de Icaza <miguel@ximian.com>
6925 * class.cs (Method.Define): If we are an operator (because it
6926 reuses our code), then set the SpecialName and HideBySig. #36128
6928 2002-12-22 Miguel de Icaza <miguel@ximian.com>
6930 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
6931 exception, report error 120 `object reference required'.
6933 * driver.cs: Add --pause option, used during to measure the size
6934 of the process as it goes with --timestamp.
6936 * expression.cs (Invocation.DoResolve): Do not allow methods with
6937 SpecialName to be invoked.
6939 2002-12-21 Miguel de Icaza <miguel@ximian.com>
6941 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
6942 number before adding it.
6944 2002-12-21 Ravi Pratap <ravi@ximian.com>
6946 * ecore.cs (StandardImplicitConversion): When in an unsafe
6947 context, we allow conversion between void * to any other pointer
6948 type. This fixes bug #35973.
6950 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
6952 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
6953 is not thrown when extensionless outputs are used
6955 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6957 * rootcontext.cs: fixed compilation of corlib.
6959 2002-12-19 Miguel de Icaza <miguel@ximian.com>
6961 * attribute.cs (Attributes.Contains): Add new method.
6963 * class.cs (MethodCore.LabelParameters): if the parameter is an
6964 `out' parameter, check that no attribute `[In]' has been passed.
6966 * enum.cs: Handle the `value__' name in an enumeration.
6968 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
6970 * decl.cs: Added special case to allow overrides on "protected
6973 2002-12-18 Ravi Pratap <ravi@ximian.com>
6975 * attribute.cs (Attributes.AddAttributeSection): Rename to this
6976 since it makes much more sense.
6978 (Attributes.ctor): Don't require a Location parameter.
6980 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
6982 * attribute.cs (ApplyAttributes): Remove extra Location parameters
6983 since we already have that information per attribute.
6985 * everywhere : make appropriate changes.
6987 * class.cs (LabelParameters): Write the code which actually
6988 applies attributes to the return type. We can't do this on the MS
6989 .NET runtime so we flag a warning in the case an exception is
6992 2002-12-18 Miguel de Icaza <miguel@ximian.com>
6994 * const.cs: Handle implicit null conversions here too.
6996 2002-12-17 Ravi Pratap <ravi@ximian.com>
6998 * class.cs (MethodCore.LabelParameters): Remove the extra
6999 Type [] parameter since it is completely unnecessary. Instead
7000 pass in the method's attributes so that we can extract
7001 the "return" attribute.
7003 2002-12-17 Miguel de Icaza <miguel@ximian.com>
7005 * cs-parser.jay (parse): Use Report.Error to flag errors instead
7006 of ignoring it and letting the compile continue.
7008 * typemanager.cs (ChangeType): use an extra argument to return an
7009 error condition instead of throwing an exception.
7011 2002-12-15 Miguel de Icaza <miguel@ximian.com>
7013 * expression.cs (Unary.TryReduce): mimic the code for the regular
7014 code path. Perform an implicit cast in the cases where we can
7015 implicitly convert to one of the integral types, and then reduce
7016 based on that constant. This fixes bug #35483.
7018 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7020 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
7022 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7024 * namespace.cs: fixed bug #35489.
7026 2002-12-12 Miguel de Icaza <miguel@ximian.com>
7028 * class.cs: Remove some dead code.
7030 * cs-parser.jay: Estimate the number of methods needed
7031 (RootContext.MethodCount);
7033 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
7034 numbers instead of StringBuilders.
7036 * support.cs (PtrHashtable): Add constructor with initial size;
7037 We can now reduce reallocations of the method table.
7039 2002-12-10 Ravi Pratap <ravi@ximian.com>
7041 * attribute.cs (ApplyAttributes): Keep track of the emitted
7042 attributes on a per-target basis. This fixes bug #35413.
7044 2002-12-10 Miguel de Icaza <miguel@ximian.com>
7046 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
7047 default to the Windows 1252 encoding.
7049 (UnixParseOption): Support version, thanks to Alp for the missing
7052 * AssemblyInfo.cs: Add nice assembly information.
7054 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
7057 * cs-parser.jay: Allow a trailing comma before the close bracked
7058 in the attribute_section production.
7060 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
7061 address of the instance was being taken, I will take this out,
7062 because we take the address of the object immediately here.
7064 2002-12-09 Ravi Pratap <ravi@ximian.com>
7066 * typemanager.cs (AreMultipleAllowed): Take care of the most
7067 obvious case where attribute type is not in the current assembly -
7070 2002-12-08 Miguel de Icaza <miguel@ximian.com>
7072 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
7073 definitions, instead of doing that afterwards.
7075 Also we use a nice little hack, depending on the constructor, we
7076 know if we are a "composed" name or a simple name. Hence, we
7077 avoid the IndexOf test, and we avoid
7079 * codegen.cs: Add code to assist in a bug reporter to track down
7080 the source of a compiler crash.
7082 2002-12-07 Ravi Pratap <ravi@ximian.com>
7084 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
7085 types have been emitted for a given element and flag an error
7086 if something which does not have AllowMultiple set is used more
7089 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
7090 attribute types and their corresponding AllowMultiple properties
7092 (AreMultipleAllowed): Check the property for a given type.
7094 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
7095 property in the case we have a TypeContainer.
7097 (Attributes.AddAttribute): Detect duplicates and just skip on
7098 adding them. This trivial fix catches a pretty gross error in our
7099 attribute emission - global attributes were being emitted twice!
7101 Bugzilla bug #33187 is now fixed.
7103 2002-12-06 Miguel de Icaza <miguel@ximian.com>
7105 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
7108 * expression.cs (Binary.ResolveOperator): I can only use the
7109 Concat (string, string, string) and Concat (string, string,
7110 string, string) if the child is actually a concatenation of
7113 2002-12-04 Miguel de Icaza <miguel@ximian.com>
7115 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
7116 context where we need a 2-character lookahead.
7118 * pending.cs (PendingImplementation): Rework so we can keep track
7119 of interface types all the time, and flag those which were
7120 implemented by parents as optional.
7122 2002-12-03 Miguel de Icaza <miguel@ximian.com>
7124 * expression.cs (Binary.ResolveOperator): Use
7125 String.Concat(string,string,string) or
7126 String.Concat(string,string,string,string) when possible.
7128 * typemanager: More helper methods.
7131 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
7133 * pending.cs: remove the bogus return from GetMissingInterfaces()
7134 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
7136 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7138 * namespace.cs: avoid duplicated 'using xxx' being added to
7139 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
7140 when we get more than one 'using' statement for the same namespace.
7141 Report a CS0105 warning for it.
7143 2002-11-30 Miguel de Icaza <miguel@ximian.com>
7145 * cs-tokenizer.cs (consume_identifier): use read directly, instead
7146 of calling getChar/putback, uses internal knowledge of it.
7148 (xtoken): Reorder tokenizer so most common patterns are checked
7149 first. This reduces the compilation time in another 5% (from 8.11s
7150 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
7152 The parsing time is 22% of the compilation in mcs, and from that
7153 64% is spent on the tokenization process.
7155 I tried using a binary search for keywords, but this is slower
7156 than the hashtable. Another option would be to do a couple of
7159 * Not use a StringBuilder, instead use an array of chars,
7160 with a set value. Notice that this way we could catch
7161 the 645 error without having to do it *afterwards*.
7163 * We could write a hand-parser to avoid the hashtable
7164 compares altogether.
7166 The identifier consumption process takes 37% of the tokenization
7167 time. Another 15% is spent on is_number. 56% of the time spent
7168 on is_number is spent on Int64.Parse:
7170 * We could probably choose based on the string length to
7171 use Int32.Parse or Int64.Parse and avoid all the 64-bit
7174 Another 3% is spend on wrapping `xtoken' in the `token' function.
7176 Handle 0xa0 as whitespace (#34752)
7178 2002-11-26 Miguel de Icaza <miguel@ximian.com>
7180 * typemanager.cs (IsCLRType): New routine to tell whether a type
7181 is one of the builtin types.
7183 Maybe it needs to use TypeCodes to be faster. Maybe we could use
7184 typecode in more places instead of doing pointer comparissions.
7185 We could leverage some knowledge about the way the typecodes are
7188 New code to cache namespaces in assemblies, it is currently not
7189 invoked, to be used soon.
7191 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
7193 * expression.cs (Binary.ResolveOperator): specially handle
7194 strings, and do not perform user-defined operator overloading for
7197 2002-11-24 Miguel de Icaza <miguel@ximian.com>
7199 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
7200 internalcall as it is a pretty simple operation; Avoid whenever
7201 possible to call Char.IsLetter.
7203 (consume_identifier): Cut by half the number of
7204 hashtable calls by merging the is_keyword and GetKeyword behavior.
7206 Do not short-circuit, because if we do, we
7207 report errors (ie, #if false && true would produce an invalid
7211 2002-11-24 Martin Baulig <martin@ximian.com>
7213 * expression.cs (Cast.TryReduce): If we're in checked syntax,
7214 check constant ranges and report a CS0221. Fixes #33186.
7216 2002-11-24 Martin Baulig <martin@ximian.com>
7218 * cs-parser.jay: Make this work for uninitialized variable
7219 declarations in the `for' initializer. Fixes #32416.
7221 2002-11-24 Martin Baulig <martin@ximian.com>
7223 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
7224 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
7226 2002-11-24 Martin Baulig <martin@ximian.com>
7228 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
7229 argument; if true, we also check for user-defined conversions.
7230 This is only needed if both arguments are of a user-defined type.
7231 Fixes #30443, added test-175.cs.
7232 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
7234 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
7236 2002-11-24 Martin Baulig <martin@ximian.com>
7238 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
7239 function to get the store opcode.
7240 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
7241 only emit the Ldelema if the store opcode is Stobj. You must run
7242 both test-34 and test-167 to test this. Fixes #34529.
7244 2002-11-23 Martin Baulig <martin@ximian.com>
7246 * ecore.cs (Expression.MemberLookup): Added additional
7247 `qualifier_type' argument which is used when we're being called
7248 from MemberAccess.DoResolve() and null if we're called from a
7250 (Expression.MemberLookupFailed): New method to report errors; this
7251 does the CS1540 check and reports the correct error message.
7253 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
7254 argument for the CS1540 check and redone the way how we're dealing
7255 with private members. See the comment in the source code for details.
7256 (FilterWithClosure): Reverted this back to revision 1.197; renamed
7257 `closure_start_type' to `closure_qualifier_type' and check whether
7258 it's not null. It was not this filter being broken, it was just
7259 being called with the wrong arguments.
7261 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
7262 and pass it the correct `qualifier_type'; this also does the error
7265 2002-11-22 Miguel de Icaza <miguel@ximian.com>
7267 * expression.cs (Invocation.EmitParams): If the we are dealing
7268 with a non-built-in value type, load its address as well.
7270 (ArrayCreation): Use a a pretty constant instead
7271 of the hardcoded value 2. Use 6 instead of 2 for the number of
7272 static initializers.
7274 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
7275 because they are not really value types, just glorified integers.
7277 * driver.cs: Do not append .exe, the CSC compiler does not do it.
7279 * ecore.cs: Remove redundant code for enumerations, make them use
7280 the same code path as everything else, fixes the casting issue
7281 with enumerations in Windows.Forms.
7283 * attribute.cs: Do only cast to string if it is a string, the
7284 validation happens later.
7286 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
7287 people upgrade their corlibs.
7289 * ecore.cs: Oops, enumerations were not following the entire code path
7291 2002-11-21 Miguel de Icaza <miguel@ximian.com>
7293 * typemanager.cs (FilterWithClosure): Commented out the test for
7294 1540 in typemanager.cs, as it has problems when accessing
7295 protected methods from a parent class (see test-174.cs).
7297 * attribute.cs (Attribute.ValidateGuid): new method.
7298 (Attribute.Resolve): Use above.
7300 2002-11-19 Miguel de Icaza <miguel@ximian.com>
7302 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
7304 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
7305 handling for enumerations, as we only needed the TypeContainer
7306 functionality to begin with (this is required for the fix below to
7307 work for enums that reference constants in a container class for
7310 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
7312 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
7313 a valid TypeBuilder to perform lookups on.o
7315 * class.cs (InheritableMemberSignatureCompare): Use true in the
7316 call to GetGetMethod and GetSetMethod, because we are comparing
7317 the signature, and we need to get the methods *even* if they are
7320 (PropertyBase.CheckBase): ditto.
7322 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
7323 GotoCase.Resolve): Use Peel on EmpytCasts.
7325 * ecore.cs (EmptyCast): drop child, add Peel method.
7327 2002-11-17 Martin Baulig <martin@ximian.com>
7329 * ecore.cs (EmptyCast.Child): New public property.
7331 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
7332 label resolved to an EmptyCast. Fixes #34162.
7333 (GotoCase.Resolve): Likewise.
7334 (Block.EmitMeta): Likewise.
7336 2002-11-17 Martin Baulig <martin@ximian.com>
7338 * expression.cs (Invocation.BetterConversion): Prefer int over
7339 uint; short over ushort; long over ulong for integer literals.
7340 Use ImplicitConversionExists instead of StandardConversionExists
7341 since we also need to check for user-defined implicit conversions.
7342 Fixes #34165. Added test-173.cs.
7344 2002-11-16 Martin Baulig <martin@ximian.com>
7346 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
7347 with the `true' and `false' literals. Fixes #33151.
7349 2002-11-16 Martin Baulig <martin@ximian.com>
7351 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
7352 October 22nd; don't do the cs1540 check for static members.
7354 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
7355 now using our own filter here and doing the cs1540 check again.
7357 2002-11-16 Martin Baulig <martin@ximian.com>
7359 * support.cs (InternalParameters): Don't crash if we don't have
7360 any fixed parameters. Fixes #33532.
7362 2002-11-16 Martin Baulig <martin@ximian.com>
7364 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
7365 when looking up static methods to make this work on Windows.
7368 2002-11-16 Martin Baulig <martin@ximian.com>
7370 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
7371 a setter rather than using PropertyInfo.CanWrite.
7373 2002-11-15 Nick Drochak <ndrochak@gol.com>
7375 * class.cs: Allow acces to block member by subclasses. Fixes build
7378 2002-11-14 Martin Baulig <martin@ximian.com>
7380 * class.cs (Constructor.Emit): Added the extern/block check.
7383 2002-11-14 Martin Baulig <martin@ximian.com>
7385 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
7386 iteration while looking for indexers, this is needed because the
7387 indexer may have a different name in our base classes. Fixed the
7388 error reporting (no indexers at all, not get accessor, no
7389 overloaded match). Fixes bug #33089.
7390 (IndexerAccess.DoResolveLValue): Likewise.
7392 2002-11-14 Martin Baulig <martin@ximian.com>
7394 * class.cs (PropertyBase.CheckBase): Make this work for multiple
7395 indexers. Fixes the first part of bug #33089.
7396 (MethodSignature.InheritableMemberSignatureCompare): Added support
7399 2002-11-13 Ravi Pratap <ravi@ximian.com>
7401 * attribute.cs (Attribute.Resolve): Catch the
7402 NullReferenceException and report it since it isn't supposed to
7405 2002-11-12 Miguel de Icaza <miguel@ximian.com>
7407 * expression.cs (Binary.EmitBranchable): Also handle the cases for
7408 LogicalOr and LogicalAnd that can benefit from recursively
7409 handling EmitBranchable. The code now should be nice for Paolo.
7411 2002-11-08 Miguel de Icaza <miguel@ximian.com>
7413 * typemanager.cs (LookupType): Added a negative-hit hashtable for
7414 the Type lookups, as we perform quite a number of lookups on
7415 non-Types. This can be removed once we can deterministically tell
7416 whether we have a type or a namespace in advance.
7418 But this might require special hacks from our corlib.
7422 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
7423 and double which avoids a conversion from an integer to a double.
7425 * expression.cs: tiny optimization, avoid calling IsConstant,
7426 because it effectively performs the lookup twice.
7428 2002-11-06 Miguel de Icaza <miguel@ximian.com>
7430 But a bogus return here to keep the semantics of the old code
7431 until the Mono runtime is fixed.
7433 * pending.cs (GetMissingInterfaces): New method used to remove all
7434 the interfaces that are already implemented by our parent
7435 classes from the list of pending methods.
7437 * interface.cs: Add checks for calls after ResolveTypeExpr.
7439 2002-11-05 Miguel de Icaza <miguel@ximian.com>
7441 * class.cs (Class.Emit): Report warning 67: event not used if the
7442 warning level is beyond 3.
7444 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
7445 being a NullLiteral.
7447 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
7450 * class.cs (TypeContainer.GetClassBases): Cover a missing code
7451 path that might fail if a type can not be resolved.
7453 * expression.cs (Binary.Emit): Emit unsigned versions of the
7456 * driver.cs: use error 5.
7458 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
7460 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
7462 2002-11-01 Miguel de Icaza <miguel@ximian.com>
7464 * cs-parser.jay (switch_section): A beautiful patch from Martin
7465 Baulig that fixed 33094.
7467 2002-10-31 Miguel de Icaza <miguel@ximian.com>
7469 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
7470 Check whether the base is abstract and report an error if so.
7472 * expression.cs (IndexerAccess.DoResolveLValue,
7473 IndexerAccess.DoResolve): ditto.
7475 (Invocation.DoResolve): ditto.
7477 (Invocation.FullMethodDesc): Improve the report string.
7479 * statement.cs (Block): Eliminate IsVariableDefined as it is
7480 basically just a wrapper for GetVariableInfo.
7482 * ecore.cs (SimpleName): Use new
7484 * support.cs (ReflectionParamter.ParameterType): We unwrap the
7485 type, as we return the actual parameter ref/unref state on a
7488 2002-10-30 Miguel de Icaza <miguel@ximian.com>
7490 * support.cs: Return proper flags REF/OUT fixing the previous
7493 * expression.cs: Reverted last patch, that was wrong. Is_ref is
7494 not used to mean `ref' but `ref or out' in ParameterReference
7496 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
7497 full type signature instead of calling TypeManger.CSharpName
7500 * support.cs (InternalParameters.ParameterDesc): Do not compare
7501 directly to the modflags, because REF/OUT will actually be bitsets
7504 * delegate.cs (VerifyMethod): Check also the modifiers.
7506 * cs-tokenizer.cs: Fix bug where floating point values with an
7507 exponent where a sign was missing was ignored.
7509 * driver.cs: Allow multiple assemblies to be specified in a single
7512 2002-10-28 Miguel de Icaza <miguel@ximian.com>
7514 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
7515 because identifiers after a parenthesis would end up in this kind
7516 of production, and we needed to desamiguate it for having casts
7519 (UserDefinedType *) xxx
7521 2002-10-24 Miguel de Icaza <miguel@ximian.com>
7523 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
7524 we should set on the Bindingflags.NonPublic, but not turn on
7525 private_ok. private_ok controls whether a Private member is
7526 returned (this is chekced on the filter routine), while the
7527 BindingFlags.NonPublic just controls whether private/protected
7528 will be allowed. This fixes the problem part of the problem of
7529 private properties being allowed to be used in derived classes.
7531 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
7532 so we can call the children DoResolveLValue method (this will
7533 properly signal errors on lvalue assignments to base properties)
7535 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
7536 getter are null, and we have a property info, we know that this
7537 happened because the lookup failed, so we report an error 122 for
7538 protection level violation.
7540 We also silently return if setter and getter are null in the
7541 resolve functions, this condition only happens if we have flagged
7542 the error before. This is the other half of the problem.
7544 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
7545 not have accessibility information, that is why we were returning
7546 true in the filter function in typemanager.cs.
7548 To properly report 122 (property is inaccessible because of its
7549 protection level) correctly, we report this error in ResolveAccess
7550 by failing if both the setter and the getter are lacking (ie, the
7553 DoResolve and DoLResolve have been modified to check for both
7554 setter/getter being null and returning silently, the reason being
7555 that I did not want to put the knowledge about this error in upper
7558 int old = Report.Errors;
7559 x = new PropertyExpr (...);
7560 if (old != Report.Errors)
7565 So the property expr is returned, but it is invalid, so the error
7566 will be flagged during the resolve process.
7568 * class.cs: Remove InheritablePropertySignatureCompare from the
7569 class, as we no longer depend on the property signature to compute
7570 whether it is possible to implement a method or not.
7572 The reason is that calling PropertyInfo.GetGetMethod will return
7573 null (in .NET, in Mono it works, and we should change this), in
7574 cases where the Get Method does not exist in that particular
7579 class X { public virtual int A { get { return 1; } } }
7581 class Z : Y { public override int A { get { return 2; } } }
7583 Would fail in Z because the parent (Y) would not have the property
7584 defined. So we avoid this completely now (because the alternative
7585 fix was ugly and slow), and we now depend exclusively on the
7588 (PropertyBase.CheckBase): Use a method-base mechanism to find our
7589 reference method, instead of using the property.
7591 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
7592 routines are gone now.
7594 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
7595 names, they were incorrectly named.
7597 * cs-tokenizer.cs: Return are more gentle token on failure.
7599 * pending.cs (PendingImplementation.InterfaceMethod): This routine
7600 had an out-of-sync index variable, which caused it to remove from
7601 the list of pending methods the wrong method sometimes.
7603 2002-10-22 Miguel de Icaza <miguel@ximian.com>
7605 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
7606 CanWrite, because those refer to this particular instance of the
7607 property, and do not take into account the fact that we can
7608 override single members of a property.
7610 Constructor requires an EmitContext. The resolution process does
7611 not happen here, but we need to compute the accessors before,
7612 because the resolution does not always happen for properties.
7614 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
7615 subclass, before we did not update this flag, but we did update
7618 (GetAccessors): Drop this routine, as it did not work in the
7619 presence of partially overwritten set/get methods.
7621 Notice that this broke the cs1540 detection, but that will require
7624 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7628 * driver.cs: issue a warning instead of an error if we don't support
7629 debugging for the platform. Also ignore a couple of errors that may
7630 arise when trying to write the symbols. Undo my previous patch.
7632 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7634 * driver.cs: ignore /debug switch except for Unix platforms.
7636 2002-10-23 Nick Drochak <ndrochak@gol.com>
7638 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
7640 2002-10-21 Miguel de Icaza <miguel@ximian.com>
7642 * driver.cs: Do not make mcs-debug conditional, so we do not break
7645 * statement.cs (UsageVector.MergeChildren): I would like Martin to
7646 review this patch. But basically after all the children variables
7647 have been merged, the value of "Breaks" was not being set to
7648 new_breaks for Switch blocks. I think that it should be set after
7649 it has executed. Currently I set this to the value of new_breaks,
7650 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
7651 conservative, but I do not understand this code very well.
7653 I did not break anything in the build, so that is good ;-)
7655 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
7657 2002-10-20 Mark Crichton <crichton@gimp.org>
7659 * cfold.cs: Fixed compile blocker. Really fixed it this time.
7661 2002-10-20 Nick Drochak <ndrochak@gol.com>
7663 * cfold.cs: Fixed compile blocker.
7665 2002-10-20 Miguel de Icaza <miguel@ximian.com>
7667 * driver.cs: I was chekcing the key, not the file.
7669 2002-10-19 Ravi Pratap <ravi@ximian.com>
7671 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
7672 message that we were generating - we just need to silently return
7675 2002-10-19 Miguel de Icaza <miguel@ximian.com>
7677 * class.cs (Event.Define): Change my previous commit, as this
7678 breaks the debugger. This is a temporary hack, as it seems like
7679 the compiler is generating events incorrectly to begin with.
7681 * expression.cs (Binary.ResolveOperator): Added support for
7682 "U operator - (E x, E y)"
7684 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
7687 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
7688 init-only variables, but this path did not take into account that
7689 there might be also instance readonly variables. Correct this
7692 This fixes bug 32253
7694 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
7697 * driver.cs: Change the extension for modules to `netmodule'
7699 * cs-parser.jay: Improved slightly the location tracking for
7700 the debugger symbols.
7702 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
7703 modifiers that were specified instead of the hardcoded value
7704 (FamAndAssem). This was basically ignoring the static modifier,
7705 and others. Fixes 32429.
7707 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
7708 fixed a bug in the process (32476)
7710 * expression.cs (ArrayAccess.EmitAssign): Patch from
7711 hwang_rob@yahoo.ca that fixes bug 31834.3
7713 2002-10-18 Miguel de Icaza <miguel@ximian.com>
7715 * driver.cs: Make the module extension .netmodule.
7717 2002-10-16 Miguel de Icaza <miguel@ximian.com>
7719 * driver.cs: Report an error if the resource file is not found
7720 instead of crashing.
7722 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
7723 false, like Emit does.
7725 2002-10-16 Nick Drochak <ndrochak@gol.com>
7727 * typemanager.cs: Remove unused private member. Also reported mcs
7728 bug to report this as a warning like csc.
7730 2002-10-15 Martin Baulig <martin@gnome.org>
7732 * statement.cs (Statement.Emit): Made this a virtual method; emits
7733 the line number info and calls DoEmit().
7734 (Statement.DoEmit): New protected abstract method, formerly knows
7735 as Statement.Emit().
7737 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
7739 2002-10-11 Miguel de Icaza <miguel@ximian.com>
7741 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
7742 have fixed a remaining problem: not every AddXXXX was adding a
7743 fully qualified name.
7745 Now everyone registers a fully qualified name in the DeclSpace as
7746 being defined instead of the partial name.
7748 Downsides: we are slower than we need to be due to the excess
7749 copies and the names being registered this way.
7751 The reason for this is that we currently depend (on the corlib
7752 bootstrap for instance) that types are fully qualified, because
7753 we dump all the types in the namespace, and we should really have
7754 types inserted into the proper namespace, so we can only store the
7755 basenames in the defined_names array.
7757 2002-10-10 Martin Baulig <martin@gnome.org>
7759 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
7760 from bug #31834, see the bug report for a testcase which is
7763 2002-10-10 Martin Baulig <martin@gnome.org>
7765 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
7766 flow analysis code for this.
7768 * statement.cs (Do, While, For): Tell the flow analysis code about
7770 (FlowBranching.UsageVector): Added support for infinite loops.
7771 (Block.Resolve): Moved the dead code elimination here and use flow
7774 2002-10-09 Miguel de Icaza <miguel@ximian.com>
7776 * class.cs (Field.Define): Catch cycles on struct type
7779 * typemanager.cs (IsUnmanagedtype): Do not recursively check
7780 fields if the fields are static. We only need to check instance
7783 * expression.cs (As.DoResolve): Test for reference type.
7785 * statement.cs (Using.ResolveExpression): Use
7786 ConvertImplicitRequired, not ConvertImplicit which reports an
7788 (Using.ResolveLocalVariableDecls): ditto.
7790 * expression.cs (Binary.ResolveOperator): Report errors in a few
7791 places where we had to.
7793 * typemanager.cs (IsUnmanagedtype): Finish implementation.
7795 2002-10-08 Miguel de Icaza <miguel@ximian.com>
7797 * expression.cs: Use StoreFromPtr instead of extracting the type
7798 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
7800 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
7801 an enumeration value to a System.Enum, but System.Enum is not a
7802 value type, but an class type, so we need to box.
7804 (Expression.ConvertExplicit): One codepath could return
7805 errors but not flag them. Fix this. Fixes #31853
7807 * parameter.cs (Resolve): Do not allow void as a parameter type.
7809 2002-10-06 Martin Baulig <martin@gnome.org>
7811 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
7812 if it's a class type and not a struct. Fixes #31815.
7814 2002-10-06 Martin Baulig <martin@gnome.org>
7816 * statement.cs: Reworked the flow analysis code a bit to make it
7817 usable for dead code elimination.
7819 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7821 * cs-parser.jay: allow empty source files. Fixes bug #31781.
7823 2002-10-04 Miguel de Icaza <miguel@ximian.com>
7825 * expression.cs (ComposedCast.DoResolveType): A quick workaround
7826 to fix the test 165, will investigate deeper.
7828 2002-10-04 Martin Baulig <martin@gnome.org>
7830 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
7831 finally blocks actually work.
7832 (Try.Resolve): We don't need to create a sibling for `finally' if
7833 there is no finally block.
7835 2002-10-04 Martin Baulig <martin@gnome.org>
7837 * class.cs (Constructor.Define): The default accessibility for a
7838 non-default constructor is private, not public.
7840 2002-10-04 Miguel de Icaza <miguel@ximian.com>
7842 * class.cs (Constructor): Make AllowedModifiers public, add
7845 * cs-parser.jay: Perform the modifiers test here, as the
7846 constructor for the Constructor class usually receives a zero
7847 because of the way we create it (first we create, later we
7848 customize, and we were never checking the modifiers).
7850 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
7851 is a version of LookupTypeReflection that includes the type-name
7852 cache. This can be used as a fast path for functions that know
7853 the fully qualified name and are only calling into *.GetType() to
7854 obtain a composed type.
7856 This is also used by TypeManager.LookupType during its type
7859 (LookupType): We now also track the real type name, as sometimes
7860 we can get a quey for the real type name from things like
7861 ComposedCast. This fixes bug 31422.
7863 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
7864 complete type fullname, it does not have to go through the type
7865 resolution system to obtain the composed version of the type (for
7866 obtaining arrays or pointers).
7868 (Conditional.Emit): Use the EmitBoolExpression to
7869 generate nicer code, as requested by Paolo.
7871 (ArrayCreation.CheckIndices): Use the patch from
7872 hwang_rob@yahoo.ca to validate the array initializers.
7874 2002-10-03 Miguel de Icaza <miguel@ximian.com>
7876 * class.cs (ConstructorInitializer.Emit): simplify code by using
7877 Invocation.EmitCall, and at the same time, fix the bugs in calling
7878 parent constructors that took variable arguments.
7880 * ecore.cs (Expression.ConvertNumericExplicit,
7881 Expression.ImplicitNumericConversion): Remove the code that
7882 manually wrapped decimal (InternalTypeConstructor call is now gone
7885 * expression.cs (Cast.TryReduce): Also handle decimal types when
7886 trying to perform a constant fold on the type.
7888 * typemanager.cs (IsUnmanagedtype): Partially implemented.
7890 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
7891 that only turned off an error report, and did nothing else.
7893 2002-10-02 Miguel de Icaza <miguel@ximian.com>
7895 * driver.cs: Handle and ignore /fullpaths
7897 2002-10-01 Miguel de Icaza <miguel@ximian.com>
7899 * expression.cs (Binary.ResolveOperator): Catch the case where
7900 DoNumericPromotions returns true,
7902 (Binary.DoNumericPromotions): Simplify the code, and the tests.
7904 2002-09-27 Miguel de Icaza <miguel@ximian.com>
7906 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
7909 2002-09-26 Miguel de Icaza <miguel@ximian.com>
7911 * ecore.cs (ConvertNumericExplicit): It is not enough that the
7912 conversion exists, but it is also required that the conversion be
7913 performed. This manifested in "(Type64Enum) 2".
7915 * class.cs (TypeManager.AddMethod): The fix is not to change
7916 AddEnum, because that one was using a fully qualified name (every
7917 DeclSpace derivative does), but to change the AddMethod routine
7918 that was using an un-namespaced name. This now correctly reports
7919 the duplicated name.
7921 Revert patch until I can properly fix it. The issue
7922 is that we have a shared Type space across all namespaces
7923 currently, which is wrong.
7925 Options include making the Namespace a DeclSpace, and merge
7926 current_namespace/current_container in the parser.
7928 2002-09-25 Miguel de Icaza <miguel@ximian.com>
7930 * cs-parser.jay: Improve error reporting when we get a different
7931 kind of expression in local_variable_type and
7932 local_variable_pointer_type.
7934 Propagate this to avoid missleading errors being reported.
7936 * ecore.cs (ImplicitReferenceConversion): treat
7937 TypeManager.value_type as a target just like object_type. As
7942 Is valid, and needs to result in the int 1 being boxed before it
7943 is assigned to the value type v.
7945 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
7946 to validate the enumeration name.
7948 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
7949 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
7950 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
7952 * ecore.cs (TryImplicitIntConversion): When doing an
7953 implicit-enumeration-conversion, check if the type is 64-bits and
7954 perform a conversion before passing to EnumConstant.
7956 2002-09-23 Miguel de Icaza <miguel@ximian.com>
7958 * decl.cs (Error_AmbiguousTypeReference); New routine used to
7959 report ambiguous type references. Unlike the MS version, we
7960 report what the ambiguity is. Innovation at work ;-)
7962 (DeclSpace.FindType): Require a location argument to
7963 display when we display an ambiguous error.
7965 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
7967 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
7969 * expression.cs (EmitDynamicInitializers): Apply patch from
7970 hwang_rob@yahoo.ca that fixes the order in which we emit our
7973 2002-09-21 Martin Baulig <martin@gnome.org>
7975 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
7976 delegate takes no arguments.
7978 2002-09-20 Miguel de Icaza <miguel@ximian.com>
7980 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
7983 * expression.cs: Extract the underlying type.
7985 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
7987 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
7989 2002-09-19 Miguel de Icaza <miguel@ximian.com>
7991 * class.cs (TypeContainer.DefineType): We can not use the nice
7992 PackingSize with the size set to 1 DefineType method, because it
7993 will not allow us to define the interfaces that the struct
7996 This completes the fixing of bug 27287
7998 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
7999 means also structs. This fixes part of the problem.
8000 (Expresion.ImplicitReferenceConversionExists): ditto.
8002 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
8003 error if there were no errors reported during the type lookup
8004 process, to avoid duplicates or redundant errors. Without this
8005 you would get an ambiguous errors plus a type not found. We have
8006 beaten the user enough with the first error.
8008 (DeclSparce.FindType): Emit a warning if we have an ambiguous
8011 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
8012 during the resolution process, stop the lookup, this avoids
8013 repeated error reports (same error twice).
8015 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
8017 * typemanager.cs (LookupType): Redo the type lookup code to match
8018 the needs of System.Reflection.
8020 The issue is that System.Reflection requires references to nested
8021 types to begin with a "+" sign instead of a dot. So toplevel
8022 types look like: "NameSpace.TopLevelClass", and nested ones look
8023 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
8026 2002-09-19 Martin Baulig <martin@gnome.org>
8028 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
8029 says that a method always returns or always throws an exception,
8030 don't report the CS0161.
8032 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
8033 set `Returns = new_returns'.
8035 2002-09-19 Martin Baulig <martin@gnome.org>
8037 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
8038 to an enum constant, check for a CS0176.
8040 2002-09-18 Miguel de Icaza <miguel@ximian.com>
8042 * class.cs (TypeContainer.CheckPairedOperators): Now we check
8043 for operators that must be in pairs and report errors.
8045 * ecore.cs (SimpleName.DoResolveType): During the initial type
8046 resolution process, when we define types recursively, we must
8047 check first for types in our current scope before we perform
8048 lookups in the enclosing scopes.
8050 * expression.cs (MakeByteBlob): Handle Decimal blobs.
8052 (Invocation.VerifyArgumentsCompat): Call
8053 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
8054 I thought we were supposed to always call this, but there are a
8055 few places in the code where we dont do it.
8057 2002-09-17 Miguel de Icaza <miguel@ximian.com>
8059 * driver.cs: Add support in -linkres and -resource to specify the
8060 name of the identifier.
8062 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8064 * ecore.cs (StandardConversionExists): Sync with the conversion
8065 code: allow anything-* to void* conversions.
8067 (FindMostSpecificSource): Use an Expression argument
8068 instead of a Type, because we might be handed over a Literal which
8069 gets a few more implicit conversions that plain types do not. So
8070 this information was being lost.
8072 Also, we drop the temporary type-holder expression when not
8075 2002-09-17 Martin Baulig <martin@gnome.org>
8077 * class.cs (PropertyBase.CheckBase): Don't check the base class if
8078 this is an explicit interface implementation.
8080 2002-09-17 Martin Baulig <martin@gnome.org>
8082 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
8083 different `IndexerName' attributes.
8085 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
8086 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
8087 virtual CommonResolve().
8089 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8091 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
8092 and convert that to the UnderlyingType.
8094 * statement.cs (Foreach.Resolve): Indexers are just like variables
8095 or PropertyAccesses.
8097 * cs-tokenizer.cs (consume_string): Track line numbers and columns
8098 inside quoted strings, we were not doing this before.
8100 2002-09-16 Martin Baulig <martin@gnome.org>
8102 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
8103 resolve it. This is needed for the definite assignment check of the
8104 instance expression, fixes bug #29846.
8105 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
8107 2002-09-16 Nick Drochak <ndrochak@gol.com>
8109 * parameter.cs: Fix compile error. Cannot reference static member
8110 from an instance object. Is this an mcs bug?
8112 2002-09-14 Martin Baulig <martin@gnome.org>
8114 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
8115 multiple times. Fixes bug #30295, added test-166.cs.
8117 2002-09-14 Martin Baulig <martin@gnome.org>
8119 * statement.cs (Block.Emit): Don't emit unreachable code.
8120 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
8122 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
8124 2002-09-14 Martin Baulig <martin@gnome.org>
8126 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
8129 2002-09-14 Martin Baulig <martin@gnome.org>
8131 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
8132 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
8133 be false on the ms runtime.
8135 2002-09-13 Martin Baulig <martin@gnome.org>
8137 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
8138 the CS0038 error message.
8140 2002-09-12 Miguel de Icaza <miguel@ximian.com>
8142 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
8143 constant inside, return it.
8145 2002-09-12 Martin Baulig <martin@gnome.org>
8147 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
8148 implicit conversion can be done between enum types.
8150 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
8151 check whether an implicit conversion to the current enum's UnderlyingType
8152 exists and report an error if not.
8154 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
8155 without debugging support.
8157 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
8158 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
8160 2002-09-12 Martin Baulig <martin@gnome.org>
8162 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
8164 * ecore.cs (IMemberExpr.DeclaringType): New property.
8165 (SimpleName.SimpleNameResolve): Check whether we're accessing a
8166 nonstatic member of an outer type (CS0038).
8168 2002-09-11 Miguel de Icaza <miguel@ximian.com>
8170 * driver.cs: Activate the using-error detector at warning level
8171 4 (at least for MS-compatible APIs).
8173 * namespace.cs (VerifyUsing): Small buglett fix.
8175 * pending.cs (PendingImplementation): pass the container pointer.
8177 * interface.cs (GetMethods): Allow for recursive definition. Long
8178 term, I would like to move every type to support recursive
8179 definitions, not the current ordering mechanism that we have right
8182 The situation is this: Attributes are handled before interfaces,
8183 so we can apply attributes to interfaces. But some attributes
8184 implement interfaces, we will now handle the simple cases
8185 (recursive definitions will just get an error).
8187 * parameter.cs: Only invalidate types at the end if we fail to
8190 2002-09-09 Martin Baulig <martin@gnome.org>
8192 * ecore.cs (PropertyExpr.Emit): Also check for
8193 TypeManager.system_int_array_get_length so this'll also work when
8194 compiling corlib. Fixes #30003.
8196 2002-09-09 Martin Baulig <martin@gnome.org>
8198 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
8199 and throw an exception if we can't get the type's size. Fixed #30040,
8202 2002-09-09 Martin Baulig <martin@gnome.org>
8204 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
8206 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
8207 context. Fixes bug #30027.
8209 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
8210 virtual functions. Fixes bug #30043, added test-164.cs.
8212 2002-09-08 Ravi Pratap <ravi@ximian.com>
8214 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
8216 2002-09-08 Nick Drochak <ndrochak@gol.com>
8218 * driver.cs: Use an object to get the windows codepage since it's not a
8221 2002-09-08 Miguel de Icaza <miguel@ximian.com>
8223 * statement.cs (For.Emit): for infinite loops (test == null)
8224 return whether there is a break inside, not always "true".
8226 * namespace.cs (UsingEntry): New struct to hold the name of the
8227 using definition, the location where it is defined, and whether it
8228 has been used in a successful type lookup.
8230 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
8235 2002-09-06 Ravi Pratap <ravi@ximian.com>
8237 * attribute.cs : Fix incorrect code which relied on catching
8238 a NullReferenceException to detect a null being passed in
8239 where an object was expected.
8241 2002-09-06 Miguel de Icaza <miguel@ximian.com>
8243 * statement.cs (Try): flag the catch variable as assigned
8245 * expression.cs (Cast): Simplified by using ResolveType instead of
8248 * statement.cs (Catch): Fix bug by using ResolveType.
8250 2002-09-06 Ravi Pratap <ravi@ximian.com>
8252 * expression.cs (BetterConversion): Special case for when we have
8253 a NullLiteral as the argument and we have to choose between string
8254 and object types - we choose string the way csc does.
8256 * attribute.cs (Attribute.Resolve): Catch the
8257 NullReferenceException and report error #182 since the Mono
8258 runtime no more has the bug and having this exception raised means
8259 we tried to select a constructor which takes an object and is
8262 2002-09-05 Ravi Pratap <ravi@ximian.com>
8264 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
8265 message (1502, 1503) when we can't locate a method after overload
8266 resolution. This is much more informative and closes the bug
8269 * interface.cs (PopulateMethod): Return if there are no argument
8270 types. Fixes a NullReferenceException bug.
8272 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
8273 expressions too. Previously we were checking only in one place for
8274 positional arguments leaving out named arguments.
8276 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
8277 type to the enum type is not allowed. Remove code corresponding to
8280 (ConvertNumericExplicit): Allow explicit conversions from
8281 the underlying type to enum type. This precisely follows the spec
8282 and closes a bug filed by Gonzalo.
8284 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8287 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
8289 2002-09-03 Miguel de Icaza <miguel@ximian.com>
8291 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
8292 it was important that we stored the right value after the
8293 reduction in `converted'.
8295 2002-09-04 Martin Baulig <martin@gnome.org>
8297 * location.cs (Location.SymbolDocument): Use full pathnames for the
8300 2002-08-30 Miguel de Icaza <miguel@ximian.com>
8302 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
8303 of the expression resolve mechanism, because that will catch the
8304 SimpleName error failures.
8306 (Conditional): If we can not resolve the
8307 expression, return, do not crash.
8309 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8312 (location): display token name instead of its number.
8314 2002-08-28 Martin Baulig <martin@gnome.org>
8316 * expression.cs (Binary.ResolveOperator): Don't silently return
8317 but return an error if an operator cannot be applied between two
8320 2002-08-28 Martin Baulig <martin@gnome.org>
8322 * class.cs (Constructor.Define): Set the permission attributes
8323 correctly instead of making all constructors public.
8325 2002-08-28 Martin Baulig <martin@gnome.org>
8327 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
8328 for private members before reporting a CS0103; if we find anything,
8331 2002-08-28 Martin Baulig <martin@gnome.org>
8333 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
8334 to check whether `closure_start_type == closure_invocation_type',
8335 we also need to check whether `m.DeclaringType == closure_invocation_type'
8336 before bypassing the permission checks. We might be accessing
8337 protected/private members from the base class.
8338 (TypeManager.RealMemberLookup): Only set private_ok if private
8339 members were requested via BindingFlags.NonPublic.
8341 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
8343 * expression.cs (MemberAccess.ResolveMemberAccess): Set
8344 MethodGroupExpr.IsExplicitImpl if appropriate.
8345 (Invocation.DoResolve): Don't report the CS0120 for explicit
8346 interface implementations.
8348 2002-08-27 Martin Baulig <martin@gnome.org>
8350 * expression.cs (Invocation.DoResolve): If this is a static
8351 method and we don't have an InstanceExpression, we must report
8354 2002-08-25 Martin Baulig <martin@gnome.org>
8356 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
8357 `==' between a valuetype and an object.
8359 2002-08-25 Miguel de Icaza <miguel@ximian.com>
8361 * ecore.cs (TypeExpr): Provide a ToString method.
8363 2002-08-24 Martin Baulig <martin@gnome.org>
8365 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
8366 now called proggie.dbg and it's a binary file.
8368 2002-08-23 Martin Baulig <martin@gnome.org>
8370 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
8372 2002-08-23 Martin Baulig <martin@gnome.org>
8374 * struct.cs (MyStructInfo.ctor): Make this work with empty
8375 structs; it's not allowed to use foreach() on null.
8377 2002-08-23 Martin Baulig <martin@gnome.org>
8379 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
8380 writer the full pathname of the generated assembly.
8382 2002-08-23 Martin Baulig <martin@gnome.org>
8384 * statements.cs (FlowBranching.UsageVector.MergeChildren):
8385 A `finally' block never returns or breaks; improved handling of
8388 2002-08-23 Martin Baulig <martin@gnome.org>
8390 * statement.cs (Throw.Resolve): Allow `throw null'.
8392 2002-08-23 Martin Baulig <martin@gnome.org>
8394 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
8395 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
8396 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
8397 MemberLookup would return a wrong event if this is an explicit
8398 interface implementation and the class has an event with the same
8401 2002-08-23 Martin Baulig <martin@gnome.org>
8403 * statement.cs (Block.AddChildVariableNames): New public method.
8404 (Block.AddChildVariableName): Likewise.
8405 (Block.IsVariableNameUsedInChildBlock): Likewise.
8406 (Block.AddVariable): Check whether a variable name has already
8407 been used in a child block.
8409 * cs-parser.jay (declare_local_variables): Mark all variable names
8410 from the current block as being used in a child block in the
8413 2002-08-23 Martin Baulig <martin@gnome.org>
8415 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
8416 find the symbol writer.
8418 * driver.cs: csc also allows the arguments to /define being
8419 separated by commas, not only by semicolons.
8421 2002-08-23 Martin Baulig <martin@gnome.org>
8423 * interface.cs (Interface.GetMembers): Added static check for events.
8425 2002-08-15 Martin Baulig <martin@gnome.org>
8427 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
8428 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
8430 * ecore.cs (Expression.MemberLookup): Added documentation and explained
8431 why the MethodData.EmitDestructor() change was necessary.
8433 2002-08-20 Martin Baulig <martin@gnome.org>
8435 * class.cs (TypeContainer.FindMembers): Added static check for events.
8437 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
8439 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
8440 use Type.GetEvents(), not Type.FindMembers().
8442 2002-08-20 Martin Baulig <martin@gnome.org>
8444 * decl.cs (MemberCache): Added a special method cache which will
8445 be used for method-only searched. This ensures that a method
8446 search will return a MethodInfo with the correct ReflectedType for
8449 2002-08-20 Martin Baulig <martin@gnome.org>
8451 * decl.cs (DeclSpace.FindMembers): Made this public.
8453 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8455 * delegate.cs: fixed build on windows.
8456 [FIXME: Filed as bug #29150: MCS must report these errors.]
8458 2002-08-19 Ravi Pratap <ravi@ximian.com>
8460 * ecore.cs (StandardConversionExists): Return a false
8461 if we are trying to convert the void type to anything else
8462 since that is not allowed.
8464 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
8465 we flag error 70 in the event an event is trying to be accessed
8466 directly from outside the declaring type.
8468 2002-08-20 Martin Baulig <martin@gnome.org>
8470 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
8471 MemberCache from typemanager.cs to decl.cs.
8473 2002-08-19 Martin Baulig <martin@gnome.org>
8475 * class.cs (TypeContainer): Implement IMemberContainer.
8476 (TypeContainer.DefineMembers): Create the MemberCache.
8477 (TypeContainer.FindMembers): Do better BindingFlags checking; only
8478 return public members if BindingFlags.Public was given, check
8479 whether members are static.
8481 2002-08-16 Martin Baulig <martin@gnome.org>
8483 * decl.cs (DeclSpace.Define): Splitted this in Define and
8484 DefineMembers. DefineMembers is called first and initializes the
8487 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
8488 DefineMembers() on all our DeclSpaces.
8490 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
8491 but call DefineMembers() on all nested interfaces. We call their
8492 Define() in our new Define() function.
8494 * interface.cs (Interface): Implement IMemberContainer.
8495 (Interface.Define): Moved all code except the attribute stuf to
8497 (Interface.DefineMembers): Initialize the member cache.
8499 * typemanager.cs (IMemberFinder): Removed this interface, we don't
8500 need this anymore since we can use MemberCache.FindMembers directly.
8502 2002-08-19 Martin Baulig <martin@gnome.org>
8504 * typemanager.cs (MemberCache): When creating the cache for an
8505 interface type, add all inherited members.
8506 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
8507 to `out bool used_cache' and documented it.
8508 (TypeManager.MemberLookup): If we already used the cache in the first
8509 iteration, we don't need to do the interfaces check.
8511 2002-08-19 Martin Baulig <martin@gnome.org>
8513 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
8514 here from IMemberFinder and don't implement this interface anymore.
8515 (DeclSpace.MemberCache): Moved here from IMemberFinder.
8517 * typemanager.cs (IMemberFinder): This interface is now only used by
8518 classes which actually support the member cache.
8519 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
8520 since we only put DeclSpaces into this Hashtable.
8521 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
8522 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
8524 2002-08-16 Martin Baulig <martin@gnome.org>
8526 * typemanager.cs (ICachingMemberFinder): Removed.
8527 (IMemberFinder.MemberCache): New property.
8528 (TypeManager.FindMembers): Merged this with RealFindMembers().
8529 This function will never be called from TypeManager.MemberLookup()
8530 so we can't use the cache here, just the IMemberFinder.
8531 (TypeManager.MemberLookup_FindMembers): Check whether the
8532 IMemberFinder has a MemberCache and call the cache's FindMembers
8534 (MemberCache): Rewrote larger parts of this yet another time and
8535 cleaned it up a bit.
8537 2002-08-15 Miguel de Icaza <miguel@ximian.com>
8539 * driver.cs (LoadArgs): Support quoting.
8541 (Usage): Show the CSC-like command line arguments.
8543 Improved a few error messages.
8545 2002-08-15 Martin Baulig <martin@gnome.org>
8547 * typemanager.cs (IMemberContainer.Type): New property.
8548 (IMemberContainer.IsInterface): New property.
8550 The following changes are conditional to BROKEN_RUNTIME, which is
8551 defined at the top of the file.
8553 * typemanager.cs (MemberCache.MemberCache): Don't add the base
8554 class'es members, but add all members from TypeHandle.ObjectType
8555 if we're an interface.
8556 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
8557 is the current type.
8558 (MemberCache.CacheEntry.Container): Removed this field.
8559 (TypeHandle.GetMembers): Include inherited members.
8561 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8563 * typemanager.cs: fixed compilation and added a comment on a field that
8566 2002-08-15 Martin Baulig <martin@gnome.org>
8568 * class.cs (ConstructorInitializer.Resolve): In the
8569 Expression.MemberLookup call, use the queried_type as
8572 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
8573 declared' attribute, it's always true.
8574 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
8575 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
8576 temporary wrapper for FindMembers which tells MemberLookup whether
8577 members from the base classes are included in the return value.
8578 This will go away soon.
8579 (TypeManager.MemberLookup): Use this temporary hack here; once the
8580 new MemberCache is completed, we don't need to do the DeclaredOnly
8581 looping here anymore since the MemberCache will take care of this.
8582 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
8583 (MemberCache): When creating the MemberCache for a class, get
8584 members from the current class and all its base classes.
8585 (MemberCache.CacheEntry.Container): New field. This is a
8586 temporary hack until the Mono runtime is fixed to distinguish
8587 between ReflectedType and DeclaringType. It allows us to use MCS
8588 with both the MS runtime and the unfixed Mono runtime without
8589 problems and without accecting performance.
8590 (MemberCache.SearchMembers): The DeclaredOnly looping from
8591 TypeManager.MemberLookup is now done here.
8593 2002-08-14 Martin Baulig <martin@gnome.org>
8595 * statement.cs (MyStructInfo.MyStructInfo): Don't call
8596 Type.GetFields on dynamic types but get the fields from the
8597 corresponding TypeContainer.
8598 (MyStructInfo.GetStructInfo): Added check for enum types.
8600 * typemanager.cs (MemberList.IsSynchronized): Implemented.
8601 (MemberList.SyncRoot): Implemented.
8602 (TypeManager.FilterWithClosure): No need to check permissions if
8603 closure_start_type == closure_invocation_type, don't crash if
8604 closure_invocation_type is null.
8606 2002-08-13 Martin Baulig <martin@gnome.org>
8608 Rewrote TypeContainer.FindMembers to use a member cache. This
8609 gives us a speed increase of about 35% for the self-hosting MCS
8610 build and of about 15-20% for the class libs (both on GNU/Linux).
8612 * report.cs (Timer): New class to get enhanced profiling. This
8613 whole class is "TIMER" conditional since it remarkably slows down
8616 * class.cs (MemberList): New class. This is an IList wrapper
8617 which we're now using instead of passing MemberInfo[]'s around to
8618 avoid copying this array unnecessarily.
8619 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
8620 (ICachingMemberFinder, IMemberContainer): New interface.
8621 (TypeManager.FilterWithClosure): If `criteria' is null, the name
8622 has already been checked, otherwise use it for the name comparision.
8623 (TypeManager.FindMembers): Renamed to RealMemberFinder and
8624 provided wrapper which tries to use ICachingMemberFinder.FindMembers
8625 if possible. Returns a MemberList, not a MemberInfo [].
8626 (TypeHandle): New class, implements IMemberContainer. We create
8627 one instance of this class per type, it contains a MemberCache
8628 which is used to do the member lookups.
8629 (MemberCache): New class. Each instance of this class contains
8630 all members of a type and a name-based hash table.
8631 (MemberCache.FindMembers): This is our new member lookup
8632 function. First, it looks up all members of the requested name in
8633 the hash table. Then, it walks this list and sorts out all
8634 applicable members and returns them.
8636 2002-08-13 Martin Baulig <martin@gnome.org>
8638 In addition to a nice code cleanup, this gives us a performance
8639 increase of about 1.4% on GNU/Linux - not much, but it's already
8640 half a second for the self-hosting MCS compilation.
8642 * typemanager.cs (IMemberFinder): New interface. It is used by
8643 TypeManager.FindMembers to call FindMembers on a TypeContainer,
8644 Enum, Delegate or Interface.
8645 (TypeManager.finder_to_member_finder): New PtrHashtable.
8646 (TypeManager.finder_to_container): Removed.
8647 (TypeManager.finder_to_delegate): Removed.
8648 (TypeManager.finder_to_interface): Removed.
8649 (TypeManager.finder_to_enum): Removed.
8651 * interface.cs (Interface): Implement IMemberFinder.
8653 * delegate.cs (Delegate): Implement IMemberFinder.
8655 * enum.cs (Enum): Implement IMemberFinder.
8657 * class.cs (TypeContainer): Implement IMemberFinder.
8659 2002-08-12 Martin Baulig <martin@gnome.org>
8661 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
8663 2002-08-12 Martin Baulig <martin@gnome.org>
8665 * ecore.cs (ITypeExpression): New interface for expressions which
8667 (TypeExpression): Renamed to TypeLookupExpression.
8668 (Expression.DoResolve): If we're doing a types-only lookup, the
8669 expression must implement the ITypeExpression interface and we
8670 call DoResolveType() on it.
8671 (SimpleName): Implement the new ITypeExpression interface.
8672 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
8673 hack, the situation that we're only looking up types can't happen
8674 anymore when this method is called. Moved the type lookup code to
8675 DoResolveType() and call it.
8676 (SimpleName.DoResolveType): This ITypeExpression interface method
8677 is now doing the types-only lookup.
8678 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
8679 (ResolveFlags): Added MaskExprClass.
8681 * expression.cs (MemberAccess): Implement the ITypeExpression
8683 (MemberAccess.DoResolve): Added support for a types-only lookup
8684 when we're called via ITypeExpression.DoResolveType().
8685 (ComposedCast): Implement the ITypeExpression interface.
8687 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
8688 Expression.Resolve() with ResolveFlags.Type instead.
8690 2002-08-12 Martin Baulig <martin@gnome.org>
8692 * interface.cs (Interface.Define): Apply attributes.
8694 * attribute.cs (Attribute.ApplyAttributes): Added support for
8695 interface attributes.
8697 2002-08-11 Martin Baulig <martin@gnome.org>
8699 * statement.cs (Block.Emit): Only check the "this" variable if we
8700 do not always throw an exception.
8702 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
8703 whether the property has a set accessor.
8705 2002-08-11 Martin Baulig <martin@gnome.org>
8707 Added control flow analysis support for structs.
8709 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
8710 with control flow analysis turned off.
8711 (IVariable): New interface.
8712 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
8713 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
8714 (FieldExpr.DoResolve): Resolve the instance expression with flow
8715 analysis turned off and do the definite assignment check after the
8716 resolving when we know what the expression will resolve to.
8718 * expression.cs (LocalVariableReference, ParameterReference):
8719 Implement the new IVariable interface, only call the flow analysis
8720 code if ec.DoFlowAnalysis is true.
8721 (This): Added constructor which takes a Block argument. Implement
8722 the new IVariable interface.
8723 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
8724 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
8725 This does the definite assignment checks for struct members.
8727 * class.cs (Constructor.Emit): If this is a non-static `struct'
8728 constructor which doesn't have any initializer, call
8729 Block.AddThisVariable() to tell the flow analysis code that all
8730 struct elements must be initialized before control returns from
8733 * statement.cs (MyStructInfo): New public class.
8734 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
8735 argument to this indexer. If non-zero, check an individual struct
8736 member, not the whole struct.
8737 (FlowBranching.CheckOutParameters): Check struct members.
8738 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
8739 overloaded versions of these methods which take an additional
8740 `int field_idx' argument to check struct members.
8741 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
8742 overloaded versions of these methods which take an additional
8743 `string field_name' argument to check struct member.s
8744 (VariableInfo): Implement the IVariable interface.
8745 (VariableInfo.StructInfo): New public property. Returns the
8746 MyStructInfo instance of the variable if it's a struct or null.
8747 (Block.AddThisVariable): New public method. This is called from
8748 Constructor.Emit() for non-static `struct' constructor which do
8749 not have any initializer. It creates a special variable for the
8750 "this" instance variable which will be checked by the flow
8751 analysis code to ensure that all of the struct's fields are
8752 initialized before control returns from the constructor.
8753 (UsageVector): Added support for struct members. If a
8754 variable/parameter is a struct with N members, we reserve a slot
8755 in the usage vector for each member. A struct is considered fully
8756 initialized if either the struct itself (slot 0) or all its
8757 members are initialized.
8759 2002-08-08 Martin Baulig <martin@gnome.org>
8761 * driver.cs (Driver.MainDriver): Only report an error CS5001
8762 if there were no compilation errors.
8764 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
8765 `UnsafeContext' property to determine whether the parent is in
8766 unsafe context rather than checking the parent's ModFlags:
8767 classes nested in an unsafe class are unsafe as well.
8769 2002-08-08 Martin Baulig <martin@gnome.org>
8771 * statement.cs (UsageVector.MergeChildren): Distinguish between
8772 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
8773 we return. Added test17() and test18() to test-154.cs.
8775 2002-08-08 Martin Baulig <martin@gnome.org>
8777 * typemanager.cs (TypeManager.FilterWithClosure): If we have
8778 Family access, make sure the invoking type isn't a subclass of the
8779 queried type (that'd be a CS1540).
8781 * ecore.cs (Expression.MemberLookup): Added overloaded version of
8782 this method which takes an additional `Type invocation_type'.
8784 * expression.cs (BaseAccess.DoResolve): Use the base type as
8785 invocation and query type.
8786 (MemberAccess.DoResolve): If the lookup failed and we're about to
8787 report a CS0122, try a lookup with the ec.ContainerType - if this
8788 succeeds, we must report a CS1540.
8790 2002-08-08 Martin Baulig <martin@gnome.org>
8792 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
8793 (MethodGroupExpr): Implement the IMemberExpr interface.
8795 * expression (MemberAccess.ResolveMemberAccess): No need to have
8796 any special code for MethodGroupExprs anymore, they're now
8799 2002-08-08 Martin Baulig <martin@gnome.org>
8801 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
8802 Family, FamANDAssem and FamORAssem permissions.
8803 (TypeManager.IsSubclassOrNestedChildOf): New public method.
8805 2002-08-08 Martin Baulig <martin@gnome.org>
8807 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
8808 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
8811 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
8813 * driver.cs: implemented /resource option to embed managed resources.
8815 2002-08-07 Martin Baulig <martin@gnome.org>
8817 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
8818 (FieldBase.HasFieldInitializer): New public property.
8819 (FieldBase.GetInitializerExpression): New public method. Resolves and
8820 returns the field initializer and makes sure it is only resolved once.
8821 (TypeContainer.EmitFieldInitializers): Call
8822 FieldBase.GetInitializerExpression to get the initializer, this ensures
8823 that it isn't resolved multiple times.
8825 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
8826 the resolving process (SimpleName/MemberLookup) that we're currently
8827 emitting a field initializer (which must not access any instance members,
8828 this is an error CS0236).
8830 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
8831 argument, if the `IsFieldInitializer' flag is set, we must report and
8832 error CS0236 and not an error CS0120.
8834 2002-08-07 Martin Baulig <martin@gnome.org>
8836 * ecore.cs (IMemberExpr): New public interface.
8837 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
8838 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
8839 if the expression is an IMemberExpr.
8841 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
8842 to be null, implicitly default to `this' if we're non-static in
8843 this case. Simplified the code a lot by using the new IMemberExpr
8844 interface. Also fixed bug #28176 here.
8846 2002-08-06 Martin Baulig <martin@gnome.org>
8848 * cs-parser.jay (SimpleLookup): Removed. We need to create
8849 ParameterReferences during semantic analysis so that we can do a
8850 type-only search when resolving Cast, TypeOf and SizeOf.
8851 (block): Pass the `current_local_parameters' to the Block's
8854 * class.cs (ConstructorInitializer): Added `Parameters parameters'
8855 argument to the constructor.
8856 (ConstructorInitializer.Resolve): Create a temporary implicit
8857 block with the parameters.
8859 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
8860 references here if we aren't doing a type-only search.
8862 * statement.cs (Block): Added constructor which takes a
8863 `Parameters parameters' argument.
8864 (Block.Parameters): New public property.
8866 * support.cs (InternalParameters.Parameters): Renamed `parameters'
8867 to `Parameters' and made it public readonly.
8869 2002-08-06 Martin Baulig <martin@gnome.org>
8871 * ecore.cs (Expression.Warning): Made this public as well.
8873 * report.cs (Report.Debug): Print the contents of collections.
8875 2002-08-06 Martin Baulig <martin@gnome.org>
8877 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
8878 used to tell Resolve() which kinds of expressions it may return.
8879 (Expression.Resolve): Added overloaded version of this method which
8880 takes a `ResolveFlags flags' argument. This can be used to tell
8881 Resolve() which kinds of expressions it may return. Reports a
8883 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
8884 ResolveFlags.SimpleName.
8885 (Expression.Error118): Added overloaded version of this method which
8886 takes a `ResolveFlags flags' argument. It uses the flags to determine
8887 which kinds of expressions are allowed.
8889 * expression.cs (Argument.ResolveMethodGroup): New public method.
8890 Resolves an argument, but allows a MethodGroup to be returned.
8891 This is used when invoking a delegate.
8893 * TODO: Updated a bit.
8895 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8897 Fixed compilation with csc.
8899 * ecore.cs: Expression.Error made public. Is this correct? Should
8900 Warning be made public too?
8902 * expression.cs: use ea.Location instead of ea.loc.
8903 [FIXME: Filed as bug #28607: MCS must report these errors.]
8905 2002-08-06 Martin Baulig <martin@gnome.org>
8907 * ecore.cs (Expression.loc): Moved the location here instead of
8908 duplicating it in all derived classes.
8909 (Expression.Location): New public property.
8910 (Expression.Error, Expression.Warning): Made them non-static and
8911 removed the location argument.
8912 (Expression.Warning): Added overloaded version which takes an
8913 `int level' argument.
8914 (Expression.Error118): Make this non-static and removed the
8915 expression and location arguments.
8916 (TypeExpr): Added location argument to the constructor.
8918 * expression.cs (StaticCallExpr): Added location argument to
8920 (Indirection, PointerArithmetic): Likewise.
8921 (CheckedExpr, UnCheckedExpr): Likewise.
8922 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
8923 (StringPtr): Likewise.
8926 2002-08-05 Martin Baulig <martin@gnome.org>
8928 * expression.cs (BaseAccess.DoResolve): Actually report errors.
8930 * assign.cs (Assign.DoResolve): Check whether the source
8931 expression is a value or variable.
8933 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
8934 while resolving the corresponding blocks.
8936 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
8937 an error, don't silently return null.
8939 * statement.cs (Block.AddVariable): Do the error reporting here
8940 and distinguish between CS0128 and CS0136.
8941 (Block.DoResolve): Report all unused labels (warning CS0164).
8942 (LabeledStatement): Pass the location to the constructor.
8943 (LabeledStatement.HasBeenReferenced): New property.
8944 (LabeledStatement.Resolve): Set it to true here.
8946 * statement.cs (Return.Emit): Return success even after reporting
8947 a type mismatch error (CS0126 or CS0127), this is what csc does and
8948 it avoids confusing the users with any consecutive errors.
8950 2002-08-05 Martin Baulig <martin@gnome.org>
8952 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
8954 * const.cs (Const.LookupConstantValue): Catch circular definitions.
8956 * expression.cs (MemberAccess.DoResolve): Silently return if an
8957 error has already been reported.
8959 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
8960 error has already been reported.
8962 2002-08-05 Martin Baulig <martin@gnome.org>
8964 * statement.cs (UsageVector): Only initialize the `parameters'
8965 vector if we actually have any "out" parameters.
8967 2002-08-05 Martin Baulig <martin@gnome.org>
8969 * expression.cs (Binary.ResolveOperator): When combining delegates,
8970 they must have the same type.
8972 2002-08-05 Martin Baulig <martin@gnome.org>
8974 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
8975 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
8976 work with the ms runtime and we also don't need it: if we're a
8977 PropertyBuilder and not in the `indexer_arguments' hash, then we
8978 are a property and not an indexer.
8980 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
8981 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
8982 since the latter one doesn't work with the ms runtime.
8984 2002-08-03 Martin Baulig <martin@gnome.org>
8986 Fixed bugs #27998 and #22735.
8988 * class.cs (Method.IsOperator): New public field.
8989 (Method.CheckBase): Report CS0111 if there's already a method
8990 with the same parameters in the current class. Report CS0508 when
8991 attempting to change the return type of an inherited method.
8992 (MethodData.Emit): Report CS0179 if a method doesn't have a body
8993 and it's not marked abstract or extern.
8994 (PropertyBase): New abstract base class for Property and Indexer.
8995 (PropertyBase.CheckBase): Moved here from Property and made it work
8997 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
8998 the same so we can reuse it there.
8999 (Property, Indexer): Derive from PropertyBase.
9000 (MethodSignature.inheritable_property_signature_filter): New delegate
9001 to find properties and indexers.
9003 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
9004 argument and improved error reporting.
9006 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
9007 EmptyReadOnlyParameters and made it a property.
9009 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
9010 version of this method which takes a `PropertyInfo indexer'.
9011 (TypeManager.RegisterIndexer): New method.
9013 * class.cs: Added myself as author of this file :-)
9015 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9017 * class.cs: fixed compilation on windoze.
9019 2002-08-03 Martin Baulig <martin@gnome.org>
9021 * interface.cs (Interface.GetInterfaceBases): Check whether all
9022 base interfaces are at least as accessible than the current one.
9024 * class.cs (TypeContainer.GetClassBases): Check whether base types
9025 are at least as accessible than the current type.
9026 (TypeContainer.AsAccessible): Implemented and made non-static.
9027 (MemberBase.CheckParameters): Report errors if the accessibility
9030 * delegate.cs (Delegate.Delegate): The default visibility is
9031 internal for top-level types and private for nested types.
9032 (Delegate.Define): Report errors if the accessibility checks fail.
9034 * enum.cs (Enum.Enum): The default visibility is internal for
9035 top-level types and private for nested types.
9036 (Enum.DefineType): Compute the correct visibility.
9038 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
9039 function which takes a `bool is_toplevel' instead of a TypeContainer.
9041 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
9044 2002-08-02 Martin Baulig <martin@gnome.org>
9046 * expression.cs (LocalVariableReferenc): Added constructor which
9047 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
9048 (LocalVariableReference.IsReadOnly): New property.
9049 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
9050 variable is readonly, use our own readonly flag to do this; you can
9051 use the new constructor to get a writable reference to a read-only
9054 * cs-parser.jay (foreach_statement, using_statement): Get a writable
9055 reference to the local variable.
9057 2002-08-01 Miguel de Icaza <miguel@ximian.com>
9059 * rootcontext.cs (ResolveCore): Also include System.Exception
9061 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
9062 we reach an EmptyStatement.
9064 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
9067 * expression.cs (Binary.ResolveOperator): Check error result in
9070 use brtrue/brfalse directly and avoid compares to null.
9072 2002-08-02 Martin Baulig <martin@gnome.org>
9074 * class.cs (TypeContainer.Define): Define all nested interfaces here.
9075 Fixes bug #28407, added test-155.cs.
9077 2002-08-01 Martin Baulig <martin@gnome.org>
9079 * class.cs (Event.EmitDefaultMethod): Make this work with static
9080 events. Fixes #28311, added verify-3.cs.
9082 2002-08-01 Martin Baulig <martin@gnome.org>
9084 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
9085 `is_disposable' fields.
9086 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
9087 `hm.is_disposable' if we're using the collection pattern.
9088 (Foreach.EmitCollectionForeach): Use the correct type for the
9089 enumerator's local variable, only emit the try/finally block if
9090 necessary (fixes #27713).
9092 2002-08-01 Martin Baulig <martin@gnome.org>
9094 * ecore.cs (Expression.report118): Renamed to Error118 and made
9097 * statement.cs (Throw.Resolve): Check whether the expression is of
9098 the correct type (CS0118) and whether the type derives from
9099 System.Exception (CS0155).
9100 (Catch.Resolve): New method. Do the type lookup here and check
9101 whether it derives from System.Exception (CS0155).
9102 (Catch.CatchType, Catch.IsGeneral): New public properties.
9104 * typemanager.cs (TypeManager.exception_type): Added.
9106 2002-07-31 Miguel de Icaza <miguel@ximian.com>
9108 * driver.cs: Updated About function.
9110 2002-07-31 Martin Baulig <martin@gnome.org>
9112 Implemented Control Flow Analysis.
9114 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
9115 (EmitContext.CurrentBranching): Added.
9116 (EmitContext.StartFlowBranching): Added.
9117 (EmitContext.EndFlowBranching): Added.
9118 (EmitContext.KillFlowBranching): Added.
9119 (EmitContext.IsVariableAssigned): Added.
9120 (EmitContext.SetVariableAssigned): Added.
9121 (EmitContext.IsParameterAssigned): Added.
9122 (EmitContext.SetParameterAssigned): Added.
9123 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
9124 Added control flow analysis stuff here.
9126 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
9127 resolve the expression as lvalue.
9128 (LocalVariableReference.DoResolve): Check whether the variable has
9129 already been assigned.
9130 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
9131 the parameter as assigned here.
9132 (ParameterReference.DoResolve): Check whether the parameter has already
9134 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
9135 expression as lvalue.
9137 * statement.cs (FlowBranching): New class for the flow analysis code.
9138 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
9139 (LabeledStatement.IsDefined): New public property.
9140 (LabeledStatement.AddUsageVector): New public method to tell flow
9141 analyis that the label may be reached via a forward jump.
9142 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
9144 (VariableInfo.Number): New public field. This is used by flow analysis
9145 to number all locals of a block.
9146 (Block.CountVariables): New public property. This is the number of
9147 local variables in this block (including the locals from all parent
9149 (Block.EmitMeta): Number all the variables.
9151 * statement.cs: Added flow analysis support to all classes.
9153 2002-07-31 Martin Baulig <martin@gnome.org>
9155 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
9156 To get debugging messages, compile mcs with /define:MCS_DEBUG and
9157 then use this argument.
9159 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
9161 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
9162 use this to specify /define options.
9164 2002-07-29 Martin Baulig <martin@gnome.org>
9166 * statement.cs (Fixed): Moved all code that does variable lookups
9167 and resolvings from Emit to Resolve.
9169 * statement.cs (For): Moved all code that does variable lookups
9170 and resolvings from Emit to Resolve.
9172 * statement.cs (Using): Moved all code that does variable lookups
9173 and resolvings from Emit to Resolve.
9175 2002-07-29 Martin Baulig <martin@gnome.org>
9177 * attribute.cs (Attribute.Resolve): Explicitly catch a
9178 System.NullReferenceException when creating the
9179 CustromAttributeBuilder and report a different warning message.
9181 2002-07-29 Martin Baulig <martin@gnome.org>
9183 * support.cs (ParameterData.ParameterName): Added method to
9184 get the name of a parameter.
9186 * typemanager.cs (TypeManager.IsValueType): New public method.
9188 2002-07-29 Martin Baulig <martin@gnome.org>
9190 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
9191 is a flag which specifies that it's either ref or out.
9192 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
9193 the out parameter to `out Parameter.Modifier mod', also set the
9194 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
9196 * support.cs (InternalParameters.ParameterModifier): Distinguish
9197 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9198 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9200 * expression.cs (Argument.GetParameterModifier): Distinguish
9201 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9202 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9204 2002-07-29 Martin Baulig <martin@gnome.org>
9206 * expression.cs (ParameterReference.ParameterReference): Added
9207 `Location loc' argument to the constructor.
9209 * cs-parser.jay: Pass location to ParameterReference.
9211 2002-07-28 Miguel de Icaza <miguel@ximian.com>
9213 * statement.cs (Try): Initialize the location.
9215 * cs-parser.jay: pass location to Try.
9217 * expression.cs (Unary.Reduce): Change the prototype to return
9218 whether a constant fold could be performed or not. The result is
9219 returned in an out parameters. In the case of Indirection and
9220 AddressOf, we want to perform the full tests.
9222 2002-07-26 Miguel de Icaza <miguel@ximian.com>
9224 * statement.cs (Statement.Emit): Flag dead code.
9226 2002-07-27 Andrew Birkett <andy@nobugs.org>
9228 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
9230 2002-07-27 Martin Baulig <martin@gnome.org>
9232 * class.cs (MethodData.Define): Put back call to
9233 TypeManager.AddMethod(), accidentally commented this out.
9235 * report.cs (Debug): New public method to print debugging information,
9236 this is `[Conditional ("DEBUG")]'.
9238 2002-07-26 Martin Baulig <martin@gnome.org>
9240 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
9241 (switch_statement): Push the current_block to the switch_stack and
9242 pop it again when we're done with the switch.
9243 (switch_section): The new block is a child of the current_block.
9244 Fixes bug #24007, added test-152.cs.
9246 2002-07-27 Martin Baulig <martin@gnome.org>
9248 * expression.cs (Invocation.EmitArguments): When calling a varargs
9249 function with only its fixed arguments, we need to pass an empty
9252 2002-07-27 Martin Baulig <martin@gnome.org>
9254 Mono 0.13 has been released.
9256 2002-07-25 Miguel de Icaza <miguel@ximian.com>
9258 * driver.cs: Rename --resource to --linkres, because that is what
9259 we do currently, we dont support --resource yet.
9261 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
9263 2002-07-25 Martin Baulig <martin@gnome.org>
9265 * class.cs (MethodData): New public class. This is a `method builder'
9266 class for a method or one accessor of a Property/Indexer/Event.
9267 (MethodData.GetMethodFlags): Moved here from MemberBase.
9268 (MethodData.ApplyAttributes): Likewise.
9269 (MethodData.ApplyObsoleteAttribute): Likewise.
9270 (MethodData.ApplyConditionalAttribute): Likewise.
9271 (MethodData.ApplyDllImportAttribute): Likewise.
9272 (MethodData.CheckAbstractAndExternal): Likewise.
9273 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
9274 (MethodData.Emit): Formerly known as Method.Emit().
9275 (MemberBase): Moved everything which was specific to a single
9276 accessor/method to MethodData.
9277 (Method): Create a new MethodData and call Define() and Emit() on it.
9278 (Property, Indexer, Event): Create a new MethodData objects for each
9279 accessor and call Define() and Emit() on them.
9281 2002-07-25 Martin Baulig <martin@gnome.org>
9283 Made MethodCore derive from MemberBase to reuse the code from there.
9284 MemberBase now also checks for attributes.
9286 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
9287 (MemberBase.GetMethodFlags): Moved here from class Method and marked
9289 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
9290 `CallingConventions cc' and `Attributes opt_attrs' arguments.
9291 (MemberBase.ApplyAttributes): New virtual method; applies the
9292 attributes to a method or accessor.
9293 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
9294 (MemberBase.ApplyConditionalAttribute): Likewise.
9295 (MemberBase.ApplyDllImportAttribute): Likewise.
9296 (MemberBase.CheckAbstractAndExternal): Likewise.
9297 (MethodCore.ParameterTypes): This is now a property instead of a
9298 method, it's initialized from DoDefineParameters().
9299 (MethodCore.ParameterInfo): Removed the set accessor.
9300 (MethodCore.DoDefineParameters): New protected virtual method to
9301 initialize ParameterTypes and ParameterInfo.
9302 (Method.GetReturnType): We can now simply return the MemberType.
9303 (Method.GetMethodFlags): Override the MemberBase version and add
9304 the conditional flags.
9305 (Method.CheckBase): Moved some code from Define() here, call
9306 DoDefineParameters() here.
9307 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
9308 here to avoid some larger code duplication.
9309 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
9310 ensure that abstract and external accessors don't declare a body.
9312 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
9313 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
9314 lookup in the attribute's parent classes, so we need to abort as soon
9315 as we found the first match.
9316 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
9317 the attribute has no arguments.
9319 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
9322 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9324 * cs-parser.jay: reverted previous patch.
9326 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9328 * cs-parser.jay: fixed bug #22119.
9330 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9332 * attribute.cs: fixed compilation. The error was:
9333 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
9334 be assigned to before control leaves the current method."
9335 [FIXME: Filed as bug #28186: MCS must report this error.]
9337 2002-07-25 Martin Baulig <martin@gnome.org>
9339 * attribute.cs (Attribute.Conditional_GetConditionName): New static
9340 method to pull the condition name ouf of a Conditional attribute.
9341 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
9342 the obsolete message and error flag out of an Obsolete attribute.
9344 * class.cs (Method.GetMethodFlags): New public method to get the
9345 TypeManager.MethodFlags for this method.
9346 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
9348 (Method.Define): Get and apply the Obsolete and Conditional attributes;
9349 if we're overriding a virtual function, set the new private variable
9350 `parent_method'; call the new TypeManager.AddMethod().
9352 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
9353 the MethodBuilder and the Method in a PtrHashtable.
9354 (TypeManager.builder_to_method): Added for this purpose.
9355 (TypeManager.MethodFlags): Added IsObsoleteError.
9356 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
9357 Obsolete and Conditional arguments in MethodBuilders. If we discover
9358 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
9359 the message from the attribute.
9361 2002-07-24 Martin Baulig <martin@gnome.org>
9363 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
9364 preprocessor directives, ensure that the argument to #define/#undef is
9365 exactly one identifier and that it's actually an identifier.
9367 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
9370 2002-07-24 Martin Baulig <martin@gnome.org>
9372 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
9373 initialize it to TypeManager.object_type in the constructor.
9374 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
9375 of the `hm.get_current' method if we're using the collection pattern.
9376 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
9377 for the explicit conversion to make it work when we're using the collection
9378 pattern and the `Current' property has a different return type than `object'.
9381 2002-07-24 Martin Baulig <martin@gnome.org>
9383 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
9384 does not match, but don't report any errors. This method is called in
9385 order for all methods in a MethodGroupExpr until a matching method is
9386 found, so we don't want to bail out if the first method doesn't match.
9387 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
9388 matches, report the 123. Fixes #28070.
9390 2002-07-24 Martin Baulig <martin@gnome.org>
9392 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
9393 TypeManager.TypeToCoreType() to the top of the method so the
9394 following equality checks will work. Fixes #28107.
9396 2002-07-24 Martin Baulig <martin@gnome.org>
9398 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
9399 operand is of type uint, and the other operand is of type sbyte,
9400 short or int, the operands are converted to type long." -
9401 Actually do what this comment already told us. Fixes bug #28106,
9404 2002-07-24 Martin Baulig <martin@gnome.org>
9406 * class.cs (MethodBase): New abstract class. This is now a base
9407 class for Property, Indexer and Event to avoid some code duplication
9408 in their Define() and DefineMethods() methods.
9409 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
9410 generic methods for Define() and DefineMethods().
9411 (FieldBase): Derive from MemberBase, not MemberCore.
9412 (Property): Derive from MemberBase, not MemberCore.
9413 (Property.DefineMethod): Moved all the code from this method to the
9414 new MethodBase.DefineAccessor(), just call it with appropriate
9416 (Property.Define): Call the new Property.DoDefine(), this does some
9417 sanity checks and we don't need to duplicate the code everywhere.
9418 (Event): Derive from MemberBase, not MemberCore.
9419 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
9420 accessors, this will also make them work with interface events.
9421 (Indexer): Derive from MemberBase, not MemberCore.
9422 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
9423 (Indexer.Define): Use the new MethodBase functions.
9425 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
9426 argument to the constructor.
9427 (Interface.FindMembers): Added support for interface events.
9428 (Interface.PopluateEvent): Implemented.
9430 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
9432 2002-07-22 Miguel de Icaza <miguel@ximian.com>
9434 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
9435 but this is required to check for a method name being the same as
9436 the containing class.
9440 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9442 * interface.cs: initialize variable.
9444 2002-07-23 Martin Baulig <martin@gnome.org>
9446 Implemented the IndexerName attribute in interfaces.
9448 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
9449 name if this is an explicit interface implementation.
9450 (Indexer.InterfaceIndexerName): New public variable. If we're
9451 implementing an interface indexer, this is the IndexerName in that
9452 interface. Otherwise, it's the IndexerName.
9453 (Indexer.DefineMethod): If we're implementing interface indexer,
9454 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
9455 and Pending.ImplementIndexer methods.
9456 (Indexer.Define): Also define the PropertyBuilder if we're
9457 implementing an interface indexer and this is neither an explicit
9458 interface implementation nor do the IndexerName match the one in
9461 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
9462 If a method is defined here, then we always need to create a proxy
9463 for it. This is used when implementing interface indexers.
9464 (Pending.IsInterfaceIndexer): New public method.
9465 (Pending.ImplementIndexer): New public method.
9466 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
9467 This is used when implementing interface indexers to define a proxy
9469 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
9470 define a proxy if necessary.
9472 * interface.cs (Interface.IndexerName): New public variable.
9473 (Interface.PopulateIndexer): Set the IndexerName.
9474 (Interface.DefineIndexers): New private method. Populate all the
9475 indexers and make sure their IndexerNames match.
9477 * typemanager.cs (IndexerPropertyName): Added support for interface
9480 2002-07-22 Martin Baulig <martin@gnome.org>
9482 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
9483 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
9484 ret if HasReturnLabel.
9485 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
9488 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
9489 and set the ec.LoopBeginTryCatchLevel.
9490 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
9491 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
9492 the current ec.TryCatchLevel, the branch goes out of an exception
9493 block. In this case, we need to use Leave and not Br.
9495 2002-07-22 Martin Baulig <martin@gnome.org>
9497 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
9498 block unless the block does not always return or it is contained in
9499 another try { ... } catch { ... } block. Fixes bug #26506.
9500 Added verify-1.cs to the test suite.
9502 2002-07-22 Martin Baulig <martin@gnome.org>
9504 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
9505 then we do not always return. Fixes bug #24985.
9507 2002-07-22 Martin Baulig <martin@gnome.org>
9509 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
9510 lookup on a per-class level; ie. walk up the class hierarchy until we
9511 found at least one applicable method, then choose the best among them.
9512 Fixes bug #24463 and test-29.cs.
9514 2002-07-22 Martin Baulig <martin@gnome.org>
9516 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
9517 return types of the methods. The return type is not part of the
9518 signature and we must not check it to make the `new' modifier work.
9519 Fixes bug #27999, also added test-147.cs.
9520 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
9522 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
9523 on the method's return type.
9525 2002-07-21 Martin Baulig <martin@gnome.org>
9527 * assign.cs: Make this work if the rightmost source is a constant and
9528 we need to do an implicit type conversion. Also adding a few more tests
9529 to test-38.cs which should have caught this.
9531 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
9532 target in the makefile for this. The makefile.gnu is primarily intended
9533 for end-users who don't want to debug the compiler.
9535 2002-07-21 Martin Baulig <martin@gnome.org>
9537 * assign.cs: Improved the Assign class so it can now handle embedded
9538 assignments (X = Y = Z = something). As a side-effect this'll now also
9539 consume less local variables. test-38.cs now passes with MCS, added
9540 a few new test cases to that test.
9542 2002-07-20 Martin Baulig <martin@gnome.org>
9544 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
9545 instructions. Fixes bug #27977, also added test-146.cs.
9547 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9549 * cs-tokenizer.cs: fixed getHex ().
9551 2002-07-19 Martin Baulig <martin@gnome.org>
9553 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
9554 not Type.GetType() to lookup the array type. This is needed when
9555 we're constructing an array of a user-defined type.
9556 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
9557 single-dimensional arrays, but also for single-dimensial arrays of
9560 2002-07-19 Martin Baulig <martin@gnome.org>
9562 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
9563 this function is called, it's not allowed to share LocalBuilders
9566 2002-07-19 Martin Baulig <martin@gnome.org>
9568 * expression.cs (Argument.Resolve): Report an error 118 when trying
9569 to pass a type as argument.
9571 2002-07-18 Martin Baulig <martin@gnome.org>
9573 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
9574 Conv_R_Un for the signed `long' type.
9576 2002-07-15 Miguel de Icaza <miguel@ximian.com>
9578 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
9579 `expr' for the temporary result, as that will fail if we do
9580 multiple resolves on the same expression.
9582 2002-07-05 Miguel de Icaza <miguel@ximian.com>
9584 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
9585 ec.TypeContainer for looking up aliases.
9587 * class.cs (TypeContainer): Remove LookupAlias from here.
9589 * decl.cs (DeclSpace); Move here.
9591 2002-07-01 Miguel de Icaza <miguel@ximian.com>
9593 * class.cs (FindMembers): Only call filter if the constructor
9594 bulider is not null.
9596 Also handle delegates in `NestedTypes' now. Now we will perform
9597 type lookups using the standard resolution process. This also
9600 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
9601 This uses Expressions (the limited kind that can be parsed by the
9602 tree) instead of strings.
9604 * expression.cs (ComposedCast.ToString): Implement, used to flag
9605 errors since now we have to render expressions.
9607 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
9610 * ecore.cs (SimpleName.ToString): ditto.
9612 * cs-parser.jay: Instead of using strings to assemble types, use
9613 Expressions to assemble the type (using SimpleName, ComposedCast,
9614 MemberAccess). This should fix the type lookups in declarations,
9615 because we were using a different code path for this.
9617 * statement.cs (Block.Resolve): Continue processing statements
9618 even when there is an error.
9620 2002-07-17 Miguel de Icaza <miguel@ximian.com>
9622 * class.cs (Event.Define): Also remove the `remove' method from
9623 the list of pending items.
9625 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
9626 generate more compact code.
9628 2002-07-17 Martin Baulig <martin@gnome.org>
9630 * const.cs (Const.LookupConstantValue): Add support for constant
9631 `unchecked' and `checked' expressions.
9632 Also adding test case test-140.cs for this.
9634 2002-07-17 Martin Baulig <martin@gnome.org>
9636 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
9637 check whether mi.ReturnType implements the IEnumerator interface; the
9638 `==' and the IsAssignableFrom() will fail in this situation.
9640 2002-07-16 Ravi Pratap <ravi@ximian.com>
9642 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
9645 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9647 * expression.cs: fixed bug #27811.
9649 2002-07-14 Miguel de Icaza <miguel@ximian.com>
9651 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
9652 Molaro: when we are a ref, the value already contains a pointer
9653 value, do not take the address of it.
9655 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
9656 * removed mb-parser.jay and mb-tokenizer.cs
9658 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
9660 * expression.cs: check against the building corlib void type.
9662 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
9664 * ecore.cs: fix for valuetype static readonly fields: when
9665 initializing them, we need their address, not the address of a copy.
9667 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
9669 * typemanager.cs: register also enum_type in corlib.
9671 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
9673 * class.cs: allow calling this (but not base) initializers in structs.
9675 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
9677 * ecore.cs: make sure we compare against the building base types
9680 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
9682 * typemanager.cs: fix TypeToCoreType() to handle void and object
9683 (corlib gets no more typerefs after this change).
9685 2002-07-12 Miguel de Icaza <miguel@ximian.com>
9687 * expression.cs (ArrayCreation.EmitArrayArguments): use
9688 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
9690 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
9691 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
9692 array indexes, the runtime actually forbids them.
9694 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
9695 for array arguments here.
9697 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
9698 instead of the default for ValueTypes.
9700 (New.DoEmit): Use IsValueType instead of
9701 IsSubclassOf (value_type)
9702 (New.DoResolve): ditto.
9703 (Invocation.EmitCall): ditto.
9705 * assign.cs (Assign): ditto.
9707 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
9708 Statements *are* currently doing part of their resolution during
9711 Expressions do always resolve during resolve, but statements are
9712 only required to propagate resolution to their children.
9714 2002-07-11 Miguel de Icaza <miguel@ximian.com>
9716 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
9718 (LoadAssembly): Do not add the dll if it is already specified
9720 (MainDriver): Add the System directory to the link path at the end,
9721 after all the other -L arguments.
9723 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
9724 wrong opcode for loading bytes and bools (ldelem.i1 instead of
9725 ldelem.u1) and using the opposite for sbytes.
9727 This fixes Digger, and we can finally run it.
9729 * driver.cs (UnixParseOption): Move the option parsing here.
9730 (CSCParseOption): Implement CSC-like parsing of options.
9732 We now support both modes of operation, the old Unix way, and the
9733 new CSC-like way. This should help those who wanted to make cross
9736 The only thing broken is that /r:, /reference: and /lib: are not
9737 implemented, because I want to make those have the same semantics
9738 as the CSC compiler has, and kill once and for all the confussion
9739 around this. Will be doing this tomorrow.
9741 * statement.cs (Unsafe.Resolve): The state is checked during
9742 resolve, not emit, so we have to set the flags for IsUnsfe here.
9744 2002-07-10 Miguel de Icaza <miguel@ximian.com>
9746 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
9747 not catch the Error_ObjectRefRequired in SimpleName (as it is
9748 possible to have a class/instance variable name that later gets
9749 deambiguated), we have to check this here.
9751 2002-07-10 Ravi Pratap <ravi@ximian.com>
9753 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
9754 make static and put into Expression.
9756 (Event.Define): Register the private field of the event with the
9757 TypeManager so that GetFieldFromEvent can get at it.
9759 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
9760 keep track of the private field associated with an event which
9763 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
9766 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
9768 2002-07-10 Miguel de Icaza <miguel@ximian.com>
9770 * expression.cs (Binary.EmitBranchable): this routine emits the
9771 Binary expression in a branchable context. This basically means:
9772 we need to branch somewhere, not just get the value on the stack.
9774 This works together with Statement.EmitBoolExpression.
9776 * statement.cs (Statement.EmitBoolExpression): Use
9779 2002-07-09 Miguel de Icaza <miguel@ximian.com>
9781 * statement.cs (For): Reduce the number of jumps in loops.
9783 (For): Implement loop inversion for the For statement.
9785 (Break): We can be breaking out of a Try/Catch controlled section
9786 (foreach might have an implicit try/catch clause), so we need to
9787 use Leave instead of Br.
9789 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
9790 now). If the instace expression supports IMemoryLocation, we use
9791 the AddressOf method from the IMemoryLocation to extract the
9792 address instead of emitting the instance.
9794 This showed up with `This', as we were emitting the instance
9795 always (Emit) instead of the Address of This. Particularly
9796 interesting when This is a value type, as we dont want the Emit
9797 effect (which was to load the object).
9799 2002-07-08 Miguel de Icaza <miguel@ximian.com>
9801 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
9803 * statement.cs (Checked): Set the CheckedState during the resolve
9804 process too, as the ConvCast operations track the checked state on
9805 the resolve process, and not emit.
9807 * cs-parser.jay (namespace_member_declaration): Flag that we have
9808 found a declaration when we do. This is used to flag error 1529
9810 * driver.cs: Report ok when we display the help only.
9812 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
9814 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
9816 2002-07-04 Miguel de Icaza <miguel@ximian.com>
9818 * cs-tokenizer.cs (define): We also have to track locally the
9819 defines. AllDefines is just used for the Conditional Attribute,
9820 but we also need the local defines for the current source code.
9822 2002-07-03 Miguel de Icaza <miguel@ximian.com>
9824 * statement.cs (While, For, Do): These loops can exit through a
9825 Break statement, use this information to tell whether the
9826 statement is the last piece of code.
9828 (Break): Flag that we break.
9830 * codegen.cs (EmitContexts): New `Breaks' state variable.
9832 2002-07-03 Martin Baulig <martin@gnome.org>
9834 * class.cs (TypeContainer.MethodModifiersValid): Allow override
9835 modifiers in method declarations in structs. Otherwise, you won't
9836 be able to override things like Object.Equals().
9838 2002-07-02 Miguel de Icaza <miguel@ximian.com>
9840 * class.cs (Method, Property, Indexer): Do not allow the public
9841 modifier to be used in explicit interface implementations.
9843 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
9844 override modifiers in method declarations in structs
9846 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
9848 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
9849 integer or real overflow, report an error
9851 2002-07-02 Martin Baulig <martin@gnome.org>
9853 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
9854 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
9855 to tell the runtime about our newly created System.Object and
9856 System.ValueType types.
9858 2002-07-02 Miguel de Icaza <miguel@ximian.com>
9860 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
9861 struct instead of Ldarg/Starg.
9863 2002-07-02 Martin Baulig <martin@gnome.org>
9865 * expression.cs (Indirection.Indirection): Call
9866 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
9868 2002-07-02 Martin Baulig <martin@gnome.org>
9870 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
9871 ValueType, call TypeManager.TypeToCoreType() on it.
9872 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
9873 the OpCodes.Newarr argument.
9875 2002-07-02 Martin Baulig <martin@gnome.org>
9877 * expression.cs (Invocation.EmitCall): When compiling corlib,
9878 replace all calls to the system's System.Array type to calls to
9879 the newly created one.
9881 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
9882 System.Array methods.
9883 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
9884 from the system's System.Array type which must be replaced.
9886 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
9888 * typemanager.cs: load unverifiable_code_ctor so we can build
9889 corlib using the correct type. Avoid using GetTypeCode() with
9891 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
9892 TypeManager.object_type to allow building corlib.
9894 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
9896 * ecore.cs: handle System.Enum separately in LoadFromPtr().
9898 2002-07-01 Martin Baulig <martin@gnome.org>
9900 * class.cs: Make the last change actually work, we need to check
9901 whether `ifaces != null' to avoid a crash.
9903 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
9905 * class.cs: when we build structs without fields that implement
9906 interfaces, we need to add the interfaces separately, since there is
9907 no API to both set the size and add the interfaces at type creation
9910 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
9912 * expression.cs: the dimension arguments to the array constructors
9913 need to be converted if they are a long.
9915 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
9917 * class.cs: don't emit ldarg.0 if there is no parent constructor
9918 (fixes showstopper for corlib).
9920 2002-06-29 Martin Baulig <martin@gnome.org>
9922 MCS now compiles corlib on GNU/Linux :-)
9924 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
9925 ie. check for MethodImplOptions.InternalCall.
9927 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
9928 and TypeManager.attribute_type are null, so we must explicitly check
9929 whether parent is not null to find out whether it's an attribute type.
9930 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
9931 and SetBuilder, not only if the property is neither abstract nor external.
9932 This is necessary to set the MethodImplOptions on the accessor methods.
9933 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
9934 SetBuilder, see Property.Emit().
9936 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
9937 populate "System.Object", "System.ValueType" and "System.Attribute" since
9938 they've already been populated from BootCorlib_PopulateCoreTypes().
9940 2002-06-29 Martin Baulig <martin@gnome.org>
9942 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
9943 is the NullLiteral, we also need to make sure that target_type is not
9946 2002-06-29 Martin Baulig <martin@gnome.org>
9948 * rootcontext.cs (RootContext.ResolveCore): We must initialize
9949 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
9950 before calling BootstrapCorlib_ResolveDelegate ().
9952 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9954 * statement.cs: fixed build-breaker. All tests passed ok.
9956 2002-06-27 Martin Baulig <martin@gnome.org>
9958 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
9959 for System.Decimal when compiling corlib.
9961 2002-06-27 Martin Baulig <martin@gnome.org>
9963 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
9964 switch blocks which contain nothing but a default clause.
9966 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
9968 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
9970 2002-06-27 Martin Baulig <martin@gnome.org>
9972 * ecore.cs (PropertyExpr.PropertyExpr): Call
9973 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
9975 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
9976 is already a TypeBuilder.
9978 2002-06-27 Martin Baulig <martin@gnome.org>
9980 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
9981 `target_type == TypeManager.array_type', not IsAssignableFrom() in
9982 the "from an array-type to System.Array" case. This makes it work
9983 when compiling corlib.
9985 2002-06-27 Martin Baulig <martin@gnome.org>
9987 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
9988 non-static PropertyExpr, set its InstanceExpression. This makes
9989 the `ICollection.Count' property work in System/Array.cs.
9991 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
9993 * driver.cs: Made error handling more consistent. Errors now
9994 tracked by Report class, so many methods which used to return int
9995 now return void. Main() now prints success/failure and
9996 errors/warnings message.
9998 Renamed '--probe' compiler argument to '--expect-error'. Removed
9999 the magic number return values (123 and 124). Now, if the
10000 expected error occurs, the compiler exits with success (exit value
10001 0). If the compilation completes without seeing that particular
10002 error, the compiler exits with failure (exit value 1). The
10003 makefile in mcs/errors has been changed to handle the new behaviour.
10005 * report.cs: Made 'expected error' number a property and renamed
10006 it from 'Probe' to 'ExpectedError'.
10008 * genericparser.cs: Removed error handling support, since it is
10009 now all done by Report class.
10011 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
10012 class, so parse() no longer returns an int.
10014 * namespace.cs: Use Report.Error instead of GenericParser.error
10016 2002-06-22 Miguel de Icaza <miguel@ximian.com>
10018 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
10019 TypeContainer.AddOperator): At the front of the list put the
10020 explicit implementations, so they get resolved/defined first.
10022 2002-06-21 Miguel de Icaza <miguel@ximian.com>
10024 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
10025 interface type is implemented by this TypeContainer. Used during
10026 explicit interface implementation.
10028 (Property.Define, Indexer.Define, Method.Define): Validate that
10029 the given interface in the explicit implementation is one of the
10030 base classes for the containing type.
10032 Also if we are explicitly implementing an interface, but there is
10033 no match in the pending implementation table, report an error.
10035 (Property.Define): Only define the property if we are
10036 not explicitly implementing a property from an interface. Use the
10037 correct name also for those properties (the same CSC uses,
10038 although that is really not needed).
10040 (Property.Emit): Do not emit attributes for explicitly implemented
10041 properties, as there is no TypeBuilder.
10043 (Indexer.Emit): ditto.
10045 Hiding then means that we do not really *implement* a pending
10046 implementation, which makes code fail.
10048 2002-06-22 Martin Baulig <martin@gnome.org>
10050 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
10051 the return value of Object.GetType(). [FIXME: we need to do this whenever
10052 we get a type back from the reflection library].
10054 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
10056 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
10058 2002-06-20 Miguel de Icaza <miguel@ximian.com>
10060 * attribute.cs: Return null if we can not look up the type.
10062 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
10063 the interface types found.
10065 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
10066 interface types found.
10068 * typemanager.cs (GetInterfaces): Make this routine returns alll
10069 the interfaces and work around the lame differences between
10070 System.Type and System.Reflection.Emit.TypeBuilder in the results
10071 result for GetInterfaces.
10073 (ExpandInterfaces): Given an array of interface types, expand and
10074 eliminate repeated ocurrences of an interface. This expands in
10075 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
10078 2002-06-21 Martin Baulig <martin@gnome.org>
10080 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
10083 2002-06-21 Martin Baulig <martin@gnome.org>
10085 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
10086 and called with one of the core types, return the corresponding typebuilder for
10089 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
10092 2002-06-21 Martin Baulig <martin@gnome.org>
10094 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
10095 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
10096 (Expression.ConvertReferenceExplicit): Likewise.
10098 * expression.cs (ElementAccess.DoResolve): Likewise.
10099 (ElementAccess.DoResolveLValue): Likewise.
10101 2002-06-10 Martin Baulig <martin@gnome.org>
10103 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
10104 add the "value" parameter to the parameter list.
10106 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
10109 2002-06-19 Miguel de Icaza <miguel@ximian.com>
10111 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
10112 the argument to an int, uint, long or ulong, per the spec. Also
10113 catch negative constants in array creation.
10115 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
10117 * class.cs: do not allow the same interface to appear twice in
10118 the definition list.
10120 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
10122 * ecore.cs: don't use ldlen with System.Array.
10124 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
10126 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
10128 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
10130 * modifiers.cs: produce correct field attributes for protected
10131 internal. Easy fix so miguel can work on ther harder stuff:-)
10133 2002-06-18 Miguel de Icaza <miguel@ximian.com>
10135 * pending.cs: New file. Move the code from class.cs here.
10136 Support clearning the pending flag for all methods (when not doing
10137 explicit interface implementation).
10139 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
10141 * rootcontext.cs: added a couple more types needed to bootstrap.
10143 2002-06-17 Miguel de Icaza <miguel@ximian.com>
10145 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
10146 constructor in the type, instead of any constructor in the type
10147 hierarchy. Thanks to Paolo for finding this bug (it showed up as
10148 a bug in the Mono runtime when applying the params attribute).
10150 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10151 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
10153 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
10155 * expression.cs (Unary.ResolveOperator): Use TypeManager
10156 to resolve the type.
10158 2002-06-13 Ravi Pratap <ravi@ximian.com>
10160 * cs-parser.jay (enum_member_declaration): Pass in the attributes
10163 * enum.cs (AddEnumMember): Add support to store the attributes associated
10164 with each member too.
10166 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
10167 field builders too - this takes care of the enum member case.
10169 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
10171 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
10172 address-of operator on both value types and pointers.
10174 2002-06-10 Martin Baulig <martin@gnome.org>
10176 * interface.cs (Interface.PopulateIndexer): Add the indexer's
10177 PropertyBuilder to the `property_builders' list.
10179 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
10180 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
10181 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
10182 find any indexers which are inherited from an interface.
10184 2002-06-09 Martin Baulig <martin@gnome.org>
10186 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
10187 the same type as the constant if necessary. There's also a test-130.cs
10190 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
10192 * typemanager.cs (TypeManager.ChangeType): Previously known as
10193 Enum.ChangeEnumType().
10195 2002-06-09 Martin Baulig <martin@gnome.org>
10197 * expression.cs (Cast.TryReduce): Added support for consts.
10199 2002-06-08 Ravi Pratap <ravi@ximian.com>
10201 * class.cs (Accessor): Hold attributes information so we can pass
10204 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
10205 Modify to pass in attributes attached to the methods.
10207 (add_accessor_declaration, remove_accessor_declaration): Ditto.
10209 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
10210 to handle the Accessor kind :-)
10212 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
10214 2002-06-08 Martin Baulig <martin@gnome.org>
10216 * expression.cs (Unary.TryReduceNegative): Added support for
10219 2002-06-08 Martin Baulig <martin@gnome.org>
10221 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
10222 name can't be found in the `defined_names' - the caller will do a
10223 MemberLookup in this case and thus find methods in System.Enum
10224 such as Enum.IsDefined().
10226 2002-06-08 Martin Baulig <martin@gnome.org>
10228 * enum.cs (Enum.ChangeEnumType): This is a custom version of
10229 Convert.ChangeType() which works with TypeBuilder created types.
10230 (Enum.LookupEnumValue, Enum.Define): Use it here.
10232 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
10233 `TypeBuilder.BaseType != null' check.
10234 (TypeContainer.FindMembers): Only lookup parent members if we
10235 actually have a parent.
10236 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
10237 (ConstructorInitializer.Resolve): Likewise.
10239 * interface.cs (Interface.FindMembers): Added
10240 `TypeBuilder.BaseType != null' check.
10242 * rootcontext.cs (RootContext.ResolveCore): Added
10243 "System.Runtime.CompilerServices.IndexerNameAttribute" to
10244 classes_second_stage.
10246 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
10247 debug_type and trace_type when compiling with --nostdlib.
10249 2002-06-07 Martin Baulig <martin@gnome.org>
10251 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
10252 (AddField): Set it to true when adding a non-static field.
10253 (DefineType): Use `have_nonstatic_fields' to find out whether we
10254 have non-static fields, not `Fields != null'.
10256 2002-06-02 Miguel de Icaza <miguel@ximian.com>
10258 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
10259 dereferencing a null on the static-field code path)
10261 2002-05-30 Martin Baulig <martin@gnome.org>
10263 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
10264 to take command line arguments. Use reflection to call the new
10265 custom `Initialize' function on the symbol writer and pass it the
10266 command line arguments.
10268 * driver.cs (--debug-args): New command line argument to pass command
10269 line arguments to the symbol writer.
10271 2002-05-28 Miguel de Icaza <miguel@ximian.com>
10273 * assign.cs (DoResolve): Forgot to do the implicit conversion to
10274 the target type for indexers and properties. Thanks to Joe for
10277 2002-05-27 Miguel de Icaza <miguel@ximian.com>
10279 * typemanager.cs (MethodFlags): returns the method flags
10280 (Obsolete/ShouldIgnore) that control warning emission and whether
10281 the invocation should be made, or ignored.
10283 * expression.cs (Invocation.Emit): Remove previous hack, we should
10284 not do this on matching a base type, we should do this based on an attribute
10286 Only emit calls to System.Diagnostics.Debug and
10287 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
10288 on the command line.
10290 * rootcontext.cs: Global settings for tracing and debugging.
10292 * cs-tokenizer.cs (define): New utility function to track
10293 defines. Set the global settings for TRACE and DEBUG if found.
10295 2002-05-25 Ravi Pratap <ravi@ximian.com>
10297 * interface.cs (Populate*): Pass in the TypeContainer as well as
10298 the DeclSpace as parameters so that we can create EmitContexts and
10299 then use that to apply attributes etc.
10301 (PopulateMethod, PopulateEvent, PopulateProperty)
10302 (PopulateIndexer): Apply attributes everywhere.
10304 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
10307 (ApplyAttributes): Update accordingly.
10309 We now apply interface attributes for all members too.
10311 2002-05-26 Miguel de Icaza <miguel@ximian.com>
10313 * class.cs (Indexer.Define); Correctly check if we are explicit
10314 implementation (instead of checking the Name for a ".", we
10315 directly look up if the InterfaceType was specified).
10317 Delay the creation of the PropertyBuilder.
10319 Only create the PropertyBuilder if we are not an explicit
10320 interface implementation. This means that explicit interface
10321 implementation members do not participate in regular function
10322 lookups, and hence fixes another major ambiguity problem in
10323 overload resolution (that was the visible effect).
10325 (DefineMethod): Return whether we are doing an interface
10328 * typemanager.cs: Temporary hack until we get attributes in
10329 interfaces (Ravi is working on that) and we get IndexerName
10330 support in interfaces.
10332 * interface.cs: Register the indexers as properties.
10334 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
10335 warning, I have verified that this is a bug in the .NET runtime
10336 (JavaScript suffers of the same problem).
10338 * typemanager.cs (MemberLookup): When looking up members for
10339 interfaces, the parent of an interface is the implicit
10340 System.Object (so we succeed in searches of Object methods in an
10341 interface method invocation. Example: IEnumerable x; x.ToString
10344 2002-05-25 Miguel de Icaza <miguel@ximian.com>
10346 * class.cs (Event): Events should also register if they do
10347 implement the methods that an interface requires.
10349 * typemanager.cs (MemberLookup); use the new GetInterfaces
10352 (GetInterfaces): The code used to lookup interfaces for a type is
10353 used in more than one place, factor it here.
10355 * driver.cs: Track the errors at the bottom of the file, we kept
10358 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
10359 instance if the method we are calling is static!
10361 2002-05-24 Miguel de Icaza <miguel@ximian.com>
10363 * attribute.cs (ApplyAttributes): Make this function filter out
10364 the IndexerName attribute (as that attribute in reality is never
10365 applied) and return the string constant for the IndexerName
10368 * class.cs (TypeContainer.Emit): Validate that all the indexers
10369 have the same IndexerName attribute, and if so, set the
10370 DefaultName attribute on the class.
10372 * typemanager.cs: The return value might contain other stuff (not
10373 only methods). For instance, consider a method with an "Item"
10374 property and an Item method.
10376 * class.cs: If there is a problem with the parameter types,
10379 2002-05-24 Ravi Pratap <ravi@ximian.com>
10381 * ecore.cs (ImplicitConversionExists): Wrapper function which also
10382 looks at user defined conversion after making a call to
10383 StandardConversionExists - we need this for overload resolution.
10385 * expression.cs : Update accordingly the various method calls.
10387 This fixes 2 bugs filed against implicit user defined conversions
10389 2002-05-22 Miguel de Icaza <miguel@ximian.com>
10391 * statement.cs: Track the result of the assignment.
10393 2002-05-21 Miguel de Icaza <miguel@ximian.com>
10395 * expression.cs (MemberAccess): Improved error reporting for
10396 inaccessible members.
10398 2002-05-22 Martin Baulig <martin@gnome.org>
10400 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
10401 itself with debugging support.
10403 2002-05-22 Martin Baulig <martin@gnome.org>
10405 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
10406 Removed, this isn't needed anymore.
10408 2002-05-20 Martin Baulig <martin@gnome.org>
10410 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
10411 be underlying type for an enum.
10413 2002-05-20 Miguel de Icaza <miguel@ximian.com>
10415 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
10416 that splits out the loading of just the core types.
10418 * rootcontext.cs (ResolveCore): Split the struct resolution in
10419 two, so we can load the enumeration underlying types before any
10422 * expression.cs (Is): Bandaid until we fix properly Switch (see
10423 bug #24985 for details).
10425 * typemanager.cs (ImplementsInterface): The hashtable will contain
10426 a null if there are no interfaces implemented.
10428 2002-05-18 Miguel de Icaza <miguel@ximian.com>
10430 * cs-parser.jay (indexer_declarator): It is fine to have array
10433 2002-05-17 Miguel de Icaza <miguel@ximian.com>
10435 * typemanager.cs: (RegisterBuilder): New function used to register
10436 TypeBuilders that implement interfaces. Since
10437 TypeBuilder.GetInterfaces (as usual) does not work with lame
10439 (AddUserType): register interfaces.
10441 (ImplementsInterface): Use the builder_to_ifaces hash if we are
10442 dealing with TypeBuilder. Also, arrays are showing up as
10443 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
10444 methods can not be invoked on them!
10446 * ecore.cs (ExplicitReferenceConversionExists): Made public.
10447 (ImplicitReferenceConversionExists): Split out from
10448 StandardConversionExists.
10450 * expression.cs (As): We were only implementing one of the three
10451 cases for the as operator. We now implement them all.
10452 (Is): Implement the various other cases for Is as well.
10454 * typemanager.cs (CACHE): New define used to control if we want or
10455 not the FindMembers cache. Seems to have a negative impact on
10456 performance currently
10458 (MemberLookup): Nested types have full acess to
10459 enclosing type members
10461 Remove code that coped with instance/static returns for events, we
10462 now catch this in RealFindMembers.
10464 (RealFindMembers): only perform static lookup if the instance
10465 lookup did not return a type or an event.
10467 2002-05-17 Miguel de Icaza <miguel@ximian.com>
10469 * assign.cs (CompoundAssign): We pass more semantic information
10470 now to Compound Assignments than we did before: now we have all
10471 the information at hand, and now we resolve the target *before* we
10472 do the expression expansion, which allows the "CacheValue" method
10473 to have the effect we intended (before, a [x] += 1 would generate
10474 two differen ArrayAccess expressions from the ElementAccess,
10475 during the resolution process).
10477 (CompoundAssign.DoResolve): Resolve target and original_source here.
10479 2002-05-16 Miguel de Icaza <miguel@ximian.com>
10481 * expression.cs (ArrayAccess): dropped debugging information.
10483 * typemanager.cs: Small bug fix: I was always returning i_members,
10484 instead of one of i_members or s_members (depending on which had
10487 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
10488 method is invoked before any code generation takes place, and it
10489 is a mechanism to inform that the expression will be invoked more
10490 than once, and that the method should use temporary values to
10491 avoid having side effects
10493 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
10495 * ecore.cs (Expression.CacheTemporaries): Provide empty default
10498 * expression.cs (Indirection, ArrayAccess): Add support for
10499 CacheTemporaries in these two bad boys.
10501 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
10502 ldobj or ldind_ref.
10503 (StoreFromPtr): Handle stobj as well.
10505 * expression.cs (UnaryMutator): Share more code.
10507 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
10508 down: I was not tracking the Filter function as well, which
10509 was affecting the results of the cache.
10511 2002-05-15 Miguel de Icaza <miguel@ximian.com>
10513 * attribute.cs: Remove the hack to handle the CharSet property on
10516 2002-05-14 Miguel de Icaza <miguel@ximian.com>
10518 * attribute.cs (DoResolve): More uglyness, we now only try to
10519 resolve the attribute partially, to extract the CharSet
10520 information (only if we are a StructLayout attribute). Otherwise
10522 (GetExtraTypeInfo): Add some code to conditionally kill in the
10523 future this. I am more and more convinced that the .NET
10524 framework has special code to handle the attribute setting on
10527 * expression.cs (IsParamsMethodApplicable): Revert my previous
10528 foreach change here, it was wrong.
10530 2002-05-13 Miguel de Icaza <miguel@ximian.com>
10532 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
10533 (pp_expr): do not abort on unknown input, just return.
10534 (eval): abort if there are pending chars.
10536 * attribute.cs (Attribute.Resolve): Positional parameters are
10537 optional. Deal with that case.
10539 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
10540 the Ansi/Unicode/Auto information for the type.
10542 (TypeContainer.DefineType): instantiate the EmitContext here, as
10543 we will be using it during the type definition (to resolve
10544 attributes) and during the emit phase.
10546 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
10547 to pull type information out of the attributes
10549 (Attribute.Resolve): track the constructor builder, and allow for
10550 multiple invocations (structs and classes will use this).
10552 * ecore.cs (MemberLookupFinal): new version with all the
10553 parameters customizable.
10555 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
10556 constructors. Return if the result value is null (as the error
10557 would have been flagged already by MemberLookupFinal)
10559 Do not allow instances of abstract classes or interfaces to be
10562 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
10563 We have to compare the assembly property here when dealing with
10564 FamANDAssem and Assembly access modifiers, because we might be
10565 creating an assembly from *modules* (that means that we are not
10566 getting TypeBuilders for types defined in other modules that are
10567 part of this assembly).
10569 (Method.Emit): If the method is marked abstract and has a body,
10572 (TypeContainer.DefineMembers): If both the defined member and the
10573 parent name match are methods, then do not emit any warnings: let
10574 the Method.Define routine take care of flagging warnings. But if
10575 there is a mismatch (method overrides something else, or method is
10576 overriwritten by something, then emit warning).
10578 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
10579 set to null, this means `do not check for the return type on the
10582 (Method.Define): set the return type for the method signature to
10583 null, so that we get methods with the same name and parameters and
10584 different return types. This is used to flag warning 114 (you are
10585 hiding a method, and you probably want to use the new/override
10588 * typemanager.cs (MemberLookup): Implemented proper access
10589 control, closing a long standing set of bug reports. The problem
10590 was that the Framework only has two bits: Public and NonPublic,
10591 and NonPublic includes private and protected methods, but we need
10592 to enforce the FamANDAssem, FamOrAssem and Family.
10594 2002-05-11 Miguel de Icaza <miguel@ximian.com>
10596 * statement.cs (GotoCase): Return true: Ammounts to giving up
10597 knowledge on whether we return or not, and letting the other case
10598 be responsible for it.
10600 2002-05-10 Miguel de Icaza <miguel@ximian.com>
10602 * driver.cs: Do not load directories for each file processed, only
10603 do it if there is a pattern.
10605 * ecore.cs: Report readonly assigns here as well, as we might have
10606 been resolved only by MemberAccess.
10608 (SimpleName.SimpleNameResolve): Also be useful for LValue
10609 resolution. We need this to propagate assign to local readonly variables
10611 * typemanager.cs: Use a ptrhashtable for the criteria, because we
10612 do not want to reuse potential criteria memory.
10614 * class.cs (MyEventBuilder): Set reflected_type;
10616 * ecore.cs (Constantify): Added support for constifying bools.
10618 (RootContext.LookupType): Added a cache for values looked up in
10619 the declaration space.
10621 * typemanager.cs (FindMembers): Now is a front-end to
10622 RealFindMembers, and provides a two-level hashtable-based cache to
10625 15% performance improvement: from 22.5 to 19.2 seconds.
10627 * expression.cs (IsParamsMethodApplicable): use foreach.
10628 (Invocation.DoResolve): ditto.
10629 (New.DoResolve): ditto.
10630 (ArrayCreation.DoResolve): ditto.
10632 * ecore.cs (FindMostEncompassingType): use foreach.
10634 * delegate.cs (NewDelegate.DoResolve): Use foreach
10636 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
10637 (RemoveMethods): use foreach.
10639 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
10640 nested foreach statements instead of for, and also break out of
10641 the inner loop once a match is found.
10643 (Invocation.OverloadResolve): Use foreach, simplify the code.
10645 2002-05-08 Miguel de Icaza <miguel@ximian.com>
10647 * cfold.cs (BinaryFold): During an enumeration evaluation context,
10648 we actually unwrap the expression to allow for extra information
10651 * expression.cs: Use Shr_Un on unsigned operations.
10653 2002-05-08 Ravi Pratap <ravi@ximian.com>
10655 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
10656 applicable operators was not being considered correctly. This closes
10657 the bug Miguel reported.
10659 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
10661 * attribute.cs: check that the type derives from System.Attribute
10662 and report the correct error in that case (moved the duplicate code to
10663 its own method, too).
10665 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
10667 * attribute.cs: lookup attribute type name as the spec says: first the
10668 bare attribute name and then name + "Attribute" (nant compiles with
10669 mcs after this fix).
10671 2002-05-07 Miguel de Icaza <miguel@ximian.com>
10673 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
10674 Because of the way we parse things, we should try to see if a
10675 UIntConstant can fit in an integer.
10677 2002-05-07 Ravi Pratap <ravi@ximian.com>
10679 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
10680 when we are in an explicit context.
10682 (ConvertReferenceExplicit): When converting from Iface type S to Class
10683 T make sure the rules are implemented as an OR.
10685 * parameter.cs (ParameterType): Make it a property for now although the
10686 purpose really isn't anything immediate.
10688 * expression.cs (Is*Applicable): Do better checking on the parameter type
10689 of a ref/out parameter. The ones from the system assemblies are already
10690 marked with the correct type so we don't need to do any correction.
10692 * ecore.cs (StandardConversionExists): Conversion from Interface types to
10693 the object type is standard too so include that.
10695 2002-05-06 Miguel de Icaza <miguel@ximian.com>
10697 * ecore.cs (StandardConversionExists): Augment with missing code:
10698 deal with IntConstant, LongConstants and Enumerations.
10700 * assign.cs: Report the error, instead of failing silently
10702 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
10703 typecontainer that they are declared, because the
10704 typecontainer/namespace will have the list of using clauses that
10705 need to be applied.
10707 Assembly Attributes were escaping the normal registration
10710 (EmitCode): Apply attributes within an EmitContext that represents
10711 the container they were declared on.
10713 * cs-parser.jay: Track bases for structs. How did I get this wrong?
10715 2002-05-06 Ravi Pratap <ravi@ximian.com>
10717 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
10718 Revamp completely - make much cleaner as we now operate only
10721 (FindMostSpecificSource, FindMostSpecificTarget): New methods
10722 to implement the logic detailed in the spec more correctly.
10724 (UserDefinedConversion): Update accordingly.
10726 2002-05-06 Miguel de Icaza <miguel@ximian.com>
10728 * statement.cs: Return flow analysis information up.
10730 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
10733 (token): Do not consume an extra character before calling
10736 2002-05-06 Piers Haken <piersh@friskit.com>
10738 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
10740 2002-05-06 Miguel de Icaza <miguel@ximian.com>
10742 * class.cs (Constructor.Emit): Set the IsStatic flag in the
10743 EmitContext during the instance constructor initializer
10744 resolution, to stop access to instance variables.
10746 This is mandated by the spec, last paragraph of the `constructor
10747 initializers' section.
10749 2002-05-05 Miguel de Icaza <miguel@ximian.com>
10751 * cs-parser.jay, class.cs (Accessor): new class used to represent
10752 an accessor (get or set). In the past we used `null' to represent
10753 a missing accessor. But this is ambiguous because there was no
10754 way to tell in abstract indexers/properties if one of them was
10757 Now there is a way of addressing that.
10759 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
10760 instead of FindMembers.
10762 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
10763 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
10765 * attribute.cs: Treat indexers and properties as the same in terms
10766 of applying attributes
10768 * ecore.cs (FindMostEncompassedType): Use statically initialized
10769 EmptyExpressions()s like we do elsewhere to avoid creating useless
10770 objects (and we take this out of the tight loop).
10772 (GetConversionOperators): Move the code to extract the actual
10773 operators to a separate routine to clean things up.
10775 2002-05-04 Miguel de Icaza <miguel@ximian.com>
10777 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
10778 events are always registered FieldBuilders.
10780 * class.cs (FieldBase): New class shared by Fields
10782 * delegate.cs: If we are a toplevel delegate, use our full name.
10783 If we are a nested delegate, then only use our tail name.
10785 2002-05-02 Ravi Pratap <ravi@ximian.com>
10787 * expression.cs (IsApplicable): Ensure that we add the "&" to
10788 ref/out types before comparing it with the type of the argument.
10790 (IsParamsMethodApplicable): Ditto.
10792 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
10795 * delegate.cs : Handle the case when we have more than one applicable
10796 method. Flag an error only when we finish checking all.
10798 2002-05-02 Miguel de Icaza <miguel@ximian.com>
10800 * expression.cs: Add support for boolean static initializers.
10802 2002-05-01 Miguel de Icaza <miguel@ximian.com>
10804 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
10806 * parameter.cs (ComputeParameterTypes,
10807 ComputeAndDefineParameterTypes): Better error handling: now we
10808 clear the `types' cache if we fail during any of the type lookups.
10809 We also return the status code correctly to our caller
10811 * delegate.cs: If we fail to define a delegate, abort the extra
10814 * expression.cs (Binary.ResolveOperator): for
10815 operator==(object,object) and operator !=(object, object) we also
10816 have to verify that there is an implicit conversion from one to
10819 (ArrayAccess.DoResolve): Array Access can operate on
10822 2002-04-30 Miguel de Icaza <miguel@ximian.com>
10824 * assign.cs (CompoundAssign): A new class used as a "flag" that
10825 the assignment actually is happening as part of a compound
10826 assignment operator.
10828 During compound assignment, a few new rules exist to enable things
10835 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
10836 to the type of x) if y is implicitly convertible to the type of x,
10837 and the operator is a builtin operator and the return type of the
10838 operator is explicitly convertible to the type of x.
10840 * rootcontext.cs: Reset warning level to 2. 4 catches various
10841 "interesting" features in mcs, we must clean this up at some
10842 point, but currently am trying to kill other bugs ;-)
10844 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
10845 in container classes as well.
10847 * expression.cs (Binary.ResolveOperator): Handle string case
10848 before anything else (as operator overloading does emit an error
10849 before doing anything else).
10851 This code could go away when we move to a table driven model, but
10852 i could not come up with a good plan last night.
10854 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
10856 * typemanager.cs (CSharpName): reimplementation using regex.
10857 * class.cs: added null check for fields in Emit
10858 * rootcontext.cs: set warninglevel to 4
10860 2002-04-29 Miguel de Icaza <miguel@ximian.com>
10862 * typemanager.cs (CSharpName): reimplemented with Lupus
10865 2002-04-28 Miguel de Icaza <miguel@ximian.com>
10867 * statement.cs (If): correclty implement Resolve, because we were
10868 not catching sem errors in there. The same process is needed
10870 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
10873 (Statement.Warning_DeadCodeFound): Factorize code.
10874 (While): Report dead code here too.
10876 (Statement): Added Resolve virtual method to allow
10877 for resolution split from the emit code.
10879 2002-04-26 Miguel de Icaza <miguel@ximian.com>
10881 * statement.cs (EmitBoolExpression): No longer try to resolve the
10883 (MakeBoolean): New utility function that resolve, implicitly
10884 converts to boolean and tags the expression.
10887 (If, Do): Implement dead code elimination.
10888 (While): Implement loop inversion
10890 (Do, While, For, If): Resolve the expression prior to calling our
10893 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
10896 - added method Report28 (warning: program has more than one entry point)
10897 - added method IsEntryPoint, implements paragraph 10.1 of the spec
10898 - modified method Method.Define, the part at the end of the method
10900 * rootcontext.cs: added static public Location EntryPointLocation;
10902 * ../errors/cs0028.cs : Add test case for the above warning.
10905 - modified method CSharpName to allow arrays of primitive type to
10906 be printed nicely (e.g. instead of System.Int32[][] it now prints
10908 - added method CSharpSignature: returns the signature of a method
10909 in string format to be used in reporting errors, warnings, etc.
10911 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
10914 2002-04-26 Ravi Pratap <ravi@ximian.com>
10916 * delegate.cs (Define): Fix extremely silly bug where I was
10917 setting the type of the 'object' parameter of the BeginInvoke
10918 method to System.IAsyncResult instead of System.Object ;-)
10920 2002-04-26 Miguel de Icaza <miguel@ximian.com>
10922 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
10925 (Constructor.Emit): return if we fail to initialize the
10926 constructor. Another door closed!
10928 * expression.cs (New.DoResolve): Improve error message (from -6 to
10929 1501). Use DeclaredOnly lookup to find the exact constructor.
10931 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
10932 loop. This is useful.
10934 * cs-parser.jay: Adjust the default parameters so that destructors
10935 have the proper signature.
10937 2002-04-26 Martin Baulig <martin@gnome.org>
10939 * driver.cs (LoadAssembly): If `assembly' contains any characters
10940 which are only valid in path names and not in assembly names
10941 (currently slash, backslash and point), use Assembly.LoadFrom ()
10942 instead of Assembly.Load () on the `assembly' (before iteration
10943 over the link_paths).
10945 2002-04-26 Martin Baulig <martin@gnome.org>
10947 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
10949 2002-04-25 Miguel de Icaza <miguel@ximian.com>
10951 * class.cs (Property): use the new typemanager.MemberLookup
10953 (TypeContainer.MemberLookup): Implement using the
10954 TypeManager.MemberLookup now.
10956 * typemanager.cs: Make MemberLookup a function of the TypeManager,
10957 and return MemberInfos, so that these can be used without an
10958 EmitContext (what we had before).
10960 2002-04-24 Miguel de Icaza <miguel@ximian.com>
10962 * expression.cs: Fix the case where the argument to params if the
10963 type of the params. I omitted handling this before. Fixed
10965 2002-04-22 Miguel de Icaza <miguel@ximian.com>
10967 * driver.cs: Call BootCorlib_PopulateCoreType
10969 * class.cs (Property.CheckBase): Check for properties only, not
10972 * interface.cs: Temporary hack: try/catch around the
10973 CustomAttributeBuilder, because I am getting an exception that I
10976 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
10977 types whose definitions are required to be there (attributes are
10978 defined before standard types).
10980 Compute definitions as we boot the various types, as they are used
10981 immediately (value_type class will need object_type, but if we do
10982 not initialize object_type, we will pass a null, which will let
10983 the runtime pick the System.Object from the existing corlib, which
10984 is not what we want).
10986 2002-04-22 Patrik Torstensson <totte@labs2.com>
10988 * cs-tokenizer.cs: fixed a number of trim() issues.
10990 2002-04-22 Ravi Pratap <ravi@ximian.com>
10992 * expression.cs (Argument.Type): Ensure that we return the correct
10993 type when we have out or ref parameters [in which case we
10996 2002-04-22 Miguel de Icaza <miguel@ximian.com>
10998 * class.cs (Property, Indexer): Allow extern modifier in there.
11000 * typemanager.cs (InitBaseTypes): Initializes object_type and
11001 value_type, since those will be used early on during the bootstrap
11002 process to compile corlib.
11004 (InitCoreTypes): Move code from here to InitBaseTypes.
11006 2002-04-21 Miguel de Icaza <miguel@ximian.com>
11008 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
11009 single-dimension arrays as using the ldlen opcode.
11011 Daniel Lewis discovered this optimization.
11013 * typemanager.cs: Add signature for System.Array::get_Length
11015 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11017 * statement.cs: report the error when the foreach does not apply to an
11018 array nor a collection.
11020 2002-04-19 Miguel de Icaza <miguel@ximian.com>
11022 * expression.cs: Add implicit conversions to the operator ~.
11024 * constant.cs (DecimalConstant.Emit): Emit decimal value.
11026 * typemanager.cs: Locate the decimal constructor.
11028 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11030 * attribute.cs: use the new property of TypeOf.
11031 * expression.cs: added 'get' property around typearg.
11033 These changes fix a build breaker reported by NickD. Is this the
11034 correct way to fix? If not, please, revert my changes and make it
11037 2002-04-17 Miguel de Icaza <miguel@ximian.com>
11039 * attribute.cs: Add support for typeof in attribute invocations.
11040 I am not sure that this is right though.
11042 2002-04-14 Duncan Mak <duncan@ximian.com>
11044 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
11045 Binary.Operator.Division case.
11047 2002-04-13 Ravi Pratap <ravi@ximian.com>
11049 * class.cs (DefineType): Ensure that we do a proper check on
11050 attribute types and also register it with the TypeManager.
11052 (TypeContainer.Targets): The default for attribute types is
11053 AttributeTargets.All.
11055 * attribute.cs (ApplyAttributes): Registering the attribute type
11056 is done elsewhere, not when we discover we have a Usage attribute.
11058 2002-04-12 Ravi Pratap <ravi@ximian.com>
11060 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
11061 and get rid of is_delegate parameter.
11063 * everywhere : update.
11065 2002-04-12 Ravi Pratap <ravi@ximian.com>
11067 * cs-parser.jay (compilation_unit): Revamp completely to use
11068 some new ideas that I got from Rhys' grammar to solve the problems
11069 with assembly level attributes.
11071 (outer_declaration): New grammar production.
11073 (attribute_sections): Add.
11075 (opt_attributes): Base on attribute_sections
11077 (namespace_declaration): Allow opt_attributes to tackle the case
11078 when we have assembly level attributes - we are clever in this
11081 * attribute.cs (ApplyAttributes): Do not worry about assembly
11082 attributes in the non-global context.
11084 * rootcontext.cs (AddGlobalAttributes): Go back to using this
11085 instead of SetGlobalAttributes.
11087 * class.cs, rootcontext.cs : Ensure we define and generate
11088 attribute types before anything else.
11090 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
11091 and flag the new error -20 for the case when the attribute type
11092 does not have valid targets specified. csc does not catch this.
11094 * ../errors/errors.txt : update for error # -20
11096 2002-04-11 Ravi Pratap <ravi@ximian.com>
11098 * support.cs (InternalParameters.ParameterModifier): Do some null
11099 checking and return sane values.
11101 * class.cs (Method.Define): If we are a PInvoke method, ensure
11102 that we are static and extern. Report error # 601
11104 * ../errors/cs0601.cs : Add test case for the above error.
11106 2002-04-07 Ravi Pratap <ravi@ximian.com>
11108 * rootcontext.cs (attribute_types): We need to keep type of
11109 all attribute types separately and emit code for them first.
11111 (RegisterAttribute) : Implement.
11113 * class.cs (DefineType): Check if the current Type is a custom
11114 attribute type and register it accordingly.
11116 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
11117 adding the first attribute twice and rename to
11119 (SetGlobalAttributes): this.
11121 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
11124 * attribute.cs (ApplyAttributes): Take an additional argument telling us
11125 if we are processing global arguments. Hmm, I am unsure of this.
11127 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11129 * expression.cs: added static array of strings to avoid calling
11130 Enum.ToString () for Operator in Binary. Significant recover of
11133 2002-04-10 Miguel de Icaza <miguel@ximian.com>
11135 * class.cs (FindMembers): Allow the Builders of the various
11136 members to be null. If they are skip them. This only happens
11137 during the PInvoke declaration.
11139 2002-04-09 Miguel de Icaza <miguel@ximian.com>
11141 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
11142 failure, so we do not keep going afterwards.
11144 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
11145 wanted to pass `false' as the `is_delegate' argument. If this is
11146 the case, why not use delegate_type == null to mean `is_delegate =
11147 false' and anything else as is_delegate = true.
11149 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
11151 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
11152 code for the section, not the beginning of the tests.
11154 2002-04-08 Miguel de Icaza <miguel@ximian.com>
11156 * cfold.cs: Handle operator + (Enum x, Underlying x)
11158 * expression.cs (Binary): same. Warn about errors where we have
11159 Enum/Enum in operator + as well.
11161 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
11164 - added support for switch(bool)
11165 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
11166 - add TableSwitchEmit() to handle table-based switch statements
11168 2002-04-05 Ravi Pratap <ravi@ximian.com>
11170 * expression.cs (Invocation.OverloadResolve): Factor out code which
11171 does parameter compatibility checking with arguments so that we can
11172 re-use the code even from Delegate.VerifyApplicability
11174 (VerifyArgumentsCompat): Move above code here.
11176 * delegate.cs (VerifyApplicability): Get rid of duplicate code
11177 and instead make a call to the above method.
11179 2002-03-31 Ravi Pratap <ravi@ximian.com>
11181 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
11182 We use it to keep track of classes which are attribute types.
11184 2002-04-02 Miguel de Icaza <miguel@ximian.com>
11186 * delegate.cs (Delegate.Define): Correctly define the types in the
11187 presence of fixed and array parameters.
11189 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
11192 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
11193 include NonPublic after the first iteration.
11195 * class.cs (Indexer.CheckBase): Only check if both parents are
11198 * cs-parser.jay (accessor_body): If empty, set to null.
11200 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
11201 same code path here to resolve constants names that we did have in
11202 MemberAccess.DoResolve. There is too much code duplicated here.
11204 2002-04-01 Miguel de Icaza <miguel@ximian.com>
11206 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
11208 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
11211 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
11212 tokens, numbers and strings.
11214 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
11217 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
11218 asyncronous parameters and the regular parameters.
11220 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
11221 specify the target directory.
11223 * expression.cs: (This.DoResolve): Simplify
11224 (As.Emit): Optimize, do not generate IsInst if the expression is
11225 always of the given type.
11227 (Is.DoResolve): Bug fix, we were reporting both always/never for
11230 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
11231 creating too many unnecessary arrays.
11233 2002-03-31 Miguel de Icaza <miguel@ximian.com>
11235 * class.cs (EmitFieldInitializer): Use Assign expression to assign
11236 fields instead of rolling our own initializer. Takes care of all
11237 implicit conversions, and drops unnecessary static checks/argument.
11239 2002-03-31 Dick Porter <dick@ximian.com>
11241 * driver.cs: use the GetDirectories() return values properly, and
11242 use "/" as path separator.
11244 2002-03-30 Miguel de Icaza <miguel@ximian.com>
11246 * expression.cs (Unary): Optimize - - expr into expr.
11247 (Binary): Optimize a + (-b) into a -b.
11249 * codegen.cs (CodeGen): Made all methods static.
11251 2002-03-29 Miguel de Icaza <miguel@ximian.com>
11255 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
11256 TypeBuilder property.
11258 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
11261 * tree.cs: Removed the various RecordXXXX, and replaced with a
11262 single RecordDecl. Removed all the accessor methods, and just
11263 left a single access point Type
11265 * enum.cs: Rename DefineEnum to DefineType.
11267 * decl.cs: New abstract method `DefineType' used to unify the
11268 Defines for Enumerations, Interfaces, TypeContainers and
11271 (FindType): Moved LookupInterfaceOrClass here. Moved the
11272 LookupBaseClasses method that used to live in class.cs and
11273 interface.cs here, and renamed to FindType.
11275 * delegate.cs: Implement DefineType. Take advantage of the
11276 refactored pattern for locating the parent builder without taking
11277 the parent_builder argument (which we know does not work if we are
11278 nested, and triggering a toplevel definition).
11280 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11282 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
11283 accessibility of a member has changed during override and report
11286 * class.cs (Method.Define, Property.Define): Only complain on
11287 overrides if the method is private, any other accessibility is
11288 fine (and since we just checked the permission is the same, we are
11291 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
11292 and elif are processed always. The other pre-processing
11293 directives are only processed if we are "taking" the path
11295 2002-03-29 Martin Baulig <martin@gnome.org>
11297 * class.cs (Method.Emit): Only emit symbolic debugging info if the
11298 current location is not Null.
11300 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
11301 a separate method so we can profile it.
11303 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
11304 `span.Seconds' are just seconds, but no minutes or hours.
11305 (MainDriver): Profile the CodeGen.SaveSymbols calls.
11307 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11309 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
11310 Remove the gratuitous set of Final:
11312 // If an interface implementation, then we can set Final.
11313 if (((flags & MethodAttributes.Abstract) == 0) &&
11314 implementing.DeclaringType.IsInterface)
11315 flags |= MethodAttributes.Final;
11317 I do not know what I was smoking when I used that.
11320 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
11321 step into fixing the name resolution issues for delegates and
11322 unifying the toplevel name resolution.
11324 2002-03-28 Martin Baulig <martin@gnome.org>
11326 * class.cs (Method.Emit): If we have a symbol writer, call its
11327 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
11328 tell it about the current method.
11330 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
11331 writer that we're going to emit the first byte of IL code for a new
11332 statement (a new source line).
11333 (EmitContext.EmitTopBlock): If we have a symbol writer, call
11334 EmitContext.Mark() before emitting any code.
11336 * location.cs (SymbolDocument): Return null when we're Null.
11338 * statement.cs (Statement): Moved the `Location loc' variable here.
11339 (Statement.EmitBoolExpression): If we have a symbol writer, call
11340 ec.Mark() before emitting any code to tell it that we're at the
11341 beginning of a new statement.
11342 (StatementExpression): Added `Location' argument to the constructor.
11343 (Block): Added public readonly variable `StartLocation' and public
11344 variable `EndLocation'. The latter is to be set using SetEndLocation().
11345 (Block): Added constructor which takes a start and end location.
11346 (Block.SetEndLocation): New method. This sets the end location.
11347 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
11348 local variables we create.
11349 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
11350 each statement and do also mark the begin and end of the block.
11352 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
11353 tell it the current lexer.Location, use Location.Null for the end of the
11355 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
11356 current block, set its end location using SetEndLocation().
11357 (statement_expression): StatementExpression constructor now takes the
11358 lexer.Location as additional argument.
11359 (for_statement, declare_local_variables): Likewise.
11360 (declare_local_variables): When creating a new implicit block, use the
11361 new Block constructor and pass it the lexer.Location.
11363 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11365 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
11366 members also on the parent interfaces recursively.
11368 2002-03-27 Miguel de Icaza <miguel@ximian.com>
11370 * report.cs: Use new formats, since Gonzalo finished the missing
11373 * expression.cs (Binary.ResolveOperator): added missing operator|
11374 operator& and operator^ for bool/bool.
11376 * cs-parser.jay: CheckDef now takes a Location argument that is
11377 used to report errors more precisly (instead of reporting the end
11378 of a definition, we try to track something which is a lot closer
11379 to the source of the problem).
11381 * cs-tokenizer.cs: Track global token use, so we can properly flag
11382 the use of #define/#undef after the first token has been seen.
11384 Also, rename the reportXXXX to Error_DescriptiveName
11386 * decl.cs (DeclSpace.IsTopLevel): Move property here from
11387 TypeContainer, so that Enum and Interface can use this too.
11389 * class.cs (TypeContainer.LookupInterfaceOrClass,
11390 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
11391 `builder' argument. Typically this was used to pass the parent
11392 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
11395 The problem is that a nested class could trigger the definition of
11396 a toplevel class, and the builder would be obviously wrong in that
11399 So we drop this argument, and we compute dynamically the
11400 TypeBuilder/ModuleBuilder (the correct information was available
11401 to us anyways from DeclSpace.Parent)
11403 * interface.cs (Interface.DefineInterface): Drop builder
11404 parameter cleanup like class.cs
11406 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
11409 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
11412 (Try.Emit): Propagate the returns value from the statement.
11414 (Return.Emit): Even if we are leavning
11416 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
11418 * modifiers.cs: Fix the computation of MethodAttributes flags.
11420 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
11422 * driver.cs: allow compilation of files that start with '/'.
11423 Add a default case when checking the argument of --target.
11425 2002-03-25 Miguel de Icaza <miguel@ximian.com>
11427 * interface.cs: Implement the same search algorithm for types in
11428 the interface code.
11430 * delegate.cs: Do not allow multiple definition.
11432 * Recovered ChangeLog that got accidentally amputated
11434 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
11436 * rootcontext.cs: Load manually enum to allow core classes to
11437 contain enumerations.
11439 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
11440 Update to new static methods in TypeManager.
11442 * typemanager.cs (GetMethod, GetConstructor): Use our
11443 implementation of FindMembers to find the members, since during
11444 corlib compilation, the types are TypeBuilders and GetMethod and
11445 GetConstructor do not work.
11447 Make all methods in TypeManager static.
11449 (InitCodeHelpers): Split the functionality from
11450 the InitCodeTypes function.
11452 * driver.cs: Call InitCodeHelpers after we have populated the
11455 * cs-parser.jay (delegate_declaration): we did not used to compute
11456 the delegate name correctly for void delegates.
11458 2002-03-24 Miguel de Icaza <miguel@ximian.com>
11460 * rootcontext.cs (RootContext): Init the interface_resolve_order
11461 and type_container_resolve_order always.
11463 (ResolveCore, BootstrapCorlib_ResolveClass,
11464 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
11465 compiler when compiling with --nostdlib
11467 * class.cs (TypeContainer.DefineType): Check that our parent is
11468 not null. This test is most important when we are bootstraping
11471 * codegen.cs: Split out the symbol writing code.
11473 2002-03-25 Martin Baulig <martin@gnome.org>
11475 * driver.cs (-g): Made -g an alias for --debug.
11477 2002-03-24 Martin Baulig <martin@gnome.org>
11479 * codegen.cs (SymbolWriter): New public variable. Returns the
11480 current symbol writer.
11481 (CodeGen): Added `bool want_debugging_support' argument to the
11482 constructor. If true, tell the ModuleBuild that we want debugging
11483 support and ask it for the ISymbolWriter.
11484 (Save): If we have a symbol writer, call it's Close() method after
11485 saving the assembly.
11487 * driver.c (--debug): New command line argument to create a
11488 debugger information file.
11490 * location.cs (SymbolDocument): New public property. Returns an
11491 ISymbolDocumentWriter object for the current source file or null
11492 if we don't have a symbol writer.
11494 2002-03-21 Miguel de Icaza <miguel@ximian.com>
11496 * driver.cs (LoadAssembly): Correctly return when all the paths
11497 have been tried and not before.
11499 * statement.cs (Switch.Emit): return the actual coverage for this
11500 statement (returns/not-returns)
11502 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
11503 switch of the statement if we are the last switch section. That
11504 kills two problems: try/catch problems (we used to emit an empty
11505 nop at the end) and switch statements where all branches would
11508 2002-03-19 Miguel de Icaza <miguel@ximian.com>
11510 * driver.cs: Add default assemblies (the equivalent to the
11511 Microsoft CSC.RSP file)
11513 * cs-tokenizer.cs: When updating `cols and setting it to zero,
11514 also update tokens_seen and set it to false.
11516 * driver.cs: Implement --recurse for Mike.
11518 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
11519 correctly splitting out the paths.
11521 2002-03-18 Miguel de Icaza <miguel@ximian.com>
11523 * interface.cs (Interface.PopulateProperty): Instead of using
11524 `parent' as the declaration space for the set parameters, use
11527 * support.cs (InternalParameters): InternalParameters constructor
11528 takes a DeclSpace instead of a TypeContainer.
11530 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
11531 types are being initialized, load the address of it before calling
11534 (New): Provide a mechanism to disable the generation of local
11535 value type temporaries when the caller will be providing us with
11536 an address to store it.
11538 (ArrayCreation.EmitDynamicInitializers): Use it.
11540 2002-03-17 Miguel de Icaza <miguel@ximian.com>
11542 * expression.cs (Invocation.EmitArguments): Only probe for array
11543 property if there is more than one argument. Sorry about that.
11545 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
11546 empty param arrays.
11548 * class.cs (Method.LabelParameters): Fix incorrect code path that
11549 prevented the `ParamArrayAttribute' from being applied to the
11552 2002-03-16 Miguel de Icaza <miguel@ximian.com>
11554 * support.cs (ReflectionParameters): Correctly compute whether the
11555 last argument is a params array. Fixes the problem with
11558 * typemanager.cs: Make the assemblies array always be non-null
11559 (empty, but non-null)
11561 * tree.cs (RecordDecl): New function that abstracts the recording
11562 of names. This reports error 101, and provides a pointer to the
11563 previous declaration. Fixes a crash in the compiler.
11565 * cs-parser.jay (constructor_declaration): Update to new grammar,
11566 and provide a constructor_body that can be empty.
11568 2002-03-15 Miguel de Icaza <miguel@ximian.com>
11570 * driver.cs: Add support for --resources.
11572 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
11573 Make all types for the various array helper methods be integer.
11575 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
11576 CheckState to ConvCast.
11578 (ConvCast): Now it takes a `checked' state argument, to avoid
11579 depending on the emit context for the conversion, and just using
11580 the resolve time setting.
11582 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
11583 instead of Invocation.EmitArguments. We do not emit the original
11584 arguments, instead we emit those which have been converted to
11585 unsigned int expressions.
11587 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
11589 * codegen.cs: ditto.
11591 * expression.cs (LocalVariableReference): Drop the use of the
11592 Store function that depended on the variable index.
11594 * statement.cs (VariableInfo): Drop the `Idx' property from this
11595 class, as this is not taking into account the indexes for
11596 temporaries tat we generate during the execution, getting the
11599 * class.cs: First emit class initializers, then call the parent
11602 * expression.cs (Binary): Fix opcode emision.
11603 (UnaryMutator.EmitCode): Support checked code generation
11605 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
11606 matches for events for both the Static and Instance scans,
11607 pointing to the same element. Fix that.
11609 2002-03-14 Miguel de Icaza <miguel@ximian.com>
11611 * rootcontext.cs (ResolveTree): Always set the
11612 interface_resolve_order, because nested interfaces will be calling
11615 * class.cs (GetInterfaceOrClass): Track the same resolution
11616 process used by TypeManager.LookupType. This fixes the nested
11617 type lookups in class declarations (separate path from
11620 (TypeContainer.DefineType): Also define nested interfaces.
11621 (TypeContainer.RegisterOrder): New public function used to
11622 register the order in which child interfaces need to be closed.
11624 Nested interfaces need to be closed after their parents have been
11627 * interface.cs (InterfaceAttr): Put all the logic for computing
11628 the interface attribute here.
11630 (DefineInterface): Register our interface order with the
11631 RootContext or with the TypeContainer depending on the case.
11633 2002-03-12 Miguel de Icaza <miguel@ximian.com>
11635 * cs-parser.jay: rework foreach statement to work with the new
11636 changes to the policy on SimpleNames.
11638 * report.cs: support Stacktrace on warnings as well.
11640 * makefile: drop --unsafe and /unsafe from the compile.
11642 2002-03-13 Ravi Pratap <ravi@ximian.com>
11644 * ecore.cs (StandardConversionExists): Modify to take an Expression
11645 as the first parameter. Ensure we do null -> reference type conversion
11648 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
11649 temporary Expression objects.
11651 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
11653 * interface.cs: workaround bug in method overloading resolution
11654 (there is already a bugzilla bug for it).
11656 2002-03-12 Miguel de Icaza <miguel@ximian.com>
11658 We could also solve this problem by having a separate path for
11659 performing type lookups, instead of DoResolve, we could have a
11660 ResolveType entry point, and only participating pieces of the
11661 production (simplename, deref, array) would implement this.
11663 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
11664 signal SimpleName to only resolve type names and not attempt to
11665 resolve anything else.
11667 * expression.cs (Cast): Set the flag.
11669 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
11671 * class.cs: Only report 108 if there is no `new' modifier.
11673 * cs-parser.jay: rework foreach statement to work with the new
11674 changes to the policy on SimpleNames.
11676 * report.cs: support Stacktrace on warnings as well.
11678 * makefile: drop --unsafe and /unsafe from the compile.
11680 2002-03-11 Miguel de Icaza <miguel@ximian.com>
11682 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
11683 lookups here, instead of doing that at parse time. This means
11684 that our grammar will not introduce `LocalVariableReferences' as
11685 expressions at this point. That solves the problem of code like
11689 static void Main ()
11693 This is only half the fix. The full fix requires parameters to
11694 also be handled in this way.
11696 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
11697 makes the use more obvious of the DeclSpace. The
11698 ec.TypeContainer.TypeBuilder is now only used to pull the
11699 TypeBuilder for it.
11701 My theory is that I can get rid of the TypeBuilder completely from
11702 the EmitContext, and have typecasts where it is used (from
11703 DeclSpace to where it matters).
11705 The only pending problem is that the code that implements Aliases
11706 is on TypeContainer, and probably should go in DeclSpace.
11708 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
11709 lookups here, instead of doing that at parse time. This means
11710 that our grammar will not introduce `LocalVariableReferences' as
11711 expressions at this point. That solves the problem of code like
11715 static void Main ()
11719 This is only half the fix. The full fix requires parameters to
11720 also be handled in this way.
11722 * class.cs (Property.DefineMethod): When implementing an interface
11723 method, set newslot, when implementing an abstract method, do not
11724 set the flag (before we tried never setting it, or always setting
11725 it, which is the difference).
11726 (Indexer.DefineMethod): same.
11727 (Method.DefineMethod): same.
11729 * ecore.cs: Only set the status used flag if we get back a Field.
11731 * attribute.cs: Temporary hack, so Paolo can keep working.
11733 2002-03-08 Ravi Pratap <ravi@ximian.com>
11735 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
11736 the unmanaged type in the case we have a MarshalAs attribute.
11738 (Resolve): Handle the case when we are parsing the special MarshalAs
11739 attribute [we need to store the unmanaged type to use later]
11741 * typemanager.cs (marshal_as_attr_type): Built in type for the
11742 MarshalAs Attribute.
11744 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
11745 on parameters and accordingly set the marshalling info.
11747 2002-03-09 Miguel de Icaza <miguel@ximian.com>
11749 * class.cs: Optimizing slightly by removing redundant code after
11750 we switched to the `NoTypes' return value.
11751 (Property.DefineMethod): use NoTypes here too.
11753 This fixes the bug I introduced in my last batch of changes.
11755 2002-03-05 Ravi Pratap <ravi@ximian.com>
11757 * tree.cs (RecordEnum): Add. We now keep track of enums too.
11759 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
11760 Enums since those are types too.
11762 * cs-parser.jay (enum_declaration): Record enums as we parse them.
11764 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
11765 thanks to a call during the lookup process.
11767 2002-03-07 Miguel de Icaza <miguel@ximian.com>
11769 * statement.cs (Foreach): Lots of work to accomodate a particular
11770 kind of foreach statement that I had not kept in mind. It is
11771 possible to have foreachs on classes that provide a GetEnumerator
11772 method that return objects that implement the "pattern" for using
11773 a foreach, there is no need to support GetEnumerator
11776 This is needed to compile nant.
11778 * decl.cs: Only report 114 if the member is not `Finalize' and if
11779 the warning level is at least 2.
11781 * class.cs: Moved the compare function from Method to
11784 (MethodSignature.InheritableMemberSignatureCompare): Add new
11785 filter function that is used to extract inheritable methods from a
11788 (Method.Define): Use the new `inheritable_method_signature_filter'
11791 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
11794 2002-03-06 Miguel de Icaza <miguel@ximian.com>
11796 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
11798 * cs-parser.jay: Add opt_semicolon to the interface declaration.
11800 * expression.cs: Pass location information to
11801 ConvertImplicitStandard.
11803 * class.cs: Added debugging code to track return values from
11806 2002-03-05 Miguel de Icaza <miguel@ximian.com>
11808 * expression.cs (Is.DoResolve): If either side of the `is' is an
11809 interface, do not flag the warning.
11811 * ecore.cs (ImplicitReferenceConversion): We need a separate test
11814 * report.cs: Allow for --fatal to be used with --probe.
11816 * typemanager.cs (NoTypes): Move the definition for the empty Type
11819 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
11821 (TypeContainer.DefineProxy): New function used to proxy to parent
11822 implementations when implementing interfaces.
11823 (TypeContainer.ParentImplements): used to lookup if our parent
11824 implements a public function that is required by an interface.
11825 (TypeContainer.VerifyPendingMethods): Hook this up.
11827 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
11828 `modules' and `assemblies' arraylists into arrays. We only grow
11829 these are the very early start up of the program, so this improves
11830 the speedof LookupType (nicely measured).
11832 * expression.cs (MakeByteBlob): Replaced unsafe code with
11833 BitConverter, as suggested by Paolo.
11835 * cfold.cs (ConstantFold.Binary): Special case: perform constant
11836 folding of string concatenation, but if either side is a string,
11837 and the other is not, then return null, and let the runtime use
11838 the concatenation on the string plus the object (using
11839 `Object.ToString').
11841 2002-03-04 Miguel de Icaza <miguel@ximian.com>
11843 Constant Folding has been implemented now.
11845 * expression.cs (Unary.Reduce): Do not throw an exception, catch
11846 the error instead on types that are not supported in one's
11849 * constant.cs (Constant and all children): New set of functions to
11850 perform implict and explicit conversions.
11852 * ecore.cs (EnumConstant): Implement the new functions to perform
11853 conversion by proxying to the child expression.
11855 * codegen.cs: (ConstantCheckState): Constant evaluation has its
11856 own separate setting that can not be turned off from the command
11857 line using --unchecked or --checked and is only controlled using
11858 the checked/unchecked statements and expressions. This setting is
11859 used by the constant folder to flag errors.
11861 * expression.cs (CheckedExpr, UncheckedExpr): Set the
11862 ConstantCheckState as well.
11864 During Resolve, they also have to flag the state, because the
11865 constant folder runs completely in the Resolve phase.
11867 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
11870 2002-03-01 Miguel de Icaza <miguel@ximian.com>
11872 * cfold.cs: New file, this file contains the constant folder.
11874 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
11875 argument to track whether we are using the resulting address to
11876 load or store a value and provide better error messages.
11878 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
11879 new AddressOf arguments.
11881 * statement.cs (Foreach.EmitCollectionForeach): Update
11883 * expression.cs (Argument.Emit): Call AddressOf with proper
11884 arguments to track usage.
11886 (New.DoEmit): Call AddressOf with new arguments.
11888 (Unary.Emit): Adjust AddressOf call.
11890 2002-03-01 Ravi Pratap <ravi@ximian.com>
11892 * cs-parser.jay (member_access): Change the case for pre-defined types
11893 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
11896 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
11899 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
11900 essentially like methods and apply attributes like MethodImplOptions to them too.
11902 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
11905 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
11906 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
11909 * Update code everywhere accordingly.
11911 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
11913 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
11915 2002-02-28 Ravi Pratap <ravi@ximian.com>
11917 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
11918 try performing lookups against those instead of jumping straight into using
11919 the 'using' clauses.
11921 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
11923 (LookupType): Perform lookups in implicit parents too.
11925 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
11926 sequence as RootContext.LookupType.
11928 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
11929 the various cases of namespace lookups into this method.
11931 2002-03-01 Miguel de Icaza <miguel@ximian.com>
11933 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
11934 in positional arguments)
11936 * class.cs (Operator): Update the AllowedModifiers to contain
11939 * cs-parser.jay: Update operator declaration to allow for the
11940 operator body to be empty.
11942 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
11945 2002-02-27 Miguel de Icaza <miguel@ximian.com>
11947 * class.cs (Method.Emit): Label parameters.
11949 * driver.cs: Return 1 or 0 as the program exit code.
11951 2002-02-26 Miguel de Icaza <miguel@ximian.com>
11953 * expression.cs: Special case the `null' object when trying to
11954 auto-compute the type, as anything can be explicitly converted to
11957 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
11958 spotting this Paolo.
11960 (Expression.ImplicitNumericConversion): Perform comparissions of
11961 the type using the underlying type in the case of an enumeration
11962 rather than using the enumeration type for the compare.
11964 Cope with the underlying == type case, which is not possible to
11967 (Expression.ConvertNumericExplicit): Perform comparissions of
11968 the type using the underlying type in the case of an enumeration
11969 rather than using the enumeration type for the compare.
11971 * driver.cs: If the user does not supply an extension, assume .exe
11973 * cs-parser.jay (if_statement): Rewrote so that we can track the
11974 location for the if statement.
11976 * expression.cs (Binary.ConstantFold): Only concat strings when
11977 the operation is "+", not everything ;-)
11979 * statement.cs (Statement.EmitBoolExpression): Take a location
11981 (If, While, Do): Track location.
11983 * expression.cs (Binary.ResolveOperator): In the object + string
11984 case, I was missing a call to ConvertImplicit
11986 2002-02-25 Ravi Pratap <ravi@ximian.com>
11988 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
11989 Location arguments. Ensure we use RootContext.LookupType to do our work
11990 and not try to do a direct Type.GetType and ModuleBuilder.GetType
11992 * interface.cs (PopulateMethod): Handle the type of the parameter being
11995 * expression.cs (Invocation.BetterFunction): Handle the case when we
11996 have a params method with no fixed arguments and a call is made with no
11999 2002-02-25 Miguel de Icaza <miguel@ximian.com>
12001 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
12002 the verbatim-string-literal
12004 * support.cs (InternalParameters.ParameterModifier): handle null
12006 (InternalParameters.ParameterType): ditto.
12008 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
12009 duplicating the name of the variable parameter.
12010 (GetParameterByName): Fix bug where we were not looking up array
12011 paramters if they were the only present (thanks Paolo!).
12012 (GetParameterInfo): We only have an empty set of types if both
12013 fixed and array are set to null.
12014 (GetParameterInfo-idx): Handle FixedParameter == null
12016 * cs-parser.jay: Handle the case where there is no catch
12017 statements (missing null test).
12019 2002-02-22 Miguel de Icaza <miguel@ximian.com>
12021 * driver.cs (MainDriver): Be conservative on our command line
12024 Catch DirectoryNotFoundException when calling GetFiles.
12026 (SplitPathAndPattern): Used to split the input specification into
12027 a path and a pattern that we can feed to Directory.GetFiles.
12029 2002-02-21 Miguel de Icaza <miguel@ximian.com>
12031 * statement.cs (Fixed): Implement the last case of the Fixed
12032 statement (string handling).
12034 * expression.cs (StringPtr): New class used to return a char * to
12035 a string; Used by the Fixed statement.
12037 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
12039 * expression.cs (Binary.ResolveOperator): Remove redundant
12040 MemberLookup pn parent type.
12041 Optimize union call, we do not need a union if the types are the same.
12042 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
12045 Specialize the use of MemberLookup everywhere, instead of using
12046 the default settings.
12048 (StackAlloc): Implement stackalloc keyword.
12050 * cs-parser.jay: Add rule to parse stackalloc.
12052 * driver.cs: Handle /h, /help, /?
12054 * expression.cs (MakeByteBlob): Removed the hacks we had in place
12055 before we supported unsafe code.
12057 * makefile: add --unsafe to the self compilation of mcs.
12059 2002-02-20 Miguel de Icaza <miguel@ximian.com>
12061 * expression.cs (PointerArithmetic): New class that is used to
12062 perform pointer arithmetic.
12063 (Binary.Resolve): Handle pointer arithmetic
12064 Handle pointer comparission.
12065 (ArrayPtr): Utility expression class that is used to take the
12066 address of an array.
12068 (ElementAccess): Implement array access for pointers
12070 * statement.cs (Fixed): Implement fixed statement for arrays, we
12071 are missing one more case before we are done.
12073 * expression.cs (Indirection): Implement EmitAssign and set the
12074 ExprClass to Variable. This allows pointer dereferences to be
12075 treated as variables, and to have values assigned to them.
12077 * ecore.cs (Expression.StoreFromPtr): New utility function to
12078 store values dereferencing.
12080 2002-02-20 Ravi Pratap <ravi@ximian.com>
12082 * expression.cs (Binary.ResolveOperator): Ensure that we are
12083 not trying to operate on a void type - this fixes the reported
12086 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
12087 the parent implementation is sealed.
12089 * ../errors/cs0239.cs : Add.
12091 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
12093 * typemanager.cs (unverifiable_code_type): Corresponds to
12094 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
12095 which have unsafe code in them.
12097 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
12100 2002-02-19 Miguel de Icaza <miguel@ximian.com>
12102 * cs-tokenizer.cs: Add support for @"litreal strings"
12104 Make tokenizer accept pre-processor directives
12105 on any column (remove the old C-like limitation).
12107 * rootcontext.cs (EmitCode): Emit any global attributes.
12108 (AddGlobalAttributes): Used to keep track of assembly attributes.
12110 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
12112 * cs-parser.jay: Add support for global attributes.
12114 2002-02-17 Miguel de Icaza <miguel@ximian.com>
12116 * expression.cs (Indirection): New helper class. Unary will
12117 create Indirection classes to be able to implement the
12118 IMemoryLocation interface on it.
12120 2002-02-16 Miguel de Icaza <miguel@ximian.com>
12122 * cs-parser.jay (fixed_statement): reference the right statement.
12124 * statement.cs (Fixed.Emit): Finish implementing the fixed
12125 statement for the &x case.
12127 2002-02-14 Miguel de Icaza <miguel@ximian.com>
12129 * class.cs (Property.Define, Method.Define): Remove newslot when
12132 * modifiers.cs: My use of NewSlot when `Abstract' was set was
12133 wrong. NewSlot should only be used if the `new' keyword is present.
12135 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
12136 locating our system dir. Sorry about this.
12138 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12140 * driver.cs (GetSystemDir): Compute correctly the location of our
12141 system assemblies. I was using the compiler directory instead of
12142 the library directory.
12144 2002-02-13 Ravi Pratap <ravi@ximian.com>
12146 * expression.cs (BetterFunction): Put back in what Miguel commented out
12147 since it is the correct fix. The problem is elsewhere ;-)
12149 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
12150 parameters of the parms method are themselves compatible or not !
12152 (StandardConversionExists): Fix very dangerous bug where we were forgetting
12153 to check that a class implements an interface before saying that an implicit
12154 conversion was allowed. Use ImplementsInterface to do the checking.
12156 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12158 * class.cs (Method.Define): Track whether we are an explicit
12159 implementation or not. And only call DefineMethodOverride if we
12160 are an explicit implementation.
12162 (Property.DefineMethod): Ditto.
12164 2002-02-11 Ravi Pratap <ravi@ximian.com>
12166 * expression.cs (BetterFunction): Catch hideous bug which was
12167 preventing us from detecting ambiguous calls due to implicit casts i.e
12170 2002-01-29 Miguel de Icaza <miguel@ximian.com>
12172 * support.cs (Pair): Remove un-needed method. I figured why I was
12173 getting the error in cs-parser.jay, the variable in a foreach loop
12174 is readonly, and the compiler does not really treat this as a variable.
12176 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
12177 instead of EQUALS in grammar.
12179 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
12181 * expression.cs (Unary.DoResolve): Check whether the argument is
12184 2002-01-28 Miguel de Icaza <miguel@ximian.com>
12186 * support.cs: Api for Pair to set a value. Despite the fact that
12187 the variables are public the MS C# compiler refuses to compile
12188 code that accesses the field if the variable is part of a foreach
12191 * statement.cs (Fixed): Begin implementation of the fixed
12194 (Block.AddVariable): Return the VariableInfo on success and null
12195 on failure instead of true/false.
12197 * cs-parser.jay (foreach): Catch errors on variables already
12198 defined (we were ignoring this value before) and properly unwind
12199 the block hierarchy
12201 (fixed_statement): grammar for the fixed statement.
12203 2002-01-25 Miguel de Icaza <miguel@ximian.com>
12205 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
12206 pointer types to be incretemented.
12208 (SizeOf): Implement.
12210 * cs-parser.jay (pointer_member_access): Implement
12211 expr->IDENTIFIER production.
12213 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
12214 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
12217 (Unary): Implement indirection.
12219 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
12220 use in non-unsafe context).
12222 (SimpleName.DoResolve): Check for pointers in field access on safe
12225 (Expression.LoadFromPtr): Factor the load-indirect code in this
12226 function. This was duplicated in UnboxCast and ParameterReference
12228 2002-01-24 Miguel de Icaza <miguel@ximian.com>
12230 * expression.cs (ComposedCast): report an error if a pointer cast
12231 is used in a safe region.
12233 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
12234 pointer type casts in unsafe context.
12236 * codegen.cs (EmitContext): Set up IsUnsafe.
12238 * cs-parser.jay (non_expression_type): Add productions for pointer
12241 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
12242 code. We should not use force into static mode if the method is
12243 not virtual. Fixes bug in MIS
12245 * statement.cs (Do.Emit, While.Emit, For.Emit,
12246 Statement.EmitBoolExpression): Add support to Do and While to
12247 propagate infinite loop as `I do return' semantics.
12249 Improve the For case to also test for boolean constants.
12251 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
12252 to the list of attributes we can add.
12254 Remove `EmitContext' argument.
12256 * class.cs (Method.Define): Apply parameter attributes.
12257 (Constructor.Define): Apply parameter attributes.
12258 (MethodCore.LabelParameters): Move here the core of labeling
12261 * support.cs (ReflectionParameters.ParameterModifier,
12262 InternalParameters.ParameterModifier): Use IsByRef on the type and
12263 only return the OUT bit for these parameters instead of in/out/ref
12266 This is because I miss-understood things. The ParameterInfo.IsIn
12267 and IsOut represent whether the parameter has the [In] and [Out]
12270 2002-01-22 Miguel de Icaza <miguel@ximian.com>
12272 * ecore.cs (FieldExpr.Emit): Release temporaries.
12274 * assign.cs (LocalTemporary.Release): new function.
12276 * codegen.cs (EmitContext.GetTemporaryStorage,
12277 EmitContext.FreeTemporaryStorage): Rework the way we deal with
12278 temporary storage. Now we can "put back" localbuilders when we
12281 2002-01-21 Miguel de Icaza <miguel@ximian.com>
12283 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
12284 need to make a copy of the variable to generate verifiable code.
12286 2002-01-19 Miguel de Icaza <miguel@ximian.com>
12288 * driver.cs: Compute dynamically the system directory.
12290 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
12291 Slower, but more generally useful. Used by the abstract
12292 registering implementation.
12294 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
12295 the rules for the special rule on Type/instances. First check if
12296 we have the same name, and if so, try that special static path
12297 rather than the instance path.
12299 2002-01-18 Miguel de Icaza <miguel@ximian.com>
12301 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
12304 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
12305 Enum, ValueType, Delegate or Array for non-corlib compiles.
12307 * cs-tokenizer.cs: Catch long identifiers (645)
12309 * typemanager.cs (IndexerPropetyName): Ravi never tested this
12312 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
12313 fix, we were returning too early, so we were not registering
12314 pending methods from abstract classes.
12316 Do not register pending methods if the class is abstract.
12318 * expression.cs (Conditional.DoResolve): Report circular implicit
12319 conversions when we neecd to compute it for conditional
12322 (Is.DoResolve): If the expression is always of the provided type,
12323 flag warning 183. If the expression can not ever be of the
12324 provided type flag warning 184.
12326 * class.cs: Catch 169 as well.
12328 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
12331 2002-01-18 Nick Drochak <ndrochak@gol.com>
12333 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
12335 2002-01-17 Miguel de Icaza <miguel@ximian.com>
12337 * interface.cs: (PopulateMethod): Check for pointers being defined
12338 only if the unsafe context is active.
12339 (PopulateProperty): ditto.
12340 (PopulateIndexer): ditto.
12342 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
12343 specified. If pointers are present, make sure that they are
12344 present in an unsafe context.
12345 (Constructor, Constructor.Define): ditto.
12346 (Field, Field.Define): ditto.
12347 (Property, Property.Define): ditto.
12348 (Event, Event.Define): ditto.
12350 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
12351 hashtable if there are classes or structs defined.
12353 * expression.cs (LocalVariableReference.DoResolve): Simplify this
12354 code, as the constant resolution moved.
12356 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
12357 the metadata, so we can flag error 133.
12359 * decl.cs (MemberCore.UnsafeOK): New function to test that a
12360 pointer is being declared in an unsafe context.
12362 2002-01-16 Miguel de Icaza <miguel@ximian.com>
12364 * modifiers.cs (Modifiers.Check): Require a Location argument.
12365 Report error 227 for Unsafe use.
12367 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
12369 * statement.cs (For.Emit): If the test is null, then report that
12370 we do `return', as we wont reach anything afterwards.
12372 (Switch.SwitchGoverningType): Track the expression that matched
12375 * driver.cs: Allow negative numbers as an error code to flag.
12377 * cs-parser.jay: Handle 1551.
12379 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
12381 2002-01-15 Miguel de Icaza <miguel@ximian.com>
12383 * cs-parser.jay: Report 1518 (type declaration can only contain
12384 class, struct, interface, enum or delegate)
12386 (switch_label): Report 1523 (keywords `case' or `default' must
12389 (opt_switch_sections): Report 1522 (empty switch)
12391 * driver.cs: Report 1515 (response file specified multiple times)
12392 Report 1516 (Source file specified multiple times).
12394 * expression.cs (Argument.Resolve): Signal 1510
12396 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
12397 access not allowed in static code)
12399 2002-01-11 Ravi Pratap <ravi@ximian.com>
12401 * typemanager.cs (IsPointerType): Utility method which we are going
12404 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
12405 the object type, so we take care of that.
12407 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
12409 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
12410 added to non-params parameters :-)
12412 * typemanager.cs (CSharpName): Include 'void' type too.
12414 (void_ptr_type): Include in the set of core types.
12416 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
12419 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
12422 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
12423 completely forgotten about it.
12425 2002-01-10 Ravi Pratap <ravi@ximian.com>
12427 * cs-parser.jay (pointer_type): Add. This begins our implementation
12428 of parsing rules for unsafe code.
12430 (unsafe_statement): Implement.
12432 (embedded_statement): Modify to include the above.
12434 * statement.cs (Unsafe): Implement new class for unsafe blocks.
12436 * codegen.cs (EmitContext.InUnsafe): Add. This determines
12437 if the current context is an unsafe one.
12439 * cs-parser.jay (local_variable_pointer_type): Since local variable types
12440 are handled differently, we need separate rules for them.
12442 (local_variable_declaration): Update to use local_variable_pointer_type
12443 to allow variable declarations of unmanaged pointer types.
12445 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
12446 in unsafe contexts.
12448 * ../errors/cs0214.cs : Add.
12450 2002-01-16 Nick Drochak <ndrochak@gol.com>
12452 * makefile: remove 'response' file when cleaning.
12454 2002-01-15 Miguel de Icaza <miguel@ximian.com>
12456 * cs-parser.jay: Report 1524.
12458 2002-01-14 Miguel de Icaza <miguel@ximian.com>
12460 * typemanager.cs (RegisterMethod): drop checking if we have
12461 registered this from here
12463 2002-01-12 Miguel de Icaza <miguel@ximian.com>
12465 * class.cs (Method.EmitDestructor): Implement calling our base
12468 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
12469 value of InFinally.
12471 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
12472 this routine and will wrap the call in a try/catch block. Deal
12475 2002-01-11 Miguel de Icaza <miguel@ximian.com>
12477 * ecore.cs (Expression.MemberLookup): instead of taking a
12478 parameter `same_type' that was used to tell whether we could
12479 access private members we compute our containing type from the
12482 (FieldExpr): Added partial support for volatile fields. This does
12483 not work for volatile fields exposed from assemblies, as I can not
12484 figure out how to extract the modreq from it.
12486 Updated all the source files to use this.
12488 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
12489 because it is referenced by MemberLookup very often.
12491 2002-01-09 Ravi Pratap <ravi@ximian.com>
12493 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
12494 TypeBuilder.GetCustomAttributes to retrieve what we need.
12496 Get rid of redundant default_member_attr_type as this is the same as
12497 default_member_type which already exists.
12499 * interface.cs, attribute.cs : Update accordingly.
12501 2002-01-08 Miguel de Icaza <miguel@ximian.com>
12503 * typemanager.cs: Enable IndexerPropertyName again. It does not
12504 work for TYpeBuilders though. Ravi, can you please fix this?
12506 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
12508 * expression.cs (Argument.Emit): Handle the case of ref objects
12509 being passed to ref functions;
12511 (ParameterReference.EmitLoad): Loads the content of the pointer
12512 without dereferencing.
12514 2002-01-07 Miguel de Icaza <miguel@ximian.com>
12516 * cs-tokenizer.cs: Implemented the pre-processing expressions.
12518 2002-01-08 Ravi Pratap <ravi@ximian.com>
12520 * class.cs (Indexer.DefineMethod): Incorporate the interface
12521 type in the name of the method if we are doing explicit interface
12524 * expression.cs (ConversionExists): Remove as it is completely obsolete.
12526 (BetterConversion): Fix extremely trivial bug where we were referring to
12527 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
12530 * ../errors/bug16.cs : Add although we have fixed it.
12532 2002-01-07 Miguel de Icaza <miguel@ximian.com>
12534 * expression.cs (BaseIndexer): Begin implementation.
12536 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
12538 * cs-parser.jay (indexer_declarator): Use qualified_identifier
12539 production directly to remove a shift/reduce, and implement
12540 explicit interface implementation.
12542 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
12543 after a floating point suffix.
12545 * expression.cs (DoNumericPromotions): Improved the conversion for
12546 uint/uint. If we have a constant, we avoid doing a typecast to a
12549 * class.cs (Indexer): Implement explicit interface implementation
12552 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
12554 * class.cs: make the default instance constructor public and hidebysig.
12556 2001-01-03 Ravi Pratap <ravi@ximian.com>
12558 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
12559 so we can call it from elsewhere.
12561 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
12562 we emit it internally if the class has a defined indexer; otherwise the user
12563 emits it by decorating the class definition with the DefaultMemberAttribute.
12565 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
12566 attribute is not used on a type which defines an indexer.
12568 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
12569 character when we skip whitespace.
12571 * ../errors/cs0646.cs : Add.
12573 2002-01-03 Miguel de Icaza <miguel@ximian.com>
12575 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
12578 * makefile: Add practical target `mcs3.exe' which builds the third
12579 generation compiler.
12581 * expression.cs (New): Fix structures constructor calling.
12583 * class.cs (Property, Method, Indexer): Emit Final flag on the
12584 method if we are an interface implementation and we are not
12587 * ecore.cs (PropertyExpr): New public field `IsBase', tells
12588 whether this property is referencing a `base' method.
12590 * expression.cs (Invocation.EmitCall): take an extra argument:
12591 is_base, this is used to determine whether the `call' or
12592 `callvirt' opcode should be used.
12595 * delegate.cs: update EmitCall.
12597 * class.cs (Method.Define): Set NewSlot for the cases where we are
12598 not implementing an interface method.
12600 (Property.Define): ditto.
12602 2002-01-02 Miguel de Icaza <miguel@ximian.com>
12604 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
12605 'r'. Allows mcs to parse itself fully.
12607 2002-01-02 Ravi Pratap <ravi@ximian.com>
12609 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
12610 of the number of initializers that require the InitializeArray method.
12612 (CheckIndices): Store the Expression in all cases - not the plain value. Also
12613 update the above field where necessary.
12615 (MakeByteBlob): Update accordingly.
12617 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
12620 (EmitDynamicInitializers): Update in accordance with the new optimization.
12622 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
12623 same OpCode applies.
12625 * cs-parser.jay : Fix some glaring errors I introduced.
12627 2002-01-01 Ravi Pratap <ravi@ximian.com>
12629 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
12630 so that we can check for name clashes there too.
12632 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
12633 for interface indexers.
12635 * interfaces.cs (Define): Emit the default member attribute.
12637 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
12638 variable was being referred to while setting the value ;-)
12640 2002-01-01 Miguel de Icaza <miguel@ximian.com>
12642 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
12643 byte-by-byte information when we know the data is zero.
12645 Make the block always a multiple of 4, because
12646 DefineInitializedData has a bug.
12648 * assign.cs: Fix, we should assign from the temporary, not from
12651 * expression.cs (MakeByteBlob): Fix my incorrect code.
12653 2001-12-31 Miguel de Icaza <miguel@ximian.com>
12655 * typemanager.cs (EnumToUnderlying): This function is used to get
12656 the underlying type from an enumeration, because it does not
12659 * constant.cs: Use the I4_S form for values between -128 and 127.
12661 * statement.cs (Block.LookupLabel): Looks up a label.
12662 (Block): Drop support for labeled blocks.
12664 (LabeledStatement): New kind of statement that represents a label
12667 (Goto): Finally implement this bad boy.
12669 * cs-parser.jay: Update to reflect new mechanism to implement
12672 2001-12-30 Miguel de Icaza <miguel@ximian.com>
12674 * codegen.cs (EmitContext.This): a codegen property that keeps the
12675 a single instance of this instead of creating many different this
12678 * delegate.cs (Delegate.DoResolve): Update to use the property;
12680 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
12682 * expression.cs (BaseAccess.DoResolve): Ditto.
12684 2001-12-29 Ravi Pratap <ravi@ximian.com>
12686 * typemanager.cs (methodimpl_attr_type): Add to hold the type
12687 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
12689 (InitCoreTypes): Update accordingly.
12691 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
12692 so we can quickly store the state.
12694 (ApplyAttributes): Set the correct implementation flags
12695 for InternalCall methods.
12697 2001-12-29 Miguel de Icaza <miguel@ximian.com>
12699 * expression.cs (EmitCall): if a method is not virtual, then do
12700 not use callvirt on it.
12702 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
12703 user defined stuff) requires the use of stobj, which takes an
12704 address on the stack instead of an array and an index. So emit
12705 the Ldelema operation for it.
12707 (EmitStoreOpcode): Use stobj for valuetypes.
12709 (UnaryMutator.EmitCode): Use the right 1 value depending on
12710 whether we are dealing with int64/uint64, float or doubles.
12712 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
12713 constructors that I implemented last night.
12715 (Constructor.IsDefault): Fix to work properly for static
12718 * cs-parser.jay (CheckDef): report method signature errors.
12719 Update error number 103 to be 132.
12721 * decl.cs: New AdditionResult enumeration value: MethodExists.
12722 Although we do this check for methods later on in the semantic
12723 analysis, catching repeated default constructors is so easy that
12724 we catch these here.
12726 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
12729 (ParameterReference.EmitAssign, Emit): handle
12732 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
12733 (ArrayAccess.EmitStoreOpcode): ditto.
12735 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
12737 * expression.cs (MakeByteBlob): Complete all the missing types
12738 (uint, short, ushort, byte, sbyte)
12740 * class.cs: Only init instance field initializers on instance
12743 Rename `constructors' to instance_constructors.
12745 (TypeContainer.AddConstructor): Only add constructors to the list
12746 if it is not static.
12748 Make sure that we handle default_static_constructor independently
12749 everywhere where we handle instance_constructors
12751 2001-12-28 Miguel de Icaza <miguel@ximian.com>
12753 * class.cs: Do not lookup or create a base initializer for a
12754 static constructor.
12756 (ConstructorInitializer.Resolve): use the proper type to lookup
12759 * cs-parser.jay: Report error 1585 (modifiers between type and name).
12761 * enum.cs, interface.cs: Remove CloseType, this is taken care by
12764 * decl.cs: CloseType is now an virtual method, the default
12765 implementation just closes this type.
12767 2001-12-28 Ravi Pratap <ravi@ximian.com>
12769 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
12770 to PreserveSig by default. Also emit HideBySig on such methods.
12772 Basically, set the defaults to standard values.
12774 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
12775 argument, if candidate is better, it can't be worse than the best !
12777 (Invocation): Re-write bits to differentiate between methods being
12778 applicable in their expanded form and their normal form - for params
12781 Get rid of use_standard everywhere as only standard conversions are allowed
12782 in overload resolution.
12784 More spec conformance.
12786 2001-12-27 Miguel de Icaza <miguel@ximian.com>
12788 * driver.cs: Add --timestamp, to see where the compiler spends
12791 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
12792 `this' in static code.
12794 (SimpleName.DoResolve): Implement in terms of a helper function
12795 that allows static-references to be passed upstream to
12798 (Expression.ResolveWithSimpleName): Resolve specially simple
12799 names when called by MemberAccess to implement the special
12802 (Expression.ImplicitReferenceConversion): Handle conversions from
12803 Null to reference types before others, as Null's type is
12806 * expression.cs (Invocation.EmitCall): Handle the special case of
12807 calling methods declared on a reference type from a ValueType
12808 (Base classes System.Object and System.Enum)
12810 (MemberAccess.Resolve): Only perform lookups on Enumerations if
12811 the left hand side is a TypeExpr, not on every enumeration.
12813 (Binary.Resolve): If types are reference types, then do a cast to
12814 object on operators != and == of both arguments.
12816 * typemanager.cs (FindMembers): Extract instance and static
12817 members if requested.
12819 * interface.cs (PopulateProperty): Use void_type instead of null
12820 as the return type for the setter method.
12822 (PopulateIndexer): ditto.
12824 2001-12-27 Ravi Pratap <ravi@ximian.com>
12826 * support.cs (ReflectionParameters): Fix minor bug where we
12827 were examining the wrong parameter for the ParamArray attribute.
12829 Cope with requests for the type of the parameter at position
12830 greater than the params parameter's. We now return the element
12831 type of the params array as that makes more sense.
12833 * expression.cs (Invocation.IsParamsMethodApplicable): Update
12834 accordingly as we no longer have to extract the element type
12837 (Invocation.OverloadResolve): Update.
12839 2001-12-27 Miguel de Icaza <miguel@ximian.com>
12841 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
12842 against IEnumerator, test whether the return value is a descendant
12843 of the IEnumerator interface.
12845 * class.cs (Indexer.Define): Use an auxiliary method to implement
12846 the other bits of the method definition. Begin support for
12847 explicit interface implementation.
12849 (Property.DefineMethod): Use TypeManager.void_type instead of null
12850 for an empty return value.
12852 2001-12-26 Miguel de Icaza <miguel@ximian.com>
12854 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
12855 dealing with a FieldExpr which is composed of a FieldBuilder, in
12856 the code path we did extract the constant, but we should have
12857 obtained the underlying value to be able to cast it (otherwise we
12858 end up in an infinite loop, this is what Ravi was running into).
12860 (ArrayCreation.UpdateIndices): Arrays might be empty.
12862 (MemberAccess.ResolveMemberAccess): Add support for section
12863 14.5.4.1 that deals with the special case of E.I when E is a type
12864 and something else, that I can be a reference to a static member.
12866 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
12867 handle a particular array type to create byte blobs, it is just
12868 something we dont generate byteblobs for.
12870 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
12873 * location.cs (Push): remove the key from the hashtable that we
12874 are about to add. This happens for empty files.
12876 * driver.cs: Dispose files after we have parsed them.
12878 (tokenize): new function that only runs the tokenizer on its
12879 input, for speed testing.
12881 2001-12-26 Ravi Pratap <ravi@ximian.com>
12883 * class.cs (Event.Define): Define the private field only if there
12884 are no accessors defined.
12886 * expression.cs (ResolveMemberAccess): If there is no associated
12887 field with the event, that means we have an event defined with its
12888 own accessors and we should flag error cs0070 since transforming
12889 ourselves into a field is not valid in that case.
12891 * ecore.cs (SimpleName.DoResolve): Same as above.
12893 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
12894 and charset to sane values.
12896 2001-12-25 Ravi Pratap <ravi@ximian.com>
12898 * assign.cs (DoResolve): Perform check on events only if they
12899 are being accessed outside the declaring type.
12901 * cs-parser.jay (event_declarations): Update rules to correctly
12902 set the type of the implicit parameter etc.
12904 (add_accessor, remove_accessor): Set current local parameters.
12906 * expression.cs (Binary): For delegate addition and subtraction,
12907 cast the return value from the method into the appropriate delegate
12910 2001-12-24 Ravi Pratap <ravi@ximian.com>
12912 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
12913 of these as the workaround is unnecessary.
12915 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
12916 delegate data - none of that is needed at all.
12918 Re-write bits to extract the instance expression and the delegate method
12921 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
12924 * attribute.cs (ApplyAttributes): New method to take care of common tasks
12925 of attaching attributes instead of duplicating code everywhere.
12927 * everywhere : Update code to do attribute emission using the above method.
12929 2001-12-23 Miguel de Icaza <miguel@ximian.com>
12931 * expression.cs (IsParamsMethodApplicable): if there are not
12932 parameters, return immediately.
12934 * ecore.cs: The 0 literal can be implicity converted to an enum
12937 (SimpleName.DoResolve): First lookup the type, then lookup the
12940 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
12941 want to get its address. If the InstanceExpression is not
12942 addressable, store the result in a temporary variable, then get
12945 * codegen.cs: Only display 219 errors on warning level or above.
12947 * expression.cs (ArrayAccess): Make it implement the
12948 IMemoryLocation interface.
12950 (Binary.DoResolve): handle the operator == (object a, object b)
12951 and operator != (object a, object b) without incurring into a
12952 BoxedCast (because 5 != o should never be performed).
12954 Handle binary enumerator operators.
12956 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
12957 value type, otherwise use Ldelem_ref.
12959 Use precomputed names;
12961 (AddressOf): Implement address of
12963 * cs-parser.jay (labeled_statement): Fix recursive block
12964 addition by reworking the production.
12966 * expression.cs (New.DoEmit): New has a special case:
12968 If we are dealing with a ValueType, we have a few
12969 situations to deal with:
12971 * The target of New is a ValueType variable, that is
12972 easy, we just pass this as the variable reference
12974 * The target of New is being passed as an argument,
12975 to a boxing operation or a function that takes a
12978 In this case, we need to create a temporary variable
12979 that is the argument of New.
12982 2001-12-23 Ravi Pratap <ravi@ximian.com>
12984 * rootcontext.cs (LookupType): Check that current_type is not null before
12985 going about looking at nested types.
12987 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
12988 not implement the IAssignMethod interface any more.
12990 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
12991 where we tranform them into FieldExprs if they are being resolved from within
12992 the declaring type.
12994 * ecore.cs (SimpleName.DoResolve): Do the same here.
12996 * assign.cs (DoResolve, Emit): Clean up code considerably.
12998 * ../errors/bug10.cs : Add.
13000 * ../errors/cs0070.cs : Add.
13002 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
13004 * assign.cs : Get rid of EventIsLocal everywhere.
13006 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13008 * ecore.cs (ConvertIntLiteral): finished the implementation.
13010 * statement.cs (SwitchLabel): Convert the value we are using as a
13011 key before looking up the table.
13013 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13015 * codegen.cs (EmitTopBlock): Require a Location argument now.
13017 * cs-parser.jay (constructor_declarator): We need to setup
13018 current_local_parameters before we parse the
13019 opt_constructor_initializer, to allow the variables to be bound
13020 to the constructor arguments.
13022 * rootcontext.cs (LookupType): First lookup nested classes in our
13023 class and our parents before we go looking outside our class.
13025 * expression.cs (ConstantFold): Extract/debox the values at the
13028 * rootcontext.cs (EmitCode): Resolve the constants first before we
13029 resolve the types. This is not really needed, but it helps debugging.
13031 * statement.cs: report location.
13033 * cs-parser.jay: pass location to throw statement.
13035 * driver.cs: Small bug fix.
13037 * report.cs: Updated format to be 4-zero filled digits.
13039 2001-12-22 Ravi Pratap <ravi@ximian.com>
13041 * expression.cs (CheckIndices): Fix minor bug where the wrong
13042 variable was being referred to ;-)
13044 (DoEmit): Do not call EmitStaticInitializers when the
13045 underlying type is System.Object.
13047 2001-12-21 Ravi Pratap <ravi@ximian.com>
13049 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
13050 and do the usual workaround for SRE.
13052 * class.cs (MyEventBuilder.EventType): New member to get at the type
13053 of the event, quickly.
13055 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
13057 * assign.cs (Assign.DoResolve): Handle the case when the target
13058 is an EventExpr and perform the necessary checks.
13060 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
13063 (SimpleName.MemberStaticCheck): Include check for EventExpr.
13065 (EventExpr): Set the type in the constructor itself since we
13066 are meant to be born fully resolved.
13068 (EventExpr.Define): Revert code I wrote earlier.
13070 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
13071 instance expression is null. The instance expression is a This in that case
13072 or a null, depending on whether it is a static method or not.
13074 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
13075 refers to more than one method.
13077 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
13078 and accordingly flag errors.
13080 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13082 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
13084 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13086 * location.cs (ToString): Provide useful rutine.
13088 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13090 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
13091 objects, return the actual integral boxed.
13093 * statement.cs (SwitchLabel): define an ILLabel for each
13096 (Switch.CheckSwitch): If the value is a Literal, extract
13097 the underlying literal.
13099 Also in the unused hashtable we had, add the SwitchLabel so we can
13100 quickly look this value up.
13102 * constant.cs: Implement a bunch of new constants. Rewrite
13103 Literal based on this. Made changes everywhere to adapt to this.
13105 * expression.cs (Expression.MakeByteBlob): Optimize routine by
13106 dereferencing array only once, and also copes with enumrations.
13108 bytes are two bytes wide, not one.
13110 (Cast): Perform constant conversions.
13112 * ecore.cs (TryImplicitIntConversion): Return literals instead of
13113 wrappers to the literals here.
13115 * expression.cs (DoNumericPromotions): long literals can converted
13116 to ulong implicity (this is taken care of elsewhere, but I was
13117 missing this spot).
13119 * ecore.cs (Expression.Literalize): Make the return type Literal,
13120 to improve type checking.
13122 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
13124 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13126 * literal.cs: Revert code from ravi that checked the bounds. The
13127 bounds are sane by the definition of the type itself.
13129 * typemanager.cs: Fix implementation of ImplementsInterface. We
13130 need to actually look up in our parent hierarchy for interfaces
13133 * const.cs: Use the underlying type for enumerations
13135 * delegate.cs: Compute the basename for the delegate creation,
13136 that should fix the delegate test case, and restore the correct
13137 Type Lookup semantics in rootcontext
13139 * rootcontext.cs: Revert Ravi's last patch. The correct way of
13140 referencing a nested type with the Reflection API is using the "+"
13143 * cs-parser.jay: Do not require EOF token at the end.
13145 2001-12-20 Ravi Pratap <ravi@ximian.com>
13147 * rootcontext.cs (LookupType): Concatenate type names with
13148 a '.' instead of a '+' The test suite passes again.
13150 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
13151 field of the enumeration.
13153 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
13154 the case when the member is an EventExpr.
13156 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
13157 static has an associated instance expression.
13159 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
13161 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
13163 * class.cs (Event.Define): Register event and perform appropriate checks
13166 We define the Add and Remove methods even if the use provides none because
13167 in that case, we provide default implementations ourselves.
13169 Define a private field of the type of the event. This is done by the CSC compiler
13170 and we should be doing it too ;-)
13172 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
13173 More methods we use in code we generate.
13175 (multicast_delegate_type, delegate_type): Two separate types since the distinction
13178 (InitCoreTypes): Update accordingly for the above.
13180 * class.cs (Event.Emit): Generate code for default accessors that we provide
13182 (EmitDefaultMethod): Do the job in the above.
13184 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
13187 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13189 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
13190 builders even if we were missing one.
13192 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
13193 pass the Basename as our class name instead of the Name. The
13194 basename will be correctly composed for us.
13196 * parameter.cs (Paramters): Now takes a Location argument.
13198 * decl.cs (DeclSpace.LookupType): Removed convenience function and
13199 make all the code call directly LookupType in RootContext and take
13200 this chance to pass the Location information everywhere.
13202 * Everywhere: pass Location information.
13204 2001-12-19 Miguel de Icaza <miguel@ximian.com>
13206 * class.cs (Constructor.Define): Updated way of detecting the
13207 length of the parameters.
13209 (TypeContainer.DefineType): Use basename as the type name for
13212 (TypeContainer.Define): Do not recursively define types here, as
13213 definition is taken care in order by the RootContext.
13215 * tree.cs: Keep track of namespaces in a per-file basis.
13217 * parameter.cs (Parameter.ComputeSignature): Update to use
13220 (Parameters.GetSignature): ditto.
13222 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
13223 instead of a TypeContainer.
13225 (Interface.SemanticAnalysis): Use `this' instead of our parent to
13226 resolve names. Because we need to be resolve in our context, not
13229 * driver.cs: Implement response files.
13231 * class.cs (TypeContainer.DefineType): If we are defined, do not
13232 redefine ourselves.
13234 (Event.Emit): Emit the code for add/remove handlers.
13235 (Event.Define): Save the MethodBuilders for add/remove.
13237 * typemanager.cs: Use pair here too.
13239 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
13240 DictionaryEntry requires the first argument to be non-null.
13242 (enum_declaration): Compute full name for registering the
13245 (delegate_declaration): Instead of using
13246 formal_parameter_list, use opt_formal_parameter_list as the list
13249 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
13250 (EventParsing): New property that controls whether `add' and
13251 `remove' are returned as tokens or identifiers (for events);
13253 2001-12-19 Ravi Pratap <ravi@ximian.com>
13255 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
13256 use MyEventBuilder only and let it wrap the real builder for us.
13258 (MyEventBuilder): Revamp constructor etc.
13260 Implement all operations that we perform on EventBuilder in precisely the same
13263 (FindMembers): Update to use the EventBuilder member.
13265 (Event.Emit): Update accordingly.
13267 2001-12-18 Ravi Pratap <ravi@ximian.com>
13269 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
13270 by calling the appropriate methods.
13272 (GetCustomAttributes): Make stubs as they cannot possibly do anything
13275 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
13277 2001-12-17 Ravi Pratap <ravi@ximian.com>
13279 * delegate.cs (Delegate.Populate): Check that the return type
13280 and various parameters types are indeed accessible.
13282 * class.cs (Constructor.Define): Same here.
13284 (Field.Define): Ditto.
13286 (Event.Define): Ditto.
13288 (Operator.Define): Check that the underlying Method defined itself
13289 correctly - so it's MethodBuilder should not be null.
13291 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
13292 expression happens to be null.
13294 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
13295 members but as of now we don't seem to be able to do anything really useful with it.
13297 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
13298 not the EventBuilder.
13300 2001-12-18 Miguel de Icaza <miguel@ximian.com>
13302 * cs-tokenizer.cs: Add support for defines.
13303 Add support for #if, #elif, #else, #endif
13305 (eval_var): evaluates a variable.
13306 (eval): stubbed for evaluating functions.
13308 * cs-parser.jay: Pass the defines information
13310 * driver.cs: Add --define command line option.
13312 * decl.cs: Move MemberCore here.
13314 Make it the base class for DeclSpace. This allows us to catch and
13315 report 108 and 109 for everything now.
13317 * class.cs (TypeContainer.Define): Extract all the members
13318 before populating and emit the warning 108 (new keyword required
13319 to override) instead of having each member implement this.
13321 (MemberCore.Define): New abstract method, we will be using this in
13322 the warning reporting engine in Populate.
13324 (Operator.Define): Adjust to new MemberCore protocol.
13326 * const.cs (Const): This does not derive from Expression, it is a
13327 temporary object we use to create fields, it is a MemberCore.
13329 * class.cs (Method.Define): Allow the entry point to be in a
13332 * driver.cs: Rewrite the argument handler to clean it up a bit.
13334 * rootcontext.cs: Made it just an auxiliary namespace feature by
13335 making everything static.
13337 * driver.cs: Adapt code to use RootContext type name instead of
13340 * delegate.cs: Remove RootContext argument.
13342 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
13345 * class.cs (Event.Define): The lookup can fail.
13347 * cs-tokenizer.cs: Begin implementation of pre-procesor.
13349 * expression.cs: Resolve the this instance before invoking the code.
13351 2001-12-17 Miguel de Icaza <miguel@ximian.com>
13353 * cs-parser.jay: Add a production in element_access that allows
13354 the thing to become a "type" reference. This way we can parse
13355 things like "(string [])" as a type.
13357 Note that this still does not handle the more complex rules of
13361 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
13363 * ecore.cs: (CopyNewMethods): new utility function used to
13364 assemble the list of methods from running FindMembers.
13366 (MemberLookup): Rework FindMembers so that
13368 2001-12-16 Miguel de Icaza <miguel@ximian.com>
13370 * class.cs (TypeContainer): Remove Delegates who fail to be
13373 * delegate.cs (Populate): Verify that we dont get null return
13374 values. TODO: Check for AsAccessible.
13376 * cs-parser.jay: Use basename to emit error 574 (destructor should
13377 have the same name as container class), not the full name.
13379 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
13380 possible representation.
13382 Also implements integer type suffixes U and L.
13384 2001-12-15 Miguel de Icaza <miguel@ximian.com>
13386 * expression.cs (ArrayCreation.DoResolve): We need to do the
13387 argument resolution *always*.
13389 * decl.cs: Make this hold the namespace. Hold the root context as
13391 (LookupType): Move here.
13393 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
13395 * location.cs (Row, Name): Fixed the code, it was always returning
13396 references to the first file.
13398 * interface.cs: Register properties defined through interfaces.
13400 * driver.cs: Add support for globbing on the command line
13402 * class.cs (Field): Make it derive from MemberCore as well.
13405 2001-12-15 Ravi Pratap <ravi@ximian.com>
13407 * class.cs (Event::Define): Check that the type of the event is a delegate
13408 type else flag error #66.
13410 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
13413 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
13414 values of EntryPoint, CharSet etc etc.
13416 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
13418 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
13419 be null and we should ignore this. I am not sure if this is really clean. Apparently,
13420 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
13421 which needs this to do its work.
13423 * ../errors/cs0066.cs : Add.
13425 2001-12-14 Miguel de Icaza <miguel@ximian.com>
13427 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
13430 * class.cs: (MethodSignature.MethodSignature): Removed hack that
13431 clears out the parameters field.
13432 (MemberSignatureCompare): Cleanup
13434 (MemberCore): New base class used to share code between MethodCore
13437 (RegisterRequiredImplementations) BindingFlags.Public requires
13438 either BindingFlags.Instace or Static. Use instance here.
13440 (Property): Refactored code to cope better with the full spec.
13442 * parameter.cs (GetParameterInfo): Return an empty array instead
13445 * class.cs (Property): Abstract or extern properties have no bodies.
13447 * parameter.cs (GetParameterInfo): return a zero-sized array.
13449 * class.cs (TypeContainer.MethodModifiersValid): Move all the
13450 method modifier validation to the typecontainer so we can reuse
13451 this on properties.
13453 (MethodCore.ParameterTypes): return an empty sized array of types.
13455 (Property.Define): Test property modifier validity.
13457 Add tests for sealed/override too.
13459 (Method.Emit): abstract or extern methods have no bodies.
13461 2001-12-14 Ravi Pratap <ravi@ximian.com>
13463 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
13466 (Method::Define, ::Emit): Modify accordingly.
13468 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
13470 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
13472 * makefile: Pass in /unsafe.
13474 2001-12-13 Miguel de Icaza <miguel@ximian.com>
13476 * class.cs (MakeKey): Kill routine.
13478 * class.cs (TypeContainer.Define): Correctly define explicit
13479 method implementations (they require the full interface name plus
13482 * typemanager.cs: Deply the PtrHashtable here and stop using the
13483 lame keys. Things work so much better.
13485 This of course broke everyone who depended on `RegisterMethod' to
13486 do the `test for existance' test. This has to be done elsewhere.
13488 * support.cs (PtrHashtable): A hashtable that avoid comparing with
13489 the object stupid Equals method (because, that like fails all over
13490 the place). We still do not use it.
13492 * class.cs (TypeContainer.SetRequiredInterface,
13493 TypeContainer.RequireMethods): Killed these two routines and moved
13494 all the functionality to RegisterRequiredImplementations.
13496 (TypeContainer.RegisterRequiredImplementations): This routine now
13497 registers all the implementations required in an array for the
13498 interfaces and abstract methods. We use an array of structures
13499 which can be computed ahead of time to reduce memory usage and we
13500 also assume that lookups are cheap as most classes will not
13501 implement too many interfaces.
13503 We also avoid creating too many MethodSignatures.
13505 (TypeContainer.IsInterfaceMethod): Update and optionally does not
13506 clear the "pending" bit if we find that there are problems with
13509 (TypeContainer.VerifyPendingMethods): Update to report errors of
13510 methods that look like implementations but are not.
13512 (TypeContainer.Define): Add support for explicit interface method
13515 2001-12-12 Miguel de Icaza <miguel@ximian.com>
13517 * typemanager.cs: Keep track of the parameters here instead of
13518 being a feature of the TypeContainer.
13520 * class.cs: Drop the registration of parameters here, as
13521 InterfaceMethods are also interface declarations.
13523 * delegate.cs: Register methods with the TypeManager not only with
13524 the TypeContainer. This code was buggy.
13526 * interface.cs: Full registation here.
13528 2001-12-11 Miguel de Icaza <miguel@ximian.com>
13530 * expression.cs: Remove reducer for binary expressions, it can not
13533 * const.cs: Put here the code that used to go into constant.cs
13535 * constant.cs: Put here the code for constants, this is a new base
13536 class for Literals.
13538 * literal.cs: Make Literal derive from Constant.
13540 2001-12-09 Miguel de Icaza <miguel@ximian.com>
13542 * statement.cs (Return.Emit): Report error 157 if the user
13543 attempts to return from a finally block.
13545 (Return.Emit): Instead of emitting a return, jump to the end of
13548 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
13549 LocalBuilder to store the result of the function. ReturnLabel is
13550 the target where we jump.
13553 2001-12-09 Radek Doulik <rodo@ximian.com>
13555 * cs-parser.jay: remember alias in current namespace
13557 * ecore.cs (SimpleName::DoResolve): use aliases for types or
13560 * class.cs (LookupAlias): lookup alias in my_namespace
13562 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
13564 (LookupAlias): lookup alias in this and if needed in parent
13567 2001-12-08 Miguel de Icaza <miguel@ximian.com>
13571 * rootcontext.cs: (ModuleBuilder) Made static, first step into
13572 making things static. I need this to avoid passing the
13573 TypeContainer when calling ParameterType.
13575 * support.cs (InternalParameters.ParameterType): Remove ugly hack
13576 that did string manipulation to compute the type and then call
13577 GetType. Use Parameter.ParameterType instead.
13579 * cs-tokenizer.cs: Consume the suffix for floating values.
13581 * expression.cs (ParameterReference): figure out whether this is a
13582 reference parameter or not. Kill an extra variable by computing
13583 the arg_idx during emission.
13585 * parameter.cs (Parameters.GetParameterInfo): New overloaded
13586 function that returns whether a parameter is an out/ref value or not.
13588 (Parameter.ParameterType): The type of the parameter (base,
13589 without ref/out applied).
13591 (Parameter.Resolve): Perform resolution here.
13592 (Parameter.ExternalType): The full type (with ref/out applied).
13594 * statement.cs (Using.Emit, Using.EmitExpression): Implement
13595 support for expressions on the using statement.
13597 2001-12-07 Miguel de Icaza <miguel@ximian.com>
13599 * statement.cs (Using.EmitLocalVariableDecls): Split the
13600 localvariable handling of the using statement.
13602 (Block.EmitMeta): Keep track of variable count across blocks. We
13603 were reusing slots on separate branches of blocks.
13605 (Try.Emit): Emit the general code block, we were not emitting it.
13607 Check the type of the declaration to be an IDisposable or
13608 something that can be implicity converted to it.
13610 Emit conversions if required.
13612 * ecore.cs (EmptyExpression): New utility class.
13613 (Expression.ImplicitConversionExists): New utility function.
13615 2001-12-06 Miguel de Icaza <miguel@ximian.com>
13617 * statement.cs (Using): Implement.
13619 * expression.cs (LocalVariableReference): Support read only variables.
13621 * statement.cs: Remove the explicit emit for the Leave opcode.
13622 (VariableInfo): Add a readonly field.
13624 2001-12-05 Miguel de Icaza <miguel@ximian.com>
13626 * ecore.cs (ConvCast): new class used to encapsulate the various
13627 explicit integer conversions that works in both checked and
13628 unchecked contexts.
13630 (Expression.ConvertNumericExplicit): Use new ConvCast class to
13631 properly generate the overflow opcodes.
13633 2001-12-04 Miguel de Icaza <miguel@ximian.com>
13635 * statement.cs: The correct type for the EmptyExpression is the
13636 element_type, not the variable type. Ravi pointed this out.
13638 2001-12-04 Ravi Pratap <ravi@ximian.com>
13640 * class.cs (Method::Define): Handle PInvoke methods specially
13641 by using DefinePInvokeMethod instead of the usual one.
13643 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
13644 above to do the task of extracting information and defining the method.
13646 2001-12-04 Ravi Pratap <ravi@ximian.com>
13648 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
13649 of the condition for string type.
13651 (Emit): Move that here.
13653 (ArrayCreation::CheckIndices): Keep string literals in their expression
13656 (EmitDynamicInitializers): Handle strings appropriately.
13658 2001-12-04 Miguel de Icaza <miguel@ximian.com>
13660 * codegen.cs (EmitContext): Replace multiple variables with a
13661 single pointer to the current Switch statement.
13663 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
13666 2001-12-03 Miguel de Icaza <miguel@ximian.com>
13670 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
13673 (Foreach.Emit): Foreach on arrays was not setting
13674 up the loop variables (for break/continue).
13676 (GotoCase): Semi-implented.
13678 2001-12-03 Ravi Pratap <ravi@ximian.com>
13680 * attribute.cs (CheckAttribute): Handle system attributes by using
13681 Attribute.GetAttributes to examine information we need.
13683 (GetValidPlaces): Same here.
13685 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
13687 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
13689 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
13691 (Method::Define): Set appropriate flags if we have a DllImport attribute.
13693 (Method::Emit): Handle the case when we are a PInvoke method.
13695 2001-12-03 Miguel de Icaza <miguel@ximian.com>
13697 * expression.cs: Use ResolveWithSimpleName on compound names.
13699 2001-12-02 Ravi Pratap <ravi@ximian.com>
13701 * constant.cs (EmitConstant): Make sure we resolve the associated expression
13702 before trying to reduce it.
13704 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
13706 * constant.cs (LookupConstantValue): Implement.
13708 (EmitConstant): Use the above in emitting the constant.
13710 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
13711 that are user-defined by doing a LookupConstantValue on them.
13713 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
13716 2001-11-29 Miguel de Icaza <miguel@ximian.com>
13718 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
13720 (BaseAccess.DoResolve): Implement.
13722 (MemberAccess.DoResolve): Split this routine into a
13723 ResolveMemberAccess routine that can be used independently
13725 2001-11-28 Miguel de Icaza <miguel@ximian.com>
13727 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
13728 As that share bits of the implementation. Is returns a boolean,
13729 while As returns the Type that is being probed.
13731 2001-12-01 Ravi Pratap <ravi@ximian.com>
13733 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
13734 instead of a Literal - much easier.
13736 (EnumInTransit): Remove - utterly useless :-)
13738 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
13740 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
13742 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
13743 chain when we have no associated expression.
13745 2001-11-30 Ravi Pratap <ravi@ximian.com>
13747 * constant.cs (Define): Use Location while reporting the errror.
13749 Also emit a warning when 'new' is used and there is no inherited
13752 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
13755 (LookupEnumValue): Implement to lookup an enum member's value and define it
13758 (Populate): Re-write accordingly to use the above routine.
13760 2001-11-27 Miguel de Icaza <miguel@ximian.com>
13762 * expression.cs (This): Fix prototype for DoResolveLValue to
13763 override the base class DoResolveLValue.
13765 * cs-parser.cs: Report errors cs574 and cs575 (destructor
13768 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
13769 (we need to load the address of the field here). This fixes
13772 (FieldExpr.DoResolveLValue): Call the DoResolve
13773 function to initialize the Instance expression.
13775 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
13776 correctly the GetEnumerator operation on a value type.
13778 * cs-parser.jay: Add more simple parsing error catches.
13780 * statement.cs (Switch): Add support for string switches.
13781 Handle null specially.
13783 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
13785 2001-11-28 Ravi Pratap <ravi@ximian.com>
13787 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
13789 (declare_local_constant): New helper function.
13791 * statement.cs (AddConstant): Keep a separate record of constants
13793 (IsConstant): Implement to determine if a variable is a constant.
13795 (GetConstantExpression): Implement.
13797 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
13799 * statement.cs (IsVariableDefined): Re-write.
13801 2001-11-27 Ravi Pratap <ravi@ximian.com>
13803 * class.cs (TypeContainer::FindMembers): Look for constants
13804 in the case when we are looking for MemberTypes.Field
13806 * expression.cs (MemberAccess::DoResolve): Check that in the
13807 case we are a FieldExpr and a Literal, we are not being accessed
13808 by an instance reference.
13810 * cs-parser.jay (local_constant_declaration): Implement.
13812 (declaration_statement): Implement for constant declarations.
13814 2001-11-26 Miguel de Icaza <miguel@ximian.com>
13816 * statement.cs (Switch): Catch double defaults.
13818 (Switch): More work on the switch() statement
13819 implementation. It works for integral values now, need to finish
13823 2001-11-24 Miguel de Icaza <miguel@ximian.com>
13825 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
13826 integer literals into other integer literals. To be used by
13829 2001-11-24 Ravi Pratap <ravi@ximian.com>
13831 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
13834 (EmitDynamicInitializers): Cope with the above since we extract data
13835 directly from ArrayData now.
13837 (ExpectInitializers): Keep track of whether initializers are mandatory
13840 (Bounds): Make it a hashtable to prevent the same dimension being
13841 recorded for every element in that dimension.
13843 (EmitDynamicInitializers): Fix bug which prevented the Set array method
13846 Also fix bug which was causing the indices to be emitted in the reverse
13849 2001-11-24 Miguel de Icaza <miguel@ximian.com>
13851 * expression.cs (ArrayCreation): Implement the bits that Ravi left
13852 unfinished. They do not work, because the underlying code is
13855 2001-11-22 Miguel de Icaza <miguel@ximian.com>
13857 * cs-parser.jay: Remove bogus fixme.
13859 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
13860 on Switch statement.
13862 2001-11-23 Ravi Pratap <ravi@ximian.com>
13864 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
13867 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
13868 parameter. Apparently, any expression is allowed.
13870 (ValidateInitializers): Update accordingly.
13872 (CheckIndices): Fix some tricky bugs thanks to recursion.
13874 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
13875 I was being completely brain-dead.
13877 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
13878 and re-write acordingly.
13880 (DelegateInvocation): Re-write accordingly.
13882 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
13884 (MakeByteBlob): Handle types more correctly.
13886 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
13887 initialization from expressions but it is incomplete because I am a complete
13890 2001-11-22 Miguel de Icaza <miguel@ximian.com>
13892 * statement.cs (If.Emit): Fix a bug that generated incorrect code
13893 on If. Basically, we have to return `true' (ie, we do return to
13894 our caller) only if both branches of the if return.
13896 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
13897 short-circuit operators, handle them as short circuit operators.
13899 (Cast.DoResolve): Resolve type.
13900 (Cast.Cast): Take an expression as the target type.
13902 * cs-parser.jay (cast_expression): Remove old hack that only
13903 allowed a limited set of types to be handled. Now we take a
13904 unary_expression and we resolve to a type during semantic
13907 Use the grammar productions from Rhys to handle casts (this is
13908 not complete like Rhys syntax yet, we fail to handle that corner
13909 case that C# has regarding (-x), but we will get there.
13911 2001-11-22 Ravi Pratap <ravi@ximian.com>
13913 * class.cs (EmitFieldInitializer): Take care of the case when we have a
13914 field which is an array type.
13916 * cs-parser.jay (declare_local_variables): Support array initialization too.
13918 * typemanager.cs (MakeKey): Implement.
13920 (everywhere): Use the above appropriately.
13922 * cs-parser.jay (for_statement): Update for array initialization while
13923 declaring variables.
13925 * ecore.cs : The error message was correct, it's the variable's names that
13926 were misleading ;-) Make the code more readable.
13928 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
13929 the correct type etc.
13931 (ConvertExplicit): Handle Enum types by examining the underlying type.
13933 2001-11-21 Ravi Pratap <ravi@ximian.com>
13935 * parameter.cs (GetCallingConvention): Always return
13936 CallingConventions.Standard for now.
13938 2001-11-22 Miguel de Icaza <miguel@ximian.com>
13940 * expression.cs (Binary.ResolveOperator): Update the values of `l'
13941 and `r' after calling DoNumericPromotions.
13943 * ecore.cs: Fix error message (the types were in the wrong order).
13945 * statement.cs (Foreach.ProbeCollectionType): Need to pass
13946 BindingFlags.Instance as well
13948 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
13949 implicit int literal conversion in an empty cast so that we
13950 propagate the right type upstream.
13952 (UnboxCast): new class used to unbox value types.
13953 (Expression.ConvertExplicit): Add explicit type conversions done
13956 (Expression.ImplicitNumericConversion): Oops, forgot to test for
13957 the target type before applying the implicit LongLiterals to ULong
13960 2001-11-21 Miguel de Icaza <miguel@ximian.com>
13962 * cs-parser.jay (for_statement): Reworked the way For works: now
13963 we declare manually any variables that are introduced in
13964 for_initializer to solve the problem of having out-of-band code
13965 emition (that is what got for broken).
13967 (declaration_statement): Perform the actual variable declaration
13968 that used to be done in local_variable_declaration here.
13970 (local_variable_declaration): Do not declare anything, just pass
13971 the information on a DictionaryEntry
13973 2001-11-20 Ravi Pratap <ravi@ximian.com>
13975 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
13976 re-write of the logic to now make it recursive.
13978 (UpdateIndices): Re-write accordingly.
13980 Store element data in a separate ArrayData list in the above methods.
13982 (MakeByteBlob): Implement to dump the array data into a byte array.
13984 2001-11-19 Ravi Pratap <ravi@ximian.com>
13986 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
13989 * constant.cs (Define): Implement.
13991 (EmitConstant): Re-write fully.
13993 Pass in location info.
13995 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
13998 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
13999 DictionaryEntry since we need location info too.
14001 (constant_declaration): Update accordingly.
14003 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
14004 code into another method : UpdateIndices.
14006 2001-11-18 Ravi Pratap <ravi@ximian.com>
14008 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
14009 some type checking etc.
14011 2001-11-17 Ravi Pratap <ravi@ximian.com>
14013 * expression.cs (ArrayCreation::ValidateInitializers): Implement
14014 bits to provide dimension info if the user skips doing that.
14016 Update second constructor to store the rank correctly.
14018 2001-11-16 Ravi Pratap <ravi@ximian.com>
14020 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
14021 and try to implement.
14023 * ../errors/cs0150.cs : Add.
14025 * ../errors/cs0178.cs : Add.
14027 2001-11-16 Miguel de Icaza <miguel@ximian.com>
14029 * statement.cs: Implement foreach on multi-dimensional arrays.
14031 * parameter.cs (Parameters.GetParameterByName): Also lookup the
14032 name of the params argument.
14034 * expression.cs: Use EmitStoreOpcode to get the right opcode while
14035 initializing the array.
14037 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
14038 we can use this elsewhere.
14040 * statement.cs: Finish implementation of foreach for single
14043 * cs-parser.jay: Use an out-of-band stack to pass information
14044 around, I wonder why I need this.
14046 foreach_block: Make the new foreach_block the current_block.
14048 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
14049 function used to return a static Parameters structure. Used for
14050 empty parameters, as those are created very frequently.
14052 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
14054 2001-11-15 Ravi Pratap <ravi@ximian.com>
14056 * interface.cs : Default modifier is private, not public. The
14057 make verify test passes again.
14059 2001-11-15 Ravi Pratap <ravi@ximian.com>
14061 * support.cs (ReflectionParameters): Fix logic to determine
14062 whether the last parameter is a params one. Test 9 passes again.
14064 * delegate.cs (Populate): Register the builders we define with
14065 RegisterParameterForBuilder. Test 19 passes again.
14067 * cs-parser.jay (property_declaration): Reference $6 instead
14068 of $$ to get at the location.
14070 (indexer_declaration): Similar stuff.
14072 (attribute): Ditto.
14074 * class.cs (Property): Register parameters for the Get and Set methods
14075 if they exist. Test 23 passes again.
14077 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
14078 call to EmitArguments as we are sure there aren't any params arguments.
14079 Test 32 passes again.
14081 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
14082 IndexOutOfRangeException.
14084 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
14085 Test 33 now passes again.
14087 2001-11-15 Miguel de Icaza <miguel@ximian.com>
14089 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
14090 broke a bunch of things. Will have to come up with a better way
14091 of tracking locations.
14093 * statement.cs: Implemented foreach for single dimension arrays.
14095 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14097 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
14098 an error. This removes the lookup from the critical path.
14100 * cs-parser.jay: Removed use of temporary_loc, which is completely
14103 2001-11-14 Miguel de Icaza <miguel@ximian.com>
14105 * support.cs (ReflectionParameters.ParameterModifier): Report
14106 whether the argument is a PARAMS argument or not.
14108 * class.cs: Set the attribute `ParamArrayAttribute' on the
14109 parameter argument.
14111 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
14112 and cons_param_array_attribute (ConstructorInfo for
14113 ParamArrayAttribute).,
14115 * codegen.cs: Emit the return using the `Return' statement, that
14116 way we can report the error correctly for missing return values.
14118 * class.cs (Method.Emit): Clean up.
14120 * expression.cs (Argument.Resolve): Take another argument: the
14121 location where this argument is used. Notice that this is not
14122 part of the "Argument" class as to reduce the size of the
14123 structure (we know the approximate location anyways).
14125 Test if the argument is a variable-reference, if not, then
14126 complain with a 206.
14128 (Argument.Emit): Emit addresses of variables.
14130 (Argument.FullDesc): Simplify.
14132 (Invocation.DoResolve): Update for Argument.Resolve.
14134 (ElementAccess.DoResolve): ditto.
14136 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
14137 method should be virtual, as this method is always virtual.
14139 (NewDelegate.DoResolve): Update for Argument.Resolve.
14141 * class.cs (ConstructorInitializer.DoResolve): ditto.
14143 * attribute.cs (Attribute.Resolve): ditto.
14145 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14147 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
14149 * expression.cs (ParameterReference): Drop IStackStorage and implement
14150 IAssignMethod instead.
14152 (LocalVariableReference): ditto.
14154 * ecore.cs (FieldExpr): Drop IStackStorage and implement
14155 IAssignMethod instead.
14157 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14159 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
14160 enumerations that are used in heavily used structures derive from
14161 byte in a laughable and pathetic attempt to reduce memory usage.
14162 This is the kind of pre-optimzations that you should not do at
14163 home without adult supervision.
14165 * expression.cs (UnaryMutator): New class, used to handle ++ and
14166 -- separatedly from the other unary operators. Cleans up the
14167 code, and kills the ExpressionStatement dependency in Unary.
14169 (Unary): Removed `method' and `Arguments' from this class, making
14170 it smaller, and moving it all to SimpleCall, so I can reuse this
14171 code in other locations and avoid creating a lot of transient data
14172 strucutres when not required.
14174 * cs-parser.jay: Adjust for new changes.
14176 2001-11-11 Miguel de Icaza <miguel@ximian.com>
14178 * enum.cs (Enum.Populate): If there is a failure during
14181 * cs-parser.jay (opt_enum_base): we used to catch type errors
14182 here, but this is really incorrect. The type error should be
14183 catched during semantic analysis.
14185 2001-12-11 Ravi Pratap <ravi@ximian.com>
14187 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
14188 current_local_parameters as expected since I, in my stupidity, had forgotten
14191 * attribute.cs (GetValidPlaces): Fix stupid bug.
14193 * class.cs (Method::Emit): Perform check on applicability of attributes.
14195 (Constructor::Emit): Ditto.
14197 (Field::Emit): Ditto.
14199 (Field.Location): Store location information.
14201 (Property, Event, Indexer, Operator): Ditto.
14203 * cs-parser.jay (field_declaration): Pass in location for each field.
14205 * ../errors/cs0592.cs : Add.
14207 2001-11-12 Ravi Pratap <ravi@ximian.com>
14209 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
14211 (InitCoreTypes): Update accordingly.
14213 (RegisterAttrType, LookupAttr): Implement.
14215 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
14216 info about the same.
14218 (Resolve): Update to populate the above as necessary.
14220 (Error592): Helper.
14222 (GetValidPlaces): Helper to the above.
14224 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
14226 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
14228 2001-11-12 Ravi Pratap <ravi@ximian.com>
14230 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
14232 * ../errors/cs0617.cs : Add.
14234 2001-11-11 Ravi Pratap <ravi@ximian.com>
14236 * enum.cs (Emit): Rename to Populate to be more consistent with what
14237 we expect it to do and when exactly it is called.
14239 * class.cs, rootcontext.cs : Update accordingly.
14241 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
14242 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
14244 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
14246 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
14247 of a fieldinfo using the above, when dealing with a FieldBuilder.
14249 2001-11-10 Ravi Pratap <ravi@ximian.com>
14251 * ../errors/cs0031.cs : Add.
14253 * ../errors/cs1008.cs : Add.
14255 * ../errrors/cs0543.cs : Add.
14257 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
14260 (FindMembers): Implement.
14262 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
14263 enums and delegates too.
14265 (enum_types): Rename to builder_to_enum.
14267 (delegate_types): Rename to builder_to_delegate.
14269 * delegate.cs (FindMembers): Implement.
14271 2001-11-09 Ravi Pratap <ravi@ximian.com>
14273 * typemanager.cs (IsEnumType): Implement.
14275 * enum.cs (Emit): Re-write parts to account for the underlying type
14276 better and perform checking etc.
14278 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
14279 of the underlying type.
14281 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
14284 * enum.cs (error31): Helper to report error #31.
14286 * cs-parser.jay (enum_declaration): Store location of each member too.
14288 * enum.cs (member_to_location): New hashtable.
14290 (AddEnumMember): Update location hashtable.
14292 (Emit): Use the location of each member while reporting errors.
14294 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14296 * cs-parser.jay: A for_initializer if is a
14297 local_variable_declaration really ammount to have an implicit
14298 block with the variable declaration and no initializer for for.
14300 * statement.cs (For.Emit): Cope with null initializers.
14302 This fixes the infinite loop on for initializers.
14304 2001-11-08 Miguel de Icaza <miguel@ximian.com>
14306 * enum.cs: More cleanup.
14308 * ecore.cs: Remove dead code.
14310 * class.cs (Property.Emit): More simplification.
14311 (Event.Emit): ditto.
14313 Reworked to have less levels of indentation.
14315 2001-11-08 Ravi Pratap <ravi@ximian.com>
14317 * class.cs (Property): Emit attributes.
14327 * enum.cs (Emit): Ditto.
14329 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
14332 * class.cs (Field, Event, etc.): Move attribute generation into the
14333 Emit method everywhere.
14335 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
14336 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
14337 as we had no way of defining nested enums !
14339 * rootcontext.cs : Adjust code accordingly.
14341 * typemanager.cs (AddEnumType): To keep track of enum types separately.
14343 2001-11-07 Ravi Pratap <ravi@ximian.com>
14345 * expression.cs (EvalConstantExpression): Move into ecore.cs
14347 * enum.cs (Enum): Rename some members and make them public and readonly
14348 according to our convention.
14350 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
14353 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
14355 (Enum::Emit): Write a simple version for now which doesn't try to compute
14356 expressions. I shall modify this to be more robust in just a while.
14358 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
14360 (TypeContainer::CloseType): Create the Enum types too.
14362 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
14364 * expression.cs (EvalConstantExpression): Get rid of completely.
14366 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
14367 user-defined values and other cases.
14369 (IsValidEnumLiteral): Helper function.
14371 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
14372 out there in the case we had a literal FieldExpr.
14374 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
14376 (Literalize): Revamp a bit to take two arguments.
14378 (EnumLiteral): New class which derives from Literal to wrap enum literals.
14380 2001-11-06 Ravi Pratap <ravi@ximian.com>
14382 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
14384 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
14386 (Resolve): Use the above to ensure we have proper initializers.
14388 2001-11-05 Ravi Pratap <ravi@ximian.com>
14390 * expression.cs (Expression::EvalConstantExpression): New method to
14391 evaluate constant expressions.
14393 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
14395 2001-11-07 Miguel de Icaza <miguel@ximian.com>
14397 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
14400 (Binary.ResolveOperator): Handle operator != (object a, object b)
14401 and operator == (object a, object b);
14403 (Binary.DoNumericPromotions): Indicate whether the numeric
14404 promotion was possible.
14406 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
14409 Made the ArrayAccess implement interface IAssignMethod instead of
14410 IStackStore as the order in which arguments are passed reflects
14413 * assign.cs: Instead of using expr.ExprClass to select the way of
14414 assinging, probe for the IStackStore/IAssignMethod interfaces.
14416 * typemanager.cs: Load InitializeArray definition.
14418 * rootcontext.cs (RootContext.MakeStaticData): Used to define
14419 static data that can be used to initialize arrays.
14421 2001-11-05 Miguel de Icaza <miguel@ximian.com>
14423 * expression.cs: Handle operator== and operator!= for booleans.
14425 (Conditioal.Reduce): Implement reducer for the ?: operator.
14427 (Conditional.Resolve): Implement dead code elimination.
14429 (Binary.Resolve): Catch string literals and return a new
14430 concatenated string.
14432 (Unary.Reduce): Implement reduction of unary expressions.
14434 * ecore.cs: Split out the expression core handling here.
14436 (Expression.Reduce): New method used to perform constant folding
14437 and CSE. This is needed to support constant-expressions.
14439 * statement.cs (Statement.EmitBoolExpression): Pass true and false
14440 targets, and optimize for !x.
14442 2001-11-04 Ravi Pratap <ravi@ximian.com>
14444 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
14445 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
14446 set custom atttributes.
14448 * literal.cs (Literal::GetValue): New abstract method to return the actual
14449 value of the literal, cast as an object.
14451 (*Literal): Implement GetValue method.
14453 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
14454 expressions to the arraylist but objects of type Argument.
14456 * class.cs (TypeContainer::Emit): Emit our attributes too.
14458 (Method::Emit, Constructor::Emit): Ditto.
14460 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
14461 to be ignoring earlier.
14463 2001-11-03 Ravi Pratap <ravi@ximian.com>
14465 * attribute.cs (AttributeSection::Define): Implement to do the business
14466 of constructing a CustomAttributeBuilder.
14468 (Attribute): New trivial class. Increases readability of code.
14470 * cs-parser.jay : Update accordingly.
14472 (positional_argument_list, named_argument_list, named_argument): New rules
14474 (attribute_arguments): Use the above so that we are more correct.
14476 2001-11-02 Ravi Pratap <ravi@ximian.com>
14478 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
14479 to perform all checks for a method with a params parameter.
14481 (Invocation::OverloadResolve): Update to use the above method and therefore
14482 cope correctly with params method invocations.
14484 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
14487 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
14488 constructors in our parent too because we can't afford to miss out on
14491 * attribute.cs (AttributeSection): New name for the class Attribute
14493 Other trivial changes to improve readability.
14495 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
14496 use the new class names.
14498 2001-11-01 Ravi Pratap <ravi@ximian.com>
14500 * class.cs (Method::Define): Complete definition for params types too
14502 (Indexer::Define): Ditto.
14504 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
14505 Cope everywhere with a request for info about the array parameter.
14507 2001-11-01 Ravi Pratap <ravi@ximian.com>
14509 * tree.cs (RecordNamespace): Fix up to check for the correct key.
14511 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
14512 local_variable_type to extract the string corresponding to the type.
14514 (local_variable_type): Fixup the action to use the new helper method.
14516 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
14519 * expression.cs : Clean out code which uses the above.
14521 2001-10-31 Ravi Pratap <ravi@ximian.com>
14523 * typemanager.cs (RegisterMethod): Check if we already have an existing key
14524 and bale out if necessary by returning a false.
14526 (RegisterProperty): Ditto.
14528 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
14529 and print out appropriate error messages.
14531 * interface.cs (everywhere): Ditto.
14533 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
14534 location to constructor.
14536 * class.cs (Property, Event, Indexer): Update accordingly.
14538 * ../errors/cs111.cs : Added.
14540 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
14541 of a method, as laid down by the spec.
14543 (Invocation::OverloadResolve): Use the above method.
14545 2001-10-31 Ravi Pratap <ravi@ximian.com>
14547 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
14548 now take a TypeContainer and a Parameters object.
14550 (ParameterData): Modify return type of ParameterModifier method to be
14551 Parameter.Modifier and not a string.
14553 (ReflectionParameters, InternalParameters): Update accordingly.
14555 * expression.cs (Argument::GetParameterModifier): Same here.
14557 * support.cs (InternalParameters::ParameterType): Find a better way of determining
14558 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
14559 symbol in it at all so maybe this is only for now.
14561 2001-10-30 Ravi Pratap <ravi@ximian.com>
14563 * support.cs (InternalParameters): Constructor now takes an extra argument
14564 which is the actual Parameters class.
14566 (ParameterDesc): Update to provide info on ref/out modifiers.
14568 * class.cs (everywhere): Update call to InternalParameters to pass in
14569 the second argument too.
14571 * support.cs (ParameterData): Add ParameterModifier, which is a method
14572 to return the modifier info [ref/out etc]
14574 (InternalParameters, ReflectionParameters): Implement the above.
14576 * expression.cs (Argument::ParameterModifier): Similar function to return
14577 info about the argument's modifiers.
14579 (Invocation::OverloadResolve): Update to take into account matching modifiers
14582 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
14583 a new SetFormalParameters object which we pass to InternalParameters.
14585 2001-10-30 Ravi Pratap <ravi@ximian.com>
14587 * expression.cs (NewArray): Merge into the ArrayCreation class.
14589 2001-10-29 Ravi Pratap <ravi@ximian.com>
14591 * expression.cs (NewArray): Merge classes NewBuiltinArray and
14592 NewUserdefinedArray into one as there wasn't much of a use in having
14595 * expression.cs (Argument): Change field's name to ArgType from Type.
14597 (Type): New readonly property which returns the proper type, taking into
14598 account ref/out modifiers.
14600 (everywhere): Adjust code accordingly for the above.
14602 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
14603 whether we are emitting for a ref or out parameter.
14605 * expression.cs (Argument::Emit): Use the above field to set the state.
14607 (LocalVariableReference::Emit): Update to honour the flag and emit the
14610 * parameter.cs (Attributes): Set the correct flags for ref parameters.
14612 * expression.cs (Argument::FullDesc): New function to provide a full desc.
14614 * support.cs (ParameterData): Add method ParameterDesc to the interface.
14616 (ReflectionParameters, InternalParameters): Implement the above method.
14618 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
14621 (Invocation::FullMethodDesc): Ditto.
14623 2001-10-29 Miguel de Icaza <miguel@ximian.com>
14625 * cs-parser.jay: Add extra production for the second form of array
14628 * expression.cs (ArrayCreation): Update to reflect the above
14631 * Small changes to prepare for Array initialization.
14633 2001-10-28 Miguel de Icaza <miguel@ximian.com>
14635 * typemanager.cs (ImplementsInterface): interface might be null;
14636 Deal with this problem;
14638 Also, we do store negative hits on the cache (null values), so use
14639 this instead of calling t.GetInterfaces on the type everytime.
14641 2001-10-28 Ravi Pratap <ravi@ximian.com>
14643 * typemanager.cs (IsBuiltinType): New method to help determine the same.
14645 * expression.cs (New::DoResolve): Get rid of array creation code and instead
14646 split functionality out into different classes.
14648 (New::FormArrayType): Move into NewBuiltinArray.
14650 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
14653 (NewBuiltinArray): New class to handle creation of built-in arrays.
14655 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
14656 account creation of one-dimensional arrays.
14658 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
14660 (NewUserdefinedArray::DoResolve): Implement.
14662 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
14664 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
14665 we maintain inside the TypeManager. This is necessary to perform lookups on the
14668 (LookupType): Update to perform GetType on the module builders too.
14670 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
14672 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
14674 2001-10-23 Ravi Pratap <ravi@ximian.com>
14676 * expression.cs (New::DoResolve): Implement guts of array creation.
14678 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
14680 2001-10-27 Miguel de Icaza <miguel@ximian.com>
14682 * expression.cs: Fix bug I introduced lsat night that broke
14685 (Expression.Resolve): Report a 246 error (can not resolve name)
14686 if we find a SimpleName in the stream.
14688 (Expression.ResolveLValue): Ditto.
14690 (Expression.ResolveWithSimpleName): This function is a variant of
14691 ResolveName, this one allows SimpleNames to be returned without a
14692 warning. The only consumer of SimpleNames is MemberAccess
14694 2001-10-26 Miguel de Icaza <miguel@ximian.com>
14696 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
14697 might arrive here. I have my doubts that this is correct.
14699 * statement.cs (Lock): Implement lock statement.
14701 * cs-parser.jay: Small fixes to support `lock' and `using'
14703 * cs-tokenizer.cs: Remove extra space
14705 * driver.cs: New flag --checked, allows to turn on integer math
14708 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
14709 Threading.Monitor.Exit
14711 2001-10-23 Miguel de Icaza <miguel@ximian.com>
14713 * expression.cs (IndexerAccess::DoResolveLValue): Set the
14714 Expression Class to be IndexerAccess.
14716 Notice that Indexer::DoResolve sets the eclass to Value.
14718 2001-10-22 Miguel de Icaza <miguel@ximian.com>
14720 * class.cs (TypeContainer::Emit): Emit code for indexers.
14722 * assign.cs (IAssignMethod): New interface implemented by Indexers
14723 and Properties for handling assignment.
14725 (Assign::Emit): Simplify and reuse code.
14727 * expression.cs (IndexerAccess, PropertyExpr): Implement
14728 IAssignMethod, clean up old code.
14730 2001-10-22 Ravi Pratap <ravi@ximian.com>
14732 * typemanager.cs (ImplementsInterface): New method to determine if a type
14733 implements a given interface. Provides a nice cache too.
14735 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
14738 (ConvertReferenceExplicit): Ditto.
14740 * delegate.cs (Delegate::Populate): Update to define the parameters on the
14741 various methods, with correct names etc.
14743 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
14744 Operator.UnaryNegation.
14746 * cs-parser.jay (operator_declarator): Be a little clever in the case where
14747 we have a unary plus or minus operator.
14749 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
14752 * everywhere : update accordingly.
14754 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
14757 * class.cs (Method::Define): For the case where we are implementing a method
14758 inherited from an interface, we need to set the MethodAttributes.Final flag too.
14759 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
14761 2001-10-21 Ravi Pratap <ravi@ximian.com>
14763 * interface.cs (FindMembers): Implement to work around S.R.E
14766 * typemanager.cs (IsInterfaceType): Implement.
14768 (FindMembers): Update to handle interface types too.
14770 * expression.cs (ImplicitReferenceConversion): Re-write bits which
14771 use IsAssignableFrom as that is not correct - it doesn't work.
14773 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
14774 and accordingly override EmitStatement.
14776 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
14777 using the correct logic :-)
14779 2001-10-19 Ravi Pratap <ravi@ximian.com>
14781 * ../errors/cs-11.cs : Add to demonstrate error -11
14783 2001-10-17 Miguel de Icaza <miguel@ximian.com>
14785 * assign.cs (Assign::Resolve): Resolve right hand side first, and
14786 then pass this as a hint to ResolveLValue.
14788 * expression.cs (FieldExpr): Add Location information
14790 (FieldExpr::LValueResolve): Report assignment to readonly
14793 (Expression::ExprClassFromMemberInfo): Pass location information.
14795 (Expression::ResolveLValue): Add new method that resolves an
14798 (Expression::DoResolveLValue): Default invocation calls
14801 (Indexers): New class used to keep track of indexers in a given
14804 (IStackStore): Renamed from LValue, as it did not really describe
14805 what this did. Also ResolveLValue is gone from this interface and
14806 now is part of Expression.
14808 (ElementAccess): Depending on the element access type
14810 * typemanager.cs: Add `indexer_name_type' as a Core type
14811 (System.Runtime.CompilerServices.IndexerNameAttribute)
14813 * statement.cs (Goto): Take a location.
14815 2001-10-18 Ravi Pratap <ravi@ximian.com>
14817 * delegate.cs (Delegate::VerifyDelegate): New method to verify
14818 if two delegates are compatible.
14820 (NewDelegate::DoResolve): Update to take care of the case when
14821 we instantiate a delegate from another delegate.
14823 * typemanager.cs (FindMembers): Don't even try to look up members
14824 of Delegate types for now.
14826 2001-10-18 Ravi Pratap <ravi@ximian.com>
14828 * delegate.cs (NewDelegate): New class to take care of delegate
14831 * expression.cs (New): Split the delegate related code out into
14832 the NewDelegate class.
14834 * delegate.cs (DelegateInvocation): New class to handle delegate
14837 * expression.cs (Invocation): Split out delegate related code into
14838 the DelegateInvocation class.
14840 2001-10-17 Ravi Pratap <ravi@ximian.com>
14842 * expression.cs (New::DoResolve): Implement delegate creation fully
14843 and according to the spec.
14845 (New::DoEmit): Update to handle delegates differently.
14847 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
14848 because of which we were printing out arguments in reverse order !
14850 * delegate.cs (VerifyMethod): Implement to check if the given method
14851 matches the delegate.
14853 (FullDelegateDesc): Implement.
14855 (VerifyApplicability): Implement.
14857 * expression.cs (Invocation::DoResolve): Update to accordingly handle
14858 delegate invocations too.
14860 (Invocation::Emit): Ditto.
14862 * ../errors/cs1593.cs : Added.
14864 * ../errors/cs1594.cs : Added.
14866 * delegate.cs (InstanceExpression, TargetMethod): New properties.
14868 2001-10-16 Ravi Pratap <ravi@ximian.com>
14870 * typemanager.cs (intptr_type): Core type for System.IntPtr
14872 (InitCoreTypes): Update for the same.
14874 (iasyncresult_type, asynccallback_type): Ditto.
14876 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
14879 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
14882 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
14883 the builders for the 4 members of a delegate type :-)
14885 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
14888 * expression.cs (New::DoResolve): Implement guts for delegate creation.
14890 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
14892 2001-10-15 Miguel de Icaza <miguel@ximian.com>
14894 * statement.cs (Break::Emit): Implement.
14895 (Continue::Emit): Implement.
14897 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
14898 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
14899 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
14900 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
14903 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
14904 properties that track the label for the current loop (begin of the
14905 loop and end of the loop).
14907 2001-10-15 Ravi Pratap <ravi@ximian.com>
14909 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
14910 use of emitting anything at all.
14912 * class.cs, rootcontext.cs : Get rid of calls to the same.
14914 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
14916 (Populate): Define the constructor correctly and set the implementation
14919 * typemanager.cs (delegate_types): New hashtable to hold delegates that
14922 (AddDelegateType): Implement.
14924 (IsDelegateType): Implement helper method.
14926 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
14928 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
14929 and accordingly handle it.
14931 * delegate.cs (Populate): Take TypeContainer argument.
14932 Implement bits to define the Invoke method. However, I still haven't figured out
14933 how to take care of the native int bit :-(
14935 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
14936 Qualify the name of the delegate, not its return type !
14938 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
14941 (StandardConversionExists): Checking for array types turns out to be recursive.
14943 (ConvertReferenceExplicit): Implement array conversion.
14945 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
14947 2001-10-12 Ravi Pratap <ravi@ximian.com>
14949 * cs-parser.jay (delegate_declaration): Store the fully qualified
14950 name as it is a type declaration.
14952 * delegate.cs (ReturnType, Name): Rename members to these. Make them
14955 (DefineDelegate): Renamed from Define. Does the same thing essentially,
14956 as TypeContainer::DefineType.
14958 (Populate): Method in which all the definition of the various methods (Invoke)
14961 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
14964 (CloseDelegate): Finally creates the delegate.
14966 * class.cs (TypeContainer::DefineType): Update to define delegates.
14967 (Populate, Emit and CloseType): Do the same thing here too.
14969 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
14970 delegates in all these operations.
14972 2001-10-14 Miguel de Icaza <miguel@ximian.com>
14974 * expression.cs: LocalTemporary: a new expression used to
14975 reference a temporary that has been created.
14977 * assign.cs: Handle PropertyAccess back here, so that we can
14978 provide the proper semantic access to properties.
14980 * expression.cs (Expression::ConvertReferenceExplicit): Implement
14981 a few more explicit conversions.
14983 * modifiers.cs: `NEW' modifier maps to HideBySig.
14985 * expression.cs (PropertyExpr): Make this into an
14986 ExpressionStatement, and support the EmitStatement code path.
14988 Perform get/set error checking, clean up the interface.
14990 * assign.cs: recognize PropertyExprs as targets, and if so, turn
14991 them into toplevel access objects.
14993 2001-10-12 Miguel de Icaza <miguel@ximian.com>
14995 * expression.cs: PropertyExpr::PropertyExpr: use work around the
14998 * typemanager.cs: Keep track here of our PropertyBuilders again to
14999 work around lameness in SRE.
15001 2001-10-11 Miguel de Icaza <miguel@ximian.com>
15003 * expression.cs (LValue::LValueResolve): New method in the
15004 interface, used to perform a second resolution pass for LValues.
15006 (This::DoResolve): Catch the use of this in static methods.
15008 (This::LValueResolve): Implement.
15010 (This::Store): Remove warning, assigning to `this' in structures
15013 (Invocation::Emit): Deal with invocation of
15014 methods on value types. We need to pass the address to structure
15015 methods rather than the object itself. (The equivalent code to
15016 emit "this" for structures leaves the entire structure on the
15017 stack instead of a pointer to it).
15019 (ParameterReference::DoResolve): Compute the real index for the
15020 argument based on whether the method takes or not a `this' pointer
15021 (ie, the method is static).
15023 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
15024 value types returned from functions when we need to invoke a
15025 method on the sturcture.
15028 2001-10-11 Ravi Pratap <ravi@ximian.com>
15030 * class.cs (TypeContainer::DefineType): Method to actually do the business of
15031 defining the type in the Modulebuilder or Typebuilder. This is to take
15032 care of nested types which need to be defined on the TypeBuilder using
15033 DefineNestedMethod.
15035 (TypeContainer::GetClassBases): Implement. Essentially the code from the
15036 methods in RootContext, only ported to be part of TypeContainer.
15038 (TypeContainer::GetInterfaceOrClass): Ditto.
15040 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
15042 * interface.cs (Interface::DefineInterface): New method. Does exactly
15043 what RootContext.CreateInterface did earlier, only it takes care of nested types
15046 (Interface::GetInterfaces): Move from RootContext here and port.
15048 (Interface::GetInterfaceByName): Same here.
15050 * rootcontext.cs (ResolveTree): Re-write.
15052 (PopulateTypes): Re-write.
15054 * class.cs (TypeContainer::Populate): Populate nested types too.
15055 (TypeContainer::Emit): Emit nested members too.
15057 * typemanager.cs (AddUserType): Do not make use of the FullName property,
15058 instead just use the name argument passed in as it is already fully
15061 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
15062 to TypeContainer mapping to see if a type is user-defined.
15064 * class.cs (TypeContainer::CloseType): Implement.
15066 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
15067 the default constructor.
15069 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
15072 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
15074 * interface.cs (CloseType): Create the type here.
15076 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
15079 Remove all the methods which are now in TypeContainer.
15081 2001-10-10 Ravi Pratap <ravi@ximian.com>
15083 * delegate.cs (Define): Re-write bits to define the delegate
15086 2001-10-10 Miguel de Icaza <miguel@ximian.com>
15088 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
15090 * expression.cs (ImplicitReferenceConversion): handle null as well
15091 as a source to convert to any reference type.
15093 * statement.cs (Return): Perform any implicit conversions to
15094 expected return type.
15096 Validate use of return statement.
15098 * codegen.cs (EmitContext): Pass the expected return type here.
15100 * class.cs (Method, Constructor, Property): Pass expected return
15101 type to EmitContext.
15103 2001-10-09 Miguel de Icaza <miguel@ximian.com>
15105 * expression.cs: Make DoResolve take an EmitContext instead of a
15108 Replaced `l' and `location' for `loc', for consistency.
15110 (Error, Warning): Remove unneeded Tc argument.
15112 * assign.cs, literal.cs, constant.cs: Update to new calling
15115 * codegen.cs: EmitContext now contains a flag indicating whether
15116 code is being generated in a static method or not.
15118 * cs-parser.jay: DecomposeQI, new function that replaces the old
15119 QualifiedIdentifier. Now we always decompose the assembled
15120 strings from qualified_identifier productions into a group of
15123 2001-10-08 Miguel de Icaza <miguel@ximian.com>
15125 * rootcontext.cs: Deal with field-less struct types correctly now
15126 by passing the size option to Define Type.
15128 * class.cs: Removed hack that created one static field.
15130 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15132 * statement.cs: Moved most of the code generation here.
15134 2001-10-09 Ravi Pratap <ravi@ximian.com>
15136 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
15139 (ElementAccess): Remove useless bits for now - keep checks as the spec
15142 2001-10-08 Ravi Pratap <ravi@ximian.com>
15144 * expression.cs (ElementAccess::DoResolve): Remove my crap code
15145 and start performing checks according to the spec.
15147 2001-10-07 Ravi Pratap <ravi@ximian.com>
15149 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
15150 rank_specifiers instead.
15152 (rank_specifiers): Change the order in which the rank specifiers are stored
15154 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
15156 * expression.cs (ElementAccess): Implement the LValue interface too.
15158 2001-10-06 Ravi Pratap <ravi@ximian.com>
15160 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
15161 except that user defined conversions are not included.
15163 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
15164 perform the conversion of the return type, if necessary.
15166 (New::DoResolve): Check whether we are creating an array or an object
15167 and accordingly do the needful.
15169 (New::Emit): Same here.
15171 (New::DoResolve): Implement guts of array creation.
15173 (New::FormLookupType): Helper function.
15175 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15177 * codegen.cs: Removed most of the code generation here, and move the
15178 corresponding code generation bits to the statement classes.
15180 Added support for try/catch/finalize and throw.
15182 * cs-parser.jay: Added support for try/catch/finalize.
15184 * class.cs: Catch static methods having the flags override,
15185 virtual or abstract.
15187 * expression.cs (UserCast): This user cast was not really doing
15188 what it was supposed to do. Which is to be born in fully resolved
15189 state. Parts of the resolution were being performed at Emit time!
15193 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15195 * expression.cs: Implicity convert the result from UserCast.
15197 2001-10-05 Ravi Pratap <ravi@ximian.com>
15199 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
15200 prevented it from working correctly.
15202 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
15203 merely ConvertImplicit.
15205 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15207 * typemanager.cs: Make the LookupTypeContainer function static,
15208 and not per-instance.
15210 * class.cs: Make static FindMembers (the one that takes a Type
15213 * codegen.cs: Add EmitForeach here.
15215 * cs-parser.jay: Make foreach a toplevel object instead of the
15216 inline expansion, as we need to perform semantic analysis on it.
15218 2001-10-05 Ravi Pratap <ravi@ximian.com>
15220 * expression.cs (Expression::ImplicitUserConversion): Rename to
15221 UserDefinedConversion.
15223 (Expression::UserDefinedConversion): Take an extra argument specifying
15224 whether we look for explicit user conversions too.
15226 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
15228 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
15230 (ExplicitUserConversion): Make it a call to UserDefinedConversion
15231 with the appropriate arguments.
15233 * cs-parser.jay (cast_expression): Record location too.
15235 * expression.cs (Cast): Record location info.
15237 (Expression::ConvertExplicit): Take location argument.
15239 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
15240 to determine if we are doing explicit conversions.
15242 (UserCast::Emit): Update accordingly.
15244 (Expression::ConvertExplicit): Report an error if everything fails.
15246 * ../errors/cs0030.cs : Add.
15248 2001-10-04 Miguel de Icaza <miguel@ximian.com>
15250 * modifiers.cs: If the ABSTRACT keyword is present, also set the
15251 virtual and newslot bits.
15253 * class.cs (TypeContainer::RegisterRequiredImplementations):
15254 Record methods we need.
15256 (TypeContainer::MakeKey): Helper function to make keys for
15257 MethodBases, since the Methodbase key is useless.
15259 (TypeContainer::Populate): Call RegisterRequiredImplementations
15260 before defining the methods.
15262 Create a mapping for method_builders_to_methods ahead of time
15263 instead of inside a tight loop.
15265 (::RequireMethods): Accept an object as the data to set into the
15266 hashtable so we can report interface vs abstract method mismatch.
15268 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15270 * report.cs: Make all of it static.
15272 * rootcontext.cs: Drop object_type and value_type computations, as
15273 we have those in the TypeManager anyways.
15275 Drop report instance variable too, now it is a global.
15277 * driver.cs: Use try/catch on command line handling.
15279 Add --probe option to debug the error reporting system with a test
15282 * report.cs: Add support for exiting program when a probe
15283 condition is reached.
15285 2001-10-03 Ravi Pratap <ravi@ximian.com>
15287 * expression.cs (Binary::DoNumericPromotions): Fix the case when
15288 we do a forcible conversion regardless of type, to check if
15289 ForceConversion returns a null.
15291 (Binary::error19): Use location to report error.
15293 (Unary::error23): Use location here too.
15295 * ../errors/cs0019.cs : Check in.
15297 * ../errors/cs0023.cs : Check in.
15299 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
15300 case of a non-null MethodInfo object with a length of 0 !
15302 (Binary::ResolveOperator): Flag error if overload resolution fails to find
15303 an applicable member - according to the spec :-)
15304 Also fix logic to find members in base types.
15306 (Unary::ResolveOperator): Same here.
15308 (Unary::report23): Change name to error23 and make first argument a TypeContainer
15309 as I was getting thoroughly confused between this and error19 :-)
15311 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
15312 (::FindMostEncompassedType): Implement.
15313 (::FindMostEncompassingType): Implement.
15314 (::StandardConversionExists): Implement.
15316 (UserImplicitCast): Re-vamp. We now need info about most specific
15317 source and target types so that we can do the necessary conversions.
15319 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
15320 mathematical union with no duplicates.
15322 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15324 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
15325 in order from base classes to child classes, so that we can in
15326 child classes look up in our parent for method names and
15327 attributes (required for handling abstract, virtual, new, override
15328 constructs: we need to instrospect our base class, and if we dont
15329 populate the classes in order, the introspection might be
15330 incorrect. For example, a method could query its parent before
15331 the parent has any methods and would determine that the parent has
15332 no abstract methods (while it could have had them)).
15334 (RootContext::CreateType): Record the order in which we define the
15337 2001-10-02 Miguel de Icaza <miguel@ximian.com>
15339 * class.cs (TypeContainer::Populate): Also method definitions can
15340 fail now, keep track of this.
15342 (TypeContainer::FindMembers): Implement support for
15343 DeclaredOnly/noDeclaredOnly flag.
15345 (Constructor::Emit) Return the ConstructorBuilder.
15347 (Method::Emit) Return the MethodBuilder.
15348 Check for abstract or virtual methods to be public.
15350 * rootcontext.cs (RootContext::CreateType): Register all the
15351 abstract methods required for the class to be complete and the
15352 interface methods that must be implemented.
15354 * cs-parser.jay: Report error 501 (method requires body if it is
15355 not marked abstract or extern).
15357 * expression.cs (TypeOf::Emit): Implement.
15359 * typemanager.cs: runtime_handle_type, new global type.
15361 * class.cs (Property::Emit): Generate code for properties.
15363 2001-10-02 Ravi Pratap <ravi@ximian.com>
15365 * expression.cs (Unary::ResolveOperator): Find operators on base type
15366 too - we now conform exactly to the spec.
15368 (Binary::ResolveOperator): Same here.
15370 * class.cs (Operator::Define): Fix minor quirk in the tests.
15372 * ../errors/cs0215.cs : Added.
15374 * ../errors/cs0556.cs : Added.
15376 * ../errors/cs0555.cs : Added.
15378 2001-10-01 Miguel de Icaza <miguel@ximian.com>
15380 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
15381 single integer which is really efficient
15383 2001-10-01 Ravi Pratap <ravi@ximian.com>
15385 * expression.cs (Expression::ImplicitUserConversion): Use location
15386 even in the case when we are examining True operators.
15388 * class.cs (Operator::Define): Perform extensive checks to conform
15389 with the rules for operator overloading in the spec.
15391 * expression.cs (Expression::ImplicitReferenceConversion): Implement
15392 some of the other conversions mentioned in the spec.
15394 * typemanager.cs (array_type): New static member for the System.Array built-in
15397 (cloneable_interface): For System.ICloneable interface.
15399 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
15400 we start resolving the tree and populating types.
15402 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
15404 2001-10-01 Miguel de Icaza <miguel@ximian.com>
15406 * expression.cs (Expression::ExprClassFromMemberInfo,
15407 Expression::Literalize): Create literal expressions from
15408 FieldInfos which are literals.
15410 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
15411 type casts, because they were wrong. The test suite in tests
15414 (ImplicitNumericConversion): ushort to ulong requires a widening
15417 Int32 constant to long requires widening cast as well.
15419 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
15420 for integers because the type on the stack is not i4.
15422 2001-09-30 Miguel de Icaza <miguel@ximian.com>
15424 * expression.cs (report118): require location argument.
15426 * parameter.cs: Do not dereference potential null value.
15428 * class.cs: Catch methods that lack the `new' keyword when
15429 overriding a name. Report warnings when `new' is used without
15430 anything being there to override.
15432 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
15434 * class.cs: Only add constructor to hashtable if it is non-null
15435 (as now constructors can fail on define).
15437 (TypeManager, Class, Struct): Take location arguments.
15439 Catch field instance initialization in structs as errors.
15441 accepting_filter: a new filter for FindMembers that is static so
15442 that we dont create an instance per invocation.
15444 (Constructor::Define): Catch errors where a struct constructor is
15447 * cs-parser.jay: Pass location information for various new
15450 * delegate.cs (Delegate): take a location argument.
15452 * driver.cs: Do not call EmitCode if there were problesm in the
15453 Definition of the types, as many Builders wont be there.
15455 * decl.cs (Decl::Decl): Require a location argument.
15457 * cs-tokenizer.cs: Handle properly hex constants that can not fit
15458 into integers, and find the most appropiate integer for it.
15460 * literal.cs: Implement ULongLiteral.
15462 * rootcontext.cs: Provide better information about the location of
15463 failure when CreateType fails.
15465 2001-09-29 Miguel de Icaza <miguel@ximian.com>
15467 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
15470 * expression.cs (Binary::CheckShiftArguments): Add missing type
15472 (Binary::ResolveOperator): Add type to the logical and and logical
15473 or, Bitwise And/Or and Exclusive Or code paths, it was missing
15476 (Binary::DoNumericPromotions): In the case where either argument
15477 is ulong (and most signed types combined with ulong cause an
15478 error) perform implicit integer constant conversions as well.
15480 2001-09-28 Miguel de Icaza <miguel@ximian.com>
15482 * expression.cs (UserImplicitCast): Method should always be
15484 (Invocation::BetterConversion): Simplified test for IntLiteral.
15486 (Expression::ImplicitNumericConversion): Split this routine out.
15487 Put the code that performs implicit constant integer conversions
15490 (Expression::Resolve): Become a wrapper around DoResolve so we can
15491 check eclass and type being set after resolve.
15493 (Invocation::Badness): Remove this dead function
15495 (Binary::ResolveOperator): Do not compute the expensive argumnets
15496 unless we have a union for it.
15498 (Probe::Emit): Is needs to do an isinst and then
15499 compare against null.
15501 (::CanConvert): Added Location argument. If the Location argument
15502 is null (Location.Null), then we do not report errors. This is
15503 used by the `probe' mechanism of the Explicit conversion. We do
15504 not want to generate an error for something that the user
15505 explicitly requested to be casted. But the pipeline for an
15506 explicit cast first tests for potential implicit casts.
15508 So for now, if the Location is null, it means `Probe only' to
15509 avoid adding another argument. Might have to revise this
15512 (ClassCast): New class used to type cast objects into arbitrary
15513 classes (used in Explicit Reference Conversions).
15515 Implement `as' as well.
15517 Reverted all the patches from Ravi below: they were broken:
15519 * The use of `level' as a mechanism to stop recursive
15520 invocations is wrong. That was there just to catch the
15521 bug with a strack trace but not as a way of addressing
15524 To fix the problem we have to *understand* what is going
15525 on and the interactions and come up with a plan, not
15526 just get things going.
15528 * The use of the type conversion cache that I proposed
15529 last night had an open topic: How does this work across
15530 protection domains. A user defined conversion might not
15531 be public in the location where we are applying the
15532 conversion, a different conversion might be selected
15533 (ie, private A->B (better) but public B->A (worse),
15534 inside A, A->B applies, but outside it, B->A will
15537 * On top of that (ie, even if the above is solved),
15538 conversions in a cache need to be abstract. Ie, `To
15539 convert from an Int to a Short use an OpcodeCast', not
15540 `To convert from an Int to a Short use the OpcodeCast on
15541 the variable 5' (which is what this patch was doing).
15543 2001-09-28 Ravi Pratap <ravi@ximian.com>
15545 * expression.cs (Invocation::ConversionExists): Re-write to use
15546 the conversion cache
15548 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
15549 cache all conversions done, not just user-defined ones.
15551 (Invocation::BetterConversion): The real culprit. Use ConversionExists
15552 to determine if a conversion exists instead of acutually trying to
15553 perform the conversion. It's faster too.
15555 (Expression::ConvertExplicit): Modify to use ConversionExists to check
15556 and only then attempt the implicit conversion.
15558 2001-09-28 Ravi Pratap <ravi@ximian.com>
15560 * expression.cs (ConvertImplicit): Use a cache for conversions
15561 already found. Check level of recursion and bail out if necessary.
15563 2001-09-28 Miguel de Icaza <miguel@ximian.com>
15565 * typemanager.cs (string_concat_string_string, string_concat_object_object):
15566 Export standard methods that we expect for string operations.
15568 * statement.cs (Block::UsageWarning): Track usage of variables and
15569 report the errors for not used variables.
15571 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
15574 2001-09-27 Miguel de Icaza <miguel@ximian.com>
15576 * codegen.cs: remove unnneded code
15578 * expression.cs: Removed BuiltinTypeAccess class
15580 Fix the order in which implicit conversions are
15583 The previous fixed dropped support for boxed conversions (adding a
15584 test to the test suite now)
15586 (UserImplicitCast::CanConvert): Remove test for source being null,
15587 that code is broken. We should not feed a null to begin with, if
15588 we do, then we should track the bug where the problem originates
15589 and not try to cover it up here.
15591 Return a resolved expression of type UserImplicitCast on success
15592 rather than true/false. Ravi: this is what I was talking about,
15593 the pattern is to use a static method as a "constructor" for
15596 Also, do not create arguments until the very last minute,
15597 otherwise we always create the arguments even for lookups that
15598 will never be performed.
15600 (UserImplicitCast::Resolve): Eliminate, objects of type
15601 UserImplicitCast are born in a fully resolved state.
15603 * typemanager.cs (InitCoreTypes): Init also value_type
15604 (System.ValueType).
15606 * expression.cs (Cast::Resolve): First resolve the child expression.
15608 (LValue): Add new method AddressOf to be used by
15611 Change the argument of Store to take an EmitContext instead of an
15612 ILGenerator, because things like FieldExpr need to be able to call
15613 their children expression to generate the instance code.
15615 (Expression::Error, Expression::Warning): Sugar functions for
15618 (Expression::MemberLookup): Accept a TypeContainer instead of a
15619 Report as the first argument.
15621 (Expression::ResolvePrimary): Killed. I still want to improve
15622 this as currently the code is just not right.
15624 (Expression::ResolveMemberAccess): Simplify, but it is still
15627 (Unary::Resolve): Catch errors in AddressOf operators.
15629 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
15630 index to a byte for the short-version, or the compiler will choose
15631 the wrong Emit call, which generates the wrong data.
15633 (ParameterReference::Emit, ::Store): same.
15635 (FieldExpr::AddressOf): Implement.
15637 * typemanager.cs: TypeManager: made public variable instead of
15640 * driver.cs: document --fatal.
15642 * report.cs (ErrorMessage, WarningMessage): new names for the old
15643 Error and Warning classes.
15645 * cs-parser.jay (member_access): Turn built-in access to types
15646 into a normal simplename
15648 2001-09-27 Ravi Pratap <ravi@ximian.com>
15650 * expression.cs (Invocation::BetterConversion): Fix to cope
15651 with q being null, since this was introducing a bug.
15653 * expression.cs (ConvertImplicit): Do built-in conversions first.
15655 2001-09-27 Ravi Pratap <ravi@ximian.com>
15657 * expression.cs (UserImplicitCast::Resolve): Fix bug.
15659 2001-09-27 Ravi Pratap <ravi@ximian.com>
15661 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
15662 I had introduced long ago (what's new ?).
15664 * expression.cs (UserImplicitCast::CanConvert): Static method to do
15665 the work of all the checking.
15666 (ConvertImplicit): Call CanConvert and only then create object if necessary.
15667 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
15669 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
15670 that is the right way.
15672 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
15673 overloading resolution. Use everywhere instead of cutting and pasting code.
15675 (Binary::ResolveOperator): Use MakeUnionSet.
15677 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
15678 we have to convert to bool types. Not complete yet.
15680 2001-09-27 Miguel de Icaza <miguel@ximian.com>
15682 * typemanager.cs (TypeManager::CSharpName): support ushort.
15684 * expression.cs (Expression::TryImplicitIntConversion): Attempts
15685 to provide an expression that performsn an implicit constant int
15686 conversion (section 6.1.6).
15687 (Expression::ConvertImplicitRequired): Reworked to include
15688 implicit constant expression conversions.
15690 (Expression::ConvertNumericExplicit): Finished.
15692 (Invocation::Emit): If InstanceExpression is null, then it means
15693 that we perform a call on this.
15695 2001-09-26 Miguel de Icaza <miguel@ximian.com>
15697 * expression.cs (Unary::Emit): Remove some dead code.
15698 (Probe): Implement Resolve and Emit for `is'.
15699 (Expression::ConvertImplicitRequired): Attempt to do constant
15700 expression conversions here. Maybe should be moved to
15701 ConvertImplicit, but I am not sure.
15702 (Expression::ImplicitLongConstantConversionPossible,
15703 Expression::ImplicitIntConstantConversionPossible): New functions
15704 that tell whether is it possible to apply an implicit constant
15705 expression conversion.
15707 (ConvertNumericExplicit): Started work on explicit numeric
15710 * cs-parser.jay: Update operator constants.
15712 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
15713 (Parameters::GetSignature): Hook up VerifyArgs here.
15714 (Parameters::VerifyArgs): Verifies that no two arguments have the
15717 * class.cs (Operator): Update the operator names to reflect the
15718 ones that the spec expects (as we are just stringizing the
15721 * expression.cs (Unary::ResolveOperator): Fix bug: Use
15722 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
15723 previous usage did only work for our methods.
15724 (Expression::ConvertImplicit): Handle decimal implicit numeric
15725 conversions as well.
15726 (Expression::InternalTypeConstructor): Used to invoke constructors
15727 on internal types for default promotions.
15729 (Unary::Emit): Implement special handling for the pre/post
15730 increment/decrement for overloaded operators, as they need to have
15731 the same semantics as the other operators.
15733 (Binary::ResolveOperator): ditto.
15734 (Invocation::ConversionExists): ditto.
15735 (UserImplicitCast::Resolve): ditto.
15737 2001-09-26 Ravi Pratap <ravi@ximian.com>
15739 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
15740 operator, return after emitting body. Regression tests pass again !
15742 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
15743 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
15744 (Invocation::OverloadResolve): Ditto.
15745 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
15747 * everywhere : update calls to the above methods accordingly.
15749 2001-09-26 Miguel de Icaza <miguel@ximian.com>
15751 * assign.cs (Assign): Make it inherit from ExpressionStatement.
15753 * expression.cs (ExpressionStatement): New base class used for
15754 expressions that can appear in statements, so that we can provide
15755 an alternate path to generate expression that do not leave a value
15758 (Expression::Emit, and all the derivatives): We no longer return
15759 whether a value is left on the stack or not. Every expression
15760 after being emitted leaves a single value on the stack.
15762 * codegen.cs (EmitContext::EmitStatementExpression): Use the
15763 facilties of ExpressionStatement if possible.
15765 * cs-parser.jay: Update statement_expression.
15767 2001-09-25 Miguel de Icaza <miguel@ximian.com>
15769 * driver.cs: Change the wording of message
15771 2001-09-25 Ravi Pratap <ravi@ximian.com>
15773 * expression.cs (Binary::ResolveOperator): Had forgottten to set
15774 the type of the expression to the return type of the method if
15775 we have an overloaded operator match ! The regression tests pass again !
15776 (Unary::ResolveOperator): Ditto.
15778 * expression.cs (Invocation::ConversionExists): Correct the member lookup
15779 to find "op_Implicit", not "implicit" ;-)
15780 (UserImplicitCast): New class to take care of user-defined implicit conversions.
15781 (ConvertImplicit, ForceConversion): Take TypeContainer argument
15783 * everywhere : Correct calls to the above accordingly.
15785 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
15786 (ConvertImplicit): Do user-defined conversion if it exists.
15788 2001-09-24 Miguel de Icaza <miguel@ximian.com>
15790 * assign.cs: track location.
15791 (Resolve): Use implicit conversions on assignment.
15793 * literal.cs: Oops. Not good, Emit of short access values should
15794 pass (Bytes) or the wrong argument will be selected.
15796 * expression.cs (Unary::Emit): Emit code for -expr.
15798 (Unary::ResolveOperator): Handle `Substract' for non-constants
15799 (substract from zero from the non-constants).
15800 Deal with Doubles as well.
15802 (Expression::ConvertImplicitRequired): New routine that reports an
15803 error if no implicit conversion exists.
15805 (Invocation::OverloadResolve): Store the converted implicit
15806 expressions if we make them
15808 2001-09-24 Ravi Pratap <ravi@ximian.com>
15810 * class.cs (ConstructorInitializer): Take a Location argument.
15811 (ConstructorBaseInitializer): Same here.
15812 (ConstructorThisInitializer): Same here.
15814 * cs-parser.jay : Update all calls accordingly.
15816 * expression.cs (Unary, Binary, New): Take location argument.
15817 Update accordingly everywhere.
15819 * cs-parser.jay : Update all calls to the above to take a location
15822 * class.cs : Ditto.
15824 2001-09-24 Ravi Pratap <ravi@ximian.com>
15826 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
15827 (Invocation::BetterConversion): Same here
15828 (Invocation::ConversionExists): Ditto.
15830 (Invocation::ConversionExists): Implement.
15832 2001-09-22 Ravi Pratap <ravi@ximian.com>
15834 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
15835 Also take an additional TypeContainer argument.
15837 * All over : Pass in TypeContainer as argument to OverloadResolve.
15839 * typemanager.cs (CSharpName): Update to check for the string type and return
15842 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
15845 2001-09-21 Ravi Pratap <ravi@ximian.com>
15847 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
15848 (Invocation::BetterFunction): Implement.
15849 (Invocation::BetterConversion): Implement.
15850 (Invocation::ConversionExists): Skeleton, no implementation yet.
15852 Okay, things work fine !
15854 2001-09-21 Miguel de Icaza <miguel@ximian.com>
15856 * typemanager.cs: declare and load enum_type, delegate_type and
15859 * expression.cs (Expression::Emit): Now emit returns a value that
15860 tells whether a value is left on the stack or not. This strategy
15861 might be reveted tomorrow with a mechanism that would address
15862 multiple assignments.
15863 (Expression::report118): Utility routine to report mismatches on
15866 (Unary::Report23): Report impossible type/operator combination
15869 (Unary::IsIncrementableNumber): Whether the type can be
15870 incremented or decremented with add.
15871 (Unary::ResolveOperator): Also allow enumerations to be bitwise
15873 (Unary::ResolveOperator): Implement ++, !, ~,
15875 (Invocation::Emit): Deal with new Emit convetion.
15877 * All Expression derivatives: Updated their Emit method to return
15878 whether they leave values on the stack or not.
15880 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
15881 stack for expressions that are statements.
15883 2001-09-20 Miguel de Icaza <miguel@ximian.com>
15885 * expression.cs (LValue): New interface. Must be implemented by
15887 (LocalVariableReference, ParameterReference, FieldExpr): Implement
15890 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
15891 interface for generating code, simplifies the code.
15893 2001-09-20 Ravi Pratap <ravi@ximian.com>
15895 * expression.cs (everywhere): Comment out return statements in ::Resolve
15896 methods to avoid the warnings.
15898 2001-09-20 Miguel de Icaza <miguel@ximian.com>
15900 * driver.cs (parse): Report error 2001 if we can not open the
15903 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
15906 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
15909 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
15910 otherwise nested blocks end up with the same index.
15912 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
15914 * expression.cs: Instead of having FIXMEs in the Resolve
15915 functions, throw exceptions so it is obvious that we are facing a
15918 * cs-parser.jay (invocation_expression): Pass Location information.
15920 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
15921 Use a basename for those routines because .NET does not like paths
15924 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
15927 2001-09-19 Miguel de Icaza <miguel@ximian.com>
15929 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
15930 are loading the correct data types (throws an exception if not).
15931 (TypeManager::InitCoreTypes): Use CoreLookupType
15933 * expression.cs (Unary::ResolveOperator): return the child
15934 expression for expressions which are just +expr.
15935 (Unary::ResolveOperator): Return negative literals for -LITERAL
15936 expressions (otherwise they are Unary {Literal}).
15937 (Invocation::Badness): Take into account `Implicit constant
15938 expression conversions'.
15940 * literal.cs (LongLiteral): Implement long literal class.
15941 (IntLiteral): export the `Value' of the intliteral.
15943 2001-09-19 Ravi Pratap <ravi@ximian.com>
15945 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
15947 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
15948 instead of 'Operator'
15950 * expression.cs (Binary::ResolveOperator): Update accordingly.
15951 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
15954 * cs-parser.jay (unary_expression): Update to use the new names.
15956 * gen-treedump.cs (GetUnary): Same here.
15958 * expression.cs (Unary::Resolve): Implement.
15959 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
15960 operators are found instead of making noise ;-)
15961 (Unary::ResolveOperator): New method to do precisely the same thing which
15962 Binary::ResolveOperator does for Binary expressions.
15963 (Unary.method, .Arguments): Add.
15964 (Unary::OperName): Implement.
15965 (Unary::ForceConversion): Copy and Paste !
15967 * class.cs (Operator::Define): Fix a small bug for the case when we have
15970 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
15971 for the inbuilt operators. Only overloading works for now ;-)
15973 2001-09-18 Miguel de Icaza <miguel@ximian.com>
15975 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
15976 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
15978 * expression.cs (This::Emit): Implement.
15979 (This::Resolve): Implement.
15980 (TypeOf:Resolve): Implement.
15981 (Expression::ResolveSimpleName): Add an implicit this to instance
15983 (MemberAccess::Resolve): Deal with Parameters and Fields.
15984 Bind instance variable to Field expressions.
15985 (FieldExpr::Instance): New field used to track the expression that
15986 represents the object instance.
15987 (FieldExpr::Resolve): Track potential errors from MemberLookup not
15989 (FieldExpr::Emit): Implement.
15991 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
15992 the last instruction contains a return opcode to avoid generating
15993 the last `ret' instruction (this generates correct code, and it is
15994 nice to pass the peverify output).
15996 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
15997 initializer for static and instance variables.
15998 (Constructor::Emit): Allow initializer to be null in the case of
15999 static constructors. Only emit initializer for instance
16002 (TypeContainer::FindMembers): Return a null array if there are no
16005 Also fix the code for the MemberTypes.Method branch, as it was not
16006 scanning that for operators (or tried to access null variables before).
16008 * assign.cs (Assign::Emit): Handle instance and static fields.
16012 * driver.cs: Stop compilation if there are parse errors.
16014 * cs-parser.jay (constructor_declaration): Provide default base
16015 initializer for non-static constructors.
16016 (constructor_declarator): Do not provide a default base
16017 initializers if none was specified.
16018 Catch the fact that constructors should not have parameters.
16020 * class.cs: Do not emit parent class initializers for static
16021 constructors, that should be flagged as an error.
16023 2001-09-18 Ravi Pratap <ravi@ximian.com>
16025 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
16026 Move back code into TypeContainer::Populate.
16028 2001-09-18 Ravi Pratap <ravi@ximian.com>
16030 * class.cs (TypeContainer::AddConstructor): Fix the check to
16031 compare against Name, not Basename.
16032 (Operator::OpType): Change Plus and Minus to Add and Subtract.
16034 * cs-parser.jay : Update accordingly.
16036 * class.cs (TypeContainer::FindMembers): For the case where we are searching
16037 for methods, don't forget to look into the operators too.
16038 (RegisterMethodBuilder): Helper method to take care of this for
16039 methods, constructors and operators.
16040 (Operator::Define): Completely revamp.
16041 (Operator.OperatorMethod, MethodName): New fields.
16042 (TypeContainer::Populate): Move the registering of builders into
16043 RegisterMethodBuilder.
16044 (Operator::Emit): Re-write.
16046 * expression.cs (Binary::Emit): Comment out code path to emit method
16047 invocation stuff for the case when we have a user defined operator. I am
16048 just not able to get it right !
16050 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16052 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
16055 (Expression::MemberLookup): Provide a version that allows to
16056 specify the MemberTypes and BindingFlags.
16058 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
16059 so it was not fetching variable information from outer blocks.
16061 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
16062 Beforefieldinit as it was buggy.
16064 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
16065 that Ravi put here.
16067 * class.cs (Constructor::Emit): Only emit if block is not null.
16068 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
16069 deal with this by semantically definining it as if the user had
16072 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
16073 constructors as we now "emit" them at a higher level.
16075 (TypeContainer::DefineDefaultConstructor): Used to define the
16076 default constructors if none was provided.
16078 (ConstructorInitializer): Add methods Resolve and Emit.
16080 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
16082 2001-09-17 Ravi Pratap <ravi@ximian.com>
16084 * class.cs (TypeContainer::EmitDefaultConstructor): Register
16085 the default constructor builder with our hashtable for methodbuilders
16088 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
16089 and argument_count is 0 in which case we have a match.
16090 (Binary::ResolveOperator): More null checking and miscellaneous coding
16093 2001-09-17 Ravi Pratap <ravi@ximian.com>
16095 * rootcontext.cs (IsNameSpace): Compare against null.
16097 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
16099 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
16100 and Unary::Operator.
16102 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
16105 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
16106 we have overloaded operators.
16107 (Binary::ResolveOperator): Implement the part which does the operator overload
16110 * class.cs (Operator::Emit): Implement.
16111 (TypeContainer::Emit): Emit the operators we have too.
16113 * expression.cs (Binary::Emit): Update to emit the appropriate code for
16114 the case when we have a user-defined operator.
16116 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16118 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
16120 2001-09-16 Ravi Pratap <ravi@ximian.com>
16122 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
16123 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
16124 (Constructor::Emit): Implement.
16125 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
16126 if we have no work to do.
16127 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
16130 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
16131 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
16133 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
16136 2001-09-15 Ravi Pratap <ravi@ximian.com>
16138 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
16140 (Tree::RecordNamespace): Method to do what the name says ;-)
16141 (Tree::Namespaces): Property to get at the namespaces hashtable.
16143 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
16146 * rootcontext.cs (IsNamespace): Fixed it :-)
16148 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16150 * class.cs (TypeContainer::FindMembers): Add support for
16152 (MethodCore): New class that encapsulates both the shared aspects
16153 of a Constructor and a Method.
16154 (Method, Constructor): Factored pieces into MethodCore.
16156 * driver.cs: Added --fatal which makes errors throw exceptions.
16157 Load System assembly as well as part of the standard library.
16159 * report.cs: Allow throwing exceptions on errors for debugging.
16161 * modifiers.cs: Do not use `parent', instead use the real type
16162 container to evaluate permission settings.
16164 * class.cs: Put Ravi's patch back in. He is right, and we will
16165 have to cope with the
16167 2001-09-14 Ravi Pratap <ravi@ximian.com>
16169 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
16170 FamORAssem, not FamANDAssem.
16172 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16174 * driver.cs: Added --parse option that only parses its input files
16177 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
16178 incorrect. IsTopLevel is not used to tell whether an object is
16179 root_types or not (that can be achieved by testing this ==
16180 root_types). But to see if this is a top-level *class* (not
16181 necessarly our "toplevel" container).
16183 2001-09-14 Ravi Pratap <ravi@ximian.com>
16185 * enum.cs (Enum::Define): Modify to call the Lookup method on the
16186 parent instead of a direct call to GetType.
16188 2001-09-14 Ravi Pratap <ravi@ximian.com>
16190 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
16191 Modifiers.TypeAttr. This should just be a call to that method.
16193 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
16194 object so that we can determine if we are top-level or not.
16196 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
16199 * enum.cs (Enum::Define): Ditto.
16201 * modifiers.cs (FieldAttr): Re-write.
16203 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
16204 (TypeContainer::HaveStaticConstructor): New property to provide access
16205 to precisely that info.
16207 * modifiers.cs (MethodAttr): Re-write.
16208 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
16210 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
16211 of top-level types as claimed.
16213 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16215 * expression.cs (MemberLookup): Fruitless attempt to lookup
16216 constructors. Maybe I need to emit default constructors? That
16217 might be it (currently .NET emits this for me automatically).
16218 (Invocation::OverloadResolve): Cope with Arguments == null.
16219 (Invocation::EmitArguments): new function, shared by the new
16220 constructor and us.
16221 (Invocation::Emit): Handle static and instance methods. Emit
16222 proper call instruction for virtual or non-virtual invocations.
16223 (New::Emit): Implement.
16224 (New::Resolve): Implement.
16225 (MemberAccess:Resolve): Implement.
16226 (MethodGroupExpr::InstanceExpression): used conforming to the spec
16227 to track instances.
16228 (FieldExpr::Resolve): Set type.
16230 * support.cs: Handle empty arguments.
16232 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
16233 SimpleLookup): Auxiliary routines to help parse a qualifier
16236 Update qualifier_identifier rule.
16238 * codegen.cs: Removed debugging messages.
16240 * class.cs: Make this a global thing, this acts just as a "key" to
16241 objects that we might have around.
16243 (Populate): Only initialize method_builders_to_methods once.
16245 * expression.cs (PropertyExpr): Initialize type from the
16248 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
16249 Resolve pattern. Attempt to implicitly convert value to boolean.
16252 * expression.cs: Set the type for the int32/int32 argument case.
16253 (Binary::ResolveOperator): Set the return type to boolean for
16254 comparission operators
16256 * typemanager.cs: Remove debugging print code.
16258 (Invocation::Resolve): resolve type.
16260 * class.cs: Allocate a MemberInfo of the correct size, as the code
16261 elsewhere depends on the test to reflect the correct contents.
16263 (Method::) Keep track of parameters, due to System.Reflection holes
16265 (TypeContainer::Populate): Keep track of MethodBuilders to Method
16268 (TypeContainer::FindMembers): Use ArrayList and then copy an array
16269 of the exact size and return that.
16271 (Class::LookupMethodByBuilder): New function that maps
16272 MethodBuilders to its methods. Required to locate the information
16273 on methods because System.Reflection bit us again.
16275 * support.cs: New file, contains an interface ParameterData and
16276 two implementations: ReflectionParameters and InternalParameters
16277 used to access Parameter information. We will need to grow this
16280 * expression.cs (Invocation::GetParameterData): implement a cache
16281 and a wrapper around the ParameterData creation for methods.
16282 (Invocation::OverloadResolve): Use new code.
16284 2001-09-13 Ravi Pratap <ravi@ximian.com>
16286 * class.cs (TypeContainer::EmitField): Remove and move into
16287 (Field::Define): here and modify accordingly.
16288 (Field.FieldBuilder): New member.
16289 (TypeContainer::Populate): Update accordingly.
16290 (TypeContainer::FindMembers): Implement.
16292 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16294 * statement.cs: (VariableInfo::VariableType): New field to be
16295 initialized with the full type once it is resolved.
16297 2001-09-12 Miguel de Icaza <miguel@ximian.com>
16299 * parameter.cs (GetParameterInfo): Use a type cache to compute
16300 things only once, and to reuse this information
16302 * expression.cs (LocalVariableReference::Emit): Implement.
16303 (OpcodeCast::Emit): fix.
16305 (ParameterReference::Resolve): Implement.
16306 (ParameterReference::Emit): Implement.
16308 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
16309 that are expressions need to stay as Expressions.
16311 * typemanager.cs (CSharpName): Returns the C# name of a type if
16314 * expression.cs (Expression::ConvertImplicit): New function that
16315 implements implicit type conversions.
16317 (Expression::ImplicitReferenceConversion): Implements implicit
16318 reference conversions.
16320 (EmptyCast): New type for transparent casts.
16322 (OpcodeCast): New type for casts of types that are performed with
16323 a sequence of bytecodes.
16325 (BoxedCast): New type used for casting value types into reference
16326 types. Emits a box opcode.
16328 (Binary::DoNumericPromotions): Implements numeric promotions of
16329 and computation of the Binary::Type.
16331 (Binary::EmitBranchable): Optimization.
16333 (Binary::Emit): Implement code emission for expressions.
16335 * typemanager.cs (TypeManager): Added two new core types: sbyte
16338 2001-09-12 Ravi Pratap <ravi@ximian.com>
16340 * class.cs (TypeContainer::FindMembers): Method which does exactly
16341 what Type.FindMembers does, only we don't have to use reflection. No
16342 implementation yet.
16344 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
16345 typecontainer objects as we need to get at them.
16346 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
16348 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
16349 typecontainer object.
16351 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
16352 of just a Report object.
16354 2001-09-11 Ravi Pratap <ravi@ximian.com>
16356 * class.cs (Event::Define): Go back to using the prefixes "add_" and
16358 (TypeContainer::Populate): Now define the delegates of the type too.
16359 (TypeContainer.Delegates): Property to access the list of delegates defined
16362 * delegates.cs (Delegate::Define): Implement partially.
16364 * modifiers.cs (TypeAttr): Handle more flags.
16366 2001-09-11 Ravi Pratap <ravi@ximian.com>
16368 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
16370 (Operator::Define): Re-write logic to get types by using the LookupType method
16371 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
16372 (Indexer::Define): Ditto.
16373 (Event::Define): Ditto.
16374 (Property::Define): Ditto.
16376 2001-09-10 Ravi Pratap <ravi@ximian.com>
16378 * class.cs (TypeContainer::Populate): Now define operators too.
16379 (TypeContainer.Operators): New property to access the list of operators
16381 (Operator.OperatorMethodBuilder): New member to hold the method builder
16382 for the operator we are defining.
16383 (Operator::Define): Implement.
16385 2001-09-10 Ravi Pratap <ravi@ximian.com>
16387 * class.cs (Event::Define): Make the prefixes of the accessor methods
16388 addOn_ and removeOn_
16390 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
16391 of the location being passed in too. Ideally, this should go later since all
16392 error reporting should be done through the Report object.
16394 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
16395 (Populate): Iterate thru the indexers we have and define them too.
16396 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
16397 for the get and set accessors.
16398 (Indexer::Define): Implement.
16400 2001-09-09 Miguel de Icaza <miguel@ximian.com>
16402 * expression.cs (Binary::Resolve): Beginning of it. I scratched
16403 my previous implementation, did not work.
16405 * typemanager.cs: Add a couple of missing types (the longs).
16407 * literal.cs: Use TypeManager.bool_type instead of getting it.
16409 * expression.cs (EventExpr): New kind of expressions.
16410 (Expressio::ExprClassFromMemberInfo): finish
16412 2001-09-08 Miguel de Icaza <miguel@ximian.com>
16414 * assign.cs: Emit stores to static fields differently.
16416 2001-09-08 Ravi Pratap <ravi@ximian.com>
16418 * Merge in changes and adjust code to tackle conflicts. Backed out my
16419 code in Assign::Resolve ;-)
16421 2001-09-08 Ravi Pratap <ravi@ximian.com>
16423 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
16424 instead Report.Error and also pass in the location.
16425 (CSharpParser::Lexer): New readonly property to return the reference
16426 to the Tokenizer object.
16427 (declare_local_variables): Use Report.Error with location instead of plain
16431 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
16432 (Operator.CheckBinaryOperator): Ditto.
16434 * cs-parser.jay (operator_declarator): Update accordingly.
16436 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
16437 (CheckBinaryOperator): Same here.
16439 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
16440 on the name without any prefixes of namespace names etc. This is because we
16441 already might have something already fully qualified like
16442 'System.Console.WriteLine'
16444 * assign.cs (Resolve): Begin implementation. Stuck ;-)
16446 2001-09-07 Ravi Pratap <ravi@ximian.com>
16448 * cs-tokenizer.cs (location): Return a string which also contains
16451 * expression.cs (ElementAccess): New class for expressions of the
16452 type 'element access.'
16453 (BaseAccess): New class for expressions of the type 'base access.'
16454 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
16457 * cs-parser.jay (element_access): Implement action.
16458 (base_access): Implement actions.
16459 (checked_expression, unchecked_expression): Implement.
16461 * cs-parser.jay (local_variable_type): Correct and implement.
16462 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
16464 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
16466 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
16467 name and the specifiers.
16469 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
16471 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
16472 making them all public ;-)
16474 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
16477 2001-09-07 Miguel de Icaza <miguel@ximian.com>
16479 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
16481 (FieldExpr, PropertyExprs): New resolved expressions.
16482 (SimpleName::MemberStaticCheck): Perform static checks for access
16483 to non-static fields on static methods. Maybe this should be
16484 generalized for MemberAccesses.
16485 (SimpleName::ResolveSimpleName): More work on simple name
16488 * cs-parser.jay (primary_expression/qualified_identifier): track
16489 the parameter index.
16491 * codegen.cs (CodeGen::Save): Catch save exception, report error.
16492 (EmitContext::EmitBoolExpression): Chain to expression generation
16493 instead of temporary hack.
16494 (::EmitStatementExpression): Put generic expression code generation.
16496 * assign.cs (Assign::Emit): Implement variable assignments to
16497 local variables, parameters and fields.
16499 2001-09-06 Miguel de Icaza <miguel@ximian.com>
16501 * statement.cs (Block::GetVariableInfo): New method, returns the
16502 VariableInfo for a variable name in a block.
16503 (Block::GetVariableType): Implement in terms of GetVariableInfo
16505 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
16506 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
16508 2001-09-06 Ravi Pratap <ravi@ximian.com>
16510 * cs-parser.jay (operator_declaration): Continue on my quest : update
16511 to take attributes argument.
16512 (event_declaration): Ditto.
16513 (enum_declaration): Ditto.
16514 (indexer_declaration): Ditto.
16516 * class.cs (Operator::Operator): Update constructor accordingly.
16517 (Event::Event): Ditto.
16519 * delegate.cs (Delegate::Delegate): Same here.
16521 * enum.cs (Enum::Enum): Same here.
16523 2001-09-05 Ravi Pratap <ravi@ximian.com>
16525 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
16527 * ../tests/cs0658.cs : New file to demonstrate error 0658.
16529 * attribute.cs (Attributes): New class to encapsulate all attributes which were
16530 being passed around as an arraylist.
16531 (Attributes::AddAttribute): Method to add attribute sections.
16533 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
16534 (struct_declaration): Update accordingly.
16535 (constant_declaration): Update.
16536 (field_declaration): Update.
16537 (method_header): Update.
16538 (fixed_parameter): Update.
16539 (parameter_array): Ditto.
16540 (property_declaration): Ditto.
16541 (destructor_declaration): Ditto.
16543 * class.cs (Struct::Struct): Update constructors accordingly.
16544 (Class::Class): Ditto.
16545 (Field::Field): Ditto.
16546 (Method::Method): Ditto.
16547 (Property::Property): Ditto.
16548 (TypeContainer::OptAttribute): update property's return type.
16550 * interface.cs (Interface.opt_attributes): New member.
16551 (Interface::Interface): Update to take the extra Attributes argument.
16553 * parameter.cs (Parameter::Parameter): Ditto.
16555 * constant.cs (Constant::Constant): Ditto.
16557 * interface.cs (InterfaceMemberBase): New OptAttributes field.
16558 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
16559 the attributes as a parameter.
16560 (InterfaceProperty): Update constructor call.
16561 (InterfaceEvent): Ditto.
16562 (InterfaceMethod): Ditto.
16563 (InterfaceIndexer): Ditto.
16565 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
16566 pass the attributes too.
16567 (interface_event_declaration): Ditto.
16568 (interface_property_declaration): Ditto.
16569 (interface_method_declaration): Ditto.
16570 (interface_declaration): Ditto.
16572 2001-09-05 Miguel de Icaza <miguel@ximian.com>
16574 * class.cs (Method::Define): Track the "static Main" definition to
16575 create an entry point.
16577 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
16578 EntryPoint if we find it.
16580 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
16581 (EmitContext::ig): Make this variable public.
16583 * driver.cs: Make the default output file be the first file name
16584 with the .exe extension.
16586 Detect empty compilations
16588 Handle various kinds of output targets. Handle --target and
16589 rename -t to --dumper.
16591 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
16592 methods inherited from Expression return now an Expression. This
16593 will is used during the tree rewriting as we resolve them during
16596 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
16597 the spec. Missing entirely is the information about
16598 accessability of elements of it.
16600 (Expression::ExprClassFromMemberInfo): New constructor for
16601 Expressions that creates a fully initialized Expression based on
16602 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
16605 (Invocation::Resolve): Begin implementing resolution of invocations.
16607 * literal.cs (StringLiteral): Implement Emit.
16609 2001-09-05 Ravi Pratap <ravi@ximian.com>
16611 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
16614 2001-09-04 Ravi Pratap <ravi@ximian.com>
16616 * cs-parser.jay (attribute_arguments): Implement actions.
16617 (attribute): Fix bug in production. Implement action.
16618 (attribute_list): Implement.
16619 (attribute_target): Implement.
16620 (attribute_target_specifier, opt_target_specifier): Implement
16621 (CheckAttributeTarget): New method to check if the attribute target
16623 (attribute_section): Implement.
16624 (opt_attributes): Implement.
16626 * attribute.cs : New file to handle attributes.
16627 (Attribute): Class to hold attribute info.
16629 * cs-parser.jay (opt_attribute_target_specifier): Remove production
16630 (attribute_section): Modify production to use 2 different rules to
16631 achieve the same thing. 1 s/r conflict down !
16632 Clean out commented, useless, non-reducing dimension_separator rules.
16634 * class.cs (TypeContainer.attributes): New member to hold list
16635 of attributes for a type.
16636 (Struct::Struct): Modify to take one more argument, the attribute list.
16637 (Class::Class): Ditto.
16638 (Field::Field): Ditto.
16639 (Method::Method): Ditto.
16640 (Property::Property): Ditto.
16642 * cs-parser.jay (struct_declaration): Update constructor call to
16643 pass in the attributes too.
16644 (class_declaration): Ditto.
16645 (constant_declaration): Ditto.
16646 (field_declaration): Ditto.
16647 (method_header): Ditto.
16648 (fixed_parameter): Ditto.
16649 (parameter_array): Ditto.
16650 (property_declaration): Ditto.
16652 * constant.cs (Constant::Constant): Update constructor similarly.
16653 Use System.Collections.
16655 * parameter.cs (Parameter::Parameter): Update as above.
16657 2001-09-02 Ravi Pratap <ravi@ximian.com>
16659 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
16660 (TypeContainer.delegates): New member to hold list of delegates.
16662 * cs-parser.jay (delegate_declaration): Implement the action correctly
16663 this time as I seem to be on crack ;-)
16665 2001-09-02 Miguel de Icaza <miguel@ximian.com>
16667 * rootcontext.cs (RootContext::IsNamespace): new function, used to
16668 tell whether an identifier represents a namespace.
16670 * expression.cs (NamespaceExpr): A namespace expression, used only
16671 temporarly during expression resolution.
16672 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
16673 utility functions to resolve names on expressions.
16675 2001-09-01 Miguel de Icaza <miguel@ximian.com>
16677 * codegen.cs: Add hook for StatementExpressions.
16679 * class.cs: Fix inverted test for static flag in methods.
16681 2001-09-02 Ravi Pratap <ravi@ximian.com>
16683 * class.cs (Operator::CheckUnaryOperator): Correct error number used
16684 to make it coincide with MS' number.
16685 (Operator::CheckBinaryOperator): Ditto.
16687 * ../errors/errors.txt : Remove error numbers added earlier.
16689 * ../errors/cs1019.cs : Test case for error # 1019
16691 * ../errros/cs1020.cs : Test case for error # 1020
16693 * cs-parser.jay : Clean out commented cruft.
16694 (dimension_separators, dimension_separator): Comment out. Ostensibly not
16695 used anywhere - non-reducing rule.
16696 (namespace_declarations): Non-reducing rule - comment out.
16698 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
16699 with TypeContainer::AddEnum.
16701 * delegate.cs : New file for delegate handling classes.
16702 (Delegate): Class for declaring delegates.
16704 * makefile : Update.
16706 * cs-parser.jay (delegate_declaration): Implement.
16708 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
16710 * class.cs (Event::Define): Implement.
16711 (Event.EventBuilder): New member.
16713 * class.cs (TypeContainer::Populate): Update to define all enums and events
16715 (Events): New property for the events arraylist we hold. Shouldn't we move to using
16716 readonly fields for all these cases ?
16718 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
16720 * class.cs (Property): Revamp to use the convention of making fields readonly.
16721 Accordingly modify code elsewhere.
16723 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
16724 the Define method of the Property class.
16726 * class.cs : Clean up applied patch and update references to variables etc. Fix
16728 (TypeContainer::Populate): Update to define all the properties we have. Also
16729 define all enumerations.
16731 * enum.cs (Define): Implement.
16733 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
16735 * cs-parser.jay (overloadable_operator): The semantic value is an
16736 enum of the Operator class.
16737 (operator_declarator): Implement actions.
16738 (operator_declaration): Implement.
16740 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
16741 validity of definitions.
16742 (Operator::CheckBinaryOperator): Static method to check for binary operators
16743 (TypeContainer::AddOperator): New method to add an operator to a type.
16745 * cs-parser.jay (indexer_declaration): Added line to actually call the
16746 AddIndexer method so it gets added ;-)
16748 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
16749 already taken care of by the MS compiler ?
16751 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
16753 * class.cs (Operator): New class for operator declarations.
16754 (Operator::OpType): Enum for the various operators.
16756 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
16758 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
16759 ostensibly handle this in semantic analysis.
16761 * cs-parser.jay (general_catch_clause): Comment out
16762 (specific_catch_clauses, specific_catch_clause): Ditto.
16763 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
16764 (catch_args, opt_catch_args): New productions.
16765 (catch_clause): Rewrite to use the new productions above
16766 (catch_clauses): Modify accordingly.
16767 (opt_catch_clauses): New production to use in try_statement
16768 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
16769 and re-write the code in the actions to extract the specific and
16770 general catch clauses by being a little smart ;-)
16772 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
16773 Hooray, try and catch statements parse fine !
16775 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
16777 * statement.cs (Block::GetVariableType): Fix logic to extract the type
16778 string from the hashtable of variables.
16780 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
16781 I end up making that mistake ;-)
16782 (catch_clauses): Fixed gross error which made Key and Value of the
16783 DictionaryEntry the same : $1 !!
16785 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
16787 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
16789 * cs-parser.jay (event_declaration): Correct to remove the semicolon
16790 when the add and remove accessors are specified.
16792 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
16794 * cs-parser.jay (IndexerDeclaration): New helper class to hold
16795 information about indexer_declarator.
16796 (indexer_declarator): Implement actions.
16797 (parsing_indexer): New local boolean used to keep track of whether
16798 we are parsing indexers or properties. This is necessary because
16799 implicit_parameters come into picture even for the get accessor in the
16800 case of an indexer.
16801 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
16803 * class.cs (Indexer): New class for indexer declarations.
16804 (TypeContainer::AddIndexer): New method to add an indexer to a type.
16805 (TypeContainer::indexers): New member to hold list of indexers for the
16808 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
16810 * cs-parser.jay (add_accessor_declaration): Implement action.
16811 (remove_accessor_declaration): Implement action.
16812 (event_accessors_declaration): Implement
16813 (variable_declarators): swap statements for first rule - trivial.
16815 * class.cs (Event): New class to hold information about event
16817 (TypeContainer::AddEvent): New method to add an event to a type
16818 (TypeContainer::events): New member to hold list of events.
16820 * cs-parser.jay (event_declaration): Implement actions.
16822 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
16824 * cs-parser.jay (dim_separators): Implement. Make it a string
16825 concatenating all the commas together, just as they appear.
16826 (opt_dim_separators): Modify accordingly
16827 (rank_specifiers): Update accordingly. Basically do the same
16828 thing - instead, collect the brackets here.
16829 (opt_rank_sepcifiers): Modify accordingly.
16830 (array_type): Modify to actually return the complete type string
16831 instead of ignoring the rank_specifiers.
16832 (expression_list): Implement to collect the expressions
16833 (variable_initializer): Implement. We make it a list of expressions
16834 essentially so that we can handle the array_initializer case neatly too.
16835 (variable_initializer_list): Implement.
16836 (array_initializer): Make it a list of variable_initializers
16837 (opt_array_initializer): Modify accordingly.
16839 * expression.cs (New::NType): Add enumeration to help us
16840 keep track of whether we have an object/delegate creation
16841 or an array creation.
16842 (New:NewType, New::Rank, New::Indices, New::Initializers): New
16843 members to hold data about array creation.
16844 (New:New): Modify to update NewType
16845 (New:New): New Overloaded contructor for the array creation
16848 * cs-parser.jay (array_creation_expression): Implement to call
16849 the overloaded New constructor.
16851 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
16853 * class.cs (TypeContainer::Constructors): Return member
16854 constructors instead of returning null.
16856 2001-08-26 Miguel de Icaza <miguel@ximian.com>
16858 * typemanager.cs (InitCoreTypes): Initialize the various core
16859 types after we have populated the type manager with the user
16860 defined types (this distinction will be important later while
16861 compiling corlib.dll)
16863 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
16864 on Expression Classification. Now all expressions have a method
16865 `Resolve' and a method `Emit'.
16867 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
16868 generation from working. Also add some temporary debugging
16871 2001-08-24 Miguel de Icaza <miguel@ximian.com>
16873 * codegen.cs: Lots of code generation pieces. This is only the
16874 beginning, will continue tomorrow with more touches of polish. We
16875 handle the fundamentals of if, while, do, for, return. Others are
16876 trickier and I need to start working on invocations soon.
16878 * gen-treedump.cs: Bug fix, use s.Increment here instead of
16881 * codegen.cs (EmitContext): New struct, used during code
16882 emission to keep a context. Most of the code generation will be
16885 * cs-parser.jay: Add embedded blocks to the list of statements of
16886 this block. So code generation proceeds in a top down fashion.
16888 2001-08-23 Miguel de Icaza <miguel@ximian.com>
16890 * statement.cs: Add support for multiple child blocks.
16892 2001-08-22 Miguel de Icaza <miguel@ximian.com>
16894 * codegen.cs (EmitCode): New function, will emit the code for a
16895 Block of code given a TypeContainer and its ILGenerator.
16897 * statement.cs (Block): Standard public readonly optimization.
16898 (Block::Block constructors): Link children.
16899 (Block::Child): Child Linker.
16900 (Block::EmitVariables): Emits IL variable declarations.
16902 * class.cs: Drop support for MethodGroups here, delay until
16904 (Method::): Applied the same simplification that I did before, and
16905 move from Properties to public readonly fields.
16906 (Method::ParameterTypes): Returns the parameter types for the
16907 function, and implements a cache that will be useful later when I
16908 do error checking and the semantic analysis on the methods is
16910 (Constructor::GetCallingConvention): Renamed from CallingConvetion
16911 and made a method, optional argument tells whether this is a class
16912 or a structure to apply the `has-this' bit.
16913 (Method::GetCallingConvention): Implement, returns the calling
16915 (Method::Define): Defines the type, a second pass is performed
16916 later to populate the methods.
16918 (Constructor::ParameterTypes): implement a cache similar to the
16919 one on Method::ParameterTypes, useful later when we do semantic
16922 (TypeContainer::EmitMethod): New method. Emits methods.
16924 * expression.cs: Removed MethodGroup class from here.
16926 * parameter.cs (Parameters::GetCallingConvention): new method.
16928 2001-08-21 Miguel de Icaza <miguel@ximian.com>
16930 * class.cs (TypeContainer::Populate): Drop RootContext from the
16933 (Constructor::CallingConvention): Returns the calling convention.
16934 (Constructor::ParameterTypes): Returns the constructor parameter
16937 (TypeContainer::AddConstructor): Keep track of default constructor
16938 and the default static constructor.
16940 (Constructor::) Another class that starts using `public readonly'
16941 instead of properties.
16943 (Constructor::IsDefault): Whether this is a default constructor.
16945 (Field::) use readonly public fields instead of properties also.
16947 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
16948 track of static constructors; If none is used, turn on
16949 BeforeFieldInit in the TypeAttributes.
16951 * cs-parser.jay (opt_argument_list): now the return can be null
16952 for the cases where there are no arguments.
16954 (constructor_declarator): If there is no implicit `base' or
16955 `this', then invoke the default parent constructor.
16957 * modifiers.cs (MethodAttr): New static function maps a set of
16958 modifiers flags into a MethodAttributes enum
16959 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
16960 MethodAttr, TypeAttr to represent the various mappings where the
16961 modifiers are used.
16962 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
16964 2001-08-19 Miguel de Icaza <miguel@ximian.com>
16966 * parameter.cs (GetParameterInfo): Fix bug where there would be no
16969 * interface.cs (PopulateIndexer): Implemented the code generator
16970 for interface indexers.
16972 2001-08-17 Miguel de Icaza <miguel@ximian.com>
16974 * interface.cs (InterfaceMemberBase): Now we track the new status
16977 (PopulateProperty): Implement property population. Woohoo! Got
16978 Methods and Properties going today.
16980 Removed all the properties for interfaces, and replaced them with
16981 `public readonly' fields.
16983 2001-08-16 Miguel de Icaza <miguel@ximian.com>
16985 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
16986 initialize their hashtables/arraylists only when they are needed
16987 instead of doing this always.
16989 * parameter.cs: Handle refs and out parameters.
16991 * cs-parser.jay: Use an ArrayList to construct the arguments
16992 instead of the ParameterCollection, and then cast that to a
16995 * parameter.cs: Drop the use of ParameterCollection and use
16996 instead arrays of Parameters.
16998 (GetParameterInfo): Use the Type, not the Name when resolving
17001 2001-08-13 Miguel de Icaza <miguel@ximian.com>
17003 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
17004 and instead use public readonly fields.
17006 * class.cs: Put back walking code for type containers.
17008 2001-08-11 Miguel de Icaza <miguel@ximian.com>
17010 * class.cs (MakeConstant): Code to define constants.
17012 * rootcontext.cs (LookupType): New function. Used to locate types
17015 2001-08-08 Miguel de Icaza <miguel@ximian.com>
17017 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
17018 this System.Reflection code is. Kudos to Microsoft
17020 * typemanager.cs: Implement a type cache and avoid loading all
17021 types at boot time. Wrap in LookupType the internals. This made
17022 the compiler so much faster. Wow. I rule!
17024 * driver.cs: Make sure we always load mscorlib first (for
17025 debugging purposes, nothing really important).
17027 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
17028 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
17030 * rootcontext.cs: Lookup types on their namespace; Lookup types
17031 on namespaces that have been imported using the `using' keyword.
17033 * class.cs (TypeContainer::TypeAttr): Virtualize.
17034 (Class::TypeAttr): Return attributes suitable for this bad boy.
17035 (Struct::TypeAttr): ditto.
17036 Handle nested classes.
17037 (TypeContainer::) Remove all the type visiting code, it is now
17038 replaced with the rootcontext.cs code
17040 * rootcontext.cs (GetClassBases): Added support for structs.
17042 2001-08-06 Miguel de Icaza <miguel@ximian.com>
17044 * interface.cs, statement.cs, class.cs, parameter.cs,
17045 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
17046 Drop use of TypeRefs, and use strings instead.
17048 2001-08-04 Miguel de Icaza <miguel@ximian.com>
17052 * class.cs (Struct::Struct): set the SEALED flags after
17053 checking the modifiers.
17054 (TypeContainer::TypeAttr): new property, returns the
17055 TypeAttributes for a class.
17057 * cs-parser.jay (type_list): Oops, list production was creating a
17058 new list of base types.
17060 * rootcontext.cs (StdLib): New property.
17061 (GetInterfaceTypeByName): returns an interface by type name, and
17062 encapsulates error handling here.
17063 (GetInterfaces): simplified.
17064 (ResolveTree): Encapsulated all the tree resolution here.
17065 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
17068 * driver.cs: Add support for --nostdlib, to avoid loading the
17069 default assemblies.
17070 (Main): Do not put tree resolution here.
17072 * rootcontext.cs: Beginning of the class resolution.
17074 2001-08-03 Miguel de Icaza <miguel@ximian.com>
17076 * rootcontext.cs: Provide better error reporting.
17078 * cs-parser.jay (interface_base): set our $$ to be interfaces.
17080 * rootcontext.cs (CreateInterface): Handle the case where there
17081 are no parent interfaces.
17083 (CloseTypes): Routine to flush types at the end.
17084 (CreateInterface): Track types.
17085 (GetInterfaces): Returns an array of Types from the list of
17086 defined interfaces.
17088 * typemanager.c (AddUserType): Mechanism to track user types (puts
17089 the type on the global type hash, and allows us to close it at the
17092 2001-08-02 Miguel de Icaza <miguel@ximian.com>
17094 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
17095 RecordInterface instead.
17097 * cs-parser.jay: Updated to reflect changes above.
17099 * decl.cs (Definition): Keep track of the TypeBuilder type that
17100 represents this type here. Not sure we will use it in the long
17101 run, but wont hurt for now.
17103 * driver.cs: Smaller changes to accomodate the new code.
17105 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
17108 * rootcontext.cs (CreateInterface): New method, used to create
17109 the System.TypeBuilder type for interfaces.
17110 (ResolveInterfaces): new entry point to resolve the interface
17112 (CodeGen): Property, used to keep track of the code generator.
17114 2001-07-26 Miguel de Icaza <miguel@ximian.com>
17116 * cs-parser.jay: Add a second production for delegate_declaration
17119 (enum_body): Put an opt_comma here instead of putting it on
17120 enum_body or enum_member_declarations so we can handle trailing
17121 commas on enumeration members. Gets rid of a shift/reduce.
17123 (type_list): Need a COMMA in the middle.
17125 (indexer_declaration): Tell tokenizer to recognize get/set
17127 * Remove old targets.
17129 * Re-add the parser target.
17131 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17133 * cs-parser.jay: Add precendence rules for a number of operators
17134 ot reduce the number of shift/reduce conflicts in the grammar.
17136 2001-07-17 Miguel de Icaza <miguel@ximian.com>
17138 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
17141 Get rid of old crufty code.
17143 * rootcontext.cs: Use this to keep track of the parsed
17144 representation and the defined types available to the program.
17146 * gen-treedump.cs: adjust for new convention.
17148 * type.cs: Split out the type manager, and the assembly builder
17151 * typemanager.cs: the type manager will live here now.
17153 * cil-codegen.cs: And the code generator here.
17155 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
17157 * makefile: Fixed up for easy making.
17159 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17161 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
17164 (unary_expression): Expand pre_increment_expression and
17165 post_decrement_expression to reduce a shift/reduce.
17167 2001-07-11 Simon Cozens
17169 * cs-tokenizer.cs: Hex numbers should begin with a 0.
17171 Improve allow_keyword_as_indent name.
17173 2001-06-19 Miguel de Icaza <miguel@ximian.com>
17175 * Adjustments for Beta2.
17177 2001-06-13 Miguel de Icaza <miguel@ximian.com>
17179 * decl.cs: Added `Define' abstract method.
17180 (InTransit): new property, used to catch recursive definitions.
17182 * interface.cs: Implement `Define'.
17184 * modifiers.cs: Map Modifiers.constants to
17185 System.Reflection.TypeAttribute flags.
17187 * class.cs: Keep track of types and user-defined types.
17188 (BuilderInit): New method for creating an assembly
17189 (ResolveType): New function to launch the resolution process, only
17190 used by interfaces for now.
17192 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
17193 that are inserted into the name space.
17195 2001-06-08 Miguel de Icaza <miguel@ximian.com>
17197 * ARGH. I have screwed up my tree so many times due to the use of
17198 rsync rather than using CVS. Going to fix this at once.
17200 * driver.cs: Objetify driver. Load assemblies, use assemblies to
17203 2001-06-07 Miguel de Icaza <miguel@ximian.com>
17205 * Experiment successful: Use System.Type rather that our own
17208 2001-05-25 Miguel de Icaza <miguel@ximian.com>
17210 * cs-parser.jay: Removed nsAliases from here.
17212 Use new namespaces, handle `using XXX;'
17214 * namespace.cs: Reimplemented namespace handling, use a recursive
17215 definition of the class. Now we can keep track of using clauses
17216 and catch invalid using clauses.
17218 2001-05-24 Miguel de Icaza <miguel@ximian.com>
17220 * gen-treedump.cs: Adapted for all the renaming.
17222 * expression.cs (Expression): this class now has a Type property
17223 which returns an expression Type.
17225 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
17226 `Type', as this has a different meaning now in the base
17228 2001-05-22 Miguel de Icaza <miguel@ximian.com>
17230 * interface.cs, class.cs: Removed from all the sources the
17231 references to signature computation, as we can not do method
17232 signature computation during the parsing time, as we are not
17233 trying to solve at that point distinguishing:
17237 void a (NS.Blah x) {}
17240 Which depending on the context might be valid or not, as we do not
17241 know if Blah is the same thing as NS.Blah at that point.
17243 * Redid everything so the code uses TypeRefs now instead of
17244 Types. TypeRefs are just temporary type placeholders, that need
17245 to be resolved. They initially have a pointer to a string and the
17246 current scope in which they are used. This is used later by the
17247 compiler to resolve the reference to an actual Type.
17249 * DeclSpace is no longer a CIR.Type, and neither are
17250 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
17251 are all DeclSpaces, but no Types.
17253 * type.cs (TypeRefManager): This implements the TypeRef manager,
17254 which keeps track of all the types that need to be resolved after
17255 the parsing has finished.
17257 2001-05-13 Miguel de Icaza <miguel@ximian.com>
17259 * ARGH. We are going to have to store `foreach' as a class rather
17260 than resolving it, as we need to verify error 1579 after name
17261 resolution. *OR* we could keep a flag that says `This request to
17262 IEnumerator comes from a foreach statement' which we can then use
17263 to generate the error.
17265 2001-05-10 Miguel de Icaza <miguel@ximian.com>
17267 * class.cs (TypeContainer.AddMethod): we now add methods to the
17268 MethodGroup instead of the method hashtable.
17270 * expression.cs: Add MethodGroup abstraction, which gets us one
17271 step closer to the specification in the way we handle method
17274 * cs-parser.jay (primary_expression): qualified_identifier now
17275 tried to match up an identifier to a local variable reference or
17276 to a parameter reference.
17278 current_local_parameters is now a parser global variable that
17279 points to the current parameters for the block, used during name
17282 (property_declaration): Now creates an implicit `value' argument to
17285 2001-05-09 Miguel de Icaza <miguel@ximian.com>
17287 * parameter.cs: Do not use `param' arguments as part of the
17288 signature, per the spec.
17290 2001-05-08 Miguel de Icaza <miguel@ximian.com>
17292 * decl.cs: Base class for classes, structs and interfaces. This
17293 is the "Declaration Space"
17295 * cs-parser.jay: Use CheckDef for checking declaration errors
17296 instead of having one on each function.
17298 * class.cs: Factor out some code for handling error handling in
17299 accordance to the "Declarations" section in the "Basic Concepts"
17300 chapter in the ECMA C# spec.
17302 * interface.cs: Make all interface member classes derive from
17303 InterfaceMemberBase.
17305 2001-05-07 Miguel de Icaza <miguel@ximian.com>
17307 * Many things: all interfaces are parsed and generated in
17308 gen-treedump. Support for member variables, constructors,
17309 destructors, properties, constants is there.
17311 Beginning of the IL backend, but very little done, just there for
17314 2001-04-29 Miguel de Icaza <miguel@ximian.com>
17316 * cs-parser.jay: Fix labeled statement.
17318 * cs-tokenizer.cs (escape): Escape " and ' always.
17319 ref_line, ref_name: keep track of the line/filename as instructed
17320 by #line by the compiler.
17323 2001-04-27 Miguel de Icaza <miguel@ximian.com>
17325 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
17326 to match the values in System.CodeDOM.
17328 Divid renamed to Divide.
17330 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
17332 (Statements.set): remove.
17334 * System.CodeDOM/CodeCatchClause.cs: always have a valid
17337 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
17338 falseStatements always have valid values.
17340 * cs-parser.jay: Use System.CodeDOM now.