1 2005-02-15 Raja R Harinath <rharinath@novell.com>
4 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
5 'ignore_cs0104' parameter. Pass it to ...
6 (NamespaceEntry.Lookup): ... this.
7 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
8 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
9 (TypeLookupExpression.DoResolveAsTypeStep): Update.
10 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
11 Update. Request that cs0104 errors be ignored.
12 (ComposedCast.ResolveAsTypeStep): Update.
14 2005-02-14 Raja R Harinath <rharinath@novell.com>
17 * expression.cs (Invocation.BetterFunction): Remove support for
18 comparing virtual functions and their overrides.
19 (Invocation.IsOverride): New.
20 (Invocation.OverloadResolve): Don't consider 'override' functions
21 during candidate selection. Store them in a lookaside list.
22 If the selected method is a 'virtual' function, use the list to
23 find any overrides that are closer to the LHS type.
25 2005-02-14 Marek Safar <marek.safar@seznam.cz>
27 * expression.cs (New.DoResolve): Add complex core type reduction.
28 (New.Constantify): Converts complex core type syntax like 'new int ()'
31 2005-02-14 Raja R Harinath <rharinath@novell.com>
33 * decl.cs (EntryType.EntryType): New constructor to create an
34 updated copy of a cache entry.
35 (MemberCache.AddMethods): Use it.
36 (MemberCache.ClearDeclaredOnly): Remove.
37 (MemberCache.MemberCache): Update.
39 2005-02-11 Miguel de Icaza <miguel@novell.com>
41 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
42 variable. This one is represents the actual low-level declaration
43 of the method, as opposed to the semantic level `IsStatic'.
45 An anonymous method which is hosted into a static method might be
46 actually an instance method. IsStatic would reflect the
47 container, while MethodIsStatic represents the actual code
50 * expression.cs (ParameterReference): Use the new MethodIsStatic
53 * anonymous.cs (AnonymousMethod.Compatible): Pass the
54 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
55 set on the current EmitContext.
57 * expression.cs (Cast): Overload DoResolveLValue so we can pass
58 resolve our casted expression as an LValue. This triggers the
59 proper LValue processing that is later required by Assign.
63 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
65 2005-02-11 Marek Safar <marek.safar@seznam.cz>
67 C# 2.0 Fixed buffer implementation
69 * anonymous.cs: Update after RegisterHelperClass renaming.
71 * attribute.cs (AttributeTester.fixed_buffer_cache):
72 Cache of external fixed buffers.
73 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
74 implementation if field is fixed buffer else null.
77 (TypeContainer.AddField): Accept FieldMember instead of Field.
78 (FieldBase.IsFieldClsCompliant): Extracted code from
79 VerifyClsCompliance descendant customization.
80 (FixedField): New class handles fixed buffer fields.
81 (FixedFieldExternal): Keeps information about imported fixed
83 (IFixedField): Make access to internal or external fixed buffer
86 * cs-parser.jay: Add fixed buffer parsing.
88 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
91 * expression.cs (Indirection): Extended implementation to accept
93 (PointerArithmetic.Emit): Get element from fixed buffer as well.
94 (ElementAccess.MakePointerAccess): Get type as parameter.
95 (DoResolve): Add fixed buffer field expression conversion.
96 (DoResolveLValue): Ditto.
97 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
98 (ArrayPtr): Derives from FixedBufferPtr.
99 (ArrayPtr.Emit): Add extra emit for array elements.
101 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
103 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
104 for compiler generated types.
105 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
107 * statement.cs (Fixed): Refactored to be easier add fixed buffer
108 and consume less memory.
109 (Fixed.Resolve): Add fixed buffer case.
111 * typemanager.cs (compiler_generated_attr_ctor,
112 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
113 (HasElementType): Add our own implementation to work on every
116 2005-02-11 Miguel de Icaza <miguel@novell.com>
118 * anonymous.cs (CaptureContext): Track whether `this' has been
121 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
122 only captured `this' if it was implicitly done (instance
123 methods/variables were used).
125 * codegen.cs (EmitContext.CaptureThis): New method to flag that
126 `this' must be captured.
128 2005-01-30 Miguel de Icaza <miguel@novell.com>
130 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
131 is null it means that there has been no need to capture anything,
132 so we just create a sibling.
134 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
136 Just a partial fix. The other half is fairly elusive.
138 2005-02-10 Raja R Harinath <rharinath@novell.com>
140 Fix #52586, cs0121-4.cs.
141 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
142 and return a hashtable.
143 (MemberCache.ClearDeclaredOnly): New.
144 (MemberCache.MemberCache): Update to change. Make a deep copy of
145 the method_hash of a base type too.
146 (MemberCache.AddMethods): Adapt to having a deep copy of the base
147 type methods. Overwrite entries with the same MethodHandle so
148 that the ReflectedType is correct. The process leaves in base
149 virtual functions and their overrides as distinct entries.
150 (CacheEntry): Now a class instead of a struct. It shouldn't alter
151 matters since it was boxed in a ArrayList before.
152 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
154 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
155 case of a virtual function and its override (choose the overload
157 (Invocation.OverloadResolve): Avoid 'override' members during
158 'applicable_type' calculation.
160 2005-02-09 Raja R Harinath <rharinath@novell.com>
162 Combine two near-redundant caches.
163 * typemanager.cs (method_params): Rename from method_internal_params.
164 (TypeManager.GetParameterData): New. Replace
165 Invocation.GetParameterData.
166 (TypeManager.LookupParametersByBuilder): Remove.
167 * expression.cs (Invocation.method_parameter_cache): Remove.
168 (Invocation.GetParameterData): Remove.
170 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
173 2005-02-08 Raja R Harinath <rharinath@novell.com>
176 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
177 TypeManager.multicast_delegate_type is null, resolve it by looking
178 up "System.MulticastDelegate".
179 * rootcontext.cs (RootContext.ResolveCore): Simplify.
181 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
182 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
183 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
186 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
187 (LabeledStatement.AddReference): New. Set 'referenced'.
188 (Goto.Resolve): Use it.
190 2005-02-05 John Luke <john.luke@gmail.com>
192 * driver.cs: remove duplicate -doc line in Usage ()
194 2005-02-04 Raja R Harinath <rharinath@novell.com>
196 * location.cs (Location.AddFile): Fix CS2002 error report.
198 2005-02-02 Martin Baulig <martin@ximian.com>
200 * delegate.cs (Delegate.DefineType): Report an internal error if
201 TypeManager.multicast_delegate_type is null. See bug #72015 for
204 2005-02-02 Raja R Harinath <rharinath@novell.com>
206 Fix a crasher in a variant of #31984.
207 * const.cs (Constant.CheckBase): New override that defers the
208 new-or-override check in case the base type hasn't been populated
210 (Constant.Define): Ensure the new-or-override check is performed.
212 2005-02-01 Duncan Mak <duncan@ximian.com>
214 * const.cs (LookupConstantValue): Check that `ce' is not null
215 before calling GetValue ().
217 2005-02-01 Raja R Harinath <rharinath@novell.com>
219 Fix test-334.cs (#69519).
220 * cs-parser.jay (using_alias_directive): Pass in an expression to
221 NamespaceEntry.UsingAlias.
222 (using_namespace_directive): Pass in an expression to
223 NamespaceEntry.Using.
224 (namespace_name): Don't flatten to a string.
225 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
226 (NamespaceEntry.AliasEntry.Resolve): Lookup using
228 (NamespaceEntry.UsingEntry): Likewise.
229 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
231 (NamespaceEntry.LookupForUsing): Remove.
232 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
234 (NamespaceEntry.Lookup): Remove support for dotted names.
236 2005-02-01 Raja R Harinath <rharinath@novell.com>
238 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
240 (NamespaceEntry.ImplicitParent): Compute on demand.
241 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
242 parallels the current.
243 (NamespaceEntry.LookupForUsing): Use it.
244 (NamespaceEntry.Lookup): If the current namespace-entry is
245 implicit, don't search aliases and using tables.
247 2005-02-01 Raja R Harinath <rharinath@novell.com>
250 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
252 (TypeContainer.BaseCache): Compute on demand.
253 (TypeContainer.FindMembers): Define constants and types if they're
255 (FieldMember.Define): Move resetting of ec.InUnsafe before error
257 * const.cs (Constant.Define): Make idempotent.
259 2005-01-29 Miguel de Icaza <miguel@novell.com>
261 * pending.cs: Produce better code (no nops produced by using Ldarg
264 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
265 i - 1' it should be arg + 1.
269 2005-01-28 Raja R Harinath <rharinath@novell.com>
271 * attribute.cs (Attribute.CheckAttributeType): Make private
273 (Attribute.ResolveType): Make virtual.
274 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
275 handling of RootContext.Tree.Types.
277 2005-01-27 Raja R Harinath <rharinath@novell.com>
279 Update attribute-handling to use the SimpleName/MemberAccess
281 * cs-parser.jay (attribute): Pass in an expression to the
282 constructors of Attribute and GlobalAttribute.
283 * attribute.cs (Attribute): Take an expression for the name.
284 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
285 passed in attribute name expression.
286 (Attribute.CheckAttributeType): Use it.
287 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
288 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
289 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
290 argument to prevent error messages if the lookup fails.
292 2005-01-27 Marek Safar <marek.safar@seznam.cz>
294 * expression.cs (Indirection): Implemented IVariable interface
295 to support indirection in AddressOf operator.
296 (PointerArithmetic.Emit): Add optimalization for case where
297 result can be precomputed.
299 2005-01-26 Martin Baulig <martin@ximian.com>
301 * class.cs (TypeContainer.AttributeTargets): Return the correct
302 AttributeTargets depending on our `Kind' instead of throwing an
303 exception; fixes #71632.
305 2005-01-26 Marek Safar <marek.safar@seznam.cz>
308 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
311 2005-01-25 Raja R Harinath <rharinath@novell.com>
314 * expression.cs (MemberAccess.DoResolve): Don't complain with
315 cs0572 when the LHS of a member access has identical name and type
318 2005-01-25 Marek Safar <marek.safar@seznam.cz>
321 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
323 Create custom PermissionSet only for PermissionSetAttribute.
325 2005-01-24 Marek Safar <marek.safar@seznam.cz>
328 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
329 delegates in static class.
331 2005-01-24 Martin Baulig <martin@ximian.com>
333 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
334 merging an implicit block, just use its reachability.
336 * statement.cs (Block.Resolve): Make the unreachable code check
337 work wrt. implicit blocks; see test-337 from #63842.
339 2005-01-21 Alp Toker <alp@atoker.com>
341 * cs-parser.jay: destructor_declaration's container is PartialContainer
342 not Class when partial types are used, so use Kind prop instead of
345 2005-01-22 Miguel de Icaza <miguel@ximian.com>
347 * cs-parser.jay: Improve error reporting when an interface
350 2005-01-20 Dick Porter <dick@ximian.com>
352 * support.cs: SeekableStreamReader fix from Sandor Dobos
353 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
354 chars are read. Fixes bug 70369.
356 2005-01-20 Raja R Harinath <rharinath@novell.com>
358 * cs-parser.jay (catch_clause): Simplify current_block handling
361 2005-01-17 Miguel de Icaza <miguel@ximian.com>
363 * convert.cs (ImplicitStandardConversionExists): Synchronize the
364 code with ImplicitStandardConversion to handle the implicit
365 conversion of method groups into valid delegate invocations.
367 The problem is that in parameter handling we were using this code
368 path. Fixes bug #64698
370 2005-01-19 Raja R Harinath <rharinath@novell.com>
372 * cs-parser.jay: Fix several infelicities.
373 - Avoid assigning to the parser value stack. Code like
374 '$3 = null' is unclean. Synthesize a value for the code block
376 - Avoid using oob_stack for storing location information. Use ...
377 (_mark_): ... this. New (empty) rule. Saves the current location
379 (foreach_statement): Avoid using oob_stack for current_block
380 handling. Use technique used in for_statement and
381 using_statement. Synthesize a value for the code block to store
382 additional intermediate information.
384 2005-01-13 Miguel de Icaza <miguel@ximian.com>
386 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
387 of a different type is only allowed to private fields of a
388 containing type, not on fields of a base class.
390 See test-174.cs and error cs0122-9.cs
392 2005-01-13 Raja R Harinath <rharinath@novell.com>
394 Fix test-335.cs (bug #58126).
395 * cs-parser.jay (argument): Split out non-expression parts of the
396 rule into 'non_simple_argument'.
397 (invocation_expression): Support parenthesized invocations with
398 multiple arguments, and with single non-simple arguments.
400 2005-01-13 Raja R Harinath <rharinath@novell.com>
402 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
405 2005-01-12 Raja R Harinath <rharinath@novell.com>
407 Fix cs0038-1.cs, cs1640-6.cs.
408 * ecore.cs (Expression.Resolve): Remove special-case for
409 SimpleName in error-handling.
410 (Expression.almostMatchedMembers): Relax access permission to
412 (Expression.MemberLookupFailed): Handle duplicates in
413 almostMatchedMembers list.
414 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
415 * expression.cs (New.DoResolve): Report CS1540 for more cases.
416 * typemanager.cs (GetFullNameSignature): Use the MethodBase
417 overload if the passed in MemberInfo is a MethodBase.
419 2005-01-12 Marek Safar <marek.safar@seznam.cz>
422 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
423 for non-CAS & merge permission sets properly.
425 2005-01-11 Raja R Harinath <rharinath@novell.com>
427 Improve standard-compliance of simple name and member access
428 resolution. Fixes bugs #52697, #57200, #67520, #69519.
429 * ecore.cs (FullNamedExpression): New abstract base class
430 for Namespaces and TypeExpressions.
431 (ResolveFlags.SimpleName): Remove.
432 (SimpleName): Remove support for dotted names.
433 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
434 DeclSpace.FindType and DeclSpace.LookupType.
435 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
436 (Expression.ExprClassName): Make member function.
437 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
438 a namespace. Remove creation of dotted "SimpleName"s.
439 (MemberAccess.DoResolve): Likewise.
440 * decl.cs (DeclSpace.Cache): Make private.
441 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
442 (DeclSpace.FindType): Update.
443 (DeclSpace.LookupType): Move here from RootContext. Return a
445 * namespace.cs (Namespace): Derive from FullNamedExpression
446 so that it can be part of expression resolution.
447 (Namespace.Lookup): Return an FullNamedExpression.
448 (NamespaceEntry.LookupAlias): Lookup aliases only in current
450 * rootcontext.cs (NamespaceLookup): Remove.
451 (LookupType): Move to DeclSpace.
452 * attribute.cs (CheckAttributeType): Update.
453 * doc.cs (FindDocumentedType): Remove allowAlias argument.
454 (FindDocumentedTypeNonArray): Likewise.
456 2005-01-11 Raja R Harinath <rharinath@novell.com>
458 Fix cs0509.cs, cs1632.cs.
459 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
460 is the same as IsInterface.
461 (TypeContainer.GetClassBases): Likewise.
462 * statement.cs (LabeledStatement.ig): New field.
463 (LabeledStatement.LabelTarget): Save ILGenerator which created the
465 (LabeledStatement.DoEmit): Check that the label was created with
466 the same ILGenerator.
468 2005-01-10 Marek Safar <marek.safar@seznam.cz>
471 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
472 accessors to its properties.
474 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
475 from accessors to property.
477 2005-01-10 Marek Safar <marek.safar@seznam.cz>
480 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
483 2005-01-08 Miguel de Icaza <miguel@ximian.com>
485 * attribute.cs: Check for null and empty strings.
487 I have lost another battle to Paolo.
489 2005-01-07 Marek Safar <marek.safar@seznam.cz>
492 * class.cs (PropertyMethod): Set Parent field in ctors.
493 (SetMethod.InternalParameters): Add unsafe switch hack.
494 Override MarkForDuplicationCheck where it is appropriate.
496 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
497 It says whether container allows members with the same name.
499 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
500 Removed is_method parameter.
502 2005-01-06 Duncan Mak <duncan@ximian.com>
504 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
505 because the previous change led to incorrect reporting of CS1032
506 ("Cannot define/undefine preprocessor symbols after first token in
507 file"). Instead of using `tokens_seen' as the only flag that
508 triggers CS1040, introduce `comments_seen'. This new flag is used
509 to signify having seen comments on the current line, so it is
510 unset after a newline.
512 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
514 * doc.cs : When searching for a type, find nested type too.
515 This fixes bug #71040.
517 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
520 - Warn missing member comment on those classes which also does not
521 have doc comments. Fixed bug #71041.
522 - Don't warn missing doc comment on default constructor.
525 2005-01-06 Duncan Mak <duncan@ximian.com>
527 * cs-tokenizer.cs (xtoken): After handling traditional C-style
528 comments, set `tokens_seen' to true. This allows us to detect
529 misplaced preprocessor directives (i.e. not at the beginning of
530 the a line, nor after whitespaces). In that case, report error
531 CS1040. This fixes bug #56460.
533 * cs-parser.jay (interface_member_declaration): Add checks for
534 IsExplicitImpl, and report CS0541 error if an interface member is
535 defined as an explicit interface declaration.
537 2005-01-06 Marek Safar <marek.safar@seznam.cz>
540 * class.cs (PropertyMethod): Set Parent field in ctors.
541 (SetMethod.InternalParameters): Add unsafe switch hack.
543 * decl.cs (MemberCore.Parent): Cannot be readonly.
545 2005-01-06 Raja R Harinath <rharinath@novell.com>
547 * decl.cs (DeclSpace.ResolveType): Remove.
548 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
549 Merge in code from ...
550 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
551 * class.cs, enum.cs: Update to changes.
553 2005-01-06 Miguel de Icaza <miguel@ximian.com>
555 * anonymous.cs: Ensure that we init the scope of our parent if it
556 has not been initialized yet.
558 2004-12-30 Duncan Mak <duncan@ximian.com>
560 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
561 if field.FieldBuilder is null. Fixes #70758.
563 * convert.cs: Fixed some typos and updated some of the comments.
564 (ImplicitStandardConversionExists):
565 (TryImplicitIntConversion): If `target_type' is an interface and
566 the type of `ic' implements this interface, return true or a new
567 BoxedCast instead of null. This fixes #70468.
569 2004-12-29 Duncan Mak <duncan@ximian.com>
571 * expression.cs (Argument.Emit): Check that Expr is
572 IMemoryLocation before casting to it, and report CS1510 otherwise.
576 2004-12-21 Ben Maurer <bmaurer@ximian.com>
578 * statement.cs (Block.ThisVariable): remove the recursion here, to
579 make the --profile more sane.
581 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
583 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
584 assembly, by JB Evain.
586 2004-12-17 Raja R Harinath <rharinath@novell.com>
588 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
589 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
590 "parent" refers to enclosing type/class. "base" refers to superclass.
592 2004-12-17 Raja R Harinath <rharinath@novell.com>
594 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
595 Ensure that we only have GlobalAttributes.
596 * attribute.cs (Attribute.Emit): Make non-virtual.
597 (GlobalAttribute.Emit): Remove.
598 (Attribute.Resolve): Make virtual.
599 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
600 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
601 the argument. Don't create one.
602 (Attribute.GetObsoleteAttribute): Likewise.
603 (Attribute.GetClsCompliantAttributeValue): Likewise.
604 * class.cs, decl.cs: Update to changes.
606 2004-12-17 Marek Safar <marek.safar@seznam.cz>
608 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
610 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
612 * statement.cs (Foreach.Resolve): Add error 186 report.
614 2004-12-16 Marek Safar <marek.safar@seznam.cz>
616 * expression.cs (Conditional.DoResolve): Add warning 429.
618 * statement.cs (If.Resolve): Add warning 665.
620 2004-12-16 Raja R Harinath <rharinath@novell.com>
622 New invariant: RootContext.Tree.Types.NamespaceEntry == null
623 except when in the parser, and in GlobalAttribute.
624 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
625 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
626 RootContext.Tree.Types.NamespaceEntry once work is done.
627 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
628 and resets RootContext.Tree.Types.NamespaceEntry.
630 2004-12-15 Marek Safar <marek.safar@seznam.cz>
632 * cs-parser.jay: Don't create a block for every variable.
634 2004-12-14 Miguel de Icaza <miguel@ximian.com>
636 * location.cs: Provide extra information.
638 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
639 variables from the captured environment, it is the ldarg_0.
641 2004-12-14 Marek Safar <marek.safar@seznam.cz>
643 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
646 * class.cs: Changed warning level for 169 to avoid developer
647 displeasure from warning flooding. It will be changed back when they
648 fix most of current BCL warnings.
650 * RootContext.cs: Pushed default WarningLevel to 3.
652 * statement.cs: Removed unused variable.
654 2004-12-14 Marek Safar <marek.safar@seznam.cz>
656 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
657 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
658 Add error 502 report.
659 (StaticClass.DefineType): Add error 441 report.
660 (Class.AllowedModifiersProp): New virtual property as temporary
661 extension to AllowedModifiers.
662 (Class.DefineType): Add error 418 report. Moved ModFlags check here
663 to share implementation with StaticClass and don't call virtual
666 * driver.cs (MainDriver): Add error 1558 test.
668 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
669 report. Moved error 36 test here.
671 * statement.cs (Throw.Resolve): Add error 724 report.
673 * typemanager.cs: Add out_attribute_type core type.
675 2004-12-13 Marek Safar <marek.safar@seznam.cz>
677 * class.cs (TypeContainer.VerifyClsCompliance): Add error
679 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
681 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
684 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
686 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
687 Add error 3023 report.
688 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
690 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
693 2004-12-12 John Luke <john.luke@gmail.com>
695 * driver.cs (AddArgs): take -- into account when
696 adding arguments, fixes bug 65710
698 2004-12-12 Martin Baulig <martin@ximian.com>
700 * expression.cs (Unary.TryReduceNegative): Added support for
701 SByteConstant and ByteConstant.
702 (Unary.Reduce): Check error values from TryReduceNegative().
704 2004-12-10 Marek Safar <marek.safar@seznam.cz>
706 * attributes.cs (Attribute.Resolve): Avoid multiple error report
707 and report exception as error 182.
709 2004-12-10 Raja R Harinath <rharinath@novell.com>
711 * driver.cs (Main): Fix message when there are warnings.
713 2004-12-09 Miguel de Icaza <miguel@ximian.com>
715 * delegate.cs: Fixed my fix from yesterday, sorry about that.
717 2004-12-09 Marek Safar <marek.safar@seznam.cz>
719 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
720 Reduced number of warnings.
722 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
724 2004-12-08 Miguel de Icaza <miguel@ximian.com>
726 * driver.cs: Removed message.
728 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
730 2004-12-08 <vargaz@freemail.hu>
732 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
734 2004-12-08 Martin Baulig <martin@ximian.com>
736 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
737 instead of a CS3002 for properties and indexer.
739 2004-12-08 Martin Baulig <martin@ximian.com>
741 * decl.cs (MemberName.ToString): Make this work again.
743 2004-12-08 Marek Safar <marek.safar@seznam.cz>
745 * attribute.cs (Resolve): Add error 591 detection.
747 * class.cs (FieldMember.Define): Add error 1547 detection.
748 (Indexer.Define): Add error 620 detection.
749 (Operator.Define): Add error 590 detection.
751 * ecore.cs: Missing argument for error 79.
753 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
756 2004-12-07 Marek Safar <marek.safar@seznam.cz>
759 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
762 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
764 * cs-parser.jay : handle doc comments on implicit/explicit operators.
765 Some operator comments were suppressed.
766 * doc.cs : Implicit/explicit operator name in doc comments are like
767 "op_Explicit(type)~returnType", so added suffix handling.
769 2004-12-07 Martin Baulig <martin@ximian.com>
772 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
773 (MemberCore.GetClsCompliantAttributeValue): Likewise.
774 (DeclSpace.ec): New protected field; store the EmitContext here.
775 (DeclSpace.EmitContext): New public property; moved here from
777 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
780 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
781 (Enum.Emit): Don't create a new EmitContext.
783 * delegate.cs (Delegate.DefineType): Always create the
786 * iterators.cs (Iterators.DefineIterator): Create a new
787 EmitContext and store it in `ec'.
789 2004-08-24 Martin Baulig <martin@ximian.com>
792 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
793 this for accessibility checks.
794 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
795 IsNestedFamilyAccessible.
796 (TypeManager.IsSubclassOf): New method, do what the name actually
799 2004-12-06 Raja R Harinath <rharinath@novell.com>
801 Fix crash on cs0657-17.cs.
802 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
803 Use RootContext.Tree.Types, not 'new RootTypes ()'.
804 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
805 the case where the NamespaceEntry gets overwritten.
807 2004-12-06 Marek Safar <marek.safar@seznam.cz>
810 * ecore.cs (ResolveBoolean): Tiny refactoring.
812 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
813 of right expression resolving when left is false constant and
814 operator is LogicalAnd OR true constant and operator is LogicalOr.
816 * statement.cs (ResolveUnreachable): Always reports warning.
818 2004-12-05 Miguel de Icaza <miguel@ximian.com>
820 * class.cs: Distinguish between 1721 and 1722 (just a little help
823 2004-12-03 Miguel de Icaza <miguel@ximian.com>
825 * delegate.cs: Only allow this on new versions of the language.
827 2004-12-02 Duncan Mak <duncan@ximian.com>
829 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
831 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
832 here as a static method. Take an additional bool out parameter
833 `must_do_cs1540_check' for signaling to InstanceResolve.
834 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
835 member field from PropertyExpr class and made it an argument of
837 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
838 check for MarshalByRefObject, and report CS0122 instead of CS1540.
839 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
840 and `remove_accessor' as well as InstanceResolve: report CS0122
845 2004-12-03 Raja R Harinath <rharinath@novell.com>
847 Fix test-327.cs, test-328.cs, and put in early infrastructure
848 for eventually fixing #52697.
849 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
850 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
852 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
853 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
854 (VerifyUsing, error246): Update.
855 * rootcontext.cs (RootContext.NamespaceLookup): Just use
856 'NamespaceEntry.LookupNamespaceOrType'.
858 2004-12-03 Martin Baulig <martin@ximian.com>
860 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
861 method as our child, call AnonymousMethod.Compatible() on it.
863 2004-12-03 Raja R Harinath <rharinath@novell.com>
865 Disable XML documentation support in 'basic' profile.
866 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
867 Redirect XmlElement to System.Object.
868 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
869 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
870 * mcs.exe.sources: Add doc-bootstrap.cs.
871 * doc-bootstrap.cs: New file. Contains empty stub implementation
874 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
876 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
877 comments are allowed.
879 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
881 * delegate.cs: Add checks for subtypes in paramaters and return values
882 in VerifyMethod () to add support for Covariance/Contravariance
885 2004-12-02 Miguel de Icaza <miguel@ximian.com>
887 * report.cs: Remove extra closing parenthesis.
889 * convert.cs (Error_CannotImplicitConversion): If the name of the
890 types are the same, provide some extra information.
892 * class.cs (FieldBase): Use an unused bit field from the field to
893 encode the `has_offset' property from the FieldMember. This saves
894 a couple of Ks on bootstrap compilation.
896 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
897 method as our child, return the AnonymousMethod resolved
900 * expression.cs (New.DoResolve): Allow return values from
901 NewDelegate to also include AnonymousMethods.
905 2004-12-02 Marek Safar <marek.safar@seznam.cz>
908 * attribute.cs (Resolve): Improved implementation of params
911 * support.cs (ParameterData): Add HasParams to be faster.
913 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
915 all things are for /doc support:
917 * doc.cs: new file that supports XML documentation generation.
918 * mcs.exe.sources: added doc.cs.
920 Handle /doc command line option.
921 Report error 2006 instead of 5 for missing file name for /doc.
922 Generate XML documentation when required, after type resolution.
924 Added support for picking up documentation (/// and /** ... */),
925 including a new XmlCommentState enumeration.
927 Added lines to fill Documentation element for field, constant,
928 property, indexer, method, constructor, destructor, operator, event
929 and class, struct, interface, delegate, enum.
930 Added lines to warn incorrect comment.
932 Added Documentation field (passed only when /doc was specified).
934 Added DocComment, DocCommentHeader, GenerateDocComment() and
935 OnGenerateDocComment() and some supporting private members for
936 /doc feature to MemberCore.
938 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
940 Added overriden DocCommentHeader.
942 Added overriden DocCommentHeader and GenerateDocComment().
944 2004-12-01 Miguel de Icaza <miguel@ximian.com>
946 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
947 unwrapping the enumeration values, chain to
948 DoConstantNumericPromotions again, so we can promote things to the
949 fundamental types (takes care of enums that are bytes, sbytes).
953 2004-12-01 Raja R Harinath <rharinath@novell.com>
955 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
956 Fix long-standing bug in type-lookup. Use FindType instead of
957 LookupType when ec.ResolvingTypeTree.
958 (Attribute.ResolveType, Attribute.Resolve)
959 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
961 (Attributes.Search): Remove internal version. Update.
962 (Attributes.SearchMulti): Update.
963 (Attributes.GetClsCompliantAttribute): Remove.
964 (Attributes.GetIndexerNameAttribute): Remove.
965 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
966 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
967 * class.cs (Indexer.Define): Likewise.
969 2004-12-01 Marek Safar <marek.safar@seznam.cz>
972 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
973 MarshallByReference members access.
975 * expression.cs: Use CheckMarshallByRefAccess;
976 Better error CS0197 message.
978 * report.cs: Print whole related error message.
980 2004-11-30 Raja R Harinath <rharinath@novell.com>
982 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
983 the current directory to help debugging.
985 2004-11-29 Marek Safar <marek.safar@seznam.cz>
987 * class (GetClassBases): Better error 60 report.
988 (EventProperty): Disabled warning 67 detection.
990 2004-11-29 Marek Safar <marek.safar@seznam.cz>
993 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
995 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
998 2004-11-29 Marek Safar <marek.safar@seznam.cz>
1001 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
1003 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
1005 2004-11-26 Miguel de Icaza <miguel@ximian.com>
1007 * attribute.cs (Attribute.Resolve): Refine error reporting and
1008 report a cs0117 if the identifier does not exist, to distinguish
1009 from 0617 which is a miss-use of the actual identifier.
1011 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
1012 between cs0070 and cs0079.
1014 * class.cs (MemberBase.DoDefine): When reporting a wrong
1015 accessibility level, we use MethodCore to compare instead of
1016 Method (this was a regression in some refactoring effort).
1018 So now we correctly report cs0056 again.
1020 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
1021 testing the target_type (which was known to be object_type) and
1022 not the source type (which is anonymous_method).
1024 Fixed reporting of error cs1660.
1026 * expression.cs (UserCast.Source): Expose the underlying cast.
1028 * statement.cs (Switch.SwitchGoverningType): Sort the list of
1029 allowed types to find a match to int32 first (most common).
1031 In addition, it ignores any ImplicitUserConversions that did an
1032 internal implicit conversion (as the switch statement allows only
1033 one integral conversion to exist).
1035 * class.cs (PartialContainer.Create): rename `name' to
1036 `member_name' for clarity. Then replace the string calls with a
1037 call to MemberName.GetPartialName, as now using
1038 MemberName.ToString is an error (this is due to the side effects
1039 it had, that were fixed in the past).
1041 This will restore the error reporting on a number of partial class
1042 errors that were missusing this (and getting an exception as a
1043 results, which is now just a plain textual warning, because
1044 yyparse debug output would crash otherwise).
1046 2004-11-26 Raja R Harinath <rharinath@novell.com>
1048 * Makefile (PROGRAM_INSTALL_DIR): Remove.
1050 2004-11-25 Ben Maurer <bmaurer@ximian.com>
1052 * rootcontext.cs (LookupType): Make sure to cache lookups that
1053 don't give us a negative result. This saves about 5% of corlib
1056 2004-11-25 Miguel de Icaza <miguel@ximian.com>
1058 * report.cs (AbstractMessage.Print): messages are sent to stderr
1060 * class.cs (TypeContainer.GetClassBases): It is an error to have a
1061 non-interface in the list of interfaces (at this point, either
1062 parent was properly set, or a base class is being listed in the
1063 interfaces section).
1065 This flags error 1722, and resolves the crash from bug 69259.
1067 2004-11-25 Ben Maurer <bmaurer@ximian.com>
1069 * statement.cs (Using.EmitExpressionFinally): make this work right
1070 for valuetypes. Fixes 69926.
1072 2004-11-25 Miguel de Icaza <miguel@ximian.com>
1074 * const.cs (Const.ChangeType): Cope with the "0 literal can be
1075 converted to an enum" here, before we try to change the underlying
1076 type. This code exists, but it is a different code path than the
1077 one used while encoding constants.
1079 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
1080 old bug: when converting from the null literal to a pointer,
1081 return an EmptyCast, not the NullLiteral.
1083 This fixes #69921, the recent null_type changes probably made this
1086 (ImplicitReferenceConversionExists): In addition, resynchronized
1087 the code here, so it matches the same code in
1088 ImplicitReferenceConversionExists for the `from any class-type S
1089 to any interface-type T'.
1092 2004-11-25 Marek Safar <marek.safar@seznam.cz>
1094 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
1096 2004-11-24 Miguel de Icaza <miguel@ximian.com>
1098 * cs-parser.jay: Use verbosity accordingly.
1100 2004-11-24 Marek Safar <marek.safar@seznam.cz>
1102 * expression.cs (Unary.ResolveOperator): Do not report warning;
1103 AddressOf reads from variable.
1105 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
1107 2004-11-24 Marek Safar <marek.safar@seznam.cz>
1111 * attribute.cs (Attributable): Removed CheckTargets.
1112 (Attributes.Emit): Explicit attribute targets are tested here.
1114 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
1115 not enabled for interfaces.
1117 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
1118 (GetAssemblyName): Ouch next bug there.
1120 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
1122 * expression.cs: Error 275 added.
1124 2004-11-23 Marek Safar <marek.safar@seznam.cz>
1126 Fix bug #69177 (Implemented decimal constant support)
1128 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
1129 (BinaryFold): Add DecimalConstant.
1131 * const.cs (Define): Decimal constant
1133 (ChangeType): Add decimal type handling.
1134 (LookupConstantValue): Don't set value for decimal type but
1135 emit DecimalConstantAttribute. Needed for constant optimization.
1137 * constant.cs (ToDecimal): New method.
1138 (ConvertToDecimal): New method.
1139 (IntConstant): Implemented ConvertToDecimal.
1140 (DecimalConstant.Emit): Emit optimized version for decimals in
1143 * expression.cs (ResolveOperator): Changed order of constant
1144 reduction to work correctly with native types which have
1145 overloaded operators.
1146 (ResolveMemberAccess): Extract constant value from attribute
1149 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
1151 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
1152 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
1153 (ChangeType): Decimal is special.
1154 (TypeToCoreType): Add decimal type.
1156 2004-11-22 Marek Safar <marek.safar@seznam.cz>
1158 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
1161 2004-11-22 Marek Safar <marek.safar@seznam.cz>
1163 * class.cs (EventField.ApplyAttributeBuilder): Fix error
1166 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1168 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
1170 * pending.cs (PendingImplementation): Grab only interfaces.
1172 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1174 * statement.cs (ForeachHelperMethods): Add location member and
1175 error 202 detection.
1177 2004-11-19 Raja R Harinath <rharinath@novell.com>
1179 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
1180 automatically handled by executable.make.
1181 (PROGRAM): Make profile-specific.
1183 2004-11-18 Marek Safar <marek.safar@seznam.cz>
1185 * expression.cs (DoResolveBase): Fixed wrong warning for out
1188 2004-11-18 Martin Baulig <martin@ximian.com>
1190 Merged latest changes into gmcs. Please keep this comment in
1191 here, it makes it easier for me to see what changed in MCS since
1192 the last time I merged.
1194 2004-11-17 Raja R Harinath <rharinath@novell.com>
1196 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
1197 (TypeHandle.GetMemberCache): New.
1198 (TypeHandle.TypeHandle): Update.
1199 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
1200 (TypeManager.LookupParentInterfacesCache):
1201 Rename from LookupInterfaceCache. Optimize slightly.
1202 (TypeManager.MemberLookup_FindMembers): Update.
1203 * decl.cs (MemberCache.MemberCache): Set Container to null in the
1205 (AddCacheContents): Rename from AddHashtable.
1206 * class.cs (TypeContainer.parent_container): Remove.
1207 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
1208 (TypeContainer.DoDefineMembers): Don't initialize it.
1209 Update to name changes.
1211 2004-11-17 Miguel de Icaza <miguel@ximian.com>
1213 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
1214 that factors the code to check access modifiers on override.
1216 (PropertyBase): Use the code here.
1218 Patch from Lluis S'anchez, fixes bug #69361.
1220 2004-11-15 Miguel de Icaza <miguel@ximian.com>
1222 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
1223 routine that is used to report the use of a captured variable
1224 whose address has been taken.
1226 There are two checks: one when variables are being captured and
1227 the other check is when the address of a variable is taken.
1229 (because an anonymous methods might be resolved before *or* after
1230 the address has been taken) and
1232 * expression.cs (Conditional.DoResolve): Remove the special
1233 casing that Martin added to trueExpr and falseExpr being both
1234 NullLiteral. We get the right behavior now just by introducing
1235 the null_type into the compiler.
1237 * convert.cs (ExplicitConversion): Change the code to use
1238 null_type instead of testing `expr is NullLiteral'.
1239 (ImplicitConversionStandard): use null_type too.
1240 (ImplicitReferenceConversionExists): use null_type too.
1241 (ImplicitReferenceConversion): use null_type too.
1243 * literal.cs: The type of `NullLiteral' is now null_type instead
1245 (Resolve): Set the type here.
1247 * typemanager.cs: Introduce null_type.
1249 2004-11-17 Martin Baulig <martin@ximian.com>
1251 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
1252 direction, like FindMembers() does. Fixes #69546, testcase is in
1255 2004-11-16 Martin Baulig <martin@ximian.com>
1257 This is based on a patch from Marek Safar, see bug #69082.
1258 Fixes bugs #63705 and #67130.
1260 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
1261 method; create a MemberCache for an interface type and cache the
1264 * decl.cs (IMemberContainer.ParentContainer): Removed.
1265 (IMemberContainer.ParentCache): New property.
1266 (MemberCache.SetupCacheForInterface): Removed.
1267 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
1268 to create a cache for an interface's "parent".
1270 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
1273 2004-11-16 Martin Baulig <martin@ximian.com>
1275 Merged back from gmcs; these changes already went into gmcs a
1276 couple of weeks ago.
1279 (TypeManager.AddUserType): Removed the `ifaces' argument.
1280 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
1282 (TypeManager.AddUserInterface): Removed.
1283 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
1285 (TypeManager.GetInterfaces): Likewise.
1286 (TypeManager.GetExplicitInterfaces): Likewise.
1288 * ecore.cs (TypeExpr.GetInterfaces): Removed.
1290 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
1291 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
1293 2004-11-14 Ben Maurer <bmaurer@ximian.com>
1295 * statement.cs: Avoid adding bools to a hashtable.
1297 2004-11-07 Miguel de Icaza <miguel@ximian.com>
1299 * expression.cs (Invocation.OverloadResolve): Flag error if we are
1300 calling an unsafe method from a safe location.
1302 2004-11-06 Marek Safar <marek.safar@seznam.cz>
1305 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
1307 2004-11-06 Miguel de Icaza <miguel@ximian.com>
1309 * namespace.cs (VerifyUsing): use GetPartialName instead of
1312 2004-11-05 Miguel de Icaza <miguel@ximian.com>
1314 * statement.cs (Return.Resolve): Fix regression in typo: if
1315 `in_exc', we have to request a NeedReturnLabel, this was a typo
1316 introduced in the anonymous method check-in. Fixes #69131.
1318 * Indexers were using the ShortName when defining themselves,
1319 causing a regression in the compiler bootstrap when applying the
1320 patch from 2004-11-02 (first part), now they use their full name
1321 and the bug is gone.
1323 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
1325 * driver.cs: Strip the path from the names of embedded resources. Fixes
1328 2004-11-04 Raja R Harinath <rharinath@novell.com>
1330 Fix error message regression: cs0104-2.cs.
1331 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
1332 (AliasEntry.Resolve): Update.
1333 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
1335 (RootContext.LookupType): Update.
1337 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
1339 * cs-parser.jay: Add support for handling accessor modifiers
1340 * class: Add support port accessor modifiers and error checking,
1341 define PropertyMethod.Define as virtual (not abstract anymore)
1342 * ecore.cs: Add checking for proeprties access with access modifiers
1343 * iterators.cs: Modify Accessor constructor call based in the modified
1345 2004-11-02 Ben Maurer <bmaurer@ximian.com>
1347 * expression.cs (StringConcat): Handle being called twice,
1348 as when we have a concat in a field init with more than two
1351 2004-11-02 Miguel de Icaza <miguel@ximian.com>
1353 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
1354 special case explicit implementations, we should always produce
1355 the .property or .event declaration.
1357 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
1358 since it will not return correct data if people use this
1359 unresolved in the presence of using statements (see test-313).
1361 * class.cs (MethodData.Define): If we are an explicit interface
1362 implementation, set the method name to the full name of the
1363 interface plus the name of the method.
1365 Notice that using the method.MethodName.GetFullName() does not
1366 work, as it will only contain the name as declared on the source
1367 file (it can be a shorthand in the presence of using statements)
1368 and not the fully qualifed type name, for example:
1372 class D : ICloneable {
1373 object ICloneable.Clone () {
1377 Would produce a method called `ICloneable.Clone' instead of
1378 `System.ICloneable.Clone'.
1380 * namespace.cs (Alias.Resolve): Use GetPartialName.
1382 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1384 * cs-parser.jay: Add error 1055 report.
1386 2004-11-01 Miguel de Icaza <miguel@ximian.com>
1388 * assign.cs (Assign.DoResolve): Only do the transform of
1389 assignment into a New if the types are compatible, if not, fall
1390 through and let the implicit code deal with the errors and with
1391 the necessary conversions.
1393 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1395 * cs-parser.jay: Add error 1031 report.
1397 * cs-tokenizer.cs: Add location for error 1038.
1399 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1401 * cs-parser.jay: Add error 1016 report.
1403 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1405 * cs-parser.jay: Add errors 1575,1611 report.
1407 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1409 * cs-parser.jay: Add error 1001 report.
1411 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1414 * attribute.cs (GetMarshal): Add method argument for
1415 caller identification.
1417 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
1418 agument for GetMarshal and RuntimeMissingSupport.
1420 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1422 * attribute.cs (ExtractSecurityPermissionSet): Removed
1423 TypeManager.code_access_permission_type.
1425 * typemanager.cs: Removed TypeManager.code_access_permission_type.
1427 2004-10-27 Miguel de Icaza <miguel@ximian.com>
1429 * expression.cs (LocalVariableReference.DoResolveLValue): Check
1430 for obsolete use of a variable here. Fixes regression on errors
1431 cs0619-25 and cs0619-26.
1433 2004-10-27 Marek Safar <marek.safar@seznam.cz>
1435 Fix #62358, implemented security attribute encoding.
1437 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
1438 Tests permitted SecurityAction for assembly or other types.
1439 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
1440 data from SecurityPermissionAttribute to PermisionSet class.
1442 * class.cs (ApplyAttributeBuilder): Added special handling
1443 for System.Security.Permissions.SecurityAttribute based types.
1445 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
1446 special handling for System.Security.Permissions.SecurityAttribute
1449 * enum.cs (ApplyAttributeBuilder): Added special handling
1450 for System.Security.Permissions.SecurityAttribute based types.
1452 * parameter.cs (ApplyAttributeBuilder): Added special handling
1453 for System.Security.Permissions.SecurityAttribute based types.
1455 * rootcontext.cs: Next 2 core types.
1457 * typemanager.cs (TypeManager.security_permission_attr_type):
1458 Built in type for the SecurityPermission Attribute.
1459 (code_access_permission_type): Build in type.
1461 2004-10-17 Miguel de Icaza <miguel@ximian.com>
1463 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
1464 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
1465 all of this information into
1466 EmitContext.EmitCapturedVariableInstance.
1468 * codegen.cs (EmitCapturedVariableInstance): move here the
1469 funcionality of emitting an ldarg.0 in the presence of a
1470 remapping. This centralizes the instance emit code.
1472 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
1473 then emit a load of this: it means that we have reached the
1474 topmost ScopeInfo: the one that contains the pointer to the
1475 instance of the class hosting the anonymous method.
1477 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
1478 captures to the topmost CaptureContext.
1480 2004-10-12 Miguel de Icaza <miguel@ximian.com>
1482 * expression.cs (LocalVariableReference): Move the knowledge about
1483 the iterators into codegen's EmitCapturedVariableInstance.
1485 2004-10-11 Miguel de Icaza <miguel@ximian.com>
1487 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
1488 all code paths return a value from an anonymous method (it is the
1489 same as the 161 error, but for anonymous methods).
1491 2004-10-08 Miguel de Icaza <miguel@ximian.com>
1493 The introduction of anonymous methods in the compiler changed
1494 various ways of doing things in the compiler. The most
1495 significant one is the hard split between the resolution phase
1496 and the emission phases of the compiler.
1498 For instance, routines that referenced local variables no
1499 longer can safely create temporary variables during the
1500 resolution phase: they must do so from the emission phase,
1501 since the variable might have been "captured", hence access to
1502 it can not be done with the local-variable operations from the runtime.
1506 (Block.Flags): New flag `IsTopLevel' to indicate that this block
1507 is a toplevel block.
1509 (ToplevelBlock): A new kind of Block, these are the blocks that
1510 are created by the parser for all toplevel method bodies. These
1511 include methods, accessors and anonymous methods.
1513 These contain some extra information not found in regular blocks:
1514 A pointer to an optional CaptureContext (for tracking captured
1515 local variables and parameters). A pointer to the parent
1518 (Return.Resolve): Catch missmatches when returning a value from an
1519 anonymous method (error 1662).
1520 Invoke NeedReturnLabel from the Resolve phase instead of the emit
1523 (Break.Resolve): ditto.
1525 (SwitchLabel): instead of defining the labels during the
1526 resolution phase, we now turned the public ILLabel and ILLabelCode
1527 labels into methods called GetILLabelCode() and GetILLabel() that
1528 only define the label during the Emit phase.
1530 (GotoCase): Track the SwitchLabel instead of the computed label
1531 (its contained therein). Emit the code by using
1532 SwitchLabel.GetILLabelCode ().
1534 (LocalInfo.Flags.Captured): A new flag has been introduce to track
1535 whether the Local has been captured or not.
1537 (LocalInfo.IsCaptured): New property, used to tell whether the
1538 local has been captured.
1540 * anonymous.cs: Vastly updated to contain the anonymous method
1543 The main classes here are: CaptureContext which tracks any
1544 captured information for a toplevel block and ScopeInfo used to
1545 track the activation frames for various local variables.
1547 Each toplevel block has an optional capture context associated
1548 with it. When a method contains an anonymous method both the
1549 toplevel method and the anonymous method will create a capture
1550 context. When variables or parameters are captured, they are
1551 recorded on the CaptureContext that owns them, for example:
1555 MyDelegate d = delegate {
1560 Here `a' will be recorded as captured on the toplevel
1561 CapturedContext, the inner captured context will not have anything
1562 (it will only have data if local variables or parameters from it
1563 are captured in a nested anonymous method.
1565 The ScopeInfo is used to track the activation frames for local
1566 variables, for example:
1568 for (int i = 0; i < 10; i++)
1569 for (int j = 0; j < 10; j++){
1570 MyDelegate d = delegate {
1575 At runtime this captures a single captured variable `i', but it
1576 captures 10 different versions of the variable `j'. The variable
1577 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
1578 recorded on a child.
1580 The toplevel ScopeInfo will also track information like the `this'
1581 pointer if instance variables were referenced (this is necessary
1582 as the anonymous method lives inside a nested class in the host
1583 type of the method).
1585 (AnonymousMethod): Expanded to track the Toplevel, implement
1586 `AnonymousMethod.Compatible' to tell whether an anonymous method
1587 can be converted to a target delegate type.
1589 The routine now also produces the anonymous method content
1591 (AnonymousDelegate): A helper class that derives from
1592 DelegateCreation, this is used to generate the code necessary to
1593 produce the delegate for the anonymous method that was created.
1595 * assign.cs: API adjustments for new changes in
1596 Convert.ImplicitStandardConversionExists.
1598 * class.cs: Adjustments to cope with the fact that now toplevel
1599 blocks are of type `ToplevelBlock'.
1601 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
1602 insteda of standard blocks.
1604 Flag errors if params arguments are passed to anonymous methods.
1606 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
1607 `CurrentAnonymousMethod' which points to the current Anonymous
1608 Method. The variable points to the AnonymousMethod class that
1609 holds the code being compiled. It is set in the new EmitContext
1610 created for the anonymous method.
1612 (EmitContext.Phase): Introduce a variable and an enumeration to
1613 assist in enforcing some rules about when and where we are allowed
1614 to invoke certain methods (EmitContext.NeedsReturnLabel is the
1615 only one that enfonces this right now).
1617 (EmitContext.HaveCaptureInfo): new helper method that returns
1618 whether we have a CapturedContext initialized.
1620 (EmitContext.CaptureVariable): New method used to register that a
1621 LocalInfo must be flagged for capturing.
1623 (EmitContext.CapturedParameter): New method used to register that a
1624 parameters must be flagged for capturing.
1626 (EmitContext.CapturedField): New method used to register that a
1627 field must be flagged for capturing.
1629 (EmitContext.HaveCapturedVariables,
1630 EmitContext.HaveCapturedFields): Return whether there are captured
1631 variables or fields.
1633 (EmitContext.EmitMethodHostInstance): This is used to emit the
1634 instance for the anonymous method. The instance might be null
1635 (static methods), this (for anonymous methods that capture nothing
1636 and happen to live side-by-side with the current method body) or a
1637 more complicated expression if the method has a CaptureContext.
1639 (EmitContext.EmitTopBlock): Routine that drives the emission of
1640 code: it will first resolve the top block, then emit any metadata
1641 and then emit the code. The split is done so that we can extract
1642 any anonymous methods and flag any captured variables/parameters.
1644 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
1645 during this phase, the ILGenerator should not be used as labels
1646 and local variables declared here might not be accessible to any
1647 code that is part of an anonymous method.
1649 Exceptions to this include the temporary variables that are
1650 created by some statements internally for holding temporary
1653 (EmitContext.EmitMeta): New routine, in charge of emitting all the
1656 (EmitContext.TemporaryReturn): This method is typically called
1657 from the Emit phase, and its the only place where we allow the
1658 ReturnLabel to be defined other than the EmitMeta. The reason is
1659 that otherwise we would have to duplicate a lot of logic in the
1660 Resolve phases of various methods that today is on the Emit
1663 (EmitContext.NeedReturnLabel): This no longer creates the label,
1664 as the ILGenerator is not valid during the resolve phase.
1666 (EmitContext.EmitThis): Extended the knowledge in this class to
1667 work in anonymous methods in addition to iterators.
1669 (EmitContext.EmitCapturedVariableInstance): This emits whatever
1670 code is necessary on the stack to access the instance to a local
1671 variable (the variable will be accessed as a field).
1673 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
1674 EmitContext.EmitAddressOfParameter): Routines to support
1675 parameters (not completed at this point).
1677 Removals: Removed RemapLocal and RemapLocalLValue. We probably
1678 will also remove the parameters.
1680 * convert.cs (Convert): Define a `ConstantEC' which points to a
1681 null. This is just to prefity some code that uses
1682 ImplicitStandardConversion code and do not have an EmitContext
1685 The idea is to flag explicitly that at that point in time, it is
1686 known that the conversion will not trigger the delegate checking
1687 code in implicit conversions (which requires a valid
1690 Everywhere: pass new EmitContext parameter since
1691 ImplicitStandardConversionExists now requires it to check for
1692 anonymous method conversions.
1694 (Convert.ImplicitStandardConversionExists): If the type of an
1695 expression is the anonymous_method_type, and the type is a
1696 delegate, we invoke the AnonymousMethod.Compatible method to check
1697 whether an implicit conversion is possible.
1699 (Convert.ImplicitConversionStandard): Only do implicit method
1700 group conversions if the language level is not ISO_1.
1702 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
1703 MethodInfo for the Invoke method. used by Delegate and
1706 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
1707 method conversions if the target type is a delegate.
1709 Removed extra debugging nops.
1711 (LocalVariableReference): Turn the `local_info' into a public
1714 Add `prepared' field, the same hack used for FieldExprs to cope
1715 with composed assignments, as Local variables do not necessarily
1716 operate purely on the stack as they used to: they can be captured
1719 Add `temp' for a temporary result, like fields.
1721 Refactor DoResolve and DoResolveLValue into DoResolveBase.
1723 It now copes with Local variables that are captured and emits the
1724 proper instance variable to load it from a field in the captured
1727 (ParameterReference.DoResolveBase): During the resolve phase,
1728 capture parameters if we are in an anonymous method.
1730 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
1731 anonymous method, use the EmitContext helper routines to emit the
1732 parameter reference.
1734 * iterators.cs: Set RemapToProxy to true/false during the
1737 * parameters.cs (GetParameterByName): New helper method.
1739 * typemanager.cs (anonymous_method_type) a new type that
1740 represents an anonyous method. This is always an internal type,
1741 used as a fencepost to test against the anonymous-methodness of an
1744 2004-10-20 Marek Safar <marek.safar@seznam.cz>
1746 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
1748 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
1750 2004-10-18 Martin Baulig <martin@ximian.com>
1752 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
1753 `Type' directly, but call ResolveType() on it.
1754 (Catch.Resolve): Likewise.
1755 (Foreach.Resolve): Likewise.
1757 2004-10-18 Martin Baulig <martin@ximian.com>
1759 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
1760 `Type' directly, but call ResolveType() on it.
1761 (Probe.DoResolve): Likewise.
1762 (ArrayCreation.LookupType): Likewise.
1763 (TypeOf.DoResolve): Likewise.
1764 (SizeOf.DoResolve): Likewise.
1766 2004-10-18 Martin Baulig <martin@ximian.com>
1768 * expression.cs (Invocation.BetterFunction): Put back
1769 TypeManager.TypeToCoreType().
1771 2004-10-18 Raja R Harinath <rharinath@novell.com>
1773 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
1776 2004-10-18 Martin Baulig <martin@ximian.com>
1778 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
1779 `Type' directly, but call ResolveType() on it.
1781 2004-10-18 Martin Baulig <martin@ximian.com>
1783 * class.cs (FieldMember.Define): Don't access the TypeExpr's
1784 `Type' directly, but call ResolveType() on it.
1785 (MemberBase.DoDefine): Likewise.
1787 * expression.cs (New.DoResolve): Don't access the TypeExpr's
1788 `Type' directly, but call ResolveType() on it.
1789 (ComposedCast.DoResolveAsTypeStep): Likewise.
1791 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
1792 `Type' directly, but call ResolveType() on it.
1794 2004-10-17 John Luke <john.luke@gmail.com>
1796 * class.cs (Operator.GetSignatureForError): use CSharpName
1798 * parameter.cs (Parameter.GetSignatureForError): Returns
1799 correct name even if was not defined.
1801 2004-10-13 Raja R Harinath <rharinath@novell.com>
1804 * class.cs (TypeContainer.EmitContext): New property.
1805 (DefineNestedTypes): Create an emitcontext for each part.
1806 (MethodCore.DoDefineParameters): Use container's emitcontext.
1807 Pass type array to InternalParameters.
1808 (MemberBase.DoDefine): Use container's emitcontext.
1809 (FieldMember.Define): Likewise.
1810 (Event.Define): Likewise.
1811 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1812 Pass type array to InternalParameters.
1813 (SetIndexerMethod.GetParameterInfo): Likewise.
1814 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1815 * delegate.cs (Define): Pass emitcontext to
1816 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1817 array to InternalParameters.
1818 * expression.cs (ParameterReference.DoResolveBase): Pass
1819 emitcontext to GetParameterInfo.
1820 (ComposedCast.DoResolveAsTypeStep): Remove check on
1821 ec.ResolvingTypeTree.
1822 * parameter.cs (Parameter.Resolve): Change argument to
1823 EmitContext. Use ResolveAsTypeTerminal.
1824 (Parameter.GetSignature): Change argument to EmitContext.
1825 (Parameters.ComputeSignature): Likewise.
1826 (Parameters.ComputeParameterTypes): Likewise.
1827 (Parameters.GetParameterInfo): Likewise.
1828 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1829 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1830 * support.cs (InternalParameters..ctor): Remove variant that takes
1832 * typemanager.cs (system_intptr_expr): New.
1833 (InitExpressionTypes): Initialize it.
1835 2004-10-12 Chris Toshok <toshok@ximian.com>
1837 * cs-parser.jay: fix location for try_statement and catch_clause.
1839 2004-10-11 Martin Baulig <martin@ximian.com>
1841 * report.cs: Don't make --fatal abort on warnings, we have
1842 -warnaserror for that.
1844 2004-10-07 Raja R Harinath <rharinath@novell.com>
1846 More DeclSpace.ResolveType avoidance.
1847 * decl.cs (MemberCore.InUnsafe): New property.
1848 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1849 with newly created EmitContext.
1850 (FieldMember.Define): Likewise.
1851 * delegate.cs (Delegate.Define): Likewise.
1852 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1853 only if normal name-lookup fails.
1854 (TypeExpr.DoResolve): Enable error-checking.
1855 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
1856 (SizeOf.DoResolve): Likewise.
1857 (ComposedCast.DoResolveAsTypeStep): Likewise.
1858 (StackAlloc.DoResolve): Likewise.
1859 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
1860 (Block.Unsafe): New property.
1861 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
1862 (Unsafe): Set 'unsafe' flag of contained block.
1863 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
1864 (Fixed.Resolve): Likewise.
1865 (Catch.Resolve): Likewise.
1866 (Using.ResolveLocalVariableDecls): Likewise.
1867 (Foreach.Resolve): Likewise.
1869 2004-10-05 John Luke <john.luke@gmail.com>
1871 * cs-parser.jay: add location to error CS0175
1873 2004-10-04 Miguel de Icaza <miguel@ximian.com>
1875 * ecore.cs (Expression.Constantity): Add support for turning null
1878 * const.cs (Const.Define): Allow constants to be reference types
1879 as long as the value is Null.
1881 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
1883 * namespace.cs (NamespaceEntry.Using): No matter which warning
1884 level is set, check if this namespace name has already been added.
1886 2004-10-03 Ben Maurer <bmaurer@ximian.com>
1888 * expression.cs: reftype [!=]= null should always use br[true,false].
1891 2004-10-03 Marek Safar <marek.safar@seznam.cz>
1894 * attribute.cs: Enum conversion moved to
1895 GetAttributeArgumentExpression to be applied to the all
1898 2004-10-01 Raja R Harinath <rharinath@novell.com>
1900 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
1901 * class.c (TypeContainer.DefineType): Flag error if
1902 base types aren't accessible due to access permissions.
1903 * decl.cs (DeclSpace.ResolveType): Move logic to
1904 Expression.ResolveAsTypeTerminal.
1905 (DeclSpace.ResolveTypeExpr): Thin layer over
1906 Expression.ResolveAsTypeTerminal.
1907 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
1908 Refactor code into NestedAccess. Use it.
1909 (DeclSpace.NestedAccess): New.
1910 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
1911 argument to silence errors. Check access permissions.
1912 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
1913 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
1914 (Cast.DoResolve): Likewise.
1915 (New.DoResolve): Likewise.
1916 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
1917 (TypeOf.DoResolve): Likewise.
1919 * expression.cs (Invocation.BetterConversion): Return the Type of
1920 the better conversion. Implement section 14.4.2.3 more faithfully.
1921 (Invocation.BetterFunction): Make boolean. Make correspondence to
1922 section 14.4.2.2 explicit.
1923 (Invocation.OverloadResolve): Update.
1924 (Invocation): Remove is_base field.
1925 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
1926 (Invocation.Emit): Likewise.
1928 2004-09-27 Raja R Harinath <rharinath@novell.com>
1930 * README: Update to changes.
1932 2004-09-24 Marek Safar <marek.safar@seznam.cz>
1934 * cs-parser.jay: Reverted 642 warning fix.
1936 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1939 * decl.cs (FindMemberWithSameName): Indexer can have more than
1942 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1944 * expression.cs (LocalVariableReference.DoResolveLValue):
1945 Do not report warning 219 for out values.
1946 (EmptyExpression.Null): New member to avoid extra allocations.
1948 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1950 * cs-parser.jay: Fix wrong warning 642 report.
1952 * cs-tokenizer.cs (CheckNextToken): New helper;
1953 Inspect next character if is same as expected.
1955 2004-09-23 Martin Baulig <martin@ximian.com>
1957 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1958 (Convert.ImplicitReferenceConversionExists): Likewise.
1960 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1962 * class.cs (Operator.Define): Add error 448 and 559 report.
1964 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1966 * class.cs (MemberBase.IsTypePermitted): New protected
1967 method for checking error CS0610.
1969 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1971 * class.cs (TypeContainer.HasExplicitLayout): New property
1972 Returns whether container has StructLayout attribute set Explicit.
1973 (FieldMember): New abstract class for consts and fields.
1974 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1975 (Field): Reuse FieldMember.
1977 * const.cs (Const): Reuse FieldMember.
1979 * rootcontext.cs: EmitConstants call moved to class.
1981 2004-09-22 Martin Baulig <martin@ximian.com>
1983 Thanks to Peter Sestoft for this bug report.
1985 * expression.cs (Conditional): If both the `trueExpr' and the
1986 `falseExpr' is a NullLiteral, return a NullLiteral.
1988 2004-09-22 Martin Baulig <martin@ximian.com>
1990 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1991 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1992 for the "get_Current" call.
1994 2004-09-22 Martin Baulig <martin@ximian.com>
1996 Marek and me just fixed one of our oldest bugs: #28562 :-)
1998 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
2000 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
2001 we're an EnumConstant, just return that.
2002 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
2003 an EnumConstant. In this case, we need to use GetValueAsEnumType()
2004 to get the value which'll actually be written into the attribute.
2005 However, we have to use GetValue() to access the attribute's value
2008 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2010 * constant.cs (Constant.IsNegative): New abstract property
2013 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
2014 (StackAlloc.DoResolve): Reused IsNegative.
2016 2004-09-21 Martin Baulig <martin@ximian.com>
2018 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
2019 if we're used in an iterator, we may be called from different
2022 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
2023 we actually have an exception block.
2025 2004-09-20 John Luke <jluke@cfl.rr.com>
2027 * class.cs, cs-parser.jay: Improve the error report for 1520:
2028 report the actual line where the error happens, not where the
2031 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
2032 Pass location information that was available elsewhere.
2034 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
2036 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
2037 runtime to delay sign assemblies.
2039 2004-09-19 Miguel de Icaza <miguel@ximian.com>
2041 * cs-parser.jay: Do not report the stack trace, this is barely
2044 2004-08-22 John Luke <john.luke@gmail.com>
2046 * driver.cs : check that a resource id is not already used
2047 before adding it, report CS1508 if it is, bug #63637
2049 2004-09-19 Miguel de Icaza <miguel@ximian.com>
2051 * ecore.cs: Removed dead code.
2053 2004-09-18 Marek Safar <marek.safar@seznam.cz>
2055 * class.cs: Do not report warning CS0067 on the interfaces.
2057 2004-09-16 Marek Safar <marek.safar@seznam.cz>
2059 * cs-parser.jay: Add error 504 report.
2061 2004-09-16 Marek Safar <marek.safar@seznam.cz>
2063 * rootcontext.cs: WarningLevel is 4 by default now.
2065 * statement.cs (Fixed.Resolve): Do not null
2068 2004-09-16 Marek Safar <marek.safar@seznam.cz>
2071 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
2072 deep search when property is not virtual.
2073 (PropertyExpr.ResolveAccessors): Make one call for both
2076 2004-09-15 Marek Safar <marek.safar@seznam.cz>
2079 * statement.cs: Error 152 report constains also location.
2081 2004-09-15 Marek Safar <marek.safar@seznam.cz>
2084 * const.cs: Explicitly set constant as static.
2086 2004-09-15 Marek Safar <marek.safar@seznam.cz>
2089 * cs-parser.jay: Add error 1017 report.
2091 2004-09-15 Marek Safar <marek.safar@seznam.cz>
2093 Fixed bug #59980, #64224
2094 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
2096 * typemanager.cs (IsSpecialMethod): Simplified
2098 2004-09-14 Marek Safar <marek.safar@seznam.cz>
2100 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
2101 condition with better params.
2103 2004-09-14 Marek Safar <marek.safar@seznam.cz>
2106 * attribute.cs (Resolve): Property has to have both
2109 2004-09-14 Martin Baulig <martin@ximian.com>
2111 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
2113 2004-09-14 Marek Safar <marek.safar@seznam.cz>
2116 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
2117 called and is obsolete then this member suppress message
2118 when call is inside next [Obsolete] method or type.
2120 * expression.cs: Use TestObsoleteMethodUsage member.
2122 2004-09-14 Martin Baulig <martin@ximian.com>
2124 * cs-parser.jay: Sync a bit with the GMCS version.
2126 2004-09-14 Martin Baulig <martin@ximian.com>
2128 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
2129 (CSharpParser.yacc_verbose_flag): New public field.
2131 * genericparser.cs: Removed.
2133 2004-09-14 Raja R Harinath <rharinath@novell.com>
2135 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
2137 2004-09-13 Marek Safar <marek.safar@seznam.cz>
2139 * class.cs (MethodCore.CheckBase): Fix bug #65757.
2141 2004-09-10 Martin Baulig <martin@ximian.com>
2143 Backported my MemberName changes from GMCS into MCS.
2145 - we are now using a special `MemberName' class instead of using
2146 strings; in GMCS, the `MemberName' also contains the type
2149 - changed the grammar rules a bit:
2150 * the old `member_name' is now a `namespace_or_type_name':
2151 The rule is that we use `namespace_or_type_name' everywhere
2152 where we expect either a "member name" (GetEnumerator) or a
2153 "member name" with an explicit interface name
2154 (IEnumerable.GetEnumerator).
2155 In GMCS, the explicit interface name may include type arguments
2156 (IEnumerable<T>.GetEnumerator).
2157 * we use `member_name' instead of just `IDENTIFIER' for
2159 The rule is that we use `member_name' wherever a member may
2160 have type parameters in GMCS.
2162 * decl.cs (MemberName): New public class.
2163 (MemberCore.MemberName): New public readonly field.
2164 (MemberCore.ctor): Take a `MemberName' argument, not a string.
2165 (DeclSpace): Likewise.
2167 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
2168 * enum.cs (Enum.ctor): Likewise.
2170 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
2172 (AliasEntry.ctor): Take a MemberName, not an Expression.
2173 (AliasEntry.UsingAlias): Likewise.
2175 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
2176 (IMethodData.MemberName): Changed type from string to MemberName.
2177 (MemberBase.ExplicitInterfaceName): Likewise.
2178 (AbstractPropertyEventMethod.SetupName): Make this private.
2179 (AbstractPropertyEventMethod.ctor): Added `string prefix'
2180 argument; compute the member name here.
2181 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
2182 on the `member.MemberName' and the `prefix'.
2184 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
2186 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
2187 thus, we get a `MemberName' instead of a `string'. These
2188 declarations may have type parameters in GMCS.
2189 (interface_method_declaration, delegate_declaration): Likewise.
2190 (class_declaration, interface_declaration): Likewise.
2191 (method_header): Use `namespace_or_type_name' instead of
2192 `member_name'. We may be an explicit interface implementation.
2193 (property_declaration, event_declaration): Likewise.
2194 (member_name): This is now just an `IDENTIFIER', not a
2195 `namespace_or_type_name'.
2196 (type_name, interface_type): Removed.
2197 (namespace_or_type_name): Return a MemberName, not an Expression.
2198 (primary_expression): Use `member_name' instead of `IDENTIFIER';
2199 call GetTypeExpression() on the MemberName to get an expression.
2200 (IndexerDeclaration.interface_type): Changed type from string to
2202 (MakeName): Operate on MemberName's instead of string's.
2204 2004-09-13 Raja R Harinath <rharinath@novell.com>
2207 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
2208 (NamespaceEntry.Lookup): Add new argument to flag if we want the
2209 lookup to avoid symbols introduced by 'using'.
2210 * rootcontext.cs (NamespaceLookup): Update.
2212 2004-09-12 Marek Safar <marek.safar@seznam.cz>
2214 * class.cs (TypeContainer.DoDefineMembers): Do not call
2215 DefineDefaultConstructor for static classes.
2217 2004-09-12 Marek Safar <marek.safar@seznam.cz>
2219 * attribute.cs (Attribute.Resolve): Add error 653 report.
2221 * class.cs (Class.ApplyAttributeBuilder): Add error 641
2223 (Method.ApplyAttributeBuilder): Add error 685 report.
2224 (Operator.Define): Add error 564 report.
2226 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
2228 * expression.cs (Invocation.DoResolve): Add error
2231 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
2234 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2236 * class.cs (ConstructorInitializer.Resolve):
2237 Wrong error number (515->516).
2239 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2241 * class.cs (Indexer.Define): Add error 631 report.
2243 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2245 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
2247 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2249 * expression.cs (Probe.DoResolve): Add error CS0241 report.
2251 2004-09-10 Marek Safar <marek.safar@seznam.cz>
2253 * cs-parser.jay: Added error CS0241 report.
2255 2004-09-10 Raja R Harinath <rharinath@novell.com>
2257 * cs-parser.jay (fixed_statement): Introduce a scope for the
2258 declaration in the 'fixed' statement.
2260 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2262 * cs-parser.jay: Added CS0230 error report.
2264 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2266 * cs-parser.jay: Added errors CS0231 and CS0257 report.
2268 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2270 * expression.cs (Argument.Resolve): Added error CS0192 and
2273 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2275 C# 2.0 #pragma warning feature
2277 * cs-tokenizer.cs (PreProcessPragma): New method;
2278 Handles #pragma directive.
2280 * report.cs (WarningRegions): New class; Support
2281 class for #pragma warning directive. It tests whether
2282 warning is enabled for a given line.
2284 2004-09-08 Miguel de Icaza <miguel@ximian.com>
2286 * const.cs: Add more descriptive error report, tahnks to
2289 2004-09-08 Marek Safar <marek.safar@seznam.cz>
2291 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
2293 2004-09-07 Miguel de Icaza <miguel@ximian.com>
2295 * expression.cs: Apply patch from Ben: Remove dead code from
2296 ArrayCreation, and remove the TurnintoConstant call in const.cs,
2297 as that code just threw an exception anwyays.
2299 * const.cs: Remove the call to the turnintoconstant, for details
2302 * literal.cs: The type of the null-literal is the null type; So
2303 we use a placeholder type (literal.cs:System.Null, defined here)
2306 * expression.cs (Conditional.DoResolve): Remove some old code that
2307 is no longer needed, conversions have been fixed.
2309 (ArrayCreationExpression.DoResolve): Return false if we fail to
2310 resolve the inner expression.
2312 2004-09-07 Raja R Harinath <rharinath@novell.com>
2315 * cs-parser.jay (delegate_declaration): Record a delegate
2316 declaration as a type declaration.
2317 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
2319 2004-09-06 Miguel de Icaza <miguel@ximian.com>
2321 * parameter.cs: Do not crash if the type can not be resolved.
2323 * expression.cs: Report errors with unsafe pointers, fixes #64896
2325 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
2327 * expression.cs: Pointer arith always needs to do a conv.i
2328 if the operand is a long. fix 65320
2330 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2332 Fixed cs0619-37.cs, cs0619-38.cs
2334 * enum.cs (GetObsoleteAttribute): Removed.
2336 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
2337 on Enum member is double staged. The first is tested member
2340 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2342 Fixed #56986, #63631, #65231
2344 * class.cs: (TypeContainer.AddToMemberContainer): New method,
2345 adds member to name container.
2346 (TypeContainer.AddToTypeContainer): New method, adds type to
2348 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
2349 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
2350 AddOperator): Simplified by reusing AddToMemberContainer.
2351 (TypeContainer.UserDefinedStaticConstructor): Changed to property
2353 (Method.CheckForDuplications): Fixed implementation to test all
2355 (MemberBase): Detection whether member is explicit interface
2356 implementation is now in constructor.
2357 (MemberBase.UpdateMemberName): Handles IndexerName.
2358 (Accessor): Changed to keep also location information.
2359 (AbstractPropertyEventMethod): Is derived from MemberCore.
2360 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
2361 will be emited or not.
2362 (PropertyBase.AreAccessorsDuplicateImplementation):
2363 Tests whether accessors are not in collision with some method.
2364 (Operator): Is derived from MethodCore to simplify common
2367 * decl.cs (Flags.TestMethodDuplication): Test for duplication
2369 (DeclSpace.AddToContainer): Adds the member to defined_names
2370 table. It tests for duplications and enclosing name conflicts.
2372 * enum.cs (EnumMember): Clean up to reuse the base structures
2374 2004-09-03 Martin Baulig <martin@ximian.com>
2376 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2377 into TypeContainer, to make partial classes work again.
2379 2004-09-03 Martin Baulig <martin@ximian.com>
2381 * rootcontext.cs (RootContext.V2): Removed.
2383 2004-03-23 Martin Baulig <martin@ximian.com>
2385 * expression.cs (Invocation.OverloadResolve): Added `bool
2386 may_fail' argument and use it instead of the Location.IsNull() hack.
2388 2004-09-03 Martin Baulig <martin@ximian.com>
2390 Merged latest changes into gmcs. Please keep this comment in
2391 here, it makes it easier for me to see what changed in MCS since
2392 the last time I merged.
2394 2004-09-03 Raja R Harinath <rharinath@novell.com>
2397 * expression.cs (BetterConversion): Don't allow either conversion
2398 to be null. Remove redundant implicit conversion test when 'q ==
2399 null' -- when this function is invoked, we already know that the
2400 implicit conversion exists.
2401 (BetterFunction): Assume that 'best' is non-null. Remove
2402 redundant reimplementation of IsApplicable when 'best' is null.
2403 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
2404 number of arguments.
2405 (IsAncestralType): Extract from OverloadResolve.
2406 (OverloadResolve): Make robust to the MethodGroupExpr being
2407 unsorted. Implement all the logic of Section 14.5.5.1, and
2408 support overloading of methods from multiple applicable types.
2409 Clean up logic somewhat. Don't pass null methods to BetterFunction.
2411 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
2412 (RealError, Warning): Append type of report to related symbol.
2414 2004-09-03 Marek Safar <marek.safar@seznam.cz>
2416 * enum.cs: Fixed CLS-Compliance checks for enum members.
2417 Error tests cs3008-8.cs, cs3014-8.cs
2419 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2421 Fixed bug #62342, #63102
2422 * class.cs: ImplementIndexer uses member.IsExplicitImpl
2423 like ImplementMethod.
2425 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2427 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2430 2004-09-02 Martin Baulig <martin@ximian.com>
2432 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2433 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2436 2004-09-01 Marek Safar <marek.safar@seznam.cz>
2438 C# 2.0 Static classes implemented
2440 * class.cs (TypeContainer): instance_constructors,
2441 initialized_fields, initialized_static_fields,
2442 default_constructor, base_inteface_types are protected to be
2443 accessible from StaticClass.
2444 (TypeContainer.DefineDefaultConstructor): New virtual method
2445 for custom default constructor generating
2446 (StaticClass): New class to handle "Static classes" feature.
2448 * cs-parser.jay: Handle static keyword on class like instance
2451 * driver.cs: Added "/langversion" command line switch with two
2452 options (iso-1, default).
2454 2004-08-31 Marek Safar <marek.safar@seznam.cz>
2456 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
2458 2004-08-31 Miguel de Icaza <miguel@ximian.com>
2460 * delegate.cs: Style.
2462 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
2464 * delegate.cs: Add seperate instance expr field for miguel.
2466 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2468 * PointerArithmetic (Resolve): make sure we are not doing
2469 pointer arith on void*. Also, make sure we are resolved
2470 by not setting eclass until resolve.
2472 All callers: Make sure that PointerArithmetic gets resolved.
2474 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2476 * ArrayCreation (LookupType): If the type does not resolve
2477 to an array, give an error.
2479 2004-08-27 Marek Safar <marek.safar@seznam.cz>
2481 * statement.cs (Try.Resolve): Fixed bug #64222
2483 2004-08-27 Martin Baulig <martin@ximian.com>
2486 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2489 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2491 * ecore.cs (Constantify): Get underlying type via
2492 System.Enum.GetUnderlyingType to avoid StackOverflow on the
2493 Windows in special cases.
2495 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2497 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
2498 for obtaining also private methods.
2499 (GetRemoveMethod): Used GetRemoveMethod (true)
2500 for obtaining also private methods.
2502 2004-08-24 Martin Baulig <martin@ximian.com>
2504 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
2505 MethodAttributes.HideBySig for operators.
2507 2004-08-23 Martin Baulig <martin@ximian.com>
2509 Back to the old error reporting system :-)
2511 * report.cs (Message): Removed.
2512 (Report.MessageData, ErrorData, WarningData): Removed.
2513 (Report.Error, Warning): Back to the old system.
2515 2004-08-23 Martin Baulig <martin@ximian.com>
2517 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
2519 * class.cs (TypeContainer.ParentContainer): New public virtual
2520 method; replaces the explicit interface implementation.
2521 (ClassPart.ParentContainer): Override.
2523 2004-08-23 Martin Baulig <martin@ximian.com>
2525 * statement.cs (Switch): Added support for constant switches; see
2526 #59428 or test-285.cs.
2528 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2531 * statement.cs (GetEnumeratorFilter): Removed useless
2532 logic because C# specs is strict. GetEnumerator must be
2535 2004-08-22 Martin Baulig <martin@ximian.com>
2537 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2538 a switch and may break, reset the barrier. Fixes #59867.
2540 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2542 CLS-Compliance speed up (~5% for corlib)
2544 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
2545 New method. Tests container for CLS-Compliant names
2547 * class.cs (TypeContainer.VerifyClsName): New method.
2548 Checks whether container name is CLS Compliant.
2549 (Constructor): Implements IMethodData.
2551 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
2552 low-case table for CLS Compliance test.
2553 (MemberCache.VerifyClsParameterConflict): New method.
2554 Checks method parameters for CS3006 error.
2556 * enum.cs (EnumMember): Is derived from MemberCore.
2557 (Enum.VerifyClsName): Optimized for better performance.
2559 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2561 * report.cs: Renamed Error_T to Error and changed all
2564 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2566 * class.cs (TypeContainer.IndexerArrayList): New inner class
2567 container for indexers.
2568 (TypeContainer.DefaultIndexerName): New constant for default
2569 indexer name. Replaced all "Item" with this constant.
2570 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
2572 * typemanager.cs (TypeManager.default_member_ctor): Cache here
2573 DefaultMemberAttribute constructor.
2575 2004-08-05 Martin Baulig <martin@ximian.com>
2577 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
2580 2004-08-05 Marek Safar <marek.safar@seznam.cz>
2582 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
2583 multi platforms problem.
2585 * compiler.csproj: Included shared files.
2587 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2589 Fix bug 60333, 55971 in the more general way
2590 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2591 Added arg_type argument for constant conversion.
2592 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
2594 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2597 * class.cs (TypeContainer ): New inner classes MethodArrayList,
2598 OperatorArrayList, MethodCoreArrayList for typecontainer
2599 containers. Changed class member types to these new types.
2600 (MethodArrayList.DefineMembers): Added test for CS0659.
2602 2004-08-04 Miguel de Icaza <miguel@ximian.com>
2604 * cfold.cs: Synchronize the folding with the code in expression.cs
2605 Binary.DoNumericPromotions for uint operands.
2607 * attribute.cs: Revert patch from Raja, it introduced a regression
2608 while building Blam-1.2.1 (hard to isolate a test case).
2610 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2614 (TypeContainer.Define): Renamed to DefineContainerMembers because of
2616 (MethodCore.parent_method): New member. The method we're overriding
2617 if this is an override method.
2618 (MethodCore.CheckBase): Moved from Method class and made common.
2619 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
2621 (MethodCore.CheckForDuplications): New abstract method. For custom
2622 member duplication search in a container
2623 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
2624 method and its return type.
2625 (Event.conflict_symbol): New member. Symbol with same name in the
2629 (MemberCache.FindMemberWithSameName): New method. The method
2630 is looking for conflict with inherited symbols.
2632 2004-08-04 Martin Baulig <martin@ximian.com>
2634 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
2636 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
2638 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2640 * report.cs (Message): New enum for better error, warning reference in
2642 (MessageData): New inner abstract class. It generally handles printing of
2643 error and warning messages.
2644 Removed unused Error, Warning, Message methods.
2646 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2648 Fix for cs0592-8.cs test
2650 (Attributable.ValidAttributeTargets): Made public.
2651 (Attribute.ExplicitTarget): New member for explicit target value.
2652 (Attribute.CheckTargets): Now we translate explicit attribute
2653 target to Target here.
2655 2004-08-03 Ben Maurer <bmaurer@ximian.com>
2657 * ecore.cs (MethodGroupExpr): new IsBase property.
2659 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
2661 * delegate.cs (DelegateCreation): store a MethodGroupExpr
2662 rather than an instance expr.
2664 (DelegateCreation.Emit): Use the method group rather than
2665 the instance expression. Also, if you have base.Foo as the
2666 method for a delegate, make sure to emit ldftn, not ldftnvirt.
2668 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
2670 (NewDelegate.DoResolve): Only check for the existance of Invoke
2671 if the method is going to be needed. Use MethodGroupExpr.
2673 (NewDelegate.Emit): Remove, DelegateCreation implements this.
2675 * expression.cs: For pointer arith., make sure to use
2676 the size of the type, not the size of the pointer to
2679 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2682 * class.cs (Class): Added error CS0502 test.
2684 2004-08-03 John Luke <jluke@cfl.rr.com>
2685 Raja R Harinath <rharinath@novell.com>
2688 * attribute.cs (Attribute.complained_before): New flag.
2689 (Attribute.ResolveType, Attribute.Resolve),
2690 (Attribute.DefinePInvokeMethod): Set it.
2691 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
2693 2004-08-03 Martin Baulig <martin@ximian.com>
2695 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
2696 use a user-defined operator; we still need to do numeric
2697 promotions in case one argument is a builtin type and the other
2698 one has an implicit conversion to that type. Fixes #62322.
2700 2004-08-02 Martin Baulig <martin@ximian.com>
2702 * statement.cs (LocalInfo.Flags): Added `IsThis'.
2703 (LocalInfo.IsThis): New public property.
2704 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
2706 2004-08-01 Martin Baulig <martin@ximian.com>
2708 * class.cs (TypeContainer.GetClassBases): Don't set the default
2709 here since we may get called from GetPartialBases().
2710 (TypeContainer.DefineType): If GetClassBases() didn't return a
2711 parent, use the default one.
2713 2004-07-30 Duncan Mak <duncan@ximian.com>
2715 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
2717 2004-07-30 Martin Baulig <martin@ximian.com>
2719 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
2721 * class.cs (SourceMethod): New public class, derive from the
2722 symbol writer's ISourceMethod.
2723 (Method): Use the new symbol writer API.
2725 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
2726 as argument and use the new symbol writer.
2729 (SourceFile): Implement the symbol writer's ISourceFile.
2730 (Location.SymbolDocument): Removed.
2731 (Location.SourceFile): New public property.
2733 * symbolwriter.cs: Use the new symbol writer API.
2735 2004-07-30 Raja R Harinath <rharinath@novell.com>
2737 * Makefile (install-local): Remove. Functionality moved to
2740 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
2742 * Makefile: Install mcs.exe.config file together with mcs.exe.
2743 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
2744 correct runtime version.
2746 2004-07-25 Martin Baulig <martin@ximian.com>
2749 (TypeContainer.RegisterOrder): Removed, this was unused.
2750 (TypeContainer, interface_order): Removed.
2751 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
2752 TypeContainer as argument since we can also be called with a
2753 `PartialContainer' for a partial class/struct/interface.
2754 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
2755 of checking whether we're an `Interface' - we could be a
2757 (PartialContainer.Register): Override; call
2758 AddClass()/AddStruct()/AddInterface() on our parent.
2760 * cs-parser.jay (interface_member_declaration): Add things to the
2761 `current_container', not the `current_class'.
2763 * rootcontext.cs (RegisterOrder): The overloaded version which
2764 takes an `Interface' was unused, removed.
2766 * typemanager.cs (TypeManager.LookupInterface): Return a
2767 `TypeContainer', not an `Interface'.
2768 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
2769 contain a `PartialContainer' for an interface, so check it's
2770 `Kind' to figure out what it is.
2772 2004-07-25 Martin Baulig <martin@ximian.com>
2774 * class.cs (Class.DefaultTypeAttributes): New public constant.
2775 (Struct.DefaultTypeAttributes): Likewise.
2776 (Interface.DefaultTypeAttributes): Likewise.
2777 (PartialContainer.TypeAttr): Override this and add the
2778 DefaultTypeAttributes.
2780 2004-07-25 Martin Baulig <martin@ximian.com>
2782 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
2783 we can just use the `Parent' field instead.
2785 2004-07-25 Martin Baulig <martin@ximian.com>
2787 * class.cs (TypeContainer.Emit): Renamed to EmitType().
2789 2004-07-25 Martin Baulig <martin@ximian.com>
2791 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
2792 our parts before defining any methods.
2793 (TypeContainer.VerifyImplements): Make this virtual.
2794 (ClassPart.VerifyImplements): Override and call VerifyImplements()
2795 on our PartialContainer.
2797 2004-07-25 Martin Baulig <martin@ximian.com>
2799 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2801 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2802 argument, we can just use the `Parent' field instead.
2805 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2806 (MemberBase.DoDefine): Likewise.
2808 2004-07-24 Martin Baulig <martin@ximian.com>
2810 * decl.cs (MemberCore.Parent): New public field.
2811 (DeclSpace.Parent): Moved to MemberCore.
2813 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2814 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2816 (FieldBase, Field, Operator): Likewise.
2817 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2818 (EventField, Event): Likewise.
2820 2004-07-23 Martin Baulig <martin@ximian.com>
2822 * class.cs (PartialContainer): New public class.
2823 (ClassPart): New public class.
2824 (TypeContainer): Added support for partial classes.
2825 (TypeContainer.GetClassBases): Splitted some of the functionality
2826 out into GetNormalBases() and GetPartialBases().
2828 * cs-tokenizer.cs (Token.PARTIAL): New token.
2829 (Tokenizer.consume_identifier): Added some hacks to recognize
2830 `partial', but only if it's immediately followed by `class',
2831 `struct' or `interface'.
2833 * cs-parser.jay: Added support for partial clases.
2835 2004-07-23 Martin Baulig <martin@ximian.com>
2837 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2838 a `DeclSpace' and also made it readonly.
2839 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2840 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2841 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2843 * cs-parser.jay: Pass the `current_class', not the
2844 `current_container' (at the moment, this is still the same thing)
2845 to a new Method, Property, Event, Indexer or Constructor.
2847 2004-07-23 Martin Baulig <martin@ximian.com>
2849 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2850 and removed the `current_interface' one.
2851 (struct_declaration, class_declaration, interface_declaration):
2852 Set `current_class' to the newly created class/struct/interface;
2853 set their `Bases' and call Register() before parsing their body.
2855 2004-07-23 Martin Baulig <martin@ximian.com>
2857 * class.cs (Kind): New public enum.
2858 (TypeContainer): Made this class abstract.
2859 (TypeContainer.Kind): New public readonly field.
2860 (TypeContainer.CheckDef): New public method; moved here from
2862 (TypeContainer.Register): New public abstract method.
2863 (TypeContainer.GetPendingImplementations): New public abstract
2865 (TypeContainer.GetClassBases): Removed the `is_class' and
2866 `is_iface' parameters.
2867 (TypeContainer.DefineNestedTypes): Formerly known as
2869 (ClassOrStruct): Made this class abstract.
2871 * tree.cs (RootTypes): New public type.
2873 2004-07-20 Martin Baulig <martin@ximian.com>
2875 * tree.cs (Tree.RecordNamespace): Removed.
2876 (Tree.Namespaces): Removed.
2878 * rootcontext.cs (RootContext.IsNamespace): Removed.
2880 * cs-parser.jay (namespace_declaration): Just create a new
2881 NamespaceEntry here.
2883 2004-07-20 Martin Baulig <martin@ximian.com>
2885 * statement.cs (ExceptionStatement): New abstract class. This is
2886 now used as a base class for everyone who's using `finally'.
2887 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
2888 our local variables before using them.
2890 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
2891 virtual method. This is used by Yield.Resolve() to "steal" an
2892 outer block's `finally' clauses.
2893 (FlowBranchingException): The .ctor now takes an ExceptionStatement
2896 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
2897 version which takes an ExceptionStatement. This version must be
2898 used to create exception branchings.
2901 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
2902 (Iterator.EmitMoveNext): Added exception support; protect the
2903 block with a `fault' clause, properly handle 'finally' clauses.
2904 (Iterator.EmitDispose): Run all the `finally' clauses here.
2906 2004-07-20 Martin Baulig <martin@ximian.com>
2908 * iterator.cs: This is the first of a set of changes in the
2909 iterator code. Match the spec more closely: if we're an
2910 IEnumerable, then GetEnumerator() must be called. The first time
2911 GetEnumerator() is called, it returns the current instance; all
2912 subsequent invocations (if any) must create a copy.
2914 2004-07-19 Miguel de Icaza <miguel@ximian.com>
2916 * expression.cs: Resolve the constant expression before returning
2919 2004-07-19 Martin Baulig <martin@ximian.com>
2921 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
2922 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
2923 the return type of the new EmitContext.
2925 2004-07-18 Martin Baulig <martin@ximian.com>
2927 * class.cs (Property.Define): Fix iterators.
2929 * iterators.cs (Iterator.Define): Moved the
2930 `container.AddInterator (this)' call here from the .ctor; only do
2931 it if we resolved successfully.
2933 2004-07-17 Miguel de Icaza <miguel@ximian.com>
2935 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
2936 `true' for preprocessing directives that we parse. The return
2937 value indicates whether we should return to regular tokenizing or
2938 not, not whether it was parsed successfully.
2940 In the past if we were in: #if false ... #line #endif, we would
2941 resume parsing after `#line'. See bug 61604.
2943 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
2944 building: IsEnumType should return true only for enums, not for
2945 enums or System.Enum itself. This fixes #61593.
2947 Likely what happened is that corlib was wrong: mcs depended on
2948 this bug in some places. The bug got fixed, we had to add the
2949 hack, which caused bug 61593.
2951 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
2952 that was a workaround for the older conditions.
2954 2004-07-16 Ben Maurer <bmaurer@ximian.com>
2956 * assign.cs: IAssignMethod has a new interface, as documented
2957 inline. All assignment code now uses this new api.
2959 * ecore.cs, expression.cs: All classes which implement
2960 IAssignMethod now use the new interface.
2962 * expression.cs (Invocation): add a hack to EmitCall so that
2963 IndexerAccess can be the target of a compound assignment without
2964 evaluating its arguments twice.
2966 * statement.cs: Handle changes in Invocation api.
2968 2004-07-16 Martin Baulig <martin@ximian.com>
2970 * iterators.cs: Rewrote this. We're now using one single Proxy
2971 class for both the IEnumerable and the IEnumerator interface and
2972 `Iterator' derives from Class so we can use the high-level API.
2974 * class.cs (TypeContainer.AddIterator): New method.
2975 (TypeContainer.DoDefineType): New protected virtual method, which
2976 is called from DefineType().
2977 (TypeContainer.DoDefineMembers): Call DefineType() and
2978 DefineMembers() on all our iterators.
2979 (TypeContainer.Emit): Call Emit() on all our iterators.
2980 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2982 * codegen.cs (EmitContext.CurrentIterator): New public field.
2984 2004-07-15 Martin Baulig <martin@ximian.com>
2987 (TypeManager.not_supported_exception_type): New type.
2989 2004-07-14 Martin Baulig <martin@ximian.com>
2991 * iterators.cs: Use real error numbers.
2993 2004-07-14 Martin Baulig <martin@ximian.com>
2995 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2996 requires this to be a System.Collection.IEnumerable and not a
2997 class implementing that interface.
2998 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
3000 2004-07-13 Marek Safar <marek.safar@seznam.cz>
3002 * class.cs: Fixed previous fix, it broke some error tests.
3004 2004-07-12 Martin Baulig <martin@ximian.com>
3006 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
3009 2004-07-09 Miguel de Icaza <miguel@ximian.com>
3011 * assign.cs (LocalTemporary): Add new argument: is_address,If
3012 `is_address' is true, then the value that we store is the address
3013 to the real value, and not the value itself.
3015 * ecore.cs (PropertyExpr): use the new local temporary
3016 stuff to allow us to handle X.Y += z (where X is a struct)
3018 2004-07-08 Martin Baulig <martin@ximian.com>
3020 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
3021 not always return, just like we're doing in Using.Resolve().
3023 2004-07-07 Miguel de Icaza <miguel@ximian.com>
3025 * cs-parser.jay (fixed_statement): flag this as Pinned.
3027 2004-07-06 Miguel de Icaza <miguel@ximian.com>
3029 * typemanager.cs (TypeManager): Removed MakePinned method, this
3030 mechanism is replaced with the .NET 2.x compatible mechanism of
3031 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
3033 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
3034 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
3035 `IsFixed' property which has a different meaning.
3037 2004-07-02 Raja R Harinath <rharinath@novell.com>
3039 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
3040 visible from inside a nested class, not just the names of the
3041 immediately enclosing class.
3044 2004-06-24 Raja R Harinath <rharinath@novell.com>
3046 * expression.cs (BetterConversion): Remove buggy special-case
3047 handling of "implicit constant expression conversions". At this
3048 point, we already know that the conversion is possible -- we're
3049 only checking to see which is better.
3051 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3053 * cs-parser.jay: Added error CS0210 test.
3055 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3057 * cs-parser.jay: Added error CS0134 test.
3059 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3062 * cs-parser.jay: Added error CS0145 test.
3064 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3066 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
3068 2004-06-23 Ben Maurer <bmaurer@ximian.com>
3070 * expression.cs (StackAlloc.Resolve): The argument may not
3071 be a constant; deal with this case.
3073 2004-06-23 Marek Safar <marek.safar@seznam.cz>
3075 * attribute.cs (IndexerName_GetIndexerName): Renamed to
3076 GetIndexerAttributeValue.
3077 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
3079 * class.cs (Indexer.Define): Added error tests for CS0415,
3082 2004-06-23 Miguel de Icaza <miguel@ximian.com>
3084 * attribute.cs (Attribute.Resolve): Keep field code in sync with
3087 2004-06-23 Martin Baulig <martin@ximian.com>
3089 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
3090 neither return nor throw, reset the barrier as well. Fixes #60457.
3092 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
3094 * class.cs : EventAttributes is now set to None by default.
3095 This fixes bug #60459.
3097 2004-06-18 Marek Safar <marek.safar@seznam.cz>
3100 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3101 Don't throw exception but return null (it's sufficient now).
3103 2004-06-18 Marek Safar <marek.safar@seznam.cz>
3105 * typemanager.cs (GetArgumentTypes): Faster implementation.
3107 2004-06-18 Martin Baulig <martin@ximian.com>
3109 * attribute.cs (Attribute.Resolve): Check whether we're an
3110 EmptyCast which a Constant child. Fixes #60333.
3112 2004-06-17 Ben Maurer <bmaurer@ximian.com>
3114 * statement.cs (EmitCollectionForeach): Account for the fact that
3115 not all valuetypes are in areas which we can take the address of.
3116 For these variables, we store to a temporary variable. Also, make
3117 sure that we dont emit a `callvirt' on a valuetype method.
3119 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3121 * expression.cs (StackAlloc.DoReSolve): Added test for
3122 negative parameter (CS0247).
3124 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3127 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
3129 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3132 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
3135 2004-06-14 Marek Safar <marek.safar@seznam.cz>
3137 Fix bug #58254 & cs1555.cs, cs1556.cs
3138 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
3140 2004-06-14 Marek Safar <marek.safar@seznam.cz>
3142 * cs-parser.jay: Added error CS1669 test for indexers.
3144 2004-06-11 Martin Baulig <martin@ximian.com>
3146 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
3147 call this twice: for params and varargs methods.
3149 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3152 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
3154 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3156 * attribute.cs (Attribute.GetValidTargets): Made public.
3159 (AbstractPropertyEventMethod): New class for better code sharing.
3160 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
3162 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
3164 2004-06-11 Raja R Harinath <rharinath@novell.com>
3167 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
3168 that the call to Resolve is part of a MemberAccess.
3169 (Expression.Resolve): Use it for SimpleName resolution.
3170 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
3171 Add 'intermediate' boolean argument.
3172 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
3173 error message when the SimpleName can be resolved ambiguously
3174 between an expression and a type.
3175 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
3177 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
3178 call on the left-side.
3180 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3183 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
3185 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3187 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
3189 2004-06-11 Martin Baulig <martin@ximian.com>
3191 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
3192 varargs methods if applicable.
3194 2004-06-11 Martin Baulig <martin@ximian.com>
3196 * expression.cs (Invocation.EmitCall): Don't use
3197 `method.CallingConvention == CallingConventions.VarArgs' since the
3198 method could also have `CallingConventions.HasThis'.
3200 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3202 * class.cs (Event.GetSignatureForError): Implemented.
3203 Fixed crash in error test cs3010.cs
3205 2004-06-10 Miguel de Icaza <miguel@ximian.com>
3207 * cs-tokenizer.cs: Change the way we track __arglist to be
3208 consistent with the other keywords.
3210 2004-06-09 Miguel de Icaza <miguel@ximian.com>
3212 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
3215 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
3217 * codegen.cs: Check that all referenced assemblies have a strongname
3218 before strongnaming the compiled assembly. If not report error CS1577.
3219 Fix bug #56563. Patch by Jackson Harper.
3220 * typemanager.cs: Added a method to return all referenced assemblies.
3221 Fix bug #56563. Patch by Jackson Harper.
3223 2004-06-08 Marek Safar <marek.safar@seznam.cz>
3226 (Method.ApplyAttributeBuilder): Moved and added conditional
3227 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
3230 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
3232 2004-06-08 Marek Safar <marek.safar@seznam.cz>
3235 * class.cs: (EventField.attribute_targets): Changed default target.
3237 2004-06-08 Martin Baulig <martin@ximian.com>
3239 * expression.cs (Invocation.EmitCall): Enable varargs methods.
3241 2004-06-08 Martin Baulig <martin@ximian.com>
3243 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
3245 2004-06-07 Martin Baulig <martin@ximian.com>
3247 Added support for varargs methods.
3249 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
3252 * cs-parser.jay: Added support for `__arglist'.
3254 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
3256 * expression.cs (Argument.AType): Added `ArgList'.
3257 (Invocation): Added support for varargs methods.
3258 (ArglistAccess): New public class.
3259 (Arglist): New public class.
3261 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
3263 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
3264 a method's top-level block if the method has varargs.
3266 * support.cs (ReflectionParameters, InternalParameters): Added
3267 support for varargs methods.
3269 2004-06-07 Miguel de Icaza <miguel@ximian.com>
3271 * class.cs: Provide location in indexer error report.
3273 * driver.cs: Use standard names.
3275 * namespace.cs: Catch the use of using after a namespace has been
3276 declared also on using aliases.
3278 2004-06-03 Raja R Harinath <rharinath@novell.com>
3281 * typemanager.cs (closure_private_ok, closure_invocation_type)
3282 (closure_qualifier_type, closure_invocation_assembly)
3283 (FilterWithClosure): Move to ...
3284 (Closure): New internal nested class.
3285 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
3286 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
3287 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
3288 (MemberLookup, MemberLookupFailed): Use it.
3289 * expression.cs (New.DoResolve): Treat the lookup for the
3290 constructor as being qualified by the 'new'ed type.
3291 (Indexers.GetIndexersForTypeOrInterface): Update.
3293 2004-06-03 Marek Safar <marek.safar@seznam.cz>
3296 (GetConditionalAttributeValue): New method. Returns
3297 condition of ConditionalAttribute.
3298 (SearchMulti): New method. Returns all attributes of type 't'.
3299 Use it when attribute is AllowMultiple = true.
3300 (IsConditionalMethodExcluded): New method.
3303 (Method.IsExcluded): Implemented. Returns true if method has conditional
3304 attribute and the conditions is not defined (method is excluded).
3305 (IMethodData): Extended interface for ConditionalAttribute support.
3306 (PropertyMethod.IsExcluded): Implemented.
3309 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
3312 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
3315 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
3317 * expression.cs (ArrayCreationExpression): Make this just an
3318 `expression'. It can't be a statement, so the code here was
3321 2004-06-02 Marek Safar <marek.safar@seznam.cz>
3324 * typemanager.cs (GetFullNameSignature): New method for
3327 2004-06-02 Marek Safar <marek.safar@seznam.cz>
3330 * class.cs (MemberBase.GetSignatureForError): New virtual method.
3331 Use this method when MethodBuilder is null.
3332 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
3333 Added test for error CS0626 (MONO reports error for this situation).
3334 (IMethodData.GetSignatureForError): Extended interface.
3336 2004-06-01 Marek Safar <marek.safar@seznam.cz>
3339 (AttributeTester.GetObsoleteAttribute): Returns instance of
3340 ObsoleteAttribute when type is obsolete.
3343 (TypeContainer.VerifyObsoleteAttribute): Override.
3344 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
3345 (MethodCode.VerifyObsoleteAttribute): Override.
3346 (MemberBase.VerifyObsoleteAttribute): Override.
3349 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
3350 and report proper error.
3353 Delegate.VerifyObsoleteAttribute): Override.
3356 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
3357 and report proper error.
3358 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
3361 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
3365 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
3366 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
3367 Added test for ObsoleteAttribute.
3370 (Catch): Derived from Statement.
3372 2004-06-01 Marek Safar <marek.safar@seznam.cz>
3374 Fixed bug #59071 & cs0160.cs
3376 * statement.cs (Try.Resolve): Check here whether order of catch
3377 clauses matches their dependencies.
3379 2004-05-31 Miguel de Icaza <miguel@ximian.com>
3381 * Reverted patch to namespace.cs (Use lookuptypedirect). This
3382 caused a regression: #59343. Referencing nested classes from an
3383 assembly stopped working.
3385 2004-05-31 Martin Baulig <martin@ximian.com>
3387 MCS is now frozen for beta 2.
3389 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3391 * convert.cs: add a trivial cache for overload operator resolution.
3393 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3395 * decl.cs: If possible, use lookuptypedirect here. We can only do
3396 this if there is no `.' after the namespace. Avoids using
3397 LookupType, which does lots of slow processing.
3398 (FindNestedType) New method, does what it says :-).
3399 * namespace.cs: use LookupTypeDirect.
3400 * rootcontext.cs: use membercache, if possible.
3401 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3403 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3406 According to the spec,
3408 In a member access of the form E.I, if E is a single identifier,
3409 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3410 field, property, localvariable, or parameter with the same type as
3411 the meaning of E as a type-name (§3.8), then both possible
3412 meanings of E are permitted.
3414 We did not check that E as a simple-name had the same type as E as
3417 This trivial check gives us 5-7% on bootstrap time.
3419 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3421 * expression.cs (Invocation.OverloadResolve): Avoid the
3422 use of hashtables and boxing here by allocating on demand.
3424 2004-05-30 Martin Baulig <martin@ximian.com>
3426 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3427 we're doing a silent lookup. Don't try to lookup nested types in
3428 TypeManager.object_type (thanks to Ben Maurer).
3430 2004-05-30 Martin Baulig <martin@ximian.com>
3432 Committing a patch from Ben Maurer.
3434 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3436 2004-05-29 Martin Baulig <martin@ximian.com>
3438 * class.cs (IMethodData.ShouldIgnore): New method.
3440 * typemanager.cs (TypeManager.MethodFlags): Don't take a
3441 `Location' argument, we don't need it anywhere. Use
3442 `IMethodData.ShouldIgnore ()' instead of
3443 `MethodData.GetMethodFlags ()'.
3444 (TypeManager.AddMethod): Removed.
3445 (TypeManager.AddMethod2): Renamed to AddMethod.
3447 2004-05-29 Martin Baulig <martin@ximian.com>
3449 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
3451 * convert.cs (Convert.ImplicitReferenceConversion): If we're
3452 converting from a class type S to an interface type and we already
3453 have an object on the stack, don't box it again. Fixes #52578.
3455 2004-05-29 Martin Baulig <martin@ximian.com>
3457 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3458 Added support for `params' parameters. Fixes #59267.
3460 2004-05-29 Martin Baulig <martin@ximian.com>
3462 * literal.cs (NullPointer): Provide a private .ctor which sets
3463 `type' to TypeManager.object_type. Fixes #59048.
3465 2004-05-29 Martin Baulig <martin@ximian.com>
3467 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
3468 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
3470 * ecore.cs (EventExpr.instance_expr): Make the field private.
3472 2004-05-26 Marek Safar <marek.safar@seznam.cz>
3474 Fixed bug #50080 & cs0214-2.cs
3475 * expression.cs (Cast.DoResolve): Check unsafe context here.
3477 * statement.cs (Resolve.DoResolve): Likewise.
3479 2004-05-26 Martin Baulig <martin@ximian.com>
3481 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
3483 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
3484 (RootContext.LookupType): Pass down the `silent' flag.
3486 2004-05-25 Martin Baulig <martin@ximian.com>
3489 (MethodGroupExpr.IdenticalTypeName): New public property.
3490 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
3491 expression actually refers to a type.
3493 2004-05-25 Martin Baulig <martin@ximian.com>
3495 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
3496 for #56176 and made it actually work.
3498 2004-05-25 Martin Baulig <martin@ximian.com>
3500 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
3501 (FieldExpr, PropertyExpr): Override and implement
3502 CacheTemporaries. Fixes #52279.
3504 2004-05-25 Miguel de Icaza <miguel@ximian.com>
3506 * location.cs: In the new compiler listing a file twice is a
3507 warning, not an error.
3509 2004-05-24 Martin Baulig <martin@ximian.com>
3511 * enum.cs (Enum.DefineType): For the `BaseType' to be a
3512 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
3514 2004-05-24 Martin Baulig <martin@ximian.com>
3516 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
3517 walking the `using' list. Fixes #53921.
3519 2004-05-24 Martin Baulig <martin@ximian.com>
3521 * const.cs (Const.LookupConstantValue): Added support for
3522 EmptyCast's; fixes #55251.
3524 2004-05-24 Martin Baulig <martin@ximian.com>
3526 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
3527 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
3528 which does the CS0135 check. The reason is that we first need to
3529 check whether the variable actually exists.
3531 2004-05-24 Martin Baulig <martin@ximian.com>
3533 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
3534 than RootContext.LookupType() to find the explicit interface
3537 2004-05-24 Raja R Harinath <rharinath@novell.com>
3539 * Makefile: Simplify. Use executable.make.
3540 * mcs.exe.sources: New file. List of sources of mcs.exe.
3542 2004-05-24 Anders Carlsson <andersca@gnome.org>
3546 Use the invariant culture when doing String.Compare for CLS case
3549 2004-05-23 Martin Baulig <martin@ximian.com>
3551 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
3552 don't have any dots. Fixes #52622, added cs0246-8.cs.
3554 * namespace.cs (NamespaceEntry.Lookup): Likewise.
3556 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3558 * class.cs (MemberBase.Define): Reuse MemberType member for
3559 resolved type. Other methods can use it too.
3561 2004-05-23 Martin Baulig <martin@ximian.com>
3563 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
3564 the variable also exists in the current block (otherwise, we need
3565 to report a CS0103). Fixes #58670.
3567 2004-05-23 Martin Baulig <martin@ximian.com>
3569 * flowanalysis.cs (Reachability.Reachable): Compute this
3570 on-the-fly rather than storing it as a field.
3572 2004-05-23 Martin Baulig <martin@ximian.com>
3574 * flowanalysis.cs (Reachability.And): Manually compute the
3575 resulting `barrier' from the reachability.
3577 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3580 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
3581 instance of ObsoleteAttribute when symbol is obsolete.
3584 (IMethodData): Extended interface for ObsoleteAttribute support.
3586 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3588 * attribute.cs: Fix bug #55970
3590 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3594 (GetObsoleteAttribute): New method. Creates the instance of
3596 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
3597 ObsoleteAttribute when member is obsolete.
3598 (AttributeTester.Report_ObsoleteMessage): Common method for
3599 Obsolete error/warning reporting.
3602 (TypeContainer.base_classs_type): New member for storing parent type.
3605 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
3606 for this MemberCore.
3608 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3610 * attribute.cs, const.cs: Fix bug #58590
3612 2004-05-21 Martin Baulig <martin@ximian.com>
3614 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
3615 out parameters if the end of the method is unreachable. Fixes
3618 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3620 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
3621 Hari was right, why extra method.
3623 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3625 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
3627 2004-05-20 Martin Baulig <martin@ximian.com>
3629 Merged this back from gmcs to keep the differences to a minumum.
3631 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
3632 instead of a Declspace.
3633 (Attribute.ResolveType): Likewise.
3634 (Attributes.Search): Likewise.
3635 (Attributes.Contains): Likewise.
3636 (Attributes.GetClsCompliantAttribute): Likewise.
3638 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
3640 (MethodData.ApplyAttributes): Take an EmitContext instead of a
3643 2004-05-19 Marek Safar <marek.safar@seznam.cz>
3645 Fix bug #58688 (MCS does not report error when the same attribute
3648 * attribute.cs (Attribute.Emit): Distinction between null and default.
3650 2004-05-19 Raja R Harinath <rharinath@novell.com>
3652 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
3653 of a top-level attribute without an attribute target.
3654 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
3656 (Attribute.Conditional_GetConditionName),
3657 (Attribute.Obsolete_GetObsoleteMessage): Update.
3658 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
3659 part of ScanForIndexerName.
3660 (Attribute.CanIgnoreInvalidAttribute): New function.
3661 (Attribute.ScanForIndexerName): Move to ...
3662 (Attributes.ScanForIndexerName): ... here.
3663 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
3664 (Attributes.Search): New internal variant that can choose not to
3665 complain if types aren't resolved. The original signature now
3667 (Attributes.GetClsCompliantAttribute): Use internal variant, with
3668 complaints suppressed.
3669 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
3670 only if it not useful.
3671 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
3672 top-level for attributes that are shared between the assembly
3673 and a top-level class.
3674 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
3675 * class.cs: Update to reflect changes.
3676 (DefineIndexers): Fuse loops.
3677 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
3678 a couple more variants of attribute names.
3680 2004-05-18 Marek Safar <marek.safar@seznam.cz>
3682 Fix bug #52585 (Implemented explicit attribute declaration)
3685 (Attributable.ValidAttributeTargets): New abstract method. It gets
3686 list of valid attribute targets for explicit target declaration.
3687 (Attribute.Target): It holds target itself.
3688 (AttributeSection): Removed.
3689 (Attribute.CheckTargets): New method. It checks whether attribute
3690 target is valid for the current element.
3693 (EventProperty): New class. For events that are declared like
3694 property (with add and remove accessors).
3695 (EventField): New class. For events that are declared like field.
3698 * cs-parser.jay: Implemented explicit attribute target declaration.
3700 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
3701 Override ValidAttributeTargets.
3704 (ReturnParameter): Class for applying custom attributes on
3706 (ParameterAtribute): New class. Class for applying custom
3707 attributes on the parameter type.
3709 2004-05-17 Miguel de Icaza <miguel@ximian.com>
3711 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
3714 (Method): Allow UNSAFE here.
3716 * modifiers.cs: Support unsafe reporting.
3718 2004-05-17 Marek Safar <marek.safar@seznam.cz>
3720 * decl.cs: Fix bug #58478.
3722 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3724 * statement.cs: When checking for unreachable code on an EmptyStatement,
3725 set the location. Fixes bug #58488.
3727 2004-05-13 Miguel de Icaza <miguel@ximian.com>
3729 * driver.cs: Add -pkg handling.
3731 From Gonzalo: UseShelLExecute=false
3733 2004-05-12 Marek Safar <marek.safar@seznam.cz>
3736 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
3738 (Attribute.IsClsCompliaceRequired): Moved to base for better
3740 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
3741 when attribute is AttributeUsageAttribute.
3742 (Attribute.GetValidTargets): Simplified.
3743 (Attribute.GetAttributeUsage): New method returns AttributeUsage
3744 attribute for this type.
3745 (Attribute.ApplyAttributes): Method renamed to Emit and make
3747 (GlobalAttributeSection): New class for special handling of global
3748 attributes (assembly, module).
3749 (AttributeSection.Emit): New method.
3751 * class.cs: Implemented Attributable abstract methods.
3752 (MethodCore.LabelParameters): Moved to Parameter class.
3753 (Accessor): Is back simple class.
3754 (PropertyMethod): Implemented Attributable abstract class.
3755 (DelegateMethod): Implemented Attributable abstract class.
3756 (Event): New constructor for disctintion between normal Event
3757 and Event with accessors.
3759 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
3761 * codegen.cs, const.cs, decl.cs, delegate.cs:
3762 (CommonAssemblyModulClass): Implemented Attributable abstract class
3765 * enum.cs: Implement IAttributeSupport interface.
3766 (EnumMember): New class for emum members. Implemented Attributable
3770 (ParameterBase): Is abstract.
3771 (ReturnParameter): New class for easier [return:] attribute handling.
3773 * typemanager.cs: Removed builder_to_attr.
3775 2004-05-11 Raja R Harinath <rharinath@novell.com>
3778 * attribute.cs (Attribute.GetPositionalValue): New function.
3779 * class.cs (TypeContainer.VerifyMembers): New function.
3780 (TypeContainer.Emit): Use it.
3781 (ClassOrStruct): New base class for Class and Struct.
3782 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
3783 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
3785 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
3786 then each non-static field should have a FieldOffset attribute.
3787 Otherwise, none of the fields should have a FieldOffset attribute.
3788 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
3789 and FieldOffset attributes.
3790 * typemanager.cs (TypeManager.struct_layout_attribute_type)
3791 (TypeManager.field_offset_attribute_type): New core types.
3792 (TypeManager.InitCoreTypes): Initialize them.
3794 2004-05-11 Michal Moskal <malekith@pld-linux.org>
3796 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
3797 Return correct type.
3800 2004-05-09 Miguel de Icaza <miguel@ximian.com>
3802 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
3803 be implicitly converted to ulong.
3805 * expression.cs: The logic for allowing operator &, | and ^ worked
3806 was wrong, it worked before because we did not report an error in
3807 an else branch. Fixes 57895.
3809 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
3810 allow volatile fields to be reference types.
3812 2004-05-07 Miguel de Icaza <miguel@ximian.com>
3814 * driver.cs: Add support for /debug-
3816 2004-05-07 Raja R Harinath <rharinath@novell.com>
3818 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
3819 Add a 'complain' parameter to silence errors.
3820 (Attribute.Resolve): Update to changes. Put in sanity check to catch
3821 silently overlooked type-resolutions.
3822 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
3824 (Attributes.Search): New function.
3825 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
3826 (Attributes.GetAttributeFullName): Remove hack.
3827 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
3828 Update to reflect changes.
3829 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
3830 Use Attributes.Search instead of nested loops.
3832 2004-05-07 Marek Safar <marek.safar@seznam.cz>
3835 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
3836 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
3837 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
3839 * report.cs: (Report.Warning): Renamed to Warning_T because of
3840 parameter collision.
3842 2004-05-05 Raja R Harinath <rharinath@novell.com>
3844 * expression.cs (MemberAccess.ResolveMemberAccess):
3845 Exit with non-zero status after Report.Error.
3846 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
3848 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
3850 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3852 * support.cs: Don't hang when the file is empty.
3854 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3856 * support.cs: In SeekableStreamReader, compute the preamble size of the
3857 underlying stream. Position changes should take into account that initial
3860 2004-05-03 Todd Berman <tberman@sevenl.net>
3862 * driver.cs: remove unused GetSysVersion function.
3864 2004-05-03 Todd Berman <tberman@sevenl.net>
3866 * driver.cs: Remove the hack from saturday, as well as the hack
3867 from jackson (LoadAssemblyFromGac), also adds the CWD to the
3868 link_paths to get that bit proper.
3870 2004-05-01 Todd Berman <tberman@sevenl.net>
3872 * driver.cs: Try a LoadFrom before a Load, this checks the current
3873 path. This is currently a bug in mono that is be fixed, however, this
3874 provides a workaround for now. This will be removed when the bug
3877 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
3879 * CryptoConvert.cs: Updated to latest version. Fix issue with
3880 incomplete key pairs (#57941).
3882 2004-05-01 Todd Berman <tberman@sevenl.net>
3884 * driver.cs: Remove '.' from path_chars, now System.* loads properly
3887 2004-04-30 Jackson Harper <jackson@ximian.com>
3889 * codegen.cs: Open keys readonly.
3891 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3893 * typemanager.cs: don't report cyclic struct layout when a struct
3894 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3895 which has 2 Pango.Rectangle fields.
3897 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3899 * expression.cs: Handle IntPtr comparisons with IL code
3900 rather than a method call.
3902 2004-04-29 Martin Baulig <martin@ximian.com>
3904 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3905 the list of PropertyInfo's in class hierarchy and find the
3906 accessor. Fixes #56013.
3908 2004-04-29 Martin Baulig <martin@ximian.com>
3910 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3912 2004-04-29 Martin Baulig <martin@ximian.com>
3914 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3916 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3918 2004-04-29 Martin Baulig <martin@ximian.com>
3920 * class.cs (ConstructorInitializer.Resolve): Check whether the
3921 parent .ctor is accessible. Fixes #52146.
3923 2004-04-29 Martin Baulig <martin@ximian.com>
3925 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3927 * statement.cs (Using.EmitLocalVariableDecls): Use
3928 TypeManager.idisposable_type, not typeof (IDisposable).
3929 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3931 2004-04-29 Martin Baulig <martin@ximian.com>
3933 * class.cs (Event.Define): Don't emit the field and don't set
3934 RTSpecialName and SpecialName for events on interfaces. Fixes
3937 2004-04-29 Raja R Harinath <rharinath@novell.com>
3939 Refactor Attribute.ApplyAttributes.
3940 * attribute.cs (Attributable): New base class for objects that can
3941 have Attributes applied on them.
3942 (Attribute): Make AttributeUsage fields public.
3943 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3944 (Attribute.IsInternalCall): New property.
3945 (Attribute.UsageAttr): Convert to a public read-only property.
3946 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3947 (Attribute.ResolveType, Attribute.Resolve)
3948 (Attribute.ScanForIndexerName): Update to reflect changes.
3949 (Attribute.CheckAttributeTarget): Re-format.
3950 (Attribute.ApplyAttributes): Refactor, to various
3951 Attributable.ApplyAttributeBuilder methods.
3952 * decl.cs (MemberCore): Make Attributable.
3953 * class.cs (Accessor): Make Attributable.
3954 (MethodData.ApplyAttributes): Use proper attribute types, not
3956 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3957 (TypeContainer.ApplyAttributeBuilder)
3958 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3959 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3960 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3961 (Operator.ApplyAttributeBuilder): New factored-out methods.
3962 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3963 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3964 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3965 * parameter.cs (ParameterBase): New Attributable base class
3966 that can also represent Return types.
3967 (Parameter): Update to the changes.
3969 2004-04-29 Jackson Harper <jackson@ximian.com>
3971 * driver.cs: Prefer the corlib system version when looking for
3972 assemblies in the GAC. This is still a hack, but its a better hack
3975 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3977 * decl.cs, enum.cs: Improved error 3005 reporting.
3979 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3980 (related_symbols): New private member for list of symbols
3981 related to reported error/warning.
3983 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3985 2004-04-29 Martin Baulig <martin@ximian.com>
3987 * ecore.cs (Expression.Constantify): If we're an enum and
3988 TypeManager.TypeToCoreType() doesn't give us another type, use
3989 t.UnderlyingSystemType. Fixes #56178.
3991 2004-04-29 Martin Baulig <martin@ximian.com>
3993 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3994 interfaces and for each interface, only add members directly
3995 declared in that interface. Fixes #53255.
3997 2004-04-28 Martin Baulig <martin@ximian.com>
3999 * expression.cs (ConditionalLogicalOperator): Use a temporary
4000 variable for `left' to avoid that we evaluate it more than once;
4003 2004-04-28 Martin Baulig <martin@ximian.com>
4005 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
4008 2004-04-28 Martin Baulig <martin@ximian.com>
4010 * statement.cs (LocalInfo.Resolve): Check whether the type is not
4013 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
4014 whether the type is not void (CS1547).
4016 2004-04-28 Martin Baulig <martin@ximian.com>
4018 * expression.cs (Unary.DoResolveLValue): Override this and report
4019 CS0131 for anything but Operator.Indirection.
4021 2004-04-28 Martin Baulig <martin@ximian.com>
4023 Committing a patch from Ben Maurer; see bug #50820.
4025 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
4028 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
4031 2004-04-28 Martin Baulig <martin@ximian.com>
4033 Committing a patch from Ben Maurer; see bug #50820.
4035 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
4038 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
4041 2004-04-28 Martin Baulig <martin@ximian.com>
4043 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
4044 (Block.AddLabel): Call DoLookupLabel() to only search in the
4047 2004-04-28 Martin Baulig <martin@ximian.com>
4049 * cfold.cs (ConstantFold.BinaryFold): Added special support for
4050 comparing StringConstants and NullLiterals in Equality and Inequality.
4052 2004-04-28 Jackson Harper <jackson@ximian.com>
4054 * driver.cs: Attempt to load referenced assemblies from the
4055 GAC. This is the quick and dirty version of this method that
4056 doesnt take into account versions and just takes the first
4057 canidate found. Will be good enough for now as we will not have more
4058 then one version installed into the GAC until I update this method.
4060 2004-04-28 Martin Baulig <martin@ximian.com>
4062 * typemanager.cs (TypeManager.CheckStructCycles): New public
4063 static method to check for cycles in the struct layout.
4065 * rootcontext.cs (RootContext.PopulateTypes): Call
4066 TypeManager.CheckStructCycles() for each TypeContainer.
4067 [Note: We only need to visit each type once.]
4069 2004-04-28 Martin Baulig <martin@ximian.com>
4071 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
4073 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
4074 success and added `out object value'. Use a `bool resolved' field
4075 to check whether we've already been called rather than
4076 `ConstantValue != null' since this breaks for NullLiterals.
4078 2004-04-28 Raja R Harinath <rharinath@novell.com>
4080 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
4081 setting of this flag, since the 'set' method may be non-public.
4083 2004-04-28 Raja R Harinath <rharinath@novell.com>
4085 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
4086 check on current_vector.Block.
4088 2004-04-27 Martin Baulig <martin@ximian.com>
4090 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
4091 a field initializer. Fixes #56459.
4093 2004-04-27 Martin Baulig <martin@ximian.com>
4095 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
4096 we're not attempting to use an indexer. Fixes #52154.
4098 2004-04-27 Martin Baulig <martin@ximian.com>
4100 * statement.cs (Return): Don't create a return label if we don't
4101 need it; reverts my change from January 20th. Thanks to Ben
4104 2004-04-27 Martin Baulig <martin@ximian.com>
4106 According to the spec, `goto' can only leave a nested scope, but
4109 * statement.cs (Block.LookupLabel): Only lookup in the current
4110 block, don't recurse into parent or child blocks.
4111 (Block.AddLabel): Check in parent and child blocks, report
4112 CS0140/CS0158 if we find a duplicate.
4113 (Block): Removed this indexer for label lookups.
4114 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
4115 this already does the error reporting for us.
4118 (FlowBranching.UsageVector.Block): New public variable; may be null.
4119 (FlowBranching.CreateSibling): Added `Block' argument.
4120 (FlowBranching.LookupLabel): New public virtual method. Lookup a
4121 label for the target of a `goto' and check whether we're not
4122 leaving a `finally'.
4124 2004-04-27 Martin Baulig <martin@ximian.com>
4126 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
4127 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
4130 2004-04-27 Martin Baulig <martin@ximian.com>
4132 * statement.cs (Block.AddLabel): Also check for implicit blocks
4133 and added a CS0158 check.
4135 2004-04-27 Martin Baulig <martin@ximian.com>
4137 * flowanalysis.cs (FlowBranchingLoop): New class.
4138 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
4139 UsageVector's instead of an ArrayList.
4140 (FlowBranching.Label): Likewise.
4141 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
4142 (FlowBranching.AddBreakVector): New method.
4144 2004-04-27 Miguel de Icaza <miguel@ximian.com>
4146 * attribute.cs: Small regression fix: only convert the type if we
4147 the type is different, fixes System.Drawing build.
4149 2004-04-27 Martin Baulig <martin@ximian.com>
4151 * attribute.cs (Attribute.Resolve): If we have a constant value
4152 for a named field or property, implicity convert it to the correct
4155 2004-04-27 Raja R Harinath <rharinath@novell.com>
4157 * statement.cs (Block.Block): Implicit blocks share
4158 'child_variable_names' fields with parent blocks.
4159 (Block.AddChildVariableNames): Remove.
4160 (Block.AddVariable): Mark variable as "used by a child block" in
4161 every surrounding block.
4162 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
4163 been used in a child block, complain about violation of "Invariant
4164 meaning in blocks" rule.
4165 * cs-parser.jay (declare_local_variables): Don't use
4166 AddChildVariableNames.
4167 (foreach_statement): Don't create an implicit block: 'foreach'
4170 2004-04-23 Miguel de Icaza <miguel@ximian.com>
4172 * convert.cs (ImplicitNumericConversion): 0 is also positive when
4173 converting from 0L to ulong. Fixes 57522.
4175 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4177 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
4178 derived class hides via 'new' keyword field from base class (test-242.cs).
4179 TODO: Handle this in the more general way.
4181 * class.cs (CheckBase): Ditto.
4183 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4185 * decl.cs (caching_flags): New member for storing cached values
4187 (MemberCore.Flags): New enum where bit flags for caching_flags
4189 (MemberCore.cls_compliance): Moved to caching_flags.
4190 (DeclSpace.Created): Moved to caching_flags.
4192 * class.cs: Use caching_flags instead of DeclSpace.Created
4194 2004-04-21 Miguel de Icaza <miguel@ximian.com>
4196 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
4197 if we are only a derived class, not a nested class.
4199 * typemanager.cs: Same as above, but do this at the MemberLookup
4200 level (used by field and methods, properties are handled in
4201 PropertyExpr). Allow for the qualified access if we are a nested
4204 2004-04-21 Marek Safar <marek.safar@seznam.cz>
4206 * class.cs: Refactoring.
4207 (IMethodData): New inteface; Holds links to parent members
4208 to avoid member duplication (reduced memory allocation).
4209 (Method): Implemented IMethodData interface.
4210 (PropertyBase): New inner classes for get/set methods.
4211 (PropertyBase.PropertyMethod): Implemented IMethodData interface
4212 (Event): New inner classes for add/remove methods.
4213 (Event.DelegateMethod): Implemented IMethodData interface.
4215 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
4216 EmitContext (related to class.cs refactoring).
4218 2004-04-21 Raja R Harinath <rharinath@novell.com>
4220 * delegate.cs (Delegate.VerifyApplicability): If the number of
4221 arguments are the same as the number of parameters, first try to
4222 verify applicability ignoring any 'params' modifier on the last
4226 2004-04-16 Raja R Harinath <rharinath@novell.com>
4228 * class.cs (TypeContainer.AddIndexer): Use
4229 'ExplicitInterfaceName' to determine if interface name was
4230 explicitly specified. 'InterfaceType' is not initialized at this time.
4231 (TypeContainer.DefineIndexers): Remove use of temporary list. The
4232 Indexers array is already in the required order. Initialize
4233 'IndexerName' only if there are normal indexers.
4234 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
4235 (TypeContainer.Emit): Emit DefaultMember attribute only if
4236 IndexerName is initialized.
4239 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
4241 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
4244 2004-04-15 Raja R Harinath <rharinath@novell.com>
4246 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
4250 * attribute.cs (Attribute.Resolve): Check for duplicate named
4254 2004-04-15 Miguel de Icaza <miguel@ximian.com>
4256 * iterators.cs (MarkYield): track whether we are in an exception,
4257 and generate code accordingly. Use a temporary value to store the
4258 result for our state.
4260 I had ignored a bit the interaction of try/catch with iterators
4261 since their behavior was not entirely obvious, but now it is
4262 possible to verify that our behavior is the same as MS .NET 2.0
4266 2004-04-14 Miguel de Icaza <miguel@ximian.com>
4268 * iterators.cs: Avoid creating temporaries if there is no work to
4271 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
4272 Enumerations, use TypeManager.EnumToUnderlying and call
4275 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
4278 (This.Emit): Use EmitContext.EmitThis to emit our
4281 (This.EmitAssign): Ditto.
4283 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
4284 codepaths, we will move all the functionality into
4287 (FieldExpr.EmitAssign): Ditto.
4289 This fixes several hidden bugs that I uncovered while doing a code
4290 review of this today.
4292 * codegen.cs (EmitThis): reworked so the semantics are more clear
4293 and also support value types "this" instances.
4295 * iterators.cs: Changed so that for iterators in value types, we
4296 do not pass the value type as a parameter.
4298 Initialization of the enumerator helpers is now done in the caller
4299 instead of passing the parameters to the constructors and having
4300 the constructor set the fields.
4302 The fields have now `assembly' visibility instead of private.
4304 2004-04-11 Miguel de Icaza <miguel@ximian.com>
4306 * expression.cs (Argument.Resolve): Check if fields passed as ref
4307 or out are contained in a MarshalByRefObject.
4309 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
4310 another compiler type.
4312 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
4314 * class.cs (Indexer.Define): use the new name checking method.
4315 Also, return false on an error.
4316 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
4317 (is_identifier_[start/part]_character): make static.
4319 2004-04-10 Miguel de Icaza <miguel@ximian.com>
4321 * expression.cs (Binary.ResolveOperator): Do no append strings
4322 twice: since we can be invoked more than once (array evaluation)
4323 on the same concatenation, take care of this here. Based on a fix
4324 from Ben (bug #56454)
4326 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
4328 * codegen.cs: Fix another case where CS1548 must be reported (when
4329 delay-sign isn't specified and no private is available #56564). Fix
4330 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4331 error when MCS is used on the MS runtime and we need to delay-sign
4332 (which seems unsupported by AssemblyBuilder - see #56621).
4334 2004-04-08 Marek Safar <marek.safar@seznam.cz>
4336 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
4337 (TypeManager.ComputeNamespaces): Faster implementation for
4340 * compiler.csproj: Updated AssemblyName to mcs.
4342 2004-04-07 Miguel de Icaza <miguel@ximian.com>
4344 * rootcontext.cs: Add new types to the boot resolution.
4346 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
4347 MulticastDelegate is not allowed.
4349 * typemanager.cs: Add new types to lookup: System.TypedReference
4352 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
4353 check for TypedReference or ArgIterator, they are not allowed.
4355 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
4356 makes us properly catch 1510 in some conditions (see bug 56016 for
4359 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
4361 * CryptoConvert.cs: update from corlib version
4364 2004-04-05 Miguel de Icaza <miguel@ximian.com>
4366 * class.cs (Indexer.Define): Check indexername declaration
4368 2004-04-05 Marek Safar <marek.safar@seznam.cz>
4370 * attribute.cs (IsClsCompliant): Fixed problem with handling
4371 all three states (compliant, not-compliant, undetected).
4373 2004-03-30 Marek Safar <marek.safar@seznam.cz>
4375 * attribute.cs (Attribute): Location is now public.
4376 (Resolve): Store resolved arguments (pos_values) in attribute class.
4377 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
4378 (GetClsCompliantAttributeValue): New method that gets
4379 CLSCompliantAttribute value.
4380 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
4381 if exists else null.
4382 (AttributeTester): New class for CLS-Compliant verification routines.
4384 * class.cs (Emit): Add CLS-Compliant verification.
4385 (Method.GetSignatureForError): Implemented.
4386 (Constructor.GetSignatureForError): Implemented
4387 (Constructor.HasCompliantArgs): Returns if constructor has
4388 CLS-Compliant arguments.
4389 (Constructor.Emit): Override.
4390 (Construcor.IsIdentifierClsCompliant): New method; For constructors
4391 is needed to test only parameters.
4392 (FieldBase.GetSignatureForError): Implemented.
4393 (TypeContainer): New member for storing base interfaces.
4394 (TypeContainer.FindMembers): Search in base interfaces too.
4396 * codegen.cs (GetClsComplianceAttribute): New method that gets
4397 assembly or module CLSCompliantAttribute value.
4398 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
4400 (ModuleClass.Emit): Add error 3012 test.
4402 * const.cs (Emit): Override and call base for CLS-Compliant tests.
4404 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
4405 state for all decl types.
4406 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
4407 if CLS-Compliant tests are required.
4408 (IsClsCompliaceRequired): New method. Analyze whether code
4409 must be CLS-Compliant.
4410 (IsExposedFromAssembly): New method. Returns true when MemberCore
4411 is exposed from assembly.
4412 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
4413 value or gets cached value.
4414 (HasClsCompliantAttribute): New method. Returns true if MemberCore
4415 is explicitly marked with CLSCompliantAttribute.
4416 (IsIdentifierClsCompliant): New abstract method. This method is
4417 used to testing error 3005.
4418 (IsIdentifierAndParamClsCompliant): New method. Common helper method
4419 for identifier and parameters CLS-Compliant testing.
4420 (VerifyClsCompliance): New method. The main virtual method for
4421 CLS-Compliant verifications.
4422 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
4423 null. I don't know why is null (too many public members !).
4424 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
4425 and get value of first CLSCompliantAttribute that found.
4427 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
4428 (VerifyClsCompliance): Override and add extra tests.
4430 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
4431 clscheck- disable CLS-Compliant verification event if assembly is has
4432 CLSCompliantAttribute(true).
4434 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
4435 ApllyAttribute is now called in emit section as in the other cases.
4436 Possible future Emit integration.
4437 (IsIdentifierClsCompliant): New override.
4438 (VerifyClsCompliance): New override.
4439 (GetEnumeratorName): Returns full enum name.
4441 * parameter.cs (GetSignatureForError): Implemented.
4443 * report.cs (WarningData): New struct for Warning message information.
4444 (LocationOfPreviousError): New method.
4445 (Warning): New method. Reports warning based on the warning table.
4446 (Error_T): New method. Reports error based on the error table.
4448 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
4449 verifications are done here.
4451 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
4453 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
4454 CLSCompliantAttribute.
4455 (all_imported_types): New member holds all imported types from other
4457 (LoadAllImportedTypes): New method fills static table with exported types
4458 from all referenced assemblies.
4459 (Modules): New property returns all assembly modules.
4461 2004-03-30 Miguel de Icaza <miguel@ximian.com>
4463 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
4464 throwing a parser error.
4466 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
4467 which removes the hardcoded get_/set_ prefixes for properties, as
4468 IL allows for the properties to be named something else.
4472 * expression.cs: Do not override operand before we know if it is
4475 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4477 * typemanager.cs: support for pinned variables.
4479 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4481 * decl.cs, typemanager.cs: Avoid using an arraylist
4482 as a buffer if there is only one result set.
4484 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4486 * expression.cs: Make sure you cant call a static method
4487 with an instance expression, bug #56174.
4489 2004-03-29 Miguel de Icaza <miguel@ximian.com>
4491 * class.cs (IsDuplicateImplementation): Improve error reporting to
4492 flag 663 (method only differs in parameter modifier).
4494 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
4495 in preprocessor directives.
4497 * location.cs (LookupFile): Allow for the empty path.
4499 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
4500 better approach for some of that patch, but its failing with the
4501 CharSet enumeration. For now try/catch will do.
4503 * typemanager.cs: Do not crash if a struct does not have fields.
4506 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4508 * expression.cs: cs0213, cant fix a fixed expression.
4511 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4513 * cs-parser.jay: detect invalid embeded statements gracefully.
4516 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4518 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
4521 the invocation type may not be a subclass of the tye of the item/
4522 The type of the item must be a subclass of the invocation item.
4527 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
4529 * attribute.cs: Added methods to get a string and a bool from an
4530 attribute. Required to information from AssemblyKeyFileAttribute,
4531 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
4532 * codegen.cs: Modified AssemblyName creation to include support for
4533 strongnames. Catch additional exceptions to report them as CS1548.
4534 * compiler.csproj: Updated include CryptoConvert.cs.
4535 * compiler.csproj.user: Removed file - user specific configuration.
4536 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
4537 Mono.Security assembly. The original class is maintained and tested in
4538 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
4539 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
4540 like CSC 8.0 (C# v2) supports.
4541 * Makefile: Added CryptoConvert.cs to mcs sources.
4542 * rootcontext.cs: Added new options for strongnames.
4544 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
4546 * driver.cs: For --expect-error, report error code `2'
4547 if the program compiled with no errors, error code `1' if
4548 it compiled with an error other than the one expected.
4550 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
4552 * compiler.csproj: Updated for Visual Studio .NET 2003.
4553 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
4554 * compiler.sln: Updated for Visual Studio .NET 2003.
4556 2004-03-24 Ravi Pratap M <ravi@ximian.com>
4558 * expression.cs: Fix bug #47234. We basically need to apply the
4559 rule that we prefer the conversion of null to a reference type
4560 when faced with a conversion to 'object' (csc behaviour).
4562 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4564 * statement.cs: Shorter form for foreach, eliminates
4565 a local variable. r=Martin.
4567 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4569 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
4570 checks if we can use brtrue/brfalse to test for 0.
4571 * expression.cs: use the above in the test for using brtrue/brfalse.
4574 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4576 * expression.cs: Rewrite string concat stuff. Benefits:
4578 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
4579 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
4580 rather than a concat chain.
4582 * typemanager.cs: Add lookups for more concat overloads.
4584 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4586 * expression.cs: Emit shorter il code for array init.
4603 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
4605 * statement.cs: Before, two switch blocks would be merged if the
4606 total size of the blocks (end_item - begin_item + 1) was less than
4607 two times the combined sizes of the blocks.
4609 Now, it will only merge if after the merge at least half of the
4614 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
4616 * class.cs : csc build fix for GetMethods(). See bug #52503.
4618 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
4620 * expression.cs: Make sure fp comparisons work with NaN.
4621 This fixes bug #54303. Mig approved this patch a long
4622 time ago, but we were not able to test b/c the runtime
4625 2004-03-19 Miguel de Icaza <miguel@ximian.com>
4627 * ecore.cs (TypExpr.GetHashCode): implement this overload.
4629 2004-03-19 Martin Baulig <martin@ximian.com>
4631 * class.cs (MemberCore.IsDuplicateImplementation): Report the
4632 error here and not in our caller.
4634 2004-03-19 Martin Baulig <martin@ximian.com>
4636 * interface.cs: Completely killed this file.
4637 (Interface): We're now a TypeContainer and live in class.cs.
4639 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4640 argument; we're now also called for interfaces.
4641 (TypeContainer.DefineMembers): Allow this method being called
4643 (TypeContainer.GetMethods): New public method; formerly known as
4644 Interface.GetMethod(). This is used by PendingImplementation.
4645 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4646 it's now private and non-static.
4647 (Interface): Moved this here; it's now implemented similar to
4649 (Method, Property, Event, Indexer): Added `bool is_interface'
4650 argument to their .ctor's.
4651 (MemberBase.IsInterface): New public field.
4653 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4654 instances instead of InterfaceMethod, InterfaceProperty, etc.
4655 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4656 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4658 2004-03-19 Martin Baulig <martin@ximian.com>
4660 * class.cs (MethodCore.IsDuplicateImplementation): New private
4661 method which does the CS0111 checking.
4662 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4663 Use IsDuplicateImplementation().
4665 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4667 * decl.cs (FindMemberToOverride): New method to find the correct
4668 method or property to override in the base class.
4670 - Make Method/Property use the above method to find the
4671 version in the base class.
4672 - Remove the InheritableMemberSignatureCompare as it is now
4675 This patch makes large code bases much faster to compile, as it is
4676 O(n) rather than O(n^2) to do this validation.
4678 Also, it fixes bug 52458 which is that nested classes are not
4679 taken into account when finding the base class member.
4681 Reviewed/Approved by Martin.
4683 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4685 * interface.cs: In all interface classes removed redundant
4686 member initialization.
4688 2004-03-16 Martin Baulig <martin@ximian.com>
4690 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4692 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4694 * decl.cs (DefineTypeAndParents): New helper method to define a
4695 type's containers before the type itself is defined; This is a
4696 bug exposed by the recent changes to Windows.Forms when an
4697 implemented interface was defined inside a class that had not been
4700 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4702 (Check): Loop correctly to report errors modifiers
4703 (UNSAFE was not in the loop, since it was the same as TOP).
4705 * interface.cs: Every interface member now takes a ModFlags,
4706 instead of a "is_new" bool, which we set on the base MemberCore.
4708 Every place where we called "UnsafeOk" in the interface, now we
4709 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4710 the unsafe settings from the member declaration instead of the
4711 container interface.
4713 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4715 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4716 `set_indexer_name' to the pending bits (one per type).
4718 We fixed a bug today that was picking the wrong method to
4719 override, since for properties the existing InterfaceMethod code
4720 basically ignored the method name. Now we make sure that the
4721 method name is one of the valid indexer names.
4723 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4725 * support.cs (SeekableStreamReader): Keep track of stream byte
4726 positions and don't mix them with character offsets to the buffer.
4728 Patch from Gustavo Giráldez
4730 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4732 * interface.cs (InterfaceSetGetBase): Removed double member
4733 initialization, base class does it as well.
4735 2004-03-13 Martin Baulig <martin@ximian.com>
4737 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4738 when compiling corlib.
4740 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4742 * convert.cs (ExplicitConversion): We were reporting an error on
4743 certain conversions (object_type source to a value type, when the
4744 expression was `null') before we had a chance to pass it through
4745 the user defined conversions.
4747 * driver.cs: Replace / and \ in resource specifications to dots.
4750 * class.cs: Add check for duplicate operators. Fixes 52477
4752 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4754 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4755 that are in the middle of the statements, not only at the end.
4758 * class.cs (TypeContainer.AddField): No longer set the
4759 `HaveStaticConstructor' flag, now we call it
4760 `UserDefineStaticConstructor' to diferentiate the slightly
4761 semantic difference.
4763 The situation is that we were not adding BeforeFieldInit (from
4764 Modifiers.TypeAttr) to classes that could have it.
4765 BeforeFieldInit should be set to classes that have no static
4770 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4772 And most importantly Zoltan's comment:
4774 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4776 "I think beforefieldinit means 'it's ok to initialize the type sometime
4777 before its static fields are used', i.e. initialization does not need
4778 to be triggered by the first access to the type. Setting this flag
4779 helps the JIT to compile better code, since it can run the static
4780 constructor at JIT time, and does not need to generate code to call it
4781 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4782 this flag for lots of classes like String.
4784 csc sets this flag if the type does not have an explicit static
4785 constructor. The reasoning seems to be that if there are only static
4786 initalizers for a type, and no static constructor, then the programmer
4787 does not care when this initialization happens, so beforefieldinit
4790 This bug prevents the AOT compiler from being usable, since it
4791 generates so many calls to mono_runtime_class_init that the AOT code
4792 is much slower than the JITted code. The JITted code is faster,
4793 because it does not generate these calls if the vtable is type is
4794 already initialized, which is true in the majority of cases. But the
4795 AOT compiler can't do this."
4797 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4799 * class.cs (MethodData.Emit): Refactor the code so symbolic
4800 information is generated for destructors; For some reasons we
4801 were taking a code path that did not generate symbolic information
4804 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4806 * class.cs: Create a Constructor.CheckBase method that
4807 takes care of all validation type code. The method
4808 contains some code that was moved from Define.
4810 It also includes new code that checks for duplicate ctors.
4811 This fixes bug #55148.
4813 2004-03-09 Joshua Tauberer <tauberer@for.net>
4815 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4816 a { ... }-style array creation invokes EmitStaticInitializers
4817 which is not good for reference-type arrays. String, decimal
4818 and now null constants (NullCast) are not counted toward
4819 static initializers.
4821 2004-03-05 Martin Baulig <martin@ximian.com>
4823 * location.cs (SourceFile.HasLineDirective): New public field;
4824 specifies whether the file contains or is referenced by a "#line"
4826 (Location.DefineSymbolDocuments): Ignore source files which
4827 either contain or are referenced by a "#line" directive.
4829 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4831 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4832 direct access to our parent, so check the method inline there.
4834 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4836 * expression.cs (Invocation.EmitCall): Miguel's last commit
4837 caused a regression. If you had:
4842 In Foo the implict this would be null.
4844 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4846 * expression.cs (Invocation.EmitCall): If the method is not
4847 virtual, do not emit a CallVirt to it, use Call.
4849 * typemanager.cs (GetFullNameSignature): Improve the method to
4850 cope with ".ctor" and replace it with the type name.
4852 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4853 as an argument the ConstructorBuilder where it is being defined,
4854 to catch the recursive constructor invocations.
4856 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4858 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4859 routines to check if a type is an enumerable/enumerator allow
4860 classes that implement the IEnumerable or IEnumerator interfaces.
4862 * class.cs (Property, Operator): Implement IIteratorContainer, and
4863 implement SetYields.
4865 (Property.Define): Do the block swapping for get_methods in the
4866 context of iterators. We need to check if Properties also
4867 include indexers or not.
4869 (Operator): Assign the Block before invoking the
4870 OperatorMethod.Define, so we can trigger the Iterator code
4873 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4874 Property and Operator classes are not created when we parse the
4875 declarator but until we have the block completed, so we use a
4876 singleton SimpleIteratorContainer.Simple to flag whether the
4877 SetYields has been invoked.
4879 We propagate this setting then to the Property or the Operator to
4880 allow the `yield' to function.
4882 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4884 * codegen.cs: Implemented attribute support for modules.
4885 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4886 Assembly/Module functionality.
4888 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4889 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4890 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4892 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4894 * interface.cs (FindMembers): The operation is performed on all base
4895 interfaces and not only on the first. It is required for future CLS Compliance patch.
4897 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4899 * statement.cs, codegen.cs:
4900 This patch deals with patterns such as:
4902 public class List : IEnumerable {
4904 public MyEnumerator GetEnumerator () {
4905 return new MyEnumerator(this);
4908 IEnumerator IEnumerable.GetEnumerator () {
4912 public struct MyEnumerator : IEnumerator {
4917 Before, there were a few things we did wrong:
4918 1) we would emit callvirt on a struct, which is illegal
4919 2) we emited ldarg when we needed to emit ldarga
4920 3) we would mistakenly call the interface methods on an enumerator
4921 type that derived from IEnumerator and was in another assembly. For example:
4923 public class MyEnumerator : IEnumerator
4925 Would have the interface methods called, even if there were public impls of the
4926 method. In a struct, this lead to invalid IL code.
4928 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4930 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4933 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4935 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4937 * cs-parser.jay: Fix small regression: we were not testing V2
4938 compiler features correctly.
4940 * interface.cs: If the emit context is null, then create one
4942 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4944 * decl.cs (GetSignatureForError): New virtual method to get full name
4947 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4948 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4950 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4951 Duplicated members and code in these classes has been removed.
4952 Better encapsulation in these classes.
4954 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4956 * assign.cs (Assign.DoResolve): When dealing with compound
4957 assignments, there is a new rule in ECMA C# 2.4 (might have been
4958 there before, but it is documented here) that states that in:
4962 If b is of type int, and the `op' is a shift-operator, then the
4963 above is evaluated as:
4967 * expression.cs (Binary.ResolveOperator): Instead of testing for
4968 int/uint/long/ulong, try to implicitly convert to any of those
4969 types and use that in pointer arithmetic.
4971 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4972 method to print information for from the type, not from the
4973 null-method we were given.
4975 2004-02-01 Duncan Mak <duncan@ximian.com>
4977 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4978 parsing for cmd, fixes bug #53694.
4980 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4982 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4983 in the member name duplication tests. Property and operator name duplication
4984 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4986 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4988 * interface.cs (PopulateMethod): Fixed crash when interface method
4989 returns not existing type (error test cs0246-3.cs).
4991 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4993 * cs-parser.jay (interface_accessors): Re-write actions to also
4994 store attributes attached to get and set methods. Fix spelling
4997 (inteface_property_declaration): Modify accordingly.
4999 (InterfaceAccessorInfo): New helper class to store information to pass
5000 around between rules that use interface_accessors.
5002 * interface.cs (Emit): Apply attributes on the get and set
5003 accessors of properties and indexers too.
5005 * attribute.cs (ApplyAttributes): Modify accordingly to use the
5006 right MethodBuilder when applying attributes to the get and set accessors.
5008 2004-01-31 Miguel de Icaza <miguel@ximian.com>
5010 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
5012 2004-01-26 Miguel de Icaza <miguel@ximian.com>
5014 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
5016 2004-01-25 Miguel de Icaza <miguel@ximian.com>
5018 * cs-parser.jay: Remove YIELD token, instead use the new grammar
5019 changes that treat `yield' specially when present before `break'
5022 * cs-tokenizer.cs: yield is no longer a keyword.
5024 2004-01-23 Marek Safar <marek.safar@seznam.cz>
5026 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
5027 setting for default constructors.
5028 For default constructors are almost every time set wrong Modifier. The
5029 generated IL code has been alright. But inside mcs this values was
5030 wrong and this was reason why several of my CLS Compliance tests
5033 2004-01-22 Martin Baulig <martin@ximian.com>
5035 * cs-parser.jay (namespace_or_type_name): Return an Expression,
5036 not a QualifiedIdentifier. This is what `type_name_expression'
5037 was previously doing.
5038 (type_name_expression): Removed; the code is now in
5039 `namespace_or_type_name'.
5040 (qualified_identifier): Removed, use `namespace_or_type_name'
5042 (QualifiedIdentifier): Removed this class.
5044 2004-01-22 Martin Baulig <martin@ximian.com>
5046 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
5047 not a string as alias name.
5049 2004-01-21 Miguel de Icaza <miguel@ximian.com>
5051 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
5052 #52730 bug, and instead compute correctly the need to use a
5053 temporary variable when requesting an address based on the
5054 static/instace modified of the field and the constructor.
5056 2004-01-21 Martin Baulig <martin@ximian.com>
5058 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
5059 class and namespace before looking up aliases. Fixes #52517.
5061 2004-01-21 Martin Baulig <martin@ximian.com>
5063 * flowanalysis.cs (UsageVector.Merge): Allow variables being
5064 assinged in a 'try'; fixes exception4.cs.
5066 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5067 * class.cs : Implemented parameter-less constructor for TypeContainer
5069 * decl.cs: Attributes are now stored here. New property OptAttributes
5071 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
5073 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
5075 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5077 * typemanager.cs (CSharpSignature): Now reports also inner class name.
5078 (CSharpSignature): New method for indexer and property signature.
5080 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5082 * pending.cs (IsVirtualFilter): Faster implementation.
5084 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5086 * typemanager.cs: Avoid inclusion of same assembly more than once.
5088 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5090 * cs-parser.jay: Fixed problem where the last assembly attribute
5091 has been applied also to following declaration (class, struct, etc.)
5093 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5095 * class.cs: Added error CS0538, CS0539 reporting.
5096 Fixed crash on Microsoft runtime when field type is void.
5098 * cs-parser.jay: Added error CS0537 reporting.
5100 * pending.cs: Added error CS0535 reporting.
5101 Improved error report for errors CS0536, CS0534.
5103 2004-01-20 Miguel de Icaza <miguel@ximian.com>
5105 Merge a few bits from the Anonymous Method MCS tree.
5107 * statement.cs (ToplevelBlock): New class for toplevel methods,
5108 will hold anonymous methods, lifted variables.
5110 * cs-parser.jay: Create toplevel blocks for delegates and for
5111 regular blocks of code.
5113 2004-01-20 Martin Baulig <martin@ximian.com>
5115 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
5116 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
5117 and `NeedExplicitReturn'; added `IsLastStatement'.
5118 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
5119 have a `ReturnLabel' or we're not unreachable.
5121 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
5122 child's reachability; don't just override ours with it. Fixes
5123 #58058 (lluis's example).
5124 (FlowBranching): Added public InTryOrCatch(), InCatch(),
5125 InFinally(), InLoop(), InSwitch() and
5126 BreakCrossesTryCatchBoundary() methods.
5128 * statement.cs (Return): Do all error checking in Resolve().
5129 Unless we are the last statement in a top-level block, always
5130 create a return label and jump to it.
5131 (Break, Continue): Do all error checking in Resolve(); also make
5132 sure we aren't leaving a `finally'.
5133 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
5134 statement in a top-level block.
5135 (Block.Flags): Added `IsDestructor'.
5136 (Block.IsDestructor): New public property.
5138 2004-01-20 Martin Baulig <martin@ximian.com>
5140 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
5142 2004-01-20 Martin Baulig <martin@ximian.com>
5144 * statement.cs (Statement.ResolveUnreachable): New public method.
5145 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
5146 (Block.Resolve): Resolve unreachable statements.
5148 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
5150 * expression.cs: We need to fix the case where we do
5151 not have a temp variable here.
5153 * assign.cs: Only expression compound assignments need
5154 temporary variables.
5156 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
5158 * flowanalysis.cs: Reduce memory allocation in a few ways:
5159 - A block with no variables should not allocate a bit
5161 - A method with no out parameters does not need any tracking
5162 for assignment of the parameters, so we need not allocate
5165 public readonly Type[] VariableTypes;
5166 public readonly string[] VariableNames;
5167 Are redundant. The data is already stored in the variable
5168 map, so we need not allocate another array for it.
5169 - We need to add alot of checks for if (params | locals) == null
5170 due to the first two changes.
5172 2004-01-18 Miguel de Icaza <miguel@ximian.com>
5174 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
5175 implement IMemoryLocation, we store a copy on a local variable and
5176 take the address of it. Patch from Benjamin Jemlich
5178 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
5179 to use a special "type_name_expression" rule which reduces the
5180 number of "QualifiedIdentifier" classes created, and instead
5181 directly creates MemberAccess expressions.
5183 2004-01-17 Miguel de Icaza <miguel@ximian.com>
5185 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
5186 that fixes #52853. Null literal assignment to ValueType
5188 * class.cs (MethodData.Emit): Instead of checking the name of the
5189 method to determine if its a destructor, create a new derived
5190 class from Method called Destructor, and test for that.
5192 * cs-parser.jay: Create a Destructor object instead of a Method.
5194 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
5198 2004-01-16 Miguel de Icaza <miguel@ximian.com>
5200 * expression.cs (Binary.ResolveOperator): Perform an implicit
5201 conversion from MethodGroups to their delegate types on the
5204 * delegate.cs: Introduce a new class DelegateCreation that is the
5205 base class for `NewDelegate' and `ImplicitDelegateCreation',
5206 factor some code in here.
5208 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
5209 conversion from MethodGroups to compatible delegate types.
5211 * ecore.cs (Expression.Resolve): Do not flag error 654
5212 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
5213 we allow conversions from MethodGroups to delegate types now.
5215 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
5216 assignments in v2 either.
5218 2004-01-10 Miguel de Icaza <miguel@ximian.com>
5220 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
5221 static read-only fields in ctors.
5223 Applied patch from Benjamin Jemlich
5225 * expression.cs (UnaryMutator): Avoid leaking local variables.
5227 2004-01-09 Miguel de Icaza <miguel@ximian.com>
5229 * cs-tokenizer.cs (IsCastToken): Allow the various native types
5230 here to return true, as they can be used like this:
5234 Fixed 49836 and all the other dups
5236 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
5238 * driver.cs: Implement /win32res and /win32icon.
5240 2004-01-08 Miguel de Icaza <miguel@ximian.com>
5242 * cs-parser.jay: Add a rule to improve error handling for the
5243 common mistake of placing modifiers after the type.
5245 2004-01-07 Miguel de Icaza <miguel@ximian.com>
5247 * cs-parser.jay (interface_event_declaration): Catch
5248 initialization of events on interfaces, and report cs0068
5250 * cs-parser.jay (interface_event_declaration): Catch
5251 initialization of events.
5253 * ecore.cs: Better report missing constructors.
5255 * expression.cs (Binary.ResolveOperator): My previous bug fix had
5256 the error reporting done in the wrong place. Fix.
5258 * expression.cs (Binary.ResolveOperator): Catch the
5259 operator + (E x, E y) error earlier, and later allow for implicit
5260 conversions in operator +/- (E e, U x) from U to the underlying
5263 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
5264 52596, if the container class is abstract, the default constructor
5265 is protected otherwise its public (before, we were always public).
5267 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
5270 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
5271 Jemlich that fixes bug #52597, MCS was generating invalid code for
5272 idisposable structs. Thanks to Ben for following up with this
5275 2004-01-06 Miguel de Icaza <miguel@ximian.com>
5277 * driver.cs: Allow assemblies without code to be generated, fixes
5280 2004-01-07 Nick Drochak <ndrochak@gol.com>
5282 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
5284 2004-01-05 Miguel de Icaza <miguel@ximian.com>
5286 * cs-parser.jay: Add rules to improve error reporting if fields or
5287 methods are declared at the namespace level (error 116)
5289 * Add rules to catch event add/remove
5291 2004-01-04 David Sheldon <dave-mono@earth.li>
5293 * expression.cs: Added matching ")" to error message for
5296 2004-01-03 Todd Berman <tberman@gentoo.org>
5298 * ecore.cs, attribute.cs:
5299 Applying fix from #52429.
5301 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5303 * ecore.cs, expression.cs, statement.cs:
5304 Total rewrite of how we handle branching. We
5305 now handle complex boolean expressions with fewer
5306 jumps. As well if (x == 0) no longer emits a ceq.
5308 if (x is Foo) is much faster now, because we generate
5311 Overall, we get a pretty big improvement on our benchmark
5312 tests. The code we generate is smaller and more readable.
5314 I did a full two-stage bootstrap. The patch was reviewed
5315 by Martin and Miguel.
5317 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5319 * cs-parser.jay: Make primary_expression not take a QI.
5320 we dont need this because the member_access rule covers
5321 us here. So we replace the rule with just IDENTIFIER.
5323 This has two good effects. First, we remove a s/r conflict.
5324 Second, we allocate many fewer QualifiedIdentifier objects.
5326 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5328 * attribute.cs: Handle MarshalAs attributes as pseudo, and
5329 set the correct information via SRE. This prevents
5330 hanging on the MS runtime. Fixes #29374.
5332 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5334 * convert.cs: correctly handle conversions to value types
5335 from Enum and ValueType as unboxing conversions.
5337 Fixes bug #52569. Patch by Benjamin Jemlich.
5339 2004-01-02 Ravi Pratap <ravi@ximian.com>
5341 * expression.cs (BetterConversion): Prefer int -> uint
5342 over int -> ulong (csc's behaviour). This fixed bug #52046.
5344 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
5346 * decl.cs (MemberCache.FindMembers): now returns a
5349 * typemanager.cs: In general, go with with ^^.
5350 (CopyNewMethods): take an IList.
5351 (RealMemberLookup): Only allocate an arraylist
5352 if we copy from two sets of methods.
5354 This change basically does two things:
5355 1) Fewer array lists allocated due to CopyNewMethods.
5356 2) the explicit cast in MemberList costed ALOT.
5358 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
5360 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
5361 a hashtable to avoid needless string allocations when an identifier is
5362 used more than once (the common case).
5364 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5366 * pending.cs: MS's TypeBuilder.GetInterfaces ()
5367 is broken, it will not return anything. So, we
5368 have to use the information we have in mcs to
5371 * typemanager.cs: Add a cache for GetInterfaces,
5372 since this will now be used more often (due to ^^)
5374 (GetExplicitInterfaces) New method that gets the
5375 declared, not effective, interfaces on a type
5376 builder (eg, if you have interface IFoo, interface
5377 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
5380 This patch makes MCS able to bootstrap itself on
5383 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5385 * expression.cs: Remove the Nop's that Miguel put
5388 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5390 * report.cs, codegen.cs: Give the real stack trace to
5391 the error when an exception is thrown.
5393 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5395 * decl.cs: only allocate hashtables for ifaces if
5398 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5400 * expression.cs: fix the error from cs0121-2.cs
5401 (a parent interface has two child interfaces that
5402 have a function with the same name and 0 params
5403 and the function is called through the parent).
5405 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
5407 * class.cs, rootcontext.cs, typmanager.cs: do not
5410 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
5412 * codegen.cs: remove stack for the ec flow branching.
5413 It is already a linked list, so no need.
5415 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
5417 * Makefile: Allow custom profiler here.
5419 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5421 * typemanager.cs (LookupType):
5422 - Use a static char [], because split takes
5423 a param array for args, so it was allocating
5425 - Do not store true in a hashtable, it boxes.
5427 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5429 * flowanalysis.cs: bytify common enums.
5431 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5433 * modifiers.cs: Add a new set of flags for the
5434 flags allowed on explicit interface impls.
5435 * cs-parser.jay: catch the use of modifiers in
5436 interfaces correctly.
5437 * class.cs: catch private void IFoo.Blah ().
5439 All related to bug #50572.
5441 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5443 * decl.cs: Rewrite the consistant accessability checking.
5444 Accessability is not linear, it must be implemented in
5445 a tableish way. Fixes #49704.
5447 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5449 * expression.cs: Handle negation in a checked context.
5450 We must use subtraction from zero. Fixes #38674.
5452 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5454 * class.cs: Ignore static void main in DLLs.
5455 * rootcontext.cs: Handle the target type here,
5456 since we are have to access it from class.cs
5457 * driver.cs: account for the above.
5459 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5461 * report.cs: Give line numbers and files if available.
5463 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
5465 * driver.cs: Implement /addmodule.
5467 * typemanager.cs: Change 'modules' field so it now contains Modules not
5470 2003-12-20 Martin Baulig <martin@ximian.com>
5472 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
5473 (FieldBase.IsAssigned): Removed this field.
5474 (FieldBase.SetAssigned): New public method.
5475 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
5477 2003-12-20 Martin Baulig <martin@ximian.com>
5479 * expression.cs (LocalVariableReference.DoResolve): Don't set
5480 `vi.Used' if we're called from DoResolveLValue().
5482 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
5483 returns the usage vector it just merged into the current one -
5484 pass this one to UsageWarning().
5485 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
5486 of the `EmitContext', don't call this recursively on our children.
5488 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
5490 * driver.cs: Implement /target:module.
5492 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
5494 * support.cs (CharArrayHashtable): New helper class.
5496 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
5497 char arrays, not strings, so we can avoid creating a string in
5498 consume_identifier if the identifier is a keyword.
5500 2003-12-16 Martin Baulig <martin@ximian.com>
5502 * statement.cs (LocalInfo.Assigned): Removed this property.
5503 (LocalInfo.Flags): Removed `Assigned'.
5504 (LocalInfo.IsAssigned): New public method; takes the EmitContext
5505 and uses flow analysis.
5506 (Block.UsageWarning): Made this method private.
5507 (Block.Resolve): Call UsageWarning() if appropriate.
5509 * expression.cs (LocalVariableReference.DoResolve): Always set
5510 LocalInfo.Used here.
5512 2003-12-13 Martin Baulig <martin@ximian.com>
5514 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
5515 any value here; we're now using flow analysis to figure out
5516 whether a statement/block returns a value.
5518 2003-12-13 Martin Baulig <martin@ximian.com>
5520 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
5522 (FlowBranching.MergeFinally): Don't call
5523 `branching.CheckOutParameters()' here, this is called in
5525 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
5526 when adding the `finally' vector.
5528 2003-12-13 Martin Baulig <martin@ximian.com>
5531 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
5532 actually work and also fix #48962.
5534 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
5536 * decl.cs: Do not check System.Object for nested types,
5537 since we know it does not have any. Big bang for buck:
5542 corlib: 17.99 seconds
5546 corlib: 17.39 seconds
5548 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5550 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5551 time we are returning 0 members, so we save alot here.
5553 2003-12-11 Martin Baulig <martin@ximian.com>
5555 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5556 `MergeChild()', also just take the `FlowBranching' as argument;
5557 call Merge() on it and return the result.
5558 (FlowBranching.Merge): We don't need to do anything if we just
5561 2003-12-11 Martin Baulig <martin@ximian.com>
5563 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5564 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5565 Maurer for this idea.
5567 2003-12-11 Martin Baulig <martin@ximian.com>
5569 * flowanalysis.cs (MergeResult): This class is now gone; we now
5570 use the `UsageVector' for this. The reason for this is that if a
5571 branching just has one sibling, we don't need to "merge" them at
5572 all - that's the next step to do.
5573 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5576 2003-12-11 Martin Baulig <martin@ximian.com>
5578 Reworked flow analyis and made it more precise and bug-free. The
5579 most important change is that we're now using a special `Reachability'
5580 class instead of having "magic" meanings of `FlowReturns'. I'll
5581 do some more cleanups and optimizations and also add some more
5582 documentation this week.
5584 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5585 largely reworked this class.
5586 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5587 the new `Reachability' class instead of having "magic" values here.
5588 (FlowBranching): We're now using an instance of `Reachability'
5589 instead of having separate `Returns', `Breaks' etc. fields.
5591 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5592 based on flow analysis; ignore the return value of block.Emit ().
5594 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5596 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5597 if they are private.
5599 2003-12-09 Martin Baulig <martin@ximian.com>
5601 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5602 call them directly on the UsageVector.
5604 2003-12-09 Martin Baulig <martin@ximian.com>
5606 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5607 Changed return type from `FlowReturns' to `Reachability'.
5609 2003-12-09 Martin Baulig <martin@ximian.com>
5611 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5612 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5613 `Reachable' fields with a single `Reachability' one.
5615 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5617 * class.cs (FindMembers): Remove foreach's.
5630 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5635 This patch does a few things:
5636 1. EmptyStatement is now a singleton, so it is never reallocated.
5637 2. All blah is EmptyStatement constructs have been changed to
5638 blah == EmptyStatement.Value, which is much faster and valid
5639 now that EmptyStatement is a singleton.
5640 3. When resolving a block, rather than allocating a new array for
5641 the non-empty statements, empty statements are replaced with
5642 EmptyStatement.Value
5643 4. Some recursive functions have been made non-recursive.
5644 Mainly the performance impact is from (3), however (1) and (2) are needed for
5645 this to work. (4) does not make a big difference in normal situations, however
5646 it makes the profile look saner.
5651 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5652 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5653 Total memory allocated: 56397 KB
5656 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5657 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5658 Total memory allocated: 55666 KB
5660 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5662 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5663 than the hashtable in a hashtable version
5665 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5666 we always end up concating a string. This results in a huge perf
5667 loss, because many strings have to be tracked by the GC. In this
5668 patch, we first use a hashtable that works with two keys, so that
5669 the strings do not need to be concat'ed.
5680 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5682 * Makefile: Add a new target `do-time' that does a quick and simple
5683 profile, leaving easy to parse output.
5685 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5687 * codegen.cs (Init): Create the dynamic assembly with
5688 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5690 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5692 * support.cs: Make the PtrHashtable use only one
5693 instance of its comparer.
5695 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5697 * typemanager.cs: Fix lookup of GetNamespaces.
5699 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5701 * expression.cs: Removed redundant line.
5703 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5704 ArrayLists, use for loops with bounds.
5706 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5709 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5710 arraylists, use for loop with bounds.
5712 The above three changes give us a 0.071 second performance
5713 improvement out of 3.294 seconds down to 3.223. On my machine
5714 the above changes reduced the memory usage by 1,387 KB during
5717 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5718 QualifiedIdentifiers. Before we created a new string through
5719 concatenation, and mostly later on, the result would be
5720 manipulated by DecomposeQI through string manipulation.
5722 This reduced the compiler memory usage for bootstrapping from
5723 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5724 compile times in 0.05 seconds.
5726 2003-11-28 Dick Porter <dick@ximian.com>
5728 * support.cs: Do string compares with the Invariant culture.
5736 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5737 the comparison is done with the Invariant culture.
5739 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5741 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5742 GetEnumerator method.
5744 (ProbeCollectionType): Iterate starting at the most specific type
5745 upwards looking for a GetEnumerator
5747 * expression.cs: Shift count can be up to 31 for int/uint and 63
5750 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5752 * statement.cs (Block.LookupLabel): Also look for the label on the
5753 children blocks. Use a hash table to keep track of visited
5756 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5757 we actually did transform the other operand, otherwise fall back
5758 to the common codepath that casts to long.
5760 * cs-tokenizer.cs: Use the same code pattern as the int case.
5761 Maybe I should do the parsing myself, and avoid depending on the
5762 Parse routines to get this done.
5764 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5766 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5767 which fixes bug 51347. This time test it.
5769 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5770 attributes for example can not tell the difference between these.
5771 The difference was only a syntax feature of the language.
5773 * attribute.cs: Apply attributes to delegates.
5775 * delegate.cs: Call the apply attributes method.
5777 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5779 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5780 comparing 0 vs Byte.MinValue, not the value
5782 (ImplicitConversionRequired): When reporting a conversion error,
5783 use error 31 to print out the constant error instead of the
5786 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5787 which fixes bug 51347.
5789 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5791 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5792 which fixes the -warnaserror command line option.
5794 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5796 * cfold.cs (DoNumericPromotions): During constant folding of
5797 additions on UIntConstant, special case intconstants with
5798 IntConstants like we do on the expression binary operator.
5800 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5802 * convert.cs (ImplicitReferenceConversion): We were missing a case
5803 (System.Enum are not value types or class types, so we need to
5804 classify them separatedly).
5806 * driver.cs: We do not support error 2007.
5808 2003-11-12 Jackson Harper <jackson@ximian.com>
5810 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5811 system directory. Also use the full file name so users can
5812 libraries names mscorlib-o-tron.dll in a non system dir.
5814 2003-11-10 Martin Baulig <martin@ximian.com>
5816 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5817 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5818 calling `ResolveType()' on them, directly assign their `Type'.
5820 2003-11-08 Martin Baulig <martin@ximian.com>
5822 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5823 return value and the `out parent' parameter.
5824 (TypeContainer.DefineType): Moved the CS0644 check into
5825 GetClassBases(). Don't pass the interface types to the
5826 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5827 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5829 * ecore.cs (TypeExpr.IsAttribute): New property.
5830 (TypeExpr.GetInterfaces): New method.
5832 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5833 TypeExpr instead of a Type.
5834 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5835 (Interface.DefineType): Don't pass the interface types to the
5836 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5837 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5839 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5840 instead of a `Type[]'.
5841 (TypeManager.RegisterBuilder): Likewise.
5842 (TypeManager.AddUserInterface): Likewise.
5843 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5844 `Type[]' and also return a `TypeExpr[]'.
5845 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5847 2003-11-08 Martin Baulig <martin@ximian.com>
5849 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5852 2003-11-08 Martin Baulig <martin@ximian.com>
5854 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5855 TypeManager.ResolveExpressionTypes().
5857 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5858 instead of an Expression.
5859 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5860 (TypeExpression): New public class; formerly known as `TypeExpr'.
5862 * expression.cs (ComposedCast): Derive from TypeExpr.
5864 * typemanager.cs (TypeManager.system_*_expr): These are now
5865 TypExpr's instead of Expression's.
5866 (TypeManager.ResolveExpressionTypes): New public static function;
5867 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5870 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5872 * expression.cs (New.DoResolve): Do not dereference value that
5873 might be a null return.
5875 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5876 sure that the constant value has the right type. Fixes an
5877 unreported bug, similar to 50425.
5879 * const.cs (Const.LookupConstantValue): Call
5880 ImplicitStandardConversionExists before doing a conversion to
5881 avoid havng the TypeManager.ChangeType do conversions.
5883 Reduced the number of casts used
5885 (Const.ChangeType): New routine to enable reuse of the constant
5886 type changing code from statement.
5888 * typemanager.cs (ChangeType): Move common initialization to
5889 static global variables.
5893 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5894 every value type to go through, even if it was void. Fix that.
5896 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5897 character of the define, and the is_identifier_part_character for
5898 the rest of the string.
5900 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5902 * expression.cs (UnaryMutator.EmitCode): When I updated
5903 LocalVariableReference.DoResolve, I overdid it, and dropped an
5904 optimization done on local variable references.
5906 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5908 * ecore.cs: Convert the return from Ldlen into an int.
5910 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5912 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5913 the accessibility, this is a special case for toplevel non-public
5914 classes (internal for instance).
5916 2003-10-20 Nick Drochak <ndrochak@gol.com>
5918 * ecore.cs: Fix typo and build. Needed another right paren.
5920 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5922 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5923 `internal' case regular and protected, but not allowing protected
5924 to be evaluated later. Bug 49840
5926 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5928 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5929 to kb.Nlast, and not the kb.nFirst to isolate the switch
5932 Extract the underlying type, so enumerations of long/ulong are
5933 treated like long/ulong.
5935 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5937 * expression.cs (New): Overload the meaning of RequestedType to
5938 track the possible creation of the NewDelegate type, since
5939 DoResolve is invoked more than once for new constructors on field
5942 See bugs: #48800 and #37014
5944 * cs-parser.jay (declare_local_constants): Take an arraylist
5945 instead of a single constant.
5947 (local_constant_declaration): It should take a
5948 constant_declarators, not a constant_declarator. Fixes 49487
5950 * convert.cs: Fix error report.
5952 2003-10-13 Jackson Harper <jackson@ximian.com>
5954 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5957 2003-10-09 Martin Baulig <martin@ximian.com>
5959 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5961 (MethodCore.DoDefineParameters): Removed the TypeContainer
5962 argument; use the DeclSpace which was passed to the .ctor instead.
5963 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5964 TypeContainer; we only need a DeclSpace here.
5966 2003-10-09 Martin Baulig <martin@ximian.com>
5968 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5970 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5971 EmitContext's .ctor.
5973 2003-10-09 Martin Baulig <martin@ximian.com>
5975 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5976 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5977 AsAccessible(), moved them as well.
5979 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5981 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5983 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5985 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5987 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5988 generation for >=, as spotted by Paolo, bug 48679.
5989 Patch from David Waite.
5991 * cs-tokenizer.cs: Add handling for #pragma.
5993 * cs-parser.jay: Allow for both yield and yield return in the
5994 syntax. The anti-cobolization of C# fight will go on!
5996 * class.cs (TypeBuilder.DefineType): Catch error condition here
5997 (Parent.DefineType erroring out and returning null).
5999 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6000 coping with enumerations variables, we were mistakenly processing
6001 them as a regular value type instead of built-in types. Fixes the
6004 * typemanager.cs (IsBuiltinOrEnum): New method.
6006 2003-09-30 Miguel de Icaza <miguel@ximian.com>
6008 * cs-parser.jay: Upgrade: yield now needs the return clause.
6010 2003-09-19 Martin Baulig <martin@ximian.com>
6012 * decl.cs (MemberCache.SetupCacheForInterface): Take a
6013 `MemberCache parent' argument. Normally, an interface doesn't
6014 have a parent type except System.Object, but we use this in gmcs
6015 for generic type parameters.
6017 2003-09-18 Martin Baulig <martin@ximian.com>
6019 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
6020 on `type.IsInterface'; don't check whether the type has a parent
6021 to determine whether it's an interface.
6023 2003-09-15 Martin Baulig <martin@ximian.com>
6025 * class.cs (TypeContainer.DefineType): Added an error flag to
6026 avoid reporting duplicate CS0146's ("class definition is
6029 * driver.cs (Driver.MainDriver): Abort if
6030 RootContext.ResolveTree() reported any errors.
6032 2003-09-07 Martin Baulig <martin@ximian.com>
6034 * report.cs (Error, Warning): Added overloaded versions which take
6035 a `params object[] args' and call String.Format().
6037 2003-09-07 Martin Baulig <martin@ximian.com>
6039 * decl.cs (DeclSpace..ctor): Don't call
6040 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
6041 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
6042 (DeclSpace.RecordDecl): New method.
6044 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
6046 2003-09-02 Ravi Pratap <ravi@ximian.com>
6048 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
6049 value attributes to be applied to ParameterBuilders.
6051 * class.cs (MethodCore.LabelParameters): Make static and more
6052 generic so that it can be used from other places - like interface
6053 methods, for instance.
6055 * interface.cs (Interface.Emit): Call LabelParameters before
6056 emitting attributes on the InterfaceMethod.
6058 2003-08-26 Martin Baulig <martin@ximian.com>
6060 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
6061 resolving aliases; fixes #47927.
6063 2003-08-26 Martin Baulig <martin@ximian.com>
6065 * statement.cs (Using.DoResolve): This is internally emitting a
6066 try/finally clause, so we need to set ec.NeedExplicitReturn if we
6067 do not always return. Fixes #47681.
6069 2003-08-26 Martin Baulig <martin@ximian.com>
6071 * decl.cs (MemberCore): Moved WarningNotHiding(),
6072 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
6074 (AdditionResult): Make this nested in DeclSpace.
6075 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
6076 argument; call NamespaceEntry.Define() unless we're nested in a
6079 * namespace.cs (Namespace.DefineName): New public function. This
6080 is called from DeclSpace's .ctor to add
6081 (Namespace.Lookup): Include DeclSpaces in the lookup.
6083 * class.cs (Operator): Derive from MemberBase, not MemberCore.
6085 * const.cs (Const): Derive from MemberBase, not MemberCore.
6087 2003-08-25 Martin Baulig <martin@ximian.com>
6089 * convert.cs (Convert.ExplicitReferenceConversion): When
6090 converting from an interface type to a class, unbox if the target
6091 type is a struct type. Fixes #47822.
6093 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6095 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
6098 2003-08-22 Martin Baulig <martin@ximian.com>
6100 * class.cs (TypeManager.DefineType): When defining a nested type,
6101 call DefineType() on our parent; fixes #47801.
6103 2003-08-22 Martin Baulig <martin@ximian.com>
6105 * class.cs (MethodData.Define): While checking if a method is an
6106 interface implementation, improve the test a bit more to fix #47654.
6108 2003-08-22 Martin Baulig <martin@ximian.com>
6110 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
6111 correctly; fixes #47722.
6113 2003-08-22 Martin Baulig <martin@ximian.com>
6115 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
6116 LocalVariableReference, ensure it's not read-only. Fixes #47536.
6118 * statement.cs (Fixed.DoResolve): Make all variables read-only.
6120 2003-08-22 Martin Baulig <martin@ximian.com>
6122 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
6123 can only be assigned in static constructors. Fixes #47161.
6125 2003-08-22 Martin Baulig <martin@ximian.com>
6127 Rewrote and improved the flow analysis code.
6129 * flowbranching.cs (FlowBranching): Make this class abstract.
6130 (FlowBranching.CreateBranching): New static function to create a
6132 (FlowBranchingBlock, FlowBranchingException): New classes.
6133 (FlowBranching.UsageVector.Type): New public readonly field.
6134 (FlowBranching.UsageVector.Breaks): Removed the setter.
6135 (FlowBranching.UsageVector.Returns): Removed the setter.
6136 (FlowBranching.UsageVector): Added Break(), Return(),
6137 NeverReachable() and Throw() methods to modify the reachability.
6138 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
6139 done by FlowBranching.Merge().
6140 (FlowBranching.UsageVector.MergeChild): New method; merges the
6141 merge result into the current vector.
6142 (FlowBranching.Merge): New abstract method to merge a branching.
6144 2003-08-12 Martin Baulig <martin@ximian.com>
6146 * expression.cs (Indirection.CacheTemporaries): Create the
6147 LocalTemporary with the pointer type, not its element type.
6149 2003-08-10 Miguel de Icaza <miguel@ximian.com>
6151 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
6152 token was a keyword or not.
6154 Add `error' options where an IDENTIFIER was expected; Provide
6155 CheckToken and CheckIdentifierToken convenience error reporting
6158 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
6160 * decl.cs: Rename `NamespaceEntry Namespace' public field into
6161 NameSpaceEntry NameSpaceEntry.
6163 (LookupInterfaceOrClass): Avoid creating a full qualified name
6164 from namespace and name: avoid doing lookups when we know the
6165 namespace is non-existant. Use new Tree.LookupByNamespace which
6166 looks up DeclSpaces based on their namespace, name pair.
6168 * driver.cs: Provide a new `parser verbose' to display the
6169 exception thrown during parsing. This is turned off by default
6170 now, so the output of a failure from mcs is more graceful.
6172 * namespace.cs: Track all the namespaces defined in a hashtable
6175 (IsNamespace): New method
6177 2003-08-09 Miguel de Icaza <miguel@ximian.com>
6179 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
6180 we know that we need to concatenate (full typename can never be
6185 * statement.cs: Use a bitfield; Do not initialize to null things
6186 which are done by the constructor by default.
6188 * cs-parser.jay: bug fix, parameter was 4, not 3.
6190 * expression.cs: Just use the property;
6192 * statement.cs: No need for GetVariableInfo method.
6194 2003-08-08 Martin Baulig <martin@ximian.com>
6196 * flowanalysis.cs (FlowReturns): This is now nested in the
6197 `FlowBranching' class.
6198 (MyBitVector): Moved this here from statement.cs.
6199 (FlowBranching.SiblingType): New enum type.
6200 (FlowBranching.CreateSibling): Added `SiblingType' argument.
6202 2003-08-07 Martin Baulig <martin@ximian.com>
6204 * flowanalysis.cs (FlowBranchingType): This is now nested in the
6205 `FlowBranching' class and called `BranchingType'.
6207 2003-08-07 Martin Baulig <martin@ximian.com>
6209 * flowanalysis.cs: Moved all the control flow analysis code into
6212 2003-08-07 Martin Baulig <martin@ximian.com>
6214 * assign.cs (Assign.DoResolve): `target' must either be an
6215 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
6218 2003-08-07 Miguel de Icaza <miguel@ximian.com>
6220 * expression.cs (BinaryMethod): This kind of expression is created by the
6221 Binary class if it determines that the operator has to be handled
6224 (BinaryDelegate): This kind of expression is created if we are
6225 dealing with a + or - operator on delegates.
6227 (Binary): remove method, argumetns, and DelegateOperator: when
6228 dealing with methods,
6230 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
6232 * statement.cs (Block): use bitfields for the three extra booleans
6233 we had in use. Remove unused topblock parameter.
6235 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
6237 * assign.cs: Drop extra unneeded tests.
6239 2003-08-06 Miguel de Icaza <miguel@ximian.com>
6241 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
6243 * statement.cs (Foreach): Use VariableStorage instead of
6246 * codegen.cs (VariableStorage): New class used by clients that
6247 require a variable stored: locals or fields for variables that
6248 need to live across yield.
6250 Maybe provide a convenience api for EmitThis+EmitLoad?
6252 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
6255 2003-08-05 Miguel de Icaza <miguel@ximian.com>
6257 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
6258 RemapParameterLValue): New methods that are used to turn a
6259 precomputed FieldInfo into an expression like this:
6263 The idea is to use this instead of making LocalVariableReference
6264 have more than one meaning.
6266 * cs-parser.jay: Add error production to BASE.
6268 * ecore.cs: Deal with TypeManager.GetField returning null, which
6269 is now a valid return value.
6271 (FieldExprNoAddress): New expression for Fields whose address can
6274 * expression.cs (LocalVariableReference): During the resolve
6275 phases, create new expressions if we are in a remapping context.
6276 Remove code that dealt with remapping here.
6278 (ParameterReference): same.
6280 (ProxyInstance): New expression, like the `This' expression, but
6281 it is born fully resolved. We know what we are doing, so remove
6282 the errors that are targeted to user-provided uses of `this'.
6284 * statement.cs (Foreach): our variable is now stored as an
6285 Expression; During resolution, follow the protocol, dont just
6286 assume it will return this.
6288 2003-08-06 Martin Baulig <martin@ximian.com>
6290 * support.cs (SeekableStreamReader.cs): New public class.
6292 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
6293 SeekableStreamReader instead of the normal StreamReader.
6295 2003-08-04 Martin Baulig <martin@ximian.com>
6297 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
6298 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
6299 deambiguate casts and delegate invocations.
6300 (parenthesized_expression): Use the new tokens to ensure this is
6301 not a cast of method invocation.
6303 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
6304 when reading a `)' and Deambiguate_CloseParens () was previously
6307 * expression.cs (ParenthesizedExpression): New class. This is
6308 just used for the CS0075 test.
6309 (Binary.DoResolve): Check for CS0075.
6311 2003-07-29 Ravi Pratap <ravi@ximian.com>
6313 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
6314 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
6315 reference comparison.
6317 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
6318 examine the ReturnType for equality - this is necessary in the
6319 cases of implicit and explicit operators whose signature also
6320 includes the return type.
6322 2003-07-26 Miguel de Icaza <miguel@ximian.com>
6324 * namespace.cs: Cache the result of the namespace computation,
6325 instead of computing it every time.
6327 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6329 * decl.cs: Use a global arraylist that we reuse over invocations
6330 to avoid excesive memory consumption. Reduces memory usage on an
6331 mcs compile by one meg (45 average).
6333 * typemanager.cs (LookupTypeReflection): In .NET pointers are
6334 private, work around that.
6336 2003-07-23 Miguel de Icaza <miguel@ximian.com>
6338 * literal.cs (IntLiteral): Define Zero and One static literals.
6340 * cs-parser.jay (integer_literal): use static literals to reduce
6341 memory usage for the most used literals (0, 1 and -1). 211kb
6342 reduced in memory usage.
6344 Replace all calls to `new ArrayList' with `new
6345 ArrayList(4)' which is a good average number for most allocations,
6346 and also requires only 16 bytes of memory for its buffer by
6349 This reduced MCS memory usage in seven megabytes for the RSS after
6352 2003-07-28 Ravi Pratap <ravi@ximian.com>
6354 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
6355 handle params methods the correct way by forming only one
6356 applicable set with params and normal methods in them. Earlier we
6357 were looking at params methods only if we found no normal methods
6358 which was not the correct thing to do.
6360 (Invocation.BetterFunction): Take separate arguments indicating
6361 when candidate and the best method are params methods in their
6364 This fixes bugs #43367 and #46199.
6366 * attribute.cs: Documentation updates.
6368 (CheckAttribute): Rename to CheckAttributeTarget.
6369 (GetValidPlaces): Rename to GetValidTargets.
6371 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
6372 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
6376 2003-07-28 Martin Baulig <martin@ximian.com>
6378 * class.cs (TypeContainer.DefineMembers): Use the base type's full
6379 name when looking up the base class of a nested class. Fixes #46977.
6381 2003-07-26 Martin Baulig <martin@ximian.com>
6383 * expression.cs (Indexers.Indexer): New nested struct; contains
6384 getter, setter and the indexer's type.
6385 (Indexers.Properties): This is now an ArrayList of
6387 (IndexerAccess.DoResolveLValue): Correctly set the type if the
6388 indexer doesn't have any getters.
6390 * assign.cs (Assign.DoResolve): Also do the implicit conversions
6391 for embedded property and indexer assignments.
6393 2003-07-26 Martin Baulig <martin@ximian.com>
6395 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
6396 preprocessor directive is not the first non-whitespace character
6399 2003-07-26 Martin Baulig <martin@ximian.com>
6401 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
6402 namespace parsing, follow the spec more closely.
6404 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
6405 NamespaceEntry.Lookup().
6407 2003-07-25 Martin Baulig <martin@ximian.com>
6409 * MethodCore.cs (OverridesSomething): New public field; it's set
6410 from TypeContainer.DefineMembers if this method overrides
6411 something (which doesn't need to be a method). Fix #39462.
6413 2003-07-25 Ravi Pratap <ravi@ximian.com>
6415 * typemanager.cs (GetMembers): Ensure that the list of members is
6416 reversed. This keeps things in sync.
6418 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
6419 find an AttributeUsage attribute.
6421 * expression.cs (Invocation.OverloadResolve): Perform the check
6422 which disallows Invoke to be directly called on a Delegate.
6424 (Error_InvokeOnDelegate): Report error cs1533.
6426 2003-07-25 Martin Baulig <martin@ximian.com>
6428 * expression.cs (Indexers.GetIndexersForType): Only look in the
6429 interface hierarchy if the requested type is already an
6430 interface. Fixes #46788 while keeping #46502 fixed.
6432 2003-07-25 Martin Baulig <martin@ximian.com>
6434 * class.cs (TypeContainer.DefineMembers): Check whether all
6435 readonly fields have been assigned and report warning CS0649 if
6438 * statement.cs (LocalInfo.IsFixed): Always return true if this is
6441 2003-07-24 Ravi Pratap <ravi@ximian.com>
6443 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
6444 returned from GetMethods to make things consistent with the
6445 assumptions MCS makes about ordering of methods.
6447 This should comprehensively fix bug #45127 and it does :-)
6449 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
6450 ordering is actually reverse.
6452 * Clean up some debug messages I left lying around.
6454 * interface.cs (Populate*): Get rid of code which emits attributes
6455 since the stage in which we emit attributes is the 'Emit' stage,
6456 not the define stage.
6458 (Emit): Move attribute emission for interface members here.
6460 2003-07-22 Ravi Pratap <ravi@ximian.com>
6462 * expression.cs (Invocation.OverloadResolve): Follow the spec more
6463 closely: we eliminate methods in base types when we have an
6464 applicable method in a top-level type.
6466 Please see section 14.5.5.1 for an exact description of what goes
6469 This fixes bug #45127 and a host of other related to corlib compilation.
6471 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
6472 array is the method corresponding to the top-level type (this is
6473 because of the changes made to icall.c) so we change this
6476 (MethodGroupExpr.Name): This too.
6478 * typemanager.cs (GetElementType): New method which does the right
6479 thing when compiling corlib.
6481 * everywhere: Make use of the above in the relevant places.
6483 2003-07-22 Martin Baulig <martin@ximian.com>
6485 * cs-parser.jay (invocation_expression): Moved
6486 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
6487 `cast_expression', but create a InvocationOrCast which later
6488 resolves to either an Invocation or a Cast.
6490 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
6491 method; call this before EmitStatement() to make sure that this
6492 expression can be used as a statement.
6494 * expression.cs (InvocationOrCast): New class; resolves to either
6495 an Invocation or a Cast.
6497 * statement.cs (StatementExpression): Call ResolveStatement() on
6498 the ExpressionStatement before emitting it.
6500 2003-07-21 Martin Baulig <martin@ximian.com>
6502 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
6503 `ref' and `out' attributes match; fixes #46220.
6504 (MemberAccess.ResolveMemberAccess): You can't reference a type
6505 through an expression; fixes #33180.
6506 (Indexers.GetIndexersForType): Don't return the indexers from
6507 interfaces the class implements; fixes #46502.
6509 2003-07-21 Martin Baulig <martin@ximian.com>
6511 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
6512 CS0661 checks; fixes bug #30442.
6514 2003-07-21 Martin Baulig <martin@ximian.com>
6516 * decl.cs (AdditionResult): Added `Error'.
6518 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
6520 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
6521 makes cs0031.cs actually work.
6523 2003-07-20 Martin Baulig <martin@ximian.com>
6525 * namespace.cs: Fixed that bug which caused a crash when compiling
6528 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6530 * typemanager.cs (LookupTypeReflection): Never expose types which
6531 are NotPublic, NestedPrivate, NestedAssembly, or
6532 NestedFamANDAssem. We used to return these, and later do a check
6533 that would report a meaningful error, but the problem is that we
6534 would not get the real match, if there was a name override.
6536 2003-07-18 Miguel de Icaza <miguel@ximian.com>
6538 * namespace.cs (Namespace, Name): Do not compute the namespace
6539 name dynamically, compute it in the constructor. This reduced
6540 memory usage by 1697 KB.
6542 * driver.cs: Use --pause to pause at the end.
6544 2003-07-17 Peter Williams <peter@newton.cx>
6546 * Makefile: Change the name of the test target so that it doesn't
6547 conflict with the recursive test target.
6549 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6551 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6552 AddressOf): Do not use EmitThis, that was wrong, use the actual
6555 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6557 * class.cs (MethodData.Define): While checking if a method is an
6558 interface implementation, improve the test: If we are not public
6559 (use new test here: use the computed MethodAttributes directly,
6560 instead of the parsed modifier flags) check if the `implementing'
6561 method comes from an interface or not.
6563 * pending.cs (VerifyPendingMethods): Slightly better error
6566 * makefile: add test target that does the mcs bootstrap.
6568 2003-07-16 Ravi Pratap <ravi@ximian.com>
6570 * interface.cs (Define): Do nothing here since there are no
6571 members to populate etc. Move the attribute emission out of here
6572 since this was just totally the wrong place to put it. Attribute
6573 application happens during the 'Emit' phase, not in the 'Define'
6576 (Emit): Add this method and move the attribute emission here
6578 * rootcontext.cs (EmitCode): Call the Emit method on interface
6581 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6583 * expression.cs (OverloadResolve): Report error only if Location
6584 is not 'Null' which means that there was a probe going on.
6586 2003-07-14 Martin Baulig <martin@ximian.com>
6588 * expression.cs (ConditionalLogicalOperator): New public class to
6589 implement user defined conditional logical operators.
6590 This is section 14.11.2 in the spec and bug #40505.
6592 2003-07-14 Martin Baulig <martin@ximian.com>
6594 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6596 2003-07-14 Martin Baulig <martin@ximian.com>
6598 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6600 * ecore.cs (IVariable.VerifyFixed): New interface method.
6602 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6603 operator, check whether the variable is actually fixed. Fixes bug
6604 #36055. Set a variable definitely assigned when taking its
6605 address as required by the spec.
6607 * statement.cs (LocalInfo.IsFixed): New field.
6608 (LocalInfo.MakePinned): Set `IsFixed' to true.
6610 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6612 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6613 for .ctors, ensure that we only ask for members declared in the
6614 attribute type (BindingFlags.DeclaredOnly).
6618 * expression.cs (Error_WrongNumArguments): Report error 1501
6619 correctly the way CSC does.
6621 2003-07-13 Martin Baulig <martin@ximian.com>
6623 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6624 lookup on the fully qualified name, to make things like "X.X" work
6625 where "X.X" is a fully qualified type name, but we also have a
6626 namespace "X" in the using list. Fixes #41975.
6628 2003-07-13 Martin Baulig <martin@ximian.com>
6630 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6631 function. If we're a CompoundAssign, we need to create an embedded
6632 CompoundAssign, not an embedded Assign.
6633 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6636 2003-07-13 Martin Baulig <martin@ximian.com>
6638 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6639 work to fix bug #46088.
6641 2003-07-13 Ravi Pratap <ravi@ximian.com>
6643 * class.cs (Operator.Emit): Do not emit attributes here - it is
6644 taken care of by the Method class that we delegate too. This takes
6647 2003-07-10 Martin Baulig <martin@ximian.com>
6649 * expression.cs (TypeOfVoid): New class.
6650 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6652 2003-07-10 Martin Baulig <martin@ximian.com>
6654 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6657 2003-07-10 Martin Baulig <martin@ximian.com>
6659 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6660 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6662 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6664 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6666 2003-07-10 Martin Baulig <martin@ximian.com>
6668 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6669 of decimal. Fixes #42850.
6671 NOTE: I also fixed the created byte blob, but this doesn't work on
6672 the MS runtime and csc never produces any byte blobs for decimal
6675 2003-07-10 Martin Baulig <martin@ximian.com>
6677 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6678 structs; fixes #32068.
6679 (Block.AddChildVariableNames): Fixed #44302.
6681 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6683 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6685 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6687 * attribute.cs: And this test is onger needed.
6689 2003-07-08 Martin Baulig <martin@ximian.com>
6691 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6692 inaccessible types. Fixes #36313.
6694 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6696 * namespace.cs (NamespaceEntry): Create implicit entries for all
6697 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6698 implicit entries for N1.N2 and N1.
6700 2003-07-08 Martin Baulig <martin@ximian.com>
6702 Rewrote the handling of namespaces to fix a lot of the issues
6703 wrt. `using' aliases etc.
6705 * namespace.cs (Namespace): Splitted this class into a
6706 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6708 * typemanager.cs (TypeManager.IsNamespace): Removed.
6709 (TypeManager.ComputeNamespaces): Only compute namespaces from
6710 loaded assemblies here, not the namespaces from the assembly we're
6711 currently compiling.
6713 2003-07-08 Martin Baulig <martin@ximian.com>
6715 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6717 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6719 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6722 I thought about the memory savings here, but LookupTypeReflection
6723 is used under already very constrained scenarios. Compiling
6724 corlib or mcs only exposes one hit, so it would not really reduce
6725 any memory consumption.
6727 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6729 * typemanager.cs: fixes bug #45889 by only adding public types from
6730 other assemblies to the list of known types.
6732 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6734 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6735 on the type we resolved.
6737 2003-07-05 Martin Baulig <martin@ximian.com>
6739 * pending.cs (PendingImplementation.ParentImplements): Don't
6740 create the proxy if the parent is abstract.
6742 * class.cs (TypeContainer.DefineIndexers): Process explicit
6743 interface implementations first. Fixes #37714.
6745 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6747 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6748 defined recursively; but since we modify the input parameters
6749 (left is set to `this' temporarily), we reset this value if the
6750 left_is_explicit is false, which gives the original semantics to
6753 * literal.cs (NullPointer): new class used to represent a null
6754 literal in a pointer context.
6756 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6757 type is a pointer, use a NullPointer object instead of a
6758 NullLiteral. Closes 43687
6760 (ExplicitConversion): Convert pointer values using
6761 the conv opcode to the proper type.
6763 * ecore.cs (New): change ValueTypeVariable property into a method,
6764 that returns whether the valuetype is suitable for being used.
6766 * expression.cs (Binary.DoNumericPromotions): Only return if we
6767 the int constant was a valid uint, and we can return both left and
6768 right as uints. If not, we continue processing, to trigger the
6769 type conversion. This fixes 39018.
6771 * statement.cs (Block.EmitMeta): During constant resolution, set
6772 the CurrentBlock property on the emitcontext, so that we resolve
6773 constants propertly.
6775 2003-07-02 Martin Baulig <martin@ximian.com>
6777 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6778 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6780 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6781 than emitting it here.
6783 * statement.cs: Fixed some more flow analysis bugs.
6785 2003-07-02 Martin Baulig <martin@ximian.com>
6787 * class.cs (MethodData.Define): When implementing interface
6788 methods, set Final unless we're Virtual.
6790 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6791 check work for interface methods.
6793 2003-07-01 Martin Baulig <martin@ximian.com>
6795 * ecore.cs (EmitContext.This): Replaced this property with a
6796 GetThis() method which takes a Location argument. This ensures
6797 that we get the correct error location for a CS0188.
6799 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6801 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6802 ImplicitStandardConversion.
6804 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6806 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6808 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6811 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6813 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6816 (MethodData.Define): Turn off initlocals for unsafe methods.
6818 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6820 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6821 complete; Fixes #37521.
6823 * delegate.cs: Use Modifiers.TypeAttr to compute the
6824 TypeAttributes, instead of rolling our own. This makes the flags
6825 correct for the delegates.
6827 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6829 * class.cs (Constructor.Define): Set the private flag for static
6830 constructors as well.
6832 * cs-parser.jay (statement_expression): Set the return value to
6833 null, to avoid a crash when we catch an error.
6835 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6837 * cs-parser.jay: Applied patch from Jackson that adds support for
6838 extern and unsafe modifiers to destructor declarations.
6840 * expression.cs: Report error 21 if the user is trying to index a
6843 * driver.cs: Add an error message, suggested by the bug report.
6845 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6846 if we do not have a ": this ()" constructor initializer. Fixes 45149
6848 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6850 * namespace.cs: Add some information to reduce FAQs.
6852 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6854 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6855 underlying enumeration types. Fixes #43915.
6857 * expression.cs: Treat ushort/short as legal values to be used in
6860 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6862 * delegate.cs: transfer custom attributes for paramenters from
6863 the delegate declaration to Invoke and BeginInvoke.
6865 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6867 * attribute.cs: handle custom marshalers and emit marshal info
6870 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6872 * makefile.gnu: Added anonymous.cs to the compiler sources.
6874 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6876 * iterators.cs: Change the name of the proxy class to include two
6879 * cs-parser.jay: Update grammar to include anonymous methods.
6881 * anonymous.cs: new file.
6883 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6885 * class.cs (Field.Define): Add missing test for pointers and
6888 2003-05-27 Ravi Pratap <ravi@ximian.com>
6890 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6891 we use the stobj opcode.
6893 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6894 since it wasn't the correct fix.
6896 It still is puzzling that we are required to use stobj for IntPtr
6897 which seems to be a ValueType.
6899 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6901 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6902 during regular simple name resolution. Now, the trick is that
6903 instead of returning for processing the simplename, we do a
6904 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6905 contextual lookup type). If a match is found, return that, if
6906 not, return for further composition.
6908 This fixes long-standing 30485.
6910 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6911 using the address to initialize an object, do an Stobj instead of
6912 using the regular Stelem.
6914 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6915 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6916 Because if we are a BaseIndexerAccess that value will be true.
6919 * statement.cs (GotoCase.Resolve): Return after reporting an
6920 error, do not attempt to continue.
6922 * expression.cs (PointerArithmetic.Emit): If our operand is a
6923 long, convert our constants to match the operand before
6924 multiplying. Convert to I type before adding. Fixes 43670.
6926 2003-05-14 Ravi Pratap <ravi@ximian.com>
6928 * enum.cs (ImplicitConversionExists) : Rename to
6929 ImplicitEnumConversionExists to remove ambiguity.
6931 * ecore.cs (NullCast): New type of cast expression class which
6932 basically is very similar to EmptyCast with the difference being
6933 it still is a constant since it is used only to cast a null to
6937 * convert.cs (ImplicitReferenceConversion): When casting a null
6938 literal, we return a NullCast.
6940 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6941 should be around anymore.
6943 The renaming (reported was slightly wrong). Corrections:
6945 ConvertImplicitStandard -> ImplicitConversionStandard
6946 ConvertExplicitStandard -> ExplicitConversionStandard
6948 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6949 before passing them in !
6951 * convert.cs (ImplicitConversionStandard): When comparing for
6952 equal expr and target types, ensure that expr is not a
6955 In general, we must not be checking (expr_type ==
6956 target_type) in the top level conversion methods
6957 (ImplicitConversion, ExplicitConversion etc). This checking is
6958 done in the methods that they delegate to.
6960 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6962 * convert.cs: Move Error_CannotConvertType,
6963 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6964 ImplicitNumericConversion, ImplicitConversionExists,
6965 ImplicitUserConversionExists, StandardConversionExists,
6966 FindMostEncompassedType, FindMostSpecificSource,
6967 FindMostSpecificTarget, ImplicitUserConversion,
6968 ExplicitUserConversion, GetConversionOperators,
6969 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6970 TryImplicitIntConversion, Error_CannotConvertImplicit,
6971 ConvertImplicitRequired, ConvertNumericExplicit,
6972 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6973 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6976 Perform the following renames:
6978 StandardConversionExists -> ImplicitStandardConversionExists
6979 ConvertImplicit -> ImplicitConversion
6980 ConvertImplicitStandard -> ImplicitStandardConversion
6981 TryImplicitIntConversion -> ImplicitIntConversion
6982 ConvertImplicitRequired -> ImplicitConversionRequired
6983 ConvertNumericExplicit -> ExplicitNumericConversion
6984 ConvertReferenceExplicit -> ExplicitReferenceConversion
6985 ConvertExplicit -> ExplicitConversion
6986 ConvertExplicitStandard -> ExplicitStandardConversion
6988 2003-05-19 Martin Baulig <martin@ximian.com>
6990 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6991 (TypeInfo): Added support for structs having structs as fields.
6993 * ecore.cs (FieldExpr): Implement IVariable.
6994 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6995 VariableInfo for the field.
6997 2003-05-18 Martin Baulig <martin@ximian.com>
6999 * expression.cs (This.DoResolve): Report a CS0027 if we're
7000 emitting a field initializer.
7002 2003-05-18 Martin Baulig <martin@ximian.com>
7004 * expression.cs (This.ResolveBase): New public function.
7005 (This.DoResolve): Check for CS0188.
7007 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
7010 * ecore.cs (MethodGroupExpr.DoResolve): Set the
7011 `instance_expression' to null if we don't have any non-static
7014 2003-05-18 Martin Baulig <martin@ximian.com>
7016 Reworked the way how local variables and parameters are handled by
7017 the flow analysis code.
7019 * statement.cs (TypeInfo, VariableMap): New public classes.
7020 (VariableInfo): New public class. This is now responsible for
7021 checking whether a variable has been assigned. It is used for
7022 parameters and local variables.
7023 (Block.EmitMeta): Take the InternalParameters as argument; compute
7024 the layout of the flow vectors here.
7025 (Block.LocalMap, Block.ParameterMap): New public properties.
7026 (FlowBranching): The .ctor doesn't get the InternalParameters
7027 anymore since Block.EmitMeta() now computes the layout of the flow
7029 (MyStructInfo): This class is now known as `StructInfo' and nested
7030 in `TypeInfo'; we don't access this directly anymore.
7032 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
7033 property and removed IsAssigned(), IsFieldAssigned(),
7034 SetAssigned() and SetFieldAssigned(); we now call them on the
7035 VariableInfo so we don't need to duplicate this code everywhere.
7037 * expression.cs (ParameterReference): Added `Block block' argument
7039 (LocalVariableReference, ParameterReference, This): The new
7040 VariableInfo class is now responsible for all the definite
7043 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
7044 IsParameterAssigned, SetParameterAssigned): Removed.
7046 2003-05-18 Martin Baulig <martin@ximian.com>
7048 * typemanager.cs (InitCoreTypes): Try calling
7049 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
7050 the 3-args-version. Corlib now also needs our `void_type'.
7051 (GetMethod): Added overloaded version which takes an optional
7052 `bool report_errors' to allow lookups of optional methods.
7054 2003-05-12 Martin Baulig <martin@ximian.com>
7056 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
7057 only used for locals and not for parameters.
7059 2003-05-12 Miguel de Icaza <miguel@ximian.com>
7061 * support.cs (InternalParameters.ParameterType): Return the
7062 ExternalType of the parameter.
7064 * parameter.cs (Parameter.ExternalType): drop the two arguments,
7067 2003-05-11 Miguel de Icaza <miguel@ximian.com>
7069 * class.cs (MethodData.Define): Do not set the `newslot' on
7070 interface members, if they are also flagged as "override".
7072 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
7073 better code for ++i and i++. This only works for static fields
7074 and local variables.
7076 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
7077 want to pull the DeclSpace out of the builder_to_declspace instead
7078 of the TypeBuilder (like in TypeContainer.FindMembers).
7080 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
7081 instead of LookupTypeContainer. Fixes the crash on .NET for
7082 looking up interface members.
7084 * const.cs: Create our own emit context during the Definition
7085 stage, so that constants are evaluated in the proper context, when
7086 a recursive definition happens.
7088 2003-05-11 Martin Baulig <martin@ximian.com>
7090 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
7091 new block for a switch section.
7092 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
7093 the adding/lookup in the switch block. Fixes #39828.
7095 2003-05-09 Miguel de Icaza <miguel@ximian.com>
7097 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
7098 functionality: I needed to convert the data after I had performed
7099 the add/sub operation into the operands type size.
7101 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
7102 pass the type for the box operation, otherwise the resulting
7103 object would have been of type object.
7105 (BoxedCast): Add constructor to specify the type to box as.
7107 2003-05-07 Miguel de Icaza <miguel@ximian.com>
7109 * iterators.cs: I was reusing the `count' variable inadvertently,
7110 take steps to not allow this to happen.
7112 2003-05-06 Miguel de Icaza <miguel@ximian.com>
7114 * attribute.cs (Attribute.Resolve): Params attributes are encoded
7115 by creating an array at the point where the params starts and
7116 putting all those arguments there, then adjusting the size of the
7119 2003-05-05 Miguel de Icaza <miguel@ximian.com>
7121 * expression.cs (New.AddressOf): Implement interface
7122 IMemoryLocation. This is used when the `new' operator is used in
7123 the context of an invocation to a method on a value type.
7125 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
7128 * namespace.cs: Also check the using aliases here.
7130 * driver.cs: Move the test for using validity after the types have
7131 been entered, so we do a single pass that also includes the using
7134 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
7135 in the regular case. CreateSiblingForFinally is doing extra
7138 * attribute.cs (GetAttributeArgumentExpression): Store the result
7139 on an out value, and use the return value to indicate failure
7140 instead of using null (which is a valid return for Constant.GetValue).
7142 * statement.cs: Perform the analysis flow for the increment
7143 portion after the statement, because this will be the real flow of
7144 execution. Fixes #42385
7146 * codegen.cs (EmitContext.EmitArgument,
7147 EmitContext.EmitStoreArgument): New helper functions when the
7148 RemapToProxy flag is set.
7150 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
7153 Add support for remapping parameters.
7155 * iterators.cs: Propagate parameter values; Store parameter
7156 values in the proxy classes.
7158 2003-05-04 Miguel de Icaza <miguel@ximian.com>
7160 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
7161 need a proxy reference; I do not know what I was thinking
7163 * cs-parser.jay (constructor_initializer): catch another error,
7164 and display nice message.
7166 (field_declaration): catch void field declaration
7167 to flag a better error.
7169 * class.cs (MemberBase.CheckBase): Report an error instead of a
7170 warning if a new protected member is declared in a struct.
7171 (Field.Define): catch the error of readonly/volatile.
7173 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
7175 (FieldExpr.AddressOf): ditto. Catch error where the address of a
7176 volatile variable is taken
7178 2003-05-02 Miguel de Icaza <miguel@ximian.com>
7180 * statement.cs (Fixed.Resolve): Report an error if we are not in
7183 2003-05-01 Miguel de Icaza <miguel@ximian.com>
7185 * typemanager.cs: reuse the code that handles type clashes for
7186 delegates and enumerations.
7188 * class.cs (Report28): Always report.
7190 * expression.cs (EncodeAsAttribute): Allow nulls here.
7192 2003-04-28 Miguel de Icaza <miguel@ximian.com>
7194 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
7195 the functionality for testing whether an expression is valid for
7196 an attribute here. Also handle the case of arrays of elements
7199 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
7200 encoding a linear array into an array of objects that are suitable
7201 to be passed to an CustomAttributeBuilder.
7203 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
7205 * ecore.cs: (FieldExpr): Handle field remapping here.
7207 * iteratators.cs: Pass the instance variable (if the method is an
7208 instance method) to the constructors, so we can access the field
7209 variables on the class.
7211 TODO: Test this with structs. I think the THIS variable on
7212 structs might have to be a pointer, and not a refenrece
7214 2003-04-27 Miguel de Icaza <miguel@ximian.com>
7216 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
7217 local variables to fields in a proxy class.
7219 * iterators.cs (PopulateProxy): Rename our internal fields to
7221 Create a <THIS> field if we are an instance method, so we can
7222 reference our parent container variables.
7223 (MapVariable): Called back from the EmitContext code to enter a
7224 new variable to field mapping into the proxy class (we just create
7228 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
7229 for using the remapped locals to fields.
7231 I placed the code here, because that gives the same semantics to
7232 local variables, and only changes the Emit code.
7234 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
7235 statements inside iterators.
7236 (VariableInfo): Add a FieldBuilder for the cases when we are
7237 remapping local variables to fields in a proxy class
7239 * ecore.cs (SimpleNameResolve): Avoid testing two times for
7240 current_block != null.
7242 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
7243 not cope with strings, as it has been moved to the
7244 TableSwitchEmit. Fixed bug in switch generation.
7246 * expression.cs (New.DoResolve): Provide more context for the user
7247 when reporting an error.
7249 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
7252 * expression.cs (MemberAccess.DoResolve): When we get a type back,
7253 check the permissions for it. Note than in a type-resolution
7254 context the check was already present in DeclSpace.ResolveType,
7255 but was missing from the MemberAccess.
7257 (ArrayCreation.CheckIndices): warn if the user has
7258 more nested levels of expressions, but there are no more
7259 dimensions specified. Avoids crash on bug 41906.
7261 2003-04-26 Miguel de Icaza <miguel@ximian.com>
7263 * statement.cs (Block): replace Implicit bool, for a generic
7265 New flag: `Unchecked'. This is used during the EmitMeta phase
7266 (which is out-of-line with the regular Resolve/Emit process for a
7267 statement, as this is done ahead of time, but still gets a chance
7268 to call constant resolve).
7270 (Block.Flags): new enum for adding a new flag.
7272 (Block.EmitMeta): track the state of unchecked.
7274 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
7275 to enable constant resolution to work there as well.
7277 2003-04-22 Miguel de Icaza <miguel@ximian.com>
7279 * typemanager.cs (ienumerable_type): Also look up
7280 System.Collections.IEnumerable.
7282 2003-04-21 Miguel de Icaza <miguel@ximian.com>
7284 TODO: Test more than one conditional per method.
7286 * class.cs (Indexer.Define): Report the location where the user is
7287 referencing the unsupported feature.
7289 (MethodData): Overload the use of `conditionals' to
7290 minimize the creation of needless ArrayLists. This saves roughly
7291 212kb on my machine.
7293 (Method): Implement the new IIteratorContainer interface.
7294 (Method.SetYields): Implement the method by setting the ModFlags
7295 to contain METHOD_YIELDS.
7297 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
7298 which just got set to null.
7300 * iterators.cs: New file.
7302 (Yield, YieldBreak): New statements.
7304 * statement.cs (Return.Resolve): Flag an error if we are used in
7307 * codegen.cs (InIterator): New flag set if the code is being
7308 compiled in an iterator method.
7310 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
7311 internal modifier, and we just use it to avoid adding extra
7312 fields, as this is seldom used.
7314 * cs-parser.jay: Add yield_statement (yield and yield break).
7316 * driver.cs: New flag -v2 to turn on version 2 features.
7318 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
7319 hashtable when v2 is enabled.
7321 2003-04-20 Miguel de Icaza <miguel@ximian.com>
7323 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
7324 there is already a namespace defined with this name.
7326 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
7327 people upgraded their corlibs.
7329 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
7330 always use fully qualified types, no need to use the compiler
7333 (TypeManager.IsNamespace): Use binarysearch.
7335 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
7336 AddDelegate): I did not quite use the new IsValid API properly: I
7337 have to pass the short-name and the fullname. I was passing only
7338 the basename instead of the fullname sometimes.
7340 (TypeContainer.DefineType): call NamespaceClash.
7342 * interface.cs (Interface.DefineType): use NamespaceClash before
7345 * delegate.cs (Delegate.DefineType): use NamespaceClash before
7348 * enum.cs: (Enum.DefineType): use NamespaceClash before
7351 * typemanager.cs (: 3-line patch that gives us some tasty 11%
7352 speed increase. First, use the negative_hits cache when we get a
7353 negative. Second, add the type with its full original name
7354 instead of the new . and + encoded name (reflection uses + to
7355 separate type from a nested type). Use LookupTypeReflection
7356 directly which bypasses the type->name hashtable (that we already
7357 know does not contain the type.
7359 * decl.cs (DeclSpace.ResolveTypeExpr): track the
7360 location/container type.
7362 * driver.cs: When passing utf8, use directly the UTF8Encoding.
7364 2003-04-19 Miguel de Icaza <miguel@ximian.com>
7366 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
7368 * delegate.cs (NewDelegate.Resolve): Test whether an instance
7369 method is being referenced in the method group from a static
7370 context, and report error 120 if so.
7372 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
7375 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
7376 is created, we create the A namespace).
7378 * cs-parser.jay: A namespace also introduces a DeclarationFound.
7381 2003-04-18 Miguel de Icaza <miguel@ximian.com>
7383 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
7384 invocation to ModuleBuilder.GetType with the same values will
7385 return a new type instance, so we need to cache its return
7388 * expression.cs (Binary.ResolveOperator): Only allow the compare
7389 operators on enums if they are of the same type.
7391 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
7392 types of ValueType on their own case. Before we were giving them
7393 the same treatment as objects.
7395 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
7396 fullname. Short name is used to compare against container name.
7397 Fullname is used to check against defined namespace names.
7399 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
7400 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
7402 (Method.CheckBase): Call parent.
7403 (MemberBase.CheckBase): Check for protected members on sealed
7405 (PropertyBase.CheckBase): Call parent.
7406 (Field.Define): Call parent.
7408 * report.cs: Negative error codes are now mapped to 8000 - code,
7409 so that the display is render more nicely.
7411 * typemanager.cs: Do not use try/catch, instead report a regular
7414 (GetPointerType, GetReferenceType): These methods provide
7415 mechanisms to obtain the T* and T& from a T. We had the code
7416 previously scattered around the code base, and it also used
7417 TypeManager.LookupType that would go through plenty of caches.
7418 This one goes directly to the type source.
7420 In some places we did the Type.GetType followed by
7421 ModuleBuilder.GetType, but not in others, so this unifies the
7424 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
7425 statements now that we have namespace information.
7427 * typemanager.cs (IsNamespace): New method, returns whether the
7428 string presented is a namespace or not.
7430 (ComputeNamespaces): New public entry point, computes the list of
7431 available namespaces, using the GetNamespaces API call in Mono, or
7432 the slower version in MS.NET.
7434 Now before we start the semantic analysis phase, we have a
7435 complete list of namespaces including everything that the user has
7438 Deleted old code to cache namespaces in .nsc files.
7440 2003-04-17 Miguel de Icaza <miguel@ximian.com>
7442 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
7443 class/struct location definition Location for the implicit
7444 constructor location.
7446 (Operator.Define): Use the location of the operator for the
7447 implicit Method definition.
7449 (Constructor.Emit): use the constructor location for the implicit
7450 base initializer constructor.
7452 * ecore.cs: Remove ITypeExpression. This interface is now gone,
7453 and the Expression class now contains two new methods:
7455 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
7456 isolate type lookup from the rest of the resolution process.
7458 Since we use Expressions to hold type definitions due to the way
7459 we parse the input we have historically overloaded Resolve to
7460 perform the Type lookups if a special flag is passed. Now this is
7461 eliminated and two methods take their place.
7463 The differences in the two methods between xStep and xTerminal is
7464 that xStep is involved in our current lookup system that uses
7465 SimpleNames to compose a name, while xTerminal is used just to
7466 catch the case where the simplename lookup failed.
7468 2003-04-16 Miguel de Icaza <miguel@ximian.com>
7470 * expression.cs (ResolveMemberAccess): Remove redundant code.
7471 TypeExpr expressions are always born fully resolved.
7473 * interface.cs (PopulateMethod): Do not lookup the types twice.
7474 We were doing it once during SemanticAnalysis and once during
7477 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
7478 in local variable type definitions, were being returned as a
7479 SimpleName (we decomposed everything into a string), that is
7480 because primary_expression was being used instead of a type in the
7481 grammar (reduce/reduce conflicts).
7483 The part that was wrong is that we converted the expression into a
7484 string (an oversimplification in one hand, compounded with primary
7485 expressions doing string concatenation).
7491 Would return "A.B.C[]" as a SimpleName. This stopped things like
7492 using clauses from working on this particular context. And a type
7493 was being matched directly against "A.B.C[]".
7495 We now use the correct approach, and allow for ComposedCast to be
7496 part of the unary expression. So the "A.B.C []" become a composed
7497 cast of "A.B.C" (as a nested group of MemberAccess with a
7498 SimpleName at the end) plus the rank composition "[]".
7502 2003-04-10 Miguel de Icaza <miguel@ximian.com>
7504 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
7505 for the access level checking.
7507 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
7508 `TypeContainer container', because I kept getting confused when I
7509 was debugging this code.
7511 * expression.cs (Indexers): Instead of tracking getters/setters,
7512 we now track them in parallel. We create one arraylist less, but
7513 most importantly it is possible now for the LValue code to find a
7514 matching get for a set.
7516 (IndexerAccess.DoResolveLValue): Update the code.
7517 GetIndexersForType has been modified already to extract all the
7518 indexers from a type. The code assumed it did not.
7520 Also make the code set the correct return type for the indexer.
7521 This was fixed a long time ago for properties, but was missing for
7522 indexers. It used to be void_type.
7524 (Binary.Emit): Test first for doubles instead of
7525 floats, as they are more common.
7527 (Binary.EmitBranchable): Use the .un version of the branch opcodes
7528 when dealing with floats and the <=, >= operators. This fixes bug
7531 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
7532 to load the array value by emitting a load on the foreach variable
7533 type. This was incorrect.
7535 We now emit the code to load an element using the the array
7536 variable type, and then we emit the conversion operator.
7540 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
7542 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7544 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7546 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7547 test for protection before we test for signatures.
7549 (MethodSignature.ToString): implement.
7551 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7552 to the case where we reduced into a LongConstant.
7554 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7555 depend on whether the information is acurrate, because the
7556 Microsoft runtime will always claim that the array type is public,
7557 regardless of the real state.
7559 If the type is a pointer, another problem happens: the type is
7560 reported as non-public in Microsoft.
7562 In both cases we have to call CheckAccessLevel recursively with
7563 the underlying type as the argument to be tested.
7565 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7567 * assign.cs (Assign.Emit): If we are dealing with a compound
7568 assignment expression, we should use the code path that stores the
7569 intermediate result in a temporary value. This fixes #40903.
7571 *expression.cs (Indirection.ToString): Provide ToString method for
7574 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7576 * class.cs: Null out fields holding references to Block objects so
7577 they can be garbage collected.
7579 * expression.cs (OverloadResolve): Remove unused local.
7581 2003-04-07 Martin Baulig <martin@ximian.com>
7583 * codegen.cs (EmitContext.CurrentFile): New public field.
7584 (EmitContext.Mark): Use the CurrentFile to check whether the
7585 location is in the correct file.
7586 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7588 2003-04-07 Martin Baulig <martin@ximian.com>
7590 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7592 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7593 location. [FIXME: The location argument which gets passed to this
7594 method is sometimes wrong!]
7596 2003-04-07 Nick Drochak <ndrochak@gol.com>
7598 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7600 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7602 * expression.cs (Indirection.EmitAssign): We were using the
7603 temporary, but returning immediately instead of continuing the
7606 2003-04-06 Martin Baulig <martin@ximian.com>
7608 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7609 if it's a nested child, but also deriving from the outer class.
7612 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7613 nested child, but also deriving from the outer class. See
7615 (FilterWithClosure): We may access private members of the outer
7616 class if we're a nested child and deriving from the outer class.
7617 (RealMemberLookup): Only set `closure_private_ok' if the
7618 `original_bf' contained BindingFlags.NonPublic.
7620 2003-04-05 Martin Baulig <martin@ximian.com>
7622 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
7624 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7626 * class.cs (Event.Define): Do not allow abstract events to have
7629 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7631 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7632 block in event declarations.
7634 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7635 value type, get its address.
7637 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7638 leaving a class on the stack instead of a boolean value (int
7639 0/1). Change the code so we compare against null, and then the
7640 result against zero.
7642 * class.cs (TypeContainer.GetClassBases): We were checking for the
7643 parent class being sealed too late.
7645 * expression.cs (Binary.Emit): For <= and >= when dealing with
7646 floating point values, use cgt.un and clt.un instead of cgt and
7649 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7651 * statement.cs: Apply the same optimization as MS: skip the
7652 GetEnumerator returning an IEnumerator, and use the one returning a
7653 CharEnumerator instead. This allows us to avoid the try-finally block
7656 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7658 * cs-parser.jay: Attributes cannot be applied to
7659 namespaces. Fixes #40473
7661 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7664 (Add*): check if the name is valid using the full name for constants,
7665 fields, properties and events.
7667 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7669 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7670 char constants to be part of the enumeration.
7672 * expression.cs (Conditional.DoResolve): Add support for operator
7673 true. Implements the missing functionality from 14.12
7675 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7676 operator true/false as required by the spec.
7678 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7679 implicit conversion to boolean.
7681 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7682 also one where the type implements `operator true'.
7684 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7685 get an expression that will invoke operator true based on an
7688 (GetConversionOperators): Removed the hack that called op_True
7691 (Expression.ResolveBoolean): Move this from Statement.
7693 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7695 * ecore.cs (FieldExpr): do not allow initialization of initonly
7696 fields on derived classes
7698 2003-03-13 Martin Baulig <martin@ximian.com>
7700 * statement.cs (Block.Emit): Call ig.BeginScope() and
7701 ig.EndScope() when compiling with debugging info; call
7702 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7704 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7706 * expression.cs (Indexers): Do not construct immediately, allow
7707 for new members to be appended as we go. Fixes 38143
7709 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7711 * expression.cs: save/restore context when resolving an unchecked
7714 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7716 * cfold.cs: Catch division by zero in modulus operator during
7719 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7721 * interface.cs (Interface.DefineMembers): Avoid defining members
7724 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7726 * driver.cs: handle the +/- options for -noconfig
7728 * statement.cs (Unckeched.Resolve): Also track the state of
7729 unchecked in the Resolve phase.
7731 2003-02-27 Martin Baulig <martin@ximian.com>
7733 * ecore.cs (Expression.MemberLookup): Don't create a
7734 MethodGroupExpr for something which is not a method. Fixes #38291.
7736 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7738 * class.cs (MemberBase.CheckParameters): Also check that the type
7739 is unmanaged if it is a pointer.
7741 * expression.cs (SizeOf.Resolve): Add location information.
7743 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7744 a managed type is declared.
7746 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7747 parameter modifiers as well. Fixes bug 38606
7749 * class.cs: Very sad. Am backing out the speed up changes
7750 introduced by the ArrayList -> Array in the TypeContainer, as they
7751 were not actually that much faster, and introduced a bug (no error
7752 reports on duplicated methods).
7754 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7755 source first, this will guarantee that we have a valid expression
7756 before calling in lower levels functions that will require a
7757 resolved object. Then use this original_source in the
7758 target.ResolveLValue instead of the original source that was
7761 Another change. Use target.Resolve instead of LValueResolve.
7762 Although we are resolving for LValues, we will let the Assign code
7763 take care of that (it will be called again from Resolve). This
7764 basically allows code like this:
7766 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7767 class Y { void A (X x) { x [0] += o; }
7769 The problem was that the indexer was trying to resolve for
7770 set_Item (idx, object o) and never finding one. The real set_Item
7771 was set_Item (idx, X). By delaying the process we get the right
7776 2003-02-23 Martin Baulig <martin@ximian.com>
7778 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7779 while calling DoEmit ().
7781 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7782 source files; if you use the #line directive inside a method, the
7783 compiler stops emitting line numbers for the debugger until it
7784 reaches the end of the method or another #line directive which
7785 restores the original file.
7787 2003-02-23 Martin Baulig <martin@ximian.com>
7789 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7791 2003-02-23 Martin Baulig <martin@ximian.com>
7793 * statement.cs (Block.AddChildVariableNames): We need to call this
7794 recursively, not just for our immediate children.
7796 2003-02-23 Martin Baulig <martin@ximian.com>
7798 * class.cs (Event.Define): Always make the field private, like csc does.
7800 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7801 actually work, fixes bug #37521.
7803 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7805 * delegate.cs: When creating the various temporary "Parameters"
7806 classes, make sure that we call the ComputeAndDefineParameterTypes
7807 on those new parameters (just like we do with the formal ones), to
7808 allow them to be resolved in the context of the DeclSpace.
7810 This fixes the bug that Dick observed in Bugzilla #38530.
7812 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7814 * expression.cs (ResolveMemberAccess): When resolving a constant,
7815 do not attempt to pull a constant if the value was not able to
7816 generate a valid constant.
7818 * const.cs (LookupConstantValue): Do not report more errors than required.
7820 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7822 * expression.cs: fixes bug #38328.
7824 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7826 * class.cs: Changed all the various members that can be part of a
7827 class from being an ArrayList to be an Array of the right type.
7828 During the DefineType type_list, interface_list, delegate_list and
7829 enum_list are turned into types, interfaces, delegates and enums
7832 And during the member population, indexer_list, event_list,
7833 constant_list, field_list, instance_constructor_list, method_list,
7834 operator_list and property_list are turned into their real arrays.
7836 Although we could probably perform this operation earlier, for
7837 good error reporting we need to keep the lists and remove the
7838 lists for longer than required.
7840 This optimization was triggered by Paolo profiling the compiler
7841 speed on the output of `gen-sample-program.pl' perl script.
7843 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7844 not crash in methods like MemberLookupFailed that use this field.
7846 This problem arises when the compiler fails to resolve a type
7847 during interface type definition for example.
7849 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7851 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7852 inherit from System.Object, so we have to stop at null, not only
7853 when reaching System.Object.
7855 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7857 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7858 DeclaredOnly because the parent indexer might have had a different
7859 name, but did not loop until the top of the hierarchy was reached.
7861 The problem this one fixes is 35492: when a class implemented an
7862 indexer from an interface, we were getting the interface method
7863 (which was abstract) and we were flagging an error (can not invoke
7866 This also keeps bug 33089 functioning, and test-148 functioning.
7868 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7869 out if a method is special is to see if it is declared in a
7870 property or event, or whether it is one of the predefined operator
7871 names. This should fix correctly #36804.
7873 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7875 The goal here is to remove the dependency on EmptyCast.Peel ().
7876 Killing it completely.
7878 The problem is that currently in a number of places where
7879 constants are expected, we have to "probe" for an EmptyCast, and
7880 Peel, which is not the correct thing to do, as this will be
7881 repetitive and will likely lead to errors.
7883 The idea is to remove any EmptyCasts that are used in casts that
7884 can be reduced to constants, so we only have to cope with
7887 This bug hunt was triggered by Bug 37363 and the desire to remove
7888 the duplicate pattern where we were "peeling" emptycasts to check
7889 whether they were constants. Now constants will always be
7892 * ecore.cs: Use an enumconstant here instead of wrapping with
7895 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7896 throwing me off. By handling this we can get rid of a few hacks.
7898 * statement.cs (Switch): Removed Peel() code.
7900 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7902 * class.cs: Location information for error 508
7904 * expression.cs (New.DoResolve): Add a guard against double
7905 resolution of an expression.
7907 The New DoResolve might be called twice when initializing field
7908 expressions (see EmitFieldInitializers, the call to
7909 GetInitializerExpression will perform a resolve on the expression,
7910 and later the assign will trigger another resolution
7912 This leads to bugs (#37014)
7914 * delegate.cs: The signature for EndInvoke should contain any ref
7915 or out parameters as well. We were not doing this in the past.
7917 * class.cs (Field.Define): Do not overwrite the type definition
7918 inside the `volatile' group. Turns out that volatile enumerations
7919 were changing the type here to perform a validity test, which
7922 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7924 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7925 and structs, we do not want to load the instance variable
7927 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7928 enum_type has to be handled like an object reference (implicit
7929 conversions exists from this to object), but the regular IsClass
7930 and IsValueType tests will never return true for this one.
7932 Also we use TypeManager.IsValueType instead of type.IsValueType,
7933 just for consistency with the rest of the code (this is only
7934 needed if we ever use the construct exposed by test-180.cs inside
7935 corlib, which we dont today).
7937 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7939 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7942 2003-02-09 Martin Baulig <martin@ximian.com>
7944 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7945 (Namespace.DefineNamespaces): New static public method; this is
7946 called when we're compiling with debugging to add all namespaces
7949 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7950 pass it to the Namespace's .ctor.
7952 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7953 and MethodBase arguments; pass the namespace ID to the symwriter;
7954 pass the MethodBase instead of the token to the symwriter.
7955 (SymbolWriter.DefineNamespace): New method to add a namespace to
7958 2003-02-09 Martin Baulig <martin@ximian.com>
7960 * symbolwriter.cs: New file. This is a wrapper around
7961 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7962 methods here in near future.
7964 2003-02-09 Martin Baulig <martin@ximian.com>
7966 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7967 ILGenerator.MarkSequencePoint() which are actually used by the
7970 2003-02-09 Martin Baulig <martin@ximian.com>
7972 * location.cs (SourceFile): New public sealed class. This
7973 contains the name and an index which is used in the location's token.
7974 (Location): Reserve an appropriate number of bits in the token for
7975 the source file instead of walking over that list, this gives us a
7976 really huge performance improvement when compiling with debugging.
7978 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7979 `SourceFile' argument instead of a string.
7980 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7981 but don't parse/tokenize here, we need to generate the list of all
7982 source files before we do that.
7983 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7986 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7987 instead of a string.
7989 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7992 2003-02-09 Martin Baulig <martin@ximian.com>
7994 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7995 filename on `#line default'.
7997 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7999 * statement.cs: don't clear the pinned var when the fixed statement
8000 returns from the method (fixes bug#37752).
8002 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
8004 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
8007 2003-02-07 Martin Baulig <martin@ximian.com>
8009 * driver.cs: Removed the `--debug-args' command line argument.
8011 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
8012 automatically by the AsssemblyBuilder.
8013 (CodeGen.InitializeSymbolWriter): We don't need to call any
8014 initialization function on the symbol writer anymore. This method
8015 doesn't take any arguments.
8017 2003-02-03 Miguel de Icaza <miguel@ximian.com>
8019 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
8020 from referenced assemblies as well.
8022 2003-02-02 Martin Baulig <martin@ximian.com>
8024 * class.cs (MethodData.Emit): Generate debugging info for external methods.
8026 2003-02-02 Martin Baulig <martin@ximian.com>
8028 * class.cs (Constructor.Emit): Open the symbol writer before
8029 emitting the constructor initializer.
8030 (ConstructorInitializer.Emit): Call ec.Mark() to allow
8031 single-stepping through constructor initializers.
8033 2003-01-30 Miguel de Icaza <miguel@ximian.com>
8035 * class.cs: Handle error 549: do not allow virtual methods in
8038 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
8040 * decl.cs: Check access levels when resolving types
8042 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
8044 * statement.cs: Add parameters and locals set in catch blocks that might
8045 return to set vector
8047 2003-01-29 Miguel de Icaza <miguel@ximian.com>
8049 * class.cs (Operator): Set the SpecialName flags for operators.
8051 * expression.cs (Invocation.DoResolve): Only block calls to
8052 accessors and operators on SpecialName methods.
8054 (Cast.TryReduce): Handle conversions from char constants.
8057 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
8059 * statement.cs: small memory and time optimization in FlowBranching.
8061 2003-01-28 Pedro Mart <yoros@wanadoo.es>
8063 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
8064 problem that the last fix but in the other sid (Set).
8066 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
8067 access when there is no indexer in the hierarchy.
8069 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
8071 * class.cs: Combine some if statements.
8073 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8075 * driver.cs: fixed bug #37187.
8077 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
8079 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
8080 any indexer, it's needed to build a list with all the indexers in the
8081 hierarchy (AllGetters), else we have problems. Fixes #35653.
8083 2003-01-23 Miguel de Icaza <miguel@ximian.com>
8085 * class.cs (MethodData.Define): It is wrong for an interface
8086 implementation to be static in both cases: explicit and implicit.
8087 We were only handling this in one case.
8089 Improve the if situation there to not have negations.
8091 * class.cs (Field.Define): Turns out that we do not need to check
8092 the unsafe bit on field definition, only on usage. Remove the test.
8094 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8096 * driver.cs: use assembly.Location instead of Codebase (the latest
8097 patch made mcs fail when using MS assemblies).
8099 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
8101 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
8102 get the path to *corlib.dll.
8104 2003-01-21 Nick Drochak <ndrochak@gol.com>
8108 * typemanager.cs: Remove compiler warnings
8110 2003-01-20 Duncan Mak <duncan@ximian.com>
8112 * AssemblyInfo.cs: Bump the version number to 0.19.
8114 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8116 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
8118 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
8120 * class.cs (Constructor::Emit): Emit debugging info for constructors.
8122 2003-01-17 Miguel de Icaza <miguel@ximian.com>
8124 * cs-parser.jay: Small fix: we were not comparing the constructor
8125 name correctly. Thanks to Zoltan for the initial pointer.
8127 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
8129 * cs-tokenizer.cs: Set file name when specified with #line
8131 2003-01-15 Miguel de Icaza <miguel@ximian.com>
8133 * cs-parser.jay: Only perform the constructor checks here if we
8134 are named like the class; This will help provider a better
8135 error. The constructor path is taken when a type definition is
8136 not found, but most likely the user forgot to add the type, so
8137 report that rather than the constructor error.
8139 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
8141 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
8144 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8146 * cs-parser.jay: Add cleanup call.
8148 2003-01-13 Duncan Mak <duncan@ximian.com>
8150 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
8151 consistent with other methods.
8153 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8155 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
8157 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
8159 * attribute.cs: only set GuidAttr to true when we have a
8162 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8166 * typemanager.cs: fixes to allow mcs compile corlib with the new
8167 Type.IsSubclassOf fix.
8169 2003-01-08 Miguel de Icaza <miguel@ximian.com>
8171 * expression.cs (LocalVariableReference.DoResolve): Classify a
8172 constant as a value, not as a variable. Also, set the type for
8175 * cs-parser.jay (fixed_statement): take a type instead of a
8176 pointer_type, so we can produce a better error message later.
8178 * statement.cs (Fixed.Resolve): Flag types that are not pointers
8181 (For.DoEmit): Make inifinite loops have a
8182 non-conditional branch back.
8184 (Fixed.DoEmit): First populate the pinned variables, then emit the
8185 statement, then clear the variables. Before I was emitting the
8186 code once for each fixed piece.
8189 2003-01-08 Martin Baulig <martin@ximian.com>
8191 * statement.cs (FlowBranching.MergeChild): A break in a
8192 SWITCH_SECTION does not leave a loop. Fixes #36155.
8194 2003-01-08 Martin Baulig <martin@ximian.com>
8196 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
8197 lives in the same number space than `param_map'. Fixes #36154.
8199 2003-01-07 Miguel de Icaza <miguel@ximian.com>
8201 * cs-parser.jay (constructor_declaration): Set the
8202 Constructor.ModFlags before probing for it. This makes the
8203 compiler report 514, 515 and 132 (the code was there, but got
8206 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
8207 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
8208 (GotoCase.Resolve): Set `Returns' to ALWAYS.
8210 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
8212 * enum.cs: create the enum static fields using the enum type.
8214 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
8216 * class.cs: don't try to create the ParamBuilder for the return
8217 type if it's not needed (and handle it breaking for the ms runtime
8220 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
8222 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
8224 2002-12-29 Miguel de Icaza <miguel@ximian.com>
8226 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
8227 the command. This showed up while compiling the JANET source
8228 code, which used \r as its only newline separator.
8230 2002-12-28 Miguel de Icaza <miguel@ximian.com>
8232 * class.cs (Method.Define): If we are an operator (because it
8233 reuses our code), then set the SpecialName and HideBySig. #36128
8235 2002-12-22 Miguel de Icaza <miguel@ximian.com>
8237 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
8238 exception, report error 120 `object reference required'.
8240 * driver.cs: Add --pause option, used during to measure the size
8241 of the process as it goes with --timestamp.
8243 * expression.cs (Invocation.DoResolve): Do not allow methods with
8244 SpecialName to be invoked.
8246 2002-12-21 Miguel de Icaza <miguel@ximian.com>
8248 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
8249 number before adding it.
8251 2002-12-21 Ravi Pratap <ravi@ximian.com>
8253 * ecore.cs (StandardImplicitConversion): When in an unsafe
8254 context, we allow conversion between void * to any other pointer
8255 type. This fixes bug #35973.
8257 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
8259 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
8260 is not thrown when extensionless outputs are used
8262 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8264 * rootcontext.cs: fixed compilation of corlib.
8266 2002-12-19 Miguel de Icaza <miguel@ximian.com>
8268 * attribute.cs (Attributes.Contains): Add new method.
8270 * class.cs (MethodCore.LabelParameters): if the parameter is an
8271 `out' parameter, check that no attribute `[In]' has been passed.
8273 * enum.cs: Handle the `value__' name in an enumeration.
8275 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
8277 * decl.cs: Added special case to allow overrides on "protected
8280 2002-12-18 Ravi Pratap <ravi@ximian.com>
8282 * attribute.cs (Attributes.AddAttributeSection): Rename to this
8283 since it makes much more sense.
8285 (Attributes.ctor): Don't require a Location parameter.
8287 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
8289 * attribute.cs (ApplyAttributes): Remove extra Location parameters
8290 since we already have that information per attribute.
8292 * everywhere : make appropriate changes.
8294 * class.cs (LabelParameters): Write the code which actually
8295 applies attributes to the return type. We can't do this on the MS
8296 .NET runtime so we flag a warning in the case an exception is
8299 2002-12-18 Miguel de Icaza <miguel@ximian.com>
8301 * const.cs: Handle implicit null conversions here too.
8303 2002-12-17 Ravi Pratap <ravi@ximian.com>
8305 * class.cs (MethodCore.LabelParameters): Remove the extra
8306 Type [] parameter since it is completely unnecessary. Instead
8307 pass in the method's attributes so that we can extract
8308 the "return" attribute.
8310 2002-12-17 Miguel de Icaza <miguel@ximian.com>
8312 * cs-parser.jay (parse): Use Report.Error to flag errors instead
8313 of ignoring it and letting the compile continue.
8315 * typemanager.cs (ChangeType): use an extra argument to return an
8316 error condition instead of throwing an exception.
8318 2002-12-15 Miguel de Icaza <miguel@ximian.com>
8320 * expression.cs (Unary.TryReduce): mimic the code for the regular
8321 code path. Perform an implicit cast in the cases where we can
8322 implicitly convert to one of the integral types, and then reduce
8323 based on that constant. This fixes bug #35483.
8325 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8327 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
8329 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8331 * namespace.cs: fixed bug #35489.
8333 2002-12-12 Miguel de Icaza <miguel@ximian.com>
8335 * class.cs: Remove some dead code.
8337 * cs-parser.jay: Estimate the number of methods needed
8338 (RootContext.MethodCount);
8340 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
8341 numbers instead of StringBuilders.
8343 * support.cs (PtrHashtable): Add constructor with initial size;
8344 We can now reduce reallocations of the method table.
8346 2002-12-10 Ravi Pratap <ravi@ximian.com>
8348 * attribute.cs (ApplyAttributes): Keep track of the emitted
8349 attributes on a per-target basis. This fixes bug #35413.
8351 2002-12-10 Miguel de Icaza <miguel@ximian.com>
8353 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
8354 default to the Windows 1252 encoding.
8356 (UnixParseOption): Support version, thanks to Alp for the missing
8359 * AssemblyInfo.cs: Add nice assembly information.
8361 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
8364 * cs-parser.jay: Allow a trailing comma before the close bracked
8365 in the attribute_section production.
8367 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
8368 address of the instance was being taken, I will take this out,
8369 because we take the address of the object immediately here.
8371 2002-12-09 Ravi Pratap <ravi@ximian.com>
8373 * typemanager.cs (AreMultipleAllowed): Take care of the most
8374 obvious case where attribute type is not in the current assembly -
8377 2002-12-08 Miguel de Icaza <miguel@ximian.com>
8379 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
8380 definitions, instead of doing that afterwards.
8382 Also we use a nice little hack, depending on the constructor, we
8383 know if we are a "composed" name or a simple name. Hence, we
8384 avoid the IndexOf test, and we avoid
8386 * codegen.cs: Add code to assist in a bug reporter to track down
8387 the source of a compiler crash.
8389 2002-12-07 Ravi Pratap <ravi@ximian.com>
8391 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
8392 types have been emitted for a given element and flag an error
8393 if something which does not have AllowMultiple set is used more
8396 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
8397 attribute types and their corresponding AllowMultiple properties
8399 (AreMultipleAllowed): Check the property for a given type.
8401 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
8402 property in the case we have a TypeContainer.
8404 (Attributes.AddAttribute): Detect duplicates and just skip on
8405 adding them. This trivial fix catches a pretty gross error in our
8406 attribute emission - global attributes were being emitted twice!
8408 Bugzilla bug #33187 is now fixed.
8410 2002-12-06 Miguel de Icaza <miguel@ximian.com>
8412 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
8415 * expression.cs (Binary.ResolveOperator): I can only use the
8416 Concat (string, string, string) and Concat (string, string,
8417 string, string) if the child is actually a concatenation of
8420 2002-12-04 Miguel de Icaza <miguel@ximian.com>
8422 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
8423 context where we need a 2-character lookahead.
8425 * pending.cs (PendingImplementation): Rework so we can keep track
8426 of interface types all the time, and flag those which were
8427 implemented by parents as optional.
8429 2002-12-03 Miguel de Icaza <miguel@ximian.com>
8431 * expression.cs (Binary.ResolveOperator): Use
8432 String.Concat(string,string,string) or
8433 String.Concat(string,string,string,string) when possible.
8435 * typemanager: More helper methods.
8438 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
8440 * pending.cs: remove the bogus return from GetMissingInterfaces()
8441 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
8443 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8445 * namespace.cs: avoid duplicated 'using xxx' being added to
8446 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
8447 when we get more than one 'using' statement for the same namespace.
8448 Report a CS0105 warning for it.
8450 2002-11-30 Miguel de Icaza <miguel@ximian.com>
8452 * cs-tokenizer.cs (consume_identifier): use read directly, instead
8453 of calling getChar/putback, uses internal knowledge of it.
8455 (xtoken): Reorder tokenizer so most common patterns are checked
8456 first. This reduces the compilation time in another 5% (from 8.11s
8457 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
8459 The parsing time is 22% of the compilation in mcs, and from that
8460 64% is spent on the tokenization process.
8462 I tried using a binary search for keywords, but this is slower
8463 than the hashtable. Another option would be to do a couple of
8466 * Not use a StringBuilder, instead use an array of chars,
8467 with a set value. Notice that this way we could catch
8468 the 645 error without having to do it *afterwards*.
8470 * We could write a hand-parser to avoid the hashtable
8471 compares altogether.
8473 The identifier consumption process takes 37% of the tokenization
8474 time. Another 15% is spent on is_number. 56% of the time spent
8475 on is_number is spent on Int64.Parse:
8477 * We could probably choose based on the string length to
8478 use Int32.Parse or Int64.Parse and avoid all the 64-bit
8481 Another 3% is spend on wrapping `xtoken' in the `token' function.
8483 Handle 0xa0 as whitespace (#34752)
8485 2002-11-26 Miguel de Icaza <miguel@ximian.com>
8487 * typemanager.cs (IsCLRType): New routine to tell whether a type
8488 is one of the builtin types.
8490 Maybe it needs to use TypeCodes to be faster. Maybe we could use
8491 typecode in more places instead of doing pointer comparissions.
8492 We could leverage some knowledge about the way the typecodes are
8495 New code to cache namespaces in assemblies, it is currently not
8496 invoked, to be used soon.
8498 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
8500 * expression.cs (Binary.ResolveOperator): specially handle
8501 strings, and do not perform user-defined operator overloading for
8504 2002-11-24 Miguel de Icaza <miguel@ximian.com>
8506 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
8507 internalcall as it is a pretty simple operation; Avoid whenever
8508 possible to call Char.IsLetter.
8510 (consume_identifier): Cut by half the number of
8511 hashtable calls by merging the is_keyword and GetKeyword behavior.
8513 Do not short-circuit, because if we do, we
8514 report errors (ie, #if false && true would produce an invalid
8518 2002-11-24 Martin Baulig <martin@ximian.com>
8520 * expression.cs (Cast.TryReduce): If we're in checked syntax,
8521 check constant ranges and report a CS0221. Fixes #33186.
8523 2002-11-24 Martin Baulig <martin@ximian.com>
8525 * cs-parser.jay: Make this work for uninitialized variable
8526 declarations in the `for' initializer. Fixes #32416.
8528 2002-11-24 Martin Baulig <martin@ximian.com>
8530 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
8531 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
8533 2002-11-24 Martin Baulig <martin@ximian.com>
8535 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
8536 argument; if true, we also check for user-defined conversions.
8537 This is only needed if both arguments are of a user-defined type.
8538 Fixes #30443, added test-175.cs.
8539 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
8541 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
8543 2002-11-24 Martin Baulig <martin@ximian.com>
8545 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8546 function to get the store opcode.
8547 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8548 only emit the Ldelema if the store opcode is Stobj. You must run
8549 both test-34 and test-167 to test this. Fixes #34529.
8551 2002-11-23 Martin Baulig <martin@ximian.com>
8553 * ecore.cs (Expression.MemberLookup): Added additional
8554 `qualifier_type' argument which is used when we're being called
8555 from MemberAccess.DoResolve() and null if we're called from a
8557 (Expression.MemberLookupFailed): New method to report errors; this
8558 does the CS1540 check and reports the correct error message.
8560 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8561 argument for the CS1540 check and redone the way how we're dealing
8562 with private members. See the comment in the source code for details.
8563 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8564 `closure_start_type' to `closure_qualifier_type' and check whether
8565 it's not null. It was not this filter being broken, it was just
8566 being called with the wrong arguments.
8568 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8569 and pass it the correct `qualifier_type'; this also does the error
8572 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8574 * expression.cs (Invocation.EmitParams): If the we are dealing
8575 with a non-built-in value type, load its address as well.
8577 (ArrayCreation): Use a a pretty constant instead
8578 of the hardcoded value 2. Use 6 instead of 2 for the number of
8579 static initializers.
8581 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8582 because they are not really value types, just glorified integers.
8584 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8586 * ecore.cs: Remove redundant code for enumerations, make them use
8587 the same code path as everything else, fixes the casting issue
8588 with enumerations in Windows.Forms.
8590 * attribute.cs: Do only cast to string if it is a string, the
8591 validation happens later.
8593 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8594 people upgrade their corlibs.
8596 * ecore.cs: Oops, enumerations were not following the entire code path
8598 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8600 * typemanager.cs (FilterWithClosure): Commented out the test for
8601 1540 in typemanager.cs, as it has problems when accessing
8602 protected methods from a parent class (see test-174.cs).
8604 * attribute.cs (Attribute.ValidateGuid): new method.
8605 (Attribute.Resolve): Use above.
8607 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8609 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8611 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8612 handling for enumerations, as we only needed the TypeContainer
8613 functionality to begin with (this is required for the fix below to
8614 work for enums that reference constants in a container class for
8617 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8619 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8620 a valid TypeBuilder to perform lookups on.o
8622 * class.cs (InheritableMemberSignatureCompare): Use true in the
8623 call to GetGetMethod and GetSetMethod, because we are comparing
8624 the signature, and we need to get the methods *even* if they are
8627 (PropertyBase.CheckBase): ditto.
8629 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8630 GotoCase.Resolve): Use Peel on EmpytCasts.
8632 * ecore.cs (EmptyCast): drop child, add Peel method.
8634 2002-11-17 Martin Baulig <martin@ximian.com>
8636 * ecore.cs (EmptyCast.Child): New public property.
8638 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8639 label resolved to an EmptyCast. Fixes #34162.
8640 (GotoCase.Resolve): Likewise.
8641 (Block.EmitMeta): Likewise.
8643 2002-11-17 Martin Baulig <martin@ximian.com>
8645 * expression.cs (Invocation.BetterConversion): Prefer int over
8646 uint; short over ushort; long over ulong for integer literals.
8647 Use ImplicitConversionExists instead of StandardConversionExists
8648 since we also need to check for user-defined implicit conversions.
8649 Fixes #34165. Added test-173.cs.
8651 2002-11-16 Martin Baulig <martin@ximian.com>
8653 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8654 with the `true' and `false' literals. Fixes #33151.
8656 2002-11-16 Martin Baulig <martin@ximian.com>
8658 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8659 October 22nd; don't do the cs1540 check for static members.
8661 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8662 now using our own filter here and doing the cs1540 check again.
8664 2002-11-16 Martin Baulig <martin@ximian.com>
8666 * support.cs (InternalParameters): Don't crash if we don't have
8667 any fixed parameters. Fixes #33532.
8669 2002-11-16 Martin Baulig <martin@ximian.com>
8671 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8672 when looking up static methods to make this work on Windows.
8675 2002-11-16 Martin Baulig <martin@ximian.com>
8677 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8678 a setter rather than using PropertyInfo.CanWrite.
8680 2002-11-15 Nick Drochak <ndrochak@gol.com>
8682 * class.cs: Allow acces to block member by subclasses. Fixes build
8685 2002-11-14 Martin Baulig <martin@ximian.com>
8687 * class.cs (Constructor.Emit): Added the extern/block check.
8690 2002-11-14 Martin Baulig <martin@ximian.com>
8692 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8693 iteration while looking for indexers, this is needed because the
8694 indexer may have a different name in our base classes. Fixed the
8695 error reporting (no indexers at all, not get accessor, no
8696 overloaded match). Fixes bug #33089.
8697 (IndexerAccess.DoResolveLValue): Likewise.
8699 2002-11-14 Martin Baulig <martin@ximian.com>
8701 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8702 indexers. Fixes the first part of bug #33089.
8703 (MethodSignature.InheritableMemberSignatureCompare): Added support
8706 2002-11-13 Ravi Pratap <ravi@ximian.com>
8708 * attribute.cs (Attribute.Resolve): Catch the
8709 NullReferenceException and report it since it isn't supposed to
8712 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8714 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8715 LogicalOr and LogicalAnd that can benefit from recursively
8716 handling EmitBranchable. The code now should be nice for Paolo.
8718 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8720 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8721 the Type lookups, as we perform quite a number of lookups on
8722 non-Types. This can be removed once we can deterministically tell
8723 whether we have a type or a namespace in advance.
8725 But this might require special hacks from our corlib.
8729 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8730 and double which avoids a conversion from an integer to a double.
8732 * expression.cs: tiny optimization, avoid calling IsConstant,
8733 because it effectively performs the lookup twice.
8735 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8737 But a bogus return here to keep the semantics of the old code
8738 until the Mono runtime is fixed.
8740 * pending.cs (GetMissingInterfaces): New method used to remove all
8741 the interfaces that are already implemented by our parent
8742 classes from the list of pending methods.
8744 * interface.cs: Add checks for calls after ResolveTypeExpr.
8746 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8748 * class.cs (Class.Emit): Report warning 67: event not used if the
8749 warning level is beyond 3.
8751 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8752 being a NullLiteral.
8754 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8757 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8758 path that might fail if a type can not be resolved.
8760 * expression.cs (Binary.Emit): Emit unsigned versions of the
8763 * driver.cs: use error 5.
8765 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8767 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8769 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8771 * cs-parser.jay (switch_section): A beautiful patch from Martin
8772 Baulig that fixed 33094.
8774 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8776 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8777 Check whether the base is abstract and report an error if so.
8779 * expression.cs (IndexerAccess.DoResolveLValue,
8780 IndexerAccess.DoResolve): ditto.
8782 (Invocation.DoResolve): ditto.
8784 (Invocation.FullMethodDesc): Improve the report string.
8786 * statement.cs (Block): Eliminate IsVariableDefined as it is
8787 basically just a wrapper for GetVariableInfo.
8789 * ecore.cs (SimpleName): Use new
8791 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8792 type, as we return the actual parameter ref/unref state on a
8795 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8797 * support.cs: Return proper flags REF/OUT fixing the previous
8800 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8801 not used to mean `ref' but `ref or out' in ParameterReference
8803 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8804 full type signature instead of calling TypeManger.CSharpName
8807 * support.cs (InternalParameters.ParameterDesc): Do not compare
8808 directly to the modflags, because REF/OUT will actually be bitsets
8811 * delegate.cs (VerifyMethod): Check also the modifiers.
8813 * cs-tokenizer.cs: Fix bug where floating point values with an
8814 exponent where a sign was missing was ignored.
8816 * driver.cs: Allow multiple assemblies to be specified in a single
8819 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8821 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8822 because identifiers after a parenthesis would end up in this kind
8823 of production, and we needed to desamiguate it for having casts
8826 (UserDefinedType *) xxx
8828 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8830 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8831 we should set on the Bindingflags.NonPublic, but not turn on
8832 private_ok. private_ok controls whether a Private member is
8833 returned (this is chekced on the filter routine), while the
8834 BindingFlags.NonPublic just controls whether private/protected
8835 will be allowed. This fixes the problem part of the problem of
8836 private properties being allowed to be used in derived classes.
8838 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8839 so we can call the children DoResolveLValue method (this will
8840 properly signal errors on lvalue assignments to base properties)
8842 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8843 getter are null, and we have a property info, we know that this
8844 happened because the lookup failed, so we report an error 122 for
8845 protection level violation.
8847 We also silently return if setter and getter are null in the
8848 resolve functions, this condition only happens if we have flagged
8849 the error before. This is the other half of the problem.
8851 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8852 not have accessibility information, that is why we were returning
8853 true in the filter function in typemanager.cs.
8855 To properly report 122 (property is inaccessible because of its
8856 protection level) correctly, we report this error in ResolveAccess
8857 by failing if both the setter and the getter are lacking (ie, the
8860 DoResolve and DoLResolve have been modified to check for both
8861 setter/getter being null and returning silently, the reason being
8862 that I did not want to put the knowledge about this error in upper
8865 int old = Report.Errors;
8866 x = new PropertyExpr (...);
8867 if (old != Report.Errors)
8872 So the property expr is returned, but it is invalid, so the error
8873 will be flagged during the resolve process.
8875 * class.cs: Remove InheritablePropertySignatureCompare from the
8876 class, as we no longer depend on the property signature to compute
8877 whether it is possible to implement a method or not.
8879 The reason is that calling PropertyInfo.GetGetMethod will return
8880 null (in .NET, in Mono it works, and we should change this), in
8881 cases where the Get Method does not exist in that particular
8886 class X { public virtual int A { get { return 1; } } }
8888 class Z : Y { public override int A { get { return 2; } } }
8890 Would fail in Z because the parent (Y) would not have the property
8891 defined. So we avoid this completely now (because the alternative
8892 fix was ugly and slow), and we now depend exclusively on the
8895 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8896 reference method, instead of using the property.
8898 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8899 routines are gone now.
8901 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8902 names, they were incorrectly named.
8904 * cs-tokenizer.cs: Return are more gentle token on failure.
8906 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8907 had an out-of-sync index variable, which caused it to remove from
8908 the list of pending methods the wrong method sometimes.
8910 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8912 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8913 CanWrite, because those refer to this particular instance of the
8914 property, and do not take into account the fact that we can
8915 override single members of a property.
8917 Constructor requires an EmitContext. The resolution process does
8918 not happen here, but we need to compute the accessors before,
8919 because the resolution does not always happen for properties.
8921 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8922 subclass, before we did not update this flag, but we did update
8925 (GetAccessors): Drop this routine, as it did not work in the
8926 presence of partially overwritten set/get methods.
8928 Notice that this broke the cs1540 detection, but that will require
8931 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8935 * driver.cs: issue a warning instead of an error if we don't support
8936 debugging for the platform. Also ignore a couple of errors that may
8937 arise when trying to write the symbols. Undo my previous patch.
8939 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8941 * driver.cs: ignore /debug switch except for Unix platforms.
8943 2002-10-23 Nick Drochak <ndrochak@gol.com>
8945 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8947 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8949 * driver.cs: Do not make mcs-debug conditional, so we do not break
8952 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8953 review this patch. But basically after all the children variables
8954 have been merged, the value of "Breaks" was not being set to
8955 new_breaks for Switch blocks. I think that it should be set after
8956 it has executed. Currently I set this to the value of new_breaks,
8957 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8958 conservative, but I do not understand this code very well.
8960 I did not break anything in the build, so that is good ;-)
8962 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8964 2002-10-20 Mark Crichton <crichton@gimp.org>
8966 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8968 2002-10-20 Nick Drochak <ndrochak@gol.com>
8970 * cfold.cs: Fixed compile blocker.
8972 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8974 * driver.cs: I was chekcing the key, not the file.
8976 2002-10-19 Ravi Pratap <ravi@ximian.com>
8978 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8979 message that we were generating - we just need to silently return
8982 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8984 * class.cs (Event.Define): Change my previous commit, as this
8985 breaks the debugger. This is a temporary hack, as it seems like
8986 the compiler is generating events incorrectly to begin with.
8988 * expression.cs (Binary.ResolveOperator): Added support for
8989 "U operator - (E x, E y)"
8991 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8994 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8995 init-only variables, but this path did not take into account that
8996 there might be also instance readonly variables. Correct this
8999 This fixes bug 32253
9001 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
9004 * driver.cs: Change the extension for modules to `netmodule'
9006 * cs-parser.jay: Improved slightly the location tracking for
9007 the debugger symbols.
9009 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
9010 modifiers that were specified instead of the hardcoded value
9011 (FamAndAssem). This was basically ignoring the static modifier,
9012 and others. Fixes 32429.
9014 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
9015 fixed a bug in the process (32476)
9017 * expression.cs (ArrayAccess.EmitAssign): Patch from
9018 hwang_rob@yahoo.ca that fixes bug 31834.3
9020 2002-10-18 Miguel de Icaza <miguel@ximian.com>
9022 * driver.cs: Make the module extension .netmodule.
9024 2002-10-16 Miguel de Icaza <miguel@ximian.com>
9026 * driver.cs: Report an error if the resource file is not found
9027 instead of crashing.
9029 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
9030 false, like Emit does.
9032 2002-10-16 Nick Drochak <ndrochak@gol.com>
9034 * typemanager.cs: Remove unused private member. Also reported mcs
9035 bug to report this as a warning like csc.
9037 2002-10-15 Martin Baulig <martin@gnome.org>
9039 * statement.cs (Statement.Emit): Made this a virtual method; emits
9040 the line number info and calls DoEmit().
9041 (Statement.DoEmit): New protected abstract method, formerly knows
9042 as Statement.Emit().
9044 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
9046 2002-10-11 Miguel de Icaza <miguel@ximian.com>
9048 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
9049 have fixed a remaining problem: not every AddXXXX was adding a
9050 fully qualified name.
9052 Now everyone registers a fully qualified name in the DeclSpace as
9053 being defined instead of the partial name.
9055 Downsides: we are slower than we need to be due to the excess
9056 copies and the names being registered this way.
9058 The reason for this is that we currently depend (on the corlib
9059 bootstrap for instance) that types are fully qualified, because
9060 we dump all the types in the namespace, and we should really have
9061 types inserted into the proper namespace, so we can only store the
9062 basenames in the defined_names array.
9064 2002-10-10 Martin Baulig <martin@gnome.org>
9066 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
9067 from bug #31834, see the bug report for a testcase which is
9070 2002-10-10 Martin Baulig <martin@gnome.org>
9072 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
9073 flow analysis code for this.
9075 * statement.cs (Do, While, For): Tell the flow analysis code about
9077 (FlowBranching.UsageVector): Added support for infinite loops.
9078 (Block.Resolve): Moved the dead code elimination here and use flow
9081 2002-10-09 Miguel de Icaza <miguel@ximian.com>
9083 * class.cs (Field.Define): Catch cycles on struct type
9086 * typemanager.cs (IsUnmanagedtype): Do not recursively check
9087 fields if the fields are static. We only need to check instance
9090 * expression.cs (As.DoResolve): Test for reference type.
9092 * statement.cs (Using.ResolveExpression): Use
9093 ConvertImplicitRequired, not ConvertImplicit which reports an
9095 (Using.ResolveLocalVariableDecls): ditto.
9097 * expression.cs (Binary.ResolveOperator): Report errors in a few
9098 places where we had to.
9100 * typemanager.cs (IsUnmanagedtype): Finish implementation.
9102 2002-10-08 Miguel de Icaza <miguel@ximian.com>
9104 * expression.cs: Use StoreFromPtr instead of extracting the type
9105 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
9107 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
9108 an enumeration value to a System.Enum, but System.Enum is not a
9109 value type, but an class type, so we need to box.
9111 (Expression.ConvertExplicit): One codepath could return
9112 errors but not flag them. Fix this. Fixes #31853
9114 * parameter.cs (Resolve): Do not allow void as a parameter type.
9116 2002-10-06 Martin Baulig <martin@gnome.org>
9118 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
9119 if it's a class type and not a struct. Fixes #31815.
9121 2002-10-06 Martin Baulig <martin@gnome.org>
9123 * statement.cs: Reworked the flow analysis code a bit to make it
9124 usable for dead code elimination.
9126 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9128 * cs-parser.jay: allow empty source files. Fixes bug #31781.
9130 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9132 * expression.cs (ComposedCast.DoResolveType): A quick workaround
9133 to fix the test 165, will investigate deeper.
9135 2002-10-04 Martin Baulig <martin@gnome.org>
9137 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
9138 finally blocks actually work.
9139 (Try.Resolve): We don't need to create a sibling for `finally' if
9140 there is no finally block.
9142 2002-10-04 Martin Baulig <martin@gnome.org>
9144 * class.cs (Constructor.Define): The default accessibility for a
9145 non-default constructor is private, not public.
9147 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9149 * class.cs (Constructor): Make AllowedModifiers public, add
9152 * cs-parser.jay: Perform the modifiers test here, as the
9153 constructor for the Constructor class usually receives a zero
9154 because of the way we create it (first we create, later we
9155 customize, and we were never checking the modifiers).
9157 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
9158 is a version of LookupTypeReflection that includes the type-name
9159 cache. This can be used as a fast path for functions that know
9160 the fully qualified name and are only calling into *.GetType() to
9161 obtain a composed type.
9163 This is also used by TypeManager.LookupType during its type
9166 (LookupType): We now also track the real type name, as sometimes
9167 we can get a quey for the real type name from things like
9168 ComposedCast. This fixes bug 31422.
9170 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
9171 complete type fullname, it does not have to go through the type
9172 resolution system to obtain the composed version of the type (for
9173 obtaining arrays or pointers).
9175 (Conditional.Emit): Use the EmitBoolExpression to
9176 generate nicer code, as requested by Paolo.
9178 (ArrayCreation.CheckIndices): Use the patch from
9179 hwang_rob@yahoo.ca to validate the array initializers.
9181 2002-10-03 Miguel de Icaza <miguel@ximian.com>
9183 * class.cs (ConstructorInitializer.Emit): simplify code by using
9184 Invocation.EmitCall, and at the same time, fix the bugs in calling
9185 parent constructors that took variable arguments.
9187 * ecore.cs (Expression.ConvertNumericExplicit,
9188 Expression.ImplicitNumericConversion): Remove the code that
9189 manually wrapped decimal (InternalTypeConstructor call is now gone
9192 * expression.cs (Cast.TryReduce): Also handle decimal types when
9193 trying to perform a constant fold on the type.
9195 * typemanager.cs (IsUnmanagedtype): Partially implemented.
9197 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
9198 that only turned off an error report, and did nothing else.
9200 2002-10-02 Miguel de Icaza <miguel@ximian.com>
9202 * driver.cs: Handle and ignore /fullpaths
9204 2002-10-01 Miguel de Icaza <miguel@ximian.com>
9206 * expression.cs (Binary.ResolveOperator): Catch the case where
9207 DoNumericPromotions returns true,
9209 (Binary.DoNumericPromotions): Simplify the code, and the tests.
9211 2002-09-27 Miguel de Icaza <miguel@ximian.com>
9213 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
9216 2002-09-26 Miguel de Icaza <miguel@ximian.com>
9218 * ecore.cs (ConvertNumericExplicit): It is not enough that the
9219 conversion exists, but it is also required that the conversion be
9220 performed. This manifested in "(Type64Enum) 2".
9222 * class.cs (TypeManager.AddMethod): The fix is not to change
9223 AddEnum, because that one was using a fully qualified name (every
9224 DeclSpace derivative does), but to change the AddMethod routine
9225 that was using an un-namespaced name. This now correctly reports
9226 the duplicated name.
9228 Revert patch until I can properly fix it. The issue
9229 is that we have a shared Type space across all namespaces
9230 currently, which is wrong.
9232 Options include making the Namespace a DeclSpace, and merge
9233 current_namespace/current_container in the parser.
9235 2002-09-25 Miguel de Icaza <miguel@ximian.com>
9237 * cs-parser.jay: Improve error reporting when we get a different
9238 kind of expression in local_variable_type and
9239 local_variable_pointer_type.
9241 Propagate this to avoid missleading errors being reported.
9243 * ecore.cs (ImplicitReferenceConversion): treat
9244 TypeManager.value_type as a target just like object_type. As
9249 Is valid, and needs to result in the int 1 being boxed before it
9250 is assigned to the value type v.
9252 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
9253 to validate the enumeration name.
9255 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
9256 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
9257 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
9259 * ecore.cs (TryImplicitIntConversion): When doing an
9260 implicit-enumeration-conversion, check if the type is 64-bits and
9261 perform a conversion before passing to EnumConstant.
9263 2002-09-23 Miguel de Icaza <miguel@ximian.com>
9265 * decl.cs (Error_AmbiguousTypeReference); New routine used to
9266 report ambiguous type references. Unlike the MS version, we
9267 report what the ambiguity is. Innovation at work ;-)
9269 (DeclSpace.FindType): Require a location argument to
9270 display when we display an ambiguous error.
9272 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
9274 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
9276 * expression.cs (EmitDynamicInitializers): Apply patch from
9277 hwang_rob@yahoo.ca that fixes the order in which we emit our
9280 2002-09-21 Martin Baulig <martin@gnome.org>
9282 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
9283 delegate takes no arguments.
9285 2002-09-20 Miguel de Icaza <miguel@ximian.com>
9287 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
9290 * expression.cs: Extract the underlying type.
9292 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
9294 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
9296 2002-09-19 Miguel de Icaza <miguel@ximian.com>
9298 * class.cs (TypeContainer.DefineType): We can not use the nice
9299 PackingSize with the size set to 1 DefineType method, because it
9300 will not allow us to define the interfaces that the struct
9303 This completes the fixing of bug 27287
9305 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
9306 means also structs. This fixes part of the problem.
9307 (Expresion.ImplicitReferenceConversionExists): ditto.
9309 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
9310 error if there were no errors reported during the type lookup
9311 process, to avoid duplicates or redundant errors. Without this
9312 you would get an ambiguous errors plus a type not found. We have
9313 beaten the user enough with the first error.
9315 (DeclSparce.FindType): Emit a warning if we have an ambiguous
9318 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
9319 during the resolution process, stop the lookup, this avoids
9320 repeated error reports (same error twice).
9322 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
9324 * typemanager.cs (LookupType): Redo the type lookup code to match
9325 the needs of System.Reflection.
9327 The issue is that System.Reflection requires references to nested
9328 types to begin with a "+" sign instead of a dot. So toplevel
9329 types look like: "NameSpace.TopLevelClass", and nested ones look
9330 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
9333 2002-09-19 Martin Baulig <martin@gnome.org>
9335 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
9336 says that a method always returns or always throws an exception,
9337 don't report the CS0161.
9339 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
9340 set `Returns = new_returns'.
9342 2002-09-19 Martin Baulig <martin@gnome.org>
9344 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
9345 to an enum constant, check for a CS0176.
9347 2002-09-18 Miguel de Icaza <miguel@ximian.com>
9349 * class.cs (TypeContainer.CheckPairedOperators): Now we check
9350 for operators that must be in pairs and report errors.
9352 * ecore.cs (SimpleName.DoResolveType): During the initial type
9353 resolution process, when we define types recursively, we must
9354 check first for types in our current scope before we perform
9355 lookups in the enclosing scopes.
9357 * expression.cs (MakeByteBlob): Handle Decimal blobs.
9359 (Invocation.VerifyArgumentsCompat): Call
9360 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
9361 I thought we were supposed to always call this, but there are a
9362 few places in the code where we dont do it.
9364 2002-09-17 Miguel de Icaza <miguel@ximian.com>
9366 * driver.cs: Add support in -linkres and -resource to specify the
9367 name of the identifier.
9369 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9371 * ecore.cs (StandardConversionExists): Sync with the conversion
9372 code: allow anything-* to void* conversions.
9374 (FindMostSpecificSource): Use an Expression argument
9375 instead of a Type, because we might be handed over a Literal which
9376 gets a few more implicit conversions that plain types do not. So
9377 this information was being lost.
9379 Also, we drop the temporary type-holder expression when not
9382 2002-09-17 Martin Baulig <martin@gnome.org>
9384 * class.cs (PropertyBase.CheckBase): Don't check the base class if
9385 this is an explicit interface implementation.
9387 2002-09-17 Martin Baulig <martin@gnome.org>
9389 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
9390 different `IndexerName' attributes.
9392 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
9393 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
9394 virtual CommonResolve().
9396 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9398 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
9399 and convert that to the UnderlyingType.
9401 * statement.cs (Foreach.Resolve): Indexers are just like variables
9402 or PropertyAccesses.
9404 * cs-tokenizer.cs (consume_string): Track line numbers and columns
9405 inside quoted strings, we were not doing this before.
9407 2002-09-16 Martin Baulig <martin@gnome.org>
9409 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
9410 resolve it. This is needed for the definite assignment check of the
9411 instance expression, fixes bug #29846.
9412 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
9414 2002-09-16 Nick Drochak <ndrochak@gol.com>
9416 * parameter.cs: Fix compile error. Cannot reference static member
9417 from an instance object. Is this an mcs bug?
9419 2002-09-14 Martin Baulig <martin@gnome.org>
9421 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
9422 multiple times. Fixes bug #30295, added test-166.cs.
9424 2002-09-14 Martin Baulig <martin@gnome.org>
9426 * statement.cs (Block.Emit): Don't emit unreachable code.
9427 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
9429 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
9431 2002-09-14 Martin Baulig <martin@gnome.org>
9433 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
9436 2002-09-14 Martin Baulig <martin@gnome.org>
9438 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
9439 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
9440 be false on the ms runtime.
9442 2002-09-13 Martin Baulig <martin@gnome.org>
9444 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
9445 the CS0038 error message.
9447 2002-09-12 Miguel de Icaza <miguel@ximian.com>
9449 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
9450 constant inside, return it.
9452 2002-09-12 Martin Baulig <martin@gnome.org>
9454 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
9455 implicit conversion can be done between enum types.
9457 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
9458 check whether an implicit conversion to the current enum's UnderlyingType
9459 exists and report an error if not.
9461 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
9462 without debugging support.
9464 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
9465 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
9467 2002-09-12 Martin Baulig <martin@gnome.org>
9469 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
9471 * ecore.cs (IMemberExpr.DeclaringType): New property.
9472 (SimpleName.SimpleNameResolve): Check whether we're accessing a
9473 nonstatic member of an outer type (CS0038).
9475 2002-09-11 Miguel de Icaza <miguel@ximian.com>
9477 * driver.cs: Activate the using-error detector at warning level
9478 4 (at least for MS-compatible APIs).
9480 * namespace.cs (VerifyUsing): Small buglett fix.
9482 * pending.cs (PendingImplementation): pass the container pointer.
9484 * interface.cs (GetMethods): Allow for recursive definition. Long
9485 term, I would like to move every type to support recursive
9486 definitions, not the current ordering mechanism that we have right
9489 The situation is this: Attributes are handled before interfaces,
9490 so we can apply attributes to interfaces. But some attributes
9491 implement interfaces, we will now handle the simple cases
9492 (recursive definitions will just get an error).
9494 * parameter.cs: Only invalidate types at the end if we fail to
9497 2002-09-09 Martin Baulig <martin@gnome.org>
9499 * ecore.cs (PropertyExpr.Emit): Also check for
9500 TypeManager.system_int_array_get_length so this'll also work when
9501 compiling corlib. Fixes #30003.
9503 2002-09-09 Martin Baulig <martin@gnome.org>
9505 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
9506 and throw an exception if we can't get the type's size. Fixed #30040,
9509 2002-09-09 Martin Baulig <martin@gnome.org>
9511 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
9513 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
9514 context. Fixes bug #30027.
9516 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
9517 virtual functions. Fixes bug #30043, added test-164.cs.
9519 2002-09-08 Ravi Pratap <ravi@ximian.com>
9521 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
9523 2002-09-08 Nick Drochak <ndrochak@gol.com>
9525 * driver.cs: Use an object to get the windows codepage since it's not a
9528 2002-09-08 Miguel de Icaza <miguel@ximian.com>
9530 * statement.cs (For.Emit): for infinite loops (test == null)
9531 return whether there is a break inside, not always "true".
9533 * namespace.cs (UsingEntry): New struct to hold the name of the
9534 using definition, the location where it is defined, and whether it
9535 has been used in a successful type lookup.
9537 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
9542 2002-09-06 Ravi Pratap <ravi@ximian.com>
9544 * attribute.cs : Fix incorrect code which relied on catching
9545 a NullReferenceException to detect a null being passed in
9546 where an object was expected.
9548 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9550 * statement.cs (Try): flag the catch variable as assigned
9552 * expression.cs (Cast): Simplified by using ResolveType instead of
9555 * statement.cs (Catch): Fix bug by using ResolveType.
9557 2002-09-06 Ravi Pratap <ravi@ximian.com>
9559 * expression.cs (BetterConversion): Special case for when we have
9560 a NullLiteral as the argument and we have to choose between string
9561 and object types - we choose string the way csc does.
9563 * attribute.cs (Attribute.Resolve): Catch the
9564 NullReferenceException and report error #182 since the Mono
9565 runtime no more has the bug and having this exception raised means
9566 we tried to select a constructor which takes an object and is
9569 2002-09-05 Ravi Pratap <ravi@ximian.com>
9571 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9572 message (1502, 1503) when we can't locate a method after overload
9573 resolution. This is much more informative and closes the bug
9576 * interface.cs (PopulateMethod): Return if there are no argument
9577 types. Fixes a NullReferenceException bug.
9579 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9580 expressions too. Previously we were checking only in one place for
9581 positional arguments leaving out named arguments.
9583 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9584 type to the enum type is not allowed. Remove code corresponding to
9587 (ConvertNumericExplicit): Allow explicit conversions from
9588 the underlying type to enum type. This precisely follows the spec
9589 and closes a bug filed by Gonzalo.
9591 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9594 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9596 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9598 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9599 it was important that we stored the right value after the
9600 reduction in `converted'.
9602 2002-09-04 Martin Baulig <martin@gnome.org>
9604 * location.cs (Location.SymbolDocument): Use full pathnames for the
9607 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9609 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9610 of the expression resolve mechanism, because that will catch the
9611 SimpleName error failures.
9613 (Conditional): If we can not resolve the
9614 expression, return, do not crash.
9616 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9619 (location): display token name instead of its number.
9621 2002-08-28 Martin Baulig <martin@gnome.org>
9623 * expression.cs (Binary.ResolveOperator): Don't silently return
9624 but return an error if an operator cannot be applied between two
9627 2002-08-28 Martin Baulig <martin@gnome.org>
9629 * class.cs (Constructor.Define): Set the permission attributes
9630 correctly instead of making all constructors public.
9632 2002-08-28 Martin Baulig <martin@gnome.org>
9634 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9635 for private members before reporting a CS0103; if we find anything,
9638 2002-08-28 Martin Baulig <martin@gnome.org>
9640 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9641 to check whether `closure_start_type == closure_invocation_type',
9642 we also need to check whether `m.DeclaringType == closure_invocation_type'
9643 before bypassing the permission checks. We might be accessing
9644 protected/private members from the base class.
9645 (TypeManager.RealMemberLookup): Only set private_ok if private
9646 members were requested via BindingFlags.NonPublic.
9648 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9650 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9651 MethodGroupExpr.IsExplicitImpl if appropriate.
9652 (Invocation.DoResolve): Don't report the CS0120 for explicit
9653 interface implementations.
9655 2002-08-27 Martin Baulig <martin@gnome.org>
9657 * expression.cs (Invocation.DoResolve): If this is a static
9658 method and we don't have an InstanceExpression, we must report
9661 2002-08-25 Martin Baulig <martin@gnome.org>
9663 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9664 `==' between a valuetype and an object.
9666 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9668 * ecore.cs (TypeExpr): Provide a ToString method.
9670 2002-08-24 Martin Baulig <martin@gnome.org>
9672 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9673 now called proggie.dbg and it's a binary file.
9675 2002-08-23 Martin Baulig <martin@gnome.org>
9677 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9679 2002-08-23 Martin Baulig <martin@gnome.org>
9681 * struct.cs (MyStructInfo.ctor): Make this work with empty
9682 structs; it's not allowed to use foreach() on null.
9684 2002-08-23 Martin Baulig <martin@gnome.org>
9686 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9687 writer the full pathname of the generated assembly.
9689 2002-08-23 Martin Baulig <martin@gnome.org>
9691 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9692 A `finally' block never returns or breaks; improved handling of
9695 2002-08-23 Martin Baulig <martin@gnome.org>
9697 * statement.cs (Throw.Resolve): Allow `throw null'.
9699 2002-08-23 Martin Baulig <martin@gnome.org>
9701 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9702 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9703 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9704 MemberLookup would return a wrong event if this is an explicit
9705 interface implementation and the class has an event with the same
9708 2002-08-23 Martin Baulig <martin@gnome.org>
9710 * statement.cs (Block.AddChildVariableNames): New public method.
9711 (Block.AddChildVariableName): Likewise.
9712 (Block.IsVariableNameUsedInChildBlock): Likewise.
9713 (Block.AddVariable): Check whether a variable name has already
9714 been used in a child block.
9716 * cs-parser.jay (declare_local_variables): Mark all variable names
9717 from the current block as being used in a child block in the
9720 2002-08-23 Martin Baulig <martin@gnome.org>
9722 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9723 find the symbol writer.
9725 * driver.cs: csc also allows the arguments to /define being
9726 separated by commas, not only by semicolons.
9728 2002-08-23 Martin Baulig <martin@gnome.org>
9730 * interface.cs (Interface.GetMembers): Added static check for events.
9732 2002-08-15 Martin Baulig <martin@gnome.org>
9734 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9735 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9737 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9738 why the MethodData.EmitDestructor() change was necessary.
9740 2002-08-20 Martin Baulig <martin@gnome.org>
9742 * class.cs (TypeContainer.FindMembers): Added static check for events.
9744 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9746 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9747 use Type.GetEvents(), not Type.FindMembers().
9749 2002-08-20 Martin Baulig <martin@gnome.org>
9751 * decl.cs (MemberCache): Added a special method cache which will
9752 be used for method-only searched. This ensures that a method
9753 search will return a MethodInfo with the correct ReflectedType for
9756 2002-08-20 Martin Baulig <martin@gnome.org>
9758 * decl.cs (DeclSpace.FindMembers): Made this public.
9760 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9762 * delegate.cs: fixed build on windows.
9763 [FIXME: Filed as bug #29150: MCS must report these errors.]
9765 2002-08-19 Ravi Pratap <ravi@ximian.com>
9767 * ecore.cs (StandardConversionExists): Return a false
9768 if we are trying to convert the void type to anything else
9769 since that is not allowed.
9771 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9772 we flag error 70 in the event an event is trying to be accessed
9773 directly from outside the declaring type.
9775 2002-08-20 Martin Baulig <martin@gnome.org>
9777 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9778 MemberCache from typemanager.cs to decl.cs.
9780 2002-08-19 Martin Baulig <martin@gnome.org>
9782 * class.cs (TypeContainer): Implement IMemberContainer.
9783 (TypeContainer.DefineMembers): Create the MemberCache.
9784 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9785 return public members if BindingFlags.Public was given, check
9786 whether members are static.
9788 2002-08-16 Martin Baulig <martin@gnome.org>
9790 * decl.cs (DeclSpace.Define): Splitted this in Define and
9791 DefineMembers. DefineMembers is called first and initializes the
9794 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9795 DefineMembers() on all our DeclSpaces.
9797 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9798 but call DefineMembers() on all nested interfaces. We call their
9799 Define() in our new Define() function.
9801 * interface.cs (Interface): Implement IMemberContainer.
9802 (Interface.Define): Moved all code except the attribute stuf to
9804 (Interface.DefineMembers): Initialize the member cache.
9806 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9807 need this anymore since we can use MemberCache.FindMembers directly.
9809 2002-08-19 Martin Baulig <martin@gnome.org>
9811 * typemanager.cs (MemberCache): When creating the cache for an
9812 interface type, add all inherited members.
9813 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9814 to `out bool used_cache' and documented it.
9815 (TypeManager.MemberLookup): If we already used the cache in the first
9816 iteration, we don't need to do the interfaces check.
9818 2002-08-19 Martin Baulig <martin@gnome.org>
9820 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9821 here from IMemberFinder and don't implement this interface anymore.
9822 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9824 * typemanager.cs (IMemberFinder): This interface is now only used by
9825 classes which actually support the member cache.
9826 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9827 since we only put DeclSpaces into this Hashtable.
9828 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9829 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9831 2002-08-16 Martin Baulig <martin@gnome.org>
9833 * typemanager.cs (ICachingMemberFinder): Removed.
9834 (IMemberFinder.MemberCache): New property.
9835 (TypeManager.FindMembers): Merged this with RealFindMembers().
9836 This function will never be called from TypeManager.MemberLookup()
9837 so we can't use the cache here, just the IMemberFinder.
9838 (TypeManager.MemberLookup_FindMembers): Check whether the
9839 IMemberFinder has a MemberCache and call the cache's FindMembers
9841 (MemberCache): Rewrote larger parts of this yet another time and
9842 cleaned it up a bit.
9844 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9846 * driver.cs (LoadArgs): Support quoting.
9848 (Usage): Show the CSC-like command line arguments.
9850 Improved a few error messages.
9852 2002-08-15 Martin Baulig <martin@gnome.org>
9854 * typemanager.cs (IMemberContainer.Type): New property.
9855 (IMemberContainer.IsInterface): New property.
9857 The following changes are conditional to BROKEN_RUNTIME, which is
9858 defined at the top of the file.
9860 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9861 class'es members, but add all members from TypeHandle.ObjectType
9862 if we're an interface.
9863 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9864 is the current type.
9865 (MemberCache.CacheEntry.Container): Removed this field.
9866 (TypeHandle.GetMembers): Include inherited members.
9868 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9870 * typemanager.cs: fixed compilation and added a comment on a field that
9873 2002-08-15 Martin Baulig <martin@gnome.org>
9875 * class.cs (ConstructorInitializer.Resolve): In the
9876 Expression.MemberLookup call, use the queried_type as
9879 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9880 declared' attribute, it's always true.
9881 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9882 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9883 temporary wrapper for FindMembers which tells MemberLookup whether
9884 members from the base classes are included in the return value.
9885 This will go away soon.
9886 (TypeManager.MemberLookup): Use this temporary hack here; once the
9887 new MemberCache is completed, we don't need to do the DeclaredOnly
9888 looping here anymore since the MemberCache will take care of this.
9889 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9890 (MemberCache): When creating the MemberCache for a class, get
9891 members from the current class and all its base classes.
9892 (MemberCache.CacheEntry.Container): New field. This is a
9893 temporary hack until the Mono runtime is fixed to distinguish
9894 between ReflectedType and DeclaringType. It allows us to use MCS
9895 with both the MS runtime and the unfixed Mono runtime without
9896 problems and without accecting performance.
9897 (MemberCache.SearchMembers): The DeclaredOnly looping from
9898 TypeManager.MemberLookup is now done here.
9900 2002-08-14 Martin Baulig <martin@gnome.org>
9902 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9903 Type.GetFields on dynamic types but get the fields from the
9904 corresponding TypeContainer.
9905 (MyStructInfo.GetStructInfo): Added check for enum types.
9907 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9908 (MemberList.SyncRoot): Implemented.
9909 (TypeManager.FilterWithClosure): No need to check permissions if
9910 closure_start_type == closure_invocation_type, don't crash if
9911 closure_invocation_type is null.
9913 2002-08-13 Martin Baulig <martin@gnome.org>
9915 Rewrote TypeContainer.FindMembers to use a member cache. This
9916 gives us a speed increase of about 35% for the self-hosting MCS
9917 build and of about 15-20% for the class libs (both on GNU/Linux).
9919 * report.cs (Timer): New class to get enhanced profiling. This
9920 whole class is "TIMER" conditional since it remarkably slows down
9923 * class.cs (MemberList): New class. This is an IList wrapper
9924 which we're now using instead of passing MemberInfo[]'s around to
9925 avoid copying this array unnecessarily.
9926 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9927 (ICachingMemberFinder, IMemberContainer): New interface.
9928 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9929 has already been checked, otherwise use it for the name comparision.
9930 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9931 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9932 if possible. Returns a MemberList, not a MemberInfo [].
9933 (TypeHandle): New class, implements IMemberContainer. We create
9934 one instance of this class per type, it contains a MemberCache
9935 which is used to do the member lookups.
9936 (MemberCache): New class. Each instance of this class contains
9937 all members of a type and a name-based hash table.
9938 (MemberCache.FindMembers): This is our new member lookup
9939 function. First, it looks up all members of the requested name in
9940 the hash table. Then, it walks this list and sorts out all
9941 applicable members and returns them.
9943 2002-08-13 Martin Baulig <martin@gnome.org>
9945 In addition to a nice code cleanup, this gives us a performance
9946 increase of about 1.4% on GNU/Linux - not much, but it's already
9947 half a second for the self-hosting MCS compilation.
9949 * typemanager.cs (IMemberFinder): New interface. It is used by
9950 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9951 Enum, Delegate or Interface.
9952 (TypeManager.finder_to_member_finder): New PtrHashtable.
9953 (TypeManager.finder_to_container): Removed.
9954 (TypeManager.finder_to_delegate): Removed.
9955 (TypeManager.finder_to_interface): Removed.
9956 (TypeManager.finder_to_enum): Removed.
9958 * interface.cs (Interface): Implement IMemberFinder.
9960 * delegate.cs (Delegate): Implement IMemberFinder.
9962 * enum.cs (Enum): Implement IMemberFinder.
9964 * class.cs (TypeContainer): Implement IMemberFinder.
9966 2002-08-12 Martin Baulig <martin@gnome.org>
9968 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9970 2002-08-12 Martin Baulig <martin@gnome.org>
9972 * ecore.cs (ITypeExpression): New interface for expressions which
9974 (TypeExpression): Renamed to TypeLookupExpression.
9975 (Expression.DoResolve): If we're doing a types-only lookup, the
9976 expression must implement the ITypeExpression interface and we
9977 call DoResolveType() on it.
9978 (SimpleName): Implement the new ITypeExpression interface.
9979 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9980 hack, the situation that we're only looking up types can't happen
9981 anymore when this method is called. Moved the type lookup code to
9982 DoResolveType() and call it.
9983 (SimpleName.DoResolveType): This ITypeExpression interface method
9984 is now doing the types-only lookup.
9985 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9986 (ResolveFlags): Added MaskExprClass.
9988 * expression.cs (MemberAccess): Implement the ITypeExpression
9990 (MemberAccess.DoResolve): Added support for a types-only lookup
9991 when we're called via ITypeExpression.DoResolveType().
9992 (ComposedCast): Implement the ITypeExpression interface.
9994 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9995 Expression.Resolve() with ResolveFlags.Type instead.
9997 2002-08-12 Martin Baulig <martin@gnome.org>
9999 * interface.cs (Interface.Define): Apply attributes.
10001 * attribute.cs (Attribute.ApplyAttributes): Added support for
10002 interface attributes.
10004 2002-08-11 Martin Baulig <martin@gnome.org>
10006 * statement.cs (Block.Emit): Only check the "this" variable if we
10007 do not always throw an exception.
10009 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
10010 whether the property has a set accessor.
10012 2002-08-11 Martin Baulig <martin@gnome.org>
10014 Added control flow analysis support for structs.
10016 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
10017 with control flow analysis turned off.
10018 (IVariable): New interface.
10019 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
10020 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
10021 (FieldExpr.DoResolve): Resolve the instance expression with flow
10022 analysis turned off and do the definite assignment check after the
10023 resolving when we know what the expression will resolve to.
10025 * expression.cs (LocalVariableReference, ParameterReference):
10026 Implement the new IVariable interface, only call the flow analysis
10027 code if ec.DoFlowAnalysis is true.
10028 (This): Added constructor which takes a Block argument. Implement
10029 the new IVariable interface.
10030 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
10031 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
10032 This does the definite assignment checks for struct members.
10034 * class.cs (Constructor.Emit): If this is a non-static `struct'
10035 constructor which doesn't have any initializer, call
10036 Block.AddThisVariable() to tell the flow analysis code that all
10037 struct elements must be initialized before control returns from
10040 * statement.cs (MyStructInfo): New public class.
10041 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
10042 argument to this indexer. If non-zero, check an individual struct
10043 member, not the whole struct.
10044 (FlowBranching.CheckOutParameters): Check struct members.
10045 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
10046 overloaded versions of these methods which take an additional
10047 `int field_idx' argument to check struct members.
10048 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
10049 overloaded versions of these methods which take an additional
10050 `string field_name' argument to check struct member.s
10051 (VariableInfo): Implement the IVariable interface.
10052 (VariableInfo.StructInfo): New public property. Returns the
10053 MyStructInfo instance of the variable if it's a struct or null.
10054 (Block.AddThisVariable): New public method. This is called from
10055 Constructor.Emit() for non-static `struct' constructor which do
10056 not have any initializer. It creates a special variable for the
10057 "this" instance variable which will be checked by the flow
10058 analysis code to ensure that all of the struct's fields are
10059 initialized before control returns from the constructor.
10060 (UsageVector): Added support for struct members. If a
10061 variable/parameter is a struct with N members, we reserve a slot
10062 in the usage vector for each member. A struct is considered fully
10063 initialized if either the struct itself (slot 0) or all its
10064 members are initialized.
10066 2002-08-08 Martin Baulig <martin@gnome.org>
10068 * driver.cs (Driver.MainDriver): Only report an error CS5001
10069 if there were no compilation errors.
10071 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
10072 `UnsafeContext' property to determine whether the parent is in
10073 unsafe context rather than checking the parent's ModFlags:
10074 classes nested in an unsafe class are unsafe as well.
10076 2002-08-08 Martin Baulig <martin@gnome.org>
10078 * statement.cs (UsageVector.MergeChildren): Distinguish between
10079 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
10080 we return. Added test17() and test18() to test-154.cs.
10082 2002-08-08 Martin Baulig <martin@gnome.org>
10084 * typemanager.cs (TypeManager.FilterWithClosure): If we have
10085 Family access, make sure the invoking type isn't a subclass of the
10086 queried type (that'd be a CS1540).
10088 * ecore.cs (Expression.MemberLookup): Added overloaded version of
10089 this method which takes an additional `Type invocation_type'.
10091 * expression.cs (BaseAccess.DoResolve): Use the base type as
10092 invocation and query type.
10093 (MemberAccess.DoResolve): If the lookup failed and we're about to
10094 report a CS0122, try a lookup with the ec.ContainerType - if this
10095 succeeds, we must report a CS1540.
10097 2002-08-08 Martin Baulig <martin@gnome.org>
10099 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
10100 (MethodGroupExpr): Implement the IMemberExpr interface.
10102 * expression (MemberAccess.ResolveMemberAccess): No need to have
10103 any special code for MethodGroupExprs anymore, they're now
10106 2002-08-08 Martin Baulig <martin@gnome.org>
10108 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
10109 Family, FamANDAssem and FamORAssem permissions.
10110 (TypeManager.IsSubclassOrNestedChildOf): New public method.
10112 2002-08-08 Martin Baulig <martin@gnome.org>
10114 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
10115 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
10118 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
10120 * driver.cs: implemented /resource option to embed managed resources.
10122 2002-08-07 Martin Baulig <martin@gnome.org>
10124 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
10125 (FieldBase.HasFieldInitializer): New public property.
10126 (FieldBase.GetInitializerExpression): New public method. Resolves and
10127 returns the field initializer and makes sure it is only resolved once.
10128 (TypeContainer.EmitFieldInitializers): Call
10129 FieldBase.GetInitializerExpression to get the initializer, this ensures
10130 that it isn't resolved multiple times.
10132 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
10133 the resolving process (SimpleName/MemberLookup) that we're currently
10134 emitting a field initializer (which must not access any instance members,
10135 this is an error CS0236).
10137 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
10138 argument, if the `IsFieldInitializer' flag is set, we must report and
10139 error CS0236 and not an error CS0120.
10141 2002-08-07 Martin Baulig <martin@gnome.org>
10143 * ecore.cs (IMemberExpr): New public interface.
10144 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
10145 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
10146 if the expression is an IMemberExpr.
10148 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
10149 to be null, implicitly default to `this' if we're non-static in
10150 this case. Simplified the code a lot by using the new IMemberExpr
10151 interface. Also fixed bug #28176 here.
10153 2002-08-06 Martin Baulig <martin@gnome.org>
10155 * cs-parser.jay (SimpleLookup): Removed. We need to create
10156 ParameterReferences during semantic analysis so that we can do a
10157 type-only search when resolving Cast, TypeOf and SizeOf.
10158 (block): Pass the `current_local_parameters' to the Block's
10161 * class.cs (ConstructorInitializer): Added `Parameters parameters'
10162 argument to the constructor.
10163 (ConstructorInitializer.Resolve): Create a temporary implicit
10164 block with the parameters.
10166 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
10167 references here if we aren't doing a type-only search.
10169 * statement.cs (Block): Added constructor which takes a
10170 `Parameters parameters' argument.
10171 (Block.Parameters): New public property.
10173 * support.cs (InternalParameters.Parameters): Renamed `parameters'
10174 to `Parameters' and made it public readonly.
10176 2002-08-06 Martin Baulig <martin@gnome.org>
10178 * ecore.cs (Expression.Warning): Made this public as well.
10180 * report.cs (Report.Debug): Print the contents of collections.
10182 2002-08-06 Martin Baulig <martin@gnome.org>
10184 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
10185 used to tell Resolve() which kinds of expressions it may return.
10186 (Expression.Resolve): Added overloaded version of this method which
10187 takes a `ResolveFlags flags' argument. This can be used to tell
10188 Resolve() which kinds of expressions it may return. Reports a
10190 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
10191 ResolveFlags.SimpleName.
10192 (Expression.Error118): Added overloaded version of this method which
10193 takes a `ResolveFlags flags' argument. It uses the flags to determine
10194 which kinds of expressions are allowed.
10196 * expression.cs (Argument.ResolveMethodGroup): New public method.
10197 Resolves an argument, but allows a MethodGroup to be returned.
10198 This is used when invoking a delegate.
10200 * TODO: Updated a bit.
10202 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10204 Fixed compilation with csc.
10206 * ecore.cs: Expression.Error made public. Is this correct? Should
10207 Warning be made public too?
10209 * expression.cs: use ea.Location instead of ea.loc.
10210 [FIXME: Filed as bug #28607: MCS must report these errors.]
10212 2002-08-06 Martin Baulig <martin@gnome.org>
10214 * ecore.cs (Expression.loc): Moved the location here instead of
10215 duplicating it in all derived classes.
10216 (Expression.Location): New public property.
10217 (Expression.Error, Expression.Warning): Made them non-static and
10218 removed the location argument.
10219 (Expression.Warning): Added overloaded version which takes an
10220 `int level' argument.
10221 (Expression.Error118): Make this non-static and removed the
10222 expression and location arguments.
10223 (TypeExpr): Added location argument to the constructor.
10225 * expression.cs (StaticCallExpr): Added location argument to
10227 (Indirection, PointerArithmetic): Likewise.
10228 (CheckedExpr, UnCheckedExpr): Likewise.
10229 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
10230 (StringPtr): Likewise.
10233 2002-08-05 Martin Baulig <martin@gnome.org>
10235 * expression.cs (BaseAccess.DoResolve): Actually report errors.
10237 * assign.cs (Assign.DoResolve): Check whether the source
10238 expression is a value or variable.
10240 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
10241 while resolving the corresponding blocks.
10243 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
10244 an error, don't silently return null.
10246 * statement.cs (Block.AddVariable): Do the error reporting here
10247 and distinguish between CS0128 and CS0136.
10248 (Block.DoResolve): Report all unused labels (warning CS0164).
10249 (LabeledStatement): Pass the location to the constructor.
10250 (LabeledStatement.HasBeenReferenced): New property.
10251 (LabeledStatement.Resolve): Set it to true here.
10253 * statement.cs (Return.Emit): Return success even after reporting
10254 a type mismatch error (CS0126 or CS0127), this is what csc does and
10255 it avoids confusing the users with any consecutive errors.
10257 2002-08-05 Martin Baulig <martin@gnome.org>
10259 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
10261 * const.cs (Const.LookupConstantValue): Catch circular definitions.
10263 * expression.cs (MemberAccess.DoResolve): Silently return if an
10264 error has already been reported.
10266 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
10267 error has already been reported.
10269 2002-08-05 Martin Baulig <martin@gnome.org>
10271 * statement.cs (UsageVector): Only initialize the `parameters'
10272 vector if we actually have any "out" parameters.
10274 2002-08-05 Martin Baulig <martin@gnome.org>
10276 * expression.cs (Binary.ResolveOperator): When combining delegates,
10277 they must have the same type.
10279 2002-08-05 Martin Baulig <martin@gnome.org>
10281 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
10282 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
10283 work with the ms runtime and we also don't need it: if we're a
10284 PropertyBuilder and not in the `indexer_arguments' hash, then we
10285 are a property and not an indexer.
10287 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
10288 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
10289 since the latter one doesn't work with the ms runtime.
10291 2002-08-03 Martin Baulig <martin@gnome.org>
10293 Fixed bugs #27998 and #22735.
10295 * class.cs (Method.IsOperator): New public field.
10296 (Method.CheckBase): Report CS0111 if there's already a method
10297 with the same parameters in the current class. Report CS0508 when
10298 attempting to change the return type of an inherited method.
10299 (MethodData.Emit): Report CS0179 if a method doesn't have a body
10300 and it's not marked abstract or extern.
10301 (PropertyBase): New abstract base class for Property and Indexer.
10302 (PropertyBase.CheckBase): Moved here from Property and made it work
10304 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
10305 the same so we can reuse it there.
10306 (Property, Indexer): Derive from PropertyBase.
10307 (MethodSignature.inheritable_property_signature_filter): New delegate
10308 to find properties and indexers.
10310 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
10311 argument and improved error reporting.
10313 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
10314 EmptyReadOnlyParameters and made it a property.
10316 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
10317 version of this method which takes a `PropertyInfo indexer'.
10318 (TypeManager.RegisterIndexer): New method.
10320 * class.cs: Added myself as author of this file :-)
10322 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10324 * class.cs: fixed compilation on windoze.
10326 2002-08-03 Martin Baulig <martin@gnome.org>
10328 * interface.cs (Interface.GetInterfaceBases): Check whether all
10329 base interfaces are at least as accessible than the current one.
10331 * class.cs (TypeContainer.GetClassBases): Check whether base types
10332 are at least as accessible than the current type.
10333 (TypeContainer.AsAccessible): Implemented and made non-static.
10334 (MemberBase.CheckParameters): Report errors if the accessibility
10337 * delegate.cs (Delegate.Delegate): The default visibility is
10338 internal for top-level types and private for nested types.
10339 (Delegate.Define): Report errors if the accessibility checks fail.
10341 * enum.cs (Enum.Enum): The default visibility is internal for
10342 top-level types and private for nested types.
10343 (Enum.DefineType): Compute the correct visibility.
10345 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
10346 function which takes a `bool is_toplevel' instead of a TypeContainer.
10348 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
10351 2002-08-02 Martin Baulig <martin@gnome.org>
10353 * expression.cs (LocalVariableReferenc): Added constructor which
10354 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
10355 (LocalVariableReference.IsReadOnly): New property.
10356 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
10357 variable is readonly, use our own readonly flag to do this; you can
10358 use the new constructor to get a writable reference to a read-only
10361 * cs-parser.jay (foreach_statement, using_statement): Get a writable
10362 reference to the local variable.
10364 2002-08-01 Miguel de Icaza <miguel@ximian.com>
10366 * rootcontext.cs (ResolveCore): Also include System.Exception
10368 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
10369 we reach an EmptyStatement.
10371 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
10374 * expression.cs (Binary.ResolveOperator): Check error result in
10377 use brtrue/brfalse directly and avoid compares to null.
10379 2002-08-02 Martin Baulig <martin@gnome.org>
10381 * class.cs (TypeContainer.Define): Define all nested interfaces here.
10382 Fixes bug #28407, added test-155.cs.
10384 2002-08-01 Martin Baulig <martin@gnome.org>
10386 * class.cs (Event.EmitDefaultMethod): Make this work with static
10387 events. Fixes #28311, added verify-3.cs.
10389 2002-08-01 Martin Baulig <martin@gnome.org>
10391 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
10392 `is_disposable' fields.
10393 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
10394 `hm.is_disposable' if we're using the collection pattern.
10395 (Foreach.EmitCollectionForeach): Use the correct type for the
10396 enumerator's local variable, only emit the try/finally block if
10397 necessary (fixes #27713).
10399 2002-08-01 Martin Baulig <martin@gnome.org>
10401 * ecore.cs (Expression.report118): Renamed to Error118 and made
10404 * statement.cs (Throw.Resolve): Check whether the expression is of
10405 the correct type (CS0118) and whether the type derives from
10406 System.Exception (CS0155).
10407 (Catch.Resolve): New method. Do the type lookup here and check
10408 whether it derives from System.Exception (CS0155).
10409 (Catch.CatchType, Catch.IsGeneral): New public properties.
10411 * typemanager.cs (TypeManager.exception_type): Added.
10413 2002-07-31 Miguel de Icaza <miguel@ximian.com>
10415 * driver.cs: Updated About function.
10417 2002-07-31 Martin Baulig <martin@gnome.org>
10419 Implemented Control Flow Analysis.
10421 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
10422 (EmitContext.CurrentBranching): Added.
10423 (EmitContext.StartFlowBranching): Added.
10424 (EmitContext.EndFlowBranching): Added.
10425 (EmitContext.KillFlowBranching): Added.
10426 (EmitContext.IsVariableAssigned): Added.
10427 (EmitContext.SetVariableAssigned): Added.
10428 (EmitContext.IsParameterAssigned): Added.
10429 (EmitContext.SetParameterAssigned): Added.
10430 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
10431 Added control flow analysis stuff here.
10433 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
10434 resolve the expression as lvalue.
10435 (LocalVariableReference.DoResolve): Check whether the variable has
10436 already been assigned.
10437 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
10438 the parameter as assigned here.
10439 (ParameterReference.DoResolve): Check whether the parameter has already
10441 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
10442 expression as lvalue.
10444 * statement.cs (FlowBranching): New class for the flow analysis code.
10445 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
10446 (LabeledStatement.IsDefined): New public property.
10447 (LabeledStatement.AddUsageVector): New public method to tell flow
10448 analyis that the label may be reached via a forward jump.
10449 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
10451 (VariableInfo.Number): New public field. This is used by flow analysis
10452 to number all locals of a block.
10453 (Block.CountVariables): New public property. This is the number of
10454 local variables in this block (including the locals from all parent
10456 (Block.EmitMeta): Number all the variables.
10458 * statement.cs: Added flow analysis support to all classes.
10460 2002-07-31 Martin Baulig <martin@gnome.org>
10462 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
10463 To get debugging messages, compile mcs with /define:MCS_DEBUG and
10464 then use this argument.
10466 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
10468 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
10469 use this to specify /define options.
10471 2002-07-29 Martin Baulig <martin@gnome.org>
10473 * statement.cs (Fixed): Moved all code that does variable lookups
10474 and resolvings from Emit to Resolve.
10476 * statement.cs (For): Moved all code that does variable lookups
10477 and resolvings from Emit to Resolve.
10479 * statement.cs (Using): Moved all code that does variable lookups
10480 and resolvings from Emit to Resolve.
10482 2002-07-29 Martin Baulig <martin@gnome.org>
10484 * attribute.cs (Attribute.Resolve): Explicitly catch a
10485 System.NullReferenceException when creating the
10486 CustromAttributeBuilder and report a different warning message.
10488 2002-07-29 Martin Baulig <martin@gnome.org>
10490 * support.cs (ParameterData.ParameterName): Added method to
10491 get the name of a parameter.
10493 * typemanager.cs (TypeManager.IsValueType): New public method.
10495 2002-07-29 Martin Baulig <martin@gnome.org>
10497 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
10498 is a flag which specifies that it's either ref or out.
10499 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
10500 the out parameter to `out Parameter.Modifier mod', also set the
10501 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
10503 * support.cs (InternalParameters.ParameterModifier): Distinguish
10504 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10505 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10507 * expression.cs (Argument.GetParameterModifier): Distinguish
10508 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10509 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10511 2002-07-29 Martin Baulig <martin@gnome.org>
10513 * expression.cs (ParameterReference.ParameterReference): Added
10514 `Location loc' argument to the constructor.
10516 * cs-parser.jay: Pass location to ParameterReference.
10518 2002-07-28 Miguel de Icaza <miguel@ximian.com>
10520 * statement.cs (Try): Initialize the location.
10522 * cs-parser.jay: pass location to Try.
10524 * expression.cs (Unary.Reduce): Change the prototype to return
10525 whether a constant fold could be performed or not. The result is
10526 returned in an out parameters. In the case of Indirection and
10527 AddressOf, we want to perform the full tests.
10529 2002-07-26 Miguel de Icaza <miguel@ximian.com>
10531 * statement.cs (Statement.Emit): Flag dead code.
10533 2002-07-27 Andrew Birkett <andy@nobugs.org>
10535 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
10537 2002-07-27 Martin Baulig <martin@gnome.org>
10539 * class.cs (MethodData.Define): Put back call to
10540 TypeManager.AddMethod(), accidentally commented this out.
10542 * report.cs (Debug): New public method to print debugging information,
10543 this is `[Conditional ("DEBUG")]'.
10545 2002-07-26 Martin Baulig <martin@gnome.org>
10547 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10548 (switch_statement): Push the current_block to the switch_stack and
10549 pop it again when we're done with the switch.
10550 (switch_section): The new block is a child of the current_block.
10551 Fixes bug #24007, added test-152.cs.
10553 2002-07-27 Martin Baulig <martin@gnome.org>
10555 * expression.cs (Invocation.EmitArguments): When calling a varargs
10556 function with only its fixed arguments, we need to pass an empty
10559 2002-07-27 Martin Baulig <martin@gnome.org>
10561 Mono 0.13 has been released.
10563 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10565 * driver.cs: Rename --resource to --linkres, because that is what
10566 we do currently, we dont support --resource yet.
10568 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10570 2002-07-25 Martin Baulig <martin@gnome.org>
10572 * class.cs (MethodData): New public class. This is a `method builder'
10573 class for a method or one accessor of a Property/Indexer/Event.
10574 (MethodData.GetMethodFlags): Moved here from MemberBase.
10575 (MethodData.ApplyAttributes): Likewise.
10576 (MethodData.ApplyObsoleteAttribute): Likewise.
10577 (MethodData.ApplyConditionalAttribute): Likewise.
10578 (MethodData.ApplyDllImportAttribute): Likewise.
10579 (MethodData.CheckAbstractAndExternal): Likewise.
10580 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10581 (MethodData.Emit): Formerly known as Method.Emit().
10582 (MemberBase): Moved everything which was specific to a single
10583 accessor/method to MethodData.
10584 (Method): Create a new MethodData and call Define() and Emit() on it.
10585 (Property, Indexer, Event): Create a new MethodData objects for each
10586 accessor and call Define() and Emit() on them.
10588 2002-07-25 Martin Baulig <martin@gnome.org>
10590 Made MethodCore derive from MemberBase to reuse the code from there.
10591 MemberBase now also checks for attributes.
10593 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10594 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10596 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10597 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10598 (MemberBase.ApplyAttributes): New virtual method; applies the
10599 attributes to a method or accessor.
10600 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10601 (MemberBase.ApplyConditionalAttribute): Likewise.
10602 (MemberBase.ApplyDllImportAttribute): Likewise.
10603 (MemberBase.CheckAbstractAndExternal): Likewise.
10604 (MethodCore.ParameterTypes): This is now a property instead of a
10605 method, it's initialized from DoDefineParameters().
10606 (MethodCore.ParameterInfo): Removed the set accessor.
10607 (MethodCore.DoDefineParameters): New protected virtual method to
10608 initialize ParameterTypes and ParameterInfo.
10609 (Method.GetReturnType): We can now simply return the MemberType.
10610 (Method.GetMethodFlags): Override the MemberBase version and add
10611 the conditional flags.
10612 (Method.CheckBase): Moved some code from Define() here, call
10613 DoDefineParameters() here.
10614 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10615 here to avoid some larger code duplication.
10616 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10617 ensure that abstract and external accessors don't declare a body.
10619 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10620 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10621 lookup in the attribute's parent classes, so we need to abort as soon
10622 as we found the first match.
10623 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10624 the attribute has no arguments.
10626 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10629 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10631 * cs-parser.jay: reverted previous patch.
10633 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10635 * cs-parser.jay: fixed bug #22119.
10637 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10639 * attribute.cs: fixed compilation. The error was:
10640 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10641 be assigned to before control leaves the current method."
10642 [FIXME: Filed as bug #28186: MCS must report this error.]
10644 2002-07-25 Martin Baulig <martin@gnome.org>
10646 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10647 method to pull the condition name ouf of a Conditional attribute.
10648 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10649 the obsolete message and error flag out of an Obsolete attribute.
10651 * class.cs (Method.GetMethodFlags): New public method to get the
10652 TypeManager.MethodFlags for this method.
10653 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10655 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10656 if we're overriding a virtual function, set the new private variable
10657 `parent_method'; call the new TypeManager.AddMethod().
10659 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10660 the MethodBuilder and the Method in a PtrHashtable.
10661 (TypeManager.builder_to_method): Added for this purpose.
10662 (TypeManager.MethodFlags): Added IsObsoleteError.
10663 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10664 Obsolete and Conditional arguments in MethodBuilders. If we discover
10665 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10666 the message from the attribute.
10668 2002-07-24 Martin Baulig <martin@gnome.org>
10670 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10671 preprocessor directives, ensure that the argument to #define/#undef is
10672 exactly one identifier and that it's actually an identifier.
10674 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10677 2002-07-24 Martin Baulig <martin@gnome.org>
10679 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10680 initialize it to TypeManager.object_type in the constructor.
10681 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10682 of the `hm.get_current' method if we're using the collection pattern.
10683 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10684 for the explicit conversion to make it work when we're using the collection
10685 pattern and the `Current' property has a different return type than `object'.
10688 2002-07-24 Martin Baulig <martin@gnome.org>
10690 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10691 does not match, but don't report any errors. This method is called in
10692 order for all methods in a MethodGroupExpr until a matching method is
10693 found, so we don't want to bail out if the first method doesn't match.
10694 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10695 matches, report the 123. Fixes #28070.
10697 2002-07-24 Martin Baulig <martin@gnome.org>
10699 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10700 TypeManager.TypeToCoreType() to the top of the method so the
10701 following equality checks will work. Fixes #28107.
10703 2002-07-24 Martin Baulig <martin@gnome.org>
10705 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10706 operand is of type uint, and the other operand is of type sbyte,
10707 short or int, the operands are converted to type long." -
10708 Actually do what this comment already told us. Fixes bug #28106,
10711 2002-07-24 Martin Baulig <martin@gnome.org>
10713 * class.cs (MethodBase): New abstract class. This is now a base
10714 class for Property, Indexer and Event to avoid some code duplication
10715 in their Define() and DefineMethods() methods.
10716 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10717 generic methods for Define() and DefineMethods().
10718 (FieldBase): Derive from MemberBase, not MemberCore.
10719 (Property): Derive from MemberBase, not MemberCore.
10720 (Property.DefineMethod): Moved all the code from this method to the
10721 new MethodBase.DefineAccessor(), just call it with appropriate
10723 (Property.Define): Call the new Property.DoDefine(), this does some
10724 sanity checks and we don't need to duplicate the code everywhere.
10725 (Event): Derive from MemberBase, not MemberCore.
10726 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10727 accessors, this will also make them work with interface events.
10728 (Indexer): Derive from MemberBase, not MemberCore.
10729 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10730 (Indexer.Define): Use the new MethodBase functions.
10732 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10733 argument to the constructor.
10734 (Interface.FindMembers): Added support for interface events.
10735 (Interface.PopluateEvent): Implemented.
10737 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10739 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10741 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10742 but this is required to check for a method name being the same as
10743 the containing class.
10747 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10749 * interface.cs: initialize variable.
10751 2002-07-23 Martin Baulig <martin@gnome.org>
10753 Implemented the IndexerName attribute in interfaces.
10755 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10756 name if this is an explicit interface implementation.
10757 (Indexer.InterfaceIndexerName): New public variable. If we're
10758 implementing an interface indexer, this is the IndexerName in that
10759 interface. Otherwise, it's the IndexerName.
10760 (Indexer.DefineMethod): If we're implementing interface indexer,
10761 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10762 and Pending.ImplementIndexer methods.
10763 (Indexer.Define): Also define the PropertyBuilder if we're
10764 implementing an interface indexer and this is neither an explicit
10765 interface implementation nor do the IndexerName match the one in
10768 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10769 If a method is defined here, then we always need to create a proxy
10770 for it. This is used when implementing interface indexers.
10771 (Pending.IsInterfaceIndexer): New public method.
10772 (Pending.ImplementIndexer): New public method.
10773 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10774 This is used when implementing interface indexers to define a proxy
10776 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10777 define a proxy if necessary.
10779 * interface.cs (Interface.IndexerName): New public variable.
10780 (Interface.PopulateIndexer): Set the IndexerName.
10781 (Interface.DefineIndexers): New private method. Populate all the
10782 indexers and make sure their IndexerNames match.
10784 * typemanager.cs (IndexerPropertyName): Added support for interface
10787 2002-07-22 Martin Baulig <martin@gnome.org>
10789 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10790 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10791 ret if HasReturnLabel.
10792 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10795 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10796 and set the ec.LoopBeginTryCatchLevel.
10797 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10798 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10799 the current ec.TryCatchLevel, the branch goes out of an exception
10800 block. In this case, we need to use Leave and not Br.
10802 2002-07-22 Martin Baulig <martin@gnome.org>
10804 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10805 block unless the block does not always return or it is contained in
10806 another try { ... } catch { ... } block. Fixes bug #26506.
10807 Added verify-1.cs to the test suite.
10809 2002-07-22 Martin Baulig <martin@gnome.org>
10811 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10812 then we do not always return. Fixes bug #24985.
10814 2002-07-22 Martin Baulig <martin@gnome.org>
10816 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10817 lookup on a per-class level; ie. walk up the class hierarchy until we
10818 found at least one applicable method, then choose the best among them.
10819 Fixes bug #24463 and test-29.cs.
10821 2002-07-22 Martin Baulig <martin@gnome.org>
10823 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10824 return types of the methods. The return type is not part of the
10825 signature and we must not check it to make the `new' modifier work.
10826 Fixes bug #27999, also added test-147.cs.
10827 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10829 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10830 on the method's return type.
10832 2002-07-21 Martin Baulig <martin@gnome.org>
10834 * assign.cs: Make this work if the rightmost source is a constant and
10835 we need to do an implicit type conversion. Also adding a few more tests
10836 to test-38.cs which should have caught this.
10838 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10839 target in the makefile for this. The makefile.gnu is primarily intended
10840 for end-users who don't want to debug the compiler.
10842 2002-07-21 Martin Baulig <martin@gnome.org>
10844 * assign.cs: Improved the Assign class so it can now handle embedded
10845 assignments (X = Y = Z = something). As a side-effect this'll now also
10846 consume less local variables. test-38.cs now passes with MCS, added
10847 a few new test cases to that test.
10849 2002-07-20 Martin Baulig <martin@gnome.org>
10851 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10852 instructions. Fixes bug #27977, also added test-146.cs.
10854 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10856 * cs-tokenizer.cs: fixed getHex ().
10858 2002-07-19 Martin Baulig <martin@gnome.org>
10860 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10861 not Type.GetType() to lookup the array type. This is needed when
10862 we're constructing an array of a user-defined type.
10863 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10864 single-dimensional arrays, but also for single-dimensial arrays of
10867 2002-07-19 Martin Baulig <martin@gnome.org>
10869 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10870 this function is called, it's not allowed to share LocalBuilders
10871 among ILGenerators.
10873 2002-07-19 Martin Baulig <martin@gnome.org>
10875 * expression.cs (Argument.Resolve): Report an error 118 when trying
10876 to pass a type as argument.
10878 2002-07-18 Martin Baulig <martin@gnome.org>
10880 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10881 Conv_R_Un for the signed `long' type.
10883 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10885 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10886 `expr' for the temporary result, as that will fail if we do
10887 multiple resolves on the same expression.
10889 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10891 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10892 ec.TypeContainer for looking up aliases.
10894 * class.cs (TypeContainer): Remove LookupAlias from here.
10896 * decl.cs (DeclSpace); Move here.
10898 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10900 * class.cs (FindMembers): Only call filter if the constructor
10901 bulider is not null.
10903 Also handle delegates in `NestedTypes' now. Now we will perform
10904 type lookups using the standard resolution process. This also
10907 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10908 This uses Expressions (the limited kind that can be parsed by the
10909 tree) instead of strings.
10911 * expression.cs (ComposedCast.ToString): Implement, used to flag
10912 errors since now we have to render expressions.
10914 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10917 * ecore.cs (SimpleName.ToString): ditto.
10919 * cs-parser.jay: Instead of using strings to assemble types, use
10920 Expressions to assemble the type (using SimpleName, ComposedCast,
10921 MemberAccess). This should fix the type lookups in declarations,
10922 because we were using a different code path for this.
10924 * statement.cs (Block.Resolve): Continue processing statements
10925 even when there is an error.
10927 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10929 * class.cs (Event.Define): Also remove the `remove' method from
10930 the list of pending items.
10932 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10933 generate more compact code.
10935 2002-07-17 Martin Baulig <martin@gnome.org>
10937 * const.cs (Const.LookupConstantValue): Add support for constant
10938 `unchecked' and `checked' expressions.
10939 Also adding test case test-140.cs for this.
10941 2002-07-17 Martin Baulig <martin@gnome.org>
10943 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10944 check whether mi.ReturnType implements the IEnumerator interface; the
10945 `==' and the IsAssignableFrom() will fail in this situation.
10947 2002-07-16 Ravi Pratap <ravi@ximian.com>
10949 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10952 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10954 * expression.cs: fixed bug #27811.
10956 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10958 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10959 Molaro: when we are a ref, the value already contains a pointer
10960 value, do not take the address of it.
10962 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10963 * removed mb-parser.jay and mb-tokenizer.cs
10965 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10967 * expression.cs: check against the building corlib void type.
10969 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10971 * ecore.cs: fix for valuetype static readonly fields: when
10972 initializing them, we need their address, not the address of a copy.
10974 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10976 * typemanager.cs: register also enum_type in corlib.
10978 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10980 * class.cs: allow calling this (but not base) initializers in structs.
10982 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10984 * ecore.cs: make sure we compare against the building base types
10987 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10989 * typemanager.cs: fix TypeToCoreType() to handle void and object
10990 (corlib gets no more typerefs after this change).
10992 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10994 * expression.cs (ArrayCreation.EmitArrayArguments): use
10995 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10997 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10998 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10999 array indexes, the runtime actually forbids them.
11001 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
11002 for array arguments here.
11004 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
11005 instead of the default for ValueTypes.
11007 (New.DoEmit): Use IsValueType instead of
11008 IsSubclassOf (value_type)
11009 (New.DoResolve): ditto.
11010 (Invocation.EmitCall): ditto.
11012 * assign.cs (Assign): ditto.
11014 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
11015 Statements *are* currently doing part of their resolution during
11018 Expressions do always resolve during resolve, but statements are
11019 only required to propagate resolution to their children.
11021 2002-07-11 Miguel de Icaza <miguel@ximian.com>
11023 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
11025 (LoadAssembly): Do not add the dll if it is already specified
11027 (MainDriver): Add the System directory to the link path at the end,
11028 after all the other -L arguments.
11030 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
11031 wrong opcode for loading bytes and bools (ldelem.i1 instead of
11032 ldelem.u1) and using the opposite for sbytes.
11034 This fixes Digger, and we can finally run it.
11036 * driver.cs (UnixParseOption): Move the option parsing here.
11037 (CSCParseOption): Implement CSC-like parsing of options.
11039 We now support both modes of operation, the old Unix way, and the
11040 new CSC-like way. This should help those who wanted to make cross
11041 platform makefiles.
11043 The only thing broken is that /r:, /reference: and /lib: are not
11044 implemented, because I want to make those have the same semantics
11045 as the CSC compiler has, and kill once and for all the confussion
11046 around this. Will be doing this tomorrow.
11048 * statement.cs (Unsafe.Resolve): The state is checked during
11049 resolve, not emit, so we have to set the flags for IsUnsfe here.
11051 2002-07-10 Miguel de Icaza <miguel@ximian.com>
11053 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
11054 not catch the Error_ObjectRefRequired in SimpleName (as it is
11055 possible to have a class/instance variable name that later gets
11056 deambiguated), we have to check this here.
11058 2002-07-10 Ravi Pratap <ravi@ximian.com>
11060 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
11061 make static and put into Expression.
11063 (Event.Define): Register the private field of the event with the
11064 TypeManager so that GetFieldFromEvent can get at it.
11066 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
11067 keep track of the private field associated with an event which
11070 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
11073 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
11075 2002-07-10 Miguel de Icaza <miguel@ximian.com>
11077 * expression.cs (Binary.EmitBranchable): this routine emits the
11078 Binary expression in a branchable context. This basically means:
11079 we need to branch somewhere, not just get the value on the stack.
11081 This works together with Statement.EmitBoolExpression.
11083 * statement.cs (Statement.EmitBoolExpression): Use
11086 2002-07-09 Miguel de Icaza <miguel@ximian.com>
11088 * statement.cs (For): Reduce the number of jumps in loops.
11090 (For): Implement loop inversion for the For statement.
11092 (Break): We can be breaking out of a Try/Catch controlled section
11093 (foreach might have an implicit try/catch clause), so we need to
11094 use Leave instead of Br.
11096 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
11097 now). If the instace expression supports IMemoryLocation, we use
11098 the AddressOf method from the IMemoryLocation to extract the
11099 address instead of emitting the instance.
11101 This showed up with `This', as we were emitting the instance
11102 always (Emit) instead of the Address of This. Particularly
11103 interesting when This is a value type, as we dont want the Emit
11104 effect (which was to load the object).
11106 2002-07-08 Miguel de Icaza <miguel@ximian.com>
11108 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
11110 * statement.cs (Checked): Set the CheckedState during the resolve
11111 process too, as the ConvCast operations track the checked state on
11112 the resolve process, and not emit.
11114 * cs-parser.jay (namespace_member_declaration): Flag that we have
11115 found a declaration when we do. This is used to flag error 1529
11117 * driver.cs: Report ok when we display the help only.
11119 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
11121 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
11123 2002-07-04 Miguel de Icaza <miguel@ximian.com>
11125 * cs-tokenizer.cs (define): We also have to track locally the
11126 defines. AllDefines is just used for the Conditional Attribute,
11127 but we also need the local defines for the current source code.
11129 2002-07-03 Miguel de Icaza <miguel@ximian.com>
11131 * statement.cs (While, For, Do): These loops can exit through a
11132 Break statement, use this information to tell whether the
11133 statement is the last piece of code.
11135 (Break): Flag that we break.
11137 * codegen.cs (EmitContexts): New `Breaks' state variable.
11139 2002-07-03 Martin Baulig <martin@gnome.org>
11141 * class.cs (TypeContainer.MethodModifiersValid): Allow override
11142 modifiers in method declarations in structs. Otherwise, you won't
11143 be able to override things like Object.Equals().
11145 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11147 * class.cs (Method, Property, Indexer): Do not allow the public
11148 modifier to be used in explicit interface implementations.
11150 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
11151 override modifiers in method declarations in structs
11153 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
11155 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
11156 integer or real overflow, report an error
11158 2002-07-02 Martin Baulig <martin@gnome.org>
11160 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
11161 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
11162 to tell the runtime about our newly created System.Object and
11163 System.ValueType types.
11165 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11167 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
11168 struct instead of Ldarg/Starg.
11170 2002-07-02 Martin Baulig <martin@gnome.org>
11172 * expression.cs (Indirection.Indirection): Call
11173 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
11175 2002-07-02 Martin Baulig <martin@gnome.org>
11177 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
11178 ValueType, call TypeManager.TypeToCoreType() on it.
11179 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
11180 the OpCodes.Newarr argument.
11182 2002-07-02 Martin Baulig <martin@gnome.org>
11184 * expression.cs (Invocation.EmitCall): When compiling corlib,
11185 replace all calls to the system's System.Array type to calls to
11186 the newly created one.
11188 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
11189 System.Array methods.
11190 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
11191 from the system's System.Array type which must be replaced.
11193 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
11195 * typemanager.cs: load unverifiable_code_ctor so we can build
11196 corlib using the correct type. Avoid using GetTypeCode() with
11198 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
11199 TypeManager.object_type to allow building corlib.
11201 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
11203 * ecore.cs: handle System.Enum separately in LoadFromPtr().
11205 2002-07-01 Martin Baulig <martin@gnome.org>
11207 * class.cs: Make the last change actually work, we need to check
11208 whether `ifaces != null' to avoid a crash.
11210 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11212 * class.cs: when we build structs without fields that implement
11213 interfaces, we need to add the interfaces separately, since there is
11214 no API to both set the size and add the interfaces at type creation
11217 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11219 * expression.cs: the dimension arguments to the array constructors
11220 need to be converted if they are a long.
11222 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
11224 * class.cs: don't emit ldarg.0 if there is no parent constructor
11225 (fixes showstopper for corlib).
11227 2002-06-29 Martin Baulig <martin@gnome.org>
11229 MCS now compiles corlib on GNU/Linux :-)
11231 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
11232 ie. check for MethodImplOptions.InternalCall.
11234 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
11235 and TypeManager.attribute_type are null, so we must explicitly check
11236 whether parent is not null to find out whether it's an attribute type.
11237 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
11238 and SetBuilder, not only if the property is neither abstract nor external.
11239 This is necessary to set the MethodImplOptions on the accessor methods.
11240 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
11241 SetBuilder, see Property.Emit().
11243 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
11244 populate "System.Object", "System.ValueType" and "System.Attribute" since
11245 they've already been populated from BootCorlib_PopulateCoreTypes().
11247 2002-06-29 Martin Baulig <martin@gnome.org>
11249 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
11250 is the NullLiteral, we also need to make sure that target_type is not
11253 2002-06-29 Martin Baulig <martin@gnome.org>
11255 * rootcontext.cs (RootContext.ResolveCore): We must initialize
11256 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
11257 before calling BootstrapCorlib_ResolveDelegate ().
11259 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11261 * statement.cs: fixed build-breaker. All tests passed ok.
11263 2002-06-27 Martin Baulig <martin@gnome.org>
11265 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
11266 for System.Decimal when compiling corlib.
11268 2002-06-27 Martin Baulig <martin@gnome.org>
11270 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
11271 switch blocks which contain nothing but a default clause.
11273 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
11275 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
11277 2002-06-27 Martin Baulig <martin@gnome.org>
11279 * ecore.cs (PropertyExpr.PropertyExpr): Call
11280 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
11282 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
11283 is already a TypeBuilder.
11285 2002-06-27 Martin Baulig <martin@gnome.org>
11287 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
11288 `target_type == TypeManager.array_type', not IsAssignableFrom() in
11289 the "from an array-type to System.Array" case. This makes it work
11290 when compiling corlib.
11292 2002-06-27 Martin Baulig <martin@gnome.org>
11294 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
11295 non-static PropertyExpr, set its InstanceExpression. This makes
11296 the `ICollection.Count' property work in System/Array.cs.
11298 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
11300 * driver.cs: Made error handling more consistent. Errors now
11301 tracked by Report class, so many methods which used to return int
11302 now return void. Main() now prints success/failure and
11303 errors/warnings message.
11305 Renamed '--probe' compiler argument to '--expect-error'. Removed
11306 the magic number return values (123 and 124). Now, if the
11307 expected error occurs, the compiler exits with success (exit value
11308 0). If the compilation completes without seeing that particular
11309 error, the compiler exits with failure (exit value 1). The
11310 makefile in mcs/errors has been changed to handle the new behaviour.
11312 * report.cs: Made 'expected error' number a property and renamed
11313 it from 'Probe' to 'ExpectedError'.
11315 * genericparser.cs: Removed error handling support, since it is
11316 now all done by Report class.
11318 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
11319 class, so parse() no longer returns an int.
11321 * namespace.cs: Use Report.Error instead of GenericParser.error
11323 2002-06-22 Miguel de Icaza <miguel@ximian.com>
11325 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
11326 TypeContainer.AddOperator): At the front of the list put the
11327 explicit implementations, so they get resolved/defined first.
11329 2002-06-21 Miguel de Icaza <miguel@ximian.com>
11331 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
11332 interface type is implemented by this TypeContainer. Used during
11333 explicit interface implementation.
11335 (Property.Define, Indexer.Define, Method.Define): Validate that
11336 the given interface in the explicit implementation is one of the
11337 base classes for the containing type.
11339 Also if we are explicitly implementing an interface, but there is
11340 no match in the pending implementation table, report an error.
11342 (Property.Define): Only define the property if we are
11343 not explicitly implementing a property from an interface. Use the
11344 correct name also for those properties (the same CSC uses,
11345 although that is really not needed).
11347 (Property.Emit): Do not emit attributes for explicitly implemented
11348 properties, as there is no TypeBuilder.
11350 (Indexer.Emit): ditto.
11352 Hiding then means that we do not really *implement* a pending
11353 implementation, which makes code fail.
11355 2002-06-22 Martin Baulig <martin@gnome.org>
11357 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
11358 the return value of Object.GetType(). [FIXME: we need to do this whenever
11359 we get a type back from the reflection library].
11361 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
11363 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
11365 2002-06-20 Miguel de Icaza <miguel@ximian.com>
11367 * attribute.cs: Return null if we can not look up the type.
11369 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
11370 the interface types found.
11372 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
11373 interface types found.
11375 * typemanager.cs (GetInterfaces): Make this routine returns alll
11376 the interfaces and work around the lame differences between
11377 System.Type and System.Reflection.Emit.TypeBuilder in the results
11378 result for GetInterfaces.
11380 (ExpandInterfaces): Given an array of interface types, expand and
11381 eliminate repeated ocurrences of an interface. This expands in
11382 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
11385 2002-06-21 Martin Baulig <martin@gnome.org>
11387 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
11390 2002-06-21 Martin Baulig <martin@gnome.org>
11392 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
11393 and called with one of the core types, return the corresponding typebuilder for
11396 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
11399 2002-06-21 Martin Baulig <martin@gnome.org>
11401 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
11402 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
11403 (Expression.ConvertReferenceExplicit): Likewise.
11405 * expression.cs (ElementAccess.DoResolve): Likewise.
11406 (ElementAccess.DoResolveLValue): Likewise.
11408 2002-06-10 Martin Baulig <martin@gnome.org>
11410 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
11411 add the "value" parameter to the parameter list.
11413 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
11416 2002-06-19 Miguel de Icaza <miguel@ximian.com>
11418 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
11419 the argument to an int, uint, long or ulong, per the spec. Also
11420 catch negative constants in array creation.
11422 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
11424 * class.cs: do not allow the same interface to appear twice in
11425 the definition list.
11427 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
11429 * ecore.cs: don't use ldlen with System.Array.
11431 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
11433 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
11435 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
11437 * modifiers.cs: produce correct field attributes for protected
11438 internal. Easy fix so miguel can work on ther harder stuff:-)
11440 2002-06-18 Miguel de Icaza <miguel@ximian.com>
11442 * pending.cs: New file. Move the code from class.cs here.
11443 Support clearning the pending flag for all methods (when not doing
11444 explicit interface implementation).
11446 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
11448 * rootcontext.cs: added a couple more types needed to bootstrap.
11450 2002-06-17 Miguel de Icaza <miguel@ximian.com>
11452 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
11453 constructor in the type, instead of any constructor in the type
11454 hierarchy. Thanks to Paolo for finding this bug (it showed up as
11455 a bug in the Mono runtime when applying the params attribute).
11457 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11458 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
11460 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
11462 * expression.cs (Unary.ResolveOperator): Use TypeManager
11463 to resolve the type.
11465 2002-06-13 Ravi Pratap <ravi@ximian.com>
11467 * cs-parser.jay (enum_member_declaration): Pass in the attributes
11470 * enum.cs (AddEnumMember): Add support to store the attributes associated
11471 with each member too.
11473 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
11474 field builders too - this takes care of the enum member case.
11476 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
11478 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
11479 address-of operator on both value types and pointers.
11481 2002-06-10 Martin Baulig <martin@gnome.org>
11483 * interface.cs (Interface.PopulateIndexer): Add the indexer's
11484 PropertyBuilder to the `property_builders' list.
11486 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
11487 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
11488 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
11489 find any indexers which are inherited from an interface.
11491 2002-06-09 Martin Baulig <martin@gnome.org>
11493 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
11494 the same type as the constant if necessary. There's also a test-130.cs
11497 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
11499 * typemanager.cs (TypeManager.ChangeType): Previously known as
11500 Enum.ChangeEnumType().
11502 2002-06-09 Martin Baulig <martin@gnome.org>
11504 * expression.cs (Cast.TryReduce): Added support for consts.
11506 2002-06-08 Ravi Pratap <ravi@ximian.com>
11508 * class.cs (Accessor): Hold attributes information so we can pass
11511 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
11512 Modify to pass in attributes attached to the methods.
11514 (add_accessor_declaration, remove_accessor_declaration): Ditto.
11516 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
11517 to handle the Accessor kind :-)
11519 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
11521 2002-06-08 Martin Baulig <martin@gnome.org>
11523 * expression.cs (Unary.TryReduceNegative): Added support for
11526 2002-06-08 Martin Baulig <martin@gnome.org>
11528 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
11529 name can't be found in the `defined_names' - the caller will do a
11530 MemberLookup in this case and thus find methods in System.Enum
11531 such as Enum.IsDefined().
11533 2002-06-08 Martin Baulig <martin@gnome.org>
11535 * enum.cs (Enum.ChangeEnumType): This is a custom version of
11536 Convert.ChangeType() which works with TypeBuilder created types.
11537 (Enum.LookupEnumValue, Enum.Define): Use it here.
11539 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
11540 `TypeBuilder.BaseType != null' check.
11541 (TypeContainer.FindMembers): Only lookup parent members if we
11542 actually have a parent.
11543 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11544 (ConstructorInitializer.Resolve): Likewise.
11546 * interface.cs (Interface.FindMembers): Added
11547 `TypeBuilder.BaseType != null' check.
11549 * rootcontext.cs (RootContext.ResolveCore): Added
11550 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11551 classes_second_stage.
11553 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11554 debug_type and trace_type when compiling with --nostdlib.
11556 2002-06-07 Martin Baulig <martin@gnome.org>
11558 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11559 (AddField): Set it to true when adding a non-static field.
11560 (DefineType): Use `have_nonstatic_fields' to find out whether we
11561 have non-static fields, not `Fields != null'.
11563 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11565 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11566 dereferencing a null on the static-field code path)
11568 2002-05-30 Martin Baulig <martin@gnome.org>
11570 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11571 to take command line arguments. Use reflection to call the new
11572 custom `Initialize' function on the symbol writer and pass it the
11573 command line arguments.
11575 * driver.cs (--debug-args): New command line argument to pass command
11576 line arguments to the symbol writer.
11578 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11580 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11581 the target type for indexers and properties. Thanks to Joe for
11584 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11586 * typemanager.cs (MethodFlags): returns the method flags
11587 (Obsolete/ShouldIgnore) that control warning emission and whether
11588 the invocation should be made, or ignored.
11590 * expression.cs (Invocation.Emit): Remove previous hack, we should
11591 not do this on matching a base type, we should do this based on an attribute
11593 Only emit calls to System.Diagnostics.Debug and
11594 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11595 on the command line.
11597 * rootcontext.cs: Global settings for tracing and debugging.
11599 * cs-tokenizer.cs (define): New utility function to track
11600 defines. Set the global settings for TRACE and DEBUG if found.
11602 2002-05-25 Ravi Pratap <ravi@ximian.com>
11604 * interface.cs (Populate*): Pass in the TypeContainer as well as
11605 the DeclSpace as parameters so that we can create EmitContexts and
11606 then use that to apply attributes etc.
11608 (PopulateMethod, PopulateEvent, PopulateProperty)
11609 (PopulateIndexer): Apply attributes everywhere.
11611 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11614 (ApplyAttributes): Update accordingly.
11616 We now apply interface attributes for all members too.
11618 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11620 * class.cs (Indexer.Define); Correctly check if we are explicit
11621 implementation (instead of checking the Name for a ".", we
11622 directly look up if the InterfaceType was specified).
11624 Delay the creation of the PropertyBuilder.
11626 Only create the PropertyBuilder if we are not an explicit
11627 interface implementation. This means that explicit interface
11628 implementation members do not participate in regular function
11629 lookups, and hence fixes another major ambiguity problem in
11630 overload resolution (that was the visible effect).
11632 (DefineMethod): Return whether we are doing an interface
11635 * typemanager.cs: Temporary hack until we get attributes in
11636 interfaces (Ravi is working on that) and we get IndexerName
11637 support in interfaces.
11639 * interface.cs: Register the indexers as properties.
11641 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11642 warning, I have verified that this is a bug in the .NET runtime
11643 (JavaScript suffers of the same problem).
11645 * typemanager.cs (MemberLookup): When looking up members for
11646 interfaces, the parent of an interface is the implicit
11647 System.Object (so we succeed in searches of Object methods in an
11648 interface method invocation. Example: IEnumerable x; x.ToString
11651 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11653 * class.cs (Event): Events should also register if they do
11654 implement the methods that an interface requires.
11656 * typemanager.cs (MemberLookup); use the new GetInterfaces
11659 (GetInterfaces): The code used to lookup interfaces for a type is
11660 used in more than one place, factor it here.
11662 * driver.cs: Track the errors at the bottom of the file, we kept
11665 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11666 instance if the method we are calling is static!
11668 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11670 * attribute.cs (ApplyAttributes): Make this function filter out
11671 the IndexerName attribute (as that attribute in reality is never
11672 applied) and return the string constant for the IndexerName
11675 * class.cs (TypeContainer.Emit): Validate that all the indexers
11676 have the same IndexerName attribute, and if so, set the
11677 DefaultName attribute on the class.
11679 * typemanager.cs: The return value might contain other stuff (not
11680 only methods). For instance, consider a method with an "Item"
11681 property and an Item method.
11683 * class.cs: If there is a problem with the parameter types,
11686 2002-05-24 Ravi Pratap <ravi@ximian.com>
11688 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11689 looks at user defined conversion after making a call to
11690 StandardConversionExists - we need this for overload resolution.
11692 * expression.cs : Update accordingly the various method calls.
11694 This fixes 2 bugs filed against implicit user defined conversions
11696 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11698 * statement.cs: Track the result of the assignment.
11700 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11702 * expression.cs (MemberAccess): Improved error reporting for
11703 inaccessible members.
11705 2002-05-22 Martin Baulig <martin@gnome.org>
11707 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11708 itself with debugging support.
11710 2002-05-22 Martin Baulig <martin@gnome.org>
11712 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11713 Removed, this isn't needed anymore.
11715 2002-05-20 Martin Baulig <martin@gnome.org>
11717 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11718 be underlying type for an enum.
11720 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11722 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11723 that splits out the loading of just the core types.
11725 * rootcontext.cs (ResolveCore): Split the struct resolution in
11726 two, so we can load the enumeration underlying types before any
11729 * expression.cs (Is): Bandaid until we fix properly Switch (see
11730 bug #24985 for details).
11732 * typemanager.cs (ImplementsInterface): The hashtable will contain
11733 a null if there are no interfaces implemented.
11735 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11737 * cs-parser.jay (indexer_declarator): It is fine to have array
11740 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11742 * typemanager.cs: (RegisterBuilder): New function used to register
11743 TypeBuilders that implement interfaces. Since
11744 TypeBuilder.GetInterfaces (as usual) does not work with lame
11746 (AddUserType): register interfaces.
11748 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11749 dealing with TypeBuilder. Also, arrays are showing up as
11750 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11751 methods can not be invoked on them!
11753 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11754 (ImplicitReferenceConversionExists): Split out from
11755 StandardConversionExists.
11757 * expression.cs (As): We were only implementing one of the three
11758 cases for the as operator. We now implement them all.
11759 (Is): Implement the various other cases for Is as well.
11761 * typemanager.cs (CACHE): New define used to control if we want or
11762 not the FindMembers cache. Seems to have a negative impact on
11763 performance currently
11765 (MemberLookup): Nested types have full acess to
11766 enclosing type members
11768 Remove code that coped with instance/static returns for events, we
11769 now catch this in RealFindMembers.
11771 (RealFindMembers): only perform static lookup if the instance
11772 lookup did not return a type or an event.
11774 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11776 * assign.cs (CompoundAssign): We pass more semantic information
11777 now to Compound Assignments than we did before: now we have all
11778 the information at hand, and now we resolve the target *before* we
11779 do the expression expansion, which allows the "CacheValue" method
11780 to have the effect we intended (before, a [x] += 1 would generate
11781 two differen ArrayAccess expressions from the ElementAccess,
11782 during the resolution process).
11784 (CompoundAssign.DoResolve): Resolve target and original_source here.
11786 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11788 * expression.cs (ArrayAccess): dropped debugging information.
11790 * typemanager.cs: Small bug fix: I was always returning i_members,
11791 instead of one of i_members or s_members (depending on which had
11794 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11795 method is invoked before any code generation takes place, and it
11796 is a mechanism to inform that the expression will be invoked more
11797 than once, and that the method should use temporary values to
11798 avoid having side effects
11800 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11802 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11805 * expression.cs (Indirection, ArrayAccess): Add support for
11806 CacheTemporaries in these two bad boys.
11808 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11809 ldobj or ldind_ref.
11810 (StoreFromPtr): Handle stobj as well.
11812 * expression.cs (UnaryMutator): Share more code.
11814 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11815 down: I was not tracking the Filter function as well, which
11816 was affecting the results of the cache.
11818 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11820 * attribute.cs: Remove the hack to handle the CharSet property on
11823 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11825 * attribute.cs (DoResolve): More uglyness, we now only try to
11826 resolve the attribute partially, to extract the CharSet
11827 information (only if we are a StructLayout attribute). Otherwise
11829 (GetExtraTypeInfo): Add some code to conditionally kill in the
11830 future this. I am more and more convinced that the .NET
11831 framework has special code to handle the attribute setting on
11834 * expression.cs (IsParamsMethodApplicable): Revert my previous
11835 foreach change here, it was wrong.
11837 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11839 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11840 (pp_expr): do not abort on unknown input, just return.
11841 (eval): abort if there are pending chars.
11843 * attribute.cs (Attribute.Resolve): Positional parameters are
11844 optional. Deal with that case.
11846 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11847 the Ansi/Unicode/Auto information for the type.
11849 (TypeContainer.DefineType): instantiate the EmitContext here, as
11850 we will be using it during the type definition (to resolve
11851 attributes) and during the emit phase.
11853 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11854 to pull type information out of the attributes
11856 (Attribute.Resolve): track the constructor builder, and allow for
11857 multiple invocations (structs and classes will use this).
11859 * ecore.cs (MemberLookupFinal): new version with all the
11860 parameters customizable.
11862 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11863 constructors. Return if the result value is null (as the error
11864 would have been flagged already by MemberLookupFinal)
11866 Do not allow instances of abstract classes or interfaces to be
11869 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11870 We have to compare the assembly property here when dealing with
11871 FamANDAssem and Assembly access modifiers, because we might be
11872 creating an assembly from *modules* (that means that we are not
11873 getting TypeBuilders for types defined in other modules that are
11874 part of this assembly).
11876 (Method.Emit): If the method is marked abstract and has a body,
11879 (TypeContainer.DefineMembers): If both the defined member and the
11880 parent name match are methods, then do not emit any warnings: let
11881 the Method.Define routine take care of flagging warnings. But if
11882 there is a mismatch (method overrides something else, or method is
11883 overriwritten by something, then emit warning).
11885 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11886 set to null, this means `do not check for the return type on the
11889 (Method.Define): set the return type for the method signature to
11890 null, so that we get methods with the same name and parameters and
11891 different return types. This is used to flag warning 114 (you are
11892 hiding a method, and you probably want to use the new/override
11895 * typemanager.cs (MemberLookup): Implemented proper access
11896 control, closing a long standing set of bug reports. The problem
11897 was that the Framework only has two bits: Public and NonPublic,
11898 and NonPublic includes private and protected methods, but we need
11899 to enforce the FamANDAssem, FamOrAssem and Family.
11901 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11903 * statement.cs (GotoCase): Return true: Ammounts to giving up
11904 knowledge on whether we return or not, and letting the other case
11905 be responsible for it.
11907 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11909 * driver.cs: Do not load directories for each file processed, only
11910 do it if there is a pattern.
11912 * ecore.cs: Report readonly assigns here as well, as we might have
11913 been resolved only by MemberAccess.
11915 (SimpleName.SimpleNameResolve): Also be useful for LValue
11916 resolution. We need this to propagate assign to local readonly variables
11918 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11919 do not want to reuse potential criteria memory.
11921 * class.cs (MyEventBuilder): Set reflected_type;
11923 * ecore.cs (Constantify): Added support for constifying bools.
11925 (RootContext.LookupType): Added a cache for values looked up in
11926 the declaration space.
11928 * typemanager.cs (FindMembers): Now is a front-end to
11929 RealFindMembers, and provides a two-level hashtable-based cache to
11932 15% performance improvement: from 22.5 to 19.2 seconds.
11934 * expression.cs (IsParamsMethodApplicable): use foreach.
11935 (Invocation.DoResolve): ditto.
11936 (New.DoResolve): ditto.
11937 (ArrayCreation.DoResolve): ditto.
11939 * ecore.cs (FindMostEncompassingType): use foreach.
11941 * delegate.cs (NewDelegate.DoResolve): Use foreach
11943 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11944 (RemoveMethods): use foreach.
11946 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11947 nested foreach statements instead of for, and also break out of
11948 the inner loop once a match is found.
11950 (Invocation.OverloadResolve): Use foreach, simplify the code.
11952 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11954 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11955 we actually unwrap the expression to allow for extra information
11958 * expression.cs: Use Shr_Un on unsigned operations.
11960 2002-05-08 Ravi Pratap <ravi@ximian.com>
11962 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11963 applicable operators was not being considered correctly. This closes
11964 the bug Miguel reported.
11966 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11968 * attribute.cs: check that the type derives from System.Attribute
11969 and report the correct error in that case (moved the duplicate code to
11970 its own method, too).
11972 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11974 * attribute.cs: lookup attribute type name as the spec says: first the
11975 bare attribute name and then name + "Attribute" (nant compiles with
11976 mcs after this fix).
11978 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11980 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11981 Because of the way we parse things, we should try to see if a
11982 UIntConstant can fit in an integer.
11984 2002-05-07 Ravi Pratap <ravi@ximian.com>
11986 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11987 when we are in an explicit context.
11989 (ConvertReferenceExplicit): When converting from Iface type S to Class
11990 T make sure the rules are implemented as an OR.
11992 * parameter.cs (ParameterType): Make it a property for now although the
11993 purpose really isn't anything immediate.
11995 * expression.cs (Is*Applicable): Do better checking on the parameter type
11996 of a ref/out parameter. The ones from the system assemblies are already
11997 marked with the correct type so we don't need to do any correction.
11999 * ecore.cs (StandardConversionExists): Conversion from Interface types to
12000 the object type is standard too so include that.
12002 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12004 * ecore.cs (StandardConversionExists): Augment with missing code:
12005 deal with IntConstant, LongConstants and Enumerations.
12007 * assign.cs: Report the error, instead of failing silently
12009 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
12010 typecontainer that they are declared, because the
12011 typecontainer/namespace will have the list of using clauses that
12012 need to be applied.
12014 Assembly Attributes were escaping the normal registration
12017 (EmitCode): Apply attributes within an EmitContext that represents
12018 the container they were declared on.
12020 * cs-parser.jay: Track bases for structs. How did I get this wrong?
12022 2002-05-06 Ravi Pratap <ravi@ximian.com>
12024 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
12025 Revamp completely - make much cleaner as we now operate only
12028 (FindMostSpecificSource, FindMostSpecificTarget): New methods
12029 to implement the logic detailed in the spec more correctly.
12031 (UserDefinedConversion): Update accordingly.
12033 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12035 * statement.cs: Return flow analysis information up.
12037 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
12040 (token): Do not consume an extra character before calling
12043 2002-05-06 Piers Haken <piersh@friskit.com>
12045 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
12047 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12049 * class.cs (Constructor.Emit): Set the IsStatic flag in the
12050 EmitContext during the instance constructor initializer
12051 resolution, to stop access to instance variables.
12053 This is mandated by the spec, last paragraph of the `constructor
12054 initializers' section.
12056 2002-05-05 Miguel de Icaza <miguel@ximian.com>
12058 * cs-parser.jay, class.cs (Accessor): new class used to represent
12059 an accessor (get or set). In the past we used `null' to represent
12060 a missing accessor. But this is ambiguous because there was no
12061 way to tell in abstract indexers/properties if one of them was
12064 Now there is a way of addressing that.
12066 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
12067 instead of FindMembers.
12069 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
12070 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
12072 * attribute.cs: Treat indexers and properties as the same in terms
12073 of applying attributes
12075 * ecore.cs (FindMostEncompassedType): Use statically initialized
12076 EmptyExpressions()s like we do elsewhere to avoid creating useless
12077 objects (and we take this out of the tight loop).
12079 (GetConversionOperators): Move the code to extract the actual
12080 operators to a separate routine to clean things up.
12082 2002-05-04 Miguel de Icaza <miguel@ximian.com>
12084 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
12085 events are always registered FieldBuilders.
12087 * class.cs (FieldBase): New class shared by Fields
12089 * delegate.cs: If we are a toplevel delegate, use our full name.
12090 If we are a nested delegate, then only use our tail name.
12092 2002-05-02 Ravi Pratap <ravi@ximian.com>
12094 * expression.cs (IsApplicable): Ensure that we add the "&" to
12095 ref/out types before comparing it with the type of the argument.
12097 (IsParamsMethodApplicable): Ditto.
12099 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
12102 * delegate.cs : Handle the case when we have more than one applicable
12103 method. Flag an error only when we finish checking all.
12105 2002-05-02 Miguel de Icaza <miguel@ximian.com>
12107 * expression.cs: Add support for boolean static initializers.
12109 2002-05-01 Miguel de Icaza <miguel@ximian.com>
12111 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
12113 * parameter.cs (ComputeParameterTypes,
12114 ComputeAndDefineParameterTypes): Better error handling: now we
12115 clear the `types' cache if we fail during any of the type lookups.
12116 We also return the status code correctly to our caller
12118 * delegate.cs: If we fail to define a delegate, abort the extra
12121 * expression.cs (Binary.ResolveOperator): for
12122 operator==(object,object) and operator !=(object, object) we also
12123 have to verify that there is an implicit conversion from one to
12126 (ArrayAccess.DoResolve): Array Access can operate on
12129 2002-04-30 Miguel de Icaza <miguel@ximian.com>
12131 * assign.cs (CompoundAssign): A new class used as a "flag" that
12132 the assignment actually is happening as part of a compound
12133 assignment operator.
12135 During compound assignment, a few new rules exist to enable things
12142 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
12143 to the type of x) if y is implicitly convertible to the type of x,
12144 and the operator is a builtin operator and the return type of the
12145 operator is explicitly convertible to the type of x.
12147 * rootcontext.cs: Reset warning level to 2. 4 catches various
12148 "interesting" features in mcs, we must clean this up at some
12149 point, but currently am trying to kill other bugs ;-)
12151 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
12152 in container classes as well.
12154 * expression.cs (Binary.ResolveOperator): Handle string case
12155 before anything else (as operator overloading does emit an error
12156 before doing anything else).
12158 This code could go away when we move to a table driven model, but
12159 i could not come up with a good plan last night.
12161 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
12163 * typemanager.cs (CSharpName): reimplementation using regex.
12164 * class.cs: added null check for fields in Emit
12165 * rootcontext.cs: set warninglevel to 4
12167 2002-04-29 Miguel de Icaza <miguel@ximian.com>
12169 * typemanager.cs (CSharpName): reimplemented with Lupus
12172 2002-04-28 Miguel de Icaza <miguel@ximian.com>
12174 * statement.cs (If): correclty implement Resolve, because we were
12175 not catching sem errors in there. The same process is needed
12177 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
12180 (Statement.Warning_DeadCodeFound): Factorize code.
12181 (While): Report dead code here too.
12183 (Statement): Added Resolve virtual method to allow
12184 for resolution split from the emit code.
12186 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12188 * statement.cs (EmitBoolExpression): No longer try to resolve the
12190 (MakeBoolean): New utility function that resolve, implicitly
12191 converts to boolean and tags the expression.
12194 (If, Do): Implement dead code elimination.
12195 (While): Implement loop inversion
12197 (Do, While, For, If): Resolve the expression prior to calling our
12200 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
12203 - added method Report28 (warning: program has more than one entry point)
12204 - added method IsEntryPoint, implements paragraph 10.1 of the spec
12205 - modified method Method.Define, the part at the end of the method
12207 * rootcontext.cs: added static public Location EntryPointLocation;
12209 * ../errors/cs0028.cs : Add test case for the above warning.
12212 - modified method CSharpName to allow arrays of primitive type to
12213 be printed nicely (e.g. instead of System.Int32[][] it now prints
12215 - added method CSharpSignature: returns the signature of a method
12216 in string format to be used in reporting errors, warnings, etc.
12218 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
12221 2002-04-26 Ravi Pratap <ravi@ximian.com>
12223 * delegate.cs (Define): Fix extremely silly bug where I was
12224 setting the type of the 'object' parameter of the BeginInvoke
12225 method to System.IAsyncResult instead of System.Object ;-)
12227 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12229 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
12232 (Constructor.Emit): return if we fail to initialize the
12233 constructor. Another door closed!
12235 * expression.cs (New.DoResolve): Improve error message (from -6 to
12236 1501). Use DeclaredOnly lookup to find the exact constructor.
12238 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
12239 loop. This is useful.
12241 * cs-parser.jay: Adjust the default parameters so that destructors
12242 have the proper signature.
12244 2002-04-26 Martin Baulig <martin@gnome.org>
12246 * driver.cs (LoadAssembly): If `assembly' contains any characters
12247 which are only valid in path names and not in assembly names
12248 (currently slash, backslash and point), use Assembly.LoadFrom ()
12249 instead of Assembly.Load () on the `assembly' (before iteration
12250 over the link_paths).
12252 2002-04-26 Martin Baulig <martin@gnome.org>
12254 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
12256 2002-04-25 Miguel de Icaza <miguel@ximian.com>
12258 * class.cs (Property): use the new typemanager.MemberLookup
12260 (TypeContainer.MemberLookup): Implement using the
12261 TypeManager.MemberLookup now.
12263 * typemanager.cs: Make MemberLookup a function of the TypeManager,
12264 and return MemberInfos, so that these can be used without an
12265 EmitContext (what we had before).
12267 2002-04-24 Miguel de Icaza <miguel@ximian.com>
12269 * expression.cs: Fix the case where the argument to params if the
12270 type of the params. I omitted handling this before. Fixed
12272 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12274 * driver.cs: Call BootCorlib_PopulateCoreType
12276 * class.cs (Property.CheckBase): Check for properties only, not
12279 * interface.cs: Temporary hack: try/catch around the
12280 CustomAttributeBuilder, because I am getting an exception that I
12283 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
12284 types whose definitions are required to be there (attributes are
12285 defined before standard types).
12287 Compute definitions as we boot the various types, as they are used
12288 immediately (value_type class will need object_type, but if we do
12289 not initialize object_type, we will pass a null, which will let
12290 the runtime pick the System.Object from the existing corlib, which
12291 is not what we want).
12293 2002-04-22 Patrik Torstensson <totte@labs2.com>
12295 * cs-tokenizer.cs: fixed a number of trim() issues.
12297 2002-04-22 Ravi Pratap <ravi@ximian.com>
12299 * expression.cs (Argument.Type): Ensure that we return the correct
12300 type when we have out or ref parameters [in which case we
12303 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12305 * class.cs (Property, Indexer): Allow extern modifier in there.
12307 * typemanager.cs (InitBaseTypes): Initializes object_type and
12308 value_type, since those will be used early on during the bootstrap
12309 process to compile corlib.
12311 (InitCoreTypes): Move code from here to InitBaseTypes.
12313 2002-04-21 Miguel de Icaza <miguel@ximian.com>
12315 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
12316 single-dimension arrays as using the ldlen opcode.
12318 Daniel Lewis discovered this optimization.
12320 * typemanager.cs: Add signature for System.Array::get_Length
12322 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12324 * statement.cs: report the error when the foreach does not apply to an
12325 array nor a collection.
12327 2002-04-19 Miguel de Icaza <miguel@ximian.com>
12329 * expression.cs: Add implicit conversions to the operator ~.
12331 * constant.cs (DecimalConstant.Emit): Emit decimal value.
12333 * typemanager.cs: Locate the decimal constructor.
12335 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12337 * attribute.cs: use the new property of TypeOf.
12338 * expression.cs: added 'get' property around typearg.
12340 These changes fix a build breaker reported by NickD. Is this the
12341 correct way to fix? If not, please, revert my changes and make it
12344 2002-04-17 Miguel de Icaza <miguel@ximian.com>
12346 * attribute.cs: Add support for typeof in attribute invocations.
12347 I am not sure that this is right though.
12349 2002-04-14 Duncan Mak <duncan@ximian.com>
12351 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
12352 Binary.Operator.Division case.
12354 2002-04-13 Ravi Pratap <ravi@ximian.com>
12356 * class.cs (DefineType): Ensure that we do a proper check on
12357 attribute types and also register it with the TypeManager.
12359 (TypeContainer.Targets): The default for attribute types is
12360 AttributeTargets.All.
12362 * attribute.cs (ApplyAttributes): Registering the attribute type
12363 is done elsewhere, not when we discover we have a Usage attribute.
12365 2002-04-12 Ravi Pratap <ravi@ximian.com>
12367 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
12368 and get rid of is_delegate parameter.
12370 * everywhere : update.
12372 2002-04-12 Ravi Pratap <ravi@ximian.com>
12374 * cs-parser.jay (compilation_unit): Revamp completely to use
12375 some new ideas that I got from Rhys' grammar to solve the problems
12376 with assembly level attributes.
12378 (outer_declaration): New grammar production.
12380 (attribute_sections): Add.
12382 (opt_attributes): Base on attribute_sections
12384 (namespace_declaration): Allow opt_attributes to tackle the case
12385 when we have assembly level attributes - we are clever in this
12388 * attribute.cs (ApplyAttributes): Do not worry about assembly
12389 attributes in the non-global context.
12391 * rootcontext.cs (AddGlobalAttributes): Go back to using this
12392 instead of SetGlobalAttributes.
12394 * class.cs, rootcontext.cs : Ensure we define and generate
12395 attribute types before anything else.
12397 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
12398 and flag the new error -20 for the case when the attribute type
12399 does not have valid targets specified. csc does not catch this.
12401 * ../errors/errors.txt : update for error # -20
12403 2002-04-11 Ravi Pratap <ravi@ximian.com>
12405 * support.cs (InternalParameters.ParameterModifier): Do some null
12406 checking and return sane values.
12408 * class.cs (Method.Define): If we are a PInvoke method, ensure
12409 that we are static and extern. Report error # 601
12411 * ../errors/cs0601.cs : Add test case for the above error.
12413 2002-04-07 Ravi Pratap <ravi@ximian.com>
12415 * rootcontext.cs (attribute_types): We need to keep type of
12416 all attribute types separately and emit code for them first.
12418 (RegisterAttribute) : Implement.
12420 * class.cs (DefineType): Check if the current Type is a custom
12421 attribute type and register it accordingly.
12423 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
12424 adding the first attribute twice and rename to
12426 (SetGlobalAttributes): this.
12428 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
12431 * attribute.cs (ApplyAttributes): Take an additional argument telling us
12432 if we are processing global arguments. Hmm, I am unsure of this.
12434 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12436 * expression.cs: added static array of strings to avoid calling
12437 Enum.ToString () for Operator in Binary. Significant recover of
12440 2002-04-10 Miguel de Icaza <miguel@ximian.com>
12442 * class.cs (FindMembers): Allow the Builders of the various
12443 members to be null. If they are skip them. This only happens
12444 during the PInvoke declaration.
12446 2002-04-09 Miguel de Icaza <miguel@ximian.com>
12448 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
12449 failure, so we do not keep going afterwards.
12451 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
12452 wanted to pass `false' as the `is_delegate' argument. If this is
12453 the case, why not use delegate_type == null to mean `is_delegate =
12454 false' and anything else as is_delegate = true.
12456 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
12458 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
12459 code for the section, not the beginning of the tests.
12461 2002-04-08 Miguel de Icaza <miguel@ximian.com>
12463 * cfold.cs: Handle operator + (Enum x, Underlying x)
12465 * expression.cs (Binary): same. Warn about errors where we have
12466 Enum/Enum in operator + as well.
12468 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
12471 - added support for switch(bool)
12472 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
12473 - add TableSwitchEmit() to handle table-based switch statements
12475 2002-04-05 Ravi Pratap <ravi@ximian.com>
12477 * expression.cs (Invocation.OverloadResolve): Factor out code which
12478 does parameter compatibility checking with arguments so that we can
12479 re-use the code even from Delegate.VerifyApplicability
12481 (VerifyArgumentsCompat): Move above code here.
12483 * delegate.cs (VerifyApplicability): Get rid of duplicate code
12484 and instead make a call to the above method.
12486 2002-03-31 Ravi Pratap <ravi@ximian.com>
12488 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
12489 We use it to keep track of classes which are attribute types.
12491 2002-04-02 Miguel de Icaza <miguel@ximian.com>
12493 * delegate.cs (Delegate.Define): Correctly define the types in the
12494 presence of fixed and array parameters.
12496 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
12499 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
12500 include NonPublic after the first iteration.
12502 * class.cs (Indexer.CheckBase): Only check if both parents are
12505 * cs-parser.jay (accessor_body): If empty, set to null.
12507 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
12508 same code path here to resolve constants names that we did have in
12509 MemberAccess.DoResolve. There is too much code duplicated here.
12511 2002-04-01 Miguel de Icaza <miguel@ximian.com>
12513 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
12515 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
12518 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
12519 tokens, numbers and strings.
12521 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
12524 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
12525 asyncronous parameters and the regular parameters.
12527 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
12528 specify the target directory.
12530 * expression.cs: (This.DoResolve): Simplify
12531 (As.Emit): Optimize, do not generate IsInst if the expression is
12532 always of the given type.
12534 (Is.DoResolve): Bug fix, we were reporting both always/never for
12537 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
12538 creating too many unnecessary arrays.
12540 2002-03-31 Miguel de Icaza <miguel@ximian.com>
12542 * class.cs (EmitFieldInitializer): Use Assign expression to assign
12543 fields instead of rolling our own initializer. Takes care of all
12544 implicit conversions, and drops unnecessary static checks/argument.
12546 2002-03-31 Dick Porter <dick@ximian.com>
12548 * driver.cs: use the GetDirectories() return values properly, and
12549 use "/" as path separator.
12551 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12553 * expression.cs (Unary): Optimize - - expr into expr.
12554 (Binary): Optimize a + (-b) into a -b.
12556 * codegen.cs (CodeGen): Made all methods static.
12558 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12562 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12563 TypeBuilder property.
12565 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12568 * tree.cs: Removed the various RecordXXXX, and replaced with a
12569 single RecordDecl. Removed all the accessor methods, and just
12570 left a single access point Type
12572 * enum.cs: Rename DefineEnum to DefineType.
12574 * decl.cs: New abstract method `DefineType' used to unify the
12575 Defines for Enumerations, Interfaces, TypeContainers and
12578 (FindType): Moved LookupInterfaceOrClass here. Moved the
12579 LookupBaseClasses method that used to live in class.cs and
12580 interface.cs here, and renamed to FindType.
12582 * delegate.cs: Implement DefineType. Take advantage of the
12583 refactored pattern for locating the parent builder without taking
12584 the parent_builder argument (which we know does not work if we are
12585 nested, and triggering a toplevel definition).
12587 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12589 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12590 accessibility of a member has changed during override and report
12593 * class.cs (Method.Define, Property.Define): Only complain on
12594 overrides if the method is private, any other accessibility is
12595 fine (and since we just checked the permission is the same, we are
12598 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12599 and elif are processed always. The other pre-processing
12600 directives are only processed if we are "taking" the path
12602 2002-03-29 Martin Baulig <martin@gnome.org>
12604 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12605 current location is not Null.
12607 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12608 a separate method so we can profile it.
12610 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12611 `span.Seconds' are just seconds, but no minutes or hours.
12612 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12614 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12616 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12617 Remove the gratuitous set of Final:
12619 // If an interface implementation, then we can set Final.
12620 if (((flags & MethodAttributes.Abstract) == 0) &&
12621 implementing.DeclaringType.IsInterface)
12622 flags |= MethodAttributes.Final;
12624 I do not know what I was smoking when I used that.
12627 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12628 step into fixing the name resolution issues for delegates and
12629 unifying the toplevel name resolution.
12631 2002-03-28 Martin Baulig <martin@gnome.org>
12633 * class.cs (Method.Emit): If we have a symbol writer, call its
12634 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12635 tell it about the current method.
12637 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12638 writer that we're going to emit the first byte of IL code for a new
12639 statement (a new source line).
12640 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12641 EmitContext.Mark() before emitting any code.
12643 * location.cs (SymbolDocument): Return null when we're Null.
12645 * statement.cs (Statement): Moved the `Location loc' variable here.
12646 (Statement.EmitBoolExpression): If we have a symbol writer, call
12647 ec.Mark() before emitting any code to tell it that we're at the
12648 beginning of a new statement.
12649 (StatementExpression): Added `Location' argument to the constructor.
12650 (Block): Added public readonly variable `StartLocation' and public
12651 variable `EndLocation'. The latter is to be set using SetEndLocation().
12652 (Block): Added constructor which takes a start and end location.
12653 (Block.SetEndLocation): New method. This sets the end location.
12654 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12655 local variables we create.
12656 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12657 each statement and do also mark the begin and end of the block.
12659 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12660 tell it the current lexer.Location, use Location.Null for the end of the
12662 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12663 current block, set its end location using SetEndLocation().
12664 (statement_expression): StatementExpression constructor now takes the
12665 lexer.Location as additional argument.
12666 (for_statement, declare_local_variables): Likewise.
12667 (declare_local_variables): When creating a new implicit block, use the
12668 new Block constructor and pass it the lexer.Location.
12670 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12672 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12673 members also on the parent interfaces recursively.
12675 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12677 * report.cs: Use new formats, since Gonzalo finished the missing
12680 * expression.cs (Binary.ResolveOperator): added missing operator|
12681 operator& and operator^ for bool/bool.
12683 * cs-parser.jay: CheckDef now takes a Location argument that is
12684 used to report errors more precisly (instead of reporting the end
12685 of a definition, we try to track something which is a lot closer
12686 to the source of the problem).
12688 * cs-tokenizer.cs: Track global token use, so we can properly flag
12689 the use of #define/#undef after the first token has been seen.
12691 Also, rename the reportXXXX to Error_DescriptiveName
12693 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12694 TypeContainer, so that Enum and Interface can use this too.
12696 * class.cs (TypeContainer.LookupInterfaceOrClass,
12697 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12698 `builder' argument. Typically this was used to pass the parent
12699 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12702 The problem is that a nested class could trigger the definition of
12703 a toplevel class, and the builder would be obviously wrong in that
12706 So we drop this argument, and we compute dynamically the
12707 TypeBuilder/ModuleBuilder (the correct information was available
12708 to us anyways from DeclSpace.Parent)
12710 * interface.cs (Interface.DefineInterface): Drop builder
12711 parameter cleanup like class.cs
12713 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12716 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12719 (Try.Emit): Propagate the returns value from the statement.
12721 (Return.Emit): Even if we are leavning
12723 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12725 * modifiers.cs: Fix the computation of MethodAttributes flags.
12727 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12729 * driver.cs: allow compilation of files that start with '/'.
12730 Add a default case when checking the argument of --target.
12732 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12734 * interface.cs: Implement the same search algorithm for types in
12735 the interface code.
12737 * delegate.cs: Do not allow multiple definition.
12739 * Recovered ChangeLog that got accidentally amputated
12741 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12743 * rootcontext.cs: Load manually enum to allow core classes to
12744 contain enumerations.
12746 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12747 Update to new static methods in TypeManager.
12749 * typemanager.cs (GetMethod, GetConstructor): Use our
12750 implementation of FindMembers to find the members, since during
12751 corlib compilation, the types are TypeBuilders and GetMethod and
12752 GetConstructor do not work.
12754 Make all methods in TypeManager static.
12756 (InitCodeHelpers): Split the functionality from
12757 the InitCodeTypes function.
12759 * driver.cs: Call InitCodeHelpers after we have populated the
12762 * cs-parser.jay (delegate_declaration): we did not used to compute
12763 the delegate name correctly for void delegates.
12765 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12767 * rootcontext.cs (RootContext): Init the interface_resolve_order
12768 and type_container_resolve_order always.
12770 (ResolveCore, BootstrapCorlib_ResolveClass,
12771 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12772 compiler when compiling with --nostdlib
12774 * class.cs (TypeContainer.DefineType): Check that our parent is
12775 not null. This test is most important when we are bootstraping
12778 * codegen.cs: Split out the symbol writing code.
12780 2002-03-25 Martin Baulig <martin@gnome.org>
12782 * driver.cs (-g): Made -g an alias for --debug.
12784 2002-03-24 Martin Baulig <martin@gnome.org>
12786 * codegen.cs (SymbolWriter): New public variable. Returns the
12787 current symbol writer.
12788 (CodeGen): Added `bool want_debugging_support' argument to the
12789 constructor. If true, tell the ModuleBuild that we want debugging
12790 support and ask it for the ISymbolWriter.
12791 (Save): If we have a symbol writer, call it's Close() method after
12792 saving the assembly.
12794 * driver.c (--debug): New command line argument to create a
12795 debugger information file.
12797 * location.cs (SymbolDocument): New public property. Returns an
12798 ISymbolDocumentWriter object for the current source file or null
12799 if we don't have a symbol writer.
12801 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12803 * driver.cs (LoadAssembly): Correctly return when all the paths
12804 have been tried and not before.
12806 * statement.cs (Switch.Emit): return the actual coverage for this
12807 statement (returns/not-returns)
12809 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12810 switch of the statement if we are the last switch section. That
12811 kills two problems: try/catch problems (we used to emit an empty
12812 nop at the end) and switch statements where all branches would
12815 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12817 * driver.cs: Add default assemblies (the equivalent to the
12818 Microsoft CSC.RSP file)
12820 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12821 also update tokens_seen and set it to false.
12823 * driver.cs: Implement --recurse for Mike.
12825 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12826 correctly splitting out the paths.
12828 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12830 * interface.cs (Interface.PopulateProperty): Instead of using
12831 `parent' as the declaration space for the set parameters, use
12834 * support.cs (InternalParameters): InternalParameters constructor
12835 takes a DeclSpace instead of a TypeContainer.
12837 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12838 types are being initialized, load the address of it before calling
12841 (New): Provide a mechanism to disable the generation of local
12842 value type temporaries when the caller will be providing us with
12843 an address to store it.
12845 (ArrayCreation.EmitDynamicInitializers): Use it.
12847 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12849 * expression.cs (Invocation.EmitArguments): Only probe for array
12850 property if there is more than one argument. Sorry about that.
12852 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12853 empty param arrays.
12855 * class.cs (Method.LabelParameters): Fix incorrect code path that
12856 prevented the `ParamArrayAttribute' from being applied to the
12859 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12861 * support.cs (ReflectionParameters): Correctly compute whether the
12862 last argument is a params array. Fixes the problem with
12865 * typemanager.cs: Make the assemblies array always be non-null
12866 (empty, but non-null)
12868 * tree.cs (RecordDecl): New function that abstracts the recording
12869 of names. This reports error 101, and provides a pointer to the
12870 previous declaration. Fixes a crash in the compiler.
12872 * cs-parser.jay (constructor_declaration): Update to new grammar,
12873 and provide a constructor_body that can be empty.
12875 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12877 * driver.cs: Add support for --resources.
12879 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12880 Make all types for the various array helper methods be integer.
12882 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12883 CheckState to ConvCast.
12885 (ConvCast): Now it takes a `checked' state argument, to avoid
12886 depending on the emit context for the conversion, and just using
12887 the resolve time setting.
12889 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12890 instead of Invocation.EmitArguments. We do not emit the original
12891 arguments, instead we emit those which have been converted to
12892 unsigned int expressions.
12894 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12896 * codegen.cs: ditto.
12898 * expression.cs (LocalVariableReference): Drop the use of the
12899 Store function that depended on the variable index.
12901 * statement.cs (VariableInfo): Drop the `Idx' property from this
12902 class, as this is not taking into account the indexes for
12903 temporaries tat we generate during the execution, getting the
12906 * class.cs: First emit class initializers, then call the parent
12909 * expression.cs (Binary): Fix opcode emision.
12910 (UnaryMutator.EmitCode): Support checked code generation
12912 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12913 matches for events for both the Static and Instance scans,
12914 pointing to the same element. Fix that.
12916 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12918 * rootcontext.cs (ResolveTree): Always set the
12919 interface_resolve_order, because nested interfaces will be calling
12922 * class.cs (GetInterfaceOrClass): Track the same resolution
12923 process used by TypeManager.LookupType. This fixes the nested
12924 type lookups in class declarations (separate path from
12927 (TypeContainer.DefineType): Also define nested interfaces.
12928 (TypeContainer.RegisterOrder): New public function used to
12929 register the order in which child interfaces need to be closed.
12931 Nested interfaces need to be closed after their parents have been
12934 * interface.cs (InterfaceAttr): Put all the logic for computing
12935 the interface attribute here.
12937 (DefineInterface): Register our interface order with the
12938 RootContext or with the TypeContainer depending on the case.
12940 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12942 * cs-parser.jay: rework foreach statement to work with the new
12943 changes to the policy on SimpleNames.
12945 * report.cs: support Stacktrace on warnings as well.
12947 * makefile: drop --unsafe and /unsafe from the compile.
12949 2002-03-13 Ravi Pratap <ravi@ximian.com>
12951 * ecore.cs (StandardConversionExists): Modify to take an Expression
12952 as the first parameter. Ensure we do null -> reference type conversion
12955 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12956 temporary Expression objects.
12958 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12960 * interface.cs: workaround bug in method overloading resolution
12961 (there is already a bugzilla bug for it).
12963 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12965 We could also solve this problem by having a separate path for
12966 performing type lookups, instead of DoResolve, we could have a
12967 ResolveType entry point, and only participating pieces of the
12968 production (simplename, deref, array) would implement this.
12970 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12971 signal SimpleName to only resolve type names and not attempt to
12972 resolve anything else.
12974 * expression.cs (Cast): Set the flag.
12976 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12978 * class.cs: Only report 108 if there is no `new' modifier.
12980 * cs-parser.jay: rework foreach statement to work with the new
12981 changes to the policy on SimpleNames.
12983 * report.cs: support Stacktrace on warnings as well.
12985 * makefile: drop --unsafe and /unsafe from the compile.
12987 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12989 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12990 lookups here, instead of doing that at parse time. This means
12991 that our grammar will not introduce `LocalVariableReferences' as
12992 expressions at this point. That solves the problem of code like
12996 static void Main ()
13000 This is only half the fix. The full fix requires parameters to
13001 also be handled in this way.
13003 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
13004 makes the use more obvious of the DeclSpace. The
13005 ec.TypeContainer.TypeBuilder is now only used to pull the
13006 TypeBuilder for it.
13008 My theory is that I can get rid of the TypeBuilder completely from
13009 the EmitContext, and have typecasts where it is used (from
13010 DeclSpace to where it matters).
13012 The only pending problem is that the code that implements Aliases
13013 is on TypeContainer, and probably should go in DeclSpace.
13015 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
13016 lookups here, instead of doing that at parse time. This means
13017 that our grammar will not introduce `LocalVariableReferences' as
13018 expressions at this point. That solves the problem of code like
13022 static void Main ()
13026 This is only half the fix. The full fix requires parameters to
13027 also be handled in this way.
13029 * class.cs (Property.DefineMethod): When implementing an interface
13030 method, set newslot, when implementing an abstract method, do not
13031 set the flag (before we tried never setting it, or always setting
13032 it, which is the difference).
13033 (Indexer.DefineMethod): same.
13034 (Method.DefineMethod): same.
13036 * ecore.cs: Only set the status used flag if we get back a Field.
13038 * attribute.cs: Temporary hack, so Paolo can keep working.
13040 2002-03-08 Ravi Pratap <ravi@ximian.com>
13042 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
13043 the unmanaged type in the case we have a MarshalAs attribute.
13045 (Resolve): Handle the case when we are parsing the special MarshalAs
13046 attribute [we need to store the unmanaged type to use later]
13048 * typemanager.cs (marshal_as_attr_type): Built in type for the
13049 MarshalAs Attribute.
13051 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
13052 on parameters and accordingly set the marshalling info.
13054 2002-03-09 Miguel de Icaza <miguel@ximian.com>
13056 * class.cs: Optimizing slightly by removing redundant code after
13057 we switched to the `NoTypes' return value.
13058 (Property.DefineMethod): use NoTypes here too.
13060 This fixes the bug I introduced in my last batch of changes.
13062 2002-03-05 Ravi Pratap <ravi@ximian.com>
13064 * tree.cs (RecordEnum): Add. We now keep track of enums too.
13066 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
13067 Enums since those are types too.
13069 * cs-parser.jay (enum_declaration): Record enums as we parse them.
13071 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
13072 thanks to a call during the lookup process.
13074 2002-03-07 Miguel de Icaza <miguel@ximian.com>
13076 * statement.cs (Foreach): Lots of work to accomodate a particular
13077 kind of foreach statement that I had not kept in mind. It is
13078 possible to have foreachs on classes that provide a GetEnumerator
13079 method that return objects that implement the "pattern" for using
13080 a foreach, there is no need to support GetEnumerator
13083 This is needed to compile nant.
13085 * decl.cs: Only report 114 if the member is not `Finalize' and if
13086 the warning level is at least 2.
13088 * class.cs: Moved the compare function from Method to
13091 (MethodSignature.InheritableMemberSignatureCompare): Add new
13092 filter function that is used to extract inheritable methods from a
13095 (Method.Define): Use the new `inheritable_method_signature_filter'
13098 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
13101 2002-03-06 Miguel de Icaza <miguel@ximian.com>
13103 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
13105 * cs-parser.jay: Add opt_semicolon to the interface declaration.
13107 * expression.cs: Pass location information to
13108 ConvertImplicitStandard.
13110 * class.cs: Added debugging code to track return values from
13113 2002-03-05 Miguel de Icaza <miguel@ximian.com>
13115 * expression.cs (Is.DoResolve): If either side of the `is' is an
13116 interface, do not flag the warning.
13118 * ecore.cs (ImplicitReferenceConversion): We need a separate test
13121 * report.cs: Allow for --fatal to be used with --probe.
13123 * typemanager.cs (NoTypes): Move the definition for the empty Type
13126 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
13128 (TypeContainer.DefineProxy): New function used to proxy to parent
13129 implementations when implementing interfaces.
13130 (TypeContainer.ParentImplements): used to lookup if our parent
13131 implements a public function that is required by an interface.
13132 (TypeContainer.VerifyPendingMethods): Hook this up.
13134 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
13135 `modules' and `assemblies' arraylists into arrays. We only grow
13136 these are the very early start up of the program, so this improves
13137 the speedof LookupType (nicely measured).
13139 * expression.cs (MakeByteBlob): Replaced unsafe code with
13140 BitConverter, as suggested by Paolo.
13142 * cfold.cs (ConstantFold.Binary): Special case: perform constant
13143 folding of string concatenation, but if either side is a string,
13144 and the other is not, then return null, and let the runtime use
13145 the concatenation on the string plus the object (using
13146 `Object.ToString').
13148 2002-03-04 Miguel de Icaza <miguel@ximian.com>
13150 Constant Folding has been implemented now.
13152 * expression.cs (Unary.Reduce): Do not throw an exception, catch
13153 the error instead on types that are not supported in one's
13156 * constant.cs (Constant and all children): New set of functions to
13157 perform implict and explicit conversions.
13159 * ecore.cs (EnumConstant): Implement the new functions to perform
13160 conversion by proxying to the child expression.
13162 * codegen.cs: (ConstantCheckState): Constant evaluation has its
13163 own separate setting that can not be turned off from the command
13164 line using --unchecked or --checked and is only controlled using
13165 the checked/unchecked statements and expressions. This setting is
13166 used by the constant folder to flag errors.
13168 * expression.cs (CheckedExpr, UncheckedExpr): Set the
13169 ConstantCheckState as well.
13171 During Resolve, they also have to flag the state, because the
13172 constant folder runs completely in the Resolve phase.
13174 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
13177 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13179 * cfold.cs: New file, this file contains the constant folder.
13181 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
13182 argument to track whether we are using the resulting address to
13183 load or store a value and provide better error messages.
13185 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
13186 new AddressOf arguments.
13188 * statement.cs (Foreach.EmitCollectionForeach): Update
13190 * expression.cs (Argument.Emit): Call AddressOf with proper
13191 arguments to track usage.
13193 (New.DoEmit): Call AddressOf with new arguments.
13195 (Unary.Emit): Adjust AddressOf call.
13197 2002-03-01 Ravi Pratap <ravi@ximian.com>
13199 * cs-parser.jay (member_access): Change the case for pre-defined types
13200 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
13203 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
13206 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
13207 essentially like methods and apply attributes like MethodImplOptions to them too.
13209 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
13212 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
13213 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
13216 * Update code everywhere accordingly.
13218 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
13220 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
13222 2002-02-28 Ravi Pratap <ravi@ximian.com>
13224 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
13225 try performing lookups against those instead of jumping straight into using
13226 the 'using' clauses.
13228 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
13230 (LookupType): Perform lookups in implicit parents too.
13232 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
13233 sequence as RootContext.LookupType.
13235 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
13236 the various cases of namespace lookups into this method.
13238 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13240 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
13241 in positional arguments)
13243 * class.cs (Operator): Update the AllowedModifiers to contain
13246 * cs-parser.jay: Update operator declaration to allow for the
13247 operator body to be empty.
13249 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
13252 2002-02-27 Miguel de Icaza <miguel@ximian.com>
13254 * class.cs (Method.Emit): Label parameters.
13256 * driver.cs: Return 1 or 0 as the program exit code.
13258 2002-02-26 Miguel de Icaza <miguel@ximian.com>
13260 * expression.cs: Special case the `null' object when trying to
13261 auto-compute the type, as anything can be explicitly converted to
13264 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
13265 spotting this Paolo.
13267 (Expression.ImplicitNumericConversion): Perform comparissions of
13268 the type using the underlying type in the case of an enumeration
13269 rather than using the enumeration type for the compare.
13271 Cope with the underlying == type case, which is not possible to
13274 (Expression.ConvertNumericExplicit): Perform comparissions of
13275 the type using the underlying type in the case of an enumeration
13276 rather than using the enumeration type for the compare.
13278 * driver.cs: If the user does not supply an extension, assume .exe
13280 * cs-parser.jay (if_statement): Rewrote so that we can track the
13281 location for the if statement.
13283 * expression.cs (Binary.ConstantFold): Only concat strings when
13284 the operation is "+", not everything ;-)
13286 * statement.cs (Statement.EmitBoolExpression): Take a location
13288 (If, While, Do): Track location.
13290 * expression.cs (Binary.ResolveOperator): In the object + string
13291 case, I was missing a call to ConvertImplicit
13293 2002-02-25 Ravi Pratap <ravi@ximian.com>
13295 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
13296 Location arguments. Ensure we use RootContext.LookupType to do our work
13297 and not try to do a direct Type.GetType and ModuleBuilder.GetType
13299 * interface.cs (PopulateMethod): Handle the type of the parameter being
13302 * expression.cs (Invocation.BetterFunction): Handle the case when we
13303 have a params method with no fixed arguments and a call is made with no
13306 2002-02-25 Miguel de Icaza <miguel@ximian.com>
13308 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
13309 the verbatim-string-literal
13311 * support.cs (InternalParameters.ParameterModifier): handle null
13313 (InternalParameters.ParameterType): ditto.
13315 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
13316 duplicating the name of the variable parameter.
13317 (GetParameterByName): Fix bug where we were not looking up array
13318 paramters if they were the only present (thanks Paolo!).
13319 (GetParameterInfo): We only have an empty set of types if both
13320 fixed and array are set to null.
13321 (GetParameterInfo-idx): Handle FixedParameter == null
13323 * cs-parser.jay: Handle the case where there is no catch
13324 statements (missing null test).
13326 2002-02-22 Miguel de Icaza <miguel@ximian.com>
13328 * driver.cs (MainDriver): Be conservative on our command line
13331 Catch DirectoryNotFoundException when calling GetFiles.
13333 (SplitPathAndPattern): Used to split the input specification into
13334 a path and a pattern that we can feed to Directory.GetFiles.
13336 2002-02-21 Miguel de Icaza <miguel@ximian.com>
13338 * statement.cs (Fixed): Implement the last case of the Fixed
13339 statement (string handling).
13341 * expression.cs (StringPtr): New class used to return a char * to
13342 a string; Used by the Fixed statement.
13344 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
13346 * expression.cs (Binary.ResolveOperator): Remove redundant
13347 MemberLookup pn parent type.
13348 Optimize union call, we do not need a union if the types are the same.
13349 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
13352 Specialize the use of MemberLookup everywhere, instead of using
13353 the default settings.
13355 (StackAlloc): Implement stackalloc keyword.
13357 * cs-parser.jay: Add rule to parse stackalloc.
13359 * driver.cs: Handle /h, /help, /?
13361 * expression.cs (MakeByteBlob): Removed the hacks we had in place
13362 before we supported unsafe code.
13364 * makefile: add --unsafe to the self compilation of mcs.
13366 2002-02-20 Miguel de Icaza <miguel@ximian.com>
13368 * expression.cs (PointerArithmetic): New class that is used to
13369 perform pointer arithmetic.
13370 (Binary.Resolve): Handle pointer arithmetic
13371 Handle pointer comparission.
13372 (ArrayPtr): Utility expression class that is used to take the
13373 address of an array.
13375 (ElementAccess): Implement array access for pointers
13377 * statement.cs (Fixed): Implement fixed statement for arrays, we
13378 are missing one more case before we are done.
13380 * expression.cs (Indirection): Implement EmitAssign and set the
13381 ExprClass to Variable. This allows pointer dereferences to be
13382 treated as variables, and to have values assigned to them.
13384 * ecore.cs (Expression.StoreFromPtr): New utility function to
13385 store values dereferencing.
13387 2002-02-20 Ravi Pratap <ravi@ximian.com>
13389 * expression.cs (Binary.ResolveOperator): Ensure that we are
13390 not trying to operate on a void type - this fixes the reported
13393 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
13394 the parent implementation is sealed.
13396 * ../errors/cs0239.cs : Add.
13398 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
13400 * typemanager.cs (unverifiable_code_type): Corresponds to
13401 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
13402 which have unsafe code in them.
13404 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
13407 2002-02-19 Miguel de Icaza <miguel@ximian.com>
13409 * cs-tokenizer.cs: Add support for @"litreal strings"
13411 Make tokenizer accept pre-processor directives
13412 on any column (remove the old C-like limitation).
13414 * rootcontext.cs (EmitCode): Emit any global attributes.
13415 (AddGlobalAttributes): Used to keep track of assembly attributes.
13417 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
13419 * cs-parser.jay: Add support for global attributes.
13421 2002-02-17 Miguel de Icaza <miguel@ximian.com>
13423 * expression.cs (Indirection): New helper class. Unary will
13424 create Indirection classes to be able to implement the
13425 IMemoryLocation interface on it.
13427 2002-02-16 Miguel de Icaza <miguel@ximian.com>
13429 * cs-parser.jay (fixed_statement): reference the right statement.
13431 * statement.cs (Fixed.Emit): Finish implementing the fixed
13432 statement for the &x case.
13434 2002-02-14 Miguel de Icaza <miguel@ximian.com>
13436 * class.cs (Property.Define, Method.Define): Remove newslot when
13439 * modifiers.cs: My use of NewSlot when `Abstract' was set was
13440 wrong. NewSlot should only be used if the `new' keyword is present.
13442 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
13443 locating our system dir. Sorry about this.
13445 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13447 * driver.cs (GetSystemDir): Compute correctly the location of our
13448 system assemblies. I was using the compiler directory instead of
13449 the library directory.
13451 2002-02-13 Ravi Pratap <ravi@ximian.com>
13453 * expression.cs (BetterFunction): Put back in what Miguel commented out
13454 since it is the correct fix. The problem is elsewhere ;-)
13456 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
13457 parameters of the parms method are themselves compatible or not !
13459 (StandardConversionExists): Fix very dangerous bug where we were forgetting
13460 to check that a class implements an interface before saying that an implicit
13461 conversion was allowed. Use ImplementsInterface to do the checking.
13463 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13465 * class.cs (Method.Define): Track whether we are an explicit
13466 implementation or not. And only call DefineMethodOverride if we
13467 are an explicit implementation.
13469 (Property.DefineMethod): Ditto.
13471 2002-02-11 Ravi Pratap <ravi@ximian.com>
13473 * expression.cs (BetterFunction): Catch hideous bug which was
13474 preventing us from detecting ambiguous calls due to implicit casts i.e
13477 2002-01-29 Miguel de Icaza <miguel@ximian.com>
13479 * support.cs (Pair): Remove un-needed method. I figured why I was
13480 getting the error in cs-parser.jay, the variable in a foreach loop
13481 is readonly, and the compiler does not really treat this as a variable.
13483 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
13484 instead of EQUALS in grammar.
13486 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
13488 * expression.cs (Unary.DoResolve): Check whether the argument is
13491 2002-01-28 Miguel de Icaza <miguel@ximian.com>
13493 * support.cs: Api for Pair to set a value. Despite the fact that
13494 the variables are public the MS C# compiler refuses to compile
13495 code that accesses the field if the variable is part of a foreach
13498 * statement.cs (Fixed): Begin implementation of the fixed
13501 (Block.AddVariable): Return the VariableInfo on success and null
13502 on failure instead of true/false.
13504 * cs-parser.jay (foreach): Catch errors on variables already
13505 defined (we were ignoring this value before) and properly unwind
13506 the block hierarchy
13508 (fixed_statement): grammar for the fixed statement.
13510 2002-01-25 Miguel de Icaza <miguel@ximian.com>
13512 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
13513 pointer types to be incretemented.
13515 (SizeOf): Implement.
13517 * cs-parser.jay (pointer_member_access): Implement
13518 expr->IDENTIFIER production.
13520 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
13521 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
13524 (Unary): Implement indirection.
13526 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
13527 use in non-unsafe context).
13529 (SimpleName.DoResolve): Check for pointers in field access on safe
13532 (Expression.LoadFromPtr): Factor the load-indirect code in this
13533 function. This was duplicated in UnboxCast and ParameterReference
13535 2002-01-24 Miguel de Icaza <miguel@ximian.com>
13537 * expression.cs (ComposedCast): report an error if a pointer cast
13538 is used in a safe region.
13540 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
13541 pointer type casts in unsafe context.
13543 * codegen.cs (EmitContext): Set up IsUnsafe.
13545 * cs-parser.jay (non_expression_type): Add productions for pointer
13548 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13549 code. We should not use force into static mode if the method is
13550 not virtual. Fixes bug in MIS
13552 * statement.cs (Do.Emit, While.Emit, For.Emit,
13553 Statement.EmitBoolExpression): Add support to Do and While to
13554 propagate infinite loop as `I do return' semantics.
13556 Improve the For case to also test for boolean constants.
13558 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13559 to the list of attributes we can add.
13561 Remove `EmitContext' argument.
13563 * class.cs (Method.Define): Apply parameter attributes.
13564 (Constructor.Define): Apply parameter attributes.
13565 (MethodCore.LabelParameters): Move here the core of labeling
13568 * support.cs (ReflectionParameters.ParameterModifier,
13569 InternalParameters.ParameterModifier): Use IsByRef on the type and
13570 only return the OUT bit for these parameters instead of in/out/ref
13573 This is because I miss-understood things. The ParameterInfo.IsIn
13574 and IsOut represent whether the parameter has the [In] and [Out]
13577 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13579 * ecore.cs (FieldExpr.Emit): Release temporaries.
13581 * assign.cs (LocalTemporary.Release): new function.
13583 * codegen.cs (EmitContext.GetTemporaryStorage,
13584 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13585 temporary storage. Now we can "put back" localbuilders when we
13588 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13590 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13591 need to make a copy of the variable to generate verifiable code.
13593 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13595 * driver.cs: Compute dynamically the system directory.
13597 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13598 Slower, but more generally useful. Used by the abstract
13599 registering implementation.
13601 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13602 the rules for the special rule on Type/instances. First check if
13603 we have the same name, and if so, try that special static path
13604 rather than the instance path.
13606 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13608 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13611 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13612 Enum, ValueType, Delegate or Array for non-corlib compiles.
13614 * cs-tokenizer.cs: Catch long identifiers (645)
13616 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13619 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13620 fix, we were returning too early, so we were not registering
13621 pending methods from abstract classes.
13623 Do not register pending methods if the class is abstract.
13625 * expression.cs (Conditional.DoResolve): Report circular implicit
13626 conversions when we neecd to compute it for conditional
13629 (Is.DoResolve): If the expression is always of the provided type,
13630 flag warning 183. If the expression can not ever be of the
13631 provided type flag warning 184.
13633 * class.cs: Catch 169 as well.
13635 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13638 2002-01-18 Nick Drochak <ndrochak@gol.com>
13640 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13642 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13644 * interface.cs: (PopulateMethod): Check for pointers being defined
13645 only if the unsafe context is active.
13646 (PopulateProperty): ditto.
13647 (PopulateIndexer): ditto.
13649 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13650 specified. If pointers are present, make sure that they are
13651 present in an unsafe context.
13652 (Constructor, Constructor.Define): ditto.
13653 (Field, Field.Define): ditto.
13654 (Property, Property.Define): ditto.
13655 (Event, Event.Define): ditto.
13657 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13658 hashtable if there are classes or structs defined.
13660 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13661 code, as the constant resolution moved.
13663 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13664 the metadata, so we can flag error 133.
13666 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13667 pointer is being declared in an unsafe context.
13669 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13671 * modifiers.cs (Modifiers.Check): Require a Location argument.
13672 Report error 227 for Unsafe use.
13674 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13676 * statement.cs (For.Emit): If the test is null, then report that
13677 we do `return', as we wont reach anything afterwards.
13679 (Switch.SwitchGoverningType): Track the expression that matched
13682 * driver.cs: Allow negative numbers as an error code to flag.
13684 * cs-parser.jay: Handle 1551.
13686 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13688 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13690 * cs-parser.jay: Report 1518 (type declaration can only contain
13691 class, struct, interface, enum or delegate)
13693 (switch_label): Report 1523 (keywords `case' or `default' must
13696 (opt_switch_sections): Report 1522 (empty switch)
13698 * driver.cs: Report 1515 (response file specified multiple times)
13699 Report 1516 (Source file specified multiple times).
13701 * expression.cs (Argument.Resolve): Signal 1510
13703 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13704 access not allowed in static code)
13706 2002-01-11 Ravi Pratap <ravi@ximian.com>
13708 * typemanager.cs (IsPointerType): Utility method which we are going
13711 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13712 the object type, so we take care of that.
13714 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13716 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13717 added to non-params parameters :-)
13719 * typemanager.cs (CSharpName): Include 'void' type too.
13721 (void_ptr_type): Include in the set of core types.
13723 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13726 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13729 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13730 completely forgotten about it.
13732 2002-01-10 Ravi Pratap <ravi@ximian.com>
13734 * cs-parser.jay (pointer_type): Add. This begins our implementation
13735 of parsing rules for unsafe code.
13737 (unsafe_statement): Implement.
13739 (embedded_statement): Modify to include the above.
13741 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13743 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13744 if the current context is an unsafe one.
13746 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13747 are handled differently, we need separate rules for them.
13749 (local_variable_declaration): Update to use local_variable_pointer_type
13750 to allow variable declarations of unmanaged pointer types.
13752 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13753 in unsafe contexts.
13755 * ../errors/cs0214.cs : Add.
13757 2002-01-16 Nick Drochak <ndrochak@gol.com>
13759 * makefile: remove 'response' file when cleaning.
13761 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13763 * cs-parser.jay: Report 1524.
13765 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13767 * typemanager.cs (RegisterMethod): drop checking if we have
13768 registered this from here
13770 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13772 * class.cs (Method.EmitDestructor): Implement calling our base
13775 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13776 value of InFinally.
13778 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13779 this routine and will wrap the call in a try/catch block. Deal
13782 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13784 * ecore.cs (Expression.MemberLookup): instead of taking a
13785 parameter `same_type' that was used to tell whether we could
13786 access private members we compute our containing type from the
13789 (FieldExpr): Added partial support for volatile fields. This does
13790 not work for volatile fields exposed from assemblies, as I can not
13791 figure out how to extract the modreq from it.
13793 Updated all the source files to use this.
13795 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13796 because it is referenced by MemberLookup very often.
13798 2002-01-09 Ravi Pratap <ravi@ximian.com>
13800 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13801 TypeBuilder.GetCustomAttributes to retrieve what we need.
13803 Get rid of redundant default_member_attr_type as this is the same as
13804 default_member_type which already exists.
13806 * interface.cs, attribute.cs : Update accordingly.
13808 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13810 * typemanager.cs: Enable IndexerPropertyName again. It does not
13811 work for TYpeBuilders though. Ravi, can you please fix this?
13813 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13815 * expression.cs (Argument.Emit): Handle the case of ref objects
13816 being passed to ref functions;
13818 (ParameterReference.EmitLoad): Loads the content of the pointer
13819 without dereferencing.
13821 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13823 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13825 2002-01-08 Ravi Pratap <ravi@ximian.com>
13827 * class.cs (Indexer.DefineMethod): Incorporate the interface
13828 type in the name of the method if we are doing explicit interface
13831 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13833 (BetterConversion): Fix extremely trivial bug where we were referring to
13834 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13837 * ../errors/bug16.cs : Add although we have fixed it.
13839 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13841 * expression.cs (BaseIndexer): Begin implementation.
13843 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13845 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13846 production directly to remove a shift/reduce, and implement
13847 explicit interface implementation.
13849 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13850 after a floating point suffix.
13852 * expression.cs (DoNumericPromotions): Improved the conversion for
13853 uint/uint. If we have a constant, we avoid doing a typecast to a
13856 * class.cs (Indexer): Implement explicit interface implementation
13859 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13861 * class.cs: make the default instance constructor public and hidebysig.
13863 2001-01-03 Ravi Pratap <ravi@ximian.com>
13865 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13866 so we can call it from elsewhere.
13868 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13869 we emit it internally if the class has a defined indexer; otherwise the user
13870 emits it by decorating the class definition with the DefaultMemberAttribute.
13872 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13873 attribute is not used on a type which defines an indexer.
13875 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13876 character when we skip whitespace.
13878 * ../errors/cs0646.cs : Add.
13880 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13882 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13885 * makefile: Add practical target `mcs3.exe' which builds the third
13886 generation compiler.
13888 * expression.cs (New): Fix structures constructor calling.
13890 * class.cs (Property, Method, Indexer): Emit Final flag on the
13891 method if we are an interface implementation and we are not
13894 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13895 whether this property is referencing a `base' method.
13897 * expression.cs (Invocation.EmitCall): take an extra argument:
13898 is_base, this is used to determine whether the `call' or
13899 `callvirt' opcode should be used.
13902 * delegate.cs: update EmitCall.
13904 * class.cs (Method.Define): Set NewSlot for the cases where we are
13905 not implementing an interface method.
13907 (Property.Define): ditto.
13909 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13911 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13912 'r'. Allows mcs to parse itself fully.
13914 2002-01-02 Ravi Pratap <ravi@ximian.com>
13916 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13917 of the number of initializers that require the InitializeArray method.
13919 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13920 update the above field where necessary.
13922 (MakeByteBlob): Update accordingly.
13924 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13927 (EmitDynamicInitializers): Update in accordance with the new optimization.
13929 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13930 same OpCode applies.
13932 * cs-parser.jay : Fix some glaring errors I introduced.
13934 2002-01-01 Ravi Pratap <ravi@ximian.com>
13936 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13937 so that we can check for name clashes there too.
13939 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13940 for interface indexers.
13942 * interfaces.cs (Define): Emit the default member attribute.
13944 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13945 variable was being referred to while setting the value ;-)
13947 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13949 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13950 byte-by-byte information when we know the data is zero.
13952 Make the block always a multiple of 4, because
13953 DefineInitializedData has a bug.
13955 * assign.cs: Fix, we should assign from the temporary, not from
13958 * expression.cs (MakeByteBlob): Fix my incorrect code.
13960 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13962 * typemanager.cs (EnumToUnderlying): This function is used to get
13963 the underlying type from an enumeration, because it does not
13966 * constant.cs: Use the I4_S form for values between -128 and 127.
13968 * statement.cs (Block.LookupLabel): Looks up a label.
13969 (Block): Drop support for labeled blocks.
13971 (LabeledStatement): New kind of statement that represents a label
13974 (Goto): Finally implement this bad boy.
13976 * cs-parser.jay: Update to reflect new mechanism to implement
13979 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13981 * codegen.cs (EmitContext.This): a codegen property that keeps the
13982 a single instance of this instead of creating many different this
13985 * delegate.cs (Delegate.DoResolve): Update to use the property;
13987 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13989 * expression.cs (BaseAccess.DoResolve): Ditto.
13991 2001-12-29 Ravi Pratap <ravi@ximian.com>
13993 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13994 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13996 (InitCoreTypes): Update accordingly.
13998 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13999 so we can quickly store the state.
14001 (ApplyAttributes): Set the correct implementation flags
14002 for InternalCall methods.
14004 2001-12-29 Miguel de Icaza <miguel@ximian.com>
14006 * expression.cs (EmitCall): if a method is not virtual, then do
14007 not use callvirt on it.
14009 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
14010 user defined stuff) requires the use of stobj, which takes an
14011 address on the stack instead of an array and an index. So emit
14012 the Ldelema operation for it.
14014 (EmitStoreOpcode): Use stobj for valuetypes.
14016 (UnaryMutator.EmitCode): Use the right 1 value depending on
14017 whether we are dealing with int64/uint64, float or doubles.
14019 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
14020 constructors that I implemented last night.
14022 (Constructor.IsDefault): Fix to work properly for static
14025 * cs-parser.jay (CheckDef): report method signature errors.
14026 Update error number 103 to be 132.
14028 * decl.cs: New AdditionResult enumeration value: MethodExists.
14029 Although we do this check for methods later on in the semantic
14030 analysis, catching repeated default constructors is so easy that
14031 we catch these here.
14033 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
14036 (ParameterReference.EmitAssign, Emit): handle
14039 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
14040 (ArrayAccess.EmitStoreOpcode): ditto.
14042 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
14044 * expression.cs (MakeByteBlob): Complete all the missing types
14045 (uint, short, ushort, byte, sbyte)
14047 * class.cs: Only init instance field initializers on instance
14050 Rename `constructors' to instance_constructors.
14052 (TypeContainer.AddConstructor): Only add constructors to the list
14053 if it is not static.
14055 Make sure that we handle default_static_constructor independently
14056 everywhere where we handle instance_constructors
14058 2001-12-28 Miguel de Icaza <miguel@ximian.com>
14060 * class.cs: Do not lookup or create a base initializer for a
14061 static constructor.
14063 (ConstructorInitializer.Resolve): use the proper type to lookup
14066 * cs-parser.jay: Report error 1585 (modifiers between type and name).
14068 * enum.cs, interface.cs: Remove CloseType, this is taken care by
14071 * decl.cs: CloseType is now an virtual method, the default
14072 implementation just closes this type.
14074 2001-12-28 Ravi Pratap <ravi@ximian.com>
14076 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
14077 to PreserveSig by default. Also emit HideBySig on such methods.
14079 Basically, set the defaults to standard values.
14081 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
14082 argument, if candidate is better, it can't be worse than the best !
14084 (Invocation): Re-write bits to differentiate between methods being
14085 applicable in their expanded form and their normal form - for params
14088 Get rid of use_standard everywhere as only standard conversions are allowed
14089 in overload resolution.
14091 More spec conformance.
14093 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14095 * driver.cs: Add --timestamp, to see where the compiler spends
14098 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
14099 `this' in static code.
14101 (SimpleName.DoResolve): Implement in terms of a helper function
14102 that allows static-references to be passed upstream to
14105 (Expression.ResolveWithSimpleName): Resolve specially simple
14106 names when called by MemberAccess to implement the special
14109 (Expression.ImplicitReferenceConversion): Handle conversions from
14110 Null to reference types before others, as Null's type is
14113 * expression.cs (Invocation.EmitCall): Handle the special case of
14114 calling methods declared on a reference type from a ValueType
14115 (Base classes System.Object and System.Enum)
14117 (MemberAccess.Resolve): Only perform lookups on Enumerations if
14118 the left hand side is a TypeExpr, not on every enumeration.
14120 (Binary.Resolve): If types are reference types, then do a cast to
14121 object on operators != and == of both arguments.
14123 * typemanager.cs (FindMembers): Extract instance and static
14124 members if requested.
14126 * interface.cs (PopulateProperty): Use void_type instead of null
14127 as the return type for the setter method.
14129 (PopulateIndexer): ditto.
14131 2001-12-27 Ravi Pratap <ravi@ximian.com>
14133 * support.cs (ReflectionParameters): Fix minor bug where we
14134 were examining the wrong parameter for the ParamArray attribute.
14136 Cope with requests for the type of the parameter at position
14137 greater than the params parameter's. We now return the element
14138 type of the params array as that makes more sense.
14140 * expression.cs (Invocation.IsParamsMethodApplicable): Update
14141 accordingly as we no longer have to extract the element type
14144 (Invocation.OverloadResolve): Update.
14146 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14148 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
14149 against IEnumerator, test whether the return value is a descendant
14150 of the IEnumerator interface.
14152 * class.cs (Indexer.Define): Use an auxiliary method to implement
14153 the other bits of the method definition. Begin support for
14154 explicit interface implementation.
14156 (Property.DefineMethod): Use TypeManager.void_type instead of null
14157 for an empty return value.
14159 2001-12-26 Miguel de Icaza <miguel@ximian.com>
14161 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
14162 dealing with a FieldExpr which is composed of a FieldBuilder, in
14163 the code path we did extract the constant, but we should have
14164 obtained the underlying value to be able to cast it (otherwise we
14165 end up in an infinite loop, this is what Ravi was running into).
14167 (ArrayCreation.UpdateIndices): Arrays might be empty.
14169 (MemberAccess.ResolveMemberAccess): Add support for section
14170 14.5.4.1 that deals with the special case of E.I when E is a type
14171 and something else, that I can be a reference to a static member.
14173 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
14174 handle a particular array type to create byte blobs, it is just
14175 something we dont generate byteblobs for.
14177 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
14180 * location.cs (Push): remove the key from the hashtable that we
14181 are about to add. This happens for empty files.
14183 * driver.cs: Dispose files after we have parsed them.
14185 (tokenize): new function that only runs the tokenizer on its
14186 input, for speed testing.
14188 2001-12-26 Ravi Pratap <ravi@ximian.com>
14190 * class.cs (Event.Define): Define the private field only if there
14191 are no accessors defined.
14193 * expression.cs (ResolveMemberAccess): If there is no associated
14194 field with the event, that means we have an event defined with its
14195 own accessors and we should flag error cs0070 since transforming
14196 ourselves into a field is not valid in that case.
14198 * ecore.cs (SimpleName.DoResolve): Same as above.
14200 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
14201 and charset to sane values.
14203 2001-12-25 Ravi Pratap <ravi@ximian.com>
14205 * assign.cs (DoResolve): Perform check on events only if they
14206 are being accessed outside the declaring type.
14208 * cs-parser.jay (event_declarations): Update rules to correctly
14209 set the type of the implicit parameter etc.
14211 (add_accessor, remove_accessor): Set current local parameters.
14213 * expression.cs (Binary): For delegate addition and subtraction,
14214 cast the return value from the method into the appropriate delegate
14217 2001-12-24 Ravi Pratap <ravi@ximian.com>
14219 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
14220 of these as the workaround is unnecessary.
14222 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
14223 delegate data - none of that is needed at all.
14225 Re-write bits to extract the instance expression and the delegate method
14228 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
14231 * attribute.cs (ApplyAttributes): New method to take care of common tasks
14232 of attaching attributes instead of duplicating code everywhere.
14234 * everywhere : Update code to do attribute emission using the above method.
14236 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14238 * expression.cs (IsParamsMethodApplicable): if there are not
14239 parameters, return immediately.
14241 * ecore.cs: The 0 literal can be implicity converted to an enum
14244 (SimpleName.DoResolve): First lookup the type, then lookup the
14247 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
14248 want to get its address. If the InstanceExpression is not
14249 addressable, store the result in a temporary variable, then get
14252 * codegen.cs: Only display 219 errors on warning level or above.
14254 * expression.cs (ArrayAccess): Make it implement the
14255 IMemoryLocation interface.
14257 (Binary.DoResolve): handle the operator == (object a, object b)
14258 and operator != (object a, object b) without incurring into a
14259 BoxedCast (because 5 != o should never be performed).
14261 Handle binary enumerator operators.
14263 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
14264 value type, otherwise use Ldelem_ref.
14266 Use precomputed names;
14268 (AddressOf): Implement address of
14270 * cs-parser.jay (labeled_statement): Fix recursive block
14271 addition by reworking the production.
14273 * expression.cs (New.DoEmit): New has a special case:
14275 If we are dealing with a ValueType, we have a few
14276 situations to deal with:
14278 * The target of New is a ValueType variable, that is
14279 easy, we just pass this as the variable reference
14281 * The target of New is being passed as an argument,
14282 to a boxing operation or a function that takes a
14285 In this case, we need to create a temporary variable
14286 that is the argument of New.
14289 2001-12-23 Ravi Pratap <ravi@ximian.com>
14291 * rootcontext.cs (LookupType): Check that current_type is not null before
14292 going about looking at nested types.
14294 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
14295 not implement the IAssignMethod interface any more.
14297 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
14298 where we tranform them into FieldExprs if they are being resolved from within
14299 the declaring type.
14301 * ecore.cs (SimpleName.DoResolve): Do the same here.
14303 * assign.cs (DoResolve, Emit): Clean up code considerably.
14305 * ../errors/bug10.cs : Add.
14307 * ../errors/cs0070.cs : Add.
14309 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
14311 * assign.cs : Get rid of EventIsLocal everywhere.
14313 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14315 * ecore.cs (ConvertIntLiteral): finished the implementation.
14317 * statement.cs (SwitchLabel): Convert the value we are using as a
14318 key before looking up the table.
14320 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14322 * codegen.cs (EmitTopBlock): Require a Location argument now.
14324 * cs-parser.jay (constructor_declarator): We need to setup
14325 current_local_parameters before we parse the
14326 opt_constructor_initializer, to allow the variables to be bound
14327 to the constructor arguments.
14329 * rootcontext.cs (LookupType): First lookup nested classes in our
14330 class and our parents before we go looking outside our class.
14332 * expression.cs (ConstantFold): Extract/debox the values at the
14335 * rootcontext.cs (EmitCode): Resolve the constants first before we
14336 resolve the types. This is not really needed, but it helps debugging.
14338 * statement.cs: report location.
14340 * cs-parser.jay: pass location to throw statement.
14342 * driver.cs: Small bug fix.
14344 * report.cs: Updated format to be 4-zero filled digits.
14346 2001-12-22 Ravi Pratap <ravi@ximian.com>
14348 * expression.cs (CheckIndices): Fix minor bug where the wrong
14349 variable was being referred to ;-)
14351 (DoEmit): Do not call EmitStaticInitializers when the
14352 underlying type is System.Object.
14354 2001-12-21 Ravi Pratap <ravi@ximian.com>
14356 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
14357 and do the usual workaround for SRE.
14359 * class.cs (MyEventBuilder.EventType): New member to get at the type
14360 of the event, quickly.
14362 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
14364 * assign.cs (Assign.DoResolve): Handle the case when the target
14365 is an EventExpr and perform the necessary checks.
14367 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
14370 (SimpleName.MemberStaticCheck): Include check for EventExpr.
14372 (EventExpr): Set the type in the constructor itself since we
14373 are meant to be born fully resolved.
14375 (EventExpr.Define): Revert code I wrote earlier.
14377 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
14378 instance expression is null. The instance expression is a This in that case
14379 or a null, depending on whether it is a static method or not.
14381 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
14382 refers to more than one method.
14384 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
14385 and accordingly flag errors.
14387 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14389 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
14391 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14393 * location.cs (ToString): Provide useful rutine.
14395 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14397 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
14398 objects, return the actual integral boxed.
14400 * statement.cs (SwitchLabel): define an ILLabel for each
14403 (Switch.CheckSwitch): If the value is a Literal, extract
14404 the underlying literal.
14406 Also in the unused hashtable we had, add the SwitchLabel so we can
14407 quickly look this value up.
14409 * constant.cs: Implement a bunch of new constants. Rewrite
14410 Literal based on this. Made changes everywhere to adapt to this.
14412 * expression.cs (Expression.MakeByteBlob): Optimize routine by
14413 dereferencing array only once, and also copes with enumrations.
14415 bytes are two bytes wide, not one.
14417 (Cast): Perform constant conversions.
14419 * ecore.cs (TryImplicitIntConversion): Return literals instead of
14420 wrappers to the literals here.
14422 * expression.cs (DoNumericPromotions): long literals can converted
14423 to ulong implicity (this is taken care of elsewhere, but I was
14424 missing this spot).
14426 * ecore.cs (Expression.Literalize): Make the return type Literal,
14427 to improve type checking.
14429 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
14431 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14433 * literal.cs: Revert code from ravi that checked the bounds. The
14434 bounds are sane by the definition of the type itself.
14436 * typemanager.cs: Fix implementation of ImplementsInterface. We
14437 need to actually look up in our parent hierarchy for interfaces
14440 * const.cs: Use the underlying type for enumerations
14442 * delegate.cs: Compute the basename for the delegate creation,
14443 that should fix the delegate test case, and restore the correct
14444 Type Lookup semantics in rootcontext
14446 * rootcontext.cs: Revert Ravi's last patch. The correct way of
14447 referencing a nested type with the Reflection API is using the "+"
14450 * cs-parser.jay: Do not require EOF token at the end.
14452 2001-12-20 Ravi Pratap <ravi@ximian.com>
14454 * rootcontext.cs (LookupType): Concatenate type names with
14455 a '.' instead of a '+' The test suite passes again.
14457 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
14458 field of the enumeration.
14460 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
14461 the case when the member is an EventExpr.
14463 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
14464 static has an associated instance expression.
14466 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
14468 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
14470 * class.cs (Event.Define): Register event and perform appropriate checks
14473 We define the Add and Remove methods even if the use provides none because
14474 in that case, we provide default implementations ourselves.
14476 Define a private field of the type of the event. This is done by the CSC compiler
14477 and we should be doing it too ;-)
14479 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
14480 More methods we use in code we generate.
14482 (multicast_delegate_type, delegate_type): Two separate types since the distinction
14485 (InitCoreTypes): Update accordingly for the above.
14487 * class.cs (Event.Emit): Generate code for default accessors that we provide
14489 (EmitDefaultMethod): Do the job in the above.
14491 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
14494 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14496 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
14497 builders even if we were missing one.
14499 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
14500 pass the Basename as our class name instead of the Name. The
14501 basename will be correctly composed for us.
14503 * parameter.cs (Paramters): Now takes a Location argument.
14505 * decl.cs (DeclSpace.LookupType): Removed convenience function and
14506 make all the code call directly LookupType in RootContext and take
14507 this chance to pass the Location information everywhere.
14509 * Everywhere: pass Location information.
14511 2001-12-19 Miguel de Icaza <miguel@ximian.com>
14513 * class.cs (Constructor.Define): Updated way of detecting the
14514 length of the parameters.
14516 (TypeContainer.DefineType): Use basename as the type name for
14519 (TypeContainer.Define): Do not recursively define types here, as
14520 definition is taken care in order by the RootContext.
14522 * tree.cs: Keep track of namespaces in a per-file basis.
14524 * parameter.cs (Parameter.ComputeSignature): Update to use
14527 (Parameters.GetSignature): ditto.
14529 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
14530 instead of a TypeContainer.
14532 (Interface.SemanticAnalysis): Use `this' instead of our parent to
14533 resolve names. Because we need to be resolve in our context, not
14536 * driver.cs: Implement response files.
14538 * class.cs (TypeContainer.DefineType): If we are defined, do not
14539 redefine ourselves.
14541 (Event.Emit): Emit the code for add/remove handlers.
14542 (Event.Define): Save the MethodBuilders for add/remove.
14544 * typemanager.cs: Use pair here too.
14546 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14547 DictionaryEntry requires the first argument to be non-null.
14549 (enum_declaration): Compute full name for registering the
14552 (delegate_declaration): Instead of using
14553 formal_parameter_list, use opt_formal_parameter_list as the list
14556 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14557 (EventParsing): New property that controls whether `add' and
14558 `remove' are returned as tokens or identifiers (for events);
14560 2001-12-19 Ravi Pratap <ravi@ximian.com>
14562 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14563 use MyEventBuilder only and let it wrap the real builder for us.
14565 (MyEventBuilder): Revamp constructor etc.
14567 Implement all operations that we perform on EventBuilder in precisely the same
14570 (FindMembers): Update to use the EventBuilder member.
14572 (Event.Emit): Update accordingly.
14574 2001-12-18 Ravi Pratap <ravi@ximian.com>
14576 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14577 by calling the appropriate methods.
14579 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14582 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14584 2001-12-17 Ravi Pratap <ravi@ximian.com>
14586 * delegate.cs (Delegate.Populate): Check that the return type
14587 and various parameters types are indeed accessible.
14589 * class.cs (Constructor.Define): Same here.
14591 (Field.Define): Ditto.
14593 (Event.Define): Ditto.
14595 (Operator.Define): Check that the underlying Method defined itself
14596 correctly - so it's MethodBuilder should not be null.
14598 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14599 expression happens to be null.
14601 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14602 members but as of now we don't seem to be able to do anything really useful with it.
14604 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14605 not the EventBuilder.
14607 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14609 * cs-tokenizer.cs: Add support for defines.
14610 Add support for #if, #elif, #else, #endif
14612 (eval_var): evaluates a variable.
14613 (eval): stubbed for evaluating functions.
14615 * cs-parser.jay: Pass the defines information
14617 * driver.cs: Add --define command line option.
14619 * decl.cs: Move MemberCore here.
14621 Make it the base class for DeclSpace. This allows us to catch and
14622 report 108 and 109 for everything now.
14624 * class.cs (TypeContainer.Define): Extract all the members
14625 before populating and emit the warning 108 (new keyword required
14626 to override) instead of having each member implement this.
14628 (MemberCore.Define): New abstract method, we will be using this in
14629 the warning reporting engine in Populate.
14631 (Operator.Define): Adjust to new MemberCore protocol.
14633 * const.cs (Const): This does not derive from Expression, it is a
14634 temporary object we use to create fields, it is a MemberCore.
14636 * class.cs (Method.Define): Allow the entry point to be in a
14639 * driver.cs: Rewrite the argument handler to clean it up a bit.
14641 * rootcontext.cs: Made it just an auxiliary namespace feature by
14642 making everything static.
14644 * driver.cs: Adapt code to use RootContext type name instead of
14647 * delegate.cs: Remove RootContext argument.
14649 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14652 * class.cs (Event.Define): The lookup can fail.
14654 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14656 * expression.cs: Resolve the this instance before invoking the code.
14658 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14660 * cs-parser.jay: Add a production in element_access that allows
14661 the thing to become a "type" reference. This way we can parse
14662 things like "(string [])" as a type.
14664 Note that this still does not handle the more complex rules of
14668 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14670 * ecore.cs: (CopyNewMethods): new utility function used to
14671 assemble the list of methods from running FindMembers.
14673 (MemberLookup): Rework FindMembers so that
14675 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14677 * class.cs (TypeContainer): Remove Delegates who fail to be
14680 * delegate.cs (Populate): Verify that we dont get null return
14681 values. TODO: Check for AsAccessible.
14683 * cs-parser.jay: Use basename to emit error 574 (destructor should
14684 have the same name as container class), not the full name.
14686 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14687 possible representation.
14689 Also implements integer type suffixes U and L.
14691 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14693 * expression.cs (ArrayCreation.DoResolve): We need to do the
14694 argument resolution *always*.
14696 * decl.cs: Make this hold the namespace. Hold the root context as
14698 (LookupType): Move here.
14700 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14702 * location.cs (Row, Name): Fixed the code, it was always returning
14703 references to the first file.
14705 * interface.cs: Register properties defined through interfaces.
14707 * driver.cs: Add support for globbing on the command line
14709 * class.cs (Field): Make it derive from MemberCore as well.
14712 2001-12-15 Ravi Pratap <ravi@ximian.com>
14714 * class.cs (Event::Define): Check that the type of the event is a delegate
14715 type else flag error #66.
14717 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14720 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14721 values of EntryPoint, CharSet etc etc.
14723 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14725 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14726 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14727 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14728 which needs this to do its work.
14730 * ../errors/cs0066.cs : Add.
14732 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14734 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14737 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14738 clears out the parameters field.
14739 (MemberSignatureCompare): Cleanup
14741 (MemberCore): New base class used to share code between MethodCore
14744 (RegisterRequiredImplementations) BindingFlags.Public requires
14745 either BindingFlags.Instace or Static. Use instance here.
14747 (Property): Refactored code to cope better with the full spec.
14749 * parameter.cs (GetParameterInfo): Return an empty array instead
14752 * class.cs (Property): Abstract or extern properties have no bodies.
14754 * parameter.cs (GetParameterInfo): return a zero-sized array.
14756 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14757 method modifier validation to the typecontainer so we can reuse
14758 this on properties.
14760 (MethodCore.ParameterTypes): return an empty sized array of types.
14762 (Property.Define): Test property modifier validity.
14764 Add tests for sealed/override too.
14766 (Method.Emit): abstract or extern methods have no bodies.
14768 2001-12-14 Ravi Pratap <ravi@ximian.com>
14770 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14773 (Method::Define, ::Emit): Modify accordingly.
14775 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14777 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14779 * makefile: Pass in /unsafe.
14781 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14783 * class.cs (MakeKey): Kill routine.
14785 * class.cs (TypeContainer.Define): Correctly define explicit
14786 method implementations (they require the full interface name plus
14789 * typemanager.cs: Deply the PtrHashtable here and stop using the
14790 lame keys. Things work so much better.
14792 This of course broke everyone who depended on `RegisterMethod' to
14793 do the `test for existance' test. This has to be done elsewhere.
14795 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14796 the object stupid Equals method (because, that like fails all over
14797 the place). We still do not use it.
14799 * class.cs (TypeContainer.SetRequiredInterface,
14800 TypeContainer.RequireMethods): Killed these two routines and moved
14801 all the functionality to RegisterRequiredImplementations.
14803 (TypeContainer.RegisterRequiredImplementations): This routine now
14804 registers all the implementations required in an array for the
14805 interfaces and abstract methods. We use an array of structures
14806 which can be computed ahead of time to reduce memory usage and we
14807 also assume that lookups are cheap as most classes will not
14808 implement too many interfaces.
14810 We also avoid creating too many MethodSignatures.
14812 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14813 clear the "pending" bit if we find that there are problems with
14816 (TypeContainer.VerifyPendingMethods): Update to report errors of
14817 methods that look like implementations but are not.
14819 (TypeContainer.Define): Add support for explicit interface method
14822 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14824 * typemanager.cs: Keep track of the parameters here instead of
14825 being a feature of the TypeContainer.
14827 * class.cs: Drop the registration of parameters here, as
14828 InterfaceMethods are also interface declarations.
14830 * delegate.cs: Register methods with the TypeManager not only with
14831 the TypeContainer. This code was buggy.
14833 * interface.cs: Full registation here.
14835 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14837 * expression.cs: Remove reducer for binary expressions, it can not
14840 * const.cs: Put here the code that used to go into constant.cs
14842 * constant.cs: Put here the code for constants, this is a new base
14843 class for Literals.
14845 * literal.cs: Make Literal derive from Constant.
14847 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14849 * statement.cs (Return.Emit): Report error 157 if the user
14850 attempts to return from a finally block.
14852 (Return.Emit): Instead of emitting a return, jump to the end of
14855 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14856 LocalBuilder to store the result of the function. ReturnLabel is
14857 the target where we jump.
14860 2001-12-09 Radek Doulik <rodo@ximian.com>
14862 * cs-parser.jay: remember alias in current namespace
14864 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14867 * class.cs (LookupAlias): lookup alias in my_namespace
14869 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14871 (LookupAlias): lookup alias in this and if needed in parent
14874 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14878 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14879 making things static. I need this to avoid passing the
14880 TypeContainer when calling ParameterType.
14882 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14883 that did string manipulation to compute the type and then call
14884 GetType. Use Parameter.ParameterType instead.
14886 * cs-tokenizer.cs: Consume the suffix for floating values.
14888 * expression.cs (ParameterReference): figure out whether this is a
14889 reference parameter or not. Kill an extra variable by computing
14890 the arg_idx during emission.
14892 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14893 function that returns whether a parameter is an out/ref value or not.
14895 (Parameter.ParameterType): The type of the parameter (base,
14896 without ref/out applied).
14898 (Parameter.Resolve): Perform resolution here.
14899 (Parameter.ExternalType): The full type (with ref/out applied).
14901 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14902 support for expressions on the using statement.
14904 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14906 * statement.cs (Using.EmitLocalVariableDecls): Split the
14907 localvariable handling of the using statement.
14909 (Block.EmitMeta): Keep track of variable count across blocks. We
14910 were reusing slots on separate branches of blocks.
14912 (Try.Emit): Emit the general code block, we were not emitting it.
14914 Check the type of the declaration to be an IDisposable or
14915 something that can be implicity converted to it.
14917 Emit conversions if required.
14919 * ecore.cs (EmptyExpression): New utility class.
14920 (Expression.ImplicitConversionExists): New utility function.
14922 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14924 * statement.cs (Using): Implement.
14926 * expression.cs (LocalVariableReference): Support read only variables.
14928 * statement.cs: Remove the explicit emit for the Leave opcode.
14929 (VariableInfo): Add a readonly field.
14931 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14933 * ecore.cs (ConvCast): new class used to encapsulate the various
14934 explicit integer conversions that works in both checked and
14935 unchecked contexts.
14937 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14938 properly generate the overflow opcodes.
14940 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14942 * statement.cs: The correct type for the EmptyExpression is the
14943 element_type, not the variable type. Ravi pointed this out.
14945 2001-12-04 Ravi Pratap <ravi@ximian.com>
14947 * class.cs (Method::Define): Handle PInvoke methods specially
14948 by using DefinePInvokeMethod instead of the usual one.
14950 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14951 above to do the task of extracting information and defining the method.
14953 2001-12-04 Ravi Pratap <ravi@ximian.com>
14955 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14956 of the condition for string type.
14958 (Emit): Move that here.
14960 (ArrayCreation::CheckIndices): Keep string literals in their expression
14963 (EmitDynamicInitializers): Handle strings appropriately.
14965 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14967 * codegen.cs (EmitContext): Replace multiple variables with a
14968 single pointer to the current Switch statement.
14970 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14973 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14977 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14980 (Foreach.Emit): Foreach on arrays was not setting
14981 up the loop variables (for break/continue).
14983 (GotoCase): Semi-implented.
14985 2001-12-03 Ravi Pratap <ravi@ximian.com>
14987 * attribute.cs (CheckAttribute): Handle system attributes by using
14988 Attribute.GetAttributes to examine information we need.
14990 (GetValidPlaces): Same here.
14992 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14994 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14996 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14998 (Method::Define): Set appropriate flags if we have a DllImport attribute.
15000 (Method::Emit): Handle the case when we are a PInvoke method.
15002 2001-12-03 Miguel de Icaza <miguel@ximian.com>
15004 * expression.cs: Use ResolveWithSimpleName on compound names.
15006 2001-12-02 Ravi Pratap <ravi@ximian.com>
15008 * constant.cs (EmitConstant): Make sure we resolve the associated expression
15009 before trying to reduce it.
15011 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
15013 * constant.cs (LookupConstantValue): Implement.
15015 (EmitConstant): Use the above in emitting the constant.
15017 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
15018 that are user-defined by doing a LookupConstantValue on them.
15020 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
15023 2001-11-29 Miguel de Icaza <miguel@ximian.com>
15025 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
15027 (BaseAccess.DoResolve): Implement.
15029 (MemberAccess.DoResolve): Split this routine into a
15030 ResolveMemberAccess routine that can be used independently
15032 2001-11-28 Miguel de Icaza <miguel@ximian.com>
15034 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
15035 As that share bits of the implementation. Is returns a boolean,
15036 while As returns the Type that is being probed.
15038 2001-12-01 Ravi Pratap <ravi@ximian.com>
15040 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
15041 instead of a Literal - much easier.
15043 (EnumInTransit): Remove - utterly useless :-)
15045 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
15047 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
15049 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
15050 chain when we have no associated expression.
15052 2001-11-30 Ravi Pratap <ravi@ximian.com>
15054 * constant.cs (Define): Use Location while reporting the errror.
15056 Also emit a warning when 'new' is used and there is no inherited
15059 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
15062 (LookupEnumValue): Implement to lookup an enum member's value and define it
15065 (Populate): Re-write accordingly to use the above routine.
15067 2001-11-27 Miguel de Icaza <miguel@ximian.com>
15069 * expression.cs (This): Fix prototype for DoResolveLValue to
15070 override the base class DoResolveLValue.
15072 * cs-parser.cs: Report errors cs574 and cs575 (destructor
15075 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
15076 (we need to load the address of the field here). This fixes
15079 (FieldExpr.DoResolveLValue): Call the DoResolve
15080 function to initialize the Instance expression.
15082 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
15083 correctly the GetEnumerator operation on a value type.
15085 * cs-parser.jay: Add more simple parsing error catches.
15087 * statement.cs (Switch): Add support for string switches.
15088 Handle null specially.
15090 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
15092 2001-11-28 Ravi Pratap <ravi@ximian.com>
15094 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
15096 (declare_local_constant): New helper function.
15098 * statement.cs (AddConstant): Keep a separate record of constants
15100 (IsConstant): Implement to determine if a variable is a constant.
15102 (GetConstantExpression): Implement.
15104 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
15106 * statement.cs (IsVariableDefined): Re-write.
15108 2001-11-27 Ravi Pratap <ravi@ximian.com>
15110 * class.cs (TypeContainer::FindMembers): Look for constants
15111 in the case when we are looking for MemberTypes.Field
15113 * expression.cs (MemberAccess::DoResolve): Check that in the
15114 case we are a FieldExpr and a Literal, we are not being accessed
15115 by an instance reference.
15117 * cs-parser.jay (local_constant_declaration): Implement.
15119 (declaration_statement): Implement for constant declarations.
15121 2001-11-26 Miguel de Icaza <miguel@ximian.com>
15123 * statement.cs (Switch): Catch double defaults.
15125 (Switch): More work on the switch() statement
15126 implementation. It works for integral values now, need to finish
15130 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15132 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
15133 integer literals into other integer literals. To be used by
15136 2001-11-24 Ravi Pratap <ravi@ximian.com>
15138 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
15141 (EmitDynamicInitializers): Cope with the above since we extract data
15142 directly from ArrayData now.
15144 (ExpectInitializers): Keep track of whether initializers are mandatory
15147 (Bounds): Make it a hashtable to prevent the same dimension being
15148 recorded for every element in that dimension.
15150 (EmitDynamicInitializers): Fix bug which prevented the Set array method
15153 Also fix bug which was causing the indices to be emitted in the reverse
15156 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15158 * expression.cs (ArrayCreation): Implement the bits that Ravi left
15159 unfinished. They do not work, because the underlying code is
15162 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15164 * cs-parser.jay: Remove bogus fixme.
15166 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
15167 on Switch statement.
15169 2001-11-23 Ravi Pratap <ravi@ximian.com>
15171 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
15174 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
15175 parameter. Apparently, any expression is allowed.
15177 (ValidateInitializers): Update accordingly.
15179 (CheckIndices): Fix some tricky bugs thanks to recursion.
15181 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
15182 I was being completely brain-dead.
15184 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
15185 and re-write acordingly.
15187 (DelegateInvocation): Re-write accordingly.
15189 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
15191 (MakeByteBlob): Handle types more correctly.
15193 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
15194 initialization from expressions but it is incomplete because I am a complete
15197 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15199 * statement.cs (If.Emit): Fix a bug that generated incorrect code
15200 on If. Basically, we have to return `true' (ie, we do return to
15201 our caller) only if both branches of the if return.
15203 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
15204 short-circuit operators, handle them as short circuit operators.
15206 (Cast.DoResolve): Resolve type.
15207 (Cast.Cast): Take an expression as the target type.
15209 * cs-parser.jay (cast_expression): Remove old hack that only
15210 allowed a limited set of types to be handled. Now we take a
15211 unary_expression and we resolve to a type during semantic
15214 Use the grammar productions from Rhys to handle casts (this is
15215 not complete like Rhys syntax yet, we fail to handle that corner
15216 case that C# has regarding (-x), but we will get there.
15218 2001-11-22 Ravi Pratap <ravi@ximian.com>
15220 * class.cs (EmitFieldInitializer): Take care of the case when we have a
15221 field which is an array type.
15223 * cs-parser.jay (declare_local_variables): Support array initialization too.
15225 * typemanager.cs (MakeKey): Implement.
15227 (everywhere): Use the above appropriately.
15229 * cs-parser.jay (for_statement): Update for array initialization while
15230 declaring variables.
15232 * ecore.cs : The error message was correct, it's the variable's names that
15233 were misleading ;-) Make the code more readable.
15235 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
15236 the correct type etc.
15238 (ConvertExplicit): Handle Enum types by examining the underlying type.
15240 2001-11-21 Ravi Pratap <ravi@ximian.com>
15242 * parameter.cs (GetCallingConvention): Always return
15243 CallingConventions.Standard for now.
15245 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15247 * expression.cs (Binary.ResolveOperator): Update the values of `l'
15248 and `r' after calling DoNumericPromotions.
15250 * ecore.cs: Fix error message (the types were in the wrong order).
15252 * statement.cs (Foreach.ProbeCollectionType): Need to pass
15253 BindingFlags.Instance as well
15255 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
15256 implicit int literal conversion in an empty cast so that we
15257 propagate the right type upstream.
15259 (UnboxCast): new class used to unbox value types.
15260 (Expression.ConvertExplicit): Add explicit type conversions done
15263 (Expression.ImplicitNumericConversion): Oops, forgot to test for
15264 the target type before applying the implicit LongLiterals to ULong
15267 2001-11-21 Miguel de Icaza <miguel@ximian.com>
15269 * cs-parser.jay (for_statement): Reworked the way For works: now
15270 we declare manually any variables that are introduced in
15271 for_initializer to solve the problem of having out-of-band code
15272 emition (that is what got for broken).
15274 (declaration_statement): Perform the actual variable declaration
15275 that used to be done in local_variable_declaration here.
15277 (local_variable_declaration): Do not declare anything, just pass
15278 the information on a DictionaryEntry
15280 2001-11-20 Ravi Pratap <ravi@ximian.com>
15282 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
15283 re-write of the logic to now make it recursive.
15285 (UpdateIndices): Re-write accordingly.
15287 Store element data in a separate ArrayData list in the above methods.
15289 (MakeByteBlob): Implement to dump the array data into a byte array.
15291 2001-11-19 Ravi Pratap <ravi@ximian.com>
15293 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
15296 * constant.cs (Define): Implement.
15298 (EmitConstant): Re-write fully.
15300 Pass in location info.
15302 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
15305 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
15306 DictionaryEntry since we need location info too.
15308 (constant_declaration): Update accordingly.
15310 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
15311 code into another method : UpdateIndices.
15313 2001-11-18 Ravi Pratap <ravi@ximian.com>
15315 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
15316 some type checking etc.
15318 2001-11-17 Ravi Pratap <ravi@ximian.com>
15320 * expression.cs (ArrayCreation::ValidateInitializers): Implement
15321 bits to provide dimension info if the user skips doing that.
15323 Update second constructor to store the rank correctly.
15325 2001-11-16 Ravi Pratap <ravi@ximian.com>
15327 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
15328 and try to implement.
15330 * ../errors/cs0150.cs : Add.
15332 * ../errors/cs0178.cs : Add.
15334 2001-11-16 Miguel de Icaza <miguel@ximian.com>
15336 * statement.cs: Implement foreach on multi-dimensional arrays.
15338 * parameter.cs (Parameters.GetParameterByName): Also lookup the
15339 name of the params argument.
15341 * expression.cs: Use EmitStoreOpcode to get the right opcode while
15342 initializing the array.
15344 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
15345 we can use this elsewhere.
15347 * statement.cs: Finish implementation of foreach for single
15350 * cs-parser.jay: Use an out-of-band stack to pass information
15351 around, I wonder why I need this.
15353 foreach_block: Make the new foreach_block the current_block.
15355 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
15356 function used to return a static Parameters structure. Used for
15357 empty parameters, as those are created very frequently.
15359 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
15361 2001-11-15 Ravi Pratap <ravi@ximian.com>
15363 * interface.cs : Default modifier is private, not public. The
15364 make verify test passes again.
15366 2001-11-15 Ravi Pratap <ravi@ximian.com>
15368 * support.cs (ReflectionParameters): Fix logic to determine
15369 whether the last parameter is a params one. Test 9 passes again.
15371 * delegate.cs (Populate): Register the builders we define with
15372 RegisterParameterForBuilder. Test 19 passes again.
15374 * cs-parser.jay (property_declaration): Reference $6 instead
15375 of $$ to get at the location.
15377 (indexer_declaration): Similar stuff.
15379 (attribute): Ditto.
15381 * class.cs (Property): Register parameters for the Get and Set methods
15382 if they exist. Test 23 passes again.
15384 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
15385 call to EmitArguments as we are sure there aren't any params arguments.
15386 Test 32 passes again.
15388 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
15389 IndexOutOfRangeException.
15391 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
15392 Test 33 now passes again.
15394 2001-11-15 Miguel de Icaza <miguel@ximian.com>
15396 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
15397 broke a bunch of things. Will have to come up with a better way
15398 of tracking locations.
15400 * statement.cs: Implemented foreach for single dimension arrays.
15402 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15404 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
15405 an error. This removes the lookup from the critical path.
15407 * cs-parser.jay: Removed use of temporary_loc, which is completely
15410 2001-11-14 Miguel de Icaza <miguel@ximian.com>
15412 * support.cs (ReflectionParameters.ParameterModifier): Report
15413 whether the argument is a PARAMS argument or not.
15415 * class.cs: Set the attribute `ParamArrayAttribute' on the
15416 parameter argument.
15418 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
15419 and cons_param_array_attribute (ConstructorInfo for
15420 ParamArrayAttribute).,
15422 * codegen.cs: Emit the return using the `Return' statement, that
15423 way we can report the error correctly for missing return values.
15425 * class.cs (Method.Emit): Clean up.
15427 * expression.cs (Argument.Resolve): Take another argument: the
15428 location where this argument is used. Notice that this is not
15429 part of the "Argument" class as to reduce the size of the
15430 structure (we know the approximate location anyways).
15432 Test if the argument is a variable-reference, if not, then
15433 complain with a 206.
15435 (Argument.Emit): Emit addresses of variables.
15437 (Argument.FullDesc): Simplify.
15439 (Invocation.DoResolve): Update for Argument.Resolve.
15441 (ElementAccess.DoResolve): ditto.
15443 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
15444 method should be virtual, as this method is always virtual.
15446 (NewDelegate.DoResolve): Update for Argument.Resolve.
15448 * class.cs (ConstructorInitializer.DoResolve): ditto.
15450 * attribute.cs (Attribute.Resolve): ditto.
15452 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15454 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
15456 * expression.cs (ParameterReference): Drop IStackStorage and implement
15457 IAssignMethod instead.
15459 (LocalVariableReference): ditto.
15461 * ecore.cs (FieldExpr): Drop IStackStorage and implement
15462 IAssignMethod instead.
15464 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15466 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
15467 enumerations that are used in heavily used structures derive from
15468 byte in a laughable and pathetic attempt to reduce memory usage.
15469 This is the kind of pre-optimzations that you should not do at
15470 home without adult supervision.
15472 * expression.cs (UnaryMutator): New class, used to handle ++ and
15473 -- separatedly from the other unary operators. Cleans up the
15474 code, and kills the ExpressionStatement dependency in Unary.
15476 (Unary): Removed `method' and `Arguments' from this class, making
15477 it smaller, and moving it all to SimpleCall, so I can reuse this
15478 code in other locations and avoid creating a lot of transient data
15479 strucutres when not required.
15481 * cs-parser.jay: Adjust for new changes.
15483 2001-11-11 Miguel de Icaza <miguel@ximian.com>
15485 * enum.cs (Enum.Populate): If there is a failure during
15488 * cs-parser.jay (opt_enum_base): we used to catch type errors
15489 here, but this is really incorrect. The type error should be
15490 catched during semantic analysis.
15492 2001-12-11 Ravi Pratap <ravi@ximian.com>
15494 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
15495 current_local_parameters as expected since I, in my stupidity, had forgotten
15498 * attribute.cs (GetValidPlaces): Fix stupid bug.
15500 * class.cs (Method::Emit): Perform check on applicability of attributes.
15502 (Constructor::Emit): Ditto.
15504 (Field::Emit): Ditto.
15506 (Field.Location): Store location information.
15508 (Property, Event, Indexer, Operator): Ditto.
15510 * cs-parser.jay (field_declaration): Pass in location for each field.
15512 * ../errors/cs0592.cs : Add.
15514 2001-11-12 Ravi Pratap <ravi@ximian.com>
15516 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
15518 (InitCoreTypes): Update accordingly.
15520 (RegisterAttrType, LookupAttr): Implement.
15522 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
15523 info about the same.
15525 (Resolve): Update to populate the above as necessary.
15527 (Error592): Helper.
15529 (GetValidPlaces): Helper to the above.
15531 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
15533 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
15535 2001-11-12 Ravi Pratap <ravi@ximian.com>
15537 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
15539 * ../errors/cs0617.cs : Add.
15541 2001-11-11 Ravi Pratap <ravi@ximian.com>
15543 * enum.cs (Emit): Rename to Populate to be more consistent with what
15544 we expect it to do and when exactly it is called.
15546 * class.cs, rootcontext.cs : Update accordingly.
15548 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15549 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15551 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15553 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15554 of a fieldinfo using the above, when dealing with a FieldBuilder.
15556 2001-11-10 Ravi Pratap <ravi@ximian.com>
15558 * ../errors/cs0031.cs : Add.
15560 * ../errors/cs1008.cs : Add.
15562 * ../errrors/cs0543.cs : Add.
15564 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15567 (FindMembers): Implement.
15569 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15570 enums and delegates too.
15572 (enum_types): Rename to builder_to_enum.
15574 (delegate_types): Rename to builder_to_delegate.
15576 * delegate.cs (FindMembers): Implement.
15578 2001-11-09 Ravi Pratap <ravi@ximian.com>
15580 * typemanager.cs (IsEnumType): Implement.
15582 * enum.cs (Emit): Re-write parts to account for the underlying type
15583 better and perform checking etc.
15585 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15586 of the underlying type.
15588 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15591 * enum.cs (error31): Helper to report error #31.
15593 * cs-parser.jay (enum_declaration): Store location of each member too.
15595 * enum.cs (member_to_location): New hashtable.
15597 (AddEnumMember): Update location hashtable.
15599 (Emit): Use the location of each member while reporting errors.
15601 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15603 * cs-parser.jay: A for_initializer if is a
15604 local_variable_declaration really ammount to have an implicit
15605 block with the variable declaration and no initializer for for.
15607 * statement.cs (For.Emit): Cope with null initializers.
15609 This fixes the infinite loop on for initializers.
15611 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15613 * enum.cs: More cleanup.
15615 * ecore.cs: Remove dead code.
15617 * class.cs (Property.Emit): More simplification.
15618 (Event.Emit): ditto.
15620 Reworked to have less levels of indentation.
15622 2001-11-08 Ravi Pratap <ravi@ximian.com>
15624 * class.cs (Property): Emit attributes.
15634 * enum.cs (Emit): Ditto.
15636 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15639 * class.cs (Field, Event, etc.): Move attribute generation into the
15640 Emit method everywhere.
15642 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15643 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15644 as we had no way of defining nested enums !
15646 * rootcontext.cs : Adjust code accordingly.
15648 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15650 2001-11-07 Ravi Pratap <ravi@ximian.com>
15652 * expression.cs (EvalConstantExpression): Move into ecore.cs
15654 * enum.cs (Enum): Rename some members and make them public and readonly
15655 according to our convention.
15657 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15660 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15662 (Enum::Emit): Write a simple version for now which doesn't try to compute
15663 expressions. I shall modify this to be more robust in just a while.
15665 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15667 (TypeContainer::CloseType): Create the Enum types too.
15669 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15671 * expression.cs (EvalConstantExpression): Get rid of completely.
15673 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15674 user-defined values and other cases.
15676 (IsValidEnumLiteral): Helper function.
15678 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15679 out there in the case we had a literal FieldExpr.
15681 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15683 (Literalize): Revamp a bit to take two arguments.
15685 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15687 2001-11-06 Ravi Pratap <ravi@ximian.com>
15689 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15691 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15693 (Resolve): Use the above to ensure we have proper initializers.
15695 2001-11-05 Ravi Pratap <ravi@ximian.com>
15697 * expression.cs (Expression::EvalConstantExpression): New method to
15698 evaluate constant expressions.
15700 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15702 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15704 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15707 (Binary.ResolveOperator): Handle operator != (object a, object b)
15708 and operator == (object a, object b);
15710 (Binary.DoNumericPromotions): Indicate whether the numeric
15711 promotion was possible.
15713 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15716 Made the ArrayAccess implement interface IAssignMethod instead of
15717 IStackStore as the order in which arguments are passed reflects
15720 * assign.cs: Instead of using expr.ExprClass to select the way of
15721 assinging, probe for the IStackStore/IAssignMethod interfaces.
15723 * typemanager.cs: Load InitializeArray definition.
15725 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15726 static data that can be used to initialize arrays.
15728 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15730 * expression.cs: Handle operator== and operator!= for booleans.
15732 (Conditioal.Reduce): Implement reducer for the ?: operator.
15734 (Conditional.Resolve): Implement dead code elimination.
15736 (Binary.Resolve): Catch string literals and return a new
15737 concatenated string.
15739 (Unary.Reduce): Implement reduction of unary expressions.
15741 * ecore.cs: Split out the expression core handling here.
15743 (Expression.Reduce): New method used to perform constant folding
15744 and CSE. This is needed to support constant-expressions.
15746 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15747 targets, and optimize for !x.
15749 2001-11-04 Ravi Pratap <ravi@ximian.com>
15751 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15752 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15753 set custom atttributes.
15755 * literal.cs (Literal::GetValue): New abstract method to return the actual
15756 value of the literal, cast as an object.
15758 (*Literal): Implement GetValue method.
15760 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15761 expressions to the arraylist but objects of type Argument.
15763 * class.cs (TypeContainer::Emit): Emit our attributes too.
15765 (Method::Emit, Constructor::Emit): Ditto.
15767 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15768 to be ignoring earlier.
15770 2001-11-03 Ravi Pratap <ravi@ximian.com>
15772 * attribute.cs (AttributeSection::Define): Implement to do the business
15773 of constructing a CustomAttributeBuilder.
15775 (Attribute): New trivial class. Increases readability of code.
15777 * cs-parser.jay : Update accordingly.
15779 (positional_argument_list, named_argument_list, named_argument): New rules
15781 (attribute_arguments): Use the above so that we are more correct.
15783 2001-11-02 Ravi Pratap <ravi@ximian.com>
15785 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15786 to perform all checks for a method with a params parameter.
15788 (Invocation::OverloadResolve): Update to use the above method and therefore
15789 cope correctly with params method invocations.
15791 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15794 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15795 constructors in our parent too because we can't afford to miss out on
15798 * attribute.cs (AttributeSection): New name for the class Attribute
15800 Other trivial changes to improve readability.
15802 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15803 use the new class names.
15805 2001-11-01 Ravi Pratap <ravi@ximian.com>
15807 * class.cs (Method::Define): Complete definition for params types too
15809 (Indexer::Define): Ditto.
15811 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15812 Cope everywhere with a request for info about the array parameter.
15814 2001-11-01 Ravi Pratap <ravi@ximian.com>
15816 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15818 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15819 local_variable_type to extract the string corresponding to the type.
15821 (local_variable_type): Fixup the action to use the new helper method.
15823 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15826 * expression.cs : Clean out code which uses the above.
15828 2001-10-31 Ravi Pratap <ravi@ximian.com>
15830 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15831 and bale out if necessary by returning a false.
15833 (RegisterProperty): Ditto.
15835 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15836 and print out appropriate error messages.
15838 * interface.cs (everywhere): Ditto.
15840 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15841 location to constructor.
15843 * class.cs (Property, Event, Indexer): Update accordingly.
15845 * ../errors/cs111.cs : Added.
15847 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15848 of a method, as laid down by the spec.
15850 (Invocation::OverloadResolve): Use the above method.
15852 2001-10-31 Ravi Pratap <ravi@ximian.com>
15854 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15855 now take a TypeContainer and a Parameters object.
15857 (ParameterData): Modify return type of ParameterModifier method to be
15858 Parameter.Modifier and not a string.
15860 (ReflectionParameters, InternalParameters): Update accordingly.
15862 * expression.cs (Argument::GetParameterModifier): Same here.
15864 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15865 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15866 symbol in it at all so maybe this is only for now.
15868 2001-10-30 Ravi Pratap <ravi@ximian.com>
15870 * support.cs (InternalParameters): Constructor now takes an extra argument
15871 which is the actual Parameters class.
15873 (ParameterDesc): Update to provide info on ref/out modifiers.
15875 * class.cs (everywhere): Update call to InternalParameters to pass in
15876 the second argument too.
15878 * support.cs (ParameterData): Add ParameterModifier, which is a method
15879 to return the modifier info [ref/out etc]
15881 (InternalParameters, ReflectionParameters): Implement the above.
15883 * expression.cs (Argument::ParameterModifier): Similar function to return
15884 info about the argument's modifiers.
15886 (Invocation::OverloadResolve): Update to take into account matching modifiers
15889 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15890 a new SetFormalParameters object which we pass to InternalParameters.
15892 2001-10-30 Ravi Pratap <ravi@ximian.com>
15894 * expression.cs (NewArray): Merge into the ArrayCreation class.
15896 2001-10-29 Ravi Pratap <ravi@ximian.com>
15898 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15899 NewUserdefinedArray into one as there wasn't much of a use in having
15902 * expression.cs (Argument): Change field's name to ArgType from Type.
15904 (Type): New readonly property which returns the proper type, taking into
15905 account ref/out modifiers.
15907 (everywhere): Adjust code accordingly for the above.
15909 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15910 whether we are emitting for a ref or out parameter.
15912 * expression.cs (Argument::Emit): Use the above field to set the state.
15914 (LocalVariableReference::Emit): Update to honour the flag and emit the
15917 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15919 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15921 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15923 (ReflectionParameters, InternalParameters): Implement the above method.
15925 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15928 (Invocation::FullMethodDesc): Ditto.
15930 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15932 * cs-parser.jay: Add extra production for the second form of array
15935 * expression.cs (ArrayCreation): Update to reflect the above
15938 * Small changes to prepare for Array initialization.
15940 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15942 * typemanager.cs (ImplementsInterface): interface might be null;
15943 Deal with this problem;
15945 Also, we do store negative hits on the cache (null values), so use
15946 this instead of calling t.GetInterfaces on the type everytime.
15948 2001-10-28 Ravi Pratap <ravi@ximian.com>
15950 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15952 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15953 split functionality out into different classes.
15955 (New::FormArrayType): Move into NewBuiltinArray.
15957 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15960 (NewBuiltinArray): New class to handle creation of built-in arrays.
15962 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15963 account creation of one-dimensional arrays.
15965 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15967 (NewUserdefinedArray::DoResolve): Implement.
15969 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15971 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15972 we maintain inside the TypeManager. This is necessary to perform lookups on the
15975 (LookupType): Update to perform GetType on the module builders too.
15977 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15979 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15981 2001-10-23 Ravi Pratap <ravi@ximian.com>
15983 * expression.cs (New::DoResolve): Implement guts of array creation.
15985 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15987 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15989 * expression.cs: Fix bug I introduced lsat night that broke
15992 (Expression.Resolve): Report a 246 error (can not resolve name)
15993 if we find a SimpleName in the stream.
15995 (Expression.ResolveLValue): Ditto.
15997 (Expression.ResolveWithSimpleName): This function is a variant of
15998 ResolveName, this one allows SimpleNames to be returned without a
15999 warning. The only consumer of SimpleNames is MemberAccess
16001 2001-10-26 Miguel de Icaza <miguel@ximian.com>
16003 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
16004 might arrive here. I have my doubts that this is correct.
16006 * statement.cs (Lock): Implement lock statement.
16008 * cs-parser.jay: Small fixes to support `lock' and `using'
16010 * cs-tokenizer.cs: Remove extra space
16012 * driver.cs: New flag --checked, allows to turn on integer math
16015 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
16016 Threading.Monitor.Exit
16018 2001-10-23 Miguel de Icaza <miguel@ximian.com>
16020 * expression.cs (IndexerAccess::DoResolveLValue): Set the
16021 Expression Class to be IndexerAccess.
16023 Notice that Indexer::DoResolve sets the eclass to Value.
16025 2001-10-22 Miguel de Icaza <miguel@ximian.com>
16027 * class.cs (TypeContainer::Emit): Emit code for indexers.
16029 * assign.cs (IAssignMethod): New interface implemented by Indexers
16030 and Properties for handling assignment.
16032 (Assign::Emit): Simplify and reuse code.
16034 * expression.cs (IndexerAccess, PropertyExpr): Implement
16035 IAssignMethod, clean up old code.
16037 2001-10-22 Ravi Pratap <ravi@ximian.com>
16039 * typemanager.cs (ImplementsInterface): New method to determine if a type
16040 implements a given interface. Provides a nice cache too.
16042 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
16045 (ConvertReferenceExplicit): Ditto.
16047 * delegate.cs (Delegate::Populate): Update to define the parameters on the
16048 various methods, with correct names etc.
16050 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
16051 Operator.UnaryNegation.
16053 * cs-parser.jay (operator_declarator): Be a little clever in the case where
16054 we have a unary plus or minus operator.
16056 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
16059 * everywhere : update accordingly.
16061 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
16064 * class.cs (Method::Define): For the case where we are implementing a method
16065 inherited from an interface, we need to set the MethodAttributes.Final flag too.
16066 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
16068 2001-10-21 Ravi Pratap <ravi@ximian.com>
16070 * interface.cs (FindMembers): Implement to work around S.R.E
16073 * typemanager.cs (IsInterfaceType): Implement.
16075 (FindMembers): Update to handle interface types too.
16077 * expression.cs (ImplicitReferenceConversion): Re-write bits which
16078 use IsAssignableFrom as that is not correct - it doesn't work.
16080 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
16081 and accordingly override EmitStatement.
16083 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
16084 using the correct logic :-)
16086 2001-10-19 Ravi Pratap <ravi@ximian.com>
16088 * ../errors/cs-11.cs : Add to demonstrate error -11
16090 2001-10-17 Miguel de Icaza <miguel@ximian.com>
16092 * assign.cs (Assign::Resolve): Resolve right hand side first, and
16093 then pass this as a hint to ResolveLValue.
16095 * expression.cs (FieldExpr): Add Location information
16097 (FieldExpr::LValueResolve): Report assignment to readonly
16100 (Expression::ExprClassFromMemberInfo): Pass location information.
16102 (Expression::ResolveLValue): Add new method that resolves an
16105 (Expression::DoResolveLValue): Default invocation calls
16108 (Indexers): New class used to keep track of indexers in a given
16111 (IStackStore): Renamed from LValue, as it did not really describe
16112 what this did. Also ResolveLValue is gone from this interface and
16113 now is part of Expression.
16115 (ElementAccess): Depending on the element access type
16117 * typemanager.cs: Add `indexer_name_type' as a Core type
16118 (System.Runtime.CompilerServices.IndexerNameAttribute)
16120 * statement.cs (Goto): Take a location.
16122 2001-10-18 Ravi Pratap <ravi@ximian.com>
16124 * delegate.cs (Delegate::VerifyDelegate): New method to verify
16125 if two delegates are compatible.
16127 (NewDelegate::DoResolve): Update to take care of the case when
16128 we instantiate a delegate from another delegate.
16130 * typemanager.cs (FindMembers): Don't even try to look up members
16131 of Delegate types for now.
16133 2001-10-18 Ravi Pratap <ravi@ximian.com>
16135 * delegate.cs (NewDelegate): New class to take care of delegate
16138 * expression.cs (New): Split the delegate related code out into
16139 the NewDelegate class.
16141 * delegate.cs (DelegateInvocation): New class to handle delegate
16144 * expression.cs (Invocation): Split out delegate related code into
16145 the DelegateInvocation class.
16147 2001-10-17 Ravi Pratap <ravi@ximian.com>
16149 * expression.cs (New::DoResolve): Implement delegate creation fully
16150 and according to the spec.
16152 (New::DoEmit): Update to handle delegates differently.
16154 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
16155 because of which we were printing out arguments in reverse order !
16157 * delegate.cs (VerifyMethod): Implement to check if the given method
16158 matches the delegate.
16160 (FullDelegateDesc): Implement.
16162 (VerifyApplicability): Implement.
16164 * expression.cs (Invocation::DoResolve): Update to accordingly handle
16165 delegate invocations too.
16167 (Invocation::Emit): Ditto.
16169 * ../errors/cs1593.cs : Added.
16171 * ../errors/cs1594.cs : Added.
16173 * delegate.cs (InstanceExpression, TargetMethod): New properties.
16175 2001-10-16 Ravi Pratap <ravi@ximian.com>
16177 * typemanager.cs (intptr_type): Core type for System.IntPtr
16179 (InitCoreTypes): Update for the same.
16181 (iasyncresult_type, asynccallback_type): Ditto.
16183 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
16186 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
16189 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
16190 the builders for the 4 members of a delegate type :-)
16192 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
16195 * expression.cs (New::DoResolve): Implement guts for delegate creation.
16197 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
16199 2001-10-15 Miguel de Icaza <miguel@ximian.com>
16201 * statement.cs (Break::Emit): Implement.
16202 (Continue::Emit): Implement.
16204 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
16205 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
16206 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
16207 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
16210 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
16211 properties that track the label for the current loop (begin of the
16212 loop and end of the loop).
16214 2001-10-15 Ravi Pratap <ravi@ximian.com>
16216 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
16217 use of emitting anything at all.
16219 * class.cs, rootcontext.cs : Get rid of calls to the same.
16221 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
16223 (Populate): Define the constructor correctly and set the implementation
16226 * typemanager.cs (delegate_types): New hashtable to hold delegates that
16229 (AddDelegateType): Implement.
16231 (IsDelegateType): Implement helper method.
16233 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
16235 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
16236 and accordingly handle it.
16238 * delegate.cs (Populate): Take TypeContainer argument.
16239 Implement bits to define the Invoke method. However, I still haven't figured out
16240 how to take care of the native int bit :-(
16242 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
16243 Qualify the name of the delegate, not its return type !
16245 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
16248 (StandardConversionExists): Checking for array types turns out to be recursive.
16250 (ConvertReferenceExplicit): Implement array conversion.
16252 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
16254 2001-10-12 Ravi Pratap <ravi@ximian.com>
16256 * cs-parser.jay (delegate_declaration): Store the fully qualified
16257 name as it is a type declaration.
16259 * delegate.cs (ReturnType, Name): Rename members to these. Make them
16262 (DefineDelegate): Renamed from Define. Does the same thing essentially,
16263 as TypeContainer::DefineType.
16265 (Populate): Method in which all the definition of the various methods (Invoke)
16268 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
16271 (CloseDelegate): Finally creates the delegate.
16273 * class.cs (TypeContainer::DefineType): Update to define delegates.
16274 (Populate, Emit and CloseType): Do the same thing here too.
16276 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
16277 delegates in all these operations.
16279 2001-10-14 Miguel de Icaza <miguel@ximian.com>
16281 * expression.cs: LocalTemporary: a new expression used to
16282 reference a temporary that has been created.
16284 * assign.cs: Handle PropertyAccess back here, so that we can
16285 provide the proper semantic access to properties.
16287 * expression.cs (Expression::ConvertReferenceExplicit): Implement
16288 a few more explicit conversions.
16290 * modifiers.cs: `NEW' modifier maps to HideBySig.
16292 * expression.cs (PropertyExpr): Make this into an
16293 ExpressionStatement, and support the EmitStatement code path.
16295 Perform get/set error checking, clean up the interface.
16297 * assign.cs: recognize PropertyExprs as targets, and if so, turn
16298 them into toplevel access objects.
16300 2001-10-12 Miguel de Icaza <miguel@ximian.com>
16302 * expression.cs: PropertyExpr::PropertyExpr: use work around the
16305 * typemanager.cs: Keep track here of our PropertyBuilders again to
16306 work around lameness in SRE.
16308 2001-10-11 Miguel de Icaza <miguel@ximian.com>
16310 * expression.cs (LValue::LValueResolve): New method in the
16311 interface, used to perform a second resolution pass for LValues.
16313 (This::DoResolve): Catch the use of this in static methods.
16315 (This::LValueResolve): Implement.
16317 (This::Store): Remove warning, assigning to `this' in structures
16320 (Invocation::Emit): Deal with invocation of
16321 methods on value types. We need to pass the address to structure
16322 methods rather than the object itself. (The equivalent code to
16323 emit "this" for structures leaves the entire structure on the
16324 stack instead of a pointer to it).
16326 (ParameterReference::DoResolve): Compute the real index for the
16327 argument based on whether the method takes or not a `this' pointer
16328 (ie, the method is static).
16330 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
16331 value types returned from functions when we need to invoke a
16332 method on the sturcture.
16335 2001-10-11 Ravi Pratap <ravi@ximian.com>
16337 * class.cs (TypeContainer::DefineType): Method to actually do the business of
16338 defining the type in the Modulebuilder or Typebuilder. This is to take
16339 care of nested types which need to be defined on the TypeBuilder using
16340 DefineNestedMethod.
16342 (TypeContainer::GetClassBases): Implement. Essentially the code from the
16343 methods in RootContext, only ported to be part of TypeContainer.
16345 (TypeContainer::GetInterfaceOrClass): Ditto.
16347 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
16349 * interface.cs (Interface::DefineInterface): New method. Does exactly
16350 what RootContext.CreateInterface did earlier, only it takes care of nested types
16353 (Interface::GetInterfaces): Move from RootContext here and port.
16355 (Interface::GetInterfaceByName): Same here.
16357 * rootcontext.cs (ResolveTree): Re-write.
16359 (PopulateTypes): Re-write.
16361 * class.cs (TypeContainer::Populate): Populate nested types too.
16362 (TypeContainer::Emit): Emit nested members too.
16364 * typemanager.cs (AddUserType): Do not make use of the FullName property,
16365 instead just use the name argument passed in as it is already fully
16368 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
16369 to TypeContainer mapping to see if a type is user-defined.
16371 * class.cs (TypeContainer::CloseType): Implement.
16373 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
16374 the default constructor.
16376 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
16379 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
16381 * interface.cs (CloseType): Create the type here.
16383 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
16386 Remove all the methods which are now in TypeContainer.
16388 2001-10-10 Ravi Pratap <ravi@ximian.com>
16390 * delegate.cs (Define): Re-write bits to define the delegate
16393 2001-10-10 Miguel de Icaza <miguel@ximian.com>
16395 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
16397 * expression.cs (ImplicitReferenceConversion): handle null as well
16398 as a source to convert to any reference type.
16400 * statement.cs (Return): Perform any implicit conversions to
16401 expected return type.
16403 Validate use of return statement.
16405 * codegen.cs (EmitContext): Pass the expected return type here.
16407 * class.cs (Method, Constructor, Property): Pass expected return
16408 type to EmitContext.
16410 2001-10-09 Miguel de Icaza <miguel@ximian.com>
16412 * expression.cs: Make DoResolve take an EmitContext instead of a
16415 Replaced `l' and `location' for `loc', for consistency.
16417 (Error, Warning): Remove unneeded Tc argument.
16419 * assign.cs, literal.cs, constant.cs: Update to new calling
16422 * codegen.cs: EmitContext now contains a flag indicating whether
16423 code is being generated in a static method or not.
16425 * cs-parser.jay: DecomposeQI, new function that replaces the old
16426 QualifiedIdentifier. Now we always decompose the assembled
16427 strings from qualified_identifier productions into a group of
16430 2001-10-08 Miguel de Icaza <miguel@ximian.com>
16432 * rootcontext.cs: Deal with field-less struct types correctly now
16433 by passing the size option to Define Type.
16435 * class.cs: Removed hack that created one static field.
16437 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16439 * statement.cs: Moved most of the code generation here.
16441 2001-10-09 Ravi Pratap <ravi@ximian.com>
16443 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
16446 (ElementAccess): Remove useless bits for now - keep checks as the spec
16449 2001-10-08 Ravi Pratap <ravi@ximian.com>
16451 * expression.cs (ElementAccess::DoResolve): Remove my crap code
16452 and start performing checks according to the spec.
16454 2001-10-07 Ravi Pratap <ravi@ximian.com>
16456 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
16457 rank_specifiers instead.
16459 (rank_specifiers): Change the order in which the rank specifiers are stored
16461 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
16463 * expression.cs (ElementAccess): Implement the LValue interface too.
16465 2001-10-06 Ravi Pratap <ravi@ximian.com>
16467 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
16468 except that user defined conversions are not included.
16470 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
16471 perform the conversion of the return type, if necessary.
16473 (New::DoResolve): Check whether we are creating an array or an object
16474 and accordingly do the needful.
16476 (New::Emit): Same here.
16478 (New::DoResolve): Implement guts of array creation.
16480 (New::FormLookupType): Helper function.
16482 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16484 * codegen.cs: Removed most of the code generation here, and move the
16485 corresponding code generation bits to the statement classes.
16487 Added support for try/catch/finalize and throw.
16489 * cs-parser.jay: Added support for try/catch/finalize.
16491 * class.cs: Catch static methods having the flags override,
16492 virtual or abstract.
16494 * expression.cs (UserCast): This user cast was not really doing
16495 what it was supposed to do. Which is to be born in fully resolved
16496 state. Parts of the resolution were being performed at Emit time!
16500 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16502 * expression.cs: Implicity convert the result from UserCast.
16504 2001-10-05 Ravi Pratap <ravi@ximian.com>
16506 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
16507 prevented it from working correctly.
16509 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
16510 merely ConvertImplicit.
16512 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16514 * typemanager.cs: Make the LookupTypeContainer function static,
16515 and not per-instance.
16517 * class.cs: Make static FindMembers (the one that takes a Type
16520 * codegen.cs: Add EmitForeach here.
16522 * cs-parser.jay: Make foreach a toplevel object instead of the
16523 inline expansion, as we need to perform semantic analysis on it.
16525 2001-10-05 Ravi Pratap <ravi@ximian.com>
16527 * expression.cs (Expression::ImplicitUserConversion): Rename to
16528 UserDefinedConversion.
16530 (Expression::UserDefinedConversion): Take an extra argument specifying
16531 whether we look for explicit user conversions too.
16533 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
16535 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
16537 (ExplicitUserConversion): Make it a call to UserDefinedConversion
16538 with the appropriate arguments.
16540 * cs-parser.jay (cast_expression): Record location too.
16542 * expression.cs (Cast): Record location info.
16544 (Expression::ConvertExplicit): Take location argument.
16546 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16547 to determine if we are doing explicit conversions.
16549 (UserCast::Emit): Update accordingly.
16551 (Expression::ConvertExplicit): Report an error if everything fails.
16553 * ../errors/cs0030.cs : Add.
16555 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16557 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16558 virtual and newslot bits.
16560 * class.cs (TypeContainer::RegisterRequiredImplementations):
16561 Record methods we need.
16563 (TypeContainer::MakeKey): Helper function to make keys for
16564 MethodBases, since the Methodbase key is useless.
16566 (TypeContainer::Populate): Call RegisterRequiredImplementations
16567 before defining the methods.
16569 Create a mapping for method_builders_to_methods ahead of time
16570 instead of inside a tight loop.
16572 (::RequireMethods): Accept an object as the data to set into the
16573 hashtable so we can report interface vs abstract method mismatch.
16575 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16577 * report.cs: Make all of it static.
16579 * rootcontext.cs: Drop object_type and value_type computations, as
16580 we have those in the TypeManager anyways.
16582 Drop report instance variable too, now it is a global.
16584 * driver.cs: Use try/catch on command line handling.
16586 Add --probe option to debug the error reporting system with a test
16589 * report.cs: Add support for exiting program when a probe
16590 condition is reached.
16592 2001-10-03 Ravi Pratap <ravi@ximian.com>
16594 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16595 we do a forcible conversion regardless of type, to check if
16596 ForceConversion returns a null.
16598 (Binary::error19): Use location to report error.
16600 (Unary::error23): Use location here too.
16602 * ../errors/cs0019.cs : Check in.
16604 * ../errors/cs0023.cs : Check in.
16606 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16607 case of a non-null MethodInfo object with a length of 0 !
16609 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16610 an applicable member - according to the spec :-)
16611 Also fix logic to find members in base types.
16613 (Unary::ResolveOperator): Same here.
16615 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16616 as I was getting thoroughly confused between this and error19 :-)
16618 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16619 (::FindMostEncompassedType): Implement.
16620 (::FindMostEncompassingType): Implement.
16621 (::StandardConversionExists): Implement.
16623 (UserImplicitCast): Re-vamp. We now need info about most specific
16624 source and target types so that we can do the necessary conversions.
16626 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16627 mathematical union with no duplicates.
16629 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16631 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16632 in order from base classes to child classes, so that we can in
16633 child classes look up in our parent for method names and
16634 attributes (required for handling abstract, virtual, new, override
16635 constructs: we need to instrospect our base class, and if we dont
16636 populate the classes in order, the introspection might be
16637 incorrect. For example, a method could query its parent before
16638 the parent has any methods and would determine that the parent has
16639 no abstract methods (while it could have had them)).
16641 (RootContext::CreateType): Record the order in which we define the
16644 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16646 * class.cs (TypeContainer::Populate): Also method definitions can
16647 fail now, keep track of this.
16649 (TypeContainer::FindMembers): Implement support for
16650 DeclaredOnly/noDeclaredOnly flag.
16652 (Constructor::Emit) Return the ConstructorBuilder.
16654 (Method::Emit) Return the MethodBuilder.
16655 Check for abstract or virtual methods to be public.
16657 * rootcontext.cs (RootContext::CreateType): Register all the
16658 abstract methods required for the class to be complete and the
16659 interface methods that must be implemented.
16661 * cs-parser.jay: Report error 501 (method requires body if it is
16662 not marked abstract or extern).
16664 * expression.cs (TypeOf::Emit): Implement.
16666 * typemanager.cs: runtime_handle_type, new global type.
16668 * class.cs (Property::Emit): Generate code for properties.
16670 2001-10-02 Ravi Pratap <ravi@ximian.com>
16672 * expression.cs (Unary::ResolveOperator): Find operators on base type
16673 too - we now conform exactly to the spec.
16675 (Binary::ResolveOperator): Same here.
16677 * class.cs (Operator::Define): Fix minor quirk in the tests.
16679 * ../errors/cs0215.cs : Added.
16681 * ../errors/cs0556.cs : Added.
16683 * ../errors/cs0555.cs : Added.
16685 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16687 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16688 single integer which is really efficient
16690 2001-10-01 Ravi Pratap <ravi@ximian.com>
16692 * expression.cs (Expression::ImplicitUserConversion): Use location
16693 even in the case when we are examining True operators.
16695 * class.cs (Operator::Define): Perform extensive checks to conform
16696 with the rules for operator overloading in the spec.
16698 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16699 some of the other conversions mentioned in the spec.
16701 * typemanager.cs (array_type): New static member for the System.Array built-in
16704 (cloneable_interface): For System.ICloneable interface.
16706 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16707 we start resolving the tree and populating types.
16709 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16711 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16713 * expression.cs (Expression::ExprClassFromMemberInfo,
16714 Expression::Literalize): Create literal expressions from
16715 FieldInfos which are literals.
16717 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16718 type casts, because they were wrong. The test suite in tests
16721 (ImplicitNumericConversion): ushort to ulong requires a widening
16724 Int32 constant to long requires widening cast as well.
16726 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16727 for integers because the type on the stack is not i4.
16729 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16731 * expression.cs (report118): require location argument.
16733 * parameter.cs: Do not dereference potential null value.
16735 * class.cs: Catch methods that lack the `new' keyword when
16736 overriding a name. Report warnings when `new' is used without
16737 anything being there to override.
16739 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16741 * class.cs: Only add constructor to hashtable if it is non-null
16742 (as now constructors can fail on define).
16744 (TypeManager, Class, Struct): Take location arguments.
16746 Catch field instance initialization in structs as errors.
16748 accepting_filter: a new filter for FindMembers that is static so
16749 that we dont create an instance per invocation.
16751 (Constructor::Define): Catch errors where a struct constructor is
16754 * cs-parser.jay: Pass location information for various new
16757 * delegate.cs (Delegate): take a location argument.
16759 * driver.cs: Do not call EmitCode if there were problesm in the
16760 Definition of the types, as many Builders wont be there.
16762 * decl.cs (Decl::Decl): Require a location argument.
16764 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16765 into integers, and find the most appropiate integer for it.
16767 * literal.cs: Implement ULongLiteral.
16769 * rootcontext.cs: Provide better information about the location of
16770 failure when CreateType fails.
16772 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16774 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16777 * expression.cs (Binary::CheckShiftArguments): Add missing type
16779 (Binary::ResolveOperator): Add type to the logical and and logical
16780 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16783 (Binary::DoNumericPromotions): In the case where either argument
16784 is ulong (and most signed types combined with ulong cause an
16785 error) perform implicit integer constant conversions as well.
16787 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16789 * expression.cs (UserImplicitCast): Method should always be
16791 (Invocation::BetterConversion): Simplified test for IntLiteral.
16793 (Expression::ImplicitNumericConversion): Split this routine out.
16794 Put the code that performs implicit constant integer conversions
16797 (Expression::Resolve): Become a wrapper around DoResolve so we can
16798 check eclass and type being set after resolve.
16800 (Invocation::Badness): Remove this dead function
16802 (Binary::ResolveOperator): Do not compute the expensive argumnets
16803 unless we have a union for it.
16805 (Probe::Emit): Is needs to do an isinst and then
16806 compare against null.
16808 (::CanConvert): Added Location argument. If the Location argument
16809 is null (Location.Null), then we do not report errors. This is
16810 used by the `probe' mechanism of the Explicit conversion. We do
16811 not want to generate an error for something that the user
16812 explicitly requested to be casted. But the pipeline for an
16813 explicit cast first tests for potential implicit casts.
16815 So for now, if the Location is null, it means `Probe only' to
16816 avoid adding another argument. Might have to revise this
16819 (ClassCast): New class used to type cast objects into arbitrary
16820 classes (used in Explicit Reference Conversions).
16822 Implement `as' as well.
16824 Reverted all the patches from Ravi below: they were broken:
16826 * The use of `level' as a mechanism to stop recursive
16827 invocations is wrong. That was there just to catch the
16828 bug with a strack trace but not as a way of addressing
16831 To fix the problem we have to *understand* what is going
16832 on and the interactions and come up with a plan, not
16833 just get things going.
16835 * The use of the type conversion cache that I proposed
16836 last night had an open topic: How does this work across
16837 protection domains. A user defined conversion might not
16838 be public in the location where we are applying the
16839 conversion, a different conversion might be selected
16840 (ie, private A->B (better) but public B->A (worse),
16841 inside A, A->B applies, but outside it, B->A will
16844 * On top of that (ie, even if the above is solved),
16845 conversions in a cache need to be abstract. Ie, `To
16846 convert from an Int to a Short use an OpcodeCast', not
16847 `To convert from an Int to a Short use the OpcodeCast on
16848 the variable 5' (which is what this patch was doing).
16850 2001-09-28 Ravi Pratap <ravi@ximian.com>
16852 * expression.cs (Invocation::ConversionExists): Re-write to use
16853 the conversion cache
16855 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16856 cache all conversions done, not just user-defined ones.
16858 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16859 to determine if a conversion exists instead of acutually trying to
16860 perform the conversion. It's faster too.
16862 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16863 and only then attempt the implicit conversion.
16865 2001-09-28 Ravi Pratap <ravi@ximian.com>
16867 * expression.cs (ConvertImplicit): Use a cache for conversions
16868 already found. Check level of recursion and bail out if necessary.
16870 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16872 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16873 Export standard methods that we expect for string operations.
16875 * statement.cs (Block::UsageWarning): Track usage of variables and
16876 report the errors for not used variables.
16878 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16881 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16883 * codegen.cs: remove unnneded code
16885 * expression.cs: Removed BuiltinTypeAccess class
16887 Fix the order in which implicit conversions are
16890 The previous fixed dropped support for boxed conversions (adding a
16891 test to the test suite now)
16893 (UserImplicitCast::CanConvert): Remove test for source being null,
16894 that code is broken. We should not feed a null to begin with, if
16895 we do, then we should track the bug where the problem originates
16896 and not try to cover it up here.
16898 Return a resolved expression of type UserImplicitCast on success
16899 rather than true/false. Ravi: this is what I was talking about,
16900 the pattern is to use a static method as a "constructor" for
16903 Also, do not create arguments until the very last minute,
16904 otherwise we always create the arguments even for lookups that
16905 will never be performed.
16907 (UserImplicitCast::Resolve): Eliminate, objects of type
16908 UserImplicitCast are born in a fully resolved state.
16910 * typemanager.cs (InitCoreTypes): Init also value_type
16911 (System.ValueType).
16913 * expression.cs (Cast::Resolve): First resolve the child expression.
16915 (LValue): Add new method AddressOf to be used by
16918 Change the argument of Store to take an EmitContext instead of an
16919 ILGenerator, because things like FieldExpr need to be able to call
16920 their children expression to generate the instance code.
16922 (Expression::Error, Expression::Warning): Sugar functions for
16925 (Expression::MemberLookup): Accept a TypeContainer instead of a
16926 Report as the first argument.
16928 (Expression::ResolvePrimary): Killed. I still want to improve
16929 this as currently the code is just not right.
16931 (Expression::ResolveMemberAccess): Simplify, but it is still
16934 (Unary::Resolve): Catch errors in AddressOf operators.
16936 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16937 index to a byte for the short-version, or the compiler will choose
16938 the wrong Emit call, which generates the wrong data.
16940 (ParameterReference::Emit, ::Store): same.
16942 (FieldExpr::AddressOf): Implement.
16944 * typemanager.cs: TypeManager: made public variable instead of
16947 * driver.cs: document --fatal.
16949 * report.cs (ErrorMessage, WarningMessage): new names for the old
16950 Error and Warning classes.
16952 * cs-parser.jay (member_access): Turn built-in access to types
16953 into a normal simplename
16955 2001-09-27 Ravi Pratap <ravi@ximian.com>
16957 * expression.cs (Invocation::BetterConversion): Fix to cope
16958 with q being null, since this was introducing a bug.
16960 * expression.cs (ConvertImplicit): Do built-in conversions first.
16962 2001-09-27 Ravi Pratap <ravi@ximian.com>
16964 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16966 2001-09-27 Ravi Pratap <ravi@ximian.com>
16968 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16969 I had introduced long ago (what's new ?).
16971 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16972 the work of all the checking.
16973 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16974 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16976 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16977 that is the right way.
16979 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16980 overloading resolution. Use everywhere instead of cutting and pasting code.
16982 (Binary::ResolveOperator): Use MakeUnionSet.
16984 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16985 we have to convert to bool types. Not complete yet.
16987 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16989 * typemanager.cs (TypeManager::CSharpName): support ushort.
16991 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16992 to provide an expression that performsn an implicit constant int
16993 conversion (section 6.1.6).
16994 (Expression::ConvertImplicitRequired): Reworked to include
16995 implicit constant expression conversions.
16997 (Expression::ConvertNumericExplicit): Finished.
16999 (Invocation::Emit): If InstanceExpression is null, then it means
17000 that we perform a call on this.
17002 2001-09-26 Miguel de Icaza <miguel@ximian.com>
17004 * expression.cs (Unary::Emit): Remove some dead code.
17005 (Probe): Implement Resolve and Emit for `is'.
17006 (Expression::ConvertImplicitRequired): Attempt to do constant
17007 expression conversions here. Maybe should be moved to
17008 ConvertImplicit, but I am not sure.
17009 (Expression::ImplicitLongConstantConversionPossible,
17010 Expression::ImplicitIntConstantConversionPossible): New functions
17011 that tell whether is it possible to apply an implicit constant
17012 expression conversion.
17014 (ConvertNumericExplicit): Started work on explicit numeric
17017 * cs-parser.jay: Update operator constants.
17019 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
17020 (Parameters::GetSignature): Hook up VerifyArgs here.
17021 (Parameters::VerifyArgs): Verifies that no two arguments have the
17024 * class.cs (Operator): Update the operator names to reflect the
17025 ones that the spec expects (as we are just stringizing the
17028 * expression.cs (Unary::ResolveOperator): Fix bug: Use
17029 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
17030 previous usage did only work for our methods.
17031 (Expression::ConvertImplicit): Handle decimal implicit numeric
17032 conversions as well.
17033 (Expression::InternalTypeConstructor): Used to invoke constructors
17034 on internal types for default promotions.
17036 (Unary::Emit): Implement special handling for the pre/post
17037 increment/decrement for overloaded operators, as they need to have
17038 the same semantics as the other operators.
17040 (Binary::ResolveOperator): ditto.
17041 (Invocation::ConversionExists): ditto.
17042 (UserImplicitCast::Resolve): ditto.
17044 2001-09-26 Ravi Pratap <ravi@ximian.com>
17046 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
17047 operator, return after emitting body. Regression tests pass again !
17049 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
17050 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
17051 (Invocation::OverloadResolve): Ditto.
17052 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
17054 * everywhere : update calls to the above methods accordingly.
17056 2001-09-26 Miguel de Icaza <miguel@ximian.com>
17058 * assign.cs (Assign): Make it inherit from ExpressionStatement.
17060 * expression.cs (ExpressionStatement): New base class used for
17061 expressions that can appear in statements, so that we can provide
17062 an alternate path to generate expression that do not leave a value
17065 (Expression::Emit, and all the derivatives): We no longer return
17066 whether a value is left on the stack or not. Every expression
17067 after being emitted leaves a single value on the stack.
17069 * codegen.cs (EmitContext::EmitStatementExpression): Use the
17070 facilties of ExpressionStatement if possible.
17072 * cs-parser.jay: Update statement_expression.
17074 2001-09-25 Miguel de Icaza <miguel@ximian.com>
17076 * driver.cs: Change the wording of message
17078 2001-09-25 Ravi Pratap <ravi@ximian.com>
17080 * expression.cs (Binary::ResolveOperator): Had forgottten to set
17081 the type of the expression to the return type of the method if
17082 we have an overloaded operator match ! The regression tests pass again !
17083 (Unary::ResolveOperator): Ditto.
17085 * expression.cs (Invocation::ConversionExists): Correct the member lookup
17086 to find "op_Implicit", not "implicit" ;-)
17087 (UserImplicitCast): New class to take care of user-defined implicit conversions.
17088 (ConvertImplicit, ForceConversion): Take TypeContainer argument
17090 * everywhere : Correct calls to the above accordingly.
17092 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
17093 (ConvertImplicit): Do user-defined conversion if it exists.
17095 2001-09-24 Miguel de Icaza <miguel@ximian.com>
17097 * assign.cs: track location.
17098 (Resolve): Use implicit conversions on assignment.
17100 * literal.cs: Oops. Not good, Emit of short access values should
17101 pass (Bytes) or the wrong argument will be selected.
17103 * expression.cs (Unary::Emit): Emit code for -expr.
17105 (Unary::ResolveOperator): Handle `Substract' for non-constants
17106 (substract from zero from the non-constants).
17107 Deal with Doubles as well.
17109 (Expression::ConvertImplicitRequired): New routine that reports an
17110 error if no implicit conversion exists.
17112 (Invocation::OverloadResolve): Store the converted implicit
17113 expressions if we make them
17115 2001-09-24 Ravi Pratap <ravi@ximian.com>
17117 * class.cs (ConstructorInitializer): Take a Location argument.
17118 (ConstructorBaseInitializer): Same here.
17119 (ConstructorThisInitializer): Same here.
17121 * cs-parser.jay : Update all calls accordingly.
17123 * expression.cs (Unary, Binary, New): Take location argument.
17124 Update accordingly everywhere.
17126 * cs-parser.jay : Update all calls to the above to take a location
17129 * class.cs : Ditto.
17131 2001-09-24 Ravi Pratap <ravi@ximian.com>
17133 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
17134 (Invocation::BetterConversion): Same here
17135 (Invocation::ConversionExists): Ditto.
17137 (Invocation::ConversionExists): Implement.
17139 2001-09-22 Ravi Pratap <ravi@ximian.com>
17141 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
17142 Also take an additional TypeContainer argument.
17144 * All over : Pass in TypeContainer as argument to OverloadResolve.
17146 * typemanager.cs (CSharpName): Update to check for the string type and return
17149 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
17152 2001-09-21 Ravi Pratap <ravi@ximian.com>
17154 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
17155 (Invocation::BetterFunction): Implement.
17156 (Invocation::BetterConversion): Implement.
17157 (Invocation::ConversionExists): Skeleton, no implementation yet.
17159 Okay, things work fine !
17161 2001-09-21 Miguel de Icaza <miguel@ximian.com>
17163 * typemanager.cs: declare and load enum_type, delegate_type and
17166 * expression.cs (Expression::Emit): Now emit returns a value that
17167 tells whether a value is left on the stack or not. This strategy
17168 might be reveted tomorrow with a mechanism that would address
17169 multiple assignments.
17170 (Expression::report118): Utility routine to report mismatches on
17173 (Unary::Report23): Report impossible type/operator combination
17176 (Unary::IsIncrementableNumber): Whether the type can be
17177 incremented or decremented with add.
17178 (Unary::ResolveOperator): Also allow enumerations to be bitwise
17180 (Unary::ResolveOperator): Implement ++, !, ~,
17182 (Invocation::Emit): Deal with new Emit convetion.
17184 * All Expression derivatives: Updated their Emit method to return
17185 whether they leave values on the stack or not.
17187 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
17188 stack for expressions that are statements.
17190 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17192 * expression.cs (LValue): New interface. Must be implemented by
17194 (LocalVariableReference, ParameterReference, FieldExpr): Implement
17197 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
17198 interface for generating code, simplifies the code.
17200 2001-09-20 Ravi Pratap <ravi@ximian.com>
17202 * expression.cs (everywhere): Comment out return statements in ::Resolve
17203 methods to avoid the warnings.
17205 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17207 * driver.cs (parse): Report error 2001 if we can not open the
17210 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
17213 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
17216 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
17217 otherwise nested blocks end up with the same index.
17219 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
17221 * expression.cs: Instead of having FIXMEs in the Resolve
17222 functions, throw exceptions so it is obvious that we are facing a
17225 * cs-parser.jay (invocation_expression): Pass Location information.
17227 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
17228 Use a basename for those routines because .NET does not like paths
17231 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
17234 2001-09-19 Miguel de Icaza <miguel@ximian.com>
17236 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
17237 are loading the correct data types (throws an exception if not).
17238 (TypeManager::InitCoreTypes): Use CoreLookupType
17240 * expression.cs (Unary::ResolveOperator): return the child
17241 expression for expressions which are just +expr.
17242 (Unary::ResolveOperator): Return negative literals for -LITERAL
17243 expressions (otherwise they are Unary {Literal}).
17244 (Invocation::Badness): Take into account `Implicit constant
17245 expression conversions'.
17247 * literal.cs (LongLiteral): Implement long literal class.
17248 (IntLiteral): export the `Value' of the intliteral.
17250 2001-09-19 Ravi Pratap <ravi@ximian.com>
17252 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
17254 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
17255 instead of 'Operator'
17257 * expression.cs (Binary::ResolveOperator): Update accordingly.
17258 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
17261 * cs-parser.jay (unary_expression): Update to use the new names.
17263 * gen-treedump.cs (GetUnary): Same here.
17265 * expression.cs (Unary::Resolve): Implement.
17266 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
17267 operators are found instead of making noise ;-)
17268 (Unary::ResolveOperator): New method to do precisely the same thing which
17269 Binary::ResolveOperator does for Binary expressions.
17270 (Unary.method, .Arguments): Add.
17271 (Unary::OperName): Implement.
17272 (Unary::ForceConversion): Copy and Paste !
17274 * class.cs (Operator::Define): Fix a small bug for the case when we have
17277 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
17278 for the inbuilt operators. Only overloading works for now ;-)
17280 2001-09-18 Miguel de Icaza <miguel@ximian.com>
17282 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
17283 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
17285 * expression.cs (This::Emit): Implement.
17286 (This::Resolve): Implement.
17287 (TypeOf:Resolve): Implement.
17288 (Expression::ResolveSimpleName): Add an implicit this to instance
17290 (MemberAccess::Resolve): Deal with Parameters and Fields.
17291 Bind instance variable to Field expressions.
17292 (FieldExpr::Instance): New field used to track the expression that
17293 represents the object instance.
17294 (FieldExpr::Resolve): Track potential errors from MemberLookup not
17296 (FieldExpr::Emit): Implement.
17298 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
17299 the last instruction contains a return opcode to avoid generating
17300 the last `ret' instruction (this generates correct code, and it is
17301 nice to pass the peverify output).
17303 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
17304 initializer for static and instance variables.
17305 (Constructor::Emit): Allow initializer to be null in the case of
17306 static constructors. Only emit initializer for instance
17309 (TypeContainer::FindMembers): Return a null array if there are no
17312 Also fix the code for the MemberTypes.Method branch, as it was not
17313 scanning that for operators (or tried to access null variables before).
17315 * assign.cs (Assign::Emit): Handle instance and static fields.
17319 * driver.cs: Stop compilation if there are parse errors.
17321 * cs-parser.jay (constructor_declaration): Provide default base
17322 initializer for non-static constructors.
17323 (constructor_declarator): Do not provide a default base
17324 initializers if none was specified.
17325 Catch the fact that constructors should not have parameters.
17327 * class.cs: Do not emit parent class initializers for static
17328 constructors, that should be flagged as an error.
17330 2001-09-18 Ravi Pratap <ravi@ximian.com>
17332 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
17333 Move back code into TypeContainer::Populate.
17335 2001-09-18 Ravi Pratap <ravi@ximian.com>
17337 * class.cs (TypeContainer::AddConstructor): Fix the check to
17338 compare against Name, not Basename.
17339 (Operator::OpType): Change Plus and Minus to Add and Subtract.
17341 * cs-parser.jay : Update accordingly.
17343 * class.cs (TypeContainer::FindMembers): For the case where we are searching
17344 for methods, don't forget to look into the operators too.
17345 (RegisterMethodBuilder): Helper method to take care of this for
17346 methods, constructors and operators.
17347 (Operator::Define): Completely revamp.
17348 (Operator.OperatorMethod, MethodName): New fields.
17349 (TypeContainer::Populate): Move the registering of builders into
17350 RegisterMethodBuilder.
17351 (Operator::Emit): Re-write.
17353 * expression.cs (Binary::Emit): Comment out code path to emit method
17354 invocation stuff for the case when we have a user defined operator. I am
17355 just not able to get it right !
17357 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17359 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
17362 (Expression::MemberLookup): Provide a version that allows to
17363 specify the MemberTypes and BindingFlags.
17365 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
17366 so it was not fetching variable information from outer blocks.
17368 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
17369 Beforefieldinit as it was buggy.
17371 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
17372 that Ravi put here.
17374 * class.cs (Constructor::Emit): Only emit if block is not null.
17375 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
17376 deal with this by semantically definining it as if the user had
17379 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
17380 constructors as we now "emit" them at a higher level.
17382 (TypeContainer::DefineDefaultConstructor): Used to define the
17383 default constructors if none was provided.
17385 (ConstructorInitializer): Add methods Resolve and Emit.
17387 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
17389 2001-09-17 Ravi Pratap <ravi@ximian.com>
17391 * class.cs (TypeContainer::EmitDefaultConstructor): Register
17392 the default constructor builder with our hashtable for methodbuilders
17395 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
17396 and argument_count is 0 in which case we have a match.
17397 (Binary::ResolveOperator): More null checking and miscellaneous coding
17400 2001-09-17 Ravi Pratap <ravi@ximian.com>
17402 * rootcontext.cs (IsNameSpace): Compare against null.
17404 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
17406 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
17407 and Unary::Operator.
17409 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
17412 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
17413 we have overloaded operators.
17414 (Binary::ResolveOperator): Implement the part which does the operator overload
17417 * class.cs (Operator::Emit): Implement.
17418 (TypeContainer::Emit): Emit the operators we have too.
17420 * expression.cs (Binary::Emit): Update to emit the appropriate code for
17421 the case when we have a user-defined operator.
17423 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17425 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
17427 2001-09-16 Ravi Pratap <ravi@ximian.com>
17429 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
17430 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
17431 (Constructor::Emit): Implement.
17432 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
17433 if we have no work to do.
17434 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
17437 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
17438 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
17440 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
17443 2001-09-15 Ravi Pratap <ravi@ximian.com>
17445 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
17447 (Tree::RecordNamespace): Method to do what the name says ;-)
17448 (Tree::Namespaces): Property to get at the namespaces hashtable.
17450 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
17453 * rootcontext.cs (IsNamespace): Fixed it :-)
17455 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17457 * class.cs (TypeContainer::FindMembers): Add support for
17459 (MethodCore): New class that encapsulates both the shared aspects
17460 of a Constructor and a Method.
17461 (Method, Constructor): Factored pieces into MethodCore.
17463 * driver.cs: Added --fatal which makes errors throw exceptions.
17464 Load System assembly as well as part of the standard library.
17466 * report.cs: Allow throwing exceptions on errors for debugging.
17468 * modifiers.cs: Do not use `parent', instead use the real type
17469 container to evaluate permission settings.
17471 * class.cs: Put Ravi's patch back in. He is right, and we will
17472 have to cope with the
17474 2001-09-14 Ravi Pratap <ravi@ximian.com>
17476 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
17477 FamORAssem, not FamANDAssem.
17479 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17481 * driver.cs: Added --parse option that only parses its input files
17484 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
17485 incorrect. IsTopLevel is not used to tell whether an object is
17486 root_types or not (that can be achieved by testing this ==
17487 root_types). But to see if this is a top-level *class* (not
17488 necessarly our "toplevel" container).
17490 2001-09-14 Ravi Pratap <ravi@ximian.com>
17492 * enum.cs (Enum::Define): Modify to call the Lookup method on the
17493 parent instead of a direct call to GetType.
17495 2001-09-14 Ravi Pratap <ravi@ximian.com>
17497 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
17498 Modifiers.TypeAttr. This should just be a call to that method.
17500 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
17501 object so that we can determine if we are top-level or not.
17503 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
17506 * enum.cs (Enum::Define): Ditto.
17508 * modifiers.cs (FieldAttr): Re-write.
17510 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
17511 (TypeContainer::HaveStaticConstructor): New property to provide access
17512 to precisely that info.
17514 * modifiers.cs (MethodAttr): Re-write.
17515 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
17517 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
17518 of top-level types as claimed.
17520 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17522 * expression.cs (MemberLookup): Fruitless attempt to lookup
17523 constructors. Maybe I need to emit default constructors? That
17524 might be it (currently .NET emits this for me automatically).
17525 (Invocation::OverloadResolve): Cope with Arguments == null.
17526 (Invocation::EmitArguments): new function, shared by the new
17527 constructor and us.
17528 (Invocation::Emit): Handle static and instance methods. Emit
17529 proper call instruction for virtual or non-virtual invocations.
17530 (New::Emit): Implement.
17531 (New::Resolve): Implement.
17532 (MemberAccess:Resolve): Implement.
17533 (MethodGroupExpr::InstanceExpression): used conforming to the spec
17534 to track instances.
17535 (FieldExpr::Resolve): Set type.
17537 * support.cs: Handle empty arguments.
17539 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
17540 SimpleLookup): Auxiliary routines to help parse a qualifier
17543 Update qualifier_identifier rule.
17545 * codegen.cs: Removed debugging messages.
17547 * class.cs: Make this a global thing, this acts just as a "key" to
17548 objects that we might have around.
17550 (Populate): Only initialize method_builders_to_methods once.
17552 * expression.cs (PropertyExpr): Initialize type from the
17555 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17556 Resolve pattern. Attempt to implicitly convert value to boolean.
17559 * expression.cs: Set the type for the int32/int32 argument case.
17560 (Binary::ResolveOperator): Set the return type to boolean for
17561 comparission operators
17563 * typemanager.cs: Remove debugging print code.
17565 (Invocation::Resolve): resolve type.
17567 * class.cs: Allocate a MemberInfo of the correct size, as the code
17568 elsewhere depends on the test to reflect the correct contents.
17570 (Method::) Keep track of parameters, due to System.Reflection holes
17572 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17575 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17576 of the exact size and return that.
17578 (Class::LookupMethodByBuilder): New function that maps
17579 MethodBuilders to its methods. Required to locate the information
17580 on methods because System.Reflection bit us again.
17582 * support.cs: New file, contains an interface ParameterData and
17583 two implementations: ReflectionParameters and InternalParameters
17584 used to access Parameter information. We will need to grow this
17587 * expression.cs (Invocation::GetParameterData): implement a cache
17588 and a wrapper around the ParameterData creation for methods.
17589 (Invocation::OverloadResolve): Use new code.
17591 2001-09-13 Ravi Pratap <ravi@ximian.com>
17593 * class.cs (TypeContainer::EmitField): Remove and move into
17594 (Field::Define): here and modify accordingly.
17595 (Field.FieldBuilder): New member.
17596 (TypeContainer::Populate): Update accordingly.
17597 (TypeContainer::FindMembers): Implement.
17599 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17601 * statement.cs: (VariableInfo::VariableType): New field to be
17602 initialized with the full type once it is resolved.
17604 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17606 * parameter.cs (GetParameterInfo): Use a type cache to compute
17607 things only once, and to reuse this information
17609 * expression.cs (LocalVariableReference::Emit): Implement.
17610 (OpcodeCast::Emit): fix.
17612 (ParameterReference::Resolve): Implement.
17613 (ParameterReference::Emit): Implement.
17615 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17616 that are expressions need to stay as Expressions.
17618 * typemanager.cs (CSharpName): Returns the C# name of a type if
17621 * expression.cs (Expression::ConvertImplicit): New function that
17622 implements implicit type conversions.
17624 (Expression::ImplicitReferenceConversion): Implements implicit
17625 reference conversions.
17627 (EmptyCast): New type for transparent casts.
17629 (OpcodeCast): New type for casts of types that are performed with
17630 a sequence of bytecodes.
17632 (BoxedCast): New type used for casting value types into reference
17633 types. Emits a box opcode.
17635 (Binary::DoNumericPromotions): Implements numeric promotions of
17636 and computation of the Binary::Type.
17638 (Binary::EmitBranchable): Optimization.
17640 (Binary::Emit): Implement code emission for expressions.
17642 * typemanager.cs (TypeManager): Added two new core types: sbyte
17645 2001-09-12 Ravi Pratap <ravi@ximian.com>
17647 * class.cs (TypeContainer::FindMembers): Method which does exactly
17648 what Type.FindMembers does, only we don't have to use reflection. No
17649 implementation yet.
17651 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17652 typecontainer objects as we need to get at them.
17653 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17655 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17656 typecontainer object.
17658 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17659 of just a Report object.
17661 2001-09-11 Ravi Pratap <ravi@ximian.com>
17663 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17665 (TypeContainer::Populate): Now define the delegates of the type too.
17666 (TypeContainer.Delegates): Property to access the list of delegates defined
17669 * delegates.cs (Delegate::Define): Implement partially.
17671 * modifiers.cs (TypeAttr): Handle more flags.
17673 2001-09-11 Ravi Pratap <ravi@ximian.com>
17675 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17677 (Operator::Define): Re-write logic to get types by using the LookupType method
17678 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17679 (Indexer::Define): Ditto.
17680 (Event::Define): Ditto.
17681 (Property::Define): Ditto.
17683 2001-09-10 Ravi Pratap <ravi@ximian.com>
17685 * class.cs (TypeContainer::Populate): Now define operators too.
17686 (TypeContainer.Operators): New property to access the list of operators
17688 (Operator.OperatorMethodBuilder): New member to hold the method builder
17689 for the operator we are defining.
17690 (Operator::Define): Implement.
17692 2001-09-10 Ravi Pratap <ravi@ximian.com>
17694 * class.cs (Event::Define): Make the prefixes of the accessor methods
17695 addOn_ and removeOn_
17697 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17698 of the location being passed in too. Ideally, this should go later since all
17699 error reporting should be done through the Report object.
17701 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17702 (Populate): Iterate thru the indexers we have and define them too.
17703 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17704 for the get and set accessors.
17705 (Indexer::Define): Implement.
17707 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17709 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17710 my previous implementation, did not work.
17712 * typemanager.cs: Add a couple of missing types (the longs).
17714 * literal.cs: Use TypeManager.bool_type instead of getting it.
17716 * expression.cs (EventExpr): New kind of expressions.
17717 (Expressio::ExprClassFromMemberInfo): finish
17719 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17721 * assign.cs: Emit stores to static fields differently.
17723 2001-09-08 Ravi Pratap <ravi@ximian.com>
17725 * Merge in changes and adjust code to tackle conflicts. Backed out my
17726 code in Assign::Resolve ;-)
17728 2001-09-08 Ravi Pratap <ravi@ximian.com>
17730 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17731 instead Report.Error and also pass in the location.
17732 (CSharpParser::Lexer): New readonly property to return the reference
17733 to the Tokenizer object.
17734 (declare_local_variables): Use Report.Error with location instead of plain
17738 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17739 (Operator.CheckBinaryOperator): Ditto.
17741 * cs-parser.jay (operator_declarator): Update accordingly.
17743 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17744 (CheckBinaryOperator): Same here.
17746 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17747 on the name without any prefixes of namespace names etc. This is because we
17748 already might have something already fully qualified like
17749 'System.Console.WriteLine'
17751 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17753 2001-09-07 Ravi Pratap <ravi@ximian.com>
17755 * cs-tokenizer.cs (location): Return a string which also contains
17758 * expression.cs (ElementAccess): New class for expressions of the
17759 type 'element access.'
17760 (BaseAccess): New class for expressions of the type 'base access.'
17761 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17764 * cs-parser.jay (element_access): Implement action.
17765 (base_access): Implement actions.
17766 (checked_expression, unchecked_expression): Implement.
17768 * cs-parser.jay (local_variable_type): Correct and implement.
17769 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17771 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17773 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17774 name and the specifiers.
17776 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17778 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17779 making them all public ;-)
17781 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17784 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17786 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17788 (FieldExpr, PropertyExprs): New resolved expressions.
17789 (SimpleName::MemberStaticCheck): Perform static checks for access
17790 to non-static fields on static methods. Maybe this should be
17791 generalized for MemberAccesses.
17792 (SimpleName::ResolveSimpleName): More work on simple name
17795 * cs-parser.jay (primary_expression/qualified_identifier): track
17796 the parameter index.
17798 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17799 (EmitContext::EmitBoolExpression): Chain to expression generation
17800 instead of temporary hack.
17801 (::EmitStatementExpression): Put generic expression code generation.
17803 * assign.cs (Assign::Emit): Implement variable assignments to
17804 local variables, parameters and fields.
17806 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17808 * statement.cs (Block::GetVariableInfo): New method, returns the
17809 VariableInfo for a variable name in a block.
17810 (Block::GetVariableType): Implement in terms of GetVariableInfo
17812 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17813 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17815 2001-09-06 Ravi Pratap <ravi@ximian.com>
17817 * cs-parser.jay (operator_declaration): Continue on my quest : update
17818 to take attributes argument.
17819 (event_declaration): Ditto.
17820 (enum_declaration): Ditto.
17821 (indexer_declaration): Ditto.
17823 * class.cs (Operator::Operator): Update constructor accordingly.
17824 (Event::Event): Ditto.
17826 * delegate.cs (Delegate::Delegate): Same here.
17828 * enum.cs (Enum::Enum): Same here.
17830 2001-09-05 Ravi Pratap <ravi@ximian.com>
17832 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17834 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17836 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17837 being passed around as an arraylist.
17838 (Attributes::AddAttribute): Method to add attribute sections.
17840 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17841 (struct_declaration): Update accordingly.
17842 (constant_declaration): Update.
17843 (field_declaration): Update.
17844 (method_header): Update.
17845 (fixed_parameter): Update.
17846 (parameter_array): Ditto.
17847 (property_declaration): Ditto.
17848 (destructor_declaration): Ditto.
17850 * class.cs (Struct::Struct): Update constructors accordingly.
17851 (Class::Class): Ditto.
17852 (Field::Field): Ditto.
17853 (Method::Method): Ditto.
17854 (Property::Property): Ditto.
17855 (TypeContainer::OptAttribute): update property's return type.
17857 * interface.cs (Interface.opt_attributes): New member.
17858 (Interface::Interface): Update to take the extra Attributes argument.
17860 * parameter.cs (Parameter::Parameter): Ditto.
17862 * constant.cs (Constant::Constant): Ditto.
17864 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17865 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17866 the attributes as a parameter.
17867 (InterfaceProperty): Update constructor call.
17868 (InterfaceEvent): Ditto.
17869 (InterfaceMethod): Ditto.
17870 (InterfaceIndexer): Ditto.
17872 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17873 pass the attributes too.
17874 (interface_event_declaration): Ditto.
17875 (interface_property_declaration): Ditto.
17876 (interface_method_declaration): Ditto.
17877 (interface_declaration): Ditto.
17879 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17881 * class.cs (Method::Define): Track the "static Main" definition to
17882 create an entry point.
17884 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17885 EntryPoint if we find it.
17887 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17888 (EmitContext::ig): Make this variable public.
17890 * driver.cs: Make the default output file be the first file name
17891 with the .exe extension.
17893 Detect empty compilations
17895 Handle various kinds of output targets. Handle --target and
17896 rename -t to --dumper.
17898 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17899 methods inherited from Expression return now an Expression. This
17900 will is used during the tree rewriting as we resolve them during
17903 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17904 the spec. Missing entirely is the information about
17905 accessability of elements of it.
17907 (Expression::ExprClassFromMemberInfo): New constructor for
17908 Expressions that creates a fully initialized Expression based on
17909 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17912 (Invocation::Resolve): Begin implementing resolution of invocations.
17914 * literal.cs (StringLiteral): Implement Emit.
17916 2001-09-05 Ravi Pratap <ravi@ximian.com>
17918 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17921 2001-09-04 Ravi Pratap <ravi@ximian.com>
17923 * cs-parser.jay (attribute_arguments): Implement actions.
17924 (attribute): Fix bug in production. Implement action.
17925 (attribute_list): Implement.
17926 (attribute_target): Implement.
17927 (attribute_target_specifier, opt_target_specifier): Implement
17928 (CheckAttributeTarget): New method to check if the attribute target
17930 (attribute_section): Implement.
17931 (opt_attributes): Implement.
17933 * attribute.cs : New file to handle attributes.
17934 (Attribute): Class to hold attribute info.
17936 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17937 (attribute_section): Modify production to use 2 different rules to
17938 achieve the same thing. 1 s/r conflict down !
17939 Clean out commented, useless, non-reducing dimension_separator rules.
17941 * class.cs (TypeContainer.attributes): New member to hold list
17942 of attributes for a type.
17943 (Struct::Struct): Modify to take one more argument, the attribute list.
17944 (Class::Class): Ditto.
17945 (Field::Field): Ditto.
17946 (Method::Method): Ditto.
17947 (Property::Property): Ditto.
17949 * cs-parser.jay (struct_declaration): Update constructor call to
17950 pass in the attributes too.
17951 (class_declaration): Ditto.
17952 (constant_declaration): Ditto.
17953 (field_declaration): Ditto.
17954 (method_header): Ditto.
17955 (fixed_parameter): Ditto.
17956 (parameter_array): Ditto.
17957 (property_declaration): Ditto.
17959 * constant.cs (Constant::Constant): Update constructor similarly.
17960 Use System.Collections.
17962 * parameter.cs (Parameter::Parameter): Update as above.
17964 2001-09-02 Ravi Pratap <ravi@ximian.com>
17966 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17967 (TypeContainer.delegates): New member to hold list of delegates.
17969 * cs-parser.jay (delegate_declaration): Implement the action correctly
17970 this time as I seem to be on crack ;-)
17972 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17974 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17975 tell whether an identifier represents a namespace.
17977 * expression.cs (NamespaceExpr): A namespace expression, used only
17978 temporarly during expression resolution.
17979 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17980 utility functions to resolve names on expressions.
17982 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17984 * codegen.cs: Add hook for StatementExpressions.
17986 * class.cs: Fix inverted test for static flag in methods.
17988 2001-09-02 Ravi Pratap <ravi@ximian.com>
17990 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17991 to make it coincide with MS' number.
17992 (Operator::CheckBinaryOperator): Ditto.
17994 * ../errors/errors.txt : Remove error numbers added earlier.
17996 * ../errors/cs1019.cs : Test case for error # 1019
17998 * ../errros/cs1020.cs : Test case for error # 1020
18000 * cs-parser.jay : Clean out commented cruft.
18001 (dimension_separators, dimension_separator): Comment out. Ostensibly not
18002 used anywhere - non-reducing rule.
18003 (namespace_declarations): Non-reducing rule - comment out.
18005 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
18006 with TypeContainer::AddEnum.
18008 * delegate.cs : New file for delegate handling classes.
18009 (Delegate): Class for declaring delegates.
18011 * makefile : Update.
18013 * cs-parser.jay (delegate_declaration): Implement.
18015 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
18017 * class.cs (Event::Define): Implement.
18018 (Event.EventBuilder): New member.
18020 * class.cs (TypeContainer::Populate): Update to define all enums and events
18022 (Events): New property for the events arraylist we hold. Shouldn't we move to using
18023 readonly fields for all these cases ?
18025 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
18027 * class.cs (Property): Revamp to use the convention of making fields readonly.
18028 Accordingly modify code elsewhere.
18030 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
18031 the Define method of the Property class.
18033 * class.cs : Clean up applied patch and update references to variables etc. Fix
18035 (TypeContainer::Populate): Update to define all the properties we have. Also
18036 define all enumerations.
18038 * enum.cs (Define): Implement.
18040 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
18042 * cs-parser.jay (overloadable_operator): The semantic value is an
18043 enum of the Operator class.
18044 (operator_declarator): Implement actions.
18045 (operator_declaration): Implement.
18047 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
18048 validity of definitions.
18049 (Operator::CheckBinaryOperator): Static method to check for binary operators
18050 (TypeContainer::AddOperator): New method to add an operator to a type.
18052 * cs-parser.jay (indexer_declaration): Added line to actually call the
18053 AddIndexer method so it gets added ;-)
18055 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
18056 already taken care of by the MS compiler ?
18058 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
18060 * class.cs (Operator): New class for operator declarations.
18061 (Operator::OpType): Enum for the various operators.
18063 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
18065 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
18066 ostensibly handle this in semantic analysis.
18068 * cs-parser.jay (general_catch_clause): Comment out
18069 (specific_catch_clauses, specific_catch_clause): Ditto.
18070 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
18071 (catch_args, opt_catch_args): New productions.
18072 (catch_clause): Rewrite to use the new productions above
18073 (catch_clauses): Modify accordingly.
18074 (opt_catch_clauses): New production to use in try_statement
18075 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
18076 and re-write the code in the actions to extract the specific and
18077 general catch clauses by being a little smart ;-)
18079 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
18080 Hooray, try and catch statements parse fine !
18082 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18084 * statement.cs (Block::GetVariableType): Fix logic to extract the type
18085 string from the hashtable of variables.
18087 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
18088 I end up making that mistake ;-)
18089 (catch_clauses): Fixed gross error which made Key and Value of the
18090 DictionaryEntry the same : $1 !!
18092 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18094 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
18096 * cs-parser.jay (event_declaration): Correct to remove the semicolon
18097 when the add and remove accessors are specified.
18099 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18101 * cs-parser.jay (IndexerDeclaration): New helper class to hold
18102 information about indexer_declarator.
18103 (indexer_declarator): Implement actions.
18104 (parsing_indexer): New local boolean used to keep track of whether
18105 we are parsing indexers or properties. This is necessary because
18106 implicit_parameters come into picture even for the get accessor in the
18107 case of an indexer.
18108 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
18110 * class.cs (Indexer): New class for indexer declarations.
18111 (TypeContainer::AddIndexer): New method to add an indexer to a type.
18112 (TypeContainer::indexers): New member to hold list of indexers for the
18115 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18117 * cs-parser.jay (add_accessor_declaration): Implement action.
18118 (remove_accessor_declaration): Implement action.
18119 (event_accessors_declaration): Implement
18120 (variable_declarators): swap statements for first rule - trivial.
18122 * class.cs (Event): New class to hold information about event
18124 (TypeContainer::AddEvent): New method to add an event to a type
18125 (TypeContainer::events): New member to hold list of events.
18127 * cs-parser.jay (event_declaration): Implement actions.
18129 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18131 * cs-parser.jay (dim_separators): Implement. Make it a string
18132 concatenating all the commas together, just as they appear.
18133 (opt_dim_separators): Modify accordingly
18134 (rank_specifiers): Update accordingly. Basically do the same
18135 thing - instead, collect the brackets here.
18136 (opt_rank_sepcifiers): Modify accordingly.
18137 (array_type): Modify to actually return the complete type string
18138 instead of ignoring the rank_specifiers.
18139 (expression_list): Implement to collect the expressions
18140 (variable_initializer): Implement. We make it a list of expressions
18141 essentially so that we can handle the array_initializer case neatly too.
18142 (variable_initializer_list): Implement.
18143 (array_initializer): Make it a list of variable_initializers
18144 (opt_array_initializer): Modify accordingly.
18146 * expression.cs (New::NType): Add enumeration to help us
18147 keep track of whether we have an object/delegate creation
18148 or an array creation.
18149 (New:NewType, New::Rank, New::Indices, New::Initializers): New
18150 members to hold data about array creation.
18151 (New:New): Modify to update NewType
18152 (New:New): New Overloaded contructor for the array creation
18155 * cs-parser.jay (array_creation_expression): Implement to call
18156 the overloaded New constructor.
18158 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
18160 * class.cs (TypeContainer::Constructors): Return member
18161 constructors instead of returning null.
18163 2001-08-26 Miguel de Icaza <miguel@ximian.com>
18165 * typemanager.cs (InitCoreTypes): Initialize the various core
18166 types after we have populated the type manager with the user
18167 defined types (this distinction will be important later while
18168 compiling corlib.dll)
18170 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
18171 on Expression Classification. Now all expressions have a method
18172 `Resolve' and a method `Emit'.
18174 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
18175 generation from working. Also add some temporary debugging
18178 2001-08-24 Miguel de Icaza <miguel@ximian.com>
18180 * codegen.cs: Lots of code generation pieces. This is only the
18181 beginning, will continue tomorrow with more touches of polish. We
18182 handle the fundamentals of if, while, do, for, return. Others are
18183 trickier and I need to start working on invocations soon.
18185 * gen-treedump.cs: Bug fix, use s.Increment here instead of
18188 * codegen.cs (EmitContext): New struct, used during code
18189 emission to keep a context. Most of the code generation will be
18192 * cs-parser.jay: Add embedded blocks to the list of statements of
18193 this block. So code generation proceeds in a top down fashion.
18195 2001-08-23 Miguel de Icaza <miguel@ximian.com>
18197 * statement.cs: Add support for multiple child blocks.
18199 2001-08-22 Miguel de Icaza <miguel@ximian.com>
18201 * codegen.cs (EmitCode): New function, will emit the code for a
18202 Block of code given a TypeContainer and its ILGenerator.
18204 * statement.cs (Block): Standard public readonly optimization.
18205 (Block::Block constructors): Link children.
18206 (Block::Child): Child Linker.
18207 (Block::EmitVariables): Emits IL variable declarations.
18209 * class.cs: Drop support for MethodGroups here, delay until
18211 (Method::): Applied the same simplification that I did before, and
18212 move from Properties to public readonly fields.
18213 (Method::ParameterTypes): Returns the parameter types for the
18214 function, and implements a cache that will be useful later when I
18215 do error checking and the semantic analysis on the methods is
18217 (Constructor::GetCallingConvention): Renamed from CallingConvetion
18218 and made a method, optional argument tells whether this is a class
18219 or a structure to apply the `has-this' bit.
18220 (Method::GetCallingConvention): Implement, returns the calling
18222 (Method::Define): Defines the type, a second pass is performed
18223 later to populate the methods.
18225 (Constructor::ParameterTypes): implement a cache similar to the
18226 one on Method::ParameterTypes, useful later when we do semantic
18229 (TypeContainer::EmitMethod): New method. Emits methods.
18231 * expression.cs: Removed MethodGroup class from here.
18233 * parameter.cs (Parameters::GetCallingConvention): new method.
18235 2001-08-21 Miguel de Icaza <miguel@ximian.com>
18237 * class.cs (TypeContainer::Populate): Drop RootContext from the
18240 (Constructor::CallingConvention): Returns the calling convention.
18241 (Constructor::ParameterTypes): Returns the constructor parameter
18244 (TypeContainer::AddConstructor): Keep track of default constructor
18245 and the default static constructor.
18247 (Constructor::) Another class that starts using `public readonly'
18248 instead of properties.
18250 (Constructor::IsDefault): Whether this is a default constructor.
18252 (Field::) use readonly public fields instead of properties also.
18254 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
18255 track of static constructors; If none is used, turn on
18256 BeforeFieldInit in the TypeAttributes.
18258 * cs-parser.jay (opt_argument_list): now the return can be null
18259 for the cases where there are no arguments.
18261 (constructor_declarator): If there is no implicit `base' or
18262 `this', then invoke the default parent constructor.
18264 * modifiers.cs (MethodAttr): New static function maps a set of
18265 modifiers flags into a MethodAttributes enum
18266 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
18267 MethodAttr, TypeAttr to represent the various mappings where the
18268 modifiers are used.
18269 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
18271 2001-08-19 Miguel de Icaza <miguel@ximian.com>
18273 * parameter.cs (GetParameterInfo): Fix bug where there would be no
18276 * interface.cs (PopulateIndexer): Implemented the code generator
18277 for interface indexers.
18279 2001-08-17 Miguel de Icaza <miguel@ximian.com>
18281 * interface.cs (InterfaceMemberBase): Now we track the new status
18284 (PopulateProperty): Implement property population. Woohoo! Got
18285 Methods and Properties going today.
18287 Removed all the properties for interfaces, and replaced them with
18288 `public readonly' fields.
18290 2001-08-16 Miguel de Icaza <miguel@ximian.com>
18292 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
18293 initialize their hashtables/arraylists only when they are needed
18294 instead of doing this always.
18296 * parameter.cs: Handle refs and out parameters.
18298 * cs-parser.jay: Use an ArrayList to construct the arguments
18299 instead of the ParameterCollection, and then cast that to a
18302 * parameter.cs: Drop the use of ParameterCollection and use
18303 instead arrays of Parameters.
18305 (GetParameterInfo): Use the Type, not the Name when resolving
18308 2001-08-13 Miguel de Icaza <miguel@ximian.com>
18310 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
18311 and instead use public readonly fields.
18313 * class.cs: Put back walking code for type containers.
18315 2001-08-11 Miguel de Icaza <miguel@ximian.com>
18317 * class.cs (MakeConstant): Code to define constants.
18319 * rootcontext.cs (LookupType): New function. Used to locate types
18322 2001-08-08 Miguel de Icaza <miguel@ximian.com>
18324 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
18325 this System.Reflection code is. Kudos to Microsoft
18327 * typemanager.cs: Implement a type cache and avoid loading all
18328 types at boot time. Wrap in LookupType the internals. This made
18329 the compiler so much faster. Wow. I rule!
18331 * driver.cs: Make sure we always load mscorlib first (for
18332 debugging purposes, nothing really important).
18334 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
18335 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
18337 * rootcontext.cs: Lookup types on their namespace; Lookup types
18338 on namespaces that have been imported using the `using' keyword.
18340 * class.cs (TypeContainer::TypeAttr): Virtualize.
18341 (Class::TypeAttr): Return attributes suitable for this bad boy.
18342 (Struct::TypeAttr): ditto.
18343 Handle nested classes.
18344 (TypeContainer::) Remove all the type visiting code, it is now
18345 replaced with the rootcontext.cs code
18347 * rootcontext.cs (GetClassBases): Added support for structs.
18349 2001-08-06 Miguel de Icaza <miguel@ximian.com>
18351 * interface.cs, statement.cs, class.cs, parameter.cs,
18352 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
18353 Drop use of TypeRefs, and use strings instead.
18355 2001-08-04 Miguel de Icaza <miguel@ximian.com>
18359 * class.cs (Struct::Struct): set the SEALED flags after
18360 checking the modifiers.
18361 (TypeContainer::TypeAttr): new property, returns the
18362 TypeAttributes for a class.
18364 * cs-parser.jay (type_list): Oops, list production was creating a
18365 new list of base types.
18367 * rootcontext.cs (StdLib): New property.
18368 (GetInterfaceTypeByName): returns an interface by type name, and
18369 encapsulates error handling here.
18370 (GetInterfaces): simplified.
18371 (ResolveTree): Encapsulated all the tree resolution here.
18372 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
18375 * driver.cs: Add support for --nostdlib, to avoid loading the
18376 default assemblies.
18377 (Main): Do not put tree resolution here.
18379 * rootcontext.cs: Beginning of the class resolution.
18381 2001-08-03 Miguel de Icaza <miguel@ximian.com>
18383 * rootcontext.cs: Provide better error reporting.
18385 * cs-parser.jay (interface_base): set our $$ to be interfaces.
18387 * rootcontext.cs (CreateInterface): Handle the case where there
18388 are no parent interfaces.
18390 (CloseTypes): Routine to flush types at the end.
18391 (CreateInterface): Track types.
18392 (GetInterfaces): Returns an array of Types from the list of
18393 defined interfaces.
18395 * typemanager.c (AddUserType): Mechanism to track user types (puts
18396 the type on the global type hash, and allows us to close it at the
18399 2001-08-02 Miguel de Icaza <miguel@ximian.com>
18401 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
18402 RecordInterface instead.
18404 * cs-parser.jay: Updated to reflect changes above.
18406 * decl.cs (Definition): Keep track of the TypeBuilder type that
18407 represents this type here. Not sure we will use it in the long
18408 run, but wont hurt for now.
18410 * driver.cs: Smaller changes to accomodate the new code.
18412 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
18415 * rootcontext.cs (CreateInterface): New method, used to create
18416 the System.TypeBuilder type for interfaces.
18417 (ResolveInterfaces): new entry point to resolve the interface
18419 (CodeGen): Property, used to keep track of the code generator.
18421 2001-07-26 Miguel de Icaza <miguel@ximian.com>
18423 * cs-parser.jay: Add a second production for delegate_declaration
18426 (enum_body): Put an opt_comma here instead of putting it on
18427 enum_body or enum_member_declarations so we can handle trailing
18428 commas on enumeration members. Gets rid of a shift/reduce.
18430 (type_list): Need a COMMA in the middle.
18432 (indexer_declaration): Tell tokenizer to recognize get/set
18434 * Remove old targets.
18436 * Re-add the parser target.
18438 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18440 * cs-parser.jay: Add precendence rules for a number of operators
18441 ot reduce the number of shift/reduce conflicts in the grammar.
18443 2001-07-17 Miguel de Icaza <miguel@ximian.com>
18445 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
18448 Get rid of old crufty code.
18450 * rootcontext.cs: Use this to keep track of the parsed
18451 representation and the defined types available to the program.
18453 * gen-treedump.cs: adjust for new convention.
18455 * type.cs: Split out the type manager, and the assembly builder
18458 * typemanager.cs: the type manager will live here now.
18460 * cil-codegen.cs: And the code generator here.
18462 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
18464 * makefile: Fixed up for easy making.
18466 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18468 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
18471 (unary_expression): Expand pre_increment_expression and
18472 post_decrement_expression to reduce a shift/reduce.
18474 2001-07-11 Simon Cozens
18476 * cs-tokenizer.cs: Hex numbers should begin with a 0.
18478 Improve allow_keyword_as_indent name.
18480 2001-06-19 Miguel de Icaza <miguel@ximian.com>
18482 * Adjustments for Beta2.
18484 2001-06-13 Miguel de Icaza <miguel@ximian.com>
18486 * decl.cs: Added `Define' abstract method.
18487 (InTransit): new property, used to catch recursive definitions.
18489 * interface.cs: Implement `Define'.
18491 * modifiers.cs: Map Modifiers.constants to
18492 System.Reflection.TypeAttribute flags.
18494 * class.cs: Keep track of types and user-defined types.
18495 (BuilderInit): New method for creating an assembly
18496 (ResolveType): New function to launch the resolution process, only
18497 used by interfaces for now.
18499 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
18500 that are inserted into the name space.
18502 2001-06-08 Miguel de Icaza <miguel@ximian.com>
18504 * ARGH. I have screwed up my tree so many times due to the use of
18505 rsync rather than using CVS. Going to fix this at once.
18507 * driver.cs: Objetify driver. Load assemblies, use assemblies to
18510 2001-06-07 Miguel de Icaza <miguel@ximian.com>
18512 * Experiment successful: Use System.Type rather that our own
18515 2001-05-25 Miguel de Icaza <miguel@ximian.com>
18517 * cs-parser.jay: Removed nsAliases from here.
18519 Use new namespaces, handle `using XXX;'
18521 * namespace.cs: Reimplemented namespace handling, use a recursive
18522 definition of the class. Now we can keep track of using clauses
18523 and catch invalid using clauses.
18525 2001-05-24 Miguel de Icaza <miguel@ximian.com>
18527 * gen-treedump.cs: Adapted for all the renaming.
18529 * expression.cs (Expression): this class now has a Type property
18530 which returns an expression Type.
18532 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
18533 `Type', as this has a different meaning now in the base
18535 2001-05-22 Miguel de Icaza <miguel@ximian.com>
18537 * interface.cs, class.cs: Removed from all the sources the
18538 references to signature computation, as we can not do method
18539 signature computation during the parsing time, as we are not
18540 trying to solve at that point distinguishing:
18544 void a (NS.Blah x) {}
18547 Which depending on the context might be valid or not, as we do not
18548 know if Blah is the same thing as NS.Blah at that point.
18550 * Redid everything so the code uses TypeRefs now instead of
18551 Types. TypeRefs are just temporary type placeholders, that need
18552 to be resolved. They initially have a pointer to a string and the
18553 current scope in which they are used. This is used later by the
18554 compiler to resolve the reference to an actual Type.
18556 * DeclSpace is no longer a CIR.Type, and neither are
18557 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18558 are all DeclSpaces, but no Types.
18560 * type.cs (TypeRefManager): This implements the TypeRef manager,
18561 which keeps track of all the types that need to be resolved after
18562 the parsing has finished.
18564 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18566 * ARGH. We are going to have to store `foreach' as a class rather
18567 than resolving it, as we need to verify error 1579 after name
18568 resolution. *OR* we could keep a flag that says `This request to
18569 IEnumerator comes from a foreach statement' which we can then use
18570 to generate the error.
18572 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18574 * class.cs (TypeContainer.AddMethod): we now add methods to the
18575 MethodGroup instead of the method hashtable.
18577 * expression.cs: Add MethodGroup abstraction, which gets us one
18578 step closer to the specification in the way we handle method
18581 * cs-parser.jay (primary_expression): qualified_identifier now
18582 tried to match up an identifier to a local variable reference or
18583 to a parameter reference.
18585 current_local_parameters is now a parser global variable that
18586 points to the current parameters for the block, used during name
18589 (property_declaration): Now creates an implicit `value' argument to
18592 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18594 * parameter.cs: Do not use `param' arguments as part of the
18595 signature, per the spec.
18597 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18599 * decl.cs: Base class for classes, structs and interfaces. This
18600 is the "Declaration Space"
18602 * cs-parser.jay: Use CheckDef for checking declaration errors
18603 instead of having one on each function.
18605 * class.cs: Factor out some code for handling error handling in
18606 accordance to the "Declarations" section in the "Basic Concepts"
18607 chapter in the ECMA C# spec.
18609 * interface.cs: Make all interface member classes derive from
18610 InterfaceMemberBase.
18612 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18614 * Many things: all interfaces are parsed and generated in
18615 gen-treedump. Support for member variables, constructors,
18616 destructors, properties, constants is there.
18618 Beginning of the IL backend, but very little done, just there for
18621 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18623 * cs-parser.jay: Fix labeled statement.
18625 * cs-tokenizer.cs (escape): Escape " and ' always.
18626 ref_line, ref_name: keep track of the line/filename as instructed
18627 by #line by the compiler.
18630 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18632 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18633 to match the values in System.CodeDOM.
18635 Divid renamed to Divide.
18637 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18639 (Statements.set): remove.
18641 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18644 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18645 falseStatements always have valid values.
18647 * cs-parser.jay: Use System.CodeDOM now.