1 2010-06-18 Marek Safar <marek.safar@gmail.com>
3 * convert.cs, typespec.cs, method.cs: Fixed few more dynamic
6 2010-06-18 Marek Safar <marek.safar@gmail.com>
8 * typemanager.cs, namespace.cs: Report more predefined types and
9 imported types collision types as a warning.
10 Fixes #537414, #601157
12 2010-06-18 Marek Safar <marek.safar@gmail.com>
14 * generic.cs: Overrides base method constraint can use method type
17 * import.cs: Removed redundant cache.
19 2010-06-17 Marek Safar <marek.safar@gmail.com>
21 * generic.cs: Propagate type only inflate downwards.
23 2010-06-17 Marek Safar <marek.safar@gmail.com>
26 * method.cs: Do not reject binary dynamic operators.
28 2010-06-17 Marek Safar <marek.safar@gmail.com>
30 * typespec.cs: Internal types have no generic parameters.
33 2010-06-17 Marek Safar <marek.safar@gmail.com>
36 * cs-parser.jay: Correctly set expression mode for default parameter
39 2010-06-17 Marek Safar <marek.safar@gmail.com>
42 * ecore.cs: Resolve dynamic namespace and keyword collision in the
43 favour of the keyword.
45 2010-06-17 Marek Safar <marek.safar@gmail.com>
48 * convert.cs: Allow more undocumented 0 like values to enum type
51 2010-06-17 Marek Safar <marek.safar@gmail.com>
53 * generic.cs, method.cs: Inflate copied type parameters from base
54 class or explicit interfaces.
56 * convert.cs: Fixed conversion between two type parameters.
59 2010-06-16 Marek Safar <marek.safar@gmail.com>
61 * membercache.cs, convert.cs: Correctly resize an array used by
64 2010-06-15 Marek Safar <marek.safar@gmail.com>
67 * dynamic.cs, ecore.cs: A new flag for dynamic resolver to ignore
68 generated member access left expression.
70 2010-06-16 Marek Safar <marek.safar@gmail.com>
72 * expression.cs: Dispatch dynamic invocation solely on left
75 2010-06-16 Marek Safar <marek.safar@gmail.com>
77 * expression.cs, statement.cs: Always persist explicit cast
78 semantic at expression level.
80 2010-06-15 Marek Safar <marek.safar@gmail.com>
82 * expression.cs, attribute.cs: Enable generic type parameters
85 2010-06-15 Marek Safar <marek.safar@gmail.com>
88 * generic.cs: Don't use fixed array for inflated type parameter
89 interface constraints.
91 2010-06-15 Marek Safar <marek.safar@gmail.com>
93 * typespec.cs: ElementTypeSpec has to use its own ITypeDefinition.
95 * report.cs: Unwrap elements for related symbols reporting.
97 2010-06-15 Marek Safar <marek.safar@gmail.com>
100 * cs-tokenizer.cs: Offset correctly keywords the first character
103 2010-06-15 Marek Safar <marek.safar@gmail.com>
105 A fix for bug #613397
106 * expression.cs: Removed too aggressive object initializers
109 2010-06-15 Marek Safar <marek.safar@gmail.com>
111 * parameter.cs, property.cs, membercache.cs, decl.cs, iterators.cs,
112 anonymous.cs, expression.cs, support.cs, method.cs, pending.cs,
113 class.cs, cs-parser.jay: Simplify parsing of accessors by removing
114 any intermediate steps and fake nodes, also saves few MBs of memory.
116 2010-06-11 Marek Safar <marek.safar@gmail.com>
118 * modifiers.cs, rootcontext.cs, location.cs, cs-parser.jay: More
119 precise modifiers parsing.
121 2010-06-09 Marek Safar <marek.safar@gmail.com>
123 * cs-tokenizer.cs, anonymous.cs, expression.cs, cs-parser.jay:
124 Fixed few shift/reduce conflicts.
126 2010-06-09 Marek Safar <marek.safar@gmail.com>
128 * typemanager.cs, parameter.cs, dynamic.cs, typespec.cs,
129 expression.cs, ecore.cs, cs-parser.jay: Fully parse composed type
130 specifiers and stop using string in AST.
132 2010-06-07 Marek Safar <marek.safar@gmail.com>
134 * typemanager.cs, eval.cs, iterators.cs, anonymous.cs, expression.cs
135 method.cs, class.cs, delegate.cs, cs-parser.jay, driver.cs, visit.cs
136 enum.cs: Hold location of predefined types.
138 2010-06-07 Marek Safar <marek.safar@gmail.com>
140 A fix for bug #610878
141 * pending.cs: Clone cached list before modifying.
143 2010-06-04 Marek Safar <marek.safar@gmail.com>
145 * convert.cs, typespec.cs, expression.cs: Start using array member
146 kind for better conversion checks.
148 * import.cs, report.cs: Report better error message for runtime
151 2010-06-04 Marek Safar <marek.safar@gmail.com>
153 * membercache.cs, convert.cs, nullable.cs, expression.cs: Optimize
154 user defined conversion probing and simplify user conversion for
155 nullabe types. Fixes #610940.
157 2010-06-03 Marek Safar <marek.safar@gmail.com>
159 A fix for bug #610919
160 * parameter.cs, property.cs, cs-parser.jay: Use independent implicit
161 parameters for explicit event accessors. Anonymous method capturing
162 won't otherwise work for event implicit parameter.
164 2010-06-02 Marek Safar <marek.safar@gmail.com>
166 A fix for bug #610088
167 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs:
168 Ignore overrides for base overload resolution as for non-base
169 expressions and convert the best candidate to closest override
172 2010-06-01 Marek Safar <marek.safar@gmail.com>
174 A fix for bug #610139
175 * generic.cs, convert.cs: Recursively check effective base interface
177 2010-06-01 Marek Safar <marek.safar@gmail.com>
179 * statement.cs: Handle nullable types and type parameters in using
180 statement, avoid boxing value types. Also fixes #571010
182 2010-06-01 Marek Safar <marek.safar@gmail.com>
184 * convert.cs, expression.cs: Emit unbox for underlying nullable
187 2010-05-29 Marek Safar <marek.safar@gmail.com>
189 A fix for bug #610126
190 * expression.cs: Don't use branch optimization for types bigger than
193 2010-05-28 Marek Safar <marek.safar@gmail.com>
195 A fix for bug #609088
196 * import.cs: Check private modifier correctly.
198 2010-05-28 Marek Safar <marek.safar@gmail.com>
200 A fix for bug #609049
201 * ecore.cs: Don't ignore override methods when looking for base
204 2010-05-27 Marek Safar <marek.safar@gmail.com>
206 A fix for bugs #608007, #572540, #566130, #476358
208 * generic.cs, linq.cs, expression.cs, statement.cs, cs-parser.jay:
209 More tricky refactoring of implicit linq blocks.
211 2010-05-25 Marek Safar <marek.safar@gmail.com>
213 * linq.cs, cs-parser.jay: Keep location for all linq clauses.
215 2010-05-25 Marek Safar <marek.safar@gmail.com>
217 * context.cs, expression.cs, cs-parser.jay: Don't store current
218 block in This expression (it's too early for linq blocks).
220 2010-05-21 Marek Safar <marek.safar@gmail.com>
222 * expression.cs: Use constrained prefix more broadly to avoid boxing.
224 2010-05-20 Marek Safar <marek.safar@gmail.com>
226 A fix for bug #591149
227 * nullable.cs: Don't double wrap same expression.
229 2010-05-20 Marek Safar <marek.safar@gmail.com>
231 A fix for bug #569827
232 * anonymous.cs: Any issued error in probing mode means no match.
234 2010-05-20 Marek Safar <marek.safar@gmail.com>
236 * expression.cs: Search for base indexer using the closest match
239 2010-05-20 Marek Safar <marek.safar@gmail.com>
241 A fix for bug #572071
242 * method.cs: Set override constraints using unexpanded interface
245 2010-05-20 Marek Safar <marek.safar@gmail.com>
247 A fix for bug #572071
248 * ecore.cs: Include secondary extension method lookup in probing
251 2010-05-19 Marek Safar <marek.safar@gmail.com>
253 A fix for bug #515801
254 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
257 2010-05-19 Marek Safar <marek.safar@gmail.com>
259 A fix for bug #515801
260 * pending.cs: Advance counter correctly.
262 2010-05-19 Marek Safar <marek.safar@gmail.com>
264 A fix for bug #480139
265 * method.cs, pending.cs: Indexer override uses base name.
267 2010-05-19 Marek Safar <marek.safar@gmail.com>
269 A fix for bug #424064
270 * generic.cs: Replace original with inflated type parameter on
273 2010-05-19 Marek Safar <marek.safar@gmail.com>
275 A fix for bug #359733
276 * parameter.cs: Extension attribute can be defined in each assembly.
278 2010-05-18 Marek Safar <marek.safar@gmail.com>
280 A fix for bug #446507
281 * method.cs: Only one method can implement an interface.
283 2010-05-18 Marek Safar <marek.safar@gmail.com>
285 A fix for bug #594905
286 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
287 Typed null can be used as a source for expression methods.
289 2010-05-18 Marek Safar <marek.safar@gmail.com>
291 A fix for bug #606551
292 * namespace.cs: Using directive imports only types and not nested
295 2010-05-17 Marek Safar <marek.safar@gmail.com>
297 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
298 delegate.cs: Member instance is resolved after member overload
299 definitely resolves static/instance property of member expression.
300 Fixes #545047, #358848, #456605, #460016, #603299
302 2010-05-12 Marek Safar <marek.safar@gmail.com>
304 A fix for bug #604981
305 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
306 details for nested anonymous methods stories.
308 2010-05-11 Marek Safar <marek.safar@gmail.com>
310 A fix for bug #604735
311 * namespace.cs: Don't report namespace collision.
313 2010-05-11 Marek Safar <marek.safar@gmail.com>
315 A fix for bug #604748
316 * class.cs, typespec.cs: Search full imported attribute hierarchy
319 2010-05-11 Marek Safar <marek.safar@gmail.com>
321 * namespace.cs: Ignore missing dependencies failure at
324 2010-05-11 Marek Safar <marek.safar@gmail.com>
326 A fix for bug #604640
327 * namespace.cs: Don't resolve using constraints too early.
329 2010-05-11 Marek Safar <marek.safar@gmail.com>
331 A fix for bug #604239
332 * generic.cs: Copy partial type constraints to partial container.
334 2010-05-10 Marek Safar <marek.safar@gmail.com>
336 A fix for bug #557210
337 * import.cs: Relax underlying enum field rules.
339 2010-05-10 Marek Safar <marek.safar@gmail.com>
341 A fix for bug #603476
342 * property.cs: Implement IParametersMember for indexer accessors.
344 2010-05-07 Marek Safar <marek.safar@gmail.com>
346 A fix for bug #601141
347 * class.cs: Update all partial modifiers.
349 2010-05-06 Marek Safar <marek.safar@gmail.com>
351 A fix for bug #601708
352 * method.cs, membercache.cs: Destructors cannot be hidden.
354 2010-05-06 Marek Safar <marek.safar@gmail.com>
356 A fix for bug #602551
357 * class.cs: Resursive reference of type definition is allowed.
359 2010-05-06 Marek Safar <marek.safar@gmail.com>
361 * anonymous.cs: Mutate cached storey instance types too.
363 2010-05-06 Marek Safar <marek.safar@gmail.com>
365 A fix for bug #602443
366 * convert.cs: Explicit enum conversion cannot involve user operators
368 2010-05-05 Miguel de Icaza <miguel@novell.com>
370 * class.cs (TypeContainer.DefineBaseTypes)
371 (TypeContainer.CheckRecursiveDefinition): check for the iface not
372 being null, as we could have failed resolution and crashed;
375 * cs-parser.jay: Productions to catch common mistakes when other
376 punctuation operators are used instead of comma. Fixes 571702
378 2010-05-05 Marek Safar <marek.safar@gmail.com>
380 * anonymous.cs: Mutate correct set of constraints.
382 2010-05-05 Marek Safar <marek.safar@gmail.com>
384 A fix for bug #602842
385 * expression.cs: Resolve all array bound arguments.
387 2010-05-05 Marek Safar <marek.safar@gmail.com>
389 * import.cs: Don't import private fields.
391 2010-04-30 Marek Safar <marek.safar@gmail.com>
393 Partially based on patch by <sami.lamti@gmail.com>
395 * eval.cs, ecore.cs: Fixed eval show methods.
397 2010-04-30 Marek Safar <marek.safar@gmail.com>
399 * generic.cs, delegate.cs: Implement output type inference of
400 methodgroup now when the specification was cleared at least little
403 2010-04-29 Marek Safar <marek.safar@gmail.com>
405 A fix for bug #575611
406 * class.cs: Fix recursive unmanaged recursice sruct check.
408 2010-04-29 Marek Safar <marek.safar@gmail.com>
410 A fix for bug #479776
411 * expression.cs: Implement typeof unbounded nested generic types.
413 2010-04-29 Marek Safar <marek.safar@gmail.com>
415 A fix for bug #474953
416 * class.cs: Fix valid recursive base type definition.
418 2010-04-29 Marek Safar <marek.safar@gmail.com>
420 A fix for bug #421737
421 * convert.cs, expression.cs: A boxing conversion exists from a
422 nullable-type to a reference type, if a boxing conversion exists
423 from the underlying non-nullable-value-type to the reference type.
425 2010-04-29 Marek Safar <marek.safar@gmail.com>
427 A fix for bug #376875
428 * import.cs: Import volatile modifier.
430 2010-04-29 Marek Safar <marek.safar@gmail.com>
432 A fix for bug #372412
433 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
436 2010-04-29 Marek Safar <marek.safar@gmail.com>
438 A fix for bug #568955
439 * statements.cs: Handle recursive scope initializers.
441 2010-04-28 Marek Safar <marek.safar@gmail.com>
443 A fix for bug #566511
444 * anonymous.cs: Always get inflated version of hoisted variable
445 on generic type definition.
447 2010-04-28 Marek Safar <marek.safar@gmail.com>
449 * import.cs, membercache.cs: Relax rules for valid properties.
451 2010-04-28 Marek Safar <marek.safar@gmail.com>
453 * import.cs: Intern arrays used in generic arguments.
455 2010-04-28 Marek Safar <marek.safar@gmail.com>
457 A fix for bug #600398
458 * convert.cs: Actually use effective base type for the comparison.
460 2010-04-28 Marek Safar <marek.safar@gmail.com>
462 A fix for bug #600326
463 * ecore.cs: Pass arity to base member lookup.
465 2010-04-28 Marek Safar <marek.safar@gmail.com>
467 A fix for bug #573385
468 * expression.cs: MemberAccess is of generic type based on right
471 2010-05-28 Marek Safar <marek.safar@gmail.com>
473 * cs-tokenizer.cs: Made tab size configurable.
475 2010-05-27 Marek Safar <marek.safar@gmail.com>
477 * attribute.cs: Ensure Obsolete members are defined before doing
480 2010-05-27 Marek Safar <marek.safar@gmail.com>
482 * visit.cs: Add DOM visitor skeleton.
486 2010-05-27 Marek Safar <marek.safar@gmail.com>
488 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
490 2010-05-27 Marek Safar <marek.safar@gmail.com>
492 * *.cs: Major rewrite of compiler internals to better work with
493 unmodified System.Reflection.Emit. Some of the key changes are
494 - TypeSpec replaces reflection specific System.Type.
495 - All Type(TypeSpec) operations are now done in compiler therefore
496 no dependency on SRE to inflate generic members and types or to
497 query unclosed types.
498 - MemberCache is now the only and full hierarchical topology.
499 - Generic constraints are implemented properly.
500 - And as a bonus compilation is on average 30% faster.
502 2010-04-15 Jb Evain <jbevain@novell.com>
504 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
506 2010-04-12 Marek Safar <marek.safar@gmail.com>
508 * expression.cs, attribute.cs, parameter.cs: More attribute type
511 2010-04-12 Marek Safar <marek.safar@gmail.com>
513 A fix for bug #593342
515 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
516 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
517 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
518 codegen.cs: Add custom attribute encoder to deal with unfinished
519 types and easier corlib bootstrap from its own types.
521 2010-03-26 Marek Safar <marek.safar@gmail.com>
523 * cs-parser.jay: Report invalid constraint types.
525 2010-03-16 Jb Evain <jbevain@novell.com>
527 * Makefile: rename the net_2_1 profile to moonlight.
529 2010-03-11 Marek Safar <marek.safar@gmail.com>
531 * statement.cs, cs-parser.jay: Use correct location for empty
534 2010-03-11 Marek Safar <marek.safar@gmail.com>
536 * cs-parser.jay: Disable Location from expression.
538 * generic.cs: Check constraints for overrides in the parser.
540 2010-03-09 Marek Safar <marek.safar@gmail.com>
542 * cs-parser.jay (GetLocation): Use an expression when available.
544 2010-03-04 Marek Safar <marek.safar@gmail.com>
546 A fix for bug #582579
547 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
549 2010-03-04 Marek Safar <marek.safar@gmail.com>
551 A patch by kornelpal@gmail.com
553 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
554 compiler generated classes sealed by default. Emit and close top
555 level compiler generated classes as well.
557 * support.cs: Use RuntimeHelpers.GetHashCode.
559 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
561 * Makefile: We need to use the internal bootstrapping gmcs for
562 net_2_1_bootstrap too now.
564 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
566 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
568 2010-03-02 Marek Safar <marek.safar@gmail.com>
570 * cs-tokenizer.cs: Missed few locations in previous fix.
572 2010-03-02 Marek Safar <marek.safar@gmail.com>
574 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
575 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
576 Report correct location for operator errors.
578 2010-03-02 Marek Safar <marek.safar@gmail.com>
580 * typemanager.cs (IsDynamicType): Don't check external types when
581 the attribute is not external.
583 2010-02-24 Marek Safar <marek.safar@gmail.com>
585 A fix for bug #582579
586 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
589 2010-02-24 Marek Safar <marek.safar@gmail.com>
591 A fix for bug #581804
592 * ecore.cs: Fixed type comparison.
594 2010-02-08 Miguel de Icaza <miguel@novell.com>
596 * namespace.cs (CompletionGetTypesStartingWith): Do not include
597 private types in the completion results.
599 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
602 2010-02-17 Marek Safar <marek.safar@gmail.com>
604 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
607 2010-02-14 Miguel de Icaza <miguel@novell.com>
609 * eval.cs: Do not do the report printer dance unless the user has
610 set the DescribeTypes feature.
612 2010-02-10 Marek Safar <marek.safar@gmail.com>
614 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
616 2010-02-08 Marek Safar <marek.safar@gmail.com>
618 A fix for bug #577029
619 * anonymous.cs: Fixed TypeBuilder* check.
621 2010-02-06 Miguel de Icaza <miguel@novell.com>
623 * eval.cs (CompileBlock): Also undo if there are problems during
624 semantic analysis, fixes various cases where invalid C# code would
625 be reported, but the internal changes would not be undone.
627 2010-02-03 Miguel de Icaza <miguel@novell.com>
629 * driver.cs: Change the --fatal flag to allow a number to be
630 passed, this ignores the first N fatal errors. Useful to debug
631 errors that do not happen on the first hit.
633 * cs-parser.jay (invocation_expression): accept both the
634 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
635 inside an invocation.
637 * driver.cs: Expose FatalErrors.
639 * eval.cs: Initialize the printer's Fatal property from the
640 Driver's FatalError flag, this allows csharp --fatal to work
643 Add support for calling Describe (typeof (TYPE)) if the expression
646 2010-02-02 Marek Safar <marek.safar@gmail.com>
648 A fix for bug #574991
649 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
652 2010-02-02 Marek Safar <marek.safar@gmail.com>
654 A fix for bug #575986
655 * expression.cs: Don't mutate typeof type definitions.
657 2010-01-28 Marek Safar <marek.safar@gmail.com>
659 * decl.cs: Use only one set of modifiers.
661 2010-01-26 Marek Safar <marek.safar@gmail.com>
663 A fix for bug #573329
664 * eval.cs: Don't disable error reporting completely on silent mode.
666 2010-01-25 Marek Safar <marek.safar@gmail.com>
668 A fix for bug #573312
669 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
670 pointer index of unknown size types greater than 2.
672 2010-01-15 Marek Safar <marek.safar@gmail.com>
674 * *.cs: Use only 1 member kind enum.
676 2010-01-15 Marek Safar <marek.safar@gmail.com>
678 * *.cs: Add event specification.
680 2010-01-14 Marek Safar <marek.safar@gmail.com>
682 * membercache.cs: Extracted from decl.cs.
684 * *.cs: Put more infrastructure in place.
686 2010-01-13 Marek Safar <marek.safar@gmail.com>
688 * *.cs: Add property specification, unused yet.
690 2010-01-13 Marek Safar <marek.safar@gmail.com>
692 * property.cs: Move all property based declarations into a new file.
694 2010-01-13 Marek Safar <marek.safar at gmail.com>
696 * expression.cs (Conditional): Resolve reduced expression.
698 2010-01-13 Marek Safar <marek.safar at gmail.com>
700 * *.cs: Introduced non-generic method specification.
702 2010-01-07 Marek Safar <marek.safar@gmail.com>
704 * method.cs: Move all method based declarations into a new file.
706 2010-01-07 Marek Safar <marek.safar@gmail.com>
708 * *.cs: Extract field specification.
710 2009-12-17 Marek Safar <marek.safar@gmail.com>
712 * field.cs: Extracted from class.cs
714 2009-12-15 Marek Safar <marek.safar@gmail.com>
716 * attribute.cs (GetFixedBuffer): Work on field definition only.
718 2009-12-15 Marek Safar <marek.safar@gmail.com>
720 * *.cs: Clean up NET_4_0 conditional where possible.
722 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
724 support.cs (DynamicType): Assembly property returns the assembly builder.
725 This is required due to how compiler context works in corlib.
727 2009-12-14 Marek Safar <marek.safar@gmail.com>
729 A fix for bug #564376
730 * assign.cs (LocalTemporary): Removed no longer needed special
733 2009-12-11 Marek Safar <marek.safar@gmail.com>
735 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
736 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
737 enum for easier debugging.
739 2009-12-10 Marek Safar <marek.safar@gmail.com>
741 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
744 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
747 2009-12-10 Marek Safar <marek.safar@gmail.com>
749 * cs-parser.jay, statement.cs: Handle parser error in code
752 2009-12-10 Marek Safar <marek.safar@gmail.com>
754 * ecore.cs: Ignore base imported methods when they are already
757 * eval.cs: Handle non-existent keys.
759 * report.cs, driver.cs: Make fatal work with console printer only.
761 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
763 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
765 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
767 * typemanager.cs: Add MakeGenericMethod that checks if the method
768 is really the generic method definition.
770 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
771 to inflate generic methods.
773 2009-12-08 Marek Safar <marek.safar@gmail.com>
775 A fix for bug #561149
776 * anonymous.cs: Use actual type parameters when checking for generic
779 2009-12-08 Marek Safar <marek.safar@gmail.com>
781 A fix for bug #561369
782 * expression.cs (DoNumericPromotion): Fixed typo.
784 2009-12-08 Marek Safar <marek.safar@gmail.com>
786 *.cs: Moving to generics world.
788 cs-parser.jay: Removed current_array_type.
790 2009-12-07 Marek Safar <marek.safar@gmail.com>
792 *.cs: Moving to generics world.
794 2009-12-04 Marek Safar <marek.safar@gmail.com>
796 *.cs: Moving to generics world (day 2).
798 2009-12-03 Marek Safar <marek.safar@gmail.com>
800 *.cs: Moving to generics world.
802 2009-12-02 Marek Safar <marek.safar@gmail.com>
804 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
805 Encode dynamic type attribute for elements where attributes cannot
808 2009-12-01 Marek Safar <marek.safar@gmail.com>
810 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
813 2009-12-01 Marek Safar <marek.safar@gmail.com>
815 A fix for bug #360455
816 * class.cs: Never report a unused warning for generic events to
817 workaround wrong expression type.
819 2009-11-30 Marek Safar <marek.safar@gmail.com>
821 A fix for bug #558305
822 * decl.cs, class.cs: Check partial method definitions using correct
825 2009-11-30 Marek Safar <marek.safar@gmail.com>
827 * argument.cs: Don't cache rarely used dynamic flag.
829 2009-11-27 Marek Safar <marek.safar@gmail.com>
831 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
833 2009-11-27 Marek Safar <marek.safar@gmail.com>
835 * ecore.cs (SimpleName): Removed no longer needed in_transit as
836 Resolve is now non-reentrant (saves ~0.6MB for corlib).
838 2009-11-26 Marek Safar <marek.safar@gmail.com>
840 A fix for bug #545081
841 * decl.cs: Check private nested types of nested types recursively.
843 2009-11-26 Marek Safar <marek.safar@gmail.com>
845 A fix for bug #558305
846 * location.cs: Ignore self referencing #line directive
848 2009-11-26 Marek Safar <marek.safar@gmail.com>
850 A fix for bug #558292
851 * class.cs: Allow single unsafe fixed buffer fields.
853 2009-11-26 Marek Safar <marek.safar@gmail.com>
855 * expression: Optimize few more zero-based operations.
857 2009-11-26 Marek Safar <marek.safar@gmail.com>
859 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
860 avoids boxing of literal values.
862 2009-11-26 Marek Safar <marek.safar@gmail.com>
864 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
865 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
866 codegen.cs: LocatedToken redesing to avoid excessive allocation and
867 boxing (saves ~7MB for corlib). Also fixes presise token location.
869 2009-11-25 Marek Safar <marek.safar@gmail.com>
871 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
874 2009-11-24 Marek Safar <marek.safar@gmail.com>
876 * expression.cs: Lower static array initializer barrier.
878 * support.cs, driver.cs: Share reader buffer.
880 2009-11-23 Marek Safar <marek.safar@gmail.com>
882 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
884 2009-11-23 Marek Safar <marek.safar@gmail.com>
886 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
887 cleanup some obsolete code.
889 2009-11-20 Marek Safar <marek.safar@gmail.com>
891 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
894 2009-11-20 Marek Safar <marek.safar@gmail.com>
896 * *.cs: Resolved expressions are never resolved again, this helps to
897 uncover some not easy to find bugs and improve the performance.
899 2009-11-19 Marek Safar <marek.safar@gmail.com>
901 * *.cs: Made constant expressions fully compatible with any other
904 2009-11-19 Marek Safar <marek.safar@gmail.com>
906 * *.cs: DoResolve is a worker method and has to be protected.
908 2009-11-18 Marek Safar <marek.safar@gmail.com>
910 * *.cs: More context specific handling.
912 2009-11-17 Marek Safar <marek.safar@gmail.com>
914 * *.cs: More context specific handling.
916 2009-11-16 Marek Safar <marek.safar@gmail.com>
918 * dynamic.cs, class.cs: Removed few fixed user types conversions.
920 * symbolwriter.cs: Uses public ILOffset.
922 2009-11-13 Marek Safar <marek.safar@gmail.com>
924 A fix for bug #553650
925 * generic.cs: Another missing TypeToCoreType, still too many to fix.
927 2009-11-13 Marek Safar <marek.safar@gmail.com>
929 A fix for bug #555170
931 * class.cs, delegate.cs, enum.cs: Constants have to be available
932 for parameters resolve.
934 2009-11-12 Marek Safar <marek.safar@gmail.com>
936 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
939 2009-11-12 Marek Safar <marek.safar@gmail.com>
941 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
942 with a statically known candidate set.
944 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
946 * generic.cs: Made type inflation for generic constraint checks
947 recursive. This fixes BGO #553655.
949 2009-11-11 Marek Safar <marek.safar@gmail.com>
951 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
954 2009-11-10 Marek Safar <marek.safar@gmail.com>
956 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
957 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
958 attribute.cs: Add some dynamic error checking.
960 2009-11-07 Marek Safar <marek.safar@gmail.com>
962 A fix for bug #553465
964 * expression.cs: Fixed mixed version of expression tree anonymous
967 2009-11-06 Marek Safar <marek.safar@gmail.com>
969 A fix for bug #553031
971 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
972 expression tree version of anonymous type with members declaration.
974 2009-11-05 Marek Safar <marek.safar@gmail.com>
976 * parameter.cs: Handle nullable parameter default expression.
978 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
979 class.cs, attribute.cs: Check for wrong dynamic arguments.
981 2009-11-05 Marek Safar <marek.safar@gmail.com>
983 * statement.cs: Dynamic statements.
985 2009-11-04 Marek Safar <marek.safar@gmail.com>
987 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
988 Compound assignments over dynamic type.
990 2009-11-03 Marek Safar <marek.safar@gmail.com>
992 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
993 constructor arguments.
995 2009-10-30 Marek Safar <marek.safar@gmail.com>
997 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
998 codegen.cs: Unary mutator on dynamic member access expression.
1000 2009-10-29 Marek Safar <marek.safar@gmail.com>
1002 A fix for bug #550580
1003 * convert.cs: Don't eliminate explicit precission casts.
1005 2009-10-28 Marek Safar <marek.safar@gmail.com>
1007 A fix for bug #550404
1009 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
1010 expression.cs, statement.cs, ecore.cs: Quote any nested expression
1013 2009-10-27 Marek Safar <marek.safar@gmail.com>
1015 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
1018 * class.cs: Allow nullable binary user operators.
1020 2009-10-26 Marek Safar <marek.safar@gmail.com>
1022 * expression.cs: Move binary expression optimization at the end of
1025 2009-10-23 Marek Safar <marek.safar@gmail.com>
1027 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
1028 Separate NullConstant from NullLiteral.
1030 2009-10-23 Marek Safar <marek.safar@gmail.com>
1032 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
1033 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
1034 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
1035 ModuleContainer. Add common unclosed member check routine.
1037 2009-10-22 Marek Safar <marek.safar@gmail.com>
1039 * argument.cs: Use literal flag for real literals only.
1041 * dynamic.cs: Use correct return type for custom delegates.
1043 2009-10-22 Marek Safar <marek.safar@gmail.com>
1045 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
1048 2009-10-22 Marek Safar <marek.safar@gmail.com>
1050 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
1052 2009-10-21 Marek Safar <marek.safar@gmail.com>
1054 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
1057 2009-10-21 Marek Safar <marek.safar@gmail.com>
1059 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
1062 2009-10-20 Marek Safar <marek.safar@gmail.com>
1064 * argument.cs, dynamic.cs, expression.cs: Latest API update.
1066 2009-10-19 Marek Safar <marek.safar@gmail.com>
1068 * typemanager.cs, expression.cs: Dynamic array initializer.
1070 2009-10-16 Marek Safar <marek.safar@gmail.com>
1072 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
1075 2009-10-16 Marek Safar <marek.safar@gmail.com>
1077 A fix for bug #493523, #507067
1078 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
1079 standard nullable conversion using underlying standard conversion
1080 and not full conversion.
1082 2009-10-15 Marek Safar <marek.safar@gmail.com>
1084 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
1085 type in VerifyArgumentsCompat.
1087 2009-10-15 Marek Safar <marek.safar@gmail.com>
1089 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1090 Reject variable used with type arguments.
1092 2009-10-14 Marek Safar <marek.safar@gmail.com>
1094 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
1095 Implement dynamic expressions assignment.
1097 2009-10-14 Marek Safar <marek.safar@gmail.com>
1099 * expression.cs: Build underlying expression when resolving unary
1102 2009-10-14 Marek Safar <marek.safar@gmail.com>
1104 * expression.cs: Emit enum array initializer using binary blob.
1106 2009-10-08 Marek Safar <marek.safar@gmail.com>
1108 * typemanager.cs, constant.cs: Optimize decimal constants which fit
1111 2009-10-07 Marek Safar <marek.safar@gmail.com>
1113 * typemanager.cs: Reset object_type.
1115 * assign: Made SimpleAssign public.
1117 2009-10-06 Marek Safar <marek.safar@gmail.com>
1119 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
1120 invocation assembly to IsThisOrFriendAssembly.
1122 2009-10-05 Marek Safar <marek.safar@gmail.com>
1124 * expression.cs: Equality comparison of generic parameter with
1127 2009-10-05 Marek Safar <marek.safar@gmail.com>
1129 A fix for bug #543570
1130 * generic.cs: Import predefined constraints correctly.
1132 2009-10-02 Marek Safar <marek.safar@gmail.com>
1134 * ecore.cs: Don't crash on overloads with optional paremeters where
1135 arguments count overflows.
1137 * parameter.cs: Import optional parameter constants using optional
1140 2009-10-01 Marek Safar <marek.safar@gmail.com>
1142 * Makefile: Default is gmcs compiler.
1144 2009-10-01 Marek Safar <marek.safar@gmail.com>
1146 * cs-parser.jay: Fixed few NRE.
1148 2009-10-01 Marek Safar <marek.safar@gmail.com>
1150 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
1152 2009-09-30 Marek Safar <marek.safar@gmail.com>
1154 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
1155 ShimExpression, ImplicitCast.
1157 2009-09-30 Marek Safar <marek.safar@gmail.com>
1159 A fix for bug #542959
1160 * delegate.cs: Emit correct delegate instance variable when there
1161 are static and non-static overloads.
1163 2009-09-29 Marek Safar <marek.safar@gmail.com>
1165 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
1166 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
1168 2009-09-28 Marek Safar <marek.safar@gmail.com>
1170 A fix for bug #542487
1171 * ecore.cs: Resolve extension methods hidden by properties.
1173 2009-09-25 Marek Safar <marek.safar@gmail.com>
1175 * expression.cs, ecore.cs: More dynamic binary expressions.
1177 2009-09-22 Marek Safar <marek.safar@gmail.com>
1179 * nullable.cs, expression.cs: Fixed null lifted conversion for
1180 bitwise enum operations.
1182 2009-09-22 Marek Safar <marek.safar@gmail.com>
1184 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
1185 values in checked context.
1187 2009-09-22 Marek Safar <marek.safar@gmail.com>
1189 * expression.cs, ecore.cs: Fixed array index constant conversion.
1191 2009-09-20 Miguel de Icaza <miguel@novell.com>
1193 * expression.cs: Do not crash when MemberLookup returns something
1194 that is not a MemberExpr here. Report error 582 instead.
1198 2009-09-18 Marek Safar <marek.safar@gmail.com>
1200 * decl.cs, class.cs: Check protected property accessors.
1202 2009-09-18 Marek Safar <marek.safar@gmail.com>
1204 * dynamic.cs, assign.cs: Dynamic compound assignment.
1206 2009-09-17 Marek Safar <marek.safar@gmail.com>
1208 * expression.cs: Fixed compound assignment explicit conversion.
1210 2009-09-17 Marek Safar <marek.safar@gmail.com>
1212 * expression.cs, ecore.cs: Cannot infer variables from method group.
1214 2009-09-16 Marek Safar <marek.safar@gmail.com>
1216 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
1217 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
1218 codegen.cs: Dynamic binary operations scaffolding.
1220 2009-09-15 Marek Safar <marek.safar@gmail.com>
1222 * expression.cs: Fixes nullable promotion for enum type variables.
1224 2009-09-11 Marek Safar <marek.safar@gmail.com>
1226 * driver.cs, dynamic.cs: Reset more static variables.
1228 2009-09-11 Marek Safar <marek.safar@gmail.com>
1230 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1231 driver.cs: Introduced Expression::MakeExpression.
1233 2009-09-11 Marek Safar <marek.safar@gmail.com>
1235 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1237 2009-09-09 Marek Safar <marek.safar@gmail.com>
1239 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1242 2009-09-09 Marek Safar <marek.safar@gmail.com>
1244 A fix for bug #518707
1245 * expression.cs (Is): Optimize only generic parameter type
1246 expression probing value type generic parameter.
1248 2009-09-09 Marek Safar <marek.safar@gmail.com>
1250 A fix for bug #532571
1251 * ecore.cs: Check for simple name type arguments used with
1254 2009-09-08 Marek Safar <marek.safar@gmail.com>
1256 A fix for bug #497421
1257 * generic.cs (CheckConstraint): Don't use buildin types to check for
1258 parameterless constructor.
1260 2009-09-08 Marek Safar <marek.safar@gmail.com>
1262 A fix for bug #537402
1263 * generic.cs (CheckConstraint): Correctly inflate generic type
1264 arguments when checking generic method.
1266 2009-09-08 Marek Safar <marek.safar@gmail.com>
1268 A fix for bug #536463
1269 * decl.cs (AddToContainer): Don't report collision between explicit
1270 and parameterless non-explicit members.
1272 2009-09-08 Marek Safar <marek.safar@gmail.com>
1274 * eval.cs: Reset more static stuff.
1276 2009-09-07 Marek Safar <marek.safar@gmail.com>
1278 A fix for bug #324625
1279 * expression.cs, ecore.cs: Create nested generic type expression
1280 using declaring and not current type.
1282 2009-09-07 Marek Safar <marek.safar@gmail.com>
1284 * *.cs: Changed Report class to accept various output printers and
1285 be an instance class. An expression resolver can now use different
1286 message reporter for each call and Report.Error can safely throw
1287 an exception. Part of ongoing work to turn mcs into proper library.
1289 2009-09-04 Marek Safar <marek.safar@gmail.com>
1291 * statement.cs, ecore.cs: Removed error reporting from emit code.
1293 2009-09-04 Marek Safar <marek.safar@gmail.com>
1295 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1297 2009-09-03 Marek Safar <marek.safar@gmail.com>
1299 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1300 parser checks out of constructors.
1302 2009-09-02 Marek Safar <marek.safar@gmail.com>
1304 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1306 2009-09-02 Marek Safar <marek.safar@gmail.com>
1308 A fix for bug #535448
1309 * anonymous.cs, class.cs: Copy return label between all contexts.
1311 2009-09-02 Marek Safar <marek.safar@gmail.com>
1313 A fix for bug #535395
1314 * namespace.cs: Resolve context can be null.
1316 2009-08-25 Marek Safar <marek.safar@gmail.com>
1318 A fix for bug #533912
1319 * generic.cs: Use correct context for constraints resolving.
1321 2009-08-25 Marek Safar <marek.safar@gmail.com>
1323 A fix for bug #532630
1324 * driver.cs: Trim conditional symbols.
1326 2009-08-25 Marek Safar <marek.safar@gmail.com>
1328 * context.cs: New file.
1330 * *.exe.sources, *.csproj: Updated.
1332 2009-08-25 Marek Safar <marek.safar@gmail.com>
1334 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1335 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1336 IMembercontext, some small cleanups.
1338 2009-08-24 Marek Safar <marek.safar@gmail.com>
1340 * *.cs: Split ResolveContext and EmitContext.
1342 2009-08-24 Marek Safar <marek.safar@gmail.com>
1344 * *.cs: Only ResolveContext implements IMemberContext.
1346 2009-08-21 Marek Safar <marek.safar@gmail.com>
1348 * *.cs: Renamed IResolveContext to IMemberContext.
1350 2009-08-21 Marek Safar <marek.safar@gmail.com>
1352 * *.cs: Detached ResolveContext from EmitContext.
1354 2009-08-21 Marek Safar <marek.safar@gmail.com>
1356 * codegen.cs: Moved flow-analysis to BlockContext.
1358 2009-08-21 Marek Safar <marek.safar@gmail.com>
1360 * *.cs: Detached BlockContext from EmitContext.
1362 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1364 * statement.cs: avoid nullref when the return value of GetEnumerator()
1365 does not contain any MoveNext() method.
1367 2009-08-19 Marek Safar <marek.safar@gmail.com>
1369 * *.cs: Removed IResolveContext::GenericDeclContainer.
1371 2009-08-19 Marek Safar <marek.safar@gmail.com>
1373 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1375 2009-08-19 Marek Safar <marek.safar@gmail.com>
1377 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1378 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1380 2009-08-18 Marek Safar <marek.safar@gmail.com>
1382 * *.cs: Removed boolean fields from EmitContext.
1384 2009-08-18 Marek Safar <marek.safar@gmail.com>
1386 * *.cs: Add IResolveContext::IsStatic.
1388 2009-08-18 Marek Safar <marek.safar@gmail.com>
1390 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1392 2009-08-17 Marek Safar <marek.safar@gmail.com>
1394 * *.cs: Removed DeclContainer from EmitContext.
1396 2009-08-17 Marek Safar <marek.safar@gmail.com>
1398 * *.cs: Add IResolveContext::CurrentTypeParameters.
1400 2009-08-14 Marek Safar <marek.safar@gmail.com>
1402 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1404 2009-08-14 Marek Safar <marek.safar@gmail.com>
1406 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1407 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1409 2009-08-13 Marek Safar <marek.safar@gmail.com>
1411 * decl.cs: Look in PartialContainer for parent type parameters.
1413 2009-08-13 Marek Safar <marek.safar@gmail.com>
1415 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1416 codegen.cs: Add IResolveContext::LookupTypeParameter.
1418 2009-08-13 Marek Safar <marek.safar@gmail.com>
1420 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1421 Moved resolved logic from Emit to Resolve.
1423 2009-08-13 Marek Safar <marek.safar@gmail.com>
1425 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1426 codegen.cs: Reworked atttributes handling of ResolveContext.
1428 2009-08-12 Marek Safar <marek.safar@gmail.com>
1430 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1431 LookupNamespaceOrType to ResolveContext.
1433 2009-08-12 Marek Safar <marek.safar@gmail.com>
1435 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1436 class.cs: Removed unused parameters and methods.
1438 2009-08-11 Marek Safar <marek.safar@gmail.com>
1440 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1441 codegen.cs: Finding the best common type of a set of expressions for
1444 2009-08-07 Marek Safar <marek.safar@gmail.com>
1446 * dynamic.cs, expression.cs: More dynamic conversions.
1448 2009-08-06 Miguel de Icaza <miguel@novell.com>
1450 * generic.cs: This loop was incorrect, it was increment ii, but
1451 checking for `i'. This was a change introduced to fix #327497,
1454 * class.cs: Catch another case for cs0533 error, fixes #324782.
1456 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1458 * typemanager.cs (GetGenericArguments): SRE returns null for
1459 generic methods on type builder instances if they are not generic
1460 themselves. For example, for Foo<int>::Bar() it returns null, but
1461 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1463 2009-08-05 Marek Safar <marek.safar@gmail.com>
1465 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1466 delegate.cs: Work on dynamic binding.
1468 2009-08-04 Marek Safar <marek.safar@gmail.com>
1470 A second fix for bug #525342
1471 * class.cs: Attach partial method attributes to method
1474 2009-08-03 Marek Safar <marek.safar@gmail.com>
1476 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1479 * rootcontext.cs: Default to langversion v4.
1481 2009-08-03 Marek Safar <marek.safar@gmail.com>
1483 * pending.cs: Check return type before member info is set.
1485 2009-08-03 Marek Safar <marek.safar@gmail.com>
1487 * anonymous.cs: Fully initialize generic hoisted field expression.
1489 2009-08-02 Miguel de Icaza <miguel@novell.com>
1491 * cs-parser.jay: Flag variables declared on the interactive shell
1492 as used to prevent the 168 warning about local variable not being
1495 2009-07-31 Marek Safar <marek.safar@gmail.com>
1497 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1498 attribute.cs: Emit dynamic export attribute.
1500 2009-07-30 Marek Safar <marek.safar@gmail.com>
1502 * expression.cs: More verifier work.
1504 2009-07-29 Marek Safar <marek.safar@gmail.com>
1506 * nullable.cs: Fixed SRE crash during corlib compilation.
1508 2009-07-29 Marek Safar <marek.safar@gmail.com>
1510 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1511 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1512 More TypeManager.TypeToCoreType needed.
1514 2009-07-29 Marek Safar <marek.safar@gmail.com>
1516 * anonymous.cs: Update after recent SRE fixes.
1518 2009-07-28 Marek Safar <marek.safar@gmail.com>
1520 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1521 version of GetFieldHandle for fields of generic types.
1523 2009-07-27 Marek Safar <marek.safar@gmail.com>
1525 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1526 ecore.cs: Add TypeManager.IsDynamicType,
1527 PredefinedAttributes.Dynamic.
1529 2009-07-27 Marek Safar <marek.safar@gmail.com>
1531 A fix for bug #415375
1532 * expression.cs: Fixed object and reference type parameter
1535 2009-07-27 Marek Safar <marek.safar@gmail.com>
1537 A fix for bug #525342
1538 * class.cs: Attach partial method attributes to method
1541 2009-07-24 Marek Safar <marek.safar@gmail.com>
1543 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1546 2009-07-24 Marek Safar <marek.safar@gmail.com>
1548 * anonymous.cs (MutateField): Add imported types handling.
1550 2009-07-23 Marek Safar <marek.safar@gmail.com>
1552 * expression.cs, delegate.cs: Moved arguments resolve into their
1553 counterparts expressions. Removed argument resolve from
1554 CollectionElementInitializer.
1556 2009-07-23 Marek Safar <marek.safar@gmail.com>
1558 A fix for bug #523683
1559 * convert.cs, delegate.cs: Use common overload mechanism for method
1560 group conversion check.
1562 2009-07-22 Marek Safar <marek.safar@gmail.com>
1564 A fix for bug #523899
1565 * generics.cs: Exact type inference with other bound types.
1567 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1569 Don't complain when the same type is implemented by the output
1570 assembly as well as multiple referenced assemblies
1571 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1572 'must_be_unique' flag.
1573 (GlobalRootNamespace): Update to changes.
1574 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1575 already have a type in hand.
1577 2009-07-22 Marek Safar <marek.safar@gmail.com>
1579 * expression.cs: More verifier instrumentation.
1581 * statement.cs: Do proper throw expression conversion.
1583 2009-07-22 Marek Safar <marek.safar@gmail.com>
1585 A fix for bug #522789
1586 * expression.cs: Mutate invocation return type.
1588 2009-07-16 Marek Safar <marek.safar@gmail.com>
1590 * anonymous.cs: Split assignable and readonly generated variable
1593 2009-07-16 Marek Safar <marek.safar@gmail.com>
1595 A fix for bug #521671
1596 * statement.cs: Fixed crash when checking missing type.
1598 2009-07-16 Marek Safar <marek.safar@gmail.com>
1600 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1601 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1602 class.cs, driver.cs: Work on dynamic binding.
1604 * dynamic.cs: New file.
1606 * *.sources, *.proj: Updated.
1608 2009-07-15 Marek Safar <marek.safar@gmail.com>
1610 * expression.cs (Conditional): Avoid double Resolve.
1612 2009-07-13 Marcus Griep <marcus@griep.us>
1614 * ecore.cs: Fix obscure bug with resolving members of interfaces
1615 that hide parent interface members. Fixes bug #444388 and corrects
1618 2009-07-13 Marek Safar <marek.safar@gmail.com>
1620 * expression.cs (LocalVariableReference): Bounce resolve.
1622 2009-07-10 Marek Safar <marek.safar@gmail.com>
1624 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1625 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1628 * support.cs: New dynamic type wrapper.
1630 2009-07-08 Marek Safar <marek.safar@gmail.com>
1632 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1633 typed local variable.
1635 2009-07-06 Marek Safar <marek.safar@gmail.com>
1637 A fix for bug #519005
1638 * anonymous.cs: Use null_type as no return type placeholder.
1640 2009-07-02 Marek Safar <marek.safar@gmail.com>
1642 * generic.cs: Handle type inference of identical type parameters
1643 with different bounds.
1645 2009-07-01 Marek Safar <marek.safar@gmail.com>
1647 * expression.cs, class.cs: Events variance.
1649 * cs-parser.jay: Interface events error messages.
1651 2009-07-01 Marek Safar <marek.safar@gmail.com>
1653 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1655 2009-06-29 Marek Safar <marek.safar@gmail.com>
1657 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1658 parameter expression can be value-type New.
1660 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1662 2009-06-26 Marek Safar <marek.safar@gmail.com>
1664 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1665 Implemented C# 4.0 named arguments.
1667 2009-06-24 Marek Safar <marek.safar@gmail.com>
1669 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1670 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1671 parameter modifier. Also fixes bug #515497.
1673 2009-06-24 Marek Safar <marek.safar@gmail.com>
1675 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1676 arguments expression to be implemented.
1678 *.sources: Add argument.cs
1680 2009-06-23 Marek Safar <marek.safar@gmail.com>
1682 * parameter.cs: Moved GetParameterIndexByName to base class.
1684 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1685 unused AType. Use argument's version of GetExpressionTree.
1687 2009-06-22 Marek Safar <marek.safar@gmail.com>
1689 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1692 2009-06-17 Marek Safar <marek.safar@gmail.com>
1694 A fix for bug #514096
1695 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1697 2009-06-17 Marek Safar <marek.safar@gmail.com>
1699 * expression.cs: The first multi-dimensional array nested array
1700 initializers was not checked.
1702 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1704 2009-06-17 Marek Safar <marek.safar@gmail.com>
1706 A fix for bug #513400
1707 * nullable.cs (EmitEquality): Operands emit could be simplified for
1708 built-in types when we now emit user operators differently.
1710 2009-06-16 Marek Safar <marek.safar@gmail.com>
1712 * ecore.cs: Report inaccessible delegate methods correctly.
1714 2009-06-16 Marek Safar <marek.safar@gmail.com>
1716 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1717 cs-parser.jay: Implemented C# 4.0 optional parameters.
1719 2009-06-16 Marek Safar <marek.safar@gmail.com>
1721 * driver.cs: Removed broken DefineManifestResource.
1723 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1725 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1726 Use $(BOOTSTRAP_PROFILE) instead.
1728 2009-06-12 Jb Evain <jbevain@novell.com>
1730 * rootcontext.cs: add a Platform field.
1731 * driver.cs: handle /platform.
1732 * codegen.cs: pass the proper flags according to
1733 the platform when saving the assembly.
1735 2009-06-11 Marek Safar <marek.safar@gmail.com>
1737 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1738 Add optional parameters grammar.
1740 2009-06-10 Marek Safar <marek.safar@gmail.com>
1742 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1743 driver.cs: Split lang version and metadata version.
1745 2009-06-10 Marek Safar <marek.safar@gmail.com>
1747 * decl.cs: Better overload ctor collision error message.
1749 2009-06-05 Jb Evain <jbevain@novell.com>
1751 * driver.cs (EmbededResource): avoid using an internal method
1752 in gmcs to embed manifest resources.
1754 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1756 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1757 the compiler from older mono versions (like moon's bots)
1759 2009-06-04 Marek Safar <marek.safar@gmail.com>
1761 * namespace.cs (LookupTypeReflection): Ignore collisions between
1764 2009-06-04 Marek Safar <marek.safar@gmail.com>
1766 * codegen.cs: Enabled generic type forwarders.
1768 2009-06-04 Marek Safar <marek.safar@gmail.com>
1770 * dmcs.*: Add another version of SRE compiler.
1772 2009-06-03 Marek Safar <marek.safar@gmail.com>
1774 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1775 generic-mcs.cs: Fixed variant type conversions.
1777 2009-06-02 Marek Safar <marek.safar@gmail.com>
1779 A fix for bug #507863
1780 * codegen.cs: Fixes a crash on invalid string value attribute.
1782 2009-06-01 Marek Safar <marek.safar@gmail.com>
1784 A fix for bug #508334
1785 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1786 cs-parser.jay: Fully import __arglist modifier.
1788 2009-05-29 Marek Safar <marek.safar@gmail.com>
1790 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1791 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1792 actually work with closed generic types.
1794 2009-05-27 Alan McGovern <amcgovern@novell.com>
1796 * class.cs, decl.cs, delegate.cs, parameter.cs:
1797 Fix the build by replacing the use of 'var' with the actual type.
1799 2009-05-27 Marek Safar <marek.safar@gmail.com>
1801 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1802 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1805 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1808 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1809 Marek Safar <marek.safar@gmail.com>
1811 A fix for bug #377509
1812 * parameter.cs: Use predefined and not empty name for implicit
1815 2009-05-21 Marek Safar <marek.safar@gmail.com>
1817 * class.cs: Don't report wrong warnings for event fields.
1819 2009-05-21 Marek Safar <marek.safar@gmail.com>
1821 A fix for bug #504667
1822 * class.cs: Check for static class using parent container instead of
1825 2009-05-08 Marek Safar <marek.safar@gmail.com>
1827 A fix for bug #496922
1828 * expression.cs: Always use temporary variable when using object
1831 2009-04-28 Marek Safar <marek.safar@gmail.com>
1833 A fix for bug #495112
1834 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1837 2009-04-27 Miguel de Icaza <miguel@novell.com>
1839 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1841 2009-04-24 Miguel de Icaza <miguel@novell.com>
1843 * complete.cs: No idea how gonzalo got a null in the list, but
1846 2009-04-24 Miguel de Icaza <miguel@novell.com>
1848 * complete.cs (CompletionElementInitializer): New completion class
1849 to support completing inside a C# 3 element initializer, so this
1850 allows completion for Silverlight situations where it is very
1853 new TextBlock () { Fo<TAB>
1855 (CompletionSimpleName): Expose the prefix that was
1856 passed to the simple name.
1858 * cs-parser.jay (object_or_collection_initializer): Add support
1859 for element_initializers.
1861 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1862 special case completion expressions as this method aggressively
1863 collects data before it operates, and errors were being thrown
1864 earlier than we were able to complete.
1866 2009-04-23 Miguel de Icaza <miguel@novell.com>
1868 * eval.cs: Make getcompletions silent and enable debugging output
1869 if the -v option is passed.
1871 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1872 Consider looking up the namespace that matches the prefix being
1875 This is part of the support for allowing completions like:
1876 `System.Co<TAB>' to complete to System.Console.
1878 * complete.cs (CompletionSimpleName.AppendResults): Make this
1881 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1883 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1884 COMPLETE_COMPLETION as internal.
1886 2009-04-17 Miguel de Icaza <miguel@novell.com>
1888 * complete.cs: Include namespace resolution in simple names as
1889 well as global types and types in the using scope in the
1892 * namespace.cs: Supporting infrastrcture to provide completions
1893 based on the current using scope.
1895 * eval.cs: Introduce an entry point that allows for initialization
1896 to return a list of the files passed on the command line.
1898 2009-04-14 Marek Safar <marek.safar@gmail.com>
1900 A fix for bug #494243
1901 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1903 2009-04-13 Marek Safar <marek.safar@gmail.com>
1905 A fix for bug #493887
1906 * statement.cs: Don't skip string multi-section with default or
1907 null label when populating string hashtable.
1909 2009-04-06 Marek Safar <marek.safar@gmail.com>
1911 A fix for bug #492329
1912 * expression.cs (New): Load variable when assigning type parameter
1915 2009-04-06 Marek Safar <marek.safar@gmail.com>
1917 A fix for bug #488960
1918 * decl.cs: Compare MVAR types using non-null values.
1920 2009-03-27 Marek Safar <marek.safar@gmail.com>
1922 * typemanager.cs, expression.cs: Removed unused nullable checks.
1924 2009-03-27 Marek Safar <marek.safar@gmail.com>
1926 * *.cs: Removed some gmcs conditionals.
1928 2009-03-26 Marek Safar <marek.safar@gmail.com>
1930 * generic.cs, support.cs: Moved generics stuff out of support.cs
1932 2009-03-24 Marek Safar <marek.safar@gmail.com>
1934 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1937 2009-03-23 Marek Safar <marek.safar@gmail.com>
1939 * attribute.cs: Consider all members for error reporting when
1940 checking named arguments.
1942 2009-03-23 Marek Safar <marek.safar@gmail.com>
1944 A fix for bug #487625
1945 * namespace.cs: Use a warning for all predefined type conflicts.
1947 2009-03-23 Marek Safar <marek.safar@gmail.com>
1949 A fix for bug #485706
1950 * statement.cs: Explicitly type catch type argument to pass verifier
1953 2009-03-22 Miguel de Icaza <miguel@novell.com>
1955 Initial support to provide code completion facilities to consumers
1956 of the evaluator API.
1958 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1959 support the completion engine. When we reach the end of the
1960 input stream instead of returning EOF, when this flag is true the
1961 tokenizer instead produces:
1963 One GENERATE_COMPLETION token: this token then must be
1964 handled in the grammar at every point where the user
1965 would likely request a completion.
1967 As many COMPLETE_COMPLETION tokens as necessary. These
1968 tokens are generated to assist the parser in unwinding and
1969 producing a valid parse tree.
1971 The parser rules do not have to be perfect, the parser needs to be
1972 augmented with judicious use of GENERATE_COMPLETION tokens to
1973 improve the areas where we can provide completion and the parser
1974 needs to add support for COMPLETE_COMPLETION tokens in productions
1977 It is common to not have enough support for COMPLETE_COMPLETION
1978 under certain rules and that even if we generated the
1979 GENERATE_COMPLETION token that the resulting tree will be invalid
1980 due to the missing rules that support COMPLETE_COMPLETION.
1982 The final EOF token is produced by having the parser notify the
1983 tokenizer when it reaches the root production that the next token
1986 * support.cs (CompletionResult): New Exception. This exception
1987 is thrown to return the completion results when one of the special
1988 completion expressions is reached.
1990 This exception is thrown by the completing ExpressionStatements
1991 classes that live in complete.cs
1993 * complete.cs (CompletingExpression): a new base class for
1994 completing expressions. This derives from the
1995 ExpressionStatement class and not from Expression as it allows
1996 completion to happen not only where expressions are expected in
1997 the grammar, but also where statements are expected.
1999 (CompletionSimpleName): A new class used to provide completions
2000 for SimpleNames. This currently only resolves to local
2001 variables from the evaluator context (GetVars call).
2003 (CompletionMemberAccess): Implements support for completing member
2006 * cs-parser.jay: Add support for completion in a few places.
2008 * eval.cs (GetCompletions): New public API for the evaluator that
2009 returns a list of possible completions given the input. The
2010 return value is an array of completions
2012 * anonymous.cs (Compatible): If the exception thrown from the
2013 resolved expression is a CompletionResult exception let that one
2014 through instead of printing a diagnostic error in the try/catch.
2016 2009-03-22 Miguel de Icaza <miguel@novell.com>
2020 * driver.cs (Main): Use Environment.Exit to quit quickly and
2021 prevent the compiler from doing the usual wait for helper thread
2024 This is to prevent a slowdown that was reported by Gonzalo on
2027 2009-03-19 Marek Safar <marek.safar@gmail.com>
2029 * ecore.cs: Load build-in types directly instead of accessing
2032 2009-03-18 Marek Safar <marek.safar@gmail.com>
2034 * ecore.cs: Always use unbox.any when available.
2036 2009-03-18 Marek Safar <marek.safar@gmail.com>
2038 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
2040 2009-03-17 Marek Safar <marek.safar@gmail.com>
2042 * generic.cs: Removed obsolete version of type inference.
2044 2009-03-16 Marek Safar <marek.safar@gmail.com>
2046 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
2047 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
2048 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
2049 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
2051 2009-03-11 Marek Safar <marek.safar@gmail.com>
2053 A fix for bug #482996
2054 * anonymous.cs: Make sure we are not infering return type when
2055 checking type compatibility.
2057 2009-03-11 Marek Safar <marek.safar@gmail.com>
2059 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
2060 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
2061 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
2062 attributes in their own structure. Needed when accessing their
2063 properties before they are resolved.
2065 2009-03-09 Marek Safar <marek.safar@gmail.com>
2067 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
2068 hashtable (~10x faster).
2070 * driver.cs: Removed wrong Reset.
2072 2009-03-08 Marek Safar <marek.safar@gmail.com>
2074 * class.cs: Use correct common base type for unmanaged delayed
2077 * rootcontext.cs: Wrap unhandled exception.
2079 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
2081 Make SeekableStreamReader self-tuning and arbitrarily seekable
2082 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
2084 (SeekableStreamReader.Position.set): Use it. Simplify logic
2085 which, as a side-effect, makes it arbitrarily-seekable. Tune the
2086 buffer size when the stream needs to be re-read from the beginning.
2088 2009-03-05 Marek Safar <marek.safar@gmail.com>
2090 A fix for bug #480100
2091 * parameter.cs: A parameter is not hoisted when used directly as ET.
2093 2009-03-04 Marek Safar <marek.safar@gmail.com>
2095 * statement.cs: Fixed an issue when using variable is of interface
2098 2009-03-03 Marek Safar <marek.safar@gmail.com>
2100 A fix for bug #480319
2101 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
2103 2009-03-03 Marek Safar <marek.safar@gmail.com>
2105 A fix for bug #480867
2106 * typemanager.cs, expression.cs, ecore.cs: Changed method group
2107 expression to have no valid type.
2109 2009-03-03 Marek Safar <marek.safar@gmail.com>
2111 A fix for bug #481258
2112 * class.cs: Set extension method flag in partial container.
2114 2009-03-03 Marek Safar <marek.safar@gmail.com>
2116 * statement.cs, typemanager.cs: Use expression for StringEmitter.
2118 * attribute.cs: Add sanity check.
2120 2009-02-27 Marek Safar <marek.safar@gmail.com>
2122 * class.cs: Add external constructor error.
2124 2009-02-26 Marek Safar <marek.safar@gmail.com>
2126 A fix for bug #475354
2127 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
2128 correctly user defined nullable equality operators.
2130 2009-02-25 Marek Safar <marek.safar@gmail.com>
2132 A fix for bug #479532
2133 * expression.cs: Implement NewInitialize::AddressOf.
2135 2009-02-25 Marek Safar <marek.safar@gmail.com>
2137 A fix for bug #413633
2138 * expression.cs: Iterate all base class-constraint types.
2140 2009-02-24 Marek Safar <marek.safar@gmail.com>
2142 A fix for bug #479209
2143 * literal.cs: Mutate null underlying type.
2145 2009-02-24 Marek Safar <marek.safar@gmail.com>
2147 A fix for bug #476295
2148 * convert.cs: Avoid wrapping implicitly convertible reference type.
2150 2009-02-23 Marek Safar <marek.safar@gmail.com>
2152 * iterators.cs: Create MemberName correctly.
2154 2009-02-23 Marek Safar <marek.safar@gmail.com>
2156 A fix for bug #478655
2157 * literal.cs: Check also underlying null type conversion.
2159 2009-02-21 Marek Safar <marek.safar@gmail.com>
2161 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
2163 2009-02-20 Marek Safar <marek.safar@gmail.com>
2165 A fix for bug #477447
2166 * statement.cs: Add reference to correct parent storey when this
2167 is accessible from deep children storey (more than 1 level).
2169 2009-02-19 Marek Safar <marek.safar@gmail.com>
2171 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
2172 * class.cs: Define base type members before setting up member cache.
2174 2009-02-18 Marek Safar <marek.safar@gmail.com>
2176 A fix for bug #477378
2177 * nullable.cs, expression.cs, statement.cs: More precise null type
2180 2009-02-18 Marek Safar <marek.safar@gmail.com>
2182 A fix for bug #472805
2183 * typemanager.cs, namespace.cs: Import only visible extension method
2186 2009-02-18 Marek Safar <marek.safar@gmail.com>
2188 A fix for bug #476895
2189 * attribute.cs: Use correct resolve context for attribute type.
2191 2009-02-18 Marek Safar <marek.safar@gmail.com>
2193 A fix for bug #476266
2194 * anonymous.cs: Mutate multi-dimensional arrays.
2196 2009-02-18 Marek Safar <marek.safar@gmail.com>
2198 A fix for bug #476400
2199 * statement.cs, expression.cs: Removed wrong Dispose optimization.
2201 2009-02-18 Marek Safar <marek.safar@gmail.com>
2203 A fix for bug #476811
2204 * generics.cs: Fixed null-literal check.
2206 2009-02-17 Marek Safar <marek.safar@gmail.com>
2208 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
2209 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
2210 messing with static variables.
2212 2009-02-16 Marek Safar <marek.safar@gmail.com>
2214 A fix for bug #475965
2215 * generics.cs: Check generic parameter type after extracting from
2218 2009-02-16 Marek Safar <marek.safar@gmail.com>
2220 A fix for bug #475823
2221 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
2224 2009-02-14 Marek Safar <marek.safar@gmail.com>
2226 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
2227 Simplified event field definition using backing field and not
2228 field builder directly.
2230 * expression.cs (EmitLdArg): Optimize fast paths.
2232 2009-02-13 Marek Safar <marek.safar@gmail.com>
2234 A fix for bug #475327
2235 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2237 2009-02-13 Marek Safar <marek.safar@gmail.com>
2239 A fix for bug #475342
2240 * cs-parser.jay: Using 'super' instead of 'base' to call base
2241 constructor crashes compiler.
2243 2009-02-13 Marek Safar <marek.safar@gmail.com>
2245 A fix for bug #475354
2246 * expression.cs (Constantify): Add nullable types.
2248 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2250 2009-02-12 Marek Safar <marek.safar@gmail.com>
2252 A fix for bug #475246
2253 * expression.cs: More broken flowanalysis hacking needed.
2255 2009-02-12 Marek Safar <marek.safar@gmail.com>
2257 * attribute.cs: Compare only ref/out array modifiers.
2259 2009-02-11 Marek Safar <marek.safar@gmail.com>
2261 * statement.cs: Use member cache when looking for foreach members.
2263 2009-02-11 Marek Safar <marek.safar@gmail.com>
2265 * expression.cs: Don't expose internal initializer types.
2267 * statement.cs: Check also explicit conversions for goto case.
2269 2009-02-11 Marek Safar <marek.safar@gmail.com>
2271 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2273 2009-02-10 Marek Safar <marek.safar@gmail.com>
2275 * *.cs: Replace null-type with NullLiteral where appropriate.
2277 2009-02-09 Marek Safar <marek.safar@gmail.com>
2279 * expression.cs: Initializer of reference argument use temporary
2280 variable to be verifiable.
2282 * parameter.cs: Share EmitLdArg.
2284 2009-02-09 Marek Safar <marek.safar@gmail.com>
2286 A fix for bug #473559
2287 * class.cs: Fixed: Not reporting error about nested class with the
2290 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2292 Contributed under the MIT/X11 license.
2294 * generic.cs: Added VerifyVariantTypeParameters which performs new
2295 variance verification logic. The old logic, based on the spec, was
2296 wrong because the spec is full of LIES!
2298 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2300 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2303 * ecore.cs: Added calls to the new variance verification logic.
2306 * delegate.cs: Removed calls to the old variance verification logic.
2308 2009-02-06 Marek Safar <marek.safar@gmail.com>
2310 * delegate.cs: Use cached Invoke method directly.
2312 2009-02-06 Marek Safar <marek.safar@gmail.com>
2314 * expression.cs: Emit expression tree for hoisted variable access.
2316 2009-02-04 Marek Safar <marek.safar@gmail.com>
2318 * namespace.cs: Add better extension class check.
2320 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2322 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2324 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2326 This patch adds initial generic variance support to the compiler.
2327 It is contributed under the MIT/X11 license.
2329 * typemanager.cs: Modified ImplementsInterface to check variance.
2330 Added VerifyVariantTypeParameters which checks the specified type to see
2331 if it uses a variant type parameter as a type argument (which is not
2332 allowed). Added IsVariantOf which determins if the first type is a
2333 variant of the second. NOTE: This only supports reference types at
2334 the moment to conform with the current level of VM support. When the
2335 VM supports value types, this will follow step.
2337 * generic.cs: Added the Variance enum. Added a Variance property to
2338 TypeParameter and added variance support to definition phase. Added a
2339 Variance property to TypeParameterName. Also check to make sure that
2340 no variant types appear in generic method parameters.
2342 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2343 keywords if the langversion supports it.
2345 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2346 that variant types are only used in legal positions. Also added
2347 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2350 * decl.cs: Construct TypeParameter with the variance information.
2352 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2353 and ImplicitConversionStandard.
2355 * rootcontext.cs: Added new "Future" language version.
2357 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2358 type parameters are not used as type arguments in interface inheritance.
2359 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2360 parameters are not used as method return types. In MemberBase.
2361 ResolveMemberType, ensure that variant type parameters are not used
2362 as type arguments. Also call VerifyNoVariantTypeParameters on every
2363 set of parameters which are resolved.
2365 * delegate.cs: Modified Delegate.Define to ensure that variant
2366 parameters are not used as type arguments and that a contravariant
2367 parameter is not used as the return type. Also call
2368 VerifyNoVariantTypeParameters on the delegate parameters.
2370 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2371 to specify generic variance.
2373 * driver.cs: Added support for LanguageVersion.Future in the form of
2374 "-langversion:future".
2376 * generic-mcs.cs: Stubbed out new members in generic.cs.
2378 2009-02-03 Marek Safar <marek.safar@gmail.com>
2380 * class.cs, generic.cs: Emit type parameter constraints for nested
2383 2009-02-02 Marek Safar <marek.safar@gmail.com>
2385 A fix for bug #471213
2386 * class.cs: Avoid emitting backing field for abstract event fields.
2388 2009-02-01 Marek Safar <marek.safar@gmail.com>
2390 A fix for bug #359731
2391 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2394 2009-01-30 Marek Safar <marek.safar@gmail.com>
2396 A fix for bug #470767
2397 * statement.cs: Introduced BlockScopeExpression, needed when
2398 expression tree conversion has to emit scope variables.
2400 2009-01-29 Marek Safar <marek.safar@gmail.com>
2402 * class.cs: Remove duplicate CallingConvention.
2404 2009-01-29 Marek Safar <marek.safar@gmail.com>
2406 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2407 when I finally found the right naming convention.
2409 2009-01-29 Marek Safar <marek.safar@gmail.com>
2411 * cs-tokenizer.cs: Put back different open parens optimization.
2413 2009-01-28 Marek Safar <marek.safar@gmail.com>
2415 A fix for bug #470227
2416 * cs-tokenizer.cs: Remove too agressive parser optimization.
2418 2009-01-28 Marek Safar <marek.safar@gmail.com>
2420 A fix for bug #324319
2421 * class.cs: Remove too early base type resolve.
2423 2009-01-27 Marek Safar <marek.safar@gmail.com>
2425 A fix for bug #324319
2426 * ecore.cs: Explicitly type null when assigning to type argument to
2427 make pass verifier check.
2429 2009-01-27 Marek Safar <marek.safar@gmail.com>
2431 * anonymous.cs: Fixed recent regression when initializing captured
2434 2009-01-26 Marek Safar <marek.safar@gmail.com>
2436 A fix for bug #469019
2437 * anonymous.cs: Use all parent type parameters when instantiating
2438 nested generic storey.
2440 2009-01-26 Marek Safar <marek.safar@gmail.com>
2442 * expression.cs: Check for null instance methodgroup expression.
2444 2009-01-26 Marek Safar <marek.safar@gmail.com>
2446 A fix for bug #469244
2447 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2448 instance inside a conditional expression.
2450 2009-01-23 Marek Safar <marek.safar@gmail.com>
2452 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2453 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2454 GetElementType and HasElementType. IsValueType clean up.
2456 2009-01-23 Marek Safar <marek.safar@gmail.com>
2458 * nullable.cs: Use common EmitCall.
2460 * expression.cs: Emit constraint. for virtual calls only.
2462 2009-01-23 Marek Safar <marek.safar@gmail.com>
2464 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2465 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2466 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2469 2009-01-22 Jb Evain <jbevain@novell.com>
2471 * anonymous.cs: make anonymous types' ToString implementation
2472 match what csc outputs.
2474 2009-01-21 Marek Safar <marek.safar@gmail.com>
2476 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2479 2009-01-17 Marek Safar <marek.safar@gmail.com>
2481 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2484 2009-01-16 Marek Safar <marek.safar@gmail.com>
2486 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2489 2009-01-15 Marek Safar <marek.safar@gmail.com>
2491 A fix for bug #466634
2492 * statement.cs: Add reference for nested storey when only this
2495 2009-01-15 Marek Safar <marek.safar@gmail.com>
2497 A fix for bug #466474
2498 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2501 2009-01-15 Marek Safar <marek.safar@gmail.com>
2503 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2504 Fixed nested stories parent referencing process. Also fixes #463985.
2506 2009-01-06 Marek Safar <marek.safar@gmail.com>
2508 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2509 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2510 implementation. Also fixes #463108.
2512 2009-01-05 Marek Safar <marek.safar@gmail.com>
2514 A fix for bug #416109
2515 * decl.cs: Issue correct CLSAttribute warning location.
2517 2009-01-05 Marek Safar <marek.safar@gmail.com>
2519 A fix for bug #456775
2520 * attribute.cs: Use attribute owner scope when resolving attribute
2523 2009-01-05 Marek Safar <marek.safar@gmail.com>
2525 A fix for bug #457257
2526 * decl.cs: Fixed incorrect member declaring type comparison.
2528 2009-01-05 Marek Safar <marek.safar@gmail.com>
2530 A fix for bug #460896
2531 * driver.cs: Handle /RES resources as embeddable.
2533 2009-01-05 Marek Safar <marek.safar@gmail.com>
2535 A fix for bug #462515
2536 * ecore.cs: Report inacessible members upwards.
2538 2009-01-05 Marek Safar <marek.safar@gmail.com>
2540 A fix for bug #463190, #463192
2541 * decl.cs, namespace.cs: Also import internal extension classes.
2543 2009-01-04 Marek Safar <marek.safar@gmail.com>
2545 A fix for bug #463415
2546 * generic.cs: Use right index for RemoveDependentTypes.
2548 2009-01-02 Marek Safar <marek.safar@gmail.com>
2550 A fix for bug #463196
2551 * expression.cs: Fixed enum to null comparison.
2553 2009-01-02 Marek Safar <marek.safar@gmail.com>
2555 A fix for bug #463121
2556 * nullable.cs: Fixed nullable user equality operator comparison.
2558 2009-01-02 Marek Safar <marek.safar@gmail.com>
2560 A fix for bug #462950
2561 * class.cs, decl.cs: Use full explicit name when defining automatic
2562 property backing field.
2564 2009-01-02 Marek Safar <marek.safar@gmail.com>
2566 A fix for bug #462592
2567 * pending.cs: Emit type arguments for generic proxy method.
2569 2008-12-30 Marek Safar <marek.safar@gmail.com>
2571 * expression.cs (As): Mutate all type arguments.
2573 2008-12-29 Marek Safar <marek.safar@gmail.com>
2575 A fix for bug #462622
2576 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2579 2008-12-29 Marek Safar <marek.safar@gmail.com>
2581 A fix for bug #450782
2582 * ecore.cs: Consider more variables of form V.I to be fixed.
2584 2008-12-29 Marek Safar <marek.safar@gmail.com>
2586 A fix for bug #460712
2587 * typemanager.cs: Core types could be imported.
2589 2008-12-28 Marek Safar <marek.safar@gmail.com>
2591 A fix for bugs #460847, #460772, #458049, #457339, #447807
2592 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2593 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2594 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2595 user lambdas used inside query clauses.
2597 2008-12-18 Marek Safar <marek.safar@gmail.com>
2599 A fix for bug #460229
2600 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2602 2008-12-18 Marek Safar <marek.safar@gmail.com>
2604 A fix for bug #459952
2605 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2607 2008-12-18 Marek Safar <marek.safar@gmail.com>
2609 A fix for bug #459630
2610 * convert.cs: Enum to valuetype conversion is not allowed.
2612 2008-12-18 Marek Safar <marek.safar@gmail.com>
2614 A fix for bug #457087
2615 * generic.cs: Don't crash when constraint comes from type
2618 2008-12-16 Marek Safar <marek.safar@gmail.com>
2620 A fix for bug #459221
2621 * anonymous.cs, statement.cs: Delay only captured this
2624 2008-12-12 Marek Safar <marek.safar@gmail.com>
2626 A fix for bug #457489
2627 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2628 and initialization to capture scope initializers correctly.
2630 2008-12-11 Marek Safar <marek.safar@gmail.com>
2632 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2633 ParameterReference refactoring.
2635 2008-12-03 Marek Safar <marek.safar@gmail.com>
2637 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2638 to be imported from any assembly.
2640 2008-12-03 Marek Safar <marek.safar@gmail.com>
2642 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2643 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2644 from anonymous method and lambda expression.
2646 2008-12-01 Marek Safar <marek.safar@gmail.com>
2648 A fix for bug #448560
2649 * expression.cs (As): Box any generic type arguments to be
2652 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2654 Add tripwire for implicit conversion bugs
2655 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2657 (MethodGroupExpr.OverloadResolve): Add sanity check between
2658 IsApplicable and VerifyArgumentsCompat.
2659 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2661 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2663 Fix build break in System.Data_test
2664 * convert.cs (ImplicitConversionExists): Move NullLiteral
2666 (ImplicitStandardConversionExists): ... here.
2668 2008-11-28 Marek Safar <marek.safar@gmail.com>
2670 * literal.cs: Emit correctly explicit null to nullable cast.
2672 2008-11-28 Marek Safar <marek.safar@gmail.com>
2674 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2677 2008-11-28 Marek Safar <marek.safar@gmail.com>
2679 A fix for bug #449005
2680 * convert.cs, nullable.cs: Use only one implicit nullable
2683 2008-11-27 Marek Safar <marek.safar@gmail.com>
2685 * convert.cs, literal.cs: More Convert cleanup is needed.
2687 2008-11-27 Marek Safar <marek.safar@gmail.com>
2689 * decl.cs, class.cs: Fixed misleading error message.
2691 2008-11-26 Marek Safar <marek.safar@gmail.com>
2693 A fix for bug #449005
2694 * nullable.cs (EmitEquality): Disable optimization for user operator
2697 2008-11-25 Marek Safar <marek.safar@gmail.com>
2699 A fix for bug #447027
2700 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2701 with context variables stored as expression instances.
2703 2008-11-25 Marek Safar <marek.safar@gmail.com>
2705 A fix for bug #447027
2706 * delegate.cs: Fixed delegate VerifyMethod logic.
2708 2008-11-24 Marek Safar <marek.safar@gmail.com>
2710 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2713 2008-11-21 Marek Safar <marek.safar@gmail.com>
2715 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2716 member type resolve to follow normal flow, instead of random
2719 2008-11-21 Marek Safar <marek.safar@gmail.com>
2721 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2724 2008-11-21 Marek Safar <marek.safar@gmail.com>
2726 * const.cs: Emit decimal array constant as literal.
2728 2008-11-20 Marek Safar <marek.safar@gmail.com>
2730 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2732 2008-11-19 Marek Safar <marek.safar@gmail.com>
2734 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2735 into real property (saves 8 MB for corlib compilation).
2737 2008-11-19 Marek Safar <marek.safar@gmail.com>
2739 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2740 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2741 generic-mcs.cs: Small cleanup of TypeArguments.
2743 2008-11-18 Marek Safar <marek.safar@gmail.com>
2745 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2746 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2747 of ConstructedType expression, renamed to GenericTypeExpr.
2749 2008-11-17 Marek Safar <marek.safar@gmail.com>
2751 A fix for bug #445303
2752 * location.cs (IsConditionalDefined): Handle undefined global
2755 2008-11-17 Marek Safar <marek.safar@gmail.com>
2757 A fix for bug #444678
2758 * expression.cs (TryReduceConstant): Always create new constant
2761 2008-11-17 Marek Safar <marek.safar@gmail.com>
2763 A fix for bug #444673
2764 * ecore.cs: Ignore open generic types when used as generic type
2767 2008-11-17 Marek Safar <marek.safar@gmail.com>
2769 A fix for bug #445458
2770 * expression.cs, cs-parser.jay: Don't crash when an expression
2773 2008-11-17 Marek Safar <marek.safar@gmail.com>
2775 A fix for bug #445464
2776 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2777 inside unbound type.
2779 2008-11-14 Jb Evain <jbevain@novell.com>
2781 * driver.cs: ignore empty -nowarn argument such as
2782 the one in -nowarn:12,13,,.
2784 2008-11-13 Marek Safar <marek.safar@gmail.com>
2786 A fix for bug #444271
2787 * anonymous.cs: Rescan parent storeys when best candidate was
2790 2008-11-13 Marek Safar <marek.safar@gmail.com>
2792 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2793 useless UnboundTypeExpression.
2795 * attribute.cs: Do check obsolete attribute on generic types.
2797 2008-11-12 Marek Safar <marek.safar@gmail.com>
2799 A fix for bugs #425680, #400139
2800 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2803 2008-11-11 Marek Safar <marek.safar@gmail.com>
2805 A fix for bug #435747
2806 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2807 compound value types assignment. Few micro optimizations added.
2809 2008-11-10 Marek Safar <marek.safar@gmail.com>
2811 A fix for bug #442610
2812 * anonymous.cs (MutateConstructor): More SRE hacking.
2814 2008-11-10 Marek Safar <marek.safar@gmail.com>
2816 A fix for bug #442579
2817 * ecore.cs: Also initialize expanded form of a method with 1 params
2820 2008-11-06 Marek Safar <marek.safar@gmail.com>
2822 * expression.cs (UnaryMutator): Do early l-side check.
2824 2008-11-05 Miguel de Icaza <miguel@novell.com>
2826 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2827 Init, otherwise we would crash later on when checking for friend
2830 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2831 Otherwise we never get any meaningful information as to what
2834 2008-11-05 Marek Safar <marek.safar@gmail.com>
2836 A fix for bug #436318
2837 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2839 2008-11-05 Miguel de Icaza <miguel@novell.com>
2841 * namespace.cs: Turns out that it was a really bad idea to hide
2842 the errors for namespaces not found here in eval mode.
2844 * eval.cs: When we process using clauses, only enter those into
2845 the list of valid using clauses after they have been validated.
2847 The above change gives the proper semantics: it does not
2848 senselessly report the same errors with broken using statements by
2849 never storing them in the first place when they are invalid.
2851 2008-11-05 Marek Safar <marek.safar@gmail.com>
2853 A fix for bug #421839
2854 * cs-parser.jay: Remove expression from coalesce rule to force lower
2855 priority than the assignment operator.
2857 2008-11-05 Marek Safar <marek.safar@gmail.com>
2859 A fix for bug #437875
2860 * nullable.cs: Compile correctly method group operand used with null
2861 coalescing operator.
2863 2008-11-04 Marek Safar <marek.safar@gmail.com>
2865 A fix for bug #434589
2866 * expression.cs (Binary): Ignore lifted conversions when at least
2867 one operand is of reference type.
2869 2008-11-04 Marek Safar <marek.safar@gmail.com>
2871 * cs-parser.jay: Better syntax error report.
2873 2008-11-03 Marek Safar <marek.safar@gmail.com>
2875 A fix for bug #436792
2876 * cs-parser.jay: Use GetLocation to access location.
2878 2008-11-03 Marek Safar <marek.safar@gmail.com>
2880 A fix for bug #440774
2881 * cs-parser.jay: Also set current_array_type when parsing local
2884 2008-11-03 Marek Safar <marek.safar@gmail.com>
2886 A fix for bug #440785
2887 * expression.cs (As): Don't resolve self modifing expression
2890 2008-11-03 Marek Safar <marek.safar@gmail.com>
2892 A fix for bug #439447
2893 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2895 2008-11-03 Marek Safar <marek.safar@gmail.com>
2897 A fix for bug #437571
2898 * cs-parser.jay: Fixes internal error for invalid expression
2901 2008-10-17 Marek Safar <marek.safar@gmail.com>
2903 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2905 2008-10-17 Marek Safar <marek.safar@gmail.com>
2907 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2909 2008-10-17 Marek Safar <marek.safar@gmail.com>
2911 * cs-tokenizer.cs: More precise cast parsing.
2913 2008-10-16 Martin Baulig <martin@ximian.com>
2915 * anonymous.cs (AnonymousMethodStorey): Put back the
2916 `hoisted_locals' hashtable and use it in EmitType().
2918 2008-10-15 Marek Safar <marek.safar@gmail.com>
2920 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2921 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2924 2008-10-14 Marek Safar <marek.safar@gmail.com>
2926 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2928 2008-10-14 Marek Safar <marek.safar@gmail.com>
2930 * statement.cs: Mutate scope initializers.
2932 2008-10-14 Marek Safar <marek.safar@gmail.com>
2934 * expression.cs: Use typeless value for This constant.
2936 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2938 2008-10-14 Marek Safar <marek.safar@gmail.com>
2940 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2943 2008-10-13 Marek Safar <marek.safar@gmail.com>
2945 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2948 2008-10-13 Marek Safar <marek.safar@gmail.com>
2950 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2951 parser and tokenizer. Fixes many ambiguities including #433258.
2953 2008-10-10 Marek Safar <marek.safar@gmail.com>
2955 * cs-parser.jay: Fixed missing accessor recovery.
2957 2008-10-10 Marek Safar <marek.safar@gmail.com>
2959 A fix for bug #433701
2960 * expression.cs: Better error message.
2962 2008-10-10 Marek Safar <marek.safar@gmail.com>
2964 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2966 * Makefile: Disabled unused debug symbols.
2968 Also fixes: #320556, #321097, #321656, #321876, #351316
2970 2008-10-09 Miguel de Icaza <miguel@novell.com>
2972 * eval.cs: rename "<interactive>" to "{interactive}", to work
2973 around a requirement in the compiler that this be a valid
2974 filename, and in Windows it is not (433886).
2976 2008-10-09 Marek Safar <marek.safar@gmail.com>
2978 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2980 2008-10-08 Marek Safar <marek.safar@gmail.com>
2982 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2983 cs-parser.jay: Generic type declaration and type arguments cleanup.
2985 2008-10-05 Marek Safar <marek.safar@gmail.com>
2987 * cs-parser.jay: Allow parsing weird array creation construct.
2989 2008-10-05 Marek Safar <marek.safar@gmail.com>
2991 * cs-parser.jay: Conflicts reduction.
2993 2008-10-04 Marek Safar <marek.safar@gmail.com>
2995 * cs-parser.jay: Conflicts reduction.
2997 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
3000 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
3001 property. Add a 'count' hint about the use of the shared vector.
3002 Ensure that we don't leak out dirty bits.
3003 (UsageVector.MergeChild): Throw away information about variables
3005 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
3007 2008-10-03 Marek Safar <marek.safar@gmail.com>
3009 A fix for bug #431746
3010 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
3011 parameters when iterator is created.
3013 2008-10-03 Marek Safar <marek.safar@gmail.com>
3015 A fix for bug #431827
3016 * expression.cs: Fixed right based pointer arithmetic operations
3019 2008-10-03 Marek Safar <marek.safar@gmail.com>
3021 A fix for bug #353779
3022 * assign.cs, expression.cs: Fixed compound assignment conversions.
3024 2008-10-02 Marek Safar <marek.safar@gmail.com>
3026 A fix for bug #375262
3027 * statement.cs: Refactor ArrayForeach to be usable with string
3028 indexer. Optimized single dimentional arrays foreach.
3030 2008-10-02 Marek Safar <marek.safar@gmail.com>
3032 A fix for bug #431255
3033 * anonymous.cs, expression.cs: Removed broken optimization.
3035 2008-10-01 Marek Safar <marek.safar@gmail.com>
3037 * anonymous.cs: Use full type parameters of parent generic
3038 containers. Removed unnecessary AddParentStoreyReference call.
3040 2008-10-01 Marek Safar <marek.safar@gmail.com>
3042 A fix for bug #324702
3043 * class.cs: Use better shorter names for explicit interface member
3046 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
3048 2008-10-01 Marek Safar <marek.safar@gmail.com>
3050 * expression.cs: Use new interface to check fixed expression.
3052 2008-10-01 Marek Safar <marek.safar@gmail.com>
3054 A fix for bug #421101
3055 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
3056 interface to check for fixed fixed-buffers.
3058 2008-10-01 Marek Safar <marek.safar@gmail.com>
3060 A fix for bug #429264
3061 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
3063 * delegate.cs: Removed unnecessary casts.
3065 2008-09-30 Marek Safar <marek.safar@gmail.com>
3067 A fix for bug #352151
3068 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
3069 class.cs: Fixed already defined explicit interface members check.
3071 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
3073 cs-tokenizer.cs: Fix typo.
3075 2008-09-28 Miguel de Icaza <miguel@novell.com>
3077 * eval.cs (InteractiveBase): The quit command now just sets a
3078 flag, instead of calling Environment.Exit(), it is milder on
3081 CompiledMethod is now in Mono.CSharp, not nested inside
3082 the Evaluator, it was inconvenient to use.
3084 2008-09-27 Miguel de Icaza <miguel@novell.com>
3086 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
3087 code to be invoked without having to reparse.
3089 2008-09-27 Miguel de Icaza <miguel@novell.com>
3091 * ecore.cs: The recent changes to FieldExpr broke this as well.
3092 Fixes LINQ queries in the interactive shell.
3094 * Multiple files: indentation fixing for the Mono coding
3095 guidelines for the switch statement.
3097 * eval.cs: Make the Evaluator API thread safe.
3099 2008-09-26 Marek Safar <marek.safar@gmail.com>
3101 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
3102 constructor parsing.
3104 2008-09-26 Marek Safar <marek.safar@gmail.com>
3106 A fix for bug #325326
3107 * statement.cs: Check possible mistaken empty statement using
3108 explicit blocks only.
3110 2008-09-25 Miguel de Icaza <miguel@novell.com>
3112 * eval.cs (LoadAssembly, ReferenceAssembly): Call
3113 RootNamespace.ComputeNamespaces to update the internal list of
3114 namespaces, this is no longer done for us.
3116 (InteractiveBase): Use the Evaluator APIs instead of calling into
3119 2008-09-25 Marek Safar <marek.safar@gmail.com>
3121 A fix for bug #429264
3122 * expression.cs: Missing mutator for access to multidimensional
3125 2008-09-25 Marek Safar <marek.safar@gmail.com>
3127 * class.cs, statement: Emit DebuggerHidden attribute for iterator
3130 * driver.cs: Missing input argument check.
3132 2008-09-25 Marek Safar <marek.safar@gmail.com>
3134 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
3135 expression.cs, statement.cs, rootcontext.cs, class.cs,
3136 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
3139 2008-09-24 Miguel de Icaza <miguel@novell.com>
3141 * ecore.cs (FieldExpr): Only initialize eclass when we return a
3142 fully constructed FieldExpr, fixes the regression introduced in
3145 * ecore.cs, expression.cs: Plug back the eclass initialization as
3146 otherwise it regresses `csharp'.
3148 2008-09-24 Marek Safar <marek.safar@gmail.com>
3150 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
3151 ecore.cs, attribute.cs: Moved obsolete method checks from emit
3152 phase to resolve phase. It resolves problems with expression trees
3153 and fixes bugs #323796, #325156.
3155 2008-09-23 Marek Safar <marek.safar@gmail.com>
3157 * codegen.cs: Report better error when symbol writer is missing.
3159 2008-09-23 Marek Safar <marek.safar@gmail.com>
3161 * codegen.cs: Set .NET symbol writer.
3163 * decl.cs: Guard against null generic arguments.
3165 * report.cs: Don't report exactly same additional details.
3167 2008-09-22 Marek Safar <marek.safar@gmail.com>
3169 A fix for bug #324917
3170 * cs-parser.jay: Add missing multidimensional non-expression type
3173 2008-09-22 Marek Safar <marek.safar@gmail.com>
3175 A fix for bug #428191
3176 * anonymous.cs: Create an outer generic fields also for non-storey
3179 2008-09-22 Marek Safar <marek.safar@gmail.com>
3181 A fix for bug #378294
3182 * class.cs: Make fixed size buffers gmcs feature only.
3184 2008-09-22 Marek Safar <marek.safar@gmail.com>
3186 A fix for bug #355622, #324993
3187 * assign.cs, const.cs, class.cs: Create new EmitContext for each
3190 2008-09-19 Marek Safar <marek.safar@gmail.com>
3192 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
3195 2008-09-19 Marek Safar <marek.safar@gmail.com>
3197 A fix for bug #416110
3198 * generic.cs: Struct constraint results in default ctor and
3199 ValueType base type constraint to be set.
3201 2008-09-19 Marek Safar <marek.safar@gmail.com>
3203 A fix for bug #423791
3204 * generic.cs: Fixed params output type type-inference.
3206 2008-09-19 Marek Safar <marek.safar@gmail.com>
3208 * cs-parser.jay, expression.cs: Fixed few expression crashes.
3210 2008-09-19 Marek Safar <marek.safar@gmail.com>
3212 * cs-tokenizer.cs: Don't break on extra partial modifier.
3214 2008-09-19 Marek Safar <marek.safar@gmail.com>
3216 A fix for bug #427592
3217 * generic.cs: Use common parameter resolve method.
3219 2008-09-18 Marek Safar <marek.safar@gmail.com>
3221 A fix for bug #414758
3222 * expression.cs, ecore.cs: Fixed crash when accessing non-static
3225 2008-09-18 Marek Safar <marek.safar@gmail.com>
3227 * driver.cs, namespace.cs: Read types and namespaces after all
3228 requested assemblies are loaded, fixes issues with System.Core
3229 auto-reference, and #419888.
3231 2008-09-18 Marek Safar <marek.safar@gmail.com>
3233 A fix for bug #417705
3234 * cs-parser.jay: Fixed as/is operator expression split.
3236 2008-09-18 Marek Safar <marek.safar@gmail.com>
3238 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3239 Fixed expression tree representation of empty new expression and
3240 new initializer expression.
3242 2008-09-18 Miguel de Icaza <miguel@novell.com>
3244 * eval.cs: Remove warning, keep reference to driver around.
3246 * Hide fields that do not need to be public.
3248 2008-09-17 Marek Safar <marek.safar@gmail.com>
3250 A fix for bug #426385
3251 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3252 conversion for array elements.
3254 2008-09-17 Marek Safar <marek.safar@gmail.com>
3256 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3257 void parsing conflicts.
3259 2008-09-15 Marek Safar <marek.safar@gmail.com>
3261 A fix for bug #425601
3262 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3263 System.Core only when there is no custom ExtensionAttribute
3266 2008-09-15 Miguel de Icaza <miguel@novell.com>
3268 * namespace.cs: Do not report CS0246 (name
3270 2008-09-12 Marek Safar <marek.safar@gmail.com>
3272 A fix for bug #425669
3273 * generic.cs: Don't cache generic static anonymous method
3276 2008-09-12 Marek Safar <marek.safar@gmail.com>
3278 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3279 conflicting constraints.
3281 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3283 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3286 2008-09-12 Marek Safar <marek.safar@gmail.com>
3288 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3289 to null pointer conversion fixes.
3291 2008-09-11 Marek Safar <marek.safar@gmail.com>
3293 * cs-parser.jay, expression.cs: An implicitly typed local variable
3294 declarator cannot use an array initializer.
3296 2008-09-11 Marek Safar <marek.safar@gmail.com>
3298 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3300 2008-09-11 Marek Safar <marek.safar@gmail.com>
3302 * generic.cs (InflatedConstraints): Don't crash when constraints
3305 * cs-parser.jay: const_declarator is a block.
3307 * constant.cs: Check for not allowed NaN conversions.
3309 2008-09-10 Miguel de Icaza <miguel@novell.com>
3311 * driver.cs: Drop --shell argument, the compiler is no longer a
3314 * eval.cs: Move most of the code that deals with evaluation into
3315 this file and document the public API from repl.cs
3317 * repl.cs: Remove from here.
3319 2008-09-10 Marek Safar <marek.safar@gmail.com>
3321 A fix for bug #424684
3322 * generic.cs: Generic class constraints must come first.
3324 2008-09-09 Miguel de Icaza <miguel@novell.com>
3326 * cs-parser.jay: Improve error reporting for syntax errors in
3327 statements and expressions, we now report the expected tokens
3328 instead of reporting the useless "; expected".
3330 Drop the strings from the token declaration, it turns out that
3331 they did not do what I thought they did. Instead they were adding
3332 two sets of tokens to the tables.
3334 2008-09-09 Marek Safar <marek.safar@gmail.com>
3336 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3337 delegate.cs: Share special type check.
3339 2008-09-09 Marek Safar <marek.safar@gmail.com>
3341 A fix for bug #423981
3342 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3344 2008-09-09 Marek Safar <marek.safar@gmail.com>
3346 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3349 2008-09-09 Marek Safar <marek.safar@gmail.com>
3351 A fix for bugs: #324750, #335946
3352 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3353 lookup rule to determine ?-based tokens.
3355 2008-09-08 Miguel de Icaza <miguel@novell.com>
3357 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3358 expressions (like event adding or removing) end up here, so we
3359 need to treat those as statements.
3361 Add LoadAssembly method.
3363 2008-09-04 Miguel de Icaza <miguel@novell.com>
3365 * repl.cs: Add Time method.
3367 2008-09-05 Marek Safar <marek.safar@gmail.com>
3369 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3371 2008-09-05 Miguel de Icaza <miguel@novell.com>
3373 * repl.cs: Add workaround for old compilers.
3375 2008-09-04 Jb Evain <jbevain@novell.com>
3377 * repl.cs (PrettyPrint): pretty print everything that
3378 implements IDictionary, as well as IEnumerables. Also,
3379 add a quit helper property.
3381 2008-09-04 Marek Safar <marek.safar@gmail.com>
3383 * constant.cs: Better error reporting for decimal literals.
3385 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3388 2008-09-04 Marek Safar <marek.safar@gmail.com>
3389 Miguel de Icaza <miguel@novell.com>
3391 A fix for bug #422951
3392 * assign.cs (Assign.DoResolve): Perform the type conversions
3393 checks before we attempt to initialize `New' initializers.
3395 2008-09-04 Marek Safar <marek.safar@gmail.com>
3397 A fix for bug #422853
3398 * delegate.cs (DelegateCreation): Add special handling for
3399 EmptyExpression.Null instance expression which is just another
3400 hack for undecided member instance exression.
3402 2008-09-04 Marek Safar <marek.safar@gmail.com>
3404 * expression.cs, ecore.cs: Emit full expression tree for reduced
3407 2008-09-04 Marek Safar <marek.safar@gmail.com>
3409 * expression.cs (This): Guard against multi-resolving.
3411 * ecore.cs, statement.cs (Throw): Simplified.
3413 * flowanalysis.cs: Also verify event fields.
3415 2008-09-04 Miguel de Icaza <miguel@novell.com>
3417 * assign.cs (Assign.DoResolve): Perform the type conversions
3418 checks before we attempt to initialize `New' initializers.
3420 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3422 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3425 * repl.cs: Update help.
3427 2008-09-03 Miguel de Icaza <miguel@novell.com>
3429 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3430 handling of the default config handling, including the special
3431 treatment of System.Core assembly.
3433 Fixes the REPL processing for LINQ.
3435 2008-09-03 Marek Safar <marek.safar@gmail.com>
3437 A fix for bug #422507
3438 * expression.cs (UnboxCast): Add missing child expression mutator.
3440 2008-09-03 Marek Safar <marek.safar@gmail.com>
3442 * driver.cs: Don't self reference System.Core assembly.
3444 2008-09-03 Marek Safar <marek.safar@gmail.com>
3446 A fix for bug #422507
3447 * expression.cs (StringConcat): Add missing type mutator.
3449 2008-09-03 Marek Safar <marek.safar@gmail.com>
3451 * generic.cs (TypeInferenceContext): Follow equality rule for
3452 constructed type lower bound type inference.
3454 2008-09-02 Miguel de Icaza <miguel@novell.com>
3456 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3457 <dblank@cs.brynmawr.edu> which updates the cursor position on
3460 2008-09-02 Marek Safar <marek.safar@gmail.com>
3462 A fix for bug #367145
3463 * driver.cs: Fixed import of extension methods when using -noconfig
3466 2008-09-02 Marek Safar <marek.safar@gmail.com>
3468 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3469 version from non-generic implementation instead.
3471 2008-09-01 Marek Safar <marek.safar@gmail.com>
3473 A fix for bug #418908
3474 * class.cs: Use AddScopeStatement for field initializers.
3476 2008-09-01 Marek Safar <marek.safar@gmail.com>
3478 A fix for bug #415385
3479 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3481 2008-09-01 Marek Safar <marek.safar@gmail.com>
3483 A fix for bug #421736
3484 * iterators.cs: Don't crash on unreachable iterators.
3486 2008-09-01 Marek Safar <marek.safar@gmail.com>
3488 A fix for bug #421628
3489 * parameter.cs, attribute.cs: Clone also parameter attributes.
3491 2008-08-30 Miguel de Icaza <miguel@novell.com>
3493 * namespace.cs (LookupType): In EvalMode, try to replace
3494 the TypeBuilder from our cache with a Type as Reflection.Emit does
3495 not like to mix code from older assemblies emitted and new
3498 This sounds like a serious Mono bug that prevents multiple
3499 assemblies to be generated and consumed at the same time.
3501 * cs-parser.jay (push_current_class): Do not make interactive
3502 classes internal or private, make them public as we currently
3503 generate each new class in a new assembly.
3505 2008-08-29 Miguel de Icaza <miguel@novell.com>
3507 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3508 remove types that are entered into the global namespace during
3509 parsing so that we can remove them on failure.
3511 * cs-parser.jay: Parsing: we now keep track of types that are
3512 entered into global variables and queue those in case the parsing
3515 This happens in a few situations: during partial-input, we invoke
3516 the parser repeatedly for example with the string "class X", this
3517 would cause X to be registed, and we need to remove this
3518 registration so that another parse attempt later with say "class X {"
3519 would actually work.
3521 Additionally, if there is an error in the resolution phase, for
3522 example: "class X : NonExistant {}" th
3524 * cs-parser.jay: Be more precise with the errors being raised,
3525 instead of flagging all exceptions during parsing to be attributed
3526 to the parsing process, distinguish those from errors happening in
3527 the actions and hint that using -v would produce the actual
3530 * repl.cs: Do not load all compiler references on each reset,
3531 doing the partial reset takes care of this.
3533 2008-08-28 Miguel de Icaza <miguel@novell.com>
3535 * repl.cs: Add support for loading all the files from
3536 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3539 Introduce a micro-parser that is able to deambiguate on its input
3540 whether we are dealing with a compilation unit (namespace, class,
3541 interface, struct, delegate) declaration or a statement. This
3542 allows both declarations and statements to be entered.
3544 Set history size by default to 300 lines.
3546 Instead of distinguishing based on the parser.InteractiveResult,
3547 have only two cases: statements were parsed, or a compilation unit
3548 was. Always pull the Using statement additions from the
3549 compilation unit parse.
3551 * cs-tokenizer.cs: Rename tokens to better describe their intent
3552 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3554 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3555 EvalMode is used to trigger the lookup of global variables while
3556 StatementMode is used turn variable declarations into static
3559 * getline.cs: Allow history size to be set.
3561 2008-08-29 Marek Safar <marek.safar@gmail.com>
3563 A fix for bug #360755
3564 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3566 2008-08-29 Marek Safar <marek.safar@gmail.com>
3568 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3570 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3571 member name, it is too confusing
3573 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3575 * rootcontext.cs: Finally default to warning level 4.
3577 2008-08-28 Marek Safar <marek.safar@gmail.com>
3579 * class.cs (CheckBase): Ignore overloaded operators.
3581 2008-08-28 Marek Safar <marek.safar@gmail.com>
3583 A fix for bug #420830
3584 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3586 2008-08-28 Marek Safar <marek.safar@gmail.com>
3588 A fix for bug #420832
3589 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3591 2008-08-28 Marek Safar <marek.safar@gmail.com>
3593 A fix for bug #420386
3594 * nullables.cs: Fixed logic of nullable user comparison operators involving
3597 2008-08-28 Marek Safar <marek.safar@gmail.com>
3599 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3601 2008-08-27 Miguel de Icaza <miguel@novell.com>
3603 * repl.cs: Add support for aborting the running code with C-c.
3605 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3607 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3609 2008-08-27 Miguel de Icaza <miguel@novell.com>
3611 * cs-parser.jay (interactive_statement_list): A new set of rules
3612 for hosting statements that uses the "interactive_" prefix.
3614 * repl.cs: Add support for parsing `using' as a statement or as a
3615 directive. Deambiguating before passing this to the parser.
3617 We need to distinguish statement_expressions that occur at the
3618 toplevel vs those that occur embedded into expressions.
3620 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3621 that fixes the cursor key handling, and a history bug.
3623 2008-08-26 Miguel de Icaza <miguel@novell.com>
3625 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3626 limitations in Console, instead the 2.0 bootstrap libraries now
3627 include the Console bits.
3629 Also, remove the use of Nullables from getline.cs
3633 Interactive support for the C# compiler. Use gmcs --shell to
3634 enter a read-eval-print loop shell.
3636 Docs: http://www.mono-project.com/CsharpRepl
3638 * sources: include repl.cs here and getline.cs for gmcs.exe,
3639 everything else is getline.cs impaired.
3641 * Makefile: when bootstrapping pass a special flag
3642 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3643 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3644 This distinguishes those two cases.
3646 * repl.cs: Support for a read-eval-print loop. Will be soon
3647 refactored into eval support and then REPL on top of it.
3649 * ecore.cs: If a simplename lookup fails, before erroring out,
3650 if we are in EvalMode to resolve the name to a declaration in the
3653 This means that variable declarations that happened in previous
3654 classes (as repl puts every statement in a separate class) are
3655 made visible in this way.
3657 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3658 triggered an error due to the end of file being reached. This is
3659 used to do multi-line input, and notify the caller that the user
3660 needs to provide more text before a successful parse.
3662 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3663 to drive the evaluation with a custom wrapper.
3665 * driver.cs: Add support for --shell, and refactor some code to be
3668 * namespace.cs: Add support for serializing the contents of the
3669 namespaces and reloading them.
3671 * getline.cs: A managed implementation of ReadLine under
3672 X11/Apache2 license terms. Easy to embed in other applications as
3675 * namespace.cs: Add some functions to save and restore the
3678 * rootcontext.cs: New public field.
3680 * cs-tokenizer.cs: Add support for one of the possible characters
3681 we introduce into the token stream.
3683 This patch does not affect the regular tokenization process, the
3684 only performance hit would happen if there is an invalid character
3685 on the input string.
3687 * support.cs: Move isatty helper routine here.
3689 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3690 code generator for in-memory assemblies.
3692 2008-08-26 Marek Safar <marek.safar@gmail.com>
3694 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3695 parameter cannot be always used as a type.
3697 2008-08-21 Marek Safar <marek.safar@gmail.com>
3699 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3701 2008-08-21 Marek Safar <marek.safar@gmail.com>
3703 * convert.cs: Implement explicit array to IList<T> conversion.
3705 2008-08-20 Marek Safar <marek.safar@gmail.com>
3707 A fix for bug #362740
3708 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3710 2008-08-20 Marek Safar <marek.safar@gmail.com>
3712 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3713 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3714 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3715 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3716 handling to use just one type of infrastructure and deal with generics
3719 2008-07-23 Martin Baulig <martin@ximian.com>
3721 *** Merged this from trunk revision 108527 ***
3724 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3725 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3728 2008-08-15 Marek Safar <marek.safar@gmail.com>
3730 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3733 2008-08-15 Marek Safar <marek.safar@gmail.com>
3735 * delegate.cs: Fixed compiler crash when creating delegate using partial
3738 * typemanager.cs: MulticastDelegate is not a delegate.
3740 2008-08-14 Marek Safar <marek.safar@gmail.com>
3742 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3745 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3747 * cs-parser.jay (type): Allow 'var' in mcs too.
3748 (local_variable_type): Likewise.
3750 2008-08-14 Marek Safar <marek.safar@gmail.com>
3752 * driver.cs: Removed broken -noconfig variants.
3754 2008-08-14 Marek Safar <marek.safar@gmail.com>
3756 A fix for bug #417078
3757 * expression.cs: Emit correctly left side pointer operators.
3759 2008-08-13 Marek Safar <marek.safar@gmail.com>
3761 * generic.cs, lambda.cs: Inflate method generic arguments only.
3763 2008-08-12 Marek Safar <marek.safar@gmail.com>
3765 * class.cs: Fixed struct layout check regression.
3767 2008-08-12 Marek Safar <marek.safar@gmail.com>
3769 * cs-parser.jay, enum.cs: Simplified enum parsing.
3771 * decl.cs: Check all type parameters conflicts.
3773 * expression.cs, statement.cs, attribute.cs: More expression checks.
3775 2008-08-11 Marek Safar <marek.safar@gmail.com>
3777 * generic.cs: Add type inference types restriction.
3779 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3780 anonymous.cs, expression.cs: Allocate less accessor parameters.
3782 2008-08-08 Marek Safar <marek.safar@gmail.com>
3784 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3787 2008-08-08 Marek Safar <marek.safar@gmail.com>
3789 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3791 2008-08-07 Marek Safar <marek.safar@gmail.com>
3793 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3794 Also fixes #362146 and #381592.
3796 2008-08-07 Marek Safar <marek.safar@gmail.com>
3798 * ecore.cs: Reduced constant cannot be used as an attribute value.
3800 * cs-parser.jay: Base expression has to be a type.
3802 * expression.cs (Conditional): Uses ReducedExpression.
3804 2008-08-06 Marek Safar <marek.safar@gmail.com>
3806 A fix for bug #376826
3807 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3808 address of hoisted local variable or parameter cannot be taken.
3810 2008-08-05 Marek Safar <marek.safar@gmail.com>
3812 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3813 anonymous method inside checked/unchecked expression.
3815 2008-08-05 Marek Safar <marek.safar@gmail.com>
3817 * typemanager.cs (IsEqual): Guard against null.
3819 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3820 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3821 routine. Fixed few misleading conversion errors.
3823 2008-08-04 Marek Safar <marek.safar@gmail.com>
3825 * class.cs: Consider generics when checking cycles in struct layout.
3827 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3829 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3831 2008-08-04 Marek Safar <marek.safar@gmail.com>
3833 A fix for bug #414165
3834 * anonymous.cs: Use same anonymous implementation method for all anonymous
3837 2008-08-04 Marek Safar <marek.safar@gmail.com>
3839 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3842 2008-08-04 Marek Safar <marek.safar@gmail.com>
3844 * cs-parser.jay: Typeof argument has to be a type expression.
3846 * namespace.cs: Check alias and namespace definitions collisions.
3848 * class.cs, pending.cs: Moved explicit interface accessor implementation
3851 * delegate.cs, expression.cs: Verify special name invocations.
3853 2008-08-01 Marek Safar <marek.safar@gmail.com>
3855 * cs-parser.jay: Don't choke on empty generic type arguments.
3857 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3859 * expression.cs, ecore.cs: Minor expressions bugs.
3861 2008-08-01 Marek Safar <marek.safar@gmail.com>
3863 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3864 and added more error handling.
3866 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3868 * modifiers.cs, enum.cs: Fixed.
3870 2008-07-31 Jb Evain <jbevain@novell.com>
3872 * driver.cs: remove -pkg ability of smcs.
3874 2008-07-30 Marek Safar <marek.safar@gmail.com>
3876 * statement.cs (Switch): Correctly set empty default target for single
3879 2008-07-30 Marek Safar <marek.safar@gmail.com>
3881 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3882 string switch statement implementation to use string dictionary which
3883 significantly (2-8x) improves performance of generated code.
3885 2008-07-29 Marek Safar <marek.safar@gmail.com>
3887 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3888 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3890 2008-07-29 Marek Safar <marek.safar@gmail.com>
3892 A fix for bug #412595
3893 * typemanager.cs, convert.cs, expression.cs: Some types are never
3894 convertible to each other.
3896 2008-07-29 Marek Safar <marek.safar@gmail.com>
3898 * nullable.cs (CreateNullConstant): An error messages update.
3900 2008-07-29 Marek Safar <marek.safar@gmail.com>
3902 A fix for bug #412595
3903 * cfold.cs: Don't cast undefined bool constant.
3905 2008-07-29 Martin Baulig <martin@ximian.com>
3908 (SymbolWriter.Reset): New public static method.
3911 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3913 2008-07-28 Marek Safar <marek.safar@gmail.com>
3915 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3917 * expression.cs (ElementAccess): Exact size allocation.
3919 2008-07-26 Marek Safar <marek.safar@gmail.com>
3921 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3923 2008-07-25 Marek Safar <marek.safar@gmail.com>
3925 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3927 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3930 2008-07-25 Marek Safar <marek.safar@gmail.com>
3932 A fix for bug #412217
3933 * assign.cs: Mutate also assignment type.
3935 2008-07-25 Marek Safar <marek.safar@gmail.com>
3937 A fix for bug #323644
3938 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3941 2008-07-25 Marek Safar <marek.safar@gmail.com>
3943 A fix for bug #412134
3944 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3945 non-enumerable operands when overloading equality or bitwise operators.
3947 2008-07-25 Marek Safar <marek.safar@gmail.com>
3949 * anonymous.cs: Cache closed generic anonymous method delegates.
3951 2008-07-24 Marek Safar <marek.safar@gmail.com>
3953 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3954 anonymous.cs, statement.cs: Always emit anonymous method as static method
3955 when is instance free. Use nesting for nested anynomous methods blocks.
3957 2008-07-23 Marek Safar <marek.safar@gmail.com>
3959 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3962 2008-07-23 Marek Safar <marek.safar@gmail.com>
3964 * expression.cs: Removed MakeSimpleCall.
3966 2008-07-23 Marek Safar <marek.safar@gmail.com>
3968 A fix for bug #323012
3969 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3970 Base method implementing interface has to be public.
3972 2008-07-23 Marek Safar <marek.safar@gmail.com>
3974 * cs-parser.jay: Don't break on missing argument.
3976 2008-07-22 Marek Safar <marek.safar@gmail.com>
3978 A fix for bug #320993
3979 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3980 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3982 2008-07-22 Marek Safar <marek.safar@gmail.com>
3984 A fix for bug #320748
3985 * convert.cs: Implicit user operators cannot convert to interfaces
3987 2008-07-22 Marek Safar <marek.safar@gmail.com>
3989 A fix for bug #312686
3990 * driver.cs: Ignore empty assembly references.
3992 2008-07-22 Marek Safar <marek.safar@gmail.com>
3994 A fix for bug #387040
3995 * ecore.cs: Skip constrains check for an explicit implementation.
3997 2008-07-21 Marek Safar <marek.safar@gmail.com>
3999 A fix for bug #409045
4000 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
4001 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
4002 identifiers are file specific unless passed as input arguments.
4004 2008-07-21 Marek Safar <marek.safar@gmail.com>
4006 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
4007 to emit UnmanagedMarshal data under 2.0 profile.
4009 2008-07-21 Marek Safar <marek.safar@gmail.com>
4011 A fix for bug #410369
4012 * parameter.cs: Clone correctly ParamsParameter.
4014 2008-07-21 Marek Safar <marek.safar@gmail.com>
4016 * expression.cs (Argument): Always report type for type based expressions
4019 2008-07-18 Marek Safar <marek.safar@gmail.com>
4021 A fix for bug #410666
4022 * anonymous.cs: Correctly initialize generic storey reference.
4024 2008-07-18 Marek Safar <marek.safar@gmail.com>
4026 * convert.cs: Don't box same type arguments.
4028 2008-07-18 Marek Safar <marek.safar@gmail.com>
4030 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
4031 Finished missing generic type mutators.
4033 2008-07-18 Marek Safar <marek.safar@gmail.com>
4035 * iterators.cs, statement.cs: Finished statements CloneTo.
4037 2008-07-18 Marek Safar <marek.safar@gmail.com>
4039 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
4041 * expression.cs: Emit optimized default value expressions in expression tree
4044 2008-07-18 Marek Safar <marek.safar@gmail.com>
4046 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
4048 2008-07-17 Marek Safar <marek.safar@gmail.com>
4050 A fix for bug #367536
4051 * cs-parser.jay: Check static constructor of generic types for an access
4054 2008-07-17 Marek Safar <marek.safar@gmail.com>
4056 A fix for bug #353800
4057 * lambda.cs: Emit ret for contextual statements.
4059 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
4060 up emitting redundant ret for all anonymous methods with return.
4062 2008-07-17 Marek Safar <marek.safar@gmail.com>
4064 A fix for bug #365188
4065 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
4066 create anonymous method storey in unreachable block.
4068 2008-07-17 Marek Safar <marek.safar@gmail.com>
4070 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
4071 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
4072 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
4073 statement.cs: Fixed relevant defects found by Gendarme.
4075 2008-07-17 Marek Safar <marek.safar@gmail.com>
4077 A fix for bug #325291
4078 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
4079 statement.cs: Replaced IAnonymousHost with top level block flag.
4081 2008-07-17 Marek Safar <marek.safar@gmail.com>
4083 * cs-parser.jay: Clean up unused open_parens.
4085 2008-07-17 Marek Safar <marek.safar@gmail.com>
4087 * ecore.cs: Custom error message for a range variable assignment.
4089 2008-07-16 Marek Safar <marek.safar@gmail.com>
4091 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
4094 2008-07-16 Marek Safar <marek.safar@gmail.com>
4096 * literal.cs: Null literal is of object type.
4098 2008-07-16 Marek Safar <marek.safar@gmail.com>
4100 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
4101 expression of nullable equality comparison.
4103 2008-07-15 Marek Safar <marek.safar@gmail.com>
4105 * expression.cs(PointerArithmetic): Removed redundant assignment.
4107 2008-07-15 Marek Safar <marek.safar@gmail.com>
4109 * decl.cs (GetSignatureForError): Report full namespace name for containers.
4111 2008-07-14 Marek Safar <marek.safar@gmail.com>
4113 A fix for bug #408361
4114 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
4115 they are replaced by GetMethod.
4117 2008-07-14 Marek Safar <marek.safar@gmail.com>
4119 A fix for bug #408721 by jeremie.laval@gmail.com
4120 * expression.cs (Indirection): Implemented CloneTo.
4122 2008-07-14 Marek Safar <marek.safar@gmail.com>
4124 * statement.cs (AssignableSlots): Temporary disabled variable initialization
4127 2008-07-14 Marek Safar <marek.safar@gmail.com>
4129 * report.cs (EnableReporting): Don't reinitialize 0-based values.
4131 2008-07-11 Marek Safar <marek.safar@gmail.com>
4133 * linq.cs: Reset tranparent parameter counter in probing mode.
4135 2008-07-11 Marek Safar <marek.safar@gmail.com>
4137 * anonymous.cs: Mutate anonymous method type.
4139 2008-07-11 Marek Safar <marek.safar@gmail.com>
4141 * ecore.cs, anonymous.cs: Mutate field expressions.
4143 2008-07-10 Marek Safar <marek.safar@gmail.com>
4145 A fix for bug #369670
4146 * linq.cs, statement.cs: Use explicit block for query expressions variables.
4148 2008-07-10 Marek Safar <marek.safar@gmail.com>
4150 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
4152 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
4155 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
4156 only one '>', and finds a '>>', abort the generic lookahead.
4158 2008-07-10 Marek Safar <marek.safar@gmail.com>
4160 A fix for bug #319902
4161 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
4163 2008-07-10 Marek Safar <marek.safar@gmail.com>
4165 A fix for bug #406371
4166 * statement.cs: Moved EmitSymbolInfo to Block.
4168 2008-07-09 Marek Safar <marek.safar@gmail.com>
4170 * ecore.cs: Report better error for extension method overload failures.
4172 2008-07-09 Marek Safar <marek.safar@gmail.com>
4174 * expression.cs (Is): No need to box reference values.
4176 2008-07-09 Marek Safar <marek.safar@gmail.com>
4178 * class.cs: Use event resolve context when initializing CreateEmitContext.
4180 2008-07-09 Marek Safar <marek.safar@gmail.com>
4182 A fix for bug #394436
4183 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
4184 method used inside expression trees. Added more LINQ to expression tree
4187 2008-07-08 Marek Safar <marek.safar@gmail.com>
4189 A fix for bug #378189, #370577
4190 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
4193 2008-07-08 Marek Safar <marek.safar@gmail.com>
4195 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
4198 2008-07-08 Marek Safar <marek.safar@gmail.com>
4200 A fix for bug #406702
4201 * anonymous.cs: Always park anonymous method in the nearest parent storey.
4203 2008-07-07 Marek Safar <marek.safar@gmail.com>
4205 A fix for bug #406648
4206 * cs-parser.jay: Report nullable use in mcs for some cases.
4208 2008-07-07 Marek Safar <marek.safar@gmail.com>
4210 * ecore.cs: Improved argument mismatch error messages.
4212 2008-07-07 Marek Safar <marek.safar@gmail.com>
4214 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
4216 2008-07-07 Marek Safar <marek.safar@gmail.com>
4218 * expression.cs (TypeOf): Mutate type argument.
4220 2008-07-04 Marek Safar <marek.safar@gmail.com>
4222 * class.cs: Report missing partial modifier for correct type.
4224 2008-07-04 Marek Safar <marek.safar@gmail.com>
4226 * ecore.cs, expression.cs (VariableReference): Variable property is
4229 2008-07-04 Marek Safar <marek.safar@gmail.com>
4231 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4233 2008-07-04 Marek Safar <marek.safar@gmail.com>
4235 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4238 2008-07-04 Marek Safar <marek.safar@gmail.com>
4240 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4241 anonymous method storey to an instance method when only "this" is hoisted.
4243 2008-07-03 Marek Safar <marek.safar@gmail.com>
4245 A fix for bug #321615
4246 * expression.cs: Pointer comparisons use unsigned operator.
4248 2008-07-03 Marek Safar <marek.safar@gmail.com>
4250 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4252 2008-07-02 Marek Safar <marek.safar@gmail.com>
4254 A fix for bug #404905
4255 * class.cs: Always initialize local unsafe variables.
4257 2008-06-30 Marek Safar <marek.safar@gmail.com>
4259 A fix for bug #396987
4260 * expression.cs (NewInitialize): Clear local temporary variable for next run
4262 2008-06-27 Marek Safar <marek.safar@gmail.com>
4264 A fix for bug #401020
4265 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4267 2008-06-27 Marek Safar <marek.safar@gmail.com>
4269 A fix for bug #398319
4270 * cs-parser.jay: Implemented undocumented base access expression inside
4273 2008-06-26 Marek Safar <marek.safar@gmail.com>
4275 A fix for bug #404227
4276 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4278 2008-06-26 Marek Safar <marek.safar@gmail.com>
4280 A fix for bug #404227
4281 * convert.cs: Fixed explicit array to interface cast.
4283 2008-06-26 Marek Safar <marek.safar@gmail.com>
4285 A fix for bug #403894
4286 * delegate.cs: Mutate DelegateInvocation type.
4288 2008-06-26 Marek Safar <marek.safar@gmail.com>
4290 A fix for bug #379348
4291 * delegate.cs: Box a load of generic parameters.
4293 2008-06-26 Marek Safar <marek.safar@gmail.com>
4295 * expression.cs: Add an array creation arguments mutate.
4297 2008-06-26 Marek Safar <marek.safar@gmail.com>
4299 A fix for bug #386068
4300 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4303 2008-06-25 Marek Safar <marek.safar@gmail.com>
4305 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4308 2008-06-25 Marek Safar <marek.safar@gmail.com>
4310 A fix for bug #403518
4311 * delegate.cs: Type correctly anonymous method new invocation.
4313 2008-06-24 Marek Safar <marek.safar@gmail.com>
4315 A fix for bug #394826
4316 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4319 2008-06-24 Marek Safar <marek.safar@gmail.com>
4321 A fix for bug #394826
4322 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4325 2008-06-24 Marek Safar <marek.safar@gmail.com>
4327 * class.cs: Clone indexer parameters for localized capturing.
4329 2008-06-24 Marek Safar <marek.safar@gmail.com>
4331 A fix for bug #402379
4332 * expression.cs: Don't crash when an object initializer resolve fails.
4334 2008-06-24 Marek Safar <marek.safar@gmail.com>
4336 A fix for bug #402888
4337 * expression.cs: Mutate conditional expression.
4339 2008-06-24 Marek Safar <marek.safar@gmail.com>
4341 A fix for bug #401012
4342 * class.cs: Keep StructLayout in shared container.
4344 2008-06-24 Marek Safar <marek.safar@gmail.com>
4346 A fix for bug #400438
4347 * decl.cs, class.cs: Only properties can be automatically implemented.
4349 2008-06-24 Marek Safar <marek.safar@gmail.com>
4351 * statement.cs (ChangeToIterator): Copy also labels.
4353 2008-06-23 Marek Safar <marek.safar@gmail.com>
4355 * ecore.cs: Pass type argument details to parent extension method.
4357 2008-06-23 Marek Safar <marek.safar@gmail.com>
4359 A fix for bug #375966
4360 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4362 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4364 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4366 2008-06-22 Marek Safar <marek.safar@gmail.com>
4368 A fix for bug #394347
4369 * anonymous.cs: Cache compatible delegates as compatibility check produces
4370 a new method every time.
4372 2008-06-20 Marek Safar <marek.safar@gmail.com>
4374 * anonymous.cs: Propagate storey reference for single references.
4376 2008-06-20 Marek Safar <marek.safar@gmail.com>
4378 A fix for bug #387615
4379 * assign.cs, expression.cs: Correctly clone compound assignment.
4381 2008-06-19 Marek Safar <marek.safar@gmail.com>
4383 A fix for bug #359611, #359604
4384 * anonymous.cs: Mutate all types of hoisted parameters.
4386 2008-06-19 Marek Safar <marek.safar@gmail.com>
4388 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4389 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4390 expression.cs, codegen.cs, statement.cs
4392 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4393 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4395 ** Anonymous methods, lambda expressions rewrite **
4397 Anonymous expressions are now resolved when an explicit block is resolved
4398 and they don't require any registration procedure anymore. Further,
4399 anonymous methods are defined when explicit block is emitted which allows
4400 better control of whole process and opens possibilities for more
4401 optimizations as well as alternative to reverse whole process.
4403 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4404 process consistent and to correctly emit hoisted generic methods when they
4405 have at least 1 hoisted variable.
4407 2008-06-17 Martin Baulig <martin@ximian.com>
4409 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4411 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4412 virtual property; check it in Emit().
4413 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4415 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4417 (Indexer.Define): Likewise.
4419 2008-06-17 Marek Safar <marek.safar@gmail.com>
4421 * convert.cs: Don't use IsInterface on type arguments.
4423 * delegate.cs: DelegateInvocation uses MethodInfo.
4425 * parameter.cs: Removed IsTypeParameter.
4427 * generic-mcs.cs: More missing stuff.
4429 2008-06-16 Martin Baulig <martin@ximian.com>
4432 (Modifiers.DEBUGGER_HIDDEN): New public const.
4435 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4438 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4439 (AbstractPropertyEventMethod): Likewise.
4440 (Constructor.Emit): Likewise.
4441 (SourceMethod.SetCompilerGenerated): Removed.
4443 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4447 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4448 if we're an `IteratorHost'.
4449 (AnonymousMethodMethod..ctor): Don't set
4450 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4453 2008-06-16 Marek Safar <marek.safar@gmail.com>
4455 * statement.cs: Clean-up foreach statements.
4457 2008-06-12 Marek Safar <marek.safar@gmail.com>
4459 * class.cs: Stop using public method which should not exist
4460 (MethodBuilder.SetGenericMethodSignature).
4462 2008-06-11 Martin Baulig <martin@ximian.com>
4465 (Location.LookupFile): Add `CompilationUnit' argument; when given
4466 a relative file name, make it relative to the directory the .cs
4467 file is located in instead of using the current directory.
4469 2008-06-11 Martin Baulig <martin@ximian.com>
4472 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4473 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4474 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4475 (SourceMethod.SetCompilerGenerated): Likewise.
4477 2008-06-11 Marek Safar <marek.safar@gmail.com>
4479 * codegen.cs, driver: Only write symbol file when it's asked for.
4481 2008-06-11 Marek Safar <marek.safar@gmail.com>
4483 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4485 2008-06-10 Martin Baulig <martin@ximian.com>
4487 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4489 2008-06-09 Marek Safar <marek.safar@gmail.com>
4491 A fix for bug #316290
4492 * expression.cs: Include decimal operators in predefined table.
4494 * parameters.cs: More readonlyness.
4496 2008-06-09 Marek Safar <marek.safar@gmail.com>
4498 A fix for bug #397213
4499 * cs-parser.jay: One more missing current_local_parameters reset.
4501 2008-06-09 Marek Safar <marek.safar@gmail.com>
4503 A fix for bug #396633
4504 * class.cs: Host backing field in partial container.
4506 2008-06-09 Marek Safar <marek.safar@gmail.com>
4508 A fix for bug #397068
4509 * expression.cs: Check both operand types when predefined operator is used.
4511 2008-06-05 Martin Baulig <martin@ximian.com>
4513 Merged the `debugger-kahalo' branch.
4516 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4517 we're an iterator method.
4518 (SourceMethod): Reflect latest symbol writer changes;
4519 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4520 now `start_row' and `end_row'.
4521 (Constructor.Emit): Fix the logic whether to emit symbol information.
4523 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4527 (CompilationUnit): New public class; derives from `SourceFile'.
4528 (SourceFileEntry.DefineSymbolInfo): New public method.
4529 (SourceFileEntry.SetChecksum): New public method.
4530 (Location): Encode hidden line numbers by using `column == 255';
4531 the .ctor now accepts `column == -1' to mark a hidden line number.
4532 (Location.Hidden): New public property.
4533 (Location.CheckPoint): Add `CompilationUnit'.
4534 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4535 (Location.Push): Add `CompilationUnit compile_unit' argument.
4536 (Location.CompilationUnit): New public property.
4539 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4541 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4543 * driver.cs: `SourceFile' -> `CompilationUnit'.
4545 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4547 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4549 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4553 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4554 new symbol writer API to also pass the file.
4556 2008-06-05 Marek Safar <marek.safar@gmail.com>
4558 * statement.cs: Emit catch variable assignment using variable expression.
4560 2008-06-05 Marek Safar <marek.safar@gmail.com>
4562 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4563 with other variable types.
4565 2008-06-04 Marek Safar <marek.safar@gmail.com>
4567 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4568 GetLength method emit, it breaks resolve rules.
4570 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4571 Marek Safar <marek.safar@gmail.com>
4573 A fix for bug #395542
4574 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4577 2008-06-02 Marek Safar <marek.safar@gmail.com>
4579 A fix for bug #395287
4580 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4582 2008-05-31 Marek Safar <marek.safar@gmail.com>
4584 A fix for bug #395845
4585 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4586 non-nullable parameter type.
4588 2008-05-31 Marek Safar <marek.safar@gmail.com>
4590 * class.cs: Handle contructor initializer as a statement in top-level block.
4592 2008-05-30 Marek Safar <marek.safar@gmail.com>
4594 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4595 security attributes.
4597 2008-05-24 Marek Safar <marek.safar@gmail.com>
4599 * ecore.cs, expression.cs: Small IVariable refactoring.
4601 2008-05-22 Marek Safar <marek.safar@gmail.com>
4603 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4605 2008-05-21 Marek Safar <marek.safar@gmail.com>
4607 * cs-parser.jay: Removed redundant catch type check.
4609 2008-05-21 Marek Safar <marek.safar@gmail.com>
4611 A fix for bug #390372
4612 * nullable.cs: Set correct return type.
4614 2008-05-21 Marek Safar <marek.safar@gmail.com>
4616 A fix for bug #391062
4617 * typemanager.cs: Fixed crash when comparing null types.
4619 2008-05-21 Marek Safar <marek.safar@gmail.com>
4621 A fix for bug #391871
4622 * cs-parser.jay: Better error handling for invalid catch type.
4624 2008-05-20 Marek Safar <marek.safar@gmail.com>
4626 A fix for bug #392155
4627 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4629 2008-05-15 Marek Safar <marek.safar@gmail.com>
4631 A fix for bug #390666
4632 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4635 2008-05-15 Marek Safar <marek.safar@gmail.com>
4637 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4640 2008-05-13 Marek Safar <marek.safar@gmail.com>
4642 A fix for bug #389625
4643 * delegate.cs, generic.cs: Some progress on method group return type
4646 2008-05-13 Marek Safar <marek.safar@gmail.com>
4648 A fix for bug #378419
4649 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4651 2008-05-12 Marek Safar <marek.safar@gmail.com>
4653 * class.cs (Constructor): Added IsCompilerGenerated.
4655 2008-05-12 Marek Safar <marek.safar@gmail.com>
4657 * expression.cs: Enum binary operators can accept non-enum operand only when
4658 is implicitly convertible to underlying type.
4660 2008-05-12 Marek Safar <marek.safar@gmail.com>
4662 A fix for bug #389272
4663 * support.cs: Workaround System.InvalidOperationException for enums.
4665 2008-05-12 Marek Safar <marek.safar@gmail.com>
4667 A fix for bug #389073
4668 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4670 2008-05-10 Marek Safar <marek.safar@gmail.com>
4672 * driver.cs: Split Parse.
4674 * location.cs (LookupFile): Uses string.Empty.
4676 2008-05-07 Marek Safar <marek.safar@gmail.com>
4678 * expression.cs, parameter.cs: Small ParameterReference clean up.
4680 2008-05-07 Marek Safar <marek.safar@gmail.com>
4682 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4683 hack. Fixes #387502.
4685 2008-05-06 Martin Baulig <martin@ximian.com>
4687 * class.cs (Constructor.Emit): Fix the logic whether to emit
4690 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4693 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4694 InvalidOperationException when the iterator is before the start or
4697 2008-05-06 Marek Safar <marek.safar@gmail.com>
4699 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4700 when left is nullable type.
4702 2008-05-06 Marek Safar <marek.safar@gmail.com>
4704 A fix for bug #386628
4705 * expression.cs (LocalVariableReference): Continue in resolving when
4706 variable is not assigned.
4708 2008-05-05 Marek Safar <marek.safar@gmail.com>
4710 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4711 nullable operations.
4713 2008-05-04 Marek Safar <marek.safar@gmail.com>
4715 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4716 it saves many redundant temporary variables for nullable operations.
4718 2008-05-03 Marek Safar <marek.safar@gmail.com>
4720 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4722 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4725 * nullable.cs: Constant coalescing operator optimizations.
4727 2008-05-03 Marek Safar <marek.safar@gmail.com>
4729 * constant.cs: Use unsigned conversion for values which are unsigned only.
4731 2008-05-03 Marek Safar <marek.safar@gmail.com>
4733 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4734 coalescing operator as it should be.
4736 2008-05-02 Marek Safar <marek.safar@gmail.com>
4738 A fix for bug #371016
4739 * expression.cs: All predefined delegate operators require implicit method
4742 2008-05-02 Marek Safar <marek.safar@gmail.com>
4744 * constant.cs: Emit long constant as uint when fits the range.
4746 * convert.cs, expression.cs: Fixed few unsafe conversions.
4748 2008-05-02 Marek Safar <marek.safar@gmail.com>
4750 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4752 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4755 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4757 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4759 2008-05-01 Marek Safar <marek.safar@gmail.com>
4761 * constant.cs, literal.cs: IsLiteral property for error reporting.
4763 * ecore.cs, expression.cs: Implemented Property expression.
4765 2008-05-01 Marek Safar <marek.safar@gmail.com>
4767 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4769 * nullable.cs: Implemented nullable coalescing null operator.
4771 * ecore.cs, expression.cs: Expression trees work.
4773 2008-05-01 Marek Safar <marek.safar@gmail.com>
4775 * ecore.cs: CreateExpressionTree is finally abstract.
4777 * expression.cs, linq.cs: Updated.
4779 2008-05-01 Marek Safar <marek.safar@gmail.com>
4781 * expression.cs, ecore.cs: Block base access expression inside expression
4784 2008-05-01 Marek Safar <marek.safar@gmail.com>
4786 A fix for bug #385058
4787 * expression.cs: User-defined operator implementations always take
4788 precedence over predefined operator implementations.
4790 2008-04-30 Marek Safar <marek.safar@gmail.com>
4792 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4793 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4794 expression tree conversions.
4796 2008-04-30 Marek Safar <marek.safar@gmail.com>
4798 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4799 operators method details to Operator class.
4801 2008-04-30 Marek Safar <marek.safar@gmail.com>
4803 * anonymous.cs: Pass unsafe flags to anonymous container.
4805 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4806 inside expression tree.
4808 2008-04-29 Martin Baulig <martin@ximian.com>
4810 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4811 (Tokenizer.PopPosition): Also restore the `line'.
4813 2008-04-29 Marek Safar <marek.safar@gmail.com>
4815 * delegate.cs: Implemented Invoke expression.
4817 2008-04-29 Marek Safar <marek.safar@gmail.com>
4819 * expression.cs: Fixed equality reference comparison regression.
4821 2008-04-29 Marek Safar <marek.safar@gmail.com>
4823 * ecore.cs: Clean up EmptyCast hack.
4825 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4826 using correct conversion rules. Also fixes #383993.
4828 2008-04-28 Martin Baulig <martin@ximian.com>
4830 * class.cs (Constructor.Emit): Don't emit debugging information
4831 for generated default .ctor's.
4833 2008-04-28 Marek Safar <marek.safar@gmail.com>
4835 * convert.cs: Empty-cast ushort to int conversion.
4837 2008-04-28 Marek Safar <marek.safar@gmail.com>
4839 A fix for bug #384191
4840 * ecore.cs, expression.cs: Fixed expression cloning.
4842 2008-04-28 Marek Safar <marek.safar@gmail.com>
4844 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4846 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4848 Fix #381559, test-638.cs, test-639.cs
4849 * assign.cs (CompoundAssign.Helper): New wrapper.
4850 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4852 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4853 Pass unconverted expressions to the params array creation expression.
4854 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4855 (PropertyExpr.EmitAssign): Likewise.
4856 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4857 element if it is of kind CompoundAssign.Helper.
4858 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4859 first before anything else.
4860 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4861 (ArrayAccess.LoadArrayAndArguments): Simplify.
4863 2008-04-27 Marek Safar <marek.safar@gmail.com>
4865 * expression.cs: Fixed cloning of typeof(void).
4867 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4869 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4870 (Assign.Emit): Likewise. Move it to ...
4871 (CompoundAssign.DoResolve): ... here and ...
4872 (CompoundAssign.Emit): ... here.
4873 (EventAddOrRemove): New helper to handle += and -= on events, and
4874 avoid the use of BinaryDelegates.
4875 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4876 (EventExpr.EmitAddOrRemove): Improve.
4877 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4879 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4880 create VarExprs for 'foo.bar.var'.
4881 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4882 is a highly inappropriate name for its functionality.
4884 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4886 Simplify handling of multiple assignments
4887 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4889 (SimpleAssign): New. Class to be used for normal assignments.
4890 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4891 * expression.cs, parameter.cs, statement.cs: Likewise.
4893 2008-04-25 Marek Safar <marek.safar@gmail.com>
4895 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4896 for incompatible underlying types, more to come, uff.
4898 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4901 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4902 Handle 'leave_copy'.
4904 2008-04-25 Marek Safar <marek.safar@gmail.com>
4906 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4908 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4910 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4911 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4912 * statement.cs (While, Do, For): Allow test to have side effects.
4913 (For.DoEmit): Always emit InitStatement.
4916 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4917 Always create SideEffectConstant.
4918 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4919 of type EnumConstant.
4921 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4922 Handle 'right' being SideEffectConstant of type 'bool'.
4924 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4925 Use left.EmitBranchable instead of open coding it, so as to
4926 improve optimization opportunities.
4928 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4930 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4932 (Expression.EmitSideEffect): Document.
4934 2008-04-23 Marek Safar <marek.safar@gmail.com>
4936 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4938 2008-04-23 Marek Safar <marek.safar@gmail.com>
4940 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4942 2008-04-23 Marek Safar <marek.safar@gmail.com>
4944 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4945 conversion to expression tree.
4947 2008-04-23 Marek Safar <marek.safar@gmail.com>
4949 * ecore.cs: Removed unused expression.
4951 2008-04-22 Marek Safar <marek.safar@gmail.com>
4953 * expression.cs: Implemented NegateChecked and New expressions.
4955 2008-04-22 Marek Safar <marek.safar@gmail.com>
4957 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4959 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4962 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4963 needing final 'ret' instruction.
4965 2008-04-22 Marek Safar <marek.safar@gmail.com>
4967 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4969 2008-04-21 Marek Safar <marek.safar@gmail.com>
4971 * expression.cs: Emit ldnull and not null expression as an instance argument
4972 of static method expression calls.
4974 2008-04-21 Marek Safar <marek.safar@gmail.com>
4976 A fix for bug #378200
4977 * expression.cs: Fixed crash when creating parameterless expression tree
4980 2008-04-21 Marek Safar <marek.safar@gmail.com>
4982 A fix for bug #375297
4983 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4986 2008-04-21 Marek Safar <marek.safar@gmail.com>
4988 A fix for bug #377596
4989 * decl.cs, class.cs: Emit delegate type argument attributes.
4991 2008-04-21 Marek Safar <marek.safar@gmail.com>
4993 A fix for bug #365314
4994 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4996 2008-04-21 Marek Safar <marek.safar@gmail.com>
4998 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
5001 2008-04-21 Marek Safar <marek.safar@gmail.com>
5003 * generic.cs (TypeParameter): Removed redundant location.
5005 2008-04-19 Marek Safar <marek.safar@gmail.com>
5007 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
5008 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
5009 FullNamedExpression in all declaration type expression, statements will come
5012 2008-04-18 Marek Safar <marek.safar@gmail.com>
5014 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
5015 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
5017 2008-04-18 Marek Safar <marek.safar@gmail.com>
5019 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
5022 2008-04-17 Marek Safar <marek.safar@gmail.com>
5024 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
5027 2008-04-17 Marek Safar <marek.safar@gmail.com>
5029 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
5033 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
5035 Hook up 'EmitSideEffect'
5036 * constant.cs (Constant.EmitSideEffect): New.
5037 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
5038 (SideEffectConstant.EmitSideEffect): New.
5039 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
5040 unconditional branch in EmitBranchable.
5041 (FieldExpr.EmitBranchable): New.
5042 * expression.cs (Unary.EmitSideEffect): New.
5043 (Binary.EmitSideEffect): New.
5044 (VariableReference.EmitSideEffect): New. Do nothing.
5046 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5048 Introduce 'EmitSideEffect'
5049 * ecore.cs (Expression.EmitSideEffect): New.
5050 (TypeCast): Rename from EmptyCast.
5052 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
5053 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
5054 * convert.cs, nullable.cs: Update to changes.
5056 2008-04-16 Marek Safar <marek.safar@gmail.com>
5058 * class.cs, cs-parser.jay: Early check for base types expression.
5060 2008-04-16 Marek Safar <marek.safar@gmail.com>
5062 * decl.cs (MemberName): Declare PrettyName as obsolete.
5064 2008-04-16 Marek Safar <marek.safar@gmail.com>
5066 * namespace.cs: Use MemberName comparison.
5068 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5071 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
5073 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
5074 (MemberName.FullyQualifiedName): New. Provides the functionality
5075 that users assume FullName would have.
5076 * ecore.cs, namespace.cs: Update to changes.
5078 * statement.cs (Using.assign): Make into ExpressionStatement.
5079 (Using.EmitPreTryBody): Simplify.
5081 2008-04-16 Marek Safar <marek.safar@gmail.com>
5083 * report.cs: ColorFormat is protected.
5085 * rootcontext.cs: Unused fields clean-up.
5087 * namespace.cs: Made UsingEntry name private.
5089 2008-04-16 Marek Safar <marek.safar@gmail.com>
5091 * cs-tokenizer.cs, location.cs: Removed unused field.
5093 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
5094 Raja R Harinath <harinath@hurrynot.org>
5097 * constant.cs (SideEffectConstant.value): Rename from 'left'.
5098 (SideEffectConstant.side_effect): Rename from 'right'.
5099 (SideEffectConstant..ctor): Normalize 'side_effect'.
5100 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
5101 value of this constant.
5102 * cfold.cs: Update to changes.
5104 2008-04-15 Marek Safar <marek.safar@gmail.com>
5106 * cs-paser.jay: Removed unused variable.
5108 * driver.cs: Made Compile instance method.
5110 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
5112 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
5114 2008-04-15 Marek Safar <marek.safar@gmail.com>
5116 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
5118 2008-04-13 Jb Evain <jbevain@novell.com>
5120 * namespace.cs: update the System.Core fullname for 2.1
5121 * driver.cs: update the list of required assemblies for 2.1.
5122 Merged from the Moonlight 2 branch.
5124 2008-04-11 Marek Safar <marek.safar@gmail.com>
5126 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
5127 types and user defined operators. User operators arguments has to be checked
5128 for null value before invocation, which also means no operator is called
5129 when any argument is not convertible to unwrapped nullable type.
5131 2008-04-09 Marek Safar <marek.safar@gmail.com>
5133 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
5134 of Unary expressions to follow operator overloading rules precisely.
5135 Also fixes #321794, #323794
5137 2008-04-08 Marek Safar <marek.safar@gmail.com>
5139 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
5142 2008-04-08 Marek Safar <marek.safar@gmail.com>
5144 * expression.cs, ecore.cs: Implemented MemberInit expression.
5146 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
5148 Fix mono/tests/exception4.cs
5149 * statement.cs (ExceptionStatement, TryCatch): Revert to using
5150 ec.NeedReturnLabel () rather emitting a 'nop'.
5152 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
5154 (TryCatch.SomeCodeFollows): Likewise.
5155 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
5156 for 'break', 'continue' and 'return' statements inside a try.
5157 We're fairly sure that the generated IL stream will have more
5158 instructions textually following the try.
5159 (FlowBranchingTryCatch): Likewise.
5161 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
5162 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
5165 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
5166 wrapper -- forward everything to CollectionForeach.
5167 (CollectionForeach.NonDisposableWrapper): New.
5168 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
5169 instead of a pop + branch to end.
5171 2008-04-07 Marek Safar <marek.safar@gmail.com>
5173 A fix for bug #377485
5174 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
5175 Propagate location for extension method groups. Report conversion failure at
5178 2008-04-07 Marek Safar <marek.safar@gmail.com>
5180 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
5181 ListInit and Field expressions.
5183 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
5185 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
5186 Since $PC is always -1 inside the body of MoveNext, the fault
5188 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
5189 * statement.cs (ExceptionStatement.emit_finally): Likewise.
5190 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
5192 The denouement! Fix #324708
5193 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
5194 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
5195 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
5196 'finally' inside the finally clause.
5198 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
5199 inside an iterator. Don't emit the body of the 'finally' inside
5200 the finally clause yet.
5202 Use the ResumableStatement infrastructure for MoveNext ()
5203 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
5204 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
5205 'old_resume_points'. Move dispatcher upfront.
5206 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
5207 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
5208 in an enumerator. This encodes the main fix in this patch series
5209 -- we can only jump into the first instruction of a try from the
5210 outside, but we want to emit try/finally regions in iterators and
5211 resume in the middle of them.
5213 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
5215 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
5216 of NeedReturnLabel here.
5218 Introduce a common point for emitting try/finally to IL
5219 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
5220 features of the various subclasses, which are now driven by ...
5221 (ExceptionStatement.EmitPreTryBody): ... this and ...
5222 (ExceptionStatement.EmitTryBody): ... this and the original
5224 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
5225 Remove DoEmit and update to follow above protocol.
5227 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5228 of the dispatcher are the same, skip emitting the 'switch'.
5229 * iterator.cs (Iterator.EmitDispose): Update to changes.
5231 Clean up handling of 'using' statement
5232 * statement.cs (UsingTemporary): New. Carved out of ...
5233 (Using): ... this. Simplify drastically. Handle exactly
5235 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5236 or Using as appropriate. If there are multiple variable declared,
5237 create nested Using statements.
5238 (resource_acquisition): Kill.
5240 * statement.cs (ExceptionStatement.EmitForDispose): Use
5241 EmitFinallyBody, not EmitFinally.
5243 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5244 * iterator.cs: Update to changes.
5246 Start using the ResumableStatement infrastructure
5247 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5248 (ResumableStatement.EmitForDispose): New.
5249 (ExceptionStatement): Override them.
5250 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5251 EmitForDispose to create the body of the Dispose method. Don't
5254 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5255 * statement.cs (Toplevel.AddResumePoint): ... here.
5256 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5257 * flowanalysis.cs (FlowBranchingIterator): New.
5258 * codegen.cs (EmitContext): Update to changes.
5260 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5261 (Iterator.old_resume_points): Rename from 'resume_points'.
5262 (Iterator.MoveNextStatement): Remove unused class.
5264 New infrastructure for try/finally in iterators (still unused)
5265 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5266 (FlowBranchingToplevel.AddResumePoint): Hook into
5267 ToplevelBlock.AddResumePoint.
5268 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5269 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5270 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5271 resume points and assign program-counter values.
5272 (ExceptionBlock.AddResumePoint): Collect resume points for
5273 de-muxer at the top of try block.
5274 * iterators.cs (Yield.CheckContext): Simplify.
5275 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5277 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5279 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5280 argument to an ExitStatement.
5281 (FlowBranchingException): Refactor saved origins code.
5282 * statement.cs (ExitStatement): Update to cahges.
5283 * iterator.cs (YieldBreak): Likewise.
5285 * statement.cs (ResumableStatement): New. Common base class for
5286 YieldReturn and ExceptionStatement.
5287 (ExitStatement): New. Common base class for Return and YieldBreak.
5288 (Return): Update to changes.
5289 * iterator.cs (YieldBreak): Likewise.
5290 * lambda.cs (ContextualReturn): Likewise.
5293 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5294 emit a meaningful error message.
5296 Fix #324765, #319508
5297 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5298 (VariableInfo.SetAssigned): Set it.
5299 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5300 determine if CS0219 or CS0168 is appropriate. Don't use
5301 flow-analysis information.
5302 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5303 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5304 (EmitContext.EndFlowBranching): ... this.
5306 2008-04-03 Marek Safar <marek.safar@gmail.com>
5308 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5310 2008-04-03 Marek Safar <marek.safar@gmail.com>
5312 A fix for bug #376508
5313 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5314 ImplicitConversionExists.
5316 2008-04-03 Marek Safar <marek.safar@gmail.com>
5318 * expression.cs (Binary): Added remaining binary operators to expression
5321 * nullable.cs: Optimize shift with null argument.
5323 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5325 Fix minor IL regression
5326 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5327 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5328 * cs-parser.jay (try_statement): Update to changes.
5330 * statement.cs (TryFinally.need_exc_block): Delete.
5331 (TryFinally): Update to changes.
5333 Now all ExceptionStatements are unconditional
5334 * statement.cs (CollectionForeach.DisposableWrapper): New.
5335 Extract out the try/finally code into a new wrapper.
5336 (CollectionForeach.Resolve): Use it to simplify the code.
5338 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5340 Start at simplifying ExceptionStatement semantics a bit
5341 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5342 * cs-parser.jay (try_statement): Update to changes.
5343 (opt_catch_clauses): Remove.
5344 * flowanalysis.cs: Update to changes.
5345 (FlowBranching.BranchingType.TryCatch): New.
5346 (FlowBranchingTryCatch): New.
5348 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5349 (FlowBranching.CreateBranching): Update to changes.
5350 (FlowBranchingBlock.AddSibling): Add sanity check.
5351 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5354 * iterators.cs (Iterator.MarkFinally): Remove.
5355 * statement.cs (ExceptionStatement): Update to changes.
5357 Add support for skipping over finally blocks at runtime. First
5358 in a series to fix #324708
5359 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5360 (Iterator.EmitMoveNext): Initialize it.
5361 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5362 branch over the body of the 'finally' clause.
5364 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5366 Avoid lopsided use of Foo/DoFoo names
5367 * statement.cs (ExpressionStatement.EmitFinallyBody):
5368 Rename from EmitFinally.
5369 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5370 * iterator.cs: Update to changes.
5372 2008-04-02 Marek Safar <marek.safar@gmail.com>
5374 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5375 based on UserOperatorCall. More binary nullable operators clean up.
5377 2008-04-02 Martin Baulig <martin@ximian.com>
5379 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5381 2008-04-02 Marek Safar <marek.safar@gmail.com>
5383 * nullable.cs: Merge user and empty conversions when lifting expression
5386 * expression.cs (StringConcat): Implemented expression tree representation.
5388 2008-04-01 Marek Safar <marek.safar@gmail.com>
5390 * nullable.cs: When lifting null literal and a user operator exists, no call
5393 2008-04-01 Marek Safar <marek.safar@gmail.com>
5395 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5398 2008-04-01 Marek Safar <marek.safar@gmail.com>
5400 * nullable.cs, expression.cs: Use namespace instead heavily nested
5401 monster abstract class.
5403 2008-04-01 Marek Safar <marek.safar@gmail.com>
5405 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5406 lifting of null literal and user operators. Clean up of some temporary
5409 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5411 Fix #368224, test-629.cs
5412 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5413 if it crossed an unwind-protect boundary.
5414 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5415 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5416 inside an unwind-protected region.
5417 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5418 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5419 'leave' instead of a 'br' if unwind-protected.
5420 (Iterator.EmitYieldBreak): Likewise.
5422 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5424 * driver.cs: Only define versioninfo resources if no win32 resource
5427 2008-03-28 Marek Safar <marek.safar@gmail.com>
5429 A fix for bug #372375
5430 * convert.cs: Fixed boxing of nullable types.
5432 2008-03-28 Marek Safar <marek.safar@gmail.com>
5434 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5437 2008-03-28 Marek Safar <marek.safar@gmail.com>
5439 A fix for bug #374619
5440 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5442 2008-03-27 Marek Safar <marek.safar@gmail.com>
5444 * lambda.cs: Check return type only for invocation.
5446 2008-03-27 Marek Safar <marek.safar@gmail.com>
5448 A fix for bug #374214
5449 * ecore.cs: Correctly report argument type mismatch.
5451 2008-03-27 Marek Safar <marek.safar@gmail.com>
5453 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5454 and not rely on broken IsEnum.
5456 2008-03-27 Marek Safar <marek.safar@gmail.com>
5458 * nullable.cs: New file, extracted from generic.cs.
5460 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5462 2008-03-27 Marek Safar <marek.safar@gmail.com>
5464 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5465 predefined comparison operators and null literals.
5467 * report.cs: New warning ID.
5469 2008-03-25 Marek Safar <marek.safar@gmail.com>
5471 A fix for bug #370577
5472 * lambda.cs: Check return type too.
5474 2008-03-25 Marek Safar <marek.safar@gmail.com>
5476 A fix for bug #372846
5477 * class.cs: Automatic properties can be declared as unsafe.
5479 2008-03-20 Marek Safar <marek.safar@gmail.com>
5481 * location.cs: Use string based concatenation.
5483 * expression.cs: LiftedBinaryOperator is gmcs only.
5485 2008-03-20 Marek Safar <marek.safar@gmail.com>
5487 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5488 conversions rules and expression trees.
5490 2008-03-19 Marek Safar <marek.safar@gmail.com>
5492 * delegate.cs: Use extension method source as delegate target.
5494 2008-03-19 Marek Safar <marek.safar@gmail.com>
5496 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5497 binary operations to be purely based on binary operations and optimized
5498 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5499 and other ET refactoring.
5501 * typemanager.cs: Fixed warning.
5503 2008-03-17 Marek Safar <marek.safar@gmail.com>
5505 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5507 * symbolwriter.cs: Fixed.
5509 2008-03-17 Marek Safar <marek.safar@gmail.com>
5511 * anonymous.cs, driver.cs: Reset anonymous types counters.
5513 2008-03-17 Marek Safar <marek.safar@gmail.com>
5515 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5517 * class.cs: Use fullname for all type member definitions.
5519 2008-02-19 Martin Baulig <martin@ximian.com>
5522 (IMethodData.EmitExtraSymbolInfo): New interface method.
5523 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5524 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5525 interface method here as an empty public virtual method.
5528 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5529 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5530 CodeGen.SymbolWriter.SetRealMethodName().
5532 2008-02-18 Martin Baulig <martin@ximian.com>
5535 (ScopeInfo.EmitType): Override this and emit debugging
5536 information for captured variables.
5537 (RootScopeInfo.EmitType): Override this and emit symbol
5538 information for a captured `this'.
5540 2008-02-15 Martin Baulig <martin@ximian.com>
5542 * iterators.cs: Emit debugging info.
5545 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5546 (EmitContext.OmitDebuggingInfo): New public property.
5549 (While): Override Emit() and don't emit symbol info there; do it
5550 inside DoEmit() instead.
5551 (Block.Emit): Omit symbol information while emitting the scope
5552 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5554 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5555 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5556 .ctor to make `IsIterator' work.
5558 2008-03-14 Martin Baulig <martin@ximian.com>
5560 * symbolwriter.cs: Added the new symbol writer function from the
5561 debugger's `terrania' branch; temporarily enclose them inside
5562 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5565 2008-03-14 Martin Baulig <martin@ximian.com>
5568 (SymbolWriter): Make this a public static class.
5571 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5572 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5574 2008-03-14 Marek Safar <marek.safar@gmail.com>
5576 A fix for bug #370577
5577 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5580 2008-03-14 Marek Safar <marek.safar@gmail.com>
5582 * typemanager.cs (CSharpName): Made 250 times faster.
5584 2008-03-13 Marek Safar <marek.safar@gmail.com>
5586 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5588 2008-03-12 Marek Safar <marek.safar@gmail.com>
5590 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5591 crash when predefined field does not exist.
5593 2008-03-12 Marek Safar <marek.safar@gmail.com>
5595 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5597 2008-03-12 Marek Safar <marek.safar@gmail.com>
5599 * class.cs (FixedField): Don't crash when contructors are missing.
5601 2008-03-11 Marek Safar <marek.safar@gmail.com>
5603 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5604 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5605 check internal types accessibility for internal and external types.
5606 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5608 2008-03-11 Marek Safar <marek.safar@gmail.com>
5610 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5611 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5612 attribute.cs, statement: Use corect instance of predefined types (work
5613 related to #364674).
5615 2008-03-07 Marek Safar <marek.safar@gmail.com>
5617 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5619 2008-03-07 Marek Safar <marek.safar@gmail.com>
5621 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5622 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5623 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5624 predefined types clean up, delayed predefined types members initialization
5625 (work related to #364674).
5627 2008-03-05 Marek Safar <marek.safar@gmail.com>
5629 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5631 2008-03-05 Marek Safar <marek.safar@gmail.com>
5633 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5634 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5635 predefined types clean up (work related to #364674).
5637 2008-03-04 Marek Safar <marek.safar@gmail.com>
5639 * ecore.cs: Print an error message instead of throwing exception.
5641 2008-03-04 Marek Safar <marek.safar@gmail.com>
5643 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5644 expression.cs, statement.cs: Unififed null literal representation.
5646 2008-03-03 Marek Safar <marek.safar@gmail.com>
5648 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5649 expression.cs: Refactored binary operators resolve phase and improved speed.
5650 The nullable code is still missing and won't work correctly, more fixes
5653 It also fixes #323726, #324312, #324248, and many other unreported issues.
5655 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5657 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5660 2008-02-27 Marek Safar <marek.safar@gmail.com>
5662 * ecore.cs: Clean-up and split BetterConversion.
5664 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5667 * enum.cs (EnumMember.Value): Only access 'value' if
5668 ResolveValue says it's ok.
5669 (EnumMember.DoResolveValue): Don't set prev_member.value.
5670 (Enum.GetDefinition): Reverse arguments of Equals --
5671 EnumMember.Value can return 'null'.
5673 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5675 2008-02-22 Marek Safar <marek.safar@gmail.com>
5677 * generic.cs, expression.cs: More ongoing work on expression trees.
5679 2008-02-21 Marek Safar <marek.safar@gmail.com>
5681 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5682 handle missing matches when mutiple operators exist.
5684 2008-02-20 Marek Safar <marek.safar@gmail.com>
5686 A fix for bug #363218
5687 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5690 2008-02-20 Marek Safar <marek.safar@gmail.com>
5692 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5693 update. This time to deal correctly with SideEffectConstant expression used
5694 as an argument for another constant folding.
5696 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5698 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5701 2008-02-19 Marek Safar <marek.safar@gmail.com>
5703 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5705 2008-02-19 Marek Safar <marek.safar@gmail.com>
5707 A fix for bug #328136
5708 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5709 side is a false constant, because we still need to evaluate the right-hand
5712 * statement.cs (If): Emit two types of boolean constants (simple constant,
5713 side-effect constant).
5715 2008-02-19 Marek Safar <marek.safar@gmail.com>
5717 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5719 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5722 2008-02-18 Marek Safar <marek.safar@gmail.com>
5724 A fix for bug #361457
5725 * ecore.cs (IsApplicable): Params methods have lower priority.
5727 * support.cs: Return correct parameter modifier for params types.
5729 2008-02-18 Marek Safar <marek.safar@gmail.com>
5731 * generic.cs (TypeParameter): Cache attribute target name.
5733 * support.cs: Removed unused variable.
5735 * typemanager.cs: Removed debugging leftover.
5737 * ecore.cs: Use local type instead of a property;
5739 * class.cs (VerifyMembers): Consider also parent to test whether type member
5742 * expression.cs (FullMethodDesc): Removed.
5744 * attribute.cs (IsValidArgumentType): Made static.
5746 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5748 Cleanup to be more readable.
5749 * Makefile (GMCS_PROFILE): Remove.
5750 (COMPILER_NAME): New helper.
5752 2008-02-15 Miguel de Icaza <miguel@novell.com>
5754 * cs-tokenizer.cs: if a conditional expression happens inside a
5755 (...) this also means that we do not need to de-ambiguate between
5756 an parenthesized expression and a cast.
5760 * constant.cs (SideEffectConstant): a constant value that happens
5761 to have a side effect.
5763 Fixes the build regressions introduced by the fix for #359789
5765 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5767 * expression.cs (Conditional.Emit): when emitting the ternary
5768 operator, use local variables to generate code verifiable code.
5770 The verifier cannot infer that the type on stack before the
5771 stloc.0 is executed is of type ParentB. This happens because the
5772 stack merge algorithm uses only parent types when deciding which
5773 is the common type. This is described in Part III 1.8.1.3 of ECMA
5776 This code compiled with mcs is not verifiable under MS. The MS
5777 verifier picks the first common interface of Foo and Bar, which is
5778 wrong, but doesn't use a full join type of the 2 interfaces.
5780 CSC uses a clever hack to compile such code in a verifiable
5781 way. It stores the intermediate values in a local variable with
5786 2008-02-14 Miguel de Icaza <miguel@novell.com>
5788 * expression.cs: Do not fold BitwiseAnd operators when the left
5789 side is a false constant, because we still need to evaluate the
5794 * support.cs: Instead of throwing an InternalErrorException when
5795 the position of the stream is outside the boundary of our buffer,
5796 reset the state of the reader, and restart the reading from the
5797 beginning of the file.
5799 2008-02-14 Marek Safar <marek.safar@gmail.com>
5801 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5803 2008-02-14 Marek Safar <marek.safar@gmail.com>
5805 A fix for bug #361686
5806 * decl.cs: A protected types used inside a private class which parents
5807 derives from the protected class are accessible.
5809 2008-02-13 Marek Safar <marek.safar@gmail.com>
5811 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5812 the parameterless constructor.
5814 2008-02-13 Marek Safar <marek.safar@gmail.com>
5816 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5817 lookup methods to use standard member cache when doing member lookup.
5819 2008-02-12 Marek Safar <marek.safar@gmail.com>
5821 * driver.cs: Don't report full path for referenced module as assembly error.
5823 2008-02-12 Marek Safar <marek.safar@gmail.com>
5825 * Makefile: Fixed `qh' target to work on all machines.
5827 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5828 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5829 and HasElementType with TypeManager implementation.
5831 2008-02-08 Marek Safar <marek.safar@gmail.com>
5833 A fix for bugs #325134, #359749
5834 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5835 first binds point to non-method member expression.
5837 2008-02-08 Marek Safar <marek.safar@gmail.com>
5839 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5841 2008-02-08 Marek Safar <marek.safar@gmail.com>
5843 A fix for bugs #321394, #323028
5844 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5845 Reworked naive IsAccessibleAs implementation to handle nested types.
5847 2008-02-05 Jb Evain <jbevain@novell.com>
5849 * class.cs: use generic type comparison for parameters
5852 2008-02-05 Marek Safar <marek.safar@gmail.com>
5854 A fix for bug #325372
5855 * class.cs: Use generic type comparison when testing method signatures.
5857 2008-02-05 Marek Safar <marek.safar@gmail.com>
5859 A fix for bug #357047
5860 * ecore.cs: Applied C# 3.0 changes to better conversion.
5862 2008-02-05 Marek Safar <marek.safar@gmail.com>
5864 A fix for bug #358374
5865 * cs-parser.jay: Correctly set modifiers for all constructor types.
5867 2008-02-04 Marek Safar <marek.safar@gmail.com>
5869 A fix for bug #355251
5870 * generic.cs: Added base class constraint based type inference.
5872 2008-02-01 Marek Safar <marek.safar@gmail.com>
5874 A fix for bug #357255
5875 * decl.cs: One more missing visibility check.
5877 2008-02-01 Marek Safar <marek.safar@gmail.com>
5879 * support.cs: Fixed broken return.
5881 2008-01-25 Marek Safar <marek.safar@gmail.com>
5883 * report.cs: Correctly reset warnings count after probing.
5885 2008-01-25 Martin Baulig <martin@ximian.com>
5888 (NamespaceEntry.SymbolFileID): Make this work again after
5889 MemberName.ToString() is gone.
5891 2008-01-25 Marek Safar <marek.safar@gmail.com>
5893 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5896 2008-01-25 Marek Safar <marek.safar@gmail.com>
5898 * generic.cs: Use full implicit conversion for type inference fixing.
5900 2008-01-24 Marek Safar <marek.safar@gmail.com>
5902 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5903 Fixed user operator conversions.
5905 2008-01-24 Marek Safar <marek.safar@gmail.com>
5907 * generic.cs: Do nullable type to null comparison optimization during
5910 2008-01-24 Marek Safar <marek.safar@gmail.com>
5912 A fix for bug #355163
5913 * generic.cs: Enabled l-value resolve on nullable expressions.
5915 2008-01-24 Marek Safar <marek.safar@gmail.com>
5917 A fix for bug #353986
5918 * class.cs: Ingore static ctors with parameters for any further checks.
5920 2008-01-24 Marek Safar <marek.safar@gmail.com>
5922 A fix for bug #354310
5923 * namespace.cs: Removed redundant check.
5925 2008-01-24 Marek Safar <marek.safar@gmail.com>
5927 A fix for bug #354928
5928 * expression.cs: ElementInitializers can be resolved only once.
5930 2008-01-24 Marek Safar <marek.safar@gmail.com>
5932 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5933 Condition expressions.
5935 2008-01-23 Marek Safar <marek.safar@gmail.com>
5937 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5939 2008-01-22 Marek Safar <marek.safar@gmail.com>
5941 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5944 * generic.cs: Implemented coalesce expression.
5946 2008-01-22 Marek Safar <marek.safar@gmail.com>
5948 A fix for bug #355145
5949 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5950 expression tree type inference.
5952 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5955 * expression.cs (Binary.IsUnsignedType): Fix typo.
5957 2008-01-22 Marek Safar <marek.safar@gmail.com>
5959 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5961 2008-01-22 Marek Safar <marek.safar@gmail.com>
5963 A fix for bug #355161
5964 * ecore.cs, expression.cs: Wider range of extension method supported
5967 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5969 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5970 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5973 2008-01-22 Marek Safar <marek.safar@gmail.com>
5975 A fix for bug #355148
5976 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5978 2008-01-22 Miguel de Icaza <miguel@novell.com>
5980 * expression.cs (CreateExpressionTree): Add support for or and
5981 logical or, and indent following the coding conventions.
5983 * typemanager.cs (LinqExpression): renamed from
5984 ExpressionTreeManager, for a shorter name.
5986 Use TypeManager.CoreLookupType to lookup types from our core
5987 assemblies and turn those into "Type" variables.
5989 Consumers that previously used "Namespace" and "Type" from this
5990 class should instead use the TypeExpression which is a type that
5991 is fully resolved (without involving the regular C# resolution
5994 This typically looks like this:
5996 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5997 new MemberAccess (texpr, name, type_arguments, loc)
5999 This avoids the problem in: #355178
6001 2008-01-21 Marek Safar <marek.safar@gmail.com>
6003 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
6004 feature in parser only as we do in other cases.
6006 2008-01-21 Marek Safar <marek.safar@gmail.com>
6008 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
6009 typemanager.cs: A refactoring of params arguments to reuse existing
6010 expressions (params -> array initializer) to emit params argument instead
6011 of specialized handling.
6012 It was required by expression tree implementation and it has other benefits
6013 as well, we now apply same optimization for params arguments as we do for
6016 2008-01-18 Marek Safar <marek.safar@gmail.com>
6018 A fix for bug #353526
6019 * generic.cs: A type inference of params arguments may not required any
6020 temporary array creation.
6022 2008-01-18 Marek Safar <marek.safar@gmail.com>
6024 A fix for bug #353534
6025 * generic.cs, ecore.cs, expression.cs: A method group type inference is
6026 supported for delegates only.
6028 2008-01-18 Marek Safar <marek.safar@gmail.com>
6030 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
6031 type for more than 1 candidates.
6033 2008-01-18 Marek Safar <marek.safar@gmail.com>
6035 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
6038 2008-01-16 Marek Safar <marek.safar@gmail.com>
6040 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
6041 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
6042 operator) expressions.
6044 2008-01-16 Zoltan Varga <vargaz@gmail.com>
6046 * statement.cs: Avoid declaring an IL variable for this_variable since it is
6047 not accessed from the generated IL.
6049 2008-01-14 Marek Safar <marek.safar@gmail.com>
6051 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
6052 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
6053 statement.cs: The first expression tree implementation drop, mostly
6054 infrastructure work.
6056 2008-01-14 Marek Safar <marek.safar@gmail.com>
6058 * ecore.cs (IsNestedChild): Refactored.
6060 2008-01-11 Marek Safar <marek.safar@gmail.com>
6062 * lambda.cs: Don't use a cast on unknown expression statement.
6064 2008-01-10 Geoff Norton <gnorton@novell.com>
6066 * cs-tokenizer.cs: One more token to distinguish between method and lambda
6069 2008-01-09 Marek Safar <marek.safar@gmail.com>
6071 * doc.cs: Report better /doc crash details.
6073 2008-01-09 Marek Safar <marek.safar@gmail.com>
6075 A fix for bug #352536
6076 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
6078 2008-01-08 Marek Safar <marek.safar@gmail.com>
6080 A fix for bug #352287
6081 * ecore.cs, expression.cs: Do `this' access checking in all member access
6084 2008-01-08 Marek Safar <marek.safar@gmail.com>
6086 * rootcontext.cs, driver.cs: Switch to linq mode by default.
6088 * report.cs: Reset message stacks.
6090 2008-01-08 Marek Safar <marek.safar@gmail.com>
6092 * generic.cs (InferInPhases): Correctly calculate params position.
6094 2008-01-08 Marek Safar <marek.safar@gmail.com>
6096 * cs-tokenizer.cs: No need to parse full string when parsing lambda
6099 2008-01-07 Marek Safar <marek.safar@gmail.com>
6101 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
6103 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
6105 * driver.cs: Updated --help option.
6107 2008-01-07 Marek Safar <marek.safar@gmail.com>
6109 * generic.cs (InferParamsTypeArguments): Removed.
6110 (InferInPhases): Add params type inference.
6111 (LowerBoundInference): Fixed scoring mechanism.
6113 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
6115 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
6117 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
6118 byte array for unsigned "baked" assemblies.
6120 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
6122 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
6123 array for assemblies that are not strongnamed.
6125 2008-01-04 Marek Safar <marek.safar@gmail.com>
6127 A fix for bug #351481
6128 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
6129 declaring type for nested generic types.
6131 2008-01-04 Marek Safar <marek.safar@gmail.com>
6133 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
6134 instead of ToString.
6136 2008-01-03 Marek Safar <marek.safar@gmail.com>
6138 A fix for bug #351047
6139 * expression.cs (Binary.ResolveOperator): Allow equality operators between
6140 null and structs only when equality and inequality operators are defined
6141 either as an user-operators or predefined operators.
6143 2008-01-03 Marek Safar <marek.safar@gmail.com>
6145 A fix for bug #351047
6146 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
6148 2008-01-03 Marek Safar <marek.safar@gmail.com>
6150 A fix for bug #351257
6151 * cs-tokenizer.cs: Advance line number for '\r' correctly.
6153 2008-01-03 Marek Safar <marek.safar@gmail.com>
6155 A fix for bug #351157
6156 * class.cs (Using): Fixed yet another broken cloning.
6158 (Block): Put back more sensible default value for statements.
6160 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
6162 * codegen.cs: Allow AssemblyVersion with only major version component.
6165 2007-12-29 Marek Safar <marek.safar@gmail.com>
6167 A fix for bug #324654
6168 * class.cs: Use FullName property as member name.
6170 2007-12-28 Marek Safar <marek.safar@gmail.com>
6172 A fix for bug #342117
6173 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
6174 constructor constraint.
6176 2007-12-28 Marek Safar <marek.safar@gmail.com>
6178 A fix for bug #338273
6179 * class.cs (ProbertyBase): Access modifier checks are required for overrides
6182 2007-12-28 Marek Safar <marek.safar@gmail.com>
6184 A fix for bug #350839
6185 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
6187 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6189 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6192 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6194 * statement.cs: Changed some Hashtables to use HybridDictionaries
6195 instead. It was observed that some HashTables only contained a few
6196 items in the vast majority of cases. Since HybridDictionary is
6197 more efficient on small sets (<10 elements), "known_variables"
6198 from class ExplicitBlock as well as "labels" and "constants " from
6199 class Block were changed to HybridDictionaries.
6201 Atsai results: (56216kb->54987kb)
6203 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
6206 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6208 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6211 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6213 * expression.cs: foreach loop to for loop, saved on allocation of
6214 enumerator (59333kb->59141kb)
6216 * statement.cs. Changed foreach loops to for loops, saved on
6217 allocation of enumerator (59141kb->59006kb)
6219 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
6220 when constructed with no specified capacity. This was causing a
6221 few ArrayLists to allocate more memory than they would potentially
6222 need in the Block class and MemberCache class. Setting the
6223 ArrayLists to construct with a capacity of 1 saves some
6224 memory. (56216kb->55585kb)
6226 2007-12-27 Marek Safar <marek.safar@gmail.com>
6228 A fix for bug #347189 (2nd issue)
6229 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6232 2007-12-27 Miguel de Icaza <miguel@novell.com>
6234 * report.cs: Do not use colors if stdout and stderr are not a
6237 2007-12-27 Marek Safar <marek.safar@gmail.com>
6239 A fix for bug #346998
6240 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6243 2007-12-27 Marek Safar <marek.safar@gmail.com>
6245 A fix for bug #343465
6246 * class.cs: Explicit method name for nested types uses dots only.
6248 2007-12-27 Marek Safar <marek.safar@gmail.com>
6250 A fix for bug #343707
6251 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6253 2007-12-27 Marek Safar <marek.safar@gmail.com>
6255 * ecore.cs: Report type inference errors only when arguments count matches
6258 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6260 * expression.cs, report.cs: New warning.
6262 * typemanager.cs: Catch anonymous method type too.
6264 2007-12-23 Marek Safar <marek.safar@gmail.com>
6266 A fix for bug #346379
6267 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6269 2007-12-23 Marek Safar <marek.safar@gmail.com>
6271 A fix for bug #347359
6272 * expression.cs (Invocation): Don't resolve already resolved expression.
6274 2007-12-23 Marek Safar <marek.safar@gmail.com>
6276 A fix for bug #347189
6277 * class.cs (FixedField): Use non-dependent code only in the define phase.
6279 2007-12-23 Marek Safar <marek.safar@gmail.com>
6281 A fix for bug #348076
6282 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6284 2007-12-22 Marek Safar <marek.safar@gmail.com>
6286 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6287 discovered extension methods.
6289 2007-12-22 Marek Safar <marek.safar@gmail.com>
6291 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6294 2007-12-21 Miguel de Icaza <miguel@novell.com>
6296 * report.cs (ErrorMessage): Add support for using colors on
6297 terminals that support it.
6299 2007-12-21 Marek Safar <marek.safar@gmail.com>
6301 * ecore.cs: Use information about expanded params for error reporting.
6303 2007-12-21 Marek Safar <marek.safar@gmail.com>
6305 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6306 and logic for params overloads.
6308 2007-12-15 Miguel de Icaza <miguel@novell.com>
6310 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6311 as this is also created from the parser. Fixes #349034
6313 2007-12-12 Miguel de Icaza <miguel@novell.com>
6315 * statement.cs (Throw.CloneTo): it is valid to have empty
6316 expressions for throw.
6318 2007-12-03 Marek Safar <marek.safar@gmail.com>
6320 * cs-parser.jay: Set delegate constraint parsing region correctly.
6322 2007-12-03 Marek Safar <marek.safar@gmail.com>
6324 A fix for bug #345467
6325 * typemanager.cs (IsEqual): Compare generic parameters position only.
6327 2007-11-28 Marek Safar <marek.safar@gmail.com>
6329 * expression.cs (BaseAccess): Type arguments can be null.
6331 2007-11-27 Raja R Harinath <harinath@gmail.com>
6333 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6334 consistent even when an error has occured.
6335 (Switch.Resolve): Likewise.
6337 2007-11-22 Marek Safar <marek.safar@gmail.com>
6339 A fix for bug #334505
6340 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6343 2007-11-22 Marek Safar <marek.safar@gmail.com>
6345 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6346 refactorings required to resolve extension methods correctly when mixing
6347 generics and non-generics members.
6349 2007-11-20 Marek Safar <marek.safar@gmail.com>
6351 A fix for bug #342584
6352 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6355 2007-11-19 Marek Safar <marek.safar@gmail.com>
6357 A fix for bug #342512
6358 * delegate.cs: Use delegate argument expression when is available. Don't
6359 emit virtual call when class is sealed.
6361 2007-11-16 Marek Safar <marek.safar@gmail.com>
6363 A fix for bug #325423
6364 * assign.cs (FieldInitializer): Use resolved expression for emit.
6366 * class.cs: Print less confusing error message.
6368 2007-11-16 Marek Safar <marek.safar@gmail.com>
6370 * cs-tokenizer.cs: Removed GMCS ifdefs.
6372 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6375 * cs-parser.jay: Disabled nullable check.
6377 * generic-mcs: Copied more generic stuff.
6379 2007-11-16 Marek Safar <marek.safar@gmail.com>
6381 * gcs-parser.jay: Merged to cs-parser.jay.
6383 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6384 * *.csproj, *.sources: Updated to use only jay parser file.
6386 2007-11-16 Marek Safar <marek.safar@gmail.com>
6388 * gcs-parser.jay: Added nullable and default expression feature checks.
6390 2007-11-16 Marek Safar <marek.safar@gmail.com>
6392 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6393 it fixes many TODOs and hidden bugs.
6395 * expression: Removed duplicate error check.
6397 2007-11-15 Marek Safar <marek.safar@gmail.com>
6399 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6400 implicitly type local variable only when it is used in a declaration.
6402 2007-11-15 Marek Safar <marek.safar@gmail.com>
6404 * attribute.cs: Use CS0612 for empty strings.
6406 2007-11-14 Marek Safar <marek.safar@gmail.com>
6408 * lambda.cs, statement.cs: Contextual return may act as a statement.
6410 2007-11-14 Marek Safar <marek.safar@gmail.com>
6412 A fix for a regression cause by #324222
6413 * class.cs: Don't report unused even when it implements an interface.
6415 2007-11-13 Marek Safar <marek.safar@gmail.com>
6417 A fix for bug #341205
6418 * ecore.cs, expression.cs: Method group expression cannot do static
6419 method access with an instance reference check before overloading takes
6422 2007-11-13 Marek Safar <marek.safar@gmail.com>
6424 A fix for bug #325359
6425 * class.cs: Use predictable name for automatically generated property.
6427 2007-11-12 Marek Safar <marek.safar@gmail.com>
6429 A fix for bug #324996
6430 * expression.cs (Is): Handle case where D is nullable and T is not
6433 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6435 2007-11-12 Marek Safar <marek.safar@gmail.com>
6437 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6438 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6439 Flush small error reporting changes.
6441 2007-11-09 Marek Safar <marek.safar@gmail.com>
6443 A fix for bug #324996
6444 * expression.cs: Rewrote Is expression implementation to work with
6445 generics, nullable types, anonymous method. A const result expression
6446 uses existing infrastructure instead of custom not fully-featured one.
6448 2007-11-08 Marek Safar <marek.safar@gmail.com>
6450 A fix for bug #340202
6451 * class.cs: Consider generics for volatile field.
6453 2007-11-08 Marek Safar <marek.safar@gmail.com>
6455 A fix for bug #335594
6456 * expression.cs: Use conversion rules when handling string addition.
6458 2007-11-07 Marek Safar <marek.safar@gmail.com>
6460 A fix for bug #336651
6461 * expression.cs: Fixed a crash when probing is on.
6463 2007-11-07 Marek Safar <marek.safar@gmail.com>
6465 A fix for bug #324242
6466 * covert.cs: Added a conversion from any nullable-type with an
6467 underlying enum-type to the type System.Enum.
6469 2007-11-07 Marek Safar <marek.safar@gmail.com>
6471 A fix for bug #324222
6472 * class.cs: Report all non-used event fields.
6474 2007-11-07 Marek Safar <marek.safar@gmail.com>
6476 A fix for bug #325161
6477 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6478 qualifier for generic types.
6480 2007-11-07 Marek Safar <marek.safar@gmail.com>
6482 A fix for bug #322971
6483 * expression.cs, ecore.cs: Added intermediate result value check for
6486 2007-11-07 Marek Safar <marek.safar@gmail.com>
6488 A fix for bug #324754
6489 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6490 when it was requested.
6492 2007-11-07 Marek Safar <marek.safar@gmail.com>
6494 A fix for bug #325101
6495 * expression.cs: Do type not value comparison for `is' expression.
6497 2007-11-07 Marek Safar <marek.safar@gmail.com>
6499 A fix for bug #320236
6500 * convert.cs: Don't apply user conversion on underlying target type.
6502 2007-11-06 Marek Safar <marek.safar@gmail.com>
6504 * expression.cs: Don't use unresolved expression for error reporting.
6506 2007-11-06 Marek Safar <marek.safar@gmail.com>
6508 A fix for bugs #337712, #324490
6509 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6510 overloading resolution too.
6512 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6513 the process consistent and more robust.
6515 * expression.cs, linq.cs, report.cs: Update.
6517 2007-11-02 Marek Safar <marek.safar@gmail.com>
6519 A fix for bug #332909
6520 * attribute.cs: Resolve attributes in correct context using error
6523 * rootcontext.cs: Define Obsolete attribute members as core members.
6525 2007-11-02 Marek Safar <marek.safar@gmail.com>
6527 * statement.cs: Removed unused methods.
6529 2007-10-31 Wade Berrier <wberrier@novell.com>
6531 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6532 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6535 2007-10-31 Marek Safar <marek.safar@gmail.com>
6537 A fix for bug #338102
6538 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6539 methods registered as non-generics.
6541 2007-10-31 Marek Safar <marek.safar@gmail.com>
6543 A fix for bugs #337712, #324490
6544 * delegate.cs: Delegate covariance and contravariance is not allowed for
6547 2007-10-31 Marek Safar <marek.safar@gmail.com>
6549 A fix for bug #337719
6550 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6553 2007-10-30 Marek Safar <marek.safar@gmail.com>
6555 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6557 2007-10-29 Marek Safar <marek.safar@gmail.com>
6559 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6562 2007-10-29 Raja R Harinath <rharinath@novell.com>
6564 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6566 2007-10-29 Marek Safar <marek.safar@gmail.com>
6568 A fix for bug #334652
6569 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6570 extension methods when we have not found the best candidate in normal
6573 2007-10-27 Marek Safar <marek.safar@gmail.com>
6575 * AssemblyInfo.cs: Keep up-to-date.
6577 2007-10-27 Marek Safar <marek.safar@gmail.com>
6579 * Makefile: Fixed generics compiler name.
6581 2007-10-27 Marek Safar <marek.safar@gmail.com>
6583 * lambda.test: removed, lambda parsing is done differently.
6585 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6587 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6589 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6591 2007-10-27 Marek Safar <marek.safar@gmail.com>
6593 * Makefile, *.sources : All C# compilers are in mcs folder.
6595 * *.cs: Use existing 2_1 define for smcs.
6597 2007-10-26 Marek Safar <marek.safar@gmail.com>
6599 A fix for bug #335847
6600 * assign.cs, expression.cs: Couple of changes to avoid creating a
6601 temporary variable for each object initializer assignment statement. It
6602 simplifies struct initialization too, otherwise two temporary variables
6604 Implemented optimization of redundant default element initializers.
6606 2007-10-25 Marek Safar <marek.safar@gmail.com>
6608 A fix for bug #336766
6609 * expression.cs (Class.CheckBase): Use generic name when method is
6612 2007-10-25 Marek Safar <marek.safar@gmail.com>
6614 A fix for bug #334737
6615 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6616 variable and not variable argument for prepared copies.
6618 2007-10-24 Marek Safar <marek.safar@gmail.com>
6620 A fix for bug #325110
6621 * class.cs, expression.cs, attribute.cs: Use open generic method when
6622 checking conditional attribute.
6624 2007-10-24 Marek Safar <marek.safar@gmail.com>
6626 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6627 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6628 FeatureIsNotAvailable.
6630 2007-10-24 Marek Safar <marek.safar@gmail.com>
6632 ** C# 3.0 Partial methods
6634 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6635 methods support. Because of member cache issue with generics only
6636 non-generics partial methods are fully supported.
6638 2007-10-23 Marek Safar <marek.safar@gmail.com>
6640 * class.cs, decl.cs: Rewrote member overloads check to cope with
6641 generics and to use member cache for member checking. It also improves
6642 performance and fixes remaining overloads issues.
6644 2007-10-20 Marek Safar <marek.safar@gmail.com>
6646 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6647 roottypes.cs, typemanager.cs:
6649 A member cache creation logic changed to add members immediately and
6650 not rely on fallback. The member cache is now only prefered way
6651 how to access and find type declaration members. It saves 5 MB of memory
6652 during MWF compilation and makes code ready for more optimizations and
6653 clean-ups, it's also a pre-requirement for partial methods.
6655 2007-10-18 Raja R Harinath <harinath@gmail.com>
6657 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6658 handling for generic parameters.
6660 2007-10-15 Marek Safar <marek.safar@gmail.com>
6662 * class.cs (FixedField): Removed redundant volatile check.
6664 2007-10-15 Marek Safar <marek.safar@gmail.com>
6666 * class.cs, decl.cs: Fixed overload members verification to do only one
6667 check per possible collision.
6669 2007-10-13 Marek Safar <marek.safar@gmail.com>
6671 A fix for bug #325478
6672 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6673 and create only one disposable flags container.
6675 2007-10-12 Marek Safar <marek.safar@gmail.com>
6677 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6678 * statement.cs (Fixed): Fixed variables cloning.
6680 2007-10-12 Marek Safar <marek.safar@gmail.com>
6682 A fix for bug #333342
6683 * class.cs (EventField): Don't mark value type event as synchronized.
6685 2007-10-12 Marek Safar <marek.safar@gmail.com>
6687 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6688 inference to identify best candidate method correctly.
6689 (ProperyExpr): A range variable is read only and cannot be modified.
6691 2007-10-11 Marek Safar <marek.safar@gmail.com>
6693 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6694 logic to identify best candidate method correctly.
6696 2007-10-11 Marek Safar <marek.safar@gmail.com>
6698 * location.cs (Equals, GetHashCode): Removed.
6700 2007-10-11 Marek Safar <marek.safar@gmail.com>
6702 * report.cs: Implemented message recorder. It is used mainly for lambda
6703 expressions to capture otherwise swallowed error messages.
6705 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6707 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6709 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6711 * expression.cs (MemberAccess): Always report lookup failure.
6713 * location.cs: Implemented Equals, GetHashCode.
6715 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6717 2007-10-10 Jb Evain <jbevain@novell.com>
6719 * codegen.cs: re-enable assembly version check.
6721 2007-10-09 Marek Safar <marek.safar@gmail.com>
6723 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6726 * namespace.cs (UsingAlias): Do correct version check.
6728 2007-10-08 Marek Safar <marek.safar@gmail.com>
6730 * expresison.cs, ecore.cs: Issue extension method error message when
6733 * rootcontext.cs: Added ISO_2 compiler mode option.
6735 2007-10-08 Marek Safar <marek.safar@gmail.com>
6737 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6740 2007-10-08 Marek Safar <marek.safar@gmail.com>
6742 * attribute.cs (GetString, GetBoolean): Work with both literal and
6745 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6746 Moved method overload specific methods to MethodGroupExpr.
6748 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6749 it should be less memory consuming.
6751 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6753 * codegen.cs: remove the assembly version check until the buildbot is
6756 2007-10-07 Jb Evain <jbevain@novell.com>
6758 * attribute.cs (Attribute.GetString): if the value
6759 expression is a StringConstant, return its string value.
6761 2007-10-07 Jb Evain <jbevain@novell.com>
6763 * typemanager.cs: add `assembly_version_attribute_type`.
6764 * codegen.cs: on attribute emission, check that the
6765 AssemblyVersionAttribute doesn't overflow.
6767 2007-10-05 Marek Safar <marek.safar@gmail.com>
6769 A fix for bug #324677
6770 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6771 parent container of a scope container with currently resolved one.
6773 2007-10-05 Marek Safar <marek.safar@gmail.com>
6775 A fix for bug #325534
6776 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6779 2007-10-05 Marek Safar <marek.safar@gmail.com>
6781 A fix for bug #327504
6782 * class.cs (Operator.Define): Refactored implicit and explicit user
6783 operator conversion rules.
6785 2007-10-05 Marek Safar <marek.safar@gmail.com>
6787 A fix for bug #327520
6788 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6790 2007-10-04 Marek Safar <marek.safar@gmail.com>
6792 A fix for bug #328022
6793 * class.cs (MethodData.Define): Use correct method to check whether
6794 a method implementents an accessor.
6796 2007-10-04 Marek Safar <marek.safar@gmail.com>
6798 A fix for bug #330069
6799 * statement.cs (Fixed.Resolve): Read the first array element only when
6800 an array is instantiated.
6802 2007-10-04 Marek Safar <marek.safar@gmail.com>
6804 * expression.cs, assign.cs, generics.cs: Print correct operator when
6805 compound assignment is used.
6807 2007-10-04 Marek Safar <marek.safar@gmail.com>
6809 A fix for bug #325841
6810 * expression.cs (ArrayAccess): Use full argument cloning only for
6811 string compound concatenation.
6813 2007-10-03 Marek Safar <marek.safar@gmail.com>
6815 A fix for bug #328774
6816 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6818 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6821 2007-10-03 Raja R Harinath <rharinath@novell.com>
6824 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6825 Event accessibility checks here. Remove some bogus code that
6826 accidently made GenericMethods work.
6827 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6829 2007-09-25 Marek Safar <marek.safar@gmail.com>
6831 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6833 * statement.cs (Block): Refactored AddVariable to allow error handling
6836 * generic.cs: New stub.
6838 2007-09-23 Marek Safar <marek.safar@gmail.com>
6840 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6843 2007-09-17 Marek Safar <marek.safar@gmail.com>
6845 * class.cs: Use partial container to record whether any partial part
6846 contains static field initializer and therefore default contructor has
6849 2007-09-14 Marek Safar <marek.safar@gmail.com>
6851 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6852 mono-list when only one of two partial parts has defined accessibility
6855 2007-09-14 Marek Safar <marek.safar@gmail.com>
6857 A fix for bug #82845
6859 * class.cs (TypeContainer): Set correct resolve context for all field
6862 2007-09-13 Marek Safar <marek.safar@gmail.com>
6864 * assign.cs: Fixed a crash when field is resolved twice with an error.
6866 * codegen.cs: Changed InFieldInitializer to be flag.
6868 * anonymous.cs, ecore.cs, expression.cs: Update after
6869 IsInFieldInitializer rename.
6871 * const.cs: Removed unused parameter.
6873 * class.cs: Changed the way how we resolve and emit field initializers.
6874 The field initilizers have to have access to contructor block to emit
6875 compiler generated code.
6877 2007-09-13 Marek Safar <marek.safar@gmail.com>
6879 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6880 generics use TypeContainer instead.
6882 2007-09-12 Marek Safar <marek.safar@gmail.com>
6884 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6886 * lambda.cs (ResolveParameters): Use more powerful
6887 InflateGenericArgument.
6889 * parameters.cs: Better exception message.
6891 2007-09-10 Marek Safar <marek.safar@gmail.com>
6893 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6894 correct expression block type.
6896 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6898 * expression.cs (Invocation): Extracted method group resolve to
6901 2007-09-07 Marek Safar <marek.safar@gmail.com>
6903 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6904 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6906 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6907 generic extension methods.
6909 2007-09-06 Marek Safar <marek.safar@gmail.com>
6911 A fix for bug #82676 (Do I get it right now?)
6912 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6913 object before a standard conversion is applied.
6915 2007-09-06 Marek Safar <marek.safar@gmail.com>
6917 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6920 2007-09-05 Marek Safar <marek.safar@gmail.com>
6922 A fix for bug #82676
6923 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6924 non-generic interface types.
6926 2007-09-05 Marek Safar <marek.safar@gmail.com>
6928 A fix for bug #82690
6929 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6931 2007-09-05 Marek Safar <marek.safar@gmail.com>
6933 A fix for bug #82571
6934 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6935 modifier for container based methods.
6937 2007-09-05 Marek Safar <marek.safar@gmail.com>
6939 A fix for bug #82676
6940 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6941 any interface-type T means to any of interface type T.
6943 2007-09-04 Marek Safar <marek.safar@gmail.com>
6945 * namespace.cs: We have 2 versions of System.Core assembly.
6947 2007-09-04 Marek Safar <marek.safar@gmail.com>
6949 A fix for bug #82652
6950 * class.cs (Class.GetClassBases): Compare types and not expressions.
6952 2007-09-04 Marek Safar <marek.safar@gmail.com>
6954 A fix for bug #82620
6955 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6956 actually never worked before.
6957 (IndexerAccess): Emit prepared arguments before they are modified.
6959 2007-09-04 Marek Safar <marek.safar@gmail.com>
6961 A fix for bug #82563
6962 * assign.cs: Revert wrong fix.
6964 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6966 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6967 Instead of ldelema/stdind we have to use temporary variables to handle
6968 cases like String.Concat (params string[]).
6970 2007-08-31 Marek Safar <marek.safar@gmail.com>
6972 * class.cs: EmitAttributes to Emit rename.
6974 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6976 (MemberCore.HasClsCompliantAttribute): Don't depend on
6977 GetClsCompliantAttributeValue execution.
6979 2007-08-31 Marek Safar <marek.safar@gmail.com>
6981 * anonymous.cs: Use shorter type prefix.
6983 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6986 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6987 variables when probing is on.
6989 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6990 unresolved variables.
6991 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6992 handle transparent identifiers.
6994 2007-08-26 Marek Safar <marek.safar@gmail.com>
6996 * attribute.cs (IsClsCompliant): Add nullable types test.
6998 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
7000 * doc.cs : catch other types of exception than XmlException to
7001 report CS1570. Fixed bug #82565.
7003 2007-08-23 Marek Safar <marek.safar@gmail.com>
7005 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
7006 The number of delegate parameters has to match.
7007 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
7010 2007-08-21 Marek Safar <marek.safar@gmail.com>
7012 * anonymous.cs (AnonymousMethod): Generate private anonymous method
7013 to fix problem with private arguments.
7015 2007-08-20 Marek Safar <marek.safar@gmail.com>
7017 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
7019 * decl.cs (MemberName): Ignore generic type with no generic arguments.
7021 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
7022 empty. Add cloning suport.
7024 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
7026 2007-08-20 Marek Safar <marek.safar@gmail.com>
7028 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
7029 to create EmptyCast. It handles EmptyConstantCast specialization for
7032 2007-08-18 Marek Safar <marek.safar@gmail.com>
7034 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
7035 (EmitArrayArgument): One routine for array arguments.
7036 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
7038 2007-08-17 Marek Safar <marek.safar@gmail.com>
7040 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
7042 2007-08-17 Marek Safar <marek.safar@gmail.com>
7044 * anonymous.cs: MemberLookupFinal update.
7046 * class.cs (ConstructorInitializer): Is expression based.
7048 * delegate.cs: MethodGroupExpr update.
7050 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
7052 (Error_MemberLookupFailed): Customizable error override.
7053 (MethodGroupExpr): Keep queried type for later usage.
7054 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
7057 * expression.cs: Error_MemberLookupFailed refactoring.
7058 (New.DoResolve): Resolve as much as possible.
7059 (ElementInitializer.Error_MemberLookupFailed): Object initializer
7060 customization for invalid member types.
7062 * statement.cs: MethodGroupExpr update.
7064 2007-08-16 Marek Safar <marek.safar@gmail.com>
7066 * modifier.cs (Check): Check all modifiers and not only accessibility
7069 2007-08-16 Marek Safar <marek.safar@gmail.com>
7071 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
7072 type and not an expression.
7074 2007-08-16 Marek Safar <marek.safar@gmail.com>
7076 * statement.cs (Catch.Clone): Type and variable can be null.
7078 2007-08-16 Marek Safar <marek.safar@gmail.com>
7080 A fix for bug #81979
7081 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
7082 I am really not sure whether this is the best fix.
7084 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
7087 2007-08-14 Marek Safar <marek.safar@gmail.com>
7089 ** C# 3.0 Object and collection initializers (major re-write)
7091 * assign.cs (DoResolve): Initializers are not assign related.
7093 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
7094 used during collection or object initialization.
7096 * expression.cs (Error_InvalidArguments): Add initializers specific
7097 messages. More will come later because it requires some general
7099 (New.DoResolve): Better error handling for unsafe types.
7100 (EmptyExpressionStatement): New class.
7101 (ElementInitializer): An object initializer expression.
7102 (CollectionElementInitializer): A collection initializer expression.
7103 (CollectionOrObjectInitializers): A block of object or collection
7105 (NewInitialize): New expression with element/object initializers.
7107 * statement.cs: Reverted object/collection initializer hacks.
7109 * typemanager.cs (CSharpName): Filter __arglist type.
7111 2007-08-09 Marek Safar <marek.safar@gmail.com>
7113 ** C# 3.0 Anonymous Types (update to the latest standard)
7115 * expression.cs (Binary.ResolveOperator): Threat all null based types
7117 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
7118 (AnonymousTypeParameter): Updated.
7120 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
7121 (AnonymousTypeClass): New anonymous type container.
7123 * class.cs (AddField): Return operation result.
7125 * generic.cs: Another empty TypeArguments overload.
7127 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
7128 are stored at top of normal hierarchy.
7130 * typemanager.cs (CSharpName): Filter anonymous types.
7132 2007-08-09 Marek Safar <marek.safar@gmail.com>
7134 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
7135 as single Concat call. How could we miss that :-(
7137 2007-08-08 Marek Safar <marek.safar@gmail.com>
7139 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
7141 2007-08-07 Miguel de Icaza <miguel@novell.com>
7143 * expression.cs: Fix the previous commit, the creation of the
7144 arguments array list needs also to be conditional on the arguments
7147 * class.cs: Add a little bit of help to help narrow down problems.
7149 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
7150 not try to copy in that case.
7152 * driver.cs: When building SMCS, include a new different set of
7153 default assemblies here. Do this here so we can control whether
7154 to include the default assemblies with /noconfig.
7156 2007-08-03 Marek Safar <marek.safar@gmail.com>
7158 A fix for bug #81979
7159 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
7162 2007-08-03 Marek Safar <marek.safar@gmail.com>
7164 A fix for bug #82300
7166 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
7167 we are in probing scope.
7169 2007-08-03 Marek Safar <marek.safar@gmail.com>
7171 A fix for bug #82301
7173 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
7174 (Statement.CloneTo): Clone and not map children blocks.
7176 2007-08-03 Marek Safar <marek.safar@gmail.com>
7178 A fix for bug #82299
7180 * expression.cs (LocalVariableReference.CloneTo): Remap local info
7183 * statement.cs (Statement.CloneTo): Clone variables before statements
7184 to allow remaping of local variables.
7186 2007-08-03 Marek Safar <marek.safar@gmail.com>
7188 A fix for bug #82296
7191 * report.cs: Log crash details for future clone problems.
7193 * statement.cs (Return.Clone): Don't clone non-existent expression.
7195 2007-08-03 Raja R Harinath <harinath@gmail.com>
7197 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
7198 (Class.AddBasesForPart): Move CS0537 check here from ...
7199 * cs-parser.jay (class_declaration): ... here. Move calling of
7200 'AddBasesForPart' to ...
7201 (class_bases): ... here.
7202 (struct_declaration, interface_declaration): Update to changes.
7204 2007-08-02 Marek Safar <marek.safar@gmail.com>
7206 A fix for bug #81923
7208 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
7209 conversion is allowed.
7211 2007-08-02 Marek Safar <marek.safar@gmail.com>
7213 A fix for bug #81564
7215 * ecore.cs (EventExpr): Add IsBase handling.
7217 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
7220 2007-08-02 Raja R Harinath <harinath@gmail.com>
7222 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
7223 * cs-parser.jay: Some whitespace cleanups.
7224 (current_delegate): New.
7226 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
7227 a dummy code block, and use 'type_name' instead of 'member_name'.
7228 (interface_declaration, class_declaration): Likewise.
7229 (delegate_declaration): Likewise. Rearrange slightly and use
7231 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7232 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7234 2007-08-02 Marek Safar <marek.safar@gmail.com>
7236 A fix for bug #82039
7238 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7241 * typemanager.cs (CSharpName): Split to string overload.
7243 2007-08-02 Marek Safar <marek.safar@gmail.com>
7246 * report.cs: Updated warning CS0472.
7248 2007-08-01 Marek Safar <marek.safar@gmail.com>
7250 A fix for bug #82181
7252 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7254 2007-08-01 Marek Safar <marek.safar@gmail.com>
7256 A fix for bug #82277
7257 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7259 2007-08-01 Marek Safar <marek.safar@gmail.com>
7261 ** C# 3.0 Type Inference (major bits are working)
7263 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7264 (.ImplicitStandardConversionExists): Uses compatible.
7265 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7266 (.InferReturnType): New method.
7267 (.Compatible): Refactored.
7268 (.ResolveParameters): Uses factory to create resolved parameters.
7269 (.CompatibleMethod): Add probing mode support.
7270 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7271 clearly distinguish between 2 different operations.
7272 (LambdaMethod): Moved to lambda.cs.
7273 (AnonymousMethod): Removed unused fields and methods.
7274 (AnonymousDelegate): Simplified.
7276 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7278 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7280 * delegate.cs (Delegate): New mehods to reduce code duplication.
7281 (.GetConstructor): New method.
7282 (.GetInvokeMethod): New method.
7283 (DelegateCreation): Updated.
7285 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7287 (OverloadResolve): Made probing little bit faster.
7289 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7292 * generic.cs (TypeInferenceContext): Dummy implementation.
7294 * iterators.cs: Updated after Resolve/Define rename.
7296 * lambda.cs (LambdaExpression)
7297 (.ResolveParameters): Handles both type of arguments and type inference too.
7299 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7300 (InflateTypes): Updated.
7302 * support.cs (InflateTypes): Changed signature and updated.
7304 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7305 (MemberLookup_FindMembers): More MS tricks.
7306 (GetParameterData): Ditto.
7307 (GetDelegateParameters): Uses quick path for dynamic types.
7309 2007-08-01 Marek Safar <marek.safar@gmail.com>
7311 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7314 2007-07-31 Marek Safar <marek.safar@gmail.com>
7316 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7319 2007-07-26 Jb Evain <jbevain@novell.com>
7321 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7322 which takes a boolean 'report_errors', similar to the GetMethod.
7323 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7324 in .net 2.1, do not report errors here.
7326 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7327 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7328 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7331 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7332 of the type InternalsVisibleToAttribute before the first call
7333 to CoreLookupType which is allowed to fail (third boolean parameter
7334 to true). Because, during the resolution for a type that is not
7335 immediately found, we try to check if the type is not defined in
7336 a friend assembly, and to do so, we need the
7337 InternalVisibleToAttribute.
7339 2007-07-23 Miguel de Icaza <miguel@novell.com>
7341 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7342 feature that allows structs to be compared against null and inline
7343 the result as true or false.
7345 Notice that the same code is not permitted inside a generic block
7346 of code that would do:
7348 class Foo<T> where T : struct {
7355 It is only allowed if the type of T is not bound (no where
7356 clause). In my opinion, this CSC 2 behavior is broken but people
7357 seem to be using it (IronRuby does, a few bug reports on bugzilla
7358 have it and some people have complained about it).
7360 All of the users that depend on this behavior have code that is
7363 * report.cs (Warning, Error): make these take object arguments,
7364 not strings, as that allows us to take advantage of Format.
7366 2007-07-20 William Holmes <billholmes54@gmail.com>
7368 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7369 Left member variable for the Count.
7370 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7371 MemberName.CountTypeArguments to avoid a NRE.
7373 This code is contributed under the MIT X11 license
7375 2007-07-18 Marek Safar <marek.safar@gmail.com>
7377 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7379 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7381 * doc.cs : generic method arguments are written as ``x while generic
7382 type arguments are `x. Combined with the previous change, fixed bug
7385 2007-07-18 Raja R Harinath <rharinath@novell.com>
7388 * expression.cs (Binary.ResolveOperator): When converting
7389 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7391 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7393 * doc.cs : when T: or whatever x: is specified, it does not really
7394 check the doc comment's syntax correctness. Fixed bug #82006.
7396 2007-07-18 Marek Safar <marek.safar@gmail.com>
7398 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7399 LambdaExpression better.
7401 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7403 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7405 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7406 as it can be generated.
7408 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7411 * lambda.cs (LambdaExpression): Refactored to share same code with
7412 AnonymousMethodExpression.
7414 2007-07-17 Marek Safar <marek.safar@gmail.com>
7416 * anonymous.cs (MakeName): Include host name for easier debugging.
7417 (LambdaMethod): New class for lambda spcecific stuff.
7419 * attribute.cs: Set EmitContext return type.
7421 * class.cs: Set EmitContext return type.
7423 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7424 with null/void meaning.
7426 * iterators.cs (ContainerType): Implemented.
7428 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7430 * statement.cs (Return): Updated to lambda expressions.
7431 (Block.CloneTo): Parent can be null.
7433 2007-07-13 Marek Safar <marek.safar@gmail.com>
7435 A fix for bug #81917
7436 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7438 * class.cs (FixedField): Check whether field is in unsafe scope.
7440 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7441 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7443 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7446 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7448 2007-07-13 Marek Safar <marek.safar@gmail.com>
7450 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7451 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7454 2007-07-13 Marek Safar <marek.safar@gmail.com>
7456 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7458 2007-07-13 Marek Safar <marek.safar@gmail.com>
7460 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7461 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7463 * codegen.cs(EmitContext): Add ProbingMode flag.
7465 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7467 * driver.cs: For now set both warning values.
7469 * ecore.cs (SimpleName): Name is readonly.
7470 (MethodGroup.OverloadResolve): One quick path for probing.
7472 * expression.cs (Unary): Set Oper r/o.
7473 (Binary): Set Oper r/o.
7474 (ParameterReference): Set few instance variables as r/o.
7475 (ParameterReference.DoResolveBase): Don't capture aruments when
7477 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7478 (Arglist): arguments are private.
7479 (SizeOf): type is private and r/o.
7480 (MemberAccess): arguments are private.
7482 * report.cs: Enhanced reporting on/off capabilities.
7484 * lambda.cs: Uses ec.IsInProbingMode.
7485 (ContextualReturn): Derives from return.
7487 * rootcontext.cs: For now set both warning values.
7489 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7491 (Return.Resolve): Don't die immediately.
7492 (Block.Resolve): Speed-up probing.
7493 (Block.CloneTo): Clone only child blocks.
7495 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7497 * iterators.cs: reverted Miguel's latest change (r81925) as it
7498 breaks the build in System.
7500 2007-07-13 Miguel de Icaza <miguel@novell.com>
7502 * iterators.cs (Yield.CheckContext): Check for the iterator type
7503 also here as we can call into Yield even in codepaths that are not
7505 (MethodOrOperator is the only path that was checked).
7507 In addition to the standard check, use a more specific check for
7508 constructors to report a more verbose error.
7510 2007-07-12 Miguel de Icaza <miguel@novell.com>
7512 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7513 report the warning and continue
7515 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7516 values on the stack on the call to Emit. Use EmitStatement if
7517 possible, or using Emit + Pop if not possible. Fixes #82064
7519 2007-07-12 Raja R Harinath <rharinath@novell.com>
7521 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7522 avoid try...finally in some cases.
7524 2007-07-10 Marek Safar <marek.safar@gmail.com>
7526 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7528 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7529 instead of method. Re-use standard error handling.
7530 (ConstructorInitializer.Emit): Simplified.
7532 * delegate.cs: Updated after Invocation.EmitCall change.
7534 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7535 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7536 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7537 method and don't permanently changing input arguments.
7538 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7539 is resolved it has one of the candidates is the best one which is later
7540 used to emit. Removed a few unused method.
7541 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7543 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7544 (Binary.ResolveOperator): Ditto.
7545 (ConditionalLogicalOperator.DoResolve): Ditto.
7546 (Invocation): Uses method group.
7547 (Invocation.DoResolve): Simplified.
7548 (Invocation.EmitCall): Removed useless is_static.
7549 (Invocation.Emit): Delegate to method group.
7550 (Invocation.EmitStatement): Simplified.
7551 (New): Uses method group.
7552 (MemberAccess.DoResolve): Don't destroy original expression.
7554 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7556 2007-07-04 Marek Safar <marek.safar@gmail.com>
7558 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7561 * lambda.cs: Add custom error message type.
7563 2007-07-03 Marek Safar <marek.safar@gmail.com>
7565 * lambda.cs: Simplified little bit.
7567 * parameter.cs: Introduced ImplicitLambdaParameter.
7568 (Parameters.CreateFullyResolved): New factory instead of ctor.
7572 * delegate.cs: Updated parameter creation.
7574 2007-07-03 Marek Safar <marek.safar@gmail.com>
7576 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7579 * generic.cs: Synchronized with gmcs.
7581 2007-07-03 Marek Safar <marek.safar@gmail.com>
7583 * class.cs (Indexer): Check return type as soon as possible.
7585 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7588 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7590 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7592 * parameter.cs (Parameter): Use expression type when it is available.
7594 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7595 method modifier for the first parameter only.
7597 2007-06-24 Marek Safar <marek.safar@gmail.com>
7599 A fix for bug #81938
7600 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7602 * constant.cs: Tide up an exception message.
7604 2007-06-22 Marek Safar <marek.safar@gmail.com>
7606 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7607 an uninitialized variable is used.
7609 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7611 2007-06-22 Marek Safar <marek.safar@gmail.com>
7613 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7614 not found error handling.
7616 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7618 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7619 (ArrayCreation.DoResolve): Simplified.
7620 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7621 its own resolve process.
7622 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7624 2007-06-20 Marek Safar <marek.safar@gmail.com>
7626 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7629 2007-06-20 Marek Safar <marek.safar@gmail.com>
7631 * cs-tokenizer.cs: Removed var related stuff.
7633 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7634 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7635 a type and a keyword at same time.
7637 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7640 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7641 implicitly typed arrays, more changes will follow.
7643 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7645 2007-06-19 Marek Safar <marek.safar@gmail.com>
7647 * ecore.cs (VarExpr): Removed Handled field.
7649 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7650 build-in assign functionality.
7651 (ForEach.Resolve): Removed all implicitly typed local variable code and
7653 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7654 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7656 2007-06-18 Marek Safar <marek.safar@gmail.com>
7658 * assign.cs: Removed implicitly typed local variable check.
7660 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7661 referencing implicitly typed local variable.
7662 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7665 * statement.cs (Fixed): Removed unsupported implicitly typed local
7668 2007-06-15 Marek Safar <marek.safar@gmail.com>
7670 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7672 2007-06-14 Marek Safar <marek.safar@gmail.com>
7674 A fix for bugs #81855 and #76274
7675 * attribute.cs (AttachTo): Always set owner for global attributes to
7678 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7681 * cs-parser.jay: Assembly and module attributes must precede all other
7682 elements except using clauses and extern alias declarations.
7684 2007-06-13 Marek Safar <marek.safar@gmail.com>
7686 A fix for bug #81748
7688 * expression.cs: More checks for non ISO-1 features.
7690 2007-06-12 Marek Safar <marek.safar@gmail.com>
7692 A fix for bug #81807
7693 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7694 present inside switch statement and it is required by nullable check.
7696 2007-06-12 Marek Safar <marek.safar@gmail.com>
7698 A fix for bug #81840
7699 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7700 when type matching fails.
7702 * namespace.cs: Tiny error message change.
7704 2007-06-12 Marek Safar <marek.safar@gmail.com>
7706 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7707 reporting. Added automatic property check.
7709 * class.cs: Updated after CheckAbstractAndExtern relocation.
7710 (AEventPropertyAccessor.GetSignatureForError): Customized.
7712 2007-06-11 Marek Safar <marek.safar@gmail.com>
7714 * class.cs (DefineBaseTypes): Base type can be undefined.
7716 * ecore.cs (TypeLookup): Minor refactoring.
7717 (DoResolveAsTypeStep): Removed redundant check.
7719 * namespace.cs (Lookup): Removed redundant check.
7721 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7722 ResolveAsTypeTerminal step.
7723 (BootstrapCorlib_*): Simplified.
7724 (PopulateCoreType): Core types can be now external.
7726 2007-06-07 Marek Safar <marek.safar@gmail.com>
7728 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7730 (InferTypeArguments): Infers anonymous expression type arguments.
7731 (Compatible): Split to Compatible and InferTypeArguments.
7733 * lambda.cs: Updated.
7735 2007-06-08 Marek Safar <marek.safar@gmail.com>
7737 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7739 2007-06-07 Raja R Harinath <harinath@gmail.com>
7741 Fix #80477, cs0135-2.cs, cs0135-3.cs
7742 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7743 names to the "known" variables list.
7744 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7745 parameter names are also "known".
7746 (Block.CheckError136): Remove.
7747 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7750 2007-06-07 Marek Safar <marek.safar@gmail.com>
7752 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7754 2007-06-06 Marek Safar <marek.safar@gmail.com>
7756 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7757 internal error not an user error.
7759 * expression.cs (IsApplicable): Refactored to make debugging easier.
7761 * support.cs: More tricks for non-mono runtimes.
7763 * typemanager.cs (CoreLookupType): Made public.
7764 (InitSystemCore): All linq specific stuff moved to linq.cs
7766 2007-06-05 Marek Safar <marek.safar@gmail.com>
7768 * typemanager.cs (CSharpSignature): One more missing build-in types
7770 More tricks for non-mono runtime.
7772 2007-06-05 Raja R Harinath <harinath@gmail.com>
7774 * statement.cs (Block.CheckError136_InParents): Remove.
7775 (Block.AddVariable): Use GetParameterInfo instead.
7776 (ToplevelBlock.ProcessArguments): Likewise.
7778 2007-06-04 Raja R Harinath <rharinath@novell.com>
7780 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7782 (ToplevelBlock.GetParameterInfo): Split out of ...
7783 (ToplevelBlock.GetParameterRefernce): ... this.
7784 (ToplevelBlock.ParameterMap): Remove.
7785 * expression.cs (ParameterReference): Update to use
7786 ToplevelParameterInfo.
7788 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7791 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7792 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7794 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7795 (ToplevelBlock.ProcessParameters) ... here.
7796 (ToplevelBlock..ctor): Invoke it.
7798 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7801 * statement.cs (IKnownVariable): New interface.
7802 (LocalInfo): Implement it.
7803 (ToplevelParameterInfo): New class.
7804 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7805 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7806 GetKnownVariableInfo.
7808 2007-06-03 Raja R Harinath <harinath@gmail.com>
7810 Partly speed up CS0136 error checks.
7811 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7812 'recurse' parameter.
7813 (Block.DoCheckError136): Only check errors in parameters. Move
7814 local variable checks ...
7815 (Block.AddVariable): ... here, and ...
7816 (ToplevelBlock.ResolveMeta): ... here.
7818 2007-06-02 Raja R Harinath <harinath@gmail.com>
7820 * statement.cs (Block.IsChildOf): Remove.
7822 * statement.cs (Statement.Clone): Move special case code ...
7823 (Block.CloneTo): ... here.
7825 2007-05-29 Raja R Harinath <rharinath@novell.com>
7827 * statement.cs (ToplevelBlock.container): Remove field. It's
7828 redundant with 'Parent'.
7829 (ToplevelBlock.ContainerBlock): Remove accessor.
7830 (ToplevelBlock..ctor): Update to changes. Register anonymous
7831 child with parent here, ...
7832 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7834 (start_anonymous): Don't save current_block.
7835 (top_current_block): Remove.
7837 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7838 (Block.Resolve): Update to changes.
7839 (Block..ctor): Move setting of "correct" 'Toplevel'
7840 and 'Explicit' fields to ...
7841 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7843 2007-05-27 Raja R Harinath <harinath@gmail.com>
7846 * statement.cs (Block.Implicit): Remove.
7847 (Block): Update to changes.
7848 * flowanalysis.cs: Likewise.
7850 Mildly speed up CheckInvariantMeaningInBlock
7851 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7852 Recursively call AddKnownVariable to all enclosing blocks.
7853 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7854 Remove recursive calls.
7855 (Block): Update to changes.
7857 New ExplicitBlock invariants
7858 * statement.cs (Block.Explicit): New field. It points to the
7859 immediately enclosing non-implicit block.
7860 (Block..ctor): Maintain the invariant.
7861 * cs-parser.jay: Take advantage of invariant.
7863 Introduce ExplicitBlock
7864 * statement.cs (ExplicitBlock): New.
7865 (ToplevelBlock): Derive from it.
7866 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7868 (Block.Implicit): Update to changes.
7869 * cs-parser.jay: Update to changes.
7872 * codegen.cs (EmitContext.IsLastStatement): Remove.
7873 * statement.cs (Block.DoEmit): Update to changes.
7875 2007-05-25 Raja R Harinath <rharinath@novell.com>
7877 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7878 modifying current_block directly.
7880 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7882 * class.cs: Implemented automatic properties (C# 3.0)
7883 Thanks to Marek for the help.
7885 2007-05-23 Raja R Harinath <rharinath@novell.com>
7887 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7888 variable as assigned, note also that all its components are
7890 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7892 2007-05-19 Marek Safar <marek.safar@gmail.com>
7894 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7895 member is marked as compiler generated.
7897 * decl.cs (MemberCore): Refactored ModFlags into property.
7899 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7900 (Check): Check only accessibility modifiers.
7902 2007-05-18 Raja R Harinath <rharinath@novell.com>
7904 Track all assignable slots in one bit array
7905 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7906 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7907 logic from VariableMap constructor here. Use the same 'offset'
7908 variable that's later used for computing offsets of local
7910 * flowanalysis.cs (UsageVector.parameters): Remove.
7911 (UsageVector): Update to changes.
7912 (VariableMap): Remove.
7914 Avoid creating ParameterMap in every block
7915 * statement.cs (Block.ParameterMap): Move ...
7916 (ToplevelBlock.ParameterMap): ... here.
7917 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7919 * flowanalysis.cs (FlowBranching.param_map): Remove.
7920 (FlowBranching.UsageVector): Update to changes.
7921 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7923 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7925 * expression.cs (ParameterReference): Distinguish between block
7926 where parameter was referenced and declared.
7928 2007-05-18 Marek Safar <marek.safar@gmail.com>
7930 * flowanalysis.cs, statement.cs: Put back improved error handling.
7932 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7936 Imporved object and collection initialization (C# 3.0).
7938 2007-05-15 Marek Safar <marek.safar@gmail.com>
7940 A fix for bug #81380
7941 * expression.cs (Is.DoResolve): Only value types have constant `is'
7944 2007-05-15 Raja R Harinath <rharinath@novell.com>
7946 * statement.cs (ToplevelBlock.child): Remove.
7948 2007-05-15 Raja R Harinath <harinath@gmail.com>
7950 Rationalize ResolveMeta: refactoring
7951 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7952 out constant handling code into ...
7953 (Block.DoResolveConstants): ... this.
7955 Rationalize ResolveMeta: kill local_map
7956 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7957 (Block.AssignableSlots): New.
7958 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7959 for locals -- move code from VariableMap here. Avoid unnecessary
7961 * flowanalysis.cs (FlowBranching.local_map): Remove.
7962 (FlowBranching..ctor): Use Block.AssignableSlots.
7963 (VariableMap): Remove unused constructors.
7965 2007-05-11 Raja R Harinath <rharinath@novell.com>
7967 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7969 2007-05-11 Marek Safar <marek.safar@gmail.com>
7971 * typemanager.cs (IsFriendAssembly): Should not be called for building
7974 2007-05-09 Marek Safar <marek.safar@gmail.com>
7976 * literal.cs (NullConstant): Print null in all cases.
7978 * expression.cs (Binary.ResolveOperator): Implemented delegate
7979 comparison based on C# 2.0 changes.
7981 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7983 This code is contributed under the MIT X11 license
7985 The following enables support for several C# 3.0 language features:
7987 * cs-tokenizer.cs: Added support for the "var" keyword.
7989 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7990 Added VarExpr class to facilitate type inferencing.
7992 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7993 to support anonymous types.
7995 * assign.cs: Added support for type inferencing and initialization.
7997 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7999 * expression.cs: Added implicit array support to ArrayCreation.
8000 Added 5 types and 1 interface:
8002 IInitializable Implementing classes can inject initializing
8003 statements after object instantiation.
8005 Initializer Stores data for object initialization.
8007 AnonymousType An expression for anonymous types.
8009 AnonymousTypeParameter Stores data about an anonymous type's field.
8011 NewInitialize An expression for object initialization.
8013 CollectionInitialize An expression for collection initialization.
8015 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
8018 2007-05-06 Marek Safar <marek.safar@gmail.com>
8020 A fix for bug #81500
8021 * cs-tokenizer.cs: Add special handling for coalescing operator.
8023 2007-05-06 Marek Safar <marek.safar@gmail.com>
8025 A fix for bug #81529
8026 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
8027 its value from base class until it is redefined.
8029 2007-05-02 Raja R Harinath <rharinath@novell.com>
8031 Fix regression in cs0631-3.cs
8032 * cs-parser.jay (operator_declarator): Add opt_attributes to error
8033 fallback. Make error fallback catch more cases.
8035 2007-05-01 Miguel de Icaza <miguel@novell.com>
8037 * cs-parser.jay: Allow parameters in operator declarations to have
8040 2007-04-27 Miguel de Icaza <miguel@novell.com>
8042 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
8045 * lambda.cs (ContextualReturn.Resolve): An expression is valid
8046 inside the ContextualReturn, it does not have to be an
8047 ExpressionStatement.
8049 2007-04-24 Miguel de Icaza <miguel@novell.com>
8051 * lambda.cs (ContextualReturn.Resolve): if the return type is not
8054 2007-04-23 Miguel de Icaza <miguel@novell.com>
8056 * anonymous.cs (AnonymousContainer): split the virtual Resolve
8057 method in two methods: ResolveNoDefine and Resolve.
8059 ResolveNoDefine will stop just after ResolveTopBlock has been
8062 Resolve will then continue by creating a method and issuing the
8063 call to method.Define ().
8065 (AnonymousMethod): Split and implement the new Resolve and
8066 ResolveNoDefine as well.
8068 * lambda.cs (LambdaExpression): Split the anonymous method
8069 resolution code into a separate routine (CoreCompatibilityTest)
8070 from DoCompatibleTest.
8072 (LambdaExpression.TryBuild): New method, this method tries to
8073 build the LambdaExpression with the given set of types to be used
8074 as the types for the various parameters of the lambda expression.
8076 If the compilation succeed with the given types, the infered type
8077 of the Anonymous method is returned, otherwise null is returned.
8079 2007-04-23 Marek Safar <marek.safar@gmail.com>
8081 A fix for bug #81414
8082 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
8084 2007-04-22 Miguel de Icaza <miguel@novell.com>
8086 * cs-tokenizer.cs: Change various identifiers here from the
8087 camelCasing to the recommended Linux-like style for instance
8088 variables from the Coding Guidelines.
8090 2007-04-19 Martin Baulig <martin@ximian.com>
8093 (Convert.ImplicitReferenceConversionCore): Allow conversions from
8094 System.Enum to System.ValueType.
8096 2007-04-13 Martin Baulig <martin@ximian.com>
8098 Rewrote implicit reference conversions. We need to distinguish
8099 between implicit reference conversions (13.1.4) and implicit
8100 boxing conversions (13.1.5).
8102 According to the spec, there's an an implicit conversion
8103 "From a one-dimensional array-type S[] to IList<T> and base
8104 interfaces of this interface, provided there is an implicit
8105 reference conversion from S to T." Note that this does not
8106 include boxing conversions.
8109 (Convert.ImplicitTypeParameterBoxingConversion): New method.
8110 (Convert.ImplicitReferenceConversion): Split into
8111 ImplicitReferenceConversionCore() and
8112 ImplicitBoxingConversionExist().
8113 (Convert.ImplicitReferenceConversionExists): Use the new
8114 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
8116 2007-04-12 Martin Baulig <martin@ximian.com>
8118 * convert.cs (Convert.ImplicitReferenceConversion): Move the
8119 `TypeManager.null_type' checks up to the top of the method.
8121 2007-04-11 Marek Safar <marek.safar@gmail.com>
8123 A fix for bug #81350
8124 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
8127 2007-04-11 Martin Baulig <martin@ximian.com>
8129 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
8130 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
8131 to make this work for generic classes; fixes #79561.
8133 2007-04-11 Martin Baulig <martin@ximian.com>
8135 * expression.cs (As): Add support for nullable types; fixes #79371.
8137 2007-04-11 Martin Baulig <martin@ximian.com>
8139 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
8140 `type.FullName' is null; fixes #80243.
8142 2007-04-11 Martin Baulig <martin@ximian.com>
8144 * expression.cs (Invocation.IsApplicable): Don't modify the method
8145 if type inference succeeded, but the method was not applicable.
8148 2007-04-10 Marek Safar <marek.safar@gmail.com>
8150 A fix for bug #81324
8151 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
8152 internal and external namespaces containers.
8154 2007-04-10 Martin Baulig <martin@ximian.com>
8156 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
8157 TypeManager.DropGenericMethodArguments() so we also call
8158 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
8160 2007-04-10 Martin Baulig <martin@ximian.com>
8162 * iterators.cs (Iterator.CreateIterator): Don't crash if
8163 `method.ReturnType' is null. This happens if something went wrong
8164 while resolving that typ (we already reported an error in this case).
8166 2007-04-10 Martin Baulig <martin@ximian.com>
8168 * expression.cs (New.DoResolve): Don't call CheckComImport() on
8169 generic interfaces; report the CS0144 directly.
8171 2007-04-10 Martin Baulig <martin@ximian.com>
8173 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
8174 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
8176 2007-04-10 Martin Baulig <martin@ximian.com>
8178 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
8180 2007-04-09 Raja R Harinath <rharinath@novell.com>
8183 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
8184 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
8187 * statement.cs (For.Resolve): If resolution fails, use
8190 2007-04-08 Marek Safar <marek.safar@gmail.com>
8192 * anonymous.cs (MakeName): Make faster and zero-based.
8193 (VerifyExplicitParameterCompatibility): Back to mode where generic
8194 parameter is ignored.
8195 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
8197 * class.cs (EmitType): Method can emit another new method.
8199 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
8201 * driver.cs: Updated.
8203 * lambda.cs: Reuse predefined empty parameters.
8205 * parameter.cs: Updated
8207 * support.cs: Implemented InflateTypes.
8209 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
8210 (InitSystemCore): Introduced to isolate 3.0 dependencies.
8212 2007-04-03 Martin Baulig <martin@ximian.com>
8216 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
8217 version of TypeManager.IsOverride() which also works with generic
8220 2007-04-03 Martin Baulig <martin@ximian.com>
8225 (Convert.ExplicitReferenceConversion): We need to cast when
8226 converting from IList<T> to S[].
8228 2007-04-01 Marek Safar <marek.safar@gmail.com>
8230 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8233 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8235 2007-03-31 Marek Safar <marek.safar@gmail.com>
8237 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8238 argument and return type inferring.
8240 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8241 (ReturnType): Turned to property.
8243 * statement.cs (Return): Implemented return type inferring.
8245 * support.cs (ReflectionParameters): Use local types if possible.
8247 2007-03-30 Raja R Harinath <rharinath@novell.com>
8249 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8250 (FlowBranching.UsageVector): Update to changes.
8252 Prepare to kill 'Reachability'
8253 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8254 argument of constructor.
8256 2007-03-29 Raja R Harinath <rharinath@novell.com>
8258 Prepare to kill 'Reachability'
8259 * flowanalysis.cs (UsageVector.is_unreachable): New.
8260 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8261 'reachability', and verify they're consistent.
8264 * expression.cs (New.EmitStatement): Handle type parameters here too.
8266 2007-03-29 Martin Baulig <martin@ximian.com>
8271 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8272 CompilerGeneratedClass.
8273 (ScopeInfo.EmitScopeInstance): Make this protected.
8274 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8275 `ec.CurrentAnonymousMethod.Scope == Scope'.
8277 * statement.cs (Block.ScopeInfo): Make this a property.
8279 2007-03-27 Raja R Harinath <harinath@gmail.com>
8281 Prepare to kill 'Reachability'
8282 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8283 (FlowBranching.UsageVector.Reachability): Remove property.
8284 (FlowBranching.UsageVector.IsUnreachable): New property.
8285 (FlowBranching.UsageVector.ResetBarrier): New.
8286 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8287 * codegen.cs, statement.cs: Update to changes.
8289 2007-03-27 Martin Baulig <martin@ximian.com>
8294 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8297 2007-03-26 Raja R Harinath <rharinath@novell.com>
8299 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8300 instead of TriState. Remove all mention of TriState.
8302 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8303 replaced by a boolean. Add boolean 'is_unreachable' field, check
8304 and maintain invariants.
8306 2007-03-25 Marek Safar <marek.safar@gmail.com>
8308 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8310 2007-03-25 Marek Safar <marek.safar@gmail.com>
8312 * expression.cs: Stop using obsolete 2.0 opcodes.
8314 2007-03-25 Marek Safar <marek.safar@gmail.com>
8316 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8317 one of the latests Martin's fixes.
8319 2007-03-23 Miguel de Icaza <miguel@novell.com>
8321 * expression.cs: On BigEndian systems, swap the bytes, temporary
8322 solution until we get a new bitconverter class.
8324 2007-03-23 Martin Baulig <martin@ximian.com>
8328 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8329 "Method" and "Method`1". Normally, a cache lookup is done on the
8330 "Method" form (ie. without the generic arity), but this one makes
8331 lookups on the full form work as well.
8333 2007-03-22 Raja R Harinath <rharinath@novell.com>
8335 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8338 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8340 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8341 ordered_member_list, to TypeBuilder to store members to be defined
8342 in the order they were parsed in.
8343 - ordered_explicit_member_list contains all properties indexers
8344 and methods that are defined as explicit implementation of an
8345 interface or base class.
8346 - ordered_member_list contains all properties indexers and methods
8347 that are not defined as explicit implementation of an interface
8350 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8351 functionality in these removed classes has been replaced with
8352 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8353 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8355 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8356 to CheckForDuplications inside GetMethod and SetMethod Define Method
8357 to handle method property and indexer name conflicts.
8361 All code is contributed under the MIT/X11 license.
8363 2007-03-20 Martin Baulig <martin@ximian.com>
8365 * class.cs (TypeContainer.Interfaces): Removed; they're now
8366 included in `TypeContainer.Types'.
8368 2007-03-20 Martin Baulig <martin@ximian.com>
8370 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8372 * class.cs (TypeContainer.CreateType): New public method. This is
8373 now called before DefineType() to create the TypeBuilders.
8374 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8375 has already been created by CreateType().
8376 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8377 don't resolve our base classes here; this has been moved into
8378 DefineBaseTypes(). We're now called from CreateType().
8379 (TypeContainer.DefineBaseTypes): New private method; resolve our
8380 base classes here. We're now called from DefineType().
8383 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8384 our types first to create all the TypeBuilders. After that, call
8385 TypeContainer.DefineType() on all the types which'll resolve their
8386 base classes and setup the resolve order.
8388 2007-03-20 Martin Baulig <martin@ximian.com>
8390 * class.cs (TypeContainer.Enums): Removed; they're now included in
8391 `TypeContainer.Types'.
8393 2007-03-20 Martin Baulig <martin@ximian.com>
8396 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8397 (TypeContainer.DoResolveMembers): Call DefineType() on our
8398 `compiler_generated' classes; moved here from DefineNestedTypes().
8401 (RootContext.ResolveTree): Call ResolveMembers() on all
8402 TypeContainer's in the `type_container_resolve_order'.
8404 2007-03-19 Marek Safar <marek.safar@gmail.com>
8406 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8408 2007-03-17 Marek Safar <marek.safar@gmail.com>
8410 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8411 implementation flags.
8413 2007-03-17 Marek Safar <marek.safar@gmail.com>
8415 * class.cs: More optimizations for type parameters.
8417 2007-03-15 Marek Safar <marek.safar@gmail.com>
8419 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8421 * ecore.cs, parameter.cs: More common code for both corlibs.
8423 * typemanager.cs (IsGenericMethod): Simplified.
8425 2007-03-15 Raja R Harinath <rharinath@novell.com>
8427 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8429 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8431 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8432 unconditionally. Simplify explanation.
8433 (Try.Resolve, Using.Resolve): Likewise.
8435 2007-03-15 Martin Baulig <martin@ximian.com>
8439 * decl.cs (DeclSpace): If we're a partial class, use our
8440 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8442 2007-03-15 Raja R Harinath <rharinath@novell.com>
8444 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8446 (FlowBranching.UsageVector): Update to changes.
8447 (FlowBranching.MergeSiblings): Likewise.
8448 * statement.cs: Likewise.
8450 2007-03-15 Martin Baulig <martin@ximian.com>
8455 (MemberCache): Added a special .ctor for type parameters.
8458 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8461 2007-03-09 Martin Baulig <martin@ximian.com>
8463 * enum.cs (Enum): Make this a TypeContainer.
8464 (EnumMember): Derive from `Const'.
8467 (Const.DoResolveValue): New protected virtual method; move most of
8468 the functionality of ResolveValue() here so we can override it in
8470 (Const.CreateConstantReference): Make this virtual.
8472 * class.cs (Kind): Add `Kind.Enum'.
8473 (TypeContainer.Emit): Don't emit the enums here; they're already
8474 in the `RootContext.typecontainer_resolve_order'.
8476 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8477 here; they're already in the `typecontainer_resolve_order'.
8479 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8480 TypeManager.DropGenericTypeArguments().
8483 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8484 (TypeManager.IsEnumType): Likewise.
8485 (TypeManager.EnumToUnderlying): Likewise.
8486 (TypeManager.IsEqual): Add support for enums.
8488 2007-03-12 Raja R Harinath <rharinath@novell.com>
8490 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8491 DefaultParameterValueAttribute to be undefined, say if System.dll
8494 2007-03-11 Marek Safar <marek.safar@gmail.com>
8496 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8499 2007-03-10 Marek Safar <marek.safar@gmail.com>
8501 * class.cs, parameter.cs: Unified parameters verification.
8503 2007-03-08 Martin Baulig <martin@ximian.com>
8505 * cs-parser.jay (constructor_header): Pass the location to the
8506 newly created TopLevelBlock.
8508 2007-03-07 Martin Baulig <martin@ximian.com>
8510 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8512 2007-03-06 Miguel de Icaza <miguel@novell.com>
8514 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8515 with the changes from David, fixes the build.
8517 2007-03-05 David Mitchell <dmitchell@logos.com>
8519 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8520 and its base interfaces to a one-dimensional array type S[],
8521 provided there is an implicit or explicit reference conversion
8524 2007-03-03 Marek Safar <marek.safar@gmail.com>
8526 * cs-tokenizer.cs: Implemented basic linq grammar.
8528 * driver.cs: Set linq lang version on demand.
8530 2007-02-26 Marek Safar <marek.safar@gmail.com>
8532 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8534 2007-02-25 Marek Safar <marek.safar@gmail.com>
8536 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8539 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8541 Check property and event extern attributes.
8543 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8546 2007-02-24 Marek Safar <marek.safar@gmail.com>
8548 A fix for bug #80407
8549 * ecore.cs: Don't report ambiguity error when methods have same parent.
8551 2007-02-23 Marek Safar <marek.safar@gmail.com>
8553 A fix for bug #80878
8554 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8556 2007-02-22 Marek Safar <marek.safar@gmail.com>
8558 * attribute.cs: Enable ExtensionAttribute presence test.
8560 2007-02-22 Marek Safar <marek.safar@gmail.com>
8562 * class.cs: Warn about missing GetHashCode only when Equals is override.
8564 * decl.cs: Check accessibility of type arguments.
8566 * typemanager.cs: Correctly report nullable array.
8568 2007-02-20 Marek Safar <marek.safar@gmail.com>
8570 * class.cs, report.cs: Capture more details when things go wrong.
8572 2007-02-20 Marek Safar <marek.safar@gmail.com>
8574 A fix for bug #80650
8575 * cs-parser.jay: Anonymous container starts at constructor declaration
8576 and not at block beginning because it has to be usable in constructor
8579 * statement.cs: Use context location and not block one for error reporting.
8581 2007-02-18 Marek Safar <marek.safar@gmail.com>
8583 A fix for bug #78712
8584 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8587 2007-02-18 Marek Safar <marek.safar@gmail.com>
8589 A fix for bug #80493 by Atsushi Enomoto
8590 * cs-parser.jay: Ignore invalid attribute target.
8592 2007-02-18 Marek Safar <marek.safar@gmail.com>
8594 * cs-tokenizer.cs: Ignore '\0' as white space character.
8596 2007-02-17 Miguel de Icaza <miguel@novell.com>
8598 * cs-parser.jay: Add support for lambda expressions to the mcs
8601 * lambda.cs: Only clone when we are probing, not on the final call
8602 (Compatible is the final call).
8604 * statement.cs (CloneContext): Introduce class to provide block
8605 remapping during clone.
8607 All statements Clone themselves now.
8609 (Clone): special handling for blocks, when we clone a block, we
8610 register the block inside this routine, as children of the block
8611 might trigger a lookup.
8613 * expression.cs: Add support for CloneContext in all expressions.
8615 2007-02-17 Marek Safar <marek.safar@gmail.com>
8617 A fix for bug #80493
8618 * statement.cs: Report ambiguous warning when interfaces are not related.
8620 2007-02-15 Marek Safar <marek.safar@gmail.com>
8622 C# 3.0 extension methods.
8624 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8625 cannot be used directly.
8627 * class.cs (Class.Emit): Emit extension attribute if any class method
8628 is extension method.
8629 (Method.Define): Add basic extension method validation conditions.
8630 (Method.Emit): Emit extension attribute for method.
8632 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8633 extension method exists. Currently we follow same approach as Microsoft
8634 does, emit even if a method or a class are private but this can change
8637 * cs-parser.jay: Add handling of `this' keyword in method parameters
8640 * decl.cs (DeclSpace.IsStaticClass): New property.
8641 (MemberCache.FindExtensionMethods): Looks for extension methods with
8642 defined name and extension type.
8644 * doc.cs: Updated after OverloadResolve changes.
8646 * driver.cs: Add new soft reference to System.Core.dll.
8648 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8649 (ExtensionMethodGroupExpr): Represents group of extension methods.
8651 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8652 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8653 to MethodGroupExpr and made non-static for easier customization.
8654 (Invocation.DoResolve): Add extension method lookup when no standard
8656 (MemberAccess.DoResolve): Try extension methods if no member exists.
8658 * modifiers.cs: Add METHOD_EXTENSION modifier.
8660 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8661 as well as candidate extension type.
8662 (ComputeNamespaces): When assembly constains extension methods registers
8664 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8665 extension method lookup.
8666 (Namespace.LookupExtensionMethod): Looks for extension method in this
8668 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8669 find a method which matches name and extensionType.
8671 * parameter.cs (Parameter): Add This modifer.
8672 (HasExtensionMethodModifier): New property.
8673 (Resolve): Add extension parameter check.
8674 (ModFlags): turned to property to exclude this modifier as it is not real
8676 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8678 * support.cs (ParameterData): Add ExtensionMethodType.
8679 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8681 * typemanager.cs: Add type and ctor extension attribute type.
8683 2007-02-15 Miguel de Icaza <miguel@novell.com>
8685 * report.cs (DisableErrors, EnableErrors): used to prevent error
8686 output when we are "trying" to compile various methods with
8689 * ecore.cs (Expression): Add Clone method that calls the virtual
8690 CloneTo method. The current CloneTo method in Expression throws
8691 an exception so we can track down all the places where this must
8692 be implemented (not using abstract, because that would be a lot of
8693 up-front-work before we can start testing the implementation
8696 Important: we only need Clone capabilities for expressions created
8697 by the parser, as the expressions we will be cloning are
8698 expressions in the pre-resolved state. This vastly simplifies
8701 (SimpleName): Add CloneTo that does nothing.
8702 (EmptyCast): Add CloneTo.
8704 * expression.cs (Binary): Implement CloneTo.
8705 (Invocation.IsApplicable): Store the current ec in
8706 EmitContext.TempEc and restore it on return. This is used so we
8707 do not have to sprinkle hundres of methods with an extra
8708 EmitContext, we know that the only user is the lambda expression
8709 ImplicitConversionExists code.
8711 (Argument): Add Cloning capabilities.
8712 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8713 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8714 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8715 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8716 IndexerAccess): Add Clone capability.
8718 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8720 (Argument): Add cloning capability.
8722 * assign.cs (Assign): Implement CloneTo.
8724 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8726 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8727 version by calling Convert with the EmitContext (that we are
8728 currently storing in ec, this is not great, but will do for now,
8729 to avoid passing EmitContext parameters to hundreds of functions
8730 that do not need them now).
8732 (SetExpression): Remove, it is not needed.
8734 (ContextualReturn): Implement CloneTo.
8736 * statement.cs (Statement): Implement cloning infrastructure,
8737 similar to expressions.
8739 (Block): Partial implementation of Clone for statements.
8741 (Return): Implement clone.
8743 * constant.cs (Constant.CloneTo): New method, does nothing.
8745 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8746 solution, until we decide how to exactly do this.
8748 2007-02-14 Marek Safar <marek.safar@gmail.com>
8750 A fix for bug #80493
8751 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8752 a property is override we need to use second accessor.
8754 2007-02-13 Marek Safar <marek.safar@gmail.com>
8756 A fix for bug #80418
8757 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8760 2007-02-13 Marek Safar <marek.safar@gmail.com>
8762 Another fix for bug #80749
8763 * pending.cs: Abstract class has priority over interfaces.
8765 2007-02-13 Marek Safar <marek.safar@gmail.com>
8767 Another fix for bug #80749
8768 * pending.cs: Abstract class has priority over interfaces.
8770 2007-02-13 Marek Safar <marek.safar@gmail.com>
8772 Another fix for bug #80749
8773 * pending.cs: Abstract class has priority over interfaces.
8775 2007-02-13 Marek Safar <marek.safar@gmail.com>
8777 Another fix for bug #80749
8778 * pending.cs: Abstract class has priority over interfaces.
8780 2007-02-13 Marek Safar <marek.safar@gmail.com>
8782 * class.cs Better error message.
8784 * driver.cs: Add shorter versions of -optimize option.
8786 2007-02-13 Martin Baulig <martin@ximian.com>
8788 * class.cs (Constructor.Emit): Check the return value of
8789 ec.ResolveTopBlock() and return on error.
8791 2007-02-13 Raja R Harinath <rharinath@novell.com>
8793 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8794 message to fix error message regression.
8796 2007-02-12 Marek Safar <marek.safar@gmail.com>
8798 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8800 2007-02-12 Marek Safar <marek.safar@gmail.com>
8802 A fix for bug #80749
8803 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8804 its parent container.
8806 * class.cs (DefineFieldInitializers): Each initializer can has different
8809 * const.cs: Updated.
8811 2007-02-11 Miguel de Icaza <miguel@novell.com>
8813 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8814 now all the heavy lifting to check that embedded statements or
8815 expressions have the right form is done in the ContextualReturn.
8817 (ContextualReturn): New class.
8819 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8820 method that can be invoked to report 201, so we do not replicate
8823 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8825 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8826 treating tabs as spaces.
8828 2007-02-09 Marek Safar <marek.safar@gmail.com>
8830 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8831 * assign.cs: Use full implicit conversion for right side check.
8833 2007-02-09 Marek Safar <marek.safar@gmail.com>
8835 * statement.cs (Switch): Switch over boolean type is not standardized.
8837 2007-02-08 Marek Safar <marek.safar@gmail.com>
8839 A fix for bug #80755
8840 * decl.cs (FindBaseEvent): Don't use method cache for events.
8842 2007-02-07 Marek Safar <marek.safar@gmail.com>
8844 * cs-parser.jay: Better syntax error handling.
8846 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8847 instead of underlying type value.
8849 2007-02-06 Marek Safar <marek.safar@gmail.com>
8851 * driver.cs: Check define identifier before is registered.
8853 * namespace.cs: Use existing error message.
8855 * report.cs: New warning.
8857 2007-02-06 Marek Safar <marek.safar@gmail.com>
8859 A fix for bug #80742
8860 * expression.cs: Delegate Invoke method can be called directly.
8862 2007-02-06 Marek Safar <marek.safar@gmail.com>
8864 A fix for bug #80676
8865 * class.cs (IsEntryPoint): The Main method can have params modifier.
8867 2007-02-04 Miguel de Icaza <miguel@novell.com>
8869 * parameter.cs (Parameter, Parameters): Add Clone method.
8871 * anonymous.cs (Compatible): Turn method into virtual method, so
8872 LambdaExpression can implement a different behavior.
8874 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8875 out the basic checking here, so it can be used by
8878 * lambda.cs: Introduce "Compatible" function that will do the
8881 2007-02-02 Marek Safar <marek.safar@gmail.com>
8883 * attribute.cs: Unified one error message.
8885 * class.cs (Class): Use type attributes and not properties to test static
8887 (IsEntryPoint): Don's pass local variable.
8889 * convert.cs: Removed duplicate check.
8891 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8893 * driver.cs: Don't crash when soft reference does not exist.
8895 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8896 (UsingEntry): Removed redundant allocation.
8898 * parameter.cs: Add fast path for type parameters.
8900 * support.cs: Don't allocate attribute when it's not used.
8902 2007-01-30 Miguel de Icaza <miguel@novell.com>
8905 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8906 this into a virtual method, so we can override it in LambdaExpression.
8908 * driver.cs: Improve diagnostics in case of failure.
8910 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8911 write a function that is slightly more complex and that parses:
8913 type identifier [, type identifier]* )
8915 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8918 (canEmpty ? i >= 0 : i > 0)
8920 2007-01-30 Raja R Harinath <rharinath@novell.com>
8922 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8923 exception on possibly valid code.
8925 2007-01-29 Raja R Harinath <rharinath@novell.com>
8927 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8929 (parse_opt_type_arguments): Remove. It's almost the same as
8931 (parse_namespace_or_typename): Use parse_less_than.
8933 2007-01-28 Miguel de Icaza <miguel@novell.com>
8935 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8936 this bug took a few hours to find, because the state saved and
8937 restored by PushPosition and PopPosition was ignoring the state of
8938 parse_generic_less_than.
8940 I can also now remove the handling of OP_LT and OP_GT, this solves
8943 * cs-tokenizer.cs: store the location for the ARROW token, we use
8946 (PushPosition, PopPosition): save/restore also `current_token',
8947 restore `parse_generic_less_than' (was missing).
8949 (parse_opt_type_arguments): use parse_type, not
8950 parse_namespace_or_typename to parse types.
8952 * lambda.cs: Empty new file, will eventually have the lambda
8953 expression implementation.
8955 * lambda.test: used to test the internal tokenizer.
8957 * report.cs (FeatureIsNotISO1): Rename from
8958 FeatureIsNotStandardized, because it was about the language level
8959 (1 vs 2) it was not about standarization.
8961 (FeatureRequiresLINQ): New.
8963 * support.cs (SeekableStreamReader): Only require that the reader
8964 is a TextReader, not a StreamReader, so we can plug StringReader.
8966 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8967 given position in the input stream the following tokens can be
8968 parsed as a type followed by an identifier.
8970 (is_punct): after a '(' if parse_type_and_parameter returns true,
8971 then return a special token OPEN_PARENS_LAMBDA which is used to
8972 avoid reduce/reduce errors in the grammar for the
8973 lambda_expression rules.
8975 (parse_type): implement a type parser inside the
8976 tokenizer, the parser only returns true or false depending on
8977 whether the input at a given position can be parsed as a type.
8979 (peek_token): new method used during type parsing.
8981 2007-01-28 Raja R Harinath <rharinath@novell.com>
8984 * anonymous.cs (ScopeInfo.InflateParameters): New.
8985 (AnonymousContainer.Resolve): Use it to redirect types of
8986 delegate parameters.
8988 2007-01-27 Raja R Harinath <rharinath@novell.com>
8991 * expression.cs (Error_InvalidArguments): Don't use two different
8992 messages for CS1503. Use ExtraInformation and
8993 SymbolRelatedToPreviousError instead.
8996 * decl.cs (DeclSpace.initialize_type_params): Don't access
8997 'type_params' of a partial class directly.
8999 2007-01-26 Miguel de Icaza <miguel@novell.com>
9001 * constant.cs: Removed a handful of out-of-range checks that were
9004 2007-01-25 Marek Safar <marek.safar@gmail.com>
9006 * expression.cs (CheckUselessComparison): Add additional check for char
9009 * namespace.cs: Fixed typo.
9011 2007-01-23 Miguel de Icaza <miguel@novell.com>
9013 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
9014 gone, instead we inline the test, preventing the needless casts to
9015 longs, ulongs and doubles for the parameters, avoiding calls to
9016 methods that overchecked stuff, and instead inlined things
9019 2007-01-20 Marek Safar <marek.safar@gmail.com>
9021 * cs-parser.jay: Better parameter error handling.
9023 2007-01-17 Marek Safar <marek.safar@gmail.com>
9025 A fix for bug #80368, #80522
9026 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
9027 whether array initializer contains constants only.
9028 (ArrayCreation.Emit): Use better formula to decide when
9029 are array initializers for static initialization.
9030 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
9031 have to emit even constants otherwise they are pre-initialized.
9033 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
9034 Raja R Harinath <rharinath@novell.com>
9036 Fix emit order of 'get' vs. 'set'.
9037 * support.cs (Accessors): New.
9038 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
9039 Note the order in which accessors are declared in the source.
9040 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
9041 Refactored from Property.Define and Indexer.Define.
9042 (PropertyBase.DefineAccessors): New helper that calls the above in
9043 appropriate order as noted by the parser.
9044 (Property.Define, Indexer.Define): Update to changes.
9045 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
9047 2007-01-17 Raja R Harinath <rharinath@novell.com>
9049 Fix cs0029-6.cs and gcs0029-2.cs (regression)
9050 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
9051 there's an implicit conversion from the current type to the target
9052 type before converting the underlying constant.
9054 2007-01-16 Marek Safar <marek.safar@gmail.com>
9056 * const.cs (ResolveValue): Updated after constant conversion was made more
9059 * constant.cs (GetAttributableValue): constant to object conversion is
9060 used for attributes only.
9061 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
9062 constant conversions.
9063 (LongConstant.ConvertImplicitly): Ditto.
9065 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
9066 (ImplicitConversionStandard): Handle constant conversion as extra step.
9067 It solves the issue when constant conversion was called indirectly like
9068 inside array initializer and constant folding was skipped.
9070 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
9073 * statement.cs(ImplicitConversionStandard): Updated after constant
9074 conversion was made more generic.
9076 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
9078 * expression.cs (As.DoResolve): Use GenericConstraints instead of
9079 Constraints, solves the problem where the compiler incorrectly
9080 reported that a type parameter was not constrained to a class (Bug
9083 2007-01-14 Marek Habersack <grendello@gmail.com>
9085 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
9087 2007-01-14 Marek Safar <marek.safar@gmail.com>
9089 A fix for bug #80368
9090 * assign.cs (FieldInitializer): New class implements field
9091 initializer statement.
9093 * attribute.cs: Update after FieldMember rename.
9095 * class.cs (PropertyBasedMember): New common class for property based
9097 (InterfaceMemberBase): New base class for all members which can be used as
9098 an interface members.
9099 (MethodCore): Moved really common code to InterfaceMemberBase.
9100 (Method.Define): Equal and GetHasCode detection is relevant for methods
9102 (MethodData.Define): Don't assume that public event implements an
9103 interface automatically.
9104 (MethodData.DefineMethodBuilder): Issue an error even if only extern
9106 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
9107 (FieldMember): Merged with FieldBase.
9108 (EventProperty.AEventPropertyAccessor): New specialization to check whether
9109 event extern modifier can be used.
9110 (EventField.EventFieldAccessor): Moved event field specific code here.
9111 (Event.AllowedModifiers): Even event can be extern.
9112 (Event.FindOutBaseMethod): New override specific to events.
9113 (Indexer.parameters): Reintroduce parameters because base class holds
9114 only properties common data.
9115 (Indexer.CheckForDuplications): Indexers are threated as methods so we
9116 need do extra parameters check.
9118 * const.cs: Update after FieldMember rename.
9120 * decl.cs (MemberCache.FindBaseEvent): New method.
9122 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
9123 to reflect that indexer is now derived from PropertyBased.
9125 * ecore.cs (GetMemberType): Made public.
9126 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
9129 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
9131 * typemanager.cs (CSharpSignature): Correctly print event accessors.
9132 (RegisterEvent): Removed.
9133 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
9134 (GetPrivateFieldOfEvent): Renamed to GetEventField.
9136 2007-01-11 Raja R Harinath <rharinath@novell.com>
9139 * statement.cs (CollectionForeach.TryType): Prefer generic
9140 GetEnumerator over non-generic variant. Fix code to follow comments.
9142 2007-01-09 Raja R Harinath <rharinath@novell.com>
9145 * support.cs (ReflectionParameter): Don't use an invalid index on
9146 the generic parameter data.
9148 2007-01-08 Miguel de Icaza <miguel@novell.com>
9150 * driver.cs: Just add a tiny bit of infrastructure.
9152 2007-01-02 Marek Safar <marek.safar@gmail.com>
9154 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
9155 where field type is struct from current assembly.
9157 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
9160 2007-01-02 Marek Safar <marek.safar@gmail.com>
9162 A fix for bug #80381
9163 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
9166 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
9168 (Namespace.LookupType): Always use core types from corlib when speficied.
9170 * report.cs: A new warning.
9172 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
9173 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
9174 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
9176 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
9177 (InitCoreTypes): Set expression type of object_type and value_type
9178 immediately after lookup.
9180 2007-01-01 Miguel de Icaza <miguel@novell.com>
9182 * cs-tokenizer.cs: Accept Pc class characters (Connector
9183 Punctuation) as valid identifiers. Fixes #78259
9185 * expression.cs (Invocation.DoResolve): Moved the check for the
9186 use of `this' for doing method calls to the Invocation resolution
9187 step, after overload resolution has taken place instead of doing
9188 the check at the low-level `This.DoResolve' level.
9190 The `This.DoResolve'(appens before overload resolution, so it has
9191 no way of knowing if the method that will be called will be
9192 instace or static, triggering an erroneous report for cs0188 (Bug
9195 We now do the check for instance method invocations after we know
9196 what method will be called.
9198 (This.CheckThisUsage): Move the actual use of this structure
9199 checking into its own method and expose it.
9201 * Everywhere that called Error_ValueCannotBeConverted: pass a new
9204 Exceptions: Null.ConvertImplicitly,
9205 Constant.ImplicitConversionRequired as there are too many call
9206 sites for passing the ec.
9208 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
9209 EmitContext, if the value is null, then we do not try to provide
9210 the extra information from the error (If a userdefined conversion
9211 exists, as UserDefinedConversion requires a non null-EmitContext).
9215 2006-12-30 Raja R Harinath <rharinath@novell.com>
9217 * flowanalysis.cs (MyBitVector): Document some invariants.
9218 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
9219 introduced below, and add a couple of others,
9221 2006-12-30 Marek Safar <marek.safar@gmail.com>
9223 * attribute.cs (GetMethodObsoleteAttribute): Uses new
9224 GetPropertyFromAccessor and GetEventFromAccessor.
9226 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
9227 overrides non-obsolete one.
9228 (Indexer.Define): Error message has been moved to the parser.
9230 * cs-parser.jay: Better syntax errors handling.
9232 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9233 when an invocation has no arguments.
9235 * ecore.cs: Removed not used caching.
9237 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9240 * report.cs: Add a new warning.
9242 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9244 * typemanager.cs (enumeration_type): Removed.
9245 (CSharpSignature): Reuses IsSpecialMethod.
9246 (IsEqual): Hack for MS BCL.
9247 (GetPropertyFromAccessor): New method.
9248 (GetEventFromAccessor): New method.
9249 (IsSpecialMethod): Fixed to handle more cases.
9251 2006-12-30 Marek Safar <marek.safar@gmail.com>
9253 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9254 Made white spaces array static.
9256 * ecore.cs (RemoveGenericArity): Optimized.
9258 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9260 (MyBitVector.initialize_vector): Simplified.
9262 2006-12-22 Miguel de Icaza <miguel@novell.com>
9264 * ecore.cs: Am not entirely happy with this hack, but it seems to
9265 address the issue in 80257 (a small test case for
9268 I set the MethodGroupExpr.Type to an internal compiler type
9269 (itself in this case) to force the resolution to take place. Why
9270 it does not take place with a null is beyond me.
9272 2006-12-20 Marek Safar <marek.safar@gmail.com>
9274 A fix for bug #80288
9275 * expression.cs (ResolveOperator): Consider user defined conversion for
9276 logical and operator too.
9277 (EmitBranchable): Optimization for logical and when full constant folding
9278 could not be applied but one operand is constant.
9280 2006-12-19 Marek Safar <marek.safar@gmail.com>
9282 * class.cs (GetClassBases): Write 5 times every day, will never use
9283 FullName for error reporting.
9285 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9287 2006-12-19 Martin Baulig <martin@ximian.com>
9289 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9290 the symbol file info here.
9292 2006-12-18 Marek Safar <marek.safar@gmail.com>
9294 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9295 of `elseif' is taking then following sections are not taking.
9296 Fixes an issue reported on mono mailing list.
9298 2006-12-18 Marek Safar <marek.safar@gmail.com>
9300 A fix for bug #80300
9301 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9302 a caller is not taking.
9304 2006-12-18 Raja R Harinath <rharinath@novell.com>
9306 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9307 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9308 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9309 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9310 * class.cs: Update to changes.
9312 2006-12-17 Marek Safar <marek.safar@gmail.com>
9314 A fix for bug #79934
9315 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9318 * class.cs (ResolveMembers): Register an iterator in current container and
9321 2006-12-16 Raja R Harinath <rharinath@novell.com>
9324 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9325 satisfy a params annotated parameter.
9327 2006-12-16 Marek Safar <marek.safar@gmail.com>
9329 A fix for bug #77014
9330 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9331 paramters correctly and not rely on hacks in Parameters class.
9332 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9334 (Invocation.VerifyArgumentsCompat): Ditto.
9335 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9338 * parameter.cs (HasParams): Don't assume that params is the last one.
9340 * support.cs (ReflectionParameters.ctor): Look for params attribute
9342 (ReflectionParameters.ParameterType): Removed hack when we returned last
9343 parameter for out of range parameters.
9344 (ParameterName, ParameterModifier): Ditto.
9346 2006-12-14 Marek Safar <marek.safar@gmail.com>
9348 A fix for bug #79987
9349 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9350 when assembly is not CLS compliant but type is. I have no idea why is this
9353 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9355 2006-12-13 Miguel de Icaza <miguel@novell.com>
9357 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9358 in struct constructors, they are basically no-ops.
9360 2006-12-12 Marek Safar <marek.safar@gmail.com>
9362 * cs-tokenizer.cs (Position): Save preprocessor status too.
9364 2006-12-12 Marek Safar <marek.safar@gmail.com>
9366 A fix for bug #77794
9367 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9369 2006-12-12 Marek Safar <marek.safar@gmail.com>
9371 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9373 (pp_expr): Report error for an invalid expression.
9374 (handle_preprocessing_directive): Simplified; add more error checking.
9376 2006-12-11 Marek Safar <marek.safar@gmail.com>
9378 A fix for bug #74939
9379 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9380 directives handling.
9382 2006-12-10 Marek Safar <marek.safar@gmail.com>
9384 A fix for bugs #80093, and #75984
9385 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9386 logic, it seems to me as it worked before "by coincidence".
9387 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9388 (cleanup): Enabled endif check.
9390 2006-12-09 Marek Safar <marek.safar@gmail.com>
9392 A fix for bug #80162
9393 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9394 enumerators are never ambiguous.
9396 2006-12-08 Raja R Harinath <rharinath@novell.com>
9399 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9401 2006-12-06 Marek Safar <marek.safar@gmail.com>
9403 A fix for bug #80144
9404 * class.cs (EventProperty.Define): Explicit implementation means
9405 that an even is used.
9407 2006-12-06 Marek Safar <marek.safar@gmail.com>
9409 Fixes the operators implementation (part II)
9411 * cfold.cs (DoConstantNumericPromotions): Renamed to
9412 DoBinaryNumericPromotions and simplified.
9413 (BinaryFold): Couple of conversion fixes; simplified.
9415 * constant.cs, ecore.cs, literal.cs
9416 (ToType): Renamed to ConvertImplicitly.
9417 (Reduce): Renamed to ConvertExplicitly.
9419 * class.cs, convert.cs: Updated.
9421 * expression.cs: TryReduce doesn't throw an exception.
9423 2006-12-01 Marek Safar <marek.safar@gmail.com>
9425 A fix for bug #80108
9426 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9429 2006-11-30 Marek Safar <marek.safar@gmail.com>
9431 Fixes unary operators implementation (part I)
9434 * cfold.cs (Error_CompileTimeOverflow): Made internal
9436 * const.cs (IConstant): Changed to use reference to constant and
9437 not constant itself.
9438 Updated IConstant implementations.
9440 * constant.cs (CreateConstant): New factory method.
9441 Updated IConstant implementation.
9443 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9445 * ecore.cs: Updated to use CreateConstantReference.
9447 * enum.cs: Reflects IConstant changes.
9449 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9451 * literal.cs (NullConstant): Change to be independently usable.
9453 2006-11-29 Martin Baulig <martin@ximian.com>
9455 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9456 we need to emit the scope initializer before calling the base .ctor.
9458 * anonymous.cs: Merged back from the new anonymous methods branch.
9459 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9461 * expression.cs (ParameterReference.DoResolveBase): Create a
9462 "normal" ScopeInfo when capturing parameters rather than using the
9463 root scope; this makes things work with anonymous methods having
9467 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9469 2006-11-22 Marek Safar <marek.safar@gmail.com>
9471 A fix for bug #79987
9472 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9473 check to a base class.
9474 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9475 only when assembly has missing attribute.
9476 * report.cs: Update.
9478 2006-11-21 Marek Safar <marek.safar@gmail.com>
9480 * cs-tokenizer.cs: Merged with gmcs version.
9482 2006-11-20 Marek Safar <marek.safar@gmail.com>
9485 * cs-parser.jay: Better error message when partial keyword is misplaced.
9487 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9489 A fix for bug #79810
9490 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9491 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9492 a RuntimeWrappedException by default.
9494 2006-11-18 Marek Safar <marek.safar@gmail.com>
9496 A fix for bug #79843
9497 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9499 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9501 2006-11-18 Marek Safar <marek.safar@gmail.com>
9503 * driver.cs, namespace.cs: Uses faster IndexOf version.
9505 2006-11-17 Marek Safar <marek.safar@gmail.com>
9507 A fix for bug #79941
9508 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9510 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9511 even if internal name is different.
9512 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9513 (UserDefinedConversion): Simplified as the operators cannot be internal.
9514 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9516 (MethodLookup): Replaced EmitContext with parentType.
9517 * expression.cs: Updated.
9519 2006-11-09 Raja R Harinath <rharinath@novell.com>
9521 * driver.cs (BadAssembly): Handle all the ugliness of
9522 DefineDynamicAssembly.
9524 2006-11-08 Raja R Harinath <rharinath@novell.com>
9526 Address parts of #58244 -- most of what's left is in the runtime
9527 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9528 CS1509 error checks, and handle them for all assembly loads, not
9529 just the first invocation.
9530 (LoadModule): Likewise. Move handling of 'adder_method' ...
9531 * codegen.cs (AssemblyClass.AddModule): ... here.
9533 2006-11-02 Marek Safar <marek.safar@gmail.com>
9535 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9536 IEnumerable<T> is ambiguous.
9538 2006-10-31 Marek Safar <marek.safar@gmail.com>
9540 A fix for bug #67689
9541 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9542 GetEnumerator is ambiguous.
9544 * report.cs: Add new warning.
9546 2006-10-29 Marek Safar <marek.safar@gmail.com>
9548 A fix for bug #78602
9549 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9550 to protected member can be nested type.
9552 2006-10-28 Marek Safar <marek.safar@gmail.com>
9554 A fix for bug #78965
9555 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9556 to protected member must derive from current type.
9558 2006-10-27 Marek Safar <marek.safar@gmail.com>
9560 assign.cs: Reuses error method.
9562 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9563 instead of type for constants.
9564 (Expression.Error_ValueAssignment): Common error method.
9566 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9569 2006-10-27 Marek Safar <marek.safar@gmail.com>
9571 A fix for bug #79081
9572 * expression.cs (MemberAccess.DoResolve): Check nested type
9575 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9577 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9579 2006-10-26 Marek Safar <marek.safar@gmail.com>
9581 A fix for bug #76591
9582 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9584 2006-10-26 Marek Safar <marek.safar@gmail.com>
9586 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9587 type forwarder of the same type multiple times.
9589 2006-10-26 Raja R Harinath <rharinath@novell.com>
9592 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9593 instance as an rvalue, even when we later resolve as an lvalue.
9595 2006-10-25 Martin Baulig <martin@ximian.com>
9597 * anonymous.cs: Fix #79673.
9599 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9601 A fix for bug #79666
9602 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9603 ignored when is optimized (= default value) as its value is already set.
9605 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9607 A fix for bug #79724
9608 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9609 TypeContainer for type lookup.
9611 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9613 A fix for bug #79231
9614 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9615 * expression.cs (OverloadResolve): Always convert type name for
9617 (ResolveNamespaceOrType): Don't confuse a nested type with any
9620 2006-10-18 Martin Baulig <martin@ximian.com>
9622 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9624 2006-10-17 Miguel de Icaza <miguel@novell.com>
9626 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9627 an int32, but requesting an int64 from the conversion
9629 2006-10-12 Martin Baulig <martin@ximian.com>
9632 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9634 2006-10-12 Martin Baulig <martin@ximian.com>
9637 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9639 2006-10-11 Miguel de Icaza <miguel@novell.com>
9641 * convert.cs: Remove broken code: I was doing the "Existance"
9642 tests for Implicit conversions.
9644 2006-10-10 Miguel de Icaza <miguel@novell.com>
9646 * convert.cs: Added one missing case in
9647 ImplicitStandardConversionExists uint64 to intptr.
9651 * typemanager.cs (uintptr_type): another core known type.
9653 * ecore.cs (OperatorCast): routine used to do cast operations that
9654 depend on op_Explicit. We could change some of the Decimal
9655 conversions to use this.
9657 This one has a probe mechanism that checks both types for an op_
9658 which it coudl be used to eliminate two classes: CastToDecimal
9659 and CastFromDecimal.
9661 * convert.cs: Implement the conversions documented in #59800
9663 2006-10-10 Martin Baulig <martin@ximian.com>
9665 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9666 before RootScope.ResolveMembers().
9668 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9669 `CurrentType' if appropriate.
9671 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9673 A fix for bug #78568
9674 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9675 when contains binary operators.
9676 * cs-parser.jay: Updated.
9678 2006-10-09 Martin Baulig <martin@ximian.com>
9681 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9682 moved that into Define() and also do the other type parameter
9683 checks there. Fixes #79094. Added gtest-292.cs.
9686 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9687 since that doesn't include type parameters; don't use `Ldelema'
9688 for type parameters. Fixes #78980. Added gtest-293.cs.
9690 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9693 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9694 conversion is allowed.
9696 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9698 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9699 error reporting when no error occurs.
9701 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9703 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9706 2006-10-06 Raja R Harinath <rharinath@novell.com>
9709 * class.cs (DefineTypeBuilder): Check circular dependencies before
9710 setting the parent of the TypeBuilder.
9711 (CheckRecursiveDefinition): Don't use 'BaseType', since
9712 it may not be valid until after DefineTypeBuilder. Use
9713 'base_type' instead.
9715 2006-10-04 Martin Baulig <martin@ximian.com>
9717 Merged the Anonymous Methods patch.
9719 * anonymous.cs, iterators.cs: The new anonymous methods code.
9721 * statement.cs (Variable): New public abstract class.
9722 (LocalInfo.Variable): New public property.
9723 (LocalInfo.ResolveVariable): New public method.
9724 (Block.Flags): Add `IsIterator'.
9725 (Block.AddVariable): Improved the CS0136 check.
9726 (Block.AnonymousChildren): New public property.
9727 (Block.AddAnonymousChild): New public method.
9728 (ToplevelBlock): Update to use the new anonymous method framework.
9729 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9730 `ToplevelBlock'; this is required to correctly implement the
9732 (Fixed, Using): Use `TemporaryVariable' instead of directly
9733 creating the `LocalBuilder'.
9735 * parameter.cs (Parameter.ResolveVariable): New public method.
9736 (Parameters.ResolveVariable): Likewise.
9738 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9740 * class.cs (TypeContainer): Replaced the `iterators' list and
9741 corresponding methods with a list of `CompilerGeneratedClass'es.
9742 (TypeContainer.ResolveMembers): New public method.
9743 (Method): `IIteratorContainer' has been replaced by
9746 * expression.cs (VariableReference): New public abstract base
9747 class for `LocalVariableReference', `ParameterReference' and
9750 * codegen.cs (EmitContext): Removed `capture_context',
9751 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9752 (EmitContext.EmitThis): Removed.
9754 * cs-parser.jay: Replace `iterator_container' with
9757 2006-10-04 Martin Baulig <martin@ximian.com>
9759 * generic.cs (GenericMethod): Don't make this abstract.
9760 (Constraints.Clone): Added dummy implementation.
9762 2006-10-04 Raja R Harinath <harinath@gmail.com>
9765 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9766 'declspaces'. Avoid allocating arrays willy-nilly.
9769 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9770 cases out of the switch.
9772 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9774 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9775 message when non-generic type is used with the type arguments.
9776 * expression.cs: Updated.
9778 2006-09-28 Raja R Harinath <rharinath@novell.com>
9781 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9782 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9783 Change semantics slightly. Don't insist on having only one
9784 temporary EmptyExpression -- just throttle the creation of new ones.
9787 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9788 non-interfaces too. If no methods are found, don't try to create
9791 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9793 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9796 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9797 us produce better error message.
9799 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9801 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9802 of the `|' operator.
9804 * report.cs: A new warning added.
9806 2006-09-27 Martin Baulig <martin@ximian.com>
9808 * generic.cs (GenericMethod): Don't make this abstract.
9810 2006-09-27 Martin Baulig <martin@ximian.com>
9813 (InternalErrorException): Added overloaded ctor taking a params array.
9815 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9817 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9818 Fixed the cases when same error was reported twice.
9820 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9821 now report symbol information.
9823 2006-09-25 Martin Baulig <martin@ximian.com>
9825 * class.cs: Completely unified with the gmcs version.
9827 2006-09-25 Martin Baulig <martin@ximian.com>
9829 * typemanager.cs (TypeManager.IsNullableType): New public function.
9830 (TypeManager.IsNullableTypeOf): Likewise.
9831 (TypeManager.IsNullableValueType): Likewise.
9833 * class.cs (MethodCore): Added the `GenericMethod' argument from
9834 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9836 2006-09-24 Raja R Harinath <harinath@gmail.com>
9838 * convert.cs: Unify with gmcs version.
9840 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9842 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9843 verify them as well.
9845 * report.cs: New warning.
9847 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9849 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9850 for anonymous block with out argument.
9852 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9854 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9855 not used private events only.
9857 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9859 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9861 * const.cs (Const.Define): Check for constant type.
9862 (Const.IsConstantTypeValid): Looks for valid constant types.
9864 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9866 * ecore.cs (EmptyConstantCast): New common class for all constant based
9869 * expression.cs (Is.DoResolve): Handle null constant especially.
9870 (New.DoResolve): Check for new void().
9871 (MemberAccess.DoResolve): Cope with all kind of nulls.
9873 * literal.cs (NullConstant): Uses EmptyConstantCast.
9874 (NullDefault): Based on EmptyConstantCast.
9875 (NullLiteral): Uses EmptyConstantCast.
9877 * statement.cs (Block.ResolveMeta): Check for constant type.
9879 2006-09-22 Martin Baulig <martin@ximian.com>
9881 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9883 2006-09-22 Raja R Harinath <rharinath@novell.com>
9885 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9889 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9890 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9893 2006-09-22 Martin Baulig <martin@ximian.com>
9895 * ecore.cs: Merged with the gmcs version.
9897 * generic.cs (ConstructedType): New dummy class.
9898 (TypeArguments): Don't make this abstract.
9901 (TypeManager.IsGenericTypeDefinition): New method.
9902 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9904 2006-09-22 Raja R Harinath <rharinath@novell.com>
9906 * expression.cs (ComposedCast): Check for arrays of TypedReference
9907 before creating the type, not after.
9909 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9911 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9912 after ToType change.
9914 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9915 when constant must be implicitly convertible.
9917 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9919 * ecore.cs (NullCast): Derives from NullConstant.
9921 * expression.cs (Is.DoResolve): Removed useless variables.
9922 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9923 (New.Constantify): Add enum support.
9924 (MemberAccess.DoResolve): Add warning when accessing null constant or
9927 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9930 * literal.cs (NullConstant): New abstract class with common
9931 functionality for all null specializations.
9932 (NullDefault): Represents default(X) when result can be
9934 (NullLiteral): Updated.
9936 * report.cs: Add new warning.
9938 2006-09-21 Martin Baulig <martin@ximian.com>
9940 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9942 2006-09-21 Martin Baulig <martin@ximian.com>
9944 * generic.cs (GenericConstraints): New dummy class.
9945 (Constraints): Likewise.
9946 (TypeParameter): Likewise.
9947 (TypeParameterName): Likewise.
9948 (GenericMethod): Likewise.
9950 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9952 * decl.cs: Merged with the gmcs version.
9954 2006-09-21 Raja R Harinath <rharinath@novell.com>
9956 * generic.cs (TypeParameter): Implement IMemberContainer.
9957 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9959 * rootcontext.cs: Unify with gmcs version.
9961 * report.cs: Unify with gmcs version.
9962 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9963 from gmcs/generics.cs.
9964 * generics.cs (TypeParameter): New dummy class.
9966 * support.cs: Unify with gmcs version.
9968 2006-09-20 Raja R Harinath <rharinath@novell.com>
9970 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9971 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9973 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9974 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9975 * mcs.exe.sources: Add generic.cs.
9977 * codegen.cs: Unify with gmcs version.
9979 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9980 (EmitContext): Add GenericDeclContainer implementation.
9981 * decl.cs (MemberCore, DeclSpace): Likewise.
9982 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9984 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9985 MCS TypeManager has a corresponding dummy method.
9987 2006-09-19 Martin Baulig <martin@ximian.com>
9989 * expression.cs: Completely merged with the gmcs version.
9991 2006-09-19 Martin Baulig <martin@ximian.com>
9993 * expression.cs (Invocation): Merged with the gmcs version.
9994 (ArrayAccess.GetStoreOpcode): Likewise.
9996 2006-09-19 Martin Baulig <martin@ximian.com>
9999 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
10000 (TypeManager.IsGenericMethodDefinition): Likewise.
10002 2006-09-19 Martin Baulig <martin@ximian.com>
10005 (TypeManager.IsEqual): Moved the gmcs implementation here.
10006 (TypeManager.DropGenericTypeArguments): Likewise.
10007 (TypeManager.DropGenericMethodArguments): Likewise.
10008 (TypeManager.GetTypeArguments): Moved here from gmcs.
10009 (TypeManager.HasGenericArguments): Likewise.
10011 2006-09-19 Martin Baulig <martin@ximian.com>
10013 * expression.cs (Binary): Merged with the gmcs version.
10015 2006-09-19 Martin Baulig <martin@ximian.com>
10017 * expression.cs (Probe, As, Is): Merged with the gmcs version.
10019 2006-09-19 Martin Baulig <martin@ximian.com>
10021 * typemanager.cs: Merged with the gmcs version.
10023 2006-09-16 Raja R Harinath <rharinath@novell.com>
10025 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
10026 * driver.cs: Likewise.
10028 2006-09-16 Marek Safar <marek.safar@seznam.cz>
10031 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
10032 only if parent type is class.
10033 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
10036 2006-09-15 Marek Safar <marek.safar@seznam.cz>
10039 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
10041 * typemanager.cs(CSharpName): Converts NullType to null.
10043 2006-09-15 Martin Baulig <martin@ximian.com>
10046 (TypeManager.GetMethodName): Added mcs implementation.
10047 (TypeManager.IsEqual): Likewise.
10050 (SimpleName.RemoveGenericArity): Added dummy implementation.
10052 * pending.cs: Merged with the gmcs version.
10054 2006-09-15 Martin Baulig <martin@ximian.com>
10056 * statement.cs: Merge with the gmcs version.
10058 2006-09-15 Martin Baulig <martin@ximian.com>
10060 * statement.cs (Switch): Merge with the gmcs implementation
10061 (without nullables), which is newer.
10063 2006-09-15 Martin Baulig <martin@ximian.com>
10065 * statement.cs (Block.Variables): Make this public.
10066 (ToplevelBlock.Parameters): Make this a property.
10067 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
10069 2006-09-15 Martin Baulig <martin@ximian.com>
10071 * namespace.cs: Merge with the gmcs version.
10073 2006-09-15 Martin Baulig <martin@ximian.com>
10075 * decl.cs (MemberName): Minor code cleanups.
10077 2006-09-15 Martin Baulig <martin@ximian.com>
10079 * parameter.cs: Merge with the gmcs version.
10081 2006-09-15 Martin Baulig <martin@ximian.com>
10083 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
10084 and an error in mcs.
10086 2006-09-15 Martin Baulig <martin@ximian.com>
10088 * flowanalysis.cs: Merged from GMCS; added the generics code into
10089 a `GMCS_SOURCE' conditional so we can share this file.
10091 2006-09-08 Martin Baulig <martin@ximian.com>
10093 * typemanager.cs (TypeManager.interlocked_type): New public field.
10094 (TypeManager.int_interlocked_compare-exchange): New public field.
10095 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
10096 enumerator types here and call InitGenericCoreTypes().
10097 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
10098 after calling InitEnumUnderlyingTypes().
10101 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
10102 `classes_second_stage'.
10104 2006-09-14 Marek Safar <marek.safar@seznam.cz>
10106 * assign.cs, ecore.cs, expression.cs: Share error message text.
10107 * class.cs (FieldMember.Define): Check for varible of static type.
10108 * driver.cs (LoadAssembly): Uses error output for errors.
10109 * statement.cs: Updated.
10111 2006-09-08 Marek Safar <marek.safar@seznam.cz>
10113 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
10116 2006-09-07 Martin Baulig <martin@ximian.com>
10119 (MainDriver): Revert r62663 from Marek; see #70506 for details.
10121 2006-08-29 Miguel de Icaza <miguel@novell.com>
10123 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
10125 2006-08-17 Miguel de Icaza <miguel@novell.com>
10127 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
10128 #52019 and #79064, the use of the \uXXXX sequence in source code
10129 to represent unicode characters.
10131 2006-08-15 Marek Safar <marek.safar@seznam.cz>
10133 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
10135 * class.cs, ecore.cs, statement.cs: Merged to one error message.
10137 2006-08-13 Miguel de Icaza <miguel@novell.com>
10139 * assign.cs: Catch attempts to assign to a method groups in += and
10142 2006-08-13 Marek Safar <marek.safar@seznam.cz>
10145 * cs-parser.jay: Don't destroy current array type by typeof of array's.
10147 2006-08-12 Marek Safar <marek.safar@seznam.cz>
10149 * class.cs (Method.Define): Issue a warning when generic method looks like
10151 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
10154 2006-08-09 Marek Safar <marek.safar@seznam.cz>
10156 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
10158 * decl.cs (MemberCache.FindMembers): When container is interface we need to
10159 search all base interfaces as a member can be ambiguous.
10160 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
10161 Constructor member type filter.
10162 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
10163 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
10164 reporting for returned memberinfos.
10165 * report.cs: Updated.
10166 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
10167 version to work on all runtimes.
10168 (TypeManager.RealMemberLookup): Removed members filtering.
10170 2006-08-08 Raja R Harinath <rharinath@novell.com>
10172 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
10173 (PropertyExpr.EmitAssign): Likewise.
10174 * expression.cs (Indirection.EmitAssign): Likewise.
10175 (LocalVariableReference.EmitAssign): Likewise.
10176 (ParameterReference.EmitAssign): Likewise.
10177 (Invocation.EmitArguments): Likewise.
10178 (ArrayAccess.EmitAssign): Likewise.
10179 (IndexerAccess.EmitAssign): Likewise.
10180 (This.EmitAssign): Likewise.
10181 (ConditionalLogicalOperator.Emit): Likewise.
10184 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
10185 instead of ArrayList. If the hashtable has a LocalBuilder, don't
10186 leave it in after returning it.
10187 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
10189 2006-08-06 Marek Safar <marek.safar@seznam.cz>
10191 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
10194 2006-08-03 Raja R Harinath <rharinath@novell.com>
10196 Fix cs0146-3.cs and cs0146-4.cs.
10197 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
10198 enclosing types don't depend on the current type.
10200 2006-08-02 Raja R Harinath <rharinath@novell.com>
10203 * class.cs (TypeContainer.DoDefineMembers): Use
10204 FindBaseMemberWithSameName on Parent, since we're interested in
10205 whether we hide inherited members or not.
10206 (FindBaseMemberWithSameName): Make slightly more robust.
10208 Fix the non-generic testcase from #77396
10209 * decl.cs (DeclSpace.DeclContainer): Remove override.
10211 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
10212 declspaces for doppelgangers too.
10213 (UsingEntry): Implement IResolveContext.
10214 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
10215 'this' as the resolve context.
10216 (LocalAliasEntry): Likewise.
10218 Implement parts of #77403
10219 * roottypes.cs (RootDeclSpace): New. Used to represent the
10220 toplevel declaration space. Each namespace declaration introduces
10221 a "partial" root declaretion space.
10222 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
10223 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
10224 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
10225 from 'current_namespace.SlaveDeclSpace'.
10226 (namespace_declaration): Likewise.
10227 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10228 check. It can't happen now.
10229 * decl.cs (DeclSpace.LookupType): Likewise.
10230 * driver.cs (MainDriver): Sanity check.
10232 2006-08-01 Raja R Harinath <rharinath@novell.com>
10234 * decl.cs (DeclSpace.FindNestedType): Remove.
10235 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10236 LookupTypeContainer to get the container of the nested type.
10237 * class.cs (TypeContainer.FindNestedType): Make non-override.
10239 2006-07-31 Raja R Harinath <rharinath@novell.com>
10241 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10242 * class.cs (TypeContainer.PartialContainer): ... here.
10243 (TypeContainer.AddBasesForPart): New helper.
10244 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10246 * cs-parser.jay (current_class): Convert to DeclSpace.
10247 (struct_declaration, interface_declaration, class_declaration):
10248 Use AddBasesForPart instead of .Bases directly.
10249 * const.cs, iterators.cs: Update to changes.
10251 2006-07-28 Raja R Harinath <rharinath@novell.com>
10253 * class.cs (TypeContainer.AddMemberType): Rename from
10254 AddToTypeContainer.
10255 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10256 (AddTypeContainer): New. Combine AddClassOrStruct and
10258 (AddPartial): Update. Add 'is_partial' argument.
10259 * roottypes.cs: Update to changes.
10260 * cs-parser.jay (push_current_class): New helper for handling
10261 current_container and current_class.
10262 (struct_declaration, interface_declaration, class_declaration):
10265 2006-07-26 Raja R Harinath <rharinath@novell.com>
10267 * roottypes.cs: Rename from tree.cs.
10269 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10270 * tree.cs (Tree, ITreeDump): Remove types.
10271 * rootcontext.cs (tree, Tree): Remove fields.
10272 (root, ToplevelTypes): New.
10273 * *.cs: Update to rename.
10275 * tree.cs (Tree.RecordDecl): Remove.
10276 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10278 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10280 2006-07-23 Raja R Harinath <harinath@gmail.com>
10282 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10283 DoFlowAnalysis and OmitStructFlowAnalysis here.
10284 (ec.With): Rename from WithUnsafe and generalize.
10285 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10286 (ec.WithFlowAnalyis): New.
10287 * ecore.cs, expression.cs, statement.cs: Update.
10289 2006-07-22 Raja R Harinath <harinath@gmail.com>
10291 * statement.cs (Block.ResolveMeta): Simplify slightly.
10293 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10294 multiple boolean fields. Convert InUnsafe, constant_check_state,
10295 check_state to flags.
10296 (CheckState, ConstantCheckState): Update.
10297 (InUnsafe): New read-only property.
10298 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10300 (WithUnsafe): New helper similar to WithCheckState.
10301 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10302 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10304 2006-07-21 Raja R Harinath <rharinath@novell.com>
10306 Make comparisons use the same IL irrespective of whether they're
10307 in a 'checked' or 'unchecked' context: one of the issues in #78899
10308 * codegen.cs (EmitContext.CheckState): Make read-only property.
10309 (EmitContext.ConstantCheckState): Likewise.
10310 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10311 helper that implement a save/restore stack for CheckState
10312 values. This is the only way to change check-state.
10313 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10314 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10315 (CheckedExpr.EmitBranchable): New forwarding method.
10316 (UnCheckedExpr): Likewise.
10317 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10318 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10319 (Checked.Resolve, checked.DoEmit): Likewise.
10321 2006-07-20 Miguel de Icaza <miguel@novell.com>
10323 * anonymous.cs: Cache the resolved anonymous delegate, and return
10324 this so that the ResolveTopBlock is only triggered once, not
10327 Currently we trigger ResolvetopBlock twice due to a first pass of
10328 argument check compatibility, and a second pass that does the
10331 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10333 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10335 * rootcontext.cs (Reset): Add helper_classes.
10337 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10340 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10343 2006-07-13 Miguel de Icaza <miguel@novell.com>
10345 * statement.cs (Lock): Handle expressions of type
10346 TypeManager.null_type specially. Fixes #78770
10348 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10350 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10353 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10355 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10356 for accessors as well.
10357 * ecore.cs (EventExpr): Add AccessorTable.
10359 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10362 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10363 for CS0122 where appropriate.
10364 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10366 (Filter): Assembly can be null in the case of top level attributes.
10368 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10372 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10373 is done at global level.
10375 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10377 A fix for #77002, Implemented TypeForwarder support.
10379 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10380 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10381 * typemanager.cs (): Add type_forwarder_attr_type.
10383 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10385 * report.cs: Add CS0469 warning.
10387 2006-06-21 Martin Baulig <martin@ximian.com>
10389 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10390 the `try'-block, so we also report CS0016 etc. there.
10392 2006-06-21 Martin Baulig <martin@ximian.com>
10395 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10397 2006-06-21 Martin Baulig <martin@ximian.com>
10399 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10400 also report CS1686 for parameters.
10402 2006-06-21 Martin Baulig <martin@ximian.com>
10404 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10405 instead of an error if the value is not implicitly convertible to
10406 the switch types; fixes #77964.
10408 2006-06-21 Raja R Harinath <rharinath@novell.com>
10411 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10412 FieldBuilder is null.
10415 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10416 'left' and 'right' before error-checking.
10418 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10420 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10422 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10423 (FieldExpr.DoResolve): likewise.
10424 (PropertyExpr.InstanceResolve): likewise.
10425 (EventExpr.InstanceResolve): likewise.
10427 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10429 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10430 attribute applicable tests for attribute argument.
10432 2006-06-02 Raja R Harinath <rharinath@novell.com>
10435 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10436 (Binary.OverloadResolve_PredefinedIntegral): New.
10437 (Binary.OverloadResolve_PredefinedFloating): New.
10438 (Binary.OverloadResolve_PredefinedString): New.
10439 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10440 Follow the standard more closely, and treat numeric promotions in
10441 terms of overload resolution.
10442 (Binary.CheckShiftArguments): Simplify.
10444 2006-06-01 Raja R Harinath <rharinath@novell.com>
10446 * flowanalysis.cs (MyBitVector): Simplify representation.
10447 (MyBitVector.Clone): Avoid allocating BitArray.
10448 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10449 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10450 (*): Update. Change all references to MyBitVector.And and
10451 MyBitVector.Or to &= and |=.
10453 2006-05-29 Raja R Harinath <rharinath@novell.com>
10455 Fix cs0231-[34].cs.
10456 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10457 to param arguments too.
10459 2006-05-26 Miguel de Icaza <miguel@novell.com>
10461 * cs-parser.jay: Catch another parsing form for arglist being
10462 followed by other arguments. Fixes #78313.
10464 2006-05-24 Raja R Harinath <rharinath@novell.com>
10466 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10467 checking of out parameters to ...
10468 (FlowBranchingToplevel.Merge): ... here.
10469 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10470 set, propagate the origin upward, and only complain if there was
10472 (FlowBranchingException.AddContinueOrigin): Likewise.
10473 (FlowBranchingException.AddReturnOrigin): Likewise.
10474 (FlowBranchingException.AddGotoOrigin): Likewise.
10476 2006-05-23 Raja R Harinath <rharinath@novell.com>
10478 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10479 unreachable, skip it.
10480 (FlowBranchingException.Merge): Always propagate jumps, even if
10481 the finally block renders subsequent code unreachable.
10483 2006-05-18 Raja R Harinath <rharinath@novell.com>
10486 * statement.cs (Goto.Resolve): Move responsibility for resolving
10487 'goto' to FlowBranching.AddGotoOrigin.
10488 (Goto.SetResolvedTarget): New. Callback to set the
10489 LabeledStatement that's the target of the goto.
10490 (Goto.DoEmit): Use Leave instead of Br when crossing an
10491 unwind-protect boundary.
10492 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10493 LookupLabel and adjust to new semantics.
10494 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10495 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10496 Goto.SetResolvedTarget to update target.
10497 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10498 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10499 AddBreakOrigin & co. Delay propagation until ...
10500 (FlowBranchingException.Merge): ... this.
10502 * statement.cs (Block.Resolve): Always depend on flow-branching to
10503 determine unreachability. Kill workaround that originally emitted
10504 only one statement after an "unreachable" label (see infloop in
10507 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10508 This is still "wrong", but anything better would probably need a
10509 multi-pass algorithm.
10510 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10511 usage vector. Force current usage vector to be reachable, to
10512 optimistically signify backward jumps.
10513 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10515 (FlowBranchingLabeled.Merge): New. If no backward jump was
10516 detected, return the original salted-away usage vector instead,
10517 updated with appropriate changes. Print unreachable warning if
10519 * statement.cs (Block.Resolve): Don't print unreachable warning on
10520 a labeled statement.
10522 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10524 * driver.cs: Pass filename without path to AssemblyBuilder's
10525 AddResourceFile. Fixes bug #78407.
10527 2006-05-17 Raja R Harinath <rharinath@novell.com>
10529 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10530 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10531 (FlowBranching.MergeChild): Overwrite
10532 reachability information from Labeled branchings too.
10534 2006-05-16 Raja R Harinath <rharinath@novell.com>
10536 * statement.cs (Goto.Resolve): Merge jump origins here ...
10537 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10539 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10540 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10541 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10542 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10544 * statement.cs (Goto.Resolve): ... not here.
10545 (Goto.Emit): Remove CS1632 check.
10547 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10549 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10552 2006-05-11 Raja R Harinath <rharinath@novell.com>
10554 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10555 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10556 (FlowBranchingException.Label): Likewise.
10558 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10560 (MyBitVector.Or): Use it to avoid losing information (Count).
10561 (FlowBranching.MergeOrigins): Likewise.
10563 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10564 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10565 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10566 (UsageVector.ToString): Simplify.
10567 (UsageVector.MergeSiblings): Move here from ...
10568 (FlowBranching.Merge): ... here.
10569 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10572 2006-05-10 Raja R Harinath <rharinath@novell.com>
10574 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10575 null bitvector is treated as all-true.
10577 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10578 (MyBitVector): Rationalize invariants. 'vector != null' implies
10579 that we have our own copy of the bitvector. Otherwise,
10580 'InheritsFrom == null' implies all inherited bits are true.
10582 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10584 * statement.cs (LocalInfo): Add IsConstant.
10585 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10586 local variable for constants.
10588 2006-05-09 Raja R Harinath <rharinath@novell.com>
10590 * flowanalysis.cs (MyBitVector.Empty): New.
10591 (MyBitVector): Don't allow InheritedFrom to be null.
10592 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10593 (UsageVector, FlowBranching): Update to changes.
10595 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10596 recursion. The 'Parent == null' condition isn't sufficient for
10598 (FlowBranching.AddBreakOrigin): Likewise.
10599 (FlowBranching.AddContinueOrigin): Likewise.
10600 (FlowBranching.AddReturnOrigin): Likewise.
10601 (FlowBranching.StealFinallyClauses): Likewise.
10602 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10603 (FlowBranching.CheckOutParameters): Likewise.
10604 (FlowBranchingToplevel): Terminate all the above recursions here.
10605 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10606 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10608 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10610 (FlowBranchingToplevel): New. Empty for now.
10611 (FlowBranching.MergeTopBlock): Update.
10612 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10613 branching for the anonymous delegate.
10614 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10616 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10617 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10618 information at the start of the merge. Reorganize.
10620 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10622 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10624 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10626 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10627 to newly introduced ctor.
10629 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10630 message to one place.
10631 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10634 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10636 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10638 * ecore.cs (Expression.ResolveAsConstant): Updated.
10640 * statement.cs (ResolveMeta): Updated.
10642 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10644 * cs-parser.jay: __arglist cannot be used in initializer.
10646 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10649 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10652 2006-05-05 Raja R Harinath <rharinath@novell.com>
10654 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10655 (LabeledStatement): Add 'name' parameter.
10656 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10657 (Block.AddLabel): Update to changes.
10658 * cs-parser.jay (labeled_statement): Likewise.
10660 * flowanalysis.cs (BranchingType.Labeled): New.
10661 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10662 (FlowBranchingLabeled): New. Does nothing for now, but will
10663 eventually handle 'goto' flows.
10664 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10665 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10666 that's terminated ...
10667 (Block.Resolve): ... here.
10669 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10670 (UsageVector.MergeFinallyOrigins): Likewise.
10671 (FlowBranching.InTryOrCatch): Likewise.
10672 (FlowBranching.AddFinallyVector): Likewise.
10673 (FlowBranchingException): Update to changes.
10676 * statement.cs (Return.Resolve): Move error checking to ...
10677 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10678 (FlowBranchingException): Handle return origins like break and
10680 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10682 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10685 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10688 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10691 * class.cs (MethodData.Define): Do public accessor check only when method
10692 implements an interface.
10694 2006-05-04 Raja R Harinath <rharinath@novell.com>
10696 Remove special handling of 'break'
10697 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10698 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10699 (UsageVector.Break): Remove.
10700 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10702 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10704 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10705 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10707 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10710 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10711 be the interface member.
10713 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10716 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10717 for emitting small (int) values.
10719 2006-05-03 Raja R Harinath <rharinath@novell.com>
10722 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10723 control-flow passes through the 'finally' after merging-in all the
10724 control-flows from 'try' and the 'catch' clauses.
10726 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10727 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10728 always true at the only non-recursive entry point.
10729 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10730 FlowBranchingBreakable.
10731 (FlowBranchingLoop): Remove.
10732 * statement.cs (Return.DoResolve): Update to changes.
10735 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10736 (FlowBranching.CreateBranching): Handle it: create a
10737 FlowBranchingContinuable.
10738 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10739 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10740 except that it handles the 'continue' command.
10741 (FlowBranching.UsageVector.MergeOrigins): Rename from
10743 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10744 except that it overrides AddContinueOrigin.
10745 (FlowBranchingException): Override AddContinueOrigin, similar to
10747 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10748 Create a new branching around the embedded statement.
10749 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10750 control flow after the embedded statement.
10751 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10753 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10754 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10755 FlowBranchingBreakable.
10756 (FlowBranchingSwitch): Remove.
10759 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10760 error reporting to ...
10761 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10762 Rename from 'AddBreakVector'. Add new location argument. Return
10763 a bool indicating whether the 'break' crosses an unwind-protect.
10764 (FlowBranchingException.AddBreakOrigin): Add.
10765 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10766 flowbranching after updating with the effects of the 'finally'
10768 (FlowBranchingBreakable): New common base class for
10769 FlowBranchingLoop and FlowBranchingSwitch.
10771 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10772 embedded statement.
10773 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10775 2006-05-02 Raja R Harinath <rharinath@novell.com>
10777 * statement.cs (Do.Resolve): If the loop is infinite, set the
10779 (While.Resolve, For.Resolve): Set a barrier after the embedded
10780 statement. There's no direct control flow that goes from the end
10781 of the embedded statement to the end of the loop.
10782 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10783 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10784 above ensure that the reachability is correctly computed.
10786 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10787 (UsageVector.MergeBreakOrigins): If the current path is
10788 unreachable, treat it as if all parameters/locals are initialized.
10789 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10790 infinite loops before merging-in break origins.
10792 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10793 (Reachability.Reachable): Split part into ...
10794 (Reachability.Unreachable): ... this. Simplify.
10795 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10797 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10798 (Reachability.SetThrowsSometimes): Likewise.
10799 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10800 TriState.Always, use corresponding property.
10801 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10802 (Block.Resolve): Likewise. Remove some redundant checks.
10804 2006-05-02 Raja R Harinath <harinath@gmail.com>
10806 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10807 (Reachability.Meet): Don't bother checking AlwaysThrows --
10808 barrier is always set.
10809 (FlowBranchingBlock.Merge): Likewise.
10811 2006-05-01 Raja R Harinath <harinath@gmail.com>
10813 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10814 checks for unreachable.
10816 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10819 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10821 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10822 whether field is really assigned.
10824 2006-04-30 Raja R Harinath <harinath@gmail.com>
10826 * flowanalysis.cs (Reachability): Make 4-argument constructor
10828 (Reachability.Meet): Rename from 'And'. Remove static variant.
10829 (Reachability.Always): Rename from the highly misleading
10830 'Reachability.Never'.
10831 (FlowBranching.Merge): Update to changes. Mark an impossible
10832 situation with a 'throw'.
10833 (*): Update to changes.
10835 2006-04-29 Raja R Harinath <harinath@gmail.com>
10837 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10838 Remove 'Undefined'.
10839 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10840 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10841 (*): Update to changes.
10842 * statement.cs: Update to changes.
10844 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10847 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10849 2006-04-28 Raja R Harinath <harinath@gmail.com>
10851 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10854 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10855 argument to two arguments: an usage-vector and a bool. Move call
10856 to FlowBranching.Merge () ...
10857 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10859 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10860 handling of loop and switch reachability to ...
10861 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10863 2006-04-27 Raja R Harinath <harinath@gmail.com>
10865 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10866 handling to FlowBranchingLoop.InLoop.
10867 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10869 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10872 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10873 anonymous method is allowed from AnonymousContainer here.
10875 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10877 2006-04-24 Raja R Harinath <rharinath@novell.com>
10880 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10882 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10885 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10886 (DoubleConstant.Reduce): Ditto.
10888 2006-04-23 Raja R Harinath <rharinath@novell.com>
10890 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10891 Remove 'lvalue_right_side' argument. Move parts to ...
10892 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10893 (LocalVariable.DoResolveLValue): ... these.
10895 2006-04-21 Raja R Harinath <rharinath@novell.com>
10898 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10899 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10900 (LocalVariableReference.DoResolveBase): Use it to implement new
10902 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10903 (Argument.Resolve): Simplify. Move CS1510 check ...
10904 * ecore.cs (Expression.ResolveLValue): ... here.
10905 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10906 (PropertyExpr.DoResolveLValue): Likewise.
10907 (FieldExpr.Report_AssignToReadonly): Likewise.
10908 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10909 LValueMemberAccess or LValueMemberOutAccess on instance depending
10911 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10912 DoResolve as appropriate.
10914 2006-04-20 Raja R Harinath <rharinath@novell.com>
10917 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10918 implicit conversions on 'out' and 'ref' arguments.
10920 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10921 improve clarity. Remove dead code.
10924 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10925 (Catch.Resolve): Resolve VarBlock if it exists.
10927 2006-04-19 Miguel de Icaza <miguel@novell.com>
10929 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10930 twice, this was some residual code, the enumerator was emitted
10931 properly in the two branche of if later.
10933 2006-04-19 Raja R Harinath <rharinath@novell.com>
10935 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10936 cast is never an lvalue.
10937 (Cast.DoResolve, Cast.ResolveRest): Combine.
10938 (Argument.Emit): Simplify slightly. Move 'Expr is
10939 IMemoryLocation' check ...
10940 (Argument.Resolve): ... here.
10941 (Argument.Error_LValueRequired): Remove. Inline into only user.
10943 Simplifications. Fix cs0191-2.cs
10944 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10945 CS1649 and CS1651 to ...
10946 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10947 the actual selection of the error code and message to a lookup
10948 table. Add a dummy return value to simplify callsites.
10949 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10950 readonly fields of other instances of the same type. Move CS0197
10952 * expression.cs (Argument.Resolve): ... here. Simplify code.
10953 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10954 resolution of an out or ref argument. The code simplification
10955 above uses this invariant.
10957 2006-04-18 Raja R Harinath <rharinath@novell.com>
10959 Possibly fix #77752. Fix cs1690-[4-7].cs.
10960 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10961 CheckMarshallByRefAccess. Drop parameter.
10962 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10964 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10965 InstanceExpression.
10966 * report.cs (AllWarnings): Add CS1690.
10967 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10968 for ref access too.
10969 (LocalVariableReference.DoResolveBase): Update.
10971 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10973 * class.cs (MethodOrOperator): Moved common parts from method class.
10974 detect obsolete attributes.
10975 (Method.Define): Simplified as it reuses code from base.
10976 (Constructor.ValidAttributeTargets): Fixed issue found during
10978 (Destructor.ValidAttributeTargets): Fixed issue found during
10980 (Operator): Finished refactoring set off by #78020. Operator class is now
10981 ordinary method class.
10983 * anonymous.cs: Updated.
10985 * decl.cs (DeclSpace): Add IsGeneric
10987 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10989 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10991 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10993 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10994 detect obsolete attributes.
10995 (Method.CreateEmitContext): Moved to MethodOrOperator.
10997 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11000 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
11001 customized exception to make crash detection easier.
11002 (MethodOrOperator): Started to work on new base class for methods and
11004 (Method): Derives from MethodOrOperator.
11005 (Constructor.Emit): Emits its own attributes.
11006 (AbstractPropertyEventMethod.Emit): Ditto.
11007 (Operator): Derives from MethodOrOperator, will refactor fully in extra
11009 (Operator.Emit): It's temporary more tricky than should be.
11011 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
11013 * report.cs (InternalErrorException): Add ctor with inner exception.
11015 2006-04-08 Marek Safar <marek.safar@seznam.cz>
11018 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
11021 2006-04-07 Marek Safar <marek.safar@seznam.cz>
11024 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
11027 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11029 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
11030 attribute is present and Guid not.
11031 (Interface.ApplyAttributeBuilder): Ditto.
11033 * attribute.cs: Add error message.
11035 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11039 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
11040 sources (it's composite) so hold them in extra array as they are used in
11041 Emit phase only. It worked in the previous versions by mistake.
11042 (Attribute.Emit): Emit attribute for more owners when exist.
11044 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
11045 it has now different behaviour.
11047 2006-04-04 Marek Safar <marek.safar@seznam.cz>
11049 * constant.cs (Constant.IsDefaultInitializer): New method.
11051 * class.cs: Updated.
11053 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
11054 re-initialize default values. It saves KBs almost for every assembly.
11055 Thanks Zoltan for the idea.
11056 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
11057 (ArrayCreation.DoResolve): Resolve only once.
11058 (ArrayCreation.Emit): Emit static initializer only when it is faster.
11059 (ArrayCreation.GetAttributableValue): Cope with optimized values.
11061 2006-04-03 Zoltan Varga <vargaz@gmail.com>
11063 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
11066 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11068 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
11069 in an embedded statement too.
11071 2006-04-01 Raja R Harinath <rharinath@novell.com>
11074 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
11076 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11080 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
11083 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
11085 2006-03-31 Marek Safar <marek.safar@seznam.cz>
11087 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
11090 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
11091 LocalTemporary change.
11093 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
11095 (ClassOrStruct.DefineFieldInitializers): Implemented static field
11096 initializers optimization.
11097 (ClassOrStruct.TypeAttr): Moved from modifiers.
11098 (Constructor.CheckBase): Don't crash when static ctor has parameters.
11099 (FieldBase.ResolveInitializer): Resolves initializer.
11100 (FieldBase.HasDefaultInitializer): New property.
11102 * cs-parser.jay: Removed message.
11104 * expression.cs (CompilerGeneratedThis): New specialization.
11106 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
11108 2006-03-28 Marek Safar <marek.safar@seznam.cz>
11110 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
11112 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11114 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
11115 be now EnumConstants only.
11117 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11119 * attribute.cs, driver.cs: Reset more caches.
11121 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11123 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
11125 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11127 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
11128 for easier reuse. Updated all overrides.
11129 (IntegralConstant): New base class for all integral constants.
11130 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
11131 of the constant range, report custom error.
11132 (UIntConstant.Reduce): Fixed uint conversion.
11134 * ecore.cs, literal.cs: Reduce updates.
11136 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11140 * class.cs (Constructor.Define): Removed extra if for default ctors.
11141 A patch from Atsushi Enomoto.
11143 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11145 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
11146 GetAttributableValue.
11148 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
11151 * convert.cs (ImplicitConversionRequired): Error message moved to
11154 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
11155 automatic implicit conversion of an output value.
11156 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
11158 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
11160 (TypeOf.GetAttributableValue): Add extra handling for object type.
11162 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
11163 special error message.
11165 2006-03-25 Marek Safar <marek.safar@seznam.cz>
11167 * class.cs (Constructor.Emit): Don't crash when struct ctor is
11169 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
11170 compatible with MS runtime.
11172 2006-03-23 Marek Safar <marek.safar@seznam.cz>
11174 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
11175 attribute arguments here.
11177 * class.cs (Indexer.Define): The check was moved to attribute class.
11179 2006-03-22 Marek Safar <marek.safar@seznam.cz>
11181 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
11182 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
11185 2006-03-22 Raja R Harinath <rharinath@novell.com>
11187 Support ParameterDefaultValueAttribute in gmcs. Also applied to
11188 mcs to keep code differences small.
11189 * attribute.cs (Attribute.GetParameterDefaultValue): New.
11190 * typemanager.cs (parameter_default_value_attribute_type): New.
11191 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
11194 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11196 * expression.cs (StringConcat.Append): Reverted back to no warning state.
11198 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11200 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
11202 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
11205 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
11207 * doc-bootstrap.cs : fix build.
11209 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11211 * expression.cs (StringConcat.Append): Issue a warning when empty string
11212 is going to append.
11214 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11216 * assign.cs (CompoundAssign.ResolveSource): Removed.
11218 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
11221 * class.cs (TypeContainer.FindMethods): Removed.
11222 (TypeContainer.CheckMemberUsage): Made static.
11224 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
11226 * constant.cs (CheckRange): Removed unused type argument.
11227 (CheckUnsigned): Removed unused type argument.
11229 * cs-parser.jay: Updated after MemberAccess clean up.
11230 Uses Length for empty string test.
11232 * cs-tokenizer.cs: Uses Length for empty string test.
11233 (IsCastToken): Made static.
11234 (is_hex): Made static.
11235 (real_type_suffix): Made static.
11237 * decl.cs (SetupCache): Made static.
11238 (OnGenerateDocComment): Removed unused ds argument.
11240 * delegate.cs (VerifyDelegate): Removed unused argument.
11242 * doc.cs: Uses Length for empty string test.
11244 * driver.cs: Uses Length for empty string test.
11246 * enum.cs (IsValidEnumType): Made static
11248 * expression.cs (EnumLiftUp): Removed unused argument.
11249 (ResolveMethodGroup): Ditto.
11250 (BetterConversion): Ditto.
11251 (GetVarargsTypes): Ditto.
11252 (UpdateIndices): Ditto.
11253 (ValidateInitializers): Ditto.
11254 (MemberAccess.ctor): Ditto.
11255 (GetIndexersForType): Ditto.
11257 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11259 * iterators.cs: Updated after MemberAccess clean up.
11261 * location.cs: Uses Length for empty string test.
11263 * namespace.cs: Uses Length for empty string test.
11265 * report.cs (CheckWarningCode): Made static.
11267 * statement.cs (LabeledStatement): Removed unused argument.
11269 * typemanager.cs (FilterNone): Removed.
11271 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11273 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11276 * class.cs: Updated.
11278 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11280 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11282 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11286 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11287 reporting, it's more tricky than I thought.
11289 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11293 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11295 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11296 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11297 Add more error reporting; Fixed issue with params.
11299 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11301 * cs-parser.jay: AnonymousMethod requires host container.
11303 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11305 2006-03-18 Raja R Harinath <harinath@gmail.com>
11307 * class.cs: Change 'TypeContainer ds' constructor argument to
11308 'DeclSpace parent'. Some classes were missed below due to
11309 different naming convention.
11311 * class.cs (MemberCore.Parent): Delete. This makes the
11312 ParentContainer changes below enforceable by the compiler.
11314 Treat pointers to enclosing declaration space as 'DeclSpace', not
11316 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11317 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11319 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11321 (Block.AddThisVariable): Likewise.
11322 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11323 (AbstractPropertyEventMethod.Emit): Likewise.
11324 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11325 (GetMethod.Define, SetMethod.Define): Likewise.
11326 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11327 (DelegateMethod.EmitMethod): Likewise.
11329 Fix regression test-partial-13.cs.
11330 Rationalize use of PartialContainer. Ensure that the partial
11331 class semantics can be tied to type-correctness, i.e., any
11332 violation will cause a compile error.
11333 * class.cs, const.cs: Access all fields that belong to class
11334 TypeContainer via ParentContainer. Arguments of EmitContexts and
11335 Resolve()-like functions still use 'Parent'.
11337 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11338 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11339 (PropertyMethod.CheckModifiers): Remove unused argument.
11340 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11343 2006-03-17 Raja R Harinath <harinath@gmail.com>
11345 Make semantics of PartialContainer simpler.
11346 * decl.cs (DeclSpace.IsPartial): Remove.
11347 * class.cs (TypeContainer.IsPartial): Likewise.
11348 (TypeContainer..ctor): Set PartialContainer to point to self.
11349 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11350 (TypeContainer.FindNestedType): Likewise.
11351 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11353 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11355 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11357 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11359 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11362 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11364 * class.cs (Operator.Define): An error for base conversion was not
11365 reported correctly.
11367 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11369 * iterator.cs : yield break is allowed in try statement which has
11370 catch clauses. Fixed bug #77767.
11372 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11374 A fix for #77593, #77574.
11376 * class.cs (MethodCore.CheckBase): Another if for operator.
11378 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11380 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11383 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11384 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11387 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11390 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11391 Updated after another emitcontext usage was clean up. It should help us to
11392 synchronize with gmcs easier.
11394 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11398 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11399 (Event.Define): ditto
11400 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11402 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11403 Removed redundant code and set NewSlot for Invoke method too.
11405 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11406 (Parameters.MergeGenerated): New method. Use this method when you merge
11407 compiler generated argument with user arguments.
11409 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11411 * attribute.cs (ResolveAsTypeTerminal): Removed.
11413 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11414 specialization for predefined types; 30% speed up.
11415 Finally placed obsolete check to right place.
11416 (Expression.ResolveType): Removed.
11418 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11419 Updated after ResolveType was removed.
11421 * expression.cs (Cast.ctor): Check void cast.
11422 (Binary.ResolveAsTypeTerminal): Is never type.
11423 (Conditional.ResolveAsTypeTerminal): Is never type.
11425 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11427 2006-03-01 Raja R Harinath <rharinath@novell.com>
11430 * expression.cs (ParameterReference.DoResolveBase): Change return
11432 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11436 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11439 * typemanager.cs (GetFullNameSignature): Don't nullref on
11440 protected accessors.
11442 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11444 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11445 these two separated members to simplify the code.
11446 (Attribute.Resolve): Refactored to use new fields and methods.
11447 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11448 implemented obsolete attribute checking.
11449 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11450 implemented obsolete checking again. It look line never ending quest ;-)
11451 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11453 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11455 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11457 *class.cs (Property.Define): Add RegisterProperty call.
11459 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11460 argument groups (only 2).
11462 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11463 encoding expression to arguments.
11464 (Expression.ExprClassToResolveFlags): Just turned to property.
11466 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11467 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11468 optimized as well as implemented support for zero-length attributes.
11470 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11471 Add caching of PropertyInfo's.
11473 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11475 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11476 error multiple times.
11478 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11480 New partial class implementation.
11481 A fix for #77027, #77029, #77403
11483 * attribute.cs (Attributable): Made attributes protected.
11485 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11486 the replacements of ClassPart and PartialContainer.
11487 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11488 (TypeContainer.AddInterface): Ditto.
11489 (TypeContainer.AddPartial): The main method for partial classes. It checks
11490 for errors and merges ModFlags and attributes. At the end class is added to
11491 partial_parts list.
11492 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11494 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11495 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11496 from the rest of partial classes.
11497 (TypeContainer.GetClassBases): Simplified.
11498 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11500 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11501 (TypeContainer.HasExplicitLayout): Uses Flags now.
11502 (PartialContainer): Removed.
11503 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11504 (StaticClass): Was merged with Class.
11505 (Class.GetClassBases): class and static class bases are verified here.
11506 (Class.TypeAttr): Added static attributes when class is static.
11507 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11508 (MemberBase): In some cases we need to call parent container for partial
11509 class. It should be eliminated but it's not easy now.
11511 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11513 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11514 partial classed to accumulate class comments.
11515 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11517 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11519 * driver.cs (MainDriver): Tree.GetDecl was removed.
11521 * modifiers.cs (Modifiers): Add partial modifier.
11523 * tree.cs (Tree.decl): Removed.
11524 (RootTypes): Started to use this class more often for root types
11527 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11531 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11532 external interface does not have an attribute.
11534 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11536 Another prerequisites for new partial classs implementation.
11538 * attribute.cs (Attribute.Equal): Implemented.
11539 (Attribute.Emit): Changed as attributes can be applied more than twice.
11540 (Attributes.Emit): Check for duplicate attributes here.
11542 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11543 as a parameter, clean-up.
11545 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11549 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11550 contains obsolete attribute check which can in some cases look for base
11551 type of current class which is not initialized yet.
11552 (TypeContainer.BaseType): Replacement of ptype.
11554 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11556 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11558 First of prerequisites for new partial classs implemention.
11560 * attribute.cs (Attributable): Extended by ResolveContext;
11561 Attributes finally have correct context for resolving in all cases.
11562 (AttachTo): Attribute owner is assigned here.
11564 * codegen.cs (IResolveContext): Introduce new interface to hold
11565 all information needed in resolving phase.
11566 (EmitContext): Implements IResolveContext; more clean-up needed here.
11568 * decl.cs (MemberCore): Implemented IResolveContext.
11570 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11571 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11572 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11573 Refactored to use new IResolveContext instead of EmitContext; cleanup
11575 2006-02-06 Miguel de Icaza <miguel@novell.com>
11577 * codegen.cs (EmitScopeInitFromBlock): check here the
11578 capture_context, there is no need to make two calls to the
11581 * anonymous.cs: Add some debugging messages that might help me
11582 track other instances of this problem in the future (the
11583 regression of test 467).
11585 * cs-parser.jay: track the variable block, as we need to initalize
11586 any captured variables declared in this block for the "catch"
11587 portion of the "Try" statement.
11589 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11590 scope initialization for captured variables.
11592 Also, move the emit for the variables after the block location has
11595 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11597 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11599 2006-02-02 Miguel de Icaza <miguel@novell.com>
11601 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11602 commit yesterday, the initialization for the roots is necessary.
11603 What is not necessary is the scope activation.
11605 2006-02-02 Raja R Harinath <rharinath@novell.com>
11607 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11608 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11610 (Argument.Resolve): Remove CS0206 checks.
11612 2006-02-01 Miguel de Icaza <miguel@novell.com>
11614 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11615 scopes for all the roots, the scopes will now be emitted when the
11616 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11618 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11619 code. This reduces a lot of existing cruft.
11621 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11622 that the ScopeInfo is generated as we enter the scope, not at the
11623 time of use, which is what we used to do before.
11625 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11626 every time a Block is about to be emitted if we have a
11629 2006-02-01 Raja R Harinath <rharinath@novell.com>
11631 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11633 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11635 * typemanager.cs (cons_param_array_attribute): Make private.
11636 (Reset): Set it to null.
11637 (InitCoreHelpers): Don't initialize it.
11638 (ConsParamArrayAttribute): New. Initialize it as needed.
11639 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11641 2006-01-31 Miguel de Icaza <miguel@novell.com>
11643 * expression.cs: There might be errors reported during the
11644 selection of applicable methods. If there are errors, do not
11645 continue execution as it will lead the compiler to crash.
11647 2006-01-30 Miguel de Icaza <miguel@novell.com>
11649 * expression.cs: Member access is not allowed on anonymous
11650 methods. Fixes #77402.
11652 2006-01-30 Raja R Harinath <rharinath@novell.com>
11655 * cs-parser.jay (VariableDeclaration): Don't set
11656 current_array_type to null.
11657 (field_declaration, event_declaration, declaration_statement):
11658 Set it to null here.
11660 2006-01-28 Raja R Harinath <harinath@gmail.com>
11662 * typemanager.cs (GenericParameterPosition): New.
11665 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11667 * doc.cs : To process "include" elements, first we should create
11668 another list than XmlNodeList, because it could result in node
11669 removal, which could result in that the XmlNodeList gives up
11670 yielding next node.
11672 (Also made code identical to gmcs again.)
11674 2006-01-25 Miguel de Icaza <miguel@novell.com>
11676 * ecore.cs: Introduce an error report that we were not catching
11677 before, if not silent, we must report the error. Gonzalo ran into
11680 2006-01-23 Miguel de Icaza <miguel@novell.com>
11682 A fix for bug: #76957
11684 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11685 ComputeMethodHost before creating the method, this is a new
11688 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11689 that this method references (RegisterScope). The actual scope
11690 where the method is hosted is computed with the ComputeMethodHost
11691 before we create the method.
11693 Moved the Deepest routine here.
11695 (AnonymousContainer.ComputeMethodHost): New routine used to
11696 compute the proper ScopeInfo that will host the anonymous method.
11698 (ScopeInfo): Deal with multiple roots. The problem was that we
11699 did not have a unique root where all ScopeInfos could be hanged
11700 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11703 Remove AdjustMethodScope which is now computed at the end. Remove
11704 LinkScope which did a partial link, instead link all ScopeInfos
11705 before code generation from the new "LinkScopes" routine.
11707 Simplify all the Add* routines as they no longer need to maintain
11708 the tree, they just need to record that they are using variables
11711 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11712 routines to produce the forest of ScopeInfo trees.
11714 * class.cs (TypeContainer.AppendMethod): This is just like
11715 AddMethod, but ensures that an interface implementation method
11716 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11717 methods, but at the end.
11719 We use this functionality to ensure that the generated MoveNext
11720 method in the iterator class is resolved/emitted before the
11721 enumerator methods created.
11723 This is required because the MoveNext method computes the right
11724 ScopeInfo for the method. And the other methods will eventually
11725 need to resolve and fetch information computed from the anonymous
11728 2006-01-21 Raja R Harinath <harinath@gmail.com>
11729 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11731 Fix rest of #76995.
11732 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11733 the 'aliases' hash.
11734 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11735 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11737 2006-01-18 Raja R Harinath <rharinath@novell.com>
11739 Fix #76656, cs0231-2.cs.
11740 * cs-parser.jay (formal_parameter_list): Make error case catch
11742 (parenthesized_expression_0): Add CS1026 check.
11743 (invocation_expression): Remove unused { $$ = lexer.Location }.
11745 2006-01-17 Raja R Harinath <rharinath@novell.com>
11748 * cs-parser.jay (statement_expression): Don't list out the
11749 individual statement-expressions. Convert syntax error into
11752 2006-01-16 Raja R Harinath <rharinath@novell.com>
11755 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11756 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11757 CheckIntermediateModification.
11758 (FieldExpr.DoResolve): Add new two-argument version that
11759 allows us to resolve the InstanceExpression as an lvalue.
11760 The one-argument variant is now just a wrapper.
11761 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11762 Resolve the lhs as an lvalue if the it has a value type.
11763 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11764 from Assign.DoResolve.
11765 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11766 resolved as an lvalue.
11767 (PropertyExpr.DoResolve): Update.
11768 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11769 has a value type. Move CS1612 check here from
11770 CheckIntermediateModification.
11771 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11772 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11773 'right_side' of a ResolveLValue on an 'out' argument.
11774 (EmptyExpression.LValueMemberAccess): New. Used as the
11775 'right_side' of a propagated ResolveLValue on a value type.
11776 (LocalVariableReference.DoResolveBase): Recognize
11777 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11779 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11780 EmptyExpression.Null.
11782 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11784 * typemanager.cs : added IsGenericParameter(). In mcs it always
11786 * doc.cs : for generic parameters, use GenericParameterPosition,
11789 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11791 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11793 2006-01-12 Miguel de Icaza <miguel@novell.com>
11795 This fixes the problem where we used ldfld instead of ldflda to
11796 load the "THIS" pointer on captured parameters, when THIS is a
11797 value type. See bug #77205.
11799 * iterators.cs (CapturedThisReference.Emit): Pass false to
11800 EmitThis (we do not need the address).
11802 * codegen.cs (EmitThis): it needs to know whether we need the
11803 address of `this' or not. This is used by value types.
11805 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11806 every other call passes false.
11808 2006-01-12 Raja R Harinath <rharinath@novell.com>
11811 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11813 * expression.cs (Invocation.OverloadResolve): Update.
11814 (Invocation.DoResolve): Avoid double resolution of invocation.
11816 2006-01-11 Raja R Harinath <rharinath@novell.com>
11819 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11820 unary negation of floating point types as 0-expr; negation cannot
11821 overflow in floating point types.
11824 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11825 on operands of 'void' type.
11828 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11829 and ExclusiveOr for boolean constants too.
11831 2006-01-09 Raja R Harinath <rharinath@novell.com>
11834 * expression.cs (Invocation.OverloadResolve): Replace reflected
11835 override methods with their base virtual methods, rather than
11836 skipping over them.
11837 * typemanager.cs (TypeManager.GetOverride): New.
11839 2006-01-05 Jb Evain <jbevain@gmail.com>
11841 * class.cs (Property.Define, Indexer.Define): do not tag the
11842 properties as SpecialName | RTSpecialName.
11844 2006-01-04 Miguel de Icaza <miguel@novell.com>
11846 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11847 doing a low-level comparission of parameter types. It was lacking
11848 a check for __argslist.
11850 2005-12-30 Miguel de Icaza <miguel@novell.com>
11852 * expression.cs (ParameterReference.DoResolveBase): Allow
11853 reference parameters if they are local to this block.
11855 This allows the ref and out parameters of a delegate to be used in
11856 an anonymous method, for example:
11858 delegate void set (out int x);
11860 set s = delegate (out int x){
11864 This is used by functionality introduced late in the C# language.
11866 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11867 method that take ref and out parameters.
11869 Fixes #77119 which was a late change in the spec.
11871 2005-12-23 Miguel de Icaza <miguel@novell.com>
11873 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11874 parent if its the same scope. Fixes #77060.
11876 2005-12-21 Miguel de Icaza <miguel@novell.com>
11878 * driver.cs: Report the case of no source files and no -out:
11881 2005-12-20 Raja R Harinath <rharinath@novell.com>
11884 * expression.cs (ComposedCast.GetSignatureForError): Define.
11886 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11890 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11891 ListDictionary, to contain the ExternAliasEntry entries (in
11892 addition to the NamespaceEntry.aliases hashtable). This field is
11893 shared between the original entry and its doppelganger (bodyless
11895 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11896 extern_aliases field.
11897 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11898 lookup in extern_aliases.
11900 2005-12-16 Raja R Harinath <rharinath@novell.com>
11903 * class.cs (TypeContainer.Mark_HasEquals): New.
11904 (TypeContainer.Mark_HasGetHashCode): New.
11905 (ClassPart): Override them.
11906 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11909 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11910 'parent' argument to the base constructor.
11912 Remove all mention of TypeContainer from decl.cs.
11913 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11914 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11915 (DeclSpace.DeclSpace): Likewise.
11916 (DeclSpace.DefineMembers): Remove unused argument.
11917 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11918 debugging check -- we don't care if the debug code throws an
11919 InvalidCastException instead of an InternalErrorException.
11920 * class.cs (TypeContainer.DefineMembers): Update to changes.
11921 (TypeContainer.DoDefineMembers): Likewise.
11922 (TypeContainer.GetMethods): Likewise.
11923 (PropertyMember.Define): Likewise.
11924 (MemberBase.Parent): New property that forwards to
11925 MemberCore.Parent, but ensures that we get a TypeContainer.
11926 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11927 (RootContext.PopulateTypes): Likewise. Remove special case code
11928 for !RootContext.StdLib: DefineMembers is idempotent.
11930 2005-12-14 Miguel de Icaza <miguel@novell.com>
11932 * convert.cs (ExplicitConversionCore): Check the return value from
11933 ExplicitConversionCore which can return null on failure. Fixes #76914
11935 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11937 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11939 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11941 * doc.cs : The search for referenced namespace was insufficient to
11942 get global one as it used to do. Fixed bug #76965.
11944 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11946 * doc.cs : check name in cref in the last phase that whether it is
11949 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11951 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11954 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11956 * doc.cs : so it turned out that we cannot skip override check for
11957 interface members. Fixed bug #76954.
11959 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11961 * cs-tokenizer.cs : fixed bug #75984:
11962 - #warning and #error should not be handled when the source line
11964 - #line is not checked strictly when the source line is disabled.
11965 - #define and #undef is on the other hand checked strictly at any
11968 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11970 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11973 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11975 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11977 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11978 event initializers.
11979 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11980 (FieldBase.Initializer): Initializer is now optional.
11981 (EventField.Define): Only event field can have initializer.
11983 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11985 * const.cs (Const): Reuse initializer.
11987 * cs-parser.jay: Updated after FieldBase changes.
11988 Added current_array_type to simplify array initializers.
11990 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11992 * expression.cs, iterators.cs: Updated.
11994 * namespace.cs (NamespaceEntry): Made UsingFound private.
11996 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11998 * parameterCollection.cs: Obsolete, removed.
11999 * parser.cs: Obsolete, removed.
12001 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12004 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
12006 * enum.cs (Enum.Define): Set obsolete context here.
12008 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12011 - FindDocumentedMember() now expects 1) paramList as null
12012 when "we don't have to check the number of parameters" and
12013 2) Type.EmptyTypes when "there is no arguments".
12014 - Introduced FoundMember struct to hold the exact type which was
12015 used to find the documented member (the above change broke
12016 test-xml-044; it might be better just to use DeclaringType than
12017 what MS does, like this change does, but it depends on usage.)
12019 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12021 * doc.cs : documented member might be from DeclaringType for nested
12022 types. Fixed bug #76782.
12024 2005-12-03 Ben Maurer <bmaurer@ximian.com>
12026 * anonymous.cs: Have the param code handle leaving copies on the
12027 stack etc. Allows anonymous params to take part in the assignment
12028 code (++, +=, etc). Fixes bug #76550
12030 * expression.cs: Handle the prepare_for_load/leave_copy by passing
12031 it down to the anon code.
12033 * iterators.cs: Use dummy var here
12035 * codegen.cs: Handle new vars
12037 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12040 * class.cs (MethodData.Define): Set proper Obsolete context.
12042 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
12044 (FieldExpr.DoResolve): Ditto.
12046 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12049 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
12050 parent is not obsolete.
12052 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
12054 * doc.cs : (FindDocumentedMember) find parameterless members first
12055 and get CS0419 in the early stage. Fixed first case of bug #76727.
12057 2005-11-30 Marek Safar <marek.safar@seznam.cz>
12060 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
12061 no error was reported.
12063 *expression.cs (Binary.DoResolve): left can be null.
12065 2005-11-22 Marek Safar <marek.safar@seznam.cz>
12068 * class.cs (MethodData.Emit): Parameters should be labeled first.
12070 2005-11-21 Marek Safar <marek.safar@seznam.cz>
12073 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
12075 2005-11-18 Marek Safar <marek.safar@seznam.cz>
12077 * attribute.cs (AreParametersCompliant): Moved to Parameter.
12079 * class.cs (MethodCore): Parameter clean up.
12080 (IMethodData): Added ParameterInfo.
12081 (MethodData): Parameter clean up.
12082 (Indexer.Define): Parameter clean up.
12094 * typemanager.cs: Parameter clean up.
12096 * delegate.cs (Define): Get rid of duplicated code.
12098 * expression.cs (ParameterReference): Removed useless parameters
12100 (Invocation): Ditto.
12102 * parameter.cs (ParamsParameter): New class, params specialization.
12103 (ArglistParameter): Attemp to separate arglist.
12104 (Parameter): Refactored to be reusable and faster.
12105 (Parameter.Modifier): Made understandable.
12106 (Parameters): Changed to be used as a class for `this' assembly
12107 parameters. Refactored to use new specialized classes.
12109 * support.cs (ParameterData): Added Types property.
12110 (InternalParameters): Deleted.
12112 2005-08-20 Martin Baulig <martin@ximian.com>
12114 Merging this patch from GMCS to fix #75867.
12116 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12117 scope if we don't already have it.
12119 2005-11-17 Martin Baulig <martin@ximian.com>
12122 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
12123 inherit the scope from our parent. Fixes #76653.
12125 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12127 * doc.cs : the previous patch does not actually fix the bug.
12128 PropertyInfo override check is now implemented and really fixed it.
12129 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
12131 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12133 * doc.cs : apply "override filter" also to properties.
12136 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12138 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
12139 no need to check overrides. For classes, omit those results from
12140 interfaces since they must exist in the class. Fixed bug #76726.
12142 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12144 * typemanager.cs : (GetFullNameSignature) differentiate indexers
12145 with different parameters. Fixed the second problem in #76685.
12147 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12149 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
12150 get expected 'protected' access in CheckValidFamilyAccess()).
12153 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12155 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
12156 Fixed bug #76705. CS1569 was incorrectly commented out.
12158 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12160 * doc.cs : use Invocation.IsOverride() to do real override check.
12161 * expression.cs : made Invocation.IsOverride() internal.
12163 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12165 * doc.cs : use TypeManager.FindMembers() instead of (possible)
12166 TypeBuilder.FindMembers() and filter overriden base members out.
12169 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12171 * doc.cs : ref/out parameters are represented as '@' (instead of
12172 '&' in type FullName). Fixed bug #76630 (additionally crefs).
12174 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12176 * doc.cs : when there was no '.' in cref to methods in doc comment,
12177 then parameters were missing in the output. Fixed bug #76691.
12179 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12181 * driver.cs : don't output docs when there is an error.
12184 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12187 Now it should detect indexers. Fixed primary concern in bug #76685.
12188 Fixed CS0419 message to not show the identical member signature in
12191 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12193 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
12194 instead of Type.FindMembers() since it does not handle events.
12197 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
12199 * codegen.cs: Fixed typo (speficied -> specified).
12201 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12204 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
12206 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12208 * attribute.cs: Changed error message.
12210 * cs-tokenizer.cs: One more check.
12212 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12214 * statement.cs (Block.Resolve): Ignore empty statement.
12216 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12218 * report.cs: Made error/warning methods more strict to avoid
12221 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
12222 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
12223 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
12224 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
12226 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12228 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12229 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12231 * class.cs (TypeContainer.IsComImport): New property.
12232 (Constructor.Define): Create proper ctor for ComImport types.
12234 * expression.cs (New.CheckComImport): Fixed.
12236 2005-11-07 Miguel de Icaza <miguel@novell.com>
12238 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12239 that a parameter has been captured does not mean that we do not
12240 have to do the rest of the processing. This fixes the second part
12241 of #76592. If there was another anonymous method capturing
12242 values in the past, the Scope would never be set for the second
12243 method that captured the same parameter.
12245 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12246 properly manipulate the stack. Second part of fix for #76592.
12248 * expression.cs (New): Add support for invoking "new" on
12249 interfaces that have been flagged with the ComImport attribute and
12250 the CoClass. Fixes #76637
12252 * statement.cs (Try.DoEmit): When a variable is captured, do not
12253 try to emit the vi.LocalBuilder variable as it has been captured.
12254 Create a temporary variable and store the results on the
12255 FieldBuilder. Fixes #76642
12257 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12259 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12261 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12263 * expression.cs (Binary.DoResolve): Added && optimalization.
12265 * typemanager.cs (AddUserType): Removed useless argument.
12267 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12269 * statement.cs (Block.variables): Uses ListDictionary.
12271 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12274 * class.cs (PartialContainer.EmitType): Customized to emit
12275 security attributes.
12276 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12277 for partial classes.
12279 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12282 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12283 access has to be fixed.
12285 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12287 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12290 * ecore.cs (NullCast.Reduce): Implemented.
12292 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12295 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12297 (Foreach.Resolve): Catch null properly.
12299 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12301 * cs-tokenizer.cs: Warning text fix.
12303 * driver.cs: AllWarningNumbers exposed on public interface.
12305 * report.cs (): Reviewed warning numbers.
12306 (IsValidWarning): Use binary search.
12308 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12310 * driver.cs: Implemeted resource visibility.
12311 (Resources): New class for code sharing between /res: and
12314 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12317 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12320 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12323 * ecore.cs (NullCast): Child is contant only.
12325 * literal.cs (NullLiteral.Reduce): null can be converted to any
12328 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12330 * driver.cs: Use Encoding.Default as default code page instead
12333 2005-10-27 Raja R Harinath <rharinath@novell.com>
12336 * expression.cs (Invocation.Error_InvalidArguments): Handle
12337 __arglist parameters.
12338 (Invocation.VerifyArgumentsCompat): Likewise.
12339 * support.cs (ReflectionParameters.GetSignatureForError): Print
12340 __arglist parameters.
12341 (InternalParamters.GetSignatureForError): Likewise.
12342 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12344 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12346 * attribute.cs (GetPropertyValue): Made public.
12348 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12350 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12352 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12355 * driver.cs: Reflect method name change.
12357 * statement.cs (Try.Resolve): Warn when try has both general
12358 exception handlers.
12360 * typemanager.cs: runtime_compatibility_attr_type new predefined
12363 2005-10-26 Raja R Harinath <harinath@gmail.com>
12366 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12367 treat it as an empty parameter list.
12369 2005-10-26 Raja R Harinath <rharinath@novell.com>
12372 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12373 ResolveAsTypeStep silent.
12374 * statement.cs (Block.AddConstant): Mark block as used.
12375 (Block.ResolveMeta): Avoid piling on error messages
12376 if a constant initializer resolution fails.
12378 2005-10-25 Raja R Harinath <rharinath@novell.com>
12380 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12382 (NamespaceEntry.VerifyAllUsing): New.
12383 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12384 behaviour. Delegates actual resolution of alias to ...
12385 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12386 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12388 * driver.cs (Driver.MainDriver): Update.
12390 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12391 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12393 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12395 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12396 RootNamespace.DefineNamespacesForAll.
12398 2005-10-24 Raja R Harinath <harinath@gmail.com>
12400 * typemanager.cs (assemblies, external_aliases, modules)
12401 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12402 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12403 overhead. Move resposibility ...
12404 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12405 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12407 2005-10-23 Raja R Harinath <harinath@gmail.com>
12409 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12410 cached_namespaces. Improve usage.
12411 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12412 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12413 Move from GlobalRootNamespace and simplify.
12414 (RootNamespace.Global): Make instance variable.
12415 (RootNamespace.RootNamespace): Add "alias name" parameter.
12416 (GlobalRootNamespace): Simplify drastically.
12417 (Namespace.Lookup): Don't use GetNamespace.
12418 * typemanager.cs (GetRootNamespace): Rename from
12419 ComputeNamespaceForAlias.
12420 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12422 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12424 * anonymous.cs (AnonymousContainer): Don't crash when container
12427 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12429 * expression.cs (Binary.DoResolve): Warn when comparing same
12432 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12435 * expression.cs (Binary.DoResolve): It looks like there are no
12436 convetsion rules in enum context.
12438 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12440 Add support for extern alias qualifiers.
12441 * typemanager.cs: Move some LookupTypeReflection code
12442 to namespace.cs, to have cleaner code. Added some methods
12443 to help us keep track of the extern aliased references.
12444 * driver.cs: Add suport for extern alias assemblies on command
12445 line and check for their warnings/errors. Also keep track of the
12446 extern aliased assemblies.
12447 * namespace.cs: Move the global functionality of Namespace
12448 to GlobalRootNamespace/RootNamespace. Now the global namespace
12449 is GlobalRootNamespace.Globa. Also the code moved from
12450 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12451 Finally added LocalAliasEntry (AliasEntry before) and
12452 ExternAliasEntry, to handle alias statements.
12453 * cs-parser.jay: Add support in the grammar for extern alias
12455 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12456 Update callings to Namespace (now in GlobalRootNamespace).
12458 2005-10-18 Raja R Harinath <rharinath@novell.com>
12461 * class.cs (TypeContainer.DefineType): Move updating of
12462 topological sort earlier in the code.
12463 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12465 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12468 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12470 * constant.cs (Constant.TryReduce): Moved from Cast class.
12471 (Reduce): Made little bit more OO and fixed missing conversions.
12473 * ecore.cs (Reduce): Implemented.
12474 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12476 * literal.cs (Reduce): Implemented.
12478 * class.cs: Reverted Miguel's wrong commit.
12480 2005-10-14 Miguel de Icaza <miguel@novell.com>
12482 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12484 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12486 * cs-parser.jay, expression.cs : CS0214 was missing error location
12487 for constants. Fixed bug #76404.
12489 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12492 * convert.cs (ExplicitConversionCore): Fixed object->enum
12495 2005-10-10 Raja R Harinath <rharinath@novell.com>
12497 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12498 InstanceExpression.
12499 (PropertyExpr.EmitCall): Likewise.
12500 * expression.cs (Invocation.EmitArguments): Handle case where
12502 (Invocation.EmitCall): Avoid allocating temporary variable if
12503 there are no arguments.
12505 2005-10-07 Raja R Harinath <rharinath@novell.com>
12508 * convert.cs (ImplicitConversionStandard): Move conversion of
12509 void* to arbitrary pointer types ...
12510 (ExplicitConversionStandard): .. here.
12511 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12512 error to always print typenames.
12514 2005-10-07 Raja R Harinath <rharinath@novell.com>
12516 * convert.cs (GetConversionOperator): Rename from
12517 GetConversionOperators. Move operator selection code from ...
12518 (UserDefinedConversion): ... here.
12520 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12522 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12525 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12527 * assign.cs (Assign.DoResolve): Error method changed.
12529 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12531 * const.cs (ResolveValue): Reset in_transit immediately.
12533 * constant.cs: Error method changed.
12535 * convert.cs: Removed useless location parameter.
12536 (ExplicitNumericConversion): Don't do double enum check.
12537 (ExplicitConversionCore): Renamed from ExplicitConversion.
12538 (ExplicitUnsafe): Extracted from ExplicitConversion.
12539 (ExplicitConversion): Uses for error reporting.
12541 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12543 (ResolveBoolean): Uses common error method.
12544 (CastToDecimal): Get rid of ec.
12545 (CastFromDecimal): Optimized.
12546 (ConvCast): Get rid of ec.
12548 * enum.cs (ResolveValue): Reset in_transit immediately.
12549 (Emit): Return after first error.
12551 * expression.cs: Convert changes.
12553 * literal.cs: Error method changed.
12555 * statement.cs: Error method changed.
12557 2005-10-03 Raja R Harinath <rharinath@novell.com>
12559 * support.cs (SeekableStreamReader.Position): Don't error out when
12560 the requested position is just beyond the end of the current
12563 2005-09-28 Raja R Harinath <rharinath@novell.com>
12565 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12566 try to keep in sync with the byte count of the underlying Stream.
12567 However, this limits us to a window size of 2048 characters: i.e.,
12568 the maximum lookahead of our lexer/parser can be 2048 characters.
12570 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12573 * driver.cs: Fix compilation files with full root path.
12575 2005-09-25 Miguel de Icaza <miguel@novell.com>
12577 * report.cs (SymbolRelatedToPreviousError): Format the output so
12578 it does not use an open parenthesis that is never closed.
12580 * driver.cs: Follow coding guidelines
12582 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12585 * const.cs (Const.ResolveValue): Check for assigning non-null
12586 value to reference type.
12588 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12590 * anonymous.cs: Implemented ExprClassName.
12592 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12595 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12598 * class.cs (StaticClass.DefineContainerMembers): Report protected
12601 * codegen.cs: if(ed) PRODUCTION.
12603 * convert.cs (Error_CannotImplicitConversion): Better error
12606 * cs-parser.jay: More error checks.
12608 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12610 * driver.cs (CSCParseOption): Enabled wrong option check.
12612 * ecore.cs (Expression.ExprClassName): Turned to property.
12613 (MemberExpr.CheckIntermediateModification): For checking boxed
12614 value types modification.
12616 * statement.cs (Fixed.Resolve): Expression type must be
12617 convertible to fixed type.
12618 (CollectionForeach.GetEnumeratorFilter,TryType):
12619 Small refactoring for easier error checking.
12621 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12623 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12626 * class.cs (GeneratedBaseInitializer): New class for customization
12627 compiler generated initializers.
12628 (MemberBase.DoDefine): Check Obsolete attribute here.
12629 (FieldMember.DoDefine): Ditto.
12631 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12634 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12635 (MemberCore.GetObsoleteAttribute): Removed argument.
12636 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12637 (MemberCore.CheckObsoleteType): New helper.
12641 * statement.cs: Updates after MemberCore changes.
12643 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12644 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12646 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12647 obsolete attribute for compiler construct.
12648 (As.DoResolve): Cache result.
12650 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12652 2005-09-26 Raja R Harinath <rharinath@novell.com>
12655 * expression.cs (This.VerifyFixed): In a value type T, the type of
12656 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12657 value type R, 'this' is treated as a value parameter.
12659 2005-09-22 Miguel de Icaza <miguel@novell.com>
12661 * statement.cs (Lock): Use the TemporaryVariable class instead of
12662 manually using local variables as those do not work when variables
12665 * ecore.cs: Moved the TemporaryVariable class from being a nested
12666 class inside Foreach to be a public class that can be employed in
12669 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12671 * cs-parser.jay: interface_accessors replaced by
12672 accessor_declarations.
12674 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12677 * statement.cs (GotoCase.Resolve): Convert null constant to
12679 (SwitchLabel.ResolveAndReduce): Ditto.
12680 (SwitchLabel.NullStringCase): Custom null stamp.
12681 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12683 typemanager.cs (CSharpSignature): Don't skip first argument
12686 2005-09-18 Miguel de Icaza <miguel@novell.com>
12688 * driver.cs: Set InEmacs based on the environment variable EMACS.
12690 * location.cs (InEmacs): in this mode, do not report column
12691 location as it confuses Emacs.
12693 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12695 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12696 expression.cs, iterators.cs, literal.cs: Store constants and
12699 * class.cs (MemberBase.ShortName): Pass location.
12701 * cs-parser.jay: Some location fixes.
12703 * ecore.cs (Expression.Location): Made virtual.
12705 2005-09-05 Miguel de Icaza <miguel@novell.com>
12707 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12708 if the underlying types are the same, otherwise we need to produce
12709 code that will do the proper cast.
12711 This was exposed by Marek's constant rewrite which produced
12712 invalid code for the call site:
12714 enum X : long { a }
12715 void Method (X v) {}
12719 This fixes test-49.cs
12721 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12723 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12724 Type/Object should be allowed as well. Fixed bug #75968.
12726 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12728 * expression.cs : (Binary.DoResolve): when one is enum constant and
12729 another is constant 0, then return enum one *as enum type*.
12732 2005-09-02 Raja R Harinath <rharinath@novell.com>
12734 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12738 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12739 flow-branching for LocalVariableReferences in case we were invoked
12740 from a MemberAccess.
12741 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12743 (LocalVariableReference.DoResolveBase): ... this.
12744 (MemberAccess.Resolve): Do the check that was disabled during
12747 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12750 (PartialContainer.Create): check abstract/sealed/static strictly
12751 but abstract/sealed can exist only at one side. Fixed bug #75883.
12753 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12756 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12757 specified, don't default to UnmanagedType.I4.
12759 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12761 * expression.cs : conditional operator should check possibly
12762 incorrect assign expression. Fixed bug #75946.
12764 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12766 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12767 Reverting the change. gmcs is much complex than mcs on this matter.
12769 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12771 * cs-tokenizer.cs : To read another token ahead of the actual
12772 consumption, use new SavedToken and cache token instead of moving
12773 back the stream with SeekableStreamReader (it seemed problematic).
12775 driver.cs : Thus use StreamReader directly.
12776 * support.cs : Thus removed SeekableStreamReader.
12778 2005-08-30 Raja R Harinath <rharinath@novell.com>
12781 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12782 (ScopeInfo.EmitScopeType): Use it to construct field names from
12783 names of captured locals.
12786 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12787 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12788 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12789 (ExplicitConversion): Remove enum cases already handled by
12790 implicit conversion. Move implicit conversion check to the beginning.
12791 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12792 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12793 Don't treat System.Enum as a struct.
12795 2005-08-30 Jb Evain <jbevain@gmail.com>
12797 * attribute.cs: handles as expression in parameters.
12799 2005-08-30 Raja R Harinath <rharinath@novell.com>
12802 * class.cs (TypeContainer.VerifyClsName): Don't use a
12803 PartialContainer when verifying CLS compliance.
12804 (AbstractPropertyEventMethod): Set Parent here, ...
12805 (PropertyMethod): ... not here.
12807 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12809 * attribute.cs : escaped attribute name should not be allowed to be
12810 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12812 2005-08-29 Raja R Harinath <rharinath@novell.com>
12815 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12816 when converting a long constant to unsigned long.
12817 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12818 detect where IsApplicable and VerifyArgumentsCompat disagree.
12820 2005-08-29 Raja R Harinath <rharinath@novell.com>
12821 and Carlos Alberto Cortez <carlos@unixmexico.org>
12824 * class.cs (TypeContainer.CanElideInitializer): New helper.
12825 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12826 can safely emitting the initializer of a field.
12828 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12830 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12831 allowed inside a switch (without loop). Fixed bug #75433.
12833 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12835 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12836 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12838 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12840 * driver.cs : kinda reverting the default encoding changes (not exact
12841 revert since I noticed that "codepage:reset" might not work fine).
12843 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12845 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12846 Location. Now getter and setter store location correctly.
12847 (errors/cs0111-12.cs now reports the expected location.)
12849 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12851 * driver.cs : Use default encoding on the environment.
12852 Removed (now that) extra parameter for SeekableStreamReader.
12853 * support.cs : (SeekableStreamReader) third .ctor() argument for
12854 StreamReader is not required (always true). preamble size could
12855 be acquired in simpler and safe way.
12857 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12859 * cs-parser.jay: report CS0642 at warning level 3
12860 and report CS0642 for an if else statement also
12861 fixes bug #74745. Patch by John Luke (and a bit
12863 Removed extra CS0642 warning check for "while",
12865 * statement.cs: In Block.Resolve(), CS0642 check
12866 is reimplemented to check a sequence of an empty
12867 statement and a block.
12869 Both fix bug #66777.
12871 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12873 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12874 detection until I fix it.
12876 * cs-tokenizer.cs: Changed error message.
12878 * cs-parser.jay: Fixed 2 error locations.
12880 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12881 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12884 * enum.cs (GetSignatureForError): Fixed.
12886 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12890 * typemanager.cs (RegisterProperty): Removed.
12892 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12894 2005-08-24 Raja R Harinath <rharinath@novell.com>
12897 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12898 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12900 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12902 * expression.cs : tiny fix is required for not warning positive ulong.
12905 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12907 * expression.cs : add CS0652 check for constant and integral
12908 expression. Fixed bug #53974.
12910 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12912 * expression.cs : in DoNumericPromotions(), check if there is implicit
12913 conversion overload for string (to check CS0034). Fixed bug #52492.
12915 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12917 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12919 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12921 * ecore.cs : report location when it is *not* Null.
12923 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12929 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12930 correctly. Fixed bug #75721.
12932 2005-08-23 Raja R Harinath <rharinath@novell.com>
12934 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12935 loop that performs 'min (pos, char_count)'.
12938 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12939 converted value in Operator.OnesComplement.
12941 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12943 * anonymous.cs: If the anon method is pulled into a helper class,
12944 it needs to be `internal' not `private'. Fixes runtime behavior on
12947 2005-08-20 Martin Baulig <martin@ximian.com>
12949 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12950 scope if we don't already have it.
12952 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12953 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12956 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12959 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12960 is a partial class.
12962 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12964 The big constants rewrite
12965 Fix #75746, #75685 and more
12966 As a side effect saved 1MB for MWF ;-)
12968 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12969 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12970 enum based for corlib compilation.
12972 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12975 * class.cs (FixedField.Define): Use ResolveAsConstant.
12977 * const.cs (IConstant): Interface constants and enums.
12978 (Const.ResolveValue): New method for constant resolvning.
12979 (ExternalConstant): Constants from imported assemblies.
12981 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12982 conversion; like enums.
12983 (Constant.ToType): Converts this constant to different type.
12984 (Constant.Increment): Adds 1.
12986 * convert.cs (ImplicitConversionRequired): Simplified.
12988 * cs-parser.jay: Create EnumMember directly.
12990 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12992 * doc.cs (GenerateEnumDocComment): Removed.
12994 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12995 (ConvertIntLiteral): Removed.
12996 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12998 * enum.cs (EnumMember): Implement IConstant.
12999 (Enum.IsValidEnumConstant): Removed.
13000 (Enum.GetNextDefaultValue): Removed.
13001 (Enum.FindMembers): Updated.
13002 (Enum.GenerateDocComment): Iterate enum members.
13004 * expression.cs (Cast.TryReduce): Handle enums correctly.
13005 (New.Constantify): Made public.
13006 (MemberAccess.DoResolve): Removed contant specific if(s).
13008 * literal.cs (NullLiteral): Implement new abstract methods.
13010 * statement.cs (GotoCase.Resolve): Use new constant methods.
13011 (SwitchLabel.ResolveAndReduce): Use new constant methods.
13013 * typemanager.cs (LookupEnum): Removed.
13014 (IsEnumType): Fixed to work with corlib.
13015 (RegisterConstant): Removed.
13016 (LookupConstant): Removed.
13017 (GetConstant): Changed to work with IConstant.
13019 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
13021 * location.cs : Fixed overflown (>255) column number.
13023 2005-08-03 Raja R Harinath <rharinath@novell.com>
13025 First cut of the qualified-alias-member feature.
13026 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
13028 * cs-parser.jay (DOUBLE_COLON): New token.
13029 (namespace_or_type_name): Add rule for recognizing
13030 qualified-alias-members.
13031 (primary_expression): Likewise.
13032 (element_access): Allow QualifiedAliasMember as a possible
13033 type-bearing expression.
13034 (local_variable_type, local_variable_pointer_type): Likewise.
13035 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
13036 aliases in the current and enclosing namespace declarations.
13037 (NamespaceEntry.UsingAlias): Add CS0440 warning.
13038 * decl.cs (MemberName.is_double_colon): New.
13039 (MemberName.MemberName): Add new constructor for alias-member.
13040 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
13041 * expression.cs (QualifiedAliasMember): New expression type.
13043 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13045 * location.cs : it borked when no argument was specified.
13047 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13049 * location.cs : tiny ToString() format fix.
13051 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13053 * statement.cs : oops, it was missing.
13055 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13057 A set of fixes for precise line/column location.
13060 "token" field now holds a file/line "delta", a line number offset
13061 from the segment, and a column number. See also:
13062 http://lists.ximian.com/pipermail/mono-devel-list/2004-
13063 December/009508.html
13064 Removed static IsNull. Use instance IsNull property instead.
13065 * cs-tokenizer.cs :
13066 For some tokens it stores Location. For Identifier it stores
13067 LocatedToken which is a pair of string name and location.
13068 Column numbers are adjusted only at getChar().
13070 Use Location.ToString() for reporting (it now contains column).
13072 Largely modified to use LocatedToken instead of
13073 string (IDENTIFIER), and to acquire Location from some tokens.
13074 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
13075 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
13077 Now MemberName holds Location. DeclSpace.ctor() receives Location
13078 as a parameter. Removed extra parameters to all derived classes.
13079 Replaced Location.IsNull() with instance property.
13080 * assign.cs, expression.cs :
13081 Added .ctor() overload that omits Location.
13083 Added "nameEscaped" flag that indicates the identifier was escaped
13084 in the source file. This fixes bug #57047.
13086 2005-08-02 Marek Safar <marek.safar@seznam.cz>
13088 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
13089 New method, looking for lo-case imported cls type.
13091 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
13094 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
13096 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
13098 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
13099 all_imported_types.
13100 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
13102 Optimized to save 3.5 MB for SWF compilation.
13104 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13106 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
13107 (PartialContainer.Create): Moved logic AddToContainer.
13108 (PartialContainer.MarkForDuplicationCheck): Shares name.
13110 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
13113 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
13115 (Namespace.GetSignatureForError): New method.
13117 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
13118 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
13120 2005-08-01 Raja R Harinath <rharinath@novell.com>
13123 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
13124 member lookup rather than qualifier_type, since qualifier_type can
13127 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13129 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
13132 2005-07-31 Miguel de Icaza <miguel@novell.com>
13134 * statement.cs: Copy the local exception into the exception
13135 captured local. Fixes 75674
13137 2005-07-31 Raja R Harinath <harinath@gmail.com>
13140 * expression.cs (Invocation.OverloadResolve): Don't report error
13141 CS1501 if error CS1502 has been reported.
13142 (New.DoResolve): Delegate CS1501 reporting to
13143 Invocation.OverloadResolve.
13146 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
13147 invariant-meaning-in-block property in an enclosing block if
13150 2005-07-29 Marek Safar <marek.safar@seznam.cz>
13152 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
13153 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
13154 (Switch.CheckSwitch): Just save 50kb for SWF.
13156 2005-07-27 Martin Baulig <martin@ximian.com>
13158 * anonymous.cs (CaptureContext.AddField): Added
13159 `AnonymousContainer am' argument; compute its toplevel scope if
13160 it's not already computed. Fixes #75649.
13162 2005-07-26 Raja R Harinath <rharinath@novell.com>
13165 * class.cs (Constructor.Emit): Reset block to null if the block
13168 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13170 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
13172 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13174 * class.cs (MethodData.Define): Check whether accessor implementing
13175 interface is public.
13177 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
13179 2005-07-22 Marek Safar <marek.safar@seznam.cz>
13182 * namespace.cs (LookupType): Moved same type check to...
13184 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
13185 with the same name.
13187 2005-07-21 Raja R Harinath <rharinath@novell.com>
13189 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
13190 already found a typebuilder.
13191 * class.cs (MethodCore.IsDuplicateImplementation): Compare
13192 MemberNames, not strings.
13194 * const.cs (Error_ExpressionMustBeConst):
13195 Rename from Error_EpressionMustBeConst.
13196 * const.cs, class.cs, statement.cd: Update.
13198 2005-07-21 Marek Safar <marek.safar@seznam.cz>
13202 * const.cs (Const.LookupConstantValue): Report missing contant expression
13204 (Error_EpressionMustBeConstant): Only one error method.
13206 * class.cs, statement.c: Updated.
13208 2005-07-20 Raja R Harinath <rharinath@novell.com>
13210 * statement.cs (Block.Flags): Add back HasVarargs.
13211 (Block.flags): Make protected.
13212 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
13214 * typemanager.cs (types, typecontainers, user_types): Remove.
13215 (UserTypes, TypeContainers): Likewise.
13216 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
13217 (CleanUp, Reset): Update.
13218 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
13219 (GetNestedType): Use Type.GetNestedType.
13220 (CoreLookupType): Take two arguments, the namespace and the
13221 basename of the type. Update to use the Namespace.Lookup
13223 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
13224 (RealMemberLookup): Use IsNestedChildOf instead of playing with
13225 string concatenation and substring matches.
13226 * class.cs, enum.cs, delegate.cs: Update to changes.
13228 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13230 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13231 Expression and made virtual.
13233 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13234 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13236 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13238 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13241 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13244 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13247 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13248 AssemblyCultureAttribute is not used on executable.
13251 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13253 2005-07-16 Raja R Harinath <rharinath@novell.com>
13256 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13257 New. Reports CS0252/CS0253.
13258 Mostly taken from preliminary patch by Duncak Mak.
13259 (Binary.DoResolveOperator): Store results of operator lookup.
13260 Use them to detect if we need to warn about unintended reference
13263 2005-07-15 Raja R Harinath <rharinath@novell.com>
13266 * namespace.cs (Namespace.Lookup): Add back location parameter.
13267 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13268 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13270 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13271 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13272 (Namespace.LookupType): ... this.
13273 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13275 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13276 purported to handle pointers.
13277 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13280 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13282 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13285 2005-07-15 Raja R Harinath <rharinath@novell.com>
13287 * namespace.cs (Namespace.Lookup): Drop location parameter.
13288 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13289 (NamespaceEntry.Lookup): ... this.
13290 (NamespaceEntry.Error_AmbiguousTypeReference):
13291 Move here from DeclSpace.
13292 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13294 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13295 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13296 Move to NamespaceEntry.
13297 * delegate.cs, expression.cs: Update to changes.
13299 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13301 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13302 CheckAttributeType and refactored.
13303 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13304 ResolveAsTypeTerminal error handling.
13305 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13307 (GetSignatureForError): Print errors in same way.
13310 * codegen.cs: Reflect attribute GetSignatureForError change.
13313 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13315 * namespace.cs (UsingEntry): Refactored to make fields private.
13318 statement.cs: Error_UnexpectedKind has extra parameter.
13320 2005-07-14 Raja R Harinath <rharinath@novell.com>
13322 * ecore.cs (IAlias): Remove.
13323 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13324 that implement the interface.
13325 * namespace.cs (Namespace): Likewise.
13326 (Namespace.declspaces): Renamed from 'defined_names'.
13327 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13328 DeclSpace instead of an IAlias.
13329 * tree.cs (Tree.AddDecl): Update.
13331 2005-07-12 Raja R Harinath <rharinath@novell.com>
13333 * statement.cs (Block.Flags); Remove HasVarargs.
13334 (Block.HasVarargs): Move to ToplevelBlock.
13335 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13336 (Block.Variables): Make protected. Initialize variable hashtable
13338 (Block.AddVariable): Update.
13339 (Block.Resolve): Update to changes.
13340 (ToplevelBlock.HasVarargs): New boolean.
13341 (ToplevelBlock.ThisVariable): Move here from Block.
13342 (ToplevelBlock.AddThisVariable): Likewise.
13343 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13344 * expression.cs (This.ResolveBase): Update to changes.
13345 (ArglistAccess.DoResolve): Likewise.
13347 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13350 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13352 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13353 not used and not used & assigned.
13354 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13356 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13359 * expression.cs (Is.DoResolve): null is never provided type.
13361 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13364 * cs-parser.jay: Less strict event error rule to catch more errors.
13366 2005-07-08 Martin Baulig <martin@ximian.com>
13368 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13369 gettter (allowed) or setter (not allowed).
13371 * class.cs (Accessor): Implement IIteratorContainer.
13372 (Accessor.Yields): New public field.
13373 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13374 per-accessor basis.
13377 (get_accessor_declaration, set_accessor_declaration): Set the
13378 `yields' flag on the accessor, not the property.
13379 (property_declaration): Do the iterators check on a per-accessor
13380 basis and not for the whole property.
13382 2005-07-08 Martin Baulig <martin@ximian.com>
13384 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13385 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13387 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13390 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13391 (ExtractSecurityPermissionSet): Cope with self referencing security
13392 attributes properly.
13394 * driver.cs (SetOutputFile): Made public property OutputFile.
13396 2005-07-07 Raja R Harinath <rharinath@novell.com>
13399 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13400 has_nonstatic_fields. Make into a FieldBase pointer.
13401 (TypeContainer.AddField): Add CS0282 check.
13402 (TypeContainer.EmitType): Update.
13404 2005-07-06 Miguel de Icaza <miguel@novell.com>
13406 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13407 compare if they start with __.
13409 2005-07-06 Raja R Harinath <rharinath@novell.com>
13411 * statement.cs (Switch.SwitchGoverningType): Only look at
13412 UserCasts that don't need implicit standard conversions to one of
13413 the allowed switch types (Fixes test-322.cs).
13414 (LocalInfo.Resolve): Re-enable sanity-test.
13416 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13418 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13420 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13422 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13424 2005-07-06 Raja R Harinath <rharinath@novell.com>
13427 * ecore.cs (SimpleName.GetSignatureForError): Add.
13428 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13429 (MemberAccess.GetSignatureForError): Add.
13431 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13433 The big error and warning messages review.
13463 * typemanager.cs: Updated.
13465 * class.cs: (MethodCore.SetYields): Moved here to share.
13466 (PropertyMethod.Define): Moved iterator setup here.
13468 * iterators.cs: Add orig_method to have full access to parent
13471 2005-07-05 Raja R Harinath <rharinath@novell.com>
13473 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13474 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13475 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13476 variable of struct type.
13477 * expression.cs (Unary.ResolveOperator): Update to change.
13478 (Indirection.VerifyFixed): Likewise.
13479 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13480 (ParameterReference.VerifyFixed): Value parameters are fixed.
13481 (This.VerifyFixed): Treat 'this' as a value parameter.
13482 * statement.cs (LocalInfo.IsFixed): Remove.
13484 2005-07-01 Martin Baulig <martin@ximian.com>
13486 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13487 `ec.EmitThis ()' to get the correct scope.
13489 2005-07-01 Martin Baulig <martin@ximian.com>
13491 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13492 instance is a ParameterReference; fixes #75299.
13494 2005-07-01 Martin Baulig <martin@ximian.com>
13496 Reverted Marek's latest patch (r46725):
13497 - it contains structural changes which are neither mentioned in
13498 the ChangeLog nor explained anywhere; for example the additional
13499 argument of EmitContext's and Iterator's .ctor's and the
13500 TypeContainer.DefineMembers() change.
13501 - structural changes like this should go in in seperate patches
13502 and not be hidden in a huge patch which just seems to affect
13503 warnings and errors.
13504 a big and hard to understand patch.
13505 - it breaks iterators and causes regressions, for instance in
13508 2005-06-30 Raja R Harinath <rharinath@novell.com>
13511 * expression.cs (Indexers.map): Remove.
13512 (Indexers.Append): Filter out inaccessible setters and getters.
13513 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13516 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13517 Refactored from ...
13518 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13519 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13520 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13521 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13523 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13526 * class.cs (FieldBase.GetInitializerExpression): One more field
13529 2005-06-28 Miguel de Icaza <miguel@novell.com>
13531 * pending.cs: Do not define a proxy if the base method is virtual,
13532 it will be picked up by the runtime (bug 75270).
13534 2005-06-08 Martin Baulig <martin@ximian.com>
13536 The big Iterators rewrite :-)
13538 * iterators.cs: Rewrite this to use the anonymous methods framework.
13540 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13541 before the TypeContainers; see 2test-21.cs.
13544 (TypeContainer.DefineType): Don't create a new EmitContext if we
13545 already have one (this only happens if we're an Iterator).
13546 (TypeContainer.Define): Also call Define() on all our iterators.
13547 (Method.CreateEmitContext): Added support for iterators.
13550 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13551 (AnonymousContainer.CreateMethodHost): Moved here from
13552 AnonymousMethod and made abstract.
13553 (AnonymousContainer.CreateScopeType): New abstract method.
13554 (AnonymousContainer.IsIterator): New public property.
13555 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13556 get the ScopeTypeBuilder rather than manually defining it here.
13557 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13560 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13561 before RootContext.DefineTypes().
13563 * codegen.cs (EmitContext.RemapToProxy): Removed.
13564 (EmitContext.CurrentAnonymousMethod): Changed type from
13565 AnonymousMethod -> AnonymousContainer.
13566 (EmitContext.ResolveTopBlock): Protect from being called twice.
13567 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13568 (EmitContext.EmitThis): Removed the iterators hacks; use the
13569 anonymous methods framework for that.
13572 (ToplevelBlock.Container): Make this a property, not a field.
13573 (ToplevelBlock.ReParent): New public method; move the
13574 ToplevelBlock into a new container.
13575 (Foreach.TemporaryVariable): Simplify.
13577 2005-06-05 Martin Baulig <martin@ximian.com>
13579 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13580 (Block.AddTemporaryVariable): New public method; creates a new
13581 `LocalInfo' for a temporary variable.
13582 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13584 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13585 non-iterator variables.
13587 2005-06-05 Martin Baulig <martin@ximian.com>
13589 * statement.cs (Foreach.TemporaryVariable): Create the
13590 LocalBuilder in the Emit phase and not in Resolve since in some
13591 situations, we don't have an ILGenerator during Resolve; see
13592 2test-19.cs for an example.
13594 2005-06-04 Martin Baulig <martin@ximian.com>
13596 **** Merged r45395 from GCS ****
13598 The big Foreach rewrite - Part II.
13600 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13601 with `PropertyInfo ienumerator_getcurrent'.
13603 * codegen.cs (VariableStorage): Removed.
13606 (Foreach): Derive from Statement, not ExceptionStatement.
13607 (Foreach.CollectionForeach): New nested class. Moved all the code
13608 dealing with collection foreach here.
13609 (Foreach.ForeachHelperMethods): Removed.
13610 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13612 2005-05-23 Martin Baulig <martin@ximian.com>
13614 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13615 don't need to. Fix #75014.
13617 2005-05-20 Martin Baulig <martin@ximian.com>
13619 Merged r44808 from GMCS.
13621 * class.cs (TypeContainer.CircularDepException): Removed.
13622 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13623 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13624 (CS0146) and interface (CS0529) dependencies here.
13626 2005-06-21 Raja R Harinath <rharinath@novell.com>
13628 * expression.cs (Invocation.EmitCall): Fix initialization
13629 'this_call' to reflect current behaviour. Fix indentation.
13631 * convert.cs (FindMostEncompassedType): Add two trivial special
13632 cases (number_of_types == 0 || number_of_types == 1).
13633 (FindMostEncompasingType): Likewise.
13635 2005-06-17 Raja R Harinath <rharinath@novell.com>
13637 Some cleanups preparing for the fix of #75283.
13638 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13640 (EventExpr.InstanceResolve): Likewise.
13641 (EventExpr.DoResolve): Remove redundant checks.
13643 2005-06-10 Duncan Mak <duncan@novell.com>
13645 * cs-tokenizer.cs (process_directives): New flag for controlling
13646 the processing of preprocessor directives.
13647 (x_token): After seeing a '#', return Token.NONE instead of going
13648 to handle_preprocessing_directive() when not processing
13649 directives. This avoids unnecessary processing during the token peek in
13654 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13655 the existing error reporting methods instead of Report.Error.
13657 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13658 after Raja's rewrite.
13660 2005-06-08 Miguel de Icaza <miguel@novell.com>
13662 * class.cs: Small fix.
13664 2005-06-08 Raja R Harinath <rharinath@novell.com>
13667 * class.cs (GetPartialBases): Fix return value check of
13668 part.GetClassBases.
13670 2005-06-07 Raja R Harinath <rharinath@novell.com>
13672 Ensure that partial classes are registered in their enclosing
13673 namespace. Initial part of fix of #75160.
13674 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13675 Register declspace with namespace here, not in
13676 DeclSpace.RecordDecl.
13677 * cs-parser.jay: Pass namespace to RecordDecl.
13678 * class.cs (PartialContainer.Create): Likewise.
13679 (ClassPart.DefineType): New sanity-check. Throws an exception if
13681 * decl.cs (Declspace.RecordDecl): Remove.
13682 * namespace.cs (NamespaceEntry.DefineName): Remove.
13684 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13686 * rootcontext.cs: Reset TargetExt as well.
13688 2005-06-03 Raja R Harinath <rharinath@novell.com>
13690 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13691 -langversion:ISO-1.
13693 2005-06-02 Raja R Harinath <rharinath@novell.com>
13695 Fix #75080, cs0119.cs.
13696 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13698 (Expression.Resolve): ... this. Use it. Remove bogus code
13699 allowing ExprClass.Type and ExprClass.Namespace for
13700 ResolveFlags.VariableOrValue.
13701 (Expression.Resolve) [1-argument variant]: Change default resolve
13702 flags based on language version.
13703 (Expression.Error_UnexpectedKind): Use a simple string array
13704 rather than an ArrayList.
13705 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13706 not ExprClass.Type.
13707 (TypeOfVoid.DoResolve): Likewise.
13708 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13709 flags argument -- it always has the same value.
13711 2005-05-31 Raja R Harinath <rharinath@novell.com>
13714 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13715 Use it in the error message.
13716 * assign.cs, expression.cs, statement.cs: Update.
13718 2005-05-30 Raja R Harinath <rharinath@novell.com>
13721 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13722 the "almostMatchedMember" case too.
13723 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13724 that failed the accessibility checks to 'almost_match'.
13726 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13728 * attribute.cs: Use internal MethodBuilder methods to set
13729 ExactSpelling and SetLastError on PInvoke methods, instead
13730 of passing them via charset. Fixes #75060.
13732 2005-05-27 Raja R Harinath <rharinath@novell.com>
13734 * parameter.cs (Parameter): Remove TODO comment.
13735 (Parameter.DefineParameter): Remove Location parameter.
13736 (Parameters.LabelParameters): Likewise.
13737 * class.cs (Constructor.Emit): Update to change.
13738 (MethodData.Emit): Likewise.
13739 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13740 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13742 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13745 Removed Parameters.Location and added Parameter.Location instead.
13746 Removed Location parameter from Emit() and GetSignature().
13753 Modified all related calls.
13755 2005-05-26 Raja R Harinath <rharinath@novell.com>
13757 Improve user-defined conversion handling.
13758 * convert.cs (GetConversionOperators): Rewrite. Return only the
13759 applicable operators.
13760 (AddConversionOperators): New. Helper for GetConversionOperators.
13761 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13762 there is only one most encompassed/encompassing type.
13763 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13764 "applicable operator" handling.
13765 (UserConversion): Move cache here from GetConversionOperators.
13766 Directly cache the chosen operator, rather than the whole
13768 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13769 case. Allow conversion of decimal to sbyte and byte too.
13770 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13771 New static methods. Used to avoid allocating EmptyExpressions in
13774 2005-05-24 Duncan Mak <duncan@novell.com>
13776 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13777 another class, used in Convert.ExplicitNumericConversion.
13778 (CastToDecimal): New class, similar to above, but casts to
13779 System.Decimal, used in Convert.ImplicitNumericConversion and also
13780 in explicit convesion from double/float to decimal.
13782 * convert.cs (ImplicitNumericConversion): Handle implicit
13783 conversions to System.Decimal.
13784 (ExplicitNumericConversion): handle explicit conversions to
13789 2005-05-20 Miguel de Icaza <miguel@novell.com>
13791 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13792 know the type at this stage, just break through. Fixes #75008
13794 2005-05-19 Martin Baulig <martin@ximian.com>
13797 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13798 to disable error reporting.
13800 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13801 here since we don't want to report an error; see the new test-336.cs.
13803 2005-05-19 Raja R Harinath <rharinath@novell.com>
13805 * statement.cs (ToplevelBlock.GetParameterReference)
13806 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13807 Move here from class Block.
13808 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13809 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13811 2005-05-18 Martin Baulig <martin@ximian.com>
13816 (FlowBranching.Reachability): Add non-static public And() and Or()
13818 (FlowBranchingSwitch): New class; do the `break_origins' thing
13819 like in FlowBranchingLoop.
13820 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13821 reachability, not just locals and parameters.
13822 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13823 switch; MergeBreakOrigins() now takes care of that.
13825 2005-05-18 Martin Baulig <martin@ximian.com>
13827 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13828 a loop and may leave it, reset the barrier; fixes #74974.
13830 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13832 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13835 * cs-parser.jay: Catch more lexical errors.
13837 * report.cs: Add one more Error method.
13840 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13842 2005-05-17 Martin Baulig <martin@ximian.com>
13844 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13847 2005-05-16 Raja R Harinath <rharinath@novell.com>
13849 Fix test-382.cs. Emit values of decimal constants.
13850 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13852 (TypeContainer.AddField): ... this.
13853 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13854 with initializers to include 'Const's.
13855 (ClassPart.RegisterFieldForInitialization): Forward to
13857 * const.cs (Const.Const): Pass initializer to base class.
13858 (Const.Define): In case of decimal constants, register them for
13859 initialization in a static constructor.
13861 2005-05-14 Martin Baulig <martin@ximian.com>
13863 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13864 do not call ResolveUnreachable() on unreachable statements in
13865 here, see the comment in the source code.
13867 2005-05-13 Raja R Harinath <rharinath@novell.com>
13870 * expression.cs (BinaryResolveOperator): If one of the operands of
13871 an equality comparison is 'null' and the other is a pointer type,
13872 convert the null to a NullPointer.
13873 * convert.cs (ImplicitReferenceConversion): If the expression is a
13874 NullLiteral and the target type is a pointer type, return a
13875 NullPointer instead.
13876 (ImplicitConversionStandard): Likewise.
13878 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13880 * cs-parser.jay: Set readonly context based on special constructs.
13882 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13883 readonly variable error handling.
13885 * rootcontext.cs (EmitCode): Don't verify members when error
13888 * statement.cs (LocalInfo): Add reaodnly context information.
13889 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13891 2005-05-13 Raja R Harinath <rharinath@novell.com>
13893 * statement.cs (Block.Resolve): Revert change below. Modify fix
13894 for #74041 to initialize 'resolved' to false only for explicit
13895 blocks. Fixes #74873.
13897 2005-05-12 Raja R Harinath <harinath@gmail.com>
13900 * typemanager.cs (unmanaged_enclosing_types): New.
13901 (IsUnmanagedType): Avoid infloops by using
13902 'unmanaged_enclosing_types' to talk with recursive invocations.
13904 2005-05-13 Martin Baulig <martin@ximian.com>
13906 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13907 instance variable, not a local. Fix #74873.
13908 (Block.ResolveUnreachable): Set it to true here.
13910 2005-05-11 Duncan Mak <duncan@novell.com>
13912 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13913 continuing to process for 'arg'.
13914 (handle_preprocessing_directive): Check the argument of the #endif
13915 directive and report error CS1025 if there are any trailing
13918 According to the C# spec, having even whitespace after the #endif
13919 directive is illegal; however, because we call arg.TrimEnd ()
13920 beforehand, we have the same behavior as csc, allowing whitespace
13921 after the directive.
13925 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13929 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13930 (Constructor.GetObsoleteAttribute): Implemented correctly.
13932 2005-05-10 Martin Baulig <martin@ximian.com>
13934 * support.cs (ReflectionParameters.ParameterModifier): Use
13935 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13936 and `ParameterAttributes.In'. Fixes #74884.
13938 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13940 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13942 * expression.cs (Argument.GetParameterModifier): Turned to property.
13943 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13945 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13948 2005-05-09 Raja R Harinath <rharinath@novell.com>
13951 * decl.cs (MemberCache.AddMethods): Register override methods,
13952 rather than non-override methods.
13953 * typemanager.cs (RegisterOverride): New.
13954 (IsOverride): Update.
13956 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13960 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13961 recursive declaration.
13963 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13965 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13967 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13969 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13971 2005-05-05 Raja R Harinath <rharinath@novell.com>
13974 * decl.cs (DeclSpace.FamilyAccessible):
13975 Use TypeManager.IsNestedFamilyAccessible.
13977 Fix reopened #64812.
13978 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13981 2005-05-04 Raja R Harinath <rharinath@novell.com>
13982 Abin Thomas <projectmonokochi@rediffmail.com>
13983 Anoob V E <projectmonokochi@rediffmail.com>
13984 Harilal P R <projectmonokochi@rediffmail.com>
13987 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13988 allow access to all static members.
13990 2005-05-04 Martin Baulig <martin@ximian.com>
13992 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13994 2005-05-04 Martin Baulig <martin@ximian.com>
13998 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13999 section at the end; make things work if `default' is not the last
14002 2005-05-04 Martin Baulig <martin@ximian.com>
14006 * statement.cs (Switch): Replaced the `got_default' field with a
14007 `default_section' one.
14008 (Switch.CheckSwitch): Set `default_section' here.
14009 (Switch.Resolve): If we're a constant switch and the constant is
14010 not found, use the default section.
14012 2005-05-03 Martin Baulig <martin@ximian.com>
14014 * expression.cs (ArrayAccess.EmitGetLength): New public method.
14016 * statement.cs (Foreach.ArrayForeach): New nested class.
14017 (Foreach.TemporaryVariable): New nested class.
14018 (Foreach.EmitArrayForeach): Removed; this is now in the new
14019 ArrayForeach class.
14021 2005-05-03 Raja R Harinath <rharinath@novell.com>
14023 * pending.cs (BaseImplements): Move the #74773 fix here. This is
14025 (VerifyPendingMethods): Revert change below.
14027 * typemanager.cs (IsOverride, RegisterNonOverride): New.
14028 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
14029 that used to trigger warning -28. Remove warning -28.
14030 * expression.cs (Invocation.OverloadResolve): Use
14031 TypeManager.IsOverride to distinguish override methods.
14034 * pending.cs (VerifyPendingMethods): If a base type implements the
14035 requested interface, don't bother checking individual methods of
14036 the base type. As a side-effect, this prevents the creation of
14037 unnecessary proxies.
14039 2005-05-02 Martin Baulig <martin@ximian.com>
14043 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
14044 Also `And' the locals if the old vector is null.
14045 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
14046 null; in this case we basically reset all the variables.
14048 2005-05-02 Martin Baulig <martin@ximian.com>
14052 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
14053 Added `FlowBranching branching' argument; always `and' the
14054 variables instead of `or'ing them unless we're an infinite loop.
14056 * statement.cs (While.Resolve): Create a new sibling unless we're
14059 2005-05-02 Martin Baulig <martin@ximian.com>
14063 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
14064 arguments; use it instead of creating a new TopLevelBlock.
14065 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
14066 our ConstructorInitializer.
14069 (TopLevelBlock.TopLevelBranching): New public property.
14070 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
14071 and create our `TopLevelBranching'.
14073 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
14074 anonymous method host, use `block.TopLevelBranching' rather than
14075 creating a new branching.
14077 2005-04-20 Miguel de Icaza <miguel@novell.com>
14079 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
14080 a ScopeInfo, if any of the current children is a child of the new
14081 entry, move those children there.
14083 2005-04-30 Martin Baulig <martin@ximian.com>
14085 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
14086 at the beginning of a SwitchSection. Fix #73335.
14088 2005-04-27 Marek Safar <marek.safar@seznam.cz>
14091 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
14093 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
14094 (FieldExpr.DoResolve): Obsolete members are ignored for field
14097 2005-04-26 Marek Safar <marek.safar@seznam.cz>
14099 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
14100 of arrays detection.
14102 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
14104 (Field.VerifyClsCompliance): Volatile fields are not compliant.
14106 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
14109 2005-04-25 Ben Maurer <bmaurer@ximian.com>
14111 * cs-parser.jay: Use the prefered version of -unsafe in error
14114 2005-04-22 Marek Safar <marek.safar@seznam.cz>
14116 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
14119 2005-04-20 John Luke <john.luke@gmail.com>
14121 * driver.cs: fix typo in error message, --outout to --output
14123 2005-04-20 Marek Safar <marek.safar@seznam.cz>
14125 * codegen.cs (InRefOutArgumentResolving): New field.
14127 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
14128 fields outside contructor.
14130 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
14132 2005-04-19 Miguel de Icaza <miguel@novell.com>
14134 * anonymous.cs (CaptureContext.EmitParameterInstance): The
14135 parameter code was not completed ever, so it was not as up-to-date
14136 as local variables. Must finish it.
14138 The bug fix was to compare the Toplevel of the block, not the
14139 current block. Thanks for Ben for pointing this out.
14141 2005-04-19 Raja R Harinath <rharinath@novell.com>
14143 * decl.cs (AddMethods): Use the declaring type of the problem
14144 method to determine if we want to squash a warning.
14146 2005-04-19 Marek Safar <marek.safar@seznam.cz>
14148 * attribute.cs: Removed debug output.
14150 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
14152 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
14155 2005-04-18 Raja R Harinath <rharinath@novell.com>
14158 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
14159 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
14160 all null comparisons against reference types.
14162 2005-04-18 Marek Safar <marek.safar@seznam.cz>
14165 * class.cs (TypeContainer.CircularDepException) New nested
14167 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
14168 (TypeContainer.DefineType): Removed error, reset InTransit before
14170 (Class.DefineType): Throw exception when is in Transit.
14171 Catch exception and report error.
14172 (Struct.DefineType): Throw exception when is in Transit.
14173 Catch exception and report error.
14174 (Interface.DefineType): Throw exception when is in Transit.
14175 Catch exception and report error.
14177 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
14178 handle nested exception handlers.
14180 * flowanalysis.cs (InTryWithCatch): New method, search for try with
14183 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
14184 InFinally and InCatch storage.
14186 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
14187 (Catch.Resolve): Set and Restore ec.InCatch.
14188 (Try.Resolve): Set and Restore ec.InFinally.
14189 (Try.HasCatch): True when try has catch.
14191 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
14193 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
14194 for the same event member, so exclude such cases from warning 419.
14197 2005-04-16 Miguel de Icaza <miguel@novell.com>
14199 * expression.cs (Binary.ResolveOperator): Apply patch from John
14200 Luke to fix bug 59864: operators &, | and ^ on enumerations
14201 require that the same enum type on both sides.
14203 * driver.cs: Add warnings to old flag usage, this is to assist
14204 people who produce Makefiles and hope that the Makefiles will be
14207 * class.cs (TypeContainer.EmitType): Moved the definition of the
14208 special $PRIVATE$ field from the resolve phase to the Emit phase.
14209 During resolve we do not know if we are a struct with
14210 HasExplicitLayout, we know this only after the attributes for the
14213 Set the FieldOffset to zero on the dummy field that we create for
14214 the class. Fixes 74590.
14216 2005-04-16 Raja R Harinath <rharinath@novell.com>
14219 * ecore.cs (PropertyExpr.resolved): New.
14220 (DoResolve): Use it to handle a case of double resolution here.
14221 Handle a case of identical-name-and-type-name.
14222 * expression.cs (ArrayCreation.CheckIndices): Avoid double
14223 resolution by storing the results of expression resolution back
14224 into the "probes" array.
14226 2005-04-15 Raja R Harinath <rharinath@novell.com>
14228 Fix cs0208-7.cs and cs0208-8.cs.
14229 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14230 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14231 error reporting to point out the reason a struct is not unmanaged.
14233 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14235 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14236 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14238 2005-04-13 Raja R Harinath <rharinath@novell.com>
14241 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14242 IdenticalNameAndTypeName here.
14243 (EventExpr.InstanceResolve): Likewise.
14245 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14247 C# 2.0 DefaultCharSetAttribute implementation
14249 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14250 which allows us to set GlobalNamespace for every resolve.
14251 (Attribute.ResolveArguments): Cut from Resolve.
14252 (Attribute.GetCharSetValue): Returns CharSet named argument.
14253 (Attribute.DefinePInvokeMethod): Gets default charset from
14255 (GlobalAttribute.ResolveAsTypeStep): Override.
14256 (GlobalAttribute.ResolveArguments): Override.
14258 * class.cs (TypeAttr): Is protected.
14260 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14261 (ModuleClass.DefaultCharSetType): New memeber.
14262 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14264 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14265 charset from module.
14267 * delegate.cs (TypeAttr): Override.
14268 (Delegate.DefineType): Use this TypeAttr.
14270 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14271 at very early stage (before types are defined) to resolve model
14272 module attributes. It will probably not work with corlib but it
14275 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14276 charset from module.
14278 * typemanager.cs (default_charset_type): New type.
14280 2005-04-13 Raja R Harinath <rharinath@novell.com>
14282 * decl.cs (MemberCache.AddMethods): Don't warn if
14283 System.Object.Finalize has buggy MethodAttributes.
14285 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14288 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14290 * doc.cs : detect ambiguous reference to overloaded members.
14291 Fixed bug #71603. MS 1.1 csc does not detect it.
14293 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14295 * doc.cs : delegates must not be referenced with parameters.
14298 2005-04-12 Miguel de Icaza <miguel@novell.com>
14300 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14302 2005-04-10 Miguel de Icaza <miguel@novell.com>
14304 * driver.cs (MainDriver): Stop processing if the CLS stage found
14307 (CompilerCallableEntryPoint.InvokeCompiler): Always
14308 reset after execution; Take a TextWriter argument for the
14311 * report.cs: Use the error stream instead of hardcoding stderr.
14313 2005-04-09 Miguel de Icaza <miguel@novell.com>
14315 * class.cs: Reduce code paths to test, too small of an
14316 optimization to make it worth the extra testing. Always perform
14319 2005-04-08 Raja R Harinath <rharinath@novell.com>
14322 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14323 operators that had errors reported on them.
14325 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14327 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14329 (Attribute.Resolve): Add named argument type checking.
14331 * class.cs (FixedField.Define): Use IsPrimitiveType
14333 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14335 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14336 unsafe parameter types.
14338 * statement.cs (Using.ResolveExpression): Add better error description.
14340 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14342 2005-04-08 Raja R Harinath <rharinath@novell.com>
14345 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14346 AttributeUsageAttribute in the emitcontext of the attribute class,
14347 not in the emitcontext of the attributable entity it was attached to.
14348 * cs-parser.jay: Use 'current_class', not 'current_container',
14349 when creating a GlobalAttribute.
14351 2005-04-08 Alp Toker <alp@atoker.com>
14353 * pending.cs: The fix to #58413 failed to compile methods implementing
14354 interfaces with/without params modifiers and vice versa, even though
14355 params modifiers aren't part of the signature. Make the modifier check
14356 less strict as in csc.
14358 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14359 Anoob V E <projectmonokochi@rediffmail.com>
14360 Harilal P R <projectmonokochi@rediffmail.com>
14363 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14364 modifiers of pending methods.
14365 (PendingImplementation.PendingImplementation): Initialize it.
14366 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14367 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14368 with ParameterData. Add check for modifiers.
14369 * class.cs (MethodData.Define): Update to changes.
14371 2005-04-07 Raja R Harinath <rharinath@novell.com>
14373 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14375 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14377 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14380 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14383 * typemanager.cs: Registered RequiredAttributeAttribute.
14385 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14387 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14388 Warning CS0169 is back at level 3.
14389 (IMethodData.SetMemberIsUsed): New method.
14391 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14392 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14394 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14396 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14398 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14401 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14404 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14405 to avoid the problems with nested types.
14407 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14408 Anoob V.E <projectmonokochi@rediffmail.com>
14409 Harilal P.R <projectmonokochi@rediffmail.com>
14410 Raja R Harinath <rharinath@novell.com>
14413 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14415 * typemanager (GetConstructor): Make public.
14417 2005-04-05 John Luke <john.luke@gmail.com>
14418 Raja R Harinath <rharinath@novell.com>
14421 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14422 struct too. Return false quicker in a few cases.
14423 (VerifyUnManaged): Use it.
14425 2005-04-05 Raja R Harinath <rharinath@novell.com>
14428 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14429 not 'unreachable_seen'.
14431 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14433 * attribute.cs (Attribute.GetValue): Removed unused.
14435 * codegen.cs (CodeGen.TrimExt): Removed unused.
14437 * cs-parser.jay (output): Removed unused.
14439 * cs-tokenizer.cs (hex_digits): Removed unused.
14441 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14443 * expression.cs (Indirection.LoadExprValue): Removed unused.
14444 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14446 * iterators.cs (Iterator.param_types): Removed unused.
14448 * statement.cs (Goto.block): Removed unused.
14449 (ToplevelBlock.did): Removed unused.
14450 (Switch.ResolveConstantSwitch): Removed unused.
14452 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14454 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14457 2005-04-01 Raja R Harinath <rharinath@novell.com>
14459 Fix #74232 and cs0208-3.cs.
14460 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14461 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14462 unmanaged type. Don't use FieldBuilders when 't' is a
14463 TypeBuilder. Use ModFlags and MemberType fields.
14464 * class.cs (MemberBase.member_type): Rename from MemberType.
14465 (MemberBase.MemberType): New property. Determines member_type on
14467 (MemberBase.DoDefine): Don't initialize MemberType here.
14468 (FieldMember.Define): Likewise.
14470 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14473 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14474 Attributes are emitted there.
14476 2005-04-01 Raja R Harinath <rharinath@novell.com>
14478 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14479 keyword in 'partial enum' too.
14480 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14482 Report from Kamil Skalski <nazgul@omega.pl>.
14485 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14486 have partial containers too.
14488 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14489 in block' checks to Block.CheckInvariantMeaningInBlock.
14490 * statement.cs (Block.GetKnownVariableInfo): Make private.
14491 (Block.IsVariableUsedInChildBlock): Remove.
14492 (Block.IsVariableUsedInBlock): Likewise.
14493 (Block.CheckInvariantMeaningInBlock): New. Show location of
14494 conflicting declaration.
14495 (Block.AddVariable): Make error messages less long-winded and more
14496 specific. Show location of conflicting declaration.
14497 * parameter.cs (Parameters.Location): New readonly property.
14499 2005-03-31 Raja R Harinath <rharinath@novell.com>
14501 Clean up semantics of invoking ResolveMemberAccess.
14502 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14503 can have an instance, ensure that we pass in a non-TypeExpression
14504 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14505 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14506 argument. Update to changes and simplify.
14507 (FieldExpr.Emitinstance): Remove CS0120 check.
14508 (PropertyExpr.EmitInstance): Likewise.
14509 * expression.cs (Argument.Resolve): Likewise.
14510 (Invocation.DoResolve): Update to changes in semantics of
14511 InstanceExpression.
14513 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14516 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14519 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14521 2005-03-31 Raja R Harinath <rharinath@novell.com>
14523 Fix difference in behaviour with commandline invocation.
14524 * driver.cs (Driver.Reset): New.
14525 (CompilerCallableEntryPoint): Call it.
14527 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14528 variable" warnings if the boolean expression failed to resolve.
14530 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14532 * attribute.cs: Fix the union of several permissions when some of them
14533 are unrestricted (so the result isn't an unrestricted permission set).
14536 2005-03-30 Raja R Harinath <rharinath@novell.com>
14538 * ecore.cs (MemberExpr): New class. Convert from interface
14540 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14541 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14543 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14544 (MethodGroupExpr.IsExplicitImpl): Remove.
14545 (Expression.GetFieldFromEvent): Remove.
14546 (SimpleName.MemberStaticCheck): Remove.
14547 (SimpleName.DoSimpleNameResolve): Update to changes.
14548 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14549 (MemberAccess.IdenticalNameAndTypeName): Remove.
14550 (MemberAccess.error176): Move to MemberExpr.
14551 (MemberAccess.DoResolve): Update to changes.
14552 (BaseAccess.DoResolve): Likewise.
14554 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14556 C# 2.0 Conditional attribute class implementation
14558 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14559 Analyzes class whether it has attribute which has ConditionalAttribute
14560 and its condition is not defined.
14562 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14563 (Class.IsExcluded): New method. Search for at least one defined
14564 condition in ConditionalAttribute of attribute class.
14566 2005-03-30 Raja R Harinath <rharinath@novell.com>
14568 * ecore.cs (PropertyExpr): Derive from Expression, not
14569 ExpressionStatement.
14570 (PropertyExpr.EmitStatement): Remove.
14572 2005-03-29 Raja R Harinath <rharinath@novell.com>
14575 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14576 internal field "value__" of an enum be private. The examples for
14577 "value__" that I found on MSDN all used FieldAttributes.Private.
14579 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14580 Don't mention IL method attribute names.
14582 Fix #47991. Remove a TODO.
14583 * statement.cs (Block.Toplevel): Make into a field.
14584 (Block.Parameters): Move into ToplevelBlock.
14585 (Block.known_variables): Rename from child_variable_names.
14586 (Block.Block): Remove variants that take Parameters. Initialize
14587 'Toplevel' with the immediately surrounding toplevel block.
14588 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14589 LocalInfo parameter.
14590 (Block.GetKnownVariableInfo): New.
14591 (Block.IsVariableNameUsedInChildBlock): Update.
14592 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14593 the block, even though it may not be in scope.
14594 (Block.AddVariable): Remove Parameters parameter. Use
14595 Toplevel.Parameters instead.
14596 (Block.AddConstant): Remove Parameters parameter.
14597 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14598 (Block.IsParamaterReference): Likewise.
14599 (Block.IsLocalParameter): Likewise. Simplify a lot.
14600 (ToplevelBlock.Parameters): New. Moved from Block.
14601 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14602 initialize Parameters to a non-null value.
14603 * cs-parser.jay: Update to changes.
14604 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14605 simple names that mean different things in the same block. Use
14606 Block.IsVariableNameUsedInBlock.
14608 2005-03-28 Raja R Harinath <rharinath@novell.com>
14610 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14611 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14612 GetTypeHandle. It is possible for a reflected type to derive from
14613 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14614 System.Array during mscorlib compilation).
14615 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14616 contain a method_hash, don't create one either. Don't create a
14617 deep copy of the base cache's method_hash.
14618 (MemberCache.SetupCache): Rename back from DeepCopy.
14619 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14620 already initialized. If we see an override function, add its
14621 underlying base virtual function to the member_hash too.
14623 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14625 2005-03-26 Raja R Harinath <harinath@acm.org>
14628 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14629 fails to resolve, ensure that the LHS is still resolved as an
14632 2005-03-25 Raja R Harinath <harinath@acm.org>
14634 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14636 (Enum.current_ec): Remove.
14637 (Enum.LookupEnumValue): Remove EmitContext argument.
14638 Just uses the one created during DefineType.
14639 (Enum.FindMembers): Update.
14640 * expression.cs (MemberAccess.DoResolve): Update.
14642 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14644 * assign.cs (Assign.DoResolve): Check for CS1717 when
14645 source and target are same (uses Equals).
14647 * expression.cs (LocalVariableReference, ParameterReference,
14648 This): Implemented Equals, GetHashCode.
14650 * statement.cs (Block.GetParameterReference): Removed useless
14653 2005-03-22 Raja R Harinath <rharinath@novell.com>
14656 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14657 blocks before deciding whether the error is cs0136 or cs0128.
14659 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14660 (using_alias_directive, using_namespace_directive): Pass
14661 MemberName, not an expression to Namespace.UsingAlias and
14663 (MakeName): Use the MemberName of the namespace.
14664 * namespace.cs (Namespace.MemberName): New.
14665 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14666 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14668 * decl.cs (MemberName.Name): Make readonly.
14669 (MemberName.FromDotted): New "constructor".
14670 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14671 (MemberCore.Name): Compute from MemberName on demand.
14672 (MemberCore.SetMemberName): Provide a way to change the
14674 (MemberCore.AddToContainer): Don't take a fullname parameter.
14675 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14676 fully qualified name of the container to the member name.
14677 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14678 only if the type is a member of the root container.
14679 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14680 MemberName.Left rather than searching for an embedded ".".
14681 (PartialContainer.CreatePart): Update to changes in RootContext.
14682 (MemberBase.ShortName): Turn into a property. Use
14683 MemberCore.SetMemberName.
14684 (MemberBase.ExplicitInterfaceName): Remove.
14685 (MemberBase.UpdateMemberName): Remove.
14686 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14687 (PropertyBase.SetMemberName): New override.
14688 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14689 (Tree.GetDecl): New.
14690 (Tree.AllDecls): Rename from Decls.
14691 * attribute.cs, enum.cs, report.cs: Update to changes.
14692 * driver.cs (MainDriver): Use MemberName.FromDotted on
14693 RootContext.MainClass.
14695 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14697 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14700 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14702 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14704 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14705 property accessor modifiers.
14707 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14708 fixed buffer attribute (CS1716).
14709 (PropertyMethod.HasCustomAccessModifier): When property accessor
14710 has custom modifier.
14712 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14714 (PropertyExpr.DoResolveLValue): Add CS0272.
14716 2005-03-17 Miguel de Icaza <miguel@novell.com>
14718 * convert.cs: When converting to a pointer, use the proper Conv.U
14719 or Conv.I depending on the source data type.
14721 * cs-tokenizer.cs: Make the size for large decimal constants,
14724 2005-03-17 Martin Baulig <martin@ximian.com>
14726 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14727 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14729 2005-03-17 Martin Baulig <martin@ximian.com>
14731 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14732 to bool so we can return an error condition.
14733 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14736 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14738 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14741 2005-03-16 Raja R Harinath <rharinath@novell.com>
14743 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14744 Refactor to avoid traversing the list of assemblies, and to avoid
14745 string concatenation.
14746 * typemanager.cs (guid_attr_type): Remove.
14747 (negative_hits, pointers, references): Remove hashes.
14749 (GetConstructedType): New. Uses type_hash to handle constructed
14750 types (arrays, references, pointers).
14751 (GetReferenceType, GetPointerType): Use it.
14752 (GetNestedType): New. Uses type_hash to handle nested types of
14754 (LookupType, LookupTypeDirect): Remove.
14755 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14756 'types' hash and LookupTypeReflection directly.
14757 (params_string, params_object): Use GetConstructedType.
14758 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14760 (Namespace.Lookup): Use cached_types.
14761 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14762 provided by old TypeManager.LookupType.
14763 * rootcontext.cs (MakeFQN): Remove.
14764 * decl.cs (DeclSpace.MakeFQN): Likewise.
14765 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14766 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14767 TypeManager.GetConstructedType.
14768 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14770 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14772 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14775 * cs-parser.jay: Reports CS1527 for any namespace element.
14777 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14780 * expression.cs (ParameterReference.IsAssigned): Changed error to
14782 (Error_WrongNumArguments): Moved CS0245 detection here.
14784 * statement.cs (Return.Resolve): Add CS1622 report.
14786 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14788 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14790 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14792 * attribute.cs expression.cs: Get rid of some allocations.
14794 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14796 * doc.cs : just eliminate the latest change.
14798 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14800 * doc.cs : commented out the latest change. It breaks xml-030.cs
14802 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14804 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14805 fail. So invoke CreateType() in FindDocumentedType().
14807 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14809 * cs-tokenizer.cs : added IsKeyword().
14810 * doc.cs : Detect keyword incorrectly used as identifier.
14811 Allow identifiers prefixed by @.
14813 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14815 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14816 It caused exception in namespace resolving (again!).
14818 * class.cs (Class.ctor): Removed exit.
14819 (PropertyMethod.ctor): ditto.
14821 * codegen.cs (Codegen.Reset): Reset static data.
14822 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14824 * cs-tokenizer.cs (Cleanup): Removed.
14826 * driver.cs (GetSystemDir): Rewrote to one line command.
14827 It caused problem with unloaded dynamic modules.
14828 (UnixParseOption): Removed Exit.
14829 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14830 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14831 Now can be mcs used as library.
14833 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14836 * location.cs (Reset): Reset static data.
14838 * namespace.cs (Reset): Reset static data.
14840 * report.cs (Report.Reset): Reset static data.
14842 * rootcontext.cs (RootContext.Reset): Reset static data.
14844 * tree.cs (RootTypes.ctor): Use Location.Null
14846 * typemanager.cs (TypeManager.Reset): Reset static data.
14847 (CoreLookupType): Removed Exit.
14848 (TypeHandle.Reset): Reset static data.
14850 2005-03-10 Raja R Harinath <rharinath@novell.com>
14853 * typemanager.cs (ComputeNamespaces): Import namespaces from
14854 referenced modules too.
14856 2005-03-09 Raja R Harinath <rharinath@novell.com>
14858 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14861 2005-03-09 Raja R Harinath <rharinath@novell.com>
14863 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14864 enclosing DeclSpace. This ensures that a name-lookup populates
14865 more caches and there are fewer 'TypeExpression's. Carve out
14866 nested type lookup into ...
14867 (LookupNestedTypeInHierarchy): ... this.
14869 2005-03-09 Raja R Harinath <rharinath@novell.com>
14871 Clean up a few partial-class semantics.
14872 Fixes test-357.cs and cs1618-2.cs.
14873 * cs-parser.jay (struct_declaration): Use 'current_class' as
14874 parent of newly-created struct. Remove call to Register ().
14875 Use 'pop_current_class' to complete handing the current struct.
14876 (interface_declaration): Likewise.
14877 (class_declaration): Likewise.
14878 (enum_declaration): Use 'current_class' as parent of newly created
14880 (delegate_declaration): Likewise.
14881 (pop_current_class): New function. This is used to handle closing
14882 up the 'current_class' and 'current_container', and pointing them
14883 to the enclosing class/container.
14884 (CSharpParser): Initialize 'current_class' too.
14885 * decl.cs (MemberCore): Add check for invariant: a partial
14886 container is not a parsed entity, and thus does not enclose any
14888 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14889 (DeclSpace.BaseTypeExpr): Use it.
14890 (DeclSpace.LookupType): Add check for invariant.
14891 * class.cs (TypeContainer): Add check for invariant: a nested
14892 class should have the same NamespaceEntry as its enclosing class.
14893 (TypeContainer.EmitFieldInitializers): Make virtual.
14894 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14896 (TypeContainer.Register): Remove.
14897 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14898 null. Use TypeResolveEmitContext for resolving base types and
14899 interfaces. Move initialization of Parts.TypeBuilder here from
14901 (TypeContainer.DefineNestedTypes): ... here.
14902 (PartialContainer): Take a Namespace not a NamespaceEntry.
14903 (PartialContainer.Create): Don't use Register. Call the
14904 appropriate Add... function directly.
14905 (ClassPart): Take both the PartialContainer and the enclosing
14906 class as constructor arguments.
14907 (ClassPart.EmitFieldInitializers): Override.
14908 (ClassPart.PartFindNestedTypes): Remove.
14909 (FieldBase.GetInitializerExpression): Resolve the initializer
14910 expression in the emit context of the enclosing class.
14911 * tree.cs (RootTypes): Remove Register ().
14913 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14915 * cs-parser.jay: Removed CS0134.
14917 * driver.cs: Removed CS1901.
14919 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14920 for predefined types.
14922 2005-03-07 Duncan Mak <duncan@novell.com>
14924 * codegen.cs (Save): Catch UnauthorizedAccessException as
14925 well. Fixes bug #73454.
14927 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14929 * cs-tokenizer.cs (xtoken): Add CS1035.
14931 * class.cs (MethodData.Define): Add CS0683.
14932 (FieldMember.ctor): Add CS0681.
14934 2005-03-07 Raja R Harinath <rharinath@novell.com>
14936 * ecore.cs (SimpleName.DoResolve): Rename from
14937 SimpleName.DoResolveAllowStatic.
14938 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14939 Pass 'intermediate' flag to MemberStaticCheck.
14940 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14941 of "intermediate" lookups via MemberAccess.
14942 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14943 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14945 2005-03-07 Raja R Harinath <rharinath@novell.com>
14948 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14949 slipped in because of variable names that are identical to a
14950 builtin type's BCL equivalent ('string String;', 'int Int32;').
14951 (PropertyExpr.EmitInstance): Likewise.
14953 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14955 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14957 * report.cs (warning_ignore_table): Made public.
14959 2005-03-04 Raja R Harinath <rharinath@novell.com>
14962 * class.cs (MethodData.Emit): Pass 'container' to
14963 container.GetObsoleteAttribute instead of 'container.Parent'.
14965 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14967 * cs-parser.jay: Add 1534 error test.
14969 * iterators.cs (Yield.CheckContext): Add error 1629.
14970 (Iterator.ctor): Save unsafe modifier.
14971 (MoveNextMethod.DoEmit): Restore unsafe context.
14973 * namespace.cs (UsingAlias): Better error message.
14975 2005-03-03 Dan Winship <danw@novell.com>
14977 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14978 the warning message [#73219]
14980 2005-03-03 Raja R Harinath <rharinath@novell.com>
14982 Fix compile with MCS 1.0.0.0.
14983 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14984 w_restore to not depend on string constant folding.
14986 2005-03-03 Raja R Harinath <rharinath@novell.com>
14988 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14989 CS0246 check to users who passed 'silent = false'.
14990 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14992 (SimpleName.SimpleNameResolve): Update.
14993 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14994 (MemberAccess.IdenticalNameAndTypeName): Update.
14995 * doc.cs (FindDocumentedTypeNonArray): Update.
14997 2005-03-03 Raja R Harinath <rharinath@novell.com>
14999 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
15000 * parameters.cs (ComputeAndDefineParameters): Remove.
15001 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
15002 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
15003 Use GetParameterInfo.
15005 2005-03-02 Marek Safar <marek.safar@seznam.cz>
15007 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
15009 2005-03-02 Raja R Harinath <rharinath@novell.com>
15011 Unify DeclSpace.LookupType and DeclSpace.FindType.
15012 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
15013 is in charge of defining nested types on demand.
15014 (DeclSpace.LookupType): Use it when the current_type is a
15015 TypeBuilder. Use LookupTypeDirect for reflected types.
15016 (DeclSpace.FindType): Remove.
15017 (DeclSpace.LookupInterfaceOrClass): Likewise.
15018 (DeclSpace.DefineTypeAndParents): Likewise.
15019 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
15020 DeclSpace.LookupType.
15021 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
15022 * typemanager.cs (LookupType): Simplify.
15023 (AddUserType): Remove type from negative_hits.
15024 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
15025 * class.cs (TypeContainer.FindMembers): Move handling of nested
15027 (TypeContainer.FindMembers_NestedTypes): ... here.
15028 (TypeContainer.FindNestedType): Implement override.
15029 (ClassPart.FindNestedType): Delegate to PartialContainer.
15030 (ClassPart.PartFindNestedType): Looks up the nested types of the
15033 2005-03-02 Martin Baulig <martin@ximian.com>
15035 * class.cs (TypeContainer.DoDefineMembers): We also need a default
15036 static constructor in static classes.
15038 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
15040 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
15041 sizeParamIndex is not specified.
15043 2005-03-01 Marek Safar <marek.safar@seznam.cz>
15046 * report.cs (WarningMessage.IsEnabled): Missing null check.
15048 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15050 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
15051 in the fields and not in the properties.
15053 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
15055 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
15058 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15060 * attribute.cs: Small refactoring (improved robustness).
15061 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
15062 (ValidateGuid): Removed.
15063 (Resolve): Removed referenced to above mentioned.
15064 (GetAttributeUsage): Made private and changed to work without
15066 (GetIndexerAttributeValue): Don't crash.
15067 (GetConditionalAttributeValue): Ditto.
15068 (GetClsCompliantAttributeValue): Ditto.
15069 (ExtractSecurityPermissionSet): All attributes exceptions are
15071 (GetPropertyValue): New helper.
15072 (GetMethodImplOptions): New method.
15073 (DefinePInvokeMethod): Reuse common code. Implemented handling of
15074 some missing properties.
15076 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
15077 (Method.ApplyAttributeBuilder): Updated.
15079 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
15082 2005-02-28 Raja R Harinath <rharinath@novell.com>
15085 * report.cs (Report.SymbolRelatedToPreviousError): Handle
15086 non-simple types (array, pointer, reference).
15088 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15090 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
15092 * class.cs (MethodCore.IsDuplicateImplementation): Special error
15094 (Method.CheckBase): Catch wrong destructor here.
15095 (MethodData.Define): Add errors 550, 668.
15097 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
15099 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
15101 * pending.cs (VerifyPendingMethods): Add error 551.
15103 * typemanager.cs (CSharpName): Next error report helper.
15105 2005-02-25 Marek Safar <marek.safar@seznam.cz>
15107 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
15108 attributes. Removed useless attribute double check.
15109 It saves almost 2MBs for corlib.
15111 2005-02-25 Raja R Harinath <rharinath@novell.com>
15114 * statement.cs (ExpressionStatement.Resolve): Make robust to being
15115 called twice in case of error.
15117 2005-02-23 Chris Toshok <toshok@ximian.com>
15119 Fix compiler portions of #72827.
15120 * statement.cs (Block.Emit): call Begin/EndScope on the
15121 EmitContext instead of the ILGenerator.
15123 * codegen.cs (EmitContext.BeginScope): new method, call
15124 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
15126 (EmitContext.BeginScope): same, but EndScope and CloseScope
15128 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
15129 offset and call the superclass's OpenScope(int) with it.
15130 (SymbolWriter.CloseScope): get the current il
15131 offset and call superclass's CloseScope(int) with it.
15133 2005-02-23 Marek Safar <marek.safar@seznam.cz>
15135 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
15136 CS1677 for out and ref as well.
15138 * class.cs (Method.Define): Add error CS1599 detection.
15140 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
15142 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
15144 * delegate.cs (Delegate.Define): Add error CS1599 detection.
15146 * support.cs.cs (ModifierDesc): New helper method.
15148 2005-02-23 Raja R Harinath <rharinath@novell.com>
15149 Abin Thomas <projectmonokochi@rediffmail.com>
15150 Anoob V E <projectmonokochi@rediffmail.com>
15151 Harilal P R <projectmonokochi@rediffmail.com>
15153 Fix #57851, #72718.
15154 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
15155 MemberLookup (used for error reporting) actually returns a result.
15156 Fix error report number (122, not 112).
15158 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
15159 Anoob V E <projectmonokochi@rediffmail.com>
15160 Harilal P R <projectmonokochi@rediffmail.com>
15163 * pending.cs (PendingImplementation.GetAbstractMethods):
15164 Find NonPublic members too.
15166 2005-02-22 Marek Safar <marek.safar@seznam.cz>
15168 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
15171 * class.cs (MethodCore.CheckMethodAgainstBase):
15172 Add error 239 report.
15174 2005-02-21 Raja R Harinath <rharinath@novell.com>
15177 * expression.cs (Invocation.IsApplicable): Make public.
15178 (Invocation.IsParamsMethodApplicable): Likewise.
15179 * delegate.cs (Delegate.VerifyApplicability): Don't use
15180 Invocation.VerifyArgumentCompat for parameter applicability
15181 testing. Use Invocation.IsApplicable and
15182 Invocation.IsParamsMethodApplicable.
15184 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15186 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
15188 * class.cs (Operator.Define): Add error 217 report.
15190 2005-02-21 Raja R Harinath <rharinath@novell.com>
15192 * namespace.cs (UsingEntry.Resolve): Undo change below.
15194 2005-02-21 Raja R Harinath <rharinath@novell.com>
15197 * ecore.cs (Expression.MemberLookupFailed): Add argument to
15198 disable the error message when the extended MemberLookup also
15200 (Expression.MemberLookupFinal): Update.
15201 (SimpleName.DoSimpleNameResolve): Update.
15202 * expression.cs (MemberAccess.ResolveNamespaceOrType):
15203 Don't use MemberLookupFinal.
15204 (New.DoResolve): Update.
15205 (BaseAccess.CommonResolve): Update.
15207 2005-02-21 Raja R Harinath <rharinath@novell.com>
15210 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
15211 occured previously, don't resolve again.
15213 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15216 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
15217 argument. Call ResolveAttributeUsage for unresolved.
15218 when types doesn't match ctor arguments.
15220 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
15221 for nested attribute classes.
15222 (Class.attribute_usage): Removed.
15223 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
15224 for attribute class.
15226 * ecore.cs (IsAttribute): Removed.
15228 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15230 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15232 (attribute_types): Removed.
15233 (EmitCode): Global attributes are emited as the latest.
15235 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15237 * class.cs (EmitFieldInitializers): Don't emit field initializer
15238 for default values when optimilization is on.
15240 * constant.cs (Constant.IsDefaultValue): New property.
15242 * driver.cs: Add /optimize handling.
15246 * literal.cs: Implement new IsDefaultValue property.
15248 * rootcontext.cs (Optimize): New field, holds /optimize option.
15250 2005-02-18 Raja R Harinath <rharinath@novell.com>
15252 Fix crasher in re-opened #72347.
15253 * namespace.cs (Namespace.Lookup): Return null if
15254 DeclSpace.DefineType returns null.
15257 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15259 2005-02-18 Raja R Harinath <rharinath@novell.com>
15261 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15262 now returns null if it cannot resolve to an lvalue.
15263 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15264 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15265 returned null. Remove check for SimpleName.
15266 (EventExpr.DoResolveLValue): New.
15267 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15268 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15270 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15271 avoid CS0131 error.
15272 (Unary.ResolveOperator): Move CS0211 check ...
15273 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15275 (Unary.DoResolveLValue): Simplify.
15276 (AddressOf.DoResolveLValue): New.
15277 (ArrayAccess.DoResolveLValue): New.
15279 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15281 * attribute.cs (Attribute.Resolve): Add arguments casting for
15282 when types doesn't match ctor arguments.
15284 2005-02-16 Raja R Harinath <rharinath@novell.com>
15286 Fix parts of #63202.
15287 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15288 lookup of operator in base type. Ensure that all checks happen
15289 when the operator resolves to an "op_..." method.
15291 2005-02-15 Raja R Harinath <rharinath@novell.com>
15294 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15295 'ignore_cs0104' parameter. Pass it to ...
15296 (NamespaceEntry.Lookup): ... this.
15297 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15298 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15299 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15300 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15301 Update. Request that cs0104 errors be ignored.
15302 (ComposedCast.ResolveAsTypeStep): Update.
15304 2005-02-14 Raja R Harinath <rharinath@novell.com>
15307 * expression.cs (Invocation.BetterFunction): Remove support for
15308 comparing virtual functions and their overrides.
15309 (Invocation.IsOverride): New.
15310 (Invocation.OverloadResolve): Don't consider 'override' functions
15311 during candidate selection. Store them in a lookaside list.
15312 If the selected method is a 'virtual' function, use the list to
15313 find any overrides that are closer to the LHS type.
15315 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15317 * expression.cs (New.DoResolve): Add complex core type reduction.
15318 (New.Constantify): Converts complex core type syntax like 'new int ()'
15319 to simple constant.
15321 2005-02-14 Raja R Harinath <rharinath@novell.com>
15323 * decl.cs (EntryType.EntryType): New constructor to create an
15324 updated copy of a cache entry.
15325 (MemberCache.AddMethods): Use it.
15326 (MemberCache.ClearDeclaredOnly): Remove.
15327 (MemberCache.MemberCache): Update.
15329 2005-02-11 Miguel de Icaza <miguel@novell.com>
15331 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15332 variable. This one is represents the actual low-level declaration
15333 of the method, as opposed to the semantic level `IsStatic'.
15335 An anonymous method which is hosted into a static method might be
15336 actually an instance method. IsStatic would reflect the
15337 container, while MethodIsStatic represents the actual code
15340 * expression.cs (ParameterReference): Use the new MethodIsStatic
15341 instead of IsStatic.
15343 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15344 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15345 set on the current EmitContext.
15347 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15348 resolve our casted expression as an LValue. This triggers the
15349 proper LValue processing that is later required by Assign.
15353 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15355 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15357 C# 2.0 Fixed buffer implementation
15359 * anonymous.cs: Update after RegisterHelperClass renaming.
15361 * attribute.cs (AttributeTester.fixed_buffer_cache):
15362 Cache of external fixed buffers.
15363 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15364 implementation if field is fixed buffer else null.
15367 (TypeContainer.AddField): Accept FieldMember instead of Field.
15368 (FieldBase.IsFieldClsCompliant): Extracted code from
15369 VerifyClsCompliance descendant customization.
15370 (FixedField): New class handles fixed buffer fields.
15371 (FixedFieldExternal): Keeps information about imported fixed
15373 (IFixedField): Make access to internal or external fixed buffer
15376 * cs-parser.jay: Add fixed buffer parsing.
15378 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15381 * expression.cs (Indirection): Extended implementation to accept
15382 fixed buffer field.
15383 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15384 (ElementAccess.MakePointerAccess): Get type as parameter.
15385 (DoResolve): Add fixed buffer field expression conversion.
15386 (DoResolveLValue): Ditto.
15387 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15388 (ArrayPtr): Derives from FixedBufferPtr.
15389 (ArrayPtr.Emit): Add extra emit for array elements.
15391 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15393 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15394 for compiler generated types.
15395 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15397 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15398 and consume less memory.
15399 (Fixed.Resolve): Add fixed buffer case.
15401 * typemanager.cs (compiler_generated_attr_ctor,
15402 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15403 (HasElementType): Add our own implementation to work on every
15406 2005-02-11 Miguel de Icaza <miguel@novell.com>
15408 * anonymous.cs (CaptureContext): Track whether `this' has been
15411 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15412 only captured `this' if it was implicitly done (instance
15413 methods/variables were used).
15415 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15416 `this' must be captured.
15418 2005-01-30 Miguel de Icaza <miguel@novell.com>
15420 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15421 is null it means that there has been no need to capture anything,
15422 so we just create a sibling.
15424 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15426 Just a partial fix. The other half is fairly elusive.
15428 2005-02-10 Raja R Harinath <rharinath@novell.com>
15430 Fix #52586, cs0121-4.cs.
15431 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15432 and return a hashtable.
15433 (MemberCache.ClearDeclaredOnly): New.
15434 (MemberCache.MemberCache): Update to change. Make a deep copy of
15435 the method_hash of a base type too.
15436 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15437 type methods. Overwrite entries with the same MethodHandle so
15438 that the ReflectedType is correct. The process leaves in base
15439 virtual functions and their overrides as distinct entries.
15440 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15441 matters since it was boxed in a ArrayList before.
15442 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15444 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15445 case of a virtual function and its override (choose the overload
15447 (Invocation.OverloadResolve): Avoid 'override' members during
15448 'applicable_type' calculation.
15450 2005-02-09 Raja R Harinath <rharinath@novell.com>
15452 Combine two near-redundant caches.
15453 * typemanager.cs (method_params): Rename from method_internal_params.
15454 (TypeManager.GetParameterData): New. Replace
15455 Invocation.GetParameterData.
15456 (TypeManager.LookupParametersByBuilder): Remove.
15457 * expression.cs (Invocation.method_parameter_cache): Remove.
15458 (Invocation.GetParameterData): Remove.
15460 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15463 2005-02-08 Raja R Harinath <rharinath@novell.com>
15466 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15467 TypeManager.multicast_delegate_type is null, resolve it by looking
15468 up "System.MulticastDelegate".
15469 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15471 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15472 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15473 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15476 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15477 (LabeledStatement.AddReference): New. Set 'referenced'.
15478 (Goto.Resolve): Use it.
15480 2005-02-05 John Luke <john.luke@gmail.com>
15482 * driver.cs: remove duplicate -doc line in Usage ()
15484 2005-02-04 Raja R Harinath <rharinath@novell.com>
15486 * location.cs (Location.AddFile): Fix CS2002 error report.
15488 2005-02-02 Martin Baulig <martin@ximian.com>
15490 * delegate.cs (Delegate.DefineType): Report an internal error if
15491 TypeManager.multicast_delegate_type is null. See bug #72015 for
15494 2005-02-02 Raja R Harinath <rharinath@novell.com>
15496 Fix a crasher in a variant of #31984.
15497 * const.cs (Constant.CheckBase): New override that defers the
15498 new-or-override check in case the base type hasn't been populated
15500 (Constant.Define): Ensure the new-or-override check is performed.
15502 2005-02-01 Duncan Mak <duncan@ximian.com>
15504 * const.cs (LookupConstantValue): Check that `ce' is not null
15505 before calling GetValue ().
15507 2005-02-01 Raja R Harinath <rharinath@novell.com>
15509 Fix test-334.cs (#69519).
15510 * cs-parser.jay (using_alias_directive): Pass in an expression to
15511 NamespaceEntry.UsingAlias.
15512 (using_namespace_directive): Pass in an expression to
15513 NamespaceEntry.Using.
15514 (namespace_name): Don't flatten to a string.
15515 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15516 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15518 (NamespaceEntry.UsingEntry): Likewise.
15519 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15521 (NamespaceEntry.LookupForUsing): Remove.
15522 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15524 (NamespaceEntry.Lookup): Remove support for dotted names.
15526 2005-02-01 Raja R Harinath <rharinath@novell.com>
15528 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15530 (NamespaceEntry.ImplicitParent): Compute on demand.
15531 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15532 parallels the current.
15533 (NamespaceEntry.LookupForUsing): Use it.
15534 (NamespaceEntry.Lookup): If the current namespace-entry is
15535 implicit, don't search aliases and using tables.
15537 2005-02-01 Raja R Harinath <rharinath@novell.com>
15540 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15542 (TypeContainer.BaseCache): Compute on demand.
15543 (TypeContainer.FindMembers): Define constants and types if they're
15544 not already created.
15545 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15547 * const.cs (Constant.Define): Make idempotent.
15549 2005-01-29 Miguel de Icaza <miguel@novell.com>
15551 * pending.cs: Produce better code (no nops produced by using Ldarg
15554 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15555 i - 1' it should be arg + 1.
15559 2005-01-28 Raja R Harinath <rharinath@novell.com>
15561 * attribute.cs (Attribute.CheckAttributeType): Make private
15563 (Attribute.ResolveType): Make virtual.
15564 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15565 handling of RootContext.Tree.Types.
15567 2005-01-27 Raja R Harinath <rharinath@novell.com>
15569 Update attribute-handling to use the SimpleName/MemberAccess
15571 * cs-parser.jay (attribute): Pass in an expression to the
15572 constructors of Attribute and GlobalAttribute.
15573 * attribute.cs (Attribute): Take an expression for the name.
15574 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15575 passed in attribute name expression.
15576 (Attribute.CheckAttributeType): Use it.
15577 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15578 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15579 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15580 argument to prevent error messages if the lookup fails.
15582 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15584 * expression.cs (Indirection): Implemented IVariable interface
15585 to support indirection in AddressOf operator.
15586 (PointerArithmetic.Emit): Add optimalization for case where
15587 result can be precomputed.
15589 2005-01-26 Martin Baulig <martin@ximian.com>
15591 * class.cs (TypeContainer.AttributeTargets): Return the correct
15592 AttributeTargets depending on our `Kind' instead of throwing an
15593 exception; fixes #71632.
15595 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15598 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15601 2005-01-25 Raja R Harinath <rharinath@novell.com>
15604 * expression.cs (MemberAccess.DoResolve): Don't complain with
15605 cs0572 when the LHS of a member access has identical name and type
15608 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15611 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15613 Create custom PermissionSet only for PermissionSetAttribute.
15615 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15618 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15619 delegates in static class.
15621 2005-01-24 Martin Baulig <martin@ximian.com>
15623 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15624 merging an implicit block, just use its reachability.
15626 * statement.cs (Block.Resolve): Make the unreachable code check
15627 work wrt. implicit blocks; see test-337 from #63842.
15629 2005-01-21 Alp Toker <alp@atoker.com>
15631 * cs-parser.jay: destructor_declaration's container is PartialContainer
15632 not Class when partial types are used, so use Kind prop instead of
15635 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15637 * cs-parser.jay: Improve error reporting when an interface
15638 declares new types.
15640 2005-01-20 Dick Porter <dick@ximian.com>
15642 * support.cs: SeekableStreamReader fix from Sandor Dobos
15643 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15644 chars are read. Fixes bug 70369.
15646 2005-01-20 Raja R Harinath <rharinath@novell.com>
15648 * cs-parser.jay (catch_clause): Simplify current_block handling
15651 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15653 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15654 code with ImplicitStandardConversion to handle the implicit
15655 conversion of method groups into valid delegate invocations.
15657 The problem is that in parameter handling we were using this code
15658 path. Fixes bug #64698
15660 2005-01-19 Raja R Harinath <rharinath@novell.com>
15662 * cs-parser.jay: Fix several infelicities.
15663 - Avoid assigning to the parser value stack. Code like
15664 '$3 = null' is unclean. Synthesize a value for the code block
15666 - Avoid using oob_stack for storing location information. Use ...
15667 (_mark_): ... this. New (empty) rule. Saves the current location
15669 (foreach_statement): Avoid using oob_stack for current_block
15670 handling. Use technique used in for_statement and
15671 using_statement. Synthesize a value for the code block to store
15672 additional intermediate information.
15674 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15676 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15677 of a different type is only allowed to private fields of a
15678 containing type, not on fields of a base class.
15680 See test-174.cs and error cs0122-9.cs
15682 2005-01-13 Raja R Harinath <rharinath@novell.com>
15684 Fix test-335.cs (bug #58126).
15685 * cs-parser.jay (argument): Split out non-expression parts of the
15686 rule into 'non_simple_argument'.
15687 (invocation_expression): Support parenthesized invocations with
15688 multiple arguments, and with single non-simple arguments.
15690 2005-01-13 Raja R Harinath <rharinath@novell.com>
15692 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15695 2005-01-12 Raja R Harinath <rharinath@novell.com>
15697 Fix cs0038-1.cs, cs1640-6.cs.
15698 * ecore.cs (Expression.Resolve): Remove special-case for
15699 SimpleName in error-handling.
15700 (Expression.almostMatchedMembers): Relax access permission to
15702 (Expression.MemberLookupFailed): Handle duplicates in
15703 almostMatchedMembers list.
15704 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15705 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15706 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15707 overload if the passed in MemberInfo is a MethodBase.
15709 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15712 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15713 for non-CAS & merge permission sets properly.
15715 2005-01-11 Raja R Harinath <rharinath@novell.com>
15717 Improve standard-compliance of simple name and member access
15718 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15719 * ecore.cs (FullNamedExpression): New abstract base class
15720 for Namespaces and TypeExpressions.
15721 (ResolveFlags.SimpleName): Remove.
15722 (SimpleName): Remove support for dotted names.
15723 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15724 DeclSpace.FindType and DeclSpace.LookupType.
15725 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15726 (Expression.ExprClassName): Make member function.
15727 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15728 a namespace. Remove creation of dotted "SimpleName"s.
15729 (MemberAccess.DoResolve): Likewise.
15730 * decl.cs (DeclSpace.Cache): Make private.
15731 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15732 (DeclSpace.FindType): Update.
15733 (DeclSpace.LookupType): Move here from RootContext. Return a
15734 FullNamedExpression.
15735 * namespace.cs (Namespace): Derive from FullNamedExpression
15736 so that it can be part of expression resolution.
15737 (Namespace.Lookup): Return an FullNamedExpression.
15738 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15740 * rootcontext.cs (NamespaceLookup): Remove.
15741 (LookupType): Move to DeclSpace.
15742 * attribute.cs (CheckAttributeType): Update.
15743 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15744 (FindDocumentedTypeNonArray): Likewise.
15746 2005-01-11 Raja R Harinath <rharinath@novell.com>
15748 Fix cs0509.cs, cs1632.cs.
15749 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15750 is the same as IsInterface.
15751 (TypeContainer.GetClassBases): Likewise.
15752 * statement.cs (LabeledStatement.ig): New field.
15753 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15755 (LabeledStatement.DoEmit): Check that the label was created with
15756 the same ILGenerator.
15758 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15761 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15762 accessors to its properties.
15764 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15765 from accessors to property.
15767 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15770 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15771 only for overrides.
15773 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15775 * attribute.cs: Check for null and empty strings.
15777 I have lost another battle to Paolo.
15779 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15782 * class.cs (PropertyMethod): Set Parent field in ctors.
15783 (SetMethod.InternalParameters): Add unsafe switch hack.
15784 Override MarkForDuplicationCheck where it is appropriate.
15786 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15787 It says whether container allows members with the same name.
15788 Base default is no.
15789 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15790 Removed is_method parameter.
15792 2005-01-06 Duncan Mak <duncan@ximian.com>
15794 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15795 because the previous change led to incorrect reporting of CS1032
15796 ("Cannot define/undefine preprocessor symbols after first token in
15797 file"). Instead of using `tokens_seen' as the only flag that
15798 triggers CS1040, introduce `comments_seen'. This new flag is used
15799 to signify having seen comments on the current line, so it is
15800 unset after a newline.
15802 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15804 * doc.cs : When searching for a type, find nested type too.
15805 This fixes bug #71040.
15807 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15810 - Warn missing member comment on those classes which also does not
15811 have doc comments. Fixed bug #71041.
15812 - Don't warn missing doc comment on default constructor.
15815 2005-01-06 Duncan Mak <duncan@ximian.com>
15817 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15818 comments, set `tokens_seen' to true. This allows us to detect
15819 misplaced preprocessor directives (i.e. not at the beginning of
15820 the a line, nor after whitespaces). In that case, report error
15821 CS1040. This fixes bug #56460.
15823 * cs-parser.jay (interface_member_declaration): Add checks for
15824 IsExplicitImpl, and report CS0541 error if an interface member is
15825 defined as an explicit interface declaration.
15827 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15830 * class.cs (PropertyMethod): Set Parent field in ctors.
15831 (SetMethod.InternalParameters): Add unsafe switch hack.
15833 * decl.cs (MemberCore.Parent): Cannot be readonly.
15835 2005-01-06 Raja R Harinath <rharinath@novell.com>
15837 * decl.cs (DeclSpace.ResolveType): Remove.
15838 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15839 Merge in code from ...
15840 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15841 * class.cs, enum.cs: Update to changes.
15843 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15845 * anonymous.cs: Ensure that we init the scope of our parent if it
15846 has not been initialized yet.
15848 2004-12-30 Duncan Mak <duncan@ximian.com>
15850 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15851 if field.FieldBuilder is null. Fixes #70758.
15853 * convert.cs: Fixed some typos and updated some of the comments.
15854 (ImplicitStandardConversionExists):
15855 (TryImplicitIntConversion): If `target_type' is an interface and
15856 the type of `ic' implements this interface, return true or a new
15857 BoxedCast instead of null. This fixes #70468.
15859 2004-12-29 Duncan Mak <duncan@ximian.com>
15861 * expression.cs (Argument.Emit): Check that Expr is
15862 IMemoryLocation before casting to it, and report CS1510 otherwise.
15866 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15868 * statement.cs (Block.ThisVariable): remove the recursion here, to
15869 make the --profile more sane.
15871 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15873 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15874 assembly, by JB Evain.
15876 2004-12-17 Raja R Harinath <rharinath@novell.com>
15878 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15879 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15880 "parent" refers to enclosing type/class. "base" refers to superclass.
15882 2004-12-17 Raja R Harinath <rharinath@novell.com>
15884 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15885 Ensure that we only have GlobalAttributes.
15886 * attribute.cs (Attribute.Emit): Make non-virtual.
15887 (GlobalAttribute.Emit): Remove.
15888 (Attribute.Resolve): Make virtual.
15889 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15890 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15891 the argument. Don't create one.
15892 (Attribute.GetObsoleteAttribute): Likewise.
15893 (Attribute.GetClsCompliantAttributeValue): Likewise.
15894 * class.cs, decl.cs: Update to changes.
15896 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15898 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15900 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15902 * statement.cs (Foreach.Resolve): Add error 186 report.
15904 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15906 * expression.cs (Conditional.DoResolve): Add warning 429.
15908 * statement.cs (If.Resolve): Add warning 665.
15910 2004-12-16 Raja R Harinath <rharinath@novell.com>
15912 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15913 except when in the parser, and in GlobalAttribute.
15914 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15915 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15916 RootContext.Tree.Types.NamespaceEntry once work is done.
15917 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15918 and resets RootContext.Tree.Types.NamespaceEntry.
15920 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15922 * cs-parser.jay: Don't create a block for every variable.
15924 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15926 * location.cs: Provide extra information.
15928 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15929 variables from the captured environment, it is the ldarg_0.
15931 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15933 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15936 * class.cs: Changed warning level for 169 to avoid developer
15937 displeasure from warning flooding. It will be changed back when they
15938 fix most of current BCL warnings.
15940 * RootContext.cs: Pushed default WarningLevel to 3.
15942 * statement.cs: Removed unused variable.
15944 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15946 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15947 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15948 Add error 502 report.
15949 (StaticClass.DefineType): Add error 441 report.
15950 (Class.AllowedModifiersProp): New virtual property as temporary
15951 extension to AllowedModifiers.
15952 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15953 to share implementation with StaticClass and don't call virtual
15956 * driver.cs (MainDriver): Add error 1558 test.
15958 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15959 report. Moved error 36 test here.
15961 * statement.cs (Throw.Resolve): Add error 724 report.
15963 * typemanager.cs: Add out_attribute_type core type.
15965 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15967 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15969 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15971 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15974 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15976 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15977 Add error 3023 report.
15978 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15980 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15983 2004-12-12 John Luke <john.luke@gmail.com>
15985 * driver.cs (AddArgs): take -- into account when
15986 adding arguments, fixes bug 65710
15988 2004-12-12 Martin Baulig <martin@ximian.com>
15990 * expression.cs (Unary.TryReduceNegative): Added support for
15991 SByteConstant and ByteConstant.
15992 (Unary.Reduce): Check error values from TryReduceNegative().
15994 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15996 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15997 and report exception as error 182.
15999 2004-12-10 Raja R Harinath <rharinath@novell.com>
16001 * driver.cs (Main): Fix message when there are warnings.
16003 2004-12-09 Miguel de Icaza <miguel@ximian.com>
16005 * delegate.cs: Fixed my fix from yesterday, sorry about that.
16007 2004-12-09 Marek Safar <marek.safar@seznam.cz>
16009 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
16010 Reduced number of warnings.
16012 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
16014 2004-12-08 Miguel de Icaza <miguel@ximian.com>
16016 * driver.cs: Removed message.
16018 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
16020 2004-12-08 <vargaz@freemail.hu>
16022 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
16024 2004-12-08 Martin Baulig <martin@ximian.com>
16026 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
16027 instead of a CS3002 for properties and indexer.
16029 2004-12-08 Martin Baulig <martin@ximian.com>
16031 * decl.cs (MemberName.ToString): Make this work again.
16033 2004-12-08 Marek Safar <marek.safar@seznam.cz>
16035 * attribute.cs (Resolve): Add error 591 detection.
16037 * class.cs (FieldMember.Define): Add error 1547 detection.
16038 (Indexer.Define): Add error 620 detection.
16039 (Operator.Define): Add error 590 detection.
16041 * ecore.cs: Missing argument for error 79.
16043 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
16046 2004-12-07 Marek Safar <marek.safar@seznam.cz>
16049 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
16052 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
16054 * cs-parser.jay : handle doc comments on implicit/explicit operators.
16055 Some operator comments were suppressed.
16056 * doc.cs : Implicit/explicit operator name in doc comments are like
16057 "op_Explicit(type)~returnType", so added suffix handling.
16059 2004-12-07 Martin Baulig <martin@ximian.com>
16062 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
16063 (MemberCore.GetClsCompliantAttributeValue): Likewise.
16064 (DeclSpace.ec): New protected field; store the EmitContext here.
16065 (DeclSpace.EmitContext): New public property; moved here from
16067 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
16070 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
16071 (Enum.Emit): Don't create a new EmitContext.
16073 * delegate.cs (Delegate.DefineType): Always create the
16076 * iterators.cs (Iterators.DefineIterator): Create a new
16077 EmitContext and store it in `ec'.
16079 2004-08-24 Martin Baulig <martin@ximian.com>
16082 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
16083 this for accessibility checks.
16084 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
16085 IsNestedFamilyAccessible.
16086 (TypeManager.IsSubclassOf): New method, do what the name actually
16089 2004-12-06 Raja R Harinath <rharinath@novell.com>
16091 Fix crash on cs0657-17.cs.
16092 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
16093 Use RootContext.Tree.Types, not 'new RootTypes ()'.
16094 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
16095 the case where the NamespaceEntry gets overwritten.
16097 2004-12-06 Marek Safar <marek.safar@seznam.cz>
16099 Fixed #69195, #56821
16100 * ecore.cs (ResolveBoolean): Tiny refactoring.
16102 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
16103 of right expression resolving when left is false constant and
16104 operator is LogicalAnd OR true constant and operator is LogicalOr.
16106 * statement.cs (ResolveUnreachable): Always reports warning.
16108 2004-12-05 Miguel de Icaza <miguel@ximian.com>
16110 * class.cs: Distinguish between 1721 and 1722 (just a little help
16111 for the programmer).
16113 2004-12-03 Miguel de Icaza <miguel@ximian.com>
16115 * delegate.cs: Only allow this on new versions of the language.
16117 2004-12-02 Duncan Mak <duncan@ximian.com>
16119 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
16121 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
16122 here as a static method. Take an additional bool out parameter
16123 `must_do_cs1540_check' for signaling to InstanceResolve.
16124 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
16125 member field from PropertyExpr class and made it an argument of
16126 the method instead.
16127 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
16128 check for MarshalByRefObject, and report CS0122 instead of CS1540.
16129 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
16130 and `remove_accessor' as well as InstanceResolve: report CS0122
16135 2004-12-03 Raja R Harinath <rharinath@novell.com>
16137 Fix test-327.cs, test-328.cs, and put in early infrastructure
16138 for eventually fixing #52697.
16139 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
16140 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
16141 from other methods.
16142 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
16143 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
16144 (VerifyUsing, error246): Update.
16145 * rootcontext.cs (RootContext.NamespaceLookup): Just use
16146 'NamespaceEntry.LookupNamespaceOrType'.
16148 2004-12-03 Martin Baulig <martin@ximian.com>
16150 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16151 method as our child, call AnonymousMethod.Compatible() on it.
16153 2004-12-03 Raja R Harinath <rharinath@novell.com>
16155 Disable XML documentation support in 'basic' profile.
16156 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
16157 Redirect XmlElement to System.Object.
16158 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
16159 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
16160 * mcs.exe.sources: Add doc-bootstrap.cs.
16161 * doc-bootstrap.cs: New file. Contains empty stub implementation
16164 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
16166 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
16167 comments are allowed.
16169 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16171 * delegate.cs: Add checks for subtypes in paramaters and return values
16172 in VerifyMethod () to add support for Covariance/Contravariance
16175 2004-12-02 Miguel de Icaza <miguel@ximian.com>
16177 * report.cs: Remove extra closing parenthesis.
16179 * convert.cs (Error_CannotImplicitConversion): If the name of the
16180 types are the same, provide some extra information.
16182 * class.cs (FieldBase): Use an unused bit field from the field to
16183 encode the `has_offset' property from the FieldMember. This saves
16184 a couple of Ks on bootstrap compilation.
16186 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16187 method as our child, return the AnonymousMethod resolved
16190 * expression.cs (New.DoResolve): Allow return values from
16191 NewDelegate to also include AnonymousMethods.
16195 2004-12-02 Marek Safar <marek.safar@seznam.cz>
16198 * attribute.cs (Resolve): Improved implementation of params
16199 attribute arguments.
16201 * support.cs (ParameterData): Add HasParams to be faster.
16203 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
16205 all things are for /doc support:
16207 * doc.cs: new file that supports XML documentation generation.
16208 * mcs.exe.sources: added doc.cs.
16210 Handle /doc command line option.
16211 Report error 2006 instead of 5 for missing file name for /doc.
16212 Generate XML documentation when required, after type resolution.
16214 Added support for picking up documentation (/// and /** ... */),
16215 including a new XmlCommentState enumeration.
16217 Added lines to fill Documentation element for field, constant,
16218 property, indexer, method, constructor, destructor, operator, event
16219 and class, struct, interface, delegate, enum.
16220 Added lines to warn incorrect comment.
16222 Added Documentation field (passed only when /doc was specified).
16224 Added DocComment, DocCommentHeader, GenerateDocComment() and
16225 OnGenerateDocComment() and some supporting private members for
16226 /doc feature to MemberCore.
16228 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16230 Added overriden DocCommentHeader.
16232 Added overriden DocCommentHeader and GenerateDocComment().
16234 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16236 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16237 unwrapping the enumeration values, chain to
16238 DoConstantNumericPromotions again, so we can promote things to the
16239 fundamental types (takes care of enums that are bytes, sbytes).
16243 2004-12-01 Raja R Harinath <rharinath@novell.com>
16245 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16246 Fix long-standing bug in type-lookup. Use FindType instead of
16247 LookupType when ec.ResolvingTypeTree.
16248 (Attribute.ResolveType, Attribute.Resolve)
16249 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16251 (Attributes.Search): Remove internal version. Update.
16252 (Attributes.SearchMulti): Update.
16253 (Attributes.GetClsCompliantAttribute): Remove.
16254 (Attributes.GetIndexerNameAttribute): Remove.
16255 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16256 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16257 * class.cs (Indexer.Define): Likewise.
16259 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16262 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16263 MarshallByReference members access.
16265 * expression.cs: Use CheckMarshallByRefAccess;
16266 Better error CS0197 message.
16268 * report.cs: Print whole related error message.
16270 2004-11-30 Raja R Harinath <rharinath@novell.com>
16272 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16273 the current directory to help debugging.
16275 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16277 * class (GetClassBases): Better error 60 report.
16278 (EventProperty): Disabled warning 67 detection.
16280 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16283 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16285 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16288 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16291 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16293 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16295 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16297 * attribute.cs (Attribute.Resolve): Refine error reporting and
16298 report a cs0117 if the identifier does not exist, to distinguish
16299 from 0617 which is a miss-use of the actual identifier.
16301 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16302 between cs0070 and cs0079.
16304 * class.cs (MemberBase.DoDefine): When reporting a wrong
16305 accessibility level, we use MethodCore to compare instead of
16306 Method (this was a regression in some refactoring effort).
16308 So now we correctly report cs0056 again.
16310 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16311 testing the target_type (which was known to be object_type) and
16312 not the source type (which is anonymous_method).
16314 Fixed reporting of error cs1660.
16316 * expression.cs (UserCast.Source): Expose the underlying cast.
16318 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16319 allowed types to find a match to int32 first (most common).
16321 In addition, it ignores any ImplicitUserConversions that did an
16322 internal implicit conversion (as the switch statement allows only
16323 one integral conversion to exist).
16325 * class.cs (PartialContainer.Create): rename `name' to
16326 `member_name' for clarity. Then replace the string calls with a
16327 call to MemberName.GetPartialName, as now using
16328 MemberName.ToString is an error (this is due to the side effects
16329 it had, that were fixed in the past).
16331 This will restore the error reporting on a number of partial class
16332 errors that were missusing this (and getting an exception as a
16333 results, which is now just a plain textual warning, because
16334 yyparse debug output would crash otherwise).
16336 2004-11-26 Raja R Harinath <rharinath@novell.com>
16338 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16340 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16342 * rootcontext.cs (LookupType): Make sure to cache lookups that
16343 don't give us a negative result. This saves about 5% of corlib
16346 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16348 * report.cs (AbstractMessage.Print): messages are sent to stderr
16350 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16351 non-interface in the list of interfaces (at this point, either
16352 parent was properly set, or a base class is being listed in the
16353 interfaces section).
16355 This flags error 1722, and resolves the crash from bug 69259.
16357 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16359 * statement.cs (Using.EmitExpressionFinally): make this work right
16360 for valuetypes. Fixes 69926.
16362 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16364 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16365 converted to an enum" here, before we try to change the underlying
16366 type. This code exists, but it is a different code path than the
16367 one used while encoding constants.
16369 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16370 old bug: when converting from the null literal to a pointer,
16371 return an EmptyCast, not the NullLiteral.
16373 This fixes #69921, the recent null_type changes probably made this
16374 bug more prominent.
16376 (ImplicitReferenceConversionExists): In addition, resynchronized
16377 the code here, so it matches the same code in
16378 ImplicitReferenceConversionExists for the `from any class-type S
16379 to any interface-type T'.
16382 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16384 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16386 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16388 * cs-parser.jay: Use verbosity accordingly.
16390 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16392 * expression.cs (Unary.ResolveOperator): Do not report warning;
16393 AddressOf reads from variable.
16395 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16397 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16401 * attribute.cs (Attributable): Removed CheckTargets.
16402 (Attributes.Emit): Explicit attribute targets are tested here.
16404 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16405 not enabled for interfaces.
16407 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16408 (GetAssemblyName): Ouch next bug there.
16410 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16412 * expression.cs: Error 275 added.
16414 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16416 Fix bug #69177 (Implemented decimal constant support)
16418 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16419 (BinaryFold): Add DecimalConstant.
16421 * const.cs (Define): Decimal constant
16423 (ChangeType): Add decimal type handling.
16424 (LookupConstantValue): Don't set value for decimal type but
16425 emit DecimalConstantAttribute. Needed for constant optimization.
16427 * constant.cs (ToDecimal): New method.
16428 (ConvertToDecimal): New method.
16429 (IntConstant): Implemented ConvertToDecimal.
16430 (DecimalConstant.Emit): Emit optimized version for decimals in
16433 * expression.cs (ResolveOperator): Changed order of constant
16434 reduction to work correctly with native types which have
16435 overloaded operators.
16436 (ResolveMemberAccess): Extract constant value from attribute
16439 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16441 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16442 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16443 (ChangeType): Decimal is special.
16444 (TypeToCoreType): Add decimal type.
16446 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16448 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16451 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16453 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16456 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16458 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16460 * pending.cs (PendingImplementation): Grab only interfaces.
16462 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16464 * statement.cs (ForeachHelperMethods): Add location member and
16465 error 202 detection.
16467 2004-11-19 Raja R Harinath <rharinath@novell.com>
16469 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16470 automatically handled by executable.make.
16471 (PROGRAM): Make profile-specific.
16473 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16475 * expression.cs (DoResolveBase): Fixed wrong warning for out
16478 2004-11-18 Martin Baulig <martin@ximian.com>
16480 Merged latest changes into gmcs. Please keep this comment in
16481 here, it makes it easier for me to see what changed in MCS since
16482 the last time I merged.
16484 2004-11-17 Raja R Harinath <rharinath@novell.com>
16486 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16487 (TypeHandle.GetMemberCache): New.
16488 (TypeHandle.TypeHandle): Update.
16489 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16490 (TypeManager.LookupParentInterfacesCache):
16491 Rename from LookupInterfaceCache. Optimize slightly.
16492 (TypeManager.MemberLookup_FindMembers): Update.
16493 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16494 multi-type variant.
16495 (AddCacheContents): Rename from AddHashtable.
16496 * class.cs (TypeContainer.parent_container): Remove.
16497 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16498 (TypeContainer.DoDefineMembers): Don't initialize it.
16499 Update to name changes.
16501 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16503 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16504 that factors the code to check access modifiers on override.
16506 (PropertyBase): Use the code here.
16508 Patch from Lluis S'anchez, fixes bug #69361.
16510 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16512 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16513 routine that is used to report the use of a captured variable
16514 whose address has been taken.
16516 There are two checks: one when variables are being captured and
16517 the other check is when the address of a variable is taken.
16519 (because an anonymous methods might be resolved before *or* after
16520 the address has been taken) and
16522 * expression.cs (Conditional.DoResolve): Remove the special
16523 casing that Martin added to trueExpr and falseExpr being both
16524 NullLiteral. We get the right behavior now just by introducing
16525 the null_type into the compiler.
16527 * convert.cs (ExplicitConversion): Change the code to use
16528 null_type instead of testing `expr is NullLiteral'.
16529 (ImplicitConversionStandard): use null_type too.
16530 (ImplicitReferenceConversionExists): use null_type too.
16531 (ImplicitReferenceConversion): use null_type too.
16533 * literal.cs: The type of `NullLiteral' is now null_type instead
16535 (Resolve): Set the type here.
16537 * typemanager.cs: Introduce null_type.
16539 2004-11-17 Martin Baulig <martin@ximian.com>
16541 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16542 direction, like FindMembers() does. Fixes #69546, testcase is in
16545 2004-11-16 Martin Baulig <martin@ximian.com>
16547 This is based on a patch from Marek Safar, see bug #69082.
16548 Fixes bugs #63705 and #67130.
16550 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16551 method; create a MemberCache for an interface type and cache the
16554 * decl.cs (IMemberContainer.ParentContainer): Removed.
16555 (IMemberContainer.ParentCache): New property.
16556 (MemberCache.SetupCacheForInterface): Removed.
16557 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16558 to create a cache for an interface's "parent".
16560 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16563 2004-11-16 Martin Baulig <martin@ximian.com>
16565 Merged back from gmcs; these changes already went into gmcs a
16566 couple of weeks ago.
16569 (TypeManager.AddUserType): Removed the `ifaces' argument.
16570 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16572 (TypeManager.AddUserInterface): Removed.
16573 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16575 (TypeManager.GetInterfaces): Likewise.
16576 (TypeManager.GetExplicitInterfaces): Likewise.
16578 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16580 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16581 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16583 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16585 * statement.cs: Avoid adding bools to a hashtable.
16587 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16589 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16590 calling an unsafe method from a safe location.
16592 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16595 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16597 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16599 * namespace.cs (VerifyUsing): use GetPartialName instead of
16602 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16604 * statement.cs (Return.Resolve): Fix regression in typo: if
16605 `in_exc', we have to request a NeedReturnLabel, this was a typo
16606 introduced in the anonymous method check-in. Fixes #69131.
16608 * Indexers were using the ShortName when defining themselves,
16609 causing a regression in the compiler bootstrap when applying the
16610 patch from 2004-11-02 (first part), now they use their full name
16611 and the bug is gone.
16613 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16615 * driver.cs: Strip the path from the names of embedded resources. Fixes
16618 2004-11-04 Raja R Harinath <rharinath@novell.com>
16620 Fix error message regression: cs0104-2.cs.
16621 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16622 (AliasEntry.Resolve): Update.
16623 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16625 (RootContext.LookupType): Update.
16627 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16629 * cs-parser.jay: Add support for handling accessor modifiers
16630 * class: Add support port accessor modifiers and error checking,
16631 define PropertyMethod.Define as virtual (not abstract anymore)
16632 * ecore.cs: Add checking for proeprties access with access modifiers
16633 * iterators.cs: Modify Accessor constructor call based in the modified
16635 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16637 * expression.cs (StringConcat): Handle being called twice,
16638 as when we have a concat in a field init with more than two
16641 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16643 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16644 special case explicit implementations, we should always produce
16645 the .property or .event declaration.
16647 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16648 since it will not return correct data if people use this
16649 unresolved in the presence of using statements (see test-313).
16651 * class.cs (MethodData.Define): If we are an explicit interface
16652 implementation, set the method name to the full name of the
16653 interface plus the name of the method.
16655 Notice that using the method.MethodName.GetFullName() does not
16656 work, as it will only contain the name as declared on the source
16657 file (it can be a shorthand in the presence of using statements)
16658 and not the fully qualifed type name, for example:
16662 class D : ICloneable {
16663 object ICloneable.Clone () {
16667 Would produce a method called `ICloneable.Clone' instead of
16668 `System.ICloneable.Clone'.
16670 * namespace.cs (Alias.Resolve): Use GetPartialName.
16672 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16674 * cs-parser.jay: Add error 1055 report.
16676 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16678 * assign.cs (Assign.DoResolve): Only do the transform of
16679 assignment into a New if the types are compatible, if not, fall
16680 through and let the implicit code deal with the errors and with
16681 the necessary conversions.
16683 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16685 * cs-parser.jay: Add error 1031 report.
16687 * cs-tokenizer.cs: Add location for error 1038.
16689 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16691 * cs-parser.jay: Add error 1016 report.
16693 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16695 * cs-parser.jay: Add errors 1575,1611 report.
16697 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16699 * cs-parser.jay: Add error 1001 report.
16701 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16704 * attribute.cs (GetMarshal): Add method argument for
16705 caller identification.
16707 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16708 agument for GetMarshal and RuntimeMissingSupport.
16710 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16712 * attribute.cs (ExtractSecurityPermissionSet): Removed
16713 TypeManager.code_access_permission_type.
16715 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16717 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16719 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16720 for obsolete use of a variable here. Fixes regression on errors
16721 cs0619-25 and cs0619-26.
16723 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16725 Fix #62358, implemented security attribute encoding.
16727 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16728 Tests permitted SecurityAction for assembly or other types.
16729 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16730 data from SecurityPermissionAttribute to PermisionSet class.
16732 * class.cs (ApplyAttributeBuilder): Added special handling
16733 for System.Security.Permissions.SecurityAttribute based types.
16735 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16736 special handling for System.Security.Permissions.SecurityAttribute
16739 * enum.cs (ApplyAttributeBuilder): Added special handling
16740 for System.Security.Permissions.SecurityAttribute based types.
16742 * parameter.cs (ApplyAttributeBuilder): Added special handling
16743 for System.Security.Permissions.SecurityAttribute based types.
16745 * rootcontext.cs: Next 2 core types.
16747 * typemanager.cs (TypeManager.security_permission_attr_type):
16748 Built in type for the SecurityPermission Attribute.
16749 (code_access_permission_type): Build in type.
16751 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16753 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16754 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16755 all of this information into
16756 EmitContext.EmitCapturedVariableInstance.
16758 * codegen.cs (EmitCapturedVariableInstance): move here the
16759 funcionality of emitting an ldarg.0 in the presence of a
16760 remapping. This centralizes the instance emit code.
16762 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16763 then emit a load of this: it means that we have reached the
16764 topmost ScopeInfo: the one that contains the pointer to the
16765 instance of the class hosting the anonymous method.
16767 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16768 captures to the topmost CaptureContext.
16770 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16772 * expression.cs (LocalVariableReference): Move the knowledge about
16773 the iterators into codegen's EmitCapturedVariableInstance.
16775 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16777 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16778 all code paths return a value from an anonymous method (it is the
16779 same as the 161 error, but for anonymous methods).
16781 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16783 The introduction of anonymous methods in the compiler changed
16784 various ways of doing things in the compiler. The most
16785 significant one is the hard split between the resolution phase
16786 and the emission phases of the compiler.
16788 For instance, routines that referenced local variables no
16789 longer can safely create temporary variables during the
16790 resolution phase: they must do so from the emission phase,
16791 since the variable might have been "captured", hence access to
16792 it can not be done with the local-variable operations from the runtime.
16796 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16797 is a toplevel block.
16799 (ToplevelBlock): A new kind of Block, these are the blocks that
16800 are created by the parser for all toplevel method bodies. These
16801 include methods, accessors and anonymous methods.
16803 These contain some extra information not found in regular blocks:
16804 A pointer to an optional CaptureContext (for tracking captured
16805 local variables and parameters). A pointer to the parent
16808 (Return.Resolve): Catch missmatches when returning a value from an
16809 anonymous method (error 1662).
16810 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16813 (Break.Resolve): ditto.
16815 (SwitchLabel): instead of defining the labels during the
16816 resolution phase, we now turned the public ILLabel and ILLabelCode
16817 labels into methods called GetILLabelCode() and GetILLabel() that
16818 only define the label during the Emit phase.
16820 (GotoCase): Track the SwitchLabel instead of the computed label
16821 (its contained therein). Emit the code by using
16822 SwitchLabel.GetILLabelCode ().
16824 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16825 whether the Local has been captured or not.
16827 (LocalInfo.IsCaptured): New property, used to tell whether the
16828 local has been captured.
16830 * anonymous.cs: Vastly updated to contain the anonymous method
16833 The main classes here are: CaptureContext which tracks any
16834 captured information for a toplevel block and ScopeInfo used to
16835 track the activation frames for various local variables.
16837 Each toplevel block has an optional capture context associated
16838 with it. When a method contains an anonymous method both the
16839 toplevel method and the anonymous method will create a capture
16840 context. When variables or parameters are captured, they are
16841 recorded on the CaptureContext that owns them, for example:
16845 MyDelegate d = delegate {
16850 Here `a' will be recorded as captured on the toplevel
16851 CapturedContext, the inner captured context will not have anything
16852 (it will only have data if local variables or parameters from it
16853 are captured in a nested anonymous method.
16855 The ScopeInfo is used to track the activation frames for local
16856 variables, for example:
16858 for (int i = 0; i < 10; i++)
16859 for (int j = 0; j < 10; j++){
16860 MyDelegate d = delegate {
16865 At runtime this captures a single captured variable `i', but it
16866 captures 10 different versions of the variable `j'. The variable
16867 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16868 recorded on a child.
16870 The toplevel ScopeInfo will also track information like the `this'
16871 pointer if instance variables were referenced (this is necessary
16872 as the anonymous method lives inside a nested class in the host
16873 type of the method).
16875 (AnonymousMethod): Expanded to track the Toplevel, implement
16876 `AnonymousMethod.Compatible' to tell whether an anonymous method
16877 can be converted to a target delegate type.
16879 The routine now also produces the anonymous method content
16881 (AnonymousDelegate): A helper class that derives from
16882 DelegateCreation, this is used to generate the code necessary to
16883 produce the delegate for the anonymous method that was created.
16885 * assign.cs: API adjustments for new changes in
16886 Convert.ImplicitStandardConversionExists.
16888 * class.cs: Adjustments to cope with the fact that now toplevel
16889 blocks are of type `ToplevelBlock'.
16891 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16892 insteda of standard blocks.
16894 Flag errors if params arguments are passed to anonymous methods.
16896 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16897 `CurrentAnonymousMethod' which points to the current Anonymous
16898 Method. The variable points to the AnonymousMethod class that
16899 holds the code being compiled. It is set in the new EmitContext
16900 created for the anonymous method.
16902 (EmitContext.Phase): Introduce a variable and an enumeration to
16903 assist in enforcing some rules about when and where we are allowed
16904 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16905 only one that enfonces this right now).
16907 (EmitContext.HaveCaptureInfo): new helper method that returns
16908 whether we have a CapturedContext initialized.
16910 (EmitContext.CaptureVariable): New method used to register that a
16911 LocalInfo must be flagged for capturing.
16913 (EmitContext.CapturedParameter): New method used to register that a
16914 parameters must be flagged for capturing.
16916 (EmitContext.CapturedField): New method used to register that a
16917 field must be flagged for capturing.
16919 (EmitContext.HaveCapturedVariables,
16920 EmitContext.HaveCapturedFields): Return whether there are captured
16921 variables or fields.
16923 (EmitContext.EmitMethodHostInstance): This is used to emit the
16924 instance for the anonymous method. The instance might be null
16925 (static methods), this (for anonymous methods that capture nothing
16926 and happen to live side-by-side with the current method body) or a
16927 more complicated expression if the method has a CaptureContext.
16929 (EmitContext.EmitTopBlock): Routine that drives the emission of
16930 code: it will first resolve the top block, then emit any metadata
16931 and then emit the code. The split is done so that we can extract
16932 any anonymous methods and flag any captured variables/parameters.
16934 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16935 during this phase, the ILGenerator should not be used as labels
16936 and local variables declared here might not be accessible to any
16937 code that is part of an anonymous method.
16939 Exceptions to this include the temporary variables that are
16940 created by some statements internally for holding temporary
16943 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16946 (EmitContext.TemporaryReturn): This method is typically called
16947 from the Emit phase, and its the only place where we allow the
16948 ReturnLabel to be defined other than the EmitMeta. The reason is
16949 that otherwise we would have to duplicate a lot of logic in the
16950 Resolve phases of various methods that today is on the Emit
16953 (EmitContext.NeedReturnLabel): This no longer creates the label,
16954 as the ILGenerator is not valid during the resolve phase.
16956 (EmitContext.EmitThis): Extended the knowledge in this class to
16957 work in anonymous methods in addition to iterators.
16959 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16960 code is necessary on the stack to access the instance to a local
16961 variable (the variable will be accessed as a field).
16963 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16964 EmitContext.EmitAddressOfParameter): Routines to support
16965 parameters (not completed at this point).
16967 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16968 will also remove the parameters.
16970 * convert.cs (Convert): Define a `ConstantEC' which points to a
16971 null. This is just to prefity some code that uses
16972 ImplicitStandardConversion code and do not have an EmitContext
16975 The idea is to flag explicitly that at that point in time, it is
16976 known that the conversion will not trigger the delegate checking
16977 code in implicit conversions (which requires a valid
16980 Everywhere: pass new EmitContext parameter since
16981 ImplicitStandardConversionExists now requires it to check for
16982 anonymous method conversions.
16984 (Convert.ImplicitStandardConversionExists): If the type of an
16985 expression is the anonymous_method_type, and the type is a
16986 delegate, we invoke the AnonymousMethod.Compatible method to check
16987 whether an implicit conversion is possible.
16989 (Convert.ImplicitConversionStandard): Only do implicit method
16990 group conversions if the language level is not ISO_1.
16992 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16993 MethodInfo for the Invoke method. used by Delegate and
16996 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16997 method conversions if the target type is a delegate.
16999 Removed extra debugging nops.
17001 (LocalVariableReference): Turn the `local_info' into a public
17004 Add `prepared' field, the same hack used for FieldExprs to cope
17005 with composed assignments, as Local variables do not necessarily
17006 operate purely on the stack as they used to: they can be captured
17009 Add `temp' for a temporary result, like fields.
17011 Refactor DoResolve and DoResolveLValue into DoResolveBase.
17013 It now copes with Local variables that are captured and emits the
17014 proper instance variable to load it from a field in the captured
17017 (ParameterReference.DoResolveBase): During the resolve phase,
17018 capture parameters if we are in an anonymous method.
17020 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
17021 anonymous method, use the EmitContext helper routines to emit the
17022 parameter reference.
17024 * iterators.cs: Set RemapToProxy to true/false during the
17027 * parameters.cs (GetParameterByName): New helper method.
17029 * typemanager.cs (anonymous_method_type) a new type that
17030 represents an anonyous method. This is always an internal type,
17031 used as a fencepost to test against the anonymous-methodness of an
17034 2004-10-20 Marek Safar <marek.safar@seznam.cz>
17036 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
17038 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
17040 2004-10-18 Martin Baulig <martin@ximian.com>
17042 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
17043 `Type' directly, but call ResolveType() on it.
17044 (Catch.Resolve): Likewise.
17045 (Foreach.Resolve): Likewise.
17047 2004-10-18 Martin Baulig <martin@ximian.com>
17049 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
17050 `Type' directly, but call ResolveType() on it.
17051 (Probe.DoResolve): Likewise.
17052 (ArrayCreation.LookupType): Likewise.
17053 (TypeOf.DoResolve): Likewise.
17054 (SizeOf.DoResolve): Likewise.
17056 2004-10-18 Martin Baulig <martin@ximian.com>
17058 * expression.cs (Invocation.BetterFunction): Put back
17059 TypeManager.TypeToCoreType().
17061 2004-10-18 Raja R Harinath <rharinath@novell.com>
17063 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
17066 2004-10-18 Martin Baulig <martin@ximian.com>
17068 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
17069 `Type' directly, but call ResolveType() on it.
17071 2004-10-18 Martin Baulig <martin@ximian.com>
17073 * class.cs (FieldMember.Define): Don't access the TypeExpr's
17074 `Type' directly, but call ResolveType() on it.
17075 (MemberBase.DoDefine): Likewise.
17077 * expression.cs (New.DoResolve): Don't access the TypeExpr's
17078 `Type' directly, but call ResolveType() on it.
17079 (ComposedCast.DoResolveAsTypeStep): Likewise.
17081 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
17082 `Type' directly, but call ResolveType() on it.
17084 2004-10-17 John Luke <john.luke@gmail.com>
17086 * class.cs (Operator.GetSignatureForError): use CSharpName
17088 * parameter.cs (Parameter.GetSignatureForError): Returns
17089 correct name even if was not defined.
17091 2004-10-13 Raja R Harinath <rharinath@novell.com>
17094 * class.cs (TypeContainer.EmitContext): New property.
17095 (DefineNestedTypes): Create an emitcontext for each part.
17096 (MethodCore.DoDefineParameters): Use container's emitcontext.
17097 Pass type array to InternalParameters.
17098 (MemberBase.DoDefine): Use container's emitcontext.
17099 (FieldMember.Define): Likewise.
17100 (Event.Define): Likewise.
17101 (SetMethod.GetParameterInfo): Change argument to EmitContext.
17102 Pass type array to InternalParameters.
17103 (SetIndexerMethod.GetParameterInfo): Likewise.
17104 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
17105 * delegate.cs (Define): Pass emitcontext to
17106 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
17107 array to InternalParameters.
17108 * expression.cs (ParameterReference.DoResolveBase): Pass
17109 emitcontext to GetParameterInfo.
17110 (ComposedCast.DoResolveAsTypeStep): Remove check on
17111 ec.ResolvingTypeTree.
17112 * parameter.cs (Parameter.Resolve): Change argument to
17113 EmitContext. Use ResolveAsTypeTerminal.
17114 (Parameter.GetSignature): Change argument to EmitContext.
17115 (Parameters.ComputeSignature): Likewise.
17116 (Parameters.ComputeParameterTypes): Likewise.
17117 (Parameters.GetParameterInfo): Likewise.
17118 (Parameters.ComputeAndDefineParameterTypes): Likewise.
17119 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
17120 * support.cs (InternalParameters..ctor): Remove variant that takes
17122 * typemanager.cs (system_intptr_expr): New.
17123 (InitExpressionTypes): Initialize it.
17125 2004-10-12 Chris Toshok <toshok@ximian.com>
17127 * cs-parser.jay: fix location for try_statement and catch_clause.
17129 2004-10-11 Martin Baulig <martin@ximian.com>
17131 * report.cs: Don't make --fatal abort on warnings, we have
17132 -warnaserror for that.
17134 2004-10-07 Raja R Harinath <rharinath@novell.com>
17136 More DeclSpace.ResolveType avoidance.
17137 * decl.cs (MemberCore.InUnsafe): New property.
17138 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
17139 with newly created EmitContext.
17140 (FieldMember.Define): Likewise.
17141 * delegate.cs (Delegate.Define): Likewise.
17142 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
17143 only if normal name-lookup fails.
17144 (TypeExpr.DoResolve): Enable error-checking.
17145 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
17146 (SizeOf.DoResolve): Likewise.
17147 (ComposedCast.DoResolveAsTypeStep): Likewise.
17148 (StackAlloc.DoResolve): Likewise.
17149 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
17150 (Block.Unsafe): New property.
17151 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
17152 (Unsafe): Set 'unsafe' flag of contained block.
17153 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
17154 (Fixed.Resolve): Likewise.
17155 (Catch.Resolve): Likewise.
17156 (Using.ResolveLocalVariableDecls): Likewise.
17157 (Foreach.Resolve): Likewise.
17159 2004-10-05 John Luke <john.luke@gmail.com>
17161 * cs-parser.jay: add location to error CS0175
17163 2004-10-04 Miguel de Icaza <miguel@ximian.com>
17165 * ecore.cs (Expression.Constantity): Add support for turning null
17168 * const.cs (Const.Define): Allow constants to be reference types
17169 as long as the value is Null.
17171 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
17173 * namespace.cs (NamespaceEntry.Using): No matter which warning
17174 level is set, check if this namespace name has already been added.
17176 2004-10-03 Ben Maurer <bmaurer@ximian.com>
17178 * expression.cs: reftype [!=]= null should always use br[true,false].
17181 2004-10-03 Marek Safar <marek.safar@seznam.cz>
17184 * attribute.cs: Enum conversion moved to
17185 GetAttributeArgumentExpression to be applied to the all
17188 2004-10-01 Raja R Harinath <rharinath@novell.com>
17190 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
17191 * class.c (TypeContainer.DefineType): Flag error if
17192 base types aren't accessible due to access permissions.
17193 * decl.cs (DeclSpace.ResolveType): Move logic to
17194 Expression.ResolveAsTypeTerminal.
17195 (DeclSpace.ResolveTypeExpr): Thin layer over
17196 Expression.ResolveAsTypeTerminal.
17197 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
17198 Refactor code into NestedAccess. Use it.
17199 (DeclSpace.NestedAccess): New.
17200 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
17201 argument to silence errors. Check access permissions.
17202 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
17203 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
17204 (Cast.DoResolve): Likewise.
17205 (New.DoResolve): Likewise.
17206 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
17207 (TypeOf.DoResolve): Likewise.
17209 * expression.cs (Invocation.BetterConversion): Return the Type of
17210 the better conversion. Implement section 14.4.2.3 more faithfully.
17211 (Invocation.BetterFunction): Make boolean. Make correspondence to
17212 section 14.4.2.2 explicit.
17213 (Invocation.OverloadResolve): Update.
17214 (Invocation): Remove is_base field.
17215 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
17216 (Invocation.Emit): Likewise.
17218 2004-09-27 Raja R Harinath <rharinath@novell.com>
17220 * README: Update to changes.
17222 2004-09-24 Marek Safar <marek.safar@seznam.cz>
17224 * cs-parser.jay: Reverted 642 warning fix.
17226 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17229 * decl.cs (FindMemberWithSameName): Indexer can have more than
17232 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17234 * expression.cs (LocalVariableReference.DoResolveLValue):
17235 Do not report warning 219 for out values.
17236 (EmptyExpression.Null): New member to avoid extra allocations.
17238 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17240 * cs-parser.jay: Fix wrong warning 642 report.
17242 * cs-tokenizer.cs (CheckNextToken): New helper;
17243 Inspect next character if is same as expected.
17245 2004-09-23 Martin Baulig <martin@ximian.com>
17247 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17248 (Convert.ImplicitReferenceConversionExists): Likewise.
17250 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17252 * class.cs (Operator.Define): Add error 448 and 559 report.
17254 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17256 * class.cs (MemberBase.IsTypePermitted): New protected
17257 method for checking error CS0610.
17259 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17261 * class.cs (TypeContainer.HasExplicitLayout): New property
17262 Returns whether container has StructLayout attribute set Explicit.
17263 (FieldMember): New abstract class for consts and fields.
17264 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17265 (Field): Reuse FieldMember.
17267 * const.cs (Const): Reuse FieldMember.
17269 * rootcontext.cs: EmitConstants call moved to class.
17271 2004-09-22 Martin Baulig <martin@ximian.com>
17273 Thanks to Peter Sestoft for this bug report.
17275 * expression.cs (Conditional): If both the `trueExpr' and the
17276 `falseExpr' is a NullLiteral, return a NullLiteral.
17278 2004-09-22 Martin Baulig <martin@ximian.com>
17280 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17281 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17282 for the "get_Current" call.
17284 2004-09-22 Martin Baulig <martin@ximian.com>
17286 Marek and me just fixed one of our oldest bugs: #28562 :-)
17288 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17290 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17291 we're an EnumConstant, just return that.
17292 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17293 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17294 to get the value which'll actually be written into the attribute.
17295 However, we have to use GetValue() to access the attribute's value
17298 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17300 * constant.cs (Constant.IsNegative): New abstract property
17303 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17304 (StackAlloc.DoResolve): Reused IsNegative.
17306 2004-09-21 Martin Baulig <martin@ximian.com>
17308 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17309 if we're used in an iterator, we may be called from different
17312 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17313 we actually have an exception block.
17315 2004-09-20 John Luke <jluke@cfl.rr.com>
17317 * class.cs, cs-parser.jay: Improve the error report for 1520:
17318 report the actual line where the error happens, not where the
17319 class was declared.
17321 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17322 Pass location information that was available elsewhere.
17324 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17326 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17327 runtime to delay sign assemblies.
17329 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17331 * cs-parser.jay: Do not report the stack trace, this is barely
17334 2004-08-22 John Luke <john.luke@gmail.com>
17336 * driver.cs : check that a resource id is not already used
17337 before adding it, report CS1508 if it is, bug #63637
17339 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17341 * ecore.cs: Removed dead code.
17343 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17345 * class.cs: Do not report warning CS0067 on the interfaces.
17347 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17349 * cs-parser.jay: Add error 504 report.
17351 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17353 * rootcontext.cs: WarningLevel is 4 by default now.
17355 * statement.cs (Fixed.Resolve): Do not null
17358 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17361 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17362 deep search when property is not virtual.
17363 (PropertyExpr.ResolveAccessors): Make one call for both
17366 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17369 * statement.cs: Error 152 report constains also location.
17371 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17374 * const.cs: Explicitly set constant as static.
17376 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17379 * cs-parser.jay: Add error 1017 report.
17381 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17383 Fixed bug #59980, #64224
17384 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17386 * typemanager.cs (IsSpecialMethod): Simplified
17388 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17390 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17391 condition with better params.
17393 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17396 * attribute.cs (Resolve): Property has to have both
17399 2004-09-14 Martin Baulig <martin@ximian.com>
17401 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17403 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17406 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17407 called and is obsolete then this member suppress message
17408 when call is inside next [Obsolete] method or type.
17410 * expression.cs: Use TestObsoleteMethodUsage member.
17412 2004-09-14 Martin Baulig <martin@ximian.com>
17414 * cs-parser.jay: Sync a bit with the GMCS version.
17416 2004-09-14 Martin Baulig <martin@ximian.com>
17418 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17419 (CSharpParser.yacc_verbose_flag): New public field.
17421 * genericparser.cs: Removed.
17423 2004-09-14 Raja R Harinath <rharinath@novell.com>
17425 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17427 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17429 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17431 2004-09-10 Martin Baulig <martin@ximian.com>
17433 Backported my MemberName changes from GMCS into MCS.
17435 - we are now using a special `MemberName' class instead of using
17436 strings; in GMCS, the `MemberName' also contains the type
17439 - changed the grammar rules a bit:
17440 * the old `member_name' is now a `namespace_or_type_name':
17441 The rule is that we use `namespace_or_type_name' everywhere
17442 where we expect either a "member name" (GetEnumerator) or a
17443 "member name" with an explicit interface name
17444 (IEnumerable.GetEnumerator).
17445 In GMCS, the explicit interface name may include type arguments
17446 (IEnumerable<T>.GetEnumerator).
17447 * we use `member_name' instead of just `IDENTIFIER' for
17449 The rule is that we use `member_name' wherever a member may
17450 have type parameters in GMCS.
17452 * decl.cs (MemberName): New public class.
17453 (MemberCore.MemberName): New public readonly field.
17454 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17455 (DeclSpace): Likewise.
17457 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17458 * enum.cs (Enum.ctor): Likewise.
17460 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17462 (AliasEntry.ctor): Take a MemberName, not an Expression.
17463 (AliasEntry.UsingAlias): Likewise.
17465 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17466 (IMethodData.MemberName): Changed type from string to MemberName.
17467 (MemberBase.ExplicitInterfaceName): Likewise.
17468 (AbstractPropertyEventMethod.SetupName): Make this private.
17469 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17470 argument; compute the member name here.
17471 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17472 on the `member.MemberName' and the `prefix'.
17474 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17476 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17477 thus, we get a `MemberName' instead of a `string'. These
17478 declarations may have type parameters in GMCS.
17479 (interface_method_declaration, delegate_declaration): Likewise.
17480 (class_declaration, interface_declaration): Likewise.
17481 (method_header): Use `namespace_or_type_name' instead of
17482 `member_name'. We may be an explicit interface implementation.
17483 (property_declaration, event_declaration): Likewise.
17484 (member_name): This is now just an `IDENTIFIER', not a
17485 `namespace_or_type_name'.
17486 (type_name, interface_type): Removed.
17487 (namespace_or_type_name): Return a MemberName, not an Expression.
17488 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17489 call GetTypeExpression() on the MemberName to get an expression.
17490 (IndexerDeclaration.interface_type): Changed type from string to
17492 (MakeName): Operate on MemberName's instead of string's.
17494 2004-09-13 Raja R Harinath <rharinath@novell.com>
17497 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17498 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17499 lookup to avoid symbols introduced by 'using'.
17500 * rootcontext.cs (NamespaceLookup): Update.
17502 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17504 * class.cs (TypeContainer.DoDefineMembers): Do not call
17505 DefineDefaultConstructor for static classes.
17507 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17509 * attribute.cs (Attribute.Resolve): Add error 653 report.
17511 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17513 (Method.ApplyAttributeBuilder): Add error 685 report.
17514 (Operator.Define): Add error 564 report.
17516 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17518 * expression.cs (Invocation.DoResolve): Add error
17519 245 and 250 report.
17521 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17524 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17526 * class.cs (ConstructorInitializer.Resolve):
17527 Wrong error number (515->516).
17529 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17531 * class.cs (Indexer.Define): Add error 631 report.
17533 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17535 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17537 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17539 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17541 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17543 * cs-parser.jay: Added error CS0241 report.
17545 2004-09-10 Raja R Harinath <rharinath@novell.com>
17547 * cs-parser.jay (fixed_statement): Introduce a scope for the
17548 declaration in the 'fixed' statement.
17550 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17552 * cs-parser.jay: Added CS0230 error report.
17554 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17556 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17558 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17560 * expression.cs (Argument.Resolve): Added error CS0192 and
17563 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17565 C# 2.0 #pragma warning feature
17567 * cs-tokenizer.cs (PreProcessPragma): New method;
17568 Handles #pragma directive.
17570 * report.cs (WarningRegions): New class; Support
17571 class for #pragma warning directive. It tests whether
17572 warning is enabled for a given line.
17574 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17576 * const.cs: Add more descriptive error report, tahnks to
17579 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17581 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17583 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17585 * expression.cs: Apply patch from Ben: Remove dead code from
17586 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17587 as that code just threw an exception anwyays.
17589 * const.cs: Remove the call to the turnintoconstant, for details
17592 * literal.cs: The type of the null-literal is the null type; So
17593 we use a placeholder type (literal.cs:System.Null, defined here)
17596 * expression.cs (Conditional.DoResolve): Remove some old code that
17597 is no longer needed, conversions have been fixed.
17599 (ArrayCreationExpression.DoResolve): Return false if we fail to
17600 resolve the inner expression.
17602 2004-09-07 Raja R Harinath <rharinath@novell.com>
17605 * cs-parser.jay (delegate_declaration): Record a delegate
17606 declaration as a type declaration.
17607 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17609 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17611 * parameter.cs: Do not crash if the type can not be resolved.
17613 * expression.cs: Report errors with unsafe pointers, fixes #64896
17615 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17617 * expression.cs: Pointer arith always needs to do a conv.i
17618 if the operand is a long. fix 65320
17620 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17622 Fixed cs0619-37.cs, cs0619-38.cs
17624 * enum.cs (GetObsoleteAttribute): Removed.
17626 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17627 on Enum member is double staged. The first is tested member
17630 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17632 Fixed #56986, #63631, #65231
17634 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17635 adds member to name container.
17636 (TypeContainer.AddToTypeContainer): New method, adds type to
17638 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17639 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17640 AddOperator): Simplified by reusing AddToMemberContainer.
17641 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17643 (Method.CheckForDuplications): Fixed implementation to test all
17645 (MemberBase): Detection whether member is explicit interface
17646 implementation is now in constructor.
17647 (MemberBase.UpdateMemberName): Handles IndexerName.
17648 (Accessor): Changed to keep also location information.
17649 (AbstractPropertyEventMethod): Is derived from MemberCore.
17650 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17651 will be emited or not.
17652 (PropertyBase.AreAccessorsDuplicateImplementation):
17653 Tests whether accessors are not in collision with some method.
17654 (Operator): Is derived from MethodCore to simplify common
17657 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17659 (DeclSpace.AddToContainer): Adds the member to defined_names
17660 table. It tests for duplications and enclosing name conflicts.
17662 * enum.cs (EnumMember): Clean up to reuse the base structures
17664 2004-09-03 Martin Baulig <martin@ximian.com>
17666 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17667 into TypeContainer, to make partial classes work again.
17669 2004-09-03 Martin Baulig <martin@ximian.com>
17671 * rootcontext.cs (RootContext.V2): Removed.
17673 2004-03-23 Martin Baulig <martin@ximian.com>
17675 * expression.cs (Invocation.OverloadResolve): Added `bool
17676 may_fail' argument and use it instead of the Location.IsNull() hack.
17678 2004-09-03 Martin Baulig <martin@ximian.com>
17680 Merged latest changes into gmcs. Please keep this comment in
17681 here, it makes it easier for me to see what changed in MCS since
17682 the last time I merged.
17684 2004-09-03 Raja R Harinath <rharinath@novell.com>
17687 * expression.cs (BetterConversion): Don't allow either conversion
17688 to be null. Remove redundant implicit conversion test when 'q ==
17689 null' -- when this function is invoked, we already know that the
17690 implicit conversion exists.
17691 (BetterFunction): Assume that 'best' is non-null. Remove
17692 redundant reimplementation of IsApplicable when 'best' is null.
17693 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17694 number of arguments.
17695 (IsAncestralType): Extract from OverloadResolve.
17696 (OverloadResolve): Make robust to the MethodGroupExpr being
17697 unsorted. Implement all the logic of Section 14.5.5.1, and
17698 support overloading of methods from multiple applicable types.
17699 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17701 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17702 (RealError, Warning): Append type of report to related symbol.
17704 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17706 * enum.cs: Fixed CLS-Compliance checks for enum members.
17707 Error tests cs3008-8.cs, cs3014-8.cs
17709 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17711 Fixed bug #62342, #63102
17712 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17713 like ImplementMethod.
17715 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17717 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17720 2004-09-02 Martin Baulig <martin@ximian.com>
17722 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17723 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17726 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17728 C# 2.0 Static classes implemented
17730 * class.cs (TypeContainer): instance_constructors,
17731 initialized_fields, initialized_static_fields,
17732 default_constructor, base_inteface_types are protected to be
17733 accessible from StaticClass.
17734 (TypeContainer.DefineDefaultConstructor): New virtual method
17735 for custom default constructor generating
17736 (StaticClass): New class to handle "Static classes" feature.
17738 * cs-parser.jay: Handle static keyword on class like instance
17741 * driver.cs: Added "/langversion" command line switch with two
17742 options (iso-1, default).
17744 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17746 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17748 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17750 * delegate.cs: Style.
17752 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17754 * delegate.cs: Add seperate instance expr field for miguel.
17756 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17758 * PointerArithmetic (Resolve): make sure we are not doing
17759 pointer arith on void*. Also, make sure we are resolved
17760 by not setting eclass until resolve.
17762 All callers: Make sure that PointerArithmetic gets resolved.
17764 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17766 * ArrayCreation (LookupType): If the type does not resolve
17767 to an array, give an error.
17769 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17771 * statement.cs (Try.Resolve): Fixed bug #64222
17773 2004-08-27 Martin Baulig <martin@ximian.com>
17776 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17779 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17781 * ecore.cs (Constantify): Get underlying type via
17782 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17783 Windows in special cases.
17785 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17787 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17788 for obtaining also private methods.
17789 (GetRemoveMethod): Used GetRemoveMethod (true)
17790 for obtaining also private methods.
17792 2004-08-24 Martin Baulig <martin@ximian.com>
17794 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17795 MethodAttributes.HideBySig for operators.
17797 2004-08-23 Martin Baulig <martin@ximian.com>
17799 Back to the old error reporting system :-)
17801 * report.cs (Message): Removed.
17802 (Report.MessageData, ErrorData, WarningData): Removed.
17803 (Report.Error, Warning): Back to the old system.
17805 2004-08-23 Martin Baulig <martin@ximian.com>
17807 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17809 * class.cs (TypeContainer.ParentContainer): New public virtual
17810 method; replaces the explicit interface implementation.
17811 (ClassPart.ParentContainer): Override.
17813 2004-08-23 Martin Baulig <martin@ximian.com>
17815 * statement.cs (Switch): Added support for constant switches; see
17816 #59428 or test-285.cs.
17818 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17821 * statement.cs (GetEnumeratorFilter): Removed useless
17822 logic because C# specs is strict. GetEnumerator must be
17825 2004-08-22 Martin Baulig <martin@ximian.com>
17827 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17828 a switch and may break, reset the barrier. Fixes #59867.
17830 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17832 CLS-Compliance speed up (~5% for corlib)
17834 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17835 New method. Tests container for CLS-Compliant names
17837 * class.cs (TypeContainer.VerifyClsName): New method.
17838 Checks whether container name is CLS Compliant.
17839 (Constructor): Implements IMethodData.
17841 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17842 low-case table for CLS Compliance test.
17843 (MemberCache.VerifyClsParameterConflict): New method.
17844 Checks method parameters for CS3006 error.
17846 * enum.cs (EnumMember): Is derived from MemberCore.
17847 (Enum.VerifyClsName): Optimized for better performance.
17849 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17851 * report.cs: Renamed Error_T to Error and changed all
17854 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17856 * class.cs (TypeContainer.IndexerArrayList): New inner class
17857 container for indexers.
17858 (TypeContainer.DefaultIndexerName): New constant for default
17859 indexer name. Replaced all "Item" with this constant.
17860 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17862 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17863 DefaultMemberAttribute constructor.
17865 2004-08-05 Martin Baulig <martin@ximian.com>
17867 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17870 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17872 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17873 multi platforms problem.
17875 * compiler.csproj: Included shared files.
17877 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17879 Fix bug 60333, 55971 in the more general way
17880 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17881 Added arg_type argument for constant conversion.
17882 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17884 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17887 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17888 OperatorArrayList, MethodCoreArrayList for typecontainer
17889 containers. Changed class member types to these new types.
17890 (MethodArrayList.DefineMembers): Added test for CS0659.
17892 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17894 * cfold.cs: Synchronize the folding with the code in expression.cs
17895 Binary.DoNumericPromotions for uint operands.
17897 * attribute.cs: Revert patch from Raja, it introduced a regression
17898 while building Blam-1.2.1 (hard to isolate a test case).
17900 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17904 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17906 (MethodCore.parent_method): New member. The method we're overriding
17907 if this is an override method.
17908 (MethodCore.CheckBase): Moved from Method class and made common.
17909 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17911 (MethodCore.CheckForDuplications): New abstract method. For custom
17912 member duplication search in a container
17913 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17914 method and its return type.
17915 (Event.conflict_symbol): New member. Symbol with same name in the
17919 (MemberCache.FindMemberWithSameName): New method. The method
17920 is looking for conflict with inherited symbols.
17922 2004-08-04 Martin Baulig <martin@ximian.com>
17924 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17926 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17928 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17930 * report.cs (Message): New enum for better error, warning reference in
17932 (MessageData): New inner abstract class. It generally handles printing of
17933 error and warning messages.
17934 Removed unused Error, Warning, Message methods.
17936 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17938 Fix for cs0592-8.cs test
17940 (Attributable.ValidAttributeTargets): Made public.
17941 (Attribute.ExplicitTarget): New member for explicit target value.
17942 (Attribute.CheckTargets): Now we translate explicit attribute
17943 target to Target here.
17945 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17947 * ecore.cs (MethodGroupExpr): new IsBase property.
17949 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17951 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17952 rather than an instance expr.
17954 (DelegateCreation.Emit): Use the method group rather than
17955 the instance expression. Also, if you have base.Foo as the
17956 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17958 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17960 (NewDelegate.DoResolve): Only check for the existance of Invoke
17961 if the method is going to be needed. Use MethodGroupExpr.
17963 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17965 * expression.cs: For pointer arith., make sure to use
17966 the size of the type, not the size of the pointer to
17969 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17972 * class.cs (Class): Added error CS0502 test.
17974 2004-08-03 John Luke <jluke@cfl.rr.com>
17975 Raja R Harinath <rharinath@novell.com>
17978 * attribute.cs (Attribute.complained_before): New flag.
17979 (Attribute.ResolveType, Attribute.Resolve),
17980 (Attribute.DefinePInvokeMethod): Set it.
17981 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17983 2004-08-03 Martin Baulig <martin@ximian.com>
17985 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17986 use a user-defined operator; we still need to do numeric
17987 promotions in case one argument is a builtin type and the other
17988 one has an implicit conversion to that type. Fixes #62322.
17990 2004-08-02 Martin Baulig <martin@ximian.com>
17992 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17993 (LocalInfo.IsThis): New public property.
17994 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17996 2004-08-01 Martin Baulig <martin@ximian.com>
17998 * class.cs (TypeContainer.GetClassBases): Don't set the default
17999 here since we may get called from GetPartialBases().
18000 (TypeContainer.DefineType): If GetClassBases() didn't return a
18001 parent, use the default one.
18003 2004-07-30 Duncan Mak <duncan@ximian.com>
18005 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
18007 2004-07-30 Martin Baulig <martin@ximian.com>
18009 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
18011 * class.cs (SourceMethod): New public class, derive from the
18012 symbol writer's ISourceMethod.
18013 (Method): Use the new symbol writer API.
18015 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
18016 as argument and use the new symbol writer.
18019 (SourceFile): Implement the symbol writer's ISourceFile.
18020 (Location.SymbolDocument): Removed.
18021 (Location.SourceFile): New public property.
18023 * symbolwriter.cs: Use the new symbol writer API.
18025 2004-07-30 Raja R Harinath <rharinath@novell.com>
18027 * Makefile (install-local): Remove. Functionality moved to
18030 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
18032 * Makefile: Install mcs.exe.config file together with mcs.exe.
18033 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
18034 correct runtime version.
18036 2004-07-25 Martin Baulig <martin@ximian.com>
18039 (TypeContainer.RegisterOrder): Removed, this was unused.
18040 (TypeContainer, interface_order): Removed.
18041 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
18042 TypeContainer as argument since we can also be called with a
18043 `PartialContainer' for a partial class/struct/interface.
18044 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
18045 of checking whether we're an `Interface' - we could be a
18046 `PartialContainer'.
18047 (PartialContainer.Register): Override; call
18048 AddClass()/AddStruct()/AddInterface() on our parent.
18050 * cs-parser.jay (interface_member_declaration): Add things to the
18051 `current_container', not the `current_class'.
18053 * rootcontext.cs (RegisterOrder): The overloaded version which
18054 takes an `Interface' was unused, removed.
18056 * typemanager.cs (TypeManager.LookupInterface): Return a
18057 `TypeContainer', not an `Interface'.
18058 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
18059 contain a `PartialContainer' for an interface, so check it's
18060 `Kind' to figure out what it is.
18062 2004-07-25 Martin Baulig <martin@ximian.com>
18064 * class.cs (Class.DefaultTypeAttributes): New public constant.
18065 (Struct.DefaultTypeAttributes): Likewise.
18066 (Interface.DefaultTypeAttributes): Likewise.
18067 (PartialContainer.TypeAttr): Override this and add the
18068 DefaultTypeAttributes.
18070 2004-07-25 Martin Baulig <martin@ximian.com>
18072 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
18073 we can just use the `Parent' field instead.
18075 2004-07-25 Martin Baulig <martin@ximian.com>
18077 * class.cs (TypeContainer.Emit): Renamed to EmitType().
18079 2004-07-25 Martin Baulig <martin@ximian.com>
18081 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
18082 our parts before defining any methods.
18083 (TypeContainer.VerifyImplements): Make this virtual.
18084 (ClassPart.VerifyImplements): Override and call VerifyImplements()
18085 on our PartialContainer.
18087 2004-07-25 Martin Baulig <martin@ximian.com>
18089 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
18091 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
18092 argument, we can just use the `Parent' field instead.
18095 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
18096 (MemberBase.DoDefine): Likewise.
18098 2004-07-24 Martin Baulig <martin@ximian.com>
18100 * decl.cs (MemberCore.Parent): New public field.
18101 (DeclSpace.Parent): Moved to MemberCore.
18103 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
18104 (MemberBase.ctor): Added TypeContainer argument, pass it to our
18106 (FieldBase, Field, Operator): Likewise.
18107 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
18108 (EventField, Event): Likewise.
18110 2004-07-23 Martin Baulig <martin@ximian.com>
18112 * class.cs (PartialContainer): New public class.
18113 (ClassPart): New public class.
18114 (TypeContainer): Added support for partial classes.
18115 (TypeContainer.GetClassBases): Splitted some of the functionality
18116 out into GetNormalBases() and GetPartialBases().
18118 * cs-tokenizer.cs (Token.PARTIAL): New token.
18119 (Tokenizer.consume_identifier): Added some hacks to recognize
18120 `partial', but only if it's immediately followed by `class',
18121 `struct' or `interface'.
18123 * cs-parser.jay: Added support for partial clases.
18125 2004-07-23 Martin Baulig <martin@ximian.com>
18127 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
18128 a `DeclSpace' and also made it readonly.
18129 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
18130 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
18131 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
18133 * cs-parser.jay: Pass the `current_class', not the
18134 `current_container' (at the moment, this is still the same thing)
18135 to a new Method, Property, Event, Indexer or Constructor.
18137 2004-07-23 Martin Baulig <martin@ximian.com>
18139 * cs-parser.jay (CSharpParser): Added a new `current_class' field
18140 and removed the `current_interface' one.
18141 (struct_declaration, class_declaration, interface_declaration):
18142 Set `current_class' to the newly created class/struct/interface;
18143 set their `Bases' and call Register() before parsing their body.
18145 2004-07-23 Martin Baulig <martin@ximian.com>
18147 * class.cs (Kind): New public enum.
18148 (TypeContainer): Made this class abstract.
18149 (TypeContainer.Kind): New public readonly field.
18150 (TypeContainer.CheckDef): New public method; moved here from
18152 (TypeContainer.Register): New public abstract method.
18153 (TypeContainer.GetPendingImplementations): New public abstract
18155 (TypeContainer.GetClassBases): Removed the `is_class' and
18156 `is_iface' parameters.
18157 (TypeContainer.DefineNestedTypes): Formerly known as
18159 (ClassOrStruct): Made this class abstract.
18161 * tree.cs (RootTypes): New public type.
18163 2004-07-20 Martin Baulig <martin@ximian.com>
18165 * tree.cs (Tree.RecordNamespace): Removed.
18166 (Tree.Namespaces): Removed.
18168 * rootcontext.cs (RootContext.IsNamespace): Removed.
18170 * cs-parser.jay (namespace_declaration): Just create a new
18171 NamespaceEntry here.
18173 2004-07-20 Martin Baulig <martin@ximian.com>
18175 * statement.cs (ExceptionStatement): New abstract class. This is
18176 now used as a base class for everyone who's using `finally'.
18177 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
18178 our local variables before using them.
18180 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
18181 virtual method. This is used by Yield.Resolve() to "steal" an
18182 outer block's `finally' clauses.
18183 (FlowBranchingException): The .ctor now takes an ExceptionStatement
18186 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
18187 version which takes an ExceptionStatement. This version must be
18188 used to create exception branchings.
18191 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
18192 (Iterator.EmitMoveNext): Added exception support; protect the
18193 block with a `fault' clause, properly handle 'finally' clauses.
18194 (Iterator.EmitDispose): Run all the `finally' clauses here.
18196 2004-07-20 Martin Baulig <martin@ximian.com>
18198 * iterator.cs: This is the first of a set of changes in the
18199 iterator code. Match the spec more closely: if we're an
18200 IEnumerable, then GetEnumerator() must be called. The first time
18201 GetEnumerator() is called, it returns the current instance; all
18202 subsequent invocations (if any) must create a copy.
18204 2004-07-19 Miguel de Icaza <miguel@ximian.com>
18206 * expression.cs: Resolve the constant expression before returning
18209 2004-07-19 Martin Baulig <martin@ximian.com>
18211 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
18212 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
18213 the return type of the new EmitContext.
18215 2004-07-18 Martin Baulig <martin@ximian.com>
18217 * class.cs (Property.Define): Fix iterators.
18219 * iterators.cs (Iterator.Define): Moved the
18220 `container.AddInterator (this)' call here from the .ctor; only do
18221 it if we resolved successfully.
18223 2004-07-17 Miguel de Icaza <miguel@ximian.com>
18225 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
18226 `true' for preprocessing directives that we parse. The return
18227 value indicates whether we should return to regular tokenizing or
18228 not, not whether it was parsed successfully.
18230 In the past if we were in: #if false ... #line #endif, we would
18231 resume parsing after `#line'. See bug 61604.
18233 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18234 building: IsEnumType should return true only for enums, not for
18235 enums or System.Enum itself. This fixes #61593.
18237 Likely what happened is that corlib was wrong: mcs depended on
18238 this bug in some places. The bug got fixed, we had to add the
18239 hack, which caused bug 61593.
18241 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18242 that was a workaround for the older conditions.
18244 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18246 * assign.cs: IAssignMethod has a new interface, as documented
18247 inline. All assignment code now uses this new api.
18249 * ecore.cs, expression.cs: All classes which implement
18250 IAssignMethod now use the new interface.
18252 * expression.cs (Invocation): add a hack to EmitCall so that
18253 IndexerAccess can be the target of a compound assignment without
18254 evaluating its arguments twice.
18256 * statement.cs: Handle changes in Invocation api.
18258 2004-07-16 Martin Baulig <martin@ximian.com>
18260 * iterators.cs: Rewrote this. We're now using one single Proxy
18261 class for both the IEnumerable and the IEnumerator interface and
18262 `Iterator' derives from Class so we can use the high-level API.
18264 * class.cs (TypeContainer.AddIterator): New method.
18265 (TypeContainer.DoDefineType): New protected virtual method, which
18266 is called from DefineType().
18267 (TypeContainer.DoDefineMembers): Call DefineType() and
18268 DefineMembers() on all our iterators.
18269 (TypeContainer.Emit): Call Emit() on all our iterators.
18270 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18272 * codegen.cs (EmitContext.CurrentIterator): New public field.
18274 2004-07-15 Martin Baulig <martin@ximian.com>
18277 (TypeManager.not_supported_exception_type): New type.
18279 2004-07-14 Martin Baulig <martin@ximian.com>
18281 * iterators.cs: Use real error numbers.
18283 2004-07-14 Martin Baulig <martin@ximian.com>
18285 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18286 requires this to be a System.Collection.IEnumerable and not a
18287 class implementing that interface.
18288 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18290 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18292 * class.cs: Fixed previous fix, it broke some error tests.
18294 2004-07-12 Martin Baulig <martin@ximian.com>
18296 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18299 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18301 * assign.cs (LocalTemporary): Add new argument: is_address,If
18302 `is_address' is true, then the value that we store is the address
18303 to the real value, and not the value itself.
18305 * ecore.cs (PropertyExpr): use the new local temporary
18306 stuff to allow us to handle X.Y += z (where X is a struct)
18308 2004-07-08 Martin Baulig <martin@ximian.com>
18310 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18311 not always return, just like we're doing in Using.Resolve().
18313 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18315 * cs-parser.jay (fixed_statement): flag this as Pinned.
18317 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18319 * typemanager.cs (TypeManager): Removed MakePinned method, this
18320 mechanism is replaced with the .NET 2.x compatible mechanism of
18321 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18323 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18324 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18325 `IsFixed' property which has a different meaning.
18327 2004-07-02 Raja R Harinath <rharinath@novell.com>
18329 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18330 visible from inside a nested class, not just the names of the
18331 immediately enclosing class.
18332 Fix for bug #60730.
18334 2004-06-24 Raja R Harinath <rharinath@novell.com>
18336 * expression.cs (BetterConversion): Remove buggy special-case
18337 handling of "implicit constant expression conversions". At this
18338 point, we already know that the conversion is possible -- we're
18339 only checking to see which is better.
18341 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18343 * cs-parser.jay: Added error CS0210 test.
18345 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18347 * cs-parser.jay: Added error CS0134 test.
18349 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18352 * cs-parser.jay: Added error CS0145 test.
18354 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18356 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18358 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18360 * expression.cs (StackAlloc.Resolve): The argument may not
18361 be a constant; deal with this case.
18363 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18365 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18366 GetIndexerAttributeValue.
18367 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18369 * class.cs (Indexer.Define): Added error tests for CS0415,
18372 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18374 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18377 2004-06-23 Martin Baulig <martin@ximian.com>
18379 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18380 neither return nor throw, reset the barrier as well. Fixes #60457.
18382 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18384 * class.cs : EventAttributes is now set to None by default.
18385 This fixes bug #60459.
18387 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18390 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18391 Don't throw exception but return null (it's sufficient now).
18393 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18395 * typemanager.cs (GetArgumentTypes): Faster implementation.
18397 2004-06-18 Martin Baulig <martin@ximian.com>
18399 * attribute.cs (Attribute.Resolve): Check whether we're an
18400 EmptyCast which a Constant child. Fixes #60333.
18402 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18404 * statement.cs (EmitCollectionForeach): Account for the fact that
18405 not all valuetypes are in areas which we can take the address of.
18406 For these variables, we store to a temporary variable. Also, make
18407 sure that we dont emit a `callvirt' on a valuetype method.
18409 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18411 * expression.cs (StackAlloc.DoReSolve): Added test for
18412 negative parameter (CS0247).
18414 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18417 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18419 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18422 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18425 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18427 Fix bug #58254 & cs1555.cs, cs1556.cs
18428 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18430 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18432 * cs-parser.jay: Added error CS1669 test for indexers.
18434 2004-06-11 Martin Baulig <martin@ximian.com>
18436 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18437 call this twice: for params and varargs methods.
18439 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18442 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18444 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18446 * attribute.cs (Attribute.GetValidTargets): Made public.
18449 (AbstractPropertyEventMethod): New class for better code sharing.
18450 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18452 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18454 2004-06-11 Raja R Harinath <rharinath@novell.com>
18457 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18458 that the call to Resolve is part of a MemberAccess.
18459 (Expression.Resolve): Use it for SimpleName resolution.
18460 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18461 Add 'intermediate' boolean argument.
18462 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18463 error message when the SimpleName can be resolved ambiguously
18464 between an expression and a type.
18465 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18467 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18468 call on the left-side.
18470 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18473 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18475 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18477 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18479 2004-06-11 Martin Baulig <martin@ximian.com>
18481 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18482 varargs methods if applicable.
18484 2004-06-11 Martin Baulig <martin@ximian.com>
18486 * expression.cs (Invocation.EmitCall): Don't use
18487 `method.CallingConvention == CallingConventions.VarArgs' since the
18488 method could also have `CallingConventions.HasThis'.
18490 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18492 * class.cs (Event.GetSignatureForError): Implemented.
18493 Fixed crash in error test cs3010.cs
18495 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18497 * cs-tokenizer.cs: Change the way we track __arglist to be
18498 consistent with the other keywords.
18500 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18502 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18505 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18507 * codegen.cs: Check that all referenced assemblies have a strongname
18508 before strongnaming the compiled assembly. If not report error CS1577.
18509 Fix bug #56563. Patch by Jackson Harper.
18510 * typemanager.cs: Added a method to return all referenced assemblies.
18511 Fix bug #56563. Patch by Jackson Harper.
18513 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18516 (Method.ApplyAttributeBuilder): Moved and added conditional
18517 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18520 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18522 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18525 * class.cs: (EventField.attribute_targets): Changed default target.
18527 2004-06-08 Martin Baulig <martin@ximian.com>
18529 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18531 2004-06-08 Martin Baulig <martin@ximian.com>
18533 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18535 2004-06-07 Martin Baulig <martin@ximian.com>
18537 Added support for varargs methods.
18539 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18542 * cs-parser.jay: Added support for `__arglist'.
18544 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18546 * expression.cs (Argument.AType): Added `ArgList'.
18547 (Invocation): Added support for varargs methods.
18548 (ArglistAccess): New public class.
18549 (Arglist): New public class.
18551 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18553 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18554 a method's top-level block if the method has varargs.
18556 * support.cs (ReflectionParameters, InternalParameters): Added
18557 support for varargs methods.
18559 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18561 * class.cs: Provide location in indexer error report.
18563 * driver.cs: Use standard names.
18565 * namespace.cs: Catch the use of using after a namespace has been
18566 declared also on using aliases.
18568 2004-06-03 Raja R Harinath <rharinath@novell.com>
18571 * typemanager.cs (closure_private_ok, closure_invocation_type)
18572 (closure_qualifier_type, closure_invocation_assembly)
18573 (FilterWithClosure): Move to ...
18574 (Closure): New internal nested class.
18575 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18576 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18577 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18578 (MemberLookup, MemberLookupFailed): Use it.
18579 * expression.cs (New.DoResolve): Treat the lookup for the
18580 constructor as being qualified by the 'new'ed type.
18581 (Indexers.GetIndexersForTypeOrInterface): Update.
18583 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18586 (GetConditionalAttributeValue): New method. Returns
18587 condition of ConditionalAttribute.
18588 (SearchMulti): New method. Returns all attributes of type 't'.
18589 Use it when attribute is AllowMultiple = true.
18590 (IsConditionalMethodExcluded): New method.
18593 (Method.IsExcluded): Implemented. Returns true if method has conditional
18594 attribute and the conditions is not defined (method is excluded).
18595 (IMethodData): Extended interface for ConditionalAttribute support.
18596 (PropertyMethod.IsExcluded): Implemented.
18599 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18602 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18605 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18607 * expression.cs (ArrayCreationExpression): Make this just an
18608 `expression'. It can't be a statement, so the code here was
18611 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18614 * typemanager.cs (GetFullNameSignature): New method for
18617 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18620 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18621 Use this method when MethodBuilder is null.
18622 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18623 Added test for error CS0626 (MONO reports error for this situation).
18624 (IMethodData.GetSignatureForError): Extended interface.
18626 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18629 (AttributeTester.GetObsoleteAttribute): Returns instance of
18630 ObsoleteAttribute when type is obsolete.
18633 (TypeContainer.VerifyObsoleteAttribute): Override.
18634 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18635 (MethodCode.VerifyObsoleteAttribute): Override.
18636 (MemberBase.VerifyObsoleteAttribute): Override.
18639 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18640 and report proper error.
18643 Delegate.VerifyObsoleteAttribute): Override.
18646 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18647 and report proper error.
18648 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18651 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18655 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18656 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18657 Added test for ObsoleteAttribute.
18660 (Catch): Derived from Statement.
18662 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18664 Fixed bug #59071 & cs0160.cs
18666 * statement.cs (Try.Resolve): Check here whether order of catch
18667 clauses matches their dependencies.
18669 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18671 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18672 caused a regression: #59343. Referencing nested classes from an
18673 assembly stopped working.
18675 2004-05-31 Martin Baulig <martin@ximian.com>
18677 MCS is now frozen for beta 2.
18679 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18681 * convert.cs: add a trivial cache for overload operator resolution.
18683 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18685 * decl.cs: If possible, use lookuptypedirect here. We can only do
18686 this if there is no `.' after the namespace. Avoids using
18687 LookupType, which does lots of slow processing.
18688 (FindNestedType) New method, does what it says :-).
18689 * namespace.cs: use LookupTypeDirect.
18690 * rootcontext.cs: use membercache, if possible.
18691 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18693 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18696 According to the spec,
18698 In a member access of the form E.I, if E is a single identifier,
18699 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18700 field, property, localvariable, or parameter with the same type as
18701 the meaning of E as a type-name (§3.8), then both possible
18702 meanings of E are permitted.
18704 We did not check that E as a simple-name had the same type as E as
18707 This trivial check gives us 5-7% on bootstrap time.
18709 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18711 * expression.cs (Invocation.OverloadResolve): Avoid the
18712 use of hashtables and boxing here by allocating on demand.
18714 2004-05-30 Martin Baulig <martin@ximian.com>
18716 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18717 we're doing a silent lookup. Don't try to lookup nested types in
18718 TypeManager.object_type (thanks to Ben Maurer).
18720 2004-05-30 Martin Baulig <martin@ximian.com>
18722 Committing a patch from Ben Maurer.
18724 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18726 2004-05-29 Martin Baulig <martin@ximian.com>
18728 * class.cs (IMethodData.ShouldIgnore): New method.
18730 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18731 `Location' argument, we don't need it anywhere. Use
18732 `IMethodData.ShouldIgnore ()' instead of
18733 `MethodData.GetMethodFlags ()'.
18734 (TypeManager.AddMethod): Removed.
18735 (TypeManager.AddMethod2): Renamed to AddMethod.
18737 2004-05-29 Martin Baulig <martin@ximian.com>
18739 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18741 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18742 converting from a class type S to an interface type and we already
18743 have an object on the stack, don't box it again. Fixes #52578.
18745 2004-05-29 Martin Baulig <martin@ximian.com>
18747 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18748 Added support for `params' parameters. Fixes #59267.
18750 2004-05-29 Martin Baulig <martin@ximian.com>
18752 * literal.cs (NullPointer): Provide a private .ctor which sets
18753 `type' to TypeManager.object_type. Fixes #59048.
18755 2004-05-29 Martin Baulig <martin@ximian.com>
18757 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18758 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18760 * ecore.cs (EventExpr.instance_expr): Make the field private.
18762 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18764 Fixed bug #50080 & cs0214-2.cs
18765 * expression.cs (Cast.DoResolve): Check unsafe context here.
18767 * statement.cs (Resolve.DoResolve): Likewise.
18769 2004-05-26 Martin Baulig <martin@ximian.com>
18771 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18773 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18774 (RootContext.LookupType): Pass down the `silent' flag.
18776 2004-05-25 Martin Baulig <martin@ximian.com>
18779 (MethodGroupExpr.IdenticalTypeName): New public property.
18780 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18781 expression actually refers to a type.
18783 2004-05-25 Martin Baulig <martin@ximian.com>
18785 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18786 for #56176 and made it actually work.
18788 2004-05-25 Martin Baulig <martin@ximian.com>
18790 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18791 (FieldExpr, PropertyExpr): Override and implement
18792 CacheTemporaries. Fixes #52279.
18794 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18796 * location.cs: In the new compiler listing a file twice is a
18797 warning, not an error.
18799 2004-05-24 Martin Baulig <martin@ximian.com>
18801 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18802 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18804 2004-05-24 Martin Baulig <martin@ximian.com>
18806 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18807 walking the `using' list. Fixes #53921.
18809 2004-05-24 Martin Baulig <martin@ximian.com>
18811 * const.cs (Const.LookupConstantValue): Added support for
18812 EmptyCast's; fixes #55251.
18814 2004-05-24 Martin Baulig <martin@ximian.com>
18816 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18817 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18818 which does the CS0135 check. The reason is that we first need to
18819 check whether the variable actually exists.
18821 2004-05-24 Martin Baulig <martin@ximian.com>
18823 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18824 than RootContext.LookupType() to find the explicit interface
18825 type. Fixes #58584.
18827 2004-05-24 Raja R Harinath <rharinath@novell.com>
18829 * Makefile: Simplify. Use executable.make.
18830 * mcs.exe.sources: New file. List of sources of mcs.exe.
18832 2004-05-24 Anders Carlsson <andersca@gnome.org>
18836 Use the invariant culture when doing String.Compare for CLS case
18839 2004-05-23 Martin Baulig <martin@ximian.com>
18841 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18842 don't have any dots. Fixes #52622, added cs0246-8.cs.
18844 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18846 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18848 * class.cs (MemberBase.Define): Reuse MemberType member for
18849 resolved type. Other methods can use it too.
18851 2004-05-23 Martin Baulig <martin@ximian.com>
18853 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18854 the variable also exists in the current block (otherwise, we need
18855 to report a CS0103). Fixes #58670.
18857 2004-05-23 Martin Baulig <martin@ximian.com>
18859 * flowanalysis.cs (Reachability.Reachable): Compute this
18860 on-the-fly rather than storing it as a field.
18862 2004-05-23 Martin Baulig <martin@ximian.com>
18864 * flowanalysis.cs (Reachability.And): Manually compute the
18865 resulting `barrier' from the reachability.
18867 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18870 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18871 instance of ObsoleteAttribute when symbol is obsolete.
18874 (IMethodData): Extended interface for ObsoleteAttribute support.
18876 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18878 * attribute.cs: Fix bug #55970
18880 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18884 (GetObsoleteAttribute): New method. Creates the instance of
18886 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18887 ObsoleteAttribute when member is obsolete.
18888 (AttributeTester.Report_ObsoleteMessage): Common method for
18889 Obsolete error/warning reporting.
18892 (TypeContainer.base_classs_type): New member for storing parent type.
18895 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18896 for this MemberCore.
18898 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18900 * attribute.cs, const.cs: Fix bug #58590
18902 2004-05-21 Martin Baulig <martin@ximian.com>
18904 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18905 out parameters if the end of the method is unreachable. Fixes
18908 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18910 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18911 Hari was right, why extra method.
18913 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18915 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18917 2004-05-20 Martin Baulig <martin@ximian.com>
18919 Merged this back from gmcs to keep the differences to a minumum.
18921 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18922 instead of a Declspace.
18923 (Attribute.ResolveType): Likewise.
18924 (Attributes.Search): Likewise.
18925 (Attributes.Contains): Likewise.
18926 (Attributes.GetClsCompliantAttribute): Likewise.
18928 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18930 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18933 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18935 Fix bug #58688 (MCS does not report error when the same attribute
18938 * attribute.cs (Attribute.Emit): Distinction between null and default.
18940 2004-05-19 Raja R Harinath <rharinath@novell.com>
18942 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18943 of a top-level attribute without an attribute target.
18944 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18946 (Attribute.Conditional_GetConditionName),
18947 (Attribute.Obsolete_GetObsoleteMessage): Update.
18948 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18949 part of ScanForIndexerName.
18950 (Attribute.CanIgnoreInvalidAttribute): New function.
18951 (Attribute.ScanForIndexerName): Move to ...
18952 (Attributes.ScanForIndexerName): ... here.
18953 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18954 (Attributes.Search): New internal variant that can choose not to
18955 complain if types aren't resolved. The original signature now
18957 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18958 complaints suppressed.
18959 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18960 only if it not useful.
18961 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18962 top-level for attributes that are shared between the assembly
18963 and a top-level class.
18964 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18965 * class.cs: Update to reflect changes.
18966 (DefineIndexers): Fuse loops.
18967 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18968 a couple more variants of attribute names.
18970 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18972 Fix bug #52585 (Implemented explicit attribute declaration)
18975 (Attributable.ValidAttributeTargets): New abstract method. It gets
18976 list of valid attribute targets for explicit target declaration.
18977 (Attribute.Target): It holds target itself.
18978 (AttributeSection): Removed.
18979 (Attribute.CheckTargets): New method. It checks whether attribute
18980 target is valid for the current element.
18983 (EventProperty): New class. For events that are declared like
18984 property (with add and remove accessors).
18985 (EventField): New class. For events that are declared like field.
18988 * cs-parser.jay: Implemented explicit attribute target declaration.
18990 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18991 Override ValidAttributeTargets.
18994 (ReturnParameter): Class for applying custom attributes on
18996 (ParameterAtribute): New class. Class for applying custom
18997 attributes on the parameter type.
18999 2004-05-17 Miguel de Icaza <miguel@ximian.com>
19001 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
19004 (Method): Allow UNSAFE here.
19006 * modifiers.cs: Support unsafe reporting.
19008 2004-05-17 Marek Safar <marek.safar@seznam.cz>
19010 * decl.cs: Fix bug #58478.
19012 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19014 * statement.cs: When checking for unreachable code on an EmptyStatement,
19015 set the location. Fixes bug #58488.
19017 2004-05-13 Miguel de Icaza <miguel@ximian.com>
19019 * driver.cs: Add -pkg handling.
19021 From Gonzalo: UseShelLExecute=false
19023 2004-05-12 Marek Safar <marek.safar@seznam.cz>
19026 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
19028 (Attribute.IsClsCompliaceRequired): Moved to base for better
19030 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
19031 when attribute is AttributeUsageAttribute.
19032 (Attribute.GetValidTargets): Simplified.
19033 (Attribute.GetAttributeUsage): New method returns AttributeUsage
19034 attribute for this type.
19035 (Attribute.ApplyAttributes): Method renamed to Emit and make
19037 (GlobalAttributeSection): New class for special handling of global
19038 attributes (assembly, module).
19039 (AttributeSection.Emit): New method.
19041 * class.cs: Implemented Attributable abstract methods.
19042 (MethodCore.LabelParameters): Moved to Parameter class.
19043 (Accessor): Is back simple class.
19044 (PropertyMethod): Implemented Attributable abstract class.
19045 (DelegateMethod): Implemented Attributable abstract class.
19046 (Event): New constructor for disctintion between normal Event
19047 and Event with accessors.
19049 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
19051 * codegen.cs, const.cs, decl.cs, delegate.cs:
19052 (CommonAssemblyModulClass): Implemented Attributable abstract class
19055 * enum.cs: Implement IAttributeSupport interface.
19056 (EnumMember): New class for emum members. Implemented Attributable
19060 (ParameterBase): Is abstract.
19061 (ReturnParameter): New class for easier [return:] attribute handling.
19063 * typemanager.cs: Removed builder_to_attr.
19065 2004-05-11 Raja R Harinath <rharinath@novell.com>
19068 * attribute.cs (Attribute.GetPositionalValue): New function.
19069 * class.cs (TypeContainer.VerifyMembers): New function.
19070 (TypeContainer.Emit): Use it.
19071 (ClassOrStruct): New base class for Class and Struct.
19072 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
19073 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
19075 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
19076 then each non-static field should have a FieldOffset attribute.
19077 Otherwise, none of the fields should have a FieldOffset attribute.
19078 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
19079 and FieldOffset attributes.
19080 * typemanager.cs (TypeManager.struct_layout_attribute_type)
19081 (TypeManager.field_offset_attribute_type): New core types.
19082 (TypeManager.InitCoreTypes): Initialize them.
19084 2004-05-11 Michal Moskal <malekith@pld-linux.org>
19086 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
19087 Return correct type.
19090 2004-05-09 Miguel de Icaza <miguel@ximian.com>
19092 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
19093 be implicitly converted to ulong.
19095 * expression.cs: The logic for allowing operator &, | and ^ worked
19096 was wrong, it worked before because we did not report an error in
19097 an else branch. Fixes 57895.
19099 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
19100 allow volatile fields to be reference types.
19102 2004-05-07 Miguel de Icaza <miguel@ximian.com>
19104 * driver.cs: Add support for /debug-
19106 2004-05-07 Raja R Harinath <rharinath@novell.com>
19108 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
19109 Add a 'complain' parameter to silence errors.
19110 (Attribute.Resolve): Update to changes. Put in sanity check to catch
19111 silently overlooked type-resolutions.
19112 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
19113 to reflect changes.
19114 (Attributes.Search): New function.
19115 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
19116 (Attributes.GetAttributeFullName): Remove hack.
19117 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
19118 Update to reflect changes.
19119 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
19120 Use Attributes.Search instead of nested loops.
19122 2004-05-07 Marek Safar <marek.safar@seznam.cz>
19125 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
19126 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
19127 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
19129 * report.cs: (Report.Warning): Renamed to Warning_T because of
19130 parameter collision.
19132 2004-05-05 Raja R Harinath <rharinath@novell.com>
19134 * expression.cs (MemberAccess.ResolveMemberAccess):
19135 Exit with non-zero status after Report.Error.
19136 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
19138 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
19140 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19142 * support.cs: Don't hang when the file is empty.
19144 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19146 * support.cs: In SeekableStreamReader, compute the preamble size of the
19147 underlying stream. Position changes should take into account that initial
19150 2004-05-03 Todd Berman <tberman@sevenl.net>
19152 * driver.cs: remove unused GetSysVersion function.
19154 2004-05-03 Todd Berman <tberman@sevenl.net>
19156 * driver.cs: Remove the hack from saturday, as well as the hack
19157 from jackson (LoadAssemblyFromGac), also adds the CWD to the
19158 link_paths to get that bit proper.
19160 2004-05-01 Todd Berman <tberman@sevenl.net>
19162 * driver.cs: Try a LoadFrom before a Load, this checks the current
19163 path. This is currently a bug in mono that is be fixed, however, this
19164 provides a workaround for now. This will be removed when the bug
19167 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
19169 * CryptoConvert.cs: Updated to latest version. Fix issue with
19170 incomplete key pairs (#57941).
19172 2004-05-01 Todd Berman <tberman@sevenl.net>
19174 * driver.cs: Remove '.' from path_chars, now System.* loads properly
19177 2004-04-30 Jackson Harper <jackson@ximian.com>
19179 * codegen.cs: Open keys readonly.
19181 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19183 * typemanager.cs: don't report cyclic struct layout when a struct
19184 contains 2 or more fields of the same type. Failed for Pango.AttrShape
19185 which has 2 Pango.Rectangle fields.
19187 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
19189 * expression.cs: Handle IntPtr comparisons with IL code
19190 rather than a method call.
19192 2004-04-29 Martin Baulig <martin@ximian.com>
19194 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
19195 the list of PropertyInfo's in class hierarchy and find the
19196 accessor. Fixes #56013.
19198 2004-04-29 Martin Baulig <martin@ximian.com>
19200 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
19202 2004-04-29 Martin Baulig <martin@ximian.com>
19204 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19206 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
19208 2004-04-29 Martin Baulig <martin@ximian.com>
19210 * class.cs (ConstructorInitializer.Resolve): Check whether the
19211 parent .ctor is accessible. Fixes #52146.
19213 2004-04-29 Martin Baulig <martin@ximian.com>
19215 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19217 * statement.cs (Using.EmitLocalVariableDecls): Use
19218 TypeManager.idisposable_type, not typeof (IDisposable).
19219 (Foreach.EmitCollectionForeach): Added support for valuetypes.
19221 2004-04-29 Martin Baulig <martin@ximian.com>
19223 * class.cs (Event.Define): Don't emit the field and don't set
19224 RTSpecialName and SpecialName for events on interfaces. Fixes
19227 2004-04-29 Raja R Harinath <rharinath@novell.com>
19229 Refactor Attribute.ApplyAttributes.
19230 * attribute.cs (Attributable): New base class for objects that can
19231 have Attributes applied on them.
19232 (Attribute): Make AttributeUsage fields public.
19233 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19234 (Attribute.IsInternalCall): New property.
19235 (Attribute.UsageAttr): Convert to a public read-only property.
19236 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19237 (Attribute.ResolveType, Attribute.Resolve)
19238 (Attribute.ScanForIndexerName): Update to reflect changes.
19239 (Attribute.CheckAttributeTarget): Re-format.
19240 (Attribute.ApplyAttributes): Refactor, to various
19241 Attributable.ApplyAttributeBuilder methods.
19242 * decl.cs (MemberCore): Make Attributable.
19243 * class.cs (Accessor): Make Attributable.
19244 (MethodData.ApplyAttributes): Use proper attribute types, not
19246 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19247 (TypeContainer.ApplyAttributeBuilder)
19248 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19249 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19250 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19251 (Operator.ApplyAttributeBuilder): New factored-out methods.
19252 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19253 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19254 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19255 * parameter.cs (ParameterBase): New Attributable base class
19256 that can also represent Return types.
19257 (Parameter): Update to the changes.
19259 2004-04-29 Jackson Harper <jackson@ximian.com>
19261 * driver.cs: Prefer the corlib system version when looking for
19262 assemblies in the GAC. This is still a hack, but its a better hack
19265 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19267 * decl.cs, enum.cs: Improved error 3005 reporting.
19269 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19270 (related_symbols): New private member for list of symbols
19271 related to reported error/warning.
19273 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19275 2004-04-29 Martin Baulig <martin@ximian.com>
19277 * ecore.cs (Expression.Constantify): If we're an enum and
19278 TypeManager.TypeToCoreType() doesn't give us another type, use
19279 t.UnderlyingSystemType. Fixes #56178.
19281 2004-04-29 Martin Baulig <martin@ximian.com>
19283 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19284 interfaces and for each interface, only add members directly
19285 declared in that interface. Fixes #53255.
19287 2004-04-28 Martin Baulig <martin@ximian.com>
19289 * expression.cs (ConditionalLogicalOperator): Use a temporary
19290 variable for `left' to avoid that we evaluate it more than once;
19293 2004-04-28 Martin Baulig <martin@ximian.com>
19295 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19298 2004-04-28 Martin Baulig <martin@ximian.com>
19300 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19303 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19304 whether the type is not void (CS1547).
19306 2004-04-28 Martin Baulig <martin@ximian.com>
19308 * expression.cs (Unary.DoResolveLValue): Override this and report
19309 CS0131 for anything but Operator.Indirection.
19311 2004-04-28 Martin Baulig <martin@ximian.com>
19313 Committing a patch from Ben Maurer; see bug #50820.
19315 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19318 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19321 2004-04-28 Martin Baulig <martin@ximian.com>
19323 Committing a patch from Ben Maurer; see bug #50820.
19325 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19328 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19331 2004-04-28 Martin Baulig <martin@ximian.com>
19333 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19334 (Block.AddLabel): Call DoLookupLabel() to only search in the
19337 2004-04-28 Martin Baulig <martin@ximian.com>
19339 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19340 comparing StringConstants and NullLiterals in Equality and Inequality.
19342 2004-04-28 Jackson Harper <jackson@ximian.com>
19344 * driver.cs: Attempt to load referenced assemblies from the
19345 GAC. This is the quick and dirty version of this method that
19346 doesnt take into account versions and just takes the first
19347 canidate found. Will be good enough for now as we will not have more
19348 then one version installed into the GAC until I update this method.
19350 2004-04-28 Martin Baulig <martin@ximian.com>
19352 * typemanager.cs (TypeManager.CheckStructCycles): New public
19353 static method to check for cycles in the struct layout.
19355 * rootcontext.cs (RootContext.PopulateTypes): Call
19356 TypeManager.CheckStructCycles() for each TypeContainer.
19357 [Note: We only need to visit each type once.]
19359 2004-04-28 Martin Baulig <martin@ximian.com>
19361 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19363 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19364 success and added `out object value'. Use a `bool resolved' field
19365 to check whether we've already been called rather than
19366 `ConstantValue != null' since this breaks for NullLiterals.
19368 2004-04-28 Raja R Harinath <rharinath@novell.com>
19370 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19371 setting of this flag, since the 'set' method may be non-public.
19373 2004-04-28 Raja R Harinath <rharinath@novell.com>
19375 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19376 check on current_vector.Block.
19378 2004-04-27 Martin Baulig <martin@ximian.com>
19380 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19381 a field initializer. Fixes #56459.
19383 2004-04-27 Martin Baulig <martin@ximian.com>
19385 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19386 we're not attempting to use an indexer. Fixes #52154.
19388 2004-04-27 Martin Baulig <martin@ximian.com>
19390 * statement.cs (Return): Don't create a return label if we don't
19391 need it; reverts my change from January 20th. Thanks to Ben
19394 2004-04-27 Martin Baulig <martin@ximian.com>
19396 According to the spec, `goto' can only leave a nested scope, but
19399 * statement.cs (Block.LookupLabel): Only lookup in the current
19400 block, don't recurse into parent or child blocks.
19401 (Block.AddLabel): Check in parent and child blocks, report
19402 CS0140/CS0158 if we find a duplicate.
19403 (Block): Removed this indexer for label lookups.
19404 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19405 this already does the error reporting for us.
19408 (FlowBranching.UsageVector.Block): New public variable; may be null.
19409 (FlowBranching.CreateSibling): Added `Block' argument.
19410 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19411 label for the target of a `goto' and check whether we're not
19412 leaving a `finally'.
19414 2004-04-27 Martin Baulig <martin@ximian.com>
19416 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19417 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19420 2004-04-27 Martin Baulig <martin@ximian.com>
19422 * statement.cs (Block.AddLabel): Also check for implicit blocks
19423 and added a CS0158 check.
19425 2004-04-27 Martin Baulig <martin@ximian.com>
19427 * flowanalysis.cs (FlowBranchingLoop): New class.
19428 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19429 UsageVector's instead of an ArrayList.
19430 (FlowBranching.Label): Likewise.
19431 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19432 (FlowBranching.AddBreakVector): New method.
19434 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19436 * attribute.cs: Small regression fix: only convert the type if we
19437 the type is different, fixes System.Drawing build.
19439 2004-04-27 Martin Baulig <martin@ximian.com>
19441 * attribute.cs (Attribute.Resolve): If we have a constant value
19442 for a named field or property, implicity convert it to the correct
19445 2004-04-27 Raja R Harinath <rharinath@novell.com>
19447 * statement.cs (Block.Block): Implicit blocks share
19448 'child_variable_names' fields with parent blocks.
19449 (Block.AddChildVariableNames): Remove.
19450 (Block.AddVariable): Mark variable as "used by a child block" in
19451 every surrounding block.
19452 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19453 been used in a child block, complain about violation of "Invariant
19454 meaning in blocks" rule.
19455 * cs-parser.jay (declare_local_variables): Don't use
19456 AddChildVariableNames.
19457 (foreach_statement): Don't create an implicit block: 'foreach'
19458 introduces a scope.
19460 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19462 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19463 converting from 0L to ulong. Fixes 57522.
19465 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19467 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19468 derived class hides via 'new' keyword field from base class (test-242.cs).
19469 TODO: Handle this in the more general way.
19471 * class.cs (CheckBase): Ditto.
19473 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19475 * decl.cs (caching_flags): New member for storing cached values
19477 (MemberCore.Flags): New enum where bit flags for caching_flags
19479 (MemberCore.cls_compliance): Moved to caching_flags.
19480 (DeclSpace.Created): Moved to caching_flags.
19482 * class.cs: Use caching_flags instead of DeclSpace.Created
19484 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19486 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19487 if we are only a derived class, not a nested class.
19489 * typemanager.cs: Same as above, but do this at the MemberLookup
19490 level (used by field and methods, properties are handled in
19491 PropertyExpr). Allow for the qualified access if we are a nested
19494 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19496 * class.cs: Refactoring.
19497 (IMethodData): New inteface; Holds links to parent members
19498 to avoid member duplication (reduced memory allocation).
19499 (Method): Implemented IMethodData interface.
19500 (PropertyBase): New inner classes for get/set methods.
19501 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19502 (Event): New inner classes for add/remove methods.
19503 (Event.DelegateMethod): Implemented IMethodData interface.
19505 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19506 EmitContext (related to class.cs refactoring).
19508 2004-04-21 Raja R Harinath <rharinath@novell.com>
19510 * delegate.cs (Delegate.VerifyApplicability): If the number of
19511 arguments are the same as the number of parameters, first try to
19512 verify applicability ignoring any 'params' modifier on the last
19516 2004-04-16 Raja R Harinath <rharinath@novell.com>
19518 * class.cs (TypeContainer.AddIndexer): Use
19519 'ExplicitInterfaceName' to determine if interface name was
19520 explicitly specified. 'InterfaceType' is not initialized at this time.
19521 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19522 Indexers array is already in the required order. Initialize
19523 'IndexerName' only if there are normal indexers.
19524 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19525 (TypeContainer.Emit): Emit DefaultMember attribute only if
19526 IndexerName is initialized.
19529 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19531 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19534 2004-04-15 Raja R Harinath <rharinath@novell.com>
19536 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19540 * attribute.cs (Attribute.Resolve): Check for duplicate named
19544 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19546 * iterators.cs (MarkYield): track whether we are in an exception,
19547 and generate code accordingly. Use a temporary value to store the
19548 result for our state.
19550 I had ignored a bit the interaction of try/catch with iterators
19551 since their behavior was not entirely obvious, but now it is
19552 possible to verify that our behavior is the same as MS .NET 2.0
19556 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19558 * iterators.cs: Avoid creating temporaries if there is no work to
19561 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19562 Enumerations, use TypeManager.EnumToUnderlying and call
19565 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19568 (This.Emit): Use EmitContext.EmitThis to emit our
19571 (This.EmitAssign): Ditto.
19573 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19574 codepaths, we will move all the functionality into
19577 (FieldExpr.EmitAssign): Ditto.
19579 This fixes several hidden bugs that I uncovered while doing a code
19580 review of this today.
19582 * codegen.cs (EmitThis): reworked so the semantics are more clear
19583 and also support value types "this" instances.
19585 * iterators.cs: Changed so that for iterators in value types, we
19586 do not pass the value type as a parameter.
19588 Initialization of the enumerator helpers is now done in the caller
19589 instead of passing the parameters to the constructors and having
19590 the constructor set the fields.
19592 The fields have now `assembly' visibility instead of private.
19594 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19596 * expression.cs (Argument.Resolve): Check if fields passed as ref
19597 or out are contained in a MarshalByRefObject.
19599 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19600 another compiler type.
19602 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19604 * class.cs (Indexer.Define): use the new name checking method.
19605 Also, return false on an error.
19606 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19607 (is_identifier_[start/part]_character): make static.
19609 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19611 * expression.cs (Binary.ResolveOperator): Do no append strings
19612 twice: since we can be invoked more than once (array evaluation)
19613 on the same concatenation, take care of this here. Based on a fix
19614 from Ben (bug #56454)
19616 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19618 * codegen.cs: Fix another case where CS1548 must be reported (when
19619 delay-sign isn't specified and no private is available #56564). Fix
19620 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19621 error when MCS is used on the MS runtime and we need to delay-sign
19622 (which seems unsupported by AssemblyBuilder - see #56621).
19624 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19626 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19627 (TypeManager.ComputeNamespaces): Faster implementation for
19630 * compiler.csproj: Updated AssemblyName to mcs.
19632 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19634 * rootcontext.cs: Add new types to the boot resolution.
19636 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19637 MulticastDelegate is not allowed.
19639 * typemanager.cs: Add new types to lookup: System.TypedReference
19642 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19643 check for TypedReference or ArgIterator, they are not allowed.
19645 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19646 makes us properly catch 1510 in some conditions (see bug 56016 for
19649 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19651 * CryptoConvert.cs: update from corlib version
19654 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19656 * class.cs (Indexer.Define): Check indexername declaration
19658 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19660 * attribute.cs (IsClsCompliant): Fixed problem with handling
19661 all three states (compliant, not-compliant, undetected).
19663 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19665 * attribute.cs (Attribute): Location is now public.
19666 (Resolve): Store resolved arguments (pos_values) in attribute class.
19667 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19668 (GetClsCompliantAttributeValue): New method that gets
19669 CLSCompliantAttribute value.
19670 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19671 if exists else null.
19672 (AttributeTester): New class for CLS-Compliant verification routines.
19674 * class.cs (Emit): Add CLS-Compliant verification.
19675 (Method.GetSignatureForError): Implemented.
19676 (Constructor.GetSignatureForError): Implemented
19677 (Constructor.HasCompliantArgs): Returns if constructor has
19678 CLS-Compliant arguments.
19679 (Constructor.Emit): Override.
19680 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19681 is needed to test only parameters.
19682 (FieldBase.GetSignatureForError): Implemented.
19683 (TypeContainer): New member for storing base interfaces.
19684 (TypeContainer.FindMembers): Search in base interfaces too.
19686 * codegen.cs (GetClsComplianceAttribute): New method that gets
19687 assembly or module CLSCompliantAttribute value.
19688 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19690 (ModuleClass.Emit): Add error 3012 test.
19692 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19694 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19695 state for all decl types.
19696 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19697 if CLS-Compliant tests are required.
19698 (IsClsCompliaceRequired): New method. Analyze whether code
19699 must be CLS-Compliant.
19700 (IsExposedFromAssembly): New method. Returns true when MemberCore
19701 is exposed from assembly.
19702 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19703 value or gets cached value.
19704 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19705 is explicitly marked with CLSCompliantAttribute.
19706 (IsIdentifierClsCompliant): New abstract method. This method is
19707 used to testing error 3005.
19708 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19709 for identifier and parameters CLS-Compliant testing.
19710 (VerifyClsCompliance): New method. The main virtual method for
19711 CLS-Compliant verifications.
19712 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19713 null. I don't know why is null (too many public members !).
19714 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19715 and get value of first CLSCompliantAttribute that found.
19717 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19718 (VerifyClsCompliance): Override and add extra tests.
19720 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19721 clscheck- disable CLS-Compliant verification event if assembly is has
19722 CLSCompliantAttribute(true).
19724 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19725 ApllyAttribute is now called in emit section as in the other cases.
19726 Possible future Emit integration.
19727 (IsIdentifierClsCompliant): New override.
19728 (VerifyClsCompliance): New override.
19729 (GetEnumeratorName): Returns full enum name.
19731 * parameter.cs (GetSignatureForError): Implemented.
19733 * report.cs (WarningData): New struct for Warning message information.
19734 (LocationOfPreviousError): New method.
19735 (Warning): New method. Reports warning based on the warning table.
19736 (Error_T): New method. Reports error based on the error table.
19738 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19739 verifications are done here.
19741 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19743 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19744 CLSCompliantAttribute.
19745 (all_imported_types): New member holds all imported types from other
19747 (LoadAllImportedTypes): New method fills static table with exported types
19748 from all referenced assemblies.
19749 (Modules): New property returns all assembly modules.
19751 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19753 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19754 throwing a parser error.
19756 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19757 which removes the hardcoded get_/set_ prefixes for properties, as
19758 IL allows for the properties to be named something else.
19762 * expression.cs: Do not override operand before we know if it is
19763 non-null. Fix 56207
19765 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19767 * typemanager.cs: support for pinned variables.
19769 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19771 * decl.cs, typemanager.cs: Avoid using an arraylist
19772 as a buffer if there is only one result set.
19774 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19776 * expression.cs: Make sure you cant call a static method
19777 with an instance expression, bug #56174.
19779 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19781 * class.cs (IsDuplicateImplementation): Improve error reporting to
19782 flag 663 (method only differs in parameter modifier).
19784 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19785 in preprocessor directives.
19787 * location.cs (LookupFile): Allow for the empty path.
19789 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19790 better approach for some of that patch, but its failing with the
19791 CharSet enumeration. For now try/catch will do.
19793 * typemanager.cs: Do not crash if a struct does not have fields.
19796 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19798 * expression.cs: cs0213, cant fix a fixed expression.
19801 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19803 * cs-parser.jay: detect invalid embeded statements gracefully.
19806 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19808 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19811 the invocation type may not be a subclass of the tye of the item/
19812 The type of the item must be a subclass of the invocation item.
19817 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19819 * attribute.cs: Added methods to get a string and a bool from an
19820 attribute. Required to information from AssemblyKeyFileAttribute,
19821 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19822 * codegen.cs: Modified AssemblyName creation to include support for
19823 strongnames. Catch additional exceptions to report them as CS1548.
19824 * compiler.csproj: Updated include CryptoConvert.cs.
19825 * compiler.csproj.user: Removed file - user specific configuration.
19826 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19827 Mono.Security assembly. The original class is maintained and tested in
19828 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19829 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19830 like CSC 8.0 (C# v2) supports.
19831 * Makefile: Added CryptoConvert.cs to mcs sources.
19832 * rootcontext.cs: Added new options for strongnames.
19834 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19836 * driver.cs: For --expect-error, report error code `2'
19837 if the program compiled with no errors, error code `1' if
19838 it compiled with an error other than the one expected.
19840 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19842 * compiler.csproj: Updated for Visual Studio .NET 2003.
19843 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19844 * compiler.sln: Updated for Visual Studio .NET 2003.
19846 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19848 * expression.cs: Fix bug #47234. We basically need to apply the
19849 rule that we prefer the conversion of null to a reference type
19850 when faced with a conversion to 'object' (csc behaviour).
19852 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19854 * statement.cs: Shorter form for foreach, eliminates
19855 a local variable. r=Martin.
19857 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19859 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19860 checks if we can use brtrue/brfalse to test for 0.
19861 * expression.cs: use the above in the test for using brtrue/brfalse.
19862 cleanup code a bit.
19864 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19866 * expression.cs: Rewrite string concat stuff. Benefits:
19868 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19869 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19870 rather than a concat chain.
19872 * typemanager.cs: Add lookups for more concat overloads.
19874 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19876 * expression.cs: Emit shorter il code for array init.
19893 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19895 * statement.cs: Before, two switch blocks would be merged if the
19896 total size of the blocks (end_item - begin_item + 1) was less than
19897 two times the combined sizes of the blocks.
19899 Now, it will only merge if after the merge at least half of the
19904 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19906 * class.cs : csc build fix for GetMethods(). See bug #52503.
19908 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19910 * expression.cs: Make sure fp comparisons work with NaN.
19911 This fixes bug #54303. Mig approved this patch a long
19912 time ago, but we were not able to test b/c the runtime
19915 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19917 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19919 2004-03-19 Martin Baulig <martin@ximian.com>
19921 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19922 error here and not in our caller.
19924 2004-03-19 Martin Baulig <martin@ximian.com>
19926 * interface.cs: Completely killed this file.
19927 (Interface): We're now a TypeContainer and live in class.cs.
19929 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19930 argument; we're now also called for interfaces.
19931 (TypeContainer.DefineMembers): Allow this method being called
19933 (TypeContainer.GetMethods): New public method; formerly known as
19934 Interface.GetMethod(). This is used by PendingImplementation.
19935 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19936 it's now private and non-static.
19937 (Interface): Moved this here; it's now implemented similar to
19939 (Method, Property, Event, Indexer): Added `bool is_interface'
19940 argument to their .ctor's.
19941 (MemberBase.IsInterface): New public field.
19943 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19944 instances instead of InterfaceMethod, InterfaceProperty, etc.
19945 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19946 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19948 2004-03-19 Martin Baulig <martin@ximian.com>
19950 * class.cs (MethodCore.IsDuplicateImplementation): New private
19951 method which does the CS0111 checking.
19952 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19953 Use IsDuplicateImplementation().
19955 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19957 * decl.cs (FindMemberToOverride): New method to find the correct
19958 method or property to override in the base class.
19960 - Make Method/Property use the above method to find the
19961 version in the base class.
19962 - Remove the InheritableMemberSignatureCompare as it is now
19965 This patch makes large code bases much faster to compile, as it is
19966 O(n) rather than O(n^2) to do this validation.
19968 Also, it fixes bug 52458 which is that nested classes are not
19969 taken into account when finding the base class member.
19971 Reviewed/Approved by Martin.
19973 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19975 * interface.cs: In all interface classes removed redundant
19976 member initialization.
19978 2004-03-16 Martin Baulig <martin@ximian.com>
19980 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19982 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19984 * decl.cs (DefineTypeAndParents): New helper method to define a
19985 type's containers before the type itself is defined; This is a
19986 bug exposed by the recent changes to Windows.Forms when an
19987 implemented interface was defined inside a class that had not been
19990 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19992 (Check): Loop correctly to report errors modifiers
19993 (UNSAFE was not in the loop, since it was the same as TOP).
19995 * interface.cs: Every interface member now takes a ModFlags,
19996 instead of a "is_new" bool, which we set on the base MemberCore.
19998 Every place where we called "UnsafeOk" in the interface, now we
19999 call the proper member (InterfaceMethod.UnsafeOK) instead to get
20000 the unsafe settings from the member declaration instead of the
20001 container interface.
20003 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
20005 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
20006 `set_indexer_name' to the pending bits (one per type).
20008 We fixed a bug today that was picking the wrong method to
20009 override, since for properties the existing InterfaceMethod code
20010 basically ignored the method name. Now we make sure that the
20011 method name is one of the valid indexer names.
20013 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
20015 * support.cs (SeekableStreamReader): Keep track of stream byte
20016 positions and don't mix them with character offsets to the buffer.
20018 Patch from Gustavo Giráldez
20020 2004-03-15 Marek Safar <marek.safar@seznam.cz>
20022 * interface.cs (InterfaceSetGetBase): Removed double member
20023 initialization, base class does it as well.
20025 2004-03-13 Martin Baulig <martin@ximian.com>
20027 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
20028 when compiling corlib.
20030 2004-03-13 Miguel de Icaza <miguel@ximian.com>
20032 * convert.cs (ExplicitConversion): We were reporting an error on
20033 certain conversions (object_type source to a value type, when the
20034 expression was `null') before we had a chance to pass it through
20035 the user defined conversions.
20037 * driver.cs: Replace / and \ in resource specifications to dots.
20040 * class.cs: Add check for duplicate operators. Fixes 52477
20042 2004-03-11 Miguel de Icaza <miguel@ximian.com>
20044 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
20045 that are in the middle of the statements, not only at the end.
20048 * class.cs (TypeContainer.AddField): No longer set the
20049 `HaveStaticConstructor' flag, now we call it
20050 `UserDefineStaticConstructor' to diferentiate the slightly
20051 semantic difference.
20053 The situation is that we were not adding BeforeFieldInit (from
20054 Modifiers.TypeAttr) to classes that could have it.
20055 BeforeFieldInit should be set to classes that have no static
20060 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
20062 And most importantly Zoltan's comment:
20064 http://bugzilla.ximian.com/show_bug.cgi?id=44229
20066 "I think beforefieldinit means 'it's ok to initialize the type sometime
20067 before its static fields are used', i.e. initialization does not need
20068 to be triggered by the first access to the type. Setting this flag
20069 helps the JIT to compile better code, since it can run the static
20070 constructor at JIT time, and does not need to generate code to call it
20071 (possibly lots of times) at runtime. Unfortunately, mcs does not set
20072 this flag for lots of classes like String.
20074 csc sets this flag if the type does not have an explicit static
20075 constructor. The reasoning seems to be that if there are only static
20076 initalizers for a type, and no static constructor, then the programmer
20077 does not care when this initialization happens, so beforefieldinit
20080 This bug prevents the AOT compiler from being usable, since it
20081 generates so many calls to mono_runtime_class_init that the AOT code
20082 is much slower than the JITted code. The JITted code is faster,
20083 because it does not generate these calls if the vtable is type is
20084 already initialized, which is true in the majority of cases. But the
20085 AOT compiler can't do this."
20087 2004-03-10 Miguel de Icaza <miguel@ximian.com>
20089 * class.cs (MethodData.Emit): Refactor the code so symbolic
20090 information is generated for destructors; For some reasons we
20091 were taking a code path that did not generate symbolic information
20094 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
20096 * class.cs: Create a Constructor.CheckBase method that
20097 takes care of all validation type code. The method
20098 contains some code that was moved from Define.
20100 It also includes new code that checks for duplicate ctors.
20101 This fixes bug #55148.
20103 2004-03-09 Joshua Tauberer <tauberer@for.net>
20105 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
20106 a { ... }-style array creation invokes EmitStaticInitializers
20107 which is not good for reference-type arrays. String, decimal
20108 and now null constants (NullCast) are not counted toward
20109 static initializers.
20111 2004-03-05 Martin Baulig <martin@ximian.com>
20113 * location.cs (SourceFile.HasLineDirective): New public field;
20114 specifies whether the file contains or is referenced by a "#line"
20116 (Location.DefineSymbolDocuments): Ignore source files which
20117 either contain or are referenced by a "#line" directive.
20119 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
20121 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
20122 direct access to our parent, so check the method inline there.
20124 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
20126 * expression.cs (Invocation.EmitCall): Miguel's last commit
20127 caused a regression. If you had:
20132 In Foo the implict this would be null.
20134 2004-02-27 Miguel de Icaza <miguel@ximian.com>
20136 * expression.cs (Invocation.EmitCall): If the method is not
20137 virtual, do not emit a CallVirt to it, use Call.
20139 * typemanager.cs (GetFullNameSignature): Improve the method to
20140 cope with ".ctor" and replace it with the type name.
20142 * class.cs (ConstructorInitializer.Resolve): Now the method takes
20143 as an argument the ConstructorBuilder where it is being defined,
20144 to catch the recursive constructor invocations.
20146 2004-02-26 Miguel de Icaza <miguel@ximian.com>
20148 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
20149 routines to check if a type is an enumerable/enumerator allow
20150 classes that implement the IEnumerable or IEnumerator interfaces.
20152 * class.cs (Property, Operator): Implement IIteratorContainer, and
20153 implement SetYields.
20155 (Property.Define): Do the block swapping for get_methods in the
20156 context of iterators. We need to check if Properties also
20157 include indexers or not.
20159 (Operator): Assign the Block before invoking the
20160 OperatorMethod.Define, so we can trigger the Iterator code
20163 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
20164 Property and Operator classes are not created when we parse the
20165 declarator but until we have the block completed, so we use a
20166 singleton SimpleIteratorContainer.Simple to flag whether the
20167 SetYields has been invoked.
20169 We propagate this setting then to the Property or the Operator to
20170 allow the `yield' to function.
20172 2004-02-25 Marek Safar <marek.safar@seznam.cz>
20174 * codegen.cs: Implemented attribute support for modules.
20175 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
20176 Assembly/Module functionality.
20178 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
20179 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
20180 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
20182 2004-02-16 Marek Safar <marek.safar@seznam.cz>
20184 * interface.cs (FindMembers): The operation is performed on all base
20185 interfaces and not only on the first. It is required for future CLS Compliance patch.
20187 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
20189 * statement.cs, codegen.cs:
20190 This patch deals with patterns such as:
20192 public class List : IEnumerable {
20194 public MyEnumerator GetEnumerator () {
20195 return new MyEnumerator(this);
20198 IEnumerator IEnumerable.GetEnumerator () {
20202 public struct MyEnumerator : IEnumerator {
20207 Before, there were a few things we did wrong:
20208 1) we would emit callvirt on a struct, which is illegal
20209 2) we emited ldarg when we needed to emit ldarga
20210 3) we would mistakenly call the interface methods on an enumerator
20211 type that derived from IEnumerator and was in another assembly. For example:
20213 public class MyEnumerator : IEnumerator
20215 Would have the interface methods called, even if there were public impls of the
20216 method. In a struct, this lead to invalid IL code.
20218 2004-02-11 Marek Safar <marek.safar@seznam.cz>
20220 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
20223 * delegate.cs (Define): Fixed crash when delegate type is undefined.
20225 2004-02-11 Miguel de Icaza <miguel@ximian.com>
20227 * cs-parser.jay: Fix small regression: we were not testing V2
20228 compiler features correctly.
20230 * interface.cs: If the emit context is null, then create one
20232 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20234 * decl.cs (GetSignatureForError): New virtual method to get full name
20235 for error messages.
20237 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20238 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20240 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20241 Duplicated members and code in these classes has been removed.
20242 Better encapsulation in these classes.
20244 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20246 * assign.cs (Assign.DoResolve): When dealing with compound
20247 assignments, there is a new rule in ECMA C# 2.4 (might have been
20248 there before, but it is documented here) that states that in:
20252 If b is of type int, and the `op' is a shift-operator, then the
20253 above is evaluated as:
20257 * expression.cs (Binary.ResolveOperator): Instead of testing for
20258 int/uint/long/ulong, try to implicitly convert to any of those
20259 types and use that in pointer arithmetic.
20261 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20262 method to print information for from the type, not from the
20263 null-method we were given.
20265 2004-02-01 Duncan Mak <duncan@ximian.com>
20267 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20268 parsing for cmd, fixes bug #53694.
20270 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20272 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20273 in the member name duplication tests. Property and operator name duplication
20274 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20276 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20278 * interface.cs (PopulateMethod): Fixed crash when interface method
20279 returns not existing type (error test cs0246-3.cs).
20281 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20283 * cs-parser.jay (interface_accessors): Re-write actions to also
20284 store attributes attached to get and set methods. Fix spelling
20287 (inteface_property_declaration): Modify accordingly.
20289 (InterfaceAccessorInfo): New helper class to store information to pass
20290 around between rules that use interface_accessors.
20292 * interface.cs (Emit): Apply attributes on the get and set
20293 accessors of properties and indexers too.
20295 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20296 right MethodBuilder when applying attributes to the get and set accessors.
20298 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20300 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20302 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20304 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20306 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20308 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20309 changes that treat `yield' specially when present before `break'
20310 or `return' tokens.
20312 * cs-tokenizer.cs: yield is no longer a keyword.
20314 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20316 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20317 setting for default constructors.
20318 For default constructors are almost every time set wrong Modifier. The
20319 generated IL code has been alright. But inside mcs this values was
20320 wrong and this was reason why several of my CLS Compliance tests
20323 2004-01-22 Martin Baulig <martin@ximian.com>
20325 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20326 not a QualifiedIdentifier. This is what `type_name_expression'
20327 was previously doing.
20328 (type_name_expression): Removed; the code is now in
20329 `namespace_or_type_name'.
20330 (qualified_identifier): Removed, use `namespace_or_type_name'
20332 (QualifiedIdentifier): Removed this class.
20334 2004-01-22 Martin Baulig <martin@ximian.com>
20336 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20337 not a string as alias name.
20339 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20341 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20342 #52730 bug, and instead compute correctly the need to use a
20343 temporary variable when requesting an address based on the
20344 static/instace modified of the field and the constructor.
20346 2004-01-21 Martin Baulig <martin@ximian.com>
20348 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20349 class and namespace before looking up aliases. Fixes #52517.
20351 2004-01-21 Martin Baulig <martin@ximian.com>
20353 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20354 assinged in a 'try'; fixes exception4.cs.
20356 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20357 * class.cs : Implemented parameter-less constructor for TypeContainer
20359 * decl.cs: Attributes are now stored here. New property OptAttributes
20361 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20363 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20365 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20367 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20368 (CSharpSignature): New method for indexer and property signature.
20370 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20372 * pending.cs (IsVirtualFilter): Faster implementation.
20374 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20376 * typemanager.cs: Avoid inclusion of same assembly more than once.
20378 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20380 * cs-parser.jay: Fixed problem where the last assembly attribute
20381 has been applied also to following declaration (class, struct, etc.)
20383 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20385 * class.cs: Added error CS0538, CS0539 reporting.
20386 Fixed crash on Microsoft runtime when field type is void.
20388 * cs-parser.jay: Added error CS0537 reporting.
20390 * pending.cs: Added error CS0535 reporting.
20391 Improved error report for errors CS0536, CS0534.
20393 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20395 Merge a few bits from the Anonymous Method MCS tree.
20397 * statement.cs (ToplevelBlock): New class for toplevel methods,
20398 will hold anonymous methods, lifted variables.
20400 * cs-parser.jay: Create toplevel blocks for delegates and for
20401 regular blocks of code.
20403 2004-01-20 Martin Baulig <martin@ximian.com>
20405 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20406 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20407 and `NeedExplicitReturn'; added `IsLastStatement'.
20408 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20409 have a `ReturnLabel' or we're not unreachable.
20411 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20412 child's reachability; don't just override ours with it. Fixes
20413 #58058 (lluis's example).
20414 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20415 InFinally(), InLoop(), InSwitch() and
20416 BreakCrossesTryCatchBoundary() methods.
20418 * statement.cs (Return): Do all error checking in Resolve().
20419 Unless we are the last statement in a top-level block, always
20420 create a return label and jump to it.
20421 (Break, Continue): Do all error checking in Resolve(); also make
20422 sure we aren't leaving a `finally'.
20423 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20424 statement in a top-level block.
20425 (Block.Flags): Added `IsDestructor'.
20426 (Block.IsDestructor): New public property.
20428 2004-01-20 Martin Baulig <martin@ximian.com>
20430 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20432 2004-01-20 Martin Baulig <martin@ximian.com>
20434 * statement.cs (Statement.ResolveUnreachable): New public method.
20435 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20436 (Block.Resolve): Resolve unreachable statements.
20438 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20440 * expression.cs: We need to fix the case where we do
20441 not have a temp variable here.
20443 * assign.cs: Only expression compound assignments need
20444 temporary variables.
20446 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20448 * flowanalysis.cs: Reduce memory allocation in a few ways:
20449 - A block with no variables should not allocate a bit
20451 - A method with no out parameters does not need any tracking
20452 for assignment of the parameters, so we need not allocate
20455 public readonly Type[] VariableTypes;
20456 public readonly string[] VariableNames;
20457 Are redundant. The data is already stored in the variable
20458 map, so we need not allocate another array for it.
20459 - We need to add alot of checks for if (params | locals) == null
20460 due to the first two changes.
20462 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20464 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20465 implement IMemoryLocation, we store a copy on a local variable and
20466 take the address of it. Patch from Benjamin Jemlich
20468 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20469 to use a special "type_name_expression" rule which reduces the
20470 number of "QualifiedIdentifier" classes created, and instead
20471 directly creates MemberAccess expressions.
20473 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20475 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20476 that fixes #52853. Null literal assignment to ValueType
20478 * class.cs (MethodData.Emit): Instead of checking the name of the
20479 method to determine if its a destructor, create a new derived
20480 class from Method called Destructor, and test for that.
20482 * cs-parser.jay: Create a Destructor object instead of a Method.
20484 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20488 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20490 * expression.cs (Binary.ResolveOperator): Perform an implicit
20491 conversion from MethodGroups to their delegate types on the
20492 Addition operation.
20494 * delegate.cs: Introduce a new class DelegateCreation that is the
20495 base class for `NewDelegate' and `ImplicitDelegateCreation',
20496 factor some code in here.
20498 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20499 conversion from MethodGroups to compatible delegate types.
20501 * ecore.cs (Expression.Resolve): Do not flag error 654
20502 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20503 we allow conversions from MethodGroups to delegate types now.
20505 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20506 assignments in v2 either.
20508 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20510 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20511 static read-only fields in ctors.
20513 Applied patch from Benjamin Jemlich
20515 * expression.cs (UnaryMutator): Avoid leaking local variables.
20517 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20519 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20520 here to return true, as they can be used like this:
20522 (XXX) int.MEMBER ()
20524 Fixed 49836 and all the other dups
20526 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20528 * driver.cs: Implement /win32res and /win32icon.
20530 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20532 * cs-parser.jay: Add a rule to improve error handling for the
20533 common mistake of placing modifiers after the type.
20535 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20537 * cs-parser.jay (interface_event_declaration): Catch
20538 initialization of events on interfaces, and report cs0068
20540 * cs-parser.jay (interface_event_declaration): Catch
20541 initialization of events.
20543 * ecore.cs: Better report missing constructors.
20545 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20546 the error reporting done in the wrong place. Fix.
20548 * expression.cs (Binary.ResolveOperator): Catch the
20549 operator + (E x, E y) error earlier, and later allow for implicit
20550 conversions in operator +/- (E e, U x) from U to the underlying
20553 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20554 52596, if the container class is abstract, the default constructor
20555 is protected otherwise its public (before, we were always public).
20557 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20560 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20561 Jemlich that fixes bug #52597, MCS was generating invalid code for
20562 idisposable structs. Thanks to Ben for following up with this
20565 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20567 * driver.cs: Allow assemblies without code to be generated, fixes
20570 2004-01-07 Nick Drochak <ndrochak@gol.com>
20572 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20574 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20576 * cs-parser.jay: Add rules to improve error reporting if fields or
20577 methods are declared at the namespace level (error 116)
20579 * Add rules to catch event add/remove
20581 2004-01-04 David Sheldon <dave-mono@earth.li>
20583 * expression.cs: Added matching ")" to error message for
20586 2004-01-03 Todd Berman <tberman@gentoo.org>
20588 * ecore.cs, attribute.cs:
20589 Applying fix from #52429.
20591 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20593 * ecore.cs, expression.cs, statement.cs:
20594 Total rewrite of how we handle branching. We
20595 now handle complex boolean expressions with fewer
20596 jumps. As well if (x == 0) no longer emits a ceq.
20598 if (x is Foo) is much faster now, because we generate
20601 Overall, we get a pretty big improvement on our benchmark
20602 tests. The code we generate is smaller and more readable.
20604 I did a full two-stage bootstrap. The patch was reviewed
20605 by Martin and Miguel.
20607 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20609 * cs-parser.jay: Make primary_expression not take a QI.
20610 we dont need this because the member_access rule covers
20611 us here. So we replace the rule with just IDENTIFIER.
20613 This has two good effects. First, we remove a s/r conflict.
20614 Second, we allocate many fewer QualifiedIdentifier objects.
20616 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20618 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20619 set the correct information via SRE. This prevents
20620 hanging on the MS runtime. Fixes #29374.
20622 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20624 * convert.cs: correctly handle conversions to value types
20625 from Enum and ValueType as unboxing conversions.
20627 Fixes bug #52569. Patch by Benjamin Jemlich.
20629 2004-01-02 Ravi Pratap <ravi@ximian.com>
20631 * expression.cs (BetterConversion): Prefer int -> uint
20632 over int -> ulong (csc's behaviour). This fixed bug #52046.
20634 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20636 * decl.cs (MemberCache.FindMembers): now returns a
20639 * typemanager.cs: In general, go with with ^^.
20640 (CopyNewMethods): take an IList.
20641 (RealMemberLookup): Only allocate an arraylist
20642 if we copy from two sets of methods.
20644 This change basically does two things:
20645 1) Fewer array lists allocated due to CopyNewMethods.
20646 2) the explicit cast in MemberList costed ALOT.
20648 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20650 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20651 a hashtable to avoid needless string allocations when an identifier is
20652 used more than once (the common case).
20654 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20656 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20657 is broken, it will not return anything. So, we
20658 have to use the information we have in mcs to
20661 * typemanager.cs: Add a cache for GetInterfaces,
20662 since this will now be used more often (due to ^^)
20664 (GetExplicitInterfaces) New method that gets the
20665 declared, not effective, interfaces on a type
20666 builder (eg, if you have interface IFoo, interface
20667 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20670 This patch makes MCS able to bootstrap itself on
20673 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20675 * expression.cs: Remove the Nop's that Miguel put
20678 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20680 * report.cs, codegen.cs: Give the real stack trace to
20681 the error when an exception is thrown.
20683 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20685 * decl.cs: only allocate hashtables for ifaces if
20688 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20690 * expression.cs: fix the error from cs0121-2.cs
20691 (a parent interface has two child interfaces that
20692 have a function with the same name and 0 params
20693 and the function is called through the parent).
20695 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20697 * class.cs, rootcontext.cs, typmanager.cs: do not
20700 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20702 * codegen.cs: remove stack for the ec flow branching.
20703 It is already a linked list, so no need.
20705 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20707 * Makefile: Allow custom profiler here.
20709 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20711 * typemanager.cs (LookupType):
20712 - Use a static char [], because split takes
20713 a param array for args, so it was allocating
20715 - Do not store true in a hashtable, it boxes.
20717 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20719 * flowanalysis.cs: bytify common enums.
20721 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20723 * modifiers.cs: Add a new set of flags for the
20724 flags allowed on explicit interface impls.
20725 * cs-parser.jay: catch the use of modifiers in
20726 interfaces correctly.
20727 * class.cs: catch private void IFoo.Blah ().
20729 All related to bug #50572.
20731 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20733 * decl.cs: Rewrite the consistant accessability checking.
20734 Accessability is not linear, it must be implemented in
20735 a tableish way. Fixes #49704.
20737 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20739 * expression.cs: Handle negation in a checked context.
20740 We must use subtraction from zero. Fixes #38674.
20742 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20744 * class.cs: Ignore static void main in DLLs.
20745 * rootcontext.cs: Handle the target type here,
20746 since we are have to access it from class.cs
20747 * driver.cs: account for the above.
20749 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20751 * report.cs: Give line numbers and files if available.
20753 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20755 * driver.cs: Implement /addmodule.
20757 * typemanager.cs: Change 'modules' field so it now contains Modules not
20760 2003-12-20 Martin Baulig <martin@ximian.com>
20762 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20763 (FieldBase.IsAssigned): Removed this field.
20764 (FieldBase.SetAssigned): New public method.
20765 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20767 2003-12-20 Martin Baulig <martin@ximian.com>
20769 * expression.cs (LocalVariableReference.DoResolve): Don't set
20770 `vi.Used' if we're called from DoResolveLValue().
20772 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20773 returns the usage vector it just merged into the current one -
20774 pass this one to UsageWarning().
20775 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20776 of the `EmitContext', don't call this recursively on our children.
20778 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20780 * driver.cs: Implement /target:module.
20782 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20784 * support.cs (CharArrayHashtable): New helper class.
20786 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20787 char arrays, not strings, so we can avoid creating a string in
20788 consume_identifier if the identifier is a keyword.
20790 2003-12-16 Martin Baulig <martin@ximian.com>
20792 * statement.cs (LocalInfo.Assigned): Removed this property.
20793 (LocalInfo.Flags): Removed `Assigned'.
20794 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20795 and uses flow analysis.
20796 (Block.UsageWarning): Made this method private.
20797 (Block.Resolve): Call UsageWarning() if appropriate.
20799 * expression.cs (LocalVariableReference.DoResolve): Always set
20800 LocalInfo.Used here.
20802 2003-12-13 Martin Baulig <martin@ximian.com>
20804 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20805 any value here; we're now using flow analysis to figure out
20806 whether a statement/block returns a value.
20808 2003-12-13 Martin Baulig <martin@ximian.com>
20810 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20812 (FlowBranching.MergeFinally): Don't call
20813 `branching.CheckOutParameters()' here, this is called in
20815 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20816 when adding the `finally' vector.
20818 2003-12-13 Martin Baulig <martin@ximian.com>
20821 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20822 actually work and also fix #48962.
20824 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20826 * decl.cs: Do not check System.Object for nested types,
20827 since we know it does not have any. Big bang for buck:
20830 Run 1: 8.35 seconds
20831 Run 2: 8.32 seconds
20832 corlib: 17.99 seconds
20834 Run 1: 8.17 seconds
20835 Run 2: 8.17 seconds
20836 corlib: 17.39 seconds
20838 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20840 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20841 time we are returning 0 members, so we save alot here.
20843 2003-12-11 Martin Baulig <martin@ximian.com>
20845 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20846 `MergeChild()', also just take the `FlowBranching' as argument;
20847 call Merge() on it and return the result.
20848 (FlowBranching.Merge): We don't need to do anything if we just
20851 2003-12-11 Martin Baulig <martin@ximian.com>
20853 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20854 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20855 Maurer for this idea.
20857 2003-12-11 Martin Baulig <martin@ximian.com>
20859 * flowanalysis.cs (MergeResult): This class is now gone; we now
20860 use the `UsageVector' for this. The reason for this is that if a
20861 branching just has one sibling, we don't need to "merge" them at
20862 all - that's the next step to do.
20863 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20866 2003-12-11 Martin Baulig <martin@ximian.com>
20868 Reworked flow analyis and made it more precise and bug-free. The
20869 most important change is that we're now using a special `Reachability'
20870 class instead of having "magic" meanings of `FlowReturns'. I'll
20871 do some more cleanups and optimizations and also add some more
20872 documentation this week.
20874 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20875 largely reworked this class.
20876 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20877 the new `Reachability' class instead of having "magic" values here.
20878 (FlowBranching): We're now using an instance of `Reachability'
20879 instead of having separate `Returns', `Breaks' etc. fields.
20881 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20882 based on flow analysis; ignore the return value of block.Emit ().
20884 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20886 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20887 if they are private.
20889 2003-12-09 Martin Baulig <martin@ximian.com>
20891 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20892 call them directly on the UsageVector.
20894 2003-12-09 Martin Baulig <martin@ximian.com>
20896 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20897 Changed return type from `FlowReturns' to `Reachability'.
20899 2003-12-09 Martin Baulig <martin@ximian.com>
20901 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20902 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20903 `Reachable' fields with a single `Reachability' one.
20905 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20907 * class.cs (FindMembers): Remove foreach's.
20912 Run 1: 8.74 seconds
20913 Run 2: 8.71 seconds
20916 Run 1: 8.64 seconds
20917 Run 2: 8.58 seconds
20920 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20925 This patch does a few things:
20926 1. EmptyStatement is now a singleton, so it is never reallocated.
20927 2. All blah is EmptyStatement constructs have been changed to
20928 blah == EmptyStatement.Value, which is much faster and valid
20929 now that EmptyStatement is a singleton.
20930 3. When resolving a block, rather than allocating a new array for
20931 the non-empty statements, empty statements are replaced with
20932 EmptyStatement.Value
20933 4. Some recursive functions have been made non-recursive.
20934 Mainly the performance impact is from (3), however (1) and (2) are needed for
20935 this to work. (4) does not make a big difference in normal situations, however
20936 it makes the profile look saner.
20941 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20942 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20943 Total memory allocated: 56397 KB
20946 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20947 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20948 Total memory allocated: 55666 KB
20950 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20952 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20953 than the hashtable in a hashtable version
20955 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20956 we always end up concating a string. This results in a huge perf
20957 loss, because many strings have to be tracked by the GC. In this
20958 patch, we first use a hashtable that works with two keys, so that
20959 the strings do not need to be concat'ed.
20963 Run 1: 8.74 seconds
20964 Run 2: 8.71 seconds
20967 Run 1: 8.65 seconds
20968 Run 2: 8.56 seconds
20970 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20972 * Makefile: Add a new target `do-time' that does a quick and simple
20973 profile, leaving easy to parse output.
20975 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20977 * codegen.cs (Init): Create the dynamic assembly with
20978 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20980 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20982 * support.cs: Make the PtrHashtable use only one
20983 instance of its comparer.
20985 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20987 * typemanager.cs: Fix lookup of GetNamespaces.
20989 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20991 * expression.cs: Removed redundant line.
20993 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20994 ArrayLists, use for loops with bounds.
20996 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20999 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
21000 arraylists, use for loop with bounds.
21002 The above three changes give us a 0.071 second performance
21003 improvement out of 3.294 seconds down to 3.223. On my machine
21004 the above changes reduced the memory usage by 1,387 KB during
21005 compiler bootstrap.
21007 * cs-parser.jay (QualifiedIdentifier): New class used to represent
21008 QualifiedIdentifiers. Before we created a new string through
21009 concatenation, and mostly later on, the result would be
21010 manipulated by DecomposeQI through string manipulation.
21012 This reduced the compiler memory usage for bootstrapping from
21013 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
21014 compile times in 0.05 seconds.
21016 2003-11-28 Dick Porter <dick@ximian.com>
21018 * support.cs: Do string compares with the Invariant culture.
21026 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
21027 the comparison is done with the Invariant culture.
21029 2003-11-27 Miguel de Icaza <miguel@ximian.com>
21031 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
21032 GetEnumerator method.
21034 (ProbeCollectionType): Iterate starting at the most specific type
21035 upwards looking for a GetEnumerator
21037 * expression.cs: Shift count can be up to 31 for int/uint and 63
21040 2003-11-26 Miguel de Icaza <miguel@ximian.com>
21042 * statement.cs (Block.LookupLabel): Also look for the label on the
21043 children blocks. Use a hash table to keep track of visited
21046 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
21047 we actually did transform the other operand, otherwise fall back
21048 to the common codepath that casts to long.
21050 * cs-tokenizer.cs: Use the same code pattern as the int case.
21051 Maybe I should do the parsing myself, and avoid depending on the
21052 Parse routines to get this done.
21054 2003-11-25 Miguel de Icaza <miguel@ximian.com>
21056 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21057 which fixes bug 51347. This time test it.
21059 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
21060 attributes for example can not tell the difference between these.
21061 The difference was only a syntax feature of the language.
21063 * attribute.cs: Apply attributes to delegates.
21065 * delegate.cs: Call the apply attributes method.
21067 2003-11-24 Miguel de Icaza <miguel@ximian.com>
21069 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
21070 comparing 0 vs Byte.MinValue, not the value
21072 (ImplicitConversionRequired): When reporting a conversion error,
21073 use error 31 to print out the constant error instead of the
21076 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21077 which fixes bug 51347.
21079 2003-11-22 Miguel de Icaza <miguel@ximian.com>
21081 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
21082 which fixes the -warnaserror command line option.
21084 2003-11-21 Miguel de Icaza <miguel@ximian.com>
21086 * cfold.cs (DoNumericPromotions): During constant folding of
21087 additions on UIntConstant, special case intconstants with
21088 IntConstants like we do on the expression binary operator.
21090 2003-11-12 Miguel de Icaza <miguel@ximian.com>
21092 * convert.cs (ImplicitReferenceConversion): We were missing a case
21093 (System.Enum are not value types or class types, so we need to
21094 classify them separatedly).
21096 * driver.cs: We do not support error 2007.
21098 2003-11-12 Jackson Harper <jackson@ximian.com>
21100 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
21101 system directory. Also use the full file name so users can
21102 libraries names mscorlib-o-tron.dll in a non system dir.
21104 2003-11-10 Martin Baulig <martin@ximian.com>
21106 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
21107 (TypeManager.InitCoreTypes): Initialize them here, but instead of
21108 calling `ResolveType()' on them, directly assign their `Type'.
21110 2003-11-08 Martin Baulig <martin@ximian.com>
21112 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
21113 return value and the `out parent' parameter.
21114 (TypeContainer.DefineType): Moved the CS0644 check into
21115 GetClassBases(). Don't pass the interface types to the
21116 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
21117 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
21119 * ecore.cs (TypeExpr.IsAttribute): New property.
21120 (TypeExpr.GetInterfaces): New method.
21122 * interface.cs (Interface.GetInterfaceTypeByName): Return a
21123 TypeExpr instead of a Type.
21124 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
21125 (Interface.DefineType): Don't pass the interface types to the
21126 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
21127 them later and then call `TypeBulider.AddInterfaceImplementation()'.
21129 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
21130 instead of a `Type[]'.
21131 (TypeManager.RegisterBuilder): Likewise.
21132 (TypeManager.AddUserInterface): Likewise.
21133 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
21134 `Type[]' and also return a `TypeExpr[]'.
21135 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
21137 2003-11-08 Martin Baulig <martin@ximian.com>
21139 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
21142 2003-11-08 Martin Baulig <martin@ximian.com>
21144 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
21145 TypeManager.ResolveExpressionTypes().
21147 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
21148 instead of an Expression.
21149 (TypeExpr): This is now an abstract base class for `TypeExpression'.
21150 (TypeExpression): New public class; formerly known as `TypeExpr'.
21152 * expression.cs (ComposedCast): Derive from TypeExpr.
21154 * typemanager.cs (TypeManager.system_*_expr): These are now
21155 TypExpr's instead of Expression's.
21156 (TypeManager.ResolveExpressionTypes): New public static function;
21157 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
21160 2003-11-06 Miguel de Icaza <miguel@ximian.com>
21162 * expression.cs (New.DoResolve): Do not dereference value that
21163 might be a null return.
21165 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
21166 sure that the constant value has the right type. Fixes an
21167 unreported bug, similar to 50425.
21169 * const.cs (Const.LookupConstantValue): Call
21170 ImplicitStandardConversionExists before doing a conversion to
21171 avoid havng the TypeManager.ChangeType do conversions.
21173 Reduced the number of casts used
21175 (Const.ChangeType): New routine to enable reuse of the constant
21176 type changing code from statement.
21178 * typemanager.cs (ChangeType): Move common initialization to
21179 static global variables.
21183 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
21184 every value type to go through, even if it was void. Fix that.
21186 * cs-tokenizer.cs: Use is_identifier_start_character on the start
21187 character of the define, and the is_identifier_part_character for
21188 the rest of the string.
21190 2003-11-05 Miguel de Icaza <miguel@ximian.com>
21192 * expression.cs (UnaryMutator.EmitCode): When I updated
21193 LocalVariableReference.DoResolve, I overdid it, and dropped an
21194 optimization done on local variable references.
21196 2003-11-04 Miguel de Icaza <miguel@ximian.com>
21198 * ecore.cs: Convert the return from Ldlen into an int.
21200 2003-10-20 Miguel de Icaza <miguel@ximian.com>
21202 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
21203 the accessibility, this is a special case for toplevel non-public
21204 classes (internal for instance).
21206 2003-10-20 Nick Drochak <ndrochak@gol.com>
21208 * ecore.cs: Fix typo and build. Needed another right paren.
21210 2003-10-19 Miguel de Icaza <miguel@ximian.com>
21212 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
21213 `internal' case regular and protected, but not allowing protected
21214 to be evaluated later. Bug 49840
21216 2003-10-15 Miguel de Icaza <miguel@ximian.com>
21218 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
21219 to kb.Nlast, and not the kb.nFirst to isolate the switch
21222 Extract the underlying type, so enumerations of long/ulong are
21223 treated like long/ulong.
21225 2003-10-14 Miguel de Icaza <miguel@ximian.com>
21227 * expression.cs (New): Overload the meaning of RequestedType to
21228 track the possible creation of the NewDelegate type, since
21229 DoResolve is invoked more than once for new constructors on field
21232 See bugs: #48800 and #37014
21234 * cs-parser.jay (declare_local_constants): Take an arraylist
21235 instead of a single constant.
21237 (local_constant_declaration): It should take a
21238 constant_declarators, not a constant_declarator. Fixes 49487
21240 * convert.cs: Fix error report.
21242 2003-10-13 Jackson Harper <jackson@ximian.com>
21244 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21247 2003-10-09 Martin Baulig <martin@ximian.com>
21249 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21251 (MethodCore.DoDefineParameters): Removed the TypeContainer
21252 argument; use the DeclSpace which was passed to the .ctor instead.
21253 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21254 TypeContainer; we only need a DeclSpace here.
21256 2003-10-09 Martin Baulig <martin@ximian.com>
21258 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21260 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21261 EmitContext's .ctor.
21263 2003-10-09 Martin Baulig <martin@ximian.com>
21265 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21266 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21267 AsAccessible(), moved them as well.
21269 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21271 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21273 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21275 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21277 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21278 generation for >=, as spotted by Paolo, bug 48679.
21279 Patch from David Waite.
21281 * cs-tokenizer.cs: Add handling for #pragma.
21283 * cs-parser.jay: Allow for both yield and yield return in the
21284 syntax. The anti-cobolization of C# fight will go on!
21286 * class.cs (TypeBuilder.DefineType): Catch error condition here
21287 (Parent.DefineType erroring out and returning null).
21289 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21290 coping with enumerations variables, we were mistakenly processing
21291 them as a regular value type instead of built-in types. Fixes the
21294 * typemanager.cs (IsBuiltinOrEnum): New method.
21296 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21298 * cs-parser.jay: Upgrade: yield now needs the return clause.
21300 2003-09-19 Martin Baulig <martin@ximian.com>
21302 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21303 `MemberCache parent' argument. Normally, an interface doesn't
21304 have a parent type except System.Object, but we use this in gmcs
21305 for generic type parameters.
21307 2003-09-18 Martin Baulig <martin@ximian.com>
21309 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21310 on `type.IsInterface'; don't check whether the type has a parent
21311 to determine whether it's an interface.
21313 2003-09-15 Martin Baulig <martin@ximian.com>
21315 * class.cs (TypeContainer.DefineType): Added an error flag to
21316 avoid reporting duplicate CS0146's ("class definition is
21319 * driver.cs (Driver.MainDriver): Abort if
21320 RootContext.ResolveTree() reported any errors.
21322 2003-09-07 Martin Baulig <martin@ximian.com>
21324 * report.cs (Error, Warning): Added overloaded versions which take
21325 a `params object[] args' and call String.Format().
21327 2003-09-07 Martin Baulig <martin@ximian.com>
21329 * decl.cs (DeclSpace..ctor): Don't call
21330 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21331 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21332 (DeclSpace.RecordDecl): New method.
21334 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21336 2003-09-02 Ravi Pratap <ravi@ximian.com>
21338 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21339 value attributes to be applied to ParameterBuilders.
21341 * class.cs (MethodCore.LabelParameters): Make static and more
21342 generic so that it can be used from other places - like interface
21343 methods, for instance.
21345 * interface.cs (Interface.Emit): Call LabelParameters before
21346 emitting attributes on the InterfaceMethod.
21348 2003-08-26 Martin Baulig <martin@ximian.com>
21350 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21351 resolving aliases; fixes #47927.
21353 2003-08-26 Martin Baulig <martin@ximian.com>
21355 * statement.cs (Using.DoResolve): This is internally emitting a
21356 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21357 do not always return. Fixes #47681.
21359 2003-08-26 Martin Baulig <martin@ximian.com>
21361 * decl.cs (MemberCore): Moved WarningNotHiding(),
21362 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21364 (AdditionResult): Make this nested in DeclSpace.
21365 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21366 argument; call NamespaceEntry.Define() unless we're nested in a
21369 * namespace.cs (Namespace.DefineName): New public function. This
21370 is called from DeclSpace's .ctor to add
21371 (Namespace.Lookup): Include DeclSpaces in the lookup.
21373 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21375 * const.cs (Const): Derive from MemberBase, not MemberCore.
21377 2003-08-25 Martin Baulig <martin@ximian.com>
21379 * convert.cs (Convert.ExplicitReferenceConversion): When
21380 converting from an interface type to a class, unbox if the target
21381 type is a struct type. Fixes #47822.
21383 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21385 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21388 2003-08-22 Martin Baulig <martin@ximian.com>
21390 * class.cs (TypeManager.DefineType): When defining a nested type,
21391 call DefineType() on our parent; fixes #47801.
21393 2003-08-22 Martin Baulig <martin@ximian.com>
21395 * class.cs (MethodData.Define): While checking if a method is an
21396 interface implementation, improve the test a bit more to fix #47654.
21398 2003-08-22 Martin Baulig <martin@ximian.com>
21400 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21401 correctly; fixes #47722.
21403 2003-08-22 Martin Baulig <martin@ximian.com>
21405 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21406 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21408 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21410 2003-08-22 Martin Baulig <martin@ximian.com>
21412 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21413 can only be assigned in static constructors. Fixes #47161.
21415 2003-08-22 Martin Baulig <martin@ximian.com>
21417 Rewrote and improved the flow analysis code.
21419 * flowbranching.cs (FlowBranching): Make this class abstract.
21420 (FlowBranching.CreateBranching): New static function to create a
21421 new flow branching.
21422 (FlowBranchingBlock, FlowBranchingException): New classes.
21423 (FlowBranching.UsageVector.Type): New public readonly field.
21424 (FlowBranching.UsageVector.Breaks): Removed the setter.
21425 (FlowBranching.UsageVector.Returns): Removed the setter.
21426 (FlowBranching.UsageVector): Added Break(), Return(),
21427 NeverReachable() and Throw() methods to modify the reachability.
21428 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21429 done by FlowBranching.Merge().
21430 (FlowBranching.UsageVector.MergeChild): New method; merges the
21431 merge result into the current vector.
21432 (FlowBranching.Merge): New abstract method to merge a branching.
21434 2003-08-12 Martin Baulig <martin@ximian.com>
21436 * expression.cs (Indirection.CacheTemporaries): Create the
21437 LocalTemporary with the pointer type, not its element type.
21439 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21441 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21442 token was a keyword or not.
21444 Add `error' options where an IDENTIFIER was expected; Provide
21445 CheckToken and CheckIdentifierToken convenience error reporting
21448 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21450 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21451 NameSpaceEntry NameSpaceEntry.
21453 (LookupInterfaceOrClass): Avoid creating a full qualified name
21454 from namespace and name: avoid doing lookups when we know the
21455 namespace is non-existant. Use new Tree.LookupByNamespace which
21456 looks up DeclSpaces based on their namespace, name pair.
21458 * driver.cs: Provide a new `parser verbose' to display the
21459 exception thrown during parsing. This is turned off by default
21460 now, so the output of a failure from mcs is more graceful.
21462 * namespace.cs: Track all the namespaces defined in a hashtable
21465 (IsNamespace): New method
21467 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21469 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21470 we know that we need to concatenate (full typename can never be
21475 * statement.cs: Use a bitfield; Do not initialize to null things
21476 which are done by the constructor by default.
21478 * cs-parser.jay: bug fix, parameter was 4, not 3.
21480 * expression.cs: Just use the property;
21482 * statement.cs: No need for GetVariableInfo method.
21484 2003-08-08 Martin Baulig <martin@ximian.com>
21486 * flowanalysis.cs (FlowReturns): This is now nested in the
21487 `FlowBranching' class.
21488 (MyBitVector): Moved this here from statement.cs.
21489 (FlowBranching.SiblingType): New enum type.
21490 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21492 2003-08-07 Martin Baulig <martin@ximian.com>
21494 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21495 `FlowBranching' class and called `BranchingType'.
21497 2003-08-07 Martin Baulig <martin@ximian.com>
21499 * flowanalysis.cs: Moved all the control flow analysis code into
21502 2003-08-07 Martin Baulig <martin@ximian.com>
21504 * assign.cs (Assign.DoResolve): `target' must either be an
21505 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21508 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21510 * expression.cs (BinaryMethod): This kind of expression is created by the
21511 Binary class if it determines that the operator has to be handled
21514 (BinaryDelegate): This kind of expression is created if we are
21515 dealing with a + or - operator on delegates.
21517 (Binary): remove method, argumetns, and DelegateOperator: when
21518 dealing with methods,
21520 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21522 * statement.cs (Block): use bitfields for the three extra booleans
21523 we had in use. Remove unused topblock parameter.
21525 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21527 * assign.cs: Drop extra unneeded tests.
21529 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21531 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21533 * statement.cs (Foreach): Use VariableStorage instead of
21536 * codegen.cs (VariableStorage): New class used by clients that
21537 require a variable stored: locals or fields for variables that
21538 need to live across yield.
21540 Maybe provide a convenience api for EmitThis+EmitLoad?
21542 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21545 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21547 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21548 RemapParameterLValue): New methods that are used to turn a
21549 precomputed FieldInfo into an expression like this:
21553 The idea is to use this instead of making LocalVariableReference
21554 have more than one meaning.
21556 * cs-parser.jay: Add error production to BASE.
21558 * ecore.cs: Deal with TypeManager.GetField returning null, which
21559 is now a valid return value.
21561 (FieldExprNoAddress): New expression for Fields whose address can
21564 * expression.cs (LocalVariableReference): During the resolve
21565 phases, create new expressions if we are in a remapping context.
21566 Remove code that dealt with remapping here.
21568 (ParameterReference): same.
21570 (ProxyInstance): New expression, like the `This' expression, but
21571 it is born fully resolved. We know what we are doing, so remove
21572 the errors that are targeted to user-provided uses of `this'.
21574 * statement.cs (Foreach): our variable is now stored as an
21575 Expression; During resolution, follow the protocol, dont just
21576 assume it will return this.
21578 2003-08-06 Martin Baulig <martin@ximian.com>
21580 * support.cs (SeekableStreamReader.cs): New public class.
21582 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21583 SeekableStreamReader instead of the normal StreamReader.
21585 2003-08-04 Martin Baulig <martin@ximian.com>
21587 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21588 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21589 deambiguate casts and delegate invocations.
21590 (parenthesized_expression): Use the new tokens to ensure this is
21591 not a cast of method invocation.
21593 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21594 when reading a `)' and Deambiguate_CloseParens () was previously
21597 * expression.cs (ParenthesizedExpression): New class. This is
21598 just used for the CS0075 test.
21599 (Binary.DoResolve): Check for CS0075.
21601 2003-07-29 Ravi Pratap <ravi@ximian.com>
21603 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21604 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21605 reference comparison.
21607 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21608 examine the ReturnType for equality - this is necessary in the
21609 cases of implicit and explicit operators whose signature also
21610 includes the return type.
21612 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21614 * namespace.cs: Cache the result of the namespace computation,
21615 instead of computing it every time.
21617 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21619 * decl.cs: Use a global arraylist that we reuse over invocations
21620 to avoid excesive memory consumption. Reduces memory usage on an
21621 mcs compile by one meg (45 average).
21623 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21624 private, work around that.
21626 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21628 * literal.cs (IntLiteral): Define Zero and One static literals.
21630 * cs-parser.jay (integer_literal): use static literals to reduce
21631 memory usage for the most used literals (0, 1 and -1). 211kb
21632 reduced in memory usage.
21634 Replace all calls to `new ArrayList' with `new
21635 ArrayList(4)' which is a good average number for most allocations,
21636 and also requires only 16 bytes of memory for its buffer by
21639 This reduced MCS memory usage in seven megabytes for the RSS after
21642 2003-07-28 Ravi Pratap <ravi@ximian.com>
21644 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21645 handle params methods the correct way by forming only one
21646 applicable set with params and normal methods in them. Earlier we
21647 were looking at params methods only if we found no normal methods
21648 which was not the correct thing to do.
21650 (Invocation.BetterFunction): Take separate arguments indicating
21651 when candidate and the best method are params methods in their
21654 This fixes bugs #43367 and #46199.
21656 * attribute.cs: Documentation updates.
21658 (CheckAttribute): Rename to CheckAttributeTarget.
21659 (GetValidPlaces): Rename to GetValidTargets.
21661 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21662 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21666 2003-07-28 Martin Baulig <martin@ximian.com>
21668 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21669 name when looking up the base class of a nested class. Fixes #46977.
21671 2003-07-26 Martin Baulig <martin@ximian.com>
21673 * expression.cs (Indexers.Indexer): New nested struct; contains
21674 getter, setter and the indexer's type.
21675 (Indexers.Properties): This is now an ArrayList of
21676 Indexers.Indexer's.
21677 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21678 indexer doesn't have any getters.
21680 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21681 for embedded property and indexer assignments.
21683 2003-07-26 Martin Baulig <martin@ximian.com>
21685 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21686 preprocessor directive is not the first non-whitespace character
21689 2003-07-26 Martin Baulig <martin@ximian.com>
21691 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21692 namespace parsing, follow the spec more closely.
21694 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21695 NamespaceEntry.Lookup().
21697 2003-07-25 Martin Baulig <martin@ximian.com>
21699 * MethodCore.cs (OverridesSomething): New public field; it's set
21700 from TypeContainer.DefineMembers if this method overrides
21701 something (which doesn't need to be a method). Fix #39462.
21703 2003-07-25 Ravi Pratap <ravi@ximian.com>
21705 * typemanager.cs (GetMembers): Ensure that the list of members is
21706 reversed. This keeps things in sync.
21708 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21709 find an AttributeUsage attribute.
21711 * expression.cs (Invocation.OverloadResolve): Perform the check
21712 which disallows Invoke to be directly called on a Delegate.
21714 (Error_InvokeOnDelegate): Report error cs1533.
21716 2003-07-25 Martin Baulig <martin@ximian.com>
21718 * expression.cs (Indexers.GetIndexersForType): Only look in the
21719 interface hierarchy if the requested type is already an
21720 interface. Fixes #46788 while keeping #46502 fixed.
21722 2003-07-25 Martin Baulig <martin@ximian.com>
21724 * class.cs (TypeContainer.DefineMembers): Check whether all
21725 readonly fields have been assigned and report warning CS0649 if
21728 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21731 2003-07-24 Ravi Pratap <ravi@ximian.com>
21733 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21734 returned from GetMethods to make things consistent with the
21735 assumptions MCS makes about ordering of methods.
21737 This should comprehensively fix bug #45127 and it does :-)
21739 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21740 ordering is actually reverse.
21742 * Clean up some debug messages I left lying around.
21744 * interface.cs (Populate*): Get rid of code which emits attributes
21745 since the stage in which we emit attributes is the 'Emit' stage,
21746 not the define stage.
21748 (Emit): Move attribute emission for interface members here.
21750 2003-07-22 Ravi Pratap <ravi@ximian.com>
21752 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21753 closely: we eliminate methods in base types when we have an
21754 applicable method in a top-level type.
21756 Please see section 14.5.5.1 for an exact description of what goes
21759 This fixes bug #45127 and a host of other related to corlib compilation.
21761 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21762 array is the method corresponding to the top-level type (this is
21763 because of the changes made to icall.c) so we change this
21766 (MethodGroupExpr.Name): This too.
21768 * typemanager.cs (GetElementType): New method which does the right
21769 thing when compiling corlib.
21771 * everywhere: Make use of the above in the relevant places.
21773 2003-07-22 Martin Baulig <martin@ximian.com>
21775 * cs-parser.jay (invocation_expression): Moved
21776 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21777 `cast_expression', but create a InvocationOrCast which later
21778 resolves to either an Invocation or a Cast.
21780 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21781 method; call this before EmitStatement() to make sure that this
21782 expression can be used as a statement.
21784 * expression.cs (InvocationOrCast): New class; resolves to either
21785 an Invocation or a Cast.
21787 * statement.cs (StatementExpression): Call ResolveStatement() on
21788 the ExpressionStatement before emitting it.
21790 2003-07-21 Martin Baulig <martin@ximian.com>
21792 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21793 `ref' and `out' attributes match; fixes #46220.
21794 (MemberAccess.ResolveMemberAccess): You can't reference a type
21795 through an expression; fixes #33180.
21796 (Indexers.GetIndexersForType): Don't return the indexers from
21797 interfaces the class implements; fixes #46502.
21799 2003-07-21 Martin Baulig <martin@ximian.com>
21801 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21802 CS0661 checks; fixes bug #30442.
21804 2003-07-21 Martin Baulig <martin@ximian.com>
21806 * decl.cs (AdditionResult): Added `Error'.
21808 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21810 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21811 makes cs0031.cs actually work.
21813 2003-07-20 Martin Baulig <martin@ximian.com>
21815 * namespace.cs: Fixed that bug which caused a crash when compiling
21816 the debugger's GUI.
21818 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21820 * typemanager.cs (LookupTypeReflection): Never expose types which
21821 are NotPublic, NestedPrivate, NestedAssembly, or
21822 NestedFamANDAssem. We used to return these, and later do a check
21823 that would report a meaningful error, but the problem is that we
21824 would not get the real match, if there was a name override.
21826 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21828 * namespace.cs (Namespace, Name): Do not compute the namespace
21829 name dynamically, compute it in the constructor. This reduced
21830 memory usage by 1697 KB.
21832 * driver.cs: Use --pause to pause at the end.
21834 2003-07-17 Peter Williams <peter@newton.cx>
21836 * Makefile: Change the name of the test target so that it doesn't
21837 conflict with the recursive test target.
21839 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21841 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21842 AddressOf): Do not use EmitThis, that was wrong, use the actual
21845 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21847 * class.cs (MethodData.Define): While checking if a method is an
21848 interface implementation, improve the test: If we are not public
21849 (use new test here: use the computed MethodAttributes directly,
21850 instead of the parsed modifier flags) check if the `implementing'
21851 method comes from an interface or not.
21853 * pending.cs (VerifyPendingMethods): Slightly better error
21856 * makefile: add test target that does the mcs bootstrap.
21858 2003-07-16 Ravi Pratap <ravi@ximian.com>
21860 * interface.cs (Define): Do nothing here since there are no
21861 members to populate etc. Move the attribute emission out of here
21862 since this was just totally the wrong place to put it. Attribute
21863 application happens during the 'Emit' phase, not in the 'Define'
21866 (Emit): Add this method and move the attribute emission here
21868 * rootcontext.cs (EmitCode): Call the Emit method on interface
21871 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21873 * expression.cs (OverloadResolve): Report error only if Location
21874 is not 'Null' which means that there was a probe going on.
21876 2003-07-14 Martin Baulig <martin@ximian.com>
21878 * expression.cs (ConditionalLogicalOperator): New public class to
21879 implement user defined conditional logical operators.
21880 This is section 14.11.2 in the spec and bug #40505.
21882 2003-07-14 Martin Baulig <martin@ximian.com>
21884 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21886 2003-07-14 Martin Baulig <martin@ximian.com>
21888 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21890 * ecore.cs (IVariable.VerifyFixed): New interface method.
21892 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21893 operator, check whether the variable is actually fixed. Fixes bug
21894 #36055. Set a variable definitely assigned when taking its
21895 address as required by the spec.
21897 * statement.cs (LocalInfo.IsFixed): New field.
21898 (LocalInfo.MakePinned): Set `IsFixed' to true.
21900 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21902 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21903 for .ctors, ensure that we only ask for members declared in the
21904 attribute type (BindingFlags.DeclaredOnly).
21908 * expression.cs (Error_WrongNumArguments): Report error 1501
21909 correctly the way CSC does.
21911 2003-07-13 Martin Baulig <martin@ximian.com>
21913 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21914 lookup on the fully qualified name, to make things like "X.X" work
21915 where "X.X" is a fully qualified type name, but we also have a
21916 namespace "X" in the using list. Fixes #41975.
21918 2003-07-13 Martin Baulig <martin@ximian.com>
21920 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21921 function. If we're a CompoundAssign, we need to create an embedded
21922 CompoundAssign, not an embedded Assign.
21923 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21926 2003-07-13 Martin Baulig <martin@ximian.com>
21928 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21929 work to fix bug #46088.
21931 2003-07-13 Ravi Pratap <ravi@ximian.com>
21933 * class.cs (Operator.Emit): Do not emit attributes here - it is
21934 taken care of by the Method class that we delegate too. This takes
21935 care of bug #45876.
21937 2003-07-10 Martin Baulig <martin@ximian.com>
21939 * expression.cs (TypeOfVoid): New class.
21940 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21942 2003-07-10 Martin Baulig <martin@ximian.com>
21944 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21947 2003-07-10 Martin Baulig <martin@ximian.com>
21949 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21950 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21952 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21954 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21956 2003-07-10 Martin Baulig <martin@ximian.com>
21958 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21959 of decimal. Fixes #42850.
21961 NOTE: I also fixed the created byte blob, but this doesn't work on
21962 the MS runtime and csc never produces any byte blobs for decimal
21965 2003-07-10 Martin Baulig <martin@ximian.com>
21967 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21968 structs; fixes #32068.
21969 (Block.AddChildVariableNames): Fixed #44302.
21971 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21973 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21975 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21977 * attribute.cs: And this test is onger needed.
21979 2003-07-08 Martin Baulig <martin@ximian.com>
21981 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21982 inaccessible types. Fixes #36313.
21984 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21986 * namespace.cs (NamespaceEntry): Create implicit entries for all
21987 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21988 implicit entries for N1.N2 and N1.
21990 2003-07-08 Martin Baulig <martin@ximian.com>
21992 Rewrote the handling of namespaces to fix a lot of the issues
21993 wrt. `using' aliases etc.
21995 * namespace.cs (Namespace): Splitted this class into a
21996 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21998 * typemanager.cs (TypeManager.IsNamespace): Removed.
21999 (TypeManager.ComputeNamespaces): Only compute namespaces from
22000 loaded assemblies here, not the namespaces from the assembly we're
22001 currently compiling.
22003 2003-07-08 Martin Baulig <martin@ximian.com>
22005 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
22007 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22009 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
22012 I thought about the memory savings here, but LookupTypeReflection
22013 is used under already very constrained scenarios. Compiling
22014 corlib or mcs only exposes one hit, so it would not really reduce
22015 any memory consumption.
22017 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22019 * typemanager.cs: fixes bug #45889 by only adding public types from
22020 other assemblies to the list of known types.
22022 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22024 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
22025 on the type we resolved.
22027 2003-07-05 Martin Baulig <martin@ximian.com>
22029 * pending.cs (PendingImplementation.ParentImplements): Don't
22030 create the proxy if the parent is abstract.
22032 * class.cs (TypeContainer.DefineIndexers): Process explicit
22033 interface implementations first. Fixes #37714.
22035 2003-07-04 Miguel de Icaza <miguel@ximian.com>
22037 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
22038 defined recursively; but since we modify the input parameters
22039 (left is set to `this' temporarily), we reset this value if the
22040 left_is_explicit is false, which gives the original semantics to
22043 * literal.cs (NullPointer): new class used to represent a null
22044 literal in a pointer context.
22046 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
22047 type is a pointer, use a NullPointer object instead of a
22048 NullLiteral. Closes 43687
22050 (ExplicitConversion): Convert pointer values using
22051 the conv opcode to the proper type.
22053 * ecore.cs (New): change ValueTypeVariable property into a method,
22054 that returns whether the valuetype is suitable for being used.
22056 * expression.cs (Binary.DoNumericPromotions): Only return if we
22057 the int constant was a valid uint, and we can return both left and
22058 right as uints. If not, we continue processing, to trigger the
22059 type conversion. This fixes 39018.
22061 * statement.cs (Block.EmitMeta): During constant resolution, set
22062 the CurrentBlock property on the emitcontext, so that we resolve
22063 constants propertly.
22065 2003-07-02 Martin Baulig <martin@ximian.com>
22067 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
22068 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
22070 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
22071 than emitting it here.
22073 * statement.cs: Fixed some more flow analysis bugs.
22075 2003-07-02 Martin Baulig <martin@ximian.com>
22077 * class.cs (MethodData.Define): When implementing interface
22078 methods, set Final unless we're Virtual.
22080 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
22081 check work for interface methods.
22083 2003-07-01 Martin Baulig <martin@ximian.com>
22085 * ecore.cs (EmitContext.This): Replaced this property with a
22086 GetThis() method which takes a Location argument. This ensures
22087 that we get the correct error location for a CS0188.
22089 2003-07-01 Miguel de Icaza <miguel@ximian.com>
22091 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
22092 ImplicitStandardConversion.
22094 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
22096 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
22098 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
22101 2003-06-30 Miguel de Icaza <miguel@ximian.com>
22103 * class.cs (Constructor.Define): Turn off initlocals for unsafe
22106 (MethodData.Define): Turn off initlocals for unsafe methods.
22108 2003-06-29 Miguel de Icaza <miguel@ximian.com>
22110 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
22111 complete; Fixes #37521.
22113 * delegate.cs: Use Modifiers.TypeAttr to compute the
22114 TypeAttributes, instead of rolling our own. This makes the flags
22115 correct for the delegates.
22117 2003-06-28 Miguel de Icaza <miguel@ximian.com>
22119 * class.cs (Constructor.Define): Set the private flag for static
22120 constructors as well.
22122 * cs-parser.jay (statement_expression): Set the return value to
22123 null, to avoid a crash when we catch an error.
22125 2003-06-24 Miguel de Icaza <miguel@ximian.com>
22127 * cs-parser.jay: Applied patch from Jackson that adds support for
22128 extern and unsafe modifiers to destructor declarations.
22130 * expression.cs: Report error 21 if the user is trying to index a
22133 * driver.cs: Add an error message, suggested by the bug report.
22135 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
22136 if we do not have a ": this ()" constructor initializer. Fixes 45149
22138 2003-06-14 Miguel de Icaza <miguel@ximian.com>
22140 * namespace.cs: Add some information to reduce FAQs.
22142 2003-06-13 Miguel de Icaza <miguel@ximian.com>
22144 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
22145 underlying enumeration types. Fixes #43915.
22147 * expression.cs: Treat ushort/short as legal values to be used in
22148 bitwise operations.
22150 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
22152 * delegate.cs: transfer custom attributes for paramenters from
22153 the delegate declaration to Invoke and BeginInvoke.
22155 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
22157 * attribute.cs: handle custom marshalers and emit marshal info
22160 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
22162 * makefile.gnu: Added anonymous.cs to the compiler sources.
22164 2003-05-28 Miguel de Icaza <miguel@ximian.com>
22166 * iterators.cs: Change the name of the proxy class to include two
22169 * cs-parser.jay: Update grammar to include anonymous methods.
22171 * anonymous.cs: new file.
22173 2003-05-27 Miguel de Icaza <miguel@ximian.com>
22175 * class.cs (Field.Define): Add missing test for pointers and
22178 2003-05-27 Ravi Pratap <ravi@ximian.com>
22180 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
22181 we use the stobj opcode.
22183 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
22184 since it wasn't the correct fix.
22186 It still is puzzling that we are required to use stobj for IntPtr
22187 which seems to be a ValueType.
22189 2003-05-26 Miguel de Icaza <miguel@ximian.com>
22191 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
22192 during regular simple name resolution. Now, the trick is that
22193 instead of returning for processing the simplename, we do a
22194 TypeManager.LookupType (ie, a rooted lookup as opposed to a
22195 contextual lookup type). If a match is found, return that, if
22196 not, return for further composition.
22198 This fixes long-standing 30485.
22200 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
22201 using the address to initialize an object, do an Stobj instead of
22202 using the regular Stelem.
22204 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
22205 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
22206 Because if we are a BaseIndexerAccess that value will be true.
22209 * statement.cs (GotoCase.Resolve): Return after reporting an
22210 error, do not attempt to continue.
22212 * expression.cs (PointerArithmetic.Emit): If our operand is a
22213 long, convert our constants to match the operand before
22214 multiplying. Convert to I type before adding. Fixes 43670.
22216 2003-05-14 Ravi Pratap <ravi@ximian.com>
22218 * enum.cs (ImplicitConversionExists) : Rename to
22219 ImplicitEnumConversionExists to remove ambiguity.
22221 * ecore.cs (NullCast): New type of cast expression class which
22222 basically is very similar to EmptyCast with the difference being
22223 it still is a constant since it is used only to cast a null to
22225 (eg. (string) null)
22227 * convert.cs (ImplicitReferenceConversion): When casting a null
22228 literal, we return a NullCast.
22230 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22231 should be around anymore.
22233 The renaming (reported was slightly wrong). Corrections:
22235 ConvertImplicitStandard -> ImplicitConversionStandard
22236 ConvertExplicitStandard -> ExplicitConversionStandard
22238 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22239 before passing them in !
22241 * convert.cs (ImplicitConversionStandard): When comparing for
22242 equal expr and target types, ensure that expr is not a
22245 In general, we must not be checking (expr_type ==
22246 target_type) in the top level conversion methods
22247 (ImplicitConversion, ExplicitConversion etc). This checking is
22248 done in the methods that they delegate to.
22250 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22252 * convert.cs: Move Error_CannotConvertType,
22253 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22254 ImplicitNumericConversion, ImplicitConversionExists,
22255 ImplicitUserConversionExists, StandardConversionExists,
22256 FindMostEncompassedType, FindMostSpecificSource,
22257 FindMostSpecificTarget, ImplicitUserConversion,
22258 ExplicitUserConversion, GetConversionOperators,
22259 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22260 TryImplicitIntConversion, Error_CannotConvertImplicit,
22261 ConvertImplicitRequired, ConvertNumericExplicit,
22262 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22263 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22266 Perform the following renames:
22268 StandardConversionExists -> ImplicitStandardConversionExists
22269 ConvertImplicit -> ImplicitConversion
22270 ConvertImplicitStandard -> ImplicitStandardConversion
22271 TryImplicitIntConversion -> ImplicitIntConversion
22272 ConvertImplicitRequired -> ImplicitConversionRequired
22273 ConvertNumericExplicit -> ExplicitNumericConversion
22274 ConvertReferenceExplicit -> ExplicitReferenceConversion
22275 ConvertExplicit -> ExplicitConversion
22276 ConvertExplicitStandard -> ExplicitStandardConversion
22278 2003-05-19 Martin Baulig <martin@ximian.com>
22280 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22281 (TypeInfo): Added support for structs having structs as fields.
22283 * ecore.cs (FieldExpr): Implement IVariable.
22284 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22285 VariableInfo for the field.
22287 2003-05-18 Martin Baulig <martin@ximian.com>
22289 * expression.cs (This.DoResolve): Report a CS0027 if we're
22290 emitting a field initializer.
22292 2003-05-18 Martin Baulig <martin@ximian.com>
22294 * expression.cs (This.ResolveBase): New public function.
22295 (This.DoResolve): Check for CS0188.
22297 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22300 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22301 `instance_expression' to null if we don't have any non-static
22304 2003-05-18 Martin Baulig <martin@ximian.com>
22306 Reworked the way how local variables and parameters are handled by
22307 the flow analysis code.
22309 * statement.cs (TypeInfo, VariableMap): New public classes.
22310 (VariableInfo): New public class. This is now responsible for
22311 checking whether a variable has been assigned. It is used for
22312 parameters and local variables.
22313 (Block.EmitMeta): Take the InternalParameters as argument; compute
22314 the layout of the flow vectors here.
22315 (Block.LocalMap, Block.ParameterMap): New public properties.
22316 (FlowBranching): The .ctor doesn't get the InternalParameters
22317 anymore since Block.EmitMeta() now computes the layout of the flow
22319 (MyStructInfo): This class is now known as `StructInfo' and nested
22320 in `TypeInfo'; we don't access this directly anymore.
22322 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22323 property and removed IsAssigned(), IsFieldAssigned(),
22324 SetAssigned() and SetFieldAssigned(); we now call them on the
22325 VariableInfo so we don't need to duplicate this code everywhere.
22327 * expression.cs (ParameterReference): Added `Block block' argument
22329 (LocalVariableReference, ParameterReference, This): The new
22330 VariableInfo class is now responsible for all the definite
22333 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22334 IsParameterAssigned, SetParameterAssigned): Removed.
22336 2003-05-18 Martin Baulig <martin@ximian.com>
22338 * typemanager.cs (InitCoreTypes): Try calling
22339 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22340 the 3-args-version. Corlib now also needs our `void_type'.
22341 (GetMethod): Added overloaded version which takes an optional
22342 `bool report_errors' to allow lookups of optional methods.
22344 2003-05-12 Martin Baulig <martin@ximian.com>
22346 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22347 only used for locals and not for parameters.
22349 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22351 * support.cs (InternalParameters.ParameterType): Return the
22352 ExternalType of the parameter.
22354 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22357 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22359 * class.cs (MethodData.Define): Do not set the `newslot' on
22360 interface members, if they are also flagged as "override".
22362 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22363 better code for ++i and i++. This only works for static fields
22364 and local variables.
22366 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22367 want to pull the DeclSpace out of the builder_to_declspace instead
22368 of the TypeBuilder (like in TypeContainer.FindMembers).
22370 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22371 instead of LookupTypeContainer. Fixes the crash on .NET for
22372 looking up interface members.
22374 * const.cs: Create our own emit context during the Definition
22375 stage, so that constants are evaluated in the proper context, when
22376 a recursive definition happens.
22378 2003-05-11 Martin Baulig <martin@ximian.com>
22380 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22381 new block for a switch section.
22382 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22383 the adding/lookup in the switch block. Fixes #39828.
22385 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22387 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22388 functionality: I needed to convert the data after I had performed
22389 the add/sub operation into the operands type size.
22391 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22392 pass the type for the box operation, otherwise the resulting
22393 object would have been of type object.
22395 (BoxedCast): Add constructor to specify the type to box as.
22397 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22399 * iterators.cs: I was reusing the `count' variable inadvertently,
22400 take steps to not allow this to happen.
22402 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22404 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22405 by creating an array at the point where the params starts and
22406 putting all those arguments there, then adjusting the size of the
22409 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22411 * expression.cs (New.AddressOf): Implement interface
22412 IMemoryLocation. This is used when the `new' operator is used in
22413 the context of an invocation to a method on a value type.
22415 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22418 * namespace.cs: Also check the using aliases here.
22420 * driver.cs: Move the test for using validity after the types have
22421 been entered, so we do a single pass that also includes the using
22424 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22425 in the regular case. CreateSiblingForFinally is doing extra
22428 * attribute.cs (GetAttributeArgumentExpression): Store the result
22429 on an out value, and use the return value to indicate failure
22430 instead of using null (which is a valid return for Constant.GetValue).
22432 * statement.cs: Perform the analysis flow for the increment
22433 portion after the statement, because this will be the real flow of
22434 execution. Fixes #42385
22436 * codegen.cs (EmitContext.EmitArgument,
22437 EmitContext.EmitStoreArgument): New helper functions when the
22438 RemapToProxy flag is set.
22440 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22443 Add support for remapping parameters.
22445 * iterators.cs: Propagate parameter values; Store parameter
22446 values in the proxy classes.
22448 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22450 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22451 need a proxy reference; I do not know what I was thinking
22453 * cs-parser.jay (constructor_initializer): catch another error,
22454 and display nice message.
22456 (field_declaration): catch void field declaration
22457 to flag a better error.
22459 * class.cs (MemberBase.CheckBase): Report an error instead of a
22460 warning if a new protected member is declared in a struct.
22461 (Field.Define): catch the error of readonly/volatile.
22463 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22465 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22466 volatile variable is taken
22468 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22470 * statement.cs (Fixed.Resolve): Report an error if we are not in
22473 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22475 * typemanager.cs: reuse the code that handles type clashes for
22476 delegates and enumerations.
22478 * class.cs (Report28): Always report.
22480 * expression.cs (EncodeAsAttribute): Allow nulls here.
22482 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22484 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22485 the functionality for testing whether an expression is valid for
22486 an attribute here. Also handle the case of arrays of elements
22489 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22490 encoding a linear array into an array of objects that are suitable
22491 to be passed to an CustomAttributeBuilder.
22493 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22495 * ecore.cs: (FieldExpr): Handle field remapping here.
22497 * iteratators.cs: Pass the instance variable (if the method is an
22498 instance method) to the constructors, so we can access the field
22499 variables on the class.
22501 TODO: Test this with structs. I think the THIS variable on
22502 structs might have to be a pointer, and not a refenrece
22504 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22506 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22507 local variables to fields in a proxy class.
22509 * iterators.cs (PopulateProxy): Rename our internal fields to
22511 Create a <THIS> field if we are an instance method, so we can
22512 reference our parent container variables.
22513 (MapVariable): Called back from the EmitContext code to enter a
22514 new variable to field mapping into the proxy class (we just create
22518 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22519 for using the remapped locals to fields.
22521 I placed the code here, because that gives the same semantics to
22522 local variables, and only changes the Emit code.
22524 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22525 statements inside iterators.
22526 (VariableInfo): Add a FieldBuilder for the cases when we are
22527 remapping local variables to fields in a proxy class
22529 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22530 current_block != null.
22532 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22533 not cope with strings, as it has been moved to the
22534 TableSwitchEmit. Fixed bug in switch generation.
22536 * expression.cs (New.DoResolve): Provide more context for the user
22537 when reporting an error.
22539 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22542 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22543 check the permissions for it. Note than in a type-resolution
22544 context the check was already present in DeclSpace.ResolveType,
22545 but was missing from the MemberAccess.
22547 (ArrayCreation.CheckIndices): warn if the user has
22548 more nested levels of expressions, but there are no more
22549 dimensions specified. Avoids crash on bug 41906.
22551 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22553 * statement.cs (Block): replace Implicit bool, for a generic
22555 New flag: `Unchecked'. This is used during the EmitMeta phase
22556 (which is out-of-line with the regular Resolve/Emit process for a
22557 statement, as this is done ahead of time, but still gets a chance
22558 to call constant resolve).
22560 (Block.Flags): new enum for adding a new flag.
22562 (Block.EmitMeta): track the state of unchecked.
22564 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22565 to enable constant resolution to work there as well.
22567 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22569 * typemanager.cs (ienumerable_type): Also look up
22570 System.Collections.IEnumerable.
22572 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22574 TODO: Test more than one conditional per method.
22576 * class.cs (Indexer.Define): Report the location where the user is
22577 referencing the unsupported feature.
22579 (MethodData): Overload the use of `conditionals' to
22580 minimize the creation of needless ArrayLists. This saves roughly
22581 212kb on my machine.
22583 (Method): Implement the new IIteratorContainer interface.
22584 (Method.SetYields): Implement the method by setting the ModFlags
22585 to contain METHOD_YIELDS.
22587 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22588 which just got set to null.
22590 * iterators.cs: New file.
22592 (Yield, YieldBreak): New statements.
22594 * statement.cs (Return.Resolve): Flag an error if we are used in
22595 an iterator method.
22597 * codegen.cs (InIterator): New flag set if the code is being
22598 compiled in an iterator method.
22600 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22601 internal modifier, and we just use it to avoid adding extra
22602 fields, as this is seldom used.
22604 * cs-parser.jay: Add yield_statement (yield and yield break).
22606 * driver.cs: New flag -v2 to turn on version 2 features.
22608 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22609 hashtable when v2 is enabled.
22611 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22613 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22614 there is already a namespace defined with this name.
22616 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22617 people upgraded their corlibs.
22619 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22620 always use fully qualified types, no need to use the compiler
22623 (TypeManager.IsNamespace): Use binarysearch.
22625 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22626 AddDelegate): I did not quite use the new IsValid API properly: I
22627 have to pass the short-name and the fullname. I was passing only
22628 the basename instead of the fullname sometimes.
22630 (TypeContainer.DefineType): call NamespaceClash.
22632 * interface.cs (Interface.DefineType): use NamespaceClash before
22635 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22638 * enum.cs: (Enum.DefineType): use NamespaceClash before
22641 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22642 speed increase. First, use the negative_hits cache when we get a
22643 negative. Second, add the type with its full original name
22644 instead of the new . and + encoded name (reflection uses + to
22645 separate type from a nested type). Use LookupTypeReflection
22646 directly which bypasses the type->name hashtable (that we already
22647 know does not contain the type.
22649 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22650 location/container type.
22652 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22654 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22656 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22658 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22659 method is being referenced in the method group from a static
22660 context, and report error 120 if so.
22662 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22665 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22666 is created, we create the A namespace).
22668 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22671 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22673 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22674 invocation to ModuleBuilder.GetType with the same values will
22675 return a new type instance, so we need to cache its return
22678 * expression.cs (Binary.ResolveOperator): Only allow the compare
22679 operators on enums if they are of the same type.
22681 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22682 types of ValueType on their own case. Before we were giving them
22683 the same treatment as objects.
22685 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22686 fullname. Short name is used to compare against container name.
22687 Fullname is used to check against defined namespace names.
22689 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22690 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22692 (Method.CheckBase): Call parent.
22693 (MemberBase.CheckBase): Check for protected members on sealed
22695 (PropertyBase.CheckBase): Call parent.
22696 (Field.Define): Call parent.
22698 * report.cs: Negative error codes are now mapped to 8000 - code,
22699 so that the display is render more nicely.
22701 * typemanager.cs: Do not use try/catch, instead report a regular
22704 (GetPointerType, GetReferenceType): These methods provide
22705 mechanisms to obtain the T* and T& from a T. We had the code
22706 previously scattered around the code base, and it also used
22707 TypeManager.LookupType that would go through plenty of caches.
22708 This one goes directly to the type source.
22710 In some places we did the Type.GetType followed by
22711 ModuleBuilder.GetType, but not in others, so this unifies the
22712 processing as well.
22714 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22715 statements now that we have namespace information.
22717 * typemanager.cs (IsNamespace): New method, returns whether the
22718 string presented is a namespace or not.
22720 (ComputeNamespaces): New public entry point, computes the list of
22721 available namespaces, using the GetNamespaces API call in Mono, or
22722 the slower version in MS.NET.
22724 Now before we start the semantic analysis phase, we have a
22725 complete list of namespaces including everything that the user has
22728 Deleted old code to cache namespaces in .nsc files.
22730 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22732 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22733 class/struct location definition Location for the implicit
22734 constructor location.
22736 (Operator.Define): Use the location of the operator for the
22737 implicit Method definition.
22739 (Constructor.Emit): use the constructor location for the implicit
22740 base initializer constructor.
22742 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22743 and the Expression class now contains two new methods:
22745 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22746 isolate type lookup from the rest of the resolution process.
22748 Since we use Expressions to hold type definitions due to the way
22749 we parse the input we have historically overloaded Resolve to
22750 perform the Type lookups if a special flag is passed. Now this is
22751 eliminated and two methods take their place.
22753 The differences in the two methods between xStep and xTerminal is
22754 that xStep is involved in our current lookup system that uses
22755 SimpleNames to compose a name, while xTerminal is used just to
22756 catch the case where the simplename lookup failed.
22758 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22760 * expression.cs (ResolveMemberAccess): Remove redundant code.
22761 TypeExpr expressions are always born fully resolved.
22763 * interface.cs (PopulateMethod): Do not lookup the types twice.
22764 We were doing it once during SemanticAnalysis and once during
22767 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22768 in local variable type definitions, were being returned as a
22769 SimpleName (we decomposed everything into a string), that is
22770 because primary_expression was being used instead of a type in the
22771 grammar (reduce/reduce conflicts).
22773 The part that was wrong is that we converted the expression into a
22774 string (an oversimplification in one hand, compounded with primary
22775 expressions doing string concatenation).
22781 Would return "A.B.C[]" as a SimpleName. This stopped things like
22782 using clauses from working on this particular context. And a type
22783 was being matched directly against "A.B.C[]".
22785 We now use the correct approach, and allow for ComposedCast to be
22786 part of the unary expression. So the "A.B.C []" become a composed
22787 cast of "A.B.C" (as a nested group of MemberAccess with a
22788 SimpleName at the end) plus the rank composition "[]".
22792 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22794 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22795 for the access level checking.
22797 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22798 `TypeContainer container', because I kept getting confused when I
22799 was debugging this code.
22801 * expression.cs (Indexers): Instead of tracking getters/setters,
22802 we now track them in parallel. We create one arraylist less, but
22803 most importantly it is possible now for the LValue code to find a
22804 matching get for a set.
22806 (IndexerAccess.DoResolveLValue): Update the code.
22807 GetIndexersForType has been modified already to extract all the
22808 indexers from a type. The code assumed it did not.
22810 Also make the code set the correct return type for the indexer.
22811 This was fixed a long time ago for properties, but was missing for
22812 indexers. It used to be void_type.
22814 (Binary.Emit): Test first for doubles instead of
22815 floats, as they are more common.
22817 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22818 when dealing with floats and the <=, >= operators. This fixes bug
22821 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22822 to load the array value by emitting a load on the foreach variable
22823 type. This was incorrect.
22825 We now emit the code to load an element using the the array
22826 variable type, and then we emit the conversion operator.
22830 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22832 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22834 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22836 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22837 test for protection before we test for signatures.
22839 (MethodSignature.ToString): implement.
22841 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22842 to the case where we reduced into a LongConstant.
22844 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22845 depend on whether the information is acurrate, because the
22846 Microsoft runtime will always claim that the array type is public,
22847 regardless of the real state.
22849 If the type is a pointer, another problem happens: the type is
22850 reported as non-public in Microsoft.
22852 In both cases we have to call CheckAccessLevel recursively with
22853 the underlying type as the argument to be tested.
22855 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22857 * assign.cs (Assign.Emit): If we are dealing with a compound
22858 assignment expression, we should use the code path that stores the
22859 intermediate result in a temporary value. This fixes #40903.
22861 *expression.cs (Indirection.ToString): Provide ToString method for
22864 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22866 * class.cs: Null out fields holding references to Block objects so
22867 they can be garbage collected.
22869 * expression.cs (OverloadResolve): Remove unused local.
22871 2003-04-07 Martin Baulig <martin@ximian.com>
22873 * codegen.cs (EmitContext.CurrentFile): New public field.
22874 (EmitContext.Mark): Use the CurrentFile to check whether the
22875 location is in the correct file.
22876 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22878 2003-04-07 Martin Baulig <martin@ximian.com>
22880 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22882 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22883 location. [FIXME: The location argument which gets passed to this
22884 method is sometimes wrong!]
22886 2003-04-07 Nick Drochak <ndrochak@gol.com>
22888 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22890 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22892 * expression.cs (Indirection.EmitAssign): We were using the
22893 temporary, but returning immediately instead of continuing the
22896 2003-04-06 Martin Baulig <martin@ximian.com>
22898 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22899 if it's a nested child, but also deriving from the outer class.
22902 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22903 nested child, but also deriving from the outer class. See
22905 (FilterWithClosure): We may access private members of the outer
22906 class if we're a nested child and deriving from the outer class.
22907 (RealMemberLookup): Only set `closure_private_ok' if the
22908 `original_bf' contained BindingFlags.NonPublic.
22910 2003-04-05 Martin Baulig <martin@ximian.com>
22912 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22914 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22916 * class.cs (Event.Define): Do not allow abstract events to have
22919 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22921 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22922 block in event declarations.
22924 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22925 value type, get its address.
22927 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22928 leaving a class on the stack instead of a boolean value (int
22929 0/1). Change the code so we compare against null, and then the
22930 result against zero.
22932 * class.cs (TypeContainer.GetClassBases): We were checking for the
22933 parent class being sealed too late.
22935 * expression.cs (Binary.Emit): For <= and >= when dealing with
22936 floating point values, use cgt.un and clt.un instead of cgt and
22939 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22941 * statement.cs: Apply the same optimization as MS: skip the
22942 GetEnumerator returning an IEnumerator, and use the one returning a
22943 CharEnumerator instead. This allows us to avoid the try-finally block
22946 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22948 * cs-parser.jay: Attributes cannot be applied to
22949 namespaces. Fixes #40473
22951 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22954 (Add*): check if the name is valid using the full name for constants,
22955 fields, properties and events.
22957 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22959 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22960 char constants to be part of the enumeration.
22962 * expression.cs (Conditional.DoResolve): Add support for operator
22963 true. Implements the missing functionality from 14.12
22965 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22966 operator true/false as required by the spec.
22968 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22969 implicit conversion to boolean.
22971 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22972 also one where the type implements `operator true'.
22974 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22975 get an expression that will invoke operator true based on an
22978 (GetConversionOperators): Removed the hack that called op_True
22981 (Expression.ResolveBoolean): Move this from Statement.
22983 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22985 * ecore.cs (FieldExpr): do not allow initialization of initonly
22986 fields on derived classes
22988 2003-03-13 Martin Baulig <martin@ximian.com>
22990 * statement.cs (Block.Emit): Call ig.BeginScope() and
22991 ig.EndScope() when compiling with debugging info; call
22992 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22994 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22996 * expression.cs (Indexers): Do not construct immediately, allow
22997 for new members to be appended as we go. Fixes 38143
22999 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23001 * expression.cs: save/restore context when resolving an unchecked
23004 2003-03-05 Miguel de Icaza <miguel@ximian.com>
23006 * cfold.cs: Catch division by zero in modulus operator during
23009 2003-03-03 Miguel de Icaza <miguel@ximian.com>
23011 * interface.cs (Interface.DefineMembers): Avoid defining members
23014 2003-02-27 Miguel de Icaza <miguel@ximian.com>
23016 * driver.cs: handle the +/- options for -noconfig
23018 * statement.cs (Unckeched.Resolve): Also track the state of
23019 unchecked in the Resolve phase.
23021 2003-02-27 Martin Baulig <martin@ximian.com>
23023 * ecore.cs (Expression.MemberLookup): Don't create a
23024 MethodGroupExpr for something which is not a method. Fixes #38291.
23026 2003-02-25 Miguel de Icaza <miguel@ximian.com>
23028 * class.cs (MemberBase.CheckParameters): Also check that the type
23029 is unmanaged if it is a pointer.
23031 * expression.cs (SizeOf.Resolve): Add location information.
23033 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
23034 a managed type is declared.
23036 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
23037 parameter modifiers as well. Fixes bug 38606
23039 * class.cs: Very sad. Am backing out the speed up changes
23040 introduced by the ArrayList -> Array in the TypeContainer, as they
23041 were not actually that much faster, and introduced a bug (no error
23042 reports on duplicated methods).
23044 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
23045 source first, this will guarantee that we have a valid expression
23046 before calling in lower levels functions that will require a
23047 resolved object. Then use this original_source in the
23048 target.ResolveLValue instead of the original source that was
23051 Another change. Use target.Resolve instead of LValueResolve.
23052 Although we are resolving for LValues, we will let the Assign code
23053 take care of that (it will be called again from Resolve). This
23054 basically allows code like this:
23056 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
23057 class Y { void A (X x) { x [0] += o; }
23059 The problem was that the indexer was trying to resolve for
23060 set_Item (idx, object o) and never finding one. The real set_Item
23061 was set_Item (idx, X). By delaying the process we get the right
23066 2003-02-23 Martin Baulig <martin@ximian.com>
23068 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
23069 while calling DoEmit ().
23071 * codegen.cs (EmitContext.Mark): Don't mark locations in other
23072 source files; if you use the #line directive inside a method, the
23073 compiler stops emitting line numbers for the debugger until it
23074 reaches the end of the method or another #line directive which
23075 restores the original file.
23077 2003-02-23 Martin Baulig <martin@ximian.com>
23079 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
23081 2003-02-23 Martin Baulig <martin@ximian.com>
23083 * statement.cs (Block.AddChildVariableNames): We need to call this
23084 recursively, not just for our immediate children.
23086 2003-02-23 Martin Baulig <martin@ximian.com>
23088 * class.cs (Event.Define): Always make the field private, like csc does.
23090 * typemanager.cs (TypeManager.RealMemberLookup): Make events
23091 actually work, fixes bug #37521.
23093 2003-02-23 Miguel de Icaza <miguel@ximian.com>
23095 * delegate.cs: When creating the various temporary "Parameters"
23096 classes, make sure that we call the ComputeAndDefineParameterTypes
23097 on those new parameters (just like we do with the formal ones), to
23098 allow them to be resolved in the context of the DeclSpace.
23100 This fixes the bug that Dick observed in Bugzilla #38530.
23102 2003-02-22 Miguel de Icaza <miguel@ximian.com>
23104 * expression.cs (ResolveMemberAccess): When resolving a constant,
23105 do not attempt to pull a constant if the value was not able to
23106 generate a valid constant.
23108 * const.cs (LookupConstantValue): Do not report more errors than required.
23110 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23112 * expression.cs: fixes bug #38328.
23114 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23116 * class.cs: Changed all the various members that can be part of a
23117 class from being an ArrayList to be an Array of the right type.
23118 During the DefineType type_list, interface_list, delegate_list and
23119 enum_list are turned into types, interfaces, delegates and enums
23122 And during the member population, indexer_list, event_list,
23123 constant_list, field_list, instance_constructor_list, method_list,
23124 operator_list and property_list are turned into their real arrays.
23126 Although we could probably perform this operation earlier, for
23127 good error reporting we need to keep the lists and remove the
23128 lists for longer than required.
23130 This optimization was triggered by Paolo profiling the compiler
23131 speed on the output of `gen-sample-program.pl' perl script.
23133 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
23134 not crash in methods like MemberLookupFailed that use this field.
23136 This problem arises when the compiler fails to resolve a type
23137 during interface type definition for example.
23139 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23141 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
23142 inherit from System.Object, so we have to stop at null, not only
23143 when reaching System.Object.
23145 2003-02-17 Miguel de Icaza <miguel@ximian.com>
23147 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
23148 DeclaredOnly because the parent indexer might have had a different
23149 name, but did not loop until the top of the hierarchy was reached.
23151 The problem this one fixes is 35492: when a class implemented an
23152 indexer from an interface, we were getting the interface method
23153 (which was abstract) and we were flagging an error (can not invoke
23156 This also keeps bug 33089 functioning, and test-148 functioning.
23158 * typemanager.cs (IsSpecialMethod): The correct way of figuring
23159 out if a method is special is to see if it is declared in a
23160 property or event, or whether it is one of the predefined operator
23161 names. This should fix correctly #36804.
23163 2003-02-15 Miguel de Icaza <miguel@ximian.com>
23165 The goal here is to remove the dependency on EmptyCast.Peel ().
23166 Killing it completely.
23168 The problem is that currently in a number of places where
23169 constants are expected, we have to "probe" for an EmptyCast, and
23170 Peel, which is not the correct thing to do, as this will be
23171 repetitive and will likely lead to errors.
23173 The idea is to remove any EmptyCasts that are used in casts that
23174 can be reduced to constants, so we only have to cope with
23177 This bug hunt was triggered by Bug 37363 and the desire to remove
23178 the duplicate pattern where we were "peeling" emptycasts to check
23179 whether they were constants. Now constants will always be
23182 * ecore.cs: Use an enumconstant here instead of wrapping with
23185 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
23186 throwing me off. By handling this we can get rid of a few hacks.
23188 * statement.cs (Switch): Removed Peel() code.
23190 2003-02-14 Miguel de Icaza <miguel@ximian.com>
23192 * class.cs: Location information for error 508
23194 * expression.cs (New.DoResolve): Add a guard against double
23195 resolution of an expression.
23197 The New DoResolve might be called twice when initializing field
23198 expressions (see EmitFieldInitializers, the call to
23199 GetInitializerExpression will perform a resolve on the expression,
23200 and later the assign will trigger another resolution
23202 This leads to bugs (#37014)
23204 * delegate.cs: The signature for EndInvoke should contain any ref
23205 or out parameters as well. We were not doing this in the past.
23207 * class.cs (Field.Define): Do not overwrite the type definition
23208 inside the `volatile' group. Turns out that volatile enumerations
23209 were changing the type here to perform a validity test, which
23212 2003-02-12 Miguel de Icaza <miguel@ximian.com>
23214 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
23215 and structs, we do not want to load the instance variable
23217 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
23218 enum_type has to be handled like an object reference (implicit
23219 conversions exists from this to object), but the regular IsClass
23220 and IsValueType tests will never return true for this one.
23222 Also we use TypeManager.IsValueType instead of type.IsValueType,
23223 just for consistency with the rest of the code (this is only
23224 needed if we ever use the construct exposed by test-180.cs inside
23225 corlib, which we dont today).
23227 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23229 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23232 2003-02-09 Martin Baulig <martin@ximian.com>
23234 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23235 (Namespace.DefineNamespaces): New static public method; this is
23236 called when we're compiling with debugging to add all namespaces
23237 to the symbol file.
23239 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23240 pass it to the Namespace's .ctor.
23242 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23243 and MethodBase arguments; pass the namespace ID to the symwriter;
23244 pass the MethodBase instead of the token to the symwriter.
23245 (SymbolWriter.DefineNamespace): New method to add a namespace to
23248 2003-02-09 Martin Baulig <martin@ximian.com>
23250 * symbolwriter.cs: New file. This is a wrapper around
23251 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23252 methods here in near future.
23254 2003-02-09 Martin Baulig <martin@ximian.com>
23256 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23257 ILGenerator.MarkSequencePoint() which are actually used by the
23260 2003-02-09 Martin Baulig <martin@ximian.com>
23262 * location.cs (SourceFile): New public sealed class. This
23263 contains the name and an index which is used in the location's token.
23264 (Location): Reserve an appropriate number of bits in the token for
23265 the source file instead of walking over that list, this gives us a
23266 really huge performance improvement when compiling with debugging.
23268 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23269 `SourceFile' argument instead of a string.
23270 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23271 but don't parse/tokenize here, we need to generate the list of all
23272 source files before we do that.
23273 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23276 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23277 instead of a string.
23279 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23282 2003-02-09 Martin Baulig <martin@ximian.com>
23284 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23285 filename on `#line default'.
23287 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23289 * statement.cs: don't clear the pinned var when the fixed statement
23290 returns from the method (fixes bug#37752).
23292 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23294 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23297 2003-02-07 Martin Baulig <martin@ximian.com>
23299 * driver.cs: Removed the `--debug-args' command line argument.
23301 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23302 automatically by the AsssemblyBuilder.
23303 (CodeGen.InitializeSymbolWriter): We don't need to call any
23304 initialization function on the symbol writer anymore. This method
23305 doesn't take any arguments.
23307 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23309 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23310 from referenced assemblies as well.
23312 2003-02-02 Martin Baulig <martin@ximian.com>
23314 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23316 2003-02-02 Martin Baulig <martin@ximian.com>
23318 * class.cs (Constructor.Emit): Open the symbol writer before
23319 emitting the constructor initializer.
23320 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23321 single-stepping through constructor initializers.
23323 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23325 * class.cs: Handle error 549: do not allow virtual methods in
23328 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23330 * decl.cs: Check access levels when resolving types
23332 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23334 * statement.cs: Add parameters and locals set in catch blocks that might
23335 return to set vector
23337 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23339 * class.cs (Operator): Set the SpecialName flags for operators.
23341 * expression.cs (Invocation.DoResolve): Only block calls to
23342 accessors and operators on SpecialName methods.
23344 (Cast.TryReduce): Handle conversions from char constants.
23347 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23349 * statement.cs: small memory and time optimization in FlowBranching.
23351 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23353 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23354 problem that the last fix but in the other sid (Set).
23356 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23357 access when there is no indexer in the hierarchy.
23359 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23361 * class.cs: Combine some if statements.
23363 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23365 * driver.cs: fixed bug #37187.
23367 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23369 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23370 any indexer, it's needed to build a list with all the indexers in the
23371 hierarchy (AllGetters), else we have problems. Fixes #35653.
23373 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23375 * class.cs (MethodData.Define): It is wrong for an interface
23376 implementation to be static in both cases: explicit and implicit.
23377 We were only handling this in one case.
23379 Improve the if situation there to not have negations.
23381 * class.cs (Field.Define): Turns out that we do not need to check
23382 the unsafe bit on field definition, only on usage. Remove the test.
23384 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23386 * driver.cs: use assembly.Location instead of Codebase (the latest
23387 patch made mcs fail when using MS assemblies).
23389 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23391 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23392 get the path to *corlib.dll.
23394 2003-01-21 Nick Drochak <ndrochak@gol.com>
23398 * typemanager.cs: Remove compiler warnings
23400 2003-01-20 Duncan Mak <duncan@ximian.com>
23402 * AssemblyInfo.cs: Bump the version number to 0.19.
23404 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23406 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23408 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23410 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23412 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23414 * cs-parser.jay: Small fix: we were not comparing the constructor
23415 name correctly. Thanks to Zoltan for the initial pointer.
23417 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23419 * cs-tokenizer.cs: Set file name when specified with #line
23421 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23423 * cs-parser.jay: Only perform the constructor checks here if we
23424 are named like the class; This will help provider a better
23425 error. The constructor path is taken when a type definition is
23426 not found, but most likely the user forgot to add the type, so
23427 report that rather than the constructor error.
23429 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23431 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23434 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23436 * cs-parser.jay: Add cleanup call.
23438 2003-01-13 Duncan Mak <duncan@ximian.com>
23440 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23441 consistent with other methods.
23443 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23445 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23447 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23449 * attribute.cs: only set GuidAttr to true when we have a
23452 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23456 * typemanager.cs: fixes to allow mcs compile corlib with the new
23457 Type.IsSubclassOf fix.
23459 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23461 * expression.cs (LocalVariableReference.DoResolve): Classify a
23462 constant as a value, not as a variable. Also, set the type for
23465 * cs-parser.jay (fixed_statement): take a type instead of a
23466 pointer_type, so we can produce a better error message later.
23468 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23471 (For.DoEmit): Make inifinite loops have a
23472 non-conditional branch back.
23474 (Fixed.DoEmit): First populate the pinned variables, then emit the
23475 statement, then clear the variables. Before I was emitting the
23476 code once for each fixed piece.
23479 2003-01-08 Martin Baulig <martin@ximian.com>
23481 * statement.cs (FlowBranching.MergeChild): A break in a
23482 SWITCH_SECTION does not leave a loop. Fixes #36155.
23484 2003-01-08 Martin Baulig <martin@ximian.com>
23486 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23487 lives in the same number space than `param_map'. Fixes #36154.
23489 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23491 * cs-parser.jay (constructor_declaration): Set the
23492 Constructor.ModFlags before probing for it. This makes the
23493 compiler report 514, 515 and 132 (the code was there, but got
23496 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23497 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23498 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23500 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23502 * enum.cs: create the enum static fields using the enum type.
23504 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23506 * class.cs: don't try to create the ParamBuilder for the return
23507 type if it's not needed (and handle it breaking for the ms runtime
23510 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23512 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23514 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23516 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23517 the command. This showed up while compiling the JANET source
23518 code, which used \r as its only newline separator.
23520 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23522 * class.cs (Method.Define): If we are an operator (because it
23523 reuses our code), then set the SpecialName and HideBySig. #36128
23525 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23527 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23528 exception, report error 120 `object reference required'.
23530 * driver.cs: Add --pause option, used during to measure the size
23531 of the process as it goes with --timestamp.
23533 * expression.cs (Invocation.DoResolve): Do not allow methods with
23534 SpecialName to be invoked.
23536 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23538 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23539 number before adding it.
23541 2002-12-21 Ravi Pratap <ravi@ximian.com>
23543 * ecore.cs (StandardImplicitConversion): When in an unsafe
23544 context, we allow conversion between void * to any other pointer
23545 type. This fixes bug #35973.
23547 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23549 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23550 is not thrown when extensionless outputs are used
23552 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23554 * rootcontext.cs: fixed compilation of corlib.
23556 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23558 * attribute.cs (Attributes.Contains): Add new method.
23560 * class.cs (MethodCore.LabelParameters): if the parameter is an
23561 `out' parameter, check that no attribute `[In]' has been passed.
23563 * enum.cs: Handle the `value__' name in an enumeration.
23565 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23567 * decl.cs: Added special case to allow overrides on "protected
23570 2002-12-18 Ravi Pratap <ravi@ximian.com>
23572 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23573 since it makes much more sense.
23575 (Attributes.ctor): Don't require a Location parameter.
23577 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23579 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23580 since we already have that information per attribute.
23582 * everywhere : make appropriate changes.
23584 * class.cs (LabelParameters): Write the code which actually
23585 applies attributes to the return type. We can't do this on the MS
23586 .NET runtime so we flag a warning in the case an exception is
23589 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23591 * const.cs: Handle implicit null conversions here too.
23593 2002-12-17 Ravi Pratap <ravi@ximian.com>
23595 * class.cs (MethodCore.LabelParameters): Remove the extra
23596 Type [] parameter since it is completely unnecessary. Instead
23597 pass in the method's attributes so that we can extract
23598 the "return" attribute.
23600 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23602 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23603 of ignoring it and letting the compile continue.
23605 * typemanager.cs (ChangeType): use an extra argument to return an
23606 error condition instead of throwing an exception.
23608 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23610 * expression.cs (Unary.TryReduce): mimic the code for the regular
23611 code path. Perform an implicit cast in the cases where we can
23612 implicitly convert to one of the integral types, and then reduce
23613 based on that constant. This fixes bug #35483.
23615 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23617 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23619 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23621 * namespace.cs: fixed bug #35489.
23623 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23625 * class.cs: Remove some dead code.
23627 * cs-parser.jay: Estimate the number of methods needed
23628 (RootContext.MethodCount);
23630 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23631 numbers instead of StringBuilders.
23633 * support.cs (PtrHashtable): Add constructor with initial size;
23634 We can now reduce reallocations of the method table.
23636 2002-12-10 Ravi Pratap <ravi@ximian.com>
23638 * attribute.cs (ApplyAttributes): Keep track of the emitted
23639 attributes on a per-target basis. This fixes bug #35413.
23641 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23643 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23644 default to the Windows 1252 encoding.
23646 (UnixParseOption): Support version, thanks to Alp for the missing
23649 * AssemblyInfo.cs: Add nice assembly information.
23651 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23654 * cs-parser.jay: Allow a trailing comma before the close bracked
23655 in the attribute_section production.
23657 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23658 address of the instance was being taken, I will take this out,
23659 because we take the address of the object immediately here.
23661 2002-12-09 Ravi Pratap <ravi@ximian.com>
23663 * typemanager.cs (AreMultipleAllowed): Take care of the most
23664 obvious case where attribute type is not in the current assembly -
23667 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23669 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23670 definitions, instead of doing that afterwards.
23672 Also we use a nice little hack, depending on the constructor, we
23673 know if we are a "composed" name or a simple name. Hence, we
23674 avoid the IndexOf test, and we avoid
23676 * codegen.cs: Add code to assist in a bug reporter to track down
23677 the source of a compiler crash.
23679 2002-12-07 Ravi Pratap <ravi@ximian.com>
23681 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23682 types have been emitted for a given element and flag an error
23683 if something which does not have AllowMultiple set is used more
23686 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23687 attribute types and their corresponding AllowMultiple properties
23689 (AreMultipleAllowed): Check the property for a given type.
23691 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23692 property in the case we have a TypeContainer.
23694 (Attributes.AddAttribute): Detect duplicates and just skip on
23695 adding them. This trivial fix catches a pretty gross error in our
23696 attribute emission - global attributes were being emitted twice!
23698 Bugzilla bug #33187 is now fixed.
23700 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23702 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23703 instead of pp_and).
23705 * expression.cs (Binary.ResolveOperator): I can only use the
23706 Concat (string, string, string) and Concat (string, string,
23707 string, string) if the child is actually a concatenation of
23710 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23712 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23713 context where we need a 2-character lookahead.
23715 * pending.cs (PendingImplementation): Rework so we can keep track
23716 of interface types all the time, and flag those which were
23717 implemented by parents as optional.
23719 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23721 * expression.cs (Binary.ResolveOperator): Use
23722 String.Concat(string,string,string) or
23723 String.Concat(string,string,string,string) when possible.
23725 * typemanager: More helper methods.
23728 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23730 * pending.cs: remove the bogus return from GetMissingInterfaces()
23731 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23733 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23735 * namespace.cs: avoid duplicated 'using xxx' being added to
23736 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23737 when we get more than one 'using' statement for the same namespace.
23738 Report a CS0105 warning for it.
23740 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23742 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23743 of calling getChar/putback, uses internal knowledge of it.
23745 (xtoken): Reorder tokenizer so most common patterns are checked
23746 first. This reduces the compilation time in another 5% (from 8.11s
23747 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23749 The parsing time is 22% of the compilation in mcs, and from that
23750 64% is spent on the tokenization process.
23752 I tried using a binary search for keywords, but this is slower
23753 than the hashtable. Another option would be to do a couple of
23756 * Not use a StringBuilder, instead use an array of chars,
23757 with a set value. Notice that this way we could catch
23758 the 645 error without having to do it *afterwards*.
23760 * We could write a hand-parser to avoid the hashtable
23761 compares altogether.
23763 The identifier consumption process takes 37% of the tokenization
23764 time. Another 15% is spent on is_number. 56% of the time spent
23765 on is_number is spent on Int64.Parse:
23767 * We could probably choose based on the string length to
23768 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23771 Another 3% is spend on wrapping `xtoken' in the `token' function.
23773 Handle 0xa0 as whitespace (#34752)
23775 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23777 * typemanager.cs (IsCLRType): New routine to tell whether a type
23778 is one of the builtin types.
23780 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23781 typecode in more places instead of doing pointer comparissions.
23782 We could leverage some knowledge about the way the typecodes are
23785 New code to cache namespaces in assemblies, it is currently not
23786 invoked, to be used soon.
23788 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23790 * expression.cs (Binary.ResolveOperator): specially handle
23791 strings, and do not perform user-defined operator overloading for
23794 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23796 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23797 internalcall as it is a pretty simple operation; Avoid whenever
23798 possible to call Char.IsLetter.
23800 (consume_identifier): Cut by half the number of
23801 hashtable calls by merging the is_keyword and GetKeyword behavior.
23803 Do not short-circuit, because if we do, we
23804 report errors (ie, #if false && true would produce an invalid
23808 2002-11-24 Martin Baulig <martin@ximian.com>
23810 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23811 check constant ranges and report a CS0221. Fixes #33186.
23813 2002-11-24 Martin Baulig <martin@ximian.com>
23815 * cs-parser.jay: Make this work for uninitialized variable
23816 declarations in the `for' initializer. Fixes #32416.
23818 2002-11-24 Martin Baulig <martin@ximian.com>
23820 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23821 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23823 2002-11-24 Martin Baulig <martin@ximian.com>
23825 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23826 argument; if true, we also check for user-defined conversions.
23827 This is only needed if both arguments are of a user-defined type.
23828 Fixes #30443, added test-175.cs.
23829 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23831 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23833 2002-11-24 Martin Baulig <martin@ximian.com>
23835 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23836 function to get the store opcode.
23837 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23838 only emit the Ldelema if the store opcode is Stobj. You must run
23839 both test-34 and test-167 to test this. Fixes #34529.
23841 2002-11-23 Martin Baulig <martin@ximian.com>
23843 * ecore.cs (Expression.MemberLookup): Added additional
23844 `qualifier_type' argument which is used when we're being called
23845 from MemberAccess.DoResolve() and null if we're called from a
23847 (Expression.MemberLookupFailed): New method to report errors; this
23848 does the CS1540 check and reports the correct error message.
23850 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23851 argument for the CS1540 check and redone the way how we're dealing
23852 with private members. See the comment in the source code for details.
23853 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23854 `closure_start_type' to `closure_qualifier_type' and check whether
23855 it's not null. It was not this filter being broken, it was just
23856 being called with the wrong arguments.
23858 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23859 and pass it the correct `qualifier_type'; this also does the error
23862 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23864 * expression.cs (Invocation.EmitParams): If the we are dealing
23865 with a non-built-in value type, load its address as well.
23867 (ArrayCreation): Use a a pretty constant instead
23868 of the hardcoded value 2. Use 6 instead of 2 for the number of
23869 static initializers.
23871 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23872 because they are not really value types, just glorified integers.
23874 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23876 * ecore.cs: Remove redundant code for enumerations, make them use
23877 the same code path as everything else, fixes the casting issue
23878 with enumerations in Windows.Forms.
23880 * attribute.cs: Do only cast to string if it is a string, the
23881 validation happens later.
23883 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23884 people upgrade their corlibs.
23886 * ecore.cs: Oops, enumerations were not following the entire code path
23888 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23890 * typemanager.cs (FilterWithClosure): Commented out the test for
23891 1540 in typemanager.cs, as it has problems when accessing
23892 protected methods from a parent class (see test-174.cs).
23894 * attribute.cs (Attribute.ValidateGuid): new method.
23895 (Attribute.Resolve): Use above.
23897 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23899 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23901 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23902 handling for enumerations, as we only needed the TypeContainer
23903 functionality to begin with (this is required for the fix below to
23904 work for enums that reference constants in a container class for
23907 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23909 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23910 a valid TypeBuilder to perform lookups on.o
23912 * class.cs (InheritableMemberSignatureCompare): Use true in the
23913 call to GetGetMethod and GetSetMethod, because we are comparing
23914 the signature, and we need to get the methods *even* if they are
23917 (PropertyBase.CheckBase): ditto.
23919 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23920 GotoCase.Resolve): Use Peel on EmpytCasts.
23922 * ecore.cs (EmptyCast): drop child, add Peel method.
23924 2002-11-17 Martin Baulig <martin@ximian.com>
23926 * ecore.cs (EmptyCast.Child): New public property.
23928 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23929 label resolved to an EmptyCast. Fixes #34162.
23930 (GotoCase.Resolve): Likewise.
23931 (Block.EmitMeta): Likewise.
23933 2002-11-17 Martin Baulig <martin@ximian.com>
23935 * expression.cs (Invocation.BetterConversion): Prefer int over
23936 uint; short over ushort; long over ulong for integer literals.
23937 Use ImplicitConversionExists instead of StandardConversionExists
23938 since we also need to check for user-defined implicit conversions.
23939 Fixes #34165. Added test-173.cs.
23941 2002-11-16 Martin Baulig <martin@ximian.com>
23943 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23944 with the `true' and `false' literals. Fixes #33151.
23946 2002-11-16 Martin Baulig <martin@ximian.com>
23948 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23949 October 22nd; don't do the cs1540 check for static members.
23951 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23952 now using our own filter here and doing the cs1540 check again.
23954 2002-11-16 Martin Baulig <martin@ximian.com>
23956 * support.cs (InternalParameters): Don't crash if we don't have
23957 any fixed parameters. Fixes #33532.
23959 2002-11-16 Martin Baulig <martin@ximian.com>
23961 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23962 when looking up static methods to make this work on Windows.
23965 2002-11-16 Martin Baulig <martin@ximian.com>
23967 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23968 a setter rather than using PropertyInfo.CanWrite.
23970 2002-11-15 Nick Drochak <ndrochak@gol.com>
23972 * class.cs: Allow acces to block member by subclasses. Fixes build
23975 2002-11-14 Martin Baulig <martin@ximian.com>
23977 * class.cs (Constructor.Emit): Added the extern/block check.
23980 2002-11-14 Martin Baulig <martin@ximian.com>
23982 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23983 iteration while looking for indexers, this is needed because the
23984 indexer may have a different name in our base classes. Fixed the
23985 error reporting (no indexers at all, not get accessor, no
23986 overloaded match). Fixes bug #33089.
23987 (IndexerAccess.DoResolveLValue): Likewise.
23989 2002-11-14 Martin Baulig <martin@ximian.com>
23991 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23992 indexers. Fixes the first part of bug #33089.
23993 (MethodSignature.InheritableMemberSignatureCompare): Added support
23996 2002-11-13 Ravi Pratap <ravi@ximian.com>
23998 * attribute.cs (Attribute.Resolve): Catch the
23999 NullReferenceException and report it since it isn't supposed to
24002 2002-11-12 Miguel de Icaza <miguel@ximian.com>
24004 * expression.cs (Binary.EmitBranchable): Also handle the cases for
24005 LogicalOr and LogicalAnd that can benefit from recursively
24006 handling EmitBranchable. The code now should be nice for Paolo.
24008 2002-11-08 Miguel de Icaza <miguel@ximian.com>
24010 * typemanager.cs (LookupType): Added a negative-hit hashtable for
24011 the Type lookups, as we perform quite a number of lookups on
24012 non-Types. This can be removed once we can deterministically tell
24013 whether we have a type or a namespace in advance.
24015 But this might require special hacks from our corlib.
24019 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
24020 and double which avoids a conversion from an integer to a double.
24022 * expression.cs: tiny optimization, avoid calling IsConstant,
24023 because it effectively performs the lookup twice.
24025 2002-11-06 Miguel de Icaza <miguel@ximian.com>
24027 But a bogus return here to keep the semantics of the old code
24028 until the Mono runtime is fixed.
24030 * pending.cs (GetMissingInterfaces): New method used to remove all
24031 the interfaces that are already implemented by our parent
24032 classes from the list of pending methods.
24034 * interface.cs: Add checks for calls after ResolveTypeExpr.
24036 2002-11-05 Miguel de Icaza <miguel@ximian.com>
24038 * class.cs (Class.Emit): Report warning 67: event not used if the
24039 warning level is beyond 3.
24041 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
24042 being a NullLiteral.
24044 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
24047 * class.cs (TypeContainer.GetClassBases): Cover a missing code
24048 path that might fail if a type can not be resolved.
24050 * expression.cs (Binary.Emit): Emit unsigned versions of the
24053 * driver.cs: use error 5.
24055 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
24057 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
24059 2002-11-01 Miguel de Icaza <miguel@ximian.com>
24061 * cs-parser.jay (switch_section): A beautiful patch from Martin
24062 Baulig that fixed 33094.
24064 2002-10-31 Miguel de Icaza <miguel@ximian.com>
24066 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
24067 Check whether the base is abstract and report an error if so.
24069 * expression.cs (IndexerAccess.DoResolveLValue,
24070 IndexerAccess.DoResolve): ditto.
24072 (Invocation.DoResolve): ditto.
24074 (Invocation.FullMethodDesc): Improve the report string.
24076 * statement.cs (Block): Eliminate IsVariableDefined as it is
24077 basically just a wrapper for GetVariableInfo.
24079 * ecore.cs (SimpleName): Use new
24081 * support.cs (ReflectionParamter.ParameterType): We unwrap the
24082 type, as we return the actual parameter ref/unref state on a
24085 2002-10-30 Miguel de Icaza <miguel@ximian.com>
24087 * support.cs: Return proper flags REF/OUT fixing the previous
24090 * expression.cs: Reverted last patch, that was wrong. Is_ref is
24091 not used to mean `ref' but `ref or out' in ParameterReference
24093 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
24094 full type signature instead of calling TypeManger.CSharpName
24097 * support.cs (InternalParameters.ParameterDesc): Do not compare
24098 directly to the modflags, because REF/OUT will actually be bitsets
24101 * delegate.cs (VerifyMethod): Check also the modifiers.
24103 * cs-tokenizer.cs: Fix bug where floating point values with an
24104 exponent where a sign was missing was ignored.
24106 * driver.cs: Allow multiple assemblies to be specified in a single
24109 2002-10-28 Miguel de Icaza <miguel@ximian.com>
24111 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
24112 because identifiers after a parenthesis would end up in this kind
24113 of production, and we needed to desamiguate it for having casts
24116 (UserDefinedType *) xxx
24118 2002-10-24 Miguel de Icaza <miguel@ximian.com>
24120 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
24121 we should set on the Bindingflags.NonPublic, but not turn on
24122 private_ok. private_ok controls whether a Private member is
24123 returned (this is chekced on the filter routine), while the
24124 BindingFlags.NonPublic just controls whether private/protected
24125 will be allowed. This fixes the problem part of the problem of
24126 private properties being allowed to be used in derived classes.
24128 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
24129 so we can call the children DoResolveLValue method (this will
24130 properly signal errors on lvalue assignments to base properties)
24132 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
24133 getter are null, and we have a property info, we know that this
24134 happened because the lookup failed, so we report an error 122 for
24135 protection level violation.
24137 We also silently return if setter and getter are null in the
24138 resolve functions, this condition only happens if we have flagged
24139 the error before. This is the other half of the problem.
24141 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
24142 not have accessibility information, that is why we were returning
24143 true in the filter function in typemanager.cs.
24145 To properly report 122 (property is inaccessible because of its
24146 protection level) correctly, we report this error in ResolveAccess
24147 by failing if both the setter and the getter are lacking (ie, the
24150 DoResolve and DoLResolve have been modified to check for both
24151 setter/getter being null and returning silently, the reason being
24152 that I did not want to put the knowledge about this error in upper
24155 int old = Report.Errors;
24156 x = new PropertyExpr (...);
24157 if (old != Report.Errors)
24162 So the property expr is returned, but it is invalid, so the error
24163 will be flagged during the resolve process.
24165 * class.cs: Remove InheritablePropertySignatureCompare from the
24166 class, as we no longer depend on the property signature to compute
24167 whether it is possible to implement a method or not.
24169 The reason is that calling PropertyInfo.GetGetMethod will return
24170 null (in .NET, in Mono it works, and we should change this), in
24171 cases where the Get Method does not exist in that particular
24176 class X { public virtual int A { get { return 1; } } }
24178 class Z : Y { public override int A { get { return 2; } } }
24180 Would fail in Z because the parent (Y) would not have the property
24181 defined. So we avoid this completely now (because the alternative
24182 fix was ugly and slow), and we now depend exclusively on the
24185 (PropertyBase.CheckBase): Use a method-base mechanism to find our
24186 reference method, instead of using the property.
24188 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
24189 routines are gone now.
24191 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
24192 names, they were incorrectly named.
24194 * cs-tokenizer.cs: Return are more gentle token on failure.
24196 * pending.cs (PendingImplementation.InterfaceMethod): This routine
24197 had an out-of-sync index variable, which caused it to remove from
24198 the list of pending methods the wrong method sometimes.
24200 2002-10-22 Miguel de Icaza <miguel@ximian.com>
24202 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
24203 CanWrite, because those refer to this particular instance of the
24204 property, and do not take into account the fact that we can
24205 override single members of a property.
24207 Constructor requires an EmitContext. The resolution process does
24208 not happen here, but we need to compute the accessors before,
24209 because the resolution does not always happen for properties.
24211 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
24212 subclass, before we did not update this flag, but we did update
24215 (GetAccessors): Drop this routine, as it did not work in the
24216 presence of partially overwritten set/get methods.
24218 Notice that this broke the cs1540 detection, but that will require
24221 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24225 * driver.cs: issue a warning instead of an error if we don't support
24226 debugging for the platform. Also ignore a couple of errors that may
24227 arise when trying to write the symbols. Undo my previous patch.
24229 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24231 * driver.cs: ignore /debug switch except for Unix platforms.
24233 2002-10-23 Nick Drochak <ndrochak@gol.com>
24235 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24237 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24239 * driver.cs: Do not make mcs-debug conditional, so we do not break
24240 builds that use it.
24242 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24243 review this patch. But basically after all the children variables
24244 have been merged, the value of "Breaks" was not being set to
24245 new_breaks for Switch blocks. I think that it should be set after
24246 it has executed. Currently I set this to the value of new_breaks,
24247 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24248 conservative, but I do not understand this code very well.
24250 I did not break anything in the build, so that is good ;-)
24252 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24254 2002-10-20 Mark Crichton <crichton@gimp.org>
24256 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24258 2002-10-20 Nick Drochak <ndrochak@gol.com>
24260 * cfold.cs: Fixed compile blocker.
24262 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24264 * driver.cs: I was chekcing the key, not the file.
24266 2002-10-19 Ravi Pratap <ravi@ximian.com>
24268 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24269 message that we were generating - we just need to silently return
24272 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24274 * class.cs (Event.Define): Change my previous commit, as this
24275 breaks the debugger. This is a temporary hack, as it seems like
24276 the compiler is generating events incorrectly to begin with.
24278 * expression.cs (Binary.ResolveOperator): Added support for
24279 "U operator - (E x, E y)"
24281 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24284 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24285 init-only variables, but this path did not take into account that
24286 there might be also instance readonly variables. Correct this
24289 This fixes bug 32253
24291 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24294 * driver.cs: Change the extension for modules to `netmodule'
24296 * cs-parser.jay: Improved slightly the location tracking for
24297 the debugger symbols.
24299 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24300 modifiers that were specified instead of the hardcoded value
24301 (FamAndAssem). This was basically ignoring the static modifier,
24302 and others. Fixes 32429.
24304 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24305 fixed a bug in the process (32476)
24307 * expression.cs (ArrayAccess.EmitAssign): Patch from
24308 hwang_rob@yahoo.ca that fixes bug 31834.3
24310 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24312 * driver.cs: Make the module extension .netmodule.
24314 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24316 * driver.cs: Report an error if the resource file is not found
24317 instead of crashing.
24319 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24320 false, like Emit does.
24322 2002-10-16 Nick Drochak <ndrochak@gol.com>
24324 * typemanager.cs: Remove unused private member. Also reported mcs
24325 bug to report this as a warning like csc.
24327 2002-10-15 Martin Baulig <martin@gnome.org>
24329 * statement.cs (Statement.Emit): Made this a virtual method; emits
24330 the line number info and calls DoEmit().
24331 (Statement.DoEmit): New protected abstract method, formerly knows
24332 as Statement.Emit().
24334 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24336 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24338 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24339 have fixed a remaining problem: not every AddXXXX was adding a
24340 fully qualified name.
24342 Now everyone registers a fully qualified name in the DeclSpace as
24343 being defined instead of the partial name.
24345 Downsides: we are slower than we need to be due to the excess
24346 copies and the names being registered this way.
24348 The reason for this is that we currently depend (on the corlib
24349 bootstrap for instance) that types are fully qualified, because
24350 we dump all the types in the namespace, and we should really have
24351 types inserted into the proper namespace, so we can only store the
24352 basenames in the defined_names array.
24354 2002-10-10 Martin Baulig <martin@gnome.org>
24356 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24357 from bug #31834, see the bug report for a testcase which is
24360 2002-10-10 Martin Baulig <martin@gnome.org>
24362 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24363 flow analysis code for this.
24365 * statement.cs (Do, While, For): Tell the flow analysis code about
24367 (FlowBranching.UsageVector): Added support for infinite loops.
24368 (Block.Resolve): Moved the dead code elimination here and use flow
24371 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24373 * class.cs (Field.Define): Catch cycles on struct type
24376 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24377 fields if the fields are static. We only need to check instance
24380 * expression.cs (As.DoResolve): Test for reference type.
24382 * statement.cs (Using.ResolveExpression): Use
24383 ConvertImplicitRequired, not ConvertImplicit which reports an
24385 (Using.ResolveLocalVariableDecls): ditto.
24387 * expression.cs (Binary.ResolveOperator): Report errors in a few
24388 places where we had to.
24390 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24392 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24394 * expression.cs: Use StoreFromPtr instead of extracting the type
24395 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24397 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24398 an enumeration value to a System.Enum, but System.Enum is not a
24399 value type, but an class type, so we need to box.
24401 (Expression.ConvertExplicit): One codepath could return
24402 errors but not flag them. Fix this. Fixes #31853
24404 * parameter.cs (Resolve): Do not allow void as a parameter type.
24406 2002-10-06 Martin Baulig <martin@gnome.org>
24408 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24409 if it's a class type and not a struct. Fixes #31815.
24411 2002-10-06 Martin Baulig <martin@gnome.org>
24413 * statement.cs: Reworked the flow analysis code a bit to make it
24414 usable for dead code elimination.
24416 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24418 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24420 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24422 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24423 to fix the test 165, will investigate deeper.
24425 2002-10-04 Martin Baulig <martin@gnome.org>
24427 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24428 finally blocks actually work.
24429 (Try.Resolve): We don't need to create a sibling for `finally' if
24430 there is no finally block.
24432 2002-10-04 Martin Baulig <martin@gnome.org>
24434 * class.cs (Constructor.Define): The default accessibility for a
24435 non-default constructor is private, not public.
24437 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24439 * class.cs (Constructor): Make AllowedModifiers public, add
24442 * cs-parser.jay: Perform the modifiers test here, as the
24443 constructor for the Constructor class usually receives a zero
24444 because of the way we create it (first we create, later we
24445 customize, and we were never checking the modifiers).
24447 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24448 is a version of LookupTypeReflection that includes the type-name
24449 cache. This can be used as a fast path for functions that know
24450 the fully qualified name and are only calling into *.GetType() to
24451 obtain a composed type.
24453 This is also used by TypeManager.LookupType during its type
24456 (LookupType): We now also track the real type name, as sometimes
24457 we can get a quey for the real type name from things like
24458 ComposedCast. This fixes bug 31422.
24460 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24461 complete type fullname, it does not have to go through the type
24462 resolution system to obtain the composed version of the type (for
24463 obtaining arrays or pointers).
24465 (Conditional.Emit): Use the EmitBoolExpression to
24466 generate nicer code, as requested by Paolo.
24468 (ArrayCreation.CheckIndices): Use the patch from
24469 hwang_rob@yahoo.ca to validate the array initializers.
24471 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24473 * class.cs (ConstructorInitializer.Emit): simplify code by using
24474 Invocation.EmitCall, and at the same time, fix the bugs in calling
24475 parent constructors that took variable arguments.
24477 * ecore.cs (Expression.ConvertNumericExplicit,
24478 Expression.ImplicitNumericConversion): Remove the code that
24479 manually wrapped decimal (InternalTypeConstructor call is now gone
24482 * expression.cs (Cast.TryReduce): Also handle decimal types when
24483 trying to perform a constant fold on the type.
24485 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24487 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24488 that only turned off an error report, and did nothing else.
24490 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24492 * driver.cs: Handle and ignore /fullpaths
24494 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24496 * expression.cs (Binary.ResolveOperator): Catch the case where
24497 DoNumericPromotions returns true,
24499 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24501 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24503 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24506 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24508 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24509 conversion exists, but it is also required that the conversion be
24510 performed. This manifested in "(Type64Enum) 2".
24512 * class.cs (TypeManager.AddMethod): The fix is not to change
24513 AddEnum, because that one was using a fully qualified name (every
24514 DeclSpace derivative does), but to change the AddMethod routine
24515 that was using an un-namespaced name. This now correctly reports
24516 the duplicated name.
24518 Revert patch until I can properly fix it. The issue
24519 is that we have a shared Type space across all namespaces
24520 currently, which is wrong.
24522 Options include making the Namespace a DeclSpace, and merge
24523 current_namespace/current_container in the parser.
24525 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24527 * cs-parser.jay: Improve error reporting when we get a different
24528 kind of expression in local_variable_type and
24529 local_variable_pointer_type.
24531 Propagate this to avoid missleading errors being reported.
24533 * ecore.cs (ImplicitReferenceConversion): treat
24534 TypeManager.value_type as a target just like object_type. As
24539 Is valid, and needs to result in the int 1 being boxed before it
24540 is assigned to the value type v.
24542 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24543 to validate the enumeration name.
24545 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24546 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24547 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24549 * ecore.cs (TryImplicitIntConversion): When doing an
24550 implicit-enumeration-conversion, check if the type is 64-bits and
24551 perform a conversion before passing to EnumConstant.
24553 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24555 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24556 report ambiguous type references. Unlike the MS version, we
24557 report what the ambiguity is. Innovation at work ;-)
24559 (DeclSpace.FindType): Require a location argument to
24560 display when we display an ambiguous error.
24562 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24564 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24566 * expression.cs (EmitDynamicInitializers): Apply patch from
24567 hwang_rob@yahoo.ca that fixes the order in which we emit our
24570 2002-09-21 Martin Baulig <martin@gnome.org>
24572 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24573 delegate takes no arguments.
24575 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24577 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24580 * expression.cs: Extract the underlying type.
24582 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24584 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24586 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24588 * class.cs (TypeContainer.DefineType): We can not use the nice
24589 PackingSize with the size set to 1 DefineType method, because it
24590 will not allow us to define the interfaces that the struct
24593 This completes the fixing of bug 27287
24595 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24596 means also structs. This fixes part of the problem.
24597 (Expresion.ImplicitReferenceConversionExists): ditto.
24599 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24600 error if there were no errors reported during the type lookup
24601 process, to avoid duplicates or redundant errors. Without this
24602 you would get an ambiguous errors plus a type not found. We have
24603 beaten the user enough with the first error.
24605 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24608 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24609 during the resolution process, stop the lookup, this avoids
24610 repeated error reports (same error twice).
24612 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24614 * typemanager.cs (LookupType): Redo the type lookup code to match
24615 the needs of System.Reflection.
24617 The issue is that System.Reflection requires references to nested
24618 types to begin with a "+" sign instead of a dot. So toplevel
24619 types look like: "NameSpace.TopLevelClass", and nested ones look
24620 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24623 2002-09-19 Martin Baulig <martin@gnome.org>
24625 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24626 says that a method always returns or always throws an exception,
24627 don't report the CS0161.
24629 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24630 set `Returns = new_returns'.
24632 2002-09-19 Martin Baulig <martin@gnome.org>
24634 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24635 to an enum constant, check for a CS0176.
24637 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24639 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24640 for operators that must be in pairs and report errors.
24642 * ecore.cs (SimpleName.DoResolveType): During the initial type
24643 resolution process, when we define types recursively, we must
24644 check first for types in our current scope before we perform
24645 lookups in the enclosing scopes.
24647 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24649 (Invocation.VerifyArgumentsCompat): Call
24650 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24651 I thought we were supposed to always call this, but there are a
24652 few places in the code where we dont do it.
24654 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24656 * driver.cs: Add support in -linkres and -resource to specify the
24657 name of the identifier.
24659 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24661 * ecore.cs (StandardConversionExists): Sync with the conversion
24662 code: allow anything-* to void* conversions.
24664 (FindMostSpecificSource): Use an Expression argument
24665 instead of a Type, because we might be handed over a Literal which
24666 gets a few more implicit conversions that plain types do not. So
24667 this information was being lost.
24669 Also, we drop the temporary type-holder expression when not
24672 2002-09-17 Martin Baulig <martin@gnome.org>
24674 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24675 this is an explicit interface implementation.
24677 2002-09-17 Martin Baulig <martin@gnome.org>
24679 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24680 different `IndexerName' attributes.
24682 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24683 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24684 virtual CommonResolve().
24686 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24688 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24689 and convert that to the UnderlyingType.
24691 * statement.cs (Foreach.Resolve): Indexers are just like variables
24692 or PropertyAccesses.
24694 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24695 inside quoted strings, we were not doing this before.
24697 2002-09-16 Martin Baulig <martin@gnome.org>
24699 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24700 resolve it. This is needed for the definite assignment check of the
24701 instance expression, fixes bug #29846.
24702 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24704 2002-09-16 Nick Drochak <ndrochak@gol.com>
24706 * parameter.cs: Fix compile error. Cannot reference static member
24707 from an instance object. Is this an mcs bug?
24709 2002-09-14 Martin Baulig <martin@gnome.org>
24711 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24712 multiple times. Fixes bug #30295, added test-166.cs.
24714 2002-09-14 Martin Baulig <martin@gnome.org>
24716 * statement.cs (Block.Emit): Don't emit unreachable code.
24717 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24718 `break' statements.
24719 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24721 2002-09-14 Martin Baulig <martin@gnome.org>
24723 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24726 2002-09-14 Martin Baulig <martin@gnome.org>
24728 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24729 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24730 be false on the ms runtime.
24732 2002-09-13 Martin Baulig <martin@gnome.org>
24734 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24735 the CS0038 error message.
24737 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24739 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24740 constant inside, return it.
24742 2002-09-12 Martin Baulig <martin@gnome.org>
24744 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24745 implicit conversion can be done between enum types.
24747 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24748 check whether an implicit conversion to the current enum's UnderlyingType
24749 exists and report an error if not.
24751 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24752 without debugging support.
24754 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24755 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24757 2002-09-12 Martin Baulig <martin@gnome.org>
24759 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24761 * ecore.cs (IMemberExpr.DeclaringType): New property.
24762 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24763 nonstatic member of an outer type (CS0038).
24765 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24767 * driver.cs: Activate the using-error detector at warning level
24768 4 (at least for MS-compatible APIs).
24770 * namespace.cs (VerifyUsing): Small buglett fix.
24772 * pending.cs (PendingImplementation): pass the container pointer.
24774 * interface.cs (GetMethods): Allow for recursive definition. Long
24775 term, I would like to move every type to support recursive
24776 definitions, not the current ordering mechanism that we have right
24779 The situation is this: Attributes are handled before interfaces,
24780 so we can apply attributes to interfaces. But some attributes
24781 implement interfaces, we will now handle the simple cases
24782 (recursive definitions will just get an error).
24784 * parameter.cs: Only invalidate types at the end if we fail to
24787 2002-09-09 Martin Baulig <martin@gnome.org>
24789 * ecore.cs (PropertyExpr.Emit): Also check for
24790 TypeManager.system_int_array_get_length so this'll also work when
24791 compiling corlib. Fixes #30003.
24793 2002-09-09 Martin Baulig <martin@gnome.org>
24795 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24796 and throw an exception if we can't get the type's size. Fixed #30040,
24799 2002-09-09 Martin Baulig <martin@gnome.org>
24801 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24803 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24804 context. Fixes bug #30027.
24806 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24807 virtual functions. Fixes bug #30043, added test-164.cs.
24809 2002-09-08 Ravi Pratap <ravi@ximian.com>
24811 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24813 2002-09-08 Nick Drochak <ndrochak@gol.com>
24815 * driver.cs: Use an object to get the windows codepage since it's not a
24818 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24820 * statement.cs (For.Emit): for infinite loops (test == null)
24821 return whether there is a break inside, not always "true".
24823 * namespace.cs (UsingEntry): New struct to hold the name of the
24824 using definition, the location where it is defined, and whether it
24825 has been used in a successful type lookup.
24827 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24832 2002-09-06 Ravi Pratap <ravi@ximian.com>
24834 * attribute.cs : Fix incorrect code which relied on catching
24835 a NullReferenceException to detect a null being passed in
24836 where an object was expected.
24838 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24840 * statement.cs (Try): flag the catch variable as assigned
24842 * expression.cs (Cast): Simplified by using ResolveType instead of
24843 manually resolving.
24845 * statement.cs (Catch): Fix bug by using ResolveType.
24847 2002-09-06 Ravi Pratap <ravi@ximian.com>
24849 * expression.cs (BetterConversion): Special case for when we have
24850 a NullLiteral as the argument and we have to choose between string
24851 and object types - we choose string the way csc does.
24853 * attribute.cs (Attribute.Resolve): Catch the
24854 NullReferenceException and report error #182 since the Mono
24855 runtime no more has the bug and having this exception raised means
24856 we tried to select a constructor which takes an object and is
24859 2002-09-05 Ravi Pratap <ravi@ximian.com>
24861 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24862 message (1502, 1503) when we can't locate a method after overload
24863 resolution. This is much more informative and closes the bug
24866 * interface.cs (PopulateMethod): Return if there are no argument
24867 types. Fixes a NullReferenceException bug.
24869 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24870 expressions too. Previously we were checking only in one place for
24871 positional arguments leaving out named arguments.
24873 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24874 type to the enum type is not allowed. Remove code corresponding to
24877 (ConvertNumericExplicit): Allow explicit conversions from
24878 the underlying type to enum type. This precisely follows the spec
24879 and closes a bug filed by Gonzalo.
24881 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24884 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24886 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24888 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24889 it was important that we stored the right value after the
24890 reduction in `converted'.
24892 2002-09-04 Martin Baulig <martin@gnome.org>
24894 * location.cs (Location.SymbolDocument): Use full pathnames for the
24897 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24899 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24900 of the expression resolve mechanism, because that will catch the
24901 SimpleName error failures.
24903 (Conditional): If we can not resolve the
24904 expression, return, do not crash.
24906 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24909 (location): display token name instead of its number.
24911 2002-08-28 Martin Baulig <martin@gnome.org>
24913 * expression.cs (Binary.ResolveOperator): Don't silently return
24914 but return an error if an operator cannot be applied between two
24917 2002-08-28 Martin Baulig <martin@gnome.org>
24919 * class.cs (Constructor.Define): Set the permission attributes
24920 correctly instead of making all constructors public.
24922 2002-08-28 Martin Baulig <martin@gnome.org>
24924 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24925 for private members before reporting a CS0103; if we find anything,
24928 2002-08-28 Martin Baulig <martin@gnome.org>
24930 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24931 to check whether `closure_start_type == closure_invocation_type',
24932 we also need to check whether `m.DeclaringType == closure_invocation_type'
24933 before bypassing the permission checks. We might be accessing
24934 protected/private members from the base class.
24935 (TypeManager.RealMemberLookup): Only set private_ok if private
24936 members were requested via BindingFlags.NonPublic.
24938 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24940 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24941 MethodGroupExpr.IsExplicitImpl if appropriate.
24942 (Invocation.DoResolve): Don't report the CS0120 for explicit
24943 interface implementations.
24945 2002-08-27 Martin Baulig <martin@gnome.org>
24947 * expression.cs (Invocation.DoResolve): If this is a static
24948 method and we don't have an InstanceExpression, we must report
24951 2002-08-25 Martin Baulig <martin@gnome.org>
24953 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24954 `==' between a valuetype and an object.
24956 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24958 * ecore.cs (TypeExpr): Provide a ToString method.
24960 2002-08-24 Martin Baulig <martin@gnome.org>
24962 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24963 now called proggie.dbg and it's a binary file.
24965 2002-08-23 Martin Baulig <martin@gnome.org>
24967 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24969 2002-08-23 Martin Baulig <martin@gnome.org>
24971 * struct.cs (MyStructInfo.ctor): Make this work with empty
24972 structs; it's not allowed to use foreach() on null.
24974 2002-08-23 Martin Baulig <martin@gnome.org>
24976 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24977 writer the full pathname of the generated assembly.
24979 2002-08-23 Martin Baulig <martin@gnome.org>
24981 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24982 A `finally' block never returns or breaks; improved handling of
24985 2002-08-23 Martin Baulig <martin@gnome.org>
24987 * statement.cs (Throw.Resolve): Allow `throw null'.
24989 2002-08-23 Martin Baulig <martin@gnome.org>
24991 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24992 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24993 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24994 MemberLookup would return a wrong event if this is an explicit
24995 interface implementation and the class has an event with the same
24998 2002-08-23 Martin Baulig <martin@gnome.org>
25000 * statement.cs (Block.AddChildVariableNames): New public method.
25001 (Block.AddChildVariableName): Likewise.
25002 (Block.IsVariableNameUsedInChildBlock): Likewise.
25003 (Block.AddVariable): Check whether a variable name has already
25004 been used in a child block.
25006 * cs-parser.jay (declare_local_variables): Mark all variable names
25007 from the current block as being used in a child block in the
25010 2002-08-23 Martin Baulig <martin@gnome.org>
25012 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
25013 find the symbol writer.
25015 * driver.cs: csc also allows the arguments to /define being
25016 separated by commas, not only by semicolons.
25018 2002-08-23 Martin Baulig <martin@gnome.org>
25020 * interface.cs (Interface.GetMembers): Added static check for events.
25022 2002-08-15 Martin Baulig <martin@gnome.org>
25024 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
25025 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
25027 * ecore.cs (Expression.MemberLookup): Added documentation and explained
25028 why the MethodData.EmitDestructor() change was necessary.
25030 2002-08-20 Martin Baulig <martin@gnome.org>
25032 * class.cs (TypeContainer.FindMembers): Added static check for events.
25034 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
25036 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
25037 use Type.GetEvents(), not Type.FindMembers().
25039 2002-08-20 Martin Baulig <martin@gnome.org>
25041 * decl.cs (MemberCache): Added a special method cache which will
25042 be used for method-only searched. This ensures that a method
25043 search will return a MethodInfo with the correct ReflectedType for
25046 2002-08-20 Martin Baulig <martin@gnome.org>
25048 * decl.cs (DeclSpace.FindMembers): Made this public.
25050 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25052 * delegate.cs: fixed build on windows.
25053 [FIXME: Filed as bug #29150: MCS must report these errors.]
25055 2002-08-19 Ravi Pratap <ravi@ximian.com>
25057 * ecore.cs (StandardConversionExists): Return a false
25058 if we are trying to convert the void type to anything else
25059 since that is not allowed.
25061 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
25062 we flag error 70 in the event an event is trying to be accessed
25063 directly from outside the declaring type.
25065 2002-08-20 Martin Baulig <martin@gnome.org>
25067 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
25068 MemberCache from typemanager.cs to decl.cs.
25070 2002-08-19 Martin Baulig <martin@gnome.org>
25072 * class.cs (TypeContainer): Implement IMemberContainer.
25073 (TypeContainer.DefineMembers): Create the MemberCache.
25074 (TypeContainer.FindMembers): Do better BindingFlags checking; only
25075 return public members if BindingFlags.Public was given, check
25076 whether members are static.
25078 2002-08-16 Martin Baulig <martin@gnome.org>
25080 * decl.cs (DeclSpace.Define): Splitted this in Define and
25081 DefineMembers. DefineMembers is called first and initializes the
25084 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
25085 DefineMembers() on all our DeclSpaces.
25087 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
25088 but call DefineMembers() on all nested interfaces. We call their
25089 Define() in our new Define() function.
25091 * interface.cs (Interface): Implement IMemberContainer.
25092 (Interface.Define): Moved all code except the attribute stuf to
25094 (Interface.DefineMembers): Initialize the member cache.
25096 * typemanager.cs (IMemberFinder): Removed this interface, we don't
25097 need this anymore since we can use MemberCache.FindMembers directly.
25099 2002-08-19 Martin Baulig <martin@gnome.org>
25101 * typemanager.cs (MemberCache): When creating the cache for an
25102 interface type, add all inherited members.
25103 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
25104 to `out bool used_cache' and documented it.
25105 (TypeManager.MemberLookup): If we already used the cache in the first
25106 iteration, we don't need to do the interfaces check.
25108 2002-08-19 Martin Baulig <martin@gnome.org>
25110 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
25111 here from IMemberFinder and don't implement this interface anymore.
25112 (DeclSpace.MemberCache): Moved here from IMemberFinder.
25114 * typemanager.cs (IMemberFinder): This interface is now only used by
25115 classes which actually support the member cache.
25116 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
25117 since we only put DeclSpaces into this Hashtable.
25118 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
25119 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
25121 2002-08-16 Martin Baulig <martin@gnome.org>
25123 * typemanager.cs (ICachingMemberFinder): Removed.
25124 (IMemberFinder.MemberCache): New property.
25125 (TypeManager.FindMembers): Merged this with RealFindMembers().
25126 This function will never be called from TypeManager.MemberLookup()
25127 so we can't use the cache here, just the IMemberFinder.
25128 (TypeManager.MemberLookup_FindMembers): Check whether the
25129 IMemberFinder has a MemberCache and call the cache's FindMembers
25131 (MemberCache): Rewrote larger parts of this yet another time and
25132 cleaned it up a bit.
25134 2002-08-15 Miguel de Icaza <miguel@ximian.com>
25136 * driver.cs (LoadArgs): Support quoting.
25138 (Usage): Show the CSC-like command line arguments.
25140 Improved a few error messages.
25142 2002-08-15 Martin Baulig <martin@gnome.org>
25144 * typemanager.cs (IMemberContainer.Type): New property.
25145 (IMemberContainer.IsInterface): New property.
25147 The following changes are conditional to BROKEN_RUNTIME, which is
25148 defined at the top of the file.
25150 * typemanager.cs (MemberCache.MemberCache): Don't add the base
25151 class'es members, but add all members from TypeHandle.ObjectType
25152 if we're an interface.
25153 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
25154 is the current type.
25155 (MemberCache.CacheEntry.Container): Removed this field.
25156 (TypeHandle.GetMembers): Include inherited members.
25158 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25160 * typemanager.cs: fixed compilation and added a comment on a field that
25163 2002-08-15 Martin Baulig <martin@gnome.org>
25165 * class.cs (ConstructorInitializer.Resolve): In the
25166 Expression.MemberLookup call, use the queried_type as
25169 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
25170 declared' attribute, it's always true.
25171 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
25172 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
25173 temporary wrapper for FindMembers which tells MemberLookup whether
25174 members from the base classes are included in the return value.
25175 This will go away soon.
25176 (TypeManager.MemberLookup): Use this temporary hack here; once the
25177 new MemberCache is completed, we don't need to do the DeclaredOnly
25178 looping here anymore since the MemberCache will take care of this.
25179 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
25180 (MemberCache): When creating the MemberCache for a class, get
25181 members from the current class and all its base classes.
25182 (MemberCache.CacheEntry.Container): New field. This is a
25183 temporary hack until the Mono runtime is fixed to distinguish
25184 between ReflectedType and DeclaringType. It allows us to use MCS
25185 with both the MS runtime and the unfixed Mono runtime without
25186 problems and without accecting performance.
25187 (MemberCache.SearchMembers): The DeclaredOnly looping from
25188 TypeManager.MemberLookup is now done here.
25190 2002-08-14 Martin Baulig <martin@gnome.org>
25192 * statement.cs (MyStructInfo.MyStructInfo): Don't call
25193 Type.GetFields on dynamic types but get the fields from the
25194 corresponding TypeContainer.
25195 (MyStructInfo.GetStructInfo): Added check for enum types.
25197 * typemanager.cs (MemberList.IsSynchronized): Implemented.
25198 (MemberList.SyncRoot): Implemented.
25199 (TypeManager.FilterWithClosure): No need to check permissions if
25200 closure_start_type == closure_invocation_type, don't crash if
25201 closure_invocation_type is null.
25203 2002-08-13 Martin Baulig <martin@gnome.org>
25205 Rewrote TypeContainer.FindMembers to use a member cache. This
25206 gives us a speed increase of about 35% for the self-hosting MCS
25207 build and of about 15-20% for the class libs (both on GNU/Linux).
25209 * report.cs (Timer): New class to get enhanced profiling. This
25210 whole class is "TIMER" conditional since it remarkably slows down
25213 * class.cs (MemberList): New class. This is an IList wrapper
25214 which we're now using instead of passing MemberInfo[]'s around to
25215 avoid copying this array unnecessarily.
25216 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
25217 (ICachingMemberFinder, IMemberContainer): New interface.
25218 (TypeManager.FilterWithClosure): If `criteria' is null, the name
25219 has already been checked, otherwise use it for the name comparision.
25220 (TypeManager.FindMembers): Renamed to RealMemberFinder and
25221 provided wrapper which tries to use ICachingMemberFinder.FindMembers
25222 if possible. Returns a MemberList, not a MemberInfo [].
25223 (TypeHandle): New class, implements IMemberContainer. We create
25224 one instance of this class per type, it contains a MemberCache
25225 which is used to do the member lookups.
25226 (MemberCache): New class. Each instance of this class contains
25227 all members of a type and a name-based hash table.
25228 (MemberCache.FindMembers): This is our new member lookup
25229 function. First, it looks up all members of the requested name in
25230 the hash table. Then, it walks this list and sorts out all
25231 applicable members and returns them.
25233 2002-08-13 Martin Baulig <martin@gnome.org>
25235 In addition to a nice code cleanup, this gives us a performance
25236 increase of about 1.4% on GNU/Linux - not much, but it's already
25237 half a second for the self-hosting MCS compilation.
25239 * typemanager.cs (IMemberFinder): New interface. It is used by
25240 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25241 Enum, Delegate or Interface.
25242 (TypeManager.finder_to_member_finder): New PtrHashtable.
25243 (TypeManager.finder_to_container): Removed.
25244 (TypeManager.finder_to_delegate): Removed.
25245 (TypeManager.finder_to_interface): Removed.
25246 (TypeManager.finder_to_enum): Removed.
25248 * interface.cs (Interface): Implement IMemberFinder.
25250 * delegate.cs (Delegate): Implement IMemberFinder.
25252 * enum.cs (Enum): Implement IMemberFinder.
25254 * class.cs (TypeContainer): Implement IMemberFinder.
25256 2002-08-12 Martin Baulig <martin@gnome.org>
25258 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25260 2002-08-12 Martin Baulig <martin@gnome.org>
25262 * ecore.cs (ITypeExpression): New interface for expressions which
25264 (TypeExpression): Renamed to TypeLookupExpression.
25265 (Expression.DoResolve): If we're doing a types-only lookup, the
25266 expression must implement the ITypeExpression interface and we
25267 call DoResolveType() on it.
25268 (SimpleName): Implement the new ITypeExpression interface.
25269 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25270 hack, the situation that we're only looking up types can't happen
25271 anymore when this method is called. Moved the type lookup code to
25272 DoResolveType() and call it.
25273 (SimpleName.DoResolveType): This ITypeExpression interface method
25274 is now doing the types-only lookup.
25275 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25276 (ResolveFlags): Added MaskExprClass.
25278 * expression.cs (MemberAccess): Implement the ITypeExpression
25280 (MemberAccess.DoResolve): Added support for a types-only lookup
25281 when we're called via ITypeExpression.DoResolveType().
25282 (ComposedCast): Implement the ITypeExpression interface.
25284 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25285 Expression.Resolve() with ResolveFlags.Type instead.
25287 2002-08-12 Martin Baulig <martin@gnome.org>
25289 * interface.cs (Interface.Define): Apply attributes.
25291 * attribute.cs (Attribute.ApplyAttributes): Added support for
25292 interface attributes.
25294 2002-08-11 Martin Baulig <martin@gnome.org>
25296 * statement.cs (Block.Emit): Only check the "this" variable if we
25297 do not always throw an exception.
25299 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25300 whether the property has a set accessor.
25302 2002-08-11 Martin Baulig <martin@gnome.org>
25304 Added control flow analysis support for structs.
25306 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25307 with control flow analysis turned off.
25308 (IVariable): New interface.
25309 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25310 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25311 (FieldExpr.DoResolve): Resolve the instance expression with flow
25312 analysis turned off and do the definite assignment check after the
25313 resolving when we know what the expression will resolve to.
25315 * expression.cs (LocalVariableReference, ParameterReference):
25316 Implement the new IVariable interface, only call the flow analysis
25317 code if ec.DoFlowAnalysis is true.
25318 (This): Added constructor which takes a Block argument. Implement
25319 the new IVariable interface.
25320 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25321 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25322 This does the definite assignment checks for struct members.
25324 * class.cs (Constructor.Emit): If this is a non-static `struct'
25325 constructor which doesn't have any initializer, call
25326 Block.AddThisVariable() to tell the flow analysis code that all
25327 struct elements must be initialized before control returns from
25330 * statement.cs (MyStructInfo): New public class.
25331 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25332 argument to this indexer. If non-zero, check an individual struct
25333 member, not the whole struct.
25334 (FlowBranching.CheckOutParameters): Check struct members.
25335 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25336 overloaded versions of these methods which take an additional
25337 `int field_idx' argument to check struct members.
25338 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25339 overloaded versions of these methods which take an additional
25340 `string field_name' argument to check struct member.s
25341 (VariableInfo): Implement the IVariable interface.
25342 (VariableInfo.StructInfo): New public property. Returns the
25343 MyStructInfo instance of the variable if it's a struct or null.
25344 (Block.AddThisVariable): New public method. This is called from
25345 Constructor.Emit() for non-static `struct' constructor which do
25346 not have any initializer. It creates a special variable for the
25347 "this" instance variable which will be checked by the flow
25348 analysis code to ensure that all of the struct's fields are
25349 initialized before control returns from the constructor.
25350 (UsageVector): Added support for struct members. If a
25351 variable/parameter is a struct with N members, we reserve a slot
25352 in the usage vector for each member. A struct is considered fully
25353 initialized if either the struct itself (slot 0) or all its
25354 members are initialized.
25356 2002-08-08 Martin Baulig <martin@gnome.org>
25358 * driver.cs (Driver.MainDriver): Only report an error CS5001
25359 if there were no compilation errors.
25361 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25362 `UnsafeContext' property to determine whether the parent is in
25363 unsafe context rather than checking the parent's ModFlags:
25364 classes nested in an unsafe class are unsafe as well.
25366 2002-08-08 Martin Baulig <martin@gnome.org>
25368 * statement.cs (UsageVector.MergeChildren): Distinguish between
25369 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25370 we return. Added test17() and test18() to test-154.cs.
25372 2002-08-08 Martin Baulig <martin@gnome.org>
25374 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25375 Family access, make sure the invoking type isn't a subclass of the
25376 queried type (that'd be a CS1540).
25378 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25379 this method which takes an additional `Type invocation_type'.
25381 * expression.cs (BaseAccess.DoResolve): Use the base type as
25382 invocation and query type.
25383 (MemberAccess.DoResolve): If the lookup failed and we're about to
25384 report a CS0122, try a lookup with the ec.ContainerType - if this
25385 succeeds, we must report a CS1540.
25387 2002-08-08 Martin Baulig <martin@gnome.org>
25389 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25390 (MethodGroupExpr): Implement the IMemberExpr interface.
25392 * expression (MemberAccess.ResolveMemberAccess): No need to have
25393 any special code for MethodGroupExprs anymore, they're now
25396 2002-08-08 Martin Baulig <martin@gnome.org>
25398 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25399 Family, FamANDAssem and FamORAssem permissions.
25400 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25402 2002-08-08 Martin Baulig <martin@gnome.org>
25404 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25405 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25408 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25410 * driver.cs: implemented /resource option to embed managed resources.
25412 2002-08-07 Martin Baulig <martin@gnome.org>
25414 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25415 (FieldBase.HasFieldInitializer): New public property.
25416 (FieldBase.GetInitializerExpression): New public method. Resolves and
25417 returns the field initializer and makes sure it is only resolved once.
25418 (TypeContainer.EmitFieldInitializers): Call
25419 FieldBase.GetInitializerExpression to get the initializer, this ensures
25420 that it isn't resolved multiple times.
25422 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25423 the resolving process (SimpleName/MemberLookup) that we're currently
25424 emitting a field initializer (which must not access any instance members,
25425 this is an error CS0236).
25427 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25428 argument, if the `IsFieldInitializer' flag is set, we must report and
25429 error CS0236 and not an error CS0120.
25431 2002-08-07 Martin Baulig <martin@gnome.org>
25433 * ecore.cs (IMemberExpr): New public interface.
25434 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25435 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25436 if the expression is an IMemberExpr.
25438 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25439 to be null, implicitly default to `this' if we're non-static in
25440 this case. Simplified the code a lot by using the new IMemberExpr
25441 interface. Also fixed bug #28176 here.
25443 2002-08-06 Martin Baulig <martin@gnome.org>
25445 * cs-parser.jay (SimpleLookup): Removed. We need to create
25446 ParameterReferences during semantic analysis so that we can do a
25447 type-only search when resolving Cast, TypeOf and SizeOf.
25448 (block): Pass the `current_local_parameters' to the Block's
25451 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25452 argument to the constructor.
25453 (ConstructorInitializer.Resolve): Create a temporary implicit
25454 block with the parameters.
25456 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25457 references here if we aren't doing a type-only search.
25459 * statement.cs (Block): Added constructor which takes a
25460 `Parameters parameters' argument.
25461 (Block.Parameters): New public property.
25463 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25464 to `Parameters' and made it public readonly.
25466 2002-08-06 Martin Baulig <martin@gnome.org>
25468 * ecore.cs (Expression.Warning): Made this public as well.
25470 * report.cs (Report.Debug): Print the contents of collections.
25472 2002-08-06 Martin Baulig <martin@gnome.org>
25474 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25475 used to tell Resolve() which kinds of expressions it may return.
25476 (Expression.Resolve): Added overloaded version of this method which
25477 takes a `ResolveFlags flags' argument. This can be used to tell
25478 Resolve() which kinds of expressions it may return. Reports a
25480 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25481 ResolveFlags.SimpleName.
25482 (Expression.Error118): Added overloaded version of this method which
25483 takes a `ResolveFlags flags' argument. It uses the flags to determine
25484 which kinds of expressions are allowed.
25486 * expression.cs (Argument.ResolveMethodGroup): New public method.
25487 Resolves an argument, but allows a MethodGroup to be returned.
25488 This is used when invoking a delegate.
25490 * TODO: Updated a bit.
25492 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25494 Fixed compilation with csc.
25496 * ecore.cs: Expression.Error made public. Is this correct? Should
25497 Warning be made public too?
25499 * expression.cs: use ea.Location instead of ea.loc.
25500 [FIXME: Filed as bug #28607: MCS must report these errors.]
25502 2002-08-06 Martin Baulig <martin@gnome.org>
25504 * ecore.cs (Expression.loc): Moved the location here instead of
25505 duplicating it in all derived classes.
25506 (Expression.Location): New public property.
25507 (Expression.Error, Expression.Warning): Made them non-static and
25508 removed the location argument.
25509 (Expression.Warning): Added overloaded version which takes an
25510 `int level' argument.
25511 (Expression.Error118): Make this non-static and removed the
25512 expression and location arguments.
25513 (TypeExpr): Added location argument to the constructor.
25515 * expression.cs (StaticCallExpr): Added location argument to
25517 (Indirection, PointerArithmetic): Likewise.
25518 (CheckedExpr, UnCheckedExpr): Likewise.
25519 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25520 (StringPtr): Likewise.
25523 2002-08-05 Martin Baulig <martin@gnome.org>
25525 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25527 * assign.cs (Assign.DoResolve): Check whether the source
25528 expression is a value or variable.
25530 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25531 while resolving the corresponding blocks.
25533 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25534 an error, don't silently return null.
25536 * statement.cs (Block.AddVariable): Do the error reporting here
25537 and distinguish between CS0128 and CS0136.
25538 (Block.DoResolve): Report all unused labels (warning CS0164).
25539 (LabeledStatement): Pass the location to the constructor.
25540 (LabeledStatement.HasBeenReferenced): New property.
25541 (LabeledStatement.Resolve): Set it to true here.
25543 * statement.cs (Return.Emit): Return success even after reporting
25544 a type mismatch error (CS0126 or CS0127), this is what csc does and
25545 it avoids confusing the users with any consecutive errors.
25547 2002-08-05 Martin Baulig <martin@gnome.org>
25549 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25551 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25553 * expression.cs (MemberAccess.DoResolve): Silently return if an
25554 error has already been reported.
25556 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25557 error has already been reported.
25559 2002-08-05 Martin Baulig <martin@gnome.org>
25561 * statement.cs (UsageVector): Only initialize the `parameters'
25562 vector if we actually have any "out" parameters.
25564 2002-08-05 Martin Baulig <martin@gnome.org>
25566 * expression.cs (Binary.ResolveOperator): When combining delegates,
25567 they must have the same type.
25569 2002-08-05 Martin Baulig <martin@gnome.org>
25571 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25572 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25573 work with the ms runtime and we also don't need it: if we're a
25574 PropertyBuilder and not in the `indexer_arguments' hash, then we
25575 are a property and not an indexer.
25577 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25578 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25579 since the latter one doesn't work with the ms runtime.
25581 2002-08-03 Martin Baulig <martin@gnome.org>
25583 Fixed bugs #27998 and #22735.
25585 * class.cs (Method.IsOperator): New public field.
25586 (Method.CheckBase): Report CS0111 if there's already a method
25587 with the same parameters in the current class. Report CS0508 when
25588 attempting to change the return type of an inherited method.
25589 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25590 and it's not marked abstract or extern.
25591 (PropertyBase): New abstract base class for Property and Indexer.
25592 (PropertyBase.CheckBase): Moved here from Property and made it work
25594 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25595 the same so we can reuse it there.
25596 (Property, Indexer): Derive from PropertyBase.
25597 (MethodSignature.inheritable_property_signature_filter): New delegate
25598 to find properties and indexers.
25600 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25601 argument and improved error reporting.
25603 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25604 EmptyReadOnlyParameters and made it a property.
25606 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25607 version of this method which takes a `PropertyInfo indexer'.
25608 (TypeManager.RegisterIndexer): New method.
25610 * class.cs: Added myself as author of this file :-)
25612 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25614 * class.cs: fixed compilation on windoze.
25616 2002-08-03 Martin Baulig <martin@gnome.org>
25618 * interface.cs (Interface.GetInterfaceBases): Check whether all
25619 base interfaces are at least as accessible than the current one.
25621 * class.cs (TypeContainer.GetClassBases): Check whether base types
25622 are at least as accessible than the current type.
25623 (TypeContainer.AsAccessible): Implemented and made non-static.
25624 (MemberBase.CheckParameters): Report errors if the accessibility
25627 * delegate.cs (Delegate.Delegate): The default visibility is
25628 internal for top-level types and private for nested types.
25629 (Delegate.Define): Report errors if the accessibility checks fail.
25631 * enum.cs (Enum.Enum): The default visibility is internal for
25632 top-level types and private for nested types.
25633 (Enum.DefineType): Compute the correct visibility.
25635 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25636 function which takes a `bool is_toplevel' instead of a TypeContainer.
25638 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25641 2002-08-02 Martin Baulig <martin@gnome.org>
25643 * expression.cs (LocalVariableReferenc): Added constructor which
25644 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25645 (LocalVariableReference.IsReadOnly): New property.
25646 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25647 variable is readonly, use our own readonly flag to do this; you can
25648 use the new constructor to get a writable reference to a read-only
25651 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25652 reference to the local variable.
25654 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25656 * rootcontext.cs (ResolveCore): Also include System.Exception
25658 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25659 we reach an EmptyStatement.
25661 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25664 * expression.cs (Binary.ResolveOperator): Check error result in
25667 use brtrue/brfalse directly and avoid compares to null.
25669 2002-08-02 Martin Baulig <martin@gnome.org>
25671 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25672 Fixes bug #28407, added test-155.cs.
25674 2002-08-01 Martin Baulig <martin@gnome.org>
25676 * class.cs (Event.EmitDefaultMethod): Make this work with static
25677 events. Fixes #28311, added verify-3.cs.
25679 2002-08-01 Martin Baulig <martin@gnome.org>
25681 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25682 `is_disposable' fields.
25683 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25684 `hm.is_disposable' if we're using the collection pattern.
25685 (Foreach.EmitCollectionForeach): Use the correct type for the
25686 enumerator's local variable, only emit the try/finally block if
25687 necessary (fixes #27713).
25689 2002-08-01 Martin Baulig <martin@gnome.org>
25691 * ecore.cs (Expression.report118): Renamed to Error118 and made
25694 * statement.cs (Throw.Resolve): Check whether the expression is of
25695 the correct type (CS0118) and whether the type derives from
25696 System.Exception (CS0155).
25697 (Catch.Resolve): New method. Do the type lookup here and check
25698 whether it derives from System.Exception (CS0155).
25699 (Catch.CatchType, Catch.IsGeneral): New public properties.
25701 * typemanager.cs (TypeManager.exception_type): Added.
25703 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25705 * driver.cs: Updated About function.
25707 2002-07-31 Martin Baulig <martin@gnome.org>
25709 Implemented Control Flow Analysis.
25711 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25712 (EmitContext.CurrentBranching): Added.
25713 (EmitContext.StartFlowBranching): Added.
25714 (EmitContext.EndFlowBranching): Added.
25715 (EmitContext.KillFlowBranching): Added.
25716 (EmitContext.IsVariableAssigned): Added.
25717 (EmitContext.SetVariableAssigned): Added.
25718 (EmitContext.IsParameterAssigned): Added.
25719 (EmitContext.SetParameterAssigned): Added.
25720 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25721 Added control flow analysis stuff here.
25723 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25724 resolve the expression as lvalue.
25725 (LocalVariableReference.DoResolve): Check whether the variable has
25726 already been assigned.
25727 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25728 the parameter as assigned here.
25729 (ParameterReference.DoResolve): Check whether the parameter has already
25731 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25732 expression as lvalue.
25734 * statement.cs (FlowBranching): New class for the flow analysis code.
25735 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25736 (LabeledStatement.IsDefined): New public property.
25737 (LabeledStatement.AddUsageVector): New public method to tell flow
25738 analyis that the label may be reached via a forward jump.
25739 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25741 (VariableInfo.Number): New public field. This is used by flow analysis
25742 to number all locals of a block.
25743 (Block.CountVariables): New public property. This is the number of
25744 local variables in this block (including the locals from all parent
25746 (Block.EmitMeta): Number all the variables.
25748 * statement.cs: Added flow analysis support to all classes.
25750 2002-07-31 Martin Baulig <martin@gnome.org>
25752 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25753 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25754 then use this argument.
25756 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25758 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25759 use this to specify /define options.
25761 2002-07-29 Martin Baulig <martin@gnome.org>
25763 * statement.cs (Fixed): Moved all code that does variable lookups
25764 and resolvings from Emit to Resolve.
25766 * statement.cs (For): Moved all code that does variable lookups
25767 and resolvings from Emit to Resolve.
25769 * statement.cs (Using): Moved all code that does variable lookups
25770 and resolvings from Emit to Resolve.
25772 2002-07-29 Martin Baulig <martin@gnome.org>
25774 * attribute.cs (Attribute.Resolve): Explicitly catch a
25775 System.NullReferenceException when creating the
25776 CustromAttributeBuilder and report a different warning message.
25778 2002-07-29 Martin Baulig <martin@gnome.org>
25780 * support.cs (ParameterData.ParameterName): Added method to
25781 get the name of a parameter.
25783 * typemanager.cs (TypeManager.IsValueType): New public method.
25785 2002-07-29 Martin Baulig <martin@gnome.org>
25787 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25788 is a flag which specifies that it's either ref or out.
25789 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25790 the out parameter to `out Parameter.Modifier mod', also set the
25791 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25793 * support.cs (InternalParameters.ParameterModifier): Distinguish
25794 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25795 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25797 * expression.cs (Argument.GetParameterModifier): Distinguish
25798 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25799 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25801 2002-07-29 Martin Baulig <martin@gnome.org>
25803 * expression.cs (ParameterReference.ParameterReference): Added
25804 `Location loc' argument to the constructor.
25806 * cs-parser.jay: Pass location to ParameterReference.
25808 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25810 * statement.cs (Try): Initialize the location.
25812 * cs-parser.jay: pass location to Try.
25814 * expression.cs (Unary.Reduce): Change the prototype to return
25815 whether a constant fold could be performed or not. The result is
25816 returned in an out parameters. In the case of Indirection and
25817 AddressOf, we want to perform the full tests.
25819 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25821 * statement.cs (Statement.Emit): Flag dead code.
25823 2002-07-27 Andrew Birkett <andy@nobugs.org>
25825 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25827 2002-07-27 Martin Baulig <martin@gnome.org>
25829 * class.cs (MethodData.Define): Put back call to
25830 TypeManager.AddMethod(), accidentally commented this out.
25832 * report.cs (Debug): New public method to print debugging information,
25833 this is `[Conditional ("DEBUG")]'.
25835 2002-07-26 Martin Baulig <martin@gnome.org>
25837 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25838 (switch_statement): Push the current_block to the switch_stack and
25839 pop it again when we're done with the switch.
25840 (switch_section): The new block is a child of the current_block.
25841 Fixes bug #24007, added test-152.cs.
25843 2002-07-27 Martin Baulig <martin@gnome.org>
25845 * expression.cs (Invocation.EmitArguments): When calling a varargs
25846 function with only its fixed arguments, we need to pass an empty
25849 2002-07-27 Martin Baulig <martin@gnome.org>
25851 Mono 0.13 has been released.
25853 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25855 * driver.cs: Rename --resource to --linkres, because that is what
25856 we do currently, we dont support --resource yet.
25858 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25860 2002-07-25 Martin Baulig <martin@gnome.org>
25862 * class.cs (MethodData): New public class. This is a `method builder'
25863 class for a method or one accessor of a Property/Indexer/Event.
25864 (MethodData.GetMethodFlags): Moved here from MemberBase.
25865 (MethodData.ApplyAttributes): Likewise.
25866 (MethodData.ApplyObsoleteAttribute): Likewise.
25867 (MethodData.ApplyConditionalAttribute): Likewise.
25868 (MethodData.ApplyDllImportAttribute): Likewise.
25869 (MethodData.CheckAbstractAndExternal): Likewise.
25870 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25871 (MethodData.Emit): Formerly known as Method.Emit().
25872 (MemberBase): Moved everything which was specific to a single
25873 accessor/method to MethodData.
25874 (Method): Create a new MethodData and call Define() and Emit() on it.
25875 (Property, Indexer, Event): Create a new MethodData objects for each
25876 accessor and call Define() and Emit() on them.
25878 2002-07-25 Martin Baulig <martin@gnome.org>
25880 Made MethodCore derive from MemberBase to reuse the code from there.
25881 MemberBase now also checks for attributes.
25883 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25884 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25886 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25887 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25888 (MemberBase.ApplyAttributes): New virtual method; applies the
25889 attributes to a method or accessor.
25890 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25891 (MemberBase.ApplyConditionalAttribute): Likewise.
25892 (MemberBase.ApplyDllImportAttribute): Likewise.
25893 (MemberBase.CheckAbstractAndExternal): Likewise.
25894 (MethodCore.ParameterTypes): This is now a property instead of a
25895 method, it's initialized from DoDefineParameters().
25896 (MethodCore.ParameterInfo): Removed the set accessor.
25897 (MethodCore.DoDefineParameters): New protected virtual method to
25898 initialize ParameterTypes and ParameterInfo.
25899 (Method.GetReturnType): We can now simply return the MemberType.
25900 (Method.GetMethodFlags): Override the MemberBase version and add
25901 the conditional flags.
25902 (Method.CheckBase): Moved some code from Define() here, call
25903 DoDefineParameters() here.
25904 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25905 here to avoid some larger code duplication.
25906 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25907 ensure that abstract and external accessors don't declare a body.
25909 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25910 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25911 lookup in the attribute's parent classes, so we need to abort as soon
25912 as we found the first match.
25913 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25914 the attribute has no arguments.
25916 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25919 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25921 * cs-parser.jay: reverted previous patch.
25923 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25925 * cs-parser.jay: fixed bug #22119.
25927 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25929 * attribute.cs: fixed compilation. The error was:
25930 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25931 be assigned to before control leaves the current method."
25932 [FIXME: Filed as bug #28186: MCS must report this error.]
25934 2002-07-25 Martin Baulig <martin@gnome.org>
25936 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25937 method to pull the condition name ouf of a Conditional attribute.
25938 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25939 the obsolete message and error flag out of an Obsolete attribute.
25941 * class.cs (Method.GetMethodFlags): New public method to get the
25942 TypeManager.MethodFlags for this method.
25943 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25945 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25946 if we're overriding a virtual function, set the new private variable
25947 `parent_method'; call the new TypeManager.AddMethod().
25949 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25950 the MethodBuilder and the Method in a PtrHashtable.
25951 (TypeManager.builder_to_method): Added for this purpose.
25952 (TypeManager.MethodFlags): Added IsObsoleteError.
25953 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25954 Obsolete and Conditional arguments in MethodBuilders. If we discover
25955 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25956 the message from the attribute.
25958 2002-07-24 Martin Baulig <martin@gnome.org>
25960 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25961 preprocessor directives, ensure that the argument to #define/#undef is
25962 exactly one identifier and that it's actually an identifier.
25964 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25967 2002-07-24 Martin Baulig <martin@gnome.org>
25969 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25970 initialize it to TypeManager.object_type in the constructor.
25971 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25972 of the `hm.get_current' method if we're using the collection pattern.
25973 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25974 for the explicit conversion to make it work when we're using the collection
25975 pattern and the `Current' property has a different return type than `object'.
25978 2002-07-24 Martin Baulig <martin@gnome.org>
25980 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25981 does not match, but don't report any errors. This method is called in
25982 order for all methods in a MethodGroupExpr until a matching method is
25983 found, so we don't want to bail out if the first method doesn't match.
25984 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25985 matches, report the 123. Fixes #28070.
25987 2002-07-24 Martin Baulig <martin@gnome.org>
25989 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25990 TypeManager.TypeToCoreType() to the top of the method so the
25991 following equality checks will work. Fixes #28107.
25993 2002-07-24 Martin Baulig <martin@gnome.org>
25995 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25996 operand is of type uint, and the other operand is of type sbyte,
25997 short or int, the operands are converted to type long." -
25998 Actually do what this comment already told us. Fixes bug #28106,
26001 2002-07-24 Martin Baulig <martin@gnome.org>
26003 * class.cs (MethodBase): New abstract class. This is now a base
26004 class for Property, Indexer and Event to avoid some code duplication
26005 in their Define() and DefineMethods() methods.
26006 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
26007 generic methods for Define() and DefineMethods().
26008 (FieldBase): Derive from MemberBase, not MemberCore.
26009 (Property): Derive from MemberBase, not MemberCore.
26010 (Property.DefineMethod): Moved all the code from this method to the
26011 new MethodBase.DefineAccessor(), just call it with appropriate
26013 (Property.Define): Call the new Property.DoDefine(), this does some
26014 sanity checks and we don't need to duplicate the code everywhere.
26015 (Event): Derive from MemberBase, not MemberCore.
26016 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
26017 accessors, this will also make them work with interface events.
26018 (Indexer): Derive from MemberBase, not MemberCore.
26019 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
26020 (Indexer.Define): Use the new MethodBase functions.
26022 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
26023 argument to the constructor.
26024 (Interface.FindMembers): Added support for interface events.
26025 (Interface.PopluateEvent): Implemented.
26027 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
26029 2002-07-22 Miguel de Icaza <miguel@ximian.com>
26031 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
26032 but this is required to check for a method name being the same as
26033 the containing class.
26037 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26039 * interface.cs: initialize variable.
26041 2002-07-23 Martin Baulig <martin@gnome.org>
26043 Implemented the IndexerName attribute in interfaces.
26045 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
26046 name if this is an explicit interface implementation.
26047 (Indexer.InterfaceIndexerName): New public variable. If we're
26048 implementing an interface indexer, this is the IndexerName in that
26049 interface. Otherwise, it's the IndexerName.
26050 (Indexer.DefineMethod): If we're implementing interface indexer,
26051 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
26052 and Pending.ImplementIndexer methods.
26053 (Indexer.Define): Also define the PropertyBuilder if we're
26054 implementing an interface indexer and this is neither an explicit
26055 interface implementation nor do the IndexerName match the one in
26058 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
26059 If a method is defined here, then we always need to create a proxy
26060 for it. This is used when implementing interface indexers.
26061 (Pending.IsInterfaceIndexer): New public method.
26062 (Pending.ImplementIndexer): New public method.
26063 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
26064 This is used when implementing interface indexers to define a proxy
26066 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
26067 define a proxy if necessary.
26069 * interface.cs (Interface.IndexerName): New public variable.
26070 (Interface.PopulateIndexer): Set the IndexerName.
26071 (Interface.DefineIndexers): New private method. Populate all the
26072 indexers and make sure their IndexerNames match.
26074 * typemanager.cs (IndexerPropertyName): Added support for interface
26077 2002-07-22 Martin Baulig <martin@gnome.org>
26079 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
26080 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
26081 ret if HasReturnLabel.
26082 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
26085 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
26086 and set the ec.LoopBeginTryCatchLevel.
26087 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
26088 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
26089 the current ec.TryCatchLevel, the branch goes out of an exception
26090 block. In this case, we need to use Leave and not Br.
26092 2002-07-22 Martin Baulig <martin@gnome.org>
26094 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
26095 block unless the block does not always return or it is contained in
26096 another try { ... } catch { ... } block. Fixes bug #26506.
26097 Added verify-1.cs to the test suite.
26099 2002-07-22 Martin Baulig <martin@gnome.org>
26101 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
26102 then we do not always return. Fixes bug #24985.
26104 2002-07-22 Martin Baulig <martin@gnome.org>
26106 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
26107 lookup on a per-class level; ie. walk up the class hierarchy until we
26108 found at least one applicable method, then choose the best among them.
26109 Fixes bug #24463 and test-29.cs.
26111 2002-07-22 Martin Baulig <martin@gnome.org>
26113 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
26114 return types of the methods. The return type is not part of the
26115 signature and we must not check it to make the `new' modifier work.
26116 Fixes bug #27999, also added test-147.cs.
26117 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
26119 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
26120 on the method's return type.
26122 2002-07-21 Martin Baulig <martin@gnome.org>
26124 * assign.cs: Make this work if the rightmost source is a constant and
26125 we need to do an implicit type conversion. Also adding a few more tests
26126 to test-38.cs which should have caught this.
26128 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
26129 target in the makefile for this. The makefile.gnu is primarily intended
26130 for end-users who don't want to debug the compiler.
26132 2002-07-21 Martin Baulig <martin@gnome.org>
26134 * assign.cs: Improved the Assign class so it can now handle embedded
26135 assignments (X = Y = Z = something). As a side-effect this'll now also
26136 consume less local variables. test-38.cs now passes with MCS, added
26137 a few new test cases to that test.
26139 2002-07-20 Martin Baulig <martin@gnome.org>
26141 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
26142 instructions. Fixes bug #27977, also added test-146.cs.
26144 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26146 * cs-tokenizer.cs: fixed getHex ().
26148 2002-07-19 Martin Baulig <martin@gnome.org>
26150 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
26151 not Type.GetType() to lookup the array type. This is needed when
26152 we're constructing an array of a user-defined type.
26153 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
26154 single-dimensional arrays, but also for single-dimensial arrays of
26157 2002-07-19 Martin Baulig <martin@gnome.org>
26159 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
26160 this function is called, it's not allowed to share LocalBuilders
26161 among ILGenerators.
26163 2002-07-19 Martin Baulig <martin@gnome.org>
26165 * expression.cs (Argument.Resolve): Report an error 118 when trying
26166 to pass a type as argument.
26168 2002-07-18 Martin Baulig <martin@gnome.org>
26170 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
26171 Conv_R_Un for the signed `long' type.
26173 2002-07-15 Miguel de Icaza <miguel@ximian.com>
26175 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
26176 `expr' for the temporary result, as that will fail if we do
26177 multiple resolves on the same expression.
26179 2002-07-05 Miguel de Icaza <miguel@ximian.com>
26181 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
26182 ec.TypeContainer for looking up aliases.
26184 * class.cs (TypeContainer): Remove LookupAlias from here.
26186 * decl.cs (DeclSpace); Move here.
26188 2002-07-01 Miguel de Icaza <miguel@ximian.com>
26190 * class.cs (FindMembers): Only call filter if the constructor
26191 bulider is not null.
26193 Also handle delegates in `NestedTypes' now. Now we will perform
26194 type lookups using the standard resolution process. This also
26197 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
26198 This uses Expressions (the limited kind that can be parsed by the
26199 tree) instead of strings.
26201 * expression.cs (ComposedCast.ToString): Implement, used to flag
26202 errors since now we have to render expressions.
26204 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
26207 * ecore.cs (SimpleName.ToString): ditto.
26209 * cs-parser.jay: Instead of using strings to assemble types, use
26210 Expressions to assemble the type (using SimpleName, ComposedCast,
26211 MemberAccess). This should fix the type lookups in declarations,
26212 because we were using a different code path for this.
26214 * statement.cs (Block.Resolve): Continue processing statements
26215 even when there is an error.
26217 2002-07-17 Miguel de Icaza <miguel@ximian.com>
26219 * class.cs (Event.Define): Also remove the `remove' method from
26220 the list of pending items.
26222 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
26223 generate more compact code.
26225 2002-07-17 Martin Baulig <martin@gnome.org>
26227 * const.cs (Const.LookupConstantValue): Add support for constant
26228 `unchecked' and `checked' expressions.
26229 Also adding test case test-140.cs for this.
26231 2002-07-17 Martin Baulig <martin@gnome.org>
26233 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26234 check whether mi.ReturnType implements the IEnumerator interface; the
26235 `==' and the IsAssignableFrom() will fail in this situation.
26237 2002-07-16 Ravi Pratap <ravi@ximian.com>
26239 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26242 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26244 * expression.cs: fixed bug #27811.
26246 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26248 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26249 Molaro: when we are a ref, the value already contains a pointer
26250 value, do not take the address of it.
26252 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26253 * removed mb-parser.jay and mb-tokenizer.cs
26255 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26257 * expression.cs: check against the building corlib void type.
26259 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26261 * ecore.cs: fix for valuetype static readonly fields: when
26262 initializing them, we need their address, not the address of a copy.
26264 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26266 * typemanager.cs: register also enum_type in corlib.
26268 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26270 * class.cs: allow calling this (but not base) initializers in structs.
26272 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26274 * ecore.cs: make sure we compare against the building base types
26277 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26279 * typemanager.cs: fix TypeToCoreType() to handle void and object
26280 (corlib gets no more typerefs after this change).
26282 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26284 * expression.cs (ArrayCreation.EmitArrayArguments): use
26285 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26287 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26288 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26289 array indexes, the runtime actually forbids them.
26291 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26292 for array arguments here.
26294 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26295 instead of the default for ValueTypes.
26297 (New.DoEmit): Use IsValueType instead of
26298 IsSubclassOf (value_type)
26299 (New.DoResolve): ditto.
26300 (Invocation.EmitCall): ditto.
26302 * assign.cs (Assign): ditto.
26304 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26305 Statements *are* currently doing part of their resolution during
26308 Expressions do always resolve during resolve, but statements are
26309 only required to propagate resolution to their children.
26311 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26313 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26315 (LoadAssembly): Do not add the dll if it is already specified
26317 (MainDriver): Add the System directory to the link path at the end,
26318 after all the other -L arguments.
26320 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26321 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26322 ldelem.u1) and using the opposite for sbytes.
26324 This fixes Digger, and we can finally run it.
26326 * driver.cs (UnixParseOption): Move the option parsing here.
26327 (CSCParseOption): Implement CSC-like parsing of options.
26329 We now support both modes of operation, the old Unix way, and the
26330 new CSC-like way. This should help those who wanted to make cross
26331 platform makefiles.
26333 The only thing broken is that /r:, /reference: and /lib: are not
26334 implemented, because I want to make those have the same semantics
26335 as the CSC compiler has, and kill once and for all the confussion
26336 around this. Will be doing this tomorrow.
26338 * statement.cs (Unsafe.Resolve): The state is checked during
26339 resolve, not emit, so we have to set the flags for IsUnsfe here.
26341 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26343 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26344 not catch the Error_ObjectRefRequired in SimpleName (as it is
26345 possible to have a class/instance variable name that later gets
26346 deambiguated), we have to check this here.
26348 2002-07-10 Ravi Pratap <ravi@ximian.com>
26350 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26351 make static and put into Expression.
26353 (Event.Define): Register the private field of the event with the
26354 TypeManager so that GetFieldFromEvent can get at it.
26356 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26357 keep track of the private field associated with an event which
26360 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26363 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26365 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26367 * expression.cs (Binary.EmitBranchable): this routine emits the
26368 Binary expression in a branchable context. This basically means:
26369 we need to branch somewhere, not just get the value on the stack.
26371 This works together with Statement.EmitBoolExpression.
26373 * statement.cs (Statement.EmitBoolExpression): Use
26376 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26378 * statement.cs (For): Reduce the number of jumps in loops.
26380 (For): Implement loop inversion for the For statement.
26382 (Break): We can be breaking out of a Try/Catch controlled section
26383 (foreach might have an implicit try/catch clause), so we need to
26384 use Leave instead of Br.
26386 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26387 now). If the instace expression supports IMemoryLocation, we use
26388 the AddressOf method from the IMemoryLocation to extract the
26389 address instead of emitting the instance.
26391 This showed up with `This', as we were emitting the instance
26392 always (Emit) instead of the Address of This. Particularly
26393 interesting when This is a value type, as we dont want the Emit
26394 effect (which was to load the object).
26396 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26398 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26400 * statement.cs (Checked): Set the CheckedState during the resolve
26401 process too, as the ConvCast operations track the checked state on
26402 the resolve process, and not emit.
26404 * cs-parser.jay (namespace_member_declaration): Flag that we have
26405 found a declaration when we do. This is used to flag error 1529
26407 * driver.cs: Report ok when we display the help only.
26409 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26411 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26413 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26415 * cs-tokenizer.cs (define): We also have to track locally the
26416 defines. AllDefines is just used for the Conditional Attribute,
26417 but we also need the local defines for the current source code.
26419 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26421 * statement.cs (While, For, Do): These loops can exit through a
26422 Break statement, use this information to tell whether the
26423 statement is the last piece of code.
26425 (Break): Flag that we break.
26427 * codegen.cs (EmitContexts): New `Breaks' state variable.
26429 2002-07-03 Martin Baulig <martin@gnome.org>
26431 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26432 modifiers in method declarations in structs. Otherwise, you won't
26433 be able to override things like Object.Equals().
26435 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26437 * class.cs (Method, Property, Indexer): Do not allow the public
26438 modifier to be used in explicit interface implementations.
26440 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26441 override modifiers in method declarations in structs
26443 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26445 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26446 integer or real overflow, report an error
26448 2002-07-02 Martin Baulig <martin@gnome.org>
26450 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26451 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26452 to tell the runtime about our newly created System.Object and
26453 System.ValueType types.
26455 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26457 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26458 struct instead of Ldarg/Starg.
26460 2002-07-02 Martin Baulig <martin@gnome.org>
26462 * expression.cs (Indirection.Indirection): Call
26463 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26465 2002-07-02 Martin Baulig <martin@gnome.org>
26467 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26468 ValueType, call TypeManager.TypeToCoreType() on it.
26469 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26470 the OpCodes.Newarr argument.
26472 2002-07-02 Martin Baulig <martin@gnome.org>
26474 * expression.cs (Invocation.EmitCall): When compiling corlib,
26475 replace all calls to the system's System.Array type to calls to
26476 the newly created one.
26478 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26479 System.Array methods.
26480 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26481 from the system's System.Array type which must be replaced.
26483 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26485 * typemanager.cs: load unverifiable_code_ctor so we can build
26486 corlib using the correct type. Avoid using GetTypeCode() with
26488 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26489 TypeManager.object_type to allow building corlib.
26491 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26493 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26495 2002-07-01 Martin Baulig <martin@gnome.org>
26497 * class.cs: Make the last change actually work, we need to check
26498 whether `ifaces != null' to avoid a crash.
26500 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26502 * class.cs: when we build structs without fields that implement
26503 interfaces, we need to add the interfaces separately, since there is
26504 no API to both set the size and add the interfaces at type creation
26507 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26509 * expression.cs: the dimension arguments to the array constructors
26510 need to be converted if they are a long.
26512 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26514 * class.cs: don't emit ldarg.0 if there is no parent constructor
26515 (fixes showstopper for corlib).
26517 2002-06-29 Martin Baulig <martin@gnome.org>
26519 MCS now compiles corlib on GNU/Linux :-)
26521 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26522 ie. check for MethodImplOptions.InternalCall.
26524 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26525 and TypeManager.attribute_type are null, so we must explicitly check
26526 whether parent is not null to find out whether it's an attribute type.
26527 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26528 and SetBuilder, not only if the property is neither abstract nor external.
26529 This is necessary to set the MethodImplOptions on the accessor methods.
26530 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26531 SetBuilder, see Property.Emit().
26533 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26534 populate "System.Object", "System.ValueType" and "System.Attribute" since
26535 they've already been populated from BootCorlib_PopulateCoreTypes().
26537 2002-06-29 Martin Baulig <martin@gnome.org>
26539 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26540 is the NullLiteral, we also need to make sure that target_type is not
26543 2002-06-29 Martin Baulig <martin@gnome.org>
26545 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26546 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26547 before calling BootstrapCorlib_ResolveDelegate ().
26549 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26551 * statement.cs: fixed build-breaker. All tests passed ok.
26553 2002-06-27 Martin Baulig <martin@gnome.org>
26555 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26556 for System.Decimal when compiling corlib.
26558 2002-06-27 Martin Baulig <martin@gnome.org>
26560 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26561 switch blocks which contain nothing but a default clause.
26563 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26565 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26567 2002-06-27 Martin Baulig <martin@gnome.org>
26569 * ecore.cs (PropertyExpr.PropertyExpr): Call
26570 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26572 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26573 is already a TypeBuilder.
26575 2002-06-27 Martin Baulig <martin@gnome.org>
26577 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26578 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26579 the "from an array-type to System.Array" case. This makes it work
26580 when compiling corlib.
26582 2002-06-27 Martin Baulig <martin@gnome.org>
26584 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26585 non-static PropertyExpr, set its InstanceExpression. This makes
26586 the `ICollection.Count' property work in System/Array.cs.
26588 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26590 * driver.cs: Made error handling more consistent. Errors now
26591 tracked by Report class, so many methods which used to return int
26592 now return void. Main() now prints success/failure and
26593 errors/warnings message.
26595 Renamed '--probe' compiler argument to '--expect-error'. Removed
26596 the magic number return values (123 and 124). Now, if the
26597 expected error occurs, the compiler exits with success (exit value
26598 0). If the compilation completes without seeing that particular
26599 error, the compiler exits with failure (exit value 1). The
26600 makefile in mcs/errors has been changed to handle the new behaviour.
26602 * report.cs: Made 'expected error' number a property and renamed
26603 it from 'Probe' to 'ExpectedError'.
26605 * genericparser.cs: Removed error handling support, since it is
26606 now all done by Report class.
26608 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26609 class, so parse() no longer returns an int.
26611 * namespace.cs: Use Report.Error instead of GenericParser.error
26613 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26615 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26616 TypeContainer.AddOperator): At the front of the list put the
26617 explicit implementations, so they get resolved/defined first.
26619 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26621 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26622 interface type is implemented by this TypeContainer. Used during
26623 explicit interface implementation.
26625 (Property.Define, Indexer.Define, Method.Define): Validate that
26626 the given interface in the explicit implementation is one of the
26627 base classes for the containing type.
26629 Also if we are explicitly implementing an interface, but there is
26630 no match in the pending implementation table, report an error.
26632 (Property.Define): Only define the property if we are
26633 not explicitly implementing a property from an interface. Use the
26634 correct name also for those properties (the same CSC uses,
26635 although that is really not needed).
26637 (Property.Emit): Do not emit attributes for explicitly implemented
26638 properties, as there is no TypeBuilder.
26640 (Indexer.Emit): ditto.
26642 Hiding then means that we do not really *implement* a pending
26643 implementation, which makes code fail.
26645 2002-06-22 Martin Baulig <martin@gnome.org>
26647 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26648 the return value of Object.GetType(). [FIXME: we need to do this whenever
26649 we get a type back from the reflection library].
26651 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26653 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26655 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26657 * attribute.cs: Return null if we can not look up the type.
26659 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26660 the interface types found.
26662 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26663 interface types found.
26665 * typemanager.cs (GetInterfaces): Make this routine returns alll
26666 the interfaces and work around the lame differences between
26667 System.Type and System.Reflection.Emit.TypeBuilder in the results
26668 result for GetInterfaces.
26670 (ExpandInterfaces): Given an array of interface types, expand and
26671 eliminate repeated ocurrences of an interface. This expands in
26672 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26675 2002-06-21 Martin Baulig <martin@gnome.org>
26677 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26680 2002-06-21 Martin Baulig <martin@gnome.org>
26682 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26683 and called with one of the core types, return the corresponding typebuilder for
26686 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26689 2002-06-21 Martin Baulig <martin@gnome.org>
26691 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26692 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26693 (Expression.ConvertReferenceExplicit): Likewise.
26695 * expression.cs (ElementAccess.DoResolve): Likewise.
26696 (ElementAccess.DoResolveLValue): Likewise.
26698 2002-06-10 Martin Baulig <martin@gnome.org>
26700 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26701 add the "value" parameter to the parameter list.
26703 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26706 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26708 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26709 the argument to an int, uint, long or ulong, per the spec. Also
26710 catch negative constants in array creation.
26712 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26714 * class.cs: do not allow the same interface to appear twice in
26715 the definition list.
26717 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26719 * ecore.cs: don't use ldlen with System.Array.
26721 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26723 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26725 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26727 * modifiers.cs: produce correct field attributes for protected
26728 internal. Easy fix so miguel can work on ther harder stuff:-)
26730 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26732 * pending.cs: New file. Move the code from class.cs here.
26733 Support clearning the pending flag for all methods (when not doing
26734 explicit interface implementation).
26736 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26738 * rootcontext.cs: added a couple more types needed to bootstrap.
26740 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26742 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26743 constructor in the type, instead of any constructor in the type
26744 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26745 a bug in the Mono runtime when applying the params attribute).
26747 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26748 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26750 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26752 * expression.cs (Unary.ResolveOperator): Use TypeManager
26753 to resolve the type.
26755 2002-06-13 Ravi Pratap <ravi@ximian.com>
26757 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26760 * enum.cs (AddEnumMember): Add support to store the attributes associated
26761 with each member too.
26763 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26764 field builders too - this takes care of the enum member case.
26766 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26768 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26769 address-of operator on both value types and pointers.
26771 2002-06-10 Martin Baulig <martin@gnome.org>
26773 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26774 PropertyBuilder to the `property_builders' list.
26776 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26777 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26778 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26779 find any indexers which are inherited from an interface.
26781 2002-06-09 Martin Baulig <martin@gnome.org>
26783 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26784 the same type as the constant if necessary. There's also a test-130.cs
26787 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26789 * typemanager.cs (TypeManager.ChangeType): Previously known as
26790 Enum.ChangeEnumType().
26792 2002-06-09 Martin Baulig <martin@gnome.org>
26794 * expression.cs (Cast.TryReduce): Added support for consts.
26796 2002-06-08 Ravi Pratap <ravi@ximian.com>
26798 * class.cs (Accessor): Hold attributes information so we can pass
26801 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26802 Modify to pass in attributes attached to the methods.
26804 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26806 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26807 to handle the Accessor kind :-)
26809 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26811 2002-06-08 Martin Baulig <martin@gnome.org>
26813 * expression.cs (Unary.TryReduceNegative): Added support for
26816 2002-06-08 Martin Baulig <martin@gnome.org>
26818 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26819 name can't be found in the `defined_names' - the caller will do a
26820 MemberLookup in this case and thus find methods in System.Enum
26821 such as Enum.IsDefined().
26823 2002-06-08 Martin Baulig <martin@gnome.org>
26825 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26826 Convert.ChangeType() which works with TypeBuilder created types.
26827 (Enum.LookupEnumValue, Enum.Define): Use it here.
26829 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26830 `TypeBuilder.BaseType != null' check.
26831 (TypeContainer.FindMembers): Only lookup parent members if we
26832 actually have a parent.
26833 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26834 (ConstructorInitializer.Resolve): Likewise.
26836 * interface.cs (Interface.FindMembers): Added
26837 `TypeBuilder.BaseType != null' check.
26839 * rootcontext.cs (RootContext.ResolveCore): Added
26840 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26841 classes_second_stage.
26843 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26844 debug_type and trace_type when compiling with --nostdlib.
26846 2002-06-07 Martin Baulig <martin@gnome.org>
26848 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26849 (AddField): Set it to true when adding a non-static field.
26850 (DefineType): Use `have_nonstatic_fields' to find out whether we
26851 have non-static fields, not `Fields != null'.
26853 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26855 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26856 dereferencing a null on the static-field code path)
26858 2002-05-30 Martin Baulig <martin@gnome.org>
26860 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26861 to take command line arguments. Use reflection to call the new
26862 custom `Initialize' function on the symbol writer and pass it the
26863 command line arguments.
26865 * driver.cs (--debug-args): New command line argument to pass command
26866 line arguments to the symbol writer.
26868 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26870 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26871 the target type for indexers and properties. Thanks to Joe for
26874 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26876 * typemanager.cs (MethodFlags): returns the method flags
26877 (Obsolete/ShouldIgnore) that control warning emission and whether
26878 the invocation should be made, or ignored.
26880 * expression.cs (Invocation.Emit): Remove previous hack, we should
26881 not do this on matching a base type, we should do this based on an attribute
26883 Only emit calls to System.Diagnostics.Debug and
26884 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26885 on the command line.
26887 * rootcontext.cs: Global settings for tracing and debugging.
26889 * cs-tokenizer.cs (define): New utility function to track
26890 defines. Set the global settings for TRACE and DEBUG if found.
26892 2002-05-25 Ravi Pratap <ravi@ximian.com>
26894 * interface.cs (Populate*): Pass in the TypeContainer as well as
26895 the DeclSpace as parameters so that we can create EmitContexts and
26896 then use that to apply attributes etc.
26898 (PopulateMethod, PopulateEvent, PopulateProperty)
26899 (PopulateIndexer): Apply attributes everywhere.
26901 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26904 (ApplyAttributes): Update accordingly.
26906 We now apply interface attributes for all members too.
26908 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26910 * class.cs (Indexer.Define); Correctly check if we are explicit
26911 implementation (instead of checking the Name for a ".", we
26912 directly look up if the InterfaceType was specified).
26914 Delay the creation of the PropertyBuilder.
26916 Only create the PropertyBuilder if we are not an explicit
26917 interface implementation. This means that explicit interface
26918 implementation members do not participate in regular function
26919 lookups, and hence fixes another major ambiguity problem in
26920 overload resolution (that was the visible effect).
26922 (DefineMethod): Return whether we are doing an interface
26925 * typemanager.cs: Temporary hack until we get attributes in
26926 interfaces (Ravi is working on that) and we get IndexerName
26927 support in interfaces.
26929 * interface.cs: Register the indexers as properties.
26931 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26932 warning, I have verified that this is a bug in the .NET runtime
26933 (JavaScript suffers of the same problem).
26935 * typemanager.cs (MemberLookup): When looking up members for
26936 interfaces, the parent of an interface is the implicit
26937 System.Object (so we succeed in searches of Object methods in an
26938 interface method invocation. Example: IEnumerable x; x.ToString
26941 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26943 * class.cs (Event): Events should also register if they do
26944 implement the methods that an interface requires.
26946 * typemanager.cs (MemberLookup); use the new GetInterfaces
26949 (GetInterfaces): The code used to lookup interfaces for a type is
26950 used in more than one place, factor it here.
26952 * driver.cs: Track the errors at the bottom of the file, we kept
26955 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26956 instance if the method we are calling is static!
26958 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26960 * attribute.cs (ApplyAttributes): Make this function filter out
26961 the IndexerName attribute (as that attribute in reality is never
26962 applied) and return the string constant for the IndexerName
26965 * class.cs (TypeContainer.Emit): Validate that all the indexers
26966 have the same IndexerName attribute, and if so, set the
26967 DefaultName attribute on the class.
26969 * typemanager.cs: The return value might contain other stuff (not
26970 only methods). For instance, consider a method with an "Item"
26971 property and an Item method.
26973 * class.cs: If there is a problem with the parameter types,
26976 2002-05-24 Ravi Pratap <ravi@ximian.com>
26978 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26979 looks at user defined conversion after making a call to
26980 StandardConversionExists - we need this for overload resolution.
26982 * expression.cs : Update accordingly the various method calls.
26984 This fixes 2 bugs filed against implicit user defined conversions
26986 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26988 * statement.cs: Track the result of the assignment.
26990 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26992 * expression.cs (MemberAccess): Improved error reporting for
26993 inaccessible members.
26995 2002-05-22 Martin Baulig <martin@gnome.org>
26997 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26998 itself with debugging support.
27000 2002-05-22 Martin Baulig <martin@gnome.org>
27002 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
27003 Removed, this isn't needed anymore.
27005 2002-05-20 Martin Baulig <martin@gnome.org>
27007 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
27008 be underlying type for an enum.
27010 2002-05-20 Miguel de Icaza <miguel@ximian.com>
27012 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
27013 that splits out the loading of just the core types.
27015 * rootcontext.cs (ResolveCore): Split the struct resolution in
27016 two, so we can load the enumeration underlying types before any
27019 * expression.cs (Is): Bandaid until we fix properly Switch (see
27020 bug #24985 for details).
27022 * typemanager.cs (ImplementsInterface): The hashtable will contain
27023 a null if there are no interfaces implemented.
27025 2002-05-18 Miguel de Icaza <miguel@ximian.com>
27027 * cs-parser.jay (indexer_declarator): It is fine to have array
27030 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27032 * typemanager.cs: (RegisterBuilder): New function used to register
27033 TypeBuilders that implement interfaces. Since
27034 TypeBuilder.GetInterfaces (as usual) does not work with lame
27036 (AddUserType): register interfaces.
27038 (ImplementsInterface): Use the builder_to_ifaces hash if we are
27039 dealing with TypeBuilder. Also, arrays are showing up as
27040 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
27041 methods can not be invoked on them!
27043 * ecore.cs (ExplicitReferenceConversionExists): Made public.
27044 (ImplicitReferenceConversionExists): Split out from
27045 StandardConversionExists.
27047 * expression.cs (As): We were only implementing one of the three
27048 cases for the as operator. We now implement them all.
27049 (Is): Implement the various other cases for Is as well.
27051 * typemanager.cs (CACHE): New define used to control if we want or
27052 not the FindMembers cache. Seems to have a negative impact on
27053 performance currently
27055 (MemberLookup): Nested types have full acess to
27056 enclosing type members
27058 Remove code that coped with instance/static returns for events, we
27059 now catch this in RealFindMembers.
27061 (RealFindMembers): only perform static lookup if the instance
27062 lookup did not return a type or an event.
27064 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27066 * assign.cs (CompoundAssign): We pass more semantic information
27067 now to Compound Assignments than we did before: now we have all
27068 the information at hand, and now we resolve the target *before* we
27069 do the expression expansion, which allows the "CacheValue" method
27070 to have the effect we intended (before, a [x] += 1 would generate
27071 two differen ArrayAccess expressions from the ElementAccess,
27072 during the resolution process).
27074 (CompoundAssign.DoResolve): Resolve target and original_source here.
27076 2002-05-16 Miguel de Icaza <miguel@ximian.com>
27078 * expression.cs (ArrayAccess): dropped debugging information.
27080 * typemanager.cs: Small bug fix: I was always returning i_members,
27081 instead of one of i_members or s_members (depending on which had
27084 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
27085 method is invoked before any code generation takes place, and it
27086 is a mechanism to inform that the expression will be invoked more
27087 than once, and that the method should use temporary values to
27088 avoid having side effects
27090 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
27092 * ecore.cs (Expression.CacheTemporaries): Provide empty default
27095 * expression.cs (Indirection, ArrayAccess): Add support for
27096 CacheTemporaries in these two bad boys.
27098 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
27099 ldobj or ldind_ref.
27100 (StoreFromPtr): Handle stobj as well.
27102 * expression.cs (UnaryMutator): Share more code.
27104 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
27105 down: I was not tracking the Filter function as well, which
27106 was affecting the results of the cache.
27108 2002-05-15 Miguel de Icaza <miguel@ximian.com>
27110 * attribute.cs: Remove the hack to handle the CharSet property on
27113 2002-05-14 Miguel de Icaza <miguel@ximian.com>
27115 * attribute.cs (DoResolve): More uglyness, we now only try to
27116 resolve the attribute partially, to extract the CharSet
27117 information (only if we are a StructLayout attribute). Otherwise
27119 (GetExtraTypeInfo): Add some code to conditionally kill in the
27120 future this. I am more and more convinced that the .NET
27121 framework has special code to handle the attribute setting on
27124 * expression.cs (IsParamsMethodApplicable): Revert my previous
27125 foreach change here, it was wrong.
27127 2002-05-13 Miguel de Icaza <miguel@ximian.com>
27129 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
27130 (pp_expr): do not abort on unknown input, just return.
27131 (eval): abort if there are pending chars.
27133 * attribute.cs (Attribute.Resolve): Positional parameters are
27134 optional. Deal with that case.
27136 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
27137 the Ansi/Unicode/Auto information for the type.
27139 (TypeContainer.DefineType): instantiate the EmitContext here, as
27140 we will be using it during the type definition (to resolve
27141 attributes) and during the emit phase.
27143 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
27144 to pull type information out of the attributes
27146 (Attribute.Resolve): track the constructor builder, and allow for
27147 multiple invocations (structs and classes will use this).
27149 * ecore.cs (MemberLookupFinal): new version with all the
27150 parameters customizable.
27152 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
27153 constructors. Return if the result value is null (as the error
27154 would have been flagged already by MemberLookupFinal)
27156 Do not allow instances of abstract classes or interfaces to be
27159 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
27160 We have to compare the assembly property here when dealing with
27161 FamANDAssem and Assembly access modifiers, because we might be
27162 creating an assembly from *modules* (that means that we are not
27163 getting TypeBuilders for types defined in other modules that are
27164 part of this assembly).
27166 (Method.Emit): If the method is marked abstract and has a body,
27169 (TypeContainer.DefineMembers): If both the defined member and the
27170 parent name match are methods, then do not emit any warnings: let
27171 the Method.Define routine take care of flagging warnings. But if
27172 there is a mismatch (method overrides something else, or method is
27173 overriwritten by something, then emit warning).
27175 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
27176 set to null, this means `do not check for the return type on the
27179 (Method.Define): set the return type for the method signature to
27180 null, so that we get methods with the same name and parameters and
27181 different return types. This is used to flag warning 114 (you are
27182 hiding a method, and you probably want to use the new/override
27185 * typemanager.cs (MemberLookup): Implemented proper access
27186 control, closing a long standing set of bug reports. The problem
27187 was that the Framework only has two bits: Public and NonPublic,
27188 and NonPublic includes private and protected methods, but we need
27189 to enforce the FamANDAssem, FamOrAssem and Family.
27191 2002-05-11 Miguel de Icaza <miguel@ximian.com>
27193 * statement.cs (GotoCase): Return true: Ammounts to giving up
27194 knowledge on whether we return or not, and letting the other case
27195 be responsible for it.
27197 2002-05-10 Miguel de Icaza <miguel@ximian.com>
27199 * driver.cs: Do not load directories for each file processed, only
27200 do it if there is a pattern.
27202 * ecore.cs: Report readonly assigns here as well, as we might have
27203 been resolved only by MemberAccess.
27205 (SimpleName.SimpleNameResolve): Also be useful for LValue
27206 resolution. We need this to propagate assign to local readonly variables
27208 * typemanager.cs: Use a ptrhashtable for the criteria, because we
27209 do not want to reuse potential criteria memory.
27211 * class.cs (MyEventBuilder): Set reflected_type;
27213 * ecore.cs (Constantify): Added support for constifying bools.
27215 (RootContext.LookupType): Added a cache for values looked up in
27216 the declaration space.
27218 * typemanager.cs (FindMembers): Now is a front-end to
27219 RealFindMembers, and provides a two-level hashtable-based cache to
27222 15% performance improvement: from 22.5 to 19.2 seconds.
27224 * expression.cs (IsParamsMethodApplicable): use foreach.
27225 (Invocation.DoResolve): ditto.
27226 (New.DoResolve): ditto.
27227 (ArrayCreation.DoResolve): ditto.
27229 * ecore.cs (FindMostEncompassingType): use foreach.
27231 * delegate.cs (NewDelegate.DoResolve): Use foreach
27233 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27234 (RemoveMethods): use foreach.
27236 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27237 nested foreach statements instead of for, and also break out of
27238 the inner loop once a match is found.
27240 (Invocation.OverloadResolve): Use foreach, simplify the code.
27242 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27244 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27245 we actually unwrap the expression to allow for extra information
27248 * expression.cs: Use Shr_Un on unsigned operations.
27250 2002-05-08 Ravi Pratap <ravi@ximian.com>
27252 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27253 applicable operators was not being considered correctly. This closes
27254 the bug Miguel reported.
27256 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27258 * attribute.cs: check that the type derives from System.Attribute
27259 and report the correct error in that case (moved the duplicate code to
27260 its own method, too).
27262 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27264 * attribute.cs: lookup attribute type name as the spec says: first the
27265 bare attribute name and then name + "Attribute" (nant compiles with
27266 mcs after this fix).
27268 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27270 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27271 Because of the way we parse things, we should try to see if a
27272 UIntConstant can fit in an integer.
27274 2002-05-07 Ravi Pratap <ravi@ximian.com>
27276 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27277 when we are in an explicit context.
27279 (ConvertReferenceExplicit): When converting from Iface type S to Class
27280 T make sure the rules are implemented as an OR.
27282 * parameter.cs (ParameterType): Make it a property for now although the
27283 purpose really isn't anything immediate.
27285 * expression.cs (Is*Applicable): Do better checking on the parameter type
27286 of a ref/out parameter. The ones from the system assemblies are already
27287 marked with the correct type so we don't need to do any correction.
27289 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27290 the object type is standard too so include that.
27292 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27294 * ecore.cs (StandardConversionExists): Augment with missing code:
27295 deal with IntConstant, LongConstants and Enumerations.
27297 * assign.cs: Report the error, instead of failing silently
27299 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27300 typecontainer that they are declared, because the
27301 typecontainer/namespace will have the list of using clauses that
27302 need to be applied.
27304 Assembly Attributes were escaping the normal registration
27307 (EmitCode): Apply attributes within an EmitContext that represents
27308 the container they were declared on.
27310 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27312 2002-05-06 Ravi Pratap <ravi@ximian.com>
27314 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27315 Revamp completely - make much cleaner as we now operate only
27318 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27319 to implement the logic detailed in the spec more correctly.
27321 (UserDefinedConversion): Update accordingly.
27323 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27325 * statement.cs: Return flow analysis information up.
27327 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27330 (token): Do not consume an extra character before calling
27333 2002-05-06 Piers Haken <piersh@friskit.com>
27335 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27337 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27339 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27340 EmitContext during the instance constructor initializer
27341 resolution, to stop access to instance variables.
27343 This is mandated by the spec, last paragraph of the `constructor
27344 initializers' section.
27346 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27348 * cs-parser.jay, class.cs (Accessor): new class used to represent
27349 an accessor (get or set). In the past we used `null' to represent
27350 a missing accessor. But this is ambiguous because there was no
27351 way to tell in abstract indexers/properties if one of them was
27354 Now there is a way of addressing that.
27356 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27357 instead of FindMembers.
27359 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27360 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27362 * attribute.cs: Treat indexers and properties as the same in terms
27363 of applying attributes
27365 * ecore.cs (FindMostEncompassedType): Use statically initialized
27366 EmptyExpressions()s like we do elsewhere to avoid creating useless
27367 objects (and we take this out of the tight loop).
27369 (GetConversionOperators): Move the code to extract the actual
27370 operators to a separate routine to clean things up.
27372 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27374 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27375 events are always registered FieldBuilders.
27377 * class.cs (FieldBase): New class shared by Fields
27379 * delegate.cs: If we are a toplevel delegate, use our full name.
27380 If we are a nested delegate, then only use our tail name.
27382 2002-05-02 Ravi Pratap <ravi@ximian.com>
27384 * expression.cs (IsApplicable): Ensure that we add the "&" to
27385 ref/out types before comparing it with the type of the argument.
27387 (IsParamsMethodApplicable): Ditto.
27389 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27392 * delegate.cs : Handle the case when we have more than one applicable
27393 method. Flag an error only when we finish checking all.
27395 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27397 * expression.cs: Add support for boolean static initializers.
27399 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27401 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27403 * parameter.cs (ComputeParameterTypes,
27404 ComputeAndDefineParameterTypes): Better error handling: now we
27405 clear the `types' cache if we fail during any of the type lookups.
27406 We also return the status code correctly to our caller
27408 * delegate.cs: If we fail to define a delegate, abort the extra
27411 * expression.cs (Binary.ResolveOperator): for
27412 operator==(object,object) and operator !=(object, object) we also
27413 have to verify that there is an implicit conversion from one to
27416 (ArrayAccess.DoResolve): Array Access can operate on
27419 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27421 * assign.cs (CompoundAssign): A new class used as a "flag" that
27422 the assignment actually is happening as part of a compound
27423 assignment operator.
27425 During compound assignment, a few new rules exist to enable things
27432 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27433 to the type of x) if y is implicitly convertible to the type of x,
27434 and the operator is a builtin operator and the return type of the
27435 operator is explicitly convertible to the type of x.
27437 * rootcontext.cs: Reset warning level to 2. 4 catches various
27438 "interesting" features in mcs, we must clean this up at some
27439 point, but currently am trying to kill other bugs ;-)
27441 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27442 in container classes as well.
27444 * expression.cs (Binary.ResolveOperator): Handle string case
27445 before anything else (as operator overloading does emit an error
27446 before doing anything else).
27448 This code could go away when we move to a table driven model, but
27449 i could not come up with a good plan last night.
27451 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27453 * typemanager.cs (CSharpName): reimplementation using regex.
27454 * class.cs: added null check for fields in Emit
27455 * rootcontext.cs: set warninglevel to 4
27457 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27459 * typemanager.cs (CSharpName): reimplemented with Lupus
27462 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27464 * statement.cs (If): correclty implement Resolve, because we were
27465 not catching sem errors in there. The same process is needed
27467 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27470 (Statement.Warning_DeadCodeFound): Factorize code.
27471 (While): Report dead code here too.
27473 (Statement): Added Resolve virtual method to allow
27474 for resolution split from the emit code.
27476 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27478 * statement.cs (EmitBoolExpression): No longer try to resolve the
27480 (MakeBoolean): New utility function that resolve, implicitly
27481 converts to boolean and tags the expression.
27484 (If, Do): Implement dead code elimination.
27485 (While): Implement loop inversion
27487 (Do, While, For, If): Resolve the expression prior to calling our
27490 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27493 - added method Report28 (warning: program has more than one entry point)
27494 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27495 - modified method Method.Define, the part at the end of the method
27497 * rootcontext.cs: added static public Location EntryPointLocation;
27499 * ../errors/cs0028.cs : Add test case for the above warning.
27502 - modified method CSharpName to allow arrays of primitive type to
27503 be printed nicely (e.g. instead of System.Int32[][] it now prints
27505 - added method CSharpSignature: returns the signature of a method
27506 in string format to be used in reporting errors, warnings, etc.
27508 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27511 2002-04-26 Ravi Pratap <ravi@ximian.com>
27513 * delegate.cs (Define): Fix extremely silly bug where I was
27514 setting the type of the 'object' parameter of the BeginInvoke
27515 method to System.IAsyncResult instead of System.Object ;-)
27517 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27519 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27522 (Constructor.Emit): return if we fail to initialize the
27523 constructor. Another door closed!
27525 * expression.cs (New.DoResolve): Improve error message (from -6 to
27526 1501). Use DeclaredOnly lookup to find the exact constructor.
27528 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27529 loop. This is useful.
27531 * cs-parser.jay: Adjust the default parameters so that destructors
27532 have the proper signature.
27534 2002-04-26 Martin Baulig <martin@gnome.org>
27536 * driver.cs (LoadAssembly): If `assembly' contains any characters
27537 which are only valid in path names and not in assembly names
27538 (currently slash, backslash and point), use Assembly.LoadFrom ()
27539 instead of Assembly.Load () on the `assembly' (before iteration
27540 over the link_paths).
27542 2002-04-26 Martin Baulig <martin@gnome.org>
27544 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27546 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27548 * class.cs (Property): use the new typemanager.MemberLookup
27550 (TypeContainer.MemberLookup): Implement using the
27551 TypeManager.MemberLookup now.
27553 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27554 and return MemberInfos, so that these can be used without an
27555 EmitContext (what we had before).
27557 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27559 * expression.cs: Fix the case where the argument to params if the
27560 type of the params. I omitted handling this before. Fixed
27562 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27564 * driver.cs: Call BootCorlib_PopulateCoreType
27566 * class.cs (Property.CheckBase): Check for properties only, not
27569 * interface.cs: Temporary hack: try/catch around the
27570 CustomAttributeBuilder, because I am getting an exception that I
27573 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27574 types whose definitions are required to be there (attributes are
27575 defined before standard types).
27577 Compute definitions as we boot the various types, as they are used
27578 immediately (value_type class will need object_type, but if we do
27579 not initialize object_type, we will pass a null, which will let
27580 the runtime pick the System.Object from the existing corlib, which
27581 is not what we want).
27583 2002-04-22 Patrik Torstensson <totte@labs2.com>
27585 * cs-tokenizer.cs: fixed a number of trim() issues.
27587 2002-04-22 Ravi Pratap <ravi@ximian.com>
27589 * expression.cs (Argument.Type): Ensure that we return the correct
27590 type when we have out or ref parameters [in which case we
27593 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27595 * class.cs (Property, Indexer): Allow extern modifier in there.
27597 * typemanager.cs (InitBaseTypes): Initializes object_type and
27598 value_type, since those will be used early on during the bootstrap
27599 process to compile corlib.
27601 (InitCoreTypes): Move code from here to InitBaseTypes.
27603 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27605 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27606 single-dimension arrays as using the ldlen opcode.
27608 Daniel Lewis discovered this optimization.
27610 * typemanager.cs: Add signature for System.Array::get_Length
27612 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27614 * statement.cs: report the error when the foreach does not apply to an
27615 array nor a collection.
27617 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27619 * expression.cs: Add implicit conversions to the operator ~.
27621 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27623 * typemanager.cs: Locate the decimal constructor.
27625 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27627 * attribute.cs: use the new property of TypeOf.
27628 * expression.cs: added 'get' property around typearg.
27630 These changes fix a build breaker reported by NickD. Is this the
27631 correct way to fix? If not, please, revert my changes and make it
27634 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27636 * attribute.cs: Add support for typeof in attribute invocations.
27637 I am not sure that this is right though.
27639 2002-04-14 Duncan Mak <duncan@ximian.com>
27641 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27642 Binary.Operator.Division case.
27644 2002-04-13 Ravi Pratap <ravi@ximian.com>
27646 * class.cs (DefineType): Ensure that we do a proper check on
27647 attribute types and also register it with the TypeManager.
27649 (TypeContainer.Targets): The default for attribute types is
27650 AttributeTargets.All.
27652 * attribute.cs (ApplyAttributes): Registering the attribute type
27653 is done elsewhere, not when we discover we have a Usage attribute.
27655 2002-04-12 Ravi Pratap <ravi@ximian.com>
27657 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27658 and get rid of is_delegate parameter.
27660 * everywhere : update.
27662 2002-04-12 Ravi Pratap <ravi@ximian.com>
27664 * cs-parser.jay (compilation_unit): Revamp completely to use
27665 some new ideas that I got from Rhys' grammar to solve the problems
27666 with assembly level attributes.
27668 (outer_declaration): New grammar production.
27670 (attribute_sections): Add.
27672 (opt_attributes): Base on attribute_sections
27674 (namespace_declaration): Allow opt_attributes to tackle the case
27675 when we have assembly level attributes - we are clever in this
27678 * attribute.cs (ApplyAttributes): Do not worry about assembly
27679 attributes in the non-global context.
27681 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27682 instead of SetGlobalAttributes.
27684 * class.cs, rootcontext.cs : Ensure we define and generate
27685 attribute types before anything else.
27687 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27688 and flag the new error -20 for the case when the attribute type
27689 does not have valid targets specified. csc does not catch this.
27691 * ../errors/errors.txt : update for error # -20
27693 2002-04-11 Ravi Pratap <ravi@ximian.com>
27695 * support.cs (InternalParameters.ParameterModifier): Do some null
27696 checking and return sane values.
27698 * class.cs (Method.Define): If we are a PInvoke method, ensure
27699 that we are static and extern. Report error # 601
27701 * ../errors/cs0601.cs : Add test case for the above error.
27703 2002-04-07 Ravi Pratap <ravi@ximian.com>
27705 * rootcontext.cs (attribute_types): We need to keep type of
27706 all attribute types separately and emit code for them first.
27708 (RegisterAttribute) : Implement.
27710 * class.cs (DefineType): Check if the current Type is a custom
27711 attribute type and register it accordingly.
27713 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27714 adding the first attribute twice and rename to
27716 (SetGlobalAttributes): this.
27718 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27721 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27722 if we are processing global arguments. Hmm, I am unsure of this.
27724 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27726 * expression.cs: added static array of strings to avoid calling
27727 Enum.ToString () for Operator in Binary. Significant recover of
27730 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27732 * class.cs (FindMembers): Allow the Builders of the various
27733 members to be null. If they are skip them. This only happens
27734 during the PInvoke declaration.
27736 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27738 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27739 failure, so we do not keep going afterwards.
27741 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27742 wanted to pass `false' as the `is_delegate' argument. If this is
27743 the case, why not use delegate_type == null to mean `is_delegate =
27744 false' and anything else as is_delegate = true.
27746 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27748 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27749 code for the section, not the beginning of the tests.
27751 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27753 * cfold.cs: Handle operator + (Enum x, Underlying x)
27755 * expression.cs (Binary): same. Warn about errors where we have
27756 Enum/Enum in operator + as well.
27758 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27761 - added support for switch(bool)
27762 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27763 - add TableSwitchEmit() to handle table-based switch statements
27765 2002-04-05 Ravi Pratap <ravi@ximian.com>
27767 * expression.cs (Invocation.OverloadResolve): Factor out code which
27768 does parameter compatibility checking with arguments so that we can
27769 re-use the code even from Delegate.VerifyApplicability
27771 (VerifyArgumentsCompat): Move above code here.
27773 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27774 and instead make a call to the above method.
27776 2002-03-31 Ravi Pratap <ravi@ximian.com>
27778 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27779 We use it to keep track of classes which are attribute types.
27781 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27783 * delegate.cs (Delegate.Define): Correctly define the types in the
27784 presence of fixed and array parameters.
27786 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27789 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27790 include NonPublic after the first iteration.
27792 * class.cs (Indexer.CheckBase): Only check if both parents are
27795 * cs-parser.jay (accessor_body): If empty, set to null.
27797 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27798 same code path here to resolve constants names that we did have in
27799 MemberAccess.DoResolve. There is too much code duplicated here.
27801 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27803 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27805 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27808 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27809 tokens, numbers and strings.
27811 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27814 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27815 asyncronous parameters and the regular parameters.
27817 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27818 specify the target directory.
27820 * expression.cs: (This.DoResolve): Simplify
27821 (As.Emit): Optimize, do not generate IsInst if the expression is
27822 always of the given type.
27824 (Is.DoResolve): Bug fix, we were reporting both always/never for
27827 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27828 creating too many unnecessary arrays.
27830 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27832 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27833 fields instead of rolling our own initializer. Takes care of all
27834 implicit conversions, and drops unnecessary static checks/argument.
27836 2002-03-31 Dick Porter <dick@ximian.com>
27838 * driver.cs: use the GetDirectories() return values properly, and
27839 use "/" as path separator.
27841 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27843 * expression.cs (Unary): Optimize - - expr into expr.
27844 (Binary): Optimize a + (-b) into a -b.
27846 * codegen.cs (CodeGen): Made all methods static.
27848 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27852 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27853 TypeBuilder property.
27855 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27858 * tree.cs: Removed the various RecordXXXX, and replaced with a
27859 single RecordDecl. Removed all the accessor methods, and just
27860 left a single access point Type
27862 * enum.cs: Rename DefineEnum to DefineType.
27864 * decl.cs: New abstract method `DefineType' used to unify the
27865 Defines for Enumerations, Interfaces, TypeContainers and
27868 (FindType): Moved LookupInterfaceOrClass here. Moved the
27869 LookupBaseClasses method that used to live in class.cs and
27870 interface.cs here, and renamed to FindType.
27872 * delegate.cs: Implement DefineType. Take advantage of the
27873 refactored pattern for locating the parent builder without taking
27874 the parent_builder argument (which we know does not work if we are
27875 nested, and triggering a toplevel definition).
27877 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27879 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27880 accessibility of a member has changed during override and report
27883 * class.cs (Method.Define, Property.Define): Only complain on
27884 overrides if the method is private, any other accessibility is
27885 fine (and since we just checked the permission is the same, we are
27888 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27889 and elif are processed always. The other pre-processing
27890 directives are only processed if we are "taking" the path
27892 2002-03-29 Martin Baulig <martin@gnome.org>
27894 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27895 current location is not Null.
27897 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27898 a separate method so we can profile it.
27900 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27901 `span.Seconds' are just seconds, but no minutes or hours.
27902 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27904 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27906 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27907 Remove the gratuitous set of Final:
27909 // If an interface implementation, then we can set Final.
27910 if (((flags & MethodAttributes.Abstract) == 0) &&
27911 implementing.DeclaringType.IsInterface)
27912 flags |= MethodAttributes.Final;
27914 I do not know what I was smoking when I used that.
27917 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27918 step into fixing the name resolution issues for delegates and
27919 unifying the toplevel name resolution.
27921 2002-03-28 Martin Baulig <martin@gnome.org>
27923 * class.cs (Method.Emit): If we have a symbol writer, call its
27924 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27925 tell it about the current method.
27927 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27928 writer that we're going to emit the first byte of IL code for a new
27929 statement (a new source line).
27930 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27931 EmitContext.Mark() before emitting any code.
27933 * location.cs (SymbolDocument): Return null when we're Null.
27935 * statement.cs (Statement): Moved the `Location loc' variable here.
27936 (Statement.EmitBoolExpression): If we have a symbol writer, call
27937 ec.Mark() before emitting any code to tell it that we're at the
27938 beginning of a new statement.
27939 (StatementExpression): Added `Location' argument to the constructor.
27940 (Block): Added public readonly variable `StartLocation' and public
27941 variable `EndLocation'. The latter is to be set using SetEndLocation().
27942 (Block): Added constructor which takes a start and end location.
27943 (Block.SetEndLocation): New method. This sets the end location.
27944 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27945 local variables we create.
27946 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27947 each statement and do also mark the begin and end of the block.
27949 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27950 tell it the current lexer.Location, use Location.Null for the end of the
27952 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27953 current block, set its end location using SetEndLocation().
27954 (statement_expression): StatementExpression constructor now takes the
27955 lexer.Location as additional argument.
27956 (for_statement, declare_local_variables): Likewise.
27957 (declare_local_variables): When creating a new implicit block, use the
27958 new Block constructor and pass it the lexer.Location.
27960 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27962 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27963 members also on the parent interfaces recursively.
27965 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27967 * report.cs: Use new formats, since Gonzalo finished the missing
27970 * expression.cs (Binary.ResolveOperator): added missing operator|
27971 operator& and operator^ for bool/bool.
27973 * cs-parser.jay: CheckDef now takes a Location argument that is
27974 used to report errors more precisly (instead of reporting the end
27975 of a definition, we try to track something which is a lot closer
27976 to the source of the problem).
27978 * cs-tokenizer.cs: Track global token use, so we can properly flag
27979 the use of #define/#undef after the first token has been seen.
27981 Also, rename the reportXXXX to Error_DescriptiveName
27983 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27984 TypeContainer, so that Enum and Interface can use this too.
27986 * class.cs (TypeContainer.LookupInterfaceOrClass,
27987 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27988 `builder' argument. Typically this was used to pass the parent
27989 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27992 The problem is that a nested class could trigger the definition of
27993 a toplevel class, and the builder would be obviously wrong in that
27996 So we drop this argument, and we compute dynamically the
27997 TypeBuilder/ModuleBuilder (the correct information was available
27998 to us anyways from DeclSpace.Parent)
28000 * interface.cs (Interface.DefineInterface): Drop builder
28001 parameter cleanup like class.cs
28003 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
28006 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
28009 (Try.Emit): Propagate the returns value from the statement.
28011 (Return.Emit): Even if we are leavning
28013 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
28015 * modifiers.cs: Fix the computation of MethodAttributes flags.
28017 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
28019 * driver.cs: allow compilation of files that start with '/'.
28020 Add a default case when checking the argument of --target.
28022 2002-03-25 Miguel de Icaza <miguel@ximian.com>
28024 * interface.cs: Implement the same search algorithm for types in
28025 the interface code.
28027 * delegate.cs: Do not allow multiple definition.
28029 * Recovered ChangeLog that got accidentally amputated
28031 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
28033 * rootcontext.cs: Load manually enum to allow core classes to
28034 contain enumerations.
28036 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
28037 Update to new static methods in TypeManager.
28039 * typemanager.cs (GetMethod, GetConstructor): Use our
28040 implementation of FindMembers to find the members, since during
28041 corlib compilation, the types are TypeBuilders and GetMethod and
28042 GetConstructor do not work.
28044 Make all methods in TypeManager static.
28046 (InitCodeHelpers): Split the functionality from
28047 the InitCodeTypes function.
28049 * driver.cs: Call InitCodeHelpers after we have populated the
28052 * cs-parser.jay (delegate_declaration): we did not used to compute
28053 the delegate name correctly for void delegates.
28055 2002-03-24 Miguel de Icaza <miguel@ximian.com>
28057 * rootcontext.cs (RootContext): Init the interface_resolve_order
28058 and type_container_resolve_order always.
28060 (ResolveCore, BootstrapCorlib_ResolveClass,
28061 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
28062 compiler when compiling with --nostdlib
28064 * class.cs (TypeContainer.DefineType): Check that our parent is
28065 not null. This test is most important when we are bootstraping
28068 * codegen.cs: Split out the symbol writing code.
28070 2002-03-25 Martin Baulig <martin@gnome.org>
28072 * driver.cs (-g): Made -g an alias for --debug.
28074 2002-03-24 Martin Baulig <martin@gnome.org>
28076 * codegen.cs (SymbolWriter): New public variable. Returns the
28077 current symbol writer.
28078 (CodeGen): Added `bool want_debugging_support' argument to the
28079 constructor. If true, tell the ModuleBuild that we want debugging
28080 support and ask it for the ISymbolWriter.
28081 (Save): If we have a symbol writer, call it's Close() method after
28082 saving the assembly.
28084 * driver.c (--debug): New command line argument to create a
28085 debugger information file.
28087 * location.cs (SymbolDocument): New public property. Returns an
28088 ISymbolDocumentWriter object for the current source file or null
28089 if we don't have a symbol writer.
28091 2002-03-21 Miguel de Icaza <miguel@ximian.com>
28093 * driver.cs (LoadAssembly): Correctly return when all the paths
28094 have been tried and not before.
28096 * statement.cs (Switch.Emit): return the actual coverage for this
28097 statement (returns/not-returns)
28099 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
28100 switch of the statement if we are the last switch section. That
28101 kills two problems: try/catch problems (we used to emit an empty
28102 nop at the end) and switch statements where all branches would
28105 2002-03-19 Miguel de Icaza <miguel@ximian.com>
28107 * driver.cs: Add default assemblies (the equivalent to the
28108 Microsoft CSC.RSP file)
28110 * cs-tokenizer.cs: When updating `cols and setting it to zero,
28111 also update tokens_seen and set it to false.
28113 * driver.cs: Implement --recurse for Mike.
28115 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
28116 correctly splitting out the paths.
28118 2002-03-18 Miguel de Icaza <miguel@ximian.com>
28120 * interface.cs (Interface.PopulateProperty): Instead of using
28121 `parent' as the declaration space for the set parameters, use
28124 * support.cs (InternalParameters): InternalParameters constructor
28125 takes a DeclSpace instead of a TypeContainer.
28127 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
28128 types are being initialized, load the address of it before calling
28131 (New): Provide a mechanism to disable the generation of local
28132 value type temporaries when the caller will be providing us with
28133 an address to store it.
28135 (ArrayCreation.EmitDynamicInitializers): Use it.
28137 2002-03-17 Miguel de Icaza <miguel@ximian.com>
28139 * expression.cs (Invocation.EmitArguments): Only probe for array
28140 property if there is more than one argument. Sorry about that.
28142 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
28143 empty param arrays.
28145 * class.cs (Method.LabelParameters): Fix incorrect code path that
28146 prevented the `ParamArrayAttribute' from being applied to the
28149 2002-03-16 Miguel de Icaza <miguel@ximian.com>
28151 * support.cs (ReflectionParameters): Correctly compute whether the
28152 last argument is a params array. Fixes the problem with
28155 * typemanager.cs: Make the assemblies array always be non-null
28156 (empty, but non-null)
28158 * tree.cs (RecordDecl): New function that abstracts the recording
28159 of names. This reports error 101, and provides a pointer to the
28160 previous declaration. Fixes a crash in the compiler.
28162 * cs-parser.jay (constructor_declaration): Update to new grammar,
28163 and provide a constructor_body that can be empty.
28165 2002-03-15 Miguel de Icaza <miguel@ximian.com>
28167 * driver.cs: Add support for --resources.
28169 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
28170 Make all types for the various array helper methods be integer.
28172 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
28173 CheckState to ConvCast.
28175 (ConvCast): Now it takes a `checked' state argument, to avoid
28176 depending on the emit context for the conversion, and just using
28177 the resolve time setting.
28179 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
28180 instead of Invocation.EmitArguments. We do not emit the original
28181 arguments, instead we emit those which have been converted to
28182 unsigned int expressions.
28184 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
28186 * codegen.cs: ditto.
28188 * expression.cs (LocalVariableReference): Drop the use of the
28189 Store function that depended on the variable index.
28191 * statement.cs (VariableInfo): Drop the `Idx' property from this
28192 class, as this is not taking into account the indexes for
28193 temporaries tat we generate during the execution, getting the
28196 * class.cs: First emit class initializers, then call the parent
28199 * expression.cs (Binary): Fix opcode emision.
28200 (UnaryMutator.EmitCode): Support checked code generation
28202 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
28203 matches for events for both the Static and Instance scans,
28204 pointing to the same element. Fix that.
28206 2002-03-14 Miguel de Icaza <miguel@ximian.com>
28208 * rootcontext.cs (ResolveTree): Always set the
28209 interface_resolve_order, because nested interfaces will be calling
28212 * class.cs (GetInterfaceOrClass): Track the same resolution
28213 process used by TypeManager.LookupType. This fixes the nested
28214 type lookups in class declarations (separate path from
28217 (TypeContainer.DefineType): Also define nested interfaces.
28218 (TypeContainer.RegisterOrder): New public function used to
28219 register the order in which child interfaces need to be closed.
28221 Nested interfaces need to be closed after their parents have been
28224 * interface.cs (InterfaceAttr): Put all the logic for computing
28225 the interface attribute here.
28227 (DefineInterface): Register our interface order with the
28228 RootContext or with the TypeContainer depending on the case.
28230 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28232 * cs-parser.jay: rework foreach statement to work with the new
28233 changes to the policy on SimpleNames.
28235 * report.cs: support Stacktrace on warnings as well.
28237 * makefile: drop --unsafe and /unsafe from the compile.
28239 2002-03-13 Ravi Pratap <ravi@ximian.com>
28241 * ecore.cs (StandardConversionExists): Modify to take an Expression
28242 as the first parameter. Ensure we do null -> reference type conversion
28245 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28246 temporary Expression objects.
28248 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28250 * interface.cs: workaround bug in method overloading resolution
28251 (there is already a bugzilla bug for it).
28253 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28255 We could also solve this problem by having a separate path for
28256 performing type lookups, instead of DoResolve, we could have a
28257 ResolveType entry point, and only participating pieces of the
28258 production (simplename, deref, array) would implement this.
28260 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28261 signal SimpleName to only resolve type names and not attempt to
28262 resolve anything else.
28264 * expression.cs (Cast): Set the flag.
28266 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28268 * class.cs: Only report 108 if there is no `new' modifier.
28270 * cs-parser.jay: rework foreach statement to work with the new
28271 changes to the policy on SimpleNames.
28273 * report.cs: support Stacktrace on warnings as well.
28275 * makefile: drop --unsafe and /unsafe from the compile.
28277 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28279 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28280 lookups here, instead of doing that at parse time. This means
28281 that our grammar will not introduce `LocalVariableReferences' as
28282 expressions at this point. That solves the problem of code like
28286 static void Main ()
28290 This is only half the fix. The full fix requires parameters to
28291 also be handled in this way.
28293 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28294 makes the use more obvious of the DeclSpace. The
28295 ec.TypeContainer.TypeBuilder is now only used to pull the
28296 TypeBuilder for it.
28298 My theory is that I can get rid of the TypeBuilder completely from
28299 the EmitContext, and have typecasts where it is used (from
28300 DeclSpace to where it matters).
28302 The only pending problem is that the code that implements Aliases
28303 is on TypeContainer, and probably should go in DeclSpace.
28305 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28306 lookups here, instead of doing that at parse time. This means
28307 that our grammar will not introduce `LocalVariableReferences' as
28308 expressions at this point. That solves the problem of code like
28312 static void Main ()
28316 This is only half the fix. The full fix requires parameters to
28317 also be handled in this way.
28319 * class.cs (Property.DefineMethod): When implementing an interface
28320 method, set newslot, when implementing an abstract method, do not
28321 set the flag (before we tried never setting it, or always setting
28322 it, which is the difference).
28323 (Indexer.DefineMethod): same.
28324 (Method.DefineMethod): same.
28326 * ecore.cs: Only set the status used flag if we get back a Field.
28328 * attribute.cs: Temporary hack, so Paolo can keep working.
28330 2002-03-08 Ravi Pratap <ravi@ximian.com>
28332 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28333 the unmanaged type in the case we have a MarshalAs attribute.
28335 (Resolve): Handle the case when we are parsing the special MarshalAs
28336 attribute [we need to store the unmanaged type to use later]
28338 * typemanager.cs (marshal_as_attr_type): Built in type for the
28339 MarshalAs Attribute.
28341 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28342 on parameters and accordingly set the marshalling info.
28344 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28346 * class.cs: Optimizing slightly by removing redundant code after
28347 we switched to the `NoTypes' return value.
28348 (Property.DefineMethod): use NoTypes here too.
28350 This fixes the bug I introduced in my last batch of changes.
28352 2002-03-05 Ravi Pratap <ravi@ximian.com>
28354 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28356 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28357 Enums since those are types too.
28359 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28361 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28362 thanks to a call during the lookup process.
28364 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28366 * statement.cs (Foreach): Lots of work to accomodate a particular
28367 kind of foreach statement that I had not kept in mind. It is
28368 possible to have foreachs on classes that provide a GetEnumerator
28369 method that return objects that implement the "pattern" for using
28370 a foreach, there is no need to support GetEnumerator
28373 This is needed to compile nant.
28375 * decl.cs: Only report 114 if the member is not `Finalize' and if
28376 the warning level is at least 2.
28378 * class.cs: Moved the compare function from Method to
28381 (MethodSignature.InheritableMemberSignatureCompare): Add new
28382 filter function that is used to extract inheritable methods from a
28385 (Method.Define): Use the new `inheritable_method_signature_filter'
28388 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28391 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28393 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28395 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28397 * expression.cs: Pass location information to
28398 ConvertImplicitStandard.
28400 * class.cs: Added debugging code to track return values from
28403 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28405 * expression.cs (Is.DoResolve): If either side of the `is' is an
28406 interface, do not flag the warning.
28408 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28411 * report.cs: Allow for --fatal to be used with --probe.
28413 * typemanager.cs (NoTypes): Move the definition for the empty Type
28416 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28418 (TypeContainer.DefineProxy): New function used to proxy to parent
28419 implementations when implementing interfaces.
28420 (TypeContainer.ParentImplements): used to lookup if our parent
28421 implements a public function that is required by an interface.
28422 (TypeContainer.VerifyPendingMethods): Hook this up.
28424 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28425 `modules' and `assemblies' arraylists into arrays. We only grow
28426 these are the very early start up of the program, so this improves
28427 the speedof LookupType (nicely measured).
28429 * expression.cs (MakeByteBlob): Replaced unsafe code with
28430 BitConverter, as suggested by Paolo.
28432 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28433 folding of string concatenation, but if either side is a string,
28434 and the other is not, then return null, and let the runtime use
28435 the concatenation on the string plus the object (using
28436 `Object.ToString').
28438 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28440 Constant Folding has been implemented now.
28442 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28443 the error instead on types that are not supported in one's
28446 * constant.cs (Constant and all children): New set of functions to
28447 perform implict and explicit conversions.
28449 * ecore.cs (EnumConstant): Implement the new functions to perform
28450 conversion by proxying to the child expression.
28452 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28453 own separate setting that can not be turned off from the command
28454 line using --unchecked or --checked and is only controlled using
28455 the checked/unchecked statements and expressions. This setting is
28456 used by the constant folder to flag errors.
28458 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28459 ConstantCheckState as well.
28461 During Resolve, they also have to flag the state, because the
28462 constant folder runs completely in the Resolve phase.
28464 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28467 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28469 * cfold.cs: New file, this file contains the constant folder.
28471 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28472 argument to track whether we are using the resulting address to
28473 load or store a value and provide better error messages.
28475 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28476 new AddressOf arguments.
28478 * statement.cs (Foreach.EmitCollectionForeach): Update
28480 * expression.cs (Argument.Emit): Call AddressOf with proper
28481 arguments to track usage.
28483 (New.DoEmit): Call AddressOf with new arguments.
28485 (Unary.Emit): Adjust AddressOf call.
28487 2002-03-01 Ravi Pratap <ravi@ximian.com>
28489 * cs-parser.jay (member_access): Change the case for pre-defined types
28490 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28493 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28496 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28497 essentially like methods and apply attributes like MethodImplOptions to them too.
28499 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28502 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28503 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28506 * Update code everywhere accordingly.
28508 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28510 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28512 2002-02-28 Ravi Pratap <ravi@ximian.com>
28514 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28515 try performing lookups against those instead of jumping straight into using
28516 the 'using' clauses.
28518 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28520 (LookupType): Perform lookups in implicit parents too.
28522 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28523 sequence as RootContext.LookupType.
28525 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28526 the various cases of namespace lookups into this method.
28528 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28530 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28531 in positional arguments)
28533 * class.cs (Operator): Update the AllowedModifiers to contain
28536 * cs-parser.jay: Update operator declaration to allow for the
28537 operator body to be empty.
28539 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28542 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28544 * class.cs (Method.Emit): Label parameters.
28546 * driver.cs: Return 1 or 0 as the program exit code.
28548 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28550 * expression.cs: Special case the `null' object when trying to
28551 auto-compute the type, as anything can be explicitly converted to
28554 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28555 spotting this Paolo.
28557 (Expression.ImplicitNumericConversion): Perform comparissions of
28558 the type using the underlying type in the case of an enumeration
28559 rather than using the enumeration type for the compare.
28561 Cope with the underlying == type case, which is not possible to
28564 (Expression.ConvertNumericExplicit): Perform comparissions of
28565 the type using the underlying type in the case of an enumeration
28566 rather than using the enumeration type for the compare.
28568 * driver.cs: If the user does not supply an extension, assume .exe
28570 * cs-parser.jay (if_statement): Rewrote so that we can track the
28571 location for the if statement.
28573 * expression.cs (Binary.ConstantFold): Only concat strings when
28574 the operation is "+", not everything ;-)
28576 * statement.cs (Statement.EmitBoolExpression): Take a location
28578 (If, While, Do): Track location.
28580 * expression.cs (Binary.ResolveOperator): In the object + string
28581 case, I was missing a call to ConvertImplicit
28583 2002-02-25 Ravi Pratap <ravi@ximian.com>
28585 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28586 Location arguments. Ensure we use RootContext.LookupType to do our work
28587 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28589 * interface.cs (PopulateMethod): Handle the type of the parameter being
28592 * expression.cs (Invocation.BetterFunction): Handle the case when we
28593 have a params method with no fixed arguments and a call is made with no
28596 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28598 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28599 the verbatim-string-literal
28601 * support.cs (InternalParameters.ParameterModifier): handle null
28603 (InternalParameters.ParameterType): ditto.
28605 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28606 duplicating the name of the variable parameter.
28607 (GetParameterByName): Fix bug where we were not looking up array
28608 paramters if they were the only present (thanks Paolo!).
28609 (GetParameterInfo): We only have an empty set of types if both
28610 fixed and array are set to null.
28611 (GetParameterInfo-idx): Handle FixedParameter == null
28613 * cs-parser.jay: Handle the case where there is no catch
28614 statements (missing null test).
28616 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28618 * driver.cs (MainDriver): Be conservative on our command line
28621 Catch DirectoryNotFoundException when calling GetFiles.
28623 (SplitPathAndPattern): Used to split the input specification into
28624 a path and a pattern that we can feed to Directory.GetFiles.
28626 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28628 * statement.cs (Fixed): Implement the last case of the Fixed
28629 statement (string handling).
28631 * expression.cs (StringPtr): New class used to return a char * to
28632 a string; Used by the Fixed statement.
28634 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28636 * expression.cs (Binary.ResolveOperator): Remove redundant
28637 MemberLookup pn parent type.
28638 Optimize union call, we do not need a union if the types are the same.
28639 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28642 Specialize the use of MemberLookup everywhere, instead of using
28643 the default settings.
28645 (StackAlloc): Implement stackalloc keyword.
28647 * cs-parser.jay: Add rule to parse stackalloc.
28649 * driver.cs: Handle /h, /help, /?
28651 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28652 before we supported unsafe code.
28654 * makefile: add --unsafe to the self compilation of mcs.
28656 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28658 * expression.cs (PointerArithmetic): New class that is used to
28659 perform pointer arithmetic.
28660 (Binary.Resolve): Handle pointer arithmetic
28661 Handle pointer comparission.
28662 (ArrayPtr): Utility expression class that is used to take the
28663 address of an array.
28665 (ElementAccess): Implement array access for pointers
28667 * statement.cs (Fixed): Implement fixed statement for arrays, we
28668 are missing one more case before we are done.
28670 * expression.cs (Indirection): Implement EmitAssign and set the
28671 ExprClass to Variable. This allows pointer dereferences to be
28672 treated as variables, and to have values assigned to them.
28674 * ecore.cs (Expression.StoreFromPtr): New utility function to
28675 store values dereferencing.
28677 2002-02-20 Ravi Pratap <ravi@ximian.com>
28679 * expression.cs (Binary.ResolveOperator): Ensure that we are
28680 not trying to operate on a void type - this fixes the reported
28683 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28684 the parent implementation is sealed.
28686 * ../errors/cs0239.cs : Add.
28688 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28690 * typemanager.cs (unverifiable_code_type): Corresponds to
28691 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28692 which have unsafe code in them.
28694 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28697 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28699 * cs-tokenizer.cs: Add support for @"litreal strings"
28701 Make tokenizer accept pre-processor directives
28702 on any column (remove the old C-like limitation).
28704 * rootcontext.cs (EmitCode): Emit any global attributes.
28705 (AddGlobalAttributes): Used to keep track of assembly attributes.
28707 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28709 * cs-parser.jay: Add support for global attributes.
28711 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28713 * expression.cs (Indirection): New helper class. Unary will
28714 create Indirection classes to be able to implement the
28715 IMemoryLocation interface on it.
28717 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28719 * cs-parser.jay (fixed_statement): reference the right statement.
28721 * statement.cs (Fixed.Emit): Finish implementing the fixed
28722 statement for the &x case.
28724 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28726 * class.cs (Property.Define, Method.Define): Remove newslot when
28729 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28730 wrong. NewSlot should only be used if the `new' keyword is present.
28732 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28733 locating our system dir. Sorry about this.
28735 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28737 * driver.cs (GetSystemDir): Compute correctly the location of our
28738 system assemblies. I was using the compiler directory instead of
28739 the library directory.
28741 2002-02-13 Ravi Pratap <ravi@ximian.com>
28743 * expression.cs (BetterFunction): Put back in what Miguel commented out
28744 since it is the correct fix. The problem is elsewhere ;-)
28746 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28747 parameters of the parms method are themselves compatible or not !
28749 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28750 to check that a class implements an interface before saying that an implicit
28751 conversion was allowed. Use ImplementsInterface to do the checking.
28753 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28755 * class.cs (Method.Define): Track whether we are an explicit
28756 implementation or not. And only call DefineMethodOverride if we
28757 are an explicit implementation.
28759 (Property.DefineMethod): Ditto.
28761 2002-02-11 Ravi Pratap <ravi@ximian.com>
28763 * expression.cs (BetterFunction): Catch hideous bug which was
28764 preventing us from detecting ambiguous calls due to implicit casts i.e
28767 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28769 * support.cs (Pair): Remove un-needed method. I figured why I was
28770 getting the error in cs-parser.jay, the variable in a foreach loop
28771 is readonly, and the compiler does not really treat this as a variable.
28773 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28774 instead of EQUALS in grammar.
28776 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28778 * expression.cs (Unary.DoResolve): Check whether the argument is
28781 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28783 * support.cs: Api for Pair to set a value. Despite the fact that
28784 the variables are public the MS C# compiler refuses to compile
28785 code that accesses the field if the variable is part of a foreach
28788 * statement.cs (Fixed): Begin implementation of the fixed
28791 (Block.AddVariable): Return the VariableInfo on success and null
28792 on failure instead of true/false.
28794 * cs-parser.jay (foreach): Catch errors on variables already
28795 defined (we were ignoring this value before) and properly unwind
28796 the block hierarchy
28798 (fixed_statement): grammar for the fixed statement.
28800 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28802 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28803 pointer types to be incretemented.
28805 (SizeOf): Implement.
28807 * cs-parser.jay (pointer_member_access): Implement
28808 expr->IDENTIFIER production.
28810 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28811 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28814 (Unary): Implement indirection.
28816 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28817 use in non-unsafe context).
28819 (SimpleName.DoResolve): Check for pointers in field access on safe
28822 (Expression.LoadFromPtr): Factor the load-indirect code in this
28823 function. This was duplicated in UnboxCast and ParameterReference
28825 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28827 * expression.cs (ComposedCast): report an error if a pointer cast
28828 is used in a safe region.
28830 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28831 pointer type casts in unsafe context.
28833 * codegen.cs (EmitContext): Set up IsUnsafe.
28835 * cs-parser.jay (non_expression_type): Add productions for pointer
28838 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28839 code. We should not use force into static mode if the method is
28840 not virtual. Fixes bug in MIS
28842 * statement.cs (Do.Emit, While.Emit, For.Emit,
28843 Statement.EmitBoolExpression): Add support to Do and While to
28844 propagate infinite loop as `I do return' semantics.
28846 Improve the For case to also test for boolean constants.
28848 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28849 to the list of attributes we can add.
28851 Remove `EmitContext' argument.
28853 * class.cs (Method.Define): Apply parameter attributes.
28854 (Constructor.Define): Apply parameter attributes.
28855 (MethodCore.LabelParameters): Move here the core of labeling
28858 * support.cs (ReflectionParameters.ParameterModifier,
28859 InternalParameters.ParameterModifier): Use IsByRef on the type and
28860 only return the OUT bit for these parameters instead of in/out/ref
28863 This is because I miss-understood things. The ParameterInfo.IsIn
28864 and IsOut represent whether the parameter has the [In] and [Out]
28867 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28869 * ecore.cs (FieldExpr.Emit): Release temporaries.
28871 * assign.cs (LocalTemporary.Release): new function.
28873 * codegen.cs (EmitContext.GetTemporaryStorage,
28874 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28875 temporary storage. Now we can "put back" localbuilders when we
28878 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28880 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28881 need to make a copy of the variable to generate verifiable code.
28883 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28885 * driver.cs: Compute dynamically the system directory.
28887 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28888 Slower, but more generally useful. Used by the abstract
28889 registering implementation.
28891 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28892 the rules for the special rule on Type/instances. First check if
28893 we have the same name, and if so, try that special static path
28894 rather than the instance path.
28896 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28898 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28901 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28902 Enum, ValueType, Delegate or Array for non-corlib compiles.
28904 * cs-tokenizer.cs: Catch long identifiers (645)
28906 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28909 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28910 fix, we were returning too early, so we were not registering
28911 pending methods from abstract classes.
28913 Do not register pending methods if the class is abstract.
28915 * expression.cs (Conditional.DoResolve): Report circular implicit
28916 conversions when we neecd to compute it for conditional
28919 (Is.DoResolve): If the expression is always of the provided type,
28920 flag warning 183. If the expression can not ever be of the
28921 provided type flag warning 184.
28923 * class.cs: Catch 169 as well.
28925 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28928 2002-01-18 Nick Drochak <ndrochak@gol.com>
28930 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28932 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28934 * interface.cs: (PopulateMethod): Check for pointers being defined
28935 only if the unsafe context is active.
28936 (PopulateProperty): ditto.
28937 (PopulateIndexer): ditto.
28939 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28940 specified. If pointers are present, make sure that they are
28941 present in an unsafe context.
28942 (Constructor, Constructor.Define): ditto.
28943 (Field, Field.Define): ditto.
28944 (Property, Property.Define): ditto.
28945 (Event, Event.Define): ditto.
28947 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28948 hashtable if there are classes or structs defined.
28950 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28951 code, as the constant resolution moved.
28953 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28954 the metadata, so we can flag error 133.
28956 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28957 pointer is being declared in an unsafe context.
28959 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28961 * modifiers.cs (Modifiers.Check): Require a Location argument.
28962 Report error 227 for Unsafe use.
28964 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28966 * statement.cs (For.Emit): If the test is null, then report that
28967 we do `return', as we wont reach anything afterwards.
28969 (Switch.SwitchGoverningType): Track the expression that matched
28972 * driver.cs: Allow negative numbers as an error code to flag.
28974 * cs-parser.jay: Handle 1551.
28976 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28978 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28980 * cs-parser.jay: Report 1518 (type declaration can only contain
28981 class, struct, interface, enum or delegate)
28983 (switch_label): Report 1523 (keywords `case' or `default' must
28986 (opt_switch_sections): Report 1522 (empty switch)
28988 * driver.cs: Report 1515 (response file specified multiple times)
28989 Report 1516 (Source file specified multiple times).
28991 * expression.cs (Argument.Resolve): Signal 1510
28993 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28994 access not allowed in static code)
28996 2002-01-11 Ravi Pratap <ravi@ximian.com>
28998 * typemanager.cs (IsPointerType): Utility method which we are going
29001 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
29002 the object type, so we take care of that.
29004 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
29006 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
29007 added to non-params parameters :-)
29009 * typemanager.cs (CSharpName): Include 'void' type too.
29011 (void_ptr_type): Include in the set of core types.
29013 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
29016 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
29019 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
29020 completely forgotten about it.
29022 2002-01-10 Ravi Pratap <ravi@ximian.com>
29024 * cs-parser.jay (pointer_type): Add. This begins our implementation
29025 of parsing rules for unsafe code.
29027 (unsafe_statement): Implement.
29029 (embedded_statement): Modify to include the above.
29031 * statement.cs (Unsafe): Implement new class for unsafe blocks.
29033 * codegen.cs (EmitContext.InUnsafe): Add. This determines
29034 if the current context is an unsafe one.
29036 * cs-parser.jay (local_variable_pointer_type): Since local variable types
29037 are handled differently, we need separate rules for them.
29039 (local_variable_declaration): Update to use local_variable_pointer_type
29040 to allow variable declarations of unmanaged pointer types.
29042 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
29043 in unsafe contexts.
29045 * ../errors/cs0214.cs : Add.
29047 2002-01-16 Nick Drochak <ndrochak@gol.com>
29049 * makefile: remove 'response' file when cleaning.
29051 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29053 * cs-parser.jay: Report 1524.
29055 2002-01-14 Miguel de Icaza <miguel@ximian.com>
29057 * typemanager.cs (RegisterMethod): drop checking if we have
29058 registered this from here
29060 2002-01-12 Miguel de Icaza <miguel@ximian.com>
29062 * class.cs (Method.EmitDestructor): Implement calling our base
29065 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
29066 value of InFinally.
29068 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
29069 this routine and will wrap the call in a try/catch block. Deal
29072 2002-01-11 Miguel de Icaza <miguel@ximian.com>
29074 * ecore.cs (Expression.MemberLookup): instead of taking a
29075 parameter `same_type' that was used to tell whether we could
29076 access private members we compute our containing type from the
29079 (FieldExpr): Added partial support for volatile fields. This does
29080 not work for volatile fields exposed from assemblies, as I can not
29081 figure out how to extract the modreq from it.
29083 Updated all the source files to use this.
29085 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
29086 because it is referenced by MemberLookup very often.
29088 2002-01-09 Ravi Pratap <ravi@ximian.com>
29090 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
29091 TypeBuilder.GetCustomAttributes to retrieve what we need.
29093 Get rid of redundant default_member_attr_type as this is the same as
29094 default_member_type which already exists.
29096 * interface.cs, attribute.cs : Update accordingly.
29098 2002-01-08 Miguel de Icaza <miguel@ximian.com>
29100 * typemanager.cs: Enable IndexerPropertyName again. It does not
29101 work for TYpeBuilders though. Ravi, can you please fix this?
29103 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
29105 * expression.cs (Argument.Emit): Handle the case of ref objects
29106 being passed to ref functions;
29108 (ParameterReference.EmitLoad): Loads the content of the pointer
29109 without dereferencing.
29111 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29113 * cs-tokenizer.cs: Implemented the pre-processing expressions.
29115 2002-01-08 Ravi Pratap <ravi@ximian.com>
29117 * class.cs (Indexer.DefineMethod): Incorporate the interface
29118 type in the name of the method if we are doing explicit interface
29121 * expression.cs (ConversionExists): Remove as it is completely obsolete.
29123 (BetterConversion): Fix extremely trivial bug where we were referring to
29124 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
29127 * ../errors/bug16.cs : Add although we have fixed it.
29129 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29131 * expression.cs (BaseIndexer): Begin implementation.
29133 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
29135 * cs-parser.jay (indexer_declarator): Use qualified_identifier
29136 production directly to remove a shift/reduce, and implement
29137 explicit interface implementation.
29139 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
29140 after a floating point suffix.
29142 * expression.cs (DoNumericPromotions): Improved the conversion for
29143 uint/uint. If we have a constant, we avoid doing a typecast to a
29146 * class.cs (Indexer): Implement explicit interface implementation
29149 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
29151 * class.cs: make the default instance constructor public and hidebysig.
29153 2001-01-03 Ravi Pratap <ravi@ximian.com>
29155 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
29156 so we can call it from elsewhere.
29158 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
29159 we emit it internally if the class has a defined indexer; otherwise the user
29160 emits it by decorating the class definition with the DefaultMemberAttribute.
29162 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
29163 attribute is not used on a type which defines an indexer.
29165 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
29166 character when we skip whitespace.
29168 * ../errors/cs0646.cs : Add.
29170 2002-01-03 Miguel de Icaza <miguel@ximian.com>
29172 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
29175 * makefile: Add practical target `mcs3.exe' which builds the third
29176 generation compiler.
29178 * expression.cs (New): Fix structures constructor calling.
29180 * class.cs (Property, Method, Indexer): Emit Final flag on the
29181 method if we are an interface implementation and we are not
29184 * ecore.cs (PropertyExpr): New public field `IsBase', tells
29185 whether this property is referencing a `base' method.
29187 * expression.cs (Invocation.EmitCall): take an extra argument:
29188 is_base, this is used to determine whether the `call' or
29189 `callvirt' opcode should be used.
29192 * delegate.cs: update EmitCall.
29194 * class.cs (Method.Define): Set NewSlot for the cases where we are
29195 not implementing an interface method.
29197 (Property.Define): ditto.
29199 2002-01-02 Miguel de Icaza <miguel@ximian.com>
29201 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
29202 'r'. Allows mcs to parse itself fully.
29204 2002-01-02 Ravi Pratap <ravi@ximian.com>
29206 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
29207 of the number of initializers that require the InitializeArray method.
29209 (CheckIndices): Store the Expression in all cases - not the plain value. Also
29210 update the above field where necessary.
29212 (MakeByteBlob): Update accordingly.
29214 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
29217 (EmitDynamicInitializers): Update in accordance with the new optimization.
29219 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
29220 same OpCode applies.
29222 * cs-parser.jay : Fix some glaring errors I introduced.
29224 2002-01-01 Ravi Pratap <ravi@ximian.com>
29226 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
29227 so that we can check for name clashes there too.
29229 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29230 for interface indexers.
29232 * interfaces.cs (Define): Emit the default member attribute.
29234 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29235 variable was being referred to while setting the value ;-)
29237 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29239 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29240 byte-by-byte information when we know the data is zero.
29242 Make the block always a multiple of 4, because
29243 DefineInitializedData has a bug.
29245 * assign.cs: Fix, we should assign from the temporary, not from
29248 * expression.cs (MakeByteBlob): Fix my incorrect code.
29250 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29252 * typemanager.cs (EnumToUnderlying): This function is used to get
29253 the underlying type from an enumeration, because it does not
29256 * constant.cs: Use the I4_S form for values between -128 and 127.
29258 * statement.cs (Block.LookupLabel): Looks up a label.
29259 (Block): Drop support for labeled blocks.
29261 (LabeledStatement): New kind of statement that represents a label
29264 (Goto): Finally implement this bad boy.
29266 * cs-parser.jay: Update to reflect new mechanism to implement
29269 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29271 * codegen.cs (EmitContext.This): a codegen property that keeps the
29272 a single instance of this instead of creating many different this
29275 * delegate.cs (Delegate.DoResolve): Update to use the property;
29277 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29279 * expression.cs (BaseAccess.DoResolve): Ditto.
29281 2001-12-29 Ravi Pratap <ravi@ximian.com>
29283 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29284 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29286 (InitCoreTypes): Update accordingly.
29288 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29289 so we can quickly store the state.
29291 (ApplyAttributes): Set the correct implementation flags
29292 for InternalCall methods.
29294 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29296 * expression.cs (EmitCall): if a method is not virtual, then do
29297 not use callvirt on it.
29299 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29300 user defined stuff) requires the use of stobj, which takes an
29301 address on the stack instead of an array and an index. So emit
29302 the Ldelema operation for it.
29304 (EmitStoreOpcode): Use stobj for valuetypes.
29306 (UnaryMutator.EmitCode): Use the right 1 value depending on
29307 whether we are dealing with int64/uint64, float or doubles.
29309 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29310 constructors that I implemented last night.
29312 (Constructor.IsDefault): Fix to work properly for static
29315 * cs-parser.jay (CheckDef): report method signature errors.
29316 Update error number 103 to be 132.
29318 * decl.cs: New AdditionResult enumeration value: MethodExists.
29319 Although we do this check for methods later on in the semantic
29320 analysis, catching repeated default constructors is so easy that
29321 we catch these here.
29323 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29326 (ParameterReference.EmitAssign, Emit): handle
29329 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29330 (ArrayAccess.EmitStoreOpcode): ditto.
29332 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29334 * expression.cs (MakeByteBlob): Complete all the missing types
29335 (uint, short, ushort, byte, sbyte)
29337 * class.cs: Only init instance field initializers on instance
29340 Rename `constructors' to instance_constructors.
29342 (TypeContainer.AddConstructor): Only add constructors to the list
29343 if it is not static.
29345 Make sure that we handle default_static_constructor independently
29346 everywhere where we handle instance_constructors
29348 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29350 * class.cs: Do not lookup or create a base initializer for a
29351 static constructor.
29353 (ConstructorInitializer.Resolve): use the proper type to lookup
29356 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29358 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29361 * decl.cs: CloseType is now an virtual method, the default
29362 implementation just closes this type.
29364 2001-12-28 Ravi Pratap <ravi@ximian.com>
29366 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29367 to PreserveSig by default. Also emit HideBySig on such methods.
29369 Basically, set the defaults to standard values.
29371 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29372 argument, if candidate is better, it can't be worse than the best !
29374 (Invocation): Re-write bits to differentiate between methods being
29375 applicable in their expanded form and their normal form - for params
29378 Get rid of use_standard everywhere as only standard conversions are allowed
29379 in overload resolution.
29381 More spec conformance.
29383 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29385 * driver.cs: Add --timestamp, to see where the compiler spends
29388 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29389 `this' in static code.
29391 (SimpleName.DoResolve): Implement in terms of a helper function
29392 that allows static-references to be passed upstream to
29395 (Expression.ResolveWithSimpleName): Resolve specially simple
29396 names when called by MemberAccess to implement the special
29399 (Expression.ImplicitReferenceConversion): Handle conversions from
29400 Null to reference types before others, as Null's type is
29403 * expression.cs (Invocation.EmitCall): Handle the special case of
29404 calling methods declared on a reference type from a ValueType
29405 (Base classes System.Object and System.Enum)
29407 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29408 the left hand side is a TypeExpr, not on every enumeration.
29410 (Binary.Resolve): If types are reference types, then do a cast to
29411 object on operators != and == of both arguments.
29413 * typemanager.cs (FindMembers): Extract instance and static
29414 members if requested.
29416 * interface.cs (PopulateProperty): Use void_type instead of null
29417 as the return type for the setter method.
29419 (PopulateIndexer): ditto.
29421 2001-12-27 Ravi Pratap <ravi@ximian.com>
29423 * support.cs (ReflectionParameters): Fix minor bug where we
29424 were examining the wrong parameter for the ParamArray attribute.
29426 Cope with requests for the type of the parameter at position
29427 greater than the params parameter's. We now return the element
29428 type of the params array as that makes more sense.
29430 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29431 accordingly as we no longer have to extract the element type
29434 (Invocation.OverloadResolve): Update.
29436 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29438 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29439 against IEnumerator, test whether the return value is a descendant
29440 of the IEnumerator interface.
29442 * class.cs (Indexer.Define): Use an auxiliary method to implement
29443 the other bits of the method definition. Begin support for
29444 explicit interface implementation.
29446 (Property.DefineMethod): Use TypeManager.void_type instead of null
29447 for an empty return value.
29449 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29451 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29452 dealing with a FieldExpr which is composed of a FieldBuilder, in
29453 the code path we did extract the constant, but we should have
29454 obtained the underlying value to be able to cast it (otherwise we
29455 end up in an infinite loop, this is what Ravi was running into).
29457 (ArrayCreation.UpdateIndices): Arrays might be empty.
29459 (MemberAccess.ResolveMemberAccess): Add support for section
29460 14.5.4.1 that deals with the special case of E.I when E is a type
29461 and something else, that I can be a reference to a static member.
29463 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29464 handle a particular array type to create byte blobs, it is just
29465 something we dont generate byteblobs for.
29467 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29470 * location.cs (Push): remove the key from the hashtable that we
29471 are about to add. This happens for empty files.
29473 * driver.cs: Dispose files after we have parsed them.
29475 (tokenize): new function that only runs the tokenizer on its
29476 input, for speed testing.
29478 2001-12-26 Ravi Pratap <ravi@ximian.com>
29480 * class.cs (Event.Define): Define the private field only if there
29481 are no accessors defined.
29483 * expression.cs (ResolveMemberAccess): If there is no associated
29484 field with the event, that means we have an event defined with its
29485 own accessors and we should flag error cs0070 since transforming
29486 ourselves into a field is not valid in that case.
29488 * ecore.cs (SimpleName.DoResolve): Same as above.
29490 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29491 and charset to sane values.
29493 2001-12-25 Ravi Pratap <ravi@ximian.com>
29495 * assign.cs (DoResolve): Perform check on events only if they
29496 are being accessed outside the declaring type.
29498 * cs-parser.jay (event_declarations): Update rules to correctly
29499 set the type of the implicit parameter etc.
29501 (add_accessor, remove_accessor): Set current local parameters.
29503 * expression.cs (Binary): For delegate addition and subtraction,
29504 cast the return value from the method into the appropriate delegate
29507 2001-12-24 Ravi Pratap <ravi@ximian.com>
29509 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29510 of these as the workaround is unnecessary.
29512 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29513 delegate data - none of that is needed at all.
29515 Re-write bits to extract the instance expression and the delegate method
29518 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29521 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29522 of attaching attributes instead of duplicating code everywhere.
29524 * everywhere : Update code to do attribute emission using the above method.
29526 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29528 * expression.cs (IsParamsMethodApplicable): if there are not
29529 parameters, return immediately.
29531 * ecore.cs: The 0 literal can be implicity converted to an enum
29534 (SimpleName.DoResolve): First lookup the type, then lookup the
29537 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29538 want to get its address. If the InstanceExpression is not
29539 addressable, store the result in a temporary variable, then get
29542 * codegen.cs: Only display 219 errors on warning level or above.
29544 * expression.cs (ArrayAccess): Make it implement the
29545 IMemoryLocation interface.
29547 (Binary.DoResolve): handle the operator == (object a, object b)
29548 and operator != (object a, object b) without incurring into a
29549 BoxedCast (because 5 != o should never be performed).
29551 Handle binary enumerator operators.
29553 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29554 value type, otherwise use Ldelem_ref.
29556 Use precomputed names;
29558 (AddressOf): Implement address of
29560 * cs-parser.jay (labeled_statement): Fix recursive block
29561 addition by reworking the production.
29563 * expression.cs (New.DoEmit): New has a special case:
29565 If we are dealing with a ValueType, we have a few
29566 situations to deal with:
29568 * The target of New is a ValueType variable, that is
29569 easy, we just pass this as the variable reference
29571 * The target of New is being passed as an argument,
29572 to a boxing operation or a function that takes a
29575 In this case, we need to create a temporary variable
29576 that is the argument of New.
29579 2001-12-23 Ravi Pratap <ravi@ximian.com>
29581 * rootcontext.cs (LookupType): Check that current_type is not null before
29582 going about looking at nested types.
29584 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29585 not implement the IAssignMethod interface any more.
29587 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29588 where we tranform them into FieldExprs if they are being resolved from within
29589 the declaring type.
29591 * ecore.cs (SimpleName.DoResolve): Do the same here.
29593 * assign.cs (DoResolve, Emit): Clean up code considerably.
29595 * ../errors/bug10.cs : Add.
29597 * ../errors/cs0070.cs : Add.
29599 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29601 * assign.cs : Get rid of EventIsLocal everywhere.
29603 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29605 * ecore.cs (ConvertIntLiteral): finished the implementation.
29607 * statement.cs (SwitchLabel): Convert the value we are using as a
29608 key before looking up the table.
29610 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29612 * codegen.cs (EmitTopBlock): Require a Location argument now.
29614 * cs-parser.jay (constructor_declarator): We need to setup
29615 current_local_parameters before we parse the
29616 opt_constructor_initializer, to allow the variables to be bound
29617 to the constructor arguments.
29619 * rootcontext.cs (LookupType): First lookup nested classes in our
29620 class and our parents before we go looking outside our class.
29622 * expression.cs (ConstantFold): Extract/debox the values at the
29625 * rootcontext.cs (EmitCode): Resolve the constants first before we
29626 resolve the types. This is not really needed, but it helps debugging.
29628 * statement.cs: report location.
29630 * cs-parser.jay: pass location to throw statement.
29632 * driver.cs: Small bug fix.
29634 * report.cs: Updated format to be 4-zero filled digits.
29636 2001-12-22 Ravi Pratap <ravi@ximian.com>
29638 * expression.cs (CheckIndices): Fix minor bug where the wrong
29639 variable was being referred to ;-)
29641 (DoEmit): Do not call EmitStaticInitializers when the
29642 underlying type is System.Object.
29644 2001-12-21 Ravi Pratap <ravi@ximian.com>
29646 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29647 and do the usual workaround for SRE.
29649 * class.cs (MyEventBuilder.EventType): New member to get at the type
29650 of the event, quickly.
29652 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29654 * assign.cs (Assign.DoResolve): Handle the case when the target
29655 is an EventExpr and perform the necessary checks.
29657 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29660 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29662 (EventExpr): Set the type in the constructor itself since we
29663 are meant to be born fully resolved.
29665 (EventExpr.Define): Revert code I wrote earlier.
29667 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29668 instance expression is null. The instance expression is a This in that case
29669 or a null, depending on whether it is a static method or not.
29671 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29672 refers to more than one method.
29674 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29675 and accordingly flag errors.
29677 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29679 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29681 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29683 * location.cs (ToString): Provide useful rutine.
29685 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29687 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29688 objects, return the actual integral boxed.
29690 * statement.cs (SwitchLabel): define an ILLabel for each
29693 (Switch.CheckSwitch): If the value is a Literal, extract
29694 the underlying literal.
29696 Also in the unused hashtable we had, add the SwitchLabel so we can
29697 quickly look this value up.
29699 * constant.cs: Implement a bunch of new constants. Rewrite
29700 Literal based on this. Made changes everywhere to adapt to this.
29702 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29703 dereferencing array only once, and also copes with enumrations.
29705 bytes are two bytes wide, not one.
29707 (Cast): Perform constant conversions.
29709 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29710 wrappers to the literals here.
29712 * expression.cs (DoNumericPromotions): long literals can converted
29713 to ulong implicity (this is taken care of elsewhere, but I was
29714 missing this spot).
29716 * ecore.cs (Expression.Literalize): Make the return type Literal,
29717 to improve type checking.
29719 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29721 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29723 * literal.cs: Revert code from ravi that checked the bounds. The
29724 bounds are sane by the definition of the type itself.
29726 * typemanager.cs: Fix implementation of ImplementsInterface. We
29727 need to actually look up in our parent hierarchy for interfaces
29730 * const.cs: Use the underlying type for enumerations
29732 * delegate.cs: Compute the basename for the delegate creation,
29733 that should fix the delegate test case, and restore the correct
29734 Type Lookup semantics in rootcontext
29736 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29737 referencing a nested type with the Reflection API is using the "+"
29740 * cs-parser.jay: Do not require EOF token at the end.
29742 2001-12-20 Ravi Pratap <ravi@ximian.com>
29744 * rootcontext.cs (LookupType): Concatenate type names with
29745 a '.' instead of a '+' The test suite passes again.
29747 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29748 field of the enumeration.
29750 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29751 the case when the member is an EventExpr.
29753 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29754 static has an associated instance expression.
29756 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29758 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29760 * class.cs (Event.Define): Register event and perform appropriate checks
29763 We define the Add and Remove methods even if the use provides none because
29764 in that case, we provide default implementations ourselves.
29766 Define a private field of the type of the event. This is done by the CSC compiler
29767 and we should be doing it too ;-)
29769 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29770 More methods we use in code we generate.
29772 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29775 (InitCoreTypes): Update accordingly for the above.
29777 * class.cs (Event.Emit): Generate code for default accessors that we provide
29779 (EmitDefaultMethod): Do the job in the above.
29781 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29784 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29786 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29787 builders even if we were missing one.
29789 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29790 pass the Basename as our class name instead of the Name. The
29791 basename will be correctly composed for us.
29793 * parameter.cs (Paramters): Now takes a Location argument.
29795 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29796 make all the code call directly LookupType in RootContext and take
29797 this chance to pass the Location information everywhere.
29799 * Everywhere: pass Location information.
29801 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29803 * class.cs (Constructor.Define): Updated way of detecting the
29804 length of the parameters.
29806 (TypeContainer.DefineType): Use basename as the type name for
29809 (TypeContainer.Define): Do not recursively define types here, as
29810 definition is taken care in order by the RootContext.
29812 * tree.cs: Keep track of namespaces in a per-file basis.
29814 * parameter.cs (Parameter.ComputeSignature): Update to use
29817 (Parameters.GetSignature): ditto.
29819 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29820 instead of a TypeContainer.
29822 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29823 resolve names. Because we need to be resolve in our context, not
29826 * driver.cs: Implement response files.
29828 * class.cs (TypeContainer.DefineType): If we are defined, do not
29829 redefine ourselves.
29831 (Event.Emit): Emit the code for add/remove handlers.
29832 (Event.Define): Save the MethodBuilders for add/remove.
29834 * typemanager.cs: Use pair here too.
29836 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29837 DictionaryEntry requires the first argument to be non-null.
29839 (enum_declaration): Compute full name for registering the
29842 (delegate_declaration): Instead of using
29843 formal_parameter_list, use opt_formal_parameter_list as the list
29846 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29847 (EventParsing): New property that controls whether `add' and
29848 `remove' are returned as tokens or identifiers (for events);
29850 2001-12-19 Ravi Pratap <ravi@ximian.com>
29852 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29853 use MyEventBuilder only and let it wrap the real builder for us.
29855 (MyEventBuilder): Revamp constructor etc.
29857 Implement all operations that we perform on EventBuilder in precisely the same
29860 (FindMembers): Update to use the EventBuilder member.
29862 (Event.Emit): Update accordingly.
29864 2001-12-18 Ravi Pratap <ravi@ximian.com>
29866 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29867 by calling the appropriate methods.
29869 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29872 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29874 2001-12-17 Ravi Pratap <ravi@ximian.com>
29876 * delegate.cs (Delegate.Populate): Check that the return type
29877 and various parameters types are indeed accessible.
29879 * class.cs (Constructor.Define): Same here.
29881 (Field.Define): Ditto.
29883 (Event.Define): Ditto.
29885 (Operator.Define): Check that the underlying Method defined itself
29886 correctly - so it's MethodBuilder should not be null.
29888 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29889 expression happens to be null.
29891 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29892 members but as of now we don't seem to be able to do anything really useful with it.
29894 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29895 not the EventBuilder.
29897 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29899 * cs-tokenizer.cs: Add support for defines.
29900 Add support for #if, #elif, #else, #endif
29902 (eval_var): evaluates a variable.
29903 (eval): stubbed for evaluating functions.
29905 * cs-parser.jay: Pass the defines information
29907 * driver.cs: Add --define command line option.
29909 * decl.cs: Move MemberCore here.
29911 Make it the base class for DeclSpace. This allows us to catch and
29912 report 108 and 109 for everything now.
29914 * class.cs (TypeContainer.Define): Extract all the members
29915 before populating and emit the warning 108 (new keyword required
29916 to override) instead of having each member implement this.
29918 (MemberCore.Define): New abstract method, we will be using this in
29919 the warning reporting engine in Populate.
29921 (Operator.Define): Adjust to new MemberCore protocol.
29923 * const.cs (Const): This does not derive from Expression, it is a
29924 temporary object we use to create fields, it is a MemberCore.
29926 * class.cs (Method.Define): Allow the entry point to be in a
29929 * driver.cs: Rewrite the argument handler to clean it up a bit.
29931 * rootcontext.cs: Made it just an auxiliary namespace feature by
29932 making everything static.
29934 * driver.cs: Adapt code to use RootContext type name instead of
29937 * delegate.cs: Remove RootContext argument.
29939 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29942 * class.cs (Event.Define): The lookup can fail.
29944 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29946 * expression.cs: Resolve the this instance before invoking the code.
29948 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29950 * cs-parser.jay: Add a production in element_access that allows
29951 the thing to become a "type" reference. This way we can parse
29952 things like "(string [])" as a type.
29954 Note that this still does not handle the more complex rules of
29958 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29960 * ecore.cs: (CopyNewMethods): new utility function used to
29961 assemble the list of methods from running FindMembers.
29963 (MemberLookup): Rework FindMembers so that
29965 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29967 * class.cs (TypeContainer): Remove Delegates who fail to be
29970 * delegate.cs (Populate): Verify that we dont get null return
29971 values. TODO: Check for AsAccessible.
29973 * cs-parser.jay: Use basename to emit error 574 (destructor should
29974 have the same name as container class), not the full name.
29976 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29977 possible representation.
29979 Also implements integer type suffixes U and L.
29981 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29983 * expression.cs (ArrayCreation.DoResolve): We need to do the
29984 argument resolution *always*.
29986 * decl.cs: Make this hold the namespace. Hold the root context as
29988 (LookupType): Move here.
29990 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29992 * location.cs (Row, Name): Fixed the code, it was always returning
29993 references to the first file.
29995 * interface.cs: Register properties defined through interfaces.
29997 * driver.cs: Add support for globbing on the command line
29999 * class.cs (Field): Make it derive from MemberCore as well.
30002 2001-12-15 Ravi Pratap <ravi@ximian.com>
30004 * class.cs (Event::Define): Check that the type of the event is a delegate
30005 type else flag error #66.
30007 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
30010 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
30011 values of EntryPoint, CharSet etc etc.
30013 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
30015 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
30016 be null and we should ignore this. I am not sure if this is really clean. Apparently,
30017 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
30018 which needs this to do its work.
30020 * ../errors/cs0066.cs : Add.
30022 2001-12-14 Miguel de Icaza <miguel@ximian.com>
30024 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
30027 * class.cs: (MethodSignature.MethodSignature): Removed hack that
30028 clears out the parameters field.
30029 (MemberSignatureCompare): Cleanup
30031 (MemberCore): New base class used to share code between MethodCore
30034 (RegisterRequiredImplementations) BindingFlags.Public requires
30035 either BindingFlags.Instace or Static. Use instance here.
30037 (Property): Refactored code to cope better with the full spec.
30039 * parameter.cs (GetParameterInfo): Return an empty array instead
30042 * class.cs (Property): Abstract or extern properties have no bodies.
30044 * parameter.cs (GetParameterInfo): return a zero-sized array.
30046 * class.cs (TypeContainer.MethodModifiersValid): Move all the
30047 method modifier validation to the typecontainer so we can reuse
30048 this on properties.
30050 (MethodCore.ParameterTypes): return an empty sized array of types.
30052 (Property.Define): Test property modifier validity.
30054 Add tests for sealed/override too.
30056 (Method.Emit): abstract or extern methods have no bodies.
30058 2001-12-14 Ravi Pratap <ravi@ximian.com>
30060 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
30063 (Method::Define, ::Emit): Modify accordingly.
30065 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
30067 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
30069 * makefile: Pass in /unsafe.
30071 2001-12-13 Miguel de Icaza <miguel@ximian.com>
30073 * class.cs (MakeKey): Kill routine.
30075 * class.cs (TypeContainer.Define): Correctly define explicit
30076 method implementations (they require the full interface name plus
30079 * typemanager.cs: Deply the PtrHashtable here and stop using the
30080 lame keys. Things work so much better.
30082 This of course broke everyone who depended on `RegisterMethod' to
30083 do the `test for existance' test. This has to be done elsewhere.
30085 * support.cs (PtrHashtable): A hashtable that avoid comparing with
30086 the object stupid Equals method (because, that like fails all over
30087 the place). We still do not use it.
30089 * class.cs (TypeContainer.SetRequiredInterface,
30090 TypeContainer.RequireMethods): Killed these two routines and moved
30091 all the functionality to RegisterRequiredImplementations.
30093 (TypeContainer.RegisterRequiredImplementations): This routine now
30094 registers all the implementations required in an array for the
30095 interfaces and abstract methods. We use an array of structures
30096 which can be computed ahead of time to reduce memory usage and we
30097 also assume that lookups are cheap as most classes will not
30098 implement too many interfaces.
30100 We also avoid creating too many MethodSignatures.
30102 (TypeContainer.IsInterfaceMethod): Update and optionally does not
30103 clear the "pending" bit if we find that there are problems with
30106 (TypeContainer.VerifyPendingMethods): Update to report errors of
30107 methods that look like implementations but are not.
30109 (TypeContainer.Define): Add support for explicit interface method
30112 2001-12-12 Miguel de Icaza <miguel@ximian.com>
30114 * typemanager.cs: Keep track of the parameters here instead of
30115 being a feature of the TypeContainer.
30117 * class.cs: Drop the registration of parameters here, as
30118 InterfaceMethods are also interface declarations.
30120 * delegate.cs: Register methods with the TypeManager not only with
30121 the TypeContainer. This code was buggy.
30123 * interface.cs: Full registation here.
30125 2001-12-11 Miguel de Icaza <miguel@ximian.com>
30127 * expression.cs: Remove reducer for binary expressions, it can not
30130 * const.cs: Put here the code that used to go into constant.cs
30132 * constant.cs: Put here the code for constants, this is a new base
30133 class for Literals.
30135 * literal.cs: Make Literal derive from Constant.
30137 2001-12-09 Miguel de Icaza <miguel@ximian.com>
30139 * statement.cs (Return.Emit): Report error 157 if the user
30140 attempts to return from a finally block.
30142 (Return.Emit): Instead of emitting a return, jump to the end of
30145 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
30146 LocalBuilder to store the result of the function. ReturnLabel is
30147 the target where we jump.
30150 2001-12-09 Radek Doulik <rodo@ximian.com>
30152 * cs-parser.jay: remember alias in current namespace
30154 * ecore.cs (SimpleName::DoResolve): use aliases for types or
30157 * class.cs (LookupAlias): lookup alias in my_namespace
30159 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
30161 (LookupAlias): lookup alias in this and if needed in parent
30164 2001-12-08 Miguel de Icaza <miguel@ximian.com>
30168 * rootcontext.cs: (ModuleBuilder) Made static, first step into
30169 making things static. I need this to avoid passing the
30170 TypeContainer when calling ParameterType.
30172 * support.cs (InternalParameters.ParameterType): Remove ugly hack
30173 that did string manipulation to compute the type and then call
30174 GetType. Use Parameter.ParameterType instead.
30176 * cs-tokenizer.cs: Consume the suffix for floating values.
30178 * expression.cs (ParameterReference): figure out whether this is a
30179 reference parameter or not. Kill an extra variable by computing
30180 the arg_idx during emission.
30182 * parameter.cs (Parameters.GetParameterInfo): New overloaded
30183 function that returns whether a parameter is an out/ref value or not.
30185 (Parameter.ParameterType): The type of the parameter (base,
30186 without ref/out applied).
30188 (Parameter.Resolve): Perform resolution here.
30189 (Parameter.ExternalType): The full type (with ref/out applied).
30191 * statement.cs (Using.Emit, Using.EmitExpression): Implement
30192 support for expressions on the using statement.
30194 2001-12-07 Miguel de Icaza <miguel@ximian.com>
30196 * statement.cs (Using.EmitLocalVariableDecls): Split the
30197 localvariable handling of the using statement.
30199 (Block.EmitMeta): Keep track of variable count across blocks. We
30200 were reusing slots on separate branches of blocks.
30202 (Try.Emit): Emit the general code block, we were not emitting it.
30204 Check the type of the declaration to be an IDisposable or
30205 something that can be implicity converted to it.
30207 Emit conversions if required.
30209 * ecore.cs (EmptyExpression): New utility class.
30210 (Expression.ImplicitConversionExists): New utility function.
30212 2001-12-06 Miguel de Icaza <miguel@ximian.com>
30214 * statement.cs (Using): Implement.
30216 * expression.cs (LocalVariableReference): Support read only variables.
30218 * statement.cs: Remove the explicit emit for the Leave opcode.
30219 (VariableInfo): Add a readonly field.
30221 2001-12-05 Miguel de Icaza <miguel@ximian.com>
30223 * ecore.cs (ConvCast): new class used to encapsulate the various
30224 explicit integer conversions that works in both checked and
30225 unchecked contexts.
30227 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30228 properly generate the overflow opcodes.
30230 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30232 * statement.cs: The correct type for the EmptyExpression is the
30233 element_type, not the variable type. Ravi pointed this out.
30235 2001-12-04 Ravi Pratap <ravi@ximian.com>
30237 * class.cs (Method::Define): Handle PInvoke methods specially
30238 by using DefinePInvokeMethod instead of the usual one.
30240 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30241 above to do the task of extracting information and defining the method.
30243 2001-12-04 Ravi Pratap <ravi@ximian.com>
30245 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30246 of the condition for string type.
30248 (Emit): Move that here.
30250 (ArrayCreation::CheckIndices): Keep string literals in their expression
30253 (EmitDynamicInitializers): Handle strings appropriately.
30255 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30257 * codegen.cs (EmitContext): Replace multiple variables with a
30258 single pointer to the current Switch statement.
30260 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30263 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30267 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30270 (Foreach.Emit): Foreach on arrays was not setting
30271 up the loop variables (for break/continue).
30273 (GotoCase): Semi-implented.
30275 2001-12-03 Ravi Pratap <ravi@ximian.com>
30277 * attribute.cs (CheckAttribute): Handle system attributes by using
30278 Attribute.GetAttributes to examine information we need.
30280 (GetValidPlaces): Same here.
30282 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30284 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30286 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30288 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30290 (Method::Emit): Handle the case when we are a PInvoke method.
30292 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30294 * expression.cs: Use ResolveWithSimpleName on compound names.
30296 2001-12-02 Ravi Pratap <ravi@ximian.com>
30298 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30299 before trying to reduce it.
30301 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30303 * constant.cs (LookupConstantValue): Implement.
30305 (EmitConstant): Use the above in emitting the constant.
30307 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30308 that are user-defined by doing a LookupConstantValue on them.
30310 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30313 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30315 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30317 (BaseAccess.DoResolve): Implement.
30319 (MemberAccess.DoResolve): Split this routine into a
30320 ResolveMemberAccess routine that can be used independently
30322 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30324 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30325 As that share bits of the implementation. Is returns a boolean,
30326 while As returns the Type that is being probed.
30328 2001-12-01 Ravi Pratap <ravi@ximian.com>
30330 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30331 instead of a Literal - much easier.
30333 (EnumInTransit): Remove - utterly useless :-)
30335 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30337 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30339 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30340 chain when we have no associated expression.
30342 2001-11-30 Ravi Pratap <ravi@ximian.com>
30344 * constant.cs (Define): Use Location while reporting the errror.
30346 Also emit a warning when 'new' is used and there is no inherited
30349 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30352 (LookupEnumValue): Implement to lookup an enum member's value and define it
30355 (Populate): Re-write accordingly to use the above routine.
30357 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30359 * expression.cs (This): Fix prototype for DoResolveLValue to
30360 override the base class DoResolveLValue.
30362 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30365 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30366 (we need to load the address of the field here). This fixes
30369 (FieldExpr.DoResolveLValue): Call the DoResolve
30370 function to initialize the Instance expression.
30372 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30373 correctly the GetEnumerator operation on a value type.
30375 * cs-parser.jay: Add more simple parsing error catches.
30377 * statement.cs (Switch): Add support for string switches.
30378 Handle null specially.
30380 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30382 2001-11-28 Ravi Pratap <ravi@ximian.com>
30384 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30386 (declare_local_constant): New helper function.
30388 * statement.cs (AddConstant): Keep a separate record of constants
30390 (IsConstant): Implement to determine if a variable is a constant.
30392 (GetConstantExpression): Implement.
30394 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30396 * statement.cs (IsVariableDefined): Re-write.
30398 2001-11-27 Ravi Pratap <ravi@ximian.com>
30400 * class.cs (TypeContainer::FindMembers): Look for constants
30401 in the case when we are looking for MemberTypes.Field
30403 * expression.cs (MemberAccess::DoResolve): Check that in the
30404 case we are a FieldExpr and a Literal, we are not being accessed
30405 by an instance reference.
30407 * cs-parser.jay (local_constant_declaration): Implement.
30409 (declaration_statement): Implement for constant declarations.
30411 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30413 * statement.cs (Switch): Catch double defaults.
30415 (Switch): More work on the switch() statement
30416 implementation. It works for integral values now, need to finish
30420 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30422 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30423 integer literals into other integer literals. To be used by
30426 2001-11-24 Ravi Pratap <ravi@ximian.com>
30428 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30431 (EmitDynamicInitializers): Cope with the above since we extract data
30432 directly from ArrayData now.
30434 (ExpectInitializers): Keep track of whether initializers are mandatory
30437 (Bounds): Make it a hashtable to prevent the same dimension being
30438 recorded for every element in that dimension.
30440 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30443 Also fix bug which was causing the indices to be emitted in the reverse
30446 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30448 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30449 unfinished. They do not work, because the underlying code is
30452 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30454 * cs-parser.jay: Remove bogus fixme.
30456 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30457 on Switch statement.
30459 2001-11-23 Ravi Pratap <ravi@ximian.com>
30461 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30464 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30465 parameter. Apparently, any expression is allowed.
30467 (ValidateInitializers): Update accordingly.
30469 (CheckIndices): Fix some tricky bugs thanks to recursion.
30471 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30472 I was being completely brain-dead.
30474 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30475 and re-write acordingly.
30477 (DelegateInvocation): Re-write accordingly.
30479 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30481 (MakeByteBlob): Handle types more correctly.
30483 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30484 initialization from expressions but it is incomplete because I am a complete
30487 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30489 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30490 on If. Basically, we have to return `true' (ie, we do return to
30491 our caller) only if both branches of the if return.
30493 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30494 short-circuit operators, handle them as short circuit operators.
30496 (Cast.DoResolve): Resolve type.
30497 (Cast.Cast): Take an expression as the target type.
30499 * cs-parser.jay (cast_expression): Remove old hack that only
30500 allowed a limited set of types to be handled. Now we take a
30501 unary_expression and we resolve to a type during semantic
30504 Use the grammar productions from Rhys to handle casts (this is
30505 not complete like Rhys syntax yet, we fail to handle that corner
30506 case that C# has regarding (-x), but we will get there.
30508 2001-11-22 Ravi Pratap <ravi@ximian.com>
30510 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30511 field which is an array type.
30513 * cs-parser.jay (declare_local_variables): Support array initialization too.
30515 * typemanager.cs (MakeKey): Implement.
30517 (everywhere): Use the above appropriately.
30519 * cs-parser.jay (for_statement): Update for array initialization while
30520 declaring variables.
30522 * ecore.cs : The error message was correct, it's the variable's names that
30523 were misleading ;-) Make the code more readable.
30525 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30526 the correct type etc.
30528 (ConvertExplicit): Handle Enum types by examining the underlying type.
30530 2001-11-21 Ravi Pratap <ravi@ximian.com>
30532 * parameter.cs (GetCallingConvention): Always return
30533 CallingConventions.Standard for now.
30535 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30537 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30538 and `r' after calling DoNumericPromotions.
30540 * ecore.cs: Fix error message (the types were in the wrong order).
30542 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30543 BindingFlags.Instance as well
30545 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30546 implicit int literal conversion in an empty cast so that we
30547 propagate the right type upstream.
30549 (UnboxCast): new class used to unbox value types.
30550 (Expression.ConvertExplicit): Add explicit type conversions done
30553 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30554 the target type before applying the implicit LongLiterals to ULong
30557 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30559 * cs-parser.jay (for_statement): Reworked the way For works: now
30560 we declare manually any variables that are introduced in
30561 for_initializer to solve the problem of having out-of-band code
30562 emition (that is what got for broken).
30564 (declaration_statement): Perform the actual variable declaration
30565 that used to be done in local_variable_declaration here.
30567 (local_variable_declaration): Do not declare anything, just pass
30568 the information on a DictionaryEntry
30570 2001-11-20 Ravi Pratap <ravi@ximian.com>
30572 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30573 re-write of the logic to now make it recursive.
30575 (UpdateIndices): Re-write accordingly.
30577 Store element data in a separate ArrayData list in the above methods.
30579 (MakeByteBlob): Implement to dump the array data into a byte array.
30581 2001-11-19 Ravi Pratap <ravi@ximian.com>
30583 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30586 * constant.cs (Define): Implement.
30588 (EmitConstant): Re-write fully.
30590 Pass in location info.
30592 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30595 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30596 DictionaryEntry since we need location info too.
30598 (constant_declaration): Update accordingly.
30600 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30601 code into another method : UpdateIndices.
30603 2001-11-18 Ravi Pratap <ravi@ximian.com>
30605 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30606 some type checking etc.
30608 2001-11-17 Ravi Pratap <ravi@ximian.com>
30610 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30611 bits to provide dimension info if the user skips doing that.
30613 Update second constructor to store the rank correctly.
30615 2001-11-16 Ravi Pratap <ravi@ximian.com>
30617 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30618 and try to implement.
30620 * ../errors/cs0150.cs : Add.
30622 * ../errors/cs0178.cs : Add.
30624 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30626 * statement.cs: Implement foreach on multi-dimensional arrays.
30628 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30629 name of the params argument.
30631 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30632 initializing the array.
30634 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30635 we can use this elsewhere.
30637 * statement.cs: Finish implementation of foreach for single
30640 * cs-parser.jay: Use an out-of-band stack to pass information
30641 around, I wonder why I need this.
30643 foreach_block: Make the new foreach_block the current_block.
30645 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30646 function used to return a static Parameters structure. Used for
30647 empty parameters, as those are created very frequently.
30649 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30651 2001-11-15 Ravi Pratap <ravi@ximian.com>
30653 * interface.cs : Default modifier is private, not public. The
30654 make verify test passes again.
30656 2001-11-15 Ravi Pratap <ravi@ximian.com>
30658 * support.cs (ReflectionParameters): Fix logic to determine
30659 whether the last parameter is a params one. Test 9 passes again.
30661 * delegate.cs (Populate): Register the builders we define with
30662 RegisterParameterForBuilder. Test 19 passes again.
30664 * cs-parser.jay (property_declaration): Reference $6 instead
30665 of $$ to get at the location.
30667 (indexer_declaration): Similar stuff.
30669 (attribute): Ditto.
30671 * class.cs (Property): Register parameters for the Get and Set methods
30672 if they exist. Test 23 passes again.
30674 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30675 call to EmitArguments as we are sure there aren't any params arguments.
30676 Test 32 passes again.
30678 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30679 IndexOutOfRangeException.
30681 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30682 Test 33 now passes again.
30684 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30686 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30687 broke a bunch of things. Will have to come up with a better way
30688 of tracking locations.
30690 * statement.cs: Implemented foreach for single dimension arrays.
30692 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30694 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30695 an error. This removes the lookup from the critical path.
30697 * cs-parser.jay: Removed use of temporary_loc, which is completely
30700 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30702 * support.cs (ReflectionParameters.ParameterModifier): Report
30703 whether the argument is a PARAMS argument or not.
30705 * class.cs: Set the attribute `ParamArrayAttribute' on the
30706 parameter argument.
30708 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30709 and cons_param_array_attribute (ConstructorInfo for
30710 ParamArrayAttribute).,
30712 * codegen.cs: Emit the return using the `Return' statement, that
30713 way we can report the error correctly for missing return values.
30715 * class.cs (Method.Emit): Clean up.
30717 * expression.cs (Argument.Resolve): Take another argument: the
30718 location where this argument is used. Notice that this is not
30719 part of the "Argument" class as to reduce the size of the
30720 structure (we know the approximate location anyways).
30722 Test if the argument is a variable-reference, if not, then
30723 complain with a 206.
30725 (Argument.Emit): Emit addresses of variables.
30727 (Argument.FullDesc): Simplify.
30729 (Invocation.DoResolve): Update for Argument.Resolve.
30731 (ElementAccess.DoResolve): ditto.
30733 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30734 method should be virtual, as this method is always virtual.
30736 (NewDelegate.DoResolve): Update for Argument.Resolve.
30738 * class.cs (ConstructorInitializer.DoResolve): ditto.
30740 * attribute.cs (Attribute.Resolve): ditto.
30742 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30744 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30746 * expression.cs (ParameterReference): Drop IStackStorage and implement
30747 IAssignMethod instead.
30749 (LocalVariableReference): ditto.
30751 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30752 IAssignMethod instead.
30754 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30756 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30757 enumerations that are used in heavily used structures derive from
30758 byte in a laughable and pathetic attempt to reduce memory usage.
30759 This is the kind of pre-optimzations that you should not do at
30760 home without adult supervision.
30762 * expression.cs (UnaryMutator): New class, used to handle ++ and
30763 -- separatedly from the other unary operators. Cleans up the
30764 code, and kills the ExpressionStatement dependency in Unary.
30766 (Unary): Removed `method' and `Arguments' from this class, making
30767 it smaller, and moving it all to SimpleCall, so I can reuse this
30768 code in other locations and avoid creating a lot of transient data
30769 strucutres when not required.
30771 * cs-parser.jay: Adjust for new changes.
30773 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30775 * enum.cs (Enum.Populate): If there is a failure during
30778 * cs-parser.jay (opt_enum_base): we used to catch type errors
30779 here, but this is really incorrect. The type error should be
30780 catched during semantic analysis.
30782 2001-12-11 Ravi Pratap <ravi@ximian.com>
30784 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30785 current_local_parameters as expected since I, in my stupidity, had forgotten
30788 * attribute.cs (GetValidPlaces): Fix stupid bug.
30790 * class.cs (Method::Emit): Perform check on applicability of attributes.
30792 (Constructor::Emit): Ditto.
30794 (Field::Emit): Ditto.
30796 (Field.Location): Store location information.
30798 (Property, Event, Indexer, Operator): Ditto.
30800 * cs-parser.jay (field_declaration): Pass in location for each field.
30802 * ../errors/cs0592.cs : Add.
30804 2001-11-12 Ravi Pratap <ravi@ximian.com>
30806 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30808 (InitCoreTypes): Update accordingly.
30810 (RegisterAttrType, LookupAttr): Implement.
30812 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30813 info about the same.
30815 (Resolve): Update to populate the above as necessary.
30817 (Error592): Helper.
30819 (GetValidPlaces): Helper to the above.
30821 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30823 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30825 2001-11-12 Ravi Pratap <ravi@ximian.com>
30827 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30829 * ../errors/cs0617.cs : Add.
30831 2001-11-11 Ravi Pratap <ravi@ximian.com>
30833 * enum.cs (Emit): Rename to Populate to be more consistent with what
30834 we expect it to do and when exactly it is called.
30836 * class.cs, rootcontext.cs : Update accordingly.
30838 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30839 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30841 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30843 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30844 of a fieldinfo using the above, when dealing with a FieldBuilder.
30846 2001-11-10 Ravi Pratap <ravi@ximian.com>
30848 * ../errors/cs0031.cs : Add.
30850 * ../errors/cs1008.cs : Add.
30852 * ../errrors/cs0543.cs : Add.
30854 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30857 (FindMembers): Implement.
30859 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30860 enums and delegates too.
30862 (enum_types): Rename to builder_to_enum.
30864 (delegate_types): Rename to builder_to_delegate.
30866 * delegate.cs (FindMembers): Implement.
30868 2001-11-09 Ravi Pratap <ravi@ximian.com>
30870 * typemanager.cs (IsEnumType): Implement.
30872 * enum.cs (Emit): Re-write parts to account for the underlying type
30873 better and perform checking etc.
30875 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30876 of the underlying type.
30878 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30881 * enum.cs (error31): Helper to report error #31.
30883 * cs-parser.jay (enum_declaration): Store location of each member too.
30885 * enum.cs (member_to_location): New hashtable.
30887 (AddEnumMember): Update location hashtable.
30889 (Emit): Use the location of each member while reporting errors.
30891 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30893 * cs-parser.jay: A for_initializer if is a
30894 local_variable_declaration really ammount to have an implicit
30895 block with the variable declaration and no initializer for for.
30897 * statement.cs (For.Emit): Cope with null initializers.
30899 This fixes the infinite loop on for initializers.
30901 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30903 * enum.cs: More cleanup.
30905 * ecore.cs: Remove dead code.
30907 * class.cs (Property.Emit): More simplification.
30908 (Event.Emit): ditto.
30910 Reworked to have less levels of indentation.
30912 2001-11-08 Ravi Pratap <ravi@ximian.com>
30914 * class.cs (Property): Emit attributes.
30924 * enum.cs (Emit): Ditto.
30926 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30929 * class.cs (Field, Event, etc.): Move attribute generation into the
30930 Emit method everywhere.
30932 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30933 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30934 as we had no way of defining nested enums !
30936 * rootcontext.cs : Adjust code accordingly.
30938 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30940 2001-11-07 Ravi Pratap <ravi@ximian.com>
30942 * expression.cs (EvalConstantExpression): Move into ecore.cs
30944 * enum.cs (Enum): Rename some members and make them public and readonly
30945 according to our convention.
30947 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30950 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30952 (Enum::Emit): Write a simple version for now which doesn't try to compute
30953 expressions. I shall modify this to be more robust in just a while.
30955 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30957 (TypeContainer::CloseType): Create the Enum types too.
30959 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30961 * expression.cs (EvalConstantExpression): Get rid of completely.
30963 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30964 user-defined values and other cases.
30966 (IsValidEnumLiteral): Helper function.
30968 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30969 out there in the case we had a literal FieldExpr.
30971 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30973 (Literalize): Revamp a bit to take two arguments.
30975 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30977 2001-11-06 Ravi Pratap <ravi@ximian.com>
30979 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30981 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30983 (Resolve): Use the above to ensure we have proper initializers.
30985 2001-11-05 Ravi Pratap <ravi@ximian.com>
30987 * expression.cs (Expression::EvalConstantExpression): New method to
30988 evaluate constant expressions.
30990 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30992 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30994 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30997 (Binary.ResolveOperator): Handle operator != (object a, object b)
30998 and operator == (object a, object b);
31000 (Binary.DoNumericPromotions): Indicate whether the numeric
31001 promotion was possible.
31003 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
31006 Made the ArrayAccess implement interface IAssignMethod instead of
31007 IStackStore as the order in which arguments are passed reflects
31010 * assign.cs: Instead of using expr.ExprClass to select the way of
31011 assinging, probe for the IStackStore/IAssignMethod interfaces.
31013 * typemanager.cs: Load InitializeArray definition.
31015 * rootcontext.cs (RootContext.MakeStaticData): Used to define
31016 static data that can be used to initialize arrays.
31018 2001-11-05 Miguel de Icaza <miguel@ximian.com>
31020 * expression.cs: Handle operator== and operator!= for booleans.
31022 (Conditioal.Reduce): Implement reducer for the ?: operator.
31024 (Conditional.Resolve): Implement dead code elimination.
31026 (Binary.Resolve): Catch string literals and return a new
31027 concatenated string.
31029 (Unary.Reduce): Implement reduction of unary expressions.
31031 * ecore.cs: Split out the expression core handling here.
31033 (Expression.Reduce): New method used to perform constant folding
31034 and CSE. This is needed to support constant-expressions.
31036 * statement.cs (Statement.EmitBoolExpression): Pass true and false
31037 targets, and optimize for !x.
31039 2001-11-04 Ravi Pratap <ravi@ximian.com>
31041 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
31042 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
31043 set custom atttributes.
31045 * literal.cs (Literal::GetValue): New abstract method to return the actual
31046 value of the literal, cast as an object.
31048 (*Literal): Implement GetValue method.
31050 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
31051 expressions to the arraylist but objects of type Argument.
31053 * class.cs (TypeContainer::Emit): Emit our attributes too.
31055 (Method::Emit, Constructor::Emit): Ditto.
31057 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
31058 to be ignoring earlier.
31060 2001-11-03 Ravi Pratap <ravi@ximian.com>
31062 * attribute.cs (AttributeSection::Define): Implement to do the business
31063 of constructing a CustomAttributeBuilder.
31065 (Attribute): New trivial class. Increases readability of code.
31067 * cs-parser.jay : Update accordingly.
31069 (positional_argument_list, named_argument_list, named_argument): New rules
31071 (attribute_arguments): Use the above so that we are more correct.
31073 2001-11-02 Ravi Pratap <ravi@ximian.com>
31075 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
31076 to perform all checks for a method with a params parameter.
31078 (Invocation::OverloadResolve): Update to use the above method and therefore
31079 cope correctly with params method invocations.
31081 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
31084 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
31085 constructors in our parent too because we can't afford to miss out on
31088 * attribute.cs (AttributeSection): New name for the class Attribute
31090 Other trivial changes to improve readability.
31092 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
31093 use the new class names.
31095 2001-11-01 Ravi Pratap <ravi@ximian.com>
31097 * class.cs (Method::Define): Complete definition for params types too
31099 (Indexer::Define): Ditto.
31101 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
31102 Cope everywhere with a request for info about the array parameter.
31104 2001-11-01 Ravi Pratap <ravi@ximian.com>
31106 * tree.cs (RecordNamespace): Fix up to check for the correct key.
31108 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
31109 local_variable_type to extract the string corresponding to the type.
31111 (local_variable_type): Fixup the action to use the new helper method.
31113 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
31116 * expression.cs : Clean out code which uses the above.
31118 2001-10-31 Ravi Pratap <ravi@ximian.com>
31120 * typemanager.cs (RegisterMethod): Check if we already have an existing key
31121 and bale out if necessary by returning a false.
31123 (RegisterProperty): Ditto.
31125 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
31126 and print out appropriate error messages.
31128 * interface.cs (everywhere): Ditto.
31130 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
31131 location to constructor.
31133 * class.cs (Property, Event, Indexer): Update accordingly.
31135 * ../errors/cs111.cs : Added.
31137 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
31138 of a method, as laid down by the spec.
31140 (Invocation::OverloadResolve): Use the above method.
31142 2001-10-31 Ravi Pratap <ravi@ximian.com>
31144 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
31145 now take a TypeContainer and a Parameters object.
31147 (ParameterData): Modify return type of ParameterModifier method to be
31148 Parameter.Modifier and not a string.
31150 (ReflectionParameters, InternalParameters): Update accordingly.
31152 * expression.cs (Argument::GetParameterModifier): Same here.
31154 * support.cs (InternalParameters::ParameterType): Find a better way of determining
31155 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
31156 symbol in it at all so maybe this is only for now.
31158 2001-10-30 Ravi Pratap <ravi@ximian.com>
31160 * support.cs (InternalParameters): Constructor now takes an extra argument
31161 which is the actual Parameters class.
31163 (ParameterDesc): Update to provide info on ref/out modifiers.
31165 * class.cs (everywhere): Update call to InternalParameters to pass in
31166 the second argument too.
31168 * support.cs (ParameterData): Add ParameterModifier, which is a method
31169 to return the modifier info [ref/out etc]
31171 (InternalParameters, ReflectionParameters): Implement the above.
31173 * expression.cs (Argument::ParameterModifier): Similar function to return
31174 info about the argument's modifiers.
31176 (Invocation::OverloadResolve): Update to take into account matching modifiers
31179 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
31180 a new SetFormalParameters object which we pass to InternalParameters.
31182 2001-10-30 Ravi Pratap <ravi@ximian.com>
31184 * expression.cs (NewArray): Merge into the ArrayCreation class.
31186 2001-10-29 Ravi Pratap <ravi@ximian.com>
31188 * expression.cs (NewArray): Merge classes NewBuiltinArray and
31189 NewUserdefinedArray into one as there wasn't much of a use in having
31192 * expression.cs (Argument): Change field's name to ArgType from Type.
31194 (Type): New readonly property which returns the proper type, taking into
31195 account ref/out modifiers.
31197 (everywhere): Adjust code accordingly for the above.
31199 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
31200 whether we are emitting for a ref or out parameter.
31202 * expression.cs (Argument::Emit): Use the above field to set the state.
31204 (LocalVariableReference::Emit): Update to honour the flag and emit the
31207 * parameter.cs (Attributes): Set the correct flags for ref parameters.
31209 * expression.cs (Argument::FullDesc): New function to provide a full desc.
31211 * support.cs (ParameterData): Add method ParameterDesc to the interface.
31213 (ReflectionParameters, InternalParameters): Implement the above method.
31215 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
31218 (Invocation::FullMethodDesc): Ditto.
31220 2001-10-29 Miguel de Icaza <miguel@ximian.com>
31222 * cs-parser.jay: Add extra production for the second form of array
31225 * expression.cs (ArrayCreation): Update to reflect the above
31228 * Small changes to prepare for Array initialization.
31230 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31232 * typemanager.cs (ImplementsInterface): interface might be null;
31233 Deal with this problem;
31235 Also, we do store negative hits on the cache (null values), so use
31236 this instead of calling t.GetInterfaces on the type everytime.
31238 2001-10-28 Ravi Pratap <ravi@ximian.com>
31240 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31242 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31243 split functionality out into different classes.
31245 (New::FormArrayType): Move into NewBuiltinArray.
31247 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31250 (NewBuiltinArray): New class to handle creation of built-in arrays.
31252 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31253 account creation of one-dimensional arrays.
31255 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31257 (NewUserdefinedArray::DoResolve): Implement.
31259 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31261 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31262 we maintain inside the TypeManager. This is necessary to perform lookups on the
31265 (LookupType): Update to perform GetType on the module builders too.
31267 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31269 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31271 2001-10-23 Ravi Pratap <ravi@ximian.com>
31273 * expression.cs (New::DoResolve): Implement guts of array creation.
31275 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31277 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31279 * expression.cs: Fix bug I introduced lsat night that broke
31282 (Expression.Resolve): Report a 246 error (can not resolve name)
31283 if we find a SimpleName in the stream.
31285 (Expression.ResolveLValue): Ditto.
31287 (Expression.ResolveWithSimpleName): This function is a variant of
31288 ResolveName, this one allows SimpleNames to be returned without a
31289 warning. The only consumer of SimpleNames is MemberAccess
31291 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31293 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31294 might arrive here. I have my doubts that this is correct.
31296 * statement.cs (Lock): Implement lock statement.
31298 * cs-parser.jay: Small fixes to support `lock' and `using'
31300 * cs-tokenizer.cs: Remove extra space
31302 * driver.cs: New flag --checked, allows to turn on integer math
31305 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31306 Threading.Monitor.Exit
31308 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31310 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31311 Expression Class to be IndexerAccess.
31313 Notice that Indexer::DoResolve sets the eclass to Value.
31315 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31317 * class.cs (TypeContainer::Emit): Emit code for indexers.
31319 * assign.cs (IAssignMethod): New interface implemented by Indexers
31320 and Properties for handling assignment.
31322 (Assign::Emit): Simplify and reuse code.
31324 * expression.cs (IndexerAccess, PropertyExpr): Implement
31325 IAssignMethod, clean up old code.
31327 2001-10-22 Ravi Pratap <ravi@ximian.com>
31329 * typemanager.cs (ImplementsInterface): New method to determine if a type
31330 implements a given interface. Provides a nice cache too.
31332 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31335 (ConvertReferenceExplicit): Ditto.
31337 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31338 various methods, with correct names etc.
31340 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31341 Operator.UnaryNegation.
31343 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31344 we have a unary plus or minus operator.
31346 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31349 * everywhere : update accordingly.
31351 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31354 * class.cs (Method::Define): For the case where we are implementing a method
31355 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31356 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31358 2001-10-21 Ravi Pratap <ravi@ximian.com>
31360 * interface.cs (FindMembers): Implement to work around S.R.E
31363 * typemanager.cs (IsInterfaceType): Implement.
31365 (FindMembers): Update to handle interface types too.
31367 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31368 use IsAssignableFrom as that is not correct - it doesn't work.
31370 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31371 and accordingly override EmitStatement.
31373 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31374 using the correct logic :-)
31376 2001-10-19 Ravi Pratap <ravi@ximian.com>
31378 * ../errors/cs-11.cs : Add to demonstrate error -11
31380 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31382 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31383 then pass this as a hint to ResolveLValue.
31385 * expression.cs (FieldExpr): Add Location information
31387 (FieldExpr::LValueResolve): Report assignment to readonly
31390 (Expression::ExprClassFromMemberInfo): Pass location information.
31392 (Expression::ResolveLValue): Add new method that resolves an
31395 (Expression::DoResolveLValue): Default invocation calls
31398 (Indexers): New class used to keep track of indexers in a given
31401 (IStackStore): Renamed from LValue, as it did not really describe
31402 what this did. Also ResolveLValue is gone from this interface and
31403 now is part of Expression.
31405 (ElementAccess): Depending on the element access type
31407 * typemanager.cs: Add `indexer_name_type' as a Core type
31408 (System.Runtime.CompilerServices.IndexerNameAttribute)
31410 * statement.cs (Goto): Take a location.
31412 2001-10-18 Ravi Pratap <ravi@ximian.com>
31414 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31415 if two delegates are compatible.
31417 (NewDelegate::DoResolve): Update to take care of the case when
31418 we instantiate a delegate from another delegate.
31420 * typemanager.cs (FindMembers): Don't even try to look up members
31421 of Delegate types for now.
31423 2001-10-18 Ravi Pratap <ravi@ximian.com>
31425 * delegate.cs (NewDelegate): New class to take care of delegate
31428 * expression.cs (New): Split the delegate related code out into
31429 the NewDelegate class.
31431 * delegate.cs (DelegateInvocation): New class to handle delegate
31434 * expression.cs (Invocation): Split out delegate related code into
31435 the DelegateInvocation class.
31437 2001-10-17 Ravi Pratap <ravi@ximian.com>
31439 * expression.cs (New::DoResolve): Implement delegate creation fully
31440 and according to the spec.
31442 (New::DoEmit): Update to handle delegates differently.
31444 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31445 because of which we were printing out arguments in reverse order !
31447 * delegate.cs (VerifyMethod): Implement to check if the given method
31448 matches the delegate.
31450 (FullDelegateDesc): Implement.
31452 (VerifyApplicability): Implement.
31454 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31455 delegate invocations too.
31457 (Invocation::Emit): Ditto.
31459 * ../errors/cs1593.cs : Added.
31461 * ../errors/cs1594.cs : Added.
31463 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31465 2001-10-16 Ravi Pratap <ravi@ximian.com>
31467 * typemanager.cs (intptr_type): Core type for System.IntPtr
31469 (InitCoreTypes): Update for the same.
31471 (iasyncresult_type, asynccallback_type): Ditto.
31473 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31476 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31479 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31480 the builders for the 4 members of a delegate type :-)
31482 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31485 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31487 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31489 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31491 * statement.cs (Break::Emit): Implement.
31492 (Continue::Emit): Implement.
31494 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31495 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31496 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31497 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31500 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31501 properties that track the label for the current loop (begin of the
31502 loop and end of the loop).
31504 2001-10-15 Ravi Pratap <ravi@ximian.com>
31506 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31507 use of emitting anything at all.
31509 * class.cs, rootcontext.cs : Get rid of calls to the same.
31511 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31513 (Populate): Define the constructor correctly and set the implementation
31516 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31519 (AddDelegateType): Implement.
31521 (IsDelegateType): Implement helper method.
31523 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31525 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31526 and accordingly handle it.
31528 * delegate.cs (Populate): Take TypeContainer argument.
31529 Implement bits to define the Invoke method. However, I still haven't figured out
31530 how to take care of the native int bit :-(
31532 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31533 Qualify the name of the delegate, not its return type !
31535 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31538 (StandardConversionExists): Checking for array types turns out to be recursive.
31540 (ConvertReferenceExplicit): Implement array conversion.
31542 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31544 2001-10-12 Ravi Pratap <ravi@ximian.com>
31546 * cs-parser.jay (delegate_declaration): Store the fully qualified
31547 name as it is a type declaration.
31549 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31552 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31553 as TypeContainer::DefineType.
31555 (Populate): Method in which all the definition of the various methods (Invoke)
31558 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31561 (CloseDelegate): Finally creates the delegate.
31563 * class.cs (TypeContainer::DefineType): Update to define delegates.
31564 (Populate, Emit and CloseType): Do the same thing here too.
31566 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31567 delegates in all these operations.
31569 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31571 * expression.cs: LocalTemporary: a new expression used to
31572 reference a temporary that has been created.
31574 * assign.cs: Handle PropertyAccess back here, so that we can
31575 provide the proper semantic access to properties.
31577 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31578 a few more explicit conversions.
31580 * modifiers.cs: `NEW' modifier maps to HideBySig.
31582 * expression.cs (PropertyExpr): Make this into an
31583 ExpressionStatement, and support the EmitStatement code path.
31585 Perform get/set error checking, clean up the interface.
31587 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31588 them into toplevel access objects.
31590 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31592 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31595 * typemanager.cs: Keep track here of our PropertyBuilders again to
31596 work around lameness in SRE.
31598 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31600 * expression.cs (LValue::LValueResolve): New method in the
31601 interface, used to perform a second resolution pass for LValues.
31603 (This::DoResolve): Catch the use of this in static methods.
31605 (This::LValueResolve): Implement.
31607 (This::Store): Remove warning, assigning to `this' in structures
31610 (Invocation::Emit): Deal with invocation of
31611 methods on value types. We need to pass the address to structure
31612 methods rather than the object itself. (The equivalent code to
31613 emit "this" for structures leaves the entire structure on the
31614 stack instead of a pointer to it).
31616 (ParameterReference::DoResolve): Compute the real index for the
31617 argument based on whether the method takes or not a `this' pointer
31618 (ie, the method is static).
31620 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31621 value types returned from functions when we need to invoke a
31622 method on the sturcture.
31625 2001-10-11 Ravi Pratap <ravi@ximian.com>
31627 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31628 defining the type in the Modulebuilder or Typebuilder. This is to take
31629 care of nested types which need to be defined on the TypeBuilder using
31630 DefineNestedMethod.
31632 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31633 methods in RootContext, only ported to be part of TypeContainer.
31635 (TypeContainer::GetInterfaceOrClass): Ditto.
31637 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31639 * interface.cs (Interface::DefineInterface): New method. Does exactly
31640 what RootContext.CreateInterface did earlier, only it takes care of nested types
31643 (Interface::GetInterfaces): Move from RootContext here and port.
31645 (Interface::GetInterfaceByName): Same here.
31647 * rootcontext.cs (ResolveTree): Re-write.
31649 (PopulateTypes): Re-write.
31651 * class.cs (TypeContainer::Populate): Populate nested types too.
31652 (TypeContainer::Emit): Emit nested members too.
31654 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31655 instead just use the name argument passed in as it is already fully
31658 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31659 to TypeContainer mapping to see if a type is user-defined.
31661 * class.cs (TypeContainer::CloseType): Implement.
31663 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31664 the default constructor.
31666 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31669 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31671 * interface.cs (CloseType): Create the type here.
31673 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31676 Remove all the methods which are now in TypeContainer.
31678 2001-10-10 Ravi Pratap <ravi@ximian.com>
31680 * delegate.cs (Define): Re-write bits to define the delegate
31683 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31685 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31687 * expression.cs (ImplicitReferenceConversion): handle null as well
31688 as a source to convert to any reference type.
31690 * statement.cs (Return): Perform any implicit conversions to
31691 expected return type.
31693 Validate use of return statement.
31695 * codegen.cs (EmitContext): Pass the expected return type here.
31697 * class.cs (Method, Constructor, Property): Pass expected return
31698 type to EmitContext.
31700 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31702 * expression.cs: Make DoResolve take an EmitContext instead of a
31705 Replaced `l' and `location' for `loc', for consistency.
31707 (Error, Warning): Remove unneeded Tc argument.
31709 * assign.cs, literal.cs, constant.cs: Update to new calling
31712 * codegen.cs: EmitContext now contains a flag indicating whether
31713 code is being generated in a static method or not.
31715 * cs-parser.jay: DecomposeQI, new function that replaces the old
31716 QualifiedIdentifier. Now we always decompose the assembled
31717 strings from qualified_identifier productions into a group of
31720 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31722 * rootcontext.cs: Deal with field-less struct types correctly now
31723 by passing the size option to Define Type.
31725 * class.cs: Removed hack that created one static field.
31727 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31729 * statement.cs: Moved most of the code generation here.
31731 2001-10-09 Ravi Pratap <ravi@ximian.com>
31733 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31736 (ElementAccess): Remove useless bits for now - keep checks as the spec
31739 2001-10-08 Ravi Pratap <ravi@ximian.com>
31741 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31742 and start performing checks according to the spec.
31744 2001-10-07 Ravi Pratap <ravi@ximian.com>
31746 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31747 rank_specifiers instead.
31749 (rank_specifiers): Change the order in which the rank specifiers are stored
31751 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31753 * expression.cs (ElementAccess): Implement the LValue interface too.
31755 2001-10-06 Ravi Pratap <ravi@ximian.com>
31757 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31758 except that user defined conversions are not included.
31760 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31761 perform the conversion of the return type, if necessary.
31763 (New::DoResolve): Check whether we are creating an array or an object
31764 and accordingly do the needful.
31766 (New::Emit): Same here.
31768 (New::DoResolve): Implement guts of array creation.
31770 (New::FormLookupType): Helper function.
31772 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31774 * codegen.cs: Removed most of the code generation here, and move the
31775 corresponding code generation bits to the statement classes.
31777 Added support for try/catch/finalize and throw.
31779 * cs-parser.jay: Added support for try/catch/finalize.
31781 * class.cs: Catch static methods having the flags override,
31782 virtual or abstract.
31784 * expression.cs (UserCast): This user cast was not really doing
31785 what it was supposed to do. Which is to be born in fully resolved
31786 state. Parts of the resolution were being performed at Emit time!
31790 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31792 * expression.cs: Implicity convert the result from UserCast.
31794 2001-10-05 Ravi Pratap <ravi@ximian.com>
31796 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31797 prevented it from working correctly.
31799 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31800 merely ConvertImplicit.
31802 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31804 * typemanager.cs: Make the LookupTypeContainer function static,
31805 and not per-instance.
31807 * class.cs: Make static FindMembers (the one that takes a Type
31810 * codegen.cs: Add EmitForeach here.
31812 * cs-parser.jay: Make foreach a toplevel object instead of the
31813 inline expansion, as we need to perform semantic analysis on it.
31815 2001-10-05 Ravi Pratap <ravi@ximian.com>
31817 * expression.cs (Expression::ImplicitUserConversion): Rename to
31818 UserDefinedConversion.
31820 (Expression::UserDefinedConversion): Take an extra argument specifying
31821 whether we look for explicit user conversions too.
31823 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31825 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31827 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31828 with the appropriate arguments.
31830 * cs-parser.jay (cast_expression): Record location too.
31832 * expression.cs (Cast): Record location info.
31834 (Expression::ConvertExplicit): Take location argument.
31836 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31837 to determine if we are doing explicit conversions.
31839 (UserCast::Emit): Update accordingly.
31841 (Expression::ConvertExplicit): Report an error if everything fails.
31843 * ../errors/cs0030.cs : Add.
31845 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31847 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31848 virtual and newslot bits.
31850 * class.cs (TypeContainer::RegisterRequiredImplementations):
31851 Record methods we need.
31853 (TypeContainer::MakeKey): Helper function to make keys for
31854 MethodBases, since the Methodbase key is useless.
31856 (TypeContainer::Populate): Call RegisterRequiredImplementations
31857 before defining the methods.
31859 Create a mapping for method_builders_to_methods ahead of time
31860 instead of inside a tight loop.
31862 (::RequireMethods): Accept an object as the data to set into the
31863 hashtable so we can report interface vs abstract method mismatch.
31865 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31867 * report.cs: Make all of it static.
31869 * rootcontext.cs: Drop object_type and value_type computations, as
31870 we have those in the TypeManager anyways.
31872 Drop report instance variable too, now it is a global.
31874 * driver.cs: Use try/catch on command line handling.
31876 Add --probe option to debug the error reporting system with a test
31879 * report.cs: Add support for exiting program when a probe
31880 condition is reached.
31882 2001-10-03 Ravi Pratap <ravi@ximian.com>
31884 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31885 we do a forcible conversion regardless of type, to check if
31886 ForceConversion returns a null.
31888 (Binary::error19): Use location to report error.
31890 (Unary::error23): Use location here too.
31892 * ../errors/cs0019.cs : Check in.
31894 * ../errors/cs0023.cs : Check in.
31896 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31897 case of a non-null MethodInfo object with a length of 0 !
31899 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31900 an applicable member - according to the spec :-)
31901 Also fix logic to find members in base types.
31903 (Unary::ResolveOperator): Same here.
31905 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31906 as I was getting thoroughly confused between this and error19 :-)
31908 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31909 (::FindMostEncompassedType): Implement.
31910 (::FindMostEncompassingType): Implement.
31911 (::StandardConversionExists): Implement.
31913 (UserImplicitCast): Re-vamp. We now need info about most specific
31914 source and target types so that we can do the necessary conversions.
31916 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31917 mathematical union with no duplicates.
31919 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31921 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31922 in order from base classes to child classes, so that we can in
31923 child classes look up in our parent for method names and
31924 attributes (required for handling abstract, virtual, new, override
31925 constructs: we need to instrospect our base class, and if we dont
31926 populate the classes in order, the introspection might be
31927 incorrect. For example, a method could query its parent before
31928 the parent has any methods and would determine that the parent has
31929 no abstract methods (while it could have had them)).
31931 (RootContext::CreateType): Record the order in which we define the
31934 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31936 * class.cs (TypeContainer::Populate): Also method definitions can
31937 fail now, keep track of this.
31939 (TypeContainer::FindMembers): Implement support for
31940 DeclaredOnly/noDeclaredOnly flag.
31942 (Constructor::Emit) Return the ConstructorBuilder.
31944 (Method::Emit) Return the MethodBuilder.
31945 Check for abstract or virtual methods to be public.
31947 * rootcontext.cs (RootContext::CreateType): Register all the
31948 abstract methods required for the class to be complete and the
31949 interface methods that must be implemented.
31951 * cs-parser.jay: Report error 501 (method requires body if it is
31952 not marked abstract or extern).
31954 * expression.cs (TypeOf::Emit): Implement.
31956 * typemanager.cs: runtime_handle_type, new global type.
31958 * class.cs (Property::Emit): Generate code for properties.
31960 2001-10-02 Ravi Pratap <ravi@ximian.com>
31962 * expression.cs (Unary::ResolveOperator): Find operators on base type
31963 too - we now conform exactly to the spec.
31965 (Binary::ResolveOperator): Same here.
31967 * class.cs (Operator::Define): Fix minor quirk in the tests.
31969 * ../errors/cs0215.cs : Added.
31971 * ../errors/cs0556.cs : Added.
31973 * ../errors/cs0555.cs : Added.
31975 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31977 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31978 single integer which is really efficient
31980 2001-10-01 Ravi Pratap <ravi@ximian.com>
31982 * expression.cs (Expression::ImplicitUserConversion): Use location
31983 even in the case when we are examining True operators.
31985 * class.cs (Operator::Define): Perform extensive checks to conform
31986 with the rules for operator overloading in the spec.
31988 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31989 some of the other conversions mentioned in the spec.
31991 * typemanager.cs (array_type): New static member for the System.Array built-in
31994 (cloneable_interface): For System.ICloneable interface.
31996 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31997 we start resolving the tree and populating types.
31999 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
32001 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32003 * expression.cs (Expression::ExprClassFromMemberInfo,
32004 Expression::Literalize): Create literal expressions from
32005 FieldInfos which are literals.
32007 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
32008 type casts, because they were wrong. The test suite in tests
32011 (ImplicitNumericConversion): ushort to ulong requires a widening
32014 Int32 constant to long requires widening cast as well.
32016 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
32017 for integers because the type on the stack is not i4.
32019 2001-09-30 Miguel de Icaza <miguel@ximian.com>
32021 * expression.cs (report118): require location argument.
32023 * parameter.cs: Do not dereference potential null value.
32025 * class.cs: Catch methods that lack the `new' keyword when
32026 overriding a name. Report warnings when `new' is used without
32027 anything being there to override.
32029 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
32031 * class.cs: Only add constructor to hashtable if it is non-null
32032 (as now constructors can fail on define).
32034 (TypeManager, Class, Struct): Take location arguments.
32036 Catch field instance initialization in structs as errors.
32038 accepting_filter: a new filter for FindMembers that is static so
32039 that we dont create an instance per invocation.
32041 (Constructor::Define): Catch errors where a struct constructor is
32044 * cs-parser.jay: Pass location information for various new
32047 * delegate.cs (Delegate): take a location argument.
32049 * driver.cs: Do not call EmitCode if there were problesm in the
32050 Definition of the types, as many Builders wont be there.
32052 * decl.cs (Decl::Decl): Require a location argument.
32054 * cs-tokenizer.cs: Handle properly hex constants that can not fit
32055 into integers, and find the most appropiate integer for it.
32057 * literal.cs: Implement ULongLiteral.
32059 * rootcontext.cs: Provide better information about the location of
32060 failure when CreateType fails.
32062 2001-09-29 Miguel de Icaza <miguel@ximian.com>
32064 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
32067 * expression.cs (Binary::CheckShiftArguments): Add missing type
32069 (Binary::ResolveOperator): Add type to the logical and and logical
32070 or, Bitwise And/Or and Exclusive Or code paths, it was missing
32073 (Binary::DoNumericPromotions): In the case where either argument
32074 is ulong (and most signed types combined with ulong cause an
32075 error) perform implicit integer constant conversions as well.
32077 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32079 * expression.cs (UserImplicitCast): Method should always be
32081 (Invocation::BetterConversion): Simplified test for IntLiteral.
32083 (Expression::ImplicitNumericConversion): Split this routine out.
32084 Put the code that performs implicit constant integer conversions
32087 (Expression::Resolve): Become a wrapper around DoResolve so we can
32088 check eclass and type being set after resolve.
32090 (Invocation::Badness): Remove this dead function
32092 (Binary::ResolveOperator): Do not compute the expensive argumnets
32093 unless we have a union for it.
32095 (Probe::Emit): Is needs to do an isinst and then
32096 compare against null.
32098 (::CanConvert): Added Location argument. If the Location argument
32099 is null (Location.Null), then we do not report errors. This is
32100 used by the `probe' mechanism of the Explicit conversion. We do
32101 not want to generate an error for something that the user
32102 explicitly requested to be casted. But the pipeline for an
32103 explicit cast first tests for potential implicit casts.
32105 So for now, if the Location is null, it means `Probe only' to
32106 avoid adding another argument. Might have to revise this
32109 (ClassCast): New class used to type cast objects into arbitrary
32110 classes (used in Explicit Reference Conversions).
32112 Implement `as' as well.
32114 Reverted all the patches from Ravi below: they were broken:
32116 * The use of `level' as a mechanism to stop recursive
32117 invocations is wrong. That was there just to catch the
32118 bug with a strack trace but not as a way of addressing
32121 To fix the problem we have to *understand* what is going
32122 on and the interactions and come up with a plan, not
32123 just get things going.
32125 * The use of the type conversion cache that I proposed
32126 last night had an open topic: How does this work across
32127 protection domains. A user defined conversion might not
32128 be public in the location where we are applying the
32129 conversion, a different conversion might be selected
32130 (ie, private A->B (better) but public B->A (worse),
32131 inside A, A->B applies, but outside it, B->A will
32134 * On top of that (ie, even if the above is solved),
32135 conversions in a cache need to be abstract. Ie, `To
32136 convert from an Int to a Short use an OpcodeCast', not
32137 `To convert from an Int to a Short use the OpcodeCast on
32138 the variable 5' (which is what this patch was doing).
32140 2001-09-28 Ravi Pratap <ravi@ximian.com>
32142 * expression.cs (Invocation::ConversionExists): Re-write to use
32143 the conversion cache
32145 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
32146 cache all conversions done, not just user-defined ones.
32148 (Invocation::BetterConversion): The real culprit. Use ConversionExists
32149 to determine if a conversion exists instead of acutually trying to
32150 perform the conversion. It's faster too.
32152 (Expression::ConvertExplicit): Modify to use ConversionExists to check
32153 and only then attempt the implicit conversion.
32155 2001-09-28 Ravi Pratap <ravi@ximian.com>
32157 * expression.cs (ConvertImplicit): Use a cache for conversions
32158 already found. Check level of recursion and bail out if necessary.
32160 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32162 * typemanager.cs (string_concat_string_string, string_concat_object_object):
32163 Export standard methods that we expect for string operations.
32165 * statement.cs (Block::UsageWarning): Track usage of variables and
32166 report the errors for not used variables.
32168 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
32171 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32173 * codegen.cs: remove unnneded code
32175 * expression.cs: Removed BuiltinTypeAccess class
32177 Fix the order in which implicit conversions are
32180 The previous fixed dropped support for boxed conversions (adding a
32181 test to the test suite now)
32183 (UserImplicitCast::CanConvert): Remove test for source being null,
32184 that code is broken. We should not feed a null to begin with, if
32185 we do, then we should track the bug where the problem originates
32186 and not try to cover it up here.
32188 Return a resolved expression of type UserImplicitCast on success
32189 rather than true/false. Ravi: this is what I was talking about,
32190 the pattern is to use a static method as a "constructor" for
32193 Also, do not create arguments until the very last minute,
32194 otherwise we always create the arguments even for lookups that
32195 will never be performed.
32197 (UserImplicitCast::Resolve): Eliminate, objects of type
32198 UserImplicitCast are born in a fully resolved state.
32200 * typemanager.cs (InitCoreTypes): Init also value_type
32201 (System.ValueType).
32203 * expression.cs (Cast::Resolve): First resolve the child expression.
32205 (LValue): Add new method AddressOf to be used by
32208 Change the argument of Store to take an EmitContext instead of an
32209 ILGenerator, because things like FieldExpr need to be able to call
32210 their children expression to generate the instance code.
32212 (Expression::Error, Expression::Warning): Sugar functions for
32215 (Expression::MemberLookup): Accept a TypeContainer instead of a
32216 Report as the first argument.
32218 (Expression::ResolvePrimary): Killed. I still want to improve
32219 this as currently the code is just not right.
32221 (Expression::ResolveMemberAccess): Simplify, but it is still
32224 (Unary::Resolve): Catch errors in AddressOf operators.
32226 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
32227 index to a byte for the short-version, or the compiler will choose
32228 the wrong Emit call, which generates the wrong data.
32230 (ParameterReference::Emit, ::Store): same.
32232 (FieldExpr::AddressOf): Implement.
32234 * typemanager.cs: TypeManager: made public variable instead of
32237 * driver.cs: document --fatal.
32239 * report.cs (ErrorMessage, WarningMessage): new names for the old
32240 Error and Warning classes.
32242 * cs-parser.jay (member_access): Turn built-in access to types
32243 into a normal simplename
32245 2001-09-27 Ravi Pratap <ravi@ximian.com>
32247 * expression.cs (Invocation::BetterConversion): Fix to cope
32248 with q being null, since this was introducing a bug.
32250 * expression.cs (ConvertImplicit): Do built-in conversions first.
32252 2001-09-27 Ravi Pratap <ravi@ximian.com>
32254 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32256 2001-09-27 Ravi Pratap <ravi@ximian.com>
32258 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32259 I had introduced long ago (what's new ?).
32261 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32262 the work of all the checking.
32263 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32264 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32266 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32267 that is the right way.
32269 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32270 overloading resolution. Use everywhere instead of cutting and pasting code.
32272 (Binary::ResolveOperator): Use MakeUnionSet.
32274 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32275 we have to convert to bool types. Not complete yet.
32277 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32279 * typemanager.cs (TypeManager::CSharpName): support ushort.
32281 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32282 to provide an expression that performsn an implicit constant int
32283 conversion (section 6.1.6).
32284 (Expression::ConvertImplicitRequired): Reworked to include
32285 implicit constant expression conversions.
32287 (Expression::ConvertNumericExplicit): Finished.
32289 (Invocation::Emit): If InstanceExpression is null, then it means
32290 that we perform a call on this.
32292 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32294 * expression.cs (Unary::Emit): Remove some dead code.
32295 (Probe): Implement Resolve and Emit for `is'.
32296 (Expression::ConvertImplicitRequired): Attempt to do constant
32297 expression conversions here. Maybe should be moved to
32298 ConvertImplicit, but I am not sure.
32299 (Expression::ImplicitLongConstantConversionPossible,
32300 Expression::ImplicitIntConstantConversionPossible): New functions
32301 that tell whether is it possible to apply an implicit constant
32302 expression conversion.
32304 (ConvertNumericExplicit): Started work on explicit numeric
32307 * cs-parser.jay: Update operator constants.
32309 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32310 (Parameters::GetSignature): Hook up VerifyArgs here.
32311 (Parameters::VerifyArgs): Verifies that no two arguments have the
32314 * class.cs (Operator): Update the operator names to reflect the
32315 ones that the spec expects (as we are just stringizing the
32318 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32319 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32320 previous usage did only work for our methods.
32321 (Expression::ConvertImplicit): Handle decimal implicit numeric
32322 conversions as well.
32323 (Expression::InternalTypeConstructor): Used to invoke constructors
32324 on internal types for default promotions.
32326 (Unary::Emit): Implement special handling for the pre/post
32327 increment/decrement for overloaded operators, as they need to have
32328 the same semantics as the other operators.
32330 (Binary::ResolveOperator): ditto.
32331 (Invocation::ConversionExists): ditto.
32332 (UserImplicitCast::Resolve): ditto.
32334 2001-09-26 Ravi Pratap <ravi@ximian.com>
32336 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32337 operator, return after emitting body. Regression tests pass again !
32339 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32340 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32341 (Invocation::OverloadResolve): Ditto.
32342 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32344 * everywhere : update calls to the above methods accordingly.
32346 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32348 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32350 * expression.cs (ExpressionStatement): New base class used for
32351 expressions that can appear in statements, so that we can provide
32352 an alternate path to generate expression that do not leave a value
32355 (Expression::Emit, and all the derivatives): We no longer return
32356 whether a value is left on the stack or not. Every expression
32357 after being emitted leaves a single value on the stack.
32359 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32360 facilties of ExpressionStatement if possible.
32362 * cs-parser.jay: Update statement_expression.
32364 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32366 * driver.cs: Change the wording of message
32368 2001-09-25 Ravi Pratap <ravi@ximian.com>
32370 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32371 the type of the expression to the return type of the method if
32372 we have an overloaded operator match ! The regression tests pass again !
32373 (Unary::ResolveOperator): Ditto.
32375 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32376 to find "op_Implicit", not "implicit" ;-)
32377 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32378 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32380 * everywhere : Correct calls to the above accordingly.
32382 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32383 (ConvertImplicit): Do user-defined conversion if it exists.
32385 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32387 * assign.cs: track location.
32388 (Resolve): Use implicit conversions on assignment.
32390 * literal.cs: Oops. Not good, Emit of short access values should
32391 pass (Bytes) or the wrong argument will be selected.
32393 * expression.cs (Unary::Emit): Emit code for -expr.
32395 (Unary::ResolveOperator): Handle `Substract' for non-constants
32396 (substract from zero from the non-constants).
32397 Deal with Doubles as well.
32399 (Expression::ConvertImplicitRequired): New routine that reports an
32400 error if no implicit conversion exists.
32402 (Invocation::OverloadResolve): Store the converted implicit
32403 expressions if we make them
32405 2001-09-24 Ravi Pratap <ravi@ximian.com>
32407 * class.cs (ConstructorInitializer): Take a Location argument.
32408 (ConstructorBaseInitializer): Same here.
32409 (ConstructorThisInitializer): Same here.
32411 * cs-parser.jay : Update all calls accordingly.
32413 * expression.cs (Unary, Binary, New): Take location argument.
32414 Update accordingly everywhere.
32416 * cs-parser.jay : Update all calls to the above to take a location
32419 * class.cs : Ditto.
32421 2001-09-24 Ravi Pratap <ravi@ximian.com>
32423 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32424 (Invocation::BetterConversion): Same here
32425 (Invocation::ConversionExists): Ditto.
32427 (Invocation::ConversionExists): Implement.
32429 2001-09-22 Ravi Pratap <ravi@ximian.com>
32431 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32432 Also take an additional TypeContainer argument.
32434 * All over : Pass in TypeContainer as argument to OverloadResolve.
32436 * typemanager.cs (CSharpName): Update to check for the string type and return
32439 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32442 2001-09-21 Ravi Pratap <ravi@ximian.com>
32444 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32445 (Invocation::BetterFunction): Implement.
32446 (Invocation::BetterConversion): Implement.
32447 (Invocation::ConversionExists): Skeleton, no implementation yet.
32449 Okay, things work fine !
32451 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32453 * typemanager.cs: declare and load enum_type, delegate_type and
32456 * expression.cs (Expression::Emit): Now emit returns a value that
32457 tells whether a value is left on the stack or not. This strategy
32458 might be reveted tomorrow with a mechanism that would address
32459 multiple assignments.
32460 (Expression::report118): Utility routine to report mismatches on
32463 (Unary::Report23): Report impossible type/operator combination
32466 (Unary::IsIncrementableNumber): Whether the type can be
32467 incremented or decremented with add.
32468 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32470 (Unary::ResolveOperator): Implement ++, !, ~,
32472 (Invocation::Emit): Deal with new Emit convetion.
32474 * All Expression derivatives: Updated their Emit method to return
32475 whether they leave values on the stack or not.
32477 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32478 stack for expressions that are statements.
32480 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32482 * expression.cs (LValue): New interface. Must be implemented by
32484 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32487 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32488 interface for generating code, simplifies the code.
32490 2001-09-20 Ravi Pratap <ravi@ximian.com>
32492 * expression.cs (everywhere): Comment out return statements in ::Resolve
32493 methods to avoid the warnings.
32495 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32497 * driver.cs (parse): Report error 2001 if we can not open the
32500 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32503 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32506 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32507 otherwise nested blocks end up with the same index.
32509 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32511 * expression.cs: Instead of having FIXMEs in the Resolve
32512 functions, throw exceptions so it is obvious that we are facing a
32515 * cs-parser.jay (invocation_expression): Pass Location information.
32517 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32518 Use a basename for those routines because .NET does not like paths
32521 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32524 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32526 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32527 are loading the correct data types (throws an exception if not).
32528 (TypeManager::InitCoreTypes): Use CoreLookupType
32530 * expression.cs (Unary::ResolveOperator): return the child
32531 expression for expressions which are just +expr.
32532 (Unary::ResolveOperator): Return negative literals for -LITERAL
32533 expressions (otherwise they are Unary {Literal}).
32534 (Invocation::Badness): Take into account `Implicit constant
32535 expression conversions'.
32537 * literal.cs (LongLiteral): Implement long literal class.
32538 (IntLiteral): export the `Value' of the intliteral.
32540 2001-09-19 Ravi Pratap <ravi@ximian.com>
32542 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32544 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32545 instead of 'Operator'
32547 * expression.cs (Binary::ResolveOperator): Update accordingly.
32548 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32551 * cs-parser.jay (unary_expression): Update to use the new names.
32553 * gen-treedump.cs (GetUnary): Same here.
32555 * expression.cs (Unary::Resolve): Implement.
32556 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32557 operators are found instead of making noise ;-)
32558 (Unary::ResolveOperator): New method to do precisely the same thing which
32559 Binary::ResolveOperator does for Binary expressions.
32560 (Unary.method, .Arguments): Add.
32561 (Unary::OperName): Implement.
32562 (Unary::ForceConversion): Copy and Paste !
32564 * class.cs (Operator::Define): Fix a small bug for the case when we have
32567 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32568 for the inbuilt operators. Only overloading works for now ;-)
32570 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32572 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32573 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32575 * expression.cs (This::Emit): Implement.
32576 (This::Resolve): Implement.
32577 (TypeOf:Resolve): Implement.
32578 (Expression::ResolveSimpleName): Add an implicit this to instance
32580 (MemberAccess::Resolve): Deal with Parameters and Fields.
32581 Bind instance variable to Field expressions.
32582 (FieldExpr::Instance): New field used to track the expression that
32583 represents the object instance.
32584 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32586 (FieldExpr::Emit): Implement.
32588 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32589 the last instruction contains a return opcode to avoid generating
32590 the last `ret' instruction (this generates correct code, and it is
32591 nice to pass the peverify output).
32593 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32594 initializer for static and instance variables.
32595 (Constructor::Emit): Allow initializer to be null in the case of
32596 static constructors. Only emit initializer for instance
32599 (TypeContainer::FindMembers): Return a null array if there are no
32602 Also fix the code for the MemberTypes.Method branch, as it was not
32603 scanning that for operators (or tried to access null variables before).
32605 * assign.cs (Assign::Emit): Handle instance and static fields.
32609 * driver.cs: Stop compilation if there are parse errors.
32611 * cs-parser.jay (constructor_declaration): Provide default base
32612 initializer for non-static constructors.
32613 (constructor_declarator): Do not provide a default base
32614 initializers if none was specified.
32615 Catch the fact that constructors should not have parameters.
32617 * class.cs: Do not emit parent class initializers for static
32618 constructors, that should be flagged as an error.
32620 2001-09-18 Ravi Pratap <ravi@ximian.com>
32622 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32623 Move back code into TypeContainer::Populate.
32625 2001-09-18 Ravi Pratap <ravi@ximian.com>
32627 * class.cs (TypeContainer::AddConstructor): Fix the check to
32628 compare against Name, not Basename.
32629 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32631 * cs-parser.jay : Update accordingly.
32633 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32634 for methods, don't forget to look into the operators too.
32635 (RegisterMethodBuilder): Helper method to take care of this for
32636 methods, constructors and operators.
32637 (Operator::Define): Completely revamp.
32638 (Operator.OperatorMethod, MethodName): New fields.
32639 (TypeContainer::Populate): Move the registering of builders into
32640 RegisterMethodBuilder.
32641 (Operator::Emit): Re-write.
32643 * expression.cs (Binary::Emit): Comment out code path to emit method
32644 invocation stuff for the case when we have a user defined operator. I am
32645 just not able to get it right !
32647 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32649 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32652 (Expression::MemberLookup): Provide a version that allows to
32653 specify the MemberTypes and BindingFlags.
32655 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32656 so it was not fetching variable information from outer blocks.
32658 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32659 Beforefieldinit as it was buggy.
32661 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32662 that Ravi put here.
32664 * class.cs (Constructor::Emit): Only emit if block is not null.
32665 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32666 deal with this by semantically definining it as if the user had
32669 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32670 constructors as we now "emit" them at a higher level.
32672 (TypeContainer::DefineDefaultConstructor): Used to define the
32673 default constructors if none was provided.
32675 (ConstructorInitializer): Add methods Resolve and Emit.
32677 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32679 2001-09-17 Ravi Pratap <ravi@ximian.com>
32681 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32682 the default constructor builder with our hashtable for methodbuilders
32685 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32686 and argument_count is 0 in which case we have a match.
32687 (Binary::ResolveOperator): More null checking and miscellaneous coding
32690 2001-09-17 Ravi Pratap <ravi@ximian.com>
32692 * rootcontext.cs (IsNameSpace): Compare against null.
32694 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32696 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32697 and Unary::Operator.
32699 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32702 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32703 we have overloaded operators.
32704 (Binary::ResolveOperator): Implement the part which does the operator overload
32707 * class.cs (Operator::Emit): Implement.
32708 (TypeContainer::Emit): Emit the operators we have too.
32710 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32711 the case when we have a user-defined operator.
32713 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32715 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32717 2001-09-16 Ravi Pratap <ravi@ximian.com>
32719 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32720 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32721 (Constructor::Emit): Implement.
32722 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32723 if we have no work to do.
32724 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32727 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32728 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32730 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32733 2001-09-15 Ravi Pratap <ravi@ximian.com>
32735 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32737 (Tree::RecordNamespace): Method to do what the name says ;-)
32738 (Tree::Namespaces): Property to get at the namespaces hashtable.
32740 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32743 * rootcontext.cs (IsNamespace): Fixed it :-)
32745 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32747 * class.cs (TypeContainer::FindMembers): Add support for
32749 (MethodCore): New class that encapsulates both the shared aspects
32750 of a Constructor and a Method.
32751 (Method, Constructor): Factored pieces into MethodCore.
32753 * driver.cs: Added --fatal which makes errors throw exceptions.
32754 Load System assembly as well as part of the standard library.
32756 * report.cs: Allow throwing exceptions on errors for debugging.
32758 * modifiers.cs: Do not use `parent', instead use the real type
32759 container to evaluate permission settings.
32761 * class.cs: Put Ravi's patch back in. He is right, and we will
32762 have to cope with the
32764 2001-09-14 Ravi Pratap <ravi@ximian.com>
32766 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32767 FamORAssem, not FamANDAssem.
32769 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32771 * driver.cs: Added --parse option that only parses its input files
32774 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32775 incorrect. IsTopLevel is not used to tell whether an object is
32776 root_types or not (that can be achieved by testing this ==
32777 root_types). But to see if this is a top-level *class* (not
32778 necessarly our "toplevel" container).
32780 2001-09-14 Ravi Pratap <ravi@ximian.com>
32782 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32783 parent instead of a direct call to GetType.
32785 2001-09-14 Ravi Pratap <ravi@ximian.com>
32787 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32788 Modifiers.TypeAttr. This should just be a call to that method.
32790 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32791 object so that we can determine if we are top-level or not.
32793 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32796 * enum.cs (Enum::Define): Ditto.
32798 * modifiers.cs (FieldAttr): Re-write.
32800 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32801 (TypeContainer::HaveStaticConstructor): New property to provide access
32802 to precisely that info.
32804 * modifiers.cs (MethodAttr): Re-write.
32805 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32807 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32808 of top-level types as claimed.
32810 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32812 * expression.cs (MemberLookup): Fruitless attempt to lookup
32813 constructors. Maybe I need to emit default constructors? That
32814 might be it (currently .NET emits this for me automatically).
32815 (Invocation::OverloadResolve): Cope with Arguments == null.
32816 (Invocation::EmitArguments): new function, shared by the new
32817 constructor and us.
32818 (Invocation::Emit): Handle static and instance methods. Emit
32819 proper call instruction for virtual or non-virtual invocations.
32820 (New::Emit): Implement.
32821 (New::Resolve): Implement.
32822 (MemberAccess:Resolve): Implement.
32823 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32824 to track instances.
32825 (FieldExpr::Resolve): Set type.
32827 * support.cs: Handle empty arguments.
32829 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32830 SimpleLookup): Auxiliary routines to help parse a qualifier
32833 Update qualifier_identifier rule.
32835 * codegen.cs: Removed debugging messages.
32837 * class.cs: Make this a global thing, this acts just as a "key" to
32838 objects that we might have around.
32840 (Populate): Only initialize method_builders_to_methods once.
32842 * expression.cs (PropertyExpr): Initialize type from the
32845 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32846 Resolve pattern. Attempt to implicitly convert value to boolean.
32849 * expression.cs: Set the type for the int32/int32 argument case.
32850 (Binary::ResolveOperator): Set the return type to boolean for
32851 comparission operators
32853 * typemanager.cs: Remove debugging print code.
32855 (Invocation::Resolve): resolve type.
32857 * class.cs: Allocate a MemberInfo of the correct size, as the code
32858 elsewhere depends on the test to reflect the correct contents.
32860 (Method::) Keep track of parameters, due to System.Reflection holes
32862 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32865 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32866 of the exact size and return that.
32868 (Class::LookupMethodByBuilder): New function that maps
32869 MethodBuilders to its methods. Required to locate the information
32870 on methods because System.Reflection bit us again.
32872 * support.cs: New file, contains an interface ParameterData and
32873 two implementations: ReflectionParameters and InternalParameters
32874 used to access Parameter information. We will need to grow this
32877 * expression.cs (Invocation::GetParameterData): implement a cache
32878 and a wrapper around the ParameterData creation for methods.
32879 (Invocation::OverloadResolve): Use new code.
32881 2001-09-13 Ravi Pratap <ravi@ximian.com>
32883 * class.cs (TypeContainer::EmitField): Remove and move into
32884 (Field::Define): here and modify accordingly.
32885 (Field.FieldBuilder): New member.
32886 (TypeContainer::Populate): Update accordingly.
32887 (TypeContainer::FindMembers): Implement.
32889 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32891 * statement.cs: (VariableInfo::VariableType): New field to be
32892 initialized with the full type once it is resolved.
32894 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32896 * parameter.cs (GetParameterInfo): Use a type cache to compute
32897 things only once, and to reuse this information
32899 * expression.cs (LocalVariableReference::Emit): Implement.
32900 (OpcodeCast::Emit): fix.
32902 (ParameterReference::Resolve): Implement.
32903 (ParameterReference::Emit): Implement.
32905 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32906 that are expressions need to stay as Expressions.
32908 * typemanager.cs (CSharpName): Returns the C# name of a type if
32911 * expression.cs (Expression::ConvertImplicit): New function that
32912 implements implicit type conversions.
32914 (Expression::ImplicitReferenceConversion): Implements implicit
32915 reference conversions.
32917 (EmptyCast): New type for transparent casts.
32919 (OpcodeCast): New type for casts of types that are performed with
32920 a sequence of bytecodes.
32922 (BoxedCast): New type used for casting value types into reference
32923 types. Emits a box opcode.
32925 (Binary::DoNumericPromotions): Implements numeric promotions of
32926 and computation of the Binary::Type.
32928 (Binary::EmitBranchable): Optimization.
32930 (Binary::Emit): Implement code emission for expressions.
32932 * typemanager.cs (TypeManager): Added two new core types: sbyte
32935 2001-09-12 Ravi Pratap <ravi@ximian.com>
32937 * class.cs (TypeContainer::FindMembers): Method which does exactly
32938 what Type.FindMembers does, only we don't have to use reflection. No
32939 implementation yet.
32941 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32942 typecontainer objects as we need to get at them.
32943 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32945 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32946 typecontainer object.
32948 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32949 of just a Report object.
32951 2001-09-11 Ravi Pratap <ravi@ximian.com>
32953 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32955 (TypeContainer::Populate): Now define the delegates of the type too.
32956 (TypeContainer.Delegates): Property to access the list of delegates defined
32959 * delegates.cs (Delegate::Define): Implement partially.
32961 * modifiers.cs (TypeAttr): Handle more flags.
32963 2001-09-11 Ravi Pratap <ravi@ximian.com>
32965 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32967 (Operator::Define): Re-write logic to get types by using the LookupType method
32968 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32969 (Indexer::Define): Ditto.
32970 (Event::Define): Ditto.
32971 (Property::Define): Ditto.
32973 2001-09-10 Ravi Pratap <ravi@ximian.com>
32975 * class.cs (TypeContainer::Populate): Now define operators too.
32976 (TypeContainer.Operators): New property to access the list of operators
32978 (Operator.OperatorMethodBuilder): New member to hold the method builder
32979 for the operator we are defining.
32980 (Operator::Define): Implement.
32982 2001-09-10 Ravi Pratap <ravi@ximian.com>
32984 * class.cs (Event::Define): Make the prefixes of the accessor methods
32985 addOn_ and removeOn_
32987 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32988 of the location being passed in too. Ideally, this should go later since all
32989 error reporting should be done through the Report object.
32991 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32992 (Populate): Iterate thru the indexers we have and define them too.
32993 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32994 for the get and set accessors.
32995 (Indexer::Define): Implement.
32997 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32999 * expression.cs (Binary::Resolve): Beginning of it. I scratched
33000 my previous implementation, did not work.
33002 * typemanager.cs: Add a couple of missing types (the longs).
33004 * literal.cs: Use TypeManager.bool_type instead of getting it.
33006 * expression.cs (EventExpr): New kind of expressions.
33007 (Expressio::ExprClassFromMemberInfo): finish
33009 2001-09-08 Miguel de Icaza <miguel@ximian.com>
33011 * assign.cs: Emit stores to static fields differently.
33013 2001-09-08 Ravi Pratap <ravi@ximian.com>
33015 * Merge in changes and adjust code to tackle conflicts. Backed out my
33016 code in Assign::Resolve ;-)
33018 2001-09-08 Ravi Pratap <ravi@ximian.com>
33020 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
33021 instead Report.Error and also pass in the location.
33022 (CSharpParser::Lexer): New readonly property to return the reference
33023 to the Tokenizer object.
33024 (declare_local_variables): Use Report.Error with location instead of plain
33028 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
33029 (Operator.CheckBinaryOperator): Ditto.
33031 * cs-parser.jay (operator_declarator): Update accordingly.
33033 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
33034 (CheckBinaryOperator): Same here.
33036 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
33037 on the name without any prefixes of namespace names etc. This is because we
33038 already might have something already fully qualified like
33039 'System.Console.WriteLine'
33041 * assign.cs (Resolve): Begin implementation. Stuck ;-)
33043 2001-09-07 Ravi Pratap <ravi@ximian.com>
33045 * cs-tokenizer.cs (location): Return a string which also contains
33048 * expression.cs (ElementAccess): New class for expressions of the
33049 type 'element access.'
33050 (BaseAccess): New class for expressions of the type 'base access.'
33051 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
33054 * cs-parser.jay (element_access): Implement action.
33055 (base_access): Implement actions.
33056 (checked_expression, unchecked_expression): Implement.
33058 * cs-parser.jay (local_variable_type): Correct and implement.
33059 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
33061 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
33063 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
33064 name and the specifiers.
33066 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
33068 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
33069 making them all public ;-)
33071 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
33074 2001-09-07 Miguel de Icaza <miguel@ximian.com>
33076 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
33078 (FieldExpr, PropertyExprs): New resolved expressions.
33079 (SimpleName::MemberStaticCheck): Perform static checks for access
33080 to non-static fields on static methods. Maybe this should be
33081 generalized for MemberAccesses.
33082 (SimpleName::ResolveSimpleName): More work on simple name
33085 * cs-parser.jay (primary_expression/qualified_identifier): track
33086 the parameter index.
33088 * codegen.cs (CodeGen::Save): Catch save exception, report error.
33089 (EmitContext::EmitBoolExpression): Chain to expression generation
33090 instead of temporary hack.
33091 (::EmitStatementExpression): Put generic expression code generation.
33093 * assign.cs (Assign::Emit): Implement variable assignments to
33094 local variables, parameters and fields.
33096 2001-09-06 Miguel de Icaza <miguel@ximian.com>
33098 * statement.cs (Block::GetVariableInfo): New method, returns the
33099 VariableInfo for a variable name in a block.
33100 (Block::GetVariableType): Implement in terms of GetVariableInfo
33102 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
33103 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
33105 2001-09-06 Ravi Pratap <ravi@ximian.com>
33107 * cs-parser.jay (operator_declaration): Continue on my quest : update
33108 to take attributes argument.
33109 (event_declaration): Ditto.
33110 (enum_declaration): Ditto.
33111 (indexer_declaration): Ditto.
33113 * class.cs (Operator::Operator): Update constructor accordingly.
33114 (Event::Event): Ditto.
33116 * delegate.cs (Delegate::Delegate): Same here.
33118 * enum.cs (Enum::Enum): Same here.
33120 2001-09-05 Ravi Pratap <ravi@ximian.com>
33122 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
33124 * ../tests/cs0658.cs : New file to demonstrate error 0658.
33126 * attribute.cs (Attributes): New class to encapsulate all attributes which were
33127 being passed around as an arraylist.
33128 (Attributes::AddAttribute): Method to add attribute sections.
33130 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
33131 (struct_declaration): Update accordingly.
33132 (constant_declaration): Update.
33133 (field_declaration): Update.
33134 (method_header): Update.
33135 (fixed_parameter): Update.
33136 (parameter_array): Ditto.
33137 (property_declaration): Ditto.
33138 (destructor_declaration): Ditto.
33140 * class.cs (Struct::Struct): Update constructors accordingly.
33141 (Class::Class): Ditto.
33142 (Field::Field): Ditto.
33143 (Method::Method): Ditto.
33144 (Property::Property): Ditto.
33145 (TypeContainer::OptAttribute): update property's return type.
33147 * interface.cs (Interface.opt_attributes): New member.
33148 (Interface::Interface): Update to take the extra Attributes argument.
33150 * parameter.cs (Parameter::Parameter): Ditto.
33152 * constant.cs (Constant::Constant): Ditto.
33154 * interface.cs (InterfaceMemberBase): New OptAttributes field.
33155 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
33156 the attributes as a parameter.
33157 (InterfaceProperty): Update constructor call.
33158 (InterfaceEvent): Ditto.
33159 (InterfaceMethod): Ditto.
33160 (InterfaceIndexer): Ditto.
33162 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
33163 pass the attributes too.
33164 (interface_event_declaration): Ditto.
33165 (interface_property_declaration): Ditto.
33166 (interface_method_declaration): Ditto.
33167 (interface_declaration): Ditto.
33169 2001-09-05 Miguel de Icaza <miguel@ximian.com>
33171 * class.cs (Method::Define): Track the "static Main" definition to
33172 create an entry point.
33174 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
33175 EntryPoint if we find it.
33177 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
33178 (EmitContext::ig): Make this variable public.
33180 * driver.cs: Make the default output file be the first file name
33181 with the .exe extension.
33183 Detect empty compilations
33185 Handle various kinds of output targets. Handle --target and
33186 rename -t to --dumper.
33188 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
33189 methods inherited from Expression return now an Expression. This
33190 will is used during the tree rewriting as we resolve them during
33193 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
33194 the spec. Missing entirely is the information about
33195 accessability of elements of it.
33197 (Expression::ExprClassFromMemberInfo): New constructor for
33198 Expressions that creates a fully initialized Expression based on
33199 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
33202 (Invocation::Resolve): Begin implementing resolution of invocations.
33204 * literal.cs (StringLiteral): Implement Emit.
33206 2001-09-05 Ravi Pratap <ravi@ximian.com>
33208 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
33211 2001-09-04 Ravi Pratap <ravi@ximian.com>
33213 * cs-parser.jay (attribute_arguments): Implement actions.
33214 (attribute): Fix bug in production. Implement action.
33215 (attribute_list): Implement.
33216 (attribute_target): Implement.
33217 (attribute_target_specifier, opt_target_specifier): Implement
33218 (CheckAttributeTarget): New method to check if the attribute target
33220 (attribute_section): Implement.
33221 (opt_attributes): Implement.
33223 * attribute.cs : New file to handle attributes.
33224 (Attribute): Class to hold attribute info.
33226 * cs-parser.jay (opt_attribute_target_specifier): Remove production
33227 (attribute_section): Modify production to use 2 different rules to
33228 achieve the same thing. 1 s/r conflict down !
33229 Clean out commented, useless, non-reducing dimension_separator rules.
33231 * class.cs (TypeContainer.attributes): New member to hold list
33232 of attributes for a type.
33233 (Struct::Struct): Modify to take one more argument, the attribute list.
33234 (Class::Class): Ditto.
33235 (Field::Field): Ditto.
33236 (Method::Method): Ditto.
33237 (Property::Property): Ditto.
33239 * cs-parser.jay (struct_declaration): Update constructor call to
33240 pass in the attributes too.
33241 (class_declaration): Ditto.
33242 (constant_declaration): Ditto.
33243 (field_declaration): Ditto.
33244 (method_header): Ditto.
33245 (fixed_parameter): Ditto.
33246 (parameter_array): Ditto.
33247 (property_declaration): Ditto.
33249 * constant.cs (Constant::Constant): Update constructor similarly.
33250 Use System.Collections.
33252 * parameter.cs (Parameter::Parameter): Update as above.
33254 2001-09-02 Ravi Pratap <ravi@ximian.com>
33256 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33257 (TypeContainer.delegates): New member to hold list of delegates.
33259 * cs-parser.jay (delegate_declaration): Implement the action correctly
33260 this time as I seem to be on crack ;-)
33262 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33264 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33265 tell whether an identifier represents a namespace.
33267 * expression.cs (NamespaceExpr): A namespace expression, used only
33268 temporarly during expression resolution.
33269 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33270 utility functions to resolve names on expressions.
33272 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33274 * codegen.cs: Add hook for StatementExpressions.
33276 * class.cs: Fix inverted test for static flag in methods.
33278 2001-09-02 Ravi Pratap <ravi@ximian.com>
33280 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33281 to make it coincide with MS' number.
33282 (Operator::CheckBinaryOperator): Ditto.
33284 * ../errors/errors.txt : Remove error numbers added earlier.
33286 * ../errors/cs1019.cs : Test case for error # 1019
33288 * ../errros/cs1020.cs : Test case for error # 1020
33290 * cs-parser.jay : Clean out commented cruft.
33291 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33292 used anywhere - non-reducing rule.
33293 (namespace_declarations): Non-reducing rule - comment out.
33295 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33296 with TypeContainer::AddEnum.
33298 * delegate.cs : New file for delegate handling classes.
33299 (Delegate): Class for declaring delegates.
33301 * makefile : Update.
33303 * cs-parser.jay (delegate_declaration): Implement.
33305 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33307 * class.cs (Event::Define): Implement.
33308 (Event.EventBuilder): New member.
33310 * class.cs (TypeContainer::Populate): Update to define all enums and events
33312 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33313 readonly fields for all these cases ?
33315 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33317 * class.cs (Property): Revamp to use the convention of making fields readonly.
33318 Accordingly modify code elsewhere.
33320 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33321 the Define method of the Property class.
33323 * class.cs : Clean up applied patch and update references to variables etc. Fix
33325 (TypeContainer::Populate): Update to define all the properties we have. Also
33326 define all enumerations.
33328 * enum.cs (Define): Implement.
33330 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33332 * cs-parser.jay (overloadable_operator): The semantic value is an
33333 enum of the Operator class.
33334 (operator_declarator): Implement actions.
33335 (operator_declaration): Implement.
33337 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33338 validity of definitions.
33339 (Operator::CheckBinaryOperator): Static method to check for binary operators
33340 (TypeContainer::AddOperator): New method to add an operator to a type.
33342 * cs-parser.jay (indexer_declaration): Added line to actually call the
33343 AddIndexer method so it gets added ;-)
33345 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33346 already taken care of by the MS compiler ?
33348 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33350 * class.cs (Operator): New class for operator declarations.
33351 (Operator::OpType): Enum for the various operators.
33353 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33355 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33356 ostensibly handle this in semantic analysis.
33358 * cs-parser.jay (general_catch_clause): Comment out
33359 (specific_catch_clauses, specific_catch_clause): Ditto.
33360 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33361 (catch_args, opt_catch_args): New productions.
33362 (catch_clause): Rewrite to use the new productions above
33363 (catch_clauses): Modify accordingly.
33364 (opt_catch_clauses): New production to use in try_statement
33365 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33366 and re-write the code in the actions to extract the specific and
33367 general catch clauses by being a little smart ;-)
33369 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33370 Hooray, try and catch statements parse fine !
33372 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33374 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33375 string from the hashtable of variables.
33377 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33378 I end up making that mistake ;-)
33379 (catch_clauses): Fixed gross error which made Key and Value of the
33380 DictionaryEntry the same : $1 !!
33382 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33384 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33386 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33387 when the add and remove accessors are specified.
33389 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33391 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33392 information about indexer_declarator.
33393 (indexer_declarator): Implement actions.
33394 (parsing_indexer): New local boolean used to keep track of whether
33395 we are parsing indexers or properties. This is necessary because
33396 implicit_parameters come into picture even for the get accessor in the
33397 case of an indexer.
33398 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33400 * class.cs (Indexer): New class for indexer declarations.
33401 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33402 (TypeContainer::indexers): New member to hold list of indexers for the
33405 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33407 * cs-parser.jay (add_accessor_declaration): Implement action.
33408 (remove_accessor_declaration): Implement action.
33409 (event_accessors_declaration): Implement
33410 (variable_declarators): swap statements for first rule - trivial.
33412 * class.cs (Event): New class to hold information about event
33414 (TypeContainer::AddEvent): New method to add an event to a type
33415 (TypeContainer::events): New member to hold list of events.
33417 * cs-parser.jay (event_declaration): Implement actions.
33419 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33421 * cs-parser.jay (dim_separators): Implement. Make it a string
33422 concatenating all the commas together, just as they appear.
33423 (opt_dim_separators): Modify accordingly
33424 (rank_specifiers): Update accordingly. Basically do the same
33425 thing - instead, collect the brackets here.
33426 (opt_rank_sepcifiers): Modify accordingly.
33427 (array_type): Modify to actually return the complete type string
33428 instead of ignoring the rank_specifiers.
33429 (expression_list): Implement to collect the expressions
33430 (variable_initializer): Implement. We make it a list of expressions
33431 essentially so that we can handle the array_initializer case neatly too.
33432 (variable_initializer_list): Implement.
33433 (array_initializer): Make it a list of variable_initializers
33434 (opt_array_initializer): Modify accordingly.
33436 * expression.cs (New::NType): Add enumeration to help us
33437 keep track of whether we have an object/delegate creation
33438 or an array creation.
33439 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33440 members to hold data about array creation.
33441 (New:New): Modify to update NewType
33442 (New:New): New Overloaded contructor for the array creation
33445 * cs-parser.jay (array_creation_expression): Implement to call
33446 the overloaded New constructor.
33448 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33450 * class.cs (TypeContainer::Constructors): Return member
33451 constructors instead of returning null.
33453 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33455 * typemanager.cs (InitCoreTypes): Initialize the various core
33456 types after we have populated the type manager with the user
33457 defined types (this distinction will be important later while
33458 compiling corlib.dll)
33460 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33461 on Expression Classification. Now all expressions have a method
33462 `Resolve' and a method `Emit'.
33464 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33465 generation from working. Also add some temporary debugging
33468 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33470 * codegen.cs: Lots of code generation pieces. This is only the
33471 beginning, will continue tomorrow with more touches of polish. We
33472 handle the fundamentals of if, while, do, for, return. Others are
33473 trickier and I need to start working on invocations soon.
33475 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33478 * codegen.cs (EmitContext): New struct, used during code
33479 emission to keep a context. Most of the code generation will be
33482 * cs-parser.jay: Add embedded blocks to the list of statements of
33483 this block. So code generation proceeds in a top down fashion.
33485 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33487 * statement.cs: Add support for multiple child blocks.
33489 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33491 * codegen.cs (EmitCode): New function, will emit the code for a
33492 Block of code given a TypeContainer and its ILGenerator.
33494 * statement.cs (Block): Standard public readonly optimization.
33495 (Block::Block constructors): Link children.
33496 (Block::Child): Child Linker.
33497 (Block::EmitVariables): Emits IL variable declarations.
33499 * class.cs: Drop support for MethodGroups here, delay until
33501 (Method::): Applied the same simplification that I did before, and
33502 move from Properties to public readonly fields.
33503 (Method::ParameterTypes): Returns the parameter types for the
33504 function, and implements a cache that will be useful later when I
33505 do error checking and the semantic analysis on the methods is
33507 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33508 and made a method, optional argument tells whether this is a class
33509 or a structure to apply the `has-this' bit.
33510 (Method::GetCallingConvention): Implement, returns the calling
33512 (Method::Define): Defines the type, a second pass is performed
33513 later to populate the methods.
33515 (Constructor::ParameterTypes): implement a cache similar to the
33516 one on Method::ParameterTypes, useful later when we do semantic
33519 (TypeContainer::EmitMethod): New method. Emits methods.
33521 * expression.cs: Removed MethodGroup class from here.
33523 * parameter.cs (Parameters::GetCallingConvention): new method.
33525 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33527 * class.cs (TypeContainer::Populate): Drop RootContext from the
33530 (Constructor::CallingConvention): Returns the calling convention.
33531 (Constructor::ParameterTypes): Returns the constructor parameter
33534 (TypeContainer::AddConstructor): Keep track of default constructor
33535 and the default static constructor.
33537 (Constructor::) Another class that starts using `public readonly'
33538 instead of properties.
33540 (Constructor::IsDefault): Whether this is a default constructor.
33542 (Field::) use readonly public fields instead of properties also.
33544 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33545 track of static constructors; If none is used, turn on
33546 BeforeFieldInit in the TypeAttributes.
33548 * cs-parser.jay (opt_argument_list): now the return can be null
33549 for the cases where there are no arguments.
33551 (constructor_declarator): If there is no implicit `base' or
33552 `this', then invoke the default parent constructor.
33554 * modifiers.cs (MethodAttr): New static function maps a set of
33555 modifiers flags into a MethodAttributes enum
33556 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33557 MethodAttr, TypeAttr to represent the various mappings where the
33558 modifiers are used.
33559 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33561 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33563 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33566 * interface.cs (PopulateIndexer): Implemented the code generator
33567 for interface indexers.
33569 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33571 * interface.cs (InterfaceMemberBase): Now we track the new status
33574 (PopulateProperty): Implement property population. Woohoo! Got
33575 Methods and Properties going today.
33577 Removed all the properties for interfaces, and replaced them with
33578 `public readonly' fields.
33580 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33582 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33583 initialize their hashtables/arraylists only when they are needed
33584 instead of doing this always.
33586 * parameter.cs: Handle refs and out parameters.
33588 * cs-parser.jay: Use an ArrayList to construct the arguments
33589 instead of the ParameterCollection, and then cast that to a
33592 * parameter.cs: Drop the use of ParameterCollection and use
33593 instead arrays of Parameters.
33595 (GetParameterInfo): Use the Type, not the Name when resolving
33598 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33600 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33601 and instead use public readonly fields.
33603 * class.cs: Put back walking code for type containers.
33605 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33607 * class.cs (MakeConstant): Code to define constants.
33609 * rootcontext.cs (LookupType): New function. Used to locate types
33612 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33614 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33615 this System.Reflection code is. Kudos to Microsoft
33617 * typemanager.cs: Implement a type cache and avoid loading all
33618 types at boot time. Wrap in LookupType the internals. This made
33619 the compiler so much faster. Wow. I rule!
33621 * driver.cs: Make sure we always load mscorlib first (for
33622 debugging purposes, nothing really important).
33624 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33625 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33627 * rootcontext.cs: Lookup types on their namespace; Lookup types
33628 on namespaces that have been imported using the `using' keyword.
33630 * class.cs (TypeContainer::TypeAttr): Virtualize.
33631 (Class::TypeAttr): Return attributes suitable for this bad boy.
33632 (Struct::TypeAttr): ditto.
33633 Handle nested classes.
33634 (TypeContainer::) Remove all the type visiting code, it is now
33635 replaced with the rootcontext.cs code
33637 * rootcontext.cs (GetClassBases): Added support for structs.
33639 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33641 * interface.cs, statement.cs, class.cs, parameter.cs,
33642 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33643 Drop use of TypeRefs, and use strings instead.
33645 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33649 * class.cs (Struct::Struct): set the SEALED flags after
33650 checking the modifiers.
33651 (TypeContainer::TypeAttr): new property, returns the
33652 TypeAttributes for a class.
33654 * cs-parser.jay (type_list): Oops, list production was creating a
33655 new list of base types.
33657 * rootcontext.cs (StdLib): New property.
33658 (GetInterfaceTypeByName): returns an interface by type name, and
33659 encapsulates error handling here.
33660 (GetInterfaces): simplified.
33661 (ResolveTree): Encapsulated all the tree resolution here.
33662 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33665 * driver.cs: Add support for --nostdlib, to avoid loading the
33666 default assemblies.
33667 (Main): Do not put tree resolution here.
33669 * rootcontext.cs: Beginning of the class resolution.
33671 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33673 * rootcontext.cs: Provide better error reporting.
33675 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33677 * rootcontext.cs (CreateInterface): Handle the case where there
33678 are no parent interfaces.
33680 (CloseTypes): Routine to flush types at the end.
33681 (CreateInterface): Track types.
33682 (GetInterfaces): Returns an array of Types from the list of
33683 defined interfaces.
33685 * typemanager.c (AddUserType): Mechanism to track user types (puts
33686 the type on the global type hash, and allows us to close it at the
33689 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33691 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33692 RecordInterface instead.
33694 * cs-parser.jay: Updated to reflect changes above.
33696 * decl.cs (Definition): Keep track of the TypeBuilder type that
33697 represents this type here. Not sure we will use it in the long
33698 run, but wont hurt for now.
33700 * driver.cs: Smaller changes to accomodate the new code.
33702 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33705 * rootcontext.cs (CreateInterface): New method, used to create
33706 the System.TypeBuilder type for interfaces.
33707 (ResolveInterfaces): new entry point to resolve the interface
33709 (CodeGen): Property, used to keep track of the code generator.
33711 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33713 * cs-parser.jay: Add a second production for delegate_declaration
33716 (enum_body): Put an opt_comma here instead of putting it on
33717 enum_body or enum_member_declarations so we can handle trailing
33718 commas on enumeration members. Gets rid of a shift/reduce.
33720 (type_list): Need a COMMA in the middle.
33722 (indexer_declaration): Tell tokenizer to recognize get/set
33724 * Remove old targets.
33726 * Re-add the parser target.
33728 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33730 * cs-parser.jay: Add precendence rules for a number of operators
33731 ot reduce the number of shift/reduce conflicts in the grammar.
33733 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33735 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33738 Get rid of old crufty code.
33740 * rootcontext.cs: Use this to keep track of the parsed
33741 representation and the defined types available to the program.
33743 * gen-treedump.cs: adjust for new convention.
33745 * type.cs: Split out the type manager, and the assembly builder
33748 * typemanager.cs: the type manager will live here now.
33750 * cil-codegen.cs: And the code generator here.
33752 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33754 * makefile: Fixed up for easy making.
33756 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33758 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33761 (unary_expression): Expand pre_increment_expression and
33762 post_decrement_expression to reduce a shift/reduce.
33764 2001-07-11 Simon Cozens
33766 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33768 Improve allow_keyword_as_indent name.
33770 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33772 * Adjustments for Beta2.
33774 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33776 * decl.cs: Added `Define' abstract method.
33777 (InTransit): new property, used to catch recursive definitions.
33779 * interface.cs: Implement `Define'.
33781 * modifiers.cs: Map Modifiers.constants to
33782 System.Reflection.TypeAttribute flags.
33784 * class.cs: Keep track of types and user-defined types.
33785 (BuilderInit): New method for creating an assembly
33786 (ResolveType): New function to launch the resolution process, only
33787 used by interfaces for now.
33789 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33790 that are inserted into the name space.
33792 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33794 * ARGH. I have screwed up my tree so many times due to the use of
33795 rsync rather than using CVS. Going to fix this at once.
33797 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33800 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33802 * Experiment successful: Use System.Type rather that our own
33805 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33807 * cs-parser.jay: Removed nsAliases from here.
33809 Use new namespaces, handle `using XXX;'
33811 * namespace.cs: Reimplemented namespace handling, use a recursive
33812 definition of the class. Now we can keep track of using clauses
33813 and catch invalid using clauses.
33815 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33817 * gen-treedump.cs: Adapted for all the renaming.
33819 * expression.cs (Expression): this class now has a Type property
33820 which returns an expression Type.
33822 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33823 `Type', as this has a different meaning now in the base
33825 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33827 * interface.cs, class.cs: Removed from all the sources the
33828 references to signature computation, as we can not do method
33829 signature computation during the parsing time, as we are not
33830 trying to solve at that point distinguishing:
33834 void a (NS.Blah x) {}
33837 Which depending on the context might be valid or not, as we do not
33838 know if Blah is the same thing as NS.Blah at that point.
33840 * Redid everything so the code uses TypeRefs now instead of
33841 Types. TypeRefs are just temporary type placeholders, that need
33842 to be resolved. They initially have a pointer to a string and the
33843 current scope in which they are used. This is used later by the
33844 compiler to resolve the reference to an actual Type.
33846 * DeclSpace is no longer a CIR.Type, and neither are
33847 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33848 are all DeclSpaces, but no Types.
33850 * type.cs (TypeRefManager): This implements the TypeRef manager,
33851 which keeps track of all the types that need to be resolved after
33852 the parsing has finished.
33854 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33856 * ARGH. We are going to have to store `foreach' as a class rather
33857 than resolving it, as we need to verify error 1579 after name
33858 resolution. *OR* we could keep a flag that says `This request to
33859 IEnumerator comes from a foreach statement' which we can then use
33860 to generate the error.
33862 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33864 * class.cs (TypeContainer.AddMethod): we now add methods to the
33865 MethodGroup instead of the method hashtable.
33867 * expression.cs: Add MethodGroup abstraction, which gets us one
33868 step closer to the specification in the way we handle method
33871 * cs-parser.jay (primary_expression): qualified_identifier now
33872 tried to match up an identifier to a local variable reference or
33873 to a parameter reference.
33875 current_local_parameters is now a parser global variable that
33876 points to the current parameters for the block, used during name
33879 (property_declaration): Now creates an implicit `value' argument to
33882 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33884 * parameter.cs: Do not use `param' arguments as part of the
33885 signature, per the spec.
33887 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33889 * decl.cs: Base class for classes, structs and interfaces. This
33890 is the "Declaration Space"
33892 * cs-parser.jay: Use CheckDef for checking declaration errors
33893 instead of having one on each function.
33895 * class.cs: Factor out some code for handling error handling in
33896 accordance to the "Declarations" section in the "Basic Concepts"
33897 chapter in the ECMA C# spec.
33899 * interface.cs: Make all interface member classes derive from
33900 InterfaceMemberBase.
33902 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33904 * Many things: all interfaces are parsed and generated in
33905 gen-treedump. Support for member variables, constructors,
33906 destructors, properties, constants is there.
33908 Beginning of the IL backend, but very little done, just there for
33911 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33913 * cs-parser.jay: Fix labeled statement.
33915 * cs-tokenizer.cs (escape): Escape " and ' always.
33916 ref_line, ref_name: keep track of the line/filename as instructed
33917 by #line by the compiler.
33920 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33922 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33923 to match the values in System.CodeDOM.
33925 Divid renamed to Divide.
33927 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33929 (Statements.set): remove.
33931 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33934 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33935 falseStatements always have valid values.
33937 * cs-parser.jay: Use System.CodeDOM now.