1 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
3 support.cs (DynamicType): Assembly property returns the assembly builder.
4 This is required due to how compiler context works in corlib.
6 2009-12-14 Marek Safar <marek.safar@gmail.com>
9 * assign.cs (LocalTemporary): Removed no longer needed special
12 2009-12-11 Marek Safar <marek.safar@gmail.com>
14 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
15 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
16 enum for easier debugging.
18 2009-12-10 Marek Safar <marek.safar@gmail.com>
20 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
23 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
26 2009-12-10 Marek Safar <marek.safar@gmail.com>
28 * cs-parser.jay, statement.cs: Handle parser error in code
31 2009-12-10 Marek Safar <marek.safar@gmail.com>
33 * ecore.cs: Ignore base imported methods when they are already
36 * eval.cs: Handle non-existent keys.
38 * report.cs, driver.cs: Make fatal work with console printer only.
40 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
42 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
44 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
46 * typemanager.cs: Add MakeGenericMethod that checks if the method
47 is really the generic method definition.
49 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
50 to inflate generic methods.
52 2009-12-08 Marek Safar <marek.safar@gmail.com>
55 * anonymous.cs: Use actual type parameters when checking for generic
58 2009-12-08 Marek Safar <marek.safar@gmail.com>
61 * expression.cs (DoNumericPromotion): Fixed typo.
63 2009-12-08 Marek Safar <marek.safar@gmail.com>
65 *.cs: Moving to generics world.
67 cs-parser.jay: Removed current_array_type.
69 2009-12-07 Marek Safar <marek.safar@gmail.com>
71 *.cs: Moving to generics world.
73 2009-12-04 Marek Safar <marek.safar@gmail.com>
75 *.cs: Moving to generics world (day 2).
77 2009-12-03 Marek Safar <marek.safar@gmail.com>
79 *.cs: Moving to generics world.
81 2009-12-02 Marek Safar <marek.safar@gmail.com>
83 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
84 Encode dynamic type attribute for elements where attributes cannot
87 2009-12-01 Marek Safar <marek.safar@gmail.com>
89 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
92 2009-12-01 Marek Safar <marek.safar@gmail.com>
95 * class.cs: Never report a unused warning for generic events to
96 workaround wrong expression type.
98 2009-11-30 Marek Safar <marek.safar@gmail.com>
100 A fix for bug #558305
101 * decl.cs, class.cs: Check partial method definitions using correct
104 2009-11-30 Marek Safar <marek.safar@gmail.com>
106 * argument.cs: Don't cache rarely used dynamic flag.
108 2009-11-27 Marek Safar <marek.safar@gmail.com>
110 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
112 2009-11-27 Marek Safar <marek.safar@gmail.com>
114 * ecore.cs (SimpleName): Removed no longer needed in_transit as
115 Resolve is now non-reentrant (saves ~0.6MB for corlib).
117 2009-11-26 Marek Safar <marek.safar@gmail.com>
119 A fix for bug #545081
120 * decl.cs: Check private nested types of nested types recursively.
122 2009-11-26 Marek Safar <marek.safar@gmail.com>
124 A fix for bug #558305
125 * location.cs: Ignore self referencing #line directive
127 2009-11-26 Marek Safar <marek.safar@gmail.com>
129 A fix for bug #558292
130 * class.cs: Allow single unsafe fixed buffer fields.
132 2009-11-26 Marek Safar <marek.safar@gmail.com>
134 * expression: Optimize few more zero-based operations.
136 2009-11-26 Marek Safar <marek.safar@gmail.com>
138 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
139 avoids boxing of literal values.
141 2009-11-26 Marek Safar <marek.safar@gmail.com>
143 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
144 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
145 codegen.cs: LocatedToken redesing to avoid excessive allocation and
146 boxing (saves ~7MB for corlib). Also fixes presise token location.
148 2009-11-25 Marek Safar <marek.safar@gmail.com>
150 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
153 2009-11-24 Marek Safar <marek.safar@gmail.com>
155 * expression.cs: Lower static array initializer barrier.
157 * support.cs, driver.cs: Share reader buffer.
159 2009-11-23 Marek Safar <marek.safar@gmail.com>
161 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
163 2009-11-23 Marek Safar <marek.safar@gmail.com>
165 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
166 cleanup some obsolete code.
168 2009-11-20 Marek Safar <marek.safar@gmail.com>
170 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
173 2009-11-20 Marek Safar <marek.safar@gmail.com>
175 * *.cs: Resolved expressions are never resolved again, this helps to
176 uncover some not easy to find bugs and improve the performance.
178 2009-11-19 Marek Safar <marek.safar@gmail.com>
180 * *.cs: Made constant expressions fully compatible with any other
183 2009-11-19 Marek Safar <marek.safar@gmail.com>
185 * *.cs: DoResolve is a worker method and has to be protected.
187 2009-11-18 Marek Safar <marek.safar@gmail.com>
189 * *.cs: More context specific handling.
191 2009-11-17 Marek Safar <marek.safar@gmail.com>
193 * *.cs: More context specific handling.
195 2009-11-16 Marek Safar <marek.safar@gmail.com>
197 * dynamic.cs, class.cs: Removed few fixed user types conversions.
199 * symbolwriter.cs: Uses public ILOffset.
201 2009-11-13 Marek Safar <marek.safar@gmail.com>
203 A fix for bug #553650
204 * generic.cs: Another missing TypeToCoreType, still too many to fix.
206 2009-11-13 Marek Safar <marek.safar@gmail.com>
208 A fix for bug #555170
210 * class.cs, delegate.cs, enum.cs: Constants have to be available
211 for parameters resolve.
213 2009-11-12 Marek Safar <marek.safar@gmail.com>
215 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
218 2009-11-12 Marek Safar <marek.safar@gmail.com>
220 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
221 with a statically known candidate set.
223 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
225 * generic.cs: Made type inflation for generic constraint checks
226 recursive. This fixes BGO #553655.
228 2009-11-11 Marek Safar <marek.safar@gmail.com>
230 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
233 2009-11-10 Marek Safar <marek.safar@gmail.com>
235 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
236 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
237 attribute.cs: Add some dynamic error checking.
239 2009-11-07 Marek Safar <marek.safar@gmail.com>
241 A fix for bug #553465
243 * expression.cs: Fixed mixed version of expression tree anonymous
246 2009-11-06 Marek Safar <marek.safar@gmail.com>
248 A fix for bug #553031
250 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
251 expression tree version of anonymous type with members declaration.
253 2009-11-05 Marek Safar <marek.safar@gmail.com>
255 * parameter.cs: Handle nullable parameter default expression.
257 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
258 class.cs, attribute.cs: Check for wrong dynamic arguments.
260 2009-11-05 Marek Safar <marek.safar@gmail.com>
262 * statement.cs: Dynamic statements.
264 2009-11-04 Marek Safar <marek.safar@gmail.com>
266 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
267 Compound assignments over dynamic type.
269 2009-11-03 Marek Safar <marek.safar@gmail.com>
271 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
272 constructor arguments.
274 2009-10-30 Marek Safar <marek.safar@gmail.com>
276 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
277 codegen.cs: Unary mutator on dynamic member access expression.
279 2009-10-29 Marek Safar <marek.safar@gmail.com>
281 A fix for bug #550580
282 * convert.cs: Don't eliminate explicit precission casts.
284 2009-10-28 Marek Safar <marek.safar@gmail.com>
286 A fix for bug #550404
288 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
289 expression.cs, statement.cs, ecore.cs: Quote any nested expression
292 2009-10-27 Marek Safar <marek.safar@gmail.com>
294 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
297 * class.cs: Allow nullable binary user operators.
299 2009-10-26 Marek Safar <marek.safar@gmail.com>
301 * expression.cs: Move binary expression optimization at the end of
304 2009-10-23 Marek Safar <marek.safar@gmail.com>
306 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
307 Separate NullConstant from NullLiteral.
309 2009-10-23 Marek Safar <marek.safar@gmail.com>
311 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
312 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
313 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
314 ModuleContainer. Add common unclosed member check routine.
316 2009-10-22 Marek Safar <marek.safar@gmail.com>
318 * argument.cs: Use literal flag for real literals only.
320 * dynamic.cs: Use correct return type for custom delegates.
322 2009-10-22 Marek Safar <marek.safar@gmail.com>
324 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
327 2009-10-22 Marek Safar <marek.safar@gmail.com>
329 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
331 2009-10-21 Marek Safar <marek.safar@gmail.com>
333 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
336 2009-10-21 Marek Safar <marek.safar@gmail.com>
338 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
341 2009-10-20 Marek Safar <marek.safar@gmail.com>
343 * argument.cs, dynamic.cs, expression.cs: Latest API update.
345 2009-10-19 Marek Safar <marek.safar@gmail.com>
347 * typemanager.cs, expression.cs: Dynamic array initializer.
349 2009-10-16 Marek Safar <marek.safar@gmail.com>
351 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
354 2009-10-16 Marek Safar <marek.safar@gmail.com>
356 A fix for bug #493523, #507067
357 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
358 standard nullable conversion using underlying standard conversion
359 and not full conversion.
361 2009-10-15 Marek Safar <marek.safar@gmail.com>
363 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
364 type in VerifyArgumentsCompat.
366 2009-10-15 Marek Safar <marek.safar@gmail.com>
368 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
369 Reject variable used with type arguments.
371 2009-10-14 Marek Safar <marek.safar@gmail.com>
373 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
374 Implement dynamic expressions assignment.
376 2009-10-14 Marek Safar <marek.safar@gmail.com>
378 * expression.cs: Build underlying expression when resolving unary
381 2009-10-14 Marek Safar <marek.safar@gmail.com>
383 * expression.cs: Emit enum array initializer using binary blob.
385 2009-10-08 Marek Safar <marek.safar@gmail.com>
387 * typemanager.cs, constant.cs: Optimize decimal constants which fit
390 2009-10-07 Marek Safar <marek.safar@gmail.com>
392 * typemanager.cs: Reset object_type.
394 * assign: Made SimpleAssign public.
396 2009-10-06 Marek Safar <marek.safar@gmail.com>
398 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
399 invocation assembly to IsThisOrFriendAssembly.
401 2009-10-05 Marek Safar <marek.safar@gmail.com>
403 * expression.cs: Equality comparison of generic parameter with
406 2009-10-05 Marek Safar <marek.safar@gmail.com>
408 A fix for bug #543570
409 * generic.cs: Import predefined constraints correctly.
411 2009-10-02 Marek Safar <marek.safar@gmail.com>
413 * ecore.cs: Don't crash on overloads with optional paremeters where
414 arguments count overflows.
416 * parameter.cs: Import optional parameter constants using optional
419 2009-10-01 Marek Safar <marek.safar@gmail.com>
421 * Makefile: Default is gmcs compiler.
423 2009-10-01 Marek Safar <marek.safar@gmail.com>
425 * cs-parser.jay: Fixed few NRE.
427 2009-10-01 Marek Safar <marek.safar@gmail.com>
429 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
431 2009-09-30 Marek Safar <marek.safar@gmail.com>
433 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
434 ShimExpression, ImplicitCast.
436 2009-09-30 Marek Safar <marek.safar@gmail.com>
438 A fix for bug #542959
439 * delegate.cs: Emit correct delegate instance variable when there
440 are static and non-static overloads.
442 2009-09-29 Marek Safar <marek.safar@gmail.com>
444 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
445 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
447 2009-09-28 Marek Safar <marek.safar@gmail.com>
449 A fix for bug #542487
450 * ecore.cs: Resolve extension methods hidden by properties.
452 2009-09-25 Marek Safar <marek.safar@gmail.com>
454 * expression.cs, ecore.cs: More dynamic binary expressions.
456 2009-09-22 Marek Safar <marek.safar@gmail.com>
458 * nullable.cs, expression.cs: Fixed null lifted conversion for
459 bitwise enum operations.
461 2009-09-22 Marek Safar <marek.safar@gmail.com>
463 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
464 values in checked context.
466 2009-09-22 Marek Safar <marek.safar@gmail.com>
468 * expression.cs, ecore.cs: Fixed array index constant conversion.
470 2009-09-20 Miguel de Icaza <miguel@novell.com>
472 * expression.cs: Do not crash when MemberLookup returns something
473 that is not a MemberExpr here. Report error 582 instead.
477 2009-09-18 Marek Safar <marek.safar@gmail.com>
479 * decl.cs, class.cs: Check protected property accessors.
481 2009-09-18 Marek Safar <marek.safar@gmail.com>
483 * dynamic.cs, assign.cs: Dynamic compound assignment.
485 2009-09-17 Marek Safar <marek.safar@gmail.com>
487 * expression.cs: Fixed compound assignment explicit conversion.
489 2009-09-17 Marek Safar <marek.safar@gmail.com>
491 * expression.cs, ecore.cs: Cannot infer variables from method group.
493 2009-09-16 Marek Safar <marek.safar@gmail.com>
495 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
496 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
497 codegen.cs: Dynamic binary operations scaffolding.
499 2009-09-15 Marek Safar <marek.safar@gmail.com>
501 * expression.cs: Fixes nullable promotion for enum type variables.
503 2009-09-11 Marek Safar <marek.safar@gmail.com>
505 * driver.cs, dynamic.cs: Reset more static variables.
507 2009-09-11 Marek Safar <marek.safar@gmail.com>
509 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
510 driver.cs: Introduced Expression::MakeExpression.
512 2009-09-11 Marek Safar <marek.safar@gmail.com>
514 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
516 2009-09-09 Marek Safar <marek.safar@gmail.com>
518 * eval.cs, report.cs: Use Console.Out for all eval error or warning
521 2009-09-09 Marek Safar <marek.safar@gmail.com>
523 A fix for bug #518707
524 * expression.cs (Is): Optimize only generic parameter type
525 expression probing value type generic parameter.
527 2009-09-09 Marek Safar <marek.safar@gmail.com>
529 A fix for bug #532571
530 * ecore.cs: Check for simple name type arguments used with
533 2009-09-08 Marek Safar <marek.safar@gmail.com>
535 A fix for bug #497421
536 * generic.cs (CheckConstraint): Don't use buildin types to check for
537 parameterless constructor.
539 2009-09-08 Marek Safar <marek.safar@gmail.com>
541 A fix for bug #537402
542 * generic.cs (CheckConstraint): Correctly inflate generic type
543 arguments when checking generic method.
545 2009-09-08 Marek Safar <marek.safar@gmail.com>
547 A fix for bug #536463
548 * decl.cs (AddToContainer): Don't report collision between explicit
549 and parameterless non-explicit members.
551 2009-09-08 Marek Safar <marek.safar@gmail.com>
553 * eval.cs: Reset more static stuff.
555 2009-09-07 Marek Safar <marek.safar@gmail.com>
557 A fix for bug #324625
558 * expression.cs, ecore.cs: Create nested generic type expression
559 using declaring and not current type.
561 2009-09-07 Marek Safar <marek.safar@gmail.com>
563 * *.cs: Changed Report class to accept various output printers and
564 be an instance class. An expression resolver can now use different
565 message reporter for each call and Report.Error can safely throw
566 an exception. Part of ongoing work to turn mcs into proper library.
568 2009-09-04 Marek Safar <marek.safar@gmail.com>
570 * statement.cs, ecore.cs: Removed error reporting from emit code.
572 2009-09-04 Marek Safar <marek.safar@gmail.com>
574 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
576 2009-09-03 Marek Safar <marek.safar@gmail.com>
578 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
579 parser checks out of constructors.
581 2009-09-02 Marek Safar <marek.safar@gmail.com>
583 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
585 2009-09-02 Marek Safar <marek.safar@gmail.com>
587 A fix for bug #535448
588 * anonymous.cs, class.cs: Copy return label between all contexts.
590 2009-09-02 Marek Safar <marek.safar@gmail.com>
592 A fix for bug #535395
593 * namespace.cs: Resolve context can be null.
595 2009-08-25 Marek Safar <marek.safar@gmail.com>
597 A fix for bug #533912
598 * generic.cs: Use correct context for constraints resolving.
600 2009-08-25 Marek Safar <marek.safar@gmail.com>
602 A fix for bug #532630
603 * driver.cs: Trim conditional symbols.
605 2009-08-25 Marek Safar <marek.safar@gmail.com>
607 * context.cs: New file.
609 * *.exe.sources, *.csproj: Updated.
611 2009-08-25 Marek Safar <marek.safar@gmail.com>
613 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
614 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
615 IMembercontext, some small cleanups.
617 2009-08-24 Marek Safar <marek.safar@gmail.com>
619 * *.cs: Split ResolveContext and EmitContext.
621 2009-08-24 Marek Safar <marek.safar@gmail.com>
623 * *.cs: Only ResolveContext implements IMemberContext.
625 2009-08-21 Marek Safar <marek.safar@gmail.com>
627 * *.cs: Renamed IResolveContext to IMemberContext.
629 2009-08-21 Marek Safar <marek.safar@gmail.com>
631 * *.cs: Detached ResolveContext from EmitContext.
633 2009-08-21 Marek Safar <marek.safar@gmail.com>
635 * codegen.cs: Moved flow-analysis to BlockContext.
637 2009-08-21 Marek Safar <marek.safar@gmail.com>
639 * *.cs: Detached BlockContext from EmitContext.
641 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
643 * statement.cs: avoid nullref when the return value of GetEnumerator()
644 does not contain any MoveNext() method.
646 2009-08-19 Marek Safar <marek.safar@gmail.com>
648 * *.cs: Removed IResolveContext::GenericDeclContainer.
650 2009-08-19 Marek Safar <marek.safar@gmail.com>
652 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
654 2009-08-19 Marek Safar <marek.safar@gmail.com>
656 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
657 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
659 2009-08-18 Marek Safar <marek.safar@gmail.com>
661 * *.cs: Removed boolean fields from EmitContext.
663 2009-08-18 Marek Safar <marek.safar@gmail.com>
665 * *.cs: Add IResolveContext::IsStatic.
667 2009-08-18 Marek Safar <marek.safar@gmail.com>
669 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
671 2009-08-17 Marek Safar <marek.safar@gmail.com>
673 * *.cs: Removed DeclContainer from EmitContext.
675 2009-08-17 Marek Safar <marek.safar@gmail.com>
677 * *.cs: Add IResolveContext::CurrentTypeParameters.
679 2009-08-14 Marek Safar <marek.safar@gmail.com>
681 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
683 2009-08-14 Marek Safar <marek.safar@gmail.com>
685 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
686 codegen.cs: Add IResolveContext::LookupExtensionMethod.
688 2009-08-13 Marek Safar <marek.safar@gmail.com>
690 * decl.cs: Look in PartialContainer for parent type parameters.
692 2009-08-13 Marek Safar <marek.safar@gmail.com>
694 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
695 codegen.cs: Add IResolveContext::LookupTypeParameter.
697 2009-08-13 Marek Safar <marek.safar@gmail.com>
699 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
700 Moved resolved logic from Emit to Resolve.
702 2009-08-13 Marek Safar <marek.safar@gmail.com>
704 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
705 codegen.cs: Reworked atttributes handling of ResolveContext.
707 2009-08-12 Marek Safar <marek.safar@gmail.com>
709 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
710 LookupNamespaceOrType to ResolveContext.
712 2009-08-12 Marek Safar <marek.safar@gmail.com>
714 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
715 class.cs: Removed unused parameters and methods.
717 2009-08-11 Marek Safar <marek.safar@gmail.com>
719 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
720 codegen.cs: Finding the best common type of a set of expressions for
723 2009-08-07 Marek Safar <marek.safar@gmail.com>
725 * dynamic.cs, expression.cs: More dynamic conversions.
727 2009-08-06 Miguel de Icaza <miguel@novell.com>
729 * generic.cs: This loop was incorrect, it was increment ii, but
730 checking for `i'. This was a change introduced to fix #327497,
733 * class.cs: Catch another case for cs0533 error, fixes #324782.
735 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
737 * typemanager.cs (GetGenericArguments): SRE returns null for
738 generic methods on type builder instances if they are not generic
739 themselves. For example, for Foo<int>::Bar() it returns null, but
740 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
742 2009-08-05 Marek Safar <marek.safar@gmail.com>
744 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
745 delegate.cs: Work on dynamic binding.
747 2009-08-04 Marek Safar <marek.safar@gmail.com>
749 A second fix for bug #525342
750 * class.cs: Attach partial method attributes to method
753 2009-08-03 Marek Safar <marek.safar@gmail.com>
755 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
758 * rootcontext.cs: Default to langversion v4.
760 2009-08-03 Marek Safar <marek.safar@gmail.com>
762 * pending.cs: Check return type before member info is set.
764 2009-08-03 Marek Safar <marek.safar@gmail.com>
766 * anonymous.cs: Fully initialize generic hoisted field expression.
768 2009-08-02 Miguel de Icaza <miguel@novell.com>
770 * cs-parser.jay: Flag variables declared on the interactive shell
771 as used to prevent the 168 warning about local variable not being
774 2009-07-31 Marek Safar <marek.safar@gmail.com>
776 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
777 attribute.cs: Emit dynamic export attribute.
779 2009-07-30 Marek Safar <marek.safar@gmail.com>
781 * expression.cs: More verifier work.
783 2009-07-29 Marek Safar <marek.safar@gmail.com>
785 * nullable.cs: Fixed SRE crash during corlib compilation.
787 2009-07-29 Marek Safar <marek.safar@gmail.com>
789 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
790 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
791 More TypeManager.TypeToCoreType needed.
793 2009-07-29 Marek Safar <marek.safar@gmail.com>
795 * anonymous.cs: Update after recent SRE fixes.
797 2009-07-28 Marek Safar <marek.safar@gmail.com>
799 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
800 version of GetFieldHandle for fields of generic types.
802 2009-07-27 Marek Safar <marek.safar@gmail.com>
804 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
805 ecore.cs: Add TypeManager.IsDynamicType,
806 PredefinedAttributes.Dynamic.
808 2009-07-27 Marek Safar <marek.safar@gmail.com>
810 A fix for bug #415375
811 * expression.cs: Fixed object and reference type parameter
814 2009-07-27 Marek Safar <marek.safar@gmail.com>
816 A fix for bug #525342
817 * class.cs: Attach partial method attributes to method
820 2009-07-24 Marek Safar <marek.safar@gmail.com>
822 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
825 2009-07-24 Marek Safar <marek.safar@gmail.com>
827 * anonymous.cs (MutateField): Add imported types handling.
829 2009-07-23 Marek Safar <marek.safar@gmail.com>
831 * expression.cs, delegate.cs: Moved arguments resolve into their
832 counterparts expressions. Removed argument resolve from
833 CollectionElementInitializer.
835 2009-07-23 Marek Safar <marek.safar@gmail.com>
837 A fix for bug #523683
838 * convert.cs, delegate.cs: Use common overload mechanism for method
839 group conversion check.
841 2009-07-22 Marek Safar <marek.safar@gmail.com>
843 A fix for bug #523899
844 * generics.cs: Exact type inference with other bound types.
846 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
848 Don't complain when the same type is implemented by the output
849 assembly as well as multiple referenced assemblies
850 * namespace.cs (RootNamespace.LookupTypeReflection): Add
851 'must_be_unique' flag.
852 (GlobalRootNamespace): Update to changes.
853 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
854 already have a type in hand.
856 2009-07-22 Marek Safar <marek.safar@gmail.com>
858 * expression.cs: More verifier instrumentation.
860 * statement.cs: Do proper throw expression conversion.
862 2009-07-22 Marek Safar <marek.safar@gmail.com>
864 A fix for bug #522789
865 * expression.cs: Mutate invocation return type.
867 2009-07-16 Marek Safar <marek.safar@gmail.com>
869 * anonymous.cs: Split assignable and readonly generated variable
872 2009-07-16 Marek Safar <marek.safar@gmail.com>
874 A fix for bug #521671
875 * statement.cs: Fixed crash when checking missing type.
877 2009-07-16 Marek Safar <marek.safar@gmail.com>
879 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
880 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
881 class.cs, driver.cs: Work on dynamic binding.
883 * dynamic.cs: New file.
885 * *.sources, *.proj: Updated.
887 2009-07-15 Marek Safar <marek.safar@gmail.com>
889 * expression.cs (Conditional): Avoid double Resolve.
891 2009-07-13 Marcus Griep <marcus@griep.us>
893 * ecore.cs: Fix obscure bug with resolving members of interfaces
894 that hide parent interface members. Fixes bug #444388 and corrects
897 2009-07-13 Marek Safar <marek.safar@gmail.com>
899 * expression.cs (LocalVariableReference): Bounce resolve.
901 2009-07-10 Marek Safar <marek.safar@gmail.com>
903 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
904 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
907 * support.cs: New dynamic type wrapper.
909 2009-07-08 Marek Safar <marek.safar@gmail.com>
911 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
912 typed local variable.
914 2009-07-06 Marek Safar <marek.safar@gmail.com>
916 A fix for bug #519005
917 * anonymous.cs: Use null_type as no return type placeholder.
919 2009-07-02 Marek Safar <marek.safar@gmail.com>
921 * generic.cs: Handle type inference of identical type parameters
922 with different bounds.
924 2009-07-01 Marek Safar <marek.safar@gmail.com>
926 * expression.cs, class.cs: Events variance.
928 * cs-parser.jay: Interface events error messages.
930 2009-07-01 Marek Safar <marek.safar@gmail.com>
932 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
934 2009-06-29 Marek Safar <marek.safar@gmail.com>
936 * parameter.cs, convert.cs, expression.cs, class.cs: Default
937 parameter expression can be value-type New.
939 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
941 2009-06-26 Marek Safar <marek.safar@gmail.com>
943 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
944 Implemented C# 4.0 named arguments.
946 2009-06-24 Marek Safar <marek.safar@gmail.com>
948 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
949 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
950 parameter modifier. Also fixes bug #515497.
952 2009-06-24 Marek Safar <marek.safar@gmail.com>
954 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
955 arguments expression to be implemented.
957 *.sources: Add argument.cs
959 2009-06-23 Marek Safar <marek.safar@gmail.com>
961 * parameter.cs: Moved GetParameterIndexByName to base class.
963 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
964 unused AType. Use argument's version of GetExpressionTree.
966 2009-06-22 Marek Safar <marek.safar@gmail.com>
968 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
971 2009-06-17 Marek Safar <marek.safar@gmail.com>
973 A fix for bug #514096
974 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
976 2009-06-17 Marek Safar <marek.safar@gmail.com>
978 * expression.cs: The first multi-dimensional array nested array
979 initializers was not checked.
981 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
983 2009-06-17 Marek Safar <marek.safar@gmail.com>
985 A fix for bug #513400
986 * nullable.cs (EmitEquality): Operands emit could be simplified for
987 built-in types when we now emit user operators differently.
989 2009-06-16 Marek Safar <marek.safar@gmail.com>
991 * ecore.cs: Report inaccessible delegate methods correctly.
993 2009-06-16 Marek Safar <marek.safar@gmail.com>
995 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
996 cs-parser.jay: Implemented C# 4.0 optional parameters.
998 2009-06-16 Marek Safar <marek.safar@gmail.com>
1000 * driver.cs: Removed broken DefineManifestResource.
1002 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1004 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1005 Use $(BOOTSTRAP_PROFILE) instead.
1007 2009-06-12 Jb Evain <jbevain@novell.com>
1009 * rootcontext.cs: add a Platform field.
1010 * driver.cs: handle /platform.
1011 * codegen.cs: pass the proper flags according to
1012 the platform when saving the assembly.
1014 2009-06-11 Marek Safar <marek.safar@gmail.com>
1016 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1017 Add optional parameters grammar.
1019 2009-06-10 Marek Safar <marek.safar@gmail.com>
1021 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1022 driver.cs: Split lang version and metadata version.
1024 2009-06-10 Marek Safar <marek.safar@gmail.com>
1026 * decl.cs: Better overload ctor collision error message.
1028 2009-06-05 Jb Evain <jbevain@novell.com>
1030 * driver.cs (EmbededResource): avoid using an internal method
1031 in gmcs to embed manifest resources.
1033 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1035 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1036 the compiler from older mono versions (like moon's bots)
1038 2009-06-04 Marek Safar <marek.safar@gmail.com>
1040 * namespace.cs (LookupTypeReflection): Ignore collisions between
1043 2009-06-04 Marek Safar <marek.safar@gmail.com>
1045 * codegen.cs: Enabled generic type forwarders.
1047 2009-06-04 Marek Safar <marek.safar@gmail.com>
1049 * dmcs.*: Add another version of SRE compiler.
1051 2009-06-03 Marek Safar <marek.safar@gmail.com>
1053 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1054 generic-mcs.cs: Fixed variant type conversions.
1056 2009-06-02 Marek Safar <marek.safar@gmail.com>
1058 A fix for bug #507863
1059 * codegen.cs: Fixes a crash on invalid string value attribute.
1061 2009-06-01 Marek Safar <marek.safar@gmail.com>
1063 A fix for bug #508334
1064 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1065 cs-parser.jay: Fully import __arglist modifier.
1067 2009-05-29 Marek Safar <marek.safar@gmail.com>
1069 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1070 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1071 actually work with closed generic types.
1073 2009-05-27 Alan McGovern <amcgovern@novell.com>
1075 * class.cs, decl.cs, delegate.cs, parameter.cs:
1076 Fix the build by replacing the use of 'var' with the actual type.
1078 2009-05-27 Marek Safar <marek.safar@gmail.com>
1080 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1081 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1084 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1087 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1088 Marek Safar <marek.safar@gmail.com>
1090 A fix for bug #377509
1091 * parameter.cs: Use predefined and not empty name for implicit
1094 2009-05-21 Marek Safar <marek.safar@gmail.com>
1096 * class.cs: Don't report wrong warnings for event fields.
1098 2009-05-21 Marek Safar <marek.safar@gmail.com>
1100 A fix for bug #504667
1101 * class.cs: Check for static class using parent container instead of
1104 2009-05-08 Marek Safar <marek.safar@gmail.com>
1106 A fix for bug #496922
1107 * expression.cs: Always use temporary variable when using object
1110 2009-04-28 Marek Safar <marek.safar@gmail.com>
1112 A fix for bug #495112
1113 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1116 2009-04-27 Miguel de Icaza <miguel@novell.com>
1118 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1120 2009-04-24 Miguel de Icaza <miguel@novell.com>
1122 * complete.cs: No idea how gonzalo got a null in the list, but
1125 2009-04-24 Miguel de Icaza <miguel@novell.com>
1127 * complete.cs (CompletionElementInitializer): New completion class
1128 to support completing inside a C# 3 element initializer, so this
1129 allows completion for Silverlight situations where it is very
1132 new TextBlock () { Fo<TAB>
1134 (CompletionSimpleName): Expose the prefix that was
1135 passed to the simple name.
1137 * cs-parser.jay (object_or_collection_initializer): Add support
1138 for element_initializers.
1140 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1141 special case completion expressions as this method aggressively
1142 collects data before it operates, and errors were being thrown
1143 earlier than we were able to complete.
1145 2009-04-23 Miguel de Icaza <miguel@novell.com>
1147 * eval.cs: Make getcompletions silent and enable debugging output
1148 if the -v option is passed.
1150 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1151 Consider looking up the namespace that matches the prefix being
1154 This is part of the support for allowing completions like:
1155 `System.Co<TAB>' to complete to System.Console.
1157 * complete.cs (CompletionSimpleName.AppendResults): Make this
1160 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1162 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1163 COMPLETE_COMPLETION as internal.
1165 2009-04-17 Miguel de Icaza <miguel@novell.com>
1167 * complete.cs: Include namespace resolution in simple names as
1168 well as global types and types in the using scope in the
1171 * namespace.cs: Supporting infrastrcture to provide completions
1172 based on the current using scope.
1174 * eval.cs: Introduce an entry point that allows for initialization
1175 to return a list of the files passed on the command line.
1177 2009-04-14 Marek Safar <marek.safar@gmail.com>
1179 A fix for bug #494243
1180 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1182 2009-04-13 Marek Safar <marek.safar@gmail.com>
1184 A fix for bug #493887
1185 * statement.cs: Don't skip string multi-section with default or
1186 null label when populating string hashtable.
1188 2009-04-06 Marek Safar <marek.safar@gmail.com>
1190 A fix for bug #492329
1191 * expression.cs (New): Load variable when assigning type parameter
1194 2009-04-06 Marek Safar <marek.safar@gmail.com>
1196 A fix for bug #488960
1197 * decl.cs: Compare MVAR types using non-null values.
1199 2009-03-27 Marek Safar <marek.safar@gmail.com>
1201 * typemanager.cs, expression.cs: Removed unused nullable checks.
1203 2009-03-27 Marek Safar <marek.safar@gmail.com>
1205 * *.cs: Removed some gmcs conditionals.
1207 2009-03-26 Marek Safar <marek.safar@gmail.com>
1209 * generic.cs, support.cs: Moved generics stuff out of support.cs
1211 2009-03-24 Marek Safar <marek.safar@gmail.com>
1213 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1216 2009-03-23 Marek Safar <marek.safar@gmail.com>
1218 * attribute.cs: Consider all members for error reporting when
1219 checking named arguments.
1221 2009-03-23 Marek Safar <marek.safar@gmail.com>
1223 A fix for bug #487625
1224 * namespace.cs: Use a warning for all predefined type conflicts.
1226 2009-03-23 Marek Safar <marek.safar@gmail.com>
1228 A fix for bug #485706
1229 * statement.cs: Explicitly type catch type argument to pass verifier
1232 2009-03-22 Miguel de Icaza <miguel@novell.com>
1234 Initial support to provide code completion facilities to consumers
1235 of the evaluator API.
1237 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1238 support the completion engine. When we reach the end of the
1239 input stream instead of returning EOF, when this flag is true the
1240 tokenizer instead produces:
1242 One GENERATE_COMPLETION token: this token then must be
1243 handled in the grammar at every point where the user
1244 would likely request a completion.
1246 As many COMPLETE_COMPLETION tokens as necessary. These
1247 tokens are generated to assist the parser in unwinding and
1248 producing a valid parse tree.
1250 The parser rules do not have to be perfect, the parser needs to be
1251 augmented with judicious use of GENERATE_COMPLETION tokens to
1252 improve the areas where we can provide completion and the parser
1253 needs to add support for COMPLETE_COMPLETION tokens in productions
1256 It is common to not have enough support for COMPLETE_COMPLETION
1257 under certain rules and that even if we generated the
1258 GENERATE_COMPLETION token that the resulting tree will be invalid
1259 due to the missing rules that support COMPLETE_COMPLETION.
1261 The final EOF token is produced by having the parser notify the
1262 tokenizer when it reaches the root production that the next token
1265 * support.cs (CompletionResult): New Exception. This exception
1266 is thrown to return the completion results when one of the special
1267 completion expressions is reached.
1269 This exception is thrown by the completing ExpressionStatements
1270 classes that live in complete.cs
1272 * complete.cs (CompletingExpression): a new base class for
1273 completing expressions. This derives from the
1274 ExpressionStatement class and not from Expression as it allows
1275 completion to happen not only where expressions are expected in
1276 the grammar, but also where statements are expected.
1278 (CompletionSimpleName): A new class used to provide completions
1279 for SimpleNames. This currently only resolves to local
1280 variables from the evaluator context (GetVars call).
1282 (CompletionMemberAccess): Implements support for completing member
1285 * cs-parser.jay: Add support for completion in a few places.
1287 * eval.cs (GetCompletions): New public API for the evaluator that
1288 returns a list of possible completions given the input. The
1289 return value is an array of completions
1291 * anonymous.cs (Compatible): If the exception thrown from the
1292 resolved expression is a CompletionResult exception let that one
1293 through instead of printing a diagnostic error in the try/catch.
1295 2009-03-22 Miguel de Icaza <miguel@novell.com>
1299 * driver.cs (Main): Use Environment.Exit to quit quickly and
1300 prevent the compiler from doing the usual wait for helper thread
1303 This is to prevent a slowdown that was reported by Gonzalo on
1306 2009-03-19 Marek Safar <marek.safar@gmail.com>
1308 * ecore.cs: Load build-in types directly instead of accessing
1311 2009-03-18 Marek Safar <marek.safar@gmail.com>
1313 * ecore.cs: Always use unbox.any when available.
1315 2009-03-18 Marek Safar <marek.safar@gmail.com>
1317 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1319 2009-03-17 Marek Safar <marek.safar@gmail.com>
1321 * generic.cs: Removed obsolete version of type inference.
1323 2009-03-16 Marek Safar <marek.safar@gmail.com>
1325 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1326 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1327 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1328 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1330 2009-03-11 Marek Safar <marek.safar@gmail.com>
1332 A fix for bug #482996
1333 * anonymous.cs: Make sure we are not infering return type when
1334 checking type compatibility.
1336 2009-03-11 Marek Safar <marek.safar@gmail.com>
1338 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1339 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1340 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1341 attributes in their own structure. Needed when accessing their
1342 properties before they are resolved.
1344 2009-03-09 Marek Safar <marek.safar@gmail.com>
1346 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1347 hashtable (~10x faster).
1349 * driver.cs: Removed wrong Reset.
1351 2009-03-08 Marek Safar <marek.safar@gmail.com>
1353 * class.cs: Use correct common base type for unmanaged delayed
1356 * rootcontext.cs: Wrap unhandled exception.
1358 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1360 Make SeekableStreamReader self-tuning and arbitrarily seekable
1361 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1363 (SeekableStreamReader.Position.set): Use it. Simplify logic
1364 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1365 buffer size when the stream needs to be re-read from the beginning.
1367 2009-03-05 Marek Safar <marek.safar@gmail.com>
1369 A fix for bug #480100
1370 * parameter.cs: A parameter is not hoisted when used directly as ET.
1372 2009-03-04 Marek Safar <marek.safar@gmail.com>
1374 * statement.cs: Fixed an issue when using variable is of interface
1377 2009-03-03 Marek Safar <marek.safar@gmail.com>
1379 A fix for bug #480319
1380 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1382 2009-03-03 Marek Safar <marek.safar@gmail.com>
1384 A fix for bug #480867
1385 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1386 expression to have no valid type.
1388 2009-03-03 Marek Safar <marek.safar@gmail.com>
1390 A fix for bug #481258
1391 * class.cs: Set extension method flag in partial container.
1393 2009-03-03 Marek Safar <marek.safar@gmail.com>
1395 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1397 * attribute.cs: Add sanity check.
1399 2009-02-27 Marek Safar <marek.safar@gmail.com>
1401 * class.cs: Add external constructor error.
1403 2009-02-26 Marek Safar <marek.safar@gmail.com>
1405 A fix for bug #475354
1406 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1407 correctly user defined nullable equality operators.
1409 2009-02-25 Marek Safar <marek.safar@gmail.com>
1411 A fix for bug #479532
1412 * expression.cs: Implement NewInitialize::AddressOf.
1414 2009-02-25 Marek Safar <marek.safar@gmail.com>
1416 A fix for bug #413633
1417 * expression.cs: Iterate all base class-constraint types.
1419 2009-02-24 Marek Safar <marek.safar@gmail.com>
1421 A fix for bug #479209
1422 * literal.cs: Mutate null underlying type.
1424 2009-02-24 Marek Safar <marek.safar@gmail.com>
1426 A fix for bug #476295
1427 * convert.cs: Avoid wrapping implicitly convertible reference type.
1429 2009-02-23 Marek Safar <marek.safar@gmail.com>
1431 * iterators.cs: Create MemberName correctly.
1433 2009-02-23 Marek Safar <marek.safar@gmail.com>
1435 A fix for bug #478655
1436 * literal.cs: Check also underlying null type conversion.
1438 2009-02-21 Marek Safar <marek.safar@gmail.com>
1440 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1442 2009-02-20 Marek Safar <marek.safar@gmail.com>
1444 A fix for bug #477447
1445 * statement.cs: Add reference to correct parent storey when this
1446 is accessible from deep children storey (more than 1 level).
1448 2009-02-19 Marek Safar <marek.safar@gmail.com>
1450 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1451 * class.cs: Define base type members before setting up member cache.
1453 2009-02-18 Marek Safar <marek.safar@gmail.com>
1455 A fix for bug #477378
1456 * nullable.cs, expression.cs, statement.cs: More precise null type
1459 2009-02-18 Marek Safar <marek.safar@gmail.com>
1461 A fix for bug #472805
1462 * typemanager.cs, namespace.cs: Import only visible extension method
1465 2009-02-18 Marek Safar <marek.safar@gmail.com>
1467 A fix for bug #476895
1468 * attribute.cs: Use correct resolve context for attribute type.
1470 2009-02-18 Marek Safar <marek.safar@gmail.com>
1472 A fix for bug #476266
1473 * anonymous.cs: Mutate multi-dimensional arrays.
1475 2009-02-18 Marek Safar <marek.safar@gmail.com>
1477 A fix for bug #476400
1478 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1480 2009-02-18 Marek Safar <marek.safar@gmail.com>
1482 A fix for bug #476811
1483 * generics.cs: Fixed null-literal check.
1485 2009-02-17 Marek Safar <marek.safar@gmail.com>
1487 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1488 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1489 messing with static variables.
1491 2009-02-16 Marek Safar <marek.safar@gmail.com>
1493 A fix for bug #475965
1494 * generics.cs: Check generic parameter type after extracting from
1497 2009-02-16 Marek Safar <marek.safar@gmail.com>
1499 A fix for bug #475823
1500 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1503 2009-02-14 Marek Safar <marek.safar@gmail.com>
1505 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1506 Simplified event field definition using backing field and not
1507 field builder directly.
1509 * expression.cs (EmitLdArg): Optimize fast paths.
1511 2009-02-13 Marek Safar <marek.safar@gmail.com>
1513 A fix for bug #475327
1514 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1516 2009-02-13 Marek Safar <marek.safar@gmail.com>
1518 A fix for bug #475342
1519 * cs-parser.jay: Using 'super' instead of 'base' to call base
1520 constructor crashes compiler.
1522 2009-02-13 Marek Safar <marek.safar@gmail.com>
1524 A fix for bug #475354
1525 * expression.cs (Constantify): Add nullable types.
1527 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1529 2009-02-12 Marek Safar <marek.safar@gmail.com>
1531 A fix for bug #475246
1532 * expression.cs: More broken flowanalysis hacking needed.
1534 2009-02-12 Marek Safar <marek.safar@gmail.com>
1536 * attribute.cs: Compare only ref/out array modifiers.
1538 2009-02-11 Marek Safar <marek.safar@gmail.com>
1540 * statement.cs: Use member cache when looking for foreach members.
1542 2009-02-11 Marek Safar <marek.safar@gmail.com>
1544 * expression.cs: Don't expose internal initializer types.
1546 * statement.cs: Check also explicit conversions for goto case.
1548 2009-02-11 Marek Safar <marek.safar@gmail.com>
1550 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1552 2009-02-10 Marek Safar <marek.safar@gmail.com>
1554 * *.cs: Replace null-type with NullLiteral where appropriate.
1556 2009-02-09 Marek Safar <marek.safar@gmail.com>
1558 * expression.cs: Initializer of reference argument use temporary
1559 variable to be verifiable.
1561 * parameter.cs: Share EmitLdArg.
1563 2009-02-09 Marek Safar <marek.safar@gmail.com>
1565 A fix for bug #473559
1566 * class.cs: Fixed: Not reporting error about nested class with the
1569 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1571 Contributed under the MIT/X11 license.
1573 * generic.cs: Added VerifyVariantTypeParameters which performs new
1574 variance verification logic. The old logic, based on the spec, was
1575 wrong because the spec is full of LIES!
1577 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1579 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1582 * ecore.cs: Added calls to the new variance verification logic.
1585 * delegate.cs: Removed calls to the old variance verification logic.
1587 2009-02-06 Marek Safar <marek.safar@gmail.com>
1589 * delegate.cs: Use cached Invoke method directly.
1591 2009-02-06 Marek Safar <marek.safar@gmail.com>
1593 * expression.cs: Emit expression tree for hoisted variable access.
1595 2009-02-04 Marek Safar <marek.safar@gmail.com>
1597 * namespace.cs: Add better extension class check.
1599 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
1601 * generic.cs: Fixed typeo (TypeParameter.Variacne).
1603 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
1605 This patch adds initial generic variance support to the compiler.
1606 It is contributed under the MIT/X11 license.
1608 * typemanager.cs: Modified ImplementsInterface to check variance.
1609 Added VerifyVariantTypeParameters which checks the specified type to see
1610 if it uses a variant type parameter as a type argument (which is not
1611 allowed). Added IsVariantOf which determins if the first type is a
1612 variant of the second. NOTE: This only supports reference types at
1613 the moment to conform with the current level of VM support. When the
1614 VM supports value types, this will follow step.
1616 * generic.cs: Added the Variance enum. Added a Variance property to
1617 TypeParameter and added variance support to definition phase. Added a
1618 Variance property to TypeParameterName. Also check to make sure that
1619 no variant types appear in generic method parameters.
1621 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
1622 keywords if the langversion supports it.
1624 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
1625 that variant types are only used in legal positions. Also added
1626 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
1629 * decl.cs: Construct TypeParameter with the variance information.
1631 * convert.cs: Checks variance in ImplicitReferenceConversionExists
1632 and ImplicitConversionStandard.
1634 * rootcontext.cs: Added new "Future" language version.
1636 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
1637 type parameters are not used as type arguments in interface inheritance.
1638 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
1639 parameters are not used as method return types. In MemberBase.
1640 ResolveMemberType, ensure that variant type parameters are not used
1641 as type arguments. Also call VerifyNoVariantTypeParameters on every
1642 set of parameters which are resolved.
1644 * delegate.cs: Modified Delegate.Define to ensure that variant
1645 parameters are not used as type arguments and that a contravariant
1646 parameter is not used as the return type. Also call
1647 VerifyNoVariantTypeParameters on the delegate parameters.
1649 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
1650 to specify generic variance.
1652 * driver.cs: Added support for LanguageVersion.Future in the form of
1653 "-langversion:future".
1655 * generic-mcs.cs: Stubbed out new members in generic.cs.
1657 2009-02-03 Marek Safar <marek.safar@gmail.com>
1659 * class.cs, generic.cs: Emit type parameter constraints for nested
1662 2009-02-02 Marek Safar <marek.safar@gmail.com>
1664 A fix for bug #471213
1665 * class.cs: Avoid emitting backing field for abstract event fields.
1667 2009-02-01 Marek Safar <marek.safar@gmail.com>
1669 A fix for bug #359731
1670 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
1673 2009-01-30 Marek Safar <marek.safar@gmail.com>
1675 A fix for bug #470767
1676 * statement.cs: Introduced BlockScopeExpression, needed when
1677 expression tree conversion has to emit scope variables.
1679 2009-01-29 Marek Safar <marek.safar@gmail.com>
1681 * class.cs: Remove duplicate CallingConvention.
1683 2009-01-29 Marek Safar <marek.safar@gmail.com>
1685 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
1686 when I finally found the right naming convention.
1688 2009-01-29 Marek Safar <marek.safar@gmail.com>
1690 * cs-tokenizer.cs: Put back different open parens optimization.
1692 2009-01-28 Marek Safar <marek.safar@gmail.com>
1694 A fix for bug #470227
1695 * cs-tokenizer.cs: Remove too agressive parser optimization.
1697 2009-01-28 Marek Safar <marek.safar@gmail.com>
1699 A fix for bug #324319
1700 * class.cs: Remove too early base type resolve.
1702 2009-01-27 Marek Safar <marek.safar@gmail.com>
1704 A fix for bug #324319
1705 * ecore.cs: Explicitly type null when assigning to type argument to
1706 make pass verifier check.
1708 2009-01-27 Marek Safar <marek.safar@gmail.com>
1710 * anonymous.cs: Fixed recent regression when initializing captured
1713 2009-01-26 Marek Safar <marek.safar@gmail.com>
1715 A fix for bug #469019
1716 * anonymous.cs: Use all parent type parameters when instantiating
1717 nested generic storey.
1719 2009-01-26 Marek Safar <marek.safar@gmail.com>
1721 * expression.cs: Check for null instance methodgroup expression.
1723 2009-01-26 Marek Safar <marek.safar@gmail.com>
1725 A fix for bug #469244
1726 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
1727 instance inside a conditional expression.
1729 2009-01-23 Marek Safar <marek.safar@gmail.com>
1731 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
1732 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
1733 GetElementType and HasElementType. IsValueType clean up.
1735 2009-01-23 Marek Safar <marek.safar@gmail.com>
1737 * nullable.cs: Use common EmitCall.
1739 * expression.cs: Emit constraint. for virtual calls only.
1741 2009-01-23 Marek Safar <marek.safar@gmail.com>
1743 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
1744 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
1745 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
1748 2009-01-22 Jb Evain <jbevain@novell.com>
1750 * anonymous.cs: make anonymous types' ToString implementation
1751 match what csc outputs.
1753 2009-01-21 Marek Safar <marek.safar@gmail.com>
1755 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
1758 2009-01-17 Marek Safar <marek.safar@gmail.com>
1760 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
1763 2009-01-16 Marek Safar <marek.safar@gmail.com>
1765 * nullable.cs (LiftedBinaryOperator): Check for all possible null
1768 2009-01-15 Marek Safar <marek.safar@gmail.com>
1770 A fix for bug #466634
1771 * statement.cs: Add reference for nested storey when only this
1774 2009-01-15 Marek Safar <marek.safar@gmail.com>
1776 A fix for bug #466474
1777 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
1780 2009-01-15 Marek Safar <marek.safar@gmail.com>
1782 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
1783 Fixed nested stories parent referencing process. Also fixes #463985.
1785 2009-01-06 Marek Safar <marek.safar@gmail.com>
1787 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
1788 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
1789 implementation. Also fixes #463108.
1791 2009-01-05 Marek Safar <marek.safar@gmail.com>
1793 A fix for bug #416109
1794 * decl.cs: Issue correct CLSAttribute warning location.
1796 2009-01-05 Marek Safar <marek.safar@gmail.com>
1798 A fix for bug #456775
1799 * attribute.cs: Use attribute owner scope when resolving attribute
1802 2009-01-05 Marek Safar <marek.safar@gmail.com>
1804 A fix for bug #457257
1805 * decl.cs: Fixed incorrect member declaring type comparison.
1807 2009-01-05 Marek Safar <marek.safar@gmail.com>
1809 A fix for bug #460896
1810 * driver.cs: Handle /RES resources as embeddable.
1812 2009-01-05 Marek Safar <marek.safar@gmail.com>
1814 A fix for bug #462515
1815 * ecore.cs: Report inacessible members upwards.
1817 2009-01-05 Marek Safar <marek.safar@gmail.com>
1819 A fix for bug #463190, #463192
1820 * decl.cs, namespace.cs: Also import internal extension classes.
1822 2009-01-04 Marek Safar <marek.safar@gmail.com>
1824 A fix for bug #463415
1825 * generic.cs: Use right index for RemoveDependentTypes.
1827 2009-01-02 Marek Safar <marek.safar@gmail.com>
1829 A fix for bug #463196
1830 * expression.cs: Fixed enum to null comparison.
1832 2009-01-02 Marek Safar <marek.safar@gmail.com>
1834 A fix for bug #463121
1835 * nullable.cs: Fixed nullable user equality operator comparison.
1837 2009-01-02 Marek Safar <marek.safar@gmail.com>
1839 A fix for bug #462950
1840 * class.cs, decl.cs: Use full explicit name when defining automatic
1841 property backing field.
1843 2009-01-02 Marek Safar <marek.safar@gmail.com>
1845 A fix for bug #462592
1846 * pending.cs: Emit type arguments for generic proxy method.
1848 2008-12-30 Marek Safar <marek.safar@gmail.com>
1850 * expression.cs (As): Mutate all type arguments.
1852 2008-12-29 Marek Safar <marek.safar@gmail.com>
1854 A fix for bug #462622
1855 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
1858 2008-12-29 Marek Safar <marek.safar@gmail.com>
1860 A fix for bug #450782
1861 * ecore.cs: Consider more variables of form V.I to be fixed.
1863 2008-12-29 Marek Safar <marek.safar@gmail.com>
1865 A fix for bug #460712
1866 * typemanager.cs: Core types could be imported.
1868 2008-12-28 Marek Safar <marek.safar@gmail.com>
1870 A fix for bugs #460847, #460772, #458049, #457339, #447807
1871 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
1872 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
1873 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
1874 user lambdas used inside query clauses.
1876 2008-12-18 Marek Safar <marek.safar@gmail.com>
1878 A fix for bug #460229
1879 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
1881 2008-12-18 Marek Safar <marek.safar@gmail.com>
1883 A fix for bug #459952
1884 * decl.cs, namespace.cs: Use common CheckAccessLevel.
1886 2008-12-18 Marek Safar <marek.safar@gmail.com>
1888 A fix for bug #459630
1889 * convert.cs: Enum to valuetype conversion is not allowed.
1891 2008-12-18 Marek Safar <marek.safar@gmail.com>
1893 A fix for bug #457087
1894 * generic.cs: Don't crash when constraint comes from type
1897 2008-12-16 Marek Safar <marek.safar@gmail.com>
1899 A fix for bug #459221
1900 * anonymous.cs, statement.cs: Delay only captured this
1903 2008-12-12 Marek Safar <marek.safar@gmail.com>
1905 A fix for bug #457489
1906 * anonymous.cs, statement.cs: Split anonymous storey instantiation
1907 and initialization to capture scope initializers correctly.
1909 2008-12-11 Marek Safar <marek.safar@gmail.com>
1911 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
1912 ParameterReference refactoring.
1914 2008-12-03 Marek Safar <marek.safar@gmail.com>
1916 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
1917 to be imported from any assembly.
1919 2008-12-03 Marek Safar <marek.safar@gmail.com>
1921 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
1922 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
1923 from anonymous method and lambda expression.
1925 2008-12-01 Marek Safar <marek.safar@gmail.com>
1927 A fix for bug #448560
1928 * expression.cs (As): Box any generic type arguments to be
1931 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1933 Add tripwire for implicit conversion bugs
1934 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
1936 (MethodGroupExpr.OverloadResolve): Add sanity check between
1937 IsApplicable and VerifyArgumentsCompat.
1938 (VerifyArgumentsCompat): Report CS1501 where appropriate.
1940 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1942 Fix build break in System.Data_test
1943 * convert.cs (ImplicitConversionExists): Move NullLiteral
1945 (ImplicitStandardConversionExists): ... here.
1947 2008-11-28 Marek Safar <marek.safar@gmail.com>
1949 * literal.cs: Emit correctly explicit null to nullable cast.
1951 2008-11-28 Marek Safar <marek.safar@gmail.com>
1953 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
1956 2008-11-28 Marek Safar <marek.safar@gmail.com>
1958 A fix for bug #449005
1959 * convert.cs, nullable.cs: Use only one implicit nullable
1962 2008-11-27 Marek Safar <marek.safar@gmail.com>
1964 * convert.cs, literal.cs: More Convert cleanup is needed.
1966 2008-11-27 Marek Safar <marek.safar@gmail.com>
1968 * decl.cs, class.cs: Fixed misleading error message.
1970 2008-11-26 Marek Safar <marek.safar@gmail.com>
1972 A fix for bug #449005
1973 * nullable.cs (EmitEquality): Disable optimization for user operator
1976 2008-11-25 Marek Safar <marek.safar@gmail.com>
1978 A fix for bug #447027
1979 * anonymous.cs (HoistedVariable): Cache also outer access to deal
1980 with context variables stored as expression instances.
1982 2008-11-25 Marek Safar <marek.safar@gmail.com>
1984 A fix for bug #447027
1985 * delegate.cs: Fixed delegate VerifyMethod logic.
1987 2008-11-24 Marek Safar <marek.safar@gmail.com>
1989 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
1992 2008-11-21 Marek Safar <marek.safar@gmail.com>
1994 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
1995 member type resolve to follow normal flow, instead of random
1998 2008-11-21 Marek Safar <marek.safar@gmail.com>
2000 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2003 2008-11-21 Marek Safar <marek.safar@gmail.com>
2005 * const.cs: Emit decimal array constant as literal.
2007 2008-11-20 Marek Safar <marek.safar@gmail.com>
2009 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2011 2008-11-19 Marek Safar <marek.safar@gmail.com>
2013 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2014 into real property (saves 8 MB for corlib compilation).
2016 2008-11-19 Marek Safar <marek.safar@gmail.com>
2018 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2019 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2020 generic-mcs.cs: Small cleanup of TypeArguments.
2022 2008-11-18 Marek Safar <marek.safar@gmail.com>
2024 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2025 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2026 of ConstructedType expression, renamed to GenericTypeExpr.
2028 2008-11-17 Marek Safar <marek.safar@gmail.com>
2030 A fix for bug #445303
2031 * location.cs (IsConditionalDefined): Handle undefined global
2034 2008-11-17 Marek Safar <marek.safar@gmail.com>
2036 A fix for bug #444678
2037 * expression.cs (TryReduceConstant): Always create new constant
2040 2008-11-17 Marek Safar <marek.safar@gmail.com>
2042 A fix for bug #444673
2043 * ecore.cs: Ignore open generic types when used as generic type
2046 2008-11-17 Marek Safar <marek.safar@gmail.com>
2048 A fix for bug #445458
2049 * expression.cs, cs-parser.jay: Don't crash when an expression
2052 2008-11-17 Marek Safar <marek.safar@gmail.com>
2054 A fix for bug #445464
2055 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2056 inside unbound type.
2058 2008-11-14 Jb Evain <jbevain@novell.com>
2060 * driver.cs: ignore empty -nowarn argument such as
2061 the one in -nowarn:12,13,,.
2063 2008-11-13 Marek Safar <marek.safar@gmail.com>
2065 A fix for bug #444271
2066 * anonymous.cs: Rescan parent storeys when best candidate was
2069 2008-11-13 Marek Safar <marek.safar@gmail.com>
2071 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2072 useless UnboundTypeExpression.
2074 * attribute.cs: Do check obsolete attribute on generic types.
2076 2008-11-12 Marek Safar <marek.safar@gmail.com>
2078 A fix for bugs #425680, #400139
2079 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2082 2008-11-11 Marek Safar <marek.safar@gmail.com>
2084 A fix for bug #435747
2085 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2086 compound value types assignment. Few micro optimizations added.
2088 2008-11-10 Marek Safar <marek.safar@gmail.com>
2090 A fix for bug #442610
2091 * anonymous.cs (MutateConstructor): More SRE hacking.
2093 2008-11-10 Marek Safar <marek.safar@gmail.com>
2095 A fix for bug #442579
2096 * ecore.cs: Also initialize expanded form of a method with 1 params
2099 2008-11-06 Marek Safar <marek.safar@gmail.com>
2101 * expression.cs (UnaryMutator): Do early l-side check.
2103 2008-11-05 Miguel de Icaza <miguel@novell.com>
2105 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2106 Init, otherwise we would crash later on when checking for friend
2109 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2110 Otherwise we never get any meaningful information as to what
2113 2008-11-05 Marek Safar <marek.safar@gmail.com>
2115 A fix for bug #436318
2116 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2118 2008-11-05 Miguel de Icaza <miguel@novell.com>
2120 * namespace.cs: Turns out that it was a really bad idea to hide
2121 the errors for namespaces not found here in eval mode.
2123 * eval.cs: When we process using clauses, only enter those into
2124 the list of valid using clauses after they have been validated.
2126 The above change gives the proper semantics: it does not
2127 senselessly report the same errors with broken using statements by
2128 never storing them in the first place when they are invalid.
2130 2008-11-05 Marek Safar <marek.safar@gmail.com>
2132 A fix for bug #421839
2133 * cs-parser.jay: Remove expression from coalesce rule to force lower
2134 priority than the assignment operator.
2136 2008-11-05 Marek Safar <marek.safar@gmail.com>
2138 A fix for bug #437875
2139 * nullable.cs: Compile correctly method group operand used with null
2140 coalescing operator.
2142 2008-11-04 Marek Safar <marek.safar@gmail.com>
2144 A fix for bug #434589
2145 * expression.cs (Binary): Ignore lifted conversions when at least
2146 one operand is of reference type.
2148 2008-11-04 Marek Safar <marek.safar@gmail.com>
2150 * cs-parser.jay: Better syntax error report.
2152 2008-11-03 Marek Safar <marek.safar@gmail.com>
2154 A fix for bug #436792
2155 * cs-parser.jay: Use GetLocation to access location.
2157 2008-11-03 Marek Safar <marek.safar@gmail.com>
2159 A fix for bug #440774
2160 * cs-parser.jay: Also set current_array_type when parsing local
2163 2008-11-03 Marek Safar <marek.safar@gmail.com>
2165 A fix for bug #440785
2166 * expression.cs (As): Don't resolve self modifing expression
2169 2008-11-03 Marek Safar <marek.safar@gmail.com>
2171 A fix for bug #439447
2172 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2174 2008-11-03 Marek Safar <marek.safar@gmail.com>
2176 A fix for bug #437571
2177 * cs-parser.jay: Fixes internal error for invalid expression
2180 2008-10-17 Marek Safar <marek.safar@gmail.com>
2182 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2184 2008-10-17 Marek Safar <marek.safar@gmail.com>
2186 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2188 2008-10-17 Marek Safar <marek.safar@gmail.com>
2190 * cs-tokenizer.cs: More precise cast parsing.
2192 2008-10-16 Martin Baulig <martin@ximian.com>
2194 * anonymous.cs (AnonymousMethodStorey): Put back the
2195 `hoisted_locals' hashtable and use it in EmitType().
2197 2008-10-15 Marek Safar <marek.safar@gmail.com>
2199 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2200 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2203 2008-10-14 Marek Safar <marek.safar@gmail.com>
2205 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2207 2008-10-14 Marek Safar <marek.safar@gmail.com>
2209 * statement.cs: Mutate scope initializers.
2211 2008-10-14 Marek Safar <marek.safar@gmail.com>
2213 * expression.cs: Use typeless value for This constant.
2215 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2217 2008-10-14 Marek Safar <marek.safar@gmail.com>
2219 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2222 2008-10-13 Marek Safar <marek.safar@gmail.com>
2224 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2227 2008-10-13 Marek Safar <marek.safar@gmail.com>
2229 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2230 parser and tokenizer. Fixes many ambiguities including #433258.
2232 2008-10-10 Marek Safar <marek.safar@gmail.com>
2234 * cs-parser.jay: Fixed missing accessor recovery.
2236 2008-10-10 Marek Safar <marek.safar@gmail.com>
2238 A fix for bug #433701
2239 * expression.cs: Better error message.
2241 2008-10-10 Marek Safar <marek.safar@gmail.com>
2243 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2245 * Makefile: Disabled unused debug symbols.
2247 Also fixes: #320556, #321097, #321656, #321876, #351316
2249 2008-10-09 Miguel de Icaza <miguel@novell.com>
2251 * eval.cs: rename "<interactive>" to "{interactive}", to work
2252 around a requirement in the compiler that this be a valid
2253 filename, and in Windows it is not (433886).
2255 2008-10-09 Marek Safar <marek.safar@gmail.com>
2257 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2259 2008-10-08 Marek Safar <marek.safar@gmail.com>
2261 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2262 cs-parser.jay: Generic type declaration and type arguments cleanup.
2264 2008-10-05 Marek Safar <marek.safar@gmail.com>
2266 * cs-parser.jay: Allow parsing weird array creation construct.
2268 2008-10-05 Marek Safar <marek.safar@gmail.com>
2270 * cs-parser.jay: Conflicts reduction.
2272 2008-10-04 Marek Safar <marek.safar@gmail.com>
2274 * cs-parser.jay: Conflicts reduction.
2276 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2279 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2280 property. Add a 'count' hint about the use of the shared vector.
2281 Ensure that we don't leak out dirty bits.
2282 (UsageVector.MergeChild): Throw away information about variables
2284 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2286 2008-10-03 Marek Safar <marek.safar@gmail.com>
2288 A fix for bug #431746
2289 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2290 parameters when iterator is created.
2292 2008-10-03 Marek Safar <marek.safar@gmail.com>
2294 A fix for bug #431827
2295 * expression.cs: Fixed right based pointer arithmetic operations
2298 2008-10-03 Marek Safar <marek.safar@gmail.com>
2300 A fix for bug #353779
2301 * assign.cs, expression.cs: Fixed compound assignment conversions.
2303 2008-10-02 Marek Safar <marek.safar@gmail.com>
2305 A fix for bug #375262
2306 * statement.cs: Refactor ArrayForeach to be usable with string
2307 indexer. Optimized single dimentional arrays foreach.
2309 2008-10-02 Marek Safar <marek.safar@gmail.com>
2311 A fix for bug #431255
2312 * anonymous.cs, expression.cs: Removed broken optimization.
2314 2008-10-01 Marek Safar <marek.safar@gmail.com>
2316 * anonymous.cs: Use full type parameters of parent generic
2317 containers. Removed unnecessary AddParentStoreyReference call.
2319 2008-10-01 Marek Safar <marek.safar@gmail.com>
2321 A fix for bug #324702
2322 * class.cs: Use better shorter names for explicit interface member
2325 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2327 2008-10-01 Marek Safar <marek.safar@gmail.com>
2329 * expression.cs: Use new interface to check fixed expression.
2331 2008-10-01 Marek Safar <marek.safar@gmail.com>
2333 A fix for bug #421101
2334 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2335 interface to check for fixed fixed-buffers.
2337 2008-10-01 Marek Safar <marek.safar@gmail.com>
2339 A fix for bug #429264
2340 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2342 * delegate.cs: Removed unnecessary casts.
2344 2008-09-30 Marek Safar <marek.safar@gmail.com>
2346 A fix for bug #352151
2347 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2348 class.cs: Fixed already defined explicit interface members check.
2350 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2352 cs-tokenizer.cs: Fix typo.
2354 2008-09-28 Miguel de Icaza <miguel@novell.com>
2356 * eval.cs (InteractiveBase): The quit command now just sets a
2357 flag, instead of calling Environment.Exit(), it is milder on
2360 CompiledMethod is now in Mono.CSharp, not nested inside
2361 the Evaluator, it was inconvenient to use.
2363 2008-09-27 Miguel de Icaza <miguel@novell.com>
2365 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2366 code to be invoked without having to reparse.
2368 2008-09-27 Miguel de Icaza <miguel@novell.com>
2370 * ecore.cs: The recent changes to FieldExpr broke this as well.
2371 Fixes LINQ queries in the interactive shell.
2373 * Multiple files: indentation fixing for the Mono coding
2374 guidelines for the switch statement.
2376 * eval.cs: Make the Evaluator API thread safe.
2378 2008-09-26 Marek Safar <marek.safar@gmail.com>
2380 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2381 constructor parsing.
2383 2008-09-26 Marek Safar <marek.safar@gmail.com>
2385 A fix for bug #325326
2386 * statement.cs: Check possible mistaken empty statement using
2387 explicit blocks only.
2389 2008-09-25 Miguel de Icaza <miguel@novell.com>
2391 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2392 RootNamespace.ComputeNamespaces to update the internal list of
2393 namespaces, this is no longer done for us.
2395 (InteractiveBase): Use the Evaluator APIs instead of calling into
2398 2008-09-25 Marek Safar <marek.safar@gmail.com>
2400 A fix for bug #429264
2401 * expression.cs: Missing mutator for access to multidimensional
2404 2008-09-25 Marek Safar <marek.safar@gmail.com>
2406 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2409 * driver.cs: Missing input argument check.
2411 2008-09-25 Marek Safar <marek.safar@gmail.com>
2413 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2414 expression.cs, statement.cs, rootcontext.cs, class.cs,
2415 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2418 2008-09-24 Miguel de Icaza <miguel@novell.com>
2420 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2421 fully constructed FieldExpr, fixes the regression introduced in
2424 * ecore.cs, expression.cs: Plug back the eclass initialization as
2425 otherwise it regresses `csharp'.
2427 2008-09-24 Marek Safar <marek.safar@gmail.com>
2429 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2430 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2431 phase to resolve phase. It resolves problems with expression trees
2432 and fixes bugs #323796, #325156.
2434 2008-09-23 Marek Safar <marek.safar@gmail.com>
2436 * codegen.cs: Report better error when symbol writer is missing.
2438 2008-09-23 Marek Safar <marek.safar@gmail.com>
2440 * codegen.cs: Set .NET symbol writer.
2442 * decl.cs: Guard against null generic arguments.
2444 * report.cs: Don't report exactly same additional details.
2446 2008-09-22 Marek Safar <marek.safar@gmail.com>
2448 A fix for bug #324917
2449 * cs-parser.jay: Add missing multidimensional non-expression type
2452 2008-09-22 Marek Safar <marek.safar@gmail.com>
2454 A fix for bug #428191
2455 * anonymous.cs: Create an outer generic fields also for non-storey
2458 2008-09-22 Marek Safar <marek.safar@gmail.com>
2460 A fix for bug #378294
2461 * class.cs: Make fixed size buffers gmcs feature only.
2463 2008-09-22 Marek Safar <marek.safar@gmail.com>
2465 A fix for bug #355622, #324993
2466 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2469 2008-09-19 Marek Safar <marek.safar@gmail.com>
2471 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2474 2008-09-19 Marek Safar <marek.safar@gmail.com>
2476 A fix for bug #416110
2477 * generic.cs: Struct constraint results in default ctor and
2478 ValueType base type constraint to be set.
2480 2008-09-19 Marek Safar <marek.safar@gmail.com>
2482 A fix for bug #423791
2483 * generic.cs: Fixed params output type type-inference.
2485 2008-09-19 Marek Safar <marek.safar@gmail.com>
2487 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2489 2008-09-19 Marek Safar <marek.safar@gmail.com>
2491 * cs-tokenizer.cs: Don't break on extra partial modifier.
2493 2008-09-19 Marek Safar <marek.safar@gmail.com>
2495 A fix for bug #427592
2496 * generic.cs: Use common parameter resolve method.
2498 2008-09-18 Marek Safar <marek.safar@gmail.com>
2500 A fix for bug #414758
2501 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2504 2008-09-18 Marek Safar <marek.safar@gmail.com>
2506 * driver.cs, namespace.cs: Read types and namespaces after all
2507 requested assemblies are loaded, fixes issues with System.Core
2508 auto-reference, and #419888.
2510 2008-09-18 Marek Safar <marek.safar@gmail.com>
2512 A fix for bug #417705
2513 * cs-parser.jay: Fixed as/is operator expression split.
2515 2008-09-18 Marek Safar <marek.safar@gmail.com>
2517 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2518 Fixed expression tree representation of empty new expression and
2519 new initializer expression.
2521 2008-09-18 Miguel de Icaza <miguel@novell.com>
2523 * eval.cs: Remove warning, keep reference to driver around.
2525 * Hide fields that do not need to be public.
2527 2008-09-17 Marek Safar <marek.safar@gmail.com>
2529 A fix for bug #426385
2530 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2531 conversion for array elements.
2533 2008-09-17 Marek Safar <marek.safar@gmail.com>
2535 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2536 void parsing conflicts.
2538 2008-09-15 Marek Safar <marek.safar@gmail.com>
2540 A fix for bug #425601
2541 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2542 System.Core only when there is no custom ExtensionAttribute
2545 2008-09-15 Miguel de Icaza <miguel@novell.com>
2547 * namespace.cs: Do not report CS0246 (name
2549 2008-09-12 Marek Safar <marek.safar@gmail.com>
2551 A fix for bug #425669
2552 * generic.cs: Don't cache generic static anonymous method
2555 2008-09-12 Marek Safar <marek.safar@gmail.com>
2557 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2558 conflicting constraints.
2560 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2562 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2565 2008-09-12 Marek Safar <marek.safar@gmail.com>
2567 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2568 to null pointer conversion fixes.
2570 2008-09-11 Marek Safar <marek.safar@gmail.com>
2572 * cs-parser.jay, expression.cs: An implicitly typed local variable
2573 declarator cannot use an array initializer.
2575 2008-09-11 Marek Safar <marek.safar@gmail.com>
2577 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2579 2008-09-11 Marek Safar <marek.safar@gmail.com>
2581 * generic.cs (InflatedConstraints): Don't crash when constraints
2584 * cs-parser.jay: const_declarator is a block.
2586 * constant.cs: Check for not allowed NaN conversions.
2588 2008-09-10 Miguel de Icaza <miguel@novell.com>
2590 * driver.cs: Drop --shell argument, the compiler is no longer a
2593 * eval.cs: Move most of the code that deals with evaluation into
2594 this file and document the public API from repl.cs
2596 * repl.cs: Remove from here.
2598 2008-09-10 Marek Safar <marek.safar@gmail.com>
2600 A fix for bug #424684
2601 * generic.cs: Generic class constraints must come first.
2603 2008-09-09 Miguel de Icaza <miguel@novell.com>
2605 * cs-parser.jay: Improve error reporting for syntax errors in
2606 statements and expressions, we now report the expected tokens
2607 instead of reporting the useless "; expected".
2609 Drop the strings from the token declaration, it turns out that
2610 they did not do what I thought they did. Instead they were adding
2611 two sets of tokens to the tables.
2613 2008-09-09 Marek Safar <marek.safar@gmail.com>
2615 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
2616 delegate.cs: Share special type check.
2618 2008-09-09 Marek Safar <marek.safar@gmail.com>
2620 A fix for bug #423981
2621 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
2623 2008-09-09 Marek Safar <marek.safar@gmail.com>
2625 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
2628 2008-09-09 Marek Safar <marek.safar@gmail.com>
2630 A fix for bugs: #324750, #335946
2631 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
2632 lookup rule to determine ?-based tokens.
2634 2008-09-08 Miguel de Icaza <miguel@novell.com>
2636 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
2637 expressions (like event adding or removing) end up here, so we
2638 need to treat those as statements.
2640 Add LoadAssembly method.
2642 2008-09-04 Miguel de Icaza <miguel@novell.com>
2644 * repl.cs: Add Time method.
2646 2008-09-05 Marek Safar <marek.safar@gmail.com>
2648 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
2650 2008-09-05 Miguel de Icaza <miguel@novell.com>
2652 * repl.cs: Add workaround for old compilers.
2654 2008-09-04 Jb Evain <jbevain@novell.com>
2656 * repl.cs (PrettyPrint): pretty print everything that
2657 implements IDictionary, as well as IEnumerables. Also,
2658 add a quit helper property.
2660 2008-09-04 Marek Safar <marek.safar@gmail.com>
2662 * constant.cs: Better error reporting for decimal literals.
2664 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
2667 2008-09-04 Marek Safar <marek.safar@gmail.com>
2668 Miguel de Icaza <miguel@novell.com>
2670 A fix for bug #422951
2671 * assign.cs (Assign.DoResolve): Perform the type conversions
2672 checks before we attempt to initialize `New' initializers.
2674 2008-09-04 Marek Safar <marek.safar@gmail.com>
2676 A fix for bug #422853
2677 * delegate.cs (DelegateCreation): Add special handling for
2678 EmptyExpression.Null instance expression which is just another
2679 hack for undecided member instance exression.
2681 2008-09-04 Marek Safar <marek.safar@gmail.com>
2683 * expression.cs, ecore.cs: Emit full expression tree for reduced
2686 2008-09-04 Marek Safar <marek.safar@gmail.com>
2688 * expression.cs (This): Guard against multi-resolving.
2690 * ecore.cs, statement.cs (Throw): Simplified.
2692 * flowanalysis.cs: Also verify event fields.
2694 2008-09-04 Miguel de Icaza <miguel@novell.com>
2696 * assign.cs (Assign.DoResolve): Perform the type conversions
2697 checks before we attempt to initialize `New' initializers.
2699 * repl.cs (PrettyPrint): Add Hashtable prettyprint
2701 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
2704 * repl.cs: Update help.
2706 2008-09-03 Miguel de Icaza <miguel@novell.com>
2708 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
2709 handling of the default config handling, including the special
2710 treatment of System.Core assembly.
2712 Fixes the REPL processing for LINQ.
2714 2008-09-03 Marek Safar <marek.safar@gmail.com>
2716 A fix for bug #422507
2717 * expression.cs (UnboxCast): Add missing child expression mutator.
2719 2008-09-03 Marek Safar <marek.safar@gmail.com>
2721 * driver.cs: Don't self reference System.Core assembly.
2723 2008-09-03 Marek Safar <marek.safar@gmail.com>
2725 A fix for bug #422507
2726 * expression.cs (StringConcat): Add missing type mutator.
2728 2008-09-03 Marek Safar <marek.safar@gmail.com>
2730 * generic.cs (TypeInferenceContext): Follow equality rule for
2731 constructed type lower bound type inference.
2733 2008-09-02 Miguel de Icaza <miguel@novell.com>
2735 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
2736 <dblank@cs.brynmawr.edu> which updates the cursor position on
2739 2008-09-02 Marek Safar <marek.safar@gmail.com>
2741 A fix for bug #367145
2742 * driver.cs: Fixed import of extension methods when using -noconfig
2745 2008-09-02 Marek Safar <marek.safar@gmail.com>
2747 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
2748 version from non-generic implementation instead.
2750 2008-09-01 Marek Safar <marek.safar@gmail.com>
2752 A fix for bug #418908
2753 * class.cs: Use AddScopeStatement for field initializers.
2755 2008-09-01 Marek Safar <marek.safar@gmail.com>
2757 A fix for bug #415385
2758 * ecore.cs, convert.cs: Do method group conversion for equal group types.
2760 2008-09-01 Marek Safar <marek.safar@gmail.com>
2762 A fix for bug #421736
2763 * iterators.cs: Don't crash on unreachable iterators.
2765 2008-09-01 Marek Safar <marek.safar@gmail.com>
2767 A fix for bug #421628
2768 * parameter.cs, attribute.cs: Clone also parameter attributes.
2770 2008-08-30 Miguel de Icaza <miguel@novell.com>
2772 * namespace.cs (LookupType): In EvalMode, try to replace
2773 the TypeBuilder from our cache with a Type as Reflection.Emit does
2774 not like to mix code from older assemblies emitted and new
2777 This sounds like a serious Mono bug that prevents multiple
2778 assemblies to be generated and consumed at the same time.
2780 * cs-parser.jay (push_current_class): Do not make interactive
2781 classes internal or private, make them public as we currently
2782 generate each new class in a new assembly.
2784 2008-08-29 Miguel de Icaza <miguel@novell.com>
2786 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
2787 remove types that are entered into the global namespace during
2788 parsing so that we can remove them on failure.
2790 * cs-parser.jay: Parsing: we now keep track of types that are
2791 entered into global variables and queue those in case the parsing
2794 This happens in a few situations: during partial-input, we invoke
2795 the parser repeatedly for example with the string "class X", this
2796 would cause X to be registed, and we need to remove this
2797 registration so that another parse attempt later with say "class X {"
2798 would actually work.
2800 Additionally, if there is an error in the resolution phase, for
2801 example: "class X : NonExistant {}" th
2803 * cs-parser.jay: Be more precise with the errors being raised,
2804 instead of flagging all exceptions during parsing to be attributed
2805 to the parsing process, distinguish those from errors happening in
2806 the actions and hint that using -v would produce the actual
2809 * repl.cs: Do not load all compiler references on each reset,
2810 doing the partial reset takes care of this.
2812 2008-08-28 Miguel de Icaza <miguel@novell.com>
2814 * repl.cs: Add support for loading all the files from
2815 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
2818 Introduce a micro-parser that is able to deambiguate on its input
2819 whether we are dealing with a compilation unit (namespace, class,
2820 interface, struct, delegate) declaration or a statement. This
2821 allows both declarations and statements to be entered.
2823 Set history size by default to 300 lines.
2825 Instead of distinguishing based on the parser.InteractiveResult,
2826 have only two cases: statements were parsed, or a compilation unit
2827 was. Always pull the Using statement additions from the
2828 compilation unit parse.
2830 * cs-tokenizer.cs: Rename tokens to better describe their intent
2831 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
2833 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
2834 EvalMode is used to trigger the lookup of global variables while
2835 StatementMode is used turn variable declarations into static
2838 * getline.cs: Allow history size to be set.
2840 2008-08-29 Marek Safar <marek.safar@gmail.com>
2842 A fix for bug #360755
2843 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
2845 2008-08-29 Marek Safar <marek.safar@gmail.com>
2847 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
2849 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
2850 member name, it is too confusing
2852 * decl.cs, class.cs: Don't report unused fields with attached attribute.
2854 * rootcontext.cs: Finally default to warning level 4.
2856 2008-08-28 Marek Safar <marek.safar@gmail.com>
2858 * class.cs (CheckBase): Ignore overloaded operators.
2860 2008-08-28 Marek Safar <marek.safar@gmail.com>
2862 A fix for bug #420830
2863 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
2865 2008-08-28 Marek Safar <marek.safar@gmail.com>
2867 A fix for bug #420832
2868 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
2870 2008-08-28 Marek Safar <marek.safar@gmail.com>
2872 A fix for bug #420386
2873 * nullables.cs: Fixed logic of nullable user comparison operators involving
2876 2008-08-28 Marek Safar <marek.safar@gmail.com>
2878 * attribute (IsClsCompliant): Use FALSE value for pointer types.
2880 2008-08-27 Miguel de Icaza <miguel@novell.com>
2882 * repl.cs: Add support for aborting the running code with C-c.
2884 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
2886 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
2888 2008-08-27 Miguel de Icaza <miguel@novell.com>
2890 * cs-parser.jay (interactive_statement_list): A new set of rules
2891 for hosting statements that uses the "interactive_" prefix.
2893 * repl.cs: Add support for parsing `using' as a statement or as a
2894 directive. Deambiguating before passing this to the parser.
2896 We need to distinguish statement_expressions that occur at the
2897 toplevel vs those that occur embedded into expressions.
2899 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
2900 that fixes the cursor key handling, and a history bug.
2902 2008-08-26 Miguel de Icaza <miguel@novell.com>
2904 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
2905 limitations in Console, instead the 2.0 bootstrap libraries now
2906 include the Console bits.
2908 Also, remove the use of Nullables from getline.cs
2912 Interactive support for the C# compiler. Use gmcs --shell to
2913 enter a read-eval-print loop shell.
2915 Docs: http://www.mono-project.com/CsharpRepl
2917 * sources: include repl.cs here and getline.cs for gmcs.exe,
2918 everything else is getline.cs impaired.
2920 * Makefile: when bootstrapping pass a special flag
2921 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
2922 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
2923 This distinguishes those two cases.
2925 * repl.cs: Support for a read-eval-print loop. Will be soon
2926 refactored into eval support and then REPL on top of it.
2928 * ecore.cs: If a simplename lookup fails, before erroring out,
2929 if we are in EvalMode to resolve the name to a declaration in the
2932 This means that variable declarations that happened in previous
2933 classes (as repl puts every statement in a separate class) are
2934 made visible in this way.
2936 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
2937 triggered an error due to the end of file being reached. This is
2938 used to do multi-line input, and notify the caller that the user
2939 needs to provide more text before a successful parse.
2941 Add new grammar rules after the INTERACTIVE_PARSER token is seen
2942 to drive the evaluation with a custom wrapper.
2944 * driver.cs: Add support for --shell, and refactor some code to be
2947 * namespace.cs: Add support for serializing the contents of the
2948 namespaces and reloading them.
2950 * getline.cs: A managed implementation of ReadLine under
2951 X11/Apache2 license terms. Easy to embed in other applications as
2954 * namespace.cs: Add some functions to save and restore the
2957 * rootcontext.cs: New public field.
2959 * cs-tokenizer.cs: Add support for one of the possible characters
2960 we introduce into the token stream.
2962 This patch does not affect the regular tokenization process, the
2963 only performance hit would happen if there is an invalid character
2964 on the input string.
2966 * support.cs: Move isatty helper routine here.
2968 * codegen.cs: Small cleanup, and add a mechanism to initialize the
2969 code generator for in-memory assemblies.
2971 2008-08-26 Marek Safar <marek.safar@gmail.com>
2973 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
2974 parameter cannot be always used as a type.
2976 2008-08-21 Marek Safar <marek.safar@gmail.com>
2978 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
2980 2008-08-21 Marek Safar <marek.safar@gmail.com>
2982 * convert.cs: Implement explicit array to IList<T> conversion.
2984 2008-08-20 Marek Safar <marek.safar@gmail.com>
2986 A fix for bug #362740
2987 * cs-tokenizer.cs: Handle UTF-16 surrogates.
2989 2008-08-20 Marek Safar <marek.safar@gmail.com>
2991 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
2992 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
2993 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
2994 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
2995 handling to use just one type of infrastructure and deal with generics
2998 2008-07-23 Martin Baulig <martin@ximian.com>
3000 *** Merged this from trunk revision 108527 ***
3003 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3004 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3007 2008-08-15 Marek Safar <marek.safar@gmail.com>
3009 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3012 2008-08-15 Marek Safar <marek.safar@gmail.com>
3014 * delegate.cs: Fixed compiler crash when creating delegate using partial
3017 * typemanager.cs: MulticastDelegate is not a delegate.
3019 2008-08-14 Marek Safar <marek.safar@gmail.com>
3021 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3024 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3026 * cs-parser.jay (type): Allow 'var' in mcs too.
3027 (local_variable_type): Likewise.
3029 2008-08-14 Marek Safar <marek.safar@gmail.com>
3031 * driver.cs: Removed broken -noconfig variants.
3033 2008-08-14 Marek Safar <marek.safar@gmail.com>
3035 A fix for bug #417078
3036 * expression.cs: Emit correctly left side pointer operators.
3038 2008-08-13 Marek Safar <marek.safar@gmail.com>
3040 * generic.cs, lambda.cs: Inflate method generic arguments only.
3042 2008-08-12 Marek Safar <marek.safar@gmail.com>
3044 * class.cs: Fixed struct layout check regression.
3046 2008-08-12 Marek Safar <marek.safar@gmail.com>
3048 * cs-parser.jay, enum.cs: Simplified enum parsing.
3050 * decl.cs: Check all type parameters conflicts.
3052 * expression.cs, statement.cs, attribute.cs: More expression checks.
3054 2008-08-11 Marek Safar <marek.safar@gmail.com>
3056 * generic.cs: Add type inference types restriction.
3058 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3059 anonymous.cs, expression.cs: Allocate less accessor parameters.
3061 2008-08-08 Marek Safar <marek.safar@gmail.com>
3063 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3066 2008-08-08 Marek Safar <marek.safar@gmail.com>
3068 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3070 2008-08-07 Marek Safar <marek.safar@gmail.com>
3072 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3073 Also fixes #362146 and #381592.
3075 2008-08-07 Marek Safar <marek.safar@gmail.com>
3077 * ecore.cs: Reduced constant cannot be used as an attribute value.
3079 * cs-parser.jay: Base expression has to be a type.
3081 * expression.cs (Conditional): Uses ReducedExpression.
3083 2008-08-06 Marek Safar <marek.safar@gmail.com>
3085 A fix for bug #376826
3086 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3087 address of hoisted local variable or parameter cannot be taken.
3089 2008-08-05 Marek Safar <marek.safar@gmail.com>
3091 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3092 anonymous method inside checked/unchecked expression.
3094 2008-08-05 Marek Safar <marek.safar@gmail.com>
3096 * typemanager.cs (IsEqual): Guard against null.
3098 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3099 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3100 routine. Fixed few misleading conversion errors.
3102 2008-08-04 Marek Safar <marek.safar@gmail.com>
3104 * class.cs: Consider generics when checking cycles in struct layout.
3106 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3108 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3110 2008-08-04 Marek Safar <marek.safar@gmail.com>
3112 A fix for bug #414165
3113 * anonymous.cs: Use same anonymous implementation method for all anonymous
3116 2008-08-04 Marek Safar <marek.safar@gmail.com>
3118 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3121 2008-08-04 Marek Safar <marek.safar@gmail.com>
3123 * cs-parser.jay: Typeof argument has to be a type expression.
3125 * namespace.cs: Check alias and namespace definitions collisions.
3127 * class.cs, pending.cs: Moved explicit interface accessor implementation
3130 * delegate.cs, expression.cs: Verify special name invocations.
3132 2008-08-01 Marek Safar <marek.safar@gmail.com>
3134 * cs-parser.jay: Don't choke on empty generic type arguments.
3136 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3138 * expression.cs, ecore.cs: Minor expressions bugs.
3140 2008-08-01 Marek Safar <marek.safar@gmail.com>
3142 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3143 and added more error handling.
3145 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3147 * modifiers.cs, enum.cs: Fixed.
3149 2008-07-31 Jb Evain <jbevain@novell.com>
3151 * driver.cs: remove -pkg ability of smcs.
3153 2008-07-30 Marek Safar <marek.safar@gmail.com>
3155 * statement.cs (Switch): Correctly set empty default target for single
3158 2008-07-30 Marek Safar <marek.safar@gmail.com>
3160 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3161 string switch statement implementation to use string dictionary which
3162 significantly (2-8x) improves performance of generated code.
3164 2008-07-29 Marek Safar <marek.safar@gmail.com>
3166 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3167 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3169 2008-07-29 Marek Safar <marek.safar@gmail.com>
3171 A fix for bug #412595
3172 * typemanager.cs, convert.cs, expression.cs: Some types are never
3173 convertible to each other.
3175 2008-07-29 Marek Safar <marek.safar@gmail.com>
3177 * nullable.cs (CreateNullConstant): An error messages update.
3179 2008-07-29 Marek Safar <marek.safar@gmail.com>
3181 A fix for bug #412595
3182 * cfold.cs: Don't cast undefined bool constant.
3184 2008-07-29 Martin Baulig <martin@ximian.com>
3187 (SymbolWriter.Reset): New public static method.
3190 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3192 2008-07-28 Marek Safar <marek.safar@gmail.com>
3194 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3196 * expression.cs (ElementAccess): Exact size allocation.
3198 2008-07-26 Marek Safar <marek.safar@gmail.com>
3200 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3202 2008-07-25 Marek Safar <marek.safar@gmail.com>
3204 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3206 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3209 2008-07-25 Marek Safar <marek.safar@gmail.com>
3211 A fix for bug #412217
3212 * assign.cs: Mutate also assignment type.
3214 2008-07-25 Marek Safar <marek.safar@gmail.com>
3216 A fix for bug #323644
3217 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3220 2008-07-25 Marek Safar <marek.safar@gmail.com>
3222 A fix for bug #412134
3223 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3224 non-enumerable operands when overloading equality or bitwise operators.
3226 2008-07-25 Marek Safar <marek.safar@gmail.com>
3228 * anonymous.cs: Cache closed generic anonymous method delegates.
3230 2008-07-24 Marek Safar <marek.safar@gmail.com>
3232 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3233 anonymous.cs, statement.cs: Always emit anonymous method as static method
3234 when is instance free. Use nesting for nested anynomous methods blocks.
3236 2008-07-23 Marek Safar <marek.safar@gmail.com>
3238 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3241 2008-07-23 Marek Safar <marek.safar@gmail.com>
3243 * expression.cs: Removed MakeSimpleCall.
3245 2008-07-23 Marek Safar <marek.safar@gmail.com>
3247 A fix for bug #323012
3248 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3249 Base method implementing interface has to be public.
3251 2008-07-23 Marek Safar <marek.safar@gmail.com>
3253 * cs-parser.jay: Don't break on missing argument.
3255 2008-07-22 Marek Safar <marek.safar@gmail.com>
3257 A fix for bug #320993
3258 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3259 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3261 2008-07-22 Marek Safar <marek.safar@gmail.com>
3263 A fix for bug #320748
3264 * convert.cs: Implicit user operators cannot convert to interfaces
3266 2008-07-22 Marek Safar <marek.safar@gmail.com>
3268 A fix for bug #312686
3269 * driver.cs: Ignore empty assembly references.
3271 2008-07-22 Marek Safar <marek.safar@gmail.com>
3273 A fix for bug #387040
3274 * ecore.cs: Skip constrains check for an explicit implementation.
3276 2008-07-21 Marek Safar <marek.safar@gmail.com>
3278 A fix for bug #409045
3279 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3280 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3281 identifiers are file specific unless passed as input arguments.
3283 2008-07-21 Marek Safar <marek.safar@gmail.com>
3285 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3286 to emit UnmanagedMarshal data under 2.0 profile.
3288 2008-07-21 Marek Safar <marek.safar@gmail.com>
3290 A fix for bug #410369
3291 * parameter.cs: Clone correctly ParamsParameter.
3293 2008-07-21 Marek Safar <marek.safar@gmail.com>
3295 * expression.cs (Argument): Always report type for type based expressions
3298 2008-07-18 Marek Safar <marek.safar@gmail.com>
3300 A fix for bug #410666
3301 * anonymous.cs: Correctly initialize generic storey reference.
3303 2008-07-18 Marek Safar <marek.safar@gmail.com>
3305 * convert.cs: Don't box same type arguments.
3307 2008-07-18 Marek Safar <marek.safar@gmail.com>
3309 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3310 Finished missing generic type mutators.
3312 2008-07-18 Marek Safar <marek.safar@gmail.com>
3314 * iterators.cs, statement.cs: Finished statements CloneTo.
3316 2008-07-18 Marek Safar <marek.safar@gmail.com>
3318 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3320 * expression.cs: Emit optimized default value expressions in expression tree
3323 2008-07-18 Marek Safar <marek.safar@gmail.com>
3325 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3327 2008-07-17 Marek Safar <marek.safar@gmail.com>
3329 A fix for bug #367536
3330 * cs-parser.jay: Check static constructor of generic types for an access
3333 2008-07-17 Marek Safar <marek.safar@gmail.com>
3335 A fix for bug #353800
3336 * lambda.cs: Emit ret for contextual statements.
3338 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3339 up emitting redundant ret for all anonymous methods with return.
3341 2008-07-17 Marek Safar <marek.safar@gmail.com>
3343 A fix for bug #365188
3344 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3345 create anonymous method storey in unreachable block.
3347 2008-07-17 Marek Safar <marek.safar@gmail.com>
3349 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3350 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3351 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3352 statement.cs: Fixed relevant defects found by Gendarme.
3354 2008-07-17 Marek Safar <marek.safar@gmail.com>
3356 A fix for bug #325291
3357 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3358 statement.cs: Replaced IAnonymousHost with top level block flag.
3360 2008-07-17 Marek Safar <marek.safar@gmail.com>
3362 * cs-parser.jay: Clean up unused open_parens.
3364 2008-07-17 Marek Safar <marek.safar@gmail.com>
3366 * ecore.cs: Custom error message for a range variable assignment.
3368 2008-07-16 Marek Safar <marek.safar@gmail.com>
3370 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3373 2008-07-16 Marek Safar <marek.safar@gmail.com>
3375 * literal.cs: Null literal is of object type.
3377 2008-07-16 Marek Safar <marek.safar@gmail.com>
3379 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3380 expression of nullable equality comparison.
3382 2008-07-15 Marek Safar <marek.safar@gmail.com>
3384 * expression.cs(PointerArithmetic): Removed redundant assignment.
3386 2008-07-15 Marek Safar <marek.safar@gmail.com>
3388 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3390 2008-07-14 Marek Safar <marek.safar@gmail.com>
3392 A fix for bug #408361
3393 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3394 they are replaced by GetMethod.
3396 2008-07-14 Marek Safar <marek.safar@gmail.com>
3398 A fix for bug #408721 by jeremie.laval@gmail.com
3399 * expression.cs (Indirection): Implemented CloneTo.
3401 2008-07-14 Marek Safar <marek.safar@gmail.com>
3403 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3406 2008-07-14 Marek Safar <marek.safar@gmail.com>
3408 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3410 2008-07-11 Marek Safar <marek.safar@gmail.com>
3412 * linq.cs: Reset tranparent parameter counter in probing mode.
3414 2008-07-11 Marek Safar <marek.safar@gmail.com>
3416 * anonymous.cs: Mutate anonymous method type.
3418 2008-07-11 Marek Safar <marek.safar@gmail.com>
3420 * ecore.cs, anonymous.cs: Mutate field expressions.
3422 2008-07-10 Marek Safar <marek.safar@gmail.com>
3424 A fix for bug #369670
3425 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3427 2008-07-10 Marek Safar <marek.safar@gmail.com>
3429 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3431 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3434 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3435 only one '>', and finds a '>>', abort the generic lookahead.
3437 2008-07-10 Marek Safar <marek.safar@gmail.com>
3439 A fix for bug #319902
3440 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3442 2008-07-10 Marek Safar <marek.safar@gmail.com>
3444 A fix for bug #406371
3445 * statement.cs: Moved EmitSymbolInfo to Block.
3447 2008-07-09 Marek Safar <marek.safar@gmail.com>
3449 * ecore.cs: Report better error for extension method overload failures.
3451 2008-07-09 Marek Safar <marek.safar@gmail.com>
3453 * expression.cs (Is): No need to box reference values.
3455 2008-07-09 Marek Safar <marek.safar@gmail.com>
3457 * class.cs: Use event resolve context when initializing CreateEmitContext.
3459 2008-07-09 Marek Safar <marek.safar@gmail.com>
3461 A fix for bug #394436
3462 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3463 method used inside expression trees. Added more LINQ to expression tree
3466 2008-07-08 Marek Safar <marek.safar@gmail.com>
3468 A fix for bug #378189, #370577
3469 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3472 2008-07-08 Marek Safar <marek.safar@gmail.com>
3474 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3477 2008-07-08 Marek Safar <marek.safar@gmail.com>
3479 A fix for bug #406702
3480 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3482 2008-07-07 Marek Safar <marek.safar@gmail.com>
3484 A fix for bug #406648
3485 * cs-parser.jay: Report nullable use in mcs for some cases.
3487 2008-07-07 Marek Safar <marek.safar@gmail.com>
3489 * ecore.cs: Improved argument mismatch error messages.
3491 2008-07-07 Marek Safar <marek.safar@gmail.com>
3493 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3495 2008-07-07 Marek Safar <marek.safar@gmail.com>
3497 * expression.cs (TypeOf): Mutate type argument.
3499 2008-07-04 Marek Safar <marek.safar@gmail.com>
3501 * class.cs: Report missing partial modifier for correct type.
3503 2008-07-04 Marek Safar <marek.safar@gmail.com>
3505 * ecore.cs, expression.cs (VariableReference): Variable property is
3508 2008-07-04 Marek Safar <marek.safar@gmail.com>
3510 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3512 2008-07-04 Marek Safar <marek.safar@gmail.com>
3514 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3517 2008-07-04 Marek Safar <marek.safar@gmail.com>
3519 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3520 anonymous method storey to an instance method when only "this" is hoisted.
3522 2008-07-03 Marek Safar <marek.safar@gmail.com>
3524 A fix for bug #321615
3525 * expression.cs: Pointer comparisons use unsigned operator.
3527 2008-07-03 Marek Safar <marek.safar@gmail.com>
3529 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3531 2008-07-02 Marek Safar <marek.safar@gmail.com>
3533 A fix for bug #404905
3534 * class.cs: Always initialize local unsafe variables.
3536 2008-06-30 Marek Safar <marek.safar@gmail.com>
3538 A fix for bug #396987
3539 * expression.cs (NewInitialize): Clear local temporary variable for next run
3541 2008-06-27 Marek Safar <marek.safar@gmail.com>
3543 A fix for bug #401020
3544 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3546 2008-06-27 Marek Safar <marek.safar@gmail.com>
3548 A fix for bug #398319
3549 * cs-parser.jay: Implemented undocumented base access expression inside
3552 2008-06-26 Marek Safar <marek.safar@gmail.com>
3554 A fix for bug #404227
3555 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3557 2008-06-26 Marek Safar <marek.safar@gmail.com>
3559 A fix for bug #404227
3560 * convert.cs: Fixed explicit array to interface cast.
3562 2008-06-26 Marek Safar <marek.safar@gmail.com>
3564 A fix for bug #403894
3565 * delegate.cs: Mutate DelegateInvocation type.
3567 2008-06-26 Marek Safar <marek.safar@gmail.com>
3569 A fix for bug #379348
3570 * delegate.cs: Box a load of generic parameters.
3572 2008-06-26 Marek Safar <marek.safar@gmail.com>
3574 * expression.cs: Add an array creation arguments mutate.
3576 2008-06-26 Marek Safar <marek.safar@gmail.com>
3578 A fix for bug #386068
3579 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3582 2008-06-25 Marek Safar <marek.safar@gmail.com>
3584 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
3587 2008-06-25 Marek Safar <marek.safar@gmail.com>
3589 A fix for bug #403518
3590 * delegate.cs: Type correctly anonymous method new invocation.
3592 2008-06-24 Marek Safar <marek.safar@gmail.com>
3594 A fix for bug #394826
3595 * anonymous.cs: Fully qualify members when resolving anonymous type internal
3598 2008-06-24 Marek Safar <marek.safar@gmail.com>
3600 A fix for bug #394826
3601 * anonymous.cs, iterators.cs: Construct generic storey only when is really
3604 2008-06-24 Marek Safar <marek.safar@gmail.com>
3606 * class.cs: Clone indexer parameters for localized capturing.
3608 2008-06-24 Marek Safar <marek.safar@gmail.com>
3610 A fix for bug #402379
3611 * expression.cs: Don't crash when an object initializer resolve fails.
3613 2008-06-24 Marek Safar <marek.safar@gmail.com>
3615 A fix for bug #402888
3616 * expression.cs: Mutate conditional expression.
3618 2008-06-24 Marek Safar <marek.safar@gmail.com>
3620 A fix for bug #401012
3621 * class.cs: Keep StructLayout in shared container.
3623 2008-06-24 Marek Safar <marek.safar@gmail.com>
3625 A fix for bug #400438
3626 * decl.cs, class.cs: Only properties can be automatically implemented.
3628 2008-06-24 Marek Safar <marek.safar@gmail.com>
3630 * statement.cs (ChangeToIterator): Copy also labels.
3632 2008-06-23 Marek Safar <marek.safar@gmail.com>
3634 * ecore.cs: Pass type argument details to parent extension method.
3636 2008-06-23 Marek Safar <marek.safar@gmail.com>
3638 A fix for bug #375966
3639 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
3641 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
3643 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
3645 2008-06-22 Marek Safar <marek.safar@gmail.com>
3647 A fix for bug #394347
3648 * anonymous.cs: Cache compatible delegates as compatibility check produces
3649 a new method every time.
3651 2008-06-20 Marek Safar <marek.safar@gmail.com>
3653 * anonymous.cs: Propagate storey reference for single references.
3655 2008-06-20 Marek Safar <marek.safar@gmail.com>
3657 A fix for bug #387615
3658 * assign.cs, expression.cs: Correctly clone compound assignment.
3660 2008-06-19 Marek Safar <marek.safar@gmail.com>
3662 A fix for bug #359611, #359604
3663 * anonymous.cs: Mutate all types of hoisted parameters.
3665 2008-06-19 Marek Safar <marek.safar@gmail.com>
3667 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
3668 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
3669 expression.cs, codegen.cs, statement.cs
3671 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
3672 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
3674 ** Anonymous methods, lambda expressions rewrite **
3676 Anonymous expressions are now resolved when an explicit block is resolved
3677 and they don't require any registration procedure anymore. Further,
3678 anonymous methods are defined when explicit block is emitted which allows
3679 better control of whole process and opens possibilities for more
3680 optimizations as well as alternative to reverse whole process.
3682 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
3683 process consistent and to correctly emit hoisted generic methods when they
3684 have at least 1 hoisted variable.
3686 2008-06-17 Martin Baulig <martin@ximian.com>
3688 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
3690 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
3691 virtual property; check it in Emit().
3692 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
3694 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
3696 (Indexer.Define): Likewise.
3698 2008-06-17 Marek Safar <marek.safar@gmail.com>
3700 * convert.cs: Don't use IsInterface on type arguments.
3702 * delegate.cs: DelegateInvocation uses MethodInfo.
3704 * parameter.cs: Removed IsTypeParameter.
3706 * generic-mcs.cs: More missing stuff.
3708 2008-06-16 Martin Baulig <martin@ximian.com>
3711 (Modifiers.DEBUGGER_HIDDEN): New public const.
3714 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
3717 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
3718 (AbstractPropertyEventMethod): Likewise.
3719 (Constructor.Emit): Likewise.
3720 (SourceMethod.SetCompilerGenerated): Removed.
3722 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
3726 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
3727 if we're an `IteratorHost'.
3728 (AnonymousMethodMethod..ctor): Don't set
3729 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
3732 2008-06-16 Marek Safar <marek.safar@gmail.com>
3734 * statement.cs: Clean-up foreach statements.
3736 2008-06-12 Marek Safar <marek.safar@gmail.com>
3738 * class.cs: Stop using public method which should not exist
3739 (MethodBuilder.SetGenericMethodSignature).
3741 2008-06-11 Martin Baulig <martin@ximian.com>
3744 (Location.LookupFile): Add `CompilationUnit' argument; when given
3745 a relative file name, make it relative to the directory the .cs
3746 file is located in instead of using the current directory.
3748 2008-06-11 Martin Baulig <martin@ximian.com>
3751 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
3752 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
3753 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
3754 (SourceMethod.SetCompilerGenerated): Likewise.
3756 2008-06-11 Marek Safar <marek.safar@gmail.com>
3758 * codegen.cs, driver: Only write symbol file when it's asked for.
3760 2008-06-11 Marek Safar <marek.safar@gmail.com>
3762 * codegen.cs: Don't use assembly writer error handling for symbol writer.
3764 2008-06-10 Martin Baulig <martin@ximian.com>
3766 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
3768 2008-06-09 Marek Safar <marek.safar@gmail.com>
3770 A fix for bug #316290
3771 * expression.cs: Include decimal operators in predefined table.
3773 * parameters.cs: More readonlyness.
3775 2008-06-09 Marek Safar <marek.safar@gmail.com>
3777 A fix for bug #397213
3778 * cs-parser.jay: One more missing current_local_parameters reset.
3780 2008-06-09 Marek Safar <marek.safar@gmail.com>
3782 A fix for bug #396633
3783 * class.cs: Host backing field in partial container.
3785 2008-06-09 Marek Safar <marek.safar@gmail.com>
3787 A fix for bug #397068
3788 * expression.cs: Check both operand types when predefined operator is used.
3790 2008-06-05 Martin Baulig <martin@ximian.com>
3792 Merged the `debugger-kahalo' branch.
3795 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
3796 we're an iterator method.
3797 (SourceMethod): Reflect latest symbol writer changes;
3798 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
3799 now `start_row' and `end_row'.
3800 (Constructor.Emit): Fix the logic whether to emit symbol information.
3802 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
3806 (CompilationUnit): New public class; derives from `SourceFile'.
3807 (SourceFileEntry.DefineSymbolInfo): New public method.
3808 (SourceFileEntry.SetChecksum): New public method.
3809 (Location): Encode hidden line numbers by using `column == 255';
3810 the .ctor now accepts `column == -1' to mark a hidden line number.
3811 (Location.Hidden): New public property.
3812 (Location.CheckPoint): Add `CompilationUnit'.
3813 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
3814 (Location.Push): Add `CompilationUnit compile_unit' argument.
3815 (Location.CompilationUnit): New public property.
3818 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
3820 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
3822 * driver.cs: `SourceFile' -> `CompilationUnit'.
3824 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
3826 * namespace.cs: `SourceFile' -> `CompilationUnit'.
3828 * cs-tokenizer.cs: Add support for `#pragma checksum' and
3832 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
3833 new symbol writer API to also pass the file.
3835 2008-06-05 Marek Safar <marek.safar@gmail.com>
3837 * statement.cs: Emit catch variable assignment using variable expression.
3839 2008-06-05 Marek Safar <marek.safar@gmail.com>
3841 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
3842 with other variable types.
3844 2008-06-04 Marek Safar <marek.safar@gmail.com>
3846 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
3847 GetLength method emit, it breaks resolve rules.
3849 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
3850 Marek Safar <marek.safar@gmail.com>
3852 A fix for bug #395542
3853 * cs-parser.jay: The trailing comma is allowed in anonymous type member
3856 2008-06-02 Marek Safar <marek.safar@gmail.com>
3858 A fix for bug #395287
3859 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
3861 2008-05-31 Marek Safar <marek.safar@gmail.com>
3863 A fix for bug #395845
3864 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
3865 non-nullable parameter type.
3867 2008-05-31 Marek Safar <marek.safar@gmail.com>
3869 * class.cs: Handle contructor initializer as a statement in top-level block.
3871 2008-05-30 Marek Safar <marek.safar@gmail.com>
3873 * attribute.cs: Don't mix old and new corlib types when emitting corlib
3874 security attributes.
3876 2008-05-24 Marek Safar <marek.safar@gmail.com>
3878 * ecore.cs, expression.cs: Small IVariable refactoring.
3880 2008-05-22 Marek Safar <marek.safar@gmail.com>
3882 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
3884 2008-05-21 Marek Safar <marek.safar@gmail.com>
3886 * cs-parser.jay: Removed redundant catch type check.
3888 2008-05-21 Marek Safar <marek.safar@gmail.com>
3890 A fix for bug #390372
3891 * nullable.cs: Set correct return type.
3893 2008-05-21 Marek Safar <marek.safar@gmail.com>
3895 A fix for bug #391062
3896 * typemanager.cs: Fixed crash when comparing null types.
3898 2008-05-21 Marek Safar <marek.safar@gmail.com>
3900 A fix for bug #391871
3901 * cs-parser.jay: Better error handling for invalid catch type.
3903 2008-05-20 Marek Safar <marek.safar@gmail.com>
3905 A fix for bug #392155
3906 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
3908 2008-05-15 Marek Safar <marek.safar@gmail.com>
3910 A fix for bug #390666
3911 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
3914 2008-05-15 Marek Safar <marek.safar@gmail.com>
3916 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
3919 2008-05-13 Marek Safar <marek.safar@gmail.com>
3921 A fix for bug #389625
3922 * delegate.cs, generic.cs: Some progress on method group return type
3925 2008-05-13 Marek Safar <marek.safar@gmail.com>
3927 A fix for bug #378419
3928 * namespace.cs: Inspect also parent namespaces not only namespace entries.
3930 2008-05-12 Marek Safar <marek.safar@gmail.com>
3932 * class.cs (Constructor): Added IsCompilerGenerated.
3934 2008-05-12 Marek Safar <marek.safar@gmail.com>
3936 * expression.cs: Enum binary operators can accept non-enum operand only when
3937 is implicitly convertible to underlying type.
3939 2008-05-12 Marek Safar <marek.safar@gmail.com>
3941 A fix for bug #389272
3942 * support.cs: Workaround System.InvalidOperationException for enums.
3944 2008-05-12 Marek Safar <marek.safar@gmail.com>
3946 A fix for bug #389073
3947 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
3949 2008-05-10 Marek Safar <marek.safar@gmail.com>
3951 * driver.cs: Split Parse.
3953 * location.cs (LookupFile): Uses string.Empty.
3955 2008-05-07 Marek Safar <marek.safar@gmail.com>
3957 * expression.cs, parameter.cs: Small ParameterReference clean up.
3959 2008-05-07 Marek Safar <marek.safar@gmail.com>
3961 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
3962 hack. Fixes #387502.
3964 2008-05-06 Martin Baulig <martin@ximian.com>
3966 * class.cs (Constructor.Emit): Fix the logic whether to emit
3969 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
3972 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
3973 InvalidOperationException when the iterator is before the start or
3976 2008-05-06 Marek Safar <marek.safar@gmail.com>
3978 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
3979 when left is nullable type.
3981 2008-05-06 Marek Safar <marek.safar@gmail.com>
3983 A fix for bug #386628
3984 * expression.cs (LocalVariableReference): Continue in resolving when
3985 variable is not assigned.
3987 2008-05-05 Marek Safar <marek.safar@gmail.com>
3989 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
3990 nullable operations.
3992 2008-05-04 Marek Safar <marek.safar@gmail.com>
3994 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
3995 it saves many redundant temporary variables for nullable operations.
3997 2008-05-03 Marek Safar <marek.safar@gmail.com>
3999 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4001 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4004 * nullable.cs: Constant coalescing operator optimizations.
4006 2008-05-03 Marek Safar <marek.safar@gmail.com>
4008 * constant.cs: Use unsigned conversion for values which are unsigned only.
4010 2008-05-03 Marek Safar <marek.safar@gmail.com>
4012 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4013 coalescing operator as it should be.
4015 2008-05-02 Marek Safar <marek.safar@gmail.com>
4017 A fix for bug #371016
4018 * expression.cs: All predefined delegate operators require implicit method
4021 2008-05-02 Marek Safar <marek.safar@gmail.com>
4023 * constant.cs: Emit long constant as uint when fits the range.
4025 * convert.cs, expression.cs: Fixed few unsafe conversions.
4027 2008-05-02 Marek Safar <marek.safar@gmail.com>
4029 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4031 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4034 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4036 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4038 2008-05-01 Marek Safar <marek.safar@gmail.com>
4040 * constant.cs, literal.cs: IsLiteral property for error reporting.
4042 * ecore.cs, expression.cs: Implemented Property expression.
4044 2008-05-01 Marek Safar <marek.safar@gmail.com>
4046 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4048 * nullable.cs: Implemented nullable coalescing null operator.
4050 * ecore.cs, expression.cs: Expression trees work.
4052 2008-05-01 Marek Safar <marek.safar@gmail.com>
4054 * ecore.cs: CreateExpressionTree is finally abstract.
4056 * expression.cs, linq.cs: Updated.
4058 2008-05-01 Marek Safar <marek.safar@gmail.com>
4060 * expression.cs, ecore.cs: Block base access expression inside expression
4063 2008-05-01 Marek Safar <marek.safar@gmail.com>
4065 A fix for bug #385058
4066 * expression.cs: User-defined operator implementations always take
4067 precedence over predefined operator implementations.
4069 2008-04-30 Marek Safar <marek.safar@gmail.com>
4071 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4072 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4073 expression tree conversions.
4075 2008-04-30 Marek Safar <marek.safar@gmail.com>
4077 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4078 operators method details to Operator class.
4080 2008-04-30 Marek Safar <marek.safar@gmail.com>
4082 * anonymous.cs: Pass unsafe flags to anonymous container.
4084 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4085 inside expression tree.
4087 2008-04-29 Martin Baulig <martin@ximian.com>
4089 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4090 (Tokenizer.PopPosition): Also restore the `line'.
4092 2008-04-29 Marek Safar <marek.safar@gmail.com>
4094 * delegate.cs: Implemented Invoke expression.
4096 2008-04-29 Marek Safar <marek.safar@gmail.com>
4098 * expression.cs: Fixed equality reference comparison regression.
4100 2008-04-29 Marek Safar <marek.safar@gmail.com>
4102 * ecore.cs: Clean up EmptyCast hack.
4104 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4105 using correct conversion rules. Also fixes #383993.
4107 2008-04-28 Martin Baulig <martin@ximian.com>
4109 * class.cs (Constructor.Emit): Don't emit debugging information
4110 for generated default .ctor's.
4112 2008-04-28 Marek Safar <marek.safar@gmail.com>
4114 * convert.cs: Empty-cast ushort to int conversion.
4116 2008-04-28 Marek Safar <marek.safar@gmail.com>
4118 A fix for bug #384191
4119 * ecore.cs, expression.cs: Fixed expression cloning.
4121 2008-04-28 Marek Safar <marek.safar@gmail.com>
4123 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4125 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4127 Fix #381559, test-638.cs, test-639.cs
4128 * assign.cs (CompoundAssign.Helper): New wrapper.
4129 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4131 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4132 Pass unconverted expressions to the params array creation expression.
4133 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4134 (PropertyExpr.EmitAssign): Likewise.
4135 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4136 element if it is of kind CompoundAssign.Helper.
4137 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4138 first before anything else.
4139 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4140 (ArrayAccess.LoadArrayAndArguments): Simplify.
4142 2008-04-27 Marek Safar <marek.safar@gmail.com>
4144 * expression.cs: Fixed cloning of typeof(void).
4146 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4148 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4149 (Assign.Emit): Likewise. Move it to ...
4150 (CompoundAssign.DoResolve): ... here and ...
4151 (CompoundAssign.Emit): ... here.
4152 (EventAddOrRemove): New helper to handle += and -= on events, and
4153 avoid the use of BinaryDelegates.
4154 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4155 (EventExpr.EmitAddOrRemove): Improve.
4156 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4158 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4159 create VarExprs for 'foo.bar.var'.
4160 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4161 is a highly inappropriate name for its functionality.
4163 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4165 Simplify handling of multiple assignments
4166 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4168 (SimpleAssign): New. Class to be used for normal assignments.
4169 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4170 * expression.cs, parameter.cs, statement.cs: Likewise.
4172 2008-04-25 Marek Safar <marek.safar@gmail.com>
4174 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4175 for incompatible underlying types, more to come, uff.
4177 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4180 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4181 Handle 'leave_copy'.
4183 2008-04-25 Marek Safar <marek.safar@gmail.com>
4185 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4187 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4189 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4190 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4191 * statement.cs (While, Do, For): Allow test to have side effects.
4192 (For.DoEmit): Always emit InitStatement.
4195 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4196 Always create SideEffectConstant.
4197 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4198 of type EnumConstant.
4200 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4201 Handle 'right' being SideEffectConstant of type 'bool'.
4203 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4204 Use left.EmitBranchable instead of open coding it, so as to
4205 improve optimization opportunities.
4207 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4209 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4211 (Expression.EmitSideEffect): Document.
4213 2008-04-23 Marek Safar <marek.safar@gmail.com>
4215 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4217 2008-04-23 Marek Safar <marek.safar@gmail.com>
4219 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4221 2008-04-23 Marek Safar <marek.safar@gmail.com>
4223 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4224 conversion to expression tree.
4226 2008-04-23 Marek Safar <marek.safar@gmail.com>
4228 * ecore.cs: Removed unused expression.
4230 2008-04-22 Marek Safar <marek.safar@gmail.com>
4232 * expression.cs: Implemented NegateChecked and New expressions.
4234 2008-04-22 Marek Safar <marek.safar@gmail.com>
4236 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4238 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4241 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4242 needing final 'ret' instruction.
4244 2008-04-22 Marek Safar <marek.safar@gmail.com>
4246 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4248 2008-04-21 Marek Safar <marek.safar@gmail.com>
4250 * expression.cs: Emit ldnull and not null expression as an instance argument
4251 of static method expression calls.
4253 2008-04-21 Marek Safar <marek.safar@gmail.com>
4255 A fix for bug #378200
4256 * expression.cs: Fixed crash when creating parameterless expression tree
4259 2008-04-21 Marek Safar <marek.safar@gmail.com>
4261 A fix for bug #375297
4262 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4265 2008-04-21 Marek Safar <marek.safar@gmail.com>
4267 A fix for bug #377596
4268 * decl.cs, class.cs: Emit delegate type argument attributes.
4270 2008-04-21 Marek Safar <marek.safar@gmail.com>
4272 A fix for bug #365314
4273 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4275 2008-04-21 Marek Safar <marek.safar@gmail.com>
4277 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4280 2008-04-21 Marek Safar <marek.safar@gmail.com>
4282 * generic.cs (TypeParameter): Removed redundant location.
4284 2008-04-19 Marek Safar <marek.safar@gmail.com>
4286 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4287 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4288 FullNamedExpression in all declaration type expression, statements will come
4291 2008-04-18 Marek Safar <marek.safar@gmail.com>
4293 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4294 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4296 2008-04-18 Marek Safar <marek.safar@gmail.com>
4298 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4301 2008-04-17 Marek Safar <marek.safar@gmail.com>
4303 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4306 2008-04-17 Marek Safar <marek.safar@gmail.com>
4308 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4312 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4314 Hook up 'EmitSideEffect'
4315 * constant.cs (Constant.EmitSideEffect): New.
4316 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4317 (SideEffectConstant.EmitSideEffect): New.
4318 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4319 unconditional branch in EmitBranchable.
4320 (FieldExpr.EmitBranchable): New.
4321 * expression.cs (Unary.EmitSideEffect): New.
4322 (Binary.EmitSideEffect): New.
4323 (VariableReference.EmitSideEffect): New. Do nothing.
4325 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4327 Introduce 'EmitSideEffect'
4328 * ecore.cs (Expression.EmitSideEffect): New.
4329 (TypeCast): Rename from EmptyCast.
4331 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4332 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4333 * convert.cs, nullable.cs: Update to changes.
4335 2008-04-16 Marek Safar <marek.safar@gmail.com>
4337 * class.cs, cs-parser.jay: Early check for base types expression.
4339 2008-04-16 Marek Safar <marek.safar@gmail.com>
4341 * decl.cs (MemberName): Declare PrettyName as obsolete.
4343 2008-04-16 Marek Safar <marek.safar@gmail.com>
4345 * namespace.cs: Use MemberName comparison.
4347 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4350 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4352 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4353 (MemberName.FullyQualifiedName): New. Provides the functionality
4354 that users assume FullName would have.
4355 * ecore.cs, namespace.cs: Update to changes.
4357 * statement.cs (Using.assign): Make into ExpressionStatement.
4358 (Using.EmitPreTryBody): Simplify.
4360 2008-04-16 Marek Safar <marek.safar@gmail.com>
4362 * report.cs: ColorFormat is protected.
4364 * rootcontext.cs: Unused fields clean-up.
4366 * namespace.cs: Made UsingEntry name private.
4368 2008-04-16 Marek Safar <marek.safar@gmail.com>
4370 * cs-tokenizer.cs, location.cs: Removed unused field.
4372 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4373 Raja R Harinath <harinath@hurrynot.org>
4376 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4377 (SideEffectConstant.side_effect): Rename from 'right'.
4378 (SideEffectConstant..ctor): Normalize 'side_effect'.
4379 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4380 value of this constant.
4381 * cfold.cs: Update to changes.
4383 2008-04-15 Marek Safar <marek.safar@gmail.com>
4385 * cs-paser.jay: Removed unused variable.
4387 * driver.cs: Made Compile instance method.
4389 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4391 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4393 2008-04-15 Marek Safar <marek.safar@gmail.com>
4395 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4397 2008-04-13 Jb Evain <jbevain@novell.com>
4399 * namespace.cs: update the System.Core fullname for 2.1
4400 * driver.cs: update the list of required assemblies for 2.1.
4401 Merged from the Moonlight 2 branch.
4403 2008-04-11 Marek Safar <marek.safar@gmail.com>
4405 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4406 types and user defined operators. User operators arguments has to be checked
4407 for null value before invocation, which also means no operator is called
4408 when any argument is not convertible to unwrapped nullable type.
4410 2008-04-09 Marek Safar <marek.safar@gmail.com>
4412 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4413 of Unary expressions to follow operator overloading rules precisely.
4414 Also fixes #321794, #323794
4416 2008-04-08 Marek Safar <marek.safar@gmail.com>
4418 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4421 2008-04-08 Marek Safar <marek.safar@gmail.com>
4423 * expression.cs, ecore.cs: Implemented MemberInit expression.
4425 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4427 Fix mono/tests/exception4.cs
4428 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4429 ec.NeedReturnLabel () rather emitting a 'nop'.
4431 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4433 (TryCatch.SomeCodeFollows): Likewise.
4434 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4435 for 'break', 'continue' and 'return' statements inside a try.
4436 We're fairly sure that the generated IL stream will have more
4437 instructions textually following the try.
4438 (FlowBranchingTryCatch): Likewise.
4440 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4441 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4444 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4445 wrapper -- forward everything to CollectionForeach.
4446 (CollectionForeach.NonDisposableWrapper): New.
4447 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4448 instead of a pop + branch to end.
4450 2008-04-07 Marek Safar <marek.safar@gmail.com>
4452 A fix for bug #377485
4453 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4454 Propagate location for extension method groups. Report conversion failure at
4457 2008-04-07 Marek Safar <marek.safar@gmail.com>
4459 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4460 ListInit and Field expressions.
4462 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4464 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4465 Since $PC is always -1 inside the body of MoveNext, the fault
4467 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4468 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4469 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4471 The denouement! Fix #324708
4472 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4473 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4474 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4475 'finally' inside the finally clause.
4477 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4478 inside an iterator. Don't emit the body of the 'finally' inside
4479 the finally clause yet.
4481 Use the ResumableStatement infrastructure for MoveNext ()
4482 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4483 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4484 'old_resume_points'. Move dispatcher upfront.
4485 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4486 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4487 in an enumerator. This encodes the main fix in this patch series
4488 -- we can only jump into the first instruction of a try from the
4489 outside, but we want to emit try/finally regions in iterators and
4490 resume in the middle of them.
4492 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4494 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4495 of NeedReturnLabel here.
4497 Introduce a common point for emitting try/finally to IL
4498 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4499 features of the various subclasses, which are now driven by ...
4500 (ExceptionStatement.EmitPreTryBody): ... this and ...
4501 (ExceptionStatement.EmitTryBody): ... this and the original
4503 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4504 Remove DoEmit and update to follow above protocol.
4506 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4507 of the dispatcher are the same, skip emitting the 'switch'.
4508 * iterator.cs (Iterator.EmitDispose): Update to changes.
4510 Clean up handling of 'using' statement
4511 * statement.cs (UsingTemporary): New. Carved out of ...
4512 (Using): ... this. Simplify drastically. Handle exactly
4514 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4515 or Using as appropriate. If there are multiple variable declared,
4516 create nested Using statements.
4517 (resource_acquisition): Kill.
4519 * statement.cs (ExceptionStatement.EmitForDispose): Use
4520 EmitFinallyBody, not EmitFinally.
4522 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4523 * iterator.cs: Update to changes.
4525 Start using the ResumableStatement infrastructure
4526 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4527 (ResumableStatement.EmitForDispose): New.
4528 (ExceptionStatement): Override them.
4529 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4530 EmitForDispose to create the body of the Dispose method. Don't
4533 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4534 * statement.cs (Toplevel.AddResumePoint): ... here.
4535 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4536 * flowanalysis.cs (FlowBranchingIterator): New.
4537 * codegen.cs (EmitContext): Update to changes.
4539 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4540 (Iterator.old_resume_points): Rename from 'resume_points'.
4541 (Iterator.MoveNextStatement): Remove unused class.
4543 New infrastructure for try/finally in iterators (still unused)
4544 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4545 (FlowBranchingToplevel.AddResumePoint): Hook into
4546 ToplevelBlock.AddResumePoint.
4547 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4548 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4549 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4550 resume points and assign program-counter values.
4551 (ExceptionBlock.AddResumePoint): Collect resume points for
4552 de-muxer at the top of try block.
4553 * iterators.cs (Yield.CheckContext): Simplify.
4554 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4556 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4558 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4559 argument to an ExitStatement.
4560 (FlowBranchingException): Refactor saved origins code.
4561 * statement.cs (ExitStatement): Update to cahges.
4562 * iterator.cs (YieldBreak): Likewise.
4564 * statement.cs (ResumableStatement): New. Common base class for
4565 YieldReturn and ExceptionStatement.
4566 (ExitStatement): New. Common base class for Return and YieldBreak.
4567 (Return): Update to changes.
4568 * iterator.cs (YieldBreak): Likewise.
4569 * lambda.cs (ContextualReturn): Likewise.
4572 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4573 emit a meaningful error message.
4575 Fix #324765, #319508
4576 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4577 (VariableInfo.SetAssigned): Set it.
4578 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4579 determine if CS0219 or CS0168 is appropriate. Don't use
4580 flow-analysis information.
4581 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4582 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4583 (EmitContext.EndFlowBranching): ... this.
4585 2008-04-03 Marek Safar <marek.safar@gmail.com>
4587 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
4589 2008-04-03 Marek Safar <marek.safar@gmail.com>
4591 A fix for bug #376508
4592 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
4593 ImplicitConversionExists.
4595 2008-04-03 Marek Safar <marek.safar@gmail.com>
4597 * expression.cs (Binary): Added remaining binary operators to expression
4600 * nullable.cs: Optimize shift with null argument.
4602 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
4604 Fix minor IL regression
4605 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
4606 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
4607 * cs-parser.jay (try_statement): Update to changes.
4609 * statement.cs (TryFinally.need_exc_block): Delete.
4610 (TryFinally): Update to changes.
4612 Now all ExceptionStatements are unconditional
4613 * statement.cs (CollectionForeach.DisposableWrapper): New.
4614 Extract out the try/finally code into a new wrapper.
4615 (CollectionForeach.Resolve): Use it to simplify the code.
4617 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
4619 Start at simplifying ExceptionStatement semantics a bit
4620 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
4621 * cs-parser.jay (try_statement): Update to changes.
4622 (opt_catch_clauses): Remove.
4623 * flowanalysis.cs: Update to changes.
4624 (FlowBranching.BranchingType.TryCatch): New.
4625 (FlowBranchingTryCatch): New.
4627 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
4628 (FlowBranching.CreateBranching): Update to changes.
4629 (FlowBranchingBlock.AddSibling): Add sanity check.
4630 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
4633 * iterators.cs (Iterator.MarkFinally): Remove.
4634 * statement.cs (ExceptionStatement): Update to changes.
4636 Add support for skipping over finally blocks at runtime. First
4637 in a series to fix #324708
4638 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
4639 (Iterator.EmitMoveNext): Initialize it.
4640 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
4641 branch over the body of the 'finally' clause.
4643 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
4645 Avoid lopsided use of Foo/DoFoo names
4646 * statement.cs (ExpressionStatement.EmitFinallyBody):
4647 Rename from EmitFinally.
4648 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
4649 * iterator.cs: Update to changes.
4651 2008-04-02 Marek Safar <marek.safar@gmail.com>
4653 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
4654 based on UserOperatorCall. More binary nullable operators clean up.
4656 2008-04-02 Martin Baulig <martin@ximian.com>
4658 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
4660 2008-04-02 Marek Safar <marek.safar@gmail.com>
4662 * nullable.cs: Merge user and empty conversions when lifting expression
4665 * expression.cs (StringConcat): Implemented expression tree representation.
4667 2008-04-01 Marek Safar <marek.safar@gmail.com>
4669 * nullable.cs: When lifting null literal and a user operator exists, no call
4672 2008-04-01 Marek Safar <marek.safar@gmail.com>
4674 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
4677 2008-04-01 Marek Safar <marek.safar@gmail.com>
4679 * nullable.cs, expression.cs: Use namespace instead heavily nested
4680 monster abstract class.
4682 2008-04-01 Marek Safar <marek.safar@gmail.com>
4684 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
4685 lifting of null literal and user operators. Clean up of some temporary
4688 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
4690 Fix #368224, test-629.cs
4691 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
4692 if it crossed an unwind-protect boundary.
4693 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
4694 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
4695 inside an unwind-protected region.
4696 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
4697 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
4698 'leave' instead of a 'br' if unwind-protected.
4699 (Iterator.EmitYieldBreak): Likewise.
4701 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
4703 * driver.cs: Only define versioninfo resources if no win32 resource
4706 2008-03-28 Marek Safar <marek.safar@gmail.com>
4708 A fix for bug #372375
4709 * convert.cs: Fixed boxing of nullable types.
4711 2008-03-28 Marek Safar <marek.safar@gmail.com>
4713 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
4716 2008-03-28 Marek Safar <marek.safar@gmail.com>
4718 A fix for bug #374619
4719 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
4721 2008-03-27 Marek Safar <marek.safar@gmail.com>
4723 * lambda.cs: Check return type only for invocation.
4725 2008-03-27 Marek Safar <marek.safar@gmail.com>
4727 A fix for bug #374214
4728 * ecore.cs: Correctly report argument type mismatch.
4730 2008-03-27 Marek Safar <marek.safar@gmail.com>
4732 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
4733 and not rely on broken IsEnum.
4735 2008-03-27 Marek Safar <marek.safar@gmail.com>
4737 * nullable.cs: New file, extracted from generic.cs.
4739 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
4741 2008-03-27 Marek Safar <marek.safar@gmail.com>
4743 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
4744 predefined comparison operators and null literals.
4746 * report.cs: New warning ID.
4748 2008-03-25 Marek Safar <marek.safar@gmail.com>
4750 A fix for bug #370577
4751 * lambda.cs: Check return type too.
4753 2008-03-25 Marek Safar <marek.safar@gmail.com>
4755 A fix for bug #372846
4756 * class.cs: Automatic properties can be declared as unsafe.
4758 2008-03-20 Marek Safar <marek.safar@gmail.com>
4760 * location.cs: Use string based concatenation.
4762 * expression.cs: LiftedBinaryOperator is gmcs only.
4764 2008-03-20 Marek Safar <marek.safar@gmail.com>
4766 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
4767 conversions rules and expression trees.
4769 2008-03-19 Marek Safar <marek.safar@gmail.com>
4771 * delegate.cs: Use extension method source as delegate target.
4773 2008-03-19 Marek Safar <marek.safar@gmail.com>
4775 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
4776 binary operations to be purely based on binary operations and optimized
4777 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
4778 and other ET refactoring.
4780 * typemanager.cs: Fixed warning.
4782 2008-03-17 Marek Safar <marek.safar@gmail.com>
4784 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
4786 * symbolwriter.cs: Fixed.
4788 2008-03-17 Marek Safar <marek.safar@gmail.com>
4790 * anonymous.cs, driver.cs: Reset anonymous types counters.
4792 2008-03-17 Marek Safar <marek.safar@gmail.com>
4794 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
4796 * class.cs: Use fullname for all type member definitions.
4798 2008-02-19 Martin Baulig <martin@ximian.com>
4801 (IMethodData.EmitExtraSymbolInfo): New interface method.
4802 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
4803 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
4804 interface method here as an empty public virtual method.
4807 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
4808 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
4809 CodeGen.SymbolWriter.SetRealMethodName().
4811 2008-02-18 Martin Baulig <martin@ximian.com>
4814 (ScopeInfo.EmitType): Override this and emit debugging
4815 information for captured variables.
4816 (RootScopeInfo.EmitType): Override this and emit symbol
4817 information for a captured `this'.
4819 2008-02-15 Martin Baulig <martin@ximian.com>
4821 * iterators.cs: Emit debugging info.
4824 (EmitContext.Flags): Add `OmitDebuggingInfo'.
4825 (EmitContext.OmitDebuggingInfo): New public property.
4828 (While): Override Emit() and don't emit symbol info there; do it
4829 inside DoEmit() instead.
4830 (Block.Emit): Omit symbol information while emitting the scope
4831 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
4833 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
4834 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
4835 .ctor to make `IsIterator' work.
4837 2008-03-14 Martin Baulig <martin@ximian.com>
4839 * symbolwriter.cs: Added the new symbol writer function from the
4840 debugger's `terrania' branch; temporarily enclose them inside
4841 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
4844 2008-03-14 Martin Baulig <martin@ximian.com>
4847 (SymbolWriter): Make this a public static class.
4850 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
4851 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
4853 2008-03-14 Marek Safar <marek.safar@gmail.com>
4855 A fix for bug #370577
4856 * statement.cs, lambda.cs: Added extra limitations when dealing with void
4859 2008-03-14 Marek Safar <marek.safar@gmail.com>
4861 * typemanager.cs (CSharpName): Made 250 times faster.
4863 2008-03-13 Marek Safar <marek.safar@gmail.com>
4865 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
4867 2008-03-12 Marek Safar <marek.safar@gmail.com>
4869 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
4870 crash when predefined field does not exist.
4872 2008-03-12 Marek Safar <marek.safar@gmail.com>
4874 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
4876 2008-03-12 Marek Safar <marek.safar@gmail.com>
4878 * class.cs (FixedField): Don't crash when contructors are missing.
4880 2008-03-11 Marek Safar <marek.safar@gmail.com>
4882 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
4883 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
4884 check internal types accessibility for internal and external types.
4885 Replaced EnumToUnderlying by GetEnumUnderlyingType.
4887 2008-03-11 Marek Safar <marek.safar@gmail.com>
4889 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
4890 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
4891 attribute.cs, statement: Use corect instance of predefined types (work
4892 related to #364674).
4894 2008-03-07 Marek Safar <marek.safar@gmail.com>
4896 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
4898 2008-03-07 Marek Safar <marek.safar@gmail.com>
4900 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
4901 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
4902 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
4903 predefined types clean up, delayed predefined types members initialization
4904 (work related to #364674).
4906 2008-03-05 Marek Safar <marek.safar@gmail.com>
4908 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
4910 2008-03-05 Marek Safar <marek.safar@gmail.com>
4912 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
4913 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
4914 predefined types clean up (work related to #364674).
4916 2008-03-04 Marek Safar <marek.safar@gmail.com>
4918 * ecore.cs: Print an error message instead of throwing exception.
4920 2008-03-04 Marek Safar <marek.safar@gmail.com>
4922 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
4923 expression.cs, statement.cs: Unififed null literal representation.
4925 2008-03-03 Marek Safar <marek.safar@gmail.com>
4927 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
4928 expression.cs: Refactored binary operators resolve phase and improved speed.
4929 The nullable code is still missing and won't work correctly, more fixes
4932 It also fixes #323726, #324312, #324248, and many other unreported issues.
4934 2008-02-29 Zoltan Varga <vargaz@gmail.com>
4936 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
4939 2008-02-27 Marek Safar <marek.safar@gmail.com>
4941 * ecore.cs: Clean-up and split BetterConversion.
4943 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
4946 * enum.cs (EnumMember.Value): Only access 'value' if
4947 ResolveValue says it's ok.
4948 (EnumMember.DoResolveValue): Don't set prev_member.value.
4949 (Enum.GetDefinition): Reverse arguments of Equals --
4950 EnumMember.Value can return 'null'.
4952 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
4954 2008-02-22 Marek Safar <marek.safar@gmail.com>
4956 * generic.cs, expression.cs: More ongoing work on expression trees.
4958 2008-02-21 Marek Safar <marek.safar@gmail.com>
4960 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
4961 handle missing matches when mutiple operators exist.
4963 2008-02-20 Marek Safar <marek.safar@gmail.com>
4965 A fix for bug #363218
4966 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
4969 2008-02-20 Marek Safar <marek.safar@gmail.com>
4971 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
4972 update. This time to deal correctly with SideEffectConstant expression used
4973 as an argument for another constant folding.
4975 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
4977 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
4980 2008-02-19 Marek Safar <marek.safar@gmail.com>
4982 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
4984 2008-02-19 Marek Safar <marek.safar@gmail.com>
4986 A fix for bug #328136
4987 * expression.cs: Do not fold immediately LogicalAnd operators when the left
4988 side is a false constant, because we still need to evaluate the right-hand
4991 * statement.cs (If): Emit two types of boolean constants (simple constant,
4992 side-effect constant).
4994 2008-02-19 Marek Safar <marek.safar@gmail.com>
4996 * constant.cs (SideEffectConstant): Don't emit boolean constant.
4998 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5001 2008-02-18 Marek Safar <marek.safar@gmail.com>
5003 A fix for bug #361457
5004 * ecore.cs (IsApplicable): Params methods have lower priority.
5006 * support.cs: Return correct parameter modifier for params types.
5008 2008-02-18 Marek Safar <marek.safar@gmail.com>
5010 * generic.cs (TypeParameter): Cache attribute target name.
5012 * support.cs: Removed unused variable.
5014 * typemanager.cs: Removed debugging leftover.
5016 * ecore.cs: Use local type instead of a property;
5018 * class.cs (VerifyMembers): Consider also parent to test whether type member
5021 * expression.cs (FullMethodDesc): Removed.
5023 * attribute.cs (IsValidArgumentType): Made static.
5025 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5027 Cleanup to be more readable.
5028 * Makefile (GMCS_PROFILE): Remove.
5029 (COMPILER_NAME): New helper.
5031 2008-02-15 Miguel de Icaza <miguel@novell.com>
5033 * cs-tokenizer.cs: if a conditional expression happens inside a
5034 (...) this also means that we do not need to de-ambiguate between
5035 an parenthesized expression and a cast.
5039 * constant.cs (SideEffectConstant): a constant value that happens
5040 to have a side effect.
5042 Fixes the build regressions introduced by the fix for #359789
5044 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5046 * expression.cs (Conditional.Emit): when emitting the ternary
5047 operator, use local variables to generate code verifiable code.
5049 The verifier cannot infer that the type on stack before the
5050 stloc.0 is executed is of type ParentB. This happens because the
5051 stack merge algorithm uses only parent types when deciding which
5052 is the common type. This is described in Part III 1.8.1.3 of ECMA
5055 This code compiled with mcs is not verifiable under MS. The MS
5056 verifier picks the first common interface of Foo and Bar, which is
5057 wrong, but doesn't use a full join type of the 2 interfaces.
5059 CSC uses a clever hack to compile such code in a verifiable
5060 way. It stores the intermediate values in a local variable with
5065 2008-02-14 Miguel de Icaza <miguel@novell.com>
5067 * expression.cs: Do not fold BitwiseAnd operators when the left
5068 side is a false constant, because we still need to evaluate the
5073 * support.cs: Instead of throwing an InternalErrorException when
5074 the position of the stream is outside the boundary of our buffer,
5075 reset the state of the reader, and restart the reading from the
5076 beginning of the file.
5078 2008-02-14 Marek Safar <marek.safar@gmail.com>
5080 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5082 2008-02-14 Marek Safar <marek.safar@gmail.com>
5084 A fix for bug #361686
5085 * decl.cs: A protected types used inside a private class which parents
5086 derives from the protected class are accessible.
5088 2008-02-13 Marek Safar <marek.safar@gmail.com>
5090 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5091 the parameterless constructor.
5093 2008-02-13 Marek Safar <marek.safar@gmail.com>
5095 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5096 lookup methods to use standard member cache when doing member lookup.
5098 2008-02-12 Marek Safar <marek.safar@gmail.com>
5100 * driver.cs: Don't report full path for referenced module as assembly error.
5102 2008-02-12 Marek Safar <marek.safar@gmail.com>
5104 * Makefile: Fixed `qh' target to work on all machines.
5106 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5107 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5108 and HasElementType with TypeManager implementation.
5110 2008-02-08 Marek Safar <marek.safar@gmail.com>
5112 A fix for bugs #325134, #359749
5113 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5114 first binds point to non-method member expression.
5116 2008-02-08 Marek Safar <marek.safar@gmail.com>
5118 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5120 2008-02-08 Marek Safar <marek.safar@gmail.com>
5122 A fix for bugs #321394, #323028
5123 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5124 Reworked naive IsAccessibleAs implementation to handle nested types.
5126 2008-02-05 Jb Evain <jbevain@novell.com>
5128 * class.cs: use generic type comparison for parameters
5131 2008-02-05 Marek Safar <marek.safar@gmail.com>
5133 A fix for bug #325372
5134 * class.cs: Use generic type comparison when testing method signatures.
5136 2008-02-05 Marek Safar <marek.safar@gmail.com>
5138 A fix for bug #357047
5139 * ecore.cs: Applied C# 3.0 changes to better conversion.
5141 2008-02-05 Marek Safar <marek.safar@gmail.com>
5143 A fix for bug #358374
5144 * cs-parser.jay: Correctly set modifiers for all constructor types.
5146 2008-02-04 Marek Safar <marek.safar@gmail.com>
5148 A fix for bug #355251
5149 * generic.cs: Added base class constraint based type inference.
5151 2008-02-01 Marek Safar <marek.safar@gmail.com>
5153 A fix for bug #357255
5154 * decl.cs: One more missing visibility check.
5156 2008-02-01 Marek Safar <marek.safar@gmail.com>
5158 * support.cs: Fixed broken return.
5160 2008-01-25 Marek Safar <marek.safar@gmail.com>
5162 * report.cs: Correctly reset warnings count after probing.
5164 2008-01-25 Martin Baulig <martin@ximian.com>
5167 (NamespaceEntry.SymbolFileID): Make this work again after
5168 MemberName.ToString() is gone.
5170 2008-01-25 Marek Safar <marek.safar@gmail.com>
5172 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5175 2008-01-25 Marek Safar <marek.safar@gmail.com>
5177 * generic.cs: Use full implicit conversion for type inference fixing.
5179 2008-01-24 Marek Safar <marek.safar@gmail.com>
5181 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5182 Fixed user operator conversions.
5184 2008-01-24 Marek Safar <marek.safar@gmail.com>
5186 * generic.cs: Do nullable type to null comparison optimization during
5189 2008-01-24 Marek Safar <marek.safar@gmail.com>
5191 A fix for bug #355163
5192 * generic.cs: Enabled l-value resolve on nullable expressions.
5194 2008-01-24 Marek Safar <marek.safar@gmail.com>
5196 A fix for bug #353986
5197 * class.cs: Ingore static ctors with parameters for any further checks.
5199 2008-01-24 Marek Safar <marek.safar@gmail.com>
5201 A fix for bug #354310
5202 * namespace.cs: Removed redundant check.
5204 2008-01-24 Marek Safar <marek.safar@gmail.com>
5206 A fix for bug #354928
5207 * expression.cs: ElementInitializers can be resolved only once.
5209 2008-01-24 Marek Safar <marek.safar@gmail.com>
5211 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5212 Condition expressions.
5214 2008-01-23 Marek Safar <marek.safar@gmail.com>
5216 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5218 2008-01-22 Marek Safar <marek.safar@gmail.com>
5220 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5223 * generic.cs: Implemented coalesce expression.
5225 2008-01-22 Marek Safar <marek.safar@gmail.com>
5227 A fix for bug #355145
5228 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5229 expression tree type inference.
5231 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5234 * expression.cs (Binary.IsUnsignedType): Fix typo.
5236 2008-01-22 Marek Safar <marek.safar@gmail.com>
5238 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5240 2008-01-22 Marek Safar <marek.safar@gmail.com>
5242 A fix for bug #355161
5243 * ecore.cs, expression.cs: Wider range of extension method supported
5246 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5248 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5249 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5252 2008-01-22 Marek Safar <marek.safar@gmail.com>
5254 A fix for bug #355148
5255 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5257 2008-01-22 Miguel de Icaza <miguel@novell.com>
5259 * expression.cs (CreateExpressionTree): Add support for or and
5260 logical or, and indent following the coding conventions.
5262 * typemanager.cs (LinqExpression): renamed from
5263 ExpressionTreeManager, for a shorter name.
5265 Use TypeManager.CoreLookupType to lookup types from our core
5266 assemblies and turn those into "Type" variables.
5268 Consumers that previously used "Namespace" and "Type" from this
5269 class should instead use the TypeExpression which is a type that
5270 is fully resolved (without involving the regular C# resolution
5273 This typically looks like this:
5275 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5276 new MemberAccess (texpr, name, type_arguments, loc)
5278 This avoids the problem in: #355178
5280 2008-01-21 Marek Safar <marek.safar@gmail.com>
5282 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5283 feature in parser only as we do in other cases.
5285 2008-01-21 Marek Safar <marek.safar@gmail.com>
5287 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5288 typemanager.cs: A refactoring of params arguments to reuse existing
5289 expressions (params -> array initializer) to emit params argument instead
5290 of specialized handling.
5291 It was required by expression tree implementation and it has other benefits
5292 as well, we now apply same optimization for params arguments as we do for
5295 2008-01-18 Marek Safar <marek.safar@gmail.com>
5297 A fix for bug #353526
5298 * generic.cs: A type inference of params arguments may not required any
5299 temporary array creation.
5301 2008-01-18 Marek Safar <marek.safar@gmail.com>
5303 A fix for bug #353534
5304 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5305 supported for delegates only.
5307 2008-01-18 Marek Safar <marek.safar@gmail.com>
5309 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5310 type for more than 1 candidates.
5312 2008-01-18 Marek Safar <marek.safar@gmail.com>
5314 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5317 2008-01-16 Marek Safar <marek.safar@gmail.com>
5319 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5320 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5321 operator) expressions.
5323 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5325 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5326 not accessed from the generated IL.
5328 2008-01-14 Marek Safar <marek.safar@gmail.com>
5330 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5331 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5332 statement.cs: The first expression tree implementation drop, mostly
5333 infrastructure work.
5335 2008-01-14 Marek Safar <marek.safar@gmail.com>
5337 * ecore.cs (IsNestedChild): Refactored.
5339 2008-01-11 Marek Safar <marek.safar@gmail.com>
5341 * lambda.cs: Don't use a cast on unknown expression statement.
5343 2008-01-10 Geoff Norton <gnorton@novell.com>
5345 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5348 2008-01-09 Marek Safar <marek.safar@gmail.com>
5350 * doc.cs: Report better /doc crash details.
5352 2008-01-09 Marek Safar <marek.safar@gmail.com>
5354 A fix for bug #352536
5355 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5357 2008-01-08 Marek Safar <marek.safar@gmail.com>
5359 A fix for bug #352287
5360 * ecore.cs, expression.cs: Do `this' access checking in all member access
5363 2008-01-08 Marek Safar <marek.safar@gmail.com>
5365 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5367 * report.cs: Reset message stacks.
5369 2008-01-08 Marek Safar <marek.safar@gmail.com>
5371 * generic.cs (InferInPhases): Correctly calculate params position.
5373 2008-01-08 Marek Safar <marek.safar@gmail.com>
5375 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5378 2008-01-07 Marek Safar <marek.safar@gmail.com>
5380 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5382 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5384 * driver.cs: Updated --help option.
5386 2008-01-07 Marek Safar <marek.safar@gmail.com>
5388 * generic.cs (InferParamsTypeArguments): Removed.
5389 (InferInPhases): Add params type inference.
5390 (LowerBoundInference): Fixed scoring mechanism.
5392 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5394 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5396 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5397 byte array for unsigned "baked" assemblies.
5399 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5401 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5402 array for assemblies that are not strongnamed.
5404 2008-01-04 Marek Safar <marek.safar@gmail.com>
5406 A fix for bug #351481
5407 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5408 declaring type for nested generic types.
5410 2008-01-04 Marek Safar <marek.safar@gmail.com>
5412 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5413 instead of ToString.
5415 2008-01-03 Marek Safar <marek.safar@gmail.com>
5417 A fix for bug #351047
5418 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5419 null and structs only when equality and inequality operators are defined
5420 either as an user-operators or predefined operators.
5422 2008-01-03 Marek Safar <marek.safar@gmail.com>
5424 A fix for bug #351047
5425 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5427 2008-01-03 Marek Safar <marek.safar@gmail.com>
5429 A fix for bug #351257
5430 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5432 2008-01-03 Marek Safar <marek.safar@gmail.com>
5434 A fix for bug #351157
5435 * class.cs (Using): Fixed yet another broken cloning.
5437 (Block): Put back more sensible default value for statements.
5439 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5441 * codegen.cs: Allow AssemblyVersion with only major version component.
5444 2007-12-29 Marek Safar <marek.safar@gmail.com>
5446 A fix for bug #324654
5447 * class.cs: Use FullName property as member name.
5449 2007-12-28 Marek Safar <marek.safar@gmail.com>
5451 A fix for bug #342117
5452 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5453 constructor constraint.
5455 2007-12-28 Marek Safar <marek.safar@gmail.com>
5457 A fix for bug #338273
5458 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5461 2007-12-28 Marek Safar <marek.safar@gmail.com>
5463 A fix for bug #350839
5464 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5466 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5468 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5471 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5473 * statement.cs: Changed some Hashtables to use HybridDictionaries
5474 instead. It was observed that some HashTables only contained a few
5475 items in the vast majority of cases. Since HybridDictionary is
5476 more efficient on small sets (<10 elements), "known_variables"
5477 from class ExplicitBlock as well as "labels" and "constants " from
5478 class Block were changed to HybridDictionaries.
5480 Atsai results: (56216kb->54987kb)
5482 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5485 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5487 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5490 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5492 * expression.cs: foreach loop to for loop, saved on allocation of
5493 enumerator (59333kb->59141kb)
5495 * statement.cs. Changed foreach loops to for loops, saved on
5496 allocation of enumerator (59141kb->59006kb)
5498 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5499 when constructed with no specified capacity. This was causing a
5500 few ArrayLists to allocate more memory than they would potentially
5501 need in the Block class and MemberCache class. Setting the
5502 ArrayLists to construct with a capacity of 1 saves some
5503 memory. (56216kb->55585kb)
5505 2007-12-27 Marek Safar <marek.safar@gmail.com>
5507 A fix for bug #347189 (2nd issue)
5508 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5511 2007-12-27 Miguel de Icaza <miguel@novell.com>
5513 * report.cs: Do not use colors if stdout and stderr are not a
5516 2007-12-27 Marek Safar <marek.safar@gmail.com>
5518 A fix for bug #346998
5519 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5522 2007-12-27 Marek Safar <marek.safar@gmail.com>
5524 A fix for bug #343465
5525 * class.cs: Explicit method name for nested types uses dots only.
5527 2007-12-27 Marek Safar <marek.safar@gmail.com>
5529 A fix for bug #343707
5530 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5532 2007-12-27 Marek Safar <marek.safar@gmail.com>
5534 * ecore.cs: Report type inference errors only when arguments count matches
5537 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5539 * expression.cs, report.cs: New warning.
5541 * typemanager.cs: Catch anonymous method type too.
5543 2007-12-23 Marek Safar <marek.safar@gmail.com>
5545 A fix for bug #346379
5546 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5548 2007-12-23 Marek Safar <marek.safar@gmail.com>
5550 A fix for bug #347359
5551 * expression.cs (Invocation): Don't resolve already resolved expression.
5553 2007-12-23 Marek Safar <marek.safar@gmail.com>
5555 A fix for bug #347189
5556 * class.cs (FixedField): Use non-dependent code only in the define phase.
5558 2007-12-23 Marek Safar <marek.safar@gmail.com>
5560 A fix for bug #348076
5561 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5563 2007-12-22 Marek Safar <marek.safar@gmail.com>
5565 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5566 discovered extension methods.
5568 2007-12-22 Marek Safar <marek.safar@gmail.com>
5570 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5573 2007-12-21 Miguel de Icaza <miguel@novell.com>
5575 * report.cs (ErrorMessage): Add support for using colors on
5576 terminals that support it.
5578 2007-12-21 Marek Safar <marek.safar@gmail.com>
5580 * ecore.cs: Use information about expanded params for error reporting.
5582 2007-12-21 Marek Safar <marek.safar@gmail.com>
5584 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5585 and logic for params overloads.
5587 2007-12-15 Miguel de Icaza <miguel@novell.com>
5589 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
5590 as this is also created from the parser. Fixes #349034
5592 2007-12-12 Miguel de Icaza <miguel@novell.com>
5594 * statement.cs (Throw.CloneTo): it is valid to have empty
5595 expressions for throw.
5597 2007-12-03 Marek Safar <marek.safar@gmail.com>
5599 * cs-parser.jay: Set delegate constraint parsing region correctly.
5601 2007-12-03 Marek Safar <marek.safar@gmail.com>
5603 A fix for bug #345467
5604 * typemanager.cs (IsEqual): Compare generic parameters position only.
5606 2007-11-28 Marek Safar <marek.safar@gmail.com>
5608 * expression.cs (BaseAccess): Type arguments can be null.
5610 2007-11-27 Raja R Harinath <harinath@gmail.com>
5612 * statement.cs (Block.Resolve): Ensure flow-branching tree is
5613 consistent even when an error has occured.
5614 (Switch.Resolve): Likewise.
5616 2007-11-22 Marek Safar <marek.safar@gmail.com>
5618 A fix for bug #334505
5619 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
5622 2007-11-22 Marek Safar <marek.safar@gmail.com>
5624 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
5625 refactorings required to resolve extension methods correctly when mixing
5626 generics and non-generics members.
5628 2007-11-20 Marek Safar <marek.safar@gmail.com>
5630 A fix for bug #342584
5631 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
5634 2007-11-19 Marek Safar <marek.safar@gmail.com>
5636 A fix for bug #342512
5637 * delegate.cs: Use delegate argument expression when is available. Don't
5638 emit virtual call when class is sealed.
5640 2007-11-16 Marek Safar <marek.safar@gmail.com>
5642 A fix for bug #325423
5643 * assign.cs (FieldInitializer): Use resolved expression for emit.
5645 * class.cs: Print less confusing error message.
5647 2007-11-16 Marek Safar <marek.safar@gmail.com>
5649 * cs-tokenizer.cs: Removed GMCS ifdefs.
5651 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
5654 * cs-parser.jay: Disabled nullable check.
5656 * generic-mcs: Copied more generic stuff.
5658 2007-11-16 Marek Safar <marek.safar@gmail.com>
5660 * gcs-parser.jay: Merged to cs-parser.jay.
5662 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
5663 * *.csproj, *.sources: Updated to use only jay parser file.
5665 2007-11-16 Marek Safar <marek.safar@gmail.com>
5667 * gcs-parser.jay: Added nullable and default expression feature checks.
5669 2007-11-16 Marek Safar <marek.safar@gmail.com>
5671 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
5672 it fixes many TODOs and hidden bugs.
5674 * expression: Removed duplicate error check.
5676 2007-11-15 Marek Safar <marek.safar@gmail.com>
5678 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
5679 implicitly type local variable only when it is used in a declaration.
5681 2007-11-15 Marek Safar <marek.safar@gmail.com>
5683 * attribute.cs: Use CS0612 for empty strings.
5685 2007-11-14 Marek Safar <marek.safar@gmail.com>
5687 * lambda.cs, statement.cs: Contextual return may act as a statement.
5689 2007-11-14 Marek Safar <marek.safar@gmail.com>
5691 A fix for a regression cause by #324222
5692 * class.cs: Don't report unused even when it implements an interface.
5694 2007-11-13 Marek Safar <marek.safar@gmail.com>
5696 A fix for bug #341205
5697 * ecore.cs, expression.cs: Method group expression cannot do static
5698 method access with an instance reference check before overloading takes
5701 2007-11-13 Marek Safar <marek.safar@gmail.com>
5703 A fix for bug #325359
5704 * class.cs: Use predictable name for automatically generated property.
5706 2007-11-12 Marek Safar <marek.safar@gmail.com>
5708 A fix for bug #324996
5709 * expression.cs (Is): Handle case where D is nullable and T is not
5712 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
5714 2007-11-12 Marek Safar <marek.safar@gmail.com>
5716 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
5717 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
5718 Flush small error reporting changes.
5720 2007-11-09 Marek Safar <marek.safar@gmail.com>
5722 A fix for bug #324996
5723 * expression.cs: Rewrote Is expression implementation to work with
5724 generics, nullable types, anonymous method. A const result expression
5725 uses existing infrastructure instead of custom not fully-featured one.
5727 2007-11-08 Marek Safar <marek.safar@gmail.com>
5729 A fix for bug #340202
5730 * class.cs: Consider generics for volatile field.
5732 2007-11-08 Marek Safar <marek.safar@gmail.com>
5734 A fix for bug #335594
5735 * expression.cs: Use conversion rules when handling string addition.
5737 2007-11-07 Marek Safar <marek.safar@gmail.com>
5739 A fix for bug #336651
5740 * expression.cs: Fixed a crash when probing is on.
5742 2007-11-07 Marek Safar <marek.safar@gmail.com>
5744 A fix for bug #324242
5745 * covert.cs: Added a conversion from any nullable-type with an
5746 underlying enum-type to the type System.Enum.
5748 2007-11-07 Marek Safar <marek.safar@gmail.com>
5750 A fix for bug #324222
5751 * class.cs: Report all non-used event fields.
5753 2007-11-07 Marek Safar <marek.safar@gmail.com>
5755 A fix for bug #325161
5756 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
5757 qualifier for generic types.
5759 2007-11-07 Marek Safar <marek.safar@gmail.com>
5761 A fix for bug #322971
5762 * expression.cs, ecore.cs: Added intermediate result value check for
5765 2007-11-07 Marek Safar <marek.safar@gmail.com>
5767 A fix for bug #324754
5768 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
5769 when it was requested.
5771 2007-11-07 Marek Safar <marek.safar@gmail.com>
5773 A fix for bug #325101
5774 * expression.cs: Do type not value comparison for `is' expression.
5776 2007-11-07 Marek Safar <marek.safar@gmail.com>
5778 A fix for bug #320236
5779 * convert.cs: Don't apply user conversion on underlying target type.
5781 2007-11-06 Marek Safar <marek.safar@gmail.com>
5783 * expression.cs: Don't use unresolved expression for error reporting.
5785 2007-11-06 Marek Safar <marek.safar@gmail.com>
5787 A fix for bugs #337712, #324490
5788 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
5789 overloading resolution too.
5791 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
5792 the process consistent and more robust.
5794 * expression.cs, linq.cs, report.cs: Update.
5796 2007-11-02 Marek Safar <marek.safar@gmail.com>
5798 A fix for bug #332909
5799 * attribute.cs: Resolve attributes in correct context using error
5802 * rootcontext.cs: Define Obsolete attribute members as core members.
5804 2007-11-02 Marek Safar <marek.safar@gmail.com>
5806 * statement.cs: Removed unused methods.
5808 2007-10-31 Wade Berrier <wberrier@novell.com>
5810 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
5811 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
5814 2007-10-31 Marek Safar <marek.safar@gmail.com>
5816 A fix for bug #338102
5817 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
5818 methods registered as non-generics.
5820 2007-10-31 Marek Safar <marek.safar@gmail.com>
5822 A fix for bugs #337712, #324490
5823 * delegate.cs: Delegate covariance and contravariance is not allowed for
5826 2007-10-31 Marek Safar <marek.safar@gmail.com>
5828 A fix for bug #337719
5829 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
5832 2007-10-30 Marek Safar <marek.safar@gmail.com>
5834 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
5836 2007-10-29 Marek Safar <marek.safar@gmail.com>
5838 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
5841 2007-10-29 Raja R Harinath <rharinath@novell.com>
5843 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
5845 2007-10-29 Marek Safar <marek.safar@gmail.com>
5847 A fix for bug #334652
5848 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
5849 extension methods when we have not found the best candidate in normal
5852 2007-10-27 Marek Safar <marek.safar@gmail.com>
5854 * AssemblyInfo.cs: Keep up-to-date.
5856 2007-10-27 Marek Safar <marek.safar@gmail.com>
5858 * Makefile: Fixed generics compiler name.
5860 2007-10-27 Marek Safar <marek.safar@gmail.com>
5862 * lambda.test: removed, lambda parsing is done differently.
5864 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
5866 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
5868 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
5870 2007-10-27 Marek Safar <marek.safar@gmail.com>
5872 * Makefile, *.sources : All C# compilers are in mcs folder.
5874 * *.cs: Use existing 2_1 define for smcs.
5876 2007-10-26 Marek Safar <marek.safar@gmail.com>
5878 A fix for bug #335847
5879 * assign.cs, expression.cs: Couple of changes to avoid creating a
5880 temporary variable for each object initializer assignment statement. It
5881 simplifies struct initialization too, otherwise two temporary variables
5883 Implemented optimization of redundant default element initializers.
5885 2007-10-25 Marek Safar <marek.safar@gmail.com>
5887 A fix for bug #336766
5888 * expression.cs (Class.CheckBase): Use generic name when method is
5891 2007-10-25 Marek Safar <marek.safar@gmail.com>
5893 A fix for bug #334737
5894 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
5895 variable and not variable argument for prepared copies.
5897 2007-10-24 Marek Safar <marek.safar@gmail.com>
5899 A fix for bug #325110
5900 * class.cs, expression.cs, attribute.cs: Use open generic method when
5901 checking conditional attribute.
5903 2007-10-24 Marek Safar <marek.safar@gmail.com>
5905 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
5906 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
5907 FeatureIsNotAvailable.
5909 2007-10-24 Marek Safar <marek.safar@gmail.com>
5911 ** C# 3.0 Partial methods
5913 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
5914 methods support. Because of member cache issue with generics only
5915 non-generics partial methods are fully supported.
5917 2007-10-23 Marek Safar <marek.safar@gmail.com>
5919 * class.cs, decl.cs: Rewrote member overloads check to cope with
5920 generics and to use member cache for member checking. It also improves
5921 performance and fixes remaining overloads issues.
5923 2007-10-20 Marek Safar <marek.safar@gmail.com>
5925 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
5926 roottypes.cs, typemanager.cs:
5928 A member cache creation logic changed to add members immediately and
5929 not rely on fallback. The member cache is now only prefered way
5930 how to access and find type declaration members. It saves 5 MB of memory
5931 during MWF compilation and makes code ready for more optimizations and
5932 clean-ups, it's also a pre-requirement for partial methods.
5934 2007-10-18 Raja R Harinath <harinath@gmail.com>
5936 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
5937 handling for generic parameters.
5939 2007-10-15 Marek Safar <marek.safar@gmail.com>
5941 * class.cs (FixedField): Removed redundant volatile check.
5943 2007-10-15 Marek Safar <marek.safar@gmail.com>
5945 * class.cs, decl.cs: Fixed overload members verification to do only one
5946 check per possible collision.
5948 2007-10-13 Marek Safar <marek.safar@gmail.com>
5950 A fix for bug #325478
5951 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
5952 and create only one disposable flags container.
5954 2007-10-12 Marek Safar <marek.safar@gmail.com>
5956 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
5957 * statement.cs (Fixed): Fixed variables cloning.
5959 2007-10-12 Marek Safar <marek.safar@gmail.com>
5961 A fix for bug #333342
5962 * class.cs (EventField): Don't mark value type event as synchronized.
5964 2007-10-12 Marek Safar <marek.safar@gmail.com>
5966 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
5967 inference to identify best candidate method correctly.
5968 (ProperyExpr): A range variable is read only and cannot be modified.
5970 2007-10-11 Marek Safar <marek.safar@gmail.com>
5972 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
5973 logic to identify best candidate method correctly.
5975 2007-10-11 Marek Safar <marek.safar@gmail.com>
5977 * location.cs (Equals, GetHashCode): Removed.
5979 2007-10-11 Marek Safar <marek.safar@gmail.com>
5981 * report.cs: Implemented message recorder. It is used mainly for lambda
5982 expressions to capture otherwise swallowed error messages.
5984 * anonymous.cs, lambda.cs.cs: Do full parameters check.
5986 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
5988 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
5990 * expression.cs (MemberAccess): Always report lookup failure.
5992 * location.cs: Implemented Equals, GetHashCode.
5994 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
5996 2007-10-10 Jb Evain <jbevain@novell.com>
5998 * codegen.cs: re-enable assembly version check.
6000 2007-10-09 Marek Safar <marek.safar@gmail.com>
6002 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6005 * namespace.cs (UsingAlias): Do correct version check.
6007 2007-10-08 Marek Safar <marek.safar@gmail.com>
6009 * expresison.cs, ecore.cs: Issue extension method error message when
6012 * rootcontext.cs: Added ISO_2 compiler mode option.
6014 2007-10-08 Marek Safar <marek.safar@gmail.com>
6016 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6019 2007-10-08 Marek Safar <marek.safar@gmail.com>
6021 * attribute.cs (GetString, GetBoolean): Work with both literal and
6024 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6025 Moved method overload specific methods to MethodGroupExpr.
6027 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6028 it should be less memory consuming.
6030 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6032 * codegen.cs: remove the assembly version check until the buildbot is
6035 2007-10-07 Jb Evain <jbevain@novell.com>
6037 * attribute.cs (Attribute.GetString): if the value
6038 expression is a StringConstant, return its string value.
6040 2007-10-07 Jb Evain <jbevain@novell.com>
6042 * typemanager.cs: add `assembly_version_attribute_type`.
6043 * codegen.cs: on attribute emission, check that the
6044 AssemblyVersionAttribute doesn't overflow.
6046 2007-10-05 Marek Safar <marek.safar@gmail.com>
6048 A fix for bug #324677
6049 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6050 parent container of a scope container with currently resolved one.
6052 2007-10-05 Marek Safar <marek.safar@gmail.com>
6054 A fix for bug #325534
6055 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6058 2007-10-05 Marek Safar <marek.safar@gmail.com>
6060 A fix for bug #327504
6061 * class.cs (Operator.Define): Refactored implicit and explicit user
6062 operator conversion rules.
6064 2007-10-05 Marek Safar <marek.safar@gmail.com>
6066 A fix for bug #327520
6067 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6069 2007-10-04 Marek Safar <marek.safar@gmail.com>
6071 A fix for bug #328022
6072 * class.cs (MethodData.Define): Use correct method to check whether
6073 a method implementents an accessor.
6075 2007-10-04 Marek Safar <marek.safar@gmail.com>
6077 A fix for bug #330069
6078 * statement.cs (Fixed.Resolve): Read the first array element only when
6079 an array is instantiated.
6081 2007-10-04 Marek Safar <marek.safar@gmail.com>
6083 * expression.cs, assign.cs, generics.cs: Print correct operator when
6084 compound assignment is used.
6086 2007-10-04 Marek Safar <marek.safar@gmail.com>
6088 A fix for bug #325841
6089 * expression.cs (ArrayAccess): Use full argument cloning only for
6090 string compound concatenation.
6092 2007-10-03 Marek Safar <marek.safar@gmail.com>
6094 A fix for bug #328774
6095 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6097 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6100 2007-10-03 Raja R Harinath <rharinath@novell.com>
6103 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6104 Event accessibility checks here. Remove some bogus code that
6105 accidently made GenericMethods work.
6106 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6108 2007-09-25 Marek Safar <marek.safar@gmail.com>
6110 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6112 * statement.cs (Block): Refactored AddVariable to allow error handling
6115 * generic.cs: New stub.
6117 2007-09-23 Marek Safar <marek.safar@gmail.com>
6119 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6122 2007-09-17 Marek Safar <marek.safar@gmail.com>
6124 * class.cs: Use partial container to record whether any partial part
6125 contains static field initializer and therefore default contructor has
6128 2007-09-14 Marek Safar <marek.safar@gmail.com>
6130 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6131 mono-list when only one of two partial parts has defined accessibility
6134 2007-09-14 Marek Safar <marek.safar@gmail.com>
6136 A fix for bug #82845
6138 * class.cs (TypeContainer): Set correct resolve context for all field
6141 2007-09-13 Marek Safar <marek.safar@gmail.com>
6143 * assign.cs: Fixed a crash when field is resolved twice with an error.
6145 * codegen.cs: Changed InFieldInitializer to be flag.
6147 * anonymous.cs, ecore.cs, expression.cs: Update after
6148 IsInFieldInitializer rename.
6150 * const.cs: Removed unused parameter.
6152 * class.cs: Changed the way how we resolve and emit field initializers.
6153 The field initilizers have to have access to contructor block to emit
6154 compiler generated code.
6156 2007-09-13 Marek Safar <marek.safar@gmail.com>
6158 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6159 generics use TypeContainer instead.
6161 2007-09-12 Marek Safar <marek.safar@gmail.com>
6163 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6165 * lambda.cs (ResolveParameters): Use more powerful
6166 InflateGenericArgument.
6168 * parameters.cs: Better exception message.
6170 2007-09-10 Marek Safar <marek.safar@gmail.com>
6172 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6173 correct expression block type.
6175 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6177 * expression.cs (Invocation): Extracted method group resolve to
6180 2007-09-07 Marek Safar <marek.safar@gmail.com>
6182 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6183 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6185 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6186 generic extension methods.
6188 2007-09-06 Marek Safar <marek.safar@gmail.com>
6190 A fix for bug #82676 (Do I get it right now?)
6191 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6192 object before a standard conversion is applied.
6194 2007-09-06 Marek Safar <marek.safar@gmail.com>
6196 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6199 2007-09-05 Marek Safar <marek.safar@gmail.com>
6201 A fix for bug #82676
6202 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6203 non-generic interface types.
6205 2007-09-05 Marek Safar <marek.safar@gmail.com>
6207 A fix for bug #82690
6208 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6210 2007-09-05 Marek Safar <marek.safar@gmail.com>
6212 A fix for bug #82571
6213 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6214 modifier for container based methods.
6216 2007-09-05 Marek Safar <marek.safar@gmail.com>
6218 A fix for bug #82676
6219 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6220 any interface-type T means to any of interface type T.
6222 2007-09-04 Marek Safar <marek.safar@gmail.com>
6224 * namespace.cs: We have 2 versions of System.Core assembly.
6226 2007-09-04 Marek Safar <marek.safar@gmail.com>
6228 A fix for bug #82652
6229 * class.cs (Class.GetClassBases): Compare types and not expressions.
6231 2007-09-04 Marek Safar <marek.safar@gmail.com>
6233 A fix for bug #82620
6234 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6235 actually never worked before.
6236 (IndexerAccess): Emit prepared arguments before they are modified.
6238 2007-09-04 Marek Safar <marek.safar@gmail.com>
6240 A fix for bug #82563
6241 * assign.cs: Revert wrong fix.
6243 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6245 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6246 Instead of ldelema/stdind we have to use temporary variables to handle
6247 cases like String.Concat (params string[]).
6249 2007-08-31 Marek Safar <marek.safar@gmail.com>
6251 * class.cs: EmitAttributes to Emit rename.
6253 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6255 (MemberCore.HasClsCompliantAttribute): Don't depend on
6256 GetClsCompliantAttributeValue execution.
6258 2007-08-31 Marek Safar <marek.safar@gmail.com>
6260 * anonymous.cs: Use shorter type prefix.
6262 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6265 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6266 variables when probing is on.
6268 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6269 unresolved variables.
6270 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6271 handle transparent identifiers.
6273 2007-08-26 Marek Safar <marek.safar@gmail.com>
6275 * attribute.cs (IsClsCompliant): Add nullable types test.
6277 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6279 * doc.cs : catch other types of exception than XmlException to
6280 report CS1570. Fixed bug #82565.
6282 2007-08-23 Marek Safar <marek.safar@gmail.com>
6284 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6285 The number of delegate parameters has to match.
6286 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6289 2007-08-21 Marek Safar <marek.safar@gmail.com>
6291 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6292 to fix problem with private arguments.
6294 2007-08-20 Marek Safar <marek.safar@gmail.com>
6296 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6298 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6300 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6301 empty. Add cloning suport.
6303 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6305 2007-08-20 Marek Safar <marek.safar@gmail.com>
6307 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6308 to create EmptyCast. It handles EmptyConstantCast specialization for
6311 2007-08-18 Marek Safar <marek.safar@gmail.com>
6313 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6314 (EmitArrayArgument): One routine for array arguments.
6315 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6317 2007-08-17 Marek Safar <marek.safar@gmail.com>
6319 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6321 2007-08-17 Marek Safar <marek.safar@gmail.com>
6323 * anonymous.cs: MemberLookupFinal update.
6325 * class.cs (ConstructorInitializer): Is expression based.
6327 * delegate.cs: MethodGroupExpr update.
6329 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6331 (Error_MemberLookupFailed): Customizable error override.
6332 (MethodGroupExpr): Keep queried type for later usage.
6333 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6336 * expression.cs: Error_MemberLookupFailed refactoring.
6337 (New.DoResolve): Resolve as much as possible.
6338 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6339 customization for invalid member types.
6341 * statement.cs: MethodGroupExpr update.
6343 2007-08-16 Marek Safar <marek.safar@gmail.com>
6345 * modifier.cs (Check): Check all modifiers and not only accessibility
6348 2007-08-16 Marek Safar <marek.safar@gmail.com>
6350 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6351 type and not an expression.
6353 2007-08-16 Marek Safar <marek.safar@gmail.com>
6355 * statement.cs (Catch.Clone): Type and variable can be null.
6357 2007-08-16 Marek Safar <marek.safar@gmail.com>
6359 A fix for bug #81979
6360 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6361 I am really not sure whether this is the best fix.
6363 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6366 2007-08-14 Marek Safar <marek.safar@gmail.com>
6368 ** C# 3.0 Object and collection initializers (major re-write)
6370 * assign.cs (DoResolve): Initializers are not assign related.
6372 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6373 used during collection or object initialization.
6375 * expression.cs (Error_InvalidArguments): Add initializers specific
6376 messages. More will come later because it requires some general
6378 (New.DoResolve): Better error handling for unsafe types.
6379 (EmptyExpressionStatement): New class.
6380 (ElementInitializer): An object initializer expression.
6381 (CollectionElementInitializer): A collection initializer expression.
6382 (CollectionOrObjectInitializers): A block of object or collection
6384 (NewInitialize): New expression with element/object initializers.
6386 * statement.cs: Reverted object/collection initializer hacks.
6388 * typemanager.cs (CSharpName): Filter __arglist type.
6390 2007-08-09 Marek Safar <marek.safar@gmail.com>
6392 ** C# 3.0 Anonymous Types (update to the latest standard)
6394 * expression.cs (Binary.ResolveOperator): Threat all null based types
6396 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6397 (AnonymousTypeParameter): Updated.
6399 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6400 (AnonymousTypeClass): New anonymous type container.
6402 * class.cs (AddField): Return operation result.
6404 * generic.cs: Another empty TypeArguments overload.
6406 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6407 are stored at top of normal hierarchy.
6409 * typemanager.cs (CSharpName): Filter anonymous types.
6411 2007-08-09 Marek Safar <marek.safar@gmail.com>
6413 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6414 as single Concat call. How could we miss that :-(
6416 2007-08-08 Marek Safar <marek.safar@gmail.com>
6418 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6420 2007-08-07 Miguel de Icaza <miguel@novell.com>
6422 * expression.cs: Fix the previous commit, the creation of the
6423 arguments array list needs also to be conditional on the arguments
6426 * class.cs: Add a little bit of help to help narrow down problems.
6428 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6429 not try to copy in that case.
6431 * driver.cs: When building SMCS, include a new different set of
6432 default assemblies here. Do this here so we can control whether
6433 to include the default assemblies with /noconfig.
6435 2007-08-03 Marek Safar <marek.safar@gmail.com>
6437 A fix for bug #81979
6438 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6441 2007-08-03 Marek Safar <marek.safar@gmail.com>
6443 A fix for bug #82300
6445 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6446 we are in probing scope.
6448 2007-08-03 Marek Safar <marek.safar@gmail.com>
6450 A fix for bug #82301
6452 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6453 (Statement.CloneTo): Clone and not map children blocks.
6455 2007-08-03 Marek Safar <marek.safar@gmail.com>
6457 A fix for bug #82299
6459 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6462 * statement.cs (Statement.CloneTo): Clone variables before statements
6463 to allow remaping of local variables.
6465 2007-08-03 Marek Safar <marek.safar@gmail.com>
6467 A fix for bug #82296
6470 * report.cs: Log crash details for future clone problems.
6472 * statement.cs (Return.Clone): Don't clone non-existent expression.
6474 2007-08-03 Raja R Harinath <harinath@gmail.com>
6476 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6477 (Class.AddBasesForPart): Move CS0537 check here from ...
6478 * cs-parser.jay (class_declaration): ... here. Move calling of
6479 'AddBasesForPart' to ...
6480 (class_bases): ... here.
6481 (struct_declaration, interface_declaration): Update to changes.
6483 2007-08-02 Marek Safar <marek.safar@gmail.com>
6485 A fix for bug #81923
6487 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6488 conversion is allowed.
6490 2007-08-02 Marek Safar <marek.safar@gmail.com>
6492 A fix for bug #81564
6494 * ecore.cs (EventExpr): Add IsBase handling.
6496 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6499 2007-08-02 Raja R Harinath <harinath@gmail.com>
6501 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6502 * cs-parser.jay: Some whitespace cleanups.
6503 (current_delegate): New.
6505 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6506 a dummy code block, and use 'type_name' instead of 'member_name'.
6507 (interface_declaration, class_declaration): Likewise.
6508 (delegate_declaration): Likewise. Rearrange slightly and use
6510 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6511 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6513 2007-08-02 Marek Safar <marek.safar@gmail.com>
6515 A fix for bug #82039
6517 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6520 * typemanager.cs (CSharpName): Split to string overload.
6522 2007-08-02 Marek Safar <marek.safar@gmail.com>
6525 * report.cs: Updated warning CS0472.
6527 2007-08-01 Marek Safar <marek.safar@gmail.com>
6529 A fix for bug #82181
6531 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6533 2007-08-01 Marek Safar <marek.safar@gmail.com>
6535 A fix for bug #82277
6536 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6538 2007-08-01 Marek Safar <marek.safar@gmail.com>
6540 ** C# 3.0 Type Inference (major bits are working)
6542 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6543 (.ImplicitStandardConversionExists): Uses compatible.
6544 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6545 (.InferReturnType): New method.
6546 (.Compatible): Refactored.
6547 (.ResolveParameters): Uses factory to create resolved parameters.
6548 (.CompatibleMethod): Add probing mode support.
6549 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6550 clearly distinguish between 2 different operations.
6551 (LambdaMethod): Moved to lambda.cs.
6552 (AnonymousMethod): Removed unused fields and methods.
6553 (AnonymousDelegate): Simplified.
6555 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6557 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6559 * delegate.cs (Delegate): New mehods to reduce code duplication.
6560 (.GetConstructor): New method.
6561 (.GetInvokeMethod): New method.
6562 (DelegateCreation): Updated.
6564 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6566 (OverloadResolve): Made probing little bit faster.
6568 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6571 * generic.cs (TypeInferenceContext): Dummy implementation.
6573 * iterators.cs: Updated after Resolve/Define rename.
6575 * lambda.cs (LambdaExpression)
6576 (.ResolveParameters): Handles both type of arguments and type inference too.
6578 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6579 (InflateTypes): Updated.
6581 * support.cs (InflateTypes): Changed signature and updated.
6583 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6584 (MemberLookup_FindMembers): More MS tricks.
6585 (GetParameterData): Ditto.
6586 (GetDelegateParameters): Uses quick path for dynamic types.
6588 2007-08-01 Marek Safar <marek.safar@gmail.com>
6590 * class.cs (MethodData.Define): EmitContext is required for generic stuff
6593 2007-07-31 Marek Safar <marek.safar@gmail.com>
6595 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
6598 2007-07-26 Jb Evain <jbevain@novell.com>
6600 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
6601 which takes a boolean 'report_errors', similar to the GetMethod.
6602 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
6603 in .net 2.1, do not report errors here.
6605 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
6606 System.Runtime.CompilerServices.RequiredAttributeAttribute and
6607 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
6610 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
6611 of the type InternalsVisibleToAttribute before the first call
6612 to CoreLookupType which is allowed to fail (third boolean parameter
6613 to true). Because, during the resolution for a type that is not
6614 immediately found, we try to check if the type is not defined in
6615 a friend assembly, and to do so, we need the
6616 InternalVisibleToAttribute.
6618 2007-07-23 Miguel de Icaza <miguel@novell.com>
6620 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
6621 feature that allows structs to be compared against null and inline
6622 the result as true or false.
6624 Notice that the same code is not permitted inside a generic block
6625 of code that would do:
6627 class Foo<T> where T : struct {
6634 It is only allowed if the type of T is not bound (no where
6635 clause). In my opinion, this CSC 2 behavior is broken but people
6636 seem to be using it (IronRuby does, a few bug reports on bugzilla
6637 have it and some people have complained about it).
6639 All of the users that depend on this behavior have code that is
6642 * report.cs (Warning, Error): make these take object arguments,
6643 not strings, as that allows us to take advantage of Format.
6645 2007-07-20 William Holmes <billholmes54@gmail.com>
6647 * decl.cs: Changed MemberName.CountTypeArguments to also check the
6648 Left member variable for the Count.
6649 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
6650 MemberName.CountTypeArguments to avoid a NRE.
6652 This code is contributed under the MIT X11 license
6654 2007-07-18 Marek Safar <marek.safar@gmail.com>
6656 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
6658 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6660 * doc.cs : generic method arguments are written as ``x while generic
6661 type arguments are `x. Combined with the previous change, fixed bug
6664 2007-07-18 Raja R Harinath <rharinath@novell.com>
6667 * expression.cs (Binary.ResolveOperator): When converting
6668 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
6670 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6672 * doc.cs : when T: or whatever x: is specified, it does not really
6673 check the doc comment's syntax correctness. Fixed bug #82006.
6675 2007-07-18 Marek Safar <marek.safar@gmail.com>
6677 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
6678 LambdaExpression better.
6680 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
6682 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
6684 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
6685 as it can be generated.
6687 * expression.cs (Invocation.Error_InvalidArguments): Show correct
6690 * lambda.cs (LambdaExpression): Refactored to share same code with
6691 AnonymousMethodExpression.
6693 2007-07-17 Marek Safar <marek.safar@gmail.com>
6695 * anonymous.cs (MakeName): Include host name for easier debugging.
6696 (LambdaMethod): New class for lambda spcecific stuff.
6698 * attribute.cs: Set EmitContext return type.
6700 * class.cs: Set EmitContext return type.
6702 * codegen.cs (EmitContext): Return type cannot be null to stop messing
6703 with null/void meaning.
6705 * iterators.cs (ContainerType): Implemented.
6707 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
6709 * statement.cs (Return): Updated to lambda expressions.
6710 (Block.CloneTo): Parent can be null.
6712 2007-07-13 Marek Safar <marek.safar@gmail.com>
6714 A fix for bug #81917
6715 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
6717 * class.cs (FixedField): Check whether field is in unsafe scope.
6719 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
6720 (FieldExpr.Emit): Fixed buffers cannot be volatile.
6722 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
6725 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
6727 2007-07-13 Marek Safar <marek.safar@gmail.com>
6729 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
6730 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
6733 2007-07-13 Marek Safar <marek.safar@gmail.com>
6735 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
6737 2007-07-13 Marek Safar <marek.safar@gmail.com>
6739 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
6740 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
6742 * codegen.cs(EmitContext): Add ProbingMode flag.
6744 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
6746 * driver.cs: For now set both warning values.
6748 * ecore.cs (SimpleName): Name is readonly.
6749 (MethodGroup.OverloadResolve): One quick path for probing.
6751 * expression.cs (Unary): Set Oper r/o.
6752 (Binary): Set Oper r/o.
6753 (ParameterReference): Set few instance variables as r/o.
6754 (ParameterReference.DoResolveBase): Don't capture aruments when
6756 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
6757 (Arglist): arguments are private.
6758 (SizeOf): type is private and r/o.
6759 (MemberAccess): arguments are private.
6761 * report.cs: Enhanced reporting on/off capabilities.
6763 * lambda.cs: Uses ec.IsInProbingMode.
6764 (ContextualReturn): Derives from return.
6766 * rootcontext.cs: For now set both warning values.
6768 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
6770 (Return.Resolve): Don't die immediately.
6771 (Block.Resolve): Speed-up probing.
6772 (Block.CloneTo): Clone only child blocks.
6774 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
6776 * iterators.cs: reverted Miguel's latest change (r81925) as it
6777 breaks the build in System.
6779 2007-07-13 Miguel de Icaza <miguel@novell.com>
6781 * iterators.cs (Yield.CheckContext): Check for the iterator type
6782 also here as we can call into Yield even in codepaths that are not
6784 (MethodOrOperator is the only path that was checked).
6786 In addition to the standard check, use a more specific check for
6787 constructors to report a more verbose error.
6789 2007-07-12 Miguel de Icaza <miguel@novell.com>
6791 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
6792 report the warning and continue
6794 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
6795 values on the stack on the call to Emit. Use EmitStatement if
6796 possible, or using Emit + Pop if not possible. Fixes #82064
6798 2007-07-12 Raja R Harinath <rharinath@novell.com>
6800 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
6801 avoid try...finally in some cases.
6803 2007-07-10 Marek Safar <marek.safar@gmail.com>
6805 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
6807 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
6808 instead of method. Re-use standard error handling.
6809 (ConstructorInitializer.Emit): Simplified.
6811 * delegate.cs: Updated after Invocation.EmitCall change.
6813 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
6814 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
6815 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
6816 method and don't permanently changing input arguments.
6817 (MethodGroupExpr): Introduced resolved best_candidate, when method group
6818 is resolved it has one of the candidates is the best one which is later
6819 used to emit. Removed a few unused method.
6820 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
6822 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
6823 (Binary.ResolveOperator): Ditto.
6824 (ConditionalLogicalOperator.DoResolve): Ditto.
6825 (Invocation): Uses method group.
6826 (Invocation.DoResolve): Simplified.
6827 (Invocation.EmitCall): Removed useless is_static.
6828 (Invocation.Emit): Delegate to method group.
6829 (Invocation.EmitStatement): Simplified.
6830 (New): Uses method group.
6831 (MemberAccess.DoResolve): Don't destroy original expression.
6833 * statement.cs (ForEach.Resolve): Use null for no method arguments.
6835 2007-07-04 Marek Safar <marek.safar@gmail.com>
6837 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
6840 * lambda.cs: Add custom error message type.
6842 2007-07-03 Marek Safar <marek.safar@gmail.com>
6844 * lambda.cs: Simplified little bit.
6846 * parameter.cs: Introduced ImplicitLambdaParameter.
6847 (Parameters.CreateFullyResolved): New factory instead of ctor.
6851 * delegate.cs: Updated parameter creation.
6853 2007-07-03 Marek Safar <marek.safar@gmail.com>
6855 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
6858 * generic.cs: Synchronized with gmcs.
6860 2007-07-03 Marek Safar <marek.safar@gmail.com>
6862 * class.cs (Indexer): Check return type as soon as possible.
6864 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
6867 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
6869 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
6871 * parameter.cs (Parameter): Use expression type when it is available.
6873 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
6874 method modifier for the first parameter only.
6876 2007-06-24 Marek Safar <marek.safar@gmail.com>
6878 A fix for bug #81938
6879 * typemanager.cs (ChangeType): Fixed couple of char conversions.
6881 * constant.cs: Tide up an exception message.
6883 2007-06-22 Marek Safar <marek.safar@gmail.com>
6885 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
6886 an uninitialized variable is used.
6888 * expression.cs (LocalVariableReference.DoResolve): Ditto.
6890 2007-06-22 Marek Safar <marek.safar@gmail.com>
6892 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
6893 not found error handling.
6895 * expression.cs (ArrayCreation): Removed redundant fields and little bit
6897 (ArrayCreation.ResolveArrayElement): To be ready to customization.
6898 (ArrayCreation.DoResolve): Simplified.
6899 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
6900 its own resolve process.
6901 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
6903 2007-06-20 Marek Safar <marek.safar@gmail.com>
6905 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
6908 2007-06-20 Marek Safar <marek.safar@gmail.com>
6910 * cs-tokenizer.cs: Removed var related stuff.
6912 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
6913 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
6914 a type and a keyword at same time.
6916 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
6919 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
6920 implicitly typed arrays, more changes will follow.
6922 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
6924 2007-06-19 Marek Safar <marek.safar@gmail.com>
6926 * ecore.cs (VarExpr): Removed Handled field.
6928 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
6929 build-in assign functionality.
6930 (ForEach.Resolve): Removed all implicitly typed local variable code and
6932 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
6933 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
6935 2007-06-18 Marek Safar <marek.safar@gmail.com>
6937 * assign.cs: Removed implicitly typed local variable check.
6939 * expression.cs (LocalVariableReference.DoResolve): Add check for self
6940 referencing implicitly typed local variable.
6941 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
6944 * statement.cs (Fixed): Removed unsupported implicitly typed local
6947 2007-06-15 Marek Safar <marek.safar@gmail.com>
6949 * decl.cs (MemberName): Moved all Unbound stuff to parser.
6951 2007-06-14 Marek Safar <marek.safar@gmail.com>
6953 A fix for bugs #81855 and #76274
6954 * attribute.cs (AttachTo): Always set owner for global attributes to
6957 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
6960 * cs-parser.jay: Assembly and module attributes must precede all other
6961 elements except using clauses and extern alias declarations.
6963 2007-06-13 Marek Safar <marek.safar@gmail.com>
6965 A fix for bug #81748
6967 * expression.cs: More checks for non ISO-1 features.
6969 2007-06-12 Marek Safar <marek.safar@gmail.com>
6971 A fix for bug #81807
6972 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
6973 present inside switch statement and it is required by nullable check.
6975 2007-06-12 Marek Safar <marek.safar@gmail.com>
6977 A fix for bug #81840
6978 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
6979 when type matching fails.
6981 * namespace.cs: Tiny error message change.
6983 2007-06-12 Marek Safar <marek.safar@gmail.com>
6985 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
6986 reporting. Added automatic property check.
6988 * class.cs: Updated after CheckAbstractAndExtern relocation.
6989 (AEventPropertyAccessor.GetSignatureForError): Customized.
6991 2007-06-11 Marek Safar <marek.safar@gmail.com>
6993 * class.cs (DefineBaseTypes): Base type can be undefined.
6995 * ecore.cs (TypeLookup): Minor refactoring.
6996 (DoResolveAsTypeStep): Removed redundant check.
6998 * namespace.cs (Lookup): Removed redundant check.
7000 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7001 ResolveAsTypeTerminal step.
7002 (BootstrapCorlib_*): Simplified.
7003 (PopulateCoreType): Core types can be now external.
7005 2007-06-07 Marek Safar <marek.safar@gmail.com>
7007 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7009 (InferTypeArguments): Infers anonymous expression type arguments.
7010 (Compatible): Split to Compatible and InferTypeArguments.
7012 * lambda.cs: Updated.
7014 2007-06-08 Marek Safar <marek.safar@gmail.com>
7016 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7018 2007-06-07 Raja R Harinath <harinath@gmail.com>
7020 Fix #80477, cs0135-2.cs, cs0135-3.cs
7021 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7022 names to the "known" variables list.
7023 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7024 parameter names are also "known".
7025 (Block.CheckError136): Remove.
7026 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7029 2007-06-07 Marek Safar <marek.safar@gmail.com>
7031 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7033 2007-06-06 Marek Safar <marek.safar@gmail.com>
7035 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7036 internal error not an user error.
7038 * expression.cs (IsApplicable): Refactored to make debugging easier.
7040 * support.cs: More tricks for non-mono runtimes.
7042 * typemanager.cs (CoreLookupType): Made public.
7043 (InitSystemCore): All linq specific stuff moved to linq.cs
7045 2007-06-05 Marek Safar <marek.safar@gmail.com>
7047 * typemanager.cs (CSharpSignature): One more missing build-in types
7049 More tricks for non-mono runtime.
7051 2007-06-05 Raja R Harinath <harinath@gmail.com>
7053 * statement.cs (Block.CheckError136_InParents): Remove.
7054 (Block.AddVariable): Use GetParameterInfo instead.
7055 (ToplevelBlock.ProcessArguments): Likewise.
7057 2007-06-04 Raja R Harinath <rharinath@novell.com>
7059 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7061 (ToplevelBlock.GetParameterInfo): Split out of ...
7062 (ToplevelBlock.GetParameterRefernce): ... this.
7063 (ToplevelBlock.ParameterMap): Remove.
7064 * expression.cs (ParameterReference): Update to use
7065 ToplevelParameterInfo.
7067 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7070 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7071 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7073 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7074 (ToplevelBlock.ProcessParameters) ... here.
7075 (ToplevelBlock..ctor): Invoke it.
7077 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7080 * statement.cs (IKnownVariable): New interface.
7081 (LocalInfo): Implement it.
7082 (ToplevelParameterInfo): New class.
7083 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7084 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7085 GetKnownVariableInfo.
7087 2007-06-03 Raja R Harinath <harinath@gmail.com>
7089 Partly speed up CS0136 error checks.
7090 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7091 'recurse' parameter.
7092 (Block.DoCheckError136): Only check errors in parameters. Move
7093 local variable checks ...
7094 (Block.AddVariable): ... here, and ...
7095 (ToplevelBlock.ResolveMeta): ... here.
7097 2007-06-02 Raja R Harinath <harinath@gmail.com>
7099 * statement.cs (Block.IsChildOf): Remove.
7101 * statement.cs (Statement.Clone): Move special case code ...
7102 (Block.CloneTo): ... here.
7104 2007-05-29 Raja R Harinath <rharinath@novell.com>
7106 * statement.cs (ToplevelBlock.container): Remove field. It's
7107 redundant with 'Parent'.
7108 (ToplevelBlock.ContainerBlock): Remove accessor.
7109 (ToplevelBlock..ctor): Update to changes. Register anonymous
7110 child with parent here, ...
7111 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7113 (start_anonymous): Don't save current_block.
7114 (top_current_block): Remove.
7116 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7117 (Block.Resolve): Update to changes.
7118 (Block..ctor): Move setting of "correct" 'Toplevel'
7119 and 'Explicit' fields to ...
7120 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7122 2007-05-27 Raja R Harinath <harinath@gmail.com>
7125 * statement.cs (Block.Implicit): Remove.
7126 (Block): Update to changes.
7127 * flowanalysis.cs: Likewise.
7129 Mildly speed up CheckInvariantMeaningInBlock
7130 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7131 Recursively call AddKnownVariable to all enclosing blocks.
7132 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7133 Remove recursive calls.
7134 (Block): Update to changes.
7136 New ExplicitBlock invariants
7137 * statement.cs (Block.Explicit): New field. It points to the
7138 immediately enclosing non-implicit block.
7139 (Block..ctor): Maintain the invariant.
7140 * cs-parser.jay: Take advantage of invariant.
7142 Introduce ExplicitBlock
7143 * statement.cs (ExplicitBlock): New.
7144 (ToplevelBlock): Derive from it.
7145 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7147 (Block.Implicit): Update to changes.
7148 * cs-parser.jay: Update to changes.
7151 * codegen.cs (EmitContext.IsLastStatement): Remove.
7152 * statement.cs (Block.DoEmit): Update to changes.
7154 2007-05-25 Raja R Harinath <rharinath@novell.com>
7156 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7157 modifying current_block directly.
7159 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7161 * class.cs: Implemented automatic properties (C# 3.0)
7162 Thanks to Marek for the help.
7164 2007-05-23 Raja R Harinath <rharinath@novell.com>
7166 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7167 variable as assigned, note also that all its components are
7169 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7171 2007-05-19 Marek Safar <marek.safar@gmail.com>
7173 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7174 member is marked as compiler generated.
7176 * decl.cs (MemberCore): Refactored ModFlags into property.
7178 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7179 (Check): Check only accessibility modifiers.
7181 2007-05-18 Raja R Harinath <rharinath@novell.com>
7183 Track all assignable slots in one bit array
7184 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7185 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7186 logic from VariableMap constructor here. Use the same 'offset'
7187 variable that's later used for computing offsets of local
7189 * flowanalysis.cs (UsageVector.parameters): Remove.
7190 (UsageVector): Update to changes.
7191 (VariableMap): Remove.
7193 Avoid creating ParameterMap in every block
7194 * statement.cs (Block.ParameterMap): Move ...
7195 (ToplevelBlock.ParameterMap): ... here.
7196 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7198 * flowanalysis.cs (FlowBranching.param_map): Remove.
7199 (FlowBranching.UsageVector): Update to changes.
7200 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7202 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7204 * expression.cs (ParameterReference): Distinguish between block
7205 where parameter was referenced and declared.
7207 2007-05-18 Marek Safar <marek.safar@gmail.com>
7209 * flowanalysis.cs, statement.cs: Put back improved error handling.
7211 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7215 Imporved object and collection initialization (C# 3.0).
7217 2007-05-15 Marek Safar <marek.safar@gmail.com>
7219 A fix for bug #81380
7220 * expression.cs (Is.DoResolve): Only value types have constant `is'
7223 2007-05-15 Raja R Harinath <rharinath@novell.com>
7225 * statement.cs (ToplevelBlock.child): Remove.
7227 2007-05-15 Raja R Harinath <harinath@gmail.com>
7229 Rationalize ResolveMeta: refactoring
7230 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7231 out constant handling code into ...
7232 (Block.DoResolveConstants): ... this.
7234 Rationalize ResolveMeta: kill local_map
7235 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7236 (Block.AssignableSlots): New.
7237 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7238 for locals -- move code from VariableMap here. Avoid unnecessary
7240 * flowanalysis.cs (FlowBranching.local_map): Remove.
7241 (FlowBranching..ctor): Use Block.AssignableSlots.
7242 (VariableMap): Remove unused constructors.
7244 2007-05-11 Raja R Harinath <rharinath@novell.com>
7246 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7248 2007-05-11 Marek Safar <marek.safar@gmail.com>
7250 * typemanager.cs (IsFriendAssembly): Should not be called for building
7253 2007-05-09 Marek Safar <marek.safar@gmail.com>
7255 * literal.cs (NullConstant): Print null in all cases.
7257 * expression.cs (Binary.ResolveOperator): Implemented delegate
7258 comparison based on C# 2.0 changes.
7260 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7262 This code is contributed under the MIT X11 license
7264 The following enables support for several C# 3.0 language features:
7266 * cs-tokenizer.cs: Added support for the "var" keyword.
7268 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7269 Added VarExpr class to facilitate type inferencing.
7271 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7272 to support anonymous types.
7274 * assign.cs: Added support for type inferencing and initialization.
7276 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7278 * expression.cs: Added implicit array support to ArrayCreation.
7279 Added 5 types and 1 interface:
7281 IInitializable Implementing classes can inject initializing
7282 statements after object instantiation.
7284 Initializer Stores data for object initialization.
7286 AnonymousType An expression for anonymous types.
7288 AnonymousTypeParameter Stores data about an anonymous type's field.
7290 NewInitialize An expression for object initialization.
7292 CollectionInitialize An expression for collection initialization.
7294 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7297 2007-05-06 Marek Safar <marek.safar@gmail.com>
7299 A fix for bug #81500
7300 * cs-tokenizer.cs: Add special handling for coalescing operator.
7302 2007-05-06 Marek Safar <marek.safar@gmail.com>
7304 A fix for bug #81529
7305 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7306 its value from base class until it is redefined.
7308 2007-05-02 Raja R Harinath <rharinath@novell.com>
7310 Fix regression in cs0631-3.cs
7311 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7312 fallback. Make error fallback catch more cases.
7314 2007-05-01 Miguel de Icaza <miguel@novell.com>
7316 * cs-parser.jay: Allow parameters in operator declarations to have
7319 2007-04-27 Miguel de Icaza <miguel@novell.com>
7321 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7324 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7325 inside the ContextualReturn, it does not have to be an
7326 ExpressionStatement.
7328 2007-04-24 Miguel de Icaza <miguel@novell.com>
7330 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7333 2007-04-23 Miguel de Icaza <miguel@novell.com>
7335 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7336 method in two methods: ResolveNoDefine and Resolve.
7338 ResolveNoDefine will stop just after ResolveTopBlock has been
7341 Resolve will then continue by creating a method and issuing the
7342 call to method.Define ().
7344 (AnonymousMethod): Split and implement the new Resolve and
7345 ResolveNoDefine as well.
7347 * lambda.cs (LambdaExpression): Split the anonymous method
7348 resolution code into a separate routine (CoreCompatibilityTest)
7349 from DoCompatibleTest.
7351 (LambdaExpression.TryBuild): New method, this method tries to
7352 build the LambdaExpression with the given set of types to be used
7353 as the types for the various parameters of the lambda expression.
7355 If the compilation succeed with the given types, the infered type
7356 of the Anonymous method is returned, otherwise null is returned.
7358 2007-04-23 Marek Safar <marek.safar@gmail.com>
7360 A fix for bug #81414
7361 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7363 2007-04-22 Miguel de Icaza <miguel@novell.com>
7365 * cs-tokenizer.cs: Change various identifiers here from the
7366 camelCasing to the recommended Linux-like style for instance
7367 variables from the Coding Guidelines.
7369 2007-04-19 Martin Baulig <martin@ximian.com>
7372 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7373 System.Enum to System.ValueType.
7375 2007-04-13 Martin Baulig <martin@ximian.com>
7377 Rewrote implicit reference conversions. We need to distinguish
7378 between implicit reference conversions (13.1.4) and implicit
7379 boxing conversions (13.1.5).
7381 According to the spec, there's an an implicit conversion
7382 "From a one-dimensional array-type S[] to IList<T> and base
7383 interfaces of this interface, provided there is an implicit
7384 reference conversion from S to T." Note that this does not
7385 include boxing conversions.
7388 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7389 (Convert.ImplicitReferenceConversion): Split into
7390 ImplicitReferenceConversionCore() and
7391 ImplicitBoxingConversionExist().
7392 (Convert.ImplicitReferenceConversionExists): Use the new
7393 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7395 2007-04-12 Martin Baulig <martin@ximian.com>
7397 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7398 `TypeManager.null_type' checks up to the top of the method.
7400 2007-04-11 Marek Safar <marek.safar@gmail.com>
7402 A fix for bug #81350
7403 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7406 2007-04-11 Martin Baulig <martin@ximian.com>
7408 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7409 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7410 to make this work for generic classes; fixes #79561.
7412 2007-04-11 Martin Baulig <martin@ximian.com>
7414 * expression.cs (As): Add support for nullable types; fixes #79371.
7416 2007-04-11 Martin Baulig <martin@ximian.com>
7418 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7419 `type.FullName' is null; fixes #80243.
7421 2007-04-11 Martin Baulig <martin@ximian.com>
7423 * expression.cs (Invocation.IsApplicable): Don't modify the method
7424 if type inference succeeded, but the method was not applicable.
7427 2007-04-10 Marek Safar <marek.safar@gmail.com>
7429 A fix for bug #81324
7430 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7431 internal and external namespaces containers.
7433 2007-04-10 Martin Baulig <martin@ximian.com>
7435 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7436 TypeManager.DropGenericMethodArguments() so we also call
7437 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7439 2007-04-10 Martin Baulig <martin@ximian.com>
7441 * iterators.cs (Iterator.CreateIterator): Don't crash if
7442 `method.ReturnType' is null. This happens if something went wrong
7443 while resolving that typ (we already reported an error in this case).
7445 2007-04-10 Martin Baulig <martin@ximian.com>
7447 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7448 generic interfaces; report the CS0144 directly.
7450 2007-04-10 Martin Baulig <martin@ximian.com>
7452 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7453 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7455 2007-04-10 Martin Baulig <martin@ximian.com>
7457 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7459 2007-04-09 Raja R Harinath <rharinath@novell.com>
7462 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7463 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7466 * statement.cs (For.Resolve): If resolution fails, use
7469 2007-04-08 Marek Safar <marek.safar@gmail.com>
7471 * anonymous.cs (MakeName): Make faster and zero-based.
7472 (VerifyExplicitParameterCompatibility): Back to mode where generic
7473 parameter is ignored.
7474 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7476 * class.cs (EmitType): Method can emit another new method.
7478 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7480 * driver.cs: Updated.
7482 * lambda.cs: Reuse predefined empty parameters.
7484 * parameter.cs: Updated
7486 * support.cs: Implemented InflateTypes.
7488 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7489 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7491 2007-04-03 Martin Baulig <martin@ximian.com>
7495 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7496 version of TypeManager.IsOverride() which also works with generic
7499 2007-04-03 Martin Baulig <martin@ximian.com>
7504 (Convert.ExplicitReferenceConversion): We need to cast when
7505 converting from IList<T> to S[].
7507 2007-04-01 Marek Safar <marek.safar@gmail.com>
7509 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7512 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7514 2007-03-31 Marek Safar <marek.safar@gmail.com>
7516 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7517 argument and return type inferring.
7519 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7520 (ReturnType): Turned to property.
7522 * statement.cs (Return): Implemented return type inferring.
7524 * support.cs (ReflectionParameters): Use local types if possible.
7526 2007-03-30 Raja R Harinath <rharinath@novell.com>
7528 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7529 (FlowBranching.UsageVector): Update to changes.
7531 Prepare to kill 'Reachability'
7532 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7533 argument of constructor.
7535 2007-03-29 Raja R Harinath <rharinath@novell.com>
7537 Prepare to kill 'Reachability'
7538 * flowanalysis.cs (UsageVector.is_unreachable): New.
7539 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7540 'reachability', and verify they're consistent.
7543 * expression.cs (New.EmitStatement): Handle type parameters here too.
7545 2007-03-29 Martin Baulig <martin@ximian.com>
7550 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7551 CompilerGeneratedClass.
7552 (ScopeInfo.EmitScopeInstance): Make this protected.
7553 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7554 `ec.CurrentAnonymousMethod.Scope == Scope'.
7556 * statement.cs (Block.ScopeInfo): Make this a property.
7558 2007-03-27 Raja R Harinath <harinath@gmail.com>
7560 Prepare to kill 'Reachability'
7561 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7562 (FlowBranching.UsageVector.Reachability): Remove property.
7563 (FlowBranching.UsageVector.IsUnreachable): New property.
7564 (FlowBranching.UsageVector.ResetBarrier): New.
7565 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7566 * codegen.cs, statement.cs: Update to changes.
7568 2007-03-27 Martin Baulig <martin@ximian.com>
7573 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7576 2007-03-26 Raja R Harinath <rharinath@novell.com>
7578 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7579 instead of TriState. Remove all mention of TriState.
7581 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7582 replaced by a boolean. Add boolean 'is_unreachable' field, check
7583 and maintain invariants.
7585 2007-03-25 Marek Safar <marek.safar@gmail.com>
7587 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
7589 2007-03-25 Marek Safar <marek.safar@gmail.com>
7591 * expression.cs: Stop using obsolete 2.0 opcodes.
7593 2007-03-25 Marek Safar <marek.safar@gmail.com>
7595 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
7596 one of the latests Martin's fixes.
7598 2007-03-23 Miguel de Icaza <miguel@novell.com>
7600 * expression.cs: On BigEndian systems, swap the bytes, temporary
7601 solution until we get a new bitconverter class.
7603 2007-03-23 Martin Baulig <martin@ximian.com>
7607 * decl.cs (MemberCache.AddMembers): Add generic methods both as
7608 "Method" and "Method`1". Normally, a cache lookup is done on the
7609 "Method" form (ie. without the generic arity), but this one makes
7610 lookups on the full form work as well.
7612 2007-03-22 Raja R Harinath <rharinath@novell.com>
7614 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
7617 2007-03-20 Bill Holmes <billholmes54@gmail.com>
7619 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
7620 ordered_member_list, to TypeBuilder to store members to be defined
7621 in the order they were parsed in.
7622 - ordered_explicit_member_list contains all properties indexers
7623 and methods that are defined as explicit implementation of an
7624 interface or base class.
7625 - ordered_member_list contains all properties indexers and methods
7626 that are not defined as explicit implementation of an interface
7629 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
7630 functionality in these removed classes has been replaced with
7631 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
7632 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
7634 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
7635 to CheckForDuplications inside GetMethod and SetMethod Define Method
7636 to handle method property and indexer name conflicts.
7640 All code is contributed under the MIT/X11 license.
7642 2007-03-20 Martin Baulig <martin@ximian.com>
7644 * class.cs (TypeContainer.Interfaces): Removed; they're now
7645 included in `TypeContainer.Types'.
7647 2007-03-20 Martin Baulig <martin@ximian.com>
7649 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
7651 * class.cs (TypeContainer.CreateType): New public method. This is
7652 now called before DefineType() to create the TypeBuilders.
7653 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
7654 has already been created by CreateType().
7655 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
7656 don't resolve our base classes here; this has been moved into
7657 DefineBaseTypes(). We're now called from CreateType().
7658 (TypeContainer.DefineBaseTypes): New private method; resolve our
7659 base classes here. We're now called from DefineType().
7662 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
7663 our types first to create all the TypeBuilders. After that, call
7664 TypeContainer.DefineType() on all the types which'll resolve their
7665 base classes and setup the resolve order.
7667 2007-03-20 Martin Baulig <martin@ximian.com>
7669 * class.cs (TypeContainer.Enums): Removed; they're now included in
7670 `TypeContainer.Types'.
7672 2007-03-20 Martin Baulig <martin@ximian.com>
7675 (TypeContainer.DefineType): Don't call ResolveMembers() here.
7676 (TypeContainer.DoResolveMembers): Call DefineType() on our
7677 `compiler_generated' classes; moved here from DefineNestedTypes().
7680 (RootContext.ResolveTree): Call ResolveMembers() on all
7681 TypeContainer's in the `type_container_resolve_order'.
7683 2007-03-19 Marek Safar <marek.safar@gmail.com>
7685 * class.cs: Use corlib to handle InternalMethodImplAttribute.
7687 2007-03-17 Marek Safar <marek.safar@gmail.com>
7689 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
7690 implementation flags.
7692 2007-03-17 Marek Safar <marek.safar@gmail.com>
7694 * class.cs: More optimizations for type parameters.
7696 2007-03-15 Marek Safar <marek.safar@gmail.com>
7698 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
7700 * ecore.cs, parameter.cs: More common code for both corlibs.
7702 * typemanager.cs (IsGenericMethod): Simplified.
7704 2007-03-15 Raja R Harinath <rharinath@novell.com>
7706 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7708 * statement.cs, iterators.cs, lambda.cs: Update to changes.
7710 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
7711 unconditionally. Simplify explanation.
7712 (Try.Resolve, Using.Resolve): Likewise.
7714 2007-03-15 Martin Baulig <martin@ximian.com>
7718 * decl.cs (DeclSpace): If we're a partial class, use our
7719 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
7721 2007-03-15 Raja R Harinath <rharinath@novell.com>
7723 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7725 (FlowBranching.UsageVector): Update to changes.
7726 (FlowBranching.MergeSiblings): Likewise.
7727 * statement.cs: Likewise.
7729 2007-03-15 Martin Baulig <martin@ximian.com>
7734 (MemberCache): Added a special .ctor for type parameters.
7737 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
7740 2007-03-09 Martin Baulig <martin@ximian.com>
7742 * enum.cs (Enum): Make this a TypeContainer.
7743 (EnumMember): Derive from `Const'.
7746 (Const.DoResolveValue): New protected virtual method; move most of
7747 the functionality of ResolveValue() here so we can override it in
7749 (Const.CreateConstantReference): Make this virtual.
7751 * class.cs (Kind): Add `Kind.Enum'.
7752 (TypeContainer.Emit): Don't emit the enums here; they're already
7753 in the `RootContext.typecontainer_resolve_order'.
7755 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
7756 here; they're already in the `typecontainer_resolve_order'.
7758 * ecore.cs (EnumConstant.ConvertImplicitly): Add
7759 TypeManager.DropGenericTypeArguments().
7762 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
7763 (TypeManager.IsEnumType): Likewise.
7764 (TypeManager.EnumToUnderlying): Likewise.
7765 (TypeManager.IsEqual): Add support for enums.
7767 2007-03-12 Raja R Harinath <rharinath@novell.com>
7769 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
7770 DefaultParameterValueAttribute to be undefined, say if System.dll
7773 2007-03-11 Marek Safar <marek.safar@gmail.com>
7775 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
7778 2007-03-10 Marek Safar <marek.safar@gmail.com>
7780 * class.cs, parameter.cs: Unified parameters verification.
7782 2007-03-08 Martin Baulig <martin@ximian.com>
7784 * cs-parser.jay (constructor_header): Pass the location to the
7785 newly created TopLevelBlock.
7787 2007-03-07 Martin Baulig <martin@ximian.com>
7789 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
7791 2007-03-06 Miguel de Icaza <miguel@novell.com>
7793 * convert.cs (ExplicitReferenceConversionExists): Sync this method
7794 with the changes from David, fixes the build.
7796 2007-03-05 David Mitchell <dmitchell@logos.com>
7798 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
7799 and its base interfaces to a one-dimensional array type S[],
7800 provided there is an implicit or explicit reference conversion
7803 2007-03-03 Marek Safar <marek.safar@gmail.com>
7805 * cs-tokenizer.cs: Implemented basic linq grammar.
7807 * driver.cs: Set linq lang version on demand.
7809 2007-02-26 Marek Safar <marek.safar@gmail.com>
7811 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
7813 2007-02-25 Marek Safar <marek.safar@gmail.com>
7815 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
7818 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
7820 Check property and event extern attributes.
7822 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
7825 2007-02-24 Marek Safar <marek.safar@gmail.com>
7827 A fix for bug #80407
7828 * ecore.cs: Don't report ambiguity error when methods have same parent.
7830 2007-02-23 Marek Safar <marek.safar@gmail.com>
7832 A fix for bug #80878
7833 * class.cs, cs-parser.jay: Event property can host anonymous methods.
7835 2007-02-22 Marek Safar <marek.safar@gmail.com>
7837 * attribute.cs: Enable ExtensionAttribute presence test.
7839 2007-02-22 Marek Safar <marek.safar@gmail.com>
7841 * class.cs: Warn about missing GetHashCode only when Equals is override.
7843 * decl.cs: Check accessibility of type arguments.
7845 * typemanager.cs: Correctly report nullable array.
7847 2007-02-20 Marek Safar <marek.safar@gmail.com>
7849 * class.cs, report.cs: Capture more details when things go wrong.
7851 2007-02-20 Marek Safar <marek.safar@gmail.com>
7853 A fix for bug #80650
7854 * cs-parser.jay: Anonymous container starts at constructor declaration
7855 and not at block beginning because it has to be usable in constructor
7858 * statement.cs: Use context location and not block one for error reporting.
7860 2007-02-18 Marek Safar <marek.safar@gmail.com>
7862 A fix for bug #78712
7863 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
7866 2007-02-18 Marek Safar <marek.safar@gmail.com>
7868 A fix for bug #80493 by Atsushi Enomoto
7869 * cs-parser.jay: Ignore invalid attribute target.
7871 2007-02-18 Marek Safar <marek.safar@gmail.com>
7873 * cs-tokenizer.cs: Ignore '\0' as white space character.
7875 2007-02-17 Miguel de Icaza <miguel@novell.com>
7877 * cs-parser.jay: Add support for lambda expressions to the mcs
7880 * lambda.cs: Only clone when we are probing, not on the final call
7881 (Compatible is the final call).
7883 * statement.cs (CloneContext): Introduce class to provide block
7884 remapping during clone.
7886 All statements Clone themselves now.
7888 (Clone): special handling for blocks, when we clone a block, we
7889 register the block inside this routine, as children of the block
7890 might trigger a lookup.
7892 * expression.cs: Add support for CloneContext in all expressions.
7894 2007-02-17 Marek Safar <marek.safar@gmail.com>
7896 A fix for bug #80493
7897 * statement.cs: Report ambiguous warning when interfaces are not related.
7899 2007-02-15 Marek Safar <marek.safar@gmail.com>
7901 C# 3.0 extension methods.
7903 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
7904 cannot be used directly.
7906 * class.cs (Class.Emit): Emit extension attribute if any class method
7907 is extension method.
7908 (Method.Define): Add basic extension method validation conditions.
7909 (Method.Emit): Emit extension attribute for method.
7911 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
7912 extension method exists. Currently we follow same approach as Microsoft
7913 does, emit even if a method or a class are private but this can change
7916 * cs-parser.jay: Add handling of `this' keyword in method parameters
7919 * decl.cs (DeclSpace.IsStaticClass): New property.
7920 (MemberCache.FindExtensionMethods): Looks for extension methods with
7921 defined name and extension type.
7923 * doc.cs: Updated after OverloadResolve changes.
7925 * driver.cs: Add new soft reference to System.Core.dll.
7927 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
7928 (ExtensionMethodGroupExpr): Represents group of extension methods.
7930 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
7931 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
7932 to MethodGroupExpr and made non-static for easier customization.
7933 (Invocation.DoResolve): Add extension method lookup when no standard
7935 (MemberAccess.DoResolve): Try extension methods if no member exists.
7937 * modifiers.cs: Add METHOD_EXTENSION modifier.
7939 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
7940 as well as candidate extension type.
7941 (ComputeNamespaces): When assembly constains extension methods registers
7943 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
7944 extension method lookup.
7945 (Namespace.LookupExtensionMethod): Looks for extension method in this
7947 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
7948 find a method which matches name and extensionType.
7950 * parameter.cs (Parameter): Add This modifer.
7951 (HasExtensionMethodModifier): New property.
7952 (Resolve): Add extension parameter check.
7953 (ModFlags): turned to property to exclude this modifier as it is not real
7955 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
7957 * support.cs (ParameterData): Add ExtensionMethodType.
7958 (ReflectionParameters): Implemented ExtensionMethodType interface property.
7960 * typemanager.cs: Add type and ctor extension attribute type.
7962 2007-02-15 Miguel de Icaza <miguel@novell.com>
7964 * report.cs (DisableErrors, EnableErrors): used to prevent error
7965 output when we are "trying" to compile various methods with
7968 * ecore.cs (Expression): Add Clone method that calls the virtual
7969 CloneTo method. The current CloneTo method in Expression throws
7970 an exception so we can track down all the places where this must
7971 be implemented (not using abstract, because that would be a lot of
7972 up-front-work before we can start testing the implementation
7975 Important: we only need Clone capabilities for expressions created
7976 by the parser, as the expressions we will be cloning are
7977 expressions in the pre-resolved state. This vastly simplifies
7980 (SimpleName): Add CloneTo that does nothing.
7981 (EmptyCast): Add CloneTo.
7983 * expression.cs (Binary): Implement CloneTo.
7984 (Invocation.IsApplicable): Store the current ec in
7985 EmitContext.TempEc and restore it on return. This is used so we
7986 do not have to sprinkle hundres of methods with an extra
7987 EmitContext, we know that the only user is the lambda expression
7988 ImplicitConversionExists code.
7990 (Argument): Add Cloning capabilities.
7991 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
7992 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
7993 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
7994 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
7995 IndexerAccess): Add Clone capability.
7997 (LocalVariableReference, This): TODO: needs cloned Block mapping.
7999 (Argument): Add cloning capability.
8001 * assign.cs (Assign): Implement CloneTo.
8003 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8005 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8006 version by calling Convert with the EmitContext (that we are
8007 currently storing in ec, this is not great, but will do for now,
8008 to avoid passing EmitContext parameters to hundreds of functions
8009 that do not need them now).
8011 (SetExpression): Remove, it is not needed.
8013 (ContextualReturn): Implement CloneTo.
8015 * statement.cs (Statement): Implement cloning infrastructure,
8016 similar to expressions.
8018 (Block): Partial implementation of Clone for statements.
8020 (Return): Implement clone.
8022 * constant.cs (Constant.CloneTo): New method, does nothing.
8024 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8025 solution, until we decide how to exactly do this.
8027 2007-02-14 Marek Safar <marek.safar@gmail.com>
8029 A fix for bug #80493
8030 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8031 a property is override we need to use second accessor.
8033 2007-02-13 Marek Safar <marek.safar@gmail.com>
8035 A fix for bug #80418
8036 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8039 2007-02-13 Marek Safar <marek.safar@gmail.com>
8041 Another fix for bug #80749
8042 * pending.cs: Abstract class has priority over interfaces.
8044 2007-02-13 Marek Safar <marek.safar@gmail.com>
8046 Another fix for bug #80749
8047 * pending.cs: Abstract class has priority over interfaces.
8049 2007-02-13 Marek Safar <marek.safar@gmail.com>
8051 Another fix for bug #80749
8052 * pending.cs: Abstract class has priority over interfaces.
8054 2007-02-13 Marek Safar <marek.safar@gmail.com>
8056 Another fix for bug #80749
8057 * pending.cs: Abstract class has priority over interfaces.
8059 2007-02-13 Marek Safar <marek.safar@gmail.com>
8061 * class.cs Better error message.
8063 * driver.cs: Add shorter versions of -optimize option.
8065 2007-02-13 Martin Baulig <martin@ximian.com>
8067 * class.cs (Constructor.Emit): Check the return value of
8068 ec.ResolveTopBlock() and return on error.
8070 2007-02-13 Raja R Harinath <rharinath@novell.com>
8072 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8073 message to fix error message regression.
8075 2007-02-12 Marek Safar <marek.safar@gmail.com>
8077 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8079 2007-02-12 Marek Safar <marek.safar@gmail.com>
8081 A fix for bug #80749
8082 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8083 its parent container.
8085 * class.cs (DefineFieldInitializers): Each initializer can has different
8088 * const.cs: Updated.
8090 2007-02-11 Miguel de Icaza <miguel@novell.com>
8092 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8093 now all the heavy lifting to check that embedded statements or
8094 expressions have the right form is done in the ContextualReturn.
8096 (ContextualReturn): New class.
8098 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8099 method that can be invoked to report 201, so we do not replicate
8102 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8104 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8105 treating tabs as spaces.
8107 2007-02-09 Marek Safar <marek.safar@gmail.com>
8109 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8110 * assign.cs: Use full implicit conversion for right side check.
8112 2007-02-09 Marek Safar <marek.safar@gmail.com>
8114 * statement.cs (Switch): Switch over boolean type is not standardized.
8116 2007-02-08 Marek Safar <marek.safar@gmail.com>
8118 A fix for bug #80755
8119 * decl.cs (FindBaseEvent): Don't use method cache for events.
8121 2007-02-07 Marek Safar <marek.safar@gmail.com>
8123 * cs-parser.jay: Better syntax error handling.
8125 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8126 instead of underlying type value.
8128 2007-02-06 Marek Safar <marek.safar@gmail.com>
8130 * driver.cs: Check define identifier before is registered.
8132 * namespace.cs: Use existing error message.
8134 * report.cs: New warning.
8136 2007-02-06 Marek Safar <marek.safar@gmail.com>
8138 A fix for bug #80742
8139 * expression.cs: Delegate Invoke method can be called directly.
8141 2007-02-06 Marek Safar <marek.safar@gmail.com>
8143 A fix for bug #80676
8144 * class.cs (IsEntryPoint): The Main method can have params modifier.
8146 2007-02-04 Miguel de Icaza <miguel@novell.com>
8148 * parameter.cs (Parameter, Parameters): Add Clone method.
8150 * anonymous.cs (Compatible): Turn method into virtual method, so
8151 LambdaExpression can implement a different behavior.
8153 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8154 out the basic checking here, so it can be used by
8157 * lambda.cs: Introduce "Compatible" function that will do the
8160 2007-02-02 Marek Safar <marek.safar@gmail.com>
8162 * attribute.cs: Unified one error message.
8164 * class.cs (Class): Use type attributes and not properties to test static
8166 (IsEntryPoint): Don's pass local variable.
8168 * convert.cs: Removed duplicate check.
8170 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8172 * driver.cs: Don't crash when soft reference does not exist.
8174 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8175 (UsingEntry): Removed redundant allocation.
8177 * parameter.cs: Add fast path for type parameters.
8179 * support.cs: Don't allocate attribute when it's not used.
8181 2007-01-30 Miguel de Icaza <miguel@novell.com>
8184 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8185 this into a virtual method, so we can override it in LambdaExpression.
8187 * driver.cs: Improve diagnostics in case of failure.
8189 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8190 write a function that is slightly more complex and that parses:
8192 type identifier [, type identifier]* )
8194 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8197 (canEmpty ? i >= 0 : i > 0)
8199 2007-01-30 Raja R Harinath <rharinath@novell.com>
8201 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8202 exception on possibly valid code.
8204 2007-01-29 Raja R Harinath <rharinath@novell.com>
8206 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8208 (parse_opt_type_arguments): Remove. It's almost the same as
8210 (parse_namespace_or_typename): Use parse_less_than.
8212 2007-01-28 Miguel de Icaza <miguel@novell.com>
8214 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8215 this bug took a few hours to find, because the state saved and
8216 restored by PushPosition and PopPosition was ignoring the state of
8217 parse_generic_less_than.
8219 I can also now remove the handling of OP_LT and OP_GT, this solves
8222 * cs-tokenizer.cs: store the location for the ARROW token, we use
8225 (PushPosition, PopPosition): save/restore also `current_token',
8226 restore `parse_generic_less_than' (was missing).
8228 (parse_opt_type_arguments): use parse_type, not
8229 parse_namespace_or_typename to parse types.
8231 * lambda.cs: Empty new file, will eventually have the lambda
8232 expression implementation.
8234 * lambda.test: used to test the internal tokenizer.
8236 * report.cs (FeatureIsNotISO1): Rename from
8237 FeatureIsNotStandardized, because it was about the language level
8238 (1 vs 2) it was not about standarization.
8240 (FeatureRequiresLINQ): New.
8242 * support.cs (SeekableStreamReader): Only require that the reader
8243 is a TextReader, not a StreamReader, so we can plug StringReader.
8245 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8246 given position in the input stream the following tokens can be
8247 parsed as a type followed by an identifier.
8249 (is_punct): after a '(' if parse_type_and_parameter returns true,
8250 then return a special token OPEN_PARENS_LAMBDA which is used to
8251 avoid reduce/reduce errors in the grammar for the
8252 lambda_expression rules.
8254 (parse_type): implement a type parser inside the
8255 tokenizer, the parser only returns true or false depending on
8256 whether the input at a given position can be parsed as a type.
8258 (peek_token): new method used during type parsing.
8260 2007-01-28 Raja R Harinath <rharinath@novell.com>
8263 * anonymous.cs (ScopeInfo.InflateParameters): New.
8264 (AnonymousContainer.Resolve): Use it to redirect types of
8265 delegate parameters.
8267 2007-01-27 Raja R Harinath <rharinath@novell.com>
8270 * expression.cs (Error_InvalidArguments): Don't use two different
8271 messages for CS1503. Use ExtraInformation and
8272 SymbolRelatedToPreviousError instead.
8275 * decl.cs (DeclSpace.initialize_type_params): Don't access
8276 'type_params' of a partial class directly.
8278 2007-01-26 Miguel de Icaza <miguel@novell.com>
8280 * constant.cs: Removed a handful of out-of-range checks that were
8283 2007-01-25 Marek Safar <marek.safar@gmail.com>
8285 * expression.cs (CheckUselessComparison): Add additional check for char
8288 * namespace.cs: Fixed typo.
8290 2007-01-23 Miguel de Icaza <miguel@novell.com>
8292 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8293 gone, instead we inline the test, preventing the needless casts to
8294 longs, ulongs and doubles for the parameters, avoiding calls to
8295 methods that overchecked stuff, and instead inlined things
8298 2007-01-20 Marek Safar <marek.safar@gmail.com>
8300 * cs-parser.jay: Better parameter error handling.
8302 2007-01-17 Marek Safar <marek.safar@gmail.com>
8304 A fix for bug #80368, #80522
8305 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8306 whether array initializer contains constants only.
8307 (ArrayCreation.Emit): Use better formula to decide when
8308 are array initializers for static initialization.
8309 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8310 have to emit even constants otherwise they are pre-initialized.
8312 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8313 Raja R Harinath <rharinath@novell.com>
8315 Fix emit order of 'get' vs. 'set'.
8316 * support.cs (Accessors): New.
8317 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8318 Note the order in which accessors are declared in the source.
8319 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8320 Refactored from Property.Define and Indexer.Define.
8321 (PropertyBase.DefineAccessors): New helper that calls the above in
8322 appropriate order as noted by the parser.
8323 (Property.Define, Indexer.Define): Update to changes.
8324 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8326 2007-01-17 Raja R Harinath <rharinath@novell.com>
8328 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8329 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8330 there's an implicit conversion from the current type to the target
8331 type before converting the underlying constant.
8333 2007-01-16 Marek Safar <marek.safar@gmail.com>
8335 * const.cs (ResolveValue): Updated after constant conversion was made more
8338 * constant.cs (GetAttributableValue): constant to object conversion is
8339 used for attributes only.
8340 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8341 constant conversions.
8342 (LongConstant.ConvertImplicitly): Ditto.
8344 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8345 (ImplicitConversionStandard): Handle constant conversion as extra step.
8346 It solves the issue when constant conversion was called indirectly like
8347 inside array initializer and constant folding was skipped.
8349 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8352 * statement.cs(ImplicitConversionStandard): Updated after constant
8353 conversion was made more generic.
8355 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8357 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8358 Constraints, solves the problem where the compiler incorrectly
8359 reported that a type parameter was not constrained to a class (Bug
8362 2007-01-14 Marek Habersack <grendello@gmail.com>
8364 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8366 2007-01-14 Marek Safar <marek.safar@gmail.com>
8368 A fix for bug #80368
8369 * assign.cs (FieldInitializer): New class implements field
8370 initializer statement.
8372 * attribute.cs: Update after FieldMember rename.
8374 * class.cs (PropertyBasedMember): New common class for property based
8376 (InterfaceMemberBase): New base class for all members which can be used as
8377 an interface members.
8378 (MethodCore): Moved really common code to InterfaceMemberBase.
8379 (Method.Define): Equal and GetHasCode detection is relevant for methods
8381 (MethodData.Define): Don't assume that public event implements an
8382 interface automatically.
8383 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8385 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8386 (FieldMember): Merged with FieldBase.
8387 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8388 event extern modifier can be used.
8389 (EventField.EventFieldAccessor): Moved event field specific code here.
8390 (Event.AllowedModifiers): Even event can be extern.
8391 (Event.FindOutBaseMethod): New override specific to events.
8392 (Indexer.parameters): Reintroduce parameters because base class holds
8393 only properties common data.
8394 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8395 need do extra parameters check.
8397 * const.cs: Update after FieldMember rename.
8399 * decl.cs (MemberCache.FindBaseEvent): New method.
8401 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8402 to reflect that indexer is now derived from PropertyBased.
8404 * ecore.cs (GetMemberType): Made public.
8405 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8408 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8410 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8411 (RegisterEvent): Removed.
8412 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8413 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8415 2007-01-11 Raja R Harinath <rharinath@novell.com>
8418 * statement.cs (CollectionForeach.TryType): Prefer generic
8419 GetEnumerator over non-generic variant. Fix code to follow comments.
8421 2007-01-09 Raja R Harinath <rharinath@novell.com>
8424 * support.cs (ReflectionParameter): Don't use an invalid index on
8425 the generic parameter data.
8427 2007-01-08 Miguel de Icaza <miguel@novell.com>
8429 * driver.cs: Just add a tiny bit of infrastructure.
8431 2007-01-02 Marek Safar <marek.safar@gmail.com>
8433 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8434 where field type is struct from current assembly.
8436 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8439 2007-01-02 Marek Safar <marek.safar@gmail.com>
8441 A fix for bug #80381
8442 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8445 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8447 (Namespace.LookupType): Always use core types from corlib when speficied.
8449 * report.cs: A new warning.
8451 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8452 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8453 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8455 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8456 (InitCoreTypes): Set expression type of object_type and value_type
8457 immediately after lookup.
8459 2007-01-01 Miguel de Icaza <miguel@novell.com>
8461 * cs-tokenizer.cs: Accept Pc class characters (Connector
8462 Punctuation) as valid identifiers. Fixes #78259
8464 * expression.cs (Invocation.DoResolve): Moved the check for the
8465 use of `this' for doing method calls to the Invocation resolution
8466 step, after overload resolution has taken place instead of doing
8467 the check at the low-level `This.DoResolve' level.
8469 The `This.DoResolve'(appens before overload resolution, so it has
8470 no way of knowing if the method that will be called will be
8471 instace or static, triggering an erroneous report for cs0188 (Bug
8474 We now do the check for instance method invocations after we know
8475 what method will be called.
8477 (This.CheckThisUsage): Move the actual use of this structure
8478 checking into its own method and expose it.
8480 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8483 Exceptions: Null.ConvertImplicitly,
8484 Constant.ImplicitConversionRequired as there are too many call
8485 sites for passing the ec.
8487 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8488 EmitContext, if the value is null, then we do not try to provide
8489 the extra information from the error (If a userdefined conversion
8490 exists, as UserDefinedConversion requires a non null-EmitContext).
8494 2006-12-30 Raja R Harinath <rharinath@novell.com>
8496 * flowanalysis.cs (MyBitVector): Document some invariants.
8497 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8498 introduced below, and add a couple of others,
8500 2006-12-30 Marek Safar <marek.safar@gmail.com>
8502 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8503 GetPropertyFromAccessor and GetEventFromAccessor.
8505 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8506 overrides non-obsolete one.
8507 (Indexer.Define): Error message has been moved to the parser.
8509 * cs-parser.jay: Better syntax errors handling.
8511 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8512 when an invocation has no arguments.
8514 * ecore.cs: Removed not used caching.
8516 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8519 * report.cs: Add a new warning.
8521 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8523 * typemanager.cs (enumeration_type): Removed.
8524 (CSharpSignature): Reuses IsSpecialMethod.
8525 (IsEqual): Hack for MS BCL.
8526 (GetPropertyFromAccessor): New method.
8527 (GetEventFromAccessor): New method.
8528 (IsSpecialMethod): Fixed to handle more cases.
8530 2006-12-30 Marek Safar <marek.safar@gmail.com>
8532 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8533 Made white spaces array static.
8535 * ecore.cs (RemoveGenericArity): Optimized.
8537 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8539 (MyBitVector.initialize_vector): Simplified.
8541 2006-12-22 Miguel de Icaza <miguel@novell.com>
8543 * ecore.cs: Am not entirely happy with this hack, but it seems to
8544 address the issue in 80257 (a small test case for
8547 I set the MethodGroupExpr.Type to an internal compiler type
8548 (itself in this case) to force the resolution to take place. Why
8549 it does not take place with a null is beyond me.
8551 2006-12-20 Marek Safar <marek.safar@gmail.com>
8553 A fix for bug #80288
8554 * expression.cs (ResolveOperator): Consider user defined conversion for
8555 logical and operator too.
8556 (EmitBranchable): Optimization for logical and when full constant folding
8557 could not be applied but one operand is constant.
8559 2006-12-19 Marek Safar <marek.safar@gmail.com>
8561 * class.cs (GetClassBases): Write 5 times every day, will never use
8562 FullName for error reporting.
8564 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8566 2006-12-19 Martin Baulig <martin@ximian.com>
8568 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8569 the symbol file info here.
8571 2006-12-18 Marek Safar <marek.safar@gmail.com>
8573 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8574 of `elseif' is taking then following sections are not taking.
8575 Fixes an issue reported on mono mailing list.
8577 2006-12-18 Marek Safar <marek.safar@gmail.com>
8579 A fix for bug #80300
8580 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8581 a caller is not taking.
8583 2006-12-18 Raja R Harinath <rharinath@novell.com>
8585 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
8586 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
8587 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
8588 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
8589 * class.cs: Update to changes.
8591 2006-12-17 Marek Safar <marek.safar@gmail.com>
8593 A fix for bug #79934
8594 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
8597 * class.cs (ResolveMembers): Register an iterator in current container and
8600 2006-12-16 Raja R Harinath <rharinath@novell.com>
8603 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
8604 satisfy a params annotated parameter.
8606 2006-12-16 Marek Safar <marek.safar@gmail.com>
8608 A fix for bug #77014
8609 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
8610 paramters correctly and not rely on hacks in Parameters class.
8611 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
8613 (Invocation.VerifyArgumentsCompat): Ditto.
8614 (Invocation.EmitArguments): Changed to correctly emit params arguments at
8617 * parameter.cs (HasParams): Don't assume that params is the last one.
8619 * support.cs (ReflectionParameters.ctor): Look for params attribute
8621 (ReflectionParameters.ParameterType): Removed hack when we returned last
8622 parameter for out of range parameters.
8623 (ParameterName, ParameterModifier): Ditto.
8625 2006-12-14 Marek Safar <marek.safar@gmail.com>
8627 A fix for bug #79987
8628 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
8629 when assembly is not CLS compliant but type is. I have no idea why is this
8632 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
8634 2006-12-13 Miguel de Icaza <miguel@novell.com>
8636 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
8637 in struct constructors, they are basically no-ops.
8639 2006-12-12 Marek Safar <marek.safar@gmail.com>
8641 * cs-tokenizer.cs (Position): Save preprocessor status too.
8643 2006-12-12 Marek Safar <marek.safar@gmail.com>
8645 A fix for bug #77794
8646 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
8648 2006-12-12 Marek Safar <marek.safar@gmail.com>
8650 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
8652 (pp_expr): Report error for an invalid expression.
8653 (handle_preprocessing_directive): Simplified; add more error checking.
8655 2006-12-11 Marek Safar <marek.safar@gmail.com>
8657 A fix for bug #74939
8658 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
8659 directives handling.
8661 2006-12-10 Marek Safar <marek.safar@gmail.com>
8663 A fix for bugs #80093, and #75984
8664 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
8665 logic, it seems to me as it worked before "by coincidence".
8666 (xtoken): Simplified to use reworked handle_preprocessing_directive.
8667 (cleanup): Enabled endif check.
8669 2006-12-09 Marek Safar <marek.safar@gmail.com>
8671 A fix for bug #80162
8672 * statement.cs (CollectionForeach.TryType): Generics and non-generics
8673 enumerators are never ambiguous.
8675 2006-12-08 Raja R Harinath <rharinath@novell.com>
8678 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
8680 2006-12-06 Marek Safar <marek.safar@gmail.com>
8682 A fix for bug #80144
8683 * class.cs (EventProperty.Define): Explicit implementation means
8684 that an even is used.
8686 2006-12-06 Marek Safar <marek.safar@gmail.com>
8688 Fixes the operators implementation (part II)
8690 * cfold.cs (DoConstantNumericPromotions): Renamed to
8691 DoBinaryNumericPromotions and simplified.
8692 (BinaryFold): Couple of conversion fixes; simplified.
8694 * constant.cs, ecore.cs, literal.cs
8695 (ToType): Renamed to ConvertImplicitly.
8696 (Reduce): Renamed to ConvertExplicitly.
8698 * class.cs, convert.cs: Updated.
8700 * expression.cs: TryReduce doesn't throw an exception.
8702 2006-12-01 Marek Safar <marek.safar@gmail.com>
8704 A fix for bug #80108
8705 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
8708 2006-11-30 Marek Safar <marek.safar@gmail.com>
8710 Fixes unary operators implementation (part I)
8713 * cfold.cs (Error_CompileTimeOverflow): Made internal
8715 * const.cs (IConstant): Changed to use reference to constant and
8716 not constant itself.
8717 Updated IConstant implementations.
8719 * constant.cs (CreateConstant): New factory method.
8720 Updated IConstant implementation.
8722 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
8724 * ecore.cs: Updated to use CreateConstantReference.
8726 * enum.cs: Reflects IConstant changes.
8728 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
8730 * literal.cs (NullConstant): Change to be independently usable.
8732 2006-11-29 Martin Baulig <martin@ximian.com>
8734 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
8735 we need to emit the scope initializer before calling the base .ctor.
8737 * anonymous.cs: Merged back from the new anonymous methods branch.
8738 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
8740 * expression.cs (ParameterReference.DoResolveBase): Create a
8741 "normal" ScopeInfo when capturing parameters rather than using the
8742 root scope; this makes things work with anonymous methods having
8746 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
8748 2006-11-22 Marek Safar <marek.safar@gmail.com>
8750 A fix for bug #79987
8751 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
8752 check to a base class.
8753 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
8754 only when assembly has missing attribute.
8755 * report.cs: Update.
8757 2006-11-21 Marek Safar <marek.safar@gmail.com>
8759 * cs-tokenizer.cs: Merged with gmcs version.
8761 2006-11-20 Marek Safar <marek.safar@gmail.com>
8764 * cs-parser.jay: Better error message when partial keyword is misplaced.
8766 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
8768 A fix for bug #79810
8769 report.cs: CS1058 only applies to 2.0 profile (gmcs).
8770 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
8771 a RuntimeWrappedException by default.
8773 2006-11-18 Marek Safar <marek.safar@gmail.com>
8775 A fix for bug #79843
8776 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
8778 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
8780 2006-11-18 Marek Safar <marek.safar@gmail.com>
8782 * driver.cs, namespace.cs: Uses faster IndexOf version.
8784 2006-11-17 Marek Safar <marek.safar@gmail.com>
8786 A fix for bug #79941
8787 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
8789 (Operator.Define): Implicit/Explicit operator of same type is duplicate
8790 even if internal name is different.
8791 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
8792 (UserDefinedConversion): Simplified as the operators cannot be internal.
8793 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
8795 (MethodLookup): Replaced EmitContext with parentType.
8796 * expression.cs: Updated.
8798 2006-11-09 Raja R Harinath <rharinath@novell.com>
8800 * driver.cs (BadAssembly): Handle all the ugliness of
8801 DefineDynamicAssembly.
8803 2006-11-08 Raja R Harinath <rharinath@novell.com>
8805 Address parts of #58244 -- most of what's left is in the runtime
8806 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
8807 CS1509 error checks, and handle them for all assembly loads, not
8808 just the first invocation.
8809 (LoadModule): Likewise. Move handling of 'adder_method' ...
8810 * codegen.cs (AssemblyClass.AddModule): ... here.
8812 2006-11-02 Marek Safar <marek.safar@gmail.com>
8814 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
8815 IEnumerable<T> is ambiguous.
8817 2006-10-31 Marek Safar <marek.safar@gmail.com>
8819 A fix for bug #67689
8820 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
8821 GetEnumerator is ambiguous.
8823 * report.cs: Add new warning.
8825 2006-10-29 Marek Safar <marek.safar@gmail.com>
8827 A fix for bug #78602
8828 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8829 to protected member can be nested type.
8831 2006-10-28 Marek Safar <marek.safar@gmail.com>
8833 A fix for bug #78965
8834 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8835 to protected member must derive from current type.
8837 2006-10-27 Marek Safar <marek.safar@gmail.com>
8839 assign.cs: Reuses error method.
8841 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
8842 instead of type for constants.
8843 (Expression.Error_ValueAssignment): Common error method.
8845 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
8848 2006-10-27 Marek Safar <marek.safar@gmail.com>
8850 A fix for bug #79081
8851 * expression.cs (MemberAccess.DoResolve): Check nested type
8854 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
8856 * doc.cs : nested delegates were not handled. Fixed bug #79754.
8858 2006-10-26 Marek Safar <marek.safar@gmail.com>
8860 A fix for bug #76591
8861 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
8863 2006-10-26 Marek Safar <marek.safar@gmail.com>
8865 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
8866 type forwarder of the same type multiple times.
8868 2006-10-26 Raja R Harinath <rharinath@novell.com>
8871 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
8872 instance as an rvalue, even when we later resolve as an lvalue.
8874 2006-10-25 Martin Baulig <martin@ximian.com>
8876 * anonymous.cs: Fix #79673.
8878 2006-10-24 Marek Safar <marek.safar@seznam.cz>
8880 A fix for bug #79666
8881 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
8882 ignored when is optimized (= default value) as its value is already set.
8884 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8886 A fix for bug #79724
8887 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
8888 TypeContainer for type lookup.
8890 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8892 A fix for bug #79231
8893 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
8894 * expression.cs (OverloadResolve): Always convert type name for
8896 (ResolveNamespaceOrType): Don't confuse a nested type with any
8899 2006-10-18 Martin Baulig <martin@ximian.com>
8901 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
8903 2006-10-17 Miguel de Icaza <miguel@novell.com>
8905 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
8906 an int32, but requesting an int64 from the conversion
8908 2006-10-12 Martin Baulig <martin@ximian.com>
8911 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
8913 2006-10-12 Martin Baulig <martin@ximian.com>
8916 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
8918 2006-10-11 Miguel de Icaza <miguel@novell.com>
8920 * convert.cs: Remove broken code: I was doing the "Existance"
8921 tests for Implicit conversions.
8923 2006-10-10 Miguel de Icaza <miguel@novell.com>
8925 * convert.cs: Added one missing case in
8926 ImplicitStandardConversionExists uint64 to intptr.
8930 * typemanager.cs (uintptr_type): another core known type.
8932 * ecore.cs (OperatorCast): routine used to do cast operations that
8933 depend on op_Explicit. We could change some of the Decimal
8934 conversions to use this.
8936 This one has a probe mechanism that checks both types for an op_
8937 which it coudl be used to eliminate two classes: CastToDecimal
8938 and CastFromDecimal.
8940 * convert.cs: Implement the conversions documented in #59800
8942 2006-10-10 Martin Baulig <martin@ximian.com>
8944 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
8945 before RootScope.ResolveMembers().
8947 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
8948 `CurrentType' if appropriate.
8950 2006-10-09 Marek Safar <marek.safar@seznam.cz>
8952 A fix for bug #78568
8953 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
8954 when contains binary operators.
8955 * cs-parser.jay: Updated.
8957 2006-10-09 Martin Baulig <martin@ximian.com>
8960 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
8961 moved that into Define() and also do the other type parameter
8962 checks there. Fixes #79094. Added gtest-292.cs.
8965 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
8966 since that doesn't include type parameters; don't use `Ldelema'
8967 for type parameters. Fixes #78980. Added gtest-293.cs.
8969 2006-10-08 Marek Safar <marek.safar@seznam.cz>
8972 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
8973 conversion is allowed.
8975 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8977 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
8978 error reporting when no error occurs.
8980 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8982 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
8985 2006-10-06 Raja R Harinath <rharinath@novell.com>
8988 * class.cs (DefineTypeBuilder): Check circular dependencies before
8989 setting the parent of the TypeBuilder.
8990 (CheckRecursiveDefinition): Don't use 'BaseType', since
8991 it may not be valid until after DefineTypeBuilder. Use
8992 'base_type' instead.
8994 2006-10-04 Martin Baulig <martin@ximian.com>
8996 Merged the Anonymous Methods patch.
8998 * anonymous.cs, iterators.cs: The new anonymous methods code.
9000 * statement.cs (Variable): New public abstract class.
9001 (LocalInfo.Variable): New public property.
9002 (LocalInfo.ResolveVariable): New public method.
9003 (Block.Flags): Add `IsIterator'.
9004 (Block.AddVariable): Improved the CS0136 check.
9005 (Block.AnonymousChildren): New public property.
9006 (Block.AddAnonymousChild): New public method.
9007 (ToplevelBlock): Update to use the new anonymous method framework.
9008 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9009 `ToplevelBlock'; this is required to correctly implement the
9011 (Fixed, Using): Use `TemporaryVariable' instead of directly
9012 creating the `LocalBuilder'.
9014 * parameter.cs (Parameter.ResolveVariable): New public method.
9015 (Parameters.ResolveVariable): Likewise.
9017 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9019 * class.cs (TypeContainer): Replaced the `iterators' list and
9020 corresponding methods with a list of `CompilerGeneratedClass'es.
9021 (TypeContainer.ResolveMembers): New public method.
9022 (Method): `IIteratorContainer' has been replaced by
9025 * expression.cs (VariableReference): New public abstract base
9026 class for `LocalVariableReference', `ParameterReference' and
9029 * codegen.cs (EmitContext): Removed `capture_context',
9030 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9031 (EmitContext.EmitThis): Removed.
9033 * cs-parser.jay: Replace `iterator_container' with
9036 2006-10-04 Martin Baulig <martin@ximian.com>
9038 * generic.cs (GenericMethod): Don't make this abstract.
9039 (Constraints.Clone): Added dummy implementation.
9041 2006-10-04 Raja R Harinath <harinath@gmail.com>
9044 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9045 'declspaces'. Avoid allocating arrays willy-nilly.
9048 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9049 cases out of the switch.
9051 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9053 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9054 message when non-generic type is used with the type arguments.
9055 * expression.cs: Updated.
9057 2006-09-28 Raja R Harinath <rharinath@novell.com>
9060 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9061 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9062 Change semantics slightly. Don't insist on having only one
9063 temporary EmptyExpression -- just throttle the creation of new ones.
9066 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9067 non-interfaces too. If no methods are found, don't try to create
9070 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9072 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9075 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9076 us produce better error message.
9078 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9080 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9081 of the `|' operator.
9083 * report.cs: A new warning added.
9085 2006-09-27 Martin Baulig <martin@ximian.com>
9087 * generic.cs (GenericMethod): Don't make this abstract.
9089 2006-09-27 Martin Baulig <martin@ximian.com>
9092 (InternalErrorException): Added overloaded ctor taking a params array.
9094 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9096 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9097 Fixed the cases when same error was reported twice.
9099 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9100 now report symbol information.
9102 2006-09-25 Martin Baulig <martin@ximian.com>
9104 * class.cs: Completely unified with the gmcs version.
9106 2006-09-25 Martin Baulig <martin@ximian.com>
9108 * typemanager.cs (TypeManager.IsNullableType): New public function.
9109 (TypeManager.IsNullableTypeOf): Likewise.
9110 (TypeManager.IsNullableValueType): Likewise.
9112 * class.cs (MethodCore): Added the `GenericMethod' argument from
9113 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9115 2006-09-24 Raja R Harinath <harinath@gmail.com>
9117 * convert.cs: Unify with gmcs version.
9119 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9121 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9122 verify them as well.
9124 * report.cs: New warning.
9126 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9128 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9129 for anonymous block with out argument.
9131 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9133 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9134 not used private events only.
9136 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9138 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9140 * const.cs (Const.Define): Check for constant type.
9141 (Const.IsConstantTypeValid): Looks for valid constant types.
9143 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9145 * ecore.cs (EmptyConstantCast): New common class for all constant based
9148 * expression.cs (Is.DoResolve): Handle null constant especially.
9149 (New.DoResolve): Check for new void().
9150 (MemberAccess.DoResolve): Cope with all kind of nulls.
9152 * literal.cs (NullConstant): Uses EmptyConstantCast.
9153 (NullDefault): Based on EmptyConstantCast.
9154 (NullLiteral): Uses EmptyConstantCast.
9156 * statement.cs (Block.ResolveMeta): Check for constant type.
9158 2006-09-22 Martin Baulig <martin@ximian.com>
9160 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9162 2006-09-22 Raja R Harinath <rharinath@novell.com>
9164 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9168 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9169 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9172 2006-09-22 Martin Baulig <martin@ximian.com>
9174 * ecore.cs: Merged with the gmcs version.
9176 * generic.cs (ConstructedType): New dummy class.
9177 (TypeArguments): Don't make this abstract.
9180 (TypeManager.IsGenericTypeDefinition): New method.
9181 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9183 2006-09-22 Raja R Harinath <rharinath@novell.com>
9185 * expression.cs (ComposedCast): Check for arrays of TypedReference
9186 before creating the type, not after.
9188 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9190 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9191 after ToType change.
9193 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9194 when constant must be implicitly convertible.
9196 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9198 * ecore.cs (NullCast): Derives from NullConstant.
9200 * expression.cs (Is.DoResolve): Removed useless variables.
9201 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9202 (New.Constantify): Add enum support.
9203 (MemberAccess.DoResolve): Add warning when accessing null constant or
9206 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9209 * literal.cs (NullConstant): New abstract class with common
9210 functionality for all null specializations.
9211 (NullDefault): Represents default(X) when result can be
9213 (NullLiteral): Updated.
9215 * report.cs: Add new warning.
9217 2006-09-21 Martin Baulig <martin@ximian.com>
9219 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9221 2006-09-21 Martin Baulig <martin@ximian.com>
9223 * generic.cs (GenericConstraints): New dummy class.
9224 (Constraints): Likewise.
9225 (TypeParameter): Likewise.
9226 (TypeParameterName): Likewise.
9227 (GenericMethod): Likewise.
9229 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9231 * decl.cs: Merged with the gmcs version.
9233 2006-09-21 Raja R Harinath <rharinath@novell.com>
9235 * generic.cs (TypeParameter): Implement IMemberContainer.
9236 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9238 * rootcontext.cs: Unify with gmcs version.
9240 * report.cs: Unify with gmcs version.
9241 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9242 from gmcs/generics.cs.
9243 * generics.cs (TypeParameter): New dummy class.
9245 * support.cs: Unify with gmcs version.
9247 2006-09-20 Raja R Harinath <rharinath@novell.com>
9249 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9250 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9252 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9253 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9254 * mcs.exe.sources: Add generic.cs.
9256 * codegen.cs: Unify with gmcs version.
9258 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9259 (EmitContext): Add GenericDeclContainer implementation.
9260 * decl.cs (MemberCore, DeclSpace): Likewise.
9261 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9263 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9264 MCS TypeManager has a corresponding dummy method.
9266 2006-09-19 Martin Baulig <martin@ximian.com>
9268 * expression.cs: Completely merged with the gmcs version.
9270 2006-09-19 Martin Baulig <martin@ximian.com>
9272 * expression.cs (Invocation): Merged with the gmcs version.
9273 (ArrayAccess.GetStoreOpcode): Likewise.
9275 2006-09-19 Martin Baulig <martin@ximian.com>
9278 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9279 (TypeManager.IsGenericMethodDefinition): Likewise.
9281 2006-09-19 Martin Baulig <martin@ximian.com>
9284 (TypeManager.IsEqual): Moved the gmcs implementation here.
9285 (TypeManager.DropGenericTypeArguments): Likewise.
9286 (TypeManager.DropGenericMethodArguments): Likewise.
9287 (TypeManager.GetTypeArguments): Moved here from gmcs.
9288 (TypeManager.HasGenericArguments): Likewise.
9290 2006-09-19 Martin Baulig <martin@ximian.com>
9292 * expression.cs (Binary): Merged with the gmcs version.
9294 2006-09-19 Martin Baulig <martin@ximian.com>
9296 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9298 2006-09-19 Martin Baulig <martin@ximian.com>
9300 * typemanager.cs: Merged with the gmcs version.
9302 2006-09-16 Raja R Harinath <rharinath@novell.com>
9304 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9305 * driver.cs: Likewise.
9307 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9310 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9311 only if parent type is class.
9312 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9315 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9318 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9320 * typemanager.cs(CSharpName): Converts NullType to null.
9322 2006-09-15 Martin Baulig <martin@ximian.com>
9325 (TypeManager.GetMethodName): Added mcs implementation.
9326 (TypeManager.IsEqual): Likewise.
9329 (SimpleName.RemoveGenericArity): Added dummy implementation.
9331 * pending.cs: Merged with the gmcs version.
9333 2006-09-15 Martin Baulig <martin@ximian.com>
9335 * statement.cs: Merge with the gmcs version.
9337 2006-09-15 Martin Baulig <martin@ximian.com>
9339 * statement.cs (Switch): Merge with the gmcs implementation
9340 (without nullables), which is newer.
9342 2006-09-15 Martin Baulig <martin@ximian.com>
9344 * statement.cs (Block.Variables): Make this public.
9345 (ToplevelBlock.Parameters): Make this a property.
9346 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9348 2006-09-15 Martin Baulig <martin@ximian.com>
9350 * namespace.cs: Merge with the gmcs version.
9352 2006-09-15 Martin Baulig <martin@ximian.com>
9354 * decl.cs (MemberName): Minor code cleanups.
9356 2006-09-15 Martin Baulig <martin@ximian.com>
9358 * parameter.cs: Merge with the gmcs version.
9360 2006-09-15 Martin Baulig <martin@ximian.com>
9362 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9363 and an error in mcs.
9365 2006-09-15 Martin Baulig <martin@ximian.com>
9367 * flowanalysis.cs: Merged from GMCS; added the generics code into
9368 a `GMCS_SOURCE' conditional so we can share this file.
9370 2006-09-08 Martin Baulig <martin@ximian.com>
9372 * typemanager.cs (TypeManager.interlocked_type): New public field.
9373 (TypeManager.int_interlocked_compare-exchange): New public field.
9374 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9375 enumerator types here and call InitGenericCoreTypes().
9376 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9377 after calling InitEnumUnderlyingTypes().
9380 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9381 `classes_second_stage'.
9383 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9385 * assign.cs, ecore.cs, expression.cs: Share error message text.
9386 * class.cs (FieldMember.Define): Check for varible of static type.
9387 * driver.cs (LoadAssembly): Uses error output for errors.
9388 * statement.cs: Updated.
9390 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9392 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9395 2006-09-07 Martin Baulig <martin@ximian.com>
9398 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9400 2006-08-29 Miguel de Icaza <miguel@novell.com>
9402 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9404 2006-08-17 Miguel de Icaza <miguel@novell.com>
9406 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9407 #52019 and #79064, the use of the \uXXXX sequence in source code
9408 to represent unicode characters.
9410 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9412 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9414 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9416 2006-08-13 Miguel de Icaza <miguel@novell.com>
9418 * assign.cs: Catch attempts to assign to a method groups in += and
9421 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9424 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9426 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9428 * class.cs (Method.Define): Issue a warning when generic method looks like
9430 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9433 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9435 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9437 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9438 search all base interfaces as a member can be ambiguous.
9439 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9440 Constructor member type filter.
9441 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9442 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9443 reporting for returned memberinfos.
9444 * report.cs: Updated.
9445 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9446 version to work on all runtimes.
9447 (TypeManager.RealMemberLookup): Removed members filtering.
9449 2006-08-08 Raja R Harinath <rharinath@novell.com>
9451 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9452 (PropertyExpr.EmitAssign): Likewise.
9453 * expression.cs (Indirection.EmitAssign): Likewise.
9454 (LocalVariableReference.EmitAssign): Likewise.
9455 (ParameterReference.EmitAssign): Likewise.
9456 (Invocation.EmitArguments): Likewise.
9457 (ArrayAccess.EmitAssign): Likewise.
9458 (IndexerAccess.EmitAssign): Likewise.
9459 (This.EmitAssign): Likewise.
9460 (ConditionalLogicalOperator.Emit): Likewise.
9463 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9464 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9465 leave it in after returning it.
9466 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9468 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9470 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9473 2006-08-03 Raja R Harinath <rharinath@novell.com>
9475 Fix cs0146-3.cs and cs0146-4.cs.
9476 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9477 enclosing types don't depend on the current type.
9479 2006-08-02 Raja R Harinath <rharinath@novell.com>
9482 * class.cs (TypeContainer.DoDefineMembers): Use
9483 FindBaseMemberWithSameName on Parent, since we're interested in
9484 whether we hide inherited members or not.
9485 (FindBaseMemberWithSameName): Make slightly more robust.
9487 Fix the non-generic testcase from #77396
9488 * decl.cs (DeclSpace.DeclContainer): Remove override.
9490 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9491 declspaces for doppelgangers too.
9492 (UsingEntry): Implement IResolveContext.
9493 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9494 'this' as the resolve context.
9495 (LocalAliasEntry): Likewise.
9497 Implement parts of #77403
9498 * roottypes.cs (RootDeclSpace): New. Used to represent the
9499 toplevel declaration space. Each namespace declaration introduces
9500 a "partial" root declaretion space.
9501 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9502 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9503 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9504 from 'current_namespace.SlaveDeclSpace'.
9505 (namespace_declaration): Likewise.
9506 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9507 check. It can't happen now.
9508 * decl.cs (DeclSpace.LookupType): Likewise.
9509 * driver.cs (MainDriver): Sanity check.
9511 2006-08-01 Raja R Harinath <rharinath@novell.com>
9513 * decl.cs (DeclSpace.FindNestedType): Remove.
9514 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9515 LookupTypeContainer to get the container of the nested type.
9516 * class.cs (TypeContainer.FindNestedType): Make non-override.
9518 2006-07-31 Raja R Harinath <rharinath@novell.com>
9520 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9521 * class.cs (TypeContainer.PartialContainer): ... here.
9522 (TypeContainer.AddBasesForPart): New helper.
9523 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9525 * cs-parser.jay (current_class): Convert to DeclSpace.
9526 (struct_declaration, interface_declaration, class_declaration):
9527 Use AddBasesForPart instead of .Bases directly.
9528 * const.cs, iterators.cs: Update to changes.
9530 2006-07-28 Raja R Harinath <rharinath@novell.com>
9532 * class.cs (TypeContainer.AddMemberType): Rename from
9534 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9535 (AddTypeContainer): New. Combine AddClassOrStruct and
9537 (AddPartial): Update. Add 'is_partial' argument.
9538 * roottypes.cs: Update to changes.
9539 * cs-parser.jay (push_current_class): New helper for handling
9540 current_container and current_class.
9541 (struct_declaration, interface_declaration, class_declaration):
9544 2006-07-26 Raja R Harinath <rharinath@novell.com>
9546 * roottypes.cs: Rename from tree.cs.
9548 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9549 * tree.cs (Tree, ITreeDump): Remove types.
9550 * rootcontext.cs (tree, Tree): Remove fields.
9551 (root, ToplevelTypes): New.
9552 * *.cs: Update to rename.
9554 * tree.cs (Tree.RecordDecl): Remove.
9555 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9557 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9559 2006-07-23 Raja R Harinath <harinath@gmail.com>
9561 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9562 DoFlowAnalysis and OmitStructFlowAnalysis here.
9563 (ec.With): Rename from WithUnsafe and generalize.
9564 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9565 (ec.WithFlowAnalyis): New.
9566 * ecore.cs, expression.cs, statement.cs: Update.
9568 2006-07-22 Raja R Harinath <harinath@gmail.com>
9570 * statement.cs (Block.ResolveMeta): Simplify slightly.
9572 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9573 multiple boolean fields. Convert InUnsafe, constant_check_state,
9574 check_state to flags.
9575 (CheckState, ConstantCheckState): Update.
9576 (InUnsafe): New read-only property.
9577 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9579 (WithUnsafe): New helper similar to WithCheckState.
9580 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9581 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9583 2006-07-21 Raja R Harinath <rharinath@novell.com>
9585 Make comparisons use the same IL irrespective of whether they're
9586 in a 'checked' or 'unchecked' context: one of the issues in #78899
9587 * codegen.cs (EmitContext.CheckState): Make read-only property.
9588 (EmitContext.ConstantCheckState): Likewise.
9589 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
9590 helper that implement a save/restore stack for CheckState
9591 values. This is the only way to change check-state.
9592 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
9593 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
9594 (CheckedExpr.EmitBranchable): New forwarding method.
9595 (UnCheckedExpr): Likewise.
9596 * statement.cs (Block.ResolveMeta): Use WithCheckState.
9597 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
9598 (Checked.Resolve, checked.DoEmit): Likewise.
9600 2006-07-20 Miguel de Icaza <miguel@novell.com>
9602 * anonymous.cs: Cache the resolved anonymous delegate, and return
9603 this so that the ResolveTopBlock is only triggered once, not
9606 Currently we trigger ResolvetopBlock twice due to a first pass of
9607 argument check compatibility, and a second pass that does the
9610 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9612 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
9614 * rootcontext.cs (Reset): Add helper_classes.
9616 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9619 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
9622 2006-07-13 Miguel de Icaza <miguel@novell.com>
9624 * statement.cs (Lock): Handle expressions of type
9625 TypeManager.null_type specially. Fixes #78770
9627 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9629 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
9632 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9634 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
9635 for accessors as well.
9636 * ecore.cs (EventExpr): Add AccessorTable.
9638 2006-07-01 Marek Safar <marek.safar@seznam.cz>
9641 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
9642 for CS0122 where appropriate.
9643 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
9645 (Filter): Assembly can be null in the case of top level attributes.
9647 2006-06-25 Marek Safar <marek.safar@seznam.cz>
9651 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
9652 is done at global level.
9654 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9656 A fix for #77002, Implemented TypeForwarder support.
9658 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
9659 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
9660 * typemanager.cs (): Add type_forwarder_attr_type.
9662 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9664 * report.cs: Add CS0469 warning.
9666 2006-06-21 Martin Baulig <martin@ximian.com>
9668 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
9669 the `try'-block, so we also report CS0016 etc. there.
9671 2006-06-21 Martin Baulig <martin@ximian.com>
9674 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
9676 2006-06-21 Martin Baulig <martin@ximian.com>
9678 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
9679 also report CS1686 for parameters.
9681 2006-06-21 Martin Baulig <martin@ximian.com>
9683 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
9684 instead of an error if the value is not implicitly convertible to
9685 the switch types; fixes #77964.
9687 2006-06-21 Raja R Harinath <rharinath@novell.com>
9690 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
9691 FieldBuilder is null.
9694 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
9695 'left' and 'right' before error-checking.
9697 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
9699 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
9701 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
9702 (FieldExpr.DoResolve): likewise.
9703 (PropertyExpr.InstanceResolve): likewise.
9704 (EventExpr.InstanceResolve): likewise.
9706 2006-06-04 Marek Safar <marek.safar@seznam.cz>
9708 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
9709 attribute applicable tests for attribute argument.
9711 2006-06-02 Raja R Harinath <rharinath@novell.com>
9714 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
9715 (Binary.OverloadResolve_PredefinedIntegral): New.
9716 (Binary.OverloadResolve_PredefinedFloating): New.
9717 (Binary.OverloadResolve_PredefinedString): New.
9718 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
9719 Follow the standard more closely, and treat numeric promotions in
9720 terms of overload resolution.
9721 (Binary.CheckShiftArguments): Simplify.
9723 2006-06-01 Raja R Harinath <rharinath@novell.com>
9725 * flowanalysis.cs (MyBitVector): Simplify representation.
9726 (MyBitVector.Clone): Avoid allocating BitArray.
9727 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
9728 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
9729 (*): Update. Change all references to MyBitVector.And and
9730 MyBitVector.Or to &= and |=.
9732 2006-05-29 Raja R Harinath <rharinath@novell.com>
9735 * cs-parser.jay (formal_parameter_list): Extend the pattern below
9736 to param arguments too.
9738 2006-05-26 Miguel de Icaza <miguel@novell.com>
9740 * cs-parser.jay: Catch another parsing form for arglist being
9741 followed by other arguments. Fixes #78313.
9743 2006-05-24 Raja R Harinath <rharinath@novell.com>
9745 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
9746 checking of out parameters to ...
9747 (FlowBranchingToplevel.Merge): ... here.
9748 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
9749 set, propagate the origin upward, and only complain if there was
9751 (FlowBranchingException.AddContinueOrigin): Likewise.
9752 (FlowBranchingException.AddReturnOrigin): Likewise.
9753 (FlowBranchingException.AddGotoOrigin): Likewise.
9755 2006-05-23 Raja R Harinath <rharinath@novell.com>
9757 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
9758 unreachable, skip it.
9759 (FlowBranchingException.Merge): Always propagate jumps, even if
9760 the finally block renders subsequent code unreachable.
9762 2006-05-18 Raja R Harinath <rharinath@novell.com>
9765 * statement.cs (Goto.Resolve): Move responsibility for resolving
9766 'goto' to FlowBranching.AddGotoOrigin.
9767 (Goto.SetResolvedTarget): New. Callback to set the
9768 LabeledStatement that's the target of the goto.
9769 (Goto.DoEmit): Use Leave instead of Br when crossing an
9770 unwind-protect boundary.
9771 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
9772 LookupLabel and adjust to new semantics.
9773 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
9774 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
9775 Goto.SetResolvedTarget to update target.
9776 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
9777 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
9778 AddBreakOrigin & co. Delay propagation until ...
9779 (FlowBranchingException.Merge): ... this.
9781 * statement.cs (Block.Resolve): Always depend on flow-branching to
9782 determine unreachability. Kill workaround that originally emitted
9783 only one statement after an "unreachable" label (see infloop in
9786 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
9787 This is still "wrong", but anything better would probably need a
9788 multi-pass algorithm.
9789 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
9790 usage vector. Force current usage vector to be reachable, to
9791 optimistically signify backward jumps.
9792 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
9794 (FlowBranchingLabeled.Merge): New. If no backward jump was
9795 detected, return the original salted-away usage vector instead,
9796 updated with appropriate changes. Print unreachable warning if
9798 * statement.cs (Block.Resolve): Don't print unreachable warning on
9799 a labeled statement.
9801 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
9803 * driver.cs: Pass filename without path to AssemblyBuilder's
9804 AddResourceFile. Fixes bug #78407.
9806 2006-05-17 Raja R Harinath <rharinath@novell.com>
9808 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
9809 * flowanalysis.cs (FlowBranchingLabeled): ... here.
9810 (FlowBranching.MergeChild): Overwrite
9811 reachability information from Labeled branchings too.
9813 2006-05-16 Raja R Harinath <rharinath@novell.com>
9815 * statement.cs (Goto.Resolve): Merge jump origins here ...
9816 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
9818 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
9819 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
9820 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
9821 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
9823 * statement.cs (Goto.Resolve): ... not here.
9824 (Goto.Emit): Remove CS1632 check.
9826 2006-05-14 Marek Safar <marek.safar@seznam.cz>
9828 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
9831 2006-05-11 Raja R Harinath <rharinath@novell.com>
9833 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
9834 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
9835 (FlowBranchingException.Label): Likewise.
9837 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
9839 (MyBitVector.Or): Use it to avoid losing information (Count).
9840 (FlowBranching.MergeOrigins): Likewise.
9842 * flowanalysis.cs (UsageVector.IsDirty): Remove.
9843 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
9844 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
9845 (UsageVector.ToString): Simplify.
9846 (UsageVector.MergeSiblings): Move here from ...
9847 (FlowBranching.Merge): ... here.
9848 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
9851 2006-05-10 Raja R Harinath <rharinath@novell.com>
9853 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
9854 null bitvector is treated as all-true.
9856 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
9857 (MyBitVector): Rationalize invariants. 'vector != null' implies
9858 that we have our own copy of the bitvector. Otherwise,
9859 'InheritsFrom == null' implies all inherited bits are true.
9861 2006-05-09 Marek Safar <marek.safar@seznam.cz>
9863 * statement.cs (LocalInfo): Add IsConstant.
9864 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
9865 local variable for constants.
9867 2006-05-09 Raja R Harinath <rharinath@novell.com>
9869 * flowanalysis.cs (MyBitVector.Empty): New.
9870 (MyBitVector): Don't allow InheritedFrom to be null.
9871 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
9872 (UsageVector, FlowBranching): Update to changes.
9874 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
9875 recursion. The 'Parent == null' condition isn't sufficient for
9877 (FlowBranching.AddBreakOrigin): Likewise.
9878 (FlowBranching.AddContinueOrigin): Likewise.
9879 (FlowBranching.AddReturnOrigin): Likewise.
9880 (FlowBranching.StealFinallyClauses): Likewise.
9881 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
9882 (FlowBranching.CheckOutParameters): Likewise.
9883 (FlowBranchingToplevel): Terminate all the above recursions here.
9884 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
9885 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
9887 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
9889 (FlowBranchingToplevel): New. Empty for now.
9890 (FlowBranching.MergeTopBlock): Update.
9891 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
9892 branching for the anonymous delegate.
9893 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
9895 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
9896 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
9897 information at the start of the merge. Reorganize.
9899 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9901 * class.cs (MethodData.Define): Method cannot implement interface accessor.
9903 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9905 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
9906 to newly introduced ctor.
9908 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
9909 message to one place.
9910 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
9913 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9915 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
9917 * ecore.cs (Expression.ResolveAsConstant): Updated.
9919 * statement.cs (ResolveMeta): Updated.
9921 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9923 * cs-parser.jay: __arglist cannot be used in initializer.
9925 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9928 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
9931 2006-05-05 Raja R Harinath <rharinath@novell.com>
9933 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
9934 (LabeledStatement): Add 'name' parameter.
9935 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
9936 (Block.AddLabel): Update to changes.
9937 * cs-parser.jay (labeled_statement): Likewise.
9939 * flowanalysis.cs (BranchingType.Labeled): New.
9940 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
9941 (FlowBranchingLabeled): New. Does nothing for now, but will
9942 eventually handle 'goto' flows.
9943 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
9944 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
9945 that's terminated ...
9946 (Block.Resolve): ... here.
9948 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
9949 (UsageVector.MergeFinallyOrigins): Likewise.
9950 (FlowBranching.InTryOrCatch): Likewise.
9951 (FlowBranching.AddFinallyVector): Likewise.
9952 (FlowBranchingException): Update to changes.
9955 * statement.cs (Return.Resolve): Move error checking to ...
9956 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
9957 (FlowBranchingException): Handle return origins like break and
9959 (FlowBranching.UsageVector.CheckOutParameters): Remove.
9961 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9964 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
9967 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9970 * class.cs (MethodData.Define): Do public accessor check only when method
9971 implements an interface.
9973 2006-05-04 Raja R Harinath <rharinath@novell.com>
9975 Remove special handling of 'break'
9976 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
9977 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
9978 (UsageVector.Break): Remove.
9979 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
9981 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
9983 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
9984 UsageVector.Breaks (). Don't set NeedsReturnLabel.
9986 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9989 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
9990 be the interface member.
9992 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9995 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
9996 for emitting small (int) values.
9998 2006-05-03 Raja R Harinath <rharinath@novell.com>
10001 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10002 control-flow passes through the 'finally' after merging-in all the
10003 control-flows from 'try' and the 'catch' clauses.
10005 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10006 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10007 always true at the only non-recursive entry point.
10008 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10009 FlowBranchingBreakable.
10010 (FlowBranchingLoop): Remove.
10011 * statement.cs (Return.DoResolve): Update to changes.
10014 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10015 (FlowBranching.CreateBranching): Handle it: create a
10016 FlowBranchingContinuable.
10017 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10018 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10019 except that it handles the 'continue' command.
10020 (FlowBranching.UsageVector.MergeOrigins): Rename from
10022 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10023 except that it overrides AddContinueOrigin.
10024 (FlowBranchingException): Override AddContinueOrigin, similar to
10026 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10027 Create a new branching around the embedded statement.
10028 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10029 control flow after the embedded statement.
10030 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10032 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10033 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10034 FlowBranchingBreakable.
10035 (FlowBranchingSwitch): Remove.
10038 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10039 error reporting to ...
10040 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10041 Rename from 'AddBreakVector'. Add new location argument. Return
10042 a bool indicating whether the 'break' crosses an unwind-protect.
10043 (FlowBranchingException.AddBreakOrigin): Add.
10044 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10045 flowbranching after updating with the effects of the 'finally'
10047 (FlowBranchingBreakable): New common base class for
10048 FlowBranchingLoop and FlowBranchingSwitch.
10050 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10051 embedded statement.
10052 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10054 2006-05-02 Raja R Harinath <rharinath@novell.com>
10056 * statement.cs (Do.Resolve): If the loop is infinite, set the
10058 (While.Resolve, For.Resolve): Set a barrier after the embedded
10059 statement. There's no direct control flow that goes from the end
10060 of the embedded statement to the end of the loop.
10061 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10062 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10063 above ensure that the reachability is correctly computed.
10065 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10066 (UsageVector.MergeBreakOrigins): If the current path is
10067 unreachable, treat it as if all parameters/locals are initialized.
10068 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10069 infinite loops before merging-in break origins.
10071 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10072 (Reachability.Reachable): Split part into ...
10073 (Reachability.Unreachable): ... this. Simplify.
10074 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10076 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10077 (Reachability.SetThrowsSometimes): Likewise.
10078 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10079 TriState.Always, use corresponding property.
10080 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10081 (Block.Resolve): Likewise. Remove some redundant checks.
10083 2006-05-02 Raja R Harinath <harinath@gmail.com>
10085 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10086 (Reachability.Meet): Don't bother checking AlwaysThrows --
10087 barrier is always set.
10088 (FlowBranchingBlock.Merge): Likewise.
10090 2006-05-01 Raja R Harinath <harinath@gmail.com>
10092 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10093 checks for unreachable.
10095 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10098 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10100 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10101 whether field is really assigned.
10103 2006-04-30 Raja R Harinath <harinath@gmail.com>
10105 * flowanalysis.cs (Reachability): Make 4-argument constructor
10107 (Reachability.Meet): Rename from 'And'. Remove static variant.
10108 (Reachability.Always): Rename from the highly misleading
10109 'Reachability.Never'.
10110 (FlowBranching.Merge): Update to changes. Mark an impossible
10111 situation with a 'throw'.
10112 (*): Update to changes.
10114 2006-04-29 Raja R Harinath <harinath@gmail.com>
10116 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10117 Remove 'Undefined'.
10118 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10119 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10120 (*): Update to changes.
10121 * statement.cs: Update to changes.
10123 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10126 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10128 2006-04-28 Raja R Harinath <harinath@gmail.com>
10130 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10133 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10134 argument to two arguments: an usage-vector and a bool. Move call
10135 to FlowBranching.Merge () ...
10136 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10138 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10139 handling of loop and switch reachability to ...
10140 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10142 2006-04-27 Raja R Harinath <harinath@gmail.com>
10144 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10145 handling to FlowBranchingLoop.InLoop.
10146 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10148 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10151 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10152 anonymous method is allowed from AnonymousContainer here.
10154 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10156 2006-04-24 Raja R Harinath <rharinath@novell.com>
10159 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10161 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10164 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10165 (DoubleConstant.Reduce): Ditto.
10167 2006-04-23 Raja R Harinath <rharinath@novell.com>
10169 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10170 Remove 'lvalue_right_side' argument. Move parts to ...
10171 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10172 (LocalVariable.DoResolveLValue): ... these.
10174 2006-04-21 Raja R Harinath <rharinath@novell.com>
10177 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10178 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10179 (LocalVariableReference.DoResolveBase): Use it to implement new
10181 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10182 (Argument.Resolve): Simplify. Move CS1510 check ...
10183 * ecore.cs (Expression.ResolveLValue): ... here.
10184 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10185 (PropertyExpr.DoResolveLValue): Likewise.
10186 (FieldExpr.Report_AssignToReadonly): Likewise.
10187 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10188 LValueMemberAccess or LValueMemberOutAccess on instance depending
10190 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10191 DoResolve as appropriate.
10193 2006-04-20 Raja R Harinath <rharinath@novell.com>
10196 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10197 implicit conversions on 'out' and 'ref' arguments.
10199 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10200 improve clarity. Remove dead code.
10203 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10204 (Catch.Resolve): Resolve VarBlock if it exists.
10206 2006-04-19 Miguel de Icaza <miguel@novell.com>
10208 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10209 twice, this was some residual code, the enumerator was emitted
10210 properly in the two branche of if later.
10212 2006-04-19 Raja R Harinath <rharinath@novell.com>
10214 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10215 cast is never an lvalue.
10216 (Cast.DoResolve, Cast.ResolveRest): Combine.
10217 (Argument.Emit): Simplify slightly. Move 'Expr is
10218 IMemoryLocation' check ...
10219 (Argument.Resolve): ... here.
10220 (Argument.Error_LValueRequired): Remove. Inline into only user.
10222 Simplifications. Fix cs0191-2.cs
10223 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10224 CS1649 and CS1651 to ...
10225 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10226 the actual selection of the error code and message to a lookup
10227 table. Add a dummy return value to simplify callsites.
10228 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10229 readonly fields of other instances of the same type. Move CS0197
10231 * expression.cs (Argument.Resolve): ... here. Simplify code.
10232 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10233 resolution of an out or ref argument. The code simplification
10234 above uses this invariant.
10236 2006-04-18 Raja R Harinath <rharinath@novell.com>
10238 Possibly fix #77752. Fix cs1690-[4-7].cs.
10239 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10240 CheckMarshallByRefAccess. Drop parameter.
10241 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10243 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10244 InstanceExpression.
10245 * report.cs (AllWarnings): Add CS1690.
10246 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10247 for ref access too.
10248 (LocalVariableReference.DoResolveBase): Update.
10250 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10252 * class.cs (MethodOrOperator): Moved common parts from method class.
10253 detect obsolete attributes.
10254 (Method.Define): Simplified as it reuses code from base.
10255 (Constructor.ValidAttributeTargets): Fixed issue found during
10257 (Destructor.ValidAttributeTargets): Fixed issue found during
10259 (Operator): Finished refactoring set off by #78020. Operator class is now
10260 ordinary method class.
10262 * anonymous.cs: Updated.
10264 * decl.cs (DeclSpace): Add IsGeneric
10266 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10268 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10270 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10272 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10273 detect obsolete attributes.
10274 (Method.CreateEmitContext): Moved to MethodOrOperator.
10276 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10279 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10280 customized exception to make crash detection easier.
10281 (MethodOrOperator): Started to work on new base class for methods and
10283 (Method): Derives from MethodOrOperator.
10284 (Constructor.Emit): Emits its own attributes.
10285 (AbstractPropertyEventMethod.Emit): Ditto.
10286 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10288 (Operator.Emit): It's temporary more tricky than should be.
10290 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10292 * report.cs (InternalErrorException): Add ctor with inner exception.
10294 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10297 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10300 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10303 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10306 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10308 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10309 attribute is present and Guid not.
10310 (Interface.ApplyAttributeBuilder): Ditto.
10312 * attribute.cs: Add error message.
10314 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10318 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10319 sources (it's composite) so hold them in extra array as they are used in
10320 Emit phase only. It worked in the previous versions by mistake.
10321 (Attribute.Emit): Emit attribute for more owners when exist.
10323 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10324 it has now different behaviour.
10326 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10328 * constant.cs (Constant.IsDefaultInitializer): New method.
10330 * class.cs: Updated.
10332 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10333 re-initialize default values. It saves KBs almost for every assembly.
10334 Thanks Zoltan for the idea.
10335 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10336 (ArrayCreation.DoResolve): Resolve only once.
10337 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10338 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10340 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10342 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10345 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10347 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10348 in an embedded statement too.
10350 2006-04-01 Raja R Harinath <rharinath@novell.com>
10353 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10355 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10359 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10362 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10364 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10366 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10369 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10370 LocalTemporary change.
10372 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10374 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10375 initializers optimization.
10376 (ClassOrStruct.TypeAttr): Moved from modifiers.
10377 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10378 (FieldBase.ResolveInitializer): Resolves initializer.
10379 (FieldBase.HasDefaultInitializer): New property.
10381 * cs-parser.jay: Removed message.
10383 * expression.cs (CompilerGeneratedThis): New specialization.
10385 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10387 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10389 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10391 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10393 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10394 be now EnumConstants only.
10396 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10398 * attribute.cs, driver.cs: Reset more caches.
10400 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10402 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10404 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10406 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10407 for easier reuse. Updated all overrides.
10408 (IntegralConstant): New base class for all integral constants.
10409 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10410 of the constant range, report custom error.
10411 (UIntConstant.Reduce): Fixed uint conversion.
10413 * ecore.cs, literal.cs: Reduce updates.
10415 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10419 * class.cs (Constructor.Define): Removed extra if for default ctors.
10420 A patch from Atsushi Enomoto.
10422 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10424 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10425 GetAttributableValue.
10427 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10430 * convert.cs (ImplicitConversionRequired): Error message moved to
10433 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10434 automatic implicit conversion of an output value.
10435 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10437 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10439 (TypeOf.GetAttributableValue): Add extra handling for object type.
10441 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10442 special error message.
10444 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10446 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10448 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10449 compatible with MS runtime.
10451 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10453 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10454 attribute arguments here.
10456 * class.cs (Indexer.Define): The check was moved to attribute class.
10458 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10460 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10461 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10464 2006-03-22 Raja R Harinath <rharinath@novell.com>
10466 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10467 mcs to keep code differences small.
10468 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10469 * typemanager.cs (parameter_default_value_attribute_type): New.
10470 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10473 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10475 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10477 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10479 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10481 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10484 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10486 * doc-bootstrap.cs : fix build.
10488 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10490 * expression.cs (StringConcat.Append): Issue a warning when empty string
10491 is going to append.
10493 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10495 * assign.cs (CompoundAssign.ResolveSource): Removed.
10497 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10500 * class.cs (TypeContainer.FindMethods): Removed.
10501 (TypeContainer.CheckMemberUsage): Made static.
10503 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10505 * constant.cs (CheckRange): Removed unused type argument.
10506 (CheckUnsigned): Removed unused type argument.
10508 * cs-parser.jay: Updated after MemberAccess clean up.
10509 Uses Length for empty string test.
10511 * cs-tokenizer.cs: Uses Length for empty string test.
10512 (IsCastToken): Made static.
10513 (is_hex): Made static.
10514 (real_type_suffix): Made static.
10516 * decl.cs (SetupCache): Made static.
10517 (OnGenerateDocComment): Removed unused ds argument.
10519 * delegate.cs (VerifyDelegate): Removed unused argument.
10521 * doc.cs: Uses Length for empty string test.
10523 * driver.cs: Uses Length for empty string test.
10525 * enum.cs (IsValidEnumType): Made static
10527 * expression.cs (EnumLiftUp): Removed unused argument.
10528 (ResolveMethodGroup): Ditto.
10529 (BetterConversion): Ditto.
10530 (GetVarargsTypes): Ditto.
10531 (UpdateIndices): Ditto.
10532 (ValidateInitializers): Ditto.
10533 (MemberAccess.ctor): Ditto.
10534 (GetIndexersForType): Ditto.
10536 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10538 * iterators.cs: Updated after MemberAccess clean up.
10540 * location.cs: Uses Length for empty string test.
10542 * namespace.cs: Uses Length for empty string test.
10544 * report.cs (CheckWarningCode): Made static.
10546 * statement.cs (LabeledStatement): Removed unused argument.
10548 * typemanager.cs (FilterNone): Removed.
10550 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10552 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10555 * class.cs: Updated.
10557 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10559 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10561 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10565 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10566 reporting, it's more tricky than I thought.
10568 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10572 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10574 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10575 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10576 Add more error reporting; Fixed issue with params.
10578 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10580 * cs-parser.jay: AnonymousMethod requires host container.
10582 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10584 2006-03-18 Raja R Harinath <harinath@gmail.com>
10586 * class.cs: Change 'TypeContainer ds' constructor argument to
10587 'DeclSpace parent'. Some classes were missed below due to
10588 different naming convention.
10590 * class.cs (MemberCore.Parent): Delete. This makes the
10591 ParentContainer changes below enforceable by the compiler.
10593 Treat pointers to enclosing declaration space as 'DeclSpace', not
10595 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
10596 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
10598 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
10600 (Block.AddThisVariable): Likewise.
10601 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
10602 (AbstractPropertyEventMethod.Emit): Likewise.
10603 (AbstractPropertyEventMethod.EmitMethod): Likewise.
10604 (GetMethod.Define, SetMethod.Define): Likewise.
10605 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
10606 (DelegateMethod.EmitMethod): Likewise.
10608 Fix regression test-partial-13.cs.
10609 Rationalize use of PartialContainer. Ensure that the partial
10610 class semantics can be tied to type-correctness, i.e., any
10611 violation will cause a compile error.
10612 * class.cs, const.cs: Access all fields that belong to class
10613 TypeContainer via ParentContainer. Arguments of EmitContexts and
10614 Resolve()-like functions still use 'Parent'.
10616 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
10617 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
10618 (PropertyMethod.CheckModifiers): Remove unused argument.
10619 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
10622 2006-03-17 Raja R Harinath <harinath@gmail.com>
10624 Make semantics of PartialContainer simpler.
10625 * decl.cs (DeclSpace.IsPartial): Remove.
10626 * class.cs (TypeContainer.IsPartial): Likewise.
10627 (TypeContainer..ctor): Set PartialContainer to point to self.
10628 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
10629 (TypeContainer.FindNestedType): Likewise.
10630 (MemberCore.ParentContainer): Simplify. Remove deprecation.
10632 2006-03-17 Marek Safar <marek.safar@seznam.cz>
10634 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
10636 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10638 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
10641 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10643 * class.cs (Operator.Define): An error for base conversion was not
10644 reported correctly.
10646 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
10648 * iterator.cs : yield break is allowed in try statement which has
10649 catch clauses. Fixed bug #77767.
10651 2006-03-13 Marek Safar <marek.safar@seznam.cz>
10653 A fix for #77593, #77574.
10655 * class.cs (MethodCore.CheckBase): Another if for operator.
10657 2006-03-09 Marek Safar <marek.safar@seznam.cz>
10659 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
10662 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
10663 (DelegateCreation.ImplicitStandardConversionExists): New method for just
10666 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
10669 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
10670 Updated after another emitcontext usage was clean up. It should help us to
10671 synchronize with gmcs easier.
10673 2006-03-04 Marek Safar <marek.safar@seznam.cz>
10677 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
10678 (Event.Define): ditto
10679 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
10681 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
10682 Removed redundant code and set NewSlot for Invoke method too.
10684 * parameter.cs (Parameters.ctor): Add custom, type ctor.
10685 (Parameters.MergeGenerated): New method. Use this method when you merge
10686 compiler generated argument with user arguments.
10688 2006-03-03 Marek Safar <marek.safar@seznam.cz>
10690 * attribute.cs (ResolveAsTypeTerminal): Removed.
10692 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
10693 specialization for predefined types; 30% speed up.
10694 Finally placed obsolete check to right place.
10695 (Expression.ResolveType): Removed.
10697 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
10698 Updated after ResolveType was removed.
10700 * expression.cs (Cast.ctor): Check void cast.
10701 (Binary.ResolveAsTypeTerminal): Is never type.
10702 (Conditional.ResolveAsTypeTerminal): Is never type.
10704 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
10706 2006-03-01 Raja R Harinath <rharinath@novell.com>
10709 * expression.cs (ParameterReference.DoResolveBase): Change return
10711 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
10715 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
10718 * typemanager.cs (GetFullNameSignature): Don't nullref on
10719 protected accessors.
10721 2006-02-27 Marek Safar <marek.safar@seznam.cz>
10723 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
10724 these two separated members to simplify the code.
10725 (Attribute.Resolve): Refactored to use new fields and methods.
10726 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
10727 implemented obsolete attribute checking.
10728 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
10729 implemented obsolete checking again. It look line never ending quest ;-)
10730 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
10732 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
10734 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
10736 *class.cs (Property.Define): Add RegisterProperty call.
10738 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
10739 argument groups (only 2).
10741 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
10742 encoding expression to arguments.
10743 (Expression.ExprClassToResolveFlags): Just turned to property.
10745 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
10746 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
10747 optimized as well as implemented support for zero-length attributes.
10749 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
10750 Add caching of PropertyInfo's.
10752 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10754 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
10755 error multiple times.
10757 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10759 New partial class implementation.
10760 A fix for #77027, #77029, #77403
10762 * attribute.cs (Attributable): Made attributes protected.
10764 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
10765 the replacements of ClassPart and PartialContainer.
10766 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
10767 (TypeContainer.AddInterface): Ditto.
10768 (TypeContainer.AddPartial): The main method for partial classes. It checks
10769 for errors and merges ModFlags and attributes. At the end class is added to
10770 partial_parts list.
10771 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
10773 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
10774 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
10775 from the rest of partial classes.
10776 (TypeContainer.GetClassBases): Simplified.
10777 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
10779 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
10780 (TypeContainer.HasExplicitLayout): Uses Flags now.
10781 (PartialContainer): Removed.
10782 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
10783 (StaticClass): Was merged with Class.
10784 (Class.GetClassBases): class and static class bases are verified here.
10785 (Class.TypeAttr): Added static attributes when class is static.
10786 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
10787 (MemberBase): In some cases we need to call parent container for partial
10788 class. It should be eliminated but it's not easy now.
10790 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
10792 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
10793 partial classed to accumulate class comments.
10794 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
10796 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
10798 * driver.cs (MainDriver): Tree.GetDecl was removed.
10800 * modifiers.cs (Modifiers): Add partial modifier.
10802 * tree.cs (Tree.decl): Removed.
10803 (RootTypes): Started to use this class more often for root types
10806 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10810 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
10811 external interface does not have an attribute.
10813 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10815 Another prerequisites for new partial classs implementation.
10817 * attribute.cs (Attribute.Equal): Implemented.
10818 (Attribute.Emit): Changed as attributes can be applied more than twice.
10819 (Attributes.Emit): Check for duplicate attributes here.
10821 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
10822 as a parameter, clean-up.
10824 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10828 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
10829 contains obsolete attribute check which can in some cases look for base
10830 type of current class which is not initialized yet.
10831 (TypeContainer.BaseType): Replacement of ptype.
10833 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
10835 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10837 First of prerequisites for new partial classs implemention.
10839 * attribute.cs (Attributable): Extended by ResolveContext;
10840 Attributes finally have correct context for resolving in all cases.
10841 (AttachTo): Attribute owner is assigned here.
10843 * codegen.cs (IResolveContext): Introduce new interface to hold
10844 all information needed in resolving phase.
10845 (EmitContext): Implements IResolveContext; more clean-up needed here.
10847 * decl.cs (MemberCore): Implemented IResolveContext.
10849 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
10850 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
10851 parameter.cs, statement.cs, tree.cs, typemanager.cs:
10852 Refactored to use new IResolveContext instead of EmitContext; cleanup
10854 2006-02-06 Miguel de Icaza <miguel@novell.com>
10856 * codegen.cs (EmitScopeInitFromBlock): check here the
10857 capture_context, there is no need to make two calls to the
10860 * anonymous.cs: Add some debugging messages that might help me
10861 track other instances of this problem in the future (the
10862 regression of test 467).
10864 * cs-parser.jay: track the variable block, as we need to initalize
10865 any captured variables declared in this block for the "catch"
10866 portion of the "Try" statement.
10868 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
10869 scope initialization for captured variables.
10871 Also, move the emit for the variables after the block location has
10874 2006-02-06 Marek Safar <marek.safar@seznam.cz>
10876 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
10878 2006-02-02 Miguel de Icaza <miguel@novell.com>
10880 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
10881 commit yesterday, the initialization for the roots is necessary.
10882 What is not necessary is the scope activation.
10884 2006-02-02 Raja R Harinath <rharinath@novell.com>
10886 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
10887 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
10889 (Argument.Resolve): Remove CS0206 checks.
10891 2006-02-01 Miguel de Icaza <miguel@novell.com>
10893 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
10894 scopes for all the roots, the scopes will now be emitted when the
10895 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
10897 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
10898 code. This reduces a lot of existing cruft.
10900 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
10901 that the ScopeInfo is generated as we enter the scope, not at the
10902 time of use, which is what we used to do before.
10904 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
10905 every time a Block is about to be emitted if we have a
10908 2006-02-01 Raja R Harinath <rharinath@novell.com>
10910 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
10912 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
10914 * typemanager.cs (cons_param_array_attribute): Make private.
10915 (Reset): Set it to null.
10916 (InitCoreHelpers): Don't initialize it.
10917 (ConsParamArrayAttribute): New. Initialize it as needed.
10918 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
10920 2006-01-31 Miguel de Icaza <miguel@novell.com>
10922 * expression.cs: There might be errors reported during the
10923 selection of applicable methods. If there are errors, do not
10924 continue execution as it will lead the compiler to crash.
10926 2006-01-30 Miguel de Icaza <miguel@novell.com>
10928 * expression.cs: Member access is not allowed on anonymous
10929 methods. Fixes #77402.
10931 2006-01-30 Raja R Harinath <rharinath@novell.com>
10934 * cs-parser.jay (VariableDeclaration): Don't set
10935 current_array_type to null.
10936 (field_declaration, event_declaration, declaration_statement):
10937 Set it to null here.
10939 2006-01-28 Raja R Harinath <harinath@gmail.com>
10941 * typemanager.cs (GenericParameterPosition): New.
10944 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
10946 * doc.cs : To process "include" elements, first we should create
10947 another list than XmlNodeList, because it could result in node
10948 removal, which could result in that the XmlNodeList gives up
10949 yielding next node.
10951 (Also made code identical to gmcs again.)
10953 2006-01-25 Miguel de Icaza <miguel@novell.com>
10955 * ecore.cs: Introduce an error report that we were not catching
10956 before, if not silent, we must report the error. Gonzalo ran into
10959 2006-01-23 Miguel de Icaza <miguel@novell.com>
10961 A fix for bug: #76957
10963 * iterators.cs (MoveNextMethod.CreateMethodHost): call
10964 ComputeMethodHost before creating the method, this is a new
10967 * anonymous.cs (AnonymousContainer): Now we track all the scopes
10968 that this method references (RegisterScope). The actual scope
10969 where the method is hosted is computed with the ComputeMethodHost
10970 before we create the method.
10972 Moved the Deepest routine here.
10974 (AnonymousContainer.ComputeMethodHost): New routine used to
10975 compute the proper ScopeInfo that will host the anonymous method.
10977 (ScopeInfo): Deal with multiple roots. The problem was that we
10978 did not have a unique root where all ScopeInfos could be hanged
10979 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
10982 Remove AdjustMethodScope which is now computed at the end. Remove
10983 LinkScope which did a partial link, instead link all ScopeInfos
10984 before code generation from the new "LinkScopes" routine.
10986 Simplify all the Add* routines as they no longer need to maintain
10987 the tree, they just need to record that they are using variables
10990 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
10991 routines to produce the forest of ScopeInfo trees.
10993 * class.cs (TypeContainer.AppendMethod): This is just like
10994 AddMethod, but ensures that an interface implementation method
10995 (IEnumerable.XXX) is not inserted at the beginning of the queue of
10996 methods, but at the end.
10998 We use this functionality to ensure that the generated MoveNext
10999 method in the iterator class is resolved/emitted before the
11000 enumerator methods created.
11002 This is required because the MoveNext method computes the right
11003 ScopeInfo for the method. And the other methods will eventually
11004 need to resolve and fetch information computed from the anonymous
11007 2006-01-21 Raja R Harinath <harinath@gmail.com>
11008 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11010 Fix rest of #76995.
11011 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11012 the 'aliases' hash.
11013 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11014 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11016 2006-01-18 Raja R Harinath <rharinath@novell.com>
11018 Fix #76656, cs0231-2.cs.
11019 * cs-parser.jay (formal_parameter_list): Make error case catch
11021 (parenthesized_expression_0): Add CS1026 check.
11022 (invocation_expression): Remove unused { $$ = lexer.Location }.
11024 2006-01-17 Raja R Harinath <rharinath@novell.com>
11027 * cs-parser.jay (statement_expression): Don't list out the
11028 individual statement-expressions. Convert syntax error into
11031 2006-01-16 Raja R Harinath <rharinath@novell.com>
11034 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11035 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11036 CheckIntermediateModification.
11037 (FieldExpr.DoResolve): Add new two-argument version that
11038 allows us to resolve the InstanceExpression as an lvalue.
11039 The one-argument variant is now just a wrapper.
11040 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11041 Resolve the lhs as an lvalue if the it has a value type.
11042 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11043 from Assign.DoResolve.
11044 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11045 resolved as an lvalue.
11046 (PropertyExpr.DoResolve): Update.
11047 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11048 has a value type. Move CS1612 check here from
11049 CheckIntermediateModification.
11050 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11051 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11052 'right_side' of a ResolveLValue on an 'out' argument.
11053 (EmptyExpression.LValueMemberAccess): New. Used as the
11054 'right_side' of a propagated ResolveLValue on a value type.
11055 (LocalVariableReference.DoResolveBase): Recognize
11056 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11058 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11059 EmptyExpression.Null.
11061 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11063 * typemanager.cs : added IsGenericParameter(). In mcs it always
11065 * doc.cs : for generic parameters, use GenericParameterPosition,
11068 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11070 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11072 2006-01-12 Miguel de Icaza <miguel@novell.com>
11074 This fixes the problem where we used ldfld instead of ldflda to
11075 load the "THIS" pointer on captured parameters, when THIS is a
11076 value type. See bug #77205.
11078 * iterators.cs (CapturedThisReference.Emit): Pass false to
11079 EmitThis (we do not need the address).
11081 * codegen.cs (EmitThis): it needs to know whether we need the
11082 address of `this' or not. This is used by value types.
11084 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11085 every other call passes false.
11087 2006-01-12 Raja R Harinath <rharinath@novell.com>
11090 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11092 * expression.cs (Invocation.OverloadResolve): Update.
11093 (Invocation.DoResolve): Avoid double resolution of invocation.
11095 2006-01-11 Raja R Harinath <rharinath@novell.com>
11098 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11099 unary negation of floating point types as 0-expr; negation cannot
11100 overflow in floating point types.
11103 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11104 on operands of 'void' type.
11107 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11108 and ExclusiveOr for boolean constants too.
11110 2006-01-09 Raja R Harinath <rharinath@novell.com>
11113 * expression.cs (Invocation.OverloadResolve): Replace reflected
11114 override methods with their base virtual methods, rather than
11115 skipping over them.
11116 * typemanager.cs (TypeManager.GetOverride): New.
11118 2006-01-05 Jb Evain <jbevain@gmail.com>
11120 * class.cs (Property.Define, Indexer.Define): do not tag the
11121 properties as SpecialName | RTSpecialName.
11123 2006-01-04 Miguel de Icaza <miguel@novell.com>
11125 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11126 doing a low-level comparission of parameter types. It was lacking
11127 a check for __argslist.
11129 2005-12-30 Miguel de Icaza <miguel@novell.com>
11131 * expression.cs (ParameterReference.DoResolveBase): Allow
11132 reference parameters if they are local to this block.
11134 This allows the ref and out parameters of a delegate to be used in
11135 an anonymous method, for example:
11137 delegate void set (out int x);
11139 set s = delegate (out int x){
11143 This is used by functionality introduced late in the C# language.
11145 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11146 method that take ref and out parameters.
11148 Fixes #77119 which was a late change in the spec.
11150 2005-12-23 Miguel de Icaza <miguel@novell.com>
11152 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11153 parent if its the same scope. Fixes #77060.
11155 2005-12-21 Miguel de Icaza <miguel@novell.com>
11157 * driver.cs: Report the case of no source files and no -out:
11160 2005-12-20 Raja R Harinath <rharinath@novell.com>
11163 * expression.cs (ComposedCast.GetSignatureForError): Define.
11165 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11169 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11170 ListDictionary, to contain the ExternAliasEntry entries (in
11171 addition to the NamespaceEntry.aliases hashtable). This field is
11172 shared between the original entry and its doppelganger (bodyless
11174 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11175 extern_aliases field.
11176 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11177 lookup in extern_aliases.
11179 2005-12-16 Raja R Harinath <rharinath@novell.com>
11182 * class.cs (TypeContainer.Mark_HasEquals): New.
11183 (TypeContainer.Mark_HasGetHashCode): New.
11184 (ClassPart): Override them.
11185 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11188 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11189 'parent' argument to the base constructor.
11191 Remove all mention of TypeContainer from decl.cs.
11192 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11193 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11194 (DeclSpace.DeclSpace): Likewise.
11195 (DeclSpace.DefineMembers): Remove unused argument.
11196 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11197 debugging check -- we don't care if the debug code throws an
11198 InvalidCastException instead of an InternalErrorException.
11199 * class.cs (TypeContainer.DefineMembers): Update to changes.
11200 (TypeContainer.DoDefineMembers): Likewise.
11201 (TypeContainer.GetMethods): Likewise.
11202 (PropertyMember.Define): Likewise.
11203 (MemberBase.Parent): New property that forwards to
11204 MemberCore.Parent, but ensures that we get a TypeContainer.
11205 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11206 (RootContext.PopulateTypes): Likewise. Remove special case code
11207 for !RootContext.StdLib: DefineMembers is idempotent.
11209 2005-12-14 Miguel de Icaza <miguel@novell.com>
11211 * convert.cs (ExplicitConversionCore): Check the return value from
11212 ExplicitConversionCore which can return null on failure. Fixes #76914
11214 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11216 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11218 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11220 * doc.cs : The search for referenced namespace was insufficient to
11221 get global one as it used to do. Fixed bug #76965.
11223 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11225 * doc.cs : check name in cref in the last phase that whether it is
11228 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11230 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11233 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11235 * doc.cs : so it turned out that we cannot skip override check for
11236 interface members. Fixed bug #76954.
11238 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11240 * cs-tokenizer.cs : fixed bug #75984:
11241 - #warning and #error should not be handled when the source line
11243 - #line is not checked strictly when the source line is disabled.
11244 - #define and #undef is on the other hand checked strictly at any
11247 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11249 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11252 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11254 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11256 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11257 event initializers.
11258 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11259 (FieldBase.Initializer): Initializer is now optional.
11260 (EventField.Define): Only event field can have initializer.
11262 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11264 * const.cs (Const): Reuse initializer.
11266 * cs-parser.jay: Updated after FieldBase changes.
11267 Added current_array_type to simplify array initializers.
11269 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11271 * expression.cs, iterators.cs: Updated.
11273 * namespace.cs (NamespaceEntry): Made UsingFound private.
11275 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11277 * parameterCollection.cs: Obsolete, removed.
11278 * parser.cs: Obsolete, removed.
11280 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11283 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11285 * enum.cs (Enum.Define): Set obsolete context here.
11287 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11290 - FindDocumentedMember() now expects 1) paramList as null
11291 when "we don't have to check the number of parameters" and
11292 2) Type.EmptyTypes when "there is no arguments".
11293 - Introduced FoundMember struct to hold the exact type which was
11294 used to find the documented member (the above change broke
11295 test-xml-044; it might be better just to use DeclaringType than
11296 what MS does, like this change does, but it depends on usage.)
11298 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11300 * doc.cs : documented member might be from DeclaringType for nested
11301 types. Fixed bug #76782.
11303 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11305 * anonymous.cs: Have the param code handle leaving copies on the
11306 stack etc. Allows anonymous params to take part in the assignment
11307 code (++, +=, etc). Fixes bug #76550
11309 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11310 it down to the anon code.
11312 * iterators.cs: Use dummy var here
11314 * codegen.cs: Handle new vars
11316 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11319 * class.cs (MethodData.Define): Set proper Obsolete context.
11321 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11323 (FieldExpr.DoResolve): Ditto.
11325 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11328 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11329 parent is not obsolete.
11331 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11333 * doc.cs : (FindDocumentedMember) find parameterless members first
11334 and get CS0419 in the early stage. Fixed first case of bug #76727.
11336 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11339 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11340 no error was reported.
11342 *expression.cs (Binary.DoResolve): left can be null.
11344 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11347 * class.cs (MethodData.Emit): Parameters should be labeled first.
11349 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11352 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11354 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11356 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11358 * class.cs (MethodCore): Parameter clean up.
11359 (IMethodData): Added ParameterInfo.
11360 (MethodData): Parameter clean up.
11361 (Indexer.Define): Parameter clean up.
11373 * typemanager.cs: Parameter clean up.
11375 * delegate.cs (Define): Get rid of duplicated code.
11377 * expression.cs (ParameterReference): Removed useless parameters
11379 (Invocation): Ditto.
11381 * parameter.cs (ParamsParameter): New class, params specialization.
11382 (ArglistParameter): Attemp to separate arglist.
11383 (Parameter): Refactored to be reusable and faster.
11384 (Parameter.Modifier): Made understandable.
11385 (Parameters): Changed to be used as a class for `this' assembly
11386 parameters. Refactored to use new specialized classes.
11388 * support.cs (ParameterData): Added Types property.
11389 (InternalParameters): Deleted.
11391 2005-08-20 Martin Baulig <martin@ximian.com>
11393 Merging this patch from GMCS to fix #75867.
11395 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11396 scope if we don't already have it.
11398 2005-11-17 Martin Baulig <martin@ximian.com>
11401 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11402 inherit the scope from our parent. Fixes #76653.
11404 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11406 * doc.cs : the previous patch does not actually fix the bug.
11407 PropertyInfo override check is now implemented and really fixed it.
11408 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11410 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11412 * doc.cs : apply "override filter" also to properties.
11415 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11417 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11418 no need to check overrides. For classes, omit those results from
11419 interfaces since they must exist in the class. Fixed bug #76726.
11421 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11423 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11424 with different parameters. Fixed the second problem in #76685.
11426 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11428 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11429 get expected 'protected' access in CheckValidFamilyAccess()).
11432 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11434 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11435 Fixed bug #76705. CS1569 was incorrectly commented out.
11437 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11439 * doc.cs : use Invocation.IsOverride() to do real override check.
11440 * expression.cs : made Invocation.IsOverride() internal.
11442 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11444 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11445 TypeBuilder.FindMembers() and filter overriden base members out.
11448 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11450 * doc.cs : ref/out parameters are represented as '@' (instead of
11451 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11453 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11455 * doc.cs : when there was no '.' in cref to methods in doc comment,
11456 then parameters were missing in the output. Fixed bug #76691.
11458 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11460 * driver.cs : don't output docs when there is an error.
11463 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11466 Now it should detect indexers. Fixed primary concern in bug #76685.
11467 Fixed CS0419 message to not show the identical member signature in
11470 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11472 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11473 instead of Type.FindMembers() since it does not handle events.
11476 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11478 * codegen.cs: Fixed typo (speficied -> specified).
11480 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11483 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11485 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11487 * attribute.cs: Changed error message.
11489 * cs-tokenizer.cs: One more check.
11491 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11493 * statement.cs (Block.Resolve): Ignore empty statement.
11495 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11497 * report.cs: Made error/warning methods more strict to avoid
11500 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11501 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11502 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11503 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11505 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11507 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11508 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11510 * class.cs (TypeContainer.IsComImport): New property.
11511 (Constructor.Define): Create proper ctor for ComImport types.
11513 * expression.cs (New.CheckComImport): Fixed.
11515 2005-11-07 Miguel de Icaza <miguel@novell.com>
11517 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11518 that a parameter has been captured does not mean that we do not
11519 have to do the rest of the processing. This fixes the second part
11520 of #76592. If there was another anonymous method capturing
11521 values in the past, the Scope would never be set for the second
11522 method that captured the same parameter.
11524 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11525 properly manipulate the stack. Second part of fix for #76592.
11527 * expression.cs (New): Add support for invoking "new" on
11528 interfaces that have been flagged with the ComImport attribute and
11529 the CoClass. Fixes #76637
11531 * statement.cs (Try.DoEmit): When a variable is captured, do not
11532 try to emit the vi.LocalBuilder variable as it has been captured.
11533 Create a temporary variable and store the results on the
11534 FieldBuilder. Fixes #76642
11536 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11538 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11540 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11542 * expression.cs (Binary.DoResolve): Added && optimalization.
11544 * typemanager.cs (AddUserType): Removed useless argument.
11546 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11548 * statement.cs (Block.variables): Uses ListDictionary.
11550 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11553 * class.cs (PartialContainer.EmitType): Customized to emit
11554 security attributes.
11555 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11556 for partial classes.
11558 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11561 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11562 access has to be fixed.
11564 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11566 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11569 * ecore.cs (NullCast.Reduce): Implemented.
11571 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11574 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11576 (Foreach.Resolve): Catch null properly.
11578 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11580 * cs-tokenizer.cs: Warning text fix.
11582 * driver.cs: AllWarningNumbers exposed on public interface.
11584 * report.cs (): Reviewed warning numbers.
11585 (IsValidWarning): Use binary search.
11587 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11589 * driver.cs: Implemeted resource visibility.
11590 (Resources): New class for code sharing between /res: and
11593 2005-10-28 Marek Safar <marek.safar@seznam.cz>
11596 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
11599 * convert (Convert.ImplicitReferenceConversion): NullCast holds
11602 * ecore.cs (NullCast): Child is contant only.
11604 * literal.cs (NullLiteral.Reduce): null can be converted to any
11607 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
11609 * driver.cs: Use Encoding.Default as default code page instead
11612 2005-10-27 Raja R Harinath <rharinath@novell.com>
11615 * expression.cs (Invocation.Error_InvalidArguments): Handle
11616 __arglist parameters.
11617 (Invocation.VerifyArgumentsCompat): Likewise.
11618 * support.cs (ReflectionParameters.GetSignatureForError): Print
11619 __arglist parameters.
11620 (InternalParamters.GetSignatureForError): Likewise.
11621 * parameter.cs (Parameters.GetSignatureForError): Likewise.
11623 2005-10-26 Marek Safar <marek.safar@seznam.cz>
11625 * attribute.cs (GetPropertyValue): Made public.
11627 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
11629 Add new property WrapNonExceptionThrows to handle 2.0 assembly
11631 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
11634 * driver.cs: Reflect method name change.
11636 * statement.cs (Try.Resolve): Warn when try has both general
11637 exception handlers.
11639 * typemanager.cs: runtime_compatibility_attr_type new predefined
11642 2005-10-26 Raja R Harinath <harinath@gmail.com>
11645 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
11646 treat it as an empty parameter list.
11648 2005-10-26 Raja R Harinath <rharinath@novell.com>
11651 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
11652 ResolveAsTypeStep silent.
11653 * statement.cs (Block.AddConstant): Mark block as used.
11654 (Block.ResolveMeta): Avoid piling on error messages
11655 if a constant initializer resolution fails.
11657 2005-10-25 Raja R Harinath <rharinath@novell.com>
11659 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
11661 (NamespaceEntry.VerifyAllUsing): New.
11662 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
11663 behaviour. Delegates actual resolution of alias to ...
11664 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
11665 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
11667 * driver.cs (Driver.MainDriver): Update.
11669 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
11670 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
11672 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
11674 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
11675 RootNamespace.DefineNamespacesForAll.
11677 2005-10-24 Raja R Harinath <harinath@gmail.com>
11679 * typemanager.cs (assemblies, external_aliases, modules)
11680 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
11681 (ComputeNamespaces, GetRootNamespace): Remove extra staging
11682 overhead. Move resposibility ...
11683 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
11684 * driver.cs, attribute.cs, codegen.cs: Update to changes.
11686 2005-10-23 Raja R Harinath <harinath@gmail.com>
11688 * namespace.cs (RootNamespace.all_namespaces): Renamed from
11689 cached_namespaces. Improve usage.
11690 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
11691 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
11692 Move from GlobalRootNamespace and simplify.
11693 (RootNamespace.Global): Make instance variable.
11694 (RootNamespace.RootNamespace): Add "alias name" parameter.
11695 (GlobalRootNamespace): Simplify drastically.
11696 (Namespace.Lookup): Don't use GetNamespace.
11697 * typemanager.cs (GetRootNamespace): Rename from
11698 ComputeNamespaceForAlias.
11699 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
11701 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11703 * anonymous.cs (AnonymousContainer): Don't crash when container
11706 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11708 * expression.cs (Binary.DoResolve): Warn when comparing same
11711 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11714 * expression.cs (Binary.DoResolve): It looks like there are no
11715 convetsion rules in enum context.
11717 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11719 Add support for extern alias qualifiers.
11720 * typemanager.cs: Move some LookupTypeReflection code
11721 to namespace.cs, to have cleaner code. Added some methods
11722 to help us keep track of the extern aliased references.
11723 * driver.cs: Add suport for extern alias assemblies on command
11724 line and check for their warnings/errors. Also keep track of the
11725 extern aliased assemblies.
11726 * namespace.cs: Move the global functionality of Namespace
11727 to GlobalRootNamespace/RootNamespace. Now the global namespace
11728 is GlobalRootNamespace.Globa. Also the code moved from
11729 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
11730 Finally added LocalAliasEntry (AliasEntry before) and
11731 ExternAliasEntry, to handle alias statements.
11732 * cs-parser.jay: Add support in the grammar for extern alias
11734 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
11735 Update callings to Namespace (now in GlobalRootNamespace).
11737 2005-10-18 Raja R Harinath <rharinath@novell.com>
11740 * class.cs (TypeContainer.DefineType): Move updating of
11741 topological sort earlier in the code.
11742 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
11744 2005-10-18 Marek Safar <marek.safar@seznam.cz>
11747 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
11749 * constant.cs (Constant.TryReduce): Moved from Cast class.
11750 (Reduce): Made little bit more OO and fixed missing conversions.
11752 * ecore.cs (Reduce): Implemented.
11753 (Binary.EnumLiftUp): New method to upgrade values to enum values.
11755 * literal.cs (Reduce): Implemented.
11757 * class.cs: Reverted Miguel's wrong commit.
11759 2005-10-14 Miguel de Icaza <miguel@novell.com>
11761 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
11763 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
11765 * cs-parser.jay, expression.cs : CS0214 was missing error location
11766 for constants. Fixed bug #76404.
11768 2005-10-11 Marek Safar <marek.safar@seznam.cz>
11771 * convert.cs (ExplicitConversionCore): Fixed object->enum
11774 2005-10-10 Raja R Harinath <rharinath@novell.com>
11776 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
11777 InstanceExpression.
11778 (PropertyExpr.EmitCall): Likewise.
11779 * expression.cs (Invocation.EmitArguments): Handle case where
11781 (Invocation.EmitCall): Avoid allocating temporary variable if
11782 there are no arguments.
11784 2005-10-07 Raja R Harinath <rharinath@novell.com>
11787 * convert.cs (ImplicitConversionStandard): Move conversion of
11788 void* to arbitrary pointer types ...
11789 (ExplicitConversionStandard): .. here.
11790 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
11791 error to always print typenames.
11793 2005-10-07 Raja R Harinath <rharinath@novell.com>
11795 * convert.cs (GetConversionOperator): Rename from
11796 GetConversionOperators. Move operator selection code from ...
11797 (UserDefinedConversion): ... here.
11799 2005-10-06 Marek Safar <marek.safar@seznam.cz>
11801 * convert.cs (ExplicitConversionCore): Removed duplicate enum
11804 2005-10-05 Marek Safar <marek.safar@seznam.cz>
11806 * assign.cs (Assign.DoResolve): Error method changed.
11808 * cfold.cs (DoConstantNumericPromotions): Error method changed.
11810 * const.cs (ResolveValue): Reset in_transit immediately.
11812 * constant.cs: Error method changed.
11814 * convert.cs: Removed useless location parameter.
11815 (ExplicitNumericConversion): Don't do double enum check.
11816 (ExplicitConversionCore): Renamed from ExplicitConversion.
11817 (ExplicitUnsafe): Extracted from ExplicitConversion.
11818 (ExplicitConversion): Uses for error reporting.
11820 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
11822 (ResolveBoolean): Uses common error method.
11823 (CastToDecimal): Get rid of ec.
11824 (CastFromDecimal): Optimized.
11825 (ConvCast): Get rid of ec.
11827 * enum.cs (ResolveValue): Reset in_transit immediately.
11828 (Emit): Return after first error.
11830 * expression.cs: Convert changes.
11832 * literal.cs: Error method changed.
11834 * statement.cs: Error method changed.
11836 2005-10-03 Raja R Harinath <rharinath@novell.com>
11838 * support.cs (SeekableStreamReader.Position): Don't error out when
11839 the requested position is just beyond the end of the current
11842 2005-09-28 Raja R Harinath <rharinath@novell.com>
11844 * support.cs (SeekableStreamReader): Simplify drastically. Don't
11845 try to keep in sync with the byte count of the underlying Stream.
11846 However, this limits us to a window size of 2048 characters: i.e.,
11847 the maximum lookahead of our lexer/parser can be 2048 characters.
11849 2005-09-28 Marek Safar <marek.safar@seznam.cz>
11852 * driver.cs: Fix compilation files with full root path.
11854 2005-09-25 Miguel de Icaza <miguel@novell.com>
11856 * report.cs (SymbolRelatedToPreviousError): Format the output so
11857 it does not use an open parenthesis that is never closed.
11859 * driver.cs: Follow coding guidelines
11861 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11864 * const.cs (Const.ResolveValue): Check for assigning non-null
11865 value to reference type.
11867 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11869 * anonymous.cs: Implemented ExprClassName.
11871 * assign.cs (Assign.DoResolve): Don't chrash when type is not
11874 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
11877 * class.cs (StaticClass.DefineContainerMembers): Report protected
11880 * codegen.cs: if(ed) PRODUCTION.
11882 * convert.cs (Error_CannotImplicitConversion): Better error
11885 * cs-parser.jay: More error checks.
11887 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
11889 * driver.cs (CSCParseOption): Enabled wrong option check.
11891 * ecore.cs (Expression.ExprClassName): Turned to property.
11892 (MemberExpr.CheckIntermediateModification): For checking boxed
11893 value types modification.
11895 * statement.cs (Fixed.Resolve): Expression type must be
11896 convertible to fixed type.
11897 (CollectionForeach.GetEnumeratorFilter,TryType):
11898 Small refactoring for easier error checking.
11900 2005-09-26 Marek Safar <marek.safar@seznam.cz>
11902 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
11905 * class.cs (GeneratedBaseInitializer): New class for customization
11906 compiler generated initializers.
11907 (MemberBase.DoDefine): Check Obsolete attribute here.
11908 (FieldMember.DoDefine): Ditto.
11910 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
11913 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
11914 (MemberCore.GetObsoleteAttribute): Removed argument.
11915 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
11916 (MemberCore.CheckObsoleteType): New helper.
11920 * statement.cs: Updates after MemberCore changes.
11922 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
11923 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
11925 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
11926 obsolete attribute for compiler construct.
11927 (As.DoResolve): Cache result.
11929 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
11931 2005-09-26 Raja R Harinath <rharinath@novell.com>
11934 * expression.cs (This.VerifyFixed): In a value type T, the type of
11935 'this' is T&, iow, 'this' is either an out or ref parameter. In a
11936 value type R, 'this' is treated as a value parameter.
11938 2005-09-22 Miguel de Icaza <miguel@novell.com>
11940 * statement.cs (Lock): Use the TemporaryVariable class instead of
11941 manually using local variables as those do not work when variables
11944 * ecore.cs: Moved the TemporaryVariable class from being a nested
11945 class inside Foreach to be a public class that can be employed in
11948 2005-09-19 Marek Safar <marek.safar@seznam.cz>
11950 * cs-parser.jay: interface_accessors replaced by
11951 accessor_declarations.
11953 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
11956 * statement.cs (GotoCase.Resolve): Convert null constant to
11958 (SwitchLabel.ResolveAndReduce): Ditto.
11959 (SwitchLabel.NullStringCase): Custom null stamp.
11960 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
11962 typemanager.cs (CSharpSignature): Don't skip first argument
11965 2005-09-18 Miguel de Icaza <miguel@novell.com>
11967 * driver.cs: Set InEmacs based on the environment variable EMACS.
11969 * location.cs (InEmacs): in this mode, do not report column
11970 location as it confuses Emacs.
11972 2005-09-16 Marek Safar <marek.safar@seznam.cz>
11974 * cfold.cs, constant.cs, convert.cs, ecore.cs,
11975 expression.cs, iterators.cs, literal.cs: Store constants and
11978 * class.cs (MemberBase.ShortName): Pass location.
11980 * cs-parser.jay: Some location fixes.
11982 * ecore.cs (Expression.Location): Made virtual.
11984 2005-09-05 Miguel de Icaza <miguel@novell.com>
11986 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
11987 if the underlying types are the same, otherwise we need to produce
11988 code that will do the proper cast.
11990 This was exposed by Marek's constant rewrite which produced
11991 invalid code for the call site:
11993 enum X : long { a }
11994 void Method (X v) {}
11998 This fixes test-49.cs
12000 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12002 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12003 Type/Object should be allowed as well. Fixed bug #75968.
12005 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12007 * expression.cs : (Binary.DoResolve): when one is enum constant and
12008 another is constant 0, then return enum one *as enum type*.
12011 2005-09-02 Raja R Harinath <rharinath@novell.com>
12013 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12017 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12018 flow-branching for LocalVariableReferences in case we were invoked
12019 from a MemberAccess.
12020 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12022 (LocalVariableReference.DoResolveBase): ... this.
12023 (MemberAccess.Resolve): Do the check that was disabled during
12026 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12029 (PartialContainer.Create): check abstract/sealed/static strictly
12030 but abstract/sealed can exist only at one side. Fixed bug #75883.
12032 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12035 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12036 specified, don't default to UnmanagedType.I4.
12038 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12040 * expression.cs : conditional operator should check possibly
12041 incorrect assign expression. Fixed bug #75946.
12043 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12045 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12046 Reverting the change. gmcs is much complex than mcs on this matter.
12048 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12050 * cs-tokenizer.cs : To read another token ahead of the actual
12051 consumption, use new SavedToken and cache token instead of moving
12052 back the stream with SeekableStreamReader (it seemed problematic).
12054 driver.cs : Thus use StreamReader directly.
12055 * support.cs : Thus removed SeekableStreamReader.
12057 2005-08-30 Raja R Harinath <rharinath@novell.com>
12060 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12061 (ScopeInfo.EmitScopeType): Use it to construct field names from
12062 names of captured locals.
12065 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12066 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12067 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12068 (ExplicitConversion): Remove enum cases already handled by
12069 implicit conversion. Move implicit conversion check to the beginning.
12070 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12071 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12072 Don't treat System.Enum as a struct.
12074 2005-08-30 Jb Evain <jbevain@gmail.com>
12076 * attribute.cs: handles as expression in parameters.
12078 2005-08-30 Raja R Harinath <rharinath@novell.com>
12081 * class.cs (TypeContainer.VerifyClsName): Don't use a
12082 PartialContainer when verifying CLS compliance.
12083 (AbstractPropertyEventMethod): Set Parent here, ...
12084 (PropertyMethod): ... not here.
12086 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12088 * attribute.cs : escaped attribute name should not be allowed to be
12089 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12091 2005-08-29 Raja R Harinath <rharinath@novell.com>
12094 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12095 when converting a long constant to unsigned long.
12096 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12097 detect where IsApplicable and VerifyArgumentsCompat disagree.
12099 2005-08-29 Raja R Harinath <rharinath@novell.com>
12100 and Carlos Alberto Cortez <carlos@unixmexico.org>
12103 * class.cs (TypeContainer.CanElideInitializer): New helper.
12104 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12105 can safely emitting the initializer of a field.
12107 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12109 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12110 allowed inside a switch (without loop). Fixed bug #75433.
12112 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12114 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12115 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12117 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12119 * driver.cs : kinda reverting the default encoding changes (not exact
12120 revert since I noticed that "codepage:reset" might not work fine).
12122 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12124 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12125 Location. Now getter and setter store location correctly.
12126 (errors/cs0111-12.cs now reports the expected location.)
12128 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12130 * driver.cs : Use default encoding on the environment.
12131 Removed (now that) extra parameter for SeekableStreamReader.
12132 * support.cs : (SeekableStreamReader) third .ctor() argument for
12133 StreamReader is not required (always true). preamble size could
12134 be acquired in simpler and safe way.
12136 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12138 * cs-parser.jay: report CS0642 at warning level 3
12139 and report CS0642 for an if else statement also
12140 fixes bug #74745. Patch by John Luke (and a bit
12142 Removed extra CS0642 warning check for "while",
12144 * statement.cs: In Block.Resolve(), CS0642 check
12145 is reimplemented to check a sequence of an empty
12146 statement and a block.
12148 Both fix bug #66777.
12150 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12152 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12153 detection until I fix it.
12155 * cs-tokenizer.cs: Changed error message.
12157 * cs-parser.jay: Fixed 2 error locations.
12159 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12160 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12163 * enum.cs (GetSignatureForError): Fixed.
12165 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12169 * typemanager.cs (RegisterProperty): Removed.
12171 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12173 2005-08-24 Raja R Harinath <rharinath@novell.com>
12176 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12177 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12179 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12181 * expression.cs : tiny fix is required for not warning positive ulong.
12184 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12186 * expression.cs : add CS0652 check for constant and integral
12187 expression. Fixed bug #53974.
12189 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12191 * expression.cs : in DoNumericPromotions(), check if there is implicit
12192 conversion overload for string (to check CS0034). Fixed bug #52492.
12194 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12196 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12198 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12200 * ecore.cs : report location when it is *not* Null.
12202 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12208 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12209 correctly. Fixed bug #75721.
12211 2005-08-23 Raja R Harinath <rharinath@novell.com>
12213 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12214 loop that performs 'min (pos, char_count)'.
12217 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12218 converted value in Operator.OnesComplement.
12220 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12222 * anonymous.cs: If the anon method is pulled into a helper class,
12223 it needs to be `internal' not `private'. Fixes runtime behavior on
12226 2005-08-20 Martin Baulig <martin@ximian.com>
12228 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12229 scope if we don't already have it.
12231 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12232 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12235 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12238 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12239 is a partial class.
12241 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12243 The big constants rewrite
12244 Fix #75746, #75685 and more
12245 As a side effect saved 1MB for MWF ;-)
12247 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12248 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12249 enum based for corlib compilation.
12251 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12254 * class.cs (FixedField.Define): Use ResolveAsConstant.
12256 * const.cs (IConstant): Interface constants and enums.
12257 (Const.ResolveValue): New method for constant resolvning.
12258 (ExternalConstant): Constants from imported assemblies.
12260 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12261 conversion; like enums.
12262 (Constant.ToType): Converts this constant to different type.
12263 (Constant.Increment): Adds 1.
12265 * convert.cs (ImplicitConversionRequired): Simplified.
12267 * cs-parser.jay: Create EnumMember directly.
12269 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12271 * doc.cs (GenerateEnumDocComment): Removed.
12273 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12274 (ConvertIntLiteral): Removed.
12275 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12277 * enum.cs (EnumMember): Implement IConstant.
12278 (Enum.IsValidEnumConstant): Removed.
12279 (Enum.GetNextDefaultValue): Removed.
12280 (Enum.FindMembers): Updated.
12281 (Enum.GenerateDocComment): Iterate enum members.
12283 * expression.cs (Cast.TryReduce): Handle enums correctly.
12284 (New.Constantify): Made public.
12285 (MemberAccess.DoResolve): Removed contant specific if(s).
12287 * literal.cs (NullLiteral): Implement new abstract methods.
12289 * statement.cs (GotoCase.Resolve): Use new constant methods.
12290 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12292 * typemanager.cs (LookupEnum): Removed.
12293 (IsEnumType): Fixed to work with corlib.
12294 (RegisterConstant): Removed.
12295 (LookupConstant): Removed.
12296 (GetConstant): Changed to work with IConstant.
12298 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12300 * location.cs : Fixed overflown (>255) column number.
12302 2005-08-03 Raja R Harinath <rharinath@novell.com>
12304 First cut of the qualified-alias-member feature.
12305 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12307 * cs-parser.jay (DOUBLE_COLON): New token.
12308 (namespace_or_type_name): Add rule for recognizing
12309 qualified-alias-members.
12310 (primary_expression): Likewise.
12311 (element_access): Allow QualifiedAliasMember as a possible
12312 type-bearing expression.
12313 (local_variable_type, local_variable_pointer_type): Likewise.
12314 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12315 aliases in the current and enclosing namespace declarations.
12316 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12317 * decl.cs (MemberName.is_double_colon): New.
12318 (MemberName.MemberName): Add new constructor for alias-member.
12319 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12320 * expression.cs (QualifiedAliasMember): New expression type.
12322 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12324 * location.cs : it borked when no argument was specified.
12326 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12328 * location.cs : tiny ToString() format fix.
12330 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12332 * statement.cs : oops, it was missing.
12334 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12336 A set of fixes for precise line/column location.
12339 "token" field now holds a file/line "delta", a line number offset
12340 from the segment, and a column number. See also:
12341 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12342 December/009508.html
12343 Removed static IsNull. Use instance IsNull property instead.
12344 * cs-tokenizer.cs :
12345 For some tokens it stores Location. For Identifier it stores
12346 LocatedToken which is a pair of string name and location.
12347 Column numbers are adjusted only at getChar().
12349 Use Location.ToString() for reporting (it now contains column).
12351 Largely modified to use LocatedToken instead of
12352 string (IDENTIFIER), and to acquire Location from some tokens.
12353 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12354 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12356 Now MemberName holds Location. DeclSpace.ctor() receives Location
12357 as a parameter. Removed extra parameters to all derived classes.
12358 Replaced Location.IsNull() with instance property.
12359 * assign.cs, expression.cs :
12360 Added .ctor() overload that omits Location.
12362 Added "nameEscaped" flag that indicates the identifier was escaped
12363 in the source file. This fixes bug #57047.
12365 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12367 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12368 New method, looking for lo-case imported cls type.
12370 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12373 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12375 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12377 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12378 all_imported_types.
12379 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12381 Optimized to save 3.5 MB for SWF compilation.
12383 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12385 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12386 (PartialContainer.Create): Moved logic AddToContainer.
12387 (PartialContainer.MarkForDuplicationCheck): Shares name.
12389 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12392 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12394 (Namespace.GetSignatureForError): New method.
12396 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12397 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12399 2005-08-01 Raja R Harinath <rharinath@novell.com>
12402 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12403 member lookup rather than qualifier_type, since qualifier_type can
12406 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12408 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12411 2005-07-31 Miguel de Icaza <miguel@novell.com>
12413 * statement.cs: Copy the local exception into the exception
12414 captured local. Fixes 75674
12416 2005-07-31 Raja R Harinath <harinath@gmail.com>
12419 * expression.cs (Invocation.OverloadResolve): Don't report error
12420 CS1501 if error CS1502 has been reported.
12421 (New.DoResolve): Delegate CS1501 reporting to
12422 Invocation.OverloadResolve.
12425 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12426 invariant-meaning-in-block property in an enclosing block if
12429 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12431 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12432 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12433 (Switch.CheckSwitch): Just save 50kb for SWF.
12435 2005-07-27 Martin Baulig <martin@ximian.com>
12437 * anonymous.cs (CaptureContext.AddField): Added
12438 `AnonymousContainer am' argument; compute its toplevel scope if
12439 it's not already computed. Fixes #75649.
12441 2005-07-26 Raja R Harinath <rharinath@novell.com>
12444 * class.cs (Constructor.Emit): Reset block to null if the block
12447 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12449 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12451 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12453 * class.cs (MethodData.Define): Check whether accessor implementing
12454 interface is public.
12456 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12458 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12461 * namespace.cs (LookupType): Moved same type check to...
12463 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12464 with the same name.
12466 2005-07-21 Raja R Harinath <rharinath@novell.com>
12468 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12469 already found a typebuilder.
12470 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12471 MemberNames, not strings.
12473 * const.cs (Error_ExpressionMustBeConst):
12474 Rename from Error_EpressionMustBeConst.
12475 * const.cs, class.cs, statement.cd: Update.
12477 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12481 * const.cs (Const.LookupConstantValue): Report missing contant expression
12483 (Error_EpressionMustBeConstant): Only one error method.
12485 * class.cs, statement.c: Updated.
12487 2005-07-20 Raja R Harinath <rharinath@novell.com>
12489 * statement.cs (Block.Flags): Add back HasVarargs.
12490 (Block.flags): Make protected.
12491 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12493 * typemanager.cs (types, typecontainers, user_types): Remove.
12494 (UserTypes, TypeContainers): Likewise.
12495 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12496 (CleanUp, Reset): Update.
12497 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12498 (GetNestedType): Use Type.GetNestedType.
12499 (CoreLookupType): Take two arguments, the namespace and the
12500 basename of the type. Update to use the Namespace.Lookup
12502 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12503 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12504 string concatenation and substring matches.
12505 * class.cs, enum.cs, delegate.cs: Update to changes.
12507 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12509 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12510 Expression and made virtual.
12512 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12513 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12515 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12517 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12520 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12523 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12526 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12527 AssemblyCultureAttribute is not used on executable.
12530 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12532 2005-07-16 Raja R Harinath <rharinath@novell.com>
12535 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12536 New. Reports CS0252/CS0253.
12537 Mostly taken from preliminary patch by Duncak Mak.
12538 (Binary.DoResolveOperator): Store results of operator lookup.
12539 Use them to detect if we need to warn about unintended reference
12542 2005-07-15 Raja R Harinath <rharinath@novell.com>
12545 * namespace.cs (Namespace.Lookup): Add back location parameter.
12546 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12547 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12549 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12550 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12551 (Namespace.LookupType): ... this.
12552 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12554 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12555 purported to handle pointers.
12556 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12559 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12561 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12564 2005-07-15 Raja R Harinath <rharinath@novell.com>
12566 * namespace.cs (Namespace.Lookup): Drop location parameter.
12567 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12568 (NamespaceEntry.Lookup): ... this.
12569 (NamespaceEntry.Error_AmbiguousTypeReference):
12570 Move here from DeclSpace.
12571 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12573 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12574 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12575 Move to NamespaceEntry.
12576 * delegate.cs, expression.cs: Update to changes.
12578 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12580 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12581 CheckAttributeType and refactored.
12582 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12583 ResolveAsTypeTerminal error handling.
12584 (ResolveAsTypeTerminal): Introduced because of global attributes extra
12586 (GetSignatureForError): Print errors in same way.
12589 * codegen.cs: Reflect attribute GetSignatureForError change.
12592 * expression.cs: Add silent parameter to ResolveAsTypeStep.
12594 * namespace.cs (UsingEntry): Refactored to make fields private.
12597 statement.cs: Error_UnexpectedKind has extra parameter.
12599 2005-07-14 Raja R Harinath <rharinath@novell.com>
12601 * ecore.cs (IAlias): Remove.
12602 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
12603 that implement the interface.
12604 * namespace.cs (Namespace): Likewise.
12605 (Namespace.declspaces): Renamed from 'defined_names'.
12606 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
12607 DeclSpace instead of an IAlias.
12608 * tree.cs (Tree.AddDecl): Update.
12610 2005-07-12 Raja R Harinath <rharinath@novell.com>
12612 * statement.cs (Block.Flags); Remove HasVarargs.
12613 (Block.HasVarargs): Move to ToplevelBlock.
12614 (Block.ThisVariable, Block.AddThisVariable): Likewise.
12615 (Block.Variables): Make protected. Initialize variable hashtable
12617 (Block.AddVariable): Update.
12618 (Block.Resolve): Update to changes.
12619 (ToplevelBlock.HasVarargs): New boolean.
12620 (ToplevelBlock.ThisVariable): Move here from Block.
12621 (ToplevelBlock.AddThisVariable): Likewise.
12622 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
12623 * expression.cs (This.ResolveBase): Update to changes.
12624 (ArglistAccess.DoResolve): Likewise.
12626 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12629 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
12631 * class.cs (TypeContainer.VerifyMembers): Distinguish between
12632 not used and not used & assigned.
12633 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
12635 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12638 * expression.cs (Is.DoResolve): null is never provided type.
12640 2005-07-08 Marek Safar <marek.safar@seznam.cz>
12643 * cs-parser.jay: Less strict event error rule to catch more errors.
12645 2005-07-08 Martin Baulig <martin@ximian.com>
12647 Fix test-iter-10.cs - distinguish whether we `yield' in a property
12648 gettter (allowed) or setter (not allowed).
12650 * class.cs (Accessor): Implement IIteratorContainer.
12651 (Accessor.Yields): New public field.
12652 (PropertyBase.PropertyMethod.Define): Handle iterators on a
12653 per-accessor basis.
12656 (get_accessor_declaration, set_accessor_declaration): Set the
12657 `yields' flag on the accessor, not the property.
12658 (property_declaration): Do the iterators check on a per-accessor
12659 basis and not for the whole property.
12661 2005-07-08 Martin Baulig <martin@ximian.com>
12663 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
12664 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
12666 2005-07-07 Marek Safar <marek.safar@seznam.cz>
12669 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
12670 (ExtractSecurityPermissionSet): Cope with self referencing security
12671 attributes properly.
12673 * driver.cs (SetOutputFile): Made public property OutputFile.
12675 2005-07-07 Raja R Harinath <rharinath@novell.com>
12678 * class.cs (TypeContainer.first_nonstatic_field): Rename from
12679 has_nonstatic_fields. Make into a FieldBase pointer.
12680 (TypeContainer.AddField): Add CS0282 check.
12681 (TypeContainer.EmitType): Update.
12683 2005-07-06 Miguel de Icaza <miguel@novell.com>
12685 * cs-tokenizer.cs (consume_identifier): Do not create strings to
12686 compare if they start with __.
12688 2005-07-06 Raja R Harinath <rharinath@novell.com>
12690 * statement.cs (Switch.SwitchGoverningType): Only look at
12691 UserCasts that don't need implicit standard conversions to one of
12692 the allowed switch types (Fixes test-322.cs).
12693 (LocalInfo.Resolve): Re-enable sanity-test.
12695 2005-07-06 Marek Safar <marek.safar@seznam.cz>
12697 * cs-tokenizer.cs (consume_identifier): Detect double undescores
12699 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
12701 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
12703 2005-07-06 Raja R Harinath <rharinath@novell.com>
12706 * ecore.cs (SimpleName.GetSignatureForError): Add.
12707 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
12708 (MemberAccess.GetSignatureForError): Add.
12710 2005-07-05 Marek Safar <marek.safar@seznam.cz>
12712 The big error and warning messages review.
12742 * typemanager.cs: Updated.
12744 * class.cs: (MethodCore.SetYields): Moved here to share.
12745 (PropertyMethod.Define): Moved iterator setup here.
12747 * iterators.cs: Add orig_method to have full access to parent
12750 2005-07-05 Raja R Harinath <rharinath@novell.com>
12752 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
12753 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
12754 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
12755 variable of struct type.
12756 * expression.cs (Unary.ResolveOperator): Update to change.
12757 (Indirection.VerifyFixed): Likewise.
12758 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
12759 (ParameterReference.VerifyFixed): Value parameters are fixed.
12760 (This.VerifyFixed): Treat 'this' as a value parameter.
12761 * statement.cs (LocalInfo.IsFixed): Remove.
12763 2005-07-01 Martin Baulig <martin@ximian.com>
12765 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
12766 `ec.EmitThis ()' to get the correct scope.
12768 2005-07-01 Martin Baulig <martin@ximian.com>
12770 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
12771 instance is a ParameterReference; fixes #75299.
12773 2005-07-01 Martin Baulig <martin@ximian.com>
12775 Reverted Marek's latest patch (r46725):
12776 - it contains structural changes which are neither mentioned in
12777 the ChangeLog nor explained anywhere; for example the additional
12778 argument of EmitContext's and Iterator's .ctor's and the
12779 TypeContainer.DefineMembers() change.
12780 - structural changes like this should go in in seperate patches
12781 and not be hidden in a huge patch which just seems to affect
12782 warnings and errors.
12783 a big and hard to understand patch.
12784 - it breaks iterators and causes regressions, for instance in
12787 2005-06-30 Raja R Harinath <rharinath@novell.com>
12790 * expression.cs (Indexers.map): Remove.
12791 (Indexers.Append): Filter out inaccessible setters and getters.
12792 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
12795 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
12796 Refactored from ...
12797 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
12798 (FieldExpr.Emit, PropertyExpr.Emit): Update.
12799 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
12800 * expression.cs (Invocation.EmitCall): Add CS0120 check.
12802 2005-06-30 Marek Safar <marek.safar@seznam.cz>
12805 * class.cs (FieldBase.GetInitializerExpression): One more field
12808 2005-06-28 Miguel de Icaza <miguel@novell.com>
12810 * pending.cs: Do not define a proxy if the base method is virtual,
12811 it will be picked up by the runtime (bug 75270).
12813 2005-06-08 Martin Baulig <martin@ximian.com>
12815 The big Iterators rewrite :-)
12817 * iterators.cs: Rewrite this to use the anonymous methods framework.
12819 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
12820 before the TypeContainers; see 2test-21.cs.
12823 (TypeContainer.DefineType): Don't create a new EmitContext if we
12824 already have one (this only happens if we're an Iterator).
12825 (TypeContainer.Define): Also call Define() on all our iterators.
12826 (Method.CreateEmitContext): Added support for iterators.
12829 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
12830 (AnonymousContainer.CreateMethodHost): Moved here from
12831 AnonymousMethod and made abstract.
12832 (AnonymousContainer.CreateScopeType): New abstract method.
12833 (AnonymousContainer.IsIterator): New public property.
12834 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
12835 get the ScopeTypeBuilder rather than manually defining it here.
12836 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
12839 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
12840 before RootContext.DefineTypes().
12842 * codegen.cs (EmitContext.RemapToProxy): Removed.
12843 (EmitContext.CurrentAnonymousMethod): Changed type from
12844 AnonymousMethod -> AnonymousContainer.
12845 (EmitContext.ResolveTopBlock): Protect from being called twice.
12846 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
12847 (EmitContext.EmitThis): Removed the iterators hacks; use the
12848 anonymous methods framework for that.
12851 (ToplevelBlock.Container): Make this a property, not a field.
12852 (ToplevelBlock.ReParent): New public method; move the
12853 ToplevelBlock into a new container.
12854 (Foreach.TemporaryVariable): Simplify.
12856 2005-06-05 Martin Baulig <martin@ximian.com>
12858 * statement.cs (LocalInfo.CompilerGenerated): New flag.
12859 (Block.AddTemporaryVariable): New public method; creates a new
12860 `LocalInfo' for a temporary variable.
12861 (Block.EmitMeta): Create the LocalBuilders for all the temporary
12863 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
12864 non-iterator variables.
12866 2005-06-05 Martin Baulig <martin@ximian.com>
12868 * statement.cs (Foreach.TemporaryVariable): Create the
12869 LocalBuilder in the Emit phase and not in Resolve since in some
12870 situations, we don't have an ILGenerator during Resolve; see
12871 2test-19.cs for an example.
12873 2005-06-04 Martin Baulig <martin@ximian.com>
12875 **** Merged r45395 from GCS ****
12877 The big Foreach rewrite - Part II.
12879 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
12880 with `PropertyInfo ienumerator_getcurrent'.
12882 * codegen.cs (VariableStorage): Removed.
12885 (Foreach): Derive from Statement, not ExceptionStatement.
12886 (Foreach.CollectionForeach): New nested class. Moved all the code
12887 dealing with collection foreach here.
12888 (Foreach.ForeachHelperMethods): Removed.
12889 (Foreach.TemporaryVariable): Implement IMemoryLocation.
12891 2005-05-23 Martin Baulig <martin@ximian.com>
12893 * statement.cs (Try.DoResolve): Don't create a `finally' if we
12894 don't need to. Fix #75014.
12896 2005-05-20 Martin Baulig <martin@ximian.com>
12898 Merged r44808 from GMCS.
12900 * class.cs (TypeContainer.CircularDepException): Removed.
12901 (TypeContainer.DefineType): Removed the `InTransit' stuff.
12902 (TypeContainer.CheckRecursiveDefinition): Check for circular class
12903 (CS0146) and interface (CS0529) dependencies here.
12905 2005-06-21 Raja R Harinath <rharinath@novell.com>
12907 * expression.cs (Invocation.EmitCall): Fix initialization
12908 'this_call' to reflect current behaviour. Fix indentation.
12910 * convert.cs (FindMostEncompassedType): Add two trivial special
12911 cases (number_of_types == 0 || number_of_types == 1).
12912 (FindMostEncompasingType): Likewise.
12914 2005-06-17 Raja R Harinath <rharinath@novell.com>
12916 Some cleanups preparing for the fix of #75283.
12917 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
12919 (EventExpr.InstanceResolve): Likewise.
12920 (EventExpr.DoResolve): Remove redundant checks.
12922 2005-06-10 Duncan Mak <duncan@novell.com>
12924 * cs-tokenizer.cs (process_directives): New flag for controlling
12925 the processing of preprocessor directives.
12926 (x_token): After seeing a '#', return Token.NONE instead of going
12927 to handle_preprocessing_directive() when not processing
12928 directives. This avoids unnecessary processing during the token peek in
12933 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
12934 the existing error reporting methods instead of Report.Error.
12936 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
12937 after Raja's rewrite.
12939 2005-06-08 Miguel de Icaza <miguel@novell.com>
12941 * class.cs: Small fix.
12943 2005-06-08 Raja R Harinath <rharinath@novell.com>
12946 * class.cs (GetPartialBases): Fix return value check of
12947 part.GetClassBases.
12949 2005-06-07 Raja R Harinath <rharinath@novell.com>
12951 Ensure that partial classes are registered in their enclosing
12952 namespace. Initial part of fix of #75160.
12953 * tree.cs (Tree.RecordDecl): Add new namespace argument.
12954 Register declspace with namespace here, not in
12955 DeclSpace.RecordDecl.
12956 * cs-parser.jay: Pass namespace to RecordDecl.
12957 * class.cs (PartialContainer.Create): Likewise.
12958 (ClassPart.DefineType): New sanity-check. Throws an exception if
12960 * decl.cs (Declspace.RecordDecl): Remove.
12961 * namespace.cs (NamespaceEntry.DefineName): Remove.
12963 2005-06-06 Marek Safar <marek.safar@seznam.cz>
12965 * rootcontext.cs: Reset TargetExt as well.
12967 2005-06-03 Raja R Harinath <rharinath@novell.com>
12969 * ecore.cs (Expression.Resolve): Emit CS0654 error when
12970 -langversion:ISO-1.
12972 2005-06-02 Raja R Harinath <rharinath@novell.com>
12974 Fix #75080, cs0119.cs.
12975 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
12977 (Expression.Resolve): ... this. Use it. Remove bogus code
12978 allowing ExprClass.Type and ExprClass.Namespace for
12979 ResolveFlags.VariableOrValue.
12980 (Expression.Resolve) [1-argument variant]: Change default resolve
12981 flags based on language version.
12982 (Expression.Error_UnexpectedKind): Use a simple string array
12983 rather than an ArrayList.
12984 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
12985 not ExprClass.Type.
12986 (TypeOfVoid.DoResolve): Likewise.
12987 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
12988 flags argument -- it always has the same value.
12990 2005-05-31 Raja R Harinath <rharinath@novell.com>
12993 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
12994 Use it in the error message.
12995 * assign.cs, expression.cs, statement.cs: Update.
12997 2005-05-30 Raja R Harinath <rharinath@novell.com>
13000 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13001 the "almostMatchedMember" case too.
13002 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13003 that failed the accessibility checks to 'almost_match'.
13005 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13007 * attribute.cs: Use internal MethodBuilder methods to set
13008 ExactSpelling and SetLastError on PInvoke methods, instead
13009 of passing them via charset. Fixes #75060.
13011 2005-05-27 Raja R Harinath <rharinath@novell.com>
13013 * parameter.cs (Parameter): Remove TODO comment.
13014 (Parameter.DefineParameter): Remove Location parameter.
13015 (Parameters.LabelParameters): Likewise.
13016 * class.cs (Constructor.Emit): Update to change.
13017 (MethodData.Emit): Likewise.
13018 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13019 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13021 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13024 Removed Parameters.Location and added Parameter.Location instead.
13025 Removed Location parameter from Emit() and GetSignature().
13032 Modified all related calls.
13034 2005-05-26 Raja R Harinath <rharinath@novell.com>
13036 Improve user-defined conversion handling.
13037 * convert.cs (GetConversionOperators): Rewrite. Return only the
13038 applicable operators.
13039 (AddConversionOperators): New. Helper for GetConversionOperators.
13040 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13041 there is only one most encompassed/encompassing type.
13042 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13043 "applicable operator" handling.
13044 (UserConversion): Move cache here from GetConversionOperators.
13045 Directly cache the chosen operator, rather than the whole
13047 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13048 case. Allow conversion of decimal to sbyte and byte too.
13049 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13050 New static methods. Used to avoid allocating EmptyExpressions in
13053 2005-05-24 Duncan Mak <duncan@novell.com>
13055 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13056 another class, used in Convert.ExplicitNumericConversion.
13057 (CastToDecimal): New class, similar to above, but casts to
13058 System.Decimal, used in Convert.ImplicitNumericConversion and also
13059 in explicit convesion from double/float to decimal.
13061 * convert.cs (ImplicitNumericConversion): Handle implicit
13062 conversions to System.Decimal.
13063 (ExplicitNumericConversion): handle explicit conversions to
13068 2005-05-20 Miguel de Icaza <miguel@novell.com>
13070 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13071 know the type at this stage, just break through. Fixes #75008
13073 2005-05-19 Martin Baulig <martin@ximian.com>
13076 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13077 to disable error reporting.
13079 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13080 here since we don't want to report an error; see the new test-336.cs.
13082 2005-05-19 Raja R Harinath <rharinath@novell.com>
13084 * statement.cs (ToplevelBlock.GetParameterReference)
13085 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13086 Move here from class Block.
13087 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13088 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13090 2005-05-18 Martin Baulig <martin@ximian.com>
13095 (FlowBranching.Reachability): Add non-static public And() and Or()
13097 (FlowBranchingSwitch): New class; do the `break_origins' thing
13098 like in FlowBranchingLoop.
13099 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13100 reachability, not just locals and parameters.
13101 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13102 switch; MergeBreakOrigins() now takes care of that.
13104 2005-05-18 Martin Baulig <martin@ximian.com>
13106 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13107 a loop and may leave it, reset the barrier; fixes #74974.
13109 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13111 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13114 * cs-parser.jay: Catch more lexical errors.
13116 * report.cs: Add one more Error method.
13119 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13121 2005-05-17 Martin Baulig <martin@ximian.com>
13123 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13126 2005-05-16 Raja R Harinath <rharinath@novell.com>
13128 Fix test-382.cs. Emit values of decimal constants.
13129 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13131 (TypeContainer.AddField): ... this.
13132 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13133 with initializers to include 'Const's.
13134 (ClassPart.RegisterFieldForInitialization): Forward to
13136 * const.cs (Const.Const): Pass initializer to base class.
13137 (Const.Define): In case of decimal constants, register them for
13138 initialization in a static constructor.
13140 2005-05-14 Martin Baulig <martin@ximian.com>
13142 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13143 do not call ResolveUnreachable() on unreachable statements in
13144 here, see the comment in the source code.
13146 2005-05-13 Raja R Harinath <rharinath@novell.com>
13149 * expression.cs (BinaryResolveOperator): If one of the operands of
13150 an equality comparison is 'null' and the other is a pointer type,
13151 convert the null to a NullPointer.
13152 * convert.cs (ImplicitReferenceConversion): If the expression is a
13153 NullLiteral and the target type is a pointer type, return a
13154 NullPointer instead.
13155 (ImplicitConversionStandard): Likewise.
13157 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13159 * cs-parser.jay: Set readonly context based on special constructs.
13161 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13162 readonly variable error handling.
13164 * rootcontext.cs (EmitCode): Don't verify members when error
13167 * statement.cs (LocalInfo): Add reaodnly context information.
13168 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13170 2005-05-13 Raja R Harinath <rharinath@novell.com>
13172 * statement.cs (Block.Resolve): Revert change below. Modify fix
13173 for #74041 to initialize 'resolved' to false only for explicit
13174 blocks. Fixes #74873.
13176 2005-05-12 Raja R Harinath <harinath@gmail.com>
13179 * typemanager.cs (unmanaged_enclosing_types): New.
13180 (IsUnmanagedType): Avoid infloops by using
13181 'unmanaged_enclosing_types' to talk with recursive invocations.
13183 2005-05-13 Martin Baulig <martin@ximian.com>
13185 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13186 instance variable, not a local. Fix #74873.
13187 (Block.ResolveUnreachable): Set it to true here.
13189 2005-05-11 Duncan Mak <duncan@novell.com>
13191 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13192 continuing to process for 'arg'.
13193 (handle_preprocessing_directive): Check the argument of the #endif
13194 directive and report error CS1025 if there are any trailing
13197 According to the C# spec, having even whitespace after the #endif
13198 directive is illegal; however, because we call arg.TrimEnd ()
13199 beforehand, we have the same behavior as csc, allowing whitespace
13200 after the directive.
13204 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13208 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13209 (Constructor.GetObsoleteAttribute): Implemented correctly.
13211 2005-05-10 Martin Baulig <martin@ximian.com>
13213 * support.cs (ReflectionParameters.ParameterModifier): Use
13214 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13215 and `ParameterAttributes.In'. Fixes #74884.
13217 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13219 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13221 * expression.cs (Argument.GetParameterModifier): Turned to property.
13222 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13224 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13227 2005-05-09 Raja R Harinath <rharinath@novell.com>
13230 * decl.cs (MemberCache.AddMethods): Register override methods,
13231 rather than non-override methods.
13232 * typemanager.cs (RegisterOverride): New.
13233 (IsOverride): Update.
13235 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13239 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13240 recursive declaration.
13242 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13244 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13246 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13248 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13250 2005-05-05 Raja R Harinath <rharinath@novell.com>
13253 * decl.cs (DeclSpace.FamilyAccessible):
13254 Use TypeManager.IsNestedFamilyAccessible.
13256 Fix reopened #64812.
13257 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13260 2005-05-04 Raja R Harinath <rharinath@novell.com>
13261 Abin Thomas <projectmonokochi@rediffmail.com>
13262 Anoob V E <projectmonokochi@rediffmail.com>
13263 Harilal P R <projectmonokochi@rediffmail.com>
13266 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13267 allow access to all static members.
13269 2005-05-04 Martin Baulig <martin@ximian.com>
13271 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13273 2005-05-04 Martin Baulig <martin@ximian.com>
13277 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13278 section at the end; make things work if `default' is not the last
13281 2005-05-04 Martin Baulig <martin@ximian.com>
13285 * statement.cs (Switch): Replaced the `got_default' field with a
13286 `default_section' one.
13287 (Switch.CheckSwitch): Set `default_section' here.
13288 (Switch.Resolve): If we're a constant switch and the constant is
13289 not found, use the default section.
13291 2005-05-03 Martin Baulig <martin@ximian.com>
13293 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13295 * statement.cs (Foreach.ArrayForeach): New nested class.
13296 (Foreach.TemporaryVariable): New nested class.
13297 (Foreach.EmitArrayForeach): Removed; this is now in the new
13298 ArrayForeach class.
13300 2005-05-03 Raja R Harinath <rharinath@novell.com>
13302 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13304 (VerifyPendingMethods): Revert change below.
13306 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13307 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13308 that used to trigger warning -28. Remove warning -28.
13309 * expression.cs (Invocation.OverloadResolve): Use
13310 TypeManager.IsOverride to distinguish override methods.
13313 * pending.cs (VerifyPendingMethods): If a base type implements the
13314 requested interface, don't bother checking individual methods of
13315 the base type. As a side-effect, this prevents the creation of
13316 unnecessary proxies.
13318 2005-05-02 Martin Baulig <martin@ximian.com>
13322 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13323 Also `And' the locals if the old vector is null.
13324 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13325 null; in this case we basically reset all the variables.
13327 2005-05-02 Martin Baulig <martin@ximian.com>
13331 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13332 Added `FlowBranching branching' argument; always `and' the
13333 variables instead of `or'ing them unless we're an infinite loop.
13335 * statement.cs (While.Resolve): Create a new sibling unless we're
13338 2005-05-02 Martin Baulig <martin@ximian.com>
13342 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13343 arguments; use it instead of creating a new TopLevelBlock.
13344 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13345 our ConstructorInitializer.
13348 (TopLevelBlock.TopLevelBranching): New public property.
13349 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13350 and create our `TopLevelBranching'.
13352 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13353 anonymous method host, use `block.TopLevelBranching' rather than
13354 creating a new branching.
13356 2005-04-20 Miguel de Icaza <miguel@novell.com>
13358 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13359 a ScopeInfo, if any of the current children is a child of the new
13360 entry, move those children there.
13362 2005-04-30 Martin Baulig <martin@ximian.com>
13364 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13365 at the beginning of a SwitchSection. Fix #73335.
13367 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13370 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13372 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13373 (FieldExpr.DoResolve): Obsolete members are ignored for field
13376 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13378 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13379 of arrays detection.
13381 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13383 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13385 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13388 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13390 * cs-parser.jay: Use the prefered version of -unsafe in error
13393 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13395 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13398 2005-04-20 John Luke <john.luke@gmail.com>
13400 * driver.cs: fix typo in error message, --outout to --output
13402 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13404 * codegen.cs (InRefOutArgumentResolving): New field.
13406 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13407 fields outside contructor.
13409 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13411 2005-04-19 Miguel de Icaza <miguel@novell.com>
13413 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13414 parameter code was not completed ever, so it was not as up-to-date
13415 as local variables. Must finish it.
13417 The bug fix was to compare the Toplevel of the block, not the
13418 current block. Thanks for Ben for pointing this out.
13420 2005-04-19 Raja R Harinath <rharinath@novell.com>
13422 * decl.cs (AddMethods): Use the declaring type of the problem
13423 method to determine if we want to squash a warning.
13425 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13427 * attribute.cs: Removed debug output.
13429 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13431 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13434 2005-04-18 Raja R Harinath <rharinath@novell.com>
13437 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13438 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13439 all null comparisons against reference types.
13441 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13444 * class.cs (TypeContainer.CircularDepException) New nested
13446 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13447 (TypeContainer.DefineType): Removed error, reset InTransit before
13449 (Class.DefineType): Throw exception when is in Transit.
13450 Catch exception and report error.
13451 (Struct.DefineType): Throw exception when is in Transit.
13452 Catch exception and report error.
13453 (Interface.DefineType): Throw exception when is in Transit.
13454 Catch exception and report error.
13456 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13457 handle nested exception handlers.
13459 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13462 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13463 InFinally and InCatch storage.
13465 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13466 (Catch.Resolve): Set and Restore ec.InCatch.
13467 (Try.Resolve): Set and Restore ec.InFinally.
13468 (Try.HasCatch): True when try has catch.
13470 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13472 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13473 for the same event member, so exclude such cases from warning 419.
13476 2005-04-16 Miguel de Icaza <miguel@novell.com>
13478 * expression.cs (Binary.ResolveOperator): Apply patch from John
13479 Luke to fix bug 59864: operators &, | and ^ on enumerations
13480 require that the same enum type on both sides.
13482 * driver.cs: Add warnings to old flag usage, this is to assist
13483 people who produce Makefiles and hope that the Makefiles will be
13486 * class.cs (TypeContainer.EmitType): Moved the definition of the
13487 special $PRIVATE$ field from the resolve phase to the Emit phase.
13488 During resolve we do not know if we are a struct with
13489 HasExplicitLayout, we know this only after the attributes for the
13492 Set the FieldOffset to zero on the dummy field that we create for
13493 the class. Fixes 74590.
13495 2005-04-16 Raja R Harinath <rharinath@novell.com>
13498 * ecore.cs (PropertyExpr.resolved): New.
13499 (DoResolve): Use it to handle a case of double resolution here.
13500 Handle a case of identical-name-and-type-name.
13501 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13502 resolution by storing the results of expression resolution back
13503 into the "probes" array.
13505 2005-04-15 Raja R Harinath <rharinath@novell.com>
13507 Fix cs0208-7.cs and cs0208-8.cs.
13508 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13509 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13510 error reporting to point out the reason a struct is not unmanaged.
13512 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13514 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13515 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13517 2005-04-13 Raja R Harinath <rharinath@novell.com>
13520 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13521 IdenticalNameAndTypeName here.
13522 (EventExpr.InstanceResolve): Likewise.
13524 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13526 C# 2.0 DefaultCharSetAttribute implementation
13528 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13529 which allows us to set GlobalNamespace for every resolve.
13530 (Attribute.ResolveArguments): Cut from Resolve.
13531 (Attribute.GetCharSetValue): Returns CharSet named argument.
13532 (Attribute.DefinePInvokeMethod): Gets default charset from
13534 (GlobalAttribute.ResolveAsTypeStep): Override.
13535 (GlobalAttribute.ResolveArguments): Override.
13537 * class.cs (TypeAttr): Is protected.
13539 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13540 (ModuleClass.DefaultCharSetType): New memeber.
13541 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13543 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13544 charset from module.
13546 * delegate.cs (TypeAttr): Override.
13547 (Delegate.DefineType): Use this TypeAttr.
13549 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13550 at very early stage (before types are defined) to resolve model
13551 module attributes. It will probably not work with corlib but it
13554 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13555 charset from module.
13557 * typemanager.cs (default_charset_type): New type.
13559 2005-04-13 Raja R Harinath <rharinath@novell.com>
13561 * decl.cs (MemberCache.AddMethods): Don't warn if
13562 System.Object.Finalize has buggy MethodAttributes.
13564 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13567 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13569 * doc.cs : detect ambiguous reference to overloaded members.
13570 Fixed bug #71603. MS 1.1 csc does not detect it.
13572 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13574 * doc.cs : delegates must not be referenced with parameters.
13577 2005-04-12 Miguel de Icaza <miguel@novell.com>
13579 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13581 2005-04-10 Miguel de Icaza <miguel@novell.com>
13583 * driver.cs (MainDriver): Stop processing if the CLS stage found
13586 (CompilerCallableEntryPoint.InvokeCompiler): Always
13587 reset after execution; Take a TextWriter argument for the
13590 * report.cs: Use the error stream instead of hardcoding stderr.
13592 2005-04-09 Miguel de Icaza <miguel@novell.com>
13594 * class.cs: Reduce code paths to test, too small of an
13595 optimization to make it worth the extra testing. Always perform
13598 2005-04-08 Raja R Harinath <rharinath@novell.com>
13601 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
13602 operators that had errors reported on them.
13604 2005-04-08 Marek Safar <marek.safar@seznam.cz>
13606 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
13608 (Attribute.Resolve): Add named argument type checking.
13610 * class.cs (FixedField.Define): Use IsPrimitiveType
13612 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
13614 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
13615 unsafe parameter types.
13617 * statement.cs (Using.ResolveExpression): Add better error description.
13619 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
13621 2005-04-08 Raja R Harinath <rharinath@novell.com>
13624 * attribute.cs (Attribute.GetAttributeUsage): Resolve
13625 AttributeUsageAttribute in the emitcontext of the attribute class,
13626 not in the emitcontext of the attributable entity it was attached to.
13627 * cs-parser.jay: Use 'current_class', not 'current_container',
13628 when creating a GlobalAttribute.
13630 2005-04-08 Alp Toker <alp@atoker.com>
13632 * pending.cs: The fix to #58413 failed to compile methods implementing
13633 interfaces with/without params modifiers and vice versa, even though
13634 params modifiers aren't part of the signature. Make the modifier check
13635 less strict as in csc.
13637 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
13638 Anoob V E <projectmonokochi@rediffmail.com>
13639 Harilal P R <projectmonokochi@rediffmail.com>
13642 * pending.cs (TypeAndMethods.mods): New. Store the parameter
13643 modifiers of pending methods.
13644 (PendingImplementation.PendingImplementation): Initialize it.
13645 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
13646 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
13647 with ParameterData. Add check for modifiers.
13648 * class.cs (MethodData.Define): Update to changes.
13650 2005-04-07 Raja R Harinath <rharinath@novell.com>
13652 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
13654 2005-04-07 Marek Safar <marek.safar@seznam.cz>
13656 * class.cs (PropertyMethod.Define): Check private accessor in abstract
13659 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
13662 * typemanager.cs: Registered RequiredAttributeAttribute.
13664 2005-04-06 Marek Safar <marek.safar@seznam.cz>
13666 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
13667 Warning CS0169 is back at level 3.
13668 (IMethodData.SetMemberIsUsed): New method.
13670 * decl.cs (IsUsed): New value; moved from FieldBase.Status
13671 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
13673 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
13675 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
13677 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
13680 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
13683 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
13684 to avoid the problems with nested types.
13686 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
13687 Anoob V.E <projectmonokochi@rediffmail.com>
13688 Harilal P.R <projectmonokochi@rediffmail.com>
13689 Raja R Harinath <rharinath@novell.com>
13692 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
13694 * typemanager (GetConstructor): Make public.
13696 2005-04-05 John Luke <john.luke@gmail.com>
13697 Raja R Harinath <rharinath@novell.com>
13700 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
13701 struct too. Return false quicker in a few cases.
13702 (VerifyUnManaged): Use it.
13704 2005-04-05 Raja R Harinath <rharinath@novell.com>
13707 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
13708 not 'unreachable_seen'.
13710 2005-04-04 Marek Safar <marek.safar@seznam.cz>
13712 * attribute.cs (Attribute.GetValue): Removed unused.
13714 * codegen.cs (CodeGen.TrimExt): Removed unused.
13716 * cs-parser.jay (output): Removed unused.
13718 * cs-tokenizer.cs (hex_digits): Removed unused.
13720 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
13722 * expression.cs (Indirection.LoadExprValue): Removed unused.
13723 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
13725 * iterators.cs (Iterator.param_types): Removed unused.
13727 * statement.cs (Goto.block): Removed unused.
13728 (ToplevelBlock.did): Removed unused.
13729 (Switch.ResolveConstantSwitch): Removed unused.
13731 2005-04-01 Ben Maurer <bmaurer@ximian.com>
13733 * rootcontext.cs: Allow mcs to bootstrap with the compilation
13736 2005-04-01 Raja R Harinath <rharinath@novell.com>
13738 Fix #74232 and cs0208-3.cs.
13739 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
13740 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
13741 unmanaged type. Don't use FieldBuilders when 't' is a
13742 TypeBuilder. Use ModFlags and MemberType fields.
13743 * class.cs (MemberBase.member_type): Rename from MemberType.
13744 (MemberBase.MemberType): New property. Determines member_type on
13746 (MemberBase.DoDefine): Don't initialize MemberType here.
13747 (FieldMember.Define): Likewise.
13749 2005-04-01 Marek Safar <marek.safar@seznam.cz>
13752 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
13753 Attributes are emitted there.
13755 2005-04-01 Raja R Harinath <rharinath@novell.com>
13757 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
13758 keyword in 'partial enum' too.
13759 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
13761 Report from Kamil Skalski <nazgul@omega.pl>.
13764 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
13765 have partial containers too.
13767 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
13768 in block' checks to Block.CheckInvariantMeaningInBlock.
13769 * statement.cs (Block.GetKnownVariableInfo): Make private.
13770 (Block.IsVariableUsedInChildBlock): Remove.
13771 (Block.IsVariableUsedInBlock): Likewise.
13772 (Block.CheckInvariantMeaningInBlock): New. Show location of
13773 conflicting declaration.
13774 (Block.AddVariable): Make error messages less long-winded and more
13775 specific. Show location of conflicting declaration.
13776 * parameter.cs (Parameters.Location): New readonly property.
13778 2005-03-31 Raja R Harinath <rharinath@novell.com>
13780 Clean up semantics of invoking ResolveMemberAccess.
13781 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
13782 can have an instance, ensure that we pass in a non-TypeExpression
13783 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
13784 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
13785 argument. Update to changes and simplify.
13786 (FieldExpr.Emitinstance): Remove CS0120 check.
13787 (PropertyExpr.EmitInstance): Likewise.
13788 * expression.cs (Argument.Resolve): Likewise.
13789 (Invocation.DoResolve): Update to changes in semantics of
13790 InstanceExpression.
13792 2005-03-31 Marek Safar <marek.safar@seznam.cz>
13795 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
13798 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
13800 2005-03-31 Raja R Harinath <rharinath@novell.com>
13802 Fix difference in behaviour with commandline invocation.
13803 * driver.cs (Driver.Reset): New.
13804 (CompilerCallableEntryPoint): Call it.
13806 * statement.cs (If.Resolve): Avoid spurious "uninitialized
13807 variable" warnings if the boolean expression failed to resolve.
13809 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
13811 * attribute.cs: Fix the union of several permissions when some of them
13812 are unrestricted (so the result isn't an unrestricted permission set).
13815 2005-03-30 Raja R Harinath <rharinath@novell.com>
13817 * ecore.cs (MemberExpr): New class. Convert from interface
13819 (MemberExpr.ResolveMemberAccess): Refactor and move here from
13820 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
13822 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
13823 (MethodGroupExpr.IsExplicitImpl): Remove.
13824 (Expression.GetFieldFromEvent): Remove.
13825 (SimpleName.MemberStaticCheck): Remove.
13826 (SimpleName.DoSimpleNameResolve): Update to changes.
13827 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
13828 (MemberAccess.IdenticalNameAndTypeName): Remove.
13829 (MemberAccess.error176): Move to MemberExpr.
13830 (MemberAccess.DoResolve): Update to changes.
13831 (BaseAccess.DoResolve): Likewise.
13833 2005-03-30 Marek Safar <marek.safar@seznam.cz>
13835 C# 2.0 Conditional attribute class implementation
13837 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
13838 Analyzes class whether it has attribute which has ConditionalAttribute
13839 and its condition is not defined.
13841 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
13842 (Class.IsExcluded): New method. Search for at least one defined
13843 condition in ConditionalAttribute of attribute class.
13845 2005-03-30 Raja R Harinath <rharinath@novell.com>
13847 * ecore.cs (PropertyExpr): Derive from Expression, not
13848 ExpressionStatement.
13849 (PropertyExpr.EmitStatement): Remove.
13851 2005-03-29 Raja R Harinath <rharinath@novell.com>
13854 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
13855 internal field "value__" of an enum be private. The examples for
13856 "value__" that I found on MSDN all used FieldAttributes.Private.
13858 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
13859 Don't mention IL method attribute names.
13861 Fix #47991. Remove a TODO.
13862 * statement.cs (Block.Toplevel): Make into a field.
13863 (Block.Parameters): Move into ToplevelBlock.
13864 (Block.known_variables): Rename from child_variable_names.
13865 (Block.Block): Remove variants that take Parameters. Initialize
13866 'Toplevel' with the immediately surrounding toplevel block.
13867 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
13868 LocalInfo parameter.
13869 (Block.GetKnownVariableInfo): New.
13870 (Block.IsVariableNameUsedInChildBlock): Update.
13871 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
13872 the block, even though it may not be in scope.
13873 (Block.AddVariable): Remove Parameters parameter. Use
13874 Toplevel.Parameters instead.
13875 (Block.AddConstant): Remove Parameters parameter.
13876 (Block.GetParameterReference): Update to use Toplevel.Parameters.
13877 (Block.IsParamaterReference): Likewise.
13878 (Block.IsLocalParameter): Likewise. Simplify a lot.
13879 (ToplevelBlock.Parameters): New. Moved from Block.
13880 (ToplevelBlock.ToplevelBlock): Update to changes. Always
13881 initialize Parameters to a non-null value.
13882 * cs-parser.jay: Update to changes.
13883 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
13884 simple names that mean different things in the same block. Use
13885 Block.IsVariableNameUsedInBlock.
13887 2005-03-28 Raja R Harinath <rharinath@novell.com>
13889 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
13890 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
13891 GetTypeHandle. It is possible for a reflected type to derive from
13892 a TypeBuilder (e.g., int[] derives from the TypeBuilder
13893 System.Array during mscorlib compilation).
13894 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
13895 contain a method_hash, don't create one either. Don't create a
13896 deep copy of the base cache's method_hash.
13897 (MemberCache.SetupCache): Rename back from DeepCopy.
13898 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
13899 already initialized. If we see an override function, add its
13900 underlying base virtual function to the member_hash too.
13902 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
13904 2005-03-26 Raja R Harinath <harinath@acm.org>
13907 * assign.cs (Assign.DoResolve): When the RHS of an assignment
13908 fails to resolve, ensure that the LHS is still resolved as an
13911 2005-03-25 Raja R Harinath <harinath@acm.org>
13913 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
13915 (Enum.current_ec): Remove.
13916 (Enum.LookupEnumValue): Remove EmitContext argument.
13917 Just uses the one created during DefineType.
13918 (Enum.FindMembers): Update.
13919 * expression.cs (MemberAccess.DoResolve): Update.
13921 2005-03-22 Marek Safar <marek.safar@seznam.cz>
13923 * assign.cs (Assign.DoResolve): Check for CS1717 when
13924 source and target are same (uses Equals).
13926 * expression.cs (LocalVariableReference, ParameterReference,
13927 This): Implemented Equals, GetHashCode.
13929 * statement.cs (Block.GetParameterReference): Removed useless
13932 2005-03-22 Raja R Harinath <rharinath@novell.com>
13935 * statement.cs (Block.AddVariable): Ensure that we skip implicit
13936 blocks before deciding whether the error is cs0136 or cs0128.
13938 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
13939 (using_alias_directive, using_namespace_directive): Pass
13940 MemberName, not an expression to Namespace.UsingAlias and
13942 (MakeName): Use the MemberName of the namespace.
13943 * namespace.cs (Namespace.MemberName): New.
13944 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
13945 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
13947 * decl.cs (MemberName.Name): Make readonly.
13948 (MemberName.FromDotted): New "constructor".
13949 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
13950 (MemberCore.Name): Compute from MemberName on demand.
13951 (MemberCore.SetMemberName): Provide a way to change the
13953 (MemberCore.AddToContainer): Don't take a fullname parameter.
13954 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
13955 fully qualified name of the container to the member name.
13956 (TypeContainer.AddToTypeContainer): Use a fully qualified name
13957 only if the type is a member of the root container.
13958 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
13959 MemberName.Left rather than searching for an embedded ".".
13960 (PartialContainer.CreatePart): Update to changes in RootContext.
13961 (MemberBase.ShortName): Turn into a property. Use
13962 MemberCore.SetMemberName.
13963 (MemberBase.ExplicitInterfaceName): Remove.
13964 (MemberBase.UpdateMemberName): Remove.
13965 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
13966 (PropertyBase.SetMemberName): New override.
13967 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
13968 (Tree.GetDecl): New.
13969 (Tree.AllDecls): Rename from Decls.
13970 * attribute.cs, enum.cs, report.cs: Update to changes.
13971 * driver.cs (MainDriver): Use MemberName.FromDotted on
13972 RootContext.MainClass.
13974 2005-03-21 Marek Safar <marek.safar@seznam.cz>
13976 * class.cs (FixedField.Define): Check for CS1664 and more sanity
13979 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
13981 2005-03-18 Marek Safar <marek.safar@seznam.cz>
13983 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
13984 property accessor modifiers.
13986 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
13987 fixed buffer attribute (CS1716).
13988 (PropertyMethod.HasCustomAccessModifier): When property accessor
13989 has custom modifier.
13991 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
13993 (PropertyExpr.DoResolveLValue): Add CS0272.
13995 2005-03-17 Miguel de Icaza <miguel@novell.com>
13997 * convert.cs: When converting to a pointer, use the proper Conv.U
13998 or Conv.I depending on the source data type.
14000 * cs-tokenizer.cs: Make the size for large decimal constants,
14003 2005-03-17 Martin Baulig <martin@ximian.com>
14005 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14006 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14008 2005-03-17 Martin Baulig <martin@ximian.com>
14010 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14011 to bool so we can return an error condition.
14012 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14015 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14017 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14020 2005-03-16 Raja R Harinath <rharinath@novell.com>
14022 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14023 Refactor to avoid traversing the list of assemblies, and to avoid
14024 string concatenation.
14025 * typemanager.cs (guid_attr_type): Remove.
14026 (negative_hits, pointers, references): Remove hashes.
14028 (GetConstructedType): New. Uses type_hash to handle constructed
14029 types (arrays, references, pointers).
14030 (GetReferenceType, GetPointerType): Use it.
14031 (GetNestedType): New. Uses type_hash to handle nested types of
14033 (LookupType, LookupTypeDirect): Remove.
14034 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14035 'types' hash and LookupTypeReflection directly.
14036 (params_string, params_object): Use GetConstructedType.
14037 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14039 (Namespace.Lookup): Use cached_types.
14040 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14041 provided by old TypeManager.LookupType.
14042 * rootcontext.cs (MakeFQN): Remove.
14043 * decl.cs (DeclSpace.MakeFQN): Likewise.
14044 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14045 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14046 TypeManager.GetConstructedType.
14047 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14049 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14051 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14054 * cs-parser.jay: Reports CS1527 for any namespace element.
14056 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14059 * expression.cs (ParameterReference.IsAssigned): Changed error to
14061 (Error_WrongNumArguments): Moved CS0245 detection here.
14063 * statement.cs (Return.Resolve): Add CS1622 report.
14065 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14067 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14069 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14071 * attribute.cs expression.cs: Get rid of some allocations.
14073 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14075 * doc.cs : just eliminate the latest change.
14077 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14079 * doc.cs : commented out the latest change. It breaks xml-030.cs
14081 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14083 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14084 fail. So invoke CreateType() in FindDocumentedType().
14086 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14088 * cs-tokenizer.cs : added IsKeyword().
14089 * doc.cs : Detect keyword incorrectly used as identifier.
14090 Allow identifiers prefixed by @.
14092 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14094 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14095 It caused exception in namespace resolving (again!).
14097 * class.cs (Class.ctor): Removed exit.
14098 (PropertyMethod.ctor): ditto.
14100 * codegen.cs (Codegen.Reset): Reset static data.
14101 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14103 * cs-tokenizer.cs (Cleanup): Removed.
14105 * driver.cs (GetSystemDir): Rewrote to one line command.
14106 It caused problem with unloaded dynamic modules.
14107 (UnixParseOption): Removed Exit.
14108 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14109 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14110 Now can be mcs used as library.
14112 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14115 * location.cs (Reset): Reset static data.
14117 * namespace.cs (Reset): Reset static data.
14119 * report.cs (Report.Reset): Reset static data.
14121 * rootcontext.cs (RootContext.Reset): Reset static data.
14123 * tree.cs (RootTypes.ctor): Use Location.Null
14125 * typemanager.cs (TypeManager.Reset): Reset static data.
14126 (CoreLookupType): Removed Exit.
14127 (TypeHandle.Reset): Reset static data.
14129 2005-03-10 Raja R Harinath <rharinath@novell.com>
14132 * typemanager.cs (ComputeNamespaces): Import namespaces from
14133 referenced modules too.
14135 2005-03-09 Raja R Harinath <rharinath@novell.com>
14137 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14140 2005-03-09 Raja R Harinath <rharinath@novell.com>
14142 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14143 enclosing DeclSpace. This ensures that a name-lookup populates
14144 more caches and there are fewer 'TypeExpression's. Carve out
14145 nested type lookup into ...
14146 (LookupNestedTypeInHierarchy): ... this.
14148 2005-03-09 Raja R Harinath <rharinath@novell.com>
14150 Clean up a few partial-class semantics.
14151 Fixes test-357.cs and cs1618-2.cs.
14152 * cs-parser.jay (struct_declaration): Use 'current_class' as
14153 parent of newly-created struct. Remove call to Register ().
14154 Use 'pop_current_class' to complete handing the current struct.
14155 (interface_declaration): Likewise.
14156 (class_declaration): Likewise.
14157 (enum_declaration): Use 'current_class' as parent of newly created
14159 (delegate_declaration): Likewise.
14160 (pop_current_class): New function. This is used to handle closing
14161 up the 'current_class' and 'current_container', and pointing them
14162 to the enclosing class/container.
14163 (CSharpParser): Initialize 'current_class' too.
14164 * decl.cs (MemberCore): Add check for invariant: a partial
14165 container is not a parsed entity, and thus does not enclose any
14167 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14168 (DeclSpace.BaseTypeExpr): Use it.
14169 (DeclSpace.LookupType): Add check for invariant.
14170 * class.cs (TypeContainer): Add check for invariant: a nested
14171 class should have the same NamespaceEntry as its enclosing class.
14172 (TypeContainer.EmitFieldInitializers): Make virtual.
14173 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14175 (TypeContainer.Register): Remove.
14176 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14177 null. Use TypeResolveEmitContext for resolving base types and
14178 interfaces. Move initialization of Parts.TypeBuilder here from
14180 (TypeContainer.DefineNestedTypes): ... here.
14181 (PartialContainer): Take a Namespace not a NamespaceEntry.
14182 (PartialContainer.Create): Don't use Register. Call the
14183 appropriate Add... function directly.
14184 (ClassPart): Take both the PartialContainer and the enclosing
14185 class as constructor arguments.
14186 (ClassPart.EmitFieldInitializers): Override.
14187 (ClassPart.PartFindNestedTypes): Remove.
14188 (FieldBase.GetInitializerExpression): Resolve the initializer
14189 expression in the emit context of the enclosing class.
14190 * tree.cs (RootTypes): Remove Register ().
14192 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14194 * cs-parser.jay: Removed CS0134.
14196 * driver.cs: Removed CS1901.
14198 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14199 for predefined types.
14201 2005-03-07 Duncan Mak <duncan@novell.com>
14203 * codegen.cs (Save): Catch UnauthorizedAccessException as
14204 well. Fixes bug #73454.
14206 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14208 * cs-tokenizer.cs (xtoken): Add CS1035.
14210 * class.cs (MethodData.Define): Add CS0683.
14211 (FieldMember.ctor): Add CS0681.
14213 2005-03-07 Raja R Harinath <rharinath@novell.com>
14215 * ecore.cs (SimpleName.DoResolve): Rename from
14216 SimpleName.DoResolveAllowStatic.
14217 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14218 Pass 'intermediate' flag to MemberStaticCheck.
14219 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14220 of "intermediate" lookups via MemberAccess.
14221 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14222 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14224 2005-03-07 Raja R Harinath <rharinath@novell.com>
14227 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14228 slipped in because of variable names that are identical to a
14229 builtin type's BCL equivalent ('string String;', 'int Int32;').
14230 (PropertyExpr.EmitInstance): Likewise.
14232 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14234 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14236 * report.cs (warning_ignore_table): Made public.
14238 2005-03-04 Raja R Harinath <rharinath@novell.com>
14241 * class.cs (MethodData.Emit): Pass 'container' to
14242 container.GetObsoleteAttribute instead of 'container.Parent'.
14244 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14246 * cs-parser.jay: Add 1534 error test.
14248 * iterators.cs (Yield.CheckContext): Add error 1629.
14249 (Iterator.ctor): Save unsafe modifier.
14250 (MoveNextMethod.DoEmit): Restore unsafe context.
14252 * namespace.cs (UsingAlias): Better error message.
14254 2005-03-03 Dan Winship <danw@novell.com>
14256 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14257 the warning message [#73219]
14259 2005-03-03 Raja R Harinath <rharinath@novell.com>
14261 Fix compile with MCS 1.0.0.0.
14262 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14263 w_restore to not depend on string constant folding.
14265 2005-03-03 Raja R Harinath <rharinath@novell.com>
14267 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14268 CS0246 check to users who passed 'silent = false'.
14269 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14271 (SimpleName.SimpleNameResolve): Update.
14272 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14273 (MemberAccess.IdenticalNameAndTypeName): Update.
14274 * doc.cs (FindDocumentedTypeNonArray): Update.
14276 2005-03-03 Raja R Harinath <rharinath@novell.com>
14278 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14279 * parameters.cs (ComputeAndDefineParameters): Remove.
14280 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14281 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14282 Use GetParameterInfo.
14284 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14286 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14288 2005-03-02 Raja R Harinath <rharinath@novell.com>
14290 Unify DeclSpace.LookupType and DeclSpace.FindType.
14291 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14292 is in charge of defining nested types on demand.
14293 (DeclSpace.LookupType): Use it when the current_type is a
14294 TypeBuilder. Use LookupTypeDirect for reflected types.
14295 (DeclSpace.FindType): Remove.
14296 (DeclSpace.LookupInterfaceOrClass): Likewise.
14297 (DeclSpace.DefineTypeAndParents): Likewise.
14298 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14299 DeclSpace.LookupType.
14300 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14301 * typemanager.cs (LookupType): Simplify.
14302 (AddUserType): Remove type from negative_hits.
14303 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14304 * class.cs (TypeContainer.FindMembers): Move handling of nested
14306 (TypeContainer.FindMembers_NestedTypes): ... here.
14307 (TypeContainer.FindNestedType): Implement override.
14308 (ClassPart.FindNestedType): Delegate to PartialContainer.
14309 (ClassPart.PartFindNestedType): Looks up the nested types of the
14312 2005-03-02 Martin Baulig <martin@ximian.com>
14314 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14315 static constructor in static classes.
14317 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14319 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14320 sizeParamIndex is not specified.
14322 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14325 * report.cs (WarningMessage.IsEnabled): Missing null check.
14327 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14329 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14330 in the fields and not in the properties.
14332 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14334 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14337 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14339 * attribute.cs: Small refactoring (improved robustness).
14340 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14341 (ValidateGuid): Removed.
14342 (Resolve): Removed referenced to above mentioned.
14343 (GetAttributeUsage): Made private and changed to work without
14345 (GetIndexerAttributeValue): Don't crash.
14346 (GetConditionalAttributeValue): Ditto.
14347 (GetClsCompliantAttributeValue): Ditto.
14348 (ExtractSecurityPermissionSet): All attributes exceptions are
14350 (GetPropertyValue): New helper.
14351 (GetMethodImplOptions): New method.
14352 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14353 some missing properties.
14355 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14356 (Method.ApplyAttributeBuilder): Updated.
14358 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14361 2005-02-28 Raja R Harinath <rharinath@novell.com>
14364 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14365 non-simple types (array, pointer, reference).
14367 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14369 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14371 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14373 (Method.CheckBase): Catch wrong destructor here.
14374 (MethodData.Define): Add errors 550, 668.
14376 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14378 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14380 * pending.cs (VerifyPendingMethods): Add error 551.
14382 * typemanager.cs (CSharpName): Next error report helper.
14384 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14386 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14387 attributes. Removed useless attribute double check.
14388 It saves almost 2MBs for corlib.
14390 2005-02-25 Raja R Harinath <rharinath@novell.com>
14393 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14394 called twice in case of error.
14396 2005-02-23 Chris Toshok <toshok@ximian.com>
14398 Fix compiler portions of #72827.
14399 * statement.cs (Block.Emit): call Begin/EndScope on the
14400 EmitContext instead of the ILGenerator.
14402 * codegen.cs (EmitContext.BeginScope): new method, call
14403 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14405 (EmitContext.BeginScope): same, but EndScope and CloseScope
14407 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14408 offset and call the superclass's OpenScope(int) with it.
14409 (SymbolWriter.CloseScope): get the current il
14410 offset and call superclass's CloseScope(int) with it.
14412 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14414 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14415 CS1677 for out and ref as well.
14417 * class.cs (Method.Define): Add error CS1599 detection.
14419 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14421 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14423 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14425 * support.cs.cs (ModifierDesc): New helper method.
14427 2005-02-23 Raja R Harinath <rharinath@novell.com>
14428 Abin Thomas <projectmonokochi@rediffmail.com>
14429 Anoob V E <projectmonokochi@rediffmail.com>
14430 Harilal P R <projectmonokochi@rediffmail.com>
14432 Fix #57851, #72718.
14433 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14434 MemberLookup (used for error reporting) actually returns a result.
14435 Fix error report number (122, not 112).
14437 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14438 Anoob V E <projectmonokochi@rediffmail.com>
14439 Harilal P R <projectmonokochi@rediffmail.com>
14442 * pending.cs (PendingImplementation.GetAbstractMethods):
14443 Find NonPublic members too.
14445 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14447 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14450 * class.cs (MethodCore.CheckMethodAgainstBase):
14451 Add error 239 report.
14453 2005-02-21 Raja R Harinath <rharinath@novell.com>
14456 * expression.cs (Invocation.IsApplicable): Make public.
14457 (Invocation.IsParamsMethodApplicable): Likewise.
14458 * delegate.cs (Delegate.VerifyApplicability): Don't use
14459 Invocation.VerifyArgumentCompat for parameter applicability
14460 testing. Use Invocation.IsApplicable and
14461 Invocation.IsParamsMethodApplicable.
14463 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14465 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14467 * class.cs (Operator.Define): Add error 217 report.
14469 2005-02-21 Raja R Harinath <rharinath@novell.com>
14471 * namespace.cs (UsingEntry.Resolve): Undo change below.
14473 2005-02-21 Raja R Harinath <rharinath@novell.com>
14476 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14477 disable the error message when the extended MemberLookup also
14479 (Expression.MemberLookupFinal): Update.
14480 (SimpleName.DoSimpleNameResolve): Update.
14481 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14482 Don't use MemberLookupFinal.
14483 (New.DoResolve): Update.
14484 (BaseAccess.CommonResolve): Update.
14486 2005-02-21 Raja R Harinath <rharinath@novell.com>
14489 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14490 occured previously, don't resolve again.
14492 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14495 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14496 argument. Call ResolveAttributeUsage for unresolved.
14497 when types doesn't match ctor arguments.
14499 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14500 for nested attribute classes.
14501 (Class.attribute_usage): Removed.
14502 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14503 for attribute class.
14505 * ecore.cs (IsAttribute): Removed.
14507 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14509 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14511 (attribute_types): Removed.
14512 (EmitCode): Global attributes are emited as the latest.
14514 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14516 * class.cs (EmitFieldInitializers): Don't emit field initializer
14517 for default values when optimilization is on.
14519 * constant.cs (Constant.IsDefaultValue): New property.
14521 * driver.cs: Add /optimize handling.
14525 * literal.cs: Implement new IsDefaultValue property.
14527 * rootcontext.cs (Optimize): New field, holds /optimize option.
14529 2005-02-18 Raja R Harinath <rharinath@novell.com>
14531 Fix crasher in re-opened #72347.
14532 * namespace.cs (Namespace.Lookup): Return null if
14533 DeclSpace.DefineType returns null.
14536 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14538 2005-02-18 Raja R Harinath <rharinath@novell.com>
14540 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14541 now returns null if it cannot resolve to an lvalue.
14542 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14543 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14544 returned null. Remove check for SimpleName.
14545 (EventExpr.DoResolveLValue): New.
14546 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14547 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14549 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14550 avoid CS0131 error.
14551 (Unary.ResolveOperator): Move CS0211 check ...
14552 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14554 (Unary.DoResolveLValue): Simplify.
14555 (AddressOf.DoResolveLValue): New.
14556 (ArrayAccess.DoResolveLValue): New.
14558 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14560 * attribute.cs (Attribute.Resolve): Add arguments casting for
14561 when types doesn't match ctor arguments.
14563 2005-02-16 Raja R Harinath <rharinath@novell.com>
14565 Fix parts of #63202.
14566 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14567 lookup of operator in base type. Ensure that all checks happen
14568 when the operator resolves to an "op_..." method.
14570 2005-02-15 Raja R Harinath <rharinath@novell.com>
14573 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14574 'ignore_cs0104' parameter. Pass it to ...
14575 (NamespaceEntry.Lookup): ... this.
14576 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14577 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14578 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14579 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14580 Update. Request that cs0104 errors be ignored.
14581 (ComposedCast.ResolveAsTypeStep): Update.
14583 2005-02-14 Raja R Harinath <rharinath@novell.com>
14586 * expression.cs (Invocation.BetterFunction): Remove support for
14587 comparing virtual functions and their overrides.
14588 (Invocation.IsOverride): New.
14589 (Invocation.OverloadResolve): Don't consider 'override' functions
14590 during candidate selection. Store them in a lookaside list.
14591 If the selected method is a 'virtual' function, use the list to
14592 find any overrides that are closer to the LHS type.
14594 2005-02-14 Marek Safar <marek.safar@seznam.cz>
14596 * expression.cs (New.DoResolve): Add complex core type reduction.
14597 (New.Constantify): Converts complex core type syntax like 'new int ()'
14598 to simple constant.
14600 2005-02-14 Raja R Harinath <rharinath@novell.com>
14602 * decl.cs (EntryType.EntryType): New constructor to create an
14603 updated copy of a cache entry.
14604 (MemberCache.AddMethods): Use it.
14605 (MemberCache.ClearDeclaredOnly): Remove.
14606 (MemberCache.MemberCache): Update.
14608 2005-02-11 Miguel de Icaza <miguel@novell.com>
14610 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
14611 variable. This one is represents the actual low-level declaration
14612 of the method, as opposed to the semantic level `IsStatic'.
14614 An anonymous method which is hosted into a static method might be
14615 actually an instance method. IsStatic would reflect the
14616 container, while MethodIsStatic represents the actual code
14619 * expression.cs (ParameterReference): Use the new MethodIsStatic
14620 instead of IsStatic.
14622 * anonymous.cs (AnonymousMethod.Compatible): Pass the
14623 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
14624 set on the current EmitContext.
14626 * expression.cs (Cast): Overload DoResolveLValue so we can pass
14627 resolve our casted expression as an LValue. This triggers the
14628 proper LValue processing that is later required by Assign.
14632 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
14634 2005-02-11 Marek Safar <marek.safar@seznam.cz>
14636 C# 2.0 Fixed buffer implementation
14638 * anonymous.cs: Update after RegisterHelperClass renaming.
14640 * attribute.cs (AttributeTester.fixed_buffer_cache):
14641 Cache of external fixed buffers.
14642 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
14643 implementation if field is fixed buffer else null.
14646 (TypeContainer.AddField): Accept FieldMember instead of Field.
14647 (FieldBase.IsFieldClsCompliant): Extracted code from
14648 VerifyClsCompliance descendant customization.
14649 (FixedField): New class handles fixed buffer fields.
14650 (FixedFieldExternal): Keeps information about imported fixed
14652 (IFixedField): Make access to internal or external fixed buffer
14655 * cs-parser.jay: Add fixed buffer parsing.
14657 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
14660 * expression.cs (Indirection): Extended implementation to accept
14661 fixed buffer field.
14662 (PointerArithmetic.Emit): Get element from fixed buffer as well.
14663 (ElementAccess.MakePointerAccess): Get type as parameter.
14664 (DoResolve): Add fixed buffer field expression conversion.
14665 (DoResolveLValue): Ditto.
14666 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
14667 (ArrayPtr): Derives from FixedBufferPtr.
14668 (ArrayPtr.Emit): Add extra emit for array elements.
14670 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
14672 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
14673 for compiler generated types.
14674 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
14676 * statement.cs (Fixed): Refactored to be easier add fixed buffer
14677 and consume less memory.
14678 (Fixed.Resolve): Add fixed buffer case.
14680 * typemanager.cs (compiler_generated_attr_ctor,
14681 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
14682 (HasElementType): Add our own implementation to work on every
14685 2005-02-11 Miguel de Icaza <miguel@novell.com>
14687 * anonymous.cs (CaptureContext): Track whether `this' has been
14690 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
14691 only captured `this' if it was implicitly done (instance
14692 methods/variables were used).
14694 * codegen.cs (EmitContext.CaptureThis): New method to flag that
14695 `this' must be captured.
14697 2005-01-30 Miguel de Icaza <miguel@novell.com>
14699 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
14700 is null it means that there has been no need to capture anything,
14701 so we just create a sibling.
14703 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
14705 Just a partial fix. The other half is fairly elusive.
14707 2005-02-10 Raja R Harinath <rharinath@novell.com>
14709 Fix #52586, cs0121-4.cs.
14710 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
14711 and return a hashtable.
14712 (MemberCache.ClearDeclaredOnly): New.
14713 (MemberCache.MemberCache): Update to change. Make a deep copy of
14714 the method_hash of a base type too.
14715 (MemberCache.AddMethods): Adapt to having a deep copy of the base
14716 type methods. Overwrite entries with the same MethodHandle so
14717 that the ReflectedType is correct. The process leaves in base
14718 virtual functions and their overrides as distinct entries.
14719 (CacheEntry): Now a class instead of a struct. It shouldn't alter
14720 matters since it was boxed in a ArrayList before.
14721 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
14723 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
14724 case of a virtual function and its override (choose the overload
14726 (Invocation.OverloadResolve): Avoid 'override' members during
14727 'applicable_type' calculation.
14729 2005-02-09 Raja R Harinath <rharinath@novell.com>
14731 Combine two near-redundant caches.
14732 * typemanager.cs (method_params): Rename from method_internal_params.
14733 (TypeManager.GetParameterData): New. Replace
14734 Invocation.GetParameterData.
14735 (TypeManager.LookupParametersByBuilder): Remove.
14736 * expression.cs (Invocation.method_parameter_cache): Remove.
14737 (Invocation.GetParameterData): Remove.
14739 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
14742 2005-02-08 Raja R Harinath <rharinath@novell.com>
14745 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
14746 TypeManager.multicast_delegate_type is null, resolve it by looking
14747 up "System.MulticastDelegate".
14748 * rootcontext.cs (RootContext.ResolveCore): Simplify.
14750 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
14751 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
14752 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
14755 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
14756 (LabeledStatement.AddReference): New. Set 'referenced'.
14757 (Goto.Resolve): Use it.
14759 2005-02-05 John Luke <john.luke@gmail.com>
14761 * driver.cs: remove duplicate -doc line in Usage ()
14763 2005-02-04 Raja R Harinath <rharinath@novell.com>
14765 * location.cs (Location.AddFile): Fix CS2002 error report.
14767 2005-02-02 Martin Baulig <martin@ximian.com>
14769 * delegate.cs (Delegate.DefineType): Report an internal error if
14770 TypeManager.multicast_delegate_type is null. See bug #72015 for
14773 2005-02-02 Raja R Harinath <rharinath@novell.com>
14775 Fix a crasher in a variant of #31984.
14776 * const.cs (Constant.CheckBase): New override that defers the
14777 new-or-override check in case the base type hasn't been populated
14779 (Constant.Define): Ensure the new-or-override check is performed.
14781 2005-02-01 Duncan Mak <duncan@ximian.com>
14783 * const.cs (LookupConstantValue): Check that `ce' is not null
14784 before calling GetValue ().
14786 2005-02-01 Raja R Harinath <rharinath@novell.com>
14788 Fix test-334.cs (#69519).
14789 * cs-parser.jay (using_alias_directive): Pass in an expression to
14790 NamespaceEntry.UsingAlias.
14791 (using_namespace_directive): Pass in an expression to
14792 NamespaceEntry.Using.
14793 (namespace_name): Don't flatten to a string.
14794 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
14795 (NamespaceEntry.AliasEntry.Resolve): Lookup using
14797 (NamespaceEntry.UsingEntry): Likewise.
14798 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
14800 (NamespaceEntry.LookupForUsing): Remove.
14801 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
14803 (NamespaceEntry.Lookup): Remove support for dotted names.
14805 2005-02-01 Raja R Harinath <rharinath@novell.com>
14807 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
14809 (NamespaceEntry.ImplicitParent): Compute on demand.
14810 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
14811 parallels the current.
14812 (NamespaceEntry.LookupForUsing): Use it.
14813 (NamespaceEntry.Lookup): If the current namespace-entry is
14814 implicit, don't search aliases and using tables.
14816 2005-02-01 Raja R Harinath <rharinath@novell.com>
14819 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
14821 (TypeContainer.BaseCache): Compute on demand.
14822 (TypeContainer.FindMembers): Define constants and types if they're
14823 not already created.
14824 (FieldMember.Define): Move resetting of ec.InUnsafe before error
14826 * const.cs (Constant.Define): Make idempotent.
14828 2005-01-29 Miguel de Icaza <miguel@novell.com>
14830 * pending.cs: Produce better code (no nops produced by using Ldarg
14833 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
14834 i - 1' it should be arg + 1.
14838 2005-01-28 Raja R Harinath <rharinath@novell.com>
14840 * attribute.cs (Attribute.CheckAttributeType): Make private
14842 (Attribute.ResolveType): Make virtual.
14843 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
14844 handling of RootContext.Tree.Types.
14846 2005-01-27 Raja R Harinath <rharinath@novell.com>
14848 Update attribute-handling to use the SimpleName/MemberAccess
14850 * cs-parser.jay (attribute): Pass in an expression to the
14851 constructors of Attribute and GlobalAttribute.
14852 * attribute.cs (Attribute): Take an expression for the name.
14853 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
14854 passed in attribute name expression.
14855 (Attribute.CheckAttributeType): Use it.
14856 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
14857 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
14858 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
14859 argument to prevent error messages if the lookup fails.
14861 2005-01-27 Marek Safar <marek.safar@seznam.cz>
14863 * expression.cs (Indirection): Implemented IVariable interface
14864 to support indirection in AddressOf operator.
14865 (PointerArithmetic.Emit): Add optimalization for case where
14866 result can be precomputed.
14868 2005-01-26 Martin Baulig <martin@ximian.com>
14870 * class.cs (TypeContainer.AttributeTargets): Return the correct
14871 AttributeTargets depending on our `Kind' instead of throwing an
14872 exception; fixes #71632.
14874 2005-01-26 Marek Safar <marek.safar@seznam.cz>
14877 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
14880 2005-01-25 Raja R Harinath <rharinath@novell.com>
14883 * expression.cs (MemberAccess.DoResolve): Don't complain with
14884 cs0572 when the LHS of a member access has identical name and type
14887 2005-01-25 Marek Safar <marek.safar@seznam.cz>
14890 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
14892 Create custom PermissionSet only for PermissionSetAttribute.
14894 2005-01-24 Marek Safar <marek.safar@seznam.cz>
14897 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
14898 delegates in static class.
14900 2005-01-24 Martin Baulig <martin@ximian.com>
14902 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14903 merging an implicit block, just use its reachability.
14905 * statement.cs (Block.Resolve): Make the unreachable code check
14906 work wrt. implicit blocks; see test-337 from #63842.
14908 2005-01-21 Alp Toker <alp@atoker.com>
14910 * cs-parser.jay: destructor_declaration's container is PartialContainer
14911 not Class when partial types are used, so use Kind prop instead of
14914 2005-01-22 Miguel de Icaza <miguel@ximian.com>
14916 * cs-parser.jay: Improve error reporting when an interface
14917 declares new types.
14919 2005-01-20 Dick Porter <dick@ximian.com>
14921 * support.cs: SeekableStreamReader fix from Sandor Dobos
14922 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
14923 chars are read. Fixes bug 70369.
14925 2005-01-20 Raja R Harinath <rharinath@novell.com>
14927 * cs-parser.jay (catch_clause): Simplify current_block handling
14930 2005-01-17 Miguel de Icaza <miguel@ximian.com>
14932 * convert.cs (ImplicitStandardConversionExists): Synchronize the
14933 code with ImplicitStandardConversion to handle the implicit
14934 conversion of method groups into valid delegate invocations.
14936 The problem is that in parameter handling we were using this code
14937 path. Fixes bug #64698
14939 2005-01-19 Raja R Harinath <rharinath@novell.com>
14941 * cs-parser.jay: Fix several infelicities.
14942 - Avoid assigning to the parser value stack. Code like
14943 '$3 = null' is unclean. Synthesize a value for the code block
14945 - Avoid using oob_stack for storing location information. Use ...
14946 (_mark_): ... this. New (empty) rule. Saves the current location
14948 (foreach_statement): Avoid using oob_stack for current_block
14949 handling. Use technique used in for_statement and
14950 using_statement. Synthesize a value for the code block to store
14951 additional intermediate information.
14953 2005-01-13 Miguel de Icaza <miguel@ximian.com>
14955 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
14956 of a different type is only allowed to private fields of a
14957 containing type, not on fields of a base class.
14959 See test-174.cs and error cs0122-9.cs
14961 2005-01-13 Raja R Harinath <rharinath@novell.com>
14963 Fix test-335.cs (bug #58126).
14964 * cs-parser.jay (argument): Split out non-expression parts of the
14965 rule into 'non_simple_argument'.
14966 (invocation_expression): Support parenthesized invocations with
14967 multiple arguments, and with single non-simple arguments.
14969 2005-01-13 Raja R Harinath <rharinath@novell.com>
14971 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
14974 2005-01-12 Raja R Harinath <rharinath@novell.com>
14976 Fix cs0038-1.cs, cs1640-6.cs.
14977 * ecore.cs (Expression.Resolve): Remove special-case for
14978 SimpleName in error-handling.
14979 (Expression.almostMatchedMembers): Relax access permission to
14981 (Expression.MemberLookupFailed): Handle duplicates in
14982 almostMatchedMembers list.
14983 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
14984 * expression.cs (New.DoResolve): Report CS1540 for more cases.
14985 * typemanager.cs (GetFullNameSignature): Use the MethodBase
14986 overload if the passed in MemberInfo is a MethodBase.
14988 2005-01-12 Marek Safar <marek.safar@seznam.cz>
14991 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
14992 for non-CAS & merge permission sets properly.
14994 2005-01-11 Raja R Harinath <rharinath@novell.com>
14996 Improve standard-compliance of simple name and member access
14997 resolution. Fixes bugs #52697, #57200, #67520, #69519.
14998 * ecore.cs (FullNamedExpression): New abstract base class
14999 for Namespaces and TypeExpressions.
15000 (ResolveFlags.SimpleName): Remove.
15001 (SimpleName): Remove support for dotted names.
15002 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15003 DeclSpace.FindType and DeclSpace.LookupType.
15004 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15005 (Expression.ExprClassName): Make member function.
15006 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15007 a namespace. Remove creation of dotted "SimpleName"s.
15008 (MemberAccess.DoResolve): Likewise.
15009 * decl.cs (DeclSpace.Cache): Make private.
15010 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15011 (DeclSpace.FindType): Update.
15012 (DeclSpace.LookupType): Move here from RootContext. Return a
15013 FullNamedExpression.
15014 * namespace.cs (Namespace): Derive from FullNamedExpression
15015 so that it can be part of expression resolution.
15016 (Namespace.Lookup): Return an FullNamedExpression.
15017 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15019 * rootcontext.cs (NamespaceLookup): Remove.
15020 (LookupType): Move to DeclSpace.
15021 * attribute.cs (CheckAttributeType): Update.
15022 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15023 (FindDocumentedTypeNonArray): Likewise.
15025 2005-01-11 Raja R Harinath <rharinath@novell.com>
15027 Fix cs0509.cs, cs1632.cs.
15028 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15029 is the same as IsInterface.
15030 (TypeContainer.GetClassBases): Likewise.
15031 * statement.cs (LabeledStatement.ig): New field.
15032 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15034 (LabeledStatement.DoEmit): Check that the label was created with
15035 the same ILGenerator.
15037 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15040 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15041 accessors to its properties.
15043 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15044 from accessors to property.
15046 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15049 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15050 only for overrides.
15052 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15054 * attribute.cs: Check for null and empty strings.
15056 I have lost another battle to Paolo.
15058 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15061 * class.cs (PropertyMethod): Set Parent field in ctors.
15062 (SetMethod.InternalParameters): Add unsafe switch hack.
15063 Override MarkForDuplicationCheck where it is appropriate.
15065 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15066 It says whether container allows members with the same name.
15067 Base default is no.
15068 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15069 Removed is_method parameter.
15071 2005-01-06 Duncan Mak <duncan@ximian.com>
15073 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15074 because the previous change led to incorrect reporting of CS1032
15075 ("Cannot define/undefine preprocessor symbols after first token in
15076 file"). Instead of using `tokens_seen' as the only flag that
15077 triggers CS1040, introduce `comments_seen'. This new flag is used
15078 to signify having seen comments on the current line, so it is
15079 unset after a newline.
15081 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15083 * doc.cs : When searching for a type, find nested type too.
15084 This fixes bug #71040.
15086 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15089 - Warn missing member comment on those classes which also does not
15090 have doc comments. Fixed bug #71041.
15091 - Don't warn missing doc comment on default constructor.
15094 2005-01-06 Duncan Mak <duncan@ximian.com>
15096 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15097 comments, set `tokens_seen' to true. This allows us to detect
15098 misplaced preprocessor directives (i.e. not at the beginning of
15099 the a line, nor after whitespaces). In that case, report error
15100 CS1040. This fixes bug #56460.
15102 * cs-parser.jay (interface_member_declaration): Add checks for
15103 IsExplicitImpl, and report CS0541 error if an interface member is
15104 defined as an explicit interface declaration.
15106 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15109 * class.cs (PropertyMethod): Set Parent field in ctors.
15110 (SetMethod.InternalParameters): Add unsafe switch hack.
15112 * decl.cs (MemberCore.Parent): Cannot be readonly.
15114 2005-01-06 Raja R Harinath <rharinath@novell.com>
15116 * decl.cs (DeclSpace.ResolveType): Remove.
15117 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15118 Merge in code from ...
15119 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15120 * class.cs, enum.cs: Update to changes.
15122 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15124 * anonymous.cs: Ensure that we init the scope of our parent if it
15125 has not been initialized yet.
15127 2004-12-30 Duncan Mak <duncan@ximian.com>
15129 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15130 if field.FieldBuilder is null. Fixes #70758.
15132 * convert.cs: Fixed some typos and updated some of the comments.
15133 (ImplicitStandardConversionExists):
15134 (TryImplicitIntConversion): If `target_type' is an interface and
15135 the type of `ic' implements this interface, return true or a new
15136 BoxedCast instead of null. This fixes #70468.
15138 2004-12-29 Duncan Mak <duncan@ximian.com>
15140 * expression.cs (Argument.Emit): Check that Expr is
15141 IMemoryLocation before casting to it, and report CS1510 otherwise.
15145 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15147 * statement.cs (Block.ThisVariable): remove the recursion here, to
15148 make the --profile more sane.
15150 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15152 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15153 assembly, by JB Evain.
15155 2004-12-17 Raja R Harinath <rharinath@novell.com>
15157 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15158 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15159 "parent" refers to enclosing type/class. "base" refers to superclass.
15161 2004-12-17 Raja R Harinath <rharinath@novell.com>
15163 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15164 Ensure that we only have GlobalAttributes.
15165 * attribute.cs (Attribute.Emit): Make non-virtual.
15166 (GlobalAttribute.Emit): Remove.
15167 (Attribute.Resolve): Make virtual.
15168 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15169 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15170 the argument. Don't create one.
15171 (Attribute.GetObsoleteAttribute): Likewise.
15172 (Attribute.GetClsCompliantAttributeValue): Likewise.
15173 * class.cs, decl.cs: Update to changes.
15175 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15177 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15179 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15181 * statement.cs (Foreach.Resolve): Add error 186 report.
15183 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15185 * expression.cs (Conditional.DoResolve): Add warning 429.
15187 * statement.cs (If.Resolve): Add warning 665.
15189 2004-12-16 Raja R Harinath <rharinath@novell.com>
15191 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15192 except when in the parser, and in GlobalAttribute.
15193 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15194 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15195 RootContext.Tree.Types.NamespaceEntry once work is done.
15196 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15197 and resets RootContext.Tree.Types.NamespaceEntry.
15199 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15201 * cs-parser.jay: Don't create a block for every variable.
15203 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15205 * location.cs: Provide extra information.
15207 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15208 variables from the captured environment, it is the ldarg_0.
15210 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15212 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15215 * class.cs: Changed warning level for 169 to avoid developer
15216 displeasure from warning flooding. It will be changed back when they
15217 fix most of current BCL warnings.
15219 * RootContext.cs: Pushed default WarningLevel to 3.
15221 * statement.cs: Removed unused variable.
15223 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15225 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15226 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15227 Add error 502 report.
15228 (StaticClass.DefineType): Add error 441 report.
15229 (Class.AllowedModifiersProp): New virtual property as temporary
15230 extension to AllowedModifiers.
15231 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15232 to share implementation with StaticClass and don't call virtual
15235 * driver.cs (MainDriver): Add error 1558 test.
15237 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15238 report. Moved error 36 test here.
15240 * statement.cs (Throw.Resolve): Add error 724 report.
15242 * typemanager.cs: Add out_attribute_type core type.
15244 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15246 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15248 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15250 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15253 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15255 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15256 Add error 3023 report.
15257 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15259 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15262 2004-12-12 John Luke <john.luke@gmail.com>
15264 * driver.cs (AddArgs): take -- into account when
15265 adding arguments, fixes bug 65710
15267 2004-12-12 Martin Baulig <martin@ximian.com>
15269 * expression.cs (Unary.TryReduceNegative): Added support for
15270 SByteConstant and ByteConstant.
15271 (Unary.Reduce): Check error values from TryReduceNegative().
15273 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15275 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15276 and report exception as error 182.
15278 2004-12-10 Raja R Harinath <rharinath@novell.com>
15280 * driver.cs (Main): Fix message when there are warnings.
15282 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15284 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15286 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15288 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15289 Reduced number of warnings.
15291 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15293 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15295 * driver.cs: Removed message.
15297 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15299 2004-12-08 <vargaz@freemail.hu>
15301 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15303 2004-12-08 Martin Baulig <martin@ximian.com>
15305 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15306 instead of a CS3002 for properties and indexer.
15308 2004-12-08 Martin Baulig <martin@ximian.com>
15310 * decl.cs (MemberName.ToString): Make this work again.
15312 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15314 * attribute.cs (Resolve): Add error 591 detection.
15316 * class.cs (FieldMember.Define): Add error 1547 detection.
15317 (Indexer.Define): Add error 620 detection.
15318 (Operator.Define): Add error 590 detection.
15320 * ecore.cs: Missing argument for error 79.
15322 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15325 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15328 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15331 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15333 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15334 Some operator comments were suppressed.
15335 * doc.cs : Implicit/explicit operator name in doc comments are like
15336 "op_Explicit(type)~returnType", so added suffix handling.
15338 2004-12-07 Martin Baulig <martin@ximian.com>
15341 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15342 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15343 (DeclSpace.ec): New protected field; store the EmitContext here.
15344 (DeclSpace.EmitContext): New public property; moved here from
15346 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15349 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15350 (Enum.Emit): Don't create a new EmitContext.
15352 * delegate.cs (Delegate.DefineType): Always create the
15355 * iterators.cs (Iterators.DefineIterator): Create a new
15356 EmitContext and store it in `ec'.
15358 2004-08-24 Martin Baulig <martin@ximian.com>
15361 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15362 this for accessibility checks.
15363 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15364 IsNestedFamilyAccessible.
15365 (TypeManager.IsSubclassOf): New method, do what the name actually
15368 2004-12-06 Raja R Harinath <rharinath@novell.com>
15370 Fix crash on cs0657-17.cs.
15371 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15372 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15373 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15374 the case where the NamespaceEntry gets overwritten.
15376 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15378 Fixed #69195, #56821
15379 * ecore.cs (ResolveBoolean): Tiny refactoring.
15381 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15382 of right expression resolving when left is false constant and
15383 operator is LogicalAnd OR true constant and operator is LogicalOr.
15385 * statement.cs (ResolveUnreachable): Always reports warning.
15387 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15389 * class.cs: Distinguish between 1721 and 1722 (just a little help
15390 for the programmer).
15392 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15394 * delegate.cs: Only allow this on new versions of the language.
15396 2004-12-02 Duncan Mak <duncan@ximian.com>
15398 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15400 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15401 here as a static method. Take an additional bool out parameter
15402 `must_do_cs1540_check' for signaling to InstanceResolve.
15403 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15404 member field from PropertyExpr class and made it an argument of
15405 the method instead.
15406 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15407 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15408 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15409 and `remove_accessor' as well as InstanceResolve: report CS0122
15414 2004-12-03 Raja R Harinath <rharinath@novell.com>
15416 Fix test-327.cs, test-328.cs, and put in early infrastructure
15417 for eventually fixing #52697.
15418 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15419 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15420 from other methods.
15421 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15422 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15423 (VerifyUsing, error246): Update.
15424 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15425 'NamespaceEntry.LookupNamespaceOrType'.
15427 2004-12-03 Martin Baulig <martin@ximian.com>
15429 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15430 method as our child, call AnonymousMethod.Compatible() on it.
15432 2004-12-03 Raja R Harinath <rharinath@novell.com>
15434 Disable XML documentation support in 'basic' profile.
15435 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15436 Redirect XmlElement to System.Object.
15437 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15438 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15439 * mcs.exe.sources: Add doc-bootstrap.cs.
15440 * doc-bootstrap.cs: New file. Contains empty stub implementation
15443 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15445 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15446 comments are allowed.
15448 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15450 * delegate.cs: Add checks for subtypes in paramaters and return values
15451 in VerifyMethod () to add support for Covariance/Contravariance
15454 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15456 * report.cs: Remove extra closing parenthesis.
15458 * convert.cs (Error_CannotImplicitConversion): If the name of the
15459 types are the same, provide some extra information.
15461 * class.cs (FieldBase): Use an unused bit field from the field to
15462 encode the `has_offset' property from the FieldMember. This saves
15463 a couple of Ks on bootstrap compilation.
15465 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15466 method as our child, return the AnonymousMethod resolved
15469 * expression.cs (New.DoResolve): Allow return values from
15470 NewDelegate to also include AnonymousMethods.
15474 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15477 * attribute.cs (Resolve): Improved implementation of params
15478 attribute arguments.
15480 * support.cs (ParameterData): Add HasParams to be faster.
15482 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15484 all things are for /doc support:
15486 * doc.cs: new file that supports XML documentation generation.
15487 * mcs.exe.sources: added doc.cs.
15489 Handle /doc command line option.
15490 Report error 2006 instead of 5 for missing file name for /doc.
15491 Generate XML documentation when required, after type resolution.
15493 Added support for picking up documentation (/// and /** ... */),
15494 including a new XmlCommentState enumeration.
15496 Added lines to fill Documentation element for field, constant,
15497 property, indexer, method, constructor, destructor, operator, event
15498 and class, struct, interface, delegate, enum.
15499 Added lines to warn incorrect comment.
15501 Added Documentation field (passed only when /doc was specified).
15503 Added DocComment, DocCommentHeader, GenerateDocComment() and
15504 OnGenerateDocComment() and some supporting private members for
15505 /doc feature to MemberCore.
15507 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15509 Added overriden DocCommentHeader.
15511 Added overriden DocCommentHeader and GenerateDocComment().
15513 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15515 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15516 unwrapping the enumeration values, chain to
15517 DoConstantNumericPromotions again, so we can promote things to the
15518 fundamental types (takes care of enums that are bytes, sbytes).
15522 2004-12-01 Raja R Harinath <rharinath@novell.com>
15524 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15525 Fix long-standing bug in type-lookup. Use FindType instead of
15526 LookupType when ec.ResolvingTypeTree.
15527 (Attribute.ResolveType, Attribute.Resolve)
15528 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15530 (Attributes.Search): Remove internal version. Update.
15531 (Attributes.SearchMulti): Update.
15532 (Attributes.GetClsCompliantAttribute): Remove.
15533 (Attributes.GetIndexerNameAttribute): Remove.
15534 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15535 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15536 * class.cs (Indexer.Define): Likewise.
15538 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15541 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15542 MarshallByReference members access.
15544 * expression.cs: Use CheckMarshallByRefAccess;
15545 Better error CS0197 message.
15547 * report.cs: Print whole related error message.
15549 2004-11-30 Raja R Harinath <rharinath@novell.com>
15551 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15552 the current directory to help debugging.
15554 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15556 * class (GetClassBases): Better error 60 report.
15557 (EventProperty): Disabled warning 67 detection.
15559 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15562 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15564 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15567 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15570 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15572 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15574 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15576 * attribute.cs (Attribute.Resolve): Refine error reporting and
15577 report a cs0117 if the identifier does not exist, to distinguish
15578 from 0617 which is a miss-use of the actual identifier.
15580 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15581 between cs0070 and cs0079.
15583 * class.cs (MemberBase.DoDefine): When reporting a wrong
15584 accessibility level, we use MethodCore to compare instead of
15585 Method (this was a regression in some refactoring effort).
15587 So now we correctly report cs0056 again.
15589 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
15590 testing the target_type (which was known to be object_type) and
15591 not the source type (which is anonymous_method).
15593 Fixed reporting of error cs1660.
15595 * expression.cs (UserCast.Source): Expose the underlying cast.
15597 * statement.cs (Switch.SwitchGoverningType): Sort the list of
15598 allowed types to find a match to int32 first (most common).
15600 In addition, it ignores any ImplicitUserConversions that did an
15601 internal implicit conversion (as the switch statement allows only
15602 one integral conversion to exist).
15604 * class.cs (PartialContainer.Create): rename `name' to
15605 `member_name' for clarity. Then replace the string calls with a
15606 call to MemberName.GetPartialName, as now using
15607 MemberName.ToString is an error (this is due to the side effects
15608 it had, that were fixed in the past).
15610 This will restore the error reporting on a number of partial class
15611 errors that were missusing this (and getting an exception as a
15612 results, which is now just a plain textual warning, because
15613 yyparse debug output would crash otherwise).
15615 2004-11-26 Raja R Harinath <rharinath@novell.com>
15617 * Makefile (PROGRAM_INSTALL_DIR): Remove.
15619 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15621 * rootcontext.cs (LookupType): Make sure to cache lookups that
15622 don't give us a negative result. This saves about 5% of corlib
15625 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15627 * report.cs (AbstractMessage.Print): messages are sent to stderr
15629 * class.cs (TypeContainer.GetClassBases): It is an error to have a
15630 non-interface in the list of interfaces (at this point, either
15631 parent was properly set, or a base class is being listed in the
15632 interfaces section).
15634 This flags error 1722, and resolves the crash from bug 69259.
15636 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15638 * statement.cs (Using.EmitExpressionFinally): make this work right
15639 for valuetypes. Fixes 69926.
15641 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15643 * const.cs (Const.ChangeType): Cope with the "0 literal can be
15644 converted to an enum" here, before we try to change the underlying
15645 type. This code exists, but it is a different code path than the
15646 one used while encoding constants.
15648 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
15649 old bug: when converting from the null literal to a pointer,
15650 return an EmptyCast, not the NullLiteral.
15652 This fixes #69921, the recent null_type changes probably made this
15653 bug more prominent.
15655 (ImplicitReferenceConversionExists): In addition, resynchronized
15656 the code here, so it matches the same code in
15657 ImplicitReferenceConversionExists for the `from any class-type S
15658 to any interface-type T'.
15661 2004-11-25 Marek Safar <marek.safar@seznam.cz>
15663 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
15665 2004-11-24 Miguel de Icaza <miguel@ximian.com>
15667 * cs-parser.jay: Use verbosity accordingly.
15669 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15671 * expression.cs (Unary.ResolveOperator): Do not report warning;
15672 AddressOf reads from variable.
15674 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
15676 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15680 * attribute.cs (Attributable): Removed CheckTargets.
15681 (Attributes.Emit): Explicit attribute targets are tested here.
15683 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
15684 not enabled for interfaces.
15686 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
15687 (GetAssemblyName): Ouch next bug there.
15689 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15691 * expression.cs: Error 275 added.
15693 2004-11-23 Marek Safar <marek.safar@seznam.cz>
15695 Fix bug #69177 (Implemented decimal constant support)
15697 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
15698 (BinaryFold): Add DecimalConstant.
15700 * const.cs (Define): Decimal constant
15702 (ChangeType): Add decimal type handling.
15703 (LookupConstantValue): Don't set value for decimal type but
15704 emit DecimalConstantAttribute. Needed for constant optimization.
15706 * constant.cs (ToDecimal): New method.
15707 (ConvertToDecimal): New method.
15708 (IntConstant): Implemented ConvertToDecimal.
15709 (DecimalConstant.Emit): Emit optimized version for decimals in
15712 * expression.cs (ResolveOperator): Changed order of constant
15713 reduction to work correctly with native types which have
15714 overloaded operators.
15715 (ResolveMemberAccess): Extract constant value from attribute
15718 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
15720 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
15721 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
15722 (ChangeType): Decimal is special.
15723 (TypeToCoreType): Add decimal type.
15725 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15727 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
15730 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15732 * class.cs (EventField.ApplyAttributeBuilder): Fix error
15735 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15737 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
15739 * pending.cs (PendingImplementation): Grab only interfaces.
15741 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15743 * statement.cs (ForeachHelperMethods): Add location member and
15744 error 202 detection.
15746 2004-11-19 Raja R Harinath <rharinath@novell.com>
15748 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
15749 automatically handled by executable.make.
15750 (PROGRAM): Make profile-specific.
15752 2004-11-18 Marek Safar <marek.safar@seznam.cz>
15754 * expression.cs (DoResolveBase): Fixed wrong warning for out
15757 2004-11-18 Martin Baulig <martin@ximian.com>
15759 Merged latest changes into gmcs. Please keep this comment in
15760 here, it makes it easier for me to see what changed in MCS since
15761 the last time I merged.
15763 2004-11-17 Raja R Harinath <rharinath@novell.com>
15765 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
15766 (TypeHandle.GetMemberCache): New.
15767 (TypeHandle.TypeHandle): Update.
15768 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
15769 (TypeManager.LookupParentInterfacesCache):
15770 Rename from LookupInterfaceCache. Optimize slightly.
15771 (TypeManager.MemberLookup_FindMembers): Update.
15772 * decl.cs (MemberCache.MemberCache): Set Container to null in the
15773 multi-type variant.
15774 (AddCacheContents): Rename from AddHashtable.
15775 * class.cs (TypeContainer.parent_container): Remove.
15776 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
15777 (TypeContainer.DoDefineMembers): Don't initialize it.
15778 Update to name changes.
15780 2004-11-17 Miguel de Icaza <miguel@ximian.com>
15782 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
15783 that factors the code to check access modifiers on override.
15785 (PropertyBase): Use the code here.
15787 Patch from Lluis S'anchez, fixes bug #69361.
15789 2004-11-15 Miguel de Icaza <miguel@ximian.com>
15791 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
15792 routine that is used to report the use of a captured variable
15793 whose address has been taken.
15795 There are two checks: one when variables are being captured and
15796 the other check is when the address of a variable is taken.
15798 (because an anonymous methods might be resolved before *or* after
15799 the address has been taken) and
15801 * expression.cs (Conditional.DoResolve): Remove the special
15802 casing that Martin added to trueExpr and falseExpr being both
15803 NullLiteral. We get the right behavior now just by introducing
15804 the null_type into the compiler.
15806 * convert.cs (ExplicitConversion): Change the code to use
15807 null_type instead of testing `expr is NullLiteral'.
15808 (ImplicitConversionStandard): use null_type too.
15809 (ImplicitReferenceConversionExists): use null_type too.
15810 (ImplicitReferenceConversion): use null_type too.
15812 * literal.cs: The type of `NullLiteral' is now null_type instead
15814 (Resolve): Set the type here.
15816 * typemanager.cs: Introduce null_type.
15818 2004-11-17 Martin Baulig <martin@ximian.com>
15820 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
15821 direction, like FindMembers() does. Fixes #69546, testcase is in
15824 2004-11-16 Martin Baulig <martin@ximian.com>
15826 This is based on a patch from Marek Safar, see bug #69082.
15827 Fixes bugs #63705 and #67130.
15829 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
15830 method; create a MemberCache for an interface type and cache the
15833 * decl.cs (IMemberContainer.ParentContainer): Removed.
15834 (IMemberContainer.ParentCache): New property.
15835 (MemberCache.SetupCacheForInterface): Removed.
15836 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
15837 to create a cache for an interface's "parent".
15839 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
15842 2004-11-16 Martin Baulig <martin@ximian.com>
15844 Merged back from gmcs; these changes already went into gmcs a
15845 couple of weeks ago.
15848 (TypeManager.AddUserType): Removed the `ifaces' argument.
15849 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
15851 (TypeManager.AddUserInterface): Removed.
15852 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
15854 (TypeManager.GetInterfaces): Likewise.
15855 (TypeManager.GetExplicitInterfaces): Likewise.
15857 * ecore.cs (TypeExpr.GetInterfaces): Removed.
15859 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
15860 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
15862 2004-11-14 Ben Maurer <bmaurer@ximian.com>
15864 * statement.cs: Avoid adding bools to a hashtable.
15866 2004-11-07 Miguel de Icaza <miguel@ximian.com>
15868 * expression.cs (Invocation.OverloadResolve): Flag error if we are
15869 calling an unsafe method from a safe location.
15871 2004-11-06 Marek Safar <marek.safar@seznam.cz>
15874 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
15876 2004-11-06 Miguel de Icaza <miguel@ximian.com>
15878 * namespace.cs (VerifyUsing): use GetPartialName instead of
15881 2004-11-05 Miguel de Icaza <miguel@ximian.com>
15883 * statement.cs (Return.Resolve): Fix regression in typo: if
15884 `in_exc', we have to request a NeedReturnLabel, this was a typo
15885 introduced in the anonymous method check-in. Fixes #69131.
15887 * Indexers were using the ShortName when defining themselves,
15888 causing a regression in the compiler bootstrap when applying the
15889 patch from 2004-11-02 (first part), now they use their full name
15890 and the bug is gone.
15892 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
15894 * driver.cs: Strip the path from the names of embedded resources. Fixes
15897 2004-11-04 Raja R Harinath <rharinath@novell.com>
15899 Fix error message regression: cs0104-2.cs.
15900 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
15901 (AliasEntry.Resolve): Update.
15902 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
15904 (RootContext.LookupType): Update.
15906 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
15908 * cs-parser.jay: Add support for handling accessor modifiers
15909 * class: Add support port accessor modifiers and error checking,
15910 define PropertyMethod.Define as virtual (not abstract anymore)
15911 * ecore.cs: Add checking for proeprties access with access modifiers
15912 * iterators.cs: Modify Accessor constructor call based in the modified
15914 2004-11-02 Ben Maurer <bmaurer@ximian.com>
15916 * expression.cs (StringConcat): Handle being called twice,
15917 as when we have a concat in a field init with more than two
15920 2004-11-02 Miguel de Icaza <miguel@ximian.com>
15922 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
15923 special case explicit implementations, we should always produce
15924 the .property or .event declaration.
15926 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
15927 since it will not return correct data if people use this
15928 unresolved in the presence of using statements (see test-313).
15930 * class.cs (MethodData.Define): If we are an explicit interface
15931 implementation, set the method name to the full name of the
15932 interface plus the name of the method.
15934 Notice that using the method.MethodName.GetFullName() does not
15935 work, as it will only contain the name as declared on the source
15936 file (it can be a shorthand in the presence of using statements)
15937 and not the fully qualifed type name, for example:
15941 class D : ICloneable {
15942 object ICloneable.Clone () {
15946 Would produce a method called `ICloneable.Clone' instead of
15947 `System.ICloneable.Clone'.
15949 * namespace.cs (Alias.Resolve): Use GetPartialName.
15951 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15953 * cs-parser.jay: Add error 1055 report.
15955 2004-11-01 Miguel de Icaza <miguel@ximian.com>
15957 * assign.cs (Assign.DoResolve): Only do the transform of
15958 assignment into a New if the types are compatible, if not, fall
15959 through and let the implicit code deal with the errors and with
15960 the necessary conversions.
15962 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15964 * cs-parser.jay: Add error 1031 report.
15966 * cs-tokenizer.cs: Add location for error 1038.
15968 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15970 * cs-parser.jay: Add error 1016 report.
15972 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15974 * cs-parser.jay: Add errors 1575,1611 report.
15976 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15978 * cs-parser.jay: Add error 1001 report.
15980 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15983 * attribute.cs (GetMarshal): Add method argument for
15984 caller identification.
15986 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
15987 agument for GetMarshal and RuntimeMissingSupport.
15989 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15991 * attribute.cs (ExtractSecurityPermissionSet): Removed
15992 TypeManager.code_access_permission_type.
15994 * typemanager.cs: Removed TypeManager.code_access_permission_type.
15996 2004-10-27 Miguel de Icaza <miguel@ximian.com>
15998 * expression.cs (LocalVariableReference.DoResolveLValue): Check
15999 for obsolete use of a variable here. Fixes regression on errors
16000 cs0619-25 and cs0619-26.
16002 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16004 Fix #62358, implemented security attribute encoding.
16006 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16007 Tests permitted SecurityAction for assembly or other types.
16008 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16009 data from SecurityPermissionAttribute to PermisionSet class.
16011 * class.cs (ApplyAttributeBuilder): Added special handling
16012 for System.Security.Permissions.SecurityAttribute based types.
16014 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16015 special handling for System.Security.Permissions.SecurityAttribute
16018 * enum.cs (ApplyAttributeBuilder): Added special handling
16019 for System.Security.Permissions.SecurityAttribute based types.
16021 * parameter.cs (ApplyAttributeBuilder): Added special handling
16022 for System.Security.Permissions.SecurityAttribute based types.
16024 * rootcontext.cs: Next 2 core types.
16026 * typemanager.cs (TypeManager.security_permission_attr_type):
16027 Built in type for the SecurityPermission Attribute.
16028 (code_access_permission_type): Build in type.
16030 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16032 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16033 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16034 all of this information into
16035 EmitContext.EmitCapturedVariableInstance.
16037 * codegen.cs (EmitCapturedVariableInstance): move here the
16038 funcionality of emitting an ldarg.0 in the presence of a
16039 remapping. This centralizes the instance emit code.
16041 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16042 then emit a load of this: it means that we have reached the
16043 topmost ScopeInfo: the one that contains the pointer to the
16044 instance of the class hosting the anonymous method.
16046 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16047 captures to the topmost CaptureContext.
16049 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16051 * expression.cs (LocalVariableReference): Move the knowledge about
16052 the iterators into codegen's EmitCapturedVariableInstance.
16054 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16056 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16057 all code paths return a value from an anonymous method (it is the
16058 same as the 161 error, but for anonymous methods).
16060 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16062 The introduction of anonymous methods in the compiler changed
16063 various ways of doing things in the compiler. The most
16064 significant one is the hard split between the resolution phase
16065 and the emission phases of the compiler.
16067 For instance, routines that referenced local variables no
16068 longer can safely create temporary variables during the
16069 resolution phase: they must do so from the emission phase,
16070 since the variable might have been "captured", hence access to
16071 it can not be done with the local-variable operations from the runtime.
16075 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16076 is a toplevel block.
16078 (ToplevelBlock): A new kind of Block, these are the blocks that
16079 are created by the parser for all toplevel method bodies. These
16080 include methods, accessors and anonymous methods.
16082 These contain some extra information not found in regular blocks:
16083 A pointer to an optional CaptureContext (for tracking captured
16084 local variables and parameters). A pointer to the parent
16087 (Return.Resolve): Catch missmatches when returning a value from an
16088 anonymous method (error 1662).
16089 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16092 (Break.Resolve): ditto.
16094 (SwitchLabel): instead of defining the labels during the
16095 resolution phase, we now turned the public ILLabel and ILLabelCode
16096 labels into methods called GetILLabelCode() and GetILLabel() that
16097 only define the label during the Emit phase.
16099 (GotoCase): Track the SwitchLabel instead of the computed label
16100 (its contained therein). Emit the code by using
16101 SwitchLabel.GetILLabelCode ().
16103 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16104 whether the Local has been captured or not.
16106 (LocalInfo.IsCaptured): New property, used to tell whether the
16107 local has been captured.
16109 * anonymous.cs: Vastly updated to contain the anonymous method
16112 The main classes here are: CaptureContext which tracks any
16113 captured information for a toplevel block and ScopeInfo used to
16114 track the activation frames for various local variables.
16116 Each toplevel block has an optional capture context associated
16117 with it. When a method contains an anonymous method both the
16118 toplevel method and the anonymous method will create a capture
16119 context. When variables or parameters are captured, they are
16120 recorded on the CaptureContext that owns them, for example:
16124 MyDelegate d = delegate {
16129 Here `a' will be recorded as captured on the toplevel
16130 CapturedContext, the inner captured context will not have anything
16131 (it will only have data if local variables or parameters from it
16132 are captured in a nested anonymous method.
16134 The ScopeInfo is used to track the activation frames for local
16135 variables, for example:
16137 for (int i = 0; i < 10; i++)
16138 for (int j = 0; j < 10; j++){
16139 MyDelegate d = delegate {
16144 At runtime this captures a single captured variable `i', but it
16145 captures 10 different versions of the variable `j'. The variable
16146 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16147 recorded on a child.
16149 The toplevel ScopeInfo will also track information like the `this'
16150 pointer if instance variables were referenced (this is necessary
16151 as the anonymous method lives inside a nested class in the host
16152 type of the method).
16154 (AnonymousMethod): Expanded to track the Toplevel, implement
16155 `AnonymousMethod.Compatible' to tell whether an anonymous method
16156 can be converted to a target delegate type.
16158 The routine now also produces the anonymous method content
16160 (AnonymousDelegate): A helper class that derives from
16161 DelegateCreation, this is used to generate the code necessary to
16162 produce the delegate for the anonymous method that was created.
16164 * assign.cs: API adjustments for new changes in
16165 Convert.ImplicitStandardConversionExists.
16167 * class.cs: Adjustments to cope with the fact that now toplevel
16168 blocks are of type `ToplevelBlock'.
16170 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16171 insteda of standard blocks.
16173 Flag errors if params arguments are passed to anonymous methods.
16175 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16176 `CurrentAnonymousMethod' which points to the current Anonymous
16177 Method. The variable points to the AnonymousMethod class that
16178 holds the code being compiled. It is set in the new EmitContext
16179 created for the anonymous method.
16181 (EmitContext.Phase): Introduce a variable and an enumeration to
16182 assist in enforcing some rules about when and where we are allowed
16183 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16184 only one that enfonces this right now).
16186 (EmitContext.HaveCaptureInfo): new helper method that returns
16187 whether we have a CapturedContext initialized.
16189 (EmitContext.CaptureVariable): New method used to register that a
16190 LocalInfo must be flagged for capturing.
16192 (EmitContext.CapturedParameter): New method used to register that a
16193 parameters must be flagged for capturing.
16195 (EmitContext.CapturedField): New method used to register that a
16196 field must be flagged for capturing.
16198 (EmitContext.HaveCapturedVariables,
16199 EmitContext.HaveCapturedFields): Return whether there are captured
16200 variables or fields.
16202 (EmitContext.EmitMethodHostInstance): This is used to emit the
16203 instance for the anonymous method. The instance might be null
16204 (static methods), this (for anonymous methods that capture nothing
16205 and happen to live side-by-side with the current method body) or a
16206 more complicated expression if the method has a CaptureContext.
16208 (EmitContext.EmitTopBlock): Routine that drives the emission of
16209 code: it will first resolve the top block, then emit any metadata
16210 and then emit the code. The split is done so that we can extract
16211 any anonymous methods and flag any captured variables/parameters.
16213 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16214 during this phase, the ILGenerator should not be used as labels
16215 and local variables declared here might not be accessible to any
16216 code that is part of an anonymous method.
16218 Exceptions to this include the temporary variables that are
16219 created by some statements internally for holding temporary
16222 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16225 (EmitContext.TemporaryReturn): This method is typically called
16226 from the Emit phase, and its the only place where we allow the
16227 ReturnLabel to be defined other than the EmitMeta. The reason is
16228 that otherwise we would have to duplicate a lot of logic in the
16229 Resolve phases of various methods that today is on the Emit
16232 (EmitContext.NeedReturnLabel): This no longer creates the label,
16233 as the ILGenerator is not valid during the resolve phase.
16235 (EmitContext.EmitThis): Extended the knowledge in this class to
16236 work in anonymous methods in addition to iterators.
16238 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16239 code is necessary on the stack to access the instance to a local
16240 variable (the variable will be accessed as a field).
16242 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16243 EmitContext.EmitAddressOfParameter): Routines to support
16244 parameters (not completed at this point).
16246 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16247 will also remove the parameters.
16249 * convert.cs (Convert): Define a `ConstantEC' which points to a
16250 null. This is just to prefity some code that uses
16251 ImplicitStandardConversion code and do not have an EmitContext
16254 The idea is to flag explicitly that at that point in time, it is
16255 known that the conversion will not trigger the delegate checking
16256 code in implicit conversions (which requires a valid
16259 Everywhere: pass new EmitContext parameter since
16260 ImplicitStandardConversionExists now requires it to check for
16261 anonymous method conversions.
16263 (Convert.ImplicitStandardConversionExists): If the type of an
16264 expression is the anonymous_method_type, and the type is a
16265 delegate, we invoke the AnonymousMethod.Compatible method to check
16266 whether an implicit conversion is possible.
16268 (Convert.ImplicitConversionStandard): Only do implicit method
16269 group conversions if the language level is not ISO_1.
16271 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16272 MethodInfo for the Invoke method. used by Delegate and
16275 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16276 method conversions if the target type is a delegate.
16278 Removed extra debugging nops.
16280 (LocalVariableReference): Turn the `local_info' into a public
16283 Add `prepared' field, the same hack used for FieldExprs to cope
16284 with composed assignments, as Local variables do not necessarily
16285 operate purely on the stack as they used to: they can be captured
16288 Add `temp' for a temporary result, like fields.
16290 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16292 It now copes with Local variables that are captured and emits the
16293 proper instance variable to load it from a field in the captured
16296 (ParameterReference.DoResolveBase): During the resolve phase,
16297 capture parameters if we are in an anonymous method.
16299 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16300 anonymous method, use the EmitContext helper routines to emit the
16301 parameter reference.
16303 * iterators.cs: Set RemapToProxy to true/false during the
16306 * parameters.cs (GetParameterByName): New helper method.
16308 * typemanager.cs (anonymous_method_type) a new type that
16309 represents an anonyous method. This is always an internal type,
16310 used as a fencepost to test against the anonymous-methodness of an
16313 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16315 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16317 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16319 2004-10-18 Martin Baulig <martin@ximian.com>
16321 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16322 `Type' directly, but call ResolveType() on it.
16323 (Catch.Resolve): Likewise.
16324 (Foreach.Resolve): Likewise.
16326 2004-10-18 Martin Baulig <martin@ximian.com>
16328 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16329 `Type' directly, but call ResolveType() on it.
16330 (Probe.DoResolve): Likewise.
16331 (ArrayCreation.LookupType): Likewise.
16332 (TypeOf.DoResolve): Likewise.
16333 (SizeOf.DoResolve): Likewise.
16335 2004-10-18 Martin Baulig <martin@ximian.com>
16337 * expression.cs (Invocation.BetterFunction): Put back
16338 TypeManager.TypeToCoreType().
16340 2004-10-18 Raja R Harinath <rharinath@novell.com>
16342 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16345 2004-10-18 Martin Baulig <martin@ximian.com>
16347 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16348 `Type' directly, but call ResolveType() on it.
16350 2004-10-18 Martin Baulig <martin@ximian.com>
16352 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16353 `Type' directly, but call ResolveType() on it.
16354 (MemberBase.DoDefine): Likewise.
16356 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16357 `Type' directly, but call ResolveType() on it.
16358 (ComposedCast.DoResolveAsTypeStep): Likewise.
16360 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16361 `Type' directly, but call ResolveType() on it.
16363 2004-10-17 John Luke <john.luke@gmail.com>
16365 * class.cs (Operator.GetSignatureForError): use CSharpName
16367 * parameter.cs (Parameter.GetSignatureForError): Returns
16368 correct name even if was not defined.
16370 2004-10-13 Raja R Harinath <rharinath@novell.com>
16373 * class.cs (TypeContainer.EmitContext): New property.
16374 (DefineNestedTypes): Create an emitcontext for each part.
16375 (MethodCore.DoDefineParameters): Use container's emitcontext.
16376 Pass type array to InternalParameters.
16377 (MemberBase.DoDefine): Use container's emitcontext.
16378 (FieldMember.Define): Likewise.
16379 (Event.Define): Likewise.
16380 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16381 Pass type array to InternalParameters.
16382 (SetIndexerMethod.GetParameterInfo): Likewise.
16383 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16384 * delegate.cs (Define): Pass emitcontext to
16385 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16386 array to InternalParameters.
16387 * expression.cs (ParameterReference.DoResolveBase): Pass
16388 emitcontext to GetParameterInfo.
16389 (ComposedCast.DoResolveAsTypeStep): Remove check on
16390 ec.ResolvingTypeTree.
16391 * parameter.cs (Parameter.Resolve): Change argument to
16392 EmitContext. Use ResolveAsTypeTerminal.
16393 (Parameter.GetSignature): Change argument to EmitContext.
16394 (Parameters.ComputeSignature): Likewise.
16395 (Parameters.ComputeParameterTypes): Likewise.
16396 (Parameters.GetParameterInfo): Likewise.
16397 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16398 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16399 * support.cs (InternalParameters..ctor): Remove variant that takes
16401 * typemanager.cs (system_intptr_expr): New.
16402 (InitExpressionTypes): Initialize it.
16404 2004-10-12 Chris Toshok <toshok@ximian.com>
16406 * cs-parser.jay: fix location for try_statement and catch_clause.
16408 2004-10-11 Martin Baulig <martin@ximian.com>
16410 * report.cs: Don't make --fatal abort on warnings, we have
16411 -warnaserror for that.
16413 2004-10-07 Raja R Harinath <rharinath@novell.com>
16415 More DeclSpace.ResolveType avoidance.
16416 * decl.cs (MemberCore.InUnsafe): New property.
16417 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16418 with newly created EmitContext.
16419 (FieldMember.Define): Likewise.
16420 * delegate.cs (Delegate.Define): Likewise.
16421 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16422 only if normal name-lookup fails.
16423 (TypeExpr.DoResolve): Enable error-checking.
16424 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16425 (SizeOf.DoResolve): Likewise.
16426 (ComposedCast.DoResolveAsTypeStep): Likewise.
16427 (StackAlloc.DoResolve): Likewise.
16428 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16429 (Block.Unsafe): New property.
16430 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16431 (Unsafe): Set 'unsafe' flag of contained block.
16432 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16433 (Fixed.Resolve): Likewise.
16434 (Catch.Resolve): Likewise.
16435 (Using.ResolveLocalVariableDecls): Likewise.
16436 (Foreach.Resolve): Likewise.
16438 2004-10-05 John Luke <john.luke@gmail.com>
16440 * cs-parser.jay: add location to error CS0175
16442 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16444 * ecore.cs (Expression.Constantity): Add support for turning null
16447 * const.cs (Const.Define): Allow constants to be reference types
16448 as long as the value is Null.
16450 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16452 * namespace.cs (NamespaceEntry.Using): No matter which warning
16453 level is set, check if this namespace name has already been added.
16455 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16457 * expression.cs: reftype [!=]= null should always use br[true,false].
16460 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16463 * attribute.cs: Enum conversion moved to
16464 GetAttributeArgumentExpression to be applied to the all
16467 2004-10-01 Raja R Harinath <rharinath@novell.com>
16469 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16470 * class.c (TypeContainer.DefineType): Flag error if
16471 base types aren't accessible due to access permissions.
16472 * decl.cs (DeclSpace.ResolveType): Move logic to
16473 Expression.ResolveAsTypeTerminal.
16474 (DeclSpace.ResolveTypeExpr): Thin layer over
16475 Expression.ResolveAsTypeTerminal.
16476 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16477 Refactor code into NestedAccess. Use it.
16478 (DeclSpace.NestedAccess): New.
16479 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16480 argument to silence errors. Check access permissions.
16481 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16482 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16483 (Cast.DoResolve): Likewise.
16484 (New.DoResolve): Likewise.
16485 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16486 (TypeOf.DoResolve): Likewise.
16488 * expression.cs (Invocation.BetterConversion): Return the Type of
16489 the better conversion. Implement section 14.4.2.3 more faithfully.
16490 (Invocation.BetterFunction): Make boolean. Make correspondence to
16491 section 14.4.2.2 explicit.
16492 (Invocation.OverloadResolve): Update.
16493 (Invocation): Remove is_base field.
16494 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16495 (Invocation.Emit): Likewise.
16497 2004-09-27 Raja R Harinath <rharinath@novell.com>
16499 * README: Update to changes.
16501 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16503 * cs-parser.jay: Reverted 642 warning fix.
16505 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16508 * decl.cs (FindMemberWithSameName): Indexer can have more than
16511 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16513 * expression.cs (LocalVariableReference.DoResolveLValue):
16514 Do not report warning 219 for out values.
16515 (EmptyExpression.Null): New member to avoid extra allocations.
16517 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16519 * cs-parser.jay: Fix wrong warning 642 report.
16521 * cs-tokenizer.cs (CheckNextToken): New helper;
16522 Inspect next character if is same as expected.
16524 2004-09-23 Martin Baulig <martin@ximian.com>
16526 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16527 (Convert.ImplicitReferenceConversionExists): Likewise.
16529 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16531 * class.cs (Operator.Define): Add error 448 and 559 report.
16533 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16535 * class.cs (MemberBase.IsTypePermitted): New protected
16536 method for checking error CS0610.
16538 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16540 * class.cs (TypeContainer.HasExplicitLayout): New property
16541 Returns whether container has StructLayout attribute set Explicit.
16542 (FieldMember): New abstract class for consts and fields.
16543 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16544 (Field): Reuse FieldMember.
16546 * const.cs (Const): Reuse FieldMember.
16548 * rootcontext.cs: EmitConstants call moved to class.
16550 2004-09-22 Martin Baulig <martin@ximian.com>
16552 Thanks to Peter Sestoft for this bug report.
16554 * expression.cs (Conditional): If both the `trueExpr' and the
16555 `falseExpr' is a NullLiteral, return a NullLiteral.
16557 2004-09-22 Martin Baulig <martin@ximian.com>
16559 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16560 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16561 for the "get_Current" call.
16563 2004-09-22 Martin Baulig <martin@ximian.com>
16565 Marek and me just fixed one of our oldest bugs: #28562 :-)
16567 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16569 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16570 we're an EnumConstant, just return that.
16571 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16572 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16573 to get the value which'll actually be written into the attribute.
16574 However, we have to use GetValue() to access the attribute's value
16577 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16579 * constant.cs (Constant.IsNegative): New abstract property
16582 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16583 (StackAlloc.DoResolve): Reused IsNegative.
16585 2004-09-21 Martin Baulig <martin@ximian.com>
16587 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
16588 if we're used in an iterator, we may be called from different
16591 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
16592 we actually have an exception block.
16594 2004-09-20 John Luke <jluke@cfl.rr.com>
16596 * class.cs, cs-parser.jay: Improve the error report for 1520:
16597 report the actual line where the error happens, not where the
16598 class was declared.
16600 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
16601 Pass location information that was available elsewhere.
16603 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
16605 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
16606 runtime to delay sign assemblies.
16608 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16610 * cs-parser.jay: Do not report the stack trace, this is barely
16613 2004-08-22 John Luke <john.luke@gmail.com>
16615 * driver.cs : check that a resource id is not already used
16616 before adding it, report CS1508 if it is, bug #63637
16618 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16620 * ecore.cs: Removed dead code.
16622 2004-09-18 Marek Safar <marek.safar@seznam.cz>
16624 * class.cs: Do not report warning CS0067 on the interfaces.
16626 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16628 * cs-parser.jay: Add error 504 report.
16630 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16632 * rootcontext.cs: WarningLevel is 4 by default now.
16634 * statement.cs (Fixed.Resolve): Do not null
16637 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16640 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
16641 deep search when property is not virtual.
16642 (PropertyExpr.ResolveAccessors): Make one call for both
16645 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16648 * statement.cs: Error 152 report constains also location.
16650 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16653 * const.cs: Explicitly set constant as static.
16655 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16658 * cs-parser.jay: Add error 1017 report.
16660 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16662 Fixed bug #59980, #64224
16663 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
16665 * typemanager.cs (IsSpecialMethod): Simplified
16667 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16669 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
16670 condition with better params.
16672 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16675 * attribute.cs (Resolve): Property has to have both
16678 2004-09-14 Martin Baulig <martin@ximian.com>
16680 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
16682 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16685 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
16686 called and is obsolete then this member suppress message
16687 when call is inside next [Obsolete] method or type.
16689 * expression.cs: Use TestObsoleteMethodUsage member.
16691 2004-09-14 Martin Baulig <martin@ximian.com>
16693 * cs-parser.jay: Sync a bit with the GMCS version.
16695 2004-09-14 Martin Baulig <martin@ximian.com>
16697 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
16698 (CSharpParser.yacc_verbose_flag): New public field.
16700 * genericparser.cs: Removed.
16702 2004-09-14 Raja R Harinath <rharinath@novell.com>
16704 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
16706 2004-09-13 Marek Safar <marek.safar@seznam.cz>
16708 * class.cs (MethodCore.CheckBase): Fix bug #65757.
16710 2004-09-10 Martin Baulig <martin@ximian.com>
16712 Backported my MemberName changes from GMCS into MCS.
16714 - we are now using a special `MemberName' class instead of using
16715 strings; in GMCS, the `MemberName' also contains the type
16718 - changed the grammar rules a bit:
16719 * the old `member_name' is now a `namespace_or_type_name':
16720 The rule is that we use `namespace_or_type_name' everywhere
16721 where we expect either a "member name" (GetEnumerator) or a
16722 "member name" with an explicit interface name
16723 (IEnumerable.GetEnumerator).
16724 In GMCS, the explicit interface name may include type arguments
16725 (IEnumerable<T>.GetEnumerator).
16726 * we use `member_name' instead of just `IDENTIFIER' for
16728 The rule is that we use `member_name' wherever a member may
16729 have type parameters in GMCS.
16731 * decl.cs (MemberName): New public class.
16732 (MemberCore.MemberName): New public readonly field.
16733 (MemberCore.ctor): Take a `MemberName' argument, not a string.
16734 (DeclSpace): Likewise.
16736 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
16737 * enum.cs (Enum.ctor): Likewise.
16739 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
16741 (AliasEntry.ctor): Take a MemberName, not an Expression.
16742 (AliasEntry.UsingAlias): Likewise.
16744 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
16745 (IMethodData.MemberName): Changed type from string to MemberName.
16746 (MemberBase.ExplicitInterfaceName): Likewise.
16747 (AbstractPropertyEventMethod.SetupName): Make this private.
16748 (AbstractPropertyEventMethod.ctor): Added `string prefix'
16749 argument; compute the member name here.
16750 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
16751 on the `member.MemberName' and the `prefix'.
16753 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
16755 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
16756 thus, we get a `MemberName' instead of a `string'. These
16757 declarations may have type parameters in GMCS.
16758 (interface_method_declaration, delegate_declaration): Likewise.
16759 (class_declaration, interface_declaration): Likewise.
16760 (method_header): Use `namespace_or_type_name' instead of
16761 `member_name'. We may be an explicit interface implementation.
16762 (property_declaration, event_declaration): Likewise.
16763 (member_name): This is now just an `IDENTIFIER', not a
16764 `namespace_or_type_name'.
16765 (type_name, interface_type): Removed.
16766 (namespace_or_type_name): Return a MemberName, not an Expression.
16767 (primary_expression): Use `member_name' instead of `IDENTIFIER';
16768 call GetTypeExpression() on the MemberName to get an expression.
16769 (IndexerDeclaration.interface_type): Changed type from string to
16771 (MakeName): Operate on MemberName's instead of string's.
16773 2004-09-13 Raja R Harinath <rharinath@novell.com>
16776 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
16777 (NamespaceEntry.Lookup): Add new argument to flag if we want the
16778 lookup to avoid symbols introduced by 'using'.
16779 * rootcontext.cs (NamespaceLookup): Update.
16781 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16783 * class.cs (TypeContainer.DoDefineMembers): Do not call
16784 DefineDefaultConstructor for static classes.
16786 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16788 * attribute.cs (Attribute.Resolve): Add error 653 report.
16790 * class.cs (Class.ApplyAttributeBuilder): Add error 641
16792 (Method.ApplyAttributeBuilder): Add error 685 report.
16793 (Operator.Define): Add error 564 report.
16795 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
16797 * expression.cs (Invocation.DoResolve): Add error
16798 245 and 250 report.
16800 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
16803 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16805 * class.cs (ConstructorInitializer.Resolve):
16806 Wrong error number (515->516).
16808 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16810 * class.cs (Indexer.Define): Add error 631 report.
16812 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16814 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
16816 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16818 * expression.cs (Probe.DoResolve): Add error CS0241 report.
16820 2004-09-10 Marek Safar <marek.safar@seznam.cz>
16822 * cs-parser.jay: Added error CS0241 report.
16824 2004-09-10 Raja R Harinath <rharinath@novell.com>
16826 * cs-parser.jay (fixed_statement): Introduce a scope for the
16827 declaration in the 'fixed' statement.
16829 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16831 * cs-parser.jay: Added CS0230 error report.
16833 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16835 * cs-parser.jay: Added errors CS0231 and CS0257 report.
16837 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16839 * expression.cs (Argument.Resolve): Added error CS0192 and
16842 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16844 C# 2.0 #pragma warning feature
16846 * cs-tokenizer.cs (PreProcessPragma): New method;
16847 Handles #pragma directive.
16849 * report.cs (WarningRegions): New class; Support
16850 class for #pragma warning directive. It tests whether
16851 warning is enabled for a given line.
16853 2004-09-08 Miguel de Icaza <miguel@ximian.com>
16855 * const.cs: Add more descriptive error report, tahnks to
16858 2004-09-08 Marek Safar <marek.safar@seznam.cz>
16860 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
16862 2004-09-07 Miguel de Icaza <miguel@ximian.com>
16864 * expression.cs: Apply patch from Ben: Remove dead code from
16865 ArrayCreation, and remove the TurnintoConstant call in const.cs,
16866 as that code just threw an exception anwyays.
16868 * const.cs: Remove the call to the turnintoconstant, for details
16871 * literal.cs: The type of the null-literal is the null type; So
16872 we use a placeholder type (literal.cs:System.Null, defined here)
16875 * expression.cs (Conditional.DoResolve): Remove some old code that
16876 is no longer needed, conversions have been fixed.
16878 (ArrayCreationExpression.DoResolve): Return false if we fail to
16879 resolve the inner expression.
16881 2004-09-07 Raja R Harinath <rharinath@novell.com>
16884 * cs-parser.jay (delegate_declaration): Record a delegate
16885 declaration as a type declaration.
16886 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
16888 2004-09-06 Miguel de Icaza <miguel@ximian.com>
16890 * parameter.cs: Do not crash if the type can not be resolved.
16892 * expression.cs: Report errors with unsafe pointers, fixes #64896
16894 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
16896 * expression.cs: Pointer arith always needs to do a conv.i
16897 if the operand is a long. fix 65320
16899 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16901 Fixed cs0619-37.cs, cs0619-38.cs
16903 * enum.cs (GetObsoleteAttribute): Removed.
16905 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
16906 on Enum member is double staged. The first is tested member
16909 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16911 Fixed #56986, #63631, #65231
16913 * class.cs: (TypeContainer.AddToMemberContainer): New method,
16914 adds member to name container.
16915 (TypeContainer.AddToTypeContainer): New method, adds type to
16917 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
16918 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
16919 AddOperator): Simplified by reusing AddToMemberContainer.
16920 (TypeContainer.UserDefinedStaticConstructor): Changed to property
16922 (Method.CheckForDuplications): Fixed implementation to test all
16924 (MemberBase): Detection whether member is explicit interface
16925 implementation is now in constructor.
16926 (MemberBase.UpdateMemberName): Handles IndexerName.
16927 (Accessor): Changed to keep also location information.
16928 (AbstractPropertyEventMethod): Is derived from MemberCore.
16929 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
16930 will be emited or not.
16931 (PropertyBase.AreAccessorsDuplicateImplementation):
16932 Tests whether accessors are not in collision with some method.
16933 (Operator): Is derived from MethodCore to simplify common
16936 * decl.cs (Flags.TestMethodDuplication): Test for duplication
16938 (DeclSpace.AddToContainer): Adds the member to defined_names
16939 table. It tests for duplications and enclosing name conflicts.
16941 * enum.cs (EnumMember): Clean up to reuse the base structures
16943 2004-09-03 Martin Baulig <martin@ximian.com>
16945 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
16946 into TypeContainer, to make partial classes work again.
16948 2004-09-03 Martin Baulig <martin@ximian.com>
16950 * rootcontext.cs (RootContext.V2): Removed.
16952 2004-03-23 Martin Baulig <martin@ximian.com>
16954 * expression.cs (Invocation.OverloadResolve): Added `bool
16955 may_fail' argument and use it instead of the Location.IsNull() hack.
16957 2004-09-03 Martin Baulig <martin@ximian.com>
16959 Merged latest changes into gmcs. Please keep this comment in
16960 here, it makes it easier for me to see what changed in MCS since
16961 the last time I merged.
16963 2004-09-03 Raja R Harinath <rharinath@novell.com>
16966 * expression.cs (BetterConversion): Don't allow either conversion
16967 to be null. Remove redundant implicit conversion test when 'q ==
16968 null' -- when this function is invoked, we already know that the
16969 implicit conversion exists.
16970 (BetterFunction): Assume that 'best' is non-null. Remove
16971 redundant reimplementation of IsApplicable when 'best' is null.
16972 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
16973 number of arguments.
16974 (IsAncestralType): Extract from OverloadResolve.
16975 (OverloadResolve): Make robust to the MethodGroupExpr being
16976 unsorted. Implement all the logic of Section 14.5.5.1, and
16977 support overloading of methods from multiple applicable types.
16978 Clean up logic somewhat. Don't pass null methods to BetterFunction.
16980 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
16981 (RealError, Warning): Append type of report to related symbol.
16983 2004-09-03 Marek Safar <marek.safar@seznam.cz>
16985 * enum.cs: Fixed CLS-Compliance checks for enum members.
16986 Error tests cs3008-8.cs, cs3014-8.cs
16988 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16990 Fixed bug #62342, #63102
16991 * class.cs: ImplementIndexer uses member.IsExplicitImpl
16992 like ImplementMethod.
16994 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16996 * attribute.cs (Attribute.GetAttributeArgumentExpression):
16999 2004-09-02 Martin Baulig <martin@ximian.com>
17001 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17002 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17005 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17007 C# 2.0 Static classes implemented
17009 * class.cs (TypeContainer): instance_constructors,
17010 initialized_fields, initialized_static_fields,
17011 default_constructor, base_inteface_types are protected to be
17012 accessible from StaticClass.
17013 (TypeContainer.DefineDefaultConstructor): New virtual method
17014 for custom default constructor generating
17015 (StaticClass): New class to handle "Static classes" feature.
17017 * cs-parser.jay: Handle static keyword on class like instance
17020 * driver.cs: Added "/langversion" command line switch with two
17021 options (iso-1, default).
17023 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17025 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17027 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17029 * delegate.cs: Style.
17031 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17033 * delegate.cs: Add seperate instance expr field for miguel.
17035 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17037 * PointerArithmetic (Resolve): make sure we are not doing
17038 pointer arith on void*. Also, make sure we are resolved
17039 by not setting eclass until resolve.
17041 All callers: Make sure that PointerArithmetic gets resolved.
17043 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17045 * ArrayCreation (LookupType): If the type does not resolve
17046 to an array, give an error.
17048 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17050 * statement.cs (Try.Resolve): Fixed bug #64222
17052 2004-08-27 Martin Baulig <martin@ximian.com>
17055 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17058 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17060 * ecore.cs (Constantify): Get underlying type via
17061 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17062 Windows in special cases.
17064 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17066 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17067 for obtaining also private methods.
17068 (GetRemoveMethod): Used GetRemoveMethod (true)
17069 for obtaining also private methods.
17071 2004-08-24 Martin Baulig <martin@ximian.com>
17073 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17074 MethodAttributes.HideBySig for operators.
17076 2004-08-23 Martin Baulig <martin@ximian.com>
17078 Back to the old error reporting system :-)
17080 * report.cs (Message): Removed.
17081 (Report.MessageData, ErrorData, WarningData): Removed.
17082 (Report.Error, Warning): Back to the old system.
17084 2004-08-23 Martin Baulig <martin@ximian.com>
17086 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17088 * class.cs (TypeContainer.ParentContainer): New public virtual
17089 method; replaces the explicit interface implementation.
17090 (ClassPart.ParentContainer): Override.
17092 2004-08-23 Martin Baulig <martin@ximian.com>
17094 * statement.cs (Switch): Added support for constant switches; see
17095 #59428 or test-285.cs.
17097 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17100 * statement.cs (GetEnumeratorFilter): Removed useless
17101 logic because C# specs is strict. GetEnumerator must be
17104 2004-08-22 Martin Baulig <martin@ximian.com>
17106 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17107 a switch and may break, reset the barrier. Fixes #59867.
17109 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17111 CLS-Compliance speed up (~5% for corlib)
17113 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17114 New method. Tests container for CLS-Compliant names
17116 * class.cs (TypeContainer.VerifyClsName): New method.
17117 Checks whether container name is CLS Compliant.
17118 (Constructor): Implements IMethodData.
17120 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17121 low-case table for CLS Compliance test.
17122 (MemberCache.VerifyClsParameterConflict): New method.
17123 Checks method parameters for CS3006 error.
17125 * enum.cs (EnumMember): Is derived from MemberCore.
17126 (Enum.VerifyClsName): Optimized for better performance.
17128 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17130 * report.cs: Renamed Error_T to Error and changed all
17133 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17135 * class.cs (TypeContainer.IndexerArrayList): New inner class
17136 container for indexers.
17137 (TypeContainer.DefaultIndexerName): New constant for default
17138 indexer name. Replaced all "Item" with this constant.
17139 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17141 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17142 DefaultMemberAttribute constructor.
17144 2004-08-05 Martin Baulig <martin@ximian.com>
17146 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17149 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17151 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17152 multi platforms problem.
17154 * compiler.csproj: Included shared files.
17156 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17158 Fix bug 60333, 55971 in the more general way
17159 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17160 Added arg_type argument for constant conversion.
17161 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17163 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17166 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17167 OperatorArrayList, MethodCoreArrayList for typecontainer
17168 containers. Changed class member types to these new types.
17169 (MethodArrayList.DefineMembers): Added test for CS0659.
17171 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17173 * cfold.cs: Synchronize the folding with the code in expression.cs
17174 Binary.DoNumericPromotions for uint operands.
17176 * attribute.cs: Revert patch from Raja, it introduced a regression
17177 while building Blam-1.2.1 (hard to isolate a test case).
17179 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17183 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17185 (MethodCore.parent_method): New member. The method we're overriding
17186 if this is an override method.
17187 (MethodCore.CheckBase): Moved from Method class and made common.
17188 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17190 (MethodCore.CheckForDuplications): New abstract method. For custom
17191 member duplication search in a container
17192 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17193 method and its return type.
17194 (Event.conflict_symbol): New member. Symbol with same name in the
17198 (MemberCache.FindMemberWithSameName): New method. The method
17199 is looking for conflict with inherited symbols.
17201 2004-08-04 Martin Baulig <martin@ximian.com>
17203 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17205 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17207 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17209 * report.cs (Message): New enum for better error, warning reference in
17211 (MessageData): New inner abstract class. It generally handles printing of
17212 error and warning messages.
17213 Removed unused Error, Warning, Message methods.
17215 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17217 Fix for cs0592-8.cs test
17219 (Attributable.ValidAttributeTargets): Made public.
17220 (Attribute.ExplicitTarget): New member for explicit target value.
17221 (Attribute.CheckTargets): Now we translate explicit attribute
17222 target to Target here.
17224 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17226 * ecore.cs (MethodGroupExpr): new IsBase property.
17228 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17230 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17231 rather than an instance expr.
17233 (DelegateCreation.Emit): Use the method group rather than
17234 the instance expression. Also, if you have base.Foo as the
17235 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17237 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17239 (NewDelegate.DoResolve): Only check for the existance of Invoke
17240 if the method is going to be needed. Use MethodGroupExpr.
17242 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17244 * expression.cs: For pointer arith., make sure to use
17245 the size of the type, not the size of the pointer to
17248 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17251 * class.cs (Class): Added error CS0502 test.
17253 2004-08-03 John Luke <jluke@cfl.rr.com>
17254 Raja R Harinath <rharinath@novell.com>
17257 * attribute.cs (Attribute.complained_before): New flag.
17258 (Attribute.ResolveType, Attribute.Resolve),
17259 (Attribute.DefinePInvokeMethod): Set it.
17260 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17262 2004-08-03 Martin Baulig <martin@ximian.com>
17264 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17265 use a user-defined operator; we still need to do numeric
17266 promotions in case one argument is a builtin type and the other
17267 one has an implicit conversion to that type. Fixes #62322.
17269 2004-08-02 Martin Baulig <martin@ximian.com>
17271 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17272 (LocalInfo.IsThis): New public property.
17273 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17275 2004-08-01 Martin Baulig <martin@ximian.com>
17277 * class.cs (TypeContainer.GetClassBases): Don't set the default
17278 here since we may get called from GetPartialBases().
17279 (TypeContainer.DefineType): If GetClassBases() didn't return a
17280 parent, use the default one.
17282 2004-07-30 Duncan Mak <duncan@ximian.com>
17284 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17286 2004-07-30 Martin Baulig <martin@ximian.com>
17288 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17290 * class.cs (SourceMethod): New public class, derive from the
17291 symbol writer's ISourceMethod.
17292 (Method): Use the new symbol writer API.
17294 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17295 as argument and use the new symbol writer.
17298 (SourceFile): Implement the symbol writer's ISourceFile.
17299 (Location.SymbolDocument): Removed.
17300 (Location.SourceFile): New public property.
17302 * symbolwriter.cs: Use the new symbol writer API.
17304 2004-07-30 Raja R Harinath <rharinath@novell.com>
17306 * Makefile (install-local): Remove. Functionality moved to
17309 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17311 * Makefile: Install mcs.exe.config file together with mcs.exe.
17312 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17313 correct runtime version.
17315 2004-07-25 Martin Baulig <martin@ximian.com>
17318 (TypeContainer.RegisterOrder): Removed, this was unused.
17319 (TypeContainer, interface_order): Removed.
17320 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17321 TypeContainer as argument since we can also be called with a
17322 `PartialContainer' for a partial class/struct/interface.
17323 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17324 of checking whether we're an `Interface' - we could be a
17325 `PartialContainer'.
17326 (PartialContainer.Register): Override; call
17327 AddClass()/AddStruct()/AddInterface() on our parent.
17329 * cs-parser.jay (interface_member_declaration): Add things to the
17330 `current_container', not the `current_class'.
17332 * rootcontext.cs (RegisterOrder): The overloaded version which
17333 takes an `Interface' was unused, removed.
17335 * typemanager.cs (TypeManager.LookupInterface): Return a
17336 `TypeContainer', not an `Interface'.
17337 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17338 contain a `PartialContainer' for an interface, so check it's
17339 `Kind' to figure out what it is.
17341 2004-07-25 Martin Baulig <martin@ximian.com>
17343 * class.cs (Class.DefaultTypeAttributes): New public constant.
17344 (Struct.DefaultTypeAttributes): Likewise.
17345 (Interface.DefaultTypeAttributes): Likewise.
17346 (PartialContainer.TypeAttr): Override this and add the
17347 DefaultTypeAttributes.
17349 2004-07-25 Martin Baulig <martin@ximian.com>
17351 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17352 we can just use the `Parent' field instead.
17354 2004-07-25 Martin Baulig <martin@ximian.com>
17356 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17358 2004-07-25 Martin Baulig <martin@ximian.com>
17360 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17361 our parts before defining any methods.
17362 (TypeContainer.VerifyImplements): Make this virtual.
17363 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17364 on our PartialContainer.
17366 2004-07-25 Martin Baulig <martin@ximian.com>
17368 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17370 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17371 argument, we can just use the `Parent' field instead.
17374 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17375 (MemberBase.DoDefine): Likewise.
17377 2004-07-24 Martin Baulig <martin@ximian.com>
17379 * decl.cs (MemberCore.Parent): New public field.
17380 (DeclSpace.Parent): Moved to MemberCore.
17382 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17383 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17385 (FieldBase, Field, Operator): Likewise.
17386 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17387 (EventField, Event): Likewise.
17389 2004-07-23 Martin Baulig <martin@ximian.com>
17391 * class.cs (PartialContainer): New public class.
17392 (ClassPart): New public class.
17393 (TypeContainer): Added support for partial classes.
17394 (TypeContainer.GetClassBases): Splitted some of the functionality
17395 out into GetNormalBases() and GetPartialBases().
17397 * cs-tokenizer.cs (Token.PARTIAL): New token.
17398 (Tokenizer.consume_identifier): Added some hacks to recognize
17399 `partial', but only if it's immediately followed by `class',
17400 `struct' or `interface'.
17402 * cs-parser.jay: Added support for partial clases.
17404 2004-07-23 Martin Baulig <martin@ximian.com>
17406 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17407 a `DeclSpace' and also made it readonly.
17408 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17409 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17410 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17412 * cs-parser.jay: Pass the `current_class', not the
17413 `current_container' (at the moment, this is still the same thing)
17414 to a new Method, Property, Event, Indexer or Constructor.
17416 2004-07-23 Martin Baulig <martin@ximian.com>
17418 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17419 and removed the `current_interface' one.
17420 (struct_declaration, class_declaration, interface_declaration):
17421 Set `current_class' to the newly created class/struct/interface;
17422 set their `Bases' and call Register() before parsing their body.
17424 2004-07-23 Martin Baulig <martin@ximian.com>
17426 * class.cs (Kind): New public enum.
17427 (TypeContainer): Made this class abstract.
17428 (TypeContainer.Kind): New public readonly field.
17429 (TypeContainer.CheckDef): New public method; moved here from
17431 (TypeContainer.Register): New public abstract method.
17432 (TypeContainer.GetPendingImplementations): New public abstract
17434 (TypeContainer.GetClassBases): Removed the `is_class' and
17435 `is_iface' parameters.
17436 (TypeContainer.DefineNestedTypes): Formerly known as
17438 (ClassOrStruct): Made this class abstract.
17440 * tree.cs (RootTypes): New public type.
17442 2004-07-20 Martin Baulig <martin@ximian.com>
17444 * tree.cs (Tree.RecordNamespace): Removed.
17445 (Tree.Namespaces): Removed.
17447 * rootcontext.cs (RootContext.IsNamespace): Removed.
17449 * cs-parser.jay (namespace_declaration): Just create a new
17450 NamespaceEntry here.
17452 2004-07-20 Martin Baulig <martin@ximian.com>
17454 * statement.cs (ExceptionStatement): New abstract class. This is
17455 now used as a base class for everyone who's using `finally'.
17456 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17457 our local variables before using them.
17459 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17460 virtual method. This is used by Yield.Resolve() to "steal" an
17461 outer block's `finally' clauses.
17462 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17465 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17466 version which takes an ExceptionStatement. This version must be
17467 used to create exception branchings.
17470 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17471 (Iterator.EmitMoveNext): Added exception support; protect the
17472 block with a `fault' clause, properly handle 'finally' clauses.
17473 (Iterator.EmitDispose): Run all the `finally' clauses here.
17475 2004-07-20 Martin Baulig <martin@ximian.com>
17477 * iterator.cs: This is the first of a set of changes in the
17478 iterator code. Match the spec more closely: if we're an
17479 IEnumerable, then GetEnumerator() must be called. The first time
17480 GetEnumerator() is called, it returns the current instance; all
17481 subsequent invocations (if any) must create a copy.
17483 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17485 * expression.cs: Resolve the constant expression before returning
17488 2004-07-19 Martin Baulig <martin@ximian.com>
17490 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17491 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17492 the return type of the new EmitContext.
17494 2004-07-18 Martin Baulig <martin@ximian.com>
17496 * class.cs (Property.Define): Fix iterators.
17498 * iterators.cs (Iterator.Define): Moved the
17499 `container.AddInterator (this)' call here from the .ctor; only do
17500 it if we resolved successfully.
17502 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17504 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17505 `true' for preprocessing directives that we parse. The return
17506 value indicates whether we should return to regular tokenizing or
17507 not, not whether it was parsed successfully.
17509 In the past if we were in: #if false ... #line #endif, we would
17510 resume parsing after `#line'. See bug 61604.
17512 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17513 building: IsEnumType should return true only for enums, not for
17514 enums or System.Enum itself. This fixes #61593.
17516 Likely what happened is that corlib was wrong: mcs depended on
17517 this bug in some places. The bug got fixed, we had to add the
17518 hack, which caused bug 61593.
17520 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17521 that was a workaround for the older conditions.
17523 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17525 * assign.cs: IAssignMethod has a new interface, as documented
17526 inline. All assignment code now uses this new api.
17528 * ecore.cs, expression.cs: All classes which implement
17529 IAssignMethod now use the new interface.
17531 * expression.cs (Invocation): add a hack to EmitCall so that
17532 IndexerAccess can be the target of a compound assignment without
17533 evaluating its arguments twice.
17535 * statement.cs: Handle changes in Invocation api.
17537 2004-07-16 Martin Baulig <martin@ximian.com>
17539 * iterators.cs: Rewrote this. We're now using one single Proxy
17540 class for both the IEnumerable and the IEnumerator interface and
17541 `Iterator' derives from Class so we can use the high-level API.
17543 * class.cs (TypeContainer.AddIterator): New method.
17544 (TypeContainer.DoDefineType): New protected virtual method, which
17545 is called from DefineType().
17546 (TypeContainer.DoDefineMembers): Call DefineType() and
17547 DefineMembers() on all our iterators.
17548 (TypeContainer.Emit): Call Emit() on all our iterators.
17549 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17551 * codegen.cs (EmitContext.CurrentIterator): New public field.
17553 2004-07-15 Martin Baulig <martin@ximian.com>
17556 (TypeManager.not_supported_exception_type): New type.
17558 2004-07-14 Martin Baulig <martin@ximian.com>
17560 * iterators.cs: Use real error numbers.
17562 2004-07-14 Martin Baulig <martin@ximian.com>
17564 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17565 requires this to be a System.Collection.IEnumerable and not a
17566 class implementing that interface.
17567 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17569 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17571 * class.cs: Fixed previous fix, it broke some error tests.
17573 2004-07-12 Martin Baulig <martin@ximian.com>
17575 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17578 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17580 * assign.cs (LocalTemporary): Add new argument: is_address,If
17581 `is_address' is true, then the value that we store is the address
17582 to the real value, and not the value itself.
17584 * ecore.cs (PropertyExpr): use the new local temporary
17585 stuff to allow us to handle X.Y += z (where X is a struct)
17587 2004-07-08 Martin Baulig <martin@ximian.com>
17589 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
17590 not always return, just like we're doing in Using.Resolve().
17592 2004-07-07 Miguel de Icaza <miguel@ximian.com>
17594 * cs-parser.jay (fixed_statement): flag this as Pinned.
17596 2004-07-06 Miguel de Icaza <miguel@ximian.com>
17598 * typemanager.cs (TypeManager): Removed MakePinned method, this
17599 mechanism is replaced with the .NET 2.x compatible mechanism of
17600 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
17602 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
17603 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
17604 `IsFixed' property which has a different meaning.
17606 2004-07-02 Raja R Harinath <rharinath@novell.com>
17608 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
17609 visible from inside a nested class, not just the names of the
17610 immediately enclosing class.
17611 Fix for bug #60730.
17613 2004-06-24 Raja R Harinath <rharinath@novell.com>
17615 * expression.cs (BetterConversion): Remove buggy special-case
17616 handling of "implicit constant expression conversions". At this
17617 point, we already know that the conversion is possible -- we're
17618 only checking to see which is better.
17620 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17622 * cs-parser.jay: Added error CS0210 test.
17624 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17626 * cs-parser.jay: Added error CS0134 test.
17628 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17631 * cs-parser.jay: Added error CS0145 test.
17633 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17635 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
17637 2004-06-23 Ben Maurer <bmaurer@ximian.com>
17639 * expression.cs (StackAlloc.Resolve): The argument may not
17640 be a constant; deal with this case.
17642 2004-06-23 Marek Safar <marek.safar@seznam.cz>
17644 * attribute.cs (IndexerName_GetIndexerName): Renamed to
17645 GetIndexerAttributeValue.
17646 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
17648 * class.cs (Indexer.Define): Added error tests for CS0415,
17651 2004-06-23 Miguel de Icaza <miguel@ximian.com>
17653 * attribute.cs (Attribute.Resolve): Keep field code in sync with
17656 2004-06-23 Martin Baulig <martin@ximian.com>
17658 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
17659 neither return nor throw, reset the barrier as well. Fixes #60457.
17661 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
17663 * class.cs : EventAttributes is now set to None by default.
17664 This fixes bug #60459.
17666 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17669 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17670 Don't throw exception but return null (it's sufficient now).
17672 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17674 * typemanager.cs (GetArgumentTypes): Faster implementation.
17676 2004-06-18 Martin Baulig <martin@ximian.com>
17678 * attribute.cs (Attribute.Resolve): Check whether we're an
17679 EmptyCast which a Constant child. Fixes #60333.
17681 2004-06-17 Ben Maurer <bmaurer@ximian.com>
17683 * statement.cs (EmitCollectionForeach): Account for the fact that
17684 not all valuetypes are in areas which we can take the address of.
17685 For these variables, we store to a temporary variable. Also, make
17686 sure that we dont emit a `callvirt' on a valuetype method.
17688 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17690 * expression.cs (StackAlloc.DoReSolve): Added test for
17691 negative parameter (CS0247).
17693 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17696 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
17698 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17701 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
17704 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17706 Fix bug #58254 & cs1555.cs, cs1556.cs
17707 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
17709 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17711 * cs-parser.jay: Added error CS1669 test for indexers.
17713 2004-06-11 Martin Baulig <martin@ximian.com>
17715 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
17716 call this twice: for params and varargs methods.
17718 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17721 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
17723 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17725 * attribute.cs (Attribute.GetValidTargets): Made public.
17728 (AbstractPropertyEventMethod): New class for better code sharing.
17729 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
17731 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
17733 2004-06-11 Raja R Harinath <rharinath@novell.com>
17736 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
17737 that the call to Resolve is part of a MemberAccess.
17738 (Expression.Resolve): Use it for SimpleName resolution.
17739 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
17740 Add 'intermediate' boolean argument.
17741 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
17742 error message when the SimpleName can be resolved ambiguously
17743 between an expression and a type.
17744 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
17746 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
17747 call on the left-side.
17749 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17752 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
17754 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17756 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
17758 2004-06-11 Martin Baulig <martin@ximian.com>
17760 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
17761 varargs methods if applicable.
17763 2004-06-11 Martin Baulig <martin@ximian.com>
17765 * expression.cs (Invocation.EmitCall): Don't use
17766 `method.CallingConvention == CallingConventions.VarArgs' since the
17767 method could also have `CallingConventions.HasThis'.
17769 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17771 * class.cs (Event.GetSignatureForError): Implemented.
17772 Fixed crash in error test cs3010.cs
17774 2004-06-10 Miguel de Icaza <miguel@ximian.com>
17776 * cs-tokenizer.cs: Change the way we track __arglist to be
17777 consistent with the other keywords.
17779 2004-06-09 Miguel de Icaza <miguel@ximian.com>
17781 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
17784 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
17786 * codegen.cs: Check that all referenced assemblies have a strongname
17787 before strongnaming the compiled assembly. If not report error CS1577.
17788 Fix bug #56563. Patch by Jackson Harper.
17789 * typemanager.cs: Added a method to return all referenced assemblies.
17790 Fix bug #56563. Patch by Jackson Harper.
17792 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17795 (Method.ApplyAttributeBuilder): Moved and added conditional
17796 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
17799 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
17801 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17804 * class.cs: (EventField.attribute_targets): Changed default target.
17806 2004-06-08 Martin Baulig <martin@ximian.com>
17808 * expression.cs (Invocation.EmitCall): Enable varargs methods.
17810 2004-06-08 Martin Baulig <martin@ximian.com>
17812 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
17814 2004-06-07 Martin Baulig <martin@ximian.com>
17816 Added support for varargs methods.
17818 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
17821 * cs-parser.jay: Added support for `__arglist'.
17823 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
17825 * expression.cs (Argument.AType): Added `ArgList'.
17826 (Invocation): Added support for varargs methods.
17827 (ArglistAccess): New public class.
17828 (Arglist): New public class.
17830 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
17832 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
17833 a method's top-level block if the method has varargs.
17835 * support.cs (ReflectionParameters, InternalParameters): Added
17836 support for varargs methods.
17838 2004-06-07 Miguel de Icaza <miguel@ximian.com>
17840 * class.cs: Provide location in indexer error report.
17842 * driver.cs: Use standard names.
17844 * namespace.cs: Catch the use of using after a namespace has been
17845 declared also on using aliases.
17847 2004-06-03 Raja R Harinath <rharinath@novell.com>
17850 * typemanager.cs (closure_private_ok, closure_invocation_type)
17851 (closure_qualifier_type, closure_invocation_assembly)
17852 (FilterWithClosure): Move to ...
17853 (Closure): New internal nested class.
17854 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
17855 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
17856 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
17857 (MemberLookup, MemberLookupFailed): Use it.
17858 * expression.cs (New.DoResolve): Treat the lookup for the
17859 constructor as being qualified by the 'new'ed type.
17860 (Indexers.GetIndexersForTypeOrInterface): Update.
17862 2004-06-03 Marek Safar <marek.safar@seznam.cz>
17865 (GetConditionalAttributeValue): New method. Returns
17866 condition of ConditionalAttribute.
17867 (SearchMulti): New method. Returns all attributes of type 't'.
17868 Use it when attribute is AllowMultiple = true.
17869 (IsConditionalMethodExcluded): New method.
17872 (Method.IsExcluded): Implemented. Returns true if method has conditional
17873 attribute and the conditions is not defined (method is excluded).
17874 (IMethodData): Extended interface for ConditionalAttribute support.
17875 (PropertyMethod.IsExcluded): Implemented.
17878 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
17881 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
17884 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
17886 * expression.cs (ArrayCreationExpression): Make this just an
17887 `expression'. It can't be a statement, so the code here was
17890 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17893 * typemanager.cs (GetFullNameSignature): New method for
17896 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17899 * class.cs (MemberBase.GetSignatureForError): New virtual method.
17900 Use this method when MethodBuilder is null.
17901 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
17902 Added test for error CS0626 (MONO reports error for this situation).
17903 (IMethodData.GetSignatureForError): Extended interface.
17905 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17908 (AttributeTester.GetObsoleteAttribute): Returns instance of
17909 ObsoleteAttribute when type is obsolete.
17912 (TypeContainer.VerifyObsoleteAttribute): Override.
17913 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
17914 (MethodCode.VerifyObsoleteAttribute): Override.
17915 (MemberBase.VerifyObsoleteAttribute): Override.
17918 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
17919 and report proper error.
17922 Delegate.VerifyObsoleteAttribute): Override.
17925 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
17926 and report proper error.
17927 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
17930 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
17934 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
17935 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
17936 Added test for ObsoleteAttribute.
17939 (Catch): Derived from Statement.
17941 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17943 Fixed bug #59071 & cs0160.cs
17945 * statement.cs (Try.Resolve): Check here whether order of catch
17946 clauses matches their dependencies.
17948 2004-05-31 Miguel de Icaza <miguel@ximian.com>
17950 * Reverted patch to namespace.cs (Use lookuptypedirect). This
17951 caused a regression: #59343. Referencing nested classes from an
17952 assembly stopped working.
17954 2004-05-31 Martin Baulig <martin@ximian.com>
17956 MCS is now frozen for beta 2.
17958 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17960 * convert.cs: add a trivial cache for overload operator resolution.
17962 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17964 * decl.cs: If possible, use lookuptypedirect here. We can only do
17965 this if there is no `.' after the namespace. Avoids using
17966 LookupType, which does lots of slow processing.
17967 (FindNestedType) New method, does what it says :-).
17968 * namespace.cs: use LookupTypeDirect.
17969 * rootcontext.cs: use membercache, if possible.
17970 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
17972 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17975 According to the spec,
17977 In a member access of the form E.I, if E is a single identifier,
17978 and if the meaning of E as a simple-name (§7.5.2) is a constant,
17979 field, property, localvariable, or parameter with the same type as
17980 the meaning of E as a type-name (§3.8), then both possible
17981 meanings of E are permitted.
17983 We did not check that E as a simple-name had the same type as E as
17986 This trivial check gives us 5-7% on bootstrap time.
17988 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17990 * expression.cs (Invocation.OverloadResolve): Avoid the
17991 use of hashtables and boxing here by allocating on demand.
17993 2004-05-30 Martin Baulig <martin@ximian.com>
17995 * rootcontext.cs (RootContext.LookupType): Don't cache things if
17996 we're doing a silent lookup. Don't try to lookup nested types in
17997 TypeManager.object_type (thanks to Ben Maurer).
17999 2004-05-30 Martin Baulig <martin@ximian.com>
18001 Committing a patch from Ben Maurer.
18003 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18005 2004-05-29 Martin Baulig <martin@ximian.com>
18007 * class.cs (IMethodData.ShouldIgnore): New method.
18009 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18010 `Location' argument, we don't need it anywhere. Use
18011 `IMethodData.ShouldIgnore ()' instead of
18012 `MethodData.GetMethodFlags ()'.
18013 (TypeManager.AddMethod): Removed.
18014 (TypeManager.AddMethod2): Renamed to AddMethod.
18016 2004-05-29 Martin Baulig <martin@ximian.com>
18018 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18020 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18021 converting from a class type S to an interface type and we already
18022 have an object on the stack, don't box it again. Fixes #52578.
18024 2004-05-29 Martin Baulig <martin@ximian.com>
18026 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18027 Added support for `params' parameters. Fixes #59267.
18029 2004-05-29 Martin Baulig <martin@ximian.com>
18031 * literal.cs (NullPointer): Provide a private .ctor which sets
18032 `type' to TypeManager.object_type. Fixes #59048.
18034 2004-05-29 Martin Baulig <martin@ximian.com>
18036 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18037 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18039 * ecore.cs (EventExpr.instance_expr): Make the field private.
18041 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18043 Fixed bug #50080 & cs0214-2.cs
18044 * expression.cs (Cast.DoResolve): Check unsafe context here.
18046 * statement.cs (Resolve.DoResolve): Likewise.
18048 2004-05-26 Martin Baulig <martin@ximian.com>
18050 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18052 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18053 (RootContext.LookupType): Pass down the `silent' flag.
18055 2004-05-25 Martin Baulig <martin@ximian.com>
18058 (MethodGroupExpr.IdenticalTypeName): New public property.
18059 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18060 expression actually refers to a type.
18062 2004-05-25 Martin Baulig <martin@ximian.com>
18064 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18065 for #56176 and made it actually work.
18067 2004-05-25 Martin Baulig <martin@ximian.com>
18069 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18070 (FieldExpr, PropertyExpr): Override and implement
18071 CacheTemporaries. Fixes #52279.
18073 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18075 * location.cs: In the new compiler listing a file twice is a
18076 warning, not an error.
18078 2004-05-24 Martin Baulig <martin@ximian.com>
18080 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18081 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18083 2004-05-24 Martin Baulig <martin@ximian.com>
18085 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18086 walking the `using' list. Fixes #53921.
18088 2004-05-24 Martin Baulig <martin@ximian.com>
18090 * const.cs (Const.LookupConstantValue): Added support for
18091 EmptyCast's; fixes #55251.
18093 2004-05-24 Martin Baulig <martin@ximian.com>
18095 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18096 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18097 which does the CS0135 check. The reason is that we first need to
18098 check whether the variable actually exists.
18100 2004-05-24 Martin Baulig <martin@ximian.com>
18102 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18103 than RootContext.LookupType() to find the explicit interface
18104 type. Fixes #58584.
18106 2004-05-24 Raja R Harinath <rharinath@novell.com>
18108 * Makefile: Simplify. Use executable.make.
18109 * mcs.exe.sources: New file. List of sources of mcs.exe.
18111 2004-05-24 Anders Carlsson <andersca@gnome.org>
18115 Use the invariant culture when doing String.Compare for CLS case
18118 2004-05-23 Martin Baulig <martin@ximian.com>
18120 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18121 don't have any dots. Fixes #52622, added cs0246-8.cs.
18123 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18125 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18127 * class.cs (MemberBase.Define): Reuse MemberType member for
18128 resolved type. Other methods can use it too.
18130 2004-05-23 Martin Baulig <martin@ximian.com>
18132 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18133 the variable also exists in the current block (otherwise, we need
18134 to report a CS0103). Fixes #58670.
18136 2004-05-23 Martin Baulig <martin@ximian.com>
18138 * flowanalysis.cs (Reachability.Reachable): Compute this
18139 on-the-fly rather than storing it as a field.
18141 2004-05-23 Martin Baulig <martin@ximian.com>
18143 * flowanalysis.cs (Reachability.And): Manually compute the
18144 resulting `barrier' from the reachability.
18146 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18149 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18150 instance of ObsoleteAttribute when symbol is obsolete.
18153 (IMethodData): Extended interface for ObsoleteAttribute support.
18155 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18157 * attribute.cs: Fix bug #55970
18159 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18163 (GetObsoleteAttribute): New method. Creates the instance of
18165 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18166 ObsoleteAttribute when member is obsolete.
18167 (AttributeTester.Report_ObsoleteMessage): Common method for
18168 Obsolete error/warning reporting.
18171 (TypeContainer.base_classs_type): New member for storing parent type.
18174 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18175 for this MemberCore.
18177 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18179 * attribute.cs, const.cs: Fix bug #58590
18181 2004-05-21 Martin Baulig <martin@ximian.com>
18183 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18184 out parameters if the end of the method is unreachable. Fixes
18187 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18189 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18190 Hari was right, why extra method.
18192 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18194 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18196 2004-05-20 Martin Baulig <martin@ximian.com>
18198 Merged this back from gmcs to keep the differences to a minumum.
18200 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18201 instead of a Declspace.
18202 (Attribute.ResolveType): Likewise.
18203 (Attributes.Search): Likewise.
18204 (Attributes.Contains): Likewise.
18205 (Attributes.GetClsCompliantAttribute): Likewise.
18207 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18209 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18212 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18214 Fix bug #58688 (MCS does not report error when the same attribute
18217 * attribute.cs (Attribute.Emit): Distinction between null and default.
18219 2004-05-19 Raja R Harinath <rharinath@novell.com>
18221 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18222 of a top-level attribute without an attribute target.
18223 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18225 (Attribute.Conditional_GetConditionName),
18226 (Attribute.Obsolete_GetObsoleteMessage): Update.
18227 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18228 part of ScanForIndexerName.
18229 (Attribute.CanIgnoreInvalidAttribute): New function.
18230 (Attribute.ScanForIndexerName): Move to ...
18231 (Attributes.ScanForIndexerName): ... here.
18232 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18233 (Attributes.Search): New internal variant that can choose not to
18234 complain if types aren't resolved. The original signature now
18236 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18237 complaints suppressed.
18238 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18239 only if it not useful.
18240 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18241 top-level for attributes that are shared between the assembly
18242 and a top-level class.
18243 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18244 * class.cs: Update to reflect changes.
18245 (DefineIndexers): Fuse loops.
18246 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18247 a couple more variants of attribute names.
18249 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18251 Fix bug #52585 (Implemented explicit attribute declaration)
18254 (Attributable.ValidAttributeTargets): New abstract method. It gets
18255 list of valid attribute targets for explicit target declaration.
18256 (Attribute.Target): It holds target itself.
18257 (AttributeSection): Removed.
18258 (Attribute.CheckTargets): New method. It checks whether attribute
18259 target is valid for the current element.
18262 (EventProperty): New class. For events that are declared like
18263 property (with add and remove accessors).
18264 (EventField): New class. For events that are declared like field.
18267 * cs-parser.jay: Implemented explicit attribute target declaration.
18269 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18270 Override ValidAttributeTargets.
18273 (ReturnParameter): Class for applying custom attributes on
18275 (ParameterAtribute): New class. Class for applying custom
18276 attributes on the parameter type.
18278 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18280 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18283 (Method): Allow UNSAFE here.
18285 * modifiers.cs: Support unsafe reporting.
18287 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18289 * decl.cs: Fix bug #58478.
18291 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18293 * statement.cs: When checking for unreachable code on an EmptyStatement,
18294 set the location. Fixes bug #58488.
18296 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18298 * driver.cs: Add -pkg handling.
18300 From Gonzalo: UseShelLExecute=false
18302 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18305 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18307 (Attribute.IsClsCompliaceRequired): Moved to base for better
18309 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18310 when attribute is AttributeUsageAttribute.
18311 (Attribute.GetValidTargets): Simplified.
18312 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18313 attribute for this type.
18314 (Attribute.ApplyAttributes): Method renamed to Emit and make
18316 (GlobalAttributeSection): New class for special handling of global
18317 attributes (assembly, module).
18318 (AttributeSection.Emit): New method.
18320 * class.cs: Implemented Attributable abstract methods.
18321 (MethodCore.LabelParameters): Moved to Parameter class.
18322 (Accessor): Is back simple class.
18323 (PropertyMethod): Implemented Attributable abstract class.
18324 (DelegateMethod): Implemented Attributable abstract class.
18325 (Event): New constructor for disctintion between normal Event
18326 and Event with accessors.
18328 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18330 * codegen.cs, const.cs, decl.cs, delegate.cs:
18331 (CommonAssemblyModulClass): Implemented Attributable abstract class
18334 * enum.cs: Implement IAttributeSupport interface.
18335 (EnumMember): New class for emum members. Implemented Attributable
18339 (ParameterBase): Is abstract.
18340 (ReturnParameter): New class for easier [return:] attribute handling.
18342 * typemanager.cs: Removed builder_to_attr.
18344 2004-05-11 Raja R Harinath <rharinath@novell.com>
18347 * attribute.cs (Attribute.GetPositionalValue): New function.
18348 * class.cs (TypeContainer.VerifyMembers): New function.
18349 (TypeContainer.Emit): Use it.
18350 (ClassOrStruct): New base class for Class and Struct.
18351 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18352 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18354 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18355 then each non-static field should have a FieldOffset attribute.
18356 Otherwise, none of the fields should have a FieldOffset attribute.
18357 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18358 and FieldOffset attributes.
18359 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18360 (TypeManager.field_offset_attribute_type): New core types.
18361 (TypeManager.InitCoreTypes): Initialize them.
18363 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18365 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18366 Return correct type.
18369 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18371 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18372 be implicitly converted to ulong.
18374 * expression.cs: The logic for allowing operator &, | and ^ worked
18375 was wrong, it worked before because we did not report an error in
18376 an else branch. Fixes 57895.
18378 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18379 allow volatile fields to be reference types.
18381 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18383 * driver.cs: Add support for /debug-
18385 2004-05-07 Raja R Harinath <rharinath@novell.com>
18387 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18388 Add a 'complain' parameter to silence errors.
18389 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18390 silently overlooked type-resolutions.
18391 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18392 to reflect changes.
18393 (Attributes.Search): New function.
18394 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18395 (Attributes.GetAttributeFullName): Remove hack.
18396 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18397 Update to reflect changes.
18398 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18399 Use Attributes.Search instead of nested loops.
18401 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18404 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18405 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18406 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18408 * report.cs: (Report.Warning): Renamed to Warning_T because of
18409 parameter collision.
18411 2004-05-05 Raja R Harinath <rharinath@novell.com>
18413 * expression.cs (MemberAccess.ResolveMemberAccess):
18414 Exit with non-zero status after Report.Error.
18415 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18417 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18419 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18421 * support.cs: Don't hang when the file is empty.
18423 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18425 * support.cs: In SeekableStreamReader, compute the preamble size of the
18426 underlying stream. Position changes should take into account that initial
18429 2004-05-03 Todd Berman <tberman@sevenl.net>
18431 * driver.cs: remove unused GetSysVersion function.
18433 2004-05-03 Todd Berman <tberman@sevenl.net>
18435 * driver.cs: Remove the hack from saturday, as well as the hack
18436 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18437 link_paths to get that bit proper.
18439 2004-05-01 Todd Berman <tberman@sevenl.net>
18441 * driver.cs: Try a LoadFrom before a Load, this checks the current
18442 path. This is currently a bug in mono that is be fixed, however, this
18443 provides a workaround for now. This will be removed when the bug
18446 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18448 * CryptoConvert.cs: Updated to latest version. Fix issue with
18449 incomplete key pairs (#57941).
18451 2004-05-01 Todd Berman <tberman@sevenl.net>
18453 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18456 2004-04-30 Jackson Harper <jackson@ximian.com>
18458 * codegen.cs: Open keys readonly.
18460 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18462 * typemanager.cs: don't report cyclic struct layout when a struct
18463 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18464 which has 2 Pango.Rectangle fields.
18466 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18468 * expression.cs: Handle IntPtr comparisons with IL code
18469 rather than a method call.
18471 2004-04-29 Martin Baulig <martin@ximian.com>
18473 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18474 the list of PropertyInfo's in class hierarchy and find the
18475 accessor. Fixes #56013.
18477 2004-04-29 Martin Baulig <martin@ximian.com>
18479 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18481 2004-04-29 Martin Baulig <martin@ximian.com>
18483 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18485 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18487 2004-04-29 Martin Baulig <martin@ximian.com>
18489 * class.cs (ConstructorInitializer.Resolve): Check whether the
18490 parent .ctor is accessible. Fixes #52146.
18492 2004-04-29 Martin Baulig <martin@ximian.com>
18494 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18496 * statement.cs (Using.EmitLocalVariableDecls): Use
18497 TypeManager.idisposable_type, not typeof (IDisposable).
18498 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18500 2004-04-29 Martin Baulig <martin@ximian.com>
18502 * class.cs (Event.Define): Don't emit the field and don't set
18503 RTSpecialName and SpecialName for events on interfaces. Fixes
18506 2004-04-29 Raja R Harinath <rharinath@novell.com>
18508 Refactor Attribute.ApplyAttributes.
18509 * attribute.cs (Attributable): New base class for objects that can
18510 have Attributes applied on them.
18511 (Attribute): Make AttributeUsage fields public.
18512 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18513 (Attribute.IsInternalCall): New property.
18514 (Attribute.UsageAttr): Convert to a public read-only property.
18515 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18516 (Attribute.ResolveType, Attribute.Resolve)
18517 (Attribute.ScanForIndexerName): Update to reflect changes.
18518 (Attribute.CheckAttributeTarget): Re-format.
18519 (Attribute.ApplyAttributes): Refactor, to various
18520 Attributable.ApplyAttributeBuilder methods.
18521 * decl.cs (MemberCore): Make Attributable.
18522 * class.cs (Accessor): Make Attributable.
18523 (MethodData.ApplyAttributes): Use proper attribute types, not
18525 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18526 (TypeContainer.ApplyAttributeBuilder)
18527 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18528 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18529 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18530 (Operator.ApplyAttributeBuilder): New factored-out methods.
18531 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18532 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18533 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18534 * parameter.cs (ParameterBase): New Attributable base class
18535 that can also represent Return types.
18536 (Parameter): Update to the changes.
18538 2004-04-29 Jackson Harper <jackson@ximian.com>
18540 * driver.cs: Prefer the corlib system version when looking for
18541 assemblies in the GAC. This is still a hack, but its a better hack
18544 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18546 * decl.cs, enum.cs: Improved error 3005 reporting.
18548 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18549 (related_symbols): New private member for list of symbols
18550 related to reported error/warning.
18552 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18554 2004-04-29 Martin Baulig <martin@ximian.com>
18556 * ecore.cs (Expression.Constantify): If we're an enum and
18557 TypeManager.TypeToCoreType() doesn't give us another type, use
18558 t.UnderlyingSystemType. Fixes #56178.
18560 2004-04-29 Martin Baulig <martin@ximian.com>
18562 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18563 interfaces and for each interface, only add members directly
18564 declared in that interface. Fixes #53255.
18566 2004-04-28 Martin Baulig <martin@ximian.com>
18568 * expression.cs (ConditionalLogicalOperator): Use a temporary
18569 variable for `left' to avoid that we evaluate it more than once;
18572 2004-04-28 Martin Baulig <martin@ximian.com>
18574 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18577 2004-04-28 Martin Baulig <martin@ximian.com>
18579 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18582 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18583 whether the type is not void (CS1547).
18585 2004-04-28 Martin Baulig <martin@ximian.com>
18587 * expression.cs (Unary.DoResolveLValue): Override this and report
18588 CS0131 for anything but Operator.Indirection.
18590 2004-04-28 Martin Baulig <martin@ximian.com>
18592 Committing a patch from Ben Maurer; see bug #50820.
18594 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18597 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18600 2004-04-28 Martin Baulig <martin@ximian.com>
18602 Committing a patch from Ben Maurer; see bug #50820.
18604 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18607 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18610 2004-04-28 Martin Baulig <martin@ximian.com>
18612 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
18613 (Block.AddLabel): Call DoLookupLabel() to only search in the
18616 2004-04-28 Martin Baulig <martin@ximian.com>
18618 * cfold.cs (ConstantFold.BinaryFold): Added special support for
18619 comparing StringConstants and NullLiterals in Equality and Inequality.
18621 2004-04-28 Jackson Harper <jackson@ximian.com>
18623 * driver.cs: Attempt to load referenced assemblies from the
18624 GAC. This is the quick and dirty version of this method that
18625 doesnt take into account versions and just takes the first
18626 canidate found. Will be good enough for now as we will not have more
18627 then one version installed into the GAC until I update this method.
18629 2004-04-28 Martin Baulig <martin@ximian.com>
18631 * typemanager.cs (TypeManager.CheckStructCycles): New public
18632 static method to check for cycles in the struct layout.
18634 * rootcontext.cs (RootContext.PopulateTypes): Call
18635 TypeManager.CheckStructCycles() for each TypeContainer.
18636 [Note: We only need to visit each type once.]
18638 2004-04-28 Martin Baulig <martin@ximian.com>
18640 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
18642 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
18643 success and added `out object value'. Use a `bool resolved' field
18644 to check whether we've already been called rather than
18645 `ConstantValue != null' since this breaks for NullLiterals.
18647 2004-04-28 Raja R Harinath <rharinath@novell.com>
18649 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
18650 setting of this flag, since the 'set' method may be non-public.
18652 2004-04-28 Raja R Harinath <rharinath@novell.com>
18654 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
18655 check on current_vector.Block.
18657 2004-04-27 Martin Baulig <martin@ximian.com>
18659 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
18660 a field initializer. Fixes #56459.
18662 2004-04-27 Martin Baulig <martin@ximian.com>
18664 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
18665 we're not attempting to use an indexer. Fixes #52154.
18667 2004-04-27 Martin Baulig <martin@ximian.com>
18669 * statement.cs (Return): Don't create a return label if we don't
18670 need it; reverts my change from January 20th. Thanks to Ben
18673 2004-04-27 Martin Baulig <martin@ximian.com>
18675 According to the spec, `goto' can only leave a nested scope, but
18678 * statement.cs (Block.LookupLabel): Only lookup in the current
18679 block, don't recurse into parent or child blocks.
18680 (Block.AddLabel): Check in parent and child blocks, report
18681 CS0140/CS0158 if we find a duplicate.
18682 (Block): Removed this indexer for label lookups.
18683 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
18684 this already does the error reporting for us.
18687 (FlowBranching.UsageVector.Block): New public variable; may be null.
18688 (FlowBranching.CreateSibling): Added `Block' argument.
18689 (FlowBranching.LookupLabel): New public virtual method. Lookup a
18690 label for the target of a `goto' and check whether we're not
18691 leaving a `finally'.
18693 2004-04-27 Martin Baulig <martin@ximian.com>
18695 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
18696 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
18699 2004-04-27 Martin Baulig <martin@ximian.com>
18701 * statement.cs (Block.AddLabel): Also check for implicit blocks
18702 and added a CS0158 check.
18704 2004-04-27 Martin Baulig <martin@ximian.com>
18706 * flowanalysis.cs (FlowBranchingLoop): New class.
18707 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
18708 UsageVector's instead of an ArrayList.
18709 (FlowBranching.Label): Likewise.
18710 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
18711 (FlowBranching.AddBreakVector): New method.
18713 2004-04-27 Miguel de Icaza <miguel@ximian.com>
18715 * attribute.cs: Small regression fix: only convert the type if we
18716 the type is different, fixes System.Drawing build.
18718 2004-04-27 Martin Baulig <martin@ximian.com>
18720 * attribute.cs (Attribute.Resolve): If we have a constant value
18721 for a named field or property, implicity convert it to the correct
18724 2004-04-27 Raja R Harinath <rharinath@novell.com>
18726 * statement.cs (Block.Block): Implicit blocks share
18727 'child_variable_names' fields with parent blocks.
18728 (Block.AddChildVariableNames): Remove.
18729 (Block.AddVariable): Mark variable as "used by a child block" in
18730 every surrounding block.
18731 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
18732 been used in a child block, complain about violation of "Invariant
18733 meaning in blocks" rule.
18734 * cs-parser.jay (declare_local_variables): Don't use
18735 AddChildVariableNames.
18736 (foreach_statement): Don't create an implicit block: 'foreach'
18737 introduces a scope.
18739 2004-04-23 Miguel de Icaza <miguel@ximian.com>
18741 * convert.cs (ImplicitNumericConversion): 0 is also positive when
18742 converting from 0L to ulong. Fixes 57522.
18744 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18746 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
18747 derived class hides via 'new' keyword field from base class (test-242.cs).
18748 TODO: Handle this in the more general way.
18750 * class.cs (CheckBase): Ditto.
18752 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18754 * decl.cs (caching_flags): New member for storing cached values
18756 (MemberCore.Flags): New enum where bit flags for caching_flags
18758 (MemberCore.cls_compliance): Moved to caching_flags.
18759 (DeclSpace.Created): Moved to caching_flags.
18761 * class.cs: Use caching_flags instead of DeclSpace.Created
18763 2004-04-21 Miguel de Icaza <miguel@ximian.com>
18765 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
18766 if we are only a derived class, not a nested class.
18768 * typemanager.cs: Same as above, but do this at the MemberLookup
18769 level (used by field and methods, properties are handled in
18770 PropertyExpr). Allow for the qualified access if we are a nested
18773 2004-04-21 Marek Safar <marek.safar@seznam.cz>
18775 * class.cs: Refactoring.
18776 (IMethodData): New inteface; Holds links to parent members
18777 to avoid member duplication (reduced memory allocation).
18778 (Method): Implemented IMethodData interface.
18779 (PropertyBase): New inner classes for get/set methods.
18780 (PropertyBase.PropertyMethod): Implemented IMethodData interface
18781 (Event): New inner classes for add/remove methods.
18782 (Event.DelegateMethod): Implemented IMethodData interface.
18784 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
18785 EmitContext (related to class.cs refactoring).
18787 2004-04-21 Raja R Harinath <rharinath@novell.com>
18789 * delegate.cs (Delegate.VerifyApplicability): If the number of
18790 arguments are the same as the number of parameters, first try to
18791 verify applicability ignoring any 'params' modifier on the last
18795 2004-04-16 Raja R Harinath <rharinath@novell.com>
18797 * class.cs (TypeContainer.AddIndexer): Use
18798 'ExplicitInterfaceName' to determine if interface name was
18799 explicitly specified. 'InterfaceType' is not initialized at this time.
18800 (TypeContainer.DefineIndexers): Remove use of temporary list. The
18801 Indexers array is already in the required order. Initialize
18802 'IndexerName' only if there are normal indexers.
18803 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
18804 (TypeContainer.Emit): Emit DefaultMember attribute only if
18805 IndexerName is initialized.
18808 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
18810 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
18813 2004-04-15 Raja R Harinath <rharinath@novell.com>
18815 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
18819 * attribute.cs (Attribute.Resolve): Check for duplicate named
18823 2004-04-15 Miguel de Icaza <miguel@ximian.com>
18825 * iterators.cs (MarkYield): track whether we are in an exception,
18826 and generate code accordingly. Use a temporary value to store the
18827 result for our state.
18829 I had ignored a bit the interaction of try/catch with iterators
18830 since their behavior was not entirely obvious, but now it is
18831 possible to verify that our behavior is the same as MS .NET 2.0
18835 2004-04-14 Miguel de Icaza <miguel@ximian.com>
18837 * iterators.cs: Avoid creating temporaries if there is no work to
18840 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
18841 Enumerations, use TypeManager.EnumToUnderlying and call
18844 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
18847 (This.Emit): Use EmitContext.EmitThis to emit our
18850 (This.EmitAssign): Ditto.
18852 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
18853 codepaths, we will move all the functionality into
18856 (FieldExpr.EmitAssign): Ditto.
18858 This fixes several hidden bugs that I uncovered while doing a code
18859 review of this today.
18861 * codegen.cs (EmitThis): reworked so the semantics are more clear
18862 and also support value types "this" instances.
18864 * iterators.cs: Changed so that for iterators in value types, we
18865 do not pass the value type as a parameter.
18867 Initialization of the enumerator helpers is now done in the caller
18868 instead of passing the parameters to the constructors and having
18869 the constructor set the fields.
18871 The fields have now `assembly' visibility instead of private.
18873 2004-04-11 Miguel de Icaza <miguel@ximian.com>
18875 * expression.cs (Argument.Resolve): Check if fields passed as ref
18876 or out are contained in a MarshalByRefObject.
18878 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
18879 another compiler type.
18881 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
18883 * class.cs (Indexer.Define): use the new name checking method.
18884 Also, return false on an error.
18885 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
18886 (is_identifier_[start/part]_character): make static.
18888 2004-04-10 Miguel de Icaza <miguel@ximian.com>
18890 * expression.cs (Binary.ResolveOperator): Do no append strings
18891 twice: since we can be invoked more than once (array evaluation)
18892 on the same concatenation, take care of this here. Based on a fix
18893 from Ben (bug #56454)
18895 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
18897 * codegen.cs: Fix another case where CS1548 must be reported (when
18898 delay-sign isn't specified and no private is available #56564). Fix
18899 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
18900 error when MCS is used on the MS runtime and we need to delay-sign
18901 (which seems unsupported by AssemblyBuilder - see #56621).
18903 2004-04-08 Marek Safar <marek.safar@seznam.cz>
18905 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
18906 (TypeManager.ComputeNamespaces): Faster implementation for
18909 * compiler.csproj: Updated AssemblyName to mcs.
18911 2004-04-07 Miguel de Icaza <miguel@ximian.com>
18913 * rootcontext.cs: Add new types to the boot resolution.
18915 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
18916 MulticastDelegate is not allowed.
18918 * typemanager.cs: Add new types to lookup: System.TypedReference
18921 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
18922 check for TypedReference or ArgIterator, they are not allowed.
18924 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
18925 makes us properly catch 1510 in some conditions (see bug 56016 for
18928 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
18930 * CryptoConvert.cs: update from corlib version
18933 2004-04-05 Miguel de Icaza <miguel@ximian.com>
18935 * class.cs (Indexer.Define): Check indexername declaration
18937 2004-04-05 Marek Safar <marek.safar@seznam.cz>
18939 * attribute.cs (IsClsCompliant): Fixed problem with handling
18940 all three states (compliant, not-compliant, undetected).
18942 2004-03-30 Marek Safar <marek.safar@seznam.cz>
18944 * attribute.cs (Attribute): Location is now public.
18945 (Resolve): Store resolved arguments (pos_values) in attribute class.
18946 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
18947 (GetClsCompliantAttributeValue): New method that gets
18948 CLSCompliantAttribute value.
18949 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
18950 if exists else null.
18951 (AttributeTester): New class for CLS-Compliant verification routines.
18953 * class.cs (Emit): Add CLS-Compliant verification.
18954 (Method.GetSignatureForError): Implemented.
18955 (Constructor.GetSignatureForError): Implemented
18956 (Constructor.HasCompliantArgs): Returns if constructor has
18957 CLS-Compliant arguments.
18958 (Constructor.Emit): Override.
18959 (Construcor.IsIdentifierClsCompliant): New method; For constructors
18960 is needed to test only parameters.
18961 (FieldBase.GetSignatureForError): Implemented.
18962 (TypeContainer): New member for storing base interfaces.
18963 (TypeContainer.FindMembers): Search in base interfaces too.
18965 * codegen.cs (GetClsComplianceAttribute): New method that gets
18966 assembly or module CLSCompliantAttribute value.
18967 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
18969 (ModuleClass.Emit): Add error 3012 test.
18971 * const.cs (Emit): Override and call base for CLS-Compliant tests.
18973 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
18974 state for all decl types.
18975 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
18976 if CLS-Compliant tests are required.
18977 (IsClsCompliaceRequired): New method. Analyze whether code
18978 must be CLS-Compliant.
18979 (IsExposedFromAssembly): New method. Returns true when MemberCore
18980 is exposed from assembly.
18981 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
18982 value or gets cached value.
18983 (HasClsCompliantAttribute): New method. Returns true if MemberCore
18984 is explicitly marked with CLSCompliantAttribute.
18985 (IsIdentifierClsCompliant): New abstract method. This method is
18986 used to testing error 3005.
18987 (IsIdentifierAndParamClsCompliant): New method. Common helper method
18988 for identifier and parameters CLS-Compliant testing.
18989 (VerifyClsCompliance): New method. The main virtual method for
18990 CLS-Compliant verifications.
18991 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
18992 null. I don't know why is null (too many public members !).
18993 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
18994 and get value of first CLSCompliantAttribute that found.
18996 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
18997 (VerifyClsCompliance): Override and add extra tests.
18999 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19000 clscheck- disable CLS-Compliant verification event if assembly is has
19001 CLSCompliantAttribute(true).
19003 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19004 ApllyAttribute is now called in emit section as in the other cases.
19005 Possible future Emit integration.
19006 (IsIdentifierClsCompliant): New override.
19007 (VerifyClsCompliance): New override.
19008 (GetEnumeratorName): Returns full enum name.
19010 * parameter.cs (GetSignatureForError): Implemented.
19012 * report.cs (WarningData): New struct for Warning message information.
19013 (LocationOfPreviousError): New method.
19014 (Warning): New method. Reports warning based on the warning table.
19015 (Error_T): New method. Reports error based on the error table.
19017 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19018 verifications are done here.
19020 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19022 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19023 CLSCompliantAttribute.
19024 (all_imported_types): New member holds all imported types from other
19026 (LoadAllImportedTypes): New method fills static table with exported types
19027 from all referenced assemblies.
19028 (Modules): New property returns all assembly modules.
19030 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19032 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19033 throwing a parser error.
19035 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19036 which removes the hardcoded get_/set_ prefixes for properties, as
19037 IL allows for the properties to be named something else.
19041 * expression.cs: Do not override operand before we know if it is
19042 non-null. Fix 56207
19044 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19046 * typemanager.cs: support for pinned variables.
19048 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19050 * decl.cs, typemanager.cs: Avoid using an arraylist
19051 as a buffer if there is only one result set.
19053 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19055 * expression.cs: Make sure you cant call a static method
19056 with an instance expression, bug #56174.
19058 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19060 * class.cs (IsDuplicateImplementation): Improve error reporting to
19061 flag 663 (method only differs in parameter modifier).
19063 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19064 in preprocessor directives.
19066 * location.cs (LookupFile): Allow for the empty path.
19068 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19069 better approach for some of that patch, but its failing with the
19070 CharSet enumeration. For now try/catch will do.
19072 * typemanager.cs: Do not crash if a struct does not have fields.
19075 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19077 * expression.cs: cs0213, cant fix a fixed expression.
19080 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19082 * cs-parser.jay: detect invalid embeded statements gracefully.
19085 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19087 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19090 the invocation type may not be a subclass of the tye of the item/
19091 The type of the item must be a subclass of the invocation item.
19096 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19098 * attribute.cs: Added methods to get a string and a bool from an
19099 attribute. Required to information from AssemblyKeyFileAttribute,
19100 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19101 * codegen.cs: Modified AssemblyName creation to include support for
19102 strongnames. Catch additional exceptions to report them as CS1548.
19103 * compiler.csproj: Updated include CryptoConvert.cs.
19104 * compiler.csproj.user: Removed file - user specific configuration.
19105 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19106 Mono.Security assembly. The original class is maintained and tested in
19107 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19108 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19109 like CSC 8.0 (C# v2) supports.
19110 * Makefile: Added CryptoConvert.cs to mcs sources.
19111 * rootcontext.cs: Added new options for strongnames.
19113 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19115 * driver.cs: For --expect-error, report error code `2'
19116 if the program compiled with no errors, error code `1' if
19117 it compiled with an error other than the one expected.
19119 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19121 * compiler.csproj: Updated for Visual Studio .NET 2003.
19122 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19123 * compiler.sln: Updated for Visual Studio .NET 2003.
19125 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19127 * expression.cs: Fix bug #47234. We basically need to apply the
19128 rule that we prefer the conversion of null to a reference type
19129 when faced with a conversion to 'object' (csc behaviour).
19131 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19133 * statement.cs: Shorter form for foreach, eliminates
19134 a local variable. r=Martin.
19136 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19138 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19139 checks if we can use brtrue/brfalse to test for 0.
19140 * expression.cs: use the above in the test for using brtrue/brfalse.
19141 cleanup code a bit.
19143 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19145 * expression.cs: Rewrite string concat stuff. Benefits:
19147 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19148 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19149 rather than a concat chain.
19151 * typemanager.cs: Add lookups for more concat overloads.
19153 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19155 * expression.cs: Emit shorter il code for array init.
19172 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19174 * statement.cs: Before, two switch blocks would be merged if the
19175 total size of the blocks (end_item - begin_item + 1) was less than
19176 two times the combined sizes of the blocks.
19178 Now, it will only merge if after the merge at least half of the
19183 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19185 * class.cs : csc build fix for GetMethods(). See bug #52503.
19187 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19189 * expression.cs: Make sure fp comparisons work with NaN.
19190 This fixes bug #54303. Mig approved this patch a long
19191 time ago, but we were not able to test b/c the runtime
19194 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19196 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19198 2004-03-19 Martin Baulig <martin@ximian.com>
19200 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19201 error here and not in our caller.
19203 2004-03-19 Martin Baulig <martin@ximian.com>
19205 * interface.cs: Completely killed this file.
19206 (Interface): We're now a TypeContainer and live in class.cs.
19208 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19209 argument; we're now also called for interfaces.
19210 (TypeContainer.DefineMembers): Allow this method being called
19212 (TypeContainer.GetMethods): New public method; formerly known as
19213 Interface.GetMethod(). This is used by PendingImplementation.
19214 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19215 it's now private and non-static.
19216 (Interface): Moved this here; it's now implemented similar to
19218 (Method, Property, Event, Indexer): Added `bool is_interface'
19219 argument to their .ctor's.
19220 (MemberBase.IsInterface): New public field.
19222 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19223 instances instead of InterfaceMethod, InterfaceProperty, etc.
19224 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19225 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19227 2004-03-19 Martin Baulig <martin@ximian.com>
19229 * class.cs (MethodCore.IsDuplicateImplementation): New private
19230 method which does the CS0111 checking.
19231 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19232 Use IsDuplicateImplementation().
19234 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19236 * decl.cs (FindMemberToOverride): New method to find the correct
19237 method or property to override in the base class.
19239 - Make Method/Property use the above method to find the
19240 version in the base class.
19241 - Remove the InheritableMemberSignatureCompare as it is now
19244 This patch makes large code bases much faster to compile, as it is
19245 O(n) rather than O(n^2) to do this validation.
19247 Also, it fixes bug 52458 which is that nested classes are not
19248 taken into account when finding the base class member.
19250 Reviewed/Approved by Martin.
19252 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19254 * interface.cs: In all interface classes removed redundant
19255 member initialization.
19257 2004-03-16 Martin Baulig <martin@ximian.com>
19259 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19261 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19263 * decl.cs (DefineTypeAndParents): New helper method to define a
19264 type's containers before the type itself is defined; This is a
19265 bug exposed by the recent changes to Windows.Forms when an
19266 implemented interface was defined inside a class that had not been
19269 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19271 (Check): Loop correctly to report errors modifiers
19272 (UNSAFE was not in the loop, since it was the same as TOP).
19274 * interface.cs: Every interface member now takes a ModFlags,
19275 instead of a "is_new" bool, which we set on the base MemberCore.
19277 Every place where we called "UnsafeOk" in the interface, now we
19278 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19279 the unsafe settings from the member declaration instead of the
19280 container interface.
19282 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19284 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19285 `set_indexer_name' to the pending bits (one per type).
19287 We fixed a bug today that was picking the wrong method to
19288 override, since for properties the existing InterfaceMethod code
19289 basically ignored the method name. Now we make sure that the
19290 method name is one of the valid indexer names.
19292 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19294 * support.cs (SeekableStreamReader): Keep track of stream byte
19295 positions and don't mix them with character offsets to the buffer.
19297 Patch from Gustavo Giráldez
19299 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19301 * interface.cs (InterfaceSetGetBase): Removed double member
19302 initialization, base class does it as well.
19304 2004-03-13 Martin Baulig <martin@ximian.com>
19306 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19307 when compiling corlib.
19309 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19311 * convert.cs (ExplicitConversion): We were reporting an error on
19312 certain conversions (object_type source to a value type, when the
19313 expression was `null') before we had a chance to pass it through
19314 the user defined conversions.
19316 * driver.cs: Replace / and \ in resource specifications to dots.
19319 * class.cs: Add check for duplicate operators. Fixes 52477
19321 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19323 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19324 that are in the middle of the statements, not only at the end.
19327 * class.cs (TypeContainer.AddField): No longer set the
19328 `HaveStaticConstructor' flag, now we call it
19329 `UserDefineStaticConstructor' to diferentiate the slightly
19330 semantic difference.
19332 The situation is that we were not adding BeforeFieldInit (from
19333 Modifiers.TypeAttr) to classes that could have it.
19334 BeforeFieldInit should be set to classes that have no static
19339 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19341 And most importantly Zoltan's comment:
19343 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19345 "I think beforefieldinit means 'it's ok to initialize the type sometime
19346 before its static fields are used', i.e. initialization does not need
19347 to be triggered by the first access to the type. Setting this flag
19348 helps the JIT to compile better code, since it can run the static
19349 constructor at JIT time, and does not need to generate code to call it
19350 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19351 this flag for lots of classes like String.
19353 csc sets this flag if the type does not have an explicit static
19354 constructor. The reasoning seems to be that if there are only static
19355 initalizers for a type, and no static constructor, then the programmer
19356 does not care when this initialization happens, so beforefieldinit
19359 This bug prevents the AOT compiler from being usable, since it
19360 generates so many calls to mono_runtime_class_init that the AOT code
19361 is much slower than the JITted code. The JITted code is faster,
19362 because it does not generate these calls if the vtable is type is
19363 already initialized, which is true in the majority of cases. But the
19364 AOT compiler can't do this."
19366 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19368 * class.cs (MethodData.Emit): Refactor the code so symbolic
19369 information is generated for destructors; For some reasons we
19370 were taking a code path that did not generate symbolic information
19373 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19375 * class.cs: Create a Constructor.CheckBase method that
19376 takes care of all validation type code. The method
19377 contains some code that was moved from Define.
19379 It also includes new code that checks for duplicate ctors.
19380 This fixes bug #55148.
19382 2004-03-09 Joshua Tauberer <tauberer@for.net>
19384 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19385 a { ... }-style array creation invokes EmitStaticInitializers
19386 which is not good for reference-type arrays. String, decimal
19387 and now null constants (NullCast) are not counted toward
19388 static initializers.
19390 2004-03-05 Martin Baulig <martin@ximian.com>
19392 * location.cs (SourceFile.HasLineDirective): New public field;
19393 specifies whether the file contains or is referenced by a "#line"
19395 (Location.DefineSymbolDocuments): Ignore source files which
19396 either contain or are referenced by a "#line" directive.
19398 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19400 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19401 direct access to our parent, so check the method inline there.
19403 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19405 * expression.cs (Invocation.EmitCall): Miguel's last commit
19406 caused a regression. If you had:
19411 In Foo the implict this would be null.
19413 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19415 * expression.cs (Invocation.EmitCall): If the method is not
19416 virtual, do not emit a CallVirt to it, use Call.
19418 * typemanager.cs (GetFullNameSignature): Improve the method to
19419 cope with ".ctor" and replace it with the type name.
19421 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19422 as an argument the ConstructorBuilder where it is being defined,
19423 to catch the recursive constructor invocations.
19425 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19427 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19428 routines to check if a type is an enumerable/enumerator allow
19429 classes that implement the IEnumerable or IEnumerator interfaces.
19431 * class.cs (Property, Operator): Implement IIteratorContainer, and
19432 implement SetYields.
19434 (Property.Define): Do the block swapping for get_methods in the
19435 context of iterators. We need to check if Properties also
19436 include indexers or not.
19438 (Operator): Assign the Block before invoking the
19439 OperatorMethod.Define, so we can trigger the Iterator code
19442 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19443 Property and Operator classes are not created when we parse the
19444 declarator but until we have the block completed, so we use a
19445 singleton SimpleIteratorContainer.Simple to flag whether the
19446 SetYields has been invoked.
19448 We propagate this setting then to the Property or the Operator to
19449 allow the `yield' to function.
19451 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19453 * codegen.cs: Implemented attribute support for modules.
19454 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19455 Assembly/Module functionality.
19457 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19458 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19459 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19461 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19463 * interface.cs (FindMembers): The operation is performed on all base
19464 interfaces and not only on the first. It is required for future CLS Compliance patch.
19466 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19468 * statement.cs, codegen.cs:
19469 This patch deals with patterns such as:
19471 public class List : IEnumerable {
19473 public MyEnumerator GetEnumerator () {
19474 return new MyEnumerator(this);
19477 IEnumerator IEnumerable.GetEnumerator () {
19481 public struct MyEnumerator : IEnumerator {
19486 Before, there were a few things we did wrong:
19487 1) we would emit callvirt on a struct, which is illegal
19488 2) we emited ldarg when we needed to emit ldarga
19489 3) we would mistakenly call the interface methods on an enumerator
19490 type that derived from IEnumerator and was in another assembly. For example:
19492 public class MyEnumerator : IEnumerator
19494 Would have the interface methods called, even if there were public impls of the
19495 method. In a struct, this lead to invalid IL code.
19497 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19499 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19502 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19504 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19506 * cs-parser.jay: Fix small regression: we were not testing V2
19507 compiler features correctly.
19509 * interface.cs: If the emit context is null, then create one
19511 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19513 * decl.cs (GetSignatureForError): New virtual method to get full name
19514 for error messages.
19516 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19517 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19519 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19520 Duplicated members and code in these classes has been removed.
19521 Better encapsulation in these classes.
19523 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19525 * assign.cs (Assign.DoResolve): When dealing with compound
19526 assignments, there is a new rule in ECMA C# 2.4 (might have been
19527 there before, but it is documented here) that states that in:
19531 If b is of type int, and the `op' is a shift-operator, then the
19532 above is evaluated as:
19536 * expression.cs (Binary.ResolveOperator): Instead of testing for
19537 int/uint/long/ulong, try to implicitly convert to any of those
19538 types and use that in pointer arithmetic.
19540 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19541 method to print information for from the type, not from the
19542 null-method we were given.
19544 2004-02-01 Duncan Mak <duncan@ximian.com>
19546 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19547 parsing for cmd, fixes bug #53694.
19549 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19551 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19552 in the member name duplication tests. Property and operator name duplication
19553 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19555 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19557 * interface.cs (PopulateMethod): Fixed crash when interface method
19558 returns not existing type (error test cs0246-3.cs).
19560 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19562 * cs-parser.jay (interface_accessors): Re-write actions to also
19563 store attributes attached to get and set methods. Fix spelling
19566 (inteface_property_declaration): Modify accordingly.
19568 (InterfaceAccessorInfo): New helper class to store information to pass
19569 around between rules that use interface_accessors.
19571 * interface.cs (Emit): Apply attributes on the get and set
19572 accessors of properties and indexers too.
19574 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19575 right MethodBuilder when applying attributes to the get and set accessors.
19577 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19579 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19581 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19583 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19585 2004-01-25 Miguel de Icaza <miguel@ximian.com>
19587 * cs-parser.jay: Remove YIELD token, instead use the new grammar
19588 changes that treat `yield' specially when present before `break'
19589 or `return' tokens.
19591 * cs-tokenizer.cs: yield is no longer a keyword.
19593 2004-01-23 Marek Safar <marek.safar@seznam.cz>
19595 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
19596 setting for default constructors.
19597 For default constructors are almost every time set wrong Modifier. The
19598 generated IL code has been alright. But inside mcs this values was
19599 wrong and this was reason why several of my CLS Compliance tests
19602 2004-01-22 Martin Baulig <martin@ximian.com>
19604 * cs-parser.jay (namespace_or_type_name): Return an Expression,
19605 not a QualifiedIdentifier. This is what `type_name_expression'
19606 was previously doing.
19607 (type_name_expression): Removed; the code is now in
19608 `namespace_or_type_name'.
19609 (qualified_identifier): Removed, use `namespace_or_type_name'
19611 (QualifiedIdentifier): Removed this class.
19613 2004-01-22 Martin Baulig <martin@ximian.com>
19615 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
19616 not a string as alias name.
19618 2004-01-21 Miguel de Icaza <miguel@ximian.com>
19620 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
19621 #52730 bug, and instead compute correctly the need to use a
19622 temporary variable when requesting an address based on the
19623 static/instace modified of the field and the constructor.
19625 2004-01-21 Martin Baulig <martin@ximian.com>
19627 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
19628 class and namespace before looking up aliases. Fixes #52517.
19630 2004-01-21 Martin Baulig <martin@ximian.com>
19632 * flowanalysis.cs (UsageVector.Merge): Allow variables being
19633 assinged in a 'try'; fixes exception4.cs.
19635 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19636 * class.cs : Implemented parameter-less constructor for TypeContainer
19638 * decl.cs: Attributes are now stored here. New property OptAttributes
19640 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
19642 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
19644 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19646 * typemanager.cs (CSharpSignature): Now reports also inner class name.
19647 (CSharpSignature): New method for indexer and property signature.
19649 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19651 * pending.cs (IsVirtualFilter): Faster implementation.
19653 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19655 * typemanager.cs: Avoid inclusion of same assembly more than once.
19657 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19659 * cs-parser.jay: Fixed problem where the last assembly attribute
19660 has been applied also to following declaration (class, struct, etc.)
19662 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19664 * class.cs: Added error CS0538, CS0539 reporting.
19665 Fixed crash on Microsoft runtime when field type is void.
19667 * cs-parser.jay: Added error CS0537 reporting.
19669 * pending.cs: Added error CS0535 reporting.
19670 Improved error report for errors CS0536, CS0534.
19672 2004-01-20 Miguel de Icaza <miguel@ximian.com>
19674 Merge a few bits from the Anonymous Method MCS tree.
19676 * statement.cs (ToplevelBlock): New class for toplevel methods,
19677 will hold anonymous methods, lifted variables.
19679 * cs-parser.jay: Create toplevel blocks for delegates and for
19680 regular blocks of code.
19682 2004-01-20 Martin Baulig <martin@ximian.com>
19684 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
19685 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
19686 and `NeedExplicitReturn'; added `IsLastStatement'.
19687 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
19688 have a `ReturnLabel' or we're not unreachable.
19690 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
19691 child's reachability; don't just override ours with it. Fixes
19692 #58058 (lluis's example).
19693 (FlowBranching): Added public InTryOrCatch(), InCatch(),
19694 InFinally(), InLoop(), InSwitch() and
19695 BreakCrossesTryCatchBoundary() methods.
19697 * statement.cs (Return): Do all error checking in Resolve().
19698 Unless we are the last statement in a top-level block, always
19699 create a return label and jump to it.
19700 (Break, Continue): Do all error checking in Resolve(); also make
19701 sure we aren't leaving a `finally'.
19702 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
19703 statement in a top-level block.
19704 (Block.Flags): Added `IsDestructor'.
19705 (Block.IsDestructor): New public property.
19707 2004-01-20 Martin Baulig <martin@ximian.com>
19709 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
19711 2004-01-20 Martin Baulig <martin@ximian.com>
19713 * statement.cs (Statement.ResolveUnreachable): New public method.
19714 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
19715 (Block.Resolve): Resolve unreachable statements.
19717 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19719 * expression.cs: We need to fix the case where we do
19720 not have a temp variable here.
19722 * assign.cs: Only expression compound assignments need
19723 temporary variables.
19725 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19727 * flowanalysis.cs: Reduce memory allocation in a few ways:
19728 - A block with no variables should not allocate a bit
19730 - A method with no out parameters does not need any tracking
19731 for assignment of the parameters, so we need not allocate
19734 public readonly Type[] VariableTypes;
19735 public readonly string[] VariableNames;
19736 Are redundant. The data is already stored in the variable
19737 map, so we need not allocate another array for it.
19738 - We need to add alot of checks for if (params | locals) == null
19739 due to the first two changes.
19741 2004-01-18 Miguel de Icaza <miguel@ximian.com>
19743 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
19744 implement IMemoryLocation, we store a copy on a local variable and
19745 take the address of it. Patch from Benjamin Jemlich
19747 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
19748 to use a special "type_name_expression" rule which reduces the
19749 number of "QualifiedIdentifier" classes created, and instead
19750 directly creates MemberAccess expressions.
19752 2004-01-17 Miguel de Icaza <miguel@ximian.com>
19754 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
19755 that fixes #52853. Null literal assignment to ValueType
19757 * class.cs (MethodData.Emit): Instead of checking the name of the
19758 method to determine if its a destructor, create a new derived
19759 class from Method called Destructor, and test for that.
19761 * cs-parser.jay: Create a Destructor object instead of a Method.
19763 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
19767 2004-01-16 Miguel de Icaza <miguel@ximian.com>
19769 * expression.cs (Binary.ResolveOperator): Perform an implicit
19770 conversion from MethodGroups to their delegate types on the
19771 Addition operation.
19773 * delegate.cs: Introduce a new class DelegateCreation that is the
19774 base class for `NewDelegate' and `ImplicitDelegateCreation',
19775 factor some code in here.
19777 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
19778 conversion from MethodGroups to compatible delegate types.
19780 * ecore.cs (Expression.Resolve): Do not flag error 654
19781 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
19782 we allow conversions from MethodGroups to delegate types now.
19784 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
19785 assignments in v2 either.
19787 2004-01-10 Miguel de Icaza <miguel@ximian.com>
19789 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
19790 static read-only fields in ctors.
19792 Applied patch from Benjamin Jemlich
19794 * expression.cs (UnaryMutator): Avoid leaking local variables.
19796 2004-01-09 Miguel de Icaza <miguel@ximian.com>
19798 * cs-tokenizer.cs (IsCastToken): Allow the various native types
19799 here to return true, as they can be used like this:
19801 (XXX) int.MEMBER ()
19803 Fixed 49836 and all the other dups
19805 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
19807 * driver.cs: Implement /win32res and /win32icon.
19809 2004-01-08 Miguel de Icaza <miguel@ximian.com>
19811 * cs-parser.jay: Add a rule to improve error handling for the
19812 common mistake of placing modifiers after the type.
19814 2004-01-07 Miguel de Icaza <miguel@ximian.com>
19816 * cs-parser.jay (interface_event_declaration): Catch
19817 initialization of events on interfaces, and report cs0068
19819 * cs-parser.jay (interface_event_declaration): Catch
19820 initialization of events.
19822 * ecore.cs: Better report missing constructors.
19824 * expression.cs (Binary.ResolveOperator): My previous bug fix had
19825 the error reporting done in the wrong place. Fix.
19827 * expression.cs (Binary.ResolveOperator): Catch the
19828 operator + (E x, E y) error earlier, and later allow for implicit
19829 conversions in operator +/- (E e, U x) from U to the underlying
19832 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
19833 52596, if the container class is abstract, the default constructor
19834 is protected otherwise its public (before, we were always public).
19836 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
19839 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
19840 Jemlich that fixes bug #52597, MCS was generating invalid code for
19841 idisposable structs. Thanks to Ben for following up with this
19844 2004-01-06 Miguel de Icaza <miguel@ximian.com>
19846 * driver.cs: Allow assemblies without code to be generated, fixes
19849 2004-01-07 Nick Drochak <ndrochak@gol.com>
19851 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
19853 2004-01-05 Miguel de Icaza <miguel@ximian.com>
19855 * cs-parser.jay: Add rules to improve error reporting if fields or
19856 methods are declared at the namespace level (error 116)
19858 * Add rules to catch event add/remove
19860 2004-01-04 David Sheldon <dave-mono@earth.li>
19862 * expression.cs: Added matching ")" to error message for
19865 2004-01-03 Todd Berman <tberman@gentoo.org>
19867 * ecore.cs, attribute.cs:
19868 Applying fix from #52429.
19870 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19872 * ecore.cs, expression.cs, statement.cs:
19873 Total rewrite of how we handle branching. We
19874 now handle complex boolean expressions with fewer
19875 jumps. As well if (x == 0) no longer emits a ceq.
19877 if (x is Foo) is much faster now, because we generate
19880 Overall, we get a pretty big improvement on our benchmark
19881 tests. The code we generate is smaller and more readable.
19883 I did a full two-stage bootstrap. The patch was reviewed
19884 by Martin and Miguel.
19886 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19888 * cs-parser.jay: Make primary_expression not take a QI.
19889 we dont need this because the member_access rule covers
19890 us here. So we replace the rule with just IDENTIFIER.
19892 This has two good effects. First, we remove a s/r conflict.
19893 Second, we allocate many fewer QualifiedIdentifier objects.
19895 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19897 * attribute.cs: Handle MarshalAs attributes as pseudo, and
19898 set the correct information via SRE. This prevents
19899 hanging on the MS runtime. Fixes #29374.
19901 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19903 * convert.cs: correctly handle conversions to value types
19904 from Enum and ValueType as unboxing conversions.
19906 Fixes bug #52569. Patch by Benjamin Jemlich.
19908 2004-01-02 Ravi Pratap <ravi@ximian.com>
19910 * expression.cs (BetterConversion): Prefer int -> uint
19911 over int -> ulong (csc's behaviour). This fixed bug #52046.
19913 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
19915 * decl.cs (MemberCache.FindMembers): now returns a
19918 * typemanager.cs: In general, go with with ^^.
19919 (CopyNewMethods): take an IList.
19920 (RealMemberLookup): Only allocate an arraylist
19921 if we copy from two sets of methods.
19923 This change basically does two things:
19924 1) Fewer array lists allocated due to CopyNewMethods.
19925 2) the explicit cast in MemberList costed ALOT.
19927 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
19929 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
19930 a hashtable to avoid needless string allocations when an identifier is
19931 used more than once (the common case).
19933 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19935 * pending.cs: MS's TypeBuilder.GetInterfaces ()
19936 is broken, it will not return anything. So, we
19937 have to use the information we have in mcs to
19940 * typemanager.cs: Add a cache for GetInterfaces,
19941 since this will now be used more often (due to ^^)
19943 (GetExplicitInterfaces) New method that gets the
19944 declared, not effective, interfaces on a type
19945 builder (eg, if you have interface IFoo, interface
19946 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
19949 This patch makes MCS able to bootstrap itself on
19952 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19954 * expression.cs: Remove the Nop's that Miguel put
19957 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19959 * report.cs, codegen.cs: Give the real stack trace to
19960 the error when an exception is thrown.
19962 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19964 * decl.cs: only allocate hashtables for ifaces if
19967 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19969 * expression.cs: fix the error from cs0121-2.cs
19970 (a parent interface has two child interfaces that
19971 have a function with the same name and 0 params
19972 and the function is called through the parent).
19974 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
19976 * class.cs, rootcontext.cs, typmanager.cs: do not
19979 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
19981 * codegen.cs: remove stack for the ec flow branching.
19982 It is already a linked list, so no need.
19984 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
19986 * Makefile: Allow custom profiler here.
19988 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19990 * typemanager.cs (LookupType):
19991 - Use a static char [], because split takes
19992 a param array for args, so it was allocating
19994 - Do not store true in a hashtable, it boxes.
19996 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19998 * flowanalysis.cs: bytify common enums.
20000 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20002 * modifiers.cs: Add a new set of flags for the
20003 flags allowed on explicit interface impls.
20004 * cs-parser.jay: catch the use of modifiers in
20005 interfaces correctly.
20006 * class.cs: catch private void IFoo.Blah ().
20008 All related to bug #50572.
20010 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20012 * decl.cs: Rewrite the consistant accessability checking.
20013 Accessability is not linear, it must be implemented in
20014 a tableish way. Fixes #49704.
20016 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20018 * expression.cs: Handle negation in a checked context.
20019 We must use subtraction from zero. Fixes #38674.
20021 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20023 * class.cs: Ignore static void main in DLLs.
20024 * rootcontext.cs: Handle the target type here,
20025 since we are have to access it from class.cs
20026 * driver.cs: account for the above.
20028 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20030 * report.cs: Give line numbers and files if available.
20032 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20034 * driver.cs: Implement /addmodule.
20036 * typemanager.cs: Change 'modules' field so it now contains Modules not
20039 2003-12-20 Martin Baulig <martin@ximian.com>
20041 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20042 (FieldBase.IsAssigned): Removed this field.
20043 (FieldBase.SetAssigned): New public method.
20044 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20046 2003-12-20 Martin Baulig <martin@ximian.com>
20048 * expression.cs (LocalVariableReference.DoResolve): Don't set
20049 `vi.Used' if we're called from DoResolveLValue().
20051 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20052 returns the usage vector it just merged into the current one -
20053 pass this one to UsageWarning().
20054 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20055 of the `EmitContext', don't call this recursively on our children.
20057 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20059 * driver.cs: Implement /target:module.
20061 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20063 * support.cs (CharArrayHashtable): New helper class.
20065 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20066 char arrays, not strings, so we can avoid creating a string in
20067 consume_identifier if the identifier is a keyword.
20069 2003-12-16 Martin Baulig <martin@ximian.com>
20071 * statement.cs (LocalInfo.Assigned): Removed this property.
20072 (LocalInfo.Flags): Removed `Assigned'.
20073 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20074 and uses flow analysis.
20075 (Block.UsageWarning): Made this method private.
20076 (Block.Resolve): Call UsageWarning() if appropriate.
20078 * expression.cs (LocalVariableReference.DoResolve): Always set
20079 LocalInfo.Used here.
20081 2003-12-13 Martin Baulig <martin@ximian.com>
20083 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20084 any value here; we're now using flow analysis to figure out
20085 whether a statement/block returns a value.
20087 2003-12-13 Martin Baulig <martin@ximian.com>
20089 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20091 (FlowBranching.MergeFinally): Don't call
20092 `branching.CheckOutParameters()' here, this is called in
20094 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20095 when adding the `finally' vector.
20097 2003-12-13 Martin Baulig <martin@ximian.com>
20100 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20101 actually work and also fix #48962.
20103 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20105 * decl.cs: Do not check System.Object for nested types,
20106 since we know it does not have any. Big bang for buck:
20109 Run 1: 8.35 seconds
20110 Run 2: 8.32 seconds
20111 corlib: 17.99 seconds
20113 Run 1: 8.17 seconds
20114 Run 2: 8.17 seconds
20115 corlib: 17.39 seconds
20117 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20119 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20120 time we are returning 0 members, so we save alot here.
20122 2003-12-11 Martin Baulig <martin@ximian.com>
20124 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20125 `MergeChild()', also just take the `FlowBranching' as argument;
20126 call Merge() on it and return the result.
20127 (FlowBranching.Merge): We don't need to do anything if we just
20130 2003-12-11 Martin Baulig <martin@ximian.com>
20132 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20133 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20134 Maurer for this idea.
20136 2003-12-11 Martin Baulig <martin@ximian.com>
20138 * flowanalysis.cs (MergeResult): This class is now gone; we now
20139 use the `UsageVector' for this. The reason for this is that if a
20140 branching just has one sibling, we don't need to "merge" them at
20141 all - that's the next step to do.
20142 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20145 2003-12-11 Martin Baulig <martin@ximian.com>
20147 Reworked flow analyis and made it more precise and bug-free. The
20148 most important change is that we're now using a special `Reachability'
20149 class instead of having "magic" meanings of `FlowReturns'. I'll
20150 do some more cleanups and optimizations and also add some more
20151 documentation this week.
20153 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20154 largely reworked this class.
20155 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20156 the new `Reachability' class instead of having "magic" values here.
20157 (FlowBranching): We're now using an instance of `Reachability'
20158 instead of having separate `Returns', `Breaks' etc. fields.
20160 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20161 based on flow analysis; ignore the return value of block.Emit ().
20163 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20165 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20166 if they are private.
20168 2003-12-09 Martin Baulig <martin@ximian.com>
20170 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20171 call them directly on the UsageVector.
20173 2003-12-09 Martin Baulig <martin@ximian.com>
20175 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20176 Changed return type from `FlowReturns' to `Reachability'.
20178 2003-12-09 Martin Baulig <martin@ximian.com>
20180 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20181 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20182 `Reachable' fields with a single `Reachability' one.
20184 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20186 * class.cs (FindMembers): Remove foreach's.
20191 Run 1: 8.74 seconds
20192 Run 2: 8.71 seconds
20195 Run 1: 8.64 seconds
20196 Run 2: 8.58 seconds
20199 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20204 This patch does a few things:
20205 1. EmptyStatement is now a singleton, so it is never reallocated.
20206 2. All blah is EmptyStatement constructs have been changed to
20207 blah == EmptyStatement.Value, which is much faster and valid
20208 now that EmptyStatement is a singleton.
20209 3. When resolving a block, rather than allocating a new array for
20210 the non-empty statements, empty statements are replaced with
20211 EmptyStatement.Value
20212 4. Some recursive functions have been made non-recursive.
20213 Mainly the performance impact is from (3), however (1) and (2) are needed for
20214 this to work. (4) does not make a big difference in normal situations, however
20215 it makes the profile look saner.
20220 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20221 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20222 Total memory allocated: 56397 KB
20225 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20226 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20227 Total memory allocated: 55666 KB
20229 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20231 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20232 than the hashtable in a hashtable version
20234 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20235 we always end up concating a string. This results in a huge perf
20236 loss, because many strings have to be tracked by the GC. In this
20237 patch, we first use a hashtable that works with two keys, so that
20238 the strings do not need to be concat'ed.
20242 Run 1: 8.74 seconds
20243 Run 2: 8.71 seconds
20246 Run 1: 8.65 seconds
20247 Run 2: 8.56 seconds
20249 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20251 * Makefile: Add a new target `do-time' that does a quick and simple
20252 profile, leaving easy to parse output.
20254 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20256 * codegen.cs (Init): Create the dynamic assembly with
20257 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20259 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20261 * support.cs: Make the PtrHashtable use only one
20262 instance of its comparer.
20264 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20266 * typemanager.cs: Fix lookup of GetNamespaces.
20268 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20270 * expression.cs: Removed redundant line.
20272 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20273 ArrayLists, use for loops with bounds.
20275 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20278 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20279 arraylists, use for loop with bounds.
20281 The above three changes give us a 0.071 second performance
20282 improvement out of 3.294 seconds down to 3.223. On my machine
20283 the above changes reduced the memory usage by 1,387 KB during
20284 compiler bootstrap.
20286 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20287 QualifiedIdentifiers. Before we created a new string through
20288 concatenation, and mostly later on, the result would be
20289 manipulated by DecomposeQI through string manipulation.
20291 This reduced the compiler memory usage for bootstrapping from
20292 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20293 compile times in 0.05 seconds.
20295 2003-11-28 Dick Porter <dick@ximian.com>
20297 * support.cs: Do string compares with the Invariant culture.
20305 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20306 the comparison is done with the Invariant culture.
20308 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20310 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20311 GetEnumerator method.
20313 (ProbeCollectionType): Iterate starting at the most specific type
20314 upwards looking for a GetEnumerator
20316 * expression.cs: Shift count can be up to 31 for int/uint and 63
20319 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20321 * statement.cs (Block.LookupLabel): Also look for the label on the
20322 children blocks. Use a hash table to keep track of visited
20325 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20326 we actually did transform the other operand, otherwise fall back
20327 to the common codepath that casts to long.
20329 * cs-tokenizer.cs: Use the same code pattern as the int case.
20330 Maybe I should do the parsing myself, and avoid depending on the
20331 Parse routines to get this done.
20333 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20335 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20336 which fixes bug 51347. This time test it.
20338 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20339 attributes for example can not tell the difference between these.
20340 The difference was only a syntax feature of the language.
20342 * attribute.cs: Apply attributes to delegates.
20344 * delegate.cs: Call the apply attributes method.
20346 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20348 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20349 comparing 0 vs Byte.MinValue, not the value
20351 (ImplicitConversionRequired): When reporting a conversion error,
20352 use error 31 to print out the constant error instead of the
20355 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20356 which fixes bug 51347.
20358 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20360 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20361 which fixes the -warnaserror command line option.
20363 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20365 * cfold.cs (DoNumericPromotions): During constant folding of
20366 additions on UIntConstant, special case intconstants with
20367 IntConstants like we do on the expression binary operator.
20369 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20371 * convert.cs (ImplicitReferenceConversion): We were missing a case
20372 (System.Enum are not value types or class types, so we need to
20373 classify them separatedly).
20375 * driver.cs: We do not support error 2007.
20377 2003-11-12 Jackson Harper <jackson@ximian.com>
20379 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20380 system directory. Also use the full file name so users can
20381 libraries names mscorlib-o-tron.dll in a non system dir.
20383 2003-11-10 Martin Baulig <martin@ximian.com>
20385 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20386 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20387 calling `ResolveType()' on them, directly assign their `Type'.
20389 2003-11-08 Martin Baulig <martin@ximian.com>
20391 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20392 return value and the `out parent' parameter.
20393 (TypeContainer.DefineType): Moved the CS0644 check into
20394 GetClassBases(). Don't pass the interface types to the
20395 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20396 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20398 * ecore.cs (TypeExpr.IsAttribute): New property.
20399 (TypeExpr.GetInterfaces): New method.
20401 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20402 TypeExpr instead of a Type.
20403 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20404 (Interface.DefineType): Don't pass the interface types to the
20405 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20406 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20408 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20409 instead of a `Type[]'.
20410 (TypeManager.RegisterBuilder): Likewise.
20411 (TypeManager.AddUserInterface): Likewise.
20412 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20413 `Type[]' and also return a `TypeExpr[]'.
20414 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20416 2003-11-08 Martin Baulig <martin@ximian.com>
20418 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20421 2003-11-08 Martin Baulig <martin@ximian.com>
20423 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20424 TypeManager.ResolveExpressionTypes().
20426 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20427 instead of an Expression.
20428 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20429 (TypeExpression): New public class; formerly known as `TypeExpr'.
20431 * expression.cs (ComposedCast): Derive from TypeExpr.
20433 * typemanager.cs (TypeManager.system_*_expr): These are now
20434 TypExpr's instead of Expression's.
20435 (TypeManager.ResolveExpressionTypes): New public static function;
20436 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20439 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20441 * expression.cs (New.DoResolve): Do not dereference value that
20442 might be a null return.
20444 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20445 sure that the constant value has the right type. Fixes an
20446 unreported bug, similar to 50425.
20448 * const.cs (Const.LookupConstantValue): Call
20449 ImplicitStandardConversionExists before doing a conversion to
20450 avoid havng the TypeManager.ChangeType do conversions.
20452 Reduced the number of casts used
20454 (Const.ChangeType): New routine to enable reuse of the constant
20455 type changing code from statement.
20457 * typemanager.cs (ChangeType): Move common initialization to
20458 static global variables.
20462 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20463 every value type to go through, even if it was void. Fix that.
20465 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20466 character of the define, and the is_identifier_part_character for
20467 the rest of the string.
20469 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20471 * expression.cs (UnaryMutator.EmitCode): When I updated
20472 LocalVariableReference.DoResolve, I overdid it, and dropped an
20473 optimization done on local variable references.
20475 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20477 * ecore.cs: Convert the return from Ldlen into an int.
20479 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20481 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20482 the accessibility, this is a special case for toplevel non-public
20483 classes (internal for instance).
20485 2003-10-20 Nick Drochak <ndrochak@gol.com>
20487 * ecore.cs: Fix typo and build. Needed another right paren.
20489 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20491 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20492 `internal' case regular and protected, but not allowing protected
20493 to be evaluated later. Bug 49840
20495 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20497 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20498 to kb.Nlast, and not the kb.nFirst to isolate the switch
20501 Extract the underlying type, so enumerations of long/ulong are
20502 treated like long/ulong.
20504 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20506 * expression.cs (New): Overload the meaning of RequestedType to
20507 track the possible creation of the NewDelegate type, since
20508 DoResolve is invoked more than once for new constructors on field
20511 See bugs: #48800 and #37014
20513 * cs-parser.jay (declare_local_constants): Take an arraylist
20514 instead of a single constant.
20516 (local_constant_declaration): It should take a
20517 constant_declarators, not a constant_declarator. Fixes 49487
20519 * convert.cs: Fix error report.
20521 2003-10-13 Jackson Harper <jackson@ximian.com>
20523 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20526 2003-10-09 Martin Baulig <martin@ximian.com>
20528 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20530 (MethodCore.DoDefineParameters): Removed the TypeContainer
20531 argument; use the DeclSpace which was passed to the .ctor instead.
20532 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20533 TypeContainer; we only need a DeclSpace here.
20535 2003-10-09 Martin Baulig <martin@ximian.com>
20537 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20539 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20540 EmitContext's .ctor.
20542 2003-10-09 Martin Baulig <martin@ximian.com>
20544 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20545 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20546 AsAccessible(), moved them as well.
20548 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20550 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20552 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20554 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20556 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20557 generation for >=, as spotted by Paolo, bug 48679.
20558 Patch from David Waite.
20560 * cs-tokenizer.cs: Add handling for #pragma.
20562 * cs-parser.jay: Allow for both yield and yield return in the
20563 syntax. The anti-cobolization of C# fight will go on!
20565 * class.cs (TypeBuilder.DefineType): Catch error condition here
20566 (Parent.DefineType erroring out and returning null).
20568 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20569 coping with enumerations variables, we were mistakenly processing
20570 them as a regular value type instead of built-in types. Fixes the
20573 * typemanager.cs (IsBuiltinOrEnum): New method.
20575 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20577 * cs-parser.jay: Upgrade: yield now needs the return clause.
20579 2003-09-19 Martin Baulig <martin@ximian.com>
20581 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20582 `MemberCache parent' argument. Normally, an interface doesn't
20583 have a parent type except System.Object, but we use this in gmcs
20584 for generic type parameters.
20586 2003-09-18 Martin Baulig <martin@ximian.com>
20588 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
20589 on `type.IsInterface'; don't check whether the type has a parent
20590 to determine whether it's an interface.
20592 2003-09-15 Martin Baulig <martin@ximian.com>
20594 * class.cs (TypeContainer.DefineType): Added an error flag to
20595 avoid reporting duplicate CS0146's ("class definition is
20598 * driver.cs (Driver.MainDriver): Abort if
20599 RootContext.ResolveTree() reported any errors.
20601 2003-09-07 Martin Baulig <martin@ximian.com>
20603 * report.cs (Error, Warning): Added overloaded versions which take
20604 a `params object[] args' and call String.Format().
20606 2003-09-07 Martin Baulig <martin@ximian.com>
20608 * decl.cs (DeclSpace..ctor): Don't call
20609 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
20610 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
20611 (DeclSpace.RecordDecl): New method.
20613 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
20615 2003-09-02 Ravi Pratap <ravi@ximian.com>
20617 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
20618 value attributes to be applied to ParameterBuilders.
20620 * class.cs (MethodCore.LabelParameters): Make static and more
20621 generic so that it can be used from other places - like interface
20622 methods, for instance.
20624 * interface.cs (Interface.Emit): Call LabelParameters before
20625 emitting attributes on the InterfaceMethod.
20627 2003-08-26 Martin Baulig <martin@ximian.com>
20629 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
20630 resolving aliases; fixes #47927.
20632 2003-08-26 Martin Baulig <martin@ximian.com>
20634 * statement.cs (Using.DoResolve): This is internally emitting a
20635 try/finally clause, so we need to set ec.NeedExplicitReturn if we
20636 do not always return. Fixes #47681.
20638 2003-08-26 Martin Baulig <martin@ximian.com>
20640 * decl.cs (MemberCore): Moved WarningNotHiding(),
20641 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
20643 (AdditionResult): Make this nested in DeclSpace.
20644 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
20645 argument; call NamespaceEntry.Define() unless we're nested in a
20648 * namespace.cs (Namespace.DefineName): New public function. This
20649 is called from DeclSpace's .ctor to add
20650 (Namespace.Lookup): Include DeclSpaces in the lookup.
20652 * class.cs (Operator): Derive from MemberBase, not MemberCore.
20654 * const.cs (Const): Derive from MemberBase, not MemberCore.
20656 2003-08-25 Martin Baulig <martin@ximian.com>
20658 * convert.cs (Convert.ExplicitReferenceConversion): When
20659 converting from an interface type to a class, unbox if the target
20660 type is a struct type. Fixes #47822.
20662 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20664 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
20667 2003-08-22 Martin Baulig <martin@ximian.com>
20669 * class.cs (TypeManager.DefineType): When defining a nested type,
20670 call DefineType() on our parent; fixes #47801.
20672 2003-08-22 Martin Baulig <martin@ximian.com>
20674 * class.cs (MethodData.Define): While checking if a method is an
20675 interface implementation, improve the test a bit more to fix #47654.
20677 2003-08-22 Martin Baulig <martin@ximian.com>
20679 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
20680 correctly; fixes #47722.
20682 2003-08-22 Martin Baulig <martin@ximian.com>
20684 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
20685 LocalVariableReference, ensure it's not read-only. Fixes #47536.
20687 * statement.cs (Fixed.DoResolve): Make all variables read-only.
20689 2003-08-22 Martin Baulig <martin@ximian.com>
20691 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
20692 can only be assigned in static constructors. Fixes #47161.
20694 2003-08-22 Martin Baulig <martin@ximian.com>
20696 Rewrote and improved the flow analysis code.
20698 * flowbranching.cs (FlowBranching): Make this class abstract.
20699 (FlowBranching.CreateBranching): New static function to create a
20700 new flow branching.
20701 (FlowBranchingBlock, FlowBranchingException): New classes.
20702 (FlowBranching.UsageVector.Type): New public readonly field.
20703 (FlowBranching.UsageVector.Breaks): Removed the setter.
20704 (FlowBranching.UsageVector.Returns): Removed the setter.
20705 (FlowBranching.UsageVector): Added Break(), Return(),
20706 NeverReachable() and Throw() methods to modify the reachability.
20707 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
20708 done by FlowBranching.Merge().
20709 (FlowBranching.UsageVector.MergeChild): New method; merges the
20710 merge result into the current vector.
20711 (FlowBranching.Merge): New abstract method to merge a branching.
20713 2003-08-12 Martin Baulig <martin@ximian.com>
20715 * expression.cs (Indirection.CacheTemporaries): Create the
20716 LocalTemporary with the pointer type, not its element type.
20718 2003-08-10 Miguel de Icaza <miguel@ximian.com>
20720 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
20721 token was a keyword or not.
20723 Add `error' options where an IDENTIFIER was expected; Provide
20724 CheckToken and CheckIdentifierToken convenience error reporting
20727 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
20729 * decl.cs: Rename `NamespaceEntry Namespace' public field into
20730 NameSpaceEntry NameSpaceEntry.
20732 (LookupInterfaceOrClass): Avoid creating a full qualified name
20733 from namespace and name: avoid doing lookups when we know the
20734 namespace is non-existant. Use new Tree.LookupByNamespace which
20735 looks up DeclSpaces based on their namespace, name pair.
20737 * driver.cs: Provide a new `parser verbose' to display the
20738 exception thrown during parsing. This is turned off by default
20739 now, so the output of a failure from mcs is more graceful.
20741 * namespace.cs: Track all the namespaces defined in a hashtable
20744 (IsNamespace): New method
20746 2003-08-09 Miguel de Icaza <miguel@ximian.com>
20748 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
20749 we know that we need to concatenate (full typename can never be
20754 * statement.cs: Use a bitfield; Do not initialize to null things
20755 which are done by the constructor by default.
20757 * cs-parser.jay: bug fix, parameter was 4, not 3.
20759 * expression.cs: Just use the property;
20761 * statement.cs: No need for GetVariableInfo method.
20763 2003-08-08 Martin Baulig <martin@ximian.com>
20765 * flowanalysis.cs (FlowReturns): This is now nested in the
20766 `FlowBranching' class.
20767 (MyBitVector): Moved this here from statement.cs.
20768 (FlowBranching.SiblingType): New enum type.
20769 (FlowBranching.CreateSibling): Added `SiblingType' argument.
20771 2003-08-07 Martin Baulig <martin@ximian.com>
20773 * flowanalysis.cs (FlowBranchingType): This is now nested in the
20774 `FlowBranching' class and called `BranchingType'.
20776 2003-08-07 Martin Baulig <martin@ximian.com>
20778 * flowanalysis.cs: Moved all the control flow analysis code into
20781 2003-08-07 Martin Baulig <martin@ximian.com>
20783 * assign.cs (Assign.DoResolve): `target' must either be an
20784 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
20787 2003-08-07 Miguel de Icaza <miguel@ximian.com>
20789 * expression.cs (BinaryMethod): This kind of expression is created by the
20790 Binary class if it determines that the operator has to be handled
20793 (BinaryDelegate): This kind of expression is created if we are
20794 dealing with a + or - operator on delegates.
20796 (Binary): remove method, argumetns, and DelegateOperator: when
20797 dealing with methods,
20799 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
20801 * statement.cs (Block): use bitfields for the three extra booleans
20802 we had in use. Remove unused topblock parameter.
20804 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
20806 * assign.cs: Drop extra unneeded tests.
20808 2003-08-06 Miguel de Icaza <miguel@ximian.com>
20810 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
20812 * statement.cs (Foreach): Use VariableStorage instead of
20815 * codegen.cs (VariableStorage): New class used by clients that
20816 require a variable stored: locals or fields for variables that
20817 need to live across yield.
20819 Maybe provide a convenience api for EmitThis+EmitLoad?
20821 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
20824 2003-08-05 Miguel de Icaza <miguel@ximian.com>
20826 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
20827 RemapParameterLValue): New methods that are used to turn a
20828 precomputed FieldInfo into an expression like this:
20832 The idea is to use this instead of making LocalVariableReference
20833 have more than one meaning.
20835 * cs-parser.jay: Add error production to BASE.
20837 * ecore.cs: Deal with TypeManager.GetField returning null, which
20838 is now a valid return value.
20840 (FieldExprNoAddress): New expression for Fields whose address can
20843 * expression.cs (LocalVariableReference): During the resolve
20844 phases, create new expressions if we are in a remapping context.
20845 Remove code that dealt with remapping here.
20847 (ParameterReference): same.
20849 (ProxyInstance): New expression, like the `This' expression, but
20850 it is born fully resolved. We know what we are doing, so remove
20851 the errors that are targeted to user-provided uses of `this'.
20853 * statement.cs (Foreach): our variable is now stored as an
20854 Expression; During resolution, follow the protocol, dont just
20855 assume it will return this.
20857 2003-08-06 Martin Baulig <martin@ximian.com>
20859 * support.cs (SeekableStreamReader.cs): New public class.
20861 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
20862 SeekableStreamReader instead of the normal StreamReader.
20864 2003-08-04 Martin Baulig <martin@ximian.com>
20866 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
20867 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
20868 deambiguate casts and delegate invocations.
20869 (parenthesized_expression): Use the new tokens to ensure this is
20870 not a cast of method invocation.
20872 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
20873 when reading a `)' and Deambiguate_CloseParens () was previously
20876 * expression.cs (ParenthesizedExpression): New class. This is
20877 just used for the CS0075 test.
20878 (Binary.DoResolve): Check for CS0075.
20880 2003-07-29 Ravi Pratap <ravi@ximian.com>
20882 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
20883 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
20884 reference comparison.
20886 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
20887 examine the ReturnType for equality - this is necessary in the
20888 cases of implicit and explicit operators whose signature also
20889 includes the return type.
20891 2003-07-26 Miguel de Icaza <miguel@ximian.com>
20893 * namespace.cs: Cache the result of the namespace computation,
20894 instead of computing it every time.
20896 2003-07-24 Miguel de Icaza <miguel@ximian.com>
20898 * decl.cs: Use a global arraylist that we reuse over invocations
20899 to avoid excesive memory consumption. Reduces memory usage on an
20900 mcs compile by one meg (45 average).
20902 * typemanager.cs (LookupTypeReflection): In .NET pointers are
20903 private, work around that.
20905 2003-07-23 Miguel de Icaza <miguel@ximian.com>
20907 * literal.cs (IntLiteral): Define Zero and One static literals.
20909 * cs-parser.jay (integer_literal): use static literals to reduce
20910 memory usage for the most used literals (0, 1 and -1). 211kb
20911 reduced in memory usage.
20913 Replace all calls to `new ArrayList' with `new
20914 ArrayList(4)' which is a good average number for most allocations,
20915 and also requires only 16 bytes of memory for its buffer by
20918 This reduced MCS memory usage in seven megabytes for the RSS after
20921 2003-07-28 Ravi Pratap <ravi@ximian.com>
20923 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
20924 handle params methods the correct way by forming only one
20925 applicable set with params and normal methods in them. Earlier we
20926 were looking at params methods only if we found no normal methods
20927 which was not the correct thing to do.
20929 (Invocation.BetterFunction): Take separate arguments indicating
20930 when candidate and the best method are params methods in their
20933 This fixes bugs #43367 and #46199.
20935 * attribute.cs: Documentation updates.
20937 (CheckAttribute): Rename to CheckAttributeTarget.
20938 (GetValidPlaces): Rename to GetValidTargets.
20940 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
20941 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
20945 2003-07-28 Martin Baulig <martin@ximian.com>
20947 * class.cs (TypeContainer.DefineMembers): Use the base type's full
20948 name when looking up the base class of a nested class. Fixes #46977.
20950 2003-07-26 Martin Baulig <martin@ximian.com>
20952 * expression.cs (Indexers.Indexer): New nested struct; contains
20953 getter, setter and the indexer's type.
20954 (Indexers.Properties): This is now an ArrayList of
20955 Indexers.Indexer's.
20956 (IndexerAccess.DoResolveLValue): Correctly set the type if the
20957 indexer doesn't have any getters.
20959 * assign.cs (Assign.DoResolve): Also do the implicit conversions
20960 for embedded property and indexer assignments.
20962 2003-07-26 Martin Baulig <martin@ximian.com>
20964 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
20965 preprocessor directive is not the first non-whitespace character
20968 2003-07-26 Martin Baulig <martin@ximian.com>
20970 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
20971 namespace parsing, follow the spec more closely.
20973 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
20974 NamespaceEntry.Lookup().
20976 2003-07-25 Martin Baulig <martin@ximian.com>
20978 * MethodCore.cs (OverridesSomething): New public field; it's set
20979 from TypeContainer.DefineMembers if this method overrides
20980 something (which doesn't need to be a method). Fix #39462.
20982 2003-07-25 Ravi Pratap <ravi@ximian.com>
20984 * typemanager.cs (GetMembers): Ensure that the list of members is
20985 reversed. This keeps things in sync.
20987 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
20988 find an AttributeUsage attribute.
20990 * expression.cs (Invocation.OverloadResolve): Perform the check
20991 which disallows Invoke to be directly called on a Delegate.
20993 (Error_InvokeOnDelegate): Report error cs1533.
20995 2003-07-25 Martin Baulig <martin@ximian.com>
20997 * expression.cs (Indexers.GetIndexersForType): Only look in the
20998 interface hierarchy if the requested type is already an
20999 interface. Fixes #46788 while keeping #46502 fixed.
21001 2003-07-25 Martin Baulig <martin@ximian.com>
21003 * class.cs (TypeContainer.DefineMembers): Check whether all
21004 readonly fields have been assigned and report warning CS0649 if
21007 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21010 2003-07-24 Ravi Pratap <ravi@ximian.com>
21012 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21013 returned from GetMethods to make things consistent with the
21014 assumptions MCS makes about ordering of methods.
21016 This should comprehensively fix bug #45127 and it does :-)
21018 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21019 ordering is actually reverse.
21021 * Clean up some debug messages I left lying around.
21023 * interface.cs (Populate*): Get rid of code which emits attributes
21024 since the stage in which we emit attributes is the 'Emit' stage,
21025 not the define stage.
21027 (Emit): Move attribute emission for interface members here.
21029 2003-07-22 Ravi Pratap <ravi@ximian.com>
21031 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21032 closely: we eliminate methods in base types when we have an
21033 applicable method in a top-level type.
21035 Please see section 14.5.5.1 for an exact description of what goes
21038 This fixes bug #45127 and a host of other related to corlib compilation.
21040 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21041 array is the method corresponding to the top-level type (this is
21042 because of the changes made to icall.c) so we change this
21045 (MethodGroupExpr.Name): This too.
21047 * typemanager.cs (GetElementType): New method which does the right
21048 thing when compiling corlib.
21050 * everywhere: Make use of the above in the relevant places.
21052 2003-07-22 Martin Baulig <martin@ximian.com>
21054 * cs-parser.jay (invocation_expression): Moved
21055 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21056 `cast_expression', but create a InvocationOrCast which later
21057 resolves to either an Invocation or a Cast.
21059 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21060 method; call this before EmitStatement() to make sure that this
21061 expression can be used as a statement.
21063 * expression.cs (InvocationOrCast): New class; resolves to either
21064 an Invocation or a Cast.
21066 * statement.cs (StatementExpression): Call ResolveStatement() on
21067 the ExpressionStatement before emitting it.
21069 2003-07-21 Martin Baulig <martin@ximian.com>
21071 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21072 `ref' and `out' attributes match; fixes #46220.
21073 (MemberAccess.ResolveMemberAccess): You can't reference a type
21074 through an expression; fixes #33180.
21075 (Indexers.GetIndexersForType): Don't return the indexers from
21076 interfaces the class implements; fixes #46502.
21078 2003-07-21 Martin Baulig <martin@ximian.com>
21080 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21081 CS0661 checks; fixes bug #30442.
21083 2003-07-21 Martin Baulig <martin@ximian.com>
21085 * decl.cs (AdditionResult): Added `Error'.
21087 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21089 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21090 makes cs0031.cs actually work.
21092 2003-07-20 Martin Baulig <martin@ximian.com>
21094 * namespace.cs: Fixed that bug which caused a crash when compiling
21095 the debugger's GUI.
21097 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21099 * typemanager.cs (LookupTypeReflection): Never expose types which
21100 are NotPublic, NestedPrivate, NestedAssembly, or
21101 NestedFamANDAssem. We used to return these, and later do a check
21102 that would report a meaningful error, but the problem is that we
21103 would not get the real match, if there was a name override.
21105 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21107 * namespace.cs (Namespace, Name): Do not compute the namespace
21108 name dynamically, compute it in the constructor. This reduced
21109 memory usage by 1697 KB.
21111 * driver.cs: Use --pause to pause at the end.
21113 2003-07-17 Peter Williams <peter@newton.cx>
21115 * Makefile: Change the name of the test target so that it doesn't
21116 conflict with the recursive test target.
21118 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21120 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21121 AddressOf): Do not use EmitThis, that was wrong, use the actual
21124 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21126 * class.cs (MethodData.Define): While checking if a method is an
21127 interface implementation, improve the test: If we are not public
21128 (use new test here: use the computed MethodAttributes directly,
21129 instead of the parsed modifier flags) check if the `implementing'
21130 method comes from an interface or not.
21132 * pending.cs (VerifyPendingMethods): Slightly better error
21135 * makefile: add test target that does the mcs bootstrap.
21137 2003-07-16 Ravi Pratap <ravi@ximian.com>
21139 * interface.cs (Define): Do nothing here since there are no
21140 members to populate etc. Move the attribute emission out of here
21141 since this was just totally the wrong place to put it. Attribute
21142 application happens during the 'Emit' phase, not in the 'Define'
21145 (Emit): Add this method and move the attribute emission here
21147 * rootcontext.cs (EmitCode): Call the Emit method on interface
21150 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21152 * expression.cs (OverloadResolve): Report error only if Location
21153 is not 'Null' which means that there was a probe going on.
21155 2003-07-14 Martin Baulig <martin@ximian.com>
21157 * expression.cs (ConditionalLogicalOperator): New public class to
21158 implement user defined conditional logical operators.
21159 This is section 14.11.2 in the spec and bug #40505.
21161 2003-07-14 Martin Baulig <martin@ximian.com>
21163 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21165 2003-07-14 Martin Baulig <martin@ximian.com>
21167 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21169 * ecore.cs (IVariable.VerifyFixed): New interface method.
21171 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21172 operator, check whether the variable is actually fixed. Fixes bug
21173 #36055. Set a variable definitely assigned when taking its
21174 address as required by the spec.
21176 * statement.cs (LocalInfo.IsFixed): New field.
21177 (LocalInfo.MakePinned): Set `IsFixed' to true.
21179 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21181 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21182 for .ctors, ensure that we only ask for members declared in the
21183 attribute type (BindingFlags.DeclaredOnly).
21187 * expression.cs (Error_WrongNumArguments): Report error 1501
21188 correctly the way CSC does.
21190 2003-07-13 Martin Baulig <martin@ximian.com>
21192 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21193 lookup on the fully qualified name, to make things like "X.X" work
21194 where "X.X" is a fully qualified type name, but we also have a
21195 namespace "X" in the using list. Fixes #41975.
21197 2003-07-13 Martin Baulig <martin@ximian.com>
21199 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21200 function. If we're a CompoundAssign, we need to create an embedded
21201 CompoundAssign, not an embedded Assign.
21202 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21205 2003-07-13 Martin Baulig <martin@ximian.com>
21207 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21208 work to fix bug #46088.
21210 2003-07-13 Ravi Pratap <ravi@ximian.com>
21212 * class.cs (Operator.Emit): Do not emit attributes here - it is
21213 taken care of by the Method class that we delegate too. This takes
21214 care of bug #45876.
21216 2003-07-10 Martin Baulig <martin@ximian.com>
21218 * expression.cs (TypeOfVoid): New class.
21219 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21221 2003-07-10 Martin Baulig <martin@ximian.com>
21223 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21226 2003-07-10 Martin Baulig <martin@ximian.com>
21228 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21229 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21231 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21233 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21235 2003-07-10 Martin Baulig <martin@ximian.com>
21237 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21238 of decimal. Fixes #42850.
21240 NOTE: I also fixed the created byte blob, but this doesn't work on
21241 the MS runtime and csc never produces any byte blobs for decimal
21244 2003-07-10 Martin Baulig <martin@ximian.com>
21246 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21247 structs; fixes #32068.
21248 (Block.AddChildVariableNames): Fixed #44302.
21250 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21252 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21254 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21256 * attribute.cs: And this test is onger needed.
21258 2003-07-08 Martin Baulig <martin@ximian.com>
21260 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21261 inaccessible types. Fixes #36313.
21263 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21265 * namespace.cs (NamespaceEntry): Create implicit entries for all
21266 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21267 implicit entries for N1.N2 and N1.
21269 2003-07-08 Martin Baulig <martin@ximian.com>
21271 Rewrote the handling of namespaces to fix a lot of the issues
21272 wrt. `using' aliases etc.
21274 * namespace.cs (Namespace): Splitted this class into a
21275 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21277 * typemanager.cs (TypeManager.IsNamespace): Removed.
21278 (TypeManager.ComputeNamespaces): Only compute namespaces from
21279 loaded assemblies here, not the namespaces from the assembly we're
21280 currently compiling.
21282 2003-07-08 Martin Baulig <martin@ximian.com>
21284 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21286 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21288 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21291 I thought about the memory savings here, but LookupTypeReflection
21292 is used under already very constrained scenarios. Compiling
21293 corlib or mcs only exposes one hit, so it would not really reduce
21294 any memory consumption.
21296 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21298 * typemanager.cs: fixes bug #45889 by only adding public types from
21299 other assemblies to the list of known types.
21301 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21303 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21304 on the type we resolved.
21306 2003-07-05 Martin Baulig <martin@ximian.com>
21308 * pending.cs (PendingImplementation.ParentImplements): Don't
21309 create the proxy if the parent is abstract.
21311 * class.cs (TypeContainer.DefineIndexers): Process explicit
21312 interface implementations first. Fixes #37714.
21314 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21316 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21317 defined recursively; but since we modify the input parameters
21318 (left is set to `this' temporarily), we reset this value if the
21319 left_is_explicit is false, which gives the original semantics to
21322 * literal.cs (NullPointer): new class used to represent a null
21323 literal in a pointer context.
21325 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21326 type is a pointer, use a NullPointer object instead of a
21327 NullLiteral. Closes 43687
21329 (ExplicitConversion): Convert pointer values using
21330 the conv opcode to the proper type.
21332 * ecore.cs (New): change ValueTypeVariable property into a method,
21333 that returns whether the valuetype is suitable for being used.
21335 * expression.cs (Binary.DoNumericPromotions): Only return if we
21336 the int constant was a valid uint, and we can return both left and
21337 right as uints. If not, we continue processing, to trigger the
21338 type conversion. This fixes 39018.
21340 * statement.cs (Block.EmitMeta): During constant resolution, set
21341 the CurrentBlock property on the emitcontext, so that we resolve
21342 constants propertly.
21344 2003-07-02 Martin Baulig <martin@ximian.com>
21346 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21347 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21349 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21350 than emitting it here.
21352 * statement.cs: Fixed some more flow analysis bugs.
21354 2003-07-02 Martin Baulig <martin@ximian.com>
21356 * class.cs (MethodData.Define): When implementing interface
21357 methods, set Final unless we're Virtual.
21359 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21360 check work for interface methods.
21362 2003-07-01 Martin Baulig <martin@ximian.com>
21364 * ecore.cs (EmitContext.This): Replaced this property with a
21365 GetThis() method which takes a Location argument. This ensures
21366 that we get the correct error location for a CS0188.
21368 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21370 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21371 ImplicitStandardConversion.
21373 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21375 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21377 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21380 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21382 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21385 (MethodData.Define): Turn off initlocals for unsafe methods.
21387 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21389 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21390 complete; Fixes #37521.
21392 * delegate.cs: Use Modifiers.TypeAttr to compute the
21393 TypeAttributes, instead of rolling our own. This makes the flags
21394 correct for the delegates.
21396 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21398 * class.cs (Constructor.Define): Set the private flag for static
21399 constructors as well.
21401 * cs-parser.jay (statement_expression): Set the return value to
21402 null, to avoid a crash when we catch an error.
21404 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21406 * cs-parser.jay: Applied patch from Jackson that adds support for
21407 extern and unsafe modifiers to destructor declarations.
21409 * expression.cs: Report error 21 if the user is trying to index a
21412 * driver.cs: Add an error message, suggested by the bug report.
21414 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21415 if we do not have a ": this ()" constructor initializer. Fixes 45149
21417 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21419 * namespace.cs: Add some information to reduce FAQs.
21421 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21423 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21424 underlying enumeration types. Fixes #43915.
21426 * expression.cs: Treat ushort/short as legal values to be used in
21427 bitwise operations.
21429 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21431 * delegate.cs: transfer custom attributes for paramenters from
21432 the delegate declaration to Invoke and BeginInvoke.
21434 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21436 * attribute.cs: handle custom marshalers and emit marshal info
21439 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21441 * makefile.gnu: Added anonymous.cs to the compiler sources.
21443 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21445 * iterators.cs: Change the name of the proxy class to include two
21448 * cs-parser.jay: Update grammar to include anonymous methods.
21450 * anonymous.cs: new file.
21452 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21454 * class.cs (Field.Define): Add missing test for pointers and
21457 2003-05-27 Ravi Pratap <ravi@ximian.com>
21459 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21460 we use the stobj opcode.
21462 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21463 since it wasn't the correct fix.
21465 It still is puzzling that we are required to use stobj for IntPtr
21466 which seems to be a ValueType.
21468 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21470 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21471 during regular simple name resolution. Now, the trick is that
21472 instead of returning for processing the simplename, we do a
21473 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21474 contextual lookup type). If a match is found, return that, if
21475 not, return for further composition.
21477 This fixes long-standing 30485.
21479 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21480 using the address to initialize an object, do an Stobj instead of
21481 using the regular Stelem.
21483 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21484 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21485 Because if we are a BaseIndexerAccess that value will be true.
21488 * statement.cs (GotoCase.Resolve): Return after reporting an
21489 error, do not attempt to continue.
21491 * expression.cs (PointerArithmetic.Emit): If our operand is a
21492 long, convert our constants to match the operand before
21493 multiplying. Convert to I type before adding. Fixes 43670.
21495 2003-05-14 Ravi Pratap <ravi@ximian.com>
21497 * enum.cs (ImplicitConversionExists) : Rename to
21498 ImplicitEnumConversionExists to remove ambiguity.
21500 * ecore.cs (NullCast): New type of cast expression class which
21501 basically is very similar to EmptyCast with the difference being
21502 it still is a constant since it is used only to cast a null to
21504 (eg. (string) null)
21506 * convert.cs (ImplicitReferenceConversion): When casting a null
21507 literal, we return a NullCast.
21509 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21510 should be around anymore.
21512 The renaming (reported was slightly wrong). Corrections:
21514 ConvertImplicitStandard -> ImplicitConversionStandard
21515 ConvertExplicitStandard -> ExplicitConversionStandard
21517 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21518 before passing them in !
21520 * convert.cs (ImplicitConversionStandard): When comparing for
21521 equal expr and target types, ensure that expr is not a
21524 In general, we must not be checking (expr_type ==
21525 target_type) in the top level conversion methods
21526 (ImplicitConversion, ExplicitConversion etc). This checking is
21527 done in the methods that they delegate to.
21529 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21531 * convert.cs: Move Error_CannotConvertType,
21532 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21533 ImplicitNumericConversion, ImplicitConversionExists,
21534 ImplicitUserConversionExists, StandardConversionExists,
21535 FindMostEncompassedType, FindMostSpecificSource,
21536 FindMostSpecificTarget, ImplicitUserConversion,
21537 ExplicitUserConversion, GetConversionOperators,
21538 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21539 TryImplicitIntConversion, Error_CannotConvertImplicit,
21540 ConvertImplicitRequired, ConvertNumericExplicit,
21541 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21542 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21545 Perform the following renames:
21547 StandardConversionExists -> ImplicitStandardConversionExists
21548 ConvertImplicit -> ImplicitConversion
21549 ConvertImplicitStandard -> ImplicitStandardConversion
21550 TryImplicitIntConversion -> ImplicitIntConversion
21551 ConvertImplicitRequired -> ImplicitConversionRequired
21552 ConvertNumericExplicit -> ExplicitNumericConversion
21553 ConvertReferenceExplicit -> ExplicitReferenceConversion
21554 ConvertExplicit -> ExplicitConversion
21555 ConvertExplicitStandard -> ExplicitStandardConversion
21557 2003-05-19 Martin Baulig <martin@ximian.com>
21559 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21560 (TypeInfo): Added support for structs having structs as fields.
21562 * ecore.cs (FieldExpr): Implement IVariable.
21563 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21564 VariableInfo for the field.
21566 2003-05-18 Martin Baulig <martin@ximian.com>
21568 * expression.cs (This.DoResolve): Report a CS0027 if we're
21569 emitting a field initializer.
21571 2003-05-18 Martin Baulig <martin@ximian.com>
21573 * expression.cs (This.ResolveBase): New public function.
21574 (This.DoResolve): Check for CS0188.
21576 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21579 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21580 `instance_expression' to null if we don't have any non-static
21583 2003-05-18 Martin Baulig <martin@ximian.com>
21585 Reworked the way how local variables and parameters are handled by
21586 the flow analysis code.
21588 * statement.cs (TypeInfo, VariableMap): New public classes.
21589 (VariableInfo): New public class. This is now responsible for
21590 checking whether a variable has been assigned. It is used for
21591 parameters and local variables.
21592 (Block.EmitMeta): Take the InternalParameters as argument; compute
21593 the layout of the flow vectors here.
21594 (Block.LocalMap, Block.ParameterMap): New public properties.
21595 (FlowBranching): The .ctor doesn't get the InternalParameters
21596 anymore since Block.EmitMeta() now computes the layout of the flow
21598 (MyStructInfo): This class is now known as `StructInfo' and nested
21599 in `TypeInfo'; we don't access this directly anymore.
21601 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
21602 property and removed IsAssigned(), IsFieldAssigned(),
21603 SetAssigned() and SetFieldAssigned(); we now call them on the
21604 VariableInfo so we don't need to duplicate this code everywhere.
21606 * expression.cs (ParameterReference): Added `Block block' argument
21608 (LocalVariableReference, ParameterReference, This): The new
21609 VariableInfo class is now responsible for all the definite
21612 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
21613 IsParameterAssigned, SetParameterAssigned): Removed.
21615 2003-05-18 Martin Baulig <martin@ximian.com>
21617 * typemanager.cs (InitCoreTypes): Try calling
21618 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
21619 the 3-args-version. Corlib now also needs our `void_type'.
21620 (GetMethod): Added overloaded version which takes an optional
21621 `bool report_errors' to allow lookups of optional methods.
21623 2003-05-12 Martin Baulig <martin@ximian.com>
21625 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
21626 only used for locals and not for parameters.
21628 2003-05-12 Miguel de Icaza <miguel@ximian.com>
21630 * support.cs (InternalParameters.ParameterType): Return the
21631 ExternalType of the parameter.
21633 * parameter.cs (Parameter.ExternalType): drop the two arguments,
21636 2003-05-11 Miguel de Icaza <miguel@ximian.com>
21638 * class.cs (MethodData.Define): Do not set the `newslot' on
21639 interface members, if they are also flagged as "override".
21641 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
21642 better code for ++i and i++. This only works for static fields
21643 and local variables.
21645 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
21646 want to pull the DeclSpace out of the builder_to_declspace instead
21647 of the TypeBuilder (like in TypeContainer.FindMembers).
21649 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
21650 instead of LookupTypeContainer. Fixes the crash on .NET for
21651 looking up interface members.
21653 * const.cs: Create our own emit context during the Definition
21654 stage, so that constants are evaluated in the proper context, when
21655 a recursive definition happens.
21657 2003-05-11 Martin Baulig <martin@ximian.com>
21659 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
21660 new block for a switch section.
21661 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
21662 the adding/lookup in the switch block. Fixes #39828.
21664 2003-05-09 Miguel de Icaza <miguel@ximian.com>
21666 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
21667 functionality: I needed to convert the data after I had performed
21668 the add/sub operation into the operands type size.
21670 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
21671 pass the type for the box operation, otherwise the resulting
21672 object would have been of type object.
21674 (BoxedCast): Add constructor to specify the type to box as.
21676 2003-05-07 Miguel de Icaza <miguel@ximian.com>
21678 * iterators.cs: I was reusing the `count' variable inadvertently,
21679 take steps to not allow this to happen.
21681 2003-05-06 Miguel de Icaza <miguel@ximian.com>
21683 * attribute.cs (Attribute.Resolve): Params attributes are encoded
21684 by creating an array at the point where the params starts and
21685 putting all those arguments there, then adjusting the size of the
21688 2003-05-05 Miguel de Icaza <miguel@ximian.com>
21690 * expression.cs (New.AddressOf): Implement interface
21691 IMemoryLocation. This is used when the `new' operator is used in
21692 the context of an invocation to a method on a value type.
21694 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
21697 * namespace.cs: Also check the using aliases here.
21699 * driver.cs: Move the test for using validity after the types have
21700 been entered, so we do a single pass that also includes the using
21703 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
21704 in the regular case. CreateSiblingForFinally is doing extra
21707 * attribute.cs (GetAttributeArgumentExpression): Store the result
21708 on an out value, and use the return value to indicate failure
21709 instead of using null (which is a valid return for Constant.GetValue).
21711 * statement.cs: Perform the analysis flow for the increment
21712 portion after the statement, because this will be the real flow of
21713 execution. Fixes #42385
21715 * codegen.cs (EmitContext.EmitArgument,
21716 EmitContext.EmitStoreArgument): New helper functions when the
21717 RemapToProxy flag is set.
21719 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
21722 Add support for remapping parameters.
21724 * iterators.cs: Propagate parameter values; Store parameter
21725 values in the proxy classes.
21727 2003-05-04 Miguel de Icaza <miguel@ximian.com>
21729 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
21730 need a proxy reference; I do not know what I was thinking
21732 * cs-parser.jay (constructor_initializer): catch another error,
21733 and display nice message.
21735 (field_declaration): catch void field declaration
21736 to flag a better error.
21738 * class.cs (MemberBase.CheckBase): Report an error instead of a
21739 warning if a new protected member is declared in a struct.
21740 (Field.Define): catch the error of readonly/volatile.
21742 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
21744 (FieldExpr.AddressOf): ditto. Catch error where the address of a
21745 volatile variable is taken
21747 2003-05-02 Miguel de Icaza <miguel@ximian.com>
21749 * statement.cs (Fixed.Resolve): Report an error if we are not in
21752 2003-05-01 Miguel de Icaza <miguel@ximian.com>
21754 * typemanager.cs: reuse the code that handles type clashes for
21755 delegates and enumerations.
21757 * class.cs (Report28): Always report.
21759 * expression.cs (EncodeAsAttribute): Allow nulls here.
21761 2003-04-28 Miguel de Icaza <miguel@ximian.com>
21763 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
21764 the functionality for testing whether an expression is valid for
21765 an attribute here. Also handle the case of arrays of elements
21768 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
21769 encoding a linear array into an array of objects that are suitable
21770 to be passed to an CustomAttributeBuilder.
21772 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
21774 * ecore.cs: (FieldExpr): Handle field remapping here.
21776 * iteratators.cs: Pass the instance variable (if the method is an
21777 instance method) to the constructors, so we can access the field
21778 variables on the class.
21780 TODO: Test this with structs. I think the THIS variable on
21781 structs might have to be a pointer, and not a refenrece
21783 2003-04-27 Miguel de Icaza <miguel@ximian.com>
21785 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
21786 local variables to fields in a proxy class.
21788 * iterators.cs (PopulateProxy): Rename our internal fields to
21790 Create a <THIS> field if we are an instance method, so we can
21791 reference our parent container variables.
21792 (MapVariable): Called back from the EmitContext code to enter a
21793 new variable to field mapping into the proxy class (we just create
21797 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
21798 for using the remapped locals to fields.
21800 I placed the code here, because that gives the same semantics to
21801 local variables, and only changes the Emit code.
21803 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
21804 statements inside iterators.
21805 (VariableInfo): Add a FieldBuilder for the cases when we are
21806 remapping local variables to fields in a proxy class
21808 * ecore.cs (SimpleNameResolve): Avoid testing two times for
21809 current_block != null.
21811 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
21812 not cope with strings, as it has been moved to the
21813 TableSwitchEmit. Fixed bug in switch generation.
21815 * expression.cs (New.DoResolve): Provide more context for the user
21816 when reporting an error.
21818 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
21821 * expression.cs (MemberAccess.DoResolve): When we get a type back,
21822 check the permissions for it. Note than in a type-resolution
21823 context the check was already present in DeclSpace.ResolveType,
21824 but was missing from the MemberAccess.
21826 (ArrayCreation.CheckIndices): warn if the user has
21827 more nested levels of expressions, but there are no more
21828 dimensions specified. Avoids crash on bug 41906.
21830 2003-04-26 Miguel de Icaza <miguel@ximian.com>
21832 * statement.cs (Block): replace Implicit bool, for a generic
21834 New flag: `Unchecked'. This is used during the EmitMeta phase
21835 (which is out-of-line with the regular Resolve/Emit process for a
21836 statement, as this is done ahead of time, but still gets a chance
21837 to call constant resolve).
21839 (Block.Flags): new enum for adding a new flag.
21841 (Block.EmitMeta): track the state of unchecked.
21843 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
21844 to enable constant resolution to work there as well.
21846 2003-04-22 Miguel de Icaza <miguel@ximian.com>
21848 * typemanager.cs (ienumerable_type): Also look up
21849 System.Collections.IEnumerable.
21851 2003-04-21 Miguel de Icaza <miguel@ximian.com>
21853 TODO: Test more than one conditional per method.
21855 * class.cs (Indexer.Define): Report the location where the user is
21856 referencing the unsupported feature.
21858 (MethodData): Overload the use of `conditionals' to
21859 minimize the creation of needless ArrayLists. This saves roughly
21860 212kb on my machine.
21862 (Method): Implement the new IIteratorContainer interface.
21863 (Method.SetYields): Implement the method by setting the ModFlags
21864 to contain METHOD_YIELDS.
21866 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
21867 which just got set to null.
21869 * iterators.cs: New file.
21871 (Yield, YieldBreak): New statements.
21873 * statement.cs (Return.Resolve): Flag an error if we are used in
21874 an iterator method.
21876 * codegen.cs (InIterator): New flag set if the code is being
21877 compiled in an iterator method.
21879 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
21880 internal modifier, and we just use it to avoid adding extra
21881 fields, as this is seldom used.
21883 * cs-parser.jay: Add yield_statement (yield and yield break).
21885 * driver.cs: New flag -v2 to turn on version 2 features.
21887 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
21888 hashtable when v2 is enabled.
21890 2003-04-20 Miguel de Icaza <miguel@ximian.com>
21892 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
21893 there is already a namespace defined with this name.
21895 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
21896 people upgraded their corlibs.
21898 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
21899 always use fully qualified types, no need to use the compiler
21902 (TypeManager.IsNamespace): Use binarysearch.
21904 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
21905 AddDelegate): I did not quite use the new IsValid API properly: I
21906 have to pass the short-name and the fullname. I was passing only
21907 the basename instead of the fullname sometimes.
21909 (TypeContainer.DefineType): call NamespaceClash.
21911 * interface.cs (Interface.DefineType): use NamespaceClash before
21914 * delegate.cs (Delegate.DefineType): use NamespaceClash before
21917 * enum.cs: (Enum.DefineType): use NamespaceClash before
21920 * typemanager.cs (: 3-line patch that gives us some tasty 11%
21921 speed increase. First, use the negative_hits cache when we get a
21922 negative. Second, add the type with its full original name
21923 instead of the new . and + encoded name (reflection uses + to
21924 separate type from a nested type). Use LookupTypeReflection
21925 directly which bypasses the type->name hashtable (that we already
21926 know does not contain the type.
21928 * decl.cs (DeclSpace.ResolveTypeExpr): track the
21929 location/container type.
21931 * driver.cs: When passing utf8, use directly the UTF8Encoding.
21933 2003-04-19 Miguel de Icaza <miguel@ximian.com>
21935 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
21937 * delegate.cs (NewDelegate.Resolve): Test whether an instance
21938 method is being referenced in the method group from a static
21939 context, and report error 120 if so.
21941 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
21944 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
21945 is created, we create the A namespace).
21947 * cs-parser.jay: A namespace also introduces a DeclarationFound.
21950 2003-04-18 Miguel de Icaza <miguel@ximian.com>
21952 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
21953 invocation to ModuleBuilder.GetType with the same values will
21954 return a new type instance, so we need to cache its return
21957 * expression.cs (Binary.ResolveOperator): Only allow the compare
21958 operators on enums if they are of the same type.
21960 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
21961 types of ValueType on their own case. Before we were giving them
21962 the same treatment as objects.
21964 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
21965 fullname. Short name is used to compare against container name.
21966 Fullname is used to check against defined namespace names.
21968 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
21969 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
21971 (Method.CheckBase): Call parent.
21972 (MemberBase.CheckBase): Check for protected members on sealed
21974 (PropertyBase.CheckBase): Call parent.
21975 (Field.Define): Call parent.
21977 * report.cs: Negative error codes are now mapped to 8000 - code,
21978 so that the display is render more nicely.
21980 * typemanager.cs: Do not use try/catch, instead report a regular
21983 (GetPointerType, GetReferenceType): These methods provide
21984 mechanisms to obtain the T* and T& from a T. We had the code
21985 previously scattered around the code base, and it also used
21986 TypeManager.LookupType that would go through plenty of caches.
21987 This one goes directly to the type source.
21989 In some places we did the Type.GetType followed by
21990 ModuleBuilder.GetType, but not in others, so this unifies the
21991 processing as well.
21993 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
21994 statements now that we have namespace information.
21996 * typemanager.cs (IsNamespace): New method, returns whether the
21997 string presented is a namespace or not.
21999 (ComputeNamespaces): New public entry point, computes the list of
22000 available namespaces, using the GetNamespaces API call in Mono, or
22001 the slower version in MS.NET.
22003 Now before we start the semantic analysis phase, we have a
22004 complete list of namespaces including everything that the user has
22007 Deleted old code to cache namespaces in .nsc files.
22009 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22011 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22012 class/struct location definition Location for the implicit
22013 constructor location.
22015 (Operator.Define): Use the location of the operator for the
22016 implicit Method definition.
22018 (Constructor.Emit): use the constructor location for the implicit
22019 base initializer constructor.
22021 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22022 and the Expression class now contains two new methods:
22024 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22025 isolate type lookup from the rest of the resolution process.
22027 Since we use Expressions to hold type definitions due to the way
22028 we parse the input we have historically overloaded Resolve to
22029 perform the Type lookups if a special flag is passed. Now this is
22030 eliminated and two methods take their place.
22032 The differences in the two methods between xStep and xTerminal is
22033 that xStep is involved in our current lookup system that uses
22034 SimpleNames to compose a name, while xTerminal is used just to
22035 catch the case where the simplename lookup failed.
22037 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22039 * expression.cs (ResolveMemberAccess): Remove redundant code.
22040 TypeExpr expressions are always born fully resolved.
22042 * interface.cs (PopulateMethod): Do not lookup the types twice.
22043 We were doing it once during SemanticAnalysis and once during
22046 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22047 in local variable type definitions, were being returned as a
22048 SimpleName (we decomposed everything into a string), that is
22049 because primary_expression was being used instead of a type in the
22050 grammar (reduce/reduce conflicts).
22052 The part that was wrong is that we converted the expression into a
22053 string (an oversimplification in one hand, compounded with primary
22054 expressions doing string concatenation).
22060 Would return "A.B.C[]" as a SimpleName. This stopped things like
22061 using clauses from working on this particular context. And a type
22062 was being matched directly against "A.B.C[]".
22064 We now use the correct approach, and allow for ComposedCast to be
22065 part of the unary expression. So the "A.B.C []" become a composed
22066 cast of "A.B.C" (as a nested group of MemberAccess with a
22067 SimpleName at the end) plus the rank composition "[]".
22071 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22073 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22074 for the access level checking.
22076 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22077 `TypeContainer container', because I kept getting confused when I
22078 was debugging this code.
22080 * expression.cs (Indexers): Instead of tracking getters/setters,
22081 we now track them in parallel. We create one arraylist less, but
22082 most importantly it is possible now for the LValue code to find a
22083 matching get for a set.
22085 (IndexerAccess.DoResolveLValue): Update the code.
22086 GetIndexersForType has been modified already to extract all the
22087 indexers from a type. The code assumed it did not.
22089 Also make the code set the correct return type for the indexer.
22090 This was fixed a long time ago for properties, but was missing for
22091 indexers. It used to be void_type.
22093 (Binary.Emit): Test first for doubles instead of
22094 floats, as they are more common.
22096 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22097 when dealing with floats and the <=, >= operators. This fixes bug
22100 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22101 to load the array value by emitting a load on the foreach variable
22102 type. This was incorrect.
22104 We now emit the code to load an element using the the array
22105 variable type, and then we emit the conversion operator.
22109 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22111 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22113 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22115 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22116 test for protection before we test for signatures.
22118 (MethodSignature.ToString): implement.
22120 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22121 to the case where we reduced into a LongConstant.
22123 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22124 depend on whether the information is acurrate, because the
22125 Microsoft runtime will always claim that the array type is public,
22126 regardless of the real state.
22128 If the type is a pointer, another problem happens: the type is
22129 reported as non-public in Microsoft.
22131 In both cases we have to call CheckAccessLevel recursively with
22132 the underlying type as the argument to be tested.
22134 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22136 * assign.cs (Assign.Emit): If we are dealing with a compound
22137 assignment expression, we should use the code path that stores the
22138 intermediate result in a temporary value. This fixes #40903.
22140 *expression.cs (Indirection.ToString): Provide ToString method for
22143 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22145 * class.cs: Null out fields holding references to Block objects so
22146 they can be garbage collected.
22148 * expression.cs (OverloadResolve): Remove unused local.
22150 2003-04-07 Martin Baulig <martin@ximian.com>
22152 * codegen.cs (EmitContext.CurrentFile): New public field.
22153 (EmitContext.Mark): Use the CurrentFile to check whether the
22154 location is in the correct file.
22155 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22157 2003-04-07 Martin Baulig <martin@ximian.com>
22159 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22161 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22162 location. [FIXME: The location argument which gets passed to this
22163 method is sometimes wrong!]
22165 2003-04-07 Nick Drochak <ndrochak@gol.com>
22167 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22169 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22171 * expression.cs (Indirection.EmitAssign): We were using the
22172 temporary, but returning immediately instead of continuing the
22175 2003-04-06 Martin Baulig <martin@ximian.com>
22177 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22178 if it's a nested child, but also deriving from the outer class.
22181 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22182 nested child, but also deriving from the outer class. See
22184 (FilterWithClosure): We may access private members of the outer
22185 class if we're a nested child and deriving from the outer class.
22186 (RealMemberLookup): Only set `closure_private_ok' if the
22187 `original_bf' contained BindingFlags.NonPublic.
22189 2003-04-05 Martin Baulig <martin@ximian.com>
22191 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22193 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22195 * class.cs (Event.Define): Do not allow abstract events to have
22198 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22200 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22201 block in event declarations.
22203 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22204 value type, get its address.
22206 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22207 leaving a class on the stack instead of a boolean value (int
22208 0/1). Change the code so we compare against null, and then the
22209 result against zero.
22211 * class.cs (TypeContainer.GetClassBases): We were checking for the
22212 parent class being sealed too late.
22214 * expression.cs (Binary.Emit): For <= and >= when dealing with
22215 floating point values, use cgt.un and clt.un instead of cgt and
22218 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22220 * statement.cs: Apply the same optimization as MS: skip the
22221 GetEnumerator returning an IEnumerator, and use the one returning a
22222 CharEnumerator instead. This allows us to avoid the try-finally block
22225 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22227 * cs-parser.jay: Attributes cannot be applied to
22228 namespaces. Fixes #40473
22230 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22233 (Add*): check if the name is valid using the full name for constants,
22234 fields, properties and events.
22236 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22238 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22239 char constants to be part of the enumeration.
22241 * expression.cs (Conditional.DoResolve): Add support for operator
22242 true. Implements the missing functionality from 14.12
22244 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22245 operator true/false as required by the spec.
22247 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22248 implicit conversion to boolean.
22250 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22251 also one where the type implements `operator true'.
22253 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22254 get an expression that will invoke operator true based on an
22257 (GetConversionOperators): Removed the hack that called op_True
22260 (Expression.ResolveBoolean): Move this from Statement.
22262 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22264 * ecore.cs (FieldExpr): do not allow initialization of initonly
22265 fields on derived classes
22267 2003-03-13 Martin Baulig <martin@ximian.com>
22269 * statement.cs (Block.Emit): Call ig.BeginScope() and
22270 ig.EndScope() when compiling with debugging info; call
22271 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22273 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22275 * expression.cs (Indexers): Do not construct immediately, allow
22276 for new members to be appended as we go. Fixes 38143
22278 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22280 * expression.cs: save/restore context when resolving an unchecked
22283 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22285 * cfold.cs: Catch division by zero in modulus operator during
22288 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22290 * interface.cs (Interface.DefineMembers): Avoid defining members
22293 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22295 * driver.cs: handle the +/- options for -noconfig
22297 * statement.cs (Unckeched.Resolve): Also track the state of
22298 unchecked in the Resolve phase.
22300 2003-02-27 Martin Baulig <martin@ximian.com>
22302 * ecore.cs (Expression.MemberLookup): Don't create a
22303 MethodGroupExpr for something which is not a method. Fixes #38291.
22305 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22307 * class.cs (MemberBase.CheckParameters): Also check that the type
22308 is unmanaged if it is a pointer.
22310 * expression.cs (SizeOf.Resolve): Add location information.
22312 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22313 a managed type is declared.
22315 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22316 parameter modifiers as well. Fixes bug 38606
22318 * class.cs: Very sad. Am backing out the speed up changes
22319 introduced by the ArrayList -> Array in the TypeContainer, as they
22320 were not actually that much faster, and introduced a bug (no error
22321 reports on duplicated methods).
22323 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22324 source first, this will guarantee that we have a valid expression
22325 before calling in lower levels functions that will require a
22326 resolved object. Then use this original_source in the
22327 target.ResolveLValue instead of the original source that was
22330 Another change. Use target.Resolve instead of LValueResolve.
22331 Although we are resolving for LValues, we will let the Assign code
22332 take care of that (it will be called again from Resolve). This
22333 basically allows code like this:
22335 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22336 class Y { void A (X x) { x [0] += o; }
22338 The problem was that the indexer was trying to resolve for
22339 set_Item (idx, object o) and never finding one. The real set_Item
22340 was set_Item (idx, X). By delaying the process we get the right
22345 2003-02-23 Martin Baulig <martin@ximian.com>
22347 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22348 while calling DoEmit ().
22350 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22351 source files; if you use the #line directive inside a method, the
22352 compiler stops emitting line numbers for the debugger until it
22353 reaches the end of the method or another #line directive which
22354 restores the original file.
22356 2003-02-23 Martin Baulig <martin@ximian.com>
22358 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22360 2003-02-23 Martin Baulig <martin@ximian.com>
22362 * statement.cs (Block.AddChildVariableNames): We need to call this
22363 recursively, not just for our immediate children.
22365 2003-02-23 Martin Baulig <martin@ximian.com>
22367 * class.cs (Event.Define): Always make the field private, like csc does.
22369 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22370 actually work, fixes bug #37521.
22372 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22374 * delegate.cs: When creating the various temporary "Parameters"
22375 classes, make sure that we call the ComputeAndDefineParameterTypes
22376 on those new parameters (just like we do with the formal ones), to
22377 allow them to be resolved in the context of the DeclSpace.
22379 This fixes the bug that Dick observed in Bugzilla #38530.
22381 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22383 * expression.cs (ResolveMemberAccess): When resolving a constant,
22384 do not attempt to pull a constant if the value was not able to
22385 generate a valid constant.
22387 * const.cs (LookupConstantValue): Do not report more errors than required.
22389 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22391 * expression.cs: fixes bug #38328.
22393 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22395 * class.cs: Changed all the various members that can be part of a
22396 class from being an ArrayList to be an Array of the right type.
22397 During the DefineType type_list, interface_list, delegate_list and
22398 enum_list are turned into types, interfaces, delegates and enums
22401 And during the member population, indexer_list, event_list,
22402 constant_list, field_list, instance_constructor_list, method_list,
22403 operator_list and property_list are turned into their real arrays.
22405 Although we could probably perform this operation earlier, for
22406 good error reporting we need to keep the lists and remove the
22407 lists for longer than required.
22409 This optimization was triggered by Paolo profiling the compiler
22410 speed on the output of `gen-sample-program.pl' perl script.
22412 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22413 not crash in methods like MemberLookupFailed that use this field.
22415 This problem arises when the compiler fails to resolve a type
22416 during interface type definition for example.
22418 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22420 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22421 inherit from System.Object, so we have to stop at null, not only
22422 when reaching System.Object.
22424 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22426 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22427 DeclaredOnly because the parent indexer might have had a different
22428 name, but did not loop until the top of the hierarchy was reached.
22430 The problem this one fixes is 35492: when a class implemented an
22431 indexer from an interface, we were getting the interface method
22432 (which was abstract) and we were flagging an error (can not invoke
22435 This also keeps bug 33089 functioning, and test-148 functioning.
22437 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22438 out if a method is special is to see if it is declared in a
22439 property or event, or whether it is one of the predefined operator
22440 names. This should fix correctly #36804.
22442 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22444 The goal here is to remove the dependency on EmptyCast.Peel ().
22445 Killing it completely.
22447 The problem is that currently in a number of places where
22448 constants are expected, we have to "probe" for an EmptyCast, and
22449 Peel, which is not the correct thing to do, as this will be
22450 repetitive and will likely lead to errors.
22452 The idea is to remove any EmptyCasts that are used in casts that
22453 can be reduced to constants, so we only have to cope with
22456 This bug hunt was triggered by Bug 37363 and the desire to remove
22457 the duplicate pattern where we were "peeling" emptycasts to check
22458 whether they were constants. Now constants will always be
22461 * ecore.cs: Use an enumconstant here instead of wrapping with
22464 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22465 throwing me off. By handling this we can get rid of a few hacks.
22467 * statement.cs (Switch): Removed Peel() code.
22469 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22471 * class.cs: Location information for error 508
22473 * expression.cs (New.DoResolve): Add a guard against double
22474 resolution of an expression.
22476 The New DoResolve might be called twice when initializing field
22477 expressions (see EmitFieldInitializers, the call to
22478 GetInitializerExpression will perform a resolve on the expression,
22479 and later the assign will trigger another resolution
22481 This leads to bugs (#37014)
22483 * delegate.cs: The signature for EndInvoke should contain any ref
22484 or out parameters as well. We were not doing this in the past.
22486 * class.cs (Field.Define): Do not overwrite the type definition
22487 inside the `volatile' group. Turns out that volatile enumerations
22488 were changing the type here to perform a validity test, which
22491 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22493 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22494 and structs, we do not want to load the instance variable
22496 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22497 enum_type has to be handled like an object reference (implicit
22498 conversions exists from this to object), but the regular IsClass
22499 and IsValueType tests will never return true for this one.
22501 Also we use TypeManager.IsValueType instead of type.IsValueType,
22502 just for consistency with the rest of the code (this is only
22503 needed if we ever use the construct exposed by test-180.cs inside
22504 corlib, which we dont today).
22506 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22508 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22511 2003-02-09 Martin Baulig <martin@ximian.com>
22513 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22514 (Namespace.DefineNamespaces): New static public method; this is
22515 called when we're compiling with debugging to add all namespaces
22516 to the symbol file.
22518 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22519 pass it to the Namespace's .ctor.
22521 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22522 and MethodBase arguments; pass the namespace ID to the symwriter;
22523 pass the MethodBase instead of the token to the symwriter.
22524 (SymbolWriter.DefineNamespace): New method to add a namespace to
22527 2003-02-09 Martin Baulig <martin@ximian.com>
22529 * symbolwriter.cs: New file. This is a wrapper around
22530 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22531 methods here in near future.
22533 2003-02-09 Martin Baulig <martin@ximian.com>
22535 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22536 ILGenerator.MarkSequencePoint() which are actually used by the
22539 2003-02-09 Martin Baulig <martin@ximian.com>
22541 * location.cs (SourceFile): New public sealed class. This
22542 contains the name and an index which is used in the location's token.
22543 (Location): Reserve an appropriate number of bits in the token for
22544 the source file instead of walking over that list, this gives us a
22545 really huge performance improvement when compiling with debugging.
22547 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22548 `SourceFile' argument instead of a string.
22549 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22550 but don't parse/tokenize here, we need to generate the list of all
22551 source files before we do that.
22552 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22555 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22556 instead of a string.
22558 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22561 2003-02-09 Martin Baulig <martin@ximian.com>
22563 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22564 filename on `#line default'.
22566 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22568 * statement.cs: don't clear the pinned var when the fixed statement
22569 returns from the method (fixes bug#37752).
22571 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22573 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22576 2003-02-07 Martin Baulig <martin@ximian.com>
22578 * driver.cs: Removed the `--debug-args' command line argument.
22580 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22581 automatically by the AsssemblyBuilder.
22582 (CodeGen.InitializeSymbolWriter): We don't need to call any
22583 initialization function on the symbol writer anymore. This method
22584 doesn't take any arguments.
22586 2003-02-03 Miguel de Icaza <miguel@ximian.com>
22588 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
22589 from referenced assemblies as well.
22591 2003-02-02 Martin Baulig <martin@ximian.com>
22593 * class.cs (MethodData.Emit): Generate debugging info for external methods.
22595 2003-02-02 Martin Baulig <martin@ximian.com>
22597 * class.cs (Constructor.Emit): Open the symbol writer before
22598 emitting the constructor initializer.
22599 (ConstructorInitializer.Emit): Call ec.Mark() to allow
22600 single-stepping through constructor initializers.
22602 2003-01-30 Miguel de Icaza <miguel@ximian.com>
22604 * class.cs: Handle error 549: do not allow virtual methods in
22607 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
22609 * decl.cs: Check access levels when resolving types
22611 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
22613 * statement.cs: Add parameters and locals set in catch blocks that might
22614 return to set vector
22616 2003-01-29 Miguel de Icaza <miguel@ximian.com>
22618 * class.cs (Operator): Set the SpecialName flags for operators.
22620 * expression.cs (Invocation.DoResolve): Only block calls to
22621 accessors and operators on SpecialName methods.
22623 (Cast.TryReduce): Handle conversions from char constants.
22626 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
22628 * statement.cs: small memory and time optimization in FlowBranching.
22630 2003-01-28 Pedro Mart <yoros@wanadoo.es>
22632 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
22633 problem that the last fix but in the other sid (Set).
22635 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
22636 access when there is no indexer in the hierarchy.
22638 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
22640 * class.cs: Combine some if statements.
22642 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22644 * driver.cs: fixed bug #37187.
22646 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
22648 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
22649 any indexer, it's needed to build a list with all the indexers in the
22650 hierarchy (AllGetters), else we have problems. Fixes #35653.
22652 2003-01-23 Miguel de Icaza <miguel@ximian.com>
22654 * class.cs (MethodData.Define): It is wrong for an interface
22655 implementation to be static in both cases: explicit and implicit.
22656 We were only handling this in one case.
22658 Improve the if situation there to not have negations.
22660 * class.cs (Field.Define): Turns out that we do not need to check
22661 the unsafe bit on field definition, only on usage. Remove the test.
22663 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22665 * driver.cs: use assembly.Location instead of Codebase (the latest
22666 patch made mcs fail when using MS assemblies).
22668 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
22670 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
22671 get the path to *corlib.dll.
22673 2003-01-21 Nick Drochak <ndrochak@gol.com>
22677 * typemanager.cs: Remove compiler warnings
22679 2003-01-20 Duncan Mak <duncan@ximian.com>
22681 * AssemblyInfo.cs: Bump the version number to 0.19.
22683 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22685 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
22687 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
22689 * class.cs (Constructor::Emit): Emit debugging info for constructors.
22691 2003-01-17 Miguel de Icaza <miguel@ximian.com>
22693 * cs-parser.jay: Small fix: we were not comparing the constructor
22694 name correctly. Thanks to Zoltan for the initial pointer.
22696 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
22698 * cs-tokenizer.cs: Set file name when specified with #line
22700 2003-01-15 Miguel de Icaza <miguel@ximian.com>
22702 * cs-parser.jay: Only perform the constructor checks here if we
22703 are named like the class; This will help provider a better
22704 error. The constructor path is taken when a type definition is
22705 not found, but most likely the user forgot to add the type, so
22706 report that rather than the constructor error.
22708 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
22710 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
22713 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22715 * cs-parser.jay: Add cleanup call.
22717 2003-01-13 Duncan Mak <duncan@ximian.com>
22719 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
22720 consistent with other methods.
22722 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22724 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
22726 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
22728 * attribute.cs: only set GuidAttr to true when we have a
22731 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22735 * typemanager.cs: fixes to allow mcs compile corlib with the new
22736 Type.IsSubclassOf fix.
22738 2003-01-08 Miguel de Icaza <miguel@ximian.com>
22740 * expression.cs (LocalVariableReference.DoResolve): Classify a
22741 constant as a value, not as a variable. Also, set the type for
22744 * cs-parser.jay (fixed_statement): take a type instead of a
22745 pointer_type, so we can produce a better error message later.
22747 * statement.cs (Fixed.Resolve): Flag types that are not pointers
22750 (For.DoEmit): Make inifinite loops have a
22751 non-conditional branch back.
22753 (Fixed.DoEmit): First populate the pinned variables, then emit the
22754 statement, then clear the variables. Before I was emitting the
22755 code once for each fixed piece.
22758 2003-01-08 Martin Baulig <martin@ximian.com>
22760 * statement.cs (FlowBranching.MergeChild): A break in a
22761 SWITCH_SECTION does not leave a loop. Fixes #36155.
22763 2003-01-08 Martin Baulig <martin@ximian.com>
22765 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
22766 lives in the same number space than `param_map'. Fixes #36154.
22768 2003-01-07 Miguel de Icaza <miguel@ximian.com>
22770 * cs-parser.jay (constructor_declaration): Set the
22771 Constructor.ModFlags before probing for it. This makes the
22772 compiler report 514, 515 and 132 (the code was there, but got
22775 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
22776 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
22777 (GotoCase.Resolve): Set `Returns' to ALWAYS.
22779 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
22781 * enum.cs: create the enum static fields using the enum type.
22783 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
22785 * class.cs: don't try to create the ParamBuilder for the return
22786 type if it's not needed (and handle it breaking for the ms runtime
22789 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
22791 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
22793 2002-12-29 Miguel de Icaza <miguel@ximian.com>
22795 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
22796 the command. This showed up while compiling the JANET source
22797 code, which used \r as its only newline separator.
22799 2002-12-28 Miguel de Icaza <miguel@ximian.com>
22801 * class.cs (Method.Define): If we are an operator (because it
22802 reuses our code), then set the SpecialName and HideBySig. #36128
22804 2002-12-22 Miguel de Icaza <miguel@ximian.com>
22806 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
22807 exception, report error 120 `object reference required'.
22809 * driver.cs: Add --pause option, used during to measure the size
22810 of the process as it goes with --timestamp.
22812 * expression.cs (Invocation.DoResolve): Do not allow methods with
22813 SpecialName to be invoked.
22815 2002-12-21 Miguel de Icaza <miguel@ximian.com>
22817 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
22818 number before adding it.
22820 2002-12-21 Ravi Pratap <ravi@ximian.com>
22822 * ecore.cs (StandardImplicitConversion): When in an unsafe
22823 context, we allow conversion between void * to any other pointer
22824 type. This fixes bug #35973.
22826 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
22828 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
22829 is not thrown when extensionless outputs are used
22831 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22833 * rootcontext.cs: fixed compilation of corlib.
22835 2002-12-19 Miguel de Icaza <miguel@ximian.com>
22837 * attribute.cs (Attributes.Contains): Add new method.
22839 * class.cs (MethodCore.LabelParameters): if the parameter is an
22840 `out' parameter, check that no attribute `[In]' has been passed.
22842 * enum.cs: Handle the `value__' name in an enumeration.
22844 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
22846 * decl.cs: Added special case to allow overrides on "protected
22849 2002-12-18 Ravi Pratap <ravi@ximian.com>
22851 * attribute.cs (Attributes.AddAttributeSection): Rename to this
22852 since it makes much more sense.
22854 (Attributes.ctor): Don't require a Location parameter.
22856 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
22858 * attribute.cs (ApplyAttributes): Remove extra Location parameters
22859 since we already have that information per attribute.
22861 * everywhere : make appropriate changes.
22863 * class.cs (LabelParameters): Write the code which actually
22864 applies attributes to the return type. We can't do this on the MS
22865 .NET runtime so we flag a warning in the case an exception is
22868 2002-12-18 Miguel de Icaza <miguel@ximian.com>
22870 * const.cs: Handle implicit null conversions here too.
22872 2002-12-17 Ravi Pratap <ravi@ximian.com>
22874 * class.cs (MethodCore.LabelParameters): Remove the extra
22875 Type [] parameter since it is completely unnecessary. Instead
22876 pass in the method's attributes so that we can extract
22877 the "return" attribute.
22879 2002-12-17 Miguel de Icaza <miguel@ximian.com>
22881 * cs-parser.jay (parse): Use Report.Error to flag errors instead
22882 of ignoring it and letting the compile continue.
22884 * typemanager.cs (ChangeType): use an extra argument to return an
22885 error condition instead of throwing an exception.
22887 2002-12-15 Miguel de Icaza <miguel@ximian.com>
22889 * expression.cs (Unary.TryReduce): mimic the code for the regular
22890 code path. Perform an implicit cast in the cases where we can
22891 implicitly convert to one of the integral types, and then reduce
22892 based on that constant. This fixes bug #35483.
22894 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22896 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
22898 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22900 * namespace.cs: fixed bug #35489.
22902 2002-12-12 Miguel de Icaza <miguel@ximian.com>
22904 * class.cs: Remove some dead code.
22906 * cs-parser.jay: Estimate the number of methods needed
22907 (RootContext.MethodCount);
22909 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
22910 numbers instead of StringBuilders.
22912 * support.cs (PtrHashtable): Add constructor with initial size;
22913 We can now reduce reallocations of the method table.
22915 2002-12-10 Ravi Pratap <ravi@ximian.com>
22917 * attribute.cs (ApplyAttributes): Keep track of the emitted
22918 attributes on a per-target basis. This fixes bug #35413.
22920 2002-12-10 Miguel de Icaza <miguel@ximian.com>
22922 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
22923 default to the Windows 1252 encoding.
22925 (UnixParseOption): Support version, thanks to Alp for the missing
22928 * AssemblyInfo.cs: Add nice assembly information.
22930 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
22933 * cs-parser.jay: Allow a trailing comma before the close bracked
22934 in the attribute_section production.
22936 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
22937 address of the instance was being taken, I will take this out,
22938 because we take the address of the object immediately here.
22940 2002-12-09 Ravi Pratap <ravi@ximian.com>
22942 * typemanager.cs (AreMultipleAllowed): Take care of the most
22943 obvious case where attribute type is not in the current assembly -
22946 2002-12-08 Miguel de Icaza <miguel@ximian.com>
22948 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
22949 definitions, instead of doing that afterwards.
22951 Also we use a nice little hack, depending on the constructor, we
22952 know if we are a "composed" name or a simple name. Hence, we
22953 avoid the IndexOf test, and we avoid
22955 * codegen.cs: Add code to assist in a bug reporter to track down
22956 the source of a compiler crash.
22958 2002-12-07 Ravi Pratap <ravi@ximian.com>
22960 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
22961 types have been emitted for a given element and flag an error
22962 if something which does not have AllowMultiple set is used more
22965 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
22966 attribute types and their corresponding AllowMultiple properties
22968 (AreMultipleAllowed): Check the property for a given type.
22970 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
22971 property in the case we have a TypeContainer.
22973 (Attributes.AddAttribute): Detect duplicates and just skip on
22974 adding them. This trivial fix catches a pretty gross error in our
22975 attribute emission - global attributes were being emitted twice!
22977 Bugzilla bug #33187 is now fixed.
22979 2002-12-06 Miguel de Icaza <miguel@ximian.com>
22981 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
22982 instead of pp_and).
22984 * expression.cs (Binary.ResolveOperator): I can only use the
22985 Concat (string, string, string) and Concat (string, string,
22986 string, string) if the child is actually a concatenation of
22989 2002-12-04 Miguel de Icaza <miguel@ximian.com>
22991 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
22992 context where we need a 2-character lookahead.
22994 * pending.cs (PendingImplementation): Rework so we can keep track
22995 of interface types all the time, and flag those which were
22996 implemented by parents as optional.
22998 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23000 * expression.cs (Binary.ResolveOperator): Use
23001 String.Concat(string,string,string) or
23002 String.Concat(string,string,string,string) when possible.
23004 * typemanager: More helper methods.
23007 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23009 * pending.cs: remove the bogus return from GetMissingInterfaces()
23010 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23012 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23014 * namespace.cs: avoid duplicated 'using xxx' being added to
23015 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23016 when we get more than one 'using' statement for the same namespace.
23017 Report a CS0105 warning for it.
23019 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23021 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23022 of calling getChar/putback, uses internal knowledge of it.
23024 (xtoken): Reorder tokenizer so most common patterns are checked
23025 first. This reduces the compilation time in another 5% (from 8.11s
23026 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23028 The parsing time is 22% of the compilation in mcs, and from that
23029 64% is spent on the tokenization process.
23031 I tried using a binary search for keywords, but this is slower
23032 than the hashtable. Another option would be to do a couple of
23035 * Not use a StringBuilder, instead use an array of chars,
23036 with a set value. Notice that this way we could catch
23037 the 645 error without having to do it *afterwards*.
23039 * We could write a hand-parser to avoid the hashtable
23040 compares altogether.
23042 The identifier consumption process takes 37% of the tokenization
23043 time. Another 15% is spent on is_number. 56% of the time spent
23044 on is_number is spent on Int64.Parse:
23046 * We could probably choose based on the string length to
23047 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23050 Another 3% is spend on wrapping `xtoken' in the `token' function.
23052 Handle 0xa0 as whitespace (#34752)
23054 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23056 * typemanager.cs (IsCLRType): New routine to tell whether a type
23057 is one of the builtin types.
23059 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23060 typecode in more places instead of doing pointer comparissions.
23061 We could leverage some knowledge about the way the typecodes are
23064 New code to cache namespaces in assemblies, it is currently not
23065 invoked, to be used soon.
23067 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23069 * expression.cs (Binary.ResolveOperator): specially handle
23070 strings, and do not perform user-defined operator overloading for
23073 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23075 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23076 internalcall as it is a pretty simple operation; Avoid whenever
23077 possible to call Char.IsLetter.
23079 (consume_identifier): Cut by half the number of
23080 hashtable calls by merging the is_keyword and GetKeyword behavior.
23082 Do not short-circuit, because if we do, we
23083 report errors (ie, #if false && true would produce an invalid
23087 2002-11-24 Martin Baulig <martin@ximian.com>
23089 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23090 check constant ranges and report a CS0221. Fixes #33186.
23092 2002-11-24 Martin Baulig <martin@ximian.com>
23094 * cs-parser.jay: Make this work for uninitialized variable
23095 declarations in the `for' initializer. Fixes #32416.
23097 2002-11-24 Martin Baulig <martin@ximian.com>
23099 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23100 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23102 2002-11-24 Martin Baulig <martin@ximian.com>
23104 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23105 argument; if true, we also check for user-defined conversions.
23106 This is only needed if both arguments are of a user-defined type.
23107 Fixes #30443, added test-175.cs.
23108 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23110 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23112 2002-11-24 Martin Baulig <martin@ximian.com>
23114 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23115 function to get the store opcode.
23116 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23117 only emit the Ldelema if the store opcode is Stobj. You must run
23118 both test-34 and test-167 to test this. Fixes #34529.
23120 2002-11-23 Martin Baulig <martin@ximian.com>
23122 * ecore.cs (Expression.MemberLookup): Added additional
23123 `qualifier_type' argument which is used when we're being called
23124 from MemberAccess.DoResolve() and null if we're called from a
23126 (Expression.MemberLookupFailed): New method to report errors; this
23127 does the CS1540 check and reports the correct error message.
23129 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23130 argument for the CS1540 check and redone the way how we're dealing
23131 with private members. See the comment in the source code for details.
23132 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23133 `closure_start_type' to `closure_qualifier_type' and check whether
23134 it's not null. It was not this filter being broken, it was just
23135 being called with the wrong arguments.
23137 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23138 and pass it the correct `qualifier_type'; this also does the error
23141 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23143 * expression.cs (Invocation.EmitParams): If the we are dealing
23144 with a non-built-in value type, load its address as well.
23146 (ArrayCreation): Use a a pretty constant instead
23147 of the hardcoded value 2. Use 6 instead of 2 for the number of
23148 static initializers.
23150 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23151 because they are not really value types, just glorified integers.
23153 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23155 * ecore.cs: Remove redundant code for enumerations, make them use
23156 the same code path as everything else, fixes the casting issue
23157 with enumerations in Windows.Forms.
23159 * attribute.cs: Do only cast to string if it is a string, the
23160 validation happens later.
23162 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23163 people upgrade their corlibs.
23165 * ecore.cs: Oops, enumerations were not following the entire code path
23167 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23169 * typemanager.cs (FilterWithClosure): Commented out the test for
23170 1540 in typemanager.cs, as it has problems when accessing
23171 protected methods from a parent class (see test-174.cs).
23173 * attribute.cs (Attribute.ValidateGuid): new method.
23174 (Attribute.Resolve): Use above.
23176 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23178 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23180 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23181 handling for enumerations, as we only needed the TypeContainer
23182 functionality to begin with (this is required for the fix below to
23183 work for enums that reference constants in a container class for
23186 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23188 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23189 a valid TypeBuilder to perform lookups on.o
23191 * class.cs (InheritableMemberSignatureCompare): Use true in the
23192 call to GetGetMethod and GetSetMethod, because we are comparing
23193 the signature, and we need to get the methods *even* if they are
23196 (PropertyBase.CheckBase): ditto.
23198 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23199 GotoCase.Resolve): Use Peel on EmpytCasts.
23201 * ecore.cs (EmptyCast): drop child, add Peel method.
23203 2002-11-17 Martin Baulig <martin@ximian.com>
23205 * ecore.cs (EmptyCast.Child): New public property.
23207 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23208 label resolved to an EmptyCast. Fixes #34162.
23209 (GotoCase.Resolve): Likewise.
23210 (Block.EmitMeta): Likewise.
23212 2002-11-17 Martin Baulig <martin@ximian.com>
23214 * expression.cs (Invocation.BetterConversion): Prefer int over
23215 uint; short over ushort; long over ulong for integer literals.
23216 Use ImplicitConversionExists instead of StandardConversionExists
23217 since we also need to check for user-defined implicit conversions.
23218 Fixes #34165. Added test-173.cs.
23220 2002-11-16 Martin Baulig <martin@ximian.com>
23222 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23223 with the `true' and `false' literals. Fixes #33151.
23225 2002-11-16 Martin Baulig <martin@ximian.com>
23227 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23228 October 22nd; don't do the cs1540 check for static members.
23230 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23231 now using our own filter here and doing the cs1540 check again.
23233 2002-11-16 Martin Baulig <martin@ximian.com>
23235 * support.cs (InternalParameters): Don't crash if we don't have
23236 any fixed parameters. Fixes #33532.
23238 2002-11-16 Martin Baulig <martin@ximian.com>
23240 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23241 when looking up static methods to make this work on Windows.
23244 2002-11-16 Martin Baulig <martin@ximian.com>
23246 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23247 a setter rather than using PropertyInfo.CanWrite.
23249 2002-11-15 Nick Drochak <ndrochak@gol.com>
23251 * class.cs: Allow acces to block member by subclasses. Fixes build
23254 2002-11-14 Martin Baulig <martin@ximian.com>
23256 * class.cs (Constructor.Emit): Added the extern/block check.
23259 2002-11-14 Martin Baulig <martin@ximian.com>
23261 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23262 iteration while looking for indexers, this is needed because the
23263 indexer may have a different name in our base classes. Fixed the
23264 error reporting (no indexers at all, not get accessor, no
23265 overloaded match). Fixes bug #33089.
23266 (IndexerAccess.DoResolveLValue): Likewise.
23268 2002-11-14 Martin Baulig <martin@ximian.com>
23270 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23271 indexers. Fixes the first part of bug #33089.
23272 (MethodSignature.InheritableMemberSignatureCompare): Added support
23275 2002-11-13 Ravi Pratap <ravi@ximian.com>
23277 * attribute.cs (Attribute.Resolve): Catch the
23278 NullReferenceException and report it since it isn't supposed to
23281 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23283 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23284 LogicalOr and LogicalAnd that can benefit from recursively
23285 handling EmitBranchable. The code now should be nice for Paolo.
23287 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23289 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23290 the Type lookups, as we perform quite a number of lookups on
23291 non-Types. This can be removed once we can deterministically tell
23292 whether we have a type or a namespace in advance.
23294 But this might require special hacks from our corlib.
23298 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23299 and double which avoids a conversion from an integer to a double.
23301 * expression.cs: tiny optimization, avoid calling IsConstant,
23302 because it effectively performs the lookup twice.
23304 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23306 But a bogus return here to keep the semantics of the old code
23307 until the Mono runtime is fixed.
23309 * pending.cs (GetMissingInterfaces): New method used to remove all
23310 the interfaces that are already implemented by our parent
23311 classes from the list of pending methods.
23313 * interface.cs: Add checks for calls after ResolveTypeExpr.
23315 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23317 * class.cs (Class.Emit): Report warning 67: event not used if the
23318 warning level is beyond 3.
23320 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23321 being a NullLiteral.
23323 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23326 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23327 path that might fail if a type can not be resolved.
23329 * expression.cs (Binary.Emit): Emit unsigned versions of the
23332 * driver.cs: use error 5.
23334 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23336 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23338 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23340 * cs-parser.jay (switch_section): A beautiful patch from Martin
23341 Baulig that fixed 33094.
23343 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23345 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23346 Check whether the base is abstract and report an error if so.
23348 * expression.cs (IndexerAccess.DoResolveLValue,
23349 IndexerAccess.DoResolve): ditto.
23351 (Invocation.DoResolve): ditto.
23353 (Invocation.FullMethodDesc): Improve the report string.
23355 * statement.cs (Block): Eliminate IsVariableDefined as it is
23356 basically just a wrapper for GetVariableInfo.
23358 * ecore.cs (SimpleName): Use new
23360 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23361 type, as we return the actual parameter ref/unref state on a
23364 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23366 * support.cs: Return proper flags REF/OUT fixing the previous
23369 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23370 not used to mean `ref' but `ref or out' in ParameterReference
23372 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23373 full type signature instead of calling TypeManger.CSharpName
23376 * support.cs (InternalParameters.ParameterDesc): Do not compare
23377 directly to the modflags, because REF/OUT will actually be bitsets
23380 * delegate.cs (VerifyMethod): Check also the modifiers.
23382 * cs-tokenizer.cs: Fix bug where floating point values with an
23383 exponent where a sign was missing was ignored.
23385 * driver.cs: Allow multiple assemblies to be specified in a single
23388 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23390 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23391 because identifiers after a parenthesis would end up in this kind
23392 of production, and we needed to desamiguate it for having casts
23395 (UserDefinedType *) xxx
23397 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23399 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23400 we should set on the Bindingflags.NonPublic, but not turn on
23401 private_ok. private_ok controls whether a Private member is
23402 returned (this is chekced on the filter routine), while the
23403 BindingFlags.NonPublic just controls whether private/protected
23404 will be allowed. This fixes the problem part of the problem of
23405 private properties being allowed to be used in derived classes.
23407 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23408 so we can call the children DoResolveLValue method (this will
23409 properly signal errors on lvalue assignments to base properties)
23411 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23412 getter are null, and we have a property info, we know that this
23413 happened because the lookup failed, so we report an error 122 for
23414 protection level violation.
23416 We also silently return if setter and getter are null in the
23417 resolve functions, this condition only happens if we have flagged
23418 the error before. This is the other half of the problem.
23420 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23421 not have accessibility information, that is why we were returning
23422 true in the filter function in typemanager.cs.
23424 To properly report 122 (property is inaccessible because of its
23425 protection level) correctly, we report this error in ResolveAccess
23426 by failing if both the setter and the getter are lacking (ie, the
23429 DoResolve and DoLResolve have been modified to check for both
23430 setter/getter being null and returning silently, the reason being
23431 that I did not want to put the knowledge about this error in upper
23434 int old = Report.Errors;
23435 x = new PropertyExpr (...);
23436 if (old != Report.Errors)
23441 So the property expr is returned, but it is invalid, so the error
23442 will be flagged during the resolve process.
23444 * class.cs: Remove InheritablePropertySignatureCompare from the
23445 class, as we no longer depend on the property signature to compute
23446 whether it is possible to implement a method or not.
23448 The reason is that calling PropertyInfo.GetGetMethod will return
23449 null (in .NET, in Mono it works, and we should change this), in
23450 cases where the Get Method does not exist in that particular
23455 class X { public virtual int A { get { return 1; } } }
23457 class Z : Y { public override int A { get { return 2; } } }
23459 Would fail in Z because the parent (Y) would not have the property
23460 defined. So we avoid this completely now (because the alternative
23461 fix was ugly and slow), and we now depend exclusively on the
23464 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23465 reference method, instead of using the property.
23467 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23468 routines are gone now.
23470 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23471 names, they were incorrectly named.
23473 * cs-tokenizer.cs: Return are more gentle token on failure.
23475 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23476 had an out-of-sync index variable, which caused it to remove from
23477 the list of pending methods the wrong method sometimes.
23479 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23481 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23482 CanWrite, because those refer to this particular instance of the
23483 property, and do not take into account the fact that we can
23484 override single members of a property.
23486 Constructor requires an EmitContext. The resolution process does
23487 not happen here, but we need to compute the accessors before,
23488 because the resolution does not always happen for properties.
23490 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23491 subclass, before we did not update this flag, but we did update
23494 (GetAccessors): Drop this routine, as it did not work in the
23495 presence of partially overwritten set/get methods.
23497 Notice that this broke the cs1540 detection, but that will require
23500 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23504 * driver.cs: issue a warning instead of an error if we don't support
23505 debugging for the platform. Also ignore a couple of errors that may
23506 arise when trying to write the symbols. Undo my previous patch.
23508 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23510 * driver.cs: ignore /debug switch except for Unix platforms.
23512 2002-10-23 Nick Drochak <ndrochak@gol.com>
23514 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23516 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23518 * driver.cs: Do not make mcs-debug conditional, so we do not break
23519 builds that use it.
23521 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23522 review this patch. But basically after all the children variables
23523 have been merged, the value of "Breaks" was not being set to
23524 new_breaks for Switch blocks. I think that it should be set after
23525 it has executed. Currently I set this to the value of new_breaks,
23526 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23527 conservative, but I do not understand this code very well.
23529 I did not break anything in the build, so that is good ;-)
23531 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23533 2002-10-20 Mark Crichton <crichton@gimp.org>
23535 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23537 2002-10-20 Nick Drochak <ndrochak@gol.com>
23539 * cfold.cs: Fixed compile blocker.
23541 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23543 * driver.cs: I was chekcing the key, not the file.
23545 2002-10-19 Ravi Pratap <ravi@ximian.com>
23547 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23548 message that we were generating - we just need to silently return
23551 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23553 * class.cs (Event.Define): Change my previous commit, as this
23554 breaks the debugger. This is a temporary hack, as it seems like
23555 the compiler is generating events incorrectly to begin with.
23557 * expression.cs (Binary.ResolveOperator): Added support for
23558 "U operator - (E x, E y)"
23560 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23563 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23564 init-only variables, but this path did not take into account that
23565 there might be also instance readonly variables. Correct this
23568 This fixes bug 32253
23570 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23573 * driver.cs: Change the extension for modules to `netmodule'
23575 * cs-parser.jay: Improved slightly the location tracking for
23576 the debugger symbols.
23578 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23579 modifiers that were specified instead of the hardcoded value
23580 (FamAndAssem). This was basically ignoring the static modifier,
23581 and others. Fixes 32429.
23583 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23584 fixed a bug in the process (32476)
23586 * expression.cs (ArrayAccess.EmitAssign): Patch from
23587 hwang_rob@yahoo.ca that fixes bug 31834.3
23589 2002-10-18 Miguel de Icaza <miguel@ximian.com>
23591 * driver.cs: Make the module extension .netmodule.
23593 2002-10-16 Miguel de Icaza <miguel@ximian.com>
23595 * driver.cs: Report an error if the resource file is not found
23596 instead of crashing.
23598 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
23599 false, like Emit does.
23601 2002-10-16 Nick Drochak <ndrochak@gol.com>
23603 * typemanager.cs: Remove unused private member. Also reported mcs
23604 bug to report this as a warning like csc.
23606 2002-10-15 Martin Baulig <martin@gnome.org>
23608 * statement.cs (Statement.Emit): Made this a virtual method; emits
23609 the line number info and calls DoEmit().
23610 (Statement.DoEmit): New protected abstract method, formerly knows
23611 as Statement.Emit().
23613 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
23615 2002-10-11 Miguel de Icaza <miguel@ximian.com>
23617 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
23618 have fixed a remaining problem: not every AddXXXX was adding a
23619 fully qualified name.
23621 Now everyone registers a fully qualified name in the DeclSpace as
23622 being defined instead of the partial name.
23624 Downsides: we are slower than we need to be due to the excess
23625 copies and the names being registered this way.
23627 The reason for this is that we currently depend (on the corlib
23628 bootstrap for instance) that types are fully qualified, because
23629 we dump all the types in the namespace, and we should really have
23630 types inserted into the proper namespace, so we can only store the
23631 basenames in the defined_names array.
23633 2002-10-10 Martin Baulig <martin@gnome.org>
23635 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
23636 from bug #31834, see the bug report for a testcase which is
23639 2002-10-10 Martin Baulig <martin@gnome.org>
23641 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
23642 flow analysis code for this.
23644 * statement.cs (Do, While, For): Tell the flow analysis code about
23646 (FlowBranching.UsageVector): Added support for infinite loops.
23647 (Block.Resolve): Moved the dead code elimination here and use flow
23650 2002-10-09 Miguel de Icaza <miguel@ximian.com>
23652 * class.cs (Field.Define): Catch cycles on struct type
23655 * typemanager.cs (IsUnmanagedtype): Do not recursively check
23656 fields if the fields are static. We only need to check instance
23659 * expression.cs (As.DoResolve): Test for reference type.
23661 * statement.cs (Using.ResolveExpression): Use
23662 ConvertImplicitRequired, not ConvertImplicit which reports an
23664 (Using.ResolveLocalVariableDecls): ditto.
23666 * expression.cs (Binary.ResolveOperator): Report errors in a few
23667 places where we had to.
23669 * typemanager.cs (IsUnmanagedtype): Finish implementation.
23671 2002-10-08 Miguel de Icaza <miguel@ximian.com>
23673 * expression.cs: Use StoreFromPtr instead of extracting the type
23674 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
23676 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
23677 an enumeration value to a System.Enum, but System.Enum is not a
23678 value type, but an class type, so we need to box.
23680 (Expression.ConvertExplicit): One codepath could return
23681 errors but not flag them. Fix this. Fixes #31853
23683 * parameter.cs (Resolve): Do not allow void as a parameter type.
23685 2002-10-06 Martin Baulig <martin@gnome.org>
23687 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
23688 if it's a class type and not a struct. Fixes #31815.
23690 2002-10-06 Martin Baulig <martin@gnome.org>
23692 * statement.cs: Reworked the flow analysis code a bit to make it
23693 usable for dead code elimination.
23695 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23697 * cs-parser.jay: allow empty source files. Fixes bug #31781.
23699 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23701 * expression.cs (ComposedCast.DoResolveType): A quick workaround
23702 to fix the test 165, will investigate deeper.
23704 2002-10-04 Martin Baulig <martin@gnome.org>
23706 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
23707 finally blocks actually work.
23708 (Try.Resolve): We don't need to create a sibling for `finally' if
23709 there is no finally block.
23711 2002-10-04 Martin Baulig <martin@gnome.org>
23713 * class.cs (Constructor.Define): The default accessibility for a
23714 non-default constructor is private, not public.
23716 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23718 * class.cs (Constructor): Make AllowedModifiers public, add
23721 * cs-parser.jay: Perform the modifiers test here, as the
23722 constructor for the Constructor class usually receives a zero
23723 because of the way we create it (first we create, later we
23724 customize, and we were never checking the modifiers).
23726 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
23727 is a version of LookupTypeReflection that includes the type-name
23728 cache. This can be used as a fast path for functions that know
23729 the fully qualified name and are only calling into *.GetType() to
23730 obtain a composed type.
23732 This is also used by TypeManager.LookupType during its type
23735 (LookupType): We now also track the real type name, as sometimes
23736 we can get a quey for the real type name from things like
23737 ComposedCast. This fixes bug 31422.
23739 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
23740 complete type fullname, it does not have to go through the type
23741 resolution system to obtain the composed version of the type (for
23742 obtaining arrays or pointers).
23744 (Conditional.Emit): Use the EmitBoolExpression to
23745 generate nicer code, as requested by Paolo.
23747 (ArrayCreation.CheckIndices): Use the patch from
23748 hwang_rob@yahoo.ca to validate the array initializers.
23750 2002-10-03 Miguel de Icaza <miguel@ximian.com>
23752 * class.cs (ConstructorInitializer.Emit): simplify code by using
23753 Invocation.EmitCall, and at the same time, fix the bugs in calling
23754 parent constructors that took variable arguments.
23756 * ecore.cs (Expression.ConvertNumericExplicit,
23757 Expression.ImplicitNumericConversion): Remove the code that
23758 manually wrapped decimal (InternalTypeConstructor call is now gone
23761 * expression.cs (Cast.TryReduce): Also handle decimal types when
23762 trying to perform a constant fold on the type.
23764 * typemanager.cs (IsUnmanagedtype): Partially implemented.
23766 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
23767 that only turned off an error report, and did nothing else.
23769 2002-10-02 Miguel de Icaza <miguel@ximian.com>
23771 * driver.cs: Handle and ignore /fullpaths
23773 2002-10-01 Miguel de Icaza <miguel@ximian.com>
23775 * expression.cs (Binary.ResolveOperator): Catch the case where
23776 DoNumericPromotions returns true,
23778 (Binary.DoNumericPromotions): Simplify the code, and the tests.
23780 2002-09-27 Miguel de Icaza <miguel@ximian.com>
23782 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
23785 2002-09-26 Miguel de Icaza <miguel@ximian.com>
23787 * ecore.cs (ConvertNumericExplicit): It is not enough that the
23788 conversion exists, but it is also required that the conversion be
23789 performed. This manifested in "(Type64Enum) 2".
23791 * class.cs (TypeManager.AddMethod): The fix is not to change
23792 AddEnum, because that one was using a fully qualified name (every
23793 DeclSpace derivative does), but to change the AddMethod routine
23794 that was using an un-namespaced name. This now correctly reports
23795 the duplicated name.
23797 Revert patch until I can properly fix it. The issue
23798 is that we have a shared Type space across all namespaces
23799 currently, which is wrong.
23801 Options include making the Namespace a DeclSpace, and merge
23802 current_namespace/current_container in the parser.
23804 2002-09-25 Miguel de Icaza <miguel@ximian.com>
23806 * cs-parser.jay: Improve error reporting when we get a different
23807 kind of expression in local_variable_type and
23808 local_variable_pointer_type.
23810 Propagate this to avoid missleading errors being reported.
23812 * ecore.cs (ImplicitReferenceConversion): treat
23813 TypeManager.value_type as a target just like object_type. As
23818 Is valid, and needs to result in the int 1 being boxed before it
23819 is assigned to the value type v.
23821 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
23822 to validate the enumeration name.
23824 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
23825 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
23826 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
23828 * ecore.cs (TryImplicitIntConversion): When doing an
23829 implicit-enumeration-conversion, check if the type is 64-bits and
23830 perform a conversion before passing to EnumConstant.
23832 2002-09-23 Miguel de Icaza <miguel@ximian.com>
23834 * decl.cs (Error_AmbiguousTypeReference); New routine used to
23835 report ambiguous type references. Unlike the MS version, we
23836 report what the ambiguity is. Innovation at work ;-)
23838 (DeclSpace.FindType): Require a location argument to
23839 display when we display an ambiguous error.
23841 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
23843 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
23845 * expression.cs (EmitDynamicInitializers): Apply patch from
23846 hwang_rob@yahoo.ca that fixes the order in which we emit our
23849 2002-09-21 Martin Baulig <martin@gnome.org>
23851 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
23852 delegate takes no arguments.
23854 2002-09-20 Miguel de Icaza <miguel@ximian.com>
23856 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
23859 * expression.cs: Extract the underlying type.
23861 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
23863 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
23865 2002-09-19 Miguel de Icaza <miguel@ximian.com>
23867 * class.cs (TypeContainer.DefineType): We can not use the nice
23868 PackingSize with the size set to 1 DefineType method, because it
23869 will not allow us to define the interfaces that the struct
23872 This completes the fixing of bug 27287
23874 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
23875 means also structs. This fixes part of the problem.
23876 (Expresion.ImplicitReferenceConversionExists): ditto.
23878 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
23879 error if there were no errors reported during the type lookup
23880 process, to avoid duplicates or redundant errors. Without this
23881 you would get an ambiguous errors plus a type not found. We have
23882 beaten the user enough with the first error.
23884 (DeclSparce.FindType): Emit a warning if we have an ambiguous
23887 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
23888 during the resolution process, stop the lookup, this avoids
23889 repeated error reports (same error twice).
23891 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
23893 * typemanager.cs (LookupType): Redo the type lookup code to match
23894 the needs of System.Reflection.
23896 The issue is that System.Reflection requires references to nested
23897 types to begin with a "+" sign instead of a dot. So toplevel
23898 types look like: "NameSpace.TopLevelClass", and nested ones look
23899 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
23902 2002-09-19 Martin Baulig <martin@gnome.org>
23904 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
23905 says that a method always returns or always throws an exception,
23906 don't report the CS0161.
23908 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
23909 set `Returns = new_returns'.
23911 2002-09-19 Martin Baulig <martin@gnome.org>
23913 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
23914 to an enum constant, check for a CS0176.
23916 2002-09-18 Miguel de Icaza <miguel@ximian.com>
23918 * class.cs (TypeContainer.CheckPairedOperators): Now we check
23919 for operators that must be in pairs and report errors.
23921 * ecore.cs (SimpleName.DoResolveType): During the initial type
23922 resolution process, when we define types recursively, we must
23923 check first for types in our current scope before we perform
23924 lookups in the enclosing scopes.
23926 * expression.cs (MakeByteBlob): Handle Decimal blobs.
23928 (Invocation.VerifyArgumentsCompat): Call
23929 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
23930 I thought we were supposed to always call this, but there are a
23931 few places in the code where we dont do it.
23933 2002-09-17 Miguel de Icaza <miguel@ximian.com>
23935 * driver.cs: Add support in -linkres and -resource to specify the
23936 name of the identifier.
23938 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23940 * ecore.cs (StandardConversionExists): Sync with the conversion
23941 code: allow anything-* to void* conversions.
23943 (FindMostSpecificSource): Use an Expression argument
23944 instead of a Type, because we might be handed over a Literal which
23945 gets a few more implicit conversions that plain types do not. So
23946 this information was being lost.
23948 Also, we drop the temporary type-holder expression when not
23951 2002-09-17 Martin Baulig <martin@gnome.org>
23953 * class.cs (PropertyBase.CheckBase): Don't check the base class if
23954 this is an explicit interface implementation.
23956 2002-09-17 Martin Baulig <martin@gnome.org>
23958 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
23959 different `IndexerName' attributes.
23961 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
23962 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
23963 virtual CommonResolve().
23965 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23967 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
23968 and convert that to the UnderlyingType.
23970 * statement.cs (Foreach.Resolve): Indexers are just like variables
23971 or PropertyAccesses.
23973 * cs-tokenizer.cs (consume_string): Track line numbers and columns
23974 inside quoted strings, we were not doing this before.
23976 2002-09-16 Martin Baulig <martin@gnome.org>
23978 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
23979 resolve it. This is needed for the definite assignment check of the
23980 instance expression, fixes bug #29846.
23981 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
23983 2002-09-16 Nick Drochak <ndrochak@gol.com>
23985 * parameter.cs: Fix compile error. Cannot reference static member
23986 from an instance object. Is this an mcs bug?
23988 2002-09-14 Martin Baulig <martin@gnome.org>
23990 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
23991 multiple times. Fixes bug #30295, added test-166.cs.
23993 2002-09-14 Martin Baulig <martin@gnome.org>
23995 * statement.cs (Block.Emit): Don't emit unreachable code.
23996 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
23997 `break' statements.
23998 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24000 2002-09-14 Martin Baulig <martin@gnome.org>
24002 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24005 2002-09-14 Martin Baulig <martin@gnome.org>
24007 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24008 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24009 be false on the ms runtime.
24011 2002-09-13 Martin Baulig <martin@gnome.org>
24013 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24014 the CS0038 error message.
24016 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24018 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24019 constant inside, return it.
24021 2002-09-12 Martin Baulig <martin@gnome.org>
24023 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24024 implicit conversion can be done between enum types.
24026 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24027 check whether an implicit conversion to the current enum's UnderlyingType
24028 exists and report an error if not.
24030 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24031 without debugging support.
24033 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24034 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24036 2002-09-12 Martin Baulig <martin@gnome.org>
24038 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24040 * ecore.cs (IMemberExpr.DeclaringType): New property.
24041 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24042 nonstatic member of an outer type (CS0038).
24044 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24046 * driver.cs: Activate the using-error detector at warning level
24047 4 (at least for MS-compatible APIs).
24049 * namespace.cs (VerifyUsing): Small buglett fix.
24051 * pending.cs (PendingImplementation): pass the container pointer.
24053 * interface.cs (GetMethods): Allow for recursive definition. Long
24054 term, I would like to move every type to support recursive
24055 definitions, not the current ordering mechanism that we have right
24058 The situation is this: Attributes are handled before interfaces,
24059 so we can apply attributes to interfaces. But some attributes
24060 implement interfaces, we will now handle the simple cases
24061 (recursive definitions will just get an error).
24063 * parameter.cs: Only invalidate types at the end if we fail to
24066 2002-09-09 Martin Baulig <martin@gnome.org>
24068 * ecore.cs (PropertyExpr.Emit): Also check for
24069 TypeManager.system_int_array_get_length so this'll also work when
24070 compiling corlib. Fixes #30003.
24072 2002-09-09 Martin Baulig <martin@gnome.org>
24074 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24075 and throw an exception if we can't get the type's size. Fixed #30040,
24078 2002-09-09 Martin Baulig <martin@gnome.org>
24080 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24082 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24083 context. Fixes bug #30027.
24085 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24086 virtual functions. Fixes bug #30043, added test-164.cs.
24088 2002-09-08 Ravi Pratap <ravi@ximian.com>
24090 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24092 2002-09-08 Nick Drochak <ndrochak@gol.com>
24094 * driver.cs: Use an object to get the windows codepage since it's not a
24097 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24099 * statement.cs (For.Emit): for infinite loops (test == null)
24100 return whether there is a break inside, not always "true".
24102 * namespace.cs (UsingEntry): New struct to hold the name of the
24103 using definition, the location where it is defined, and whether it
24104 has been used in a successful type lookup.
24106 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24111 2002-09-06 Ravi Pratap <ravi@ximian.com>
24113 * attribute.cs : Fix incorrect code which relied on catching
24114 a NullReferenceException to detect a null being passed in
24115 where an object was expected.
24117 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24119 * statement.cs (Try): flag the catch variable as assigned
24121 * expression.cs (Cast): Simplified by using ResolveType instead of
24122 manually resolving.
24124 * statement.cs (Catch): Fix bug by using ResolveType.
24126 2002-09-06 Ravi Pratap <ravi@ximian.com>
24128 * expression.cs (BetterConversion): Special case for when we have
24129 a NullLiteral as the argument and we have to choose between string
24130 and object types - we choose string the way csc does.
24132 * attribute.cs (Attribute.Resolve): Catch the
24133 NullReferenceException and report error #182 since the Mono
24134 runtime no more has the bug and having this exception raised means
24135 we tried to select a constructor which takes an object and is
24138 2002-09-05 Ravi Pratap <ravi@ximian.com>
24140 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24141 message (1502, 1503) when we can't locate a method after overload
24142 resolution. This is much more informative and closes the bug
24145 * interface.cs (PopulateMethod): Return if there are no argument
24146 types. Fixes a NullReferenceException bug.
24148 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24149 expressions too. Previously we were checking only in one place for
24150 positional arguments leaving out named arguments.
24152 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24153 type to the enum type is not allowed. Remove code corresponding to
24156 (ConvertNumericExplicit): Allow explicit conversions from
24157 the underlying type to enum type. This precisely follows the spec
24158 and closes a bug filed by Gonzalo.
24160 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24163 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24165 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24167 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24168 it was important that we stored the right value after the
24169 reduction in `converted'.
24171 2002-09-04 Martin Baulig <martin@gnome.org>
24173 * location.cs (Location.SymbolDocument): Use full pathnames for the
24176 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24178 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24179 of the expression resolve mechanism, because that will catch the
24180 SimpleName error failures.
24182 (Conditional): If we can not resolve the
24183 expression, return, do not crash.
24185 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24188 (location): display token name instead of its number.
24190 2002-08-28 Martin Baulig <martin@gnome.org>
24192 * expression.cs (Binary.ResolveOperator): Don't silently return
24193 but return an error if an operator cannot be applied between two
24196 2002-08-28 Martin Baulig <martin@gnome.org>
24198 * class.cs (Constructor.Define): Set the permission attributes
24199 correctly instead of making all constructors public.
24201 2002-08-28 Martin Baulig <martin@gnome.org>
24203 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24204 for private members before reporting a CS0103; if we find anything,
24207 2002-08-28 Martin Baulig <martin@gnome.org>
24209 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24210 to check whether `closure_start_type == closure_invocation_type',
24211 we also need to check whether `m.DeclaringType == closure_invocation_type'
24212 before bypassing the permission checks. We might be accessing
24213 protected/private members from the base class.
24214 (TypeManager.RealMemberLookup): Only set private_ok if private
24215 members were requested via BindingFlags.NonPublic.
24217 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24219 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24220 MethodGroupExpr.IsExplicitImpl if appropriate.
24221 (Invocation.DoResolve): Don't report the CS0120 for explicit
24222 interface implementations.
24224 2002-08-27 Martin Baulig <martin@gnome.org>
24226 * expression.cs (Invocation.DoResolve): If this is a static
24227 method and we don't have an InstanceExpression, we must report
24230 2002-08-25 Martin Baulig <martin@gnome.org>
24232 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24233 `==' between a valuetype and an object.
24235 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24237 * ecore.cs (TypeExpr): Provide a ToString method.
24239 2002-08-24 Martin Baulig <martin@gnome.org>
24241 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24242 now called proggie.dbg and it's a binary file.
24244 2002-08-23 Martin Baulig <martin@gnome.org>
24246 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24248 2002-08-23 Martin Baulig <martin@gnome.org>
24250 * struct.cs (MyStructInfo.ctor): Make this work with empty
24251 structs; it's not allowed to use foreach() on null.
24253 2002-08-23 Martin Baulig <martin@gnome.org>
24255 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24256 writer the full pathname of the generated assembly.
24258 2002-08-23 Martin Baulig <martin@gnome.org>
24260 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24261 A `finally' block never returns or breaks; improved handling of
24264 2002-08-23 Martin Baulig <martin@gnome.org>
24266 * statement.cs (Throw.Resolve): Allow `throw null'.
24268 2002-08-23 Martin Baulig <martin@gnome.org>
24270 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24271 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24272 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24273 MemberLookup would return a wrong event if this is an explicit
24274 interface implementation and the class has an event with the same
24277 2002-08-23 Martin Baulig <martin@gnome.org>
24279 * statement.cs (Block.AddChildVariableNames): New public method.
24280 (Block.AddChildVariableName): Likewise.
24281 (Block.IsVariableNameUsedInChildBlock): Likewise.
24282 (Block.AddVariable): Check whether a variable name has already
24283 been used in a child block.
24285 * cs-parser.jay (declare_local_variables): Mark all variable names
24286 from the current block as being used in a child block in the
24289 2002-08-23 Martin Baulig <martin@gnome.org>
24291 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24292 find the symbol writer.
24294 * driver.cs: csc also allows the arguments to /define being
24295 separated by commas, not only by semicolons.
24297 2002-08-23 Martin Baulig <martin@gnome.org>
24299 * interface.cs (Interface.GetMembers): Added static check for events.
24301 2002-08-15 Martin Baulig <martin@gnome.org>
24303 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24304 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24306 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24307 why the MethodData.EmitDestructor() change was necessary.
24309 2002-08-20 Martin Baulig <martin@gnome.org>
24311 * class.cs (TypeContainer.FindMembers): Added static check for events.
24313 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24315 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24316 use Type.GetEvents(), not Type.FindMembers().
24318 2002-08-20 Martin Baulig <martin@gnome.org>
24320 * decl.cs (MemberCache): Added a special method cache which will
24321 be used for method-only searched. This ensures that a method
24322 search will return a MethodInfo with the correct ReflectedType for
24325 2002-08-20 Martin Baulig <martin@gnome.org>
24327 * decl.cs (DeclSpace.FindMembers): Made this public.
24329 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24331 * delegate.cs: fixed build on windows.
24332 [FIXME: Filed as bug #29150: MCS must report these errors.]
24334 2002-08-19 Ravi Pratap <ravi@ximian.com>
24336 * ecore.cs (StandardConversionExists): Return a false
24337 if we are trying to convert the void type to anything else
24338 since that is not allowed.
24340 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24341 we flag error 70 in the event an event is trying to be accessed
24342 directly from outside the declaring type.
24344 2002-08-20 Martin Baulig <martin@gnome.org>
24346 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24347 MemberCache from typemanager.cs to decl.cs.
24349 2002-08-19 Martin Baulig <martin@gnome.org>
24351 * class.cs (TypeContainer): Implement IMemberContainer.
24352 (TypeContainer.DefineMembers): Create the MemberCache.
24353 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24354 return public members if BindingFlags.Public was given, check
24355 whether members are static.
24357 2002-08-16 Martin Baulig <martin@gnome.org>
24359 * decl.cs (DeclSpace.Define): Splitted this in Define and
24360 DefineMembers. DefineMembers is called first and initializes the
24363 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24364 DefineMembers() on all our DeclSpaces.
24366 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24367 but call DefineMembers() on all nested interfaces. We call their
24368 Define() in our new Define() function.
24370 * interface.cs (Interface): Implement IMemberContainer.
24371 (Interface.Define): Moved all code except the attribute stuf to
24373 (Interface.DefineMembers): Initialize the member cache.
24375 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24376 need this anymore since we can use MemberCache.FindMembers directly.
24378 2002-08-19 Martin Baulig <martin@gnome.org>
24380 * typemanager.cs (MemberCache): When creating the cache for an
24381 interface type, add all inherited members.
24382 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24383 to `out bool used_cache' and documented it.
24384 (TypeManager.MemberLookup): If we already used the cache in the first
24385 iteration, we don't need to do the interfaces check.
24387 2002-08-19 Martin Baulig <martin@gnome.org>
24389 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24390 here from IMemberFinder and don't implement this interface anymore.
24391 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24393 * typemanager.cs (IMemberFinder): This interface is now only used by
24394 classes which actually support the member cache.
24395 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24396 since we only put DeclSpaces into this Hashtable.
24397 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24398 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24400 2002-08-16 Martin Baulig <martin@gnome.org>
24402 * typemanager.cs (ICachingMemberFinder): Removed.
24403 (IMemberFinder.MemberCache): New property.
24404 (TypeManager.FindMembers): Merged this with RealFindMembers().
24405 This function will never be called from TypeManager.MemberLookup()
24406 so we can't use the cache here, just the IMemberFinder.
24407 (TypeManager.MemberLookup_FindMembers): Check whether the
24408 IMemberFinder has a MemberCache and call the cache's FindMembers
24410 (MemberCache): Rewrote larger parts of this yet another time and
24411 cleaned it up a bit.
24413 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24415 * driver.cs (LoadArgs): Support quoting.
24417 (Usage): Show the CSC-like command line arguments.
24419 Improved a few error messages.
24421 2002-08-15 Martin Baulig <martin@gnome.org>
24423 * typemanager.cs (IMemberContainer.Type): New property.
24424 (IMemberContainer.IsInterface): New property.
24426 The following changes are conditional to BROKEN_RUNTIME, which is
24427 defined at the top of the file.
24429 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24430 class'es members, but add all members from TypeHandle.ObjectType
24431 if we're an interface.
24432 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24433 is the current type.
24434 (MemberCache.CacheEntry.Container): Removed this field.
24435 (TypeHandle.GetMembers): Include inherited members.
24437 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24439 * typemanager.cs: fixed compilation and added a comment on a field that
24442 2002-08-15 Martin Baulig <martin@gnome.org>
24444 * class.cs (ConstructorInitializer.Resolve): In the
24445 Expression.MemberLookup call, use the queried_type as
24448 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24449 declared' attribute, it's always true.
24450 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24451 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24452 temporary wrapper for FindMembers which tells MemberLookup whether
24453 members from the base classes are included in the return value.
24454 This will go away soon.
24455 (TypeManager.MemberLookup): Use this temporary hack here; once the
24456 new MemberCache is completed, we don't need to do the DeclaredOnly
24457 looping here anymore since the MemberCache will take care of this.
24458 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24459 (MemberCache): When creating the MemberCache for a class, get
24460 members from the current class and all its base classes.
24461 (MemberCache.CacheEntry.Container): New field. This is a
24462 temporary hack until the Mono runtime is fixed to distinguish
24463 between ReflectedType and DeclaringType. It allows us to use MCS
24464 with both the MS runtime and the unfixed Mono runtime without
24465 problems and without accecting performance.
24466 (MemberCache.SearchMembers): The DeclaredOnly looping from
24467 TypeManager.MemberLookup is now done here.
24469 2002-08-14 Martin Baulig <martin@gnome.org>
24471 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24472 Type.GetFields on dynamic types but get the fields from the
24473 corresponding TypeContainer.
24474 (MyStructInfo.GetStructInfo): Added check for enum types.
24476 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24477 (MemberList.SyncRoot): Implemented.
24478 (TypeManager.FilterWithClosure): No need to check permissions if
24479 closure_start_type == closure_invocation_type, don't crash if
24480 closure_invocation_type is null.
24482 2002-08-13 Martin Baulig <martin@gnome.org>
24484 Rewrote TypeContainer.FindMembers to use a member cache. This
24485 gives us a speed increase of about 35% for the self-hosting MCS
24486 build and of about 15-20% for the class libs (both on GNU/Linux).
24488 * report.cs (Timer): New class to get enhanced profiling. This
24489 whole class is "TIMER" conditional since it remarkably slows down
24492 * class.cs (MemberList): New class. This is an IList wrapper
24493 which we're now using instead of passing MemberInfo[]'s around to
24494 avoid copying this array unnecessarily.
24495 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24496 (ICachingMemberFinder, IMemberContainer): New interface.
24497 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24498 has already been checked, otherwise use it for the name comparision.
24499 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24500 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24501 if possible. Returns a MemberList, not a MemberInfo [].
24502 (TypeHandle): New class, implements IMemberContainer. We create
24503 one instance of this class per type, it contains a MemberCache
24504 which is used to do the member lookups.
24505 (MemberCache): New class. Each instance of this class contains
24506 all members of a type and a name-based hash table.
24507 (MemberCache.FindMembers): This is our new member lookup
24508 function. First, it looks up all members of the requested name in
24509 the hash table. Then, it walks this list and sorts out all
24510 applicable members and returns them.
24512 2002-08-13 Martin Baulig <martin@gnome.org>
24514 In addition to a nice code cleanup, this gives us a performance
24515 increase of about 1.4% on GNU/Linux - not much, but it's already
24516 half a second for the self-hosting MCS compilation.
24518 * typemanager.cs (IMemberFinder): New interface. It is used by
24519 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24520 Enum, Delegate or Interface.
24521 (TypeManager.finder_to_member_finder): New PtrHashtable.
24522 (TypeManager.finder_to_container): Removed.
24523 (TypeManager.finder_to_delegate): Removed.
24524 (TypeManager.finder_to_interface): Removed.
24525 (TypeManager.finder_to_enum): Removed.
24527 * interface.cs (Interface): Implement IMemberFinder.
24529 * delegate.cs (Delegate): Implement IMemberFinder.
24531 * enum.cs (Enum): Implement IMemberFinder.
24533 * class.cs (TypeContainer): Implement IMemberFinder.
24535 2002-08-12 Martin Baulig <martin@gnome.org>
24537 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24539 2002-08-12 Martin Baulig <martin@gnome.org>
24541 * ecore.cs (ITypeExpression): New interface for expressions which
24543 (TypeExpression): Renamed to TypeLookupExpression.
24544 (Expression.DoResolve): If we're doing a types-only lookup, the
24545 expression must implement the ITypeExpression interface and we
24546 call DoResolveType() on it.
24547 (SimpleName): Implement the new ITypeExpression interface.
24548 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24549 hack, the situation that we're only looking up types can't happen
24550 anymore when this method is called. Moved the type lookup code to
24551 DoResolveType() and call it.
24552 (SimpleName.DoResolveType): This ITypeExpression interface method
24553 is now doing the types-only lookup.
24554 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24555 (ResolveFlags): Added MaskExprClass.
24557 * expression.cs (MemberAccess): Implement the ITypeExpression
24559 (MemberAccess.DoResolve): Added support for a types-only lookup
24560 when we're called via ITypeExpression.DoResolveType().
24561 (ComposedCast): Implement the ITypeExpression interface.
24563 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24564 Expression.Resolve() with ResolveFlags.Type instead.
24566 2002-08-12 Martin Baulig <martin@gnome.org>
24568 * interface.cs (Interface.Define): Apply attributes.
24570 * attribute.cs (Attribute.ApplyAttributes): Added support for
24571 interface attributes.
24573 2002-08-11 Martin Baulig <martin@gnome.org>
24575 * statement.cs (Block.Emit): Only check the "this" variable if we
24576 do not always throw an exception.
24578 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24579 whether the property has a set accessor.
24581 2002-08-11 Martin Baulig <martin@gnome.org>
24583 Added control flow analysis support for structs.
24585 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
24586 with control flow analysis turned off.
24587 (IVariable): New interface.
24588 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
24589 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
24590 (FieldExpr.DoResolve): Resolve the instance expression with flow
24591 analysis turned off and do the definite assignment check after the
24592 resolving when we know what the expression will resolve to.
24594 * expression.cs (LocalVariableReference, ParameterReference):
24595 Implement the new IVariable interface, only call the flow analysis
24596 code if ec.DoFlowAnalysis is true.
24597 (This): Added constructor which takes a Block argument. Implement
24598 the new IVariable interface.
24599 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
24600 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
24601 This does the definite assignment checks for struct members.
24603 * class.cs (Constructor.Emit): If this is a non-static `struct'
24604 constructor which doesn't have any initializer, call
24605 Block.AddThisVariable() to tell the flow analysis code that all
24606 struct elements must be initialized before control returns from
24609 * statement.cs (MyStructInfo): New public class.
24610 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
24611 argument to this indexer. If non-zero, check an individual struct
24612 member, not the whole struct.
24613 (FlowBranching.CheckOutParameters): Check struct members.
24614 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
24615 overloaded versions of these methods which take an additional
24616 `int field_idx' argument to check struct members.
24617 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
24618 overloaded versions of these methods which take an additional
24619 `string field_name' argument to check struct member.s
24620 (VariableInfo): Implement the IVariable interface.
24621 (VariableInfo.StructInfo): New public property. Returns the
24622 MyStructInfo instance of the variable if it's a struct or null.
24623 (Block.AddThisVariable): New public method. This is called from
24624 Constructor.Emit() for non-static `struct' constructor which do
24625 not have any initializer. It creates a special variable for the
24626 "this" instance variable which will be checked by the flow
24627 analysis code to ensure that all of the struct's fields are
24628 initialized before control returns from the constructor.
24629 (UsageVector): Added support for struct members. If a
24630 variable/parameter is a struct with N members, we reserve a slot
24631 in the usage vector for each member. A struct is considered fully
24632 initialized if either the struct itself (slot 0) or all its
24633 members are initialized.
24635 2002-08-08 Martin Baulig <martin@gnome.org>
24637 * driver.cs (Driver.MainDriver): Only report an error CS5001
24638 if there were no compilation errors.
24640 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
24641 `UnsafeContext' property to determine whether the parent is in
24642 unsafe context rather than checking the parent's ModFlags:
24643 classes nested in an unsafe class are unsafe as well.
24645 2002-08-08 Martin Baulig <martin@gnome.org>
24647 * statement.cs (UsageVector.MergeChildren): Distinguish between
24648 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
24649 we return. Added test17() and test18() to test-154.cs.
24651 2002-08-08 Martin Baulig <martin@gnome.org>
24653 * typemanager.cs (TypeManager.FilterWithClosure): If we have
24654 Family access, make sure the invoking type isn't a subclass of the
24655 queried type (that'd be a CS1540).
24657 * ecore.cs (Expression.MemberLookup): Added overloaded version of
24658 this method which takes an additional `Type invocation_type'.
24660 * expression.cs (BaseAccess.DoResolve): Use the base type as
24661 invocation and query type.
24662 (MemberAccess.DoResolve): If the lookup failed and we're about to
24663 report a CS0122, try a lookup with the ec.ContainerType - if this
24664 succeeds, we must report a CS1540.
24666 2002-08-08 Martin Baulig <martin@gnome.org>
24668 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
24669 (MethodGroupExpr): Implement the IMemberExpr interface.
24671 * expression (MemberAccess.ResolveMemberAccess): No need to have
24672 any special code for MethodGroupExprs anymore, they're now
24675 2002-08-08 Martin Baulig <martin@gnome.org>
24677 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
24678 Family, FamANDAssem and FamORAssem permissions.
24679 (TypeManager.IsSubclassOrNestedChildOf): New public method.
24681 2002-08-08 Martin Baulig <martin@gnome.org>
24683 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
24684 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
24687 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
24689 * driver.cs: implemented /resource option to embed managed resources.
24691 2002-08-07 Martin Baulig <martin@gnome.org>
24693 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
24694 (FieldBase.HasFieldInitializer): New public property.
24695 (FieldBase.GetInitializerExpression): New public method. Resolves and
24696 returns the field initializer and makes sure it is only resolved once.
24697 (TypeContainer.EmitFieldInitializers): Call
24698 FieldBase.GetInitializerExpression to get the initializer, this ensures
24699 that it isn't resolved multiple times.
24701 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
24702 the resolving process (SimpleName/MemberLookup) that we're currently
24703 emitting a field initializer (which must not access any instance members,
24704 this is an error CS0236).
24706 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
24707 argument, if the `IsFieldInitializer' flag is set, we must report and
24708 error CS0236 and not an error CS0120.
24710 2002-08-07 Martin Baulig <martin@gnome.org>
24712 * ecore.cs (IMemberExpr): New public interface.
24713 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
24714 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
24715 if the expression is an IMemberExpr.
24717 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
24718 to be null, implicitly default to `this' if we're non-static in
24719 this case. Simplified the code a lot by using the new IMemberExpr
24720 interface. Also fixed bug #28176 here.
24722 2002-08-06 Martin Baulig <martin@gnome.org>
24724 * cs-parser.jay (SimpleLookup): Removed. We need to create
24725 ParameterReferences during semantic analysis so that we can do a
24726 type-only search when resolving Cast, TypeOf and SizeOf.
24727 (block): Pass the `current_local_parameters' to the Block's
24730 * class.cs (ConstructorInitializer): Added `Parameters parameters'
24731 argument to the constructor.
24732 (ConstructorInitializer.Resolve): Create a temporary implicit
24733 block with the parameters.
24735 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
24736 references here if we aren't doing a type-only search.
24738 * statement.cs (Block): Added constructor which takes a
24739 `Parameters parameters' argument.
24740 (Block.Parameters): New public property.
24742 * support.cs (InternalParameters.Parameters): Renamed `parameters'
24743 to `Parameters' and made it public readonly.
24745 2002-08-06 Martin Baulig <martin@gnome.org>
24747 * ecore.cs (Expression.Warning): Made this public as well.
24749 * report.cs (Report.Debug): Print the contents of collections.
24751 2002-08-06 Martin Baulig <martin@gnome.org>
24753 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
24754 used to tell Resolve() which kinds of expressions it may return.
24755 (Expression.Resolve): Added overloaded version of this method which
24756 takes a `ResolveFlags flags' argument. This can be used to tell
24757 Resolve() which kinds of expressions it may return. Reports a
24759 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
24760 ResolveFlags.SimpleName.
24761 (Expression.Error118): Added overloaded version of this method which
24762 takes a `ResolveFlags flags' argument. It uses the flags to determine
24763 which kinds of expressions are allowed.
24765 * expression.cs (Argument.ResolveMethodGroup): New public method.
24766 Resolves an argument, but allows a MethodGroup to be returned.
24767 This is used when invoking a delegate.
24769 * TODO: Updated a bit.
24771 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24773 Fixed compilation with csc.
24775 * ecore.cs: Expression.Error made public. Is this correct? Should
24776 Warning be made public too?
24778 * expression.cs: use ea.Location instead of ea.loc.
24779 [FIXME: Filed as bug #28607: MCS must report these errors.]
24781 2002-08-06 Martin Baulig <martin@gnome.org>
24783 * ecore.cs (Expression.loc): Moved the location here instead of
24784 duplicating it in all derived classes.
24785 (Expression.Location): New public property.
24786 (Expression.Error, Expression.Warning): Made them non-static and
24787 removed the location argument.
24788 (Expression.Warning): Added overloaded version which takes an
24789 `int level' argument.
24790 (Expression.Error118): Make this non-static and removed the
24791 expression and location arguments.
24792 (TypeExpr): Added location argument to the constructor.
24794 * expression.cs (StaticCallExpr): Added location argument to
24796 (Indirection, PointerArithmetic): Likewise.
24797 (CheckedExpr, UnCheckedExpr): Likewise.
24798 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
24799 (StringPtr): Likewise.
24802 2002-08-05 Martin Baulig <martin@gnome.org>
24804 * expression.cs (BaseAccess.DoResolve): Actually report errors.
24806 * assign.cs (Assign.DoResolve): Check whether the source
24807 expression is a value or variable.
24809 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
24810 while resolving the corresponding blocks.
24812 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
24813 an error, don't silently return null.
24815 * statement.cs (Block.AddVariable): Do the error reporting here
24816 and distinguish between CS0128 and CS0136.
24817 (Block.DoResolve): Report all unused labels (warning CS0164).
24818 (LabeledStatement): Pass the location to the constructor.
24819 (LabeledStatement.HasBeenReferenced): New property.
24820 (LabeledStatement.Resolve): Set it to true here.
24822 * statement.cs (Return.Emit): Return success even after reporting
24823 a type mismatch error (CS0126 or CS0127), this is what csc does and
24824 it avoids confusing the users with any consecutive errors.
24826 2002-08-05 Martin Baulig <martin@gnome.org>
24828 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
24830 * const.cs (Const.LookupConstantValue): Catch circular definitions.
24832 * expression.cs (MemberAccess.DoResolve): Silently return if an
24833 error has already been reported.
24835 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
24836 error has already been reported.
24838 2002-08-05 Martin Baulig <martin@gnome.org>
24840 * statement.cs (UsageVector): Only initialize the `parameters'
24841 vector if we actually have any "out" parameters.
24843 2002-08-05 Martin Baulig <martin@gnome.org>
24845 * expression.cs (Binary.ResolveOperator): When combining delegates,
24846 they must have the same type.
24848 2002-08-05 Martin Baulig <martin@gnome.org>
24850 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
24851 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
24852 work with the ms runtime and we also don't need it: if we're a
24853 PropertyBuilder and not in the `indexer_arguments' hash, then we
24854 are a property and not an indexer.
24856 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
24857 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
24858 since the latter one doesn't work with the ms runtime.
24860 2002-08-03 Martin Baulig <martin@gnome.org>
24862 Fixed bugs #27998 and #22735.
24864 * class.cs (Method.IsOperator): New public field.
24865 (Method.CheckBase): Report CS0111 if there's already a method
24866 with the same parameters in the current class. Report CS0508 when
24867 attempting to change the return type of an inherited method.
24868 (MethodData.Emit): Report CS0179 if a method doesn't have a body
24869 and it's not marked abstract or extern.
24870 (PropertyBase): New abstract base class for Property and Indexer.
24871 (PropertyBase.CheckBase): Moved here from Property and made it work
24873 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
24874 the same so we can reuse it there.
24875 (Property, Indexer): Derive from PropertyBase.
24876 (MethodSignature.inheritable_property_signature_filter): New delegate
24877 to find properties and indexers.
24879 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
24880 argument and improved error reporting.
24882 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
24883 EmptyReadOnlyParameters and made it a property.
24885 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
24886 version of this method which takes a `PropertyInfo indexer'.
24887 (TypeManager.RegisterIndexer): New method.
24889 * class.cs: Added myself as author of this file :-)
24891 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24893 * class.cs: fixed compilation on windoze.
24895 2002-08-03 Martin Baulig <martin@gnome.org>
24897 * interface.cs (Interface.GetInterfaceBases): Check whether all
24898 base interfaces are at least as accessible than the current one.
24900 * class.cs (TypeContainer.GetClassBases): Check whether base types
24901 are at least as accessible than the current type.
24902 (TypeContainer.AsAccessible): Implemented and made non-static.
24903 (MemberBase.CheckParameters): Report errors if the accessibility
24906 * delegate.cs (Delegate.Delegate): The default visibility is
24907 internal for top-level types and private for nested types.
24908 (Delegate.Define): Report errors if the accessibility checks fail.
24910 * enum.cs (Enum.Enum): The default visibility is internal for
24911 top-level types and private for nested types.
24912 (Enum.DefineType): Compute the correct visibility.
24914 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
24915 function which takes a `bool is_toplevel' instead of a TypeContainer.
24917 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
24920 2002-08-02 Martin Baulig <martin@gnome.org>
24922 * expression.cs (LocalVariableReferenc): Added constructor which
24923 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
24924 (LocalVariableReference.IsReadOnly): New property.
24925 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
24926 variable is readonly, use our own readonly flag to do this; you can
24927 use the new constructor to get a writable reference to a read-only
24930 * cs-parser.jay (foreach_statement, using_statement): Get a writable
24931 reference to the local variable.
24933 2002-08-01 Miguel de Icaza <miguel@ximian.com>
24935 * rootcontext.cs (ResolveCore): Also include System.Exception
24937 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
24938 we reach an EmptyStatement.
24940 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
24943 * expression.cs (Binary.ResolveOperator): Check error result in
24946 use brtrue/brfalse directly and avoid compares to null.
24948 2002-08-02 Martin Baulig <martin@gnome.org>
24950 * class.cs (TypeContainer.Define): Define all nested interfaces here.
24951 Fixes bug #28407, added test-155.cs.
24953 2002-08-01 Martin Baulig <martin@gnome.org>
24955 * class.cs (Event.EmitDefaultMethod): Make this work with static
24956 events. Fixes #28311, added verify-3.cs.
24958 2002-08-01 Martin Baulig <martin@gnome.org>
24960 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
24961 `is_disposable' fields.
24962 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
24963 `hm.is_disposable' if we're using the collection pattern.
24964 (Foreach.EmitCollectionForeach): Use the correct type for the
24965 enumerator's local variable, only emit the try/finally block if
24966 necessary (fixes #27713).
24968 2002-08-01 Martin Baulig <martin@gnome.org>
24970 * ecore.cs (Expression.report118): Renamed to Error118 and made
24973 * statement.cs (Throw.Resolve): Check whether the expression is of
24974 the correct type (CS0118) and whether the type derives from
24975 System.Exception (CS0155).
24976 (Catch.Resolve): New method. Do the type lookup here and check
24977 whether it derives from System.Exception (CS0155).
24978 (Catch.CatchType, Catch.IsGeneral): New public properties.
24980 * typemanager.cs (TypeManager.exception_type): Added.
24982 2002-07-31 Miguel de Icaza <miguel@ximian.com>
24984 * driver.cs: Updated About function.
24986 2002-07-31 Martin Baulig <martin@gnome.org>
24988 Implemented Control Flow Analysis.
24990 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
24991 (EmitContext.CurrentBranching): Added.
24992 (EmitContext.StartFlowBranching): Added.
24993 (EmitContext.EndFlowBranching): Added.
24994 (EmitContext.KillFlowBranching): Added.
24995 (EmitContext.IsVariableAssigned): Added.
24996 (EmitContext.SetVariableAssigned): Added.
24997 (EmitContext.IsParameterAssigned): Added.
24998 (EmitContext.SetParameterAssigned): Added.
24999 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25000 Added control flow analysis stuff here.
25002 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25003 resolve the expression as lvalue.
25004 (LocalVariableReference.DoResolve): Check whether the variable has
25005 already been assigned.
25006 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25007 the parameter as assigned here.
25008 (ParameterReference.DoResolve): Check whether the parameter has already
25010 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25011 expression as lvalue.
25013 * statement.cs (FlowBranching): New class for the flow analysis code.
25014 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25015 (LabeledStatement.IsDefined): New public property.
25016 (LabeledStatement.AddUsageVector): New public method to tell flow
25017 analyis that the label may be reached via a forward jump.
25018 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25020 (VariableInfo.Number): New public field. This is used by flow analysis
25021 to number all locals of a block.
25022 (Block.CountVariables): New public property. This is the number of
25023 local variables in this block (including the locals from all parent
25025 (Block.EmitMeta): Number all the variables.
25027 * statement.cs: Added flow analysis support to all classes.
25029 2002-07-31 Martin Baulig <martin@gnome.org>
25031 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25032 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25033 then use this argument.
25035 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25037 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25038 use this to specify /define options.
25040 2002-07-29 Martin Baulig <martin@gnome.org>
25042 * statement.cs (Fixed): Moved all code that does variable lookups
25043 and resolvings from Emit to Resolve.
25045 * statement.cs (For): Moved all code that does variable lookups
25046 and resolvings from Emit to Resolve.
25048 * statement.cs (Using): Moved all code that does variable lookups
25049 and resolvings from Emit to Resolve.
25051 2002-07-29 Martin Baulig <martin@gnome.org>
25053 * attribute.cs (Attribute.Resolve): Explicitly catch a
25054 System.NullReferenceException when creating the
25055 CustromAttributeBuilder and report a different warning message.
25057 2002-07-29 Martin Baulig <martin@gnome.org>
25059 * support.cs (ParameterData.ParameterName): Added method to
25060 get the name of a parameter.
25062 * typemanager.cs (TypeManager.IsValueType): New public method.
25064 2002-07-29 Martin Baulig <martin@gnome.org>
25066 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25067 is a flag which specifies that it's either ref or out.
25068 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25069 the out parameter to `out Parameter.Modifier mod', also set the
25070 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25072 * support.cs (InternalParameters.ParameterModifier): Distinguish
25073 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25074 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25076 * expression.cs (Argument.GetParameterModifier): Distinguish
25077 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25078 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25080 2002-07-29 Martin Baulig <martin@gnome.org>
25082 * expression.cs (ParameterReference.ParameterReference): Added
25083 `Location loc' argument to the constructor.
25085 * cs-parser.jay: Pass location to ParameterReference.
25087 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25089 * statement.cs (Try): Initialize the location.
25091 * cs-parser.jay: pass location to Try.
25093 * expression.cs (Unary.Reduce): Change the prototype to return
25094 whether a constant fold could be performed or not. The result is
25095 returned in an out parameters. In the case of Indirection and
25096 AddressOf, we want to perform the full tests.
25098 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25100 * statement.cs (Statement.Emit): Flag dead code.
25102 2002-07-27 Andrew Birkett <andy@nobugs.org>
25104 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25106 2002-07-27 Martin Baulig <martin@gnome.org>
25108 * class.cs (MethodData.Define): Put back call to
25109 TypeManager.AddMethod(), accidentally commented this out.
25111 * report.cs (Debug): New public method to print debugging information,
25112 this is `[Conditional ("DEBUG")]'.
25114 2002-07-26 Martin Baulig <martin@gnome.org>
25116 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25117 (switch_statement): Push the current_block to the switch_stack and
25118 pop it again when we're done with the switch.
25119 (switch_section): The new block is a child of the current_block.
25120 Fixes bug #24007, added test-152.cs.
25122 2002-07-27 Martin Baulig <martin@gnome.org>
25124 * expression.cs (Invocation.EmitArguments): When calling a varargs
25125 function with only its fixed arguments, we need to pass an empty
25128 2002-07-27 Martin Baulig <martin@gnome.org>
25130 Mono 0.13 has been released.
25132 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25134 * driver.cs: Rename --resource to --linkres, because that is what
25135 we do currently, we dont support --resource yet.
25137 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25139 2002-07-25 Martin Baulig <martin@gnome.org>
25141 * class.cs (MethodData): New public class. This is a `method builder'
25142 class for a method or one accessor of a Property/Indexer/Event.
25143 (MethodData.GetMethodFlags): Moved here from MemberBase.
25144 (MethodData.ApplyAttributes): Likewise.
25145 (MethodData.ApplyObsoleteAttribute): Likewise.
25146 (MethodData.ApplyConditionalAttribute): Likewise.
25147 (MethodData.ApplyDllImportAttribute): Likewise.
25148 (MethodData.CheckAbstractAndExternal): Likewise.
25149 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25150 (MethodData.Emit): Formerly known as Method.Emit().
25151 (MemberBase): Moved everything which was specific to a single
25152 accessor/method to MethodData.
25153 (Method): Create a new MethodData and call Define() and Emit() on it.
25154 (Property, Indexer, Event): Create a new MethodData objects for each
25155 accessor and call Define() and Emit() on them.
25157 2002-07-25 Martin Baulig <martin@gnome.org>
25159 Made MethodCore derive from MemberBase to reuse the code from there.
25160 MemberBase now also checks for attributes.
25162 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25163 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25165 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25166 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25167 (MemberBase.ApplyAttributes): New virtual method; applies the
25168 attributes to a method or accessor.
25169 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25170 (MemberBase.ApplyConditionalAttribute): Likewise.
25171 (MemberBase.ApplyDllImportAttribute): Likewise.
25172 (MemberBase.CheckAbstractAndExternal): Likewise.
25173 (MethodCore.ParameterTypes): This is now a property instead of a
25174 method, it's initialized from DoDefineParameters().
25175 (MethodCore.ParameterInfo): Removed the set accessor.
25176 (MethodCore.DoDefineParameters): New protected virtual method to
25177 initialize ParameterTypes and ParameterInfo.
25178 (Method.GetReturnType): We can now simply return the MemberType.
25179 (Method.GetMethodFlags): Override the MemberBase version and add
25180 the conditional flags.
25181 (Method.CheckBase): Moved some code from Define() here, call
25182 DoDefineParameters() here.
25183 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25184 here to avoid some larger code duplication.
25185 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25186 ensure that abstract and external accessors don't declare a body.
25188 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25189 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25190 lookup in the attribute's parent classes, so we need to abort as soon
25191 as we found the first match.
25192 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25193 the attribute has no arguments.
25195 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25198 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25200 * cs-parser.jay: reverted previous patch.
25202 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25204 * cs-parser.jay: fixed bug #22119.
25206 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25208 * attribute.cs: fixed compilation. The error was:
25209 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25210 be assigned to before control leaves the current method."
25211 [FIXME: Filed as bug #28186: MCS must report this error.]
25213 2002-07-25 Martin Baulig <martin@gnome.org>
25215 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25216 method to pull the condition name ouf of a Conditional attribute.
25217 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25218 the obsolete message and error flag out of an Obsolete attribute.
25220 * class.cs (Method.GetMethodFlags): New public method to get the
25221 TypeManager.MethodFlags for this method.
25222 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25224 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25225 if we're overriding a virtual function, set the new private variable
25226 `parent_method'; call the new TypeManager.AddMethod().
25228 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25229 the MethodBuilder and the Method in a PtrHashtable.
25230 (TypeManager.builder_to_method): Added for this purpose.
25231 (TypeManager.MethodFlags): Added IsObsoleteError.
25232 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25233 Obsolete and Conditional arguments in MethodBuilders. If we discover
25234 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25235 the message from the attribute.
25237 2002-07-24 Martin Baulig <martin@gnome.org>
25239 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25240 preprocessor directives, ensure that the argument to #define/#undef is
25241 exactly one identifier and that it's actually an identifier.
25243 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25246 2002-07-24 Martin Baulig <martin@gnome.org>
25248 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25249 initialize it to TypeManager.object_type in the constructor.
25250 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25251 of the `hm.get_current' method if we're using the collection pattern.
25252 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25253 for the explicit conversion to make it work when we're using the collection
25254 pattern and the `Current' property has a different return type than `object'.
25257 2002-07-24 Martin Baulig <martin@gnome.org>
25259 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25260 does not match, but don't report any errors. This method is called in
25261 order for all methods in a MethodGroupExpr until a matching method is
25262 found, so we don't want to bail out if the first method doesn't match.
25263 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25264 matches, report the 123. Fixes #28070.
25266 2002-07-24 Martin Baulig <martin@gnome.org>
25268 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25269 TypeManager.TypeToCoreType() to the top of the method so the
25270 following equality checks will work. Fixes #28107.
25272 2002-07-24 Martin Baulig <martin@gnome.org>
25274 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25275 operand is of type uint, and the other operand is of type sbyte,
25276 short or int, the operands are converted to type long." -
25277 Actually do what this comment already told us. Fixes bug #28106,
25280 2002-07-24 Martin Baulig <martin@gnome.org>
25282 * class.cs (MethodBase): New abstract class. This is now a base
25283 class for Property, Indexer and Event to avoid some code duplication
25284 in their Define() and DefineMethods() methods.
25285 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25286 generic methods for Define() and DefineMethods().
25287 (FieldBase): Derive from MemberBase, not MemberCore.
25288 (Property): Derive from MemberBase, not MemberCore.
25289 (Property.DefineMethod): Moved all the code from this method to the
25290 new MethodBase.DefineAccessor(), just call it with appropriate
25292 (Property.Define): Call the new Property.DoDefine(), this does some
25293 sanity checks and we don't need to duplicate the code everywhere.
25294 (Event): Derive from MemberBase, not MemberCore.
25295 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25296 accessors, this will also make them work with interface events.
25297 (Indexer): Derive from MemberBase, not MemberCore.
25298 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25299 (Indexer.Define): Use the new MethodBase functions.
25301 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25302 argument to the constructor.
25303 (Interface.FindMembers): Added support for interface events.
25304 (Interface.PopluateEvent): Implemented.
25306 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25308 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25310 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25311 but this is required to check for a method name being the same as
25312 the containing class.
25316 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25318 * interface.cs: initialize variable.
25320 2002-07-23 Martin Baulig <martin@gnome.org>
25322 Implemented the IndexerName attribute in interfaces.
25324 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25325 name if this is an explicit interface implementation.
25326 (Indexer.InterfaceIndexerName): New public variable. If we're
25327 implementing an interface indexer, this is the IndexerName in that
25328 interface. Otherwise, it's the IndexerName.
25329 (Indexer.DefineMethod): If we're implementing interface indexer,
25330 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25331 and Pending.ImplementIndexer methods.
25332 (Indexer.Define): Also define the PropertyBuilder if we're
25333 implementing an interface indexer and this is neither an explicit
25334 interface implementation nor do the IndexerName match the one in
25337 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25338 If a method is defined here, then we always need to create a proxy
25339 for it. This is used when implementing interface indexers.
25340 (Pending.IsInterfaceIndexer): New public method.
25341 (Pending.ImplementIndexer): New public method.
25342 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25343 This is used when implementing interface indexers to define a proxy
25345 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25346 define a proxy if necessary.
25348 * interface.cs (Interface.IndexerName): New public variable.
25349 (Interface.PopulateIndexer): Set the IndexerName.
25350 (Interface.DefineIndexers): New private method. Populate all the
25351 indexers and make sure their IndexerNames match.
25353 * typemanager.cs (IndexerPropertyName): Added support for interface
25356 2002-07-22 Martin Baulig <martin@gnome.org>
25358 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25359 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25360 ret if HasReturnLabel.
25361 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25364 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25365 and set the ec.LoopBeginTryCatchLevel.
25366 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25367 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25368 the current ec.TryCatchLevel, the branch goes out of an exception
25369 block. In this case, we need to use Leave and not Br.
25371 2002-07-22 Martin Baulig <martin@gnome.org>
25373 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25374 block unless the block does not always return or it is contained in
25375 another try { ... } catch { ... } block. Fixes bug #26506.
25376 Added verify-1.cs to the test suite.
25378 2002-07-22 Martin Baulig <martin@gnome.org>
25380 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25381 then we do not always return. Fixes bug #24985.
25383 2002-07-22 Martin Baulig <martin@gnome.org>
25385 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25386 lookup on a per-class level; ie. walk up the class hierarchy until we
25387 found at least one applicable method, then choose the best among them.
25388 Fixes bug #24463 and test-29.cs.
25390 2002-07-22 Martin Baulig <martin@gnome.org>
25392 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25393 return types of the methods. The return type is not part of the
25394 signature and we must not check it to make the `new' modifier work.
25395 Fixes bug #27999, also added test-147.cs.
25396 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25398 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25399 on the method's return type.
25401 2002-07-21 Martin Baulig <martin@gnome.org>
25403 * assign.cs: Make this work if the rightmost source is a constant and
25404 we need to do an implicit type conversion. Also adding a few more tests
25405 to test-38.cs which should have caught this.
25407 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25408 target in the makefile for this. The makefile.gnu is primarily intended
25409 for end-users who don't want to debug the compiler.
25411 2002-07-21 Martin Baulig <martin@gnome.org>
25413 * assign.cs: Improved the Assign class so it can now handle embedded
25414 assignments (X = Y = Z = something). As a side-effect this'll now also
25415 consume less local variables. test-38.cs now passes with MCS, added
25416 a few new test cases to that test.
25418 2002-07-20 Martin Baulig <martin@gnome.org>
25420 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25421 instructions. Fixes bug #27977, also added test-146.cs.
25423 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25425 * cs-tokenizer.cs: fixed getHex ().
25427 2002-07-19 Martin Baulig <martin@gnome.org>
25429 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25430 not Type.GetType() to lookup the array type. This is needed when
25431 we're constructing an array of a user-defined type.
25432 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25433 single-dimensional arrays, but also for single-dimensial arrays of
25436 2002-07-19 Martin Baulig <martin@gnome.org>
25438 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25439 this function is called, it's not allowed to share LocalBuilders
25440 among ILGenerators.
25442 2002-07-19 Martin Baulig <martin@gnome.org>
25444 * expression.cs (Argument.Resolve): Report an error 118 when trying
25445 to pass a type as argument.
25447 2002-07-18 Martin Baulig <martin@gnome.org>
25449 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25450 Conv_R_Un for the signed `long' type.
25452 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25454 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25455 `expr' for the temporary result, as that will fail if we do
25456 multiple resolves on the same expression.
25458 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25460 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25461 ec.TypeContainer for looking up aliases.
25463 * class.cs (TypeContainer): Remove LookupAlias from here.
25465 * decl.cs (DeclSpace); Move here.
25467 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25469 * class.cs (FindMembers): Only call filter if the constructor
25470 bulider is not null.
25472 Also handle delegates in `NestedTypes' now. Now we will perform
25473 type lookups using the standard resolution process. This also
25476 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25477 This uses Expressions (the limited kind that can be parsed by the
25478 tree) instead of strings.
25480 * expression.cs (ComposedCast.ToString): Implement, used to flag
25481 errors since now we have to render expressions.
25483 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25486 * ecore.cs (SimpleName.ToString): ditto.
25488 * cs-parser.jay: Instead of using strings to assemble types, use
25489 Expressions to assemble the type (using SimpleName, ComposedCast,
25490 MemberAccess). This should fix the type lookups in declarations,
25491 because we were using a different code path for this.
25493 * statement.cs (Block.Resolve): Continue processing statements
25494 even when there is an error.
25496 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25498 * class.cs (Event.Define): Also remove the `remove' method from
25499 the list of pending items.
25501 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25502 generate more compact code.
25504 2002-07-17 Martin Baulig <martin@gnome.org>
25506 * const.cs (Const.LookupConstantValue): Add support for constant
25507 `unchecked' and `checked' expressions.
25508 Also adding test case test-140.cs for this.
25510 2002-07-17 Martin Baulig <martin@gnome.org>
25512 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25513 check whether mi.ReturnType implements the IEnumerator interface; the
25514 `==' and the IsAssignableFrom() will fail in this situation.
25516 2002-07-16 Ravi Pratap <ravi@ximian.com>
25518 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25521 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25523 * expression.cs: fixed bug #27811.
25525 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25527 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25528 Molaro: when we are a ref, the value already contains a pointer
25529 value, do not take the address of it.
25531 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25532 * removed mb-parser.jay and mb-tokenizer.cs
25534 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25536 * expression.cs: check against the building corlib void type.
25538 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25540 * ecore.cs: fix for valuetype static readonly fields: when
25541 initializing them, we need their address, not the address of a copy.
25543 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25545 * typemanager.cs: register also enum_type in corlib.
25547 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25549 * class.cs: allow calling this (but not base) initializers in structs.
25551 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25553 * ecore.cs: make sure we compare against the building base types
25556 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25558 * typemanager.cs: fix TypeToCoreType() to handle void and object
25559 (corlib gets no more typerefs after this change).
25561 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25563 * expression.cs (ArrayCreation.EmitArrayArguments): use
25564 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25566 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25567 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25568 array indexes, the runtime actually forbids them.
25570 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25571 for array arguments here.
25573 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25574 instead of the default for ValueTypes.
25576 (New.DoEmit): Use IsValueType instead of
25577 IsSubclassOf (value_type)
25578 (New.DoResolve): ditto.
25579 (Invocation.EmitCall): ditto.
25581 * assign.cs (Assign): ditto.
25583 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25584 Statements *are* currently doing part of their resolution during
25587 Expressions do always resolve during resolve, but statements are
25588 only required to propagate resolution to their children.
25590 2002-07-11 Miguel de Icaza <miguel@ximian.com>
25592 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
25594 (LoadAssembly): Do not add the dll if it is already specified
25596 (MainDriver): Add the System directory to the link path at the end,
25597 after all the other -L arguments.
25599 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
25600 wrong opcode for loading bytes and bools (ldelem.i1 instead of
25601 ldelem.u1) and using the opposite for sbytes.
25603 This fixes Digger, and we can finally run it.
25605 * driver.cs (UnixParseOption): Move the option parsing here.
25606 (CSCParseOption): Implement CSC-like parsing of options.
25608 We now support both modes of operation, the old Unix way, and the
25609 new CSC-like way. This should help those who wanted to make cross
25610 platform makefiles.
25612 The only thing broken is that /r:, /reference: and /lib: are not
25613 implemented, because I want to make those have the same semantics
25614 as the CSC compiler has, and kill once and for all the confussion
25615 around this. Will be doing this tomorrow.
25617 * statement.cs (Unsafe.Resolve): The state is checked during
25618 resolve, not emit, so we have to set the flags for IsUnsfe here.
25620 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25622 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
25623 not catch the Error_ObjectRefRequired in SimpleName (as it is
25624 possible to have a class/instance variable name that later gets
25625 deambiguated), we have to check this here.
25627 2002-07-10 Ravi Pratap <ravi@ximian.com>
25629 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
25630 make static and put into Expression.
25632 (Event.Define): Register the private field of the event with the
25633 TypeManager so that GetFieldFromEvent can get at it.
25635 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
25636 keep track of the private field associated with an event which
25639 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
25642 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
25644 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25646 * expression.cs (Binary.EmitBranchable): this routine emits the
25647 Binary expression in a branchable context. This basically means:
25648 we need to branch somewhere, not just get the value on the stack.
25650 This works together with Statement.EmitBoolExpression.
25652 * statement.cs (Statement.EmitBoolExpression): Use
25655 2002-07-09 Miguel de Icaza <miguel@ximian.com>
25657 * statement.cs (For): Reduce the number of jumps in loops.
25659 (For): Implement loop inversion for the For statement.
25661 (Break): We can be breaking out of a Try/Catch controlled section
25662 (foreach might have an implicit try/catch clause), so we need to
25663 use Leave instead of Br.
25665 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
25666 now). If the instace expression supports IMemoryLocation, we use
25667 the AddressOf method from the IMemoryLocation to extract the
25668 address instead of emitting the instance.
25670 This showed up with `This', as we were emitting the instance
25671 always (Emit) instead of the Address of This. Particularly
25672 interesting when This is a value type, as we dont want the Emit
25673 effect (which was to load the object).
25675 2002-07-08 Miguel de Icaza <miguel@ximian.com>
25677 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
25679 * statement.cs (Checked): Set the CheckedState during the resolve
25680 process too, as the ConvCast operations track the checked state on
25681 the resolve process, and not emit.
25683 * cs-parser.jay (namespace_member_declaration): Flag that we have
25684 found a declaration when we do. This is used to flag error 1529
25686 * driver.cs: Report ok when we display the help only.
25688 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
25690 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
25692 2002-07-04 Miguel de Icaza <miguel@ximian.com>
25694 * cs-tokenizer.cs (define): We also have to track locally the
25695 defines. AllDefines is just used for the Conditional Attribute,
25696 but we also need the local defines for the current source code.
25698 2002-07-03 Miguel de Icaza <miguel@ximian.com>
25700 * statement.cs (While, For, Do): These loops can exit through a
25701 Break statement, use this information to tell whether the
25702 statement is the last piece of code.
25704 (Break): Flag that we break.
25706 * codegen.cs (EmitContexts): New `Breaks' state variable.
25708 2002-07-03 Martin Baulig <martin@gnome.org>
25710 * class.cs (TypeContainer.MethodModifiersValid): Allow override
25711 modifiers in method declarations in structs. Otherwise, you won't
25712 be able to override things like Object.Equals().
25714 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25716 * class.cs (Method, Property, Indexer): Do not allow the public
25717 modifier to be used in explicit interface implementations.
25719 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
25720 override modifiers in method declarations in structs
25722 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
25724 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
25725 integer or real overflow, report an error
25727 2002-07-02 Martin Baulig <martin@gnome.org>
25729 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
25730 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
25731 to tell the runtime about our newly created System.Object and
25732 System.ValueType types.
25734 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25736 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
25737 struct instead of Ldarg/Starg.
25739 2002-07-02 Martin Baulig <martin@gnome.org>
25741 * expression.cs (Indirection.Indirection): Call
25742 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
25744 2002-07-02 Martin Baulig <martin@gnome.org>
25746 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
25747 ValueType, call TypeManager.TypeToCoreType() on it.
25748 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
25749 the OpCodes.Newarr argument.
25751 2002-07-02 Martin Baulig <martin@gnome.org>
25753 * expression.cs (Invocation.EmitCall): When compiling corlib,
25754 replace all calls to the system's System.Array type to calls to
25755 the newly created one.
25757 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
25758 System.Array methods.
25759 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
25760 from the system's System.Array type which must be replaced.
25762 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
25764 * typemanager.cs: load unverifiable_code_ctor so we can build
25765 corlib using the correct type. Avoid using GetTypeCode() with
25767 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
25768 TypeManager.object_type to allow building corlib.
25770 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
25772 * ecore.cs: handle System.Enum separately in LoadFromPtr().
25774 2002-07-01 Martin Baulig <martin@gnome.org>
25776 * class.cs: Make the last change actually work, we need to check
25777 whether `ifaces != null' to avoid a crash.
25779 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25781 * class.cs: when we build structs without fields that implement
25782 interfaces, we need to add the interfaces separately, since there is
25783 no API to both set the size and add the interfaces at type creation
25786 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25788 * expression.cs: the dimension arguments to the array constructors
25789 need to be converted if they are a long.
25791 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
25793 * class.cs: don't emit ldarg.0 if there is no parent constructor
25794 (fixes showstopper for corlib).
25796 2002-06-29 Martin Baulig <martin@gnome.org>
25798 MCS now compiles corlib on GNU/Linux :-)
25800 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
25801 ie. check for MethodImplOptions.InternalCall.
25803 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
25804 and TypeManager.attribute_type are null, so we must explicitly check
25805 whether parent is not null to find out whether it's an attribute type.
25806 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
25807 and SetBuilder, not only if the property is neither abstract nor external.
25808 This is necessary to set the MethodImplOptions on the accessor methods.
25809 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
25810 SetBuilder, see Property.Emit().
25812 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
25813 populate "System.Object", "System.ValueType" and "System.Attribute" since
25814 they've already been populated from BootCorlib_PopulateCoreTypes().
25816 2002-06-29 Martin Baulig <martin@gnome.org>
25818 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
25819 is the NullLiteral, we also need to make sure that target_type is not
25822 2002-06-29 Martin Baulig <martin@gnome.org>
25824 * rootcontext.cs (RootContext.ResolveCore): We must initialize
25825 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
25826 before calling BootstrapCorlib_ResolveDelegate ().
25828 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25830 * statement.cs: fixed build-breaker. All tests passed ok.
25832 2002-06-27 Martin Baulig <martin@gnome.org>
25834 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
25835 for System.Decimal when compiling corlib.
25837 2002-06-27 Martin Baulig <martin@gnome.org>
25839 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
25840 switch blocks which contain nothing but a default clause.
25842 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
25844 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
25846 2002-06-27 Martin Baulig <martin@gnome.org>
25848 * ecore.cs (PropertyExpr.PropertyExpr): Call
25849 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
25851 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
25852 is already a TypeBuilder.
25854 2002-06-27 Martin Baulig <martin@gnome.org>
25856 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
25857 `target_type == TypeManager.array_type', not IsAssignableFrom() in
25858 the "from an array-type to System.Array" case. This makes it work
25859 when compiling corlib.
25861 2002-06-27 Martin Baulig <martin@gnome.org>
25863 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
25864 non-static PropertyExpr, set its InstanceExpression. This makes
25865 the `ICollection.Count' property work in System/Array.cs.
25867 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
25869 * driver.cs: Made error handling more consistent. Errors now
25870 tracked by Report class, so many methods which used to return int
25871 now return void. Main() now prints success/failure and
25872 errors/warnings message.
25874 Renamed '--probe' compiler argument to '--expect-error'. Removed
25875 the magic number return values (123 and 124). Now, if the
25876 expected error occurs, the compiler exits with success (exit value
25877 0). If the compilation completes without seeing that particular
25878 error, the compiler exits with failure (exit value 1). The
25879 makefile in mcs/errors has been changed to handle the new behaviour.
25881 * report.cs: Made 'expected error' number a property and renamed
25882 it from 'Probe' to 'ExpectedError'.
25884 * genericparser.cs: Removed error handling support, since it is
25885 now all done by Report class.
25887 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
25888 class, so parse() no longer returns an int.
25890 * namespace.cs: Use Report.Error instead of GenericParser.error
25892 2002-06-22 Miguel de Icaza <miguel@ximian.com>
25894 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
25895 TypeContainer.AddOperator): At the front of the list put the
25896 explicit implementations, so they get resolved/defined first.
25898 2002-06-21 Miguel de Icaza <miguel@ximian.com>
25900 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
25901 interface type is implemented by this TypeContainer. Used during
25902 explicit interface implementation.
25904 (Property.Define, Indexer.Define, Method.Define): Validate that
25905 the given interface in the explicit implementation is one of the
25906 base classes for the containing type.
25908 Also if we are explicitly implementing an interface, but there is
25909 no match in the pending implementation table, report an error.
25911 (Property.Define): Only define the property if we are
25912 not explicitly implementing a property from an interface. Use the
25913 correct name also for those properties (the same CSC uses,
25914 although that is really not needed).
25916 (Property.Emit): Do not emit attributes for explicitly implemented
25917 properties, as there is no TypeBuilder.
25919 (Indexer.Emit): ditto.
25921 Hiding then means that we do not really *implement* a pending
25922 implementation, which makes code fail.
25924 2002-06-22 Martin Baulig <martin@gnome.org>
25926 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
25927 the return value of Object.GetType(). [FIXME: we need to do this whenever
25928 we get a type back from the reflection library].
25930 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
25932 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
25934 2002-06-20 Miguel de Icaza <miguel@ximian.com>
25936 * attribute.cs: Return null if we can not look up the type.
25938 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
25939 the interface types found.
25941 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
25942 interface types found.
25944 * typemanager.cs (GetInterfaces): Make this routine returns alll
25945 the interfaces and work around the lame differences between
25946 System.Type and System.Reflection.Emit.TypeBuilder in the results
25947 result for GetInterfaces.
25949 (ExpandInterfaces): Given an array of interface types, expand and
25950 eliminate repeated ocurrences of an interface. This expands in
25951 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
25954 2002-06-21 Martin Baulig <martin@gnome.org>
25956 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
25959 2002-06-21 Martin Baulig <martin@gnome.org>
25961 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
25962 and called with one of the core types, return the corresponding typebuilder for
25965 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
25968 2002-06-21 Martin Baulig <martin@gnome.org>
25970 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
25971 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
25972 (Expression.ConvertReferenceExplicit): Likewise.
25974 * expression.cs (ElementAccess.DoResolve): Likewise.
25975 (ElementAccess.DoResolveLValue): Likewise.
25977 2002-06-10 Martin Baulig <martin@gnome.org>
25979 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
25980 add the "value" parameter to the parameter list.
25982 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
25985 2002-06-19 Miguel de Icaza <miguel@ximian.com>
25987 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
25988 the argument to an int, uint, long or ulong, per the spec. Also
25989 catch negative constants in array creation.
25991 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
25993 * class.cs: do not allow the same interface to appear twice in
25994 the definition list.
25996 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
25998 * ecore.cs: don't use ldlen with System.Array.
26000 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26002 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26004 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26006 * modifiers.cs: produce correct field attributes for protected
26007 internal. Easy fix so miguel can work on ther harder stuff:-)
26009 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26011 * pending.cs: New file. Move the code from class.cs here.
26012 Support clearning the pending flag for all methods (when not doing
26013 explicit interface implementation).
26015 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26017 * rootcontext.cs: added a couple more types needed to bootstrap.
26019 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26021 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26022 constructor in the type, instead of any constructor in the type
26023 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26024 a bug in the Mono runtime when applying the params attribute).
26026 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26027 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26029 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26031 * expression.cs (Unary.ResolveOperator): Use TypeManager
26032 to resolve the type.
26034 2002-06-13 Ravi Pratap <ravi@ximian.com>
26036 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26039 * enum.cs (AddEnumMember): Add support to store the attributes associated
26040 with each member too.
26042 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26043 field builders too - this takes care of the enum member case.
26045 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26047 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26048 address-of operator on both value types and pointers.
26050 2002-06-10 Martin Baulig <martin@gnome.org>
26052 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26053 PropertyBuilder to the `property_builders' list.
26055 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26056 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26057 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26058 find any indexers which are inherited from an interface.
26060 2002-06-09 Martin Baulig <martin@gnome.org>
26062 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26063 the same type as the constant if necessary. There's also a test-130.cs
26066 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26068 * typemanager.cs (TypeManager.ChangeType): Previously known as
26069 Enum.ChangeEnumType().
26071 2002-06-09 Martin Baulig <martin@gnome.org>
26073 * expression.cs (Cast.TryReduce): Added support for consts.
26075 2002-06-08 Ravi Pratap <ravi@ximian.com>
26077 * class.cs (Accessor): Hold attributes information so we can pass
26080 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26081 Modify to pass in attributes attached to the methods.
26083 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26085 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26086 to handle the Accessor kind :-)
26088 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26090 2002-06-08 Martin Baulig <martin@gnome.org>
26092 * expression.cs (Unary.TryReduceNegative): Added support for
26095 2002-06-08 Martin Baulig <martin@gnome.org>
26097 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26098 name can't be found in the `defined_names' - the caller will do a
26099 MemberLookup in this case and thus find methods in System.Enum
26100 such as Enum.IsDefined().
26102 2002-06-08 Martin Baulig <martin@gnome.org>
26104 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26105 Convert.ChangeType() which works with TypeBuilder created types.
26106 (Enum.LookupEnumValue, Enum.Define): Use it here.
26108 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26109 `TypeBuilder.BaseType != null' check.
26110 (TypeContainer.FindMembers): Only lookup parent members if we
26111 actually have a parent.
26112 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26113 (ConstructorInitializer.Resolve): Likewise.
26115 * interface.cs (Interface.FindMembers): Added
26116 `TypeBuilder.BaseType != null' check.
26118 * rootcontext.cs (RootContext.ResolveCore): Added
26119 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26120 classes_second_stage.
26122 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26123 debug_type and trace_type when compiling with --nostdlib.
26125 2002-06-07 Martin Baulig <martin@gnome.org>
26127 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26128 (AddField): Set it to true when adding a non-static field.
26129 (DefineType): Use `have_nonstatic_fields' to find out whether we
26130 have non-static fields, not `Fields != null'.
26132 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26134 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26135 dereferencing a null on the static-field code path)
26137 2002-05-30 Martin Baulig <martin@gnome.org>
26139 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26140 to take command line arguments. Use reflection to call the new
26141 custom `Initialize' function on the symbol writer and pass it the
26142 command line arguments.
26144 * driver.cs (--debug-args): New command line argument to pass command
26145 line arguments to the symbol writer.
26147 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26149 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26150 the target type for indexers and properties. Thanks to Joe for
26153 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26155 * typemanager.cs (MethodFlags): returns the method flags
26156 (Obsolete/ShouldIgnore) that control warning emission and whether
26157 the invocation should be made, or ignored.
26159 * expression.cs (Invocation.Emit): Remove previous hack, we should
26160 not do this on matching a base type, we should do this based on an attribute
26162 Only emit calls to System.Diagnostics.Debug and
26163 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26164 on the command line.
26166 * rootcontext.cs: Global settings for tracing and debugging.
26168 * cs-tokenizer.cs (define): New utility function to track
26169 defines. Set the global settings for TRACE and DEBUG if found.
26171 2002-05-25 Ravi Pratap <ravi@ximian.com>
26173 * interface.cs (Populate*): Pass in the TypeContainer as well as
26174 the DeclSpace as parameters so that we can create EmitContexts and
26175 then use that to apply attributes etc.
26177 (PopulateMethod, PopulateEvent, PopulateProperty)
26178 (PopulateIndexer): Apply attributes everywhere.
26180 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26183 (ApplyAttributes): Update accordingly.
26185 We now apply interface attributes for all members too.
26187 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26189 * class.cs (Indexer.Define); Correctly check if we are explicit
26190 implementation (instead of checking the Name for a ".", we
26191 directly look up if the InterfaceType was specified).
26193 Delay the creation of the PropertyBuilder.
26195 Only create the PropertyBuilder if we are not an explicit
26196 interface implementation. This means that explicit interface
26197 implementation members do not participate in regular function
26198 lookups, and hence fixes another major ambiguity problem in
26199 overload resolution (that was the visible effect).
26201 (DefineMethod): Return whether we are doing an interface
26204 * typemanager.cs: Temporary hack until we get attributes in
26205 interfaces (Ravi is working on that) and we get IndexerName
26206 support in interfaces.
26208 * interface.cs: Register the indexers as properties.
26210 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26211 warning, I have verified that this is a bug in the .NET runtime
26212 (JavaScript suffers of the same problem).
26214 * typemanager.cs (MemberLookup): When looking up members for
26215 interfaces, the parent of an interface is the implicit
26216 System.Object (so we succeed in searches of Object methods in an
26217 interface method invocation. Example: IEnumerable x; x.ToString
26220 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26222 * class.cs (Event): Events should also register if they do
26223 implement the methods that an interface requires.
26225 * typemanager.cs (MemberLookup); use the new GetInterfaces
26228 (GetInterfaces): The code used to lookup interfaces for a type is
26229 used in more than one place, factor it here.
26231 * driver.cs: Track the errors at the bottom of the file, we kept
26234 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26235 instance if the method we are calling is static!
26237 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26239 * attribute.cs (ApplyAttributes): Make this function filter out
26240 the IndexerName attribute (as that attribute in reality is never
26241 applied) and return the string constant for the IndexerName
26244 * class.cs (TypeContainer.Emit): Validate that all the indexers
26245 have the same IndexerName attribute, and if so, set the
26246 DefaultName attribute on the class.
26248 * typemanager.cs: The return value might contain other stuff (not
26249 only methods). For instance, consider a method with an "Item"
26250 property and an Item method.
26252 * class.cs: If there is a problem with the parameter types,
26255 2002-05-24 Ravi Pratap <ravi@ximian.com>
26257 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26258 looks at user defined conversion after making a call to
26259 StandardConversionExists - we need this for overload resolution.
26261 * expression.cs : Update accordingly the various method calls.
26263 This fixes 2 bugs filed against implicit user defined conversions
26265 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26267 * statement.cs: Track the result of the assignment.
26269 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26271 * expression.cs (MemberAccess): Improved error reporting for
26272 inaccessible members.
26274 2002-05-22 Martin Baulig <martin@gnome.org>
26276 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26277 itself with debugging support.
26279 2002-05-22 Martin Baulig <martin@gnome.org>
26281 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26282 Removed, this isn't needed anymore.
26284 2002-05-20 Martin Baulig <martin@gnome.org>
26286 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26287 be underlying type for an enum.
26289 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26291 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26292 that splits out the loading of just the core types.
26294 * rootcontext.cs (ResolveCore): Split the struct resolution in
26295 two, so we can load the enumeration underlying types before any
26298 * expression.cs (Is): Bandaid until we fix properly Switch (see
26299 bug #24985 for details).
26301 * typemanager.cs (ImplementsInterface): The hashtable will contain
26302 a null if there are no interfaces implemented.
26304 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26306 * cs-parser.jay (indexer_declarator): It is fine to have array
26309 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26311 * typemanager.cs: (RegisterBuilder): New function used to register
26312 TypeBuilders that implement interfaces. Since
26313 TypeBuilder.GetInterfaces (as usual) does not work with lame
26315 (AddUserType): register interfaces.
26317 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26318 dealing with TypeBuilder. Also, arrays are showing up as
26319 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26320 methods can not be invoked on them!
26322 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26323 (ImplicitReferenceConversionExists): Split out from
26324 StandardConversionExists.
26326 * expression.cs (As): We were only implementing one of the three
26327 cases for the as operator. We now implement them all.
26328 (Is): Implement the various other cases for Is as well.
26330 * typemanager.cs (CACHE): New define used to control if we want or
26331 not the FindMembers cache. Seems to have a negative impact on
26332 performance currently
26334 (MemberLookup): Nested types have full acess to
26335 enclosing type members
26337 Remove code that coped with instance/static returns for events, we
26338 now catch this in RealFindMembers.
26340 (RealFindMembers): only perform static lookup if the instance
26341 lookup did not return a type or an event.
26343 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26345 * assign.cs (CompoundAssign): We pass more semantic information
26346 now to Compound Assignments than we did before: now we have all
26347 the information at hand, and now we resolve the target *before* we
26348 do the expression expansion, which allows the "CacheValue" method
26349 to have the effect we intended (before, a [x] += 1 would generate
26350 two differen ArrayAccess expressions from the ElementAccess,
26351 during the resolution process).
26353 (CompoundAssign.DoResolve): Resolve target and original_source here.
26355 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26357 * expression.cs (ArrayAccess): dropped debugging information.
26359 * typemanager.cs: Small bug fix: I was always returning i_members,
26360 instead of one of i_members or s_members (depending on which had
26363 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26364 method is invoked before any code generation takes place, and it
26365 is a mechanism to inform that the expression will be invoked more
26366 than once, and that the method should use temporary values to
26367 avoid having side effects
26369 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26371 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26374 * expression.cs (Indirection, ArrayAccess): Add support for
26375 CacheTemporaries in these two bad boys.
26377 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26378 ldobj or ldind_ref.
26379 (StoreFromPtr): Handle stobj as well.
26381 * expression.cs (UnaryMutator): Share more code.
26383 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26384 down: I was not tracking the Filter function as well, which
26385 was affecting the results of the cache.
26387 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26389 * attribute.cs: Remove the hack to handle the CharSet property on
26392 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26394 * attribute.cs (DoResolve): More uglyness, we now only try to
26395 resolve the attribute partially, to extract the CharSet
26396 information (only if we are a StructLayout attribute). Otherwise
26398 (GetExtraTypeInfo): Add some code to conditionally kill in the
26399 future this. I am more and more convinced that the .NET
26400 framework has special code to handle the attribute setting on
26403 * expression.cs (IsParamsMethodApplicable): Revert my previous
26404 foreach change here, it was wrong.
26406 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26408 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26409 (pp_expr): do not abort on unknown input, just return.
26410 (eval): abort if there are pending chars.
26412 * attribute.cs (Attribute.Resolve): Positional parameters are
26413 optional. Deal with that case.
26415 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26416 the Ansi/Unicode/Auto information for the type.
26418 (TypeContainer.DefineType): instantiate the EmitContext here, as
26419 we will be using it during the type definition (to resolve
26420 attributes) and during the emit phase.
26422 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26423 to pull type information out of the attributes
26425 (Attribute.Resolve): track the constructor builder, and allow for
26426 multiple invocations (structs and classes will use this).
26428 * ecore.cs (MemberLookupFinal): new version with all the
26429 parameters customizable.
26431 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26432 constructors. Return if the result value is null (as the error
26433 would have been flagged already by MemberLookupFinal)
26435 Do not allow instances of abstract classes or interfaces to be
26438 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26439 We have to compare the assembly property here when dealing with
26440 FamANDAssem and Assembly access modifiers, because we might be
26441 creating an assembly from *modules* (that means that we are not
26442 getting TypeBuilders for types defined in other modules that are
26443 part of this assembly).
26445 (Method.Emit): If the method is marked abstract and has a body,
26448 (TypeContainer.DefineMembers): If both the defined member and the
26449 parent name match are methods, then do not emit any warnings: let
26450 the Method.Define routine take care of flagging warnings. But if
26451 there is a mismatch (method overrides something else, or method is
26452 overriwritten by something, then emit warning).
26454 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26455 set to null, this means `do not check for the return type on the
26458 (Method.Define): set the return type for the method signature to
26459 null, so that we get methods with the same name and parameters and
26460 different return types. This is used to flag warning 114 (you are
26461 hiding a method, and you probably want to use the new/override
26464 * typemanager.cs (MemberLookup): Implemented proper access
26465 control, closing a long standing set of bug reports. The problem
26466 was that the Framework only has two bits: Public and NonPublic,
26467 and NonPublic includes private and protected methods, but we need
26468 to enforce the FamANDAssem, FamOrAssem and Family.
26470 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26472 * statement.cs (GotoCase): Return true: Ammounts to giving up
26473 knowledge on whether we return or not, and letting the other case
26474 be responsible for it.
26476 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26478 * driver.cs: Do not load directories for each file processed, only
26479 do it if there is a pattern.
26481 * ecore.cs: Report readonly assigns here as well, as we might have
26482 been resolved only by MemberAccess.
26484 (SimpleName.SimpleNameResolve): Also be useful for LValue
26485 resolution. We need this to propagate assign to local readonly variables
26487 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26488 do not want to reuse potential criteria memory.
26490 * class.cs (MyEventBuilder): Set reflected_type;
26492 * ecore.cs (Constantify): Added support for constifying bools.
26494 (RootContext.LookupType): Added a cache for values looked up in
26495 the declaration space.
26497 * typemanager.cs (FindMembers): Now is a front-end to
26498 RealFindMembers, and provides a two-level hashtable-based cache to
26501 15% performance improvement: from 22.5 to 19.2 seconds.
26503 * expression.cs (IsParamsMethodApplicable): use foreach.
26504 (Invocation.DoResolve): ditto.
26505 (New.DoResolve): ditto.
26506 (ArrayCreation.DoResolve): ditto.
26508 * ecore.cs (FindMostEncompassingType): use foreach.
26510 * delegate.cs (NewDelegate.DoResolve): Use foreach
26512 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26513 (RemoveMethods): use foreach.
26515 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26516 nested foreach statements instead of for, and also break out of
26517 the inner loop once a match is found.
26519 (Invocation.OverloadResolve): Use foreach, simplify the code.
26521 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26523 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26524 we actually unwrap the expression to allow for extra information
26527 * expression.cs: Use Shr_Un on unsigned operations.
26529 2002-05-08 Ravi Pratap <ravi@ximian.com>
26531 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26532 applicable operators was not being considered correctly. This closes
26533 the bug Miguel reported.
26535 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26537 * attribute.cs: check that the type derives from System.Attribute
26538 and report the correct error in that case (moved the duplicate code to
26539 its own method, too).
26541 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26543 * attribute.cs: lookup attribute type name as the spec says: first the
26544 bare attribute name and then name + "Attribute" (nant compiles with
26545 mcs after this fix).
26547 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26549 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26550 Because of the way we parse things, we should try to see if a
26551 UIntConstant can fit in an integer.
26553 2002-05-07 Ravi Pratap <ravi@ximian.com>
26555 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26556 when we are in an explicit context.
26558 (ConvertReferenceExplicit): When converting from Iface type S to Class
26559 T make sure the rules are implemented as an OR.
26561 * parameter.cs (ParameterType): Make it a property for now although the
26562 purpose really isn't anything immediate.
26564 * expression.cs (Is*Applicable): Do better checking on the parameter type
26565 of a ref/out parameter. The ones from the system assemblies are already
26566 marked with the correct type so we don't need to do any correction.
26568 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26569 the object type is standard too so include that.
26571 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26573 * ecore.cs (StandardConversionExists): Augment with missing code:
26574 deal with IntConstant, LongConstants and Enumerations.
26576 * assign.cs: Report the error, instead of failing silently
26578 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26579 typecontainer that they are declared, because the
26580 typecontainer/namespace will have the list of using clauses that
26581 need to be applied.
26583 Assembly Attributes were escaping the normal registration
26586 (EmitCode): Apply attributes within an EmitContext that represents
26587 the container they were declared on.
26589 * cs-parser.jay: Track bases for structs. How did I get this wrong?
26591 2002-05-06 Ravi Pratap <ravi@ximian.com>
26593 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
26594 Revamp completely - make much cleaner as we now operate only
26597 (FindMostSpecificSource, FindMostSpecificTarget): New methods
26598 to implement the logic detailed in the spec more correctly.
26600 (UserDefinedConversion): Update accordingly.
26602 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26604 * statement.cs: Return flow analysis information up.
26606 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
26609 (token): Do not consume an extra character before calling
26612 2002-05-06 Piers Haken <piersh@friskit.com>
26614 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
26616 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26618 * class.cs (Constructor.Emit): Set the IsStatic flag in the
26619 EmitContext during the instance constructor initializer
26620 resolution, to stop access to instance variables.
26622 This is mandated by the spec, last paragraph of the `constructor
26623 initializers' section.
26625 2002-05-05 Miguel de Icaza <miguel@ximian.com>
26627 * cs-parser.jay, class.cs (Accessor): new class used to represent
26628 an accessor (get or set). In the past we used `null' to represent
26629 a missing accessor. But this is ambiguous because there was no
26630 way to tell in abstract indexers/properties if one of them was
26633 Now there is a way of addressing that.
26635 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
26636 instead of FindMembers.
26638 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
26639 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
26641 * attribute.cs: Treat indexers and properties as the same in terms
26642 of applying attributes
26644 * ecore.cs (FindMostEncompassedType): Use statically initialized
26645 EmptyExpressions()s like we do elsewhere to avoid creating useless
26646 objects (and we take this out of the tight loop).
26648 (GetConversionOperators): Move the code to extract the actual
26649 operators to a separate routine to clean things up.
26651 2002-05-04 Miguel de Icaza <miguel@ximian.com>
26653 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
26654 events are always registered FieldBuilders.
26656 * class.cs (FieldBase): New class shared by Fields
26658 * delegate.cs: If we are a toplevel delegate, use our full name.
26659 If we are a nested delegate, then only use our tail name.
26661 2002-05-02 Ravi Pratap <ravi@ximian.com>
26663 * expression.cs (IsApplicable): Ensure that we add the "&" to
26664 ref/out types before comparing it with the type of the argument.
26666 (IsParamsMethodApplicable): Ditto.
26668 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
26671 * delegate.cs : Handle the case when we have more than one applicable
26672 method. Flag an error only when we finish checking all.
26674 2002-05-02 Miguel de Icaza <miguel@ximian.com>
26676 * expression.cs: Add support for boolean static initializers.
26678 2002-05-01 Miguel de Icaza <miguel@ximian.com>
26680 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
26682 * parameter.cs (ComputeParameterTypes,
26683 ComputeAndDefineParameterTypes): Better error handling: now we
26684 clear the `types' cache if we fail during any of the type lookups.
26685 We also return the status code correctly to our caller
26687 * delegate.cs: If we fail to define a delegate, abort the extra
26690 * expression.cs (Binary.ResolveOperator): for
26691 operator==(object,object) and operator !=(object, object) we also
26692 have to verify that there is an implicit conversion from one to
26695 (ArrayAccess.DoResolve): Array Access can operate on
26698 2002-04-30 Miguel de Icaza <miguel@ximian.com>
26700 * assign.cs (CompoundAssign): A new class used as a "flag" that
26701 the assignment actually is happening as part of a compound
26702 assignment operator.
26704 During compound assignment, a few new rules exist to enable things
26711 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
26712 to the type of x) if y is implicitly convertible to the type of x,
26713 and the operator is a builtin operator and the return type of the
26714 operator is explicitly convertible to the type of x.
26716 * rootcontext.cs: Reset warning level to 2. 4 catches various
26717 "interesting" features in mcs, we must clean this up at some
26718 point, but currently am trying to kill other bugs ;-)
26720 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
26721 in container classes as well.
26723 * expression.cs (Binary.ResolveOperator): Handle string case
26724 before anything else (as operator overloading does emit an error
26725 before doing anything else).
26727 This code could go away when we move to a table driven model, but
26728 i could not come up with a good plan last night.
26730 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
26732 * typemanager.cs (CSharpName): reimplementation using regex.
26733 * class.cs: added null check for fields in Emit
26734 * rootcontext.cs: set warninglevel to 4
26736 2002-04-29 Miguel de Icaza <miguel@ximian.com>
26738 * typemanager.cs (CSharpName): reimplemented with Lupus
26741 2002-04-28 Miguel de Icaza <miguel@ximian.com>
26743 * statement.cs (If): correclty implement Resolve, because we were
26744 not catching sem errors in there. The same process is needed
26746 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
26749 (Statement.Warning_DeadCodeFound): Factorize code.
26750 (While): Report dead code here too.
26752 (Statement): Added Resolve virtual method to allow
26753 for resolution split from the emit code.
26755 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26757 * statement.cs (EmitBoolExpression): No longer try to resolve the
26759 (MakeBoolean): New utility function that resolve, implicitly
26760 converts to boolean and tags the expression.
26763 (If, Do): Implement dead code elimination.
26764 (While): Implement loop inversion
26766 (Do, While, For, If): Resolve the expression prior to calling our
26769 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
26772 - added method Report28 (warning: program has more than one entry point)
26773 - added method IsEntryPoint, implements paragraph 10.1 of the spec
26774 - modified method Method.Define, the part at the end of the method
26776 * rootcontext.cs: added static public Location EntryPointLocation;
26778 * ../errors/cs0028.cs : Add test case for the above warning.
26781 - modified method CSharpName to allow arrays of primitive type to
26782 be printed nicely (e.g. instead of System.Int32[][] it now prints
26784 - added method CSharpSignature: returns the signature of a method
26785 in string format to be used in reporting errors, warnings, etc.
26787 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
26790 2002-04-26 Ravi Pratap <ravi@ximian.com>
26792 * delegate.cs (Define): Fix extremely silly bug where I was
26793 setting the type of the 'object' parameter of the BeginInvoke
26794 method to System.IAsyncResult instead of System.Object ;-)
26796 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26798 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
26801 (Constructor.Emit): return if we fail to initialize the
26802 constructor. Another door closed!
26804 * expression.cs (New.DoResolve): Improve error message (from -6 to
26805 1501). Use DeclaredOnly lookup to find the exact constructor.
26807 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
26808 loop. This is useful.
26810 * cs-parser.jay: Adjust the default parameters so that destructors
26811 have the proper signature.
26813 2002-04-26 Martin Baulig <martin@gnome.org>
26815 * driver.cs (LoadAssembly): If `assembly' contains any characters
26816 which are only valid in path names and not in assembly names
26817 (currently slash, backslash and point), use Assembly.LoadFrom ()
26818 instead of Assembly.Load () on the `assembly' (before iteration
26819 over the link_paths).
26821 2002-04-26 Martin Baulig <martin@gnome.org>
26823 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
26825 2002-04-25 Miguel de Icaza <miguel@ximian.com>
26827 * class.cs (Property): use the new typemanager.MemberLookup
26829 (TypeContainer.MemberLookup): Implement using the
26830 TypeManager.MemberLookup now.
26832 * typemanager.cs: Make MemberLookup a function of the TypeManager,
26833 and return MemberInfos, so that these can be used without an
26834 EmitContext (what we had before).
26836 2002-04-24 Miguel de Icaza <miguel@ximian.com>
26838 * expression.cs: Fix the case where the argument to params if the
26839 type of the params. I omitted handling this before. Fixed
26841 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26843 * driver.cs: Call BootCorlib_PopulateCoreType
26845 * class.cs (Property.CheckBase): Check for properties only, not
26848 * interface.cs: Temporary hack: try/catch around the
26849 CustomAttributeBuilder, because I am getting an exception that I
26852 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
26853 types whose definitions are required to be there (attributes are
26854 defined before standard types).
26856 Compute definitions as we boot the various types, as they are used
26857 immediately (value_type class will need object_type, but if we do
26858 not initialize object_type, we will pass a null, which will let
26859 the runtime pick the System.Object from the existing corlib, which
26860 is not what we want).
26862 2002-04-22 Patrik Torstensson <totte@labs2.com>
26864 * cs-tokenizer.cs: fixed a number of trim() issues.
26866 2002-04-22 Ravi Pratap <ravi@ximian.com>
26868 * expression.cs (Argument.Type): Ensure that we return the correct
26869 type when we have out or ref parameters [in which case we
26872 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26874 * class.cs (Property, Indexer): Allow extern modifier in there.
26876 * typemanager.cs (InitBaseTypes): Initializes object_type and
26877 value_type, since those will be used early on during the bootstrap
26878 process to compile corlib.
26880 (InitCoreTypes): Move code from here to InitBaseTypes.
26882 2002-04-21 Miguel de Icaza <miguel@ximian.com>
26884 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
26885 single-dimension arrays as using the ldlen opcode.
26887 Daniel Lewis discovered this optimization.
26889 * typemanager.cs: Add signature for System.Array::get_Length
26891 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26893 * statement.cs: report the error when the foreach does not apply to an
26894 array nor a collection.
26896 2002-04-19 Miguel de Icaza <miguel@ximian.com>
26898 * expression.cs: Add implicit conversions to the operator ~.
26900 * constant.cs (DecimalConstant.Emit): Emit decimal value.
26902 * typemanager.cs: Locate the decimal constructor.
26904 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26906 * attribute.cs: use the new property of TypeOf.
26907 * expression.cs: added 'get' property around typearg.
26909 These changes fix a build breaker reported by NickD. Is this the
26910 correct way to fix? If not, please, revert my changes and make it
26913 2002-04-17 Miguel de Icaza <miguel@ximian.com>
26915 * attribute.cs: Add support for typeof in attribute invocations.
26916 I am not sure that this is right though.
26918 2002-04-14 Duncan Mak <duncan@ximian.com>
26920 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
26921 Binary.Operator.Division case.
26923 2002-04-13 Ravi Pratap <ravi@ximian.com>
26925 * class.cs (DefineType): Ensure that we do a proper check on
26926 attribute types and also register it with the TypeManager.
26928 (TypeContainer.Targets): The default for attribute types is
26929 AttributeTargets.All.
26931 * attribute.cs (ApplyAttributes): Registering the attribute type
26932 is done elsewhere, not when we discover we have a Usage attribute.
26934 2002-04-12 Ravi Pratap <ravi@ximian.com>
26936 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
26937 and get rid of is_delegate parameter.
26939 * everywhere : update.
26941 2002-04-12 Ravi Pratap <ravi@ximian.com>
26943 * cs-parser.jay (compilation_unit): Revamp completely to use
26944 some new ideas that I got from Rhys' grammar to solve the problems
26945 with assembly level attributes.
26947 (outer_declaration): New grammar production.
26949 (attribute_sections): Add.
26951 (opt_attributes): Base on attribute_sections
26953 (namespace_declaration): Allow opt_attributes to tackle the case
26954 when we have assembly level attributes - we are clever in this
26957 * attribute.cs (ApplyAttributes): Do not worry about assembly
26958 attributes in the non-global context.
26960 * rootcontext.cs (AddGlobalAttributes): Go back to using this
26961 instead of SetGlobalAttributes.
26963 * class.cs, rootcontext.cs : Ensure we define and generate
26964 attribute types before anything else.
26966 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
26967 and flag the new error -20 for the case when the attribute type
26968 does not have valid targets specified. csc does not catch this.
26970 * ../errors/errors.txt : update for error # -20
26972 2002-04-11 Ravi Pratap <ravi@ximian.com>
26974 * support.cs (InternalParameters.ParameterModifier): Do some null
26975 checking and return sane values.
26977 * class.cs (Method.Define): If we are a PInvoke method, ensure
26978 that we are static and extern. Report error # 601
26980 * ../errors/cs0601.cs : Add test case for the above error.
26982 2002-04-07 Ravi Pratap <ravi@ximian.com>
26984 * rootcontext.cs (attribute_types): We need to keep type of
26985 all attribute types separately and emit code for them first.
26987 (RegisterAttribute) : Implement.
26989 * class.cs (DefineType): Check if the current Type is a custom
26990 attribute type and register it accordingly.
26992 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
26993 adding the first attribute twice and rename to
26995 (SetGlobalAttributes): this.
26997 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27000 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27001 if we are processing global arguments. Hmm, I am unsure of this.
27003 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27005 * expression.cs: added static array of strings to avoid calling
27006 Enum.ToString () for Operator in Binary. Significant recover of
27009 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27011 * class.cs (FindMembers): Allow the Builders of the various
27012 members to be null. If they are skip them. This only happens
27013 during the PInvoke declaration.
27015 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27017 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27018 failure, so we do not keep going afterwards.
27020 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27021 wanted to pass `false' as the `is_delegate' argument. If this is
27022 the case, why not use delegate_type == null to mean `is_delegate =
27023 false' and anything else as is_delegate = true.
27025 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27027 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27028 code for the section, not the beginning of the tests.
27030 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27032 * cfold.cs: Handle operator + (Enum x, Underlying x)
27034 * expression.cs (Binary): same. Warn about errors where we have
27035 Enum/Enum in operator + as well.
27037 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27040 - added support for switch(bool)
27041 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27042 - add TableSwitchEmit() to handle table-based switch statements
27044 2002-04-05 Ravi Pratap <ravi@ximian.com>
27046 * expression.cs (Invocation.OverloadResolve): Factor out code which
27047 does parameter compatibility checking with arguments so that we can
27048 re-use the code even from Delegate.VerifyApplicability
27050 (VerifyArgumentsCompat): Move above code here.
27052 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27053 and instead make a call to the above method.
27055 2002-03-31 Ravi Pratap <ravi@ximian.com>
27057 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27058 We use it to keep track of classes which are attribute types.
27060 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27062 * delegate.cs (Delegate.Define): Correctly define the types in the
27063 presence of fixed and array parameters.
27065 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27068 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27069 include NonPublic after the first iteration.
27071 * class.cs (Indexer.CheckBase): Only check if both parents are
27074 * cs-parser.jay (accessor_body): If empty, set to null.
27076 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27077 same code path here to resolve constants names that we did have in
27078 MemberAccess.DoResolve. There is too much code duplicated here.
27080 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27082 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27084 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27087 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27088 tokens, numbers and strings.
27090 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27093 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27094 asyncronous parameters and the regular parameters.
27096 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27097 specify the target directory.
27099 * expression.cs: (This.DoResolve): Simplify
27100 (As.Emit): Optimize, do not generate IsInst if the expression is
27101 always of the given type.
27103 (Is.DoResolve): Bug fix, we were reporting both always/never for
27106 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27107 creating too many unnecessary arrays.
27109 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27111 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27112 fields instead of rolling our own initializer. Takes care of all
27113 implicit conversions, and drops unnecessary static checks/argument.
27115 2002-03-31 Dick Porter <dick@ximian.com>
27117 * driver.cs: use the GetDirectories() return values properly, and
27118 use "/" as path separator.
27120 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27122 * expression.cs (Unary): Optimize - - expr into expr.
27123 (Binary): Optimize a + (-b) into a -b.
27125 * codegen.cs (CodeGen): Made all methods static.
27127 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27131 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27132 TypeBuilder property.
27134 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27137 * tree.cs: Removed the various RecordXXXX, and replaced with a
27138 single RecordDecl. Removed all the accessor methods, and just
27139 left a single access point Type
27141 * enum.cs: Rename DefineEnum to DefineType.
27143 * decl.cs: New abstract method `DefineType' used to unify the
27144 Defines for Enumerations, Interfaces, TypeContainers and
27147 (FindType): Moved LookupInterfaceOrClass here. Moved the
27148 LookupBaseClasses method that used to live in class.cs and
27149 interface.cs here, and renamed to FindType.
27151 * delegate.cs: Implement DefineType. Take advantage of the
27152 refactored pattern for locating the parent builder without taking
27153 the parent_builder argument (which we know does not work if we are
27154 nested, and triggering a toplevel definition).
27156 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27158 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27159 accessibility of a member has changed during override and report
27162 * class.cs (Method.Define, Property.Define): Only complain on
27163 overrides if the method is private, any other accessibility is
27164 fine (and since we just checked the permission is the same, we are
27167 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27168 and elif are processed always. The other pre-processing
27169 directives are only processed if we are "taking" the path
27171 2002-03-29 Martin Baulig <martin@gnome.org>
27173 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27174 current location is not Null.
27176 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27177 a separate method so we can profile it.
27179 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27180 `span.Seconds' are just seconds, but no minutes or hours.
27181 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27183 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27185 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27186 Remove the gratuitous set of Final:
27188 // If an interface implementation, then we can set Final.
27189 if (((flags & MethodAttributes.Abstract) == 0) &&
27190 implementing.DeclaringType.IsInterface)
27191 flags |= MethodAttributes.Final;
27193 I do not know what I was smoking when I used that.
27196 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27197 step into fixing the name resolution issues for delegates and
27198 unifying the toplevel name resolution.
27200 2002-03-28 Martin Baulig <martin@gnome.org>
27202 * class.cs (Method.Emit): If we have a symbol writer, call its
27203 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27204 tell it about the current method.
27206 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27207 writer that we're going to emit the first byte of IL code for a new
27208 statement (a new source line).
27209 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27210 EmitContext.Mark() before emitting any code.
27212 * location.cs (SymbolDocument): Return null when we're Null.
27214 * statement.cs (Statement): Moved the `Location loc' variable here.
27215 (Statement.EmitBoolExpression): If we have a symbol writer, call
27216 ec.Mark() before emitting any code to tell it that we're at the
27217 beginning of a new statement.
27218 (StatementExpression): Added `Location' argument to the constructor.
27219 (Block): Added public readonly variable `StartLocation' and public
27220 variable `EndLocation'. The latter is to be set using SetEndLocation().
27221 (Block): Added constructor which takes a start and end location.
27222 (Block.SetEndLocation): New method. This sets the end location.
27223 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27224 local variables we create.
27225 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27226 each statement and do also mark the begin and end of the block.
27228 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27229 tell it the current lexer.Location, use Location.Null for the end of the
27231 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27232 current block, set its end location using SetEndLocation().
27233 (statement_expression): StatementExpression constructor now takes the
27234 lexer.Location as additional argument.
27235 (for_statement, declare_local_variables): Likewise.
27236 (declare_local_variables): When creating a new implicit block, use the
27237 new Block constructor and pass it the lexer.Location.
27239 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27241 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27242 members also on the parent interfaces recursively.
27244 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27246 * report.cs: Use new formats, since Gonzalo finished the missing
27249 * expression.cs (Binary.ResolveOperator): added missing operator|
27250 operator& and operator^ for bool/bool.
27252 * cs-parser.jay: CheckDef now takes a Location argument that is
27253 used to report errors more precisly (instead of reporting the end
27254 of a definition, we try to track something which is a lot closer
27255 to the source of the problem).
27257 * cs-tokenizer.cs: Track global token use, so we can properly flag
27258 the use of #define/#undef after the first token has been seen.
27260 Also, rename the reportXXXX to Error_DescriptiveName
27262 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27263 TypeContainer, so that Enum and Interface can use this too.
27265 * class.cs (TypeContainer.LookupInterfaceOrClass,
27266 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27267 `builder' argument. Typically this was used to pass the parent
27268 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27271 The problem is that a nested class could trigger the definition of
27272 a toplevel class, and the builder would be obviously wrong in that
27275 So we drop this argument, and we compute dynamically the
27276 TypeBuilder/ModuleBuilder (the correct information was available
27277 to us anyways from DeclSpace.Parent)
27279 * interface.cs (Interface.DefineInterface): Drop builder
27280 parameter cleanup like class.cs
27282 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27285 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27288 (Try.Emit): Propagate the returns value from the statement.
27290 (Return.Emit): Even if we are leavning
27292 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27294 * modifiers.cs: Fix the computation of MethodAttributes flags.
27296 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27298 * driver.cs: allow compilation of files that start with '/'.
27299 Add a default case when checking the argument of --target.
27301 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27303 * interface.cs: Implement the same search algorithm for types in
27304 the interface code.
27306 * delegate.cs: Do not allow multiple definition.
27308 * Recovered ChangeLog that got accidentally amputated
27310 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27312 * rootcontext.cs: Load manually enum to allow core classes to
27313 contain enumerations.
27315 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27316 Update to new static methods in TypeManager.
27318 * typemanager.cs (GetMethod, GetConstructor): Use our
27319 implementation of FindMembers to find the members, since during
27320 corlib compilation, the types are TypeBuilders and GetMethod and
27321 GetConstructor do not work.
27323 Make all methods in TypeManager static.
27325 (InitCodeHelpers): Split the functionality from
27326 the InitCodeTypes function.
27328 * driver.cs: Call InitCodeHelpers after we have populated the
27331 * cs-parser.jay (delegate_declaration): we did not used to compute
27332 the delegate name correctly for void delegates.
27334 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27336 * rootcontext.cs (RootContext): Init the interface_resolve_order
27337 and type_container_resolve_order always.
27339 (ResolveCore, BootstrapCorlib_ResolveClass,
27340 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27341 compiler when compiling with --nostdlib
27343 * class.cs (TypeContainer.DefineType): Check that our parent is
27344 not null. This test is most important when we are bootstraping
27347 * codegen.cs: Split out the symbol writing code.
27349 2002-03-25 Martin Baulig <martin@gnome.org>
27351 * driver.cs (-g): Made -g an alias for --debug.
27353 2002-03-24 Martin Baulig <martin@gnome.org>
27355 * codegen.cs (SymbolWriter): New public variable. Returns the
27356 current symbol writer.
27357 (CodeGen): Added `bool want_debugging_support' argument to the
27358 constructor. If true, tell the ModuleBuild that we want debugging
27359 support and ask it for the ISymbolWriter.
27360 (Save): If we have a symbol writer, call it's Close() method after
27361 saving the assembly.
27363 * driver.c (--debug): New command line argument to create a
27364 debugger information file.
27366 * location.cs (SymbolDocument): New public property. Returns an
27367 ISymbolDocumentWriter object for the current source file or null
27368 if we don't have a symbol writer.
27370 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27372 * driver.cs (LoadAssembly): Correctly return when all the paths
27373 have been tried and not before.
27375 * statement.cs (Switch.Emit): return the actual coverage for this
27376 statement (returns/not-returns)
27378 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27379 switch of the statement if we are the last switch section. That
27380 kills two problems: try/catch problems (we used to emit an empty
27381 nop at the end) and switch statements where all branches would
27384 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27386 * driver.cs: Add default assemblies (the equivalent to the
27387 Microsoft CSC.RSP file)
27389 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27390 also update tokens_seen and set it to false.
27392 * driver.cs: Implement --recurse for Mike.
27394 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27395 correctly splitting out the paths.
27397 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27399 * interface.cs (Interface.PopulateProperty): Instead of using
27400 `parent' as the declaration space for the set parameters, use
27403 * support.cs (InternalParameters): InternalParameters constructor
27404 takes a DeclSpace instead of a TypeContainer.
27406 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27407 types are being initialized, load the address of it before calling
27410 (New): Provide a mechanism to disable the generation of local
27411 value type temporaries when the caller will be providing us with
27412 an address to store it.
27414 (ArrayCreation.EmitDynamicInitializers): Use it.
27416 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27418 * expression.cs (Invocation.EmitArguments): Only probe for array
27419 property if there is more than one argument. Sorry about that.
27421 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27422 empty param arrays.
27424 * class.cs (Method.LabelParameters): Fix incorrect code path that
27425 prevented the `ParamArrayAttribute' from being applied to the
27428 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27430 * support.cs (ReflectionParameters): Correctly compute whether the
27431 last argument is a params array. Fixes the problem with
27434 * typemanager.cs: Make the assemblies array always be non-null
27435 (empty, but non-null)
27437 * tree.cs (RecordDecl): New function that abstracts the recording
27438 of names. This reports error 101, and provides a pointer to the
27439 previous declaration. Fixes a crash in the compiler.
27441 * cs-parser.jay (constructor_declaration): Update to new grammar,
27442 and provide a constructor_body that can be empty.
27444 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27446 * driver.cs: Add support for --resources.
27448 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27449 Make all types for the various array helper methods be integer.
27451 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27452 CheckState to ConvCast.
27454 (ConvCast): Now it takes a `checked' state argument, to avoid
27455 depending on the emit context for the conversion, and just using
27456 the resolve time setting.
27458 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27459 instead of Invocation.EmitArguments. We do not emit the original
27460 arguments, instead we emit those which have been converted to
27461 unsigned int expressions.
27463 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27465 * codegen.cs: ditto.
27467 * expression.cs (LocalVariableReference): Drop the use of the
27468 Store function that depended on the variable index.
27470 * statement.cs (VariableInfo): Drop the `Idx' property from this
27471 class, as this is not taking into account the indexes for
27472 temporaries tat we generate during the execution, getting the
27475 * class.cs: First emit class initializers, then call the parent
27478 * expression.cs (Binary): Fix opcode emision.
27479 (UnaryMutator.EmitCode): Support checked code generation
27481 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27482 matches for events for both the Static and Instance scans,
27483 pointing to the same element. Fix that.
27485 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27487 * rootcontext.cs (ResolveTree): Always set the
27488 interface_resolve_order, because nested interfaces will be calling
27491 * class.cs (GetInterfaceOrClass): Track the same resolution
27492 process used by TypeManager.LookupType. This fixes the nested
27493 type lookups in class declarations (separate path from
27496 (TypeContainer.DefineType): Also define nested interfaces.
27497 (TypeContainer.RegisterOrder): New public function used to
27498 register the order in which child interfaces need to be closed.
27500 Nested interfaces need to be closed after their parents have been
27503 * interface.cs (InterfaceAttr): Put all the logic for computing
27504 the interface attribute here.
27506 (DefineInterface): Register our interface order with the
27507 RootContext or with the TypeContainer depending on the case.
27509 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27511 * cs-parser.jay: rework foreach statement to work with the new
27512 changes to the policy on SimpleNames.
27514 * report.cs: support Stacktrace on warnings as well.
27516 * makefile: drop --unsafe and /unsafe from the compile.
27518 2002-03-13 Ravi Pratap <ravi@ximian.com>
27520 * ecore.cs (StandardConversionExists): Modify to take an Expression
27521 as the first parameter. Ensure we do null -> reference type conversion
27524 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27525 temporary Expression objects.
27527 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27529 * interface.cs: workaround bug in method overloading resolution
27530 (there is already a bugzilla bug for it).
27532 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27534 We could also solve this problem by having a separate path for
27535 performing type lookups, instead of DoResolve, we could have a
27536 ResolveType entry point, and only participating pieces of the
27537 production (simplename, deref, array) would implement this.
27539 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27540 signal SimpleName to only resolve type names and not attempt to
27541 resolve anything else.
27543 * expression.cs (Cast): Set the flag.
27545 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27547 * class.cs: Only report 108 if there is no `new' modifier.
27549 * cs-parser.jay: rework foreach statement to work with the new
27550 changes to the policy on SimpleNames.
27552 * report.cs: support Stacktrace on warnings as well.
27554 * makefile: drop --unsafe and /unsafe from the compile.
27556 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27558 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27559 lookups here, instead of doing that at parse time. This means
27560 that our grammar will not introduce `LocalVariableReferences' as
27561 expressions at this point. That solves the problem of code like
27565 static void Main ()
27569 This is only half the fix. The full fix requires parameters to
27570 also be handled in this way.
27572 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27573 makes the use more obvious of the DeclSpace. The
27574 ec.TypeContainer.TypeBuilder is now only used to pull the
27575 TypeBuilder for it.
27577 My theory is that I can get rid of the TypeBuilder completely from
27578 the EmitContext, and have typecasts where it is used (from
27579 DeclSpace to where it matters).
27581 The only pending problem is that the code that implements Aliases
27582 is on TypeContainer, and probably should go in DeclSpace.
27584 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27585 lookups here, instead of doing that at parse time. This means
27586 that our grammar will not introduce `LocalVariableReferences' as
27587 expressions at this point. That solves the problem of code like
27591 static void Main ()
27595 This is only half the fix. The full fix requires parameters to
27596 also be handled in this way.
27598 * class.cs (Property.DefineMethod): When implementing an interface
27599 method, set newslot, when implementing an abstract method, do not
27600 set the flag (before we tried never setting it, or always setting
27601 it, which is the difference).
27602 (Indexer.DefineMethod): same.
27603 (Method.DefineMethod): same.
27605 * ecore.cs: Only set the status used flag if we get back a Field.
27607 * attribute.cs: Temporary hack, so Paolo can keep working.
27609 2002-03-08 Ravi Pratap <ravi@ximian.com>
27611 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
27612 the unmanaged type in the case we have a MarshalAs attribute.
27614 (Resolve): Handle the case when we are parsing the special MarshalAs
27615 attribute [we need to store the unmanaged type to use later]
27617 * typemanager.cs (marshal_as_attr_type): Built in type for the
27618 MarshalAs Attribute.
27620 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
27621 on parameters and accordingly set the marshalling info.
27623 2002-03-09 Miguel de Icaza <miguel@ximian.com>
27625 * class.cs: Optimizing slightly by removing redundant code after
27626 we switched to the `NoTypes' return value.
27627 (Property.DefineMethod): use NoTypes here too.
27629 This fixes the bug I introduced in my last batch of changes.
27631 2002-03-05 Ravi Pratap <ravi@ximian.com>
27633 * tree.cs (RecordEnum): Add. We now keep track of enums too.
27635 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
27636 Enums since those are types too.
27638 * cs-parser.jay (enum_declaration): Record enums as we parse them.
27640 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
27641 thanks to a call during the lookup process.
27643 2002-03-07 Miguel de Icaza <miguel@ximian.com>
27645 * statement.cs (Foreach): Lots of work to accomodate a particular
27646 kind of foreach statement that I had not kept in mind. It is
27647 possible to have foreachs on classes that provide a GetEnumerator
27648 method that return objects that implement the "pattern" for using
27649 a foreach, there is no need to support GetEnumerator
27652 This is needed to compile nant.
27654 * decl.cs: Only report 114 if the member is not `Finalize' and if
27655 the warning level is at least 2.
27657 * class.cs: Moved the compare function from Method to
27660 (MethodSignature.InheritableMemberSignatureCompare): Add new
27661 filter function that is used to extract inheritable methods from a
27664 (Method.Define): Use the new `inheritable_method_signature_filter'
27667 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
27670 2002-03-06 Miguel de Icaza <miguel@ximian.com>
27672 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
27674 * cs-parser.jay: Add opt_semicolon to the interface declaration.
27676 * expression.cs: Pass location information to
27677 ConvertImplicitStandard.
27679 * class.cs: Added debugging code to track return values from
27682 2002-03-05 Miguel de Icaza <miguel@ximian.com>
27684 * expression.cs (Is.DoResolve): If either side of the `is' is an
27685 interface, do not flag the warning.
27687 * ecore.cs (ImplicitReferenceConversion): We need a separate test
27690 * report.cs: Allow for --fatal to be used with --probe.
27692 * typemanager.cs (NoTypes): Move the definition for the empty Type
27695 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
27697 (TypeContainer.DefineProxy): New function used to proxy to parent
27698 implementations when implementing interfaces.
27699 (TypeContainer.ParentImplements): used to lookup if our parent
27700 implements a public function that is required by an interface.
27701 (TypeContainer.VerifyPendingMethods): Hook this up.
27703 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
27704 `modules' and `assemblies' arraylists into arrays. We only grow
27705 these are the very early start up of the program, so this improves
27706 the speedof LookupType (nicely measured).
27708 * expression.cs (MakeByteBlob): Replaced unsafe code with
27709 BitConverter, as suggested by Paolo.
27711 * cfold.cs (ConstantFold.Binary): Special case: perform constant
27712 folding of string concatenation, but if either side is a string,
27713 and the other is not, then return null, and let the runtime use
27714 the concatenation on the string plus the object (using
27715 `Object.ToString').
27717 2002-03-04 Miguel de Icaza <miguel@ximian.com>
27719 Constant Folding has been implemented now.
27721 * expression.cs (Unary.Reduce): Do not throw an exception, catch
27722 the error instead on types that are not supported in one's
27725 * constant.cs (Constant and all children): New set of functions to
27726 perform implict and explicit conversions.
27728 * ecore.cs (EnumConstant): Implement the new functions to perform
27729 conversion by proxying to the child expression.
27731 * codegen.cs: (ConstantCheckState): Constant evaluation has its
27732 own separate setting that can not be turned off from the command
27733 line using --unchecked or --checked and is only controlled using
27734 the checked/unchecked statements and expressions. This setting is
27735 used by the constant folder to flag errors.
27737 * expression.cs (CheckedExpr, UncheckedExpr): Set the
27738 ConstantCheckState as well.
27740 During Resolve, they also have to flag the state, because the
27741 constant folder runs completely in the Resolve phase.
27743 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
27746 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27748 * cfold.cs: New file, this file contains the constant folder.
27750 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
27751 argument to track whether we are using the resulting address to
27752 load or store a value and provide better error messages.
27754 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
27755 new AddressOf arguments.
27757 * statement.cs (Foreach.EmitCollectionForeach): Update
27759 * expression.cs (Argument.Emit): Call AddressOf with proper
27760 arguments to track usage.
27762 (New.DoEmit): Call AddressOf with new arguments.
27764 (Unary.Emit): Adjust AddressOf call.
27766 2002-03-01 Ravi Pratap <ravi@ximian.com>
27768 * cs-parser.jay (member_access): Change the case for pre-defined types
27769 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
27772 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
27775 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
27776 essentially like methods and apply attributes like MethodImplOptions to them too.
27778 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
27781 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
27782 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
27785 * Update code everywhere accordingly.
27787 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
27789 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
27791 2002-02-28 Ravi Pratap <ravi@ximian.com>
27793 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
27794 try performing lookups against those instead of jumping straight into using
27795 the 'using' clauses.
27797 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
27799 (LookupType): Perform lookups in implicit parents too.
27801 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
27802 sequence as RootContext.LookupType.
27804 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
27805 the various cases of namespace lookups into this method.
27807 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27809 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
27810 in positional arguments)
27812 * class.cs (Operator): Update the AllowedModifiers to contain
27815 * cs-parser.jay: Update operator declaration to allow for the
27816 operator body to be empty.
27818 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
27821 2002-02-27 Miguel de Icaza <miguel@ximian.com>
27823 * class.cs (Method.Emit): Label parameters.
27825 * driver.cs: Return 1 or 0 as the program exit code.
27827 2002-02-26 Miguel de Icaza <miguel@ximian.com>
27829 * expression.cs: Special case the `null' object when trying to
27830 auto-compute the type, as anything can be explicitly converted to
27833 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
27834 spotting this Paolo.
27836 (Expression.ImplicitNumericConversion): Perform comparissions of
27837 the type using the underlying type in the case of an enumeration
27838 rather than using the enumeration type for the compare.
27840 Cope with the underlying == type case, which is not possible to
27843 (Expression.ConvertNumericExplicit): Perform comparissions of
27844 the type using the underlying type in the case of an enumeration
27845 rather than using the enumeration type for the compare.
27847 * driver.cs: If the user does not supply an extension, assume .exe
27849 * cs-parser.jay (if_statement): Rewrote so that we can track the
27850 location for the if statement.
27852 * expression.cs (Binary.ConstantFold): Only concat strings when
27853 the operation is "+", not everything ;-)
27855 * statement.cs (Statement.EmitBoolExpression): Take a location
27857 (If, While, Do): Track location.
27859 * expression.cs (Binary.ResolveOperator): In the object + string
27860 case, I was missing a call to ConvertImplicit
27862 2002-02-25 Ravi Pratap <ravi@ximian.com>
27864 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
27865 Location arguments. Ensure we use RootContext.LookupType to do our work
27866 and not try to do a direct Type.GetType and ModuleBuilder.GetType
27868 * interface.cs (PopulateMethod): Handle the type of the parameter being
27871 * expression.cs (Invocation.BetterFunction): Handle the case when we
27872 have a params method with no fixed arguments and a call is made with no
27875 2002-02-25 Miguel de Icaza <miguel@ximian.com>
27877 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
27878 the verbatim-string-literal
27880 * support.cs (InternalParameters.ParameterModifier): handle null
27882 (InternalParameters.ParameterType): ditto.
27884 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
27885 duplicating the name of the variable parameter.
27886 (GetParameterByName): Fix bug where we were not looking up array
27887 paramters if they were the only present (thanks Paolo!).
27888 (GetParameterInfo): We only have an empty set of types if both
27889 fixed and array are set to null.
27890 (GetParameterInfo-idx): Handle FixedParameter == null
27892 * cs-parser.jay: Handle the case where there is no catch
27893 statements (missing null test).
27895 2002-02-22 Miguel de Icaza <miguel@ximian.com>
27897 * driver.cs (MainDriver): Be conservative on our command line
27900 Catch DirectoryNotFoundException when calling GetFiles.
27902 (SplitPathAndPattern): Used to split the input specification into
27903 a path and a pattern that we can feed to Directory.GetFiles.
27905 2002-02-21 Miguel de Icaza <miguel@ximian.com>
27907 * statement.cs (Fixed): Implement the last case of the Fixed
27908 statement (string handling).
27910 * expression.cs (StringPtr): New class used to return a char * to
27911 a string; Used by the Fixed statement.
27913 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
27915 * expression.cs (Binary.ResolveOperator): Remove redundant
27916 MemberLookup pn parent type.
27917 Optimize union call, we do not need a union if the types are the same.
27918 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
27921 Specialize the use of MemberLookup everywhere, instead of using
27922 the default settings.
27924 (StackAlloc): Implement stackalloc keyword.
27926 * cs-parser.jay: Add rule to parse stackalloc.
27928 * driver.cs: Handle /h, /help, /?
27930 * expression.cs (MakeByteBlob): Removed the hacks we had in place
27931 before we supported unsafe code.
27933 * makefile: add --unsafe to the self compilation of mcs.
27935 2002-02-20 Miguel de Icaza <miguel@ximian.com>
27937 * expression.cs (PointerArithmetic): New class that is used to
27938 perform pointer arithmetic.
27939 (Binary.Resolve): Handle pointer arithmetic
27940 Handle pointer comparission.
27941 (ArrayPtr): Utility expression class that is used to take the
27942 address of an array.
27944 (ElementAccess): Implement array access for pointers
27946 * statement.cs (Fixed): Implement fixed statement for arrays, we
27947 are missing one more case before we are done.
27949 * expression.cs (Indirection): Implement EmitAssign and set the
27950 ExprClass to Variable. This allows pointer dereferences to be
27951 treated as variables, and to have values assigned to them.
27953 * ecore.cs (Expression.StoreFromPtr): New utility function to
27954 store values dereferencing.
27956 2002-02-20 Ravi Pratap <ravi@ximian.com>
27958 * expression.cs (Binary.ResolveOperator): Ensure that we are
27959 not trying to operate on a void type - this fixes the reported
27962 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
27963 the parent implementation is sealed.
27965 * ../errors/cs0239.cs : Add.
27967 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
27969 * typemanager.cs (unverifiable_code_type): Corresponds to
27970 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
27971 which have unsafe code in them.
27973 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
27976 2002-02-19 Miguel de Icaza <miguel@ximian.com>
27978 * cs-tokenizer.cs: Add support for @"litreal strings"
27980 Make tokenizer accept pre-processor directives
27981 on any column (remove the old C-like limitation).
27983 * rootcontext.cs (EmitCode): Emit any global attributes.
27984 (AddGlobalAttributes): Used to keep track of assembly attributes.
27986 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
27988 * cs-parser.jay: Add support for global attributes.
27990 2002-02-17 Miguel de Icaza <miguel@ximian.com>
27992 * expression.cs (Indirection): New helper class. Unary will
27993 create Indirection classes to be able to implement the
27994 IMemoryLocation interface on it.
27996 2002-02-16 Miguel de Icaza <miguel@ximian.com>
27998 * cs-parser.jay (fixed_statement): reference the right statement.
28000 * statement.cs (Fixed.Emit): Finish implementing the fixed
28001 statement for the &x case.
28003 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28005 * class.cs (Property.Define, Method.Define): Remove newslot when
28008 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28009 wrong. NewSlot should only be used if the `new' keyword is present.
28011 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28012 locating our system dir. Sorry about this.
28014 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28016 * driver.cs (GetSystemDir): Compute correctly the location of our
28017 system assemblies. I was using the compiler directory instead of
28018 the library directory.
28020 2002-02-13 Ravi Pratap <ravi@ximian.com>
28022 * expression.cs (BetterFunction): Put back in what Miguel commented out
28023 since it is the correct fix. The problem is elsewhere ;-)
28025 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28026 parameters of the parms method are themselves compatible or not !
28028 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28029 to check that a class implements an interface before saying that an implicit
28030 conversion was allowed. Use ImplementsInterface to do the checking.
28032 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28034 * class.cs (Method.Define): Track whether we are an explicit
28035 implementation or not. And only call DefineMethodOverride if we
28036 are an explicit implementation.
28038 (Property.DefineMethod): Ditto.
28040 2002-02-11 Ravi Pratap <ravi@ximian.com>
28042 * expression.cs (BetterFunction): Catch hideous bug which was
28043 preventing us from detecting ambiguous calls due to implicit casts i.e
28046 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28048 * support.cs (Pair): Remove un-needed method. I figured why I was
28049 getting the error in cs-parser.jay, the variable in a foreach loop
28050 is readonly, and the compiler does not really treat this as a variable.
28052 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28053 instead of EQUALS in grammar.
28055 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28057 * expression.cs (Unary.DoResolve): Check whether the argument is
28060 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28062 * support.cs: Api for Pair to set a value. Despite the fact that
28063 the variables are public the MS C# compiler refuses to compile
28064 code that accesses the field if the variable is part of a foreach
28067 * statement.cs (Fixed): Begin implementation of the fixed
28070 (Block.AddVariable): Return the VariableInfo on success and null
28071 on failure instead of true/false.
28073 * cs-parser.jay (foreach): Catch errors on variables already
28074 defined (we were ignoring this value before) and properly unwind
28075 the block hierarchy
28077 (fixed_statement): grammar for the fixed statement.
28079 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28081 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28082 pointer types to be incretemented.
28084 (SizeOf): Implement.
28086 * cs-parser.jay (pointer_member_access): Implement
28087 expr->IDENTIFIER production.
28089 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28090 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28093 (Unary): Implement indirection.
28095 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28096 use in non-unsafe context).
28098 (SimpleName.DoResolve): Check for pointers in field access on safe
28101 (Expression.LoadFromPtr): Factor the load-indirect code in this
28102 function. This was duplicated in UnboxCast and ParameterReference
28104 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28106 * expression.cs (ComposedCast): report an error if a pointer cast
28107 is used in a safe region.
28109 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28110 pointer type casts in unsafe context.
28112 * codegen.cs (EmitContext): Set up IsUnsafe.
28114 * cs-parser.jay (non_expression_type): Add productions for pointer
28117 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28118 code. We should not use force into static mode if the method is
28119 not virtual. Fixes bug in MIS
28121 * statement.cs (Do.Emit, While.Emit, For.Emit,
28122 Statement.EmitBoolExpression): Add support to Do and While to
28123 propagate infinite loop as `I do return' semantics.
28125 Improve the For case to also test for boolean constants.
28127 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28128 to the list of attributes we can add.
28130 Remove `EmitContext' argument.
28132 * class.cs (Method.Define): Apply parameter attributes.
28133 (Constructor.Define): Apply parameter attributes.
28134 (MethodCore.LabelParameters): Move here the core of labeling
28137 * support.cs (ReflectionParameters.ParameterModifier,
28138 InternalParameters.ParameterModifier): Use IsByRef on the type and
28139 only return the OUT bit for these parameters instead of in/out/ref
28142 This is because I miss-understood things. The ParameterInfo.IsIn
28143 and IsOut represent whether the parameter has the [In] and [Out]
28146 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28148 * ecore.cs (FieldExpr.Emit): Release temporaries.
28150 * assign.cs (LocalTemporary.Release): new function.
28152 * codegen.cs (EmitContext.GetTemporaryStorage,
28153 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28154 temporary storage. Now we can "put back" localbuilders when we
28157 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28159 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28160 need to make a copy of the variable to generate verifiable code.
28162 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28164 * driver.cs: Compute dynamically the system directory.
28166 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28167 Slower, but more generally useful. Used by the abstract
28168 registering implementation.
28170 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28171 the rules for the special rule on Type/instances. First check if
28172 we have the same name, and if so, try that special static path
28173 rather than the instance path.
28175 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28177 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28180 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28181 Enum, ValueType, Delegate or Array for non-corlib compiles.
28183 * cs-tokenizer.cs: Catch long identifiers (645)
28185 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28188 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28189 fix, we were returning too early, so we were not registering
28190 pending methods from abstract classes.
28192 Do not register pending methods if the class is abstract.
28194 * expression.cs (Conditional.DoResolve): Report circular implicit
28195 conversions when we neecd to compute it for conditional
28198 (Is.DoResolve): If the expression is always of the provided type,
28199 flag warning 183. If the expression can not ever be of the
28200 provided type flag warning 184.
28202 * class.cs: Catch 169 as well.
28204 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28207 2002-01-18 Nick Drochak <ndrochak@gol.com>
28209 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28211 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28213 * interface.cs: (PopulateMethod): Check for pointers being defined
28214 only if the unsafe context is active.
28215 (PopulateProperty): ditto.
28216 (PopulateIndexer): ditto.
28218 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28219 specified. If pointers are present, make sure that they are
28220 present in an unsafe context.
28221 (Constructor, Constructor.Define): ditto.
28222 (Field, Field.Define): ditto.
28223 (Property, Property.Define): ditto.
28224 (Event, Event.Define): ditto.
28226 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28227 hashtable if there are classes or structs defined.
28229 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28230 code, as the constant resolution moved.
28232 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28233 the metadata, so we can flag error 133.
28235 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28236 pointer is being declared in an unsafe context.
28238 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28240 * modifiers.cs (Modifiers.Check): Require a Location argument.
28241 Report error 227 for Unsafe use.
28243 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28245 * statement.cs (For.Emit): If the test is null, then report that
28246 we do `return', as we wont reach anything afterwards.
28248 (Switch.SwitchGoverningType): Track the expression that matched
28251 * driver.cs: Allow negative numbers as an error code to flag.
28253 * cs-parser.jay: Handle 1551.
28255 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28257 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28259 * cs-parser.jay: Report 1518 (type declaration can only contain
28260 class, struct, interface, enum or delegate)
28262 (switch_label): Report 1523 (keywords `case' or `default' must
28265 (opt_switch_sections): Report 1522 (empty switch)
28267 * driver.cs: Report 1515 (response file specified multiple times)
28268 Report 1516 (Source file specified multiple times).
28270 * expression.cs (Argument.Resolve): Signal 1510
28272 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28273 access not allowed in static code)
28275 2002-01-11 Ravi Pratap <ravi@ximian.com>
28277 * typemanager.cs (IsPointerType): Utility method which we are going
28280 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28281 the object type, so we take care of that.
28283 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28285 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28286 added to non-params parameters :-)
28288 * typemanager.cs (CSharpName): Include 'void' type too.
28290 (void_ptr_type): Include in the set of core types.
28292 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28295 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28298 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28299 completely forgotten about it.
28301 2002-01-10 Ravi Pratap <ravi@ximian.com>
28303 * cs-parser.jay (pointer_type): Add. This begins our implementation
28304 of parsing rules for unsafe code.
28306 (unsafe_statement): Implement.
28308 (embedded_statement): Modify to include the above.
28310 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28312 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28313 if the current context is an unsafe one.
28315 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28316 are handled differently, we need separate rules for them.
28318 (local_variable_declaration): Update to use local_variable_pointer_type
28319 to allow variable declarations of unmanaged pointer types.
28321 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28322 in unsafe contexts.
28324 * ../errors/cs0214.cs : Add.
28326 2002-01-16 Nick Drochak <ndrochak@gol.com>
28328 * makefile: remove 'response' file when cleaning.
28330 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28332 * cs-parser.jay: Report 1524.
28334 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28336 * typemanager.cs (RegisterMethod): drop checking if we have
28337 registered this from here
28339 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28341 * class.cs (Method.EmitDestructor): Implement calling our base
28344 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28345 value of InFinally.
28347 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28348 this routine and will wrap the call in a try/catch block. Deal
28351 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28353 * ecore.cs (Expression.MemberLookup): instead of taking a
28354 parameter `same_type' that was used to tell whether we could
28355 access private members we compute our containing type from the
28358 (FieldExpr): Added partial support for volatile fields. This does
28359 not work for volatile fields exposed from assemblies, as I can not
28360 figure out how to extract the modreq from it.
28362 Updated all the source files to use this.
28364 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28365 because it is referenced by MemberLookup very often.
28367 2002-01-09 Ravi Pratap <ravi@ximian.com>
28369 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28370 TypeBuilder.GetCustomAttributes to retrieve what we need.
28372 Get rid of redundant default_member_attr_type as this is the same as
28373 default_member_type which already exists.
28375 * interface.cs, attribute.cs : Update accordingly.
28377 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28379 * typemanager.cs: Enable IndexerPropertyName again. It does not
28380 work for TYpeBuilders though. Ravi, can you please fix this?
28382 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28384 * expression.cs (Argument.Emit): Handle the case of ref objects
28385 being passed to ref functions;
28387 (ParameterReference.EmitLoad): Loads the content of the pointer
28388 without dereferencing.
28390 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28392 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28394 2002-01-08 Ravi Pratap <ravi@ximian.com>
28396 * class.cs (Indexer.DefineMethod): Incorporate the interface
28397 type in the name of the method if we are doing explicit interface
28400 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28402 (BetterConversion): Fix extremely trivial bug where we were referring to
28403 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28406 * ../errors/bug16.cs : Add although we have fixed it.
28408 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28410 * expression.cs (BaseIndexer): Begin implementation.
28412 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28414 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28415 production directly to remove a shift/reduce, and implement
28416 explicit interface implementation.
28418 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28419 after a floating point suffix.
28421 * expression.cs (DoNumericPromotions): Improved the conversion for
28422 uint/uint. If we have a constant, we avoid doing a typecast to a
28425 * class.cs (Indexer): Implement explicit interface implementation
28428 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28430 * class.cs: make the default instance constructor public and hidebysig.
28432 2001-01-03 Ravi Pratap <ravi@ximian.com>
28434 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28435 so we can call it from elsewhere.
28437 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28438 we emit it internally if the class has a defined indexer; otherwise the user
28439 emits it by decorating the class definition with the DefaultMemberAttribute.
28441 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28442 attribute is not used on a type which defines an indexer.
28444 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28445 character when we skip whitespace.
28447 * ../errors/cs0646.cs : Add.
28449 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28451 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28454 * makefile: Add practical target `mcs3.exe' which builds the third
28455 generation compiler.
28457 * expression.cs (New): Fix structures constructor calling.
28459 * class.cs (Property, Method, Indexer): Emit Final flag on the
28460 method if we are an interface implementation and we are not
28463 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28464 whether this property is referencing a `base' method.
28466 * expression.cs (Invocation.EmitCall): take an extra argument:
28467 is_base, this is used to determine whether the `call' or
28468 `callvirt' opcode should be used.
28471 * delegate.cs: update EmitCall.
28473 * class.cs (Method.Define): Set NewSlot for the cases where we are
28474 not implementing an interface method.
28476 (Property.Define): ditto.
28478 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28480 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28481 'r'. Allows mcs to parse itself fully.
28483 2002-01-02 Ravi Pratap <ravi@ximian.com>
28485 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28486 of the number of initializers that require the InitializeArray method.
28488 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28489 update the above field where necessary.
28491 (MakeByteBlob): Update accordingly.
28493 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28496 (EmitDynamicInitializers): Update in accordance with the new optimization.
28498 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28499 same OpCode applies.
28501 * cs-parser.jay : Fix some glaring errors I introduced.
28503 2002-01-01 Ravi Pratap <ravi@ximian.com>
28505 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28506 so that we can check for name clashes there too.
28508 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28509 for interface indexers.
28511 * interfaces.cs (Define): Emit the default member attribute.
28513 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28514 variable was being referred to while setting the value ;-)
28516 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28518 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28519 byte-by-byte information when we know the data is zero.
28521 Make the block always a multiple of 4, because
28522 DefineInitializedData has a bug.
28524 * assign.cs: Fix, we should assign from the temporary, not from
28527 * expression.cs (MakeByteBlob): Fix my incorrect code.
28529 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28531 * typemanager.cs (EnumToUnderlying): This function is used to get
28532 the underlying type from an enumeration, because it does not
28535 * constant.cs: Use the I4_S form for values between -128 and 127.
28537 * statement.cs (Block.LookupLabel): Looks up a label.
28538 (Block): Drop support for labeled blocks.
28540 (LabeledStatement): New kind of statement that represents a label
28543 (Goto): Finally implement this bad boy.
28545 * cs-parser.jay: Update to reflect new mechanism to implement
28548 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28550 * codegen.cs (EmitContext.This): a codegen property that keeps the
28551 a single instance of this instead of creating many different this
28554 * delegate.cs (Delegate.DoResolve): Update to use the property;
28556 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28558 * expression.cs (BaseAccess.DoResolve): Ditto.
28560 2001-12-29 Ravi Pratap <ravi@ximian.com>
28562 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28563 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28565 (InitCoreTypes): Update accordingly.
28567 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28568 so we can quickly store the state.
28570 (ApplyAttributes): Set the correct implementation flags
28571 for InternalCall methods.
28573 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28575 * expression.cs (EmitCall): if a method is not virtual, then do
28576 not use callvirt on it.
28578 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28579 user defined stuff) requires the use of stobj, which takes an
28580 address on the stack instead of an array and an index. So emit
28581 the Ldelema operation for it.
28583 (EmitStoreOpcode): Use stobj for valuetypes.
28585 (UnaryMutator.EmitCode): Use the right 1 value depending on
28586 whether we are dealing with int64/uint64, float or doubles.
28588 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
28589 constructors that I implemented last night.
28591 (Constructor.IsDefault): Fix to work properly for static
28594 * cs-parser.jay (CheckDef): report method signature errors.
28595 Update error number 103 to be 132.
28597 * decl.cs: New AdditionResult enumeration value: MethodExists.
28598 Although we do this check for methods later on in the semantic
28599 analysis, catching repeated default constructors is so easy that
28600 we catch these here.
28602 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
28605 (ParameterReference.EmitAssign, Emit): handle
28608 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
28609 (ArrayAccess.EmitStoreOpcode): ditto.
28611 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
28613 * expression.cs (MakeByteBlob): Complete all the missing types
28614 (uint, short, ushort, byte, sbyte)
28616 * class.cs: Only init instance field initializers on instance
28619 Rename `constructors' to instance_constructors.
28621 (TypeContainer.AddConstructor): Only add constructors to the list
28622 if it is not static.
28624 Make sure that we handle default_static_constructor independently
28625 everywhere where we handle instance_constructors
28627 2001-12-28 Miguel de Icaza <miguel@ximian.com>
28629 * class.cs: Do not lookup or create a base initializer for a
28630 static constructor.
28632 (ConstructorInitializer.Resolve): use the proper type to lookup
28635 * cs-parser.jay: Report error 1585 (modifiers between type and name).
28637 * enum.cs, interface.cs: Remove CloseType, this is taken care by
28640 * decl.cs: CloseType is now an virtual method, the default
28641 implementation just closes this type.
28643 2001-12-28 Ravi Pratap <ravi@ximian.com>
28645 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
28646 to PreserveSig by default. Also emit HideBySig on such methods.
28648 Basically, set the defaults to standard values.
28650 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
28651 argument, if candidate is better, it can't be worse than the best !
28653 (Invocation): Re-write bits to differentiate between methods being
28654 applicable in their expanded form and their normal form - for params
28657 Get rid of use_standard everywhere as only standard conversions are allowed
28658 in overload resolution.
28660 More spec conformance.
28662 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28664 * driver.cs: Add --timestamp, to see where the compiler spends
28667 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
28668 `this' in static code.
28670 (SimpleName.DoResolve): Implement in terms of a helper function
28671 that allows static-references to be passed upstream to
28674 (Expression.ResolveWithSimpleName): Resolve specially simple
28675 names when called by MemberAccess to implement the special
28678 (Expression.ImplicitReferenceConversion): Handle conversions from
28679 Null to reference types before others, as Null's type is
28682 * expression.cs (Invocation.EmitCall): Handle the special case of
28683 calling methods declared on a reference type from a ValueType
28684 (Base classes System.Object and System.Enum)
28686 (MemberAccess.Resolve): Only perform lookups on Enumerations if
28687 the left hand side is a TypeExpr, not on every enumeration.
28689 (Binary.Resolve): If types are reference types, then do a cast to
28690 object on operators != and == of both arguments.
28692 * typemanager.cs (FindMembers): Extract instance and static
28693 members if requested.
28695 * interface.cs (PopulateProperty): Use void_type instead of null
28696 as the return type for the setter method.
28698 (PopulateIndexer): ditto.
28700 2001-12-27 Ravi Pratap <ravi@ximian.com>
28702 * support.cs (ReflectionParameters): Fix minor bug where we
28703 were examining the wrong parameter for the ParamArray attribute.
28705 Cope with requests for the type of the parameter at position
28706 greater than the params parameter's. We now return the element
28707 type of the params array as that makes more sense.
28709 * expression.cs (Invocation.IsParamsMethodApplicable): Update
28710 accordingly as we no longer have to extract the element type
28713 (Invocation.OverloadResolve): Update.
28715 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28717 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
28718 against IEnumerator, test whether the return value is a descendant
28719 of the IEnumerator interface.
28721 * class.cs (Indexer.Define): Use an auxiliary method to implement
28722 the other bits of the method definition. Begin support for
28723 explicit interface implementation.
28725 (Property.DefineMethod): Use TypeManager.void_type instead of null
28726 for an empty return value.
28728 2001-12-26 Miguel de Icaza <miguel@ximian.com>
28730 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
28731 dealing with a FieldExpr which is composed of a FieldBuilder, in
28732 the code path we did extract the constant, but we should have
28733 obtained the underlying value to be able to cast it (otherwise we
28734 end up in an infinite loop, this is what Ravi was running into).
28736 (ArrayCreation.UpdateIndices): Arrays might be empty.
28738 (MemberAccess.ResolveMemberAccess): Add support for section
28739 14.5.4.1 that deals with the special case of E.I when E is a type
28740 and something else, that I can be a reference to a static member.
28742 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
28743 handle a particular array type to create byte blobs, it is just
28744 something we dont generate byteblobs for.
28746 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
28749 * location.cs (Push): remove the key from the hashtable that we
28750 are about to add. This happens for empty files.
28752 * driver.cs: Dispose files after we have parsed them.
28754 (tokenize): new function that only runs the tokenizer on its
28755 input, for speed testing.
28757 2001-12-26 Ravi Pratap <ravi@ximian.com>
28759 * class.cs (Event.Define): Define the private field only if there
28760 are no accessors defined.
28762 * expression.cs (ResolveMemberAccess): If there is no associated
28763 field with the event, that means we have an event defined with its
28764 own accessors and we should flag error cs0070 since transforming
28765 ourselves into a field is not valid in that case.
28767 * ecore.cs (SimpleName.DoResolve): Same as above.
28769 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
28770 and charset to sane values.
28772 2001-12-25 Ravi Pratap <ravi@ximian.com>
28774 * assign.cs (DoResolve): Perform check on events only if they
28775 are being accessed outside the declaring type.
28777 * cs-parser.jay (event_declarations): Update rules to correctly
28778 set the type of the implicit parameter etc.
28780 (add_accessor, remove_accessor): Set current local parameters.
28782 * expression.cs (Binary): For delegate addition and subtraction,
28783 cast the return value from the method into the appropriate delegate
28786 2001-12-24 Ravi Pratap <ravi@ximian.com>
28788 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
28789 of these as the workaround is unnecessary.
28791 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
28792 delegate data - none of that is needed at all.
28794 Re-write bits to extract the instance expression and the delegate method
28797 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
28800 * attribute.cs (ApplyAttributes): New method to take care of common tasks
28801 of attaching attributes instead of duplicating code everywhere.
28803 * everywhere : Update code to do attribute emission using the above method.
28805 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28807 * expression.cs (IsParamsMethodApplicable): if there are not
28808 parameters, return immediately.
28810 * ecore.cs: The 0 literal can be implicity converted to an enum
28813 (SimpleName.DoResolve): First lookup the type, then lookup the
28816 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
28817 want to get its address. If the InstanceExpression is not
28818 addressable, store the result in a temporary variable, then get
28821 * codegen.cs: Only display 219 errors on warning level or above.
28823 * expression.cs (ArrayAccess): Make it implement the
28824 IMemoryLocation interface.
28826 (Binary.DoResolve): handle the operator == (object a, object b)
28827 and operator != (object a, object b) without incurring into a
28828 BoxedCast (because 5 != o should never be performed).
28830 Handle binary enumerator operators.
28832 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
28833 value type, otherwise use Ldelem_ref.
28835 Use precomputed names;
28837 (AddressOf): Implement address of
28839 * cs-parser.jay (labeled_statement): Fix recursive block
28840 addition by reworking the production.
28842 * expression.cs (New.DoEmit): New has a special case:
28844 If we are dealing with a ValueType, we have a few
28845 situations to deal with:
28847 * The target of New is a ValueType variable, that is
28848 easy, we just pass this as the variable reference
28850 * The target of New is being passed as an argument,
28851 to a boxing operation or a function that takes a
28854 In this case, we need to create a temporary variable
28855 that is the argument of New.
28858 2001-12-23 Ravi Pratap <ravi@ximian.com>
28860 * rootcontext.cs (LookupType): Check that current_type is not null before
28861 going about looking at nested types.
28863 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
28864 not implement the IAssignMethod interface any more.
28866 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
28867 where we tranform them into FieldExprs if they are being resolved from within
28868 the declaring type.
28870 * ecore.cs (SimpleName.DoResolve): Do the same here.
28872 * assign.cs (DoResolve, Emit): Clean up code considerably.
28874 * ../errors/bug10.cs : Add.
28876 * ../errors/cs0070.cs : Add.
28878 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
28880 * assign.cs : Get rid of EventIsLocal everywhere.
28882 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28884 * ecore.cs (ConvertIntLiteral): finished the implementation.
28886 * statement.cs (SwitchLabel): Convert the value we are using as a
28887 key before looking up the table.
28889 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28891 * codegen.cs (EmitTopBlock): Require a Location argument now.
28893 * cs-parser.jay (constructor_declarator): We need to setup
28894 current_local_parameters before we parse the
28895 opt_constructor_initializer, to allow the variables to be bound
28896 to the constructor arguments.
28898 * rootcontext.cs (LookupType): First lookup nested classes in our
28899 class and our parents before we go looking outside our class.
28901 * expression.cs (ConstantFold): Extract/debox the values at the
28904 * rootcontext.cs (EmitCode): Resolve the constants first before we
28905 resolve the types. This is not really needed, but it helps debugging.
28907 * statement.cs: report location.
28909 * cs-parser.jay: pass location to throw statement.
28911 * driver.cs: Small bug fix.
28913 * report.cs: Updated format to be 4-zero filled digits.
28915 2001-12-22 Ravi Pratap <ravi@ximian.com>
28917 * expression.cs (CheckIndices): Fix minor bug where the wrong
28918 variable was being referred to ;-)
28920 (DoEmit): Do not call EmitStaticInitializers when the
28921 underlying type is System.Object.
28923 2001-12-21 Ravi Pratap <ravi@ximian.com>
28925 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
28926 and do the usual workaround for SRE.
28928 * class.cs (MyEventBuilder.EventType): New member to get at the type
28929 of the event, quickly.
28931 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
28933 * assign.cs (Assign.DoResolve): Handle the case when the target
28934 is an EventExpr and perform the necessary checks.
28936 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
28939 (SimpleName.MemberStaticCheck): Include check for EventExpr.
28941 (EventExpr): Set the type in the constructor itself since we
28942 are meant to be born fully resolved.
28944 (EventExpr.Define): Revert code I wrote earlier.
28946 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
28947 instance expression is null. The instance expression is a This in that case
28948 or a null, depending on whether it is a static method or not.
28950 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
28951 refers to more than one method.
28953 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
28954 and accordingly flag errors.
28956 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28958 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
28960 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28962 * location.cs (ToString): Provide useful rutine.
28964 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28966 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
28967 objects, return the actual integral boxed.
28969 * statement.cs (SwitchLabel): define an ILLabel for each
28972 (Switch.CheckSwitch): If the value is a Literal, extract
28973 the underlying literal.
28975 Also in the unused hashtable we had, add the SwitchLabel so we can
28976 quickly look this value up.
28978 * constant.cs: Implement a bunch of new constants. Rewrite
28979 Literal based on this. Made changes everywhere to adapt to this.
28981 * expression.cs (Expression.MakeByteBlob): Optimize routine by
28982 dereferencing array only once, and also copes with enumrations.
28984 bytes are two bytes wide, not one.
28986 (Cast): Perform constant conversions.
28988 * ecore.cs (TryImplicitIntConversion): Return literals instead of
28989 wrappers to the literals here.
28991 * expression.cs (DoNumericPromotions): long literals can converted
28992 to ulong implicity (this is taken care of elsewhere, but I was
28993 missing this spot).
28995 * ecore.cs (Expression.Literalize): Make the return type Literal,
28996 to improve type checking.
28998 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29000 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29002 * literal.cs: Revert code from ravi that checked the bounds. The
29003 bounds are sane by the definition of the type itself.
29005 * typemanager.cs: Fix implementation of ImplementsInterface. We
29006 need to actually look up in our parent hierarchy for interfaces
29009 * const.cs: Use the underlying type for enumerations
29011 * delegate.cs: Compute the basename for the delegate creation,
29012 that should fix the delegate test case, and restore the correct
29013 Type Lookup semantics in rootcontext
29015 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29016 referencing a nested type with the Reflection API is using the "+"
29019 * cs-parser.jay: Do not require EOF token at the end.
29021 2001-12-20 Ravi Pratap <ravi@ximian.com>
29023 * rootcontext.cs (LookupType): Concatenate type names with
29024 a '.' instead of a '+' The test suite passes again.
29026 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29027 field of the enumeration.
29029 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29030 the case when the member is an EventExpr.
29032 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29033 static has an associated instance expression.
29035 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29037 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29039 * class.cs (Event.Define): Register event and perform appropriate checks
29042 We define the Add and Remove methods even if the use provides none because
29043 in that case, we provide default implementations ourselves.
29045 Define a private field of the type of the event. This is done by the CSC compiler
29046 and we should be doing it too ;-)
29048 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29049 More methods we use in code we generate.
29051 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29054 (InitCoreTypes): Update accordingly for the above.
29056 * class.cs (Event.Emit): Generate code for default accessors that we provide
29058 (EmitDefaultMethod): Do the job in the above.
29060 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29063 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29065 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29066 builders even if we were missing one.
29068 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29069 pass the Basename as our class name instead of the Name. The
29070 basename will be correctly composed for us.
29072 * parameter.cs (Paramters): Now takes a Location argument.
29074 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29075 make all the code call directly LookupType in RootContext and take
29076 this chance to pass the Location information everywhere.
29078 * Everywhere: pass Location information.
29080 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29082 * class.cs (Constructor.Define): Updated way of detecting the
29083 length of the parameters.
29085 (TypeContainer.DefineType): Use basename as the type name for
29088 (TypeContainer.Define): Do not recursively define types here, as
29089 definition is taken care in order by the RootContext.
29091 * tree.cs: Keep track of namespaces in a per-file basis.
29093 * parameter.cs (Parameter.ComputeSignature): Update to use
29096 (Parameters.GetSignature): ditto.
29098 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29099 instead of a TypeContainer.
29101 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29102 resolve names. Because we need to be resolve in our context, not
29105 * driver.cs: Implement response files.
29107 * class.cs (TypeContainer.DefineType): If we are defined, do not
29108 redefine ourselves.
29110 (Event.Emit): Emit the code for add/remove handlers.
29111 (Event.Define): Save the MethodBuilders for add/remove.
29113 * typemanager.cs: Use pair here too.
29115 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29116 DictionaryEntry requires the first argument to be non-null.
29118 (enum_declaration): Compute full name for registering the
29121 (delegate_declaration): Instead of using
29122 formal_parameter_list, use opt_formal_parameter_list as the list
29125 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29126 (EventParsing): New property that controls whether `add' and
29127 `remove' are returned as tokens or identifiers (for events);
29129 2001-12-19 Ravi Pratap <ravi@ximian.com>
29131 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29132 use MyEventBuilder only and let it wrap the real builder for us.
29134 (MyEventBuilder): Revamp constructor etc.
29136 Implement all operations that we perform on EventBuilder in precisely the same
29139 (FindMembers): Update to use the EventBuilder member.
29141 (Event.Emit): Update accordingly.
29143 2001-12-18 Ravi Pratap <ravi@ximian.com>
29145 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29146 by calling the appropriate methods.
29148 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29151 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29153 2001-12-17 Ravi Pratap <ravi@ximian.com>
29155 * delegate.cs (Delegate.Populate): Check that the return type
29156 and various parameters types are indeed accessible.
29158 * class.cs (Constructor.Define): Same here.
29160 (Field.Define): Ditto.
29162 (Event.Define): Ditto.
29164 (Operator.Define): Check that the underlying Method defined itself
29165 correctly - so it's MethodBuilder should not be null.
29167 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29168 expression happens to be null.
29170 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29171 members but as of now we don't seem to be able to do anything really useful with it.
29173 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29174 not the EventBuilder.
29176 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29178 * cs-tokenizer.cs: Add support for defines.
29179 Add support for #if, #elif, #else, #endif
29181 (eval_var): evaluates a variable.
29182 (eval): stubbed for evaluating functions.
29184 * cs-parser.jay: Pass the defines information
29186 * driver.cs: Add --define command line option.
29188 * decl.cs: Move MemberCore here.
29190 Make it the base class for DeclSpace. This allows us to catch and
29191 report 108 and 109 for everything now.
29193 * class.cs (TypeContainer.Define): Extract all the members
29194 before populating and emit the warning 108 (new keyword required
29195 to override) instead of having each member implement this.
29197 (MemberCore.Define): New abstract method, we will be using this in
29198 the warning reporting engine in Populate.
29200 (Operator.Define): Adjust to new MemberCore protocol.
29202 * const.cs (Const): This does not derive from Expression, it is a
29203 temporary object we use to create fields, it is a MemberCore.
29205 * class.cs (Method.Define): Allow the entry point to be in a
29208 * driver.cs: Rewrite the argument handler to clean it up a bit.
29210 * rootcontext.cs: Made it just an auxiliary namespace feature by
29211 making everything static.
29213 * driver.cs: Adapt code to use RootContext type name instead of
29216 * delegate.cs: Remove RootContext argument.
29218 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29221 * class.cs (Event.Define): The lookup can fail.
29223 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29225 * expression.cs: Resolve the this instance before invoking the code.
29227 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29229 * cs-parser.jay: Add a production in element_access that allows
29230 the thing to become a "type" reference. This way we can parse
29231 things like "(string [])" as a type.
29233 Note that this still does not handle the more complex rules of
29237 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29239 * ecore.cs: (CopyNewMethods): new utility function used to
29240 assemble the list of methods from running FindMembers.
29242 (MemberLookup): Rework FindMembers so that
29244 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29246 * class.cs (TypeContainer): Remove Delegates who fail to be
29249 * delegate.cs (Populate): Verify that we dont get null return
29250 values. TODO: Check for AsAccessible.
29252 * cs-parser.jay: Use basename to emit error 574 (destructor should
29253 have the same name as container class), not the full name.
29255 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29256 possible representation.
29258 Also implements integer type suffixes U and L.
29260 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29262 * expression.cs (ArrayCreation.DoResolve): We need to do the
29263 argument resolution *always*.
29265 * decl.cs: Make this hold the namespace. Hold the root context as
29267 (LookupType): Move here.
29269 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29271 * location.cs (Row, Name): Fixed the code, it was always returning
29272 references to the first file.
29274 * interface.cs: Register properties defined through interfaces.
29276 * driver.cs: Add support for globbing on the command line
29278 * class.cs (Field): Make it derive from MemberCore as well.
29281 2001-12-15 Ravi Pratap <ravi@ximian.com>
29283 * class.cs (Event::Define): Check that the type of the event is a delegate
29284 type else flag error #66.
29286 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29289 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29290 values of EntryPoint, CharSet etc etc.
29292 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29294 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29295 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29296 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29297 which needs this to do its work.
29299 * ../errors/cs0066.cs : Add.
29301 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29303 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29306 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29307 clears out the parameters field.
29308 (MemberSignatureCompare): Cleanup
29310 (MemberCore): New base class used to share code between MethodCore
29313 (RegisterRequiredImplementations) BindingFlags.Public requires
29314 either BindingFlags.Instace or Static. Use instance here.
29316 (Property): Refactored code to cope better with the full spec.
29318 * parameter.cs (GetParameterInfo): Return an empty array instead
29321 * class.cs (Property): Abstract or extern properties have no bodies.
29323 * parameter.cs (GetParameterInfo): return a zero-sized array.
29325 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29326 method modifier validation to the typecontainer so we can reuse
29327 this on properties.
29329 (MethodCore.ParameterTypes): return an empty sized array of types.
29331 (Property.Define): Test property modifier validity.
29333 Add tests for sealed/override too.
29335 (Method.Emit): abstract or extern methods have no bodies.
29337 2001-12-14 Ravi Pratap <ravi@ximian.com>
29339 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29342 (Method::Define, ::Emit): Modify accordingly.
29344 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29346 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29348 * makefile: Pass in /unsafe.
29350 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29352 * class.cs (MakeKey): Kill routine.
29354 * class.cs (TypeContainer.Define): Correctly define explicit
29355 method implementations (they require the full interface name plus
29358 * typemanager.cs: Deply the PtrHashtable here and stop using the
29359 lame keys. Things work so much better.
29361 This of course broke everyone who depended on `RegisterMethod' to
29362 do the `test for existance' test. This has to be done elsewhere.
29364 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29365 the object stupid Equals method (because, that like fails all over
29366 the place). We still do not use it.
29368 * class.cs (TypeContainer.SetRequiredInterface,
29369 TypeContainer.RequireMethods): Killed these two routines and moved
29370 all the functionality to RegisterRequiredImplementations.
29372 (TypeContainer.RegisterRequiredImplementations): This routine now
29373 registers all the implementations required in an array for the
29374 interfaces and abstract methods. We use an array of structures
29375 which can be computed ahead of time to reduce memory usage and we
29376 also assume that lookups are cheap as most classes will not
29377 implement too many interfaces.
29379 We also avoid creating too many MethodSignatures.
29381 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29382 clear the "pending" bit if we find that there are problems with
29385 (TypeContainer.VerifyPendingMethods): Update to report errors of
29386 methods that look like implementations but are not.
29388 (TypeContainer.Define): Add support for explicit interface method
29391 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29393 * typemanager.cs: Keep track of the parameters here instead of
29394 being a feature of the TypeContainer.
29396 * class.cs: Drop the registration of parameters here, as
29397 InterfaceMethods are also interface declarations.
29399 * delegate.cs: Register methods with the TypeManager not only with
29400 the TypeContainer. This code was buggy.
29402 * interface.cs: Full registation here.
29404 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29406 * expression.cs: Remove reducer for binary expressions, it can not
29409 * const.cs: Put here the code that used to go into constant.cs
29411 * constant.cs: Put here the code for constants, this is a new base
29412 class for Literals.
29414 * literal.cs: Make Literal derive from Constant.
29416 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29418 * statement.cs (Return.Emit): Report error 157 if the user
29419 attempts to return from a finally block.
29421 (Return.Emit): Instead of emitting a return, jump to the end of
29424 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29425 LocalBuilder to store the result of the function. ReturnLabel is
29426 the target where we jump.
29429 2001-12-09 Radek Doulik <rodo@ximian.com>
29431 * cs-parser.jay: remember alias in current namespace
29433 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29436 * class.cs (LookupAlias): lookup alias in my_namespace
29438 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29440 (LookupAlias): lookup alias in this and if needed in parent
29443 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29447 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29448 making things static. I need this to avoid passing the
29449 TypeContainer when calling ParameterType.
29451 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29452 that did string manipulation to compute the type and then call
29453 GetType. Use Parameter.ParameterType instead.
29455 * cs-tokenizer.cs: Consume the suffix for floating values.
29457 * expression.cs (ParameterReference): figure out whether this is a
29458 reference parameter or not. Kill an extra variable by computing
29459 the arg_idx during emission.
29461 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29462 function that returns whether a parameter is an out/ref value or not.
29464 (Parameter.ParameterType): The type of the parameter (base,
29465 without ref/out applied).
29467 (Parameter.Resolve): Perform resolution here.
29468 (Parameter.ExternalType): The full type (with ref/out applied).
29470 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29471 support for expressions on the using statement.
29473 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29475 * statement.cs (Using.EmitLocalVariableDecls): Split the
29476 localvariable handling of the using statement.
29478 (Block.EmitMeta): Keep track of variable count across blocks. We
29479 were reusing slots on separate branches of blocks.
29481 (Try.Emit): Emit the general code block, we were not emitting it.
29483 Check the type of the declaration to be an IDisposable or
29484 something that can be implicity converted to it.
29486 Emit conversions if required.
29488 * ecore.cs (EmptyExpression): New utility class.
29489 (Expression.ImplicitConversionExists): New utility function.
29491 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29493 * statement.cs (Using): Implement.
29495 * expression.cs (LocalVariableReference): Support read only variables.
29497 * statement.cs: Remove the explicit emit for the Leave opcode.
29498 (VariableInfo): Add a readonly field.
29500 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29502 * ecore.cs (ConvCast): new class used to encapsulate the various
29503 explicit integer conversions that works in both checked and
29504 unchecked contexts.
29506 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29507 properly generate the overflow opcodes.
29509 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29511 * statement.cs: The correct type for the EmptyExpression is the
29512 element_type, not the variable type. Ravi pointed this out.
29514 2001-12-04 Ravi Pratap <ravi@ximian.com>
29516 * class.cs (Method::Define): Handle PInvoke methods specially
29517 by using DefinePInvokeMethod instead of the usual one.
29519 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29520 above to do the task of extracting information and defining the method.
29522 2001-12-04 Ravi Pratap <ravi@ximian.com>
29524 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29525 of the condition for string type.
29527 (Emit): Move that here.
29529 (ArrayCreation::CheckIndices): Keep string literals in their expression
29532 (EmitDynamicInitializers): Handle strings appropriately.
29534 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29536 * codegen.cs (EmitContext): Replace multiple variables with a
29537 single pointer to the current Switch statement.
29539 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29542 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29546 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29549 (Foreach.Emit): Foreach on arrays was not setting
29550 up the loop variables (for break/continue).
29552 (GotoCase): Semi-implented.
29554 2001-12-03 Ravi Pratap <ravi@ximian.com>
29556 * attribute.cs (CheckAttribute): Handle system attributes by using
29557 Attribute.GetAttributes to examine information we need.
29559 (GetValidPlaces): Same here.
29561 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29563 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29565 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29567 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29569 (Method::Emit): Handle the case when we are a PInvoke method.
29571 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29573 * expression.cs: Use ResolveWithSimpleName on compound names.
29575 2001-12-02 Ravi Pratap <ravi@ximian.com>
29577 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29578 before trying to reduce it.
29580 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29582 * constant.cs (LookupConstantValue): Implement.
29584 (EmitConstant): Use the above in emitting the constant.
29586 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
29587 that are user-defined by doing a LookupConstantValue on them.
29589 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
29592 2001-11-29 Miguel de Icaza <miguel@ximian.com>
29594 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
29596 (BaseAccess.DoResolve): Implement.
29598 (MemberAccess.DoResolve): Split this routine into a
29599 ResolveMemberAccess routine that can be used independently
29601 2001-11-28 Miguel de Icaza <miguel@ximian.com>
29603 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
29604 As that share bits of the implementation. Is returns a boolean,
29605 while As returns the Type that is being probed.
29607 2001-12-01 Ravi Pratap <ravi@ximian.com>
29609 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
29610 instead of a Literal - much easier.
29612 (EnumInTransit): Remove - utterly useless :-)
29614 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
29616 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
29618 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
29619 chain when we have no associated expression.
29621 2001-11-30 Ravi Pratap <ravi@ximian.com>
29623 * constant.cs (Define): Use Location while reporting the errror.
29625 Also emit a warning when 'new' is used and there is no inherited
29628 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
29631 (LookupEnumValue): Implement to lookup an enum member's value and define it
29634 (Populate): Re-write accordingly to use the above routine.
29636 2001-11-27 Miguel de Icaza <miguel@ximian.com>
29638 * expression.cs (This): Fix prototype for DoResolveLValue to
29639 override the base class DoResolveLValue.
29641 * cs-parser.cs: Report errors cs574 and cs575 (destructor
29644 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
29645 (we need to load the address of the field here). This fixes
29648 (FieldExpr.DoResolveLValue): Call the DoResolve
29649 function to initialize the Instance expression.
29651 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
29652 correctly the GetEnumerator operation on a value type.
29654 * cs-parser.jay: Add more simple parsing error catches.
29656 * statement.cs (Switch): Add support for string switches.
29657 Handle null specially.
29659 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
29661 2001-11-28 Ravi Pratap <ravi@ximian.com>
29663 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
29665 (declare_local_constant): New helper function.
29667 * statement.cs (AddConstant): Keep a separate record of constants
29669 (IsConstant): Implement to determine if a variable is a constant.
29671 (GetConstantExpression): Implement.
29673 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
29675 * statement.cs (IsVariableDefined): Re-write.
29677 2001-11-27 Ravi Pratap <ravi@ximian.com>
29679 * class.cs (TypeContainer::FindMembers): Look for constants
29680 in the case when we are looking for MemberTypes.Field
29682 * expression.cs (MemberAccess::DoResolve): Check that in the
29683 case we are a FieldExpr and a Literal, we are not being accessed
29684 by an instance reference.
29686 * cs-parser.jay (local_constant_declaration): Implement.
29688 (declaration_statement): Implement for constant declarations.
29690 2001-11-26 Miguel de Icaza <miguel@ximian.com>
29692 * statement.cs (Switch): Catch double defaults.
29694 (Switch): More work on the switch() statement
29695 implementation. It works for integral values now, need to finish
29699 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29701 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
29702 integer literals into other integer literals. To be used by
29705 2001-11-24 Ravi Pratap <ravi@ximian.com>
29707 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
29710 (EmitDynamicInitializers): Cope with the above since we extract data
29711 directly from ArrayData now.
29713 (ExpectInitializers): Keep track of whether initializers are mandatory
29716 (Bounds): Make it a hashtable to prevent the same dimension being
29717 recorded for every element in that dimension.
29719 (EmitDynamicInitializers): Fix bug which prevented the Set array method
29722 Also fix bug which was causing the indices to be emitted in the reverse
29725 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29727 * expression.cs (ArrayCreation): Implement the bits that Ravi left
29728 unfinished. They do not work, because the underlying code is
29731 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29733 * cs-parser.jay: Remove bogus fixme.
29735 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
29736 on Switch statement.
29738 2001-11-23 Ravi Pratap <ravi@ximian.com>
29740 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
29743 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
29744 parameter. Apparently, any expression is allowed.
29746 (ValidateInitializers): Update accordingly.
29748 (CheckIndices): Fix some tricky bugs thanks to recursion.
29750 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
29751 I was being completely brain-dead.
29753 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
29754 and re-write acordingly.
29756 (DelegateInvocation): Re-write accordingly.
29758 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
29760 (MakeByteBlob): Handle types more correctly.
29762 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
29763 initialization from expressions but it is incomplete because I am a complete
29766 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29768 * statement.cs (If.Emit): Fix a bug that generated incorrect code
29769 on If. Basically, we have to return `true' (ie, we do return to
29770 our caller) only if both branches of the if return.
29772 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
29773 short-circuit operators, handle them as short circuit operators.
29775 (Cast.DoResolve): Resolve type.
29776 (Cast.Cast): Take an expression as the target type.
29778 * cs-parser.jay (cast_expression): Remove old hack that only
29779 allowed a limited set of types to be handled. Now we take a
29780 unary_expression and we resolve to a type during semantic
29783 Use the grammar productions from Rhys to handle casts (this is
29784 not complete like Rhys syntax yet, we fail to handle that corner
29785 case that C# has regarding (-x), but we will get there.
29787 2001-11-22 Ravi Pratap <ravi@ximian.com>
29789 * class.cs (EmitFieldInitializer): Take care of the case when we have a
29790 field which is an array type.
29792 * cs-parser.jay (declare_local_variables): Support array initialization too.
29794 * typemanager.cs (MakeKey): Implement.
29796 (everywhere): Use the above appropriately.
29798 * cs-parser.jay (for_statement): Update for array initialization while
29799 declaring variables.
29801 * ecore.cs : The error message was correct, it's the variable's names that
29802 were misleading ;-) Make the code more readable.
29804 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
29805 the correct type etc.
29807 (ConvertExplicit): Handle Enum types by examining the underlying type.
29809 2001-11-21 Ravi Pratap <ravi@ximian.com>
29811 * parameter.cs (GetCallingConvention): Always return
29812 CallingConventions.Standard for now.
29814 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29816 * expression.cs (Binary.ResolveOperator): Update the values of `l'
29817 and `r' after calling DoNumericPromotions.
29819 * ecore.cs: Fix error message (the types were in the wrong order).
29821 * statement.cs (Foreach.ProbeCollectionType): Need to pass
29822 BindingFlags.Instance as well
29824 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
29825 implicit int literal conversion in an empty cast so that we
29826 propagate the right type upstream.
29828 (UnboxCast): new class used to unbox value types.
29829 (Expression.ConvertExplicit): Add explicit type conversions done
29832 (Expression.ImplicitNumericConversion): Oops, forgot to test for
29833 the target type before applying the implicit LongLiterals to ULong
29836 2001-11-21 Miguel de Icaza <miguel@ximian.com>
29838 * cs-parser.jay (for_statement): Reworked the way For works: now
29839 we declare manually any variables that are introduced in
29840 for_initializer to solve the problem of having out-of-band code
29841 emition (that is what got for broken).
29843 (declaration_statement): Perform the actual variable declaration
29844 that used to be done in local_variable_declaration here.
29846 (local_variable_declaration): Do not declare anything, just pass
29847 the information on a DictionaryEntry
29849 2001-11-20 Ravi Pratap <ravi@ximian.com>
29851 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
29852 re-write of the logic to now make it recursive.
29854 (UpdateIndices): Re-write accordingly.
29856 Store element data in a separate ArrayData list in the above methods.
29858 (MakeByteBlob): Implement to dump the array data into a byte array.
29860 2001-11-19 Ravi Pratap <ravi@ximian.com>
29862 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
29865 * constant.cs (Define): Implement.
29867 (EmitConstant): Re-write fully.
29869 Pass in location info.
29871 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
29874 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
29875 DictionaryEntry since we need location info too.
29877 (constant_declaration): Update accordingly.
29879 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
29880 code into another method : UpdateIndices.
29882 2001-11-18 Ravi Pratap <ravi@ximian.com>
29884 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
29885 some type checking etc.
29887 2001-11-17 Ravi Pratap <ravi@ximian.com>
29889 * expression.cs (ArrayCreation::ValidateInitializers): Implement
29890 bits to provide dimension info if the user skips doing that.
29892 Update second constructor to store the rank correctly.
29894 2001-11-16 Ravi Pratap <ravi@ximian.com>
29896 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
29897 and try to implement.
29899 * ../errors/cs0150.cs : Add.
29901 * ../errors/cs0178.cs : Add.
29903 2001-11-16 Miguel de Icaza <miguel@ximian.com>
29905 * statement.cs: Implement foreach on multi-dimensional arrays.
29907 * parameter.cs (Parameters.GetParameterByName): Also lookup the
29908 name of the params argument.
29910 * expression.cs: Use EmitStoreOpcode to get the right opcode while
29911 initializing the array.
29913 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
29914 we can use this elsewhere.
29916 * statement.cs: Finish implementation of foreach for single
29919 * cs-parser.jay: Use an out-of-band stack to pass information
29920 around, I wonder why I need this.
29922 foreach_block: Make the new foreach_block the current_block.
29924 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
29925 function used to return a static Parameters structure. Used for
29926 empty parameters, as those are created very frequently.
29928 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
29930 2001-11-15 Ravi Pratap <ravi@ximian.com>
29932 * interface.cs : Default modifier is private, not public. The
29933 make verify test passes again.
29935 2001-11-15 Ravi Pratap <ravi@ximian.com>
29937 * support.cs (ReflectionParameters): Fix logic to determine
29938 whether the last parameter is a params one. Test 9 passes again.
29940 * delegate.cs (Populate): Register the builders we define with
29941 RegisterParameterForBuilder. Test 19 passes again.
29943 * cs-parser.jay (property_declaration): Reference $6 instead
29944 of $$ to get at the location.
29946 (indexer_declaration): Similar stuff.
29948 (attribute): Ditto.
29950 * class.cs (Property): Register parameters for the Get and Set methods
29951 if they exist. Test 23 passes again.
29953 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
29954 call to EmitArguments as we are sure there aren't any params arguments.
29955 Test 32 passes again.
29957 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
29958 IndexOutOfRangeException.
29960 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
29961 Test 33 now passes again.
29963 2001-11-15 Miguel de Icaza <miguel@ximian.com>
29965 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
29966 broke a bunch of things. Will have to come up with a better way
29967 of tracking locations.
29969 * statement.cs: Implemented foreach for single dimension arrays.
29971 2001-11-09 Miguel de Icaza <miguel@ximian.com>
29973 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
29974 an error. This removes the lookup from the critical path.
29976 * cs-parser.jay: Removed use of temporary_loc, which is completely
29979 2001-11-14 Miguel de Icaza <miguel@ximian.com>
29981 * support.cs (ReflectionParameters.ParameterModifier): Report
29982 whether the argument is a PARAMS argument or not.
29984 * class.cs: Set the attribute `ParamArrayAttribute' on the
29985 parameter argument.
29987 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
29988 and cons_param_array_attribute (ConstructorInfo for
29989 ParamArrayAttribute).,
29991 * codegen.cs: Emit the return using the `Return' statement, that
29992 way we can report the error correctly for missing return values.
29994 * class.cs (Method.Emit): Clean up.
29996 * expression.cs (Argument.Resolve): Take another argument: the
29997 location where this argument is used. Notice that this is not
29998 part of the "Argument" class as to reduce the size of the
29999 structure (we know the approximate location anyways).
30001 Test if the argument is a variable-reference, if not, then
30002 complain with a 206.
30004 (Argument.Emit): Emit addresses of variables.
30006 (Argument.FullDesc): Simplify.
30008 (Invocation.DoResolve): Update for Argument.Resolve.
30010 (ElementAccess.DoResolve): ditto.
30012 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30013 method should be virtual, as this method is always virtual.
30015 (NewDelegate.DoResolve): Update for Argument.Resolve.
30017 * class.cs (ConstructorInitializer.DoResolve): ditto.
30019 * attribute.cs (Attribute.Resolve): ditto.
30021 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30023 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30025 * expression.cs (ParameterReference): Drop IStackStorage and implement
30026 IAssignMethod instead.
30028 (LocalVariableReference): ditto.
30030 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30031 IAssignMethod instead.
30033 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30035 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30036 enumerations that are used in heavily used structures derive from
30037 byte in a laughable and pathetic attempt to reduce memory usage.
30038 This is the kind of pre-optimzations that you should not do at
30039 home without adult supervision.
30041 * expression.cs (UnaryMutator): New class, used to handle ++ and
30042 -- separatedly from the other unary operators. Cleans up the
30043 code, and kills the ExpressionStatement dependency in Unary.
30045 (Unary): Removed `method' and `Arguments' from this class, making
30046 it smaller, and moving it all to SimpleCall, so I can reuse this
30047 code in other locations and avoid creating a lot of transient data
30048 strucutres when not required.
30050 * cs-parser.jay: Adjust for new changes.
30052 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30054 * enum.cs (Enum.Populate): If there is a failure during
30057 * cs-parser.jay (opt_enum_base): we used to catch type errors
30058 here, but this is really incorrect. The type error should be
30059 catched during semantic analysis.
30061 2001-12-11 Ravi Pratap <ravi@ximian.com>
30063 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30064 current_local_parameters as expected since I, in my stupidity, had forgotten
30067 * attribute.cs (GetValidPlaces): Fix stupid bug.
30069 * class.cs (Method::Emit): Perform check on applicability of attributes.
30071 (Constructor::Emit): Ditto.
30073 (Field::Emit): Ditto.
30075 (Field.Location): Store location information.
30077 (Property, Event, Indexer, Operator): Ditto.
30079 * cs-parser.jay (field_declaration): Pass in location for each field.
30081 * ../errors/cs0592.cs : Add.
30083 2001-11-12 Ravi Pratap <ravi@ximian.com>
30085 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30087 (InitCoreTypes): Update accordingly.
30089 (RegisterAttrType, LookupAttr): Implement.
30091 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30092 info about the same.
30094 (Resolve): Update to populate the above as necessary.
30096 (Error592): Helper.
30098 (GetValidPlaces): Helper to the above.
30100 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30102 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30104 2001-11-12 Ravi Pratap <ravi@ximian.com>
30106 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30108 * ../errors/cs0617.cs : Add.
30110 2001-11-11 Ravi Pratap <ravi@ximian.com>
30112 * enum.cs (Emit): Rename to Populate to be more consistent with what
30113 we expect it to do and when exactly it is called.
30115 * class.cs, rootcontext.cs : Update accordingly.
30117 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30118 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30120 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30122 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30123 of a fieldinfo using the above, when dealing with a FieldBuilder.
30125 2001-11-10 Ravi Pratap <ravi@ximian.com>
30127 * ../errors/cs0031.cs : Add.
30129 * ../errors/cs1008.cs : Add.
30131 * ../errrors/cs0543.cs : Add.
30133 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30136 (FindMembers): Implement.
30138 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30139 enums and delegates too.
30141 (enum_types): Rename to builder_to_enum.
30143 (delegate_types): Rename to builder_to_delegate.
30145 * delegate.cs (FindMembers): Implement.
30147 2001-11-09 Ravi Pratap <ravi@ximian.com>
30149 * typemanager.cs (IsEnumType): Implement.
30151 * enum.cs (Emit): Re-write parts to account for the underlying type
30152 better and perform checking etc.
30154 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30155 of the underlying type.
30157 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30160 * enum.cs (error31): Helper to report error #31.
30162 * cs-parser.jay (enum_declaration): Store location of each member too.
30164 * enum.cs (member_to_location): New hashtable.
30166 (AddEnumMember): Update location hashtable.
30168 (Emit): Use the location of each member while reporting errors.
30170 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30172 * cs-parser.jay: A for_initializer if is a
30173 local_variable_declaration really ammount to have an implicit
30174 block with the variable declaration and no initializer for for.
30176 * statement.cs (For.Emit): Cope with null initializers.
30178 This fixes the infinite loop on for initializers.
30180 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30182 * enum.cs: More cleanup.
30184 * ecore.cs: Remove dead code.
30186 * class.cs (Property.Emit): More simplification.
30187 (Event.Emit): ditto.
30189 Reworked to have less levels of indentation.
30191 2001-11-08 Ravi Pratap <ravi@ximian.com>
30193 * class.cs (Property): Emit attributes.
30203 * enum.cs (Emit): Ditto.
30205 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30208 * class.cs (Field, Event, etc.): Move attribute generation into the
30209 Emit method everywhere.
30211 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30212 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30213 as we had no way of defining nested enums !
30215 * rootcontext.cs : Adjust code accordingly.
30217 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30219 2001-11-07 Ravi Pratap <ravi@ximian.com>
30221 * expression.cs (EvalConstantExpression): Move into ecore.cs
30223 * enum.cs (Enum): Rename some members and make them public and readonly
30224 according to our convention.
30226 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30229 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30231 (Enum::Emit): Write a simple version for now which doesn't try to compute
30232 expressions. I shall modify this to be more robust in just a while.
30234 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30236 (TypeContainer::CloseType): Create the Enum types too.
30238 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30240 * expression.cs (EvalConstantExpression): Get rid of completely.
30242 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30243 user-defined values and other cases.
30245 (IsValidEnumLiteral): Helper function.
30247 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30248 out there in the case we had a literal FieldExpr.
30250 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30252 (Literalize): Revamp a bit to take two arguments.
30254 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30256 2001-11-06 Ravi Pratap <ravi@ximian.com>
30258 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30260 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30262 (Resolve): Use the above to ensure we have proper initializers.
30264 2001-11-05 Ravi Pratap <ravi@ximian.com>
30266 * expression.cs (Expression::EvalConstantExpression): New method to
30267 evaluate constant expressions.
30269 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30271 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30273 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30276 (Binary.ResolveOperator): Handle operator != (object a, object b)
30277 and operator == (object a, object b);
30279 (Binary.DoNumericPromotions): Indicate whether the numeric
30280 promotion was possible.
30282 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30285 Made the ArrayAccess implement interface IAssignMethod instead of
30286 IStackStore as the order in which arguments are passed reflects
30289 * assign.cs: Instead of using expr.ExprClass to select the way of
30290 assinging, probe for the IStackStore/IAssignMethod interfaces.
30292 * typemanager.cs: Load InitializeArray definition.
30294 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30295 static data that can be used to initialize arrays.
30297 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30299 * expression.cs: Handle operator== and operator!= for booleans.
30301 (Conditioal.Reduce): Implement reducer for the ?: operator.
30303 (Conditional.Resolve): Implement dead code elimination.
30305 (Binary.Resolve): Catch string literals and return a new
30306 concatenated string.
30308 (Unary.Reduce): Implement reduction of unary expressions.
30310 * ecore.cs: Split out the expression core handling here.
30312 (Expression.Reduce): New method used to perform constant folding
30313 and CSE. This is needed to support constant-expressions.
30315 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30316 targets, and optimize for !x.
30318 2001-11-04 Ravi Pratap <ravi@ximian.com>
30320 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30321 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30322 set custom atttributes.
30324 * literal.cs (Literal::GetValue): New abstract method to return the actual
30325 value of the literal, cast as an object.
30327 (*Literal): Implement GetValue method.
30329 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30330 expressions to the arraylist but objects of type Argument.
30332 * class.cs (TypeContainer::Emit): Emit our attributes too.
30334 (Method::Emit, Constructor::Emit): Ditto.
30336 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30337 to be ignoring earlier.
30339 2001-11-03 Ravi Pratap <ravi@ximian.com>
30341 * attribute.cs (AttributeSection::Define): Implement to do the business
30342 of constructing a CustomAttributeBuilder.
30344 (Attribute): New trivial class. Increases readability of code.
30346 * cs-parser.jay : Update accordingly.
30348 (positional_argument_list, named_argument_list, named_argument): New rules
30350 (attribute_arguments): Use the above so that we are more correct.
30352 2001-11-02 Ravi Pratap <ravi@ximian.com>
30354 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30355 to perform all checks for a method with a params parameter.
30357 (Invocation::OverloadResolve): Update to use the above method and therefore
30358 cope correctly with params method invocations.
30360 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30363 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30364 constructors in our parent too because we can't afford to miss out on
30367 * attribute.cs (AttributeSection): New name for the class Attribute
30369 Other trivial changes to improve readability.
30371 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30372 use the new class names.
30374 2001-11-01 Ravi Pratap <ravi@ximian.com>
30376 * class.cs (Method::Define): Complete definition for params types too
30378 (Indexer::Define): Ditto.
30380 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30381 Cope everywhere with a request for info about the array parameter.
30383 2001-11-01 Ravi Pratap <ravi@ximian.com>
30385 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30387 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30388 local_variable_type to extract the string corresponding to the type.
30390 (local_variable_type): Fixup the action to use the new helper method.
30392 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30395 * expression.cs : Clean out code which uses the above.
30397 2001-10-31 Ravi Pratap <ravi@ximian.com>
30399 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30400 and bale out if necessary by returning a false.
30402 (RegisterProperty): Ditto.
30404 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30405 and print out appropriate error messages.
30407 * interface.cs (everywhere): Ditto.
30409 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30410 location to constructor.
30412 * class.cs (Property, Event, Indexer): Update accordingly.
30414 * ../errors/cs111.cs : Added.
30416 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30417 of a method, as laid down by the spec.
30419 (Invocation::OverloadResolve): Use the above method.
30421 2001-10-31 Ravi Pratap <ravi@ximian.com>
30423 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30424 now take a TypeContainer and a Parameters object.
30426 (ParameterData): Modify return type of ParameterModifier method to be
30427 Parameter.Modifier and not a string.
30429 (ReflectionParameters, InternalParameters): Update accordingly.
30431 * expression.cs (Argument::GetParameterModifier): Same here.
30433 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30434 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30435 symbol in it at all so maybe this is only for now.
30437 2001-10-30 Ravi Pratap <ravi@ximian.com>
30439 * support.cs (InternalParameters): Constructor now takes an extra argument
30440 which is the actual Parameters class.
30442 (ParameterDesc): Update to provide info on ref/out modifiers.
30444 * class.cs (everywhere): Update call to InternalParameters to pass in
30445 the second argument too.
30447 * support.cs (ParameterData): Add ParameterModifier, which is a method
30448 to return the modifier info [ref/out etc]
30450 (InternalParameters, ReflectionParameters): Implement the above.
30452 * expression.cs (Argument::ParameterModifier): Similar function to return
30453 info about the argument's modifiers.
30455 (Invocation::OverloadResolve): Update to take into account matching modifiers
30458 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30459 a new SetFormalParameters object which we pass to InternalParameters.
30461 2001-10-30 Ravi Pratap <ravi@ximian.com>
30463 * expression.cs (NewArray): Merge into the ArrayCreation class.
30465 2001-10-29 Ravi Pratap <ravi@ximian.com>
30467 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30468 NewUserdefinedArray into one as there wasn't much of a use in having
30471 * expression.cs (Argument): Change field's name to ArgType from Type.
30473 (Type): New readonly property which returns the proper type, taking into
30474 account ref/out modifiers.
30476 (everywhere): Adjust code accordingly for the above.
30478 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30479 whether we are emitting for a ref or out parameter.
30481 * expression.cs (Argument::Emit): Use the above field to set the state.
30483 (LocalVariableReference::Emit): Update to honour the flag and emit the
30486 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30488 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30490 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30492 (ReflectionParameters, InternalParameters): Implement the above method.
30494 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30497 (Invocation::FullMethodDesc): Ditto.
30499 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30501 * cs-parser.jay: Add extra production for the second form of array
30504 * expression.cs (ArrayCreation): Update to reflect the above
30507 * Small changes to prepare for Array initialization.
30509 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30511 * typemanager.cs (ImplementsInterface): interface might be null;
30512 Deal with this problem;
30514 Also, we do store negative hits on the cache (null values), so use
30515 this instead of calling t.GetInterfaces on the type everytime.
30517 2001-10-28 Ravi Pratap <ravi@ximian.com>
30519 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30521 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30522 split functionality out into different classes.
30524 (New::FormArrayType): Move into NewBuiltinArray.
30526 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30529 (NewBuiltinArray): New class to handle creation of built-in arrays.
30531 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30532 account creation of one-dimensional arrays.
30534 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30536 (NewUserdefinedArray::DoResolve): Implement.
30538 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30540 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30541 we maintain inside the TypeManager. This is necessary to perform lookups on the
30544 (LookupType): Update to perform GetType on the module builders too.
30546 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30548 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30550 2001-10-23 Ravi Pratap <ravi@ximian.com>
30552 * expression.cs (New::DoResolve): Implement guts of array creation.
30554 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30556 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30558 * expression.cs: Fix bug I introduced lsat night that broke
30561 (Expression.Resolve): Report a 246 error (can not resolve name)
30562 if we find a SimpleName in the stream.
30564 (Expression.ResolveLValue): Ditto.
30566 (Expression.ResolveWithSimpleName): This function is a variant of
30567 ResolveName, this one allows SimpleNames to be returned without a
30568 warning. The only consumer of SimpleNames is MemberAccess
30570 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30572 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30573 might arrive here. I have my doubts that this is correct.
30575 * statement.cs (Lock): Implement lock statement.
30577 * cs-parser.jay: Small fixes to support `lock' and `using'
30579 * cs-tokenizer.cs: Remove extra space
30581 * driver.cs: New flag --checked, allows to turn on integer math
30584 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30585 Threading.Monitor.Exit
30587 2001-10-23 Miguel de Icaza <miguel@ximian.com>
30589 * expression.cs (IndexerAccess::DoResolveLValue): Set the
30590 Expression Class to be IndexerAccess.
30592 Notice that Indexer::DoResolve sets the eclass to Value.
30594 2001-10-22 Miguel de Icaza <miguel@ximian.com>
30596 * class.cs (TypeContainer::Emit): Emit code for indexers.
30598 * assign.cs (IAssignMethod): New interface implemented by Indexers
30599 and Properties for handling assignment.
30601 (Assign::Emit): Simplify and reuse code.
30603 * expression.cs (IndexerAccess, PropertyExpr): Implement
30604 IAssignMethod, clean up old code.
30606 2001-10-22 Ravi Pratap <ravi@ximian.com>
30608 * typemanager.cs (ImplementsInterface): New method to determine if a type
30609 implements a given interface. Provides a nice cache too.
30611 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
30614 (ConvertReferenceExplicit): Ditto.
30616 * delegate.cs (Delegate::Populate): Update to define the parameters on the
30617 various methods, with correct names etc.
30619 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
30620 Operator.UnaryNegation.
30622 * cs-parser.jay (operator_declarator): Be a little clever in the case where
30623 we have a unary plus or minus operator.
30625 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
30628 * everywhere : update accordingly.
30630 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
30633 * class.cs (Method::Define): For the case where we are implementing a method
30634 inherited from an interface, we need to set the MethodAttributes.Final flag too.
30635 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
30637 2001-10-21 Ravi Pratap <ravi@ximian.com>
30639 * interface.cs (FindMembers): Implement to work around S.R.E
30642 * typemanager.cs (IsInterfaceType): Implement.
30644 (FindMembers): Update to handle interface types too.
30646 * expression.cs (ImplicitReferenceConversion): Re-write bits which
30647 use IsAssignableFrom as that is not correct - it doesn't work.
30649 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
30650 and accordingly override EmitStatement.
30652 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
30653 using the correct logic :-)
30655 2001-10-19 Ravi Pratap <ravi@ximian.com>
30657 * ../errors/cs-11.cs : Add to demonstrate error -11
30659 2001-10-17 Miguel de Icaza <miguel@ximian.com>
30661 * assign.cs (Assign::Resolve): Resolve right hand side first, and
30662 then pass this as a hint to ResolveLValue.
30664 * expression.cs (FieldExpr): Add Location information
30666 (FieldExpr::LValueResolve): Report assignment to readonly
30669 (Expression::ExprClassFromMemberInfo): Pass location information.
30671 (Expression::ResolveLValue): Add new method that resolves an
30674 (Expression::DoResolveLValue): Default invocation calls
30677 (Indexers): New class used to keep track of indexers in a given
30680 (IStackStore): Renamed from LValue, as it did not really describe
30681 what this did. Also ResolveLValue is gone from this interface and
30682 now is part of Expression.
30684 (ElementAccess): Depending on the element access type
30686 * typemanager.cs: Add `indexer_name_type' as a Core type
30687 (System.Runtime.CompilerServices.IndexerNameAttribute)
30689 * statement.cs (Goto): Take a location.
30691 2001-10-18 Ravi Pratap <ravi@ximian.com>
30693 * delegate.cs (Delegate::VerifyDelegate): New method to verify
30694 if two delegates are compatible.
30696 (NewDelegate::DoResolve): Update to take care of the case when
30697 we instantiate a delegate from another delegate.
30699 * typemanager.cs (FindMembers): Don't even try to look up members
30700 of Delegate types for now.
30702 2001-10-18 Ravi Pratap <ravi@ximian.com>
30704 * delegate.cs (NewDelegate): New class to take care of delegate
30707 * expression.cs (New): Split the delegate related code out into
30708 the NewDelegate class.
30710 * delegate.cs (DelegateInvocation): New class to handle delegate
30713 * expression.cs (Invocation): Split out delegate related code into
30714 the DelegateInvocation class.
30716 2001-10-17 Ravi Pratap <ravi@ximian.com>
30718 * expression.cs (New::DoResolve): Implement delegate creation fully
30719 and according to the spec.
30721 (New::DoEmit): Update to handle delegates differently.
30723 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
30724 because of which we were printing out arguments in reverse order !
30726 * delegate.cs (VerifyMethod): Implement to check if the given method
30727 matches the delegate.
30729 (FullDelegateDesc): Implement.
30731 (VerifyApplicability): Implement.
30733 * expression.cs (Invocation::DoResolve): Update to accordingly handle
30734 delegate invocations too.
30736 (Invocation::Emit): Ditto.
30738 * ../errors/cs1593.cs : Added.
30740 * ../errors/cs1594.cs : Added.
30742 * delegate.cs (InstanceExpression, TargetMethod): New properties.
30744 2001-10-16 Ravi Pratap <ravi@ximian.com>
30746 * typemanager.cs (intptr_type): Core type for System.IntPtr
30748 (InitCoreTypes): Update for the same.
30750 (iasyncresult_type, asynccallback_type): Ditto.
30752 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
30755 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
30758 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
30759 the builders for the 4 members of a delegate type :-)
30761 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
30764 * expression.cs (New::DoResolve): Implement guts for delegate creation.
30766 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
30768 2001-10-15 Miguel de Icaza <miguel@ximian.com>
30770 * statement.cs (Break::Emit): Implement.
30771 (Continue::Emit): Implement.
30773 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
30774 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
30775 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
30776 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
30779 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
30780 properties that track the label for the current loop (begin of the
30781 loop and end of the loop).
30783 2001-10-15 Ravi Pratap <ravi@ximian.com>
30785 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
30786 use of emitting anything at all.
30788 * class.cs, rootcontext.cs : Get rid of calls to the same.
30790 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
30792 (Populate): Define the constructor correctly and set the implementation
30795 * typemanager.cs (delegate_types): New hashtable to hold delegates that
30798 (AddDelegateType): Implement.
30800 (IsDelegateType): Implement helper method.
30802 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
30804 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
30805 and accordingly handle it.
30807 * delegate.cs (Populate): Take TypeContainer argument.
30808 Implement bits to define the Invoke method. However, I still haven't figured out
30809 how to take care of the native int bit :-(
30811 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
30812 Qualify the name of the delegate, not its return type !
30814 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
30817 (StandardConversionExists): Checking for array types turns out to be recursive.
30819 (ConvertReferenceExplicit): Implement array conversion.
30821 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
30823 2001-10-12 Ravi Pratap <ravi@ximian.com>
30825 * cs-parser.jay (delegate_declaration): Store the fully qualified
30826 name as it is a type declaration.
30828 * delegate.cs (ReturnType, Name): Rename members to these. Make them
30831 (DefineDelegate): Renamed from Define. Does the same thing essentially,
30832 as TypeContainer::DefineType.
30834 (Populate): Method in which all the definition of the various methods (Invoke)
30837 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
30840 (CloseDelegate): Finally creates the delegate.
30842 * class.cs (TypeContainer::DefineType): Update to define delegates.
30843 (Populate, Emit and CloseType): Do the same thing here too.
30845 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
30846 delegates in all these operations.
30848 2001-10-14 Miguel de Icaza <miguel@ximian.com>
30850 * expression.cs: LocalTemporary: a new expression used to
30851 reference a temporary that has been created.
30853 * assign.cs: Handle PropertyAccess back here, so that we can
30854 provide the proper semantic access to properties.
30856 * expression.cs (Expression::ConvertReferenceExplicit): Implement
30857 a few more explicit conversions.
30859 * modifiers.cs: `NEW' modifier maps to HideBySig.
30861 * expression.cs (PropertyExpr): Make this into an
30862 ExpressionStatement, and support the EmitStatement code path.
30864 Perform get/set error checking, clean up the interface.
30866 * assign.cs: recognize PropertyExprs as targets, and if so, turn
30867 them into toplevel access objects.
30869 2001-10-12 Miguel de Icaza <miguel@ximian.com>
30871 * expression.cs: PropertyExpr::PropertyExpr: use work around the
30874 * typemanager.cs: Keep track here of our PropertyBuilders again to
30875 work around lameness in SRE.
30877 2001-10-11 Miguel de Icaza <miguel@ximian.com>
30879 * expression.cs (LValue::LValueResolve): New method in the
30880 interface, used to perform a second resolution pass for LValues.
30882 (This::DoResolve): Catch the use of this in static methods.
30884 (This::LValueResolve): Implement.
30886 (This::Store): Remove warning, assigning to `this' in structures
30889 (Invocation::Emit): Deal with invocation of
30890 methods on value types. We need to pass the address to structure
30891 methods rather than the object itself. (The equivalent code to
30892 emit "this" for structures leaves the entire structure on the
30893 stack instead of a pointer to it).
30895 (ParameterReference::DoResolve): Compute the real index for the
30896 argument based on whether the method takes or not a `this' pointer
30897 (ie, the method is static).
30899 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
30900 value types returned from functions when we need to invoke a
30901 method on the sturcture.
30904 2001-10-11 Ravi Pratap <ravi@ximian.com>
30906 * class.cs (TypeContainer::DefineType): Method to actually do the business of
30907 defining the type in the Modulebuilder or Typebuilder. This is to take
30908 care of nested types which need to be defined on the TypeBuilder using
30909 DefineNestedMethod.
30911 (TypeContainer::GetClassBases): Implement. Essentially the code from the
30912 methods in RootContext, only ported to be part of TypeContainer.
30914 (TypeContainer::GetInterfaceOrClass): Ditto.
30916 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
30918 * interface.cs (Interface::DefineInterface): New method. Does exactly
30919 what RootContext.CreateInterface did earlier, only it takes care of nested types
30922 (Interface::GetInterfaces): Move from RootContext here and port.
30924 (Interface::GetInterfaceByName): Same here.
30926 * rootcontext.cs (ResolveTree): Re-write.
30928 (PopulateTypes): Re-write.
30930 * class.cs (TypeContainer::Populate): Populate nested types too.
30931 (TypeContainer::Emit): Emit nested members too.
30933 * typemanager.cs (AddUserType): Do not make use of the FullName property,
30934 instead just use the name argument passed in as it is already fully
30937 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
30938 to TypeContainer mapping to see if a type is user-defined.
30940 * class.cs (TypeContainer::CloseType): Implement.
30942 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
30943 the default constructor.
30945 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
30948 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
30950 * interface.cs (CloseType): Create the type here.
30952 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
30955 Remove all the methods which are now in TypeContainer.
30957 2001-10-10 Ravi Pratap <ravi@ximian.com>
30959 * delegate.cs (Define): Re-write bits to define the delegate
30962 2001-10-10 Miguel de Icaza <miguel@ximian.com>
30964 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
30966 * expression.cs (ImplicitReferenceConversion): handle null as well
30967 as a source to convert to any reference type.
30969 * statement.cs (Return): Perform any implicit conversions to
30970 expected return type.
30972 Validate use of return statement.
30974 * codegen.cs (EmitContext): Pass the expected return type here.
30976 * class.cs (Method, Constructor, Property): Pass expected return
30977 type to EmitContext.
30979 2001-10-09 Miguel de Icaza <miguel@ximian.com>
30981 * expression.cs: Make DoResolve take an EmitContext instead of a
30984 Replaced `l' and `location' for `loc', for consistency.
30986 (Error, Warning): Remove unneeded Tc argument.
30988 * assign.cs, literal.cs, constant.cs: Update to new calling
30991 * codegen.cs: EmitContext now contains a flag indicating whether
30992 code is being generated in a static method or not.
30994 * cs-parser.jay: DecomposeQI, new function that replaces the old
30995 QualifiedIdentifier. Now we always decompose the assembled
30996 strings from qualified_identifier productions into a group of
30999 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31001 * rootcontext.cs: Deal with field-less struct types correctly now
31002 by passing the size option to Define Type.
31004 * class.cs: Removed hack that created one static field.
31006 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31008 * statement.cs: Moved most of the code generation here.
31010 2001-10-09 Ravi Pratap <ravi@ximian.com>
31012 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31015 (ElementAccess): Remove useless bits for now - keep checks as the spec
31018 2001-10-08 Ravi Pratap <ravi@ximian.com>
31020 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31021 and start performing checks according to the spec.
31023 2001-10-07 Ravi Pratap <ravi@ximian.com>
31025 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31026 rank_specifiers instead.
31028 (rank_specifiers): Change the order in which the rank specifiers are stored
31030 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31032 * expression.cs (ElementAccess): Implement the LValue interface too.
31034 2001-10-06 Ravi Pratap <ravi@ximian.com>
31036 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31037 except that user defined conversions are not included.
31039 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31040 perform the conversion of the return type, if necessary.
31042 (New::DoResolve): Check whether we are creating an array or an object
31043 and accordingly do the needful.
31045 (New::Emit): Same here.
31047 (New::DoResolve): Implement guts of array creation.
31049 (New::FormLookupType): Helper function.
31051 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31053 * codegen.cs: Removed most of the code generation here, and move the
31054 corresponding code generation bits to the statement classes.
31056 Added support for try/catch/finalize and throw.
31058 * cs-parser.jay: Added support for try/catch/finalize.
31060 * class.cs: Catch static methods having the flags override,
31061 virtual or abstract.
31063 * expression.cs (UserCast): This user cast was not really doing
31064 what it was supposed to do. Which is to be born in fully resolved
31065 state. Parts of the resolution were being performed at Emit time!
31069 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31071 * expression.cs: Implicity convert the result from UserCast.
31073 2001-10-05 Ravi Pratap <ravi@ximian.com>
31075 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31076 prevented it from working correctly.
31078 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31079 merely ConvertImplicit.
31081 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31083 * typemanager.cs: Make the LookupTypeContainer function static,
31084 and not per-instance.
31086 * class.cs: Make static FindMembers (the one that takes a Type
31089 * codegen.cs: Add EmitForeach here.
31091 * cs-parser.jay: Make foreach a toplevel object instead of the
31092 inline expansion, as we need to perform semantic analysis on it.
31094 2001-10-05 Ravi Pratap <ravi@ximian.com>
31096 * expression.cs (Expression::ImplicitUserConversion): Rename to
31097 UserDefinedConversion.
31099 (Expression::UserDefinedConversion): Take an extra argument specifying
31100 whether we look for explicit user conversions too.
31102 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31104 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31106 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31107 with the appropriate arguments.
31109 * cs-parser.jay (cast_expression): Record location too.
31111 * expression.cs (Cast): Record location info.
31113 (Expression::ConvertExplicit): Take location argument.
31115 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31116 to determine if we are doing explicit conversions.
31118 (UserCast::Emit): Update accordingly.
31120 (Expression::ConvertExplicit): Report an error if everything fails.
31122 * ../errors/cs0030.cs : Add.
31124 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31126 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31127 virtual and newslot bits.
31129 * class.cs (TypeContainer::RegisterRequiredImplementations):
31130 Record methods we need.
31132 (TypeContainer::MakeKey): Helper function to make keys for
31133 MethodBases, since the Methodbase key is useless.
31135 (TypeContainer::Populate): Call RegisterRequiredImplementations
31136 before defining the methods.
31138 Create a mapping for method_builders_to_methods ahead of time
31139 instead of inside a tight loop.
31141 (::RequireMethods): Accept an object as the data to set into the
31142 hashtable so we can report interface vs abstract method mismatch.
31144 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31146 * report.cs: Make all of it static.
31148 * rootcontext.cs: Drop object_type and value_type computations, as
31149 we have those in the TypeManager anyways.
31151 Drop report instance variable too, now it is a global.
31153 * driver.cs: Use try/catch on command line handling.
31155 Add --probe option to debug the error reporting system with a test
31158 * report.cs: Add support for exiting program when a probe
31159 condition is reached.
31161 2001-10-03 Ravi Pratap <ravi@ximian.com>
31163 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31164 we do a forcible conversion regardless of type, to check if
31165 ForceConversion returns a null.
31167 (Binary::error19): Use location to report error.
31169 (Unary::error23): Use location here too.
31171 * ../errors/cs0019.cs : Check in.
31173 * ../errors/cs0023.cs : Check in.
31175 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31176 case of a non-null MethodInfo object with a length of 0 !
31178 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31179 an applicable member - according to the spec :-)
31180 Also fix logic to find members in base types.
31182 (Unary::ResolveOperator): Same here.
31184 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31185 as I was getting thoroughly confused between this and error19 :-)
31187 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31188 (::FindMostEncompassedType): Implement.
31189 (::FindMostEncompassingType): Implement.
31190 (::StandardConversionExists): Implement.
31192 (UserImplicitCast): Re-vamp. We now need info about most specific
31193 source and target types so that we can do the necessary conversions.
31195 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31196 mathematical union with no duplicates.
31198 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31200 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31201 in order from base classes to child classes, so that we can in
31202 child classes look up in our parent for method names and
31203 attributes (required for handling abstract, virtual, new, override
31204 constructs: we need to instrospect our base class, and if we dont
31205 populate the classes in order, the introspection might be
31206 incorrect. For example, a method could query its parent before
31207 the parent has any methods and would determine that the parent has
31208 no abstract methods (while it could have had them)).
31210 (RootContext::CreateType): Record the order in which we define the
31213 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31215 * class.cs (TypeContainer::Populate): Also method definitions can
31216 fail now, keep track of this.
31218 (TypeContainer::FindMembers): Implement support for
31219 DeclaredOnly/noDeclaredOnly flag.
31221 (Constructor::Emit) Return the ConstructorBuilder.
31223 (Method::Emit) Return the MethodBuilder.
31224 Check for abstract or virtual methods to be public.
31226 * rootcontext.cs (RootContext::CreateType): Register all the
31227 abstract methods required for the class to be complete and the
31228 interface methods that must be implemented.
31230 * cs-parser.jay: Report error 501 (method requires body if it is
31231 not marked abstract or extern).
31233 * expression.cs (TypeOf::Emit): Implement.
31235 * typemanager.cs: runtime_handle_type, new global type.
31237 * class.cs (Property::Emit): Generate code for properties.
31239 2001-10-02 Ravi Pratap <ravi@ximian.com>
31241 * expression.cs (Unary::ResolveOperator): Find operators on base type
31242 too - we now conform exactly to the spec.
31244 (Binary::ResolveOperator): Same here.
31246 * class.cs (Operator::Define): Fix minor quirk in the tests.
31248 * ../errors/cs0215.cs : Added.
31250 * ../errors/cs0556.cs : Added.
31252 * ../errors/cs0555.cs : Added.
31254 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31256 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31257 single integer which is really efficient
31259 2001-10-01 Ravi Pratap <ravi@ximian.com>
31261 * expression.cs (Expression::ImplicitUserConversion): Use location
31262 even in the case when we are examining True operators.
31264 * class.cs (Operator::Define): Perform extensive checks to conform
31265 with the rules for operator overloading in the spec.
31267 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31268 some of the other conversions mentioned in the spec.
31270 * typemanager.cs (array_type): New static member for the System.Array built-in
31273 (cloneable_interface): For System.ICloneable interface.
31275 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31276 we start resolving the tree and populating types.
31278 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31280 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31282 * expression.cs (Expression::ExprClassFromMemberInfo,
31283 Expression::Literalize): Create literal expressions from
31284 FieldInfos which are literals.
31286 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31287 type casts, because they were wrong. The test suite in tests
31290 (ImplicitNumericConversion): ushort to ulong requires a widening
31293 Int32 constant to long requires widening cast as well.
31295 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31296 for integers because the type on the stack is not i4.
31298 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31300 * expression.cs (report118): require location argument.
31302 * parameter.cs: Do not dereference potential null value.
31304 * class.cs: Catch methods that lack the `new' keyword when
31305 overriding a name. Report warnings when `new' is used without
31306 anything being there to override.
31308 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31310 * class.cs: Only add constructor to hashtable if it is non-null
31311 (as now constructors can fail on define).
31313 (TypeManager, Class, Struct): Take location arguments.
31315 Catch field instance initialization in structs as errors.
31317 accepting_filter: a new filter for FindMembers that is static so
31318 that we dont create an instance per invocation.
31320 (Constructor::Define): Catch errors where a struct constructor is
31323 * cs-parser.jay: Pass location information for various new
31326 * delegate.cs (Delegate): take a location argument.
31328 * driver.cs: Do not call EmitCode if there were problesm in the
31329 Definition of the types, as many Builders wont be there.
31331 * decl.cs (Decl::Decl): Require a location argument.
31333 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31334 into integers, and find the most appropiate integer for it.
31336 * literal.cs: Implement ULongLiteral.
31338 * rootcontext.cs: Provide better information about the location of
31339 failure when CreateType fails.
31341 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31343 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31346 * expression.cs (Binary::CheckShiftArguments): Add missing type
31348 (Binary::ResolveOperator): Add type to the logical and and logical
31349 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31352 (Binary::DoNumericPromotions): In the case where either argument
31353 is ulong (and most signed types combined with ulong cause an
31354 error) perform implicit integer constant conversions as well.
31356 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31358 * expression.cs (UserImplicitCast): Method should always be
31360 (Invocation::BetterConversion): Simplified test for IntLiteral.
31362 (Expression::ImplicitNumericConversion): Split this routine out.
31363 Put the code that performs implicit constant integer conversions
31366 (Expression::Resolve): Become a wrapper around DoResolve so we can
31367 check eclass and type being set after resolve.
31369 (Invocation::Badness): Remove this dead function
31371 (Binary::ResolveOperator): Do not compute the expensive argumnets
31372 unless we have a union for it.
31374 (Probe::Emit): Is needs to do an isinst and then
31375 compare against null.
31377 (::CanConvert): Added Location argument. If the Location argument
31378 is null (Location.Null), then we do not report errors. This is
31379 used by the `probe' mechanism of the Explicit conversion. We do
31380 not want to generate an error for something that the user
31381 explicitly requested to be casted. But the pipeline for an
31382 explicit cast first tests for potential implicit casts.
31384 So for now, if the Location is null, it means `Probe only' to
31385 avoid adding another argument. Might have to revise this
31388 (ClassCast): New class used to type cast objects into arbitrary
31389 classes (used in Explicit Reference Conversions).
31391 Implement `as' as well.
31393 Reverted all the patches from Ravi below: they were broken:
31395 * The use of `level' as a mechanism to stop recursive
31396 invocations is wrong. That was there just to catch the
31397 bug with a strack trace but not as a way of addressing
31400 To fix the problem we have to *understand* what is going
31401 on and the interactions and come up with a plan, not
31402 just get things going.
31404 * The use of the type conversion cache that I proposed
31405 last night had an open topic: How does this work across
31406 protection domains. A user defined conversion might not
31407 be public in the location where we are applying the
31408 conversion, a different conversion might be selected
31409 (ie, private A->B (better) but public B->A (worse),
31410 inside A, A->B applies, but outside it, B->A will
31413 * On top of that (ie, even if the above is solved),
31414 conversions in a cache need to be abstract. Ie, `To
31415 convert from an Int to a Short use an OpcodeCast', not
31416 `To convert from an Int to a Short use the OpcodeCast on
31417 the variable 5' (which is what this patch was doing).
31419 2001-09-28 Ravi Pratap <ravi@ximian.com>
31421 * expression.cs (Invocation::ConversionExists): Re-write to use
31422 the conversion cache
31424 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31425 cache all conversions done, not just user-defined ones.
31427 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31428 to determine if a conversion exists instead of acutually trying to
31429 perform the conversion. It's faster too.
31431 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31432 and only then attempt the implicit conversion.
31434 2001-09-28 Ravi Pratap <ravi@ximian.com>
31436 * expression.cs (ConvertImplicit): Use a cache for conversions
31437 already found. Check level of recursion and bail out if necessary.
31439 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31441 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31442 Export standard methods that we expect for string operations.
31444 * statement.cs (Block::UsageWarning): Track usage of variables and
31445 report the errors for not used variables.
31447 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31450 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31452 * codegen.cs: remove unnneded code
31454 * expression.cs: Removed BuiltinTypeAccess class
31456 Fix the order in which implicit conversions are
31459 The previous fixed dropped support for boxed conversions (adding a
31460 test to the test suite now)
31462 (UserImplicitCast::CanConvert): Remove test for source being null,
31463 that code is broken. We should not feed a null to begin with, if
31464 we do, then we should track the bug where the problem originates
31465 and not try to cover it up here.
31467 Return a resolved expression of type UserImplicitCast on success
31468 rather than true/false. Ravi: this is what I was talking about,
31469 the pattern is to use a static method as a "constructor" for
31472 Also, do not create arguments until the very last minute,
31473 otherwise we always create the arguments even for lookups that
31474 will never be performed.
31476 (UserImplicitCast::Resolve): Eliminate, objects of type
31477 UserImplicitCast are born in a fully resolved state.
31479 * typemanager.cs (InitCoreTypes): Init also value_type
31480 (System.ValueType).
31482 * expression.cs (Cast::Resolve): First resolve the child expression.
31484 (LValue): Add new method AddressOf to be used by
31487 Change the argument of Store to take an EmitContext instead of an
31488 ILGenerator, because things like FieldExpr need to be able to call
31489 their children expression to generate the instance code.
31491 (Expression::Error, Expression::Warning): Sugar functions for
31494 (Expression::MemberLookup): Accept a TypeContainer instead of a
31495 Report as the first argument.
31497 (Expression::ResolvePrimary): Killed. I still want to improve
31498 this as currently the code is just not right.
31500 (Expression::ResolveMemberAccess): Simplify, but it is still
31503 (Unary::Resolve): Catch errors in AddressOf operators.
31505 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31506 index to a byte for the short-version, or the compiler will choose
31507 the wrong Emit call, which generates the wrong data.
31509 (ParameterReference::Emit, ::Store): same.
31511 (FieldExpr::AddressOf): Implement.
31513 * typemanager.cs: TypeManager: made public variable instead of
31516 * driver.cs: document --fatal.
31518 * report.cs (ErrorMessage, WarningMessage): new names for the old
31519 Error and Warning classes.
31521 * cs-parser.jay (member_access): Turn built-in access to types
31522 into a normal simplename
31524 2001-09-27 Ravi Pratap <ravi@ximian.com>
31526 * expression.cs (Invocation::BetterConversion): Fix to cope
31527 with q being null, since this was introducing a bug.
31529 * expression.cs (ConvertImplicit): Do built-in conversions first.
31531 2001-09-27 Ravi Pratap <ravi@ximian.com>
31533 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31535 2001-09-27 Ravi Pratap <ravi@ximian.com>
31537 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31538 I had introduced long ago (what's new ?).
31540 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31541 the work of all the checking.
31542 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31543 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31545 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31546 that is the right way.
31548 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31549 overloading resolution. Use everywhere instead of cutting and pasting code.
31551 (Binary::ResolveOperator): Use MakeUnionSet.
31553 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31554 we have to convert to bool types. Not complete yet.
31556 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31558 * typemanager.cs (TypeManager::CSharpName): support ushort.
31560 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31561 to provide an expression that performsn an implicit constant int
31562 conversion (section 6.1.6).
31563 (Expression::ConvertImplicitRequired): Reworked to include
31564 implicit constant expression conversions.
31566 (Expression::ConvertNumericExplicit): Finished.
31568 (Invocation::Emit): If InstanceExpression is null, then it means
31569 that we perform a call on this.
31571 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31573 * expression.cs (Unary::Emit): Remove some dead code.
31574 (Probe): Implement Resolve and Emit for `is'.
31575 (Expression::ConvertImplicitRequired): Attempt to do constant
31576 expression conversions here. Maybe should be moved to
31577 ConvertImplicit, but I am not sure.
31578 (Expression::ImplicitLongConstantConversionPossible,
31579 Expression::ImplicitIntConstantConversionPossible): New functions
31580 that tell whether is it possible to apply an implicit constant
31581 expression conversion.
31583 (ConvertNumericExplicit): Started work on explicit numeric
31586 * cs-parser.jay: Update operator constants.
31588 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
31589 (Parameters::GetSignature): Hook up VerifyArgs here.
31590 (Parameters::VerifyArgs): Verifies that no two arguments have the
31593 * class.cs (Operator): Update the operator names to reflect the
31594 ones that the spec expects (as we are just stringizing the
31597 * expression.cs (Unary::ResolveOperator): Fix bug: Use
31598 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
31599 previous usage did only work for our methods.
31600 (Expression::ConvertImplicit): Handle decimal implicit numeric
31601 conversions as well.
31602 (Expression::InternalTypeConstructor): Used to invoke constructors
31603 on internal types for default promotions.
31605 (Unary::Emit): Implement special handling for the pre/post
31606 increment/decrement for overloaded operators, as they need to have
31607 the same semantics as the other operators.
31609 (Binary::ResolveOperator): ditto.
31610 (Invocation::ConversionExists): ditto.
31611 (UserImplicitCast::Resolve): ditto.
31613 2001-09-26 Ravi Pratap <ravi@ximian.com>
31615 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
31616 operator, return after emitting body. Regression tests pass again !
31618 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
31619 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
31620 (Invocation::OverloadResolve): Ditto.
31621 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
31623 * everywhere : update calls to the above methods accordingly.
31625 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31627 * assign.cs (Assign): Make it inherit from ExpressionStatement.
31629 * expression.cs (ExpressionStatement): New base class used for
31630 expressions that can appear in statements, so that we can provide
31631 an alternate path to generate expression that do not leave a value
31634 (Expression::Emit, and all the derivatives): We no longer return
31635 whether a value is left on the stack or not. Every expression
31636 after being emitted leaves a single value on the stack.
31638 * codegen.cs (EmitContext::EmitStatementExpression): Use the
31639 facilties of ExpressionStatement if possible.
31641 * cs-parser.jay: Update statement_expression.
31643 2001-09-25 Miguel de Icaza <miguel@ximian.com>
31645 * driver.cs: Change the wording of message
31647 2001-09-25 Ravi Pratap <ravi@ximian.com>
31649 * expression.cs (Binary::ResolveOperator): Had forgottten to set
31650 the type of the expression to the return type of the method if
31651 we have an overloaded operator match ! The regression tests pass again !
31652 (Unary::ResolveOperator): Ditto.
31654 * expression.cs (Invocation::ConversionExists): Correct the member lookup
31655 to find "op_Implicit", not "implicit" ;-)
31656 (UserImplicitCast): New class to take care of user-defined implicit conversions.
31657 (ConvertImplicit, ForceConversion): Take TypeContainer argument
31659 * everywhere : Correct calls to the above accordingly.
31661 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
31662 (ConvertImplicit): Do user-defined conversion if it exists.
31664 2001-09-24 Miguel de Icaza <miguel@ximian.com>
31666 * assign.cs: track location.
31667 (Resolve): Use implicit conversions on assignment.
31669 * literal.cs: Oops. Not good, Emit of short access values should
31670 pass (Bytes) or the wrong argument will be selected.
31672 * expression.cs (Unary::Emit): Emit code for -expr.
31674 (Unary::ResolveOperator): Handle `Substract' for non-constants
31675 (substract from zero from the non-constants).
31676 Deal with Doubles as well.
31678 (Expression::ConvertImplicitRequired): New routine that reports an
31679 error if no implicit conversion exists.
31681 (Invocation::OverloadResolve): Store the converted implicit
31682 expressions if we make them
31684 2001-09-24 Ravi Pratap <ravi@ximian.com>
31686 * class.cs (ConstructorInitializer): Take a Location argument.
31687 (ConstructorBaseInitializer): Same here.
31688 (ConstructorThisInitializer): Same here.
31690 * cs-parser.jay : Update all calls accordingly.
31692 * expression.cs (Unary, Binary, New): Take location argument.
31693 Update accordingly everywhere.
31695 * cs-parser.jay : Update all calls to the above to take a location
31698 * class.cs : Ditto.
31700 2001-09-24 Ravi Pratap <ravi@ximian.com>
31702 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
31703 (Invocation::BetterConversion): Same here
31704 (Invocation::ConversionExists): Ditto.
31706 (Invocation::ConversionExists): Implement.
31708 2001-09-22 Ravi Pratap <ravi@ximian.com>
31710 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
31711 Also take an additional TypeContainer argument.
31713 * All over : Pass in TypeContainer as argument to OverloadResolve.
31715 * typemanager.cs (CSharpName): Update to check for the string type and return
31718 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
31721 2001-09-21 Ravi Pratap <ravi@ximian.com>
31723 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
31724 (Invocation::BetterFunction): Implement.
31725 (Invocation::BetterConversion): Implement.
31726 (Invocation::ConversionExists): Skeleton, no implementation yet.
31728 Okay, things work fine !
31730 2001-09-21 Miguel de Icaza <miguel@ximian.com>
31732 * typemanager.cs: declare and load enum_type, delegate_type and
31735 * expression.cs (Expression::Emit): Now emit returns a value that
31736 tells whether a value is left on the stack or not. This strategy
31737 might be reveted tomorrow with a mechanism that would address
31738 multiple assignments.
31739 (Expression::report118): Utility routine to report mismatches on
31742 (Unary::Report23): Report impossible type/operator combination
31745 (Unary::IsIncrementableNumber): Whether the type can be
31746 incremented or decremented with add.
31747 (Unary::ResolveOperator): Also allow enumerations to be bitwise
31749 (Unary::ResolveOperator): Implement ++, !, ~,
31751 (Invocation::Emit): Deal with new Emit convetion.
31753 * All Expression derivatives: Updated their Emit method to return
31754 whether they leave values on the stack or not.
31756 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
31757 stack for expressions that are statements.
31759 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31761 * expression.cs (LValue): New interface. Must be implemented by
31763 (LocalVariableReference, ParameterReference, FieldExpr): Implement
31766 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
31767 interface for generating code, simplifies the code.
31769 2001-09-20 Ravi Pratap <ravi@ximian.com>
31771 * expression.cs (everywhere): Comment out return statements in ::Resolve
31772 methods to avoid the warnings.
31774 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31776 * driver.cs (parse): Report error 2001 if we can not open the
31779 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
31782 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
31785 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
31786 otherwise nested blocks end up with the same index.
31788 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
31790 * expression.cs: Instead of having FIXMEs in the Resolve
31791 functions, throw exceptions so it is obvious that we are facing a
31794 * cs-parser.jay (invocation_expression): Pass Location information.
31796 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
31797 Use a basename for those routines because .NET does not like paths
31800 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
31803 2001-09-19 Miguel de Icaza <miguel@ximian.com>
31805 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
31806 are loading the correct data types (throws an exception if not).
31807 (TypeManager::InitCoreTypes): Use CoreLookupType
31809 * expression.cs (Unary::ResolveOperator): return the child
31810 expression for expressions which are just +expr.
31811 (Unary::ResolveOperator): Return negative literals for -LITERAL
31812 expressions (otherwise they are Unary {Literal}).
31813 (Invocation::Badness): Take into account `Implicit constant
31814 expression conversions'.
31816 * literal.cs (LongLiteral): Implement long literal class.
31817 (IntLiteral): export the `Value' of the intliteral.
31819 2001-09-19 Ravi Pratap <ravi@ximian.com>
31821 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
31823 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
31824 instead of 'Operator'
31826 * expression.cs (Binary::ResolveOperator): Update accordingly.
31827 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
31830 * cs-parser.jay (unary_expression): Update to use the new names.
31832 * gen-treedump.cs (GetUnary): Same here.
31834 * expression.cs (Unary::Resolve): Implement.
31835 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
31836 operators are found instead of making noise ;-)
31837 (Unary::ResolveOperator): New method to do precisely the same thing which
31838 Binary::ResolveOperator does for Binary expressions.
31839 (Unary.method, .Arguments): Add.
31840 (Unary::OperName): Implement.
31841 (Unary::ForceConversion): Copy and Paste !
31843 * class.cs (Operator::Define): Fix a small bug for the case when we have
31846 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
31847 for the inbuilt operators. Only overloading works for now ;-)
31849 2001-09-18 Miguel de Icaza <miguel@ximian.com>
31851 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
31852 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
31854 * expression.cs (This::Emit): Implement.
31855 (This::Resolve): Implement.
31856 (TypeOf:Resolve): Implement.
31857 (Expression::ResolveSimpleName): Add an implicit this to instance
31859 (MemberAccess::Resolve): Deal with Parameters and Fields.
31860 Bind instance variable to Field expressions.
31861 (FieldExpr::Instance): New field used to track the expression that
31862 represents the object instance.
31863 (FieldExpr::Resolve): Track potential errors from MemberLookup not
31865 (FieldExpr::Emit): Implement.
31867 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
31868 the last instruction contains a return opcode to avoid generating
31869 the last `ret' instruction (this generates correct code, and it is
31870 nice to pass the peverify output).
31872 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
31873 initializer for static and instance variables.
31874 (Constructor::Emit): Allow initializer to be null in the case of
31875 static constructors. Only emit initializer for instance
31878 (TypeContainer::FindMembers): Return a null array if there are no
31881 Also fix the code for the MemberTypes.Method branch, as it was not
31882 scanning that for operators (or tried to access null variables before).
31884 * assign.cs (Assign::Emit): Handle instance and static fields.
31888 * driver.cs: Stop compilation if there are parse errors.
31890 * cs-parser.jay (constructor_declaration): Provide default base
31891 initializer for non-static constructors.
31892 (constructor_declarator): Do not provide a default base
31893 initializers if none was specified.
31894 Catch the fact that constructors should not have parameters.
31896 * class.cs: Do not emit parent class initializers for static
31897 constructors, that should be flagged as an error.
31899 2001-09-18 Ravi Pratap <ravi@ximian.com>
31901 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
31902 Move back code into TypeContainer::Populate.
31904 2001-09-18 Ravi Pratap <ravi@ximian.com>
31906 * class.cs (TypeContainer::AddConstructor): Fix the check to
31907 compare against Name, not Basename.
31908 (Operator::OpType): Change Plus and Minus to Add and Subtract.
31910 * cs-parser.jay : Update accordingly.
31912 * class.cs (TypeContainer::FindMembers): For the case where we are searching
31913 for methods, don't forget to look into the operators too.
31914 (RegisterMethodBuilder): Helper method to take care of this for
31915 methods, constructors and operators.
31916 (Operator::Define): Completely revamp.
31917 (Operator.OperatorMethod, MethodName): New fields.
31918 (TypeContainer::Populate): Move the registering of builders into
31919 RegisterMethodBuilder.
31920 (Operator::Emit): Re-write.
31922 * expression.cs (Binary::Emit): Comment out code path to emit method
31923 invocation stuff for the case when we have a user defined operator. I am
31924 just not able to get it right !
31926 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31928 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
31931 (Expression::MemberLookup): Provide a version that allows to
31932 specify the MemberTypes and BindingFlags.
31934 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
31935 so it was not fetching variable information from outer blocks.
31937 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
31938 Beforefieldinit as it was buggy.
31940 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
31941 that Ravi put here.
31943 * class.cs (Constructor::Emit): Only emit if block is not null.
31944 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
31945 deal with this by semantically definining it as if the user had
31948 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
31949 constructors as we now "emit" them at a higher level.
31951 (TypeContainer::DefineDefaultConstructor): Used to define the
31952 default constructors if none was provided.
31954 (ConstructorInitializer): Add methods Resolve and Emit.
31956 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
31958 2001-09-17 Ravi Pratap <ravi@ximian.com>
31960 * class.cs (TypeContainer::EmitDefaultConstructor): Register
31961 the default constructor builder with our hashtable for methodbuilders
31964 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
31965 and argument_count is 0 in which case we have a match.
31966 (Binary::ResolveOperator): More null checking and miscellaneous coding
31969 2001-09-17 Ravi Pratap <ravi@ximian.com>
31971 * rootcontext.cs (IsNameSpace): Compare against null.
31973 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
31975 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
31976 and Unary::Operator.
31978 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
31981 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
31982 we have overloaded operators.
31983 (Binary::ResolveOperator): Implement the part which does the operator overload
31986 * class.cs (Operator::Emit): Implement.
31987 (TypeContainer::Emit): Emit the operators we have too.
31989 * expression.cs (Binary::Emit): Update to emit the appropriate code for
31990 the case when we have a user-defined operator.
31992 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31994 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
31996 2001-09-16 Ravi Pratap <ravi@ximian.com>
31998 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
31999 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32000 (Constructor::Emit): Implement.
32001 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32002 if we have no work to do.
32003 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32006 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32007 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32009 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32012 2001-09-15 Ravi Pratap <ravi@ximian.com>
32014 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32016 (Tree::RecordNamespace): Method to do what the name says ;-)
32017 (Tree::Namespaces): Property to get at the namespaces hashtable.
32019 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32022 * rootcontext.cs (IsNamespace): Fixed it :-)
32024 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32026 * class.cs (TypeContainer::FindMembers): Add support for
32028 (MethodCore): New class that encapsulates both the shared aspects
32029 of a Constructor and a Method.
32030 (Method, Constructor): Factored pieces into MethodCore.
32032 * driver.cs: Added --fatal which makes errors throw exceptions.
32033 Load System assembly as well as part of the standard library.
32035 * report.cs: Allow throwing exceptions on errors for debugging.
32037 * modifiers.cs: Do not use `parent', instead use the real type
32038 container to evaluate permission settings.
32040 * class.cs: Put Ravi's patch back in. He is right, and we will
32041 have to cope with the
32043 2001-09-14 Ravi Pratap <ravi@ximian.com>
32045 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32046 FamORAssem, not FamANDAssem.
32048 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32050 * driver.cs: Added --parse option that only parses its input files
32053 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32054 incorrect. IsTopLevel is not used to tell whether an object is
32055 root_types or not (that can be achieved by testing this ==
32056 root_types). But to see if this is a top-level *class* (not
32057 necessarly our "toplevel" container).
32059 2001-09-14 Ravi Pratap <ravi@ximian.com>
32061 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32062 parent instead of a direct call to GetType.
32064 2001-09-14 Ravi Pratap <ravi@ximian.com>
32066 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32067 Modifiers.TypeAttr. This should just be a call to that method.
32069 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32070 object so that we can determine if we are top-level or not.
32072 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32075 * enum.cs (Enum::Define): Ditto.
32077 * modifiers.cs (FieldAttr): Re-write.
32079 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32080 (TypeContainer::HaveStaticConstructor): New property to provide access
32081 to precisely that info.
32083 * modifiers.cs (MethodAttr): Re-write.
32084 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32086 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32087 of top-level types as claimed.
32089 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32091 * expression.cs (MemberLookup): Fruitless attempt to lookup
32092 constructors. Maybe I need to emit default constructors? That
32093 might be it (currently .NET emits this for me automatically).
32094 (Invocation::OverloadResolve): Cope with Arguments == null.
32095 (Invocation::EmitArguments): new function, shared by the new
32096 constructor and us.
32097 (Invocation::Emit): Handle static and instance methods. Emit
32098 proper call instruction for virtual or non-virtual invocations.
32099 (New::Emit): Implement.
32100 (New::Resolve): Implement.
32101 (MemberAccess:Resolve): Implement.
32102 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32103 to track instances.
32104 (FieldExpr::Resolve): Set type.
32106 * support.cs: Handle empty arguments.
32108 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32109 SimpleLookup): Auxiliary routines to help parse a qualifier
32112 Update qualifier_identifier rule.
32114 * codegen.cs: Removed debugging messages.
32116 * class.cs: Make this a global thing, this acts just as a "key" to
32117 objects that we might have around.
32119 (Populate): Only initialize method_builders_to_methods once.
32121 * expression.cs (PropertyExpr): Initialize type from the
32124 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32125 Resolve pattern. Attempt to implicitly convert value to boolean.
32128 * expression.cs: Set the type for the int32/int32 argument case.
32129 (Binary::ResolveOperator): Set the return type to boolean for
32130 comparission operators
32132 * typemanager.cs: Remove debugging print code.
32134 (Invocation::Resolve): resolve type.
32136 * class.cs: Allocate a MemberInfo of the correct size, as the code
32137 elsewhere depends on the test to reflect the correct contents.
32139 (Method::) Keep track of parameters, due to System.Reflection holes
32141 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32144 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32145 of the exact size and return that.
32147 (Class::LookupMethodByBuilder): New function that maps
32148 MethodBuilders to its methods. Required to locate the information
32149 on methods because System.Reflection bit us again.
32151 * support.cs: New file, contains an interface ParameterData and
32152 two implementations: ReflectionParameters and InternalParameters
32153 used to access Parameter information. We will need to grow this
32156 * expression.cs (Invocation::GetParameterData): implement a cache
32157 and a wrapper around the ParameterData creation for methods.
32158 (Invocation::OverloadResolve): Use new code.
32160 2001-09-13 Ravi Pratap <ravi@ximian.com>
32162 * class.cs (TypeContainer::EmitField): Remove and move into
32163 (Field::Define): here and modify accordingly.
32164 (Field.FieldBuilder): New member.
32165 (TypeContainer::Populate): Update accordingly.
32166 (TypeContainer::FindMembers): Implement.
32168 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32170 * statement.cs: (VariableInfo::VariableType): New field to be
32171 initialized with the full type once it is resolved.
32173 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32175 * parameter.cs (GetParameterInfo): Use a type cache to compute
32176 things only once, and to reuse this information
32178 * expression.cs (LocalVariableReference::Emit): Implement.
32179 (OpcodeCast::Emit): fix.
32181 (ParameterReference::Resolve): Implement.
32182 (ParameterReference::Emit): Implement.
32184 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32185 that are expressions need to stay as Expressions.
32187 * typemanager.cs (CSharpName): Returns the C# name of a type if
32190 * expression.cs (Expression::ConvertImplicit): New function that
32191 implements implicit type conversions.
32193 (Expression::ImplicitReferenceConversion): Implements implicit
32194 reference conversions.
32196 (EmptyCast): New type for transparent casts.
32198 (OpcodeCast): New type for casts of types that are performed with
32199 a sequence of bytecodes.
32201 (BoxedCast): New type used for casting value types into reference
32202 types. Emits a box opcode.
32204 (Binary::DoNumericPromotions): Implements numeric promotions of
32205 and computation of the Binary::Type.
32207 (Binary::EmitBranchable): Optimization.
32209 (Binary::Emit): Implement code emission for expressions.
32211 * typemanager.cs (TypeManager): Added two new core types: sbyte
32214 2001-09-12 Ravi Pratap <ravi@ximian.com>
32216 * class.cs (TypeContainer::FindMembers): Method which does exactly
32217 what Type.FindMembers does, only we don't have to use reflection. No
32218 implementation yet.
32220 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32221 typecontainer objects as we need to get at them.
32222 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32224 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32225 typecontainer object.
32227 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32228 of just a Report object.
32230 2001-09-11 Ravi Pratap <ravi@ximian.com>
32232 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32234 (TypeContainer::Populate): Now define the delegates of the type too.
32235 (TypeContainer.Delegates): Property to access the list of delegates defined
32238 * delegates.cs (Delegate::Define): Implement partially.
32240 * modifiers.cs (TypeAttr): Handle more flags.
32242 2001-09-11 Ravi Pratap <ravi@ximian.com>
32244 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32246 (Operator::Define): Re-write logic to get types by using the LookupType method
32247 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32248 (Indexer::Define): Ditto.
32249 (Event::Define): Ditto.
32250 (Property::Define): Ditto.
32252 2001-09-10 Ravi Pratap <ravi@ximian.com>
32254 * class.cs (TypeContainer::Populate): Now define operators too.
32255 (TypeContainer.Operators): New property to access the list of operators
32257 (Operator.OperatorMethodBuilder): New member to hold the method builder
32258 for the operator we are defining.
32259 (Operator::Define): Implement.
32261 2001-09-10 Ravi Pratap <ravi@ximian.com>
32263 * class.cs (Event::Define): Make the prefixes of the accessor methods
32264 addOn_ and removeOn_
32266 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32267 of the location being passed in too. Ideally, this should go later since all
32268 error reporting should be done through the Report object.
32270 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32271 (Populate): Iterate thru the indexers we have and define them too.
32272 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32273 for the get and set accessors.
32274 (Indexer::Define): Implement.
32276 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32278 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32279 my previous implementation, did not work.
32281 * typemanager.cs: Add a couple of missing types (the longs).
32283 * literal.cs: Use TypeManager.bool_type instead of getting it.
32285 * expression.cs (EventExpr): New kind of expressions.
32286 (Expressio::ExprClassFromMemberInfo): finish
32288 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32290 * assign.cs: Emit stores to static fields differently.
32292 2001-09-08 Ravi Pratap <ravi@ximian.com>
32294 * Merge in changes and adjust code to tackle conflicts. Backed out my
32295 code in Assign::Resolve ;-)
32297 2001-09-08 Ravi Pratap <ravi@ximian.com>
32299 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32300 instead Report.Error and also pass in the location.
32301 (CSharpParser::Lexer): New readonly property to return the reference
32302 to the Tokenizer object.
32303 (declare_local_variables): Use Report.Error with location instead of plain
32307 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32308 (Operator.CheckBinaryOperator): Ditto.
32310 * cs-parser.jay (operator_declarator): Update accordingly.
32312 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32313 (CheckBinaryOperator): Same here.
32315 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32316 on the name without any prefixes of namespace names etc. This is because we
32317 already might have something already fully qualified like
32318 'System.Console.WriteLine'
32320 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32322 2001-09-07 Ravi Pratap <ravi@ximian.com>
32324 * cs-tokenizer.cs (location): Return a string which also contains
32327 * expression.cs (ElementAccess): New class for expressions of the
32328 type 'element access.'
32329 (BaseAccess): New class for expressions of the type 'base access.'
32330 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32333 * cs-parser.jay (element_access): Implement action.
32334 (base_access): Implement actions.
32335 (checked_expression, unchecked_expression): Implement.
32337 * cs-parser.jay (local_variable_type): Correct and implement.
32338 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32340 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32342 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32343 name and the specifiers.
32345 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32347 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32348 making them all public ;-)
32350 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32353 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32355 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32357 (FieldExpr, PropertyExprs): New resolved expressions.
32358 (SimpleName::MemberStaticCheck): Perform static checks for access
32359 to non-static fields on static methods. Maybe this should be
32360 generalized for MemberAccesses.
32361 (SimpleName::ResolveSimpleName): More work on simple name
32364 * cs-parser.jay (primary_expression/qualified_identifier): track
32365 the parameter index.
32367 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32368 (EmitContext::EmitBoolExpression): Chain to expression generation
32369 instead of temporary hack.
32370 (::EmitStatementExpression): Put generic expression code generation.
32372 * assign.cs (Assign::Emit): Implement variable assignments to
32373 local variables, parameters and fields.
32375 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32377 * statement.cs (Block::GetVariableInfo): New method, returns the
32378 VariableInfo for a variable name in a block.
32379 (Block::GetVariableType): Implement in terms of GetVariableInfo
32381 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32382 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32384 2001-09-06 Ravi Pratap <ravi@ximian.com>
32386 * cs-parser.jay (operator_declaration): Continue on my quest : update
32387 to take attributes argument.
32388 (event_declaration): Ditto.
32389 (enum_declaration): Ditto.
32390 (indexer_declaration): Ditto.
32392 * class.cs (Operator::Operator): Update constructor accordingly.
32393 (Event::Event): Ditto.
32395 * delegate.cs (Delegate::Delegate): Same here.
32397 * enum.cs (Enum::Enum): Same here.
32399 2001-09-05 Ravi Pratap <ravi@ximian.com>
32401 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32403 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32405 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32406 being passed around as an arraylist.
32407 (Attributes::AddAttribute): Method to add attribute sections.
32409 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32410 (struct_declaration): Update accordingly.
32411 (constant_declaration): Update.
32412 (field_declaration): Update.
32413 (method_header): Update.
32414 (fixed_parameter): Update.
32415 (parameter_array): Ditto.
32416 (property_declaration): Ditto.
32417 (destructor_declaration): Ditto.
32419 * class.cs (Struct::Struct): Update constructors accordingly.
32420 (Class::Class): Ditto.
32421 (Field::Field): Ditto.
32422 (Method::Method): Ditto.
32423 (Property::Property): Ditto.
32424 (TypeContainer::OptAttribute): update property's return type.
32426 * interface.cs (Interface.opt_attributes): New member.
32427 (Interface::Interface): Update to take the extra Attributes argument.
32429 * parameter.cs (Parameter::Parameter): Ditto.
32431 * constant.cs (Constant::Constant): Ditto.
32433 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32434 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32435 the attributes as a parameter.
32436 (InterfaceProperty): Update constructor call.
32437 (InterfaceEvent): Ditto.
32438 (InterfaceMethod): Ditto.
32439 (InterfaceIndexer): Ditto.
32441 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32442 pass the attributes too.
32443 (interface_event_declaration): Ditto.
32444 (interface_property_declaration): Ditto.
32445 (interface_method_declaration): Ditto.
32446 (interface_declaration): Ditto.
32448 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32450 * class.cs (Method::Define): Track the "static Main" definition to
32451 create an entry point.
32453 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32454 EntryPoint if we find it.
32456 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32457 (EmitContext::ig): Make this variable public.
32459 * driver.cs: Make the default output file be the first file name
32460 with the .exe extension.
32462 Detect empty compilations
32464 Handle various kinds of output targets. Handle --target and
32465 rename -t to --dumper.
32467 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32468 methods inherited from Expression return now an Expression. This
32469 will is used during the tree rewriting as we resolve them during
32472 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32473 the spec. Missing entirely is the information about
32474 accessability of elements of it.
32476 (Expression::ExprClassFromMemberInfo): New constructor for
32477 Expressions that creates a fully initialized Expression based on
32478 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32481 (Invocation::Resolve): Begin implementing resolution of invocations.
32483 * literal.cs (StringLiteral): Implement Emit.
32485 2001-09-05 Ravi Pratap <ravi@ximian.com>
32487 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32490 2001-09-04 Ravi Pratap <ravi@ximian.com>
32492 * cs-parser.jay (attribute_arguments): Implement actions.
32493 (attribute): Fix bug in production. Implement action.
32494 (attribute_list): Implement.
32495 (attribute_target): Implement.
32496 (attribute_target_specifier, opt_target_specifier): Implement
32497 (CheckAttributeTarget): New method to check if the attribute target
32499 (attribute_section): Implement.
32500 (opt_attributes): Implement.
32502 * attribute.cs : New file to handle attributes.
32503 (Attribute): Class to hold attribute info.
32505 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32506 (attribute_section): Modify production to use 2 different rules to
32507 achieve the same thing. 1 s/r conflict down !
32508 Clean out commented, useless, non-reducing dimension_separator rules.
32510 * class.cs (TypeContainer.attributes): New member to hold list
32511 of attributes for a type.
32512 (Struct::Struct): Modify to take one more argument, the attribute list.
32513 (Class::Class): Ditto.
32514 (Field::Field): Ditto.
32515 (Method::Method): Ditto.
32516 (Property::Property): Ditto.
32518 * cs-parser.jay (struct_declaration): Update constructor call to
32519 pass in the attributes too.
32520 (class_declaration): Ditto.
32521 (constant_declaration): Ditto.
32522 (field_declaration): Ditto.
32523 (method_header): Ditto.
32524 (fixed_parameter): Ditto.
32525 (parameter_array): Ditto.
32526 (property_declaration): Ditto.
32528 * constant.cs (Constant::Constant): Update constructor similarly.
32529 Use System.Collections.
32531 * parameter.cs (Parameter::Parameter): Update as above.
32533 2001-09-02 Ravi Pratap <ravi@ximian.com>
32535 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32536 (TypeContainer.delegates): New member to hold list of delegates.
32538 * cs-parser.jay (delegate_declaration): Implement the action correctly
32539 this time as I seem to be on crack ;-)
32541 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32543 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32544 tell whether an identifier represents a namespace.
32546 * expression.cs (NamespaceExpr): A namespace expression, used only
32547 temporarly during expression resolution.
32548 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32549 utility functions to resolve names on expressions.
32551 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32553 * codegen.cs: Add hook for StatementExpressions.
32555 * class.cs: Fix inverted test for static flag in methods.
32557 2001-09-02 Ravi Pratap <ravi@ximian.com>
32559 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32560 to make it coincide with MS' number.
32561 (Operator::CheckBinaryOperator): Ditto.
32563 * ../errors/errors.txt : Remove error numbers added earlier.
32565 * ../errors/cs1019.cs : Test case for error # 1019
32567 * ../errros/cs1020.cs : Test case for error # 1020
32569 * cs-parser.jay : Clean out commented cruft.
32570 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32571 used anywhere - non-reducing rule.
32572 (namespace_declarations): Non-reducing rule - comment out.
32574 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32575 with TypeContainer::AddEnum.
32577 * delegate.cs : New file for delegate handling classes.
32578 (Delegate): Class for declaring delegates.
32580 * makefile : Update.
32582 * cs-parser.jay (delegate_declaration): Implement.
32584 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
32586 * class.cs (Event::Define): Implement.
32587 (Event.EventBuilder): New member.
32589 * class.cs (TypeContainer::Populate): Update to define all enums and events
32591 (Events): New property for the events arraylist we hold. Shouldn't we move to using
32592 readonly fields for all these cases ?
32594 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32596 * class.cs (Property): Revamp to use the convention of making fields readonly.
32597 Accordingly modify code elsewhere.
32599 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
32600 the Define method of the Property class.
32602 * class.cs : Clean up applied patch and update references to variables etc. Fix
32604 (TypeContainer::Populate): Update to define all the properties we have. Also
32605 define all enumerations.
32607 * enum.cs (Define): Implement.
32609 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32611 * cs-parser.jay (overloadable_operator): The semantic value is an
32612 enum of the Operator class.
32613 (operator_declarator): Implement actions.
32614 (operator_declaration): Implement.
32616 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
32617 validity of definitions.
32618 (Operator::CheckBinaryOperator): Static method to check for binary operators
32619 (TypeContainer::AddOperator): New method to add an operator to a type.
32621 * cs-parser.jay (indexer_declaration): Added line to actually call the
32622 AddIndexer method so it gets added ;-)
32624 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
32625 already taken care of by the MS compiler ?
32627 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32629 * class.cs (Operator): New class for operator declarations.
32630 (Operator::OpType): Enum for the various operators.
32632 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32634 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
32635 ostensibly handle this in semantic analysis.
32637 * cs-parser.jay (general_catch_clause): Comment out
32638 (specific_catch_clauses, specific_catch_clause): Ditto.
32639 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
32640 (catch_args, opt_catch_args): New productions.
32641 (catch_clause): Rewrite to use the new productions above
32642 (catch_clauses): Modify accordingly.
32643 (opt_catch_clauses): New production to use in try_statement
32644 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
32645 and re-write the code in the actions to extract the specific and
32646 general catch clauses by being a little smart ;-)
32648 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
32649 Hooray, try and catch statements parse fine !
32651 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32653 * statement.cs (Block::GetVariableType): Fix logic to extract the type
32654 string from the hashtable of variables.
32656 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
32657 I end up making that mistake ;-)
32658 (catch_clauses): Fixed gross error which made Key and Value of the
32659 DictionaryEntry the same : $1 !!
32661 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32663 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
32665 * cs-parser.jay (event_declaration): Correct to remove the semicolon
32666 when the add and remove accessors are specified.
32668 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32670 * cs-parser.jay (IndexerDeclaration): New helper class to hold
32671 information about indexer_declarator.
32672 (indexer_declarator): Implement actions.
32673 (parsing_indexer): New local boolean used to keep track of whether
32674 we are parsing indexers or properties. This is necessary because
32675 implicit_parameters come into picture even for the get accessor in the
32676 case of an indexer.
32677 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
32679 * class.cs (Indexer): New class for indexer declarations.
32680 (TypeContainer::AddIndexer): New method to add an indexer to a type.
32681 (TypeContainer::indexers): New member to hold list of indexers for the
32684 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32686 * cs-parser.jay (add_accessor_declaration): Implement action.
32687 (remove_accessor_declaration): Implement action.
32688 (event_accessors_declaration): Implement
32689 (variable_declarators): swap statements for first rule - trivial.
32691 * class.cs (Event): New class to hold information about event
32693 (TypeContainer::AddEvent): New method to add an event to a type
32694 (TypeContainer::events): New member to hold list of events.
32696 * cs-parser.jay (event_declaration): Implement actions.
32698 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32700 * cs-parser.jay (dim_separators): Implement. Make it a string
32701 concatenating all the commas together, just as they appear.
32702 (opt_dim_separators): Modify accordingly
32703 (rank_specifiers): Update accordingly. Basically do the same
32704 thing - instead, collect the brackets here.
32705 (opt_rank_sepcifiers): Modify accordingly.
32706 (array_type): Modify to actually return the complete type string
32707 instead of ignoring the rank_specifiers.
32708 (expression_list): Implement to collect the expressions
32709 (variable_initializer): Implement. We make it a list of expressions
32710 essentially so that we can handle the array_initializer case neatly too.
32711 (variable_initializer_list): Implement.
32712 (array_initializer): Make it a list of variable_initializers
32713 (opt_array_initializer): Modify accordingly.
32715 * expression.cs (New::NType): Add enumeration to help us
32716 keep track of whether we have an object/delegate creation
32717 or an array creation.
32718 (New:NewType, New::Rank, New::Indices, New::Initializers): New
32719 members to hold data about array creation.
32720 (New:New): Modify to update NewType
32721 (New:New): New Overloaded contructor for the array creation
32724 * cs-parser.jay (array_creation_expression): Implement to call
32725 the overloaded New constructor.
32727 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
32729 * class.cs (TypeContainer::Constructors): Return member
32730 constructors instead of returning null.
32732 2001-08-26 Miguel de Icaza <miguel@ximian.com>
32734 * typemanager.cs (InitCoreTypes): Initialize the various core
32735 types after we have populated the type manager with the user
32736 defined types (this distinction will be important later while
32737 compiling corlib.dll)
32739 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
32740 on Expression Classification. Now all expressions have a method
32741 `Resolve' and a method `Emit'.
32743 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
32744 generation from working. Also add some temporary debugging
32747 2001-08-24 Miguel de Icaza <miguel@ximian.com>
32749 * codegen.cs: Lots of code generation pieces. This is only the
32750 beginning, will continue tomorrow with more touches of polish. We
32751 handle the fundamentals of if, while, do, for, return. Others are
32752 trickier and I need to start working on invocations soon.
32754 * gen-treedump.cs: Bug fix, use s.Increment here instead of
32757 * codegen.cs (EmitContext): New struct, used during code
32758 emission to keep a context. Most of the code generation will be
32761 * cs-parser.jay: Add embedded blocks to the list of statements of
32762 this block. So code generation proceeds in a top down fashion.
32764 2001-08-23 Miguel de Icaza <miguel@ximian.com>
32766 * statement.cs: Add support for multiple child blocks.
32768 2001-08-22 Miguel de Icaza <miguel@ximian.com>
32770 * codegen.cs (EmitCode): New function, will emit the code for a
32771 Block of code given a TypeContainer and its ILGenerator.
32773 * statement.cs (Block): Standard public readonly optimization.
32774 (Block::Block constructors): Link children.
32775 (Block::Child): Child Linker.
32776 (Block::EmitVariables): Emits IL variable declarations.
32778 * class.cs: Drop support for MethodGroups here, delay until
32780 (Method::): Applied the same simplification that I did before, and
32781 move from Properties to public readonly fields.
32782 (Method::ParameterTypes): Returns the parameter types for the
32783 function, and implements a cache that will be useful later when I
32784 do error checking and the semantic analysis on the methods is
32786 (Constructor::GetCallingConvention): Renamed from CallingConvetion
32787 and made a method, optional argument tells whether this is a class
32788 or a structure to apply the `has-this' bit.
32789 (Method::GetCallingConvention): Implement, returns the calling
32791 (Method::Define): Defines the type, a second pass is performed
32792 later to populate the methods.
32794 (Constructor::ParameterTypes): implement a cache similar to the
32795 one on Method::ParameterTypes, useful later when we do semantic
32798 (TypeContainer::EmitMethod): New method. Emits methods.
32800 * expression.cs: Removed MethodGroup class from here.
32802 * parameter.cs (Parameters::GetCallingConvention): new method.
32804 2001-08-21 Miguel de Icaza <miguel@ximian.com>
32806 * class.cs (TypeContainer::Populate): Drop RootContext from the
32809 (Constructor::CallingConvention): Returns the calling convention.
32810 (Constructor::ParameterTypes): Returns the constructor parameter
32813 (TypeContainer::AddConstructor): Keep track of default constructor
32814 and the default static constructor.
32816 (Constructor::) Another class that starts using `public readonly'
32817 instead of properties.
32819 (Constructor::IsDefault): Whether this is a default constructor.
32821 (Field::) use readonly public fields instead of properties also.
32823 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
32824 track of static constructors; If none is used, turn on
32825 BeforeFieldInit in the TypeAttributes.
32827 * cs-parser.jay (opt_argument_list): now the return can be null
32828 for the cases where there are no arguments.
32830 (constructor_declarator): If there is no implicit `base' or
32831 `this', then invoke the default parent constructor.
32833 * modifiers.cs (MethodAttr): New static function maps a set of
32834 modifiers flags into a MethodAttributes enum
32835 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
32836 MethodAttr, TypeAttr to represent the various mappings where the
32837 modifiers are used.
32838 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
32840 2001-08-19 Miguel de Icaza <miguel@ximian.com>
32842 * parameter.cs (GetParameterInfo): Fix bug where there would be no
32845 * interface.cs (PopulateIndexer): Implemented the code generator
32846 for interface indexers.
32848 2001-08-17 Miguel de Icaza <miguel@ximian.com>
32850 * interface.cs (InterfaceMemberBase): Now we track the new status
32853 (PopulateProperty): Implement property population. Woohoo! Got
32854 Methods and Properties going today.
32856 Removed all the properties for interfaces, and replaced them with
32857 `public readonly' fields.
32859 2001-08-16 Miguel de Icaza <miguel@ximian.com>
32861 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
32862 initialize their hashtables/arraylists only when they are needed
32863 instead of doing this always.
32865 * parameter.cs: Handle refs and out parameters.
32867 * cs-parser.jay: Use an ArrayList to construct the arguments
32868 instead of the ParameterCollection, and then cast that to a
32871 * parameter.cs: Drop the use of ParameterCollection and use
32872 instead arrays of Parameters.
32874 (GetParameterInfo): Use the Type, not the Name when resolving
32877 2001-08-13 Miguel de Icaza <miguel@ximian.com>
32879 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
32880 and instead use public readonly fields.
32882 * class.cs: Put back walking code for type containers.
32884 2001-08-11 Miguel de Icaza <miguel@ximian.com>
32886 * class.cs (MakeConstant): Code to define constants.
32888 * rootcontext.cs (LookupType): New function. Used to locate types
32891 2001-08-08 Miguel de Icaza <miguel@ximian.com>
32893 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
32894 this System.Reflection code is. Kudos to Microsoft
32896 * typemanager.cs: Implement a type cache and avoid loading all
32897 types at boot time. Wrap in LookupType the internals. This made
32898 the compiler so much faster. Wow. I rule!
32900 * driver.cs: Make sure we always load mscorlib first (for
32901 debugging purposes, nothing really important).
32903 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
32904 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
32906 * rootcontext.cs: Lookup types on their namespace; Lookup types
32907 on namespaces that have been imported using the `using' keyword.
32909 * class.cs (TypeContainer::TypeAttr): Virtualize.
32910 (Class::TypeAttr): Return attributes suitable for this bad boy.
32911 (Struct::TypeAttr): ditto.
32912 Handle nested classes.
32913 (TypeContainer::) Remove all the type visiting code, it is now
32914 replaced with the rootcontext.cs code
32916 * rootcontext.cs (GetClassBases): Added support for structs.
32918 2001-08-06 Miguel de Icaza <miguel@ximian.com>
32920 * interface.cs, statement.cs, class.cs, parameter.cs,
32921 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
32922 Drop use of TypeRefs, and use strings instead.
32924 2001-08-04 Miguel de Icaza <miguel@ximian.com>
32928 * class.cs (Struct::Struct): set the SEALED flags after
32929 checking the modifiers.
32930 (TypeContainer::TypeAttr): new property, returns the
32931 TypeAttributes for a class.
32933 * cs-parser.jay (type_list): Oops, list production was creating a
32934 new list of base types.
32936 * rootcontext.cs (StdLib): New property.
32937 (GetInterfaceTypeByName): returns an interface by type name, and
32938 encapsulates error handling here.
32939 (GetInterfaces): simplified.
32940 (ResolveTree): Encapsulated all the tree resolution here.
32941 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
32944 * driver.cs: Add support for --nostdlib, to avoid loading the
32945 default assemblies.
32946 (Main): Do not put tree resolution here.
32948 * rootcontext.cs: Beginning of the class resolution.
32950 2001-08-03 Miguel de Icaza <miguel@ximian.com>
32952 * rootcontext.cs: Provide better error reporting.
32954 * cs-parser.jay (interface_base): set our $$ to be interfaces.
32956 * rootcontext.cs (CreateInterface): Handle the case where there
32957 are no parent interfaces.
32959 (CloseTypes): Routine to flush types at the end.
32960 (CreateInterface): Track types.
32961 (GetInterfaces): Returns an array of Types from the list of
32962 defined interfaces.
32964 * typemanager.c (AddUserType): Mechanism to track user types (puts
32965 the type on the global type hash, and allows us to close it at the
32968 2001-08-02 Miguel de Icaza <miguel@ximian.com>
32970 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
32971 RecordInterface instead.
32973 * cs-parser.jay: Updated to reflect changes above.
32975 * decl.cs (Definition): Keep track of the TypeBuilder type that
32976 represents this type here. Not sure we will use it in the long
32977 run, but wont hurt for now.
32979 * driver.cs: Smaller changes to accomodate the new code.
32981 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
32984 * rootcontext.cs (CreateInterface): New method, used to create
32985 the System.TypeBuilder type for interfaces.
32986 (ResolveInterfaces): new entry point to resolve the interface
32988 (CodeGen): Property, used to keep track of the code generator.
32990 2001-07-26 Miguel de Icaza <miguel@ximian.com>
32992 * cs-parser.jay: Add a second production for delegate_declaration
32995 (enum_body): Put an opt_comma here instead of putting it on
32996 enum_body or enum_member_declarations so we can handle trailing
32997 commas on enumeration members. Gets rid of a shift/reduce.
32999 (type_list): Need a COMMA in the middle.
33001 (indexer_declaration): Tell tokenizer to recognize get/set
33003 * Remove old targets.
33005 * Re-add the parser target.
33007 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33009 * cs-parser.jay: Add precendence rules for a number of operators
33010 ot reduce the number of shift/reduce conflicts in the grammar.
33012 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33014 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33017 Get rid of old crufty code.
33019 * rootcontext.cs: Use this to keep track of the parsed
33020 representation and the defined types available to the program.
33022 * gen-treedump.cs: adjust for new convention.
33024 * type.cs: Split out the type manager, and the assembly builder
33027 * typemanager.cs: the type manager will live here now.
33029 * cil-codegen.cs: And the code generator here.
33031 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33033 * makefile: Fixed up for easy making.
33035 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33037 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33040 (unary_expression): Expand pre_increment_expression and
33041 post_decrement_expression to reduce a shift/reduce.
33043 2001-07-11 Simon Cozens
33045 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33047 Improve allow_keyword_as_indent name.
33049 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33051 * Adjustments for Beta2.
33053 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33055 * decl.cs: Added `Define' abstract method.
33056 (InTransit): new property, used to catch recursive definitions.
33058 * interface.cs: Implement `Define'.
33060 * modifiers.cs: Map Modifiers.constants to
33061 System.Reflection.TypeAttribute flags.
33063 * class.cs: Keep track of types and user-defined types.
33064 (BuilderInit): New method for creating an assembly
33065 (ResolveType): New function to launch the resolution process, only
33066 used by interfaces for now.
33068 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33069 that are inserted into the name space.
33071 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33073 * ARGH. I have screwed up my tree so many times due to the use of
33074 rsync rather than using CVS. Going to fix this at once.
33076 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33079 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33081 * Experiment successful: Use System.Type rather that our own
33084 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33086 * cs-parser.jay: Removed nsAliases from here.
33088 Use new namespaces, handle `using XXX;'
33090 * namespace.cs: Reimplemented namespace handling, use a recursive
33091 definition of the class. Now we can keep track of using clauses
33092 and catch invalid using clauses.
33094 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33096 * gen-treedump.cs: Adapted for all the renaming.
33098 * expression.cs (Expression): this class now has a Type property
33099 which returns an expression Type.
33101 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33102 `Type', as this has a different meaning now in the base
33104 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33106 * interface.cs, class.cs: Removed from all the sources the
33107 references to signature computation, as we can not do method
33108 signature computation during the parsing time, as we are not
33109 trying to solve at that point distinguishing:
33113 void a (NS.Blah x) {}
33116 Which depending on the context might be valid or not, as we do not
33117 know if Blah is the same thing as NS.Blah at that point.
33119 * Redid everything so the code uses TypeRefs now instead of
33120 Types. TypeRefs are just temporary type placeholders, that need
33121 to be resolved. They initially have a pointer to a string and the
33122 current scope in which they are used. This is used later by the
33123 compiler to resolve the reference to an actual Type.
33125 * DeclSpace is no longer a CIR.Type, and neither are
33126 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33127 are all DeclSpaces, but no Types.
33129 * type.cs (TypeRefManager): This implements the TypeRef manager,
33130 which keeps track of all the types that need to be resolved after
33131 the parsing has finished.
33133 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33135 * ARGH. We are going to have to store `foreach' as a class rather
33136 than resolving it, as we need to verify error 1579 after name
33137 resolution. *OR* we could keep a flag that says `This request to
33138 IEnumerator comes from a foreach statement' which we can then use
33139 to generate the error.
33141 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33143 * class.cs (TypeContainer.AddMethod): we now add methods to the
33144 MethodGroup instead of the method hashtable.
33146 * expression.cs: Add MethodGroup abstraction, which gets us one
33147 step closer to the specification in the way we handle method
33150 * cs-parser.jay (primary_expression): qualified_identifier now
33151 tried to match up an identifier to a local variable reference or
33152 to a parameter reference.
33154 current_local_parameters is now a parser global variable that
33155 points to the current parameters for the block, used during name
33158 (property_declaration): Now creates an implicit `value' argument to
33161 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33163 * parameter.cs: Do not use `param' arguments as part of the
33164 signature, per the spec.
33166 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33168 * decl.cs: Base class for classes, structs and interfaces. This
33169 is the "Declaration Space"
33171 * cs-parser.jay: Use CheckDef for checking declaration errors
33172 instead of having one on each function.
33174 * class.cs: Factor out some code for handling error handling in
33175 accordance to the "Declarations" section in the "Basic Concepts"
33176 chapter in the ECMA C# spec.
33178 * interface.cs: Make all interface member classes derive from
33179 InterfaceMemberBase.
33181 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33183 * Many things: all interfaces are parsed and generated in
33184 gen-treedump. Support for member variables, constructors,
33185 destructors, properties, constants is there.
33187 Beginning of the IL backend, but very little done, just there for
33190 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33192 * cs-parser.jay: Fix labeled statement.
33194 * cs-tokenizer.cs (escape): Escape " and ' always.
33195 ref_line, ref_name: keep track of the line/filename as instructed
33196 by #line by the compiler.
33199 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33201 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33202 to match the values in System.CodeDOM.
33204 Divid renamed to Divide.
33206 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33208 (Statements.set): remove.
33210 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33213 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33214 falseStatements always have valid values.
33216 * cs-parser.jay: Use System.CodeDOM now.