1 2004-11-18 Martin Baulig <martin@ximian.com>
3 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
4 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
5 call ResolveConstructedType() on it to resolve it without checking
7 (Constraints.ResolveTypes): Check them here.
8 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
9 but don't check constraints.
10 (ConstructedType.ResolveAsTypeTerminal): Override this and also
11 check constraints here.
12 (ConstructedType.ResolveConstructedType): New public method. This
13 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
14 resolve ourselves without checking constraints.
16 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
18 2004-11-18 Martin Baulig <martin@ximian.com>
21 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
23 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
25 2004-11-18 Martin Baulig <martin@ximian.com>
27 * ecore.cs (TypeExpr.ResolveType): Removed.
28 (Expression.ResolveAsTypeTerminal): We always return a fully
29 resolved `TypeExpr', so we can just access its `Type'.
31 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
33 2004-11-17 Martin Baulig <martin@ximian.com>
35 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
36 sure we don't return any unresolved TypeExpr's.
37 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
39 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
41 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
42 unresolved `ConstructedType's.
44 2004-11-17 Martin Baulig <martin@ximian.com>
46 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
48 2004-11-17 Martin Baulig <martin@ximian.com>
51 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
53 * decl.cs (DeclSpace.ResolveType): Removed.
54 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
56 2004-11-17 Martin Baulig <martin@ximian.com>
58 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
59 direction, like FindMembers() does. Fixes #69546, testcase is in
62 2004-11-16 Martin Baulig <martin@ximian.com>
64 This is based on a patch from Marek Safar, see bug #69082.
65 Fixes bugs #63705 and #67130.
67 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
68 method; create a MemberCache for an interface type and cache the
71 * decl.cs (IMemberContainer.ParentContainer): Removed.
72 (IMemberContainer.ParentCache): New property.
73 (MemberCache.SetupCacheForInterface): Removed.
74 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
75 to create a cache for an interface's "parent".
77 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
80 2004-11-14 Ben Maurer <bmaurer@ximian.com>
82 * statement.cs: Avoid adding bools to a hashtable.
84 2004-11-15 Martin Baulig <martin@ximian.com>
86 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
88 2004-11-11 Martin Baulig <martin@ximian.com>
90 * typemanager.cs (TypeManager.GetMethodName): New method.
92 * class.cs (MethodData.Define): Include the generic arity in the
93 name of an explicit interface; also add it to the method name.
95 * pending.cs (PendingImplementation.InterfaceMethod): The method
96 name now includes the generic arity.
98 2004-11-07 Miguel de Icaza <miguel@ximian.com>
100 * expression.cs (Invocation.OverloadResolve): Flag error if we are
101 calling an unsafe method from a safe location.
103 2004-11-06 Marek Safar <marek.safar@seznam.cz>
106 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
108 2004-11-06 Miguel de Icaza <miguel@ximian.com>
110 * namespace.cs (VerifyUsing): use GetPartialName instead of
113 2004-11-05 Miguel de Icaza <miguel@ximian.com>
115 * statement.cs (Return.Resolve): Fix regression in typo: if
116 `in_exc', we have to request a NeedReturnLabel, this was a typo
117 introduced in the anonymous method check-in. Fixes #69131.
119 * Indexers were using the ShortName when defining themselves,
120 causing a regression in the compiler bootstrap when applying the
121 patch from 2004-11-02 (first part), now they use their full name
124 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
126 * driver.cs: Strip the path from the names of embedded resources. Fixes
129 2004-11-04 Raja R Harinath <rharinath@novell.com>
131 Fix error message regression: cs0104-2.cs.
132 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
133 (AliasEntry.Resolve): Update.
134 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
136 (RootContext.LookupType): Update.
138 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
140 * cs-parser.jay: Add support for handling accessor modifiers
141 * class: Add support port accessor modifiers and error checking,
142 define PropertyMethod.Define as virtual (not abstract anymore)
143 * ecore.cs: Add checking for proeprties access with access modifiers
144 * iterators.cs: Modify Accessor constructor call based in the modified
146 2004-11-02 Ben Maurer <bmaurer@ximian.com>
148 * expression.cs (StringConcat): Handle being called twice,
149 as when we have a concat in a field init with more than two
152 2004-11-02 Miguel de Icaza <miguel@ximian.com>
154 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
155 special case explicit implementations, we should always produce
156 the .property or .event declaration.
158 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
159 since it will not return correct data if people use this
160 unresolved in the presence of using statements (see test-313).
162 * class.cs (MethodData.Define): If we are an explicit interface
163 implementation, set the method name to the full name of the
164 interface plus the name of the method.
166 Notice that using the method.MethodName.GetFullName() does not
167 work, as it will only contain the name as declared on the source
168 file (it can be a shorthand in the presence of using statements)
169 and not the fully qualifed type name, for example:
173 class D : ICloneable {
174 object ICloneable.Clone () {
178 Would produce a method called `ICloneable.Clone' instead of
179 `System.ICloneable.Clone'.
181 * namespace.cs (Alias.Resolve): Use GetPartialName.
183 2004-11-01 Marek Safar <marek.safar@seznam.cz>
185 * cs-parser.jay: Add error 1055 report.
187 2004-11-01 Miguel de Icaza <miguel@ximian.com>
189 * assign.cs (Assign.DoResolve): Only do the transform of
190 assignment into a New if the types are compatible, if not, fall
191 through and let the implicit code deal with the errors and with
192 the necessary conversions.
194 2004-11-01 Marek Safar <marek.safar@seznam.cz>
196 * cs-parser.jay: Add error 1031 report.
198 * cs-tokenizer.cs: Add location for error 1038.
200 2004-10-31 Marek Safar <marek.safar@seznam.cz>
202 * cs-parser.jay: Add error 1016 report.
204 2004-10-31 Marek Safar <marek.safar@seznam.cz>
206 * cs-parser.jay: Add errors 1575,1611 report.
208 2004-10-31 Marek Safar <marek.safar@seznam.cz>
210 * cs-parser.jay: Add error 1001 report.
212 2004-10-31 Marek Safar <marek.safar@seznam.cz>
215 * attribute.cs (GetMarshal): Add method argument for
216 caller identification.
218 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
219 agument for GetMarshal and RuntimeMissingSupport.
221 2004-10-31 Marek Safar <marek.safar@seznam.cz>
223 * attribute.cs (ExtractSecurityPermissionSet): Removed
224 TypeManager.code_access_permission_type.
226 * typemanager.cs: Removed TypeManager.code_access_permission_type.
228 2004-10-27 Miguel de Icaza <miguel@ximian.com>
230 * expression.cs (LocalVariableReference.DoResolveLValue): Check
231 for obsolete use of a variable here. Fixes regression on errors
232 cs0619-25 and cs0619-26.
234 2004-10-27 Marek Safar <marek.safar@seznam.cz>
236 Fix #62358, implemented security attribute encoding.
238 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
239 Tests permitted SecurityAction for assembly or other types.
240 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
241 data from SecurityPermissionAttribute to PermisionSet class.
243 * class.cs (ApplyAttributeBuilder): Added special handling
244 for System.Security.Permissions.SecurityAttribute based types.
246 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
247 special handling for System.Security.Permissions.SecurityAttribute
250 * enum.cs (ApplyAttributeBuilder): Added special handling
251 for System.Security.Permissions.SecurityAttribute based types.
253 * parameter.cs (ApplyAttributeBuilder): Added special handling
254 for System.Security.Permissions.SecurityAttribute based types.
256 * rootcontext.cs: Next 2 core types.
258 * typemanager.cs (TypeManager.security_permission_attr_type):
259 Built in type for the SecurityPermission Attribute.
260 (code_access_permission_type): Build in type.
262 2004-10-17 Miguel de Icaza <miguel@ximian.com>
264 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
265 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
266 all of this information into
267 EmitContext.EmitCapturedVariableInstance.
269 * codegen.cs (EmitCapturedVariableInstance): move here the
270 funcionality of emitting an ldarg.0 in the presence of a
271 remapping. This centralizes the instance emit code.
273 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
274 then emit a load of this: it means that we have reached the
275 topmost ScopeInfo: the one that contains the pointer to the
276 instance of the class hosting the anonymous method.
278 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
279 captures to the topmost CaptureContext.
281 2004-10-12 Miguel de Icaza <miguel@ximian.com>
283 * expression.cs (LocalVariableReference): Move the knowledge about
284 the iterators into codegen's EmitCapturedVariableInstance.
286 2004-10-11 Miguel de Icaza <miguel@ximian.com>
288 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
289 all code paths return a value from an anonymous method (it is the
290 same as the 161 error, but for anonymous methods).
292 2004-10-08 Miguel de Icaza <miguel@ximian.com>
294 The introduction of anonymous methods in the compiler changed
295 various ways of doing things in the compiler. The most
296 significant one is the hard split between the resolution phase
297 and the emission phases of the compiler.
299 For instance, routines that referenced local variables no
300 longer can safely create temporary variables during the
301 resolution phase: they must do so from the emission phase,
302 since the variable might have been "captured", hence access to
303 it can not be done with the local-variable operations from the runtime.
307 (Block.Flags): New flag `IsTopLevel' to indicate that this block
310 (ToplevelBlock): A new kind of Block, these are the blocks that
311 are created by the parser for all toplevel method bodies. These
312 include methods, accessors and anonymous methods.
314 These contain some extra information not found in regular blocks:
315 A pointer to an optional CaptureContext (for tracking captured
316 local variables and parameters). A pointer to the parent
319 (Return.Resolve): Catch missmatches when returning a value from an
320 anonymous method (error 1662).
321 Invoke NeedReturnLabel from the Resolve phase instead of the emit
324 (Break.Resolve): ditto.
326 (SwitchLabel): instead of defining the labels during the
327 resolution phase, we now turned the public ILLabel and ILLabelCode
328 labels into methods called GetILLabelCode() and GetILLabel() that
329 only define the label during the Emit phase.
331 (GotoCase): Track the SwitchLabel instead of the computed label
332 (its contained therein). Emit the code by using
333 SwitchLabel.GetILLabelCode ().
335 (LocalInfo.Flags.Captured): A new flag has been introduce to track
336 whether the Local has been captured or not.
338 (LocalInfo.IsCaptured): New property, used to tell whether the
339 local has been captured.
341 * anonymous.cs: Vastly updated to contain the anonymous method
344 The main classes here are: CaptureContext which tracks any
345 captured information for a toplevel block and ScopeInfo used to
346 track the activation frames for various local variables.
348 Each toplevel block has an optional capture context associated
349 with it. When a method contains an anonymous method both the
350 toplevel method and the anonymous method will create a capture
351 context. When variables or parameters are captured, they are
352 recorded on the CaptureContext that owns them, for example:
356 MyDelegate d = delegate {
361 Here `a' will be recorded as captured on the toplevel
362 CapturedContext, the inner captured context will not have anything
363 (it will only have data if local variables or parameters from it
364 are captured in a nested anonymous method.
366 The ScopeInfo is used to track the activation frames for local
367 variables, for example:
369 for (int i = 0; i < 10; i++)
370 for (int j = 0; j < 10; j++){
371 MyDelegate d = delegate {
376 At runtime this captures a single captured variable `i', but it
377 captures 10 different versions of the variable `j'. The variable
378 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
381 The toplevel ScopeInfo will also track information like the `this'
382 pointer if instance variables were referenced (this is necessary
383 as the anonymous method lives inside a nested class in the host
386 (AnonymousMethod): Expanded to track the Toplevel, implement
387 `AnonymousMethod.Compatible' to tell whether an anonymous method
388 can be converted to a target delegate type.
390 The routine now also produces the anonymous method content
392 (AnonymousDelegate): A helper class that derives from
393 DelegateCreation, this is used to generate the code necessary to
394 produce the delegate for the anonymous method that was created.
396 * assign.cs: API adjustments for new changes in
397 Convert.ImplicitStandardConversionExists.
399 * class.cs: Adjustments to cope with the fact that now toplevel
400 blocks are of type `ToplevelBlock'.
402 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
403 insteda of standard blocks.
405 Flag errors if params arguments are passed to anonymous methods.
407 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
408 `CurrentAnonymousMethod' which points to the current Anonymous
409 Method. The variable points to the AnonymousMethod class that
410 holds the code being compiled. It is set in the new EmitContext
411 created for the anonymous method.
413 (EmitContext.Phase): Introduce a variable and an enumeration to
414 assist in enforcing some rules about when and where we are allowed
415 to invoke certain methods (EmitContext.NeedsReturnLabel is the
416 only one that enfonces this right now).
418 (EmitContext.HaveCaptureInfo): new helper method that returns
419 whether we have a CapturedContext initialized.
421 (EmitContext.CaptureVariable): New method used to register that a
422 LocalInfo must be flagged for capturing.
424 (EmitContext.CapturedParameter): New method used to register that a
425 parameters must be flagged for capturing.
427 (EmitContext.CapturedField): New method used to register that a
428 field must be flagged for capturing.
430 (EmitContext.HaveCapturedVariables,
431 EmitContext.HaveCapturedFields): Return whether there are captured
434 (EmitContext.EmitMethodHostInstance): This is used to emit the
435 instance for the anonymous method. The instance might be null
436 (static methods), this (for anonymous methods that capture nothing
437 and happen to live side-by-side with the current method body) or a
438 more complicated expression if the method has a CaptureContext.
440 (EmitContext.EmitTopBlock): Routine that drives the emission of
441 code: it will first resolve the top block, then emit any metadata
442 and then emit the code. The split is done so that we can extract
443 any anonymous methods and flag any captured variables/parameters.
445 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
446 during this phase, the ILGenerator should not be used as labels
447 and local variables declared here might not be accessible to any
448 code that is part of an anonymous method.
450 Exceptions to this include the temporary variables that are
451 created by some statements internally for holding temporary
454 (EmitContext.EmitMeta): New routine, in charge of emitting all the
457 (EmitContext.TemporaryReturn): This method is typically called
458 from the Emit phase, and its the only place where we allow the
459 ReturnLabel to be defined other than the EmitMeta. The reason is
460 that otherwise we would have to duplicate a lot of logic in the
461 Resolve phases of various methods that today is on the Emit
464 (EmitContext.NeedReturnLabel): This no longer creates the label,
465 as the ILGenerator is not valid during the resolve phase.
467 (EmitContext.EmitThis): Extended the knowledge in this class to
468 work in anonymous methods in addition to iterators.
470 (EmitContext.EmitCapturedVariableInstance): This emits whatever
471 code is necessary on the stack to access the instance to a local
472 variable (the variable will be accessed as a field).
474 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
475 EmitContext.EmitAddressOfParameter): Routines to support
476 parameters (not completed at this point).
478 Removals: Removed RemapLocal and RemapLocalLValue. We probably
479 will also remove the parameters.
481 * convert.cs (Convert): Define a `ConstantEC' which points to a
482 null. This is just to prefity some code that uses
483 ImplicitStandardConversion code and do not have an EmitContext
486 The idea is to flag explicitly that at that point in time, it is
487 known that the conversion will not trigger the delegate checking
488 code in implicit conversions (which requires a valid
491 Everywhere: pass new EmitContext parameter since
492 ImplicitStandardConversionExists now requires it to check for
493 anonymous method conversions.
495 (Convert.ImplicitStandardConversionExists): If the type of an
496 expression is the anonymous_method_type, and the type is a
497 delegate, we invoke the AnonymousMethod.Compatible method to check
498 whether an implicit conversion is possible.
500 (Convert.ImplicitConversionStandard): Only do implicit method
501 group conversions if the language level is not ISO_1.
503 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
504 MethodInfo for the Invoke method. used by Delegate and
507 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
508 method conversions if the target type is a delegate.
510 Removed extra debugging nops.
512 (LocalVariableReference): Turn the `local_info' into a public
515 Add `prepared' field, the same hack used for FieldExprs to cope
516 with composed assignments, as Local variables do not necessarily
517 operate purely on the stack as they used to: they can be captured
520 Add `temp' for a temporary result, like fields.
522 Refactor DoResolve and DoResolveLValue into DoResolveBase.
524 It now copes with Local variables that are captured and emits the
525 proper instance variable to load it from a field in the captured
528 (ParameterReference.DoResolveBase): During the resolve phase,
529 capture parameters if we are in an anonymous method.
531 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
532 anonymous method, use the EmitContext helper routines to emit the
535 * iterators.cs: Set RemapToProxy to true/false during the
538 * parameters.cs (GetParameterByName): New helper method.
540 * typemanager.cs (anonymous_method_type) a new type that
541 represents an anonyous method. This is always an internal type,
542 used as a fencepost to test against the anonymous-methodness of an
545 2004-10-20 Marek Safar <marek.safar@seznam.cz>
547 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
549 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
551 2004-11-10 Martin Baulig <martin@ximian.com>
553 * expression.cs (Invocation.BetterFunction): If two methods have
554 equal parameter types, but only one of them is generic, the
555 non-generic one wins.
556 (New.DoResolve): Don't set `is_struct' to false if we're a generic
557 instance; just use `Type.IsValueType' to determine whether
558 something is a struct or not.
559 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
560 so we can be called multiple times.
562 2004-11-10 Martin Baulig <martin@ximian.com>
564 * generic.cs (TypeParameter.DefineConstraints): New public method.
565 (TypeParameter.CheckAccessLevel): Override this and return true.
566 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
567 override ResolveType() anymore.
568 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
570 2004-11-10 Martin Baulig <martin@ximian.com>
572 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
573 call DeclSpace.ResolveNestedType() on it.
575 2004-11-10 Martin Baulig <martin@ximian.com>
577 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
578 non-null, call ParameterModifier() on it.
580 2004-11-10 Martin Baulig <martin@ximian.com>
583 (Iterators): Added `current_type' and `this_type' fields.
584 (Iterators.DefineIterator): Create a new EmitContext and store it
585 in `ec'; compute `this_type'.
587 2004-11-10 Martin Baulig <martin@ximian.com>
590 (TypeManager.IsPrivateAccessible): New public method.
591 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
593 2004-11-10 Martin Baulig <martin@ximian.com>
595 * class.cs (TypeContainer.DefineType): Call
596 TypeBuilder.DefineGenericParameters() before resolving the type
598 (MethodData.parent_method): New protected field.
599 (MethodData..ctor): Added `MethodInfo parent_method' argument.
600 (MethodData.Define): Compute `parent_method'.
603 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
604 (MemberCore.GetClsCompliantAttributeValue): Likewise.
605 (DeclSpace.ec): New protected field; store the EmitContext here.
606 (DeclSpace.EmitContext): New public property.
607 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
608 (DeclSpace.ResolveNestedType): New public method.
609 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
610 (DeclSpace.NestedAccessible): Added `Type tb' argument.
611 (DeclSpace.FamilyAccessible): Likewise.
612 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
613 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
616 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
619 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
620 (Enum.Emit): Don't create a new EmitContext.
622 2004-10-18 Martin Baulig <martin@ximian.com>
624 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
625 `Type' directly, but call ResolveType() on it.
626 (Catch.Resolve): Likewise.
627 (Foreach.Resolve): Likewise.
629 2004-10-18 Martin Baulig <martin@ximian.com>
631 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
632 `Type' directly, but call ResolveType() on it.
633 (Probe.DoResolve): Likewise.
634 (ArrayCreation.LookupType): Likewise.
635 (TypeOf.DoResolve): Likewise.
636 (SizeOf.DoResolve): Likewise.
638 2004-10-18 Raja R Harinath <rharinath@novell.com>
640 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
643 2004-10-17 John Luke <john.luke@gmail.com>
645 * class.cs (Operator.GetSignatureForError): use CSharpName
647 * parameter.cs (Parameter.GetSignatureForError): Returns
648 correct name even if was not defined.
650 2004-10-13 Raja R Harinath <rharinath@novell.com>
653 * class.cs (TypeContainer.EmitContext): New property.
654 (DefineNestedTypes): Create an emitcontext for each part.
655 (MethodCore.DoDefineParameters): Use container's emitcontext.
656 Pass type array to InternalParameters.
657 (MemberBase.DoDefine): Use container's emitcontext.
658 (FieldMember.Define): Likewise.
659 (Event.Define): Likewise.
660 (SetMethod.GetParameterInfo): Change argument to EmitContext.
661 Pass type array to InternalParameters.
662 (SetIndexerMethod.GetParameterInfo): Likewise.
663 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
664 * delegate.cs (Define): Pass emitcontext to
665 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
666 array to InternalParameters.
667 * expression.cs (ParameterReference.DoResolveBase): Pass
668 emitcontext to GetParameterInfo.
669 (ComposedCast.DoResolveAsTypeStep): Remove check on
670 ec.ResolvingTypeTree.
671 * parameter.cs (Parameter.Resolve): Change argument to
672 EmitContext. Use ResolveAsTypeTerminal.
673 (Parameter.GetSignature): Change argument to EmitContext.
674 (Parameters.ComputeSignature): Likewise.
675 (Parameters.ComputeParameterTypes): Likewise.
676 (Parameters.GetParameterInfo): Likewise.
677 (Parameters.ComputeAndDefineParameterTypes): Likewise.
678 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
679 * support.cs (InternalParameters..ctor): Remove variant that takes
681 * typemanager.cs (system_intptr_expr): New.
682 (InitExpressionTypes): Initialize it.
684 2004-10-12 Chris Toshok <toshok@ximian.com>
686 * cs-parser.jay: fix location for try_statement and catch_clause.
688 2004-10-18 Martin Baulig <martin@ximian.com>
690 * class.cs (FieldMember.Define): Don't access the TypeExpr's
691 `Type' directly, but call ResolveType() on it.
692 (MemberBase.DoDefine): Likewise.
694 * expression.cs (New.DoResolve): Don't access the TypeExpr's
695 `Type' directly, but call ResolveType() on it.
696 (ComposedCast.DoResolveAsTypeStep): Likewise.
698 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
699 `Type' directly, but call ResolveType() on it.
701 2004-10-17 John Luke <john.luke@gmail.com>
703 * class.cs (Operator.GetSignatureForError): use CSharpName
705 * parameter.cs (Parameter.GetSignatureForError): Returns
706 correct name even if was not defined.
708 2004-10-13 Raja R Harinath <rharinath@novell.com>
711 * class.cs (TypeContainer.EmitContext): New property.
712 (DefineNestedTypes): Create an emitcontext for each part.
713 (MethodCore.DoDefineParameters): Use container's emitcontext.
714 Pass type array to InternalParameters.
715 (MemberBase.DoDefine): Use container's emitcontext.
716 (FieldMember.Define): Likewise.
717 (Event.Define): Likewise.
718 (SetMethod.GetParameterInfo): Change argument to EmitContext.
719 Pass type array to InternalParameters.
720 (SetIndexerMethod.GetParameterInfo): Likewise.
721 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
722 * delegate.cs (Define): Pass emitcontext to
723 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
724 array to InternalParameters.
725 * expression.cs (ParameterReference.DoResolveBase): Pass
726 emitcontext to GetParameterInfo.
727 (ComposedCast.DoResolveAsTypeStep): Remove check on
728 ec.ResolvingTypeTree.
729 * parameter.cs (Parameter.Resolve): Change argument to
730 EmitContext. Use ResolveAsTypeTerminal.
731 (Parameter.GetSignature): Change argument to EmitContext.
732 (Parameters.ComputeSignature): Likewise.
733 (Parameters.ComputeParameterTypes): Likewise.
734 (Parameters.GetParameterInfo): Likewise.
735 (Parameters.ComputeAndDefineParameterTypes): Likewise.
736 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
737 * support.cs (InternalParameters..ctor): Remove variant that takes
739 * typemanager.cs (system_intptr_expr): New.
740 (InitExpressionTypes): Initialize it.
742 2004-10-12 Chris Toshok <toshok@ximian.com>
744 * cs-parser.jay: fix location for try_statement and catch_clause.
746 2004-10-07 Raja R Harinath <rharinath@novell.com>
748 More DeclSpace.ResolveType avoidance.
749 * decl.cs (MemberCore.InUnsafe): New property.
750 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
751 with newly created EmitContext.
752 (FieldMember.Define): Likewise.
753 * delegate.cs (Delegate.Define): Likewise.
754 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
755 only if normal name-lookup fails.
756 (TypeExpr.DoResolve): Enable error-checking.
757 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
758 (SizeOf.DoResolve): Likewise.
759 (ComposedCast.DoResolveAsTypeStep): Likewise.
760 (StackAlloc.DoResolve): Likewise.
761 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
762 (Block.Unsafe): New property.
763 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
764 (Unsafe): Set 'unsafe' flag of contained block.
765 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
766 (Fixed.Resolve): Likewise.
767 (Catch.Resolve): Likewise.
768 (Using.ResolveLocalVariableDecls): Likewise.
769 (Foreach.Resolve): Likewise.
771 2004-10-05 John Luke <john.luke@gmail.com>
773 * cs-parser.jay: add location to error CS0175
775 2004-10-04 Miguel de Icaza <miguel@ximian.com>
777 * ecore.cs (Expression.Constantity): Add support for turning null
780 * const.cs (Const.Define): Allow constants to be reference types
781 as long as the value is Null.
783 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
785 * namespace.cs (NamespaceEntry.Using): No matter which warning
786 level is set, check if this namespace name has already been added.
788 2004-10-03 Ben Maurer <bmaurer@ximian.com>
790 * expression.cs: reftype [!=]= null should always use br[true,false].
793 2004-10-03 Marek Safar <marek.safar@seznam.cz>
796 * attribute.cs: Enum conversion moved to
797 GetAttributeArgumentExpression to be applied to the all
800 2004-10-01 Raja R Harinath <rharinath@novell.com>
802 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
803 * class.c (TypeContainer.DefineType): Flag error if
804 base types aren't accessible due to access permissions.
805 * decl.cs (DeclSpace.ResolveType): Move logic to
806 Expression.ResolveAsTypeTerminal.
807 (DeclSpace.ResolveTypeExpr): Thin layer over
808 Expression.ResolveAsTypeTerminal.
809 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
810 Refactor code into NestedAccess. Use it.
811 (DeclSpace.NestedAccess): New.
812 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
813 argument to silence errors. Check access permissions.
814 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
815 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
816 (Cast.DoResolve): Likewise.
817 (New.DoResolve): Likewise.
818 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
819 (TypeOf.DoResolve): Likewise.
821 * expression.cs (Invocation.BetterConversion): Return the Type of
822 the better conversion. Implement section 14.4.2.3 more faithfully.
823 (Invocation.BetterFunction): Make boolean. Make correspondence to
824 section 14.4.2.2 explicit.
825 (Invocation.OverloadResolve): Update.
826 (Invocation): Remove is_base field.
827 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
828 (Invocation.Emit): Likewise.
830 2004-09-24 Marek Safar <marek.safar@seznam.cz>
832 * cs-parser.jay: Reverted 642 warning fix.
834 2004-09-23 Marek Safar <marek.safar@seznam.cz>
837 * decl.cs (FindMemberWithSameName): Indexer can have more than
840 2004-09-23 Marek Safar <marek.safar@seznam.cz>
842 * expression.cs (LocalVariableReference.DoResolveLValue):
843 Do not report warning 219 for out values.
844 (EmptyExpression.Null): New member to avoid extra allocations.
846 2004-09-23 Marek Safar <marek.safar@seznam.cz>
848 * cs-parser.jay: Fix wrong warning 642 report.
850 * cs-tokenizer.cs (CheckNextToken): New helper;
851 Inspect next character if is same as expected.
853 2004-09-23 Martin Baulig <martin@ximian.com>
855 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
856 (Convert.ImplicitReferenceConversionExists): Likewise.
858 2004-11-09 Raja R Harinath <rharinath@novell.com>
860 * Makefile (DISTFILES): Comment out a few missing files.
862 2004-10-29 Raja R Harinath <rharinath@novell.com>
864 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
865 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
866 (gmcs.exe): Invoke bootstrap-libs.
867 (clean-local): Clean the net_2_0_bootstrap profile too.
868 (PROGRAM_INSTALL_DIR): New.
869 (install-local): Use it.
871 2004-10-13 Martin Baulig <martin@ximian.com>
873 * generic.cs (TypeManager.InflatedConstraints): New nested class.
874 (TypeParameter.DefineType): If we're a method type parameter and
875 that method is overriding something, "inflate" its constraints.
877 2004-10-12 Martin Baulig <martin@ximian.com>
879 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
880 and have type arguments, create and resolve a ConstructedType.
882 2004-10-12 Martin Baulig <martin@ximian.com>
884 * decl.cs (MemberCache.FindMemberToOverride): Use
885 TypeManager.IsEqual() to compare the parameters and Type.Equals()
886 to compare the invocationType.
888 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
889 When comparing two type parameters, only do the signature-only
890 comparision for method type parameters.
892 2004-10-11 Martin Baulig <martin@ximian.com>
894 * report.cs: Don't make --fatal abort on warnings, we have
895 -warnaserror for that.
897 2004-10-11 Martin Baulig <martin@ximian.com>
900 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
901 (TypeManager.IsEqual): Call ourself recursively instead of using
904 2004-10-11 Martin Baulig <martin@ximian.com>
906 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
907 on our own type parameters, not on the ones we inherit from a containing
910 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
913 * generic.cs (TypeParameter.Define): We may only be called once.
915 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
916 instead of TypeManager.IsEqual().
918 2004-09-28 Martin Baulig <martin@ximian.com>
921 (GenericConstraints.EffectiveBaseClass): New public property.
922 (TypeParameter.GenericConstraints): New public property.
923 (ConstructedType.CheckConstraints): Improved.
925 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
926 (Convert.TypeParameterConversion): New private method; use this in
927 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
928 for all conversions related to type parameters.
930 2004-09-24 Martin Baulig <martin@ximian.com>
932 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
933 type parameter conversions for type parameters which are known to
936 2004-09-24 Martin Baulig <martin@ximian.com>
938 * generic.cs (GenericConstraints): Added `IsReferenceType' and
939 `IsValueType' properties.
941 * support.cs (ReflectionConstraints): Use
942 Type.GetGenericParameterConstraints() instead of the old hack.
944 2004-09-24 Martin Baulig <martin@ximian.com>
946 * generic.cs (GenericConstraints): Moved here and made it an
949 * support.cs (GenericConstraints): Moved to generic.cs.
951 2004-09-24 Martin Baulig <martin@ximian.com>
954 (ReflectionConstraints): Un-nested this class and made it public.
957 (TypeManager.GetTypeParameterConstraints): New public method.
958 (TypeManager.HasConstructorConstraint): Use the attributes.
960 2004-09-24 Martin Baulig <martin@ximian.com>
962 * support.cs (GenericConstraints): Replaced `HasConstructor',
963 `IsReferenceType' and `IsValueType' with `Attributes'.
964 (ReflectionParameters.ReflectionConstraints): Removed the Create()
965 method and made the .ctor public.
967 * generic.cs (Constraints.Attributes): New public property.
968 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
969 `IsReferenceType' -> `HasReferenceTypeConstraint' and
970 `IsValueType' -> `HasValueTypeConstraint'.
972 2004-09-23 Martin Baulig <martin@ximian.com>
974 * generic.cs (Constraints): Reflect latest runtime changes.
976 2004-09-23 Martin Baulig <martin@ximian.com>
978 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
979 (Convert.ImplicitReferenceConversionExists): Likewise.
981 2004-09-23 Marek Safar <marek.safar@seznam.cz>
983 * class.cs (Operator.Define): Add error 448 and 559 report.
985 2004-09-22 Marek Safar <marek.safar@seznam.cz>
987 * class.cs (MemberBase.IsTypePermitted): New protected
988 method for checking error CS0610.
990 2004-09-22 Marek Safar <marek.safar@seznam.cz>
992 * class.cs (TypeContainer.HasExplicitLayout): New property
993 Returns whether container has StructLayout attribute set Explicit.
994 (FieldMember): New abstract class for consts and fields.
995 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
996 (Field): Reuse FieldMember.
998 * const.cs (Const): Reuse FieldMember.
1000 * rootcontext.cs: EmitConstants call moved to class.
1002 2004-09-22 Martin Baulig <martin@ximian.com>
1004 Marek and me just fixed one of our oldest bugs: #28562 :-)
1006 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1008 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1009 we're an EnumConstant, just return that.
1010 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1011 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1012 to get the value which'll actually be written into the attribute.
1013 However, we have to use GetValue() to access the attribute's value
1016 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1018 * constant.cs (Constant.IsNegative): New abstract property
1021 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1022 (StackAlloc.DoResolve): Reused IsNegative.
1024 2004-09-22 Martin Baulig <martin@ximian.com>
1026 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
1027 public method; like LookupTypeContainer, but also works for
1030 * report.cs (Report.SymbolRelatedToPreviousError): Use
1031 TypeManager.LookupGenericTypeContainer().
1033 2004-09-22 Martin Baulig <martin@ximian.com>
1035 Thanks to Peter Sestoft for this bug report.
1037 * expression.cs (Conditional): If both the `trueExpr' and the
1038 `falseExpr' is a NullLiteral, return a NullLiteral.
1040 2004-09-22 Martin Baulig <martin@ximian.com>
1042 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1043 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1044 for the "get_Current" call.
1046 2004-09-21 Martin Baulig <martin@ximian.com>
1048 * convert.cs (Convert.ImplicitReferenceConversion): When
1049 converting to an interface type, first check whether we're
1050 converting from a reference type.
1052 2004-09-14 Martin Baulig <martin@ximian.com>
1054 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1056 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1059 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1060 called and is obsolete then this member suppress message
1061 when call is inside next [Obsolete] method or type.
1063 * expression.cs: Use TestObsoleteMethodUsage member.
1065 2004-09-14 Martin Baulig <martin@ximian.com>
1067 * genericparser.cs: Removed.
1069 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1071 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1073 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1075 * attribute.cs (Attribute.Resolve): Add error 653 report.
1077 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1079 (Method.ApplyAttributeBuilder): Add error 685 report.
1080 (Operator.Define): Add error 564 report.
1082 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1084 * expression.cs (Invocation.DoResolve): Add error
1087 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1090 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1092 * class.cs (ConstructorInitializer.Resolve):
1093 Wrong error number (515->516).
1095 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1097 * class.cs (Indexer.Define): Add error 631 report.
1099 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1101 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1103 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1105 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1107 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1109 * cs-parser.jay: Added error CS0241 report.
1111 2004-09-10 Raja R Harinath <rharinath@novell.com>
1113 * cs-parser.jay (fixed_statement): Introduce a scope for the
1114 declaration in the 'fixed' statement.
1116 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1118 * cs-parser.jay: Added CS0230 error report.
1120 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1122 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1124 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1126 * expression.cs (Argument.Resolve): Added error CS0192 and
1129 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1131 C# 2.0 #pragma warning feature
1133 * cs-tokenizer.cs (PreProcessPragma): New method;
1134 Handles #pragma directive.
1136 * report.cs (WarningRegions): New class; Support
1137 class for #pragma warning directive. It tests whether
1138 warning is enabled for a given line.
1140 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1142 * const.cs: Add more descriptive error report, tahnks to
1145 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1147 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1149 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1151 * expression.cs: Apply patch from Ben: Remove dead code from
1152 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1153 as that code just threw an exception anwyays.
1155 * const.cs: Remove the call to the turnintoconstant, for details
1158 * literal.cs: The type of the null-literal is the null type; So
1159 we use a placeholder type (literal.cs:System.Null, defined here)
1162 * expression.cs (Conditional.DoResolve): Remove some old code that
1163 is no longer needed, conversions have been fixed.
1165 (ArrayCreationExpression.DoResolve): Return false if we fail to
1166 resolve the inner expression.
1168 2004-09-07 Raja R Harinath <rharinath@novell.com>
1171 * cs-parser.jay (delegate_declaration): Record a delegate
1172 declaration as a type declaration.
1173 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1175 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1177 * parameter.cs: Do not crash if the type can not be resolved.
1179 * expression.cs: Report errors with unsafe pointers, fixes #64896
1181 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1183 * expression.cs: Pointer arith always needs to do a conv.i
1184 if the operand is a long. fix 65320
1186 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1188 Fixed cs0619-37.cs, cs0619-38.cs
1190 * enum.cs (GetObsoleteAttribute): Removed.
1192 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1193 on Enum member is double staged. The first is tested member
1196 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1198 Fixed #56986, #63631, #65231
1200 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1201 adds member to name container.
1202 (TypeContainer.AddToTypeContainer): New method, adds type to
1204 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1205 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1206 AddOperator): Simplified by reusing AddToMemberContainer.
1207 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1209 (Method.CheckForDuplications): Fixed implementation to test all
1211 (MemberBase): Detection whether member is explicit interface
1212 implementation is now in constructor.
1213 (MemberBase.UpdateMemberName): Handles IndexerName.
1214 (Accessor): Changed to keep also location information.
1215 (AbstractPropertyEventMethod): Is derived from MemberCore.
1216 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1217 will be emited or not.
1218 (PropertyBase.AreAccessorsDuplicateImplementation):
1219 Tests whether accessors are not in collision with some method.
1220 (Operator): Is derived from MethodCore to simplify common
1223 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1225 (DeclSpace.AddToContainer): Adds the member to defined_names
1226 table. It tests for duplications and enclosing name conflicts.
1228 * enum.cs (EnumMember): Clean up to reuse the base structures
1230 2004-09-03 Martin Baulig <martin@ximian.com>
1232 Merged latest changes into gmcs. Please keep this comment in
1233 here, it makes it easier for me to see what changed in MCS since
1234 the last time I merged.
1236 2004-09-03 Martin Baulig <martin@ximian.com>
1238 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1239 into TypeContainer, to make partial classes work again.
1241 2004-09-03 Martin Baulig <martin@ximian.com>
1243 * rootcontext.cs (RootContext.V2): Removed.
1245 2004-03-23 Martin Baulig <martin@ximian.com>
1247 * expression.cs (Invocation.OverloadResolve): Added `bool
1248 may_fail' argument and use it instead of the Location.IsNull() hack.
1250 2004-09-09 Martin Baulig <martin@ximian.com>
1252 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
1254 2004-09-09 Martin Baulig <martin@ximian.com>
1256 * generic.cs (TypeParameter.DefineType): Added support for
1257 explicit interface methods.
1259 2004-09-09 Martin Baulig <martin@ximian.com>
1261 * README.Changes: New document. Started to list important changes
1262 between MCS and GMCS here.
1264 2004-09-08 Martin Baulig <martin@ximian.com>
1267 (TypeContainer.CheckRecursiveDefinition): New protected method.
1268 (TypeContainer.DefineType): Move the CS0146 check into
1269 CheckRecursiveDefinition().
1271 2004-09-06 Martin Baulig <martin@ximian.com>
1273 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
1274 types for the constructor constraint.
1276 2004-09-03 Martin Baulig <martin@ximian.com>
1278 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1279 into TypeContainer, to make partial classes work again.
1281 2004-09-03 Martin Baulig <martin@ximian.com>
1283 * rootcontext.cs (RootContext.V2): Removed.
1285 2004-03-23 Martin Baulig <martin@ximian.com>
1287 * expression.cs (Invocation.OverloadResolve): Added `bool
1288 may_fail' argument and use it instead of the Location.IsNull() hack.
1290 2004-09-03 Martin Baulig <martin@ximian.com>
1292 Merged latest changes into gmcs. Please keep this comment in
1293 here, it makes it easier for me to see what changed in MCS since
1294 the last time I merged.
1296 2004-09-03 Raja R Harinath <rharinath@novell.com>
1299 * expression.cs (BetterConversion): Don't allow either conversion
1300 to be null. Remove redundant implicit conversion test when 'q ==
1301 null' -- when this function is invoked, we already know that the
1302 implicit conversion exists.
1303 (BetterFunction): Assume that 'best' is non-null. Remove
1304 redundant reimplementation of IsApplicable when 'best' is null.
1305 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1306 number of arguments.
1307 (IsAncestralType): Extract from OverloadResolve.
1308 (OverloadResolve): Make robust to the MethodGroupExpr being
1309 unsorted. Implement all the logic of Section 14.5.5.1, and
1310 support overloading of methods from multiple applicable types.
1311 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1313 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1314 (RealError, Warning): Append type of report to related symbol.
1316 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1318 * enum.cs: Fixed CLS-Compliance checks for enum members.
1319 Error tests cs3008-8.cs, cs3014-8.cs
1321 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1323 Fixed bug #62342, #63102
1324 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1325 like ImplementMethod.
1327 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1329 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1332 2004-09-02 Martin Baulig <martin@ximian.com>
1334 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1335 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1338 2004-09-01 Marek Safar <marek.safar@seznam.cz>
1340 C# 2.0 Static classes implemented
1342 * class.cs (TypeContainer): instance_constructors,
1343 initialized_fields, initialized_static_fields,
1344 default_constructor, base_inteface_types are protected to be
1345 accessible from StaticClass.
1346 (TypeContainer.DefineDefaultConstructor): New virtual method
1347 for custom default constructor generating
1348 (StaticClass): New class to handle "Static classes" feature.
1350 * cs-parser.jay: Handle static keyword on class like instance
1353 * driver.cs: Added "/langversion" command line switch with two
1354 options (iso-1, default).
1356 2004-08-31 Marek Safar <marek.safar@seznam.cz>
1358 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
1360 2004-08-31 Miguel de Icaza <miguel@ximian.com>
1362 * delegate.cs: Style.
1364 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
1366 * delegate.cs: Add seperate instance expr field for miguel.
1368 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1370 * PointerArithmetic (Resolve): make sure we are not doing
1371 pointer arith on void*. Also, make sure we are resolved
1372 by not setting eclass until resolve.
1374 All callers: Make sure that PointerArithmetic gets resolved.
1376 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1378 * ArrayCreation (LookupType): If the type does not resolve
1379 to an array, give an error.
1381 2004-08-27 Marek Safar <marek.safar@seznam.cz>
1383 * statement.cs (Try.Resolve): Fixed bug #64222
1385 2004-08-27 Martin Baulig <martin@ximian.com>
1388 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1391 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1393 * ecore.cs (Constantify): Get underlying type via
1394 System.Enum.GetUnderlyingType to avoid StackOverflow on the
1395 Windows in special cases.
1397 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1399 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
1400 for obtaining also private methods.
1401 (GetRemoveMethod): Used GetRemoveMethod (true)
1402 for obtaining also private methods.
1404 2004-09-02 Martin Baulig <martin@ximian.com>
1406 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1407 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1410 2004-08-27 Martin Baulig <martin@ximian.com>
1413 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1416 2004-08-25 Martin Baulig <martin@ximian.com>
1418 * support.cs (ReflectionParameters..ctor): If this is a generic
1419 method, retrieve and store its type parameters.
1420 (InternalParameters..ctor): Added `TypeParameter[]' argument.
1421 (ReflectionParameters.GenericConstraints): The argument specifies
1422 the type parameter, not the method parameter.
1423 (InternalParameters.GenericConstraints): Likewise.
1425 * generic.cs (TypeParameter.DefineType): Correctly handle
1426 constraints wrt. generic methods in interfaces and their
1429 2004-08-24 Martin Baulig <martin@ximian.com>
1431 * generic.cs (TypeParameter.IsSubclassOf): New public method.
1432 (Constraints.IsSubclassOf): New internal method.
1434 * typemanager.cs (TypeManager.FindMembers): Added special support
1435 for GenericTypeParameterBuilder's.
1436 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
1439 2004-08-24 Martin Baulig <martin@ximian.com>
1442 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
1443 this for accessibility checks.
1444 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
1445 IsNestedFamilyAccessible.
1446 (TypeManager.IsSubclassOf): New method, do what the name actually
1449 2004-08-24 Martin Baulig <martin@ximian.com>
1451 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
1452 as a SimpleName, include the generic arity.
1454 2004-08-24 Martin Baulig <martin@ximian.com>
1456 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
1457 MethodAttributes.HideBySig for operators.
1459 2004-08-23 Martin Baulig <martin@ximian.com>
1461 Back to the old error reporting system :-)
1463 * report.cs (Message): Removed.
1464 (Report.MessageData, ErrorData, WarningData): Removed.
1465 (Report.Error, Warning): Back to the old system.
1467 2004-08-23 Martin Baulig <martin@ximian.com>
1469 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
1471 * class.cs (TypeContainer.ParentContainer): New public virtual
1472 method; replaces the explicit interface implementation.
1473 (ClassPart.ParentContainer): Override.
1475 2004-08-23 Martin Baulig <martin@ximian.com>
1477 * statement.cs (Switch): Added support for constant switches; see
1478 #59428 or test-285.cs.
1480 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1483 * statement.cs (GetEnumeratorFilter): Removed useless
1484 logic because C# specs is strict. GetEnumerator must be
1487 2004-08-22 Martin Baulig <martin@ximian.com>
1489 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1490 a switch and may break, reset the barrier. Fixes #59867.
1492 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1494 CLS-Compliance speed up (~5% for corlib)
1496 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
1497 New method. Tests container for CLS-Compliant names
1499 * class.cs (TypeContainer.VerifyClsName): New method.
1500 Checks whether container name is CLS Compliant.
1501 (Constructor): Implements IMethodData.
1503 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
1504 low-case table for CLS Compliance test.
1505 (MemberCache.VerifyClsParameterConflict): New method.
1506 Checks method parameters for CS3006 error.
1508 * enum.cs (EnumMember): Is derived from MemberCore.
1509 (Enum.VerifyClsName): Optimized for better performance.
1511 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1513 * report.cs: Renamed Error_T to Error and changed all
1516 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1518 * class.cs (TypeContainer.IndexerArrayList): New inner class
1519 container for indexers.
1520 (TypeContainer.DefaultIndexerName): New constant for default
1521 indexer name. Replaced all "Item" with this constant.
1522 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
1524 * typemanager.cs (TypeManager.default_member_ctor): Cache here
1525 DefaultMemberAttribute constructor.
1527 2004-08-05 Martin Baulig <martin@ximian.com>
1529 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
1532 2004-08-05 Marek Safar <marek.safar@seznam.cz>
1534 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
1535 multi platforms problem.
1537 * compiler.csproj: Included shared files.
1539 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1541 Fix bug 60333, 55971 in the more general way
1542 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1543 Added arg_type argument for constant conversion.
1544 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
1546 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1549 * class.cs (TypeContainer ): New inner classes MethodArrayList,
1550 OperatorArrayList, MethodCoreArrayList for typecontainer
1551 containers. Changed class member types to these new types.
1552 (MethodArrayList.DefineMembers): Added test for CS0659.
1554 2004-08-04 Miguel de Icaza <miguel@ximian.com>
1556 * cfold.cs: Synchronize the folding with the code in expression.cs
1557 Binary.DoNumericPromotions for uint operands.
1559 * attribute.cs: Revert patch from Raja, it introduced a regression
1560 while building Blam-1.2.1 (hard to isolate a test case).
1562 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1566 (TypeContainer.Define): Renamed to DefineContainerMembers because of
1568 (MethodCore.parent_method): New member. The method we're overriding
1569 if this is an override method.
1570 (MethodCore.CheckBase): Moved from Method class and made common.
1571 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
1573 (MethodCore.CheckForDuplications): New abstract method. For custom
1574 member duplication search in a container
1575 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
1576 method and its return type.
1577 (Event.conflict_symbol): New member. Symbol with same name in the
1581 (MemberCache.FindMemberWithSameName): New method. The method
1582 is looking for conflict with inherited symbols.
1584 2004-08-04 Martin Baulig <martin@ximian.com>
1586 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1588 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1590 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1592 * report.cs (Message): New enum for better error, warning reference in
1594 (MessageData): New inner abstract class. It generally handles printing of
1595 error and warning messages.
1596 Removed unused Error, Warning, Message methods.
1598 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1600 Fix for cs0592-8.cs test
1602 (Attributable.ValidAttributeTargets): Made public.
1603 (Attribute.ExplicitTarget): New member for explicit target value.
1604 (Attribute.CheckTargets): Now we translate explicit attribute
1605 target to Target here.
1607 2004-08-03 Ben Maurer <bmaurer@ximian.com>
1609 * ecore.cs (MethodGroupExpr): new IsBase property.
1611 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
1613 * delegate.cs (DelegateCreation): store a MethodGroupExpr
1614 rather than an instance expr.
1616 (DelegateCreation.Emit): Use the method group rather than
1617 the instance expression. Also, if you have base.Foo as the
1618 method for a delegate, make sure to emit ldftn, not ldftnvirt.
1620 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
1622 (NewDelegate.DoResolve): Only check for the existance of Invoke
1623 if the method is going to be needed. Use MethodGroupExpr.
1625 (NewDelegate.Emit): Remove, DelegateCreation implements this.
1627 * expression.cs: For pointer arith., make sure to use
1628 the size of the type, not the size of the pointer to
1631 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1634 * class.cs (Class): Added error CS0502 test.
1636 2004-08-03 John Luke <jluke@cfl.rr.com>
1637 Raja R Harinath <rharinath@novell.com>
1640 * attribute.cs (Attribute.complained_before): New flag.
1641 (Attribute.ResolveType, Attribute.Resolve),
1642 (Attribute.DefinePInvokeMethod): Set it.
1643 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
1645 2004-08-03 Martin Baulig <martin@ximian.com>
1647 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1648 use a user-defined operator; we still need to do numeric
1649 promotions in case one argument is a builtin type and the other
1650 one has an implicit conversion to that type. Fixes #62322.
1652 2004-08-18 Martin Baulig <martin@ximian.com>
1654 * class.cs (Method.Define): Use the correct method name when
1655 creating the MethodBuilder for a generic method.
1657 2004-08-17 Martin Baulig <martin@ximian.com>
1659 * generic.cs (Constraints): Support type parameter constraints.
1661 2004-08-16 Martin Baulig <martin@ximian.com>
1663 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
1664 (Token.GENERIC_DIMENSION): New token; this is returned if we
1665 encounter an unbound generic type in a typeof() expression.
1667 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
1668 this token is only generated while parsing a typeof() expression.
1669 (typeof_expression): Removed the old unbound_type hack.
1671 * generic.cs (TypeArguments.IsUnbound): New public property.
1673 * decl.cs (MemberName): Added support for unbound types.
1675 2004-08-14 Martin Baulig <martin@ximian.com>
1678 (TypeManager.IsEqualGenericInstance): New static method.
1679 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
1680 just used to check accessibility, so follow the rules of 26.1.6.
1682 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
1683 ConstructedType instead of a TypeExpression if we have type arguments.
1685 * cs-parser.jay (typeof_expression): Support unbound generic types.
1687 * ecore.cs (UnboundTypeExpression): New public class.
1689 2004-08-12 Martin Baulig <martin@ximian.com>
1691 * typemanager.cs (TypeManager.IsNestedChildOf): Use
1692 TypeManager.IsEqual() rather than `=='.
1694 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
1695 generic instances as well.
1697 2004-08-12 Martin Baulig <martin@ximian.com>
1699 * expression.cs (Invocation.InferType): We can only infer method
1700 type parameters. Fixes #62647.
1702 2004-08-11 Martin Baulig <martin@ximian.com>
1704 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
1705 before resolving the base classes.
1707 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1709 * Makefile: install .mdb file too.
1711 2004-08-05 Martin Baulig <martin@ximian.com>
1713 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
1714 initializer, the current type is just the TypeBuilder, not the
1715 instantiated generic type.
1716 (FieldExpr.IsFieldInitializer): New public property.
1718 2004-08-04 Martin Baulig <martin@ximian.com>
1720 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1722 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1724 2004-08-03 Martin Baulig <martin@ximian.com>
1726 * class.cs (MethodData.Define): If we're an explicit
1727 implementation, remove the generic arity from the type name.
1729 2004-08-03 Martin Baulig <martin@ximian.com>
1731 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1732 use a user-defined operator; we still need to do numeric
1733 promotions in case one argument is a builtin type and the other
1734 one has an implicit conversion to that type. Fixes #62322.
1736 2004-08-02 Martin Baulig <martin@ximian.com>
1738 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
1740 (TypeContainer.GetClassBases): Return the unexpanded list of
1741 interfaces; we expand them later.
1742 (TypeContainer.DefineType): After creating the TypeBuilder, call
1743 TypeManager.ExpandInterfaces() to get an expanded and resolved
1746 * ecore.cs (TypeExpr.GetInterfaces): Removed
1748 * generics.cs (Constraints.InterfaceConstraints): Remove.
1749 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
1750 register the interface constraints.
1753 (TypeManager.AddUserType): Removed the `ifaces' argument.
1754 (TypeManager.AddTypeParameter): Likewise.
1755 (TypeManager.AddUserInterface): Removed, was unused.
1756 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
1757 `TypeExpr[]' array for the interfaces.
1758 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
1759 has been defined, returns a list of the resolved interfaces types.
1760 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
1761 (TypeManager.GetExplicitInterfaces): Likewise.
1763 2004-08-02 Martin Baulig <martin@ximian.com>
1765 * expression.cs (Invocation.EmitCall): If we're invoking a method
1766 on a type parameter, use the new `Constrained' prefix opcode.
1768 2004-08-02 Martin Baulig <martin@ximian.com>
1770 * statement.cs (LocalInfo.Flags): Added `IsThis'.
1771 (LocalInfo.IsThis): New public property.
1772 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
1774 2004-08-01 Martin Baulig <martin@ximian.com>
1776 * class.cs (TypeContainer.GetClassBases): Don't set the default
1777 here since we may get called from GetPartialBases().
1778 (TypeContainer.DefineType): If GetClassBases() didn't return a
1779 parent, use the default one.
1781 2004-07-30 Martin Baulig <martin@ximian.com>
1783 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
1785 * class.cs (SourceMethod): New public class, derive from the
1786 symbol writer's ISourceMethod.
1787 (Method): Use the new symbol writer API.
1789 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
1790 as argument and use the new symbol writer.
1793 (SourceFile): Implement the symbol writer's ISourceFile.
1794 (Location.SymbolDocument): Removed.
1795 (Location.SourceFile): New public property.
1797 * symbolwriter.cs: Use the new symbol writer API.
1799 2004-07-30 Raja R Harinath <rharinath@novell.com>
1801 * Makefile (install-local): Remove. Functionality moved to
1804 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
1806 * Makefile: Install mcs.exe.config file together with mcs.exe.
1807 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
1808 correct runtime version.
1810 2004-07-25 Martin Baulig <martin@ximian.com>
1813 (TypeContainer.RegisterOrder): Removed, this was unused.
1814 (TypeContainer, interface_order): Removed.
1815 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
1816 TypeContainer as argument since we can also be called with a
1817 `PartialContainer' for a partial class/struct/interface.
1818 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
1819 of checking whether we're an `Interface' - we could be a
1821 (PartialContainer.Register): Override; call
1822 AddClass()/AddStruct()/AddInterface() on our parent.
1824 * cs-parser.jay (interface_member_declaration): Add things to the
1825 `current_container', not the `current_class'.
1827 * rootcontext.cs (RegisterOrder): The overloaded version which
1828 takes an `Interface' was unused, removed.
1830 * typemanager.cs (TypeManager.LookupInterface): Return a
1831 `TypeContainer', not an `Interface'.
1832 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
1833 contain a `PartialContainer' for an interface, so check it's
1834 `Kind' to figure out what it is.
1836 2004-07-25 Martin Baulig <martin@ximian.com>
1838 * class.cs (Class.DefaultTypeAttributes): New public constant.
1839 (Struct.DefaultTypeAttributes): Likewise.
1840 (Interface.DefaultTypeAttributes): Likewise.
1841 (PartialContainer.TypeAttr): Override this and add the
1842 DefaultTypeAttributes.
1844 2004-07-25 Martin Baulig <martin@ximian.com>
1846 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
1847 we can just use the `Parent' field instead.
1849 2004-07-25 Martin Baulig <martin@ximian.com>
1851 * class.cs (TypeContainer.Emit): Renamed to EmitType().
1853 2004-07-25 Martin Baulig <martin@ximian.com>
1855 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
1856 our parts before defining any methods.
1857 (TypeContainer.VerifyImplements): Make this virtual.
1858 (ClassPart.VerifyImplements): Override and call VerifyImplements()
1859 on our PartialContainer.
1861 2004-07-25 Martin Baulig <martin@ximian.com>
1863 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
1865 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
1866 argument, we can just use the `Parent' field instead.
1869 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
1870 (MemberBase.DoDefine): Likewise.
1872 2004-07-24 Martin Baulig <martin@ximian.com>
1874 * decl.cs (MemberCore.Parent): New public field.
1875 (DeclSpace.Parent): Moved to MemberCore.
1877 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
1878 (MemberBase.ctor): Added TypeContainer argument, pass it to our
1880 (FieldBase, Field, Operator): Likewise.
1881 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
1882 (EventField, Event): Likewise.
1884 2004-07-23 Martin Baulig <martin@ximian.com>
1886 * class.cs (PartialContainer): New public class.
1887 (ClassPart): New public class.
1888 (TypeContainer): Added support for partial classes.
1889 (TypeContainer.GetClassBases): Splitted some of the functionality
1890 out into GetNormalBases() and GetPartialBases().
1892 * cs-tokenizer.cs (Token.PARTIAL): New token.
1893 (Tokenizer.consume_identifier): Added some hacks to recognize
1894 `partial', but only if it's immediately followed by `class',
1895 `struct' or `interface'.
1897 * cs-parser.jay: Added support for partial clases.
1899 2004-07-23 Martin Baulig <martin@ximian.com>
1901 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
1902 a `DeclSpace' and also made it readonly.
1903 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
1904 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
1905 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
1907 * cs-parser.jay: Pass the `current_class', not the
1908 `current_container' (at the moment, this is still the same thing)
1909 to a new Method, Property, Event, Indexer or Constructor.
1911 2004-07-23 Martin Baulig <martin@ximian.com>
1913 * cs-parser.jay (CSharpParser): Added a new `current_class' field
1914 and removed the `current_interface' one.
1915 (struct_declaration, class_declaration, interface_declaration):
1916 Set `current_class' to the newly created class/struct/interface;
1917 set their `Bases' and call Register() before parsing their body.
1919 2004-07-23 Martin Baulig <martin@ximian.com>
1921 * class.cs (Kind): New public enum.
1922 (TypeContainer): Made this class abstract.
1923 (TypeContainer.Kind): New public readonly field.
1924 (TypeContainer.CheckDef): New public method; moved here from
1926 (TypeContainer.Register): New public abstract method.
1927 (TypeContainer.GetPendingImplementations): New public abstract
1929 (TypeContainer.GetClassBases): Removed the `is_class' and
1930 `is_iface' parameters.
1931 (TypeContainer.DefineNestedTypes): Formerly known as
1933 (ClassOrStruct): Made this class abstract.
1935 * tree.cs (RootTypes): New public type.
1937 2004-07-20 Martin Baulig <martin@ximian.com>
1939 * tree.cs (Tree.RecordNamespace): Removed.
1940 (Tree.Namespaces): Removed.
1942 * rootcontext.cs (RootContext.IsNamespace): Removed.
1944 * cs-parser.jay (namespace_declaration): Just create a new
1945 NamespaceEntry here.
1947 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
1949 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
1950 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
1951 entry to make sure it runs in the correct runtime version.
1953 2004-07-18 Martin Baulig <martin@ximian.com>
1955 * generic.cs (ConstructedType.CheckConstraints): Improved
1956 constraints checking.
1958 2004-07-18 Martin Baulig <martin@ximian.com>
1960 * expression.cs (Invocation.BetterMethod): Call
1961 TypeManager.TypeToCoreType() on all types and removed my previous
1962 hack; we're already doig the right thing here.
1964 2004-07-17 Martin Baulig <martin@ximian.com>
1966 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
1968 2004-07-16 Martin Baulig <martin@ximian.com>
1970 * iterators.cs: Added generics support.
1972 2004-07-16 Martin Baulig <martin@ximian.com>
1974 * iterators.cs: Rewrote this. We're now using one single Proxy
1975 class for both the IEnumerable and the IEnumerator interface and
1976 `Iterator' derives from Class so we can use the high-level API.
1978 * class.cs (TypeContainer.AddIterator): New method.
1979 (TypeContainer.DoDefineType): New protected virtual method, which
1980 is called from DefineType().
1981 (TypeContainer.DoDefineMembers): Call DefineType() and
1982 DefineMembers() on all our iterators.
1983 (TypeContainer.Emit): Call Emit() on all our iterators.
1984 (TypeContainer.CloseType): Call CloseType() on all our iterators.
1986 * codegen.cs (EmitContext.CurrentIterator): New public field.
1988 2004-07-15 Martin Baulig <martin@ximian.com>
1991 (TypeManager.not_supported_exception_type): New type.
1993 2004-07-14 Martin Baulig <martin@ximian.com>
1996 (TypeManager.generic_ienumerable_type): New type.
1997 (TypeManager.generic_ienumerator_type): New type.
2000 (RootContext.interfaces_first_stage): Added
2001 "System.Collections.Generic.IEnumerator`1" and
2002 "System.Collections.Generic.IEnumerable`1".
2004 2004-07-14 Martin Baulig <martin@ximian.com>
2006 * iterators.cs: Use real error numbers.
2008 2004-07-14 Martin Baulig <martin@ximian.com>
2010 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2011 requires this to be a System.Collection.IEnumerable and not a
2012 class implementing that interface.
2013 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2015 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2017 * class.cs: Fixed previous fix, it broke some error tests.
2019 2004-07-12 Martin Baulig <martin@ximian.com>
2021 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2024 2004-07-14 Martin Baulig <martin@ximian.com>
2026 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
2027 an exclamation mark (!) for the generic arity to reflect the
2028 latest spec changes; ie. use "System.Collections.Generic.IList`1".
2030 2004-07-13 Martin Baulig <martin@ximian.com>
2032 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
2033 specifiers being part of a type argument.
2035 2004-07-13 Martin Baulig <martin@ximian.com>
2037 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
2038 name for generic types.
2040 2004-07-13 Martin Baulig <martin@ximian.com>
2042 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
2045 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2047 * assign.cs (LocalTemporary): Add new argument: is_address,If
2048 `is_address' is true, then the value that we store is the address
2049 to the real value, and not the value itself.
2051 * ecore.cs (PropertyExpr): use the new local temporary
2052 stuff to allow us to handle X.Y += z (where X is a struct)
2054 2004-07-08 Martin Baulig <martin@ximian.com>
2056 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2057 not always return, just like we're doing in Using.Resolve().
2059 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2061 * cs-parser.jay (fixed_statement): flag this as Pinned.
2063 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2065 * typemanager.cs (TypeManager): Removed MakePinned method, this
2066 mechanism is replaced with the .NET 2.x compatible mechanism of
2067 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2069 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2070 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2071 `IsFixed' property which has a different meaning.
2073 2004-07-02 Raja R Harinath <rharinath@novell.com>
2075 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2076 visible from inside a nested class, not just the names of the
2077 immediately enclosing class.
2080 2004-06-24 Raja R Harinath <rharinath@novell.com>
2082 * expression.cs (BetterConversion): Remove buggy special-case
2083 handling of "implicit constant expression conversions". At this
2084 point, we already know that the conversion is possible -- we're
2085 only checking to see which is better.
2087 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2089 * cs-parser.jay: Added error CS0210 test.
2091 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2093 * cs-parser.jay: Added error CS0134 test.
2095 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2098 * cs-parser.jay: Added error CS0145 test.
2100 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2102 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2104 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2106 * expression.cs (StackAlloc.Resolve): The argument may not
2107 be a constant; deal with this case.
2109 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2111 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2112 GetIndexerAttributeValue.
2113 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2115 * class.cs (Indexer.Define): Added error tests for CS0415,
2118 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2120 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2123 2004-06-23 Martin Baulig <martin@ximian.com>
2125 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2126 neither return nor throw, reset the barrier as well. Fixes #60457.
2128 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2130 * class.cs : EventAttributes is now set to None by default.
2131 This fixes bug #60459.
2133 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2136 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2137 Don't throw exception but return null (it's sufficient now).
2139 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2141 * typemanager.cs (GetArgumentTypes): Faster implementation.
2143 2004-06-18 Martin Baulig <martin@ximian.com>
2145 * attribute.cs (Attribute.Resolve): Check whether we're an
2146 EmptyCast which a Constant child. Fixes #60333.
2148 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2150 * statement.cs (EmitCollectionForeach): Account for the fact that
2151 not all valuetypes are in areas which we can take the address of.
2152 For these variables, we store to a temporary variable. Also, make
2153 sure that we dont emit a `callvirt' on a valuetype method.
2155 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2157 * expression.cs (StackAlloc.DoReSolve): Added test for
2158 negative parameter (CS0247).
2160 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2163 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2165 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2168 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2171 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2173 Fix bug #58254 & cs1555.cs, cs1556.cs
2174 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2176 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2178 * cs-parser.jay: Added error CS1669 test for indexers.
2180 2004-06-18 Martin Baulig <martin@ximian.com>
2182 * generics.cs (GenericMethod.ctor): Don't take an Attributes
2183 argument. Fixes #60441.
2185 2004-06-16 Ben Maurer <bmaurer@ximian.com>
2186 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
2187 The name needs to have the actual name of the method in order
2188 for other tests (such as the one in OverloadResolve for Invoke
2189 on a delegate) to work. As well, it does not really help
2190 error reporting because the method group had multiple methods.
2191 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
2192 Make profiling work.
2194 2004-06-13 Martin Baulig <martin@ximian.com>
2196 * cs-parser.jay: Don't allow generic attributes.
2198 2004-06-13 Martin Baulig <martin@ximian.com>
2200 * class.cs (MemberBase.DoDefineBase): New protected method.
2201 (MemberBase.DoDefine): Compute the `flags' in the new
2202 DoDefineBase() which must be called first.
2203 (Method.Define): Call DoDefineBase() first so we have the flags
2204 when defining the generic method.
2206 * cs-parser.jay (interface_method_declaration): Support generic methods.
2208 2004-06-13 Martin Baulig <martin@ximian.com>
2210 * decl.cs (TypeName): Removed.
2211 (MemberName): Removed TypeName and MemberNow; now we just have
2214 * cs-parser.jay: Don't distinguish between type arguments and type
2215 parameters in the grammar and simplified the rules a bit. The
2216 reduce/reduce conflicts are now gone (except the one we inherited
2219 2004-06-11 Martin Baulig <martin@ximian.com>
2221 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2222 call this twice: for params and varargs methods.
2224 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2227 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2229 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2231 * attribute.cs (Attribute.GetValidTargets): Made public.
2234 (AbstractPropertyEventMethod): New class for better code sharing.
2235 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2237 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2239 2004-06-09 Martin Baulig <martin@ximian.com>
2241 * cs-parser.jay: Removed a reduce/reduce conflict.
2243 2004-06-03 Martin Baulig <martin@ximian.com>
2245 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
2246 GetSimpleName() and return a SimpleName.
2248 * ecore.cs (SimpleName.Arguments): New public field.
2249 (SimpleName): Added overloaded ctor which takes an additional
2250 TypeArguments argument.
2251 (SimpleName.SimpleNameResolve): Added support for generic methods.
2252 (MethodGroupExpr.ResolveGeneric): New public method. The code was
2253 formerly in MemberAccess.DoResolve(), but we also need it in
2254 SimpleNameResolve().
2256 * expression.cs (MemberAccess.DoResolve): Use the new
2257 MethodGroupExpr.ResolveGeneric().
2259 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2261 * decl.cs: If possible, use lookuptypedirect here. We can only do
2262 this if there is no `.' after the namespace. Avoids using
2263 LookupType, which does lots of slow processing.
2264 (FindNestedType) New method, does what it says :-).
2265 * namespace.cs: use LookupTypeDirect.
2266 * rootcontext.cs: use membercache, if possible.
2267 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2269 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2272 According to the spec,
2274 In a member access of the form E.I, if E is a single identifier,
2275 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2276 field, property, localvariable, or parameter with the same type as
2277 the meaning of E as a type-name (§3.8), then both possible
2278 meanings of E are permitted.
2280 We did not check that E as a simple-name had the same type as E as
2283 This trivial check gives us 5-7% on bootstrap time.
2285 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2287 * expression.cs (Invocation.OverloadResolve): Avoid the
2288 use of hashtables and boxing here by allocating on demand.
2290 2004-05-30 Martin Baulig <martin@ximian.com>
2292 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2293 we're doing a silent lookup. Don't try to lookup nested types in
2294 TypeManager.object_type (thanks to Ben Maurer).
2296 2004-05-30 Martin Baulig <martin@ximian.com>
2298 Committing a patch from Ben Maurer.
2300 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2302 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2304 * convert.cs: add a trivial cache for overload operator resolution.
2306 2004-05-31 Marek Safar <marek.safar@seznam.cz>
2309 (AttributeTester.GetObsoleteAttribute): Returns instance of
2310 ObsoleteAttribute when type is obsolete.
2313 (TypeContainer.VerifyObsoleteAttribute): Override.
2314 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2315 (MethodCode.VerifyObsoleteAttribute): Override.
2316 (MemberBase.VerifyObsoleteAttribute): Override.
2319 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2320 and report proper error.
2323 (Delegate.VerifyObsoleteAttribute): Override.
2326 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2327 and report proper error.
2328 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2331 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2335 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2336 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2337 Added test for ObsoleteAttribute.
2340 (Catch): Derived from Statement.
2342 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2344 * decl.cs: If possible, use lookuptypedirect here. We can only do
2345 this if there is no `.' after the namespace. Avoids using
2346 LookupType, which does lots of slow processing.
2347 (FindNestedType) New method, does what it says :-).
2348 * namespace.cs: use LookupTypeDirect.
2349 * rootcontext.cs: use membercache, if possible.
2350 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2352 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2355 According to the spec,
2357 In a member access of the form E.I, if E is a single identifier,
2358 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2359 field, property, localvariable, or parameter with the same type as
2360 the meaning of E as a type-name (§3.8), then both possible
2361 meanings of E are permitted.
2363 We did not check that E as a simple-name had the same type as E as
2366 This trivial check gives us 5-7% on bootstrap time.
2368 2004-05-30 Marek Safar <marek.safar@seznam.cz>
2370 Fixed bug #59071 & cs0160.cs
2371 * statement.cs (Try.Resolve): Check here whether order of catch
2372 clauses matches their dependencies.
2374 2004-05-30 Marek Safar <marek.safar@seznam.cz>
2377 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
2380 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2382 * expression.cs (Invocation.OverloadResolve): Avoid the
2383 use of hashtables and boxing here by allocating on demand.
2385 2004-05-30 Martin Baulig <martin@ximian.com>
2387 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2388 we're doing a silent lookup. Don't try to lookup nested types in
2389 TypeManager.object_type (thanks to Ben Maurer).
2391 2004-05-30 Martin Baulig <martin@ximian.com>
2393 Committing a patch from Ben Maurer.
2395 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2397 2004-05-29 Martin Baulig <martin@ximian.com>
2399 * class.cs (IMethodData.ShouldIgnore): New method.
2401 * typemanager.cs (TypeManager.MethodFlags): Don't take a
2402 `Location' argument, we don't need it anywhere. Use
2403 `IMethodData.ShouldIgnore ()' instead of
2404 `MethodData.GetMethodFlags ()'.
2405 (TypeManager.AddMethod): Removed.
2406 (TypeManager.AddMethod2): Renamed to AddMethod.
2408 2004-05-29 Martin Baulig <martin@ximian.com>
2410 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
2412 * convert.cs (Convert.ImplicitReferenceConversion): If we're
2413 converting from a class type S to an interface type and we already
2414 have an object on the stack, don't box it again. Fixes #52578.
2416 2004-05-29 Martin Baulig <martin@ximian.com>
2418 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2419 Added support for `params' parameters. Fixes #59267.
2421 2004-05-29 Martin Baulig <martin@ximian.com>
2423 * literal.cs (NullPointer): Provide a private .ctor which sets
2424 `type' to TypeManager.object_type. Fixes #59048.
2426 2004-05-29 Martin Baulig <martin@ximian.com>
2428 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
2429 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
2431 * ecore.cs (EventExpr.instance_expr): Make the field private.
2433 2004-05-26 Marek Safar <marek.safar@seznam.cz>
2435 Fixed bug #50080 & cs0214-2.cs
2436 * expression.cs (Cast.DoResolve): Check unsafe context here.
2438 * statement.cs (Resolve.DoResolve): Likewise.
2440 2004-05-26 Martin Baulig <martin@ximian.com>
2442 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
2444 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
2445 (RootContext.LookupType): Pass down the `silent' flag.
2447 2004-05-25 Martin Baulig <martin@ximian.com>
2450 (MethodGroupExpr.IdenticalTypeName): New public property.
2451 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
2452 expression actually refers to a type.
2454 2004-05-25 Martin Baulig <martin@ximian.com>
2456 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
2457 for #56176 and made it actually work.
2459 2004-05-25 Martin Baulig <martin@ximian.com>
2461 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
2462 (FieldExpr, PropertyExpr): Override and implement
2463 CacheTemporaries. Fixes #52279.
2465 2004-05-25 Miguel de Icaza <miguel@ximian.com>
2467 * location.cs: In the new compiler listing a file twice is a
2468 warning, not an error.
2470 2004-05-24 Martin Baulig <martin@ximian.com>
2472 * enum.cs (Enum.DefineType): For the `BaseType' to be a
2473 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
2475 2004-05-24 Martin Baulig <martin@ximian.com>
2477 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
2478 walking the `using' list. Fixes #53921.
2480 2004-05-24 Martin Baulig <martin@ximian.com>
2482 * const.cs (Const.LookupConstantValue): Added support for
2483 EmptyCast's; fixes #55251.
2485 2004-05-24 Martin Baulig <martin@ximian.com>
2487 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
2488 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
2489 which does the CS0135 check. The reason is that we first need to
2490 check whether the variable actually exists.
2492 2004-05-24 Martin Baulig <martin@ximian.com>
2494 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
2495 than RootContext.LookupType() to find the explicit interface
2498 2004-05-24 Raja R Harinath <rharinath@novell.com>
2500 * Makefile: Simplify. Use executable.make.
2501 * mcs.exe.sources: New file. List of sources of mcs.exe.
2503 2004-05-24 Anders Carlsson <andersca@gnome.org>
2507 Use the invariant culture when doing String.Compare for CLS case
2510 2004-05-23 Martin Baulig <martin@ximian.com>
2512 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
2513 don't have any dots. Fixes #52622, added cs0246-8.cs.
2515 * namespace.cs (NamespaceEntry.Lookup): Likewise.
2517 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2519 * class.cs (MemberBase.Define): Reuse MemberType member for
2520 resolved type. Other methods can use it too.
2522 2004-05-23 Martin Baulig <martin@ximian.com>
2524 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
2525 the variable also exists in the current block (otherwise, we need
2526 to report a CS0103). Fixes #58670.
2528 2004-05-23 Martin Baulig <martin@ximian.com>
2530 * flowanalysis.cs (Reachability.Reachable): Compute this
2531 on-the-fly rather than storing it as a field.
2533 2004-05-23 Martin Baulig <martin@ximian.com>
2535 * flowanalysis.cs (Reachability.And): Manually compute the
2536 resulting `barrier' from the reachability.
2538 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2541 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
2542 instance of ObsoleteAttribute when symbol is obsolete.
2545 (IMethodData): Extended interface for ObsoleteAttribute support.
2547 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2549 * attribute.cs: Fix bug #55970
2551 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2555 (GetObsoleteAttribute): New method. Creates the instance of
2557 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
2558 ObsoleteAttribute when member is obsolete.
2559 (AttributeTester.Report_ObsoleteMessage): Common method for
2560 Obsolete error/warning reporting.
2563 (TypeContainer.base_classs_type): New member for storing parent type.
2566 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
2567 for this MemberCore.
2569 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2571 * attribute.cs, const.cs: Fix bug #58590
2573 2004-05-21 Martin Baulig <martin@ximian.com>
2575 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
2576 out parameters if the end of the method is unreachable. Fixes
2579 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2581 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
2582 Hari was right, why extra method.
2584 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2586 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
2588 2004-05-20 Martin Baulig <martin@ximian.com>
2590 * delegate.cs: Convert this file to Unix mode - like the original
2593 2004-05-20 Martin Baulig <martin@ximian.com>
2595 * attribute.cs: Convert this file to Unix mode - like the original
2598 2004-05-19 Marek Safar <marek.safar@seznam.cz>
2600 Fix bug #58688 (MCS does not report error when the same attribute
2603 * attribute.cs (Attribute.Emit): Distinction between null and default.
2605 2004-05-19 Raja R Harinath <rharinath@novell.com>
2607 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
2608 of a top-level attribute without an attribute target.
2609 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
2611 (Attribute.Conditional_GetConditionName),
2612 (Attribute.Obsolete_GetObsoleteMessage): Update.
2613 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
2614 part of ScanForIndexerName.
2615 (Attribute.CanIgnoreInvalidAttribute): New function.
2616 (Attribute.ScanForIndexerName): Move to ...
2617 (Attributes.ScanForIndexerName): ... here.
2618 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
2619 (Attributes.Search): New internal variant that can choose not to
2620 complain if types aren't resolved. The original signature now
2622 (Attributes.GetClsCompliantAttribute): Use internal variant, with
2623 complaints suppressed.
2624 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
2625 only if it not useful.
2626 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
2627 top-level for attributes that are shared between the assembly
2628 and a top-level class.
2629 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
2630 * class.cs: Update to reflect changes.
2631 (DefineIndexers): Fuse loops.
2632 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
2633 a couple more variants of attribute names.
2635 2004-05-18 Marek Safar <marek.safar@seznam.cz>
2637 Fix bug #52585 (Implemented explicit attribute declaration)
2640 (Attributable.ValidAttributeTargets): New abstract method. It gets
2641 list of valid attribute targets for explicit target declaration.
2642 (Attribute.Target): It holds target itself.
2643 (AttributeSection): Removed.
2644 (Attribute.CheckTargets): New method. It checks whether attribute
2645 target is valid for the current element.
2648 (EventProperty): New class. For events that are declared like
2649 property (with add and remove accessors).
2650 (EventField): New class. For events that are declared like field.
2653 * cs-parser.jay: Implemented explicit attribute target declaration.
2655 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
2656 Override ValidAttributeTargets.
2659 (ReturnParameter): Class for applying custom attributes on
2661 (ParameterAtribute): New class. Class for applying custom
2662 attributes on the parameter type.
2664 2004-05-17 Miguel de Icaza <miguel@ximian.com>
2666 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
2669 (Method): Allow UNSAFE here.
2671 * modifiers.cs: Support unsafe reporting.
2673 2004-05-17 Marek Safar <marek.safar@seznam.cz>
2675 * decl.cs: Fix bug #58478.
2677 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2679 * statement.cs: When checking for unreachable code on an EmptyStatement,
2680 set the location. Fixes bug #58488.
2682 2004-05-13 Miguel de Icaza <miguel@ximian.com>
2684 * driver.cs: Add -pkg handling.
2686 From Gonzalo: UseShelLExecute=false
2688 2004-05-12 Marek Safar <marek.safar@seznam.cz>
2691 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
2693 (Attribute.IsClsCompliaceRequired): Moved to base for better
2695 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
2696 when attribute is AttributeUsageAttribute.
2697 (Attribute.GetValidTargets): Simplified.
2698 (Attribute.GetAttributeUsage): New method returns AttributeUsage
2699 attribute for this type.
2700 (Attribute.ApplyAttributes): Method renamed to Emit and make
2702 (GlobalAttributeSection): New class for special handling of global
2703 attributes (assembly, module).
2704 (AttributeSection.Emit): New method.
2706 * class.cs: Implemented Attributable abstract methods.
2707 (MethodCore.LabelParameters): Moved to Parameter class.
2708 (Accessor): Is back simple class.
2709 (PropertyMethod): Implemented Attributable abstract class.
2710 (DelegateMethod): Implemented Attributable abstract class.
2711 (Event): New constructor for disctintion between normal Event
2712 and Event with accessors.
2714 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
2716 * codegen.cs, const.cs, decl.cs, delegate.cs:
2717 (CommonAssemblyModulClass): Implemented Attributable abstract class
2720 * enum.cs: Implement IAttributeSupport interface.
2721 (EnumMember): New class for emum members. Implemented Attributable
2725 (ParameterBase): Is abstract.
2726 (ReturnParameter): New class for easier [return:] attribute handling.
2728 * typemanager.cs: Removed builder_to_attr.
2730 2004-05-11 Raja R Harinath <rharinath@novell.com>
2733 * attribute.cs (Attribute.GetPositionalValue): New function.
2734 * class.cs (TypeContainer.VerifyMembers): New function.
2735 (TypeContainer.Emit): Use it.
2736 (ClassOrStruct): New base class for Class and Struct.
2737 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
2738 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
2740 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
2741 then each non-static field should have a FieldOffset attribute.
2742 Otherwise, none of the fields should have a FieldOffset attribute.
2743 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
2744 and FieldOffset attributes.
2745 * typemanager.cs (TypeManager.struct_layout_attribute_type)
2746 (TypeManager.field_offset_attribute_type): New core types.
2747 (TypeManager.InitCoreTypes): Initialize them.
2749 2004-05-11 Michal Moskal <malekith@pld-linux.org>
2751 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
2752 Return correct type.
2755 2004-05-09 Miguel de Icaza <miguel@ximian.com>
2757 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
2758 be implicitly converted to ulong.
2760 * expression.cs: The logic for allowing operator &, | and ^ worked
2761 was wrong, it worked before because we did not report an error in
2762 an else branch. Fixes 57895.
2764 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
2765 allow volatile fields to be reference types.
2767 2004-05-07 Miguel de Icaza <miguel@ximian.com>
2769 * driver.cs: Add support for /debug-
2771 2004-05-07 Raja R Harinath <rharinath@novell.com>
2773 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
2774 Add a 'complain' parameter to silence errors.
2775 (Attribute.Resolve): Update to changes. Put in sanity check to catch
2776 silently overlooked type-resolutions.
2777 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
2779 (Attributes.Search): New function.
2780 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
2781 (Attributes.GetAttributeFullName): Remove hack.
2782 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
2783 Update to reflect changes.
2784 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
2785 Use Attributes.Search instead of nested loops.
2787 2004-05-07 Marek Safar <marek.safar@seznam.cz>
2790 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
2791 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
2792 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
2794 * report.cs: (Report.Warning): Renamed to Warning_T because of
2795 parameter collision.
2797 2004-05-05 Raja R Harinath <rharinath@novell.com>
2799 * expression.cs (MemberAccess.ResolveMemberAccess):
2800 Exit with non-zero status after Report.Error.
2801 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
2803 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
2805 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2807 * support.cs: Don't hang when the file is empty.
2809 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2811 * support.cs: In SeekableStreamReader, compute the preamble size of the
2812 underlying stream. Position changes should take into account that initial
2815 2004-05-03 Todd Berman <tberman@sevenl.net>
2817 * driver.cs: remove unused GetSysVersion function.
2819 2004-05-03 Todd Berman <tberman@sevenl.net>
2821 * driver.cs: Remove the hack from saturday, as well as the hack
2822 from jackson (LoadAssemblyFromGac), also adds the CWD to the
2823 link_paths to get that bit proper.
2825 2004-05-01 Todd Berman <tberman@sevenl.net>
2827 * driver.cs: Try a LoadFrom before a Load, this checks the current
2828 path. This is currently a bug in mono that is be fixed, however, this
2829 provides a workaround for now. This will be removed when the bug
2832 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
2834 * CryptoConvert.cs: Updated to latest version. Fix issue with
2835 incomplete key pairs (#57941).
2837 2004-05-01 Todd Berman <tberman@sevenl.net>
2839 * driver.cs: Remove '.' from path_chars, now System.* loads properly
2842 2004-04-30 Jackson Harper <jackson@ximian.com>
2844 * codegen.cs: Open keys readonly.
2846 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2848 * typemanager.cs: don't report cyclic struct layout when a struct
2849 contains 2 or more fields of the same type. Failed for Pango.AttrShape
2850 which has 2 Pango.Rectangle fields.
2852 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
2854 * expression.cs: Handle IntPtr comparisons with IL code
2855 rather than a method call.
2857 2004-04-29 Martin Baulig <martin@ximian.com>
2859 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
2860 the list of PropertyInfo's in class hierarchy and find the
2861 accessor. Fixes #56013.
2863 2004-04-29 Martin Baulig <martin@ximian.com>
2865 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
2867 2004-04-29 Martin Baulig <martin@ximian.com>
2869 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2871 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
2873 2004-04-29 Martin Baulig <martin@ximian.com>
2875 * class.cs (ConstructorInitializer.Resolve): Check whether the
2876 parent .ctor is accessible. Fixes #52146.
2878 2004-04-29 Martin Baulig <martin@ximian.com>
2880 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2882 * statement.cs (Using.EmitLocalVariableDecls): Use
2883 TypeManager.idisposable_type, not typeof (IDisposable).
2884 (Foreach.EmitCollectionForeach): Added support for valuetypes.
2886 2004-04-29 Martin Baulig <martin@ximian.com>
2888 * class.cs (Event.Define): Don't emit the field and don't set
2889 RTSpecialName and SpecialName for events on interfaces. Fixes
2892 2004-04-29 Raja R Harinath <rharinath@novell.com>
2894 Refactor Attribute.ApplyAttributes.
2895 * attribute.cs (Attributable): New base class for objects that can
2896 have Attributes applied on them.
2897 (Attribute): Make AttributeUsage fields public.
2898 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
2899 (Attribute.IsInternalCall): New property.
2900 (Attribute.UsageAttr): Convert to a public read-only property.
2901 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
2902 (Attribute.ResolveType, Attribute.Resolve)
2903 (Attribute.ScanForIndexerName): Update to reflect changes.
2904 (Attribute.CheckAttributeTarget): Re-format.
2905 (Attribute.ApplyAttributes): Refactor, to various
2906 Attributable.ApplyAttributeBuilder methods.
2907 * decl.cs (MemberCore): Make Attributable.
2908 * class.cs (Accessor): Make Attributable.
2909 (MethodData.ApplyAttributes): Use proper attribute types, not
2911 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
2912 (TypeContainer.ApplyAttributeBuilder)
2913 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
2914 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
2915 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
2916 (Operator.ApplyAttributeBuilder): New factored-out methods.
2917 * const.cs (Const.ApplyAttributeBuilder): Likewise.
2918 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
2919 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
2920 * parameter.cs (ParameterBase): New Attributable base class
2921 that can also represent Return types.
2922 (Parameter): Update to the changes.
2924 2004-04-29 Jackson Harper <jackson@ximian.com>
2926 * driver.cs: Prefer the corlib system version when looking for
2927 assemblies in the GAC. This is still a hack, but its a better hack
2930 2004-04-29 Marek Safar <marek.safar@seznam.cz>
2932 * decl.cs, enum.cs: Improved error 3005 reporting.
2934 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
2935 (related_symbols): New private member for list of symbols
2936 related to reported error/warning.
2938 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
2940 2004-04-29 Martin Baulig <martin@ximian.com>
2942 * ecore.cs (Expression.Constantify): If we're an enum and
2943 TypeManager.TypeToCoreType() doesn't give us another type, use
2944 t.UnderlyingSystemType. Fixes #56178.
2946 2004-04-29 Martin Baulig <martin@ximian.com>
2948 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
2949 interfaces and for each interface, only add members directly
2950 declared in that interface. Fixes #53255.
2952 2004-04-28 Martin Baulig <martin@ximian.com>
2954 * expression.cs (ConditionalLogicalOperator): Use a temporary
2955 variable for `left' to avoid that we evaluate it more than once;
2958 2004-04-28 Martin Baulig <martin@ximian.com>
2960 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
2963 2004-04-28 Martin Baulig <martin@ximian.com>
2965 * statement.cs (LocalInfo.Resolve): Check whether the type is not
2968 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
2969 whether the type is not void (CS1547).
2971 2004-04-28 Martin Baulig <martin@ximian.com>
2973 * expression.cs (Unary.DoResolveLValue): Override this and report
2974 CS0131 for anything but Operator.Indirection.
2976 2004-04-28 Martin Baulig <martin@ximian.com>
2978 Committing a patch from Ben Maurer; see bug #50820.
2980 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
2983 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
2986 2004-04-28 Martin Baulig <martin@ximian.com>
2988 Committing a patch from Ben Maurer; see bug #50820.
2990 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
2993 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
2996 2004-04-28 Martin Baulig <martin@ximian.com>
2998 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
2999 (Block.AddLabel): Call DoLookupLabel() to only search in the
3002 2004-04-28 Martin Baulig <martin@ximian.com>
3004 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3005 comparing StringConstants and NullLiterals in Equality and Inequality.
3007 2004-04-28 Jackson Harper <jackson@ximian.com>
3009 * driver.cs: Attempt to load referenced assemblies from the
3010 GAC. This is the quick and dirty version of this method that
3011 doesnt take into account versions and just takes the first
3012 canidate found. Will be good enough for now as we will not have more
3013 then one version installed into the GAC until I update this method.
3015 2004-04-28 Martin Baulig <martin@ximian.com>
3017 * typemanager.cs (TypeManager.CheckStructCycles): New public
3018 static method to check for cycles in the struct layout.
3020 * rootcontext.cs (RootContext.PopulateTypes): Call
3021 TypeManager.CheckStructCycles() for each TypeContainer.
3022 [Note: We only need to visit each type once.]
3024 2004-04-28 Martin Baulig <martin@ximian.com>
3026 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3028 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3029 success and added `out object value'. Use a `bool resolved' field
3030 to check whether we've already been called rather than
3031 `ConstantValue != null' since this breaks for NullLiterals.
3033 2004-04-28 Raja R Harinath <rharinath@novell.com>
3035 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3036 setting of this flag, since the 'set' method may be non-public.
3038 2004-04-28 Raja R Harinath <rharinath@novell.com>
3040 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3041 check on current_vector.Block.
3043 2004-04-27 Martin Baulig <martin@ximian.com>
3045 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3046 a field initializer. Fixes #56459.
3048 2004-04-27 Martin Baulig <martin@ximian.com>
3050 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3051 we're not attempting to use an indexer. Fixes #52154.
3053 2004-04-27 Martin Baulig <martin@ximian.com>
3055 * statement.cs (Return): Don't create a return label if we don't
3056 need it; reverts my change from January 20th. Thanks to Ben
3059 2004-04-27 Martin Baulig <martin@ximian.com>
3061 According to the spec, `goto' can only leave a nested scope, but
3064 * statement.cs (Block.LookupLabel): Only lookup in the current
3065 block, don't recurse into parent or child blocks.
3066 (Block.AddLabel): Check in parent and child blocks, report
3067 CS0140/CS0158 if we find a duplicate.
3068 (Block): Removed this indexer for label lookups.
3069 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3070 this already does the error reporting for us.
3073 (FlowBranching.UsageVector.Block): New public variable; may be null.
3074 (FlowBranching.CreateSibling): Added `Block' argument.
3075 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3076 label for the target of a `goto' and check whether we're not
3077 leaving a `finally'.
3079 2004-04-27 Martin Baulig <martin@ximian.com>
3081 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3082 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3085 2004-04-27 Martin Baulig <martin@ximian.com>
3087 * statement.cs (Block.AddLabel): Also check for implicit blocks
3088 and added a CS0158 check.
3090 2004-04-27 Martin Baulig <martin@ximian.com>
3092 * flowanalysis.cs (FlowBranchingLoop): New class.
3093 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3094 UsageVector's instead of an ArrayList.
3095 (FlowBranching.Label): Likewise.
3096 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3097 (FlowBranching.AddBreakVector): New method.
3099 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3101 * attribute.cs: Small regression fix: only convert the type if we
3102 the type is different, fixes System.Drawing build.
3104 2004-04-27 Martin Baulig <martin@ximian.com>
3106 * attribute.cs (Attribute.Resolve): If we have a constant value
3107 for a named field or property, implicity convert it to the correct
3110 2004-04-27 Raja R Harinath <rharinath@novell.com>
3112 * statement.cs (Block.Block): Implicit blocks share
3113 'child_variable_names' fields with parent blocks.
3114 (Block.AddChildVariableNames): Remove.
3115 (Block.AddVariable): Mark variable as "used by a child block" in
3116 every surrounding block.
3117 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3118 been used in a child block, complain about violation of "Invariant
3119 meaning in blocks" rule.
3120 * cs-parser.jay (declare_local_variables): Don't use
3121 AddChildVariableNames.
3122 (foreach_statement): Don't create an implicit block: 'foreach'
3125 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3127 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3128 converting from 0L to ulong. Fixes 57522.
3130 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3132 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3133 derived class hides via 'new' keyword field from base class (test-242.cs).
3134 TODO: Handle this in the more general way.
3136 * class.cs (CheckBase): Ditto.
3138 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3140 * decl.cs (caching_flags): New member for storing cached values
3142 (MemberCore.Flags): New enum where bit flags for caching_flags
3144 (MemberCore.cls_compliance): Moved to caching_flags.
3145 (DeclSpace.Created): Moved to caching_flags.
3147 * class.cs: Use caching_flags instead of DeclSpace.Created
3149 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3151 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3152 if we are only a derived class, not a nested class.
3154 * typemanager.cs: Same as above, but do this at the MemberLookup
3155 level (used by field and methods, properties are handled in
3156 PropertyExpr). Allow for the qualified access if we are a nested
3159 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3161 * class.cs: Refactoring.
3162 (IMethodData): New inteface; Holds links to parent members
3163 to avoid member duplication (reduced memory allocation).
3164 (Method): Implemented IMethodData interface.
3165 (PropertyBase): New inner classes for get/set methods.
3166 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3167 (Event): New inner classes for add/remove methods.
3168 (Event.DelegateMethod): Implemented IMethodData interface.
3170 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3171 EmitContext (related to class.cs refactoring).
3173 2004-04-21 Raja R Harinath <rharinath@novell.com>
3175 * delegate.cs (Delegate.VerifyApplicability): If the number of
3176 arguments are the same as the number of parameters, first try to
3177 verify applicability ignoring any 'params' modifier on the last
3181 2004-04-08 Martin Baulig <martin@ximian.com>
3183 Merged latest changes into gmcs. Please keep this comment in
3184 here, it makes it easier for me to see what changed in MCS since
3185 the last time I merged.
3187 2004-04-16 Raja R Harinath <rharinath@novell.com>
3189 * class.cs (TypeContainer.AddIndexer): Use
3190 'ExplicitInterfaceName' to determine if interface name was
3191 explicitly specified. 'InterfaceType' is not initialized at this time.
3192 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3193 Indexers array is already in the required order. Initialize
3194 'IndexerName' only if there are normal indexers.
3195 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3196 (TypeContainer.Emit): Emit DefaultMember attribute only if
3197 IndexerName is initialized.
3200 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3202 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3205 2004-04-15 Raja R Harinath <rharinath@novell.com>
3207 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3211 * attribute.cs (Attribute.Resolve): Check for duplicate named
3215 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3217 * iterators.cs (MarkYield): track whether we are in an exception,
3218 and generate code accordingly. Use a temporary value to store the
3219 result for our state.
3221 I had ignored a bit the interaction of try/catch with iterators
3222 since their behavior was not entirely obvious, but now it is
3223 possible to verify that our behavior is the same as MS .NET 2.0
3227 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3229 * iterators.cs: Avoid creating temporaries if there is no work to
3232 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3233 Enumerations, use TypeManager.EnumToUnderlying and call
3236 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3239 (This.Emit): Use EmitContext.EmitThis to emit our
3242 (This.EmitAssign): Ditto.
3244 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3245 codepaths, we will move all the functionality into
3248 (FieldExpr.EmitAssign): Ditto.
3250 This fixes several hidden bugs that I uncovered while doing a code
3251 review of this today.
3253 * codegen.cs (EmitThis): reworked so the semantics are more clear
3254 and also support value types "this" instances.
3256 * iterators.cs: Changed so that for iterators in value types, we
3257 do not pass the value type as a parameter.
3259 Initialization of the enumerator helpers is now done in the caller
3260 instead of passing the parameters to the constructors and having
3261 the constructor set the fields.
3263 The fields have now `assembly' visibility instead of private.
3265 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3267 * expression.cs (Argument.Resolve): Check if fields passed as ref
3268 or out are contained in a MarshalByRefObject.
3270 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3271 another compiler type.
3273 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3275 * class.cs (Indexer.Define): use the new name checking method.
3276 Also, return false on an error.
3277 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3278 (is_identifier_[start/part]_character): make static.
3280 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3282 * expression.cs (Binary.ResolveOperator): Do no append strings
3283 twice: since we can be invoked more than once (array evaluation)
3284 on the same concatenation, take care of this here. Based on a fix
3285 from Ben (bug #56454)
3287 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3289 * codegen.cs: Fix another case where CS1548 must be reported (when
3290 delay-sign isn't specified and no private is available #56564). Fix
3291 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3292 error when MCS is used on the MS runtime and we need to delay-sign
3293 (which seems unsupported by AssemblyBuilder - see #56621).
3295 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3297 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3298 (TypeManager.ComputeNamespaces): Faster implementation for
3301 * compiler.csproj: Updated AssemblyName to mcs.
3303 2004-05-11 Jackson Harper <jackson@ximian.com>
3305 * Makefile: Preserve MONO_PATH
3307 2004-05-11 Jackson Harper <jackson@ximian.com>
3309 * Makefile: Use mono and mcs to build gmcs
3311 2004-05-03 Miguel de Icaza <miguel@ximian.com>
3313 * codegen.cs: Add patch from Robert Shade
3314 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
3317 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
3319 * CryptoConvert.cs: Updated to latest version. Fix issue with
3320 incomplete key pairs (#57941).
3322 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3324 * codegen.cs: Fix another case where CS1548 must be reported (when
3325 delay-sign isn't specified and no private is available #56564). Fix
3326 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3327 error when MCS is used on the MS runtime and we need to delay-sign
3328 (which seems unsupported by AssemblyBuilder - see #56621).
3330 2004-04-29 Jackson Harper <jackson@ximian.com>
3332 * Makefile: Set MONO_PATH to use the bootstrap corlib
3333 * driver.cs: Check the GAC for referenced assemblies.
3335 2004-04-29 Martin Baulig <martin@ximian.com>
3337 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
3339 2004-04-07 Martin Baulig <martin@ximian.com>
3341 * expression.cs (Binary.ResolveOperator): Added special case for
3342 Equality/Inequality between a type parameter and a null literal.
3344 2004-04-07 Martin Baulig <martin@ximian.com>
3346 * convert.cs: Check null literal -> type parameter conversions.
3348 2004-04-07 Martin Baulig <martin@ximian.com>
3350 * generic.cs (ConstructedType.CheckConstraints): Enforce the
3351 `class' and `struct' constraints.
3353 2004-04-07 Martin Baulig <martin@ximian.com>
3355 * generic.cs (SpecialConstraint): New public enum.
3356 (Constraints.Resolve): Added support for the `class' and `struct'
3359 * cs-parser.jay (type_parameter_constraint): Added support for the
3360 `class' and `struct' constraints.
3362 2004-04-07 Martin Baulig <martin@ximian.com>
3364 * support.cs (GenericConstraints): Replaced `Types' by
3365 `ClassConstraint' and `InterfaceConstraints'; added
3366 `HasClassConstraint'.
3368 2004-04-07 Martin Baulig <martin@ximian.com>
3371 (Constraints.InterfaceConstraints): New public property.
3372 (Constraints.Types): Make this property public
3373 (TypeParameter): Implement IMemberContainer.
3374 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
3375 instead of a TypeBuilder/MethodBuilder; pass the interface
3376 constraints to TypeManager.AddTypeParameter().
3377 (TypeParameter.DefineType): Just take an EmitContext and no
3378 TypeBuilder/MethodBuilder. Use the new public API.
3380 * typemanager.cs (TypeManager.AddTypeParameter): Added
3381 `TypeExpr[]' argument; add the interfaces to the
3382 `builder_to_ifaces' hash.
3383 (TypeManager.LookupMemberContainer): For
3384 GenericTypeParameterBuilders, get the TypeParameter from the
3385 `builder_to_type_param'.
3386 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
3387 the TypeParameter and call FindMembers on it.
3389 2004-04-07 Martin Baulig <martin@ximian.com>
3392 (MethodCore.GenericMethod): Moved this field here from Method.
3393 (MethodCore.IsDuplicateImplementation): Take the number of type
3394 parameters into account if we're a generic method.
3396 * expression.cs (Invocation.InferTypeArguments): Don't return true
3397 if `arguments' is null; we still need to check whether we actually
3398 don't need to infer anything in this case.
3399 (MemberAccess): Merged the functionality from GenericMemberAccess
3402 * generic.cs (GenericMemberAccess): Removed.
3404 2004-04-05 Martin Baulig <martin@ximian.com>
3406 * decl.cs (MemberCore): For generic classes, interfaces and
3407 structs, `Name' now includes the number of type parameters
3409 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
3410 encode the number of type arguments in the type name.
3412 * expression.cs (Expression.MemberLookup): Removed the
3413 `num_type_args' argument; we now encode the number of type
3414 arguments in the type name.
3416 * ecore.cs (SimpleName): Encode the number of type arguments in
3417 the type name itself.
3419 * generic.cs (ConstructedType): Likewise.
3421 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
3422 `MemberName'; we now include the number of type parameters in the
3425 * typemanager.cs (TypeManager.CheckGeneric): Removed.
3426 (TypeManager.MemberLookup): Removed the
3427 `num_type_args' argument; we now encode the number of type
3428 arguments in the type name.
3430 2004-04-03 Martin Baulig <martin@ximian.com>
3432 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
3433 (MemberCore.MemberName): Moved here from MemberBase.
3434 (DeclSpace.SetParameterInfo): Just take the constraints as an
3435 ArrayList; we already have the type parameters in our
3436 `MemberName'; also do the CS0080 reporting here.
3438 * cs-parser.jay (struct_declaration): Use `member_name' instead of
3439 `IDENTIFIER opt_type_parameter_list'; when constructing our
3440 `MemberName', it'll already include our type parameters.
3441 (class_declaration, interface_declaration): Likewise.
3442 (delegate_declaration): Likewise.
3443 (MakeName): Take a MemberName and return a MemberName.
3444 The following two changes are required to avoid shift/reduce conflicts:
3445 (member_name): Don't include a TypeName anymore; ie. this is now
3446 just 'IDENTIFIER opt_type_parameter_list'.
3447 (property_declaration, event_declaration): Use a
3448 `namespace_or_type_name' instead of a `member_name'.
3450 2004-04-03 Martin Baulig <martin@ximian.com>
3452 * decl.cs (MemberName): Renamed to `TypeName' and created a new
3454 (TypeName): Formerly known as MemberName.
3456 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
3457 instead of a `MemberName'.
3459 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
3460 (member_name): New rule; create a MemberName.
3462 2004-04-02 Martin Baulig <martin@ximian.com>
3464 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
3465 (CS0305 and CS0308).
3467 2004-04-02 Martin Baulig <martin@ximian.com>
3469 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
3470 support for nested types.
3472 2004-04-02 Martin Baulig <martin@ximian.com>
3474 * ecore.cs (IAlias): New public interface.
3475 (TypeExpr, TypeExpression): Implement IAlias.
3476 (TypeAliasExpression): New public class.
3478 * namespace.cs (Namespace): Implement IAlias.
3479 (Namespace.Lookup): Return an IAlias instead on an object.
3480 (Namespace.DefineName): Take an IAlias instead of an object.
3481 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
3483 (NamespaceEntry.UsingAlias): Take a Membername instead of an
3485 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
3487 (NamespaceEntry.Lookup): Likewise.
3489 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
3492 * decl.cs (DeclSpace): Implement IAlias.
3493 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
3495 * generic.cs (ConstructedType): Improved error checking.
3497 2004-04-02 Martin Baulig <martin@ximian.com>
3499 * convert.cs: Added type parameter conversions.
3502 (UnboxCast.Emit): Emit an `unbox.any' for type params.
3503 (ClassCast.Emit): If the source type is a type parameter, box it.
3504 If the target type is a type parameter, emit an `unbox.any'
3505 instead of a `classcast'.1
3507 2004-04-01 Martin Baulig <martin@ximian.com>
3509 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
3511 2004-04-01 Martin Baulig <martin@ximian.com>
3513 * generic.cs (ConstructedType.CheckConstraints): Use
3514 Convert.ImplicitStandardConversionExists(); user-defined implicit
3515 conversions are not allowed according to the spec.
3517 2004-03-30 Martin Baulig <martin@ximian.com>
3519 * expression.cs (New): Added support for type parameters.
3522 (TypeManager.activator_type): New public static field.
3523 (TypeManager.activator_create_instance): Likewise.
3525 2004-03-30 Martin Baulig <martin@ximian.com>
3527 * typemanager.cs (TypeManager.HasConstructorConstraint): New
3530 2004-03-30 Martin Baulig <martin@ximian.com>
3532 * generic.cs (ConstructedType.CheckConstraints): Actually follow
3533 the spec here: the argument type must be convertible to the
3536 2004-03-30 Martin Baulig <martin@ximian.com>
3539 (TypeParameter.Define, TypeParameter.DefineMethod): Call
3540 TypeManager.AddTypeParameter().
3541 (ConstructedType.CheckConstraints): Re-enable this and actually
3542 check whether we have a constructor constraint.
3545 (TypeManager.builder_to_type_param): New static field.
3546 (TypeManager.AddTypeParameter): New static method.
3547 (TypeManager.LookupTypeParameter): New public method.
3549 2004-03-30 Martin Baulig <martin@ximian.com>
3551 * generic.cs (TypeParameter.DefineType): Return a boolean and use
3552 the new API to actually define the constructor constraint.
3555 (TypeManager.new_constraint_attr_type): New static field.
3556 (TypeManager.InitCoreTypes): Initialize it.
3558 2004-03-30 Martin Baulig <martin@ximian.com>
3560 * generic.cs (Constraints): Completed error checking, use correct
3563 2004-03-29 Martin Baulig <martin@ximian.com>
3565 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
3567 * expression.cs (Invocation.InferTypeArguments): Added overloaded
3568 public version which takes a `ParameterData pd' instead of an
3571 2004-03-29 Martin Baulig <martin@ximian.com>
3573 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
3576 2004-03-29 Martin Baulig <martin@ximian.com>
3578 * expression.cs (Argument.ResolveMethodGroup): If we're a
3579 ConstructedType, call GetMemberAccess() on it.
3581 2004-03-29 Martin Baulig <martin@ximian.com>
3583 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
3584 (MethodCore.CheckGenericOverride): When overriding a generic
3585 method, check whether the constraints match.
3587 * support.cs (GenericConstraints): New public interface.
3588 (ParameterData.GenericConstraints): New public method.
3590 * parameter.cs (Parameter.Resolve): Check whether we're a generic
3591 method parameter and compute our constraints if appropriate.
3592 (Parameter.GenericConstraints): New public property.
3594 * generic.cs (Constraints): Implement GenericConstraints.
3596 2004-03-29 Martin Baulig <martin@ximian.com>
3598 * decl.cs (MemberCache.FindMemberToOverride): Use
3599 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
3601 2004-03-29 Martin Baulig <martin@ximian.com>
3603 * generic.cs (GenericMethod.Define): Resolve our type parameters.
3605 2004-03-29 Martin Baulig <martin@ximian.com>
3607 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
3608 not allowed on non-generic declarations").
3610 2004-03-29 Martin Baulig <martin@ximian.com>
3612 * expression.cs (Invocation.InferTypeArguments): Added overloaded
3613 public version of this method.
3615 * class.cs (MethodCore.IsDuplicateImplementation): Use
3616 Invocation.InferTypeArguments() to check this.
3618 2004-03-29 Martin Baulig <martin@ximian.com>
3620 * convert.cs: Use TypeManager.IsDelegateType() instead of
3621 comparing types correctly.
3623 2004-03-29 Martin Baulig <martin@ximian.com>
3625 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
3626 types directly to make it work for generic instances.
3628 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
3630 2004-03-29 Martin Baulig <martin@ximian.com>
3632 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
3635 2004-03-24 Martin Baulig <martin@ximian.com>
3637 * decl.cs (DeclSpace.FindType): Also use
3638 TypeManager.CheckGeneric() for types from the using clauses.
3640 2004-03-23 Martin Baulig <martin@ximian.com>
3642 * expression.cs (Invocation.OverloadResolve): Added `bool
3643 may_fail' argument and use it instead of the Location.IsNull() hack.
3645 2004-03-23 Martin Baulig <martin@ximian.com>
3647 * expression.cs (Invocation.InferType): Use correct type inference
3650 2004-03-23 Martin Baulig <martin@ximian.com>
3652 * ecore.cs (MethodGroupExpr.Name): Use
3653 TypeManager.CSharpSignature() instead of just the name.
3655 * expression.cs (Invocation.OverloadResolve): Provide better error
3657 (Invocation.DoResolve): OverloadResolve() never returns null
3658 without reporting an error, so removed the error -6 reporting here.
3660 2004-03-23 Martin Baulig <martin@ximian.com>
3662 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
3665 * cs-parser.jay (delegate_declaration): Support generic delegates.
3667 * delegate.cs: Support generic delegates.
3669 2004-03-22 Martin Baulig <martin@ximian.com>
3671 * expression.cs (Invocation.InferParamsTypeArguments): New static
3672 method; does type inference for params arguments.
3674 2004-03-21 Martin Baulig <martin@ximian.com>
3676 * typemanager.cs (TypeManager.IsGenericMethod): New public static
3677 method; checks whether a method is a generic method.
3679 * expression.cs (Invocation.InferTypeArguments): New static method;
3680 infer type arguments for generic method invocation.
3682 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
3683 property; we set this to true if we're resolving a generic method
3684 invocation and the user specified type arguments, ie. we're not
3685 doing type inference.
3687 2004-03-20 Martin Baulig <martin@ximian.com>
3689 * class.cs (MethodData.DeclaringType): New public property.
3690 (MethodData.Define): Set DeclaringType here.
3691 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
3692 instead of OperatorMethodBuilder.DeclaringType.
3694 2004-03-20 Martin Baulig <martin@ximian.com>
3696 * cs-tokenizer.cs (xtoken): Return a special
3697 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
3699 * cs-parser.jay (default_value_expression): Switch to the new
3702 2004-03-19 Martin Baulig <martin@ximian.com>
3704 * decl.cs (MemberName): New class. We use this to "construct"
3705 namespace_or_type_name's.
3707 * generics.cs (TypeArguments.GetDeclarations): New public method;
3708 returns the type arguments as a string[] and reports a CS0081 if
3709 one of them is not an identifier.
3711 * class.cs (MemberBase): The .ctor now takes the name as a
3712 MemberName instead of a string.
3713 (MemberBase.ExplicitInterfaceName): Changed type from string to
3715 (MemberBase.DoDefine): If we're an explicit implementation, the
3716 InterfaceType may be a generic instance.
3718 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
3719 (namespace_name): Call MemberName.GetName () to transform the
3720 MemberName into a string and ensure we don't have any type
3722 (type_name): Call MemberName.GetTypeExpression() to transfrom the
3723 MemberName into an expression.
3724 (method_header): Use namespace_or_type_name instead of member_name.
3726 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3728 * rootcontext.cs: Add new types to the boot resolution.
3730 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3731 MulticastDelegate is not allowed.
3733 * typemanager.cs: Add new types to lookup: System.TypedReference
3736 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3737 check for TypedReference or ArgIterator, they are not allowed.
3739 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3740 makes us properly catch 1510 in some conditions (see bug 56016 for
3743 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3745 * CryptoConvert.cs: update from corlib version
3748 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3750 * class.cs (Indexer.Define): Check indexername declaration
3752 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3754 * attribute.cs (IsClsCompliant): Fixed problem with handling
3755 all three states (compliant, not-compliant, undetected).
3757 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3759 * attribute.cs (Attribute): Location is now public.
3760 (Resolve): Store resolved arguments (pos_values) in attribute class.
3761 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3762 (GetClsCompliantAttributeValue): New method that gets
3763 CLSCompliantAttribute value.
3764 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3765 if exists else null.
3766 (AttributeTester): New class for CLS-Compliant verification routines.
3768 * class.cs (Emit): Add CLS-Compliant verification.
3769 (Method.GetSignatureForError): Implemented.
3770 (Constructor.GetSignatureForError): Implemented
3771 (Constructor.HasCompliantArgs): Returns if constructor has
3772 CLS-Compliant arguments.
3773 (Constructor.Emit): Override.
3774 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3775 is needed to test only parameters.
3776 (FieldBase.GetSignatureForError): Implemented.
3777 (TypeContainer): New member for storing base interfaces.
3778 (TypeContainer.FindMembers): Search in base interfaces too.
3780 * codegen.cs (GetClsComplianceAttribute): New method that gets
3781 assembly or module CLSCompliantAttribute value.
3782 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3784 (ModuleClass.Emit): Add error 3012 test.
3786 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3788 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3789 state for all decl types.
3790 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3791 if CLS-Compliant tests are required.
3792 (IsClsCompliaceRequired): New method. Analyze whether code
3793 must be CLS-Compliant.
3794 (IsExposedFromAssembly): New method. Returns true when MemberCore
3795 is exposed from assembly.
3796 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3797 value or gets cached value.
3798 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3799 is explicitly marked with CLSCompliantAttribute.
3800 (IsIdentifierClsCompliant): New abstract method. This method is
3801 used to testing error 3005.
3802 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3803 for identifier and parameters CLS-Compliant testing.
3804 (VerifyClsCompliance): New method. The main virtual method for
3805 CLS-Compliant verifications.
3806 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3807 null. I don't know why is null (too many public members !).
3808 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3809 and get value of first CLSCompliantAttribute that found.
3811 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3812 (VerifyClsCompliance): Override and add extra tests.
3814 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3815 clscheck- disable CLS-Compliant verification event if assembly is has
3816 CLSCompliantAttribute(true).
3818 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3819 ApllyAttribute is now called in emit section as in the other cases.
3820 Possible future Emit integration.
3821 (IsIdentifierClsCompliant): New override.
3822 (VerifyClsCompliance): New override.
3823 (GetEnumeratorName): Returns full enum name.
3825 * parameter.cs (GetSignatureForError): Implemented.
3827 * report.cs (WarningData): New struct for Warning message information.
3828 (LocationOfPreviousError): New method.
3829 (Warning): New method. Reports warning based on the warning table.
3830 (Error_T): New method. Reports error based on the error table.
3832 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3833 verifications are done here.
3835 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3837 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3838 CLSCompliantAttribute.
3839 (all_imported_types): New member holds all imported types from other
3841 (LoadAllImportedTypes): New method fills static table with exported types
3842 from all referenced assemblies.
3843 (Modules): New property returns all assembly modules.
3845 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3847 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3848 throwing a parser error.
3850 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3851 which removes the hardcoded get_/set_ prefixes for properties, as
3852 IL allows for the properties to be named something else.
3856 * expression.cs: Do not override operand before we know if it is
3859 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3861 * typemanager.cs: support for pinned variables.
3863 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3865 * decl.cs, typemanager.cs: Avoid using an arraylist
3866 as a buffer if there is only one result set.
3868 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3870 * expression.cs: Make sure you cant call a static method
3871 with an instance expression, bug #56174.
3873 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3875 * class.cs (IsDuplicateImplementation): Improve error reporting to
3876 flag 663 (method only differs in parameter modifier).
3878 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3879 in preprocessor directives.
3881 * location.cs (LookupFile): Allow for the empty path.
3883 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3884 better approach for some of that patch, but its failing with the
3885 CharSet enumeration. For now try/catch will do.
3887 * typemanager.cs: Do not crash if a struct does not have fields.
3890 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3892 * expression.cs: cs0213, cant fix a fixed expression.
3895 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3897 * cs-parser.jay: detect invalid embeded statements gracefully.
3900 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3902 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
3905 the invocation type may not be a subclass of the tye of the item/
3906 The type of the item must be a subclass of the invocation item.
3911 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
3913 * attribute.cs: Added methods to get a string and a bool from an
3914 attribute. Required to information from AssemblyKeyFileAttribute,
3915 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
3916 * codegen.cs: Modified AssemblyName creation to include support for
3917 strongnames. Catch additional exceptions to report them as CS1548.
3918 * compiler.csproj: Updated include CryptoConvert.cs.
3919 * compiler.csproj.user: Removed file - user specific configuration.
3920 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
3921 Mono.Security assembly. The original class is maintained and tested in
3922 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
3923 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
3924 like CSC 8.0 (C# v2) supports.
3925 * Makefile: Added CryptoConvert.cs to mcs sources.
3926 * rootcontext.cs: Added new options for strongnames.
3928 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
3930 * driver.cs: For --expect-error, report error code `2'
3931 if the program compiled with no errors, error code `1' if
3932 it compiled with an error other than the one expected.
3934 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
3936 * compiler.csproj: Updated for Visual Studio .NET 2003.
3937 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
3938 * compiler.sln: Updated for Visual Studio .NET 2003.
3940 2004-03-24 Ravi Pratap M <ravi@ximian.com>
3942 * expression.cs: Fix bug #47234. We basically need to apply the
3943 rule that we prefer the conversion of null to a reference type
3944 when faced with a conversion to 'object' (csc behaviour).
3946 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3948 * statement.cs: Shorter form for foreach, eliminates
3949 a local variable. r=Martin.
3951 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3953 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
3954 checks if we can use brtrue/brfalse to test for 0.
3955 * expression.cs: use the above in the test for using brtrue/brfalse.
3958 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3960 * expression.cs: Rewrite string concat stuff. Benefits:
3962 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
3963 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
3964 rather than a concat chain.
3966 * typemanager.cs: Add lookups for more concat overloads.
3968 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3970 * expression.cs: Emit shorter il code for array init.
3987 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
3989 * statement.cs: Before, two switch blocks would be merged if the
3990 total size of the blocks (end_item - begin_item + 1) was less than
3991 two times the combined sizes of the blocks.
3993 Now, it will only merge if after the merge at least half of the
3998 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
4000 * class.cs : csc build fix for GetMethods(). See bug #52503.
4002 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
4004 * expression.cs: Make sure fp comparisons work with NaN.
4005 This fixes bug #54303. Mig approved this patch a long
4006 time ago, but we were not able to test b/c the runtime
4009 2004-03-19 Miguel de Icaza <miguel@ximian.com>
4011 * ecore.cs (TypExpr.GetHashCode): implement this overload.
4013 2004-03-19 Martin Baulig <martin@ximian.com>
4015 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
4016 two overloads may unify for some type parameter substitutions and
4017 report a CS0408 if appropriate.
4019 2004-03-19 Martin Baulig <martin@ximian.com>
4021 * class.cs (MemberCore.IsDuplicateImplementation): Report the
4022 error here and not in our caller.
4024 2004-03-19 Martin Baulig <martin@ximian.com>
4026 * interface.cs: Completely killed this file.
4027 (Interface): We're now a TypeContainer and live in class.cs.
4029 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4030 argument; we're now also called for interfaces.
4031 (TypeContainer.DefineMembers): Allow this method being called
4033 (TypeContainer.GetMethods): New public method; formerly known as
4034 Interface.GetMethod(). This is used by PendingImplementation.
4035 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4036 it's now private and non-static.
4037 (Interface): Moved this here; it's now implemented similar to
4039 (Method, Property, Event, Indexer): Added `bool is_interface'
4040 argument to their .ctor's.
4041 (MemberBase.IsInterface): New public field.
4043 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4044 instances instead of InterfaceMethod, InterfaceProperty, etc.
4045 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4046 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4048 2004-03-19 Martin Baulig <martin@ximian.com>
4050 * class.cs (MethodCore.IsDuplicateImplementation): New private
4051 method which does the CS0111 checking.
4052 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4053 Use IsDuplicateImplementation().
4055 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4057 * decl.cs (FindMemberToOverride): New method to find the correct
4058 method or property to override in the base class.
4060 - Make Method/Property use the above method to find the
4061 version in the base class.
4062 - Remove the InheritableMemberSignatureCompare as it is now
4065 This patch makes large code bases much faster to compile, as it is
4066 O(n) rather than O(n^2) to do this validation.
4068 Also, it fixes bug 52458 which is that nested classes are not
4069 taken into account when finding the base class member.
4071 Reviewed/Approved by Martin.
4073 2004-03-17 Martin Baulig <martin@ximian.com>
4075 * expression.cs (MemberAccess.DoResolve): Take the parent's number
4076 of type arguments into account; use the `real_num_type_args'
4077 approach like in DoResolveAsTypeStep().
4079 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
4082 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4084 * interface.cs: In all interface classes removed redundant
4085 member initialization.
4087 2004-03-16 Martin Baulig <martin@ximian.com>
4089 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4091 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4093 * decl.cs (DefineTypeAndParents): New helper method to define a
4094 type's containers before the type itself is defined; This is a
4095 bug exposed by the recent changes to Windows.Forms when an
4096 implemented interface was defined inside a class that had not been
4099 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4101 (Check): Loop correctly to report errors modifiers
4102 (UNSAFE was not in the loop, since it was the same as TOP).
4104 * interface.cs: Every interface member now takes a ModFlags,
4105 instead of a "is_new" bool, which we set on the base MemberCore.
4107 Every place where we called "UnsafeOk" in the interface, now we
4108 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4109 the unsafe settings from the member declaration instead of the
4110 container interface.
4112 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4114 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4115 `set_indexer_name' to the pending bits (one per type).
4117 We fixed a bug today that was picking the wrong method to
4118 override, since for properties the existing InterfaceMethod code
4119 basically ignored the method name. Now we make sure that the
4120 method name is one of the valid indexer names.
4122 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4124 * support.cs (SeekableStreamReader): Keep track of stream byte
4125 positions and don't mix them with character offsets to the buffer.
4127 Patch from Gustavo Giráldez
4129 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4131 * interface.cs (InterfaceSetGetBase): Removed double member
4132 initialization, base class does it as well.
4134 2004-03-13 Martin Baulig <martin@ximian.com>
4136 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4137 when compiling corlib.
4139 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4141 * convert.cs (ExplicitConversion): We were reporting an error on
4142 certain conversions (object_type source to a value type, when the
4143 expression was `null') before we had a chance to pass it through
4144 the user defined conversions.
4146 * driver.cs: Replace / and \ in resource specifications to dots.
4149 * class.cs: Add check for duplicate operators. Fixes 52477
4151 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4153 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4154 that are in the middle of the statements, not only at the end.
4157 * class.cs (TypeContainer.AddField): No longer set the
4158 `HaveStaticConstructor' flag, now we call it
4159 `UserDefineStaticConstructor' to diferentiate the slightly
4160 semantic difference.
4162 The situation is that we were not adding BeforeFieldInit (from
4163 Modifiers.TypeAttr) to classes that could have it.
4164 BeforeFieldInit should be set to classes that have no static
4169 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4171 And most importantly Zoltan's comment:
4173 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4175 "I think beforefieldinit means 'it's ok to initialize the type sometime
4176 before its static fields are used', i.e. initialization does not need
4177 to be triggered by the first access to the type. Setting this flag
4178 helps the JIT to compile better code, since it can run the static
4179 constructor at JIT time, and does not need to generate code to call it
4180 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4181 this flag for lots of classes like String.
4183 csc sets this flag if the type does not have an explicit static
4184 constructor. The reasoning seems to be that if there are only static
4185 initalizers for a type, and no static constructor, then the programmer
4186 does not care when this initialization happens, so beforefieldinit
4189 This bug prevents the AOT compiler from being usable, since it
4190 generates so many calls to mono_runtime_class_init that the AOT code
4191 is much slower than the JITted code. The JITted code is faster,
4192 because it does not generate these calls if the vtable is type is
4193 already initialized, which is true in the majority of cases. But the
4194 AOT compiler can't do this."
4196 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4198 * class.cs (MethodData.Emit): Refactor the code so symbolic
4199 information is generated for destructors; For some reasons we
4200 were taking a code path that did not generate symbolic information
4203 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4205 * class.cs: Create a Constructor.CheckBase method that
4206 takes care of all validation type code. The method
4207 contains some code that was moved from Define.
4209 It also includes new code that checks for duplicate ctors.
4210 This fixes bug #55148.
4212 2004-03-09 Joshua Tauberer <tauberer@for.net>
4214 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4215 a { ... }-style array creation invokes EmitStaticInitializers
4216 which is not good for reference-type arrays. String, decimal
4217 and now null constants (NullCast) are not counted toward
4218 static initializers.
4220 2004-03-05 Martin Baulig <martin@ximian.com>
4222 * location.cs (SourceFile.HasLineDirective): New public field;
4223 specifies whether the file contains or is referenced by a "#line"
4225 (Location.DefineSymbolDocuments): Ignore source files which
4226 either contain or are referenced by a "#line" directive.
4228 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4230 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4231 direct access to our parent, so check the method inline there.
4233 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4235 * expression.cs (Invocation.EmitCall): Miguel's last commit
4236 caused a regression. If you had:
4241 In Foo the implict this would be null.
4243 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4245 * expression.cs (Invocation.EmitCall): If the method is not
4246 virtual, do not emit a CallVirt to it, use Call.
4248 * typemanager.cs (GetFullNameSignature): Improve the method to
4249 cope with ".ctor" and replace it with the type name.
4251 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4252 as an argument the ConstructorBuilder where it is being defined,
4253 to catch the recursive constructor invocations.
4255 2004-03-16 Martin Baulig <martin@ximian.com>
4257 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
4258 ConstructedType, call ResolveType() on it to get the type rather
4259 than just using `expr.Type'.
4261 2004-03-16 Martin Baulig <martin@ximian.com>
4263 * generics.cs (ConstructedType.GetMemberAccess): Take the
4264 EmitContext instead on the TypeExpr and use
4265 ec.TypeContainer.CurrentType/ec.ContainerType.
4267 2004-03-16 Martin Baulig <martin@ximian.com>
4269 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
4270 parameters before aliases.
4272 2004-03-16 Martin Baulig <martin@ximian.com>
4274 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
4275 New oublic function; checks whether two generic instances may become
4276 equal under some instantiations (26.3.1).
4278 * class.cs (TypeContainer.Define): Call
4279 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
4282 2004-03-16 Martin Baulig <martin@ximian.com>
4284 * class.cs (TypeContainer.GetClassBases): Moved
4285 Error_TypeParameterAsBase() here and also check whether the base
4286 class is not an attribute.
4288 2004-03-16 Martin Baulig <martin@ximian.com>
4290 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4292 2004-03-16 Martin Baulig <martin@ximian.com>
4294 * class.cs (Error_TypeParameterAsBase): Use correct error number
4297 2004-03-16 Martin Baulig <martin@ximian.com>
4299 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
4302 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
4305 2004-03-15 Martin Baulig <martin@ximian.com>
4307 * typemanager.cs (TypeManager.GetFullName): New public method.
4308 (TypeManager.MemberLookup): Added `int_num_type_arguments'
4309 argument; only return members with the correct number of type
4311 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
4312 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
4313 whether the number of type arguments matches.
4315 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
4316 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
4318 * expression.cs (MemberAccess): Added public `NumTypeArguments'
4319 field; it's set by the protected .ctor when we're actually a
4320 GenericMemberAccess.
4321 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
4322 arguments and pass it to MemberLookupFinal ().
4324 * ecore.cs (Expression.MemberLookup): Added `int
4325 num_type_arguments' argument; only return members with the correct
4326 number of type arguments.
4327 (Expression.MemberLookupFailed): Check whether the MemberLookup
4328 failed because we did not have the correct number of type
4329 arguments; report CS0305 in this case.
4331 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
4332 `e.ResolveAsTypeTerminal()' already did so.
4334 2004-03-15 Martin Baulig <martin@ximian.com>
4336 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
4337 we're a ConstructedType; in this case, the caller must report an
4338 error (for instance CS0131).
4340 * generic.cs (TypeArguments): Added Location argument to the .ctor.
4341 (TypeArguments.Resolve): Actually report errors here.
4343 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4345 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4346 `set_indexer_name' to the pending bits (one per type).
4348 We fixed a bug today that was picking the wrong method to
4349 override, since for properties the existing InterfaceMethod code
4350 basically ignored the method name. Now we make sure that the
4351 method name is one of the valid indexer names.
4353 2004-03-15 Martin Baulig <martin@ximian.com>
4355 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
4356 for generic instances.
4358 2004-03-13 Martin Baulig <martin@ximian.com>
4360 * class.cs (TypeContainer.DefineType): Call
4361 TypeManager.AddUserType() immediately after creating the
4362 TypeBuilder; pass all type parameters when creating the
4365 * decl.cs (DeclSpace.FindNestedType): New public method.
4366 (DeclSpace.FindType): Added `int num_type_args' argument; only
4367 return types with the correct number of type parameters.
4368 (DeclSpace.CountTypeParams): New public property.
4370 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
4371 the number of type parameters; defaults to zero.
4373 * generic.cs (TypeArguments.Count): New public property.
4374 (ConstructedType.DoResolveAsTypeStep): First call
4375 ds.FindNestedType() to find out whether we're nested in the
4376 current generic type; in this case, we inherit all type parameters
4377 from the current class.
4379 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
4380 num_type_args' argument.
4381 (RootContext.LookupType): Added overloaded version which takes the
4382 number of type arguments; only return types with the correct
4383 number of type arguments.
4385 * typemanager.cs (TypeManager.CheckGeneric): New public function;
4386 checks whether `Type t' has `int num_type_args'.
4388 2004-03-13 Martin Baulig <martin@ximian.com>
4390 * generic.cs (GenericMethod.DefineType): New method; calls
4391 DefineType() on all the type parameters.
4393 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
4394 (MethodData.Define): If we're a generic method, call
4395 GenericMethod.DefineType() to define the type parameters.
4397 2004-03-10 Martin Baulig <martin@ximian.com>
4399 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
4400 instead of IsAssignableFrom.
4402 2004-03-10 Martin Baulig <martin@ximian.com>
4404 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
4406 * support.cs (ParameterData.HasArrayParameter): New property.
4407 (ReflectionParameters.ctor): Take a MethodBase instead of a
4408 ParameterInfo[]. If we have any type parameters, get the generic
4409 method definition and ask it whether we have variable arguments.
4411 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4413 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4414 routines to check if a type is an enumerable/enumerator allow
4415 classes that implement the IEnumerable or IEnumerator interfaces.
4417 * class.cs (Property, Operator): Implement IIteratorContainer, and
4418 implement SetYields.
4420 (Property.Define): Do the block swapping for get_methods in the
4421 context of iterators. We need to check if Properties also
4422 include indexers or not.
4424 (Operator): Assign the Block before invoking the
4425 OperatorMethod.Define, so we can trigger the Iterator code
4428 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4429 Property and Operator classes are not created when we parse the
4430 declarator but until we have the block completed, so we use a
4431 singleton SimpleIteratorContainer.Simple to flag whether the
4432 SetYields has been invoked.
4434 We propagate this setting then to the Property or the Operator to
4435 allow the `yield' to function.
4437 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4439 * codegen.cs: Implemented attribute support for modules.
4440 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4441 Assembly/Module functionality.
4443 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4444 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4445 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4447 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4449 * interface.cs (FindMembers): The operation is performed on all base
4450 interfaces and not only on the first. It is required for future CLS Compliance patch.
4452 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4454 * statement.cs, codegen.cs:
4455 This patch deals with patterns such as:
4457 public class List : IEnumerable {
4459 public MyEnumerator GetEnumerator () {
4460 return new MyEnumerator(this);
4463 IEnumerator IEnumerable.GetEnumerator () {
4467 public struct MyEnumerator : IEnumerator {
4472 Before, there were a few things we did wrong:
4473 1) we would emit callvirt on a struct, which is illegal
4474 2) we emited ldarg when we needed to emit ldarga
4475 3) we would mistakenly call the interface methods on an enumerator
4476 type that derived from IEnumerator and was in another assembly. For example:
4478 public class MyEnumerator : IEnumerator
4480 Would have the interface methods called, even if there were public impls of the
4481 method. In a struct, this lead to invalid IL code.
4483 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4485 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4488 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4490 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4492 * cs-parser.jay: Fix small regression: we were not testing V2
4493 compiler features correctly.
4495 * interface.cs: If the emit context is null, then create one
4497 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4499 * decl.cs (GetSignatureForError): New virtual method to get full name
4502 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4503 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4505 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4506 Duplicated members and code in these classes has been removed.
4507 Better encapsulation in these classes.
4509 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4511 * assign.cs (Assign.DoResolve): When dealing with compound
4512 assignments, there is a new rule in ECMA C# 2.4 (might have been
4513 there before, but it is documented here) that states that in:
4517 If b is of type int, and the `op' is a shift-operator, then the
4518 above is evaluated as:
4522 * expression.cs (Binary.ResolveOperator): Instead of testing for
4523 int/uint/long/ulong, try to implicitly convert to any of those
4524 types and use that in pointer arithmetic.
4526 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4527 method to print information for from the type, not from the
4528 null-method we were given.
4530 2004-02-01 Duncan Mak <duncan@ximian.com>
4532 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4533 parsing for cmd, fixes bug #53694.
4535 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4537 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4538 in the member name duplication tests. Property and operator name duplication
4539 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4541 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4543 * interface.cs (PopulateMethod): Fixed crash when interface method
4544 returns not existing type (error test cs0246-3.cs).
4546 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4548 * cs-parser.jay (interface_accessors): Re-write actions to also
4549 store attributes attached to get and set methods. Fix spelling
4552 (inteface_property_declaration): Modify accordingly.
4554 (InterfaceAccessorInfo): New helper class to store information to pass
4555 around between rules that use interface_accessors.
4557 * interface.cs (Emit): Apply attributes on the get and set
4558 accessors of properties and indexers too.
4560 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4561 right MethodBuilder when applying attributes to the get and set accessors.
4563 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4565 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4567 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4569 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4571 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4573 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4574 changes that treat `yield' specially when present before `break'
4577 * cs-tokenizer.cs: yield is no longer a keyword.
4579 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4581 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4582 setting for default constructors.
4583 For default constructors are almost every time set wrong Modifier. The
4584 generated IL code has been alright. But inside mcs this values was
4585 wrong and this was reason why several of my CLS Compliance tests
4588 2004-02-27 Martin Baulig <martin@ximian.com>
4590 * generics.cs (ConstructedType.ResolveType): Make the nested type
4591 stuff actually work.
4593 2004-02-25 Martin Baulig <martin@ximian.com>
4595 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
4596 property; returns the type parameters just from the current type,
4597 ie. with the ones from outer classes.
4598 (DeclSpace.LookupGeneric): First search in the current class, then
4600 (DeclSpace.initialize_type_params): When hiding a type parameter
4601 from an outer class, put it into the `type_param_list' anyways.
4603 * expression.cs (MemberAccess.expr): Made this field protected.
4605 * class.cs (TypeContainer.Define): The `CurrentType' just contains
4606 the type parameters from the current class.
4608 * generic.cs (ConstructedType.ResolveType): Support nested generic
4609 types by taking the type parameters which we inherit from outer
4610 classes into account.
4611 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
4612 support for nested generic types.
4614 2004-02-23 Martin Baulig <martin@ximian.com>
4616 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
4617 field and check whether we're nested inside a generic type.
4618 (DeclSpace.ResolveType): If we're resolving to a generic type
4619 definition, create a ConstructedType and return its resolved type.
4620 (DeclSpace.initialize_type_params): New private method;
4621 initializes the `type_param_list' field from the type parameters
4622 from this and all enclosing classes.
4623 (DeclSpace.TypeParameters): Call initialize_type_params() unless
4624 we're already initialized.
4626 2004-02-23 Martin Baulig <martin@ximian.com>
4628 * class.cs (Method.Define): Create the generic method before
4630 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
4631 the TypeContainer one); we use this for generic methods.
4633 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
4634 parent's TypeBuilder.
4636 2004-02-18 Martin Baulig <martin@ximian.com>
4638 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
4639 to check for equality.
4641 2004-02-05 Martin Baulig <martin@ximian.com>
4643 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
4644 `ec.TypeContainer.CurrentType', use it instead of
4645 `ec.ContainerType' to check whether we're in the type's ctor.
4647 2004-01-29 Martin Baulig <martin@ximian.com>
4649 * expression.cs (Invocation.DoResolve): If we're a
4650 `ConstructedType', then we're actually a generic method, so
4651 rewrite the expr as a GenericMemberAccess.
4653 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
4654 here; manually parse it into a string.
4656 2004-01-28 Martin Baulig <martin@ximian.com>
4658 * typemanager.cs (TypeManager.IsEqual): New static method.
4659 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
4660 check for equality instead of using `=='.
4662 2004-01-26 Martin Baulig <martin@ximian.com>
4664 * decl.cs (DeclSpace.CurrentType): New public field.
4666 * expression.cs (This.ResolveBase): If we have an
4667 `ec.TypeContainer.CurrentType', use it instead of
4670 * class.cs (TypeContainer.DefineType): If we're a generic type,
4671 create the `CurrentType' (unresolved).
4672 (TypeContainer.GenericType): New private field.
4673 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
4674 it and store it in `GenericType' before creating the MemberCache.
4675 (TypeContainer.GetMembers): If we have a `GenericType', call
4676 TypeManager.FindMembers() on it.
4678 * interface.cs (Interface.GenericType): New private field.
4679 (Interface.DefineType): If we're a generic type, create the
4680 `CurrentType' (unresolved).
4681 (Interface.DefineMembers): If we have a `CurrentType', resolve it
4682 and store it in `GenericType' before creating the MemberCache.
4683 (Interface.GetMembers): If we have a `GenericType', call
4684 TypeManager.FindMembers() on it.
4686 2004-01-22 Martin Baulig <martin@ximian.com>
4688 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4689 not a QualifiedIdentifier. This is what `type_name_expression'
4690 was previously doing.
4691 (type_name_expression): Removed; the code is now in
4692 `namespace_or_type_name'.
4693 (qualified_identifier): Removed, use `namespace_or_type_name'
4695 (QualifiedIdentifier): Removed this class.
4697 2004-01-22 Martin Baulig <martin@ximian.com>
4699 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4700 not a string as alias name.
4702 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4704 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4705 #52730 bug, and instead compute correctly the need to use a
4706 temporary variable when requesting an address based on the
4707 static/instace modified of the field and the constructor.
4709 2004-01-21 Martin Baulig <martin@ximian.com>
4711 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4712 class and namespace before looking up aliases. Fixes #52517.
4714 2004-01-21 Martin Baulig <martin@ximian.com>
4716 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4717 assinged in a 'try'; fixes exception4.cs.
4719 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4720 * class.cs : Implemented parameter-less constructor for TypeContainer
4722 * decl.cs: Attributes are now stored here. New property OptAttributes
4724 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4726 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4728 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4730 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4731 (CSharpSignature): New method for indexer and property signature.
4733 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4735 * pending.cs (IsVirtualFilter): Faster implementation.
4737 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4739 * typemanager.cs: Avoid inclusion of same assembly more than once.
4741 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4743 * cs-parser.jay: Fixed problem where the last assembly attribute
4744 has been applied also to following declaration (class, struct, etc.)
4746 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4748 * class.cs: Added error CS0538, CS0539 reporting.
4749 Fixed crash on Microsoft runtime when field type is void.
4751 * cs-parser.jay: Added error CS0537 reporting.
4753 * pending.cs: Added error CS0535 reporting.
4754 Improved error report for errors CS0536, CS0534.
4756 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4758 Merge a few bits from the Anonymous Method MCS tree.
4760 * statement.cs (ToplevelBlock): New class for toplevel methods,
4761 will hold anonymous methods, lifted variables.
4763 * cs-parser.jay: Create toplevel blocks for delegates and for
4764 regular blocks of code.
4766 2004-01-20 Martin Baulig <martin@ximian.com>
4768 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4769 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4770 and `NeedExplicitReturn'; added `IsLastStatement'.
4771 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4772 have a `ReturnLabel' or we're not unreachable.
4774 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4775 child's reachability; don't just override ours with it. Fixes
4776 #58058 (lluis's example).
4777 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4778 InFinally(), InLoop(), InSwitch() and
4779 BreakCrossesTryCatchBoundary() methods.
4781 * statement.cs (Return): Do all error checking in Resolve().
4782 Unless we are the last statement in a top-level block, always
4783 create a return label and jump to it.
4784 (Break, Continue): Do all error checking in Resolve(); also make
4785 sure we aren't leaving a `finally'.
4786 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4787 statement in a top-level block.
4788 (Block.Flags): Added `IsDestructor'.
4789 (Block.IsDestructor): New public property.
4791 2004-01-20 Martin Baulig <martin@ximian.com>
4793 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4795 2004-01-20 Martin Baulig <martin@ximian.com>
4797 * statement.cs (Statement.ResolveUnreachable): New public method.
4798 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4799 (Block.Resolve): Resolve unreachable statements.
4801 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4803 * expression.cs: We need to fix the case where we do
4804 not have a temp variable here.
4806 * assign.cs: Only expression compound assignments need
4807 temporary variables.
4809 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4811 * flowanalysis.cs: Reduce memory allocation in a few ways:
4812 - A block with no variables should not allocate a bit
4814 - A method with no out parameters does not need any tracking
4815 for assignment of the parameters, so we need not allocate
4818 public readonly Type[] VariableTypes;
4819 public readonly string[] VariableNames;
4820 Are redundant. The data is already stored in the variable
4821 map, so we need not allocate another array for it.
4822 - We need to add alot of checks for if (params | locals) == null
4823 due to the first two changes.
4825 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4827 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4828 implement IMemoryLocation, we store a copy on a local variable and
4829 take the address of it. Patch from Benjamin Jemlich
4831 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4832 to use a special "type_name_expression" rule which reduces the
4833 number of "QualifiedIdentifier" classes created, and instead
4834 directly creates MemberAccess expressions.
4836 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4838 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4839 that fixes #52853. Null literal assignment to ValueType
4841 * class.cs (MethodData.Emit): Instead of checking the name of the
4842 method to determine if its a destructor, create a new derived
4843 class from Method called Destructor, and test for that.
4845 * cs-parser.jay: Create a Destructor object instead of a Method.
4847 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4851 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4853 * expression.cs (Binary.ResolveOperator): Perform an implicit
4854 conversion from MethodGroups to their delegate types on the
4857 * delegate.cs: Introduce a new class DelegateCreation that is the
4858 base class for `NewDelegate' and `ImplicitDelegateCreation',
4859 factor some code in here.
4861 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4862 conversion from MethodGroups to compatible delegate types.
4864 * ecore.cs (Expression.Resolve): Do not flag error 654
4865 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4866 we allow conversions from MethodGroups to delegate types now.
4868 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4869 assignments in v2 either.
4871 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4873 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4874 static read-only fields in ctors.
4876 Applied patch from Benjamin Jemlich
4878 * expression.cs (UnaryMutator): Avoid leaking local variables.
4880 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4882 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4883 here to return true, as they can be used like this:
4887 Fixed 49836 and all the other dups
4889 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4891 * driver.cs: Implement /win32res and /win32icon.
4893 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4895 * cs-parser.jay: Add a rule to improve error handling for the
4896 common mistake of placing modifiers after the type.
4898 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4900 * cs-parser.jay (interface_event_declaration): Catch
4901 initialization of events on interfaces, and report cs0068
4903 * cs-parser.jay (interface_event_declaration): Catch
4904 initialization of events.
4906 * ecore.cs: Better report missing constructors.
4908 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4909 the error reporting done in the wrong place. Fix.
4911 * expression.cs (Binary.ResolveOperator): Catch the
4912 operator + (E x, E y) error earlier, and later allow for implicit
4913 conversions in operator +/- (E e, U x) from U to the underlying
4916 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4917 52596, if the container class is abstract, the default constructor
4918 is protected otherwise its public (before, we were always public).
4920 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
4923 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
4924 Jemlich that fixes bug #52597, MCS was generating invalid code for
4925 idisposable structs. Thanks to Ben for following up with this
4928 2004-01-06 Miguel de Icaza <miguel@ximian.com>
4930 * driver.cs: Allow assemblies without code to be generated, fixes
4933 2004-01-07 Nick Drochak <ndrochak@gol.com>
4935 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
4937 2004-01-05 Miguel de Icaza <miguel@ximian.com>
4939 * cs-parser.jay: Add rules to improve error reporting if fields or
4940 methods are declared at the namespace level (error 116)
4942 * Add rules to catch event add/remove
4944 2004-01-04 David Sheldon <dave-mono@earth.li>
4946 * expression.cs: Added matching ")" to error message for
4949 2004-01-03 Todd Berman <tberman@gentoo.org>
4951 * ecore.cs, attribute.cs:
4952 Applying fix from #52429.
4954 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4956 * ecore.cs, expression.cs, statement.cs:
4957 Total rewrite of how we handle branching. We
4958 now handle complex boolean expressions with fewer
4959 jumps. As well if (x == 0) no longer emits a ceq.
4961 if (x is Foo) is much faster now, because we generate
4964 Overall, we get a pretty big improvement on our benchmark
4965 tests. The code we generate is smaller and more readable.
4967 I did a full two-stage bootstrap. The patch was reviewed
4968 by Martin and Miguel.
4970 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4972 * cs-parser.jay: Make primary_expression not take a QI.
4973 we dont need this because the member_access rule covers
4974 us here. So we replace the rule with just IDENTIFIER.
4976 This has two good effects. First, we remove a s/r conflict.
4977 Second, we allocate many fewer QualifiedIdentifier objects.
4979 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4981 * attribute.cs: Handle MarshalAs attributes as pseudo, and
4982 set the correct information via SRE. This prevents
4983 hanging on the MS runtime. Fixes #29374.
4985 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4987 * convert.cs: correctly handle conversions to value types
4988 from Enum and ValueType as unboxing conversions.
4990 Fixes bug #52569. Patch by Benjamin Jemlich.
4992 2004-01-02 Ravi Pratap <ravi@ximian.com>
4994 * expression.cs (BetterConversion): Prefer int -> uint
4995 over int -> ulong (csc's behaviour). This fixed bug #52046.
4997 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
4999 * decl.cs (MemberCache.FindMembers): now returns a
5002 * typemanager.cs: In general, go with with ^^.
5003 (CopyNewMethods): take an IList.
5004 (RealMemberLookup): Only allocate an arraylist
5005 if we copy from two sets of methods.
5007 This change basically does two things:
5008 1) Fewer array lists allocated due to CopyNewMethods.
5009 2) the explicit cast in MemberList costed ALOT.
5011 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
5013 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
5014 a hashtable to avoid needless string allocations when an identifier is
5015 used more than once (the common case).
5017 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5019 * pending.cs: MS's TypeBuilder.GetInterfaces ()
5020 is broken, it will not return anything. So, we
5021 have to use the information we have in mcs to
5024 * typemanager.cs: Add a cache for GetInterfaces,
5025 since this will now be used more often (due to ^^)
5027 (GetExplicitInterfaces) New method that gets the
5028 declared, not effective, interfaces on a type
5029 builder (eg, if you have interface IFoo, interface
5030 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
5033 This patch makes MCS able to bootstrap itself on
5036 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5038 * expression.cs: Remove the Nop's that Miguel put
5041 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5043 * report.cs, codegen.cs: Give the real stack trace to
5044 the error when an exception is thrown.
5046 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5048 * decl.cs: only allocate hashtables for ifaces if
5051 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5053 * expression.cs: fix the error from cs0121-2.cs
5054 (a parent interface has two child interfaces that
5055 have a function with the same name and 0 params
5056 and the function is called through the parent).
5058 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
5060 * class.cs, rootcontext.cs, typmanager.cs: do not
5063 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
5065 * codegen.cs: remove stack for the ec flow branching.
5066 It is already a linked list, so no need.
5068 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
5070 * Makefile: Allow custom profiler here.
5072 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5074 * typemanager.cs (LookupType):
5075 - Use a static char [], because split takes
5076 a param array for args, so it was allocating
5078 - Do not store true in a hashtable, it boxes.
5080 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5082 * flowanalysis.cs: bytify common enums.
5084 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5086 * modifiers.cs: Add a new set of flags for the
5087 flags allowed on explicit interface impls.
5088 * cs-parser.jay: catch the use of modifiers in
5089 interfaces correctly.
5090 * class.cs: catch private void IFoo.Blah ().
5092 All related to bug #50572.
5094 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5096 * decl.cs: Rewrite the consistant accessability checking.
5097 Accessability is not linear, it must be implemented in
5098 a tableish way. Fixes #49704.
5100 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5102 * expression.cs: Handle negation in a checked context.
5103 We must use subtraction from zero. Fixes #38674.
5105 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5107 * class.cs: Ignore static void main in DLLs.
5108 * rootcontext.cs: Handle the target type here,
5109 since we are have to access it from class.cs
5110 * driver.cs: account for the above.
5112 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5114 * report.cs: Give line numbers and files if available.
5116 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
5118 * driver.cs: Implement /addmodule.
5120 * typemanager.cs: Change 'modules' field so it now contains Modules not
5123 2003-12-20 Martin Baulig <martin@ximian.com>
5125 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
5126 (FieldBase.IsAssigned): Removed this field.
5127 (FieldBase.SetAssigned): New public method.
5128 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
5130 2003-12-20 Martin Baulig <martin@ximian.com>
5132 * expression.cs (LocalVariableReference.DoResolve): Don't set
5133 `vi.Used' if we're called from DoResolveLValue().
5135 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
5136 returns the usage vector it just merged into the current one -
5137 pass this one to UsageWarning().
5138 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
5139 of the `EmitContext', don't call this recursively on our children.
5141 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
5143 * driver.cs: Implement /target:module.
5145 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
5147 * support.cs (CharArrayHashtable): New helper class.
5149 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
5150 char arrays, not strings, so we can avoid creating a string in
5151 consume_identifier if the identifier is a keyword.
5153 2003-12-16 Martin Baulig <martin@ximian.com>
5155 * statement.cs (LocalInfo.Assigned): Removed this property.
5156 (LocalInfo.Flags): Removed `Assigned'.
5157 (LocalInfo.IsAssigned): New public method; takes the EmitContext
5158 and uses flow analysis.
5159 (Block.UsageWarning): Made this method private.
5160 (Block.Resolve): Call UsageWarning() if appropriate.
5162 * expression.cs (LocalVariableReference.DoResolve): Always set
5163 LocalInfo.Used here.
5165 2003-12-13 Martin Baulig <martin@ximian.com>
5167 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
5168 any value here; we're now using flow analysis to figure out
5169 whether a statement/block returns a value.
5171 2003-12-13 Martin Baulig <martin@ximian.com>
5173 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
5175 (FlowBranching.MergeFinally): Don't call
5176 `branching.CheckOutParameters()' here, this is called in
5178 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
5179 when adding the `finally' vector.
5181 2003-12-13 Martin Baulig <martin@ximian.com>
5184 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
5185 actually work and also fix #48962.
5187 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
5189 * decl.cs: Do not check System.Object for nested types,
5190 since we know it does not have any. Big bang for buck:
5195 corlib: 17.99 seconds
5199 corlib: 17.39 seconds
5201 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5203 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5204 time we are returning 0 members, so we save alot here.
5206 2003-12-11 Martin Baulig <martin@ximian.com>
5208 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5209 `MergeChild()', also just take the `FlowBranching' as argument;
5210 call Merge() on it and return the result.
5211 (FlowBranching.Merge): We don't need to do anything if we just
5214 2003-12-11 Martin Baulig <martin@ximian.com>
5216 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5217 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5218 Maurer for this idea.
5220 2003-12-11 Martin Baulig <martin@ximian.com>
5222 * flowanalysis.cs (MergeResult): This class is now gone; we now
5223 use the `UsageVector' for this. The reason for this is that if a
5224 branching just has one sibling, we don't need to "merge" them at
5225 all - that's the next step to do.
5226 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5229 2003-12-11 Martin Baulig <martin@ximian.com>
5231 Reworked flow analyis and made it more precise and bug-free. The
5232 most important change is that we're now using a special `Reachability'
5233 class instead of having "magic" meanings of `FlowReturns'. I'll
5234 do some more cleanups and optimizations and also add some more
5235 documentation this week.
5237 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5238 largely reworked this class.
5239 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5240 the new `Reachability' class instead of having "magic" values here.
5241 (FlowBranching): We're now using an instance of `Reachability'
5242 instead of having separate `Returns', `Breaks' etc. fields.
5244 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5245 based on flow analysis; ignore the return value of block.Emit ().
5247 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5249 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5250 if they are private.
5252 2003-12-09 Martin Baulig <martin@ximian.com>
5254 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5255 call them directly on the UsageVector.
5257 2003-12-09 Martin Baulig <martin@ximian.com>
5259 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5260 Changed return type from `FlowReturns' to `Reachability'.
5262 2003-12-09 Martin Baulig <martin@ximian.com>
5264 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5265 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5266 `Reachable' fields with a single `Reachability' one.
5268 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5270 * class.cs (FindMembers): Remove foreach's.
5283 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5288 This patch does a few things:
5289 1. EmptyStatement is now a singleton, so it is never reallocated.
5290 2. All blah is EmptyStatement constructs have been changed to
5291 blah == EmptyStatement.Value, which is much faster and valid
5292 now that EmptyStatement is a singleton.
5293 3. When resolving a block, rather than allocating a new array for
5294 the non-empty statements, empty statements are replaced with
5295 EmptyStatement.Value
5296 4. Some recursive functions have been made non-recursive.
5297 Mainly the performance impact is from (3), however (1) and (2) are needed for
5298 this to work. (4) does not make a big difference in normal situations, however
5299 it makes the profile look saner.
5304 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5305 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5306 Total memory allocated: 56397 KB
5309 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5310 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5311 Total memory allocated: 55666 KB
5313 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5315 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5316 than the hashtable in a hashtable version
5318 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5319 we always end up concating a string. This results in a huge perf
5320 loss, because many strings have to be tracked by the GC. In this
5321 patch, we first use a hashtable that works with two keys, so that
5322 the strings do not need to be concat'ed.
5333 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5335 * Makefile: Add a new target `do-time' that does a quick and simple
5336 profile, leaving easy to parse output.
5338 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5340 * codegen.cs (Init): Create the dynamic assembly with
5341 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5343 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5345 * support.cs: Make the PtrHashtable use only one
5346 instance of its comparer.
5348 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5350 * typemanager.cs: Fix lookup of GetNamespaces.
5352 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5354 * expression.cs: Removed redundant line.
5356 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5357 ArrayLists, use for loops with bounds.
5359 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5362 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5363 arraylists, use for loop with bounds.
5365 The above three changes give us a 0.071 second performance
5366 improvement out of 3.294 seconds down to 3.223. On my machine
5367 the above changes reduced the memory usage by 1,387 KB during
5370 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5371 QualifiedIdentifiers. Before we created a new string through
5372 concatenation, and mostly later on, the result would be
5373 manipulated by DecomposeQI through string manipulation.
5375 This reduced the compiler memory usage for bootstrapping from
5376 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5377 compile times in 0.05 seconds.
5379 2003-11-28 Dick Porter <dick@ximian.com>
5381 * support.cs: Do string compares with the Invariant culture.
5389 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5390 the comparison is done with the Invariant culture.
5392 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5394 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5395 GetEnumerator method.
5397 (ProbeCollectionType): Iterate starting at the most specific type
5398 upwards looking for a GetEnumerator
5400 * expression.cs: Shift count can be up to 31 for int/uint and 63
5403 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5405 * statement.cs (Block.LookupLabel): Also look for the label on the
5406 children blocks. Use a hash table to keep track of visited
5409 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5410 we actually did transform the other operand, otherwise fall back
5411 to the common codepath that casts to long.
5413 * cs-tokenizer.cs: Use the same code pattern as the int case.
5414 Maybe I should do the parsing myself, and avoid depending on the
5415 Parse routines to get this done.
5417 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5419 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5420 which fixes bug 51347. This time test it.
5422 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5423 attributes for example can not tell the difference between these.
5424 The difference was only a syntax feature of the language.
5426 * attribute.cs: Apply attributes to delegates.
5428 * delegate.cs: Call the apply attributes method.
5430 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5432 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5433 comparing 0 vs Byte.MinValue, not the value
5435 (ImplicitConversionRequired): When reporting a conversion error,
5436 use error 31 to print out the constant error instead of the
5439 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5440 which fixes bug 51347.
5442 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5444 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5445 which fixes the -warnaserror command line option.
5447 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5449 * cfold.cs (DoNumericPromotions): During constant folding of
5450 additions on UIntConstant, special case intconstants with
5451 IntConstants like we do on the expression binary operator.
5453 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5455 * convert.cs (ImplicitReferenceConversion): We were missing a case
5456 (System.Enum are not value types or class types, so we need to
5457 classify them separatedly).
5459 * driver.cs: We do not support error 2007.
5461 2003-11-12 Jackson Harper <jackson@ximian.com>
5463 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5464 system directory. Also use the full file name so users can
5465 libraries names mscorlib-o-tron.dll in a non system dir.
5467 2004-01-04 David Sheldon <dave-mono@earth.li>
5469 * expression.cs: Added matching ")" to error message for CS0077.
5471 2003-12-19 Martin Baulig <martin@ximian.com>
5473 * typemanager.cs (TypeManager.IsEqualGenericType): New public
5474 static method; see documentation in the method.
5475 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
5477 * convert.cs (Convert.ImplicitReferenceConversion,
5478 Convert.ImplicitReferenceConversionExists): Add support for
5479 generic type declarations; see gen-36.cs.
5481 2003-12-19 Martin Baulig <martin@ximian.com>
5483 * pending.cs (Pending.InterfaceMethod): Use
5484 `Type.IsAssignableFrom()' instead of `=='.
5486 2003-12-18 Martin Baulig <martin@ximian.com>
5488 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
5491 * convert.cs (Convert.ImplicitStandardConversionExists): Use
5492 `expr_type.Equals (target_type)' instead of `=='.
5494 2003-12-08 Martin Baulig <martin@ximian.com>
5496 * generics.cs (Constraints.Types): Removed.
5497 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
5499 (Constraints.ResolveTypes): New public method; resolves the
5500 TypeExpr's to Type's.
5501 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
5502 longer takes the constraints.
5503 (TypeParameter.DefineMethod): Likewise.
5504 (TypeParameter.DefineType): New public method. Calls
5505 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
5508 2003-12-08 Martin Baulig <martin@ximian.com>
5510 * convert.cs (Convert.ImplicitConversionStandard): Use
5511 `expr_type.Equals (target_type)' instead of `=='.
5513 2003-12-08 Martin Baulig <martin@ximian.com>
5515 * typemanager.cs (TypeManager.GetReferenceType): Call
5516 `Type.MakeByRefType ()'.
5518 2003-12-08 Martin Baulig <martin@ximian.com>
5520 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
5521 just has some special meaning in some situations. For instance,
5522 it is allowed to use `where' as the name of a variable etc.
5524 2003-12-04 Martin Baulig <martin@ximian.com>
5526 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
5527 `Type.MakeArrayType()' for array types.
5529 2003-11-18 Miguel de Icaza <miguel@ximian.com>
5531 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
5534 (SizeOf.DoResolve): assign the `type_queried' field. This gets
5537 2003-11-16 Martin Baulig <martin@ximian.com>
5539 * codegen.cs (EmitContext.IsGeneric): Removed.
5541 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
5542 ResolveGeneric() on the DeclSpace.
5544 2003-11-16 Martin Baulig <martin@ximian.com>
5546 * generic.cs (TypeArguments.Resolve):
5547 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
5548 `ResolveType()' on it to get the Type.
5550 2003-11-15 Martin Baulig <martin@ximian.com>
5552 * generic.cs (ConstructedType.GetInterfaces): Override this.
5554 2003-11-14 Martin Baulig <martin@ximian.com>
5556 * interface.cs (Interface.DefineType): Define all type parameters
5557 before adding the interfaces we inherit.
5559 2003-11-11 Martin Baulig <martin@ximian.com>
5561 * generic.cs (ConstructedType.ResolveType): Always call
5562 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
5564 2003-11-10 Martin Baulig <martin@ximian.com>
5566 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5567 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5568 calling `ResolveType()' on them, directly assign their `Type'.
5570 2003-11-08 Martin Baulig <martin@ximian.com>
5572 * generic.cs (ConstructedType): Override `IsClass' etc.
5574 2003-11-08 Martin Baulig <martin@ximian.com>
5576 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5577 return value and the `out parent' parameter.
5578 (TypeContainer.DefineType): Moved the CS0644 check into
5579 GetClassBases(). Don't pass the interface types to the
5580 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5581 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5583 * ecore.cs (TypeExpr.IsAttribute): New property.
5584 (TypeExpr.GetInterfaces): New method.
5586 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5587 TypeExpr instead of a Type.
5588 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5589 (Interface.DefineType): Don't pass the interface types to the
5590 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5591 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5593 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5594 instead of a `Type[]'.
5595 (TypeManager.RegisterBuilder): Likewise.
5596 (TypeManager.AddUserInterface): Likewise.
5597 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5598 `Type[]' and also return a `TypeExpr[]'.
5599 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5601 2003-11-08 Martin Baulig <martin@ximian.com>
5603 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5606 2003-11-08 Martin Baulig <martin@ximian.com>
5608 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5609 TypeManager.ResolveExpressionTypes().
5611 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5612 instead of an Expression.
5613 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5614 (TypeExpression): New public class; formerly known as `TypeExpr'.
5616 * expression.cs (ComposedCast): Derive from TypeExpr.
5618 * typemanager.cs (TypeManager.system_*_expr): These are now
5619 TypExpr's instead of Expression's.
5620 (TypeManager.ResolveExpressionTypes): New public static function;
5621 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5624 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5626 * expression.cs (New.DoResolve): Do not dereference value that
5627 might be a null return.
5629 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5630 sure that the constant value has the right type. Fixes an
5631 unreported bug, similar to 50425.
5633 * const.cs (Const.LookupConstantValue): Call
5634 ImplicitStandardConversionExists before doing a conversion to
5635 avoid havng the TypeManager.ChangeType do conversions.
5637 Reduced the number of casts used
5639 (Const.ChangeType): New routine to enable reuse of the constant
5640 type changing code from statement.
5642 * typemanager.cs (ChangeType): Move common initialization to
5643 static global variables.
5647 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5648 every value type to go through, even if it was void. Fix that.
5650 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5651 character of the define, and the is_identifier_part_character for
5652 the rest of the string.
5654 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5656 * expression.cs (UnaryMutator.EmitCode): When I updated
5657 LocalVariableReference.DoResolve, I overdid it, and dropped an
5658 optimization done on local variable references.
5660 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5662 * ecore.cs: Convert the return from Ldlen into an int.
5664 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5666 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5667 the accessibility, this is a special case for toplevel non-public
5668 classes (internal for instance).
5670 2003-10-20 Nick Drochak <ndrochak@gol.com>
5672 * ecore.cs: Fix typo and build. Needed another right paren.
5674 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5676 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5677 `internal' case regular and protected, but not allowing protected
5678 to be evaluated later. Bug 49840
5680 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5682 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5683 to kb.Nlast, and not the kb.nFirst to isolate the switch
5686 Extract the underlying type, so enumerations of long/ulong are
5687 treated like long/ulong.
5689 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5691 * expression.cs (New): Overload the meaning of RequestedType to
5692 track the possible creation of the NewDelegate type, since
5693 DoResolve is invoked more than once for new constructors on field
5696 See bugs: #48800 and #37014
5698 * cs-parser.jay (declare_local_constants): Take an arraylist
5699 instead of a single constant.
5701 (local_constant_declaration): It should take a
5702 constant_declarators, not a constant_declarator. Fixes 49487
5704 * convert.cs: Fix error report.
5706 2003-10-13 Jackson Harper <jackson@ximian.com>
5708 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5711 2003-11-03 Martin Baulig <martin@ximian.com>
5713 * expression.cs (ArrayAccess.GetStoreOpcode): Added
5714 `out bool has_type_arg'; if set, we need to pass the type to
5716 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
5717 Stelem_Any/Ldelem_Any for generic parameters.
5719 2003-11-02 Martin Baulig <martin@ximian.com>
5721 * expression.cs (Invocation.EmitCall): Use
5722 `TypeManager.IsValueType()' to check whether it's a value type.
5723 Don't set `struct_call' when calling a method on a type parameter.
5725 2003-11-02 Martin Baulig <martin@ximian.com>
5727 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
5728 and removed the TypeBuilder argument.
5730 * typemanager.cs (TypeManager.IsValueType): Return
5731 `t.IsGenericParameter || t.IsValueType'.
5733 2003-10-25 Martin Baulig <martin@ximian.com>
5735 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
5736 call ConstructedType.Resolve() on it.
5738 * generic.cs (ConstructedType.Resolve): Set `type' on success.
5740 2003-10-25 Martin Baulig <martin@ximian.com>
5742 * class.cs (TypeContainer.GetClassBases): Changed
5743 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
5744 CS8214 reporting here.
5745 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
5746 instead of a `Type' for our parent. In case of a recursive
5747 declaration (see tests/gen-23.cs for an example), our parent is a
5748 ConstructedType and it doesn't have its type set. So, first
5749 create our own TypeBuilder, then call constructed.Resolve() to get
5750 the parent's type and finally TypeBuilder.SetParent() it.
5752 * ecore.cs (TypeExpr.Name): New public virtual property.
5755 (ConstructedType): We're now a TypeExpr and not just an Expression.
5756 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
5757 arguments here; this is done later.
5758 (ConstructedType.Resolve): New public method to resolve the type
5759 arguments and bind them.
5761 2003-10-21 Martin Baulig <martin@ximian.com>
5763 * convert.cs: Use `TypeManager.IsValueType' instead of
5764 'type.IsValueType' everywhere.
5766 * typemanager.cs (TypeManager.IsValueType): Return true for type
5767 parameters. The reason for this is that we need to box a type
5768 parameter when converting it to a reference type.
5770 * cs-parser.jay: Added support for default value expressions.
5772 * generics.cs (DefaultValueExpression): New public class.
5774 2003-10-17 Martin Baulig <martin@ximian.com>
5776 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
5777 TypeContainer so we can also use this for Interfaces.
5778 (TypeParameter.Resolve): Likewise.
5780 * interface.cs (Interface.DefineType): Added support for generic
5783 * cs-parser.jay: Added support for generic structs and interfaces.
5785 2003-10-17 Martin Baulig <martin@ximian.com>
5787 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
5788 call generic methods :-)
5790 2003-10-16 Martin Baulig <martin@ximian.com>
5792 * cs-parser.jay (namespace_or_type_name): Only create a
5793 GenericMemberAccess if we actually have type arguments.
5795 2003-10-13 Martin Baulig <martin@ximian.com>
5797 * class.cs (Method.Define): If we're a generic method, call
5798 TypeBuilder.DefineGenericMethod () before resolving
5800 (MethodData): Added .ctor which takes an additional MethodBuilder
5801 argument; this is used for generic methods.
5802 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
5803 we already have a MethodBuilder.
5805 2003-10-10 Martin Baulig <martin@ximian.com>
5807 * class.cs (Method): Added .ctor which takes a `GenericMethod'
5808 instead of a `DeclSpace'. This is used for generic methods.
5810 * cs-parser.jay (method_header): Added support for generic
5811 methods; create a `GenericMethod' instance and pass it to the
5812 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
5813 parameters and locals.
5815 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
5816 since we already have the location. Check whether we're a generic
5817 type declaration or a generic method and create the correct type
5820 * generic.cs (TypeParameter.DefineMethod): New public method.
5821 (GenericMethod): New public class; derives from DeclSpace and is
5822 used for generic methods.
5824 2003-10-09 Martin Baulig <martin@ximian.com>
5826 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5828 (MethodCore.DoDefineParameters): Removed the TypeContainer
5829 argument; use the DeclSpace which was passed to the .ctor instead.
5830 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5831 TypeContainer; we only need a DeclSpace here.
5833 2003-10-09 Martin Baulig <martin@ximian.com>
5835 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5837 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5838 EmitContext's .ctor.
5840 2003-10-09 Martin Baulig <martin@ximian.com>
5842 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5843 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5844 AsAccessible(), moved them as well.
5846 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5848 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5850 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5851 generation for >=, as spotted by Paolo, bug 48679.
5852 Patch from David Waite.
5854 * cs-tokenizer.cs: Add handling for #pragma.
5856 * cs-parser.jay: Allow for both yield and yield return in the
5857 syntax. The anti-cobolization of C# fight will go on!
5859 * class.cs (TypeBuilder.DefineType): Catch error condition here
5860 (Parent.DefineType erroring out and returning null).
5862 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5863 coping with enumerations variables, we were mistakenly processing
5864 them as a regular value type instead of built-in types. Fixes the
5867 * typemanager.cs (IsBuiltinOrEnum): New method.
5869 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5871 * cs-parser.jay: Upgrade: yield now needs the return clause.
5873 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5875 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5877 2003-09-29 Martin Baulig <martin@ximian.com>
5879 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
5880 inflated generic methods.
5882 * generics.cs (ConstructedType): Distinguish between open and
5883 closed constructed types; correctly resolve the arguments.
5885 2003-09-22 Martin Baulig <martin@ximian.com>
5887 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
5888 all type arguments meet their constraints.
5890 2003-09-19 Martin Baulig <martin@ximian.com>
5892 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5893 `MemberCache parent' argument. Normally, an interface doesn't
5894 have a parent type except System.Object, but we use this in gmcs
5895 for generic type parameters.
5897 2003-09-18 Martin Baulig <martin@ximian.com>
5899 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5900 on `type.IsInterface'; don't check whether the type has a parent
5901 to determine whether it's an interface.
5903 2003-09-17 Martin Baulig <martin@ximian.com>
5905 * generic.cs (ConstructedType.ToString): Always use `name' as the
5908 2003-09-15 Martin Baulig <martin@ximian.com>
5910 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
5912 * generic.cs (Constraints.Resolve): New public method; this is
5913 called to resolve the constraint types and to check whether all
5914 the constraints are correct.
5915 (Constraints.Types): New public property.
5916 (TypeParameter.Resolve): New public method; resolves all the
5919 * class.cs (TypeContainer.DefineType): Call
5920 TypeParameter.Resolve() before actually defining the type.
5922 2003-09-15 Martin Baulig <martin@ximian.com>
5924 * class.cs (TypeContainer.DefineType): Added an error flag to
5925 avoid reporting duplicate CS0146's ("class definition is
5928 * driver.cs (Driver.MainDriver): Abort if
5929 RootContext.ResolveTree() reported any errors.
5931 2003-09-07 Martin Baulig <martin@ximian.com>
5933 * report.cs (Error, Warning): Added overloaded versions which take
5934 a `params object[] args' and call String.Format().
5936 2003-09-07 Martin Baulig <martin@ximian.com>
5938 * decl.cs (DeclSpace..ctor): Don't call
5939 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5940 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5941 (DeclSpace.RecordDecl): New method.
5943 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5945 2003-09-02 Ravi Pratap <ravi@ximian.com>
5947 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5948 value attributes to be applied to ParameterBuilders.
5950 * class.cs (MethodCore.LabelParameters): Make static and more
5951 generic so that it can be used from other places - like interface
5952 methods, for instance.
5954 * interface.cs (Interface.Emit): Call LabelParameters before
5955 emitting attributes on the InterfaceMethod.
5957 2003-09-07 Martin Baulig <martin@ximian.com>
5959 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
5960 if the number of type parameters doesn't match.
5962 2003-09-04 Martin Baulig <martin@ximian.com>
5964 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
5965 for arrays of generic type params (ie. `!0[]').
5967 2003-09-04 Martin Baulig <martin@ximian.com>
5969 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
5972 2003-09-04 Martin Baulig <martin@ximian.com>
5974 * decl.cs (DeclSpace.LookupGeneric): New method.
5975 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
5978 * generic.cs (TypeParameterExpr): Take a TypeParameter as
5979 argument, not just a string.
5980 (TypeParameter.Define): New public method; this is called to
5981 actually define the generic parameter; after this, you can use the
5982 new `Type' property to get the type.
5984 2003-09-04 Martin Baulig <martin@ximian.com>
5986 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
5987 is now an ArrayList; initialize the result of the `TypeParameters'
5989 (DeclSpace.GetGenericData): Removed.
5990 (DeclSpace.LookupGeneric): Temporarily removed; we need to
5991 implement this in a different way.
5992 (DeclSpace.GetTypeParameters): Removed; there's now a
5993 `TypeParameters' property.
5994 (DeclSpace.TypeParameters): New public property.
5996 * generic.cs (Constraints): Make this class public.
5997 (TypeParameter): New public class.
5999 2003-09-04 Martin Baulig <martin@ximian.com>
6001 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
6004 * class.cs (TypeContainer.DefineType): Call
6005 TypeBuilder.DefineGenericParameter () on all generic parameters if
6006 this is a generic type.
6008 2003-08-28 Martin Baulig <martin@ximian.com>
6010 * sample-stack.il: Compile this with ilasm: "ilasm /dll
6013 * sample-hello.cs: Compile this with gmcs: "gmcs
6014 /r:sample-stack.dll sample-hello.cs".
6016 2003-08-28 Martin Baulig <martin@ximian.com>
6018 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
6019 the parameters to the generic type.
6021 2003-08-28 Martin Baulig <martin@ximian.com>
6023 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
6025 2003-08-28 Martin Baulig <martin@ximian.com>
6027 * cs-parser.jay (opt_type_argument_list): Use
6028 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
6029 (primary_expression): Replace `qualified_identifier' with `type_name'.
6030 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
6032 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
6033 parser to check whether it is syntactically a type parameter list;
6034 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
6037 2003-08-26 Martin Baulig <martin@ximian.com>
6039 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
6040 resolving aliases; fixes #47927.
6042 2003-08-26 Martin Baulig <martin@ximian.com>
6044 * statement.cs (Using.DoResolve): This is internally emitting a
6045 try/finally clause, so we need to set ec.NeedExplicitReturn if we
6046 do not always return. Fixes #47681.
6048 2003-08-26 Martin Baulig <martin@ximian.com>
6050 * decl.cs (MemberCore): Moved WarningNotHiding(),
6051 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
6053 (AdditionResult): Make this nested in DeclSpace.
6054 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
6055 argument; call NamespaceEntry.Define() unless we're nested in a
6058 * namespace.cs (Namespace.DefineName): New public function. This
6059 is called from DeclSpace's .ctor to add
6060 (Namespace.Lookup): Include DeclSpaces in the lookup.
6062 * class.cs (Operator): Derive from MemberBase, not MemberCore.
6064 * const.cs (Const): Derive from MemberBase, not MemberCore.
6066 2003-08-25 Martin Baulig <martin@ximian.com>
6068 * convert.cs (Convert.ExplicitReferenceConversion): When
6069 converting from an interface type to a class, unbox if the target
6070 type is a struct type. Fixes #47822.
6072 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6074 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
6077 2003-08-22 Martin Baulig <martin@ximian.com>
6079 * class.cs (TypeManager.DefineType): When defining a nested type,
6080 call DefineType() on our parent; fixes #47801.
6082 2003-08-22 Martin Baulig <martin@ximian.com>
6084 * class.cs (MethodData.Define): While checking if a method is an
6085 interface implementation, improve the test a bit more to fix #47654.
6087 2003-08-22 Martin Baulig <martin@ximian.com>
6089 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
6090 correctly; fixes #47722.
6092 2003-08-22 Martin Baulig <martin@ximian.com>
6094 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
6095 LocalVariableReference, ensure it's not read-only. Fixes #47536.
6097 * statement.cs (Fixed.DoResolve): Make all variables read-only.
6099 2003-08-22 Martin Baulig <martin@ximian.com>
6101 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
6102 can only be assigned in static constructors. Fixes #47161.
6104 2003-08-22 Martin Baulig <martin@ximian.com>
6106 Rewrote and improved the flow analysis code.
6108 * flowbranching.cs (FlowBranching): Make this class abstract.
6109 (FlowBranching.CreateBranching): New static function to create a
6111 (FlowBranchingBlock, FlowBranchingException): New classes.
6112 (FlowBranching.UsageVector.Type): New public readonly field.
6113 (FlowBranching.UsageVector.Breaks): Removed the setter.
6114 (FlowBranching.UsageVector.Returns): Removed the setter.
6115 (FlowBranching.UsageVector): Added Break(), Return(),
6116 NeverReachable() and Throw() methods to modify the reachability.
6117 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
6118 done by FlowBranching.Merge().
6119 (FlowBranching.UsageVector.MergeChild): New method; merges the
6120 merge result into the current vector.
6121 (FlowBranching.Merge): New abstract method to merge a branching.
6123 2003-08-12 Martin Baulig <martin@ximian.com>
6125 * expression.cs (Indirection.CacheTemporaries): Create the
6126 LocalTemporary with the pointer type, not its element type.
6128 2003-08-10 Miguel de Icaza <miguel@ximian.com>
6130 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
6131 token was a keyword or not.
6133 Add `error' options where an IDENTIFIER was expected; Provide
6134 CheckToken and CheckIdentifierToken convenience error reporting
6137 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
6139 * decl.cs: Rename `NamespaceEntry Namespace' public field into
6140 NameSpaceEntry NameSpaceEntry.
6142 (LookupInterfaceOrClass): Avoid creating a full qualified name
6143 from namespace and name: avoid doing lookups when we know the
6144 namespace is non-existant. Use new Tree.LookupByNamespace which
6145 looks up DeclSpaces based on their namespace, name pair.
6147 * driver.cs: Provide a new `parser verbose' to display the
6148 exception thrown during parsing. This is turned off by default
6149 now, so the output of a failure from mcs is more graceful.
6151 * namespace.cs: Track all the namespaces defined in a hashtable
6154 (IsNamespace): New method
6156 2003-08-09 Miguel de Icaza <miguel@ximian.com>
6158 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
6159 we know that we need to concatenate (full typename can never be
6164 * statement.cs: Use a bitfield; Do not initialize to null things
6165 which are done by the constructor by default.
6167 * cs-parser.jay: bug fix, parameter was 4, not 3.
6169 * expression.cs: Just use the property;
6171 * statement.cs: No need for GetVariableInfo method.
6173 2003-08-08 Martin Baulig <martin@ximian.com>
6175 * flowanalysis.cs (FlowReturns): This is now nested in the
6176 `FlowBranching' class.
6177 (MyBitVector): Moved this here from statement.cs.
6178 (FlowBranching.SiblingType): New enum type.
6179 (FlowBranching.CreateSibling): Added `SiblingType' argument.
6181 2003-08-07 Martin Baulig <martin@ximian.com>
6183 * flowanalysis.cs (FlowBranchingType): This is now nested in the
6184 `FlowBranching' class and called `BranchingType'.
6186 2003-08-07 Martin Baulig <martin@ximian.com>
6188 * flowanalysis.cs: Moved all the control flow analysis code into
6191 2003-08-07 Martin Baulig <martin@ximian.com>
6193 * assign.cs (Assign.DoResolve): `target' must either be an
6194 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
6197 2003-08-07 Miguel de Icaza <miguel@ximian.com>
6199 * expression.cs (BinaryMethod): This kind of expression is created by the
6200 Binary class if it determines that the operator has to be handled
6203 (BinaryDelegate): This kind of expression is created if we are
6204 dealing with a + or - operator on delegates.
6206 (Binary): remove method, argumetns, and DelegateOperator: when
6207 dealing with methods,
6209 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
6211 * statement.cs (Block): use bitfields for the three extra booleans
6212 we had in use. Remove unused topblock parameter.
6214 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
6216 * assign.cs: Drop extra unneeded tests.
6218 2003-08-06 Miguel de Icaza <miguel@ximian.com>
6220 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
6222 * statement.cs (Foreach): Use VariableStorage instead of
6225 * codegen.cs (VariableStorage): New class used by clients that
6226 require a variable stored: locals or fields for variables that
6227 need to live across yield.
6229 Maybe provide a convenience api for EmitThis+EmitLoad?
6231 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
6234 2003-08-05 Miguel de Icaza <miguel@ximian.com>
6236 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
6237 RemapParameterLValue): New methods that are used to turn a
6238 precomputed FieldInfo into an expression like this:
6242 The idea is to use this instead of making LocalVariableReference
6243 have more than one meaning.
6245 * cs-parser.jay: Add error production to BASE.
6247 * ecore.cs: Deal with TypeManager.GetField returning null, which
6248 is now a valid return value.
6250 (FieldExprNoAddress): New expression for Fields whose address can
6253 * expression.cs (LocalVariableReference): During the resolve
6254 phases, create new expressions if we are in a remapping context.
6255 Remove code that dealt with remapping here.
6257 (ParameterReference): same.
6259 (ProxyInstance): New expression, like the `This' expression, but
6260 it is born fully resolved. We know what we are doing, so remove
6261 the errors that are targeted to user-provided uses of `this'.
6263 * statement.cs (Foreach): our variable is now stored as an
6264 Expression; During resolution, follow the protocol, dont just
6265 assume it will return this.
6267 2003-08-06 Martin Baulig <martin@ximian.com>
6269 * support.cs (SeekableStreamReader.cs): New public class.
6271 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
6272 SeekableStreamReader instead of the normal StreamReader.
6274 2003-08-04 Martin Baulig <martin@ximian.com>
6276 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
6277 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
6278 deambiguate casts and delegate invocations.
6279 (parenthesized_expression): Use the new tokens to ensure this is
6280 not a cast of method invocation.
6282 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
6283 when reading a `)' and Deambiguate_CloseParens () was previously
6286 * expression.cs (ParenthesizedExpression): New class. This is
6287 just used for the CS0075 test.
6288 (Binary.DoResolve): Check for CS0075.
6290 2003-07-29 Ravi Pratap <ravi@ximian.com>
6292 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
6293 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
6294 reference comparison.
6296 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
6297 examine the ReturnType for equality - this is necessary in the
6298 cases of implicit and explicit operators whose signature also
6299 includes the return type.
6301 2003-07-26 Miguel de Icaza <miguel@ximian.com>
6303 * namespace.cs: Cache the result of the namespace computation,
6304 instead of computing it every time.
6306 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6308 * decl.cs: Use a global arraylist that we reuse over invocations
6309 to avoid excesive memory consumption. Reduces memory usage on an
6310 mcs compile by one meg (45 average).
6312 * typemanager.cs (LookupTypeReflection): In .NET pointers are
6313 private, work around that.
6315 2003-07-23 Miguel de Icaza <miguel@ximian.com>
6317 * literal.cs (IntLiteral): Define Zero and One static literals.
6319 * cs-parser.jay (integer_literal): use static literals to reduce
6320 memory usage for the most used literals (0, 1 and -1). 211kb
6321 reduced in memory usage.
6323 Replace all calls to `new ArrayList' with `new
6324 ArrayList(4)' which is a good average number for most allocations,
6325 and also requires only 16 bytes of memory for its buffer by
6328 This reduced MCS memory usage in seven megabytes for the RSS after
6331 2003-07-28 Ravi Pratap <ravi@ximian.com>
6333 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
6334 handle params methods the correct way by forming only one
6335 applicable set with params and normal methods in them. Earlier we
6336 were looking at params methods only if we found no normal methods
6337 which was not the correct thing to do.
6339 (Invocation.BetterFunction): Take separate arguments indicating
6340 when candidate and the best method are params methods in their
6343 This fixes bugs #43367 and #46199.
6345 * attribute.cs: Documentation updates.
6347 (CheckAttribute): Rename to CheckAttributeTarget.
6348 (GetValidPlaces): Rename to GetValidTargets.
6350 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
6351 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
6355 2003-07-28 Miguel de Icaza <miguel@ximian.com>
6357 * codegen.cs: Compute IsGeneric correctly.
6359 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
6362 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
6363 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
6364 regressions, and I was chasing more bugs than I required.
6366 * interface.cs: Use expressions for base type names (like classes
6367 and structs have been doing for a while now), and resolve that.
6368 This patch should probably go into head as well.
6370 This makes it one less user of FindType.
6372 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6374 This compiler can not self host currently. Need to fix that.
6376 * Makefile: compile to `gmcs.exe'
6378 * driver.cs: Turn on v2 by default on gmcs.
6380 * generic.cs (ConstructedType): Does no longer take a container
6381 type argument; That will be taken care of later.
6383 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
6384 Use SimpleName to resolve for now, so we can continue the work on
6385 the parser, until we get Type.GetType that understands generics.
6387 (ConstructedType.ToString): Implement
6389 (TypeArguments.Resolve): Resolve the child expressions as types.
6391 * cs-parser.jay: Rename interface_constraints to
6392 type_parameter_constraints
6394 (namespace_or_type_name): Only use constructed types for the basic
6395 construction, we will deal with identifier<...> later.
6397 (type/type_name): No longer call DecomposeQI, as
6398 namespace_or_type_name is always decoded now.
6400 2003-07-22 Ravi Pratap <ravi@ximian.com>
6402 * expression.cs (Invocation.OverloadResolve): Follow the spec more
6403 closely: we eliminate methods in base types when we have an
6404 applicable method in a top-level type.
6406 Please see section 14.5.5.1 for an exact description of what goes
6409 This fixes bug #45127 and a host of other related to corlib compilation.
6411 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
6412 array is the method corresponding to the top-level type (this is
6413 because of the changes made to icall.c) so we change this
6416 (MethodGroupExpr.Name): This too.
6418 * typemanager.cs (GetElementType): New method which does the right
6419 thing when compiling corlib.
6421 * everywhere: Make use of the above in the relevant places.
6423 2003-07-22 Martin Baulig <martin@ximian.com>
6425 * cs-parser.jay (invocation_expression): Moved
6426 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
6427 `cast_expression', but create a InvocationOrCast which later
6428 resolves to either an Invocation or a Cast.
6430 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
6431 method; call this before EmitStatement() to make sure that this
6432 expression can be used as a statement.
6434 * expression.cs (InvocationOrCast): New class; resolves to either
6435 an Invocation or a Cast.
6437 * statement.cs (StatementExpression): Call ResolveStatement() on
6438 the ExpressionStatement before emitting it.
6440 2003-07-21 Martin Baulig <martin@ximian.com>
6442 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
6443 `ref' and `out' attributes match; fixes #46220.
6444 (MemberAccess.ResolveMemberAccess): You can't reference a type
6445 through an expression; fixes #33180.
6446 (Indexers.GetIndexersForType): Don't return the indexers from
6447 interfaces the class implements; fixes #46502.
6449 2003-07-21 Martin Baulig <martin@ximian.com>
6451 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
6452 CS0661 checks; fixes bug #30442.
6454 2003-07-21 Martin Baulig <martin@ximian.com>
6456 * decl.cs (AdditionResult): Added `Error'.
6458 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
6460 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
6461 cs0031.cs actually work.
6463 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6465 * cs-parser.jay (namespace_name): do not use
6466 namespace_or_type_name, use qualified_identifier, because
6467 namespace_or_type_name will soon return a composed expression
6468 instead of a string.
6470 (namespace_or_type_name): Instead of returning a string, now this
6471 production returns an expression.
6473 * codegen.cs (EmitContext): Setup IsGeneric property based on
6474 whether our DeclSpace is generic, our the method is generic.
6476 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
6477 the method is generic.
6479 * cs-parser.jay (type_arguments, opt_type_argument_list,
6480 type_parameters, type_parameter_list, opt_type_parameter_list,
6481 type_parameter,, opt_type_parameter_constraints_clauses,
6482 type_parameter_constraints_clauses,
6483 type_parameter_constraint_clause, type_parameter_constraint,
6484 interface_constraints): Add new production
6486 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
6487 DeclSpace is generic or not.
6489 (DeclSpace.SetParameterInfo): New routine, used to set the
6490 parameter info for a type.
6492 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
6493 returns a GenericTypeExpr
6495 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
6496 generic, lookup the generic argument.
6498 * attribute.cs: Do not allow TypeParameterExpressions in
6501 * class.cs: Do not allow the Main method to be defined in a
6504 * expression.cs (SizeOf): Do not allow generic types to be used as
6505 arguments to sizeof.
6507 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
6508 it: whether a type is generic or not. Only works for types we are
6509 currently building for now.
6511 2003-07-20 Martin Baulig <martin@ximian.com>
6513 * namespace.cs: Fixed that bug which caused a crash when compiling
6516 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6518 * typemanager.cs (LookupTypeReflection): Never expose types which
6519 are NotPublic, NestedPrivate, NestedAssembly, or
6520 NestedFamANDAssem. We used to return these, and later do a check
6521 that would report a meaningful error, but the problem is that we
6522 would not get the real match, if there was a name override.
6524 2003-07-18 Miguel de Icaza <miguel@ximian.com>
6526 * namespace.cs (Namespace, Name): Do not compute the namespace
6527 name dynamically, compute it in the constructor. This reduced
6528 memory usage by 1697 KB.
6530 * driver.cs: Use --pause to pause at the end.
6532 2003-07-17 Peter Williams <peter@newton.cx>
6534 * Makefile: Change the name of the test target so that it doesn't
6535 conflict with the recursive test target.
6537 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6539 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6540 AddressOf): Do not use EmitThis, that was wrong, use the actual
6543 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6545 * class.cs (MethodData.Define): While checking if a method is an
6546 interface implementation, improve the test: If we are not public
6547 (use new test here: use the computed MethodAttributes directly,
6548 instead of the parsed modifier flags) check if the `implementing'
6549 method comes from an interface or not.
6551 * pending.cs (VerifyPendingMethods): Slightly better error
6554 * makefile: add test target that does the mcs bootstrap.
6556 2003-07-16 Ravi Pratap <ravi@ximian.com>
6558 * interface.cs (Define): Do nothing here since there are no
6559 members to populate etc. Move the attribute emission out of here
6560 since this was just totally the wrong place to put it. Attribute
6561 application happens during the 'Emit' phase, not in the 'Define'
6564 (Emit): Add this method and move the attribute emission here
6566 * rootcontext.cs (EmitCode): Call the Emit method on interface
6569 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6571 * expression.cs (OverloadResolve): Report error only if Location
6572 is not 'Null' which means that there was a probe going on.
6574 2003-07-14 Martin Baulig <martin@ximian.com>
6576 * expression.cs (ConditionalLogicalOperator): New public class to
6577 implement user defined conditional logical operators.
6578 This is section 14.11.2 in the spec and bug #40505.
6580 2003-07-14 Martin Baulig <martin@ximian.com>
6582 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6584 2003-07-14 Martin Baulig <martin@ximian.com>
6586 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6588 * ecore.cs (IVariable.VerifyFixed): New interface method.
6590 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6591 operator, check whether the variable is actually fixed. Fixes bug
6592 #36055. Set a variable definitely assigned when taking its
6593 address as required by the spec.
6595 * statement.cs (LocalInfo.IsFixed): New field.
6596 (LocalInfo.MakePinned): Set `IsFixed' to true.
6598 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6600 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6601 for .ctors, ensure that we only ask for members declared in the
6602 attribute type (BindingFlags.DeclaredOnly).
6606 * expression.cs (Error_WrongNumArguments): Report error 1501
6607 correctly the way CSC does.
6609 2003-07-13 Martin Baulig <martin@ximian.com>
6611 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6612 lookup on the fully qualified name, to make things like "X.X" work
6613 where "X.X" is a fully qualified type name, but we also have a
6614 namespace "X" in the using list. Fixes #41975.
6616 2003-07-13 Martin Baulig <martin@ximian.com>
6618 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6619 function. If we're a CompoundAssign, we need to create an embedded
6620 CompoundAssign, not an embedded Assign.
6621 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6624 2003-07-13 Martin Baulig <martin@ximian.com>
6626 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6627 work to fix bug #46088.
6629 2003-07-13 Ravi Pratap <ravi@ximian.com>
6631 * class.cs (Operator.Emit): Do not emit attributes here - it is
6632 taken care of by the Method class that we delegate too. This takes
6635 2003-07-10 Martin Baulig <martin@ximian.com>
6637 * expression.cs (TypeOfVoid): New class.
6638 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6640 2003-07-10 Martin Baulig <martin@ximian.com>
6642 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6645 2003-07-10 Martin Baulig <martin@ximian.com>
6647 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6648 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6650 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6652 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6654 2003-07-10 Martin Baulig <martin@ximian.com>
6656 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6657 of decimal. Fixes #42850.
6659 NOTE: I also fixed the created byte blob, but this doesn't work on
6660 the MS runtime and csc never produces any byte blobs for decimal
6663 2003-07-10 Martin Baulig <martin@ximian.com>
6665 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6666 structs; fixes #32068.
6667 (Block.AddChildVariableNames): Fixed #44302.
6669 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6671 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6673 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6675 * attribute.cs: And this test is onger needed.
6677 2003-07-08 Martin Baulig <martin@ximian.com>
6679 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6680 inaccessible types. Fixes #36313.
6682 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6684 * namespace.cs (NamespaceEntry): Create implicit entries for all
6685 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6686 implicit entries for N1.N2 and N1.
6688 2003-07-08 Martin Baulig <martin@ximian.com>
6690 Rewrote the handling of namespaces to fix a lot of the issues
6691 wrt. `using' aliases etc.
6693 * namespace.cs (Namespace): Splitted this class into a
6694 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6696 * typemanager.cs (TypeManager.IsNamespace): Removed.
6697 (TypeManager.ComputeNamespaces): Only compute namespaces from
6698 loaded assemblies here, not the namespaces from the assembly we're
6699 currently compiling.
6701 2003-07-08 Martin Baulig <martin@ximian.com>
6703 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6705 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6707 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6710 I thought about the memory savings here, but LookupTypeReflection
6711 is used under already very constrained scenarios. Compiling
6712 corlib or mcs only exposes one hit, so it would not really reduce
6713 any memory consumption.
6715 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6717 * typemanager.cs: fixes bug #45889 by only adding public types from
6718 other assemblies to the list of known types.
6720 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6722 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6723 on the type we resolved.
6725 2003-07-05 Martin Baulig <martin@ximian.com>
6727 * pending.cs (PendingImplementation.ParentImplements): Don't
6728 create the proxy if the parent is abstract.
6730 * class.cs (TypeContainer.DefineIndexers): Process explicit
6731 interface implementations first. Fixes #37714.
6733 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6735 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6736 defined recursively; but since we modify the input parameters
6737 (left is set to `this' temporarily), we reset this value if the
6738 left_is_explicit is false, which gives the original semantics to
6741 * literal.cs (NullPointer): new class used to represent a null
6742 literal in a pointer context.
6744 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6745 type is a pointer, use a NullPointer object instead of a
6746 NullLiteral. Closes 43687
6748 (ExplicitConversion): Convert pointer values using
6749 the conv opcode to the proper type.
6751 * ecore.cs (New): change ValueTypeVariable property into a method,
6752 that returns whether the valuetype is suitable for being used.
6754 * expression.cs (Binary.DoNumericPromotions): Only return if we
6755 the int constant was a valid uint, and we can return both left and
6756 right as uints. If not, we continue processing, to trigger the
6757 type conversion. This fixes 39018.
6759 * statement.cs (Block.EmitMeta): During constant resolution, set
6760 the CurrentBlock property on the emitcontext, so that we resolve
6761 constants propertly.
6763 2003-07-02 Martin Baulig <martin@ximian.com>
6765 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6766 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6768 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6769 than emitting it here.
6771 * statement.cs: Fixed some more flow analysis bugs.
6773 2003-07-02 Martin Baulig <martin@ximian.com>
6775 * class.cs (MethodData.Define): When implementing interface
6776 methods, set Final unless we're Virtual.
6778 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6779 check work for interface methods.
6781 2003-07-01 Martin Baulig <martin@ximian.com>
6783 * ecore.cs (EmitContext.This): Replaced this property with a
6784 GetThis() method which takes a Location argument. This ensures
6785 that we get the correct error location for a CS0188.
6787 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6789 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6790 ImplicitStandardConversion.
6792 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6794 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6796 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6799 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6801 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6804 (MethodData.Define): Turn off initlocals for unsafe methods.
6806 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6808 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6809 complete; Fixes #37521.
6811 * delegate.cs: Use Modifiers.TypeAttr to compute the
6812 TypeAttributes, instead of rolling our own. This makes the flags
6813 correct for the delegates.
6815 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6817 * class.cs (Constructor.Define): Set the private flag for static
6818 constructors as well.
6820 * cs-parser.jay (statement_expression): Set the return value to
6821 null, to avoid a crash when we catch an error.
6823 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6825 * cs-parser.jay: Applied patch from Jackson that adds support for
6826 extern and unsafe modifiers to destructor declarations.
6828 * expression.cs: Report error 21 if the user is trying to index a
6831 * driver.cs: Add an error message, suggested by the bug report.
6833 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6834 if we do not have a ": this ()" constructor initializer. Fixes 45149
6836 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6838 * namespace.cs: Add some information to reduce FAQs.
6840 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6842 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6843 underlying enumeration types. Fixes #43915.
6845 * expression.cs: Treat ushort/short as legal values to be used in
6848 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6850 * delegate.cs: transfer custom attributes for paramenters from
6851 the delegate declaration to Invoke and BeginInvoke.
6853 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6855 * attribute.cs: handle custom marshalers and emit marshal info
6858 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6860 * makefile.gnu: Added anonymous.cs to the compiler sources.
6862 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6864 * iterators.cs: Change the name of the proxy class to include two
6867 * cs-parser.jay: Update grammar to include anonymous methods.
6869 * anonymous.cs: new file.
6871 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6873 * class.cs (Field.Define): Add missing test for pointers and
6876 2003-05-27 Ravi Pratap <ravi@ximian.com>
6878 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6879 we use the stobj opcode.
6881 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6882 since it wasn't the correct fix.
6884 It still is puzzling that we are required to use stobj for IntPtr
6885 which seems to be a ValueType.
6887 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6889 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6890 during regular simple name resolution. Now, the trick is that
6891 instead of returning for processing the simplename, we do a
6892 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6893 contextual lookup type). If a match is found, return that, if
6894 not, return for further composition.
6896 This fixes long-standing 30485.
6898 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6899 using the address to initialize an object, do an Stobj instead of
6900 using the regular Stelem.
6902 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6903 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6904 Because if we are a BaseIndexerAccess that value will be true.
6907 * statement.cs (GotoCase.Resolve): Return after reporting an
6908 error, do not attempt to continue.
6910 * expression.cs (PointerArithmetic.Emit): If our operand is a
6911 long, convert our constants to match the operand before
6912 multiplying. Convert to I type before adding. Fixes 43670.
6914 2003-05-14 Ravi Pratap <ravi@ximian.com>
6916 * enum.cs (ImplicitConversionExists) : Rename to
6917 ImplicitEnumConversionExists to remove ambiguity.
6919 * ecore.cs (NullCast): New type of cast expression class which
6920 basically is very similar to EmptyCast with the difference being
6921 it still is a constant since it is used only to cast a null to
6925 * convert.cs (ImplicitReferenceConversion): When casting a null
6926 literal, we return a NullCast.
6928 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6929 should be around anymore.
6931 The renaming (reported was slightly wrong). Corrections:
6933 ConvertImplicitStandard -> ImplicitConversionStandard
6934 ConvertExplicitStandard -> ExplicitConversionStandard
6936 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6937 before passing them in !
6939 * convert.cs (ImplicitConversionStandard): When comparing for
6940 equal expr and target types, ensure that expr is not a
6943 In general, we must not be checking (expr_type ==
6944 target_type) in the top level conversion methods
6945 (ImplicitConversion, ExplicitConversion etc). This checking is
6946 done in the methods that they delegate to.
6948 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6950 * convert.cs: Move Error_CannotConvertType,
6951 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6952 ImplicitNumericConversion, ImplicitConversionExists,
6953 ImplicitUserConversionExists, StandardConversionExists,
6954 FindMostEncompassedType, FindMostSpecificSource,
6955 FindMostSpecificTarget, ImplicitUserConversion,
6956 ExplicitUserConversion, GetConversionOperators,
6957 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6958 TryImplicitIntConversion, Error_CannotConvertImplicit,
6959 ConvertImplicitRequired, ConvertNumericExplicit,
6960 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6961 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6964 Perform the following renames:
6966 StandardConversionExists -> ImplicitStandardConversionExists
6967 ConvertImplicit -> ImplicitConversion
6968 ConvertImplicitStandard -> ImplicitStandardConversion
6969 TryImplicitIntConversion -> ImplicitIntConversion
6970 ConvertImplicitRequired -> ImplicitConversionRequired
6971 ConvertNumericExplicit -> ExplicitNumericConversion
6972 ConvertReferenceExplicit -> ExplicitReferenceConversion
6973 ConvertExplicit -> ExplicitConversion
6974 ConvertExplicitStandard -> ExplicitStandardConversion
6976 2003-05-19 Martin Baulig <martin@ximian.com>
6978 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6979 (TypeInfo): Added support for structs having structs as fields.
6981 * ecore.cs (FieldExpr): Implement IVariable.
6982 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6983 VariableInfo for the field.
6985 2003-05-18 Martin Baulig <martin@ximian.com>
6987 * expression.cs (This.DoResolve): Report a CS0027 if we're
6988 emitting a field initializer.
6990 2003-05-18 Martin Baulig <martin@ximian.com>
6992 * expression.cs (This.ResolveBase): New public function.
6993 (This.DoResolve): Check for CS0188.
6995 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6998 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6999 `instance_expression' to null if we don't have any non-static
7002 2003-05-18 Martin Baulig <martin@ximian.com>
7004 Reworked the way how local variables and parameters are handled by
7005 the flow analysis code.
7007 * statement.cs (TypeInfo, VariableMap): New public classes.
7008 (VariableInfo): New public class. This is now responsible for
7009 checking whether a variable has been assigned. It is used for
7010 parameters and local variables.
7011 (Block.EmitMeta): Take the InternalParameters as argument; compute
7012 the layout of the flow vectors here.
7013 (Block.LocalMap, Block.ParameterMap): New public properties.
7014 (FlowBranching): The .ctor doesn't get the InternalParameters
7015 anymore since Block.EmitMeta() now computes the layout of the flow
7017 (MyStructInfo): This class is now known as `StructInfo' and nested
7018 in `TypeInfo'; we don't access this directly anymore.
7020 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
7021 property and removed IsAssigned(), IsFieldAssigned(),
7022 SetAssigned() and SetFieldAssigned(); we now call them on the
7023 VariableInfo so we don't need to duplicate this code everywhere.
7025 * expression.cs (ParameterReference): Added `Block block' argument
7027 (LocalVariableReference, ParameterReference, This): The new
7028 VariableInfo class is now responsible for all the definite
7031 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
7032 IsParameterAssigned, SetParameterAssigned): Removed.
7034 2003-05-18 Martin Baulig <martin@ximian.com>
7036 * typemanager.cs (InitCoreTypes): Try calling
7037 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
7038 the 3-args-version. Corlib now also needs our `void_type'.
7039 (GetMethod): Added overloaded version which takes an optional
7040 `bool report_errors' to allow lookups of optional methods.
7042 2003-05-12 Martin Baulig <martin@ximian.com>
7044 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
7045 only used for locals and not for parameters.
7047 2003-05-12 Miguel de Icaza <miguel@ximian.com>
7049 * support.cs (InternalParameters.ParameterType): Return the
7050 ExternalType of the parameter.
7052 * parameter.cs (Parameter.ExternalType): drop the two arguments,
7055 2003-05-11 Miguel de Icaza <miguel@ximian.com>
7057 * class.cs (MethodData.Define): Do not set the `newslot' on
7058 interface members, if they are also flagged as "override".
7060 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
7061 better code for ++i and i++. This only works for static fields
7062 and local variables.
7064 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
7065 want to pull the DeclSpace out of the builder_to_declspace instead
7066 of the TypeBuilder (like in TypeContainer.FindMembers).
7068 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
7069 instead of LookupTypeContainer. Fixes the crash on .NET for
7070 looking up interface members.
7072 * const.cs: Create our own emit context during the Definition
7073 stage, so that constants are evaluated in the proper context, when
7074 a recursive definition happens.
7076 2003-05-11 Martin Baulig <martin@ximian.com>
7078 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
7079 new block for a switch section.
7080 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
7081 the adding/lookup in the switch block. Fixes #39828.
7083 2003-05-09 Miguel de Icaza <miguel@ximian.com>
7085 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
7086 functionality: I needed to convert the data after I had performed
7087 the add/sub operation into the operands type size.
7089 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
7090 pass the type for the box operation, otherwise the resulting
7091 object would have been of type object.
7093 (BoxedCast): Add constructor to specify the type to box as.
7095 2003-05-07 Miguel de Icaza <miguel@ximian.com>
7097 * iterators.cs: I was reusing the `count' variable inadvertently,
7098 take steps to not allow this to happen.
7100 2003-05-06 Miguel de Icaza <miguel@ximian.com>
7102 * attribute.cs (Attribute.Resolve): Params attributes are encoded
7103 by creating an array at the point where the params starts and
7104 putting all those arguments there, then adjusting the size of the
7107 2003-05-05 Miguel de Icaza <miguel@ximian.com>
7109 * expression.cs (New.AddressOf): Implement interface
7110 IMemoryLocation. This is used when the `new' operator is used in
7111 the context of an invocation to a method on a value type.
7113 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
7116 * namespace.cs: Also check the using aliases here.
7118 * driver.cs: Move the test for using validity after the types have
7119 been entered, so we do a single pass that also includes the using
7122 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
7123 in the regular case. CreateSiblingForFinally is doing extra
7126 * attribute.cs (GetAttributeArgumentExpression): Store the result
7127 on an out value, and use the return value to indicate failure
7128 instead of using null (which is a valid return for Constant.GetValue).
7130 * statement.cs: Perform the analysis flow for the increment
7131 portion after the statement, because this will be the real flow of
7132 execution. Fixes #42385
7134 * codegen.cs (EmitContext.EmitArgument,
7135 EmitContext.EmitStoreArgument): New helper functions when the
7136 RemapToProxy flag is set.
7138 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
7141 Add support for remapping parameters.
7143 * iterators.cs: Propagate parameter values; Store parameter
7144 values in the proxy classes.
7146 2003-05-04 Miguel de Icaza <miguel@ximian.com>
7148 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
7149 need a proxy reference; I do not know what I was thinking
7151 * cs-parser.jay (constructor_initializer): catch another error,
7152 and display nice message.
7154 (field_declaration): catch void field declaration
7155 to flag a better error.
7157 * class.cs (MemberBase.CheckBase): Report an error instead of a
7158 warning if a new protected member is declared in a struct.
7159 (Field.Define): catch the error of readonly/volatile.
7161 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
7163 (FieldExpr.AddressOf): ditto. Catch error where the address of a
7164 volatile variable is taken
7166 2003-05-02 Miguel de Icaza <miguel@ximian.com>
7168 * statement.cs (Fixed.Resolve): Report an error if we are not in
7171 2003-05-01 Miguel de Icaza <miguel@ximian.com>
7173 * typemanager.cs: reuse the code that handles type clashes for
7174 delegates and enumerations.
7176 * class.cs (Report28): Always report.
7178 * expression.cs (EncodeAsAttribute): Allow nulls here.
7180 2003-04-28 Miguel de Icaza <miguel@ximian.com>
7182 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
7183 the functionality for testing whether an expression is valid for
7184 an attribute here. Also handle the case of arrays of elements
7187 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
7188 encoding a linear array into an array of objects that are suitable
7189 to be passed to an CustomAttributeBuilder.
7191 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
7193 * ecore.cs: (FieldExpr): Handle field remapping here.
7195 * iteratators.cs: Pass the instance variable (if the method is an
7196 instance method) to the constructors, so we can access the field
7197 variables on the class.
7199 TODO: Test this with structs. I think the THIS variable on
7200 structs might have to be a pointer, and not a refenrece
7202 2003-04-27 Miguel de Icaza <miguel@ximian.com>
7204 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
7205 local variables to fields in a proxy class.
7207 * iterators.cs (PopulateProxy): Rename our internal fields to
7209 Create a <THIS> field if we are an instance method, so we can
7210 reference our parent container variables.
7211 (MapVariable): Called back from the EmitContext code to enter a
7212 new variable to field mapping into the proxy class (we just create
7216 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
7217 for using the remapped locals to fields.
7219 I placed the code here, because that gives the same semantics to
7220 local variables, and only changes the Emit code.
7222 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
7223 statements inside iterators.
7224 (VariableInfo): Add a FieldBuilder for the cases when we are
7225 remapping local variables to fields in a proxy class
7227 * ecore.cs (SimpleNameResolve): Avoid testing two times for
7228 current_block != null.
7230 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
7231 not cope with strings, as it has been moved to the
7232 TableSwitchEmit. Fixed bug in switch generation.
7234 * expression.cs (New.DoResolve): Provide more context for the user
7235 when reporting an error.
7237 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
7240 * expression.cs (MemberAccess.DoResolve): When we get a type back,
7241 check the permissions for it. Note than in a type-resolution
7242 context the check was already present in DeclSpace.ResolveType,
7243 but was missing from the MemberAccess.
7245 (ArrayCreation.CheckIndices): warn if the user has
7246 more nested levels of expressions, but there are no more
7247 dimensions specified. Avoids crash on bug 41906.
7249 2003-04-26 Miguel de Icaza <miguel@ximian.com>
7251 * statement.cs (Block): replace Implicit bool, for a generic
7253 New flag: `Unchecked'. This is used during the EmitMeta phase
7254 (which is out-of-line with the regular Resolve/Emit process for a
7255 statement, as this is done ahead of time, but still gets a chance
7256 to call constant resolve).
7258 (Block.Flags): new enum for adding a new flag.
7260 (Block.EmitMeta): track the state of unchecked.
7262 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
7263 to enable constant resolution to work there as well.
7265 2003-04-22 Miguel de Icaza <miguel@ximian.com>
7267 * typemanager.cs (ienumerable_type): Also look up
7268 System.Collections.IEnumerable.
7270 2003-04-21 Miguel de Icaza <miguel@ximian.com>
7272 TODO: Test more than one conditional per method.
7274 * class.cs (Indexer.Define): Report the location where the user is
7275 referencing the unsupported feature.
7277 (MethodData): Overload the use of `conditionals' to
7278 minimize the creation of needless ArrayLists. This saves roughly
7279 212kb on my machine.
7281 (Method): Implement the new IIteratorContainer interface.
7282 (Method.SetYields): Implement the method by setting the ModFlags
7283 to contain METHOD_YIELDS.
7285 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
7286 which just got set to null.
7288 * iterators.cs: New file.
7290 (Yield, YieldBreak): New statements.
7292 * statement.cs (Return.Resolve): Flag an error if we are used in
7295 * codegen.cs (InIterator): New flag set if the code is being
7296 compiled in an iterator method.
7298 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
7299 internal modifier, and we just use it to avoid adding extra
7300 fields, as this is seldom used.
7302 * cs-parser.jay: Add yield_statement (yield and yield break).
7304 * driver.cs: New flag -v2 to turn on version 2 features.
7306 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
7307 hashtable when v2 is enabled.
7309 2003-04-20 Miguel de Icaza <miguel@ximian.com>
7311 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
7312 there is already a namespace defined with this name.
7314 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
7315 people upgraded their corlibs.
7317 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
7318 always use fully qualified types, no need to use the compiler
7321 (TypeManager.IsNamespace): Use binarysearch.
7323 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
7324 AddDelegate): I did not quite use the new IsValid API properly: I
7325 have to pass the short-name and the fullname. I was passing only
7326 the basename instead of the fullname sometimes.
7328 (TypeContainer.DefineType): call NamespaceClash.
7330 * interface.cs (Interface.DefineType): use NamespaceClash before
7333 * delegate.cs (Delegate.DefineType): use NamespaceClash before
7336 * enum.cs: (Enum.DefineType): use NamespaceClash before
7339 * typemanager.cs (: 3-line patch that gives us some tasty 11%
7340 speed increase. First, use the negative_hits cache when we get a
7341 negative. Second, add the type with its full original name
7342 instead of the new . and + encoded name (reflection uses + to
7343 separate type from a nested type). Use LookupTypeReflection
7344 directly which bypasses the type->name hashtable (that we already
7345 know does not contain the type.
7347 * decl.cs (DeclSpace.ResolveTypeExpr): track the
7348 location/container type.
7350 * driver.cs: When passing utf8, use directly the UTF8Encoding.
7352 2003-04-19 Miguel de Icaza <miguel@ximian.com>
7354 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
7356 * delegate.cs (NewDelegate.Resolve): Test whether an instance
7357 method is being referenced in the method group from a static
7358 context, and report error 120 if so.
7360 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
7363 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
7364 is created, we create the A namespace).
7366 * cs-parser.jay: A namespace also introduces a DeclarationFound.
7369 2003-04-18 Miguel de Icaza <miguel@ximian.com>
7371 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
7372 invocation to ModuleBuilder.GetType with the same values will
7373 return a new type instance, so we need to cache its return
7376 * expression.cs (Binary.ResolveOperator): Only allow the compare
7377 operators on enums if they are of the same type.
7379 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
7380 types of ValueType on their own case. Before we were giving them
7381 the same treatment as objects.
7383 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
7384 fullname. Short name is used to compare against container name.
7385 Fullname is used to check against defined namespace names.
7387 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
7388 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
7390 (Method.CheckBase): Call parent.
7391 (MemberBase.CheckBase): Check for protected members on sealed
7393 (PropertyBase.CheckBase): Call parent.
7394 (Field.Define): Call parent.
7396 * report.cs: Negative error codes are now mapped to 8000 - code,
7397 so that the display is render more nicely.
7399 * typemanager.cs: Do not use try/catch, instead report a regular
7402 (GetPointerType, GetReferenceType): These methods provide
7403 mechanisms to obtain the T* and T& from a T. We had the code
7404 previously scattered around the code base, and it also used
7405 TypeManager.LookupType that would go through plenty of caches.
7406 This one goes directly to the type source.
7408 In some places we did the Type.GetType followed by
7409 ModuleBuilder.GetType, but not in others, so this unifies the
7412 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
7413 statements now that we have namespace information.
7415 * typemanager.cs (IsNamespace): New method, returns whether the
7416 string presented is a namespace or not.
7418 (ComputeNamespaces): New public entry point, computes the list of
7419 available namespaces, using the GetNamespaces API call in Mono, or
7420 the slower version in MS.NET.
7422 Now before we start the semantic analysis phase, we have a
7423 complete list of namespaces including everything that the user has
7426 Deleted old code to cache namespaces in .nsc files.
7428 2003-04-17 Miguel de Icaza <miguel@ximian.com>
7430 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
7431 class/struct location definition Location for the implicit
7432 constructor location.
7434 (Operator.Define): Use the location of the operator for the
7435 implicit Method definition.
7437 (Constructor.Emit): use the constructor location for the implicit
7438 base initializer constructor.
7440 * ecore.cs: Remove ITypeExpression. This interface is now gone,
7441 and the Expression class now contains two new methods:
7443 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
7444 isolate type lookup from the rest of the resolution process.
7446 Since we use Expressions to hold type definitions due to the way
7447 we parse the input we have historically overloaded Resolve to
7448 perform the Type lookups if a special flag is passed. Now this is
7449 eliminated and two methods take their place.
7451 The differences in the two methods between xStep and xTerminal is
7452 that xStep is involved in our current lookup system that uses
7453 SimpleNames to compose a name, while xTerminal is used just to
7454 catch the case where the simplename lookup failed.
7456 2003-04-16 Miguel de Icaza <miguel@ximian.com>
7458 * expression.cs (ResolveMemberAccess): Remove redundant code.
7459 TypeExpr expressions are always born fully resolved.
7461 * interface.cs (PopulateMethod): Do not lookup the types twice.
7462 We were doing it once during SemanticAnalysis and once during
7465 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
7466 in local variable type definitions, were being returned as a
7467 SimpleName (we decomposed everything into a string), that is
7468 because primary_expression was being used instead of a type in the
7469 grammar (reduce/reduce conflicts).
7471 The part that was wrong is that we converted the expression into a
7472 string (an oversimplification in one hand, compounded with primary
7473 expressions doing string concatenation).
7479 Would return "A.B.C[]" as a SimpleName. This stopped things like
7480 using clauses from working on this particular context. And a type
7481 was being matched directly against "A.B.C[]".
7483 We now use the correct approach, and allow for ComposedCast to be
7484 part of the unary expression. So the "A.B.C []" become a composed
7485 cast of "A.B.C" (as a nested group of MemberAccess with a
7486 SimpleName at the end) plus the rank composition "[]".
7490 2003-04-10 Miguel de Icaza <miguel@ximian.com>
7492 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
7493 for the access level checking.
7495 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
7496 `TypeContainer container', because I kept getting confused when I
7497 was debugging this code.
7499 * expression.cs (Indexers): Instead of tracking getters/setters,
7500 we now track them in parallel. We create one arraylist less, but
7501 most importantly it is possible now for the LValue code to find a
7502 matching get for a set.
7504 (IndexerAccess.DoResolveLValue): Update the code.
7505 GetIndexersForType has been modified already to extract all the
7506 indexers from a type. The code assumed it did not.
7508 Also make the code set the correct return type for the indexer.
7509 This was fixed a long time ago for properties, but was missing for
7510 indexers. It used to be void_type.
7512 (Binary.Emit): Test first for doubles instead of
7513 floats, as they are more common.
7515 (Binary.EmitBranchable): Use the .un version of the branch opcodes
7516 when dealing with floats and the <=, >= operators. This fixes bug
7519 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
7520 to load the array value by emitting a load on the foreach variable
7521 type. This was incorrect.
7523 We now emit the code to load an element using the the array
7524 variable type, and then we emit the conversion operator.
7528 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
7530 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7532 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7534 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7535 test for protection before we test for signatures.
7537 (MethodSignature.ToString): implement.
7539 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7540 to the case where we reduced into a LongConstant.
7542 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7543 depend on whether the information is acurrate, because the
7544 Microsoft runtime will always claim that the array type is public,
7545 regardless of the real state.
7547 If the type is a pointer, another problem happens: the type is
7548 reported as non-public in Microsoft.
7550 In both cases we have to call CheckAccessLevel recursively with
7551 the underlying type as the argument to be tested.
7553 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7555 * assign.cs (Assign.Emit): If we are dealing with a compound
7556 assignment expression, we should use the code path that stores the
7557 intermediate result in a temporary value. This fixes #40903.
7559 *expression.cs (Indirection.ToString): Provide ToString method for
7562 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7564 * class.cs: Null out fields holding references to Block objects so
7565 they can be garbage collected.
7567 * expression.cs (OverloadResolve): Remove unused local.
7569 2003-04-07 Martin Baulig <martin@ximian.com>
7571 * codegen.cs (EmitContext.CurrentFile): New public field.
7572 (EmitContext.Mark): Use the CurrentFile to check whether the
7573 location is in the correct file.
7574 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7576 2003-04-07 Martin Baulig <martin@ximian.com>
7578 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7580 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7581 location. [FIXME: The location argument which gets passed to this
7582 method is sometimes wrong!]
7584 2003-04-07 Nick Drochak <ndrochak@gol.com>
7586 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7588 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7590 * expression.cs (Indirection.EmitAssign): We were using the
7591 temporary, but returning immediately instead of continuing the
7594 2003-04-06 Martin Baulig <martin@ximian.com>
7596 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7597 if it's a nested child, but also deriving from the outer class.
7600 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7601 nested child, but also deriving from the outer class. See
7603 (FilterWithClosure): We may access private members of the outer
7604 class if we're a nested child and deriving from the outer class.
7605 (RealMemberLookup): Only set `closure_private_ok' if the
7606 `original_bf' contained BindingFlags.NonPublic.
7608 2003-04-05 Martin Baulig <martin@ximian.com>
7610 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
7611 probe if its a type parameter, and if so, flag an error.
7613 * decl.cs: Move here the SetParameterInfo code from class.cs.
7614 Handle IsGeneric here.
7616 Handle a variety of errors in the parameter info definition.
7618 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
7619 type parameters here.
7621 * cs-parser.jay (class_declaration): report errors for parameters
7624 2003-01-21 Miguel de Icaza <miguel@ximian.com>
7626 * generic.cs: New file, contains support code for generics.
7628 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
7629 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
7631 Update parser for the above removals.
7633 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
7634 now taken care of in the parser.
7636 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7638 * class.cs (Event.Define): Do not allow abstract events to have
7641 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7643 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7644 block in event declarations.
7646 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7647 value type, get its address.
7649 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7650 leaving a class on the stack instead of a boolean value (int
7651 0/1). Change the code so we compare against null, and then the
7652 result against zero.
7654 * class.cs (TypeContainer.GetClassBases): We were checking for the
7655 parent class being sealed too late.
7657 * expression.cs (Binary.Emit): For <= and >= when dealing with
7658 floating point values, use cgt.un and clt.un instead of cgt and
7661 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7663 * statement.cs: Apply the same optimization as MS: skip the
7664 GetEnumerator returning an IEnumerator, and use the one returning a
7665 CharEnumerator instead. This allows us to avoid the try-finally block
7668 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7670 * cs-parser.jay: Attributes cannot be applied to
7671 namespaces. Fixes #40473
7673 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7676 (Add*): check if the name is valid using the full name for constants,
7677 fields, properties and events.
7679 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7681 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7682 char constants to be part of the enumeration.
7684 * expression.cs (Conditional.DoResolve): Add support for operator
7685 true. Implements the missing functionality from 14.12
7687 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7688 operator true/false as required by the spec.
7690 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7691 implicit conversion to boolean.
7693 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7694 also one where the type implements `operator true'.
7696 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7697 get an expression that will invoke operator true based on an
7700 (GetConversionOperators): Removed the hack that called op_True
7703 (Expression.ResolveBoolean): Move this from Statement.
7705 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7707 * ecore.cs (FieldExpr): do not allow initialization of initonly
7708 fields on derived classes
7710 2003-03-13 Martin Baulig <martin@ximian.com>
7712 * statement.cs (Block.Emit): Call ig.BeginScope() and
7713 ig.EndScope() when compiling with debugging info; call
7714 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7716 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7718 * expression.cs (Indexers): Do not construct immediately, allow
7719 for new members to be appended as we go. Fixes 38143
7721 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7723 * expression.cs: save/restore context when resolving an unchecked
7726 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7728 * cfold.cs: Catch division by zero in modulus operator during
7731 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7733 * interface.cs (Interface.DefineMembers): Avoid defining members
7736 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7738 * driver.cs: handle the +/- options for -noconfig
7740 * statement.cs (Unckeched.Resolve): Also track the state of
7741 unchecked in the Resolve phase.
7743 2003-02-27 Martin Baulig <martin@ximian.com>
7745 * ecore.cs (Expression.MemberLookup): Don't create a
7746 MethodGroupExpr for something which is not a method. Fixes #38291.
7748 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7750 * class.cs (MemberBase.CheckParameters): Also check that the type
7751 is unmanaged if it is a pointer.
7753 * expression.cs (SizeOf.Resolve): Add location information.
7755 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7756 a managed type is declared.
7758 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7759 parameter modifiers as well. Fixes bug 38606
7761 * class.cs: Very sad. Am backing out the speed up changes
7762 introduced by the ArrayList -> Array in the TypeContainer, as they
7763 were not actually that much faster, and introduced a bug (no error
7764 reports on duplicated methods).
7766 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7767 source first, this will guarantee that we have a valid expression
7768 before calling in lower levels functions that will require a
7769 resolved object. Then use this original_source in the
7770 target.ResolveLValue instead of the original source that was
7773 Another change. Use target.Resolve instead of LValueResolve.
7774 Although we are resolving for LValues, we will let the Assign code
7775 take care of that (it will be called again from Resolve). This
7776 basically allows code like this:
7778 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7779 class Y { void A (X x) { x [0] += o; }
7781 The problem was that the indexer was trying to resolve for
7782 set_Item (idx, object o) and never finding one. The real set_Item
7783 was set_Item (idx, X). By delaying the process we get the right
7788 2003-02-23 Martin Baulig <martin@ximian.com>
7790 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7791 while calling DoEmit ().
7793 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7794 source files; if you use the #line directive inside a method, the
7795 compiler stops emitting line numbers for the debugger until it
7796 reaches the end of the method or another #line directive which
7797 restores the original file.
7799 2003-02-23 Martin Baulig <martin@ximian.com>
7801 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7803 2003-02-23 Martin Baulig <martin@ximian.com>
7805 * statement.cs (Block.AddChildVariableNames): We need to call this
7806 recursively, not just for our immediate children.
7808 2003-02-23 Martin Baulig <martin@ximian.com>
7810 * class.cs (Event.Define): Always make the field private, like csc does.
7812 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7813 actually work, fixes bug #37521.
7815 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7817 * delegate.cs: When creating the various temporary "Parameters"
7818 classes, make sure that we call the ComputeAndDefineParameterTypes
7819 on those new parameters (just like we do with the formal ones), to
7820 allow them to be resolved in the context of the DeclSpace.
7822 This fixes the bug that Dick observed in Bugzilla #38530.
7824 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7826 * expression.cs (ResolveMemberAccess): When resolving a constant,
7827 do not attempt to pull a constant if the value was not able to
7828 generate a valid constant.
7830 * const.cs (LookupConstantValue): Do not report more errors than required.
7832 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7834 * expression.cs: fixes bug #38328.
7836 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7838 * class.cs: Changed all the various members that can be part of a
7839 class from being an ArrayList to be an Array of the right type.
7840 During the DefineType type_list, interface_list, delegate_list and
7841 enum_list are turned into types, interfaces, delegates and enums
7844 And during the member population, indexer_list, event_list,
7845 constant_list, field_list, instance_constructor_list, method_list,
7846 operator_list and property_list are turned into their real arrays.
7848 Although we could probably perform this operation earlier, for
7849 good error reporting we need to keep the lists and remove the
7850 lists for longer than required.
7852 This optimization was triggered by Paolo profiling the compiler
7853 speed on the output of `gen-sample-program.pl' perl script.
7855 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7856 not crash in methods like MemberLookupFailed that use this field.
7858 This problem arises when the compiler fails to resolve a type
7859 during interface type definition for example.
7861 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7863 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7864 inherit from System.Object, so we have to stop at null, not only
7865 when reaching System.Object.
7867 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7869 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7870 DeclaredOnly because the parent indexer might have had a different
7871 name, but did not loop until the top of the hierarchy was reached.
7873 The problem this one fixes is 35492: when a class implemented an
7874 indexer from an interface, we were getting the interface method
7875 (which was abstract) and we were flagging an error (can not invoke
7878 This also keeps bug 33089 functioning, and test-148 functioning.
7880 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7881 out if a method is special is to see if it is declared in a
7882 property or event, or whether it is one of the predefined operator
7883 names. This should fix correctly #36804.
7885 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7887 The goal here is to remove the dependency on EmptyCast.Peel ().
7888 Killing it completely.
7890 The problem is that currently in a number of places where
7891 constants are expected, we have to "probe" for an EmptyCast, and
7892 Peel, which is not the correct thing to do, as this will be
7893 repetitive and will likely lead to errors.
7895 The idea is to remove any EmptyCasts that are used in casts that
7896 can be reduced to constants, so we only have to cope with
7899 This bug hunt was triggered by Bug 37363 and the desire to remove
7900 the duplicate pattern where we were "peeling" emptycasts to check
7901 whether they were constants. Now constants will always be
7904 * ecore.cs: Use an enumconstant here instead of wrapping with
7907 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7908 throwing me off. By handling this we can get rid of a few hacks.
7910 * statement.cs (Switch): Removed Peel() code.
7912 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7914 * class.cs: Location information for error 508
7916 * expression.cs (New.DoResolve): Add a guard against double
7917 resolution of an expression.
7919 The New DoResolve might be called twice when initializing field
7920 expressions (see EmitFieldInitializers, the call to
7921 GetInitializerExpression will perform a resolve on the expression,
7922 and later the assign will trigger another resolution
7924 This leads to bugs (#37014)
7926 * delegate.cs: The signature for EndInvoke should contain any ref
7927 or out parameters as well. We were not doing this in the past.
7929 * class.cs (Field.Define): Do not overwrite the type definition
7930 inside the `volatile' group. Turns out that volatile enumerations
7931 were changing the type here to perform a validity test, which
7934 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7936 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7937 and structs, we do not want to load the instance variable
7939 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7940 enum_type has to be handled like an object reference (implicit
7941 conversions exists from this to object), but the regular IsClass
7942 and IsValueType tests will never return true for this one.
7944 Also we use TypeManager.IsValueType instead of type.IsValueType,
7945 just for consistency with the rest of the code (this is only
7946 needed if we ever use the construct exposed by test-180.cs inside
7947 corlib, which we dont today).
7949 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7951 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7954 2003-02-09 Martin Baulig <martin@ximian.com>
7956 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7957 (Namespace.DefineNamespaces): New static public method; this is
7958 called when we're compiling with debugging to add all namespaces
7961 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7962 pass it to the Namespace's .ctor.
7964 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7965 and MethodBase arguments; pass the namespace ID to the symwriter;
7966 pass the MethodBase instead of the token to the symwriter.
7967 (SymbolWriter.DefineNamespace): New method to add a namespace to
7970 2003-02-09 Martin Baulig <martin@ximian.com>
7972 * symbolwriter.cs: New file. This is a wrapper around
7973 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7974 methods here in near future.
7976 2003-02-09 Martin Baulig <martin@ximian.com>
7978 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7979 ILGenerator.MarkSequencePoint() which are actually used by the
7982 2003-02-09 Martin Baulig <martin@ximian.com>
7984 * location.cs (SourceFile): New public sealed class. This
7985 contains the name and an index which is used in the location's token.
7986 (Location): Reserve an appropriate number of bits in the token for
7987 the source file instead of walking over that list, this gives us a
7988 really huge performance improvement when compiling with debugging.
7990 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7991 `SourceFile' argument instead of a string.
7992 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7993 but don't parse/tokenize here, we need to generate the list of all
7994 source files before we do that.
7995 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7998 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7999 instead of a string.
8001 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
8004 2003-02-09 Martin Baulig <martin@ximian.com>
8006 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
8007 filename on `#line default'.
8009 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
8011 * statement.cs: don't clear the pinned var when the fixed statement
8012 returns from the method (fixes bug#37752).
8014 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
8016 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
8019 2003-02-07 Martin Baulig <martin@ximian.com>
8021 * driver.cs: Removed the `--debug-args' command line argument.
8023 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
8024 automatically by the AsssemblyBuilder.
8025 (CodeGen.InitializeSymbolWriter): We don't need to call any
8026 initialization function on the symbol writer anymore. This method
8027 doesn't take any arguments.
8029 2003-02-03 Miguel de Icaza <miguel@ximian.com>
8031 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
8032 from referenced assemblies as well.
8034 2003-02-02 Martin Baulig <martin@ximian.com>
8036 * class.cs (MethodData.Emit): Generate debugging info for external methods.
8038 2003-02-02 Martin Baulig <martin@ximian.com>
8040 * class.cs (Constructor.Emit): Open the symbol writer before
8041 emitting the constructor initializer.
8042 (ConstructorInitializer.Emit): Call ec.Mark() to allow
8043 single-stepping through constructor initializers.
8045 2003-01-30 Miguel de Icaza <miguel@ximian.com>
8047 * class.cs: Handle error 549: do not allow virtual methods in
8050 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
8052 * decl.cs: Check access levels when resolving types
8054 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
8056 * statement.cs: Add parameters and locals set in catch blocks that might
8057 return to set vector
8059 2003-01-29 Miguel de Icaza <miguel@ximian.com>
8061 * class.cs (Operator): Set the SpecialName flags for operators.
8063 * expression.cs (Invocation.DoResolve): Only block calls to
8064 accessors and operators on SpecialName methods.
8066 (Cast.TryReduce): Handle conversions from char constants.
8069 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
8071 * statement.cs: small memory and time optimization in FlowBranching.
8073 2003-01-28 Pedro Mart <yoros@wanadoo.es>
8075 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
8076 problem that the last fix but in the other sid (Set).
8078 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
8079 access when there is no indexer in the hierarchy.
8081 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
8083 * class.cs: Combine some if statements.
8085 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8087 * driver.cs: fixed bug #37187.
8089 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
8091 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
8092 any indexer, it's needed to build a list with all the indexers in the
8093 hierarchy (AllGetters), else we have problems. Fixes #35653.
8095 2003-01-23 Miguel de Icaza <miguel@ximian.com>
8097 * class.cs (MethodData.Define): It is wrong for an interface
8098 implementation to be static in both cases: explicit and implicit.
8099 We were only handling this in one case.
8101 Improve the if situation there to not have negations.
8103 * class.cs (Field.Define): Turns out that we do not need to check
8104 the unsafe bit on field definition, only on usage. Remove the test.
8106 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8108 * driver.cs: use assembly.Location instead of Codebase (the latest
8109 patch made mcs fail when using MS assemblies).
8111 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
8113 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
8114 get the path to *corlib.dll.
8116 2003-01-21 Nick Drochak <ndrochak@gol.com>
8120 * typemanager.cs: Remove compiler warnings
8122 2003-01-20 Duncan Mak <duncan@ximian.com>
8124 * AssemblyInfo.cs: Bump the version number to 0.19.
8126 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8128 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
8130 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
8132 * class.cs (Constructor::Emit): Emit debugging info for constructors.
8134 2003-01-17 Miguel de Icaza <miguel@ximian.com>
8136 * cs-parser.jay: Small fix: we were not comparing the constructor
8137 name correctly. Thanks to Zoltan for the initial pointer.
8139 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
8141 * cs-tokenizer.cs: Set file name when specified with #line
8143 2003-01-15 Miguel de Icaza <miguel@ximian.com>
8145 * cs-parser.jay: Only perform the constructor checks here if we
8146 are named like the class; This will help provider a better
8147 error. The constructor path is taken when a type definition is
8148 not found, but most likely the user forgot to add the type, so
8149 report that rather than the constructor error.
8151 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
8153 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
8156 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8158 * cs-parser.jay: Add cleanup call.
8160 2003-01-13 Duncan Mak <duncan@ximian.com>
8162 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
8163 consistent with other methods.
8165 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8167 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
8169 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
8171 * attribute.cs: only set GuidAttr to true when we have a
8174 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8178 * typemanager.cs: fixes to allow mcs compile corlib with the new
8179 Type.IsSubclassOf fix.
8181 2003-01-08 Miguel de Icaza <miguel@ximian.com>
8183 * expression.cs (LocalVariableReference.DoResolve): Classify a
8184 constant as a value, not as a variable. Also, set the type for
8187 * cs-parser.jay (fixed_statement): take a type instead of a
8188 pointer_type, so we can produce a better error message later.
8190 * statement.cs (Fixed.Resolve): Flag types that are not pointers
8193 (For.DoEmit): Make inifinite loops have a
8194 non-conditional branch back.
8196 (Fixed.DoEmit): First populate the pinned variables, then emit the
8197 statement, then clear the variables. Before I was emitting the
8198 code once for each fixed piece.
8201 2003-01-08 Martin Baulig <martin@ximian.com>
8203 * statement.cs (FlowBranching.MergeChild): A break in a
8204 SWITCH_SECTION does not leave a loop. Fixes #36155.
8206 2003-01-08 Martin Baulig <martin@ximian.com>
8208 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
8209 lives in the same number space than `param_map'. Fixes #36154.
8211 2003-01-07 Miguel de Icaza <miguel@ximian.com>
8213 * cs-parser.jay (constructor_declaration): Set the
8214 Constructor.ModFlags before probing for it. This makes the
8215 compiler report 514, 515 and 132 (the code was there, but got
8218 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
8219 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
8220 (GotoCase.Resolve): Set `Returns' to ALWAYS.
8222 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
8224 * enum.cs: create the enum static fields using the enum type.
8226 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
8228 * class.cs: don't try to create the ParamBuilder for the return
8229 type if it's not needed (and handle it breaking for the ms runtime
8232 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
8234 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
8236 2002-12-29 Miguel de Icaza <miguel@ximian.com>
8238 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
8239 the command. This showed up while compiling the JANET source
8240 code, which used \r as its only newline separator.
8242 2002-12-28 Miguel de Icaza <miguel@ximian.com>
8244 * class.cs (Method.Define): If we are an operator (because it
8245 reuses our code), then set the SpecialName and HideBySig. #36128
8247 2002-12-22 Miguel de Icaza <miguel@ximian.com>
8249 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
8250 exception, report error 120 `object reference required'.
8252 * driver.cs: Add --pause option, used during to measure the size
8253 of the process as it goes with --timestamp.
8255 * expression.cs (Invocation.DoResolve): Do not allow methods with
8256 SpecialName to be invoked.
8258 2002-12-21 Miguel de Icaza <miguel@ximian.com>
8260 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
8261 number before adding it.
8263 2002-12-21 Ravi Pratap <ravi@ximian.com>
8265 * ecore.cs (StandardImplicitConversion): When in an unsafe
8266 context, we allow conversion between void * to any other pointer
8267 type. This fixes bug #35973.
8269 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
8271 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
8272 is not thrown when extensionless outputs are used
8274 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8276 * rootcontext.cs: fixed compilation of corlib.
8278 2002-12-19 Miguel de Icaza <miguel@ximian.com>
8280 * attribute.cs (Attributes.Contains): Add new method.
8282 * class.cs (MethodCore.LabelParameters): if the parameter is an
8283 `out' parameter, check that no attribute `[In]' has been passed.
8285 * enum.cs: Handle the `value__' name in an enumeration.
8287 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
8289 * decl.cs: Added special case to allow overrides on "protected
8292 2002-12-18 Ravi Pratap <ravi@ximian.com>
8294 * attribute.cs (Attributes.AddAttributeSection): Rename to this
8295 since it makes much more sense.
8297 (Attributes.ctor): Don't require a Location parameter.
8299 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
8301 * attribute.cs (ApplyAttributes): Remove extra Location parameters
8302 since we already have that information per attribute.
8304 * everywhere : make appropriate changes.
8306 * class.cs (LabelParameters): Write the code which actually
8307 applies attributes to the return type. We can't do this on the MS
8308 .NET runtime so we flag a warning in the case an exception is
8311 2002-12-18 Miguel de Icaza <miguel@ximian.com>
8313 * const.cs: Handle implicit null conversions here too.
8315 2002-12-17 Ravi Pratap <ravi@ximian.com>
8317 * class.cs (MethodCore.LabelParameters): Remove the extra
8318 Type [] parameter since it is completely unnecessary. Instead
8319 pass in the method's attributes so that we can extract
8320 the "return" attribute.
8322 2002-12-17 Miguel de Icaza <miguel@ximian.com>
8324 * cs-parser.jay (parse): Use Report.Error to flag errors instead
8325 of ignoring it and letting the compile continue.
8327 * typemanager.cs (ChangeType): use an extra argument to return an
8328 error condition instead of throwing an exception.
8330 2002-12-15 Miguel de Icaza <miguel@ximian.com>
8332 * expression.cs (Unary.TryReduce): mimic the code for the regular
8333 code path. Perform an implicit cast in the cases where we can
8334 implicitly convert to one of the integral types, and then reduce
8335 based on that constant. This fixes bug #35483.
8337 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8339 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
8341 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8343 * namespace.cs: fixed bug #35489.
8345 2002-12-12 Miguel de Icaza <miguel@ximian.com>
8347 * class.cs: Remove some dead code.
8349 * cs-parser.jay: Estimate the number of methods needed
8350 (RootContext.MethodCount);
8352 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
8353 numbers instead of StringBuilders.
8355 * support.cs (PtrHashtable): Add constructor with initial size;
8356 We can now reduce reallocations of the method table.
8358 2002-12-10 Ravi Pratap <ravi@ximian.com>
8360 * attribute.cs (ApplyAttributes): Keep track of the emitted
8361 attributes on a per-target basis. This fixes bug #35413.
8363 2002-12-10 Miguel de Icaza <miguel@ximian.com>
8365 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
8366 default to the Windows 1252 encoding.
8368 (UnixParseOption): Support version, thanks to Alp for the missing
8371 * AssemblyInfo.cs: Add nice assembly information.
8373 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
8376 * cs-parser.jay: Allow a trailing comma before the close bracked
8377 in the attribute_section production.
8379 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
8380 address of the instance was being taken, I will take this out,
8381 because we take the address of the object immediately here.
8383 2002-12-09 Ravi Pratap <ravi@ximian.com>
8385 * typemanager.cs (AreMultipleAllowed): Take care of the most
8386 obvious case where attribute type is not in the current assembly -
8389 2002-12-08 Miguel de Icaza <miguel@ximian.com>
8391 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
8392 definitions, instead of doing that afterwards.
8394 Also we use a nice little hack, depending on the constructor, we
8395 know if we are a "composed" name or a simple name. Hence, we
8396 avoid the IndexOf test, and we avoid
8398 * codegen.cs: Add code to assist in a bug reporter to track down
8399 the source of a compiler crash.
8401 2002-12-07 Ravi Pratap <ravi@ximian.com>
8403 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
8404 types have been emitted for a given element and flag an error
8405 if something which does not have AllowMultiple set is used more
8408 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
8409 attribute types and their corresponding AllowMultiple properties
8411 (AreMultipleAllowed): Check the property for a given type.
8413 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
8414 property in the case we have a TypeContainer.
8416 (Attributes.AddAttribute): Detect duplicates and just skip on
8417 adding them. This trivial fix catches a pretty gross error in our
8418 attribute emission - global attributes were being emitted twice!
8420 Bugzilla bug #33187 is now fixed.
8422 2002-12-06 Miguel de Icaza <miguel@ximian.com>
8424 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
8427 * expression.cs (Binary.ResolveOperator): I can only use the
8428 Concat (string, string, string) and Concat (string, string,
8429 string, string) if the child is actually a concatenation of
8432 2002-12-04 Miguel de Icaza <miguel@ximian.com>
8434 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
8435 context where we need a 2-character lookahead.
8437 * pending.cs (PendingImplementation): Rework so we can keep track
8438 of interface types all the time, and flag those which were
8439 implemented by parents as optional.
8441 2002-12-03 Miguel de Icaza <miguel@ximian.com>
8443 * expression.cs (Binary.ResolveOperator): Use
8444 String.Concat(string,string,string) or
8445 String.Concat(string,string,string,string) when possible.
8447 * typemanager: More helper methods.
8450 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
8452 * pending.cs: remove the bogus return from GetMissingInterfaces()
8453 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
8455 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8457 * namespace.cs: avoid duplicated 'using xxx' being added to
8458 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
8459 when we get more than one 'using' statement for the same namespace.
8460 Report a CS0105 warning for it.
8462 2002-11-30 Miguel de Icaza <miguel@ximian.com>
8464 * cs-tokenizer.cs (consume_identifier): use read directly, instead
8465 of calling getChar/putback, uses internal knowledge of it.
8467 (xtoken): Reorder tokenizer so most common patterns are checked
8468 first. This reduces the compilation time in another 5% (from 8.11s
8469 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
8471 The parsing time is 22% of the compilation in mcs, and from that
8472 64% is spent on the tokenization process.
8474 I tried using a binary search for keywords, but this is slower
8475 than the hashtable. Another option would be to do a couple of
8478 * Not use a StringBuilder, instead use an array of chars,
8479 with a set value. Notice that this way we could catch
8480 the 645 error without having to do it *afterwards*.
8482 * We could write a hand-parser to avoid the hashtable
8483 compares altogether.
8485 The identifier consumption process takes 37% of the tokenization
8486 time. Another 15% is spent on is_number. 56% of the time spent
8487 on is_number is spent on Int64.Parse:
8489 * We could probably choose based on the string length to
8490 use Int32.Parse or Int64.Parse and avoid all the 64-bit
8493 Another 3% is spend on wrapping `xtoken' in the `token' function.
8495 Handle 0xa0 as whitespace (#34752)
8497 2002-11-26 Miguel de Icaza <miguel@ximian.com>
8499 * typemanager.cs (IsCLRType): New routine to tell whether a type
8500 is one of the builtin types.
8502 Maybe it needs to use TypeCodes to be faster. Maybe we could use
8503 typecode in more places instead of doing pointer comparissions.
8504 We could leverage some knowledge about the way the typecodes are
8507 New code to cache namespaces in assemblies, it is currently not
8508 invoked, to be used soon.
8510 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
8512 * expression.cs (Binary.ResolveOperator): specially handle
8513 strings, and do not perform user-defined operator overloading for
8516 2002-11-24 Miguel de Icaza <miguel@ximian.com>
8518 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
8519 internalcall as it is a pretty simple operation; Avoid whenever
8520 possible to call Char.IsLetter.
8522 (consume_identifier): Cut by half the number of
8523 hashtable calls by merging the is_keyword and GetKeyword behavior.
8525 Do not short-circuit, because if we do, we
8526 report errors (ie, #if false && true would produce an invalid
8530 2002-11-24 Martin Baulig <martin@ximian.com>
8532 * expression.cs (Cast.TryReduce): If we're in checked syntax,
8533 check constant ranges and report a CS0221. Fixes #33186.
8535 2002-11-24 Martin Baulig <martin@ximian.com>
8537 * cs-parser.jay: Make this work for uninitialized variable
8538 declarations in the `for' initializer. Fixes #32416.
8540 2002-11-24 Martin Baulig <martin@ximian.com>
8542 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
8543 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
8545 2002-11-24 Martin Baulig <martin@ximian.com>
8547 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
8548 argument; if true, we also check for user-defined conversions.
8549 This is only needed if both arguments are of a user-defined type.
8550 Fixes #30443, added test-175.cs.
8551 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
8553 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
8555 2002-11-24 Martin Baulig <martin@ximian.com>
8557 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8558 function to get the store opcode.
8559 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8560 only emit the Ldelema if the store opcode is Stobj. You must run
8561 both test-34 and test-167 to test this. Fixes #34529.
8563 2002-11-23 Martin Baulig <martin@ximian.com>
8565 * ecore.cs (Expression.MemberLookup): Added additional
8566 `qualifier_type' argument which is used when we're being called
8567 from MemberAccess.DoResolve() and null if we're called from a
8569 (Expression.MemberLookupFailed): New method to report errors; this
8570 does the CS1540 check and reports the correct error message.
8572 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8573 argument for the CS1540 check and redone the way how we're dealing
8574 with private members. See the comment in the source code for details.
8575 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8576 `closure_start_type' to `closure_qualifier_type' and check whether
8577 it's not null. It was not this filter being broken, it was just
8578 being called with the wrong arguments.
8580 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8581 and pass it the correct `qualifier_type'; this also does the error
8584 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8586 * expression.cs (Invocation.EmitParams): If the we are dealing
8587 with a non-built-in value type, load its address as well.
8589 (ArrayCreation): Use a a pretty constant instead
8590 of the hardcoded value 2. Use 6 instead of 2 for the number of
8591 static initializers.
8593 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8594 because they are not really value types, just glorified integers.
8596 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8598 * ecore.cs: Remove redundant code for enumerations, make them use
8599 the same code path as everything else, fixes the casting issue
8600 with enumerations in Windows.Forms.
8602 * attribute.cs: Do only cast to string if it is a string, the
8603 validation happens later.
8605 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8606 people upgrade their corlibs.
8608 * ecore.cs: Oops, enumerations were not following the entire code path
8610 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8612 * typemanager.cs (FilterWithClosure): Commented out the test for
8613 1540 in typemanager.cs, as it has problems when accessing
8614 protected methods from a parent class (see test-174.cs).
8616 * attribute.cs (Attribute.ValidateGuid): new method.
8617 (Attribute.Resolve): Use above.
8619 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8621 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8623 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8624 handling for enumerations, as we only needed the TypeContainer
8625 functionality to begin with (this is required for the fix below to
8626 work for enums that reference constants in a container class for
8629 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8631 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8632 a valid TypeBuilder to perform lookups on.o
8634 * class.cs (InheritableMemberSignatureCompare): Use true in the
8635 call to GetGetMethod and GetSetMethod, because we are comparing
8636 the signature, and we need to get the methods *even* if they are
8639 (PropertyBase.CheckBase): ditto.
8641 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8642 GotoCase.Resolve): Use Peel on EmpytCasts.
8644 * ecore.cs (EmptyCast): drop child, add Peel method.
8646 2002-11-17 Martin Baulig <martin@ximian.com>
8648 * ecore.cs (EmptyCast.Child): New public property.
8650 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8651 label resolved to an EmptyCast. Fixes #34162.
8652 (GotoCase.Resolve): Likewise.
8653 (Block.EmitMeta): Likewise.
8655 2002-11-17 Martin Baulig <martin@ximian.com>
8657 * expression.cs (Invocation.BetterConversion): Prefer int over
8658 uint; short over ushort; long over ulong for integer literals.
8659 Use ImplicitConversionExists instead of StandardConversionExists
8660 since we also need to check for user-defined implicit conversions.
8661 Fixes #34165. Added test-173.cs.
8663 2002-11-16 Martin Baulig <martin@ximian.com>
8665 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8666 with the `true' and `false' literals. Fixes #33151.
8668 2002-11-16 Martin Baulig <martin@ximian.com>
8670 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8671 October 22nd; don't do the cs1540 check for static members.
8673 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8674 now using our own filter here and doing the cs1540 check again.
8676 2002-11-16 Martin Baulig <martin@ximian.com>
8678 * support.cs (InternalParameters): Don't crash if we don't have
8679 any fixed parameters. Fixes #33532.
8681 2002-11-16 Martin Baulig <martin@ximian.com>
8683 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8684 when looking up static methods to make this work on Windows.
8687 2002-11-16 Martin Baulig <martin@ximian.com>
8689 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8690 a setter rather than using PropertyInfo.CanWrite.
8692 2002-11-15 Nick Drochak <ndrochak@gol.com>
8694 * class.cs: Allow acces to block member by subclasses. Fixes build
8697 2002-11-14 Martin Baulig <martin@ximian.com>
8699 * class.cs (Constructor.Emit): Added the extern/block check.
8702 2002-11-14 Martin Baulig <martin@ximian.com>
8704 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8705 iteration while looking for indexers, this is needed because the
8706 indexer may have a different name in our base classes. Fixed the
8707 error reporting (no indexers at all, not get accessor, no
8708 overloaded match). Fixes bug #33089.
8709 (IndexerAccess.DoResolveLValue): Likewise.
8711 2002-11-14 Martin Baulig <martin@ximian.com>
8713 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8714 indexers. Fixes the first part of bug #33089.
8715 (MethodSignature.InheritableMemberSignatureCompare): Added support
8718 2002-11-13 Ravi Pratap <ravi@ximian.com>
8720 * attribute.cs (Attribute.Resolve): Catch the
8721 NullReferenceException and report it since it isn't supposed to
8724 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8726 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8727 LogicalOr and LogicalAnd that can benefit from recursively
8728 handling EmitBranchable. The code now should be nice for Paolo.
8730 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8732 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8733 the Type lookups, as we perform quite a number of lookups on
8734 non-Types. This can be removed once we can deterministically tell
8735 whether we have a type or a namespace in advance.
8737 But this might require special hacks from our corlib.
8741 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8742 and double which avoids a conversion from an integer to a double.
8744 * expression.cs: tiny optimization, avoid calling IsConstant,
8745 because it effectively performs the lookup twice.
8747 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8749 But a bogus return here to keep the semantics of the old code
8750 until the Mono runtime is fixed.
8752 * pending.cs (GetMissingInterfaces): New method used to remove all
8753 the interfaces that are already implemented by our parent
8754 classes from the list of pending methods.
8756 * interface.cs: Add checks for calls after ResolveTypeExpr.
8758 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8760 * class.cs (Class.Emit): Report warning 67: event not used if the
8761 warning level is beyond 3.
8763 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8764 being a NullLiteral.
8766 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8769 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8770 path that might fail if a type can not be resolved.
8772 * expression.cs (Binary.Emit): Emit unsigned versions of the
8775 * driver.cs: use error 5.
8777 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8779 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8781 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8783 * cs-parser.jay (switch_section): A beautiful patch from Martin
8784 Baulig that fixed 33094.
8786 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8788 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8789 Check whether the base is abstract and report an error if so.
8791 * expression.cs (IndexerAccess.DoResolveLValue,
8792 IndexerAccess.DoResolve): ditto.
8794 (Invocation.DoResolve): ditto.
8796 (Invocation.FullMethodDesc): Improve the report string.
8798 * statement.cs (Block): Eliminate IsVariableDefined as it is
8799 basically just a wrapper for GetVariableInfo.
8801 * ecore.cs (SimpleName): Use new
8803 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8804 type, as we return the actual parameter ref/unref state on a
8807 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8809 * support.cs: Return proper flags REF/OUT fixing the previous
8812 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8813 not used to mean `ref' but `ref or out' in ParameterReference
8815 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8816 full type signature instead of calling TypeManger.CSharpName
8819 * support.cs (InternalParameters.ParameterDesc): Do not compare
8820 directly to the modflags, because REF/OUT will actually be bitsets
8823 * delegate.cs (VerifyMethod): Check also the modifiers.
8825 * cs-tokenizer.cs: Fix bug where floating point values with an
8826 exponent where a sign was missing was ignored.
8828 * driver.cs: Allow multiple assemblies to be specified in a single
8831 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8833 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8834 because identifiers after a parenthesis would end up in this kind
8835 of production, and we needed to desamiguate it for having casts
8838 (UserDefinedType *) xxx
8840 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8842 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8843 we should set on the Bindingflags.NonPublic, but not turn on
8844 private_ok. private_ok controls whether a Private member is
8845 returned (this is chekced on the filter routine), while the
8846 BindingFlags.NonPublic just controls whether private/protected
8847 will be allowed. This fixes the problem part of the problem of
8848 private properties being allowed to be used in derived classes.
8850 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8851 so we can call the children DoResolveLValue method (this will
8852 properly signal errors on lvalue assignments to base properties)
8854 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8855 getter are null, and we have a property info, we know that this
8856 happened because the lookup failed, so we report an error 122 for
8857 protection level violation.
8859 We also silently return if setter and getter are null in the
8860 resolve functions, this condition only happens if we have flagged
8861 the error before. This is the other half of the problem.
8863 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8864 not have accessibility information, that is why we were returning
8865 true in the filter function in typemanager.cs.
8867 To properly report 122 (property is inaccessible because of its
8868 protection level) correctly, we report this error in ResolveAccess
8869 by failing if both the setter and the getter are lacking (ie, the
8872 DoResolve and DoLResolve have been modified to check for both
8873 setter/getter being null and returning silently, the reason being
8874 that I did not want to put the knowledge about this error in upper
8877 int old = Report.Errors;
8878 x = new PropertyExpr (...);
8879 if (old != Report.Errors)
8884 So the property expr is returned, but it is invalid, so the error
8885 will be flagged during the resolve process.
8887 * class.cs: Remove InheritablePropertySignatureCompare from the
8888 class, as we no longer depend on the property signature to compute
8889 whether it is possible to implement a method or not.
8891 The reason is that calling PropertyInfo.GetGetMethod will return
8892 null (in .NET, in Mono it works, and we should change this), in
8893 cases where the Get Method does not exist in that particular
8898 class X { public virtual int A { get { return 1; } } }
8900 class Z : Y { public override int A { get { return 2; } } }
8902 Would fail in Z because the parent (Y) would not have the property
8903 defined. So we avoid this completely now (because the alternative
8904 fix was ugly and slow), and we now depend exclusively on the
8907 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8908 reference method, instead of using the property.
8910 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8911 routines are gone now.
8913 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8914 names, they were incorrectly named.
8916 * cs-tokenizer.cs: Return are more gentle token on failure.
8918 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8919 had an out-of-sync index variable, which caused it to remove from
8920 the list of pending methods the wrong method sometimes.
8922 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8924 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8925 CanWrite, because those refer to this particular instance of the
8926 property, and do not take into account the fact that we can
8927 override single members of a property.
8929 Constructor requires an EmitContext. The resolution process does
8930 not happen here, but we need to compute the accessors before,
8931 because the resolution does not always happen for properties.
8933 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8934 subclass, before we did not update this flag, but we did update
8937 (GetAccessors): Drop this routine, as it did not work in the
8938 presence of partially overwritten set/get methods.
8940 Notice that this broke the cs1540 detection, but that will require
8943 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8947 * driver.cs: issue a warning instead of an error if we don't support
8948 debugging for the platform. Also ignore a couple of errors that may
8949 arise when trying to write the symbols. Undo my previous patch.
8951 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8953 * driver.cs: ignore /debug switch except for Unix platforms.
8955 2002-10-23 Nick Drochak <ndrochak@gol.com>
8957 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8959 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8961 * driver.cs: Do not make mcs-debug conditional, so we do not break
8964 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8965 review this patch. But basically after all the children variables
8966 have been merged, the value of "Breaks" was not being set to
8967 new_breaks for Switch blocks. I think that it should be set after
8968 it has executed. Currently I set this to the value of new_breaks,
8969 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8970 conservative, but I do not understand this code very well.
8972 I did not break anything in the build, so that is good ;-)
8974 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8976 2002-10-20 Mark Crichton <crichton@gimp.org>
8978 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8980 2002-10-20 Nick Drochak <ndrochak@gol.com>
8982 * cfold.cs: Fixed compile blocker.
8984 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8986 * driver.cs: I was chekcing the key, not the file.
8988 2002-10-19 Ravi Pratap <ravi@ximian.com>
8990 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8991 message that we were generating - we just need to silently return
8994 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8996 * class.cs (Event.Define): Change my previous commit, as this
8997 breaks the debugger. This is a temporary hack, as it seems like
8998 the compiler is generating events incorrectly to begin with.
9000 * expression.cs (Binary.ResolveOperator): Added support for
9001 "U operator - (E x, E y)"
9003 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
9006 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
9007 init-only variables, but this path did not take into account that
9008 there might be also instance readonly variables. Correct this
9011 This fixes bug 32253
9013 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
9016 * driver.cs: Change the extension for modules to `netmodule'
9018 * cs-parser.jay: Improved slightly the location tracking for
9019 the debugger symbols.
9021 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
9022 modifiers that were specified instead of the hardcoded value
9023 (FamAndAssem). This was basically ignoring the static modifier,
9024 and others. Fixes 32429.
9026 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
9027 fixed a bug in the process (32476)
9029 * expression.cs (ArrayAccess.EmitAssign): Patch from
9030 hwang_rob@yahoo.ca that fixes bug 31834.3
9032 2002-10-18 Miguel de Icaza <miguel@ximian.com>
9034 * driver.cs: Make the module extension .netmodule.
9036 2002-10-16 Miguel de Icaza <miguel@ximian.com>
9038 * driver.cs: Report an error if the resource file is not found
9039 instead of crashing.
9041 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
9042 false, like Emit does.
9044 2002-10-16 Nick Drochak <ndrochak@gol.com>
9046 * typemanager.cs: Remove unused private member. Also reported mcs
9047 bug to report this as a warning like csc.
9049 2002-10-15 Martin Baulig <martin@gnome.org>
9051 * statement.cs (Statement.Emit): Made this a virtual method; emits
9052 the line number info and calls DoEmit().
9053 (Statement.DoEmit): New protected abstract method, formerly knows
9054 as Statement.Emit().
9056 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
9058 2002-10-11 Miguel de Icaza <miguel@ximian.com>
9060 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
9061 have fixed a remaining problem: not every AddXXXX was adding a
9062 fully qualified name.
9064 Now everyone registers a fully qualified name in the DeclSpace as
9065 being defined instead of the partial name.
9067 Downsides: we are slower than we need to be due to the excess
9068 copies and the names being registered this way.
9070 The reason for this is that we currently depend (on the corlib
9071 bootstrap for instance) that types are fully qualified, because
9072 we dump all the types in the namespace, and we should really have
9073 types inserted into the proper namespace, so we can only store the
9074 basenames in the defined_names array.
9076 2002-10-10 Martin Baulig <martin@gnome.org>
9078 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
9079 from bug #31834, see the bug report for a testcase which is
9082 2002-10-10 Martin Baulig <martin@gnome.org>
9084 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
9085 flow analysis code for this.
9087 * statement.cs (Do, While, For): Tell the flow analysis code about
9089 (FlowBranching.UsageVector): Added support for infinite loops.
9090 (Block.Resolve): Moved the dead code elimination here and use flow
9093 2002-10-09 Miguel de Icaza <miguel@ximian.com>
9095 * class.cs (Field.Define): Catch cycles on struct type
9098 * typemanager.cs (IsUnmanagedtype): Do not recursively check
9099 fields if the fields are static. We only need to check instance
9102 * expression.cs (As.DoResolve): Test for reference type.
9104 * statement.cs (Using.ResolveExpression): Use
9105 ConvertImplicitRequired, not ConvertImplicit which reports an
9107 (Using.ResolveLocalVariableDecls): ditto.
9109 * expression.cs (Binary.ResolveOperator): Report errors in a few
9110 places where we had to.
9112 * typemanager.cs (IsUnmanagedtype): Finish implementation.
9114 2002-10-08 Miguel de Icaza <miguel@ximian.com>
9116 * expression.cs: Use StoreFromPtr instead of extracting the type
9117 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
9119 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
9120 an enumeration value to a System.Enum, but System.Enum is not a
9121 value type, but an class type, so we need to box.
9123 (Expression.ConvertExplicit): One codepath could return
9124 errors but not flag them. Fix this. Fixes #31853
9126 * parameter.cs (Resolve): Do not allow void as a parameter type.
9128 2002-10-06 Martin Baulig <martin@gnome.org>
9130 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
9131 if it's a class type and not a struct. Fixes #31815.
9133 2002-10-06 Martin Baulig <martin@gnome.org>
9135 * statement.cs: Reworked the flow analysis code a bit to make it
9136 usable for dead code elimination.
9138 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9140 * cs-parser.jay: allow empty source files. Fixes bug #31781.
9142 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9144 * expression.cs (ComposedCast.DoResolveType): A quick workaround
9145 to fix the test 165, will investigate deeper.
9147 2002-10-04 Martin Baulig <martin@gnome.org>
9149 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
9150 finally blocks actually work.
9151 (Try.Resolve): We don't need to create a sibling for `finally' if
9152 there is no finally block.
9154 2002-10-04 Martin Baulig <martin@gnome.org>
9156 * class.cs (Constructor.Define): The default accessibility for a
9157 non-default constructor is private, not public.
9159 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9161 * class.cs (Constructor): Make AllowedModifiers public, add
9164 * cs-parser.jay: Perform the modifiers test here, as the
9165 constructor for the Constructor class usually receives a zero
9166 because of the way we create it (first we create, later we
9167 customize, and we were never checking the modifiers).
9169 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
9170 is a version of LookupTypeReflection that includes the type-name
9171 cache. This can be used as a fast path for functions that know
9172 the fully qualified name and are only calling into *.GetType() to
9173 obtain a composed type.
9175 This is also used by TypeManager.LookupType during its type
9178 (LookupType): We now also track the real type name, as sometimes
9179 we can get a quey for the real type name from things like
9180 ComposedCast. This fixes bug 31422.
9182 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
9183 complete type fullname, it does not have to go through the type
9184 resolution system to obtain the composed version of the type (for
9185 obtaining arrays or pointers).
9187 (Conditional.Emit): Use the EmitBoolExpression to
9188 generate nicer code, as requested by Paolo.
9190 (ArrayCreation.CheckIndices): Use the patch from
9191 hwang_rob@yahoo.ca to validate the array initializers.
9193 2002-10-03 Miguel de Icaza <miguel@ximian.com>
9195 * class.cs (ConstructorInitializer.Emit): simplify code by using
9196 Invocation.EmitCall, and at the same time, fix the bugs in calling
9197 parent constructors that took variable arguments.
9199 * ecore.cs (Expression.ConvertNumericExplicit,
9200 Expression.ImplicitNumericConversion): Remove the code that
9201 manually wrapped decimal (InternalTypeConstructor call is now gone
9204 * expression.cs (Cast.TryReduce): Also handle decimal types when
9205 trying to perform a constant fold on the type.
9207 * typemanager.cs (IsUnmanagedtype): Partially implemented.
9209 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
9210 that only turned off an error report, and did nothing else.
9212 2002-10-02 Miguel de Icaza <miguel@ximian.com>
9214 * driver.cs: Handle and ignore /fullpaths
9216 2002-10-01 Miguel de Icaza <miguel@ximian.com>
9218 * expression.cs (Binary.ResolveOperator): Catch the case where
9219 DoNumericPromotions returns true,
9221 (Binary.DoNumericPromotions): Simplify the code, and the tests.
9223 2002-09-27 Miguel de Icaza <miguel@ximian.com>
9225 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
9228 2002-09-26 Miguel de Icaza <miguel@ximian.com>
9230 * ecore.cs (ConvertNumericExplicit): It is not enough that the
9231 conversion exists, but it is also required that the conversion be
9232 performed. This manifested in "(Type64Enum) 2".
9234 * class.cs (TypeManager.AddMethod): The fix is not to change
9235 AddEnum, because that one was using a fully qualified name (every
9236 DeclSpace derivative does), but to change the AddMethod routine
9237 that was using an un-namespaced name. This now correctly reports
9238 the duplicated name.
9240 Revert patch until I can properly fix it. The issue
9241 is that we have a shared Type space across all namespaces
9242 currently, which is wrong.
9244 Options include making the Namespace a DeclSpace, and merge
9245 current_namespace/current_container in the parser.
9247 2002-09-25 Miguel de Icaza <miguel@ximian.com>
9249 * cs-parser.jay: Improve error reporting when we get a different
9250 kind of expression in local_variable_type and
9251 local_variable_pointer_type.
9253 Propagate this to avoid missleading errors being reported.
9255 * ecore.cs (ImplicitReferenceConversion): treat
9256 TypeManager.value_type as a target just like object_type. As
9261 Is valid, and needs to result in the int 1 being boxed before it
9262 is assigned to the value type v.
9264 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
9265 to validate the enumeration name.
9267 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
9268 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
9269 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
9271 * ecore.cs (TryImplicitIntConversion): When doing an
9272 implicit-enumeration-conversion, check if the type is 64-bits and
9273 perform a conversion before passing to EnumConstant.
9275 2002-09-23 Miguel de Icaza <miguel@ximian.com>
9277 * decl.cs (Error_AmbiguousTypeReference); New routine used to
9278 report ambiguous type references. Unlike the MS version, we
9279 report what the ambiguity is. Innovation at work ;-)
9281 (DeclSpace.FindType): Require a location argument to
9282 display when we display an ambiguous error.
9284 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
9286 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
9288 * expression.cs (EmitDynamicInitializers): Apply patch from
9289 hwang_rob@yahoo.ca that fixes the order in which we emit our
9292 2002-09-21 Martin Baulig <martin@gnome.org>
9294 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
9295 delegate takes no arguments.
9297 2002-09-20 Miguel de Icaza <miguel@ximian.com>
9299 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
9302 * expression.cs: Extract the underlying type.
9304 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
9306 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
9308 2002-09-19 Miguel de Icaza <miguel@ximian.com>
9310 * class.cs (TypeContainer.DefineType): We can not use the nice
9311 PackingSize with the size set to 1 DefineType method, because it
9312 will not allow us to define the interfaces that the struct
9315 This completes the fixing of bug 27287
9317 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
9318 means also structs. This fixes part of the problem.
9319 (Expresion.ImplicitReferenceConversionExists): ditto.
9321 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
9322 error if there were no errors reported during the type lookup
9323 process, to avoid duplicates or redundant errors. Without this
9324 you would get an ambiguous errors plus a type not found. We have
9325 beaten the user enough with the first error.
9327 (DeclSparce.FindType): Emit a warning if we have an ambiguous
9330 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
9331 during the resolution process, stop the lookup, this avoids
9332 repeated error reports (same error twice).
9334 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
9336 * typemanager.cs (LookupType): Redo the type lookup code to match
9337 the needs of System.Reflection.
9339 The issue is that System.Reflection requires references to nested
9340 types to begin with a "+" sign instead of a dot. So toplevel
9341 types look like: "NameSpace.TopLevelClass", and nested ones look
9342 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
9345 2002-09-19 Martin Baulig <martin@gnome.org>
9347 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
9348 says that a method always returns or always throws an exception,
9349 don't report the CS0161.
9351 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
9352 set `Returns = new_returns'.
9354 2002-09-19 Martin Baulig <martin@gnome.org>
9356 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
9357 to an enum constant, check for a CS0176.
9359 2002-09-18 Miguel de Icaza <miguel@ximian.com>
9361 * class.cs (TypeContainer.CheckPairedOperators): Now we check
9362 for operators that must be in pairs and report errors.
9364 * ecore.cs (SimpleName.DoResolveType): During the initial type
9365 resolution process, when we define types recursively, we must
9366 check first for types in our current scope before we perform
9367 lookups in the enclosing scopes.
9369 * expression.cs (MakeByteBlob): Handle Decimal blobs.
9371 (Invocation.VerifyArgumentsCompat): Call
9372 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
9373 I thought we were supposed to always call this, but there are a
9374 few places in the code where we dont do it.
9376 2002-09-17 Miguel de Icaza <miguel@ximian.com>
9378 * driver.cs: Add support in -linkres and -resource to specify the
9379 name of the identifier.
9381 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9383 * ecore.cs (StandardConversionExists): Sync with the conversion
9384 code: allow anything-* to void* conversions.
9386 (FindMostSpecificSource): Use an Expression argument
9387 instead of a Type, because we might be handed over a Literal which
9388 gets a few more implicit conversions that plain types do not. So
9389 this information was being lost.
9391 Also, we drop the temporary type-holder expression when not
9394 2002-09-17 Martin Baulig <martin@gnome.org>
9396 * class.cs (PropertyBase.CheckBase): Don't check the base class if
9397 this is an explicit interface implementation.
9399 2002-09-17 Martin Baulig <martin@gnome.org>
9401 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
9402 different `IndexerName' attributes.
9404 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
9405 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
9406 virtual CommonResolve().
9408 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9410 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
9411 and convert that to the UnderlyingType.
9413 * statement.cs (Foreach.Resolve): Indexers are just like variables
9414 or PropertyAccesses.
9416 * cs-tokenizer.cs (consume_string): Track line numbers and columns
9417 inside quoted strings, we were not doing this before.
9419 2002-09-16 Martin Baulig <martin@gnome.org>
9421 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
9422 resolve it. This is needed for the definite assignment check of the
9423 instance expression, fixes bug #29846.
9424 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
9426 2002-09-16 Nick Drochak <ndrochak@gol.com>
9428 * parameter.cs: Fix compile error. Cannot reference static member
9429 from an instance object. Is this an mcs bug?
9431 2002-09-14 Martin Baulig <martin@gnome.org>
9433 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
9434 multiple times. Fixes bug #30295, added test-166.cs.
9436 2002-09-14 Martin Baulig <martin@gnome.org>
9438 * statement.cs (Block.Emit): Don't emit unreachable code.
9439 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
9441 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
9443 2002-09-14 Martin Baulig <martin@gnome.org>
9445 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
9448 2002-09-14 Martin Baulig <martin@gnome.org>
9450 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
9451 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
9452 be false on the ms runtime.
9454 2002-09-13 Martin Baulig <martin@gnome.org>
9456 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
9457 the CS0038 error message.
9459 2002-09-12 Miguel de Icaza <miguel@ximian.com>
9461 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
9462 constant inside, return it.
9464 2002-09-12 Martin Baulig <martin@gnome.org>
9466 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
9467 implicit conversion can be done between enum types.
9469 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
9470 check whether an implicit conversion to the current enum's UnderlyingType
9471 exists and report an error if not.
9473 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
9474 without debugging support.
9476 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
9477 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
9479 2002-09-12 Martin Baulig <martin@gnome.org>
9481 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
9483 * ecore.cs (IMemberExpr.DeclaringType): New property.
9484 (SimpleName.SimpleNameResolve): Check whether we're accessing a
9485 nonstatic member of an outer type (CS0038).
9487 2002-09-11 Miguel de Icaza <miguel@ximian.com>
9489 * driver.cs: Activate the using-error detector at warning level
9490 4 (at least for MS-compatible APIs).
9492 * namespace.cs (VerifyUsing): Small buglett fix.
9494 * pending.cs (PendingImplementation): pass the container pointer.
9496 * interface.cs (GetMethods): Allow for recursive definition. Long
9497 term, I would like to move every type to support recursive
9498 definitions, not the current ordering mechanism that we have right
9501 The situation is this: Attributes are handled before interfaces,
9502 so we can apply attributes to interfaces. But some attributes
9503 implement interfaces, we will now handle the simple cases
9504 (recursive definitions will just get an error).
9506 * parameter.cs: Only invalidate types at the end if we fail to
9509 2002-09-09 Martin Baulig <martin@gnome.org>
9511 * ecore.cs (PropertyExpr.Emit): Also check for
9512 TypeManager.system_int_array_get_length so this'll also work when
9513 compiling corlib. Fixes #30003.
9515 2002-09-09 Martin Baulig <martin@gnome.org>
9517 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
9518 and throw an exception if we can't get the type's size. Fixed #30040,
9521 2002-09-09 Martin Baulig <martin@gnome.org>
9523 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
9525 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
9526 context. Fixes bug #30027.
9528 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
9529 virtual functions. Fixes bug #30043, added test-164.cs.
9531 2002-09-08 Ravi Pratap <ravi@ximian.com>
9533 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
9535 2002-09-08 Nick Drochak <ndrochak@gol.com>
9537 * driver.cs: Use an object to get the windows codepage since it's not a
9540 2002-09-08 Miguel de Icaza <miguel@ximian.com>
9542 * statement.cs (For.Emit): for infinite loops (test == null)
9543 return whether there is a break inside, not always "true".
9545 * namespace.cs (UsingEntry): New struct to hold the name of the
9546 using definition, the location where it is defined, and whether it
9547 has been used in a successful type lookup.
9549 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
9554 2002-09-06 Ravi Pratap <ravi@ximian.com>
9556 * attribute.cs : Fix incorrect code which relied on catching
9557 a NullReferenceException to detect a null being passed in
9558 where an object was expected.
9560 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9562 * statement.cs (Try): flag the catch variable as assigned
9564 * expression.cs (Cast): Simplified by using ResolveType instead of
9567 * statement.cs (Catch): Fix bug by using ResolveType.
9569 2002-09-06 Ravi Pratap <ravi@ximian.com>
9571 * expression.cs (BetterConversion): Special case for when we have
9572 a NullLiteral as the argument and we have to choose between string
9573 and object types - we choose string the way csc does.
9575 * attribute.cs (Attribute.Resolve): Catch the
9576 NullReferenceException and report error #182 since the Mono
9577 runtime no more has the bug and having this exception raised means
9578 we tried to select a constructor which takes an object and is
9581 2002-09-05 Ravi Pratap <ravi@ximian.com>
9583 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9584 message (1502, 1503) when we can't locate a method after overload
9585 resolution. This is much more informative and closes the bug
9588 * interface.cs (PopulateMethod): Return if there are no argument
9589 types. Fixes a NullReferenceException bug.
9591 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9592 expressions too. Previously we were checking only in one place for
9593 positional arguments leaving out named arguments.
9595 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9596 type to the enum type is not allowed. Remove code corresponding to
9599 (ConvertNumericExplicit): Allow explicit conversions from
9600 the underlying type to enum type. This precisely follows the spec
9601 and closes a bug filed by Gonzalo.
9603 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9606 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9608 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9610 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9611 it was important that we stored the right value after the
9612 reduction in `converted'.
9614 2002-09-04 Martin Baulig <martin@gnome.org>
9616 * location.cs (Location.SymbolDocument): Use full pathnames for the
9619 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9621 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9622 of the expression resolve mechanism, because that will catch the
9623 SimpleName error failures.
9625 (Conditional): If we can not resolve the
9626 expression, return, do not crash.
9628 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9631 (location): display token name instead of its number.
9633 2002-08-28 Martin Baulig <martin@gnome.org>
9635 * expression.cs (Binary.ResolveOperator): Don't silently return
9636 but return an error if an operator cannot be applied between two
9639 2002-08-28 Martin Baulig <martin@gnome.org>
9641 * class.cs (Constructor.Define): Set the permission attributes
9642 correctly instead of making all constructors public.
9644 2002-08-28 Martin Baulig <martin@gnome.org>
9646 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9647 for private members before reporting a CS0103; if we find anything,
9650 2002-08-28 Martin Baulig <martin@gnome.org>
9652 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9653 to check whether `closure_start_type == closure_invocation_type',
9654 we also need to check whether `m.DeclaringType == closure_invocation_type'
9655 before bypassing the permission checks. We might be accessing
9656 protected/private members from the base class.
9657 (TypeManager.RealMemberLookup): Only set private_ok if private
9658 members were requested via BindingFlags.NonPublic.
9660 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9662 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9663 MethodGroupExpr.IsExplicitImpl if appropriate.
9664 (Invocation.DoResolve): Don't report the CS0120 for explicit
9665 interface implementations.
9667 2002-08-27 Martin Baulig <martin@gnome.org>
9669 * expression.cs (Invocation.DoResolve): If this is a static
9670 method and we don't have an InstanceExpression, we must report
9673 2002-08-25 Martin Baulig <martin@gnome.org>
9675 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9676 `==' between a valuetype and an object.
9678 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9680 * ecore.cs (TypeExpr): Provide a ToString method.
9682 2002-08-24 Martin Baulig <martin@gnome.org>
9684 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9685 now called proggie.dbg and it's a binary file.
9687 2002-08-23 Martin Baulig <martin@gnome.org>
9689 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9691 2002-08-23 Martin Baulig <martin@gnome.org>
9693 * struct.cs (MyStructInfo.ctor): Make this work with empty
9694 structs; it's not allowed to use foreach() on null.
9696 2002-08-23 Martin Baulig <martin@gnome.org>
9698 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9699 writer the full pathname of the generated assembly.
9701 2002-08-23 Martin Baulig <martin@gnome.org>
9703 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9704 A `finally' block never returns or breaks; improved handling of
9707 2002-08-23 Martin Baulig <martin@gnome.org>
9709 * statement.cs (Throw.Resolve): Allow `throw null'.
9711 2002-08-23 Martin Baulig <martin@gnome.org>
9713 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9714 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9715 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9716 MemberLookup would return a wrong event if this is an explicit
9717 interface implementation and the class has an event with the same
9720 2002-08-23 Martin Baulig <martin@gnome.org>
9722 * statement.cs (Block.AddChildVariableNames): New public method.
9723 (Block.AddChildVariableName): Likewise.
9724 (Block.IsVariableNameUsedInChildBlock): Likewise.
9725 (Block.AddVariable): Check whether a variable name has already
9726 been used in a child block.
9728 * cs-parser.jay (declare_local_variables): Mark all variable names
9729 from the current block as being used in a child block in the
9732 2002-08-23 Martin Baulig <martin@gnome.org>
9734 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9735 find the symbol writer.
9737 * driver.cs: csc also allows the arguments to /define being
9738 separated by commas, not only by semicolons.
9740 2002-08-23 Martin Baulig <martin@gnome.org>
9742 * interface.cs (Interface.GetMembers): Added static check for events.
9744 2002-08-15 Martin Baulig <martin@gnome.org>
9746 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9747 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9749 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9750 why the MethodData.EmitDestructor() change was necessary.
9752 2002-08-20 Martin Baulig <martin@gnome.org>
9754 * class.cs (TypeContainer.FindMembers): Added static check for events.
9756 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9758 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9759 use Type.GetEvents(), not Type.FindMembers().
9761 2002-08-20 Martin Baulig <martin@gnome.org>
9763 * decl.cs (MemberCache): Added a special method cache which will
9764 be used for method-only searched. This ensures that a method
9765 search will return a MethodInfo with the correct ReflectedType for
9768 2002-08-20 Martin Baulig <martin@gnome.org>
9770 * decl.cs (DeclSpace.FindMembers): Made this public.
9772 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9774 * delegate.cs: fixed build on windows.
9775 [FIXME: Filed as bug #29150: MCS must report these errors.]
9777 2002-08-19 Ravi Pratap <ravi@ximian.com>
9779 * ecore.cs (StandardConversionExists): Return a false
9780 if we are trying to convert the void type to anything else
9781 since that is not allowed.
9783 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9784 we flag error 70 in the event an event is trying to be accessed
9785 directly from outside the declaring type.
9787 2002-08-20 Martin Baulig <martin@gnome.org>
9789 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9790 MemberCache from typemanager.cs to decl.cs.
9792 2002-08-19 Martin Baulig <martin@gnome.org>
9794 * class.cs (TypeContainer): Implement IMemberContainer.
9795 (TypeContainer.DefineMembers): Create the MemberCache.
9796 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9797 return public members if BindingFlags.Public was given, check
9798 whether members are static.
9800 2002-08-16 Martin Baulig <martin@gnome.org>
9802 * decl.cs (DeclSpace.Define): Splitted this in Define and
9803 DefineMembers. DefineMembers is called first and initializes the
9806 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9807 DefineMembers() on all our DeclSpaces.
9809 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9810 but call DefineMembers() on all nested interfaces. We call their
9811 Define() in our new Define() function.
9813 * interface.cs (Interface): Implement IMemberContainer.
9814 (Interface.Define): Moved all code except the attribute stuf to
9816 (Interface.DefineMembers): Initialize the member cache.
9818 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9819 need this anymore since we can use MemberCache.FindMembers directly.
9821 2002-08-19 Martin Baulig <martin@gnome.org>
9823 * typemanager.cs (MemberCache): When creating the cache for an
9824 interface type, add all inherited members.
9825 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9826 to `out bool used_cache' and documented it.
9827 (TypeManager.MemberLookup): If we already used the cache in the first
9828 iteration, we don't need to do the interfaces check.
9830 2002-08-19 Martin Baulig <martin@gnome.org>
9832 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9833 here from IMemberFinder and don't implement this interface anymore.
9834 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9836 * typemanager.cs (IMemberFinder): This interface is now only used by
9837 classes which actually support the member cache.
9838 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9839 since we only put DeclSpaces into this Hashtable.
9840 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9841 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9843 2002-08-16 Martin Baulig <martin@gnome.org>
9845 * typemanager.cs (ICachingMemberFinder): Removed.
9846 (IMemberFinder.MemberCache): New property.
9847 (TypeManager.FindMembers): Merged this with RealFindMembers().
9848 This function will never be called from TypeManager.MemberLookup()
9849 so we can't use the cache here, just the IMemberFinder.
9850 (TypeManager.MemberLookup_FindMembers): Check whether the
9851 IMemberFinder has a MemberCache and call the cache's FindMembers
9853 (MemberCache): Rewrote larger parts of this yet another time and
9854 cleaned it up a bit.
9856 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9858 * driver.cs (LoadArgs): Support quoting.
9860 (Usage): Show the CSC-like command line arguments.
9862 Improved a few error messages.
9864 2002-08-15 Martin Baulig <martin@gnome.org>
9866 * typemanager.cs (IMemberContainer.Type): New property.
9867 (IMemberContainer.IsInterface): New property.
9869 The following changes are conditional to BROKEN_RUNTIME, which is
9870 defined at the top of the file.
9872 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9873 class'es members, but add all members from TypeHandle.ObjectType
9874 if we're an interface.
9875 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9876 is the current type.
9877 (MemberCache.CacheEntry.Container): Removed this field.
9878 (TypeHandle.GetMembers): Include inherited members.
9880 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9882 * typemanager.cs: fixed compilation and added a comment on a field that
9885 2002-08-15 Martin Baulig <martin@gnome.org>
9887 * class.cs (ConstructorInitializer.Resolve): In the
9888 Expression.MemberLookup call, use the queried_type as
9891 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9892 declared' attribute, it's always true.
9893 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9894 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9895 temporary wrapper for FindMembers which tells MemberLookup whether
9896 members from the base classes are included in the return value.
9897 This will go away soon.
9898 (TypeManager.MemberLookup): Use this temporary hack here; once the
9899 new MemberCache is completed, we don't need to do the DeclaredOnly
9900 looping here anymore since the MemberCache will take care of this.
9901 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9902 (MemberCache): When creating the MemberCache for a class, get
9903 members from the current class and all its base classes.
9904 (MemberCache.CacheEntry.Container): New field. This is a
9905 temporary hack until the Mono runtime is fixed to distinguish
9906 between ReflectedType and DeclaringType. It allows us to use MCS
9907 with both the MS runtime and the unfixed Mono runtime without
9908 problems and without accecting performance.
9909 (MemberCache.SearchMembers): The DeclaredOnly looping from
9910 TypeManager.MemberLookup is now done here.
9912 2002-08-14 Martin Baulig <martin@gnome.org>
9914 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9915 Type.GetFields on dynamic types but get the fields from the
9916 corresponding TypeContainer.
9917 (MyStructInfo.GetStructInfo): Added check for enum types.
9919 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9920 (MemberList.SyncRoot): Implemented.
9921 (TypeManager.FilterWithClosure): No need to check permissions if
9922 closure_start_type == closure_invocation_type, don't crash if
9923 closure_invocation_type is null.
9925 2002-08-13 Martin Baulig <martin@gnome.org>
9927 Rewrote TypeContainer.FindMembers to use a member cache. This
9928 gives us a speed increase of about 35% for the self-hosting MCS
9929 build and of about 15-20% for the class libs (both on GNU/Linux).
9931 * report.cs (Timer): New class to get enhanced profiling. This
9932 whole class is "TIMER" conditional since it remarkably slows down
9935 * class.cs (MemberList): New class. This is an IList wrapper
9936 which we're now using instead of passing MemberInfo[]'s around to
9937 avoid copying this array unnecessarily.
9938 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9939 (ICachingMemberFinder, IMemberContainer): New interface.
9940 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9941 has already been checked, otherwise use it for the name comparision.
9942 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9943 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9944 if possible. Returns a MemberList, not a MemberInfo [].
9945 (TypeHandle): New class, implements IMemberContainer. We create
9946 one instance of this class per type, it contains a MemberCache
9947 which is used to do the member lookups.
9948 (MemberCache): New class. Each instance of this class contains
9949 all members of a type and a name-based hash table.
9950 (MemberCache.FindMembers): This is our new member lookup
9951 function. First, it looks up all members of the requested name in
9952 the hash table. Then, it walks this list and sorts out all
9953 applicable members and returns them.
9955 2002-08-13 Martin Baulig <martin@gnome.org>
9957 In addition to a nice code cleanup, this gives us a performance
9958 increase of about 1.4% on GNU/Linux - not much, but it's already
9959 half a second for the self-hosting MCS compilation.
9961 * typemanager.cs (IMemberFinder): New interface. It is used by
9962 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9963 Enum, Delegate or Interface.
9964 (TypeManager.finder_to_member_finder): New PtrHashtable.
9965 (TypeManager.finder_to_container): Removed.
9966 (TypeManager.finder_to_delegate): Removed.
9967 (TypeManager.finder_to_interface): Removed.
9968 (TypeManager.finder_to_enum): Removed.
9970 * interface.cs (Interface): Implement IMemberFinder.
9972 * delegate.cs (Delegate): Implement IMemberFinder.
9974 * enum.cs (Enum): Implement IMemberFinder.
9976 * class.cs (TypeContainer): Implement IMemberFinder.
9978 2002-08-12 Martin Baulig <martin@gnome.org>
9980 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9982 2002-08-12 Martin Baulig <martin@gnome.org>
9984 * ecore.cs (ITypeExpression): New interface for expressions which
9986 (TypeExpression): Renamed to TypeLookupExpression.
9987 (Expression.DoResolve): If we're doing a types-only lookup, the
9988 expression must implement the ITypeExpression interface and we
9989 call DoResolveType() on it.
9990 (SimpleName): Implement the new ITypeExpression interface.
9991 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9992 hack, the situation that we're only looking up types can't happen
9993 anymore when this method is called. Moved the type lookup code to
9994 DoResolveType() and call it.
9995 (SimpleName.DoResolveType): This ITypeExpression interface method
9996 is now doing the types-only lookup.
9997 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9998 (ResolveFlags): Added MaskExprClass.
10000 * expression.cs (MemberAccess): Implement the ITypeExpression
10002 (MemberAccess.DoResolve): Added support for a types-only lookup
10003 when we're called via ITypeExpression.DoResolveType().
10004 (ComposedCast): Implement the ITypeExpression interface.
10006 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
10007 Expression.Resolve() with ResolveFlags.Type instead.
10009 2002-08-12 Martin Baulig <martin@gnome.org>
10011 * interface.cs (Interface.Define): Apply attributes.
10013 * attribute.cs (Attribute.ApplyAttributes): Added support for
10014 interface attributes.
10016 2002-08-11 Martin Baulig <martin@gnome.org>
10018 * statement.cs (Block.Emit): Only check the "this" variable if we
10019 do not always throw an exception.
10021 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
10022 whether the property has a set accessor.
10024 2002-08-11 Martin Baulig <martin@gnome.org>
10026 Added control flow analysis support for structs.
10028 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
10029 with control flow analysis turned off.
10030 (IVariable): New interface.
10031 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
10032 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
10033 (FieldExpr.DoResolve): Resolve the instance expression with flow
10034 analysis turned off and do the definite assignment check after the
10035 resolving when we know what the expression will resolve to.
10037 * expression.cs (LocalVariableReference, ParameterReference):
10038 Implement the new IVariable interface, only call the flow analysis
10039 code if ec.DoFlowAnalysis is true.
10040 (This): Added constructor which takes a Block argument. Implement
10041 the new IVariable interface.
10042 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
10043 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
10044 This does the definite assignment checks for struct members.
10046 * class.cs (Constructor.Emit): If this is a non-static `struct'
10047 constructor which doesn't have any initializer, call
10048 Block.AddThisVariable() to tell the flow analysis code that all
10049 struct elements must be initialized before control returns from
10052 * statement.cs (MyStructInfo): New public class.
10053 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
10054 argument to this indexer. If non-zero, check an individual struct
10055 member, not the whole struct.
10056 (FlowBranching.CheckOutParameters): Check struct members.
10057 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
10058 overloaded versions of these methods which take an additional
10059 `int field_idx' argument to check struct members.
10060 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
10061 overloaded versions of these methods which take an additional
10062 `string field_name' argument to check struct member.s
10063 (VariableInfo): Implement the IVariable interface.
10064 (VariableInfo.StructInfo): New public property. Returns the
10065 MyStructInfo instance of the variable if it's a struct or null.
10066 (Block.AddThisVariable): New public method. This is called from
10067 Constructor.Emit() for non-static `struct' constructor which do
10068 not have any initializer. It creates a special variable for the
10069 "this" instance variable which will be checked by the flow
10070 analysis code to ensure that all of the struct's fields are
10071 initialized before control returns from the constructor.
10072 (UsageVector): Added support for struct members. If a
10073 variable/parameter is a struct with N members, we reserve a slot
10074 in the usage vector for each member. A struct is considered fully
10075 initialized if either the struct itself (slot 0) or all its
10076 members are initialized.
10078 2002-08-08 Martin Baulig <martin@gnome.org>
10080 * driver.cs (Driver.MainDriver): Only report an error CS5001
10081 if there were no compilation errors.
10083 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
10084 `UnsafeContext' property to determine whether the parent is in
10085 unsafe context rather than checking the parent's ModFlags:
10086 classes nested in an unsafe class are unsafe as well.
10088 2002-08-08 Martin Baulig <martin@gnome.org>
10090 * statement.cs (UsageVector.MergeChildren): Distinguish between
10091 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
10092 we return. Added test17() and test18() to test-154.cs.
10094 2002-08-08 Martin Baulig <martin@gnome.org>
10096 * typemanager.cs (TypeManager.FilterWithClosure): If we have
10097 Family access, make sure the invoking type isn't a subclass of the
10098 queried type (that'd be a CS1540).
10100 * ecore.cs (Expression.MemberLookup): Added overloaded version of
10101 this method which takes an additional `Type invocation_type'.
10103 * expression.cs (BaseAccess.DoResolve): Use the base type as
10104 invocation and query type.
10105 (MemberAccess.DoResolve): If the lookup failed and we're about to
10106 report a CS0122, try a lookup with the ec.ContainerType - if this
10107 succeeds, we must report a CS1540.
10109 2002-08-08 Martin Baulig <martin@gnome.org>
10111 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
10112 (MethodGroupExpr): Implement the IMemberExpr interface.
10114 * expression (MemberAccess.ResolveMemberAccess): No need to have
10115 any special code for MethodGroupExprs anymore, they're now
10118 2002-08-08 Martin Baulig <martin@gnome.org>
10120 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
10121 Family, FamANDAssem and FamORAssem permissions.
10122 (TypeManager.IsSubclassOrNestedChildOf): New public method.
10124 2002-08-08 Martin Baulig <martin@gnome.org>
10126 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
10127 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
10130 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
10132 * driver.cs: implemented /resource option to embed managed resources.
10134 2002-08-07 Martin Baulig <martin@gnome.org>
10136 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
10137 (FieldBase.HasFieldInitializer): New public property.
10138 (FieldBase.GetInitializerExpression): New public method. Resolves and
10139 returns the field initializer and makes sure it is only resolved once.
10140 (TypeContainer.EmitFieldInitializers): Call
10141 FieldBase.GetInitializerExpression to get the initializer, this ensures
10142 that it isn't resolved multiple times.
10144 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
10145 the resolving process (SimpleName/MemberLookup) that we're currently
10146 emitting a field initializer (which must not access any instance members,
10147 this is an error CS0236).
10149 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
10150 argument, if the `IsFieldInitializer' flag is set, we must report and
10151 error CS0236 and not an error CS0120.
10153 2002-08-07 Martin Baulig <martin@gnome.org>
10155 * ecore.cs (IMemberExpr): New public interface.
10156 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
10157 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
10158 if the expression is an IMemberExpr.
10160 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
10161 to be null, implicitly default to `this' if we're non-static in
10162 this case. Simplified the code a lot by using the new IMemberExpr
10163 interface. Also fixed bug #28176 here.
10165 2002-08-06 Martin Baulig <martin@gnome.org>
10167 * cs-parser.jay (SimpleLookup): Removed. We need to create
10168 ParameterReferences during semantic analysis so that we can do a
10169 type-only search when resolving Cast, TypeOf and SizeOf.
10170 (block): Pass the `current_local_parameters' to the Block's
10173 * class.cs (ConstructorInitializer): Added `Parameters parameters'
10174 argument to the constructor.
10175 (ConstructorInitializer.Resolve): Create a temporary implicit
10176 block with the parameters.
10178 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
10179 references here if we aren't doing a type-only search.
10181 * statement.cs (Block): Added constructor which takes a
10182 `Parameters parameters' argument.
10183 (Block.Parameters): New public property.
10185 * support.cs (InternalParameters.Parameters): Renamed `parameters'
10186 to `Parameters' and made it public readonly.
10188 2002-08-06 Martin Baulig <martin@gnome.org>
10190 * ecore.cs (Expression.Warning): Made this public as well.
10192 * report.cs (Report.Debug): Print the contents of collections.
10194 2002-08-06 Martin Baulig <martin@gnome.org>
10196 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
10197 used to tell Resolve() which kinds of expressions it may return.
10198 (Expression.Resolve): Added overloaded version of this method which
10199 takes a `ResolveFlags flags' argument. This can be used to tell
10200 Resolve() which kinds of expressions it may return. Reports a
10202 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
10203 ResolveFlags.SimpleName.
10204 (Expression.Error118): Added overloaded version of this method which
10205 takes a `ResolveFlags flags' argument. It uses the flags to determine
10206 which kinds of expressions are allowed.
10208 * expression.cs (Argument.ResolveMethodGroup): New public method.
10209 Resolves an argument, but allows a MethodGroup to be returned.
10210 This is used when invoking a delegate.
10212 * TODO: Updated a bit.
10214 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10216 Fixed compilation with csc.
10218 * ecore.cs: Expression.Error made public. Is this correct? Should
10219 Warning be made public too?
10221 * expression.cs: use ea.Location instead of ea.loc.
10222 [FIXME: Filed as bug #28607: MCS must report these errors.]
10224 2002-08-06 Martin Baulig <martin@gnome.org>
10226 * ecore.cs (Expression.loc): Moved the location here instead of
10227 duplicating it in all derived classes.
10228 (Expression.Location): New public property.
10229 (Expression.Error, Expression.Warning): Made them non-static and
10230 removed the location argument.
10231 (Expression.Warning): Added overloaded version which takes an
10232 `int level' argument.
10233 (Expression.Error118): Make this non-static and removed the
10234 expression and location arguments.
10235 (TypeExpr): Added location argument to the constructor.
10237 * expression.cs (StaticCallExpr): Added location argument to
10239 (Indirection, PointerArithmetic): Likewise.
10240 (CheckedExpr, UnCheckedExpr): Likewise.
10241 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
10242 (StringPtr): Likewise.
10245 2002-08-05 Martin Baulig <martin@gnome.org>
10247 * expression.cs (BaseAccess.DoResolve): Actually report errors.
10249 * assign.cs (Assign.DoResolve): Check whether the source
10250 expression is a value or variable.
10252 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
10253 while resolving the corresponding blocks.
10255 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
10256 an error, don't silently return null.
10258 * statement.cs (Block.AddVariable): Do the error reporting here
10259 and distinguish between CS0128 and CS0136.
10260 (Block.DoResolve): Report all unused labels (warning CS0164).
10261 (LabeledStatement): Pass the location to the constructor.
10262 (LabeledStatement.HasBeenReferenced): New property.
10263 (LabeledStatement.Resolve): Set it to true here.
10265 * statement.cs (Return.Emit): Return success even after reporting
10266 a type mismatch error (CS0126 or CS0127), this is what csc does and
10267 it avoids confusing the users with any consecutive errors.
10269 2002-08-05 Martin Baulig <martin@gnome.org>
10271 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
10273 * const.cs (Const.LookupConstantValue): Catch circular definitions.
10275 * expression.cs (MemberAccess.DoResolve): Silently return if an
10276 error has already been reported.
10278 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
10279 error has already been reported.
10281 2002-08-05 Martin Baulig <martin@gnome.org>
10283 * statement.cs (UsageVector): Only initialize the `parameters'
10284 vector if we actually have any "out" parameters.
10286 2002-08-05 Martin Baulig <martin@gnome.org>
10288 * expression.cs (Binary.ResolveOperator): When combining delegates,
10289 they must have the same type.
10291 2002-08-05 Martin Baulig <martin@gnome.org>
10293 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
10294 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
10295 work with the ms runtime and we also don't need it: if we're a
10296 PropertyBuilder and not in the `indexer_arguments' hash, then we
10297 are a property and not an indexer.
10299 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
10300 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
10301 since the latter one doesn't work with the ms runtime.
10303 2002-08-03 Martin Baulig <martin@gnome.org>
10305 Fixed bugs #27998 and #22735.
10307 * class.cs (Method.IsOperator): New public field.
10308 (Method.CheckBase): Report CS0111 if there's already a method
10309 with the same parameters in the current class. Report CS0508 when
10310 attempting to change the return type of an inherited method.
10311 (MethodData.Emit): Report CS0179 if a method doesn't have a body
10312 and it's not marked abstract or extern.
10313 (PropertyBase): New abstract base class for Property and Indexer.
10314 (PropertyBase.CheckBase): Moved here from Property and made it work
10316 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
10317 the same so we can reuse it there.
10318 (Property, Indexer): Derive from PropertyBase.
10319 (MethodSignature.inheritable_property_signature_filter): New delegate
10320 to find properties and indexers.
10322 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
10323 argument and improved error reporting.
10325 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
10326 EmptyReadOnlyParameters and made it a property.
10328 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
10329 version of this method which takes a `PropertyInfo indexer'.
10330 (TypeManager.RegisterIndexer): New method.
10332 * class.cs: Added myself as author of this file :-)
10334 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10336 * class.cs: fixed compilation on windoze.
10338 2002-08-03 Martin Baulig <martin@gnome.org>
10340 * interface.cs (Interface.GetInterfaceBases): Check whether all
10341 base interfaces are at least as accessible than the current one.
10343 * class.cs (TypeContainer.GetClassBases): Check whether base types
10344 are at least as accessible than the current type.
10345 (TypeContainer.AsAccessible): Implemented and made non-static.
10346 (MemberBase.CheckParameters): Report errors if the accessibility
10349 * delegate.cs (Delegate.Delegate): The default visibility is
10350 internal for top-level types and private for nested types.
10351 (Delegate.Define): Report errors if the accessibility checks fail.
10353 * enum.cs (Enum.Enum): The default visibility is internal for
10354 top-level types and private for nested types.
10355 (Enum.DefineType): Compute the correct visibility.
10357 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
10358 function which takes a `bool is_toplevel' instead of a TypeContainer.
10360 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
10363 2002-08-02 Martin Baulig <martin@gnome.org>
10365 * expression.cs (LocalVariableReferenc): Added constructor which
10366 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
10367 (LocalVariableReference.IsReadOnly): New property.
10368 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
10369 variable is readonly, use our own readonly flag to do this; you can
10370 use the new constructor to get a writable reference to a read-only
10373 * cs-parser.jay (foreach_statement, using_statement): Get a writable
10374 reference to the local variable.
10376 2002-08-01 Miguel de Icaza <miguel@ximian.com>
10378 * rootcontext.cs (ResolveCore): Also include System.Exception
10380 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
10381 we reach an EmptyStatement.
10383 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
10386 * expression.cs (Binary.ResolveOperator): Check error result in
10389 use brtrue/brfalse directly and avoid compares to null.
10391 2002-08-02 Martin Baulig <martin@gnome.org>
10393 * class.cs (TypeContainer.Define): Define all nested interfaces here.
10394 Fixes bug #28407, added test-155.cs.
10396 2002-08-01 Martin Baulig <martin@gnome.org>
10398 * class.cs (Event.EmitDefaultMethod): Make this work with static
10399 events. Fixes #28311, added verify-3.cs.
10401 2002-08-01 Martin Baulig <martin@gnome.org>
10403 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
10404 `is_disposable' fields.
10405 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
10406 `hm.is_disposable' if we're using the collection pattern.
10407 (Foreach.EmitCollectionForeach): Use the correct type for the
10408 enumerator's local variable, only emit the try/finally block if
10409 necessary (fixes #27713).
10411 2002-08-01 Martin Baulig <martin@gnome.org>
10413 * ecore.cs (Expression.report118): Renamed to Error118 and made
10416 * statement.cs (Throw.Resolve): Check whether the expression is of
10417 the correct type (CS0118) and whether the type derives from
10418 System.Exception (CS0155).
10419 (Catch.Resolve): New method. Do the type lookup here and check
10420 whether it derives from System.Exception (CS0155).
10421 (Catch.CatchType, Catch.IsGeneral): New public properties.
10423 * typemanager.cs (TypeManager.exception_type): Added.
10425 2002-07-31 Miguel de Icaza <miguel@ximian.com>
10427 * driver.cs: Updated About function.
10429 2002-07-31 Martin Baulig <martin@gnome.org>
10431 Implemented Control Flow Analysis.
10433 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
10434 (EmitContext.CurrentBranching): Added.
10435 (EmitContext.StartFlowBranching): Added.
10436 (EmitContext.EndFlowBranching): Added.
10437 (EmitContext.KillFlowBranching): Added.
10438 (EmitContext.IsVariableAssigned): Added.
10439 (EmitContext.SetVariableAssigned): Added.
10440 (EmitContext.IsParameterAssigned): Added.
10441 (EmitContext.SetParameterAssigned): Added.
10442 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
10443 Added control flow analysis stuff here.
10445 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
10446 resolve the expression as lvalue.
10447 (LocalVariableReference.DoResolve): Check whether the variable has
10448 already been assigned.
10449 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
10450 the parameter as assigned here.
10451 (ParameterReference.DoResolve): Check whether the parameter has already
10453 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
10454 expression as lvalue.
10456 * statement.cs (FlowBranching): New class for the flow analysis code.
10457 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
10458 (LabeledStatement.IsDefined): New public property.
10459 (LabeledStatement.AddUsageVector): New public method to tell flow
10460 analyis that the label may be reached via a forward jump.
10461 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
10463 (VariableInfo.Number): New public field. This is used by flow analysis
10464 to number all locals of a block.
10465 (Block.CountVariables): New public property. This is the number of
10466 local variables in this block (including the locals from all parent
10468 (Block.EmitMeta): Number all the variables.
10470 * statement.cs: Added flow analysis support to all classes.
10472 2002-07-31 Martin Baulig <martin@gnome.org>
10474 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
10475 To get debugging messages, compile mcs with /define:MCS_DEBUG and
10476 then use this argument.
10478 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
10480 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
10481 use this to specify /define options.
10483 2002-07-29 Martin Baulig <martin@gnome.org>
10485 * statement.cs (Fixed): Moved all code that does variable lookups
10486 and resolvings from Emit to Resolve.
10488 * statement.cs (For): Moved all code that does variable lookups
10489 and resolvings from Emit to Resolve.
10491 * statement.cs (Using): Moved all code that does variable lookups
10492 and resolvings from Emit to Resolve.
10494 2002-07-29 Martin Baulig <martin@gnome.org>
10496 * attribute.cs (Attribute.Resolve): Explicitly catch a
10497 System.NullReferenceException when creating the
10498 CustromAttributeBuilder and report a different warning message.
10500 2002-07-29 Martin Baulig <martin@gnome.org>
10502 * support.cs (ParameterData.ParameterName): Added method to
10503 get the name of a parameter.
10505 * typemanager.cs (TypeManager.IsValueType): New public method.
10507 2002-07-29 Martin Baulig <martin@gnome.org>
10509 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
10510 is a flag which specifies that it's either ref or out.
10511 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
10512 the out parameter to `out Parameter.Modifier mod', also set the
10513 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
10515 * support.cs (InternalParameters.ParameterModifier): Distinguish
10516 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10517 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10519 * expression.cs (Argument.GetParameterModifier): Distinguish
10520 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10521 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10523 2002-07-29 Martin Baulig <martin@gnome.org>
10525 * expression.cs (ParameterReference.ParameterReference): Added
10526 `Location loc' argument to the constructor.
10528 * cs-parser.jay: Pass location to ParameterReference.
10530 2002-07-28 Miguel de Icaza <miguel@ximian.com>
10532 * statement.cs (Try): Initialize the location.
10534 * cs-parser.jay: pass location to Try.
10536 * expression.cs (Unary.Reduce): Change the prototype to return
10537 whether a constant fold could be performed or not. The result is
10538 returned in an out parameters. In the case of Indirection and
10539 AddressOf, we want to perform the full tests.
10541 2002-07-26 Miguel de Icaza <miguel@ximian.com>
10543 * statement.cs (Statement.Emit): Flag dead code.
10545 2002-07-27 Andrew Birkett <andy@nobugs.org>
10547 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
10549 2002-07-27 Martin Baulig <martin@gnome.org>
10551 * class.cs (MethodData.Define): Put back call to
10552 TypeManager.AddMethod(), accidentally commented this out.
10554 * report.cs (Debug): New public method to print debugging information,
10555 this is `[Conditional ("DEBUG")]'.
10557 2002-07-26 Martin Baulig <martin@gnome.org>
10559 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10560 (switch_statement): Push the current_block to the switch_stack and
10561 pop it again when we're done with the switch.
10562 (switch_section): The new block is a child of the current_block.
10563 Fixes bug #24007, added test-152.cs.
10565 2002-07-27 Martin Baulig <martin@gnome.org>
10567 * expression.cs (Invocation.EmitArguments): When calling a varargs
10568 function with only its fixed arguments, we need to pass an empty
10571 2002-07-27 Martin Baulig <martin@gnome.org>
10573 Mono 0.13 has been released.
10575 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10577 * driver.cs: Rename --resource to --linkres, because that is what
10578 we do currently, we dont support --resource yet.
10580 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10582 2002-07-25 Martin Baulig <martin@gnome.org>
10584 * class.cs (MethodData): New public class. This is a `method builder'
10585 class for a method or one accessor of a Property/Indexer/Event.
10586 (MethodData.GetMethodFlags): Moved here from MemberBase.
10587 (MethodData.ApplyAttributes): Likewise.
10588 (MethodData.ApplyObsoleteAttribute): Likewise.
10589 (MethodData.ApplyConditionalAttribute): Likewise.
10590 (MethodData.ApplyDllImportAttribute): Likewise.
10591 (MethodData.CheckAbstractAndExternal): Likewise.
10592 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10593 (MethodData.Emit): Formerly known as Method.Emit().
10594 (MemberBase): Moved everything which was specific to a single
10595 accessor/method to MethodData.
10596 (Method): Create a new MethodData and call Define() and Emit() on it.
10597 (Property, Indexer, Event): Create a new MethodData objects for each
10598 accessor and call Define() and Emit() on them.
10600 2002-07-25 Martin Baulig <martin@gnome.org>
10602 Made MethodCore derive from MemberBase to reuse the code from there.
10603 MemberBase now also checks for attributes.
10605 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10606 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10608 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10609 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10610 (MemberBase.ApplyAttributes): New virtual method; applies the
10611 attributes to a method or accessor.
10612 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10613 (MemberBase.ApplyConditionalAttribute): Likewise.
10614 (MemberBase.ApplyDllImportAttribute): Likewise.
10615 (MemberBase.CheckAbstractAndExternal): Likewise.
10616 (MethodCore.ParameterTypes): This is now a property instead of a
10617 method, it's initialized from DoDefineParameters().
10618 (MethodCore.ParameterInfo): Removed the set accessor.
10619 (MethodCore.DoDefineParameters): New protected virtual method to
10620 initialize ParameterTypes and ParameterInfo.
10621 (Method.GetReturnType): We can now simply return the MemberType.
10622 (Method.GetMethodFlags): Override the MemberBase version and add
10623 the conditional flags.
10624 (Method.CheckBase): Moved some code from Define() here, call
10625 DoDefineParameters() here.
10626 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10627 here to avoid some larger code duplication.
10628 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10629 ensure that abstract and external accessors don't declare a body.
10631 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10632 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10633 lookup in the attribute's parent classes, so we need to abort as soon
10634 as we found the first match.
10635 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10636 the attribute has no arguments.
10638 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10641 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10643 * cs-parser.jay: reverted previous patch.
10645 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10647 * cs-parser.jay: fixed bug #22119.
10649 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10651 * attribute.cs: fixed compilation. The error was:
10652 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10653 be assigned to before control leaves the current method."
10654 [FIXME: Filed as bug #28186: MCS must report this error.]
10656 2002-07-25 Martin Baulig <martin@gnome.org>
10658 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10659 method to pull the condition name ouf of a Conditional attribute.
10660 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10661 the obsolete message and error flag out of an Obsolete attribute.
10663 * class.cs (Method.GetMethodFlags): New public method to get the
10664 TypeManager.MethodFlags for this method.
10665 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10667 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10668 if we're overriding a virtual function, set the new private variable
10669 `parent_method'; call the new TypeManager.AddMethod().
10671 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10672 the MethodBuilder and the Method in a PtrHashtable.
10673 (TypeManager.builder_to_method): Added for this purpose.
10674 (TypeManager.MethodFlags): Added IsObsoleteError.
10675 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10676 Obsolete and Conditional arguments in MethodBuilders. If we discover
10677 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10678 the message from the attribute.
10680 2002-07-24 Martin Baulig <martin@gnome.org>
10682 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10683 preprocessor directives, ensure that the argument to #define/#undef is
10684 exactly one identifier and that it's actually an identifier.
10686 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10689 2002-07-24 Martin Baulig <martin@gnome.org>
10691 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10692 initialize it to TypeManager.object_type in the constructor.
10693 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10694 of the `hm.get_current' method if we're using the collection pattern.
10695 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10696 for the explicit conversion to make it work when we're using the collection
10697 pattern and the `Current' property has a different return type than `object'.
10700 2002-07-24 Martin Baulig <martin@gnome.org>
10702 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10703 does not match, but don't report any errors. This method is called in
10704 order for all methods in a MethodGroupExpr until a matching method is
10705 found, so we don't want to bail out if the first method doesn't match.
10706 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10707 matches, report the 123. Fixes #28070.
10709 2002-07-24 Martin Baulig <martin@gnome.org>
10711 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10712 TypeManager.TypeToCoreType() to the top of the method so the
10713 following equality checks will work. Fixes #28107.
10715 2002-07-24 Martin Baulig <martin@gnome.org>
10717 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10718 operand is of type uint, and the other operand is of type sbyte,
10719 short or int, the operands are converted to type long." -
10720 Actually do what this comment already told us. Fixes bug #28106,
10723 2002-07-24 Martin Baulig <martin@gnome.org>
10725 * class.cs (MethodBase): New abstract class. This is now a base
10726 class for Property, Indexer and Event to avoid some code duplication
10727 in their Define() and DefineMethods() methods.
10728 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10729 generic methods for Define() and DefineMethods().
10730 (FieldBase): Derive from MemberBase, not MemberCore.
10731 (Property): Derive from MemberBase, not MemberCore.
10732 (Property.DefineMethod): Moved all the code from this method to the
10733 new MethodBase.DefineAccessor(), just call it with appropriate
10735 (Property.Define): Call the new Property.DoDefine(), this does some
10736 sanity checks and we don't need to duplicate the code everywhere.
10737 (Event): Derive from MemberBase, not MemberCore.
10738 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10739 accessors, this will also make them work with interface events.
10740 (Indexer): Derive from MemberBase, not MemberCore.
10741 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10742 (Indexer.Define): Use the new MethodBase functions.
10744 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10745 argument to the constructor.
10746 (Interface.FindMembers): Added support for interface events.
10747 (Interface.PopluateEvent): Implemented.
10749 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10751 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10753 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10754 but this is required to check for a method name being the same as
10755 the containing class.
10759 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10761 * interface.cs: initialize variable.
10763 2002-07-23 Martin Baulig <martin@gnome.org>
10765 Implemented the IndexerName attribute in interfaces.
10767 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10768 name if this is an explicit interface implementation.
10769 (Indexer.InterfaceIndexerName): New public variable. If we're
10770 implementing an interface indexer, this is the IndexerName in that
10771 interface. Otherwise, it's the IndexerName.
10772 (Indexer.DefineMethod): If we're implementing interface indexer,
10773 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10774 and Pending.ImplementIndexer methods.
10775 (Indexer.Define): Also define the PropertyBuilder if we're
10776 implementing an interface indexer and this is neither an explicit
10777 interface implementation nor do the IndexerName match the one in
10780 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10781 If a method is defined here, then we always need to create a proxy
10782 for it. This is used when implementing interface indexers.
10783 (Pending.IsInterfaceIndexer): New public method.
10784 (Pending.ImplementIndexer): New public method.
10785 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10786 This is used when implementing interface indexers to define a proxy
10788 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10789 define a proxy if necessary.
10791 * interface.cs (Interface.IndexerName): New public variable.
10792 (Interface.PopulateIndexer): Set the IndexerName.
10793 (Interface.DefineIndexers): New private method. Populate all the
10794 indexers and make sure their IndexerNames match.
10796 * typemanager.cs (IndexerPropertyName): Added support for interface
10799 2002-07-22 Martin Baulig <martin@gnome.org>
10801 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10802 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10803 ret if HasReturnLabel.
10804 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10807 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10808 and set the ec.LoopBeginTryCatchLevel.
10809 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10810 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10811 the current ec.TryCatchLevel, the branch goes out of an exception
10812 block. In this case, we need to use Leave and not Br.
10814 2002-07-22 Martin Baulig <martin@gnome.org>
10816 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10817 block unless the block does not always return or it is contained in
10818 another try { ... } catch { ... } block. Fixes bug #26506.
10819 Added verify-1.cs to the test suite.
10821 2002-07-22 Martin Baulig <martin@gnome.org>
10823 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10824 then we do not always return. Fixes bug #24985.
10826 2002-07-22 Martin Baulig <martin@gnome.org>
10828 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10829 lookup on a per-class level; ie. walk up the class hierarchy until we
10830 found at least one applicable method, then choose the best among them.
10831 Fixes bug #24463 and test-29.cs.
10833 2002-07-22 Martin Baulig <martin@gnome.org>
10835 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10836 return types of the methods. The return type is not part of the
10837 signature and we must not check it to make the `new' modifier work.
10838 Fixes bug #27999, also added test-147.cs.
10839 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10841 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10842 on the method's return type.
10844 2002-07-21 Martin Baulig <martin@gnome.org>
10846 * assign.cs: Make this work if the rightmost source is a constant and
10847 we need to do an implicit type conversion. Also adding a few more tests
10848 to test-38.cs which should have caught this.
10850 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10851 target in the makefile for this. The makefile.gnu is primarily intended
10852 for end-users who don't want to debug the compiler.
10854 2002-07-21 Martin Baulig <martin@gnome.org>
10856 * assign.cs: Improved the Assign class so it can now handle embedded
10857 assignments (X = Y = Z = something). As a side-effect this'll now also
10858 consume less local variables. test-38.cs now passes with MCS, added
10859 a few new test cases to that test.
10861 2002-07-20 Martin Baulig <martin@gnome.org>
10863 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10864 instructions. Fixes bug #27977, also added test-146.cs.
10866 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10868 * cs-tokenizer.cs: fixed getHex ().
10870 2002-07-19 Martin Baulig <martin@gnome.org>
10872 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10873 not Type.GetType() to lookup the array type. This is needed when
10874 we're constructing an array of a user-defined type.
10875 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10876 single-dimensional arrays, but also for single-dimensial arrays of
10879 2002-07-19 Martin Baulig <martin@gnome.org>
10881 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10882 this function is called, it's not allowed to share LocalBuilders
10883 among ILGenerators.
10885 2002-07-19 Martin Baulig <martin@gnome.org>
10887 * expression.cs (Argument.Resolve): Report an error 118 when trying
10888 to pass a type as argument.
10890 2002-07-18 Martin Baulig <martin@gnome.org>
10892 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10893 Conv_R_Un for the signed `long' type.
10895 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10897 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10898 `expr' for the temporary result, as that will fail if we do
10899 multiple resolves on the same expression.
10901 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10903 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10904 ec.TypeContainer for looking up aliases.
10906 * class.cs (TypeContainer): Remove LookupAlias from here.
10908 * decl.cs (DeclSpace); Move here.
10910 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10912 * class.cs (FindMembers): Only call filter if the constructor
10913 bulider is not null.
10915 Also handle delegates in `NestedTypes' now. Now we will perform
10916 type lookups using the standard resolution process. This also
10919 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10920 This uses Expressions (the limited kind that can be parsed by the
10921 tree) instead of strings.
10923 * expression.cs (ComposedCast.ToString): Implement, used to flag
10924 errors since now we have to render expressions.
10926 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10929 * ecore.cs (SimpleName.ToString): ditto.
10931 * cs-parser.jay: Instead of using strings to assemble types, use
10932 Expressions to assemble the type (using SimpleName, ComposedCast,
10933 MemberAccess). This should fix the type lookups in declarations,
10934 because we were using a different code path for this.
10936 * statement.cs (Block.Resolve): Continue processing statements
10937 even when there is an error.
10939 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10941 * class.cs (Event.Define): Also remove the `remove' method from
10942 the list of pending items.
10944 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10945 generate more compact code.
10947 2002-07-17 Martin Baulig <martin@gnome.org>
10949 * const.cs (Const.LookupConstantValue): Add support for constant
10950 `unchecked' and `checked' expressions.
10951 Also adding test case test-140.cs for this.
10953 2002-07-17 Martin Baulig <martin@gnome.org>
10955 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10956 check whether mi.ReturnType implements the IEnumerator interface; the
10957 `==' and the IsAssignableFrom() will fail in this situation.
10959 2002-07-16 Ravi Pratap <ravi@ximian.com>
10961 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10964 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10966 * expression.cs: fixed bug #27811.
10968 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10970 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10971 Molaro: when we are a ref, the value already contains a pointer
10972 value, do not take the address of it.
10974 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10975 * removed mb-parser.jay and mb-tokenizer.cs
10977 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10979 * expression.cs: check against the building corlib void type.
10981 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10983 * ecore.cs: fix for valuetype static readonly fields: when
10984 initializing them, we need their address, not the address of a copy.
10986 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10988 * typemanager.cs: register also enum_type in corlib.
10990 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10992 * class.cs: allow calling this (but not base) initializers in structs.
10994 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10996 * ecore.cs: make sure we compare against the building base types
10999 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
11001 * typemanager.cs: fix TypeToCoreType() to handle void and object
11002 (corlib gets no more typerefs after this change).
11004 2002-07-12 Miguel de Icaza <miguel@ximian.com>
11006 * expression.cs (ArrayCreation.EmitArrayArguments): use
11007 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
11009 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
11010 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
11011 array indexes, the runtime actually forbids them.
11013 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
11014 for array arguments here.
11016 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
11017 instead of the default for ValueTypes.
11019 (New.DoEmit): Use IsValueType instead of
11020 IsSubclassOf (value_type)
11021 (New.DoResolve): ditto.
11022 (Invocation.EmitCall): ditto.
11024 * assign.cs (Assign): ditto.
11026 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
11027 Statements *are* currently doing part of their resolution during
11030 Expressions do always resolve during resolve, but statements are
11031 only required to propagate resolution to their children.
11033 2002-07-11 Miguel de Icaza <miguel@ximian.com>
11035 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
11037 (LoadAssembly): Do not add the dll if it is already specified
11039 (MainDriver): Add the System directory to the link path at the end,
11040 after all the other -L arguments.
11042 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
11043 wrong opcode for loading bytes and bools (ldelem.i1 instead of
11044 ldelem.u1) and using the opposite for sbytes.
11046 This fixes Digger, and we can finally run it.
11048 * driver.cs (UnixParseOption): Move the option parsing here.
11049 (CSCParseOption): Implement CSC-like parsing of options.
11051 We now support both modes of operation, the old Unix way, and the
11052 new CSC-like way. This should help those who wanted to make cross
11053 platform makefiles.
11055 The only thing broken is that /r:, /reference: and /lib: are not
11056 implemented, because I want to make those have the same semantics
11057 as the CSC compiler has, and kill once and for all the confussion
11058 around this. Will be doing this tomorrow.
11060 * statement.cs (Unsafe.Resolve): The state is checked during
11061 resolve, not emit, so we have to set the flags for IsUnsfe here.
11063 2002-07-10 Miguel de Icaza <miguel@ximian.com>
11065 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
11066 not catch the Error_ObjectRefRequired in SimpleName (as it is
11067 possible to have a class/instance variable name that later gets
11068 deambiguated), we have to check this here.
11070 2002-07-10 Ravi Pratap <ravi@ximian.com>
11072 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
11073 make static and put into Expression.
11075 (Event.Define): Register the private field of the event with the
11076 TypeManager so that GetFieldFromEvent can get at it.
11078 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
11079 keep track of the private field associated with an event which
11082 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
11085 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
11087 2002-07-10 Miguel de Icaza <miguel@ximian.com>
11089 * expression.cs (Binary.EmitBranchable): this routine emits the
11090 Binary expression in a branchable context. This basically means:
11091 we need to branch somewhere, not just get the value on the stack.
11093 This works together with Statement.EmitBoolExpression.
11095 * statement.cs (Statement.EmitBoolExpression): Use
11098 2002-07-09 Miguel de Icaza <miguel@ximian.com>
11100 * statement.cs (For): Reduce the number of jumps in loops.
11102 (For): Implement loop inversion for the For statement.
11104 (Break): We can be breaking out of a Try/Catch controlled section
11105 (foreach might have an implicit try/catch clause), so we need to
11106 use Leave instead of Br.
11108 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
11109 now). If the instace expression supports IMemoryLocation, we use
11110 the AddressOf method from the IMemoryLocation to extract the
11111 address instead of emitting the instance.
11113 This showed up with `This', as we were emitting the instance
11114 always (Emit) instead of the Address of This. Particularly
11115 interesting when This is a value type, as we dont want the Emit
11116 effect (which was to load the object).
11118 2002-07-08 Miguel de Icaza <miguel@ximian.com>
11120 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
11122 * statement.cs (Checked): Set the CheckedState during the resolve
11123 process too, as the ConvCast operations track the checked state on
11124 the resolve process, and not emit.
11126 * cs-parser.jay (namespace_member_declaration): Flag that we have
11127 found a declaration when we do. This is used to flag error 1529
11129 * driver.cs: Report ok when we display the help only.
11131 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
11133 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
11135 2002-07-04 Miguel de Icaza <miguel@ximian.com>
11137 * cs-tokenizer.cs (define): We also have to track locally the
11138 defines. AllDefines is just used for the Conditional Attribute,
11139 but we also need the local defines for the current source code.
11141 2002-07-03 Miguel de Icaza <miguel@ximian.com>
11143 * statement.cs (While, For, Do): These loops can exit through a
11144 Break statement, use this information to tell whether the
11145 statement is the last piece of code.
11147 (Break): Flag that we break.
11149 * codegen.cs (EmitContexts): New `Breaks' state variable.
11151 2002-07-03 Martin Baulig <martin@gnome.org>
11153 * class.cs (TypeContainer.MethodModifiersValid): Allow override
11154 modifiers in method declarations in structs. Otherwise, you won't
11155 be able to override things like Object.Equals().
11157 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11159 * class.cs (Method, Property, Indexer): Do not allow the public
11160 modifier to be used in explicit interface implementations.
11162 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
11163 override modifiers in method declarations in structs
11165 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
11167 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
11168 integer or real overflow, report an error
11170 2002-07-02 Martin Baulig <martin@gnome.org>
11172 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
11173 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
11174 to tell the runtime about our newly created System.Object and
11175 System.ValueType types.
11177 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11179 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
11180 struct instead of Ldarg/Starg.
11182 2002-07-02 Martin Baulig <martin@gnome.org>
11184 * expression.cs (Indirection.Indirection): Call
11185 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
11187 2002-07-02 Martin Baulig <martin@gnome.org>
11189 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
11190 ValueType, call TypeManager.TypeToCoreType() on it.
11191 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
11192 the OpCodes.Newarr argument.
11194 2002-07-02 Martin Baulig <martin@gnome.org>
11196 * expression.cs (Invocation.EmitCall): When compiling corlib,
11197 replace all calls to the system's System.Array type to calls to
11198 the newly created one.
11200 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
11201 System.Array methods.
11202 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
11203 from the system's System.Array type which must be replaced.
11205 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
11207 * typemanager.cs: load unverifiable_code_ctor so we can build
11208 corlib using the correct type. Avoid using GetTypeCode() with
11210 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
11211 TypeManager.object_type to allow building corlib.
11213 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
11215 * ecore.cs: handle System.Enum separately in LoadFromPtr().
11217 2002-07-01 Martin Baulig <martin@gnome.org>
11219 * class.cs: Make the last change actually work, we need to check
11220 whether `ifaces != null' to avoid a crash.
11222 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11224 * class.cs: when we build structs without fields that implement
11225 interfaces, we need to add the interfaces separately, since there is
11226 no API to both set the size and add the interfaces at type creation
11229 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11231 * expression.cs: the dimension arguments to the array constructors
11232 need to be converted if they are a long.
11234 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
11236 * class.cs: don't emit ldarg.0 if there is no parent constructor
11237 (fixes showstopper for corlib).
11239 2002-06-29 Martin Baulig <martin@gnome.org>
11241 MCS now compiles corlib on GNU/Linux :-)
11243 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
11244 ie. check for MethodImplOptions.InternalCall.
11246 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
11247 and TypeManager.attribute_type are null, so we must explicitly check
11248 whether parent is not null to find out whether it's an attribute type.
11249 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
11250 and SetBuilder, not only if the property is neither abstract nor external.
11251 This is necessary to set the MethodImplOptions on the accessor methods.
11252 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
11253 SetBuilder, see Property.Emit().
11255 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
11256 populate "System.Object", "System.ValueType" and "System.Attribute" since
11257 they've already been populated from BootCorlib_PopulateCoreTypes().
11259 2002-06-29 Martin Baulig <martin@gnome.org>
11261 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
11262 is the NullLiteral, we also need to make sure that target_type is not
11265 2002-06-29 Martin Baulig <martin@gnome.org>
11267 * rootcontext.cs (RootContext.ResolveCore): We must initialize
11268 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
11269 before calling BootstrapCorlib_ResolveDelegate ().
11271 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11273 * statement.cs: fixed build-breaker. All tests passed ok.
11275 2002-06-27 Martin Baulig <martin@gnome.org>
11277 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
11278 for System.Decimal when compiling corlib.
11280 2002-06-27 Martin Baulig <martin@gnome.org>
11282 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
11283 switch blocks which contain nothing but a default clause.
11285 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
11287 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
11289 2002-06-27 Martin Baulig <martin@gnome.org>
11291 * ecore.cs (PropertyExpr.PropertyExpr): Call
11292 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
11294 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
11295 is already a TypeBuilder.
11297 2002-06-27 Martin Baulig <martin@gnome.org>
11299 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
11300 `target_type == TypeManager.array_type', not IsAssignableFrom() in
11301 the "from an array-type to System.Array" case. This makes it work
11302 when compiling corlib.
11304 2002-06-27 Martin Baulig <martin@gnome.org>
11306 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
11307 non-static PropertyExpr, set its InstanceExpression. This makes
11308 the `ICollection.Count' property work in System/Array.cs.
11310 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
11312 * driver.cs: Made error handling more consistent. Errors now
11313 tracked by Report class, so many methods which used to return int
11314 now return void. Main() now prints success/failure and
11315 errors/warnings message.
11317 Renamed '--probe' compiler argument to '--expect-error'. Removed
11318 the magic number return values (123 and 124). Now, if the
11319 expected error occurs, the compiler exits with success (exit value
11320 0). If the compilation completes without seeing that particular
11321 error, the compiler exits with failure (exit value 1). The
11322 makefile in mcs/errors has been changed to handle the new behaviour.
11324 * report.cs: Made 'expected error' number a property and renamed
11325 it from 'Probe' to 'ExpectedError'.
11327 * genericparser.cs: Removed error handling support, since it is
11328 now all done by Report class.
11330 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
11331 class, so parse() no longer returns an int.
11333 * namespace.cs: Use Report.Error instead of GenericParser.error
11335 2002-06-22 Miguel de Icaza <miguel@ximian.com>
11337 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
11338 TypeContainer.AddOperator): At the front of the list put the
11339 explicit implementations, so they get resolved/defined first.
11341 2002-06-21 Miguel de Icaza <miguel@ximian.com>
11343 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
11344 interface type is implemented by this TypeContainer. Used during
11345 explicit interface implementation.
11347 (Property.Define, Indexer.Define, Method.Define): Validate that
11348 the given interface in the explicit implementation is one of the
11349 base classes for the containing type.
11351 Also if we are explicitly implementing an interface, but there is
11352 no match in the pending implementation table, report an error.
11354 (Property.Define): Only define the property if we are
11355 not explicitly implementing a property from an interface. Use the
11356 correct name also for those properties (the same CSC uses,
11357 although that is really not needed).
11359 (Property.Emit): Do not emit attributes for explicitly implemented
11360 properties, as there is no TypeBuilder.
11362 (Indexer.Emit): ditto.
11364 Hiding then means that we do not really *implement* a pending
11365 implementation, which makes code fail.
11367 2002-06-22 Martin Baulig <martin@gnome.org>
11369 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
11370 the return value of Object.GetType(). [FIXME: we need to do this whenever
11371 we get a type back from the reflection library].
11373 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
11375 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
11377 2002-06-20 Miguel de Icaza <miguel@ximian.com>
11379 * attribute.cs: Return null if we can not look up the type.
11381 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
11382 the interface types found.
11384 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
11385 interface types found.
11387 * typemanager.cs (GetInterfaces): Make this routine returns alll
11388 the interfaces and work around the lame differences between
11389 System.Type and System.Reflection.Emit.TypeBuilder in the results
11390 result for GetInterfaces.
11392 (ExpandInterfaces): Given an array of interface types, expand and
11393 eliminate repeated ocurrences of an interface. This expands in
11394 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
11397 2002-06-21 Martin Baulig <martin@gnome.org>
11399 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
11402 2002-06-21 Martin Baulig <martin@gnome.org>
11404 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
11405 and called with one of the core types, return the corresponding typebuilder for
11408 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
11411 2002-06-21 Martin Baulig <martin@gnome.org>
11413 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
11414 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
11415 (Expression.ConvertReferenceExplicit): Likewise.
11417 * expression.cs (ElementAccess.DoResolve): Likewise.
11418 (ElementAccess.DoResolveLValue): Likewise.
11420 2002-06-10 Martin Baulig <martin@gnome.org>
11422 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
11423 add the "value" parameter to the parameter list.
11425 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
11428 2002-06-19 Miguel de Icaza <miguel@ximian.com>
11430 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
11431 the argument to an int, uint, long or ulong, per the spec. Also
11432 catch negative constants in array creation.
11434 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
11436 * class.cs: do not allow the same interface to appear twice in
11437 the definition list.
11439 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
11441 * ecore.cs: don't use ldlen with System.Array.
11443 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
11445 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
11447 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
11449 * modifiers.cs: produce correct field attributes for protected
11450 internal. Easy fix so miguel can work on ther harder stuff:-)
11452 2002-06-18 Miguel de Icaza <miguel@ximian.com>
11454 * pending.cs: New file. Move the code from class.cs here.
11455 Support clearning the pending flag for all methods (when not doing
11456 explicit interface implementation).
11458 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
11460 * rootcontext.cs: added a couple more types needed to bootstrap.
11462 2002-06-17 Miguel de Icaza <miguel@ximian.com>
11464 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
11465 constructor in the type, instead of any constructor in the type
11466 hierarchy. Thanks to Paolo for finding this bug (it showed up as
11467 a bug in the Mono runtime when applying the params attribute).
11469 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11470 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
11472 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
11474 * expression.cs (Unary.ResolveOperator): Use TypeManager
11475 to resolve the type.
11477 2002-06-13 Ravi Pratap <ravi@ximian.com>
11479 * cs-parser.jay (enum_member_declaration): Pass in the attributes
11482 * enum.cs (AddEnumMember): Add support to store the attributes associated
11483 with each member too.
11485 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
11486 field builders too - this takes care of the enum member case.
11488 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
11490 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
11491 address-of operator on both value types and pointers.
11493 2002-06-10 Martin Baulig <martin@gnome.org>
11495 * interface.cs (Interface.PopulateIndexer): Add the indexer's
11496 PropertyBuilder to the `property_builders' list.
11498 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
11499 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
11500 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
11501 find any indexers which are inherited from an interface.
11503 2002-06-09 Martin Baulig <martin@gnome.org>
11505 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
11506 the same type as the constant if necessary. There's also a test-130.cs
11509 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
11511 * typemanager.cs (TypeManager.ChangeType): Previously known as
11512 Enum.ChangeEnumType().
11514 2002-06-09 Martin Baulig <martin@gnome.org>
11516 * expression.cs (Cast.TryReduce): Added support for consts.
11518 2002-06-08 Ravi Pratap <ravi@ximian.com>
11520 * class.cs (Accessor): Hold attributes information so we can pass
11523 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
11524 Modify to pass in attributes attached to the methods.
11526 (add_accessor_declaration, remove_accessor_declaration): Ditto.
11528 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
11529 to handle the Accessor kind :-)
11531 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
11533 2002-06-08 Martin Baulig <martin@gnome.org>
11535 * expression.cs (Unary.TryReduceNegative): Added support for
11538 2002-06-08 Martin Baulig <martin@gnome.org>
11540 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
11541 name can't be found in the `defined_names' - the caller will do a
11542 MemberLookup in this case and thus find methods in System.Enum
11543 such as Enum.IsDefined().
11545 2002-06-08 Martin Baulig <martin@gnome.org>
11547 * enum.cs (Enum.ChangeEnumType): This is a custom version of
11548 Convert.ChangeType() which works with TypeBuilder created types.
11549 (Enum.LookupEnumValue, Enum.Define): Use it here.
11551 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
11552 `TypeBuilder.BaseType != null' check.
11553 (TypeContainer.FindMembers): Only lookup parent members if we
11554 actually have a parent.
11555 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11556 (ConstructorInitializer.Resolve): Likewise.
11558 * interface.cs (Interface.FindMembers): Added
11559 `TypeBuilder.BaseType != null' check.
11561 * rootcontext.cs (RootContext.ResolveCore): Added
11562 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11563 classes_second_stage.
11565 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11566 debug_type and trace_type when compiling with --nostdlib.
11568 2002-06-07 Martin Baulig <martin@gnome.org>
11570 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11571 (AddField): Set it to true when adding a non-static field.
11572 (DefineType): Use `have_nonstatic_fields' to find out whether we
11573 have non-static fields, not `Fields != null'.
11575 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11577 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11578 dereferencing a null on the static-field code path)
11580 2002-05-30 Martin Baulig <martin@gnome.org>
11582 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11583 to take command line arguments. Use reflection to call the new
11584 custom `Initialize' function on the symbol writer and pass it the
11585 command line arguments.
11587 * driver.cs (--debug-args): New command line argument to pass command
11588 line arguments to the symbol writer.
11590 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11592 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11593 the target type for indexers and properties. Thanks to Joe for
11596 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11598 * typemanager.cs (MethodFlags): returns the method flags
11599 (Obsolete/ShouldIgnore) that control warning emission and whether
11600 the invocation should be made, or ignored.
11602 * expression.cs (Invocation.Emit): Remove previous hack, we should
11603 not do this on matching a base type, we should do this based on an attribute
11605 Only emit calls to System.Diagnostics.Debug and
11606 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11607 on the command line.
11609 * rootcontext.cs: Global settings for tracing and debugging.
11611 * cs-tokenizer.cs (define): New utility function to track
11612 defines. Set the global settings for TRACE and DEBUG if found.
11614 2002-05-25 Ravi Pratap <ravi@ximian.com>
11616 * interface.cs (Populate*): Pass in the TypeContainer as well as
11617 the DeclSpace as parameters so that we can create EmitContexts and
11618 then use that to apply attributes etc.
11620 (PopulateMethod, PopulateEvent, PopulateProperty)
11621 (PopulateIndexer): Apply attributes everywhere.
11623 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11626 (ApplyAttributes): Update accordingly.
11628 We now apply interface attributes for all members too.
11630 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11632 * class.cs (Indexer.Define); Correctly check if we are explicit
11633 implementation (instead of checking the Name for a ".", we
11634 directly look up if the InterfaceType was specified).
11636 Delay the creation of the PropertyBuilder.
11638 Only create the PropertyBuilder if we are not an explicit
11639 interface implementation. This means that explicit interface
11640 implementation members do not participate in regular function
11641 lookups, and hence fixes another major ambiguity problem in
11642 overload resolution (that was the visible effect).
11644 (DefineMethod): Return whether we are doing an interface
11647 * typemanager.cs: Temporary hack until we get attributes in
11648 interfaces (Ravi is working on that) and we get IndexerName
11649 support in interfaces.
11651 * interface.cs: Register the indexers as properties.
11653 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11654 warning, I have verified that this is a bug in the .NET runtime
11655 (JavaScript suffers of the same problem).
11657 * typemanager.cs (MemberLookup): When looking up members for
11658 interfaces, the parent of an interface is the implicit
11659 System.Object (so we succeed in searches of Object methods in an
11660 interface method invocation. Example: IEnumerable x; x.ToString
11663 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11665 * class.cs (Event): Events should also register if they do
11666 implement the methods that an interface requires.
11668 * typemanager.cs (MemberLookup); use the new GetInterfaces
11671 (GetInterfaces): The code used to lookup interfaces for a type is
11672 used in more than one place, factor it here.
11674 * driver.cs: Track the errors at the bottom of the file, we kept
11677 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11678 instance if the method we are calling is static!
11680 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11682 * attribute.cs (ApplyAttributes): Make this function filter out
11683 the IndexerName attribute (as that attribute in reality is never
11684 applied) and return the string constant for the IndexerName
11687 * class.cs (TypeContainer.Emit): Validate that all the indexers
11688 have the same IndexerName attribute, and if so, set the
11689 DefaultName attribute on the class.
11691 * typemanager.cs: The return value might contain other stuff (not
11692 only methods). For instance, consider a method with an "Item"
11693 property and an Item method.
11695 * class.cs: If there is a problem with the parameter types,
11698 2002-05-24 Ravi Pratap <ravi@ximian.com>
11700 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11701 looks at user defined conversion after making a call to
11702 StandardConversionExists - we need this for overload resolution.
11704 * expression.cs : Update accordingly the various method calls.
11706 This fixes 2 bugs filed against implicit user defined conversions
11708 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11710 * statement.cs: Track the result of the assignment.
11712 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11714 * expression.cs (MemberAccess): Improved error reporting for
11715 inaccessible members.
11717 2002-05-22 Martin Baulig <martin@gnome.org>
11719 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11720 itself with debugging support.
11722 2002-05-22 Martin Baulig <martin@gnome.org>
11724 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11725 Removed, this isn't needed anymore.
11727 2002-05-20 Martin Baulig <martin@gnome.org>
11729 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11730 be underlying type for an enum.
11732 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11734 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11735 that splits out the loading of just the core types.
11737 * rootcontext.cs (ResolveCore): Split the struct resolution in
11738 two, so we can load the enumeration underlying types before any
11741 * expression.cs (Is): Bandaid until we fix properly Switch (see
11742 bug #24985 for details).
11744 * typemanager.cs (ImplementsInterface): The hashtable will contain
11745 a null if there are no interfaces implemented.
11747 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11749 * cs-parser.jay (indexer_declarator): It is fine to have array
11752 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11754 * typemanager.cs: (RegisterBuilder): New function used to register
11755 TypeBuilders that implement interfaces. Since
11756 TypeBuilder.GetInterfaces (as usual) does not work with lame
11758 (AddUserType): register interfaces.
11760 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11761 dealing with TypeBuilder. Also, arrays are showing up as
11762 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11763 methods can not be invoked on them!
11765 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11766 (ImplicitReferenceConversionExists): Split out from
11767 StandardConversionExists.
11769 * expression.cs (As): We were only implementing one of the three
11770 cases for the as operator. We now implement them all.
11771 (Is): Implement the various other cases for Is as well.
11773 * typemanager.cs (CACHE): New define used to control if we want or
11774 not the FindMembers cache. Seems to have a negative impact on
11775 performance currently
11777 (MemberLookup): Nested types have full acess to
11778 enclosing type members
11780 Remove code that coped with instance/static returns for events, we
11781 now catch this in RealFindMembers.
11783 (RealFindMembers): only perform static lookup if the instance
11784 lookup did not return a type or an event.
11786 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11788 * assign.cs (CompoundAssign): We pass more semantic information
11789 now to Compound Assignments than we did before: now we have all
11790 the information at hand, and now we resolve the target *before* we
11791 do the expression expansion, which allows the "CacheValue" method
11792 to have the effect we intended (before, a [x] += 1 would generate
11793 two differen ArrayAccess expressions from the ElementAccess,
11794 during the resolution process).
11796 (CompoundAssign.DoResolve): Resolve target and original_source here.
11798 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11800 * expression.cs (ArrayAccess): dropped debugging information.
11802 * typemanager.cs: Small bug fix: I was always returning i_members,
11803 instead of one of i_members or s_members (depending on which had
11806 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11807 method is invoked before any code generation takes place, and it
11808 is a mechanism to inform that the expression will be invoked more
11809 than once, and that the method should use temporary values to
11810 avoid having side effects
11812 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11814 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11817 * expression.cs (Indirection, ArrayAccess): Add support for
11818 CacheTemporaries in these two bad boys.
11820 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11821 ldobj or ldind_ref.
11822 (StoreFromPtr): Handle stobj as well.
11824 * expression.cs (UnaryMutator): Share more code.
11826 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11827 down: I was not tracking the Filter function as well, which
11828 was affecting the results of the cache.
11830 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11832 * attribute.cs: Remove the hack to handle the CharSet property on
11835 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11837 * attribute.cs (DoResolve): More uglyness, we now only try to
11838 resolve the attribute partially, to extract the CharSet
11839 information (only if we are a StructLayout attribute). Otherwise
11841 (GetExtraTypeInfo): Add some code to conditionally kill in the
11842 future this. I am more and more convinced that the .NET
11843 framework has special code to handle the attribute setting on
11846 * expression.cs (IsParamsMethodApplicable): Revert my previous
11847 foreach change here, it was wrong.
11849 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11851 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11852 (pp_expr): do not abort on unknown input, just return.
11853 (eval): abort if there are pending chars.
11855 * attribute.cs (Attribute.Resolve): Positional parameters are
11856 optional. Deal with that case.
11858 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11859 the Ansi/Unicode/Auto information for the type.
11861 (TypeContainer.DefineType): instantiate the EmitContext here, as
11862 we will be using it during the type definition (to resolve
11863 attributes) and during the emit phase.
11865 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11866 to pull type information out of the attributes
11868 (Attribute.Resolve): track the constructor builder, and allow for
11869 multiple invocations (structs and classes will use this).
11871 * ecore.cs (MemberLookupFinal): new version with all the
11872 parameters customizable.
11874 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11875 constructors. Return if the result value is null (as the error
11876 would have been flagged already by MemberLookupFinal)
11878 Do not allow instances of abstract classes or interfaces to be
11881 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11882 We have to compare the assembly property here when dealing with
11883 FamANDAssem and Assembly access modifiers, because we might be
11884 creating an assembly from *modules* (that means that we are not
11885 getting TypeBuilders for types defined in other modules that are
11886 part of this assembly).
11888 (Method.Emit): If the method is marked abstract and has a body,
11891 (TypeContainer.DefineMembers): If both the defined member and the
11892 parent name match are methods, then do not emit any warnings: let
11893 the Method.Define routine take care of flagging warnings. But if
11894 there is a mismatch (method overrides something else, or method is
11895 overriwritten by something, then emit warning).
11897 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11898 set to null, this means `do not check for the return type on the
11901 (Method.Define): set the return type for the method signature to
11902 null, so that we get methods with the same name and parameters and
11903 different return types. This is used to flag warning 114 (you are
11904 hiding a method, and you probably want to use the new/override
11907 * typemanager.cs (MemberLookup): Implemented proper access
11908 control, closing a long standing set of bug reports. The problem
11909 was that the Framework only has two bits: Public and NonPublic,
11910 and NonPublic includes private and protected methods, but we need
11911 to enforce the FamANDAssem, FamOrAssem and Family.
11913 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11915 * statement.cs (GotoCase): Return true: Ammounts to giving up
11916 knowledge on whether we return or not, and letting the other case
11917 be responsible for it.
11919 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11921 * driver.cs: Do not load directories for each file processed, only
11922 do it if there is a pattern.
11924 * ecore.cs: Report readonly assigns here as well, as we might have
11925 been resolved only by MemberAccess.
11927 (SimpleName.SimpleNameResolve): Also be useful for LValue
11928 resolution. We need this to propagate assign to local readonly variables
11930 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11931 do not want to reuse potential criteria memory.
11933 * class.cs (MyEventBuilder): Set reflected_type;
11935 * ecore.cs (Constantify): Added support for constifying bools.
11937 (RootContext.LookupType): Added a cache for values looked up in
11938 the declaration space.
11940 * typemanager.cs (FindMembers): Now is a front-end to
11941 RealFindMembers, and provides a two-level hashtable-based cache to
11944 15% performance improvement: from 22.5 to 19.2 seconds.
11946 * expression.cs (IsParamsMethodApplicable): use foreach.
11947 (Invocation.DoResolve): ditto.
11948 (New.DoResolve): ditto.
11949 (ArrayCreation.DoResolve): ditto.
11951 * ecore.cs (FindMostEncompassingType): use foreach.
11953 * delegate.cs (NewDelegate.DoResolve): Use foreach
11955 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11956 (RemoveMethods): use foreach.
11958 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11959 nested foreach statements instead of for, and also break out of
11960 the inner loop once a match is found.
11962 (Invocation.OverloadResolve): Use foreach, simplify the code.
11964 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11966 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11967 we actually unwrap the expression to allow for extra information
11970 * expression.cs: Use Shr_Un on unsigned operations.
11972 2002-05-08 Ravi Pratap <ravi@ximian.com>
11974 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11975 applicable operators was not being considered correctly. This closes
11976 the bug Miguel reported.
11978 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11980 * attribute.cs: check that the type derives from System.Attribute
11981 and report the correct error in that case (moved the duplicate code to
11982 its own method, too).
11984 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11986 * attribute.cs: lookup attribute type name as the spec says: first the
11987 bare attribute name and then name + "Attribute" (nant compiles with
11988 mcs after this fix).
11990 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11992 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11993 Because of the way we parse things, we should try to see if a
11994 UIntConstant can fit in an integer.
11996 2002-05-07 Ravi Pratap <ravi@ximian.com>
11998 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11999 when we are in an explicit context.
12001 (ConvertReferenceExplicit): When converting from Iface type S to Class
12002 T make sure the rules are implemented as an OR.
12004 * parameter.cs (ParameterType): Make it a property for now although the
12005 purpose really isn't anything immediate.
12007 * expression.cs (Is*Applicable): Do better checking on the parameter type
12008 of a ref/out parameter. The ones from the system assemblies are already
12009 marked with the correct type so we don't need to do any correction.
12011 * ecore.cs (StandardConversionExists): Conversion from Interface types to
12012 the object type is standard too so include that.
12014 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12016 * ecore.cs (StandardConversionExists): Augment with missing code:
12017 deal with IntConstant, LongConstants and Enumerations.
12019 * assign.cs: Report the error, instead of failing silently
12021 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
12022 typecontainer that they are declared, because the
12023 typecontainer/namespace will have the list of using clauses that
12024 need to be applied.
12026 Assembly Attributes were escaping the normal registration
12029 (EmitCode): Apply attributes within an EmitContext that represents
12030 the container they were declared on.
12032 * cs-parser.jay: Track bases for structs. How did I get this wrong?
12034 2002-05-06 Ravi Pratap <ravi@ximian.com>
12036 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
12037 Revamp completely - make much cleaner as we now operate only
12040 (FindMostSpecificSource, FindMostSpecificTarget): New methods
12041 to implement the logic detailed in the spec more correctly.
12043 (UserDefinedConversion): Update accordingly.
12045 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12047 * statement.cs: Return flow analysis information up.
12049 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
12052 (token): Do not consume an extra character before calling
12055 2002-05-06 Piers Haken <piersh@friskit.com>
12057 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
12059 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12061 * class.cs (Constructor.Emit): Set the IsStatic flag in the
12062 EmitContext during the instance constructor initializer
12063 resolution, to stop access to instance variables.
12065 This is mandated by the spec, last paragraph of the `constructor
12066 initializers' section.
12068 2002-05-05 Miguel de Icaza <miguel@ximian.com>
12070 * cs-parser.jay, class.cs (Accessor): new class used to represent
12071 an accessor (get or set). In the past we used `null' to represent
12072 a missing accessor. But this is ambiguous because there was no
12073 way to tell in abstract indexers/properties if one of them was
12076 Now there is a way of addressing that.
12078 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
12079 instead of FindMembers.
12081 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
12082 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
12084 * attribute.cs: Treat indexers and properties as the same in terms
12085 of applying attributes
12087 * ecore.cs (FindMostEncompassedType): Use statically initialized
12088 EmptyExpressions()s like we do elsewhere to avoid creating useless
12089 objects (and we take this out of the tight loop).
12091 (GetConversionOperators): Move the code to extract the actual
12092 operators to a separate routine to clean things up.
12094 2002-05-04 Miguel de Icaza <miguel@ximian.com>
12096 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
12097 events are always registered FieldBuilders.
12099 * class.cs (FieldBase): New class shared by Fields
12101 * delegate.cs: If we are a toplevel delegate, use our full name.
12102 If we are a nested delegate, then only use our tail name.
12104 2002-05-02 Ravi Pratap <ravi@ximian.com>
12106 * expression.cs (IsApplicable): Ensure that we add the "&" to
12107 ref/out types before comparing it with the type of the argument.
12109 (IsParamsMethodApplicable): Ditto.
12111 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
12114 * delegate.cs : Handle the case when we have more than one applicable
12115 method. Flag an error only when we finish checking all.
12117 2002-05-02 Miguel de Icaza <miguel@ximian.com>
12119 * expression.cs: Add support for boolean static initializers.
12121 2002-05-01 Miguel de Icaza <miguel@ximian.com>
12123 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
12125 * parameter.cs (ComputeParameterTypes,
12126 ComputeAndDefineParameterTypes): Better error handling: now we
12127 clear the `types' cache if we fail during any of the type lookups.
12128 We also return the status code correctly to our caller
12130 * delegate.cs: If we fail to define a delegate, abort the extra
12133 * expression.cs (Binary.ResolveOperator): for
12134 operator==(object,object) and operator !=(object, object) we also
12135 have to verify that there is an implicit conversion from one to
12138 (ArrayAccess.DoResolve): Array Access can operate on
12141 2002-04-30 Miguel de Icaza <miguel@ximian.com>
12143 * assign.cs (CompoundAssign): A new class used as a "flag" that
12144 the assignment actually is happening as part of a compound
12145 assignment operator.
12147 During compound assignment, a few new rules exist to enable things
12154 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
12155 to the type of x) if y is implicitly convertible to the type of x,
12156 and the operator is a builtin operator and the return type of the
12157 operator is explicitly convertible to the type of x.
12159 * rootcontext.cs: Reset warning level to 2. 4 catches various
12160 "interesting" features in mcs, we must clean this up at some
12161 point, but currently am trying to kill other bugs ;-)
12163 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
12164 in container classes as well.
12166 * expression.cs (Binary.ResolveOperator): Handle string case
12167 before anything else (as operator overloading does emit an error
12168 before doing anything else).
12170 This code could go away when we move to a table driven model, but
12171 i could not come up with a good plan last night.
12173 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
12175 * typemanager.cs (CSharpName): reimplementation using regex.
12176 * class.cs: added null check for fields in Emit
12177 * rootcontext.cs: set warninglevel to 4
12179 2002-04-29 Miguel de Icaza <miguel@ximian.com>
12181 * typemanager.cs (CSharpName): reimplemented with Lupus
12184 2002-04-28 Miguel de Icaza <miguel@ximian.com>
12186 * statement.cs (If): correclty implement Resolve, because we were
12187 not catching sem errors in there. The same process is needed
12189 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
12192 (Statement.Warning_DeadCodeFound): Factorize code.
12193 (While): Report dead code here too.
12195 (Statement): Added Resolve virtual method to allow
12196 for resolution split from the emit code.
12198 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12200 * statement.cs (EmitBoolExpression): No longer try to resolve the
12202 (MakeBoolean): New utility function that resolve, implicitly
12203 converts to boolean and tags the expression.
12206 (If, Do): Implement dead code elimination.
12207 (While): Implement loop inversion
12209 (Do, While, For, If): Resolve the expression prior to calling our
12212 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
12215 - added method Report28 (warning: program has more than one entry point)
12216 - added method IsEntryPoint, implements paragraph 10.1 of the spec
12217 - modified method Method.Define, the part at the end of the method
12219 * rootcontext.cs: added static public Location EntryPointLocation;
12221 * ../errors/cs0028.cs : Add test case for the above warning.
12224 - modified method CSharpName to allow arrays of primitive type to
12225 be printed nicely (e.g. instead of System.Int32[][] it now prints
12227 - added method CSharpSignature: returns the signature of a method
12228 in string format to be used in reporting errors, warnings, etc.
12230 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
12233 2002-04-26 Ravi Pratap <ravi@ximian.com>
12235 * delegate.cs (Define): Fix extremely silly bug where I was
12236 setting the type of the 'object' parameter of the BeginInvoke
12237 method to System.IAsyncResult instead of System.Object ;-)
12239 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12241 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
12244 (Constructor.Emit): return if we fail to initialize the
12245 constructor. Another door closed!
12247 * expression.cs (New.DoResolve): Improve error message (from -6 to
12248 1501). Use DeclaredOnly lookup to find the exact constructor.
12250 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
12251 loop. This is useful.
12253 * cs-parser.jay: Adjust the default parameters so that destructors
12254 have the proper signature.
12256 2002-04-26 Martin Baulig <martin@gnome.org>
12258 * driver.cs (LoadAssembly): If `assembly' contains any characters
12259 which are only valid in path names and not in assembly names
12260 (currently slash, backslash and point), use Assembly.LoadFrom ()
12261 instead of Assembly.Load () on the `assembly' (before iteration
12262 over the link_paths).
12264 2002-04-26 Martin Baulig <martin@gnome.org>
12266 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
12268 2002-04-25 Miguel de Icaza <miguel@ximian.com>
12270 * class.cs (Property): use the new typemanager.MemberLookup
12272 (TypeContainer.MemberLookup): Implement using the
12273 TypeManager.MemberLookup now.
12275 * typemanager.cs: Make MemberLookup a function of the TypeManager,
12276 and return MemberInfos, so that these can be used without an
12277 EmitContext (what we had before).
12279 2002-04-24 Miguel de Icaza <miguel@ximian.com>
12281 * expression.cs: Fix the case where the argument to params if the
12282 type of the params. I omitted handling this before. Fixed
12284 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12286 * driver.cs: Call BootCorlib_PopulateCoreType
12288 * class.cs (Property.CheckBase): Check for properties only, not
12291 * interface.cs: Temporary hack: try/catch around the
12292 CustomAttributeBuilder, because I am getting an exception that I
12295 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
12296 types whose definitions are required to be there (attributes are
12297 defined before standard types).
12299 Compute definitions as we boot the various types, as they are used
12300 immediately (value_type class will need object_type, but if we do
12301 not initialize object_type, we will pass a null, which will let
12302 the runtime pick the System.Object from the existing corlib, which
12303 is not what we want).
12305 2002-04-22 Patrik Torstensson <totte@labs2.com>
12307 * cs-tokenizer.cs: fixed a number of trim() issues.
12309 2002-04-22 Ravi Pratap <ravi@ximian.com>
12311 * expression.cs (Argument.Type): Ensure that we return the correct
12312 type when we have out or ref parameters [in which case we
12315 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12317 * class.cs (Property, Indexer): Allow extern modifier in there.
12319 * typemanager.cs (InitBaseTypes): Initializes object_type and
12320 value_type, since those will be used early on during the bootstrap
12321 process to compile corlib.
12323 (InitCoreTypes): Move code from here to InitBaseTypes.
12325 2002-04-21 Miguel de Icaza <miguel@ximian.com>
12327 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
12328 single-dimension arrays as using the ldlen opcode.
12330 Daniel Lewis discovered this optimization.
12332 * typemanager.cs: Add signature for System.Array::get_Length
12334 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12336 * statement.cs: report the error when the foreach does not apply to an
12337 array nor a collection.
12339 2002-04-19 Miguel de Icaza <miguel@ximian.com>
12341 * expression.cs: Add implicit conversions to the operator ~.
12343 * constant.cs (DecimalConstant.Emit): Emit decimal value.
12345 * typemanager.cs: Locate the decimal constructor.
12347 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12349 * attribute.cs: use the new property of TypeOf.
12350 * expression.cs: added 'get' property around typearg.
12352 These changes fix a build breaker reported by NickD. Is this the
12353 correct way to fix? If not, please, revert my changes and make it
12356 2002-04-17 Miguel de Icaza <miguel@ximian.com>
12358 * attribute.cs: Add support for typeof in attribute invocations.
12359 I am not sure that this is right though.
12361 2002-04-14 Duncan Mak <duncan@ximian.com>
12363 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
12364 Binary.Operator.Division case.
12366 2002-04-13 Ravi Pratap <ravi@ximian.com>
12368 * class.cs (DefineType): Ensure that we do a proper check on
12369 attribute types and also register it with the TypeManager.
12371 (TypeContainer.Targets): The default for attribute types is
12372 AttributeTargets.All.
12374 * attribute.cs (ApplyAttributes): Registering the attribute type
12375 is done elsewhere, not when we discover we have a Usage attribute.
12377 2002-04-12 Ravi Pratap <ravi@ximian.com>
12379 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
12380 and get rid of is_delegate parameter.
12382 * everywhere : update.
12384 2002-04-12 Ravi Pratap <ravi@ximian.com>
12386 * cs-parser.jay (compilation_unit): Revamp completely to use
12387 some new ideas that I got from Rhys' grammar to solve the problems
12388 with assembly level attributes.
12390 (outer_declaration): New grammar production.
12392 (attribute_sections): Add.
12394 (opt_attributes): Base on attribute_sections
12396 (namespace_declaration): Allow opt_attributes to tackle the case
12397 when we have assembly level attributes - we are clever in this
12400 * attribute.cs (ApplyAttributes): Do not worry about assembly
12401 attributes in the non-global context.
12403 * rootcontext.cs (AddGlobalAttributes): Go back to using this
12404 instead of SetGlobalAttributes.
12406 * class.cs, rootcontext.cs : Ensure we define and generate
12407 attribute types before anything else.
12409 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
12410 and flag the new error -20 for the case when the attribute type
12411 does not have valid targets specified. csc does not catch this.
12413 * ../errors/errors.txt : update for error # -20
12415 2002-04-11 Ravi Pratap <ravi@ximian.com>
12417 * support.cs (InternalParameters.ParameterModifier): Do some null
12418 checking and return sane values.
12420 * class.cs (Method.Define): If we are a PInvoke method, ensure
12421 that we are static and extern. Report error # 601
12423 * ../errors/cs0601.cs : Add test case for the above error.
12425 2002-04-07 Ravi Pratap <ravi@ximian.com>
12427 * rootcontext.cs (attribute_types): We need to keep type of
12428 all attribute types separately and emit code for them first.
12430 (RegisterAttribute) : Implement.
12432 * class.cs (DefineType): Check if the current Type is a custom
12433 attribute type and register it accordingly.
12435 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
12436 adding the first attribute twice and rename to
12438 (SetGlobalAttributes): this.
12440 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
12443 * attribute.cs (ApplyAttributes): Take an additional argument telling us
12444 if we are processing global arguments. Hmm, I am unsure of this.
12446 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12448 * expression.cs: added static array of strings to avoid calling
12449 Enum.ToString () for Operator in Binary. Significant recover of
12452 2002-04-10 Miguel de Icaza <miguel@ximian.com>
12454 * class.cs (FindMembers): Allow the Builders of the various
12455 members to be null. If they are skip them. This only happens
12456 during the PInvoke declaration.
12458 2002-04-09 Miguel de Icaza <miguel@ximian.com>
12460 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
12461 failure, so we do not keep going afterwards.
12463 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
12464 wanted to pass `false' as the `is_delegate' argument. If this is
12465 the case, why not use delegate_type == null to mean `is_delegate =
12466 false' and anything else as is_delegate = true.
12468 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
12470 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
12471 code for the section, not the beginning of the tests.
12473 2002-04-08 Miguel de Icaza <miguel@ximian.com>
12475 * cfold.cs: Handle operator + (Enum x, Underlying x)
12477 * expression.cs (Binary): same. Warn about errors where we have
12478 Enum/Enum in operator + as well.
12480 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
12483 - added support for switch(bool)
12484 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
12485 - add TableSwitchEmit() to handle table-based switch statements
12487 2002-04-05 Ravi Pratap <ravi@ximian.com>
12489 * expression.cs (Invocation.OverloadResolve): Factor out code which
12490 does parameter compatibility checking with arguments so that we can
12491 re-use the code even from Delegate.VerifyApplicability
12493 (VerifyArgumentsCompat): Move above code here.
12495 * delegate.cs (VerifyApplicability): Get rid of duplicate code
12496 and instead make a call to the above method.
12498 2002-03-31 Ravi Pratap <ravi@ximian.com>
12500 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
12501 We use it to keep track of classes which are attribute types.
12503 2002-04-02 Miguel de Icaza <miguel@ximian.com>
12505 * delegate.cs (Delegate.Define): Correctly define the types in the
12506 presence of fixed and array parameters.
12508 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
12511 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
12512 include NonPublic after the first iteration.
12514 * class.cs (Indexer.CheckBase): Only check if both parents are
12517 * cs-parser.jay (accessor_body): If empty, set to null.
12519 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
12520 same code path here to resolve constants names that we did have in
12521 MemberAccess.DoResolve. There is too much code duplicated here.
12523 2002-04-01 Miguel de Icaza <miguel@ximian.com>
12525 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
12527 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
12530 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
12531 tokens, numbers and strings.
12533 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
12536 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
12537 asyncronous parameters and the regular parameters.
12539 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
12540 specify the target directory.
12542 * expression.cs: (This.DoResolve): Simplify
12543 (As.Emit): Optimize, do not generate IsInst if the expression is
12544 always of the given type.
12546 (Is.DoResolve): Bug fix, we were reporting both always/never for
12549 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
12550 creating too many unnecessary arrays.
12552 2002-03-31 Miguel de Icaza <miguel@ximian.com>
12554 * class.cs (EmitFieldInitializer): Use Assign expression to assign
12555 fields instead of rolling our own initializer. Takes care of all
12556 implicit conversions, and drops unnecessary static checks/argument.
12558 2002-03-31 Dick Porter <dick@ximian.com>
12560 * driver.cs: use the GetDirectories() return values properly, and
12561 use "/" as path separator.
12563 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12565 * expression.cs (Unary): Optimize - - expr into expr.
12566 (Binary): Optimize a + (-b) into a -b.
12568 * codegen.cs (CodeGen): Made all methods static.
12570 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12574 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12575 TypeBuilder property.
12577 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12580 * tree.cs: Removed the various RecordXXXX, and replaced with a
12581 single RecordDecl. Removed all the accessor methods, and just
12582 left a single access point Type
12584 * enum.cs: Rename DefineEnum to DefineType.
12586 * decl.cs: New abstract method `DefineType' used to unify the
12587 Defines for Enumerations, Interfaces, TypeContainers and
12590 (FindType): Moved LookupInterfaceOrClass here. Moved the
12591 LookupBaseClasses method that used to live in class.cs and
12592 interface.cs here, and renamed to FindType.
12594 * delegate.cs: Implement DefineType. Take advantage of the
12595 refactored pattern for locating the parent builder without taking
12596 the parent_builder argument (which we know does not work if we are
12597 nested, and triggering a toplevel definition).
12599 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12601 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12602 accessibility of a member has changed during override and report
12605 * class.cs (Method.Define, Property.Define): Only complain on
12606 overrides if the method is private, any other accessibility is
12607 fine (and since we just checked the permission is the same, we are
12610 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12611 and elif are processed always. The other pre-processing
12612 directives are only processed if we are "taking" the path
12614 2002-03-29 Martin Baulig <martin@gnome.org>
12616 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12617 current location is not Null.
12619 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12620 a separate method so we can profile it.
12622 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12623 `span.Seconds' are just seconds, but no minutes or hours.
12624 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12626 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12628 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12629 Remove the gratuitous set of Final:
12631 // If an interface implementation, then we can set Final.
12632 if (((flags & MethodAttributes.Abstract) == 0) &&
12633 implementing.DeclaringType.IsInterface)
12634 flags |= MethodAttributes.Final;
12636 I do not know what I was smoking when I used that.
12639 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12640 step into fixing the name resolution issues for delegates and
12641 unifying the toplevel name resolution.
12643 2002-03-28 Martin Baulig <martin@gnome.org>
12645 * class.cs (Method.Emit): If we have a symbol writer, call its
12646 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12647 tell it about the current method.
12649 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12650 writer that we're going to emit the first byte of IL code for a new
12651 statement (a new source line).
12652 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12653 EmitContext.Mark() before emitting any code.
12655 * location.cs (SymbolDocument): Return null when we're Null.
12657 * statement.cs (Statement): Moved the `Location loc' variable here.
12658 (Statement.EmitBoolExpression): If we have a symbol writer, call
12659 ec.Mark() before emitting any code to tell it that we're at the
12660 beginning of a new statement.
12661 (StatementExpression): Added `Location' argument to the constructor.
12662 (Block): Added public readonly variable `StartLocation' and public
12663 variable `EndLocation'. The latter is to be set using SetEndLocation().
12664 (Block): Added constructor which takes a start and end location.
12665 (Block.SetEndLocation): New method. This sets the end location.
12666 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12667 local variables we create.
12668 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12669 each statement and do also mark the begin and end of the block.
12671 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12672 tell it the current lexer.Location, use Location.Null for the end of the
12674 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12675 current block, set its end location using SetEndLocation().
12676 (statement_expression): StatementExpression constructor now takes the
12677 lexer.Location as additional argument.
12678 (for_statement, declare_local_variables): Likewise.
12679 (declare_local_variables): When creating a new implicit block, use the
12680 new Block constructor and pass it the lexer.Location.
12682 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12684 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12685 members also on the parent interfaces recursively.
12687 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12689 * report.cs: Use new formats, since Gonzalo finished the missing
12692 * expression.cs (Binary.ResolveOperator): added missing operator|
12693 operator& and operator^ for bool/bool.
12695 * cs-parser.jay: CheckDef now takes a Location argument that is
12696 used to report errors more precisly (instead of reporting the end
12697 of a definition, we try to track something which is a lot closer
12698 to the source of the problem).
12700 * cs-tokenizer.cs: Track global token use, so we can properly flag
12701 the use of #define/#undef after the first token has been seen.
12703 Also, rename the reportXXXX to Error_DescriptiveName
12705 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12706 TypeContainer, so that Enum and Interface can use this too.
12708 * class.cs (TypeContainer.LookupInterfaceOrClass,
12709 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12710 `builder' argument. Typically this was used to pass the parent
12711 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12714 The problem is that a nested class could trigger the definition of
12715 a toplevel class, and the builder would be obviously wrong in that
12718 So we drop this argument, and we compute dynamically the
12719 TypeBuilder/ModuleBuilder (the correct information was available
12720 to us anyways from DeclSpace.Parent)
12722 * interface.cs (Interface.DefineInterface): Drop builder
12723 parameter cleanup like class.cs
12725 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12728 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12731 (Try.Emit): Propagate the returns value from the statement.
12733 (Return.Emit): Even if we are leavning
12735 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12737 * modifiers.cs: Fix the computation of MethodAttributes flags.
12739 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12741 * driver.cs: allow compilation of files that start with '/'.
12742 Add a default case when checking the argument of --target.
12744 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12746 * interface.cs: Implement the same search algorithm for types in
12747 the interface code.
12749 * delegate.cs: Do not allow multiple definition.
12751 * Recovered ChangeLog that got accidentally amputated
12753 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12755 * rootcontext.cs: Load manually enum to allow core classes to
12756 contain enumerations.
12758 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12759 Update to new static methods in TypeManager.
12761 * typemanager.cs (GetMethod, GetConstructor): Use our
12762 implementation of FindMembers to find the members, since during
12763 corlib compilation, the types are TypeBuilders and GetMethod and
12764 GetConstructor do not work.
12766 Make all methods in TypeManager static.
12768 (InitCodeHelpers): Split the functionality from
12769 the InitCodeTypes function.
12771 * driver.cs: Call InitCodeHelpers after we have populated the
12774 * cs-parser.jay (delegate_declaration): we did not used to compute
12775 the delegate name correctly for void delegates.
12777 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12779 * rootcontext.cs (RootContext): Init the interface_resolve_order
12780 and type_container_resolve_order always.
12782 (ResolveCore, BootstrapCorlib_ResolveClass,
12783 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12784 compiler when compiling with --nostdlib
12786 * class.cs (TypeContainer.DefineType): Check that our parent is
12787 not null. This test is most important when we are bootstraping
12790 * codegen.cs: Split out the symbol writing code.
12792 2002-03-25 Martin Baulig <martin@gnome.org>
12794 * driver.cs (-g): Made -g an alias for --debug.
12796 2002-03-24 Martin Baulig <martin@gnome.org>
12798 * codegen.cs (SymbolWriter): New public variable. Returns the
12799 current symbol writer.
12800 (CodeGen): Added `bool want_debugging_support' argument to the
12801 constructor. If true, tell the ModuleBuild that we want debugging
12802 support and ask it for the ISymbolWriter.
12803 (Save): If we have a symbol writer, call it's Close() method after
12804 saving the assembly.
12806 * driver.c (--debug): New command line argument to create a
12807 debugger information file.
12809 * location.cs (SymbolDocument): New public property. Returns an
12810 ISymbolDocumentWriter object for the current source file or null
12811 if we don't have a symbol writer.
12813 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12815 * driver.cs (LoadAssembly): Correctly return when all the paths
12816 have been tried and not before.
12818 * statement.cs (Switch.Emit): return the actual coverage for this
12819 statement (returns/not-returns)
12821 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12822 switch of the statement if we are the last switch section. That
12823 kills two problems: try/catch problems (we used to emit an empty
12824 nop at the end) and switch statements where all branches would
12827 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12829 * driver.cs: Add default assemblies (the equivalent to the
12830 Microsoft CSC.RSP file)
12832 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12833 also update tokens_seen and set it to false.
12835 * driver.cs: Implement --recurse for Mike.
12837 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12838 correctly splitting out the paths.
12840 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12842 * interface.cs (Interface.PopulateProperty): Instead of using
12843 `parent' as the declaration space for the set parameters, use
12846 * support.cs (InternalParameters): InternalParameters constructor
12847 takes a DeclSpace instead of a TypeContainer.
12849 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12850 types are being initialized, load the address of it before calling
12853 (New): Provide a mechanism to disable the generation of local
12854 value type temporaries when the caller will be providing us with
12855 an address to store it.
12857 (ArrayCreation.EmitDynamicInitializers): Use it.
12859 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12861 * expression.cs (Invocation.EmitArguments): Only probe for array
12862 property if there is more than one argument. Sorry about that.
12864 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12865 empty param arrays.
12867 * class.cs (Method.LabelParameters): Fix incorrect code path that
12868 prevented the `ParamArrayAttribute' from being applied to the
12871 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12873 * support.cs (ReflectionParameters): Correctly compute whether the
12874 last argument is a params array. Fixes the problem with
12877 * typemanager.cs: Make the assemblies array always be non-null
12878 (empty, but non-null)
12880 * tree.cs (RecordDecl): New function that abstracts the recording
12881 of names. This reports error 101, and provides a pointer to the
12882 previous declaration. Fixes a crash in the compiler.
12884 * cs-parser.jay (constructor_declaration): Update to new grammar,
12885 and provide a constructor_body that can be empty.
12887 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12889 * driver.cs: Add support for --resources.
12891 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12892 Make all types for the various array helper methods be integer.
12894 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12895 CheckState to ConvCast.
12897 (ConvCast): Now it takes a `checked' state argument, to avoid
12898 depending on the emit context for the conversion, and just using
12899 the resolve time setting.
12901 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12902 instead of Invocation.EmitArguments. We do not emit the original
12903 arguments, instead we emit those which have been converted to
12904 unsigned int expressions.
12906 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12908 * codegen.cs: ditto.
12910 * expression.cs (LocalVariableReference): Drop the use of the
12911 Store function that depended on the variable index.
12913 * statement.cs (VariableInfo): Drop the `Idx' property from this
12914 class, as this is not taking into account the indexes for
12915 temporaries tat we generate during the execution, getting the
12918 * class.cs: First emit class initializers, then call the parent
12921 * expression.cs (Binary): Fix opcode emision.
12922 (UnaryMutator.EmitCode): Support checked code generation
12924 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12925 matches for events for both the Static and Instance scans,
12926 pointing to the same element. Fix that.
12928 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12930 * rootcontext.cs (ResolveTree): Always set the
12931 interface_resolve_order, because nested interfaces will be calling
12934 * class.cs (GetInterfaceOrClass): Track the same resolution
12935 process used by TypeManager.LookupType. This fixes the nested
12936 type lookups in class declarations (separate path from
12939 (TypeContainer.DefineType): Also define nested interfaces.
12940 (TypeContainer.RegisterOrder): New public function used to
12941 register the order in which child interfaces need to be closed.
12943 Nested interfaces need to be closed after their parents have been
12946 * interface.cs (InterfaceAttr): Put all the logic for computing
12947 the interface attribute here.
12949 (DefineInterface): Register our interface order with the
12950 RootContext or with the TypeContainer depending on the case.
12952 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12954 * cs-parser.jay: rework foreach statement to work with the new
12955 changes to the policy on SimpleNames.
12957 * report.cs: support Stacktrace on warnings as well.
12959 * makefile: drop --unsafe and /unsafe from the compile.
12961 2002-03-13 Ravi Pratap <ravi@ximian.com>
12963 * ecore.cs (StandardConversionExists): Modify to take an Expression
12964 as the first parameter. Ensure we do null -> reference type conversion
12967 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12968 temporary Expression objects.
12970 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12972 * interface.cs: workaround bug in method overloading resolution
12973 (there is already a bugzilla bug for it).
12975 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12977 We could also solve this problem by having a separate path for
12978 performing type lookups, instead of DoResolve, we could have a
12979 ResolveType entry point, and only participating pieces of the
12980 production (simplename, deref, array) would implement this.
12982 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12983 signal SimpleName to only resolve type names and not attempt to
12984 resolve anything else.
12986 * expression.cs (Cast): Set the flag.
12988 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12990 * class.cs: Only report 108 if there is no `new' modifier.
12992 * cs-parser.jay: rework foreach statement to work with the new
12993 changes to the policy on SimpleNames.
12995 * report.cs: support Stacktrace on warnings as well.
12997 * makefile: drop --unsafe and /unsafe from the compile.
12999 2002-03-11 Miguel de Icaza <miguel@ximian.com>
13001 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
13002 lookups here, instead of doing that at parse time. This means
13003 that our grammar will not introduce `LocalVariableReferences' as
13004 expressions at this point. That solves the problem of code like
13008 static void Main ()
13012 This is only half the fix. The full fix requires parameters to
13013 also be handled in this way.
13015 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
13016 makes the use more obvious of the DeclSpace. The
13017 ec.TypeContainer.TypeBuilder is now only used to pull the
13018 TypeBuilder for it.
13020 My theory is that I can get rid of the TypeBuilder completely from
13021 the EmitContext, and have typecasts where it is used (from
13022 DeclSpace to where it matters).
13024 The only pending problem is that the code that implements Aliases
13025 is on TypeContainer, and probably should go in DeclSpace.
13027 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
13028 lookups here, instead of doing that at parse time. This means
13029 that our grammar will not introduce `LocalVariableReferences' as
13030 expressions at this point. That solves the problem of code like
13034 static void Main ()
13038 This is only half the fix. The full fix requires parameters to
13039 also be handled in this way.
13041 * class.cs (Property.DefineMethod): When implementing an interface
13042 method, set newslot, when implementing an abstract method, do not
13043 set the flag (before we tried never setting it, or always setting
13044 it, which is the difference).
13045 (Indexer.DefineMethod): same.
13046 (Method.DefineMethod): same.
13048 * ecore.cs: Only set the status used flag if we get back a Field.
13050 * attribute.cs: Temporary hack, so Paolo can keep working.
13052 2002-03-08 Ravi Pratap <ravi@ximian.com>
13054 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
13055 the unmanaged type in the case we have a MarshalAs attribute.
13057 (Resolve): Handle the case when we are parsing the special MarshalAs
13058 attribute [we need to store the unmanaged type to use later]
13060 * typemanager.cs (marshal_as_attr_type): Built in type for the
13061 MarshalAs Attribute.
13063 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
13064 on parameters and accordingly set the marshalling info.
13066 2002-03-09 Miguel de Icaza <miguel@ximian.com>
13068 * class.cs: Optimizing slightly by removing redundant code after
13069 we switched to the `NoTypes' return value.
13070 (Property.DefineMethod): use NoTypes here too.
13072 This fixes the bug I introduced in my last batch of changes.
13074 2002-03-05 Ravi Pratap <ravi@ximian.com>
13076 * tree.cs (RecordEnum): Add. We now keep track of enums too.
13078 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
13079 Enums since those are types too.
13081 * cs-parser.jay (enum_declaration): Record enums as we parse them.
13083 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
13084 thanks to a call during the lookup process.
13086 2002-03-07 Miguel de Icaza <miguel@ximian.com>
13088 * statement.cs (Foreach): Lots of work to accomodate a particular
13089 kind of foreach statement that I had not kept in mind. It is
13090 possible to have foreachs on classes that provide a GetEnumerator
13091 method that return objects that implement the "pattern" for using
13092 a foreach, there is no need to support GetEnumerator
13095 This is needed to compile nant.
13097 * decl.cs: Only report 114 if the member is not `Finalize' and if
13098 the warning level is at least 2.
13100 * class.cs: Moved the compare function from Method to
13103 (MethodSignature.InheritableMemberSignatureCompare): Add new
13104 filter function that is used to extract inheritable methods from a
13107 (Method.Define): Use the new `inheritable_method_signature_filter'
13110 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
13113 2002-03-06 Miguel de Icaza <miguel@ximian.com>
13115 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
13117 * cs-parser.jay: Add opt_semicolon to the interface declaration.
13119 * expression.cs: Pass location information to
13120 ConvertImplicitStandard.
13122 * class.cs: Added debugging code to track return values from
13125 2002-03-05 Miguel de Icaza <miguel@ximian.com>
13127 * expression.cs (Is.DoResolve): If either side of the `is' is an
13128 interface, do not flag the warning.
13130 * ecore.cs (ImplicitReferenceConversion): We need a separate test
13133 * report.cs: Allow for --fatal to be used with --probe.
13135 * typemanager.cs (NoTypes): Move the definition for the empty Type
13138 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
13140 (TypeContainer.DefineProxy): New function used to proxy to parent
13141 implementations when implementing interfaces.
13142 (TypeContainer.ParentImplements): used to lookup if our parent
13143 implements a public function that is required by an interface.
13144 (TypeContainer.VerifyPendingMethods): Hook this up.
13146 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
13147 `modules' and `assemblies' arraylists into arrays. We only grow
13148 these are the very early start up of the program, so this improves
13149 the speedof LookupType (nicely measured).
13151 * expression.cs (MakeByteBlob): Replaced unsafe code with
13152 BitConverter, as suggested by Paolo.
13154 * cfold.cs (ConstantFold.Binary): Special case: perform constant
13155 folding of string concatenation, but if either side is a string,
13156 and the other is not, then return null, and let the runtime use
13157 the concatenation on the string plus the object (using
13158 `Object.ToString').
13160 2002-03-04 Miguel de Icaza <miguel@ximian.com>
13162 Constant Folding has been implemented now.
13164 * expression.cs (Unary.Reduce): Do not throw an exception, catch
13165 the error instead on types that are not supported in one's
13168 * constant.cs (Constant and all children): New set of functions to
13169 perform implict and explicit conversions.
13171 * ecore.cs (EnumConstant): Implement the new functions to perform
13172 conversion by proxying to the child expression.
13174 * codegen.cs: (ConstantCheckState): Constant evaluation has its
13175 own separate setting that can not be turned off from the command
13176 line using --unchecked or --checked and is only controlled using
13177 the checked/unchecked statements and expressions. This setting is
13178 used by the constant folder to flag errors.
13180 * expression.cs (CheckedExpr, UncheckedExpr): Set the
13181 ConstantCheckState as well.
13183 During Resolve, they also have to flag the state, because the
13184 constant folder runs completely in the Resolve phase.
13186 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
13189 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13191 * cfold.cs: New file, this file contains the constant folder.
13193 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
13194 argument to track whether we are using the resulting address to
13195 load or store a value and provide better error messages.
13197 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
13198 new AddressOf arguments.
13200 * statement.cs (Foreach.EmitCollectionForeach): Update
13202 * expression.cs (Argument.Emit): Call AddressOf with proper
13203 arguments to track usage.
13205 (New.DoEmit): Call AddressOf with new arguments.
13207 (Unary.Emit): Adjust AddressOf call.
13209 2002-03-01 Ravi Pratap <ravi@ximian.com>
13211 * cs-parser.jay (member_access): Change the case for pre-defined types
13212 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
13215 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
13218 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
13219 essentially like methods and apply attributes like MethodImplOptions to them too.
13221 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
13224 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
13225 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
13228 * Update code everywhere accordingly.
13230 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
13232 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
13234 2002-02-28 Ravi Pratap <ravi@ximian.com>
13236 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
13237 try performing lookups against those instead of jumping straight into using
13238 the 'using' clauses.
13240 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
13242 (LookupType): Perform lookups in implicit parents too.
13244 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
13245 sequence as RootContext.LookupType.
13247 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
13248 the various cases of namespace lookups into this method.
13250 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13252 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
13253 in positional arguments)
13255 * class.cs (Operator): Update the AllowedModifiers to contain
13258 * cs-parser.jay: Update operator declaration to allow for the
13259 operator body to be empty.
13261 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
13264 2002-02-27 Miguel de Icaza <miguel@ximian.com>
13266 * class.cs (Method.Emit): Label parameters.
13268 * driver.cs: Return 1 or 0 as the program exit code.
13270 2002-02-26 Miguel de Icaza <miguel@ximian.com>
13272 * expression.cs: Special case the `null' object when trying to
13273 auto-compute the type, as anything can be explicitly converted to
13276 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
13277 spotting this Paolo.
13279 (Expression.ImplicitNumericConversion): Perform comparissions of
13280 the type using the underlying type in the case of an enumeration
13281 rather than using the enumeration type for the compare.
13283 Cope with the underlying == type case, which is not possible to
13286 (Expression.ConvertNumericExplicit): Perform comparissions of
13287 the type using the underlying type in the case of an enumeration
13288 rather than using the enumeration type for the compare.
13290 * driver.cs: If the user does not supply an extension, assume .exe
13292 * cs-parser.jay (if_statement): Rewrote so that we can track the
13293 location for the if statement.
13295 * expression.cs (Binary.ConstantFold): Only concat strings when
13296 the operation is "+", not everything ;-)
13298 * statement.cs (Statement.EmitBoolExpression): Take a location
13300 (If, While, Do): Track location.
13302 * expression.cs (Binary.ResolveOperator): In the object + string
13303 case, I was missing a call to ConvertImplicit
13305 2002-02-25 Ravi Pratap <ravi@ximian.com>
13307 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
13308 Location arguments. Ensure we use RootContext.LookupType to do our work
13309 and not try to do a direct Type.GetType and ModuleBuilder.GetType
13311 * interface.cs (PopulateMethod): Handle the type of the parameter being
13314 * expression.cs (Invocation.BetterFunction): Handle the case when we
13315 have a params method with no fixed arguments and a call is made with no
13318 2002-02-25 Miguel de Icaza <miguel@ximian.com>
13320 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
13321 the verbatim-string-literal
13323 * support.cs (InternalParameters.ParameterModifier): handle null
13325 (InternalParameters.ParameterType): ditto.
13327 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
13328 duplicating the name of the variable parameter.
13329 (GetParameterByName): Fix bug where we were not looking up array
13330 paramters if they were the only present (thanks Paolo!).
13331 (GetParameterInfo): We only have an empty set of types if both
13332 fixed and array are set to null.
13333 (GetParameterInfo-idx): Handle FixedParameter == null
13335 * cs-parser.jay: Handle the case where there is no catch
13336 statements (missing null test).
13338 2002-02-22 Miguel de Icaza <miguel@ximian.com>
13340 * driver.cs (MainDriver): Be conservative on our command line
13343 Catch DirectoryNotFoundException when calling GetFiles.
13345 (SplitPathAndPattern): Used to split the input specification into
13346 a path and a pattern that we can feed to Directory.GetFiles.
13348 2002-02-21 Miguel de Icaza <miguel@ximian.com>
13350 * statement.cs (Fixed): Implement the last case of the Fixed
13351 statement (string handling).
13353 * expression.cs (StringPtr): New class used to return a char * to
13354 a string; Used by the Fixed statement.
13356 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
13358 * expression.cs (Binary.ResolveOperator): Remove redundant
13359 MemberLookup pn parent type.
13360 Optimize union call, we do not need a union if the types are the same.
13361 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
13364 Specialize the use of MemberLookup everywhere, instead of using
13365 the default settings.
13367 (StackAlloc): Implement stackalloc keyword.
13369 * cs-parser.jay: Add rule to parse stackalloc.
13371 * driver.cs: Handle /h, /help, /?
13373 * expression.cs (MakeByteBlob): Removed the hacks we had in place
13374 before we supported unsafe code.
13376 * makefile: add --unsafe to the self compilation of mcs.
13378 2002-02-20 Miguel de Icaza <miguel@ximian.com>
13380 * expression.cs (PointerArithmetic): New class that is used to
13381 perform pointer arithmetic.
13382 (Binary.Resolve): Handle pointer arithmetic
13383 Handle pointer comparission.
13384 (ArrayPtr): Utility expression class that is used to take the
13385 address of an array.
13387 (ElementAccess): Implement array access for pointers
13389 * statement.cs (Fixed): Implement fixed statement for arrays, we
13390 are missing one more case before we are done.
13392 * expression.cs (Indirection): Implement EmitAssign and set the
13393 ExprClass to Variable. This allows pointer dereferences to be
13394 treated as variables, and to have values assigned to them.
13396 * ecore.cs (Expression.StoreFromPtr): New utility function to
13397 store values dereferencing.
13399 2002-02-20 Ravi Pratap <ravi@ximian.com>
13401 * expression.cs (Binary.ResolveOperator): Ensure that we are
13402 not trying to operate on a void type - this fixes the reported
13405 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
13406 the parent implementation is sealed.
13408 * ../errors/cs0239.cs : Add.
13410 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
13412 * typemanager.cs (unverifiable_code_type): Corresponds to
13413 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
13414 which have unsafe code in them.
13416 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
13419 2002-02-19 Miguel de Icaza <miguel@ximian.com>
13421 * cs-tokenizer.cs: Add support for @"litreal strings"
13423 Make tokenizer accept pre-processor directives
13424 on any column (remove the old C-like limitation).
13426 * rootcontext.cs (EmitCode): Emit any global attributes.
13427 (AddGlobalAttributes): Used to keep track of assembly attributes.
13429 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
13431 * cs-parser.jay: Add support for global attributes.
13433 2002-02-17 Miguel de Icaza <miguel@ximian.com>
13435 * expression.cs (Indirection): New helper class. Unary will
13436 create Indirection classes to be able to implement the
13437 IMemoryLocation interface on it.
13439 2002-02-16 Miguel de Icaza <miguel@ximian.com>
13441 * cs-parser.jay (fixed_statement): reference the right statement.
13443 * statement.cs (Fixed.Emit): Finish implementing the fixed
13444 statement for the &x case.
13446 2002-02-14 Miguel de Icaza <miguel@ximian.com>
13448 * class.cs (Property.Define, Method.Define): Remove newslot when
13451 * modifiers.cs: My use of NewSlot when `Abstract' was set was
13452 wrong. NewSlot should only be used if the `new' keyword is present.
13454 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
13455 locating our system dir. Sorry about this.
13457 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13459 * driver.cs (GetSystemDir): Compute correctly the location of our
13460 system assemblies. I was using the compiler directory instead of
13461 the library directory.
13463 2002-02-13 Ravi Pratap <ravi@ximian.com>
13465 * expression.cs (BetterFunction): Put back in what Miguel commented out
13466 since it is the correct fix. The problem is elsewhere ;-)
13468 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
13469 parameters of the parms method are themselves compatible or not !
13471 (StandardConversionExists): Fix very dangerous bug where we were forgetting
13472 to check that a class implements an interface before saying that an implicit
13473 conversion was allowed. Use ImplementsInterface to do the checking.
13475 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13477 * class.cs (Method.Define): Track whether we are an explicit
13478 implementation or not. And only call DefineMethodOverride if we
13479 are an explicit implementation.
13481 (Property.DefineMethod): Ditto.
13483 2002-02-11 Ravi Pratap <ravi@ximian.com>
13485 * expression.cs (BetterFunction): Catch hideous bug which was
13486 preventing us from detecting ambiguous calls due to implicit casts i.e
13489 2002-01-29 Miguel de Icaza <miguel@ximian.com>
13491 * support.cs (Pair): Remove un-needed method. I figured why I was
13492 getting the error in cs-parser.jay, the variable in a foreach loop
13493 is readonly, and the compiler does not really treat this as a variable.
13495 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
13496 instead of EQUALS in grammar.
13498 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
13500 * expression.cs (Unary.DoResolve): Check whether the argument is
13503 2002-01-28 Miguel de Icaza <miguel@ximian.com>
13505 * support.cs: Api for Pair to set a value. Despite the fact that
13506 the variables are public the MS C# compiler refuses to compile
13507 code that accesses the field if the variable is part of a foreach
13510 * statement.cs (Fixed): Begin implementation of the fixed
13513 (Block.AddVariable): Return the VariableInfo on success and null
13514 on failure instead of true/false.
13516 * cs-parser.jay (foreach): Catch errors on variables already
13517 defined (we were ignoring this value before) and properly unwind
13518 the block hierarchy
13520 (fixed_statement): grammar for the fixed statement.
13522 2002-01-25 Miguel de Icaza <miguel@ximian.com>
13524 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
13525 pointer types to be incretemented.
13527 (SizeOf): Implement.
13529 * cs-parser.jay (pointer_member_access): Implement
13530 expr->IDENTIFIER production.
13532 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
13533 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
13536 (Unary): Implement indirection.
13538 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
13539 use in non-unsafe context).
13541 (SimpleName.DoResolve): Check for pointers in field access on safe
13544 (Expression.LoadFromPtr): Factor the load-indirect code in this
13545 function. This was duplicated in UnboxCast and ParameterReference
13547 2002-01-24 Miguel de Icaza <miguel@ximian.com>
13549 * expression.cs (ComposedCast): report an error if a pointer cast
13550 is used in a safe region.
13552 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
13553 pointer type casts in unsafe context.
13555 * codegen.cs (EmitContext): Set up IsUnsafe.
13557 * cs-parser.jay (non_expression_type): Add productions for pointer
13560 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13561 code. We should not use force into static mode if the method is
13562 not virtual. Fixes bug in MIS
13564 * statement.cs (Do.Emit, While.Emit, For.Emit,
13565 Statement.EmitBoolExpression): Add support to Do and While to
13566 propagate infinite loop as `I do return' semantics.
13568 Improve the For case to also test for boolean constants.
13570 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13571 to the list of attributes we can add.
13573 Remove `EmitContext' argument.
13575 * class.cs (Method.Define): Apply parameter attributes.
13576 (Constructor.Define): Apply parameter attributes.
13577 (MethodCore.LabelParameters): Move here the core of labeling
13580 * support.cs (ReflectionParameters.ParameterModifier,
13581 InternalParameters.ParameterModifier): Use IsByRef on the type and
13582 only return the OUT bit for these parameters instead of in/out/ref
13585 This is because I miss-understood things. The ParameterInfo.IsIn
13586 and IsOut represent whether the parameter has the [In] and [Out]
13589 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13591 * ecore.cs (FieldExpr.Emit): Release temporaries.
13593 * assign.cs (LocalTemporary.Release): new function.
13595 * codegen.cs (EmitContext.GetTemporaryStorage,
13596 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13597 temporary storage. Now we can "put back" localbuilders when we
13600 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13602 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13603 need to make a copy of the variable to generate verifiable code.
13605 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13607 * driver.cs: Compute dynamically the system directory.
13609 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13610 Slower, but more generally useful. Used by the abstract
13611 registering implementation.
13613 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13614 the rules for the special rule on Type/instances. First check if
13615 we have the same name, and if so, try that special static path
13616 rather than the instance path.
13618 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13620 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13623 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13624 Enum, ValueType, Delegate or Array for non-corlib compiles.
13626 * cs-tokenizer.cs: Catch long identifiers (645)
13628 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13631 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13632 fix, we were returning too early, so we were not registering
13633 pending methods from abstract classes.
13635 Do not register pending methods if the class is abstract.
13637 * expression.cs (Conditional.DoResolve): Report circular implicit
13638 conversions when we neecd to compute it for conditional
13641 (Is.DoResolve): If the expression is always of the provided type,
13642 flag warning 183. If the expression can not ever be of the
13643 provided type flag warning 184.
13645 * class.cs: Catch 169 as well.
13647 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13650 2002-01-18 Nick Drochak <ndrochak@gol.com>
13652 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13654 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13656 * interface.cs: (PopulateMethod): Check for pointers being defined
13657 only if the unsafe context is active.
13658 (PopulateProperty): ditto.
13659 (PopulateIndexer): ditto.
13661 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13662 specified. If pointers are present, make sure that they are
13663 present in an unsafe context.
13664 (Constructor, Constructor.Define): ditto.
13665 (Field, Field.Define): ditto.
13666 (Property, Property.Define): ditto.
13667 (Event, Event.Define): ditto.
13669 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13670 hashtable if there are classes or structs defined.
13672 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13673 code, as the constant resolution moved.
13675 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13676 the metadata, so we can flag error 133.
13678 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13679 pointer is being declared in an unsafe context.
13681 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13683 * modifiers.cs (Modifiers.Check): Require a Location argument.
13684 Report error 227 for Unsafe use.
13686 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13688 * statement.cs (For.Emit): If the test is null, then report that
13689 we do `return', as we wont reach anything afterwards.
13691 (Switch.SwitchGoverningType): Track the expression that matched
13694 * driver.cs: Allow negative numbers as an error code to flag.
13696 * cs-parser.jay: Handle 1551.
13698 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13700 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13702 * cs-parser.jay: Report 1518 (type declaration can only contain
13703 class, struct, interface, enum or delegate)
13705 (switch_label): Report 1523 (keywords `case' or `default' must
13708 (opt_switch_sections): Report 1522 (empty switch)
13710 * driver.cs: Report 1515 (response file specified multiple times)
13711 Report 1516 (Source file specified multiple times).
13713 * expression.cs (Argument.Resolve): Signal 1510
13715 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13716 access not allowed in static code)
13718 2002-01-11 Ravi Pratap <ravi@ximian.com>
13720 * typemanager.cs (IsPointerType): Utility method which we are going
13723 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13724 the object type, so we take care of that.
13726 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13728 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13729 added to non-params parameters :-)
13731 * typemanager.cs (CSharpName): Include 'void' type too.
13733 (void_ptr_type): Include in the set of core types.
13735 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13738 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13741 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13742 completely forgotten about it.
13744 2002-01-10 Ravi Pratap <ravi@ximian.com>
13746 * cs-parser.jay (pointer_type): Add. This begins our implementation
13747 of parsing rules for unsafe code.
13749 (unsafe_statement): Implement.
13751 (embedded_statement): Modify to include the above.
13753 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13755 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13756 if the current context is an unsafe one.
13758 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13759 are handled differently, we need separate rules for them.
13761 (local_variable_declaration): Update to use local_variable_pointer_type
13762 to allow variable declarations of unmanaged pointer types.
13764 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13765 in unsafe contexts.
13767 * ../errors/cs0214.cs : Add.
13769 2002-01-16 Nick Drochak <ndrochak@gol.com>
13771 * makefile: remove 'response' file when cleaning.
13773 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13775 * cs-parser.jay: Report 1524.
13777 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13779 * typemanager.cs (RegisterMethod): drop checking if we have
13780 registered this from here
13782 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13784 * class.cs (Method.EmitDestructor): Implement calling our base
13787 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13788 value of InFinally.
13790 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13791 this routine and will wrap the call in a try/catch block. Deal
13794 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13796 * ecore.cs (Expression.MemberLookup): instead of taking a
13797 parameter `same_type' that was used to tell whether we could
13798 access private members we compute our containing type from the
13801 (FieldExpr): Added partial support for volatile fields. This does
13802 not work for volatile fields exposed from assemblies, as I can not
13803 figure out how to extract the modreq from it.
13805 Updated all the source files to use this.
13807 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13808 because it is referenced by MemberLookup very often.
13810 2002-01-09 Ravi Pratap <ravi@ximian.com>
13812 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13813 TypeBuilder.GetCustomAttributes to retrieve what we need.
13815 Get rid of redundant default_member_attr_type as this is the same as
13816 default_member_type which already exists.
13818 * interface.cs, attribute.cs : Update accordingly.
13820 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13822 * typemanager.cs: Enable IndexerPropertyName again. It does not
13823 work for TYpeBuilders though. Ravi, can you please fix this?
13825 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13827 * expression.cs (Argument.Emit): Handle the case of ref objects
13828 being passed to ref functions;
13830 (ParameterReference.EmitLoad): Loads the content of the pointer
13831 without dereferencing.
13833 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13835 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13837 2002-01-08 Ravi Pratap <ravi@ximian.com>
13839 * class.cs (Indexer.DefineMethod): Incorporate the interface
13840 type in the name of the method if we are doing explicit interface
13843 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13845 (BetterConversion): Fix extremely trivial bug where we were referring to
13846 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13849 * ../errors/bug16.cs : Add although we have fixed it.
13851 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13853 * expression.cs (BaseIndexer): Begin implementation.
13855 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13857 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13858 production directly to remove a shift/reduce, and implement
13859 explicit interface implementation.
13861 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13862 after a floating point suffix.
13864 * expression.cs (DoNumericPromotions): Improved the conversion for
13865 uint/uint. If we have a constant, we avoid doing a typecast to a
13868 * class.cs (Indexer): Implement explicit interface implementation
13871 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13873 * class.cs: make the default instance constructor public and hidebysig.
13875 2001-01-03 Ravi Pratap <ravi@ximian.com>
13877 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13878 so we can call it from elsewhere.
13880 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13881 we emit it internally if the class has a defined indexer; otherwise the user
13882 emits it by decorating the class definition with the DefaultMemberAttribute.
13884 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13885 attribute is not used on a type which defines an indexer.
13887 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13888 character when we skip whitespace.
13890 * ../errors/cs0646.cs : Add.
13892 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13894 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13897 * makefile: Add practical target `mcs3.exe' which builds the third
13898 generation compiler.
13900 * expression.cs (New): Fix structures constructor calling.
13902 * class.cs (Property, Method, Indexer): Emit Final flag on the
13903 method if we are an interface implementation and we are not
13906 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13907 whether this property is referencing a `base' method.
13909 * expression.cs (Invocation.EmitCall): take an extra argument:
13910 is_base, this is used to determine whether the `call' or
13911 `callvirt' opcode should be used.
13914 * delegate.cs: update EmitCall.
13916 * class.cs (Method.Define): Set NewSlot for the cases where we are
13917 not implementing an interface method.
13919 (Property.Define): ditto.
13921 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13923 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13924 'r'. Allows mcs to parse itself fully.
13926 2002-01-02 Ravi Pratap <ravi@ximian.com>
13928 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13929 of the number of initializers that require the InitializeArray method.
13931 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13932 update the above field where necessary.
13934 (MakeByteBlob): Update accordingly.
13936 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13939 (EmitDynamicInitializers): Update in accordance with the new optimization.
13941 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13942 same OpCode applies.
13944 * cs-parser.jay : Fix some glaring errors I introduced.
13946 2002-01-01 Ravi Pratap <ravi@ximian.com>
13948 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13949 so that we can check for name clashes there too.
13951 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13952 for interface indexers.
13954 * interfaces.cs (Define): Emit the default member attribute.
13956 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13957 variable was being referred to while setting the value ;-)
13959 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13961 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13962 byte-by-byte information when we know the data is zero.
13964 Make the block always a multiple of 4, because
13965 DefineInitializedData has a bug.
13967 * assign.cs: Fix, we should assign from the temporary, not from
13970 * expression.cs (MakeByteBlob): Fix my incorrect code.
13972 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13974 * typemanager.cs (EnumToUnderlying): This function is used to get
13975 the underlying type from an enumeration, because it does not
13978 * constant.cs: Use the I4_S form for values between -128 and 127.
13980 * statement.cs (Block.LookupLabel): Looks up a label.
13981 (Block): Drop support for labeled blocks.
13983 (LabeledStatement): New kind of statement that represents a label
13986 (Goto): Finally implement this bad boy.
13988 * cs-parser.jay: Update to reflect new mechanism to implement
13991 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13993 * codegen.cs (EmitContext.This): a codegen property that keeps the
13994 a single instance of this instead of creating many different this
13997 * delegate.cs (Delegate.DoResolve): Update to use the property;
13999 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
14001 * expression.cs (BaseAccess.DoResolve): Ditto.
14003 2001-12-29 Ravi Pratap <ravi@ximian.com>
14005 * typemanager.cs (methodimpl_attr_type): Add to hold the type
14006 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
14008 (InitCoreTypes): Update accordingly.
14010 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
14011 so we can quickly store the state.
14013 (ApplyAttributes): Set the correct implementation flags
14014 for InternalCall methods.
14016 2001-12-29 Miguel de Icaza <miguel@ximian.com>
14018 * expression.cs (EmitCall): if a method is not virtual, then do
14019 not use callvirt on it.
14021 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
14022 user defined stuff) requires the use of stobj, which takes an
14023 address on the stack instead of an array and an index. So emit
14024 the Ldelema operation for it.
14026 (EmitStoreOpcode): Use stobj for valuetypes.
14028 (UnaryMutator.EmitCode): Use the right 1 value depending on
14029 whether we are dealing with int64/uint64, float or doubles.
14031 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
14032 constructors that I implemented last night.
14034 (Constructor.IsDefault): Fix to work properly for static
14037 * cs-parser.jay (CheckDef): report method signature errors.
14038 Update error number 103 to be 132.
14040 * decl.cs: New AdditionResult enumeration value: MethodExists.
14041 Although we do this check for methods later on in the semantic
14042 analysis, catching repeated default constructors is so easy that
14043 we catch these here.
14045 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
14048 (ParameterReference.EmitAssign, Emit): handle
14051 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
14052 (ArrayAccess.EmitStoreOpcode): ditto.
14054 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
14056 * expression.cs (MakeByteBlob): Complete all the missing types
14057 (uint, short, ushort, byte, sbyte)
14059 * class.cs: Only init instance field initializers on instance
14062 Rename `constructors' to instance_constructors.
14064 (TypeContainer.AddConstructor): Only add constructors to the list
14065 if it is not static.
14067 Make sure that we handle default_static_constructor independently
14068 everywhere where we handle instance_constructors
14070 2001-12-28 Miguel de Icaza <miguel@ximian.com>
14072 * class.cs: Do not lookup or create a base initializer for a
14073 static constructor.
14075 (ConstructorInitializer.Resolve): use the proper type to lookup
14078 * cs-parser.jay: Report error 1585 (modifiers between type and name).
14080 * enum.cs, interface.cs: Remove CloseType, this is taken care by
14083 * decl.cs: CloseType is now an virtual method, the default
14084 implementation just closes this type.
14086 2001-12-28 Ravi Pratap <ravi@ximian.com>
14088 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
14089 to PreserveSig by default. Also emit HideBySig on such methods.
14091 Basically, set the defaults to standard values.
14093 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
14094 argument, if candidate is better, it can't be worse than the best !
14096 (Invocation): Re-write bits to differentiate between methods being
14097 applicable in their expanded form and their normal form - for params
14100 Get rid of use_standard everywhere as only standard conversions are allowed
14101 in overload resolution.
14103 More spec conformance.
14105 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14107 * driver.cs: Add --timestamp, to see where the compiler spends
14110 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
14111 `this' in static code.
14113 (SimpleName.DoResolve): Implement in terms of a helper function
14114 that allows static-references to be passed upstream to
14117 (Expression.ResolveWithSimpleName): Resolve specially simple
14118 names when called by MemberAccess to implement the special
14121 (Expression.ImplicitReferenceConversion): Handle conversions from
14122 Null to reference types before others, as Null's type is
14125 * expression.cs (Invocation.EmitCall): Handle the special case of
14126 calling methods declared on a reference type from a ValueType
14127 (Base classes System.Object and System.Enum)
14129 (MemberAccess.Resolve): Only perform lookups on Enumerations if
14130 the left hand side is a TypeExpr, not on every enumeration.
14132 (Binary.Resolve): If types are reference types, then do a cast to
14133 object on operators != and == of both arguments.
14135 * typemanager.cs (FindMembers): Extract instance and static
14136 members if requested.
14138 * interface.cs (PopulateProperty): Use void_type instead of null
14139 as the return type for the setter method.
14141 (PopulateIndexer): ditto.
14143 2001-12-27 Ravi Pratap <ravi@ximian.com>
14145 * support.cs (ReflectionParameters): Fix minor bug where we
14146 were examining the wrong parameter for the ParamArray attribute.
14148 Cope with requests for the type of the parameter at position
14149 greater than the params parameter's. We now return the element
14150 type of the params array as that makes more sense.
14152 * expression.cs (Invocation.IsParamsMethodApplicable): Update
14153 accordingly as we no longer have to extract the element type
14156 (Invocation.OverloadResolve): Update.
14158 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14160 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
14161 against IEnumerator, test whether the return value is a descendant
14162 of the IEnumerator interface.
14164 * class.cs (Indexer.Define): Use an auxiliary method to implement
14165 the other bits of the method definition. Begin support for
14166 explicit interface implementation.
14168 (Property.DefineMethod): Use TypeManager.void_type instead of null
14169 for an empty return value.
14171 2001-12-26 Miguel de Icaza <miguel@ximian.com>
14173 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
14174 dealing with a FieldExpr which is composed of a FieldBuilder, in
14175 the code path we did extract the constant, but we should have
14176 obtained the underlying value to be able to cast it (otherwise we
14177 end up in an infinite loop, this is what Ravi was running into).
14179 (ArrayCreation.UpdateIndices): Arrays might be empty.
14181 (MemberAccess.ResolveMemberAccess): Add support for section
14182 14.5.4.1 that deals with the special case of E.I when E is a type
14183 and something else, that I can be a reference to a static member.
14185 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
14186 handle a particular array type to create byte blobs, it is just
14187 something we dont generate byteblobs for.
14189 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
14192 * location.cs (Push): remove the key from the hashtable that we
14193 are about to add. This happens for empty files.
14195 * driver.cs: Dispose files after we have parsed them.
14197 (tokenize): new function that only runs the tokenizer on its
14198 input, for speed testing.
14200 2001-12-26 Ravi Pratap <ravi@ximian.com>
14202 * class.cs (Event.Define): Define the private field only if there
14203 are no accessors defined.
14205 * expression.cs (ResolveMemberAccess): If there is no associated
14206 field with the event, that means we have an event defined with its
14207 own accessors and we should flag error cs0070 since transforming
14208 ourselves into a field is not valid in that case.
14210 * ecore.cs (SimpleName.DoResolve): Same as above.
14212 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
14213 and charset to sane values.
14215 2001-12-25 Ravi Pratap <ravi@ximian.com>
14217 * assign.cs (DoResolve): Perform check on events only if they
14218 are being accessed outside the declaring type.
14220 * cs-parser.jay (event_declarations): Update rules to correctly
14221 set the type of the implicit parameter etc.
14223 (add_accessor, remove_accessor): Set current local parameters.
14225 * expression.cs (Binary): For delegate addition and subtraction,
14226 cast the return value from the method into the appropriate delegate
14229 2001-12-24 Ravi Pratap <ravi@ximian.com>
14231 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
14232 of these as the workaround is unnecessary.
14234 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
14235 delegate data - none of that is needed at all.
14237 Re-write bits to extract the instance expression and the delegate method
14240 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
14243 * attribute.cs (ApplyAttributes): New method to take care of common tasks
14244 of attaching attributes instead of duplicating code everywhere.
14246 * everywhere : Update code to do attribute emission using the above method.
14248 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14250 * expression.cs (IsParamsMethodApplicable): if there are not
14251 parameters, return immediately.
14253 * ecore.cs: The 0 literal can be implicity converted to an enum
14256 (SimpleName.DoResolve): First lookup the type, then lookup the
14259 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
14260 want to get its address. If the InstanceExpression is not
14261 addressable, store the result in a temporary variable, then get
14264 * codegen.cs: Only display 219 errors on warning level or above.
14266 * expression.cs (ArrayAccess): Make it implement the
14267 IMemoryLocation interface.
14269 (Binary.DoResolve): handle the operator == (object a, object b)
14270 and operator != (object a, object b) without incurring into a
14271 BoxedCast (because 5 != o should never be performed).
14273 Handle binary enumerator operators.
14275 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
14276 value type, otherwise use Ldelem_ref.
14278 Use precomputed names;
14280 (AddressOf): Implement address of
14282 * cs-parser.jay (labeled_statement): Fix recursive block
14283 addition by reworking the production.
14285 * expression.cs (New.DoEmit): New has a special case:
14287 If we are dealing with a ValueType, we have a few
14288 situations to deal with:
14290 * The target of New is a ValueType variable, that is
14291 easy, we just pass this as the variable reference
14293 * The target of New is being passed as an argument,
14294 to a boxing operation or a function that takes a
14297 In this case, we need to create a temporary variable
14298 that is the argument of New.
14301 2001-12-23 Ravi Pratap <ravi@ximian.com>
14303 * rootcontext.cs (LookupType): Check that current_type is not null before
14304 going about looking at nested types.
14306 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
14307 not implement the IAssignMethod interface any more.
14309 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
14310 where we tranform them into FieldExprs if they are being resolved from within
14311 the declaring type.
14313 * ecore.cs (SimpleName.DoResolve): Do the same here.
14315 * assign.cs (DoResolve, Emit): Clean up code considerably.
14317 * ../errors/bug10.cs : Add.
14319 * ../errors/cs0070.cs : Add.
14321 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
14323 * assign.cs : Get rid of EventIsLocal everywhere.
14325 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14327 * ecore.cs (ConvertIntLiteral): finished the implementation.
14329 * statement.cs (SwitchLabel): Convert the value we are using as a
14330 key before looking up the table.
14332 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14334 * codegen.cs (EmitTopBlock): Require a Location argument now.
14336 * cs-parser.jay (constructor_declarator): We need to setup
14337 current_local_parameters before we parse the
14338 opt_constructor_initializer, to allow the variables to be bound
14339 to the constructor arguments.
14341 * rootcontext.cs (LookupType): First lookup nested classes in our
14342 class and our parents before we go looking outside our class.
14344 * expression.cs (ConstantFold): Extract/debox the values at the
14347 * rootcontext.cs (EmitCode): Resolve the constants first before we
14348 resolve the types. This is not really needed, but it helps debugging.
14350 * statement.cs: report location.
14352 * cs-parser.jay: pass location to throw statement.
14354 * driver.cs: Small bug fix.
14356 * report.cs: Updated format to be 4-zero filled digits.
14358 2001-12-22 Ravi Pratap <ravi@ximian.com>
14360 * expression.cs (CheckIndices): Fix minor bug where the wrong
14361 variable was being referred to ;-)
14363 (DoEmit): Do not call EmitStaticInitializers when the
14364 underlying type is System.Object.
14366 2001-12-21 Ravi Pratap <ravi@ximian.com>
14368 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
14369 and do the usual workaround for SRE.
14371 * class.cs (MyEventBuilder.EventType): New member to get at the type
14372 of the event, quickly.
14374 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
14376 * assign.cs (Assign.DoResolve): Handle the case when the target
14377 is an EventExpr and perform the necessary checks.
14379 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
14382 (SimpleName.MemberStaticCheck): Include check for EventExpr.
14384 (EventExpr): Set the type in the constructor itself since we
14385 are meant to be born fully resolved.
14387 (EventExpr.Define): Revert code I wrote earlier.
14389 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
14390 instance expression is null. The instance expression is a This in that case
14391 or a null, depending on whether it is a static method or not.
14393 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
14394 refers to more than one method.
14396 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
14397 and accordingly flag errors.
14399 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14401 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
14403 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14405 * location.cs (ToString): Provide useful rutine.
14407 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14409 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
14410 objects, return the actual integral boxed.
14412 * statement.cs (SwitchLabel): define an ILLabel for each
14415 (Switch.CheckSwitch): If the value is a Literal, extract
14416 the underlying literal.
14418 Also in the unused hashtable we had, add the SwitchLabel so we can
14419 quickly look this value up.
14421 * constant.cs: Implement a bunch of new constants. Rewrite
14422 Literal based on this. Made changes everywhere to adapt to this.
14424 * expression.cs (Expression.MakeByteBlob): Optimize routine by
14425 dereferencing array only once, and also copes with enumrations.
14427 bytes are two bytes wide, not one.
14429 (Cast): Perform constant conversions.
14431 * ecore.cs (TryImplicitIntConversion): Return literals instead of
14432 wrappers to the literals here.
14434 * expression.cs (DoNumericPromotions): long literals can converted
14435 to ulong implicity (this is taken care of elsewhere, but I was
14436 missing this spot).
14438 * ecore.cs (Expression.Literalize): Make the return type Literal,
14439 to improve type checking.
14441 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
14443 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14445 * literal.cs: Revert code from ravi that checked the bounds. The
14446 bounds are sane by the definition of the type itself.
14448 * typemanager.cs: Fix implementation of ImplementsInterface. We
14449 need to actually look up in our parent hierarchy for interfaces
14452 * const.cs: Use the underlying type for enumerations
14454 * delegate.cs: Compute the basename for the delegate creation,
14455 that should fix the delegate test case, and restore the correct
14456 Type Lookup semantics in rootcontext
14458 * rootcontext.cs: Revert Ravi's last patch. The correct way of
14459 referencing a nested type with the Reflection API is using the "+"
14462 * cs-parser.jay: Do not require EOF token at the end.
14464 2001-12-20 Ravi Pratap <ravi@ximian.com>
14466 * rootcontext.cs (LookupType): Concatenate type names with
14467 a '.' instead of a '+' The test suite passes again.
14469 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
14470 field of the enumeration.
14472 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
14473 the case when the member is an EventExpr.
14475 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
14476 static has an associated instance expression.
14478 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
14480 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
14482 * class.cs (Event.Define): Register event and perform appropriate checks
14485 We define the Add and Remove methods even if the use provides none because
14486 in that case, we provide default implementations ourselves.
14488 Define a private field of the type of the event. This is done by the CSC compiler
14489 and we should be doing it too ;-)
14491 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
14492 More methods we use in code we generate.
14494 (multicast_delegate_type, delegate_type): Two separate types since the distinction
14497 (InitCoreTypes): Update accordingly for the above.
14499 * class.cs (Event.Emit): Generate code for default accessors that we provide
14501 (EmitDefaultMethod): Do the job in the above.
14503 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
14506 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14508 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
14509 builders even if we were missing one.
14511 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
14512 pass the Basename as our class name instead of the Name. The
14513 basename will be correctly composed for us.
14515 * parameter.cs (Paramters): Now takes a Location argument.
14517 * decl.cs (DeclSpace.LookupType): Removed convenience function and
14518 make all the code call directly LookupType in RootContext and take
14519 this chance to pass the Location information everywhere.
14521 * Everywhere: pass Location information.
14523 2001-12-19 Miguel de Icaza <miguel@ximian.com>
14525 * class.cs (Constructor.Define): Updated way of detecting the
14526 length of the parameters.
14528 (TypeContainer.DefineType): Use basename as the type name for
14531 (TypeContainer.Define): Do not recursively define types here, as
14532 definition is taken care in order by the RootContext.
14534 * tree.cs: Keep track of namespaces in a per-file basis.
14536 * parameter.cs (Parameter.ComputeSignature): Update to use
14539 (Parameters.GetSignature): ditto.
14541 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
14542 instead of a TypeContainer.
14544 (Interface.SemanticAnalysis): Use `this' instead of our parent to
14545 resolve names. Because we need to be resolve in our context, not
14548 * driver.cs: Implement response files.
14550 * class.cs (TypeContainer.DefineType): If we are defined, do not
14551 redefine ourselves.
14553 (Event.Emit): Emit the code for add/remove handlers.
14554 (Event.Define): Save the MethodBuilders for add/remove.
14556 * typemanager.cs: Use pair here too.
14558 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14559 DictionaryEntry requires the first argument to be non-null.
14561 (enum_declaration): Compute full name for registering the
14564 (delegate_declaration): Instead of using
14565 formal_parameter_list, use opt_formal_parameter_list as the list
14568 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14569 (EventParsing): New property that controls whether `add' and
14570 `remove' are returned as tokens or identifiers (for events);
14572 2001-12-19 Ravi Pratap <ravi@ximian.com>
14574 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14575 use MyEventBuilder only and let it wrap the real builder for us.
14577 (MyEventBuilder): Revamp constructor etc.
14579 Implement all operations that we perform on EventBuilder in precisely the same
14582 (FindMembers): Update to use the EventBuilder member.
14584 (Event.Emit): Update accordingly.
14586 2001-12-18 Ravi Pratap <ravi@ximian.com>
14588 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14589 by calling the appropriate methods.
14591 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14594 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14596 2001-12-17 Ravi Pratap <ravi@ximian.com>
14598 * delegate.cs (Delegate.Populate): Check that the return type
14599 and various parameters types are indeed accessible.
14601 * class.cs (Constructor.Define): Same here.
14603 (Field.Define): Ditto.
14605 (Event.Define): Ditto.
14607 (Operator.Define): Check that the underlying Method defined itself
14608 correctly - so it's MethodBuilder should not be null.
14610 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14611 expression happens to be null.
14613 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14614 members but as of now we don't seem to be able to do anything really useful with it.
14616 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14617 not the EventBuilder.
14619 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14621 * cs-tokenizer.cs: Add support for defines.
14622 Add support for #if, #elif, #else, #endif
14624 (eval_var): evaluates a variable.
14625 (eval): stubbed for evaluating functions.
14627 * cs-parser.jay: Pass the defines information
14629 * driver.cs: Add --define command line option.
14631 * decl.cs: Move MemberCore here.
14633 Make it the base class for DeclSpace. This allows us to catch and
14634 report 108 and 109 for everything now.
14636 * class.cs (TypeContainer.Define): Extract all the members
14637 before populating and emit the warning 108 (new keyword required
14638 to override) instead of having each member implement this.
14640 (MemberCore.Define): New abstract method, we will be using this in
14641 the warning reporting engine in Populate.
14643 (Operator.Define): Adjust to new MemberCore protocol.
14645 * const.cs (Const): This does not derive from Expression, it is a
14646 temporary object we use to create fields, it is a MemberCore.
14648 * class.cs (Method.Define): Allow the entry point to be in a
14651 * driver.cs: Rewrite the argument handler to clean it up a bit.
14653 * rootcontext.cs: Made it just an auxiliary namespace feature by
14654 making everything static.
14656 * driver.cs: Adapt code to use RootContext type name instead of
14659 * delegate.cs: Remove RootContext argument.
14661 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14664 * class.cs (Event.Define): The lookup can fail.
14666 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14668 * expression.cs: Resolve the this instance before invoking the code.
14670 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14672 * cs-parser.jay: Add a production in element_access that allows
14673 the thing to become a "type" reference. This way we can parse
14674 things like "(string [])" as a type.
14676 Note that this still does not handle the more complex rules of
14680 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14682 * ecore.cs: (CopyNewMethods): new utility function used to
14683 assemble the list of methods from running FindMembers.
14685 (MemberLookup): Rework FindMembers so that
14687 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14689 * class.cs (TypeContainer): Remove Delegates who fail to be
14692 * delegate.cs (Populate): Verify that we dont get null return
14693 values. TODO: Check for AsAccessible.
14695 * cs-parser.jay: Use basename to emit error 574 (destructor should
14696 have the same name as container class), not the full name.
14698 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14699 possible representation.
14701 Also implements integer type suffixes U and L.
14703 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14705 * expression.cs (ArrayCreation.DoResolve): We need to do the
14706 argument resolution *always*.
14708 * decl.cs: Make this hold the namespace. Hold the root context as
14710 (LookupType): Move here.
14712 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14714 * location.cs (Row, Name): Fixed the code, it was always returning
14715 references to the first file.
14717 * interface.cs: Register properties defined through interfaces.
14719 * driver.cs: Add support for globbing on the command line
14721 * class.cs (Field): Make it derive from MemberCore as well.
14724 2001-12-15 Ravi Pratap <ravi@ximian.com>
14726 * class.cs (Event::Define): Check that the type of the event is a delegate
14727 type else flag error #66.
14729 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14732 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14733 values of EntryPoint, CharSet etc etc.
14735 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14737 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14738 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14739 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14740 which needs this to do its work.
14742 * ../errors/cs0066.cs : Add.
14744 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14746 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14749 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14750 clears out the parameters field.
14751 (MemberSignatureCompare): Cleanup
14753 (MemberCore): New base class used to share code between MethodCore
14756 (RegisterRequiredImplementations) BindingFlags.Public requires
14757 either BindingFlags.Instace or Static. Use instance here.
14759 (Property): Refactored code to cope better with the full spec.
14761 * parameter.cs (GetParameterInfo): Return an empty array instead
14764 * class.cs (Property): Abstract or extern properties have no bodies.
14766 * parameter.cs (GetParameterInfo): return a zero-sized array.
14768 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14769 method modifier validation to the typecontainer so we can reuse
14770 this on properties.
14772 (MethodCore.ParameterTypes): return an empty sized array of types.
14774 (Property.Define): Test property modifier validity.
14776 Add tests for sealed/override too.
14778 (Method.Emit): abstract or extern methods have no bodies.
14780 2001-12-14 Ravi Pratap <ravi@ximian.com>
14782 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14785 (Method::Define, ::Emit): Modify accordingly.
14787 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14789 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14791 * makefile: Pass in /unsafe.
14793 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14795 * class.cs (MakeKey): Kill routine.
14797 * class.cs (TypeContainer.Define): Correctly define explicit
14798 method implementations (they require the full interface name plus
14801 * typemanager.cs: Deply the PtrHashtable here and stop using the
14802 lame keys. Things work so much better.
14804 This of course broke everyone who depended on `RegisterMethod' to
14805 do the `test for existance' test. This has to be done elsewhere.
14807 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14808 the object stupid Equals method (because, that like fails all over
14809 the place). We still do not use it.
14811 * class.cs (TypeContainer.SetRequiredInterface,
14812 TypeContainer.RequireMethods): Killed these two routines and moved
14813 all the functionality to RegisterRequiredImplementations.
14815 (TypeContainer.RegisterRequiredImplementations): This routine now
14816 registers all the implementations required in an array for the
14817 interfaces and abstract methods. We use an array of structures
14818 which can be computed ahead of time to reduce memory usage and we
14819 also assume that lookups are cheap as most classes will not
14820 implement too many interfaces.
14822 We also avoid creating too many MethodSignatures.
14824 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14825 clear the "pending" bit if we find that there are problems with
14828 (TypeContainer.VerifyPendingMethods): Update to report errors of
14829 methods that look like implementations but are not.
14831 (TypeContainer.Define): Add support for explicit interface method
14834 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14836 * typemanager.cs: Keep track of the parameters here instead of
14837 being a feature of the TypeContainer.
14839 * class.cs: Drop the registration of parameters here, as
14840 InterfaceMethods are also interface declarations.
14842 * delegate.cs: Register methods with the TypeManager not only with
14843 the TypeContainer. This code was buggy.
14845 * interface.cs: Full registation here.
14847 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14849 * expression.cs: Remove reducer for binary expressions, it can not
14852 * const.cs: Put here the code that used to go into constant.cs
14854 * constant.cs: Put here the code for constants, this is a new base
14855 class for Literals.
14857 * literal.cs: Make Literal derive from Constant.
14859 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14861 * statement.cs (Return.Emit): Report error 157 if the user
14862 attempts to return from a finally block.
14864 (Return.Emit): Instead of emitting a return, jump to the end of
14867 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14868 LocalBuilder to store the result of the function. ReturnLabel is
14869 the target where we jump.
14872 2001-12-09 Radek Doulik <rodo@ximian.com>
14874 * cs-parser.jay: remember alias in current namespace
14876 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14879 * class.cs (LookupAlias): lookup alias in my_namespace
14881 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14883 (LookupAlias): lookup alias in this and if needed in parent
14886 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14890 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14891 making things static. I need this to avoid passing the
14892 TypeContainer when calling ParameterType.
14894 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14895 that did string manipulation to compute the type and then call
14896 GetType. Use Parameter.ParameterType instead.
14898 * cs-tokenizer.cs: Consume the suffix for floating values.
14900 * expression.cs (ParameterReference): figure out whether this is a
14901 reference parameter or not. Kill an extra variable by computing
14902 the arg_idx during emission.
14904 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14905 function that returns whether a parameter is an out/ref value or not.
14907 (Parameter.ParameterType): The type of the parameter (base,
14908 without ref/out applied).
14910 (Parameter.Resolve): Perform resolution here.
14911 (Parameter.ExternalType): The full type (with ref/out applied).
14913 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14914 support for expressions on the using statement.
14916 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14918 * statement.cs (Using.EmitLocalVariableDecls): Split the
14919 localvariable handling of the using statement.
14921 (Block.EmitMeta): Keep track of variable count across blocks. We
14922 were reusing slots on separate branches of blocks.
14924 (Try.Emit): Emit the general code block, we were not emitting it.
14926 Check the type of the declaration to be an IDisposable or
14927 something that can be implicity converted to it.
14929 Emit conversions if required.
14931 * ecore.cs (EmptyExpression): New utility class.
14932 (Expression.ImplicitConversionExists): New utility function.
14934 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14936 * statement.cs (Using): Implement.
14938 * expression.cs (LocalVariableReference): Support read only variables.
14940 * statement.cs: Remove the explicit emit for the Leave opcode.
14941 (VariableInfo): Add a readonly field.
14943 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14945 * ecore.cs (ConvCast): new class used to encapsulate the various
14946 explicit integer conversions that works in both checked and
14947 unchecked contexts.
14949 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14950 properly generate the overflow opcodes.
14952 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14954 * statement.cs: The correct type for the EmptyExpression is the
14955 element_type, not the variable type. Ravi pointed this out.
14957 2001-12-04 Ravi Pratap <ravi@ximian.com>
14959 * class.cs (Method::Define): Handle PInvoke methods specially
14960 by using DefinePInvokeMethod instead of the usual one.
14962 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14963 above to do the task of extracting information and defining the method.
14965 2001-12-04 Ravi Pratap <ravi@ximian.com>
14967 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14968 of the condition for string type.
14970 (Emit): Move that here.
14972 (ArrayCreation::CheckIndices): Keep string literals in their expression
14975 (EmitDynamicInitializers): Handle strings appropriately.
14977 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14979 * codegen.cs (EmitContext): Replace multiple variables with a
14980 single pointer to the current Switch statement.
14982 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14985 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14989 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14992 (Foreach.Emit): Foreach on arrays was not setting
14993 up the loop variables (for break/continue).
14995 (GotoCase): Semi-implented.
14997 2001-12-03 Ravi Pratap <ravi@ximian.com>
14999 * attribute.cs (CheckAttribute): Handle system attributes by using
15000 Attribute.GetAttributes to examine information we need.
15002 (GetValidPlaces): Same here.
15004 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
15006 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
15008 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
15010 (Method::Define): Set appropriate flags if we have a DllImport attribute.
15012 (Method::Emit): Handle the case when we are a PInvoke method.
15014 2001-12-03 Miguel de Icaza <miguel@ximian.com>
15016 * expression.cs: Use ResolveWithSimpleName on compound names.
15018 2001-12-02 Ravi Pratap <ravi@ximian.com>
15020 * constant.cs (EmitConstant): Make sure we resolve the associated expression
15021 before trying to reduce it.
15023 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
15025 * constant.cs (LookupConstantValue): Implement.
15027 (EmitConstant): Use the above in emitting the constant.
15029 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
15030 that are user-defined by doing a LookupConstantValue on them.
15032 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
15035 2001-11-29 Miguel de Icaza <miguel@ximian.com>
15037 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
15039 (BaseAccess.DoResolve): Implement.
15041 (MemberAccess.DoResolve): Split this routine into a
15042 ResolveMemberAccess routine that can be used independently
15044 2001-11-28 Miguel de Icaza <miguel@ximian.com>
15046 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
15047 As that share bits of the implementation. Is returns a boolean,
15048 while As returns the Type that is being probed.
15050 2001-12-01 Ravi Pratap <ravi@ximian.com>
15052 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
15053 instead of a Literal - much easier.
15055 (EnumInTransit): Remove - utterly useless :-)
15057 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
15059 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
15061 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
15062 chain when we have no associated expression.
15064 2001-11-30 Ravi Pratap <ravi@ximian.com>
15066 * constant.cs (Define): Use Location while reporting the errror.
15068 Also emit a warning when 'new' is used and there is no inherited
15071 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
15074 (LookupEnumValue): Implement to lookup an enum member's value and define it
15077 (Populate): Re-write accordingly to use the above routine.
15079 2001-11-27 Miguel de Icaza <miguel@ximian.com>
15081 * expression.cs (This): Fix prototype for DoResolveLValue to
15082 override the base class DoResolveLValue.
15084 * cs-parser.cs: Report errors cs574 and cs575 (destructor
15087 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
15088 (we need to load the address of the field here). This fixes
15091 (FieldExpr.DoResolveLValue): Call the DoResolve
15092 function to initialize the Instance expression.
15094 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
15095 correctly the GetEnumerator operation on a value type.
15097 * cs-parser.jay: Add more simple parsing error catches.
15099 * statement.cs (Switch): Add support for string switches.
15100 Handle null specially.
15102 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
15104 2001-11-28 Ravi Pratap <ravi@ximian.com>
15106 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
15108 (declare_local_constant): New helper function.
15110 * statement.cs (AddConstant): Keep a separate record of constants
15112 (IsConstant): Implement to determine if a variable is a constant.
15114 (GetConstantExpression): Implement.
15116 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
15118 * statement.cs (IsVariableDefined): Re-write.
15120 2001-11-27 Ravi Pratap <ravi@ximian.com>
15122 * class.cs (TypeContainer::FindMembers): Look for constants
15123 in the case when we are looking for MemberTypes.Field
15125 * expression.cs (MemberAccess::DoResolve): Check that in the
15126 case we are a FieldExpr and a Literal, we are not being accessed
15127 by an instance reference.
15129 * cs-parser.jay (local_constant_declaration): Implement.
15131 (declaration_statement): Implement for constant declarations.
15133 2001-11-26 Miguel de Icaza <miguel@ximian.com>
15135 * statement.cs (Switch): Catch double defaults.
15137 (Switch): More work on the switch() statement
15138 implementation. It works for integral values now, need to finish
15142 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15144 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
15145 integer literals into other integer literals. To be used by
15148 2001-11-24 Ravi Pratap <ravi@ximian.com>
15150 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
15153 (EmitDynamicInitializers): Cope with the above since we extract data
15154 directly from ArrayData now.
15156 (ExpectInitializers): Keep track of whether initializers are mandatory
15159 (Bounds): Make it a hashtable to prevent the same dimension being
15160 recorded for every element in that dimension.
15162 (EmitDynamicInitializers): Fix bug which prevented the Set array method
15165 Also fix bug which was causing the indices to be emitted in the reverse
15168 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15170 * expression.cs (ArrayCreation): Implement the bits that Ravi left
15171 unfinished. They do not work, because the underlying code is
15174 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15176 * cs-parser.jay: Remove bogus fixme.
15178 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
15179 on Switch statement.
15181 2001-11-23 Ravi Pratap <ravi@ximian.com>
15183 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
15186 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
15187 parameter. Apparently, any expression is allowed.
15189 (ValidateInitializers): Update accordingly.
15191 (CheckIndices): Fix some tricky bugs thanks to recursion.
15193 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
15194 I was being completely brain-dead.
15196 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
15197 and re-write acordingly.
15199 (DelegateInvocation): Re-write accordingly.
15201 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
15203 (MakeByteBlob): Handle types more correctly.
15205 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
15206 initialization from expressions but it is incomplete because I am a complete
15209 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15211 * statement.cs (If.Emit): Fix a bug that generated incorrect code
15212 on If. Basically, we have to return `true' (ie, we do return to
15213 our caller) only if both branches of the if return.
15215 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
15216 short-circuit operators, handle them as short circuit operators.
15218 (Cast.DoResolve): Resolve type.
15219 (Cast.Cast): Take an expression as the target type.
15221 * cs-parser.jay (cast_expression): Remove old hack that only
15222 allowed a limited set of types to be handled. Now we take a
15223 unary_expression and we resolve to a type during semantic
15226 Use the grammar productions from Rhys to handle casts (this is
15227 not complete like Rhys syntax yet, we fail to handle that corner
15228 case that C# has regarding (-x), but we will get there.
15230 2001-11-22 Ravi Pratap <ravi@ximian.com>
15232 * class.cs (EmitFieldInitializer): Take care of the case when we have a
15233 field which is an array type.
15235 * cs-parser.jay (declare_local_variables): Support array initialization too.
15237 * typemanager.cs (MakeKey): Implement.
15239 (everywhere): Use the above appropriately.
15241 * cs-parser.jay (for_statement): Update for array initialization while
15242 declaring variables.
15244 * ecore.cs : The error message was correct, it's the variable's names that
15245 were misleading ;-) Make the code more readable.
15247 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
15248 the correct type etc.
15250 (ConvertExplicit): Handle Enum types by examining the underlying type.
15252 2001-11-21 Ravi Pratap <ravi@ximian.com>
15254 * parameter.cs (GetCallingConvention): Always return
15255 CallingConventions.Standard for now.
15257 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15259 * expression.cs (Binary.ResolveOperator): Update the values of `l'
15260 and `r' after calling DoNumericPromotions.
15262 * ecore.cs: Fix error message (the types were in the wrong order).
15264 * statement.cs (Foreach.ProbeCollectionType): Need to pass
15265 BindingFlags.Instance as well
15267 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
15268 implicit int literal conversion in an empty cast so that we
15269 propagate the right type upstream.
15271 (UnboxCast): new class used to unbox value types.
15272 (Expression.ConvertExplicit): Add explicit type conversions done
15275 (Expression.ImplicitNumericConversion): Oops, forgot to test for
15276 the target type before applying the implicit LongLiterals to ULong
15279 2001-11-21 Miguel de Icaza <miguel@ximian.com>
15281 * cs-parser.jay (for_statement): Reworked the way For works: now
15282 we declare manually any variables that are introduced in
15283 for_initializer to solve the problem of having out-of-band code
15284 emition (that is what got for broken).
15286 (declaration_statement): Perform the actual variable declaration
15287 that used to be done in local_variable_declaration here.
15289 (local_variable_declaration): Do not declare anything, just pass
15290 the information on a DictionaryEntry
15292 2001-11-20 Ravi Pratap <ravi@ximian.com>
15294 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
15295 re-write of the logic to now make it recursive.
15297 (UpdateIndices): Re-write accordingly.
15299 Store element data in a separate ArrayData list in the above methods.
15301 (MakeByteBlob): Implement to dump the array data into a byte array.
15303 2001-11-19 Ravi Pratap <ravi@ximian.com>
15305 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
15308 * constant.cs (Define): Implement.
15310 (EmitConstant): Re-write fully.
15312 Pass in location info.
15314 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
15317 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
15318 DictionaryEntry since we need location info too.
15320 (constant_declaration): Update accordingly.
15322 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
15323 code into another method : UpdateIndices.
15325 2001-11-18 Ravi Pratap <ravi@ximian.com>
15327 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
15328 some type checking etc.
15330 2001-11-17 Ravi Pratap <ravi@ximian.com>
15332 * expression.cs (ArrayCreation::ValidateInitializers): Implement
15333 bits to provide dimension info if the user skips doing that.
15335 Update second constructor to store the rank correctly.
15337 2001-11-16 Ravi Pratap <ravi@ximian.com>
15339 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
15340 and try to implement.
15342 * ../errors/cs0150.cs : Add.
15344 * ../errors/cs0178.cs : Add.
15346 2001-11-16 Miguel de Icaza <miguel@ximian.com>
15348 * statement.cs: Implement foreach on multi-dimensional arrays.
15350 * parameter.cs (Parameters.GetParameterByName): Also lookup the
15351 name of the params argument.
15353 * expression.cs: Use EmitStoreOpcode to get the right opcode while
15354 initializing the array.
15356 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
15357 we can use this elsewhere.
15359 * statement.cs: Finish implementation of foreach for single
15362 * cs-parser.jay: Use an out-of-band stack to pass information
15363 around, I wonder why I need this.
15365 foreach_block: Make the new foreach_block the current_block.
15367 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
15368 function used to return a static Parameters structure. Used for
15369 empty parameters, as those are created very frequently.
15371 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
15373 2001-11-15 Ravi Pratap <ravi@ximian.com>
15375 * interface.cs : Default modifier is private, not public. The
15376 make verify test passes again.
15378 2001-11-15 Ravi Pratap <ravi@ximian.com>
15380 * support.cs (ReflectionParameters): Fix logic to determine
15381 whether the last parameter is a params one. Test 9 passes again.
15383 * delegate.cs (Populate): Register the builders we define with
15384 RegisterParameterForBuilder. Test 19 passes again.
15386 * cs-parser.jay (property_declaration): Reference $6 instead
15387 of $$ to get at the location.
15389 (indexer_declaration): Similar stuff.
15391 (attribute): Ditto.
15393 * class.cs (Property): Register parameters for the Get and Set methods
15394 if they exist. Test 23 passes again.
15396 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
15397 call to EmitArguments as we are sure there aren't any params arguments.
15398 Test 32 passes again.
15400 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
15401 IndexOutOfRangeException.
15403 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
15404 Test 33 now passes again.
15406 2001-11-15 Miguel de Icaza <miguel@ximian.com>
15408 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
15409 broke a bunch of things. Will have to come up with a better way
15410 of tracking locations.
15412 * statement.cs: Implemented foreach for single dimension arrays.
15414 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15416 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
15417 an error. This removes the lookup from the critical path.
15419 * cs-parser.jay: Removed use of temporary_loc, which is completely
15422 2001-11-14 Miguel de Icaza <miguel@ximian.com>
15424 * support.cs (ReflectionParameters.ParameterModifier): Report
15425 whether the argument is a PARAMS argument or not.
15427 * class.cs: Set the attribute `ParamArrayAttribute' on the
15428 parameter argument.
15430 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
15431 and cons_param_array_attribute (ConstructorInfo for
15432 ParamArrayAttribute).,
15434 * codegen.cs: Emit the return using the `Return' statement, that
15435 way we can report the error correctly for missing return values.
15437 * class.cs (Method.Emit): Clean up.
15439 * expression.cs (Argument.Resolve): Take another argument: the
15440 location where this argument is used. Notice that this is not
15441 part of the "Argument" class as to reduce the size of the
15442 structure (we know the approximate location anyways).
15444 Test if the argument is a variable-reference, if not, then
15445 complain with a 206.
15447 (Argument.Emit): Emit addresses of variables.
15449 (Argument.FullDesc): Simplify.
15451 (Invocation.DoResolve): Update for Argument.Resolve.
15453 (ElementAccess.DoResolve): ditto.
15455 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
15456 method should be virtual, as this method is always virtual.
15458 (NewDelegate.DoResolve): Update for Argument.Resolve.
15460 * class.cs (ConstructorInitializer.DoResolve): ditto.
15462 * attribute.cs (Attribute.Resolve): ditto.
15464 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15466 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
15468 * expression.cs (ParameterReference): Drop IStackStorage and implement
15469 IAssignMethod instead.
15471 (LocalVariableReference): ditto.
15473 * ecore.cs (FieldExpr): Drop IStackStorage and implement
15474 IAssignMethod instead.
15476 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15478 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
15479 enumerations that are used in heavily used structures derive from
15480 byte in a laughable and pathetic attempt to reduce memory usage.
15481 This is the kind of pre-optimzations that you should not do at
15482 home without adult supervision.
15484 * expression.cs (UnaryMutator): New class, used to handle ++ and
15485 -- separatedly from the other unary operators. Cleans up the
15486 code, and kills the ExpressionStatement dependency in Unary.
15488 (Unary): Removed `method' and `Arguments' from this class, making
15489 it smaller, and moving it all to SimpleCall, so I can reuse this
15490 code in other locations and avoid creating a lot of transient data
15491 strucutres when not required.
15493 * cs-parser.jay: Adjust for new changes.
15495 2001-11-11 Miguel de Icaza <miguel@ximian.com>
15497 * enum.cs (Enum.Populate): If there is a failure during
15500 * cs-parser.jay (opt_enum_base): we used to catch type errors
15501 here, but this is really incorrect. The type error should be
15502 catched during semantic analysis.
15504 2001-12-11 Ravi Pratap <ravi@ximian.com>
15506 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
15507 current_local_parameters as expected since I, in my stupidity, had forgotten
15510 * attribute.cs (GetValidPlaces): Fix stupid bug.
15512 * class.cs (Method::Emit): Perform check on applicability of attributes.
15514 (Constructor::Emit): Ditto.
15516 (Field::Emit): Ditto.
15518 (Field.Location): Store location information.
15520 (Property, Event, Indexer, Operator): Ditto.
15522 * cs-parser.jay (field_declaration): Pass in location for each field.
15524 * ../errors/cs0592.cs : Add.
15526 2001-11-12 Ravi Pratap <ravi@ximian.com>
15528 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
15530 (InitCoreTypes): Update accordingly.
15532 (RegisterAttrType, LookupAttr): Implement.
15534 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
15535 info about the same.
15537 (Resolve): Update to populate the above as necessary.
15539 (Error592): Helper.
15541 (GetValidPlaces): Helper to the above.
15543 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
15545 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
15547 2001-11-12 Ravi Pratap <ravi@ximian.com>
15549 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
15551 * ../errors/cs0617.cs : Add.
15553 2001-11-11 Ravi Pratap <ravi@ximian.com>
15555 * enum.cs (Emit): Rename to Populate to be more consistent with what
15556 we expect it to do and when exactly it is called.
15558 * class.cs, rootcontext.cs : Update accordingly.
15560 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15561 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15563 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15565 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15566 of a fieldinfo using the above, when dealing with a FieldBuilder.
15568 2001-11-10 Ravi Pratap <ravi@ximian.com>
15570 * ../errors/cs0031.cs : Add.
15572 * ../errors/cs1008.cs : Add.
15574 * ../errrors/cs0543.cs : Add.
15576 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15579 (FindMembers): Implement.
15581 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15582 enums and delegates too.
15584 (enum_types): Rename to builder_to_enum.
15586 (delegate_types): Rename to builder_to_delegate.
15588 * delegate.cs (FindMembers): Implement.
15590 2001-11-09 Ravi Pratap <ravi@ximian.com>
15592 * typemanager.cs (IsEnumType): Implement.
15594 * enum.cs (Emit): Re-write parts to account for the underlying type
15595 better and perform checking etc.
15597 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15598 of the underlying type.
15600 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15603 * enum.cs (error31): Helper to report error #31.
15605 * cs-parser.jay (enum_declaration): Store location of each member too.
15607 * enum.cs (member_to_location): New hashtable.
15609 (AddEnumMember): Update location hashtable.
15611 (Emit): Use the location of each member while reporting errors.
15613 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15615 * cs-parser.jay: A for_initializer if is a
15616 local_variable_declaration really ammount to have an implicit
15617 block with the variable declaration and no initializer for for.
15619 * statement.cs (For.Emit): Cope with null initializers.
15621 This fixes the infinite loop on for initializers.
15623 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15625 * enum.cs: More cleanup.
15627 * ecore.cs: Remove dead code.
15629 * class.cs (Property.Emit): More simplification.
15630 (Event.Emit): ditto.
15632 Reworked to have less levels of indentation.
15634 2001-11-08 Ravi Pratap <ravi@ximian.com>
15636 * class.cs (Property): Emit attributes.
15646 * enum.cs (Emit): Ditto.
15648 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15651 * class.cs (Field, Event, etc.): Move attribute generation into the
15652 Emit method everywhere.
15654 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15655 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15656 as we had no way of defining nested enums !
15658 * rootcontext.cs : Adjust code accordingly.
15660 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15662 2001-11-07 Ravi Pratap <ravi@ximian.com>
15664 * expression.cs (EvalConstantExpression): Move into ecore.cs
15666 * enum.cs (Enum): Rename some members and make them public and readonly
15667 according to our convention.
15669 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15672 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15674 (Enum::Emit): Write a simple version for now which doesn't try to compute
15675 expressions. I shall modify this to be more robust in just a while.
15677 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15679 (TypeContainer::CloseType): Create the Enum types too.
15681 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15683 * expression.cs (EvalConstantExpression): Get rid of completely.
15685 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15686 user-defined values and other cases.
15688 (IsValidEnumLiteral): Helper function.
15690 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15691 out there in the case we had a literal FieldExpr.
15693 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15695 (Literalize): Revamp a bit to take two arguments.
15697 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15699 2001-11-06 Ravi Pratap <ravi@ximian.com>
15701 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15703 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15705 (Resolve): Use the above to ensure we have proper initializers.
15707 2001-11-05 Ravi Pratap <ravi@ximian.com>
15709 * expression.cs (Expression::EvalConstantExpression): New method to
15710 evaluate constant expressions.
15712 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15714 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15716 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15719 (Binary.ResolveOperator): Handle operator != (object a, object b)
15720 and operator == (object a, object b);
15722 (Binary.DoNumericPromotions): Indicate whether the numeric
15723 promotion was possible.
15725 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15728 Made the ArrayAccess implement interface IAssignMethod instead of
15729 IStackStore as the order in which arguments are passed reflects
15732 * assign.cs: Instead of using expr.ExprClass to select the way of
15733 assinging, probe for the IStackStore/IAssignMethod interfaces.
15735 * typemanager.cs: Load InitializeArray definition.
15737 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15738 static data that can be used to initialize arrays.
15740 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15742 * expression.cs: Handle operator== and operator!= for booleans.
15744 (Conditioal.Reduce): Implement reducer for the ?: operator.
15746 (Conditional.Resolve): Implement dead code elimination.
15748 (Binary.Resolve): Catch string literals and return a new
15749 concatenated string.
15751 (Unary.Reduce): Implement reduction of unary expressions.
15753 * ecore.cs: Split out the expression core handling here.
15755 (Expression.Reduce): New method used to perform constant folding
15756 and CSE. This is needed to support constant-expressions.
15758 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15759 targets, and optimize for !x.
15761 2001-11-04 Ravi Pratap <ravi@ximian.com>
15763 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15764 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15765 set custom atttributes.
15767 * literal.cs (Literal::GetValue): New abstract method to return the actual
15768 value of the literal, cast as an object.
15770 (*Literal): Implement GetValue method.
15772 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15773 expressions to the arraylist but objects of type Argument.
15775 * class.cs (TypeContainer::Emit): Emit our attributes too.
15777 (Method::Emit, Constructor::Emit): Ditto.
15779 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15780 to be ignoring earlier.
15782 2001-11-03 Ravi Pratap <ravi@ximian.com>
15784 * attribute.cs (AttributeSection::Define): Implement to do the business
15785 of constructing a CustomAttributeBuilder.
15787 (Attribute): New trivial class. Increases readability of code.
15789 * cs-parser.jay : Update accordingly.
15791 (positional_argument_list, named_argument_list, named_argument): New rules
15793 (attribute_arguments): Use the above so that we are more correct.
15795 2001-11-02 Ravi Pratap <ravi@ximian.com>
15797 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15798 to perform all checks for a method with a params parameter.
15800 (Invocation::OverloadResolve): Update to use the above method and therefore
15801 cope correctly with params method invocations.
15803 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15806 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15807 constructors in our parent too because we can't afford to miss out on
15810 * attribute.cs (AttributeSection): New name for the class Attribute
15812 Other trivial changes to improve readability.
15814 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15815 use the new class names.
15817 2001-11-01 Ravi Pratap <ravi@ximian.com>
15819 * class.cs (Method::Define): Complete definition for params types too
15821 (Indexer::Define): Ditto.
15823 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15824 Cope everywhere with a request for info about the array parameter.
15826 2001-11-01 Ravi Pratap <ravi@ximian.com>
15828 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15830 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15831 local_variable_type to extract the string corresponding to the type.
15833 (local_variable_type): Fixup the action to use the new helper method.
15835 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15838 * expression.cs : Clean out code which uses the above.
15840 2001-10-31 Ravi Pratap <ravi@ximian.com>
15842 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15843 and bale out if necessary by returning a false.
15845 (RegisterProperty): Ditto.
15847 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15848 and print out appropriate error messages.
15850 * interface.cs (everywhere): Ditto.
15852 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15853 location to constructor.
15855 * class.cs (Property, Event, Indexer): Update accordingly.
15857 * ../errors/cs111.cs : Added.
15859 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15860 of a method, as laid down by the spec.
15862 (Invocation::OverloadResolve): Use the above method.
15864 2001-10-31 Ravi Pratap <ravi@ximian.com>
15866 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15867 now take a TypeContainer and a Parameters object.
15869 (ParameterData): Modify return type of ParameterModifier method to be
15870 Parameter.Modifier and not a string.
15872 (ReflectionParameters, InternalParameters): Update accordingly.
15874 * expression.cs (Argument::GetParameterModifier): Same here.
15876 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15877 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15878 symbol in it at all so maybe this is only for now.
15880 2001-10-30 Ravi Pratap <ravi@ximian.com>
15882 * support.cs (InternalParameters): Constructor now takes an extra argument
15883 which is the actual Parameters class.
15885 (ParameterDesc): Update to provide info on ref/out modifiers.
15887 * class.cs (everywhere): Update call to InternalParameters to pass in
15888 the second argument too.
15890 * support.cs (ParameterData): Add ParameterModifier, which is a method
15891 to return the modifier info [ref/out etc]
15893 (InternalParameters, ReflectionParameters): Implement the above.
15895 * expression.cs (Argument::ParameterModifier): Similar function to return
15896 info about the argument's modifiers.
15898 (Invocation::OverloadResolve): Update to take into account matching modifiers
15901 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15902 a new SetFormalParameters object which we pass to InternalParameters.
15904 2001-10-30 Ravi Pratap <ravi@ximian.com>
15906 * expression.cs (NewArray): Merge into the ArrayCreation class.
15908 2001-10-29 Ravi Pratap <ravi@ximian.com>
15910 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15911 NewUserdefinedArray into one as there wasn't much of a use in having
15914 * expression.cs (Argument): Change field's name to ArgType from Type.
15916 (Type): New readonly property which returns the proper type, taking into
15917 account ref/out modifiers.
15919 (everywhere): Adjust code accordingly for the above.
15921 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15922 whether we are emitting for a ref or out parameter.
15924 * expression.cs (Argument::Emit): Use the above field to set the state.
15926 (LocalVariableReference::Emit): Update to honour the flag and emit the
15929 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15931 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15933 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15935 (ReflectionParameters, InternalParameters): Implement the above method.
15937 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15940 (Invocation::FullMethodDesc): Ditto.
15942 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15944 * cs-parser.jay: Add extra production for the second form of array
15947 * expression.cs (ArrayCreation): Update to reflect the above
15950 * Small changes to prepare for Array initialization.
15952 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15954 * typemanager.cs (ImplementsInterface): interface might be null;
15955 Deal with this problem;
15957 Also, we do store negative hits on the cache (null values), so use
15958 this instead of calling t.GetInterfaces on the type everytime.
15960 2001-10-28 Ravi Pratap <ravi@ximian.com>
15962 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15964 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15965 split functionality out into different classes.
15967 (New::FormArrayType): Move into NewBuiltinArray.
15969 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15972 (NewBuiltinArray): New class to handle creation of built-in arrays.
15974 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15975 account creation of one-dimensional arrays.
15977 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15979 (NewUserdefinedArray::DoResolve): Implement.
15981 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15983 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15984 we maintain inside the TypeManager. This is necessary to perform lookups on the
15987 (LookupType): Update to perform GetType on the module builders too.
15989 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15991 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15993 2001-10-23 Ravi Pratap <ravi@ximian.com>
15995 * expression.cs (New::DoResolve): Implement guts of array creation.
15997 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15999 2001-10-27 Miguel de Icaza <miguel@ximian.com>
16001 * expression.cs: Fix bug I introduced lsat night that broke
16004 (Expression.Resolve): Report a 246 error (can not resolve name)
16005 if we find a SimpleName in the stream.
16007 (Expression.ResolveLValue): Ditto.
16009 (Expression.ResolveWithSimpleName): This function is a variant of
16010 ResolveName, this one allows SimpleNames to be returned without a
16011 warning. The only consumer of SimpleNames is MemberAccess
16013 2001-10-26 Miguel de Icaza <miguel@ximian.com>
16015 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
16016 might arrive here. I have my doubts that this is correct.
16018 * statement.cs (Lock): Implement lock statement.
16020 * cs-parser.jay: Small fixes to support `lock' and `using'
16022 * cs-tokenizer.cs: Remove extra space
16024 * driver.cs: New flag --checked, allows to turn on integer math
16027 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
16028 Threading.Monitor.Exit
16030 2001-10-23 Miguel de Icaza <miguel@ximian.com>
16032 * expression.cs (IndexerAccess::DoResolveLValue): Set the
16033 Expression Class to be IndexerAccess.
16035 Notice that Indexer::DoResolve sets the eclass to Value.
16037 2001-10-22 Miguel de Icaza <miguel@ximian.com>
16039 * class.cs (TypeContainer::Emit): Emit code for indexers.
16041 * assign.cs (IAssignMethod): New interface implemented by Indexers
16042 and Properties for handling assignment.
16044 (Assign::Emit): Simplify and reuse code.
16046 * expression.cs (IndexerAccess, PropertyExpr): Implement
16047 IAssignMethod, clean up old code.
16049 2001-10-22 Ravi Pratap <ravi@ximian.com>
16051 * typemanager.cs (ImplementsInterface): New method to determine if a type
16052 implements a given interface. Provides a nice cache too.
16054 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
16057 (ConvertReferenceExplicit): Ditto.
16059 * delegate.cs (Delegate::Populate): Update to define the parameters on the
16060 various methods, with correct names etc.
16062 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
16063 Operator.UnaryNegation.
16065 * cs-parser.jay (operator_declarator): Be a little clever in the case where
16066 we have a unary plus or minus operator.
16068 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
16071 * everywhere : update accordingly.
16073 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
16076 * class.cs (Method::Define): For the case where we are implementing a method
16077 inherited from an interface, we need to set the MethodAttributes.Final flag too.
16078 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
16080 2001-10-21 Ravi Pratap <ravi@ximian.com>
16082 * interface.cs (FindMembers): Implement to work around S.R.E
16085 * typemanager.cs (IsInterfaceType): Implement.
16087 (FindMembers): Update to handle interface types too.
16089 * expression.cs (ImplicitReferenceConversion): Re-write bits which
16090 use IsAssignableFrom as that is not correct - it doesn't work.
16092 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
16093 and accordingly override EmitStatement.
16095 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
16096 using the correct logic :-)
16098 2001-10-19 Ravi Pratap <ravi@ximian.com>
16100 * ../errors/cs-11.cs : Add to demonstrate error -11
16102 2001-10-17 Miguel de Icaza <miguel@ximian.com>
16104 * assign.cs (Assign::Resolve): Resolve right hand side first, and
16105 then pass this as a hint to ResolveLValue.
16107 * expression.cs (FieldExpr): Add Location information
16109 (FieldExpr::LValueResolve): Report assignment to readonly
16112 (Expression::ExprClassFromMemberInfo): Pass location information.
16114 (Expression::ResolveLValue): Add new method that resolves an
16117 (Expression::DoResolveLValue): Default invocation calls
16120 (Indexers): New class used to keep track of indexers in a given
16123 (IStackStore): Renamed from LValue, as it did not really describe
16124 what this did. Also ResolveLValue is gone from this interface and
16125 now is part of Expression.
16127 (ElementAccess): Depending on the element access type
16129 * typemanager.cs: Add `indexer_name_type' as a Core type
16130 (System.Runtime.CompilerServices.IndexerNameAttribute)
16132 * statement.cs (Goto): Take a location.
16134 2001-10-18 Ravi Pratap <ravi@ximian.com>
16136 * delegate.cs (Delegate::VerifyDelegate): New method to verify
16137 if two delegates are compatible.
16139 (NewDelegate::DoResolve): Update to take care of the case when
16140 we instantiate a delegate from another delegate.
16142 * typemanager.cs (FindMembers): Don't even try to look up members
16143 of Delegate types for now.
16145 2001-10-18 Ravi Pratap <ravi@ximian.com>
16147 * delegate.cs (NewDelegate): New class to take care of delegate
16150 * expression.cs (New): Split the delegate related code out into
16151 the NewDelegate class.
16153 * delegate.cs (DelegateInvocation): New class to handle delegate
16156 * expression.cs (Invocation): Split out delegate related code into
16157 the DelegateInvocation class.
16159 2001-10-17 Ravi Pratap <ravi@ximian.com>
16161 * expression.cs (New::DoResolve): Implement delegate creation fully
16162 and according to the spec.
16164 (New::DoEmit): Update to handle delegates differently.
16166 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
16167 because of which we were printing out arguments in reverse order !
16169 * delegate.cs (VerifyMethod): Implement to check if the given method
16170 matches the delegate.
16172 (FullDelegateDesc): Implement.
16174 (VerifyApplicability): Implement.
16176 * expression.cs (Invocation::DoResolve): Update to accordingly handle
16177 delegate invocations too.
16179 (Invocation::Emit): Ditto.
16181 * ../errors/cs1593.cs : Added.
16183 * ../errors/cs1594.cs : Added.
16185 * delegate.cs (InstanceExpression, TargetMethod): New properties.
16187 2001-10-16 Ravi Pratap <ravi@ximian.com>
16189 * typemanager.cs (intptr_type): Core type for System.IntPtr
16191 (InitCoreTypes): Update for the same.
16193 (iasyncresult_type, asynccallback_type): Ditto.
16195 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
16198 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
16201 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
16202 the builders for the 4 members of a delegate type :-)
16204 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
16207 * expression.cs (New::DoResolve): Implement guts for delegate creation.
16209 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
16211 2001-10-15 Miguel de Icaza <miguel@ximian.com>
16213 * statement.cs (Break::Emit): Implement.
16214 (Continue::Emit): Implement.
16216 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
16217 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
16218 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
16219 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
16222 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
16223 properties that track the label for the current loop (begin of the
16224 loop and end of the loop).
16226 2001-10-15 Ravi Pratap <ravi@ximian.com>
16228 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
16229 use of emitting anything at all.
16231 * class.cs, rootcontext.cs : Get rid of calls to the same.
16233 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
16235 (Populate): Define the constructor correctly and set the implementation
16238 * typemanager.cs (delegate_types): New hashtable to hold delegates that
16241 (AddDelegateType): Implement.
16243 (IsDelegateType): Implement helper method.
16245 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
16247 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
16248 and accordingly handle it.
16250 * delegate.cs (Populate): Take TypeContainer argument.
16251 Implement bits to define the Invoke method. However, I still haven't figured out
16252 how to take care of the native int bit :-(
16254 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
16255 Qualify the name of the delegate, not its return type !
16257 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
16260 (StandardConversionExists): Checking for array types turns out to be recursive.
16262 (ConvertReferenceExplicit): Implement array conversion.
16264 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
16266 2001-10-12 Ravi Pratap <ravi@ximian.com>
16268 * cs-parser.jay (delegate_declaration): Store the fully qualified
16269 name as it is a type declaration.
16271 * delegate.cs (ReturnType, Name): Rename members to these. Make them
16274 (DefineDelegate): Renamed from Define. Does the same thing essentially,
16275 as TypeContainer::DefineType.
16277 (Populate): Method in which all the definition of the various methods (Invoke)
16280 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
16283 (CloseDelegate): Finally creates the delegate.
16285 * class.cs (TypeContainer::DefineType): Update to define delegates.
16286 (Populate, Emit and CloseType): Do the same thing here too.
16288 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
16289 delegates in all these operations.
16291 2001-10-14 Miguel de Icaza <miguel@ximian.com>
16293 * expression.cs: LocalTemporary: a new expression used to
16294 reference a temporary that has been created.
16296 * assign.cs: Handle PropertyAccess back here, so that we can
16297 provide the proper semantic access to properties.
16299 * expression.cs (Expression::ConvertReferenceExplicit): Implement
16300 a few more explicit conversions.
16302 * modifiers.cs: `NEW' modifier maps to HideBySig.
16304 * expression.cs (PropertyExpr): Make this into an
16305 ExpressionStatement, and support the EmitStatement code path.
16307 Perform get/set error checking, clean up the interface.
16309 * assign.cs: recognize PropertyExprs as targets, and if so, turn
16310 them into toplevel access objects.
16312 2001-10-12 Miguel de Icaza <miguel@ximian.com>
16314 * expression.cs: PropertyExpr::PropertyExpr: use work around the
16317 * typemanager.cs: Keep track here of our PropertyBuilders again to
16318 work around lameness in SRE.
16320 2001-10-11 Miguel de Icaza <miguel@ximian.com>
16322 * expression.cs (LValue::LValueResolve): New method in the
16323 interface, used to perform a second resolution pass for LValues.
16325 (This::DoResolve): Catch the use of this in static methods.
16327 (This::LValueResolve): Implement.
16329 (This::Store): Remove warning, assigning to `this' in structures
16332 (Invocation::Emit): Deal with invocation of
16333 methods on value types. We need to pass the address to structure
16334 methods rather than the object itself. (The equivalent code to
16335 emit "this" for structures leaves the entire structure on the
16336 stack instead of a pointer to it).
16338 (ParameterReference::DoResolve): Compute the real index for the
16339 argument based on whether the method takes or not a `this' pointer
16340 (ie, the method is static).
16342 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
16343 value types returned from functions when we need to invoke a
16344 method on the sturcture.
16347 2001-10-11 Ravi Pratap <ravi@ximian.com>
16349 * class.cs (TypeContainer::DefineType): Method to actually do the business of
16350 defining the type in the Modulebuilder or Typebuilder. This is to take
16351 care of nested types which need to be defined on the TypeBuilder using
16352 DefineNestedMethod.
16354 (TypeContainer::GetClassBases): Implement. Essentially the code from the
16355 methods in RootContext, only ported to be part of TypeContainer.
16357 (TypeContainer::GetInterfaceOrClass): Ditto.
16359 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
16361 * interface.cs (Interface::DefineInterface): New method. Does exactly
16362 what RootContext.CreateInterface did earlier, only it takes care of nested types
16365 (Interface::GetInterfaces): Move from RootContext here and port.
16367 (Interface::GetInterfaceByName): Same here.
16369 * rootcontext.cs (ResolveTree): Re-write.
16371 (PopulateTypes): Re-write.
16373 * class.cs (TypeContainer::Populate): Populate nested types too.
16374 (TypeContainer::Emit): Emit nested members too.
16376 * typemanager.cs (AddUserType): Do not make use of the FullName property,
16377 instead just use the name argument passed in as it is already fully
16380 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
16381 to TypeContainer mapping to see if a type is user-defined.
16383 * class.cs (TypeContainer::CloseType): Implement.
16385 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
16386 the default constructor.
16388 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
16391 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
16393 * interface.cs (CloseType): Create the type here.
16395 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
16398 Remove all the methods which are now in TypeContainer.
16400 2001-10-10 Ravi Pratap <ravi@ximian.com>
16402 * delegate.cs (Define): Re-write bits to define the delegate
16405 2001-10-10 Miguel de Icaza <miguel@ximian.com>
16407 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
16409 * expression.cs (ImplicitReferenceConversion): handle null as well
16410 as a source to convert to any reference type.
16412 * statement.cs (Return): Perform any implicit conversions to
16413 expected return type.
16415 Validate use of return statement.
16417 * codegen.cs (EmitContext): Pass the expected return type here.
16419 * class.cs (Method, Constructor, Property): Pass expected return
16420 type to EmitContext.
16422 2001-10-09 Miguel de Icaza <miguel@ximian.com>
16424 * expression.cs: Make DoResolve take an EmitContext instead of a
16427 Replaced `l' and `location' for `loc', for consistency.
16429 (Error, Warning): Remove unneeded Tc argument.
16431 * assign.cs, literal.cs, constant.cs: Update to new calling
16434 * codegen.cs: EmitContext now contains a flag indicating whether
16435 code is being generated in a static method or not.
16437 * cs-parser.jay: DecomposeQI, new function that replaces the old
16438 QualifiedIdentifier. Now we always decompose the assembled
16439 strings from qualified_identifier productions into a group of
16442 2001-10-08 Miguel de Icaza <miguel@ximian.com>
16444 * rootcontext.cs: Deal with field-less struct types correctly now
16445 by passing the size option to Define Type.
16447 * class.cs: Removed hack that created one static field.
16449 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16451 * statement.cs: Moved most of the code generation here.
16453 2001-10-09 Ravi Pratap <ravi@ximian.com>
16455 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
16458 (ElementAccess): Remove useless bits for now - keep checks as the spec
16461 2001-10-08 Ravi Pratap <ravi@ximian.com>
16463 * expression.cs (ElementAccess::DoResolve): Remove my crap code
16464 and start performing checks according to the spec.
16466 2001-10-07 Ravi Pratap <ravi@ximian.com>
16468 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
16469 rank_specifiers instead.
16471 (rank_specifiers): Change the order in which the rank specifiers are stored
16473 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
16475 * expression.cs (ElementAccess): Implement the LValue interface too.
16477 2001-10-06 Ravi Pratap <ravi@ximian.com>
16479 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
16480 except that user defined conversions are not included.
16482 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
16483 perform the conversion of the return type, if necessary.
16485 (New::DoResolve): Check whether we are creating an array or an object
16486 and accordingly do the needful.
16488 (New::Emit): Same here.
16490 (New::DoResolve): Implement guts of array creation.
16492 (New::FormLookupType): Helper function.
16494 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16496 * codegen.cs: Removed most of the code generation here, and move the
16497 corresponding code generation bits to the statement classes.
16499 Added support for try/catch/finalize and throw.
16501 * cs-parser.jay: Added support for try/catch/finalize.
16503 * class.cs: Catch static methods having the flags override,
16504 virtual or abstract.
16506 * expression.cs (UserCast): This user cast was not really doing
16507 what it was supposed to do. Which is to be born in fully resolved
16508 state. Parts of the resolution were being performed at Emit time!
16512 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16514 * expression.cs: Implicity convert the result from UserCast.
16516 2001-10-05 Ravi Pratap <ravi@ximian.com>
16518 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
16519 prevented it from working correctly.
16521 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
16522 merely ConvertImplicit.
16524 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16526 * typemanager.cs: Make the LookupTypeContainer function static,
16527 and not per-instance.
16529 * class.cs: Make static FindMembers (the one that takes a Type
16532 * codegen.cs: Add EmitForeach here.
16534 * cs-parser.jay: Make foreach a toplevel object instead of the
16535 inline expansion, as we need to perform semantic analysis on it.
16537 2001-10-05 Ravi Pratap <ravi@ximian.com>
16539 * expression.cs (Expression::ImplicitUserConversion): Rename to
16540 UserDefinedConversion.
16542 (Expression::UserDefinedConversion): Take an extra argument specifying
16543 whether we look for explicit user conversions too.
16545 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
16547 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
16549 (ExplicitUserConversion): Make it a call to UserDefinedConversion
16550 with the appropriate arguments.
16552 * cs-parser.jay (cast_expression): Record location too.
16554 * expression.cs (Cast): Record location info.
16556 (Expression::ConvertExplicit): Take location argument.
16558 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16559 to determine if we are doing explicit conversions.
16561 (UserCast::Emit): Update accordingly.
16563 (Expression::ConvertExplicit): Report an error if everything fails.
16565 * ../errors/cs0030.cs : Add.
16567 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16569 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16570 virtual and newslot bits.
16572 * class.cs (TypeContainer::RegisterRequiredImplementations):
16573 Record methods we need.
16575 (TypeContainer::MakeKey): Helper function to make keys for
16576 MethodBases, since the Methodbase key is useless.
16578 (TypeContainer::Populate): Call RegisterRequiredImplementations
16579 before defining the methods.
16581 Create a mapping for method_builders_to_methods ahead of time
16582 instead of inside a tight loop.
16584 (::RequireMethods): Accept an object as the data to set into the
16585 hashtable so we can report interface vs abstract method mismatch.
16587 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16589 * report.cs: Make all of it static.
16591 * rootcontext.cs: Drop object_type and value_type computations, as
16592 we have those in the TypeManager anyways.
16594 Drop report instance variable too, now it is a global.
16596 * driver.cs: Use try/catch on command line handling.
16598 Add --probe option to debug the error reporting system with a test
16601 * report.cs: Add support for exiting program when a probe
16602 condition is reached.
16604 2001-10-03 Ravi Pratap <ravi@ximian.com>
16606 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16607 we do a forcible conversion regardless of type, to check if
16608 ForceConversion returns a null.
16610 (Binary::error19): Use location to report error.
16612 (Unary::error23): Use location here too.
16614 * ../errors/cs0019.cs : Check in.
16616 * ../errors/cs0023.cs : Check in.
16618 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16619 case of a non-null MethodInfo object with a length of 0 !
16621 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16622 an applicable member - according to the spec :-)
16623 Also fix logic to find members in base types.
16625 (Unary::ResolveOperator): Same here.
16627 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16628 as I was getting thoroughly confused between this and error19 :-)
16630 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16631 (::FindMostEncompassedType): Implement.
16632 (::FindMostEncompassingType): Implement.
16633 (::StandardConversionExists): Implement.
16635 (UserImplicitCast): Re-vamp. We now need info about most specific
16636 source and target types so that we can do the necessary conversions.
16638 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16639 mathematical union with no duplicates.
16641 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16643 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16644 in order from base classes to child classes, so that we can in
16645 child classes look up in our parent for method names and
16646 attributes (required for handling abstract, virtual, new, override
16647 constructs: we need to instrospect our base class, and if we dont
16648 populate the classes in order, the introspection might be
16649 incorrect. For example, a method could query its parent before
16650 the parent has any methods and would determine that the parent has
16651 no abstract methods (while it could have had them)).
16653 (RootContext::CreateType): Record the order in which we define the
16656 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16658 * class.cs (TypeContainer::Populate): Also method definitions can
16659 fail now, keep track of this.
16661 (TypeContainer::FindMembers): Implement support for
16662 DeclaredOnly/noDeclaredOnly flag.
16664 (Constructor::Emit) Return the ConstructorBuilder.
16666 (Method::Emit) Return the MethodBuilder.
16667 Check for abstract or virtual methods to be public.
16669 * rootcontext.cs (RootContext::CreateType): Register all the
16670 abstract methods required for the class to be complete and the
16671 interface methods that must be implemented.
16673 * cs-parser.jay: Report error 501 (method requires body if it is
16674 not marked abstract or extern).
16676 * expression.cs (TypeOf::Emit): Implement.
16678 * typemanager.cs: runtime_handle_type, new global type.
16680 * class.cs (Property::Emit): Generate code for properties.
16682 2001-10-02 Ravi Pratap <ravi@ximian.com>
16684 * expression.cs (Unary::ResolveOperator): Find operators on base type
16685 too - we now conform exactly to the spec.
16687 (Binary::ResolveOperator): Same here.
16689 * class.cs (Operator::Define): Fix minor quirk in the tests.
16691 * ../errors/cs0215.cs : Added.
16693 * ../errors/cs0556.cs : Added.
16695 * ../errors/cs0555.cs : Added.
16697 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16699 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16700 single integer which is really efficient
16702 2001-10-01 Ravi Pratap <ravi@ximian.com>
16704 * expression.cs (Expression::ImplicitUserConversion): Use location
16705 even in the case when we are examining True operators.
16707 * class.cs (Operator::Define): Perform extensive checks to conform
16708 with the rules for operator overloading in the spec.
16710 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16711 some of the other conversions mentioned in the spec.
16713 * typemanager.cs (array_type): New static member for the System.Array built-in
16716 (cloneable_interface): For System.ICloneable interface.
16718 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16719 we start resolving the tree and populating types.
16721 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16723 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16725 * expression.cs (Expression::ExprClassFromMemberInfo,
16726 Expression::Literalize): Create literal expressions from
16727 FieldInfos which are literals.
16729 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16730 type casts, because they were wrong. The test suite in tests
16733 (ImplicitNumericConversion): ushort to ulong requires a widening
16736 Int32 constant to long requires widening cast as well.
16738 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16739 for integers because the type on the stack is not i4.
16741 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16743 * expression.cs (report118): require location argument.
16745 * parameter.cs: Do not dereference potential null value.
16747 * class.cs: Catch methods that lack the `new' keyword when
16748 overriding a name. Report warnings when `new' is used without
16749 anything being there to override.
16751 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16753 * class.cs: Only add constructor to hashtable if it is non-null
16754 (as now constructors can fail on define).
16756 (TypeManager, Class, Struct): Take location arguments.
16758 Catch field instance initialization in structs as errors.
16760 accepting_filter: a new filter for FindMembers that is static so
16761 that we dont create an instance per invocation.
16763 (Constructor::Define): Catch errors where a struct constructor is
16766 * cs-parser.jay: Pass location information for various new
16769 * delegate.cs (Delegate): take a location argument.
16771 * driver.cs: Do not call EmitCode if there were problesm in the
16772 Definition of the types, as many Builders wont be there.
16774 * decl.cs (Decl::Decl): Require a location argument.
16776 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16777 into integers, and find the most appropiate integer for it.
16779 * literal.cs: Implement ULongLiteral.
16781 * rootcontext.cs: Provide better information about the location of
16782 failure when CreateType fails.
16784 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16786 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16789 * expression.cs (Binary::CheckShiftArguments): Add missing type
16791 (Binary::ResolveOperator): Add type to the logical and and logical
16792 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16795 (Binary::DoNumericPromotions): In the case where either argument
16796 is ulong (and most signed types combined with ulong cause an
16797 error) perform implicit integer constant conversions as well.
16799 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16801 * expression.cs (UserImplicitCast): Method should always be
16803 (Invocation::BetterConversion): Simplified test for IntLiteral.
16805 (Expression::ImplicitNumericConversion): Split this routine out.
16806 Put the code that performs implicit constant integer conversions
16809 (Expression::Resolve): Become a wrapper around DoResolve so we can
16810 check eclass and type being set after resolve.
16812 (Invocation::Badness): Remove this dead function
16814 (Binary::ResolveOperator): Do not compute the expensive argumnets
16815 unless we have a union for it.
16817 (Probe::Emit): Is needs to do an isinst and then
16818 compare against null.
16820 (::CanConvert): Added Location argument. If the Location argument
16821 is null (Location.Null), then we do not report errors. This is
16822 used by the `probe' mechanism of the Explicit conversion. We do
16823 not want to generate an error for something that the user
16824 explicitly requested to be casted. But the pipeline for an
16825 explicit cast first tests for potential implicit casts.
16827 So for now, if the Location is null, it means `Probe only' to
16828 avoid adding another argument. Might have to revise this
16831 (ClassCast): New class used to type cast objects into arbitrary
16832 classes (used in Explicit Reference Conversions).
16834 Implement `as' as well.
16836 Reverted all the patches from Ravi below: they were broken:
16838 * The use of `level' as a mechanism to stop recursive
16839 invocations is wrong. That was there just to catch the
16840 bug with a strack trace but not as a way of addressing
16843 To fix the problem we have to *understand* what is going
16844 on and the interactions and come up with a plan, not
16845 just get things going.
16847 * The use of the type conversion cache that I proposed
16848 last night had an open topic: How does this work across
16849 protection domains. A user defined conversion might not
16850 be public in the location where we are applying the
16851 conversion, a different conversion might be selected
16852 (ie, private A->B (better) but public B->A (worse),
16853 inside A, A->B applies, but outside it, B->A will
16856 * On top of that (ie, even if the above is solved),
16857 conversions in a cache need to be abstract. Ie, `To
16858 convert from an Int to a Short use an OpcodeCast', not
16859 `To convert from an Int to a Short use the OpcodeCast on
16860 the variable 5' (which is what this patch was doing).
16862 2001-09-28 Ravi Pratap <ravi@ximian.com>
16864 * expression.cs (Invocation::ConversionExists): Re-write to use
16865 the conversion cache
16867 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16868 cache all conversions done, not just user-defined ones.
16870 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16871 to determine if a conversion exists instead of acutually trying to
16872 perform the conversion. It's faster too.
16874 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16875 and only then attempt the implicit conversion.
16877 2001-09-28 Ravi Pratap <ravi@ximian.com>
16879 * expression.cs (ConvertImplicit): Use a cache for conversions
16880 already found. Check level of recursion and bail out if necessary.
16882 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16884 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16885 Export standard methods that we expect for string operations.
16887 * statement.cs (Block::UsageWarning): Track usage of variables and
16888 report the errors for not used variables.
16890 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16893 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16895 * codegen.cs: remove unnneded code
16897 * expression.cs: Removed BuiltinTypeAccess class
16899 Fix the order in which implicit conversions are
16902 The previous fixed dropped support for boxed conversions (adding a
16903 test to the test suite now)
16905 (UserImplicitCast::CanConvert): Remove test for source being null,
16906 that code is broken. We should not feed a null to begin with, if
16907 we do, then we should track the bug where the problem originates
16908 and not try to cover it up here.
16910 Return a resolved expression of type UserImplicitCast on success
16911 rather than true/false. Ravi: this is what I was talking about,
16912 the pattern is to use a static method as a "constructor" for
16915 Also, do not create arguments until the very last minute,
16916 otherwise we always create the arguments even for lookups that
16917 will never be performed.
16919 (UserImplicitCast::Resolve): Eliminate, objects of type
16920 UserImplicitCast are born in a fully resolved state.
16922 * typemanager.cs (InitCoreTypes): Init also value_type
16923 (System.ValueType).
16925 * expression.cs (Cast::Resolve): First resolve the child expression.
16927 (LValue): Add new method AddressOf to be used by
16930 Change the argument of Store to take an EmitContext instead of an
16931 ILGenerator, because things like FieldExpr need to be able to call
16932 their children expression to generate the instance code.
16934 (Expression::Error, Expression::Warning): Sugar functions for
16937 (Expression::MemberLookup): Accept a TypeContainer instead of a
16938 Report as the first argument.
16940 (Expression::ResolvePrimary): Killed. I still want to improve
16941 this as currently the code is just not right.
16943 (Expression::ResolveMemberAccess): Simplify, but it is still
16946 (Unary::Resolve): Catch errors in AddressOf operators.
16948 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16949 index to a byte for the short-version, or the compiler will choose
16950 the wrong Emit call, which generates the wrong data.
16952 (ParameterReference::Emit, ::Store): same.
16954 (FieldExpr::AddressOf): Implement.
16956 * typemanager.cs: TypeManager: made public variable instead of
16959 * driver.cs: document --fatal.
16961 * report.cs (ErrorMessage, WarningMessage): new names for the old
16962 Error and Warning classes.
16964 * cs-parser.jay (member_access): Turn built-in access to types
16965 into a normal simplename
16967 2001-09-27 Ravi Pratap <ravi@ximian.com>
16969 * expression.cs (Invocation::BetterConversion): Fix to cope
16970 with q being null, since this was introducing a bug.
16972 * expression.cs (ConvertImplicit): Do built-in conversions first.
16974 2001-09-27 Ravi Pratap <ravi@ximian.com>
16976 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16978 2001-09-27 Ravi Pratap <ravi@ximian.com>
16980 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16981 I had introduced long ago (what's new ?).
16983 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16984 the work of all the checking.
16985 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16986 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16988 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16989 that is the right way.
16991 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16992 overloading resolution. Use everywhere instead of cutting and pasting code.
16994 (Binary::ResolveOperator): Use MakeUnionSet.
16996 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16997 we have to convert to bool types. Not complete yet.
16999 2001-09-27 Miguel de Icaza <miguel@ximian.com>
17001 * typemanager.cs (TypeManager::CSharpName): support ushort.
17003 * expression.cs (Expression::TryImplicitIntConversion): Attempts
17004 to provide an expression that performsn an implicit constant int
17005 conversion (section 6.1.6).
17006 (Expression::ConvertImplicitRequired): Reworked to include
17007 implicit constant expression conversions.
17009 (Expression::ConvertNumericExplicit): Finished.
17011 (Invocation::Emit): If InstanceExpression is null, then it means
17012 that we perform a call on this.
17014 2001-09-26 Miguel de Icaza <miguel@ximian.com>
17016 * expression.cs (Unary::Emit): Remove some dead code.
17017 (Probe): Implement Resolve and Emit for `is'.
17018 (Expression::ConvertImplicitRequired): Attempt to do constant
17019 expression conversions here. Maybe should be moved to
17020 ConvertImplicit, but I am not sure.
17021 (Expression::ImplicitLongConstantConversionPossible,
17022 Expression::ImplicitIntConstantConversionPossible): New functions
17023 that tell whether is it possible to apply an implicit constant
17024 expression conversion.
17026 (ConvertNumericExplicit): Started work on explicit numeric
17029 * cs-parser.jay: Update operator constants.
17031 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
17032 (Parameters::GetSignature): Hook up VerifyArgs here.
17033 (Parameters::VerifyArgs): Verifies that no two arguments have the
17036 * class.cs (Operator): Update the operator names to reflect the
17037 ones that the spec expects (as we are just stringizing the
17040 * expression.cs (Unary::ResolveOperator): Fix bug: Use
17041 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
17042 previous usage did only work for our methods.
17043 (Expression::ConvertImplicit): Handle decimal implicit numeric
17044 conversions as well.
17045 (Expression::InternalTypeConstructor): Used to invoke constructors
17046 on internal types for default promotions.
17048 (Unary::Emit): Implement special handling for the pre/post
17049 increment/decrement for overloaded operators, as they need to have
17050 the same semantics as the other operators.
17052 (Binary::ResolveOperator): ditto.
17053 (Invocation::ConversionExists): ditto.
17054 (UserImplicitCast::Resolve): ditto.
17056 2001-09-26 Ravi Pratap <ravi@ximian.com>
17058 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
17059 operator, return after emitting body. Regression tests pass again !
17061 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
17062 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
17063 (Invocation::OverloadResolve): Ditto.
17064 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
17066 * everywhere : update calls to the above methods accordingly.
17068 2001-09-26 Miguel de Icaza <miguel@ximian.com>
17070 * assign.cs (Assign): Make it inherit from ExpressionStatement.
17072 * expression.cs (ExpressionStatement): New base class used for
17073 expressions that can appear in statements, so that we can provide
17074 an alternate path to generate expression that do not leave a value
17077 (Expression::Emit, and all the derivatives): We no longer return
17078 whether a value is left on the stack or not. Every expression
17079 after being emitted leaves a single value on the stack.
17081 * codegen.cs (EmitContext::EmitStatementExpression): Use the
17082 facilties of ExpressionStatement if possible.
17084 * cs-parser.jay: Update statement_expression.
17086 2001-09-25 Miguel de Icaza <miguel@ximian.com>
17088 * driver.cs: Change the wording of message
17090 2001-09-25 Ravi Pratap <ravi@ximian.com>
17092 * expression.cs (Binary::ResolveOperator): Had forgottten to set
17093 the type of the expression to the return type of the method if
17094 we have an overloaded operator match ! The regression tests pass again !
17095 (Unary::ResolveOperator): Ditto.
17097 * expression.cs (Invocation::ConversionExists): Correct the member lookup
17098 to find "op_Implicit", not "implicit" ;-)
17099 (UserImplicitCast): New class to take care of user-defined implicit conversions.
17100 (ConvertImplicit, ForceConversion): Take TypeContainer argument
17102 * everywhere : Correct calls to the above accordingly.
17104 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
17105 (ConvertImplicit): Do user-defined conversion if it exists.
17107 2001-09-24 Miguel de Icaza <miguel@ximian.com>
17109 * assign.cs: track location.
17110 (Resolve): Use implicit conversions on assignment.
17112 * literal.cs: Oops. Not good, Emit of short access values should
17113 pass (Bytes) or the wrong argument will be selected.
17115 * expression.cs (Unary::Emit): Emit code for -expr.
17117 (Unary::ResolveOperator): Handle `Substract' for non-constants
17118 (substract from zero from the non-constants).
17119 Deal with Doubles as well.
17121 (Expression::ConvertImplicitRequired): New routine that reports an
17122 error if no implicit conversion exists.
17124 (Invocation::OverloadResolve): Store the converted implicit
17125 expressions if we make them
17127 2001-09-24 Ravi Pratap <ravi@ximian.com>
17129 * class.cs (ConstructorInitializer): Take a Location argument.
17130 (ConstructorBaseInitializer): Same here.
17131 (ConstructorThisInitializer): Same here.
17133 * cs-parser.jay : Update all calls accordingly.
17135 * expression.cs (Unary, Binary, New): Take location argument.
17136 Update accordingly everywhere.
17138 * cs-parser.jay : Update all calls to the above to take a location
17141 * class.cs : Ditto.
17143 2001-09-24 Ravi Pratap <ravi@ximian.com>
17145 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
17146 (Invocation::BetterConversion): Same here
17147 (Invocation::ConversionExists): Ditto.
17149 (Invocation::ConversionExists): Implement.
17151 2001-09-22 Ravi Pratap <ravi@ximian.com>
17153 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
17154 Also take an additional TypeContainer argument.
17156 * All over : Pass in TypeContainer as argument to OverloadResolve.
17158 * typemanager.cs (CSharpName): Update to check for the string type and return
17161 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
17164 2001-09-21 Ravi Pratap <ravi@ximian.com>
17166 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
17167 (Invocation::BetterFunction): Implement.
17168 (Invocation::BetterConversion): Implement.
17169 (Invocation::ConversionExists): Skeleton, no implementation yet.
17171 Okay, things work fine !
17173 2001-09-21 Miguel de Icaza <miguel@ximian.com>
17175 * typemanager.cs: declare and load enum_type, delegate_type and
17178 * expression.cs (Expression::Emit): Now emit returns a value that
17179 tells whether a value is left on the stack or not. This strategy
17180 might be reveted tomorrow with a mechanism that would address
17181 multiple assignments.
17182 (Expression::report118): Utility routine to report mismatches on
17185 (Unary::Report23): Report impossible type/operator combination
17188 (Unary::IsIncrementableNumber): Whether the type can be
17189 incremented or decremented with add.
17190 (Unary::ResolveOperator): Also allow enumerations to be bitwise
17192 (Unary::ResolveOperator): Implement ++, !, ~,
17194 (Invocation::Emit): Deal with new Emit convetion.
17196 * All Expression derivatives: Updated their Emit method to return
17197 whether they leave values on the stack or not.
17199 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
17200 stack for expressions that are statements.
17202 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17204 * expression.cs (LValue): New interface. Must be implemented by
17206 (LocalVariableReference, ParameterReference, FieldExpr): Implement
17209 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
17210 interface for generating code, simplifies the code.
17212 2001-09-20 Ravi Pratap <ravi@ximian.com>
17214 * expression.cs (everywhere): Comment out return statements in ::Resolve
17215 methods to avoid the warnings.
17217 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17219 * driver.cs (parse): Report error 2001 if we can not open the
17222 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
17225 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
17228 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
17229 otherwise nested blocks end up with the same index.
17231 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
17233 * expression.cs: Instead of having FIXMEs in the Resolve
17234 functions, throw exceptions so it is obvious that we are facing a
17237 * cs-parser.jay (invocation_expression): Pass Location information.
17239 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
17240 Use a basename for those routines because .NET does not like paths
17243 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
17246 2001-09-19 Miguel de Icaza <miguel@ximian.com>
17248 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
17249 are loading the correct data types (throws an exception if not).
17250 (TypeManager::InitCoreTypes): Use CoreLookupType
17252 * expression.cs (Unary::ResolveOperator): return the child
17253 expression for expressions which are just +expr.
17254 (Unary::ResolveOperator): Return negative literals for -LITERAL
17255 expressions (otherwise they are Unary {Literal}).
17256 (Invocation::Badness): Take into account `Implicit constant
17257 expression conversions'.
17259 * literal.cs (LongLiteral): Implement long literal class.
17260 (IntLiteral): export the `Value' of the intliteral.
17262 2001-09-19 Ravi Pratap <ravi@ximian.com>
17264 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
17266 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
17267 instead of 'Operator'
17269 * expression.cs (Binary::ResolveOperator): Update accordingly.
17270 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
17273 * cs-parser.jay (unary_expression): Update to use the new names.
17275 * gen-treedump.cs (GetUnary): Same here.
17277 * expression.cs (Unary::Resolve): Implement.
17278 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
17279 operators are found instead of making noise ;-)
17280 (Unary::ResolveOperator): New method to do precisely the same thing which
17281 Binary::ResolveOperator does for Binary expressions.
17282 (Unary.method, .Arguments): Add.
17283 (Unary::OperName): Implement.
17284 (Unary::ForceConversion): Copy and Paste !
17286 * class.cs (Operator::Define): Fix a small bug for the case when we have
17289 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
17290 for the inbuilt operators. Only overloading works for now ;-)
17292 2001-09-18 Miguel de Icaza <miguel@ximian.com>
17294 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
17295 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
17297 * expression.cs (This::Emit): Implement.
17298 (This::Resolve): Implement.
17299 (TypeOf:Resolve): Implement.
17300 (Expression::ResolveSimpleName): Add an implicit this to instance
17302 (MemberAccess::Resolve): Deal with Parameters and Fields.
17303 Bind instance variable to Field expressions.
17304 (FieldExpr::Instance): New field used to track the expression that
17305 represents the object instance.
17306 (FieldExpr::Resolve): Track potential errors from MemberLookup not
17308 (FieldExpr::Emit): Implement.
17310 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
17311 the last instruction contains a return opcode to avoid generating
17312 the last `ret' instruction (this generates correct code, and it is
17313 nice to pass the peverify output).
17315 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
17316 initializer for static and instance variables.
17317 (Constructor::Emit): Allow initializer to be null in the case of
17318 static constructors. Only emit initializer for instance
17321 (TypeContainer::FindMembers): Return a null array if there are no
17324 Also fix the code for the MemberTypes.Method branch, as it was not
17325 scanning that for operators (or tried to access null variables before).
17327 * assign.cs (Assign::Emit): Handle instance and static fields.
17331 * driver.cs: Stop compilation if there are parse errors.
17333 * cs-parser.jay (constructor_declaration): Provide default base
17334 initializer for non-static constructors.
17335 (constructor_declarator): Do not provide a default base
17336 initializers if none was specified.
17337 Catch the fact that constructors should not have parameters.
17339 * class.cs: Do not emit parent class initializers for static
17340 constructors, that should be flagged as an error.
17342 2001-09-18 Ravi Pratap <ravi@ximian.com>
17344 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
17345 Move back code into TypeContainer::Populate.
17347 2001-09-18 Ravi Pratap <ravi@ximian.com>
17349 * class.cs (TypeContainer::AddConstructor): Fix the check to
17350 compare against Name, not Basename.
17351 (Operator::OpType): Change Plus and Minus to Add and Subtract.
17353 * cs-parser.jay : Update accordingly.
17355 * class.cs (TypeContainer::FindMembers): For the case where we are searching
17356 for methods, don't forget to look into the operators too.
17357 (RegisterMethodBuilder): Helper method to take care of this for
17358 methods, constructors and operators.
17359 (Operator::Define): Completely revamp.
17360 (Operator.OperatorMethod, MethodName): New fields.
17361 (TypeContainer::Populate): Move the registering of builders into
17362 RegisterMethodBuilder.
17363 (Operator::Emit): Re-write.
17365 * expression.cs (Binary::Emit): Comment out code path to emit method
17366 invocation stuff for the case when we have a user defined operator. I am
17367 just not able to get it right !
17369 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17371 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
17374 (Expression::MemberLookup): Provide a version that allows to
17375 specify the MemberTypes and BindingFlags.
17377 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
17378 so it was not fetching variable information from outer blocks.
17380 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
17381 Beforefieldinit as it was buggy.
17383 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
17384 that Ravi put here.
17386 * class.cs (Constructor::Emit): Only emit if block is not null.
17387 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
17388 deal with this by semantically definining it as if the user had
17391 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
17392 constructors as we now "emit" them at a higher level.
17394 (TypeContainer::DefineDefaultConstructor): Used to define the
17395 default constructors if none was provided.
17397 (ConstructorInitializer): Add methods Resolve and Emit.
17399 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
17401 2001-09-17 Ravi Pratap <ravi@ximian.com>
17403 * class.cs (TypeContainer::EmitDefaultConstructor): Register
17404 the default constructor builder with our hashtable for methodbuilders
17407 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
17408 and argument_count is 0 in which case we have a match.
17409 (Binary::ResolveOperator): More null checking and miscellaneous coding
17412 2001-09-17 Ravi Pratap <ravi@ximian.com>
17414 * rootcontext.cs (IsNameSpace): Compare against null.
17416 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
17418 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
17419 and Unary::Operator.
17421 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
17424 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
17425 we have overloaded operators.
17426 (Binary::ResolveOperator): Implement the part which does the operator overload
17429 * class.cs (Operator::Emit): Implement.
17430 (TypeContainer::Emit): Emit the operators we have too.
17432 * expression.cs (Binary::Emit): Update to emit the appropriate code for
17433 the case when we have a user-defined operator.
17435 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17437 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
17439 2001-09-16 Ravi Pratap <ravi@ximian.com>
17441 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
17442 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
17443 (Constructor::Emit): Implement.
17444 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
17445 if we have no work to do.
17446 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
17449 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
17450 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
17452 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
17455 2001-09-15 Ravi Pratap <ravi@ximian.com>
17457 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
17459 (Tree::RecordNamespace): Method to do what the name says ;-)
17460 (Tree::Namespaces): Property to get at the namespaces hashtable.
17462 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
17465 * rootcontext.cs (IsNamespace): Fixed it :-)
17467 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17469 * class.cs (TypeContainer::FindMembers): Add support for
17471 (MethodCore): New class that encapsulates both the shared aspects
17472 of a Constructor and a Method.
17473 (Method, Constructor): Factored pieces into MethodCore.
17475 * driver.cs: Added --fatal which makes errors throw exceptions.
17476 Load System assembly as well as part of the standard library.
17478 * report.cs: Allow throwing exceptions on errors for debugging.
17480 * modifiers.cs: Do not use `parent', instead use the real type
17481 container to evaluate permission settings.
17483 * class.cs: Put Ravi's patch back in. He is right, and we will
17484 have to cope with the
17486 2001-09-14 Ravi Pratap <ravi@ximian.com>
17488 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
17489 FamORAssem, not FamANDAssem.
17491 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17493 * driver.cs: Added --parse option that only parses its input files
17496 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
17497 incorrect. IsTopLevel is not used to tell whether an object is
17498 root_types or not (that can be achieved by testing this ==
17499 root_types). But to see if this is a top-level *class* (not
17500 necessarly our "toplevel" container).
17502 2001-09-14 Ravi Pratap <ravi@ximian.com>
17504 * enum.cs (Enum::Define): Modify to call the Lookup method on the
17505 parent instead of a direct call to GetType.
17507 2001-09-14 Ravi Pratap <ravi@ximian.com>
17509 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
17510 Modifiers.TypeAttr. This should just be a call to that method.
17512 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
17513 object so that we can determine if we are top-level or not.
17515 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
17518 * enum.cs (Enum::Define): Ditto.
17520 * modifiers.cs (FieldAttr): Re-write.
17522 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
17523 (TypeContainer::HaveStaticConstructor): New property to provide access
17524 to precisely that info.
17526 * modifiers.cs (MethodAttr): Re-write.
17527 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
17529 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
17530 of top-level types as claimed.
17532 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17534 * expression.cs (MemberLookup): Fruitless attempt to lookup
17535 constructors. Maybe I need to emit default constructors? That
17536 might be it (currently .NET emits this for me automatically).
17537 (Invocation::OverloadResolve): Cope with Arguments == null.
17538 (Invocation::EmitArguments): new function, shared by the new
17539 constructor and us.
17540 (Invocation::Emit): Handle static and instance methods. Emit
17541 proper call instruction for virtual or non-virtual invocations.
17542 (New::Emit): Implement.
17543 (New::Resolve): Implement.
17544 (MemberAccess:Resolve): Implement.
17545 (MethodGroupExpr::InstanceExpression): used conforming to the spec
17546 to track instances.
17547 (FieldExpr::Resolve): Set type.
17549 * support.cs: Handle empty arguments.
17551 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
17552 SimpleLookup): Auxiliary routines to help parse a qualifier
17555 Update qualifier_identifier rule.
17557 * codegen.cs: Removed debugging messages.
17559 * class.cs: Make this a global thing, this acts just as a "key" to
17560 objects that we might have around.
17562 (Populate): Only initialize method_builders_to_methods once.
17564 * expression.cs (PropertyExpr): Initialize type from the
17567 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17568 Resolve pattern. Attempt to implicitly convert value to boolean.
17571 * expression.cs: Set the type for the int32/int32 argument case.
17572 (Binary::ResolveOperator): Set the return type to boolean for
17573 comparission operators
17575 * typemanager.cs: Remove debugging print code.
17577 (Invocation::Resolve): resolve type.
17579 * class.cs: Allocate a MemberInfo of the correct size, as the code
17580 elsewhere depends on the test to reflect the correct contents.
17582 (Method::) Keep track of parameters, due to System.Reflection holes
17584 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17587 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17588 of the exact size and return that.
17590 (Class::LookupMethodByBuilder): New function that maps
17591 MethodBuilders to its methods. Required to locate the information
17592 on methods because System.Reflection bit us again.
17594 * support.cs: New file, contains an interface ParameterData and
17595 two implementations: ReflectionParameters and InternalParameters
17596 used to access Parameter information. We will need to grow this
17599 * expression.cs (Invocation::GetParameterData): implement a cache
17600 and a wrapper around the ParameterData creation for methods.
17601 (Invocation::OverloadResolve): Use new code.
17603 2001-09-13 Ravi Pratap <ravi@ximian.com>
17605 * class.cs (TypeContainer::EmitField): Remove and move into
17606 (Field::Define): here and modify accordingly.
17607 (Field.FieldBuilder): New member.
17608 (TypeContainer::Populate): Update accordingly.
17609 (TypeContainer::FindMembers): Implement.
17611 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17613 * statement.cs: (VariableInfo::VariableType): New field to be
17614 initialized with the full type once it is resolved.
17616 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17618 * parameter.cs (GetParameterInfo): Use a type cache to compute
17619 things only once, and to reuse this information
17621 * expression.cs (LocalVariableReference::Emit): Implement.
17622 (OpcodeCast::Emit): fix.
17624 (ParameterReference::Resolve): Implement.
17625 (ParameterReference::Emit): Implement.
17627 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17628 that are expressions need to stay as Expressions.
17630 * typemanager.cs (CSharpName): Returns the C# name of a type if
17633 * expression.cs (Expression::ConvertImplicit): New function that
17634 implements implicit type conversions.
17636 (Expression::ImplicitReferenceConversion): Implements implicit
17637 reference conversions.
17639 (EmptyCast): New type for transparent casts.
17641 (OpcodeCast): New type for casts of types that are performed with
17642 a sequence of bytecodes.
17644 (BoxedCast): New type used for casting value types into reference
17645 types. Emits a box opcode.
17647 (Binary::DoNumericPromotions): Implements numeric promotions of
17648 and computation of the Binary::Type.
17650 (Binary::EmitBranchable): Optimization.
17652 (Binary::Emit): Implement code emission for expressions.
17654 * typemanager.cs (TypeManager): Added two new core types: sbyte
17657 2001-09-12 Ravi Pratap <ravi@ximian.com>
17659 * class.cs (TypeContainer::FindMembers): Method which does exactly
17660 what Type.FindMembers does, only we don't have to use reflection. No
17661 implementation yet.
17663 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17664 typecontainer objects as we need to get at them.
17665 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17667 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17668 typecontainer object.
17670 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17671 of just a Report object.
17673 2001-09-11 Ravi Pratap <ravi@ximian.com>
17675 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17677 (TypeContainer::Populate): Now define the delegates of the type too.
17678 (TypeContainer.Delegates): Property to access the list of delegates defined
17681 * delegates.cs (Delegate::Define): Implement partially.
17683 * modifiers.cs (TypeAttr): Handle more flags.
17685 2001-09-11 Ravi Pratap <ravi@ximian.com>
17687 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17689 (Operator::Define): Re-write logic to get types by using the LookupType method
17690 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17691 (Indexer::Define): Ditto.
17692 (Event::Define): Ditto.
17693 (Property::Define): Ditto.
17695 2001-09-10 Ravi Pratap <ravi@ximian.com>
17697 * class.cs (TypeContainer::Populate): Now define operators too.
17698 (TypeContainer.Operators): New property to access the list of operators
17700 (Operator.OperatorMethodBuilder): New member to hold the method builder
17701 for the operator we are defining.
17702 (Operator::Define): Implement.
17704 2001-09-10 Ravi Pratap <ravi@ximian.com>
17706 * class.cs (Event::Define): Make the prefixes of the accessor methods
17707 addOn_ and removeOn_
17709 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17710 of the location being passed in too. Ideally, this should go later since all
17711 error reporting should be done through the Report object.
17713 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17714 (Populate): Iterate thru the indexers we have and define them too.
17715 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17716 for the get and set accessors.
17717 (Indexer::Define): Implement.
17719 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17721 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17722 my previous implementation, did not work.
17724 * typemanager.cs: Add a couple of missing types (the longs).
17726 * literal.cs: Use TypeManager.bool_type instead of getting it.
17728 * expression.cs (EventExpr): New kind of expressions.
17729 (Expressio::ExprClassFromMemberInfo): finish
17731 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17733 * assign.cs: Emit stores to static fields differently.
17735 2001-09-08 Ravi Pratap <ravi@ximian.com>
17737 * Merge in changes and adjust code to tackle conflicts. Backed out my
17738 code in Assign::Resolve ;-)
17740 2001-09-08 Ravi Pratap <ravi@ximian.com>
17742 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17743 instead Report.Error and also pass in the location.
17744 (CSharpParser::Lexer): New readonly property to return the reference
17745 to the Tokenizer object.
17746 (declare_local_variables): Use Report.Error with location instead of plain
17750 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17751 (Operator.CheckBinaryOperator): Ditto.
17753 * cs-parser.jay (operator_declarator): Update accordingly.
17755 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17756 (CheckBinaryOperator): Same here.
17758 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17759 on the name without any prefixes of namespace names etc. This is because we
17760 already might have something already fully qualified like
17761 'System.Console.WriteLine'
17763 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17765 2001-09-07 Ravi Pratap <ravi@ximian.com>
17767 * cs-tokenizer.cs (location): Return a string which also contains
17770 * expression.cs (ElementAccess): New class for expressions of the
17771 type 'element access.'
17772 (BaseAccess): New class for expressions of the type 'base access.'
17773 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17776 * cs-parser.jay (element_access): Implement action.
17777 (base_access): Implement actions.
17778 (checked_expression, unchecked_expression): Implement.
17780 * cs-parser.jay (local_variable_type): Correct and implement.
17781 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17783 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17785 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17786 name and the specifiers.
17788 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17790 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17791 making them all public ;-)
17793 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17796 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17798 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17800 (FieldExpr, PropertyExprs): New resolved expressions.
17801 (SimpleName::MemberStaticCheck): Perform static checks for access
17802 to non-static fields on static methods. Maybe this should be
17803 generalized for MemberAccesses.
17804 (SimpleName::ResolveSimpleName): More work on simple name
17807 * cs-parser.jay (primary_expression/qualified_identifier): track
17808 the parameter index.
17810 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17811 (EmitContext::EmitBoolExpression): Chain to expression generation
17812 instead of temporary hack.
17813 (::EmitStatementExpression): Put generic expression code generation.
17815 * assign.cs (Assign::Emit): Implement variable assignments to
17816 local variables, parameters and fields.
17818 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17820 * statement.cs (Block::GetVariableInfo): New method, returns the
17821 VariableInfo for a variable name in a block.
17822 (Block::GetVariableType): Implement in terms of GetVariableInfo
17824 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17825 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17827 2001-09-06 Ravi Pratap <ravi@ximian.com>
17829 * cs-parser.jay (operator_declaration): Continue on my quest : update
17830 to take attributes argument.
17831 (event_declaration): Ditto.
17832 (enum_declaration): Ditto.
17833 (indexer_declaration): Ditto.
17835 * class.cs (Operator::Operator): Update constructor accordingly.
17836 (Event::Event): Ditto.
17838 * delegate.cs (Delegate::Delegate): Same here.
17840 * enum.cs (Enum::Enum): Same here.
17842 2001-09-05 Ravi Pratap <ravi@ximian.com>
17844 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17846 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17848 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17849 being passed around as an arraylist.
17850 (Attributes::AddAttribute): Method to add attribute sections.
17852 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17853 (struct_declaration): Update accordingly.
17854 (constant_declaration): Update.
17855 (field_declaration): Update.
17856 (method_header): Update.
17857 (fixed_parameter): Update.
17858 (parameter_array): Ditto.
17859 (property_declaration): Ditto.
17860 (destructor_declaration): Ditto.
17862 * class.cs (Struct::Struct): Update constructors accordingly.
17863 (Class::Class): Ditto.
17864 (Field::Field): Ditto.
17865 (Method::Method): Ditto.
17866 (Property::Property): Ditto.
17867 (TypeContainer::OptAttribute): update property's return type.
17869 * interface.cs (Interface.opt_attributes): New member.
17870 (Interface::Interface): Update to take the extra Attributes argument.
17872 * parameter.cs (Parameter::Parameter): Ditto.
17874 * constant.cs (Constant::Constant): Ditto.
17876 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17877 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17878 the attributes as a parameter.
17879 (InterfaceProperty): Update constructor call.
17880 (InterfaceEvent): Ditto.
17881 (InterfaceMethod): Ditto.
17882 (InterfaceIndexer): Ditto.
17884 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17885 pass the attributes too.
17886 (interface_event_declaration): Ditto.
17887 (interface_property_declaration): Ditto.
17888 (interface_method_declaration): Ditto.
17889 (interface_declaration): Ditto.
17891 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17893 * class.cs (Method::Define): Track the "static Main" definition to
17894 create an entry point.
17896 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17897 EntryPoint if we find it.
17899 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17900 (EmitContext::ig): Make this variable public.
17902 * driver.cs: Make the default output file be the first file name
17903 with the .exe extension.
17905 Detect empty compilations
17907 Handle various kinds of output targets. Handle --target and
17908 rename -t to --dumper.
17910 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17911 methods inherited from Expression return now an Expression. This
17912 will is used during the tree rewriting as we resolve them during
17915 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17916 the spec. Missing entirely is the information about
17917 accessability of elements of it.
17919 (Expression::ExprClassFromMemberInfo): New constructor for
17920 Expressions that creates a fully initialized Expression based on
17921 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17924 (Invocation::Resolve): Begin implementing resolution of invocations.
17926 * literal.cs (StringLiteral): Implement Emit.
17928 2001-09-05 Ravi Pratap <ravi@ximian.com>
17930 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17933 2001-09-04 Ravi Pratap <ravi@ximian.com>
17935 * cs-parser.jay (attribute_arguments): Implement actions.
17936 (attribute): Fix bug in production. Implement action.
17937 (attribute_list): Implement.
17938 (attribute_target): Implement.
17939 (attribute_target_specifier, opt_target_specifier): Implement
17940 (CheckAttributeTarget): New method to check if the attribute target
17942 (attribute_section): Implement.
17943 (opt_attributes): Implement.
17945 * attribute.cs : New file to handle attributes.
17946 (Attribute): Class to hold attribute info.
17948 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17949 (attribute_section): Modify production to use 2 different rules to
17950 achieve the same thing. 1 s/r conflict down !
17951 Clean out commented, useless, non-reducing dimension_separator rules.
17953 * class.cs (TypeContainer.attributes): New member to hold list
17954 of attributes for a type.
17955 (Struct::Struct): Modify to take one more argument, the attribute list.
17956 (Class::Class): Ditto.
17957 (Field::Field): Ditto.
17958 (Method::Method): Ditto.
17959 (Property::Property): Ditto.
17961 * cs-parser.jay (struct_declaration): Update constructor call to
17962 pass in the attributes too.
17963 (class_declaration): Ditto.
17964 (constant_declaration): Ditto.
17965 (field_declaration): Ditto.
17966 (method_header): Ditto.
17967 (fixed_parameter): Ditto.
17968 (parameter_array): Ditto.
17969 (property_declaration): Ditto.
17971 * constant.cs (Constant::Constant): Update constructor similarly.
17972 Use System.Collections.
17974 * parameter.cs (Parameter::Parameter): Update as above.
17976 2001-09-02 Ravi Pratap <ravi@ximian.com>
17978 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17979 (TypeContainer.delegates): New member to hold list of delegates.
17981 * cs-parser.jay (delegate_declaration): Implement the action correctly
17982 this time as I seem to be on crack ;-)
17984 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17986 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17987 tell whether an identifier represents a namespace.
17989 * expression.cs (NamespaceExpr): A namespace expression, used only
17990 temporarly during expression resolution.
17991 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17992 utility functions to resolve names on expressions.
17994 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17996 * codegen.cs: Add hook for StatementExpressions.
17998 * class.cs: Fix inverted test for static flag in methods.
18000 2001-09-02 Ravi Pratap <ravi@ximian.com>
18002 * class.cs (Operator::CheckUnaryOperator): Correct error number used
18003 to make it coincide with MS' number.
18004 (Operator::CheckBinaryOperator): Ditto.
18006 * ../errors/errors.txt : Remove error numbers added earlier.
18008 * ../errors/cs1019.cs : Test case for error # 1019
18010 * ../errros/cs1020.cs : Test case for error # 1020
18012 * cs-parser.jay : Clean out commented cruft.
18013 (dimension_separators, dimension_separator): Comment out. Ostensibly not
18014 used anywhere - non-reducing rule.
18015 (namespace_declarations): Non-reducing rule - comment out.
18017 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
18018 with TypeContainer::AddEnum.
18020 * delegate.cs : New file for delegate handling classes.
18021 (Delegate): Class for declaring delegates.
18023 * makefile : Update.
18025 * cs-parser.jay (delegate_declaration): Implement.
18027 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
18029 * class.cs (Event::Define): Implement.
18030 (Event.EventBuilder): New member.
18032 * class.cs (TypeContainer::Populate): Update to define all enums and events
18034 (Events): New property for the events arraylist we hold. Shouldn't we move to using
18035 readonly fields for all these cases ?
18037 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
18039 * class.cs (Property): Revamp to use the convention of making fields readonly.
18040 Accordingly modify code elsewhere.
18042 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
18043 the Define method of the Property class.
18045 * class.cs : Clean up applied patch and update references to variables etc. Fix
18047 (TypeContainer::Populate): Update to define all the properties we have. Also
18048 define all enumerations.
18050 * enum.cs (Define): Implement.
18052 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
18054 * cs-parser.jay (overloadable_operator): The semantic value is an
18055 enum of the Operator class.
18056 (operator_declarator): Implement actions.
18057 (operator_declaration): Implement.
18059 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
18060 validity of definitions.
18061 (Operator::CheckBinaryOperator): Static method to check for binary operators
18062 (TypeContainer::AddOperator): New method to add an operator to a type.
18064 * cs-parser.jay (indexer_declaration): Added line to actually call the
18065 AddIndexer method so it gets added ;-)
18067 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
18068 already taken care of by the MS compiler ?
18070 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
18072 * class.cs (Operator): New class for operator declarations.
18073 (Operator::OpType): Enum for the various operators.
18075 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
18077 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
18078 ostensibly handle this in semantic analysis.
18080 * cs-parser.jay (general_catch_clause): Comment out
18081 (specific_catch_clauses, specific_catch_clause): Ditto.
18082 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
18083 (catch_args, opt_catch_args): New productions.
18084 (catch_clause): Rewrite to use the new productions above
18085 (catch_clauses): Modify accordingly.
18086 (opt_catch_clauses): New production to use in try_statement
18087 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
18088 and re-write the code in the actions to extract the specific and
18089 general catch clauses by being a little smart ;-)
18091 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
18092 Hooray, try and catch statements parse fine !
18094 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18096 * statement.cs (Block::GetVariableType): Fix logic to extract the type
18097 string from the hashtable of variables.
18099 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
18100 I end up making that mistake ;-)
18101 (catch_clauses): Fixed gross error which made Key and Value of the
18102 DictionaryEntry the same : $1 !!
18104 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18106 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
18108 * cs-parser.jay (event_declaration): Correct to remove the semicolon
18109 when the add and remove accessors are specified.
18111 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18113 * cs-parser.jay (IndexerDeclaration): New helper class to hold
18114 information about indexer_declarator.
18115 (indexer_declarator): Implement actions.
18116 (parsing_indexer): New local boolean used to keep track of whether
18117 we are parsing indexers or properties. This is necessary because
18118 implicit_parameters come into picture even for the get accessor in the
18119 case of an indexer.
18120 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
18122 * class.cs (Indexer): New class for indexer declarations.
18123 (TypeContainer::AddIndexer): New method to add an indexer to a type.
18124 (TypeContainer::indexers): New member to hold list of indexers for the
18127 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18129 * cs-parser.jay (add_accessor_declaration): Implement action.
18130 (remove_accessor_declaration): Implement action.
18131 (event_accessors_declaration): Implement
18132 (variable_declarators): swap statements for first rule - trivial.
18134 * class.cs (Event): New class to hold information about event
18136 (TypeContainer::AddEvent): New method to add an event to a type
18137 (TypeContainer::events): New member to hold list of events.
18139 * cs-parser.jay (event_declaration): Implement actions.
18141 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18143 * cs-parser.jay (dim_separators): Implement. Make it a string
18144 concatenating all the commas together, just as they appear.
18145 (opt_dim_separators): Modify accordingly
18146 (rank_specifiers): Update accordingly. Basically do the same
18147 thing - instead, collect the brackets here.
18148 (opt_rank_sepcifiers): Modify accordingly.
18149 (array_type): Modify to actually return the complete type string
18150 instead of ignoring the rank_specifiers.
18151 (expression_list): Implement to collect the expressions
18152 (variable_initializer): Implement. We make it a list of expressions
18153 essentially so that we can handle the array_initializer case neatly too.
18154 (variable_initializer_list): Implement.
18155 (array_initializer): Make it a list of variable_initializers
18156 (opt_array_initializer): Modify accordingly.
18158 * expression.cs (New::NType): Add enumeration to help us
18159 keep track of whether we have an object/delegate creation
18160 or an array creation.
18161 (New:NewType, New::Rank, New::Indices, New::Initializers): New
18162 members to hold data about array creation.
18163 (New:New): Modify to update NewType
18164 (New:New): New Overloaded contructor for the array creation
18167 * cs-parser.jay (array_creation_expression): Implement to call
18168 the overloaded New constructor.
18170 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
18172 * class.cs (TypeContainer::Constructors): Return member
18173 constructors instead of returning null.
18175 2001-08-26 Miguel de Icaza <miguel@ximian.com>
18177 * typemanager.cs (InitCoreTypes): Initialize the various core
18178 types after we have populated the type manager with the user
18179 defined types (this distinction will be important later while
18180 compiling corlib.dll)
18182 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
18183 on Expression Classification. Now all expressions have a method
18184 `Resolve' and a method `Emit'.
18186 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
18187 generation from working. Also add some temporary debugging
18190 2001-08-24 Miguel de Icaza <miguel@ximian.com>
18192 * codegen.cs: Lots of code generation pieces. This is only the
18193 beginning, will continue tomorrow with more touches of polish. We
18194 handle the fundamentals of if, while, do, for, return. Others are
18195 trickier and I need to start working on invocations soon.
18197 * gen-treedump.cs: Bug fix, use s.Increment here instead of
18200 * codegen.cs (EmitContext): New struct, used during code
18201 emission to keep a context. Most of the code generation will be
18204 * cs-parser.jay: Add embedded blocks to the list of statements of
18205 this block. So code generation proceeds in a top down fashion.
18207 2001-08-23 Miguel de Icaza <miguel@ximian.com>
18209 * statement.cs: Add support for multiple child blocks.
18211 2001-08-22 Miguel de Icaza <miguel@ximian.com>
18213 * codegen.cs (EmitCode): New function, will emit the code for a
18214 Block of code given a TypeContainer and its ILGenerator.
18216 * statement.cs (Block): Standard public readonly optimization.
18217 (Block::Block constructors): Link children.
18218 (Block::Child): Child Linker.
18219 (Block::EmitVariables): Emits IL variable declarations.
18221 * class.cs: Drop support for MethodGroups here, delay until
18223 (Method::): Applied the same simplification that I did before, and
18224 move from Properties to public readonly fields.
18225 (Method::ParameterTypes): Returns the parameter types for the
18226 function, and implements a cache that will be useful later when I
18227 do error checking and the semantic analysis on the methods is
18229 (Constructor::GetCallingConvention): Renamed from CallingConvetion
18230 and made a method, optional argument tells whether this is a class
18231 or a structure to apply the `has-this' bit.
18232 (Method::GetCallingConvention): Implement, returns the calling
18234 (Method::Define): Defines the type, a second pass is performed
18235 later to populate the methods.
18237 (Constructor::ParameterTypes): implement a cache similar to the
18238 one on Method::ParameterTypes, useful later when we do semantic
18241 (TypeContainer::EmitMethod): New method. Emits methods.
18243 * expression.cs: Removed MethodGroup class from here.
18245 * parameter.cs (Parameters::GetCallingConvention): new method.
18247 2001-08-21 Miguel de Icaza <miguel@ximian.com>
18249 * class.cs (TypeContainer::Populate): Drop RootContext from the
18252 (Constructor::CallingConvention): Returns the calling convention.
18253 (Constructor::ParameterTypes): Returns the constructor parameter
18256 (TypeContainer::AddConstructor): Keep track of default constructor
18257 and the default static constructor.
18259 (Constructor::) Another class that starts using `public readonly'
18260 instead of properties.
18262 (Constructor::IsDefault): Whether this is a default constructor.
18264 (Field::) use readonly public fields instead of properties also.
18266 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
18267 track of static constructors; If none is used, turn on
18268 BeforeFieldInit in the TypeAttributes.
18270 * cs-parser.jay (opt_argument_list): now the return can be null
18271 for the cases where there are no arguments.
18273 (constructor_declarator): If there is no implicit `base' or
18274 `this', then invoke the default parent constructor.
18276 * modifiers.cs (MethodAttr): New static function maps a set of
18277 modifiers flags into a MethodAttributes enum
18278 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
18279 MethodAttr, TypeAttr to represent the various mappings where the
18280 modifiers are used.
18281 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
18283 2001-08-19 Miguel de Icaza <miguel@ximian.com>
18285 * parameter.cs (GetParameterInfo): Fix bug where there would be no
18288 * interface.cs (PopulateIndexer): Implemented the code generator
18289 for interface indexers.
18291 2001-08-17 Miguel de Icaza <miguel@ximian.com>
18293 * interface.cs (InterfaceMemberBase): Now we track the new status
18296 (PopulateProperty): Implement property population. Woohoo! Got
18297 Methods and Properties going today.
18299 Removed all the properties for interfaces, and replaced them with
18300 `public readonly' fields.
18302 2001-08-16 Miguel de Icaza <miguel@ximian.com>
18304 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
18305 initialize their hashtables/arraylists only when they are needed
18306 instead of doing this always.
18308 * parameter.cs: Handle refs and out parameters.
18310 * cs-parser.jay: Use an ArrayList to construct the arguments
18311 instead of the ParameterCollection, and then cast that to a
18314 * parameter.cs: Drop the use of ParameterCollection and use
18315 instead arrays of Parameters.
18317 (GetParameterInfo): Use the Type, not the Name when resolving
18320 2001-08-13 Miguel de Icaza <miguel@ximian.com>
18322 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
18323 and instead use public readonly fields.
18325 * class.cs: Put back walking code for type containers.
18327 2001-08-11 Miguel de Icaza <miguel@ximian.com>
18329 * class.cs (MakeConstant): Code to define constants.
18331 * rootcontext.cs (LookupType): New function. Used to locate types
18334 2001-08-08 Miguel de Icaza <miguel@ximian.com>
18336 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
18337 this System.Reflection code is. Kudos to Microsoft
18339 * typemanager.cs: Implement a type cache and avoid loading all
18340 types at boot time. Wrap in LookupType the internals. This made
18341 the compiler so much faster. Wow. I rule!
18343 * driver.cs: Make sure we always load mscorlib first (for
18344 debugging purposes, nothing really important).
18346 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
18347 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
18349 * rootcontext.cs: Lookup types on their namespace; Lookup types
18350 on namespaces that have been imported using the `using' keyword.
18352 * class.cs (TypeContainer::TypeAttr): Virtualize.
18353 (Class::TypeAttr): Return attributes suitable for this bad boy.
18354 (Struct::TypeAttr): ditto.
18355 Handle nested classes.
18356 (TypeContainer::) Remove all the type visiting code, it is now
18357 replaced with the rootcontext.cs code
18359 * rootcontext.cs (GetClassBases): Added support for structs.
18361 2001-08-06 Miguel de Icaza <miguel@ximian.com>
18363 * interface.cs, statement.cs, class.cs, parameter.cs,
18364 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
18365 Drop use of TypeRefs, and use strings instead.
18367 2001-08-04 Miguel de Icaza <miguel@ximian.com>
18371 * class.cs (Struct::Struct): set the SEALED flags after
18372 checking the modifiers.
18373 (TypeContainer::TypeAttr): new property, returns the
18374 TypeAttributes for a class.
18376 * cs-parser.jay (type_list): Oops, list production was creating a
18377 new list of base types.
18379 * rootcontext.cs (StdLib): New property.
18380 (GetInterfaceTypeByName): returns an interface by type name, and
18381 encapsulates error handling here.
18382 (GetInterfaces): simplified.
18383 (ResolveTree): Encapsulated all the tree resolution here.
18384 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
18387 * driver.cs: Add support for --nostdlib, to avoid loading the
18388 default assemblies.
18389 (Main): Do not put tree resolution here.
18391 * rootcontext.cs: Beginning of the class resolution.
18393 2001-08-03 Miguel de Icaza <miguel@ximian.com>
18395 * rootcontext.cs: Provide better error reporting.
18397 * cs-parser.jay (interface_base): set our $$ to be interfaces.
18399 * rootcontext.cs (CreateInterface): Handle the case where there
18400 are no parent interfaces.
18402 (CloseTypes): Routine to flush types at the end.
18403 (CreateInterface): Track types.
18404 (GetInterfaces): Returns an array of Types from the list of
18405 defined interfaces.
18407 * typemanager.c (AddUserType): Mechanism to track user types (puts
18408 the type on the global type hash, and allows us to close it at the
18411 2001-08-02 Miguel de Icaza <miguel@ximian.com>
18413 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
18414 RecordInterface instead.
18416 * cs-parser.jay: Updated to reflect changes above.
18418 * decl.cs (Definition): Keep track of the TypeBuilder type that
18419 represents this type here. Not sure we will use it in the long
18420 run, but wont hurt for now.
18422 * driver.cs: Smaller changes to accomodate the new code.
18424 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
18427 * rootcontext.cs (CreateInterface): New method, used to create
18428 the System.TypeBuilder type for interfaces.
18429 (ResolveInterfaces): new entry point to resolve the interface
18431 (CodeGen): Property, used to keep track of the code generator.
18433 2001-07-26 Miguel de Icaza <miguel@ximian.com>
18435 * cs-parser.jay: Add a second production for delegate_declaration
18438 (enum_body): Put an opt_comma here instead of putting it on
18439 enum_body or enum_member_declarations so we can handle trailing
18440 commas on enumeration members. Gets rid of a shift/reduce.
18442 (type_list): Need a COMMA in the middle.
18444 (indexer_declaration): Tell tokenizer to recognize get/set
18446 * Remove old targets.
18448 * Re-add the parser target.
18450 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18452 * cs-parser.jay: Add precendence rules for a number of operators
18453 ot reduce the number of shift/reduce conflicts in the grammar.
18455 2001-07-17 Miguel de Icaza <miguel@ximian.com>
18457 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
18460 Get rid of old crufty code.
18462 * rootcontext.cs: Use this to keep track of the parsed
18463 representation and the defined types available to the program.
18465 * gen-treedump.cs: adjust for new convention.
18467 * type.cs: Split out the type manager, and the assembly builder
18470 * typemanager.cs: the type manager will live here now.
18472 * cil-codegen.cs: And the code generator here.
18474 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
18476 * makefile: Fixed up for easy making.
18478 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18480 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
18483 (unary_expression): Expand pre_increment_expression and
18484 post_decrement_expression to reduce a shift/reduce.
18486 2001-07-11 Simon Cozens
18488 * cs-tokenizer.cs: Hex numbers should begin with a 0.
18490 Improve allow_keyword_as_indent name.
18492 2001-06-19 Miguel de Icaza <miguel@ximian.com>
18494 * Adjustments for Beta2.
18496 2001-06-13 Miguel de Icaza <miguel@ximian.com>
18498 * decl.cs: Added `Define' abstract method.
18499 (InTransit): new property, used to catch recursive definitions.
18501 * interface.cs: Implement `Define'.
18503 * modifiers.cs: Map Modifiers.constants to
18504 System.Reflection.TypeAttribute flags.
18506 * class.cs: Keep track of types and user-defined types.
18507 (BuilderInit): New method for creating an assembly
18508 (ResolveType): New function to launch the resolution process, only
18509 used by interfaces for now.
18511 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
18512 that are inserted into the name space.
18514 2001-06-08 Miguel de Icaza <miguel@ximian.com>
18516 * ARGH. I have screwed up my tree so many times due to the use of
18517 rsync rather than using CVS. Going to fix this at once.
18519 * driver.cs: Objetify driver. Load assemblies, use assemblies to
18522 2001-06-07 Miguel de Icaza <miguel@ximian.com>
18524 * Experiment successful: Use System.Type rather that our own
18527 2001-05-25 Miguel de Icaza <miguel@ximian.com>
18529 * cs-parser.jay: Removed nsAliases from here.
18531 Use new namespaces, handle `using XXX;'
18533 * namespace.cs: Reimplemented namespace handling, use a recursive
18534 definition of the class. Now we can keep track of using clauses
18535 and catch invalid using clauses.
18537 2001-05-24 Miguel de Icaza <miguel@ximian.com>
18539 * gen-treedump.cs: Adapted for all the renaming.
18541 * expression.cs (Expression): this class now has a Type property
18542 which returns an expression Type.
18544 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
18545 `Type', as this has a different meaning now in the base
18547 2001-05-22 Miguel de Icaza <miguel@ximian.com>
18549 * interface.cs, class.cs: Removed from all the sources the
18550 references to signature computation, as we can not do method
18551 signature computation during the parsing time, as we are not
18552 trying to solve at that point distinguishing:
18556 void a (NS.Blah x) {}
18559 Which depending on the context might be valid or not, as we do not
18560 know if Blah is the same thing as NS.Blah at that point.
18562 * Redid everything so the code uses TypeRefs now instead of
18563 Types. TypeRefs are just temporary type placeholders, that need
18564 to be resolved. They initially have a pointer to a string and the
18565 current scope in which they are used. This is used later by the
18566 compiler to resolve the reference to an actual Type.
18568 * DeclSpace is no longer a CIR.Type, and neither are
18569 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18570 are all DeclSpaces, but no Types.
18572 * type.cs (TypeRefManager): This implements the TypeRef manager,
18573 which keeps track of all the types that need to be resolved after
18574 the parsing has finished.
18576 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18578 * ARGH. We are going to have to store `foreach' as a class rather
18579 than resolving it, as we need to verify error 1579 after name
18580 resolution. *OR* we could keep a flag that says `This request to
18581 IEnumerator comes from a foreach statement' which we can then use
18582 to generate the error.
18584 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18586 * class.cs (TypeContainer.AddMethod): we now add methods to the
18587 MethodGroup instead of the method hashtable.
18589 * expression.cs: Add MethodGroup abstraction, which gets us one
18590 step closer to the specification in the way we handle method
18593 * cs-parser.jay (primary_expression): qualified_identifier now
18594 tried to match up an identifier to a local variable reference or
18595 to a parameter reference.
18597 current_local_parameters is now a parser global variable that
18598 points to the current parameters for the block, used during name
18601 (property_declaration): Now creates an implicit `value' argument to
18604 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18606 * parameter.cs: Do not use `param' arguments as part of the
18607 signature, per the spec.
18609 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18611 * decl.cs: Base class for classes, structs and interfaces. This
18612 is the "Declaration Space"
18614 * cs-parser.jay: Use CheckDef for checking declaration errors
18615 instead of having one on each function.
18617 * class.cs: Factor out some code for handling error handling in
18618 accordance to the "Declarations" section in the "Basic Concepts"
18619 chapter in the ECMA C# spec.
18621 * interface.cs: Make all interface member classes derive from
18622 InterfaceMemberBase.
18624 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18626 * Many things: all interfaces are parsed and generated in
18627 gen-treedump. Support for member variables, constructors,
18628 destructors, properties, constants is there.
18630 Beginning of the IL backend, but very little done, just there for
18633 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18635 * cs-parser.jay: Fix labeled statement.
18637 * cs-tokenizer.cs (escape): Escape " and ' always.
18638 ref_line, ref_name: keep track of the line/filename as instructed
18639 by #line by the compiler.
18642 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18644 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18645 to match the values in System.CodeDOM.
18647 Divid renamed to Divide.
18649 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18651 (Statements.set): remove.
18653 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18656 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18657 falseStatements always have valid values.
18659 * cs-parser.jay: Use System.CodeDOM now.