1 2007-08-28 Marek Safar <marek.safar@gmail.com>
3 * cs-parser.jay: Anonymous type arguments can be simple name, syntax error
6 2007-08-23 Marek Safar <marek.safar@gmail.com>
8 * generic.cs (TypeInferenceV3.DoSecondPhase): Handle nested delegate
10 (IsTypeNonDependent, RemoveDependentTypes): Handle nested delegate
13 2007-08-21 Marek Safar <marek.safar@gmail.com>
15 * cs-parser.jay, linq.cs: Implemented orderby clause.
17 2007-08-20 Marek Safar <marek.safar@gmail.com>
19 * linq.cs: Switch to lambda expressions.
21 2007-08-20 Marek Safar <marek.safar@gmail.com>
23 * cs-parser.jay: An anonymous type can be empty.
25 2007-08-17 Marek Safar <marek.safar@gmail.com>
27 * linq.cs: MethodGroupExpr update.
29 2007-08-14 Marek Safar <marek.safar@gmail.com>
31 ** C# 3.0 Object and collection initializers
33 * cs-parser.jay: Grammar update.
35 2007-08-11 Marek Safar <marek.safar@gmail.com>
38 * generics.cs (TypeInferenceContext.LowerBoundInference): Don't
39 terminate type inference when an array is not paired.
41 2007-08-10 Miguel de Icaza <miguel@novell.com>
43 * generic.cs (DefaultValueExpression): Add CloneTo support to this
46 2007-08-09 Marek Safar <marek.safar@gmail.com>
48 ** C# 3.0 Anonymous Types (update to the latest standard)
50 * cs-parser.jay: Updated parameters and type names.
52 2007-08-03 Raja R Harinath <harinath@gmail.com>
54 * cs-parser.jay (class_declaration): Update to changes in class.cs.
55 Move calling of 'AddBasesForPart' to ...
56 (class_bases): ... here.
57 (struct_declaration, interface_declaration): Update to changes.
59 2007-08-02 Raja R Harinath <harinath@gmail.com>
61 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
62 * cs-parser.jay: Some whitespace cleanups.
63 (method_header): Refer to the correct symbol for parameters.
65 2007-08-01 Marek Safar <marek.safar@gmail.com>
68 * cs-parser.jay: Ignore partial keyword inside block expression.
70 2007-08-01 Marek Safar <marek.safar@gmail.com>
72 ** C# 3.0 Type Inference (major bits are working)
74 * generic.cs: Introduced new abstract class as an entry point to type
75 inference. Old type inference moved to TypeInferenceV2. Implemented C# 3.0
76 type inference as descibed in the standard in TypeInferenceV2 class.
78 * linq.cs (ALinqExpression): Disabled caching because it's wrong.
80 2007-07-25 Jb Evain <jbevain@novell.com>
82 * Makefile: don't install on net_2_1.
84 2007-07-18 Marek Safar <marek.safar@gmail.com>
86 * cs-parser.jay: Use ImplicitLambdaParameter everywhere.
88 2007-07-17 Marek Safar <marek.safar@gmail.com>
90 * cs-parser.jay: Correct placeholder for implicit linq parameter.
92 * linq: Add ImplicitArgument.
94 2007-07-03 Marek Safar <marek.safar@gmail.com>
96 * cs-parser.jay: Switch to ImplicitLambdaParameter.
98 2007-07-03 Marek Safar <marek.safar@gmail.com>
100 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
103 * linq.cs (QueryExpression.DoResolve): Resolve implicitly typed query
106 2007-06-20 Marek Safar <marek.safar@gmail.com>
108 * cs-parser.jay: Reworked var keyword handling. We cannot handle var as
109 static keyword because var becomes keyword only if no type with the var
110 name exists in the scope of variable which uses var declaration.
112 2007-06-18 Marek Safar <marek.safar@gmail.com>
114 * cs-parser.jay: Add implicitly typed local variable checks.
116 2007-06-15 Marek Safar <marek.safar@gmail.com>
118 * cs-parser.jay: Correctly split generic arguments and generic
119 parameters. Correctly implemented typeof of generic unbound types.
121 2007-06-14 Marek Safar <marek.safar@gmail.com>
123 * cs-parser.jay: Assembly and module attributes must precede all other
124 elements except using clauses and extern alias declarations.
126 2007-06-08 Marek Safar <marek.safar@gmail.com>
128 * cs-parser.jay: Uses newly defined GroupBy class.
130 * linq.cs (GroupBy): Implemented.
131 (AQueryClause.BuildQueryClause): Refactored to allow customize query
134 2007-06-08 Marek Safar <marek.safar@gmail.com>
136 * generics.cs (InferTypeArguments): Uses AnonymousMethodExpression
139 2007-06-06 Marek Safar <marek.safar@gmail.com>
141 * generics.cs (TypeArguments): New contructor fow known number of
144 2007-06-04 Raja R Harinath <rharinath@novell.com>
146 * linq.cs (Select.DoResolve): Pass the created parameters to the
149 2007-05-29 Raja R Harinath <rharinath@novell.com>
151 * cs-parser.jay: Update to changes in ToplevelBlock.
152 (top_current_block): Remove.
154 2007-05-27 Raja R Harinath <harinath@gmail.com>
156 * cs-parser.jay: Update to new ExplicitBlock invariant.
158 * cs-parser.jay: Update to changes introduced in Block and
161 2007-05-25 Raja R Harinath <rharinath@novell.com>
163 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
164 modifying current_block directly.
166 2007-05-22 Scott Peterson <lunchtimemama@gmail.com>
168 * cs-parser.jay: Implemented automatic properties (C# 3.0)
170 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
172 * cs-parser.jay: Improved grammar for object and collection
175 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
177 This code is contributed under the MIT X11 license
179 * cs-parser.jay: Added support for C# 3.0 language features:
180 Variable type inference (the "var" keyword)
183 Object initialization
184 Collection initialization
186 2007-05-06 Marek Safar <marek.safar@gmail.com>
189 * cs-parser.jay: Add special handling for coalescing operator.
191 2007-05-02 Raja R Harinath <rharinath@novell.com>
193 Fix regression in cs0631-3.cs
194 * cs-parser.jay (operator_declarator): Add opt_attributes to error
195 fallback. Make error fallback catch more cases.
197 2007-05-01 Miguel de Icaza <miguel@novell.com>
199 * cs-parser.jay: Allow parameters in operator declarations to have
202 2007-04-27 Miguel de Icaza <miguel@novell.com>
204 * generic.cs (TypeManager.LambdaInfer): now this routine will
205 make only one inference from the list of lambda expression that
206 have not participated in inferring a type.
208 (TypeManager.InferTypeArguments): The logic that drives the type
209 inference in lambda expressions is now driven here.
211 2007-04-23 Miguel de Icaza <miguel@novell.com>
213 * generic.cs: Large update to LambdaInfer, this is merely an
214 update to start the lambda type inference. It is by no means
215 complete. It is currently merely able to build a sample program
216 (with no iteration for the type parameters).
218 2007-04-12 Duncan Mak <duncan@a-chinaman.com>
220 * cs-parser.jay (interface_method_declaration_body): Fixed typo.
222 2007-04-08 Marek Safar <marek.safar@gmail.com>
224 * cs-parser.jay, linq.cs: First select implementation (hacky).
226 * generic.cs (InferTypeArguments): Simplified.
228 2007-03-31 Marek Safar <marek.safar@gmail.com>
230 * generic.cs (InferTypeArguments): Restored validation check.
231 (InferTypeArguments): Move all logic to Compatible method for re-usability.
233 2007-03-25 Marek Safar <marek.safar@gmail.com>
235 * generic.cs (InferTypeArguments): Infer arguments before they are used
236 for compatibility check.
238 2007-03-15 Marek Safar <marek.safar@gmail.com>
240 * generic.cs (InflatedConstraints): Fixed the check order.
241 (TypeArguments.Resolve): Small optimization for generic parameters.
242 (InferTypeArguments): Add infering support for anonymous methods.
244 2007-03-15 Martin Baulig <martin@ximian.com>
249 (TypeParameter.HasConstructorConstraint): Removed.
250 (ConstraintChecker.HasDefaultConstructor): Removed the
251 `TypeBuilder' argument here; correctly check for the ctor
252 constraint on type parameters.
254 2007-03-15 Martin Baulig <martin@ximian.com>
259 (TypeParameter): Create a `MemberCache' here as well. Note that
260 we need to create this on-demand when it's actually used.
262 2007-03-10 Marek Safar <marek.safar@gmail.com>
264 * generic.cs (TypeArguments.Resolve): Avoid redundant checks.
266 2007-03-09 Raja R Harinath <rharinath@novell.com>
268 * cs-parser.jay (WHERE): Move before QUERY_FIRST_TOKEN. 'where'
269 is a valid keyword outside a linq expression too.
271 2007-03-03 Marek Safar <marek.safar@gmail.com>
273 * cs-parser.jay: Implemented basic linq grammar.
275 * linq.cs: New file for hosting query specific classes.
277 2007-02-26 Marek Safar <marek.safar@gmail.com>
279 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
281 2007-02-20 Marek Safar <marek.safar@gmail.com>
284 * cs-parser.jay: Anonymous container starts at constructor declaration
285 and not at block beginning because it has to be usable in constructor
288 2007-02-18 Marek Safar <marek.safar@gmail.com>
290 A fix for bug #80493 by Atsushi Enomoto
291 * cs-parser.jay: Ignore invalid attribute target.
293 2007-02-15 Miguel de Icaza <miguel@novell.com>
295 * Remove the call to SetExpression for lambda expressions, we do
296 not actually need it.
298 Remove expression tracking code as its not needed.
300 2007-02-11 Miguel de Icaza <miguel@novell.com>
302 * cs-parser.jay (lambda_expression_body): when the body is an
303 expression add a statement of the form:
305 contextual-return expression.
307 Where `contextual-return' is similar to `return', the difference
308 being that if the delegate that the lambda will be converted to
309 has a void return type, it will check that the result is a
310 ExpressionStatement and the result is a plain ret (no return
311 values on the stack). If the return type of the delegate is of a
312 given type, this turns into a return with a value and does the
313 regular checking to check that the computed value can be
314 implicitly converted to the delegate return.
316 2007-01-30 Miguel de Icaza <miguel@novell.com>
318 * cs-parser.jay (anonymous_method_expression): move the
319 before/after productions to the start_anonymous and end_anonymous
320 methods so the code can be reused for lambda functions.
322 (lambda_expression_body): wrap expressions implicitly into a
325 (block): factor out the setup/teardown of parsing a block so we
326 can reuse that in lambda_expression_body
328 (lambda_expression): use new anonymous method helper methods.
330 2007-01-29 Miguel de Icaza <miguel@novell.com>
332 * cs-parser.jay: oob_stack make it static (am guessing that is why
333 we no longer initialize it anymore) and reuse it across
336 2007-01-28 Miguel de Icaza <miguel@novell.com>
338 * cs-parser.jay (open_parens): Introduce new non-terminal that
339 abstracts OPEN_PARENS and OPEN_PARENS_LAMBDA as the later can now
340 be returned in places where types are followed by identifiers
341 (this is expected in declaration, fixed, using, foreach and catch
344 Use open_parens in those places, keep OPEN_PARENS in the
347 cs-parser.jay: New grammar bits for parsing lambda expressions.
349 2007-01-28 Raja R Harinath <rharinath@novell.com>
351 Fix #80534, gtest-309.cs
352 * generic.cs (UnifyType): Rename from InferType. Make unification
353 of generic insts simpler and don't insist on inferring all generic
354 parameters in a single generic inst unification.
356 (InferGenericInstance): Remove.
357 Analysis and initial patch by David Mitchell <dmitchell@logos.com>.
359 2007-01-20 Marek Safar <marek.safar@gmail.com>
361 * cs-parser.jay: Better parameter error handling.
363 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
364 Raja R Harinath <rharinath@novell.com>
366 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
367 Note the order in which accessors are declared in the source.
369 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
371 * generic.cs (TypeParameter.FindMembers): Use the generic
372 constraints, not the constraints to check for methods (first fix
375 2006-12-30 Marek Safar <marek.safar@gmail.com>
377 * cs-parser.jay: Better syntax errors handling.
379 2006-11-21 Marek Safar <marek.safar@gmail.com>
381 * cs-parser.jay: Tiny change to work with mcs tokenizer.
383 * cs-tokenizer.cs: Remove after unification with mcs.
385 2006-10-28 Marek Safar <marek.safar@gmail.com>
388 * generic.cs (ConstructedType.AsAccessible): Check accessibility of type
391 2006-10-26 Marek Safar <marek.safar@gmail.com>
394 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous methods.
396 2006-10-25 Brian Crowell <brian@fluggo.com>
399 * generic.cs (CheckConstraints): Allow generic parameters with
400 inheritance constraints to satisfy reference type constraints.
402 2006-10-09 Martin Baulig <martin@ximian.com>
405 (NullCoalescingOperator.DoResolve): Fix #78964; added gtest-294.cs.
407 2006-09-25 Martin Baulig <martin@ximian.com>
409 * class.cs: Remove after unification with mcs source.
411 2006-09-24 Raja R Harinath <harinath@gmail.com>
413 * convert.cs: Remove after unification with mcs source.
415 2006-09-24 Marek Safar <marek.safar@seznam.cz>
417 * class.cs (MemberBase.VerifyClsCompliance): When method has type
418 parameters verify them as well.
420 * generic.cs (Constraints.VerifyClsCompliance): Verify CLS-Compliance of
421 the type parameter constraints.
422 (Generics.VerifyClsCompliance): Ditto.
424 2006-09-24 Marek Safar <marek.safar@seznam.cz>
426 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
427 for anonymous block with out argument.
429 2006-09-24 Marek Safar <marek.safar@seznam.cz>
431 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
432 not used private events only.
434 2006-09-23 Marek Safar <marek.safar@seznam.cz>
436 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
438 * cs-parser.jay: Parse correctly cast of default (T).
440 * generic.cs (DefaultValueExpression.DoResolve): Check for void type.
441 Store original type via EmptyConstantCast.
443 2006-09-22 Martin Baulig <martin@ximian.com>
445 * delegate.cs: Removed; this file is now shared with mcs.
447 * attribute.cs: Removed; this file is now shared with mcs.
449 2006-09-22 Martin Baulig <martin@ximian.com>
451 * ecore.cs: Removed; this file is now shared with mcs.
453 2006-09-21 Marek Safar <marek.safar@seznam.cz>
455 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
457 * ecore.cs (NullCast): Derives from NullConstant.
459 * generic.cs (DefaultValueExpression): Fixed to cope with the constant
462 2006-09-21 Martin Baulig <martin@ximian.com>
464 * decl.cs: Removed; this file is now shared with mcs.
466 2006-09-21 Raja R Harinath <rharinath@novell.com>
468 * rootcontext.cs: Remove after unification with mcs source.
470 * report.cs: Remove after unification with mcs source.
471 * generic.cs (AddTypeParameter, LookupTypeParameter): Move to
473 (InitGenerics, CleanUpGenerics): Remove.
475 * support.cs: Remove after unification with mcs source.
477 2006-09-20 Raja R Harinath <rharinath@novell.com>
479 * codegen.cs: Remove after unification with mcs source.
481 2006-09-19 Martin Baulig <martin@ximian.com>
483 * expression.cs: Removed; this file is now shared with mcs.
485 2006-09-19 Martin Baulig <martin@ximian.com>
488 (TypeManager.IsEqual): Moved into ../mcs/typemanager.cs.
489 (TypeManager.DropGenericTypeArguments): Likewise.
490 (TypeManager.DropGenericMethodArguments): Likewise.
491 (TypeManager.GetTypeArguments): Likewise.
492 (TypeManager.HasGenericArguments): Likewise.
494 2006-09-19 Martin Baulig <martin@ximian.com>
496 * ecore.cs (PropertyExpr.InstanceResolve): Fix the CS1540 check.
498 2006-09-19 Martin Baulig <martin@ximian.com>
500 * typemanager.cs: Removed; this file is now shared with mcs.
502 2006-09-16 Raja R Harinath <rharinath@novell.com>
504 * Makefile (LOCAL_MCS_FLAGS): Use instead of PROFILE_MCS_FLAGS.
505 * AssemblyInfo.cs, driver.cs: Remove after unification with mcs source.
507 2006-09-16 Marek Safar <marek.safar@seznam.cz>
510 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
511 only if parent type is class.
512 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
515 2006-09-15 Marek Safar <marek.safar@seznam.cz>
518 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
520 * typemanager.cs(CSharpName): Converts NullType to null.
522 2006-09-15 Martin Baulig <martin@ximian.com>
524 * pending.cs: Removed; this file is now shared with mcs.
526 2006-09-15 Martin Baulig <martin@ximian.com>
528 * statement.cs: Removed; this file is now shared with mcs.
530 2006-09-15 Martin Baulig <martin@ximian.com>
532 * rootcontext.cs (RootContext.BrokenCircularDeps): Removed.
534 * driver.cs: Removed the `--broken-cycles' argument.
536 2006-09-15 Martin Baulig <martin@ximian.com>
538 * namespace.cs: Removed; this file is now shared with mcs.
540 2006-09-15 Martin Baulig <martin@ximian.com>
542 * decl.cs (MemberName): Minor code cleanups.
544 2006-09-15 Martin Baulig <martin@ximian.com>
546 * parameter.cs: Removed; this file is now shared with mcs.
548 2006-09-15 Martin Baulig <martin@ximian.com>
550 * enum.cs: Removed; this file is now shared with mcs.
552 2006-09-15 Martin Baulig <martin@ximian.com>
554 * Makefile: Define `GMCS_SOURCE'.
556 * flowanalysis.cs: Removed; this file is now shared with mcs.
558 2006-09-15 Martin Baulig <martin@ximian.com>
560 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
561 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
562 doc.cs - they are now shared with mcs.
564 * gmcs.exe.sources: Include these files from ../mcs/.
566 2006-09-15 Martin Baulig <martin@ximian.com>
568 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
569 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
571 2006-09-14 Marek Safar <marek.safar@seznam.cz>
573 * assign.cs, ecore.cs, expression.cs: Share error message text.
574 * class.cs (FieldMember.Define): Check for variable of static type.
575 * decl.cs (check_type_parameter): Report correct type name.
576 * driver.cs (LoadAssembly): Uses error output for errors.
577 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
578 (TypeArguments.Resolve): Static class cannot be used as an argument.
579 * statement.cs (ResolveMeta): Constants cannot be generic types.
581 2006-09-12 Martin Baulig <martin@ximian.com>
583 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
585 * convert.cs (Convert.Array_To_IList): Moved here and correctly
586 implement it; fixes #79345.
588 2006-09-08 Marek Safar <marek.safar@seznam.cz>
590 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
592 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
594 * generic.cs: Improved error messages.
595 * typemanager.cs (RemoveGenericArity): Made public.
597 2006-09-08 Martin Baulig <martin@ximian.com>
599 * typemanager.cs (TypeManager.interlocked_type): New public field.
600 (TypeManager.int_interlocked_compare-exchange): New public field.
601 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
602 enumerator types here and call InitGenericCoreTypes().
603 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
604 after calling InitEnumUnderlyingTypes().
607 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
608 `classes_second_stage'.
610 2006-09-07 Marek Safar <marek.safar@seznam.cz>
612 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
614 * statement.cs (Block.Variables): Made public.
616 2006-09-07 Martin Baulig <martin@ximian.com>
619 (MainDriver): Revert r62663 from Marek; see #70506 for details.
621 2006-09-01 Martin Baulig <martin@ximian.com>
624 (TypeManager.IsIList): Also handle base classes and interfaces.
626 2006-09-01 Raja R Harinath <rharinath@novell.com>
629 * expression.cs (Invocation.MoreSpecific): Check for reference
632 2006-08-29 Miguel de Icaza <miguel@novell.com>
634 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
636 2006-08-17 Miguel de Icaza <miguel@novell.com>
638 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
639 #52019 and #79064, the use of the \uXXXX sequence in source code
640 to represent unicode characters.
642 2006-08-15 Marek Safar <marek.safar@seznam.cz>
644 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
646 * class.cs, ecore.cs, statement.cs: Merged to one error message.
648 2006-08-14 Raja R Harinath <rharinath@novell.com>
651 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
652 parameter too. This only avoids a parse error -- the semantic
653 error is caught elsewhere.
655 2006-08-13 Miguel de Icaza <miguel@novell.com>
657 * assign.cs: Catch attempts to assign to a method groups in += and
660 2006-08-13 Marek Safar <marek.safar@seznam.cz>
663 * cs-parser.jay: Don't destroy current array type by typeof of array's.
665 2006-08-12 Marek Safar <marek.safar@seznam.cz>
667 * cs-parser.jay: Check whether a constraint clause has already been
668 specified for type parameter.
669 * generic.cs (Constraints): Exposed location.
671 2006-08-12 Marek Safar <marek.safar@seznam.cz>
673 * class.cs (Method.Define): Issue a warning when generic method looks like
675 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
677 * report.cs: New warning number.
679 2006-08-09 Marek Safar <marek.safar@seznam.cz>
681 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
683 * decl.cs (MemberCache.FindMembers): When container is interface we need to
684 search all base interfaces as a member can be ambiguous.
685 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
686 Constructor member type filter.
687 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
688 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
689 reporting for returned memberinfos.
690 * report.cs: Updated.
691 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
692 version to work on all runtimes.
693 (TypeManager.RealMemberLookup): Removed members filtering.
695 2006-08-08 Raja R Harinath <rharinath@novell.com>
697 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
698 (PropertyExpr.EmitAssign): Likewise.
699 * expression.cs (Indirection.EmitAssign): Likewise.
700 (LocalVariableReference.EmitAssign): Likewise.
701 (ParameterReference.EmitAssign): Likewise.
702 (Invocation.EmitArguments): Likewise.
703 (ArrayAccess.EmitAssign): Likewise.
704 (IndexerAccess.EmitAssign): Likewise.
705 (This.EmitAssign): Likewise.
706 (ConditionalLogicalOperator.Emit): Likewise.
709 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
710 instead of ArrayList. If the hashtable has a LocalBuilder, don't
711 leave it in after returning it.
712 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
714 2006-08-06 Marek Safar <marek.safar@seznam.cz>
716 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
719 2006-08-05 Marek Safar <marek.safar@seznam.cz>
721 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
722 with different type names.
723 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
725 2006-08-03 Raja R Harinath <rharinath@novell.com>
727 Fix cs0146-3.cs and cs0146-4.cs.
728 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
729 enclosing types don't depend on the current type.
731 2006-08-02 Raja R Harinath <rharinath@novell.com>
734 * class.cs (TypeContainer.DoDefineMembers): Use
735 FindBaseMemberWithSameName on Parent, since we're interested in
736 whether we hide inherited members or not.
737 (FindBaseMemberWithSameName): Make slightly more robust.
740 * codegen.cs (IResolveContext.GenericDeclContainer): New.
741 (EmitContext): Implement new interface requirement.
742 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
743 * decl.cs (MemberCore): Likewise.
744 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
745 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
746 ec.GenericDeclContainer to check for generic parameters.
747 (SimpleName.DoSimpleNameResolve): Likewise.
748 * generic.cs (TypeParameter.DeclContainer): Remove override.
750 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
751 declspaces for doppelgangers too.
752 (UsingEntry): Implement IResolveContext.
753 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
754 'this' as the resolve context.
755 (LocalAliasEntry): Likewise.
757 Implement parts of #77403
758 * roottypes.cs (RootDeclSpace): New. Used to represent the
759 toplevel declaration space. Each namespace declaration introduces
760 a "partial" root declaretion space.
761 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
762 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
763 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
764 from 'current_namespace.SlaveDeclSpace'.
765 (namespace_declaration): Likewise.
766 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
767 check. It can't happen now.
768 * decl.cs (DeclSpace.LookupType): Likewise.
769 * driver.cs (MainDriver): Sanity check.
771 2006-08-01 Raja R Harinath <rharinath@novell.com>
773 * decl.cs (DeclSpace.FindNestedType): Remove.
774 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
775 LookupTypeContainer to get the container of the nested type.
776 * class.cs (TypeContainer.FindNestedType): Make non-override.
778 2006-07-31 Raja R Harinath <rharinath@novell.com>
780 * decl.cs (DeclSpace.PartialContainer): Move field from ...
781 * class.cs (TypeContainer.PartialContainer): ... here.
782 (TypeContainer.AddBasesForPart): New helper.
783 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
785 * cs-parser.jay (current_class): Convert to DeclSpace.
786 (struct_declaration, interface_declaration, class_declaration):
787 Use AddBasesForPart instead of .Bases directly.
788 * const.cs, iterators.cs: Update to changes.
790 2006-07-28 Raja R Harinath <rharinath@novell.com>
792 * class.cs (TypeContainer.AddMemberType): Rename from
794 (TypeContainer.AddMember): Rename from AddToMemberContainer.
795 (AddTypeContainer): New. Combine AddClassOrStruct and
797 (AddPartial): Update. Add 'is_partial' argument.
798 * roottypes.cs: Update to changes.
799 * cs-parser.jay (push_current_class): New helper for handling
800 current_container and current_class.
801 (struct_declaration, interface_declaration, class_declaration):
804 2006-07-26 Raja R Harinath <rharinath@novell.com>
806 * roottypes.cs: Rename from tree.cs.
808 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
809 * tree.cs (Tree, ITreeDump): Remove types.
810 * rootcontext.cs (tree, Tree): Remove fields.
811 (root, ToplevelTypes): New.
812 * *.cs: Update to rename.
814 * tree.cs (Tree.RecordDecl): Remove.
815 (RootTypes.AddToTypeContainer): Record the toplevel type in its
817 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
819 2006-07-23 Raja R Harinath <harinath@gmail.com>
821 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
822 DoFlowAnalysis and OmitStructFlowAnalysis here.
823 (ec.With): Rename from WithUnsafe and generalize.
824 (ec.WithCheckState): Remove. All users can be handled by 'With'.
825 (ec.WithFlowAnalyis): New.
826 * ecore.cs, expression.cs, statement.cs: Update.
828 2006-07-22 Raja R Harinath <harinath@gmail.com>
830 * statement.cs (Block.ResolveMeta): Simplify slightly.
832 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
833 multiple boolean fields. Convert InUnsafe, constant_check_state,
834 check_state to flags.
835 (CheckState, ConstantCheckState): Update.
836 (InUnsafe): New read-only property.
837 (FlagsHandle): Rename from CheckStateHandle and convert to handle
839 (WithUnsafe): New helper similar to WithCheckState.
840 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
841 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
843 2006-07-21 Raja R Harinath <rharinath@novell.com>
845 Make comparisons use the same IL irrespective of whether they're
846 in a 'checked' or 'unchecked' context: one of the issues in #78899
847 * codegen.cs (EmitContext.CheckState): Make read-only property.
848 (EmitContext.ConstantCheckState): Likewise.
849 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
850 helper that implement a save/restore stack for CheckState
851 values. This is the only way to change check-state.
852 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
853 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
854 (CheckedExpr.EmitBranchable): New forwarding method.
855 (UnCheckedExpr): Likewise.
856 * statement.cs (Block.ResolveMeta): Use WithCheckState.
857 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
858 (Checked.Resolve, checked.DoEmit): Likewise.
860 2006-07-21 Martin Baulig <martin@ximian.com>
862 * generic.cs (TypeManager.InferType): When inferring an array
863 type, also allow IList<T> and ICollection<T>. Fixes #78900.
865 2006-07-21 Martin Baulig <martin@ximian.com>
867 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
868 and allow IList`1 and all its base interfaces.
870 * convert.cs (Convert.ImplicitReferenceConversion): Allow
871 converting from an array-type of T to IList<T>.
873 2006-07-21 Martin Baulig <martin@ximian.com>
875 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
877 2006-07-20 Miguel de Icaza <miguel@novell.com>
879 * anonymous.cs: Cache the resolved anonymous delegate, and return
880 this so that the ResolveTopBlock is only triggered once, not
883 Currently we trigger ResolvetopBlock twice due to a first pass of
884 argument check compatibility, and a second pass that does the
887 2006-07-15 Marek Safar <marek.safar@seznam.cz>
889 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
891 * rootcontext.cs (Reset): Add helper_classes.
893 2006-07-15 Marek Safar <marek.safar@seznam.cz>
896 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
899 2006-07-13 Miguel de Icaza <miguel@novell.com>
901 * statement.cs (Lock): Handle expressions of type
902 TypeManager.null_type specially. Fixes #78770
904 2006-07-08 Marek Safar <marek.safar@seznam.cz>
906 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
909 2006-07-08 Marek Safar <marek.safar@seznam.cz>
911 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
912 for accessors as well.
913 * ecore.cs (EventExpr): Add AccessorTable.
915 2006-07-03 Martin Baulig <martin@ximian.com>
917 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
918 instances of value types.
920 * convert.cs (Convert.ExplicitConversion): Correctly handle
921 object->nullable conversions.
923 2006-07-01 Marek Safar <marek.safar@seznam.cz>
926 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
927 for CS0122 where appropriate.
928 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
930 (Filter): Assembly can be null in the case of top level attributes.
932 2006-06-28 Raja R Harinath <rharinath@novell.com>
935 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
936 no arguments, return 'false': nothing can be inferred.
938 2006-06-25 Marek Safar <marek.safar@seznam.cz>
942 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
943 is done at global level.
945 2006-06-24 Marek Safar <marek.safar@seznam.cz>
947 A fix for #77002, Implemented TypeForwarder support.
949 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
950 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
952 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
953 * typemanager.cs (): Add type_forwarder_attr_type.
955 2006-06-24 Marek Safar <marek.safar@seznam.cz>
957 * report.cs: Add CS0469 warning.
959 2006-06-22 Martin Baulig <martin@ximian.com>
962 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
963 for interfaces; fixes #78686, which is a modification of #78380
964 with interfaces instead of classes.
966 2006-06-21 Martin Baulig <martin@ximian.com>
968 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
969 the `try'-block, so we also report CS0016 etc. there.
971 2006-06-21 Martin Baulig <martin@ximian.com>
973 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
974 handle SetAssigned() and SetMemberIsUsed() for generic types;
977 2006-06-21 Martin Baulig <martin@ximian.com>
980 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
982 2006-06-21 Martin Baulig <martin@ximian.com>
984 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
985 also report CS1686 for parameters.
987 2006-06-21 Martin Baulig <martin@ximian.com>
989 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
990 instead of an error if the value is not implicitly convertible to
991 the switch types; fixes #77964.
993 2006-06-21 Raja R Harinath <rharinath@novell.com>
996 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
997 FieldBuilder is null.
1000 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
1001 'left' and 'right' before error-checking.
1003 2006-06-19 Martin Baulig <martin@ximian.com>
1006 (Convert.ImplicitConversionStandard): Cleanup and correctly
1007 implement nullable conversions.
1008 (Convert.ImplicitStandardConversionExists): Likewise.
1009 (Convert.ExplicitConversion): Likewise.
1011 2006-06-19 Martin Baulig <martin@ximian.com>
1014 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
1015 methods; make the ctors protected.
1017 2006-06-19 Martin Baulig <martin@ximian.com>
1019 Fixed #78380; added gtest-273.cs.
1022 (Expression.ResolveAsBaseTerminal): Move the constraint checking
1023 into ResolveAsTypeTerminal().
1026 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
1027 TypeManager.FindMembers() to check for the default ctor.
1029 2006-06-18 Marek Safar <marek.safar@seznam.cz>
1031 * generic.cs: Fixed NullableInfo accessibility.
1033 2006-06-16 Martin Baulig <martin@ximian.com>
1036 (Constraints.InflatedConstraints.inflate): Correctly inflate
1037 generic types; fixes #78400.
1039 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
1041 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
1043 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
1044 (FieldExpr.DoResolve): likewise.
1045 (PropertyExpr.InstanceResolve): likewise.
1046 (EventExpr.InstanceResolve): likewise.
1048 2006-06-15 Martin Baulig <martin@ximian.com>
1051 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
1052 argument; always allow a `null' label if true.
1053 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
1054 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
1055 we have a `null' label and mark the new `null_target' label;
1056 default to the `default' label.
1057 (Switch.Resolve): Add support for nullable types. Fixes #78630.
1059 2006-06-15 Martin Baulig <martin@ximian.com>
1061 * class.cs (Operator.Define): Allow an implicit/explicit operator
1062 to convert to/from a nullable value of the enclosing type.
1064 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
1065 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
1068 (Convert.ImplicitStandardConversionExists): Add support for lifted
1069 implicit/explicit conversions.
1070 (Convert.ImplicitConversionStandard): Likewise.
1072 2006-06-13 Martin Baulig <martin@ximian.com>
1074 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
1075 type arguments and create a ConstructedType if necessary. Fixes #78400.
1077 2006-06-04 Marek Safar <marek.safar@seznam.cz>
1079 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
1080 attribute applicable tests for attribute argument.
1082 2006-06-02 Raja R Harinath <rharinath@novell.com>
1085 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
1086 (Binary.OverloadResolve_PredefinedIntegral): New.
1087 (Binary.OverloadResolve_PredefinedFloating): New.
1088 (Binary.OverloadResolve_PredefinedString): New.
1089 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
1090 Follow the standard more closely, and treat numeric promotions in
1091 terms of overload resolution.
1092 (Binary.CheckShiftArguments): Simplify.
1094 2006-06-01 Raja R Harinath <rharinath@novell.com>
1096 * flowanalysis.cs (MyBitVector): Simplify representation.
1097 (MyBitVector.Clone): Avoid allocating BitArray.
1098 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
1099 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
1100 (*): Update. Change all references to MyBitVector.And and
1101 MyBitVector.Or to &= and |=.
1103 2006-05-31 Raja R Harinath <rharinath@novell.com>
1105 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
1106 Use bne.un instead of ceq+brfalse.
1109 * typemanager.cs (IsUnmanagedType): Disallow generic types and
1112 2006-05-29 Raja R Harinath <rharinath@novell.com>
1115 * cs-parser.jay (formal_parameter_list): Extend the pattern below
1116 to param arguments too.
1118 2006-05-26 Miguel de Icaza <miguel@novell.com>
1120 * cs-parser.jay: Catch another parsing form for arglist being
1121 followed by other arguments. Fixes #78313.
1123 2006-05-25 Raja R Harinath <rharinath@novell.com>
1126 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
1127 also when one of the operands is a null literal.
1128 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
1129 to improve clarity, and generate slightly better code.
1131 2006-05-24 Raja R Harinath <rharinath@novell.com>
1133 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
1134 checking of out parameters to ...
1135 (FlowBranchingToplevel.Merge): ... here.
1136 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
1137 set, propagate the origin upward, and only complain if there was
1139 (FlowBranchingException.AddContinueOrigin): Likewise.
1140 (FlowBranchingException.AddReturnOrigin): Likewise.
1141 (FlowBranchingException.AddGotoOrigin): Likewise.
1143 2006-05-23 Raja R Harinath <rharinath@novell.com>
1145 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
1146 unreachable, skip it.
1147 (FlowBranchingException.Merge): Always propagate jumps, even if
1148 the finally block renders subsequent code unreachable.
1150 2006-05-18 Raja R Harinath <rharinath@novell.com>
1153 * statement.cs (Goto.Resolve): Move responsibility for resolving
1154 'goto' to FlowBranching.AddGotoOrigin.
1155 (Goto.SetResolvedTarget): New. Callback to set the
1156 LabeledStatement that's the target of the goto.
1157 (Goto.DoEmit): Use Leave instead of Br when crossing an
1158 unwind-protect boundary.
1159 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
1160 LookupLabel and adjust to new semantics.
1161 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
1162 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
1163 Goto.SetResolvedTarget to update target.
1164 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
1165 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
1166 AddBreakOrigin & co. Delay propagation until ...
1167 (FlowBranchingException.Merge): ... this.
1169 * statement.cs (Block.Resolve): Always depend on flow-branching to
1170 determine unreachability. Kill workaround that originally emitted
1171 only one statement after an "unreachable" label (see infloop in
1174 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
1175 This is still "wrong", but anything better would probably need a
1176 multi-pass algorithm.
1177 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
1178 usage vector. Force current usage vector to be reachable, to
1179 optimistically signify backward jumps.
1180 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
1182 (FlowBranchingLabeled.Merge): New. If no backward jump was
1183 detected, return the original salted-away usage vector instead,
1184 updated with appropriate changes. Print unreachable warning if
1186 * statement.cs (Block.Resolve): Don't print unreachable warning on
1187 a labeled statement.
1189 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
1191 * driver.cs: Pass filename without path to AssemblyBuilder's
1192 AddResourceFile. Fixes bug #78407.
1194 2006-05-17 Raja R Harinath <rharinath@novell.com>
1196 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
1197 * flowanalysis.cs (FlowBranchingLabeled): ... here.
1198 (FlowBranching.MergeChild): Overwrite
1199 reachability information from Labeled branchings too.
1201 2006-05-16 Raja R Harinath <rharinath@novell.com>
1203 * statement.cs (Goto.Resolve): Merge jump origins here ...
1204 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
1206 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
1207 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
1208 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
1209 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
1211 * statement.cs (Goto.Resolve): ... not here.
1212 (Goto.Emit): Remove CS1632 check.
1214 2006-05-14 Marek Safar <marek.safar@seznam.cz>
1216 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
1219 2006-05-11 Raja R Harinath <rharinath@novell.com>
1221 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
1222 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
1223 (FlowBranchingException.Label): Likewise.
1225 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
1227 (MyBitVector.Or): Use it to avoid losing information (Count).
1228 (FlowBranching.MergeOrigins): Likewise.
1230 * flowanalysis.cs (UsageVector.IsDirty): Remove.
1231 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
1232 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
1233 (UsageVector.ToString): Simplify.
1234 (UsageVector.MergeSiblings): Move here from ...
1235 (FlowBranching.Merge): ... here.
1236 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
1239 2006-05-10 Raja R Harinath <rharinath@novell.com>
1241 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
1242 null bitvector is treated as all-true.
1244 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
1245 (MyBitVector): Rationalize invariants. 'vector != null' implies
1246 that we have our own copy of the bitvector. Otherwise,
1247 'InheritsFrom == null' implies all inherited bits are true.
1249 2006-05-09 Marek Safar <marek.safar@seznam.cz>
1251 * statement.cs (LocalInfo): Add IsConstant.
1252 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
1253 local variable for constants.
1255 2006-05-09 Raja R Harinath <rharinath@novell.com>
1257 * flowanalysis.cs (MyBitVector.Empty): New.
1258 (MyBitVector): Don't allow InheritedFrom to be null.
1259 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
1260 (UsageVector, FlowBranching): Update to changes.
1262 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
1263 recursion. The 'Parent == null' condition isn't sufficient for
1265 (FlowBranching.AddBreakOrigin): Likewise.
1266 (FlowBranching.AddContinueOrigin): Likewise.
1267 (FlowBranching.AddReturnOrigin): Likewise.
1268 (FlowBranching.StealFinallyClauses): Likewise.
1269 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
1270 (FlowBranching.CheckOutParameters): Likewise.
1271 (FlowBranchingToplevel): Terminate all the above recursions here.
1272 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
1273 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
1275 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
1277 (FlowBranchingToplevel): New. Empty for now.
1278 (FlowBranching.MergeTopBlock): Update.
1279 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
1280 branching for the anonymous delegate.
1281 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
1283 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
1284 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
1285 information at the start of the merge. Reorganize.
1287 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1289 * class.cs (MethodData.Define): Method cannot implement interface accessor.
1291 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1293 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
1294 to newly introduced ctor.
1296 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
1297 message to one place.
1298 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
1301 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1303 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
1305 * ecore.cs (Expression.ResolveAsConstant): Updated.
1307 * statement.cs (ResolveMeta): Updated.
1309 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1311 * cs-parser.jay: __arglist cannot be used in initializer.
1313 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1316 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
1319 2006-05-05 Raja R Harinath <rharinath@novell.com>
1321 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
1322 (LabeledStatement): Add 'name' parameter.
1323 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
1324 (Block.AddLabel): Update to changes.
1325 * cs-parser.jay (labeled_statement): Likewise.
1327 * flowanalysis.cs (BranchingType.Labeled): New.
1328 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
1329 (FlowBranchingLabeled): New. Does nothing for now, but will
1330 eventually handle 'goto' flows.
1331 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
1332 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
1333 that's terminated ...
1334 (Block.Resolve): ... here.
1336 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
1337 (UsageVector.MergeFinallyOrigins): Likewise.
1338 (FlowBranching.InTryOrCatch): Likewise.
1339 (FlowBranching.AddFinallyVector): Likewise.
1340 (FlowBranchingException): Update to changes.
1343 * statement.cs (Return.Resolve): Move error checking to ...
1344 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
1345 (FlowBranchingException): Handle return origins like break and
1347 (FlowBranching.UsageVector.CheckOutParameters): Remove.
1349 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1352 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
1355 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1358 * class.cs (MethodData.Define): Do public accessor check only when method
1359 implements an interface.
1361 2006-05-04 Raja R Harinath <rharinath@novell.com>
1363 Remove special handling of 'break'
1364 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
1365 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
1366 (UsageVector.Break): Remove.
1367 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
1369 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
1371 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
1372 UsageVector.Breaks (). Don't set NeedsReturnLabel.
1374 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1377 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
1378 be the interface member.
1380 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1383 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
1384 for emitting small (int) values.
1386 2006-05-03 Raja R Harinath <rharinath@novell.com>
1389 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
1390 control-flow passes through the 'finally' after merging-in all the
1391 control-flows from 'try' and the 'catch' clauses.
1393 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
1394 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
1395 always true at the only non-recursive entry point.
1396 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
1397 FlowBranchingBreakable.
1398 (FlowBranchingLoop): Remove.
1399 * statement.cs (Return.DoResolve): Update to changes.
1402 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
1403 (FlowBranching.CreateBranching): Handle it: create a
1404 FlowBranchingContinuable.
1405 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
1406 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
1407 except that it handles the 'continue' command.
1408 (FlowBranching.UsageVector.MergeOrigins): Rename from
1410 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
1411 except that it overrides AddContinueOrigin.
1412 (FlowBranchingException): Override AddContinueOrigin, similar to
1414 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
1415 Create a new branching around the embedded statement.
1416 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
1417 control flow after the embedded statement.
1418 (Continue.Resolve): Move all error checking to AddContinueOrigin.
1420 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
1421 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
1422 FlowBranchingBreakable.
1423 (FlowBranchingSwitch): Remove.
1426 * statement.cs (Break.Resolve): Simplify. Move responsibility for
1427 error reporting to ...
1428 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
1429 Rename from 'AddBreakVector'. Add new location argument. Return
1430 a bool indicating whether the 'break' crosses an unwind-protect.
1431 (FlowBranchingException.AddBreakOrigin): Add.
1432 (FlowBranchingException.Merge): Propagate 'break's to surrounding
1433 flowbranching after updating with the effects of the 'finally'
1435 (FlowBranchingBreakable): New common base class for
1436 FlowBranchingLoop and FlowBranchingSwitch.
1438 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
1440 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
1442 2006-05-02 Raja R Harinath <rharinath@novell.com>
1444 * statement.cs (Do.Resolve): If the loop is infinite, set the
1446 (While.Resolve, For.Resolve): Set a barrier after the embedded
1447 statement. There's no direct control flow that goes from the end
1448 of the embedded statement to the end of the loop.
1449 * flowanalysis.cs (FlowBranching.Infinite): Remove.
1450 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
1451 above ensure that the reachability is correctly computed.
1453 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
1454 (UsageVector.MergeBreakOrigins): If the current path is
1455 unreachable, treat it as if all parameters/locals are initialized.
1456 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
1457 infinite loops before merging-in break origins.
1459 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
1460 (Reachability.Reachable): Split part into ...
1461 (Reachability.Unreachable): ... this. Simplify.
1462 (Reachability.IsUnreachable): Use 'Unreachable' instead.
1464 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
1465 (Reachability.SetThrowsSometimes): Likewise.
1466 (FlowBranchingBlock.MergeTopBlock): Don't compare against
1467 TriState.Always, use corresponding property.
1468 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
1469 (Block.Resolve): Likewise. Remove some redundant checks.
1471 2006-05-02 Raja R Harinath <harinath@gmail.com>
1473 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
1474 (Reachability.Meet): Don't bother checking AlwaysThrows --
1475 barrier is always set.
1476 (FlowBranchingBlock.Merge): Likewise.
1478 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
1480 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
1481 defined, so it's references should also compile only for NET_2_0
1482 (as occurs in mcs version)
1484 2006-05-01 Raja R Harinath <harinath@gmail.com>
1486 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
1487 checks for unreachable.
1489 2006-05-01 Marek Safar <marek.safar@seznam.cz>
1492 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
1494 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
1495 whether field is really assigned.
1497 2006-04-30 Raja R Harinath <harinath@gmail.com>
1499 * flowanalysis.cs (Reachability): Make 4-argument constructor
1501 (Reachability.Meet): Rename from 'And'. Remove static variant.
1502 (Reachability.Always): Rename from the highly misleading
1503 'Reachability.Never'.
1504 (FlowBranching.Merge): Update to changes. Mark an impossible
1505 situation with a 'throw'.
1506 (*): Update to changes.
1508 2006-04-29 Raja R Harinath <harinath@gmail.com>
1510 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
1512 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
1513 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
1514 (*): Update to changes.
1515 * statement.cs: Update to changes.
1517 2006-04-28 Marek Safar <marek.safar@seznam.cz>
1520 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
1522 2006-04-28 Raja R Harinath <harinath@gmail.com>
1524 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
1527 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
1528 argument to two arguments: an usage-vector and a bool. Move call
1529 to FlowBranching.Merge () ...
1530 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
1532 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
1533 handling of loop and switch reachability to ...
1534 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
1536 2006-04-27 Raja R Harinath <harinath@gmail.com>
1538 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
1539 handling to FlowBranchingLoop.InLoop.
1540 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
1542 2006-04-26 Marek Safar <marek.safar@seznam.cz>
1545 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
1546 anonymous method is allowed from AnonymousContainer here.
1548 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
1550 2006-04-24 Raja R Harinath <rharinath@novell.com>
1553 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1555 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1558 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1559 (DoubleConstant.Reduce): Ditto.
1561 2006-04-23 Raja R Harinath <rharinath@novell.com>
1563 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1564 Remove 'lvalue_right_side' argument. Move parts to ...
1565 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1566 (LocalVariable.DoResolveLValue): ... these.
1568 2006-04-21 Raja R Harinath <rharinath@novell.com>
1571 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1572 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1573 (LocalVariableReference.DoResolveBase): Use it to implement new
1575 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1576 (Argument.Resolve): Simplify. Move CS1510 check ...
1577 * ecore.cs (Expression.ResolveLValue): ... here.
1578 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1579 (PropertyExpr.DoResolveLValue): Likewise.
1580 (FieldExpr.Report_AssignToReadonly): Likewise.
1581 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1582 LValueMemberAccess or LValueMemberOutAccess on instance depending
1584 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1585 DoResolve as appropriate.
1587 2006-04-20 Raja R Harinath <rharinath@novell.com>
1590 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1591 implicit conversions on 'out' and 'ref' arguments.
1593 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1594 improve clarity. Remove dead code.
1597 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1598 (Catch.Resolve): Resolve VarBlock if it exists.
1600 2006-04-19 Miguel de Icaza <miguel@novell.com>
1602 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1603 twice, this was some residual code, the enumerator was emitted
1604 properly in the two branche of if later.
1608 Thanks to Martin for finding the source of the problem
1610 2006-04-19 Raja R Harinath <rharinath@novell.com>
1612 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1613 cast is never an lvalue.
1614 (Cast.DoResolve, Cast.ResolveRest): Combine.
1615 (Argument.Emit): Simplify slightly. Move 'Expr is
1616 IMemoryLocation' check ...
1617 (Argument.Resolve): ... here.
1618 (Argument.Error_LValueRequired): Remove. Inline into only user.
1620 Simplifications. Fix cs0191-2.cs
1621 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1622 CS1649 and CS1651 to ...
1623 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1624 the actual selection of the error code and message to a lookup
1625 table. Add a dummy return value to simplify callsites.
1626 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1627 readonly fields of other instances of the same type. Move CS0197
1629 * expression.cs (Argument.Resolve): ... here. Simplify code.
1630 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1631 resolution of an out or ref argument. The code simplification
1632 above uses this invariant.
1634 2006-04-18 Raja R Harinath <rharinath@novell.com>
1636 Possibly fix #77752. Fix cs1690-[4-7].cs.
1637 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1638 CheckMarshallByRefAccess. Drop parameter.
1639 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1641 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1643 * report.cs (AllWarnings): Add CS1690.
1644 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1646 (LocalVariableReference.DoResolveBase): Update.
1648 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1650 * class.cs (MethodOrOperator): Moved common parts from method class.
1651 detect obsolete attributes.
1652 (Method.Define): Simplified as it reuses code from base.
1653 (Constructor.ValidAttributeTargets): Fixed issue found during
1655 (Destructor.ValidAttributeTargets): Fixed issue found during
1657 (Operator): Finished refactoring set off by #78020. Operator class is now
1658 ordinary method class.
1660 * anonymous.cs: Updated.
1662 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1664 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1666 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1668 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1669 detect obsolete attributes.
1670 (Method.CreateEmitContext): Moved to MethodOrOperator.
1672 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1675 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1676 customized exception to make crash detection easier.
1677 (MethodOrOperator): Started to work on new base class for methods and
1679 (Method): Derives from MethodOrOperator.
1680 (Constructor.Emit): Emits its own attributes.
1681 (AbstractPropertyEventMethod.Emit): Ditto.
1682 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1684 (Operator.Emit): It's temporary more tricky than should be.
1686 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1688 * report.cs (InternalErrorException): Add ctor with inner exception.
1690 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1693 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1696 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1699 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1702 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1704 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1705 attribute is present and Guid not.
1706 (Interface.ApplyAttributeBuilder): Ditto.
1708 * attribute.cs: Add error message.
1710 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1714 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1715 sources (it's composite) so hold them in extra array as they are used in
1716 Emit phase only. It worked in the previous versions by mistake.
1717 (Attribute.Emit): Emit attribute for more owners when exist.
1719 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1720 it has now different behaviour.
1722 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1724 * constant.cs (Constant.IsDefaultInitializer): New method.
1726 * class.cs: Updated.
1728 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1729 re-initialize default values. It saves KBs almost for every assembly.
1730 Thanks Zoltan for the idea.
1731 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1732 (ArrayCreation.DoResolve): Resolve only once.
1733 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1734 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1736 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1738 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1741 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1743 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1744 in an embedded statement too.
1746 2006-04-01 Raja R Harinath <rharinath@novell.com>
1749 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1753 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1756 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1757 arguments before checking whether a type is reflected or not.
1760 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1761 definition doesn't take part in overload resolution.
1762 (Invocation.IsParamsMethodApplicable): Likewise.
1763 (Invocation.OverloadResolve): When replacing a reflected override
1764 method with its base definition, ensure that type arguments are
1767 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1771 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1774 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1776 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1778 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1781 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1782 LocalTemporary change.
1784 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1786 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1787 initializers optimization.
1788 (ClassOrStruct.TypeAttr): Moved from modifiers.
1789 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1790 (FieldBase.ResolveInitializer): Resolves initializer.
1791 (FieldBase.HasDefaultInitializer): New property.
1793 * cs-parser.jay: Removed message.
1795 * expression.cs (CompilerGeneratedThis): New specialization.
1797 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1799 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1801 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1803 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1805 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1806 be now EnumConstants only.
1808 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1810 * attribute.cs, driver.cs: Reset more caches.
1812 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1814 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1816 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1818 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1819 for easier reuse. Updated all overrides.
1820 (IntegralConstant): New base class for all integral constants.
1821 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1822 of the constant range, report custom error.
1823 (UIntConstant.Reduce): Fixed uint conversion.
1825 * ecore.cs, literal.cs: Reduce updates.
1827 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1831 * class.cs (Constructor.Define): Removed extra if for default ctors.
1832 A patch from Atsushi Enomoto.
1834 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1836 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1837 GetAttributableValue.
1839 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1842 * convert.cs (ImplicitConversionRequired): Error message moved to
1845 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1846 automatic implicit conversion of an output value.
1847 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1849 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1851 (TypeOf.GetAttributableValue): Add extra handling for object type.
1853 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1854 special error message.
1856 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1858 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1860 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1861 compatible with MS runtime.
1863 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1865 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1866 attribute arguments here.
1868 * class.cs (Indexer.Define): The check was moved to attribute class.
1870 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1872 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1874 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1876 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1878 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1881 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1883 * doc-bootstrap.cs : fix build.
1885 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1887 * expression.cs (StringConcat.Append): Issue a warning when empty string
1890 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1892 * assign.cs (CompoundAssign.ResolveSource): Removed.
1894 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1897 * class.cs (TypeContainer.FindMethods): Removed.
1898 (TypeContainer.CheckMemberUsage): Made static.
1900 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1902 * constant.cs (CheckRange): Removed unused type argument.
1903 (CheckUnsigned): Removed unused type argument.
1905 * cs-parser.jay: Updated after MemberAccess clean up.
1906 Uses Length for empty string test.
1908 * cs-tokenizer.cs: Uses Length for empty string test.
1909 (IsCastToken): Made static.
1910 (is_hex): Made static.
1911 (real_type_suffix): Made static.
1913 * decl.cs (SetupCache): Made static.
1914 (OnGenerateDocComment): Removed unused ds argument.
1916 * delegate.cs (VerifyDelegate): Removed unused argument.
1918 * doc.cs: Uses Length for empty string test.
1920 * driver.cs: Uses Length for empty string test.
1922 * enum.cs (IsValidEnumType): Made static
1924 * expression.cs (EnumLiftUp): Removed unused argument.
1925 (ResolveMethodGroup): Ditto.
1926 (BetterConversion): Ditto.
1927 (GetVarargsTypes): Ditto.
1928 (UpdateIndices): Ditto.
1929 (ValidateInitializers): Ditto.
1930 (MemberAccess.ctor): Ditto.
1931 (GetIndexersForType): Ditto.
1933 * flowanalysis.cs: (MergeFinally): Removed unused argument.
1935 * iterators.cs: Updated after MemberAccess clean up.
1937 * location.cs: Uses Length for empty string test.
1939 * namespace.cs: Uses Length for empty string test.
1941 * report.cs (CheckWarningCode): Made static.
1943 * statement.cs (LabeledStatement): Removed unused argument.
1945 * typemanager.cs (FilterNone): Removed.
1947 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1949 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
1952 * class.cs: Updated.
1954 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1956 * cs-parser.jay.cs: __arglist is not allowed for delegates.
1958 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1962 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
1964 (AnonymousMethod.ImplicitStandardConversionExists): New method.
1965 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
1966 Add more error reporting; Fixed issue with params.
1968 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
1970 * cs-parser.jay: AnonymousMethod requires host container.
1972 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
1974 2006-03-18 Raja R Harinath <harinath@gmail.com>
1976 * class.cs: Change 'TypeContainer ds' constructor argument to
1977 'DeclSpace parent'. Some classes were missed below due to
1978 different naming convention.
1980 * class.cs (MemberCore.Parent): Delete. This makes the
1981 ParentContainer changes below enforceable by the compiler.
1983 Treat pointers to enclosing declaration space as 'DeclSpace', not
1985 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
1986 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
1988 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
1990 (Block.AddThisVariable): Likewise.
1991 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
1992 (AbstractPropertyEventMethod.Emit): Likewise.
1993 (AbstractPropertyEventMethod.EmitMethod): Likewise.
1994 (GetMethod.Define, SetMethod.Define): Likewise.
1995 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
1996 (DelegateMethod.EmitMethod): Likewise.
1998 Fix regression test-partial-13.cs.
1999 Rationalize use of PartialContainer. Ensure that the partial
2000 class semantics can be tied to type-correctness, i.e., any
2001 violation will cause a compile error.
2002 * class.cs, const.cs: Access all fields that belong to class
2003 TypeContainer via ParentContainer. Arguments of EmitContexts and
2004 Resolve()-like functions still use 'Parent'.
2006 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
2007 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
2008 (PropertyMethod.CheckModifiers): Remove unused argument.
2009 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
2012 2006-03-28 Raja R Harinath <rharinath@novell.com>
2014 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
2016 2006-03-17 Raja R Harinath <harinath@gmail.com>
2018 Make semantics of PartialContainer simpler.
2019 * decl.cs (DeclSpace.IsPartial): Remove.
2020 * class.cs (TypeContainer.IsPartial): Likewise.
2021 (TypeContainer..ctor): Set PartialContainer to point to self.
2022 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
2023 (TypeContainer.FindNestedType): Likewise.
2024 (MemberCore.ParentContainer): Simplify. Remove deprecation.
2026 2006-03-17 Marek Safar <marek.safar@seznam.cz>
2028 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
2030 2006-03-15 Marek Safar <marek.safar@seznam.cz>
2032 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
2035 2006-03-15 Marek Safar <marek.safar@seznam.cz>
2037 * class.cs (Operator.Define): An error for base conversion was not
2040 2006-03-13 Marek Safar <marek.safar@seznam.cz>
2042 A fix for #77593, #77574.
2044 * class.cs (MethodCore.CheckBase): Another if for operator.
2046 2006-03-18 Marek Safar <marek.safar@seznam.cz>
2050 * expression.cs (VerifyArgumentsCompat): Reverted to double error
2051 reporting, it's more tricky than I thought.
2053 2006-03-09 Marek Safar <marek.safar@seznam.cz>
2055 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
2058 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
2059 (DelegateCreation.ImplicitStandardConversionExists): New method for just
2062 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
2065 2006-03-04 Marek Safar <marek.safar@seznam.cz>
2069 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
2070 (Event.Define): ditto
2071 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
2073 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
2074 Removed redundant code and set NewSlot for Invoke method too.
2076 * parameter.cs (Parameters.ctor): Add custom, type ctor.
2077 (Parameters.MergeGenerated): New method. Use this method when you merge
2078 compiler generated argument with user arguments.
2080 2006-03-03 Marek Safar <marek.safar@seznam.cz>
2082 * attribute.cs (ResolveAsTypeTerminal): Removed.
2084 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
2085 specialization for predefined types; 30% speed up.
2086 Finally placed obsolete check to right place.
2087 (Expression.ResolveType): Removed.
2089 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
2090 Updated after ResolveType was removed.
2092 * expression.cs (Cast.ctor): Check void cast.
2093 (Binary.ResolveAsTypeTerminal): Is never type.
2094 (Conditional.ResolveAsTypeTerminal): Is never type.
2096 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
2098 2006-03-26 Marek Safar <marek.safar@seznam.cz>
2100 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
2102 2006-03-23 Martin Baulig <martin@ximian.com>
2104 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
2105 type check if either of the types is an open generic type.
2107 2006-03-23 Martin Baulig <martin@ximian.com>
2110 (Convert.ExplicitTypeParameterConversion): New method; implement
2111 explicit type parameter conversions.
2113 2006-03-23 Martin Baulig <martin@ximian.com>
2115 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
2116 blindly allow all conversions if we do not have any constraints.
2118 2006-02-27 Marek Safar <marek.safar@seznam.cz>
2120 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
2121 these two separated members to simplify the code.
2122 (Attribute.Resolve): Refactored to use new fields and methods.
2123 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
2124 implemented obsolete attribute checking.
2125 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
2126 implemented obsolete checking again. It look line never ending quest ;-)
2127 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
2129 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
2131 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
2133 *class.cs (Property.Define): Add RegisterProperty call.
2135 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
2136 argument groups (only 2).
2138 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
2139 encoding expression to arguments.
2140 (Expression.ExprClassToResolveFlags): Just turned to property.
2142 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
2143 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
2144 optimized as well as implemented support for zero-length attributes.
2146 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
2147 Add caching of PropertyInfo's.
2149 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2151 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
2152 error multiple times.
2154 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2156 New partial class implementation.
2157 A fix for #77027, #77029, #77403
2159 * attribute.cs (Attributable): Made attributes protected.
2161 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
2162 the replacements of ClassPart and PartialContainer.
2163 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
2164 (TypeContainer.AddInterface): Ditto.
2165 (TypeContainer.AddPartial): The main method for partial classes. It checks
2166 for errors and merges ModFlags and attributes. At the end class is added to
2168 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
2170 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
2171 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
2172 from the rest of partial classes.
2173 (TypeContainer.GetClassBases): Simplified.
2174 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
2176 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
2177 (TypeContainer.HasExplicitLayout): Uses Flags now.
2178 (PartialContainer): Removed.
2179 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
2180 (StaticClass): Was merged with Class.
2181 (Class.GetClassBases): class and static class bases are verified here.
2182 (Class.TypeAttr): Added static attributes when class is static.
2183 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
2184 (MemberBase): In some cases we need to call parent container for partial
2185 class. It should be eliminated but it's not easy now.
2187 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
2189 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
2190 partial classed to accumulate class comments.
2191 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
2193 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
2195 * driver.cs (MainDriver): Tree.GetDecl was removed.
2197 * modifiers.cs (Modifiers): Add partial modifier.
2199 * tree.cs (Tree.decl): Removed.
2200 (RootTypes): Started to use this class more often for root types
2203 2006-03-23 Raja R Harinath <rharinath@novell.com>
2205 * generic.cs (TypeParameter.UpdateConstraints): Update
2206 'constraints' if null.
2208 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2212 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
2213 external interface does not have an attribute.
2215 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2217 Another prerequisites for new partial classs implementation.
2219 * attribute.cs (Attribute.Equal): Implemented.
2220 (Attribute.Emit): Changed as attributes can be applied more than twice.
2221 (Attributes.Emit): Check for duplicate attributes here.
2223 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
2224 as a parameter, clean-up.
2226 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2230 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
2231 contains obsolete attribute check which can in some cases look for base
2232 type of current class which is not initialized yet.
2233 (TypeContainer.BaseType): Replacement of ptype.
2235 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
2237 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2239 First of prerequisites for new partial classs implemention.
2241 * attribute.cs (Attributable): Extended by ResolveContext;
2242 Attributes finally have correct context for resolving in all cases.
2243 (AttachTo): Attribute owner is assigned here.
2245 * codegen.cs (IResolveContext): Introduce new interface to hold
2246 all information needed in resolving phase.
2247 (EmitContext): Implements IResolveContext; more clean-up needed here.
2249 * decl.cs (MemberCore): Implemented IResolveContext.
2251 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
2252 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
2253 parameter.cs, statement.cs, tree.cs, typemanager.cs:
2254 Refactored to use new IResolveContext instead of EmitContext; cleanup
2256 2006-03-22 Raja R Harinath <rharinath@novell.com>
2258 Support ParameterDefaultValueAttribute in gmcs. Also applied to
2259 mcs to keep code differences small.
2260 * attribute.cs (Attribute.GetParameterDefaultValue): New.
2261 * typemanager.cs (parameter_default_value_attribute_type): New.
2262 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
2265 2006-03-22 Martin Baulig <martin@ximian.com>
2268 (Nullable.NullableLiteral): Derive from `NullLiteral'.
2271 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
2272 instead of the normal `NullLiteral'.
2274 2006-03-21 Martin Baulig <martin@ximian.com>
2277 * generic.cs (TypeManager.InferType): If `pt' is a generic
2278 parameter, don't check whether `pt == at'.
2280 2006-03-20 Raja R Harinath <rharinath@novell.com>
2283 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
2284 (TypeParameter.Resolve): Update to change.
2285 (ConstraintChecker.CheckConstraints): Resolve type-argument
2286 constraints before use.
2288 2006-03-16 Martin Baulig <martin@ximian.com>
2291 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
2292 and don't have any instance constructors, also lookup in the base class.
2293 (TypeManager.IsNullableValueType): New public method.
2295 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
2296 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
2297 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
2299 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
2300 instead of just TypeManager.IsNullableType() to determine whether
2301 a lifted operator exists.
2302 (UnaryMutator.DoResolve): Likewise.
2303 (Conditional.DoResolve): Likewise.
2304 (Binary.DoResolve): A lifted operator only exists if both operands
2305 are valuetypes and at least one of them is a nullable type.
2307 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
2309 * iterator.cs : yield break is allowed in try statement which has
2310 catch clauses. Fixed bug #77767.
2312 2006-03-12 Martin Baulig <martin@ximian.com>
2314 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
2315 private IsSignatureEqual() to compare types; see the comment in
2316 that method; fixes #77674.
2318 2006-03-10 Raja R Harinath <rharinath@novell.com>
2320 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
2321 (Expression.ResolveAsTypeTerminal): Likewise.
2322 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
2323 * expression.cs, generic.cs, iterators.cs: Likewise.
2324 * parameter.cs, statement.cs, typemanager.cs: Likewise.
2326 2006-03-09 Martin Baulig <martin@ximian.com>
2328 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
2329 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
2331 2006-03-09 Martin Baulig <martin@ximian.com>
2333 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
2334 `prepared' flag is set.
2336 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
2337 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
2338 issues; see gtest-254.cs.
2340 2006-03-07 Martin Baulig <martin@ximian.com>
2342 * generic.cs (TypeManager.InferType): Allow infering
2343 `IEnumerable<T>' with an array of T; see gtest-251.cs.
2345 2006-03-06 Martin Baulig <martin@ximian.com>
2348 (TypeManager.InferType): Fix gtest-250.cs.
2351 (TypeManager.IsSubclassOf): Also check the base class.
2354 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
2357 2006-03-01 Raja R Harinath <rharinath@novell.com>
2360 * expression.cs (ParameterReference.DoResolveBase): Change return
2362 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
2366 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
2369 * typemanager.cs (GetFullNameSignature): Don't nullref on
2370 protected accessors.
2372 2006-02-16 Martin Baulig <martin@ximian.com>
2375 (TypeManager.GetGenericFieldDefinition): New public method; use it
2376 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
2378 2006-02-14 Martin Baulig <martin@ximian.com>
2380 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
2382 2006-02-14 Martin Baulig <martin@ximian.com>
2385 (TypeManager.DropGenericMethodArguments): New public method; don't
2386 use GetGenericMethodDefinition() on something which is not a
2389 2006-02-14 Martin Baulig <martin@ximian.com>
2392 (ConstraintChecker.CheckConstraints): If a type parameter has the
2393 `struct' constraint, the type must be a non-nullable valuetype.
2395 2006-02-10 Martin Baulig <martin@ximian.com>
2398 (TypeManager.IsOverride): Make this work for instantiated methods
2399 in a generic class; fixes #77509.
2400 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
2401 rather than calling it directly; fixes #77488.
2403 2006-02-08 Martin Baulig <martin@ximian.com>
2405 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
2406 reporting into CheckConstraint() so we can use the correctly
2409 2006-02-08 Martin Baulig <martin@ximian.com>
2411 * expression.cs (BaseAccess): Add support for generic methods.
2413 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
2414 the new MethodGroupExpr.
2416 2006-02-07 Martin Baulig <martin@ximian.com>
2418 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
2419 also reference types; fixes #77483.
2421 2006-02-07 Martin Baulig <martin@ximian.com>
2424 (TypeManager.IsGenericMethod): We now return whether something is
2425 an instantiated generic method (and not a generic method def).
2426 (TypeManager.IsGenericMethodDefinition): New public method.
2429 (TypeManager.CSharpSignature): Only include type arguments for
2430 "real" generic methods, not for any instantiated method.
2431 (TypeManager.GetMethodName): Likewise, but also allow generic
2432 method definitions here.
2434 2006-02-06 Miguel de Icaza <miguel@novell.com>
2436 * codegen.cs (EmitScopeInitFromBlock): check here the
2437 capture_context, there is no need to make two calls to the
2440 * anonymous.cs: Add some debugging messages that might help me
2441 track other instances of this problem in the future (the
2442 regression of test 467).
2444 * cs-parser.jay: track the variable block, as we need to initalize
2445 any captured variables declared in this block for the "catch"
2446 portion of the "Try" statement.
2448 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
2449 scope initialization for captured variables.
2451 Also, move the emit for the variables after the block location has
2454 2006-02-06 Marek Safar <marek.safar@seznam.cz>
2456 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
2458 2006-02-06 Martin Baulig <martin@ximian.com>
2460 * class.cs (TypeContainer.DefineType): If we're a struct, pass
2461 `TypeManager.value_type' as parent type to
2462 ModuleBuilder.DefineType(). Fixes #77358.
2464 2006-02-02 Miguel de Icaza <miguel@novell.com>
2466 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
2467 commit yesterday, the initialization for the roots is necessary.
2468 What is not necessary is the scope activation.
2470 2006-02-02 Raja R Harinath <rharinath@novell.com>
2472 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
2473 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
2475 (Argument.Resolve): Remove CS0206 checks.
2477 2006-02-01 Miguel de Icaza <miguel@novell.com>
2479 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
2480 scopes for all the roots, the scopes will now be emitted when the
2481 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
2483 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
2484 code. This reduces a lot of existing cruft.
2486 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
2487 that the ScopeInfo is generated as we enter the scope, not at the
2488 time of use, which is what we used to do before.
2490 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
2491 every time a Block is about to be emitted if we have a
2494 2006-02-01 Raja R Harinath <rharinath@novell.com>
2496 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
2497 attribute for mscorlib too.
2499 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
2501 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
2503 * typemanager.cs (cons_param_array_attribute): Make private.
2504 (Reset): Set it to null.
2505 (InitCoreHelpers): Don't initialize it.
2506 (ConsParamArrayAttribute): New. Initialize it as needed.
2507 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
2509 2006-01-31 Miguel de Icaza <miguel@novell.com>
2511 * expression.cs: There might be errors reported during the
2512 selection of applicable methods. If there are errors, do not
2513 continue execution as it will lead the compiler to crash.
2515 2006-01-30 Miguel de Icaza <miguel@novell.com>
2517 * expression.cs: Member access is not allowed on anonymous
2518 methods. Fixes #77402.
2520 2006-01-30 Raja R Harinath <rharinath@novell.com>
2523 * cs-parser.jay (VariableDeclaration): Don't set
2524 current_array_type to null.
2525 (field_declaration, event_declaration, declaration_statement):
2526 Set it to null here.
2528 2006-01-29 Raja R Harinath <harinath@gmail.com>
2531 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
2533 2006-01-28 Raja R Harinath <harinath@gmail.com>
2535 * typemanager.cs (GenericParameterPosition): New.
2538 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
2540 * doc.cs : To process "include" elements, first we should create
2541 another list than XmlNodeList, because it could result in node
2542 removal, which could result in that the XmlNodeList gives up
2545 2006-01-25 Miguel de Icaza <miguel@novell.com>
2547 * expression.cs: Introduce an error report that we were not
2548 catching before. Gonzalo ran into it.
2550 2006-01-23 Miguel de Icaza <miguel@novell.com>
2552 A fix for bug: #76957
2554 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2555 ComputeMethodHost before creating the method, this is a new
2558 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2559 that this method references (RegisterScope). The actual scope
2560 where the method is hosted is computed with the ComputeMethodHost
2561 before we create the method.
2563 Moved the Deepest routine here.
2565 (AnonymousContainer.ComputeMethodHost): New routine used to
2566 compute the proper ScopeInfo that will host the anonymous method.
2568 (ScopeInfo): Deal with multiple roots. The problem was that we
2569 did not have a unique root where all ScopeInfos could be hanged
2570 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2573 Remove AdjustMethodScope which is now computed at the end. Remove
2574 LinkScope which did a partial link, instead link all ScopeInfos
2575 before code generation from the new "LinkScopes" routine.
2577 Simplify all the Add* routines as they no longer need to maintain
2578 the tree, they just need to record that they are using variables
2581 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2582 routines to produce the forest of ScopeInfo trees.
2584 * class.cs (TypeContainer.AppendMethod): This is just like
2585 AddMethod, but ensures that an interface implementation method
2586 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2587 methods, but at the end.
2589 We use this functionality to ensure that the generated MoveNext
2590 method in the iterator class is resolved/emitted before the
2591 enumerator methods created.
2593 This is required because the MoveNext method computes the right
2594 ScopeInfo for the method. And the other methods will eventually
2595 need to resolve and fetch information computed from the anonymous
2599 2006-01-23 Raja R Harinath <rharinath@novell.com>
2601 Improve implementation of section 14.4.2.2 (Better function member).
2602 * expression.cs (Invocation.MoreSpecific): Compare all type
2603 arguments before deciding if one type is more specific than
2604 another. Handle array types too. Return the more specific type.
2605 (Invocation.BetterFunction): Add more tie-breaking rules from
2606 section 14.4.2.2. Perform "more specific" check after
2607 other tie-breaking rules. Compare all parameter types before
2608 choosing the "more specific" method.
2610 2006-01-21 Raja R Harinath <harinath@gmail.com>
2611 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2614 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2616 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2617 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2619 2006-01-18 Martin Baulig <martin@ximian.com>
2621 * class.cs (TypeContainer.AddToMemberContainer): Use
2622 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2625 2006-01-18 Martin Baulig <martin@ximian.com>
2627 Fix #76417: a generic class may now have methods which may unify
2628 for some type parameter substitutions.
2630 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2631 for methods which may unify anymore.
2633 * expression.cs (Invocation.MoreSpecific): New private static
2634 method; checks whether one method is more specific than another
2635 according to 14.4.2.2 of the spec.
2636 (Invocation.BetterFunction): Implement the tie-breaking rules from
2637 14.4.2.2 of the spec: if two methods unify for some type parameter
2638 substitution, we need to pick the more specific one.
2640 2006-01-18 Raja R Harinath <rharinath@novell.com>
2642 Fix #76656, cs0231-2.cs.
2643 * cs-parser.jay (formal_parameter_list): Make error case catch
2645 (parenthesized_expression_0): Add CS1026 check.
2646 (invocation_expression): Remove unused { $$ = lexer.Location }.
2648 2006-01-17 Raja R Harinath <rharinath@novell.com>
2651 * cs-parser.jay (statement_expression): Don't list out the
2652 individual statement-expressions. Convert syntax error into
2655 2006-01-16 Raja R Harinath <rharinath@novell.com>
2658 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2659 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2660 CheckIntermediateModification.
2661 (FieldExpr.DoResolve): Add new two-argument version that
2662 allows us to resolve the InstanceExpression as an lvalue.
2663 The one-argument variant is now just a wrapper.
2664 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2665 Resolve the lhs as an lvalue if the it has a value type.
2666 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2667 from Assign.DoResolve.
2668 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2669 resolved as an lvalue.
2670 (PropertyExpr.DoResolve): Update.
2671 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2672 has a value type. Move CS1612 check here from
2673 CheckIntermediateModification.
2674 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2675 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2676 'right_side' of a ResolveLValue on an 'out' argument.
2677 (EmptyExpression.LValueMemberAccess): New. Used as the
2678 'right_side' of a propagated ResolveLValue on a value type.
2679 (LocalVariableReference.DoResolveBase): Recognize
2680 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2682 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2683 EmptyExpression.Null.
2685 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2687 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2688 Type.IsGenericParameter(). Fixed bug #77183.
2689 * doc.cs : it is now identical to doc.cs in mcs.
2691 2006-01-16 Martin Baulig <martin@ximian.com>
2693 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2695 2006-01-16 Martin Baulig <martin@ximian.com>
2697 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2698 ctors; fixes #77250.
2700 2006-01-12 Miguel de Icaza <miguel@novell.com>
2702 This fixes the problem where we used ldfld instead of ldflda to
2703 load the "THIS" pointer on captured parameters, when THIS is a
2704 value type. See bug #77205.
2706 * iterators.cs (CapturedThisReference.Emit): Pass false to
2707 EmitThis (we do not need the address).
2709 * codegen.cs (EmitThis): it needs to know whether we need the
2710 address of `this' or not. This is used by value types.
2712 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2713 every other call passes false.
2715 2006-01-12 Raja R Harinath <rharinath@novell.com>
2718 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2720 * expression.cs (Invocation.OverloadResolve): Update.
2721 (Invocation.DoResolve): Avoid double resolution of invocation.
2723 2006-01-11 Raja R Harinath <rharinath@novell.com>
2726 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2727 unary negation of floating point types as 0-expr; negation cannot
2728 overflow in floating point types.
2731 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2732 on operands of 'void' type.
2735 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2736 and ExclusiveOr for boolean constants too.
2738 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2740 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2742 2006-01-12 Miguel de Icaza <miguel@novell.com>
2744 * cs-tokenizer.cs (Position): New class used to save and restore
2745 the position state in the tokenizer. Before this patch the save
2746 and restore was not complete enough so the line and columns would
2747 start to drift and the debugger and stack traces will get the
2750 2006-01-10 Martin Baulig <martin@ximian.com>
2753 (TypeParameter.InflateConstraints): New public method.
2755 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2756 constraints; fixes #77042.
2758 2006-01-10 Martin Baulig <martin@ximian.com>
2760 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2761 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2764 2006-01-09 Raja R Harinath <rharinath@novell.com>
2767 * expression.cs (Invocation.OverloadResolve): Replace reflected
2768 override methods with their base virtual methods, rather than
2770 * typemanager.cs (TypeManager.GetOverride): New.
2772 2005-12-21 Miguel de Icaza <miguel@novell.com>
2774 * driver.cs: Report the case of no source files and no -out:
2777 2005-12-20 Raja R Harinath <rharinath@novell.com>
2780 * expression.cs (ComposedCast.GetSignatureForError): Define.
2782 2006-01-05 Jb Evain <jbevain@gmail.com>
2784 * class.cs (Property.Define, Indexer.Define): do not tag the
2785 properties as SpecialName | RTSpecialName.
2787 2006-01-04 Miguel de Icaza <miguel@novell.com>
2789 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2790 doing a low-level comparission of parameter types. It was lacking
2791 a check for __argslist.
2793 2005-12-30 Miguel de Icaza <miguel@novell.com>
2795 * expression.cs (ParameterReference.DoResolveBase): Allow
2796 reference parameters if they are local to this block.
2798 This allows the ref and out parameters of a delegate to be used in
2799 an anonymous method, for example:
2801 delegate void set (out int x);
2803 set s = delegate (out int x){
2807 This is used by functionality introduced late in the C# language.
2809 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2810 method that take ref and out parameters.
2812 Fixes #77119 which was a late change in the spec.
2814 2005-12-23 Miguel de Icaza <miguel@novell.com>
2816 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2817 parent if its the same scope. Fixes #77060.
2819 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2821 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2823 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2825 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2826 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2827 that doesn't contain the full public key. This is a update of the
2828 friend assemblies in .Net 2.0 release.
2830 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2834 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2835 ListDictionary, to contain the ExternAliasEntry entries (in
2836 addition to the NamespaceEntry.aliases hashtable). This field is
2837 shared between the original entry and its doppelganger (bodyless
2839 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2840 extern_aliases field.
2841 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2842 lookup in extern_aliases.
2844 2005-12-16 Raja R Harinath <rharinath@novell.com>
2847 * class.cs (TypeContainer.Mark_HasEquals): New.
2848 (TypeContainer.Mark_HasGetHashCode): New.
2849 (ClassPart): Override them.
2850 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2852 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2853 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2857 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2858 'parent' argument to the base constructor.
2860 Remove all mention of TypeContainer from decl.cs.
2861 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2862 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2863 (DeclSpace.DeclSpace): Likewise.
2864 (DeclSpace.DefineMembers): Remove unused argument.
2865 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2866 debugging check -- we don't care if the debug code throws an
2867 InvalidCastException instead of an InternalErrorException.
2868 * class.cs (TypeContainer.DefineMembers): Update to changes.
2869 (TypeContainer.DoDefineMembers): Likewise.
2870 (TypeContainer.GetMethods): Likewise.
2871 (PropertyMember.Define): Likewise.
2872 (MemberBase.Parent): New property that forwards to
2873 MemberCore.Parent, but ensures that we get a TypeContainer.
2874 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2875 (RootContext.PopulateTypes): Likewise. Remove special case code
2876 for !RootContext.StdLib: DefineMembers is idempotent.
2878 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2880 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2882 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2884 * doc.cs : The search for referenced namespace was insufficient to
2885 get global one as it used to do. Fixed bug #76965.
2887 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2889 * doc.cs : check name in cref in the last phase that whether it is
2892 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2894 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2897 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2899 * doc.cs : so it turned out that we cannot skip override check for
2900 interface members. Fixed bug #76954.
2902 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2904 * cs-tokenizer.cs : fixed bug #75984:
2905 - #warning and #error should not be handled when the source line
2907 - #line is not checked strictly when the source line is disabled.
2908 - #define and #undef is on the other hand checked strictly at any
2911 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
2913 * cs-tokenizer.cs : missing Location (actually, filename) in one of
2916 2005-12-15 Raja R Harinath <rharinath@novell.com>
2918 * generic.cs (TypeManager.IsGeneric): Remove unused method.
2920 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
2923 2005-12-14 Martin Baulig <martin@ximian.com>
2925 * typemanager.cs (TypeManager.GetFullName): Make this public;
2926 `Type.Fullname' now never returns null.
2928 * class.cs (Method.Define): Use TypeManager.GetFullName() for
2929 explicit interface implementations; we're now using the same
2930 naming convention than csc does.
2932 2005-12-14 Miguel de Icaza <miguel@novell.com>
2934 * convert.cs (ExplicitConversionCore): Check the return value from
2935 ExplicitConversionCore which can return null on failure. Fixes #76914
2937 2005-12-09 Raja R Harinath <rharinath@novell.com>
2939 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
2940 instead of IsGenericInstance.
2941 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
2942 code that's now covered by the more general test.
2943 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
2945 * generic.cs (DropGenericTypeArguments): New. Captures the common
2946 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
2947 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
2948 * generic.cs, report.cs, typemanager.cs: Likewise.
2950 2005-12-08 Martin Baulig <martin@ximian.com>
2952 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
2954 * typemanager.cs (TypeManager.CSharpSignature): Include type
2955 arguments in the signature of a generic method.
2957 2005-12-07 Martin Baulig <martin@ximian.com>
2959 Add support for custom attributes on type parameters.
2961 * cs-parser.jay (type_arguments): Added `opt_attributes'.
2963 * generic.cs (TypeParameterName): New public class; we use this
2964 instead of a `string' to store the name of a type parameter, so we
2965 can also have `Attributes'.
2966 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
2967 array instead of a `string[]' array.
2968 (TypeParameter.ctor): We now also take an `Attributes' argument.
2969 (TypeParameter.EmitAttributes): New public method; emit our
2970 `OptAttributes' here.
2971 (GenericMethod.EmitAttributes): New public method; emit the custom
2972 attributes on all our type parameters.
2974 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
2975 our type parameters.
2976 (MethodData.Define): If we're a generic method, call
2977 EmitAttributes() on it.
2979 2005-12-07 Martin Baulig <martin@ximian.com>
2982 (ConstraintChecker): New public abstract class; move the
2983 constraint checking here from `ConstructedType' and also do
2984 constraint checking for generic methods here.
2986 * expression.cs (Invocation.OverloadResolve): Use
2987 ConstraintChecker.CheckConstraints() if we resolved to a generic
2990 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2992 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
2994 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
2996 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
2997 (FieldBase.Initializer): Initializer is now optional.
2998 (EventField.Define): Only event field can have initializer.
3000 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
3002 * const.cs (Const): Reuse initializer.
3004 * cs-parser.jay: Updated after FieldBase changes.
3005 Added current_array_type to simplify array initializers.
3007 * ecore.cs (NullCast.IsDefaultValue): Implemented.
3009 * expression.cs, iterators.cs: Updated.
3011 * namespace.cs (NamespaceEntry): Made UsingFound private.
3013 2005-12-05 Marek Safar <marek.safar@seznam.cz>
3015 * parameterCollection.cs: Obsolete, removed.
3016 * parser.cs: Obsolete, removed.
3018 2005-12-05 Marek Safar <marek.safar@seznam.cz>
3021 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
3023 * enum.cs (Enum.Define): Set obsolete context here.
3025 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
3028 - FindDocumentedMember() now expects 1) paramList as null
3029 when "we don't have to check the number of parameters" and
3030 2) Type.EmptyTypes when "there is no arguments".
3031 - Introduced FoundMember struct to hold the exact type which was
3032 used to find the documented member (the above change broke
3033 test-xml-044; it might be better just to use DeclaringType than
3034 what MS does, like this change does, but it depends on usage.)
3036 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
3038 * doc.cs : documented member might be from DeclaringType for nested
3039 types. Fixed bug #76782.
3041 2005-12-03 Ben Maurer <bmaurer@ximian.com>
3043 * anonymous.cs: Have the param code handle leaving copies on the
3044 stack etc. Allows anonymous params to take part in the assignment
3045 code (++, +=, etc). Fixes bug #76550
3047 * expression.cs: Handle the prepare_for_load/leave_copy by passing
3048 it down to the anon code.
3050 * iterators.cs: Use dummy var here
3052 * codegen.cs: Handle new vars
3054 2005-12-01 Marek Safar <marek.safar@seznam.cz>
3057 * class.cs (MethodData.Define): Set proper Obsolete context.
3059 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
3061 (FieldExpr.DoResolve): Ditto.
3063 2005-12-01 Marek Safar <marek.safar@seznam.cz>
3066 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
3067 parent is not obsolete.
3069 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
3071 * doc.cs : (FindDocumentedMember) find parameterless members first
3072 and get CS0419 in the early stage. Fixed first case of bug #76727.
3074 2005-11-30 Marek Safar <marek.safar@seznam.cz>
3077 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
3078 no error was reported.
3080 *expression.cs (Binary.DoResolve): left can be null.
3082 2005-12-06 Raja R Harinath <rharinath@novell.com>
3084 * class.cs (MethodCore.CheckGenericOverride): Delete unused
3085 abstract method and all overrides.
3086 * support.cs (ParameterData.GenericConstraints): Delete.
3087 (ReflectionParameters.type_params): Delete.
3088 (ReflectionParameters.ReflectionParameters): Make private.
3089 (ReflectionParameters.GetConstaints): New factory method.
3090 * generic.cs (TypeParameterDefineType): Use it.
3091 (TypeManager.GetTypeParameterConstraints): Likewise.
3093 2005-11-22 Marek Safar <marek.safar@seznam.cz>
3096 * class.cs (MethodData.Emit): Parameters should be labeled first.
3098 2005-11-21 Marek Safar <marek.safar@seznam.cz>
3101 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
3103 2005-11-18 Marek Safar <marek.safar@seznam.cz>
3105 * attribute.cs (AreParametersCompliant): Moved to Parameter.
3107 * class.cs (MethodCore): Parameter clean up.
3108 (IMethodData): Added ParameterInfo.
3109 (MethodData): Parameter clean up.
3110 (Indexer.Define): Parameter clean up.
3122 * typemanager.cs: Parameter clean up.
3124 * delegate.cs (Define): Get rid of duplicated code.
3126 * expression.cs (ParameterReference): Removed useless parameters
3128 (Invocation): Ditto.
3130 * parameter.cs (ParamsParameter): New class, params specialization.
3131 (ArglistParameter): Attemp to separate arglist.
3132 (Parameter): Refactored to be reusable and faster.
3133 (Parameter.Modifier): Made understandable.
3134 (Parameters): Changed to be used as a class for `this' assembly
3135 parameters. Refactored to use new specialized classes.
3137 * support.cs (ParameterData): Added Types property.
3138 (InternalParameters): Deleted.
3140 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3142 * doc.cs : the previous patch does not actually fix the bug.
3143 PropertyInfo override check is now implemented and really fixed it.
3144 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
3146 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3148 * doc.cs : apply "override filter" also to properties.
3151 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3153 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
3154 no need to check overrides. For classes, omit those results from
3155 interfaces since they must exist in the class. Fixed bug #76726.
3157 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3159 * typemanager.cs : (GetFullNameSignature) differentiate indexers
3160 with different parameters. Fixed the second problem in #76685.
3162 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3164 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
3165 get expected 'protected' access in CheckValidFamilyAccess()).
3168 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3170 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
3171 Fixed bug #76705. CS1569 was incorrectly commented out.
3173 2005-11-23 Martin Baulig <martin@ximian.com>
3175 * generic.cs (Constraints.Define): Removed.
3176 (TypeParameter.DefineConstraints): Removed.
3177 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
3178 on the GenericTypeParameterBuilder here.
3180 2005-11-23 Martin Baulig <martin@ximian.com>
3182 * typemanager.cs (TypeManager.GetProperty): Make this public.
3184 * generic.cs (Nullable.NullableInfo.ctor): Use
3185 TypeManager.GetProperty() rather than using reflection directly.
3187 2005-11-17 Martin Baulig <martin@ximian.com>
3189 * expression.cs (Indexers.GetIndexersForType): Added support for
3190 generic parameters; fixes #76587.
3192 2005-11-17 Martin Baulig <martin@ximian.com>
3195 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
3196 inherit the scope from our parent. Fixes #76653.
3198 2005-11-15 Martin Baulig <martin@ximian.com>
3200 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
3201 instead of `ScopeTypeBuilder' to refer to the "current" type.
3202 (AnonymousMethod.CreateScopeType): Correctly create the helper
3203 class if we're inside a generic type definition.
3205 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3207 * doc.cs : use Invocation.IsOverride() to do real override check.
3208 * expression.cs : made Invocation.IsOverride() internal.
3210 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3212 * doc.cs : use TypeManager.FindMembers() instead of (possible)
3213 TypeBuilder.FindMembers() and filter overriden base members out.
3216 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3218 * doc.cs : ref/out parameters are represented as '@' (instead of
3219 '&' in type FullName). Fixed bug #76630 (additionally crefs).
3221 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3223 * doc.cs : when there was no '.' in cref to methods in doc comment,
3224 then parameters were missing in the output. Fixed bug #76691.
3226 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3228 * driver.cs : don't output docs when there is an error.
3231 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3234 Now it should detect indexers. Fixed primary concern in bug #76685.
3235 Fixed CS0419 message to not show the identical member signature in
3238 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3240 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
3241 instead of Type.FindMembers() since it does not handle events.
3244 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
3246 * codegen.cs: Fixed typo (speficied -> specified).
3248 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3251 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
3253 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3255 * attribute.cs: Changed error message.
3257 * cs-tokenizer.cs: One more check.
3259 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3261 * statement.cs (Block.Resolve): Ignore empty statement.
3263 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3265 * report.cs: Made error/warning methods more strict to avoid
3268 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
3269 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
3270 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
3271 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
3273 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3275 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
3276 Use the more explicit AssemblyName.FullName instead of
3277 AssemblyName.Name to report errors.
3279 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3281 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
3284 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3294 * report.cs: Fixed error reporting and typos.
3296 * generic.cs (TypeParameter.GetSignatureForError): New method.
3297 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
3299 * typemanager.cs (GetFullName): Refactored.
3301 2005-11-08 Marek Safar <marek.safar@seznam.cz>
3303 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
3304 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
3306 * class.cs (TypeContainer.IsComImport): New property.
3307 (Constructor.Define): Create proper ctor for ComImport types.
3309 * expression.cs (New.CheckComImport): Fixed.
3311 2005-11-07 Miguel de Icaza <miguel@novell.com>
3313 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
3314 that a parameter has been captured does not mean that we do not
3315 have to do the rest of the processing. This fixes the second part
3316 of #76592. If there was another anonymous method capturing
3317 values in the past, the Scope would never be set for the second
3318 method that captured the same parameter.
3320 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
3321 properly manipulate the stack. Second part of fix for #76592.
3323 * expression.cs (New): Add support for invoking "new" on
3324 interfaces that have been flagged with the ComImport attribute and
3325 the CoClass. Fixes #76637
3327 * statement.cs (Try.DoEmit): When a variable is captured, do not
3328 try to emit the vi.LocalBuilder variable as it has been captured.
3329 Create a temporary variable and store the results on the
3330 FieldBuilder. Fixes #76642
3332 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3334 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
3336 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
3338 * expression.cs (Binary.DoResolve): Added && optimalization.
3340 * typemanager.cs (AddUserType): Removed useless argument.
3342 2005-11-04 Marek Safar <marek.safar@seznam.cz>
3344 * statement.cs (Block.variables): Uses ListDictionary.
3346 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3349 * class.cs (PartialContainer.EmitType): Customized to emit
3350 security attributes.
3351 (ClassPart.ApplyAttributeBuilder): Transform security attribute
3352 for partial classes.
3354 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3357 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
3358 access has to be fixed.
3360 * typemanager.cs (IsUnmanagedType): Wrong common field type.
3362 2005-11-01 Marek Safar <marek.safar@seznam.cz>
3365 * ecore.cs (NullCast.Reduce): Implemented.
3367 * expression.cs (ArrayCreation.CheckIndices): Correcly check
3370 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
3372 (Foreach.Resolve): Catch null properly.
3374 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3376 * cs-tokenizer.cs: Warning text fix.
3378 * driver.cs: AllWarningNumbers exposed on public interface.
3380 * report.cs (): Reviewed warning numbers.
3381 (IsValidWarning): Use binary search.
3383 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3385 * driver.cs: Implemeted resource visibility.
3386 (Resources): New class for code sharing between /res: and
3389 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3391 decl.cs (CurrentTypeParameters): Fixed to be public.
3393 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3395 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
3397 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3399 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
3401 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
3403 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
3405 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3407 Add friend assembly access support.
3408 * typemanager.cs: assembly_internals_vis_attrs
3409 cache for friend assembly access.
3410 (TypeManager.IsFriendAssembly): New method for
3411 checking friend assembly access.
3412 (TypeManager.Error_FriendAccessNameNotMatching): New
3414 (TypeManager.CompareKeyTokens): Likewise.
3415 (TypeManager.Filter): Handle friend accessible
3418 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
3419 friend accessible types.
3421 * ecore.cs (Expression.IsAccessorAccessible): Handle
3422 friend accessible properties.
3424 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
3427 2005-10-28 Marek Safar <marek.safar@seznam.cz>
3430 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
3433 * convert (Convert.ImplicitReferenceConversion): NullCast holds
3436 * ecore.cs (NullCast): Child is contant only.
3438 * literal.cs (NullLiteral.Reduce): null can be converted to any
3441 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
3443 * driver.cs: Use Encoding.Default as default code page instead
3446 2005-10-27 Raja R Harinath <rharinath@novell.com>
3449 * expression.cs (Invocation.Error_InvalidArguments): Handle
3450 __arglist parameters.
3451 (Invocation.VerifyArgumentsCompat): Likewise.
3452 * support.cs (ReflectionParameters.GetSignatureForError): Print
3453 __arglist parameters.
3454 (InternalParamters.GetSignatureForError): Likewise.
3455 * parameter.cs (Parameters.GetSignatureForError): Likewise.
3457 2005-10-26 Marek Safar <marek.safar@seznam.cz>
3459 * attribute.cs (GetPropertyValue): Made public.
3461 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
3463 Add new property WrapNonExceptionThrows to handle 2.0 assembly
3465 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
3468 * driver.cs: Reflect method name change.
3470 * statement.cs (Try.Resolve): Warn when try has both general
3473 * typemanager.cs: runtime_compatibility_attr_type new predefined
3476 2005-10-26 Raja R Harinath <harinath@gmail.com>
3479 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
3480 treat it as an empty parameter list.
3482 2005-10-26 Raja R Harinath <rharinath@novell.com>
3485 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
3486 ResolveAsTypeStep silent.
3487 * statement.cs (Block.AddConstant): Mark block as used.
3488 (Block.ResolveMeta): Avoid piling on error messages
3489 if a constant initializer resolution fails.
3491 2005-10-25 Raja R Harinath <rharinath@novell.com>
3493 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
3495 (NamespaceEntry.VerifyAllUsing): New.
3496 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
3497 behaviour. Delegates actual resolution of alias to ...
3498 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
3499 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
3501 * driver.cs (Driver.MainDriver): Update.
3503 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
3504 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
3506 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
3508 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
3509 RootNamespace.DefineNamespacesForAll.
3511 2005-10-24 Raja R Harinath <harinath@gmail.com>
3513 * typemanager.cs (assemblies, external_aliases, modules)
3514 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
3515 (ComputeNamespaces, GetRootNamespace): Remove extra staging
3516 overhead. Move resposibility ...
3517 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
3518 * driver.cs, attribute.cs, codegen.cs: Update to changes.
3520 2005-10-23 Raja R Harinath <harinath@gmail.com>
3522 * namespace.cs (RootNamespace.all_namespaces): Renamed from
3523 cached_namespaces. Improve usage.
3524 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
3525 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
3526 Move from GlobalRootNamespace and simplify.
3527 (RootNamespace.Global): Make instance variable.
3528 (RootNamespace.RootNamespace): Add "alias name" parameter.
3529 (GlobalRootNamespace): Simplify drastically.
3530 (Namespace.Lookup): Don't use GetNamespace.
3531 * typemanager.cs (GetRootNamespace): Rename from
3532 ComputeNamespaceForAlias.
3533 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
3535 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3537 * anonymous.cs (AnonymousContainer): Don't crash when container
3540 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3542 * expression.cs (Binary.DoResolve): Warn when comparing same
3545 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3548 * expression.cs (Binary.DoResolve): It looks like there are no
3549 convetsion rules in enum context.
3551 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3553 Add support for extern alias qualifiers.
3554 * typemanager.cs: Move some LookupTypeReflection code
3555 to namespace.cs, to have cleaner code. Added some methods
3556 to help us keep track of the extern aliased references.
3557 * driver.cs: Add suport for extern alias assemblies on command
3558 line and check for their warnings/errors. Also keep track of the
3559 extern aliased assemblies.
3560 * namespace.cs: Move the global functionality of Namespace
3561 to GlobalRootNamespace/RootNamespace. Now the global namespace
3562 is GlobalRootNamespace.Globa. Also the code moved from
3563 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3564 Finally added LocalAliasEntry (AliasEntry before) and
3565 ExternAliasEntry, to handle alias statements.
3566 * cs-parser.jay: Add support in the grammar for extern alias
3568 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3569 Update callings to Namespace (now in GlobalRootNamespace).
3571 2005-10-25 Martin Baulig <martin@ximian.com>
3573 * convert.cs (ImplicitTypeParameterConversion): Make base
3574 interfaces actually work; fixes #76557.
3576 2005-10-25 Martin Baulig <martin@ximian.com>
3579 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3580 all the type parameters; fixes #76551.
3582 2005-10-25 Martin Baulig <martin@ximian.com>
3587 (GenericMethod.ctor): Added `Expression return_type' and
3588 `Parameters parameters' arguments.
3589 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3590 parameter and return types to check their constraints if they're
3593 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3596 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3597 constraints of a generic type if `ec.ResolvingGenericMethod'.
3599 * class.cs (MethodCore.DoDefineParameters): Set
3600 `ec.ResolvingGenericMethod' if we're a generic method.
3601 (MemberBase.MemberType): Likewise.
3603 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3605 * typemanager.cs (TypeManager): Added
3606 TypeManager.internals_visible_attr_type to cache
3607 S.R.CompilerServices.InternalsVisibleToAttribute.
3609 * codegen.cs (AssemblyClass): Added checks for
3610 InternalsVisibleToAttribute in new method
3611 CheckInternalsVisibleAttribute () and also cache the
3612 AssemblyName in AssemblyClass.Name.
3614 2005-10-24 Martin Baulig <martin@ximian.com>
3617 (TypeManager.ExpandInterfaces): Added overloaded version which
3618 just takes a `Type[]' array.
3621 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3622 just use the interfaces which were explicitly specified and not
3623 the interfaces they inherit. Fixes #76482.
3624 (TypeParameter.FindMembers): Expand the interfaces here.
3626 2005-10-21 Martin Baulig <martin@ximian.com>
3629 (Constraints.Resolve): Also resolve the actual types here.
3630 (Constraints.ResolveTypes): Just check the constraints here.
3631 Fixes #76363; see gtest-218.cs.
3633 2005-10-21 Martin Baulig <martin@ximian.com>
3636 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3637 instead of a `BoxedCast'; fixes gtest-217.cs.
3639 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3641 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3642 1) "new()" is specified as generic parameter constraint and 2) the
3643 type is TypeBuilder and 3) the type is abstract even if it has a
3644 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3646 2005-10-20 Martin Baulig <martin@ximian.com>
3649 (GenericConstraints.TypeParameter): New public property.
3650 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3651 (TypeParameter.DeclSpace): New public property.
3652 (TypeParameter.DefineType): Inflate the constraints if our
3653 `DeclSpace' is an `Iterator'.
3655 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3657 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3658 GenericMethod argument to compare methods' generic type arguments.
3661 2005-10-19 Martin Baulig <martin@ximian.com>
3663 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3664 not ResolveType() when resolving the base type, so we're not
3665 checking the constraints here.
3666 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3669 2005-10-19 Martin Baulig <martin@ximian.com>
3671 * generic.cs (ConstructedType.CheckConstraints): Committing
3672 untested fix for #76441.
3674 2005-10-18 Raja R Harinath <rharinath@novell.com>
3677 * class.cs (TypeContainer.DefineType): Move updating of
3678 topological sort earlier in the code.
3679 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3681 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3684 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3686 * constant.cs (Constant.TryReduce): Moved from Cast class.
3687 (Reduce): Made little bit more OO and fixed missing conversions.
3689 * ecore.cs (Reduce): Implemented.
3690 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3692 * literal.cs (Reduce): Implemented.
3694 * class.cs: Reverted Miguel's wrong commit.
3696 2005-10-14 Miguel de Icaza <miguel@novell.com>
3698 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3700 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3702 * cs-parser.jay, expression.cs : CS0214 was missing error location
3703 for constants. Fixed bug #76404.
3705 2005-10-10 Raja R Harinath <rharinath@novell.com>
3707 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3709 (PropertyExpr.EmitCall): Likewise.
3710 * expression.cs (Invocation.EmitArguments): Handle case where
3712 (Invocation.EmitCall): Avoid allocating temporary variable if
3713 there are no arguments.
3715 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3718 * convert.cs (ExplicitConversionCore): Fixed object->enum
3721 2005-10-07 Raja R Harinath <rharinath@novell.com>
3724 * convert.cs (ImplicitConversionStandard): Move conversion of
3725 void* to arbitrary pointer types ...
3726 (ExplicitConversionStandard): .. here.
3727 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3728 error to always print typenames.
3730 2005-10-07 Raja R Harinath <rharinath@novell.com>
3732 * convert.cs (GetConversionOperator): Rename from
3733 GetConversionOperators. Move operator selection code from ...
3734 (UserDefinedConversion): ... here.
3736 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3738 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3741 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3743 * assign.cs (Assign.DoResolve): Error method changed.
3745 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3747 * const.cs (ResolveValue): Reset in_transit immediately.
3749 * constant.cs: Error method changed.
3751 * convert.cs: Removed useless location parameter.
3752 (ExplicitNumericConversion): Don't do double enum check.
3753 (ExplicitConversionCore): Renamed from ExplicitConversion.
3754 (ExplicitUnsafe): Extracted from ExplicitConversion.
3755 (ExplicitConversion): Uses for error reporting.
3757 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3759 (ResolveBoolean): Uses common error method.
3760 (CastToDecimal): Get rid of ec.
3761 (CastFromDecimal): Optimized.
3762 (ConvCast): Get rid of ec.
3764 * enum.cs (ResolveValue): Reset in_transit immediately.
3765 (Emit): Return after first error.
3767 * expression.cs: Convert changes.
3769 * literal.cs: Error method changed.
3771 * statement.cs: Error method changed.
3773 2005-10-06 Raja R Harinath <rharinath@novell.com>
3775 Fix gtest-131.cs and gtest-211.cs.
3776 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3777 Only emit code for a label if it is used. Unreachable code can
3778 violate ECMA evaluation stack invariants.
3780 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3782 * anonymous.cs: Implemented ExprClassName.
3784 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3787 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3790 * class.cs (StaticClass.DefineContainerMembers): Report protected
3793 * codegen.cs: if(ed) PRODUCTION.
3795 * convert.cs (Error_CannotImplicitConversion): Better error
3798 * cs-parser.jay: More error checks.
3800 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3802 * driver.cs (CSCParseOption): Enabled wrong option check.
3804 * ecore.cs (Expression.ExprClassName): Turned to property.
3805 (MemberExpr.CheckIntermediateModification): For checking boxed
3806 value types modification.
3808 * statement.cs (Fixed.Resolve): Expression type must be
3809 convertible to fixed type.
3810 (CollectionForeach.GetEnumeratorFilter,TryType):
3811 Small refactoring for easier error checking.
3813 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3815 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3818 * class.cs (GeneratedBaseInitializer): New class for customization
3819 compiler generated initializers.
3820 (MemberBase.DoDefine): Check Obsolete attribute here.
3821 (FieldMember.DoDefine): Ditto.
3823 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3826 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3827 (MemberCore.GetObsoleteAttribute): Removed argument.
3828 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3829 (MemberCore.CheckObsoleteType): New helper.
3833 * statement.cs: Updates after MemberCore changes.
3835 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3836 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3838 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3839 obsolete attribute for compiler construct.
3840 (As.DoResolve): Cache result.
3842 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3844 2005-10-01 Miguel de Icaza <miguel@novell.com>
3846 * expression.cs (Probe): instead of having a "Type probe_type"
3847 keep the extra information as a TypeExpr probe_type_expr since the
3848 "As" operator needs to perform some type checks.
3850 * (As.DoResolve): If the type is a type parameter, ensure that it
3851 is constrained by a class.
3853 2005-09-22 Miguel de Icaza <miguel@novell.com>
3855 * statement.cs (Lock): Use the TemporaryVariable class instead of
3856 manually using local variables as those do not work when variables
3859 * ecore.cs: Moved the TemporaryVariable class from being a nested
3860 class inside Foreach to be a public class that can be employed in
3863 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3865 * cs-parser.jay: interface_accessors replaced by
3866 accessor_declarations.
3868 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3871 * statement.cs (GotoCase.Resolve): Convert null constant to
3873 (SwitchLabel.ResolveAndReduce): Ditto.
3874 (SwitchLabel.NullStringCase): Custom null stamp.
3875 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3877 typemanager.cs (CSharpSignature): Don't skip first argument
3880 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3882 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3883 expression.cs, iterators.cs, literal.cs: Store constants and
3886 * class.cs (MemberBase.ShortName): Pass location.
3888 * cs-parser.jay: Some location fixes.
3890 * ecore.cs (Expression.Location): Made virtual.
3892 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3895 * const.cs (Const.ResolveValue): Check for assigning non-null
3896 value to reference type.
3898 2005-09-26 Raja R Harinath <rharinath@novell.com>
3901 * expression.cs (This.VerifyFixed): In a value type T, the type of
3902 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3903 value type R, 'this' is treated as a value parameter.
3905 2005-09-05 Miguel de Icaza <miguel@novell.com>
3907 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3908 if the underlying types are the same, otherwise we need to produce
3909 code that will do the proper cast.
3911 This was exposed by Marek's constant rewrite which produced
3912 invalid code for the call site:
3915 void Method (X v) {}
3919 This fixes test-49.cs
3921 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3923 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
3924 Type/Object should be allowed as well. Fixed bug #75968.
3926 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3928 * expression.cs : (Binary.DoResolve): when one is enum constant and
3929 another is constant 0, then return enum one *as enum type*.
3932 2005-10-04 Martin Baulig <martin@ximian.com>
3934 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
3935 `SetMemberIsUsed()' work for generics, too.
3937 2005-10-04 Martin Baulig <martin@ximian.com>
3939 * expression.cs (DelegateInvocation.EmitStatement): Make this work
3940 for corlib. Fixes #75691.
3942 2005-09-28 Marek Safar <marek.safar@seznam.cz>
3945 * driver.cs: Fix compilation files with full root path.
3947 2005-09-25 Miguel de Icaza <miguel@novell.com>
3949 * report.cs (SymbolRelatedToPreviousError): Format the output so
3950 it does not use an open parenthesis that is never closed.
3952 * driver.cs: Follow coding guidelines
3954 2005-09-18 Miguel de Icaza <miguel@novell.com>
3956 * driver.cs: Set InEmacs based on the environment variable EMACS.
3958 * location.cs (InEmacs): in this mode, do not report column
3959 location as it confuses Emacs.
3961 2005-10-03 Raja R Harinath <rharinath@novell.com>
3963 * support.cs (SeekableStreamReader.Position): Don't error out when
3964 the requested position is just beyond the end of the current
3967 2005-09-28 Raja R Harinath <rharinath@novell.com>
3969 * support.cs (SeekableStreamReader): Simplify drastically. Don't
3970 try to keep in sync with the byte count of the underlying Stream.
3971 However, this limits us to a window size of 2048 characters: i.e.,
3972 the maximum lookahead of our lexer/parser can be 2048 characters.
3974 2005-09-22 Martin Baulig <martin@ximian.com>
3976 * driver.cs: Removed a debugging FIXME.
3978 2005-09-21 Raja R Harinath <rharinath@novell.com>
3980 * cs-parser.jay (type_arguments): Add CS1644 check.
3981 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
3983 2005-09-15 Raja R Harinath <rharinath@novell.com>
3985 * Makefile (PROGRAM): Make profile specific.
3986 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
3987 the current directory.
3990 * expression.cs (Invocation.EmitCall): Remove optimization on
3991 this_call since it doesn't handle 'this' being a value type.
3993 2005-09-05 Geoff Norton <gnorton@customerdna.com>
3995 * driver.cs: Ensure file handles are closed after parsing
3997 2005-09-05 Miguel de Icaza <miguel@novell.com>
3999 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
4000 if the underlying types are the same, otherwise we need to produce
4001 code that will do the proper cast.
4003 This was exposed by Marek's constant rewrite which produced
4004 invalid code for the call site:
4007 void Method (X v) {}
4011 This fixes test-49.cs
4013 2005-09-05 Martin Baulig <martin@ximian.com>
4015 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
4016 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
4018 * cs-parser.jay (delegate_declaration): Small fix for #75852.
4020 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
4022 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
4023 to be a pointer type due to the spec 25.2, so check if declaring
4024 type is generic type definition. Fixed bug #75772.
4026 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
4029 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
4030 both types are not defined by methods.
4031 * expression.cs : (Invocation.IsApplicable): it should work when
4032 the argument type is equal to the parameter type, not only when
4033 ImplicitConversionExists() returns true.
4035 2005-09-02 Raja R Harinath <rharinath@novell.com>
4037 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
4041 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
4042 flow-branching for LocalVariableReferences in case we were invoked
4043 from a MemberAccess.
4044 * expression.cs (LocalVariableReference.VerifyAssigned): New.
4046 (LocalVariableReference.DoResolveBase): ... this.
4047 (MemberAccess.Resolve): Do the check that was disabled during
4050 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
4053 (PartialContainer.Create): check abstract/sealed/static strictly
4054 but abstract/sealed can exist only at one side. Fixed bug #75883.
4056 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
4059 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
4060 specified, don't default to UnmanagedType.I4.
4062 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
4064 * expression.cs : conditional operator should check possibly
4065 incorrect assign expression. Fixed bug #75946.
4067 2005-08-30 Raja R Harinath <rharinath@novell.com>
4070 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
4071 (ScopeInfo.EmitScopeType): Use it to construct field names from
4072 names of captured locals.
4075 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
4076 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
4077 Pass 'target_type' to BoxedCast. Don't default to 'object'.
4078 (ExplicitConversion): Remove enum cases already handled by
4079 implicit conversion. Move implicit conversion check to the beginning.
4080 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
4081 * expression.cs (ArrayCreation.EmitDynamicInitializers):
4082 Don't treat System.Enum as a struct.
4084 2005-08-30 Jb Evain <jbevain@gmail.com>
4086 * attribute.cs: handles as expression in parameters.
4088 2005-08-30 Raja R Harinath <rharinath@novell.com>
4091 * class.cs (TypeContainer.VerifyClsName): Don't use a
4092 PartialContainer when verifying CLS compliance.
4093 (AbstractPropertyEventMethod): Set Parent here, ...
4094 (PropertyMethod): ... not here.
4096 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
4098 * attribute.cs : escaped attribute name should not be allowed to be
4099 resolved (e.g. @class as classAttribute). Fixed bug #75930.
4101 2005-08-29 Raja R Harinath <rharinath@novell.com>
4104 * convert.cs (ImplicitStandardConversionExists): Allow zero also
4105 when converting a long constant to unsigned long.
4106 * expression.cs (Invocation.OverloadResolve): Add sanity check to
4107 detect where IsApplicable and VerifyArgumentsCompat disagree.
4109 2005-08-29 Raja R Harinath <rharinath@novell.com>
4110 and Carlos Alberto Cortez <carlos@unixmexico.org>
4113 * class.cs (TypeContainer.CanElideInitializer): New helper.
4114 (TypeContainer.EmitFieldInitializers): Use it to determine if we
4115 can safely emitting the initializer of a field.
4117 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4119 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
4120 allowed inside a switch (without loop). Fixed bug #75433.
4122 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4124 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4125 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4127 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4129 * driver.cs : kinda reverting the default encoding changes (not exact
4130 revert since I noticed that "codepage:reset" might not work fine).
4132 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4134 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
4135 Location. Now getter and setter store location correctly.
4136 (errors/cs0111-12.cs now reports the expected location.)
4138 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4140 * driver.cs : Use default encoding on the environment.
4141 Removed (now that) extra parameter for SeekableStreamReader.
4142 * support.cs : (SeekableStreamReader) third .ctor() argument for
4143 StreamReader is not required (always true). preamble size could
4144 be acquired in simpler and safe way.
4146 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
4148 * cs-parser.jay: report CS0642 at warning level 3
4149 and report CS0642 for an if else statement also
4150 fixes bug #74745. Patch by John Luke (and a bit
4152 Removed extra CS0642 warning check for "while",
4154 * statement.cs: In Block.Resolve(), CS0642 check
4155 is reimplemented to check a sequence of an empty
4156 statement and a block.
4158 Both fix bug #66777.
4160 2005-08-24 Marek Safar <marek.safar@seznam.cz>
4162 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
4163 detection until I fix it.
4165 * cs-tokenizer.cs: Changed error message.
4167 * cs-parser.jay: Fixed 2 error locations.
4169 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
4170 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
4173 * enum.cs (GetSignatureForError): Fixed.
4175 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
4179 * typemanager.cs (RegisterProperty): Removed.
4181 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
4183 2005-08-24 Raja R Harinath <rharinath@novell.com>
4186 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
4187 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
4189 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4191 * expression.cs : tiny fix is required for not warning positive ulong.
4194 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4196 * expression.cs : add CS0652 check for constant and integral
4197 expression. Fixed bug #53974.
4199 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4201 * expression.cs : in DoNumericPromotions(), check if there is implicit
4202 conversion overload for string (to check CS0034). Fixed bug #52492.
4204 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4206 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
4208 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4210 * ecore.cs : report location when it is *not* Null.
4212 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4218 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
4219 correctly. Fixed bug #75721.
4221 2005-08-23 Raja R Harinath <rharinath@novell.com>
4223 * support.cs (SeekableStreamReader.Position): Avoid an expensive
4224 loop that performs 'min (pos, char_count)'.
4227 * expression.cs (Unary.ResolveOperator): Don't discard implicit
4228 converted value in Operator.OnesComplement.
4230 2005-08-22 Ben Maurer <bmaurer@ximian.com>
4232 * anonymous.cs: If the anon method is pulled into a helper class,
4233 it needs to be `internal' not `private'. Fixes runtime behavior on
4236 2005-08-17 Marek Safar <marek.safar@seznam.cz>
4239 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
4242 2005-08-16 Marek Safar <marek.safar@seznam.cz>
4244 The big constants rewrite
4245 Fix #75746, #75685 and more
4246 As a side effect saved 1MB for MWF ;-)
4248 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
4249 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
4250 enum based for corlib compilation.
4252 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
4255 * class.cs (FixedField.Define): Use ResolveAsConstant.
4257 * const.cs (IConstant): Interface constants and enums.
4258 (Const.ResolveValue): New method for constant resolvning.
4259 (ExternalConstant): Constants from imported assemblies.
4261 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
4262 conversion; like enums.
4263 (Constant.ToType): Converts this constant to different type.
4264 (Constant.Increment): Adds 1.
4266 * convert.cs (ImplicitConversionRequired): Simplified.
4268 * cs-parser.jay: Create EnumMember directly.
4270 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
4272 * doc.cs (GenerateEnumDocComment): Removed.
4274 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
4275 (ConvertIntLiteral): Removed.
4276 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
4278 * enum.cs (EnumMember): Implement IConstant.
4279 (Enum.IsValidEnumConstant): Removed.
4280 (Enum.GetNextDefaultValue): Removed.
4281 (Enum.FindMembers): Updated.
4282 (Enum.GenerateDocComment): Iterate enum members.
4284 * expression.cs (Cast.TryReduce): Handle enums correctly.
4285 (New.Constantify): Made public.
4286 (MemberAccess.DoResolve): Removed contant specific if(s).
4288 * literal.cs (NullLiteral): Implement new abstract methods.
4290 * statement.cs (GotoCase.Resolve): Use new constant methods.
4291 (SwitchLabel.ResolveAndReduce): Use new constant methods.
4293 * typemanager.cs (LookupEnum): Removed.
4294 (IsEnumType): Fixed to work with corlib.
4295 (RegisterConstant): Removed.
4296 (LookupConstant): Removed.
4297 (GetConstant): Changed to work with IConstant.
4299 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
4301 * location.cs : Fixed overflown (>255) column number.
4303 2005-08-03 Raja R Harinath <rharinath@novell.com>
4305 First cut of the qualified-alias-member feature.
4306 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
4308 * cs-parser.jay (DOUBLE_COLON): New token.
4309 (namespace_or_type_name): Add rule for recognizing
4310 qualified-alias-members.
4311 (primary_expression): Likewise.
4312 (element_access): Allow QualifiedAliasMember as a possible
4313 type-bearing expression.
4314 (local_variable_type, local_variable_pointer_type): Likewise.
4315 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
4316 aliases in the current and enclosing namespace declarations.
4317 (NamespaceEntry.UsingAlias): Add CS0440 warning.
4318 * decl.cs (MemberName.is_double_colon): New.
4319 (MemberName.MemberName): Add new constructor for alias-member.
4320 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
4321 * expression.cs (QualifiedAliasMember): New expression type.
4323 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4325 * location.cs : it borked when no argument was specified.
4327 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4329 * location.cs : tiny ToString() format fix.
4331 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4333 * statement.cs : oops, it was missing.
4335 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4337 A set of fixes for precise line/column location.
4340 "token" field now holds a file/line "delta", a line number offset
4341 from the segment, and a column number. See also:
4342 http://lists.ximian.com/pipermail/mono-devel-list/2004-
4343 December/009508.html
4344 Removed static IsNull. Use instance IsNull property instead.
4346 For some tokens it stores Location. For Identifier it stores
4347 LocatedToken which is a pair of string name and location.
4348 Column numbers are adjusted only at getChar().
4350 Use Location.ToString() for reporting (it now contains column).
4352 Largely modified to use LocatedToken instead of
4353 string (IDENTIFIER), and to acquire Location from some tokens.
4354 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
4355 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
4357 Now MemberName holds Location. DeclSpace.ctor() receives Location
4358 as a parameter. Removed extra parameters to all derived classes.
4359 Replaced Location.IsNull() with instance property.
4360 * assign.cs, expression.cs :
4361 Added .ctor() overload that omits Location.
4363 Added "nameEscaped" flag that indicates the identifier was escaped
4364 in the source file. This fixes bug #57047.
4366 2005-09-02 Martin Baulig <martin@ximian.com>
4368 * class.cs: Make CS3005 a warning, not an error.
4370 2005-08-02 Marek Safar <marek.safar@seznam.cz>
4372 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
4373 New method, looking for lo-case imported cls type.
4375 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
4378 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
4380 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
4382 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
4384 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
4386 Optimized to save 3.5 MB for SWF compilation.
4388 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4390 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
4391 (PartialContainer.Create): Moved logic AddToContainer.
4392 (PartialContainer.MarkForDuplicationCheck): Shares name.
4394 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
4397 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
4399 (Namespace.GetSignatureForError): New method.
4401 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
4402 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
4404 2005-08-01 Raja R Harinath <rharinath@novell.com>
4407 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
4408 member lookup rather than qualifier_type, since qualifier_type can
4411 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4413 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
4416 2005-07-31 Miguel de Icaza <miguel@novell.com>
4418 * statement.cs: Copy the local exception into the exception
4419 captured local. Fixes 75674
4421 2005-07-31 Raja R Harinath <harinath@gmail.com>
4424 * expression.cs (Invocation.OverloadResolve): Don't report error
4425 CS1501 if error CS1502 has been reported.
4426 (New.DoResolve): Delegate CS1501 reporting to
4427 Invocation.OverloadResolve.
4430 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
4431 invariant-meaning-in-block property in an enclosing block if
4434 2005-07-29 Marek Safar <marek.safar@seznam.cz>
4436 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
4437 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
4438 (Switch.CheckSwitch): Just save 50kb for SWF.
4440 2005-07-27 Martin Baulig <martin@ximian.com>
4442 * anonymous.cs (CaptureContext.AddField): Added
4443 `AnonymousContainer am' argument; compute its toplevel scope if
4444 it's not already computed. Fixes #75649.
4446 2005-07-26 Raja R Harinath <rharinath@novell.com>
4449 * class.cs (Constructor.Emit): Reset block to null if the block
4452 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4454 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
4456 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4458 * class.cs (MethodData.Define): Check whether accessor implementing
4459 interface is public.
4461 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
4463 2005-07-22 Marek Safar <marek.safar@seznam.cz>
4466 * namespace.cs (LookupType): Moved same type check to...
4468 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
4471 2005-07-21 Raja R Harinath <rharinath@novell.com>
4473 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
4474 already found a typebuilder.
4475 * class.cs (MethodCore.IsDuplicateImplementation): Compare
4476 MemberNames, not strings.
4478 * const.cs (Error_ExpressionMustBeConst):
4479 Rename from Error_EpressionMustBeConst.
4480 * const.cs, class.cs, statement.cd: Update.
4482 2005-07-21 Marek Safar <marek.safar@seznam.cz>
4486 * const.cs (Const.LookupConstantValue): Report missing contant expression
4488 (Error_EpressionMustBeConstant): Only one error method.
4490 * class.cs, statement.c: Updated.
4492 2005-07-20 Raja R Harinath <rharinath@novell.com>
4494 * statement.cs (Block.Flags): Add back HasVarargs.
4495 (Block.flags): Make protected.
4496 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
4498 * typemanager.cs (types, typecontainers, user_types): Remove.
4499 (UserTypes, TypeContainers): Likewise.
4500 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
4501 (CleanUp, Reset): Update.
4502 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
4503 (GetNestedType): Use Type.GetNestedType.
4504 (CoreLookupType): Take two arguments, the namespace and the
4505 basename of the type. Update to use the Namespace.Lookup
4507 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
4508 (RealMemberLookup): Use IsNestedChildOf instead of playing with
4509 string concatenation and substring matches.
4510 * class.cs, enum.cs, delegate.cs: Update to changes.
4512 2005-07-20 Marek Safar <marek.safar@seznam.cz>
4514 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
4515 Expression and made virtual.
4517 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
4518 (ImplicitStandardConversionExists): Fixed `byte' typo ?
4520 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
4522 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
4525 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
4528 2005-07-18 Marek Safar <marek.safar@seznam.cz>
4531 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
4532 AssemblyCultureAttribute is not used on executable.
4535 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
4537 2005-07-16 Raja R Harinath <rharinath@novell.com>
4540 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
4541 New. Reports CS0252/CS0253.
4542 Mostly taken from preliminary patch by Duncak Mak.
4543 (Binary.DoResolveOperator): Store results of operator lookup.
4544 Use them to detect if we need to warn about unintended reference
4547 2005-07-15 Raja R Harinath <rharinath@novell.com>
4550 * namespace.cs (Namespace.Lookup): Add back location parameter.
4551 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4552 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4554 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4555 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4556 (Namespace.LookupType): ... this.
4557 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4559 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4560 purported to handle pointers.
4561 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4564 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4566 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4569 2005-07-15 Raja R Harinath <rharinath@novell.com>
4571 * namespace.cs (Namespace.Lookup): Drop location parameter.
4572 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4573 (NamespaceEntry.Lookup): ... this.
4574 (NamespaceEntry.Error_AmbiguousTypeReference):
4575 Move here from DeclSpace.
4576 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4578 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4579 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4580 Move to NamespaceEntry.
4581 * delegate.cs, expression.cs: Update to changes.
4583 2005-08-31 Martin Baulig <martin@ximian.com>
4585 Committing a patch from Atsushi Enomoto for #75850.
4587 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4588 Prefer a generic enumerator over a non-generic one.
4590 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4592 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4593 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4595 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4597 * driver.cs : reverting default encoding change as well as mcs.
4599 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4601 * driver.cs, support.cs : merged r48826.
4603 > could you integrate your mcs changes to gmcs otherwise
4604 > gmcs cannot compile some files.
4606 2005-08-20 Martin Baulig <martin@ximian.com>
4608 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4609 scope if we don't already have it.
4611 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4612 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4615 2005-07-31 Miguel de Icaza <miguel@novell.com>
4617 * statement.cs: Copy the local exception into the exception
4618 captured local. Fixes 75674
4620 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4622 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4625 2005-08-12 Martin Baulig <martin@ximian.com>
4627 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4628 for nested types here to avoid hitting the cache too early.
4630 2005-08-09 Miguel de Icaza <miguel@novell.com>
4632 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4635 2005-08-03 Martin Baulig <martin@ximian.com>
4637 Make iterators in generic methods work; see gtest-191.cs.
4640 (Constraints.Resolve): Protect against being called twice.
4643 (TypeContainer.GetClassBases): Make this `protected virtual'.
4645 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4646 (Iterator.GetClassBases): Override this and compute the base
4648 (Iterator.DefineNestedTypes): If we're a generic method, all our
4649 method type parameters become class type parameters on the proxy
4653 (ToplevelBlock.Parameters): Make this a property, not a field.
4654 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4656 2005-08-03 Martin Baulig <martin@ximian.com>
4658 * typemanager.cs (TypeManager.IsSubclassOf): Use
4659 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4660 (TypeManager.GetFullName_recursed): Improved.
4662 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4665 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4666 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4667 invocation_type == mi.DeclaringType, since the first one also checks
4668 other condition used by generic instances.
4670 2005-07-27 Martin Baulig <martin@ximian.com>
4672 * anonymous.cs (CaptureContext.AddField): Added
4673 `AnonymousContainer am' argument; compute its toplevel scope if
4674 it's not already computed. Fixes #75649.
4676 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4678 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4679 CheckAttributeType and refactored.
4680 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4681 ResolveAsTypeTerminal error handling.
4682 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4684 (GetSignatureForError): Print errors in same way.
4687 * codegen.cs: Reflect attribute GetSignatureForError change.
4690 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4692 * namespace.cs (UsingEntry): Refactored to make fields private.
4695 statement.cs: Error_UnexpectedKind has extra parameter.
4697 2005-07-14 Raja R Harinath <rharinath@novell.com>
4699 * ecore.cs (IAlias): Remove.
4700 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4701 that implement the interface.
4702 * namespace.cs (Namespace): Likewise.
4703 (Namespace.declspaces): Renamed from 'defined_names'.
4704 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4705 DeclSpace instead of an IAlias.
4706 * tree.cs (Tree.AddDecl): Update.
4708 2005-07-12 Raja R Harinath <rharinath@novell.com>
4710 * statement.cs (Block.Flags); Remove HasVarargs.
4711 (Block.HasVarargs): Move to ToplevelBlock.
4712 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4713 (Block.Variables): Make protected. Initialize variable hashtable
4715 (Block.AddVariable): Update.
4716 (Block.Resolve): Update to changes.
4717 (ToplevelBlock.HasVarargs): New boolean.
4718 (ToplevelBlock.ThisVariable): Move here from Block.
4719 (ToplevelBlock.AddThisVariable): Likewise.
4720 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4721 * expression.cs (This.ResolveBase): Update to changes.
4722 (ArglistAccess.DoResolve): Likewise.
4724 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4727 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4729 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4730 not used and not used & assigned.
4731 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4733 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4736 * expression.cs (Is.DoResolve): null is never provided type.
4738 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4741 * cs-parser.jay: Less strict event error rule to catch more errors.
4743 2005-07-11 Martin Baulig <martin@ximian.com>
4745 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4746 for the constructor constraint: we do not only have to check
4747 whether the class has a public constructor, but also ensure that
4748 it's parameterless. Fixes #75492.
4750 2005-07-11 Martin Baulig <martin@ximian.com>
4752 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4753 between type parameters if they either have the reference type
4754 constraint or the class constraint.
4756 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4758 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4760 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4763 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4764 (ExtractSecurityPermissionSet): Cope with self referencing security
4765 attributes properly.
4767 * driver.cs (SetOutputFile): Made public property OutputFile.
4769 2005-07-07 Raja R Harinath <rharinath@novell.com>
4772 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4773 has_nonstatic_fields. Make into a FieldBase pointer.
4774 (TypeContainer.AddField): Add CS0282 check.
4775 (TypeContainer.EmitType): Update.
4777 2005-07-06 Miguel de Icaza <miguel@novell.com>
4779 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4780 compare if they start with __.
4782 2005-07-06 Raja R Harinath <rharinath@novell.com>
4784 * statement.cs (Switch.SwitchGoverningType): Only look at
4785 UserCasts that don't need implicit standard conversions to one of
4786 the allowed switch types (Fixes test-322.cs).
4787 (LocalInfo.Resolve): Re-enable sanity-test.
4789 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4791 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4793 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4795 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4797 2005-07-06 Raja R Harinath <rharinath@novell.com>
4800 * ecore.cs (SimpleName.GetSignatureForError): Add.
4801 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4802 (MemberAccess.GetSignatureForError): Add.
4804 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4806 The big error and warning messages review.
4836 * typemanager.cs: Updated.
4838 * class.cs: (MethodCore.SetYields): Moved here to share.
4839 (PropertyMethod.Define): Moved iterator setup here.
4841 * iterators.cs: Add orig_method to have full access to parent
4844 2005-07-05 Raja R Harinath <rharinath@novell.com>
4846 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4847 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4848 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4849 variable of struct type.
4850 * expression.cs (Unary.ResolveOperator): Update to change.
4851 (Indirection.VerifyFixed): Likewise.
4852 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4853 (ParameterReference.VerifyFixed): Value parameters are fixed.
4854 (This.VerifyFixed): Treat 'this' as a value parameter.
4855 * statement.cs (LocalInfo.IsFixed): Remove.
4857 2005-07-01 Martin Baulig <martin@ximian.com>
4859 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4860 `ec.EmitThis ()' to get the correct scope.
4862 2005-07-01 Martin Baulig <martin@ximian.com>
4864 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4865 instance is a ParameterReference; fixes #75299.
4867 2005-06-30 Raja R Harinath <rharinath@novell.com>
4870 * expression.cs (Indexers.map): Remove.
4871 (Indexers.Append): Filter out inaccessible setters and getters.
4872 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4875 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4877 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4878 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4879 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4880 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4882 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4885 * class.cs (FieldBase.GetInitializerExpression): One more field
4888 2005-06-28 Miguel de Icaza <miguel@novell.com>
4890 * pending.cs: Do not define a proxy if the base method is virtual,
4891 it will be picked up by the runtime (bug 75270).
4893 2005-07-08 Martin Baulig <martin@ximian.com>
4895 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4896 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4898 2005-07-07 Martin Baulig <martin@ximian.com>
4900 * generic.cs (ConstructedType.CheckConstraint): Use
4901 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4902 called recursively; fixes #75329.
4904 2005-07-06 Martin Baulig <martin@ximian.com>
4906 * generic.cs (TypeManager.InferTypeArguments): Added support for
4907 anonymous methods; fixes #75461.
4909 2005-07-01 Martin Baulig <martin@ximian.com>
4911 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4912 `ec.EmitThis ()' to get the correct scope.
4914 2005-07-01 Martin Baulig <martin@ximian.com>
4916 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
4917 instance is `This'; fixes #75299.
4919 2005-06-30 Martin Baulig <martin@ximian.com>
4921 * class.cs (Indexer): Implement IIteratorContainer; added support
4922 for iterators in indexers.
4925 (EmitContext.CurrentIterator): Make this a property, not a field.
4927 * anonymous.cs (AnonymousContainer.Iterator): New public property.
4929 2005-06-28 Miguel de Icaza <miguel@novell.com>
4931 * pending.cs: Do not define a proxy if the base method is virtual,
4932 it will be picked up by the runtime (bug 75270).
4934 2005-06-28 Martin Baulig <martin@ximian.com>
4936 * cs-parser.jay (interface_method_declaration): Avoid a
4937 reduce/reduce conflict by moving some of the code into a separate
4938 `interface_method_declaration_body' rule; fixes #75368.
4940 2005-06-28 Martin Baulig <martin@ximian.com>
4942 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
4943 array check after the check for TypeBuilder's.
4945 2005-06-21 Raja R Harinath <rharinath@novell.com>
4947 * convert.cs (FindMostEncompassedType): Add two trivial special
4948 cases (number_of_types == 0 || number_of_types == 1).
4949 (FindMostEncompasingType): Likewise.
4951 2005-06-17 Raja R Harinath <rharinath@novell.com>
4953 Some cleanups preparing for the fix of #75283.
4954 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
4956 (EventExpr.InstanceResolve): Likewise.
4957 (EventExpr.DoResolve): Remove redundant checks.
4959 2005-06-08 Miguel de Icaza <miguel@novell.com>
4961 * class.cs: Small fix.
4963 2005-06-08 Raja R Harinath <rharinath@novell.com>
4966 * class.cs (GetPartialBases): Fix return value check of
4969 2005-06-07 Raja R Harinath <rharinath@novell.com>
4971 Ensure that partial classes are registered in their enclosing
4972 namespace. Initial part of fix of #75160.
4973 * tree.cs (Tree.RecordDecl): Add new namespace argument.
4974 Register declspace with namespace here, not in
4975 DeclSpace.RecordDecl.
4976 * cs-parser.jay: Pass namespace to RecordDecl.
4977 * class.cs (PartialContainer.Create): Likewise.
4978 (ClassPart.DefineType): New sanity-check. Throws an exception if
4980 * decl.cs (Declspace.RecordDecl): Remove.
4981 * namespace.cs (NamespaceEntry.DefineName): Remove.
4983 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4985 * rootcontext.cs: Reset TargetExt as well.
4987 2005-06-03 Raja R Harinath <rharinath@novell.com>
4989 * ecore.cs (Expression.Resolve): Emit CS0654 error when
4992 2005-06-02 Raja R Harinath <rharinath@novell.com>
4994 Fix #75080, cs0119.cs.
4995 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
4997 (Expression.Resolve): ... this. Use it. Remove bogus code
4998 allowing ExprClass.Type and ExprClass.Namespace for
4999 ResolveFlags.VariableOrValue.
5000 (Expression.Resolve) [1-argument variant]: Change default resolve
5001 flags based on language version.
5002 (Expression.Error_UnexpectedKind): Use a simple string array
5003 rather than an ArrayList.
5004 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
5006 (TypeOfVoid.DoResolve): Likewise.
5007 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
5008 flags argument -- it always has the same value.
5010 2005-05-31 Raja R Harinath <rharinath@novell.com>
5013 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
5014 Use it in the error message.
5015 * assign.cs, expression.cs, statement.cs: Update.
5017 2005-05-30 Raja R Harinath <rharinath@novell.com>
5020 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
5021 the "almostMatchedMember" case too.
5022 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
5023 that failed the accessibility checks to 'almost_match'.
5025 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
5027 * attribute.cs: Use internal MethodBuilder methods to set
5028 ExactSpelling and SetLastError on PInvoke methods, instead
5029 of passing them via charset. Fixes #75060.
5031 2005-05-27 Raja R Harinath <rharinath@novell.com>
5033 * parameter.cs (Parameter): Remove TODO comment.
5034 (Parameter.DefineParameter): Remove Location parameter.
5035 (Parameters.LabelParameters): Likewise.
5036 * class.cs (Constructor.Emit): Update to change.
5037 (MethodData.Emit): Likewise.
5038 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
5039 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
5041 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
5044 Removed Parameters.Location and added Parameter.Location instead.
5045 Removed Location parameter from Emit() and GetSignature().
5052 Modified all related calls.
5054 2005-06-21 Martin Baulig <martin@ximian.com>
5056 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
5057 left-hand side is not a nullable type; fixes #75328.
5059 2005-06-21 Martin Baulig <martin@ximian.com>
5062 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
5063 (TypeManager.GetFullNameSignature): Likewise.
5065 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
5066 `source.FullName' and `target.FullName' to check whether there are
5067 two conflicting definitions.
5069 2005-06-21 Martin Baulig <martin@ximian.com>
5071 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
5072 a BoxedCast - also for reference types - to be compatible with csc.
5074 2005-06-21 Martin Baulig <martin@ximian.com>
5076 * expression.cs (MemberAccess.DoResolve): Add support for nested
5077 types in a generic instance; fixes #75320.
5079 2005-06-20 Martin Baulig <martin@ximian.com>
5081 * generic.cs (TypeManager.InferType): Also walk the class
5082 hierarchy for generic instances; fixes #75261.
5084 2005-06-17 Martin Baulig <martin@ximian.com>
5086 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
5087 to make things work for corlib.
5089 2005-06-15 Martin Baulig <martin@ximian.com>
5091 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
5092 obsolete `SecurityAction' values.
5094 2005-06-06 Marek Safar <marek.safar@seznam.cz>
5096 * rootcontext.cs: Reset TargetExt as well.
5098 2005-06-09 Martin Baulig <martin@ximian.com>
5100 * delegate.cs (Delegate.VerifyMethod): Added
5101 `MethodGroupExpr old_mg' argument; inherit its
5102 `HasTypeParameters'; fix #75085.
5104 2005-06-09 Martin Baulig <martin@ximian.com>
5106 * expression.cs (Invocation.OverloadResolve): Correctly handle
5107 generic methods for the SetMemberIsUsed(); fix #75064.
5109 2005-06-09 Martin Baulig <martin@ximian.com>
5111 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
5114 2005-06-08 Martin Baulig <martin@ximian.com>
5116 * cs-parser.jay (nullable_type_or_conditional): If we put the
5117 nullable back and our `type' is a `ComposedCast', remove the
5118 nullable from it. Fixes #75156.
5120 * expression.cs (ComposedCast.RemoveNullable): New public method.
5122 2005-06-08 Martin Baulig <martin@ximian.com>
5124 The big Iterators rewrite :-)
5126 * iterators.cs: Rewrite this to use the anonymous methods framework.
5128 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
5129 before the TypeContainers; see 2test-21.cs.
5132 (TypeContainer.DefineType): Don't create a new EmitContext if we
5133 already have one (this only happens if we're an Iterator).
5134 (TypeContainer.Define): Also call Define() on all our iterators.
5135 (Method.CreateEmitContext): Added support for iterators.
5138 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
5139 (AnonymousContainer.CreateMethodHost): Moved here from
5140 AnonymousMethod and made abstract.
5141 (AnonymousContainer.CreateScopeType): New abstract method.
5142 (AnonymousContainer.IsIterator): New public property.
5143 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
5144 get the ScopeTypeBuilder rather than manually defining it here.
5145 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
5148 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
5149 before RootContext.DefineTypes().
5151 * codegen.cs (EmitContext.RemapToProxy): Removed.
5152 (EmitContext.CurrentAnonymousMethod): Changed type from
5153 AnonymousMethod -> AnonymousContainer.
5154 (EmitContext.ResolveTopBlock): Protect from being called twice.
5155 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
5156 (EmitContext.EmitThis): Removed the iterators hacks; use the
5157 anonymous methods framework for that.
5160 (ToplevelBlock.Container): Make this a property, not a field.
5161 (ToplevelBlock.ReParent): New public method; move the
5162 ToplevelBlock into a new container.
5163 (Foreach.TemporaryVariable): Simplify.
5165 2005-06-05 Martin Baulig <martin@ximian.com>
5167 * statement.cs (LocalInfo.CompilerGenerated): New flag.
5168 (Block.AddTemporaryVariable): New public method; creates a new
5169 `LocalInfo' for a temporary variable.
5170 (Block.EmitMeta): Create the LocalBuilders for all the temporary
5172 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
5173 non-iterator variables.
5175 2005-06-05 Martin Baulig <martin@ximian.com>
5177 * statement.cs (Foreach.TemporaryVariable): Create the
5178 LocalBuilder in the Emit phase and not in Resolve since in some
5179 situations, we don't have an ILGenerator during Resolve; see
5180 2test-19.cs for an example.
5182 2005-06-04 Martin Baulig <martin@ximian.com>
5184 The big Foreach rewrite - Part II.
5186 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
5187 with `PropertyInfo ienumerator_getcurrent'.
5189 * codegen.cs (VariableStorage): Removed.
5192 (Foreach): Derive from Statement, not ExceptionStatement.
5193 (Foreach.CollectionForeach): New nested class. Moved all the code
5194 dealing with collection foreach here.
5195 (Foreach.ForeachHelperMethods): Removed.
5196 (Foreach.TemporaryVariable): Implement IMemoryLocation.
5198 2005-05-23 Martin Baulig <martin@ximian.com>
5200 * statement.cs (Try.DoResolve): Don't create a `finally' if we
5201 don't need to. Fix #75014.
5203 2005-05-26 Raja R Harinath <rharinath@novell.com>
5205 Improve user-defined conversion handling.
5206 * convert.cs (GetConversionOperators): Rewrite. Return only the
5207 applicable operators.
5208 (AddConversionOperators): New. Helper for GetConversionOperators.
5209 (FindMostEncompassedType, FindMostEncompassingType): Verify that
5210 there is only one most encompassed/encompassing type.
5211 (FindMostSpecificSource, FindMostSpecificTarget): Remove
5212 "applicable operator" handling.
5213 (UserConversion): Move cache here from GetConversionOperators.
5214 Directly cache the chosen operator, rather than the whole
5216 (ExplicitNumericConversion): Fix buggy implementation of Decimal
5217 case. Allow conversion of decimal to sbyte and byte too.
5218 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5219 New static methods. Used to avoid allocating EmptyExpressions in
5222 2005-05-24 Duncan Mak <duncan@novell.com>
5224 * ecore.cs (CastFromDecimal): New class for casting a decimal to
5225 another class, used in Convert.ExplicitNumericConversion.
5226 (CastToDecimal): New class, similar to above, but casts to
5227 System.Decimal, used in Convert.ImplicitNumericConversion and also
5228 in explicit convesion from double/float to decimal.
5230 * convert.cs (ImplicitNumericConversion): Handle implicit
5231 conversions to System.Decimal.
5232 (ExplicitNumericConversion): handle explicit conversions to
5237 2005-05-20 Miguel de Icaza <miguel@novell.com>
5239 * typemanager.cs: Do not throw an exception in the TypeBuilder
5240 case, we take care of it on the TypeCode.
5242 2005-05-17 Marek Safar <marek.safar@seznam.cz>
5244 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
5247 * cs-parser.jay: Catch more lexical errors.
5249 * report.cs: Add one more Error method.
5252 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
5254 2005-05-20 Martin Baulig <martin@ximian.com>
5256 * class.cs (TypeContainer.CircularDepException): Removed.
5257 (TypeContainer.DefineType): Removed the `InTransit' stuff.
5258 (TypeContainer.CheckRecursiveDefinition): Check for circular class
5259 (CS0146) and interface (CS0529) dependencies here.
5261 2005-05-20 Martin Baulig <martin@ximian.com>
5263 * expression.cs (New.DoResolve): Move the CS0712 check above the
5264 CS0144 check; otherwise it can never be reached.
5266 2005-05-20 Martin Baulig <martin@ximian.com>
5268 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
5270 2005-05-20 Martin Baulig <martin@ximian.com>
5272 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
5274 * typemanager.cs (TypeManager.IsAttributeType): New public method.
5276 2005-05-19 Martin Baulig <martin@ximian.com>
5279 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
5280 to disable error reporting.
5282 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
5283 here since we don't want to report an error; see the new test-336.cs.
5285 2005-05-19 Raja R Harinath <rharinath@novell.com>
5287 * statement.cs (ToplevelBlock.GetParameterReference)
5288 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
5289 Move here from class Block.
5290 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
5291 * expression.cs (ParameterReference.DoResolveBase): Likewise.
5293 2005-05-18 Martin Baulig <martin@ximian.com>
5298 (FlowBranching.Reachability): Add non-static public And() and Or()
5300 (FlowBranchingSwitch): New class; do the `break_origins' thing
5301 like in FlowBranchingLoop.
5302 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
5303 reachability, not just locals and parameters.
5304 (FlowBranching.MergeChild): Remove some of the hacks for loop and
5305 switch; MergeBreakOrigins() now takes care of that.
5307 2005-05-18 Martin Baulig <martin@ximian.com>
5309 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
5310 a loop and may leave it, reset the barrier; fixes #74974.
5312 2005-05-16 Raja R Harinath <rharinath@novell.com>
5314 Fix test-382.cs. Emit values of decimal constants.
5315 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
5317 (TypeContainer.AddField): ... this.
5318 (TypeContainer.EmitFieldInitializers): Allow the list of fields
5319 with initializers to include 'Const's.
5320 (ClassPart.RegisterFieldForInitialization): Forward to
5322 * const.cs (Const.Const): Pass initializer to base class.
5323 (Const.Define): In case of decimal constants, register them for
5324 initialization in a static constructor.
5326 2005-05-14 Martin Baulig <martin@ximian.com>
5328 * statement.cs (Block.Resolve): Correctly handle unreachable code;
5329 do not call ResolveUnreachable() on unreachable statements in
5330 here, see the comment in the source code.
5332 2005-05-13 Raja R Harinath <rharinath@novell.com>
5335 * expression.cs (BinaryResolveOperator): If one of the operands of
5336 an equality comparison is 'null' and the other is a pointer type,
5337 convert the null to a NullPointer.
5338 * convert.cs (ImplicitReferenceConversion): If the expression is a
5339 NullLiteral and the target type is a pointer type, return a
5340 NullPointer instead.
5341 (ImplicitConversionStandard): Likewise.
5343 2005-05-13 Marek Safar <marek.safar@seznam.cz>
5345 * cs-parser.jay: Set readonly context based on special constructs.
5347 * expression.cs (LocalVariableReference.DoResolveBase): Improved
5348 readonly variable error handling.
5350 * rootcontext.cs (EmitCode): Don't verify members when error
5353 * statement.cs (LocalInfo): Add reaodnly context information.
5354 (SetReadOnlyContext, GetReadOnlyContext): New methods.
5356 2005-05-17 Martin Baulig <martin@ximian.com>
5358 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
5361 2005-05-13 Martin Baulig <martin@ximian.com>
5363 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
5364 handle unreachable blocks.
5366 2005-05-13 Martin Baulig <martin@ximian.com>
5369 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
5370 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
5373 2005-05-13 Martin Baulig <martin@ximian.com>
5375 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
5376 instance variable, not a local. Fix #74873.
5377 (Block.ResolveUnreachable): Set it to true here.
5379 2005-05-12 Martin Baulig <martin@ximian.com>
5381 * cs-parser.jay (property_declaration): Pass the `current_class',
5382 not the `current_container' to Property's .ctor. Fixes #74912.
5384 2005-05-11 Martin Baulig <martin@ximian.com>
5386 * typemanager.cs (Closure): Copy this from MCS and merge all the
5387 GMCS-specific changes into it.
5389 2005-05-12 Raja R Harinath <harinath@gmail.com>
5392 * typemanager.cs (unmanaged_enclosing_types): New.
5393 (IsUnmanagedType): Avoid infloops by using
5394 'unmanaged_enclosing_types' to talk with recursive invocations.
5396 2005-05-11 Duncan Mak <duncan@novell.com>
5398 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
5399 continuing to process for 'arg'.
5400 (handle_preprocessing_directive): Check the argument of the #endif
5401 directive and report error CS1025 if there are any trailing
5404 According to the C# spec, having even whitespace after the #endif
5405 directive is illegal; however, because we call arg.TrimEnd ()
5406 beforehand, we have the same behavior as csc, allowing whitespace
5407 after the directive.
5411 2005-05-11 Marek Safar <marek.safar@seznam.cz>
5415 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
5416 (Constructor.GetObsoleteAttribute): Implemented correctly.
5418 2005-05-10 Martin Baulig <martin@ximian.com>
5420 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
5421 resolve the type; fixes #74864.
5422 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
5423 in DoResolve(); fixes #74862.
5425 2005-05-10 Martin Baulig <martin@ximian.com>
5427 * support.cs (ReflectionParameters.ParameterModifier): Use
5428 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
5429 and `ParameterAttributes.In'. Fixes #74884.
5431 2005-05-10 Martin Baulig <martin@ximian.com>
5433 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
5434 the cache if we're just looking for `MemberTypes.NestedType' in a
5437 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
5438 constraints if we're still resolving the type tree.
5439 (Expression.MemberLookup): If we're resolving the type tree, only
5440 look for `MemberTypes.NestedType' since we're only interested in
5443 * class.cs (TypeContainer.DefineType): Don't resolve the type
5444 parameters here; do this later in ResolveType() after the type
5445 tree has been resolved.
5446 (TypeContainer.ResolveType): New public method; this is called
5447 after the type tree is resolved and before the types are being
5448 populated. We resolve the generic constraints here.
5449 (TypeContainer.DoDefineMember): Check the constraints on our base
5450 class and interfaces.
5452 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
5453 set the `ResolvingTypeTree' flag on the EmitContext.
5455 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
5457 2005-05-10 Marek Safar <marek.safar@seznam.cz>
5459 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
5461 * expression.cs (Argument.GetParameterModifier): Turned to property.
5462 (Invocation.Error_InvalidArguments): Add more descriptive errors.
5464 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
5467 2005-05-09 Raja R Harinath <rharinath@novell.com>
5470 * decl.cs (MemberCache.AddMethods): Register override methods,
5471 rather than non-override methods.
5472 * typemanager.cs (RegisterOverride): New.
5473 (IsOverride): Update.
5475 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5477 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
5479 2005-05-06 Martin Baulig <martin@ximian.com>
5482 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
5483 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
5485 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5489 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
5490 recursive declaration.
5492 * statement.cs (Block.ResolveMeta): Report any error in resolving.
5494 2005-05-06 Marek Safar <marek.safar@seznam.cz>
5496 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
5498 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
5500 2005-05-05 Raja R Harinath <rharinath@novell.com>
5503 * decl.cs (DeclSpace.FamilyAccessible):
5504 Use TypeManager.IsNestedFamilyAccessible.
5506 Fix reopened #64812.
5507 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
5510 2005-05-04 Raja R Harinath <rharinath@novell.com>
5511 Abin Thomas <projectmonokochi@rediffmail.com>
5512 Anoob V E <projectmonokochi@rediffmail.com>
5513 Harilal P R <projectmonokochi@rediffmail.com>
5516 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
5517 allow access to all static members.
5519 2005-05-04 Martin Baulig <martin@ximian.com>
5521 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
5523 2005-05-04 Martin Baulig <martin@ximian.com>
5527 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
5528 section at the end; make things work if `default' is not the last
5531 2005-05-04 Martin Baulig <martin@ximian.com>
5535 * statement.cs (Switch): Replaced the `got_default' field with a
5536 `default_section' one.
5537 (Switch.CheckSwitch): Set `default_section' here.
5538 (Switch.Resolve): If we're a constant switch and the constant is
5539 not found, use the default section.
5541 2005-05-03 Martin Baulig <martin@ximian.com>
5543 * expression.cs (ArrayAccess.EmitGetLength): New public method.
5545 * statement.cs (Foreach.ArrayForeach): New nested class.
5546 (Foreach.TemporaryVariable): New nested class.
5547 (Foreach.EmitArrayForeach): Removed; this is now in the new
5550 2005-05-03 Raja R Harinath <rharinath@novell.com>
5552 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5554 (VerifyPendingMethods): Revert change below.
5556 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5557 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5558 that used to trigger warning -28. Remove warning -28.
5559 * expression.cs (Invocation.OverloadResolve): Use
5560 TypeManager.IsOverride to distinguish override methods.
5563 * pending.cs (VerifyPendingMethods): If a base type implements the
5564 requested interface, don't bother checking individual methods of
5565 the base type. As a side-effect, this prevents the creation of
5566 unnecessary proxies.
5568 2005-05-02 Martin Baulig <martin@ximian.com>
5572 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5573 Also `And' the locals if the old vector is null.
5574 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5575 null; in this case we basically reset all the variables.
5577 2005-05-02 Martin Baulig <martin@ximian.com>
5581 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5582 Added `FlowBranching branching' argument; always `and' the
5583 variables instead of `or'ing them unless we're an infinite loop.
5585 * statement.cs (While.Resolve): Create a new sibling unless we're
5588 2005-05-02 Martin Baulig <martin@ximian.com>
5592 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5593 arguments; use it instead of creating a new TopLevelBlock.
5594 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5595 our ConstructorInitializer.
5598 (TopLevelBlock.TopLevelBranching): New public property.
5599 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5600 and create our `TopLevelBranching'.
5602 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5603 anonymous method host, use `block.TopLevelBranching' rather than
5604 creating a new branching.
5606 2005-04-20 Miguel de Icaza <miguel@novell.com>
5608 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5609 a ScopeInfo, if any of the current children is a child of the new
5610 entry, move those children there.
5612 2005-04-30 Martin Baulig <martin@ximian.com>
5614 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5615 at the beginning of a SwitchSection. Fix #73335.
5617 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5620 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5622 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5623 (FieldExpr.DoResolve): Obsolete members are ignored for field
5626 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5628 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5629 of arrays detection.
5631 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5633 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5635 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5638 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5640 * cs-parser.jay: Use the prefered version of -unsafe in error
5643 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5645 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5648 2005-04-20 John Luke <john.luke@gmail.com>
5650 * driver.cs: fix typo in error message, --outout to --output
5652 2005-04-30 Martin Baulig <martin@ximian.com>
5654 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5655 handle the .NET 2.x security attributes.
5657 2005-04-30 Martin Baulig <martin@ximian.com>
5660 (TypeManager.ExpandInterfaces): Don't add things twice.
5663 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5665 2005-04-29 Martin Baulig <martin@ximian.com>
5667 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5669 * anonymous.cs: Added support for anonymous generic methods.
5671 2005-04-29 Martin Baulig <martin@ximian.com>
5673 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5676 2005-04-29 Martin Baulig <martin@ximian.com>
5678 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5680 * expression.cs (New.DoResolve): Fix the CS0304 check.
5682 2005-04-29 Martin Baulig <martin@ximian.com>
5684 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5687 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5688 explicit interface implementation, compare the interface types.
5689 (MethodData.Define): Use the new naming scheme from the latest
5691 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5693 * decl.cs (MemberName.GetMemberName): Removed.
5694 (MemberName.MethodName, FullName): New properties.
5696 2005-04-25 Raja R Harinath <rharinath@novell.com>
5698 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5700 2005-04-22 Martin Baulig <martin@ximian.com>
5702 * generic.cs (GenericMethod): Create the EmitContext in the
5703 `Define()'; in `Define(MethodBuilder)', create the type parameters
5704 before calling `Define()'. Fixes #73933.
5706 2005-04-22 Martin Baulig <martin@ximian.com>
5709 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5710 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5712 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5713 ConstructedType, check its constraints.
5715 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5717 * codegen.cs (InRefOutArgumentResolving): New field.
5719 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5720 fields outside contructor.
5722 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5724 2005-04-19 Miguel de Icaza <miguel@novell.com>
5726 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5727 parameter code was not completed ever, so it was not as up-to-date
5728 as local variables. Must finish it.
5730 The bug fix was to compare the Toplevel of the block, not the
5731 current block. Thanks for Ben for pointing this out.
5733 2005-04-19 Raja R Harinath <rharinath@novell.com>
5735 * decl.cs (AddMethods): Use the declaring type of the problem
5736 method to determine if we want to squash a warning.
5738 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5740 * attribute.cs: Removed debug output.
5742 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5744 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5747 2005-04-18 Raja R Harinath <rharinath@novell.com>
5750 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5751 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5752 all null comparisons against reference types.
5754 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5757 * class.cs (TypeContainer.CircularDepException) New nested
5759 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5760 (TypeContainer.DefineType): Removed error, reset InTransit before
5762 (Class.DefineType): Throw exception when is in Transit.
5763 Catch exception and report error.
5764 (Struct.DefineType): Throw exception when is in Transit.
5765 Catch exception and report error.
5766 (Interface.DefineType): Throw exception when is in Transit.
5767 Catch exception and report error.
5769 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5770 handle nested exception handlers.
5772 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5775 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5776 InFinally and InCatch storage.
5778 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5779 (Catch.Resolve): Set and Restore ec.InCatch.
5780 (Try.Resolve): Set and Restore ec.InFinally.
5781 (Try.HasCatch): True when try has catch.
5783 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5785 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5786 for the same event member, so exclude such cases from warning 419.
5789 2005-04-16 Miguel de Icaza <miguel@novell.com>
5791 * expression.cs (Binary.ResolveOperator): Apply patch from John
5792 Luke to fix bug 59864: operators &, | and ^ on enumerations
5793 require that the same enum type on both sides.
5795 * driver.cs: Add warnings to old flag usage, this is to assist
5796 people who produce Makefiles and hope that the Makefiles will be
5799 * class.cs (TypeContainer.EmitType): Moved the definition of the
5800 special $PRIVATE$ field from the resolve phase to the Emit phase.
5801 During resolve we do not know if we are a struct with
5802 HasExplicitLayout, we know this only after the attributes for the
5805 Set the FieldOffset to zero on the dummy field that we create for
5806 the class. Fixes 74590.
5808 2005-04-16 Raja R Harinath <rharinath@novell.com>
5811 * ecore.cs (PropertyExpr.resolved): New.
5812 (DoResolve): Use it to handle a case of double resolution here.
5813 Handle a case of identical-name-and-type-name.
5814 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5815 resolution by storing the results of expression resolution back
5816 into the "probes" array.
5818 2005-04-15 Raja R Harinath <rharinath@novell.com>
5820 Fix cs0208-7.cs and cs0208-8.cs.
5821 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5822 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5823 error reporting to point out the reason a struct is not unmanaged.
5825 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5827 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5828 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5830 2005-04-13 Raja R Harinath <rharinath@novell.com>
5833 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5834 IdenticalNameAndTypeName here.
5835 (EventExpr.InstanceResolve): Likewise.
5837 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5839 C# 2.0 DefaultCharSetAttribute implementation
5841 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5842 which allows us to set GlobalNamespace for every resolve.
5843 (Attribute.ResolveArguments): Cut from Resolve.
5844 (Attribute.GetCharSetValue): Returns CharSet named argument.
5845 (Attribute.DefinePInvokeMethod): Gets default charset from
5847 (GlobalAttribute.ResolveAsTypeStep): Override.
5848 (GlobalAttribute.ResolveArguments): Override.
5850 * class.cs (TypeAttr): Is protected.
5852 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5853 (ModuleClass.DefaultCharSetType): New memeber.
5854 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5856 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5857 charset from module.
5859 * delegate.cs (TypeAttr): Override.
5860 (Delegate.DefineType): Use this TypeAttr.
5862 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5863 at very early stage (before types are defined) to resolve model
5864 module attributes. It will probably not work with corlib but it
5867 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5868 charset from module.
5870 * typemanager.cs (default_charset_type): New type.
5872 2005-04-13 Raja R Harinath <rharinath@novell.com>
5874 * decl.cs (MemberCache.AddMethods): Don't warn if
5875 System.Object.Finalize has buggy MethodAttributes.
5877 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5880 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5882 * doc.cs : detect ambiguous reference to overloaded members.
5883 Fixed bug #71603. MS 1.1 csc does not detect it.
5885 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5887 * doc.cs : delegates must not be referenced with parameters.
5890 2005-04-12 Miguel de Icaza <miguel@novell.com>
5892 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5894 2005-04-10 Miguel de Icaza <miguel@novell.com>
5896 * driver.cs (MainDriver): Stop processing if the CLS stage found
5899 (CompilerCallableEntryPoint.InvokeCompiler): Always
5900 reset after execution; Take a TextWriter argument for the
5903 * report.cs: Use the error stream instead of hardcoding stderr.
5905 2005-04-09 Miguel de Icaza <miguel@novell.com>
5907 * class.cs: Reduce code paths to test, too small of an
5908 optimization to make it worth the extra testing. Always perform
5911 2005-04-08 Raja R Harinath <rharinath@novell.com>
5914 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
5915 operators that had errors reported on them.
5917 2005-04-08 Marek Safar <marek.safar@seznam.cz>
5919 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
5921 (Attribute.Resolve): Add named argument type checking.
5923 * class.cs (FixedField.Define): Use IsPrimitiveType
5925 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
5927 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
5928 unsafe parameter types.
5930 * statement.cs (Using.ResolveExpression): Add better error description.
5932 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
5934 2005-04-08 Raja R Harinath <rharinath@novell.com>
5937 * attribute.cs (Attribute.GetAttributeUsage): Resolve
5938 AttributeUsageAttribute in the emitcontext of the attribute class,
5939 not in the emitcontext of the attributable entity it was attached to.
5940 * cs-parser.jay: Use 'current_class', not 'current_container',
5941 when creating a GlobalAttribute.
5943 2005-04-08 Alp Toker <alp@atoker.com>
5945 * pending.cs: The fix to #58413 failed to compile methods implementing
5946 interfaces with/without params modifiers and vice versa, even though
5947 params modifiers aren't part of the signature. Make the modifier check
5948 less strict as in csc.
5950 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
5951 Anoob V E <projectmonokochi@rediffmail.com>
5952 Harilal P R <projectmonokochi@rediffmail.com>
5955 * pending.cs (TypeAndMethods.mods): New. Store the parameter
5956 modifiers of pending methods.
5957 (PendingImplementation.PendingImplementation): Initialize it.
5958 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
5959 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
5960 with ParameterData. Add check for modifiers.
5961 * class.cs (MethodData.Define): Update to changes.
5963 2005-04-07 Raja R Harinath <rharinath@novell.com>
5965 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
5967 2005-04-07 Marek Safar <marek.safar@seznam.cz>
5969 * class.cs (PropertyMethod.Define): Check private accessor in abstract
5972 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
5975 * typemanager.cs: Registered RequiredAttributeAttribute.
5977 2005-04-06 Marek Safar <marek.safar@seznam.cz>
5979 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
5980 Warning CS0169 is back at level 3.
5981 (IMethodData.SetMemberIsUsed): New method.
5983 * decl.cs (IsUsed): New value; moved from FieldBase.Status
5984 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
5986 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
5988 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
5990 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
5993 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
5996 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
5997 to avoid the problems with nested types.
5999 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
6000 Anoob V.E <projectmonokochi@rediffmail.com>
6001 Harilal P.R <projectmonokochi@rediffmail.com>
6002 Raja R Harinath <rharinath@novell.com>
6005 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
6007 * typemanager (GetConstructor): Make public.
6009 2005-04-05 John Luke <john.luke@gmail.com>
6010 Raja R Harinath <rharinath@novell.com>
6013 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
6014 struct too. Return false quicker in a few cases.
6015 (VerifyUnManaged): Use it.
6017 2005-04-05 Raja R Harinath <rharinath@novell.com>
6020 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
6021 not 'unreachable_seen'.
6023 2005-04-04 Marek Safar <marek.safar@seznam.cz>
6025 * attribute.cs (Attribute.GetValue): Removed unused.
6027 * codegen.cs (CodeGen.TrimExt): Removed unused.
6029 * cs-parser.jay (output): Removed unused.
6031 * cs-tokenizer.cs (hex_digits): Removed unused.
6033 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
6035 * expression.cs (Indirection.LoadExprValue): Removed unused.
6036 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
6038 * iterators.cs (Iterator.param_types): Removed unused.
6040 * statement.cs (Goto.block): Removed unused.
6041 (ToplevelBlock.did): Removed unused.
6042 (Switch.ResolveConstantSwitch): Removed unused.
6044 2005-04-01 Ben Maurer <bmaurer@ximian.com>
6046 * rootcontext.cs: Allow mcs to bootstrap with the compilation
6049 2005-04-19 Martin Baulig <martin@ximian.com>
6051 Merged r42462 from MCS and made it work for GMCS.
6053 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
6055 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
6057 2005-04-01 Raja R Harinath <rharinath@novell.com>
6059 Fix #74232 and cs0208-3.cs.
6060 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
6061 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
6062 unmanaged type. Don't use FieldBuilders when 't' is a
6063 TypeBuilder. Use ModFlags and MemberType fields.
6064 * class.cs (MemberBase.member_type): Rename from MemberType.
6065 (MemberBase.MemberType): New property. Determines member_type on
6067 (MemberBase.DoDefine): Don't initialize MemberType here.
6068 (FieldMember.Define): Likewise.
6070 2005-04-01 Marek Safar <marek.safar@seznam.cz>
6073 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
6074 Attributes are emitted there.
6076 2005-04-01 Raja R Harinath <rharinath@novell.com>
6078 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
6079 keyword in 'partial enum' too.
6080 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
6082 Report from Kamil Skalski <nazgul@omega.pl>.
6085 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
6086 have partial containers too.
6088 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
6089 in block' checks to Block.CheckInvariantMeaningInBlock.
6090 * statement.cs (Block.GetKnownVariableInfo): Make private.
6091 (Block.IsVariableUsedInChildBlock): Remove.
6092 (Block.IsVariableUsedInBlock): Likewise.
6093 (Block.CheckInvariantMeaningInBlock): New. Show location of
6094 conflicting declaration.
6095 (Block.AddVariable): Make error messages less long-winded and more
6096 specific. Show location of conflicting declaration.
6097 * parameter.cs (Parameters.Location): New readonly property.
6099 2005-03-31 Raja R Harinath <rharinath@novell.com>
6101 Clean up semantics of invoking ResolveMemberAccess.
6102 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
6103 can have an instance, ensure that we pass in a non-TypeExpression
6104 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
6105 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
6106 argument. Update to changes and simplify.
6107 (FieldExpr.Emitinstance): Remove CS0120 check.
6108 (PropertyExpr.EmitInstance): Likewise.
6109 * expression.cs (Argument.Resolve): Likewise.
6110 (Invocation.DoResolve): Update to changes in semantics of
6113 2005-03-31 Marek Safar <marek.safar@seznam.cz>
6116 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
6119 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
6121 2005-03-31 Raja R Harinath <rharinath@novell.com>
6123 Fix difference in behaviour with commandline invocation.
6124 * driver.cs (Driver.Reset): New.
6125 (CompilerCallableEntryPoint): Call it.
6127 * statement.cs (If.Resolve): Avoid spurious "uninitialized
6128 variable" warnings if the boolean expression failed to resolve.
6130 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
6132 * attribute.cs: Fix the union of several permissions when some of them
6133 are unrestricted (so the result isn't an unrestricted permission set).
6136 2005-03-30 Raja R Harinath <rharinath@novell.com>
6138 * ecore.cs (MemberExpr): New class. Convert from interface
6140 (MemberExpr.ResolveMemberAccess): Refactor and move here from
6141 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
6143 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
6144 (MethodGroupExpr.IsExplicitImpl): Remove.
6145 (Expression.GetFieldFromEvent): Remove.
6146 (SimpleName.MemberStaticCheck): Remove.
6147 (SimpleName.DoSimpleNameResolve): Update to changes.
6148 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
6149 (MemberAccess.IdenticalNameAndTypeName): Remove.
6150 (MemberAccess.error176): Move to MemberExpr.
6151 (MemberAccess.DoResolve): Update to changes.
6152 (BaseAccess.DoResolve): Likewise.
6154 2005-03-30 Marek Safar <marek.safar@seznam.cz>
6156 C# 2.0 Conditional attribute class implementation
6158 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
6159 Analyzes class whether it has attribute which has ConditionalAttribute
6160 and its condition is not defined.
6162 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
6163 (Class.IsExcluded): New method. Search for at least one defined
6164 condition in ConditionalAttribute of attribute class.
6166 2005-03-30 Raja R Harinath <rharinath@novell.com>
6168 * ecore.cs (PropertyExpr): Derive from Expression, not
6169 ExpressionStatement.
6170 (PropertyExpr.EmitStatement): Remove.
6172 2005-03-29 Raja R Harinath <rharinath@novell.com>
6175 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
6176 internal field "value__" of an enum be private. The examples for
6177 "value__" that I found on MSDN all used FieldAttributes.Private.
6179 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
6180 Don't mention IL method attribute names.
6182 Fix #47991. Remove a TODO.
6183 * statement.cs (Block.Toplevel): Make into a field.
6184 (Block.Parameters): Move into ToplevelBlock.
6185 (Block.known_variables): Rename from child_variable_names.
6186 (Block.Block): Remove variants that take Parameters. Initialize
6187 'Toplevel' with the immediately surrounding toplevel block.
6188 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
6189 LocalInfo parameter.
6190 (Block.GetKnownVariableInfo): New.
6191 (Block.IsVariableNameUsedInChildBlock): Update.
6192 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
6193 the block, even though it may not be in scope.
6194 (Block.AddVariable): Remove Parameters parameter. Use
6195 Toplevel.Parameters instead.
6196 (Block.AddConstant): Remove Parameters parameter.
6197 (Block.GetParameterReference): Update to use Toplevel.Parameters.
6198 (Block.IsParamaterReference): Likewise.
6199 (Block.IsLocalParameter): Likewise. Simplify a lot.
6200 (ToplevelBlock.Parameters): New. Moved from Block.
6201 (ToplevelBlock.ToplevelBlock): Update to changes. Always
6202 initialize Parameters to a non-null value.
6203 * cs-parser.jay: Update to changes.
6204 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
6205 simple names that mean different things in the same block. Use
6206 Block.IsVariableNameUsedInBlock.
6208 2005-03-28 Raja R Harinath <rharinath@novell.com>
6210 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
6212 2005-03-26 Raja R Harinath <harinath@acm.org>
6215 * assign.cs (Assign.DoResolve): When the RHS of an assignment
6216 fails to resolve, ensure that the LHS is still resolved as an
6219 2005-03-25 Raja R Harinath <harinath@acm.org>
6221 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
6223 (Enum.current_ec): Remove.
6224 (Enum.LookupEnumValue): Remove EmitContext argument.
6225 Just uses the one created during DefineType.
6226 (Enum.FindMembers): Update.
6227 * expression.cs (MemberAccess.DoResolve): Update.
6229 2005-03-22 Marek Safar <marek.safar@seznam.cz>
6231 * assign.cs (Assign.DoResolve): Check for CS1717 when
6232 source and target are same (uses Equals).
6234 * expression.cs (LocalVariableReference, ParameterReference,
6235 This): Implemented Equals, GetHashCode.
6237 * statement.cs (Block.GetParameterReference): Removed useless
6240 2005-03-22 Raja R Harinath <rharinath@novell.com>
6243 * statement.cs (Block.AddVariable): Ensure that we skip implicit
6244 blocks before deciding whether the error is cs0136 or cs0128.
6246 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
6247 (using_alias_directive, using_namespace_directive): Pass
6248 MemberName, not an expression to Namespace.UsingAlias and
6250 (MakeName): Use the MemberName of the namespace.
6251 * namespace.cs (Namespace.MemberName): New.
6252 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
6253 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
6255 * decl.cs (MemberName.Name): Make readonly.
6256 (MemberName.FromDotted): New "constructor".
6257 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
6258 (MemberCore.Name): Compute from MemberName on demand.
6259 (MemberCore.SetMemberName): Provide a way to change the
6261 (MemberCore.AddToContainer): Don't take a fullname parameter.
6262 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
6263 fully qualified name of the container to the member name.
6264 (TypeContainer.AddToTypeContainer): Use a fully qualified name
6265 only if the type is a member of the root container.
6266 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
6267 MemberName.Left rather than searching for an embedded ".".
6268 (PartialContainer.CreatePart): Update to changes in RootContext.
6269 (MemberBase.ShortName): Turn into a property. Use
6270 MemberCore.SetMemberName.
6271 (MemberBase.ExplicitInterfaceName): Remove.
6272 (MemberBase.UpdateMemberName): Remove.
6273 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
6274 (PropertyBase.SetMemberName): New override.
6275 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
6276 (Tree.GetDecl): New.
6277 (Tree.AllDecls): Rename from Decls.
6278 * attribute.cs, enum.cs, report.cs: Update to changes.
6279 * driver.cs (MainDriver): Use MemberName.FromDotted on
6280 RootContext.MainClass.
6282 2005-03-21 Marek Safar <marek.safar@seznam.cz>
6284 * class.cs (FixedField.Define): Check for CS1664 and more sanity
6287 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
6289 2005-03-18 Marek Safar <marek.safar@seznam.cz>
6291 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
6292 property accessor modifiers.
6294 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
6295 fixed buffer attribute (CS1716).
6296 (PropertyMethod.HasCustomAccessModifier): When property accessor
6297 has custom modifier.
6299 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
6301 (PropertyExpr.DoResolveLValue): Add CS0272.
6303 2005-03-17 Miguel de Icaza <miguel@novell.com>
6305 * convert.cs: When converting to a pointer, use the proper Conv.U
6306 or Conv.I depending on the source data type.
6308 * cs-tokenizer.cs: Make the size for large decimal constants,
6311 2005-03-17 Martin Baulig <martin@ximian.com>
6313 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6314 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6316 2005-03-17 Martin Baulig <martin@ximian.com>
6318 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6319 to bool so we can return an error condition.
6320 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6323 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
6325 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
6328 2005-03-16 Raja R Harinath <rharinath@novell.com>
6330 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
6331 Refactor to avoid traversing the list of assemblies, and to avoid
6332 string concatenation.
6333 * typemanager.cs (guid_attr_type): Remove.
6334 (negative_hits, pointers, references): Remove hashes.
6336 (GetConstructedType): New. Uses type_hash to handle constructed
6337 types (arrays, references, pointers).
6338 (GetReferenceType, GetPointerType): Use it.
6339 (GetNestedType): New. Uses type_hash to handle nested types of
6341 (LookupType, LookupTypeDirect): Remove.
6342 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
6343 'types' hash and LookupTypeReflection directly.
6344 (params_string, params_object): Use GetConstructedType.
6345 * namespace.cs (Namespace.cached_types): New. Cache of reflected
6347 (Namespace.Lookup): Use cached_types.
6348 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
6349 provided by old TypeManager.LookupType.
6350 * rootcontext.cs (MakeFQN): Remove.
6351 * decl.cs (DeclSpace.MakeFQN): Likewise.
6352 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
6353 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
6354 TypeManager.GetConstructedType.
6355 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
6357 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
6359 * cs-parser.jay: Fix build.
6361 2005-03-15 Marek Safar <marek.safar@seznam.cz>
6363 * class.cs (TypeContainer.CircularDepException) New nested
6364 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
6366 * cs-parser.jay: Reports CS1527 for any namespace element.
6368 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
6371 * expression.cs (ParameterReference.IsAssigned): Changed error to
6373 (Error_WrongNumArguments): Moved CS0245 detection here.
6375 * statement.cs (Return.Resolve): Add CS1622 report.
6377 2005-03-11 Marek Safar <marek.safar@seznam.cz>
6379 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
6381 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
6383 * attribute.cs expression.cs: Get rid of some allocations.
6385 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
6387 * doc.cs : just eliminate the latest change.
6389 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6391 * doc.cs : commented out the latest change. It breaks xml-030.cs
6393 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6395 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
6396 fail. So invoke CreateType() in FindDocumentedType().
6398 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6400 * cs-tokenizer.cs : added IsKeyword().
6401 * doc.cs : Detect keyword incorrectly used as identifier.
6402 Allow identifiers prefixed by @.
6404 2005-03-10 Marek Safar <marek.safar@seznam.cz>
6406 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
6407 It caused exception in namespace resolving (again!).
6409 * class.cs (Class.ctor): Removed exit.
6410 (PropertyMethod.ctor): ditto.
6412 * codegen.cs (Codegen.Reset): Reset static data.
6413 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
6415 * cs-tokenizer.cs (Cleanup): Removed.
6417 * driver.cs (GetSystemDir): Rewrote to one line command.
6418 It caused problem with unloaded dynamic modules.
6419 (UnixParseOption): Removed Exit.
6420 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
6421 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
6422 Now can be mcs used as library.
6424 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
6427 * location.cs (Reset): Reset static data.
6429 * namespace.cs (Reset): Reset static data.
6431 * report.cs (Report.Reset): Reset static data.
6433 * rootcontext.cs (RootContext.Reset): Reset static data.
6435 * tree.cs (RootTypes.ctor): Use Location.Null
6437 * typemanager.cs (TypeManager.Reset): Reset static data.
6438 (CoreLookupType): Removed Exit.
6439 (TypeHandle.Reset): Reset static data.
6441 2005-03-10 Raja R Harinath <rharinath@novell.com>
6444 * typemanager.cs (ComputeNamespaces): Import namespaces from
6445 referenced modules too.
6447 2005-03-09 Raja R Harinath <rharinath@novell.com>
6449 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
6452 2005-03-09 Raja R Harinath <rharinath@novell.com>
6454 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
6455 enclosing DeclSpace. This ensures that a name-lookup populates
6456 more caches and there are fewer 'TypeExpression's. Carve out
6457 nested type lookup into ...
6458 (LookupNestedTypeInHierarchy): ... this.
6460 2005-04-15 Martin Baulig <martin@ximian.com>
6462 Merged r41590 from MCS and make it work in the generics land.
6464 * generic.cs (TypeParameter.UpdateConstraints): Removed the
6467 * class.cs (PartialContainer.UpdateConstraints): Removed.
6468 (PartialContainer.CheckConstraints): Removed.
6469 (PartialContainer.SetParameterInfo): Store the constraints here.
6470 (PartialContainer.DefineTypeParameters): New public method;
6471 resolve the type parameter's constraints here. Note that the
6472 PartialContainer doesn't have an EmitContext anymore, so we must
6473 do this in the ClassPart.
6475 2005-03-09 Raja R Harinath <rharinath@novell.com>
6477 Clean up a few partial-class semantics.
6478 Fixes test-357.cs and cs1618-2.cs.
6479 * cs-parser.jay (struct_declaration): Use 'current_class' as
6480 parent of newly-created struct. Remove call to Register ().
6481 Use 'pop_current_class' to complete handing the current struct.
6482 (interface_declaration): Likewise.
6483 (class_declaration): Likewise.
6484 (enum_declaration): Use 'current_class' as parent of newly created
6486 (delegate_declaration): Likewise.
6487 (pop_current_class): New function. This is used to handle closing
6488 up the 'current_class' and 'current_container', and pointing them
6489 to the enclosing class/container.
6490 (CSharpParser): Initialize 'current_class' too.
6491 * decl.cs (MemberCore): Add check for invariant: a partial
6492 container is not a parsed entity, and thus does not enclose any
6494 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
6495 (DeclSpace.BaseTypeExpr): Use it.
6496 (DeclSpace.LookupType): Add check for invariant.
6497 * class.cs (TypeContainer): Add check for invariant: a nested
6498 class should have the same NamespaceEntry as its enclosing class.
6499 (TypeContainer.EmitFieldInitializers): Make virtual.
6500 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
6502 (TypeContainer.Register): Remove.
6503 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
6504 null. Use TypeResolveEmitContext for resolving base types and
6505 interfaces. Move initialization of Parts.TypeBuilder here from
6507 (TypeContainer.DefineNestedTypes): ... here.
6508 (PartialContainer): Take a Namespace not a NamespaceEntry.
6509 (PartialContainer.Create): Don't use Register. Call the
6510 appropriate Add... function directly.
6511 (ClassPart): Take both the PartialContainer and the enclosing
6512 class as constructor arguments.
6513 (ClassPart.EmitFieldInitializers): Override.
6514 (ClassPart.PartFindNestedTypes): Remove.
6515 (FieldBase.GetInitializerExpression): Resolve the initializer
6516 expression in the emit context of the enclosing class.
6517 * tree.cs (RootTypes): Remove Register ().
6519 2005-03-08 Marek Safar <marek.safar@seznam.cz>
6521 * cs-parser.jay: Removed CS0134.
6523 * driver.cs: Removed CS1901.
6525 * expression.cs (SizeOf.DoResolve): Don't report CS0233
6526 for predefined types.
6528 2005-03-07 Duncan Mak <duncan@novell.com>
6530 * codegen.cs (Save): Catch UnauthorizedAccessException as
6531 well. Fixes bug #73454.
6533 2005-03-07 Marek Safar <marek.safar@seznam.cz>
6535 * cs-tokenizer.cs (xtoken): Add CS1035.
6537 * class.cs (MethodData.Define): Add CS0683.
6538 (FieldMember.ctor): Add CS0681.
6540 2005-03-07 Raja R Harinath <rharinath@novell.com>
6542 * ecore.cs (SimpleName.DoResolve): Rename from
6543 SimpleName.DoResolveAllowStatic.
6544 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
6545 Pass 'intermediate' flag to MemberStaticCheck.
6546 (SimpleName.MemberStaticCheck): Skip "static check" only in case
6547 of "intermediate" lookups via MemberAccess.
6548 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
6549 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6551 2005-03-07 Raja R Harinath <rharinath@novell.com>
6554 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6555 slipped in because of variable names that are identical to a
6556 builtin type's BCL equivalent ('string String;', 'int Int32;').
6557 (PropertyExpr.EmitInstance): Likewise.
6559 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6561 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6563 * report.cs (warning_ignore_table): Made public.
6565 2005-03-04 Raja R Harinath <rharinath@novell.com>
6568 * class.cs (MethodData.Emit): Pass 'container' to
6569 container.GetObsoleteAttribute instead of 'container.Parent'.
6571 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6573 * cs-parser.jay: Add 1534 error test.
6575 * iterators.cs (Yield.CheckContext): Add error 1629.
6576 (Iterator.ctor): Save unsafe modifier.
6577 (MoveNextMethod.DoEmit): Restore unsafe context.
6579 * namespace.cs (UsingAlias): Better error message.
6581 2005-03-03 Dan Winship <danw@novell.com>
6583 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6584 the warning message [#73219]
6586 2005-03-03 Raja R Harinath <rharinath@novell.com>
6588 Fix compile with MCS 1.0.0.0.
6589 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6590 w_restore to not depend on string constant folding.
6592 2005-03-03 Raja R Harinath <rharinath@novell.com>
6594 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6595 CS0246 check to users who passed 'silent = false'.
6596 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6598 (SimpleName.SimpleNameResolve): Update.
6599 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6600 (MemberAccess.IdenticalNameAndTypeName): Update.
6601 * doc.cs (FindDocumentedTypeNonArray): Update.
6603 2005-03-03 Raja R Harinath <rharinath@novell.com>
6605 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6606 * parameters.cs (ComputeAndDefineParameters): Remove.
6607 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6608 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6609 Use GetParameterInfo.
6611 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6613 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6615 2005-03-02 Raja R Harinath <rharinath@novell.com>
6617 Unify DeclSpace.LookupType and DeclSpace.FindType.
6618 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6619 is in charge of defining nested types on demand.
6620 (DeclSpace.LookupType): Use it when the current_type is a
6621 TypeBuilder. Use LookupTypeDirect for reflected types.
6622 (DeclSpace.FindType): Remove.
6623 (DeclSpace.LookupInterfaceOrClass): Likewise.
6624 (DeclSpace.DefineTypeAndParents): Likewise.
6625 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6626 DeclSpace.LookupType.
6627 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6628 * typemanager.cs (LookupType): Simplify.
6629 (AddUserType): Remove type from negative_hits.
6630 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6631 * class.cs (TypeContainer.FindMembers): Move handling of nested
6633 (TypeContainer.FindMembers_NestedTypes): ... here.
6634 (TypeContainer.FindNestedType): Implement override.
6635 (ClassPart.FindNestedType): Delegate to PartialContainer.
6636 (ClassPart.PartFindNestedType): Looks up the nested types of the
6639 2005-04-14 Martin Baulig <martin@ximian.com>
6641 * generic.cs (ConstructedType): Moved all the type lookup and
6642 nested class logic into SimpleName.
6643 (ConstructedType.ResolveConstructedType): Our underlying type is
6644 already fully resolved; all the type lookup stuff is in
6647 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6648 constructed types here instead of in ConstructedType.
6650 * decl.cs (MemberName.GetTypeExpression): Always create a
6651 SimpleName, not a ConstructedType.
6652 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6654 2005-03-02 Martin Baulig <martin@ximian.com>
6656 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6657 static constructor in static classes.
6659 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6661 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6662 sizeParamIndex is not specified.
6664 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6667 * report.cs (WarningMessage.IsEnabled): Missing null check.
6669 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6671 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6672 in the fields and not in the properties.
6674 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6676 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6679 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6681 * attribute.cs: Small refactoring (improved robustness).
6682 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6683 (ValidateGuid): Removed.
6684 (Resolve): Removed referenced to above mentioned.
6685 (GetAttributeUsage): Made private and changed to work without
6687 (GetIndexerAttributeValue): Don't crash.
6688 (GetConditionalAttributeValue): Ditto.
6689 (GetClsCompliantAttributeValue): Ditto.
6690 (ExtractSecurityPermissionSet): All attributes exceptions are
6692 (GetPropertyValue): New helper.
6693 (GetMethodImplOptions): New method.
6694 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6695 some missing properties.
6697 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6698 (Method.ApplyAttributeBuilder): Updated.
6700 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6703 2005-02-28 Raja R Harinath <rharinath@novell.com>
6706 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6707 non-simple types (array, pointer, reference).
6709 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6711 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6713 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6715 (Method.CheckBase): Catch wrong destructor here.
6716 (MethodData.Define): Add errors 550, 668.
6718 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6720 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6722 * pending.cs (VerifyPendingMethods): Add error 551.
6724 * typemanager.cs (CSharpName): Next error report helper.
6726 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6728 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6729 attributes. Removed useless attribute double check.
6730 It saves almost 2MBs for corlib.
6732 2005-02-25 Raja R Harinath <rharinath@novell.com>
6735 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6736 called twice in case of error.
6738 2005-02-23 Chris Toshok <toshok@ximian.com>
6740 Fix compiler portions of #72827.
6741 * statement.cs (Block.Emit): call Begin/EndScope on the
6742 EmitContext instead of the ILGenerator.
6744 * codegen.cs (EmitContext.BeginScope): new method, call
6745 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6747 (EmitContext.BeginScope): same, but EndScope and CloseScope
6749 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6750 offset and call the superclass's OpenScope(int) with it.
6751 (SymbolWriter.CloseScope): get the current il
6752 offset and call superclass's CloseScope(int) with it.
6754 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6756 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6757 CS1677 for out and ref as well.
6759 * class.cs (Method.Define): Add error CS1599 detection.
6761 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6763 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6765 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6767 * support.cs.cs (ModifierDesc): New helper method.
6769 2005-02-23 Raja R Harinath <rharinath@novell.com>
6770 Abin Thomas <projectmonokochi@rediffmail.com>
6771 Anoob V E <projectmonokochi@rediffmail.com>
6772 Harilal P R <projectmonokochi@rediffmail.com>
6775 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6776 MemberLookup (used for error reporting) actually returns a result.
6777 Fix error report number (122, not 112).
6779 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6780 Anoob V E <projectmonokochi@rediffmail.com>
6781 Harilal P R <projectmonokochi@rediffmail.com>
6784 * pending.cs (PendingImplementation.GetAbstractMethods):
6785 Find NonPublic members too.
6787 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6789 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6792 * class.cs (MethodCore.CheckMethodAgainstBase):
6793 Add error 239 report.
6795 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6797 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6799 * class.cs (Operator.Define): Add error 217 report.
6801 2005-02-21 Raja R Harinath <rharinath@novell.com>
6804 * expression.cs (Invocation.IsApplicable): Make public.
6805 (Invocation.IsParamsMethodApplicable): Likewise.
6806 * delegate.cs (Delegate.VerifyApplicability): Don't use
6807 Invocation.VerifyArgumentCompat for parameter applicability
6808 testing. Use Invocation.IsApplicable and
6809 Invocation.IsParamsMethodApplicable.
6811 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6813 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6815 * class.cs (Operator.Define): Add error 217 report.
6817 2005-02-21 Raja R Harinath <rharinath@novell.com>
6819 * namespace.cs (UsingEntry.Resolve): Undo change below.
6821 2005-02-21 Raja R Harinath <rharinath@novell.com>
6824 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6825 disable the error message when the extended MemberLookup also
6827 (Expression.MemberLookupFinal): Update.
6828 (SimpleName.DoSimpleNameResolve): Update.
6829 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6830 Don't use MemberLookupFinal.
6831 (New.DoResolve): Update.
6832 (BaseAccess.CommonResolve): Update.
6834 2005-02-21 Raja R Harinath <rharinath@novell.com>
6837 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6838 occured previously, don't resolve again.
6840 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6843 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6844 argument. Call ResolveAttributeUsage for unresolved.
6845 when types doesn't match ctor arguments.
6847 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6848 for nested attribute classes.
6849 (Class.attribute_usage): Removed.
6850 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6851 for attribute class.
6853 * ecore.cs (IsAttribute): Removed.
6855 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6857 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6859 (attribute_types): Removed.
6860 (EmitCode): Global attributes are emited as the latest.
6862 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6864 * class.cs (EmitFieldInitializers): Don't emit field initializer
6865 for default values when optimilization is on.
6867 * constant.cs (Constant.IsDefaultValue): New property.
6869 * driver.cs: Add /optimize handling.
6873 * literal.cs: Implement new IsDefaultValue property.
6875 * rootcontext.cs (Optimize): New field, holds /optimize option.
6877 2005-02-18 Raja R Harinath <rharinath@novell.com>
6879 Fix crasher in re-opened #72347.
6880 * namespace.cs (Namespace.Lookup): Return null if
6881 DeclSpace.DefineType returns null.
6884 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6886 2005-02-18 Raja R Harinath <rharinath@novell.com>
6888 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6889 now returns null if it cannot resolve to an lvalue.
6890 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6891 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6892 returned null. Remove check for SimpleName.
6893 (EventExpr.DoResolveLValue): New.
6894 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6895 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6897 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6899 (Unary.ResolveOperator): Move CS0211 check ...
6900 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6902 (Unary.DoResolveLValue): Simplify.
6903 (AddressOf.DoResolveLValue): New.
6904 (ArrayAccess.DoResolveLValue): New.
6906 2005-02-16 Marek Safar <marek.safar@seznam.cz>
6908 * attribute.cs (Attribute.Resolve): Add arguments casting for
6909 when types doesn't match ctor arguments.
6911 2005-02-16 Raja R Harinath <rharinath@novell.com>
6913 Fix parts of #63202.
6914 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
6915 lookup of operator in base type. Ensure that all checks happen
6916 when the operator resolves to an "op_..." method.
6918 2005-02-15 Raja R Harinath <rharinath@novell.com>
6921 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
6922 'ignore_cs0104' parameter. Pass it to ...
6923 (NamespaceEntry.Lookup): ... this.
6924 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
6925 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
6926 (TypeLookupExpression.DoResolveAsTypeStep): Update.
6927 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
6928 Update. Request that cs0104 errors be ignored.
6929 (ComposedCast.ResolveAsTypeStep): Update.
6931 2005-02-14 Raja R Harinath <rharinath@novell.com>
6934 * expression.cs (Invocation.BetterFunction): Remove support for
6935 comparing virtual functions and their overrides.
6936 (Invocation.IsOverride): New.
6937 (Invocation.OverloadResolve): Don't consider 'override' functions
6938 during candidate selection. Store them in a lookaside list.
6939 If the selected method is a 'virtual' function, use the list to
6940 find any overrides that are closer to the LHS type.
6942 2005-02-14 Marek Safar <marek.safar@seznam.cz>
6944 * expression.cs (New.DoResolve): Add complex core type reduction.
6945 (New.Constantify): Converts complex core type syntax like 'new int ()'
6948 2005-02-14 Raja R Harinath <rharinath@novell.com>
6950 * decl.cs (EntryType.EntryType): New constructor to create an
6951 updated copy of a cache entry.
6952 (MemberCache.AddMethods): Use it.
6953 (MemberCache.ClearDeclaredOnly): Remove.
6954 (MemberCache.MemberCache): Update.
6956 2005-02-11 Miguel de Icaza <miguel@novell.com>
6958 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
6959 variable. This one is represents the actual low-level declaration
6960 of the method, as opposed to the semantic level `IsStatic'.
6962 An anonymous method which is hosted into a static method might be
6963 actually an instance method. IsStatic would reflect the
6964 container, while MethodIsStatic represents the actual code
6967 * expression.cs (ParameterReference): Use the new MethodIsStatic
6968 instead of IsStatic.
6970 * anonymous.cs (AnonymousMethod.Compatible): Pass the
6971 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
6972 set on the current EmitContext.
6974 * expression.cs (Cast): Overload DoResolveLValue so we can pass
6975 resolve our casted expression as an LValue. This triggers the
6976 proper LValue processing that is later required by Assign.
6980 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
6982 2005-02-11 Marek Safar <marek.safar@seznam.cz>
6984 C# 2.0 Fixed buffer implementation
6986 * anonymous.cs: Update after RegisterHelperClass renaming.
6988 * attribute.cs (AttributeTester.fixed_buffer_cache):
6989 Cache of external fixed buffers.
6990 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
6991 implementation if field is fixed buffer else null.
6994 (TypeContainer.AddField): Accept FieldMember instead of Field.
6995 (FieldBase.IsFieldClsCompliant): Extracted code from
6996 VerifyClsCompliance descendant customization.
6997 (FixedField): New class handles fixed buffer fields.
6998 (FixedFieldExternal): Keeps information about imported fixed
7000 (IFixedField): Make access to internal or external fixed buffer
7003 * cs-parser.jay: Add fixed buffer parsing.
7005 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
7008 * expression.cs (Indirection): Extended implementation to accept
7010 (PointerArithmetic.Emit): Get element from fixed buffer as well.
7011 (ElementAccess.MakePointerAccess): Get type as parameter.
7012 (DoResolve): Add fixed buffer field expression conversion.
7013 (DoResolveLValue): Ditto.
7014 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
7015 (ArrayPtr): Derives from FixedBufferPtr.
7016 (ArrayPtr.Emit): Add extra emit for array elements.
7018 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
7020 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
7021 for compiler generated types.
7022 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
7024 * statement.cs (Fixed): Refactored to be easier add fixed buffer
7025 and consume less memory.
7026 (Fixed.Resolve): Add fixed buffer case.
7028 * typemanager.cs (compiler_generated_attr_ctor,
7029 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
7030 (HasElementType): Add our own implementation to work on every
7033 2005-02-11 Miguel de Icaza <miguel@novell.com>
7035 * anonymous.cs (CaptureContext): Track whether `this' has been
7038 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
7039 only captured `this' if it was implicitly done (instance
7040 methods/variables were used).
7042 * codegen.cs (EmitContext.CaptureThis): New method to flag that
7043 `this' must be captured.
7045 2005-01-30 Miguel de Icaza <miguel@novell.com>
7047 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
7048 is null it means that there has been no need to capture anything,
7049 so we just create a sibling.
7051 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
7053 Just a partial fix. The other half is fairly elusive.
7055 2005-02-10 Raja R Harinath <rharinath@novell.com>
7057 Fix #52586, cs0121-4.cs.
7058 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
7059 and return a hashtable.
7060 (MemberCache.ClearDeclaredOnly): New.
7061 (MemberCache.MemberCache): Update to change. Make a deep copy of
7062 the method_hash of a base type too.
7063 (MemberCache.AddMethods): Adapt to having a deep copy of the base
7064 type methods. Overwrite entries with the same MethodHandle so
7065 that the ReflectedType is correct. The process leaves in base
7066 virtual functions and their overrides as distinct entries.
7067 (CacheEntry): Now a class instead of a struct. It shouldn't alter
7068 matters since it was boxed in a ArrayList before.
7069 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
7071 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
7072 case of a virtual function and its override (choose the overload
7074 (Invocation.OverloadResolve): Avoid 'override' members during
7075 'applicable_type' calculation.
7077 2005-03-28 Raja R Harinath <rharinath@novell.com>
7079 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
7080 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
7081 GetTypeHandle. It is possible for a reflected type to derive from
7082 a TypeBuilder (e.g., int[] derives from the TypeBuilder
7083 System.Array during mscorlib compilation).
7084 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
7085 contain a method_hash, don't create one either. Don't create a
7086 deep copy of the base cache's method_hash.
7087 (MemberCache.SetupCache): Rename back from DeepCopy.
7088 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
7089 already initialized. If we see an override function, add its
7090 underlying base virtual function to the member_hash too.
7092 2005-02-09 Raja R Harinath <rharinath@novell.com>
7094 Combine two near-redundant caches.
7095 * typemanager.cs (method_params): Rename from method_internal_params.
7096 (TypeManager.GetParameterData): New. Replace
7097 Invocation.GetParameterData.
7098 (TypeManager.LookupParametersByBuilder): Remove.
7099 * expression.cs (Invocation.method_parameter_cache): Remove.
7100 (Invocation.GetParameterData): Remove.
7102 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
7105 2005-02-08 Raja R Harinath <rharinath@novell.com>
7108 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
7109 TypeManager.multicast_delegate_type is null, resolve it by looking
7110 up "System.MulticastDelegate".
7111 * rootcontext.cs (RootContext.ResolveCore): Simplify.
7113 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
7114 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
7115 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
7118 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
7119 (LabeledStatement.AddReference): New. Set 'referenced'.
7120 (Goto.Resolve): Use it.
7122 2005-02-05 John Luke <john.luke@gmail.com>
7124 * driver.cs: remove duplicate -doc line in Usage ()
7126 2005-02-04 Raja R Harinath <rharinath@novell.com>
7128 * location.cs (Location.AddFile): Fix CS2002 error report.
7130 2005-02-02 Martin Baulig <martin@ximian.com>
7132 * delegate.cs (Delegate.DefineType): Report an internal error if
7133 TypeManager.multicast_delegate_type is null. See bug #72015 for
7136 2005-02-02 Raja R Harinath <rharinath@novell.com>
7138 Fix a crasher in a variant of #31984.
7139 * const.cs (Constant.CheckBase): New override that defers the
7140 new-or-override check in case the base type hasn't been populated
7142 (Constant.Define): Ensure the new-or-override check is performed.
7144 2005-02-01 Duncan Mak <duncan@ximian.com>
7146 * const.cs (LookupConstantValue): Check that `ce' is not null
7147 before calling GetValue ().
7149 2005-02-01 Raja R Harinath <rharinath@novell.com>
7151 Fix test-334.cs (#69519).
7152 * cs-parser.jay (using_alias_directive): Pass in an expression to
7153 NamespaceEntry.UsingAlias.
7154 (using_namespace_directive): Pass in an expression to
7155 NamespaceEntry.Using.
7156 (namespace_name): Don't flatten to a string.
7157 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
7158 (NamespaceEntry.AliasEntry.Resolve): Lookup using
7160 (NamespaceEntry.UsingEntry): Likewise.
7161 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
7163 (NamespaceEntry.LookupForUsing): Remove.
7164 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
7166 (NamespaceEntry.Lookup): Remove support for dotted names.
7168 2005-02-01 Raja R Harinath <rharinath@novell.com>
7170 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
7172 (NamespaceEntry.ImplicitParent): Compute on demand.
7173 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
7174 parallels the current.
7175 (NamespaceEntry.LookupForUsing): Use it.
7176 (NamespaceEntry.Lookup): If the current namespace-entry is
7177 implicit, don't search aliases and using tables.
7179 2005-02-01 Raja R Harinath <rharinath@novell.com>
7182 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
7184 (TypeContainer.BaseCache): Compute on demand.
7185 (TypeContainer.FindMembers): Define constants and types if they're
7186 not already created.
7187 (FieldMember.Define): Move resetting of ec.InUnsafe before error
7189 * const.cs (Constant.Define): Make idempotent.
7191 2005-01-29 Miguel de Icaza <miguel@novell.com>
7193 * pending.cs: Produce better code (no nops produced by using Ldarg
7196 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7197 i - 1' it should be arg + 1.
7201 2005-01-28 Raja R Harinath <rharinath@novell.com>
7203 * attribute.cs (Attribute.CheckAttributeType): Make private
7205 (Attribute.ResolveType): Make virtual.
7206 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
7207 handling of RootContext.Tree.Types.
7209 2005-01-27 Raja R Harinath <rharinath@novell.com>
7211 Update attribute-handling to use the SimpleName/MemberAccess
7213 * cs-parser.jay (attribute): Pass in an expression to the
7214 constructors of Attribute and GlobalAttribute.
7215 * attribute.cs (Attribute): Take an expression for the name.
7216 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
7217 passed in attribute name expression.
7218 (Attribute.CheckAttributeType): Use it.
7219 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
7220 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
7221 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
7222 argument to prevent error messages if the lookup fails.
7224 2005-01-27 Marek Safar <marek.safar@seznam.cz>
7226 * expression.cs (Indirection): Implemented IVariable interface
7227 to support indirection in AddressOf operator.
7228 (PointerArithmetic.Emit): Add optimalization for case where
7229 result can be precomputed.
7231 2005-01-26 Martin Baulig <martin@ximian.com>
7233 * class.cs (TypeContainer.AttributeTargets): Return the correct
7234 AttributeTargets depending on our `Kind' instead of throwing an
7235 exception; fixes #71632.
7237 2005-01-26 Marek Safar <marek.safar@seznam.cz>
7240 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
7243 2005-03-17 Martin Baulig <martin@ximian.com>
7245 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
7246 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
7248 2005-03-17 Martin Baulig <martin@ximian.com>
7250 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
7251 to bool so we can return an error condition.
7252 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
7255 2005-03-17 Martin Baulig <martin@ximian.com>
7257 * generic.cs (TypeMananager.IsIEnumerable): New public method.
7259 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
7260 converting from an array-type of T to `IEnumerable<T>'.
7262 2005-03-16 Martin Baulig <martin@ximian.com>
7264 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
7265 (Nullable.LiftedUnaryMutator): New public class.
7267 * expression.cs (UnaryMutator.DoResolve): Added support for
7270 2005-03-14 Martin Baulig <martin@ximian.com>
7272 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
7274 2005-03-14 Martin Baulig <martin@ximian.com>
7276 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
7277 the comparision operators `<', `>', `<=' and `>='.
7279 2005-03-13 Martin Baulig <martin@ximian.com>
7282 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
7283 avoid confusion with the `NullLiteral'.
7284 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
7286 2005-03-13 Martin Baulig <martin@ximian.com>
7288 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
7289 comparing arbitrary types with the null literal.
7291 2005-03-13 Martin Baulig <martin@ximian.com>
7293 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
7294 boolean operators '&&', '||', '&' and '|'.
7295 (Nullable.OperatorTrueOrFalse): New public class.
7297 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
7298 instead of a `StaticCallExpr'; added support for nullables.
7300 2005-03-10 Martin Baulig <martin@ximian.com>
7303 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
7304 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
7306 2005-03-07 Martin Baulig <martin@ximian.com>
7308 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
7309 it work if `expr' is not an IMemoryLocation.
7310 (Nullable.Lifted): Implement IMemoryLocation.
7311 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
7314 2005-03-05 Martin Baulig <martin@ximian.com>
7316 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
7317 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
7318 (Nullable): Added support for lifted unary and binary operators.
7320 * expression.cs (Unary.DoResolve): Added support for nullable types.
7321 (Binary.DoResolve): Likewise.
7322 (Conditional.DoResolve): Likewise.
7324 2005-03-02 Martin Baulig <martin@ximian.com>
7326 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
7328 * class.cs (ClassPart.SetParameterInfo): Override this.
7329 (PartialContainer.SetParameterInfo): Override this.
7330 (TypeContainer.CheckConstraints): New protected method.
7331 (PartialContainer.CheckConstraints): Override this and check
7332 whether the same contraints were specified in all parts of a
7333 partial generic type definition.
7334 (PartialContainer.UpdateConstraints): New public method.
7336 * generic.cs (TypeParameter.UpdateConstraints): New public method.
7338 2005-03-02 Martin Baulig <martin@ximian.com>
7340 Committing a patch from Carlos Alberto Cortez to fix #72887.
7342 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
7343 casts from `T []' to `int []'.
7345 2005-03-02 Martin Baulig <martin@ximian.com>
7347 * generic.cs (TypeManager.IsEqual): Make this symmetric.
7349 * expression.cs (Binary.ResolveOperator): When resolving a
7350 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
7351 `=='. Fixes #71866. See gen-127.cs.
7353 2005-03-02 Martin Baulig <martin@ximian.com>
7355 * class.cs (TypeContainer.DoDefineMembers): We also need a default
7356 static constructor in static classes.
7358 2005-03-02 Martin Baulig <martin@ximian.com>
7361 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
7362 (Nullable.LiftedConversion): Added support for user-defined
7365 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
7367 * cs-parser.jay: Use ComposedCast everywhere instead of
7368 NullableType, so we don't need to check for NullableType
7370 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
7371 case where we'll be resolved into a `parenthesized_expression_0'
7375 (Convert.UserDefinedConversion): Added nullable conversions.
7377 2005-02-28 Martin Baulig <martin@ximian.com>
7379 * generic.cs (TypeManager.IsNullableType): New static method.
7380 (Nullable): New abstract class.
7381 (Nullable.NullLiteral): New public class.
7382 (Nullable.LiftedConversion): New public class.
7384 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
7385 `builtin_types opt_nullable'.
7388 (Convert.ImplicitConversionStandard): Added nullable conversions.
7389 (Convert.ExplicitConversionStandard): Likewise.
7390 (Convert.ExplicitConversion): Likewise.
7392 2005-02-26 Martin Baulig <martin@ximian.com>
7394 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
7395 begin with a "?", for instance "?[]". Don't do a type lookup if
7398 2005-02-25 Martin Baulig <martin@ximian.com>
7400 The first part of Nullable Types :-)
7402 * generic.cs (NullableType): New public class.
7403 (NullCoalescingOperator): New public class.
7404 (TypeArguments.Resolve): Add a CS0306 check.
7406 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
7407 (opt_nullable): New rule.
7408 (type): Added `opt_nullable' to `namespace_or_type_name',
7409 `builtin_types' and `pointer_type'.
7410 (array_type): Added `opt_nullable'.
7411 (opt_rank_specifier_or_nullable): New rule; this is the
7412 combination of `opt_rank_specifier' and `opt_nullable'.
7413 (opt_error): New rule; catch errors here.
7414 (nullable_type_or_conditional): New rule; we use this to check for
7415 nullable and still detect the conditional operator.
7416 (local_variable_type): Use `opt_rank_specifier_or_nullable'
7417 instead `opt_rank_specifier'.
7419 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
7422 2005-02-24 Martin Baulig <martin@ximian.com>
7424 * README, README.Changes: Removed; they're old and obsolete.
7426 2005-02-22 Martin Baulig <martin@ximian.com>
7428 * generic.cs (TypeParameter.Resolve): If resolving the constraints
7429 returned an error, set `constraints' to null to avoid a crash
7431 (TypeParameter.ResolveType): Likewise.
7433 2005-02-22 Martin Baulig <martin@ximian.com>
7436 (Constraints.ResolveTypes): Protect against being called twice.
7437 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
7438 (TypeParameter.ResolveType): New public method; calls
7439 constraints.ResolveTypes().
7440 (TypeParameter.DefineType): Moved constraints.ResolveType() out
7441 into the new ResolveType().
7442 (GenericMethod.Define): Call ResolveType() on all our
7445 2005-02-21 Martin Baulig <martin@ximian.com>
7448 (TypeManager.generic_nullable_type): New static public field.
7449 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
7452 (RootContext.ResolveCore): Resolve "System.Nullable`1".
7454 2005-02-15 Martin Baulig <martin@ximian.com>
7456 * generic.cs (ConstructedType.Constraints): Correctly check
7457 constraints if the argument type is a type parameter; fixes
7460 2005-02-02 Martin Baulig <martin@ximian.com>
7462 * delegate.cs (Delegate.DefineType): Report an internal error if
7463 TypeManager.multicast_delegate_type is null. See bug #72015 for
7466 2005-01-29 Miguel de Icaza <miguel@novell.com>
7468 * pending.cs: Produce better code (no nops produced by using Ldarg
7471 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7472 i - 1' it should be arg + 1.
7476 2005-01-26 Martin Baulig <martin@ximian.com>
7478 * cs-parser.jay (indexer_declarator): Don't report an error if we
7479 have type parameters since we can be an explicit interface
7480 implementation; fixes #71449.
7482 2005-01-26 Martin Baulig <martin@ximian.com>
7484 * class.cs (TypeContainer.AttributeTargets): Return the correct
7485 AttributeTargets depending on our `Kind' instead of throwing an
7486 exception; fixes #71632.
7488 2005-01-26 Martin Baulig <martin@ximian.com>
7490 * delegate.cs (Delegate.DefineType): Correctly define our type
7491 parameters. Fixes #71483.
7493 2005-01-25 Raja R Harinath <rharinath@novell.com>
7496 * expression.cs (MemberAccess.DoResolve): Don't complain with
7497 cs0572 when the LHS of a member access has identical name and type
7500 2005-01-25 Marek Safar <marek.safar@seznam.cz>
7503 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
7505 Create custom PermissionSet only for PermissionSetAttribute.
7507 2005-01-24 Marek Safar <marek.safar@seznam.cz>
7510 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
7511 delegates in static class.
7513 2005-01-24 Martin Baulig <martin@ximian.com>
7515 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7516 merging an implicit block, just use its reachability.
7518 * statement.cs (Block.Resolve): Make the unreachable code check
7519 work wrt. implicit blocks; see test-337 from #63842.
7521 2005-01-21 Alp Toker <alp@atoker.com>
7523 * cs-parser.jay: destructor_declaration's container is PartialContainer
7524 not Class when partial types are used, so use Kind prop instead of
7527 2005-01-22 Miguel de Icaza <miguel@ximian.com>
7529 * cs-parser.jay: Improve error reporting when an interface
7532 2005-01-20 Dick Porter <dick@ximian.com>
7534 * support.cs: SeekableStreamReader fix from Sandor Dobos
7535 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
7536 chars are read. Fixes bug 70369.
7538 2005-01-20 Raja R Harinath <rharinath@novell.com>
7540 * cs-parser.jay (catch_clause): Simplify current_block handling
7543 2005-01-17 Miguel de Icaza <miguel@ximian.com>
7545 * convert.cs (ImplicitStandardConversionExists): Synchronize the
7546 code with ImplicitStandardConversion to handle the implicit
7547 conversion of method groups into valid delegate invocations.
7549 The problem is that in parameter handling we were using this code
7550 path. Fixes bug #64698
7552 2005-01-19 Raja R Harinath <rharinath@novell.com>
7554 * cs-parser.jay: Fix several infelicities.
7555 - Avoid assigning to the parser value stack. Code like
7556 '$3 = null' is unclean. Synthesize a value for the code block
7558 - Avoid using oob_stack for storing location information. Use ...
7559 (_mark_): ... this. New (empty) rule. Saves the current location
7561 (foreach_statement): Avoid using oob_stack for current_block
7562 handling. Use technique used in for_statement and
7563 using_statement. Synthesize a value for the code block to store
7564 additional intermediate information.
7566 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7568 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7569 of a different type is only allowed to private fields of a
7570 containing type, not on fields of a base class.
7572 See test-174.cs and error cs0122-9.cs
7574 2005-01-13 Raja R Harinath <rharinath@novell.com>
7576 Fix test-335.cs (bug #58126).
7577 * cs-parser.jay (argument): Split out non-expression parts of the
7578 rule into 'non_simple_argument'.
7579 (invocation_expression): Support parenthesized invocations with
7580 multiple arguments, and with single non-simple arguments.
7582 2005-01-13 Raja R Harinath <rharinath@novell.com>
7584 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7587 2005-01-12 Raja R Harinath <rharinath@novell.com>
7589 Fix cs0038-1.cs, cs1640-6.cs.
7590 * ecore.cs (Expression.Resolve): Remove special-case for
7591 SimpleName in error-handling.
7592 (Expression.almostMatchedMembers): Relax access permission to
7594 (Expression.MemberLookupFailed): Handle duplicates in
7595 almostMatchedMembers list.
7596 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7597 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7598 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7599 overload if the passed in MemberInfo is a MethodBase.
7601 2005-01-25 Martin Baulig <martin@ximian.com>
7604 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7606 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7609 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7610 for non-CAS & merge permission sets properly.
7612 2005-01-11 Raja R Harinath <rharinath@novell.com>
7614 Improve standard-compliance of simple name and member access
7615 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7616 * ecore.cs (FullNamedExpression): New abstract base class
7617 for Namespaces and TypeExpressions.
7618 (ResolveFlags.SimpleName): Remove.
7619 (SimpleName): Remove support for dotted names.
7620 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7621 DeclSpace.FindType and DeclSpace.LookupType.
7622 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7623 (Expression.ExprClassName): Make member function.
7624 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7625 a namespace. Remove creation of dotted "SimpleName"s.
7626 (MemberAccess.DoResolve): Likewise.
7627 * decl.cs (DeclSpace.Cache): Make private.
7628 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7629 (DeclSpace.FindType): Update.
7630 (DeclSpace.LookupType): Move here from RootContext. Return a
7631 FullNamedExpression.
7632 * namespace.cs (Namespace): Derive from FullNamedExpression
7633 so that it can be part of expression resolution.
7634 (Namespace.Lookup): Return an FullNamedExpression.
7635 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7637 * rootcontext.cs (NamespaceLookup): Remove.
7638 (LookupType): Move to DeclSpace.
7639 * attribute.cs (CheckAttributeType): Update.
7640 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7641 (FindDocumentedTypeNonArray): Likewise.
7643 2005-01-11 Raja R Harinath <rharinath@novell.com>
7645 Fix cs0509.cs, cs1632.cs.
7646 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7647 is the same as IsInterface.
7648 (TypeContainer.GetClassBases): Likewise.
7649 * statement.cs (LabeledStatement.ig): New field.
7650 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7652 (LabeledStatement.DoEmit): Check that the label was created with
7653 the same ILGenerator.
7655 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7658 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7659 accessors to its properties.
7661 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7662 from accessors to property.
7664 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7667 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7670 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7672 * attribute.cs: Check for null and empty strings.
7674 I have lost another battle to Paolo.
7676 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7679 * class.cs (PropertyMethod): Set Parent field in ctors.
7680 (SetMethod.InternalParameters): Add unsafe switch hack.
7681 Override MarkForDuplicationCheck where it is appropriate.
7683 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7684 It says whether container allows members with the same name.
7686 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7687 Removed is_method parameter.
7689 2005-01-06 Duncan Mak <duncan@ximian.com>
7691 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7692 because the previous change led to incorrect reporting of CS1032
7693 ("Cannot define/undefine preprocessor symbols after first token in
7694 file"). Instead of using `tokens_seen' as the only flag that
7695 triggers CS1040, introduce `comments_seen'. This new flag is used
7696 to signify having seen comments on the current line, so it is
7697 unset after a newline.
7699 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7701 * doc.cs : When searching for a type, find nested type too.
7702 This fixes bug #71040.
7704 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7707 - Warn missing member comment on those classes which also does not
7708 have doc comments. Fixed bug #71041.
7709 - Don't warn missing doc comment on default constructor.
7712 2005-01-06 Duncan Mak <duncan@ximian.com>
7714 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7715 comments, set `tokens_seen' to true. This allows us to detect
7716 misplaced preprocessor directives (i.e. not at the beginning of
7717 the a line, nor after whitespaces). In that case, report error
7718 CS1040. This fixes bug #56460.
7720 * cs-parser.jay (interface_member_declaration): Add checks for
7721 IsExplicitImpl, and report CS0541 error if an interface member is
7722 defined as an explicit interface declaration.
7724 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7727 * class.cs (PropertyMethod): Set Parent field in ctors.
7728 (SetMethod.InternalParameters): Add unsafe switch hack.
7730 * decl.cs (MemberCore.Parent): Cannot be readonly.
7732 2005-01-06 Raja R Harinath <rharinath@novell.com>
7734 * decl.cs (DeclSpace.ResolveType): Remove.
7735 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7736 Merge in code from ...
7737 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7738 * class.cs, enum.cs: Update to changes.
7740 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7742 * anonymous.cs: Ensure that we init the scope of our parent if it
7743 has not been initialized yet.
7745 2004-12-30 Duncan Mak <duncan@ximian.com>
7747 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7748 if field.FieldBuilder is null. Fixes #70758.
7750 * convert.cs: Fixed some typos and updated some of the comments.
7751 (ImplicitStandardConversionExists):
7752 (TryImplicitIntConversion): If `target_type' is an interface and
7753 the type of `ic' implements this interface, return true or a new
7754 BoxedCast instead of null. This fixes #70468.
7756 2004-12-29 Duncan Mak <duncan@ximian.com>
7758 * expression.cs (Argument.Emit): Check that Expr is
7759 IMemoryLocation before casting to it, and report CS1510 otherwise.
7763 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7765 * statement.cs (Block.ThisVariable): remove the recursion here, to
7766 make the --profile more sane.
7768 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7770 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7771 assembly, by JB Evain.
7773 2004-12-17 Raja R Harinath <rharinath@novell.com>
7775 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7776 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7777 "parent" refers to enclosing type/class. "base" refers to superclass.
7779 2004-12-17 Raja R Harinath <rharinath@novell.com>
7781 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7782 Ensure that we only have GlobalAttributes.
7783 * attribute.cs (Attribute.Emit): Make non-virtual.
7784 (GlobalAttribute.Emit): Remove.
7785 (Attribute.Resolve): Make virtual.
7786 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7787 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7788 the argument. Don't create one.
7789 (Attribute.GetObsoleteAttribute): Likewise.
7790 (Attribute.GetClsCompliantAttributeValue): Likewise.
7791 * class.cs, decl.cs: Update to changes.
7793 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7795 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7797 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7799 * statement.cs (Foreach.Resolve): Add error 186 report.
7801 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7803 * expression.cs (Conditional.DoResolve): Add warning 429.
7805 * statement.cs (If.Resolve): Add warning 665.
7807 2004-12-16 Raja R Harinath <rharinath@novell.com>
7809 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7810 except when in the parser, and in GlobalAttribute.
7811 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7812 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7813 RootContext.Tree.Types.NamespaceEntry once work is done.
7814 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7815 and resets RootContext.Tree.Types.NamespaceEntry.
7817 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7819 * cs-parser.jay: Don't create a block for every variable.
7821 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7823 * location.cs: Provide extra information.
7825 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7826 variables from the captured environment, it is the ldarg_0.
7828 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7830 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7833 * class.cs: Changed warning level for 169 to avoid developer
7834 displeasure from warning flooding. It will be changed back when they
7835 fix most of current BCL warnings.
7837 * RootContext.cs: Pushed default WarningLevel to 3.
7839 * statement.cs: Removed unused variable.
7841 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7843 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7844 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7845 Add error 502 report.
7846 (StaticClass.DefineType): Add error 441 report.
7847 (Class.AllowedModifiersProp): New virtual property as temporary
7848 extension to AllowedModifiers.
7849 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7850 to share implementation with StaticClass and don't call virtual
7853 * driver.cs (MainDriver): Add error 1558 test.
7855 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7856 report. Moved error 36 test here.
7858 * statement.cs (Throw.Resolve): Add error 724 report.
7860 * typemanager.cs: Add out_attribute_type core type.
7862 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7864 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7866 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7868 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7871 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7873 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7874 Add error 3023 report.
7875 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7877 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7880 2004-12-12 John Luke <john.luke@gmail.com>
7882 * driver.cs (AddArgs): take -- into account when
7883 adding arguments, fixes bug 65710
7885 2004-12-12 Martin Baulig <martin@ximian.com>
7887 * expression.cs (Unary.TryReduceNegative): Added support for
7888 SByteConstant and ByteConstant.
7889 (Unary.Reduce): Check error values from TryReduceNegative().
7891 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7893 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7894 and report exception as error 182.
7896 2004-12-10 Raja R Harinath <rharinath@novell.com>
7898 * driver.cs (Main): Fix message when there are warnings.
7900 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7902 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7904 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7906 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
7907 Reduced number of warnings.
7909 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
7911 2004-12-08 Miguel de Icaza <miguel@ximian.com>
7913 * driver.cs: Removed message.
7915 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
7917 2004-12-08 <vargaz@freemail.hu>
7919 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
7921 2004-12-08 Martin Baulig <martin@ximian.com>
7923 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7924 instead of a CS3002 for properties and indexer.
7926 2004-12-08 Martin Baulig <martin@ximian.com>
7928 * decl.cs (MemberName.ToString): Make this work again.
7930 2004-12-08 Marek Safar <marek.safar@seznam.cz>
7932 * attribute.cs (Resolve): Add error 591 detection.
7934 * class.cs (FieldMember.Define): Add error 1547 detection.
7935 (Indexer.Define): Add error 620 detection.
7936 (Operator.Define): Add error 590 detection.
7938 * ecore.cs: Missing argument for error 79.
7940 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
7943 2004-12-07 Marek Safar <marek.safar@seznam.cz>
7946 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
7949 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7951 * cs-parser.jay : handle doc comments on implicit/explicit operators.
7952 Some operator comments were suppressed.
7953 * doc.cs : Implicit/explicit operator name in doc comments are like
7954 "op_Explicit(type)~returnType", so added suffix handling.
7956 2005-01-21 Alp Toker <alp@atoker.com>
7958 * cs-parser.jay: destructor_declaration's container is PartialContainer
7959 not Class when partial types are used, so use Kind prop instead of 'is'.
7961 2004-12-12 Martin Baulig <martin@ximian.com>
7963 * expression.cs (Unary.TryReduceNegative): Added support for
7964 SByteConstant and ByteConstant.
7965 (Unary.Reduce): Check error values from TryReduceNegative().
7967 2004-12-11 Martin Baulig <martin@ximian.com>
7969 * support.cs (ReflectionParameters.ParameterName): If we have a
7970 `gpd', call `ParameterName' on it.
7972 * parameter.cs (Parameter.GetParameterAttributes): New static method.
7974 * pending.cs (PendingImplementation.DefineProxy): Call
7975 DefineParameter() for all of the MethodBuilder's arguments.
7977 2004-12-09 Martin Baulig <martin@ximian.com>
7979 * doc.cs (DocUtil): Make this a static class.
7981 2004-12-09 Martin Baulig <martin@ximian.com>
7983 * expression.cs (Invocation.InferType): Moved the type inference
7984 implementation into TypeManager.
7986 * generics.cs (TypeManager): Moved the type inference
7987 implementation here.
7989 2004-12-09 Martin Baulig <martin@ximian.com>
7991 * typemanager.cs (TypeManager): Make this a partial class.
7994 (TypeManager): Move the generics part of `TypeManager' here.
7996 2004-12-08 Martin Baulig <martin@ximian.com>
7998 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7999 instead of a CS3002 for properties and indexer. Added CS3024
8000 check for generic interfaces.
8002 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
8003 instances are not CLS-compliant.
8005 2004-12-08 Martin Baulig <martin@ximian.com>
8008 (void_pointer_expression): New rule for `void*', `void**' etc.
8009 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
8011 2004-12-08 Martin Baulig <martin@ximian.com>
8013 * expression.cs (Invocation.InferType): Removed the hack for
8014 MethodCore.MayUnify().
8016 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
8019 * class.cs (MethodCore.MayUnify): Use
8020 TypeManager.MayBecomeEqualGenericTypes().
8022 2004-12-08 Martin Baulig <martin@ximian.com>
8024 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
8025 parameter, box it. Fixes #69233.
8027 2004-12-08 Martin Baulig <martin@ximian.com>
8029 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
8030 have the ctor constraint. Fixes #68326.
8032 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
8034 * cs-parser.jay : interface comment was not consumed because of
8035 extra opt_semicolon before doc handling.
8037 2004-12-03 Raja R Harinath <rharinath@novell.com>
8039 Fix test-327.cs, test-328.cs, and put in early infrastructure
8040 for eventually fixing #52697.
8041 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
8042 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
8044 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
8045 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
8046 (VerifyUsing, error246): Update.
8047 * rootcontext.cs (RootContext.NamespaceLookup): Just use
8048 'NamespaceEntry.LookupNamespaceOrType'.
8050 2004-12-07 Martin Baulig <martin@ximian.com>
8052 * driver.cs: Call it "BETA SOFTWARE" :-)
8054 2004-12-06 Raja R Harinath <rharinath@novell.com>
8056 Fix crash on cs0657-17.cs.
8057 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
8058 Use RootContext.Tree.Types, not 'new RootTypes ()'.
8059 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
8060 the case where the NamespaceEntry gets overwritten.
8062 2004-12-06 Marek Safar <marek.safar@seznam.cz>
8064 Fixed #69195, #56821
8065 * ecore.cs (ResolveBoolean): Tiny refactoring.
8067 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
8068 of right expression resolving when left is false constant and
8069 operator is LogicalAnd OR true constant and operator is LogicalOr.
8071 * statement.cs (ResolveUnreachable): Always reports warning.
8073 2004-12-05 Miguel de Icaza <miguel@ximian.com>
8075 * class.cs: Distinguish between 1721 and 1722 (just a little help
8076 for the programmer).
8078 2004-12-03 Miguel de Icaza <miguel@ximian.com>
8080 * delegate.cs: Only allow this on new versions of the language.
8082 2004-12-02 Duncan Mak <duncan@ximian.com>
8084 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
8086 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
8087 here as a static method. Take an additional bool out parameter
8088 `must_do_cs1540_check' for signaling to InstanceResolve.
8089 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
8090 member field from PropertyExpr class and made it an argument of
8092 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
8093 check for MarshalByRefObject, and report CS0122 instead of CS1540.
8094 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
8095 and `remove_accessor' as well as InstanceResolve: report CS0122
8100 2004-12-07 Martin Baulig <martin@ximian.com>
8102 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
8103 and CS0692 where appropriate.
8105 2004-12-06 Martin Baulig <martin@ximian.com>
8107 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
8108 IsDuplicateImplementation() and improved it.
8110 * expression.cs (Invocation.InferTypeArguments): Added
8111 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
8112 and removed the "ref" modifier from `infered_types'.
8114 * decl.cs (MemberName.ToString): Removed the exception.
8116 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
8118 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
8119 comments are allowed.
8121 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8123 * delegate.cs: Add checks for subtypes in paramaters and return values
8124 in VerifyMethod () to add support for Covariance/Contravariance
8127 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8129 * report.cs: Remove extra closing parenthesis.
8131 * convert.cs (Error_CannotImplicitConversion): If the name of the
8132 types are the same, provide some extra information.
8134 2004-12-02 Marek Safar <marek.safar@seznam.cz>
8137 * attribute.cs (Resolve): Improved implementation of params
8138 attribute arguments.
8140 * support.cs (ParameterData): Add HasParams to be faster.
8142 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
8144 all things are for /doc support:
8146 * doc.cs: new file that supports XML documentation generation.
8147 * mcs.exe.sources: added doc.cs.
8149 Handle /doc command line option.
8150 Report error 2006 instead of 5 for missing file name for /doc.
8151 Generate XML documentation when required, after type resolution.
8153 Added support for picking up documentation (/// and /** ... */),
8154 including a new XmlCommentState enumeration.
8156 Added lines to fill Documentation element for field, constant,
8157 property, indexer, method, constructor, destructor, operator, event
8158 and class, struct, interface, delegate, enum.
8159 Added lines to warn incorrect comment.
8161 Added Documentation field (passed only when /doc was specified).
8163 Added DocComment, DocCommentHeader, GenerateDocComment() and
8164 OnGenerateDocComment() and some supporting private members for
8165 /doc feature to MemberCore.
8167 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
8169 Added overriden DocCommentHeader.
8171 Added overriden DocCommentHeader and GenerateDocComment().
8173 2004-12-01 Miguel de Icaza <miguel@ximian.com>
8175 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
8176 unwrapping the enumeration values, chain to
8177 DoConstantNumericPromotions again, so we can promote things to the
8178 fundamental types (takes care of enums that are bytes, sbytes).
8182 2004-12-01 Raja R Harinath <rharinath@novell.com>
8184 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
8185 Fix long-standing bug in type-lookup. Use FindType instead of
8186 LookupType when ec.ResolvingTypeTree.
8187 (Attribute.ResolveType, Attribute.Resolve)
8188 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
8190 (Attributes.Search): Remove internal version. Update.
8191 (Attributes.SearchMulti): Update.
8192 (Attributes.GetClsCompliantAttribute): Remove.
8193 (Attributes.GetIndexerNameAttribute): Remove.
8194 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
8195 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
8196 * class.cs (Indexer.Define): Likewise.
8198 2004-12-01 Marek Safar <marek.safar@seznam.cz>
8201 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
8202 MarshallByReference members access.
8204 * expression.cs: Use CheckMarshallByRefAccess;
8205 Better error CS0197 message.
8207 * report.cs: Print whole related error message.
8209 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8211 * class (GetClassBases): Better error 60 report.
8212 (EventProperty): Disabled warning 67 detection.
8214 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8217 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
8219 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
8222 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8225 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
8227 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
8229 2004-11-26 Miguel de Icaza <miguel@ximian.com>
8231 * attribute.cs (Attribute.Resolve): Refine error reporting and
8232 report a cs0117 if the identifier does not exist, to distinguish
8233 from 0617 which is a miss-use of the actual identifier.
8235 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
8236 between cs0070 and cs0079.
8238 * class.cs (MemberBase.DoDefine): When reporting a wrong
8239 accessibility level, we use MethodCore to compare instead of
8240 Method (this was a regression in some refactoring effort).
8242 So now we correctly report cs0056 again.
8244 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
8245 testing the target_type (which was known to be object_type) and
8246 not the source type (which is anonymous_method).
8248 Fixed reporting of error cs1660.
8250 * expression.cs (UserCast.Source): Expose the underlying cast.
8252 * statement.cs (Switch.SwitchGoverningType): Sort the list of
8253 allowed types to find a match to int32 first (most common).
8255 In addition, it ignores any ImplicitUserConversions that did an
8256 internal implicit conversion (as the switch statement allows only
8257 one integral conversion to exist).
8259 * class.cs (PartialContainer.Create): rename `name' to
8260 `member_name' for clarity. Then replace the string calls with a
8261 call to MemberName.GetPartialName, as now using
8262 MemberName.ToString is an error (this is due to the side effects
8263 it had, that were fixed in the past).
8265 This will restore the error reporting on a number of partial class
8266 errors that were missusing this (and getting an exception as a
8267 results, which is now just a plain textual warning, because
8268 yyparse debug output would crash otherwise).
8270 2004-11-26 Raja R Harinath <rharinath@novell.com>
8272 * Makefile (PROGRAM_INSTALL_DIR): Remove.
8274 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8276 * rootcontext.cs (LookupType): Make sure to cache lookups that
8277 don't give us a negative result. This saves about 5% of corlib
8280 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8282 * report.cs (AbstractMessage.Print): messages are sent to stderr
8284 * class.cs (TypeContainer.GetClassBases): It is an error to have a
8285 non-interface in the list of interfaces (at this point, either
8286 parent was properly set, or a base class is being listed in the
8287 interfaces section).
8289 This flags error 1722, and resolves the crash from bug 69259.
8291 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8293 * statement.cs (Using.EmitExpressionFinally): make this work right
8294 for valuetypes. Fixes 69926.
8296 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8298 * const.cs (Const.ChangeType): Cope with the "0 literal can be
8299 converted to an enum" here, before we try to change the underlying
8300 type. This code exists, but it is a different code path than the
8301 one used while encoding constants.
8303 (ImplicitReferenceConversionExists): In addition, resynchronized
8304 the code here, so it matches the same code in
8305 ImplicitReferenceConversionExists for the `from any class-type S
8306 to any interface-type T'.
8308 2004-11-25 Marek Safar <marek.safar@seznam.cz>
8310 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
8312 2004-11-24 Miguel de Icaza <miguel@ximian.com>
8314 * cs-parser.jay: Use verbosity accordingly.
8316 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8318 * expression.cs (Unary.ResolveOperator): Do not report warning;
8319 AddressOf reads from variable.
8321 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
8323 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8327 * attribute.cs (Attributable): Removed CheckTargets.
8328 (Attributes.Emit): Explicit attribute targets are tested here.
8330 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
8331 not enabled for interfaces.
8333 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
8334 (GetAssemblyName): Ouch next bug there.
8336 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8338 * expression.cs: Error 275 added.
8340 2004-11-23 Marek Safar <marek.safar@seznam.cz>
8342 Fix bug #69177 (Implemented decimal constant support)
8344 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
8345 (BinaryFold): Add DecimalConstant.
8347 * const.cs (Define): Decimal constant
8349 (ChangeType): Add decimal type handling.
8350 (LookupConstantValue): Don't set value for decimal type but
8351 emit DecimalConstantAttribute. Needed for constant optimization.
8353 * constant.cs (ToDecimal): New method.
8354 (ConvertToDecimal): New method.
8355 (IntConstant): Implemented ConvertToDecimal.
8356 (DecimalConstant.Emit): Emit optimized version for decimals in
8359 * expression.cs (ResolveOperator): Changed order of constant
8360 reduction to work correctly with native types which have
8361 overloaded operators.
8362 (ResolveMemberAccess): Extract constant value from attribute
8365 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
8367 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
8368 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
8369 (ChangeType): Decimal is special.
8370 (TypeToCoreType): Add decimal type.
8372 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8374 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
8377 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8379 * class.cs (EventField.ApplyAttributeBuilder): Fix error
8382 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8384 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
8386 * pending.cs (PendingImplementation): Grab only interfaces.
8388 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8390 * statement.cs (ForeachHelperMethods): Add location member and
8391 error 202 detection.
8393 2004-11-18 Marek Safar <marek.safar@seznam.cz>
8395 * expression.cs (DoResolveBase): Fixed wrong warning for out
8398 2004-12-04 Martin Baulig <martin@ximian.com>
8400 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
8401 to check whether the conversion is ok.
8403 * typemanager.cs (TypeManager.GetTypeArguments): Just return
8404 `Type.EmptyTypes' if we're not a generic TypeContainer.
8406 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8408 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
8409 old bug: when converting from the null literal to a pointer,
8410 return an EmptyCast, not the NullLiteral.
8412 This fixes #69921, the recent null_type changes probably made this
8415 2004-12-03 Martin Baulig <martin@ximian.com>
8417 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8418 method as our child, call AnonymousMethod.Compatible() on it.
8420 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8422 * class.cs (FieldBase): Use an unused bit field from the field to
8423 encode the `has_offset' property from the FieldMember. This saves
8424 a couple of Ks on bootstrap compilation.
8426 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8427 method as our child, return the AnonymousMethod resolved
8430 * expression.cs (New.DoResolve): Allow return values from
8431 NewDelegate to also include AnonymousMethods.
8435 2004-11-29 Raja R Harinath <rharinath@novell.com>
8437 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
8439 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
8440 System.Runtime.InteropServices._Exception, since it's a base
8441 interface of the core type System.Exception in the net_2_0 profile.
8443 2004-11-27 Martin Baulig <martin@ximian.com>
8445 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
8447 2004-11-26 Raja R Harinath <rharinath@novell.com>
8449 * Makefile: Convert to use executable.make.
8450 * gmcs.exe.sources: New.
8452 2004-11-25 Martin Baulig <martin@ximian.com>
8454 * expression.cs (Invocation.InferType): Added support for byref types.
8456 2004-11-25 Martin Baulig <martin@ximian.com>
8458 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8459 in TypeManager.TypeToCoreType().
8461 2004-11-25 Martin Baulig <martin@ximian.com>
8463 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
8464 "Dispose" method from the `current_type'.
8465 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
8466 DoDefineMembers() instead of using the MethodBuilder; this is
8467 required for generic iterators.
8469 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
8471 2004-11-24 Martin Baulig <martin@ximian.com>
8473 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
8475 2004-11-20 Martin Baulig <martin@ximian.com>
8477 * expression.cs (Invocation.InferType): Correctly infer generic
8478 instances; see gen-103.cs.
8479 (Invocation.InferTypeArguments): If a generic method doesn't have
8480 any unbound type parameters, we don't need to infer anything.
8482 2004-11-19 Raja R Harinath <rharinath@novell.com>
8484 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
8486 2004-11-17 Raja R Harinath <rharinath@novell.com>
8488 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
8489 (TypeHandle.GetMemberCache): New.
8490 (TypeHandle.TypeHandle): Update.
8491 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
8492 (TypeManager.LookupParentInterfacesCache):
8493 Rename from LookupInterfaceCache. Optimize slightly.
8494 (TypeManager.MemberLookup_FindMembers): Update.
8495 * decl.cs (MemberCache.MemberCache): Set Container to null in the
8497 (AddCacheContents): Rename from AddHashtable.
8498 * class.cs (TypeContainer.parent_container): Remove.
8499 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
8500 (TypeContainer.DoDefineMembers): Don't initialize it.
8501 Update to name changes.
8503 2004-11-17 Miguel de Icaza <miguel@ximian.com>
8505 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
8506 that factors the code to check access modifiers on override.
8508 (PropertyBase): Use the code here.
8510 Patch from Lluis S'anchez, fixes bug #69361.
8512 2004-11-15 Miguel de Icaza <miguel@ximian.com>
8514 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
8515 routine that is used to report the use of a captured variable
8516 whose address has been taken.
8518 There are two checks: one when variables are being captured and
8519 the other check is when the address of a variable is taken.
8521 (because an anonymous methods might be resolved before *or* after
8522 the address has been taken) and
8524 * expression.cs (Conditional.DoResolve): Remove the special
8525 casing that Martin added to trueExpr and falseExpr being both
8526 NullLiteral. We get the right behavior now just by introducing
8527 the null_type into the compiler.
8529 * convert.cs (ExplicitConversion): Change the code to use
8530 null_type instead of testing `expr is NullLiteral'.
8531 (ImplicitConversionStandard): use null_type too.
8532 (ImplicitReferenceConversionExists): use null_type too.
8533 (ImplicitReferenceConversion): use null_type too.
8535 * literal.cs: The type of `NullLiteral' is now null_type instead
8537 (Resolve): Set the type here.
8539 * typemanager.cs: Introduce null_type.
8541 2004-11-18 Martin Baulig <martin@ximian.com>
8544 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
8546 2004-11-18 Martin Baulig <martin@ximian.com>
8548 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
8550 2004-11-18 Martin Baulig <martin@ximian.com>
8552 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8553 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8554 call ResolveConstructedType() on it to resolve it without checking
8556 (Constraints.ResolveTypes): Check them here.
8557 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8558 but don't check constraints.
8559 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8560 check constraints here.
8561 (ConstructedType.ResolveConstructedType): New public method. This
8562 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8563 resolve ourselves without checking constraints.
8565 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8567 2004-11-18 Martin Baulig <martin@ximian.com>
8570 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8572 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8574 2004-11-18 Martin Baulig <martin@ximian.com>
8576 * ecore.cs (TypeExpr.ResolveType): Removed.
8577 (Expression.ResolveAsTypeTerminal): We always return a fully
8578 resolved `TypeExpr', so we can just access its `Type'.
8580 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8582 2004-11-17 Martin Baulig <martin@ximian.com>
8584 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8585 sure we don't return any unresolved TypeExpr's.
8586 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8588 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8590 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8591 unresolved `ConstructedType's.
8593 2004-11-17 Martin Baulig <martin@ximian.com>
8595 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8597 2004-11-17 Martin Baulig <martin@ximian.com>
8600 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8602 * decl.cs (DeclSpace.ResolveType): Removed.
8603 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8605 2004-11-17 Martin Baulig <martin@ximian.com>
8607 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8608 direction, like FindMembers() does. Fixes #69546, testcase is in
8611 2004-11-16 Martin Baulig <martin@ximian.com>
8613 This is based on a patch from Marek Safar, see bug #69082.
8614 Fixes bugs #63705 and #67130.
8616 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8617 method; create a MemberCache for an interface type and cache the
8620 * decl.cs (IMemberContainer.ParentContainer): Removed.
8621 (IMemberContainer.ParentCache): New property.
8622 (MemberCache.SetupCacheForInterface): Removed.
8623 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8624 to create a cache for an interface's "parent".
8626 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8629 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8631 * statement.cs: Avoid adding bools to a hashtable.
8633 2004-11-15 Martin Baulig <martin@ximian.com>
8635 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8637 2004-11-11 Martin Baulig <martin@ximian.com>
8639 * typemanager.cs (TypeManager.GetMethodName): New method.
8641 * class.cs (MethodData.Define): Include the generic arity in the
8642 name of an explicit interface; also add it to the method name.
8644 * pending.cs (PendingImplementation.InterfaceMethod): The method
8645 name now includes the generic arity.
8647 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8649 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8650 calling an unsafe method from a safe location.
8652 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8655 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8657 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8659 * namespace.cs (VerifyUsing): use GetPartialName instead of
8662 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8664 * statement.cs (Return.Resolve): Fix regression in typo: if
8665 `in_exc', we have to request a NeedReturnLabel, this was a typo
8666 introduced in the anonymous method check-in. Fixes #69131.
8668 * Indexers were using the ShortName when defining themselves,
8669 causing a regression in the compiler bootstrap when applying the
8670 patch from 2004-11-02 (first part), now they use their full name
8671 and the bug is gone.
8673 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8675 * driver.cs: Strip the path from the names of embedded resources. Fixes
8678 2004-11-04 Raja R Harinath <rharinath@novell.com>
8680 Fix error message regression: cs0104-2.cs.
8681 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8682 (AliasEntry.Resolve): Update.
8683 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8685 (RootContext.LookupType): Update.
8687 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8689 * cs-parser.jay: Add support for handling accessor modifiers
8690 * class: Add support port accessor modifiers and error checking,
8691 define PropertyMethod.Define as virtual (not abstract anymore)
8692 * ecore.cs: Add checking for proeprties access with access modifiers
8693 * iterators.cs: Modify Accessor constructor call based in the modified
8695 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8697 * expression.cs (StringConcat): Handle being called twice,
8698 as when we have a concat in a field init with more than two
8701 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8703 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8704 special case explicit implementations, we should always produce
8705 the .property or .event declaration.
8707 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8708 since it will not return correct data if people use this
8709 unresolved in the presence of using statements (see test-313).
8711 * class.cs (MethodData.Define): If we are an explicit interface
8712 implementation, set the method name to the full name of the
8713 interface plus the name of the method.
8715 Notice that using the method.MethodName.GetFullName() does not
8716 work, as it will only contain the name as declared on the source
8717 file (it can be a shorthand in the presence of using statements)
8718 and not the fully qualifed type name, for example:
8722 class D : ICloneable {
8723 object ICloneable.Clone () {
8727 Would produce a method called `ICloneable.Clone' instead of
8728 `System.ICloneable.Clone'.
8730 * namespace.cs (Alias.Resolve): Use GetPartialName.
8732 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8734 * cs-parser.jay: Add error 1055 report.
8736 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8738 * assign.cs (Assign.DoResolve): Only do the transform of
8739 assignment into a New if the types are compatible, if not, fall
8740 through and let the implicit code deal with the errors and with
8741 the necessary conversions.
8743 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8745 * cs-parser.jay: Add error 1031 report.
8747 * cs-tokenizer.cs: Add location for error 1038.
8749 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8751 * cs-parser.jay: Add error 1016 report.
8753 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8755 * cs-parser.jay: Add errors 1575,1611 report.
8757 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8759 * cs-parser.jay: Add error 1001 report.
8761 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8764 * attribute.cs (GetMarshal): Add method argument for
8765 caller identification.
8767 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8768 agument for GetMarshal and RuntimeMissingSupport.
8770 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8772 * attribute.cs (ExtractSecurityPermissionSet): Removed
8773 TypeManager.code_access_permission_type.
8775 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8777 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8779 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8780 for obsolete use of a variable here. Fixes regression on errors
8781 cs0619-25 and cs0619-26.
8783 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8785 Fix #62358, implemented security attribute encoding.
8787 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8788 Tests permitted SecurityAction for assembly or other types.
8789 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8790 data from SecurityPermissionAttribute to PermisionSet class.
8792 * class.cs (ApplyAttributeBuilder): Added special handling
8793 for System.Security.Permissions.SecurityAttribute based types.
8795 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8796 special handling for System.Security.Permissions.SecurityAttribute
8799 * enum.cs (ApplyAttributeBuilder): Added special handling
8800 for System.Security.Permissions.SecurityAttribute based types.
8802 * parameter.cs (ApplyAttributeBuilder): Added special handling
8803 for System.Security.Permissions.SecurityAttribute based types.
8805 * rootcontext.cs: Next 2 core types.
8807 * typemanager.cs (TypeManager.security_permission_attr_type):
8808 Built in type for the SecurityPermission Attribute.
8809 (code_access_permission_type): Build in type.
8811 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8813 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8814 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8815 all of this information into
8816 EmitContext.EmitCapturedVariableInstance.
8818 * codegen.cs (EmitCapturedVariableInstance): move here the
8819 funcionality of emitting an ldarg.0 in the presence of a
8820 remapping. This centralizes the instance emit code.
8822 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8823 then emit a load of this: it means that we have reached the
8824 topmost ScopeInfo: the one that contains the pointer to the
8825 instance of the class hosting the anonymous method.
8827 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8828 captures to the topmost CaptureContext.
8830 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8832 * expression.cs (LocalVariableReference): Move the knowledge about
8833 the iterators into codegen's EmitCapturedVariableInstance.
8835 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8837 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8838 all code paths return a value from an anonymous method (it is the
8839 same as the 161 error, but for anonymous methods).
8841 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8843 The introduction of anonymous methods in the compiler changed
8844 various ways of doing things in the compiler. The most
8845 significant one is the hard split between the resolution phase
8846 and the emission phases of the compiler.
8848 For instance, routines that referenced local variables no
8849 longer can safely create temporary variables during the
8850 resolution phase: they must do so from the emission phase,
8851 since the variable might have been "captured", hence access to
8852 it can not be done with the local-variable operations from the runtime.
8856 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8857 is a toplevel block.
8859 (ToplevelBlock): A new kind of Block, these are the blocks that
8860 are created by the parser for all toplevel method bodies. These
8861 include methods, accessors and anonymous methods.
8863 These contain some extra information not found in regular blocks:
8864 A pointer to an optional CaptureContext (for tracking captured
8865 local variables and parameters). A pointer to the parent
8868 (Return.Resolve): Catch missmatches when returning a value from an
8869 anonymous method (error 1662).
8870 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8873 (Break.Resolve): ditto.
8875 (SwitchLabel): instead of defining the labels during the
8876 resolution phase, we now turned the public ILLabel and ILLabelCode
8877 labels into methods called GetILLabelCode() and GetILLabel() that
8878 only define the label during the Emit phase.
8880 (GotoCase): Track the SwitchLabel instead of the computed label
8881 (its contained therein). Emit the code by using
8882 SwitchLabel.GetILLabelCode ().
8884 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8885 whether the Local has been captured or not.
8887 (LocalInfo.IsCaptured): New property, used to tell whether the
8888 local has been captured.
8890 * anonymous.cs: Vastly updated to contain the anonymous method
8893 The main classes here are: CaptureContext which tracks any
8894 captured information for a toplevel block and ScopeInfo used to
8895 track the activation frames for various local variables.
8897 Each toplevel block has an optional capture context associated
8898 with it. When a method contains an anonymous method both the
8899 toplevel method and the anonymous method will create a capture
8900 context. When variables or parameters are captured, they are
8901 recorded on the CaptureContext that owns them, for example:
8905 MyDelegate d = delegate {
8910 Here `a' will be recorded as captured on the toplevel
8911 CapturedContext, the inner captured context will not have anything
8912 (it will only have data if local variables or parameters from it
8913 are captured in a nested anonymous method.
8915 The ScopeInfo is used to track the activation frames for local
8916 variables, for example:
8918 for (int i = 0; i < 10; i++)
8919 for (int j = 0; j < 10; j++){
8920 MyDelegate d = delegate {
8925 At runtime this captures a single captured variable `i', but it
8926 captures 10 different versions of the variable `j'. The variable
8927 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
8928 recorded on a child.
8930 The toplevel ScopeInfo will also track information like the `this'
8931 pointer if instance variables were referenced (this is necessary
8932 as the anonymous method lives inside a nested class in the host
8933 type of the method).
8935 (AnonymousMethod): Expanded to track the Toplevel, implement
8936 `AnonymousMethod.Compatible' to tell whether an anonymous method
8937 can be converted to a target delegate type.
8939 The routine now also produces the anonymous method content
8941 (AnonymousDelegate): A helper class that derives from
8942 DelegateCreation, this is used to generate the code necessary to
8943 produce the delegate for the anonymous method that was created.
8945 * assign.cs: API adjustments for new changes in
8946 Convert.ImplicitStandardConversionExists.
8948 * class.cs: Adjustments to cope with the fact that now toplevel
8949 blocks are of type `ToplevelBlock'.
8951 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
8952 insteda of standard blocks.
8954 Flag errors if params arguments are passed to anonymous methods.
8956 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
8957 `CurrentAnonymousMethod' which points to the current Anonymous
8958 Method. The variable points to the AnonymousMethod class that
8959 holds the code being compiled. It is set in the new EmitContext
8960 created for the anonymous method.
8962 (EmitContext.Phase): Introduce a variable and an enumeration to
8963 assist in enforcing some rules about when and where we are allowed
8964 to invoke certain methods (EmitContext.NeedsReturnLabel is the
8965 only one that enfonces this right now).
8967 (EmitContext.HaveCaptureInfo): new helper method that returns
8968 whether we have a CapturedContext initialized.
8970 (EmitContext.CaptureVariable): New method used to register that a
8971 LocalInfo must be flagged for capturing.
8973 (EmitContext.CapturedParameter): New method used to register that a
8974 parameters must be flagged for capturing.
8976 (EmitContext.CapturedField): New method used to register that a
8977 field must be flagged for capturing.
8979 (EmitContext.HaveCapturedVariables,
8980 EmitContext.HaveCapturedFields): Return whether there are captured
8981 variables or fields.
8983 (EmitContext.EmitMethodHostInstance): This is used to emit the
8984 instance for the anonymous method. The instance might be null
8985 (static methods), this (for anonymous methods that capture nothing
8986 and happen to live side-by-side with the current method body) or a
8987 more complicated expression if the method has a CaptureContext.
8989 (EmitContext.EmitTopBlock): Routine that drives the emission of
8990 code: it will first resolve the top block, then emit any metadata
8991 and then emit the code. The split is done so that we can extract
8992 any anonymous methods and flag any captured variables/parameters.
8994 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
8995 during this phase, the ILGenerator should not be used as labels
8996 and local variables declared here might not be accessible to any
8997 code that is part of an anonymous method.
8999 Exceptions to this include the temporary variables that are
9000 created by some statements internally for holding temporary
9003 (EmitContext.EmitMeta): New routine, in charge of emitting all the
9006 (EmitContext.TemporaryReturn): This method is typically called
9007 from the Emit phase, and its the only place where we allow the
9008 ReturnLabel to be defined other than the EmitMeta. The reason is
9009 that otherwise we would have to duplicate a lot of logic in the
9010 Resolve phases of various methods that today is on the Emit
9013 (EmitContext.NeedReturnLabel): This no longer creates the label,
9014 as the ILGenerator is not valid during the resolve phase.
9016 (EmitContext.EmitThis): Extended the knowledge in this class to
9017 work in anonymous methods in addition to iterators.
9019 (EmitContext.EmitCapturedVariableInstance): This emits whatever
9020 code is necessary on the stack to access the instance to a local
9021 variable (the variable will be accessed as a field).
9023 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
9024 EmitContext.EmitAddressOfParameter): Routines to support
9025 parameters (not completed at this point).
9027 Removals: Removed RemapLocal and RemapLocalLValue. We probably
9028 will also remove the parameters.
9030 * convert.cs (Convert): Define a `ConstantEC' which points to a
9031 null. This is just to prefity some code that uses
9032 ImplicitStandardConversion code and do not have an EmitContext
9035 The idea is to flag explicitly that at that point in time, it is
9036 known that the conversion will not trigger the delegate checking
9037 code in implicit conversions (which requires a valid
9040 Everywhere: pass new EmitContext parameter since
9041 ImplicitStandardConversionExists now requires it to check for
9042 anonymous method conversions.
9044 (Convert.ImplicitStandardConversionExists): If the type of an
9045 expression is the anonymous_method_type, and the type is a
9046 delegate, we invoke the AnonymousMethod.Compatible method to check
9047 whether an implicit conversion is possible.
9049 (Convert.ImplicitConversionStandard): Only do implicit method
9050 group conversions if the language level is not ISO_1.
9052 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
9053 MethodInfo for the Invoke method. used by Delegate and
9056 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
9057 method conversions if the target type is a delegate.
9059 Removed extra debugging nops.
9061 (LocalVariableReference): Turn the `local_info' into a public
9064 Add `prepared' field, the same hack used for FieldExprs to cope
9065 with composed assignments, as Local variables do not necessarily
9066 operate purely on the stack as they used to: they can be captured
9069 Add `temp' for a temporary result, like fields.
9071 Refactor DoResolve and DoResolveLValue into DoResolveBase.
9073 It now copes with Local variables that are captured and emits the
9074 proper instance variable to load it from a field in the captured
9077 (ParameterReference.DoResolveBase): During the resolve phase,
9078 capture parameters if we are in an anonymous method.
9080 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
9081 anonymous method, use the EmitContext helper routines to emit the
9082 parameter reference.
9084 * iterators.cs: Set RemapToProxy to true/false during the
9087 * parameters.cs (GetParameterByName): New helper method.
9089 * typemanager.cs (anonymous_method_type) a new type that
9090 represents an anonyous method. This is always an internal type,
9091 used as a fencepost to test against the anonymous-methodness of an
9094 2004-10-20 Marek Safar <marek.safar@seznam.cz>
9096 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
9098 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
9100 2004-11-10 Martin Baulig <martin@ximian.com>
9102 * expression.cs (Invocation.BetterFunction): If two methods have
9103 equal parameter types, but only one of them is generic, the
9104 non-generic one wins.
9105 (New.DoResolve): Don't set `is_struct' to false if we're a generic
9106 instance; just use `Type.IsValueType' to determine whether
9107 something is a struct or not.
9108 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
9109 so we can be called multiple times.
9111 2004-11-10 Martin Baulig <martin@ximian.com>
9113 * generic.cs (TypeParameter.DefineConstraints): New public method.
9114 (TypeParameter.CheckAccessLevel): Override this and return true.
9115 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
9116 override ResolveType() anymore.
9117 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
9119 2004-11-10 Martin Baulig <martin@ximian.com>
9121 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
9122 call DeclSpace.ResolveNestedType() on it.
9124 2004-11-10 Martin Baulig <martin@ximian.com>
9126 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
9127 non-null, call ParameterModifier() on it.
9129 2004-11-10 Martin Baulig <martin@ximian.com>
9132 (Iterators): Added `current_type' and `this_type' fields.
9133 (Iterators.DefineIterator): Create a new EmitContext and store it
9134 in `ec'; compute `this_type'.
9136 2004-11-10 Martin Baulig <martin@ximian.com>
9139 (TypeManager.IsPrivateAccessible): New public method.
9140 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
9142 2004-11-10 Martin Baulig <martin@ximian.com>
9144 * class.cs (TypeContainer.DefineType): Call
9145 TypeBuilder.DefineGenericParameters() before resolving the type
9147 (MethodData.parent_method): New protected field.
9148 (MethodData..ctor): Added `MethodInfo parent_method' argument.
9149 (MethodData.Define): Compute `parent_method'.
9152 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
9153 (MemberCore.GetClsCompliantAttributeValue): Likewise.
9154 (DeclSpace.ec): New protected field; store the EmitContext here.
9155 (DeclSpace.EmitContext): New public property.
9156 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
9157 (DeclSpace.ResolveNestedType): New public method.
9158 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
9159 (DeclSpace.NestedAccessible): Added `Type tb' argument.
9160 (DeclSpace.FamilyAccessible): Likewise.
9161 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
9162 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
9165 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
9168 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
9169 (Enum.Emit): Don't create a new EmitContext.
9171 2004-10-18 Martin Baulig <martin@ximian.com>
9173 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
9174 `Type' directly, but call ResolveType() on it.
9175 (Catch.Resolve): Likewise.
9176 (Foreach.Resolve): Likewise.
9178 2004-10-18 Martin Baulig <martin@ximian.com>
9180 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
9181 `Type' directly, but call ResolveType() on it.
9182 (Probe.DoResolve): Likewise.
9183 (ArrayCreation.LookupType): Likewise.
9184 (TypeOf.DoResolve): Likewise.
9185 (SizeOf.DoResolve): Likewise.
9187 2004-10-18 Raja R Harinath <rharinath@novell.com>
9189 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
9192 2004-10-17 John Luke <john.luke@gmail.com>
9194 * class.cs (Operator.GetSignatureForError): use CSharpName
9196 * parameter.cs (Parameter.GetSignatureForError): Returns
9197 correct name even if was not defined.
9199 2004-10-13 Raja R Harinath <rharinath@novell.com>
9202 * class.cs (TypeContainer.EmitContext): New property.
9203 (DefineNestedTypes): Create an emitcontext for each part.
9204 (MethodCore.DoDefineParameters): Use container's emitcontext.
9205 Pass type array to InternalParameters.
9206 (MemberBase.DoDefine): Use container's emitcontext.
9207 (FieldMember.Define): Likewise.
9208 (Event.Define): Likewise.
9209 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9210 Pass type array to InternalParameters.
9211 (SetIndexerMethod.GetParameterInfo): Likewise.
9212 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9213 * delegate.cs (Define): Pass emitcontext to
9214 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9215 array to InternalParameters.
9216 * expression.cs (ParameterReference.DoResolveBase): Pass
9217 emitcontext to GetParameterInfo.
9218 (ComposedCast.DoResolveAsTypeStep): Remove check on
9219 ec.ResolvingTypeTree.
9220 * parameter.cs (Parameter.Resolve): Change argument to
9221 EmitContext. Use ResolveAsTypeTerminal.
9222 (Parameter.GetSignature): Change argument to EmitContext.
9223 (Parameters.ComputeSignature): Likewise.
9224 (Parameters.ComputeParameterTypes): Likewise.
9225 (Parameters.GetParameterInfo): Likewise.
9226 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9227 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9228 * support.cs (InternalParameters..ctor): Remove variant that takes
9230 * typemanager.cs (system_intptr_expr): New.
9231 (InitExpressionTypes): Initialize it.
9233 2004-10-12 Chris Toshok <toshok@ximian.com>
9235 * cs-parser.jay: fix location for try_statement and catch_clause.
9237 2004-10-18 Martin Baulig <martin@ximian.com>
9239 * class.cs (FieldMember.Define): Don't access the TypeExpr's
9240 `Type' directly, but call ResolveType() on it.
9241 (MemberBase.DoDefine): Likewise.
9243 * expression.cs (New.DoResolve): Don't access the TypeExpr's
9244 `Type' directly, but call ResolveType() on it.
9245 (ComposedCast.DoResolveAsTypeStep): Likewise.
9247 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
9248 `Type' directly, but call ResolveType() on it.
9250 2004-10-17 John Luke <john.luke@gmail.com>
9252 * class.cs (Operator.GetSignatureForError): use CSharpName
9254 * parameter.cs (Parameter.GetSignatureForError): Returns
9255 correct name even if was not defined.
9257 2004-10-13 Raja R Harinath <rharinath@novell.com>
9260 * class.cs (TypeContainer.EmitContext): New property.
9261 (DefineNestedTypes): Create an emitcontext for each part.
9262 (MethodCore.DoDefineParameters): Use container's emitcontext.
9263 Pass type array to InternalParameters.
9264 (MemberBase.DoDefine): Use container's emitcontext.
9265 (FieldMember.Define): Likewise.
9266 (Event.Define): Likewise.
9267 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9268 Pass type array to InternalParameters.
9269 (SetIndexerMethod.GetParameterInfo): Likewise.
9270 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9271 * delegate.cs (Define): Pass emitcontext to
9272 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9273 array to InternalParameters.
9274 * expression.cs (ParameterReference.DoResolveBase): Pass
9275 emitcontext to GetParameterInfo.
9276 (ComposedCast.DoResolveAsTypeStep): Remove check on
9277 ec.ResolvingTypeTree.
9278 * parameter.cs (Parameter.Resolve): Change argument to
9279 EmitContext. Use ResolveAsTypeTerminal.
9280 (Parameter.GetSignature): Change argument to EmitContext.
9281 (Parameters.ComputeSignature): Likewise.
9282 (Parameters.ComputeParameterTypes): Likewise.
9283 (Parameters.GetParameterInfo): Likewise.
9284 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9285 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9286 * support.cs (InternalParameters..ctor): Remove variant that takes
9288 * typemanager.cs (system_intptr_expr): New.
9289 (InitExpressionTypes): Initialize it.
9291 2004-10-12 Chris Toshok <toshok@ximian.com>
9293 * cs-parser.jay: fix location for try_statement and catch_clause.
9295 2004-10-07 Raja R Harinath <rharinath@novell.com>
9297 More DeclSpace.ResolveType avoidance.
9298 * decl.cs (MemberCore.InUnsafe): New property.
9299 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
9300 with newly created EmitContext.
9301 (FieldMember.Define): Likewise.
9302 * delegate.cs (Delegate.Define): Likewise.
9303 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
9304 only if normal name-lookup fails.
9305 (TypeExpr.DoResolve): Enable error-checking.
9306 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
9307 (SizeOf.DoResolve): Likewise.
9308 (ComposedCast.DoResolveAsTypeStep): Likewise.
9309 (StackAlloc.DoResolve): Likewise.
9310 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
9311 (Block.Unsafe): New property.
9312 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
9313 (Unsafe): Set 'unsafe' flag of contained block.
9314 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
9315 (Fixed.Resolve): Likewise.
9316 (Catch.Resolve): Likewise.
9317 (Using.ResolveLocalVariableDecls): Likewise.
9318 (Foreach.Resolve): Likewise.
9320 2004-10-05 John Luke <john.luke@gmail.com>
9322 * cs-parser.jay: add location to error CS0175
9324 2004-10-04 Miguel de Icaza <miguel@ximian.com>
9326 * ecore.cs (Expression.Constantity): Add support for turning null
9329 * const.cs (Const.Define): Allow constants to be reference types
9330 as long as the value is Null.
9332 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
9334 * namespace.cs (NamespaceEntry.Using): No matter which warning
9335 level is set, check if this namespace name has already been added.
9337 2004-10-03 Ben Maurer <bmaurer@ximian.com>
9339 * expression.cs: reftype [!=]= null should always use br[true,false].
9342 2004-10-03 Marek Safar <marek.safar@seznam.cz>
9345 * attribute.cs: Enum conversion moved to
9346 GetAttributeArgumentExpression to be applied to the all
9349 2004-10-01 Raja R Harinath <rharinath@novell.com>
9351 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
9352 * class.c (TypeContainer.DefineType): Flag error if
9353 base types aren't accessible due to access permissions.
9354 * decl.cs (DeclSpace.ResolveType): Move logic to
9355 Expression.ResolveAsTypeTerminal.
9356 (DeclSpace.ResolveTypeExpr): Thin layer over
9357 Expression.ResolveAsTypeTerminal.
9358 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
9359 Refactor code into NestedAccess. Use it.
9360 (DeclSpace.NestedAccess): New.
9361 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
9362 argument to silence errors. Check access permissions.
9363 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
9364 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
9365 (Cast.DoResolve): Likewise.
9366 (New.DoResolve): Likewise.
9367 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
9368 (TypeOf.DoResolve): Likewise.
9370 * expression.cs (Invocation.BetterConversion): Return the Type of
9371 the better conversion. Implement section 14.4.2.3 more faithfully.
9372 (Invocation.BetterFunction): Make boolean. Make correspondence to
9373 section 14.4.2.2 explicit.
9374 (Invocation.OverloadResolve): Update.
9375 (Invocation): Remove is_base field.
9376 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
9377 (Invocation.Emit): Likewise.
9379 2004-09-24 Marek Safar <marek.safar@seznam.cz>
9381 * cs-parser.jay: Reverted 642 warning fix.
9383 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9386 * decl.cs (FindMemberWithSameName): Indexer can have more than
9389 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9391 * expression.cs (LocalVariableReference.DoResolveLValue):
9392 Do not report warning 219 for out values.
9393 (EmptyExpression.Null): New member to avoid extra allocations.
9395 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9397 * cs-parser.jay: Fix wrong warning 642 report.
9399 * cs-tokenizer.cs (CheckNextToken): New helper;
9400 Inspect next character if is same as expected.
9402 2004-09-23 Martin Baulig <martin@ximian.com>
9404 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9405 (Convert.ImplicitReferenceConversionExists): Likewise.
9407 2004-11-09 Raja R Harinath <rharinath@novell.com>
9409 * Makefile (DISTFILES): Comment out a few missing files.
9411 2004-10-29 Raja R Harinath <rharinath@novell.com>
9413 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
9414 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
9415 (gmcs.exe): Invoke bootstrap-libs.
9416 (clean-local): Clean the net_2_0_bootstrap profile too.
9417 (PROGRAM_INSTALL_DIR): New.
9418 (install-local): Use it.
9420 2004-10-13 Martin Baulig <martin@ximian.com>
9422 * generic.cs (TypeManager.InflatedConstraints): New nested class.
9423 (TypeParameter.DefineType): If we're a method type parameter and
9424 that method is overriding something, "inflate" its constraints.
9426 2004-10-12 Martin Baulig <martin@ximian.com>
9428 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
9429 and have type arguments, create and resolve a ConstructedType.
9431 2004-10-12 Martin Baulig <martin@ximian.com>
9433 * decl.cs (MemberCache.FindMemberToOverride): Use
9434 TypeManager.IsEqual() to compare the parameters and Type.Equals()
9435 to compare the invocationType.
9437 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
9438 When comparing two type parameters, only do the signature-only
9439 comparision for method type parameters.
9441 2004-10-11 Martin Baulig <martin@ximian.com>
9443 * report.cs: Don't make --fatal abort on warnings, we have
9444 -warnaserror for that.
9446 2004-10-11 Martin Baulig <martin@ximian.com>
9449 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
9450 (TypeManager.IsEqual): Call ourself recursively instead of using
9453 2004-10-11 Martin Baulig <martin@ximian.com>
9455 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
9456 on our own type parameters, not on the ones we inherit from a containing
9459 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
9462 * generic.cs (TypeParameter.Define): We may only be called once.
9464 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
9465 instead of TypeManager.IsEqual().
9467 2004-09-28 Martin Baulig <martin@ximian.com>
9470 (GenericConstraints.EffectiveBaseClass): New public property.
9471 (TypeParameter.GenericConstraints): New public property.
9472 (ConstructedType.CheckConstraints): Improved.
9474 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
9475 (Convert.TypeParameterConversion): New private method; use this in
9476 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
9477 for all conversions related to type parameters.
9479 2004-09-24 Martin Baulig <martin@ximian.com>
9481 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
9482 type parameter conversions for type parameters which are known to
9485 2004-09-24 Martin Baulig <martin@ximian.com>
9487 * generic.cs (GenericConstraints): Added `IsReferenceType' and
9488 `IsValueType' properties.
9490 * support.cs (ReflectionConstraints): Use
9491 Type.GetGenericParameterConstraints() instead of the old hack.
9493 2004-09-24 Martin Baulig <martin@ximian.com>
9495 * generic.cs (GenericConstraints): Moved here and made it an
9498 * support.cs (GenericConstraints): Moved to generic.cs.
9500 2004-09-24 Martin Baulig <martin@ximian.com>
9503 (ReflectionConstraints): Un-nested this class and made it public.
9506 (TypeManager.GetTypeParameterConstraints): New public method.
9507 (TypeManager.HasConstructorConstraint): Use the attributes.
9509 2004-09-24 Martin Baulig <martin@ximian.com>
9511 * support.cs (GenericConstraints): Replaced `HasConstructor',
9512 `IsReferenceType' and `IsValueType' with `Attributes'.
9513 (ReflectionParameters.ReflectionConstraints): Removed the Create()
9514 method and made the .ctor public.
9516 * generic.cs (Constraints.Attributes): New public property.
9517 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
9518 `IsReferenceType' -> `HasReferenceTypeConstraint' and
9519 `IsValueType' -> `HasValueTypeConstraint'.
9521 2004-09-23 Martin Baulig <martin@ximian.com>
9523 * generic.cs (Constraints): Reflect latest runtime changes.
9525 2004-09-23 Martin Baulig <martin@ximian.com>
9527 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9528 (Convert.ImplicitReferenceConversionExists): Likewise.
9530 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9532 * class.cs (Operator.Define): Add error 448 and 559 report.
9534 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9536 * class.cs (MemberBase.IsTypePermitted): New protected
9537 method for checking error CS0610.
9539 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9541 * class.cs (TypeContainer.HasExplicitLayout): New property
9542 Returns whether container has StructLayout attribute set Explicit.
9543 (FieldMember): New abstract class for consts and fields.
9544 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
9545 (Field): Reuse FieldMember.
9547 * const.cs (Const): Reuse FieldMember.
9549 * rootcontext.cs: EmitConstants call moved to class.
9551 2004-09-22 Martin Baulig <martin@ximian.com>
9553 Marek and me just fixed one of our oldest bugs: #28562 :-)
9555 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9557 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9558 we're an EnumConstant, just return that.
9559 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9560 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9561 to get the value which'll actually be written into the attribute.
9562 However, we have to use GetValue() to access the attribute's value
9565 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9567 * constant.cs (Constant.IsNegative): New abstract property
9570 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9571 (StackAlloc.DoResolve): Reused IsNegative.
9573 2004-09-22 Martin Baulig <martin@ximian.com>
9575 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9576 public method; like LookupTypeContainer, but also works for
9579 * report.cs (Report.SymbolRelatedToPreviousError): Use
9580 TypeManager.LookupGenericTypeContainer().
9582 2004-09-22 Martin Baulig <martin@ximian.com>
9584 Thanks to Peter Sestoft for this bug report.
9586 * expression.cs (Conditional): If both the `trueExpr' and the
9587 `falseExpr' is a NullLiteral, return a NullLiteral.
9589 2004-09-22 Martin Baulig <martin@ximian.com>
9591 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9592 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9593 for the "get_Current" call.
9595 2004-09-21 Martin Baulig <martin@ximian.com>
9597 * convert.cs (Convert.ImplicitReferenceConversion): When
9598 converting to an interface type, first check whether we're
9599 converting from a reference type.
9601 2004-09-14 Martin Baulig <martin@ximian.com>
9603 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9605 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9608 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9609 called and is obsolete then this member suppress message
9610 when call is inside next [Obsolete] method or type.
9612 * expression.cs: Use TestObsoleteMethodUsage member.
9614 2004-09-14 Martin Baulig <martin@ximian.com>
9616 * genericparser.cs: Removed.
9618 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9620 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9622 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9624 * attribute.cs (Attribute.Resolve): Add error 653 report.
9626 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9628 (Method.ApplyAttributeBuilder): Add error 685 report.
9629 (Operator.Define): Add error 564 report.
9631 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9633 * expression.cs (Invocation.DoResolve): Add error
9636 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9639 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9641 * class.cs (ConstructorInitializer.Resolve):
9642 Wrong error number (515->516).
9644 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9646 * class.cs (Indexer.Define): Add error 631 report.
9648 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9650 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9652 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9654 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9656 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9658 * cs-parser.jay: Added error CS0241 report.
9660 2004-09-10 Raja R Harinath <rharinath@novell.com>
9662 * cs-parser.jay (fixed_statement): Introduce a scope for the
9663 declaration in the 'fixed' statement.
9665 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9667 * cs-parser.jay: Added CS0230 error report.
9669 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9671 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9673 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9675 * expression.cs (Argument.Resolve): Added error CS0192 and
9678 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9680 C# 2.0 #pragma warning feature
9682 * cs-tokenizer.cs (PreProcessPragma): New method;
9683 Handles #pragma directive.
9685 * report.cs (WarningRegions): New class; Support
9686 class for #pragma warning directive. It tests whether
9687 warning is enabled for a given line.
9689 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9691 * const.cs: Add more descriptive error report, tahnks to
9694 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9696 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9698 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9700 * expression.cs: Apply patch from Ben: Remove dead code from
9701 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9702 as that code just threw an exception anwyays.
9704 * const.cs: Remove the call to the turnintoconstant, for details
9707 * literal.cs: The type of the null-literal is the null type; So
9708 we use a placeholder type (literal.cs:System.Null, defined here)
9711 * expression.cs (Conditional.DoResolve): Remove some old code that
9712 is no longer needed, conversions have been fixed.
9714 (ArrayCreationExpression.DoResolve): Return false if we fail to
9715 resolve the inner expression.
9717 2004-09-07 Raja R Harinath <rharinath@novell.com>
9720 * cs-parser.jay (delegate_declaration): Record a delegate
9721 declaration as a type declaration.
9722 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9724 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9726 * parameter.cs: Do not crash if the type can not be resolved.
9728 * expression.cs: Report errors with unsafe pointers, fixes #64896
9730 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9732 * expression.cs: Pointer arith always needs to do a conv.i
9733 if the operand is a long. fix 65320
9735 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9737 Fixed cs0619-37.cs, cs0619-38.cs
9739 * enum.cs (GetObsoleteAttribute): Removed.
9741 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9742 on Enum member is double staged. The first is tested member
9745 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9747 Fixed #56986, #63631, #65231
9749 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9750 adds member to name container.
9751 (TypeContainer.AddToTypeContainer): New method, adds type to
9753 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9754 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9755 AddOperator): Simplified by reusing AddToMemberContainer.
9756 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9758 (Method.CheckForDuplications): Fixed implementation to test all
9760 (MemberBase): Detection whether member is explicit interface
9761 implementation is now in constructor.
9762 (MemberBase.UpdateMemberName): Handles IndexerName.
9763 (Accessor): Changed to keep also location information.
9764 (AbstractPropertyEventMethod): Is derived from MemberCore.
9765 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9766 will be emited or not.
9767 (PropertyBase.AreAccessorsDuplicateImplementation):
9768 Tests whether accessors are not in collision with some method.
9769 (Operator): Is derived from MethodCore to simplify common
9772 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9774 (DeclSpace.AddToContainer): Adds the member to defined_names
9775 table. It tests for duplications and enclosing name conflicts.
9777 * enum.cs (EnumMember): Clean up to reuse the base structures
9779 2004-09-03 Martin Baulig <martin@ximian.com>
9781 Merged latest changes into gmcs. Please keep this comment in
9782 here, it makes it easier for me to see what changed in MCS since
9783 the last time I merged.
9785 2004-09-03 Martin Baulig <martin@ximian.com>
9787 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9788 into TypeContainer, to make partial classes work again.
9790 2004-09-03 Martin Baulig <martin@ximian.com>
9792 * rootcontext.cs (RootContext.V2): Removed.
9794 2004-03-23 Martin Baulig <martin@ximian.com>
9796 * expression.cs (Invocation.OverloadResolve): Added `bool
9797 may_fail' argument and use it instead of the Location.IsNull() hack.
9799 2004-09-09 Martin Baulig <martin@ximian.com>
9801 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9803 2004-09-09 Martin Baulig <martin@ximian.com>
9805 * generic.cs (TypeParameter.DefineType): Added support for
9806 explicit interface methods.
9808 2004-09-09 Martin Baulig <martin@ximian.com>
9810 * README.Changes: New document. Started to list important changes
9811 between MCS and GMCS here.
9813 2004-09-08 Martin Baulig <martin@ximian.com>
9816 (TypeContainer.CheckRecursiveDefinition): New protected method.
9817 (TypeContainer.DefineType): Move the CS0146 check into
9818 CheckRecursiveDefinition().
9820 2004-09-06 Martin Baulig <martin@ximian.com>
9822 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9823 types for the constructor constraint.
9825 2004-09-03 Martin Baulig <martin@ximian.com>
9827 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9828 into TypeContainer, to make partial classes work again.
9830 2004-09-03 Martin Baulig <martin@ximian.com>
9832 * rootcontext.cs (RootContext.V2): Removed.
9834 2004-03-23 Martin Baulig <martin@ximian.com>
9836 * expression.cs (Invocation.OverloadResolve): Added `bool
9837 may_fail' argument and use it instead of the Location.IsNull() hack.
9839 2004-09-03 Martin Baulig <martin@ximian.com>
9841 Merged latest changes into gmcs. Please keep this comment in
9842 here, it makes it easier for me to see what changed in MCS since
9843 the last time I merged.
9845 2004-09-03 Raja R Harinath <rharinath@novell.com>
9848 * expression.cs (BetterConversion): Don't allow either conversion
9849 to be null. Remove redundant implicit conversion test when 'q ==
9850 null' -- when this function is invoked, we already know that the
9851 implicit conversion exists.
9852 (BetterFunction): Assume that 'best' is non-null. Remove
9853 redundant reimplementation of IsApplicable when 'best' is null.
9854 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9855 number of arguments.
9856 (IsAncestralType): Extract from OverloadResolve.
9857 (OverloadResolve): Make robust to the MethodGroupExpr being
9858 unsorted. Implement all the logic of Section 14.5.5.1, and
9859 support overloading of methods from multiple applicable types.
9860 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9862 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9863 (RealError, Warning): Append type of report to related symbol.
9865 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9867 * enum.cs: Fixed CLS-Compliance checks for enum members.
9868 Error tests cs3008-8.cs, cs3014-8.cs
9870 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9872 Fixed bug #62342, #63102
9873 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9874 like ImplementMethod.
9876 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9878 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9881 2004-09-02 Martin Baulig <martin@ximian.com>
9883 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9884 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9887 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9889 C# 2.0 Static classes implemented
9891 * class.cs (TypeContainer): instance_constructors,
9892 initialized_fields, initialized_static_fields,
9893 default_constructor, base_inteface_types are protected to be
9894 accessible from StaticClass.
9895 (TypeContainer.DefineDefaultConstructor): New virtual method
9896 for custom default constructor generating
9897 (StaticClass): New class to handle "Static classes" feature.
9899 * cs-parser.jay: Handle static keyword on class like instance
9902 * driver.cs: Added "/langversion" command line switch with two
9903 options (iso-1, default).
9905 2004-08-31 Marek Safar <marek.safar@seznam.cz>
9907 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
9909 2004-08-31 Miguel de Icaza <miguel@ximian.com>
9911 * delegate.cs: Style.
9913 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
9915 * delegate.cs: Add seperate instance expr field for miguel.
9917 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9919 * PointerArithmetic (Resolve): make sure we are not doing
9920 pointer arith on void*. Also, make sure we are resolved
9921 by not setting eclass until resolve.
9923 All callers: Make sure that PointerArithmetic gets resolved.
9925 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9927 * ArrayCreation (LookupType): If the type does not resolve
9928 to an array, give an error.
9930 2004-08-27 Marek Safar <marek.safar@seznam.cz>
9932 * statement.cs (Try.Resolve): Fixed bug #64222
9934 2004-08-27 Martin Baulig <martin@ximian.com>
9937 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9940 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9942 * ecore.cs (Constantify): Get underlying type via
9943 System.Enum.GetUnderlyingType to avoid StackOverflow on the
9944 Windows in special cases.
9946 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9948 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
9949 for obtaining also private methods.
9950 (GetRemoveMethod): Used GetRemoveMethod (true)
9951 for obtaining also private methods.
9953 2004-09-02 Martin Baulig <martin@ximian.com>
9955 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9956 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9959 2004-08-27 Martin Baulig <martin@ximian.com>
9962 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9965 2004-08-25 Martin Baulig <martin@ximian.com>
9967 * support.cs (ReflectionParameters..ctor): If this is a generic
9968 method, retrieve and store its type parameters.
9969 (InternalParameters..ctor): Added `TypeParameter[]' argument.
9970 (ReflectionParameters.GenericConstraints): The argument specifies
9971 the type parameter, not the method parameter.
9972 (InternalParameters.GenericConstraints): Likewise.
9974 * generic.cs (TypeParameter.DefineType): Correctly handle
9975 constraints wrt. generic methods in interfaces and their
9978 2004-08-24 Martin Baulig <martin@ximian.com>
9980 * generic.cs (TypeParameter.IsSubclassOf): New public method.
9981 (Constraints.IsSubclassOf): New internal method.
9983 * typemanager.cs (TypeManager.FindMembers): Added special support
9984 for GenericTypeParameterBuilder's.
9985 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
9988 2004-08-24 Martin Baulig <martin@ximian.com>
9991 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
9992 this for accessibility checks.
9993 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
9994 IsNestedFamilyAccessible.
9995 (TypeManager.IsSubclassOf): New method, do what the name actually
9998 2004-08-24 Martin Baulig <martin@ximian.com>
10000 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
10001 as a SimpleName, include the generic arity.
10003 2004-08-24 Martin Baulig <martin@ximian.com>
10005 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
10006 MethodAttributes.HideBySig for operators.
10008 2004-08-23 Martin Baulig <martin@ximian.com>
10010 Back to the old error reporting system :-)
10012 * report.cs (Message): Removed.
10013 (Report.MessageData, ErrorData, WarningData): Removed.
10014 (Report.Error, Warning): Back to the old system.
10016 2004-08-23 Martin Baulig <martin@ximian.com>
10018 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
10020 * class.cs (TypeContainer.ParentContainer): New public virtual
10021 method; replaces the explicit interface implementation.
10022 (ClassPart.ParentContainer): Override.
10024 2004-08-23 Martin Baulig <martin@ximian.com>
10026 * statement.cs (Switch): Added support for constant switches; see
10027 #59428 or test-285.cs.
10029 2004-08-22 Marek Safar <marek.safar@seznam.cz>
10032 * statement.cs (GetEnumeratorFilter): Removed useless
10033 logic because C# specs is strict. GetEnumerator must be
10036 2004-08-22 Martin Baulig <martin@ximian.com>
10038 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
10039 a switch and may break, reset the barrier. Fixes #59867.
10041 2004-08-22 Marek Safar <marek.safar@seznam.cz>
10043 CLS-Compliance speed up (~5% for corlib)
10045 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
10046 New method. Tests container for CLS-Compliant names
10048 * class.cs (TypeContainer.VerifyClsName): New method.
10049 Checks whether container name is CLS Compliant.
10050 (Constructor): Implements IMethodData.
10052 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
10053 low-case table for CLS Compliance test.
10054 (MemberCache.VerifyClsParameterConflict): New method.
10055 Checks method parameters for CS3006 error.
10057 * enum.cs (EnumMember): Is derived from MemberCore.
10058 (Enum.VerifyClsName): Optimized for better performance.
10060 2004-08-06 Marek Safar <marek.safar@seznam.cz>
10062 * report.cs: Renamed Error_T to Error and changed all
10065 2004-08-06 Marek Safar <marek.safar@seznam.cz>
10067 * class.cs (TypeContainer.IndexerArrayList): New inner class
10068 container for indexers.
10069 (TypeContainer.DefaultIndexerName): New constant for default
10070 indexer name. Replaced all "Item" with this constant.
10071 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
10073 * typemanager.cs (TypeManager.default_member_ctor): Cache here
10074 DefaultMemberAttribute constructor.
10076 2004-08-05 Martin Baulig <martin@ximian.com>
10078 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
10081 2004-08-05 Marek Safar <marek.safar@seznam.cz>
10083 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
10084 multi platforms problem.
10086 * compiler.csproj: Included shared files.
10088 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10090 Fix bug 60333, 55971 in the more general way
10091 * attribute.cs (Attribute.GetAttributeArgumentExpression):
10092 Added arg_type argument for constant conversion.
10093 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
10095 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10098 * class.cs (TypeContainer ): New inner classes MethodArrayList,
10099 OperatorArrayList, MethodCoreArrayList for typecontainer
10100 containers. Changed class member types to these new types.
10101 (MethodArrayList.DefineMembers): Added test for CS0659.
10103 2004-08-04 Miguel de Icaza <miguel@ximian.com>
10105 * cfold.cs: Synchronize the folding with the code in expression.cs
10106 Binary.DoNumericPromotions for uint operands.
10108 * attribute.cs: Revert patch from Raja, it introduced a regression
10109 while building Blam-1.2.1 (hard to isolate a test case).
10111 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10115 (TypeContainer.Define): Renamed to DefineContainerMembers because of
10117 (MethodCore.parent_method): New member. The method we're overriding
10118 if this is an override method.
10119 (MethodCore.CheckBase): Moved from Method class and made common.
10120 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
10122 (MethodCore.CheckForDuplications): New abstract method. For custom
10123 member duplication search in a container
10124 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
10125 method and its return type.
10126 (Event.conflict_symbol): New member. Symbol with same name in the
10130 (MemberCache.FindMemberWithSameName): New method. The method
10131 is looking for conflict with inherited symbols.
10133 2004-08-04 Martin Baulig <martin@ximian.com>
10135 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10137 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10139 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10141 * report.cs (Message): New enum for better error, warning reference in
10143 (MessageData): New inner abstract class. It generally handles printing of
10144 error and warning messages.
10145 Removed unused Error, Warning, Message methods.
10147 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10149 Fix for cs0592-8.cs test
10151 (Attributable.ValidAttributeTargets): Made public.
10152 (Attribute.ExplicitTarget): New member for explicit target value.
10153 (Attribute.CheckTargets): Now we translate explicit attribute
10154 target to Target here.
10156 2004-08-03 Ben Maurer <bmaurer@ximian.com>
10158 * ecore.cs (MethodGroupExpr): new IsBase property.
10160 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
10162 * delegate.cs (DelegateCreation): store a MethodGroupExpr
10163 rather than an instance expr.
10165 (DelegateCreation.Emit): Use the method group rather than
10166 the instance expression. Also, if you have base.Foo as the
10167 method for a delegate, make sure to emit ldftn, not ldftnvirt.
10169 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
10171 (NewDelegate.DoResolve): Only check for the existance of Invoke
10172 if the method is going to be needed. Use MethodGroupExpr.
10174 (NewDelegate.Emit): Remove, DelegateCreation implements this.
10176 * expression.cs: For pointer arith., make sure to use
10177 the size of the type, not the size of the pointer to
10180 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10183 * class.cs (Class): Added error CS0502 test.
10185 2004-08-03 John Luke <jluke@cfl.rr.com>
10186 Raja R Harinath <rharinath@novell.com>
10189 * attribute.cs (Attribute.complained_before): New flag.
10190 (Attribute.ResolveType, Attribute.Resolve),
10191 (Attribute.DefinePInvokeMethod): Set it.
10192 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
10194 2004-08-03 Martin Baulig <martin@ximian.com>
10196 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10197 use a user-defined operator; we still need to do numeric
10198 promotions in case one argument is a builtin type and the other
10199 one has an implicit conversion to that type. Fixes #62322.
10201 2004-08-18 Martin Baulig <martin@ximian.com>
10203 * class.cs (Method.Define): Use the correct method name when
10204 creating the MethodBuilder for a generic method.
10206 2004-08-17 Martin Baulig <martin@ximian.com>
10208 * generic.cs (Constraints): Support type parameter constraints.
10210 2004-08-16 Martin Baulig <martin@ximian.com>
10212 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
10213 (Token.GENERIC_DIMENSION): New token; this is returned if we
10214 encounter an unbound generic type in a typeof() expression.
10216 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
10217 this token is only generated while parsing a typeof() expression.
10218 (typeof_expression): Removed the old unbound_type hack.
10220 * generic.cs (TypeArguments.IsUnbound): New public property.
10222 * decl.cs (MemberName): Added support for unbound types.
10224 2004-08-14 Martin Baulig <martin@ximian.com>
10227 (TypeManager.IsEqualGenericInstance): New static method.
10228 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
10229 just used to check accessibility, so follow the rules of 26.1.6.
10231 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
10232 ConstructedType instead of a TypeExpression if we have type arguments.
10234 * cs-parser.jay (typeof_expression): Support unbound generic types.
10236 * ecore.cs (UnboundTypeExpression): New public class.
10238 2004-08-12 Martin Baulig <martin@ximian.com>
10240 * typemanager.cs (TypeManager.IsNestedChildOf): Use
10241 TypeManager.IsEqual() rather than `=='.
10243 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
10244 generic instances as well.
10246 2004-08-12 Martin Baulig <martin@ximian.com>
10248 * expression.cs (Invocation.InferType): We can only infer method
10249 type parameters. Fixes #62647.
10251 2004-08-11 Martin Baulig <martin@ximian.com>
10253 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
10254 before resolving the base classes.
10256 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10258 * Makefile: install .mdb file too.
10260 2004-08-05 Martin Baulig <martin@ximian.com>
10262 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
10263 initializer, the current type is just the TypeBuilder, not the
10264 instantiated generic type.
10265 (FieldExpr.IsFieldInitializer): New public property.
10267 2004-08-04 Martin Baulig <martin@ximian.com>
10269 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10271 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10273 2004-08-03 Martin Baulig <martin@ximian.com>
10275 * class.cs (MethodData.Define): If we're an explicit
10276 implementation, remove the generic arity from the type name.
10278 2004-08-03 Martin Baulig <martin@ximian.com>
10280 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10281 use a user-defined operator; we still need to do numeric
10282 promotions in case one argument is a builtin type and the other
10283 one has an implicit conversion to that type. Fixes #62322.
10285 2004-08-02 Martin Baulig <martin@ximian.com>
10287 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
10288 `TypeExpr[]' array.
10289 (TypeContainer.GetClassBases): Return the unexpanded list of
10290 interfaces; we expand them later.
10291 (TypeContainer.DefineType): After creating the TypeBuilder, call
10292 TypeManager.ExpandInterfaces() to get an expanded and resolved
10293 list of interfaces.
10295 * ecore.cs (TypeExpr.GetInterfaces): Removed
10297 * generics.cs (Constraints.InterfaceConstraints): Remove.
10298 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
10299 register the interface constraints.
10302 (TypeManager.AddUserType): Removed the `ifaces' argument.
10303 (TypeManager.AddTypeParameter): Likewise.
10304 (TypeManager.AddUserInterface): Removed, was unused.
10305 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
10306 `TypeExpr[]' array for the interfaces.
10307 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
10308 has been defined, returns a list of the resolved interfaces types.
10309 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
10310 (TypeManager.GetExplicitInterfaces): Likewise.
10312 2004-08-02 Martin Baulig <martin@ximian.com>
10314 * expression.cs (Invocation.EmitCall): If we're invoking a method
10315 on a type parameter, use the new `Constrained' prefix opcode.
10317 2004-08-02 Martin Baulig <martin@ximian.com>
10319 * statement.cs (LocalInfo.Flags): Added `IsThis'.
10320 (LocalInfo.IsThis): New public property.
10321 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
10323 2004-08-01 Martin Baulig <martin@ximian.com>
10325 * class.cs (TypeContainer.GetClassBases): Don't set the default
10326 here since we may get called from GetPartialBases().
10327 (TypeContainer.DefineType): If GetClassBases() didn't return a
10328 parent, use the default one.
10330 2004-07-30 Martin Baulig <martin@ximian.com>
10332 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
10334 * class.cs (SourceMethod): New public class, derive from the
10335 symbol writer's ISourceMethod.
10336 (Method): Use the new symbol writer API.
10338 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
10339 as argument and use the new symbol writer.
10342 (SourceFile): Implement the symbol writer's ISourceFile.
10343 (Location.SymbolDocument): Removed.
10344 (Location.SourceFile): New public property.
10346 * symbolwriter.cs: Use the new symbol writer API.
10348 2004-07-30 Raja R Harinath <rharinath@novell.com>
10350 * Makefile (install-local): Remove. Functionality moved to
10353 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
10355 * Makefile: Install mcs.exe.config file together with mcs.exe.
10356 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
10357 correct runtime version.
10359 2004-07-25 Martin Baulig <martin@ximian.com>
10362 (TypeContainer.RegisterOrder): Removed, this was unused.
10363 (TypeContainer, interface_order): Removed.
10364 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
10365 TypeContainer as argument since we can also be called with a
10366 `PartialContainer' for a partial class/struct/interface.
10367 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
10368 of checking whether we're an `Interface' - we could be a
10369 `PartialContainer'.
10370 (PartialContainer.Register): Override; call
10371 AddClass()/AddStruct()/AddInterface() on our parent.
10373 * cs-parser.jay (interface_member_declaration): Add things to the
10374 `current_container', not the `current_class'.
10376 * rootcontext.cs (RegisterOrder): The overloaded version which
10377 takes an `Interface' was unused, removed.
10379 * typemanager.cs (TypeManager.LookupInterface): Return a
10380 `TypeContainer', not an `Interface'.
10381 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
10382 contain a `PartialContainer' for an interface, so check it's
10383 `Kind' to figure out what it is.
10385 2004-07-25 Martin Baulig <martin@ximian.com>
10387 * class.cs (Class.DefaultTypeAttributes): New public constant.
10388 (Struct.DefaultTypeAttributes): Likewise.
10389 (Interface.DefaultTypeAttributes): Likewise.
10390 (PartialContainer.TypeAttr): Override this and add the
10391 DefaultTypeAttributes.
10393 2004-07-25 Martin Baulig <martin@ximian.com>
10395 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
10396 we can just use the `Parent' field instead.
10398 2004-07-25 Martin Baulig <martin@ximian.com>
10400 * class.cs (TypeContainer.Emit): Renamed to EmitType().
10402 2004-07-25 Martin Baulig <martin@ximian.com>
10404 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
10405 our parts before defining any methods.
10406 (TypeContainer.VerifyImplements): Make this virtual.
10407 (ClassPart.VerifyImplements): Override and call VerifyImplements()
10408 on our PartialContainer.
10410 2004-07-25 Martin Baulig <martin@ximian.com>
10412 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
10414 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
10415 argument, we can just use the `Parent' field instead.
10418 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
10419 (MemberBase.DoDefine): Likewise.
10421 2004-07-24 Martin Baulig <martin@ximian.com>
10423 * decl.cs (MemberCore.Parent): New public field.
10424 (DeclSpace.Parent): Moved to MemberCore.
10426 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
10427 (MemberBase.ctor): Added TypeContainer argument, pass it to our
10429 (FieldBase, Field, Operator): Likewise.
10430 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
10431 (EventField, Event): Likewise.
10433 2004-07-23 Martin Baulig <martin@ximian.com>
10435 * class.cs (PartialContainer): New public class.
10436 (ClassPart): New public class.
10437 (TypeContainer): Added support for partial classes.
10438 (TypeContainer.GetClassBases): Splitted some of the functionality
10439 out into GetNormalBases() and GetPartialBases().
10441 * cs-tokenizer.cs (Token.PARTIAL): New token.
10442 (Tokenizer.consume_identifier): Added some hacks to recognize
10443 `partial', but only if it's immediately followed by `class',
10444 `struct' or `interface'.
10446 * cs-parser.jay: Added support for partial clases.
10448 2004-07-23 Martin Baulig <martin@ximian.com>
10450 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
10451 a `DeclSpace' and also made it readonly.
10452 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
10453 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
10454 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
10456 * cs-parser.jay: Pass the `current_class', not the
10457 `current_container' (at the moment, this is still the same thing)
10458 to a new Method, Property, Event, Indexer or Constructor.
10460 2004-07-23 Martin Baulig <martin@ximian.com>
10462 * cs-parser.jay (CSharpParser): Added a new `current_class' field
10463 and removed the `current_interface' one.
10464 (struct_declaration, class_declaration, interface_declaration):
10465 Set `current_class' to the newly created class/struct/interface;
10466 set their `Bases' and call Register() before parsing their body.
10468 2004-07-23 Martin Baulig <martin@ximian.com>
10470 * class.cs (Kind): New public enum.
10471 (TypeContainer): Made this class abstract.
10472 (TypeContainer.Kind): New public readonly field.
10473 (TypeContainer.CheckDef): New public method; moved here from
10475 (TypeContainer.Register): New public abstract method.
10476 (TypeContainer.GetPendingImplementations): New public abstract
10478 (TypeContainer.GetClassBases): Removed the `is_class' and
10479 `is_iface' parameters.
10480 (TypeContainer.DefineNestedTypes): Formerly known as
10482 (ClassOrStruct): Made this class abstract.
10484 * tree.cs (RootTypes): New public type.
10486 2004-07-20 Martin Baulig <martin@ximian.com>
10488 * tree.cs (Tree.RecordNamespace): Removed.
10489 (Tree.Namespaces): Removed.
10491 * rootcontext.cs (RootContext.IsNamespace): Removed.
10493 * cs-parser.jay (namespace_declaration): Just create a new
10494 NamespaceEntry here.
10496 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
10498 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
10499 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
10500 entry to make sure it runs in the correct runtime version.
10502 2004-07-18 Martin Baulig <martin@ximian.com>
10504 * generic.cs (ConstructedType.CheckConstraints): Improved
10505 constraints checking.
10507 2004-07-18 Martin Baulig <martin@ximian.com>
10509 * expression.cs (Invocation.BetterMethod): Call
10510 TypeManager.TypeToCoreType() on all types and removed my previous
10511 hack; we're already doig the right thing here.
10513 2004-07-17 Martin Baulig <martin@ximian.com>
10515 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
10517 2004-07-16 Martin Baulig <martin@ximian.com>
10519 * iterators.cs: Added generics support.
10521 2004-07-16 Martin Baulig <martin@ximian.com>
10523 * iterators.cs: Rewrote this. We're now using one single Proxy
10524 class for both the IEnumerable and the IEnumerator interface and
10525 `Iterator' derives from Class so we can use the high-level API.
10527 * class.cs (TypeContainer.AddIterator): New method.
10528 (TypeContainer.DoDefineType): New protected virtual method, which
10529 is called from DefineType().
10530 (TypeContainer.DoDefineMembers): Call DefineType() and
10531 DefineMembers() on all our iterators.
10532 (TypeContainer.Emit): Call Emit() on all our iterators.
10533 (TypeContainer.CloseType): Call CloseType() on all our iterators.
10535 * codegen.cs (EmitContext.CurrentIterator): New public field.
10537 2004-07-15 Martin Baulig <martin@ximian.com>
10540 (TypeManager.not_supported_exception_type): New type.
10542 2004-07-14 Martin Baulig <martin@ximian.com>
10545 (TypeManager.generic_ienumerable_type): New type.
10546 (TypeManager.generic_ienumerator_type): New type.
10549 (RootContext.interfaces_first_stage): Added
10550 "System.Collections.Generic.IEnumerator`1" and
10551 "System.Collections.Generic.IEnumerable`1".
10553 2004-07-14 Martin Baulig <martin@ximian.com>
10555 * iterators.cs: Use real error numbers.
10557 2004-07-14 Martin Baulig <martin@ximian.com>
10559 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10560 requires this to be a System.Collection.IEnumerable and not a
10561 class implementing that interface.
10562 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10564 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10566 * class.cs: Fixed previous fix, it broke some error tests.
10568 2004-07-12 Martin Baulig <martin@ximian.com>
10570 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10573 2004-07-14 Martin Baulig <martin@ximian.com>
10575 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10576 an exclamation mark (!) for the generic arity to reflect the
10577 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10579 2004-07-13 Martin Baulig <martin@ximian.com>
10581 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10582 specifiers being part of a type argument.
10584 2004-07-13 Martin Baulig <martin@ximian.com>
10586 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10587 name for generic types.
10589 2004-07-13 Martin Baulig <martin@ximian.com>
10591 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10594 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10596 * assign.cs (LocalTemporary): Add new argument: is_address,If
10597 `is_address' is true, then the value that we store is the address
10598 to the real value, and not the value itself.
10600 * ecore.cs (PropertyExpr): use the new local temporary
10601 stuff to allow us to handle X.Y += z (where X is a struct)
10603 2004-07-08 Martin Baulig <martin@ximian.com>
10605 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10606 not always return, just like we're doing in Using.Resolve().
10608 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10610 * cs-parser.jay (fixed_statement): flag this as Pinned.
10612 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10614 * typemanager.cs (TypeManager): Removed MakePinned method, this
10615 mechanism is replaced with the .NET 2.x compatible mechanism of
10616 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10618 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10619 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10620 `IsFixed' property which has a different meaning.
10622 2004-07-02 Raja R Harinath <rharinath@novell.com>
10624 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10625 visible from inside a nested class, not just the names of the
10626 immediately enclosing class.
10627 Fix for bug #60730.
10629 2004-06-24 Raja R Harinath <rharinath@novell.com>
10631 * expression.cs (BetterConversion): Remove buggy special-case
10632 handling of "implicit constant expression conversions". At this
10633 point, we already know that the conversion is possible -- we're
10634 only checking to see which is better.
10636 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10638 * cs-parser.jay: Added error CS0210 test.
10640 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10642 * cs-parser.jay: Added error CS0134 test.
10644 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10647 * cs-parser.jay: Added error CS0145 test.
10649 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10651 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10653 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10655 * expression.cs (StackAlloc.Resolve): The argument may not
10656 be a constant; deal with this case.
10658 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10660 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10661 GetIndexerAttributeValue.
10662 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10664 * class.cs (Indexer.Define): Added error tests for CS0415,
10667 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10669 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10672 2004-06-23 Martin Baulig <martin@ximian.com>
10674 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10675 neither return nor throw, reset the barrier as well. Fixes #60457.
10677 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10679 * class.cs : EventAttributes is now set to None by default.
10680 This fixes bug #60459.
10682 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10685 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10686 Don't throw exception but return null (it's sufficient now).
10688 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10690 * typemanager.cs (GetArgumentTypes): Faster implementation.
10692 2004-06-18 Martin Baulig <martin@ximian.com>
10694 * attribute.cs (Attribute.Resolve): Check whether we're an
10695 EmptyCast which a Constant child. Fixes #60333.
10697 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10699 * statement.cs (EmitCollectionForeach): Account for the fact that
10700 not all valuetypes are in areas which we can take the address of.
10701 For these variables, we store to a temporary variable. Also, make
10702 sure that we dont emit a `callvirt' on a valuetype method.
10704 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10706 * expression.cs (StackAlloc.DoReSolve): Added test for
10707 negative parameter (CS0247).
10709 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10712 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10714 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10717 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10720 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10722 Fix bug #58254 & cs1555.cs, cs1556.cs
10723 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10725 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10727 * cs-parser.jay: Added error CS1669 test for indexers.
10729 2004-06-18 Martin Baulig <martin@ximian.com>
10731 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10732 argument. Fixes #60441.
10734 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10735 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10736 The name needs to have the actual name of the method in order
10737 for other tests (such as the one in OverloadResolve for Invoke
10738 on a delegate) to work. As well, it does not really help
10739 error reporting because the method group had multiple methods.
10740 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10741 Make profiling work.
10743 2004-06-13 Martin Baulig <martin@ximian.com>
10745 * cs-parser.jay: Don't allow generic attributes.
10747 2004-06-13 Martin Baulig <martin@ximian.com>
10749 * class.cs (MemberBase.DoDefineBase): New protected method.
10750 (MemberBase.DoDefine): Compute the `flags' in the new
10751 DoDefineBase() which must be called first.
10752 (Method.Define): Call DoDefineBase() first so we have the flags
10753 when defining the generic method.
10755 * cs-parser.jay (interface_method_declaration): Support generic methods.
10757 2004-06-13 Martin Baulig <martin@ximian.com>
10759 * decl.cs (TypeName): Removed.
10760 (MemberName): Removed TypeName and MemberNow; now we just have
10763 * cs-parser.jay: Don't distinguish between type arguments and type
10764 parameters in the grammar and simplified the rules a bit. The
10765 reduce/reduce conflicts are now gone (except the one we inherited
10768 2004-06-11 Martin Baulig <martin@ximian.com>
10770 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10771 call this twice: for params and varargs methods.
10773 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10776 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10778 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10780 * attribute.cs (Attribute.GetValidTargets): Made public.
10783 (AbstractPropertyEventMethod): New class for better code sharing.
10784 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10786 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10788 2004-06-09 Martin Baulig <martin@ximian.com>
10790 * cs-parser.jay: Removed a reduce/reduce conflict.
10792 2004-06-03 Martin Baulig <martin@ximian.com>
10794 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10795 GetSimpleName() and return a SimpleName.
10797 * ecore.cs (SimpleName.Arguments): New public field.
10798 (SimpleName): Added overloaded ctor which takes an additional
10799 TypeArguments argument.
10800 (SimpleName.SimpleNameResolve): Added support for generic methods.
10801 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10802 formerly in MemberAccess.DoResolve(), but we also need it in
10803 SimpleNameResolve().
10805 * expression.cs (MemberAccess.DoResolve): Use the new
10806 MethodGroupExpr.ResolveGeneric().
10808 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10810 * decl.cs: If possible, use lookuptypedirect here. We can only do
10811 this if there is no `.' after the namespace. Avoids using
10812 LookupType, which does lots of slow processing.
10813 (FindNestedType) New method, does what it says :-).
10814 * namespace.cs: use LookupTypeDirect.
10815 * rootcontext.cs: use membercache, if possible.
10816 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10818 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10821 According to the spec,
10823 In a member access of the form E.I, if E is a single identifier,
10824 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10825 field, property, localvariable, or parameter with the same type as
10826 the meaning of E as a type-name (§3.8), then both possible
10827 meanings of E are permitted.
10829 We did not check that E as a simple-name had the same type as E as
10832 This trivial check gives us 5-7% on bootstrap time.
10834 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10836 * expression.cs (Invocation.OverloadResolve): Avoid the
10837 use of hashtables and boxing here by allocating on demand.
10839 2004-05-30 Martin Baulig <martin@ximian.com>
10841 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10842 we're doing a silent lookup. Don't try to lookup nested types in
10843 TypeManager.object_type (thanks to Ben Maurer).
10845 2004-05-30 Martin Baulig <martin@ximian.com>
10847 Committing a patch from Ben Maurer.
10849 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10851 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10853 * convert.cs: add a trivial cache for overload operator resolution.
10855 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10858 (AttributeTester.GetObsoleteAttribute): Returns instance of
10859 ObsoleteAttribute when type is obsolete.
10862 (TypeContainer.VerifyObsoleteAttribute): Override.
10863 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10864 (MethodCode.VerifyObsoleteAttribute): Override.
10865 (MemberBase.VerifyObsoleteAttribute): Override.
10868 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10869 and report proper error.
10872 (Delegate.VerifyObsoleteAttribute): Override.
10875 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10876 and report proper error.
10877 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10880 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10884 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10885 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10886 Added test for ObsoleteAttribute.
10889 (Catch): Derived from Statement.
10891 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10893 * decl.cs: If possible, use lookuptypedirect here. We can only do
10894 this if there is no `.' after the namespace. Avoids using
10895 LookupType, which does lots of slow processing.
10896 (FindNestedType) New method, does what it says :-).
10897 * namespace.cs: use LookupTypeDirect.
10898 * rootcontext.cs: use membercache, if possible.
10899 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10901 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10904 According to the spec,
10906 In a member access of the form E.I, if E is a single identifier,
10907 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10908 field, property, localvariable, or parameter with the same type as
10909 the meaning of E as a type-name (§3.8), then both possible
10910 meanings of E are permitted.
10912 We did not check that E as a simple-name had the same type as E as
10915 This trivial check gives us 5-7% on bootstrap time.
10917 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10919 Fixed bug #59071 & cs0160.cs
10920 * statement.cs (Try.Resolve): Check here whether order of catch
10921 clauses matches their dependencies.
10923 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10926 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
10929 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10931 * expression.cs (Invocation.OverloadResolve): Avoid the
10932 use of hashtables and boxing here by allocating on demand.
10934 2004-05-30 Martin Baulig <martin@ximian.com>
10936 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10937 we're doing a silent lookup. Don't try to lookup nested types in
10938 TypeManager.object_type (thanks to Ben Maurer).
10940 2004-05-30 Martin Baulig <martin@ximian.com>
10942 Committing a patch from Ben Maurer.
10944 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10946 2004-05-29 Martin Baulig <martin@ximian.com>
10948 * class.cs (IMethodData.ShouldIgnore): New method.
10950 * typemanager.cs (TypeManager.MethodFlags): Don't take a
10951 `Location' argument, we don't need it anywhere. Use
10952 `IMethodData.ShouldIgnore ()' instead of
10953 `MethodData.GetMethodFlags ()'.
10954 (TypeManager.AddMethod): Removed.
10955 (TypeManager.AddMethod2): Renamed to AddMethod.
10957 2004-05-29 Martin Baulig <martin@ximian.com>
10959 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
10961 * convert.cs (Convert.ImplicitReferenceConversion): If we're
10962 converting from a class type S to an interface type and we already
10963 have an object on the stack, don't box it again. Fixes #52578.
10965 2004-05-29 Martin Baulig <martin@ximian.com>
10967 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10968 Added support for `params' parameters. Fixes #59267.
10970 2004-05-29 Martin Baulig <martin@ximian.com>
10972 * literal.cs (NullPointer): Provide a private .ctor which sets
10973 `type' to TypeManager.object_type. Fixes #59048.
10975 2004-05-29 Martin Baulig <martin@ximian.com>
10977 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
10978 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
10980 * ecore.cs (EventExpr.instance_expr): Make the field private.
10982 2004-05-26 Marek Safar <marek.safar@seznam.cz>
10984 Fixed bug #50080 & cs0214-2.cs
10985 * expression.cs (Cast.DoResolve): Check unsafe context here.
10987 * statement.cs (Resolve.DoResolve): Likewise.
10989 2004-05-26 Martin Baulig <martin@ximian.com>
10991 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
10993 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
10994 (RootContext.LookupType): Pass down the `silent' flag.
10996 2004-05-25 Martin Baulig <martin@ximian.com>
10999 (MethodGroupExpr.IdenticalTypeName): New public property.
11000 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
11001 expression actually refers to a type.
11003 2004-05-25 Martin Baulig <martin@ximian.com>
11005 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
11006 for #56176 and made it actually work.
11008 2004-05-25 Martin Baulig <martin@ximian.com>
11010 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
11011 (FieldExpr, PropertyExpr): Override and implement
11012 CacheTemporaries. Fixes #52279.
11014 2004-05-25 Miguel de Icaza <miguel@ximian.com>
11016 * location.cs: In the new compiler listing a file twice is a
11017 warning, not an error.
11019 2004-05-24 Martin Baulig <martin@ximian.com>
11021 * enum.cs (Enum.DefineType): For the `BaseType' to be a
11022 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
11024 2004-05-24 Martin Baulig <martin@ximian.com>
11026 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
11027 walking the `using' list. Fixes #53921.
11029 2004-05-24 Martin Baulig <martin@ximian.com>
11031 * const.cs (Const.LookupConstantValue): Added support for
11032 EmptyCast's; fixes #55251.
11034 2004-05-24 Martin Baulig <martin@ximian.com>
11036 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
11037 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
11038 which does the CS0135 check. The reason is that we first need to
11039 check whether the variable actually exists.
11041 2004-05-24 Martin Baulig <martin@ximian.com>
11043 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
11044 than RootContext.LookupType() to find the explicit interface
11045 type. Fixes #58584.
11047 2004-05-24 Raja R Harinath <rharinath@novell.com>
11049 * Makefile: Simplify. Use executable.make.
11050 * mcs.exe.sources: New file. List of sources of mcs.exe.
11052 2004-05-24 Anders Carlsson <andersca@gnome.org>
11056 Use the invariant culture when doing String.Compare for CLS case
11059 2004-05-23 Martin Baulig <martin@ximian.com>
11061 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
11062 don't have any dots. Fixes #52622, added cs0246-8.cs.
11064 * namespace.cs (NamespaceEntry.Lookup): Likewise.
11066 2004-05-23 Marek Safar <marek.safar@seznam.cz>
11068 * class.cs (MemberBase.Define): Reuse MemberType member for
11069 resolved type. Other methods can use it too.
11071 2004-05-23 Martin Baulig <martin@ximian.com>
11073 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
11074 the variable also exists in the current block (otherwise, we need
11075 to report a CS0103). Fixes #58670.
11077 2004-05-23 Martin Baulig <martin@ximian.com>
11079 * flowanalysis.cs (Reachability.Reachable): Compute this
11080 on-the-fly rather than storing it as a field.
11082 2004-05-23 Martin Baulig <martin@ximian.com>
11084 * flowanalysis.cs (Reachability.And): Manually compute the
11085 resulting `barrier' from the reachability.
11087 2004-05-23 Marek Safar <marek.safar@seznam.cz>
11090 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
11091 instance of ObsoleteAttribute when symbol is obsolete.
11094 (IMethodData): Extended interface for ObsoleteAttribute support.
11096 2004-05-22 Marek Safar <marek.safar@seznam.cz>
11098 * attribute.cs: Fix bug #55970
11100 2004-05-22 Marek Safar <marek.safar@seznam.cz>
11104 (GetObsoleteAttribute): New method. Creates the instance of
11106 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
11107 ObsoleteAttribute when member is obsolete.
11108 (AttributeTester.Report_ObsoleteMessage): Common method for
11109 Obsolete error/warning reporting.
11112 (TypeContainer.base_classs_type): New member for storing parent type.
11115 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
11116 for this MemberCore.
11118 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11120 * attribute.cs, const.cs: Fix bug #58590
11122 2004-05-21 Martin Baulig <martin@ximian.com>
11124 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
11125 out parameters if the end of the method is unreachable. Fixes
11128 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11130 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
11131 Hari was right, why extra method.
11133 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11135 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
11137 2004-05-20 Martin Baulig <martin@ximian.com>
11139 * delegate.cs: Convert this file to Unix mode - like the original
11142 2004-05-20 Martin Baulig <martin@ximian.com>
11144 * attribute.cs: Convert this file to Unix mode - like the original
11147 2004-05-19 Marek Safar <marek.safar@seznam.cz>
11149 Fix bug #58688 (MCS does not report error when the same attribute
11152 * attribute.cs (Attribute.Emit): Distinction between null and default.
11154 2004-05-19 Raja R Harinath <rharinath@novell.com>
11156 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
11157 of a top-level attribute without an attribute target.
11158 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
11160 (Attribute.Conditional_GetConditionName),
11161 (Attribute.Obsolete_GetObsoleteMessage): Update.
11162 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
11163 part of ScanForIndexerName.
11164 (Attribute.CanIgnoreInvalidAttribute): New function.
11165 (Attribute.ScanForIndexerName): Move to ...
11166 (Attributes.ScanForIndexerName): ... here.
11167 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
11168 (Attributes.Search): New internal variant that can choose not to
11169 complain if types aren't resolved. The original signature now
11171 (Attributes.GetClsCompliantAttribute): Use internal variant, with
11172 complaints suppressed.
11173 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
11174 only if it not useful.
11175 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
11176 top-level for attributes that are shared between the assembly
11177 and a top-level class.
11178 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
11179 * class.cs: Update to reflect changes.
11180 (DefineIndexers): Fuse loops.
11181 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
11182 a couple more variants of attribute names.
11184 2004-05-18 Marek Safar <marek.safar@seznam.cz>
11186 Fix bug #52585 (Implemented explicit attribute declaration)
11189 (Attributable.ValidAttributeTargets): New abstract method. It gets
11190 list of valid attribute targets for explicit target declaration.
11191 (Attribute.Target): It holds target itself.
11192 (AttributeSection): Removed.
11193 (Attribute.CheckTargets): New method. It checks whether attribute
11194 target is valid for the current element.
11197 (EventProperty): New class. For events that are declared like
11198 property (with add and remove accessors).
11199 (EventField): New class. For events that are declared like field.
11202 * cs-parser.jay: Implemented explicit attribute target declaration.
11204 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
11205 Override ValidAttributeTargets.
11208 (ReturnParameter): Class for applying custom attributes on
11210 (ParameterAtribute): New class. Class for applying custom
11211 attributes on the parameter type.
11213 2004-05-17 Miguel de Icaza <miguel@ximian.com>
11215 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
11218 (Method): Allow UNSAFE here.
11220 * modifiers.cs: Support unsafe reporting.
11222 2004-05-17 Marek Safar <marek.safar@seznam.cz>
11224 * decl.cs: Fix bug #58478.
11226 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11228 * statement.cs: When checking for unreachable code on an EmptyStatement,
11229 set the location. Fixes bug #58488.
11231 2004-05-13 Miguel de Icaza <miguel@ximian.com>
11233 * driver.cs: Add -pkg handling.
11235 From Gonzalo: UseShelLExecute=false
11237 2004-05-12 Marek Safar <marek.safar@seznam.cz>
11240 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
11242 (Attribute.IsClsCompliaceRequired): Moved to base for better
11244 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
11245 when attribute is AttributeUsageAttribute.
11246 (Attribute.GetValidTargets): Simplified.
11247 (Attribute.GetAttributeUsage): New method returns AttributeUsage
11248 attribute for this type.
11249 (Attribute.ApplyAttributes): Method renamed to Emit and make
11251 (GlobalAttributeSection): New class for special handling of global
11252 attributes (assembly, module).
11253 (AttributeSection.Emit): New method.
11255 * class.cs: Implemented Attributable abstract methods.
11256 (MethodCore.LabelParameters): Moved to Parameter class.
11257 (Accessor): Is back simple class.
11258 (PropertyMethod): Implemented Attributable abstract class.
11259 (DelegateMethod): Implemented Attributable abstract class.
11260 (Event): New constructor for disctintion between normal Event
11261 and Event with accessors.
11263 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
11265 * codegen.cs, const.cs, decl.cs, delegate.cs:
11266 (CommonAssemblyModulClass): Implemented Attributable abstract class
11269 * enum.cs: Implement IAttributeSupport interface.
11270 (EnumMember): New class for emum members. Implemented Attributable
11274 (ParameterBase): Is abstract.
11275 (ReturnParameter): New class for easier [return:] attribute handling.
11277 * typemanager.cs: Removed builder_to_attr.
11279 2004-05-11 Raja R Harinath <rharinath@novell.com>
11282 * attribute.cs (Attribute.GetPositionalValue): New function.
11283 * class.cs (TypeContainer.VerifyMembers): New function.
11284 (TypeContainer.Emit): Use it.
11285 (ClassOrStruct): New base class for Class and Struct.
11286 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
11287 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
11289 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
11290 then each non-static field should have a FieldOffset attribute.
11291 Otherwise, none of the fields should have a FieldOffset attribute.
11292 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
11293 and FieldOffset attributes.
11294 * typemanager.cs (TypeManager.struct_layout_attribute_type)
11295 (TypeManager.field_offset_attribute_type): New core types.
11296 (TypeManager.InitCoreTypes): Initialize them.
11298 2004-05-11 Michal Moskal <malekith@pld-linux.org>
11300 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
11301 Return correct type.
11304 2004-05-09 Miguel de Icaza <miguel@ximian.com>
11306 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
11307 be implicitly converted to ulong.
11309 * expression.cs: The logic for allowing operator &, | and ^ worked
11310 was wrong, it worked before because we did not report an error in
11311 an else branch. Fixes 57895.
11313 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
11314 allow volatile fields to be reference types.
11316 2004-05-07 Miguel de Icaza <miguel@ximian.com>
11318 * driver.cs: Add support for /debug-
11320 2004-05-07 Raja R Harinath <rharinath@novell.com>
11322 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
11323 Add a 'complain' parameter to silence errors.
11324 (Attribute.Resolve): Update to changes. Put in sanity check to catch
11325 silently overlooked type-resolutions.
11326 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
11327 to reflect changes.
11328 (Attributes.Search): New function.
11329 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
11330 (Attributes.GetAttributeFullName): Remove hack.
11331 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
11332 Update to reflect changes.
11333 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11334 Use Attributes.Search instead of nested loops.
11336 2004-05-07 Marek Safar <marek.safar@seznam.cz>
11339 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
11340 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
11341 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
11343 * report.cs: (Report.Warning): Renamed to Warning_T because of
11344 parameter collision.
11346 2004-05-05 Raja R Harinath <rharinath@novell.com>
11348 * expression.cs (MemberAccess.ResolveMemberAccess):
11349 Exit with non-zero status after Report.Error.
11350 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
11352 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
11354 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11356 * support.cs: Don't hang when the file is empty.
11358 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11360 * support.cs: In SeekableStreamReader, compute the preamble size of the
11361 underlying stream. Position changes should take into account that initial
11364 2004-05-03 Todd Berman <tberman@sevenl.net>
11366 * driver.cs: remove unused GetSysVersion function.
11368 2004-05-03 Todd Berman <tberman@sevenl.net>
11370 * driver.cs: Remove the hack from saturday, as well as the hack
11371 from jackson (LoadAssemblyFromGac), also adds the CWD to the
11372 link_paths to get that bit proper.
11374 2004-05-01 Todd Berman <tberman@sevenl.net>
11376 * driver.cs: Try a LoadFrom before a Load, this checks the current
11377 path. This is currently a bug in mono that is be fixed, however, this
11378 provides a workaround for now. This will be removed when the bug
11381 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
11383 * CryptoConvert.cs: Updated to latest version. Fix issue with
11384 incomplete key pairs (#57941).
11386 2004-05-01 Todd Berman <tberman@sevenl.net>
11388 * driver.cs: Remove '.' from path_chars, now System.* loads properly
11391 2004-04-30 Jackson Harper <jackson@ximian.com>
11393 * codegen.cs: Open keys readonly.
11395 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11397 * typemanager.cs: don't report cyclic struct layout when a struct
11398 contains 2 or more fields of the same type. Failed for Pango.AttrShape
11399 which has 2 Pango.Rectangle fields.
11401 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
11403 * expression.cs: Handle IntPtr comparisons with IL code
11404 rather than a method call.
11406 2004-04-29 Martin Baulig <martin@ximian.com>
11408 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
11409 the list of PropertyInfo's in class hierarchy and find the
11410 accessor. Fixes #56013.
11412 2004-04-29 Martin Baulig <martin@ximian.com>
11414 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
11416 2004-04-29 Martin Baulig <martin@ximian.com>
11418 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11420 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
11422 2004-04-29 Martin Baulig <martin@ximian.com>
11424 * class.cs (ConstructorInitializer.Resolve): Check whether the
11425 parent .ctor is accessible. Fixes #52146.
11427 2004-04-29 Martin Baulig <martin@ximian.com>
11429 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11431 * statement.cs (Using.EmitLocalVariableDecls): Use
11432 TypeManager.idisposable_type, not typeof (IDisposable).
11433 (Foreach.EmitCollectionForeach): Added support for valuetypes.
11435 2004-04-29 Martin Baulig <martin@ximian.com>
11437 * class.cs (Event.Define): Don't emit the field and don't set
11438 RTSpecialName and SpecialName for events on interfaces. Fixes
11441 2004-04-29 Raja R Harinath <rharinath@novell.com>
11443 Refactor Attribute.ApplyAttributes.
11444 * attribute.cs (Attributable): New base class for objects that can
11445 have Attributes applied on them.
11446 (Attribute): Make AttributeUsage fields public.
11447 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
11448 (Attribute.IsInternalCall): New property.
11449 (Attribute.UsageAttr): Convert to a public read-only property.
11450 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
11451 (Attribute.ResolveType, Attribute.Resolve)
11452 (Attribute.ScanForIndexerName): Update to reflect changes.
11453 (Attribute.CheckAttributeTarget): Re-format.
11454 (Attribute.ApplyAttributes): Refactor, to various
11455 Attributable.ApplyAttributeBuilder methods.
11456 * decl.cs (MemberCore): Make Attributable.
11457 * class.cs (Accessor): Make Attributable.
11458 (MethodData.ApplyAttributes): Use proper attribute types, not
11460 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
11461 (TypeContainer.ApplyAttributeBuilder)
11462 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
11463 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
11464 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
11465 (Operator.ApplyAttributeBuilder): New factored-out methods.
11466 * const.cs (Const.ApplyAttributeBuilder): Likewise.
11467 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
11468 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
11469 * parameter.cs (ParameterBase): New Attributable base class
11470 that can also represent Return types.
11471 (Parameter): Update to the changes.
11473 2004-04-29 Jackson Harper <jackson@ximian.com>
11475 * driver.cs: Prefer the corlib system version when looking for
11476 assemblies in the GAC. This is still a hack, but its a better hack
11479 2004-04-29 Marek Safar <marek.safar@seznam.cz>
11481 * decl.cs, enum.cs: Improved error 3005 reporting.
11483 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
11484 (related_symbols): New private member for list of symbols
11485 related to reported error/warning.
11487 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
11489 2004-04-29 Martin Baulig <martin@ximian.com>
11491 * ecore.cs (Expression.Constantify): If we're an enum and
11492 TypeManager.TypeToCoreType() doesn't give us another type, use
11493 t.UnderlyingSystemType. Fixes #56178.
11495 2004-04-29 Martin Baulig <martin@ximian.com>
11497 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
11498 interfaces and for each interface, only add members directly
11499 declared in that interface. Fixes #53255.
11501 2004-04-28 Martin Baulig <martin@ximian.com>
11503 * expression.cs (ConditionalLogicalOperator): Use a temporary
11504 variable for `left' to avoid that we evaluate it more than once;
11507 2004-04-28 Martin Baulig <martin@ximian.com>
11509 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
11512 2004-04-28 Martin Baulig <martin@ximian.com>
11514 * statement.cs (LocalInfo.Resolve): Check whether the type is not
11517 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
11518 whether the type is not void (CS1547).
11520 2004-04-28 Martin Baulig <martin@ximian.com>
11522 * expression.cs (Unary.DoResolveLValue): Override this and report
11523 CS0131 for anything but Operator.Indirection.
11525 2004-04-28 Martin Baulig <martin@ximian.com>
11527 Committing a patch from Ben Maurer; see bug #50820.
11529 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11532 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11535 2004-04-28 Martin Baulig <martin@ximian.com>
11537 Committing a patch from Ben Maurer; see bug #50820.
11539 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11542 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11545 2004-04-28 Martin Baulig <martin@ximian.com>
11547 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
11548 (Block.AddLabel): Call DoLookupLabel() to only search in the
11551 2004-04-28 Martin Baulig <martin@ximian.com>
11553 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11554 comparing StringConstants and NullLiterals in Equality and Inequality.
11556 2004-04-28 Jackson Harper <jackson@ximian.com>
11558 * driver.cs: Attempt to load referenced assemblies from the
11559 GAC. This is the quick and dirty version of this method that
11560 doesnt take into account versions and just takes the first
11561 canidate found. Will be good enough for now as we will not have more
11562 then one version installed into the GAC until I update this method.
11564 2004-04-28 Martin Baulig <martin@ximian.com>
11566 * typemanager.cs (TypeManager.CheckStructCycles): New public
11567 static method to check for cycles in the struct layout.
11569 * rootcontext.cs (RootContext.PopulateTypes): Call
11570 TypeManager.CheckStructCycles() for each TypeContainer.
11571 [Note: We only need to visit each type once.]
11573 2004-04-28 Martin Baulig <martin@ximian.com>
11575 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11577 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11578 success and added `out object value'. Use a `bool resolved' field
11579 to check whether we've already been called rather than
11580 `ConstantValue != null' since this breaks for NullLiterals.
11582 2004-04-28 Raja R Harinath <rharinath@novell.com>
11584 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11585 setting of this flag, since the 'set' method may be non-public.
11587 2004-04-28 Raja R Harinath <rharinath@novell.com>
11589 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11590 check on current_vector.Block.
11592 2004-04-27 Martin Baulig <martin@ximian.com>
11594 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11595 a field initializer. Fixes #56459.
11597 2004-04-27 Martin Baulig <martin@ximian.com>
11599 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11600 we're not attempting to use an indexer. Fixes #52154.
11602 2004-04-27 Martin Baulig <martin@ximian.com>
11604 * statement.cs (Return): Don't create a return label if we don't
11605 need it; reverts my change from January 20th. Thanks to Ben
11608 2004-04-27 Martin Baulig <martin@ximian.com>
11610 According to the spec, `goto' can only leave a nested scope, but
11613 * statement.cs (Block.LookupLabel): Only lookup in the current
11614 block, don't recurse into parent or child blocks.
11615 (Block.AddLabel): Check in parent and child blocks, report
11616 CS0140/CS0158 if we find a duplicate.
11617 (Block): Removed this indexer for label lookups.
11618 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11619 this already does the error reporting for us.
11622 (FlowBranching.UsageVector.Block): New public variable; may be null.
11623 (FlowBranching.CreateSibling): Added `Block' argument.
11624 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11625 label for the target of a `goto' and check whether we're not
11626 leaving a `finally'.
11628 2004-04-27 Martin Baulig <martin@ximian.com>
11630 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11631 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11634 2004-04-27 Martin Baulig <martin@ximian.com>
11636 * statement.cs (Block.AddLabel): Also check for implicit blocks
11637 and added a CS0158 check.
11639 2004-04-27 Martin Baulig <martin@ximian.com>
11641 * flowanalysis.cs (FlowBranchingLoop): New class.
11642 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11643 UsageVector's instead of an ArrayList.
11644 (FlowBranching.Label): Likewise.
11645 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11646 (FlowBranching.AddBreakVector): New method.
11648 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11650 * attribute.cs: Small regression fix: only convert the type if we
11651 the type is different, fixes System.Drawing build.
11653 2004-04-27 Martin Baulig <martin@ximian.com>
11655 * attribute.cs (Attribute.Resolve): If we have a constant value
11656 for a named field or property, implicity convert it to the correct
11659 2004-04-27 Raja R Harinath <rharinath@novell.com>
11661 * statement.cs (Block.Block): Implicit blocks share
11662 'child_variable_names' fields with parent blocks.
11663 (Block.AddChildVariableNames): Remove.
11664 (Block.AddVariable): Mark variable as "used by a child block" in
11665 every surrounding block.
11666 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11667 been used in a child block, complain about violation of "Invariant
11668 meaning in blocks" rule.
11669 * cs-parser.jay (declare_local_variables): Don't use
11670 AddChildVariableNames.
11671 (foreach_statement): Don't create an implicit block: 'foreach'
11672 introduces a scope.
11674 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11676 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11677 converting from 0L to ulong. Fixes 57522.
11679 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11681 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11682 derived class hides via 'new' keyword field from base class (test-242.cs).
11683 TODO: Handle this in the more general way.
11685 * class.cs (CheckBase): Ditto.
11687 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11689 * decl.cs (caching_flags): New member for storing cached values
11691 (MemberCore.Flags): New enum where bit flags for caching_flags
11693 (MemberCore.cls_compliance): Moved to caching_flags.
11694 (DeclSpace.Created): Moved to caching_flags.
11696 * class.cs: Use caching_flags instead of DeclSpace.Created
11698 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11700 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11701 if we are only a derived class, not a nested class.
11703 * typemanager.cs: Same as above, but do this at the MemberLookup
11704 level (used by field and methods, properties are handled in
11705 PropertyExpr). Allow for the qualified access if we are a nested
11708 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11710 * class.cs: Refactoring.
11711 (IMethodData): New inteface; Holds links to parent members
11712 to avoid member duplication (reduced memory allocation).
11713 (Method): Implemented IMethodData interface.
11714 (PropertyBase): New inner classes for get/set methods.
11715 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11716 (Event): New inner classes for add/remove methods.
11717 (Event.DelegateMethod): Implemented IMethodData interface.
11719 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11720 EmitContext (related to class.cs refactoring).
11722 2004-04-21 Raja R Harinath <rharinath@novell.com>
11724 * delegate.cs (Delegate.VerifyApplicability): If the number of
11725 arguments are the same as the number of parameters, first try to
11726 verify applicability ignoring any 'params' modifier on the last
11730 2004-04-08 Martin Baulig <martin@ximian.com>
11732 Merged latest changes into gmcs. Please keep this comment in
11733 here, it makes it easier for me to see what changed in MCS since
11734 the last time I merged.
11736 2004-04-16 Raja R Harinath <rharinath@novell.com>
11738 * class.cs (TypeContainer.AddIndexer): Use
11739 'ExplicitInterfaceName' to determine if interface name was
11740 explicitly specified. 'InterfaceType' is not initialized at this time.
11741 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11742 Indexers array is already in the required order. Initialize
11743 'IndexerName' only if there are normal indexers.
11744 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11745 (TypeContainer.Emit): Emit DefaultMember attribute only if
11746 IndexerName is initialized.
11749 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11751 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11754 2004-04-15 Raja R Harinath <rharinath@novell.com>
11756 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11760 * attribute.cs (Attribute.Resolve): Check for duplicate named
11764 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11766 * iterators.cs (MarkYield): track whether we are in an exception,
11767 and generate code accordingly. Use a temporary value to store the
11768 result for our state.
11770 I had ignored a bit the interaction of try/catch with iterators
11771 since their behavior was not entirely obvious, but now it is
11772 possible to verify that our behavior is the same as MS .NET 2.0
11776 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11778 * iterators.cs: Avoid creating temporaries if there is no work to
11781 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11782 Enumerations, use TypeManager.EnumToUnderlying and call
11785 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11788 (This.Emit): Use EmitContext.EmitThis to emit our
11791 (This.EmitAssign): Ditto.
11793 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11794 codepaths, we will move all the functionality into
11797 (FieldExpr.EmitAssign): Ditto.
11799 This fixes several hidden bugs that I uncovered while doing a code
11800 review of this today.
11802 * codegen.cs (EmitThis): reworked so the semantics are more clear
11803 and also support value types "this" instances.
11805 * iterators.cs: Changed so that for iterators in value types, we
11806 do not pass the value type as a parameter.
11808 Initialization of the enumerator helpers is now done in the caller
11809 instead of passing the parameters to the constructors and having
11810 the constructor set the fields.
11812 The fields have now `assembly' visibility instead of private.
11814 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11816 * expression.cs (Argument.Resolve): Check if fields passed as ref
11817 or out are contained in a MarshalByRefObject.
11819 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11820 another compiler type.
11822 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11824 * class.cs (Indexer.Define): use the new name checking method.
11825 Also, return false on an error.
11826 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11827 (is_identifier_[start/part]_character): make static.
11829 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11831 * expression.cs (Binary.ResolveOperator): Do no append strings
11832 twice: since we can be invoked more than once (array evaluation)
11833 on the same concatenation, take care of this here. Based on a fix
11834 from Ben (bug #56454)
11836 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11838 * codegen.cs: Fix another case where CS1548 must be reported (when
11839 delay-sign isn't specified and no private is available #56564). Fix
11840 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11841 error when MCS is used on the MS runtime and we need to delay-sign
11842 (which seems unsupported by AssemblyBuilder - see #56621).
11844 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11846 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11847 (TypeManager.ComputeNamespaces): Faster implementation for
11850 * compiler.csproj: Updated AssemblyName to mcs.
11852 2004-05-11 Jackson Harper <jackson@ximian.com>
11854 * Makefile: Preserve MONO_PATH
11856 2004-05-11 Jackson Harper <jackson@ximian.com>
11858 * Makefile: Use mono and mcs to build gmcs
11860 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11862 * codegen.cs: Add patch from Robert Shade
11863 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11866 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11868 * CryptoConvert.cs: Updated to latest version. Fix issue with
11869 incomplete key pairs (#57941).
11871 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11873 * codegen.cs: Fix another case where CS1548 must be reported (when
11874 delay-sign isn't specified and no private is available #56564). Fix
11875 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11876 error when MCS is used on the MS runtime and we need to delay-sign
11877 (which seems unsupported by AssemblyBuilder - see #56621).
11879 2004-04-29 Jackson Harper <jackson@ximian.com>
11881 * Makefile: Set MONO_PATH to use the bootstrap corlib
11882 * driver.cs: Check the GAC for referenced assemblies.
11884 2004-04-29 Martin Baulig <martin@ximian.com>
11886 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11888 2004-04-07 Martin Baulig <martin@ximian.com>
11890 * expression.cs (Binary.ResolveOperator): Added special case for
11891 Equality/Inequality between a type parameter and a null literal.
11893 2004-04-07 Martin Baulig <martin@ximian.com>
11895 * convert.cs: Check null literal -> type parameter conversions.
11897 2004-04-07 Martin Baulig <martin@ximian.com>
11899 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11900 `class' and `struct' constraints.
11902 2004-04-07 Martin Baulig <martin@ximian.com>
11904 * generic.cs (SpecialConstraint): New public enum.
11905 (Constraints.Resolve): Added support for the `class' and `struct'
11908 * cs-parser.jay (type_parameter_constraint): Added support for the
11909 `class' and `struct' constraints.
11911 2004-04-07 Martin Baulig <martin@ximian.com>
11913 * support.cs (GenericConstraints): Replaced `Types' by
11914 `ClassConstraint' and `InterfaceConstraints'; added
11915 `HasClassConstraint'.
11917 2004-04-07 Martin Baulig <martin@ximian.com>
11920 (Constraints.InterfaceConstraints): New public property.
11921 (Constraints.Types): Make this property public
11922 (TypeParameter): Implement IMemberContainer.
11923 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
11924 instead of a TypeBuilder/MethodBuilder; pass the interface
11925 constraints to TypeManager.AddTypeParameter().
11926 (TypeParameter.DefineType): Just take an EmitContext and no
11927 TypeBuilder/MethodBuilder. Use the new public API.
11929 * typemanager.cs (TypeManager.AddTypeParameter): Added
11930 `TypeExpr[]' argument; add the interfaces to the
11931 `builder_to_ifaces' hash.
11932 (TypeManager.LookupMemberContainer): For
11933 GenericTypeParameterBuilders, get the TypeParameter from the
11934 `builder_to_type_param'.
11935 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
11936 the TypeParameter and call FindMembers on it.
11938 2004-04-07 Martin Baulig <martin@ximian.com>
11941 (MethodCore.GenericMethod): Moved this field here from Method.
11942 (MethodCore.IsDuplicateImplementation): Take the number of type
11943 parameters into account if we're a generic method.
11945 * expression.cs (Invocation.InferTypeArguments): Don't return true
11946 if `arguments' is null; we still need to check whether we actually
11947 don't need to infer anything in this case.
11948 (MemberAccess): Merged the functionality from GenericMemberAccess
11951 * generic.cs (GenericMemberAccess): Removed.
11953 2004-04-05 Martin Baulig <martin@ximian.com>
11955 * decl.cs (MemberCore): For generic classes, interfaces and
11956 structs, `Name' now includes the number of type parameters
11957 ("Stack!1.Node!1").
11958 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
11959 encode the number of type arguments in the type name.
11961 * expression.cs (Expression.MemberLookup): Removed the
11962 `num_type_args' argument; we now encode the number of type
11963 arguments in the type name.
11965 * ecore.cs (SimpleName): Encode the number of type arguments in
11966 the type name itself.
11968 * generic.cs (ConstructedType): Likewise.
11970 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
11971 `MemberName'; we now include the number of type parameters in the
11974 * typemanager.cs (TypeManager.CheckGeneric): Removed.
11975 (TypeManager.MemberLookup): Removed the
11976 `num_type_args' argument; we now encode the number of type
11977 arguments in the type name.
11979 2004-04-03 Martin Baulig <martin@ximian.com>
11981 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
11982 (MemberCore.MemberName): Moved here from MemberBase.
11983 (DeclSpace.SetParameterInfo): Just take the constraints as an
11984 ArrayList; we already have the type parameters in our
11985 `MemberName'; also do the CS0080 reporting here.
11987 * cs-parser.jay (struct_declaration): Use `member_name' instead of
11988 `IDENTIFIER opt_type_parameter_list'; when constructing our
11989 `MemberName', it'll already include our type parameters.
11990 (class_declaration, interface_declaration): Likewise.
11991 (delegate_declaration): Likewise.
11992 (MakeName): Take a MemberName and return a MemberName.
11993 The following two changes are required to avoid shift/reduce conflicts:
11994 (member_name): Don't include a TypeName anymore; ie. this is now
11995 just 'IDENTIFIER opt_type_parameter_list'.
11996 (property_declaration, event_declaration): Use a
11997 `namespace_or_type_name' instead of a `member_name'.
11999 2004-04-03 Martin Baulig <martin@ximian.com>
12001 * decl.cs (MemberName): Renamed to `TypeName' and created a new
12002 `MemberName' class.
12003 (TypeName): Formerly known as MemberName.
12005 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
12006 instead of a `MemberName'.
12008 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
12009 (member_name): New rule; create a MemberName.
12011 2004-04-02 Martin Baulig <martin@ximian.com>
12013 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
12014 (CS0305 and CS0308).
12016 2004-04-02 Martin Baulig <martin@ximian.com>
12018 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
12019 support for nested types.
12021 2004-04-02 Martin Baulig <martin@ximian.com>
12023 * ecore.cs (IAlias): New public interface.
12024 (TypeExpr, TypeExpression): Implement IAlias.
12025 (TypeAliasExpression): New public class.
12027 * namespace.cs (Namespace): Implement IAlias.
12028 (Namespace.Lookup): Return an IAlias instead on an object.
12029 (Namespace.DefineName): Take an IAlias instead of an object.
12030 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
12032 (NamespaceEntry.UsingAlias): Take a Membername instead of an
12034 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
12036 (NamespaceEntry.Lookup): Likewise.
12038 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
12041 * decl.cs (DeclSpace): Implement IAlias.
12042 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
12044 * generic.cs (ConstructedType): Improved error checking.
12046 2004-04-02 Martin Baulig <martin@ximian.com>
12048 * convert.cs: Added type parameter conversions.
12051 (UnboxCast.Emit): Emit an `unbox.any' for type params.
12052 (ClassCast.Emit): If the source type is a type parameter, box it.
12053 If the target type is a type parameter, emit an `unbox.any'
12054 instead of a `classcast'.1
12056 2004-04-01 Martin Baulig <martin@ximian.com>
12058 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
12060 2004-04-01 Martin Baulig <martin@ximian.com>
12062 * generic.cs (ConstructedType.CheckConstraints): Use
12063 Convert.ImplicitStandardConversionExists(); user-defined implicit
12064 conversions are not allowed according to the spec.
12066 2004-03-30 Martin Baulig <martin@ximian.com>
12068 * expression.cs (New): Added support for type parameters.
12071 (TypeManager.activator_type): New public static field.
12072 (TypeManager.activator_create_instance): Likewise.
12074 2004-03-30 Martin Baulig <martin@ximian.com>
12076 * typemanager.cs (TypeManager.HasConstructorConstraint): New
12079 2004-03-30 Martin Baulig <martin@ximian.com>
12081 * generic.cs (ConstructedType.CheckConstraints): Actually follow
12082 the spec here: the argument type must be convertible to the
12085 2004-03-30 Martin Baulig <martin@ximian.com>
12088 (TypeParameter.Define, TypeParameter.DefineMethod): Call
12089 TypeManager.AddTypeParameter().
12090 (ConstructedType.CheckConstraints): Re-enable this and actually
12091 check whether we have a constructor constraint.
12094 (TypeManager.builder_to_type_param): New static field.
12095 (TypeManager.AddTypeParameter): New static method.
12096 (TypeManager.LookupTypeParameter): New public method.
12098 2004-03-30 Martin Baulig <martin@ximian.com>
12100 * generic.cs (TypeParameter.DefineType): Return a boolean and use
12101 the new API to actually define the constructor constraint.
12104 (TypeManager.new_constraint_attr_type): New static field.
12105 (TypeManager.InitCoreTypes): Initialize it.
12107 2004-03-30 Martin Baulig <martin@ximian.com>
12109 * generic.cs (Constraints): Completed error checking, use correct
12112 2004-03-29 Martin Baulig <martin@ximian.com>
12114 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
12116 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12117 public version which takes a `ParameterData pd' instead of an
12120 2004-03-29 Martin Baulig <martin@ximian.com>
12122 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
12125 2004-03-29 Martin Baulig <martin@ximian.com>
12127 * expression.cs (Argument.ResolveMethodGroup): If we're a
12128 ConstructedType, call GetMemberAccess() on it.
12130 2004-03-29 Martin Baulig <martin@ximian.com>
12132 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
12133 (MethodCore.CheckGenericOverride): When overriding a generic
12134 method, check whether the constraints match.
12136 * support.cs (GenericConstraints): New public interface.
12137 (ParameterData.GenericConstraints): New public method.
12139 * parameter.cs (Parameter.Resolve): Check whether we're a generic
12140 method parameter and compute our constraints if appropriate.
12141 (Parameter.GenericConstraints): New public property.
12143 * generic.cs (Constraints): Implement GenericConstraints.
12145 2004-03-29 Martin Baulig <martin@ximian.com>
12147 * decl.cs (MemberCache.FindMemberToOverride): Use
12148 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
12150 2004-03-29 Martin Baulig <martin@ximian.com>
12152 * generic.cs (GenericMethod.Define): Resolve our type parameters.
12154 2004-03-29 Martin Baulig <martin@ximian.com>
12156 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
12157 not allowed on non-generic declarations").
12159 2004-03-29 Martin Baulig <martin@ximian.com>
12161 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12162 public version of this method.
12164 * class.cs (MethodCore.IsDuplicateImplementation): Use
12165 Invocation.InferTypeArguments() to check this.
12167 2004-03-29 Martin Baulig <martin@ximian.com>
12169 * convert.cs: Use TypeManager.IsDelegateType() instead of
12170 comparing types correctly.
12172 2004-03-29 Martin Baulig <martin@ximian.com>
12174 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
12175 types directly to make it work for generic instances.
12177 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
12179 2004-03-29 Martin Baulig <martin@ximian.com>
12181 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
12182 support for arrays.
12184 2004-03-24 Martin Baulig <martin@ximian.com>
12186 * decl.cs (DeclSpace.FindType): Also use
12187 TypeManager.CheckGeneric() for types from the using clauses.
12189 2004-03-23 Martin Baulig <martin@ximian.com>
12191 * expression.cs (Invocation.OverloadResolve): Added `bool
12192 may_fail' argument and use it instead of the Location.IsNull() hack.
12194 2004-03-23 Martin Baulig <martin@ximian.com>
12196 * expression.cs (Invocation.InferType): Use correct type inference
12199 2004-03-23 Martin Baulig <martin@ximian.com>
12201 * ecore.cs (MethodGroupExpr.Name): Use
12202 TypeManager.CSharpSignature() instead of just the name.
12204 * expression.cs (Invocation.OverloadResolve): Provide better error
12206 (Invocation.DoResolve): OverloadResolve() never returns null
12207 without reporting an error, so removed the error -6 reporting here.
12209 2004-03-23 Martin Baulig <martin@ximian.com>
12211 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
12214 * cs-parser.jay (delegate_declaration): Support generic delegates.
12216 * delegate.cs: Support generic delegates.
12218 2004-03-22 Martin Baulig <martin@ximian.com>
12220 * expression.cs (Invocation.InferParamsTypeArguments): New static
12221 method; does type inference for params arguments.
12223 2004-03-21 Martin Baulig <martin@ximian.com>
12225 * typemanager.cs (TypeManager.IsGenericMethod): New public static
12226 method; checks whether a method is a generic method.
12228 * expression.cs (Invocation.InferTypeArguments): New static method;
12229 infer type arguments for generic method invocation.
12231 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
12232 property; we set this to true if we're resolving a generic method
12233 invocation and the user specified type arguments, ie. we're not
12234 doing type inference.
12236 2004-03-20 Martin Baulig <martin@ximian.com>
12238 * class.cs (MethodData.DeclaringType): New public property.
12239 (MethodData.Define): Set DeclaringType here.
12240 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
12241 instead of OperatorMethodBuilder.DeclaringType.
12243 2004-03-20 Martin Baulig <martin@ximian.com>
12245 * cs-tokenizer.cs (xtoken): Return a special
12246 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
12248 * cs-parser.jay (default_value_expression): Switch to the new
12251 2004-03-19 Martin Baulig <martin@ximian.com>
12253 * decl.cs (MemberName): New class. We use this to "construct"
12254 namespace_or_type_name's.
12256 * generics.cs (TypeArguments.GetDeclarations): New public method;
12257 returns the type arguments as a string[] and reports a CS0081 if
12258 one of them is not an identifier.
12260 * class.cs (MemberBase): The .ctor now takes the name as a
12261 MemberName instead of a string.
12262 (MemberBase.ExplicitInterfaceName): Changed type from string to
12264 (MemberBase.DoDefine): If we're an explicit implementation, the
12265 InterfaceType may be a generic instance.
12267 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
12268 (namespace_name): Call MemberName.GetName () to transform the
12269 MemberName into a string and ensure we don't have any type
12271 (type_name): Call MemberName.GetTypeExpression() to transfrom the
12272 MemberName into an expression.
12273 (method_header): Use namespace_or_type_name instead of member_name.
12275 2004-04-07 Miguel de Icaza <miguel@ximian.com>
12277 * rootcontext.cs: Add new types to the boot resolution.
12279 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
12280 MulticastDelegate is not allowed.
12282 * typemanager.cs: Add new types to lookup: System.TypedReference
12285 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
12286 check for TypedReference or ArgIterator, they are not allowed.
12288 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
12289 makes us properly catch 1510 in some conditions (see bug 56016 for
12292 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
12294 * CryptoConvert.cs: update from corlib version
12297 2004-04-05 Miguel de Icaza <miguel@ximian.com>
12299 * class.cs (Indexer.Define): Check indexername declaration
12301 2004-04-05 Marek Safar <marek.safar@seznam.cz>
12303 * attribute.cs (IsClsCompliant): Fixed problem with handling
12304 all three states (compliant, not-compliant, undetected).
12306 2004-03-30 Marek Safar <marek.safar@seznam.cz>
12308 * attribute.cs (Attribute): Location is now public.
12309 (Resolve): Store resolved arguments (pos_values) in attribute class.
12310 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
12311 (GetClsCompliantAttributeValue): New method that gets
12312 CLSCompliantAttribute value.
12313 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
12314 if exists else null.
12315 (AttributeTester): New class for CLS-Compliant verification routines.
12317 * class.cs (Emit): Add CLS-Compliant verification.
12318 (Method.GetSignatureForError): Implemented.
12319 (Constructor.GetSignatureForError): Implemented
12320 (Constructor.HasCompliantArgs): Returns if constructor has
12321 CLS-Compliant arguments.
12322 (Constructor.Emit): Override.
12323 (Construcor.IsIdentifierClsCompliant): New method; For constructors
12324 is needed to test only parameters.
12325 (FieldBase.GetSignatureForError): Implemented.
12326 (TypeContainer): New member for storing base interfaces.
12327 (TypeContainer.FindMembers): Search in base interfaces too.
12329 * codegen.cs (GetClsComplianceAttribute): New method that gets
12330 assembly or module CLSCompliantAttribute value.
12331 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
12333 (ModuleClass.Emit): Add error 3012 test.
12335 * const.cs (Emit): Override and call base for CLS-Compliant tests.
12337 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
12338 state for all decl types.
12339 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
12340 if CLS-Compliant tests are required.
12341 (IsClsCompliaceRequired): New method. Analyze whether code
12342 must be CLS-Compliant.
12343 (IsExposedFromAssembly): New method. Returns true when MemberCore
12344 is exposed from assembly.
12345 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
12346 value or gets cached value.
12347 (HasClsCompliantAttribute): New method. Returns true if MemberCore
12348 is explicitly marked with CLSCompliantAttribute.
12349 (IsIdentifierClsCompliant): New abstract method. This method is
12350 used to testing error 3005.
12351 (IsIdentifierAndParamClsCompliant): New method. Common helper method
12352 for identifier and parameters CLS-Compliant testing.
12353 (VerifyClsCompliance): New method. The main virtual method for
12354 CLS-Compliant verifications.
12355 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
12356 null. I don't know why is null (too many public members !).
12357 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
12358 and get value of first CLSCompliantAttribute that found.
12360 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
12361 (VerifyClsCompliance): Override and add extra tests.
12363 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
12364 clscheck- disable CLS-Compliant verification event if assembly is has
12365 CLSCompliantAttribute(true).
12367 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
12368 ApllyAttribute is now called in emit section as in the other cases.
12369 Possible future Emit integration.
12370 (IsIdentifierClsCompliant): New override.
12371 (VerifyClsCompliance): New override.
12372 (GetEnumeratorName): Returns full enum name.
12374 * parameter.cs (GetSignatureForError): Implemented.
12376 * report.cs (WarningData): New struct for Warning message information.
12377 (LocationOfPreviousError): New method.
12378 (Warning): New method. Reports warning based on the warning table.
12379 (Error_T): New method. Reports error based on the error table.
12381 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
12382 verifications are done here.
12384 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
12386 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
12387 CLSCompliantAttribute.
12388 (all_imported_types): New member holds all imported types from other
12390 (LoadAllImportedTypes): New method fills static table with exported types
12391 from all referenced assemblies.
12392 (Modules): New property returns all assembly modules.
12394 2004-03-30 Miguel de Icaza <miguel@ximian.com>
12396 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
12397 throwing a parser error.
12399 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
12400 which removes the hardcoded get_/set_ prefixes for properties, as
12401 IL allows for the properties to be named something else.
12405 * expression.cs: Do not override operand before we know if it is
12406 non-null. Fix 56207
12408 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12410 * typemanager.cs: support for pinned variables.
12412 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12414 * decl.cs, typemanager.cs: Avoid using an arraylist
12415 as a buffer if there is only one result set.
12417 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12419 * expression.cs: Make sure you cant call a static method
12420 with an instance expression, bug #56174.
12422 2004-03-29 Miguel de Icaza <miguel@ximian.com>
12424 * class.cs (IsDuplicateImplementation): Improve error reporting to
12425 flag 663 (method only differs in parameter modifier).
12427 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
12428 in preprocessor directives.
12430 * location.cs (LookupFile): Allow for the empty path.
12432 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
12433 better approach for some of that patch, but its failing with the
12434 CharSet enumeration. For now try/catch will do.
12436 * typemanager.cs: Do not crash if a struct does not have fields.
12439 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12441 * expression.cs: cs0213, cant fix a fixed expression.
12444 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12446 * cs-parser.jay: detect invalid embeded statements gracefully.
12449 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12451 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
12454 the invocation type may not be a subclass of the tye of the item/
12455 The type of the item must be a subclass of the invocation item.
12460 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
12462 * attribute.cs: Added methods to get a string and a bool from an
12463 attribute. Required to information from AssemblyKeyFileAttribute,
12464 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
12465 * codegen.cs: Modified AssemblyName creation to include support for
12466 strongnames. Catch additional exceptions to report them as CS1548.
12467 * compiler.csproj: Updated include CryptoConvert.cs.
12468 * compiler.csproj.user: Removed file - user specific configuration.
12469 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
12470 Mono.Security assembly. The original class is maintained and tested in
12471 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
12472 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
12473 like CSC 8.0 (C# v2) supports.
12474 * Makefile: Added CryptoConvert.cs to mcs sources.
12475 * rootcontext.cs: Added new options for strongnames.
12477 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
12479 * driver.cs: For --expect-error, report error code `2'
12480 if the program compiled with no errors, error code `1' if
12481 it compiled with an error other than the one expected.
12483 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
12485 * compiler.csproj: Updated for Visual Studio .NET 2003.
12486 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
12487 * compiler.sln: Updated for Visual Studio .NET 2003.
12489 2004-03-24 Ravi Pratap M <ravi@ximian.com>
12491 * expression.cs: Fix bug #47234. We basically need to apply the
12492 rule that we prefer the conversion of null to a reference type
12493 when faced with a conversion to 'object' (csc behaviour).
12495 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12497 * statement.cs: Shorter form for foreach, eliminates
12498 a local variable. r=Martin.
12500 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12502 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
12503 checks if we can use brtrue/brfalse to test for 0.
12504 * expression.cs: use the above in the test for using brtrue/brfalse.
12505 cleanup code a bit.
12507 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12509 * expression.cs: Rewrite string concat stuff. Benefits:
12511 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
12512 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
12513 rather than a concat chain.
12515 * typemanager.cs: Add lookups for more concat overloads.
12517 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12519 * expression.cs: Emit shorter il code for array init.
12536 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
12538 * statement.cs: Before, two switch blocks would be merged if the
12539 total size of the blocks (end_item - begin_item + 1) was less than
12540 two times the combined sizes of the blocks.
12542 Now, it will only merge if after the merge at least half of the
12547 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
12549 * class.cs : csc build fix for GetMethods(). See bug #52503.
12551 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12553 * expression.cs: Make sure fp comparisons work with NaN.
12554 This fixes bug #54303. Mig approved this patch a long
12555 time ago, but we were not able to test b/c the runtime
12558 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12560 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12562 2004-03-19 Martin Baulig <martin@ximian.com>
12564 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12565 two overloads may unify for some type parameter substitutions and
12566 report a CS0408 if appropriate.
12568 2004-03-19 Martin Baulig <martin@ximian.com>
12570 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12571 error here and not in our caller.
12573 2004-03-19 Martin Baulig <martin@ximian.com>
12575 * interface.cs: Completely killed this file.
12576 (Interface): We're now a TypeContainer and live in class.cs.
12578 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12579 argument; we're now also called for interfaces.
12580 (TypeContainer.DefineMembers): Allow this method being called
12582 (TypeContainer.GetMethods): New public method; formerly known as
12583 Interface.GetMethod(). This is used by PendingImplementation.
12584 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12585 it's now private and non-static.
12586 (Interface): Moved this here; it's now implemented similar to
12588 (Method, Property, Event, Indexer): Added `bool is_interface'
12589 argument to their .ctor's.
12590 (MemberBase.IsInterface): New public field.
12592 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12593 instances instead of InterfaceMethod, InterfaceProperty, etc.
12594 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12595 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12597 2004-03-19 Martin Baulig <martin@ximian.com>
12599 * class.cs (MethodCore.IsDuplicateImplementation): New private
12600 method which does the CS0111 checking.
12601 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12602 Use IsDuplicateImplementation().
12604 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12606 * decl.cs (FindMemberToOverride): New method to find the correct
12607 method or property to override in the base class.
12609 - Make Method/Property use the above method to find the
12610 version in the base class.
12611 - Remove the InheritableMemberSignatureCompare as it is now
12614 This patch makes large code bases much faster to compile, as it is
12615 O(n) rather than O(n^2) to do this validation.
12617 Also, it fixes bug 52458 which is that nested classes are not
12618 taken into account when finding the base class member.
12620 Reviewed/Approved by Martin.
12622 2004-03-17 Martin Baulig <martin@ximian.com>
12624 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12625 of type arguments into account; use the `real_num_type_args'
12626 approach like in DoResolveAsTypeStep().
12628 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12631 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12633 * interface.cs: In all interface classes removed redundant
12634 member initialization.
12636 2004-03-16 Martin Baulig <martin@ximian.com>
12638 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12640 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12642 * decl.cs (DefineTypeAndParents): New helper method to define a
12643 type's containers before the type itself is defined; This is a
12644 bug exposed by the recent changes to Windows.Forms when an
12645 implemented interface was defined inside a class that had not been
12648 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12650 (Check): Loop correctly to report errors modifiers
12651 (UNSAFE was not in the loop, since it was the same as TOP).
12653 * interface.cs: Every interface member now takes a ModFlags,
12654 instead of a "is_new" bool, which we set on the base MemberCore.
12656 Every place where we called "UnsafeOk" in the interface, now we
12657 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12658 the unsafe settings from the member declaration instead of the
12659 container interface.
12661 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12663 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12664 `set_indexer_name' to the pending bits (one per type).
12666 We fixed a bug today that was picking the wrong method to
12667 override, since for properties the existing InterfaceMethod code
12668 basically ignored the method name. Now we make sure that the
12669 method name is one of the valid indexer names.
12671 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12673 * support.cs (SeekableStreamReader): Keep track of stream byte
12674 positions and don't mix them with character offsets to the buffer.
12676 Patch from Gustavo Giráldez
12678 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12680 * interface.cs (InterfaceSetGetBase): Removed double member
12681 initialization, base class does it as well.
12683 2004-03-13 Martin Baulig <martin@ximian.com>
12685 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12686 when compiling corlib.
12688 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12690 * convert.cs (ExplicitConversion): We were reporting an error on
12691 certain conversions (object_type source to a value type, when the
12692 expression was `null') before we had a chance to pass it through
12693 the user defined conversions.
12695 * driver.cs: Replace / and \ in resource specifications to dots.
12698 * class.cs: Add check for duplicate operators. Fixes 52477
12700 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12702 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12703 that are in the middle of the statements, not only at the end.
12706 * class.cs (TypeContainer.AddField): No longer set the
12707 `HaveStaticConstructor' flag, now we call it
12708 `UserDefineStaticConstructor' to diferentiate the slightly
12709 semantic difference.
12711 The situation is that we were not adding BeforeFieldInit (from
12712 Modifiers.TypeAttr) to classes that could have it.
12713 BeforeFieldInit should be set to classes that have no static
12718 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12720 And most importantly Zoltan's comment:
12722 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12724 "I think beforefieldinit means 'it's ok to initialize the type sometime
12725 before its static fields are used', i.e. initialization does not need
12726 to be triggered by the first access to the type. Setting this flag
12727 helps the JIT to compile better code, since it can run the static
12728 constructor at JIT time, and does not need to generate code to call it
12729 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12730 this flag for lots of classes like String.
12732 csc sets this flag if the type does not have an explicit static
12733 constructor. The reasoning seems to be that if there are only static
12734 initalizers for a type, and no static constructor, then the programmer
12735 does not care when this initialization happens, so beforefieldinit
12738 This bug prevents the AOT compiler from being usable, since it
12739 generates so many calls to mono_runtime_class_init that the AOT code
12740 is much slower than the JITted code. The JITted code is faster,
12741 because it does not generate these calls if the vtable is type is
12742 already initialized, which is true in the majority of cases. But the
12743 AOT compiler can't do this."
12745 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12747 * class.cs (MethodData.Emit): Refactor the code so symbolic
12748 information is generated for destructors; For some reasons we
12749 were taking a code path that did not generate symbolic information
12752 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12754 * class.cs: Create a Constructor.CheckBase method that
12755 takes care of all validation type code. The method
12756 contains some code that was moved from Define.
12758 It also includes new code that checks for duplicate ctors.
12759 This fixes bug #55148.
12761 2004-03-09 Joshua Tauberer <tauberer@for.net>
12763 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12764 a { ... }-style array creation invokes EmitStaticInitializers
12765 which is not good for reference-type arrays. String, decimal
12766 and now null constants (NullCast) are not counted toward
12767 static initializers.
12769 2004-03-05 Martin Baulig <martin@ximian.com>
12771 * location.cs (SourceFile.HasLineDirective): New public field;
12772 specifies whether the file contains or is referenced by a "#line"
12774 (Location.DefineSymbolDocuments): Ignore source files which
12775 either contain or are referenced by a "#line" directive.
12777 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12779 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12780 direct access to our parent, so check the method inline there.
12782 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12784 * expression.cs (Invocation.EmitCall): Miguel's last commit
12785 caused a regression. If you had:
12790 In Foo the implict this would be null.
12792 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12794 * expression.cs (Invocation.EmitCall): If the method is not
12795 virtual, do not emit a CallVirt to it, use Call.
12797 * typemanager.cs (GetFullNameSignature): Improve the method to
12798 cope with ".ctor" and replace it with the type name.
12800 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12801 as an argument the ConstructorBuilder where it is being defined,
12802 to catch the recursive constructor invocations.
12804 2004-03-16 Martin Baulig <martin@ximian.com>
12806 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12807 ConstructedType, call ResolveType() on it to get the type rather
12808 than just using `expr.Type'.
12810 2004-03-16 Martin Baulig <martin@ximian.com>
12812 * generics.cs (ConstructedType.GetMemberAccess): Take the
12813 EmitContext instead on the TypeExpr and use
12814 ec.TypeContainer.CurrentType/ec.ContainerType.
12816 2004-03-16 Martin Baulig <martin@ximian.com>
12818 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12819 parameters before aliases.
12821 2004-03-16 Martin Baulig <martin@ximian.com>
12823 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12824 New oublic function; checks whether two generic instances may become
12825 equal under some instantiations (26.3.1).
12827 * class.cs (TypeContainer.Define): Call
12828 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12831 2004-03-16 Martin Baulig <martin@ximian.com>
12833 * class.cs (TypeContainer.GetClassBases): Moved
12834 Error_TypeParameterAsBase() here and also check whether the base
12835 class is not an attribute.
12837 2004-03-16 Martin Baulig <martin@ximian.com>
12839 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12841 2004-03-16 Martin Baulig <martin@ximian.com>
12843 * class.cs (Error_TypeParameterAsBase): Use correct error number
12846 2004-03-16 Martin Baulig <martin@ximian.com>
12848 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12851 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12854 2004-03-15 Martin Baulig <martin@ximian.com>
12856 * typemanager.cs (TypeManager.GetFullName): New public method.
12857 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12858 argument; only return members with the correct number of type
12860 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12861 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12862 whether the number of type arguments matches.
12864 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12865 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12867 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12868 field; it's set by the protected .ctor when we're actually a
12869 GenericMemberAccess.
12870 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12871 arguments and pass it to MemberLookupFinal ().
12873 * ecore.cs (Expression.MemberLookup): Added `int
12874 num_type_arguments' argument; only return members with the correct
12875 number of type arguments.
12876 (Expression.MemberLookupFailed): Check whether the MemberLookup
12877 failed because we did not have the correct number of type
12878 arguments; report CS0305 in this case.
12880 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12881 `e.ResolveAsTypeTerminal()' already did so.
12883 2004-03-15 Martin Baulig <martin@ximian.com>
12885 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12886 we're a ConstructedType; in this case, the caller must report an
12887 error (for instance CS0131).
12889 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12890 (TypeArguments.Resolve): Actually report errors here.
12892 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12894 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12895 `set_indexer_name' to the pending bits (one per type).
12897 We fixed a bug today that was picking the wrong method to
12898 override, since for properties the existing InterfaceMethod code
12899 basically ignored the method name. Now we make sure that the
12900 method name is one of the valid indexer names.
12902 2004-03-15 Martin Baulig <martin@ximian.com>
12904 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12905 for generic instances.
12907 2004-03-13 Martin Baulig <martin@ximian.com>
12909 * class.cs (TypeContainer.DefineType): Call
12910 TypeManager.AddUserType() immediately after creating the
12911 TypeBuilder; pass all type parameters when creating the
12914 * decl.cs (DeclSpace.FindNestedType): New public method.
12915 (DeclSpace.FindType): Added `int num_type_args' argument; only
12916 return types with the correct number of type parameters.
12917 (DeclSpace.CountTypeParams): New public property.
12919 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
12920 the number of type parameters; defaults to zero.
12922 * generic.cs (TypeArguments.Count): New public property.
12923 (ConstructedType.DoResolveAsTypeStep): First call
12924 ds.FindNestedType() to find out whether we're nested in the
12925 current generic type; in this case, we inherit all type parameters
12926 from the current class.
12928 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
12929 num_type_args' argument.
12930 (RootContext.LookupType): Added overloaded version which takes the
12931 number of type arguments; only return types with the correct
12932 number of type arguments.
12934 * typemanager.cs (TypeManager.CheckGeneric): New public function;
12935 checks whether `Type t' has `int num_type_args'.
12937 2004-03-13 Martin Baulig <martin@ximian.com>
12939 * generic.cs (GenericMethod.DefineType): New method; calls
12940 DefineType() on all the type parameters.
12942 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
12943 (MethodData.Define): If we're a generic method, call
12944 GenericMethod.DefineType() to define the type parameters.
12946 2004-03-10 Martin Baulig <martin@ximian.com>
12948 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
12949 instead of IsAssignableFrom.
12951 2004-03-10 Martin Baulig <martin@ximian.com>
12953 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
12955 * support.cs (ParameterData.HasArrayParameter): New property.
12956 (ReflectionParameters.ctor): Take a MethodBase instead of a
12957 ParameterInfo[]. If we have any type parameters, get the generic
12958 method definition and ask it whether we have variable arguments.
12960 2004-02-26 Miguel de Icaza <miguel@ximian.com>
12962 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
12963 routines to check if a type is an enumerable/enumerator allow
12964 classes that implement the IEnumerable or IEnumerator interfaces.
12966 * class.cs (Property, Operator): Implement IIteratorContainer, and
12967 implement SetYields.
12969 (Property.Define): Do the block swapping for get_methods in the
12970 context of iterators. We need to check if Properties also
12971 include indexers or not.
12973 (Operator): Assign the Block before invoking the
12974 OperatorMethod.Define, so we can trigger the Iterator code
12977 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
12978 Property and Operator classes are not created when we parse the
12979 declarator but until we have the block completed, so we use a
12980 singleton SimpleIteratorContainer.Simple to flag whether the
12981 SetYields has been invoked.
12983 We propagate this setting then to the Property or the Operator to
12984 allow the `yield' to function.
12986 2004-02-25 Marek Safar <marek.safar@seznam.cz>
12988 * codegen.cs: Implemented attribute support for modules.
12989 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
12990 Assembly/Module functionality.
12992 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
12993 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
12994 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
12996 2004-02-16 Marek Safar <marek.safar@seznam.cz>
12998 * interface.cs (FindMembers): The operation is performed on all base
12999 interfaces and not only on the first. It is required for future CLS Compliance patch.
13001 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
13003 * statement.cs, codegen.cs:
13004 This patch deals with patterns such as:
13006 public class List : IEnumerable {
13008 public MyEnumerator GetEnumerator () {
13009 return new MyEnumerator(this);
13012 IEnumerator IEnumerable.GetEnumerator () {
13016 public struct MyEnumerator : IEnumerator {
13021 Before, there were a few things we did wrong:
13022 1) we would emit callvirt on a struct, which is illegal
13023 2) we emited ldarg when we needed to emit ldarga
13024 3) we would mistakenly call the interface methods on an enumerator
13025 type that derived from IEnumerator and was in another assembly. For example:
13027 public class MyEnumerator : IEnumerator
13029 Would have the interface methods called, even if there were public impls of the
13030 method. In a struct, this lead to invalid IL code.
13032 2004-02-11 Marek Safar <marek.safar@seznam.cz>
13034 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
13037 * delegate.cs (Define): Fixed crash when delegate type is undefined.
13039 2004-02-11 Miguel de Icaza <miguel@ximian.com>
13041 * cs-parser.jay: Fix small regression: we were not testing V2
13042 compiler features correctly.
13044 * interface.cs: If the emit context is null, then create one
13046 2004-02-09 Marek Safar <marek.safar@seznam.cz>
13048 * decl.cs (GetSignatureForError): New virtual method to get full name
13049 for error messages.
13051 * attribute.cs (IAttributeSupport): New interface for attribute setting.
13052 Now it is possible to rewrite ApplyAttributes method to be less if/else.
13054 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
13055 Duplicated members and code in these classes has been removed.
13056 Better encapsulation in these classes.
13058 2004-02-07 Miguel de Icaza <miguel@ximian.com>
13060 * assign.cs (Assign.DoResolve): When dealing with compound
13061 assignments, there is a new rule in ECMA C# 2.4 (might have been
13062 there before, but it is documented here) that states that in:
13066 If b is of type int, and the `op' is a shift-operator, then the
13067 above is evaluated as:
13071 * expression.cs (Binary.ResolveOperator): Instead of testing for
13072 int/uint/long/ulong, try to implicitly convert to any of those
13073 types and use that in pointer arithmetic.
13075 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
13076 method to print information for from the type, not from the
13077 null-method we were given.
13079 2004-02-01 Duncan Mak <duncan@ximian.com>
13081 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
13082 parsing for cmd, fixes bug #53694.
13084 2004-02-04 Marek Safar <marek.safar@seznam.cz>
13086 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
13087 in the member name duplication tests. Property and operator name duplication
13088 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
13090 2004-02-03 Marek Safar <marek.safar@seznam.cz>
13092 * interface.cs (PopulateMethod): Fixed crash when interface method
13093 returns not existing type (error test cs0246-3.cs).
13095 2004-02-02 Ravi Pratap M <ravi@ximian.com>
13097 * cs-parser.jay (interface_accessors): Re-write actions to also
13098 store attributes attached to get and set methods. Fix spelling
13101 (inteface_property_declaration): Modify accordingly.
13103 (InterfaceAccessorInfo): New helper class to store information to pass
13104 around between rules that use interface_accessors.
13106 * interface.cs (Emit): Apply attributes on the get and set
13107 accessors of properties and indexers too.
13109 * attribute.cs (ApplyAttributes): Modify accordingly to use the
13110 right MethodBuilder when applying attributes to the get and set accessors.
13112 2004-01-31 Miguel de Icaza <miguel@ximian.com>
13114 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
13116 2004-01-26 Miguel de Icaza <miguel@ximian.com>
13118 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
13120 2004-01-25 Miguel de Icaza <miguel@ximian.com>
13122 * cs-parser.jay: Remove YIELD token, instead use the new grammar
13123 changes that treat `yield' specially when present before `break'
13124 or `return' tokens.
13126 * cs-tokenizer.cs: yield is no longer a keyword.
13128 2004-01-23 Marek Safar <marek.safar@seznam.cz>
13130 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
13131 setting for default constructors.
13132 For default constructors are almost every time set wrong Modifier. The
13133 generated IL code has been alright. But inside mcs this values was
13134 wrong and this was reason why several of my CLS Compliance tests
13137 2004-02-27 Martin Baulig <martin@ximian.com>
13139 * generics.cs (ConstructedType.ResolveType): Make the nested type
13140 stuff actually work.
13142 2004-02-25 Martin Baulig <martin@ximian.com>
13144 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
13145 property; returns the type parameters just from the current type,
13146 ie. with the ones from outer classes.
13147 (DeclSpace.LookupGeneric): First search in the current class, then
13149 (DeclSpace.initialize_type_params): When hiding a type parameter
13150 from an outer class, put it into the `type_param_list' anyways.
13152 * expression.cs (MemberAccess.expr): Made this field protected.
13154 * class.cs (TypeContainer.Define): The `CurrentType' just contains
13155 the type parameters from the current class.
13157 * generic.cs (ConstructedType.ResolveType): Support nested generic
13158 types by taking the type parameters which we inherit from outer
13159 classes into account.
13160 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
13161 support for nested generic types.
13163 2004-02-23 Martin Baulig <martin@ximian.com>
13165 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
13166 field and check whether we're nested inside a generic type.
13167 (DeclSpace.ResolveType): If we're resolving to a generic type
13168 definition, create a ConstructedType and return its resolved type.
13169 (DeclSpace.initialize_type_params): New private method;
13170 initializes the `type_param_list' field from the type parameters
13171 from this and all enclosing classes.
13172 (DeclSpace.TypeParameters): Call initialize_type_params() unless
13173 we're already initialized.
13175 2004-02-23 Martin Baulig <martin@ximian.com>
13177 * class.cs (Method.Define): Create the generic method before
13178 calling DoDefine().
13179 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
13180 the TypeContainer one); we use this for generic methods.
13182 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
13183 parent's TypeBuilder.
13185 2004-02-18 Martin Baulig <martin@ximian.com>
13187 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
13188 to check for equality.
13190 2004-02-05 Martin Baulig <martin@ximian.com>
13192 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
13193 `ec.TypeContainer.CurrentType', use it instead of
13194 `ec.ContainerType' to check whether we're in the type's ctor.
13196 2004-01-29 Martin Baulig <martin@ximian.com>
13198 * expression.cs (Invocation.DoResolve): If we're a
13199 `ConstructedType', then we're actually a generic method, so
13200 rewrite the expr as a GenericMemberAccess.
13202 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
13203 here; manually parse it into a string.
13205 2004-01-28 Martin Baulig <martin@ximian.com>
13207 * typemanager.cs (TypeManager.IsEqual): New static method.
13208 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
13209 check for equality instead of using `=='.
13211 2004-01-26 Martin Baulig <martin@ximian.com>
13213 * decl.cs (DeclSpace.CurrentType): New public field.
13215 * expression.cs (This.ResolveBase): If we have an
13216 `ec.TypeContainer.CurrentType', use it instead of
13217 `ec.ContainerType'.
13219 * class.cs (TypeContainer.DefineType): If we're a generic type,
13220 create the `CurrentType' (unresolved).
13221 (TypeContainer.GenericType): New private field.
13222 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
13223 it and store it in `GenericType' before creating the MemberCache.
13224 (TypeContainer.GetMembers): If we have a `GenericType', call
13225 TypeManager.FindMembers() on it.
13227 * interface.cs (Interface.GenericType): New private field.
13228 (Interface.DefineType): If we're a generic type, create the
13229 `CurrentType' (unresolved).
13230 (Interface.DefineMembers): If we have a `CurrentType', resolve it
13231 and store it in `GenericType' before creating the MemberCache.
13232 (Interface.GetMembers): If we have a `GenericType', call
13233 TypeManager.FindMembers() on it.
13235 2004-01-22 Martin Baulig <martin@ximian.com>
13237 * cs-parser.jay (namespace_or_type_name): Return an Expression,
13238 not a QualifiedIdentifier. This is what `type_name_expression'
13239 was previously doing.
13240 (type_name_expression): Removed; the code is now in
13241 `namespace_or_type_name'.
13242 (qualified_identifier): Removed, use `namespace_or_type_name'
13244 (QualifiedIdentifier): Removed this class.
13246 2004-01-22 Martin Baulig <martin@ximian.com>
13248 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
13249 not a string as alias name.
13251 2004-01-21 Miguel de Icaza <miguel@ximian.com>
13253 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
13254 #52730 bug, and instead compute correctly the need to use a
13255 temporary variable when requesting an address based on the
13256 static/instace modified of the field and the constructor.
13258 2004-01-21 Martin Baulig <martin@ximian.com>
13260 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
13261 class and namespace before looking up aliases. Fixes #52517.
13263 2004-01-21 Martin Baulig <martin@ximian.com>
13265 * flowanalysis.cs (UsageVector.Merge): Allow variables being
13266 assinged in a 'try'; fixes exception4.cs.
13268 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13269 * class.cs : Implemented parameter-less constructor for TypeContainer
13271 * decl.cs: Attributes are now stored here. New property OptAttributes
13273 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
13275 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
13277 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13279 * typemanager.cs (CSharpSignature): Now reports also inner class name.
13280 (CSharpSignature): New method for indexer and property signature.
13282 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13284 * pending.cs (IsVirtualFilter): Faster implementation.
13286 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13288 * typemanager.cs: Avoid inclusion of same assembly more than once.
13290 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13292 * cs-parser.jay: Fixed problem where the last assembly attribute
13293 has been applied also to following declaration (class, struct, etc.)
13295 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13297 * class.cs: Added error CS0538, CS0539 reporting.
13298 Fixed crash on Microsoft runtime when field type is void.
13300 * cs-parser.jay: Added error CS0537 reporting.
13302 * pending.cs: Added error CS0535 reporting.
13303 Improved error report for errors CS0536, CS0534.
13305 2004-01-20 Miguel de Icaza <miguel@ximian.com>
13307 Merge a few bits from the Anonymous Method MCS tree.
13309 * statement.cs (ToplevelBlock): New class for toplevel methods,
13310 will hold anonymous methods, lifted variables.
13312 * cs-parser.jay: Create toplevel blocks for delegates and for
13313 regular blocks of code.
13315 2004-01-20 Martin Baulig <martin@ximian.com>
13317 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
13318 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
13319 and `NeedExplicitReturn'; added `IsLastStatement'.
13320 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
13321 have a `ReturnLabel' or we're not unreachable.
13323 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
13324 child's reachability; don't just override ours with it. Fixes
13325 #58058 (lluis's example).
13326 (FlowBranching): Added public InTryOrCatch(), InCatch(),
13327 InFinally(), InLoop(), InSwitch() and
13328 BreakCrossesTryCatchBoundary() methods.
13330 * statement.cs (Return): Do all error checking in Resolve().
13331 Unless we are the last statement in a top-level block, always
13332 create a return label and jump to it.
13333 (Break, Continue): Do all error checking in Resolve(); also make
13334 sure we aren't leaving a `finally'.
13335 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
13336 statement in a top-level block.
13337 (Block.Flags): Added `IsDestructor'.
13338 (Block.IsDestructor): New public property.
13340 2004-01-20 Martin Baulig <martin@ximian.com>
13342 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
13344 2004-01-20 Martin Baulig <martin@ximian.com>
13346 * statement.cs (Statement.ResolveUnreachable): New public method.
13347 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
13348 (Block.Resolve): Resolve unreachable statements.
13350 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13352 * expression.cs: We need to fix the case where we do
13353 not have a temp variable here.
13355 * assign.cs: Only expression compound assignments need
13356 temporary variables.
13358 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13360 * flowanalysis.cs: Reduce memory allocation in a few ways:
13361 - A block with no variables should not allocate a bit
13363 - A method with no out parameters does not need any tracking
13364 for assignment of the parameters, so we need not allocate
13367 public readonly Type[] VariableTypes;
13368 public readonly string[] VariableNames;
13369 Are redundant. The data is already stored in the variable
13370 map, so we need not allocate another array for it.
13371 - We need to add alot of checks for if (params | locals) == null
13372 due to the first two changes.
13374 2004-01-18 Miguel de Icaza <miguel@ximian.com>
13376 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
13377 implement IMemoryLocation, we store a copy on a local variable and
13378 take the address of it. Patch from Benjamin Jemlich
13380 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
13381 to use a special "type_name_expression" rule which reduces the
13382 number of "QualifiedIdentifier" classes created, and instead
13383 directly creates MemberAccess expressions.
13385 2004-01-17 Miguel de Icaza <miguel@ximian.com>
13387 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
13388 that fixes #52853. Null literal assignment to ValueType
13390 * class.cs (MethodData.Emit): Instead of checking the name of the
13391 method to determine if its a destructor, create a new derived
13392 class from Method called Destructor, and test for that.
13394 * cs-parser.jay: Create a Destructor object instead of a Method.
13396 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
13400 2004-01-16 Miguel de Icaza <miguel@ximian.com>
13402 * expression.cs (Binary.ResolveOperator): Perform an implicit
13403 conversion from MethodGroups to their delegate types on the
13404 Addition operation.
13406 * delegate.cs: Introduce a new class DelegateCreation that is the
13407 base class for `NewDelegate' and `ImplicitDelegateCreation',
13408 factor some code in here.
13410 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
13411 conversion from MethodGroups to compatible delegate types.
13413 * ecore.cs (Expression.Resolve): Do not flag error 654
13414 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
13415 we allow conversions from MethodGroups to delegate types now.
13417 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
13418 assignments in v2 either.
13420 2004-01-10 Miguel de Icaza <miguel@ximian.com>
13422 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
13423 static read-only fields in ctors.
13425 Applied patch from Benjamin Jemlich
13427 * expression.cs (UnaryMutator): Avoid leaking local variables.
13429 2004-01-09 Miguel de Icaza <miguel@ximian.com>
13431 * cs-tokenizer.cs (IsCastToken): Allow the various native types
13432 here to return true, as they can be used like this:
13434 (XXX) int.MEMBER ()
13436 Fixed 49836 and all the other dups
13438 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
13440 * driver.cs: Implement /win32res and /win32icon.
13442 2004-01-08 Miguel de Icaza <miguel@ximian.com>
13444 * cs-parser.jay: Add a rule to improve error handling for the
13445 common mistake of placing modifiers after the type.
13447 2004-01-07 Miguel de Icaza <miguel@ximian.com>
13449 * cs-parser.jay (interface_event_declaration): Catch
13450 initialization of events on interfaces, and report cs0068
13452 * cs-parser.jay (interface_event_declaration): Catch
13453 initialization of events.
13455 * ecore.cs: Better report missing constructors.
13457 * expression.cs (Binary.ResolveOperator): My previous bug fix had
13458 the error reporting done in the wrong place. Fix.
13460 * expression.cs (Binary.ResolveOperator): Catch the
13461 operator + (E x, E y) error earlier, and later allow for implicit
13462 conversions in operator +/- (E e, U x) from U to the underlying
13465 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
13466 52596, if the container class is abstract, the default constructor
13467 is protected otherwise its public (before, we were always public).
13469 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
13472 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
13473 Jemlich that fixes bug #52597, MCS was generating invalid code for
13474 idisposable structs. Thanks to Ben for following up with this
13477 2004-01-06 Miguel de Icaza <miguel@ximian.com>
13479 * driver.cs: Allow assemblies without code to be generated, fixes
13482 2004-01-07 Nick Drochak <ndrochak@gol.com>
13484 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
13486 2004-01-05 Miguel de Icaza <miguel@ximian.com>
13488 * cs-parser.jay: Add rules to improve error reporting if fields or
13489 methods are declared at the namespace level (error 116)
13491 * Add rules to catch event add/remove
13493 2004-01-04 David Sheldon <dave-mono@earth.li>
13495 * expression.cs: Added matching ")" to error message for
13498 2004-01-03 Todd Berman <tberman@gentoo.org>
13500 * ecore.cs, attribute.cs:
13501 Applying fix from #52429.
13503 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13505 * ecore.cs, expression.cs, statement.cs:
13506 Total rewrite of how we handle branching. We
13507 now handle complex boolean expressions with fewer
13508 jumps. As well if (x == 0) no longer emits a ceq.
13510 if (x is Foo) is much faster now, because we generate
13513 Overall, we get a pretty big improvement on our benchmark
13514 tests. The code we generate is smaller and more readable.
13516 I did a full two-stage bootstrap. The patch was reviewed
13517 by Martin and Miguel.
13519 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13521 * cs-parser.jay: Make primary_expression not take a QI.
13522 we dont need this because the member_access rule covers
13523 us here. So we replace the rule with just IDENTIFIER.
13525 This has two good effects. First, we remove a s/r conflict.
13526 Second, we allocate many fewer QualifiedIdentifier objects.
13528 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13530 * attribute.cs: Handle MarshalAs attributes as pseudo, and
13531 set the correct information via SRE. This prevents
13532 hanging on the MS runtime. Fixes #29374.
13534 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13536 * convert.cs: correctly handle conversions to value types
13537 from Enum and ValueType as unboxing conversions.
13539 Fixes bug #52569. Patch by Benjamin Jemlich.
13541 2004-01-02 Ravi Pratap <ravi@ximian.com>
13543 * expression.cs (BetterConversion): Prefer int -> uint
13544 over int -> ulong (csc's behaviour). This fixed bug #52046.
13546 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
13548 * decl.cs (MemberCache.FindMembers): now returns a
13551 * typemanager.cs: In general, go with with ^^.
13552 (CopyNewMethods): take an IList.
13553 (RealMemberLookup): Only allocate an arraylist
13554 if we copy from two sets of methods.
13556 This change basically does two things:
13557 1) Fewer array lists allocated due to CopyNewMethods.
13558 2) the explicit cast in MemberList costed ALOT.
13560 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13562 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13563 a hashtable to avoid needless string allocations when an identifier is
13564 used more than once (the common case).
13566 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13568 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13569 is broken, it will not return anything. So, we
13570 have to use the information we have in mcs to
13573 * typemanager.cs: Add a cache for GetInterfaces,
13574 since this will now be used more often (due to ^^)
13576 (GetExplicitInterfaces) New method that gets the
13577 declared, not effective, interfaces on a type
13578 builder (eg, if you have interface IFoo, interface
13579 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13582 This patch makes MCS able to bootstrap itself on
13585 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13587 * expression.cs: Remove the Nop's that Miguel put
13590 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13592 * report.cs, codegen.cs: Give the real stack trace to
13593 the error when an exception is thrown.
13595 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13597 * decl.cs: only allocate hashtables for ifaces if
13600 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13602 * expression.cs: fix the error from cs0121-2.cs
13603 (a parent interface has two child interfaces that
13604 have a function with the same name and 0 params
13605 and the function is called through the parent).
13607 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13609 * class.cs, rootcontext.cs, typmanager.cs: do not
13612 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13614 * codegen.cs: remove stack for the ec flow branching.
13615 It is already a linked list, so no need.
13617 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13619 * Makefile: Allow custom profiler here.
13621 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13623 * typemanager.cs (LookupType):
13624 - Use a static char [], because split takes
13625 a param array for args, so it was allocating
13627 - Do not store true in a hashtable, it boxes.
13629 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13631 * flowanalysis.cs: bytify common enums.
13633 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13635 * modifiers.cs: Add a new set of flags for the
13636 flags allowed on explicit interface impls.
13637 * cs-parser.jay: catch the use of modifiers in
13638 interfaces correctly.
13639 * class.cs: catch private void IFoo.Blah ().
13641 All related to bug #50572.
13643 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13645 * decl.cs: Rewrite the consistant accessability checking.
13646 Accessability is not linear, it must be implemented in
13647 a tableish way. Fixes #49704.
13649 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13651 * expression.cs: Handle negation in a checked context.
13652 We must use subtraction from zero. Fixes #38674.
13654 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13656 * class.cs: Ignore static void main in DLLs.
13657 * rootcontext.cs: Handle the target type here,
13658 since we are have to access it from class.cs
13659 * driver.cs: account for the above.
13661 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13663 * report.cs: Give line numbers and files if available.
13665 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13667 * driver.cs: Implement /addmodule.
13669 * typemanager.cs: Change 'modules' field so it now contains Modules not
13672 2003-12-20 Martin Baulig <martin@ximian.com>
13674 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13675 (FieldBase.IsAssigned): Removed this field.
13676 (FieldBase.SetAssigned): New public method.
13677 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13679 2003-12-20 Martin Baulig <martin@ximian.com>
13681 * expression.cs (LocalVariableReference.DoResolve): Don't set
13682 `vi.Used' if we're called from DoResolveLValue().
13684 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13685 returns the usage vector it just merged into the current one -
13686 pass this one to UsageWarning().
13687 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13688 of the `EmitContext', don't call this recursively on our children.
13690 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13692 * driver.cs: Implement /target:module.
13694 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13696 * support.cs (CharArrayHashtable): New helper class.
13698 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13699 char arrays, not strings, so we can avoid creating a string in
13700 consume_identifier if the identifier is a keyword.
13702 2003-12-16 Martin Baulig <martin@ximian.com>
13704 * statement.cs (LocalInfo.Assigned): Removed this property.
13705 (LocalInfo.Flags): Removed `Assigned'.
13706 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13707 and uses flow analysis.
13708 (Block.UsageWarning): Made this method private.
13709 (Block.Resolve): Call UsageWarning() if appropriate.
13711 * expression.cs (LocalVariableReference.DoResolve): Always set
13712 LocalInfo.Used here.
13714 2003-12-13 Martin Baulig <martin@ximian.com>
13716 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13717 any value here; we're now using flow analysis to figure out
13718 whether a statement/block returns a value.
13720 2003-12-13 Martin Baulig <martin@ximian.com>
13722 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13724 (FlowBranching.MergeFinally): Don't call
13725 `branching.CheckOutParameters()' here, this is called in
13727 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13728 when adding the `finally' vector.
13730 2003-12-13 Martin Baulig <martin@ximian.com>
13733 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13734 actually work and also fix #48962.
13736 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13738 * decl.cs: Do not check System.Object for nested types,
13739 since we know it does not have any. Big bang for buck:
13742 Run 1: 8.35 seconds
13743 Run 2: 8.32 seconds
13744 corlib: 17.99 seconds
13746 Run 1: 8.17 seconds
13747 Run 2: 8.17 seconds
13748 corlib: 17.39 seconds
13750 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13752 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13753 time we are returning 0 members, so we save alot here.
13755 2003-12-11 Martin Baulig <martin@ximian.com>
13757 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13758 `MergeChild()', also just take the `FlowBranching' as argument;
13759 call Merge() on it and return the result.
13760 (FlowBranching.Merge): We don't need to do anything if we just
13763 2003-12-11 Martin Baulig <martin@ximian.com>
13765 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13766 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13767 Maurer for this idea.
13769 2003-12-11 Martin Baulig <martin@ximian.com>
13771 * flowanalysis.cs (MergeResult): This class is now gone; we now
13772 use the `UsageVector' for this. The reason for this is that if a
13773 branching just has one sibling, we don't need to "merge" them at
13774 all - that's the next step to do.
13775 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13778 2003-12-11 Martin Baulig <martin@ximian.com>
13780 Reworked flow analyis and made it more precise and bug-free. The
13781 most important change is that we're now using a special `Reachability'
13782 class instead of having "magic" meanings of `FlowReturns'. I'll
13783 do some more cleanups and optimizations and also add some more
13784 documentation this week.
13786 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13787 largely reworked this class.
13788 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13789 the new `Reachability' class instead of having "magic" values here.
13790 (FlowBranching): We're now using an instance of `Reachability'
13791 instead of having separate `Returns', `Breaks' etc. fields.
13793 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13794 based on flow analysis; ignore the return value of block.Emit ().
13796 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13798 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13799 if they are private.
13801 2003-12-09 Martin Baulig <martin@ximian.com>
13803 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13804 call them directly on the UsageVector.
13806 2003-12-09 Martin Baulig <martin@ximian.com>
13808 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13809 Changed return type from `FlowReturns' to `Reachability'.
13811 2003-12-09 Martin Baulig <martin@ximian.com>
13813 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13814 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13815 `Reachable' fields with a single `Reachability' one.
13817 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13819 * class.cs (FindMembers): Remove foreach's.
13824 Run 1: 8.74 seconds
13825 Run 2: 8.71 seconds
13828 Run 1: 8.64 seconds
13829 Run 2: 8.58 seconds
13832 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13837 This patch does a few things:
13838 1. EmptyStatement is now a singleton, so it is never reallocated.
13839 2. All blah is EmptyStatement constructs have been changed to
13840 blah == EmptyStatement.Value, which is much faster and valid
13841 now that EmptyStatement is a singleton.
13842 3. When resolving a block, rather than allocating a new array for
13843 the non-empty statements, empty statements are replaced with
13844 EmptyStatement.Value
13845 4. Some recursive functions have been made non-recursive.
13846 Mainly the performance impact is from (3), however (1) and (2) are needed for
13847 this to work. (4) does not make a big difference in normal situations, however
13848 it makes the profile look saner.
13853 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13854 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13855 Total memory allocated: 56397 KB
13858 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13859 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13860 Total memory allocated: 55666 KB
13862 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13864 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13865 than the hashtable in a hashtable version
13867 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13868 we always end up concating a string. This results in a huge perf
13869 loss, because many strings have to be tracked by the GC. In this
13870 patch, we first use a hashtable that works with two keys, so that
13871 the strings do not need to be concat'ed.
13875 Run 1: 8.74 seconds
13876 Run 2: 8.71 seconds
13879 Run 1: 8.65 seconds
13880 Run 2: 8.56 seconds
13882 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13884 * Makefile: Add a new target `do-time' that does a quick and simple
13885 profile, leaving easy to parse output.
13887 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13889 * codegen.cs (Init): Create the dynamic assembly with
13890 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13892 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13894 * support.cs: Make the PtrHashtable use only one
13895 instance of its comparer.
13897 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13899 * typemanager.cs: Fix lookup of GetNamespaces.
13901 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13903 * expression.cs: Removed redundant line.
13905 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
13906 ArrayLists, use for loops with bounds.
13908 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
13911 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
13912 arraylists, use for loop with bounds.
13914 The above three changes give us a 0.071 second performance
13915 improvement out of 3.294 seconds down to 3.223. On my machine
13916 the above changes reduced the memory usage by 1,387 KB during
13917 compiler bootstrap.
13919 * cs-parser.jay (QualifiedIdentifier): New class used to represent
13920 QualifiedIdentifiers. Before we created a new string through
13921 concatenation, and mostly later on, the result would be
13922 manipulated by DecomposeQI through string manipulation.
13924 This reduced the compiler memory usage for bootstrapping from
13925 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
13926 compile times in 0.05 seconds.
13928 2003-11-28 Dick Porter <dick@ximian.com>
13930 * support.cs: Do string compares with the Invariant culture.
13938 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
13939 the comparison is done with the Invariant culture.
13941 2003-11-27 Miguel de Icaza <miguel@ximian.com>
13943 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
13944 GetEnumerator method.
13946 (ProbeCollectionType): Iterate starting at the most specific type
13947 upwards looking for a GetEnumerator
13949 * expression.cs: Shift count can be up to 31 for int/uint and 63
13952 2003-11-26 Miguel de Icaza <miguel@ximian.com>
13954 * statement.cs (Block.LookupLabel): Also look for the label on the
13955 children blocks. Use a hash table to keep track of visited
13958 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
13959 we actually did transform the other operand, otherwise fall back
13960 to the common codepath that casts to long.
13962 * cs-tokenizer.cs: Use the same code pattern as the int case.
13963 Maybe I should do the parsing myself, and avoid depending on the
13964 Parse routines to get this done.
13966 2003-11-25 Miguel de Icaza <miguel@ximian.com>
13968 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13969 which fixes bug 51347. This time test it.
13971 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
13972 attributes for example can not tell the difference between these.
13973 The difference was only a syntax feature of the language.
13975 * attribute.cs: Apply attributes to delegates.
13977 * delegate.cs: Call the apply attributes method.
13979 2003-11-24 Miguel de Icaza <miguel@ximian.com>
13981 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
13982 comparing 0 vs Byte.MinValue, not the value
13984 (ImplicitConversionRequired): When reporting a conversion error,
13985 use error 31 to print out the constant error instead of the
13988 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13989 which fixes bug 51347.
13991 2003-11-22 Miguel de Icaza <miguel@ximian.com>
13993 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
13994 which fixes the -warnaserror command line option.
13996 2003-11-21 Miguel de Icaza <miguel@ximian.com>
13998 * cfold.cs (DoNumericPromotions): During constant folding of
13999 additions on UIntConstant, special case intconstants with
14000 IntConstants like we do on the expression binary operator.
14002 2003-11-12 Miguel de Icaza <miguel@ximian.com>
14004 * convert.cs (ImplicitReferenceConversion): We were missing a case
14005 (System.Enum are not value types or class types, so we need to
14006 classify them separatedly).
14008 * driver.cs: We do not support error 2007.
14010 2003-11-12 Jackson Harper <jackson@ximian.com>
14012 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
14013 system directory. Also use the full file name so users can
14014 libraries names mscorlib-o-tron.dll in a non system dir.
14016 2004-01-04 David Sheldon <dave-mono@earth.li>
14018 * expression.cs: Added matching ")" to error message for CS0077.
14020 2003-12-19 Martin Baulig <martin@ximian.com>
14022 * typemanager.cs (TypeManager.IsEqualGenericType): New public
14023 static method; see documentation in the method.
14024 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
14026 * convert.cs (Convert.ImplicitReferenceConversion,
14027 Convert.ImplicitReferenceConversionExists): Add support for
14028 generic type declarations; see gen-36.cs.
14030 2003-12-19 Martin Baulig <martin@ximian.com>
14032 * pending.cs (Pending.InterfaceMethod): Use
14033 `Type.IsAssignableFrom()' instead of `=='.
14035 2003-12-18 Martin Baulig <martin@ximian.com>
14037 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
14040 * convert.cs (Convert.ImplicitStandardConversionExists): Use
14041 `expr_type.Equals (target_type)' instead of `=='.
14043 2003-12-08 Martin Baulig <martin@ximian.com>
14045 * generics.cs (Constraints.Types): Removed.
14046 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
14048 (Constraints.ResolveTypes): New public method; resolves the
14049 TypeExpr's to Type's.
14050 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
14051 longer takes the constraints.
14052 (TypeParameter.DefineMethod): Likewise.
14053 (TypeParameter.DefineType): New public method. Calls
14054 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
14057 2003-12-08 Martin Baulig <martin@ximian.com>
14059 * convert.cs (Convert.ImplicitConversionStandard): Use
14060 `expr_type.Equals (target_type)' instead of `=='.
14062 2003-12-08 Martin Baulig <martin@ximian.com>
14064 * typemanager.cs (TypeManager.GetReferenceType): Call
14065 `Type.MakeByRefType ()'.
14067 2003-12-08 Martin Baulig <martin@ximian.com>
14069 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
14070 just has some special meaning in some situations. For instance,
14071 it is allowed to use `where' as the name of a variable etc.
14073 2003-12-04 Martin Baulig <martin@ximian.com>
14075 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14076 `Type.MakeArrayType()' for array types.
14078 2003-11-18 Miguel de Icaza <miguel@ximian.com>
14080 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
14083 (SizeOf.DoResolve): assign the `type_queried' field. This gets
14086 2003-11-16 Martin Baulig <martin@ximian.com>
14088 * codegen.cs (EmitContext.IsGeneric): Removed.
14090 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
14091 ResolveGeneric() on the DeclSpace.
14093 2003-11-16 Martin Baulig <martin@ximian.com>
14095 * generic.cs (TypeArguments.Resolve):
14096 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
14097 `ResolveType()' on it to get the Type.
14099 2003-11-15 Martin Baulig <martin@ximian.com>
14101 * generic.cs (ConstructedType.GetInterfaces): Override this.
14103 2003-11-14 Martin Baulig <martin@ximian.com>
14105 * interface.cs (Interface.DefineType): Define all type parameters
14106 before adding the interfaces we inherit.
14108 2003-11-11 Martin Baulig <martin@ximian.com>
14110 * generic.cs (ConstructedType.ResolveType): Always call
14111 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
14113 2003-11-10 Martin Baulig <martin@ximian.com>
14115 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
14116 (TypeManager.InitCoreTypes): Initialize them here, but instead of
14117 calling `ResolveType()' on them, directly assign their `Type'.
14119 2003-11-08 Martin Baulig <martin@ximian.com>
14121 * generic.cs (ConstructedType): Override `IsClass' etc.
14123 2003-11-08 Martin Baulig <martin@ximian.com>
14125 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
14126 return value and the `out parent' parameter.
14127 (TypeContainer.DefineType): Moved the CS0644 check into
14128 GetClassBases(). Don't pass the interface types to the
14129 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
14130 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
14132 * ecore.cs (TypeExpr.IsAttribute): New property.
14133 (TypeExpr.GetInterfaces): New method.
14135 * interface.cs (Interface.GetInterfaceTypeByName): Return a
14136 TypeExpr instead of a Type.
14137 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
14138 (Interface.DefineType): Don't pass the interface types to the
14139 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
14140 them later and then call `TypeBulider.AddInterfaceImplementation()'.
14142 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
14143 instead of a `Type[]'.
14144 (TypeManager.RegisterBuilder): Likewise.
14145 (TypeManager.AddUserInterface): Likewise.
14146 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
14147 `Type[]' and also return a `TypeExpr[]'.
14148 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
14150 2003-11-08 Martin Baulig <martin@ximian.com>
14152 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
14155 2003-11-08 Martin Baulig <martin@ximian.com>
14157 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
14158 TypeManager.ResolveExpressionTypes().
14160 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
14161 instead of an Expression.
14162 (TypeExpr): This is now an abstract base class for `TypeExpression'.
14163 (TypeExpression): New public class; formerly known as `TypeExpr'.
14165 * expression.cs (ComposedCast): Derive from TypeExpr.
14167 * typemanager.cs (TypeManager.system_*_expr): These are now
14168 TypExpr's instead of Expression's.
14169 (TypeManager.ResolveExpressionTypes): New public static function;
14170 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
14173 2003-11-06 Miguel de Icaza <miguel@ximian.com>
14175 * expression.cs (New.DoResolve): Do not dereference value that
14176 might be a null return.
14178 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
14179 sure that the constant value has the right type. Fixes an
14180 unreported bug, similar to 50425.
14182 * const.cs (Const.LookupConstantValue): Call
14183 ImplicitStandardConversionExists before doing a conversion to
14184 avoid havng the TypeManager.ChangeType do conversions.
14186 Reduced the number of casts used
14188 (Const.ChangeType): New routine to enable reuse of the constant
14189 type changing code from statement.
14191 * typemanager.cs (ChangeType): Move common initialization to
14192 static global variables.
14196 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
14197 every value type to go through, even if it was void. Fix that.
14199 * cs-tokenizer.cs: Use is_identifier_start_character on the start
14200 character of the define, and the is_identifier_part_character for
14201 the rest of the string.
14203 2003-11-05 Miguel de Icaza <miguel@ximian.com>
14205 * expression.cs (UnaryMutator.EmitCode): When I updated
14206 LocalVariableReference.DoResolve, I overdid it, and dropped an
14207 optimization done on local variable references.
14209 2003-11-04 Miguel de Icaza <miguel@ximian.com>
14211 * ecore.cs: Convert the return from Ldlen into an int.
14213 2003-10-20 Miguel de Icaza <miguel@ximian.com>
14215 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
14216 the accessibility, this is a special case for toplevel non-public
14217 classes (internal for instance).
14219 2003-10-20 Nick Drochak <ndrochak@gol.com>
14221 * ecore.cs: Fix typo and build. Needed another right paren.
14223 2003-10-19 Miguel de Icaza <miguel@ximian.com>
14225 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
14226 `internal' case regular and protected, but not allowing protected
14227 to be evaluated later. Bug 49840
14229 2003-10-15 Miguel de Icaza <miguel@ximian.com>
14231 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
14232 to kb.Nlast, and not the kb.nFirst to isolate the switch
14235 Extract the underlying type, so enumerations of long/ulong are
14236 treated like long/ulong.
14238 2003-10-14 Miguel de Icaza <miguel@ximian.com>
14240 * expression.cs (New): Overload the meaning of RequestedType to
14241 track the possible creation of the NewDelegate type, since
14242 DoResolve is invoked more than once for new constructors on field
14245 See bugs: #48800 and #37014
14247 * cs-parser.jay (declare_local_constants): Take an arraylist
14248 instead of a single constant.
14250 (local_constant_declaration): It should take a
14251 constant_declarators, not a constant_declarator. Fixes 49487
14253 * convert.cs: Fix error report.
14255 2003-10-13 Jackson Harper <jackson@ximian.com>
14257 * typemanager.cs (TypeToCoreType): Add float and double this fixes
14260 2003-11-03 Martin Baulig <martin@ximian.com>
14262 * expression.cs (ArrayAccess.GetStoreOpcode): Added
14263 `out bool has_type_arg'; if set, we need to pass the type to
14265 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
14266 Stelem_Any/Ldelem_Any for generic parameters.
14268 2003-11-02 Martin Baulig <martin@ximian.com>
14270 * expression.cs (Invocation.EmitCall): Use
14271 `TypeManager.IsValueType()' to check whether it's a value type.
14272 Don't set `struct_call' when calling a method on a type parameter.
14274 2003-11-02 Martin Baulig <martin@ximian.com>
14276 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
14277 and removed the TypeBuilder argument.
14279 * typemanager.cs (TypeManager.IsValueType): Return
14280 `t.IsGenericParameter || t.IsValueType'.
14282 2003-10-25 Martin Baulig <martin@ximian.com>
14284 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
14285 call ConstructedType.Resolve() on it.
14287 * generic.cs (ConstructedType.Resolve): Set `type' on success.
14289 2003-10-25 Martin Baulig <martin@ximian.com>
14291 * class.cs (TypeContainer.GetClassBases): Changed
14292 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
14293 CS8214 reporting here.
14294 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
14295 instead of a `Type' for our parent. In case of a recursive
14296 declaration (see tests/gen-23.cs for an example), our parent is a
14297 ConstructedType and it doesn't have its type set. So, first
14298 create our own TypeBuilder, then call constructed.Resolve() to get
14299 the parent's type and finally TypeBuilder.SetParent() it.
14301 * ecore.cs (TypeExpr.Name): New public virtual property.
14304 (ConstructedType): We're now a TypeExpr and not just an Expression.
14305 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
14306 arguments here; this is done later.
14307 (ConstructedType.Resolve): New public method to resolve the type
14308 arguments and bind them.
14310 2003-10-21 Martin Baulig <martin@ximian.com>
14312 * convert.cs: Use `TypeManager.IsValueType' instead of
14313 'type.IsValueType' everywhere.
14315 * typemanager.cs (TypeManager.IsValueType): Return true for type
14316 parameters. The reason for this is that we need to box a type
14317 parameter when converting it to a reference type.
14319 * cs-parser.jay: Added support for default value expressions.
14321 * generics.cs (DefaultValueExpression): New public class.
14323 2003-10-17 Martin Baulig <martin@ximian.com>
14325 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
14326 TypeContainer so we can also use this for Interfaces.
14327 (TypeParameter.Resolve): Likewise.
14329 * interface.cs (Interface.DefineType): Added support for generic
14332 * cs-parser.jay: Added support for generic structs and interfaces.
14334 2003-10-17 Martin Baulig <martin@ximian.com>
14336 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
14337 call generic methods :-)
14339 2003-10-16 Martin Baulig <martin@ximian.com>
14341 * cs-parser.jay (namespace_or_type_name): Only create a
14342 GenericMemberAccess if we actually have type arguments.
14344 2003-10-13 Martin Baulig <martin@ximian.com>
14346 * class.cs (Method.Define): If we're a generic method, call
14347 TypeBuilder.DefineGenericMethod () before resolving
14349 (MethodData): Added .ctor which takes an additional MethodBuilder
14350 argument; this is used for generic methods.
14351 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
14352 we already have a MethodBuilder.
14354 2003-10-10 Martin Baulig <martin@ximian.com>
14356 * class.cs (Method): Added .ctor which takes a `GenericMethod'
14357 instead of a `DeclSpace'. This is used for generic methods.
14359 * cs-parser.jay (method_header): Added support for generic
14360 methods; create a `GenericMethod' instance and pass it to the
14361 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
14362 parameters and locals.
14364 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
14365 since we already have the location. Check whether we're a generic
14366 type declaration or a generic method and create the correct type
14369 * generic.cs (TypeParameter.DefineMethod): New public method.
14370 (GenericMethod): New public class; derives from DeclSpace and is
14371 used for generic methods.
14373 2003-10-09 Martin Baulig <martin@ximian.com>
14375 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
14377 (MethodCore.DoDefineParameters): Removed the TypeContainer
14378 argument; use the DeclSpace which was passed to the .ctor instead.
14379 (MethodCore.CheckParameter): Take a DeclSpace instead of a
14380 TypeContainer; we only need a DeclSpace here.
14382 2003-10-09 Martin Baulig <martin@ximian.com>
14384 * class.cs (MethodData): Added additional `DeclSpace ds' argument
14386 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
14387 EmitContext's .ctor.
14389 2003-10-09 Martin Baulig <martin@ximian.com>
14391 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
14392 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
14393 AsAccessible(), moved them as well.
14395 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
14397 2003-10-07 Miguel de Icaza <miguel@ximian.com>
14399 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
14400 generation for >=, as spotted by Paolo, bug 48679.
14401 Patch from David Waite.
14403 * cs-tokenizer.cs: Add handling for #pragma.
14405 * cs-parser.jay: Allow for both yield and yield return in the
14406 syntax. The anti-cobolization of C# fight will go on!
14408 * class.cs (TypeBuilder.DefineType): Catch error condition here
14409 (Parent.DefineType erroring out and returning null).
14411 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14412 coping with enumerations variables, we were mistakenly processing
14413 them as a regular value type instead of built-in types. Fixes the
14416 * typemanager.cs (IsBuiltinOrEnum): New method.
14418 2003-09-30 Miguel de Icaza <miguel@ximian.com>
14420 * cs-parser.jay: Upgrade: yield now needs the return clause.
14422 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
14424 * cs-parser.jay : Renamed yyName to yyNames related to jay.
14426 2003-09-29 Martin Baulig <martin@ximian.com>
14428 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
14429 inflated generic methods.
14431 * generics.cs (ConstructedType): Distinguish between open and
14432 closed constructed types; correctly resolve the arguments.
14434 2003-09-22 Martin Baulig <martin@ximian.com>
14436 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
14437 all type arguments meet their constraints.
14439 2003-09-19 Martin Baulig <martin@ximian.com>
14441 * decl.cs (MemberCache.SetupCacheForInterface): Take a
14442 `MemberCache parent' argument. Normally, an interface doesn't
14443 have a parent type except System.Object, but we use this in gmcs
14444 for generic type parameters.
14446 2003-09-18 Martin Baulig <martin@ximian.com>
14448 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
14449 on `type.IsInterface'; don't check whether the type has a parent
14450 to determine whether it's an interface.
14452 2003-09-17 Martin Baulig <martin@ximian.com>
14454 * generic.cs (ConstructedType.ToString): Always use `name' as the
14457 2003-09-15 Martin Baulig <martin@ximian.com>
14459 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
14461 * generic.cs (Constraints.Resolve): New public method; this is
14462 called to resolve the constraint types and to check whether all
14463 the constraints are correct.
14464 (Constraints.Types): New public property.
14465 (TypeParameter.Resolve): New public method; resolves all the
14466 type's constraints.
14468 * class.cs (TypeContainer.DefineType): Call
14469 TypeParameter.Resolve() before actually defining the type.
14471 2003-09-15 Martin Baulig <martin@ximian.com>
14473 * class.cs (TypeContainer.DefineType): Added an error flag to
14474 avoid reporting duplicate CS0146's ("class definition is
14477 * driver.cs (Driver.MainDriver): Abort if
14478 RootContext.ResolveTree() reported any errors.
14480 2003-09-07 Martin Baulig <martin@ximian.com>
14482 * report.cs (Error, Warning): Added overloaded versions which take
14483 a `params object[] args' and call String.Format().
14485 2003-09-07 Martin Baulig <martin@ximian.com>
14487 * decl.cs (DeclSpace..ctor): Don't call
14488 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
14489 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
14490 (DeclSpace.RecordDecl): New method.
14492 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
14494 2003-09-02 Ravi Pratap <ravi@ximian.com>
14496 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
14497 value attributes to be applied to ParameterBuilders.
14499 * class.cs (MethodCore.LabelParameters): Make static and more
14500 generic so that it can be used from other places - like interface
14501 methods, for instance.
14503 * interface.cs (Interface.Emit): Call LabelParameters before
14504 emitting attributes on the InterfaceMethod.
14506 2003-09-07 Martin Baulig <martin@ximian.com>
14508 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
14509 if the number of type parameters doesn't match.
14511 2003-09-04 Martin Baulig <martin@ximian.com>
14513 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
14514 for arrays of generic type params (ie. `!0[]').
14516 2003-09-04 Martin Baulig <martin@ximian.com>
14518 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
14521 2003-09-04 Martin Baulig <martin@ximian.com>
14523 * decl.cs (DeclSpace.LookupGeneric): New method.
14524 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
14527 * generic.cs (TypeParameterExpr): Take a TypeParameter as
14528 argument, not just a string.
14529 (TypeParameter.Define): New public method; this is called to
14530 actually define the generic parameter; after this, you can use the
14531 new `Type' property to get the type.
14533 2003-09-04 Martin Baulig <martin@ximian.com>
14535 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
14536 is now an ArrayList; initialize the result of the `TypeParameters'
14538 (DeclSpace.GetGenericData): Removed.
14539 (DeclSpace.LookupGeneric): Temporarily removed; we need to
14540 implement this in a different way.
14541 (DeclSpace.GetTypeParameters): Removed; there's now a
14542 `TypeParameters' property.
14543 (DeclSpace.TypeParameters): New public property.
14545 * generic.cs (Constraints): Make this class public.
14546 (TypeParameter): New public class.
14548 2003-09-04 Martin Baulig <martin@ximian.com>
14550 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14551 generic parameters.
14553 * class.cs (TypeContainer.DefineType): Call
14554 TypeBuilder.DefineGenericParameter () on all generic parameters if
14555 this is a generic type.
14557 2003-08-28 Martin Baulig <martin@ximian.com>
14559 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14562 * sample-hello.cs: Compile this with gmcs: "gmcs
14563 /r:sample-stack.dll sample-hello.cs".
14565 2003-08-28 Martin Baulig <martin@ximian.com>
14567 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14568 the parameters to the generic type.
14570 2003-08-28 Martin Baulig <martin@ximian.com>
14572 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14574 2003-08-28 Martin Baulig <martin@ximian.com>
14576 * cs-parser.jay (opt_type_argument_list): Use
14577 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14578 (primary_expression): Replace `qualified_identifier' with `type_name'.
14579 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14581 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14582 parser to check whether it is syntactically a type parameter list;
14583 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14586 2003-08-26 Martin Baulig <martin@ximian.com>
14588 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14589 resolving aliases; fixes #47927.
14591 2003-08-26 Martin Baulig <martin@ximian.com>
14593 * statement.cs (Using.DoResolve): This is internally emitting a
14594 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14595 do not always return. Fixes #47681.
14597 2003-08-26 Martin Baulig <martin@ximian.com>
14599 * decl.cs (MemberCore): Moved WarningNotHiding(),
14600 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14602 (AdditionResult): Make this nested in DeclSpace.
14603 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14604 argument; call NamespaceEntry.Define() unless we're nested in a
14607 * namespace.cs (Namespace.DefineName): New public function. This
14608 is called from DeclSpace's .ctor to add
14609 (Namespace.Lookup): Include DeclSpaces in the lookup.
14611 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14613 * const.cs (Const): Derive from MemberBase, not MemberCore.
14615 2003-08-25 Martin Baulig <martin@ximian.com>
14617 * convert.cs (Convert.ExplicitReferenceConversion): When
14618 converting from an interface type to a class, unbox if the target
14619 type is a struct type. Fixes #47822.
14621 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14623 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14626 2003-08-22 Martin Baulig <martin@ximian.com>
14628 * class.cs (TypeManager.DefineType): When defining a nested type,
14629 call DefineType() on our parent; fixes #47801.
14631 2003-08-22 Martin Baulig <martin@ximian.com>
14633 * class.cs (MethodData.Define): While checking if a method is an
14634 interface implementation, improve the test a bit more to fix #47654.
14636 2003-08-22 Martin Baulig <martin@ximian.com>
14638 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14639 correctly; fixes #47722.
14641 2003-08-22 Martin Baulig <martin@ximian.com>
14643 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14644 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14646 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14648 2003-08-22 Martin Baulig <martin@ximian.com>
14650 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14651 can only be assigned in static constructors. Fixes #47161.
14653 2003-08-22 Martin Baulig <martin@ximian.com>
14655 Rewrote and improved the flow analysis code.
14657 * flowbranching.cs (FlowBranching): Make this class abstract.
14658 (FlowBranching.CreateBranching): New static function to create a
14659 new flow branching.
14660 (FlowBranchingBlock, FlowBranchingException): New classes.
14661 (FlowBranching.UsageVector.Type): New public readonly field.
14662 (FlowBranching.UsageVector.Breaks): Removed the setter.
14663 (FlowBranching.UsageVector.Returns): Removed the setter.
14664 (FlowBranching.UsageVector): Added Break(), Return(),
14665 NeverReachable() and Throw() methods to modify the reachability.
14666 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14667 done by FlowBranching.Merge().
14668 (FlowBranching.UsageVector.MergeChild): New method; merges the
14669 merge result into the current vector.
14670 (FlowBranching.Merge): New abstract method to merge a branching.
14672 2003-08-12 Martin Baulig <martin@ximian.com>
14674 * expression.cs (Indirection.CacheTemporaries): Create the
14675 LocalTemporary with the pointer type, not its element type.
14677 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14679 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14680 token was a keyword or not.
14682 Add `error' options where an IDENTIFIER was expected; Provide
14683 CheckToken and CheckIdentifierToken convenience error reporting
14686 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14688 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14689 NameSpaceEntry NameSpaceEntry.
14691 (LookupInterfaceOrClass): Avoid creating a full qualified name
14692 from namespace and name: avoid doing lookups when we know the
14693 namespace is non-existant. Use new Tree.LookupByNamespace which
14694 looks up DeclSpaces based on their namespace, name pair.
14696 * driver.cs: Provide a new `parser verbose' to display the
14697 exception thrown during parsing. This is turned off by default
14698 now, so the output of a failure from mcs is more graceful.
14700 * namespace.cs: Track all the namespaces defined in a hashtable
14703 (IsNamespace): New method
14705 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14707 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14708 we know that we need to concatenate (full typename can never be
14713 * statement.cs: Use a bitfield; Do not initialize to null things
14714 which are done by the constructor by default.
14716 * cs-parser.jay: bug fix, parameter was 4, not 3.
14718 * expression.cs: Just use the property;
14720 * statement.cs: No need for GetVariableInfo method.
14722 2003-08-08 Martin Baulig <martin@ximian.com>
14724 * flowanalysis.cs (FlowReturns): This is now nested in the
14725 `FlowBranching' class.
14726 (MyBitVector): Moved this here from statement.cs.
14727 (FlowBranching.SiblingType): New enum type.
14728 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14730 2003-08-07 Martin Baulig <martin@ximian.com>
14732 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14733 `FlowBranching' class and called `BranchingType'.
14735 2003-08-07 Martin Baulig <martin@ximian.com>
14737 * flowanalysis.cs: Moved all the control flow analysis code into
14740 2003-08-07 Martin Baulig <martin@ximian.com>
14742 * assign.cs (Assign.DoResolve): `target' must either be an
14743 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14746 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14748 * expression.cs (BinaryMethod): This kind of expression is created by the
14749 Binary class if it determines that the operator has to be handled
14752 (BinaryDelegate): This kind of expression is created if we are
14753 dealing with a + or - operator on delegates.
14755 (Binary): remove method, argumetns, and DelegateOperator: when
14756 dealing with methods,
14758 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14760 * statement.cs (Block): use bitfields for the three extra booleans
14761 we had in use. Remove unused topblock parameter.
14763 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14765 * assign.cs: Drop extra unneeded tests.
14767 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14769 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14771 * statement.cs (Foreach): Use VariableStorage instead of
14774 * codegen.cs (VariableStorage): New class used by clients that
14775 require a variable stored: locals or fields for variables that
14776 need to live across yield.
14778 Maybe provide a convenience api for EmitThis+EmitLoad?
14780 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14783 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14785 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14786 RemapParameterLValue): New methods that are used to turn a
14787 precomputed FieldInfo into an expression like this:
14791 The idea is to use this instead of making LocalVariableReference
14792 have more than one meaning.
14794 * cs-parser.jay: Add error production to BASE.
14796 * ecore.cs: Deal with TypeManager.GetField returning null, which
14797 is now a valid return value.
14799 (FieldExprNoAddress): New expression for Fields whose address can
14802 * expression.cs (LocalVariableReference): During the resolve
14803 phases, create new expressions if we are in a remapping context.
14804 Remove code that dealt with remapping here.
14806 (ParameterReference): same.
14808 (ProxyInstance): New expression, like the `This' expression, but
14809 it is born fully resolved. We know what we are doing, so remove
14810 the errors that are targeted to user-provided uses of `this'.
14812 * statement.cs (Foreach): our variable is now stored as an
14813 Expression; During resolution, follow the protocol, dont just
14814 assume it will return this.
14816 2003-08-06 Martin Baulig <martin@ximian.com>
14818 * support.cs (SeekableStreamReader.cs): New public class.
14820 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14821 SeekableStreamReader instead of the normal StreamReader.
14823 2003-08-04 Martin Baulig <martin@ximian.com>
14825 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14826 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14827 deambiguate casts and delegate invocations.
14828 (parenthesized_expression): Use the new tokens to ensure this is
14829 not a cast of method invocation.
14831 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14832 when reading a `)' and Deambiguate_CloseParens () was previously
14835 * expression.cs (ParenthesizedExpression): New class. This is
14836 just used for the CS0075 test.
14837 (Binary.DoResolve): Check for CS0075.
14839 2003-07-29 Ravi Pratap <ravi@ximian.com>
14841 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14842 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14843 reference comparison.
14845 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14846 examine the ReturnType for equality - this is necessary in the
14847 cases of implicit and explicit operators whose signature also
14848 includes the return type.
14850 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14852 * namespace.cs: Cache the result of the namespace computation,
14853 instead of computing it every time.
14855 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14857 * decl.cs: Use a global arraylist that we reuse over invocations
14858 to avoid excesive memory consumption. Reduces memory usage on an
14859 mcs compile by one meg (45 average).
14861 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14862 private, work around that.
14864 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14866 * literal.cs (IntLiteral): Define Zero and One static literals.
14868 * cs-parser.jay (integer_literal): use static literals to reduce
14869 memory usage for the most used literals (0, 1 and -1). 211kb
14870 reduced in memory usage.
14872 Replace all calls to `new ArrayList' with `new
14873 ArrayList(4)' which is a good average number for most allocations,
14874 and also requires only 16 bytes of memory for its buffer by
14877 This reduced MCS memory usage in seven megabytes for the RSS after
14880 2003-07-28 Ravi Pratap <ravi@ximian.com>
14882 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14883 handle params methods the correct way by forming only one
14884 applicable set with params and normal methods in them. Earlier we
14885 were looking at params methods only if we found no normal methods
14886 which was not the correct thing to do.
14888 (Invocation.BetterFunction): Take separate arguments indicating
14889 when candidate and the best method are params methods in their
14892 This fixes bugs #43367 and #46199.
14894 * attribute.cs: Documentation updates.
14896 (CheckAttribute): Rename to CheckAttributeTarget.
14897 (GetValidPlaces): Rename to GetValidTargets.
14899 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14900 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14904 2003-07-28 Miguel de Icaza <miguel@ximian.com>
14906 * codegen.cs: Compute IsGeneric correctly.
14908 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
14911 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
14912 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
14913 regressions, and I was chasing more bugs than I required.
14915 * interface.cs: Use expressions for base type names (like classes
14916 and structs have been doing for a while now), and resolve that.
14917 This patch should probably go into head as well.
14919 This makes it one less user of FindType.
14921 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14923 This compiler can not self host currently. Need to fix that.
14925 * Makefile: compile to `gmcs.exe'
14927 * driver.cs: Turn on v2 by default on gmcs.
14929 * generic.cs (ConstructedType): Does no longer take a container
14930 type argument; That will be taken care of later.
14932 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
14933 Use SimpleName to resolve for now, so we can continue the work on
14934 the parser, until we get Type.GetType that understands generics.
14936 (ConstructedType.ToString): Implement
14938 (TypeArguments.Resolve): Resolve the child expressions as types.
14940 * cs-parser.jay: Rename interface_constraints to
14941 type_parameter_constraints
14943 (namespace_or_type_name): Only use constructed types for the basic
14944 construction, we will deal with identifier<...> later.
14946 (type/type_name): No longer call DecomposeQI, as
14947 namespace_or_type_name is always decoded now.
14949 2003-07-22 Ravi Pratap <ravi@ximian.com>
14951 * expression.cs (Invocation.OverloadResolve): Follow the spec more
14952 closely: we eliminate methods in base types when we have an
14953 applicable method in a top-level type.
14955 Please see section 14.5.5.1 for an exact description of what goes
14958 This fixes bug #45127 and a host of other related to corlib compilation.
14960 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
14961 array is the method corresponding to the top-level type (this is
14962 because of the changes made to icall.c) so we change this
14965 (MethodGroupExpr.Name): This too.
14967 * typemanager.cs (GetElementType): New method which does the right
14968 thing when compiling corlib.
14970 * everywhere: Make use of the above in the relevant places.
14972 2003-07-22 Martin Baulig <martin@ximian.com>
14974 * cs-parser.jay (invocation_expression): Moved
14975 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
14976 `cast_expression', but create a InvocationOrCast which later
14977 resolves to either an Invocation or a Cast.
14979 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
14980 method; call this before EmitStatement() to make sure that this
14981 expression can be used as a statement.
14983 * expression.cs (InvocationOrCast): New class; resolves to either
14984 an Invocation or a Cast.
14986 * statement.cs (StatementExpression): Call ResolveStatement() on
14987 the ExpressionStatement before emitting it.
14989 2003-07-21 Martin Baulig <martin@ximian.com>
14991 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
14992 `ref' and `out' attributes match; fixes #46220.
14993 (MemberAccess.ResolveMemberAccess): You can't reference a type
14994 through an expression; fixes #33180.
14995 (Indexers.GetIndexersForType): Don't return the indexers from
14996 interfaces the class implements; fixes #46502.
14998 2003-07-21 Martin Baulig <martin@ximian.com>
15000 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
15001 CS0661 checks; fixes bug #30442.
15003 2003-07-21 Martin Baulig <martin@ximian.com>
15005 * decl.cs (AdditionResult): Added `Error'.
15007 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
15009 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
15010 cs0031.cs actually work.
15012 2003-07-20 Miguel de Icaza <miguel@ximian.com>
15014 * cs-parser.jay (namespace_name): do not use
15015 namespace_or_type_name, use qualified_identifier, because
15016 namespace_or_type_name will soon return a composed expression
15017 instead of a string.
15019 (namespace_or_type_name): Instead of returning a string, now this
15020 production returns an expression.
15022 * codegen.cs (EmitContext): Setup IsGeneric property based on
15023 whether our DeclSpace is generic, our the method is generic.
15025 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
15026 the method is generic.
15028 * cs-parser.jay (type_arguments, opt_type_argument_list,
15029 type_parameters, type_parameter_list, opt_type_parameter_list,
15030 type_parameter,, opt_type_parameter_constraints_clauses,
15031 type_parameter_constraints_clauses,
15032 type_parameter_constraint_clause, type_parameter_constraint,
15033 interface_constraints): Add new production
15035 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
15036 DeclSpace is generic or not.
15038 (DeclSpace.SetParameterInfo): New routine, used to set the
15039 parameter info for a type.
15041 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
15042 returns a GenericTypeExpr
15044 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
15045 generic, lookup the generic argument.
15047 * attribute.cs: Do not allow TypeParameterExpressions in
15050 * class.cs: Do not allow the Main method to be defined in a
15053 * expression.cs (SizeOf): Do not allow generic types to be used as
15054 arguments to sizeof.
15056 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
15057 it: whether a type is generic or not. Only works for types we are
15058 currently building for now.
15060 2003-07-20 Martin Baulig <martin@ximian.com>
15062 * namespace.cs: Fixed that bug which caused a crash when compiling
15063 the debugger's GUI.
15065 2003-07-20 Miguel de Icaza <miguel@ximian.com>
15067 * typemanager.cs (LookupTypeReflection): Never expose types which
15068 are NotPublic, NestedPrivate, NestedAssembly, or
15069 NestedFamANDAssem. We used to return these, and later do a check
15070 that would report a meaningful error, but the problem is that we
15071 would not get the real match, if there was a name override.
15073 2003-07-18 Miguel de Icaza <miguel@ximian.com>
15075 * namespace.cs (Namespace, Name): Do not compute the namespace
15076 name dynamically, compute it in the constructor. This reduced
15077 memory usage by 1697 KB.
15079 * driver.cs: Use --pause to pause at the end.
15081 2003-07-17 Peter Williams <peter@newton.cx>
15083 * Makefile: Change the name of the test target so that it doesn't
15084 conflict with the recursive test target.
15086 2003-07-17 Miguel de Icaza <miguel@ximian.com>
15088 * expression.cs (LocalVariableReference.Emit, EmitAssign,
15089 AddressOf): Do not use EmitThis, that was wrong, use the actual
15092 2003-07-15 Miguel de Icaza <miguel@ximian.com>
15094 * class.cs (MethodData.Define): While checking if a method is an
15095 interface implementation, improve the test: If we are not public
15096 (use new test here: use the computed MethodAttributes directly,
15097 instead of the parsed modifier flags) check if the `implementing'
15098 method comes from an interface or not.
15100 * pending.cs (VerifyPendingMethods): Slightly better error
15103 * makefile: add test target that does the mcs bootstrap.
15105 2003-07-16 Ravi Pratap <ravi@ximian.com>
15107 * interface.cs (Define): Do nothing here since there are no
15108 members to populate etc. Move the attribute emission out of here
15109 since this was just totally the wrong place to put it. Attribute
15110 application happens during the 'Emit' phase, not in the 'Define'
15113 (Emit): Add this method and move the attribute emission here
15115 * rootcontext.cs (EmitCode): Call the Emit method on interface
15118 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15120 * expression.cs (OverloadResolve): Report error only if Location
15121 is not 'Null' which means that there was a probe going on.
15123 2003-07-14 Martin Baulig <martin@ximian.com>
15125 * expression.cs (ConditionalLogicalOperator): New public class to
15126 implement user defined conditional logical operators.
15127 This is section 14.11.2 in the spec and bug #40505.
15129 2003-07-14 Martin Baulig <martin@ximian.com>
15131 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
15133 2003-07-14 Martin Baulig <martin@ximian.com>
15135 * codegen.cs (EmitContext.InFixedInitializer): New public field.
15137 * ecore.cs (IVariable.VerifyFixed): New interface method.
15139 * expression.cs (Unary.ResolveOperator): When resolving the `&'
15140 operator, check whether the variable is actually fixed. Fixes bug
15141 #36055. Set a variable definitely assigned when taking its
15142 address as required by the spec.
15144 * statement.cs (LocalInfo.IsFixed): New field.
15145 (LocalInfo.MakePinned): Set `IsFixed' to true.
15147 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15149 * attribute.cs (Attribute.Resolve): While doing a Member lookup
15150 for .ctors, ensure that we only ask for members declared in the
15151 attribute type (BindingFlags.DeclaredOnly).
15155 * expression.cs (Error_WrongNumArguments): Report error 1501
15156 correctly the way CSC does.
15158 2003-07-13 Martin Baulig <martin@ximian.com>
15160 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
15161 lookup on the fully qualified name, to make things like "X.X" work
15162 where "X.X" is a fully qualified type name, but we also have a
15163 namespace "X" in the using list. Fixes #41975.
15165 2003-07-13 Martin Baulig <martin@ximian.com>
15167 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
15168 function. If we're a CompoundAssign, we need to create an embedded
15169 CompoundAssign, not an embedded Assign.
15170 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
15173 2003-07-13 Martin Baulig <martin@ximian.com>
15175 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
15176 work to fix bug #46088.
15178 2003-07-13 Ravi Pratap <ravi@ximian.com>
15180 * class.cs (Operator.Emit): Do not emit attributes here - it is
15181 taken care of by the Method class that we delegate too. This takes
15182 care of bug #45876.
15184 2003-07-10 Martin Baulig <martin@ximian.com>
15186 * expression.cs (TypeOfVoid): New class.
15187 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
15189 2003-07-10 Martin Baulig <martin@ximian.com>
15191 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
15194 2003-07-10 Martin Baulig <martin@ximian.com>
15196 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
15197 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
15199 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
15201 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
15203 2003-07-10 Martin Baulig <martin@ximian.com>
15205 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
15206 of decimal. Fixes #42850.
15208 NOTE: I also fixed the created byte blob, but this doesn't work on
15209 the MS runtime and csc never produces any byte blobs for decimal
15212 2003-07-10 Martin Baulig <martin@ximian.com>
15214 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
15215 structs; fixes #32068.
15216 (Block.AddChildVariableNames): Fixed #44302.
15218 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15220 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
15222 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15224 * attribute.cs: And this test is onger needed.
15226 2003-07-08 Martin Baulig <martin@ximian.com>
15228 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
15229 inaccessible types. Fixes #36313.
15231 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
15233 * namespace.cs (NamespaceEntry): Create implicit entries for all
15234 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
15235 implicit entries for N1.N2 and N1.
15237 2003-07-08 Martin Baulig <martin@ximian.com>
15239 Rewrote the handling of namespaces to fix a lot of the issues
15240 wrt. `using' aliases etc.
15242 * namespace.cs (Namespace): Splitted this class into a
15243 per-assembly `Namespace' and a per-file `NamespaceEntry'.
15245 * typemanager.cs (TypeManager.IsNamespace): Removed.
15246 (TypeManager.ComputeNamespaces): Only compute namespaces from
15247 loaded assemblies here, not the namespaces from the assembly we're
15248 currently compiling.
15250 2003-07-08 Martin Baulig <martin@ximian.com>
15252 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
15254 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15256 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
15259 I thought about the memory savings here, but LookupTypeReflection
15260 is used under already very constrained scenarios. Compiling
15261 corlib or mcs only exposes one hit, so it would not really reduce
15262 any memory consumption.
15264 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15266 * typemanager.cs: fixes bug #45889 by only adding public types from
15267 other assemblies to the list of known types.
15269 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15271 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
15272 on the type we resolved.
15274 2003-07-05 Martin Baulig <martin@ximian.com>
15276 * pending.cs (PendingImplementation.ParentImplements): Don't
15277 create the proxy if the parent is abstract.
15279 * class.cs (TypeContainer.DefineIndexers): Process explicit
15280 interface implementations first. Fixes #37714.
15282 2003-07-04 Miguel de Icaza <miguel@ximian.com>
15284 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
15285 defined recursively; but since we modify the input parameters
15286 (left is set to `this' temporarily), we reset this value if the
15287 left_is_explicit is false, which gives the original semantics to
15290 * literal.cs (NullPointer): new class used to represent a null
15291 literal in a pointer context.
15293 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
15294 type is a pointer, use a NullPointer object instead of a
15295 NullLiteral. Closes 43687
15297 (ExplicitConversion): Convert pointer values using
15298 the conv opcode to the proper type.
15300 * ecore.cs (New): change ValueTypeVariable property into a method,
15301 that returns whether the valuetype is suitable for being used.
15303 * expression.cs (Binary.DoNumericPromotions): Only return if we
15304 the int constant was a valid uint, and we can return both left and
15305 right as uints. If not, we continue processing, to trigger the
15306 type conversion. This fixes 39018.
15308 * statement.cs (Block.EmitMeta): During constant resolution, set
15309 the CurrentBlock property on the emitcontext, so that we resolve
15310 constants propertly.
15312 2003-07-02 Martin Baulig <martin@ximian.com>
15314 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
15315 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
15317 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
15318 than emitting it here.
15320 * statement.cs: Fixed some more flow analysis bugs.
15322 2003-07-02 Martin Baulig <martin@ximian.com>
15324 * class.cs (MethodData.Define): When implementing interface
15325 methods, set Final unless we're Virtual.
15327 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
15328 check work for interface methods.
15330 2003-07-01 Martin Baulig <martin@ximian.com>
15332 * ecore.cs (EmitContext.This): Replaced this property with a
15333 GetThis() method which takes a Location argument. This ensures
15334 that we get the correct error location for a CS0188.
15336 2003-07-01 Miguel de Icaza <miguel@ximian.com>
15338 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
15339 ImplicitStandardConversion.
15341 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
15343 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
15345 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
15348 2003-06-30 Miguel de Icaza <miguel@ximian.com>
15350 * class.cs (Constructor.Define): Turn off initlocals for unsafe
15353 (MethodData.Define): Turn off initlocals for unsafe methods.
15355 2003-06-29 Miguel de Icaza <miguel@ximian.com>
15357 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
15358 complete; Fixes #37521.
15360 * delegate.cs: Use Modifiers.TypeAttr to compute the
15361 TypeAttributes, instead of rolling our own. This makes the flags
15362 correct for the delegates.
15364 2003-06-28 Miguel de Icaza <miguel@ximian.com>
15366 * class.cs (Constructor.Define): Set the private flag for static
15367 constructors as well.
15369 * cs-parser.jay (statement_expression): Set the return value to
15370 null, to avoid a crash when we catch an error.
15372 2003-06-24 Miguel de Icaza <miguel@ximian.com>
15374 * cs-parser.jay: Applied patch from Jackson that adds support for
15375 extern and unsafe modifiers to destructor declarations.
15377 * expression.cs: Report error 21 if the user is trying to index a
15380 * driver.cs: Add an error message, suggested by the bug report.
15382 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
15383 if we do not have a ": this ()" constructor initializer. Fixes 45149
15385 2003-06-14 Miguel de Icaza <miguel@ximian.com>
15387 * namespace.cs: Add some information to reduce FAQs.
15389 2003-06-13 Miguel de Icaza <miguel@ximian.com>
15391 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
15392 underlying enumeration types. Fixes #43915.
15394 * expression.cs: Treat ushort/short as legal values to be used in
15395 bitwise operations.
15397 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
15399 * delegate.cs: transfer custom attributes for paramenters from
15400 the delegate declaration to Invoke and BeginInvoke.
15402 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
15404 * attribute.cs: handle custom marshalers and emit marshal info
15407 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
15409 * makefile.gnu: Added anonymous.cs to the compiler sources.
15411 2003-05-28 Miguel de Icaza <miguel@ximian.com>
15413 * iterators.cs: Change the name of the proxy class to include two
15416 * cs-parser.jay: Update grammar to include anonymous methods.
15418 * anonymous.cs: new file.
15420 2003-05-27 Miguel de Icaza <miguel@ximian.com>
15422 * class.cs (Field.Define): Add missing test for pointers and
15425 2003-05-27 Ravi Pratap <ravi@ximian.com>
15427 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
15428 we use the stobj opcode.
15430 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
15431 since it wasn't the correct fix.
15433 It still is puzzling that we are required to use stobj for IntPtr
15434 which seems to be a ValueType.
15436 2003-05-26 Miguel de Icaza <miguel@ximian.com>
15438 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
15439 during regular simple name resolution. Now, the trick is that
15440 instead of returning for processing the simplename, we do a
15441 TypeManager.LookupType (ie, a rooted lookup as opposed to a
15442 contextual lookup type). If a match is found, return that, if
15443 not, return for further composition.
15445 This fixes long-standing 30485.
15447 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15448 using the address to initialize an object, do an Stobj instead of
15449 using the regular Stelem.
15451 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
15452 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
15453 Because if we are a BaseIndexerAccess that value will be true.
15456 * statement.cs (GotoCase.Resolve): Return after reporting an
15457 error, do not attempt to continue.
15459 * expression.cs (PointerArithmetic.Emit): If our operand is a
15460 long, convert our constants to match the operand before
15461 multiplying. Convert to I type before adding. Fixes 43670.
15463 2003-05-14 Ravi Pratap <ravi@ximian.com>
15465 * enum.cs (ImplicitConversionExists) : Rename to
15466 ImplicitEnumConversionExists to remove ambiguity.
15468 * ecore.cs (NullCast): New type of cast expression class which
15469 basically is very similar to EmptyCast with the difference being
15470 it still is a constant since it is used only to cast a null to
15472 (eg. (string) null)
15474 * convert.cs (ImplicitReferenceConversion): When casting a null
15475 literal, we return a NullCast.
15477 * literal.cs (NullLiteralTyped): Remove - I don't see why this
15478 should be around anymore.
15480 The renaming (reported was slightly wrong). Corrections:
15482 ConvertImplicitStandard -> ImplicitConversionStandard
15483 ConvertExplicitStandard -> ExplicitConversionStandard
15485 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
15486 before passing them in !
15488 * convert.cs (ImplicitConversionStandard): When comparing for
15489 equal expr and target types, ensure that expr is not a
15492 In general, we must not be checking (expr_type ==
15493 target_type) in the top level conversion methods
15494 (ImplicitConversion, ExplicitConversion etc). This checking is
15495 done in the methods that they delegate to.
15497 2003-05-20 Miguel de Icaza <miguel@ximian.com>
15499 * convert.cs: Move Error_CannotConvertType,
15500 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
15501 ImplicitNumericConversion, ImplicitConversionExists,
15502 ImplicitUserConversionExists, StandardConversionExists,
15503 FindMostEncompassedType, FindMostSpecificSource,
15504 FindMostSpecificTarget, ImplicitUserConversion,
15505 ExplicitUserConversion, GetConversionOperators,
15506 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
15507 TryImplicitIntConversion, Error_CannotConvertImplicit,
15508 ConvertImplicitRequired, ConvertNumericExplicit,
15509 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
15510 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
15513 Perform the following renames:
15515 StandardConversionExists -> ImplicitStandardConversionExists
15516 ConvertImplicit -> ImplicitConversion
15517 ConvertImplicitStandard -> ImplicitStandardConversion
15518 TryImplicitIntConversion -> ImplicitIntConversion
15519 ConvertImplicitRequired -> ImplicitConversionRequired
15520 ConvertNumericExplicit -> ExplicitNumericConversion
15521 ConvertReferenceExplicit -> ExplicitReferenceConversion
15522 ConvertExplicit -> ExplicitConversion
15523 ConvertExplicitStandard -> ExplicitStandardConversion
15525 2003-05-19 Martin Baulig <martin@ximian.com>
15527 * statement.cs (TypeInfo.StructInfo): Made this type protected.
15528 (TypeInfo): Added support for structs having structs as fields.
15530 * ecore.cs (FieldExpr): Implement IVariable.
15531 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
15532 VariableInfo for the field.
15534 2003-05-18 Martin Baulig <martin@ximian.com>
15536 * expression.cs (This.DoResolve): Report a CS0027 if we're
15537 emitting a field initializer.
15539 2003-05-18 Martin Baulig <martin@ximian.com>
15541 * expression.cs (This.ResolveBase): New public function.
15542 (This.DoResolve): Check for CS0188.
15544 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
15547 * ecore.cs (MethodGroupExpr.DoResolve): Set the
15548 `instance_expression' to null if we don't have any non-static
15551 2003-05-18 Martin Baulig <martin@ximian.com>
15553 Reworked the way how local variables and parameters are handled by
15554 the flow analysis code.
15556 * statement.cs (TypeInfo, VariableMap): New public classes.
15557 (VariableInfo): New public class. This is now responsible for
15558 checking whether a variable has been assigned. It is used for
15559 parameters and local variables.
15560 (Block.EmitMeta): Take the InternalParameters as argument; compute
15561 the layout of the flow vectors here.
15562 (Block.LocalMap, Block.ParameterMap): New public properties.
15563 (FlowBranching): The .ctor doesn't get the InternalParameters
15564 anymore since Block.EmitMeta() now computes the layout of the flow
15566 (MyStructInfo): This class is now known as `StructInfo' and nested
15567 in `TypeInfo'; we don't access this directly anymore.
15569 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15570 property and removed IsAssigned(), IsFieldAssigned(),
15571 SetAssigned() and SetFieldAssigned(); we now call them on the
15572 VariableInfo so we don't need to duplicate this code everywhere.
15574 * expression.cs (ParameterReference): Added `Block block' argument
15576 (LocalVariableReference, ParameterReference, This): The new
15577 VariableInfo class is now responsible for all the definite
15580 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15581 IsParameterAssigned, SetParameterAssigned): Removed.
15583 2003-05-18 Martin Baulig <martin@ximian.com>
15585 * typemanager.cs (InitCoreTypes): Try calling
15586 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15587 the 3-args-version. Corlib now also needs our `void_type'.
15588 (GetMethod): Added overloaded version which takes an optional
15589 `bool report_errors' to allow lookups of optional methods.
15591 2003-05-12 Martin Baulig <martin@ximian.com>
15593 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15594 only used for locals and not for parameters.
15596 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15598 * support.cs (InternalParameters.ParameterType): Return the
15599 ExternalType of the parameter.
15601 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15604 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15606 * class.cs (MethodData.Define): Do not set the `newslot' on
15607 interface members, if they are also flagged as "override".
15609 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15610 better code for ++i and i++. This only works for static fields
15611 and local variables.
15613 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15614 want to pull the DeclSpace out of the builder_to_declspace instead
15615 of the TypeBuilder (like in TypeContainer.FindMembers).
15617 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15618 instead of LookupTypeContainer. Fixes the crash on .NET for
15619 looking up interface members.
15621 * const.cs: Create our own emit context during the Definition
15622 stage, so that constants are evaluated in the proper context, when
15623 a recursive definition happens.
15625 2003-05-11 Martin Baulig <martin@ximian.com>
15627 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15628 new block for a switch section.
15629 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15630 the adding/lookup in the switch block. Fixes #39828.
15632 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15634 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15635 functionality: I needed to convert the data after I had performed
15636 the add/sub operation into the operands type size.
15638 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15639 pass the type for the box operation, otherwise the resulting
15640 object would have been of type object.
15642 (BoxedCast): Add constructor to specify the type to box as.
15644 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15646 * iterators.cs: I was reusing the `count' variable inadvertently,
15647 take steps to not allow this to happen.
15649 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15651 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15652 by creating an array at the point where the params starts and
15653 putting all those arguments there, then adjusting the size of the
15656 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15658 * expression.cs (New.AddressOf): Implement interface
15659 IMemoryLocation. This is used when the `new' operator is used in
15660 the context of an invocation to a method on a value type.
15662 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15665 * namespace.cs: Also check the using aliases here.
15667 * driver.cs: Move the test for using validity after the types have
15668 been entered, so we do a single pass that also includes the using
15671 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15672 in the regular case. CreateSiblingForFinally is doing extra
15675 * attribute.cs (GetAttributeArgumentExpression): Store the result
15676 on an out value, and use the return value to indicate failure
15677 instead of using null (which is a valid return for Constant.GetValue).
15679 * statement.cs: Perform the analysis flow for the increment
15680 portion after the statement, because this will be the real flow of
15681 execution. Fixes #42385
15683 * codegen.cs (EmitContext.EmitArgument,
15684 EmitContext.EmitStoreArgument): New helper functions when the
15685 RemapToProxy flag is set.
15687 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15690 Add support for remapping parameters.
15692 * iterators.cs: Propagate parameter values; Store parameter
15693 values in the proxy classes.
15695 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15697 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15698 need a proxy reference; I do not know what I was thinking
15700 * cs-parser.jay (constructor_initializer): catch another error,
15701 and display nice message.
15703 (field_declaration): catch void field declaration
15704 to flag a better error.
15706 * class.cs (MemberBase.CheckBase): Report an error instead of a
15707 warning if a new protected member is declared in a struct.
15708 (Field.Define): catch the error of readonly/volatile.
15710 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15712 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15713 volatile variable is taken
15715 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15717 * statement.cs (Fixed.Resolve): Report an error if we are not in
15720 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15722 * typemanager.cs: reuse the code that handles type clashes for
15723 delegates and enumerations.
15725 * class.cs (Report28): Always report.
15727 * expression.cs (EncodeAsAttribute): Allow nulls here.
15729 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15731 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15732 the functionality for testing whether an expression is valid for
15733 an attribute here. Also handle the case of arrays of elements
15736 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15737 encoding a linear array into an array of objects that are suitable
15738 to be passed to an CustomAttributeBuilder.
15740 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15742 * ecore.cs: (FieldExpr): Handle field remapping here.
15744 * iteratators.cs: Pass the instance variable (if the method is an
15745 instance method) to the constructors, so we can access the field
15746 variables on the class.
15748 TODO: Test this with structs. I think the THIS variable on
15749 structs might have to be a pointer, and not a refenrece
15751 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15753 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15754 local variables to fields in a proxy class.
15756 * iterators.cs (PopulateProxy): Rename our internal fields to
15758 Create a <THIS> field if we are an instance method, so we can
15759 reference our parent container variables.
15760 (MapVariable): Called back from the EmitContext code to enter a
15761 new variable to field mapping into the proxy class (we just create
15765 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15766 for using the remapped locals to fields.
15768 I placed the code here, because that gives the same semantics to
15769 local variables, and only changes the Emit code.
15771 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15772 statements inside iterators.
15773 (VariableInfo): Add a FieldBuilder for the cases when we are
15774 remapping local variables to fields in a proxy class
15776 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15777 current_block != null.
15779 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15780 not cope with strings, as it has been moved to the
15781 TableSwitchEmit. Fixed bug in switch generation.
15783 * expression.cs (New.DoResolve): Provide more context for the user
15784 when reporting an error.
15786 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15789 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15790 check the permissions for it. Note than in a type-resolution
15791 context the check was already present in DeclSpace.ResolveType,
15792 but was missing from the MemberAccess.
15794 (ArrayCreation.CheckIndices): warn if the user has
15795 more nested levels of expressions, but there are no more
15796 dimensions specified. Avoids crash on bug 41906.
15798 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15800 * statement.cs (Block): replace Implicit bool, for a generic
15802 New flag: `Unchecked'. This is used during the EmitMeta phase
15803 (which is out-of-line with the regular Resolve/Emit process for a
15804 statement, as this is done ahead of time, but still gets a chance
15805 to call constant resolve).
15807 (Block.Flags): new enum for adding a new flag.
15809 (Block.EmitMeta): track the state of unchecked.
15811 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15812 to enable constant resolution to work there as well.
15814 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15816 * typemanager.cs (ienumerable_type): Also look up
15817 System.Collections.IEnumerable.
15819 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15821 TODO: Test more than one conditional per method.
15823 * class.cs (Indexer.Define): Report the location where the user is
15824 referencing the unsupported feature.
15826 (MethodData): Overload the use of `conditionals' to
15827 minimize the creation of needless ArrayLists. This saves roughly
15828 212kb on my machine.
15830 (Method): Implement the new IIteratorContainer interface.
15831 (Method.SetYields): Implement the method by setting the ModFlags
15832 to contain METHOD_YIELDS.
15834 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15835 which just got set to null.
15837 * iterators.cs: New file.
15839 (Yield, YieldBreak): New statements.
15841 * statement.cs (Return.Resolve): Flag an error if we are used in
15842 an iterator method.
15844 * codegen.cs (InIterator): New flag set if the code is being
15845 compiled in an iterator method.
15847 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15848 internal modifier, and we just use it to avoid adding extra
15849 fields, as this is seldom used.
15851 * cs-parser.jay: Add yield_statement (yield and yield break).
15853 * driver.cs: New flag -v2 to turn on version 2 features.
15855 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15856 hashtable when v2 is enabled.
15858 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15860 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15861 there is already a namespace defined with this name.
15863 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15864 people upgraded their corlibs.
15866 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15867 always use fully qualified types, no need to use the compiler
15870 (TypeManager.IsNamespace): Use binarysearch.
15872 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15873 AddDelegate): I did not quite use the new IsValid API properly: I
15874 have to pass the short-name and the fullname. I was passing only
15875 the basename instead of the fullname sometimes.
15877 (TypeContainer.DefineType): call NamespaceClash.
15879 * interface.cs (Interface.DefineType): use NamespaceClash before
15882 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15885 * enum.cs: (Enum.DefineType): use NamespaceClash before
15888 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15889 speed increase. First, use the negative_hits cache when we get a
15890 negative. Second, add the type with its full original name
15891 instead of the new . and + encoded name (reflection uses + to
15892 separate type from a nested type). Use LookupTypeReflection
15893 directly which bypasses the type->name hashtable (that we already
15894 know does not contain the type.
15896 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15897 location/container type.
15899 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15901 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15903 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15905 * delegate.cs (NewDelegate.Resolve): Test whether an instance
15906 method is being referenced in the method group from a static
15907 context, and report error 120 if so.
15909 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
15912 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
15913 is created, we create the A namespace).
15915 * cs-parser.jay: A namespace also introduces a DeclarationFound.
15918 2003-04-18 Miguel de Icaza <miguel@ximian.com>
15920 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
15921 invocation to ModuleBuilder.GetType with the same values will
15922 return a new type instance, so we need to cache its return
15925 * expression.cs (Binary.ResolveOperator): Only allow the compare
15926 operators on enums if they are of the same type.
15928 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
15929 types of ValueType on their own case. Before we were giving them
15930 the same treatment as objects.
15932 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
15933 fullname. Short name is used to compare against container name.
15934 Fullname is used to check against defined namespace names.
15936 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
15937 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
15939 (Method.CheckBase): Call parent.
15940 (MemberBase.CheckBase): Check for protected members on sealed
15942 (PropertyBase.CheckBase): Call parent.
15943 (Field.Define): Call parent.
15945 * report.cs: Negative error codes are now mapped to 8000 - code,
15946 so that the display is render more nicely.
15948 * typemanager.cs: Do not use try/catch, instead report a regular
15951 (GetPointerType, GetReferenceType): These methods provide
15952 mechanisms to obtain the T* and T& from a T. We had the code
15953 previously scattered around the code base, and it also used
15954 TypeManager.LookupType that would go through plenty of caches.
15955 This one goes directly to the type source.
15957 In some places we did the Type.GetType followed by
15958 ModuleBuilder.GetType, but not in others, so this unifies the
15959 processing as well.
15961 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
15962 statements now that we have namespace information.
15964 * typemanager.cs (IsNamespace): New method, returns whether the
15965 string presented is a namespace or not.
15967 (ComputeNamespaces): New public entry point, computes the list of
15968 available namespaces, using the GetNamespaces API call in Mono, or
15969 the slower version in MS.NET.
15971 Now before we start the semantic analysis phase, we have a
15972 complete list of namespaces including everything that the user has
15975 Deleted old code to cache namespaces in .nsc files.
15977 2003-04-17 Miguel de Icaza <miguel@ximian.com>
15979 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
15980 class/struct location definition Location for the implicit
15981 constructor location.
15983 (Operator.Define): Use the location of the operator for the
15984 implicit Method definition.
15986 (Constructor.Emit): use the constructor location for the implicit
15987 base initializer constructor.
15989 * ecore.cs: Remove ITypeExpression. This interface is now gone,
15990 and the Expression class now contains two new methods:
15992 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
15993 isolate type lookup from the rest of the resolution process.
15995 Since we use Expressions to hold type definitions due to the way
15996 we parse the input we have historically overloaded Resolve to
15997 perform the Type lookups if a special flag is passed. Now this is
15998 eliminated and two methods take their place.
16000 The differences in the two methods between xStep and xTerminal is
16001 that xStep is involved in our current lookup system that uses
16002 SimpleNames to compose a name, while xTerminal is used just to
16003 catch the case where the simplename lookup failed.
16005 2003-04-16 Miguel de Icaza <miguel@ximian.com>
16007 * expression.cs (ResolveMemberAccess): Remove redundant code.
16008 TypeExpr expressions are always born fully resolved.
16010 * interface.cs (PopulateMethod): Do not lookup the types twice.
16011 We were doing it once during SemanticAnalysis and once during
16014 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
16015 in local variable type definitions, were being returned as a
16016 SimpleName (we decomposed everything into a string), that is
16017 because primary_expression was being used instead of a type in the
16018 grammar (reduce/reduce conflicts).
16020 The part that was wrong is that we converted the expression into a
16021 string (an oversimplification in one hand, compounded with primary
16022 expressions doing string concatenation).
16028 Would return "A.B.C[]" as a SimpleName. This stopped things like
16029 using clauses from working on this particular context. And a type
16030 was being matched directly against "A.B.C[]".
16032 We now use the correct approach, and allow for ComposedCast to be
16033 part of the unary expression. So the "A.B.C []" become a composed
16034 cast of "A.B.C" (as a nested group of MemberAccess with a
16035 SimpleName at the end) plus the rank composition "[]".
16039 2003-04-10 Miguel de Icaza <miguel@ximian.com>
16041 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
16042 for the access level checking.
16044 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
16045 `TypeContainer container', because I kept getting confused when I
16046 was debugging this code.
16048 * expression.cs (Indexers): Instead of tracking getters/setters,
16049 we now track them in parallel. We create one arraylist less, but
16050 most importantly it is possible now for the LValue code to find a
16051 matching get for a set.
16053 (IndexerAccess.DoResolveLValue): Update the code.
16054 GetIndexersForType has been modified already to extract all the
16055 indexers from a type. The code assumed it did not.
16057 Also make the code set the correct return type for the indexer.
16058 This was fixed a long time ago for properties, but was missing for
16059 indexers. It used to be void_type.
16061 (Binary.Emit): Test first for doubles instead of
16062 floats, as they are more common.
16064 (Binary.EmitBranchable): Use the .un version of the branch opcodes
16065 when dealing with floats and the <=, >= operators. This fixes bug
16068 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
16069 to load the array value by emitting a load on the foreach variable
16070 type. This was incorrect.
16072 We now emit the code to load an element using the the array
16073 variable type, and then we emit the conversion operator.
16077 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
16079 * attribute.cs: Avoid allocation of ArrayLists in the common case.
16081 2003-04-09 Miguel de Icaza <miguel@ximian.com>
16083 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
16084 test for protection before we test for signatures.
16086 (MethodSignature.ToString): implement.
16088 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
16089 to the case where we reduced into a LongConstant.
16091 * decl.cs (CheckAccessLevel): If the type is an array, we can not
16092 depend on whether the information is acurrate, because the
16093 Microsoft runtime will always claim that the array type is public,
16094 regardless of the real state.
16096 If the type is a pointer, another problem happens: the type is
16097 reported as non-public in Microsoft.
16099 In both cases we have to call CheckAccessLevel recursively with
16100 the underlying type as the argument to be tested.
16102 2003-04-08 Miguel de Icaza <miguel@ximian.com>
16104 * assign.cs (Assign.Emit): If we are dealing with a compound
16105 assignment expression, we should use the code path that stores the
16106 intermediate result in a temporary value. This fixes #40903.
16108 *expression.cs (Indirection.ToString): Provide ToString method for
16111 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
16113 * class.cs: Null out fields holding references to Block objects so
16114 they can be garbage collected.
16116 * expression.cs (OverloadResolve): Remove unused local.
16118 2003-04-07 Martin Baulig <martin@ximian.com>
16120 * codegen.cs (EmitContext.CurrentFile): New public field.
16121 (EmitContext.Mark): Use the CurrentFile to check whether the
16122 location is in the correct file.
16123 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
16125 2003-04-07 Martin Baulig <martin@ximian.com>
16127 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
16129 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
16130 location. [FIXME: The location argument which gets passed to this
16131 method is sometimes wrong!]
16133 2003-04-07 Nick Drochak <ndrochak@gol.com>
16135 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
16137 2003-04-07 Miguel de Icaza <miguel@ximian.com>
16139 * expression.cs (Indirection.EmitAssign): We were using the
16140 temporary, but returning immediately instead of continuing the
16143 2003-04-06 Martin Baulig <martin@ximian.com>
16145 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
16146 if it's a nested child, but also deriving from the outer class.
16149 * typemanager.cs (IsNestedChildOf): Make this work if it's a
16150 nested child, but also deriving from the outer class. See
16152 (FilterWithClosure): We may access private members of the outer
16153 class if we're a nested child and deriving from the outer class.
16154 (RealMemberLookup): Only set `closure_private_ok' if the
16155 `original_bf' contained BindingFlags.NonPublic.
16157 2003-04-05 Martin Baulig <martin@ximian.com>
16159 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
16160 probe if its a type parameter, and if so, flag an error.
16162 * decl.cs: Move here the SetParameterInfo code from class.cs.
16163 Handle IsGeneric here.
16165 Handle a variety of errors in the parameter info definition.
16167 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
16168 type parameters here.
16170 * cs-parser.jay (class_declaration): report errors for parameters
16173 2003-01-21 Miguel de Icaza <miguel@ximian.com>
16175 * generic.cs: New file, contains support code for generics.
16177 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
16178 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
16180 Update parser for the above removals.
16182 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
16183 now taken care of in the parser.
16185 2003-04-02 Miguel de Icaza <miguel@ximian.com>
16187 * class.cs (Event.Define): Do not allow abstract events to have
16190 2003-04-01 Miguel de Icaza <miguel@ximian.com>
16192 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
16193 block in event declarations.
16195 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
16196 value type, get its address.
16198 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
16199 leaving a class on the stack instead of a boolean value (int
16200 0/1). Change the code so we compare against null, and then the
16201 result against zero.
16203 * class.cs (TypeContainer.GetClassBases): We were checking for the
16204 parent class being sealed too late.
16206 * expression.cs (Binary.Emit): For <= and >= when dealing with
16207 floating point values, use cgt.un and clt.un instead of cgt and
16210 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
16212 * statement.cs: Apply the same optimization as MS: skip the
16213 GetEnumerator returning an IEnumerator, and use the one returning a
16214 CharEnumerator instead. This allows us to avoid the try-finally block
16217 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
16219 * cs-parser.jay: Attributes cannot be applied to
16220 namespaces. Fixes #40473
16222 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16225 (Add*): check if the name is valid using the full name for constants,
16226 fields, properties and events.
16228 2003-03-28 Miguel de Icaza <miguel@ximian.com>
16230 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
16231 char constants to be part of the enumeration.
16233 * expression.cs (Conditional.DoResolve): Add support for operator
16234 true. Implements the missing functionality from 14.12
16236 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
16237 operator true/false as required by the spec.
16239 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
16240 implicit conversion to boolean.
16242 * statement.cs (Statement.ResolveBoolean): A boolean expression is
16243 also one where the type implements `operator true'.
16245 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
16246 get an expression that will invoke operator true based on an
16249 (GetConversionOperators): Removed the hack that called op_True
16252 (Expression.ResolveBoolean): Move this from Statement.
16254 2003-03-17 Miguel de Icaza <miguel@ximian.com>
16256 * ecore.cs (FieldExpr): do not allow initialization of initonly
16257 fields on derived classes
16259 2003-03-13 Martin Baulig <martin@ximian.com>
16261 * statement.cs (Block.Emit): Call ig.BeginScope() and
16262 ig.EndScope() when compiling with debugging info; call
16263 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
16265 2003-03-08 Miguel de Icaza <miguel@ximian.com>
16267 * expression.cs (Indexers): Do not construct immediately, allow
16268 for new members to be appended as we go. Fixes 38143
16270 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16272 * expression.cs: save/restore context when resolving an unchecked
16275 2003-03-05 Miguel de Icaza <miguel@ximian.com>
16277 * cfold.cs: Catch division by zero in modulus operator during
16280 2003-03-03 Miguel de Icaza <miguel@ximian.com>
16282 * interface.cs (Interface.DefineMembers): Avoid defining members
16285 2003-02-27 Miguel de Icaza <miguel@ximian.com>
16287 * driver.cs: handle the +/- options for -noconfig
16289 * statement.cs (Unckeched.Resolve): Also track the state of
16290 unchecked in the Resolve phase.
16292 2003-02-27 Martin Baulig <martin@ximian.com>
16294 * ecore.cs (Expression.MemberLookup): Don't create a
16295 MethodGroupExpr for something which is not a method. Fixes #38291.
16297 2003-02-25 Miguel de Icaza <miguel@ximian.com>
16299 * class.cs (MemberBase.CheckParameters): Also check that the type
16300 is unmanaged if it is a pointer.
16302 * expression.cs (SizeOf.Resolve): Add location information.
16304 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
16305 a managed type is declared.
16307 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
16308 parameter modifiers as well. Fixes bug 38606
16310 * class.cs: Very sad. Am backing out the speed up changes
16311 introduced by the ArrayList -> Array in the TypeContainer, as they
16312 were not actually that much faster, and introduced a bug (no error
16313 reports on duplicated methods).
16315 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
16316 source first, this will guarantee that we have a valid expression
16317 before calling in lower levels functions that will require a
16318 resolved object. Then use this original_source in the
16319 target.ResolveLValue instead of the original source that was
16322 Another change. Use target.Resolve instead of LValueResolve.
16323 Although we are resolving for LValues, we will let the Assign code
16324 take care of that (it will be called again from Resolve). This
16325 basically allows code like this:
16327 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
16328 class Y { void A (X x) { x [0] += o; }
16330 The problem was that the indexer was trying to resolve for
16331 set_Item (idx, object o) and never finding one. The real set_Item
16332 was set_Item (idx, X). By delaying the process we get the right
16337 2003-02-23 Martin Baulig <martin@ximian.com>
16339 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
16340 while calling DoEmit ().
16342 * codegen.cs (EmitContext.Mark): Don't mark locations in other
16343 source files; if you use the #line directive inside a method, the
16344 compiler stops emitting line numbers for the debugger until it
16345 reaches the end of the method or another #line directive which
16346 restores the original file.
16348 2003-02-23 Martin Baulig <martin@ximian.com>
16350 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
16352 2003-02-23 Martin Baulig <martin@ximian.com>
16354 * statement.cs (Block.AddChildVariableNames): We need to call this
16355 recursively, not just for our immediate children.
16357 2003-02-23 Martin Baulig <martin@ximian.com>
16359 * class.cs (Event.Define): Always make the field private, like csc does.
16361 * typemanager.cs (TypeManager.RealMemberLookup): Make events
16362 actually work, fixes bug #37521.
16364 2003-02-23 Miguel de Icaza <miguel@ximian.com>
16366 * delegate.cs: When creating the various temporary "Parameters"
16367 classes, make sure that we call the ComputeAndDefineParameterTypes
16368 on those new parameters (just like we do with the formal ones), to
16369 allow them to be resolved in the context of the DeclSpace.
16371 This fixes the bug that Dick observed in Bugzilla #38530.
16373 2003-02-22 Miguel de Icaza <miguel@ximian.com>
16375 * expression.cs (ResolveMemberAccess): When resolving a constant,
16376 do not attempt to pull a constant if the value was not able to
16377 generate a valid constant.
16379 * const.cs (LookupConstantValue): Do not report more errors than required.
16381 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16383 * expression.cs: fixes bug #38328.
16385 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16387 * class.cs: Changed all the various members that can be part of a
16388 class from being an ArrayList to be an Array of the right type.
16389 During the DefineType type_list, interface_list, delegate_list and
16390 enum_list are turned into types, interfaces, delegates and enums
16393 And during the member population, indexer_list, event_list,
16394 constant_list, field_list, instance_constructor_list, method_list,
16395 operator_list and property_list are turned into their real arrays.
16397 Although we could probably perform this operation earlier, for
16398 good error reporting we need to keep the lists and remove the
16399 lists for longer than required.
16401 This optimization was triggered by Paolo profiling the compiler
16402 speed on the output of `gen-sample-program.pl' perl script.
16404 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
16405 not crash in methods like MemberLookupFailed that use this field.
16407 This problem arises when the compiler fails to resolve a type
16408 during interface type definition for example.
16410 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16412 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
16413 inherit from System.Object, so we have to stop at null, not only
16414 when reaching System.Object.
16416 2003-02-17 Miguel de Icaza <miguel@ximian.com>
16418 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
16419 DeclaredOnly because the parent indexer might have had a different
16420 name, but did not loop until the top of the hierarchy was reached.
16422 The problem this one fixes is 35492: when a class implemented an
16423 indexer from an interface, we were getting the interface method
16424 (which was abstract) and we were flagging an error (can not invoke
16427 This also keeps bug 33089 functioning, and test-148 functioning.
16429 * typemanager.cs (IsSpecialMethod): The correct way of figuring
16430 out if a method is special is to see if it is declared in a
16431 property or event, or whether it is one of the predefined operator
16432 names. This should fix correctly #36804.
16434 2003-02-15 Miguel de Icaza <miguel@ximian.com>
16436 The goal here is to remove the dependency on EmptyCast.Peel ().
16437 Killing it completely.
16439 The problem is that currently in a number of places where
16440 constants are expected, we have to "probe" for an EmptyCast, and
16441 Peel, which is not the correct thing to do, as this will be
16442 repetitive and will likely lead to errors.
16444 The idea is to remove any EmptyCasts that are used in casts that
16445 can be reduced to constants, so we only have to cope with
16448 This bug hunt was triggered by Bug 37363 and the desire to remove
16449 the duplicate pattern where we were "peeling" emptycasts to check
16450 whether they were constants. Now constants will always be
16453 * ecore.cs: Use an enumconstant here instead of wrapping with
16456 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
16457 throwing me off. By handling this we can get rid of a few hacks.
16459 * statement.cs (Switch): Removed Peel() code.
16461 2003-02-14 Miguel de Icaza <miguel@ximian.com>
16463 * class.cs: Location information for error 508
16465 * expression.cs (New.DoResolve): Add a guard against double
16466 resolution of an expression.
16468 The New DoResolve might be called twice when initializing field
16469 expressions (see EmitFieldInitializers, the call to
16470 GetInitializerExpression will perform a resolve on the expression,
16471 and later the assign will trigger another resolution
16473 This leads to bugs (#37014)
16475 * delegate.cs: The signature for EndInvoke should contain any ref
16476 or out parameters as well. We were not doing this in the past.
16478 * class.cs (Field.Define): Do not overwrite the type definition
16479 inside the `volatile' group. Turns out that volatile enumerations
16480 were changing the type here to perform a validity test, which
16483 2003-02-12 Miguel de Icaza <miguel@ximian.com>
16485 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
16486 and structs, we do not want to load the instance variable
16488 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
16489 enum_type has to be handled like an object reference (implicit
16490 conversions exists from this to object), but the regular IsClass
16491 and IsValueType tests will never return true for this one.
16493 Also we use TypeManager.IsValueType instead of type.IsValueType,
16494 just for consistency with the rest of the code (this is only
16495 needed if we ever use the construct exposed by test-180.cs inside
16496 corlib, which we dont today).
16498 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
16500 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
16503 2003-02-09 Martin Baulig <martin@ximian.com>
16505 * namespace.cs (Namespace..ctor): Added SourceFile argument.
16506 (Namespace.DefineNamespaces): New static public method; this is
16507 called when we're compiling with debugging to add all namespaces
16508 to the symbol file.
16510 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
16511 pass it to the Namespace's .ctor.
16513 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
16514 and MethodBase arguments; pass the namespace ID to the symwriter;
16515 pass the MethodBase instead of the token to the symwriter.
16516 (SymbolWriter.DefineNamespace): New method to add a namespace to
16519 2003-02-09 Martin Baulig <martin@ximian.com>
16521 * symbolwriter.cs: New file. This is a wrapper around
16522 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
16523 methods here in near future.
16525 2003-02-09 Martin Baulig <martin@ximian.com>
16527 * codegen.cs (EmitContext.Mark): Just pass the arguments to
16528 ILGenerator.MarkSequencePoint() which are actually used by the
16531 2003-02-09 Martin Baulig <martin@ximian.com>
16533 * location.cs (SourceFile): New public sealed class. This
16534 contains the name and an index which is used in the location's token.
16535 (Location): Reserve an appropriate number of bits in the token for
16536 the source file instead of walking over that list, this gives us a
16537 really huge performance improvement when compiling with debugging.
16539 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
16540 `SourceFile' argument instead of a string.
16541 (Driver.ProcessFile): Add all the files via Location.AddFile(),
16542 but don't parse/tokenize here, we need to generate the list of all
16543 source files before we do that.
16544 (Driver.ProcessFiles): New static function. Parses/tokenizes all
16547 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
16548 instead of a string.
16550 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16553 2003-02-09 Martin Baulig <martin@ximian.com>
16555 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16556 filename on `#line default'.
16558 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16560 * statement.cs: don't clear the pinned var when the fixed statement
16561 returns from the method (fixes bug#37752).
16563 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16565 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16568 2003-02-07 Martin Baulig <martin@ximian.com>
16570 * driver.cs: Removed the `--debug-args' command line argument.
16572 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16573 automatically by the AsssemblyBuilder.
16574 (CodeGen.InitializeSymbolWriter): We don't need to call any
16575 initialization function on the symbol writer anymore. This method
16576 doesn't take any arguments.
16578 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16580 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16581 from referenced assemblies as well.
16583 2003-02-02 Martin Baulig <martin@ximian.com>
16585 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16587 2003-02-02 Martin Baulig <martin@ximian.com>
16589 * class.cs (Constructor.Emit): Open the symbol writer before
16590 emitting the constructor initializer.
16591 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16592 single-stepping through constructor initializers.
16594 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16596 * class.cs: Handle error 549: do not allow virtual methods in
16599 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16601 * decl.cs: Check access levels when resolving types
16603 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16605 * statement.cs: Add parameters and locals set in catch blocks that might
16606 return to set vector
16608 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16610 * class.cs (Operator): Set the SpecialName flags for operators.
16612 * expression.cs (Invocation.DoResolve): Only block calls to
16613 accessors and operators on SpecialName methods.
16615 (Cast.TryReduce): Handle conversions from char constants.
16618 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16620 * statement.cs: small memory and time optimization in FlowBranching.
16622 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16624 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16625 problem that the last fix but in the other sid (Set).
16627 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16628 access when there is no indexer in the hierarchy.
16630 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16632 * class.cs: Combine some if statements.
16634 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16636 * driver.cs: fixed bug #37187.
16638 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16640 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16641 any indexer, it's needed to build a list with all the indexers in the
16642 hierarchy (AllGetters), else we have problems. Fixes #35653.
16644 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16646 * class.cs (MethodData.Define): It is wrong for an interface
16647 implementation to be static in both cases: explicit and implicit.
16648 We were only handling this in one case.
16650 Improve the if situation there to not have negations.
16652 * class.cs (Field.Define): Turns out that we do not need to check
16653 the unsafe bit on field definition, only on usage. Remove the test.
16655 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16657 * driver.cs: use assembly.Location instead of Codebase (the latest
16658 patch made mcs fail when using MS assemblies).
16660 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16662 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16663 get the path to *corlib.dll.
16665 2003-01-21 Nick Drochak <ndrochak@gol.com>
16669 * typemanager.cs: Remove compiler warnings
16671 2003-01-20 Duncan Mak <duncan@ximian.com>
16673 * AssemblyInfo.cs: Bump the version number to 0.19.
16675 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16677 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16679 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16681 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16683 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16685 * cs-parser.jay: Small fix: we were not comparing the constructor
16686 name correctly. Thanks to Zoltan for the initial pointer.
16688 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16690 * cs-tokenizer.cs: Set file name when specified with #line
16692 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16694 * cs-parser.jay: Only perform the constructor checks here if we
16695 are named like the class; This will help provider a better
16696 error. The constructor path is taken when a type definition is
16697 not found, but most likely the user forgot to add the type, so
16698 report that rather than the constructor error.
16700 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16702 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16705 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16707 * cs-parser.jay: Add cleanup call.
16709 2003-01-13 Duncan Mak <duncan@ximian.com>
16711 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16712 consistent with other methods.
16714 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16716 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16718 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16720 * attribute.cs: only set GuidAttr to true when we have a
16723 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16727 * typemanager.cs: fixes to allow mcs compile corlib with the new
16728 Type.IsSubclassOf fix.
16730 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16732 * expression.cs (LocalVariableReference.DoResolve): Classify a
16733 constant as a value, not as a variable. Also, set the type for
16736 * cs-parser.jay (fixed_statement): take a type instead of a
16737 pointer_type, so we can produce a better error message later.
16739 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16742 (For.DoEmit): Make inifinite loops have a
16743 non-conditional branch back.
16745 (Fixed.DoEmit): First populate the pinned variables, then emit the
16746 statement, then clear the variables. Before I was emitting the
16747 code once for each fixed piece.
16750 2003-01-08 Martin Baulig <martin@ximian.com>
16752 * statement.cs (FlowBranching.MergeChild): A break in a
16753 SWITCH_SECTION does not leave a loop. Fixes #36155.
16755 2003-01-08 Martin Baulig <martin@ximian.com>
16757 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16758 lives in the same number space than `param_map'. Fixes #36154.
16760 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16762 * cs-parser.jay (constructor_declaration): Set the
16763 Constructor.ModFlags before probing for it. This makes the
16764 compiler report 514, 515 and 132 (the code was there, but got
16767 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16768 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16769 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16771 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16773 * enum.cs: create the enum static fields using the enum type.
16775 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16777 * class.cs: don't try to create the ParamBuilder for the return
16778 type if it's not needed (and handle it breaking for the ms runtime
16781 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16783 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16785 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16787 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16788 the command. This showed up while compiling the JANET source
16789 code, which used \r as its only newline separator.
16791 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16793 * class.cs (Method.Define): If we are an operator (because it
16794 reuses our code), then set the SpecialName and HideBySig. #36128
16796 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16798 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16799 exception, report error 120 `object reference required'.
16801 * driver.cs: Add --pause option, used during to measure the size
16802 of the process as it goes with --timestamp.
16804 * expression.cs (Invocation.DoResolve): Do not allow methods with
16805 SpecialName to be invoked.
16807 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16809 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16810 number before adding it.
16812 2002-12-21 Ravi Pratap <ravi@ximian.com>
16814 * ecore.cs (StandardImplicitConversion): When in an unsafe
16815 context, we allow conversion between void * to any other pointer
16816 type. This fixes bug #35973.
16818 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16820 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16821 is not thrown when extensionless outputs are used
16823 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16825 * rootcontext.cs: fixed compilation of corlib.
16827 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16829 * attribute.cs (Attributes.Contains): Add new method.
16831 * class.cs (MethodCore.LabelParameters): if the parameter is an
16832 `out' parameter, check that no attribute `[In]' has been passed.
16834 * enum.cs: Handle the `value__' name in an enumeration.
16836 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16838 * decl.cs: Added special case to allow overrides on "protected
16841 2002-12-18 Ravi Pratap <ravi@ximian.com>
16843 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16844 since it makes much more sense.
16846 (Attributes.ctor): Don't require a Location parameter.
16848 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16850 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16851 since we already have that information per attribute.
16853 * everywhere : make appropriate changes.
16855 * class.cs (LabelParameters): Write the code which actually
16856 applies attributes to the return type. We can't do this on the MS
16857 .NET runtime so we flag a warning in the case an exception is
16860 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16862 * const.cs: Handle implicit null conversions here too.
16864 2002-12-17 Ravi Pratap <ravi@ximian.com>
16866 * class.cs (MethodCore.LabelParameters): Remove the extra
16867 Type [] parameter since it is completely unnecessary. Instead
16868 pass in the method's attributes so that we can extract
16869 the "return" attribute.
16871 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16873 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16874 of ignoring it and letting the compile continue.
16876 * typemanager.cs (ChangeType): use an extra argument to return an
16877 error condition instead of throwing an exception.
16879 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16881 * expression.cs (Unary.TryReduce): mimic the code for the regular
16882 code path. Perform an implicit cast in the cases where we can
16883 implicitly convert to one of the integral types, and then reduce
16884 based on that constant. This fixes bug #35483.
16886 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16888 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16890 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16892 * namespace.cs: fixed bug #35489.
16894 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16896 * class.cs: Remove some dead code.
16898 * cs-parser.jay: Estimate the number of methods needed
16899 (RootContext.MethodCount);
16901 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16902 numbers instead of StringBuilders.
16904 * support.cs (PtrHashtable): Add constructor with initial size;
16905 We can now reduce reallocations of the method table.
16907 2002-12-10 Ravi Pratap <ravi@ximian.com>
16909 * attribute.cs (ApplyAttributes): Keep track of the emitted
16910 attributes on a per-target basis. This fixes bug #35413.
16912 2002-12-10 Miguel de Icaza <miguel@ximian.com>
16914 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
16915 default to the Windows 1252 encoding.
16917 (UnixParseOption): Support version, thanks to Alp for the missing
16920 * AssemblyInfo.cs: Add nice assembly information.
16922 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
16925 * cs-parser.jay: Allow a trailing comma before the close bracked
16926 in the attribute_section production.
16928 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
16929 address of the instance was being taken, I will take this out,
16930 because we take the address of the object immediately here.
16932 2002-12-09 Ravi Pratap <ravi@ximian.com>
16934 * typemanager.cs (AreMultipleAllowed): Take care of the most
16935 obvious case where attribute type is not in the current assembly -
16938 2002-12-08 Miguel de Icaza <miguel@ximian.com>
16940 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
16941 definitions, instead of doing that afterwards.
16943 Also we use a nice little hack, depending on the constructor, we
16944 know if we are a "composed" name or a simple name. Hence, we
16945 avoid the IndexOf test, and we avoid
16947 * codegen.cs: Add code to assist in a bug reporter to track down
16948 the source of a compiler crash.
16950 2002-12-07 Ravi Pratap <ravi@ximian.com>
16952 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
16953 types have been emitted for a given element and flag an error
16954 if something which does not have AllowMultiple set is used more
16957 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
16958 attribute types and their corresponding AllowMultiple properties
16960 (AreMultipleAllowed): Check the property for a given type.
16962 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
16963 property in the case we have a TypeContainer.
16965 (Attributes.AddAttribute): Detect duplicates and just skip on
16966 adding them. This trivial fix catches a pretty gross error in our
16967 attribute emission - global attributes were being emitted twice!
16969 Bugzilla bug #33187 is now fixed.
16971 2002-12-06 Miguel de Icaza <miguel@ximian.com>
16973 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
16974 instead of pp_and).
16976 * expression.cs (Binary.ResolveOperator): I can only use the
16977 Concat (string, string, string) and Concat (string, string,
16978 string, string) if the child is actually a concatenation of
16981 2002-12-04 Miguel de Icaza <miguel@ximian.com>
16983 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
16984 context where we need a 2-character lookahead.
16986 * pending.cs (PendingImplementation): Rework so we can keep track
16987 of interface types all the time, and flag those which were
16988 implemented by parents as optional.
16990 2002-12-03 Miguel de Icaza <miguel@ximian.com>
16992 * expression.cs (Binary.ResolveOperator): Use
16993 String.Concat(string,string,string) or
16994 String.Concat(string,string,string,string) when possible.
16996 * typemanager: More helper methods.
16999 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
17001 * pending.cs: remove the bogus return from GetMissingInterfaces()
17002 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
17004 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17006 * namespace.cs: avoid duplicated 'using xxx' being added to
17007 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
17008 when we get more than one 'using' statement for the same namespace.
17009 Report a CS0105 warning for it.
17011 2002-11-30 Miguel de Icaza <miguel@ximian.com>
17013 * cs-tokenizer.cs (consume_identifier): use read directly, instead
17014 of calling getChar/putback, uses internal knowledge of it.
17016 (xtoken): Reorder tokenizer so most common patterns are checked
17017 first. This reduces the compilation time in another 5% (from 8.11s
17018 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
17020 The parsing time is 22% of the compilation in mcs, and from that
17021 64% is spent on the tokenization process.
17023 I tried using a binary search for keywords, but this is slower
17024 than the hashtable. Another option would be to do a couple of
17027 * Not use a StringBuilder, instead use an array of chars,
17028 with a set value. Notice that this way we could catch
17029 the 645 error without having to do it *afterwards*.
17031 * We could write a hand-parser to avoid the hashtable
17032 compares altogether.
17034 The identifier consumption process takes 37% of the tokenization
17035 time. Another 15% is spent on is_number. 56% of the time spent
17036 on is_number is spent on Int64.Parse:
17038 * We could probably choose based on the string length to
17039 use Int32.Parse or Int64.Parse and avoid all the 64-bit
17042 Another 3% is spend on wrapping `xtoken' in the `token' function.
17044 Handle 0xa0 as whitespace (#34752)
17046 2002-11-26 Miguel de Icaza <miguel@ximian.com>
17048 * typemanager.cs (IsCLRType): New routine to tell whether a type
17049 is one of the builtin types.
17051 Maybe it needs to use TypeCodes to be faster. Maybe we could use
17052 typecode in more places instead of doing pointer comparissions.
17053 We could leverage some knowledge about the way the typecodes are
17056 New code to cache namespaces in assemblies, it is currently not
17057 invoked, to be used soon.
17059 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
17061 * expression.cs (Binary.ResolveOperator): specially handle
17062 strings, and do not perform user-defined operator overloading for
17065 2002-11-24 Miguel de Icaza <miguel@ximian.com>
17067 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
17068 internalcall as it is a pretty simple operation; Avoid whenever
17069 possible to call Char.IsLetter.
17071 (consume_identifier): Cut by half the number of
17072 hashtable calls by merging the is_keyword and GetKeyword behavior.
17074 Do not short-circuit, because if we do, we
17075 report errors (ie, #if false && true would produce an invalid
17079 2002-11-24 Martin Baulig <martin@ximian.com>
17081 * expression.cs (Cast.TryReduce): If we're in checked syntax,
17082 check constant ranges and report a CS0221. Fixes #33186.
17084 2002-11-24 Martin Baulig <martin@ximian.com>
17086 * cs-parser.jay: Make this work for uninitialized variable
17087 declarations in the `for' initializer. Fixes #32416.
17089 2002-11-24 Martin Baulig <martin@ximian.com>
17091 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
17092 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
17094 2002-11-24 Martin Baulig <martin@ximian.com>
17096 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
17097 argument; if true, we also check for user-defined conversions.
17098 This is only needed if both arguments are of a user-defined type.
17099 Fixes #30443, added test-175.cs.
17100 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
17102 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
17104 2002-11-24 Martin Baulig <martin@ximian.com>
17106 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
17107 function to get the store opcode.
17108 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
17109 only emit the Ldelema if the store opcode is Stobj. You must run
17110 both test-34 and test-167 to test this. Fixes #34529.
17112 2002-11-23 Martin Baulig <martin@ximian.com>
17114 * ecore.cs (Expression.MemberLookup): Added additional
17115 `qualifier_type' argument which is used when we're being called
17116 from MemberAccess.DoResolve() and null if we're called from a
17118 (Expression.MemberLookupFailed): New method to report errors; this
17119 does the CS1540 check and reports the correct error message.
17121 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
17122 argument for the CS1540 check and redone the way how we're dealing
17123 with private members. See the comment in the source code for details.
17124 (FilterWithClosure): Reverted this back to revision 1.197; renamed
17125 `closure_start_type' to `closure_qualifier_type' and check whether
17126 it's not null. It was not this filter being broken, it was just
17127 being called with the wrong arguments.
17129 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
17130 and pass it the correct `qualifier_type'; this also does the error
17133 2002-11-22 Miguel de Icaza <miguel@ximian.com>
17135 * expression.cs (Invocation.EmitParams): If the we are dealing
17136 with a non-built-in value type, load its address as well.
17138 (ArrayCreation): Use a a pretty constant instead
17139 of the hardcoded value 2. Use 6 instead of 2 for the number of
17140 static initializers.
17142 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
17143 because they are not really value types, just glorified integers.
17145 * driver.cs: Do not append .exe, the CSC compiler does not do it.
17147 * ecore.cs: Remove redundant code for enumerations, make them use
17148 the same code path as everything else, fixes the casting issue
17149 with enumerations in Windows.Forms.
17151 * attribute.cs: Do only cast to string if it is a string, the
17152 validation happens later.
17154 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
17155 people upgrade their corlibs.
17157 * ecore.cs: Oops, enumerations were not following the entire code path
17159 2002-11-21 Miguel de Icaza <miguel@ximian.com>
17161 * typemanager.cs (FilterWithClosure): Commented out the test for
17162 1540 in typemanager.cs, as it has problems when accessing
17163 protected methods from a parent class (see test-174.cs).
17165 * attribute.cs (Attribute.ValidateGuid): new method.
17166 (Attribute.Resolve): Use above.
17168 2002-11-19 Miguel de Icaza <miguel@ximian.com>
17170 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
17172 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
17173 handling for enumerations, as we only needed the TypeContainer
17174 functionality to begin with (this is required for the fix below to
17175 work for enums that reference constants in a container class for
17178 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
17180 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
17181 a valid TypeBuilder to perform lookups on.o
17183 * class.cs (InheritableMemberSignatureCompare): Use true in the
17184 call to GetGetMethod and GetSetMethod, because we are comparing
17185 the signature, and we need to get the methods *even* if they are
17188 (PropertyBase.CheckBase): ditto.
17190 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
17191 GotoCase.Resolve): Use Peel on EmpytCasts.
17193 * ecore.cs (EmptyCast): drop child, add Peel method.
17195 2002-11-17 Martin Baulig <martin@ximian.com>
17197 * ecore.cs (EmptyCast.Child): New public property.
17199 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
17200 label resolved to an EmptyCast. Fixes #34162.
17201 (GotoCase.Resolve): Likewise.
17202 (Block.EmitMeta): Likewise.
17204 2002-11-17 Martin Baulig <martin@ximian.com>
17206 * expression.cs (Invocation.BetterConversion): Prefer int over
17207 uint; short over ushort; long over ulong for integer literals.
17208 Use ImplicitConversionExists instead of StandardConversionExists
17209 since we also need to check for user-defined implicit conversions.
17210 Fixes #34165. Added test-173.cs.
17212 2002-11-16 Martin Baulig <martin@ximian.com>
17214 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
17215 with the `true' and `false' literals. Fixes #33151.
17217 2002-11-16 Martin Baulig <martin@ximian.com>
17219 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
17220 October 22nd; don't do the cs1540 check for static members.
17222 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
17223 now using our own filter here and doing the cs1540 check again.
17225 2002-11-16 Martin Baulig <martin@ximian.com>
17227 * support.cs (InternalParameters): Don't crash if we don't have
17228 any fixed parameters. Fixes #33532.
17230 2002-11-16 Martin Baulig <martin@ximian.com>
17232 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
17233 when looking up static methods to make this work on Windows.
17236 2002-11-16 Martin Baulig <martin@ximian.com>
17238 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
17239 a setter rather than using PropertyInfo.CanWrite.
17241 2002-11-15 Nick Drochak <ndrochak@gol.com>
17243 * class.cs: Allow acces to block member by subclasses. Fixes build
17246 2002-11-14 Martin Baulig <martin@ximian.com>
17248 * class.cs (Constructor.Emit): Added the extern/block check.
17251 2002-11-14 Martin Baulig <martin@ximian.com>
17253 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
17254 iteration while looking for indexers, this is needed because the
17255 indexer may have a different name in our base classes. Fixed the
17256 error reporting (no indexers at all, not get accessor, no
17257 overloaded match). Fixes bug #33089.
17258 (IndexerAccess.DoResolveLValue): Likewise.
17260 2002-11-14 Martin Baulig <martin@ximian.com>
17262 * class.cs (PropertyBase.CheckBase): Make this work for multiple
17263 indexers. Fixes the first part of bug #33089.
17264 (MethodSignature.InheritableMemberSignatureCompare): Added support
17267 2002-11-13 Ravi Pratap <ravi@ximian.com>
17269 * attribute.cs (Attribute.Resolve): Catch the
17270 NullReferenceException and report it since it isn't supposed to
17273 2002-11-12 Miguel de Icaza <miguel@ximian.com>
17275 * expression.cs (Binary.EmitBranchable): Also handle the cases for
17276 LogicalOr and LogicalAnd that can benefit from recursively
17277 handling EmitBranchable. The code now should be nice for Paolo.
17279 2002-11-08 Miguel de Icaza <miguel@ximian.com>
17281 * typemanager.cs (LookupType): Added a negative-hit hashtable for
17282 the Type lookups, as we perform quite a number of lookups on
17283 non-Types. This can be removed once we can deterministically tell
17284 whether we have a type or a namespace in advance.
17286 But this might require special hacks from our corlib.
17290 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
17291 and double which avoids a conversion from an integer to a double.
17293 * expression.cs: tiny optimization, avoid calling IsConstant,
17294 because it effectively performs the lookup twice.
17296 2002-11-06 Miguel de Icaza <miguel@ximian.com>
17298 But a bogus return here to keep the semantics of the old code
17299 until the Mono runtime is fixed.
17301 * pending.cs (GetMissingInterfaces): New method used to remove all
17302 the interfaces that are already implemented by our parent
17303 classes from the list of pending methods.
17305 * interface.cs: Add checks for calls after ResolveTypeExpr.
17307 2002-11-05 Miguel de Icaza <miguel@ximian.com>
17309 * class.cs (Class.Emit): Report warning 67: event not used if the
17310 warning level is beyond 3.
17312 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
17313 being a NullLiteral.
17315 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
17318 * class.cs (TypeContainer.GetClassBases): Cover a missing code
17319 path that might fail if a type can not be resolved.
17321 * expression.cs (Binary.Emit): Emit unsigned versions of the
17324 * driver.cs: use error 5.
17326 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
17328 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
17330 2002-11-01 Miguel de Icaza <miguel@ximian.com>
17332 * cs-parser.jay (switch_section): A beautiful patch from Martin
17333 Baulig that fixed 33094.
17335 2002-10-31 Miguel de Icaza <miguel@ximian.com>
17337 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
17338 Check whether the base is abstract and report an error if so.
17340 * expression.cs (IndexerAccess.DoResolveLValue,
17341 IndexerAccess.DoResolve): ditto.
17343 (Invocation.DoResolve): ditto.
17345 (Invocation.FullMethodDesc): Improve the report string.
17347 * statement.cs (Block): Eliminate IsVariableDefined as it is
17348 basically just a wrapper for GetVariableInfo.
17350 * ecore.cs (SimpleName): Use new
17352 * support.cs (ReflectionParamter.ParameterType): We unwrap the
17353 type, as we return the actual parameter ref/unref state on a
17356 2002-10-30 Miguel de Icaza <miguel@ximian.com>
17358 * support.cs: Return proper flags REF/OUT fixing the previous
17361 * expression.cs: Reverted last patch, that was wrong. Is_ref is
17362 not used to mean `ref' but `ref or out' in ParameterReference
17364 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
17365 full type signature instead of calling TypeManger.CSharpName
17368 * support.cs (InternalParameters.ParameterDesc): Do not compare
17369 directly to the modflags, because REF/OUT will actually be bitsets
17372 * delegate.cs (VerifyMethod): Check also the modifiers.
17374 * cs-tokenizer.cs: Fix bug where floating point values with an
17375 exponent where a sign was missing was ignored.
17377 * driver.cs: Allow multiple assemblies to be specified in a single
17380 2002-10-28 Miguel de Icaza <miguel@ximian.com>
17382 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
17383 because identifiers after a parenthesis would end up in this kind
17384 of production, and we needed to desamiguate it for having casts
17387 (UserDefinedType *) xxx
17389 2002-10-24 Miguel de Icaza <miguel@ximian.com>
17391 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
17392 we should set on the Bindingflags.NonPublic, but not turn on
17393 private_ok. private_ok controls whether a Private member is
17394 returned (this is chekced on the filter routine), while the
17395 BindingFlags.NonPublic just controls whether private/protected
17396 will be allowed. This fixes the problem part of the problem of
17397 private properties being allowed to be used in derived classes.
17399 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
17400 so we can call the children DoResolveLValue method (this will
17401 properly signal errors on lvalue assignments to base properties)
17403 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
17404 getter are null, and we have a property info, we know that this
17405 happened because the lookup failed, so we report an error 122 for
17406 protection level violation.
17408 We also silently return if setter and getter are null in the
17409 resolve functions, this condition only happens if we have flagged
17410 the error before. This is the other half of the problem.
17412 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
17413 not have accessibility information, that is why we were returning
17414 true in the filter function in typemanager.cs.
17416 To properly report 122 (property is inaccessible because of its
17417 protection level) correctly, we report this error in ResolveAccess
17418 by failing if both the setter and the getter are lacking (ie, the
17421 DoResolve and DoLResolve have been modified to check for both
17422 setter/getter being null and returning silently, the reason being
17423 that I did not want to put the knowledge about this error in upper
17426 int old = Report.Errors;
17427 x = new PropertyExpr (...);
17428 if (old != Report.Errors)
17433 So the property expr is returned, but it is invalid, so the error
17434 will be flagged during the resolve process.
17436 * class.cs: Remove InheritablePropertySignatureCompare from the
17437 class, as we no longer depend on the property signature to compute
17438 whether it is possible to implement a method or not.
17440 The reason is that calling PropertyInfo.GetGetMethod will return
17441 null (in .NET, in Mono it works, and we should change this), in
17442 cases where the Get Method does not exist in that particular
17447 class X { public virtual int A { get { return 1; } } }
17449 class Z : Y { public override int A { get { return 2; } } }
17451 Would fail in Z because the parent (Y) would not have the property
17452 defined. So we avoid this completely now (because the alternative
17453 fix was ugly and slow), and we now depend exclusively on the
17456 (PropertyBase.CheckBase): Use a method-base mechanism to find our
17457 reference method, instead of using the property.
17459 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
17460 routines are gone now.
17462 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
17463 names, they were incorrectly named.
17465 * cs-tokenizer.cs: Return are more gentle token on failure.
17467 * pending.cs (PendingImplementation.InterfaceMethod): This routine
17468 had an out-of-sync index variable, which caused it to remove from
17469 the list of pending methods the wrong method sometimes.
17471 2002-10-22 Miguel de Icaza <miguel@ximian.com>
17473 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
17474 CanWrite, because those refer to this particular instance of the
17475 property, and do not take into account the fact that we can
17476 override single members of a property.
17478 Constructor requires an EmitContext. The resolution process does
17479 not happen here, but we need to compute the accessors before,
17480 because the resolution does not always happen for properties.
17482 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
17483 subclass, before we did not update this flag, but we did update
17486 (GetAccessors): Drop this routine, as it did not work in the
17487 presence of partially overwritten set/get methods.
17489 Notice that this broke the cs1540 detection, but that will require
17492 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17496 * driver.cs: issue a warning instead of an error if we don't support
17497 debugging for the platform. Also ignore a couple of errors that may
17498 arise when trying to write the symbols. Undo my previous patch.
17500 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17502 * driver.cs: ignore /debug switch except for Unix platforms.
17504 2002-10-23 Nick Drochak <ndrochak@gol.com>
17506 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
17508 2002-10-21 Miguel de Icaza <miguel@ximian.com>
17510 * driver.cs: Do not make mcs-debug conditional, so we do not break
17511 builds that use it.
17513 * statement.cs (UsageVector.MergeChildren): I would like Martin to
17514 review this patch. But basically after all the children variables
17515 have been merged, the value of "Breaks" was not being set to
17516 new_breaks for Switch blocks. I think that it should be set after
17517 it has executed. Currently I set this to the value of new_breaks,
17518 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
17519 conservative, but I do not understand this code very well.
17521 I did not break anything in the build, so that is good ;-)
17523 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
17525 2002-10-20 Mark Crichton <crichton@gimp.org>
17527 * cfold.cs: Fixed compile blocker. Really fixed it this time.
17529 2002-10-20 Nick Drochak <ndrochak@gol.com>
17531 * cfold.cs: Fixed compile blocker.
17533 2002-10-20 Miguel de Icaza <miguel@ximian.com>
17535 * driver.cs: I was chekcing the key, not the file.
17537 2002-10-19 Ravi Pratap <ravi@ximian.com>
17539 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
17540 message that we were generating - we just need to silently return
17543 2002-10-19 Miguel de Icaza <miguel@ximian.com>
17545 * class.cs (Event.Define): Change my previous commit, as this
17546 breaks the debugger. This is a temporary hack, as it seems like
17547 the compiler is generating events incorrectly to begin with.
17549 * expression.cs (Binary.ResolveOperator): Added support for
17550 "U operator - (E x, E y)"
17552 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17555 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17556 init-only variables, but this path did not take into account that
17557 there might be also instance readonly variables. Correct this
17560 This fixes bug 32253
17562 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17565 * driver.cs: Change the extension for modules to `netmodule'
17567 * cs-parser.jay: Improved slightly the location tracking for
17568 the debugger symbols.
17570 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17571 modifiers that were specified instead of the hardcoded value
17572 (FamAndAssem). This was basically ignoring the static modifier,
17573 and others. Fixes 32429.
17575 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17576 fixed a bug in the process (32476)
17578 * expression.cs (ArrayAccess.EmitAssign): Patch from
17579 hwang_rob@yahoo.ca that fixes bug 31834.3
17581 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17583 * driver.cs: Make the module extension .netmodule.
17585 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17587 * driver.cs: Report an error if the resource file is not found
17588 instead of crashing.
17590 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17591 false, like Emit does.
17593 2002-10-16 Nick Drochak <ndrochak@gol.com>
17595 * typemanager.cs: Remove unused private member. Also reported mcs
17596 bug to report this as a warning like csc.
17598 2002-10-15 Martin Baulig <martin@gnome.org>
17600 * statement.cs (Statement.Emit): Made this a virtual method; emits
17601 the line number info and calls DoEmit().
17602 (Statement.DoEmit): New protected abstract method, formerly knows
17603 as Statement.Emit().
17605 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17607 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17609 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17610 have fixed a remaining problem: not every AddXXXX was adding a
17611 fully qualified name.
17613 Now everyone registers a fully qualified name in the DeclSpace as
17614 being defined instead of the partial name.
17616 Downsides: we are slower than we need to be due to the excess
17617 copies and the names being registered this way.
17619 The reason for this is that we currently depend (on the corlib
17620 bootstrap for instance) that types are fully qualified, because
17621 we dump all the types in the namespace, and we should really have
17622 types inserted into the proper namespace, so we can only store the
17623 basenames in the defined_names array.
17625 2002-10-10 Martin Baulig <martin@gnome.org>
17627 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17628 from bug #31834, see the bug report for a testcase which is
17631 2002-10-10 Martin Baulig <martin@gnome.org>
17633 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17634 flow analysis code for this.
17636 * statement.cs (Do, While, For): Tell the flow analysis code about
17638 (FlowBranching.UsageVector): Added support for infinite loops.
17639 (Block.Resolve): Moved the dead code elimination here and use flow
17642 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17644 * class.cs (Field.Define): Catch cycles on struct type
17647 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17648 fields if the fields are static. We only need to check instance
17651 * expression.cs (As.DoResolve): Test for reference type.
17653 * statement.cs (Using.ResolveExpression): Use
17654 ConvertImplicitRequired, not ConvertImplicit which reports an
17656 (Using.ResolveLocalVariableDecls): ditto.
17658 * expression.cs (Binary.ResolveOperator): Report errors in a few
17659 places where we had to.
17661 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17663 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17665 * expression.cs: Use StoreFromPtr instead of extracting the type
17666 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17668 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17669 an enumeration value to a System.Enum, but System.Enum is not a
17670 value type, but an class type, so we need to box.
17672 (Expression.ConvertExplicit): One codepath could return
17673 errors but not flag them. Fix this. Fixes #31853
17675 * parameter.cs (Resolve): Do not allow void as a parameter type.
17677 2002-10-06 Martin Baulig <martin@gnome.org>
17679 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17680 if it's a class type and not a struct. Fixes #31815.
17682 2002-10-06 Martin Baulig <martin@gnome.org>
17684 * statement.cs: Reworked the flow analysis code a bit to make it
17685 usable for dead code elimination.
17687 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17689 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17691 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17693 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17694 to fix the test 165, will investigate deeper.
17696 2002-10-04 Martin Baulig <martin@gnome.org>
17698 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17699 finally blocks actually work.
17700 (Try.Resolve): We don't need to create a sibling for `finally' if
17701 there is no finally block.
17703 2002-10-04 Martin Baulig <martin@gnome.org>
17705 * class.cs (Constructor.Define): The default accessibility for a
17706 non-default constructor is private, not public.
17708 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17710 * class.cs (Constructor): Make AllowedModifiers public, add
17713 * cs-parser.jay: Perform the modifiers test here, as the
17714 constructor for the Constructor class usually receives a zero
17715 because of the way we create it (first we create, later we
17716 customize, and we were never checking the modifiers).
17718 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17719 is a version of LookupTypeReflection that includes the type-name
17720 cache. This can be used as a fast path for functions that know
17721 the fully qualified name and are only calling into *.GetType() to
17722 obtain a composed type.
17724 This is also used by TypeManager.LookupType during its type
17727 (LookupType): We now also track the real type name, as sometimes
17728 we can get a quey for the real type name from things like
17729 ComposedCast. This fixes bug 31422.
17731 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17732 complete type fullname, it does not have to go through the type
17733 resolution system to obtain the composed version of the type (for
17734 obtaining arrays or pointers).
17736 (Conditional.Emit): Use the EmitBoolExpression to
17737 generate nicer code, as requested by Paolo.
17739 (ArrayCreation.CheckIndices): Use the patch from
17740 hwang_rob@yahoo.ca to validate the array initializers.
17742 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17744 * class.cs (ConstructorInitializer.Emit): simplify code by using
17745 Invocation.EmitCall, and at the same time, fix the bugs in calling
17746 parent constructors that took variable arguments.
17748 * ecore.cs (Expression.ConvertNumericExplicit,
17749 Expression.ImplicitNumericConversion): Remove the code that
17750 manually wrapped decimal (InternalTypeConstructor call is now gone
17753 * expression.cs (Cast.TryReduce): Also handle decimal types when
17754 trying to perform a constant fold on the type.
17756 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17758 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17759 that only turned off an error report, and did nothing else.
17761 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17763 * driver.cs: Handle and ignore /fullpaths
17765 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17767 * expression.cs (Binary.ResolveOperator): Catch the case where
17768 DoNumericPromotions returns true,
17770 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17772 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17774 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17777 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17779 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17780 conversion exists, but it is also required that the conversion be
17781 performed. This manifested in "(Type64Enum) 2".
17783 * class.cs (TypeManager.AddMethod): The fix is not to change
17784 AddEnum, because that one was using a fully qualified name (every
17785 DeclSpace derivative does), but to change the AddMethod routine
17786 that was using an un-namespaced name. This now correctly reports
17787 the duplicated name.
17789 Revert patch until I can properly fix it. The issue
17790 is that we have a shared Type space across all namespaces
17791 currently, which is wrong.
17793 Options include making the Namespace a DeclSpace, and merge
17794 current_namespace/current_container in the parser.
17796 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17798 * cs-parser.jay: Improve error reporting when we get a different
17799 kind of expression in local_variable_type and
17800 local_variable_pointer_type.
17802 Propagate this to avoid missleading errors being reported.
17804 * ecore.cs (ImplicitReferenceConversion): treat
17805 TypeManager.value_type as a target just like object_type. As
17810 Is valid, and needs to result in the int 1 being boxed before it
17811 is assigned to the value type v.
17813 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17814 to validate the enumeration name.
17816 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17817 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17818 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17820 * ecore.cs (TryImplicitIntConversion): When doing an
17821 implicit-enumeration-conversion, check if the type is 64-bits and
17822 perform a conversion before passing to EnumConstant.
17824 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17826 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17827 report ambiguous type references. Unlike the MS version, we
17828 report what the ambiguity is. Innovation at work ;-)
17830 (DeclSpace.FindType): Require a location argument to
17831 display when we display an ambiguous error.
17833 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17835 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17837 * expression.cs (EmitDynamicInitializers): Apply patch from
17838 hwang_rob@yahoo.ca that fixes the order in which we emit our
17841 2002-09-21 Martin Baulig <martin@gnome.org>
17843 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17844 delegate takes no arguments.
17846 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17848 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17851 * expression.cs: Extract the underlying type.
17853 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17855 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17857 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17859 * class.cs (TypeContainer.DefineType): We can not use the nice
17860 PackingSize with the size set to 1 DefineType method, because it
17861 will not allow us to define the interfaces that the struct
17864 This completes the fixing of bug 27287
17866 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17867 means also structs. This fixes part of the problem.
17868 (Expresion.ImplicitReferenceConversionExists): ditto.
17870 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17871 error if there were no errors reported during the type lookup
17872 process, to avoid duplicates or redundant errors. Without this
17873 you would get an ambiguous errors plus a type not found. We have
17874 beaten the user enough with the first error.
17876 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17879 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17880 during the resolution process, stop the lookup, this avoids
17881 repeated error reports (same error twice).
17883 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17885 * typemanager.cs (LookupType): Redo the type lookup code to match
17886 the needs of System.Reflection.
17888 The issue is that System.Reflection requires references to nested
17889 types to begin with a "+" sign instead of a dot. So toplevel
17890 types look like: "NameSpace.TopLevelClass", and nested ones look
17891 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17894 2002-09-19 Martin Baulig <martin@gnome.org>
17896 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17897 says that a method always returns or always throws an exception,
17898 don't report the CS0161.
17900 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17901 set `Returns = new_returns'.
17903 2002-09-19 Martin Baulig <martin@gnome.org>
17905 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
17906 to an enum constant, check for a CS0176.
17908 2002-09-18 Miguel de Icaza <miguel@ximian.com>
17910 * class.cs (TypeContainer.CheckPairedOperators): Now we check
17911 for operators that must be in pairs and report errors.
17913 * ecore.cs (SimpleName.DoResolveType): During the initial type
17914 resolution process, when we define types recursively, we must
17915 check first for types in our current scope before we perform
17916 lookups in the enclosing scopes.
17918 * expression.cs (MakeByteBlob): Handle Decimal blobs.
17920 (Invocation.VerifyArgumentsCompat): Call
17921 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
17922 I thought we were supposed to always call this, but there are a
17923 few places in the code where we dont do it.
17925 2002-09-17 Miguel de Icaza <miguel@ximian.com>
17927 * driver.cs: Add support in -linkres and -resource to specify the
17928 name of the identifier.
17930 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17932 * ecore.cs (StandardConversionExists): Sync with the conversion
17933 code: allow anything-* to void* conversions.
17935 (FindMostSpecificSource): Use an Expression argument
17936 instead of a Type, because we might be handed over a Literal which
17937 gets a few more implicit conversions that plain types do not. So
17938 this information was being lost.
17940 Also, we drop the temporary type-holder expression when not
17943 2002-09-17 Martin Baulig <martin@gnome.org>
17945 * class.cs (PropertyBase.CheckBase): Don't check the base class if
17946 this is an explicit interface implementation.
17948 2002-09-17 Martin Baulig <martin@gnome.org>
17950 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
17951 different `IndexerName' attributes.
17953 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
17954 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
17955 virtual CommonResolve().
17957 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17959 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
17960 and convert that to the UnderlyingType.
17962 * statement.cs (Foreach.Resolve): Indexers are just like variables
17963 or PropertyAccesses.
17965 * cs-tokenizer.cs (consume_string): Track line numbers and columns
17966 inside quoted strings, we were not doing this before.
17968 2002-09-16 Martin Baulig <martin@gnome.org>
17970 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
17971 resolve it. This is needed for the definite assignment check of the
17972 instance expression, fixes bug #29846.
17973 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
17975 2002-09-16 Nick Drochak <ndrochak@gol.com>
17977 * parameter.cs: Fix compile error. Cannot reference static member
17978 from an instance object. Is this an mcs bug?
17980 2002-09-14 Martin Baulig <martin@gnome.org>
17982 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
17983 multiple times. Fixes bug #30295, added test-166.cs.
17985 2002-09-14 Martin Baulig <martin@gnome.org>
17987 * statement.cs (Block.Emit): Don't emit unreachable code.
17988 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
17989 `break' statements.
17990 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
17992 2002-09-14 Martin Baulig <martin@gnome.org>
17994 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
17997 2002-09-14 Martin Baulig <martin@gnome.org>
17999 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
18000 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
18001 be false on the ms runtime.
18003 2002-09-13 Martin Baulig <martin@gnome.org>
18005 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
18006 the CS0038 error message.
18008 2002-09-12 Miguel de Icaza <miguel@ximian.com>
18010 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
18011 constant inside, return it.
18013 2002-09-12 Martin Baulig <martin@gnome.org>
18015 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
18016 implicit conversion can be done between enum types.
18018 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
18019 check whether an implicit conversion to the current enum's UnderlyingType
18020 exists and report an error if not.
18022 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
18023 without debugging support.
18025 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
18026 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
18028 2002-09-12 Martin Baulig <martin@gnome.org>
18030 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
18032 * ecore.cs (IMemberExpr.DeclaringType): New property.
18033 (SimpleName.SimpleNameResolve): Check whether we're accessing a
18034 nonstatic member of an outer type (CS0038).
18036 2002-09-11 Miguel de Icaza <miguel@ximian.com>
18038 * driver.cs: Activate the using-error detector at warning level
18039 4 (at least for MS-compatible APIs).
18041 * namespace.cs (VerifyUsing): Small buglett fix.
18043 * pending.cs (PendingImplementation): pass the container pointer.
18045 * interface.cs (GetMethods): Allow for recursive definition. Long
18046 term, I would like to move every type to support recursive
18047 definitions, not the current ordering mechanism that we have right
18050 The situation is this: Attributes are handled before interfaces,
18051 so we can apply attributes to interfaces. But some attributes
18052 implement interfaces, we will now handle the simple cases
18053 (recursive definitions will just get an error).
18055 * parameter.cs: Only invalidate types at the end if we fail to
18058 2002-09-09 Martin Baulig <martin@gnome.org>
18060 * ecore.cs (PropertyExpr.Emit): Also check for
18061 TypeManager.system_int_array_get_length so this'll also work when
18062 compiling corlib. Fixes #30003.
18064 2002-09-09 Martin Baulig <martin@gnome.org>
18066 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
18067 and throw an exception if we can't get the type's size. Fixed #30040,
18070 2002-09-09 Martin Baulig <martin@gnome.org>
18072 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
18074 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
18075 context. Fixes bug #30027.
18077 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
18078 virtual functions. Fixes bug #30043, added test-164.cs.
18080 2002-09-08 Ravi Pratap <ravi@ximian.com>
18082 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
18084 2002-09-08 Nick Drochak <ndrochak@gol.com>
18086 * driver.cs: Use an object to get the windows codepage since it's not a
18089 2002-09-08 Miguel de Icaza <miguel@ximian.com>
18091 * statement.cs (For.Emit): for infinite loops (test == null)
18092 return whether there is a break inside, not always "true".
18094 * namespace.cs (UsingEntry): New struct to hold the name of the
18095 using definition, the location where it is defined, and whether it
18096 has been used in a successful type lookup.
18098 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
18103 2002-09-06 Ravi Pratap <ravi@ximian.com>
18105 * attribute.cs : Fix incorrect code which relied on catching
18106 a NullReferenceException to detect a null being passed in
18107 where an object was expected.
18109 2002-09-06 Miguel de Icaza <miguel@ximian.com>
18111 * statement.cs (Try): flag the catch variable as assigned
18113 * expression.cs (Cast): Simplified by using ResolveType instead of
18114 manually resolving.
18116 * statement.cs (Catch): Fix bug by using ResolveType.
18118 2002-09-06 Ravi Pratap <ravi@ximian.com>
18120 * expression.cs (BetterConversion): Special case for when we have
18121 a NullLiteral as the argument and we have to choose between string
18122 and object types - we choose string the way csc does.
18124 * attribute.cs (Attribute.Resolve): Catch the
18125 NullReferenceException and report error #182 since the Mono
18126 runtime no more has the bug and having this exception raised means
18127 we tried to select a constructor which takes an object and is
18130 2002-09-05 Ravi Pratap <ravi@ximian.com>
18132 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
18133 message (1502, 1503) when we can't locate a method after overload
18134 resolution. This is much more informative and closes the bug
18137 * interface.cs (PopulateMethod): Return if there are no argument
18138 types. Fixes a NullReferenceException bug.
18140 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
18141 expressions too. Previously we were checking only in one place for
18142 positional arguments leaving out named arguments.
18144 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
18145 type to the enum type is not allowed. Remove code corresponding to
18148 (ConvertNumericExplicit): Allow explicit conversions from
18149 the underlying type to enum type. This precisely follows the spec
18150 and closes a bug filed by Gonzalo.
18152 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18155 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
18157 2002-09-03 Miguel de Icaza <miguel@ximian.com>
18159 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
18160 it was important that we stored the right value after the
18161 reduction in `converted'.
18163 2002-09-04 Martin Baulig <martin@gnome.org>
18165 * location.cs (Location.SymbolDocument): Use full pathnames for the
18168 2002-08-30 Miguel de Icaza <miguel@ximian.com>
18170 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
18171 of the expression resolve mechanism, because that will catch the
18172 SimpleName error failures.
18174 (Conditional): If we can not resolve the
18175 expression, return, do not crash.
18177 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18180 (location): display token name instead of its number.
18182 2002-08-28 Martin Baulig <martin@gnome.org>
18184 * expression.cs (Binary.ResolveOperator): Don't silently return
18185 but return an error if an operator cannot be applied between two
18188 2002-08-28 Martin Baulig <martin@gnome.org>
18190 * class.cs (Constructor.Define): Set the permission attributes
18191 correctly instead of making all constructors public.
18193 2002-08-28 Martin Baulig <martin@gnome.org>
18195 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
18196 for private members before reporting a CS0103; if we find anything,
18199 2002-08-28 Martin Baulig <martin@gnome.org>
18201 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
18202 to check whether `closure_start_type == closure_invocation_type',
18203 we also need to check whether `m.DeclaringType == closure_invocation_type'
18204 before bypassing the permission checks. We might be accessing
18205 protected/private members from the base class.
18206 (TypeManager.RealMemberLookup): Only set private_ok if private
18207 members were requested via BindingFlags.NonPublic.
18209 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
18211 * expression.cs (MemberAccess.ResolveMemberAccess): Set
18212 MethodGroupExpr.IsExplicitImpl if appropriate.
18213 (Invocation.DoResolve): Don't report the CS0120 for explicit
18214 interface implementations.
18216 2002-08-27 Martin Baulig <martin@gnome.org>
18218 * expression.cs (Invocation.DoResolve): If this is a static
18219 method and we don't have an InstanceExpression, we must report
18222 2002-08-25 Martin Baulig <martin@gnome.org>
18224 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
18225 `==' between a valuetype and an object.
18227 2002-08-25 Miguel de Icaza <miguel@ximian.com>
18229 * ecore.cs (TypeExpr): Provide a ToString method.
18231 2002-08-24 Martin Baulig <martin@gnome.org>
18233 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
18234 now called proggie.dbg and it's a binary file.
18236 2002-08-23 Martin Baulig <martin@gnome.org>
18238 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
18240 2002-08-23 Martin Baulig <martin@gnome.org>
18242 * struct.cs (MyStructInfo.ctor): Make this work with empty
18243 structs; it's not allowed to use foreach() on null.
18245 2002-08-23 Martin Baulig <martin@gnome.org>
18247 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
18248 writer the full pathname of the generated assembly.
18250 2002-08-23 Martin Baulig <martin@gnome.org>
18252 * statements.cs (FlowBranching.UsageVector.MergeChildren):
18253 A `finally' block never returns or breaks; improved handling of
18256 2002-08-23 Martin Baulig <martin@gnome.org>
18258 * statement.cs (Throw.Resolve): Allow `throw null'.
18260 2002-08-23 Martin Baulig <martin@gnome.org>
18262 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
18263 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
18264 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
18265 MemberLookup would return a wrong event if this is an explicit
18266 interface implementation and the class has an event with the same
18269 2002-08-23 Martin Baulig <martin@gnome.org>
18271 * statement.cs (Block.AddChildVariableNames): New public method.
18272 (Block.AddChildVariableName): Likewise.
18273 (Block.IsVariableNameUsedInChildBlock): Likewise.
18274 (Block.AddVariable): Check whether a variable name has already
18275 been used in a child block.
18277 * cs-parser.jay (declare_local_variables): Mark all variable names
18278 from the current block as being used in a child block in the
18281 2002-08-23 Martin Baulig <martin@gnome.org>
18283 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
18284 find the symbol writer.
18286 * driver.cs: csc also allows the arguments to /define being
18287 separated by commas, not only by semicolons.
18289 2002-08-23 Martin Baulig <martin@gnome.org>
18291 * interface.cs (Interface.GetMembers): Added static check for events.
18293 2002-08-15 Martin Baulig <martin@gnome.org>
18295 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
18296 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
18298 * ecore.cs (Expression.MemberLookup): Added documentation and explained
18299 why the MethodData.EmitDestructor() change was necessary.
18301 2002-08-20 Martin Baulig <martin@gnome.org>
18303 * class.cs (TypeContainer.FindMembers): Added static check for events.
18305 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
18307 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
18308 use Type.GetEvents(), not Type.FindMembers().
18310 2002-08-20 Martin Baulig <martin@gnome.org>
18312 * decl.cs (MemberCache): Added a special method cache which will
18313 be used for method-only searched. This ensures that a method
18314 search will return a MethodInfo with the correct ReflectedType for
18317 2002-08-20 Martin Baulig <martin@gnome.org>
18319 * decl.cs (DeclSpace.FindMembers): Made this public.
18321 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18323 * delegate.cs: fixed build on windows.
18324 [FIXME: Filed as bug #29150: MCS must report these errors.]
18326 2002-08-19 Ravi Pratap <ravi@ximian.com>
18328 * ecore.cs (StandardConversionExists): Return a false
18329 if we are trying to convert the void type to anything else
18330 since that is not allowed.
18332 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
18333 we flag error 70 in the event an event is trying to be accessed
18334 directly from outside the declaring type.
18336 2002-08-20 Martin Baulig <martin@gnome.org>
18338 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
18339 MemberCache from typemanager.cs to decl.cs.
18341 2002-08-19 Martin Baulig <martin@gnome.org>
18343 * class.cs (TypeContainer): Implement IMemberContainer.
18344 (TypeContainer.DefineMembers): Create the MemberCache.
18345 (TypeContainer.FindMembers): Do better BindingFlags checking; only
18346 return public members if BindingFlags.Public was given, check
18347 whether members are static.
18349 2002-08-16 Martin Baulig <martin@gnome.org>
18351 * decl.cs (DeclSpace.Define): Splitted this in Define and
18352 DefineMembers. DefineMembers is called first and initializes the
18355 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
18356 DefineMembers() on all our DeclSpaces.
18358 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
18359 but call DefineMembers() on all nested interfaces. We call their
18360 Define() in our new Define() function.
18362 * interface.cs (Interface): Implement IMemberContainer.
18363 (Interface.Define): Moved all code except the attribute stuf to
18365 (Interface.DefineMembers): Initialize the member cache.
18367 * typemanager.cs (IMemberFinder): Removed this interface, we don't
18368 need this anymore since we can use MemberCache.FindMembers directly.
18370 2002-08-19 Martin Baulig <martin@gnome.org>
18372 * typemanager.cs (MemberCache): When creating the cache for an
18373 interface type, add all inherited members.
18374 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
18375 to `out bool used_cache' and documented it.
18376 (TypeManager.MemberLookup): If we already used the cache in the first
18377 iteration, we don't need to do the interfaces check.
18379 2002-08-19 Martin Baulig <martin@gnome.org>
18381 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
18382 here from IMemberFinder and don't implement this interface anymore.
18383 (DeclSpace.MemberCache): Moved here from IMemberFinder.
18385 * typemanager.cs (IMemberFinder): This interface is now only used by
18386 classes which actually support the member cache.
18387 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
18388 since we only put DeclSpaces into this Hashtable.
18389 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
18390 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
18392 2002-08-16 Martin Baulig <martin@gnome.org>
18394 * typemanager.cs (ICachingMemberFinder): Removed.
18395 (IMemberFinder.MemberCache): New property.
18396 (TypeManager.FindMembers): Merged this with RealFindMembers().
18397 This function will never be called from TypeManager.MemberLookup()
18398 so we can't use the cache here, just the IMemberFinder.
18399 (TypeManager.MemberLookup_FindMembers): Check whether the
18400 IMemberFinder has a MemberCache and call the cache's FindMembers
18402 (MemberCache): Rewrote larger parts of this yet another time and
18403 cleaned it up a bit.
18405 2002-08-15 Miguel de Icaza <miguel@ximian.com>
18407 * driver.cs (LoadArgs): Support quoting.
18409 (Usage): Show the CSC-like command line arguments.
18411 Improved a few error messages.
18413 2002-08-15 Martin Baulig <martin@gnome.org>
18415 * typemanager.cs (IMemberContainer.Type): New property.
18416 (IMemberContainer.IsInterface): New property.
18418 The following changes are conditional to BROKEN_RUNTIME, which is
18419 defined at the top of the file.
18421 * typemanager.cs (MemberCache.MemberCache): Don't add the base
18422 class'es members, but add all members from TypeHandle.ObjectType
18423 if we're an interface.
18424 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
18425 is the current type.
18426 (MemberCache.CacheEntry.Container): Removed this field.
18427 (TypeHandle.GetMembers): Include inherited members.
18429 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18431 * typemanager.cs: fixed compilation and added a comment on a field that
18434 2002-08-15 Martin Baulig <martin@gnome.org>
18436 * class.cs (ConstructorInitializer.Resolve): In the
18437 Expression.MemberLookup call, use the queried_type as
18440 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
18441 declared' attribute, it's always true.
18442 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
18443 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
18444 temporary wrapper for FindMembers which tells MemberLookup whether
18445 members from the base classes are included in the return value.
18446 This will go away soon.
18447 (TypeManager.MemberLookup): Use this temporary hack here; once the
18448 new MemberCache is completed, we don't need to do the DeclaredOnly
18449 looping here anymore since the MemberCache will take care of this.
18450 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
18451 (MemberCache): When creating the MemberCache for a class, get
18452 members from the current class and all its base classes.
18453 (MemberCache.CacheEntry.Container): New field. This is a
18454 temporary hack until the Mono runtime is fixed to distinguish
18455 between ReflectedType and DeclaringType. It allows us to use MCS
18456 with both the MS runtime and the unfixed Mono runtime without
18457 problems and without accecting performance.
18458 (MemberCache.SearchMembers): The DeclaredOnly looping from
18459 TypeManager.MemberLookup is now done here.
18461 2002-08-14 Martin Baulig <martin@gnome.org>
18463 * statement.cs (MyStructInfo.MyStructInfo): Don't call
18464 Type.GetFields on dynamic types but get the fields from the
18465 corresponding TypeContainer.
18466 (MyStructInfo.GetStructInfo): Added check for enum types.
18468 * typemanager.cs (MemberList.IsSynchronized): Implemented.
18469 (MemberList.SyncRoot): Implemented.
18470 (TypeManager.FilterWithClosure): No need to check permissions if
18471 closure_start_type == closure_invocation_type, don't crash if
18472 closure_invocation_type is null.
18474 2002-08-13 Martin Baulig <martin@gnome.org>
18476 Rewrote TypeContainer.FindMembers to use a member cache. This
18477 gives us a speed increase of about 35% for the self-hosting MCS
18478 build and of about 15-20% for the class libs (both on GNU/Linux).
18480 * report.cs (Timer): New class to get enhanced profiling. This
18481 whole class is "TIMER" conditional since it remarkably slows down
18484 * class.cs (MemberList): New class. This is an IList wrapper
18485 which we're now using instead of passing MemberInfo[]'s around to
18486 avoid copying this array unnecessarily.
18487 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
18488 (ICachingMemberFinder, IMemberContainer): New interface.
18489 (TypeManager.FilterWithClosure): If `criteria' is null, the name
18490 has already been checked, otherwise use it for the name comparision.
18491 (TypeManager.FindMembers): Renamed to RealMemberFinder and
18492 provided wrapper which tries to use ICachingMemberFinder.FindMembers
18493 if possible. Returns a MemberList, not a MemberInfo [].
18494 (TypeHandle): New class, implements IMemberContainer. We create
18495 one instance of this class per type, it contains a MemberCache
18496 which is used to do the member lookups.
18497 (MemberCache): New class. Each instance of this class contains
18498 all members of a type and a name-based hash table.
18499 (MemberCache.FindMembers): This is our new member lookup
18500 function. First, it looks up all members of the requested name in
18501 the hash table. Then, it walks this list and sorts out all
18502 applicable members and returns them.
18504 2002-08-13 Martin Baulig <martin@gnome.org>
18506 In addition to a nice code cleanup, this gives us a performance
18507 increase of about 1.4% on GNU/Linux - not much, but it's already
18508 half a second for the self-hosting MCS compilation.
18510 * typemanager.cs (IMemberFinder): New interface. It is used by
18511 TypeManager.FindMembers to call FindMembers on a TypeContainer,
18512 Enum, Delegate or Interface.
18513 (TypeManager.finder_to_member_finder): New PtrHashtable.
18514 (TypeManager.finder_to_container): Removed.
18515 (TypeManager.finder_to_delegate): Removed.
18516 (TypeManager.finder_to_interface): Removed.
18517 (TypeManager.finder_to_enum): Removed.
18519 * interface.cs (Interface): Implement IMemberFinder.
18521 * delegate.cs (Delegate): Implement IMemberFinder.
18523 * enum.cs (Enum): Implement IMemberFinder.
18525 * class.cs (TypeContainer): Implement IMemberFinder.
18527 2002-08-12 Martin Baulig <martin@gnome.org>
18529 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
18531 2002-08-12 Martin Baulig <martin@gnome.org>
18533 * ecore.cs (ITypeExpression): New interface for expressions which
18535 (TypeExpression): Renamed to TypeLookupExpression.
18536 (Expression.DoResolve): If we're doing a types-only lookup, the
18537 expression must implement the ITypeExpression interface and we
18538 call DoResolveType() on it.
18539 (SimpleName): Implement the new ITypeExpression interface.
18540 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
18541 hack, the situation that we're only looking up types can't happen
18542 anymore when this method is called. Moved the type lookup code to
18543 DoResolveType() and call it.
18544 (SimpleName.DoResolveType): This ITypeExpression interface method
18545 is now doing the types-only lookup.
18546 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
18547 (ResolveFlags): Added MaskExprClass.
18549 * expression.cs (MemberAccess): Implement the ITypeExpression
18551 (MemberAccess.DoResolve): Added support for a types-only lookup
18552 when we're called via ITypeExpression.DoResolveType().
18553 (ComposedCast): Implement the ITypeExpression interface.
18555 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18556 Expression.Resolve() with ResolveFlags.Type instead.
18558 2002-08-12 Martin Baulig <martin@gnome.org>
18560 * interface.cs (Interface.Define): Apply attributes.
18562 * attribute.cs (Attribute.ApplyAttributes): Added support for
18563 interface attributes.
18565 2002-08-11 Martin Baulig <martin@gnome.org>
18567 * statement.cs (Block.Emit): Only check the "this" variable if we
18568 do not always throw an exception.
18570 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18571 whether the property has a set accessor.
18573 2002-08-11 Martin Baulig <martin@gnome.org>
18575 Added control flow analysis support for structs.
18577 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18578 with control flow analysis turned off.
18579 (IVariable): New interface.
18580 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18581 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18582 (FieldExpr.DoResolve): Resolve the instance expression with flow
18583 analysis turned off and do the definite assignment check after the
18584 resolving when we know what the expression will resolve to.
18586 * expression.cs (LocalVariableReference, ParameterReference):
18587 Implement the new IVariable interface, only call the flow analysis
18588 code if ec.DoFlowAnalysis is true.
18589 (This): Added constructor which takes a Block argument. Implement
18590 the new IVariable interface.
18591 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18592 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18593 This does the definite assignment checks for struct members.
18595 * class.cs (Constructor.Emit): If this is a non-static `struct'
18596 constructor which doesn't have any initializer, call
18597 Block.AddThisVariable() to tell the flow analysis code that all
18598 struct elements must be initialized before control returns from
18601 * statement.cs (MyStructInfo): New public class.
18602 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18603 argument to this indexer. If non-zero, check an individual struct
18604 member, not the whole struct.
18605 (FlowBranching.CheckOutParameters): Check struct members.
18606 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18607 overloaded versions of these methods which take an additional
18608 `int field_idx' argument to check struct members.
18609 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18610 overloaded versions of these methods which take an additional
18611 `string field_name' argument to check struct member.s
18612 (VariableInfo): Implement the IVariable interface.
18613 (VariableInfo.StructInfo): New public property. Returns the
18614 MyStructInfo instance of the variable if it's a struct or null.
18615 (Block.AddThisVariable): New public method. This is called from
18616 Constructor.Emit() for non-static `struct' constructor which do
18617 not have any initializer. It creates a special variable for the
18618 "this" instance variable which will be checked by the flow
18619 analysis code to ensure that all of the struct's fields are
18620 initialized before control returns from the constructor.
18621 (UsageVector): Added support for struct members. If a
18622 variable/parameter is a struct with N members, we reserve a slot
18623 in the usage vector for each member. A struct is considered fully
18624 initialized if either the struct itself (slot 0) or all its
18625 members are initialized.
18627 2002-08-08 Martin Baulig <martin@gnome.org>
18629 * driver.cs (Driver.MainDriver): Only report an error CS5001
18630 if there were no compilation errors.
18632 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18633 `UnsafeContext' property to determine whether the parent is in
18634 unsafe context rather than checking the parent's ModFlags:
18635 classes nested in an unsafe class are unsafe as well.
18637 2002-08-08 Martin Baulig <martin@gnome.org>
18639 * statement.cs (UsageVector.MergeChildren): Distinguish between
18640 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18641 we return. Added test17() and test18() to test-154.cs.
18643 2002-08-08 Martin Baulig <martin@gnome.org>
18645 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18646 Family access, make sure the invoking type isn't a subclass of the
18647 queried type (that'd be a CS1540).
18649 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18650 this method which takes an additional `Type invocation_type'.
18652 * expression.cs (BaseAccess.DoResolve): Use the base type as
18653 invocation and query type.
18654 (MemberAccess.DoResolve): If the lookup failed and we're about to
18655 report a CS0122, try a lookup with the ec.ContainerType - if this
18656 succeeds, we must report a CS1540.
18658 2002-08-08 Martin Baulig <martin@gnome.org>
18660 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18661 (MethodGroupExpr): Implement the IMemberExpr interface.
18663 * expression (MemberAccess.ResolveMemberAccess): No need to have
18664 any special code for MethodGroupExprs anymore, they're now
18667 2002-08-08 Martin Baulig <martin@gnome.org>
18669 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18670 Family, FamANDAssem and FamORAssem permissions.
18671 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18673 2002-08-08 Martin Baulig <martin@gnome.org>
18675 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18676 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18679 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18681 * driver.cs: implemented /resource option to embed managed resources.
18683 2002-08-07 Martin Baulig <martin@gnome.org>
18685 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18686 (FieldBase.HasFieldInitializer): New public property.
18687 (FieldBase.GetInitializerExpression): New public method. Resolves and
18688 returns the field initializer and makes sure it is only resolved once.
18689 (TypeContainer.EmitFieldInitializers): Call
18690 FieldBase.GetInitializerExpression to get the initializer, this ensures
18691 that it isn't resolved multiple times.
18693 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18694 the resolving process (SimpleName/MemberLookup) that we're currently
18695 emitting a field initializer (which must not access any instance members,
18696 this is an error CS0236).
18698 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18699 argument, if the `IsFieldInitializer' flag is set, we must report and
18700 error CS0236 and not an error CS0120.
18702 2002-08-07 Martin Baulig <martin@gnome.org>
18704 * ecore.cs (IMemberExpr): New public interface.
18705 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18706 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18707 if the expression is an IMemberExpr.
18709 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18710 to be null, implicitly default to `this' if we're non-static in
18711 this case. Simplified the code a lot by using the new IMemberExpr
18712 interface. Also fixed bug #28176 here.
18714 2002-08-06 Martin Baulig <martin@gnome.org>
18716 * cs-parser.jay (SimpleLookup): Removed. We need to create
18717 ParameterReferences during semantic analysis so that we can do a
18718 type-only search when resolving Cast, TypeOf and SizeOf.
18719 (block): Pass the `current_local_parameters' to the Block's
18722 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18723 argument to the constructor.
18724 (ConstructorInitializer.Resolve): Create a temporary implicit
18725 block with the parameters.
18727 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18728 references here if we aren't doing a type-only search.
18730 * statement.cs (Block): Added constructor which takes a
18731 `Parameters parameters' argument.
18732 (Block.Parameters): New public property.
18734 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18735 to `Parameters' and made it public readonly.
18737 2002-08-06 Martin Baulig <martin@gnome.org>
18739 * ecore.cs (Expression.Warning): Made this public as well.
18741 * report.cs (Report.Debug): Print the contents of collections.
18743 2002-08-06 Martin Baulig <martin@gnome.org>
18745 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18746 used to tell Resolve() which kinds of expressions it may return.
18747 (Expression.Resolve): Added overloaded version of this method which
18748 takes a `ResolveFlags flags' argument. This can be used to tell
18749 Resolve() which kinds of expressions it may return. Reports a
18751 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18752 ResolveFlags.SimpleName.
18753 (Expression.Error118): Added overloaded version of this method which
18754 takes a `ResolveFlags flags' argument. It uses the flags to determine
18755 which kinds of expressions are allowed.
18757 * expression.cs (Argument.ResolveMethodGroup): New public method.
18758 Resolves an argument, but allows a MethodGroup to be returned.
18759 This is used when invoking a delegate.
18761 * TODO: Updated a bit.
18763 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18765 Fixed compilation with csc.
18767 * ecore.cs: Expression.Error made public. Is this correct? Should
18768 Warning be made public too?
18770 * expression.cs: use ea.Location instead of ea.loc.
18771 [FIXME: Filed as bug #28607: MCS must report these errors.]
18773 2002-08-06 Martin Baulig <martin@gnome.org>
18775 * ecore.cs (Expression.loc): Moved the location here instead of
18776 duplicating it in all derived classes.
18777 (Expression.Location): New public property.
18778 (Expression.Error, Expression.Warning): Made them non-static and
18779 removed the location argument.
18780 (Expression.Warning): Added overloaded version which takes an
18781 `int level' argument.
18782 (Expression.Error118): Make this non-static and removed the
18783 expression and location arguments.
18784 (TypeExpr): Added location argument to the constructor.
18786 * expression.cs (StaticCallExpr): Added location argument to
18788 (Indirection, PointerArithmetic): Likewise.
18789 (CheckedExpr, UnCheckedExpr): Likewise.
18790 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18791 (StringPtr): Likewise.
18794 2002-08-05 Martin Baulig <martin@gnome.org>
18796 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18798 * assign.cs (Assign.DoResolve): Check whether the source
18799 expression is a value or variable.
18801 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18802 while resolving the corresponding blocks.
18804 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18805 an error, don't silently return null.
18807 * statement.cs (Block.AddVariable): Do the error reporting here
18808 and distinguish between CS0128 and CS0136.
18809 (Block.DoResolve): Report all unused labels (warning CS0164).
18810 (LabeledStatement): Pass the location to the constructor.
18811 (LabeledStatement.HasBeenReferenced): New property.
18812 (LabeledStatement.Resolve): Set it to true here.
18814 * statement.cs (Return.Emit): Return success even after reporting
18815 a type mismatch error (CS0126 or CS0127), this is what csc does and
18816 it avoids confusing the users with any consecutive errors.
18818 2002-08-05 Martin Baulig <martin@gnome.org>
18820 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18822 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18824 * expression.cs (MemberAccess.DoResolve): Silently return if an
18825 error has already been reported.
18827 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18828 error has already been reported.
18830 2002-08-05 Martin Baulig <martin@gnome.org>
18832 * statement.cs (UsageVector): Only initialize the `parameters'
18833 vector if we actually have any "out" parameters.
18835 2002-08-05 Martin Baulig <martin@gnome.org>
18837 * expression.cs (Binary.ResolveOperator): When combining delegates,
18838 they must have the same type.
18840 2002-08-05 Martin Baulig <martin@gnome.org>
18842 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18843 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18844 work with the ms runtime and we also don't need it: if we're a
18845 PropertyBuilder and not in the `indexer_arguments' hash, then we
18846 are a property and not an indexer.
18848 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18849 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18850 since the latter one doesn't work with the ms runtime.
18852 2002-08-03 Martin Baulig <martin@gnome.org>
18854 Fixed bugs #27998 and #22735.
18856 * class.cs (Method.IsOperator): New public field.
18857 (Method.CheckBase): Report CS0111 if there's already a method
18858 with the same parameters in the current class. Report CS0508 when
18859 attempting to change the return type of an inherited method.
18860 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18861 and it's not marked abstract or extern.
18862 (PropertyBase): New abstract base class for Property and Indexer.
18863 (PropertyBase.CheckBase): Moved here from Property and made it work
18865 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18866 the same so we can reuse it there.
18867 (Property, Indexer): Derive from PropertyBase.
18868 (MethodSignature.inheritable_property_signature_filter): New delegate
18869 to find properties and indexers.
18871 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18872 argument and improved error reporting.
18874 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18875 EmptyReadOnlyParameters and made it a property.
18877 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18878 version of this method which takes a `PropertyInfo indexer'.
18879 (TypeManager.RegisterIndexer): New method.
18881 * class.cs: Added myself as author of this file :-)
18883 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18885 * class.cs: fixed compilation on windoze.
18887 2002-08-03 Martin Baulig <martin@gnome.org>
18889 * interface.cs (Interface.GetInterfaceBases): Check whether all
18890 base interfaces are at least as accessible than the current one.
18892 * class.cs (TypeContainer.GetClassBases): Check whether base types
18893 are at least as accessible than the current type.
18894 (TypeContainer.AsAccessible): Implemented and made non-static.
18895 (MemberBase.CheckParameters): Report errors if the accessibility
18898 * delegate.cs (Delegate.Delegate): The default visibility is
18899 internal for top-level types and private for nested types.
18900 (Delegate.Define): Report errors if the accessibility checks fail.
18902 * enum.cs (Enum.Enum): The default visibility is internal for
18903 top-level types and private for nested types.
18904 (Enum.DefineType): Compute the correct visibility.
18906 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
18907 function which takes a `bool is_toplevel' instead of a TypeContainer.
18909 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
18912 2002-08-02 Martin Baulig <martin@gnome.org>
18914 * expression.cs (LocalVariableReferenc): Added constructor which
18915 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
18916 (LocalVariableReference.IsReadOnly): New property.
18917 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
18918 variable is readonly, use our own readonly flag to do this; you can
18919 use the new constructor to get a writable reference to a read-only
18922 * cs-parser.jay (foreach_statement, using_statement): Get a writable
18923 reference to the local variable.
18925 2002-08-01 Miguel de Icaza <miguel@ximian.com>
18927 * rootcontext.cs (ResolveCore): Also include System.Exception
18929 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
18930 we reach an EmptyStatement.
18932 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
18935 * expression.cs (Binary.ResolveOperator): Check error result in
18938 use brtrue/brfalse directly and avoid compares to null.
18940 2002-08-02 Martin Baulig <martin@gnome.org>
18942 * class.cs (TypeContainer.Define): Define all nested interfaces here.
18943 Fixes bug #28407, added test-155.cs.
18945 2002-08-01 Martin Baulig <martin@gnome.org>
18947 * class.cs (Event.EmitDefaultMethod): Make this work with static
18948 events. Fixes #28311, added verify-3.cs.
18950 2002-08-01 Martin Baulig <martin@gnome.org>
18952 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
18953 `is_disposable' fields.
18954 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
18955 `hm.is_disposable' if we're using the collection pattern.
18956 (Foreach.EmitCollectionForeach): Use the correct type for the
18957 enumerator's local variable, only emit the try/finally block if
18958 necessary (fixes #27713).
18960 2002-08-01 Martin Baulig <martin@gnome.org>
18962 * ecore.cs (Expression.report118): Renamed to Error118 and made
18965 * statement.cs (Throw.Resolve): Check whether the expression is of
18966 the correct type (CS0118) and whether the type derives from
18967 System.Exception (CS0155).
18968 (Catch.Resolve): New method. Do the type lookup here and check
18969 whether it derives from System.Exception (CS0155).
18970 (Catch.CatchType, Catch.IsGeneral): New public properties.
18972 * typemanager.cs (TypeManager.exception_type): Added.
18974 2002-07-31 Miguel de Icaza <miguel@ximian.com>
18976 * driver.cs: Updated About function.
18978 2002-07-31 Martin Baulig <martin@gnome.org>
18980 Implemented Control Flow Analysis.
18982 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
18983 (EmitContext.CurrentBranching): Added.
18984 (EmitContext.StartFlowBranching): Added.
18985 (EmitContext.EndFlowBranching): Added.
18986 (EmitContext.KillFlowBranching): Added.
18987 (EmitContext.IsVariableAssigned): Added.
18988 (EmitContext.SetVariableAssigned): Added.
18989 (EmitContext.IsParameterAssigned): Added.
18990 (EmitContext.SetParameterAssigned): Added.
18991 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
18992 Added control flow analysis stuff here.
18994 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
18995 resolve the expression as lvalue.
18996 (LocalVariableReference.DoResolve): Check whether the variable has
18997 already been assigned.
18998 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
18999 the parameter as assigned here.
19000 (ParameterReference.DoResolve): Check whether the parameter has already
19002 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
19003 expression as lvalue.
19005 * statement.cs (FlowBranching): New class for the flow analysis code.
19006 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
19007 (LabeledStatement.IsDefined): New public property.
19008 (LabeledStatement.AddUsageVector): New public method to tell flow
19009 analyis that the label may be reached via a forward jump.
19010 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
19012 (VariableInfo.Number): New public field. This is used by flow analysis
19013 to number all locals of a block.
19014 (Block.CountVariables): New public property. This is the number of
19015 local variables in this block (including the locals from all parent
19017 (Block.EmitMeta): Number all the variables.
19019 * statement.cs: Added flow analysis support to all classes.
19021 2002-07-31 Martin Baulig <martin@gnome.org>
19023 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
19024 To get debugging messages, compile mcs with /define:MCS_DEBUG and
19025 then use this argument.
19027 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
19029 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
19030 use this to specify /define options.
19032 2002-07-29 Martin Baulig <martin@gnome.org>
19034 * statement.cs (Fixed): Moved all code that does variable lookups
19035 and resolvings from Emit to Resolve.
19037 * statement.cs (For): Moved all code that does variable lookups
19038 and resolvings from Emit to Resolve.
19040 * statement.cs (Using): Moved all code that does variable lookups
19041 and resolvings from Emit to Resolve.
19043 2002-07-29 Martin Baulig <martin@gnome.org>
19045 * attribute.cs (Attribute.Resolve): Explicitly catch a
19046 System.NullReferenceException when creating the
19047 CustromAttributeBuilder and report a different warning message.
19049 2002-07-29 Martin Baulig <martin@gnome.org>
19051 * support.cs (ParameterData.ParameterName): Added method to
19052 get the name of a parameter.
19054 * typemanager.cs (TypeManager.IsValueType): New public method.
19056 2002-07-29 Martin Baulig <martin@gnome.org>
19058 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
19059 is a flag which specifies that it's either ref or out.
19060 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
19061 the out parameter to `out Parameter.Modifier mod', also set the
19062 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
19064 * support.cs (InternalParameters.ParameterModifier): Distinguish
19065 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19066 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19068 * expression.cs (Argument.GetParameterModifier): Distinguish
19069 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19070 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19072 2002-07-29 Martin Baulig <martin@gnome.org>
19074 * expression.cs (ParameterReference.ParameterReference): Added
19075 `Location loc' argument to the constructor.
19077 * cs-parser.jay: Pass location to ParameterReference.
19079 2002-07-28 Miguel de Icaza <miguel@ximian.com>
19081 * statement.cs (Try): Initialize the location.
19083 * cs-parser.jay: pass location to Try.
19085 * expression.cs (Unary.Reduce): Change the prototype to return
19086 whether a constant fold could be performed or not. The result is
19087 returned in an out parameters. In the case of Indirection and
19088 AddressOf, we want to perform the full tests.
19090 2002-07-26 Miguel de Icaza <miguel@ximian.com>
19092 * statement.cs (Statement.Emit): Flag dead code.
19094 2002-07-27 Andrew Birkett <andy@nobugs.org>
19096 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
19098 2002-07-27 Martin Baulig <martin@gnome.org>
19100 * class.cs (MethodData.Define): Put back call to
19101 TypeManager.AddMethod(), accidentally commented this out.
19103 * report.cs (Debug): New public method to print debugging information,
19104 this is `[Conditional ("DEBUG")]'.
19106 2002-07-26 Martin Baulig <martin@gnome.org>
19108 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
19109 (switch_statement): Push the current_block to the switch_stack and
19110 pop it again when we're done with the switch.
19111 (switch_section): The new block is a child of the current_block.
19112 Fixes bug #24007, added test-152.cs.
19114 2002-07-27 Martin Baulig <martin@gnome.org>
19116 * expression.cs (Invocation.EmitArguments): When calling a varargs
19117 function with only its fixed arguments, we need to pass an empty
19120 2002-07-27 Martin Baulig <martin@gnome.org>
19122 Mono 0.13 has been released.
19124 2002-07-25 Miguel de Icaza <miguel@ximian.com>
19126 * driver.cs: Rename --resource to --linkres, because that is what
19127 we do currently, we dont support --resource yet.
19129 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
19131 2002-07-25 Martin Baulig <martin@gnome.org>
19133 * class.cs (MethodData): New public class. This is a `method builder'
19134 class for a method or one accessor of a Property/Indexer/Event.
19135 (MethodData.GetMethodFlags): Moved here from MemberBase.
19136 (MethodData.ApplyAttributes): Likewise.
19137 (MethodData.ApplyObsoleteAttribute): Likewise.
19138 (MethodData.ApplyConditionalAttribute): Likewise.
19139 (MethodData.ApplyDllImportAttribute): Likewise.
19140 (MethodData.CheckAbstractAndExternal): Likewise.
19141 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
19142 (MethodData.Emit): Formerly known as Method.Emit().
19143 (MemberBase): Moved everything which was specific to a single
19144 accessor/method to MethodData.
19145 (Method): Create a new MethodData and call Define() and Emit() on it.
19146 (Property, Indexer, Event): Create a new MethodData objects for each
19147 accessor and call Define() and Emit() on them.
19149 2002-07-25 Martin Baulig <martin@gnome.org>
19151 Made MethodCore derive from MemberBase to reuse the code from there.
19152 MemberBase now also checks for attributes.
19154 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
19155 (MemberBase.GetMethodFlags): Moved here from class Method and marked
19157 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
19158 `CallingConventions cc' and `Attributes opt_attrs' arguments.
19159 (MemberBase.ApplyAttributes): New virtual method; applies the
19160 attributes to a method or accessor.
19161 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
19162 (MemberBase.ApplyConditionalAttribute): Likewise.
19163 (MemberBase.ApplyDllImportAttribute): Likewise.
19164 (MemberBase.CheckAbstractAndExternal): Likewise.
19165 (MethodCore.ParameterTypes): This is now a property instead of a
19166 method, it's initialized from DoDefineParameters().
19167 (MethodCore.ParameterInfo): Removed the set accessor.
19168 (MethodCore.DoDefineParameters): New protected virtual method to
19169 initialize ParameterTypes and ParameterInfo.
19170 (Method.GetReturnType): We can now simply return the MemberType.
19171 (Method.GetMethodFlags): Override the MemberBase version and add
19172 the conditional flags.
19173 (Method.CheckBase): Moved some code from Define() here, call
19174 DoDefineParameters() here.
19175 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
19176 here to avoid some larger code duplication.
19177 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
19178 ensure that abstract and external accessors don't declare a body.
19180 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
19181 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
19182 lookup in the attribute's parent classes, so we need to abort as soon
19183 as we found the first match.
19184 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
19185 the attribute has no arguments.
19187 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
19190 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19192 * cs-parser.jay: reverted previous patch.
19194 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19196 * cs-parser.jay: fixed bug #22119.
19198 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19200 * attribute.cs: fixed compilation. The error was:
19201 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
19202 be assigned to before control leaves the current method."
19203 [FIXME: Filed as bug #28186: MCS must report this error.]
19205 2002-07-25 Martin Baulig <martin@gnome.org>
19207 * attribute.cs (Attribute.Conditional_GetConditionName): New static
19208 method to pull the condition name ouf of a Conditional attribute.
19209 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
19210 the obsolete message and error flag out of an Obsolete attribute.
19212 * class.cs (Method.GetMethodFlags): New public method to get the
19213 TypeManager.MethodFlags for this method.
19214 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
19216 (Method.Define): Get and apply the Obsolete and Conditional attributes;
19217 if we're overriding a virtual function, set the new private variable
19218 `parent_method'; call the new TypeManager.AddMethod().
19220 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
19221 the MethodBuilder and the Method in a PtrHashtable.
19222 (TypeManager.builder_to_method): Added for this purpose.
19223 (TypeManager.MethodFlags): Added IsObsoleteError.
19224 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
19225 Obsolete and Conditional arguments in MethodBuilders. If we discover
19226 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
19227 the message from the attribute.
19229 2002-07-24 Martin Baulig <martin@gnome.org>
19231 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
19232 preprocessor directives, ensure that the argument to #define/#undef is
19233 exactly one identifier and that it's actually an identifier.
19235 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
19238 2002-07-24 Martin Baulig <martin@gnome.org>
19240 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
19241 initialize it to TypeManager.object_type in the constructor.
19242 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
19243 of the `hm.get_current' method if we're using the collection pattern.
19244 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
19245 for the explicit conversion to make it work when we're using the collection
19246 pattern and the `Current' property has a different return type than `object'.
19249 2002-07-24 Martin Baulig <martin@gnome.org>
19251 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
19252 does not match, but don't report any errors. This method is called in
19253 order for all methods in a MethodGroupExpr until a matching method is
19254 found, so we don't want to bail out if the first method doesn't match.
19255 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
19256 matches, report the 123. Fixes #28070.
19258 2002-07-24 Martin Baulig <martin@gnome.org>
19260 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
19261 TypeManager.TypeToCoreType() to the top of the method so the
19262 following equality checks will work. Fixes #28107.
19264 2002-07-24 Martin Baulig <martin@gnome.org>
19266 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
19267 operand is of type uint, and the other operand is of type sbyte,
19268 short or int, the operands are converted to type long." -
19269 Actually do what this comment already told us. Fixes bug #28106,
19272 2002-07-24 Martin Baulig <martin@gnome.org>
19274 * class.cs (MethodBase): New abstract class. This is now a base
19275 class for Property, Indexer and Event to avoid some code duplication
19276 in their Define() and DefineMethods() methods.
19277 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
19278 generic methods for Define() and DefineMethods().
19279 (FieldBase): Derive from MemberBase, not MemberCore.
19280 (Property): Derive from MemberBase, not MemberCore.
19281 (Property.DefineMethod): Moved all the code from this method to the
19282 new MethodBase.DefineAccessor(), just call it with appropriate
19284 (Property.Define): Call the new Property.DoDefine(), this does some
19285 sanity checks and we don't need to duplicate the code everywhere.
19286 (Event): Derive from MemberBase, not MemberCore.
19287 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
19288 accessors, this will also make them work with interface events.
19289 (Indexer): Derive from MemberBase, not MemberCore.
19290 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
19291 (Indexer.Define): Use the new MethodBase functions.
19293 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
19294 argument to the constructor.
19295 (Interface.FindMembers): Added support for interface events.
19296 (Interface.PopluateEvent): Implemented.
19298 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
19300 2002-07-22 Miguel de Icaza <miguel@ximian.com>
19302 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
19303 but this is required to check for a method name being the same as
19304 the containing class.
19308 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19310 * interface.cs: initialize variable.
19312 2002-07-23 Martin Baulig <martin@gnome.org>
19314 Implemented the IndexerName attribute in interfaces.
19316 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
19317 name if this is an explicit interface implementation.
19318 (Indexer.InterfaceIndexerName): New public variable. If we're
19319 implementing an interface indexer, this is the IndexerName in that
19320 interface. Otherwise, it's the IndexerName.
19321 (Indexer.DefineMethod): If we're implementing interface indexer,
19322 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
19323 and Pending.ImplementIndexer methods.
19324 (Indexer.Define): Also define the PropertyBuilder if we're
19325 implementing an interface indexer and this is neither an explicit
19326 interface implementation nor do the IndexerName match the one in
19329 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
19330 If a method is defined here, then we always need to create a proxy
19331 for it. This is used when implementing interface indexers.
19332 (Pending.IsInterfaceIndexer): New public method.
19333 (Pending.ImplementIndexer): New public method.
19334 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
19335 This is used when implementing interface indexers to define a proxy
19337 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
19338 define a proxy if necessary.
19340 * interface.cs (Interface.IndexerName): New public variable.
19341 (Interface.PopulateIndexer): Set the IndexerName.
19342 (Interface.DefineIndexers): New private method. Populate all the
19343 indexers and make sure their IndexerNames match.
19345 * typemanager.cs (IndexerPropertyName): Added support for interface
19348 2002-07-22 Martin Baulig <martin@gnome.org>
19350 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
19351 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
19352 ret if HasReturnLabel.
19353 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
19356 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
19357 and set the ec.LoopBeginTryCatchLevel.
19358 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
19359 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
19360 the current ec.TryCatchLevel, the branch goes out of an exception
19361 block. In this case, we need to use Leave and not Br.
19363 2002-07-22 Martin Baulig <martin@gnome.org>
19365 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
19366 block unless the block does not always return or it is contained in
19367 another try { ... } catch { ... } block. Fixes bug #26506.
19368 Added verify-1.cs to the test suite.
19370 2002-07-22 Martin Baulig <martin@gnome.org>
19372 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
19373 then we do not always return. Fixes bug #24985.
19375 2002-07-22 Martin Baulig <martin@gnome.org>
19377 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
19378 lookup on a per-class level; ie. walk up the class hierarchy until we
19379 found at least one applicable method, then choose the best among them.
19380 Fixes bug #24463 and test-29.cs.
19382 2002-07-22 Martin Baulig <martin@gnome.org>
19384 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
19385 return types of the methods. The return type is not part of the
19386 signature and we must not check it to make the `new' modifier work.
19387 Fixes bug #27999, also added test-147.cs.
19388 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
19390 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
19391 on the method's return type.
19393 2002-07-21 Martin Baulig <martin@gnome.org>
19395 * assign.cs: Make this work if the rightmost source is a constant and
19396 we need to do an implicit type conversion. Also adding a few more tests
19397 to test-38.cs which should have caught this.
19399 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
19400 target in the makefile for this. The makefile.gnu is primarily intended
19401 for end-users who don't want to debug the compiler.
19403 2002-07-21 Martin Baulig <martin@gnome.org>
19405 * assign.cs: Improved the Assign class so it can now handle embedded
19406 assignments (X = Y = Z = something). As a side-effect this'll now also
19407 consume less local variables. test-38.cs now passes with MCS, added
19408 a few new test cases to that test.
19410 2002-07-20 Martin Baulig <martin@gnome.org>
19412 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
19413 instructions. Fixes bug #27977, also added test-146.cs.
19415 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19417 * cs-tokenizer.cs: fixed getHex ().
19419 2002-07-19 Martin Baulig <martin@gnome.org>
19421 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
19422 not Type.GetType() to lookup the array type. This is needed when
19423 we're constructing an array of a user-defined type.
19424 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
19425 single-dimensional arrays, but also for single-dimensial arrays of
19428 2002-07-19 Martin Baulig <martin@gnome.org>
19430 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
19431 this function is called, it's not allowed to share LocalBuilders
19432 among ILGenerators.
19434 2002-07-19 Martin Baulig <martin@gnome.org>
19436 * expression.cs (Argument.Resolve): Report an error 118 when trying
19437 to pass a type as argument.
19439 2002-07-18 Martin Baulig <martin@gnome.org>
19441 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
19442 Conv_R_Un for the signed `long' type.
19444 2002-07-15 Miguel de Icaza <miguel@ximian.com>
19446 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
19447 `expr' for the temporary result, as that will fail if we do
19448 multiple resolves on the same expression.
19450 2002-07-05 Miguel de Icaza <miguel@ximian.com>
19452 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
19453 ec.TypeContainer for looking up aliases.
19455 * class.cs (TypeContainer): Remove LookupAlias from here.
19457 * decl.cs (DeclSpace); Move here.
19459 2002-07-01 Miguel de Icaza <miguel@ximian.com>
19461 * class.cs (FindMembers): Only call filter if the constructor
19462 bulider is not null.
19464 Also handle delegates in `NestedTypes' now. Now we will perform
19465 type lookups using the standard resolution process. This also
19468 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
19469 This uses Expressions (the limited kind that can be parsed by the
19470 tree) instead of strings.
19472 * expression.cs (ComposedCast.ToString): Implement, used to flag
19473 errors since now we have to render expressions.
19475 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
19478 * ecore.cs (SimpleName.ToString): ditto.
19480 * cs-parser.jay: Instead of using strings to assemble types, use
19481 Expressions to assemble the type (using SimpleName, ComposedCast,
19482 MemberAccess). This should fix the type lookups in declarations,
19483 because we were using a different code path for this.
19485 * statement.cs (Block.Resolve): Continue processing statements
19486 even when there is an error.
19488 2002-07-17 Miguel de Icaza <miguel@ximian.com>
19490 * class.cs (Event.Define): Also remove the `remove' method from
19491 the list of pending items.
19493 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
19494 generate more compact code.
19496 2002-07-17 Martin Baulig <martin@gnome.org>
19498 * const.cs (Const.LookupConstantValue): Add support for constant
19499 `unchecked' and `checked' expressions.
19500 Also adding test case test-140.cs for this.
19502 2002-07-17 Martin Baulig <martin@gnome.org>
19504 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
19505 check whether mi.ReturnType implements the IEnumerator interface; the
19506 `==' and the IsAssignableFrom() will fail in this situation.
19508 2002-07-16 Ravi Pratap <ravi@ximian.com>
19510 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
19513 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19515 * expression.cs: fixed bug #27811.
19517 2002-07-14 Miguel de Icaza <miguel@ximian.com>
19519 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
19520 Molaro: when we are a ref, the value already contains a pointer
19521 value, do not take the address of it.
19523 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19524 * removed mb-parser.jay and mb-tokenizer.cs
19526 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19528 * expression.cs: check against the building corlib void type.
19530 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
19532 * ecore.cs: fix for valuetype static readonly fields: when
19533 initializing them, we need their address, not the address of a copy.
19535 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
19537 * typemanager.cs: register also enum_type in corlib.
19539 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19541 * class.cs: allow calling this (but not base) initializers in structs.
19543 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
19545 * ecore.cs: make sure we compare against the building base types
19548 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
19550 * typemanager.cs: fix TypeToCoreType() to handle void and object
19551 (corlib gets no more typerefs after this change).
19553 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19555 * expression.cs (ArrayCreation.EmitArrayArguments): use
19556 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19558 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19559 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19560 array indexes, the runtime actually forbids them.
19562 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19563 for array arguments here.
19565 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19566 instead of the default for ValueTypes.
19568 (New.DoEmit): Use IsValueType instead of
19569 IsSubclassOf (value_type)
19570 (New.DoResolve): ditto.
19571 (Invocation.EmitCall): ditto.
19573 * assign.cs (Assign): ditto.
19575 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19576 Statements *are* currently doing part of their resolution during
19579 Expressions do always resolve during resolve, but statements are
19580 only required to propagate resolution to their children.
19582 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19584 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19586 (LoadAssembly): Do not add the dll if it is already specified
19588 (MainDriver): Add the System directory to the link path at the end,
19589 after all the other -L arguments.
19591 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19592 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19593 ldelem.u1) and using the opposite for sbytes.
19595 This fixes Digger, and we can finally run it.
19597 * driver.cs (UnixParseOption): Move the option parsing here.
19598 (CSCParseOption): Implement CSC-like parsing of options.
19600 We now support both modes of operation, the old Unix way, and the
19601 new CSC-like way. This should help those who wanted to make cross
19602 platform makefiles.
19604 The only thing broken is that /r:, /reference: and /lib: are not
19605 implemented, because I want to make those have the same semantics
19606 as the CSC compiler has, and kill once and for all the confussion
19607 around this. Will be doing this tomorrow.
19609 * statement.cs (Unsafe.Resolve): The state is checked during
19610 resolve, not emit, so we have to set the flags for IsUnsfe here.
19612 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19614 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19615 not catch the Error_ObjectRefRequired in SimpleName (as it is
19616 possible to have a class/instance variable name that later gets
19617 deambiguated), we have to check this here.
19619 2002-07-10 Ravi Pratap <ravi@ximian.com>
19621 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19622 make static and put into Expression.
19624 (Event.Define): Register the private field of the event with the
19625 TypeManager so that GetFieldFromEvent can get at it.
19627 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19628 keep track of the private field associated with an event which
19631 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19634 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19636 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19638 * expression.cs (Binary.EmitBranchable): this routine emits the
19639 Binary expression in a branchable context. This basically means:
19640 we need to branch somewhere, not just get the value on the stack.
19642 This works together with Statement.EmitBoolExpression.
19644 * statement.cs (Statement.EmitBoolExpression): Use
19647 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19649 * statement.cs (For): Reduce the number of jumps in loops.
19651 (For): Implement loop inversion for the For statement.
19653 (Break): We can be breaking out of a Try/Catch controlled section
19654 (foreach might have an implicit try/catch clause), so we need to
19655 use Leave instead of Br.
19657 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19658 now). If the instace expression supports IMemoryLocation, we use
19659 the AddressOf method from the IMemoryLocation to extract the
19660 address instead of emitting the instance.
19662 This showed up with `This', as we were emitting the instance
19663 always (Emit) instead of the Address of This. Particularly
19664 interesting when This is a value type, as we dont want the Emit
19665 effect (which was to load the object).
19667 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19669 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19671 * statement.cs (Checked): Set the CheckedState during the resolve
19672 process too, as the ConvCast operations track the checked state on
19673 the resolve process, and not emit.
19675 * cs-parser.jay (namespace_member_declaration): Flag that we have
19676 found a declaration when we do. This is used to flag error 1529
19678 * driver.cs: Report ok when we display the help only.
19680 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19682 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19684 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19686 * cs-tokenizer.cs (define): We also have to track locally the
19687 defines. AllDefines is just used for the Conditional Attribute,
19688 but we also need the local defines for the current source code.
19690 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19692 * statement.cs (While, For, Do): These loops can exit through a
19693 Break statement, use this information to tell whether the
19694 statement is the last piece of code.
19696 (Break): Flag that we break.
19698 * codegen.cs (EmitContexts): New `Breaks' state variable.
19700 2002-07-03 Martin Baulig <martin@gnome.org>
19702 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19703 modifiers in method declarations in structs. Otherwise, you won't
19704 be able to override things like Object.Equals().
19706 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19708 * class.cs (Method, Property, Indexer): Do not allow the public
19709 modifier to be used in explicit interface implementations.
19711 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19712 override modifiers in method declarations in structs
19714 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19716 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19717 integer or real overflow, report an error
19719 2002-07-02 Martin Baulig <martin@gnome.org>
19721 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19722 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19723 to tell the runtime about our newly created System.Object and
19724 System.ValueType types.
19726 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19728 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19729 struct instead of Ldarg/Starg.
19731 2002-07-02 Martin Baulig <martin@gnome.org>
19733 * expression.cs (Indirection.Indirection): Call
19734 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19736 2002-07-02 Martin Baulig <martin@gnome.org>
19738 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19739 ValueType, call TypeManager.TypeToCoreType() on it.
19740 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19741 the OpCodes.Newarr argument.
19743 2002-07-02 Martin Baulig <martin@gnome.org>
19745 * expression.cs (Invocation.EmitCall): When compiling corlib,
19746 replace all calls to the system's System.Array type to calls to
19747 the newly created one.
19749 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19750 System.Array methods.
19751 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19752 from the system's System.Array type which must be replaced.
19754 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19756 * typemanager.cs: load unverifiable_code_ctor so we can build
19757 corlib using the correct type. Avoid using GetTypeCode() with
19759 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19760 TypeManager.object_type to allow building corlib.
19762 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19764 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19766 2002-07-01 Martin Baulig <martin@gnome.org>
19768 * class.cs: Make the last change actually work, we need to check
19769 whether `ifaces != null' to avoid a crash.
19771 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19773 * class.cs: when we build structs without fields that implement
19774 interfaces, we need to add the interfaces separately, since there is
19775 no API to both set the size and add the interfaces at type creation
19778 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19780 * expression.cs: the dimension arguments to the array constructors
19781 need to be converted if they are a long.
19783 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19785 * class.cs: don't emit ldarg.0 if there is no parent constructor
19786 (fixes showstopper for corlib).
19788 2002-06-29 Martin Baulig <martin@gnome.org>
19790 MCS now compiles corlib on GNU/Linux :-)
19792 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19793 ie. check for MethodImplOptions.InternalCall.
19795 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19796 and TypeManager.attribute_type are null, so we must explicitly check
19797 whether parent is not null to find out whether it's an attribute type.
19798 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19799 and SetBuilder, not only if the property is neither abstract nor external.
19800 This is necessary to set the MethodImplOptions on the accessor methods.
19801 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19802 SetBuilder, see Property.Emit().
19804 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19805 populate "System.Object", "System.ValueType" and "System.Attribute" since
19806 they've already been populated from BootCorlib_PopulateCoreTypes().
19808 2002-06-29 Martin Baulig <martin@gnome.org>
19810 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19811 is the NullLiteral, we also need to make sure that target_type is not
19814 2002-06-29 Martin Baulig <martin@gnome.org>
19816 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19817 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19818 before calling BootstrapCorlib_ResolveDelegate ().
19820 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19822 * statement.cs: fixed build-breaker. All tests passed ok.
19824 2002-06-27 Martin Baulig <martin@gnome.org>
19826 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19827 for System.Decimal when compiling corlib.
19829 2002-06-27 Martin Baulig <martin@gnome.org>
19831 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19832 switch blocks which contain nothing but a default clause.
19834 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19836 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19838 2002-06-27 Martin Baulig <martin@gnome.org>
19840 * ecore.cs (PropertyExpr.PropertyExpr): Call
19841 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19843 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19844 is already a TypeBuilder.
19846 2002-06-27 Martin Baulig <martin@gnome.org>
19848 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19849 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19850 the "from an array-type to System.Array" case. This makes it work
19851 when compiling corlib.
19853 2002-06-27 Martin Baulig <martin@gnome.org>
19855 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19856 non-static PropertyExpr, set its InstanceExpression. This makes
19857 the `ICollection.Count' property work in System/Array.cs.
19859 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19861 * driver.cs: Made error handling more consistent. Errors now
19862 tracked by Report class, so many methods which used to return int
19863 now return void. Main() now prints success/failure and
19864 errors/warnings message.
19866 Renamed '--probe' compiler argument to '--expect-error'. Removed
19867 the magic number return values (123 and 124). Now, if the
19868 expected error occurs, the compiler exits with success (exit value
19869 0). If the compilation completes without seeing that particular
19870 error, the compiler exits with failure (exit value 1). The
19871 makefile in mcs/errors has been changed to handle the new behaviour.
19873 * report.cs: Made 'expected error' number a property and renamed
19874 it from 'Probe' to 'ExpectedError'.
19876 * genericparser.cs: Removed error handling support, since it is
19877 now all done by Report class.
19879 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19880 class, so parse() no longer returns an int.
19882 * namespace.cs: Use Report.Error instead of GenericParser.error
19884 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19886 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19887 TypeContainer.AddOperator): At the front of the list put the
19888 explicit implementations, so they get resolved/defined first.
19890 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19892 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19893 interface type is implemented by this TypeContainer. Used during
19894 explicit interface implementation.
19896 (Property.Define, Indexer.Define, Method.Define): Validate that
19897 the given interface in the explicit implementation is one of the
19898 base classes for the containing type.
19900 Also if we are explicitly implementing an interface, but there is
19901 no match in the pending implementation table, report an error.
19903 (Property.Define): Only define the property if we are
19904 not explicitly implementing a property from an interface. Use the
19905 correct name also for those properties (the same CSC uses,
19906 although that is really not needed).
19908 (Property.Emit): Do not emit attributes for explicitly implemented
19909 properties, as there is no TypeBuilder.
19911 (Indexer.Emit): ditto.
19913 Hiding then means that we do not really *implement* a pending
19914 implementation, which makes code fail.
19916 2002-06-22 Martin Baulig <martin@gnome.org>
19918 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
19919 the return value of Object.GetType(). [FIXME: we need to do this whenever
19920 we get a type back from the reflection library].
19922 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
19924 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
19926 2002-06-20 Miguel de Icaza <miguel@ximian.com>
19928 * attribute.cs: Return null if we can not look up the type.
19930 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
19931 the interface types found.
19933 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
19934 interface types found.
19936 * typemanager.cs (GetInterfaces): Make this routine returns alll
19937 the interfaces and work around the lame differences between
19938 System.Type and System.Reflection.Emit.TypeBuilder in the results
19939 result for GetInterfaces.
19941 (ExpandInterfaces): Given an array of interface types, expand and
19942 eliminate repeated ocurrences of an interface. This expands in
19943 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
19946 2002-06-21 Martin Baulig <martin@gnome.org>
19948 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
19951 2002-06-21 Martin Baulig <martin@gnome.org>
19953 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
19954 and called with one of the core types, return the corresponding typebuilder for
19957 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
19960 2002-06-21 Martin Baulig <martin@gnome.org>
19962 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
19963 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
19964 (Expression.ConvertReferenceExplicit): Likewise.
19966 * expression.cs (ElementAccess.DoResolve): Likewise.
19967 (ElementAccess.DoResolveLValue): Likewise.
19969 2002-06-10 Martin Baulig <martin@gnome.org>
19971 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
19972 add the "value" parameter to the parameter list.
19974 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
19977 2002-06-19 Miguel de Icaza <miguel@ximian.com>
19979 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
19980 the argument to an int, uint, long or ulong, per the spec. Also
19981 catch negative constants in array creation.
19983 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
19985 * class.cs: do not allow the same interface to appear twice in
19986 the definition list.
19988 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
19990 * ecore.cs: don't use ldlen with System.Array.
19992 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
19994 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
19996 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
19998 * modifiers.cs: produce correct field attributes for protected
19999 internal. Easy fix so miguel can work on ther harder stuff:-)
20001 2002-06-18 Miguel de Icaza <miguel@ximian.com>
20003 * pending.cs: New file. Move the code from class.cs here.
20004 Support clearning the pending flag for all methods (when not doing
20005 explicit interface implementation).
20007 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
20009 * rootcontext.cs: added a couple more types needed to bootstrap.
20011 2002-06-17 Miguel de Icaza <miguel@ximian.com>
20013 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
20014 constructor in the type, instead of any constructor in the type
20015 hierarchy. Thanks to Paolo for finding this bug (it showed up as
20016 a bug in the Mono runtime when applying the params attribute).
20018 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20019 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
20021 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
20023 * expression.cs (Unary.ResolveOperator): Use TypeManager
20024 to resolve the type.
20026 2002-06-13 Ravi Pratap <ravi@ximian.com>
20028 * cs-parser.jay (enum_member_declaration): Pass in the attributes
20031 * enum.cs (AddEnumMember): Add support to store the attributes associated
20032 with each member too.
20034 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
20035 field builders too - this takes care of the enum member case.
20037 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
20039 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
20040 address-of operator on both value types and pointers.
20042 2002-06-10 Martin Baulig <martin@gnome.org>
20044 * interface.cs (Interface.PopulateIndexer): Add the indexer's
20045 PropertyBuilder to the `property_builders' list.
20047 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
20048 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
20049 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
20050 find any indexers which are inherited from an interface.
20052 2002-06-09 Martin Baulig <martin@gnome.org>
20054 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
20055 the same type as the constant if necessary. There's also a test-130.cs
20058 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
20060 * typemanager.cs (TypeManager.ChangeType): Previously known as
20061 Enum.ChangeEnumType().
20063 2002-06-09 Martin Baulig <martin@gnome.org>
20065 * expression.cs (Cast.TryReduce): Added support for consts.
20067 2002-06-08 Ravi Pratap <ravi@ximian.com>
20069 * class.cs (Accessor): Hold attributes information so we can pass
20072 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
20073 Modify to pass in attributes attached to the methods.
20075 (add_accessor_declaration, remove_accessor_declaration): Ditto.
20077 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
20078 to handle the Accessor kind :-)
20080 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
20082 2002-06-08 Martin Baulig <martin@gnome.org>
20084 * expression.cs (Unary.TryReduceNegative): Added support for
20087 2002-06-08 Martin Baulig <martin@gnome.org>
20089 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
20090 name can't be found in the `defined_names' - the caller will do a
20091 MemberLookup in this case and thus find methods in System.Enum
20092 such as Enum.IsDefined().
20094 2002-06-08 Martin Baulig <martin@gnome.org>
20096 * enum.cs (Enum.ChangeEnumType): This is a custom version of
20097 Convert.ChangeType() which works with TypeBuilder created types.
20098 (Enum.LookupEnumValue, Enum.Define): Use it here.
20100 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
20101 `TypeBuilder.BaseType != null' check.
20102 (TypeContainer.FindMembers): Only lookup parent members if we
20103 actually have a parent.
20104 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
20105 (ConstructorInitializer.Resolve): Likewise.
20107 * interface.cs (Interface.FindMembers): Added
20108 `TypeBuilder.BaseType != null' check.
20110 * rootcontext.cs (RootContext.ResolveCore): Added
20111 "System.Runtime.CompilerServices.IndexerNameAttribute" to
20112 classes_second_stage.
20114 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
20115 debug_type and trace_type when compiling with --nostdlib.
20117 2002-06-07 Martin Baulig <martin@gnome.org>
20119 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
20120 (AddField): Set it to true when adding a non-static field.
20121 (DefineType): Use `have_nonstatic_fields' to find out whether we
20122 have non-static fields, not `Fields != null'.
20124 2002-06-02 Miguel de Icaza <miguel@ximian.com>
20126 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
20127 dereferencing a null on the static-field code path)
20129 2002-05-30 Martin Baulig <martin@gnome.org>
20131 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
20132 to take command line arguments. Use reflection to call the new
20133 custom `Initialize' function on the symbol writer and pass it the
20134 command line arguments.
20136 * driver.cs (--debug-args): New command line argument to pass command
20137 line arguments to the symbol writer.
20139 2002-05-28 Miguel de Icaza <miguel@ximian.com>
20141 * assign.cs (DoResolve): Forgot to do the implicit conversion to
20142 the target type for indexers and properties. Thanks to Joe for
20145 2002-05-27 Miguel de Icaza <miguel@ximian.com>
20147 * typemanager.cs (MethodFlags): returns the method flags
20148 (Obsolete/ShouldIgnore) that control warning emission and whether
20149 the invocation should be made, or ignored.
20151 * expression.cs (Invocation.Emit): Remove previous hack, we should
20152 not do this on matching a base type, we should do this based on an attribute
20154 Only emit calls to System.Diagnostics.Debug and
20155 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
20156 on the command line.
20158 * rootcontext.cs: Global settings for tracing and debugging.
20160 * cs-tokenizer.cs (define): New utility function to track
20161 defines. Set the global settings for TRACE and DEBUG if found.
20163 2002-05-25 Ravi Pratap <ravi@ximian.com>
20165 * interface.cs (Populate*): Pass in the TypeContainer as well as
20166 the DeclSpace as parameters so that we can create EmitContexts and
20167 then use that to apply attributes etc.
20169 (PopulateMethod, PopulateEvent, PopulateProperty)
20170 (PopulateIndexer): Apply attributes everywhere.
20172 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
20175 (ApplyAttributes): Update accordingly.
20177 We now apply interface attributes for all members too.
20179 2002-05-26 Miguel de Icaza <miguel@ximian.com>
20181 * class.cs (Indexer.Define); Correctly check if we are explicit
20182 implementation (instead of checking the Name for a ".", we
20183 directly look up if the InterfaceType was specified).
20185 Delay the creation of the PropertyBuilder.
20187 Only create the PropertyBuilder if we are not an explicit
20188 interface implementation. This means that explicit interface
20189 implementation members do not participate in regular function
20190 lookups, and hence fixes another major ambiguity problem in
20191 overload resolution (that was the visible effect).
20193 (DefineMethod): Return whether we are doing an interface
20196 * typemanager.cs: Temporary hack until we get attributes in
20197 interfaces (Ravi is working on that) and we get IndexerName
20198 support in interfaces.
20200 * interface.cs: Register the indexers as properties.
20202 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
20203 warning, I have verified that this is a bug in the .NET runtime
20204 (JavaScript suffers of the same problem).
20206 * typemanager.cs (MemberLookup): When looking up members for
20207 interfaces, the parent of an interface is the implicit
20208 System.Object (so we succeed in searches of Object methods in an
20209 interface method invocation. Example: IEnumerable x; x.ToString
20212 2002-05-25 Miguel de Icaza <miguel@ximian.com>
20214 * class.cs (Event): Events should also register if they do
20215 implement the methods that an interface requires.
20217 * typemanager.cs (MemberLookup); use the new GetInterfaces
20220 (GetInterfaces): The code used to lookup interfaces for a type is
20221 used in more than one place, factor it here.
20223 * driver.cs: Track the errors at the bottom of the file, we kept
20226 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
20227 instance if the method we are calling is static!
20229 2002-05-24 Miguel de Icaza <miguel@ximian.com>
20231 * attribute.cs (ApplyAttributes): Make this function filter out
20232 the IndexerName attribute (as that attribute in reality is never
20233 applied) and return the string constant for the IndexerName
20236 * class.cs (TypeContainer.Emit): Validate that all the indexers
20237 have the same IndexerName attribute, and if so, set the
20238 DefaultName attribute on the class.
20240 * typemanager.cs: The return value might contain other stuff (not
20241 only methods). For instance, consider a method with an "Item"
20242 property and an Item method.
20244 * class.cs: If there is a problem with the parameter types,
20247 2002-05-24 Ravi Pratap <ravi@ximian.com>
20249 * ecore.cs (ImplicitConversionExists): Wrapper function which also
20250 looks at user defined conversion after making a call to
20251 StandardConversionExists - we need this for overload resolution.
20253 * expression.cs : Update accordingly the various method calls.
20255 This fixes 2 bugs filed against implicit user defined conversions
20257 2002-05-22 Miguel de Icaza <miguel@ximian.com>
20259 * statement.cs: Track the result of the assignment.
20261 2002-05-21 Miguel de Icaza <miguel@ximian.com>
20263 * expression.cs (MemberAccess): Improved error reporting for
20264 inaccessible members.
20266 2002-05-22 Martin Baulig <martin@gnome.org>
20268 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
20269 itself with debugging support.
20271 2002-05-22 Martin Baulig <martin@gnome.org>
20273 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
20274 Removed, this isn't needed anymore.
20276 2002-05-20 Martin Baulig <martin@gnome.org>
20278 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
20279 be underlying type for an enum.
20281 2002-05-20 Miguel de Icaza <miguel@ximian.com>
20283 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
20284 that splits out the loading of just the core types.
20286 * rootcontext.cs (ResolveCore): Split the struct resolution in
20287 two, so we can load the enumeration underlying types before any
20290 * expression.cs (Is): Bandaid until we fix properly Switch (see
20291 bug #24985 for details).
20293 * typemanager.cs (ImplementsInterface): The hashtable will contain
20294 a null if there are no interfaces implemented.
20296 2002-05-18 Miguel de Icaza <miguel@ximian.com>
20298 * cs-parser.jay (indexer_declarator): It is fine to have array
20301 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20303 * typemanager.cs: (RegisterBuilder): New function used to register
20304 TypeBuilders that implement interfaces. Since
20305 TypeBuilder.GetInterfaces (as usual) does not work with lame
20307 (AddUserType): register interfaces.
20309 (ImplementsInterface): Use the builder_to_ifaces hash if we are
20310 dealing with TypeBuilder. Also, arrays are showing up as
20311 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
20312 methods can not be invoked on them!
20314 * ecore.cs (ExplicitReferenceConversionExists): Made public.
20315 (ImplicitReferenceConversionExists): Split out from
20316 StandardConversionExists.
20318 * expression.cs (As): We were only implementing one of the three
20319 cases for the as operator. We now implement them all.
20320 (Is): Implement the various other cases for Is as well.
20322 * typemanager.cs (CACHE): New define used to control if we want or
20323 not the FindMembers cache. Seems to have a negative impact on
20324 performance currently
20326 (MemberLookup): Nested types have full acess to
20327 enclosing type members
20329 Remove code that coped with instance/static returns for events, we
20330 now catch this in RealFindMembers.
20332 (RealFindMembers): only perform static lookup if the instance
20333 lookup did not return a type or an event.
20335 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20337 * assign.cs (CompoundAssign): We pass more semantic information
20338 now to Compound Assignments than we did before: now we have all
20339 the information at hand, and now we resolve the target *before* we
20340 do the expression expansion, which allows the "CacheValue" method
20341 to have the effect we intended (before, a [x] += 1 would generate
20342 two differen ArrayAccess expressions from the ElementAccess,
20343 during the resolution process).
20345 (CompoundAssign.DoResolve): Resolve target and original_source here.
20347 2002-05-16 Miguel de Icaza <miguel@ximian.com>
20349 * expression.cs (ArrayAccess): dropped debugging information.
20351 * typemanager.cs: Small bug fix: I was always returning i_members,
20352 instead of one of i_members or s_members (depending on which had
20355 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
20356 method is invoked before any code generation takes place, and it
20357 is a mechanism to inform that the expression will be invoked more
20358 than once, and that the method should use temporary values to
20359 avoid having side effects
20361 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
20363 * ecore.cs (Expression.CacheTemporaries): Provide empty default
20366 * expression.cs (Indirection, ArrayAccess): Add support for
20367 CacheTemporaries in these two bad boys.
20369 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
20370 ldobj or ldind_ref.
20371 (StoreFromPtr): Handle stobj as well.
20373 * expression.cs (UnaryMutator): Share more code.
20375 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
20376 down: I was not tracking the Filter function as well, which
20377 was affecting the results of the cache.
20379 2002-05-15 Miguel de Icaza <miguel@ximian.com>
20381 * attribute.cs: Remove the hack to handle the CharSet property on
20384 2002-05-14 Miguel de Icaza <miguel@ximian.com>
20386 * attribute.cs (DoResolve): More uglyness, we now only try to
20387 resolve the attribute partially, to extract the CharSet
20388 information (only if we are a StructLayout attribute). Otherwise
20390 (GetExtraTypeInfo): Add some code to conditionally kill in the
20391 future this. I am more and more convinced that the .NET
20392 framework has special code to handle the attribute setting on
20395 * expression.cs (IsParamsMethodApplicable): Revert my previous
20396 foreach change here, it was wrong.
20398 2002-05-13 Miguel de Icaza <miguel@ximian.com>
20400 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
20401 (pp_expr): do not abort on unknown input, just return.
20402 (eval): abort if there are pending chars.
20404 * attribute.cs (Attribute.Resolve): Positional parameters are
20405 optional. Deal with that case.
20407 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
20408 the Ansi/Unicode/Auto information for the type.
20410 (TypeContainer.DefineType): instantiate the EmitContext here, as
20411 we will be using it during the type definition (to resolve
20412 attributes) and during the emit phase.
20414 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
20415 to pull type information out of the attributes
20417 (Attribute.Resolve): track the constructor builder, and allow for
20418 multiple invocations (structs and classes will use this).
20420 * ecore.cs (MemberLookupFinal): new version with all the
20421 parameters customizable.
20423 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
20424 constructors. Return if the result value is null (as the error
20425 would have been flagged already by MemberLookupFinal)
20427 Do not allow instances of abstract classes or interfaces to be
20430 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
20431 We have to compare the assembly property here when dealing with
20432 FamANDAssem and Assembly access modifiers, because we might be
20433 creating an assembly from *modules* (that means that we are not
20434 getting TypeBuilders for types defined in other modules that are
20435 part of this assembly).
20437 (Method.Emit): If the method is marked abstract and has a body,
20440 (TypeContainer.DefineMembers): If both the defined member and the
20441 parent name match are methods, then do not emit any warnings: let
20442 the Method.Define routine take care of flagging warnings. But if
20443 there is a mismatch (method overrides something else, or method is
20444 overriwritten by something, then emit warning).
20446 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
20447 set to null, this means `do not check for the return type on the
20450 (Method.Define): set the return type for the method signature to
20451 null, so that we get methods with the same name and parameters and
20452 different return types. This is used to flag warning 114 (you are
20453 hiding a method, and you probably want to use the new/override
20456 * typemanager.cs (MemberLookup): Implemented proper access
20457 control, closing a long standing set of bug reports. The problem
20458 was that the Framework only has two bits: Public and NonPublic,
20459 and NonPublic includes private and protected methods, but we need
20460 to enforce the FamANDAssem, FamOrAssem and Family.
20462 2002-05-11 Miguel de Icaza <miguel@ximian.com>
20464 * statement.cs (GotoCase): Return true: Ammounts to giving up
20465 knowledge on whether we return or not, and letting the other case
20466 be responsible for it.
20468 2002-05-10 Miguel de Icaza <miguel@ximian.com>
20470 * driver.cs: Do not load directories for each file processed, only
20471 do it if there is a pattern.
20473 * ecore.cs: Report readonly assigns here as well, as we might have
20474 been resolved only by MemberAccess.
20476 (SimpleName.SimpleNameResolve): Also be useful for LValue
20477 resolution. We need this to propagate assign to local readonly variables
20479 * typemanager.cs: Use a ptrhashtable for the criteria, because we
20480 do not want to reuse potential criteria memory.
20482 * class.cs (MyEventBuilder): Set reflected_type;
20484 * ecore.cs (Constantify): Added support for constifying bools.
20486 (RootContext.LookupType): Added a cache for values looked up in
20487 the declaration space.
20489 * typemanager.cs (FindMembers): Now is a front-end to
20490 RealFindMembers, and provides a two-level hashtable-based cache to
20493 15% performance improvement: from 22.5 to 19.2 seconds.
20495 * expression.cs (IsParamsMethodApplicable): use foreach.
20496 (Invocation.DoResolve): ditto.
20497 (New.DoResolve): ditto.
20498 (ArrayCreation.DoResolve): ditto.
20500 * ecore.cs (FindMostEncompassingType): use foreach.
20502 * delegate.cs (NewDelegate.DoResolve): Use foreach
20504 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
20505 (RemoveMethods): use foreach.
20507 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
20508 nested foreach statements instead of for, and also break out of
20509 the inner loop once a match is found.
20511 (Invocation.OverloadResolve): Use foreach, simplify the code.
20513 2002-05-08 Miguel de Icaza <miguel@ximian.com>
20515 * cfold.cs (BinaryFold): During an enumeration evaluation context,
20516 we actually unwrap the expression to allow for extra information
20519 * expression.cs: Use Shr_Un on unsigned operations.
20521 2002-05-08 Ravi Pratap <ravi@ximian.com>
20523 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
20524 applicable operators was not being considered correctly. This closes
20525 the bug Miguel reported.
20527 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
20529 * attribute.cs: check that the type derives from System.Attribute
20530 and report the correct error in that case (moved the duplicate code to
20531 its own method, too).
20533 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
20535 * attribute.cs: lookup attribute type name as the spec says: first the
20536 bare attribute name and then name + "Attribute" (nant compiles with
20537 mcs after this fix).
20539 2002-05-07 Miguel de Icaza <miguel@ximian.com>
20541 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
20542 Because of the way we parse things, we should try to see if a
20543 UIntConstant can fit in an integer.
20545 2002-05-07 Ravi Pratap <ravi@ximian.com>
20547 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
20548 when we are in an explicit context.
20550 (ConvertReferenceExplicit): When converting from Iface type S to Class
20551 T make sure the rules are implemented as an OR.
20553 * parameter.cs (ParameterType): Make it a property for now although the
20554 purpose really isn't anything immediate.
20556 * expression.cs (Is*Applicable): Do better checking on the parameter type
20557 of a ref/out parameter. The ones from the system assemblies are already
20558 marked with the correct type so we don't need to do any correction.
20560 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20561 the object type is standard too so include that.
20563 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20565 * ecore.cs (StandardConversionExists): Augment with missing code:
20566 deal with IntConstant, LongConstants and Enumerations.
20568 * assign.cs: Report the error, instead of failing silently
20570 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20571 typecontainer that they are declared, because the
20572 typecontainer/namespace will have the list of using clauses that
20573 need to be applied.
20575 Assembly Attributes were escaping the normal registration
20578 (EmitCode): Apply attributes within an EmitContext that represents
20579 the container they were declared on.
20581 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20583 2002-05-06 Ravi Pratap <ravi@ximian.com>
20585 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20586 Revamp completely - make much cleaner as we now operate only
20589 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20590 to implement the logic detailed in the spec more correctly.
20592 (UserDefinedConversion): Update accordingly.
20594 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20596 * statement.cs: Return flow analysis information up.
20598 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20601 (token): Do not consume an extra character before calling
20604 2002-05-06 Piers Haken <piersh@friskit.com>
20606 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20608 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20610 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20611 EmitContext during the instance constructor initializer
20612 resolution, to stop access to instance variables.
20614 This is mandated by the spec, last paragraph of the `constructor
20615 initializers' section.
20617 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20619 * cs-parser.jay, class.cs (Accessor): new class used to represent
20620 an accessor (get or set). In the past we used `null' to represent
20621 a missing accessor. But this is ambiguous because there was no
20622 way to tell in abstract indexers/properties if one of them was
20625 Now there is a way of addressing that.
20627 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20628 instead of FindMembers.
20630 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20631 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20633 * attribute.cs: Treat indexers and properties as the same in terms
20634 of applying attributes
20636 * ecore.cs (FindMostEncompassedType): Use statically initialized
20637 EmptyExpressions()s like we do elsewhere to avoid creating useless
20638 objects (and we take this out of the tight loop).
20640 (GetConversionOperators): Move the code to extract the actual
20641 operators to a separate routine to clean things up.
20643 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20645 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20646 events are always registered FieldBuilders.
20648 * class.cs (FieldBase): New class shared by Fields
20650 * delegate.cs: If we are a toplevel delegate, use our full name.
20651 If we are a nested delegate, then only use our tail name.
20653 2002-05-02 Ravi Pratap <ravi@ximian.com>
20655 * expression.cs (IsApplicable): Ensure that we add the "&" to
20656 ref/out types before comparing it with the type of the argument.
20658 (IsParamsMethodApplicable): Ditto.
20660 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20663 * delegate.cs : Handle the case when we have more than one applicable
20664 method. Flag an error only when we finish checking all.
20666 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20668 * expression.cs: Add support for boolean static initializers.
20670 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20672 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20674 * parameter.cs (ComputeParameterTypes,
20675 ComputeAndDefineParameterTypes): Better error handling: now we
20676 clear the `types' cache if we fail during any of the type lookups.
20677 We also return the status code correctly to our caller
20679 * delegate.cs: If we fail to define a delegate, abort the extra
20682 * expression.cs (Binary.ResolveOperator): for
20683 operator==(object,object) and operator !=(object, object) we also
20684 have to verify that there is an implicit conversion from one to
20687 (ArrayAccess.DoResolve): Array Access can operate on
20690 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20692 * assign.cs (CompoundAssign): A new class used as a "flag" that
20693 the assignment actually is happening as part of a compound
20694 assignment operator.
20696 During compound assignment, a few new rules exist to enable things
20703 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20704 to the type of x) if y is implicitly convertible to the type of x,
20705 and the operator is a builtin operator and the return type of the
20706 operator is explicitly convertible to the type of x.
20708 * rootcontext.cs: Reset warning level to 2. 4 catches various
20709 "interesting" features in mcs, we must clean this up at some
20710 point, but currently am trying to kill other bugs ;-)
20712 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20713 in container classes as well.
20715 * expression.cs (Binary.ResolveOperator): Handle string case
20716 before anything else (as operator overloading does emit an error
20717 before doing anything else).
20719 This code could go away when we move to a table driven model, but
20720 i could not come up with a good plan last night.
20722 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20724 * typemanager.cs (CSharpName): reimplementation using regex.
20725 * class.cs: added null check for fields in Emit
20726 * rootcontext.cs: set warninglevel to 4
20728 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20730 * typemanager.cs (CSharpName): reimplemented with Lupus
20733 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20735 * statement.cs (If): correclty implement Resolve, because we were
20736 not catching sem errors in there. The same process is needed
20738 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20741 (Statement.Warning_DeadCodeFound): Factorize code.
20742 (While): Report dead code here too.
20744 (Statement): Added Resolve virtual method to allow
20745 for resolution split from the emit code.
20747 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20749 * statement.cs (EmitBoolExpression): No longer try to resolve the
20751 (MakeBoolean): New utility function that resolve, implicitly
20752 converts to boolean and tags the expression.
20755 (If, Do): Implement dead code elimination.
20756 (While): Implement loop inversion
20758 (Do, While, For, If): Resolve the expression prior to calling our
20761 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20764 - added method Report28 (warning: program has more than one entry point)
20765 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20766 - modified method Method.Define, the part at the end of the method
20768 * rootcontext.cs: added static public Location EntryPointLocation;
20770 * ../errors/cs0028.cs : Add test case for the above warning.
20773 - modified method CSharpName to allow arrays of primitive type to
20774 be printed nicely (e.g. instead of System.Int32[][] it now prints
20776 - added method CSharpSignature: returns the signature of a method
20777 in string format to be used in reporting errors, warnings, etc.
20779 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20782 2002-04-26 Ravi Pratap <ravi@ximian.com>
20784 * delegate.cs (Define): Fix extremely silly bug where I was
20785 setting the type of the 'object' parameter of the BeginInvoke
20786 method to System.IAsyncResult instead of System.Object ;-)
20788 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20790 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20793 (Constructor.Emit): return if we fail to initialize the
20794 constructor. Another door closed!
20796 * expression.cs (New.DoResolve): Improve error message (from -6 to
20797 1501). Use DeclaredOnly lookup to find the exact constructor.
20799 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20800 loop. This is useful.
20802 * cs-parser.jay: Adjust the default parameters so that destructors
20803 have the proper signature.
20805 2002-04-26 Martin Baulig <martin@gnome.org>
20807 * driver.cs (LoadAssembly): If `assembly' contains any characters
20808 which are only valid in path names and not in assembly names
20809 (currently slash, backslash and point), use Assembly.LoadFrom ()
20810 instead of Assembly.Load () on the `assembly' (before iteration
20811 over the link_paths).
20813 2002-04-26 Martin Baulig <martin@gnome.org>
20815 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20817 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20819 * class.cs (Property): use the new typemanager.MemberLookup
20821 (TypeContainer.MemberLookup): Implement using the
20822 TypeManager.MemberLookup now.
20824 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20825 and return MemberInfos, so that these can be used without an
20826 EmitContext (what we had before).
20828 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20830 * expression.cs: Fix the case where the argument to params if the
20831 type of the params. I omitted handling this before. Fixed
20833 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20835 * driver.cs: Call BootCorlib_PopulateCoreType
20837 * class.cs (Property.CheckBase): Check for properties only, not
20840 * interface.cs: Temporary hack: try/catch around the
20841 CustomAttributeBuilder, because I am getting an exception that I
20844 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20845 types whose definitions are required to be there (attributes are
20846 defined before standard types).
20848 Compute definitions as we boot the various types, as they are used
20849 immediately (value_type class will need object_type, but if we do
20850 not initialize object_type, we will pass a null, which will let
20851 the runtime pick the System.Object from the existing corlib, which
20852 is not what we want).
20854 2002-04-22 Patrik Torstensson <totte@labs2.com>
20856 * cs-tokenizer.cs: fixed a number of trim() issues.
20858 2002-04-22 Ravi Pratap <ravi@ximian.com>
20860 * expression.cs (Argument.Type): Ensure that we return the correct
20861 type when we have out or ref parameters [in which case we
20864 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20866 * class.cs (Property, Indexer): Allow extern modifier in there.
20868 * typemanager.cs (InitBaseTypes): Initializes object_type and
20869 value_type, since those will be used early on during the bootstrap
20870 process to compile corlib.
20872 (InitCoreTypes): Move code from here to InitBaseTypes.
20874 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20876 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20877 single-dimension arrays as using the ldlen opcode.
20879 Daniel Lewis discovered this optimization.
20881 * typemanager.cs: Add signature for System.Array::get_Length
20883 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20885 * statement.cs: report the error when the foreach does not apply to an
20886 array nor a collection.
20888 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20890 * expression.cs: Add implicit conversions to the operator ~.
20892 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20894 * typemanager.cs: Locate the decimal constructor.
20896 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20898 * attribute.cs: use the new property of TypeOf.
20899 * expression.cs: added 'get' property around typearg.
20901 These changes fix a build breaker reported by NickD. Is this the
20902 correct way to fix? If not, please, revert my changes and make it
20905 2002-04-17 Miguel de Icaza <miguel@ximian.com>
20907 * attribute.cs: Add support for typeof in attribute invocations.
20908 I am not sure that this is right though.
20910 2002-04-14 Duncan Mak <duncan@ximian.com>
20912 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
20913 Binary.Operator.Division case.
20915 2002-04-13 Ravi Pratap <ravi@ximian.com>
20917 * class.cs (DefineType): Ensure that we do a proper check on
20918 attribute types and also register it with the TypeManager.
20920 (TypeContainer.Targets): The default for attribute types is
20921 AttributeTargets.All.
20923 * attribute.cs (ApplyAttributes): Registering the attribute type
20924 is done elsewhere, not when we discover we have a Usage attribute.
20926 2002-04-12 Ravi Pratap <ravi@ximian.com>
20928 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
20929 and get rid of is_delegate parameter.
20931 * everywhere : update.
20933 2002-04-12 Ravi Pratap <ravi@ximian.com>
20935 * cs-parser.jay (compilation_unit): Revamp completely to use
20936 some new ideas that I got from Rhys' grammar to solve the problems
20937 with assembly level attributes.
20939 (outer_declaration): New grammar production.
20941 (attribute_sections): Add.
20943 (opt_attributes): Base on attribute_sections
20945 (namespace_declaration): Allow opt_attributes to tackle the case
20946 when we have assembly level attributes - we are clever in this
20949 * attribute.cs (ApplyAttributes): Do not worry about assembly
20950 attributes in the non-global context.
20952 * rootcontext.cs (AddGlobalAttributes): Go back to using this
20953 instead of SetGlobalAttributes.
20955 * class.cs, rootcontext.cs : Ensure we define and generate
20956 attribute types before anything else.
20958 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
20959 and flag the new error -20 for the case when the attribute type
20960 does not have valid targets specified. csc does not catch this.
20962 * ../errors/errors.txt : update for error # -20
20964 2002-04-11 Ravi Pratap <ravi@ximian.com>
20966 * support.cs (InternalParameters.ParameterModifier): Do some null
20967 checking and return sane values.
20969 * class.cs (Method.Define): If we are a PInvoke method, ensure
20970 that we are static and extern. Report error # 601
20972 * ../errors/cs0601.cs : Add test case for the above error.
20974 2002-04-07 Ravi Pratap <ravi@ximian.com>
20976 * rootcontext.cs (attribute_types): We need to keep type of
20977 all attribute types separately and emit code for them first.
20979 (RegisterAttribute) : Implement.
20981 * class.cs (DefineType): Check if the current Type is a custom
20982 attribute type and register it accordingly.
20984 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
20985 adding the first attribute twice and rename to
20987 (SetGlobalAttributes): this.
20989 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
20992 * attribute.cs (ApplyAttributes): Take an additional argument telling us
20993 if we are processing global arguments. Hmm, I am unsure of this.
20995 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20997 * expression.cs: added static array of strings to avoid calling
20998 Enum.ToString () for Operator in Binary. Significant recover of
21001 2002-04-10 Miguel de Icaza <miguel@ximian.com>
21003 * class.cs (FindMembers): Allow the Builders of the various
21004 members to be null. If they are skip them. This only happens
21005 during the PInvoke declaration.
21007 2002-04-09 Miguel de Icaza <miguel@ximian.com>
21009 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
21010 failure, so we do not keep going afterwards.
21012 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
21013 wanted to pass `false' as the `is_delegate' argument. If this is
21014 the case, why not use delegate_type == null to mean `is_delegate =
21015 false' and anything else as is_delegate = true.
21017 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
21019 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
21020 code for the section, not the beginning of the tests.
21022 2002-04-08 Miguel de Icaza <miguel@ximian.com>
21024 * cfold.cs: Handle operator + (Enum x, Underlying x)
21026 * expression.cs (Binary): same. Warn about errors where we have
21027 Enum/Enum in operator + as well.
21029 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
21032 - added support for switch(bool)
21033 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
21034 - add TableSwitchEmit() to handle table-based switch statements
21036 2002-04-05 Ravi Pratap <ravi@ximian.com>
21038 * expression.cs (Invocation.OverloadResolve): Factor out code which
21039 does parameter compatibility checking with arguments so that we can
21040 re-use the code even from Delegate.VerifyApplicability
21042 (VerifyArgumentsCompat): Move above code here.
21044 * delegate.cs (VerifyApplicability): Get rid of duplicate code
21045 and instead make a call to the above method.
21047 2002-03-31 Ravi Pratap <ravi@ximian.com>
21049 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
21050 We use it to keep track of classes which are attribute types.
21052 2002-04-02 Miguel de Icaza <miguel@ximian.com>
21054 * delegate.cs (Delegate.Define): Correctly define the types in the
21055 presence of fixed and array parameters.
21057 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
21060 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
21061 include NonPublic after the first iteration.
21063 * class.cs (Indexer.CheckBase): Only check if both parents are
21066 * cs-parser.jay (accessor_body): If empty, set to null.
21068 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
21069 same code path here to resolve constants names that we did have in
21070 MemberAccess.DoResolve. There is too much code duplicated here.
21072 2002-04-01 Miguel de Icaza <miguel@ximian.com>
21074 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
21076 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
21079 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
21080 tokens, numbers and strings.
21082 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
21085 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
21086 asyncronous parameters and the regular parameters.
21088 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
21089 specify the target directory.
21091 * expression.cs: (This.DoResolve): Simplify
21092 (As.Emit): Optimize, do not generate IsInst if the expression is
21093 always of the given type.
21095 (Is.DoResolve): Bug fix, we were reporting both always/never for
21098 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
21099 creating too many unnecessary arrays.
21101 2002-03-31 Miguel de Icaza <miguel@ximian.com>
21103 * class.cs (EmitFieldInitializer): Use Assign expression to assign
21104 fields instead of rolling our own initializer. Takes care of all
21105 implicit conversions, and drops unnecessary static checks/argument.
21107 2002-03-31 Dick Porter <dick@ximian.com>
21109 * driver.cs: use the GetDirectories() return values properly, and
21110 use "/" as path separator.
21112 2002-03-30 Miguel de Icaza <miguel@ximian.com>
21114 * expression.cs (Unary): Optimize - - expr into expr.
21115 (Binary): Optimize a + (-b) into a -b.
21117 * codegen.cs (CodeGen): Made all methods static.
21119 2002-03-29 Miguel de Icaza <miguel@ximian.com>
21123 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
21124 TypeBuilder property.
21126 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
21129 * tree.cs: Removed the various RecordXXXX, and replaced with a
21130 single RecordDecl. Removed all the accessor methods, and just
21131 left a single access point Type
21133 * enum.cs: Rename DefineEnum to DefineType.
21135 * decl.cs: New abstract method `DefineType' used to unify the
21136 Defines for Enumerations, Interfaces, TypeContainers and
21139 (FindType): Moved LookupInterfaceOrClass here. Moved the
21140 LookupBaseClasses method that used to live in class.cs and
21141 interface.cs here, and renamed to FindType.
21143 * delegate.cs: Implement DefineType. Take advantage of the
21144 refactored pattern for locating the parent builder without taking
21145 the parent_builder argument (which we know does not work if we are
21146 nested, and triggering a toplevel definition).
21148 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21150 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
21151 accessibility of a member has changed during override and report
21154 * class.cs (Method.Define, Property.Define): Only complain on
21155 overrides if the method is private, any other accessibility is
21156 fine (and since we just checked the permission is the same, we are
21159 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
21160 and elif are processed always. The other pre-processing
21161 directives are only processed if we are "taking" the path
21163 2002-03-29 Martin Baulig <martin@gnome.org>
21165 * class.cs (Method.Emit): Only emit symbolic debugging info if the
21166 current location is not Null.
21168 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
21169 a separate method so we can profile it.
21171 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
21172 `span.Seconds' are just seconds, but no minutes or hours.
21173 (MainDriver): Profile the CodeGen.SaveSymbols calls.
21175 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21177 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
21178 Remove the gratuitous set of Final:
21180 // If an interface implementation, then we can set Final.
21181 if (((flags & MethodAttributes.Abstract) == 0) &&
21182 implementing.DeclaringType.IsInterface)
21183 flags |= MethodAttributes.Final;
21185 I do not know what I was smoking when I used that.
21188 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
21189 step into fixing the name resolution issues for delegates and
21190 unifying the toplevel name resolution.
21192 2002-03-28 Martin Baulig <martin@gnome.org>
21194 * class.cs (Method.Emit): If we have a symbol writer, call its
21195 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
21196 tell it about the current method.
21198 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
21199 writer that we're going to emit the first byte of IL code for a new
21200 statement (a new source line).
21201 (EmitContext.EmitTopBlock): If we have a symbol writer, call
21202 EmitContext.Mark() before emitting any code.
21204 * location.cs (SymbolDocument): Return null when we're Null.
21206 * statement.cs (Statement): Moved the `Location loc' variable here.
21207 (Statement.EmitBoolExpression): If we have a symbol writer, call
21208 ec.Mark() before emitting any code to tell it that we're at the
21209 beginning of a new statement.
21210 (StatementExpression): Added `Location' argument to the constructor.
21211 (Block): Added public readonly variable `StartLocation' and public
21212 variable `EndLocation'. The latter is to be set using SetEndLocation().
21213 (Block): Added constructor which takes a start and end location.
21214 (Block.SetEndLocation): New method. This sets the end location.
21215 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
21216 local variables we create.
21217 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
21218 each statement and do also mark the begin and end of the block.
21220 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
21221 tell it the current lexer.Location, use Location.Null for the end of the
21223 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
21224 current block, set its end location using SetEndLocation().
21225 (statement_expression): StatementExpression constructor now takes the
21226 lexer.Location as additional argument.
21227 (for_statement, declare_local_variables): Likewise.
21228 (declare_local_variables): When creating a new implicit block, use the
21229 new Block constructor and pass it the lexer.Location.
21231 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21233 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
21234 members also on the parent interfaces recursively.
21236 2002-03-27 Miguel de Icaza <miguel@ximian.com>
21238 * report.cs: Use new formats, since Gonzalo finished the missing
21241 * expression.cs (Binary.ResolveOperator): added missing operator|
21242 operator& and operator^ for bool/bool.
21244 * cs-parser.jay: CheckDef now takes a Location argument that is
21245 used to report errors more precisly (instead of reporting the end
21246 of a definition, we try to track something which is a lot closer
21247 to the source of the problem).
21249 * cs-tokenizer.cs: Track global token use, so we can properly flag
21250 the use of #define/#undef after the first token has been seen.
21252 Also, rename the reportXXXX to Error_DescriptiveName
21254 * decl.cs (DeclSpace.IsTopLevel): Move property here from
21255 TypeContainer, so that Enum and Interface can use this too.
21257 * class.cs (TypeContainer.LookupInterfaceOrClass,
21258 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
21259 `builder' argument. Typically this was used to pass the parent
21260 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
21263 The problem is that a nested class could trigger the definition of
21264 a toplevel class, and the builder would be obviously wrong in that
21267 So we drop this argument, and we compute dynamically the
21268 TypeBuilder/ModuleBuilder (the correct information was available
21269 to us anyways from DeclSpace.Parent)
21271 * interface.cs (Interface.DefineInterface): Drop builder
21272 parameter cleanup like class.cs
21274 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
21277 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
21280 (Try.Emit): Propagate the returns value from the statement.
21282 (Return.Emit): Even if we are leavning
21284 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
21286 * modifiers.cs: Fix the computation of MethodAttributes flags.
21288 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
21290 * driver.cs: allow compilation of files that start with '/'.
21291 Add a default case when checking the argument of --target.
21293 2002-03-25 Miguel de Icaza <miguel@ximian.com>
21295 * interface.cs: Implement the same search algorithm for types in
21296 the interface code.
21298 * delegate.cs: Do not allow multiple definition.
21300 * Recovered ChangeLog that got accidentally amputated
21302 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
21304 * rootcontext.cs: Load manually enum to allow core classes to
21305 contain enumerations.
21307 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
21308 Update to new static methods in TypeManager.
21310 * typemanager.cs (GetMethod, GetConstructor): Use our
21311 implementation of FindMembers to find the members, since during
21312 corlib compilation, the types are TypeBuilders and GetMethod and
21313 GetConstructor do not work.
21315 Make all methods in TypeManager static.
21317 (InitCodeHelpers): Split the functionality from
21318 the InitCodeTypes function.
21320 * driver.cs: Call InitCodeHelpers after we have populated the
21323 * cs-parser.jay (delegate_declaration): we did not used to compute
21324 the delegate name correctly for void delegates.
21326 2002-03-24 Miguel de Icaza <miguel@ximian.com>
21328 * rootcontext.cs (RootContext): Init the interface_resolve_order
21329 and type_container_resolve_order always.
21331 (ResolveCore, BootstrapCorlib_ResolveClass,
21332 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
21333 compiler when compiling with --nostdlib
21335 * class.cs (TypeContainer.DefineType): Check that our parent is
21336 not null. This test is most important when we are bootstraping
21339 * codegen.cs: Split out the symbol writing code.
21341 2002-03-25 Martin Baulig <martin@gnome.org>
21343 * driver.cs (-g): Made -g an alias for --debug.
21345 2002-03-24 Martin Baulig <martin@gnome.org>
21347 * codegen.cs (SymbolWriter): New public variable. Returns the
21348 current symbol writer.
21349 (CodeGen): Added `bool want_debugging_support' argument to the
21350 constructor. If true, tell the ModuleBuild that we want debugging
21351 support and ask it for the ISymbolWriter.
21352 (Save): If we have a symbol writer, call it's Close() method after
21353 saving the assembly.
21355 * driver.c (--debug): New command line argument to create a
21356 debugger information file.
21358 * location.cs (SymbolDocument): New public property. Returns an
21359 ISymbolDocumentWriter object for the current source file or null
21360 if we don't have a symbol writer.
21362 2002-03-21 Miguel de Icaza <miguel@ximian.com>
21364 * driver.cs (LoadAssembly): Correctly return when all the paths
21365 have been tried and not before.
21367 * statement.cs (Switch.Emit): return the actual coverage for this
21368 statement (returns/not-returns)
21370 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
21371 switch of the statement if we are the last switch section. That
21372 kills two problems: try/catch problems (we used to emit an empty
21373 nop at the end) and switch statements where all branches would
21376 2002-03-19 Miguel de Icaza <miguel@ximian.com>
21378 * driver.cs: Add default assemblies (the equivalent to the
21379 Microsoft CSC.RSP file)
21381 * cs-tokenizer.cs: When updating `cols and setting it to zero,
21382 also update tokens_seen and set it to false.
21384 * driver.cs: Implement --recurse for Mike.
21386 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
21387 correctly splitting out the paths.
21389 2002-03-18 Miguel de Icaza <miguel@ximian.com>
21391 * interface.cs (Interface.PopulateProperty): Instead of using
21392 `parent' as the declaration space for the set parameters, use
21395 * support.cs (InternalParameters): InternalParameters constructor
21396 takes a DeclSpace instead of a TypeContainer.
21398 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
21399 types are being initialized, load the address of it before calling
21402 (New): Provide a mechanism to disable the generation of local
21403 value type temporaries when the caller will be providing us with
21404 an address to store it.
21406 (ArrayCreation.EmitDynamicInitializers): Use it.
21408 2002-03-17 Miguel de Icaza <miguel@ximian.com>
21410 * expression.cs (Invocation.EmitArguments): Only probe for array
21411 property if there is more than one argument. Sorry about that.
21413 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
21414 empty param arrays.
21416 * class.cs (Method.LabelParameters): Fix incorrect code path that
21417 prevented the `ParamArrayAttribute' from being applied to the
21420 2002-03-16 Miguel de Icaza <miguel@ximian.com>
21422 * support.cs (ReflectionParameters): Correctly compute whether the
21423 last argument is a params array. Fixes the problem with
21426 * typemanager.cs: Make the assemblies array always be non-null
21427 (empty, but non-null)
21429 * tree.cs (RecordDecl): New function that abstracts the recording
21430 of names. This reports error 101, and provides a pointer to the
21431 previous declaration. Fixes a crash in the compiler.
21433 * cs-parser.jay (constructor_declaration): Update to new grammar,
21434 and provide a constructor_body that can be empty.
21436 2002-03-15 Miguel de Icaza <miguel@ximian.com>
21438 * driver.cs: Add support for --resources.
21440 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
21441 Make all types for the various array helper methods be integer.
21443 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
21444 CheckState to ConvCast.
21446 (ConvCast): Now it takes a `checked' state argument, to avoid
21447 depending on the emit context for the conversion, and just using
21448 the resolve time setting.
21450 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
21451 instead of Invocation.EmitArguments. We do not emit the original
21452 arguments, instead we emit those which have been converted to
21453 unsigned int expressions.
21455 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
21457 * codegen.cs: ditto.
21459 * expression.cs (LocalVariableReference): Drop the use of the
21460 Store function that depended on the variable index.
21462 * statement.cs (VariableInfo): Drop the `Idx' property from this
21463 class, as this is not taking into account the indexes for
21464 temporaries tat we generate during the execution, getting the
21467 * class.cs: First emit class initializers, then call the parent
21470 * expression.cs (Binary): Fix opcode emision.
21471 (UnaryMutator.EmitCode): Support checked code generation
21473 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
21474 matches for events for both the Static and Instance scans,
21475 pointing to the same element. Fix that.
21477 2002-03-14 Miguel de Icaza <miguel@ximian.com>
21479 * rootcontext.cs (ResolveTree): Always set the
21480 interface_resolve_order, because nested interfaces will be calling
21483 * class.cs (GetInterfaceOrClass): Track the same resolution
21484 process used by TypeManager.LookupType. This fixes the nested
21485 type lookups in class declarations (separate path from
21488 (TypeContainer.DefineType): Also define nested interfaces.
21489 (TypeContainer.RegisterOrder): New public function used to
21490 register the order in which child interfaces need to be closed.
21492 Nested interfaces need to be closed after their parents have been
21495 * interface.cs (InterfaceAttr): Put all the logic for computing
21496 the interface attribute here.
21498 (DefineInterface): Register our interface order with the
21499 RootContext or with the TypeContainer depending on the case.
21501 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21503 * cs-parser.jay: rework foreach statement to work with the new
21504 changes to the policy on SimpleNames.
21506 * report.cs: support Stacktrace on warnings as well.
21508 * makefile: drop --unsafe and /unsafe from the compile.
21510 2002-03-13 Ravi Pratap <ravi@ximian.com>
21512 * ecore.cs (StandardConversionExists): Modify to take an Expression
21513 as the first parameter. Ensure we do null -> reference type conversion
21516 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
21517 temporary Expression objects.
21519 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
21521 * interface.cs: workaround bug in method overloading resolution
21522 (there is already a bugzilla bug for it).
21524 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21526 We could also solve this problem by having a separate path for
21527 performing type lookups, instead of DoResolve, we could have a
21528 ResolveType entry point, and only participating pieces of the
21529 production (simplename, deref, array) would implement this.
21531 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
21532 signal SimpleName to only resolve type names and not attempt to
21533 resolve anything else.
21535 * expression.cs (Cast): Set the flag.
21537 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
21539 * class.cs: Only report 108 if there is no `new' modifier.
21541 * cs-parser.jay: rework foreach statement to work with the new
21542 changes to the policy on SimpleNames.
21544 * report.cs: support Stacktrace on warnings as well.
21546 * makefile: drop --unsafe and /unsafe from the compile.
21548 2002-03-11 Miguel de Icaza <miguel@ximian.com>
21550 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21551 lookups here, instead of doing that at parse time. This means
21552 that our grammar will not introduce `LocalVariableReferences' as
21553 expressions at this point. That solves the problem of code like
21557 static void Main ()
21561 This is only half the fix. The full fix requires parameters to
21562 also be handled in this way.
21564 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21565 makes the use more obvious of the DeclSpace. The
21566 ec.TypeContainer.TypeBuilder is now only used to pull the
21567 TypeBuilder for it.
21569 My theory is that I can get rid of the TypeBuilder completely from
21570 the EmitContext, and have typecasts where it is used (from
21571 DeclSpace to where it matters).
21573 The only pending problem is that the code that implements Aliases
21574 is on TypeContainer, and probably should go in DeclSpace.
21576 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21577 lookups here, instead of doing that at parse time. This means
21578 that our grammar will not introduce `LocalVariableReferences' as
21579 expressions at this point. That solves the problem of code like
21583 static void Main ()
21587 This is only half the fix. The full fix requires parameters to
21588 also be handled in this way.
21590 * class.cs (Property.DefineMethod): When implementing an interface
21591 method, set newslot, when implementing an abstract method, do not
21592 set the flag (before we tried never setting it, or always setting
21593 it, which is the difference).
21594 (Indexer.DefineMethod): same.
21595 (Method.DefineMethod): same.
21597 * ecore.cs: Only set the status used flag if we get back a Field.
21599 * attribute.cs: Temporary hack, so Paolo can keep working.
21601 2002-03-08 Ravi Pratap <ravi@ximian.com>
21603 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21604 the unmanaged type in the case we have a MarshalAs attribute.
21606 (Resolve): Handle the case when we are parsing the special MarshalAs
21607 attribute [we need to store the unmanaged type to use later]
21609 * typemanager.cs (marshal_as_attr_type): Built in type for the
21610 MarshalAs Attribute.
21612 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21613 on parameters and accordingly set the marshalling info.
21615 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21617 * class.cs: Optimizing slightly by removing redundant code after
21618 we switched to the `NoTypes' return value.
21619 (Property.DefineMethod): use NoTypes here too.
21621 This fixes the bug I introduced in my last batch of changes.
21623 2002-03-05 Ravi Pratap <ravi@ximian.com>
21625 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21627 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21628 Enums since those are types too.
21630 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21632 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21633 thanks to a call during the lookup process.
21635 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21637 * statement.cs (Foreach): Lots of work to accomodate a particular
21638 kind of foreach statement that I had not kept in mind. It is
21639 possible to have foreachs on classes that provide a GetEnumerator
21640 method that return objects that implement the "pattern" for using
21641 a foreach, there is no need to support GetEnumerator
21644 This is needed to compile nant.
21646 * decl.cs: Only report 114 if the member is not `Finalize' and if
21647 the warning level is at least 2.
21649 * class.cs: Moved the compare function from Method to
21652 (MethodSignature.InheritableMemberSignatureCompare): Add new
21653 filter function that is used to extract inheritable methods from a
21656 (Method.Define): Use the new `inheritable_method_signature_filter'
21659 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21662 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21664 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21666 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21668 * expression.cs: Pass location information to
21669 ConvertImplicitStandard.
21671 * class.cs: Added debugging code to track return values from
21674 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21676 * expression.cs (Is.DoResolve): If either side of the `is' is an
21677 interface, do not flag the warning.
21679 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21682 * report.cs: Allow for --fatal to be used with --probe.
21684 * typemanager.cs (NoTypes): Move the definition for the empty Type
21687 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21689 (TypeContainer.DefineProxy): New function used to proxy to parent
21690 implementations when implementing interfaces.
21691 (TypeContainer.ParentImplements): used to lookup if our parent
21692 implements a public function that is required by an interface.
21693 (TypeContainer.VerifyPendingMethods): Hook this up.
21695 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21696 `modules' and `assemblies' arraylists into arrays. We only grow
21697 these are the very early start up of the program, so this improves
21698 the speedof LookupType (nicely measured).
21700 * expression.cs (MakeByteBlob): Replaced unsafe code with
21701 BitConverter, as suggested by Paolo.
21703 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21704 folding of string concatenation, but if either side is a string,
21705 and the other is not, then return null, and let the runtime use
21706 the concatenation on the string plus the object (using
21707 `Object.ToString').
21709 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21711 Constant Folding has been implemented now.
21713 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21714 the error instead on types that are not supported in one's
21717 * constant.cs (Constant and all children): New set of functions to
21718 perform implict and explicit conversions.
21720 * ecore.cs (EnumConstant): Implement the new functions to perform
21721 conversion by proxying to the child expression.
21723 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21724 own separate setting that can not be turned off from the command
21725 line using --unchecked or --checked and is only controlled using
21726 the checked/unchecked statements and expressions. This setting is
21727 used by the constant folder to flag errors.
21729 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21730 ConstantCheckState as well.
21732 During Resolve, they also have to flag the state, because the
21733 constant folder runs completely in the Resolve phase.
21735 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21738 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21740 * cfold.cs: New file, this file contains the constant folder.
21742 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21743 argument to track whether we are using the resulting address to
21744 load or store a value and provide better error messages.
21746 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21747 new AddressOf arguments.
21749 * statement.cs (Foreach.EmitCollectionForeach): Update
21751 * expression.cs (Argument.Emit): Call AddressOf with proper
21752 arguments to track usage.
21754 (New.DoEmit): Call AddressOf with new arguments.
21756 (Unary.Emit): Adjust AddressOf call.
21758 2002-03-01 Ravi Pratap <ravi@ximian.com>
21760 * cs-parser.jay (member_access): Change the case for pre-defined types
21761 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21764 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21767 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21768 essentially like methods and apply attributes like MethodImplOptions to them too.
21770 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21773 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21774 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21777 * Update code everywhere accordingly.
21779 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21781 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21783 2002-02-28 Ravi Pratap <ravi@ximian.com>
21785 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21786 try performing lookups against those instead of jumping straight into using
21787 the 'using' clauses.
21789 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21791 (LookupType): Perform lookups in implicit parents too.
21793 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21794 sequence as RootContext.LookupType.
21796 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21797 the various cases of namespace lookups into this method.
21799 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21801 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21802 in positional arguments)
21804 * class.cs (Operator): Update the AllowedModifiers to contain
21807 * cs-parser.jay: Update operator declaration to allow for the
21808 operator body to be empty.
21810 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21813 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21815 * class.cs (Method.Emit): Label parameters.
21817 * driver.cs: Return 1 or 0 as the program exit code.
21819 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21821 * expression.cs: Special case the `null' object when trying to
21822 auto-compute the type, as anything can be explicitly converted to
21825 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21826 spotting this Paolo.
21828 (Expression.ImplicitNumericConversion): Perform comparissions of
21829 the type using the underlying type in the case of an enumeration
21830 rather than using the enumeration type for the compare.
21832 Cope with the underlying == type case, which is not possible to
21835 (Expression.ConvertNumericExplicit): Perform comparissions of
21836 the type using the underlying type in the case of an enumeration
21837 rather than using the enumeration type for the compare.
21839 * driver.cs: If the user does not supply an extension, assume .exe
21841 * cs-parser.jay (if_statement): Rewrote so that we can track the
21842 location for the if statement.
21844 * expression.cs (Binary.ConstantFold): Only concat strings when
21845 the operation is "+", not everything ;-)
21847 * statement.cs (Statement.EmitBoolExpression): Take a location
21849 (If, While, Do): Track location.
21851 * expression.cs (Binary.ResolveOperator): In the object + string
21852 case, I was missing a call to ConvertImplicit
21854 2002-02-25 Ravi Pratap <ravi@ximian.com>
21856 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21857 Location arguments. Ensure we use RootContext.LookupType to do our work
21858 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21860 * interface.cs (PopulateMethod): Handle the type of the parameter being
21863 * expression.cs (Invocation.BetterFunction): Handle the case when we
21864 have a params method with no fixed arguments and a call is made with no
21867 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21869 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21870 the verbatim-string-literal
21872 * support.cs (InternalParameters.ParameterModifier): handle null
21874 (InternalParameters.ParameterType): ditto.
21876 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21877 duplicating the name of the variable parameter.
21878 (GetParameterByName): Fix bug where we were not looking up array
21879 paramters if they were the only present (thanks Paolo!).
21880 (GetParameterInfo): We only have an empty set of types if both
21881 fixed and array are set to null.
21882 (GetParameterInfo-idx): Handle FixedParameter == null
21884 * cs-parser.jay: Handle the case where there is no catch
21885 statements (missing null test).
21887 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21889 * driver.cs (MainDriver): Be conservative on our command line
21892 Catch DirectoryNotFoundException when calling GetFiles.
21894 (SplitPathAndPattern): Used to split the input specification into
21895 a path and a pattern that we can feed to Directory.GetFiles.
21897 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21899 * statement.cs (Fixed): Implement the last case of the Fixed
21900 statement (string handling).
21902 * expression.cs (StringPtr): New class used to return a char * to
21903 a string; Used by the Fixed statement.
21905 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
21907 * expression.cs (Binary.ResolveOperator): Remove redundant
21908 MemberLookup pn parent type.
21909 Optimize union call, we do not need a union if the types are the same.
21910 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
21913 Specialize the use of MemberLookup everywhere, instead of using
21914 the default settings.
21916 (StackAlloc): Implement stackalloc keyword.
21918 * cs-parser.jay: Add rule to parse stackalloc.
21920 * driver.cs: Handle /h, /help, /?
21922 * expression.cs (MakeByteBlob): Removed the hacks we had in place
21923 before we supported unsafe code.
21925 * makefile: add --unsafe to the self compilation of mcs.
21927 2002-02-20 Miguel de Icaza <miguel@ximian.com>
21929 * expression.cs (PointerArithmetic): New class that is used to
21930 perform pointer arithmetic.
21931 (Binary.Resolve): Handle pointer arithmetic
21932 Handle pointer comparission.
21933 (ArrayPtr): Utility expression class that is used to take the
21934 address of an array.
21936 (ElementAccess): Implement array access for pointers
21938 * statement.cs (Fixed): Implement fixed statement for arrays, we
21939 are missing one more case before we are done.
21941 * expression.cs (Indirection): Implement EmitAssign and set the
21942 ExprClass to Variable. This allows pointer dereferences to be
21943 treated as variables, and to have values assigned to them.
21945 * ecore.cs (Expression.StoreFromPtr): New utility function to
21946 store values dereferencing.
21948 2002-02-20 Ravi Pratap <ravi@ximian.com>
21950 * expression.cs (Binary.ResolveOperator): Ensure that we are
21951 not trying to operate on a void type - this fixes the reported
21954 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
21955 the parent implementation is sealed.
21957 * ../errors/cs0239.cs : Add.
21959 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
21961 * typemanager.cs (unverifiable_code_type): Corresponds to
21962 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
21963 which have unsafe code in them.
21965 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
21968 2002-02-19 Miguel de Icaza <miguel@ximian.com>
21970 * cs-tokenizer.cs: Add support for @"litreal strings"
21972 Make tokenizer accept pre-processor directives
21973 on any column (remove the old C-like limitation).
21975 * rootcontext.cs (EmitCode): Emit any global attributes.
21976 (AddGlobalAttributes): Used to keep track of assembly attributes.
21978 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
21980 * cs-parser.jay: Add support for global attributes.
21982 2002-02-17 Miguel de Icaza <miguel@ximian.com>
21984 * expression.cs (Indirection): New helper class. Unary will
21985 create Indirection classes to be able to implement the
21986 IMemoryLocation interface on it.
21988 2002-02-16 Miguel de Icaza <miguel@ximian.com>
21990 * cs-parser.jay (fixed_statement): reference the right statement.
21992 * statement.cs (Fixed.Emit): Finish implementing the fixed
21993 statement for the &x case.
21995 2002-02-14 Miguel de Icaza <miguel@ximian.com>
21997 * class.cs (Property.Define, Method.Define): Remove newslot when
22000 * modifiers.cs: My use of NewSlot when `Abstract' was set was
22001 wrong. NewSlot should only be used if the `new' keyword is present.
22003 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
22004 locating our system dir. Sorry about this.
22006 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22008 * driver.cs (GetSystemDir): Compute correctly the location of our
22009 system assemblies. I was using the compiler directory instead of
22010 the library directory.
22012 2002-02-13 Ravi Pratap <ravi@ximian.com>
22014 * expression.cs (BetterFunction): Put back in what Miguel commented out
22015 since it is the correct fix. The problem is elsewhere ;-)
22017 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
22018 parameters of the parms method are themselves compatible or not !
22020 (StandardConversionExists): Fix very dangerous bug where we were forgetting
22021 to check that a class implements an interface before saying that an implicit
22022 conversion was allowed. Use ImplementsInterface to do the checking.
22024 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22026 * class.cs (Method.Define): Track whether we are an explicit
22027 implementation or not. And only call DefineMethodOverride if we
22028 are an explicit implementation.
22030 (Property.DefineMethod): Ditto.
22032 2002-02-11 Ravi Pratap <ravi@ximian.com>
22034 * expression.cs (BetterFunction): Catch hideous bug which was
22035 preventing us from detecting ambiguous calls due to implicit casts i.e
22038 2002-01-29 Miguel de Icaza <miguel@ximian.com>
22040 * support.cs (Pair): Remove un-needed method. I figured why I was
22041 getting the error in cs-parser.jay, the variable in a foreach loop
22042 is readonly, and the compiler does not really treat this as a variable.
22044 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
22045 instead of EQUALS in grammar.
22047 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
22049 * expression.cs (Unary.DoResolve): Check whether the argument is
22052 2002-01-28 Miguel de Icaza <miguel@ximian.com>
22054 * support.cs: Api for Pair to set a value. Despite the fact that
22055 the variables are public the MS C# compiler refuses to compile
22056 code that accesses the field if the variable is part of a foreach
22059 * statement.cs (Fixed): Begin implementation of the fixed
22062 (Block.AddVariable): Return the VariableInfo on success and null
22063 on failure instead of true/false.
22065 * cs-parser.jay (foreach): Catch errors on variables already
22066 defined (we were ignoring this value before) and properly unwind
22067 the block hierarchy
22069 (fixed_statement): grammar for the fixed statement.
22071 2002-01-25 Miguel de Icaza <miguel@ximian.com>
22073 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
22074 pointer types to be incretemented.
22076 (SizeOf): Implement.
22078 * cs-parser.jay (pointer_member_access): Implement
22079 expr->IDENTIFIER production.
22081 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
22082 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
22085 (Unary): Implement indirection.
22087 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
22088 use in non-unsafe context).
22090 (SimpleName.DoResolve): Check for pointers in field access on safe
22093 (Expression.LoadFromPtr): Factor the load-indirect code in this
22094 function. This was duplicated in UnboxCast and ParameterReference
22096 2002-01-24 Miguel de Icaza <miguel@ximian.com>
22098 * expression.cs (ComposedCast): report an error if a pointer cast
22099 is used in a safe region.
22101 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
22102 pointer type casts in unsafe context.
22104 * codegen.cs (EmitContext): Set up IsUnsafe.
22106 * cs-parser.jay (non_expression_type): Add productions for pointer
22109 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
22110 code. We should not use force into static mode if the method is
22111 not virtual. Fixes bug in MIS
22113 * statement.cs (Do.Emit, While.Emit, For.Emit,
22114 Statement.EmitBoolExpression): Add support to Do and While to
22115 propagate infinite loop as `I do return' semantics.
22117 Improve the For case to also test for boolean constants.
22119 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
22120 to the list of attributes we can add.
22122 Remove `EmitContext' argument.
22124 * class.cs (Method.Define): Apply parameter attributes.
22125 (Constructor.Define): Apply parameter attributes.
22126 (MethodCore.LabelParameters): Move here the core of labeling
22129 * support.cs (ReflectionParameters.ParameterModifier,
22130 InternalParameters.ParameterModifier): Use IsByRef on the type and
22131 only return the OUT bit for these parameters instead of in/out/ref
22134 This is because I miss-understood things. The ParameterInfo.IsIn
22135 and IsOut represent whether the parameter has the [In] and [Out]
22138 2002-01-22 Miguel de Icaza <miguel@ximian.com>
22140 * ecore.cs (FieldExpr.Emit): Release temporaries.
22142 * assign.cs (LocalTemporary.Release): new function.
22144 * codegen.cs (EmitContext.GetTemporaryStorage,
22145 EmitContext.FreeTemporaryStorage): Rework the way we deal with
22146 temporary storage. Now we can "put back" localbuilders when we
22149 2002-01-21 Miguel de Icaza <miguel@ximian.com>
22151 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
22152 need to make a copy of the variable to generate verifiable code.
22154 2002-01-19 Miguel de Icaza <miguel@ximian.com>
22156 * driver.cs: Compute dynamically the system directory.
22158 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
22159 Slower, but more generally useful. Used by the abstract
22160 registering implementation.
22162 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
22163 the rules for the special rule on Type/instances. First check if
22164 we have the same name, and if so, try that special static path
22165 rather than the instance path.
22167 2002-01-18 Miguel de Icaza <miguel@ximian.com>
22169 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
22172 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
22173 Enum, ValueType, Delegate or Array for non-corlib compiles.
22175 * cs-tokenizer.cs: Catch long identifiers (645)
22177 * typemanager.cs (IndexerPropetyName): Ravi never tested this
22180 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
22181 fix, we were returning too early, so we were not registering
22182 pending methods from abstract classes.
22184 Do not register pending methods if the class is abstract.
22186 * expression.cs (Conditional.DoResolve): Report circular implicit
22187 conversions when we neecd to compute it for conditional
22190 (Is.DoResolve): If the expression is always of the provided type,
22191 flag warning 183. If the expression can not ever be of the
22192 provided type flag warning 184.
22194 * class.cs: Catch 169 as well.
22196 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
22199 2002-01-18 Nick Drochak <ndrochak@gol.com>
22201 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
22203 2002-01-17 Miguel de Icaza <miguel@ximian.com>
22205 * interface.cs: (PopulateMethod): Check for pointers being defined
22206 only if the unsafe context is active.
22207 (PopulateProperty): ditto.
22208 (PopulateIndexer): ditto.
22210 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
22211 specified. If pointers are present, make sure that they are
22212 present in an unsafe context.
22213 (Constructor, Constructor.Define): ditto.
22214 (Field, Field.Define): ditto.
22215 (Property, Property.Define): ditto.
22216 (Event, Event.Define): ditto.
22218 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
22219 hashtable if there are classes or structs defined.
22221 * expression.cs (LocalVariableReference.DoResolve): Simplify this
22222 code, as the constant resolution moved.
22224 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
22225 the metadata, so we can flag error 133.
22227 * decl.cs (MemberCore.UnsafeOK): New function to test that a
22228 pointer is being declared in an unsafe context.
22230 2002-01-16 Miguel de Icaza <miguel@ximian.com>
22232 * modifiers.cs (Modifiers.Check): Require a Location argument.
22233 Report error 227 for Unsafe use.
22235 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
22237 * statement.cs (For.Emit): If the test is null, then report that
22238 we do `return', as we wont reach anything afterwards.
22240 (Switch.SwitchGoverningType): Track the expression that matched
22243 * driver.cs: Allow negative numbers as an error code to flag.
22245 * cs-parser.jay: Handle 1551.
22247 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
22249 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22251 * cs-parser.jay: Report 1518 (type declaration can only contain
22252 class, struct, interface, enum or delegate)
22254 (switch_label): Report 1523 (keywords `case' or `default' must
22257 (opt_switch_sections): Report 1522 (empty switch)
22259 * driver.cs: Report 1515 (response file specified multiple times)
22260 Report 1516 (Source file specified multiple times).
22262 * expression.cs (Argument.Resolve): Signal 1510
22264 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
22265 access not allowed in static code)
22267 2002-01-11 Ravi Pratap <ravi@ximian.com>
22269 * typemanager.cs (IsPointerType): Utility method which we are going
22272 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
22273 the object type, so we take care of that.
22275 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
22277 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
22278 added to non-params parameters :-)
22280 * typemanager.cs (CSharpName): Include 'void' type too.
22282 (void_ptr_type): Include in the set of core types.
22284 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
22287 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
22290 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
22291 completely forgotten about it.
22293 2002-01-10 Ravi Pratap <ravi@ximian.com>
22295 * cs-parser.jay (pointer_type): Add. This begins our implementation
22296 of parsing rules for unsafe code.
22298 (unsafe_statement): Implement.
22300 (embedded_statement): Modify to include the above.
22302 * statement.cs (Unsafe): Implement new class for unsafe blocks.
22304 * codegen.cs (EmitContext.InUnsafe): Add. This determines
22305 if the current context is an unsafe one.
22307 * cs-parser.jay (local_variable_pointer_type): Since local variable types
22308 are handled differently, we need separate rules for them.
22310 (local_variable_declaration): Update to use local_variable_pointer_type
22311 to allow variable declarations of unmanaged pointer types.
22313 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
22314 in unsafe contexts.
22316 * ../errors/cs0214.cs : Add.
22318 2002-01-16 Nick Drochak <ndrochak@gol.com>
22320 * makefile: remove 'response' file when cleaning.
22322 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22324 * cs-parser.jay: Report 1524.
22326 2002-01-14 Miguel de Icaza <miguel@ximian.com>
22328 * typemanager.cs (RegisterMethod): drop checking if we have
22329 registered this from here
22331 2002-01-12 Miguel de Icaza <miguel@ximian.com>
22333 * class.cs (Method.EmitDestructor): Implement calling our base
22336 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
22337 value of InFinally.
22339 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
22340 this routine and will wrap the call in a try/catch block. Deal
22343 2002-01-11 Miguel de Icaza <miguel@ximian.com>
22345 * ecore.cs (Expression.MemberLookup): instead of taking a
22346 parameter `same_type' that was used to tell whether we could
22347 access private members we compute our containing type from the
22350 (FieldExpr): Added partial support for volatile fields. This does
22351 not work for volatile fields exposed from assemblies, as I can not
22352 figure out how to extract the modreq from it.
22354 Updated all the source files to use this.
22356 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
22357 because it is referenced by MemberLookup very often.
22359 2002-01-09 Ravi Pratap <ravi@ximian.com>
22361 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
22362 TypeBuilder.GetCustomAttributes to retrieve what we need.
22364 Get rid of redundant default_member_attr_type as this is the same as
22365 default_member_type which already exists.
22367 * interface.cs, attribute.cs : Update accordingly.
22369 2002-01-08 Miguel de Icaza <miguel@ximian.com>
22371 * typemanager.cs: Enable IndexerPropertyName again. It does not
22372 work for TYpeBuilders though. Ravi, can you please fix this?
22374 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
22376 * expression.cs (Argument.Emit): Handle the case of ref objects
22377 being passed to ref functions;
22379 (ParameterReference.EmitLoad): Loads the content of the pointer
22380 without dereferencing.
22382 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22384 * cs-tokenizer.cs: Implemented the pre-processing expressions.
22386 2002-01-08 Ravi Pratap <ravi@ximian.com>
22388 * class.cs (Indexer.DefineMethod): Incorporate the interface
22389 type in the name of the method if we are doing explicit interface
22392 * expression.cs (ConversionExists): Remove as it is completely obsolete.
22394 (BetterConversion): Fix extremely trivial bug where we were referring to
22395 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
22398 * ../errors/bug16.cs : Add although we have fixed it.
22400 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22402 * expression.cs (BaseIndexer): Begin implementation.
22404 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
22406 * cs-parser.jay (indexer_declarator): Use qualified_identifier
22407 production directly to remove a shift/reduce, and implement
22408 explicit interface implementation.
22410 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
22411 after a floating point suffix.
22413 * expression.cs (DoNumericPromotions): Improved the conversion for
22414 uint/uint. If we have a constant, we avoid doing a typecast to a
22417 * class.cs (Indexer): Implement explicit interface implementation
22420 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
22422 * class.cs: make the default instance constructor public and hidebysig.
22424 2001-01-03 Ravi Pratap <ravi@ximian.com>
22426 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
22427 so we can call it from elsewhere.
22429 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
22430 we emit it internally if the class has a defined indexer; otherwise the user
22431 emits it by decorating the class definition with the DefaultMemberAttribute.
22433 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
22434 attribute is not used on a type which defines an indexer.
22436 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
22437 character when we skip whitespace.
22439 * ../errors/cs0646.cs : Add.
22441 2002-01-03 Miguel de Icaza <miguel@ximian.com>
22443 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
22446 * makefile: Add practical target `mcs3.exe' which builds the third
22447 generation compiler.
22449 * expression.cs (New): Fix structures constructor calling.
22451 * class.cs (Property, Method, Indexer): Emit Final flag on the
22452 method if we are an interface implementation and we are not
22455 * ecore.cs (PropertyExpr): New public field `IsBase', tells
22456 whether this property is referencing a `base' method.
22458 * expression.cs (Invocation.EmitCall): take an extra argument:
22459 is_base, this is used to determine whether the `call' or
22460 `callvirt' opcode should be used.
22463 * delegate.cs: update EmitCall.
22465 * class.cs (Method.Define): Set NewSlot for the cases where we are
22466 not implementing an interface method.
22468 (Property.Define): ditto.
22470 2002-01-02 Miguel de Icaza <miguel@ximian.com>
22472 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
22473 'r'. Allows mcs to parse itself fully.
22475 2002-01-02 Ravi Pratap <ravi@ximian.com>
22477 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
22478 of the number of initializers that require the InitializeArray method.
22480 (CheckIndices): Store the Expression in all cases - not the plain value. Also
22481 update the above field where necessary.
22483 (MakeByteBlob): Update accordingly.
22485 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
22488 (EmitDynamicInitializers): Update in accordance with the new optimization.
22490 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
22491 same OpCode applies.
22493 * cs-parser.jay : Fix some glaring errors I introduced.
22495 2002-01-01 Ravi Pratap <ravi@ximian.com>
22497 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
22498 so that we can check for name clashes there too.
22500 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
22501 for interface indexers.
22503 * interfaces.cs (Define): Emit the default member attribute.
22505 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
22506 variable was being referred to while setting the value ;-)
22508 2002-01-01 Miguel de Icaza <miguel@ximian.com>
22510 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
22511 byte-by-byte information when we know the data is zero.
22513 Make the block always a multiple of 4, because
22514 DefineInitializedData has a bug.
22516 * assign.cs: Fix, we should assign from the temporary, not from
22519 * expression.cs (MakeByteBlob): Fix my incorrect code.
22521 2001-12-31 Miguel de Icaza <miguel@ximian.com>
22523 * typemanager.cs (EnumToUnderlying): This function is used to get
22524 the underlying type from an enumeration, because it does not
22527 * constant.cs: Use the I4_S form for values between -128 and 127.
22529 * statement.cs (Block.LookupLabel): Looks up a label.
22530 (Block): Drop support for labeled blocks.
22532 (LabeledStatement): New kind of statement that represents a label
22535 (Goto): Finally implement this bad boy.
22537 * cs-parser.jay: Update to reflect new mechanism to implement
22540 2001-12-30 Miguel de Icaza <miguel@ximian.com>
22542 * codegen.cs (EmitContext.This): a codegen property that keeps the
22543 a single instance of this instead of creating many different this
22546 * delegate.cs (Delegate.DoResolve): Update to use the property;
22548 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
22550 * expression.cs (BaseAccess.DoResolve): Ditto.
22552 2001-12-29 Ravi Pratap <ravi@ximian.com>
22554 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22555 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22557 (InitCoreTypes): Update accordingly.
22559 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22560 so we can quickly store the state.
22562 (ApplyAttributes): Set the correct implementation flags
22563 for InternalCall methods.
22565 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22567 * expression.cs (EmitCall): if a method is not virtual, then do
22568 not use callvirt on it.
22570 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22571 user defined stuff) requires the use of stobj, which takes an
22572 address on the stack instead of an array and an index. So emit
22573 the Ldelema operation for it.
22575 (EmitStoreOpcode): Use stobj for valuetypes.
22577 (UnaryMutator.EmitCode): Use the right 1 value depending on
22578 whether we are dealing with int64/uint64, float or doubles.
22580 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22581 constructors that I implemented last night.
22583 (Constructor.IsDefault): Fix to work properly for static
22586 * cs-parser.jay (CheckDef): report method signature errors.
22587 Update error number 103 to be 132.
22589 * decl.cs: New AdditionResult enumeration value: MethodExists.
22590 Although we do this check for methods later on in the semantic
22591 analysis, catching repeated default constructors is so easy that
22592 we catch these here.
22594 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22597 (ParameterReference.EmitAssign, Emit): handle
22600 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22601 (ArrayAccess.EmitStoreOpcode): ditto.
22603 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22605 * expression.cs (MakeByteBlob): Complete all the missing types
22606 (uint, short, ushort, byte, sbyte)
22608 * class.cs: Only init instance field initializers on instance
22611 Rename `constructors' to instance_constructors.
22613 (TypeContainer.AddConstructor): Only add constructors to the list
22614 if it is not static.
22616 Make sure that we handle default_static_constructor independently
22617 everywhere where we handle instance_constructors
22619 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22621 * class.cs: Do not lookup or create a base initializer for a
22622 static constructor.
22624 (ConstructorInitializer.Resolve): use the proper type to lookup
22627 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22629 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22632 * decl.cs: CloseType is now an virtual method, the default
22633 implementation just closes this type.
22635 2001-12-28 Ravi Pratap <ravi@ximian.com>
22637 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22638 to PreserveSig by default. Also emit HideBySig on such methods.
22640 Basically, set the defaults to standard values.
22642 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22643 argument, if candidate is better, it can't be worse than the best !
22645 (Invocation): Re-write bits to differentiate between methods being
22646 applicable in their expanded form and their normal form - for params
22649 Get rid of use_standard everywhere as only standard conversions are allowed
22650 in overload resolution.
22652 More spec conformance.
22654 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22656 * driver.cs: Add --timestamp, to see where the compiler spends
22659 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22660 `this' in static code.
22662 (SimpleName.DoResolve): Implement in terms of a helper function
22663 that allows static-references to be passed upstream to
22666 (Expression.ResolveWithSimpleName): Resolve specially simple
22667 names when called by MemberAccess to implement the special
22670 (Expression.ImplicitReferenceConversion): Handle conversions from
22671 Null to reference types before others, as Null's type is
22674 * expression.cs (Invocation.EmitCall): Handle the special case of
22675 calling methods declared on a reference type from a ValueType
22676 (Base classes System.Object and System.Enum)
22678 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22679 the left hand side is a TypeExpr, not on every enumeration.
22681 (Binary.Resolve): If types are reference types, then do a cast to
22682 object on operators != and == of both arguments.
22684 * typemanager.cs (FindMembers): Extract instance and static
22685 members if requested.
22687 * interface.cs (PopulateProperty): Use void_type instead of null
22688 as the return type for the setter method.
22690 (PopulateIndexer): ditto.
22692 2001-12-27 Ravi Pratap <ravi@ximian.com>
22694 * support.cs (ReflectionParameters): Fix minor bug where we
22695 were examining the wrong parameter for the ParamArray attribute.
22697 Cope with requests for the type of the parameter at position
22698 greater than the params parameter's. We now return the element
22699 type of the params array as that makes more sense.
22701 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22702 accordingly as we no longer have to extract the element type
22705 (Invocation.OverloadResolve): Update.
22707 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22709 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22710 against IEnumerator, test whether the return value is a descendant
22711 of the IEnumerator interface.
22713 * class.cs (Indexer.Define): Use an auxiliary method to implement
22714 the other bits of the method definition. Begin support for
22715 explicit interface implementation.
22717 (Property.DefineMethod): Use TypeManager.void_type instead of null
22718 for an empty return value.
22720 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22722 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22723 dealing with a FieldExpr which is composed of a FieldBuilder, in
22724 the code path we did extract the constant, but we should have
22725 obtained the underlying value to be able to cast it (otherwise we
22726 end up in an infinite loop, this is what Ravi was running into).
22728 (ArrayCreation.UpdateIndices): Arrays might be empty.
22730 (MemberAccess.ResolveMemberAccess): Add support for section
22731 14.5.4.1 that deals with the special case of E.I when E is a type
22732 and something else, that I can be a reference to a static member.
22734 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22735 handle a particular array type to create byte blobs, it is just
22736 something we dont generate byteblobs for.
22738 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22741 * location.cs (Push): remove the key from the hashtable that we
22742 are about to add. This happens for empty files.
22744 * driver.cs: Dispose files after we have parsed them.
22746 (tokenize): new function that only runs the tokenizer on its
22747 input, for speed testing.
22749 2001-12-26 Ravi Pratap <ravi@ximian.com>
22751 * class.cs (Event.Define): Define the private field only if there
22752 are no accessors defined.
22754 * expression.cs (ResolveMemberAccess): If there is no associated
22755 field with the event, that means we have an event defined with its
22756 own accessors and we should flag error cs0070 since transforming
22757 ourselves into a field is not valid in that case.
22759 * ecore.cs (SimpleName.DoResolve): Same as above.
22761 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22762 and charset to sane values.
22764 2001-12-25 Ravi Pratap <ravi@ximian.com>
22766 * assign.cs (DoResolve): Perform check on events only if they
22767 are being accessed outside the declaring type.
22769 * cs-parser.jay (event_declarations): Update rules to correctly
22770 set the type of the implicit parameter etc.
22772 (add_accessor, remove_accessor): Set current local parameters.
22774 * expression.cs (Binary): For delegate addition and subtraction,
22775 cast the return value from the method into the appropriate delegate
22778 2001-12-24 Ravi Pratap <ravi@ximian.com>
22780 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22781 of these as the workaround is unnecessary.
22783 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22784 delegate data - none of that is needed at all.
22786 Re-write bits to extract the instance expression and the delegate method
22789 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22792 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22793 of attaching attributes instead of duplicating code everywhere.
22795 * everywhere : Update code to do attribute emission using the above method.
22797 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22799 * expression.cs (IsParamsMethodApplicable): if there are not
22800 parameters, return immediately.
22802 * ecore.cs: The 0 literal can be implicity converted to an enum
22805 (SimpleName.DoResolve): First lookup the type, then lookup the
22808 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22809 want to get its address. If the InstanceExpression is not
22810 addressable, store the result in a temporary variable, then get
22813 * codegen.cs: Only display 219 errors on warning level or above.
22815 * expression.cs (ArrayAccess): Make it implement the
22816 IMemoryLocation interface.
22818 (Binary.DoResolve): handle the operator == (object a, object b)
22819 and operator != (object a, object b) without incurring into a
22820 BoxedCast (because 5 != o should never be performed).
22822 Handle binary enumerator operators.
22824 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22825 value type, otherwise use Ldelem_ref.
22827 Use precomputed names;
22829 (AddressOf): Implement address of
22831 * cs-parser.jay (labeled_statement): Fix recursive block
22832 addition by reworking the production.
22834 * expression.cs (New.DoEmit): New has a special case:
22836 If we are dealing with a ValueType, we have a few
22837 situations to deal with:
22839 * The target of New is a ValueType variable, that is
22840 easy, we just pass this as the variable reference
22842 * The target of New is being passed as an argument,
22843 to a boxing operation or a function that takes a
22846 In this case, we need to create a temporary variable
22847 that is the argument of New.
22850 2001-12-23 Ravi Pratap <ravi@ximian.com>
22852 * rootcontext.cs (LookupType): Check that current_type is not null before
22853 going about looking at nested types.
22855 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22856 not implement the IAssignMethod interface any more.
22858 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22859 where we tranform them into FieldExprs if they are being resolved from within
22860 the declaring type.
22862 * ecore.cs (SimpleName.DoResolve): Do the same here.
22864 * assign.cs (DoResolve, Emit): Clean up code considerably.
22866 * ../errors/bug10.cs : Add.
22868 * ../errors/cs0070.cs : Add.
22870 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22872 * assign.cs : Get rid of EventIsLocal everywhere.
22874 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22876 * ecore.cs (ConvertIntLiteral): finished the implementation.
22878 * statement.cs (SwitchLabel): Convert the value we are using as a
22879 key before looking up the table.
22881 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22883 * codegen.cs (EmitTopBlock): Require a Location argument now.
22885 * cs-parser.jay (constructor_declarator): We need to setup
22886 current_local_parameters before we parse the
22887 opt_constructor_initializer, to allow the variables to be bound
22888 to the constructor arguments.
22890 * rootcontext.cs (LookupType): First lookup nested classes in our
22891 class and our parents before we go looking outside our class.
22893 * expression.cs (ConstantFold): Extract/debox the values at the
22896 * rootcontext.cs (EmitCode): Resolve the constants first before we
22897 resolve the types. This is not really needed, but it helps debugging.
22899 * statement.cs: report location.
22901 * cs-parser.jay: pass location to throw statement.
22903 * driver.cs: Small bug fix.
22905 * report.cs: Updated format to be 4-zero filled digits.
22907 2001-12-22 Ravi Pratap <ravi@ximian.com>
22909 * expression.cs (CheckIndices): Fix minor bug where the wrong
22910 variable was being referred to ;-)
22912 (DoEmit): Do not call EmitStaticInitializers when the
22913 underlying type is System.Object.
22915 2001-12-21 Ravi Pratap <ravi@ximian.com>
22917 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
22918 and do the usual workaround for SRE.
22920 * class.cs (MyEventBuilder.EventType): New member to get at the type
22921 of the event, quickly.
22923 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
22925 * assign.cs (Assign.DoResolve): Handle the case when the target
22926 is an EventExpr and perform the necessary checks.
22928 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
22931 (SimpleName.MemberStaticCheck): Include check for EventExpr.
22933 (EventExpr): Set the type in the constructor itself since we
22934 are meant to be born fully resolved.
22936 (EventExpr.Define): Revert code I wrote earlier.
22938 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
22939 instance expression is null. The instance expression is a This in that case
22940 or a null, depending on whether it is a static method or not.
22942 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
22943 refers to more than one method.
22945 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
22946 and accordingly flag errors.
22948 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22950 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
22952 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22954 * location.cs (ToString): Provide useful rutine.
22956 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22958 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
22959 objects, return the actual integral boxed.
22961 * statement.cs (SwitchLabel): define an ILLabel for each
22964 (Switch.CheckSwitch): If the value is a Literal, extract
22965 the underlying literal.
22967 Also in the unused hashtable we had, add the SwitchLabel so we can
22968 quickly look this value up.
22970 * constant.cs: Implement a bunch of new constants. Rewrite
22971 Literal based on this. Made changes everywhere to adapt to this.
22973 * expression.cs (Expression.MakeByteBlob): Optimize routine by
22974 dereferencing array only once, and also copes with enumrations.
22976 bytes are two bytes wide, not one.
22978 (Cast): Perform constant conversions.
22980 * ecore.cs (TryImplicitIntConversion): Return literals instead of
22981 wrappers to the literals here.
22983 * expression.cs (DoNumericPromotions): long literals can converted
22984 to ulong implicity (this is taken care of elsewhere, but I was
22985 missing this spot).
22987 * ecore.cs (Expression.Literalize): Make the return type Literal,
22988 to improve type checking.
22990 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
22992 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22994 * literal.cs: Revert code from ravi that checked the bounds. The
22995 bounds are sane by the definition of the type itself.
22997 * typemanager.cs: Fix implementation of ImplementsInterface. We
22998 need to actually look up in our parent hierarchy for interfaces
23001 * const.cs: Use the underlying type for enumerations
23003 * delegate.cs: Compute the basename for the delegate creation,
23004 that should fix the delegate test case, and restore the correct
23005 Type Lookup semantics in rootcontext
23007 * rootcontext.cs: Revert Ravi's last patch. The correct way of
23008 referencing a nested type with the Reflection API is using the "+"
23011 * cs-parser.jay: Do not require EOF token at the end.
23013 2001-12-20 Ravi Pratap <ravi@ximian.com>
23015 * rootcontext.cs (LookupType): Concatenate type names with
23016 a '.' instead of a '+' The test suite passes again.
23018 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
23019 field of the enumeration.
23021 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
23022 the case when the member is an EventExpr.
23024 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
23025 static has an associated instance expression.
23027 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
23029 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
23031 * class.cs (Event.Define): Register event and perform appropriate checks
23034 We define the Add and Remove methods even if the use provides none because
23035 in that case, we provide default implementations ourselves.
23037 Define a private field of the type of the event. This is done by the CSC compiler
23038 and we should be doing it too ;-)
23040 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
23041 More methods we use in code we generate.
23043 (multicast_delegate_type, delegate_type): Two separate types since the distinction
23046 (InitCoreTypes): Update accordingly for the above.
23048 * class.cs (Event.Emit): Generate code for default accessors that we provide
23050 (EmitDefaultMethod): Do the job in the above.
23052 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
23055 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23057 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
23058 builders even if we were missing one.
23060 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
23061 pass the Basename as our class name instead of the Name. The
23062 basename will be correctly composed for us.
23064 * parameter.cs (Paramters): Now takes a Location argument.
23066 * decl.cs (DeclSpace.LookupType): Removed convenience function and
23067 make all the code call directly LookupType in RootContext and take
23068 this chance to pass the Location information everywhere.
23070 * Everywhere: pass Location information.
23072 2001-12-19 Miguel de Icaza <miguel@ximian.com>
23074 * class.cs (Constructor.Define): Updated way of detecting the
23075 length of the parameters.
23077 (TypeContainer.DefineType): Use basename as the type name for
23080 (TypeContainer.Define): Do not recursively define types here, as
23081 definition is taken care in order by the RootContext.
23083 * tree.cs: Keep track of namespaces in a per-file basis.
23085 * parameter.cs (Parameter.ComputeSignature): Update to use
23088 (Parameters.GetSignature): ditto.
23090 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
23091 instead of a TypeContainer.
23093 (Interface.SemanticAnalysis): Use `this' instead of our parent to
23094 resolve names. Because we need to be resolve in our context, not
23097 * driver.cs: Implement response files.
23099 * class.cs (TypeContainer.DefineType): If we are defined, do not
23100 redefine ourselves.
23102 (Event.Emit): Emit the code for add/remove handlers.
23103 (Event.Define): Save the MethodBuilders for add/remove.
23105 * typemanager.cs: Use pair here too.
23107 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
23108 DictionaryEntry requires the first argument to be non-null.
23110 (enum_declaration): Compute full name for registering the
23113 (delegate_declaration): Instead of using
23114 formal_parameter_list, use opt_formal_parameter_list as the list
23117 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
23118 (EventParsing): New property that controls whether `add' and
23119 `remove' are returned as tokens or identifiers (for events);
23121 2001-12-19 Ravi Pratap <ravi@ximian.com>
23123 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
23124 use MyEventBuilder only and let it wrap the real builder for us.
23126 (MyEventBuilder): Revamp constructor etc.
23128 Implement all operations that we perform on EventBuilder in precisely the same
23131 (FindMembers): Update to use the EventBuilder member.
23133 (Event.Emit): Update accordingly.
23135 2001-12-18 Ravi Pratap <ravi@ximian.com>
23137 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
23138 by calling the appropriate methods.
23140 (GetCustomAttributes): Make stubs as they cannot possibly do anything
23143 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
23145 2001-12-17 Ravi Pratap <ravi@ximian.com>
23147 * delegate.cs (Delegate.Populate): Check that the return type
23148 and various parameters types are indeed accessible.
23150 * class.cs (Constructor.Define): Same here.
23152 (Field.Define): Ditto.
23154 (Event.Define): Ditto.
23156 (Operator.Define): Check that the underlying Method defined itself
23157 correctly - so it's MethodBuilder should not be null.
23159 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
23160 expression happens to be null.
23162 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
23163 members but as of now we don't seem to be able to do anything really useful with it.
23165 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
23166 not the EventBuilder.
23168 2001-12-18 Miguel de Icaza <miguel@ximian.com>
23170 * cs-tokenizer.cs: Add support for defines.
23171 Add support for #if, #elif, #else, #endif
23173 (eval_var): evaluates a variable.
23174 (eval): stubbed for evaluating functions.
23176 * cs-parser.jay: Pass the defines information
23178 * driver.cs: Add --define command line option.
23180 * decl.cs: Move MemberCore here.
23182 Make it the base class for DeclSpace. This allows us to catch and
23183 report 108 and 109 for everything now.
23185 * class.cs (TypeContainer.Define): Extract all the members
23186 before populating and emit the warning 108 (new keyword required
23187 to override) instead of having each member implement this.
23189 (MemberCore.Define): New abstract method, we will be using this in
23190 the warning reporting engine in Populate.
23192 (Operator.Define): Adjust to new MemberCore protocol.
23194 * const.cs (Const): This does not derive from Expression, it is a
23195 temporary object we use to create fields, it is a MemberCore.
23197 * class.cs (Method.Define): Allow the entry point to be in a
23200 * driver.cs: Rewrite the argument handler to clean it up a bit.
23202 * rootcontext.cs: Made it just an auxiliary namespace feature by
23203 making everything static.
23205 * driver.cs: Adapt code to use RootContext type name instead of
23208 * delegate.cs: Remove RootContext argument.
23210 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
23213 * class.cs (Event.Define): The lookup can fail.
23215 * cs-tokenizer.cs: Begin implementation of pre-procesor.
23217 * expression.cs: Resolve the this instance before invoking the code.
23219 2001-12-17 Miguel de Icaza <miguel@ximian.com>
23221 * cs-parser.jay: Add a production in element_access that allows
23222 the thing to become a "type" reference. This way we can parse
23223 things like "(string [])" as a type.
23225 Note that this still does not handle the more complex rules of
23229 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
23231 * ecore.cs: (CopyNewMethods): new utility function used to
23232 assemble the list of methods from running FindMembers.
23234 (MemberLookup): Rework FindMembers so that
23236 2001-12-16 Miguel de Icaza <miguel@ximian.com>
23238 * class.cs (TypeContainer): Remove Delegates who fail to be
23241 * delegate.cs (Populate): Verify that we dont get null return
23242 values. TODO: Check for AsAccessible.
23244 * cs-parser.jay: Use basename to emit error 574 (destructor should
23245 have the same name as container class), not the full name.
23247 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
23248 possible representation.
23250 Also implements integer type suffixes U and L.
23252 2001-12-15 Miguel de Icaza <miguel@ximian.com>
23254 * expression.cs (ArrayCreation.DoResolve): We need to do the
23255 argument resolution *always*.
23257 * decl.cs: Make this hold the namespace. Hold the root context as
23259 (LookupType): Move here.
23261 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
23263 * location.cs (Row, Name): Fixed the code, it was always returning
23264 references to the first file.
23266 * interface.cs: Register properties defined through interfaces.
23268 * driver.cs: Add support for globbing on the command line
23270 * class.cs (Field): Make it derive from MemberCore as well.
23273 2001-12-15 Ravi Pratap <ravi@ximian.com>
23275 * class.cs (Event::Define): Check that the type of the event is a delegate
23276 type else flag error #66.
23278 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
23281 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
23282 values of EntryPoint, CharSet etc etc.
23284 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
23286 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
23287 be null and we should ignore this. I am not sure if this is really clean. Apparently,
23288 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
23289 which needs this to do its work.
23291 * ../errors/cs0066.cs : Add.
23293 2001-12-14 Miguel de Icaza <miguel@ximian.com>
23295 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
23298 * class.cs: (MethodSignature.MethodSignature): Removed hack that
23299 clears out the parameters field.
23300 (MemberSignatureCompare): Cleanup
23302 (MemberCore): New base class used to share code between MethodCore
23305 (RegisterRequiredImplementations) BindingFlags.Public requires
23306 either BindingFlags.Instace or Static. Use instance here.
23308 (Property): Refactored code to cope better with the full spec.
23310 * parameter.cs (GetParameterInfo): Return an empty array instead
23313 * class.cs (Property): Abstract or extern properties have no bodies.
23315 * parameter.cs (GetParameterInfo): return a zero-sized array.
23317 * class.cs (TypeContainer.MethodModifiersValid): Move all the
23318 method modifier validation to the typecontainer so we can reuse
23319 this on properties.
23321 (MethodCore.ParameterTypes): return an empty sized array of types.
23323 (Property.Define): Test property modifier validity.
23325 Add tests for sealed/override too.
23327 (Method.Emit): abstract or extern methods have no bodies.
23329 2001-12-14 Ravi Pratap <ravi@ximian.com>
23331 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
23334 (Method::Define, ::Emit): Modify accordingly.
23336 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
23338 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
23340 * makefile: Pass in /unsafe.
23342 2001-12-13 Miguel de Icaza <miguel@ximian.com>
23344 * class.cs (MakeKey): Kill routine.
23346 * class.cs (TypeContainer.Define): Correctly define explicit
23347 method implementations (they require the full interface name plus
23350 * typemanager.cs: Deply the PtrHashtable here and stop using the
23351 lame keys. Things work so much better.
23353 This of course broke everyone who depended on `RegisterMethod' to
23354 do the `test for existance' test. This has to be done elsewhere.
23356 * support.cs (PtrHashtable): A hashtable that avoid comparing with
23357 the object stupid Equals method (because, that like fails all over
23358 the place). We still do not use it.
23360 * class.cs (TypeContainer.SetRequiredInterface,
23361 TypeContainer.RequireMethods): Killed these two routines and moved
23362 all the functionality to RegisterRequiredImplementations.
23364 (TypeContainer.RegisterRequiredImplementations): This routine now
23365 registers all the implementations required in an array for the
23366 interfaces and abstract methods. We use an array of structures
23367 which can be computed ahead of time to reduce memory usage and we
23368 also assume that lookups are cheap as most classes will not
23369 implement too many interfaces.
23371 We also avoid creating too many MethodSignatures.
23373 (TypeContainer.IsInterfaceMethod): Update and optionally does not
23374 clear the "pending" bit if we find that there are problems with
23377 (TypeContainer.VerifyPendingMethods): Update to report errors of
23378 methods that look like implementations but are not.
23380 (TypeContainer.Define): Add support for explicit interface method
23383 2001-12-12 Miguel de Icaza <miguel@ximian.com>
23385 * typemanager.cs: Keep track of the parameters here instead of
23386 being a feature of the TypeContainer.
23388 * class.cs: Drop the registration of parameters here, as
23389 InterfaceMethods are also interface declarations.
23391 * delegate.cs: Register methods with the TypeManager not only with
23392 the TypeContainer. This code was buggy.
23394 * interface.cs: Full registation here.
23396 2001-12-11 Miguel de Icaza <miguel@ximian.com>
23398 * expression.cs: Remove reducer for binary expressions, it can not
23401 * const.cs: Put here the code that used to go into constant.cs
23403 * constant.cs: Put here the code for constants, this is a new base
23404 class for Literals.
23406 * literal.cs: Make Literal derive from Constant.
23408 2001-12-09 Miguel de Icaza <miguel@ximian.com>
23410 * statement.cs (Return.Emit): Report error 157 if the user
23411 attempts to return from a finally block.
23413 (Return.Emit): Instead of emitting a return, jump to the end of
23416 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
23417 LocalBuilder to store the result of the function. ReturnLabel is
23418 the target where we jump.
23421 2001-12-09 Radek Doulik <rodo@ximian.com>
23423 * cs-parser.jay: remember alias in current namespace
23425 * ecore.cs (SimpleName::DoResolve): use aliases for types or
23428 * class.cs (LookupAlias): lookup alias in my_namespace
23430 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
23432 (LookupAlias): lookup alias in this and if needed in parent
23435 2001-12-08 Miguel de Icaza <miguel@ximian.com>
23439 * rootcontext.cs: (ModuleBuilder) Made static, first step into
23440 making things static. I need this to avoid passing the
23441 TypeContainer when calling ParameterType.
23443 * support.cs (InternalParameters.ParameterType): Remove ugly hack
23444 that did string manipulation to compute the type and then call
23445 GetType. Use Parameter.ParameterType instead.
23447 * cs-tokenizer.cs: Consume the suffix for floating values.
23449 * expression.cs (ParameterReference): figure out whether this is a
23450 reference parameter or not. Kill an extra variable by computing
23451 the arg_idx during emission.
23453 * parameter.cs (Parameters.GetParameterInfo): New overloaded
23454 function that returns whether a parameter is an out/ref value or not.
23456 (Parameter.ParameterType): The type of the parameter (base,
23457 without ref/out applied).
23459 (Parameter.Resolve): Perform resolution here.
23460 (Parameter.ExternalType): The full type (with ref/out applied).
23462 * statement.cs (Using.Emit, Using.EmitExpression): Implement
23463 support for expressions on the using statement.
23465 2001-12-07 Miguel de Icaza <miguel@ximian.com>
23467 * statement.cs (Using.EmitLocalVariableDecls): Split the
23468 localvariable handling of the using statement.
23470 (Block.EmitMeta): Keep track of variable count across blocks. We
23471 were reusing slots on separate branches of blocks.
23473 (Try.Emit): Emit the general code block, we were not emitting it.
23475 Check the type of the declaration to be an IDisposable or
23476 something that can be implicity converted to it.
23478 Emit conversions if required.
23480 * ecore.cs (EmptyExpression): New utility class.
23481 (Expression.ImplicitConversionExists): New utility function.
23483 2001-12-06 Miguel de Icaza <miguel@ximian.com>
23485 * statement.cs (Using): Implement.
23487 * expression.cs (LocalVariableReference): Support read only variables.
23489 * statement.cs: Remove the explicit emit for the Leave opcode.
23490 (VariableInfo): Add a readonly field.
23492 2001-12-05 Miguel de Icaza <miguel@ximian.com>
23494 * ecore.cs (ConvCast): new class used to encapsulate the various
23495 explicit integer conversions that works in both checked and
23496 unchecked contexts.
23498 (Expression.ConvertNumericExplicit): Use new ConvCast class to
23499 properly generate the overflow opcodes.
23501 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23503 * statement.cs: The correct type for the EmptyExpression is the
23504 element_type, not the variable type. Ravi pointed this out.
23506 2001-12-04 Ravi Pratap <ravi@ximian.com>
23508 * class.cs (Method::Define): Handle PInvoke methods specially
23509 by using DefinePInvokeMethod instead of the usual one.
23511 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
23512 above to do the task of extracting information and defining the method.
23514 2001-12-04 Ravi Pratap <ravi@ximian.com>
23516 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
23517 of the condition for string type.
23519 (Emit): Move that here.
23521 (ArrayCreation::CheckIndices): Keep string literals in their expression
23524 (EmitDynamicInitializers): Handle strings appropriately.
23526 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23528 * codegen.cs (EmitContext): Replace multiple variables with a
23529 single pointer to the current Switch statement.
23531 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
23534 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23538 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
23541 (Foreach.Emit): Foreach on arrays was not setting
23542 up the loop variables (for break/continue).
23544 (GotoCase): Semi-implented.
23546 2001-12-03 Ravi Pratap <ravi@ximian.com>
23548 * attribute.cs (CheckAttribute): Handle system attributes by using
23549 Attribute.GetAttributes to examine information we need.
23551 (GetValidPlaces): Same here.
23553 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23555 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23557 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23559 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23561 (Method::Emit): Handle the case when we are a PInvoke method.
23563 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23565 * expression.cs: Use ResolveWithSimpleName on compound names.
23567 2001-12-02 Ravi Pratap <ravi@ximian.com>
23569 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23570 before trying to reduce it.
23572 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23574 * constant.cs (LookupConstantValue): Implement.
23576 (EmitConstant): Use the above in emitting the constant.
23578 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23579 that are user-defined by doing a LookupConstantValue on them.
23581 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23584 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23586 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23588 (BaseAccess.DoResolve): Implement.
23590 (MemberAccess.DoResolve): Split this routine into a
23591 ResolveMemberAccess routine that can be used independently
23593 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23595 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23596 As that share bits of the implementation. Is returns a boolean,
23597 while As returns the Type that is being probed.
23599 2001-12-01 Ravi Pratap <ravi@ximian.com>
23601 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23602 instead of a Literal - much easier.
23604 (EnumInTransit): Remove - utterly useless :-)
23606 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23608 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23610 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23611 chain when we have no associated expression.
23613 2001-11-30 Ravi Pratap <ravi@ximian.com>
23615 * constant.cs (Define): Use Location while reporting the errror.
23617 Also emit a warning when 'new' is used and there is no inherited
23620 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23623 (LookupEnumValue): Implement to lookup an enum member's value and define it
23626 (Populate): Re-write accordingly to use the above routine.
23628 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23630 * expression.cs (This): Fix prototype for DoResolveLValue to
23631 override the base class DoResolveLValue.
23633 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23636 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23637 (we need to load the address of the field here). This fixes
23640 (FieldExpr.DoResolveLValue): Call the DoResolve
23641 function to initialize the Instance expression.
23643 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23644 correctly the GetEnumerator operation on a value type.
23646 * cs-parser.jay: Add more simple parsing error catches.
23648 * statement.cs (Switch): Add support for string switches.
23649 Handle null specially.
23651 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23653 2001-11-28 Ravi Pratap <ravi@ximian.com>
23655 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23657 (declare_local_constant): New helper function.
23659 * statement.cs (AddConstant): Keep a separate record of constants
23661 (IsConstant): Implement to determine if a variable is a constant.
23663 (GetConstantExpression): Implement.
23665 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23667 * statement.cs (IsVariableDefined): Re-write.
23669 2001-11-27 Ravi Pratap <ravi@ximian.com>
23671 * class.cs (TypeContainer::FindMembers): Look for constants
23672 in the case when we are looking for MemberTypes.Field
23674 * expression.cs (MemberAccess::DoResolve): Check that in the
23675 case we are a FieldExpr and a Literal, we are not being accessed
23676 by an instance reference.
23678 * cs-parser.jay (local_constant_declaration): Implement.
23680 (declaration_statement): Implement for constant declarations.
23682 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23684 * statement.cs (Switch): Catch double defaults.
23686 (Switch): More work on the switch() statement
23687 implementation. It works for integral values now, need to finish
23691 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23693 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23694 integer literals into other integer literals. To be used by
23697 2001-11-24 Ravi Pratap <ravi@ximian.com>
23699 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23702 (EmitDynamicInitializers): Cope with the above since we extract data
23703 directly from ArrayData now.
23705 (ExpectInitializers): Keep track of whether initializers are mandatory
23708 (Bounds): Make it a hashtable to prevent the same dimension being
23709 recorded for every element in that dimension.
23711 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23714 Also fix bug which was causing the indices to be emitted in the reverse
23717 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23719 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23720 unfinished. They do not work, because the underlying code is
23723 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23725 * cs-parser.jay: Remove bogus fixme.
23727 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23728 on Switch statement.
23730 2001-11-23 Ravi Pratap <ravi@ximian.com>
23732 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23735 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23736 parameter. Apparently, any expression is allowed.
23738 (ValidateInitializers): Update accordingly.
23740 (CheckIndices): Fix some tricky bugs thanks to recursion.
23742 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23743 I was being completely brain-dead.
23745 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23746 and re-write acordingly.
23748 (DelegateInvocation): Re-write accordingly.
23750 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23752 (MakeByteBlob): Handle types more correctly.
23754 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23755 initialization from expressions but it is incomplete because I am a complete
23758 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23760 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23761 on If. Basically, we have to return `true' (ie, we do return to
23762 our caller) only if both branches of the if return.
23764 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23765 short-circuit operators, handle them as short circuit operators.
23767 (Cast.DoResolve): Resolve type.
23768 (Cast.Cast): Take an expression as the target type.
23770 * cs-parser.jay (cast_expression): Remove old hack that only
23771 allowed a limited set of types to be handled. Now we take a
23772 unary_expression and we resolve to a type during semantic
23775 Use the grammar productions from Rhys to handle casts (this is
23776 not complete like Rhys syntax yet, we fail to handle that corner
23777 case that C# has regarding (-x), but we will get there.
23779 2001-11-22 Ravi Pratap <ravi@ximian.com>
23781 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23782 field which is an array type.
23784 * cs-parser.jay (declare_local_variables): Support array initialization too.
23786 * typemanager.cs (MakeKey): Implement.
23788 (everywhere): Use the above appropriately.
23790 * cs-parser.jay (for_statement): Update for array initialization while
23791 declaring variables.
23793 * ecore.cs : The error message was correct, it's the variable's names that
23794 were misleading ;-) Make the code more readable.
23796 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23797 the correct type etc.
23799 (ConvertExplicit): Handle Enum types by examining the underlying type.
23801 2001-11-21 Ravi Pratap <ravi@ximian.com>
23803 * parameter.cs (GetCallingConvention): Always return
23804 CallingConventions.Standard for now.
23806 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23808 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23809 and `r' after calling DoNumericPromotions.
23811 * ecore.cs: Fix error message (the types were in the wrong order).
23813 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23814 BindingFlags.Instance as well
23816 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23817 implicit int literal conversion in an empty cast so that we
23818 propagate the right type upstream.
23820 (UnboxCast): new class used to unbox value types.
23821 (Expression.ConvertExplicit): Add explicit type conversions done
23824 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23825 the target type before applying the implicit LongLiterals to ULong
23828 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23830 * cs-parser.jay (for_statement): Reworked the way For works: now
23831 we declare manually any variables that are introduced in
23832 for_initializer to solve the problem of having out-of-band code
23833 emition (that is what got for broken).
23835 (declaration_statement): Perform the actual variable declaration
23836 that used to be done in local_variable_declaration here.
23838 (local_variable_declaration): Do not declare anything, just pass
23839 the information on a DictionaryEntry
23841 2001-11-20 Ravi Pratap <ravi@ximian.com>
23843 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23844 re-write of the logic to now make it recursive.
23846 (UpdateIndices): Re-write accordingly.
23848 Store element data in a separate ArrayData list in the above methods.
23850 (MakeByteBlob): Implement to dump the array data into a byte array.
23852 2001-11-19 Ravi Pratap <ravi@ximian.com>
23854 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23857 * constant.cs (Define): Implement.
23859 (EmitConstant): Re-write fully.
23861 Pass in location info.
23863 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23866 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23867 DictionaryEntry since we need location info too.
23869 (constant_declaration): Update accordingly.
23871 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23872 code into another method : UpdateIndices.
23874 2001-11-18 Ravi Pratap <ravi@ximian.com>
23876 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23877 some type checking etc.
23879 2001-11-17 Ravi Pratap <ravi@ximian.com>
23881 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23882 bits to provide dimension info if the user skips doing that.
23884 Update second constructor to store the rank correctly.
23886 2001-11-16 Ravi Pratap <ravi@ximian.com>
23888 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23889 and try to implement.
23891 * ../errors/cs0150.cs : Add.
23893 * ../errors/cs0178.cs : Add.
23895 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23897 * statement.cs: Implement foreach on multi-dimensional arrays.
23899 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23900 name of the params argument.
23902 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23903 initializing the array.
23905 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
23906 we can use this elsewhere.
23908 * statement.cs: Finish implementation of foreach for single
23911 * cs-parser.jay: Use an out-of-band stack to pass information
23912 around, I wonder why I need this.
23914 foreach_block: Make the new foreach_block the current_block.
23916 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
23917 function used to return a static Parameters structure. Used for
23918 empty parameters, as those are created very frequently.
23920 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
23922 2001-11-15 Ravi Pratap <ravi@ximian.com>
23924 * interface.cs : Default modifier is private, not public. The
23925 make verify test passes again.
23927 2001-11-15 Ravi Pratap <ravi@ximian.com>
23929 * support.cs (ReflectionParameters): Fix logic to determine
23930 whether the last parameter is a params one. Test 9 passes again.
23932 * delegate.cs (Populate): Register the builders we define with
23933 RegisterParameterForBuilder. Test 19 passes again.
23935 * cs-parser.jay (property_declaration): Reference $6 instead
23936 of $$ to get at the location.
23938 (indexer_declaration): Similar stuff.
23940 (attribute): Ditto.
23942 * class.cs (Property): Register parameters for the Get and Set methods
23943 if they exist. Test 23 passes again.
23945 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
23946 call to EmitArguments as we are sure there aren't any params arguments.
23947 Test 32 passes again.
23949 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
23950 IndexOutOfRangeException.
23952 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
23953 Test 33 now passes again.
23955 2001-11-15 Miguel de Icaza <miguel@ximian.com>
23957 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
23958 broke a bunch of things. Will have to come up with a better way
23959 of tracking locations.
23961 * statement.cs: Implemented foreach for single dimension arrays.
23963 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23965 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
23966 an error. This removes the lookup from the critical path.
23968 * cs-parser.jay: Removed use of temporary_loc, which is completely
23971 2001-11-14 Miguel de Icaza <miguel@ximian.com>
23973 * support.cs (ReflectionParameters.ParameterModifier): Report
23974 whether the argument is a PARAMS argument or not.
23976 * class.cs: Set the attribute `ParamArrayAttribute' on the
23977 parameter argument.
23979 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
23980 and cons_param_array_attribute (ConstructorInfo for
23981 ParamArrayAttribute).,
23983 * codegen.cs: Emit the return using the `Return' statement, that
23984 way we can report the error correctly for missing return values.
23986 * class.cs (Method.Emit): Clean up.
23988 * expression.cs (Argument.Resolve): Take another argument: the
23989 location where this argument is used. Notice that this is not
23990 part of the "Argument" class as to reduce the size of the
23991 structure (we know the approximate location anyways).
23993 Test if the argument is a variable-reference, if not, then
23994 complain with a 206.
23996 (Argument.Emit): Emit addresses of variables.
23998 (Argument.FullDesc): Simplify.
24000 (Invocation.DoResolve): Update for Argument.Resolve.
24002 (ElementAccess.DoResolve): ditto.
24004 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
24005 method should be virtual, as this method is always virtual.
24007 (NewDelegate.DoResolve): Update for Argument.Resolve.
24009 * class.cs (ConstructorInitializer.DoResolve): ditto.
24011 * attribute.cs (Attribute.Resolve): ditto.
24013 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24015 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
24017 * expression.cs (ParameterReference): Drop IStackStorage and implement
24018 IAssignMethod instead.
24020 (LocalVariableReference): ditto.
24022 * ecore.cs (FieldExpr): Drop IStackStorage and implement
24023 IAssignMethod instead.
24025 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24027 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
24028 enumerations that are used in heavily used structures derive from
24029 byte in a laughable and pathetic attempt to reduce memory usage.
24030 This is the kind of pre-optimzations that you should not do at
24031 home without adult supervision.
24033 * expression.cs (UnaryMutator): New class, used to handle ++ and
24034 -- separatedly from the other unary operators. Cleans up the
24035 code, and kills the ExpressionStatement dependency in Unary.
24037 (Unary): Removed `method' and `Arguments' from this class, making
24038 it smaller, and moving it all to SimpleCall, so I can reuse this
24039 code in other locations and avoid creating a lot of transient data
24040 strucutres when not required.
24042 * cs-parser.jay: Adjust for new changes.
24044 2001-11-11 Miguel de Icaza <miguel@ximian.com>
24046 * enum.cs (Enum.Populate): If there is a failure during
24049 * cs-parser.jay (opt_enum_base): we used to catch type errors
24050 here, but this is really incorrect. The type error should be
24051 catched during semantic analysis.
24053 2001-12-11 Ravi Pratap <ravi@ximian.com>
24055 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
24056 current_local_parameters as expected since I, in my stupidity, had forgotten
24059 * attribute.cs (GetValidPlaces): Fix stupid bug.
24061 * class.cs (Method::Emit): Perform check on applicability of attributes.
24063 (Constructor::Emit): Ditto.
24065 (Field::Emit): Ditto.
24067 (Field.Location): Store location information.
24069 (Property, Event, Indexer, Operator): Ditto.
24071 * cs-parser.jay (field_declaration): Pass in location for each field.
24073 * ../errors/cs0592.cs : Add.
24075 2001-11-12 Ravi Pratap <ravi@ximian.com>
24077 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
24079 (InitCoreTypes): Update accordingly.
24081 (RegisterAttrType, LookupAttr): Implement.
24083 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
24084 info about the same.
24086 (Resolve): Update to populate the above as necessary.
24088 (Error592): Helper.
24090 (GetValidPlaces): Helper to the above.
24092 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
24094 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
24096 2001-11-12 Ravi Pratap <ravi@ximian.com>
24098 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
24100 * ../errors/cs0617.cs : Add.
24102 2001-11-11 Ravi Pratap <ravi@ximian.com>
24104 * enum.cs (Emit): Rename to Populate to be more consistent with what
24105 we expect it to do and when exactly it is called.
24107 * class.cs, rootcontext.cs : Update accordingly.
24109 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
24110 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
24112 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
24114 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
24115 of a fieldinfo using the above, when dealing with a FieldBuilder.
24117 2001-11-10 Ravi Pratap <ravi@ximian.com>
24119 * ../errors/cs0031.cs : Add.
24121 * ../errors/cs1008.cs : Add.
24123 * ../errrors/cs0543.cs : Add.
24125 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
24128 (FindMembers): Implement.
24130 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
24131 enums and delegates too.
24133 (enum_types): Rename to builder_to_enum.
24135 (delegate_types): Rename to builder_to_delegate.
24137 * delegate.cs (FindMembers): Implement.
24139 2001-11-09 Ravi Pratap <ravi@ximian.com>
24141 * typemanager.cs (IsEnumType): Implement.
24143 * enum.cs (Emit): Re-write parts to account for the underlying type
24144 better and perform checking etc.
24146 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
24147 of the underlying type.
24149 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
24152 * enum.cs (error31): Helper to report error #31.
24154 * cs-parser.jay (enum_declaration): Store location of each member too.
24156 * enum.cs (member_to_location): New hashtable.
24158 (AddEnumMember): Update location hashtable.
24160 (Emit): Use the location of each member while reporting errors.
24162 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24164 * cs-parser.jay: A for_initializer if is a
24165 local_variable_declaration really ammount to have an implicit
24166 block with the variable declaration and no initializer for for.
24168 * statement.cs (For.Emit): Cope with null initializers.
24170 This fixes the infinite loop on for initializers.
24172 2001-11-08 Miguel de Icaza <miguel@ximian.com>
24174 * enum.cs: More cleanup.
24176 * ecore.cs: Remove dead code.
24178 * class.cs (Property.Emit): More simplification.
24179 (Event.Emit): ditto.
24181 Reworked to have less levels of indentation.
24183 2001-11-08 Ravi Pratap <ravi@ximian.com>
24185 * class.cs (Property): Emit attributes.
24195 * enum.cs (Emit): Ditto.
24197 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
24200 * class.cs (Field, Event, etc.): Move attribute generation into the
24201 Emit method everywhere.
24203 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
24204 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
24205 as we had no way of defining nested enums !
24207 * rootcontext.cs : Adjust code accordingly.
24209 * typemanager.cs (AddEnumType): To keep track of enum types separately.
24211 2001-11-07 Ravi Pratap <ravi@ximian.com>
24213 * expression.cs (EvalConstantExpression): Move into ecore.cs
24215 * enum.cs (Enum): Rename some members and make them public and readonly
24216 according to our convention.
24218 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
24221 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
24223 (Enum::Emit): Write a simple version for now which doesn't try to compute
24224 expressions. I shall modify this to be more robust in just a while.
24226 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
24228 (TypeContainer::CloseType): Create the Enum types too.
24230 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
24232 * expression.cs (EvalConstantExpression): Get rid of completely.
24234 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
24235 user-defined values and other cases.
24237 (IsValidEnumLiteral): Helper function.
24239 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
24240 out there in the case we had a literal FieldExpr.
24242 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
24244 (Literalize): Revamp a bit to take two arguments.
24246 (EnumLiteral): New class which derives from Literal to wrap enum literals.
24248 2001-11-06 Ravi Pratap <ravi@ximian.com>
24250 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
24252 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
24254 (Resolve): Use the above to ensure we have proper initializers.
24256 2001-11-05 Ravi Pratap <ravi@ximian.com>
24258 * expression.cs (Expression::EvalConstantExpression): New method to
24259 evaluate constant expressions.
24261 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
24263 2001-11-07 Miguel de Icaza <miguel@ximian.com>
24265 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
24268 (Binary.ResolveOperator): Handle operator != (object a, object b)
24269 and operator == (object a, object b);
24271 (Binary.DoNumericPromotions): Indicate whether the numeric
24272 promotion was possible.
24274 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
24277 Made the ArrayAccess implement interface IAssignMethod instead of
24278 IStackStore as the order in which arguments are passed reflects
24281 * assign.cs: Instead of using expr.ExprClass to select the way of
24282 assinging, probe for the IStackStore/IAssignMethod interfaces.
24284 * typemanager.cs: Load InitializeArray definition.
24286 * rootcontext.cs (RootContext.MakeStaticData): Used to define
24287 static data that can be used to initialize arrays.
24289 2001-11-05 Miguel de Icaza <miguel@ximian.com>
24291 * expression.cs: Handle operator== and operator!= for booleans.
24293 (Conditioal.Reduce): Implement reducer for the ?: operator.
24295 (Conditional.Resolve): Implement dead code elimination.
24297 (Binary.Resolve): Catch string literals and return a new
24298 concatenated string.
24300 (Unary.Reduce): Implement reduction of unary expressions.
24302 * ecore.cs: Split out the expression core handling here.
24304 (Expression.Reduce): New method used to perform constant folding
24305 and CSE. This is needed to support constant-expressions.
24307 * statement.cs (Statement.EmitBoolExpression): Pass true and false
24308 targets, and optimize for !x.
24310 2001-11-04 Ravi Pratap <ravi@ximian.com>
24312 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
24313 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
24314 set custom atttributes.
24316 * literal.cs (Literal::GetValue): New abstract method to return the actual
24317 value of the literal, cast as an object.
24319 (*Literal): Implement GetValue method.
24321 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
24322 expressions to the arraylist but objects of type Argument.
24324 * class.cs (TypeContainer::Emit): Emit our attributes too.
24326 (Method::Emit, Constructor::Emit): Ditto.
24328 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
24329 to be ignoring earlier.
24331 2001-11-03 Ravi Pratap <ravi@ximian.com>
24333 * attribute.cs (AttributeSection::Define): Implement to do the business
24334 of constructing a CustomAttributeBuilder.
24336 (Attribute): New trivial class. Increases readability of code.
24338 * cs-parser.jay : Update accordingly.
24340 (positional_argument_list, named_argument_list, named_argument): New rules
24342 (attribute_arguments): Use the above so that we are more correct.
24344 2001-11-02 Ravi Pratap <ravi@ximian.com>
24346 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
24347 to perform all checks for a method with a params parameter.
24349 (Invocation::OverloadResolve): Update to use the above method and therefore
24350 cope correctly with params method invocations.
24352 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
24355 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
24356 constructors in our parent too because we can't afford to miss out on
24359 * attribute.cs (AttributeSection): New name for the class Attribute
24361 Other trivial changes to improve readability.
24363 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
24364 use the new class names.
24366 2001-11-01 Ravi Pratap <ravi@ximian.com>
24368 * class.cs (Method::Define): Complete definition for params types too
24370 (Indexer::Define): Ditto.
24372 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
24373 Cope everywhere with a request for info about the array parameter.
24375 2001-11-01 Ravi Pratap <ravi@ximian.com>
24377 * tree.cs (RecordNamespace): Fix up to check for the correct key.
24379 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
24380 local_variable_type to extract the string corresponding to the type.
24382 (local_variable_type): Fixup the action to use the new helper method.
24384 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
24387 * expression.cs : Clean out code which uses the above.
24389 2001-10-31 Ravi Pratap <ravi@ximian.com>
24391 * typemanager.cs (RegisterMethod): Check if we already have an existing key
24392 and bale out if necessary by returning a false.
24394 (RegisterProperty): Ditto.
24396 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
24397 and print out appropriate error messages.
24399 * interface.cs (everywhere): Ditto.
24401 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
24402 location to constructor.
24404 * class.cs (Property, Event, Indexer): Update accordingly.
24406 * ../errors/cs111.cs : Added.
24408 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
24409 of a method, as laid down by the spec.
24411 (Invocation::OverloadResolve): Use the above method.
24413 2001-10-31 Ravi Pratap <ravi@ximian.com>
24415 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
24416 now take a TypeContainer and a Parameters object.
24418 (ParameterData): Modify return type of ParameterModifier method to be
24419 Parameter.Modifier and not a string.
24421 (ReflectionParameters, InternalParameters): Update accordingly.
24423 * expression.cs (Argument::GetParameterModifier): Same here.
24425 * support.cs (InternalParameters::ParameterType): Find a better way of determining
24426 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
24427 symbol in it at all so maybe this is only for now.
24429 2001-10-30 Ravi Pratap <ravi@ximian.com>
24431 * support.cs (InternalParameters): Constructor now takes an extra argument
24432 which is the actual Parameters class.
24434 (ParameterDesc): Update to provide info on ref/out modifiers.
24436 * class.cs (everywhere): Update call to InternalParameters to pass in
24437 the second argument too.
24439 * support.cs (ParameterData): Add ParameterModifier, which is a method
24440 to return the modifier info [ref/out etc]
24442 (InternalParameters, ReflectionParameters): Implement the above.
24444 * expression.cs (Argument::ParameterModifier): Similar function to return
24445 info about the argument's modifiers.
24447 (Invocation::OverloadResolve): Update to take into account matching modifiers
24450 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
24451 a new SetFormalParameters object which we pass to InternalParameters.
24453 2001-10-30 Ravi Pratap <ravi@ximian.com>
24455 * expression.cs (NewArray): Merge into the ArrayCreation class.
24457 2001-10-29 Ravi Pratap <ravi@ximian.com>
24459 * expression.cs (NewArray): Merge classes NewBuiltinArray and
24460 NewUserdefinedArray into one as there wasn't much of a use in having
24463 * expression.cs (Argument): Change field's name to ArgType from Type.
24465 (Type): New readonly property which returns the proper type, taking into
24466 account ref/out modifiers.
24468 (everywhere): Adjust code accordingly for the above.
24470 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
24471 whether we are emitting for a ref or out parameter.
24473 * expression.cs (Argument::Emit): Use the above field to set the state.
24475 (LocalVariableReference::Emit): Update to honour the flag and emit the
24478 * parameter.cs (Attributes): Set the correct flags for ref parameters.
24480 * expression.cs (Argument::FullDesc): New function to provide a full desc.
24482 * support.cs (ParameterData): Add method ParameterDesc to the interface.
24484 (ReflectionParameters, InternalParameters): Implement the above method.
24486 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
24489 (Invocation::FullMethodDesc): Ditto.
24491 2001-10-29 Miguel de Icaza <miguel@ximian.com>
24493 * cs-parser.jay: Add extra production for the second form of array
24496 * expression.cs (ArrayCreation): Update to reflect the above
24499 * Small changes to prepare for Array initialization.
24501 2001-10-28 Miguel de Icaza <miguel@ximian.com>
24503 * typemanager.cs (ImplementsInterface): interface might be null;
24504 Deal with this problem;
24506 Also, we do store negative hits on the cache (null values), so use
24507 this instead of calling t.GetInterfaces on the type everytime.
24509 2001-10-28 Ravi Pratap <ravi@ximian.com>
24511 * typemanager.cs (IsBuiltinType): New method to help determine the same.
24513 * expression.cs (New::DoResolve): Get rid of array creation code and instead
24514 split functionality out into different classes.
24516 (New::FormArrayType): Move into NewBuiltinArray.
24518 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
24521 (NewBuiltinArray): New class to handle creation of built-in arrays.
24523 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
24524 account creation of one-dimensional arrays.
24526 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
24528 (NewUserdefinedArray::DoResolve): Implement.
24530 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
24532 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
24533 we maintain inside the TypeManager. This is necessary to perform lookups on the
24536 (LookupType): Update to perform GetType on the module builders too.
24538 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
24540 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
24542 2001-10-23 Ravi Pratap <ravi@ximian.com>
24544 * expression.cs (New::DoResolve): Implement guts of array creation.
24546 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
24548 2001-10-27 Miguel de Icaza <miguel@ximian.com>
24550 * expression.cs: Fix bug I introduced lsat night that broke
24553 (Expression.Resolve): Report a 246 error (can not resolve name)
24554 if we find a SimpleName in the stream.
24556 (Expression.ResolveLValue): Ditto.
24558 (Expression.ResolveWithSimpleName): This function is a variant of
24559 ResolveName, this one allows SimpleNames to be returned without a
24560 warning. The only consumer of SimpleNames is MemberAccess
24562 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24564 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24565 might arrive here. I have my doubts that this is correct.
24567 * statement.cs (Lock): Implement lock statement.
24569 * cs-parser.jay: Small fixes to support `lock' and `using'
24571 * cs-tokenizer.cs: Remove extra space
24573 * driver.cs: New flag --checked, allows to turn on integer math
24576 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24577 Threading.Monitor.Exit
24579 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24581 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24582 Expression Class to be IndexerAccess.
24584 Notice that Indexer::DoResolve sets the eclass to Value.
24586 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24588 * class.cs (TypeContainer::Emit): Emit code for indexers.
24590 * assign.cs (IAssignMethod): New interface implemented by Indexers
24591 and Properties for handling assignment.
24593 (Assign::Emit): Simplify and reuse code.
24595 * expression.cs (IndexerAccess, PropertyExpr): Implement
24596 IAssignMethod, clean up old code.
24598 2001-10-22 Ravi Pratap <ravi@ximian.com>
24600 * typemanager.cs (ImplementsInterface): New method to determine if a type
24601 implements a given interface. Provides a nice cache too.
24603 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24606 (ConvertReferenceExplicit): Ditto.
24608 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24609 various methods, with correct names etc.
24611 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24612 Operator.UnaryNegation.
24614 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24615 we have a unary plus or minus operator.
24617 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24620 * everywhere : update accordingly.
24622 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24625 * class.cs (Method::Define): For the case where we are implementing a method
24626 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24627 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24629 2001-10-21 Ravi Pratap <ravi@ximian.com>
24631 * interface.cs (FindMembers): Implement to work around S.R.E
24634 * typemanager.cs (IsInterfaceType): Implement.
24636 (FindMembers): Update to handle interface types too.
24638 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24639 use IsAssignableFrom as that is not correct - it doesn't work.
24641 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24642 and accordingly override EmitStatement.
24644 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24645 using the correct logic :-)
24647 2001-10-19 Ravi Pratap <ravi@ximian.com>
24649 * ../errors/cs-11.cs : Add to demonstrate error -11
24651 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24653 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24654 then pass this as a hint to ResolveLValue.
24656 * expression.cs (FieldExpr): Add Location information
24658 (FieldExpr::LValueResolve): Report assignment to readonly
24661 (Expression::ExprClassFromMemberInfo): Pass location information.
24663 (Expression::ResolveLValue): Add new method that resolves an
24666 (Expression::DoResolveLValue): Default invocation calls
24669 (Indexers): New class used to keep track of indexers in a given
24672 (IStackStore): Renamed from LValue, as it did not really describe
24673 what this did. Also ResolveLValue is gone from this interface and
24674 now is part of Expression.
24676 (ElementAccess): Depending on the element access type
24678 * typemanager.cs: Add `indexer_name_type' as a Core type
24679 (System.Runtime.CompilerServices.IndexerNameAttribute)
24681 * statement.cs (Goto): Take a location.
24683 2001-10-18 Ravi Pratap <ravi@ximian.com>
24685 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24686 if two delegates are compatible.
24688 (NewDelegate::DoResolve): Update to take care of the case when
24689 we instantiate a delegate from another delegate.
24691 * typemanager.cs (FindMembers): Don't even try to look up members
24692 of Delegate types for now.
24694 2001-10-18 Ravi Pratap <ravi@ximian.com>
24696 * delegate.cs (NewDelegate): New class to take care of delegate
24699 * expression.cs (New): Split the delegate related code out into
24700 the NewDelegate class.
24702 * delegate.cs (DelegateInvocation): New class to handle delegate
24705 * expression.cs (Invocation): Split out delegate related code into
24706 the DelegateInvocation class.
24708 2001-10-17 Ravi Pratap <ravi@ximian.com>
24710 * expression.cs (New::DoResolve): Implement delegate creation fully
24711 and according to the spec.
24713 (New::DoEmit): Update to handle delegates differently.
24715 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24716 because of which we were printing out arguments in reverse order !
24718 * delegate.cs (VerifyMethod): Implement to check if the given method
24719 matches the delegate.
24721 (FullDelegateDesc): Implement.
24723 (VerifyApplicability): Implement.
24725 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24726 delegate invocations too.
24728 (Invocation::Emit): Ditto.
24730 * ../errors/cs1593.cs : Added.
24732 * ../errors/cs1594.cs : Added.
24734 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24736 2001-10-16 Ravi Pratap <ravi@ximian.com>
24738 * typemanager.cs (intptr_type): Core type for System.IntPtr
24740 (InitCoreTypes): Update for the same.
24742 (iasyncresult_type, asynccallback_type): Ditto.
24744 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24747 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24750 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24751 the builders for the 4 members of a delegate type :-)
24753 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24756 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24758 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24760 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24762 * statement.cs (Break::Emit): Implement.
24763 (Continue::Emit): Implement.
24765 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24766 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24767 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24768 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24771 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24772 properties that track the label for the current loop (begin of the
24773 loop and end of the loop).
24775 2001-10-15 Ravi Pratap <ravi@ximian.com>
24777 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24778 use of emitting anything at all.
24780 * class.cs, rootcontext.cs : Get rid of calls to the same.
24782 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24784 (Populate): Define the constructor correctly and set the implementation
24787 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24790 (AddDelegateType): Implement.
24792 (IsDelegateType): Implement helper method.
24794 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24796 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24797 and accordingly handle it.
24799 * delegate.cs (Populate): Take TypeContainer argument.
24800 Implement bits to define the Invoke method. However, I still haven't figured out
24801 how to take care of the native int bit :-(
24803 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24804 Qualify the name of the delegate, not its return type !
24806 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24809 (StandardConversionExists): Checking for array types turns out to be recursive.
24811 (ConvertReferenceExplicit): Implement array conversion.
24813 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24815 2001-10-12 Ravi Pratap <ravi@ximian.com>
24817 * cs-parser.jay (delegate_declaration): Store the fully qualified
24818 name as it is a type declaration.
24820 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24823 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24824 as TypeContainer::DefineType.
24826 (Populate): Method in which all the definition of the various methods (Invoke)
24829 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24832 (CloseDelegate): Finally creates the delegate.
24834 * class.cs (TypeContainer::DefineType): Update to define delegates.
24835 (Populate, Emit and CloseType): Do the same thing here too.
24837 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24838 delegates in all these operations.
24840 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24842 * expression.cs: LocalTemporary: a new expression used to
24843 reference a temporary that has been created.
24845 * assign.cs: Handle PropertyAccess back here, so that we can
24846 provide the proper semantic access to properties.
24848 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24849 a few more explicit conversions.
24851 * modifiers.cs: `NEW' modifier maps to HideBySig.
24853 * expression.cs (PropertyExpr): Make this into an
24854 ExpressionStatement, and support the EmitStatement code path.
24856 Perform get/set error checking, clean up the interface.
24858 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24859 them into toplevel access objects.
24861 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24863 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24866 * typemanager.cs: Keep track here of our PropertyBuilders again to
24867 work around lameness in SRE.
24869 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24871 * expression.cs (LValue::LValueResolve): New method in the
24872 interface, used to perform a second resolution pass for LValues.
24874 (This::DoResolve): Catch the use of this in static methods.
24876 (This::LValueResolve): Implement.
24878 (This::Store): Remove warning, assigning to `this' in structures
24881 (Invocation::Emit): Deal with invocation of
24882 methods on value types. We need to pass the address to structure
24883 methods rather than the object itself. (The equivalent code to
24884 emit "this" for structures leaves the entire structure on the
24885 stack instead of a pointer to it).
24887 (ParameterReference::DoResolve): Compute the real index for the
24888 argument based on whether the method takes or not a `this' pointer
24889 (ie, the method is static).
24891 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24892 value types returned from functions when we need to invoke a
24893 method on the sturcture.
24896 2001-10-11 Ravi Pratap <ravi@ximian.com>
24898 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24899 defining the type in the Modulebuilder or Typebuilder. This is to take
24900 care of nested types which need to be defined on the TypeBuilder using
24901 DefineNestedMethod.
24903 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24904 methods in RootContext, only ported to be part of TypeContainer.
24906 (TypeContainer::GetInterfaceOrClass): Ditto.
24908 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
24910 * interface.cs (Interface::DefineInterface): New method. Does exactly
24911 what RootContext.CreateInterface did earlier, only it takes care of nested types
24914 (Interface::GetInterfaces): Move from RootContext here and port.
24916 (Interface::GetInterfaceByName): Same here.
24918 * rootcontext.cs (ResolveTree): Re-write.
24920 (PopulateTypes): Re-write.
24922 * class.cs (TypeContainer::Populate): Populate nested types too.
24923 (TypeContainer::Emit): Emit nested members too.
24925 * typemanager.cs (AddUserType): Do not make use of the FullName property,
24926 instead just use the name argument passed in as it is already fully
24929 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
24930 to TypeContainer mapping to see if a type is user-defined.
24932 * class.cs (TypeContainer::CloseType): Implement.
24934 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
24935 the default constructor.
24937 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
24940 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
24942 * interface.cs (CloseType): Create the type here.
24944 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
24947 Remove all the methods which are now in TypeContainer.
24949 2001-10-10 Ravi Pratap <ravi@ximian.com>
24951 * delegate.cs (Define): Re-write bits to define the delegate
24954 2001-10-10 Miguel de Icaza <miguel@ximian.com>
24956 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
24958 * expression.cs (ImplicitReferenceConversion): handle null as well
24959 as a source to convert to any reference type.
24961 * statement.cs (Return): Perform any implicit conversions to
24962 expected return type.
24964 Validate use of return statement.
24966 * codegen.cs (EmitContext): Pass the expected return type here.
24968 * class.cs (Method, Constructor, Property): Pass expected return
24969 type to EmitContext.
24971 2001-10-09 Miguel de Icaza <miguel@ximian.com>
24973 * expression.cs: Make DoResolve take an EmitContext instead of a
24976 Replaced `l' and `location' for `loc', for consistency.
24978 (Error, Warning): Remove unneeded Tc argument.
24980 * assign.cs, literal.cs, constant.cs: Update to new calling
24983 * codegen.cs: EmitContext now contains a flag indicating whether
24984 code is being generated in a static method or not.
24986 * cs-parser.jay: DecomposeQI, new function that replaces the old
24987 QualifiedIdentifier. Now we always decompose the assembled
24988 strings from qualified_identifier productions into a group of
24991 2001-10-08 Miguel de Icaza <miguel@ximian.com>
24993 * rootcontext.cs: Deal with field-less struct types correctly now
24994 by passing the size option to Define Type.
24996 * class.cs: Removed hack that created one static field.
24998 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25000 * statement.cs: Moved most of the code generation here.
25002 2001-10-09 Ravi Pratap <ravi@ximian.com>
25004 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
25007 (ElementAccess): Remove useless bits for now - keep checks as the spec
25010 2001-10-08 Ravi Pratap <ravi@ximian.com>
25012 * expression.cs (ElementAccess::DoResolve): Remove my crap code
25013 and start performing checks according to the spec.
25015 2001-10-07 Ravi Pratap <ravi@ximian.com>
25017 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
25018 rank_specifiers instead.
25020 (rank_specifiers): Change the order in which the rank specifiers are stored
25022 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
25024 * expression.cs (ElementAccess): Implement the LValue interface too.
25026 2001-10-06 Ravi Pratap <ravi@ximian.com>
25028 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
25029 except that user defined conversions are not included.
25031 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
25032 perform the conversion of the return type, if necessary.
25034 (New::DoResolve): Check whether we are creating an array or an object
25035 and accordingly do the needful.
25037 (New::Emit): Same here.
25039 (New::DoResolve): Implement guts of array creation.
25041 (New::FormLookupType): Helper function.
25043 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25045 * codegen.cs: Removed most of the code generation here, and move the
25046 corresponding code generation bits to the statement classes.
25048 Added support for try/catch/finalize and throw.
25050 * cs-parser.jay: Added support for try/catch/finalize.
25052 * class.cs: Catch static methods having the flags override,
25053 virtual or abstract.
25055 * expression.cs (UserCast): This user cast was not really doing
25056 what it was supposed to do. Which is to be born in fully resolved
25057 state. Parts of the resolution were being performed at Emit time!
25061 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25063 * expression.cs: Implicity convert the result from UserCast.
25065 2001-10-05 Ravi Pratap <ravi@ximian.com>
25067 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
25068 prevented it from working correctly.
25070 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
25071 merely ConvertImplicit.
25073 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25075 * typemanager.cs: Make the LookupTypeContainer function static,
25076 and not per-instance.
25078 * class.cs: Make static FindMembers (the one that takes a Type
25081 * codegen.cs: Add EmitForeach here.
25083 * cs-parser.jay: Make foreach a toplevel object instead of the
25084 inline expansion, as we need to perform semantic analysis on it.
25086 2001-10-05 Ravi Pratap <ravi@ximian.com>
25088 * expression.cs (Expression::ImplicitUserConversion): Rename to
25089 UserDefinedConversion.
25091 (Expression::UserDefinedConversion): Take an extra argument specifying
25092 whether we look for explicit user conversions too.
25094 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
25096 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
25098 (ExplicitUserConversion): Make it a call to UserDefinedConversion
25099 with the appropriate arguments.
25101 * cs-parser.jay (cast_expression): Record location too.
25103 * expression.cs (Cast): Record location info.
25105 (Expression::ConvertExplicit): Take location argument.
25107 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
25108 to determine if we are doing explicit conversions.
25110 (UserCast::Emit): Update accordingly.
25112 (Expression::ConvertExplicit): Report an error if everything fails.
25114 * ../errors/cs0030.cs : Add.
25116 2001-10-04 Miguel de Icaza <miguel@ximian.com>
25118 * modifiers.cs: If the ABSTRACT keyword is present, also set the
25119 virtual and newslot bits.
25121 * class.cs (TypeContainer::RegisterRequiredImplementations):
25122 Record methods we need.
25124 (TypeContainer::MakeKey): Helper function to make keys for
25125 MethodBases, since the Methodbase key is useless.
25127 (TypeContainer::Populate): Call RegisterRequiredImplementations
25128 before defining the methods.
25130 Create a mapping for method_builders_to_methods ahead of time
25131 instead of inside a tight loop.
25133 (::RequireMethods): Accept an object as the data to set into the
25134 hashtable so we can report interface vs abstract method mismatch.
25136 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25138 * report.cs: Make all of it static.
25140 * rootcontext.cs: Drop object_type and value_type computations, as
25141 we have those in the TypeManager anyways.
25143 Drop report instance variable too, now it is a global.
25145 * driver.cs: Use try/catch on command line handling.
25147 Add --probe option to debug the error reporting system with a test
25150 * report.cs: Add support for exiting program when a probe
25151 condition is reached.
25153 2001-10-03 Ravi Pratap <ravi@ximian.com>
25155 * expression.cs (Binary::DoNumericPromotions): Fix the case when
25156 we do a forcible conversion regardless of type, to check if
25157 ForceConversion returns a null.
25159 (Binary::error19): Use location to report error.
25161 (Unary::error23): Use location here too.
25163 * ../errors/cs0019.cs : Check in.
25165 * ../errors/cs0023.cs : Check in.
25167 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
25168 case of a non-null MethodInfo object with a length of 0 !
25170 (Binary::ResolveOperator): Flag error if overload resolution fails to find
25171 an applicable member - according to the spec :-)
25172 Also fix logic to find members in base types.
25174 (Unary::ResolveOperator): Same here.
25176 (Unary::report23): Change name to error23 and make first argument a TypeContainer
25177 as I was getting thoroughly confused between this and error19 :-)
25179 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
25180 (::FindMostEncompassedType): Implement.
25181 (::FindMostEncompassingType): Implement.
25182 (::StandardConversionExists): Implement.
25184 (UserImplicitCast): Re-vamp. We now need info about most specific
25185 source and target types so that we can do the necessary conversions.
25187 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
25188 mathematical union with no duplicates.
25190 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25192 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
25193 in order from base classes to child classes, so that we can in
25194 child classes look up in our parent for method names and
25195 attributes (required for handling abstract, virtual, new, override
25196 constructs: we need to instrospect our base class, and if we dont
25197 populate the classes in order, the introspection might be
25198 incorrect. For example, a method could query its parent before
25199 the parent has any methods and would determine that the parent has
25200 no abstract methods (while it could have had them)).
25202 (RootContext::CreateType): Record the order in which we define the
25205 2001-10-02 Miguel de Icaza <miguel@ximian.com>
25207 * class.cs (TypeContainer::Populate): Also method definitions can
25208 fail now, keep track of this.
25210 (TypeContainer::FindMembers): Implement support for
25211 DeclaredOnly/noDeclaredOnly flag.
25213 (Constructor::Emit) Return the ConstructorBuilder.
25215 (Method::Emit) Return the MethodBuilder.
25216 Check for abstract or virtual methods to be public.
25218 * rootcontext.cs (RootContext::CreateType): Register all the
25219 abstract methods required for the class to be complete and the
25220 interface methods that must be implemented.
25222 * cs-parser.jay: Report error 501 (method requires body if it is
25223 not marked abstract or extern).
25225 * expression.cs (TypeOf::Emit): Implement.
25227 * typemanager.cs: runtime_handle_type, new global type.
25229 * class.cs (Property::Emit): Generate code for properties.
25231 2001-10-02 Ravi Pratap <ravi@ximian.com>
25233 * expression.cs (Unary::ResolveOperator): Find operators on base type
25234 too - we now conform exactly to the spec.
25236 (Binary::ResolveOperator): Same here.
25238 * class.cs (Operator::Define): Fix minor quirk in the tests.
25240 * ../errors/cs0215.cs : Added.
25242 * ../errors/cs0556.cs : Added.
25244 * ../errors/cs0555.cs : Added.
25246 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25248 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
25249 single integer which is really efficient
25251 2001-10-01 Ravi Pratap <ravi@ximian.com>
25253 * expression.cs (Expression::ImplicitUserConversion): Use location
25254 even in the case when we are examining True operators.
25256 * class.cs (Operator::Define): Perform extensive checks to conform
25257 with the rules for operator overloading in the spec.
25259 * expression.cs (Expression::ImplicitReferenceConversion): Implement
25260 some of the other conversions mentioned in the spec.
25262 * typemanager.cs (array_type): New static member for the System.Array built-in
25265 (cloneable_interface): For System.ICloneable interface.
25267 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
25268 we start resolving the tree and populating types.
25270 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
25272 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25274 * expression.cs (Expression::ExprClassFromMemberInfo,
25275 Expression::Literalize): Create literal expressions from
25276 FieldInfos which are literals.
25278 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
25279 type casts, because they were wrong. The test suite in tests
25282 (ImplicitNumericConversion): ushort to ulong requires a widening
25285 Int32 constant to long requires widening cast as well.
25287 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
25288 for integers because the type on the stack is not i4.
25290 2001-09-30 Miguel de Icaza <miguel@ximian.com>
25292 * expression.cs (report118): require location argument.
25294 * parameter.cs: Do not dereference potential null value.
25296 * class.cs: Catch methods that lack the `new' keyword when
25297 overriding a name. Report warnings when `new' is used without
25298 anything being there to override.
25300 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
25302 * class.cs: Only add constructor to hashtable if it is non-null
25303 (as now constructors can fail on define).
25305 (TypeManager, Class, Struct): Take location arguments.
25307 Catch field instance initialization in structs as errors.
25309 accepting_filter: a new filter for FindMembers that is static so
25310 that we dont create an instance per invocation.
25312 (Constructor::Define): Catch errors where a struct constructor is
25315 * cs-parser.jay: Pass location information for various new
25318 * delegate.cs (Delegate): take a location argument.
25320 * driver.cs: Do not call EmitCode if there were problesm in the
25321 Definition of the types, as many Builders wont be there.
25323 * decl.cs (Decl::Decl): Require a location argument.
25325 * cs-tokenizer.cs: Handle properly hex constants that can not fit
25326 into integers, and find the most appropiate integer for it.
25328 * literal.cs: Implement ULongLiteral.
25330 * rootcontext.cs: Provide better information about the location of
25331 failure when CreateType fails.
25333 2001-09-29 Miguel de Icaza <miguel@ximian.com>
25335 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
25338 * expression.cs (Binary::CheckShiftArguments): Add missing type
25340 (Binary::ResolveOperator): Add type to the logical and and logical
25341 or, Bitwise And/Or and Exclusive Or code paths, it was missing
25344 (Binary::DoNumericPromotions): In the case where either argument
25345 is ulong (and most signed types combined with ulong cause an
25346 error) perform implicit integer constant conversions as well.
25348 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25350 * expression.cs (UserImplicitCast): Method should always be
25352 (Invocation::BetterConversion): Simplified test for IntLiteral.
25354 (Expression::ImplicitNumericConversion): Split this routine out.
25355 Put the code that performs implicit constant integer conversions
25358 (Expression::Resolve): Become a wrapper around DoResolve so we can
25359 check eclass and type being set after resolve.
25361 (Invocation::Badness): Remove this dead function
25363 (Binary::ResolveOperator): Do not compute the expensive argumnets
25364 unless we have a union for it.
25366 (Probe::Emit): Is needs to do an isinst and then
25367 compare against null.
25369 (::CanConvert): Added Location argument. If the Location argument
25370 is null (Location.Null), then we do not report errors. This is
25371 used by the `probe' mechanism of the Explicit conversion. We do
25372 not want to generate an error for something that the user
25373 explicitly requested to be casted. But the pipeline for an
25374 explicit cast first tests for potential implicit casts.
25376 So for now, if the Location is null, it means `Probe only' to
25377 avoid adding another argument. Might have to revise this
25380 (ClassCast): New class used to type cast objects into arbitrary
25381 classes (used in Explicit Reference Conversions).
25383 Implement `as' as well.
25385 Reverted all the patches from Ravi below: they were broken:
25387 * The use of `level' as a mechanism to stop recursive
25388 invocations is wrong. That was there just to catch the
25389 bug with a strack trace but not as a way of addressing
25392 To fix the problem we have to *understand* what is going
25393 on and the interactions and come up with a plan, not
25394 just get things going.
25396 * The use of the type conversion cache that I proposed
25397 last night had an open topic: How does this work across
25398 protection domains. A user defined conversion might not
25399 be public in the location where we are applying the
25400 conversion, a different conversion might be selected
25401 (ie, private A->B (better) but public B->A (worse),
25402 inside A, A->B applies, but outside it, B->A will
25405 * On top of that (ie, even if the above is solved),
25406 conversions in a cache need to be abstract. Ie, `To
25407 convert from an Int to a Short use an OpcodeCast', not
25408 `To convert from an Int to a Short use the OpcodeCast on
25409 the variable 5' (which is what this patch was doing).
25411 2001-09-28 Ravi Pratap <ravi@ximian.com>
25413 * expression.cs (Invocation::ConversionExists): Re-write to use
25414 the conversion cache
25416 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
25417 cache all conversions done, not just user-defined ones.
25419 (Invocation::BetterConversion): The real culprit. Use ConversionExists
25420 to determine if a conversion exists instead of acutually trying to
25421 perform the conversion. It's faster too.
25423 (Expression::ConvertExplicit): Modify to use ConversionExists to check
25424 and only then attempt the implicit conversion.
25426 2001-09-28 Ravi Pratap <ravi@ximian.com>
25428 * expression.cs (ConvertImplicit): Use a cache for conversions
25429 already found. Check level of recursion and bail out if necessary.
25431 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25433 * typemanager.cs (string_concat_string_string, string_concat_object_object):
25434 Export standard methods that we expect for string operations.
25436 * statement.cs (Block::UsageWarning): Track usage of variables and
25437 report the errors for not used variables.
25439 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
25442 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25444 * codegen.cs: remove unnneded code
25446 * expression.cs: Removed BuiltinTypeAccess class
25448 Fix the order in which implicit conversions are
25451 The previous fixed dropped support for boxed conversions (adding a
25452 test to the test suite now)
25454 (UserImplicitCast::CanConvert): Remove test for source being null,
25455 that code is broken. We should not feed a null to begin with, if
25456 we do, then we should track the bug where the problem originates
25457 and not try to cover it up here.
25459 Return a resolved expression of type UserImplicitCast on success
25460 rather than true/false. Ravi: this is what I was talking about,
25461 the pattern is to use a static method as a "constructor" for
25464 Also, do not create arguments until the very last minute,
25465 otherwise we always create the arguments even for lookups that
25466 will never be performed.
25468 (UserImplicitCast::Resolve): Eliminate, objects of type
25469 UserImplicitCast are born in a fully resolved state.
25471 * typemanager.cs (InitCoreTypes): Init also value_type
25472 (System.ValueType).
25474 * expression.cs (Cast::Resolve): First resolve the child expression.
25476 (LValue): Add new method AddressOf to be used by
25479 Change the argument of Store to take an EmitContext instead of an
25480 ILGenerator, because things like FieldExpr need to be able to call
25481 their children expression to generate the instance code.
25483 (Expression::Error, Expression::Warning): Sugar functions for
25486 (Expression::MemberLookup): Accept a TypeContainer instead of a
25487 Report as the first argument.
25489 (Expression::ResolvePrimary): Killed. I still want to improve
25490 this as currently the code is just not right.
25492 (Expression::ResolveMemberAccess): Simplify, but it is still
25495 (Unary::Resolve): Catch errors in AddressOf operators.
25497 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
25498 index to a byte for the short-version, or the compiler will choose
25499 the wrong Emit call, which generates the wrong data.
25501 (ParameterReference::Emit, ::Store): same.
25503 (FieldExpr::AddressOf): Implement.
25505 * typemanager.cs: TypeManager: made public variable instead of
25508 * driver.cs: document --fatal.
25510 * report.cs (ErrorMessage, WarningMessage): new names for the old
25511 Error and Warning classes.
25513 * cs-parser.jay (member_access): Turn built-in access to types
25514 into a normal simplename
25516 2001-09-27 Ravi Pratap <ravi@ximian.com>
25518 * expression.cs (Invocation::BetterConversion): Fix to cope
25519 with q being null, since this was introducing a bug.
25521 * expression.cs (ConvertImplicit): Do built-in conversions first.
25523 2001-09-27 Ravi Pratap <ravi@ximian.com>
25525 * expression.cs (UserImplicitCast::Resolve): Fix bug.
25527 2001-09-27 Ravi Pratap <ravi@ximian.com>
25529 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
25530 I had introduced long ago (what's new ?).
25532 * expression.cs (UserImplicitCast::CanConvert): Static method to do
25533 the work of all the checking.
25534 (ConvertImplicit): Call CanConvert and only then create object if necessary.
25535 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
25537 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
25538 that is the right way.
25540 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
25541 overloading resolution. Use everywhere instead of cutting and pasting code.
25543 (Binary::ResolveOperator): Use MakeUnionSet.
25545 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
25546 we have to convert to bool types. Not complete yet.
25548 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25550 * typemanager.cs (TypeManager::CSharpName): support ushort.
25552 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25553 to provide an expression that performsn an implicit constant int
25554 conversion (section 6.1.6).
25555 (Expression::ConvertImplicitRequired): Reworked to include
25556 implicit constant expression conversions.
25558 (Expression::ConvertNumericExplicit): Finished.
25560 (Invocation::Emit): If InstanceExpression is null, then it means
25561 that we perform a call on this.
25563 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25565 * expression.cs (Unary::Emit): Remove some dead code.
25566 (Probe): Implement Resolve and Emit for `is'.
25567 (Expression::ConvertImplicitRequired): Attempt to do constant
25568 expression conversions here. Maybe should be moved to
25569 ConvertImplicit, but I am not sure.
25570 (Expression::ImplicitLongConstantConversionPossible,
25571 Expression::ImplicitIntConstantConversionPossible): New functions
25572 that tell whether is it possible to apply an implicit constant
25573 expression conversion.
25575 (ConvertNumericExplicit): Started work on explicit numeric
25578 * cs-parser.jay: Update operator constants.
25580 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25581 (Parameters::GetSignature): Hook up VerifyArgs here.
25582 (Parameters::VerifyArgs): Verifies that no two arguments have the
25585 * class.cs (Operator): Update the operator names to reflect the
25586 ones that the spec expects (as we are just stringizing the
25589 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25590 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25591 previous usage did only work for our methods.
25592 (Expression::ConvertImplicit): Handle decimal implicit numeric
25593 conversions as well.
25594 (Expression::InternalTypeConstructor): Used to invoke constructors
25595 on internal types for default promotions.
25597 (Unary::Emit): Implement special handling for the pre/post
25598 increment/decrement for overloaded operators, as they need to have
25599 the same semantics as the other operators.
25601 (Binary::ResolveOperator): ditto.
25602 (Invocation::ConversionExists): ditto.
25603 (UserImplicitCast::Resolve): ditto.
25605 2001-09-26 Ravi Pratap <ravi@ximian.com>
25607 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25608 operator, return after emitting body. Regression tests pass again !
25610 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25611 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25612 (Invocation::OverloadResolve): Ditto.
25613 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25615 * everywhere : update calls to the above methods accordingly.
25617 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25619 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25621 * expression.cs (ExpressionStatement): New base class used for
25622 expressions that can appear in statements, so that we can provide
25623 an alternate path to generate expression that do not leave a value
25626 (Expression::Emit, and all the derivatives): We no longer return
25627 whether a value is left on the stack or not. Every expression
25628 after being emitted leaves a single value on the stack.
25630 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25631 facilties of ExpressionStatement if possible.
25633 * cs-parser.jay: Update statement_expression.
25635 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25637 * driver.cs: Change the wording of message
25639 2001-09-25 Ravi Pratap <ravi@ximian.com>
25641 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25642 the type of the expression to the return type of the method if
25643 we have an overloaded operator match ! The regression tests pass again !
25644 (Unary::ResolveOperator): Ditto.
25646 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25647 to find "op_Implicit", not "implicit" ;-)
25648 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25649 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25651 * everywhere : Correct calls to the above accordingly.
25653 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25654 (ConvertImplicit): Do user-defined conversion if it exists.
25656 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25658 * assign.cs: track location.
25659 (Resolve): Use implicit conversions on assignment.
25661 * literal.cs: Oops. Not good, Emit of short access values should
25662 pass (Bytes) or the wrong argument will be selected.
25664 * expression.cs (Unary::Emit): Emit code for -expr.
25666 (Unary::ResolveOperator): Handle `Substract' for non-constants
25667 (substract from zero from the non-constants).
25668 Deal with Doubles as well.
25670 (Expression::ConvertImplicitRequired): New routine that reports an
25671 error if no implicit conversion exists.
25673 (Invocation::OverloadResolve): Store the converted implicit
25674 expressions if we make them
25676 2001-09-24 Ravi Pratap <ravi@ximian.com>
25678 * class.cs (ConstructorInitializer): Take a Location argument.
25679 (ConstructorBaseInitializer): Same here.
25680 (ConstructorThisInitializer): Same here.
25682 * cs-parser.jay : Update all calls accordingly.
25684 * expression.cs (Unary, Binary, New): Take location argument.
25685 Update accordingly everywhere.
25687 * cs-parser.jay : Update all calls to the above to take a location
25690 * class.cs : Ditto.
25692 2001-09-24 Ravi Pratap <ravi@ximian.com>
25694 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25695 (Invocation::BetterConversion): Same here
25696 (Invocation::ConversionExists): Ditto.
25698 (Invocation::ConversionExists): Implement.
25700 2001-09-22 Ravi Pratap <ravi@ximian.com>
25702 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25703 Also take an additional TypeContainer argument.
25705 * All over : Pass in TypeContainer as argument to OverloadResolve.
25707 * typemanager.cs (CSharpName): Update to check for the string type and return
25710 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25713 2001-09-21 Ravi Pratap <ravi@ximian.com>
25715 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25716 (Invocation::BetterFunction): Implement.
25717 (Invocation::BetterConversion): Implement.
25718 (Invocation::ConversionExists): Skeleton, no implementation yet.
25720 Okay, things work fine !
25722 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25724 * typemanager.cs: declare and load enum_type, delegate_type and
25727 * expression.cs (Expression::Emit): Now emit returns a value that
25728 tells whether a value is left on the stack or not. This strategy
25729 might be reveted tomorrow with a mechanism that would address
25730 multiple assignments.
25731 (Expression::report118): Utility routine to report mismatches on
25734 (Unary::Report23): Report impossible type/operator combination
25737 (Unary::IsIncrementableNumber): Whether the type can be
25738 incremented or decremented with add.
25739 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25741 (Unary::ResolveOperator): Implement ++, !, ~,
25743 (Invocation::Emit): Deal with new Emit convetion.
25745 * All Expression derivatives: Updated their Emit method to return
25746 whether they leave values on the stack or not.
25748 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25749 stack for expressions that are statements.
25751 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25753 * expression.cs (LValue): New interface. Must be implemented by
25755 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25758 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25759 interface for generating code, simplifies the code.
25761 2001-09-20 Ravi Pratap <ravi@ximian.com>
25763 * expression.cs (everywhere): Comment out return statements in ::Resolve
25764 methods to avoid the warnings.
25766 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25768 * driver.cs (parse): Report error 2001 if we can not open the
25771 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25774 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25777 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25778 otherwise nested blocks end up with the same index.
25780 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25782 * expression.cs: Instead of having FIXMEs in the Resolve
25783 functions, throw exceptions so it is obvious that we are facing a
25786 * cs-parser.jay (invocation_expression): Pass Location information.
25788 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25789 Use a basename for those routines because .NET does not like paths
25792 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25795 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25797 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25798 are loading the correct data types (throws an exception if not).
25799 (TypeManager::InitCoreTypes): Use CoreLookupType
25801 * expression.cs (Unary::ResolveOperator): return the child
25802 expression for expressions which are just +expr.
25803 (Unary::ResolveOperator): Return negative literals for -LITERAL
25804 expressions (otherwise they are Unary {Literal}).
25805 (Invocation::Badness): Take into account `Implicit constant
25806 expression conversions'.
25808 * literal.cs (LongLiteral): Implement long literal class.
25809 (IntLiteral): export the `Value' of the intliteral.
25811 2001-09-19 Ravi Pratap <ravi@ximian.com>
25813 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25815 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25816 instead of 'Operator'
25818 * expression.cs (Binary::ResolveOperator): Update accordingly.
25819 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25822 * cs-parser.jay (unary_expression): Update to use the new names.
25824 * gen-treedump.cs (GetUnary): Same here.
25826 * expression.cs (Unary::Resolve): Implement.
25827 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25828 operators are found instead of making noise ;-)
25829 (Unary::ResolveOperator): New method to do precisely the same thing which
25830 Binary::ResolveOperator does for Binary expressions.
25831 (Unary.method, .Arguments): Add.
25832 (Unary::OperName): Implement.
25833 (Unary::ForceConversion): Copy and Paste !
25835 * class.cs (Operator::Define): Fix a small bug for the case when we have
25838 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25839 for the inbuilt operators. Only overloading works for now ;-)
25841 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25843 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25844 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25846 * expression.cs (This::Emit): Implement.
25847 (This::Resolve): Implement.
25848 (TypeOf:Resolve): Implement.
25849 (Expression::ResolveSimpleName): Add an implicit this to instance
25851 (MemberAccess::Resolve): Deal with Parameters and Fields.
25852 Bind instance variable to Field expressions.
25853 (FieldExpr::Instance): New field used to track the expression that
25854 represents the object instance.
25855 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25857 (FieldExpr::Emit): Implement.
25859 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25860 the last instruction contains a return opcode to avoid generating
25861 the last `ret' instruction (this generates correct code, and it is
25862 nice to pass the peverify output).
25864 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25865 initializer for static and instance variables.
25866 (Constructor::Emit): Allow initializer to be null in the case of
25867 static constructors. Only emit initializer for instance
25870 (TypeContainer::FindMembers): Return a null array if there are no
25873 Also fix the code for the MemberTypes.Method branch, as it was not
25874 scanning that for operators (or tried to access null variables before).
25876 * assign.cs (Assign::Emit): Handle instance and static fields.
25880 * driver.cs: Stop compilation if there are parse errors.
25882 * cs-parser.jay (constructor_declaration): Provide default base
25883 initializer for non-static constructors.
25884 (constructor_declarator): Do not provide a default base
25885 initializers if none was specified.
25886 Catch the fact that constructors should not have parameters.
25888 * class.cs: Do not emit parent class initializers for static
25889 constructors, that should be flagged as an error.
25891 2001-09-18 Ravi Pratap <ravi@ximian.com>
25893 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25894 Move back code into TypeContainer::Populate.
25896 2001-09-18 Ravi Pratap <ravi@ximian.com>
25898 * class.cs (TypeContainer::AddConstructor): Fix the check to
25899 compare against Name, not Basename.
25900 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25902 * cs-parser.jay : Update accordingly.
25904 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25905 for methods, don't forget to look into the operators too.
25906 (RegisterMethodBuilder): Helper method to take care of this for
25907 methods, constructors and operators.
25908 (Operator::Define): Completely revamp.
25909 (Operator.OperatorMethod, MethodName): New fields.
25910 (TypeContainer::Populate): Move the registering of builders into
25911 RegisterMethodBuilder.
25912 (Operator::Emit): Re-write.
25914 * expression.cs (Binary::Emit): Comment out code path to emit method
25915 invocation stuff for the case when we have a user defined operator. I am
25916 just not able to get it right !
25918 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25920 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
25923 (Expression::MemberLookup): Provide a version that allows to
25924 specify the MemberTypes and BindingFlags.
25926 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
25927 so it was not fetching variable information from outer blocks.
25929 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
25930 Beforefieldinit as it was buggy.
25932 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
25933 that Ravi put here.
25935 * class.cs (Constructor::Emit): Only emit if block is not null.
25936 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
25937 deal with this by semantically definining it as if the user had
25940 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
25941 constructors as we now "emit" them at a higher level.
25943 (TypeContainer::DefineDefaultConstructor): Used to define the
25944 default constructors if none was provided.
25946 (ConstructorInitializer): Add methods Resolve and Emit.
25948 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
25950 2001-09-17 Ravi Pratap <ravi@ximian.com>
25952 * class.cs (TypeContainer::EmitDefaultConstructor): Register
25953 the default constructor builder with our hashtable for methodbuilders
25956 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
25957 and argument_count is 0 in which case we have a match.
25958 (Binary::ResolveOperator): More null checking and miscellaneous coding
25961 2001-09-17 Ravi Pratap <ravi@ximian.com>
25963 * rootcontext.cs (IsNameSpace): Compare against null.
25965 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
25967 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
25968 and Unary::Operator.
25970 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
25973 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
25974 we have overloaded operators.
25975 (Binary::ResolveOperator): Implement the part which does the operator overload
25978 * class.cs (Operator::Emit): Implement.
25979 (TypeContainer::Emit): Emit the operators we have too.
25981 * expression.cs (Binary::Emit): Update to emit the appropriate code for
25982 the case when we have a user-defined operator.
25984 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25986 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
25988 2001-09-16 Ravi Pratap <ravi@ximian.com>
25990 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
25991 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
25992 (Constructor::Emit): Implement.
25993 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
25994 if we have no work to do.
25995 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
25998 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
25999 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
26001 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
26004 2001-09-15 Ravi Pratap <ravi@ximian.com>
26006 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
26008 (Tree::RecordNamespace): Method to do what the name says ;-)
26009 (Tree::Namespaces): Property to get at the namespaces hashtable.
26011 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
26014 * rootcontext.cs (IsNamespace): Fixed it :-)
26016 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26018 * class.cs (TypeContainer::FindMembers): Add support for
26020 (MethodCore): New class that encapsulates both the shared aspects
26021 of a Constructor and a Method.
26022 (Method, Constructor): Factored pieces into MethodCore.
26024 * driver.cs: Added --fatal which makes errors throw exceptions.
26025 Load System assembly as well as part of the standard library.
26027 * report.cs: Allow throwing exceptions on errors for debugging.
26029 * modifiers.cs: Do not use `parent', instead use the real type
26030 container to evaluate permission settings.
26032 * class.cs: Put Ravi's patch back in. He is right, and we will
26033 have to cope with the
26035 2001-09-14 Ravi Pratap <ravi@ximian.com>
26037 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
26038 FamORAssem, not FamANDAssem.
26040 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26042 * driver.cs: Added --parse option that only parses its input files
26045 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
26046 incorrect. IsTopLevel is not used to tell whether an object is
26047 root_types or not (that can be achieved by testing this ==
26048 root_types). But to see if this is a top-level *class* (not
26049 necessarly our "toplevel" container).
26051 2001-09-14 Ravi Pratap <ravi@ximian.com>
26053 * enum.cs (Enum::Define): Modify to call the Lookup method on the
26054 parent instead of a direct call to GetType.
26056 2001-09-14 Ravi Pratap <ravi@ximian.com>
26058 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
26059 Modifiers.TypeAttr. This should just be a call to that method.
26061 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
26062 object so that we can determine if we are top-level or not.
26064 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
26067 * enum.cs (Enum::Define): Ditto.
26069 * modifiers.cs (FieldAttr): Re-write.
26071 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
26072 (TypeContainer::HaveStaticConstructor): New property to provide access
26073 to precisely that info.
26075 * modifiers.cs (MethodAttr): Re-write.
26076 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
26078 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
26079 of top-level types as claimed.
26081 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26083 * expression.cs (MemberLookup): Fruitless attempt to lookup
26084 constructors. Maybe I need to emit default constructors? That
26085 might be it (currently .NET emits this for me automatically).
26086 (Invocation::OverloadResolve): Cope with Arguments == null.
26087 (Invocation::EmitArguments): new function, shared by the new
26088 constructor and us.
26089 (Invocation::Emit): Handle static and instance methods. Emit
26090 proper call instruction for virtual or non-virtual invocations.
26091 (New::Emit): Implement.
26092 (New::Resolve): Implement.
26093 (MemberAccess:Resolve): Implement.
26094 (MethodGroupExpr::InstanceExpression): used conforming to the spec
26095 to track instances.
26096 (FieldExpr::Resolve): Set type.
26098 * support.cs: Handle empty arguments.
26100 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
26101 SimpleLookup): Auxiliary routines to help parse a qualifier
26104 Update qualifier_identifier rule.
26106 * codegen.cs: Removed debugging messages.
26108 * class.cs: Make this a global thing, this acts just as a "key" to
26109 objects that we might have around.
26111 (Populate): Only initialize method_builders_to_methods once.
26113 * expression.cs (PropertyExpr): Initialize type from the
26116 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
26117 Resolve pattern. Attempt to implicitly convert value to boolean.
26120 * expression.cs: Set the type for the int32/int32 argument case.
26121 (Binary::ResolveOperator): Set the return type to boolean for
26122 comparission operators
26124 * typemanager.cs: Remove debugging print code.
26126 (Invocation::Resolve): resolve type.
26128 * class.cs: Allocate a MemberInfo of the correct size, as the code
26129 elsewhere depends on the test to reflect the correct contents.
26131 (Method::) Keep track of parameters, due to System.Reflection holes
26133 (TypeContainer::Populate): Keep track of MethodBuilders to Method
26136 (TypeContainer::FindMembers): Use ArrayList and then copy an array
26137 of the exact size and return that.
26139 (Class::LookupMethodByBuilder): New function that maps
26140 MethodBuilders to its methods. Required to locate the information
26141 on methods because System.Reflection bit us again.
26143 * support.cs: New file, contains an interface ParameterData and
26144 two implementations: ReflectionParameters and InternalParameters
26145 used to access Parameter information. We will need to grow this
26148 * expression.cs (Invocation::GetParameterData): implement a cache
26149 and a wrapper around the ParameterData creation for methods.
26150 (Invocation::OverloadResolve): Use new code.
26152 2001-09-13 Ravi Pratap <ravi@ximian.com>
26154 * class.cs (TypeContainer::EmitField): Remove and move into
26155 (Field::Define): here and modify accordingly.
26156 (Field.FieldBuilder): New member.
26157 (TypeContainer::Populate): Update accordingly.
26158 (TypeContainer::FindMembers): Implement.
26160 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26162 * statement.cs: (VariableInfo::VariableType): New field to be
26163 initialized with the full type once it is resolved.
26165 2001-09-12 Miguel de Icaza <miguel@ximian.com>
26167 * parameter.cs (GetParameterInfo): Use a type cache to compute
26168 things only once, and to reuse this information
26170 * expression.cs (LocalVariableReference::Emit): Implement.
26171 (OpcodeCast::Emit): fix.
26173 (ParameterReference::Resolve): Implement.
26174 (ParameterReference::Emit): Implement.
26176 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
26177 that are expressions need to stay as Expressions.
26179 * typemanager.cs (CSharpName): Returns the C# name of a type if
26182 * expression.cs (Expression::ConvertImplicit): New function that
26183 implements implicit type conversions.
26185 (Expression::ImplicitReferenceConversion): Implements implicit
26186 reference conversions.
26188 (EmptyCast): New type for transparent casts.
26190 (OpcodeCast): New type for casts of types that are performed with
26191 a sequence of bytecodes.
26193 (BoxedCast): New type used for casting value types into reference
26194 types. Emits a box opcode.
26196 (Binary::DoNumericPromotions): Implements numeric promotions of
26197 and computation of the Binary::Type.
26199 (Binary::EmitBranchable): Optimization.
26201 (Binary::Emit): Implement code emission for expressions.
26203 * typemanager.cs (TypeManager): Added two new core types: sbyte
26206 2001-09-12 Ravi Pratap <ravi@ximian.com>
26208 * class.cs (TypeContainer::FindMembers): Method which does exactly
26209 what Type.FindMembers does, only we don't have to use reflection. No
26210 implementation yet.
26212 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
26213 typecontainer objects as we need to get at them.
26214 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
26216 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
26217 typecontainer object.
26219 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
26220 of just a Report object.
26222 2001-09-11 Ravi Pratap <ravi@ximian.com>
26224 * class.cs (Event::Define): Go back to using the prefixes "add_" and
26226 (TypeContainer::Populate): Now define the delegates of the type too.
26227 (TypeContainer.Delegates): Property to access the list of delegates defined
26230 * delegates.cs (Delegate::Define): Implement partially.
26232 * modifiers.cs (TypeAttr): Handle more flags.
26234 2001-09-11 Ravi Pratap <ravi@ximian.com>
26236 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
26238 (Operator::Define): Re-write logic to get types by using the LookupType method
26239 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
26240 (Indexer::Define): Ditto.
26241 (Event::Define): Ditto.
26242 (Property::Define): Ditto.
26244 2001-09-10 Ravi Pratap <ravi@ximian.com>
26246 * class.cs (TypeContainer::Populate): Now define operators too.
26247 (TypeContainer.Operators): New property to access the list of operators
26249 (Operator.OperatorMethodBuilder): New member to hold the method builder
26250 for the operator we are defining.
26251 (Operator::Define): Implement.
26253 2001-09-10 Ravi Pratap <ravi@ximian.com>
26255 * class.cs (Event::Define): Make the prefixes of the accessor methods
26256 addOn_ and removeOn_
26258 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
26259 of the location being passed in too. Ideally, this should go later since all
26260 error reporting should be done through the Report object.
26262 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
26263 (Populate): Iterate thru the indexers we have and define them too.
26264 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
26265 for the get and set accessors.
26266 (Indexer::Define): Implement.
26268 2001-09-09 Miguel de Icaza <miguel@ximian.com>
26270 * expression.cs (Binary::Resolve): Beginning of it. I scratched
26271 my previous implementation, did not work.
26273 * typemanager.cs: Add a couple of missing types (the longs).
26275 * literal.cs: Use TypeManager.bool_type instead of getting it.
26277 * expression.cs (EventExpr): New kind of expressions.
26278 (Expressio::ExprClassFromMemberInfo): finish
26280 2001-09-08 Miguel de Icaza <miguel@ximian.com>
26282 * assign.cs: Emit stores to static fields differently.
26284 2001-09-08 Ravi Pratap <ravi@ximian.com>
26286 * Merge in changes and adjust code to tackle conflicts. Backed out my
26287 code in Assign::Resolve ;-)
26289 2001-09-08 Ravi Pratap <ravi@ximian.com>
26291 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
26292 instead Report.Error and also pass in the location.
26293 (CSharpParser::Lexer): New readonly property to return the reference
26294 to the Tokenizer object.
26295 (declare_local_variables): Use Report.Error with location instead of plain
26299 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
26300 (Operator.CheckBinaryOperator): Ditto.
26302 * cs-parser.jay (operator_declarator): Update accordingly.
26304 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
26305 (CheckBinaryOperator): Same here.
26307 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
26308 on the name without any prefixes of namespace names etc. This is because we
26309 already might have something already fully qualified like
26310 'System.Console.WriteLine'
26312 * assign.cs (Resolve): Begin implementation. Stuck ;-)
26314 2001-09-07 Ravi Pratap <ravi@ximian.com>
26316 * cs-tokenizer.cs (location): Return a string which also contains
26319 * expression.cs (ElementAccess): New class for expressions of the
26320 type 'element access.'
26321 (BaseAccess): New class for expressions of the type 'base access.'
26322 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
26325 * cs-parser.jay (element_access): Implement action.
26326 (base_access): Implement actions.
26327 (checked_expression, unchecked_expression): Implement.
26329 * cs-parser.jay (local_variable_type): Correct and implement.
26330 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
26332 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
26334 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
26335 name and the specifiers.
26337 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
26339 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
26340 making them all public ;-)
26342 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
26345 2001-09-07 Miguel de Icaza <miguel@ximian.com>
26347 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
26349 (FieldExpr, PropertyExprs): New resolved expressions.
26350 (SimpleName::MemberStaticCheck): Perform static checks for access
26351 to non-static fields on static methods. Maybe this should be
26352 generalized for MemberAccesses.
26353 (SimpleName::ResolveSimpleName): More work on simple name
26356 * cs-parser.jay (primary_expression/qualified_identifier): track
26357 the parameter index.
26359 * codegen.cs (CodeGen::Save): Catch save exception, report error.
26360 (EmitContext::EmitBoolExpression): Chain to expression generation
26361 instead of temporary hack.
26362 (::EmitStatementExpression): Put generic expression code generation.
26364 * assign.cs (Assign::Emit): Implement variable assignments to
26365 local variables, parameters and fields.
26367 2001-09-06 Miguel de Icaza <miguel@ximian.com>
26369 * statement.cs (Block::GetVariableInfo): New method, returns the
26370 VariableInfo for a variable name in a block.
26371 (Block::GetVariableType): Implement in terms of GetVariableInfo
26373 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
26374 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
26376 2001-09-06 Ravi Pratap <ravi@ximian.com>
26378 * cs-parser.jay (operator_declaration): Continue on my quest : update
26379 to take attributes argument.
26380 (event_declaration): Ditto.
26381 (enum_declaration): Ditto.
26382 (indexer_declaration): Ditto.
26384 * class.cs (Operator::Operator): Update constructor accordingly.
26385 (Event::Event): Ditto.
26387 * delegate.cs (Delegate::Delegate): Same here.
26389 * enum.cs (Enum::Enum): Same here.
26391 2001-09-05 Ravi Pratap <ravi@ximian.com>
26393 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
26395 * ../tests/cs0658.cs : New file to demonstrate error 0658.
26397 * attribute.cs (Attributes): New class to encapsulate all attributes which were
26398 being passed around as an arraylist.
26399 (Attributes::AddAttribute): Method to add attribute sections.
26401 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
26402 (struct_declaration): Update accordingly.
26403 (constant_declaration): Update.
26404 (field_declaration): Update.
26405 (method_header): Update.
26406 (fixed_parameter): Update.
26407 (parameter_array): Ditto.
26408 (property_declaration): Ditto.
26409 (destructor_declaration): Ditto.
26411 * class.cs (Struct::Struct): Update constructors accordingly.
26412 (Class::Class): Ditto.
26413 (Field::Field): Ditto.
26414 (Method::Method): Ditto.
26415 (Property::Property): Ditto.
26416 (TypeContainer::OptAttribute): update property's return type.
26418 * interface.cs (Interface.opt_attributes): New member.
26419 (Interface::Interface): Update to take the extra Attributes argument.
26421 * parameter.cs (Parameter::Parameter): Ditto.
26423 * constant.cs (Constant::Constant): Ditto.
26425 * interface.cs (InterfaceMemberBase): New OptAttributes field.
26426 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
26427 the attributes as a parameter.
26428 (InterfaceProperty): Update constructor call.
26429 (InterfaceEvent): Ditto.
26430 (InterfaceMethod): Ditto.
26431 (InterfaceIndexer): Ditto.
26433 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
26434 pass the attributes too.
26435 (interface_event_declaration): Ditto.
26436 (interface_property_declaration): Ditto.
26437 (interface_method_declaration): Ditto.
26438 (interface_declaration): Ditto.
26440 2001-09-05 Miguel de Icaza <miguel@ximian.com>
26442 * class.cs (Method::Define): Track the "static Main" definition to
26443 create an entry point.
26445 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
26446 EntryPoint if we find it.
26448 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
26449 (EmitContext::ig): Make this variable public.
26451 * driver.cs: Make the default output file be the first file name
26452 with the .exe extension.
26454 Detect empty compilations
26456 Handle various kinds of output targets. Handle --target and
26457 rename -t to --dumper.
26459 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
26460 methods inherited from Expression return now an Expression. This
26461 will is used during the tree rewriting as we resolve them during
26464 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
26465 the spec. Missing entirely is the information about
26466 accessability of elements of it.
26468 (Expression::ExprClassFromMemberInfo): New constructor for
26469 Expressions that creates a fully initialized Expression based on
26470 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
26473 (Invocation::Resolve): Begin implementing resolution of invocations.
26475 * literal.cs (StringLiteral): Implement Emit.
26477 2001-09-05 Ravi Pratap <ravi@ximian.com>
26479 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
26482 2001-09-04 Ravi Pratap <ravi@ximian.com>
26484 * cs-parser.jay (attribute_arguments): Implement actions.
26485 (attribute): Fix bug in production. Implement action.
26486 (attribute_list): Implement.
26487 (attribute_target): Implement.
26488 (attribute_target_specifier, opt_target_specifier): Implement
26489 (CheckAttributeTarget): New method to check if the attribute target
26491 (attribute_section): Implement.
26492 (opt_attributes): Implement.
26494 * attribute.cs : New file to handle attributes.
26495 (Attribute): Class to hold attribute info.
26497 * cs-parser.jay (opt_attribute_target_specifier): Remove production
26498 (attribute_section): Modify production to use 2 different rules to
26499 achieve the same thing. 1 s/r conflict down !
26500 Clean out commented, useless, non-reducing dimension_separator rules.
26502 * class.cs (TypeContainer.attributes): New member to hold list
26503 of attributes for a type.
26504 (Struct::Struct): Modify to take one more argument, the attribute list.
26505 (Class::Class): Ditto.
26506 (Field::Field): Ditto.
26507 (Method::Method): Ditto.
26508 (Property::Property): Ditto.
26510 * cs-parser.jay (struct_declaration): Update constructor call to
26511 pass in the attributes too.
26512 (class_declaration): Ditto.
26513 (constant_declaration): Ditto.
26514 (field_declaration): Ditto.
26515 (method_header): Ditto.
26516 (fixed_parameter): Ditto.
26517 (parameter_array): Ditto.
26518 (property_declaration): Ditto.
26520 * constant.cs (Constant::Constant): Update constructor similarly.
26521 Use System.Collections.
26523 * parameter.cs (Parameter::Parameter): Update as above.
26525 2001-09-02 Ravi Pratap <ravi@ximian.com>
26527 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
26528 (TypeContainer.delegates): New member to hold list of delegates.
26530 * cs-parser.jay (delegate_declaration): Implement the action correctly
26531 this time as I seem to be on crack ;-)
26533 2001-09-02 Miguel de Icaza <miguel@ximian.com>
26535 * rootcontext.cs (RootContext::IsNamespace): new function, used to
26536 tell whether an identifier represents a namespace.
26538 * expression.cs (NamespaceExpr): A namespace expression, used only
26539 temporarly during expression resolution.
26540 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
26541 utility functions to resolve names on expressions.
26543 2001-09-01 Miguel de Icaza <miguel@ximian.com>
26545 * codegen.cs: Add hook for StatementExpressions.
26547 * class.cs: Fix inverted test for static flag in methods.
26549 2001-09-02 Ravi Pratap <ravi@ximian.com>
26551 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26552 to make it coincide with MS' number.
26553 (Operator::CheckBinaryOperator): Ditto.
26555 * ../errors/errors.txt : Remove error numbers added earlier.
26557 * ../errors/cs1019.cs : Test case for error # 1019
26559 * ../errros/cs1020.cs : Test case for error # 1020
26561 * cs-parser.jay : Clean out commented cruft.
26562 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26563 used anywhere - non-reducing rule.
26564 (namespace_declarations): Non-reducing rule - comment out.
26566 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26567 with TypeContainer::AddEnum.
26569 * delegate.cs : New file for delegate handling classes.
26570 (Delegate): Class for declaring delegates.
26572 * makefile : Update.
26574 * cs-parser.jay (delegate_declaration): Implement.
26576 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26578 * class.cs (Event::Define): Implement.
26579 (Event.EventBuilder): New member.
26581 * class.cs (TypeContainer::Populate): Update to define all enums and events
26583 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26584 readonly fields for all these cases ?
26586 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26588 * class.cs (Property): Revamp to use the convention of making fields readonly.
26589 Accordingly modify code elsewhere.
26591 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26592 the Define method of the Property class.
26594 * class.cs : Clean up applied patch and update references to variables etc. Fix
26596 (TypeContainer::Populate): Update to define all the properties we have. Also
26597 define all enumerations.
26599 * enum.cs (Define): Implement.
26601 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26603 * cs-parser.jay (overloadable_operator): The semantic value is an
26604 enum of the Operator class.
26605 (operator_declarator): Implement actions.
26606 (operator_declaration): Implement.
26608 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26609 validity of definitions.
26610 (Operator::CheckBinaryOperator): Static method to check for binary operators
26611 (TypeContainer::AddOperator): New method to add an operator to a type.
26613 * cs-parser.jay (indexer_declaration): Added line to actually call the
26614 AddIndexer method so it gets added ;-)
26616 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26617 already taken care of by the MS compiler ?
26619 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26621 * class.cs (Operator): New class for operator declarations.
26622 (Operator::OpType): Enum for the various operators.
26624 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26626 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26627 ostensibly handle this in semantic analysis.
26629 * cs-parser.jay (general_catch_clause): Comment out
26630 (specific_catch_clauses, specific_catch_clause): Ditto.
26631 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26632 (catch_args, opt_catch_args): New productions.
26633 (catch_clause): Rewrite to use the new productions above
26634 (catch_clauses): Modify accordingly.
26635 (opt_catch_clauses): New production to use in try_statement
26636 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26637 and re-write the code in the actions to extract the specific and
26638 general catch clauses by being a little smart ;-)
26640 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26641 Hooray, try and catch statements parse fine !
26643 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26645 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26646 string from the hashtable of variables.
26648 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26649 I end up making that mistake ;-)
26650 (catch_clauses): Fixed gross error which made Key and Value of the
26651 DictionaryEntry the same : $1 !!
26653 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26655 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26657 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26658 when the add and remove accessors are specified.
26660 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26662 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26663 information about indexer_declarator.
26664 (indexer_declarator): Implement actions.
26665 (parsing_indexer): New local boolean used to keep track of whether
26666 we are parsing indexers or properties. This is necessary because
26667 implicit_parameters come into picture even for the get accessor in the
26668 case of an indexer.
26669 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26671 * class.cs (Indexer): New class for indexer declarations.
26672 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26673 (TypeContainer::indexers): New member to hold list of indexers for the
26676 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26678 * cs-parser.jay (add_accessor_declaration): Implement action.
26679 (remove_accessor_declaration): Implement action.
26680 (event_accessors_declaration): Implement
26681 (variable_declarators): swap statements for first rule - trivial.
26683 * class.cs (Event): New class to hold information about event
26685 (TypeContainer::AddEvent): New method to add an event to a type
26686 (TypeContainer::events): New member to hold list of events.
26688 * cs-parser.jay (event_declaration): Implement actions.
26690 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26692 * cs-parser.jay (dim_separators): Implement. Make it a string
26693 concatenating all the commas together, just as they appear.
26694 (opt_dim_separators): Modify accordingly
26695 (rank_specifiers): Update accordingly. Basically do the same
26696 thing - instead, collect the brackets here.
26697 (opt_rank_sepcifiers): Modify accordingly.
26698 (array_type): Modify to actually return the complete type string
26699 instead of ignoring the rank_specifiers.
26700 (expression_list): Implement to collect the expressions
26701 (variable_initializer): Implement. We make it a list of expressions
26702 essentially so that we can handle the array_initializer case neatly too.
26703 (variable_initializer_list): Implement.
26704 (array_initializer): Make it a list of variable_initializers
26705 (opt_array_initializer): Modify accordingly.
26707 * expression.cs (New::NType): Add enumeration to help us
26708 keep track of whether we have an object/delegate creation
26709 or an array creation.
26710 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26711 members to hold data about array creation.
26712 (New:New): Modify to update NewType
26713 (New:New): New Overloaded contructor for the array creation
26716 * cs-parser.jay (array_creation_expression): Implement to call
26717 the overloaded New constructor.
26719 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26721 * class.cs (TypeContainer::Constructors): Return member
26722 constructors instead of returning null.
26724 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26726 * typemanager.cs (InitCoreTypes): Initialize the various core
26727 types after we have populated the type manager with the user
26728 defined types (this distinction will be important later while
26729 compiling corlib.dll)
26731 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26732 on Expression Classification. Now all expressions have a method
26733 `Resolve' and a method `Emit'.
26735 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26736 generation from working. Also add some temporary debugging
26739 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26741 * codegen.cs: Lots of code generation pieces. This is only the
26742 beginning, will continue tomorrow with more touches of polish. We
26743 handle the fundamentals of if, while, do, for, return. Others are
26744 trickier and I need to start working on invocations soon.
26746 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26749 * codegen.cs (EmitContext): New struct, used during code
26750 emission to keep a context. Most of the code generation will be
26753 * cs-parser.jay: Add embedded blocks to the list of statements of
26754 this block. So code generation proceeds in a top down fashion.
26756 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26758 * statement.cs: Add support for multiple child blocks.
26760 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26762 * codegen.cs (EmitCode): New function, will emit the code for a
26763 Block of code given a TypeContainer and its ILGenerator.
26765 * statement.cs (Block): Standard public readonly optimization.
26766 (Block::Block constructors): Link children.
26767 (Block::Child): Child Linker.
26768 (Block::EmitVariables): Emits IL variable declarations.
26770 * class.cs: Drop support for MethodGroups here, delay until
26772 (Method::): Applied the same simplification that I did before, and
26773 move from Properties to public readonly fields.
26774 (Method::ParameterTypes): Returns the parameter types for the
26775 function, and implements a cache that will be useful later when I
26776 do error checking and the semantic analysis on the methods is
26778 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26779 and made a method, optional argument tells whether this is a class
26780 or a structure to apply the `has-this' bit.
26781 (Method::GetCallingConvention): Implement, returns the calling
26783 (Method::Define): Defines the type, a second pass is performed
26784 later to populate the methods.
26786 (Constructor::ParameterTypes): implement a cache similar to the
26787 one on Method::ParameterTypes, useful later when we do semantic
26790 (TypeContainer::EmitMethod): New method. Emits methods.
26792 * expression.cs: Removed MethodGroup class from here.
26794 * parameter.cs (Parameters::GetCallingConvention): new method.
26796 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26798 * class.cs (TypeContainer::Populate): Drop RootContext from the
26801 (Constructor::CallingConvention): Returns the calling convention.
26802 (Constructor::ParameterTypes): Returns the constructor parameter
26805 (TypeContainer::AddConstructor): Keep track of default constructor
26806 and the default static constructor.
26808 (Constructor::) Another class that starts using `public readonly'
26809 instead of properties.
26811 (Constructor::IsDefault): Whether this is a default constructor.
26813 (Field::) use readonly public fields instead of properties also.
26815 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26816 track of static constructors; If none is used, turn on
26817 BeforeFieldInit in the TypeAttributes.
26819 * cs-parser.jay (opt_argument_list): now the return can be null
26820 for the cases where there are no arguments.
26822 (constructor_declarator): If there is no implicit `base' or
26823 `this', then invoke the default parent constructor.
26825 * modifiers.cs (MethodAttr): New static function maps a set of
26826 modifiers flags into a MethodAttributes enum
26827 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26828 MethodAttr, TypeAttr to represent the various mappings where the
26829 modifiers are used.
26830 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26832 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26834 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26837 * interface.cs (PopulateIndexer): Implemented the code generator
26838 for interface indexers.
26840 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26842 * interface.cs (InterfaceMemberBase): Now we track the new status
26845 (PopulateProperty): Implement property population. Woohoo! Got
26846 Methods and Properties going today.
26848 Removed all the properties for interfaces, and replaced them with
26849 `public readonly' fields.
26851 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26853 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26854 initialize their hashtables/arraylists only when they are needed
26855 instead of doing this always.
26857 * parameter.cs: Handle refs and out parameters.
26859 * cs-parser.jay: Use an ArrayList to construct the arguments
26860 instead of the ParameterCollection, and then cast that to a
26863 * parameter.cs: Drop the use of ParameterCollection and use
26864 instead arrays of Parameters.
26866 (GetParameterInfo): Use the Type, not the Name when resolving
26869 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26871 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26872 and instead use public readonly fields.
26874 * class.cs: Put back walking code for type containers.
26876 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26878 * class.cs (MakeConstant): Code to define constants.
26880 * rootcontext.cs (LookupType): New function. Used to locate types
26883 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26885 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26886 this System.Reflection code is. Kudos to Microsoft
26888 * typemanager.cs: Implement a type cache and avoid loading all
26889 types at boot time. Wrap in LookupType the internals. This made
26890 the compiler so much faster. Wow. I rule!
26892 * driver.cs: Make sure we always load mscorlib first (for
26893 debugging purposes, nothing really important).
26895 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26896 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26898 * rootcontext.cs: Lookup types on their namespace; Lookup types
26899 on namespaces that have been imported using the `using' keyword.
26901 * class.cs (TypeContainer::TypeAttr): Virtualize.
26902 (Class::TypeAttr): Return attributes suitable for this bad boy.
26903 (Struct::TypeAttr): ditto.
26904 Handle nested classes.
26905 (TypeContainer::) Remove all the type visiting code, it is now
26906 replaced with the rootcontext.cs code
26908 * rootcontext.cs (GetClassBases): Added support for structs.
26910 2001-08-06 Miguel de Icaza <miguel@ximian.com>
26912 * interface.cs, statement.cs, class.cs, parameter.cs,
26913 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
26914 Drop use of TypeRefs, and use strings instead.
26916 2001-08-04 Miguel de Icaza <miguel@ximian.com>
26920 * class.cs (Struct::Struct): set the SEALED flags after
26921 checking the modifiers.
26922 (TypeContainer::TypeAttr): new property, returns the
26923 TypeAttributes for a class.
26925 * cs-parser.jay (type_list): Oops, list production was creating a
26926 new list of base types.
26928 * rootcontext.cs (StdLib): New property.
26929 (GetInterfaceTypeByName): returns an interface by type name, and
26930 encapsulates error handling here.
26931 (GetInterfaces): simplified.
26932 (ResolveTree): Encapsulated all the tree resolution here.
26933 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
26936 * driver.cs: Add support for --nostdlib, to avoid loading the
26937 default assemblies.
26938 (Main): Do not put tree resolution here.
26940 * rootcontext.cs: Beginning of the class resolution.
26942 2001-08-03 Miguel de Icaza <miguel@ximian.com>
26944 * rootcontext.cs: Provide better error reporting.
26946 * cs-parser.jay (interface_base): set our $$ to be interfaces.
26948 * rootcontext.cs (CreateInterface): Handle the case where there
26949 are no parent interfaces.
26951 (CloseTypes): Routine to flush types at the end.
26952 (CreateInterface): Track types.
26953 (GetInterfaces): Returns an array of Types from the list of
26954 defined interfaces.
26956 * typemanager.c (AddUserType): Mechanism to track user types (puts
26957 the type on the global type hash, and allows us to close it at the
26960 2001-08-02 Miguel de Icaza <miguel@ximian.com>
26962 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
26963 RecordInterface instead.
26965 * cs-parser.jay: Updated to reflect changes above.
26967 * decl.cs (Definition): Keep track of the TypeBuilder type that
26968 represents this type here. Not sure we will use it in the long
26969 run, but wont hurt for now.
26971 * driver.cs: Smaller changes to accomodate the new code.
26973 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
26976 * rootcontext.cs (CreateInterface): New method, used to create
26977 the System.TypeBuilder type for interfaces.
26978 (ResolveInterfaces): new entry point to resolve the interface
26980 (CodeGen): Property, used to keep track of the code generator.
26982 2001-07-26 Miguel de Icaza <miguel@ximian.com>
26984 * cs-parser.jay: Add a second production for delegate_declaration
26987 (enum_body): Put an opt_comma here instead of putting it on
26988 enum_body or enum_member_declarations so we can handle trailing
26989 commas on enumeration members. Gets rid of a shift/reduce.
26991 (type_list): Need a COMMA in the middle.
26993 (indexer_declaration): Tell tokenizer to recognize get/set
26995 * Remove old targets.
26997 * Re-add the parser target.
26999 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27001 * cs-parser.jay: Add precendence rules for a number of operators
27002 ot reduce the number of shift/reduce conflicts in the grammar.
27004 2001-07-17 Miguel de Icaza <miguel@ximian.com>
27006 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
27009 Get rid of old crufty code.
27011 * rootcontext.cs: Use this to keep track of the parsed
27012 representation and the defined types available to the program.
27014 * gen-treedump.cs: adjust for new convention.
27016 * type.cs: Split out the type manager, and the assembly builder
27019 * typemanager.cs: the type manager will live here now.
27021 * cil-codegen.cs: And the code generator here.
27023 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
27025 * makefile: Fixed up for easy making.
27027 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27029 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
27032 (unary_expression): Expand pre_increment_expression and
27033 post_decrement_expression to reduce a shift/reduce.
27035 2001-07-11 Simon Cozens
27037 * cs-tokenizer.cs: Hex numbers should begin with a 0.
27039 Improve allow_keyword_as_indent name.
27041 2001-06-19 Miguel de Icaza <miguel@ximian.com>
27043 * Adjustments for Beta2.
27045 2001-06-13 Miguel de Icaza <miguel@ximian.com>
27047 * decl.cs: Added `Define' abstract method.
27048 (InTransit): new property, used to catch recursive definitions.
27050 * interface.cs: Implement `Define'.
27052 * modifiers.cs: Map Modifiers.constants to
27053 System.Reflection.TypeAttribute flags.
27055 * class.cs: Keep track of types and user-defined types.
27056 (BuilderInit): New method for creating an assembly
27057 (ResolveType): New function to launch the resolution process, only
27058 used by interfaces for now.
27060 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
27061 that are inserted into the name space.
27063 2001-06-08 Miguel de Icaza <miguel@ximian.com>
27065 * ARGH. I have screwed up my tree so many times due to the use of
27066 rsync rather than using CVS. Going to fix this at once.
27068 * driver.cs: Objetify driver. Load assemblies, use assemblies to
27071 2001-06-07 Miguel de Icaza <miguel@ximian.com>
27073 * Experiment successful: Use System.Type rather that our own
27076 2001-05-25 Miguel de Icaza <miguel@ximian.com>
27078 * cs-parser.jay: Removed nsAliases from here.
27080 Use new namespaces, handle `using XXX;'
27082 * namespace.cs: Reimplemented namespace handling, use a recursive
27083 definition of the class. Now we can keep track of using clauses
27084 and catch invalid using clauses.
27086 2001-05-24 Miguel de Icaza <miguel@ximian.com>
27088 * gen-treedump.cs: Adapted for all the renaming.
27090 * expression.cs (Expression): this class now has a Type property
27091 which returns an expression Type.
27093 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
27094 `Type', as this has a different meaning now in the base
27096 2001-05-22 Miguel de Icaza <miguel@ximian.com>
27098 * interface.cs, class.cs: Removed from all the sources the
27099 references to signature computation, as we can not do method
27100 signature computation during the parsing time, as we are not
27101 trying to solve at that point distinguishing:
27105 void a (NS.Blah x) {}
27108 Which depending on the context might be valid or not, as we do not
27109 know if Blah is the same thing as NS.Blah at that point.
27111 * Redid everything so the code uses TypeRefs now instead of
27112 Types. TypeRefs are just temporary type placeholders, that need
27113 to be resolved. They initially have a pointer to a string and the
27114 current scope in which they are used. This is used later by the
27115 compiler to resolve the reference to an actual Type.
27117 * DeclSpace is no longer a CIR.Type, and neither are
27118 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
27119 are all DeclSpaces, but no Types.
27121 * type.cs (TypeRefManager): This implements the TypeRef manager,
27122 which keeps track of all the types that need to be resolved after
27123 the parsing has finished.
27125 2001-05-13 Miguel de Icaza <miguel@ximian.com>
27127 * ARGH. We are going to have to store `foreach' as a class rather
27128 than resolving it, as we need to verify error 1579 after name
27129 resolution. *OR* we could keep a flag that says `This request to
27130 IEnumerator comes from a foreach statement' which we can then use
27131 to generate the error.
27133 2001-05-10 Miguel de Icaza <miguel@ximian.com>
27135 * class.cs (TypeContainer.AddMethod): we now add methods to the
27136 MethodGroup instead of the method hashtable.
27138 * expression.cs: Add MethodGroup abstraction, which gets us one
27139 step closer to the specification in the way we handle method
27142 * cs-parser.jay (primary_expression): qualified_identifier now
27143 tried to match up an identifier to a local variable reference or
27144 to a parameter reference.
27146 current_local_parameters is now a parser global variable that
27147 points to the current parameters for the block, used during name
27150 (property_declaration): Now creates an implicit `value' argument to
27153 2001-05-09 Miguel de Icaza <miguel@ximian.com>
27155 * parameter.cs: Do not use `param' arguments as part of the
27156 signature, per the spec.
27158 2001-05-08 Miguel de Icaza <miguel@ximian.com>
27160 * decl.cs: Base class for classes, structs and interfaces. This
27161 is the "Declaration Space"
27163 * cs-parser.jay: Use CheckDef for checking declaration errors
27164 instead of having one on each function.
27166 * class.cs: Factor out some code for handling error handling in
27167 accordance to the "Declarations" section in the "Basic Concepts"
27168 chapter in the ECMA C# spec.
27170 * interface.cs: Make all interface member classes derive from
27171 InterfaceMemberBase.
27173 2001-05-07 Miguel de Icaza <miguel@ximian.com>
27175 * Many things: all interfaces are parsed and generated in
27176 gen-treedump. Support for member variables, constructors,
27177 destructors, properties, constants is there.
27179 Beginning of the IL backend, but very little done, just there for
27182 2001-04-29 Miguel de Icaza <miguel@ximian.com>
27184 * cs-parser.jay: Fix labeled statement.
27186 * cs-tokenizer.cs (escape): Escape " and ' always.
27187 ref_line, ref_name: keep track of the line/filename as instructed
27188 by #line by the compiler.
27191 2001-04-27 Miguel de Icaza <miguel@ximian.com>
27193 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
27194 to match the values in System.CodeDOM.
27196 Divid renamed to Divide.
27198 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
27200 (Statements.set): remove.
27202 * System.CodeDOM/CodeCatchClause.cs: always have a valid
27205 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
27206 falseStatements always have valid values.
27208 * cs-parser.jay: Use System.CodeDOM now.