1 2007-08-31 Marek Safar <marek.safar@gmail.com>
3 * generic.cs (TypeParameter): Uses common Emit.
4 (.IsClsComplianceRequired): Is never required.
6 2007-08-31 Marek Safar <marek.safar@gmail.com>
8 * cs-parser.jay: Terminates query block correctly. Fixed orderby
11 * generic.cs (TypeInferenceContext): Better error resistance.
13 * linq.cs: Implemented range variables, transparent identifiers and
16 2007-08-28 Marek Safar <marek.safar@gmail.com>
18 * cs-parser.jay: Anonymous type arguments can be simple name, syntax error
21 2007-08-23 Marek Safar <marek.safar@gmail.com>
23 * generic.cs (TypeInferenceV3.DoSecondPhase): Handle nested delegate
25 (IsTypeNonDependent, RemoveDependentTypes): Handle nested delegate
28 2007-08-21 Marek Safar <marek.safar@gmail.com>
30 * cs-parser.jay, linq.cs: Implemented orderby clause.
32 2007-08-20 Marek Safar <marek.safar@gmail.com>
34 * linq.cs: Switch to lambda expressions.
36 2007-08-20 Marek Safar <marek.safar@gmail.com>
38 * cs-parser.jay: An anonymous type can be empty.
40 2007-08-17 Marek Safar <marek.safar@gmail.com>
42 * linq.cs: MethodGroupExpr update.
44 2007-08-14 Marek Safar <marek.safar@gmail.com>
46 ** C# 3.0 Object and collection initializers
48 * cs-parser.jay: Grammar update.
50 2007-08-11 Marek Safar <marek.safar@gmail.com>
53 * generics.cs (TypeInferenceContext.LowerBoundInference): Don't
54 terminate type inference when an array is not paired.
56 2007-08-10 Miguel de Icaza <miguel@novell.com>
58 * generic.cs (DefaultValueExpression): Add CloneTo support to this
61 2007-08-09 Marek Safar <marek.safar@gmail.com>
63 ** C# 3.0 Anonymous Types (update to the latest standard)
65 * cs-parser.jay: Updated parameters and type names.
67 2007-08-03 Raja R Harinath <harinath@gmail.com>
69 * cs-parser.jay (class_declaration): Update to changes in class.cs.
70 Move calling of 'AddBasesForPart' to ...
71 (class_bases): ... here.
72 (struct_declaration, interface_declaration): Update to changes.
74 2007-08-02 Raja R Harinath <harinath@gmail.com>
76 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
77 * cs-parser.jay: Some whitespace cleanups.
78 (method_header): Refer to the correct symbol for parameters.
80 2007-08-01 Marek Safar <marek.safar@gmail.com>
83 * cs-parser.jay: Ignore partial keyword inside block expression.
85 2007-08-01 Marek Safar <marek.safar@gmail.com>
87 ** C# 3.0 Type Inference (major bits are working)
89 * generic.cs: Introduced new abstract class as an entry point to type
90 inference. Old type inference moved to TypeInferenceV2. Implemented C# 3.0
91 type inference as descibed in the standard in TypeInferenceV2 class.
93 * linq.cs (ALinqExpression): Disabled caching because it's wrong.
95 2007-07-25 Jb Evain <jbevain@novell.com>
97 * Makefile: don't install on net_2_1.
99 2007-07-18 Marek Safar <marek.safar@gmail.com>
101 * cs-parser.jay: Use ImplicitLambdaParameter everywhere.
103 2007-07-17 Marek Safar <marek.safar@gmail.com>
105 * cs-parser.jay: Correct placeholder for implicit linq parameter.
107 * linq: Add ImplicitArgument.
109 2007-07-03 Marek Safar <marek.safar@gmail.com>
111 * cs-parser.jay: Switch to ImplicitLambdaParameter.
113 2007-07-03 Marek Safar <marek.safar@gmail.com>
115 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
118 * linq.cs (QueryExpression.DoResolve): Resolve implicitly typed query
121 2007-06-20 Marek Safar <marek.safar@gmail.com>
123 * cs-parser.jay: Reworked var keyword handling. We cannot handle var as
124 static keyword because var becomes keyword only if no type with the var
125 name exists in the scope of variable which uses var declaration.
127 2007-06-18 Marek Safar <marek.safar@gmail.com>
129 * cs-parser.jay: Add implicitly typed local variable checks.
131 2007-06-15 Marek Safar <marek.safar@gmail.com>
133 * cs-parser.jay: Correctly split generic arguments and generic
134 parameters. Correctly implemented typeof of generic unbound types.
136 2007-06-14 Marek Safar <marek.safar@gmail.com>
138 * cs-parser.jay: Assembly and module attributes must precede all other
139 elements except using clauses and extern alias declarations.
141 2007-06-08 Marek Safar <marek.safar@gmail.com>
143 * cs-parser.jay: Uses newly defined GroupBy class.
145 * linq.cs (GroupBy): Implemented.
146 (AQueryClause.BuildQueryClause): Refactored to allow customize query
149 2007-06-08 Marek Safar <marek.safar@gmail.com>
151 * generics.cs (InferTypeArguments): Uses AnonymousMethodExpression
154 2007-06-06 Marek Safar <marek.safar@gmail.com>
156 * generics.cs (TypeArguments): New contructor fow known number of
159 2007-06-04 Raja R Harinath <rharinath@novell.com>
161 * linq.cs (Select.DoResolve): Pass the created parameters to the
164 2007-05-29 Raja R Harinath <rharinath@novell.com>
166 * cs-parser.jay: Update to changes in ToplevelBlock.
167 (top_current_block): Remove.
169 2007-05-27 Raja R Harinath <harinath@gmail.com>
171 * cs-parser.jay: Update to new ExplicitBlock invariant.
173 * cs-parser.jay: Update to changes introduced in Block and
176 2007-05-25 Raja R Harinath <rharinath@novell.com>
178 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
179 modifying current_block directly.
181 2007-05-22 Scott Peterson <lunchtimemama@gmail.com>
183 * cs-parser.jay: Implemented automatic properties (C# 3.0)
185 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
187 * cs-parser.jay: Improved grammar for object and collection
190 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
192 This code is contributed under the MIT X11 license
194 * cs-parser.jay: Added support for C# 3.0 language features:
195 Variable type inference (the "var" keyword)
198 Object initialization
199 Collection initialization
201 2007-05-06 Marek Safar <marek.safar@gmail.com>
204 * cs-parser.jay: Add special handling for coalescing operator.
206 2007-05-02 Raja R Harinath <rharinath@novell.com>
208 Fix regression in cs0631-3.cs
209 * cs-parser.jay (operator_declarator): Add opt_attributes to error
210 fallback. Make error fallback catch more cases.
212 2007-05-01 Miguel de Icaza <miguel@novell.com>
214 * cs-parser.jay: Allow parameters in operator declarations to have
217 2007-04-27 Miguel de Icaza <miguel@novell.com>
219 * generic.cs (TypeManager.LambdaInfer): now this routine will
220 make only one inference from the list of lambda expression that
221 have not participated in inferring a type.
223 (TypeManager.InferTypeArguments): The logic that drives the type
224 inference in lambda expressions is now driven here.
226 2007-04-23 Miguel de Icaza <miguel@novell.com>
228 * generic.cs: Large update to LambdaInfer, this is merely an
229 update to start the lambda type inference. It is by no means
230 complete. It is currently merely able to build a sample program
231 (with no iteration for the type parameters).
233 2007-04-12 Duncan Mak <duncan@a-chinaman.com>
235 * cs-parser.jay (interface_method_declaration_body): Fixed typo.
237 2007-04-08 Marek Safar <marek.safar@gmail.com>
239 * cs-parser.jay, linq.cs: First select implementation (hacky).
241 * generic.cs (InferTypeArguments): Simplified.
243 2007-03-31 Marek Safar <marek.safar@gmail.com>
245 * generic.cs (InferTypeArguments): Restored validation check.
246 (InferTypeArguments): Move all logic to Compatible method for re-usability.
248 2007-03-25 Marek Safar <marek.safar@gmail.com>
250 * generic.cs (InferTypeArguments): Infer arguments before they are used
251 for compatibility check.
253 2007-03-15 Marek Safar <marek.safar@gmail.com>
255 * generic.cs (InflatedConstraints): Fixed the check order.
256 (TypeArguments.Resolve): Small optimization for generic parameters.
257 (InferTypeArguments): Add infering support for anonymous methods.
259 2007-03-15 Martin Baulig <martin@ximian.com>
264 (TypeParameter.HasConstructorConstraint): Removed.
265 (ConstraintChecker.HasDefaultConstructor): Removed the
266 `TypeBuilder' argument here; correctly check for the ctor
267 constraint on type parameters.
269 2007-03-15 Martin Baulig <martin@ximian.com>
274 (TypeParameter): Create a `MemberCache' here as well. Note that
275 we need to create this on-demand when it's actually used.
277 2007-03-10 Marek Safar <marek.safar@gmail.com>
279 * generic.cs (TypeArguments.Resolve): Avoid redundant checks.
281 2007-03-09 Raja R Harinath <rharinath@novell.com>
283 * cs-parser.jay (WHERE): Move before QUERY_FIRST_TOKEN. 'where'
284 is a valid keyword outside a linq expression too.
286 2007-03-03 Marek Safar <marek.safar@gmail.com>
288 * cs-parser.jay: Implemented basic linq grammar.
290 * linq.cs: New file for hosting query specific classes.
292 2007-02-26 Marek Safar <marek.safar@gmail.com>
294 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
296 2007-02-20 Marek Safar <marek.safar@gmail.com>
299 * cs-parser.jay: Anonymous container starts at constructor declaration
300 and not at block beginning because it has to be usable in constructor
303 2007-02-18 Marek Safar <marek.safar@gmail.com>
305 A fix for bug #80493 by Atsushi Enomoto
306 * cs-parser.jay: Ignore invalid attribute target.
308 2007-02-15 Miguel de Icaza <miguel@novell.com>
310 * Remove the call to SetExpression for lambda expressions, we do
311 not actually need it.
313 Remove expression tracking code as its not needed.
315 2007-02-11 Miguel de Icaza <miguel@novell.com>
317 * cs-parser.jay (lambda_expression_body): when the body is an
318 expression add a statement of the form:
320 contextual-return expression.
322 Where `contextual-return' is similar to `return', the difference
323 being that if the delegate that the lambda will be converted to
324 has a void return type, it will check that the result is a
325 ExpressionStatement and the result is a plain ret (no return
326 values on the stack). If the return type of the delegate is of a
327 given type, this turns into a return with a value and does the
328 regular checking to check that the computed value can be
329 implicitly converted to the delegate return.
331 2007-01-30 Miguel de Icaza <miguel@novell.com>
333 * cs-parser.jay (anonymous_method_expression): move the
334 before/after productions to the start_anonymous and end_anonymous
335 methods so the code can be reused for lambda functions.
337 (lambda_expression_body): wrap expressions implicitly into a
340 (block): factor out the setup/teardown of parsing a block so we
341 can reuse that in lambda_expression_body
343 (lambda_expression): use new anonymous method helper methods.
345 2007-01-29 Miguel de Icaza <miguel@novell.com>
347 * cs-parser.jay: oob_stack make it static (am guessing that is why
348 we no longer initialize it anymore) and reuse it across
351 2007-01-28 Miguel de Icaza <miguel@novell.com>
353 * cs-parser.jay (open_parens): Introduce new non-terminal that
354 abstracts OPEN_PARENS and OPEN_PARENS_LAMBDA as the later can now
355 be returned in places where types are followed by identifiers
356 (this is expected in declaration, fixed, using, foreach and catch
359 Use open_parens in those places, keep OPEN_PARENS in the
362 cs-parser.jay: New grammar bits for parsing lambda expressions.
364 2007-01-28 Raja R Harinath <rharinath@novell.com>
366 Fix #80534, gtest-309.cs
367 * generic.cs (UnifyType): Rename from InferType. Make unification
368 of generic insts simpler and don't insist on inferring all generic
369 parameters in a single generic inst unification.
371 (InferGenericInstance): Remove.
372 Analysis and initial patch by David Mitchell <dmitchell@logos.com>.
374 2007-01-20 Marek Safar <marek.safar@gmail.com>
376 * cs-parser.jay: Better parameter error handling.
378 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
379 Raja R Harinath <rharinath@novell.com>
381 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
382 Note the order in which accessors are declared in the source.
384 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
386 * generic.cs (TypeParameter.FindMembers): Use the generic
387 constraints, not the constraints to check for methods (first fix
390 2006-12-30 Marek Safar <marek.safar@gmail.com>
392 * cs-parser.jay: Better syntax errors handling.
394 2006-11-21 Marek Safar <marek.safar@gmail.com>
396 * cs-parser.jay: Tiny change to work with mcs tokenizer.
398 * cs-tokenizer.cs: Remove after unification with mcs.
400 2006-10-28 Marek Safar <marek.safar@gmail.com>
403 * generic.cs (ConstructedType.AsAccessible): Check accessibility of type
406 2006-10-26 Marek Safar <marek.safar@gmail.com>
409 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous methods.
411 2006-10-25 Brian Crowell <brian@fluggo.com>
414 * generic.cs (CheckConstraints): Allow generic parameters with
415 inheritance constraints to satisfy reference type constraints.
417 2006-10-09 Martin Baulig <martin@ximian.com>
420 (NullCoalescingOperator.DoResolve): Fix #78964; added gtest-294.cs.
422 2006-09-25 Martin Baulig <martin@ximian.com>
424 * class.cs: Remove after unification with mcs source.
426 2006-09-24 Raja R Harinath <harinath@gmail.com>
428 * convert.cs: Remove after unification with mcs source.
430 2006-09-24 Marek Safar <marek.safar@seznam.cz>
432 * class.cs (MemberBase.VerifyClsCompliance): When method has type
433 parameters verify them as well.
435 * generic.cs (Constraints.VerifyClsCompliance): Verify CLS-Compliance of
436 the type parameter constraints.
437 (Generics.VerifyClsCompliance): Ditto.
439 2006-09-24 Marek Safar <marek.safar@seznam.cz>
441 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
442 for anonymous block with out argument.
444 2006-09-24 Marek Safar <marek.safar@seznam.cz>
446 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
447 not used private events only.
449 2006-09-23 Marek Safar <marek.safar@seznam.cz>
451 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
453 * cs-parser.jay: Parse correctly cast of default (T).
455 * generic.cs (DefaultValueExpression.DoResolve): Check for void type.
456 Store original type via EmptyConstantCast.
458 2006-09-22 Martin Baulig <martin@ximian.com>
460 * delegate.cs: Removed; this file is now shared with mcs.
462 * attribute.cs: Removed; this file is now shared with mcs.
464 2006-09-22 Martin Baulig <martin@ximian.com>
466 * ecore.cs: Removed; this file is now shared with mcs.
468 2006-09-21 Marek Safar <marek.safar@seznam.cz>
470 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
472 * ecore.cs (NullCast): Derives from NullConstant.
474 * generic.cs (DefaultValueExpression): Fixed to cope with the constant
477 2006-09-21 Martin Baulig <martin@ximian.com>
479 * decl.cs: Removed; this file is now shared with mcs.
481 2006-09-21 Raja R Harinath <rharinath@novell.com>
483 * rootcontext.cs: Remove after unification with mcs source.
485 * report.cs: Remove after unification with mcs source.
486 * generic.cs (AddTypeParameter, LookupTypeParameter): Move to
488 (InitGenerics, CleanUpGenerics): Remove.
490 * support.cs: Remove after unification with mcs source.
492 2006-09-20 Raja R Harinath <rharinath@novell.com>
494 * codegen.cs: Remove after unification with mcs source.
496 2006-09-19 Martin Baulig <martin@ximian.com>
498 * expression.cs: Removed; this file is now shared with mcs.
500 2006-09-19 Martin Baulig <martin@ximian.com>
503 (TypeManager.IsEqual): Moved into ../mcs/typemanager.cs.
504 (TypeManager.DropGenericTypeArguments): Likewise.
505 (TypeManager.DropGenericMethodArguments): Likewise.
506 (TypeManager.GetTypeArguments): Likewise.
507 (TypeManager.HasGenericArguments): Likewise.
509 2006-09-19 Martin Baulig <martin@ximian.com>
511 * ecore.cs (PropertyExpr.InstanceResolve): Fix the CS1540 check.
513 2006-09-19 Martin Baulig <martin@ximian.com>
515 * typemanager.cs: Removed; this file is now shared with mcs.
517 2006-09-16 Raja R Harinath <rharinath@novell.com>
519 * Makefile (LOCAL_MCS_FLAGS): Use instead of PROFILE_MCS_FLAGS.
520 * AssemblyInfo.cs, driver.cs: Remove after unification with mcs source.
522 2006-09-16 Marek Safar <marek.safar@seznam.cz>
525 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
526 only if parent type is class.
527 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
530 2006-09-15 Marek Safar <marek.safar@seznam.cz>
533 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
535 * typemanager.cs(CSharpName): Converts NullType to null.
537 2006-09-15 Martin Baulig <martin@ximian.com>
539 * pending.cs: Removed; this file is now shared with mcs.
541 2006-09-15 Martin Baulig <martin@ximian.com>
543 * statement.cs: Removed; this file is now shared with mcs.
545 2006-09-15 Martin Baulig <martin@ximian.com>
547 * rootcontext.cs (RootContext.BrokenCircularDeps): Removed.
549 * driver.cs: Removed the `--broken-cycles' argument.
551 2006-09-15 Martin Baulig <martin@ximian.com>
553 * namespace.cs: Removed; this file is now shared with mcs.
555 2006-09-15 Martin Baulig <martin@ximian.com>
557 * decl.cs (MemberName): Minor code cleanups.
559 2006-09-15 Martin Baulig <martin@ximian.com>
561 * parameter.cs: Removed; this file is now shared with mcs.
563 2006-09-15 Martin Baulig <martin@ximian.com>
565 * enum.cs: Removed; this file is now shared with mcs.
567 2006-09-15 Martin Baulig <martin@ximian.com>
569 * Makefile: Define `GMCS_SOURCE'.
571 * flowanalysis.cs: Removed; this file is now shared with mcs.
573 2006-09-15 Martin Baulig <martin@ximian.com>
575 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
576 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
577 doc.cs - they are now shared with mcs.
579 * gmcs.exe.sources: Include these files from ../mcs/.
581 2006-09-15 Martin Baulig <martin@ximian.com>
583 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
584 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
586 2006-09-14 Marek Safar <marek.safar@seznam.cz>
588 * assign.cs, ecore.cs, expression.cs: Share error message text.
589 * class.cs (FieldMember.Define): Check for variable of static type.
590 * decl.cs (check_type_parameter): Report correct type name.
591 * driver.cs (LoadAssembly): Uses error output for errors.
592 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
593 (TypeArguments.Resolve): Static class cannot be used as an argument.
594 * statement.cs (ResolveMeta): Constants cannot be generic types.
596 2006-09-12 Martin Baulig <martin@ximian.com>
598 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
600 * convert.cs (Convert.Array_To_IList): Moved here and correctly
601 implement it; fixes #79345.
603 2006-09-08 Marek Safar <marek.safar@seznam.cz>
605 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
607 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
609 * generic.cs: Improved error messages.
610 * typemanager.cs (RemoveGenericArity): Made public.
612 2006-09-08 Martin Baulig <martin@ximian.com>
614 * typemanager.cs (TypeManager.interlocked_type): New public field.
615 (TypeManager.int_interlocked_compare-exchange): New public field.
616 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
617 enumerator types here and call InitGenericCoreTypes().
618 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
619 after calling InitEnumUnderlyingTypes().
622 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
623 `classes_second_stage'.
625 2006-09-07 Marek Safar <marek.safar@seznam.cz>
627 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
629 * statement.cs (Block.Variables): Made public.
631 2006-09-07 Martin Baulig <martin@ximian.com>
634 (MainDriver): Revert r62663 from Marek; see #70506 for details.
636 2006-09-01 Martin Baulig <martin@ximian.com>
639 (TypeManager.IsIList): Also handle base classes and interfaces.
641 2006-09-01 Raja R Harinath <rharinath@novell.com>
644 * expression.cs (Invocation.MoreSpecific): Check for reference
647 2006-08-29 Miguel de Icaza <miguel@novell.com>
649 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
651 2006-08-17 Miguel de Icaza <miguel@novell.com>
653 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
654 #52019 and #79064, the use of the \uXXXX sequence in source code
655 to represent unicode characters.
657 2006-08-15 Marek Safar <marek.safar@seznam.cz>
659 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
661 * class.cs, ecore.cs, statement.cs: Merged to one error message.
663 2006-08-14 Raja R Harinath <rharinath@novell.com>
666 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
667 parameter too. This only avoids a parse error -- the semantic
668 error is caught elsewhere.
670 2006-08-13 Miguel de Icaza <miguel@novell.com>
672 * assign.cs: Catch attempts to assign to a method groups in += and
675 2006-08-13 Marek Safar <marek.safar@seznam.cz>
678 * cs-parser.jay: Don't destroy current array type by typeof of array's.
680 2006-08-12 Marek Safar <marek.safar@seznam.cz>
682 * cs-parser.jay: Check whether a constraint clause has already been
683 specified for type parameter.
684 * generic.cs (Constraints): Exposed location.
686 2006-08-12 Marek Safar <marek.safar@seznam.cz>
688 * class.cs (Method.Define): Issue a warning when generic method looks like
690 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
692 * report.cs: New warning number.
694 2006-08-09 Marek Safar <marek.safar@seznam.cz>
696 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
698 * decl.cs (MemberCache.FindMembers): When container is interface we need to
699 search all base interfaces as a member can be ambiguous.
700 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
701 Constructor member type filter.
702 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
703 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
704 reporting for returned memberinfos.
705 * report.cs: Updated.
706 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
707 version to work on all runtimes.
708 (TypeManager.RealMemberLookup): Removed members filtering.
710 2006-08-08 Raja R Harinath <rharinath@novell.com>
712 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
713 (PropertyExpr.EmitAssign): Likewise.
714 * expression.cs (Indirection.EmitAssign): Likewise.
715 (LocalVariableReference.EmitAssign): Likewise.
716 (ParameterReference.EmitAssign): Likewise.
717 (Invocation.EmitArguments): Likewise.
718 (ArrayAccess.EmitAssign): Likewise.
719 (IndexerAccess.EmitAssign): Likewise.
720 (This.EmitAssign): Likewise.
721 (ConditionalLogicalOperator.Emit): Likewise.
724 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
725 instead of ArrayList. If the hashtable has a LocalBuilder, don't
726 leave it in after returning it.
727 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
729 2006-08-06 Marek Safar <marek.safar@seznam.cz>
731 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
734 2006-08-05 Marek Safar <marek.safar@seznam.cz>
736 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
737 with different type names.
738 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
740 2006-08-03 Raja R Harinath <rharinath@novell.com>
742 Fix cs0146-3.cs and cs0146-4.cs.
743 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
744 enclosing types don't depend on the current type.
746 2006-08-02 Raja R Harinath <rharinath@novell.com>
749 * class.cs (TypeContainer.DoDefineMembers): Use
750 FindBaseMemberWithSameName on Parent, since we're interested in
751 whether we hide inherited members or not.
752 (FindBaseMemberWithSameName): Make slightly more robust.
755 * codegen.cs (IResolveContext.GenericDeclContainer): New.
756 (EmitContext): Implement new interface requirement.
757 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
758 * decl.cs (MemberCore): Likewise.
759 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
760 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
761 ec.GenericDeclContainer to check for generic parameters.
762 (SimpleName.DoSimpleNameResolve): Likewise.
763 * generic.cs (TypeParameter.DeclContainer): Remove override.
765 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
766 declspaces for doppelgangers too.
767 (UsingEntry): Implement IResolveContext.
768 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
769 'this' as the resolve context.
770 (LocalAliasEntry): Likewise.
772 Implement parts of #77403
773 * roottypes.cs (RootDeclSpace): New. Used to represent the
774 toplevel declaration space. Each namespace declaration introduces
775 a "partial" root declaretion space.
776 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
777 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
778 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
779 from 'current_namespace.SlaveDeclSpace'.
780 (namespace_declaration): Likewise.
781 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
782 check. It can't happen now.
783 * decl.cs (DeclSpace.LookupType): Likewise.
784 * driver.cs (MainDriver): Sanity check.
786 2006-08-01 Raja R Harinath <rharinath@novell.com>
788 * decl.cs (DeclSpace.FindNestedType): Remove.
789 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
790 LookupTypeContainer to get the container of the nested type.
791 * class.cs (TypeContainer.FindNestedType): Make non-override.
793 2006-07-31 Raja R Harinath <rharinath@novell.com>
795 * decl.cs (DeclSpace.PartialContainer): Move field from ...
796 * class.cs (TypeContainer.PartialContainer): ... here.
797 (TypeContainer.AddBasesForPart): New helper.
798 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
800 * cs-parser.jay (current_class): Convert to DeclSpace.
801 (struct_declaration, interface_declaration, class_declaration):
802 Use AddBasesForPart instead of .Bases directly.
803 * const.cs, iterators.cs: Update to changes.
805 2006-07-28 Raja R Harinath <rharinath@novell.com>
807 * class.cs (TypeContainer.AddMemberType): Rename from
809 (TypeContainer.AddMember): Rename from AddToMemberContainer.
810 (AddTypeContainer): New. Combine AddClassOrStruct and
812 (AddPartial): Update. Add 'is_partial' argument.
813 * roottypes.cs: Update to changes.
814 * cs-parser.jay (push_current_class): New helper for handling
815 current_container and current_class.
816 (struct_declaration, interface_declaration, class_declaration):
819 2006-07-26 Raja R Harinath <rharinath@novell.com>
821 * roottypes.cs: Rename from tree.cs.
823 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
824 * tree.cs (Tree, ITreeDump): Remove types.
825 * rootcontext.cs (tree, Tree): Remove fields.
826 (root, ToplevelTypes): New.
827 * *.cs: Update to rename.
829 * tree.cs (Tree.RecordDecl): Remove.
830 (RootTypes.AddToTypeContainer): Record the toplevel type in its
832 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
834 2006-07-23 Raja R Harinath <harinath@gmail.com>
836 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
837 DoFlowAnalysis and OmitStructFlowAnalysis here.
838 (ec.With): Rename from WithUnsafe and generalize.
839 (ec.WithCheckState): Remove. All users can be handled by 'With'.
840 (ec.WithFlowAnalyis): New.
841 * ecore.cs, expression.cs, statement.cs: Update.
843 2006-07-22 Raja R Harinath <harinath@gmail.com>
845 * statement.cs (Block.ResolveMeta): Simplify slightly.
847 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
848 multiple boolean fields. Convert InUnsafe, constant_check_state,
849 check_state to flags.
850 (CheckState, ConstantCheckState): Update.
851 (InUnsafe): New read-only property.
852 (FlagsHandle): Rename from CheckStateHandle and convert to handle
854 (WithUnsafe): New helper similar to WithCheckState.
855 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
856 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
858 2006-07-21 Raja R Harinath <rharinath@novell.com>
860 Make comparisons use the same IL irrespective of whether they're
861 in a 'checked' or 'unchecked' context: one of the issues in #78899
862 * codegen.cs (EmitContext.CheckState): Make read-only property.
863 (EmitContext.ConstantCheckState): Likewise.
864 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
865 helper that implement a save/restore stack for CheckState
866 values. This is the only way to change check-state.
867 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
868 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
869 (CheckedExpr.EmitBranchable): New forwarding method.
870 (UnCheckedExpr): Likewise.
871 * statement.cs (Block.ResolveMeta): Use WithCheckState.
872 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
873 (Checked.Resolve, checked.DoEmit): Likewise.
875 2006-07-21 Martin Baulig <martin@ximian.com>
877 * generic.cs (TypeManager.InferType): When inferring an array
878 type, also allow IList<T> and ICollection<T>. Fixes #78900.
880 2006-07-21 Martin Baulig <martin@ximian.com>
882 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
883 and allow IList`1 and all its base interfaces.
885 * convert.cs (Convert.ImplicitReferenceConversion): Allow
886 converting from an array-type of T to IList<T>.
888 2006-07-21 Martin Baulig <martin@ximian.com>
890 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
892 2006-07-20 Miguel de Icaza <miguel@novell.com>
894 * anonymous.cs: Cache the resolved anonymous delegate, and return
895 this so that the ResolveTopBlock is only triggered once, not
898 Currently we trigger ResolvetopBlock twice due to a first pass of
899 argument check compatibility, and a second pass that does the
902 2006-07-15 Marek Safar <marek.safar@seznam.cz>
904 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
906 * rootcontext.cs (Reset): Add helper_classes.
908 2006-07-15 Marek Safar <marek.safar@seznam.cz>
911 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
914 2006-07-13 Miguel de Icaza <miguel@novell.com>
916 * statement.cs (Lock): Handle expressions of type
917 TypeManager.null_type specially. Fixes #78770
919 2006-07-08 Marek Safar <marek.safar@seznam.cz>
921 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
924 2006-07-08 Marek Safar <marek.safar@seznam.cz>
926 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
927 for accessors as well.
928 * ecore.cs (EventExpr): Add AccessorTable.
930 2006-07-03 Martin Baulig <martin@ximian.com>
932 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
933 instances of value types.
935 * convert.cs (Convert.ExplicitConversion): Correctly handle
936 object->nullable conversions.
938 2006-07-01 Marek Safar <marek.safar@seznam.cz>
941 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
942 for CS0122 where appropriate.
943 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
945 (Filter): Assembly can be null in the case of top level attributes.
947 2006-06-28 Raja R Harinath <rharinath@novell.com>
950 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
951 no arguments, return 'false': nothing can be inferred.
953 2006-06-25 Marek Safar <marek.safar@seznam.cz>
957 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
958 is done at global level.
960 2006-06-24 Marek Safar <marek.safar@seznam.cz>
962 A fix for #77002, Implemented TypeForwarder support.
964 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
965 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
967 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
968 * typemanager.cs (): Add type_forwarder_attr_type.
970 2006-06-24 Marek Safar <marek.safar@seznam.cz>
972 * report.cs: Add CS0469 warning.
974 2006-06-22 Martin Baulig <martin@ximian.com>
977 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
978 for interfaces; fixes #78686, which is a modification of #78380
979 with interfaces instead of classes.
981 2006-06-21 Martin Baulig <martin@ximian.com>
983 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
984 the `try'-block, so we also report CS0016 etc. there.
986 2006-06-21 Martin Baulig <martin@ximian.com>
988 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
989 handle SetAssigned() and SetMemberIsUsed() for generic types;
992 2006-06-21 Martin Baulig <martin@ximian.com>
995 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
997 2006-06-21 Martin Baulig <martin@ximian.com>
999 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
1000 also report CS1686 for parameters.
1002 2006-06-21 Martin Baulig <martin@ximian.com>
1004 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
1005 instead of an error if the value is not implicitly convertible to
1006 the switch types; fixes #77964.
1008 2006-06-21 Raja R Harinath <rharinath@novell.com>
1011 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
1012 FieldBuilder is null.
1015 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
1016 'left' and 'right' before error-checking.
1018 2006-06-19 Martin Baulig <martin@ximian.com>
1021 (Convert.ImplicitConversionStandard): Cleanup and correctly
1022 implement nullable conversions.
1023 (Convert.ImplicitStandardConversionExists): Likewise.
1024 (Convert.ExplicitConversion): Likewise.
1026 2006-06-19 Martin Baulig <martin@ximian.com>
1029 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
1030 methods; make the ctors protected.
1032 2006-06-19 Martin Baulig <martin@ximian.com>
1034 Fixed #78380; added gtest-273.cs.
1037 (Expression.ResolveAsBaseTerminal): Move the constraint checking
1038 into ResolveAsTypeTerminal().
1041 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
1042 TypeManager.FindMembers() to check for the default ctor.
1044 2006-06-18 Marek Safar <marek.safar@seznam.cz>
1046 * generic.cs: Fixed NullableInfo accessibility.
1048 2006-06-16 Martin Baulig <martin@ximian.com>
1051 (Constraints.InflatedConstraints.inflate): Correctly inflate
1052 generic types; fixes #78400.
1054 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
1056 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
1058 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
1059 (FieldExpr.DoResolve): likewise.
1060 (PropertyExpr.InstanceResolve): likewise.
1061 (EventExpr.InstanceResolve): likewise.
1063 2006-06-15 Martin Baulig <martin@ximian.com>
1066 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
1067 argument; always allow a `null' label if true.
1068 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
1069 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
1070 we have a `null' label and mark the new `null_target' label;
1071 default to the `default' label.
1072 (Switch.Resolve): Add support for nullable types. Fixes #78630.
1074 2006-06-15 Martin Baulig <martin@ximian.com>
1076 * class.cs (Operator.Define): Allow an implicit/explicit operator
1077 to convert to/from a nullable value of the enclosing type.
1079 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
1080 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
1083 (Convert.ImplicitStandardConversionExists): Add support for lifted
1084 implicit/explicit conversions.
1085 (Convert.ImplicitConversionStandard): Likewise.
1087 2006-06-13 Martin Baulig <martin@ximian.com>
1089 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
1090 type arguments and create a ConstructedType if necessary. Fixes #78400.
1092 2006-06-04 Marek Safar <marek.safar@seznam.cz>
1094 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
1095 attribute applicable tests for attribute argument.
1097 2006-06-02 Raja R Harinath <rharinath@novell.com>
1100 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
1101 (Binary.OverloadResolve_PredefinedIntegral): New.
1102 (Binary.OverloadResolve_PredefinedFloating): New.
1103 (Binary.OverloadResolve_PredefinedString): New.
1104 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
1105 Follow the standard more closely, and treat numeric promotions in
1106 terms of overload resolution.
1107 (Binary.CheckShiftArguments): Simplify.
1109 2006-06-01 Raja R Harinath <rharinath@novell.com>
1111 * flowanalysis.cs (MyBitVector): Simplify representation.
1112 (MyBitVector.Clone): Avoid allocating BitArray.
1113 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
1114 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
1115 (*): Update. Change all references to MyBitVector.And and
1116 MyBitVector.Or to &= and |=.
1118 2006-05-31 Raja R Harinath <rharinath@novell.com>
1120 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
1121 Use bne.un instead of ceq+brfalse.
1124 * typemanager.cs (IsUnmanagedType): Disallow generic types and
1127 2006-05-29 Raja R Harinath <rharinath@novell.com>
1130 * cs-parser.jay (formal_parameter_list): Extend the pattern below
1131 to param arguments too.
1133 2006-05-26 Miguel de Icaza <miguel@novell.com>
1135 * cs-parser.jay: Catch another parsing form for arglist being
1136 followed by other arguments. Fixes #78313.
1138 2006-05-25 Raja R Harinath <rharinath@novell.com>
1141 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
1142 also when one of the operands is a null literal.
1143 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
1144 to improve clarity, and generate slightly better code.
1146 2006-05-24 Raja R Harinath <rharinath@novell.com>
1148 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
1149 checking of out parameters to ...
1150 (FlowBranchingToplevel.Merge): ... here.
1151 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
1152 set, propagate the origin upward, and only complain if there was
1154 (FlowBranchingException.AddContinueOrigin): Likewise.
1155 (FlowBranchingException.AddReturnOrigin): Likewise.
1156 (FlowBranchingException.AddGotoOrigin): Likewise.
1158 2006-05-23 Raja R Harinath <rharinath@novell.com>
1160 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
1161 unreachable, skip it.
1162 (FlowBranchingException.Merge): Always propagate jumps, even if
1163 the finally block renders subsequent code unreachable.
1165 2006-05-18 Raja R Harinath <rharinath@novell.com>
1168 * statement.cs (Goto.Resolve): Move responsibility for resolving
1169 'goto' to FlowBranching.AddGotoOrigin.
1170 (Goto.SetResolvedTarget): New. Callback to set the
1171 LabeledStatement that's the target of the goto.
1172 (Goto.DoEmit): Use Leave instead of Br when crossing an
1173 unwind-protect boundary.
1174 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
1175 LookupLabel and adjust to new semantics.
1176 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
1177 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
1178 Goto.SetResolvedTarget to update target.
1179 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
1180 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
1181 AddBreakOrigin & co. Delay propagation until ...
1182 (FlowBranchingException.Merge): ... this.
1184 * statement.cs (Block.Resolve): Always depend on flow-branching to
1185 determine unreachability. Kill workaround that originally emitted
1186 only one statement after an "unreachable" label (see infloop in
1189 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
1190 This is still "wrong", but anything better would probably need a
1191 multi-pass algorithm.
1192 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
1193 usage vector. Force current usage vector to be reachable, to
1194 optimistically signify backward jumps.
1195 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
1197 (FlowBranchingLabeled.Merge): New. If no backward jump was
1198 detected, return the original salted-away usage vector instead,
1199 updated with appropriate changes. Print unreachable warning if
1201 * statement.cs (Block.Resolve): Don't print unreachable warning on
1202 a labeled statement.
1204 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
1206 * driver.cs: Pass filename without path to AssemblyBuilder's
1207 AddResourceFile. Fixes bug #78407.
1209 2006-05-17 Raja R Harinath <rharinath@novell.com>
1211 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
1212 * flowanalysis.cs (FlowBranchingLabeled): ... here.
1213 (FlowBranching.MergeChild): Overwrite
1214 reachability information from Labeled branchings too.
1216 2006-05-16 Raja R Harinath <rharinath@novell.com>
1218 * statement.cs (Goto.Resolve): Merge jump origins here ...
1219 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
1221 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
1222 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
1223 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
1224 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
1226 * statement.cs (Goto.Resolve): ... not here.
1227 (Goto.Emit): Remove CS1632 check.
1229 2006-05-14 Marek Safar <marek.safar@seznam.cz>
1231 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
1234 2006-05-11 Raja R Harinath <rharinath@novell.com>
1236 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
1237 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
1238 (FlowBranchingException.Label): Likewise.
1240 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
1242 (MyBitVector.Or): Use it to avoid losing information (Count).
1243 (FlowBranching.MergeOrigins): Likewise.
1245 * flowanalysis.cs (UsageVector.IsDirty): Remove.
1246 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
1247 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
1248 (UsageVector.ToString): Simplify.
1249 (UsageVector.MergeSiblings): Move here from ...
1250 (FlowBranching.Merge): ... here.
1251 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
1254 2006-05-10 Raja R Harinath <rharinath@novell.com>
1256 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
1257 null bitvector is treated as all-true.
1259 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
1260 (MyBitVector): Rationalize invariants. 'vector != null' implies
1261 that we have our own copy of the bitvector. Otherwise,
1262 'InheritsFrom == null' implies all inherited bits are true.
1264 2006-05-09 Marek Safar <marek.safar@seznam.cz>
1266 * statement.cs (LocalInfo): Add IsConstant.
1267 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
1268 local variable for constants.
1270 2006-05-09 Raja R Harinath <rharinath@novell.com>
1272 * flowanalysis.cs (MyBitVector.Empty): New.
1273 (MyBitVector): Don't allow InheritedFrom to be null.
1274 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
1275 (UsageVector, FlowBranching): Update to changes.
1277 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
1278 recursion. The 'Parent == null' condition isn't sufficient for
1280 (FlowBranching.AddBreakOrigin): Likewise.
1281 (FlowBranching.AddContinueOrigin): Likewise.
1282 (FlowBranching.AddReturnOrigin): Likewise.
1283 (FlowBranching.StealFinallyClauses): Likewise.
1284 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
1285 (FlowBranching.CheckOutParameters): Likewise.
1286 (FlowBranchingToplevel): Terminate all the above recursions here.
1287 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
1288 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
1290 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
1292 (FlowBranchingToplevel): New. Empty for now.
1293 (FlowBranching.MergeTopBlock): Update.
1294 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
1295 branching for the anonymous delegate.
1296 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
1298 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
1299 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
1300 information at the start of the merge. Reorganize.
1302 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1304 * class.cs (MethodData.Define): Method cannot implement interface accessor.
1306 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1308 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
1309 to newly introduced ctor.
1311 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
1312 message to one place.
1313 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
1316 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1318 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
1320 * ecore.cs (Expression.ResolveAsConstant): Updated.
1322 * statement.cs (ResolveMeta): Updated.
1324 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1326 * cs-parser.jay: __arglist cannot be used in initializer.
1328 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1331 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
1334 2006-05-05 Raja R Harinath <rharinath@novell.com>
1336 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
1337 (LabeledStatement): Add 'name' parameter.
1338 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
1339 (Block.AddLabel): Update to changes.
1340 * cs-parser.jay (labeled_statement): Likewise.
1342 * flowanalysis.cs (BranchingType.Labeled): New.
1343 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
1344 (FlowBranchingLabeled): New. Does nothing for now, but will
1345 eventually handle 'goto' flows.
1346 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
1347 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
1348 that's terminated ...
1349 (Block.Resolve): ... here.
1351 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
1352 (UsageVector.MergeFinallyOrigins): Likewise.
1353 (FlowBranching.InTryOrCatch): Likewise.
1354 (FlowBranching.AddFinallyVector): Likewise.
1355 (FlowBranchingException): Update to changes.
1358 * statement.cs (Return.Resolve): Move error checking to ...
1359 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
1360 (FlowBranchingException): Handle return origins like break and
1362 (FlowBranching.UsageVector.CheckOutParameters): Remove.
1364 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1367 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
1370 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1373 * class.cs (MethodData.Define): Do public accessor check only when method
1374 implements an interface.
1376 2006-05-04 Raja R Harinath <rharinath@novell.com>
1378 Remove special handling of 'break'
1379 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
1380 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
1381 (UsageVector.Break): Remove.
1382 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
1384 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
1386 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
1387 UsageVector.Breaks (). Don't set NeedsReturnLabel.
1389 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1392 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
1393 be the interface member.
1395 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1398 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
1399 for emitting small (int) values.
1401 2006-05-03 Raja R Harinath <rharinath@novell.com>
1404 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
1405 control-flow passes through the 'finally' after merging-in all the
1406 control-flows from 'try' and the 'catch' clauses.
1408 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
1409 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
1410 always true at the only non-recursive entry point.
1411 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
1412 FlowBranchingBreakable.
1413 (FlowBranchingLoop): Remove.
1414 * statement.cs (Return.DoResolve): Update to changes.
1417 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
1418 (FlowBranching.CreateBranching): Handle it: create a
1419 FlowBranchingContinuable.
1420 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
1421 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
1422 except that it handles the 'continue' command.
1423 (FlowBranching.UsageVector.MergeOrigins): Rename from
1425 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
1426 except that it overrides AddContinueOrigin.
1427 (FlowBranchingException): Override AddContinueOrigin, similar to
1429 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
1430 Create a new branching around the embedded statement.
1431 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
1432 control flow after the embedded statement.
1433 (Continue.Resolve): Move all error checking to AddContinueOrigin.
1435 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
1436 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
1437 FlowBranchingBreakable.
1438 (FlowBranchingSwitch): Remove.
1441 * statement.cs (Break.Resolve): Simplify. Move responsibility for
1442 error reporting to ...
1443 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
1444 Rename from 'AddBreakVector'. Add new location argument. Return
1445 a bool indicating whether the 'break' crosses an unwind-protect.
1446 (FlowBranchingException.AddBreakOrigin): Add.
1447 (FlowBranchingException.Merge): Propagate 'break's to surrounding
1448 flowbranching after updating with the effects of the 'finally'
1450 (FlowBranchingBreakable): New common base class for
1451 FlowBranchingLoop and FlowBranchingSwitch.
1453 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
1455 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
1457 2006-05-02 Raja R Harinath <rharinath@novell.com>
1459 * statement.cs (Do.Resolve): If the loop is infinite, set the
1461 (While.Resolve, For.Resolve): Set a barrier after the embedded
1462 statement. There's no direct control flow that goes from the end
1463 of the embedded statement to the end of the loop.
1464 * flowanalysis.cs (FlowBranching.Infinite): Remove.
1465 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
1466 above ensure that the reachability is correctly computed.
1468 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
1469 (UsageVector.MergeBreakOrigins): If the current path is
1470 unreachable, treat it as if all parameters/locals are initialized.
1471 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
1472 infinite loops before merging-in break origins.
1474 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
1475 (Reachability.Reachable): Split part into ...
1476 (Reachability.Unreachable): ... this. Simplify.
1477 (Reachability.IsUnreachable): Use 'Unreachable' instead.
1479 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
1480 (Reachability.SetThrowsSometimes): Likewise.
1481 (FlowBranchingBlock.MergeTopBlock): Don't compare against
1482 TriState.Always, use corresponding property.
1483 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
1484 (Block.Resolve): Likewise. Remove some redundant checks.
1486 2006-05-02 Raja R Harinath <harinath@gmail.com>
1488 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
1489 (Reachability.Meet): Don't bother checking AlwaysThrows --
1490 barrier is always set.
1491 (FlowBranchingBlock.Merge): Likewise.
1493 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
1495 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
1496 defined, so it's references should also compile only for NET_2_0
1497 (as occurs in mcs version)
1499 2006-05-01 Raja R Harinath <harinath@gmail.com>
1501 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
1502 checks for unreachable.
1504 2006-05-01 Marek Safar <marek.safar@seznam.cz>
1507 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
1509 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
1510 whether field is really assigned.
1512 2006-04-30 Raja R Harinath <harinath@gmail.com>
1514 * flowanalysis.cs (Reachability): Make 4-argument constructor
1516 (Reachability.Meet): Rename from 'And'. Remove static variant.
1517 (Reachability.Always): Rename from the highly misleading
1518 'Reachability.Never'.
1519 (FlowBranching.Merge): Update to changes. Mark an impossible
1520 situation with a 'throw'.
1521 (*): Update to changes.
1523 2006-04-29 Raja R Harinath <harinath@gmail.com>
1525 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
1527 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
1528 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
1529 (*): Update to changes.
1530 * statement.cs: Update to changes.
1532 2006-04-28 Marek Safar <marek.safar@seznam.cz>
1535 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
1537 2006-04-28 Raja R Harinath <harinath@gmail.com>
1539 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
1542 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
1543 argument to two arguments: an usage-vector and a bool. Move call
1544 to FlowBranching.Merge () ...
1545 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
1547 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
1548 handling of loop and switch reachability to ...
1549 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
1551 2006-04-27 Raja R Harinath <harinath@gmail.com>
1553 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
1554 handling to FlowBranchingLoop.InLoop.
1555 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
1557 2006-04-26 Marek Safar <marek.safar@seznam.cz>
1560 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
1561 anonymous method is allowed from AnonymousContainer here.
1563 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
1565 2006-04-24 Raja R Harinath <rharinath@novell.com>
1568 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1570 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1573 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1574 (DoubleConstant.Reduce): Ditto.
1576 2006-04-23 Raja R Harinath <rharinath@novell.com>
1578 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1579 Remove 'lvalue_right_side' argument. Move parts to ...
1580 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1581 (LocalVariable.DoResolveLValue): ... these.
1583 2006-04-21 Raja R Harinath <rharinath@novell.com>
1586 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1587 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1588 (LocalVariableReference.DoResolveBase): Use it to implement new
1590 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1591 (Argument.Resolve): Simplify. Move CS1510 check ...
1592 * ecore.cs (Expression.ResolveLValue): ... here.
1593 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1594 (PropertyExpr.DoResolveLValue): Likewise.
1595 (FieldExpr.Report_AssignToReadonly): Likewise.
1596 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1597 LValueMemberAccess or LValueMemberOutAccess on instance depending
1599 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1600 DoResolve as appropriate.
1602 2006-04-20 Raja R Harinath <rharinath@novell.com>
1605 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1606 implicit conversions on 'out' and 'ref' arguments.
1608 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1609 improve clarity. Remove dead code.
1612 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1613 (Catch.Resolve): Resolve VarBlock if it exists.
1615 2006-04-19 Miguel de Icaza <miguel@novell.com>
1617 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1618 twice, this was some residual code, the enumerator was emitted
1619 properly in the two branche of if later.
1623 Thanks to Martin for finding the source of the problem
1625 2006-04-19 Raja R Harinath <rharinath@novell.com>
1627 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1628 cast is never an lvalue.
1629 (Cast.DoResolve, Cast.ResolveRest): Combine.
1630 (Argument.Emit): Simplify slightly. Move 'Expr is
1631 IMemoryLocation' check ...
1632 (Argument.Resolve): ... here.
1633 (Argument.Error_LValueRequired): Remove. Inline into only user.
1635 Simplifications. Fix cs0191-2.cs
1636 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1637 CS1649 and CS1651 to ...
1638 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1639 the actual selection of the error code and message to a lookup
1640 table. Add a dummy return value to simplify callsites.
1641 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1642 readonly fields of other instances of the same type. Move CS0197
1644 * expression.cs (Argument.Resolve): ... here. Simplify code.
1645 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1646 resolution of an out or ref argument. The code simplification
1647 above uses this invariant.
1649 2006-04-18 Raja R Harinath <rharinath@novell.com>
1651 Possibly fix #77752. Fix cs1690-[4-7].cs.
1652 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1653 CheckMarshallByRefAccess. Drop parameter.
1654 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1656 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1658 * report.cs (AllWarnings): Add CS1690.
1659 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1661 (LocalVariableReference.DoResolveBase): Update.
1663 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1665 * class.cs (MethodOrOperator): Moved common parts from method class.
1666 detect obsolete attributes.
1667 (Method.Define): Simplified as it reuses code from base.
1668 (Constructor.ValidAttributeTargets): Fixed issue found during
1670 (Destructor.ValidAttributeTargets): Fixed issue found during
1672 (Operator): Finished refactoring set off by #78020. Operator class is now
1673 ordinary method class.
1675 * anonymous.cs: Updated.
1677 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1679 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1681 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1683 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1684 detect obsolete attributes.
1685 (Method.CreateEmitContext): Moved to MethodOrOperator.
1687 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1690 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1691 customized exception to make crash detection easier.
1692 (MethodOrOperator): Started to work on new base class for methods and
1694 (Method): Derives from MethodOrOperator.
1695 (Constructor.Emit): Emits its own attributes.
1696 (AbstractPropertyEventMethod.Emit): Ditto.
1697 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1699 (Operator.Emit): It's temporary more tricky than should be.
1701 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1703 * report.cs (InternalErrorException): Add ctor with inner exception.
1705 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1708 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1711 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1714 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1717 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1719 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1720 attribute is present and Guid not.
1721 (Interface.ApplyAttributeBuilder): Ditto.
1723 * attribute.cs: Add error message.
1725 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1729 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1730 sources (it's composite) so hold them in extra array as they are used in
1731 Emit phase only. It worked in the previous versions by mistake.
1732 (Attribute.Emit): Emit attribute for more owners when exist.
1734 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1735 it has now different behaviour.
1737 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1739 * constant.cs (Constant.IsDefaultInitializer): New method.
1741 * class.cs: Updated.
1743 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1744 re-initialize default values. It saves KBs almost for every assembly.
1745 Thanks Zoltan for the idea.
1746 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1747 (ArrayCreation.DoResolve): Resolve only once.
1748 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1749 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1751 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1753 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1756 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1758 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1759 in an embedded statement too.
1761 2006-04-01 Raja R Harinath <rharinath@novell.com>
1764 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1768 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1771 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1772 arguments before checking whether a type is reflected or not.
1775 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1776 definition doesn't take part in overload resolution.
1777 (Invocation.IsParamsMethodApplicable): Likewise.
1778 (Invocation.OverloadResolve): When replacing a reflected override
1779 method with its base definition, ensure that type arguments are
1782 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1786 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1789 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1791 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1793 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1796 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1797 LocalTemporary change.
1799 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1801 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1802 initializers optimization.
1803 (ClassOrStruct.TypeAttr): Moved from modifiers.
1804 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1805 (FieldBase.ResolveInitializer): Resolves initializer.
1806 (FieldBase.HasDefaultInitializer): New property.
1808 * cs-parser.jay: Removed message.
1810 * expression.cs (CompilerGeneratedThis): New specialization.
1812 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1814 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1816 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1818 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1820 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1821 be now EnumConstants only.
1823 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1825 * attribute.cs, driver.cs: Reset more caches.
1827 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1829 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1831 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1833 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1834 for easier reuse. Updated all overrides.
1835 (IntegralConstant): New base class for all integral constants.
1836 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1837 of the constant range, report custom error.
1838 (UIntConstant.Reduce): Fixed uint conversion.
1840 * ecore.cs, literal.cs: Reduce updates.
1842 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1846 * class.cs (Constructor.Define): Removed extra if for default ctors.
1847 A patch from Atsushi Enomoto.
1849 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1851 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1852 GetAttributableValue.
1854 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1857 * convert.cs (ImplicitConversionRequired): Error message moved to
1860 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1861 automatic implicit conversion of an output value.
1862 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1864 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1866 (TypeOf.GetAttributableValue): Add extra handling for object type.
1868 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1869 special error message.
1871 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1873 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1875 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1876 compatible with MS runtime.
1878 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1880 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1881 attribute arguments here.
1883 * class.cs (Indexer.Define): The check was moved to attribute class.
1885 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1887 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1889 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1891 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1893 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1896 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1898 * doc-bootstrap.cs : fix build.
1900 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1902 * expression.cs (StringConcat.Append): Issue a warning when empty string
1905 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1907 * assign.cs (CompoundAssign.ResolveSource): Removed.
1909 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1912 * class.cs (TypeContainer.FindMethods): Removed.
1913 (TypeContainer.CheckMemberUsage): Made static.
1915 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1917 * constant.cs (CheckRange): Removed unused type argument.
1918 (CheckUnsigned): Removed unused type argument.
1920 * cs-parser.jay: Updated after MemberAccess clean up.
1921 Uses Length for empty string test.
1923 * cs-tokenizer.cs: Uses Length for empty string test.
1924 (IsCastToken): Made static.
1925 (is_hex): Made static.
1926 (real_type_suffix): Made static.
1928 * decl.cs (SetupCache): Made static.
1929 (OnGenerateDocComment): Removed unused ds argument.
1931 * delegate.cs (VerifyDelegate): Removed unused argument.
1933 * doc.cs: Uses Length for empty string test.
1935 * driver.cs: Uses Length for empty string test.
1937 * enum.cs (IsValidEnumType): Made static
1939 * expression.cs (EnumLiftUp): Removed unused argument.
1940 (ResolveMethodGroup): Ditto.
1941 (BetterConversion): Ditto.
1942 (GetVarargsTypes): Ditto.
1943 (UpdateIndices): Ditto.
1944 (ValidateInitializers): Ditto.
1945 (MemberAccess.ctor): Ditto.
1946 (GetIndexersForType): Ditto.
1948 * flowanalysis.cs: (MergeFinally): Removed unused argument.
1950 * iterators.cs: Updated after MemberAccess clean up.
1952 * location.cs: Uses Length for empty string test.
1954 * namespace.cs: Uses Length for empty string test.
1956 * report.cs (CheckWarningCode): Made static.
1958 * statement.cs (LabeledStatement): Removed unused argument.
1960 * typemanager.cs (FilterNone): Removed.
1962 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1964 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
1967 * class.cs: Updated.
1969 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1971 * cs-parser.jay.cs: __arglist is not allowed for delegates.
1973 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1977 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
1979 (AnonymousMethod.ImplicitStandardConversionExists): New method.
1980 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
1981 Add more error reporting; Fixed issue with params.
1983 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
1985 * cs-parser.jay: AnonymousMethod requires host container.
1987 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
1989 2006-03-18 Raja R Harinath <harinath@gmail.com>
1991 * class.cs: Change 'TypeContainer ds' constructor argument to
1992 'DeclSpace parent'. Some classes were missed below due to
1993 different naming convention.
1995 * class.cs (MemberCore.Parent): Delete. This makes the
1996 ParentContainer changes below enforceable by the compiler.
1998 Treat pointers to enclosing declaration space as 'DeclSpace', not
2000 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
2001 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
2003 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
2005 (Block.AddThisVariable): Likewise.
2006 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
2007 (AbstractPropertyEventMethod.Emit): Likewise.
2008 (AbstractPropertyEventMethod.EmitMethod): Likewise.
2009 (GetMethod.Define, SetMethod.Define): Likewise.
2010 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
2011 (DelegateMethod.EmitMethod): Likewise.
2013 Fix regression test-partial-13.cs.
2014 Rationalize use of PartialContainer. Ensure that the partial
2015 class semantics can be tied to type-correctness, i.e., any
2016 violation will cause a compile error.
2017 * class.cs, const.cs: Access all fields that belong to class
2018 TypeContainer via ParentContainer. Arguments of EmitContexts and
2019 Resolve()-like functions still use 'Parent'.
2021 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
2022 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
2023 (PropertyMethod.CheckModifiers): Remove unused argument.
2024 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
2027 2006-03-28 Raja R Harinath <rharinath@novell.com>
2029 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
2031 2006-03-17 Raja R Harinath <harinath@gmail.com>
2033 Make semantics of PartialContainer simpler.
2034 * decl.cs (DeclSpace.IsPartial): Remove.
2035 * class.cs (TypeContainer.IsPartial): Likewise.
2036 (TypeContainer..ctor): Set PartialContainer to point to self.
2037 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
2038 (TypeContainer.FindNestedType): Likewise.
2039 (MemberCore.ParentContainer): Simplify. Remove deprecation.
2041 2006-03-17 Marek Safar <marek.safar@seznam.cz>
2043 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
2045 2006-03-15 Marek Safar <marek.safar@seznam.cz>
2047 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
2050 2006-03-15 Marek Safar <marek.safar@seznam.cz>
2052 * class.cs (Operator.Define): An error for base conversion was not
2055 2006-03-13 Marek Safar <marek.safar@seznam.cz>
2057 A fix for #77593, #77574.
2059 * class.cs (MethodCore.CheckBase): Another if for operator.
2061 2006-03-18 Marek Safar <marek.safar@seznam.cz>
2065 * expression.cs (VerifyArgumentsCompat): Reverted to double error
2066 reporting, it's more tricky than I thought.
2068 2006-03-09 Marek Safar <marek.safar@seznam.cz>
2070 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
2073 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
2074 (DelegateCreation.ImplicitStandardConversionExists): New method for just
2077 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
2080 2006-03-04 Marek Safar <marek.safar@seznam.cz>
2084 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
2085 (Event.Define): ditto
2086 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
2088 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
2089 Removed redundant code and set NewSlot for Invoke method too.
2091 * parameter.cs (Parameters.ctor): Add custom, type ctor.
2092 (Parameters.MergeGenerated): New method. Use this method when you merge
2093 compiler generated argument with user arguments.
2095 2006-03-03 Marek Safar <marek.safar@seznam.cz>
2097 * attribute.cs (ResolveAsTypeTerminal): Removed.
2099 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
2100 specialization for predefined types; 30% speed up.
2101 Finally placed obsolete check to right place.
2102 (Expression.ResolveType): Removed.
2104 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
2105 Updated after ResolveType was removed.
2107 * expression.cs (Cast.ctor): Check void cast.
2108 (Binary.ResolveAsTypeTerminal): Is never type.
2109 (Conditional.ResolveAsTypeTerminal): Is never type.
2111 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
2113 2006-03-26 Marek Safar <marek.safar@seznam.cz>
2115 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
2117 2006-03-23 Martin Baulig <martin@ximian.com>
2119 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
2120 type check if either of the types is an open generic type.
2122 2006-03-23 Martin Baulig <martin@ximian.com>
2125 (Convert.ExplicitTypeParameterConversion): New method; implement
2126 explicit type parameter conversions.
2128 2006-03-23 Martin Baulig <martin@ximian.com>
2130 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
2131 blindly allow all conversions if we do not have any constraints.
2133 2006-02-27 Marek Safar <marek.safar@seznam.cz>
2135 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
2136 these two separated members to simplify the code.
2137 (Attribute.Resolve): Refactored to use new fields and methods.
2138 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
2139 implemented obsolete attribute checking.
2140 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
2141 implemented obsolete checking again. It look line never ending quest ;-)
2142 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
2144 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
2146 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
2148 *class.cs (Property.Define): Add RegisterProperty call.
2150 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
2151 argument groups (only 2).
2153 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
2154 encoding expression to arguments.
2155 (Expression.ExprClassToResolveFlags): Just turned to property.
2157 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
2158 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
2159 optimized as well as implemented support for zero-length attributes.
2161 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
2162 Add caching of PropertyInfo's.
2164 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2166 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
2167 error multiple times.
2169 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2171 New partial class implementation.
2172 A fix for #77027, #77029, #77403
2174 * attribute.cs (Attributable): Made attributes protected.
2176 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
2177 the replacements of ClassPart and PartialContainer.
2178 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
2179 (TypeContainer.AddInterface): Ditto.
2180 (TypeContainer.AddPartial): The main method for partial classes. It checks
2181 for errors and merges ModFlags and attributes. At the end class is added to
2183 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
2185 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
2186 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
2187 from the rest of partial classes.
2188 (TypeContainer.GetClassBases): Simplified.
2189 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
2191 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
2192 (TypeContainer.HasExplicitLayout): Uses Flags now.
2193 (PartialContainer): Removed.
2194 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
2195 (StaticClass): Was merged with Class.
2196 (Class.GetClassBases): class and static class bases are verified here.
2197 (Class.TypeAttr): Added static attributes when class is static.
2198 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
2199 (MemberBase): In some cases we need to call parent container for partial
2200 class. It should be eliminated but it's not easy now.
2202 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
2204 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
2205 partial classed to accumulate class comments.
2206 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
2208 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
2210 * driver.cs (MainDriver): Tree.GetDecl was removed.
2212 * modifiers.cs (Modifiers): Add partial modifier.
2214 * tree.cs (Tree.decl): Removed.
2215 (RootTypes): Started to use this class more often for root types
2218 2006-03-23 Raja R Harinath <rharinath@novell.com>
2220 * generic.cs (TypeParameter.UpdateConstraints): Update
2221 'constraints' if null.
2223 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2227 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
2228 external interface does not have an attribute.
2230 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2232 Another prerequisites for new partial classs implementation.
2234 * attribute.cs (Attribute.Equal): Implemented.
2235 (Attribute.Emit): Changed as attributes can be applied more than twice.
2236 (Attributes.Emit): Check for duplicate attributes here.
2238 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
2239 as a parameter, clean-up.
2241 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2245 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
2246 contains obsolete attribute check which can in some cases look for base
2247 type of current class which is not initialized yet.
2248 (TypeContainer.BaseType): Replacement of ptype.
2250 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
2252 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2254 First of prerequisites for new partial classs implemention.
2256 * attribute.cs (Attributable): Extended by ResolveContext;
2257 Attributes finally have correct context for resolving in all cases.
2258 (AttachTo): Attribute owner is assigned here.
2260 * codegen.cs (IResolveContext): Introduce new interface to hold
2261 all information needed in resolving phase.
2262 (EmitContext): Implements IResolveContext; more clean-up needed here.
2264 * decl.cs (MemberCore): Implemented IResolveContext.
2266 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
2267 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
2268 parameter.cs, statement.cs, tree.cs, typemanager.cs:
2269 Refactored to use new IResolveContext instead of EmitContext; cleanup
2271 2006-03-22 Raja R Harinath <rharinath@novell.com>
2273 Support ParameterDefaultValueAttribute in gmcs. Also applied to
2274 mcs to keep code differences small.
2275 * attribute.cs (Attribute.GetParameterDefaultValue): New.
2276 * typemanager.cs (parameter_default_value_attribute_type): New.
2277 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
2280 2006-03-22 Martin Baulig <martin@ximian.com>
2283 (Nullable.NullableLiteral): Derive from `NullLiteral'.
2286 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
2287 instead of the normal `NullLiteral'.
2289 2006-03-21 Martin Baulig <martin@ximian.com>
2292 * generic.cs (TypeManager.InferType): If `pt' is a generic
2293 parameter, don't check whether `pt == at'.
2295 2006-03-20 Raja R Harinath <rharinath@novell.com>
2298 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
2299 (TypeParameter.Resolve): Update to change.
2300 (ConstraintChecker.CheckConstraints): Resolve type-argument
2301 constraints before use.
2303 2006-03-16 Martin Baulig <martin@ximian.com>
2306 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
2307 and don't have any instance constructors, also lookup in the base class.
2308 (TypeManager.IsNullableValueType): New public method.
2310 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
2311 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
2312 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
2314 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
2315 instead of just TypeManager.IsNullableType() to determine whether
2316 a lifted operator exists.
2317 (UnaryMutator.DoResolve): Likewise.
2318 (Conditional.DoResolve): Likewise.
2319 (Binary.DoResolve): A lifted operator only exists if both operands
2320 are valuetypes and at least one of them is a nullable type.
2322 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
2324 * iterator.cs : yield break is allowed in try statement which has
2325 catch clauses. Fixed bug #77767.
2327 2006-03-12 Martin Baulig <martin@ximian.com>
2329 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
2330 private IsSignatureEqual() to compare types; see the comment in
2331 that method; fixes #77674.
2333 2006-03-10 Raja R Harinath <rharinath@novell.com>
2335 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
2336 (Expression.ResolveAsTypeTerminal): Likewise.
2337 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
2338 * expression.cs, generic.cs, iterators.cs: Likewise.
2339 * parameter.cs, statement.cs, typemanager.cs: Likewise.
2341 2006-03-09 Martin Baulig <martin@ximian.com>
2343 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
2344 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
2346 2006-03-09 Martin Baulig <martin@ximian.com>
2348 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
2349 `prepared' flag is set.
2351 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
2352 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
2353 issues; see gtest-254.cs.
2355 2006-03-07 Martin Baulig <martin@ximian.com>
2357 * generic.cs (TypeManager.InferType): Allow infering
2358 `IEnumerable<T>' with an array of T; see gtest-251.cs.
2360 2006-03-06 Martin Baulig <martin@ximian.com>
2363 (TypeManager.InferType): Fix gtest-250.cs.
2366 (TypeManager.IsSubclassOf): Also check the base class.
2369 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
2372 2006-03-01 Raja R Harinath <rharinath@novell.com>
2375 * expression.cs (ParameterReference.DoResolveBase): Change return
2377 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
2381 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
2384 * typemanager.cs (GetFullNameSignature): Don't nullref on
2385 protected accessors.
2387 2006-02-16 Martin Baulig <martin@ximian.com>
2390 (TypeManager.GetGenericFieldDefinition): New public method; use it
2391 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
2393 2006-02-14 Martin Baulig <martin@ximian.com>
2395 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
2397 2006-02-14 Martin Baulig <martin@ximian.com>
2400 (TypeManager.DropGenericMethodArguments): New public method; don't
2401 use GetGenericMethodDefinition() on something which is not a
2404 2006-02-14 Martin Baulig <martin@ximian.com>
2407 (ConstraintChecker.CheckConstraints): If a type parameter has the
2408 `struct' constraint, the type must be a non-nullable valuetype.
2410 2006-02-10 Martin Baulig <martin@ximian.com>
2413 (TypeManager.IsOverride): Make this work for instantiated methods
2414 in a generic class; fixes #77509.
2415 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
2416 rather than calling it directly; fixes #77488.
2418 2006-02-08 Martin Baulig <martin@ximian.com>
2420 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
2421 reporting into CheckConstraint() so we can use the correctly
2424 2006-02-08 Martin Baulig <martin@ximian.com>
2426 * expression.cs (BaseAccess): Add support for generic methods.
2428 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
2429 the new MethodGroupExpr.
2431 2006-02-07 Martin Baulig <martin@ximian.com>
2433 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
2434 also reference types; fixes #77483.
2436 2006-02-07 Martin Baulig <martin@ximian.com>
2439 (TypeManager.IsGenericMethod): We now return whether something is
2440 an instantiated generic method (and not a generic method def).
2441 (TypeManager.IsGenericMethodDefinition): New public method.
2444 (TypeManager.CSharpSignature): Only include type arguments for
2445 "real" generic methods, not for any instantiated method.
2446 (TypeManager.GetMethodName): Likewise, but also allow generic
2447 method definitions here.
2449 2006-02-06 Miguel de Icaza <miguel@novell.com>
2451 * codegen.cs (EmitScopeInitFromBlock): check here the
2452 capture_context, there is no need to make two calls to the
2455 * anonymous.cs: Add some debugging messages that might help me
2456 track other instances of this problem in the future (the
2457 regression of test 467).
2459 * cs-parser.jay: track the variable block, as we need to initalize
2460 any captured variables declared in this block for the "catch"
2461 portion of the "Try" statement.
2463 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
2464 scope initialization for captured variables.
2466 Also, move the emit for the variables after the block location has
2469 2006-02-06 Marek Safar <marek.safar@seznam.cz>
2471 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
2473 2006-02-06 Martin Baulig <martin@ximian.com>
2475 * class.cs (TypeContainer.DefineType): If we're a struct, pass
2476 `TypeManager.value_type' as parent type to
2477 ModuleBuilder.DefineType(). Fixes #77358.
2479 2006-02-02 Miguel de Icaza <miguel@novell.com>
2481 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
2482 commit yesterday, the initialization for the roots is necessary.
2483 What is not necessary is the scope activation.
2485 2006-02-02 Raja R Harinath <rharinath@novell.com>
2487 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
2488 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
2490 (Argument.Resolve): Remove CS0206 checks.
2492 2006-02-01 Miguel de Icaza <miguel@novell.com>
2494 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
2495 scopes for all the roots, the scopes will now be emitted when the
2496 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
2498 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
2499 code. This reduces a lot of existing cruft.
2501 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
2502 that the ScopeInfo is generated as we enter the scope, not at the
2503 time of use, which is what we used to do before.
2505 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
2506 every time a Block is about to be emitted if we have a
2509 2006-02-01 Raja R Harinath <rharinath@novell.com>
2511 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
2512 attribute for mscorlib too.
2514 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
2516 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
2518 * typemanager.cs (cons_param_array_attribute): Make private.
2519 (Reset): Set it to null.
2520 (InitCoreHelpers): Don't initialize it.
2521 (ConsParamArrayAttribute): New. Initialize it as needed.
2522 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
2524 2006-01-31 Miguel de Icaza <miguel@novell.com>
2526 * expression.cs: There might be errors reported during the
2527 selection of applicable methods. If there are errors, do not
2528 continue execution as it will lead the compiler to crash.
2530 2006-01-30 Miguel de Icaza <miguel@novell.com>
2532 * expression.cs: Member access is not allowed on anonymous
2533 methods. Fixes #77402.
2535 2006-01-30 Raja R Harinath <rharinath@novell.com>
2538 * cs-parser.jay (VariableDeclaration): Don't set
2539 current_array_type to null.
2540 (field_declaration, event_declaration, declaration_statement):
2541 Set it to null here.
2543 2006-01-29 Raja R Harinath <harinath@gmail.com>
2546 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
2548 2006-01-28 Raja R Harinath <harinath@gmail.com>
2550 * typemanager.cs (GenericParameterPosition): New.
2553 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
2555 * doc.cs : To process "include" elements, first we should create
2556 another list than XmlNodeList, because it could result in node
2557 removal, which could result in that the XmlNodeList gives up
2560 2006-01-25 Miguel de Icaza <miguel@novell.com>
2562 * expression.cs: Introduce an error report that we were not
2563 catching before. Gonzalo ran into it.
2565 2006-01-23 Miguel de Icaza <miguel@novell.com>
2567 A fix for bug: #76957
2569 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2570 ComputeMethodHost before creating the method, this is a new
2573 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2574 that this method references (RegisterScope). The actual scope
2575 where the method is hosted is computed with the ComputeMethodHost
2576 before we create the method.
2578 Moved the Deepest routine here.
2580 (AnonymousContainer.ComputeMethodHost): New routine used to
2581 compute the proper ScopeInfo that will host the anonymous method.
2583 (ScopeInfo): Deal with multiple roots. The problem was that we
2584 did not have a unique root where all ScopeInfos could be hanged
2585 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2588 Remove AdjustMethodScope which is now computed at the end. Remove
2589 LinkScope which did a partial link, instead link all ScopeInfos
2590 before code generation from the new "LinkScopes" routine.
2592 Simplify all the Add* routines as they no longer need to maintain
2593 the tree, they just need to record that they are using variables
2596 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2597 routines to produce the forest of ScopeInfo trees.
2599 * class.cs (TypeContainer.AppendMethod): This is just like
2600 AddMethod, but ensures that an interface implementation method
2601 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2602 methods, but at the end.
2604 We use this functionality to ensure that the generated MoveNext
2605 method in the iterator class is resolved/emitted before the
2606 enumerator methods created.
2608 This is required because the MoveNext method computes the right
2609 ScopeInfo for the method. And the other methods will eventually
2610 need to resolve and fetch information computed from the anonymous
2614 2006-01-23 Raja R Harinath <rharinath@novell.com>
2616 Improve implementation of section 14.4.2.2 (Better function member).
2617 * expression.cs (Invocation.MoreSpecific): Compare all type
2618 arguments before deciding if one type is more specific than
2619 another. Handle array types too. Return the more specific type.
2620 (Invocation.BetterFunction): Add more tie-breaking rules from
2621 section 14.4.2.2. Perform "more specific" check after
2622 other tie-breaking rules. Compare all parameter types before
2623 choosing the "more specific" method.
2625 2006-01-21 Raja R Harinath <harinath@gmail.com>
2626 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2629 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2631 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2632 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2634 2006-01-18 Martin Baulig <martin@ximian.com>
2636 * class.cs (TypeContainer.AddToMemberContainer): Use
2637 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2640 2006-01-18 Martin Baulig <martin@ximian.com>
2642 Fix #76417: a generic class may now have methods which may unify
2643 for some type parameter substitutions.
2645 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2646 for methods which may unify anymore.
2648 * expression.cs (Invocation.MoreSpecific): New private static
2649 method; checks whether one method is more specific than another
2650 according to 14.4.2.2 of the spec.
2651 (Invocation.BetterFunction): Implement the tie-breaking rules from
2652 14.4.2.2 of the spec: if two methods unify for some type parameter
2653 substitution, we need to pick the more specific one.
2655 2006-01-18 Raja R Harinath <rharinath@novell.com>
2657 Fix #76656, cs0231-2.cs.
2658 * cs-parser.jay (formal_parameter_list): Make error case catch
2660 (parenthesized_expression_0): Add CS1026 check.
2661 (invocation_expression): Remove unused { $$ = lexer.Location }.
2663 2006-01-17 Raja R Harinath <rharinath@novell.com>
2666 * cs-parser.jay (statement_expression): Don't list out the
2667 individual statement-expressions. Convert syntax error into
2670 2006-01-16 Raja R Harinath <rharinath@novell.com>
2673 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2674 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2675 CheckIntermediateModification.
2676 (FieldExpr.DoResolve): Add new two-argument version that
2677 allows us to resolve the InstanceExpression as an lvalue.
2678 The one-argument variant is now just a wrapper.
2679 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2680 Resolve the lhs as an lvalue if the it has a value type.
2681 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2682 from Assign.DoResolve.
2683 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2684 resolved as an lvalue.
2685 (PropertyExpr.DoResolve): Update.
2686 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2687 has a value type. Move CS1612 check here from
2688 CheckIntermediateModification.
2689 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2690 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2691 'right_side' of a ResolveLValue on an 'out' argument.
2692 (EmptyExpression.LValueMemberAccess): New. Used as the
2693 'right_side' of a propagated ResolveLValue on a value type.
2694 (LocalVariableReference.DoResolveBase): Recognize
2695 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2697 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2698 EmptyExpression.Null.
2700 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2702 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2703 Type.IsGenericParameter(). Fixed bug #77183.
2704 * doc.cs : it is now identical to doc.cs in mcs.
2706 2006-01-16 Martin Baulig <martin@ximian.com>
2708 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2710 2006-01-16 Martin Baulig <martin@ximian.com>
2712 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2713 ctors; fixes #77250.
2715 2006-01-12 Miguel de Icaza <miguel@novell.com>
2717 This fixes the problem where we used ldfld instead of ldflda to
2718 load the "THIS" pointer on captured parameters, when THIS is a
2719 value type. See bug #77205.
2721 * iterators.cs (CapturedThisReference.Emit): Pass false to
2722 EmitThis (we do not need the address).
2724 * codegen.cs (EmitThis): it needs to know whether we need the
2725 address of `this' or not. This is used by value types.
2727 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2728 every other call passes false.
2730 2006-01-12 Raja R Harinath <rharinath@novell.com>
2733 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2735 * expression.cs (Invocation.OverloadResolve): Update.
2736 (Invocation.DoResolve): Avoid double resolution of invocation.
2738 2006-01-11 Raja R Harinath <rharinath@novell.com>
2741 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2742 unary negation of floating point types as 0-expr; negation cannot
2743 overflow in floating point types.
2746 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2747 on operands of 'void' type.
2750 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2751 and ExclusiveOr for boolean constants too.
2753 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2755 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2757 2006-01-12 Miguel de Icaza <miguel@novell.com>
2759 * cs-tokenizer.cs (Position): New class used to save and restore
2760 the position state in the tokenizer. Before this patch the save
2761 and restore was not complete enough so the line and columns would
2762 start to drift and the debugger and stack traces will get the
2765 2006-01-10 Martin Baulig <martin@ximian.com>
2768 (TypeParameter.InflateConstraints): New public method.
2770 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2771 constraints; fixes #77042.
2773 2006-01-10 Martin Baulig <martin@ximian.com>
2775 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2776 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2779 2006-01-09 Raja R Harinath <rharinath@novell.com>
2782 * expression.cs (Invocation.OverloadResolve): Replace reflected
2783 override methods with their base virtual methods, rather than
2785 * typemanager.cs (TypeManager.GetOverride): New.
2787 2005-12-21 Miguel de Icaza <miguel@novell.com>
2789 * driver.cs: Report the case of no source files and no -out:
2792 2005-12-20 Raja R Harinath <rharinath@novell.com>
2795 * expression.cs (ComposedCast.GetSignatureForError): Define.
2797 2006-01-05 Jb Evain <jbevain@gmail.com>
2799 * class.cs (Property.Define, Indexer.Define): do not tag the
2800 properties as SpecialName | RTSpecialName.
2802 2006-01-04 Miguel de Icaza <miguel@novell.com>
2804 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2805 doing a low-level comparission of parameter types. It was lacking
2806 a check for __argslist.
2808 2005-12-30 Miguel de Icaza <miguel@novell.com>
2810 * expression.cs (ParameterReference.DoResolveBase): Allow
2811 reference parameters if they are local to this block.
2813 This allows the ref and out parameters of a delegate to be used in
2814 an anonymous method, for example:
2816 delegate void set (out int x);
2818 set s = delegate (out int x){
2822 This is used by functionality introduced late in the C# language.
2824 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2825 method that take ref and out parameters.
2827 Fixes #77119 which was a late change in the spec.
2829 2005-12-23 Miguel de Icaza <miguel@novell.com>
2831 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2832 parent if its the same scope. Fixes #77060.
2834 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2836 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2838 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2840 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2841 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2842 that doesn't contain the full public key. This is a update of the
2843 friend assemblies in .Net 2.0 release.
2845 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2849 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2850 ListDictionary, to contain the ExternAliasEntry entries (in
2851 addition to the NamespaceEntry.aliases hashtable). This field is
2852 shared between the original entry and its doppelganger (bodyless
2854 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2855 extern_aliases field.
2856 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2857 lookup in extern_aliases.
2859 2005-12-16 Raja R Harinath <rharinath@novell.com>
2862 * class.cs (TypeContainer.Mark_HasEquals): New.
2863 (TypeContainer.Mark_HasGetHashCode): New.
2864 (ClassPart): Override them.
2865 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2867 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2868 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2872 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2873 'parent' argument to the base constructor.
2875 Remove all mention of TypeContainer from decl.cs.
2876 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2877 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2878 (DeclSpace.DeclSpace): Likewise.
2879 (DeclSpace.DefineMembers): Remove unused argument.
2880 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2881 debugging check -- we don't care if the debug code throws an
2882 InvalidCastException instead of an InternalErrorException.
2883 * class.cs (TypeContainer.DefineMembers): Update to changes.
2884 (TypeContainer.DoDefineMembers): Likewise.
2885 (TypeContainer.GetMethods): Likewise.
2886 (PropertyMember.Define): Likewise.
2887 (MemberBase.Parent): New property that forwards to
2888 MemberCore.Parent, but ensures that we get a TypeContainer.
2889 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2890 (RootContext.PopulateTypes): Likewise. Remove special case code
2891 for !RootContext.StdLib: DefineMembers is idempotent.
2893 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2895 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2897 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2899 * doc.cs : The search for referenced namespace was insufficient to
2900 get global one as it used to do. Fixed bug #76965.
2902 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2904 * doc.cs : check name in cref in the last phase that whether it is
2907 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2909 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2912 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2914 * doc.cs : so it turned out that we cannot skip override check for
2915 interface members. Fixed bug #76954.
2917 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2919 * cs-tokenizer.cs : fixed bug #75984:
2920 - #warning and #error should not be handled when the source line
2922 - #line is not checked strictly when the source line is disabled.
2923 - #define and #undef is on the other hand checked strictly at any
2926 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
2928 * cs-tokenizer.cs : missing Location (actually, filename) in one of
2931 2005-12-15 Raja R Harinath <rharinath@novell.com>
2933 * generic.cs (TypeManager.IsGeneric): Remove unused method.
2935 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
2938 2005-12-14 Martin Baulig <martin@ximian.com>
2940 * typemanager.cs (TypeManager.GetFullName): Make this public;
2941 `Type.Fullname' now never returns null.
2943 * class.cs (Method.Define): Use TypeManager.GetFullName() for
2944 explicit interface implementations; we're now using the same
2945 naming convention than csc does.
2947 2005-12-14 Miguel de Icaza <miguel@novell.com>
2949 * convert.cs (ExplicitConversionCore): Check the return value from
2950 ExplicitConversionCore which can return null on failure. Fixes #76914
2952 2005-12-09 Raja R Harinath <rharinath@novell.com>
2954 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
2955 instead of IsGenericInstance.
2956 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
2957 code that's now covered by the more general test.
2958 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
2960 * generic.cs (DropGenericTypeArguments): New. Captures the common
2961 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
2962 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
2963 * generic.cs, report.cs, typemanager.cs: Likewise.
2965 2005-12-08 Martin Baulig <martin@ximian.com>
2967 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
2969 * typemanager.cs (TypeManager.CSharpSignature): Include type
2970 arguments in the signature of a generic method.
2972 2005-12-07 Martin Baulig <martin@ximian.com>
2974 Add support for custom attributes on type parameters.
2976 * cs-parser.jay (type_arguments): Added `opt_attributes'.
2978 * generic.cs (TypeParameterName): New public class; we use this
2979 instead of a `string' to store the name of a type parameter, so we
2980 can also have `Attributes'.
2981 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
2982 array instead of a `string[]' array.
2983 (TypeParameter.ctor): We now also take an `Attributes' argument.
2984 (TypeParameter.EmitAttributes): New public method; emit our
2985 `OptAttributes' here.
2986 (GenericMethod.EmitAttributes): New public method; emit the custom
2987 attributes on all our type parameters.
2989 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
2990 our type parameters.
2991 (MethodData.Define): If we're a generic method, call
2992 EmitAttributes() on it.
2994 2005-12-07 Martin Baulig <martin@ximian.com>
2997 (ConstraintChecker): New public abstract class; move the
2998 constraint checking here from `ConstructedType' and also do
2999 constraint checking for generic methods here.
3001 * expression.cs (Invocation.OverloadResolve): Use
3002 ConstraintChecker.CheckConstraints() if we resolved to a generic
3005 2005-12-05 Marek Safar <marek.safar@seznam.cz>
3007 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
3009 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
3011 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
3012 (FieldBase.Initializer): Initializer is now optional.
3013 (EventField.Define): Only event field can have initializer.
3015 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
3017 * const.cs (Const): Reuse initializer.
3019 * cs-parser.jay: Updated after FieldBase changes.
3020 Added current_array_type to simplify array initializers.
3022 * ecore.cs (NullCast.IsDefaultValue): Implemented.
3024 * expression.cs, iterators.cs: Updated.
3026 * namespace.cs (NamespaceEntry): Made UsingFound private.
3028 2005-12-05 Marek Safar <marek.safar@seznam.cz>
3030 * parameterCollection.cs: Obsolete, removed.
3031 * parser.cs: Obsolete, removed.
3033 2005-12-05 Marek Safar <marek.safar@seznam.cz>
3036 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
3038 * enum.cs (Enum.Define): Set obsolete context here.
3040 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
3043 - FindDocumentedMember() now expects 1) paramList as null
3044 when "we don't have to check the number of parameters" and
3045 2) Type.EmptyTypes when "there is no arguments".
3046 - Introduced FoundMember struct to hold the exact type which was
3047 used to find the documented member (the above change broke
3048 test-xml-044; it might be better just to use DeclaringType than
3049 what MS does, like this change does, but it depends on usage.)
3051 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
3053 * doc.cs : documented member might be from DeclaringType for nested
3054 types. Fixed bug #76782.
3056 2005-12-03 Ben Maurer <bmaurer@ximian.com>
3058 * anonymous.cs: Have the param code handle leaving copies on the
3059 stack etc. Allows anonymous params to take part in the assignment
3060 code (++, +=, etc). Fixes bug #76550
3062 * expression.cs: Handle the prepare_for_load/leave_copy by passing
3063 it down to the anon code.
3065 * iterators.cs: Use dummy var here
3067 * codegen.cs: Handle new vars
3069 2005-12-01 Marek Safar <marek.safar@seznam.cz>
3072 * class.cs (MethodData.Define): Set proper Obsolete context.
3074 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
3076 (FieldExpr.DoResolve): Ditto.
3078 2005-12-01 Marek Safar <marek.safar@seznam.cz>
3081 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
3082 parent is not obsolete.
3084 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
3086 * doc.cs : (FindDocumentedMember) find parameterless members first
3087 and get CS0419 in the early stage. Fixed first case of bug #76727.
3089 2005-11-30 Marek Safar <marek.safar@seznam.cz>
3092 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
3093 no error was reported.
3095 *expression.cs (Binary.DoResolve): left can be null.
3097 2005-12-06 Raja R Harinath <rharinath@novell.com>
3099 * class.cs (MethodCore.CheckGenericOverride): Delete unused
3100 abstract method and all overrides.
3101 * support.cs (ParameterData.GenericConstraints): Delete.
3102 (ReflectionParameters.type_params): Delete.
3103 (ReflectionParameters.ReflectionParameters): Make private.
3104 (ReflectionParameters.GetConstaints): New factory method.
3105 * generic.cs (TypeParameterDefineType): Use it.
3106 (TypeManager.GetTypeParameterConstraints): Likewise.
3108 2005-11-22 Marek Safar <marek.safar@seznam.cz>
3111 * class.cs (MethodData.Emit): Parameters should be labeled first.
3113 2005-11-21 Marek Safar <marek.safar@seznam.cz>
3116 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
3118 2005-11-18 Marek Safar <marek.safar@seznam.cz>
3120 * attribute.cs (AreParametersCompliant): Moved to Parameter.
3122 * class.cs (MethodCore): Parameter clean up.
3123 (IMethodData): Added ParameterInfo.
3124 (MethodData): Parameter clean up.
3125 (Indexer.Define): Parameter clean up.
3137 * typemanager.cs: Parameter clean up.
3139 * delegate.cs (Define): Get rid of duplicated code.
3141 * expression.cs (ParameterReference): Removed useless parameters
3143 (Invocation): Ditto.
3145 * parameter.cs (ParamsParameter): New class, params specialization.
3146 (ArglistParameter): Attemp to separate arglist.
3147 (Parameter): Refactored to be reusable and faster.
3148 (Parameter.Modifier): Made understandable.
3149 (Parameters): Changed to be used as a class for `this' assembly
3150 parameters. Refactored to use new specialized classes.
3152 * support.cs (ParameterData): Added Types property.
3153 (InternalParameters): Deleted.
3155 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3157 * doc.cs : the previous patch does not actually fix the bug.
3158 PropertyInfo override check is now implemented and really fixed it.
3159 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
3161 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3163 * doc.cs : apply "override filter" also to properties.
3166 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3168 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
3169 no need to check overrides. For classes, omit those results from
3170 interfaces since they must exist in the class. Fixed bug #76726.
3172 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3174 * typemanager.cs : (GetFullNameSignature) differentiate indexers
3175 with different parameters. Fixed the second problem in #76685.
3177 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3179 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
3180 get expected 'protected' access in CheckValidFamilyAccess()).
3183 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3185 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
3186 Fixed bug #76705. CS1569 was incorrectly commented out.
3188 2005-11-23 Martin Baulig <martin@ximian.com>
3190 * generic.cs (Constraints.Define): Removed.
3191 (TypeParameter.DefineConstraints): Removed.
3192 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
3193 on the GenericTypeParameterBuilder here.
3195 2005-11-23 Martin Baulig <martin@ximian.com>
3197 * typemanager.cs (TypeManager.GetProperty): Make this public.
3199 * generic.cs (Nullable.NullableInfo.ctor): Use
3200 TypeManager.GetProperty() rather than using reflection directly.
3202 2005-11-17 Martin Baulig <martin@ximian.com>
3204 * expression.cs (Indexers.GetIndexersForType): Added support for
3205 generic parameters; fixes #76587.
3207 2005-11-17 Martin Baulig <martin@ximian.com>
3210 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
3211 inherit the scope from our parent. Fixes #76653.
3213 2005-11-15 Martin Baulig <martin@ximian.com>
3215 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
3216 instead of `ScopeTypeBuilder' to refer to the "current" type.
3217 (AnonymousMethod.CreateScopeType): Correctly create the helper
3218 class if we're inside a generic type definition.
3220 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3222 * doc.cs : use Invocation.IsOverride() to do real override check.
3223 * expression.cs : made Invocation.IsOverride() internal.
3225 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3227 * doc.cs : use TypeManager.FindMembers() instead of (possible)
3228 TypeBuilder.FindMembers() and filter overriden base members out.
3231 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3233 * doc.cs : ref/out parameters are represented as '@' (instead of
3234 '&' in type FullName). Fixed bug #76630 (additionally crefs).
3236 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3238 * doc.cs : when there was no '.' in cref to methods in doc comment,
3239 then parameters were missing in the output. Fixed bug #76691.
3241 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3243 * driver.cs : don't output docs when there is an error.
3246 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3249 Now it should detect indexers. Fixed primary concern in bug #76685.
3250 Fixed CS0419 message to not show the identical member signature in
3253 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3255 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
3256 instead of Type.FindMembers() since it does not handle events.
3259 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
3261 * codegen.cs: Fixed typo (speficied -> specified).
3263 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3266 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
3268 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3270 * attribute.cs: Changed error message.
3272 * cs-tokenizer.cs: One more check.
3274 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3276 * statement.cs (Block.Resolve): Ignore empty statement.
3278 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3280 * report.cs: Made error/warning methods more strict to avoid
3283 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
3284 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
3285 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
3286 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
3288 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3290 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
3291 Use the more explicit AssemblyName.FullName instead of
3292 AssemblyName.Name to report errors.
3294 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3296 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
3299 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3309 * report.cs: Fixed error reporting and typos.
3311 * generic.cs (TypeParameter.GetSignatureForError): New method.
3312 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
3314 * typemanager.cs (GetFullName): Refactored.
3316 2005-11-08 Marek Safar <marek.safar@seznam.cz>
3318 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
3319 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
3321 * class.cs (TypeContainer.IsComImport): New property.
3322 (Constructor.Define): Create proper ctor for ComImport types.
3324 * expression.cs (New.CheckComImport): Fixed.
3326 2005-11-07 Miguel de Icaza <miguel@novell.com>
3328 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
3329 that a parameter has been captured does not mean that we do not
3330 have to do the rest of the processing. This fixes the second part
3331 of #76592. If there was another anonymous method capturing
3332 values in the past, the Scope would never be set for the second
3333 method that captured the same parameter.
3335 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
3336 properly manipulate the stack. Second part of fix for #76592.
3338 * expression.cs (New): Add support for invoking "new" on
3339 interfaces that have been flagged with the ComImport attribute and
3340 the CoClass. Fixes #76637
3342 * statement.cs (Try.DoEmit): When a variable is captured, do not
3343 try to emit the vi.LocalBuilder variable as it has been captured.
3344 Create a temporary variable and store the results on the
3345 FieldBuilder. Fixes #76642
3347 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3349 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
3351 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
3353 * expression.cs (Binary.DoResolve): Added && optimalization.
3355 * typemanager.cs (AddUserType): Removed useless argument.
3357 2005-11-04 Marek Safar <marek.safar@seznam.cz>
3359 * statement.cs (Block.variables): Uses ListDictionary.
3361 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3364 * class.cs (PartialContainer.EmitType): Customized to emit
3365 security attributes.
3366 (ClassPart.ApplyAttributeBuilder): Transform security attribute
3367 for partial classes.
3369 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3372 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
3373 access has to be fixed.
3375 * typemanager.cs (IsUnmanagedType): Wrong common field type.
3377 2005-11-01 Marek Safar <marek.safar@seznam.cz>
3380 * ecore.cs (NullCast.Reduce): Implemented.
3382 * expression.cs (ArrayCreation.CheckIndices): Correcly check
3385 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
3387 (Foreach.Resolve): Catch null properly.
3389 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3391 * cs-tokenizer.cs: Warning text fix.
3393 * driver.cs: AllWarningNumbers exposed on public interface.
3395 * report.cs (): Reviewed warning numbers.
3396 (IsValidWarning): Use binary search.
3398 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3400 * driver.cs: Implemeted resource visibility.
3401 (Resources): New class for code sharing between /res: and
3404 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3406 decl.cs (CurrentTypeParameters): Fixed to be public.
3408 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3410 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
3412 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3414 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
3416 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
3418 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
3420 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3422 Add friend assembly access support.
3423 * typemanager.cs: assembly_internals_vis_attrs
3424 cache for friend assembly access.
3425 (TypeManager.IsFriendAssembly): New method for
3426 checking friend assembly access.
3427 (TypeManager.Error_FriendAccessNameNotMatching): New
3429 (TypeManager.CompareKeyTokens): Likewise.
3430 (TypeManager.Filter): Handle friend accessible
3433 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
3434 friend accessible types.
3436 * ecore.cs (Expression.IsAccessorAccessible): Handle
3437 friend accessible properties.
3439 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
3442 2005-10-28 Marek Safar <marek.safar@seznam.cz>
3445 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
3448 * convert (Convert.ImplicitReferenceConversion): NullCast holds
3451 * ecore.cs (NullCast): Child is contant only.
3453 * literal.cs (NullLiteral.Reduce): null can be converted to any
3456 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
3458 * driver.cs: Use Encoding.Default as default code page instead
3461 2005-10-27 Raja R Harinath <rharinath@novell.com>
3464 * expression.cs (Invocation.Error_InvalidArguments): Handle
3465 __arglist parameters.
3466 (Invocation.VerifyArgumentsCompat): Likewise.
3467 * support.cs (ReflectionParameters.GetSignatureForError): Print
3468 __arglist parameters.
3469 (InternalParamters.GetSignatureForError): Likewise.
3470 * parameter.cs (Parameters.GetSignatureForError): Likewise.
3472 2005-10-26 Marek Safar <marek.safar@seznam.cz>
3474 * attribute.cs (GetPropertyValue): Made public.
3476 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
3478 Add new property WrapNonExceptionThrows to handle 2.0 assembly
3480 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
3483 * driver.cs: Reflect method name change.
3485 * statement.cs (Try.Resolve): Warn when try has both general
3488 * typemanager.cs: runtime_compatibility_attr_type new predefined
3491 2005-10-26 Raja R Harinath <harinath@gmail.com>
3494 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
3495 treat it as an empty parameter list.
3497 2005-10-26 Raja R Harinath <rharinath@novell.com>
3500 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
3501 ResolveAsTypeStep silent.
3502 * statement.cs (Block.AddConstant): Mark block as used.
3503 (Block.ResolveMeta): Avoid piling on error messages
3504 if a constant initializer resolution fails.
3506 2005-10-25 Raja R Harinath <rharinath@novell.com>
3508 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
3510 (NamespaceEntry.VerifyAllUsing): New.
3511 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
3512 behaviour. Delegates actual resolution of alias to ...
3513 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
3514 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
3516 * driver.cs (Driver.MainDriver): Update.
3518 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
3519 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
3521 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
3523 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
3524 RootNamespace.DefineNamespacesForAll.
3526 2005-10-24 Raja R Harinath <harinath@gmail.com>
3528 * typemanager.cs (assemblies, external_aliases, modules)
3529 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
3530 (ComputeNamespaces, GetRootNamespace): Remove extra staging
3531 overhead. Move resposibility ...
3532 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
3533 * driver.cs, attribute.cs, codegen.cs: Update to changes.
3535 2005-10-23 Raja R Harinath <harinath@gmail.com>
3537 * namespace.cs (RootNamespace.all_namespaces): Renamed from
3538 cached_namespaces. Improve usage.
3539 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
3540 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
3541 Move from GlobalRootNamespace and simplify.
3542 (RootNamespace.Global): Make instance variable.
3543 (RootNamespace.RootNamespace): Add "alias name" parameter.
3544 (GlobalRootNamespace): Simplify drastically.
3545 (Namespace.Lookup): Don't use GetNamespace.
3546 * typemanager.cs (GetRootNamespace): Rename from
3547 ComputeNamespaceForAlias.
3548 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
3550 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3552 * anonymous.cs (AnonymousContainer): Don't crash when container
3555 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3557 * expression.cs (Binary.DoResolve): Warn when comparing same
3560 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3563 * expression.cs (Binary.DoResolve): It looks like there are no
3564 convetsion rules in enum context.
3566 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3568 Add support for extern alias qualifiers.
3569 * typemanager.cs: Move some LookupTypeReflection code
3570 to namespace.cs, to have cleaner code. Added some methods
3571 to help us keep track of the extern aliased references.
3572 * driver.cs: Add suport for extern alias assemblies on command
3573 line and check for their warnings/errors. Also keep track of the
3574 extern aliased assemblies.
3575 * namespace.cs: Move the global functionality of Namespace
3576 to GlobalRootNamespace/RootNamespace. Now the global namespace
3577 is GlobalRootNamespace.Globa. Also the code moved from
3578 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3579 Finally added LocalAliasEntry (AliasEntry before) and
3580 ExternAliasEntry, to handle alias statements.
3581 * cs-parser.jay: Add support in the grammar for extern alias
3583 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3584 Update callings to Namespace (now in GlobalRootNamespace).
3586 2005-10-25 Martin Baulig <martin@ximian.com>
3588 * convert.cs (ImplicitTypeParameterConversion): Make base
3589 interfaces actually work; fixes #76557.
3591 2005-10-25 Martin Baulig <martin@ximian.com>
3594 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3595 all the type parameters; fixes #76551.
3597 2005-10-25 Martin Baulig <martin@ximian.com>
3602 (GenericMethod.ctor): Added `Expression return_type' and
3603 `Parameters parameters' arguments.
3604 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3605 parameter and return types to check their constraints if they're
3608 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3611 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3612 constraints of a generic type if `ec.ResolvingGenericMethod'.
3614 * class.cs (MethodCore.DoDefineParameters): Set
3615 `ec.ResolvingGenericMethod' if we're a generic method.
3616 (MemberBase.MemberType): Likewise.
3618 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3620 * typemanager.cs (TypeManager): Added
3621 TypeManager.internals_visible_attr_type to cache
3622 S.R.CompilerServices.InternalsVisibleToAttribute.
3624 * codegen.cs (AssemblyClass): Added checks for
3625 InternalsVisibleToAttribute in new method
3626 CheckInternalsVisibleAttribute () and also cache the
3627 AssemblyName in AssemblyClass.Name.
3629 2005-10-24 Martin Baulig <martin@ximian.com>
3632 (TypeManager.ExpandInterfaces): Added overloaded version which
3633 just takes a `Type[]' array.
3636 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3637 just use the interfaces which were explicitly specified and not
3638 the interfaces they inherit. Fixes #76482.
3639 (TypeParameter.FindMembers): Expand the interfaces here.
3641 2005-10-21 Martin Baulig <martin@ximian.com>
3644 (Constraints.Resolve): Also resolve the actual types here.
3645 (Constraints.ResolveTypes): Just check the constraints here.
3646 Fixes #76363; see gtest-218.cs.
3648 2005-10-21 Martin Baulig <martin@ximian.com>
3651 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3652 instead of a `BoxedCast'; fixes gtest-217.cs.
3654 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3656 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3657 1) "new()" is specified as generic parameter constraint and 2) the
3658 type is TypeBuilder and 3) the type is abstract even if it has a
3659 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3661 2005-10-20 Martin Baulig <martin@ximian.com>
3664 (GenericConstraints.TypeParameter): New public property.
3665 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3666 (TypeParameter.DeclSpace): New public property.
3667 (TypeParameter.DefineType): Inflate the constraints if our
3668 `DeclSpace' is an `Iterator'.
3670 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3672 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3673 GenericMethod argument to compare methods' generic type arguments.
3676 2005-10-19 Martin Baulig <martin@ximian.com>
3678 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3679 not ResolveType() when resolving the base type, so we're not
3680 checking the constraints here.
3681 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3684 2005-10-19 Martin Baulig <martin@ximian.com>
3686 * generic.cs (ConstructedType.CheckConstraints): Committing
3687 untested fix for #76441.
3689 2005-10-18 Raja R Harinath <rharinath@novell.com>
3692 * class.cs (TypeContainer.DefineType): Move updating of
3693 topological sort earlier in the code.
3694 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3696 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3699 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3701 * constant.cs (Constant.TryReduce): Moved from Cast class.
3702 (Reduce): Made little bit more OO and fixed missing conversions.
3704 * ecore.cs (Reduce): Implemented.
3705 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3707 * literal.cs (Reduce): Implemented.
3709 * class.cs: Reverted Miguel's wrong commit.
3711 2005-10-14 Miguel de Icaza <miguel@novell.com>
3713 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3715 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3717 * cs-parser.jay, expression.cs : CS0214 was missing error location
3718 for constants. Fixed bug #76404.
3720 2005-10-10 Raja R Harinath <rharinath@novell.com>
3722 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3724 (PropertyExpr.EmitCall): Likewise.
3725 * expression.cs (Invocation.EmitArguments): Handle case where
3727 (Invocation.EmitCall): Avoid allocating temporary variable if
3728 there are no arguments.
3730 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3733 * convert.cs (ExplicitConversionCore): Fixed object->enum
3736 2005-10-07 Raja R Harinath <rharinath@novell.com>
3739 * convert.cs (ImplicitConversionStandard): Move conversion of
3740 void* to arbitrary pointer types ...
3741 (ExplicitConversionStandard): .. here.
3742 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3743 error to always print typenames.
3745 2005-10-07 Raja R Harinath <rharinath@novell.com>
3747 * convert.cs (GetConversionOperator): Rename from
3748 GetConversionOperators. Move operator selection code from ...
3749 (UserDefinedConversion): ... here.
3751 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3753 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3756 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3758 * assign.cs (Assign.DoResolve): Error method changed.
3760 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3762 * const.cs (ResolveValue): Reset in_transit immediately.
3764 * constant.cs: Error method changed.
3766 * convert.cs: Removed useless location parameter.
3767 (ExplicitNumericConversion): Don't do double enum check.
3768 (ExplicitConversionCore): Renamed from ExplicitConversion.
3769 (ExplicitUnsafe): Extracted from ExplicitConversion.
3770 (ExplicitConversion): Uses for error reporting.
3772 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3774 (ResolveBoolean): Uses common error method.
3775 (CastToDecimal): Get rid of ec.
3776 (CastFromDecimal): Optimized.
3777 (ConvCast): Get rid of ec.
3779 * enum.cs (ResolveValue): Reset in_transit immediately.
3780 (Emit): Return after first error.
3782 * expression.cs: Convert changes.
3784 * literal.cs: Error method changed.
3786 * statement.cs: Error method changed.
3788 2005-10-06 Raja R Harinath <rharinath@novell.com>
3790 Fix gtest-131.cs and gtest-211.cs.
3791 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3792 Only emit code for a label if it is used. Unreachable code can
3793 violate ECMA evaluation stack invariants.
3795 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3797 * anonymous.cs: Implemented ExprClassName.
3799 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3802 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3805 * class.cs (StaticClass.DefineContainerMembers): Report protected
3808 * codegen.cs: if(ed) PRODUCTION.
3810 * convert.cs (Error_CannotImplicitConversion): Better error
3813 * cs-parser.jay: More error checks.
3815 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3817 * driver.cs (CSCParseOption): Enabled wrong option check.
3819 * ecore.cs (Expression.ExprClassName): Turned to property.
3820 (MemberExpr.CheckIntermediateModification): For checking boxed
3821 value types modification.
3823 * statement.cs (Fixed.Resolve): Expression type must be
3824 convertible to fixed type.
3825 (CollectionForeach.GetEnumeratorFilter,TryType):
3826 Small refactoring for easier error checking.
3828 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3830 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3833 * class.cs (GeneratedBaseInitializer): New class for customization
3834 compiler generated initializers.
3835 (MemberBase.DoDefine): Check Obsolete attribute here.
3836 (FieldMember.DoDefine): Ditto.
3838 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3841 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3842 (MemberCore.GetObsoleteAttribute): Removed argument.
3843 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3844 (MemberCore.CheckObsoleteType): New helper.
3848 * statement.cs: Updates after MemberCore changes.
3850 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3851 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3853 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3854 obsolete attribute for compiler construct.
3855 (As.DoResolve): Cache result.
3857 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3859 2005-10-01 Miguel de Icaza <miguel@novell.com>
3861 * expression.cs (Probe): instead of having a "Type probe_type"
3862 keep the extra information as a TypeExpr probe_type_expr since the
3863 "As" operator needs to perform some type checks.
3865 * (As.DoResolve): If the type is a type parameter, ensure that it
3866 is constrained by a class.
3868 2005-09-22 Miguel de Icaza <miguel@novell.com>
3870 * statement.cs (Lock): Use the TemporaryVariable class instead of
3871 manually using local variables as those do not work when variables
3874 * ecore.cs: Moved the TemporaryVariable class from being a nested
3875 class inside Foreach to be a public class that can be employed in
3878 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3880 * cs-parser.jay: interface_accessors replaced by
3881 accessor_declarations.
3883 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3886 * statement.cs (GotoCase.Resolve): Convert null constant to
3888 (SwitchLabel.ResolveAndReduce): Ditto.
3889 (SwitchLabel.NullStringCase): Custom null stamp.
3890 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3892 typemanager.cs (CSharpSignature): Don't skip first argument
3895 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3897 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3898 expression.cs, iterators.cs, literal.cs: Store constants and
3901 * class.cs (MemberBase.ShortName): Pass location.
3903 * cs-parser.jay: Some location fixes.
3905 * ecore.cs (Expression.Location): Made virtual.
3907 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3910 * const.cs (Const.ResolveValue): Check for assigning non-null
3911 value to reference type.
3913 2005-09-26 Raja R Harinath <rharinath@novell.com>
3916 * expression.cs (This.VerifyFixed): In a value type T, the type of
3917 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3918 value type R, 'this' is treated as a value parameter.
3920 2005-09-05 Miguel de Icaza <miguel@novell.com>
3922 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3923 if the underlying types are the same, otherwise we need to produce
3924 code that will do the proper cast.
3926 This was exposed by Marek's constant rewrite which produced
3927 invalid code for the call site:
3930 void Method (X v) {}
3934 This fixes test-49.cs
3936 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3938 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
3939 Type/Object should be allowed as well. Fixed bug #75968.
3941 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3943 * expression.cs : (Binary.DoResolve): when one is enum constant and
3944 another is constant 0, then return enum one *as enum type*.
3947 2005-10-04 Martin Baulig <martin@ximian.com>
3949 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
3950 `SetMemberIsUsed()' work for generics, too.
3952 2005-10-04 Martin Baulig <martin@ximian.com>
3954 * expression.cs (DelegateInvocation.EmitStatement): Make this work
3955 for corlib. Fixes #75691.
3957 2005-09-28 Marek Safar <marek.safar@seznam.cz>
3960 * driver.cs: Fix compilation files with full root path.
3962 2005-09-25 Miguel de Icaza <miguel@novell.com>
3964 * report.cs (SymbolRelatedToPreviousError): Format the output so
3965 it does not use an open parenthesis that is never closed.
3967 * driver.cs: Follow coding guidelines
3969 2005-09-18 Miguel de Icaza <miguel@novell.com>
3971 * driver.cs: Set InEmacs based on the environment variable EMACS.
3973 * location.cs (InEmacs): in this mode, do not report column
3974 location as it confuses Emacs.
3976 2005-10-03 Raja R Harinath <rharinath@novell.com>
3978 * support.cs (SeekableStreamReader.Position): Don't error out when
3979 the requested position is just beyond the end of the current
3982 2005-09-28 Raja R Harinath <rharinath@novell.com>
3984 * support.cs (SeekableStreamReader): Simplify drastically. Don't
3985 try to keep in sync with the byte count of the underlying Stream.
3986 However, this limits us to a window size of 2048 characters: i.e.,
3987 the maximum lookahead of our lexer/parser can be 2048 characters.
3989 2005-09-22 Martin Baulig <martin@ximian.com>
3991 * driver.cs: Removed a debugging FIXME.
3993 2005-09-21 Raja R Harinath <rharinath@novell.com>
3995 * cs-parser.jay (type_arguments): Add CS1644 check.
3996 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
3998 2005-09-15 Raja R Harinath <rharinath@novell.com>
4000 * Makefile (PROGRAM): Make profile specific.
4001 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
4002 the current directory.
4005 * expression.cs (Invocation.EmitCall): Remove optimization on
4006 this_call since it doesn't handle 'this' being a value type.
4008 2005-09-05 Geoff Norton <gnorton@customerdna.com>
4010 * driver.cs: Ensure file handles are closed after parsing
4012 2005-09-05 Miguel de Icaza <miguel@novell.com>
4014 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
4015 if the underlying types are the same, otherwise we need to produce
4016 code that will do the proper cast.
4018 This was exposed by Marek's constant rewrite which produced
4019 invalid code for the call site:
4022 void Method (X v) {}
4026 This fixes test-49.cs
4028 2005-09-05 Martin Baulig <martin@ximian.com>
4030 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
4031 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
4033 * cs-parser.jay (delegate_declaration): Small fix for #75852.
4035 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
4037 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
4038 to be a pointer type due to the spec 25.2, so check if declaring
4039 type is generic type definition. Fixed bug #75772.
4041 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
4044 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
4045 both types are not defined by methods.
4046 * expression.cs : (Invocation.IsApplicable): it should work when
4047 the argument type is equal to the parameter type, not only when
4048 ImplicitConversionExists() returns true.
4050 2005-09-02 Raja R Harinath <rharinath@novell.com>
4052 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
4056 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
4057 flow-branching for LocalVariableReferences in case we were invoked
4058 from a MemberAccess.
4059 * expression.cs (LocalVariableReference.VerifyAssigned): New.
4061 (LocalVariableReference.DoResolveBase): ... this.
4062 (MemberAccess.Resolve): Do the check that was disabled during
4065 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
4068 (PartialContainer.Create): check abstract/sealed/static strictly
4069 but abstract/sealed can exist only at one side. Fixed bug #75883.
4071 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
4074 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
4075 specified, don't default to UnmanagedType.I4.
4077 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
4079 * expression.cs : conditional operator should check possibly
4080 incorrect assign expression. Fixed bug #75946.
4082 2005-08-30 Raja R Harinath <rharinath@novell.com>
4085 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
4086 (ScopeInfo.EmitScopeType): Use it to construct field names from
4087 names of captured locals.
4090 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
4091 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
4092 Pass 'target_type' to BoxedCast. Don't default to 'object'.
4093 (ExplicitConversion): Remove enum cases already handled by
4094 implicit conversion. Move implicit conversion check to the beginning.
4095 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
4096 * expression.cs (ArrayCreation.EmitDynamicInitializers):
4097 Don't treat System.Enum as a struct.
4099 2005-08-30 Jb Evain <jbevain@gmail.com>
4101 * attribute.cs: handles as expression in parameters.
4103 2005-08-30 Raja R Harinath <rharinath@novell.com>
4106 * class.cs (TypeContainer.VerifyClsName): Don't use a
4107 PartialContainer when verifying CLS compliance.
4108 (AbstractPropertyEventMethod): Set Parent here, ...
4109 (PropertyMethod): ... not here.
4111 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
4113 * attribute.cs : escaped attribute name should not be allowed to be
4114 resolved (e.g. @class as classAttribute). Fixed bug #75930.
4116 2005-08-29 Raja R Harinath <rharinath@novell.com>
4119 * convert.cs (ImplicitStandardConversionExists): Allow zero also
4120 when converting a long constant to unsigned long.
4121 * expression.cs (Invocation.OverloadResolve): Add sanity check to
4122 detect where IsApplicable and VerifyArgumentsCompat disagree.
4124 2005-08-29 Raja R Harinath <rharinath@novell.com>
4125 and Carlos Alberto Cortez <carlos@unixmexico.org>
4128 * class.cs (TypeContainer.CanElideInitializer): New helper.
4129 (TypeContainer.EmitFieldInitializers): Use it to determine if we
4130 can safely emitting the initializer of a field.
4132 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4134 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
4135 allowed inside a switch (without loop). Fixed bug #75433.
4137 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4139 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4140 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4142 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4144 * driver.cs : kinda reverting the default encoding changes (not exact
4145 revert since I noticed that "codepage:reset" might not work fine).
4147 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4149 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
4150 Location. Now getter and setter store location correctly.
4151 (errors/cs0111-12.cs now reports the expected location.)
4153 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4155 * driver.cs : Use default encoding on the environment.
4156 Removed (now that) extra parameter for SeekableStreamReader.
4157 * support.cs : (SeekableStreamReader) third .ctor() argument for
4158 StreamReader is not required (always true). preamble size could
4159 be acquired in simpler and safe way.
4161 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
4163 * cs-parser.jay: report CS0642 at warning level 3
4164 and report CS0642 for an if else statement also
4165 fixes bug #74745. Patch by John Luke (and a bit
4167 Removed extra CS0642 warning check for "while",
4169 * statement.cs: In Block.Resolve(), CS0642 check
4170 is reimplemented to check a sequence of an empty
4171 statement and a block.
4173 Both fix bug #66777.
4175 2005-08-24 Marek Safar <marek.safar@seznam.cz>
4177 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
4178 detection until I fix it.
4180 * cs-tokenizer.cs: Changed error message.
4182 * cs-parser.jay: Fixed 2 error locations.
4184 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
4185 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
4188 * enum.cs (GetSignatureForError): Fixed.
4190 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
4194 * typemanager.cs (RegisterProperty): Removed.
4196 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
4198 2005-08-24 Raja R Harinath <rharinath@novell.com>
4201 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
4202 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
4204 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4206 * expression.cs : tiny fix is required for not warning positive ulong.
4209 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4211 * expression.cs : add CS0652 check for constant and integral
4212 expression. Fixed bug #53974.
4214 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4216 * expression.cs : in DoNumericPromotions(), check if there is implicit
4217 conversion overload for string (to check CS0034). Fixed bug #52492.
4219 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4221 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
4223 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4225 * ecore.cs : report location when it is *not* Null.
4227 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4233 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
4234 correctly. Fixed bug #75721.
4236 2005-08-23 Raja R Harinath <rharinath@novell.com>
4238 * support.cs (SeekableStreamReader.Position): Avoid an expensive
4239 loop that performs 'min (pos, char_count)'.
4242 * expression.cs (Unary.ResolveOperator): Don't discard implicit
4243 converted value in Operator.OnesComplement.
4245 2005-08-22 Ben Maurer <bmaurer@ximian.com>
4247 * anonymous.cs: If the anon method is pulled into a helper class,
4248 it needs to be `internal' not `private'. Fixes runtime behavior on
4251 2005-08-17 Marek Safar <marek.safar@seznam.cz>
4254 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
4257 2005-08-16 Marek Safar <marek.safar@seznam.cz>
4259 The big constants rewrite
4260 Fix #75746, #75685 and more
4261 As a side effect saved 1MB for MWF ;-)
4263 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
4264 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
4265 enum based for corlib compilation.
4267 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
4270 * class.cs (FixedField.Define): Use ResolveAsConstant.
4272 * const.cs (IConstant): Interface constants and enums.
4273 (Const.ResolveValue): New method for constant resolvning.
4274 (ExternalConstant): Constants from imported assemblies.
4276 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
4277 conversion; like enums.
4278 (Constant.ToType): Converts this constant to different type.
4279 (Constant.Increment): Adds 1.
4281 * convert.cs (ImplicitConversionRequired): Simplified.
4283 * cs-parser.jay: Create EnumMember directly.
4285 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
4287 * doc.cs (GenerateEnumDocComment): Removed.
4289 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
4290 (ConvertIntLiteral): Removed.
4291 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
4293 * enum.cs (EnumMember): Implement IConstant.
4294 (Enum.IsValidEnumConstant): Removed.
4295 (Enum.GetNextDefaultValue): Removed.
4296 (Enum.FindMembers): Updated.
4297 (Enum.GenerateDocComment): Iterate enum members.
4299 * expression.cs (Cast.TryReduce): Handle enums correctly.
4300 (New.Constantify): Made public.
4301 (MemberAccess.DoResolve): Removed contant specific if(s).
4303 * literal.cs (NullLiteral): Implement new abstract methods.
4305 * statement.cs (GotoCase.Resolve): Use new constant methods.
4306 (SwitchLabel.ResolveAndReduce): Use new constant methods.
4308 * typemanager.cs (LookupEnum): Removed.
4309 (IsEnumType): Fixed to work with corlib.
4310 (RegisterConstant): Removed.
4311 (LookupConstant): Removed.
4312 (GetConstant): Changed to work with IConstant.
4314 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
4316 * location.cs : Fixed overflown (>255) column number.
4318 2005-08-03 Raja R Harinath <rharinath@novell.com>
4320 First cut of the qualified-alias-member feature.
4321 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
4323 * cs-parser.jay (DOUBLE_COLON): New token.
4324 (namespace_or_type_name): Add rule for recognizing
4325 qualified-alias-members.
4326 (primary_expression): Likewise.
4327 (element_access): Allow QualifiedAliasMember as a possible
4328 type-bearing expression.
4329 (local_variable_type, local_variable_pointer_type): Likewise.
4330 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
4331 aliases in the current and enclosing namespace declarations.
4332 (NamespaceEntry.UsingAlias): Add CS0440 warning.
4333 * decl.cs (MemberName.is_double_colon): New.
4334 (MemberName.MemberName): Add new constructor for alias-member.
4335 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
4336 * expression.cs (QualifiedAliasMember): New expression type.
4338 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4340 * location.cs : it borked when no argument was specified.
4342 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4344 * location.cs : tiny ToString() format fix.
4346 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4348 * statement.cs : oops, it was missing.
4350 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4352 A set of fixes for precise line/column location.
4355 "token" field now holds a file/line "delta", a line number offset
4356 from the segment, and a column number. See also:
4357 http://lists.ximian.com/pipermail/mono-devel-list/2004-
4358 December/009508.html
4359 Removed static IsNull. Use instance IsNull property instead.
4361 For some tokens it stores Location. For Identifier it stores
4362 LocatedToken which is a pair of string name and location.
4363 Column numbers are adjusted only at getChar().
4365 Use Location.ToString() for reporting (it now contains column).
4367 Largely modified to use LocatedToken instead of
4368 string (IDENTIFIER), and to acquire Location from some tokens.
4369 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
4370 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
4372 Now MemberName holds Location. DeclSpace.ctor() receives Location
4373 as a parameter. Removed extra parameters to all derived classes.
4374 Replaced Location.IsNull() with instance property.
4375 * assign.cs, expression.cs :
4376 Added .ctor() overload that omits Location.
4378 Added "nameEscaped" flag that indicates the identifier was escaped
4379 in the source file. This fixes bug #57047.
4381 2005-09-02 Martin Baulig <martin@ximian.com>
4383 * class.cs: Make CS3005 a warning, not an error.
4385 2005-08-02 Marek Safar <marek.safar@seznam.cz>
4387 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
4388 New method, looking for lo-case imported cls type.
4390 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
4393 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
4395 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
4397 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
4399 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
4401 Optimized to save 3.5 MB for SWF compilation.
4403 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4405 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
4406 (PartialContainer.Create): Moved logic AddToContainer.
4407 (PartialContainer.MarkForDuplicationCheck): Shares name.
4409 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
4412 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
4414 (Namespace.GetSignatureForError): New method.
4416 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
4417 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
4419 2005-08-01 Raja R Harinath <rharinath@novell.com>
4422 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
4423 member lookup rather than qualifier_type, since qualifier_type can
4426 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4428 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
4431 2005-07-31 Miguel de Icaza <miguel@novell.com>
4433 * statement.cs: Copy the local exception into the exception
4434 captured local. Fixes 75674
4436 2005-07-31 Raja R Harinath <harinath@gmail.com>
4439 * expression.cs (Invocation.OverloadResolve): Don't report error
4440 CS1501 if error CS1502 has been reported.
4441 (New.DoResolve): Delegate CS1501 reporting to
4442 Invocation.OverloadResolve.
4445 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
4446 invariant-meaning-in-block property in an enclosing block if
4449 2005-07-29 Marek Safar <marek.safar@seznam.cz>
4451 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
4452 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
4453 (Switch.CheckSwitch): Just save 50kb for SWF.
4455 2005-07-27 Martin Baulig <martin@ximian.com>
4457 * anonymous.cs (CaptureContext.AddField): Added
4458 `AnonymousContainer am' argument; compute its toplevel scope if
4459 it's not already computed. Fixes #75649.
4461 2005-07-26 Raja R Harinath <rharinath@novell.com>
4464 * class.cs (Constructor.Emit): Reset block to null if the block
4467 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4469 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
4471 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4473 * class.cs (MethodData.Define): Check whether accessor implementing
4474 interface is public.
4476 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
4478 2005-07-22 Marek Safar <marek.safar@seznam.cz>
4481 * namespace.cs (LookupType): Moved same type check to...
4483 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
4486 2005-07-21 Raja R Harinath <rharinath@novell.com>
4488 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
4489 already found a typebuilder.
4490 * class.cs (MethodCore.IsDuplicateImplementation): Compare
4491 MemberNames, not strings.
4493 * const.cs (Error_ExpressionMustBeConst):
4494 Rename from Error_EpressionMustBeConst.
4495 * const.cs, class.cs, statement.cd: Update.
4497 2005-07-21 Marek Safar <marek.safar@seznam.cz>
4501 * const.cs (Const.LookupConstantValue): Report missing contant expression
4503 (Error_EpressionMustBeConstant): Only one error method.
4505 * class.cs, statement.c: Updated.
4507 2005-07-20 Raja R Harinath <rharinath@novell.com>
4509 * statement.cs (Block.Flags): Add back HasVarargs.
4510 (Block.flags): Make protected.
4511 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
4513 * typemanager.cs (types, typecontainers, user_types): Remove.
4514 (UserTypes, TypeContainers): Likewise.
4515 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
4516 (CleanUp, Reset): Update.
4517 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
4518 (GetNestedType): Use Type.GetNestedType.
4519 (CoreLookupType): Take two arguments, the namespace and the
4520 basename of the type. Update to use the Namespace.Lookup
4522 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
4523 (RealMemberLookup): Use IsNestedChildOf instead of playing with
4524 string concatenation and substring matches.
4525 * class.cs, enum.cs, delegate.cs: Update to changes.
4527 2005-07-20 Marek Safar <marek.safar@seznam.cz>
4529 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
4530 Expression and made virtual.
4532 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
4533 (ImplicitStandardConversionExists): Fixed `byte' typo ?
4535 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
4537 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
4540 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
4543 2005-07-18 Marek Safar <marek.safar@seznam.cz>
4546 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
4547 AssemblyCultureAttribute is not used on executable.
4550 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
4552 2005-07-16 Raja R Harinath <rharinath@novell.com>
4555 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
4556 New. Reports CS0252/CS0253.
4557 Mostly taken from preliminary patch by Duncak Mak.
4558 (Binary.DoResolveOperator): Store results of operator lookup.
4559 Use them to detect if we need to warn about unintended reference
4562 2005-07-15 Raja R Harinath <rharinath@novell.com>
4565 * namespace.cs (Namespace.Lookup): Add back location parameter.
4566 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4567 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4569 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4570 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4571 (Namespace.LookupType): ... this.
4572 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4574 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4575 purported to handle pointers.
4576 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4579 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4581 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4584 2005-07-15 Raja R Harinath <rharinath@novell.com>
4586 * namespace.cs (Namespace.Lookup): Drop location parameter.
4587 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4588 (NamespaceEntry.Lookup): ... this.
4589 (NamespaceEntry.Error_AmbiguousTypeReference):
4590 Move here from DeclSpace.
4591 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4593 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4594 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4595 Move to NamespaceEntry.
4596 * delegate.cs, expression.cs: Update to changes.
4598 2005-08-31 Martin Baulig <martin@ximian.com>
4600 Committing a patch from Atsushi Enomoto for #75850.
4602 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4603 Prefer a generic enumerator over a non-generic one.
4605 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4607 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4608 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4610 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4612 * driver.cs : reverting default encoding change as well as mcs.
4614 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4616 * driver.cs, support.cs : merged r48826.
4618 > could you integrate your mcs changes to gmcs otherwise
4619 > gmcs cannot compile some files.
4621 2005-08-20 Martin Baulig <martin@ximian.com>
4623 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4624 scope if we don't already have it.
4626 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4627 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4630 2005-07-31 Miguel de Icaza <miguel@novell.com>
4632 * statement.cs: Copy the local exception into the exception
4633 captured local. Fixes 75674
4635 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4637 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4640 2005-08-12 Martin Baulig <martin@ximian.com>
4642 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4643 for nested types here to avoid hitting the cache too early.
4645 2005-08-09 Miguel de Icaza <miguel@novell.com>
4647 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4650 2005-08-03 Martin Baulig <martin@ximian.com>
4652 Make iterators in generic methods work; see gtest-191.cs.
4655 (Constraints.Resolve): Protect against being called twice.
4658 (TypeContainer.GetClassBases): Make this `protected virtual'.
4660 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4661 (Iterator.GetClassBases): Override this and compute the base
4663 (Iterator.DefineNestedTypes): If we're a generic method, all our
4664 method type parameters become class type parameters on the proxy
4668 (ToplevelBlock.Parameters): Make this a property, not a field.
4669 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4671 2005-08-03 Martin Baulig <martin@ximian.com>
4673 * typemanager.cs (TypeManager.IsSubclassOf): Use
4674 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4675 (TypeManager.GetFullName_recursed): Improved.
4677 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4680 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4681 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4682 invocation_type == mi.DeclaringType, since the first one also checks
4683 other condition used by generic instances.
4685 2005-07-27 Martin Baulig <martin@ximian.com>
4687 * anonymous.cs (CaptureContext.AddField): Added
4688 `AnonymousContainer am' argument; compute its toplevel scope if
4689 it's not already computed. Fixes #75649.
4691 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4693 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4694 CheckAttributeType and refactored.
4695 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4696 ResolveAsTypeTerminal error handling.
4697 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4699 (GetSignatureForError): Print errors in same way.
4702 * codegen.cs: Reflect attribute GetSignatureForError change.
4705 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4707 * namespace.cs (UsingEntry): Refactored to make fields private.
4710 statement.cs: Error_UnexpectedKind has extra parameter.
4712 2005-07-14 Raja R Harinath <rharinath@novell.com>
4714 * ecore.cs (IAlias): Remove.
4715 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4716 that implement the interface.
4717 * namespace.cs (Namespace): Likewise.
4718 (Namespace.declspaces): Renamed from 'defined_names'.
4719 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4720 DeclSpace instead of an IAlias.
4721 * tree.cs (Tree.AddDecl): Update.
4723 2005-07-12 Raja R Harinath <rharinath@novell.com>
4725 * statement.cs (Block.Flags); Remove HasVarargs.
4726 (Block.HasVarargs): Move to ToplevelBlock.
4727 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4728 (Block.Variables): Make protected. Initialize variable hashtable
4730 (Block.AddVariable): Update.
4731 (Block.Resolve): Update to changes.
4732 (ToplevelBlock.HasVarargs): New boolean.
4733 (ToplevelBlock.ThisVariable): Move here from Block.
4734 (ToplevelBlock.AddThisVariable): Likewise.
4735 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4736 * expression.cs (This.ResolveBase): Update to changes.
4737 (ArglistAccess.DoResolve): Likewise.
4739 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4742 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4744 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4745 not used and not used & assigned.
4746 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4748 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4751 * expression.cs (Is.DoResolve): null is never provided type.
4753 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4756 * cs-parser.jay: Less strict event error rule to catch more errors.
4758 2005-07-11 Martin Baulig <martin@ximian.com>
4760 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4761 for the constructor constraint: we do not only have to check
4762 whether the class has a public constructor, but also ensure that
4763 it's parameterless. Fixes #75492.
4765 2005-07-11 Martin Baulig <martin@ximian.com>
4767 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4768 between type parameters if they either have the reference type
4769 constraint or the class constraint.
4771 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4773 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4775 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4778 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4779 (ExtractSecurityPermissionSet): Cope with self referencing security
4780 attributes properly.
4782 * driver.cs (SetOutputFile): Made public property OutputFile.
4784 2005-07-07 Raja R Harinath <rharinath@novell.com>
4787 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4788 has_nonstatic_fields. Make into a FieldBase pointer.
4789 (TypeContainer.AddField): Add CS0282 check.
4790 (TypeContainer.EmitType): Update.
4792 2005-07-06 Miguel de Icaza <miguel@novell.com>
4794 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4795 compare if they start with __.
4797 2005-07-06 Raja R Harinath <rharinath@novell.com>
4799 * statement.cs (Switch.SwitchGoverningType): Only look at
4800 UserCasts that don't need implicit standard conversions to one of
4801 the allowed switch types (Fixes test-322.cs).
4802 (LocalInfo.Resolve): Re-enable sanity-test.
4804 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4806 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4808 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4810 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4812 2005-07-06 Raja R Harinath <rharinath@novell.com>
4815 * ecore.cs (SimpleName.GetSignatureForError): Add.
4816 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4817 (MemberAccess.GetSignatureForError): Add.
4819 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4821 The big error and warning messages review.
4851 * typemanager.cs: Updated.
4853 * class.cs: (MethodCore.SetYields): Moved here to share.
4854 (PropertyMethod.Define): Moved iterator setup here.
4856 * iterators.cs: Add orig_method to have full access to parent
4859 2005-07-05 Raja R Harinath <rharinath@novell.com>
4861 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4862 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4863 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4864 variable of struct type.
4865 * expression.cs (Unary.ResolveOperator): Update to change.
4866 (Indirection.VerifyFixed): Likewise.
4867 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4868 (ParameterReference.VerifyFixed): Value parameters are fixed.
4869 (This.VerifyFixed): Treat 'this' as a value parameter.
4870 * statement.cs (LocalInfo.IsFixed): Remove.
4872 2005-07-01 Martin Baulig <martin@ximian.com>
4874 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4875 `ec.EmitThis ()' to get the correct scope.
4877 2005-07-01 Martin Baulig <martin@ximian.com>
4879 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4880 instance is a ParameterReference; fixes #75299.
4882 2005-06-30 Raja R Harinath <rharinath@novell.com>
4885 * expression.cs (Indexers.map): Remove.
4886 (Indexers.Append): Filter out inaccessible setters and getters.
4887 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4890 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4892 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4893 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4894 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4895 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4897 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4900 * class.cs (FieldBase.GetInitializerExpression): One more field
4903 2005-06-28 Miguel de Icaza <miguel@novell.com>
4905 * pending.cs: Do not define a proxy if the base method is virtual,
4906 it will be picked up by the runtime (bug 75270).
4908 2005-07-08 Martin Baulig <martin@ximian.com>
4910 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4911 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4913 2005-07-07 Martin Baulig <martin@ximian.com>
4915 * generic.cs (ConstructedType.CheckConstraint): Use
4916 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4917 called recursively; fixes #75329.
4919 2005-07-06 Martin Baulig <martin@ximian.com>
4921 * generic.cs (TypeManager.InferTypeArguments): Added support for
4922 anonymous methods; fixes #75461.
4924 2005-07-01 Martin Baulig <martin@ximian.com>
4926 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4927 `ec.EmitThis ()' to get the correct scope.
4929 2005-07-01 Martin Baulig <martin@ximian.com>
4931 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
4932 instance is `This'; fixes #75299.
4934 2005-06-30 Martin Baulig <martin@ximian.com>
4936 * class.cs (Indexer): Implement IIteratorContainer; added support
4937 for iterators in indexers.
4940 (EmitContext.CurrentIterator): Make this a property, not a field.
4942 * anonymous.cs (AnonymousContainer.Iterator): New public property.
4944 2005-06-28 Miguel de Icaza <miguel@novell.com>
4946 * pending.cs: Do not define a proxy if the base method is virtual,
4947 it will be picked up by the runtime (bug 75270).
4949 2005-06-28 Martin Baulig <martin@ximian.com>
4951 * cs-parser.jay (interface_method_declaration): Avoid a
4952 reduce/reduce conflict by moving some of the code into a separate
4953 `interface_method_declaration_body' rule; fixes #75368.
4955 2005-06-28 Martin Baulig <martin@ximian.com>
4957 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
4958 array check after the check for TypeBuilder's.
4960 2005-06-21 Raja R Harinath <rharinath@novell.com>
4962 * convert.cs (FindMostEncompassedType): Add two trivial special
4963 cases (number_of_types == 0 || number_of_types == 1).
4964 (FindMostEncompasingType): Likewise.
4966 2005-06-17 Raja R Harinath <rharinath@novell.com>
4968 Some cleanups preparing for the fix of #75283.
4969 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
4971 (EventExpr.InstanceResolve): Likewise.
4972 (EventExpr.DoResolve): Remove redundant checks.
4974 2005-06-08 Miguel de Icaza <miguel@novell.com>
4976 * class.cs: Small fix.
4978 2005-06-08 Raja R Harinath <rharinath@novell.com>
4981 * class.cs (GetPartialBases): Fix return value check of
4984 2005-06-07 Raja R Harinath <rharinath@novell.com>
4986 Ensure that partial classes are registered in their enclosing
4987 namespace. Initial part of fix of #75160.
4988 * tree.cs (Tree.RecordDecl): Add new namespace argument.
4989 Register declspace with namespace here, not in
4990 DeclSpace.RecordDecl.
4991 * cs-parser.jay: Pass namespace to RecordDecl.
4992 * class.cs (PartialContainer.Create): Likewise.
4993 (ClassPart.DefineType): New sanity-check. Throws an exception if
4995 * decl.cs (Declspace.RecordDecl): Remove.
4996 * namespace.cs (NamespaceEntry.DefineName): Remove.
4998 2005-06-06 Marek Safar <marek.safar@seznam.cz>
5000 * rootcontext.cs: Reset TargetExt as well.
5002 2005-06-03 Raja R Harinath <rharinath@novell.com>
5004 * ecore.cs (Expression.Resolve): Emit CS0654 error when
5007 2005-06-02 Raja R Harinath <rharinath@novell.com>
5009 Fix #75080, cs0119.cs.
5010 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
5012 (Expression.Resolve): ... this. Use it. Remove bogus code
5013 allowing ExprClass.Type and ExprClass.Namespace for
5014 ResolveFlags.VariableOrValue.
5015 (Expression.Resolve) [1-argument variant]: Change default resolve
5016 flags based on language version.
5017 (Expression.Error_UnexpectedKind): Use a simple string array
5018 rather than an ArrayList.
5019 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
5021 (TypeOfVoid.DoResolve): Likewise.
5022 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
5023 flags argument -- it always has the same value.
5025 2005-05-31 Raja R Harinath <rharinath@novell.com>
5028 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
5029 Use it in the error message.
5030 * assign.cs, expression.cs, statement.cs: Update.
5032 2005-05-30 Raja R Harinath <rharinath@novell.com>
5035 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
5036 the "almostMatchedMember" case too.
5037 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
5038 that failed the accessibility checks to 'almost_match'.
5040 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
5042 * attribute.cs: Use internal MethodBuilder methods to set
5043 ExactSpelling and SetLastError on PInvoke methods, instead
5044 of passing them via charset. Fixes #75060.
5046 2005-05-27 Raja R Harinath <rharinath@novell.com>
5048 * parameter.cs (Parameter): Remove TODO comment.
5049 (Parameter.DefineParameter): Remove Location parameter.
5050 (Parameters.LabelParameters): Likewise.
5051 * class.cs (Constructor.Emit): Update to change.
5052 (MethodData.Emit): Likewise.
5053 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
5054 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
5056 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
5059 Removed Parameters.Location and added Parameter.Location instead.
5060 Removed Location parameter from Emit() and GetSignature().
5067 Modified all related calls.
5069 2005-06-21 Martin Baulig <martin@ximian.com>
5071 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
5072 left-hand side is not a nullable type; fixes #75328.
5074 2005-06-21 Martin Baulig <martin@ximian.com>
5077 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
5078 (TypeManager.GetFullNameSignature): Likewise.
5080 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
5081 `source.FullName' and `target.FullName' to check whether there are
5082 two conflicting definitions.
5084 2005-06-21 Martin Baulig <martin@ximian.com>
5086 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
5087 a BoxedCast - also for reference types - to be compatible with csc.
5089 2005-06-21 Martin Baulig <martin@ximian.com>
5091 * expression.cs (MemberAccess.DoResolve): Add support for nested
5092 types in a generic instance; fixes #75320.
5094 2005-06-20 Martin Baulig <martin@ximian.com>
5096 * generic.cs (TypeManager.InferType): Also walk the class
5097 hierarchy for generic instances; fixes #75261.
5099 2005-06-17 Martin Baulig <martin@ximian.com>
5101 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
5102 to make things work for corlib.
5104 2005-06-15 Martin Baulig <martin@ximian.com>
5106 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
5107 obsolete `SecurityAction' values.
5109 2005-06-06 Marek Safar <marek.safar@seznam.cz>
5111 * rootcontext.cs: Reset TargetExt as well.
5113 2005-06-09 Martin Baulig <martin@ximian.com>
5115 * delegate.cs (Delegate.VerifyMethod): Added
5116 `MethodGroupExpr old_mg' argument; inherit its
5117 `HasTypeParameters'; fix #75085.
5119 2005-06-09 Martin Baulig <martin@ximian.com>
5121 * expression.cs (Invocation.OverloadResolve): Correctly handle
5122 generic methods for the SetMemberIsUsed(); fix #75064.
5124 2005-06-09 Martin Baulig <martin@ximian.com>
5126 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
5129 2005-06-08 Martin Baulig <martin@ximian.com>
5131 * cs-parser.jay (nullable_type_or_conditional): If we put the
5132 nullable back and our `type' is a `ComposedCast', remove the
5133 nullable from it. Fixes #75156.
5135 * expression.cs (ComposedCast.RemoveNullable): New public method.
5137 2005-06-08 Martin Baulig <martin@ximian.com>
5139 The big Iterators rewrite :-)
5141 * iterators.cs: Rewrite this to use the anonymous methods framework.
5143 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
5144 before the TypeContainers; see 2test-21.cs.
5147 (TypeContainer.DefineType): Don't create a new EmitContext if we
5148 already have one (this only happens if we're an Iterator).
5149 (TypeContainer.Define): Also call Define() on all our iterators.
5150 (Method.CreateEmitContext): Added support for iterators.
5153 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
5154 (AnonymousContainer.CreateMethodHost): Moved here from
5155 AnonymousMethod and made abstract.
5156 (AnonymousContainer.CreateScopeType): New abstract method.
5157 (AnonymousContainer.IsIterator): New public property.
5158 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
5159 get the ScopeTypeBuilder rather than manually defining it here.
5160 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
5163 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
5164 before RootContext.DefineTypes().
5166 * codegen.cs (EmitContext.RemapToProxy): Removed.
5167 (EmitContext.CurrentAnonymousMethod): Changed type from
5168 AnonymousMethod -> AnonymousContainer.
5169 (EmitContext.ResolveTopBlock): Protect from being called twice.
5170 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
5171 (EmitContext.EmitThis): Removed the iterators hacks; use the
5172 anonymous methods framework for that.
5175 (ToplevelBlock.Container): Make this a property, not a field.
5176 (ToplevelBlock.ReParent): New public method; move the
5177 ToplevelBlock into a new container.
5178 (Foreach.TemporaryVariable): Simplify.
5180 2005-06-05 Martin Baulig <martin@ximian.com>
5182 * statement.cs (LocalInfo.CompilerGenerated): New flag.
5183 (Block.AddTemporaryVariable): New public method; creates a new
5184 `LocalInfo' for a temporary variable.
5185 (Block.EmitMeta): Create the LocalBuilders for all the temporary
5187 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
5188 non-iterator variables.
5190 2005-06-05 Martin Baulig <martin@ximian.com>
5192 * statement.cs (Foreach.TemporaryVariable): Create the
5193 LocalBuilder in the Emit phase and not in Resolve since in some
5194 situations, we don't have an ILGenerator during Resolve; see
5195 2test-19.cs for an example.
5197 2005-06-04 Martin Baulig <martin@ximian.com>
5199 The big Foreach rewrite - Part II.
5201 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
5202 with `PropertyInfo ienumerator_getcurrent'.
5204 * codegen.cs (VariableStorage): Removed.
5207 (Foreach): Derive from Statement, not ExceptionStatement.
5208 (Foreach.CollectionForeach): New nested class. Moved all the code
5209 dealing with collection foreach here.
5210 (Foreach.ForeachHelperMethods): Removed.
5211 (Foreach.TemporaryVariable): Implement IMemoryLocation.
5213 2005-05-23 Martin Baulig <martin@ximian.com>
5215 * statement.cs (Try.DoResolve): Don't create a `finally' if we
5216 don't need to. Fix #75014.
5218 2005-05-26 Raja R Harinath <rharinath@novell.com>
5220 Improve user-defined conversion handling.
5221 * convert.cs (GetConversionOperators): Rewrite. Return only the
5222 applicable operators.
5223 (AddConversionOperators): New. Helper for GetConversionOperators.
5224 (FindMostEncompassedType, FindMostEncompassingType): Verify that
5225 there is only one most encompassed/encompassing type.
5226 (FindMostSpecificSource, FindMostSpecificTarget): Remove
5227 "applicable operator" handling.
5228 (UserConversion): Move cache here from GetConversionOperators.
5229 Directly cache the chosen operator, rather than the whole
5231 (ExplicitNumericConversion): Fix buggy implementation of Decimal
5232 case. Allow conversion of decimal to sbyte and byte too.
5233 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5234 New static methods. Used to avoid allocating EmptyExpressions in
5237 2005-05-24 Duncan Mak <duncan@novell.com>
5239 * ecore.cs (CastFromDecimal): New class for casting a decimal to
5240 another class, used in Convert.ExplicitNumericConversion.
5241 (CastToDecimal): New class, similar to above, but casts to
5242 System.Decimal, used in Convert.ImplicitNumericConversion and also
5243 in explicit convesion from double/float to decimal.
5245 * convert.cs (ImplicitNumericConversion): Handle implicit
5246 conversions to System.Decimal.
5247 (ExplicitNumericConversion): handle explicit conversions to
5252 2005-05-20 Miguel de Icaza <miguel@novell.com>
5254 * typemanager.cs: Do not throw an exception in the TypeBuilder
5255 case, we take care of it on the TypeCode.
5257 2005-05-17 Marek Safar <marek.safar@seznam.cz>
5259 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
5262 * cs-parser.jay: Catch more lexical errors.
5264 * report.cs: Add one more Error method.
5267 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
5269 2005-05-20 Martin Baulig <martin@ximian.com>
5271 * class.cs (TypeContainer.CircularDepException): Removed.
5272 (TypeContainer.DefineType): Removed the `InTransit' stuff.
5273 (TypeContainer.CheckRecursiveDefinition): Check for circular class
5274 (CS0146) and interface (CS0529) dependencies here.
5276 2005-05-20 Martin Baulig <martin@ximian.com>
5278 * expression.cs (New.DoResolve): Move the CS0712 check above the
5279 CS0144 check; otherwise it can never be reached.
5281 2005-05-20 Martin Baulig <martin@ximian.com>
5283 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
5285 2005-05-20 Martin Baulig <martin@ximian.com>
5287 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
5289 * typemanager.cs (TypeManager.IsAttributeType): New public method.
5291 2005-05-19 Martin Baulig <martin@ximian.com>
5294 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
5295 to disable error reporting.
5297 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
5298 here since we don't want to report an error; see the new test-336.cs.
5300 2005-05-19 Raja R Harinath <rharinath@novell.com>
5302 * statement.cs (ToplevelBlock.GetParameterReference)
5303 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
5304 Move here from class Block.
5305 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
5306 * expression.cs (ParameterReference.DoResolveBase): Likewise.
5308 2005-05-18 Martin Baulig <martin@ximian.com>
5313 (FlowBranching.Reachability): Add non-static public And() and Or()
5315 (FlowBranchingSwitch): New class; do the `break_origins' thing
5316 like in FlowBranchingLoop.
5317 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
5318 reachability, not just locals and parameters.
5319 (FlowBranching.MergeChild): Remove some of the hacks for loop and
5320 switch; MergeBreakOrigins() now takes care of that.
5322 2005-05-18 Martin Baulig <martin@ximian.com>
5324 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
5325 a loop and may leave it, reset the barrier; fixes #74974.
5327 2005-05-16 Raja R Harinath <rharinath@novell.com>
5329 Fix test-382.cs. Emit values of decimal constants.
5330 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
5332 (TypeContainer.AddField): ... this.
5333 (TypeContainer.EmitFieldInitializers): Allow the list of fields
5334 with initializers to include 'Const's.
5335 (ClassPart.RegisterFieldForInitialization): Forward to
5337 * const.cs (Const.Const): Pass initializer to base class.
5338 (Const.Define): In case of decimal constants, register them for
5339 initialization in a static constructor.
5341 2005-05-14 Martin Baulig <martin@ximian.com>
5343 * statement.cs (Block.Resolve): Correctly handle unreachable code;
5344 do not call ResolveUnreachable() on unreachable statements in
5345 here, see the comment in the source code.
5347 2005-05-13 Raja R Harinath <rharinath@novell.com>
5350 * expression.cs (BinaryResolveOperator): If one of the operands of
5351 an equality comparison is 'null' and the other is a pointer type,
5352 convert the null to a NullPointer.
5353 * convert.cs (ImplicitReferenceConversion): If the expression is a
5354 NullLiteral and the target type is a pointer type, return a
5355 NullPointer instead.
5356 (ImplicitConversionStandard): Likewise.
5358 2005-05-13 Marek Safar <marek.safar@seznam.cz>
5360 * cs-parser.jay: Set readonly context based on special constructs.
5362 * expression.cs (LocalVariableReference.DoResolveBase): Improved
5363 readonly variable error handling.
5365 * rootcontext.cs (EmitCode): Don't verify members when error
5368 * statement.cs (LocalInfo): Add reaodnly context information.
5369 (SetReadOnlyContext, GetReadOnlyContext): New methods.
5371 2005-05-17 Martin Baulig <martin@ximian.com>
5373 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
5376 2005-05-13 Martin Baulig <martin@ximian.com>
5378 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
5379 handle unreachable blocks.
5381 2005-05-13 Martin Baulig <martin@ximian.com>
5384 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
5385 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
5388 2005-05-13 Martin Baulig <martin@ximian.com>
5390 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
5391 instance variable, not a local. Fix #74873.
5392 (Block.ResolveUnreachable): Set it to true here.
5394 2005-05-12 Martin Baulig <martin@ximian.com>
5396 * cs-parser.jay (property_declaration): Pass the `current_class',
5397 not the `current_container' to Property's .ctor. Fixes #74912.
5399 2005-05-11 Martin Baulig <martin@ximian.com>
5401 * typemanager.cs (Closure): Copy this from MCS and merge all the
5402 GMCS-specific changes into it.
5404 2005-05-12 Raja R Harinath <harinath@gmail.com>
5407 * typemanager.cs (unmanaged_enclosing_types): New.
5408 (IsUnmanagedType): Avoid infloops by using
5409 'unmanaged_enclosing_types' to talk with recursive invocations.
5411 2005-05-11 Duncan Mak <duncan@novell.com>
5413 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
5414 continuing to process for 'arg'.
5415 (handle_preprocessing_directive): Check the argument of the #endif
5416 directive and report error CS1025 if there are any trailing
5419 According to the C# spec, having even whitespace after the #endif
5420 directive is illegal; however, because we call arg.TrimEnd ()
5421 beforehand, we have the same behavior as csc, allowing whitespace
5422 after the directive.
5426 2005-05-11 Marek Safar <marek.safar@seznam.cz>
5430 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
5431 (Constructor.GetObsoleteAttribute): Implemented correctly.
5433 2005-05-10 Martin Baulig <martin@ximian.com>
5435 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
5436 resolve the type; fixes #74864.
5437 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
5438 in DoResolve(); fixes #74862.
5440 2005-05-10 Martin Baulig <martin@ximian.com>
5442 * support.cs (ReflectionParameters.ParameterModifier): Use
5443 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
5444 and `ParameterAttributes.In'. Fixes #74884.
5446 2005-05-10 Martin Baulig <martin@ximian.com>
5448 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
5449 the cache if we're just looking for `MemberTypes.NestedType' in a
5452 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
5453 constraints if we're still resolving the type tree.
5454 (Expression.MemberLookup): If we're resolving the type tree, only
5455 look for `MemberTypes.NestedType' since we're only interested in
5458 * class.cs (TypeContainer.DefineType): Don't resolve the type
5459 parameters here; do this later in ResolveType() after the type
5460 tree has been resolved.
5461 (TypeContainer.ResolveType): New public method; this is called
5462 after the type tree is resolved and before the types are being
5463 populated. We resolve the generic constraints here.
5464 (TypeContainer.DoDefineMember): Check the constraints on our base
5465 class and interfaces.
5467 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
5468 set the `ResolvingTypeTree' flag on the EmitContext.
5470 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
5472 2005-05-10 Marek Safar <marek.safar@seznam.cz>
5474 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
5476 * expression.cs (Argument.GetParameterModifier): Turned to property.
5477 (Invocation.Error_InvalidArguments): Add more descriptive errors.
5479 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
5482 2005-05-09 Raja R Harinath <rharinath@novell.com>
5485 * decl.cs (MemberCache.AddMethods): Register override methods,
5486 rather than non-override methods.
5487 * typemanager.cs (RegisterOverride): New.
5488 (IsOverride): Update.
5490 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5492 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
5494 2005-05-06 Martin Baulig <martin@ximian.com>
5497 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
5498 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
5500 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5504 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
5505 recursive declaration.
5507 * statement.cs (Block.ResolveMeta): Report any error in resolving.
5509 2005-05-06 Marek Safar <marek.safar@seznam.cz>
5511 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
5513 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
5515 2005-05-05 Raja R Harinath <rharinath@novell.com>
5518 * decl.cs (DeclSpace.FamilyAccessible):
5519 Use TypeManager.IsNestedFamilyAccessible.
5521 Fix reopened #64812.
5522 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
5525 2005-05-04 Raja R Harinath <rharinath@novell.com>
5526 Abin Thomas <projectmonokochi@rediffmail.com>
5527 Anoob V E <projectmonokochi@rediffmail.com>
5528 Harilal P R <projectmonokochi@rediffmail.com>
5531 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
5532 allow access to all static members.
5534 2005-05-04 Martin Baulig <martin@ximian.com>
5536 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
5538 2005-05-04 Martin Baulig <martin@ximian.com>
5542 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
5543 section at the end; make things work if `default' is not the last
5546 2005-05-04 Martin Baulig <martin@ximian.com>
5550 * statement.cs (Switch): Replaced the `got_default' field with a
5551 `default_section' one.
5552 (Switch.CheckSwitch): Set `default_section' here.
5553 (Switch.Resolve): If we're a constant switch and the constant is
5554 not found, use the default section.
5556 2005-05-03 Martin Baulig <martin@ximian.com>
5558 * expression.cs (ArrayAccess.EmitGetLength): New public method.
5560 * statement.cs (Foreach.ArrayForeach): New nested class.
5561 (Foreach.TemporaryVariable): New nested class.
5562 (Foreach.EmitArrayForeach): Removed; this is now in the new
5565 2005-05-03 Raja R Harinath <rharinath@novell.com>
5567 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5569 (VerifyPendingMethods): Revert change below.
5571 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5572 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5573 that used to trigger warning -28. Remove warning -28.
5574 * expression.cs (Invocation.OverloadResolve): Use
5575 TypeManager.IsOverride to distinguish override methods.
5578 * pending.cs (VerifyPendingMethods): If a base type implements the
5579 requested interface, don't bother checking individual methods of
5580 the base type. As a side-effect, this prevents the creation of
5581 unnecessary proxies.
5583 2005-05-02 Martin Baulig <martin@ximian.com>
5587 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5588 Also `And' the locals if the old vector is null.
5589 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5590 null; in this case we basically reset all the variables.
5592 2005-05-02 Martin Baulig <martin@ximian.com>
5596 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5597 Added `FlowBranching branching' argument; always `and' the
5598 variables instead of `or'ing them unless we're an infinite loop.
5600 * statement.cs (While.Resolve): Create a new sibling unless we're
5603 2005-05-02 Martin Baulig <martin@ximian.com>
5607 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5608 arguments; use it instead of creating a new TopLevelBlock.
5609 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5610 our ConstructorInitializer.
5613 (TopLevelBlock.TopLevelBranching): New public property.
5614 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5615 and create our `TopLevelBranching'.
5617 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5618 anonymous method host, use `block.TopLevelBranching' rather than
5619 creating a new branching.
5621 2005-04-20 Miguel de Icaza <miguel@novell.com>
5623 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5624 a ScopeInfo, if any of the current children is a child of the new
5625 entry, move those children there.
5627 2005-04-30 Martin Baulig <martin@ximian.com>
5629 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5630 at the beginning of a SwitchSection. Fix #73335.
5632 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5635 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5637 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5638 (FieldExpr.DoResolve): Obsolete members are ignored for field
5641 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5643 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5644 of arrays detection.
5646 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5648 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5650 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5653 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5655 * cs-parser.jay: Use the prefered version of -unsafe in error
5658 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5660 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5663 2005-04-20 John Luke <john.luke@gmail.com>
5665 * driver.cs: fix typo in error message, --outout to --output
5667 2005-04-30 Martin Baulig <martin@ximian.com>
5669 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5670 handle the .NET 2.x security attributes.
5672 2005-04-30 Martin Baulig <martin@ximian.com>
5675 (TypeManager.ExpandInterfaces): Don't add things twice.
5678 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5680 2005-04-29 Martin Baulig <martin@ximian.com>
5682 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5684 * anonymous.cs: Added support for anonymous generic methods.
5686 2005-04-29 Martin Baulig <martin@ximian.com>
5688 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5691 2005-04-29 Martin Baulig <martin@ximian.com>
5693 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5695 * expression.cs (New.DoResolve): Fix the CS0304 check.
5697 2005-04-29 Martin Baulig <martin@ximian.com>
5699 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5702 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5703 explicit interface implementation, compare the interface types.
5704 (MethodData.Define): Use the new naming scheme from the latest
5706 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5708 * decl.cs (MemberName.GetMemberName): Removed.
5709 (MemberName.MethodName, FullName): New properties.
5711 2005-04-25 Raja R Harinath <rharinath@novell.com>
5713 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5715 2005-04-22 Martin Baulig <martin@ximian.com>
5717 * generic.cs (GenericMethod): Create the EmitContext in the
5718 `Define()'; in `Define(MethodBuilder)', create the type parameters
5719 before calling `Define()'. Fixes #73933.
5721 2005-04-22 Martin Baulig <martin@ximian.com>
5724 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5725 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5727 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5728 ConstructedType, check its constraints.
5730 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5732 * codegen.cs (InRefOutArgumentResolving): New field.
5734 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5735 fields outside contructor.
5737 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5739 2005-04-19 Miguel de Icaza <miguel@novell.com>
5741 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5742 parameter code was not completed ever, so it was not as up-to-date
5743 as local variables. Must finish it.
5745 The bug fix was to compare the Toplevel of the block, not the
5746 current block. Thanks for Ben for pointing this out.
5748 2005-04-19 Raja R Harinath <rharinath@novell.com>
5750 * decl.cs (AddMethods): Use the declaring type of the problem
5751 method to determine if we want to squash a warning.
5753 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5755 * attribute.cs: Removed debug output.
5757 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5759 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5762 2005-04-18 Raja R Harinath <rharinath@novell.com>
5765 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5766 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5767 all null comparisons against reference types.
5769 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5772 * class.cs (TypeContainer.CircularDepException) New nested
5774 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5775 (TypeContainer.DefineType): Removed error, reset InTransit before
5777 (Class.DefineType): Throw exception when is in Transit.
5778 Catch exception and report error.
5779 (Struct.DefineType): Throw exception when is in Transit.
5780 Catch exception and report error.
5781 (Interface.DefineType): Throw exception when is in Transit.
5782 Catch exception and report error.
5784 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5785 handle nested exception handlers.
5787 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5790 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5791 InFinally and InCatch storage.
5793 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5794 (Catch.Resolve): Set and Restore ec.InCatch.
5795 (Try.Resolve): Set and Restore ec.InFinally.
5796 (Try.HasCatch): True when try has catch.
5798 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5800 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5801 for the same event member, so exclude such cases from warning 419.
5804 2005-04-16 Miguel de Icaza <miguel@novell.com>
5806 * expression.cs (Binary.ResolveOperator): Apply patch from John
5807 Luke to fix bug 59864: operators &, | and ^ on enumerations
5808 require that the same enum type on both sides.
5810 * driver.cs: Add warnings to old flag usage, this is to assist
5811 people who produce Makefiles and hope that the Makefiles will be
5814 * class.cs (TypeContainer.EmitType): Moved the definition of the
5815 special $PRIVATE$ field from the resolve phase to the Emit phase.
5816 During resolve we do not know if we are a struct with
5817 HasExplicitLayout, we know this only after the attributes for the
5820 Set the FieldOffset to zero on the dummy field that we create for
5821 the class. Fixes 74590.
5823 2005-04-16 Raja R Harinath <rharinath@novell.com>
5826 * ecore.cs (PropertyExpr.resolved): New.
5827 (DoResolve): Use it to handle a case of double resolution here.
5828 Handle a case of identical-name-and-type-name.
5829 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5830 resolution by storing the results of expression resolution back
5831 into the "probes" array.
5833 2005-04-15 Raja R Harinath <rharinath@novell.com>
5835 Fix cs0208-7.cs and cs0208-8.cs.
5836 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5837 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5838 error reporting to point out the reason a struct is not unmanaged.
5840 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5842 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5843 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5845 2005-04-13 Raja R Harinath <rharinath@novell.com>
5848 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5849 IdenticalNameAndTypeName here.
5850 (EventExpr.InstanceResolve): Likewise.
5852 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5854 C# 2.0 DefaultCharSetAttribute implementation
5856 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5857 which allows us to set GlobalNamespace for every resolve.
5858 (Attribute.ResolveArguments): Cut from Resolve.
5859 (Attribute.GetCharSetValue): Returns CharSet named argument.
5860 (Attribute.DefinePInvokeMethod): Gets default charset from
5862 (GlobalAttribute.ResolveAsTypeStep): Override.
5863 (GlobalAttribute.ResolveArguments): Override.
5865 * class.cs (TypeAttr): Is protected.
5867 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5868 (ModuleClass.DefaultCharSetType): New memeber.
5869 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5871 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5872 charset from module.
5874 * delegate.cs (TypeAttr): Override.
5875 (Delegate.DefineType): Use this TypeAttr.
5877 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5878 at very early stage (before types are defined) to resolve model
5879 module attributes. It will probably not work with corlib but it
5882 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5883 charset from module.
5885 * typemanager.cs (default_charset_type): New type.
5887 2005-04-13 Raja R Harinath <rharinath@novell.com>
5889 * decl.cs (MemberCache.AddMethods): Don't warn if
5890 System.Object.Finalize has buggy MethodAttributes.
5892 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5895 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5897 * doc.cs : detect ambiguous reference to overloaded members.
5898 Fixed bug #71603. MS 1.1 csc does not detect it.
5900 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5902 * doc.cs : delegates must not be referenced with parameters.
5905 2005-04-12 Miguel de Icaza <miguel@novell.com>
5907 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5909 2005-04-10 Miguel de Icaza <miguel@novell.com>
5911 * driver.cs (MainDriver): Stop processing if the CLS stage found
5914 (CompilerCallableEntryPoint.InvokeCompiler): Always
5915 reset after execution; Take a TextWriter argument for the
5918 * report.cs: Use the error stream instead of hardcoding stderr.
5920 2005-04-09 Miguel de Icaza <miguel@novell.com>
5922 * class.cs: Reduce code paths to test, too small of an
5923 optimization to make it worth the extra testing. Always perform
5926 2005-04-08 Raja R Harinath <rharinath@novell.com>
5929 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
5930 operators that had errors reported on them.
5932 2005-04-08 Marek Safar <marek.safar@seznam.cz>
5934 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
5936 (Attribute.Resolve): Add named argument type checking.
5938 * class.cs (FixedField.Define): Use IsPrimitiveType
5940 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
5942 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
5943 unsafe parameter types.
5945 * statement.cs (Using.ResolveExpression): Add better error description.
5947 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
5949 2005-04-08 Raja R Harinath <rharinath@novell.com>
5952 * attribute.cs (Attribute.GetAttributeUsage): Resolve
5953 AttributeUsageAttribute in the emitcontext of the attribute class,
5954 not in the emitcontext of the attributable entity it was attached to.
5955 * cs-parser.jay: Use 'current_class', not 'current_container',
5956 when creating a GlobalAttribute.
5958 2005-04-08 Alp Toker <alp@atoker.com>
5960 * pending.cs: The fix to #58413 failed to compile methods implementing
5961 interfaces with/without params modifiers and vice versa, even though
5962 params modifiers aren't part of the signature. Make the modifier check
5963 less strict as in csc.
5965 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
5966 Anoob V E <projectmonokochi@rediffmail.com>
5967 Harilal P R <projectmonokochi@rediffmail.com>
5970 * pending.cs (TypeAndMethods.mods): New. Store the parameter
5971 modifiers of pending methods.
5972 (PendingImplementation.PendingImplementation): Initialize it.
5973 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
5974 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
5975 with ParameterData. Add check for modifiers.
5976 * class.cs (MethodData.Define): Update to changes.
5978 2005-04-07 Raja R Harinath <rharinath@novell.com>
5980 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
5982 2005-04-07 Marek Safar <marek.safar@seznam.cz>
5984 * class.cs (PropertyMethod.Define): Check private accessor in abstract
5987 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
5990 * typemanager.cs: Registered RequiredAttributeAttribute.
5992 2005-04-06 Marek Safar <marek.safar@seznam.cz>
5994 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
5995 Warning CS0169 is back at level 3.
5996 (IMethodData.SetMemberIsUsed): New method.
5998 * decl.cs (IsUsed): New value; moved from FieldBase.Status
5999 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
6001 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
6003 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
6005 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
6008 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
6011 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
6012 to avoid the problems with nested types.
6014 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
6015 Anoob V.E <projectmonokochi@rediffmail.com>
6016 Harilal P.R <projectmonokochi@rediffmail.com>
6017 Raja R Harinath <rharinath@novell.com>
6020 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
6022 * typemanager (GetConstructor): Make public.
6024 2005-04-05 John Luke <john.luke@gmail.com>
6025 Raja R Harinath <rharinath@novell.com>
6028 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
6029 struct too. Return false quicker in a few cases.
6030 (VerifyUnManaged): Use it.
6032 2005-04-05 Raja R Harinath <rharinath@novell.com>
6035 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
6036 not 'unreachable_seen'.
6038 2005-04-04 Marek Safar <marek.safar@seznam.cz>
6040 * attribute.cs (Attribute.GetValue): Removed unused.
6042 * codegen.cs (CodeGen.TrimExt): Removed unused.
6044 * cs-parser.jay (output): Removed unused.
6046 * cs-tokenizer.cs (hex_digits): Removed unused.
6048 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
6050 * expression.cs (Indirection.LoadExprValue): Removed unused.
6051 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
6053 * iterators.cs (Iterator.param_types): Removed unused.
6055 * statement.cs (Goto.block): Removed unused.
6056 (ToplevelBlock.did): Removed unused.
6057 (Switch.ResolveConstantSwitch): Removed unused.
6059 2005-04-01 Ben Maurer <bmaurer@ximian.com>
6061 * rootcontext.cs: Allow mcs to bootstrap with the compilation
6064 2005-04-19 Martin Baulig <martin@ximian.com>
6066 Merged r42462 from MCS and made it work for GMCS.
6068 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
6070 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
6072 2005-04-01 Raja R Harinath <rharinath@novell.com>
6074 Fix #74232 and cs0208-3.cs.
6075 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
6076 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
6077 unmanaged type. Don't use FieldBuilders when 't' is a
6078 TypeBuilder. Use ModFlags and MemberType fields.
6079 * class.cs (MemberBase.member_type): Rename from MemberType.
6080 (MemberBase.MemberType): New property. Determines member_type on
6082 (MemberBase.DoDefine): Don't initialize MemberType here.
6083 (FieldMember.Define): Likewise.
6085 2005-04-01 Marek Safar <marek.safar@seznam.cz>
6088 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
6089 Attributes are emitted there.
6091 2005-04-01 Raja R Harinath <rharinath@novell.com>
6093 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
6094 keyword in 'partial enum' too.
6095 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
6097 Report from Kamil Skalski <nazgul@omega.pl>.
6100 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
6101 have partial containers too.
6103 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
6104 in block' checks to Block.CheckInvariantMeaningInBlock.
6105 * statement.cs (Block.GetKnownVariableInfo): Make private.
6106 (Block.IsVariableUsedInChildBlock): Remove.
6107 (Block.IsVariableUsedInBlock): Likewise.
6108 (Block.CheckInvariantMeaningInBlock): New. Show location of
6109 conflicting declaration.
6110 (Block.AddVariable): Make error messages less long-winded and more
6111 specific. Show location of conflicting declaration.
6112 * parameter.cs (Parameters.Location): New readonly property.
6114 2005-03-31 Raja R Harinath <rharinath@novell.com>
6116 Clean up semantics of invoking ResolveMemberAccess.
6117 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
6118 can have an instance, ensure that we pass in a non-TypeExpression
6119 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
6120 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
6121 argument. Update to changes and simplify.
6122 (FieldExpr.Emitinstance): Remove CS0120 check.
6123 (PropertyExpr.EmitInstance): Likewise.
6124 * expression.cs (Argument.Resolve): Likewise.
6125 (Invocation.DoResolve): Update to changes in semantics of
6128 2005-03-31 Marek Safar <marek.safar@seznam.cz>
6131 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
6134 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
6136 2005-03-31 Raja R Harinath <rharinath@novell.com>
6138 Fix difference in behaviour with commandline invocation.
6139 * driver.cs (Driver.Reset): New.
6140 (CompilerCallableEntryPoint): Call it.
6142 * statement.cs (If.Resolve): Avoid spurious "uninitialized
6143 variable" warnings if the boolean expression failed to resolve.
6145 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
6147 * attribute.cs: Fix the union of several permissions when some of them
6148 are unrestricted (so the result isn't an unrestricted permission set).
6151 2005-03-30 Raja R Harinath <rharinath@novell.com>
6153 * ecore.cs (MemberExpr): New class. Convert from interface
6155 (MemberExpr.ResolveMemberAccess): Refactor and move here from
6156 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
6158 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
6159 (MethodGroupExpr.IsExplicitImpl): Remove.
6160 (Expression.GetFieldFromEvent): Remove.
6161 (SimpleName.MemberStaticCheck): Remove.
6162 (SimpleName.DoSimpleNameResolve): Update to changes.
6163 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
6164 (MemberAccess.IdenticalNameAndTypeName): Remove.
6165 (MemberAccess.error176): Move to MemberExpr.
6166 (MemberAccess.DoResolve): Update to changes.
6167 (BaseAccess.DoResolve): Likewise.
6169 2005-03-30 Marek Safar <marek.safar@seznam.cz>
6171 C# 2.0 Conditional attribute class implementation
6173 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
6174 Analyzes class whether it has attribute which has ConditionalAttribute
6175 and its condition is not defined.
6177 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
6178 (Class.IsExcluded): New method. Search for at least one defined
6179 condition in ConditionalAttribute of attribute class.
6181 2005-03-30 Raja R Harinath <rharinath@novell.com>
6183 * ecore.cs (PropertyExpr): Derive from Expression, not
6184 ExpressionStatement.
6185 (PropertyExpr.EmitStatement): Remove.
6187 2005-03-29 Raja R Harinath <rharinath@novell.com>
6190 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
6191 internal field "value__" of an enum be private. The examples for
6192 "value__" that I found on MSDN all used FieldAttributes.Private.
6194 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
6195 Don't mention IL method attribute names.
6197 Fix #47991. Remove a TODO.
6198 * statement.cs (Block.Toplevel): Make into a field.
6199 (Block.Parameters): Move into ToplevelBlock.
6200 (Block.known_variables): Rename from child_variable_names.
6201 (Block.Block): Remove variants that take Parameters. Initialize
6202 'Toplevel' with the immediately surrounding toplevel block.
6203 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
6204 LocalInfo parameter.
6205 (Block.GetKnownVariableInfo): New.
6206 (Block.IsVariableNameUsedInChildBlock): Update.
6207 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
6208 the block, even though it may not be in scope.
6209 (Block.AddVariable): Remove Parameters parameter. Use
6210 Toplevel.Parameters instead.
6211 (Block.AddConstant): Remove Parameters parameter.
6212 (Block.GetParameterReference): Update to use Toplevel.Parameters.
6213 (Block.IsParamaterReference): Likewise.
6214 (Block.IsLocalParameter): Likewise. Simplify a lot.
6215 (ToplevelBlock.Parameters): New. Moved from Block.
6216 (ToplevelBlock.ToplevelBlock): Update to changes. Always
6217 initialize Parameters to a non-null value.
6218 * cs-parser.jay: Update to changes.
6219 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
6220 simple names that mean different things in the same block. Use
6221 Block.IsVariableNameUsedInBlock.
6223 2005-03-28 Raja R Harinath <rharinath@novell.com>
6225 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
6227 2005-03-26 Raja R Harinath <harinath@acm.org>
6230 * assign.cs (Assign.DoResolve): When the RHS of an assignment
6231 fails to resolve, ensure that the LHS is still resolved as an
6234 2005-03-25 Raja R Harinath <harinath@acm.org>
6236 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
6238 (Enum.current_ec): Remove.
6239 (Enum.LookupEnumValue): Remove EmitContext argument.
6240 Just uses the one created during DefineType.
6241 (Enum.FindMembers): Update.
6242 * expression.cs (MemberAccess.DoResolve): Update.
6244 2005-03-22 Marek Safar <marek.safar@seznam.cz>
6246 * assign.cs (Assign.DoResolve): Check for CS1717 when
6247 source and target are same (uses Equals).
6249 * expression.cs (LocalVariableReference, ParameterReference,
6250 This): Implemented Equals, GetHashCode.
6252 * statement.cs (Block.GetParameterReference): Removed useless
6255 2005-03-22 Raja R Harinath <rharinath@novell.com>
6258 * statement.cs (Block.AddVariable): Ensure that we skip implicit
6259 blocks before deciding whether the error is cs0136 or cs0128.
6261 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
6262 (using_alias_directive, using_namespace_directive): Pass
6263 MemberName, not an expression to Namespace.UsingAlias and
6265 (MakeName): Use the MemberName of the namespace.
6266 * namespace.cs (Namespace.MemberName): New.
6267 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
6268 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
6270 * decl.cs (MemberName.Name): Make readonly.
6271 (MemberName.FromDotted): New "constructor".
6272 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
6273 (MemberCore.Name): Compute from MemberName on demand.
6274 (MemberCore.SetMemberName): Provide a way to change the
6276 (MemberCore.AddToContainer): Don't take a fullname parameter.
6277 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
6278 fully qualified name of the container to the member name.
6279 (TypeContainer.AddToTypeContainer): Use a fully qualified name
6280 only if the type is a member of the root container.
6281 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
6282 MemberName.Left rather than searching for an embedded ".".
6283 (PartialContainer.CreatePart): Update to changes in RootContext.
6284 (MemberBase.ShortName): Turn into a property. Use
6285 MemberCore.SetMemberName.
6286 (MemberBase.ExplicitInterfaceName): Remove.
6287 (MemberBase.UpdateMemberName): Remove.
6288 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
6289 (PropertyBase.SetMemberName): New override.
6290 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
6291 (Tree.GetDecl): New.
6292 (Tree.AllDecls): Rename from Decls.
6293 * attribute.cs, enum.cs, report.cs: Update to changes.
6294 * driver.cs (MainDriver): Use MemberName.FromDotted on
6295 RootContext.MainClass.
6297 2005-03-21 Marek Safar <marek.safar@seznam.cz>
6299 * class.cs (FixedField.Define): Check for CS1664 and more sanity
6302 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
6304 2005-03-18 Marek Safar <marek.safar@seznam.cz>
6306 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
6307 property accessor modifiers.
6309 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
6310 fixed buffer attribute (CS1716).
6311 (PropertyMethod.HasCustomAccessModifier): When property accessor
6312 has custom modifier.
6314 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
6316 (PropertyExpr.DoResolveLValue): Add CS0272.
6318 2005-03-17 Miguel de Icaza <miguel@novell.com>
6320 * convert.cs: When converting to a pointer, use the proper Conv.U
6321 or Conv.I depending on the source data type.
6323 * cs-tokenizer.cs: Make the size for large decimal constants,
6326 2005-03-17 Martin Baulig <martin@ximian.com>
6328 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6329 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6331 2005-03-17 Martin Baulig <martin@ximian.com>
6333 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6334 to bool so we can return an error condition.
6335 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6338 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
6340 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
6343 2005-03-16 Raja R Harinath <rharinath@novell.com>
6345 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
6346 Refactor to avoid traversing the list of assemblies, and to avoid
6347 string concatenation.
6348 * typemanager.cs (guid_attr_type): Remove.
6349 (negative_hits, pointers, references): Remove hashes.
6351 (GetConstructedType): New. Uses type_hash to handle constructed
6352 types (arrays, references, pointers).
6353 (GetReferenceType, GetPointerType): Use it.
6354 (GetNestedType): New. Uses type_hash to handle nested types of
6356 (LookupType, LookupTypeDirect): Remove.
6357 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
6358 'types' hash and LookupTypeReflection directly.
6359 (params_string, params_object): Use GetConstructedType.
6360 * namespace.cs (Namespace.cached_types): New. Cache of reflected
6362 (Namespace.Lookup): Use cached_types.
6363 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
6364 provided by old TypeManager.LookupType.
6365 * rootcontext.cs (MakeFQN): Remove.
6366 * decl.cs (DeclSpace.MakeFQN): Likewise.
6367 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
6368 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
6369 TypeManager.GetConstructedType.
6370 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
6372 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
6374 * cs-parser.jay: Fix build.
6376 2005-03-15 Marek Safar <marek.safar@seznam.cz>
6378 * class.cs (TypeContainer.CircularDepException) New nested
6379 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
6381 * cs-parser.jay: Reports CS1527 for any namespace element.
6383 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
6386 * expression.cs (ParameterReference.IsAssigned): Changed error to
6388 (Error_WrongNumArguments): Moved CS0245 detection here.
6390 * statement.cs (Return.Resolve): Add CS1622 report.
6392 2005-03-11 Marek Safar <marek.safar@seznam.cz>
6394 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
6396 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
6398 * attribute.cs expression.cs: Get rid of some allocations.
6400 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
6402 * doc.cs : just eliminate the latest change.
6404 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6406 * doc.cs : commented out the latest change. It breaks xml-030.cs
6408 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6410 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
6411 fail. So invoke CreateType() in FindDocumentedType().
6413 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6415 * cs-tokenizer.cs : added IsKeyword().
6416 * doc.cs : Detect keyword incorrectly used as identifier.
6417 Allow identifiers prefixed by @.
6419 2005-03-10 Marek Safar <marek.safar@seznam.cz>
6421 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
6422 It caused exception in namespace resolving (again!).
6424 * class.cs (Class.ctor): Removed exit.
6425 (PropertyMethod.ctor): ditto.
6427 * codegen.cs (Codegen.Reset): Reset static data.
6428 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
6430 * cs-tokenizer.cs (Cleanup): Removed.
6432 * driver.cs (GetSystemDir): Rewrote to one line command.
6433 It caused problem with unloaded dynamic modules.
6434 (UnixParseOption): Removed Exit.
6435 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
6436 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
6437 Now can be mcs used as library.
6439 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
6442 * location.cs (Reset): Reset static data.
6444 * namespace.cs (Reset): Reset static data.
6446 * report.cs (Report.Reset): Reset static data.
6448 * rootcontext.cs (RootContext.Reset): Reset static data.
6450 * tree.cs (RootTypes.ctor): Use Location.Null
6452 * typemanager.cs (TypeManager.Reset): Reset static data.
6453 (CoreLookupType): Removed Exit.
6454 (TypeHandle.Reset): Reset static data.
6456 2005-03-10 Raja R Harinath <rharinath@novell.com>
6459 * typemanager.cs (ComputeNamespaces): Import namespaces from
6460 referenced modules too.
6462 2005-03-09 Raja R Harinath <rharinath@novell.com>
6464 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
6467 2005-03-09 Raja R Harinath <rharinath@novell.com>
6469 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
6470 enclosing DeclSpace. This ensures that a name-lookup populates
6471 more caches and there are fewer 'TypeExpression's. Carve out
6472 nested type lookup into ...
6473 (LookupNestedTypeInHierarchy): ... this.
6475 2005-04-15 Martin Baulig <martin@ximian.com>
6477 Merged r41590 from MCS and make it work in the generics land.
6479 * generic.cs (TypeParameter.UpdateConstraints): Removed the
6482 * class.cs (PartialContainer.UpdateConstraints): Removed.
6483 (PartialContainer.CheckConstraints): Removed.
6484 (PartialContainer.SetParameterInfo): Store the constraints here.
6485 (PartialContainer.DefineTypeParameters): New public method;
6486 resolve the type parameter's constraints here. Note that the
6487 PartialContainer doesn't have an EmitContext anymore, so we must
6488 do this in the ClassPart.
6490 2005-03-09 Raja R Harinath <rharinath@novell.com>
6492 Clean up a few partial-class semantics.
6493 Fixes test-357.cs and cs1618-2.cs.
6494 * cs-parser.jay (struct_declaration): Use 'current_class' as
6495 parent of newly-created struct. Remove call to Register ().
6496 Use 'pop_current_class' to complete handing the current struct.
6497 (interface_declaration): Likewise.
6498 (class_declaration): Likewise.
6499 (enum_declaration): Use 'current_class' as parent of newly created
6501 (delegate_declaration): Likewise.
6502 (pop_current_class): New function. This is used to handle closing
6503 up the 'current_class' and 'current_container', and pointing them
6504 to the enclosing class/container.
6505 (CSharpParser): Initialize 'current_class' too.
6506 * decl.cs (MemberCore): Add check for invariant: a partial
6507 container is not a parsed entity, and thus does not enclose any
6509 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
6510 (DeclSpace.BaseTypeExpr): Use it.
6511 (DeclSpace.LookupType): Add check for invariant.
6512 * class.cs (TypeContainer): Add check for invariant: a nested
6513 class should have the same NamespaceEntry as its enclosing class.
6514 (TypeContainer.EmitFieldInitializers): Make virtual.
6515 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
6517 (TypeContainer.Register): Remove.
6518 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
6519 null. Use TypeResolveEmitContext for resolving base types and
6520 interfaces. Move initialization of Parts.TypeBuilder here from
6522 (TypeContainer.DefineNestedTypes): ... here.
6523 (PartialContainer): Take a Namespace not a NamespaceEntry.
6524 (PartialContainer.Create): Don't use Register. Call the
6525 appropriate Add... function directly.
6526 (ClassPart): Take both the PartialContainer and the enclosing
6527 class as constructor arguments.
6528 (ClassPart.EmitFieldInitializers): Override.
6529 (ClassPart.PartFindNestedTypes): Remove.
6530 (FieldBase.GetInitializerExpression): Resolve the initializer
6531 expression in the emit context of the enclosing class.
6532 * tree.cs (RootTypes): Remove Register ().
6534 2005-03-08 Marek Safar <marek.safar@seznam.cz>
6536 * cs-parser.jay: Removed CS0134.
6538 * driver.cs: Removed CS1901.
6540 * expression.cs (SizeOf.DoResolve): Don't report CS0233
6541 for predefined types.
6543 2005-03-07 Duncan Mak <duncan@novell.com>
6545 * codegen.cs (Save): Catch UnauthorizedAccessException as
6546 well. Fixes bug #73454.
6548 2005-03-07 Marek Safar <marek.safar@seznam.cz>
6550 * cs-tokenizer.cs (xtoken): Add CS1035.
6552 * class.cs (MethodData.Define): Add CS0683.
6553 (FieldMember.ctor): Add CS0681.
6555 2005-03-07 Raja R Harinath <rharinath@novell.com>
6557 * ecore.cs (SimpleName.DoResolve): Rename from
6558 SimpleName.DoResolveAllowStatic.
6559 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
6560 Pass 'intermediate' flag to MemberStaticCheck.
6561 (SimpleName.MemberStaticCheck): Skip "static check" only in case
6562 of "intermediate" lookups via MemberAccess.
6563 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
6564 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6566 2005-03-07 Raja R Harinath <rharinath@novell.com>
6569 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6570 slipped in because of variable names that are identical to a
6571 builtin type's BCL equivalent ('string String;', 'int Int32;').
6572 (PropertyExpr.EmitInstance): Likewise.
6574 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6576 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6578 * report.cs (warning_ignore_table): Made public.
6580 2005-03-04 Raja R Harinath <rharinath@novell.com>
6583 * class.cs (MethodData.Emit): Pass 'container' to
6584 container.GetObsoleteAttribute instead of 'container.Parent'.
6586 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6588 * cs-parser.jay: Add 1534 error test.
6590 * iterators.cs (Yield.CheckContext): Add error 1629.
6591 (Iterator.ctor): Save unsafe modifier.
6592 (MoveNextMethod.DoEmit): Restore unsafe context.
6594 * namespace.cs (UsingAlias): Better error message.
6596 2005-03-03 Dan Winship <danw@novell.com>
6598 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6599 the warning message [#73219]
6601 2005-03-03 Raja R Harinath <rharinath@novell.com>
6603 Fix compile with MCS 1.0.0.0.
6604 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6605 w_restore to not depend on string constant folding.
6607 2005-03-03 Raja R Harinath <rharinath@novell.com>
6609 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6610 CS0246 check to users who passed 'silent = false'.
6611 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6613 (SimpleName.SimpleNameResolve): Update.
6614 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6615 (MemberAccess.IdenticalNameAndTypeName): Update.
6616 * doc.cs (FindDocumentedTypeNonArray): Update.
6618 2005-03-03 Raja R Harinath <rharinath@novell.com>
6620 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6621 * parameters.cs (ComputeAndDefineParameters): Remove.
6622 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6623 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6624 Use GetParameterInfo.
6626 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6628 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6630 2005-03-02 Raja R Harinath <rharinath@novell.com>
6632 Unify DeclSpace.LookupType and DeclSpace.FindType.
6633 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6634 is in charge of defining nested types on demand.
6635 (DeclSpace.LookupType): Use it when the current_type is a
6636 TypeBuilder. Use LookupTypeDirect for reflected types.
6637 (DeclSpace.FindType): Remove.
6638 (DeclSpace.LookupInterfaceOrClass): Likewise.
6639 (DeclSpace.DefineTypeAndParents): Likewise.
6640 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6641 DeclSpace.LookupType.
6642 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6643 * typemanager.cs (LookupType): Simplify.
6644 (AddUserType): Remove type from negative_hits.
6645 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6646 * class.cs (TypeContainer.FindMembers): Move handling of nested
6648 (TypeContainer.FindMembers_NestedTypes): ... here.
6649 (TypeContainer.FindNestedType): Implement override.
6650 (ClassPart.FindNestedType): Delegate to PartialContainer.
6651 (ClassPart.PartFindNestedType): Looks up the nested types of the
6654 2005-04-14 Martin Baulig <martin@ximian.com>
6656 * generic.cs (ConstructedType): Moved all the type lookup and
6657 nested class logic into SimpleName.
6658 (ConstructedType.ResolveConstructedType): Our underlying type is
6659 already fully resolved; all the type lookup stuff is in
6662 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6663 constructed types here instead of in ConstructedType.
6665 * decl.cs (MemberName.GetTypeExpression): Always create a
6666 SimpleName, not a ConstructedType.
6667 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6669 2005-03-02 Martin Baulig <martin@ximian.com>
6671 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6672 static constructor in static classes.
6674 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6676 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6677 sizeParamIndex is not specified.
6679 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6682 * report.cs (WarningMessage.IsEnabled): Missing null check.
6684 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6686 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6687 in the fields and not in the properties.
6689 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6691 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6694 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6696 * attribute.cs: Small refactoring (improved robustness).
6697 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6698 (ValidateGuid): Removed.
6699 (Resolve): Removed referenced to above mentioned.
6700 (GetAttributeUsage): Made private and changed to work without
6702 (GetIndexerAttributeValue): Don't crash.
6703 (GetConditionalAttributeValue): Ditto.
6704 (GetClsCompliantAttributeValue): Ditto.
6705 (ExtractSecurityPermissionSet): All attributes exceptions are
6707 (GetPropertyValue): New helper.
6708 (GetMethodImplOptions): New method.
6709 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6710 some missing properties.
6712 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6713 (Method.ApplyAttributeBuilder): Updated.
6715 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6718 2005-02-28 Raja R Harinath <rharinath@novell.com>
6721 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6722 non-simple types (array, pointer, reference).
6724 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6726 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6728 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6730 (Method.CheckBase): Catch wrong destructor here.
6731 (MethodData.Define): Add errors 550, 668.
6733 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6735 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6737 * pending.cs (VerifyPendingMethods): Add error 551.
6739 * typemanager.cs (CSharpName): Next error report helper.
6741 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6743 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6744 attributes. Removed useless attribute double check.
6745 It saves almost 2MBs for corlib.
6747 2005-02-25 Raja R Harinath <rharinath@novell.com>
6750 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6751 called twice in case of error.
6753 2005-02-23 Chris Toshok <toshok@ximian.com>
6755 Fix compiler portions of #72827.
6756 * statement.cs (Block.Emit): call Begin/EndScope on the
6757 EmitContext instead of the ILGenerator.
6759 * codegen.cs (EmitContext.BeginScope): new method, call
6760 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6762 (EmitContext.BeginScope): same, but EndScope and CloseScope
6764 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6765 offset and call the superclass's OpenScope(int) with it.
6766 (SymbolWriter.CloseScope): get the current il
6767 offset and call superclass's CloseScope(int) with it.
6769 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6771 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6772 CS1677 for out and ref as well.
6774 * class.cs (Method.Define): Add error CS1599 detection.
6776 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6778 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6780 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6782 * support.cs.cs (ModifierDesc): New helper method.
6784 2005-02-23 Raja R Harinath <rharinath@novell.com>
6785 Abin Thomas <projectmonokochi@rediffmail.com>
6786 Anoob V E <projectmonokochi@rediffmail.com>
6787 Harilal P R <projectmonokochi@rediffmail.com>
6790 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6791 MemberLookup (used for error reporting) actually returns a result.
6792 Fix error report number (122, not 112).
6794 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6795 Anoob V E <projectmonokochi@rediffmail.com>
6796 Harilal P R <projectmonokochi@rediffmail.com>
6799 * pending.cs (PendingImplementation.GetAbstractMethods):
6800 Find NonPublic members too.
6802 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6804 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6807 * class.cs (MethodCore.CheckMethodAgainstBase):
6808 Add error 239 report.
6810 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6812 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6814 * class.cs (Operator.Define): Add error 217 report.
6816 2005-02-21 Raja R Harinath <rharinath@novell.com>
6819 * expression.cs (Invocation.IsApplicable): Make public.
6820 (Invocation.IsParamsMethodApplicable): Likewise.
6821 * delegate.cs (Delegate.VerifyApplicability): Don't use
6822 Invocation.VerifyArgumentCompat for parameter applicability
6823 testing. Use Invocation.IsApplicable and
6824 Invocation.IsParamsMethodApplicable.
6826 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6828 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6830 * class.cs (Operator.Define): Add error 217 report.
6832 2005-02-21 Raja R Harinath <rharinath@novell.com>
6834 * namespace.cs (UsingEntry.Resolve): Undo change below.
6836 2005-02-21 Raja R Harinath <rharinath@novell.com>
6839 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6840 disable the error message when the extended MemberLookup also
6842 (Expression.MemberLookupFinal): Update.
6843 (SimpleName.DoSimpleNameResolve): Update.
6844 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6845 Don't use MemberLookupFinal.
6846 (New.DoResolve): Update.
6847 (BaseAccess.CommonResolve): Update.
6849 2005-02-21 Raja R Harinath <rharinath@novell.com>
6852 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6853 occured previously, don't resolve again.
6855 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6858 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6859 argument. Call ResolveAttributeUsage for unresolved.
6860 when types doesn't match ctor arguments.
6862 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6863 for nested attribute classes.
6864 (Class.attribute_usage): Removed.
6865 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6866 for attribute class.
6868 * ecore.cs (IsAttribute): Removed.
6870 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6872 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6874 (attribute_types): Removed.
6875 (EmitCode): Global attributes are emited as the latest.
6877 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6879 * class.cs (EmitFieldInitializers): Don't emit field initializer
6880 for default values when optimilization is on.
6882 * constant.cs (Constant.IsDefaultValue): New property.
6884 * driver.cs: Add /optimize handling.
6888 * literal.cs: Implement new IsDefaultValue property.
6890 * rootcontext.cs (Optimize): New field, holds /optimize option.
6892 2005-02-18 Raja R Harinath <rharinath@novell.com>
6894 Fix crasher in re-opened #72347.
6895 * namespace.cs (Namespace.Lookup): Return null if
6896 DeclSpace.DefineType returns null.
6899 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6901 2005-02-18 Raja R Harinath <rharinath@novell.com>
6903 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6904 now returns null if it cannot resolve to an lvalue.
6905 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6906 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6907 returned null. Remove check for SimpleName.
6908 (EventExpr.DoResolveLValue): New.
6909 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6910 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6912 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6914 (Unary.ResolveOperator): Move CS0211 check ...
6915 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6917 (Unary.DoResolveLValue): Simplify.
6918 (AddressOf.DoResolveLValue): New.
6919 (ArrayAccess.DoResolveLValue): New.
6921 2005-02-16 Marek Safar <marek.safar@seznam.cz>
6923 * attribute.cs (Attribute.Resolve): Add arguments casting for
6924 when types doesn't match ctor arguments.
6926 2005-02-16 Raja R Harinath <rharinath@novell.com>
6928 Fix parts of #63202.
6929 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
6930 lookup of operator in base type. Ensure that all checks happen
6931 when the operator resolves to an "op_..." method.
6933 2005-02-15 Raja R Harinath <rharinath@novell.com>
6936 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
6937 'ignore_cs0104' parameter. Pass it to ...
6938 (NamespaceEntry.Lookup): ... this.
6939 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
6940 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
6941 (TypeLookupExpression.DoResolveAsTypeStep): Update.
6942 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
6943 Update. Request that cs0104 errors be ignored.
6944 (ComposedCast.ResolveAsTypeStep): Update.
6946 2005-02-14 Raja R Harinath <rharinath@novell.com>
6949 * expression.cs (Invocation.BetterFunction): Remove support for
6950 comparing virtual functions and their overrides.
6951 (Invocation.IsOverride): New.
6952 (Invocation.OverloadResolve): Don't consider 'override' functions
6953 during candidate selection. Store them in a lookaside list.
6954 If the selected method is a 'virtual' function, use the list to
6955 find any overrides that are closer to the LHS type.
6957 2005-02-14 Marek Safar <marek.safar@seznam.cz>
6959 * expression.cs (New.DoResolve): Add complex core type reduction.
6960 (New.Constantify): Converts complex core type syntax like 'new int ()'
6963 2005-02-14 Raja R Harinath <rharinath@novell.com>
6965 * decl.cs (EntryType.EntryType): New constructor to create an
6966 updated copy of a cache entry.
6967 (MemberCache.AddMethods): Use it.
6968 (MemberCache.ClearDeclaredOnly): Remove.
6969 (MemberCache.MemberCache): Update.
6971 2005-02-11 Miguel de Icaza <miguel@novell.com>
6973 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
6974 variable. This one is represents the actual low-level declaration
6975 of the method, as opposed to the semantic level `IsStatic'.
6977 An anonymous method which is hosted into a static method might be
6978 actually an instance method. IsStatic would reflect the
6979 container, while MethodIsStatic represents the actual code
6982 * expression.cs (ParameterReference): Use the new MethodIsStatic
6983 instead of IsStatic.
6985 * anonymous.cs (AnonymousMethod.Compatible): Pass the
6986 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
6987 set on the current EmitContext.
6989 * expression.cs (Cast): Overload DoResolveLValue so we can pass
6990 resolve our casted expression as an LValue. This triggers the
6991 proper LValue processing that is later required by Assign.
6995 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
6997 2005-02-11 Marek Safar <marek.safar@seznam.cz>
6999 C# 2.0 Fixed buffer implementation
7001 * anonymous.cs: Update after RegisterHelperClass renaming.
7003 * attribute.cs (AttributeTester.fixed_buffer_cache):
7004 Cache of external fixed buffers.
7005 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
7006 implementation if field is fixed buffer else null.
7009 (TypeContainer.AddField): Accept FieldMember instead of Field.
7010 (FieldBase.IsFieldClsCompliant): Extracted code from
7011 VerifyClsCompliance descendant customization.
7012 (FixedField): New class handles fixed buffer fields.
7013 (FixedFieldExternal): Keeps information about imported fixed
7015 (IFixedField): Make access to internal or external fixed buffer
7018 * cs-parser.jay: Add fixed buffer parsing.
7020 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
7023 * expression.cs (Indirection): Extended implementation to accept
7025 (PointerArithmetic.Emit): Get element from fixed buffer as well.
7026 (ElementAccess.MakePointerAccess): Get type as parameter.
7027 (DoResolve): Add fixed buffer field expression conversion.
7028 (DoResolveLValue): Ditto.
7029 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
7030 (ArrayPtr): Derives from FixedBufferPtr.
7031 (ArrayPtr.Emit): Add extra emit for array elements.
7033 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
7035 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
7036 for compiler generated types.
7037 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
7039 * statement.cs (Fixed): Refactored to be easier add fixed buffer
7040 and consume less memory.
7041 (Fixed.Resolve): Add fixed buffer case.
7043 * typemanager.cs (compiler_generated_attr_ctor,
7044 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
7045 (HasElementType): Add our own implementation to work on every
7048 2005-02-11 Miguel de Icaza <miguel@novell.com>
7050 * anonymous.cs (CaptureContext): Track whether `this' has been
7053 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
7054 only captured `this' if it was implicitly done (instance
7055 methods/variables were used).
7057 * codegen.cs (EmitContext.CaptureThis): New method to flag that
7058 `this' must be captured.
7060 2005-01-30 Miguel de Icaza <miguel@novell.com>
7062 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
7063 is null it means that there has been no need to capture anything,
7064 so we just create a sibling.
7066 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
7068 Just a partial fix. The other half is fairly elusive.
7070 2005-02-10 Raja R Harinath <rharinath@novell.com>
7072 Fix #52586, cs0121-4.cs.
7073 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
7074 and return a hashtable.
7075 (MemberCache.ClearDeclaredOnly): New.
7076 (MemberCache.MemberCache): Update to change. Make a deep copy of
7077 the method_hash of a base type too.
7078 (MemberCache.AddMethods): Adapt to having a deep copy of the base
7079 type methods. Overwrite entries with the same MethodHandle so
7080 that the ReflectedType is correct. The process leaves in base
7081 virtual functions and their overrides as distinct entries.
7082 (CacheEntry): Now a class instead of a struct. It shouldn't alter
7083 matters since it was boxed in a ArrayList before.
7084 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
7086 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
7087 case of a virtual function and its override (choose the overload
7089 (Invocation.OverloadResolve): Avoid 'override' members during
7090 'applicable_type' calculation.
7092 2005-03-28 Raja R Harinath <rharinath@novell.com>
7094 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
7095 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
7096 GetTypeHandle. It is possible for a reflected type to derive from
7097 a TypeBuilder (e.g., int[] derives from the TypeBuilder
7098 System.Array during mscorlib compilation).
7099 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
7100 contain a method_hash, don't create one either. Don't create a
7101 deep copy of the base cache's method_hash.
7102 (MemberCache.SetupCache): Rename back from DeepCopy.
7103 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
7104 already initialized. If we see an override function, add its
7105 underlying base virtual function to the member_hash too.
7107 2005-02-09 Raja R Harinath <rharinath@novell.com>
7109 Combine two near-redundant caches.
7110 * typemanager.cs (method_params): Rename from method_internal_params.
7111 (TypeManager.GetParameterData): New. Replace
7112 Invocation.GetParameterData.
7113 (TypeManager.LookupParametersByBuilder): Remove.
7114 * expression.cs (Invocation.method_parameter_cache): Remove.
7115 (Invocation.GetParameterData): Remove.
7117 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
7120 2005-02-08 Raja R Harinath <rharinath@novell.com>
7123 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
7124 TypeManager.multicast_delegate_type is null, resolve it by looking
7125 up "System.MulticastDelegate".
7126 * rootcontext.cs (RootContext.ResolveCore): Simplify.
7128 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
7129 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
7130 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
7133 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
7134 (LabeledStatement.AddReference): New. Set 'referenced'.
7135 (Goto.Resolve): Use it.
7137 2005-02-05 John Luke <john.luke@gmail.com>
7139 * driver.cs: remove duplicate -doc line in Usage ()
7141 2005-02-04 Raja R Harinath <rharinath@novell.com>
7143 * location.cs (Location.AddFile): Fix CS2002 error report.
7145 2005-02-02 Martin Baulig <martin@ximian.com>
7147 * delegate.cs (Delegate.DefineType): Report an internal error if
7148 TypeManager.multicast_delegate_type is null. See bug #72015 for
7151 2005-02-02 Raja R Harinath <rharinath@novell.com>
7153 Fix a crasher in a variant of #31984.
7154 * const.cs (Constant.CheckBase): New override that defers the
7155 new-or-override check in case the base type hasn't been populated
7157 (Constant.Define): Ensure the new-or-override check is performed.
7159 2005-02-01 Duncan Mak <duncan@ximian.com>
7161 * const.cs (LookupConstantValue): Check that `ce' is not null
7162 before calling GetValue ().
7164 2005-02-01 Raja R Harinath <rharinath@novell.com>
7166 Fix test-334.cs (#69519).
7167 * cs-parser.jay (using_alias_directive): Pass in an expression to
7168 NamespaceEntry.UsingAlias.
7169 (using_namespace_directive): Pass in an expression to
7170 NamespaceEntry.Using.
7171 (namespace_name): Don't flatten to a string.
7172 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
7173 (NamespaceEntry.AliasEntry.Resolve): Lookup using
7175 (NamespaceEntry.UsingEntry): Likewise.
7176 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
7178 (NamespaceEntry.LookupForUsing): Remove.
7179 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
7181 (NamespaceEntry.Lookup): Remove support for dotted names.
7183 2005-02-01 Raja R Harinath <rharinath@novell.com>
7185 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
7187 (NamespaceEntry.ImplicitParent): Compute on demand.
7188 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
7189 parallels the current.
7190 (NamespaceEntry.LookupForUsing): Use it.
7191 (NamespaceEntry.Lookup): If the current namespace-entry is
7192 implicit, don't search aliases and using tables.
7194 2005-02-01 Raja R Harinath <rharinath@novell.com>
7197 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
7199 (TypeContainer.BaseCache): Compute on demand.
7200 (TypeContainer.FindMembers): Define constants and types if they're
7201 not already created.
7202 (FieldMember.Define): Move resetting of ec.InUnsafe before error
7204 * const.cs (Constant.Define): Make idempotent.
7206 2005-01-29 Miguel de Icaza <miguel@novell.com>
7208 * pending.cs: Produce better code (no nops produced by using Ldarg
7211 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7212 i - 1' it should be arg + 1.
7216 2005-01-28 Raja R Harinath <rharinath@novell.com>
7218 * attribute.cs (Attribute.CheckAttributeType): Make private
7220 (Attribute.ResolveType): Make virtual.
7221 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
7222 handling of RootContext.Tree.Types.
7224 2005-01-27 Raja R Harinath <rharinath@novell.com>
7226 Update attribute-handling to use the SimpleName/MemberAccess
7228 * cs-parser.jay (attribute): Pass in an expression to the
7229 constructors of Attribute and GlobalAttribute.
7230 * attribute.cs (Attribute): Take an expression for the name.
7231 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
7232 passed in attribute name expression.
7233 (Attribute.CheckAttributeType): Use it.
7234 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
7235 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
7236 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
7237 argument to prevent error messages if the lookup fails.
7239 2005-01-27 Marek Safar <marek.safar@seznam.cz>
7241 * expression.cs (Indirection): Implemented IVariable interface
7242 to support indirection in AddressOf operator.
7243 (PointerArithmetic.Emit): Add optimalization for case where
7244 result can be precomputed.
7246 2005-01-26 Martin Baulig <martin@ximian.com>
7248 * class.cs (TypeContainer.AttributeTargets): Return the correct
7249 AttributeTargets depending on our `Kind' instead of throwing an
7250 exception; fixes #71632.
7252 2005-01-26 Marek Safar <marek.safar@seznam.cz>
7255 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
7258 2005-03-17 Martin Baulig <martin@ximian.com>
7260 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
7261 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
7263 2005-03-17 Martin Baulig <martin@ximian.com>
7265 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
7266 to bool so we can return an error condition.
7267 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
7270 2005-03-17 Martin Baulig <martin@ximian.com>
7272 * generic.cs (TypeMananager.IsIEnumerable): New public method.
7274 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
7275 converting from an array-type of T to `IEnumerable<T>'.
7277 2005-03-16 Martin Baulig <martin@ximian.com>
7279 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
7280 (Nullable.LiftedUnaryMutator): New public class.
7282 * expression.cs (UnaryMutator.DoResolve): Added support for
7285 2005-03-14 Martin Baulig <martin@ximian.com>
7287 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
7289 2005-03-14 Martin Baulig <martin@ximian.com>
7291 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
7292 the comparision operators `<', `>', `<=' and `>='.
7294 2005-03-13 Martin Baulig <martin@ximian.com>
7297 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
7298 avoid confusion with the `NullLiteral'.
7299 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
7301 2005-03-13 Martin Baulig <martin@ximian.com>
7303 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
7304 comparing arbitrary types with the null literal.
7306 2005-03-13 Martin Baulig <martin@ximian.com>
7308 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
7309 boolean operators '&&', '||', '&' and '|'.
7310 (Nullable.OperatorTrueOrFalse): New public class.
7312 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
7313 instead of a `StaticCallExpr'; added support for nullables.
7315 2005-03-10 Martin Baulig <martin@ximian.com>
7318 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
7319 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
7321 2005-03-07 Martin Baulig <martin@ximian.com>
7323 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
7324 it work if `expr' is not an IMemoryLocation.
7325 (Nullable.Lifted): Implement IMemoryLocation.
7326 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
7329 2005-03-05 Martin Baulig <martin@ximian.com>
7331 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
7332 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
7333 (Nullable): Added support for lifted unary and binary operators.
7335 * expression.cs (Unary.DoResolve): Added support for nullable types.
7336 (Binary.DoResolve): Likewise.
7337 (Conditional.DoResolve): Likewise.
7339 2005-03-02 Martin Baulig <martin@ximian.com>
7341 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
7343 * class.cs (ClassPart.SetParameterInfo): Override this.
7344 (PartialContainer.SetParameterInfo): Override this.
7345 (TypeContainer.CheckConstraints): New protected method.
7346 (PartialContainer.CheckConstraints): Override this and check
7347 whether the same contraints were specified in all parts of a
7348 partial generic type definition.
7349 (PartialContainer.UpdateConstraints): New public method.
7351 * generic.cs (TypeParameter.UpdateConstraints): New public method.
7353 2005-03-02 Martin Baulig <martin@ximian.com>
7355 Committing a patch from Carlos Alberto Cortez to fix #72887.
7357 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
7358 casts from `T []' to `int []'.
7360 2005-03-02 Martin Baulig <martin@ximian.com>
7362 * generic.cs (TypeManager.IsEqual): Make this symmetric.
7364 * expression.cs (Binary.ResolveOperator): When resolving a
7365 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
7366 `=='. Fixes #71866. See gen-127.cs.
7368 2005-03-02 Martin Baulig <martin@ximian.com>
7370 * class.cs (TypeContainer.DoDefineMembers): We also need a default
7371 static constructor in static classes.
7373 2005-03-02 Martin Baulig <martin@ximian.com>
7376 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
7377 (Nullable.LiftedConversion): Added support for user-defined
7380 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
7382 * cs-parser.jay: Use ComposedCast everywhere instead of
7383 NullableType, so we don't need to check for NullableType
7385 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
7386 case where we'll be resolved into a `parenthesized_expression_0'
7390 (Convert.UserDefinedConversion): Added nullable conversions.
7392 2005-02-28 Martin Baulig <martin@ximian.com>
7394 * generic.cs (TypeManager.IsNullableType): New static method.
7395 (Nullable): New abstract class.
7396 (Nullable.NullLiteral): New public class.
7397 (Nullable.LiftedConversion): New public class.
7399 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
7400 `builtin_types opt_nullable'.
7403 (Convert.ImplicitConversionStandard): Added nullable conversions.
7404 (Convert.ExplicitConversionStandard): Likewise.
7405 (Convert.ExplicitConversion): Likewise.
7407 2005-02-26 Martin Baulig <martin@ximian.com>
7409 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
7410 begin with a "?", for instance "?[]". Don't do a type lookup if
7413 2005-02-25 Martin Baulig <martin@ximian.com>
7415 The first part of Nullable Types :-)
7417 * generic.cs (NullableType): New public class.
7418 (NullCoalescingOperator): New public class.
7419 (TypeArguments.Resolve): Add a CS0306 check.
7421 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
7422 (opt_nullable): New rule.
7423 (type): Added `opt_nullable' to `namespace_or_type_name',
7424 `builtin_types' and `pointer_type'.
7425 (array_type): Added `opt_nullable'.
7426 (opt_rank_specifier_or_nullable): New rule; this is the
7427 combination of `opt_rank_specifier' and `opt_nullable'.
7428 (opt_error): New rule; catch errors here.
7429 (nullable_type_or_conditional): New rule; we use this to check for
7430 nullable and still detect the conditional operator.
7431 (local_variable_type): Use `opt_rank_specifier_or_nullable'
7432 instead `opt_rank_specifier'.
7434 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
7437 2005-02-24 Martin Baulig <martin@ximian.com>
7439 * README, README.Changes: Removed; they're old and obsolete.
7441 2005-02-22 Martin Baulig <martin@ximian.com>
7443 * generic.cs (TypeParameter.Resolve): If resolving the constraints
7444 returned an error, set `constraints' to null to avoid a crash
7446 (TypeParameter.ResolveType): Likewise.
7448 2005-02-22 Martin Baulig <martin@ximian.com>
7451 (Constraints.ResolveTypes): Protect against being called twice.
7452 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
7453 (TypeParameter.ResolveType): New public method; calls
7454 constraints.ResolveTypes().
7455 (TypeParameter.DefineType): Moved constraints.ResolveType() out
7456 into the new ResolveType().
7457 (GenericMethod.Define): Call ResolveType() on all our
7460 2005-02-21 Martin Baulig <martin@ximian.com>
7463 (TypeManager.generic_nullable_type): New static public field.
7464 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
7467 (RootContext.ResolveCore): Resolve "System.Nullable`1".
7469 2005-02-15 Martin Baulig <martin@ximian.com>
7471 * generic.cs (ConstructedType.Constraints): Correctly check
7472 constraints if the argument type is a type parameter; fixes
7475 2005-02-02 Martin Baulig <martin@ximian.com>
7477 * delegate.cs (Delegate.DefineType): Report an internal error if
7478 TypeManager.multicast_delegate_type is null. See bug #72015 for
7481 2005-01-29 Miguel de Icaza <miguel@novell.com>
7483 * pending.cs: Produce better code (no nops produced by using Ldarg
7486 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7487 i - 1' it should be arg + 1.
7491 2005-01-26 Martin Baulig <martin@ximian.com>
7493 * cs-parser.jay (indexer_declarator): Don't report an error if we
7494 have type parameters since we can be an explicit interface
7495 implementation; fixes #71449.
7497 2005-01-26 Martin Baulig <martin@ximian.com>
7499 * class.cs (TypeContainer.AttributeTargets): Return the correct
7500 AttributeTargets depending on our `Kind' instead of throwing an
7501 exception; fixes #71632.
7503 2005-01-26 Martin Baulig <martin@ximian.com>
7505 * delegate.cs (Delegate.DefineType): Correctly define our type
7506 parameters. Fixes #71483.
7508 2005-01-25 Raja R Harinath <rharinath@novell.com>
7511 * expression.cs (MemberAccess.DoResolve): Don't complain with
7512 cs0572 when the LHS of a member access has identical name and type
7515 2005-01-25 Marek Safar <marek.safar@seznam.cz>
7518 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
7520 Create custom PermissionSet only for PermissionSetAttribute.
7522 2005-01-24 Marek Safar <marek.safar@seznam.cz>
7525 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
7526 delegates in static class.
7528 2005-01-24 Martin Baulig <martin@ximian.com>
7530 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7531 merging an implicit block, just use its reachability.
7533 * statement.cs (Block.Resolve): Make the unreachable code check
7534 work wrt. implicit blocks; see test-337 from #63842.
7536 2005-01-21 Alp Toker <alp@atoker.com>
7538 * cs-parser.jay: destructor_declaration's container is PartialContainer
7539 not Class when partial types are used, so use Kind prop instead of
7542 2005-01-22 Miguel de Icaza <miguel@ximian.com>
7544 * cs-parser.jay: Improve error reporting when an interface
7547 2005-01-20 Dick Porter <dick@ximian.com>
7549 * support.cs: SeekableStreamReader fix from Sandor Dobos
7550 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
7551 chars are read. Fixes bug 70369.
7553 2005-01-20 Raja R Harinath <rharinath@novell.com>
7555 * cs-parser.jay (catch_clause): Simplify current_block handling
7558 2005-01-17 Miguel de Icaza <miguel@ximian.com>
7560 * convert.cs (ImplicitStandardConversionExists): Synchronize the
7561 code with ImplicitStandardConversion to handle the implicit
7562 conversion of method groups into valid delegate invocations.
7564 The problem is that in parameter handling we were using this code
7565 path. Fixes bug #64698
7567 2005-01-19 Raja R Harinath <rharinath@novell.com>
7569 * cs-parser.jay: Fix several infelicities.
7570 - Avoid assigning to the parser value stack. Code like
7571 '$3 = null' is unclean. Synthesize a value for the code block
7573 - Avoid using oob_stack for storing location information. Use ...
7574 (_mark_): ... this. New (empty) rule. Saves the current location
7576 (foreach_statement): Avoid using oob_stack for current_block
7577 handling. Use technique used in for_statement and
7578 using_statement. Synthesize a value for the code block to store
7579 additional intermediate information.
7581 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7583 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7584 of a different type is only allowed to private fields of a
7585 containing type, not on fields of a base class.
7587 See test-174.cs and error cs0122-9.cs
7589 2005-01-13 Raja R Harinath <rharinath@novell.com>
7591 Fix test-335.cs (bug #58126).
7592 * cs-parser.jay (argument): Split out non-expression parts of the
7593 rule into 'non_simple_argument'.
7594 (invocation_expression): Support parenthesized invocations with
7595 multiple arguments, and with single non-simple arguments.
7597 2005-01-13 Raja R Harinath <rharinath@novell.com>
7599 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7602 2005-01-12 Raja R Harinath <rharinath@novell.com>
7604 Fix cs0038-1.cs, cs1640-6.cs.
7605 * ecore.cs (Expression.Resolve): Remove special-case for
7606 SimpleName in error-handling.
7607 (Expression.almostMatchedMembers): Relax access permission to
7609 (Expression.MemberLookupFailed): Handle duplicates in
7610 almostMatchedMembers list.
7611 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7612 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7613 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7614 overload if the passed in MemberInfo is a MethodBase.
7616 2005-01-25 Martin Baulig <martin@ximian.com>
7619 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7621 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7624 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7625 for non-CAS & merge permission sets properly.
7627 2005-01-11 Raja R Harinath <rharinath@novell.com>
7629 Improve standard-compliance of simple name and member access
7630 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7631 * ecore.cs (FullNamedExpression): New abstract base class
7632 for Namespaces and TypeExpressions.
7633 (ResolveFlags.SimpleName): Remove.
7634 (SimpleName): Remove support for dotted names.
7635 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7636 DeclSpace.FindType and DeclSpace.LookupType.
7637 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7638 (Expression.ExprClassName): Make member function.
7639 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7640 a namespace. Remove creation of dotted "SimpleName"s.
7641 (MemberAccess.DoResolve): Likewise.
7642 * decl.cs (DeclSpace.Cache): Make private.
7643 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7644 (DeclSpace.FindType): Update.
7645 (DeclSpace.LookupType): Move here from RootContext. Return a
7646 FullNamedExpression.
7647 * namespace.cs (Namespace): Derive from FullNamedExpression
7648 so that it can be part of expression resolution.
7649 (Namespace.Lookup): Return an FullNamedExpression.
7650 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7652 * rootcontext.cs (NamespaceLookup): Remove.
7653 (LookupType): Move to DeclSpace.
7654 * attribute.cs (CheckAttributeType): Update.
7655 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7656 (FindDocumentedTypeNonArray): Likewise.
7658 2005-01-11 Raja R Harinath <rharinath@novell.com>
7660 Fix cs0509.cs, cs1632.cs.
7661 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7662 is the same as IsInterface.
7663 (TypeContainer.GetClassBases): Likewise.
7664 * statement.cs (LabeledStatement.ig): New field.
7665 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7667 (LabeledStatement.DoEmit): Check that the label was created with
7668 the same ILGenerator.
7670 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7673 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7674 accessors to its properties.
7676 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7677 from accessors to property.
7679 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7682 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7685 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7687 * attribute.cs: Check for null and empty strings.
7689 I have lost another battle to Paolo.
7691 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7694 * class.cs (PropertyMethod): Set Parent field in ctors.
7695 (SetMethod.InternalParameters): Add unsafe switch hack.
7696 Override MarkForDuplicationCheck where it is appropriate.
7698 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7699 It says whether container allows members with the same name.
7701 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7702 Removed is_method parameter.
7704 2005-01-06 Duncan Mak <duncan@ximian.com>
7706 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7707 because the previous change led to incorrect reporting of CS1032
7708 ("Cannot define/undefine preprocessor symbols after first token in
7709 file"). Instead of using `tokens_seen' as the only flag that
7710 triggers CS1040, introduce `comments_seen'. This new flag is used
7711 to signify having seen comments on the current line, so it is
7712 unset after a newline.
7714 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7716 * doc.cs : When searching for a type, find nested type too.
7717 This fixes bug #71040.
7719 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7722 - Warn missing member comment on those classes which also does not
7723 have doc comments. Fixed bug #71041.
7724 - Don't warn missing doc comment on default constructor.
7727 2005-01-06 Duncan Mak <duncan@ximian.com>
7729 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7730 comments, set `tokens_seen' to true. This allows us to detect
7731 misplaced preprocessor directives (i.e. not at the beginning of
7732 the a line, nor after whitespaces). In that case, report error
7733 CS1040. This fixes bug #56460.
7735 * cs-parser.jay (interface_member_declaration): Add checks for
7736 IsExplicitImpl, and report CS0541 error if an interface member is
7737 defined as an explicit interface declaration.
7739 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7742 * class.cs (PropertyMethod): Set Parent field in ctors.
7743 (SetMethod.InternalParameters): Add unsafe switch hack.
7745 * decl.cs (MemberCore.Parent): Cannot be readonly.
7747 2005-01-06 Raja R Harinath <rharinath@novell.com>
7749 * decl.cs (DeclSpace.ResolveType): Remove.
7750 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7751 Merge in code from ...
7752 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7753 * class.cs, enum.cs: Update to changes.
7755 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7757 * anonymous.cs: Ensure that we init the scope of our parent if it
7758 has not been initialized yet.
7760 2004-12-30 Duncan Mak <duncan@ximian.com>
7762 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7763 if field.FieldBuilder is null. Fixes #70758.
7765 * convert.cs: Fixed some typos and updated some of the comments.
7766 (ImplicitStandardConversionExists):
7767 (TryImplicitIntConversion): If `target_type' is an interface and
7768 the type of `ic' implements this interface, return true or a new
7769 BoxedCast instead of null. This fixes #70468.
7771 2004-12-29 Duncan Mak <duncan@ximian.com>
7773 * expression.cs (Argument.Emit): Check that Expr is
7774 IMemoryLocation before casting to it, and report CS1510 otherwise.
7778 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7780 * statement.cs (Block.ThisVariable): remove the recursion here, to
7781 make the --profile more sane.
7783 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7785 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7786 assembly, by JB Evain.
7788 2004-12-17 Raja R Harinath <rharinath@novell.com>
7790 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7791 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7792 "parent" refers to enclosing type/class. "base" refers to superclass.
7794 2004-12-17 Raja R Harinath <rharinath@novell.com>
7796 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7797 Ensure that we only have GlobalAttributes.
7798 * attribute.cs (Attribute.Emit): Make non-virtual.
7799 (GlobalAttribute.Emit): Remove.
7800 (Attribute.Resolve): Make virtual.
7801 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7802 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7803 the argument. Don't create one.
7804 (Attribute.GetObsoleteAttribute): Likewise.
7805 (Attribute.GetClsCompliantAttributeValue): Likewise.
7806 * class.cs, decl.cs: Update to changes.
7808 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7810 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7812 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7814 * statement.cs (Foreach.Resolve): Add error 186 report.
7816 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7818 * expression.cs (Conditional.DoResolve): Add warning 429.
7820 * statement.cs (If.Resolve): Add warning 665.
7822 2004-12-16 Raja R Harinath <rharinath@novell.com>
7824 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7825 except when in the parser, and in GlobalAttribute.
7826 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7827 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7828 RootContext.Tree.Types.NamespaceEntry once work is done.
7829 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7830 and resets RootContext.Tree.Types.NamespaceEntry.
7832 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7834 * cs-parser.jay: Don't create a block for every variable.
7836 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7838 * location.cs: Provide extra information.
7840 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7841 variables from the captured environment, it is the ldarg_0.
7843 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7845 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7848 * class.cs: Changed warning level for 169 to avoid developer
7849 displeasure from warning flooding. It will be changed back when they
7850 fix most of current BCL warnings.
7852 * RootContext.cs: Pushed default WarningLevel to 3.
7854 * statement.cs: Removed unused variable.
7856 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7858 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7859 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7860 Add error 502 report.
7861 (StaticClass.DefineType): Add error 441 report.
7862 (Class.AllowedModifiersProp): New virtual property as temporary
7863 extension to AllowedModifiers.
7864 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7865 to share implementation with StaticClass and don't call virtual
7868 * driver.cs (MainDriver): Add error 1558 test.
7870 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7871 report. Moved error 36 test here.
7873 * statement.cs (Throw.Resolve): Add error 724 report.
7875 * typemanager.cs: Add out_attribute_type core type.
7877 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7879 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7881 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7883 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7886 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7888 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7889 Add error 3023 report.
7890 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7892 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7895 2004-12-12 John Luke <john.luke@gmail.com>
7897 * driver.cs (AddArgs): take -- into account when
7898 adding arguments, fixes bug 65710
7900 2004-12-12 Martin Baulig <martin@ximian.com>
7902 * expression.cs (Unary.TryReduceNegative): Added support for
7903 SByteConstant and ByteConstant.
7904 (Unary.Reduce): Check error values from TryReduceNegative().
7906 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7908 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7909 and report exception as error 182.
7911 2004-12-10 Raja R Harinath <rharinath@novell.com>
7913 * driver.cs (Main): Fix message when there are warnings.
7915 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7917 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7919 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7921 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
7922 Reduced number of warnings.
7924 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
7926 2004-12-08 Miguel de Icaza <miguel@ximian.com>
7928 * driver.cs: Removed message.
7930 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
7932 2004-12-08 <vargaz@freemail.hu>
7934 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
7936 2004-12-08 Martin Baulig <martin@ximian.com>
7938 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7939 instead of a CS3002 for properties and indexer.
7941 2004-12-08 Martin Baulig <martin@ximian.com>
7943 * decl.cs (MemberName.ToString): Make this work again.
7945 2004-12-08 Marek Safar <marek.safar@seznam.cz>
7947 * attribute.cs (Resolve): Add error 591 detection.
7949 * class.cs (FieldMember.Define): Add error 1547 detection.
7950 (Indexer.Define): Add error 620 detection.
7951 (Operator.Define): Add error 590 detection.
7953 * ecore.cs: Missing argument for error 79.
7955 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
7958 2004-12-07 Marek Safar <marek.safar@seznam.cz>
7961 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
7964 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7966 * cs-parser.jay : handle doc comments on implicit/explicit operators.
7967 Some operator comments were suppressed.
7968 * doc.cs : Implicit/explicit operator name in doc comments are like
7969 "op_Explicit(type)~returnType", so added suffix handling.
7971 2005-01-21 Alp Toker <alp@atoker.com>
7973 * cs-parser.jay: destructor_declaration's container is PartialContainer
7974 not Class when partial types are used, so use Kind prop instead of 'is'.
7976 2004-12-12 Martin Baulig <martin@ximian.com>
7978 * expression.cs (Unary.TryReduceNegative): Added support for
7979 SByteConstant and ByteConstant.
7980 (Unary.Reduce): Check error values from TryReduceNegative().
7982 2004-12-11 Martin Baulig <martin@ximian.com>
7984 * support.cs (ReflectionParameters.ParameterName): If we have a
7985 `gpd', call `ParameterName' on it.
7987 * parameter.cs (Parameter.GetParameterAttributes): New static method.
7989 * pending.cs (PendingImplementation.DefineProxy): Call
7990 DefineParameter() for all of the MethodBuilder's arguments.
7992 2004-12-09 Martin Baulig <martin@ximian.com>
7994 * doc.cs (DocUtil): Make this a static class.
7996 2004-12-09 Martin Baulig <martin@ximian.com>
7998 * expression.cs (Invocation.InferType): Moved the type inference
7999 implementation into TypeManager.
8001 * generics.cs (TypeManager): Moved the type inference
8002 implementation here.
8004 2004-12-09 Martin Baulig <martin@ximian.com>
8006 * typemanager.cs (TypeManager): Make this a partial class.
8009 (TypeManager): Move the generics part of `TypeManager' here.
8011 2004-12-08 Martin Baulig <martin@ximian.com>
8013 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
8014 instead of a CS3002 for properties and indexer. Added CS3024
8015 check for generic interfaces.
8017 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
8018 instances are not CLS-compliant.
8020 2004-12-08 Martin Baulig <martin@ximian.com>
8023 (void_pointer_expression): New rule for `void*', `void**' etc.
8024 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
8026 2004-12-08 Martin Baulig <martin@ximian.com>
8028 * expression.cs (Invocation.InferType): Removed the hack for
8029 MethodCore.MayUnify().
8031 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
8034 * class.cs (MethodCore.MayUnify): Use
8035 TypeManager.MayBecomeEqualGenericTypes().
8037 2004-12-08 Martin Baulig <martin@ximian.com>
8039 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
8040 parameter, box it. Fixes #69233.
8042 2004-12-08 Martin Baulig <martin@ximian.com>
8044 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
8045 have the ctor constraint. Fixes #68326.
8047 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
8049 * cs-parser.jay : interface comment was not consumed because of
8050 extra opt_semicolon before doc handling.
8052 2004-12-03 Raja R Harinath <rharinath@novell.com>
8054 Fix test-327.cs, test-328.cs, and put in early infrastructure
8055 for eventually fixing #52697.
8056 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
8057 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
8059 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
8060 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
8061 (VerifyUsing, error246): Update.
8062 * rootcontext.cs (RootContext.NamespaceLookup): Just use
8063 'NamespaceEntry.LookupNamespaceOrType'.
8065 2004-12-07 Martin Baulig <martin@ximian.com>
8067 * driver.cs: Call it "BETA SOFTWARE" :-)
8069 2004-12-06 Raja R Harinath <rharinath@novell.com>
8071 Fix crash on cs0657-17.cs.
8072 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
8073 Use RootContext.Tree.Types, not 'new RootTypes ()'.
8074 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
8075 the case where the NamespaceEntry gets overwritten.
8077 2004-12-06 Marek Safar <marek.safar@seznam.cz>
8079 Fixed #69195, #56821
8080 * ecore.cs (ResolveBoolean): Tiny refactoring.
8082 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
8083 of right expression resolving when left is false constant and
8084 operator is LogicalAnd OR true constant and operator is LogicalOr.
8086 * statement.cs (ResolveUnreachable): Always reports warning.
8088 2004-12-05 Miguel de Icaza <miguel@ximian.com>
8090 * class.cs: Distinguish between 1721 and 1722 (just a little help
8091 for the programmer).
8093 2004-12-03 Miguel de Icaza <miguel@ximian.com>
8095 * delegate.cs: Only allow this on new versions of the language.
8097 2004-12-02 Duncan Mak <duncan@ximian.com>
8099 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
8101 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
8102 here as a static method. Take an additional bool out parameter
8103 `must_do_cs1540_check' for signaling to InstanceResolve.
8104 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
8105 member field from PropertyExpr class and made it an argument of
8107 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
8108 check for MarshalByRefObject, and report CS0122 instead of CS1540.
8109 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
8110 and `remove_accessor' as well as InstanceResolve: report CS0122
8115 2004-12-07 Martin Baulig <martin@ximian.com>
8117 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
8118 and CS0692 where appropriate.
8120 2004-12-06 Martin Baulig <martin@ximian.com>
8122 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
8123 IsDuplicateImplementation() and improved it.
8125 * expression.cs (Invocation.InferTypeArguments): Added
8126 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
8127 and removed the "ref" modifier from `infered_types'.
8129 * decl.cs (MemberName.ToString): Removed the exception.
8131 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
8133 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
8134 comments are allowed.
8136 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8138 * delegate.cs: Add checks for subtypes in paramaters and return values
8139 in VerifyMethod () to add support for Covariance/Contravariance
8142 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8144 * report.cs: Remove extra closing parenthesis.
8146 * convert.cs (Error_CannotImplicitConversion): If the name of the
8147 types are the same, provide some extra information.
8149 2004-12-02 Marek Safar <marek.safar@seznam.cz>
8152 * attribute.cs (Resolve): Improved implementation of params
8153 attribute arguments.
8155 * support.cs (ParameterData): Add HasParams to be faster.
8157 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
8159 all things are for /doc support:
8161 * doc.cs: new file that supports XML documentation generation.
8162 * mcs.exe.sources: added doc.cs.
8164 Handle /doc command line option.
8165 Report error 2006 instead of 5 for missing file name for /doc.
8166 Generate XML documentation when required, after type resolution.
8168 Added support for picking up documentation (/// and /** ... */),
8169 including a new XmlCommentState enumeration.
8171 Added lines to fill Documentation element for field, constant,
8172 property, indexer, method, constructor, destructor, operator, event
8173 and class, struct, interface, delegate, enum.
8174 Added lines to warn incorrect comment.
8176 Added Documentation field (passed only when /doc was specified).
8178 Added DocComment, DocCommentHeader, GenerateDocComment() and
8179 OnGenerateDocComment() and some supporting private members for
8180 /doc feature to MemberCore.
8182 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
8184 Added overriden DocCommentHeader.
8186 Added overriden DocCommentHeader and GenerateDocComment().
8188 2004-12-01 Miguel de Icaza <miguel@ximian.com>
8190 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
8191 unwrapping the enumeration values, chain to
8192 DoConstantNumericPromotions again, so we can promote things to the
8193 fundamental types (takes care of enums that are bytes, sbytes).
8197 2004-12-01 Raja R Harinath <rharinath@novell.com>
8199 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
8200 Fix long-standing bug in type-lookup. Use FindType instead of
8201 LookupType when ec.ResolvingTypeTree.
8202 (Attribute.ResolveType, Attribute.Resolve)
8203 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
8205 (Attributes.Search): Remove internal version. Update.
8206 (Attributes.SearchMulti): Update.
8207 (Attributes.GetClsCompliantAttribute): Remove.
8208 (Attributes.GetIndexerNameAttribute): Remove.
8209 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
8210 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
8211 * class.cs (Indexer.Define): Likewise.
8213 2004-12-01 Marek Safar <marek.safar@seznam.cz>
8216 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
8217 MarshallByReference members access.
8219 * expression.cs: Use CheckMarshallByRefAccess;
8220 Better error CS0197 message.
8222 * report.cs: Print whole related error message.
8224 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8226 * class (GetClassBases): Better error 60 report.
8227 (EventProperty): Disabled warning 67 detection.
8229 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8232 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
8234 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
8237 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8240 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
8242 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
8244 2004-11-26 Miguel de Icaza <miguel@ximian.com>
8246 * attribute.cs (Attribute.Resolve): Refine error reporting and
8247 report a cs0117 if the identifier does not exist, to distinguish
8248 from 0617 which is a miss-use of the actual identifier.
8250 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
8251 between cs0070 and cs0079.
8253 * class.cs (MemberBase.DoDefine): When reporting a wrong
8254 accessibility level, we use MethodCore to compare instead of
8255 Method (this was a regression in some refactoring effort).
8257 So now we correctly report cs0056 again.
8259 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
8260 testing the target_type (which was known to be object_type) and
8261 not the source type (which is anonymous_method).
8263 Fixed reporting of error cs1660.
8265 * expression.cs (UserCast.Source): Expose the underlying cast.
8267 * statement.cs (Switch.SwitchGoverningType): Sort the list of
8268 allowed types to find a match to int32 first (most common).
8270 In addition, it ignores any ImplicitUserConversions that did an
8271 internal implicit conversion (as the switch statement allows only
8272 one integral conversion to exist).
8274 * class.cs (PartialContainer.Create): rename `name' to
8275 `member_name' for clarity. Then replace the string calls with a
8276 call to MemberName.GetPartialName, as now using
8277 MemberName.ToString is an error (this is due to the side effects
8278 it had, that were fixed in the past).
8280 This will restore the error reporting on a number of partial class
8281 errors that were missusing this (and getting an exception as a
8282 results, which is now just a plain textual warning, because
8283 yyparse debug output would crash otherwise).
8285 2004-11-26 Raja R Harinath <rharinath@novell.com>
8287 * Makefile (PROGRAM_INSTALL_DIR): Remove.
8289 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8291 * rootcontext.cs (LookupType): Make sure to cache lookups that
8292 don't give us a negative result. This saves about 5% of corlib
8295 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8297 * report.cs (AbstractMessage.Print): messages are sent to stderr
8299 * class.cs (TypeContainer.GetClassBases): It is an error to have a
8300 non-interface in the list of interfaces (at this point, either
8301 parent was properly set, or a base class is being listed in the
8302 interfaces section).
8304 This flags error 1722, and resolves the crash from bug 69259.
8306 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8308 * statement.cs (Using.EmitExpressionFinally): make this work right
8309 for valuetypes. Fixes 69926.
8311 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8313 * const.cs (Const.ChangeType): Cope with the "0 literal can be
8314 converted to an enum" here, before we try to change the underlying
8315 type. This code exists, but it is a different code path than the
8316 one used while encoding constants.
8318 (ImplicitReferenceConversionExists): In addition, resynchronized
8319 the code here, so it matches the same code in
8320 ImplicitReferenceConversionExists for the `from any class-type S
8321 to any interface-type T'.
8323 2004-11-25 Marek Safar <marek.safar@seznam.cz>
8325 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
8327 2004-11-24 Miguel de Icaza <miguel@ximian.com>
8329 * cs-parser.jay: Use verbosity accordingly.
8331 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8333 * expression.cs (Unary.ResolveOperator): Do not report warning;
8334 AddressOf reads from variable.
8336 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
8338 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8342 * attribute.cs (Attributable): Removed CheckTargets.
8343 (Attributes.Emit): Explicit attribute targets are tested here.
8345 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
8346 not enabled for interfaces.
8348 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
8349 (GetAssemblyName): Ouch next bug there.
8351 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8353 * expression.cs: Error 275 added.
8355 2004-11-23 Marek Safar <marek.safar@seznam.cz>
8357 Fix bug #69177 (Implemented decimal constant support)
8359 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
8360 (BinaryFold): Add DecimalConstant.
8362 * const.cs (Define): Decimal constant
8364 (ChangeType): Add decimal type handling.
8365 (LookupConstantValue): Don't set value for decimal type but
8366 emit DecimalConstantAttribute. Needed for constant optimization.
8368 * constant.cs (ToDecimal): New method.
8369 (ConvertToDecimal): New method.
8370 (IntConstant): Implemented ConvertToDecimal.
8371 (DecimalConstant.Emit): Emit optimized version for decimals in
8374 * expression.cs (ResolveOperator): Changed order of constant
8375 reduction to work correctly with native types which have
8376 overloaded operators.
8377 (ResolveMemberAccess): Extract constant value from attribute
8380 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
8382 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
8383 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
8384 (ChangeType): Decimal is special.
8385 (TypeToCoreType): Add decimal type.
8387 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8389 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
8392 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8394 * class.cs (EventField.ApplyAttributeBuilder): Fix error
8397 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8399 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
8401 * pending.cs (PendingImplementation): Grab only interfaces.
8403 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8405 * statement.cs (ForeachHelperMethods): Add location member and
8406 error 202 detection.
8408 2004-11-18 Marek Safar <marek.safar@seznam.cz>
8410 * expression.cs (DoResolveBase): Fixed wrong warning for out
8413 2004-12-04 Martin Baulig <martin@ximian.com>
8415 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
8416 to check whether the conversion is ok.
8418 * typemanager.cs (TypeManager.GetTypeArguments): Just return
8419 `Type.EmptyTypes' if we're not a generic TypeContainer.
8421 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8423 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
8424 old bug: when converting from the null literal to a pointer,
8425 return an EmptyCast, not the NullLiteral.
8427 This fixes #69921, the recent null_type changes probably made this
8430 2004-12-03 Martin Baulig <martin@ximian.com>
8432 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8433 method as our child, call AnonymousMethod.Compatible() on it.
8435 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8437 * class.cs (FieldBase): Use an unused bit field from the field to
8438 encode the `has_offset' property from the FieldMember. This saves
8439 a couple of Ks on bootstrap compilation.
8441 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8442 method as our child, return the AnonymousMethod resolved
8445 * expression.cs (New.DoResolve): Allow return values from
8446 NewDelegate to also include AnonymousMethods.
8450 2004-11-29 Raja R Harinath <rharinath@novell.com>
8452 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
8454 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
8455 System.Runtime.InteropServices._Exception, since it's a base
8456 interface of the core type System.Exception in the net_2_0 profile.
8458 2004-11-27 Martin Baulig <martin@ximian.com>
8460 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
8462 2004-11-26 Raja R Harinath <rharinath@novell.com>
8464 * Makefile: Convert to use executable.make.
8465 * gmcs.exe.sources: New.
8467 2004-11-25 Martin Baulig <martin@ximian.com>
8469 * expression.cs (Invocation.InferType): Added support for byref types.
8471 2004-11-25 Martin Baulig <martin@ximian.com>
8473 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8474 in TypeManager.TypeToCoreType().
8476 2004-11-25 Martin Baulig <martin@ximian.com>
8478 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
8479 "Dispose" method from the `current_type'.
8480 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
8481 DoDefineMembers() instead of using the MethodBuilder; this is
8482 required for generic iterators.
8484 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
8486 2004-11-24 Martin Baulig <martin@ximian.com>
8488 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
8490 2004-11-20 Martin Baulig <martin@ximian.com>
8492 * expression.cs (Invocation.InferType): Correctly infer generic
8493 instances; see gen-103.cs.
8494 (Invocation.InferTypeArguments): If a generic method doesn't have
8495 any unbound type parameters, we don't need to infer anything.
8497 2004-11-19 Raja R Harinath <rharinath@novell.com>
8499 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
8501 2004-11-17 Raja R Harinath <rharinath@novell.com>
8503 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
8504 (TypeHandle.GetMemberCache): New.
8505 (TypeHandle.TypeHandle): Update.
8506 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
8507 (TypeManager.LookupParentInterfacesCache):
8508 Rename from LookupInterfaceCache. Optimize slightly.
8509 (TypeManager.MemberLookup_FindMembers): Update.
8510 * decl.cs (MemberCache.MemberCache): Set Container to null in the
8512 (AddCacheContents): Rename from AddHashtable.
8513 * class.cs (TypeContainer.parent_container): Remove.
8514 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
8515 (TypeContainer.DoDefineMembers): Don't initialize it.
8516 Update to name changes.
8518 2004-11-17 Miguel de Icaza <miguel@ximian.com>
8520 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
8521 that factors the code to check access modifiers on override.
8523 (PropertyBase): Use the code here.
8525 Patch from Lluis S'anchez, fixes bug #69361.
8527 2004-11-15 Miguel de Icaza <miguel@ximian.com>
8529 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
8530 routine that is used to report the use of a captured variable
8531 whose address has been taken.
8533 There are two checks: one when variables are being captured and
8534 the other check is when the address of a variable is taken.
8536 (because an anonymous methods might be resolved before *or* after
8537 the address has been taken) and
8539 * expression.cs (Conditional.DoResolve): Remove the special
8540 casing that Martin added to trueExpr and falseExpr being both
8541 NullLiteral. We get the right behavior now just by introducing
8542 the null_type into the compiler.
8544 * convert.cs (ExplicitConversion): Change the code to use
8545 null_type instead of testing `expr is NullLiteral'.
8546 (ImplicitConversionStandard): use null_type too.
8547 (ImplicitReferenceConversionExists): use null_type too.
8548 (ImplicitReferenceConversion): use null_type too.
8550 * literal.cs: The type of `NullLiteral' is now null_type instead
8552 (Resolve): Set the type here.
8554 * typemanager.cs: Introduce null_type.
8556 2004-11-18 Martin Baulig <martin@ximian.com>
8559 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
8561 2004-11-18 Martin Baulig <martin@ximian.com>
8563 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
8565 2004-11-18 Martin Baulig <martin@ximian.com>
8567 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8568 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8569 call ResolveConstructedType() on it to resolve it without checking
8571 (Constraints.ResolveTypes): Check them here.
8572 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8573 but don't check constraints.
8574 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8575 check constraints here.
8576 (ConstructedType.ResolveConstructedType): New public method. This
8577 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8578 resolve ourselves without checking constraints.
8580 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8582 2004-11-18 Martin Baulig <martin@ximian.com>
8585 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8587 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8589 2004-11-18 Martin Baulig <martin@ximian.com>
8591 * ecore.cs (TypeExpr.ResolveType): Removed.
8592 (Expression.ResolveAsTypeTerminal): We always return a fully
8593 resolved `TypeExpr', so we can just access its `Type'.
8595 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8597 2004-11-17 Martin Baulig <martin@ximian.com>
8599 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8600 sure we don't return any unresolved TypeExpr's.
8601 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8603 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8605 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8606 unresolved `ConstructedType's.
8608 2004-11-17 Martin Baulig <martin@ximian.com>
8610 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8612 2004-11-17 Martin Baulig <martin@ximian.com>
8615 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8617 * decl.cs (DeclSpace.ResolveType): Removed.
8618 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8620 2004-11-17 Martin Baulig <martin@ximian.com>
8622 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8623 direction, like FindMembers() does. Fixes #69546, testcase is in
8626 2004-11-16 Martin Baulig <martin@ximian.com>
8628 This is based on a patch from Marek Safar, see bug #69082.
8629 Fixes bugs #63705 and #67130.
8631 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8632 method; create a MemberCache for an interface type and cache the
8635 * decl.cs (IMemberContainer.ParentContainer): Removed.
8636 (IMemberContainer.ParentCache): New property.
8637 (MemberCache.SetupCacheForInterface): Removed.
8638 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8639 to create a cache for an interface's "parent".
8641 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8644 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8646 * statement.cs: Avoid adding bools to a hashtable.
8648 2004-11-15 Martin Baulig <martin@ximian.com>
8650 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8652 2004-11-11 Martin Baulig <martin@ximian.com>
8654 * typemanager.cs (TypeManager.GetMethodName): New method.
8656 * class.cs (MethodData.Define): Include the generic arity in the
8657 name of an explicit interface; also add it to the method name.
8659 * pending.cs (PendingImplementation.InterfaceMethod): The method
8660 name now includes the generic arity.
8662 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8664 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8665 calling an unsafe method from a safe location.
8667 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8670 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8672 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8674 * namespace.cs (VerifyUsing): use GetPartialName instead of
8677 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8679 * statement.cs (Return.Resolve): Fix regression in typo: if
8680 `in_exc', we have to request a NeedReturnLabel, this was a typo
8681 introduced in the anonymous method check-in. Fixes #69131.
8683 * Indexers were using the ShortName when defining themselves,
8684 causing a regression in the compiler bootstrap when applying the
8685 patch from 2004-11-02 (first part), now they use their full name
8686 and the bug is gone.
8688 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8690 * driver.cs: Strip the path from the names of embedded resources. Fixes
8693 2004-11-04 Raja R Harinath <rharinath@novell.com>
8695 Fix error message regression: cs0104-2.cs.
8696 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8697 (AliasEntry.Resolve): Update.
8698 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8700 (RootContext.LookupType): Update.
8702 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8704 * cs-parser.jay: Add support for handling accessor modifiers
8705 * class: Add support port accessor modifiers and error checking,
8706 define PropertyMethod.Define as virtual (not abstract anymore)
8707 * ecore.cs: Add checking for proeprties access with access modifiers
8708 * iterators.cs: Modify Accessor constructor call based in the modified
8710 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8712 * expression.cs (StringConcat): Handle being called twice,
8713 as when we have a concat in a field init with more than two
8716 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8718 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8719 special case explicit implementations, we should always produce
8720 the .property or .event declaration.
8722 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8723 since it will not return correct data if people use this
8724 unresolved in the presence of using statements (see test-313).
8726 * class.cs (MethodData.Define): If we are an explicit interface
8727 implementation, set the method name to the full name of the
8728 interface plus the name of the method.
8730 Notice that using the method.MethodName.GetFullName() does not
8731 work, as it will only contain the name as declared on the source
8732 file (it can be a shorthand in the presence of using statements)
8733 and not the fully qualifed type name, for example:
8737 class D : ICloneable {
8738 object ICloneable.Clone () {
8742 Would produce a method called `ICloneable.Clone' instead of
8743 `System.ICloneable.Clone'.
8745 * namespace.cs (Alias.Resolve): Use GetPartialName.
8747 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8749 * cs-parser.jay: Add error 1055 report.
8751 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8753 * assign.cs (Assign.DoResolve): Only do the transform of
8754 assignment into a New if the types are compatible, if not, fall
8755 through and let the implicit code deal with the errors and with
8756 the necessary conversions.
8758 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8760 * cs-parser.jay: Add error 1031 report.
8762 * cs-tokenizer.cs: Add location for error 1038.
8764 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8766 * cs-parser.jay: Add error 1016 report.
8768 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8770 * cs-parser.jay: Add errors 1575,1611 report.
8772 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8774 * cs-parser.jay: Add error 1001 report.
8776 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8779 * attribute.cs (GetMarshal): Add method argument for
8780 caller identification.
8782 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8783 agument for GetMarshal and RuntimeMissingSupport.
8785 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8787 * attribute.cs (ExtractSecurityPermissionSet): Removed
8788 TypeManager.code_access_permission_type.
8790 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8792 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8794 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8795 for obsolete use of a variable here. Fixes regression on errors
8796 cs0619-25 and cs0619-26.
8798 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8800 Fix #62358, implemented security attribute encoding.
8802 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8803 Tests permitted SecurityAction for assembly or other types.
8804 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8805 data from SecurityPermissionAttribute to PermisionSet class.
8807 * class.cs (ApplyAttributeBuilder): Added special handling
8808 for System.Security.Permissions.SecurityAttribute based types.
8810 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8811 special handling for System.Security.Permissions.SecurityAttribute
8814 * enum.cs (ApplyAttributeBuilder): Added special handling
8815 for System.Security.Permissions.SecurityAttribute based types.
8817 * parameter.cs (ApplyAttributeBuilder): Added special handling
8818 for System.Security.Permissions.SecurityAttribute based types.
8820 * rootcontext.cs: Next 2 core types.
8822 * typemanager.cs (TypeManager.security_permission_attr_type):
8823 Built in type for the SecurityPermission Attribute.
8824 (code_access_permission_type): Build in type.
8826 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8828 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8829 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8830 all of this information into
8831 EmitContext.EmitCapturedVariableInstance.
8833 * codegen.cs (EmitCapturedVariableInstance): move here the
8834 funcionality of emitting an ldarg.0 in the presence of a
8835 remapping. This centralizes the instance emit code.
8837 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8838 then emit a load of this: it means that we have reached the
8839 topmost ScopeInfo: the one that contains the pointer to the
8840 instance of the class hosting the anonymous method.
8842 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8843 captures to the topmost CaptureContext.
8845 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8847 * expression.cs (LocalVariableReference): Move the knowledge about
8848 the iterators into codegen's EmitCapturedVariableInstance.
8850 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8852 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8853 all code paths return a value from an anonymous method (it is the
8854 same as the 161 error, but for anonymous methods).
8856 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8858 The introduction of anonymous methods in the compiler changed
8859 various ways of doing things in the compiler. The most
8860 significant one is the hard split between the resolution phase
8861 and the emission phases of the compiler.
8863 For instance, routines that referenced local variables no
8864 longer can safely create temporary variables during the
8865 resolution phase: they must do so from the emission phase,
8866 since the variable might have been "captured", hence access to
8867 it can not be done with the local-variable operations from the runtime.
8871 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8872 is a toplevel block.
8874 (ToplevelBlock): A new kind of Block, these are the blocks that
8875 are created by the parser for all toplevel method bodies. These
8876 include methods, accessors and anonymous methods.
8878 These contain some extra information not found in regular blocks:
8879 A pointer to an optional CaptureContext (for tracking captured
8880 local variables and parameters). A pointer to the parent
8883 (Return.Resolve): Catch missmatches when returning a value from an
8884 anonymous method (error 1662).
8885 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8888 (Break.Resolve): ditto.
8890 (SwitchLabel): instead of defining the labels during the
8891 resolution phase, we now turned the public ILLabel and ILLabelCode
8892 labels into methods called GetILLabelCode() and GetILLabel() that
8893 only define the label during the Emit phase.
8895 (GotoCase): Track the SwitchLabel instead of the computed label
8896 (its contained therein). Emit the code by using
8897 SwitchLabel.GetILLabelCode ().
8899 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8900 whether the Local has been captured or not.
8902 (LocalInfo.IsCaptured): New property, used to tell whether the
8903 local has been captured.
8905 * anonymous.cs: Vastly updated to contain the anonymous method
8908 The main classes here are: CaptureContext which tracks any
8909 captured information for a toplevel block and ScopeInfo used to
8910 track the activation frames for various local variables.
8912 Each toplevel block has an optional capture context associated
8913 with it. When a method contains an anonymous method both the
8914 toplevel method and the anonymous method will create a capture
8915 context. When variables or parameters are captured, they are
8916 recorded on the CaptureContext that owns them, for example:
8920 MyDelegate d = delegate {
8925 Here `a' will be recorded as captured on the toplevel
8926 CapturedContext, the inner captured context will not have anything
8927 (it will only have data if local variables or parameters from it
8928 are captured in a nested anonymous method.
8930 The ScopeInfo is used to track the activation frames for local
8931 variables, for example:
8933 for (int i = 0; i < 10; i++)
8934 for (int j = 0; j < 10; j++){
8935 MyDelegate d = delegate {
8940 At runtime this captures a single captured variable `i', but it
8941 captures 10 different versions of the variable `j'. The variable
8942 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
8943 recorded on a child.
8945 The toplevel ScopeInfo will also track information like the `this'
8946 pointer if instance variables were referenced (this is necessary
8947 as the anonymous method lives inside a nested class in the host
8948 type of the method).
8950 (AnonymousMethod): Expanded to track the Toplevel, implement
8951 `AnonymousMethod.Compatible' to tell whether an anonymous method
8952 can be converted to a target delegate type.
8954 The routine now also produces the anonymous method content
8956 (AnonymousDelegate): A helper class that derives from
8957 DelegateCreation, this is used to generate the code necessary to
8958 produce the delegate for the anonymous method that was created.
8960 * assign.cs: API adjustments for new changes in
8961 Convert.ImplicitStandardConversionExists.
8963 * class.cs: Adjustments to cope with the fact that now toplevel
8964 blocks are of type `ToplevelBlock'.
8966 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
8967 insteda of standard blocks.
8969 Flag errors if params arguments are passed to anonymous methods.
8971 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
8972 `CurrentAnonymousMethod' which points to the current Anonymous
8973 Method. The variable points to the AnonymousMethod class that
8974 holds the code being compiled. It is set in the new EmitContext
8975 created for the anonymous method.
8977 (EmitContext.Phase): Introduce a variable and an enumeration to
8978 assist in enforcing some rules about when and where we are allowed
8979 to invoke certain methods (EmitContext.NeedsReturnLabel is the
8980 only one that enfonces this right now).
8982 (EmitContext.HaveCaptureInfo): new helper method that returns
8983 whether we have a CapturedContext initialized.
8985 (EmitContext.CaptureVariable): New method used to register that a
8986 LocalInfo must be flagged for capturing.
8988 (EmitContext.CapturedParameter): New method used to register that a
8989 parameters must be flagged for capturing.
8991 (EmitContext.CapturedField): New method used to register that a
8992 field must be flagged for capturing.
8994 (EmitContext.HaveCapturedVariables,
8995 EmitContext.HaveCapturedFields): Return whether there are captured
8996 variables or fields.
8998 (EmitContext.EmitMethodHostInstance): This is used to emit the
8999 instance for the anonymous method. The instance might be null
9000 (static methods), this (for anonymous methods that capture nothing
9001 and happen to live side-by-side with the current method body) or a
9002 more complicated expression if the method has a CaptureContext.
9004 (EmitContext.EmitTopBlock): Routine that drives the emission of
9005 code: it will first resolve the top block, then emit any metadata
9006 and then emit the code. The split is done so that we can extract
9007 any anonymous methods and flag any captured variables/parameters.
9009 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
9010 during this phase, the ILGenerator should not be used as labels
9011 and local variables declared here might not be accessible to any
9012 code that is part of an anonymous method.
9014 Exceptions to this include the temporary variables that are
9015 created by some statements internally for holding temporary
9018 (EmitContext.EmitMeta): New routine, in charge of emitting all the
9021 (EmitContext.TemporaryReturn): This method is typically called
9022 from the Emit phase, and its the only place where we allow the
9023 ReturnLabel to be defined other than the EmitMeta. The reason is
9024 that otherwise we would have to duplicate a lot of logic in the
9025 Resolve phases of various methods that today is on the Emit
9028 (EmitContext.NeedReturnLabel): This no longer creates the label,
9029 as the ILGenerator is not valid during the resolve phase.
9031 (EmitContext.EmitThis): Extended the knowledge in this class to
9032 work in anonymous methods in addition to iterators.
9034 (EmitContext.EmitCapturedVariableInstance): This emits whatever
9035 code is necessary on the stack to access the instance to a local
9036 variable (the variable will be accessed as a field).
9038 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
9039 EmitContext.EmitAddressOfParameter): Routines to support
9040 parameters (not completed at this point).
9042 Removals: Removed RemapLocal and RemapLocalLValue. We probably
9043 will also remove the parameters.
9045 * convert.cs (Convert): Define a `ConstantEC' which points to a
9046 null. This is just to prefity some code that uses
9047 ImplicitStandardConversion code and do not have an EmitContext
9050 The idea is to flag explicitly that at that point in time, it is
9051 known that the conversion will not trigger the delegate checking
9052 code in implicit conversions (which requires a valid
9055 Everywhere: pass new EmitContext parameter since
9056 ImplicitStandardConversionExists now requires it to check for
9057 anonymous method conversions.
9059 (Convert.ImplicitStandardConversionExists): If the type of an
9060 expression is the anonymous_method_type, and the type is a
9061 delegate, we invoke the AnonymousMethod.Compatible method to check
9062 whether an implicit conversion is possible.
9064 (Convert.ImplicitConversionStandard): Only do implicit method
9065 group conversions if the language level is not ISO_1.
9067 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
9068 MethodInfo for the Invoke method. used by Delegate and
9071 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
9072 method conversions if the target type is a delegate.
9074 Removed extra debugging nops.
9076 (LocalVariableReference): Turn the `local_info' into a public
9079 Add `prepared' field, the same hack used for FieldExprs to cope
9080 with composed assignments, as Local variables do not necessarily
9081 operate purely on the stack as they used to: they can be captured
9084 Add `temp' for a temporary result, like fields.
9086 Refactor DoResolve and DoResolveLValue into DoResolveBase.
9088 It now copes with Local variables that are captured and emits the
9089 proper instance variable to load it from a field in the captured
9092 (ParameterReference.DoResolveBase): During the resolve phase,
9093 capture parameters if we are in an anonymous method.
9095 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
9096 anonymous method, use the EmitContext helper routines to emit the
9097 parameter reference.
9099 * iterators.cs: Set RemapToProxy to true/false during the
9102 * parameters.cs (GetParameterByName): New helper method.
9104 * typemanager.cs (anonymous_method_type) a new type that
9105 represents an anonyous method. This is always an internal type,
9106 used as a fencepost to test against the anonymous-methodness of an
9109 2004-10-20 Marek Safar <marek.safar@seznam.cz>
9111 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
9113 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
9115 2004-11-10 Martin Baulig <martin@ximian.com>
9117 * expression.cs (Invocation.BetterFunction): If two methods have
9118 equal parameter types, but only one of them is generic, the
9119 non-generic one wins.
9120 (New.DoResolve): Don't set `is_struct' to false if we're a generic
9121 instance; just use `Type.IsValueType' to determine whether
9122 something is a struct or not.
9123 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
9124 so we can be called multiple times.
9126 2004-11-10 Martin Baulig <martin@ximian.com>
9128 * generic.cs (TypeParameter.DefineConstraints): New public method.
9129 (TypeParameter.CheckAccessLevel): Override this and return true.
9130 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
9131 override ResolveType() anymore.
9132 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
9134 2004-11-10 Martin Baulig <martin@ximian.com>
9136 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
9137 call DeclSpace.ResolveNestedType() on it.
9139 2004-11-10 Martin Baulig <martin@ximian.com>
9141 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
9142 non-null, call ParameterModifier() on it.
9144 2004-11-10 Martin Baulig <martin@ximian.com>
9147 (Iterators): Added `current_type' and `this_type' fields.
9148 (Iterators.DefineIterator): Create a new EmitContext and store it
9149 in `ec'; compute `this_type'.
9151 2004-11-10 Martin Baulig <martin@ximian.com>
9154 (TypeManager.IsPrivateAccessible): New public method.
9155 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
9157 2004-11-10 Martin Baulig <martin@ximian.com>
9159 * class.cs (TypeContainer.DefineType): Call
9160 TypeBuilder.DefineGenericParameters() before resolving the type
9162 (MethodData.parent_method): New protected field.
9163 (MethodData..ctor): Added `MethodInfo parent_method' argument.
9164 (MethodData.Define): Compute `parent_method'.
9167 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
9168 (MemberCore.GetClsCompliantAttributeValue): Likewise.
9169 (DeclSpace.ec): New protected field; store the EmitContext here.
9170 (DeclSpace.EmitContext): New public property.
9171 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
9172 (DeclSpace.ResolveNestedType): New public method.
9173 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
9174 (DeclSpace.NestedAccessible): Added `Type tb' argument.
9175 (DeclSpace.FamilyAccessible): Likewise.
9176 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
9177 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
9180 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
9183 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
9184 (Enum.Emit): Don't create a new EmitContext.
9186 2004-10-18 Martin Baulig <martin@ximian.com>
9188 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
9189 `Type' directly, but call ResolveType() on it.
9190 (Catch.Resolve): Likewise.
9191 (Foreach.Resolve): Likewise.
9193 2004-10-18 Martin Baulig <martin@ximian.com>
9195 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
9196 `Type' directly, but call ResolveType() on it.
9197 (Probe.DoResolve): Likewise.
9198 (ArrayCreation.LookupType): Likewise.
9199 (TypeOf.DoResolve): Likewise.
9200 (SizeOf.DoResolve): Likewise.
9202 2004-10-18 Raja R Harinath <rharinath@novell.com>
9204 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
9207 2004-10-17 John Luke <john.luke@gmail.com>
9209 * class.cs (Operator.GetSignatureForError): use CSharpName
9211 * parameter.cs (Parameter.GetSignatureForError): Returns
9212 correct name even if was not defined.
9214 2004-10-13 Raja R Harinath <rharinath@novell.com>
9217 * class.cs (TypeContainer.EmitContext): New property.
9218 (DefineNestedTypes): Create an emitcontext for each part.
9219 (MethodCore.DoDefineParameters): Use container's emitcontext.
9220 Pass type array to InternalParameters.
9221 (MemberBase.DoDefine): Use container's emitcontext.
9222 (FieldMember.Define): Likewise.
9223 (Event.Define): Likewise.
9224 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9225 Pass type array to InternalParameters.
9226 (SetIndexerMethod.GetParameterInfo): Likewise.
9227 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9228 * delegate.cs (Define): Pass emitcontext to
9229 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9230 array to InternalParameters.
9231 * expression.cs (ParameterReference.DoResolveBase): Pass
9232 emitcontext to GetParameterInfo.
9233 (ComposedCast.DoResolveAsTypeStep): Remove check on
9234 ec.ResolvingTypeTree.
9235 * parameter.cs (Parameter.Resolve): Change argument to
9236 EmitContext. Use ResolveAsTypeTerminal.
9237 (Parameter.GetSignature): Change argument to EmitContext.
9238 (Parameters.ComputeSignature): Likewise.
9239 (Parameters.ComputeParameterTypes): Likewise.
9240 (Parameters.GetParameterInfo): Likewise.
9241 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9242 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9243 * support.cs (InternalParameters..ctor): Remove variant that takes
9245 * typemanager.cs (system_intptr_expr): New.
9246 (InitExpressionTypes): Initialize it.
9248 2004-10-12 Chris Toshok <toshok@ximian.com>
9250 * cs-parser.jay: fix location for try_statement and catch_clause.
9252 2004-10-18 Martin Baulig <martin@ximian.com>
9254 * class.cs (FieldMember.Define): Don't access the TypeExpr's
9255 `Type' directly, but call ResolveType() on it.
9256 (MemberBase.DoDefine): Likewise.
9258 * expression.cs (New.DoResolve): Don't access the TypeExpr's
9259 `Type' directly, but call ResolveType() on it.
9260 (ComposedCast.DoResolveAsTypeStep): Likewise.
9262 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
9263 `Type' directly, but call ResolveType() on it.
9265 2004-10-17 John Luke <john.luke@gmail.com>
9267 * class.cs (Operator.GetSignatureForError): use CSharpName
9269 * parameter.cs (Parameter.GetSignatureForError): Returns
9270 correct name even if was not defined.
9272 2004-10-13 Raja R Harinath <rharinath@novell.com>
9275 * class.cs (TypeContainer.EmitContext): New property.
9276 (DefineNestedTypes): Create an emitcontext for each part.
9277 (MethodCore.DoDefineParameters): Use container's emitcontext.
9278 Pass type array to InternalParameters.
9279 (MemberBase.DoDefine): Use container's emitcontext.
9280 (FieldMember.Define): Likewise.
9281 (Event.Define): Likewise.
9282 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9283 Pass type array to InternalParameters.
9284 (SetIndexerMethod.GetParameterInfo): Likewise.
9285 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9286 * delegate.cs (Define): Pass emitcontext to
9287 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9288 array to InternalParameters.
9289 * expression.cs (ParameterReference.DoResolveBase): Pass
9290 emitcontext to GetParameterInfo.
9291 (ComposedCast.DoResolveAsTypeStep): Remove check on
9292 ec.ResolvingTypeTree.
9293 * parameter.cs (Parameter.Resolve): Change argument to
9294 EmitContext. Use ResolveAsTypeTerminal.
9295 (Parameter.GetSignature): Change argument to EmitContext.
9296 (Parameters.ComputeSignature): Likewise.
9297 (Parameters.ComputeParameterTypes): Likewise.
9298 (Parameters.GetParameterInfo): Likewise.
9299 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9300 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9301 * support.cs (InternalParameters..ctor): Remove variant that takes
9303 * typemanager.cs (system_intptr_expr): New.
9304 (InitExpressionTypes): Initialize it.
9306 2004-10-12 Chris Toshok <toshok@ximian.com>
9308 * cs-parser.jay: fix location for try_statement and catch_clause.
9310 2004-10-07 Raja R Harinath <rharinath@novell.com>
9312 More DeclSpace.ResolveType avoidance.
9313 * decl.cs (MemberCore.InUnsafe): New property.
9314 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
9315 with newly created EmitContext.
9316 (FieldMember.Define): Likewise.
9317 * delegate.cs (Delegate.Define): Likewise.
9318 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
9319 only if normal name-lookup fails.
9320 (TypeExpr.DoResolve): Enable error-checking.
9321 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
9322 (SizeOf.DoResolve): Likewise.
9323 (ComposedCast.DoResolveAsTypeStep): Likewise.
9324 (StackAlloc.DoResolve): Likewise.
9325 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
9326 (Block.Unsafe): New property.
9327 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
9328 (Unsafe): Set 'unsafe' flag of contained block.
9329 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
9330 (Fixed.Resolve): Likewise.
9331 (Catch.Resolve): Likewise.
9332 (Using.ResolveLocalVariableDecls): Likewise.
9333 (Foreach.Resolve): Likewise.
9335 2004-10-05 John Luke <john.luke@gmail.com>
9337 * cs-parser.jay: add location to error CS0175
9339 2004-10-04 Miguel de Icaza <miguel@ximian.com>
9341 * ecore.cs (Expression.Constantity): Add support for turning null
9344 * const.cs (Const.Define): Allow constants to be reference types
9345 as long as the value is Null.
9347 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
9349 * namespace.cs (NamespaceEntry.Using): No matter which warning
9350 level is set, check if this namespace name has already been added.
9352 2004-10-03 Ben Maurer <bmaurer@ximian.com>
9354 * expression.cs: reftype [!=]= null should always use br[true,false].
9357 2004-10-03 Marek Safar <marek.safar@seznam.cz>
9360 * attribute.cs: Enum conversion moved to
9361 GetAttributeArgumentExpression to be applied to the all
9364 2004-10-01 Raja R Harinath <rharinath@novell.com>
9366 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
9367 * class.c (TypeContainer.DefineType): Flag error if
9368 base types aren't accessible due to access permissions.
9369 * decl.cs (DeclSpace.ResolveType): Move logic to
9370 Expression.ResolveAsTypeTerminal.
9371 (DeclSpace.ResolveTypeExpr): Thin layer over
9372 Expression.ResolveAsTypeTerminal.
9373 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
9374 Refactor code into NestedAccess. Use it.
9375 (DeclSpace.NestedAccess): New.
9376 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
9377 argument to silence errors. Check access permissions.
9378 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
9379 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
9380 (Cast.DoResolve): Likewise.
9381 (New.DoResolve): Likewise.
9382 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
9383 (TypeOf.DoResolve): Likewise.
9385 * expression.cs (Invocation.BetterConversion): Return the Type of
9386 the better conversion. Implement section 14.4.2.3 more faithfully.
9387 (Invocation.BetterFunction): Make boolean. Make correspondence to
9388 section 14.4.2.2 explicit.
9389 (Invocation.OverloadResolve): Update.
9390 (Invocation): Remove is_base field.
9391 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
9392 (Invocation.Emit): Likewise.
9394 2004-09-24 Marek Safar <marek.safar@seznam.cz>
9396 * cs-parser.jay: Reverted 642 warning fix.
9398 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9401 * decl.cs (FindMemberWithSameName): Indexer can have more than
9404 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9406 * expression.cs (LocalVariableReference.DoResolveLValue):
9407 Do not report warning 219 for out values.
9408 (EmptyExpression.Null): New member to avoid extra allocations.
9410 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9412 * cs-parser.jay: Fix wrong warning 642 report.
9414 * cs-tokenizer.cs (CheckNextToken): New helper;
9415 Inspect next character if is same as expected.
9417 2004-09-23 Martin Baulig <martin@ximian.com>
9419 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9420 (Convert.ImplicitReferenceConversionExists): Likewise.
9422 2004-11-09 Raja R Harinath <rharinath@novell.com>
9424 * Makefile (DISTFILES): Comment out a few missing files.
9426 2004-10-29 Raja R Harinath <rharinath@novell.com>
9428 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
9429 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
9430 (gmcs.exe): Invoke bootstrap-libs.
9431 (clean-local): Clean the net_2_0_bootstrap profile too.
9432 (PROGRAM_INSTALL_DIR): New.
9433 (install-local): Use it.
9435 2004-10-13 Martin Baulig <martin@ximian.com>
9437 * generic.cs (TypeManager.InflatedConstraints): New nested class.
9438 (TypeParameter.DefineType): If we're a method type parameter and
9439 that method is overriding something, "inflate" its constraints.
9441 2004-10-12 Martin Baulig <martin@ximian.com>
9443 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
9444 and have type arguments, create and resolve a ConstructedType.
9446 2004-10-12 Martin Baulig <martin@ximian.com>
9448 * decl.cs (MemberCache.FindMemberToOverride): Use
9449 TypeManager.IsEqual() to compare the parameters and Type.Equals()
9450 to compare the invocationType.
9452 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
9453 When comparing two type parameters, only do the signature-only
9454 comparision for method type parameters.
9456 2004-10-11 Martin Baulig <martin@ximian.com>
9458 * report.cs: Don't make --fatal abort on warnings, we have
9459 -warnaserror for that.
9461 2004-10-11 Martin Baulig <martin@ximian.com>
9464 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
9465 (TypeManager.IsEqual): Call ourself recursively instead of using
9468 2004-10-11 Martin Baulig <martin@ximian.com>
9470 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
9471 on our own type parameters, not on the ones we inherit from a containing
9474 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
9477 * generic.cs (TypeParameter.Define): We may only be called once.
9479 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
9480 instead of TypeManager.IsEqual().
9482 2004-09-28 Martin Baulig <martin@ximian.com>
9485 (GenericConstraints.EffectiveBaseClass): New public property.
9486 (TypeParameter.GenericConstraints): New public property.
9487 (ConstructedType.CheckConstraints): Improved.
9489 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
9490 (Convert.TypeParameterConversion): New private method; use this in
9491 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
9492 for all conversions related to type parameters.
9494 2004-09-24 Martin Baulig <martin@ximian.com>
9496 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
9497 type parameter conversions for type parameters which are known to
9500 2004-09-24 Martin Baulig <martin@ximian.com>
9502 * generic.cs (GenericConstraints): Added `IsReferenceType' and
9503 `IsValueType' properties.
9505 * support.cs (ReflectionConstraints): Use
9506 Type.GetGenericParameterConstraints() instead of the old hack.
9508 2004-09-24 Martin Baulig <martin@ximian.com>
9510 * generic.cs (GenericConstraints): Moved here and made it an
9513 * support.cs (GenericConstraints): Moved to generic.cs.
9515 2004-09-24 Martin Baulig <martin@ximian.com>
9518 (ReflectionConstraints): Un-nested this class and made it public.
9521 (TypeManager.GetTypeParameterConstraints): New public method.
9522 (TypeManager.HasConstructorConstraint): Use the attributes.
9524 2004-09-24 Martin Baulig <martin@ximian.com>
9526 * support.cs (GenericConstraints): Replaced `HasConstructor',
9527 `IsReferenceType' and `IsValueType' with `Attributes'.
9528 (ReflectionParameters.ReflectionConstraints): Removed the Create()
9529 method and made the .ctor public.
9531 * generic.cs (Constraints.Attributes): New public property.
9532 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
9533 `IsReferenceType' -> `HasReferenceTypeConstraint' and
9534 `IsValueType' -> `HasValueTypeConstraint'.
9536 2004-09-23 Martin Baulig <martin@ximian.com>
9538 * generic.cs (Constraints): Reflect latest runtime changes.
9540 2004-09-23 Martin Baulig <martin@ximian.com>
9542 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9543 (Convert.ImplicitReferenceConversionExists): Likewise.
9545 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9547 * class.cs (Operator.Define): Add error 448 and 559 report.
9549 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9551 * class.cs (MemberBase.IsTypePermitted): New protected
9552 method for checking error CS0610.
9554 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9556 * class.cs (TypeContainer.HasExplicitLayout): New property
9557 Returns whether container has StructLayout attribute set Explicit.
9558 (FieldMember): New abstract class for consts and fields.
9559 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
9560 (Field): Reuse FieldMember.
9562 * const.cs (Const): Reuse FieldMember.
9564 * rootcontext.cs: EmitConstants call moved to class.
9566 2004-09-22 Martin Baulig <martin@ximian.com>
9568 Marek and me just fixed one of our oldest bugs: #28562 :-)
9570 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9572 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9573 we're an EnumConstant, just return that.
9574 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9575 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9576 to get the value which'll actually be written into the attribute.
9577 However, we have to use GetValue() to access the attribute's value
9580 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9582 * constant.cs (Constant.IsNegative): New abstract property
9585 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9586 (StackAlloc.DoResolve): Reused IsNegative.
9588 2004-09-22 Martin Baulig <martin@ximian.com>
9590 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9591 public method; like LookupTypeContainer, but also works for
9594 * report.cs (Report.SymbolRelatedToPreviousError): Use
9595 TypeManager.LookupGenericTypeContainer().
9597 2004-09-22 Martin Baulig <martin@ximian.com>
9599 Thanks to Peter Sestoft for this bug report.
9601 * expression.cs (Conditional): If both the `trueExpr' and the
9602 `falseExpr' is a NullLiteral, return a NullLiteral.
9604 2004-09-22 Martin Baulig <martin@ximian.com>
9606 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9607 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9608 for the "get_Current" call.
9610 2004-09-21 Martin Baulig <martin@ximian.com>
9612 * convert.cs (Convert.ImplicitReferenceConversion): When
9613 converting to an interface type, first check whether we're
9614 converting from a reference type.
9616 2004-09-14 Martin Baulig <martin@ximian.com>
9618 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9620 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9623 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9624 called and is obsolete then this member suppress message
9625 when call is inside next [Obsolete] method or type.
9627 * expression.cs: Use TestObsoleteMethodUsage member.
9629 2004-09-14 Martin Baulig <martin@ximian.com>
9631 * genericparser.cs: Removed.
9633 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9635 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9637 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9639 * attribute.cs (Attribute.Resolve): Add error 653 report.
9641 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9643 (Method.ApplyAttributeBuilder): Add error 685 report.
9644 (Operator.Define): Add error 564 report.
9646 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9648 * expression.cs (Invocation.DoResolve): Add error
9651 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9654 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9656 * class.cs (ConstructorInitializer.Resolve):
9657 Wrong error number (515->516).
9659 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9661 * class.cs (Indexer.Define): Add error 631 report.
9663 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9665 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9667 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9669 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9671 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9673 * cs-parser.jay: Added error CS0241 report.
9675 2004-09-10 Raja R Harinath <rharinath@novell.com>
9677 * cs-parser.jay (fixed_statement): Introduce a scope for the
9678 declaration in the 'fixed' statement.
9680 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9682 * cs-parser.jay: Added CS0230 error report.
9684 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9686 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9688 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9690 * expression.cs (Argument.Resolve): Added error CS0192 and
9693 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9695 C# 2.0 #pragma warning feature
9697 * cs-tokenizer.cs (PreProcessPragma): New method;
9698 Handles #pragma directive.
9700 * report.cs (WarningRegions): New class; Support
9701 class for #pragma warning directive. It tests whether
9702 warning is enabled for a given line.
9704 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9706 * const.cs: Add more descriptive error report, tahnks to
9709 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9711 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9713 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9715 * expression.cs: Apply patch from Ben: Remove dead code from
9716 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9717 as that code just threw an exception anwyays.
9719 * const.cs: Remove the call to the turnintoconstant, for details
9722 * literal.cs: The type of the null-literal is the null type; So
9723 we use a placeholder type (literal.cs:System.Null, defined here)
9726 * expression.cs (Conditional.DoResolve): Remove some old code that
9727 is no longer needed, conversions have been fixed.
9729 (ArrayCreationExpression.DoResolve): Return false if we fail to
9730 resolve the inner expression.
9732 2004-09-07 Raja R Harinath <rharinath@novell.com>
9735 * cs-parser.jay (delegate_declaration): Record a delegate
9736 declaration as a type declaration.
9737 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9739 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9741 * parameter.cs: Do not crash if the type can not be resolved.
9743 * expression.cs: Report errors with unsafe pointers, fixes #64896
9745 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9747 * expression.cs: Pointer arith always needs to do a conv.i
9748 if the operand is a long. fix 65320
9750 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9752 Fixed cs0619-37.cs, cs0619-38.cs
9754 * enum.cs (GetObsoleteAttribute): Removed.
9756 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9757 on Enum member is double staged. The first is tested member
9760 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9762 Fixed #56986, #63631, #65231
9764 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9765 adds member to name container.
9766 (TypeContainer.AddToTypeContainer): New method, adds type to
9768 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9769 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9770 AddOperator): Simplified by reusing AddToMemberContainer.
9771 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9773 (Method.CheckForDuplications): Fixed implementation to test all
9775 (MemberBase): Detection whether member is explicit interface
9776 implementation is now in constructor.
9777 (MemberBase.UpdateMemberName): Handles IndexerName.
9778 (Accessor): Changed to keep also location information.
9779 (AbstractPropertyEventMethod): Is derived from MemberCore.
9780 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9781 will be emited or not.
9782 (PropertyBase.AreAccessorsDuplicateImplementation):
9783 Tests whether accessors are not in collision with some method.
9784 (Operator): Is derived from MethodCore to simplify common
9787 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9789 (DeclSpace.AddToContainer): Adds the member to defined_names
9790 table. It tests for duplications and enclosing name conflicts.
9792 * enum.cs (EnumMember): Clean up to reuse the base structures
9794 2004-09-03 Martin Baulig <martin@ximian.com>
9796 Merged latest changes into gmcs. Please keep this comment in
9797 here, it makes it easier for me to see what changed in MCS since
9798 the last time I merged.
9800 2004-09-03 Martin Baulig <martin@ximian.com>
9802 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9803 into TypeContainer, to make partial classes work again.
9805 2004-09-03 Martin Baulig <martin@ximian.com>
9807 * rootcontext.cs (RootContext.V2): Removed.
9809 2004-03-23 Martin Baulig <martin@ximian.com>
9811 * expression.cs (Invocation.OverloadResolve): Added `bool
9812 may_fail' argument and use it instead of the Location.IsNull() hack.
9814 2004-09-09 Martin Baulig <martin@ximian.com>
9816 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9818 2004-09-09 Martin Baulig <martin@ximian.com>
9820 * generic.cs (TypeParameter.DefineType): Added support for
9821 explicit interface methods.
9823 2004-09-09 Martin Baulig <martin@ximian.com>
9825 * README.Changes: New document. Started to list important changes
9826 between MCS and GMCS here.
9828 2004-09-08 Martin Baulig <martin@ximian.com>
9831 (TypeContainer.CheckRecursiveDefinition): New protected method.
9832 (TypeContainer.DefineType): Move the CS0146 check into
9833 CheckRecursiveDefinition().
9835 2004-09-06 Martin Baulig <martin@ximian.com>
9837 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9838 types for the constructor constraint.
9840 2004-09-03 Martin Baulig <martin@ximian.com>
9842 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9843 into TypeContainer, to make partial classes work again.
9845 2004-09-03 Martin Baulig <martin@ximian.com>
9847 * rootcontext.cs (RootContext.V2): Removed.
9849 2004-03-23 Martin Baulig <martin@ximian.com>
9851 * expression.cs (Invocation.OverloadResolve): Added `bool
9852 may_fail' argument and use it instead of the Location.IsNull() hack.
9854 2004-09-03 Martin Baulig <martin@ximian.com>
9856 Merged latest changes into gmcs. Please keep this comment in
9857 here, it makes it easier for me to see what changed in MCS since
9858 the last time I merged.
9860 2004-09-03 Raja R Harinath <rharinath@novell.com>
9863 * expression.cs (BetterConversion): Don't allow either conversion
9864 to be null. Remove redundant implicit conversion test when 'q ==
9865 null' -- when this function is invoked, we already know that the
9866 implicit conversion exists.
9867 (BetterFunction): Assume that 'best' is non-null. Remove
9868 redundant reimplementation of IsApplicable when 'best' is null.
9869 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9870 number of arguments.
9871 (IsAncestralType): Extract from OverloadResolve.
9872 (OverloadResolve): Make robust to the MethodGroupExpr being
9873 unsorted. Implement all the logic of Section 14.5.5.1, and
9874 support overloading of methods from multiple applicable types.
9875 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9877 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9878 (RealError, Warning): Append type of report to related symbol.
9880 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9882 * enum.cs: Fixed CLS-Compliance checks for enum members.
9883 Error tests cs3008-8.cs, cs3014-8.cs
9885 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9887 Fixed bug #62342, #63102
9888 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9889 like ImplementMethod.
9891 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9893 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9896 2004-09-02 Martin Baulig <martin@ximian.com>
9898 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9899 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9902 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9904 C# 2.0 Static classes implemented
9906 * class.cs (TypeContainer): instance_constructors,
9907 initialized_fields, initialized_static_fields,
9908 default_constructor, base_inteface_types are protected to be
9909 accessible from StaticClass.
9910 (TypeContainer.DefineDefaultConstructor): New virtual method
9911 for custom default constructor generating
9912 (StaticClass): New class to handle "Static classes" feature.
9914 * cs-parser.jay: Handle static keyword on class like instance
9917 * driver.cs: Added "/langversion" command line switch with two
9918 options (iso-1, default).
9920 2004-08-31 Marek Safar <marek.safar@seznam.cz>
9922 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
9924 2004-08-31 Miguel de Icaza <miguel@ximian.com>
9926 * delegate.cs: Style.
9928 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
9930 * delegate.cs: Add seperate instance expr field for miguel.
9932 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9934 * PointerArithmetic (Resolve): make sure we are not doing
9935 pointer arith on void*. Also, make sure we are resolved
9936 by not setting eclass until resolve.
9938 All callers: Make sure that PointerArithmetic gets resolved.
9940 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9942 * ArrayCreation (LookupType): If the type does not resolve
9943 to an array, give an error.
9945 2004-08-27 Marek Safar <marek.safar@seznam.cz>
9947 * statement.cs (Try.Resolve): Fixed bug #64222
9949 2004-08-27 Martin Baulig <martin@ximian.com>
9952 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9955 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9957 * ecore.cs (Constantify): Get underlying type via
9958 System.Enum.GetUnderlyingType to avoid StackOverflow on the
9959 Windows in special cases.
9961 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9963 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
9964 for obtaining also private methods.
9965 (GetRemoveMethod): Used GetRemoveMethod (true)
9966 for obtaining also private methods.
9968 2004-09-02 Martin Baulig <martin@ximian.com>
9970 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9971 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9974 2004-08-27 Martin Baulig <martin@ximian.com>
9977 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9980 2004-08-25 Martin Baulig <martin@ximian.com>
9982 * support.cs (ReflectionParameters..ctor): If this is a generic
9983 method, retrieve and store its type parameters.
9984 (InternalParameters..ctor): Added `TypeParameter[]' argument.
9985 (ReflectionParameters.GenericConstraints): The argument specifies
9986 the type parameter, not the method parameter.
9987 (InternalParameters.GenericConstraints): Likewise.
9989 * generic.cs (TypeParameter.DefineType): Correctly handle
9990 constraints wrt. generic methods in interfaces and their
9993 2004-08-24 Martin Baulig <martin@ximian.com>
9995 * generic.cs (TypeParameter.IsSubclassOf): New public method.
9996 (Constraints.IsSubclassOf): New internal method.
9998 * typemanager.cs (TypeManager.FindMembers): Added special support
9999 for GenericTypeParameterBuilder's.
10000 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
10003 2004-08-24 Martin Baulig <martin@ximian.com>
10006 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
10007 this for accessibility checks.
10008 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
10009 IsNestedFamilyAccessible.
10010 (TypeManager.IsSubclassOf): New method, do what the name actually
10013 2004-08-24 Martin Baulig <martin@ximian.com>
10015 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
10016 as a SimpleName, include the generic arity.
10018 2004-08-24 Martin Baulig <martin@ximian.com>
10020 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
10021 MethodAttributes.HideBySig for operators.
10023 2004-08-23 Martin Baulig <martin@ximian.com>
10025 Back to the old error reporting system :-)
10027 * report.cs (Message): Removed.
10028 (Report.MessageData, ErrorData, WarningData): Removed.
10029 (Report.Error, Warning): Back to the old system.
10031 2004-08-23 Martin Baulig <martin@ximian.com>
10033 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
10035 * class.cs (TypeContainer.ParentContainer): New public virtual
10036 method; replaces the explicit interface implementation.
10037 (ClassPart.ParentContainer): Override.
10039 2004-08-23 Martin Baulig <martin@ximian.com>
10041 * statement.cs (Switch): Added support for constant switches; see
10042 #59428 or test-285.cs.
10044 2004-08-22 Marek Safar <marek.safar@seznam.cz>
10047 * statement.cs (GetEnumeratorFilter): Removed useless
10048 logic because C# specs is strict. GetEnumerator must be
10051 2004-08-22 Martin Baulig <martin@ximian.com>
10053 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
10054 a switch and may break, reset the barrier. Fixes #59867.
10056 2004-08-22 Marek Safar <marek.safar@seznam.cz>
10058 CLS-Compliance speed up (~5% for corlib)
10060 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
10061 New method. Tests container for CLS-Compliant names
10063 * class.cs (TypeContainer.VerifyClsName): New method.
10064 Checks whether container name is CLS Compliant.
10065 (Constructor): Implements IMethodData.
10067 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
10068 low-case table for CLS Compliance test.
10069 (MemberCache.VerifyClsParameterConflict): New method.
10070 Checks method parameters for CS3006 error.
10072 * enum.cs (EnumMember): Is derived from MemberCore.
10073 (Enum.VerifyClsName): Optimized for better performance.
10075 2004-08-06 Marek Safar <marek.safar@seznam.cz>
10077 * report.cs: Renamed Error_T to Error and changed all
10080 2004-08-06 Marek Safar <marek.safar@seznam.cz>
10082 * class.cs (TypeContainer.IndexerArrayList): New inner class
10083 container for indexers.
10084 (TypeContainer.DefaultIndexerName): New constant for default
10085 indexer name. Replaced all "Item" with this constant.
10086 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
10088 * typemanager.cs (TypeManager.default_member_ctor): Cache here
10089 DefaultMemberAttribute constructor.
10091 2004-08-05 Martin Baulig <martin@ximian.com>
10093 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
10096 2004-08-05 Marek Safar <marek.safar@seznam.cz>
10098 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
10099 multi platforms problem.
10101 * compiler.csproj: Included shared files.
10103 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10105 Fix bug 60333, 55971 in the more general way
10106 * attribute.cs (Attribute.GetAttributeArgumentExpression):
10107 Added arg_type argument for constant conversion.
10108 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
10110 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10113 * class.cs (TypeContainer ): New inner classes MethodArrayList,
10114 OperatorArrayList, MethodCoreArrayList for typecontainer
10115 containers. Changed class member types to these new types.
10116 (MethodArrayList.DefineMembers): Added test for CS0659.
10118 2004-08-04 Miguel de Icaza <miguel@ximian.com>
10120 * cfold.cs: Synchronize the folding with the code in expression.cs
10121 Binary.DoNumericPromotions for uint operands.
10123 * attribute.cs: Revert patch from Raja, it introduced a regression
10124 while building Blam-1.2.1 (hard to isolate a test case).
10126 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10130 (TypeContainer.Define): Renamed to DefineContainerMembers because of
10132 (MethodCore.parent_method): New member. The method we're overriding
10133 if this is an override method.
10134 (MethodCore.CheckBase): Moved from Method class and made common.
10135 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
10137 (MethodCore.CheckForDuplications): New abstract method. For custom
10138 member duplication search in a container
10139 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
10140 method and its return type.
10141 (Event.conflict_symbol): New member. Symbol with same name in the
10145 (MemberCache.FindMemberWithSameName): New method. The method
10146 is looking for conflict with inherited symbols.
10148 2004-08-04 Martin Baulig <martin@ximian.com>
10150 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10152 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10154 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10156 * report.cs (Message): New enum for better error, warning reference in
10158 (MessageData): New inner abstract class. It generally handles printing of
10159 error and warning messages.
10160 Removed unused Error, Warning, Message methods.
10162 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10164 Fix for cs0592-8.cs test
10166 (Attributable.ValidAttributeTargets): Made public.
10167 (Attribute.ExplicitTarget): New member for explicit target value.
10168 (Attribute.CheckTargets): Now we translate explicit attribute
10169 target to Target here.
10171 2004-08-03 Ben Maurer <bmaurer@ximian.com>
10173 * ecore.cs (MethodGroupExpr): new IsBase property.
10175 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
10177 * delegate.cs (DelegateCreation): store a MethodGroupExpr
10178 rather than an instance expr.
10180 (DelegateCreation.Emit): Use the method group rather than
10181 the instance expression. Also, if you have base.Foo as the
10182 method for a delegate, make sure to emit ldftn, not ldftnvirt.
10184 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
10186 (NewDelegate.DoResolve): Only check for the existance of Invoke
10187 if the method is going to be needed. Use MethodGroupExpr.
10189 (NewDelegate.Emit): Remove, DelegateCreation implements this.
10191 * expression.cs: For pointer arith., make sure to use
10192 the size of the type, not the size of the pointer to
10195 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10198 * class.cs (Class): Added error CS0502 test.
10200 2004-08-03 John Luke <jluke@cfl.rr.com>
10201 Raja R Harinath <rharinath@novell.com>
10204 * attribute.cs (Attribute.complained_before): New flag.
10205 (Attribute.ResolveType, Attribute.Resolve),
10206 (Attribute.DefinePInvokeMethod): Set it.
10207 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
10209 2004-08-03 Martin Baulig <martin@ximian.com>
10211 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10212 use a user-defined operator; we still need to do numeric
10213 promotions in case one argument is a builtin type and the other
10214 one has an implicit conversion to that type. Fixes #62322.
10216 2004-08-18 Martin Baulig <martin@ximian.com>
10218 * class.cs (Method.Define): Use the correct method name when
10219 creating the MethodBuilder for a generic method.
10221 2004-08-17 Martin Baulig <martin@ximian.com>
10223 * generic.cs (Constraints): Support type parameter constraints.
10225 2004-08-16 Martin Baulig <martin@ximian.com>
10227 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
10228 (Token.GENERIC_DIMENSION): New token; this is returned if we
10229 encounter an unbound generic type in a typeof() expression.
10231 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
10232 this token is only generated while parsing a typeof() expression.
10233 (typeof_expression): Removed the old unbound_type hack.
10235 * generic.cs (TypeArguments.IsUnbound): New public property.
10237 * decl.cs (MemberName): Added support for unbound types.
10239 2004-08-14 Martin Baulig <martin@ximian.com>
10242 (TypeManager.IsEqualGenericInstance): New static method.
10243 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
10244 just used to check accessibility, so follow the rules of 26.1.6.
10246 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
10247 ConstructedType instead of a TypeExpression if we have type arguments.
10249 * cs-parser.jay (typeof_expression): Support unbound generic types.
10251 * ecore.cs (UnboundTypeExpression): New public class.
10253 2004-08-12 Martin Baulig <martin@ximian.com>
10255 * typemanager.cs (TypeManager.IsNestedChildOf): Use
10256 TypeManager.IsEqual() rather than `=='.
10258 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
10259 generic instances as well.
10261 2004-08-12 Martin Baulig <martin@ximian.com>
10263 * expression.cs (Invocation.InferType): We can only infer method
10264 type parameters. Fixes #62647.
10266 2004-08-11 Martin Baulig <martin@ximian.com>
10268 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
10269 before resolving the base classes.
10271 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10273 * Makefile: install .mdb file too.
10275 2004-08-05 Martin Baulig <martin@ximian.com>
10277 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
10278 initializer, the current type is just the TypeBuilder, not the
10279 instantiated generic type.
10280 (FieldExpr.IsFieldInitializer): New public property.
10282 2004-08-04 Martin Baulig <martin@ximian.com>
10284 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10286 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10288 2004-08-03 Martin Baulig <martin@ximian.com>
10290 * class.cs (MethodData.Define): If we're an explicit
10291 implementation, remove the generic arity from the type name.
10293 2004-08-03 Martin Baulig <martin@ximian.com>
10295 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10296 use a user-defined operator; we still need to do numeric
10297 promotions in case one argument is a builtin type and the other
10298 one has an implicit conversion to that type. Fixes #62322.
10300 2004-08-02 Martin Baulig <martin@ximian.com>
10302 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
10303 `TypeExpr[]' array.
10304 (TypeContainer.GetClassBases): Return the unexpanded list of
10305 interfaces; we expand them later.
10306 (TypeContainer.DefineType): After creating the TypeBuilder, call
10307 TypeManager.ExpandInterfaces() to get an expanded and resolved
10308 list of interfaces.
10310 * ecore.cs (TypeExpr.GetInterfaces): Removed
10312 * generics.cs (Constraints.InterfaceConstraints): Remove.
10313 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
10314 register the interface constraints.
10317 (TypeManager.AddUserType): Removed the `ifaces' argument.
10318 (TypeManager.AddTypeParameter): Likewise.
10319 (TypeManager.AddUserInterface): Removed, was unused.
10320 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
10321 `TypeExpr[]' array for the interfaces.
10322 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
10323 has been defined, returns a list of the resolved interfaces types.
10324 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
10325 (TypeManager.GetExplicitInterfaces): Likewise.
10327 2004-08-02 Martin Baulig <martin@ximian.com>
10329 * expression.cs (Invocation.EmitCall): If we're invoking a method
10330 on a type parameter, use the new `Constrained' prefix opcode.
10332 2004-08-02 Martin Baulig <martin@ximian.com>
10334 * statement.cs (LocalInfo.Flags): Added `IsThis'.
10335 (LocalInfo.IsThis): New public property.
10336 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
10338 2004-08-01 Martin Baulig <martin@ximian.com>
10340 * class.cs (TypeContainer.GetClassBases): Don't set the default
10341 here since we may get called from GetPartialBases().
10342 (TypeContainer.DefineType): If GetClassBases() didn't return a
10343 parent, use the default one.
10345 2004-07-30 Martin Baulig <martin@ximian.com>
10347 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
10349 * class.cs (SourceMethod): New public class, derive from the
10350 symbol writer's ISourceMethod.
10351 (Method): Use the new symbol writer API.
10353 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
10354 as argument and use the new symbol writer.
10357 (SourceFile): Implement the symbol writer's ISourceFile.
10358 (Location.SymbolDocument): Removed.
10359 (Location.SourceFile): New public property.
10361 * symbolwriter.cs: Use the new symbol writer API.
10363 2004-07-30 Raja R Harinath <rharinath@novell.com>
10365 * Makefile (install-local): Remove. Functionality moved to
10368 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
10370 * Makefile: Install mcs.exe.config file together with mcs.exe.
10371 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
10372 correct runtime version.
10374 2004-07-25 Martin Baulig <martin@ximian.com>
10377 (TypeContainer.RegisterOrder): Removed, this was unused.
10378 (TypeContainer, interface_order): Removed.
10379 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
10380 TypeContainer as argument since we can also be called with a
10381 `PartialContainer' for a partial class/struct/interface.
10382 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
10383 of checking whether we're an `Interface' - we could be a
10384 `PartialContainer'.
10385 (PartialContainer.Register): Override; call
10386 AddClass()/AddStruct()/AddInterface() on our parent.
10388 * cs-parser.jay (interface_member_declaration): Add things to the
10389 `current_container', not the `current_class'.
10391 * rootcontext.cs (RegisterOrder): The overloaded version which
10392 takes an `Interface' was unused, removed.
10394 * typemanager.cs (TypeManager.LookupInterface): Return a
10395 `TypeContainer', not an `Interface'.
10396 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
10397 contain a `PartialContainer' for an interface, so check it's
10398 `Kind' to figure out what it is.
10400 2004-07-25 Martin Baulig <martin@ximian.com>
10402 * class.cs (Class.DefaultTypeAttributes): New public constant.
10403 (Struct.DefaultTypeAttributes): Likewise.
10404 (Interface.DefaultTypeAttributes): Likewise.
10405 (PartialContainer.TypeAttr): Override this and add the
10406 DefaultTypeAttributes.
10408 2004-07-25 Martin Baulig <martin@ximian.com>
10410 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
10411 we can just use the `Parent' field instead.
10413 2004-07-25 Martin Baulig <martin@ximian.com>
10415 * class.cs (TypeContainer.Emit): Renamed to EmitType().
10417 2004-07-25 Martin Baulig <martin@ximian.com>
10419 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
10420 our parts before defining any methods.
10421 (TypeContainer.VerifyImplements): Make this virtual.
10422 (ClassPart.VerifyImplements): Override and call VerifyImplements()
10423 on our PartialContainer.
10425 2004-07-25 Martin Baulig <martin@ximian.com>
10427 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
10429 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
10430 argument, we can just use the `Parent' field instead.
10433 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
10434 (MemberBase.DoDefine): Likewise.
10436 2004-07-24 Martin Baulig <martin@ximian.com>
10438 * decl.cs (MemberCore.Parent): New public field.
10439 (DeclSpace.Parent): Moved to MemberCore.
10441 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
10442 (MemberBase.ctor): Added TypeContainer argument, pass it to our
10444 (FieldBase, Field, Operator): Likewise.
10445 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
10446 (EventField, Event): Likewise.
10448 2004-07-23 Martin Baulig <martin@ximian.com>
10450 * class.cs (PartialContainer): New public class.
10451 (ClassPart): New public class.
10452 (TypeContainer): Added support for partial classes.
10453 (TypeContainer.GetClassBases): Splitted some of the functionality
10454 out into GetNormalBases() and GetPartialBases().
10456 * cs-tokenizer.cs (Token.PARTIAL): New token.
10457 (Tokenizer.consume_identifier): Added some hacks to recognize
10458 `partial', but only if it's immediately followed by `class',
10459 `struct' or `interface'.
10461 * cs-parser.jay: Added support for partial clases.
10463 2004-07-23 Martin Baulig <martin@ximian.com>
10465 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
10466 a `DeclSpace' and also made it readonly.
10467 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
10468 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
10469 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
10471 * cs-parser.jay: Pass the `current_class', not the
10472 `current_container' (at the moment, this is still the same thing)
10473 to a new Method, Property, Event, Indexer or Constructor.
10475 2004-07-23 Martin Baulig <martin@ximian.com>
10477 * cs-parser.jay (CSharpParser): Added a new `current_class' field
10478 and removed the `current_interface' one.
10479 (struct_declaration, class_declaration, interface_declaration):
10480 Set `current_class' to the newly created class/struct/interface;
10481 set their `Bases' and call Register() before parsing their body.
10483 2004-07-23 Martin Baulig <martin@ximian.com>
10485 * class.cs (Kind): New public enum.
10486 (TypeContainer): Made this class abstract.
10487 (TypeContainer.Kind): New public readonly field.
10488 (TypeContainer.CheckDef): New public method; moved here from
10490 (TypeContainer.Register): New public abstract method.
10491 (TypeContainer.GetPendingImplementations): New public abstract
10493 (TypeContainer.GetClassBases): Removed the `is_class' and
10494 `is_iface' parameters.
10495 (TypeContainer.DefineNestedTypes): Formerly known as
10497 (ClassOrStruct): Made this class abstract.
10499 * tree.cs (RootTypes): New public type.
10501 2004-07-20 Martin Baulig <martin@ximian.com>
10503 * tree.cs (Tree.RecordNamespace): Removed.
10504 (Tree.Namespaces): Removed.
10506 * rootcontext.cs (RootContext.IsNamespace): Removed.
10508 * cs-parser.jay (namespace_declaration): Just create a new
10509 NamespaceEntry here.
10511 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
10513 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
10514 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
10515 entry to make sure it runs in the correct runtime version.
10517 2004-07-18 Martin Baulig <martin@ximian.com>
10519 * generic.cs (ConstructedType.CheckConstraints): Improved
10520 constraints checking.
10522 2004-07-18 Martin Baulig <martin@ximian.com>
10524 * expression.cs (Invocation.BetterMethod): Call
10525 TypeManager.TypeToCoreType() on all types and removed my previous
10526 hack; we're already doig the right thing here.
10528 2004-07-17 Martin Baulig <martin@ximian.com>
10530 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
10532 2004-07-16 Martin Baulig <martin@ximian.com>
10534 * iterators.cs: Added generics support.
10536 2004-07-16 Martin Baulig <martin@ximian.com>
10538 * iterators.cs: Rewrote this. We're now using one single Proxy
10539 class for both the IEnumerable and the IEnumerator interface and
10540 `Iterator' derives from Class so we can use the high-level API.
10542 * class.cs (TypeContainer.AddIterator): New method.
10543 (TypeContainer.DoDefineType): New protected virtual method, which
10544 is called from DefineType().
10545 (TypeContainer.DoDefineMembers): Call DefineType() and
10546 DefineMembers() on all our iterators.
10547 (TypeContainer.Emit): Call Emit() on all our iterators.
10548 (TypeContainer.CloseType): Call CloseType() on all our iterators.
10550 * codegen.cs (EmitContext.CurrentIterator): New public field.
10552 2004-07-15 Martin Baulig <martin@ximian.com>
10555 (TypeManager.not_supported_exception_type): New type.
10557 2004-07-14 Martin Baulig <martin@ximian.com>
10560 (TypeManager.generic_ienumerable_type): New type.
10561 (TypeManager.generic_ienumerator_type): New type.
10564 (RootContext.interfaces_first_stage): Added
10565 "System.Collections.Generic.IEnumerator`1" and
10566 "System.Collections.Generic.IEnumerable`1".
10568 2004-07-14 Martin Baulig <martin@ximian.com>
10570 * iterators.cs: Use real error numbers.
10572 2004-07-14 Martin Baulig <martin@ximian.com>
10574 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10575 requires this to be a System.Collection.IEnumerable and not a
10576 class implementing that interface.
10577 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10579 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10581 * class.cs: Fixed previous fix, it broke some error tests.
10583 2004-07-12 Martin Baulig <martin@ximian.com>
10585 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10588 2004-07-14 Martin Baulig <martin@ximian.com>
10590 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10591 an exclamation mark (!) for the generic arity to reflect the
10592 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10594 2004-07-13 Martin Baulig <martin@ximian.com>
10596 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10597 specifiers being part of a type argument.
10599 2004-07-13 Martin Baulig <martin@ximian.com>
10601 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10602 name for generic types.
10604 2004-07-13 Martin Baulig <martin@ximian.com>
10606 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10609 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10611 * assign.cs (LocalTemporary): Add new argument: is_address,If
10612 `is_address' is true, then the value that we store is the address
10613 to the real value, and not the value itself.
10615 * ecore.cs (PropertyExpr): use the new local temporary
10616 stuff to allow us to handle X.Y += z (where X is a struct)
10618 2004-07-08 Martin Baulig <martin@ximian.com>
10620 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10621 not always return, just like we're doing in Using.Resolve().
10623 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10625 * cs-parser.jay (fixed_statement): flag this as Pinned.
10627 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10629 * typemanager.cs (TypeManager): Removed MakePinned method, this
10630 mechanism is replaced with the .NET 2.x compatible mechanism of
10631 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10633 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10634 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10635 `IsFixed' property which has a different meaning.
10637 2004-07-02 Raja R Harinath <rharinath@novell.com>
10639 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10640 visible from inside a nested class, not just the names of the
10641 immediately enclosing class.
10642 Fix for bug #60730.
10644 2004-06-24 Raja R Harinath <rharinath@novell.com>
10646 * expression.cs (BetterConversion): Remove buggy special-case
10647 handling of "implicit constant expression conversions". At this
10648 point, we already know that the conversion is possible -- we're
10649 only checking to see which is better.
10651 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10653 * cs-parser.jay: Added error CS0210 test.
10655 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10657 * cs-parser.jay: Added error CS0134 test.
10659 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10662 * cs-parser.jay: Added error CS0145 test.
10664 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10666 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10668 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10670 * expression.cs (StackAlloc.Resolve): The argument may not
10671 be a constant; deal with this case.
10673 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10675 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10676 GetIndexerAttributeValue.
10677 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10679 * class.cs (Indexer.Define): Added error tests for CS0415,
10682 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10684 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10687 2004-06-23 Martin Baulig <martin@ximian.com>
10689 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10690 neither return nor throw, reset the barrier as well. Fixes #60457.
10692 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10694 * class.cs : EventAttributes is now set to None by default.
10695 This fixes bug #60459.
10697 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10700 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10701 Don't throw exception but return null (it's sufficient now).
10703 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10705 * typemanager.cs (GetArgumentTypes): Faster implementation.
10707 2004-06-18 Martin Baulig <martin@ximian.com>
10709 * attribute.cs (Attribute.Resolve): Check whether we're an
10710 EmptyCast which a Constant child. Fixes #60333.
10712 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10714 * statement.cs (EmitCollectionForeach): Account for the fact that
10715 not all valuetypes are in areas which we can take the address of.
10716 For these variables, we store to a temporary variable. Also, make
10717 sure that we dont emit a `callvirt' on a valuetype method.
10719 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10721 * expression.cs (StackAlloc.DoReSolve): Added test for
10722 negative parameter (CS0247).
10724 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10727 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10729 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10732 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10735 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10737 Fix bug #58254 & cs1555.cs, cs1556.cs
10738 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10740 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10742 * cs-parser.jay: Added error CS1669 test for indexers.
10744 2004-06-18 Martin Baulig <martin@ximian.com>
10746 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10747 argument. Fixes #60441.
10749 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10750 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10751 The name needs to have the actual name of the method in order
10752 for other tests (such as the one in OverloadResolve for Invoke
10753 on a delegate) to work. As well, it does not really help
10754 error reporting because the method group had multiple methods.
10755 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10756 Make profiling work.
10758 2004-06-13 Martin Baulig <martin@ximian.com>
10760 * cs-parser.jay: Don't allow generic attributes.
10762 2004-06-13 Martin Baulig <martin@ximian.com>
10764 * class.cs (MemberBase.DoDefineBase): New protected method.
10765 (MemberBase.DoDefine): Compute the `flags' in the new
10766 DoDefineBase() which must be called first.
10767 (Method.Define): Call DoDefineBase() first so we have the flags
10768 when defining the generic method.
10770 * cs-parser.jay (interface_method_declaration): Support generic methods.
10772 2004-06-13 Martin Baulig <martin@ximian.com>
10774 * decl.cs (TypeName): Removed.
10775 (MemberName): Removed TypeName and MemberNow; now we just have
10778 * cs-parser.jay: Don't distinguish between type arguments and type
10779 parameters in the grammar and simplified the rules a bit. The
10780 reduce/reduce conflicts are now gone (except the one we inherited
10783 2004-06-11 Martin Baulig <martin@ximian.com>
10785 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10786 call this twice: for params and varargs methods.
10788 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10791 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10793 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10795 * attribute.cs (Attribute.GetValidTargets): Made public.
10798 (AbstractPropertyEventMethod): New class for better code sharing.
10799 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10801 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10803 2004-06-09 Martin Baulig <martin@ximian.com>
10805 * cs-parser.jay: Removed a reduce/reduce conflict.
10807 2004-06-03 Martin Baulig <martin@ximian.com>
10809 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10810 GetSimpleName() and return a SimpleName.
10812 * ecore.cs (SimpleName.Arguments): New public field.
10813 (SimpleName): Added overloaded ctor which takes an additional
10814 TypeArguments argument.
10815 (SimpleName.SimpleNameResolve): Added support for generic methods.
10816 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10817 formerly in MemberAccess.DoResolve(), but we also need it in
10818 SimpleNameResolve().
10820 * expression.cs (MemberAccess.DoResolve): Use the new
10821 MethodGroupExpr.ResolveGeneric().
10823 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10825 * decl.cs: If possible, use lookuptypedirect here. We can only do
10826 this if there is no `.' after the namespace. Avoids using
10827 LookupType, which does lots of slow processing.
10828 (FindNestedType) New method, does what it says :-).
10829 * namespace.cs: use LookupTypeDirect.
10830 * rootcontext.cs: use membercache, if possible.
10831 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10833 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10836 According to the spec,
10838 In a member access of the form E.I, if E is a single identifier,
10839 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10840 field, property, localvariable, or parameter with the same type as
10841 the meaning of E as a type-name (§3.8), then both possible
10842 meanings of E are permitted.
10844 We did not check that E as a simple-name had the same type as E as
10847 This trivial check gives us 5-7% on bootstrap time.
10849 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10851 * expression.cs (Invocation.OverloadResolve): Avoid the
10852 use of hashtables and boxing here by allocating on demand.
10854 2004-05-30 Martin Baulig <martin@ximian.com>
10856 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10857 we're doing a silent lookup. Don't try to lookup nested types in
10858 TypeManager.object_type (thanks to Ben Maurer).
10860 2004-05-30 Martin Baulig <martin@ximian.com>
10862 Committing a patch from Ben Maurer.
10864 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10866 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10868 * convert.cs: add a trivial cache for overload operator resolution.
10870 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10873 (AttributeTester.GetObsoleteAttribute): Returns instance of
10874 ObsoleteAttribute when type is obsolete.
10877 (TypeContainer.VerifyObsoleteAttribute): Override.
10878 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10879 (MethodCode.VerifyObsoleteAttribute): Override.
10880 (MemberBase.VerifyObsoleteAttribute): Override.
10883 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10884 and report proper error.
10887 (Delegate.VerifyObsoleteAttribute): Override.
10890 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10891 and report proper error.
10892 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10895 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10899 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10900 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10901 Added test for ObsoleteAttribute.
10904 (Catch): Derived from Statement.
10906 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10908 * decl.cs: If possible, use lookuptypedirect here. We can only do
10909 this if there is no `.' after the namespace. Avoids using
10910 LookupType, which does lots of slow processing.
10911 (FindNestedType) New method, does what it says :-).
10912 * namespace.cs: use LookupTypeDirect.
10913 * rootcontext.cs: use membercache, if possible.
10914 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10916 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10919 According to the spec,
10921 In a member access of the form E.I, if E is a single identifier,
10922 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10923 field, property, localvariable, or parameter with the same type as
10924 the meaning of E as a type-name (§3.8), then both possible
10925 meanings of E are permitted.
10927 We did not check that E as a simple-name had the same type as E as
10930 This trivial check gives us 5-7% on bootstrap time.
10932 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10934 Fixed bug #59071 & cs0160.cs
10935 * statement.cs (Try.Resolve): Check here whether order of catch
10936 clauses matches their dependencies.
10938 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10941 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
10944 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10946 * expression.cs (Invocation.OverloadResolve): Avoid the
10947 use of hashtables and boxing here by allocating on demand.
10949 2004-05-30 Martin Baulig <martin@ximian.com>
10951 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10952 we're doing a silent lookup. Don't try to lookup nested types in
10953 TypeManager.object_type (thanks to Ben Maurer).
10955 2004-05-30 Martin Baulig <martin@ximian.com>
10957 Committing a patch from Ben Maurer.
10959 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10961 2004-05-29 Martin Baulig <martin@ximian.com>
10963 * class.cs (IMethodData.ShouldIgnore): New method.
10965 * typemanager.cs (TypeManager.MethodFlags): Don't take a
10966 `Location' argument, we don't need it anywhere. Use
10967 `IMethodData.ShouldIgnore ()' instead of
10968 `MethodData.GetMethodFlags ()'.
10969 (TypeManager.AddMethod): Removed.
10970 (TypeManager.AddMethod2): Renamed to AddMethod.
10972 2004-05-29 Martin Baulig <martin@ximian.com>
10974 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
10976 * convert.cs (Convert.ImplicitReferenceConversion): If we're
10977 converting from a class type S to an interface type and we already
10978 have an object on the stack, don't box it again. Fixes #52578.
10980 2004-05-29 Martin Baulig <martin@ximian.com>
10982 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10983 Added support for `params' parameters. Fixes #59267.
10985 2004-05-29 Martin Baulig <martin@ximian.com>
10987 * literal.cs (NullPointer): Provide a private .ctor which sets
10988 `type' to TypeManager.object_type. Fixes #59048.
10990 2004-05-29 Martin Baulig <martin@ximian.com>
10992 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
10993 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
10995 * ecore.cs (EventExpr.instance_expr): Make the field private.
10997 2004-05-26 Marek Safar <marek.safar@seznam.cz>
10999 Fixed bug #50080 & cs0214-2.cs
11000 * expression.cs (Cast.DoResolve): Check unsafe context here.
11002 * statement.cs (Resolve.DoResolve): Likewise.
11004 2004-05-26 Martin Baulig <martin@ximian.com>
11006 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
11008 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
11009 (RootContext.LookupType): Pass down the `silent' flag.
11011 2004-05-25 Martin Baulig <martin@ximian.com>
11014 (MethodGroupExpr.IdenticalTypeName): New public property.
11015 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
11016 expression actually refers to a type.
11018 2004-05-25 Martin Baulig <martin@ximian.com>
11020 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
11021 for #56176 and made it actually work.
11023 2004-05-25 Martin Baulig <martin@ximian.com>
11025 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
11026 (FieldExpr, PropertyExpr): Override and implement
11027 CacheTemporaries. Fixes #52279.
11029 2004-05-25 Miguel de Icaza <miguel@ximian.com>
11031 * location.cs: In the new compiler listing a file twice is a
11032 warning, not an error.
11034 2004-05-24 Martin Baulig <martin@ximian.com>
11036 * enum.cs (Enum.DefineType): For the `BaseType' to be a
11037 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
11039 2004-05-24 Martin Baulig <martin@ximian.com>
11041 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
11042 walking the `using' list. Fixes #53921.
11044 2004-05-24 Martin Baulig <martin@ximian.com>
11046 * const.cs (Const.LookupConstantValue): Added support for
11047 EmptyCast's; fixes #55251.
11049 2004-05-24 Martin Baulig <martin@ximian.com>
11051 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
11052 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
11053 which does the CS0135 check. The reason is that we first need to
11054 check whether the variable actually exists.
11056 2004-05-24 Martin Baulig <martin@ximian.com>
11058 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
11059 than RootContext.LookupType() to find the explicit interface
11060 type. Fixes #58584.
11062 2004-05-24 Raja R Harinath <rharinath@novell.com>
11064 * Makefile: Simplify. Use executable.make.
11065 * mcs.exe.sources: New file. List of sources of mcs.exe.
11067 2004-05-24 Anders Carlsson <andersca@gnome.org>
11071 Use the invariant culture when doing String.Compare for CLS case
11074 2004-05-23 Martin Baulig <martin@ximian.com>
11076 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
11077 don't have any dots. Fixes #52622, added cs0246-8.cs.
11079 * namespace.cs (NamespaceEntry.Lookup): Likewise.
11081 2004-05-23 Marek Safar <marek.safar@seznam.cz>
11083 * class.cs (MemberBase.Define): Reuse MemberType member for
11084 resolved type. Other methods can use it too.
11086 2004-05-23 Martin Baulig <martin@ximian.com>
11088 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
11089 the variable also exists in the current block (otherwise, we need
11090 to report a CS0103). Fixes #58670.
11092 2004-05-23 Martin Baulig <martin@ximian.com>
11094 * flowanalysis.cs (Reachability.Reachable): Compute this
11095 on-the-fly rather than storing it as a field.
11097 2004-05-23 Martin Baulig <martin@ximian.com>
11099 * flowanalysis.cs (Reachability.And): Manually compute the
11100 resulting `barrier' from the reachability.
11102 2004-05-23 Marek Safar <marek.safar@seznam.cz>
11105 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
11106 instance of ObsoleteAttribute when symbol is obsolete.
11109 (IMethodData): Extended interface for ObsoleteAttribute support.
11111 2004-05-22 Marek Safar <marek.safar@seznam.cz>
11113 * attribute.cs: Fix bug #55970
11115 2004-05-22 Marek Safar <marek.safar@seznam.cz>
11119 (GetObsoleteAttribute): New method. Creates the instance of
11121 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
11122 ObsoleteAttribute when member is obsolete.
11123 (AttributeTester.Report_ObsoleteMessage): Common method for
11124 Obsolete error/warning reporting.
11127 (TypeContainer.base_classs_type): New member for storing parent type.
11130 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
11131 for this MemberCore.
11133 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11135 * attribute.cs, const.cs: Fix bug #58590
11137 2004-05-21 Martin Baulig <martin@ximian.com>
11139 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
11140 out parameters if the end of the method is unreachable. Fixes
11143 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11145 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
11146 Hari was right, why extra method.
11148 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11150 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
11152 2004-05-20 Martin Baulig <martin@ximian.com>
11154 * delegate.cs: Convert this file to Unix mode - like the original
11157 2004-05-20 Martin Baulig <martin@ximian.com>
11159 * attribute.cs: Convert this file to Unix mode - like the original
11162 2004-05-19 Marek Safar <marek.safar@seznam.cz>
11164 Fix bug #58688 (MCS does not report error when the same attribute
11167 * attribute.cs (Attribute.Emit): Distinction between null and default.
11169 2004-05-19 Raja R Harinath <rharinath@novell.com>
11171 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
11172 of a top-level attribute without an attribute target.
11173 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
11175 (Attribute.Conditional_GetConditionName),
11176 (Attribute.Obsolete_GetObsoleteMessage): Update.
11177 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
11178 part of ScanForIndexerName.
11179 (Attribute.CanIgnoreInvalidAttribute): New function.
11180 (Attribute.ScanForIndexerName): Move to ...
11181 (Attributes.ScanForIndexerName): ... here.
11182 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
11183 (Attributes.Search): New internal variant that can choose not to
11184 complain if types aren't resolved. The original signature now
11186 (Attributes.GetClsCompliantAttribute): Use internal variant, with
11187 complaints suppressed.
11188 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
11189 only if it not useful.
11190 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
11191 top-level for attributes that are shared between the assembly
11192 and a top-level class.
11193 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
11194 * class.cs: Update to reflect changes.
11195 (DefineIndexers): Fuse loops.
11196 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
11197 a couple more variants of attribute names.
11199 2004-05-18 Marek Safar <marek.safar@seznam.cz>
11201 Fix bug #52585 (Implemented explicit attribute declaration)
11204 (Attributable.ValidAttributeTargets): New abstract method. It gets
11205 list of valid attribute targets for explicit target declaration.
11206 (Attribute.Target): It holds target itself.
11207 (AttributeSection): Removed.
11208 (Attribute.CheckTargets): New method. It checks whether attribute
11209 target is valid for the current element.
11212 (EventProperty): New class. For events that are declared like
11213 property (with add and remove accessors).
11214 (EventField): New class. For events that are declared like field.
11217 * cs-parser.jay: Implemented explicit attribute target declaration.
11219 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
11220 Override ValidAttributeTargets.
11223 (ReturnParameter): Class for applying custom attributes on
11225 (ParameterAtribute): New class. Class for applying custom
11226 attributes on the parameter type.
11228 2004-05-17 Miguel de Icaza <miguel@ximian.com>
11230 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
11233 (Method): Allow UNSAFE here.
11235 * modifiers.cs: Support unsafe reporting.
11237 2004-05-17 Marek Safar <marek.safar@seznam.cz>
11239 * decl.cs: Fix bug #58478.
11241 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11243 * statement.cs: When checking for unreachable code on an EmptyStatement,
11244 set the location. Fixes bug #58488.
11246 2004-05-13 Miguel de Icaza <miguel@ximian.com>
11248 * driver.cs: Add -pkg handling.
11250 From Gonzalo: UseShelLExecute=false
11252 2004-05-12 Marek Safar <marek.safar@seznam.cz>
11255 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
11257 (Attribute.IsClsCompliaceRequired): Moved to base for better
11259 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
11260 when attribute is AttributeUsageAttribute.
11261 (Attribute.GetValidTargets): Simplified.
11262 (Attribute.GetAttributeUsage): New method returns AttributeUsage
11263 attribute for this type.
11264 (Attribute.ApplyAttributes): Method renamed to Emit and make
11266 (GlobalAttributeSection): New class for special handling of global
11267 attributes (assembly, module).
11268 (AttributeSection.Emit): New method.
11270 * class.cs: Implemented Attributable abstract methods.
11271 (MethodCore.LabelParameters): Moved to Parameter class.
11272 (Accessor): Is back simple class.
11273 (PropertyMethod): Implemented Attributable abstract class.
11274 (DelegateMethod): Implemented Attributable abstract class.
11275 (Event): New constructor for disctintion between normal Event
11276 and Event with accessors.
11278 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
11280 * codegen.cs, const.cs, decl.cs, delegate.cs:
11281 (CommonAssemblyModulClass): Implemented Attributable abstract class
11284 * enum.cs: Implement IAttributeSupport interface.
11285 (EnumMember): New class for emum members. Implemented Attributable
11289 (ParameterBase): Is abstract.
11290 (ReturnParameter): New class for easier [return:] attribute handling.
11292 * typemanager.cs: Removed builder_to_attr.
11294 2004-05-11 Raja R Harinath <rharinath@novell.com>
11297 * attribute.cs (Attribute.GetPositionalValue): New function.
11298 * class.cs (TypeContainer.VerifyMembers): New function.
11299 (TypeContainer.Emit): Use it.
11300 (ClassOrStruct): New base class for Class and Struct.
11301 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
11302 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
11304 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
11305 then each non-static field should have a FieldOffset attribute.
11306 Otherwise, none of the fields should have a FieldOffset attribute.
11307 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
11308 and FieldOffset attributes.
11309 * typemanager.cs (TypeManager.struct_layout_attribute_type)
11310 (TypeManager.field_offset_attribute_type): New core types.
11311 (TypeManager.InitCoreTypes): Initialize them.
11313 2004-05-11 Michal Moskal <malekith@pld-linux.org>
11315 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
11316 Return correct type.
11319 2004-05-09 Miguel de Icaza <miguel@ximian.com>
11321 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
11322 be implicitly converted to ulong.
11324 * expression.cs: The logic for allowing operator &, | and ^ worked
11325 was wrong, it worked before because we did not report an error in
11326 an else branch. Fixes 57895.
11328 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
11329 allow volatile fields to be reference types.
11331 2004-05-07 Miguel de Icaza <miguel@ximian.com>
11333 * driver.cs: Add support for /debug-
11335 2004-05-07 Raja R Harinath <rharinath@novell.com>
11337 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
11338 Add a 'complain' parameter to silence errors.
11339 (Attribute.Resolve): Update to changes. Put in sanity check to catch
11340 silently overlooked type-resolutions.
11341 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
11342 to reflect changes.
11343 (Attributes.Search): New function.
11344 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
11345 (Attributes.GetAttributeFullName): Remove hack.
11346 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
11347 Update to reflect changes.
11348 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11349 Use Attributes.Search instead of nested loops.
11351 2004-05-07 Marek Safar <marek.safar@seznam.cz>
11354 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
11355 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
11356 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
11358 * report.cs: (Report.Warning): Renamed to Warning_T because of
11359 parameter collision.
11361 2004-05-05 Raja R Harinath <rharinath@novell.com>
11363 * expression.cs (MemberAccess.ResolveMemberAccess):
11364 Exit with non-zero status after Report.Error.
11365 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
11367 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
11369 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11371 * support.cs: Don't hang when the file is empty.
11373 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11375 * support.cs: In SeekableStreamReader, compute the preamble size of the
11376 underlying stream. Position changes should take into account that initial
11379 2004-05-03 Todd Berman <tberman@sevenl.net>
11381 * driver.cs: remove unused GetSysVersion function.
11383 2004-05-03 Todd Berman <tberman@sevenl.net>
11385 * driver.cs: Remove the hack from saturday, as well as the hack
11386 from jackson (LoadAssemblyFromGac), also adds the CWD to the
11387 link_paths to get that bit proper.
11389 2004-05-01 Todd Berman <tberman@sevenl.net>
11391 * driver.cs: Try a LoadFrom before a Load, this checks the current
11392 path. This is currently a bug in mono that is be fixed, however, this
11393 provides a workaround for now. This will be removed when the bug
11396 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
11398 * CryptoConvert.cs: Updated to latest version. Fix issue with
11399 incomplete key pairs (#57941).
11401 2004-05-01 Todd Berman <tberman@sevenl.net>
11403 * driver.cs: Remove '.' from path_chars, now System.* loads properly
11406 2004-04-30 Jackson Harper <jackson@ximian.com>
11408 * codegen.cs: Open keys readonly.
11410 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11412 * typemanager.cs: don't report cyclic struct layout when a struct
11413 contains 2 or more fields of the same type. Failed for Pango.AttrShape
11414 which has 2 Pango.Rectangle fields.
11416 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
11418 * expression.cs: Handle IntPtr comparisons with IL code
11419 rather than a method call.
11421 2004-04-29 Martin Baulig <martin@ximian.com>
11423 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
11424 the list of PropertyInfo's in class hierarchy and find the
11425 accessor. Fixes #56013.
11427 2004-04-29 Martin Baulig <martin@ximian.com>
11429 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
11431 2004-04-29 Martin Baulig <martin@ximian.com>
11433 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11435 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
11437 2004-04-29 Martin Baulig <martin@ximian.com>
11439 * class.cs (ConstructorInitializer.Resolve): Check whether the
11440 parent .ctor is accessible. Fixes #52146.
11442 2004-04-29 Martin Baulig <martin@ximian.com>
11444 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11446 * statement.cs (Using.EmitLocalVariableDecls): Use
11447 TypeManager.idisposable_type, not typeof (IDisposable).
11448 (Foreach.EmitCollectionForeach): Added support for valuetypes.
11450 2004-04-29 Martin Baulig <martin@ximian.com>
11452 * class.cs (Event.Define): Don't emit the field and don't set
11453 RTSpecialName and SpecialName for events on interfaces. Fixes
11456 2004-04-29 Raja R Harinath <rharinath@novell.com>
11458 Refactor Attribute.ApplyAttributes.
11459 * attribute.cs (Attributable): New base class for objects that can
11460 have Attributes applied on them.
11461 (Attribute): Make AttributeUsage fields public.
11462 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
11463 (Attribute.IsInternalCall): New property.
11464 (Attribute.UsageAttr): Convert to a public read-only property.
11465 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
11466 (Attribute.ResolveType, Attribute.Resolve)
11467 (Attribute.ScanForIndexerName): Update to reflect changes.
11468 (Attribute.CheckAttributeTarget): Re-format.
11469 (Attribute.ApplyAttributes): Refactor, to various
11470 Attributable.ApplyAttributeBuilder methods.
11471 * decl.cs (MemberCore): Make Attributable.
11472 * class.cs (Accessor): Make Attributable.
11473 (MethodData.ApplyAttributes): Use proper attribute types, not
11475 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
11476 (TypeContainer.ApplyAttributeBuilder)
11477 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
11478 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
11479 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
11480 (Operator.ApplyAttributeBuilder): New factored-out methods.
11481 * const.cs (Const.ApplyAttributeBuilder): Likewise.
11482 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
11483 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
11484 * parameter.cs (ParameterBase): New Attributable base class
11485 that can also represent Return types.
11486 (Parameter): Update to the changes.
11488 2004-04-29 Jackson Harper <jackson@ximian.com>
11490 * driver.cs: Prefer the corlib system version when looking for
11491 assemblies in the GAC. This is still a hack, but its a better hack
11494 2004-04-29 Marek Safar <marek.safar@seznam.cz>
11496 * decl.cs, enum.cs: Improved error 3005 reporting.
11498 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
11499 (related_symbols): New private member for list of symbols
11500 related to reported error/warning.
11502 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
11504 2004-04-29 Martin Baulig <martin@ximian.com>
11506 * ecore.cs (Expression.Constantify): If we're an enum and
11507 TypeManager.TypeToCoreType() doesn't give us another type, use
11508 t.UnderlyingSystemType. Fixes #56178.
11510 2004-04-29 Martin Baulig <martin@ximian.com>
11512 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
11513 interfaces and for each interface, only add members directly
11514 declared in that interface. Fixes #53255.
11516 2004-04-28 Martin Baulig <martin@ximian.com>
11518 * expression.cs (ConditionalLogicalOperator): Use a temporary
11519 variable for `left' to avoid that we evaluate it more than once;
11522 2004-04-28 Martin Baulig <martin@ximian.com>
11524 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
11527 2004-04-28 Martin Baulig <martin@ximian.com>
11529 * statement.cs (LocalInfo.Resolve): Check whether the type is not
11532 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
11533 whether the type is not void (CS1547).
11535 2004-04-28 Martin Baulig <martin@ximian.com>
11537 * expression.cs (Unary.DoResolveLValue): Override this and report
11538 CS0131 for anything but Operator.Indirection.
11540 2004-04-28 Martin Baulig <martin@ximian.com>
11542 Committing a patch from Ben Maurer; see bug #50820.
11544 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11547 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11550 2004-04-28 Martin Baulig <martin@ximian.com>
11552 Committing a patch from Ben Maurer; see bug #50820.
11554 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11557 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11560 2004-04-28 Martin Baulig <martin@ximian.com>
11562 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
11563 (Block.AddLabel): Call DoLookupLabel() to only search in the
11566 2004-04-28 Martin Baulig <martin@ximian.com>
11568 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11569 comparing StringConstants and NullLiterals in Equality and Inequality.
11571 2004-04-28 Jackson Harper <jackson@ximian.com>
11573 * driver.cs: Attempt to load referenced assemblies from the
11574 GAC. This is the quick and dirty version of this method that
11575 doesnt take into account versions and just takes the first
11576 canidate found. Will be good enough for now as we will not have more
11577 then one version installed into the GAC until I update this method.
11579 2004-04-28 Martin Baulig <martin@ximian.com>
11581 * typemanager.cs (TypeManager.CheckStructCycles): New public
11582 static method to check for cycles in the struct layout.
11584 * rootcontext.cs (RootContext.PopulateTypes): Call
11585 TypeManager.CheckStructCycles() for each TypeContainer.
11586 [Note: We only need to visit each type once.]
11588 2004-04-28 Martin Baulig <martin@ximian.com>
11590 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11592 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11593 success and added `out object value'. Use a `bool resolved' field
11594 to check whether we've already been called rather than
11595 `ConstantValue != null' since this breaks for NullLiterals.
11597 2004-04-28 Raja R Harinath <rharinath@novell.com>
11599 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11600 setting of this flag, since the 'set' method may be non-public.
11602 2004-04-28 Raja R Harinath <rharinath@novell.com>
11604 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11605 check on current_vector.Block.
11607 2004-04-27 Martin Baulig <martin@ximian.com>
11609 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11610 a field initializer. Fixes #56459.
11612 2004-04-27 Martin Baulig <martin@ximian.com>
11614 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11615 we're not attempting to use an indexer. Fixes #52154.
11617 2004-04-27 Martin Baulig <martin@ximian.com>
11619 * statement.cs (Return): Don't create a return label if we don't
11620 need it; reverts my change from January 20th. Thanks to Ben
11623 2004-04-27 Martin Baulig <martin@ximian.com>
11625 According to the spec, `goto' can only leave a nested scope, but
11628 * statement.cs (Block.LookupLabel): Only lookup in the current
11629 block, don't recurse into parent or child blocks.
11630 (Block.AddLabel): Check in parent and child blocks, report
11631 CS0140/CS0158 if we find a duplicate.
11632 (Block): Removed this indexer for label lookups.
11633 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11634 this already does the error reporting for us.
11637 (FlowBranching.UsageVector.Block): New public variable; may be null.
11638 (FlowBranching.CreateSibling): Added `Block' argument.
11639 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11640 label for the target of a `goto' and check whether we're not
11641 leaving a `finally'.
11643 2004-04-27 Martin Baulig <martin@ximian.com>
11645 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11646 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11649 2004-04-27 Martin Baulig <martin@ximian.com>
11651 * statement.cs (Block.AddLabel): Also check for implicit blocks
11652 and added a CS0158 check.
11654 2004-04-27 Martin Baulig <martin@ximian.com>
11656 * flowanalysis.cs (FlowBranchingLoop): New class.
11657 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11658 UsageVector's instead of an ArrayList.
11659 (FlowBranching.Label): Likewise.
11660 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11661 (FlowBranching.AddBreakVector): New method.
11663 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11665 * attribute.cs: Small regression fix: only convert the type if we
11666 the type is different, fixes System.Drawing build.
11668 2004-04-27 Martin Baulig <martin@ximian.com>
11670 * attribute.cs (Attribute.Resolve): If we have a constant value
11671 for a named field or property, implicity convert it to the correct
11674 2004-04-27 Raja R Harinath <rharinath@novell.com>
11676 * statement.cs (Block.Block): Implicit blocks share
11677 'child_variable_names' fields with parent blocks.
11678 (Block.AddChildVariableNames): Remove.
11679 (Block.AddVariable): Mark variable as "used by a child block" in
11680 every surrounding block.
11681 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11682 been used in a child block, complain about violation of "Invariant
11683 meaning in blocks" rule.
11684 * cs-parser.jay (declare_local_variables): Don't use
11685 AddChildVariableNames.
11686 (foreach_statement): Don't create an implicit block: 'foreach'
11687 introduces a scope.
11689 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11691 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11692 converting from 0L to ulong. Fixes 57522.
11694 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11696 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11697 derived class hides via 'new' keyword field from base class (test-242.cs).
11698 TODO: Handle this in the more general way.
11700 * class.cs (CheckBase): Ditto.
11702 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11704 * decl.cs (caching_flags): New member for storing cached values
11706 (MemberCore.Flags): New enum where bit flags for caching_flags
11708 (MemberCore.cls_compliance): Moved to caching_flags.
11709 (DeclSpace.Created): Moved to caching_flags.
11711 * class.cs: Use caching_flags instead of DeclSpace.Created
11713 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11715 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11716 if we are only a derived class, not a nested class.
11718 * typemanager.cs: Same as above, but do this at the MemberLookup
11719 level (used by field and methods, properties are handled in
11720 PropertyExpr). Allow for the qualified access if we are a nested
11723 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11725 * class.cs: Refactoring.
11726 (IMethodData): New inteface; Holds links to parent members
11727 to avoid member duplication (reduced memory allocation).
11728 (Method): Implemented IMethodData interface.
11729 (PropertyBase): New inner classes for get/set methods.
11730 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11731 (Event): New inner classes for add/remove methods.
11732 (Event.DelegateMethod): Implemented IMethodData interface.
11734 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11735 EmitContext (related to class.cs refactoring).
11737 2004-04-21 Raja R Harinath <rharinath@novell.com>
11739 * delegate.cs (Delegate.VerifyApplicability): If the number of
11740 arguments are the same as the number of parameters, first try to
11741 verify applicability ignoring any 'params' modifier on the last
11745 2004-04-08 Martin Baulig <martin@ximian.com>
11747 Merged latest changes into gmcs. Please keep this comment in
11748 here, it makes it easier for me to see what changed in MCS since
11749 the last time I merged.
11751 2004-04-16 Raja R Harinath <rharinath@novell.com>
11753 * class.cs (TypeContainer.AddIndexer): Use
11754 'ExplicitInterfaceName' to determine if interface name was
11755 explicitly specified. 'InterfaceType' is not initialized at this time.
11756 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11757 Indexers array is already in the required order. Initialize
11758 'IndexerName' only if there are normal indexers.
11759 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11760 (TypeContainer.Emit): Emit DefaultMember attribute only if
11761 IndexerName is initialized.
11764 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11766 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11769 2004-04-15 Raja R Harinath <rharinath@novell.com>
11771 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11775 * attribute.cs (Attribute.Resolve): Check for duplicate named
11779 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11781 * iterators.cs (MarkYield): track whether we are in an exception,
11782 and generate code accordingly. Use a temporary value to store the
11783 result for our state.
11785 I had ignored a bit the interaction of try/catch with iterators
11786 since their behavior was not entirely obvious, but now it is
11787 possible to verify that our behavior is the same as MS .NET 2.0
11791 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11793 * iterators.cs: Avoid creating temporaries if there is no work to
11796 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11797 Enumerations, use TypeManager.EnumToUnderlying and call
11800 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11803 (This.Emit): Use EmitContext.EmitThis to emit our
11806 (This.EmitAssign): Ditto.
11808 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11809 codepaths, we will move all the functionality into
11812 (FieldExpr.EmitAssign): Ditto.
11814 This fixes several hidden bugs that I uncovered while doing a code
11815 review of this today.
11817 * codegen.cs (EmitThis): reworked so the semantics are more clear
11818 and also support value types "this" instances.
11820 * iterators.cs: Changed so that for iterators in value types, we
11821 do not pass the value type as a parameter.
11823 Initialization of the enumerator helpers is now done in the caller
11824 instead of passing the parameters to the constructors and having
11825 the constructor set the fields.
11827 The fields have now `assembly' visibility instead of private.
11829 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11831 * expression.cs (Argument.Resolve): Check if fields passed as ref
11832 or out are contained in a MarshalByRefObject.
11834 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11835 another compiler type.
11837 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11839 * class.cs (Indexer.Define): use the new name checking method.
11840 Also, return false on an error.
11841 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11842 (is_identifier_[start/part]_character): make static.
11844 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11846 * expression.cs (Binary.ResolveOperator): Do no append strings
11847 twice: since we can be invoked more than once (array evaluation)
11848 on the same concatenation, take care of this here. Based on a fix
11849 from Ben (bug #56454)
11851 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11853 * codegen.cs: Fix another case where CS1548 must be reported (when
11854 delay-sign isn't specified and no private is available #56564). Fix
11855 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11856 error when MCS is used on the MS runtime and we need to delay-sign
11857 (which seems unsupported by AssemblyBuilder - see #56621).
11859 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11861 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11862 (TypeManager.ComputeNamespaces): Faster implementation for
11865 * compiler.csproj: Updated AssemblyName to mcs.
11867 2004-05-11 Jackson Harper <jackson@ximian.com>
11869 * Makefile: Preserve MONO_PATH
11871 2004-05-11 Jackson Harper <jackson@ximian.com>
11873 * Makefile: Use mono and mcs to build gmcs
11875 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11877 * codegen.cs: Add patch from Robert Shade
11878 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11881 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11883 * CryptoConvert.cs: Updated to latest version. Fix issue with
11884 incomplete key pairs (#57941).
11886 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11888 * codegen.cs: Fix another case where CS1548 must be reported (when
11889 delay-sign isn't specified and no private is available #56564). Fix
11890 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11891 error when MCS is used on the MS runtime and we need to delay-sign
11892 (which seems unsupported by AssemblyBuilder - see #56621).
11894 2004-04-29 Jackson Harper <jackson@ximian.com>
11896 * Makefile: Set MONO_PATH to use the bootstrap corlib
11897 * driver.cs: Check the GAC for referenced assemblies.
11899 2004-04-29 Martin Baulig <martin@ximian.com>
11901 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11903 2004-04-07 Martin Baulig <martin@ximian.com>
11905 * expression.cs (Binary.ResolveOperator): Added special case for
11906 Equality/Inequality between a type parameter and a null literal.
11908 2004-04-07 Martin Baulig <martin@ximian.com>
11910 * convert.cs: Check null literal -> type parameter conversions.
11912 2004-04-07 Martin Baulig <martin@ximian.com>
11914 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11915 `class' and `struct' constraints.
11917 2004-04-07 Martin Baulig <martin@ximian.com>
11919 * generic.cs (SpecialConstraint): New public enum.
11920 (Constraints.Resolve): Added support for the `class' and `struct'
11923 * cs-parser.jay (type_parameter_constraint): Added support for the
11924 `class' and `struct' constraints.
11926 2004-04-07 Martin Baulig <martin@ximian.com>
11928 * support.cs (GenericConstraints): Replaced `Types' by
11929 `ClassConstraint' and `InterfaceConstraints'; added
11930 `HasClassConstraint'.
11932 2004-04-07 Martin Baulig <martin@ximian.com>
11935 (Constraints.InterfaceConstraints): New public property.
11936 (Constraints.Types): Make this property public
11937 (TypeParameter): Implement IMemberContainer.
11938 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
11939 instead of a TypeBuilder/MethodBuilder; pass the interface
11940 constraints to TypeManager.AddTypeParameter().
11941 (TypeParameter.DefineType): Just take an EmitContext and no
11942 TypeBuilder/MethodBuilder. Use the new public API.
11944 * typemanager.cs (TypeManager.AddTypeParameter): Added
11945 `TypeExpr[]' argument; add the interfaces to the
11946 `builder_to_ifaces' hash.
11947 (TypeManager.LookupMemberContainer): For
11948 GenericTypeParameterBuilders, get the TypeParameter from the
11949 `builder_to_type_param'.
11950 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
11951 the TypeParameter and call FindMembers on it.
11953 2004-04-07 Martin Baulig <martin@ximian.com>
11956 (MethodCore.GenericMethod): Moved this field here from Method.
11957 (MethodCore.IsDuplicateImplementation): Take the number of type
11958 parameters into account if we're a generic method.
11960 * expression.cs (Invocation.InferTypeArguments): Don't return true
11961 if `arguments' is null; we still need to check whether we actually
11962 don't need to infer anything in this case.
11963 (MemberAccess): Merged the functionality from GenericMemberAccess
11966 * generic.cs (GenericMemberAccess): Removed.
11968 2004-04-05 Martin Baulig <martin@ximian.com>
11970 * decl.cs (MemberCore): For generic classes, interfaces and
11971 structs, `Name' now includes the number of type parameters
11972 ("Stack!1.Node!1").
11973 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
11974 encode the number of type arguments in the type name.
11976 * expression.cs (Expression.MemberLookup): Removed the
11977 `num_type_args' argument; we now encode the number of type
11978 arguments in the type name.
11980 * ecore.cs (SimpleName): Encode the number of type arguments in
11981 the type name itself.
11983 * generic.cs (ConstructedType): Likewise.
11985 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
11986 `MemberName'; we now include the number of type parameters in the
11989 * typemanager.cs (TypeManager.CheckGeneric): Removed.
11990 (TypeManager.MemberLookup): Removed the
11991 `num_type_args' argument; we now encode the number of type
11992 arguments in the type name.
11994 2004-04-03 Martin Baulig <martin@ximian.com>
11996 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
11997 (MemberCore.MemberName): Moved here from MemberBase.
11998 (DeclSpace.SetParameterInfo): Just take the constraints as an
11999 ArrayList; we already have the type parameters in our
12000 `MemberName'; also do the CS0080 reporting here.
12002 * cs-parser.jay (struct_declaration): Use `member_name' instead of
12003 `IDENTIFIER opt_type_parameter_list'; when constructing our
12004 `MemberName', it'll already include our type parameters.
12005 (class_declaration, interface_declaration): Likewise.
12006 (delegate_declaration): Likewise.
12007 (MakeName): Take a MemberName and return a MemberName.
12008 The following two changes are required to avoid shift/reduce conflicts:
12009 (member_name): Don't include a TypeName anymore; ie. this is now
12010 just 'IDENTIFIER opt_type_parameter_list'.
12011 (property_declaration, event_declaration): Use a
12012 `namespace_or_type_name' instead of a `member_name'.
12014 2004-04-03 Martin Baulig <martin@ximian.com>
12016 * decl.cs (MemberName): Renamed to `TypeName' and created a new
12017 `MemberName' class.
12018 (TypeName): Formerly known as MemberName.
12020 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
12021 instead of a `MemberName'.
12023 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
12024 (member_name): New rule; create a MemberName.
12026 2004-04-02 Martin Baulig <martin@ximian.com>
12028 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
12029 (CS0305 and CS0308).
12031 2004-04-02 Martin Baulig <martin@ximian.com>
12033 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
12034 support for nested types.
12036 2004-04-02 Martin Baulig <martin@ximian.com>
12038 * ecore.cs (IAlias): New public interface.
12039 (TypeExpr, TypeExpression): Implement IAlias.
12040 (TypeAliasExpression): New public class.
12042 * namespace.cs (Namespace): Implement IAlias.
12043 (Namespace.Lookup): Return an IAlias instead on an object.
12044 (Namespace.DefineName): Take an IAlias instead of an object.
12045 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
12047 (NamespaceEntry.UsingAlias): Take a Membername instead of an
12049 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
12051 (NamespaceEntry.Lookup): Likewise.
12053 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
12056 * decl.cs (DeclSpace): Implement IAlias.
12057 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
12059 * generic.cs (ConstructedType): Improved error checking.
12061 2004-04-02 Martin Baulig <martin@ximian.com>
12063 * convert.cs: Added type parameter conversions.
12066 (UnboxCast.Emit): Emit an `unbox.any' for type params.
12067 (ClassCast.Emit): If the source type is a type parameter, box it.
12068 If the target type is a type parameter, emit an `unbox.any'
12069 instead of a `classcast'.1
12071 2004-04-01 Martin Baulig <martin@ximian.com>
12073 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
12075 2004-04-01 Martin Baulig <martin@ximian.com>
12077 * generic.cs (ConstructedType.CheckConstraints): Use
12078 Convert.ImplicitStandardConversionExists(); user-defined implicit
12079 conversions are not allowed according to the spec.
12081 2004-03-30 Martin Baulig <martin@ximian.com>
12083 * expression.cs (New): Added support for type parameters.
12086 (TypeManager.activator_type): New public static field.
12087 (TypeManager.activator_create_instance): Likewise.
12089 2004-03-30 Martin Baulig <martin@ximian.com>
12091 * typemanager.cs (TypeManager.HasConstructorConstraint): New
12094 2004-03-30 Martin Baulig <martin@ximian.com>
12096 * generic.cs (ConstructedType.CheckConstraints): Actually follow
12097 the spec here: the argument type must be convertible to the
12100 2004-03-30 Martin Baulig <martin@ximian.com>
12103 (TypeParameter.Define, TypeParameter.DefineMethod): Call
12104 TypeManager.AddTypeParameter().
12105 (ConstructedType.CheckConstraints): Re-enable this and actually
12106 check whether we have a constructor constraint.
12109 (TypeManager.builder_to_type_param): New static field.
12110 (TypeManager.AddTypeParameter): New static method.
12111 (TypeManager.LookupTypeParameter): New public method.
12113 2004-03-30 Martin Baulig <martin@ximian.com>
12115 * generic.cs (TypeParameter.DefineType): Return a boolean and use
12116 the new API to actually define the constructor constraint.
12119 (TypeManager.new_constraint_attr_type): New static field.
12120 (TypeManager.InitCoreTypes): Initialize it.
12122 2004-03-30 Martin Baulig <martin@ximian.com>
12124 * generic.cs (Constraints): Completed error checking, use correct
12127 2004-03-29 Martin Baulig <martin@ximian.com>
12129 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
12131 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12132 public version which takes a `ParameterData pd' instead of an
12135 2004-03-29 Martin Baulig <martin@ximian.com>
12137 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
12140 2004-03-29 Martin Baulig <martin@ximian.com>
12142 * expression.cs (Argument.ResolveMethodGroup): If we're a
12143 ConstructedType, call GetMemberAccess() on it.
12145 2004-03-29 Martin Baulig <martin@ximian.com>
12147 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
12148 (MethodCore.CheckGenericOverride): When overriding a generic
12149 method, check whether the constraints match.
12151 * support.cs (GenericConstraints): New public interface.
12152 (ParameterData.GenericConstraints): New public method.
12154 * parameter.cs (Parameter.Resolve): Check whether we're a generic
12155 method parameter and compute our constraints if appropriate.
12156 (Parameter.GenericConstraints): New public property.
12158 * generic.cs (Constraints): Implement GenericConstraints.
12160 2004-03-29 Martin Baulig <martin@ximian.com>
12162 * decl.cs (MemberCache.FindMemberToOverride): Use
12163 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
12165 2004-03-29 Martin Baulig <martin@ximian.com>
12167 * generic.cs (GenericMethod.Define): Resolve our type parameters.
12169 2004-03-29 Martin Baulig <martin@ximian.com>
12171 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
12172 not allowed on non-generic declarations").
12174 2004-03-29 Martin Baulig <martin@ximian.com>
12176 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12177 public version of this method.
12179 * class.cs (MethodCore.IsDuplicateImplementation): Use
12180 Invocation.InferTypeArguments() to check this.
12182 2004-03-29 Martin Baulig <martin@ximian.com>
12184 * convert.cs: Use TypeManager.IsDelegateType() instead of
12185 comparing types correctly.
12187 2004-03-29 Martin Baulig <martin@ximian.com>
12189 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
12190 types directly to make it work for generic instances.
12192 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
12194 2004-03-29 Martin Baulig <martin@ximian.com>
12196 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
12197 support for arrays.
12199 2004-03-24 Martin Baulig <martin@ximian.com>
12201 * decl.cs (DeclSpace.FindType): Also use
12202 TypeManager.CheckGeneric() for types from the using clauses.
12204 2004-03-23 Martin Baulig <martin@ximian.com>
12206 * expression.cs (Invocation.OverloadResolve): Added `bool
12207 may_fail' argument and use it instead of the Location.IsNull() hack.
12209 2004-03-23 Martin Baulig <martin@ximian.com>
12211 * expression.cs (Invocation.InferType): Use correct type inference
12214 2004-03-23 Martin Baulig <martin@ximian.com>
12216 * ecore.cs (MethodGroupExpr.Name): Use
12217 TypeManager.CSharpSignature() instead of just the name.
12219 * expression.cs (Invocation.OverloadResolve): Provide better error
12221 (Invocation.DoResolve): OverloadResolve() never returns null
12222 without reporting an error, so removed the error -6 reporting here.
12224 2004-03-23 Martin Baulig <martin@ximian.com>
12226 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
12229 * cs-parser.jay (delegate_declaration): Support generic delegates.
12231 * delegate.cs: Support generic delegates.
12233 2004-03-22 Martin Baulig <martin@ximian.com>
12235 * expression.cs (Invocation.InferParamsTypeArguments): New static
12236 method; does type inference for params arguments.
12238 2004-03-21 Martin Baulig <martin@ximian.com>
12240 * typemanager.cs (TypeManager.IsGenericMethod): New public static
12241 method; checks whether a method is a generic method.
12243 * expression.cs (Invocation.InferTypeArguments): New static method;
12244 infer type arguments for generic method invocation.
12246 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
12247 property; we set this to true if we're resolving a generic method
12248 invocation and the user specified type arguments, ie. we're not
12249 doing type inference.
12251 2004-03-20 Martin Baulig <martin@ximian.com>
12253 * class.cs (MethodData.DeclaringType): New public property.
12254 (MethodData.Define): Set DeclaringType here.
12255 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
12256 instead of OperatorMethodBuilder.DeclaringType.
12258 2004-03-20 Martin Baulig <martin@ximian.com>
12260 * cs-tokenizer.cs (xtoken): Return a special
12261 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
12263 * cs-parser.jay (default_value_expression): Switch to the new
12266 2004-03-19 Martin Baulig <martin@ximian.com>
12268 * decl.cs (MemberName): New class. We use this to "construct"
12269 namespace_or_type_name's.
12271 * generics.cs (TypeArguments.GetDeclarations): New public method;
12272 returns the type arguments as a string[] and reports a CS0081 if
12273 one of them is not an identifier.
12275 * class.cs (MemberBase): The .ctor now takes the name as a
12276 MemberName instead of a string.
12277 (MemberBase.ExplicitInterfaceName): Changed type from string to
12279 (MemberBase.DoDefine): If we're an explicit implementation, the
12280 InterfaceType may be a generic instance.
12282 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
12283 (namespace_name): Call MemberName.GetName () to transform the
12284 MemberName into a string and ensure we don't have any type
12286 (type_name): Call MemberName.GetTypeExpression() to transfrom the
12287 MemberName into an expression.
12288 (method_header): Use namespace_or_type_name instead of member_name.
12290 2004-04-07 Miguel de Icaza <miguel@ximian.com>
12292 * rootcontext.cs: Add new types to the boot resolution.
12294 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
12295 MulticastDelegate is not allowed.
12297 * typemanager.cs: Add new types to lookup: System.TypedReference
12300 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
12301 check for TypedReference or ArgIterator, they are not allowed.
12303 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
12304 makes us properly catch 1510 in some conditions (see bug 56016 for
12307 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
12309 * CryptoConvert.cs: update from corlib version
12312 2004-04-05 Miguel de Icaza <miguel@ximian.com>
12314 * class.cs (Indexer.Define): Check indexername declaration
12316 2004-04-05 Marek Safar <marek.safar@seznam.cz>
12318 * attribute.cs (IsClsCompliant): Fixed problem with handling
12319 all three states (compliant, not-compliant, undetected).
12321 2004-03-30 Marek Safar <marek.safar@seznam.cz>
12323 * attribute.cs (Attribute): Location is now public.
12324 (Resolve): Store resolved arguments (pos_values) in attribute class.
12325 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
12326 (GetClsCompliantAttributeValue): New method that gets
12327 CLSCompliantAttribute value.
12328 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
12329 if exists else null.
12330 (AttributeTester): New class for CLS-Compliant verification routines.
12332 * class.cs (Emit): Add CLS-Compliant verification.
12333 (Method.GetSignatureForError): Implemented.
12334 (Constructor.GetSignatureForError): Implemented
12335 (Constructor.HasCompliantArgs): Returns if constructor has
12336 CLS-Compliant arguments.
12337 (Constructor.Emit): Override.
12338 (Construcor.IsIdentifierClsCompliant): New method; For constructors
12339 is needed to test only parameters.
12340 (FieldBase.GetSignatureForError): Implemented.
12341 (TypeContainer): New member for storing base interfaces.
12342 (TypeContainer.FindMembers): Search in base interfaces too.
12344 * codegen.cs (GetClsComplianceAttribute): New method that gets
12345 assembly or module CLSCompliantAttribute value.
12346 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
12348 (ModuleClass.Emit): Add error 3012 test.
12350 * const.cs (Emit): Override and call base for CLS-Compliant tests.
12352 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
12353 state for all decl types.
12354 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
12355 if CLS-Compliant tests are required.
12356 (IsClsCompliaceRequired): New method. Analyze whether code
12357 must be CLS-Compliant.
12358 (IsExposedFromAssembly): New method. Returns true when MemberCore
12359 is exposed from assembly.
12360 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
12361 value or gets cached value.
12362 (HasClsCompliantAttribute): New method. Returns true if MemberCore
12363 is explicitly marked with CLSCompliantAttribute.
12364 (IsIdentifierClsCompliant): New abstract method. This method is
12365 used to testing error 3005.
12366 (IsIdentifierAndParamClsCompliant): New method. Common helper method
12367 for identifier and parameters CLS-Compliant testing.
12368 (VerifyClsCompliance): New method. The main virtual method for
12369 CLS-Compliant verifications.
12370 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
12371 null. I don't know why is null (too many public members !).
12372 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
12373 and get value of first CLSCompliantAttribute that found.
12375 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
12376 (VerifyClsCompliance): Override and add extra tests.
12378 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
12379 clscheck- disable CLS-Compliant verification event if assembly is has
12380 CLSCompliantAttribute(true).
12382 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
12383 ApllyAttribute is now called in emit section as in the other cases.
12384 Possible future Emit integration.
12385 (IsIdentifierClsCompliant): New override.
12386 (VerifyClsCompliance): New override.
12387 (GetEnumeratorName): Returns full enum name.
12389 * parameter.cs (GetSignatureForError): Implemented.
12391 * report.cs (WarningData): New struct for Warning message information.
12392 (LocationOfPreviousError): New method.
12393 (Warning): New method. Reports warning based on the warning table.
12394 (Error_T): New method. Reports error based on the error table.
12396 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
12397 verifications are done here.
12399 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
12401 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
12402 CLSCompliantAttribute.
12403 (all_imported_types): New member holds all imported types from other
12405 (LoadAllImportedTypes): New method fills static table with exported types
12406 from all referenced assemblies.
12407 (Modules): New property returns all assembly modules.
12409 2004-03-30 Miguel de Icaza <miguel@ximian.com>
12411 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
12412 throwing a parser error.
12414 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
12415 which removes the hardcoded get_/set_ prefixes for properties, as
12416 IL allows for the properties to be named something else.
12420 * expression.cs: Do not override operand before we know if it is
12421 non-null. Fix 56207
12423 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12425 * typemanager.cs: support for pinned variables.
12427 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12429 * decl.cs, typemanager.cs: Avoid using an arraylist
12430 as a buffer if there is only one result set.
12432 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12434 * expression.cs: Make sure you cant call a static method
12435 with an instance expression, bug #56174.
12437 2004-03-29 Miguel de Icaza <miguel@ximian.com>
12439 * class.cs (IsDuplicateImplementation): Improve error reporting to
12440 flag 663 (method only differs in parameter modifier).
12442 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
12443 in preprocessor directives.
12445 * location.cs (LookupFile): Allow for the empty path.
12447 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
12448 better approach for some of that patch, but its failing with the
12449 CharSet enumeration. For now try/catch will do.
12451 * typemanager.cs: Do not crash if a struct does not have fields.
12454 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12456 * expression.cs: cs0213, cant fix a fixed expression.
12459 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12461 * cs-parser.jay: detect invalid embeded statements gracefully.
12464 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12466 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
12469 the invocation type may not be a subclass of the tye of the item/
12470 The type of the item must be a subclass of the invocation item.
12475 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
12477 * attribute.cs: Added methods to get a string and a bool from an
12478 attribute. Required to information from AssemblyKeyFileAttribute,
12479 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
12480 * codegen.cs: Modified AssemblyName creation to include support for
12481 strongnames. Catch additional exceptions to report them as CS1548.
12482 * compiler.csproj: Updated include CryptoConvert.cs.
12483 * compiler.csproj.user: Removed file - user specific configuration.
12484 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
12485 Mono.Security assembly. The original class is maintained and tested in
12486 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
12487 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
12488 like CSC 8.0 (C# v2) supports.
12489 * Makefile: Added CryptoConvert.cs to mcs sources.
12490 * rootcontext.cs: Added new options for strongnames.
12492 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
12494 * driver.cs: For --expect-error, report error code `2'
12495 if the program compiled with no errors, error code `1' if
12496 it compiled with an error other than the one expected.
12498 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
12500 * compiler.csproj: Updated for Visual Studio .NET 2003.
12501 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
12502 * compiler.sln: Updated for Visual Studio .NET 2003.
12504 2004-03-24 Ravi Pratap M <ravi@ximian.com>
12506 * expression.cs: Fix bug #47234. We basically need to apply the
12507 rule that we prefer the conversion of null to a reference type
12508 when faced with a conversion to 'object' (csc behaviour).
12510 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12512 * statement.cs: Shorter form for foreach, eliminates
12513 a local variable. r=Martin.
12515 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12517 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
12518 checks if we can use brtrue/brfalse to test for 0.
12519 * expression.cs: use the above in the test for using brtrue/brfalse.
12520 cleanup code a bit.
12522 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12524 * expression.cs: Rewrite string concat stuff. Benefits:
12526 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
12527 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
12528 rather than a concat chain.
12530 * typemanager.cs: Add lookups for more concat overloads.
12532 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12534 * expression.cs: Emit shorter il code for array init.
12551 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
12553 * statement.cs: Before, two switch blocks would be merged if the
12554 total size of the blocks (end_item - begin_item + 1) was less than
12555 two times the combined sizes of the blocks.
12557 Now, it will only merge if after the merge at least half of the
12562 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
12564 * class.cs : csc build fix for GetMethods(). See bug #52503.
12566 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12568 * expression.cs: Make sure fp comparisons work with NaN.
12569 This fixes bug #54303. Mig approved this patch a long
12570 time ago, but we were not able to test b/c the runtime
12573 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12575 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12577 2004-03-19 Martin Baulig <martin@ximian.com>
12579 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12580 two overloads may unify for some type parameter substitutions and
12581 report a CS0408 if appropriate.
12583 2004-03-19 Martin Baulig <martin@ximian.com>
12585 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12586 error here and not in our caller.
12588 2004-03-19 Martin Baulig <martin@ximian.com>
12590 * interface.cs: Completely killed this file.
12591 (Interface): We're now a TypeContainer and live in class.cs.
12593 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12594 argument; we're now also called for interfaces.
12595 (TypeContainer.DefineMembers): Allow this method being called
12597 (TypeContainer.GetMethods): New public method; formerly known as
12598 Interface.GetMethod(). This is used by PendingImplementation.
12599 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12600 it's now private and non-static.
12601 (Interface): Moved this here; it's now implemented similar to
12603 (Method, Property, Event, Indexer): Added `bool is_interface'
12604 argument to their .ctor's.
12605 (MemberBase.IsInterface): New public field.
12607 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12608 instances instead of InterfaceMethod, InterfaceProperty, etc.
12609 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12610 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12612 2004-03-19 Martin Baulig <martin@ximian.com>
12614 * class.cs (MethodCore.IsDuplicateImplementation): New private
12615 method which does the CS0111 checking.
12616 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12617 Use IsDuplicateImplementation().
12619 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12621 * decl.cs (FindMemberToOverride): New method to find the correct
12622 method or property to override in the base class.
12624 - Make Method/Property use the above method to find the
12625 version in the base class.
12626 - Remove the InheritableMemberSignatureCompare as it is now
12629 This patch makes large code bases much faster to compile, as it is
12630 O(n) rather than O(n^2) to do this validation.
12632 Also, it fixes bug 52458 which is that nested classes are not
12633 taken into account when finding the base class member.
12635 Reviewed/Approved by Martin.
12637 2004-03-17 Martin Baulig <martin@ximian.com>
12639 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12640 of type arguments into account; use the `real_num_type_args'
12641 approach like in DoResolveAsTypeStep().
12643 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12646 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12648 * interface.cs: In all interface classes removed redundant
12649 member initialization.
12651 2004-03-16 Martin Baulig <martin@ximian.com>
12653 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12655 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12657 * decl.cs (DefineTypeAndParents): New helper method to define a
12658 type's containers before the type itself is defined; This is a
12659 bug exposed by the recent changes to Windows.Forms when an
12660 implemented interface was defined inside a class that had not been
12663 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12665 (Check): Loop correctly to report errors modifiers
12666 (UNSAFE was not in the loop, since it was the same as TOP).
12668 * interface.cs: Every interface member now takes a ModFlags,
12669 instead of a "is_new" bool, which we set on the base MemberCore.
12671 Every place where we called "UnsafeOk" in the interface, now we
12672 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12673 the unsafe settings from the member declaration instead of the
12674 container interface.
12676 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12678 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12679 `set_indexer_name' to the pending bits (one per type).
12681 We fixed a bug today that was picking the wrong method to
12682 override, since for properties the existing InterfaceMethod code
12683 basically ignored the method name. Now we make sure that the
12684 method name is one of the valid indexer names.
12686 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12688 * support.cs (SeekableStreamReader): Keep track of stream byte
12689 positions and don't mix them with character offsets to the buffer.
12691 Patch from Gustavo Giráldez
12693 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12695 * interface.cs (InterfaceSetGetBase): Removed double member
12696 initialization, base class does it as well.
12698 2004-03-13 Martin Baulig <martin@ximian.com>
12700 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12701 when compiling corlib.
12703 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12705 * convert.cs (ExplicitConversion): We were reporting an error on
12706 certain conversions (object_type source to a value type, when the
12707 expression was `null') before we had a chance to pass it through
12708 the user defined conversions.
12710 * driver.cs: Replace / and \ in resource specifications to dots.
12713 * class.cs: Add check for duplicate operators. Fixes 52477
12715 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12717 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12718 that are in the middle of the statements, not only at the end.
12721 * class.cs (TypeContainer.AddField): No longer set the
12722 `HaveStaticConstructor' flag, now we call it
12723 `UserDefineStaticConstructor' to diferentiate the slightly
12724 semantic difference.
12726 The situation is that we were not adding BeforeFieldInit (from
12727 Modifiers.TypeAttr) to classes that could have it.
12728 BeforeFieldInit should be set to classes that have no static
12733 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12735 And most importantly Zoltan's comment:
12737 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12739 "I think beforefieldinit means 'it's ok to initialize the type sometime
12740 before its static fields are used', i.e. initialization does not need
12741 to be triggered by the first access to the type. Setting this flag
12742 helps the JIT to compile better code, since it can run the static
12743 constructor at JIT time, and does not need to generate code to call it
12744 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12745 this flag for lots of classes like String.
12747 csc sets this flag if the type does not have an explicit static
12748 constructor. The reasoning seems to be that if there are only static
12749 initalizers for a type, and no static constructor, then the programmer
12750 does not care when this initialization happens, so beforefieldinit
12753 This bug prevents the AOT compiler from being usable, since it
12754 generates so many calls to mono_runtime_class_init that the AOT code
12755 is much slower than the JITted code. The JITted code is faster,
12756 because it does not generate these calls if the vtable is type is
12757 already initialized, which is true in the majority of cases. But the
12758 AOT compiler can't do this."
12760 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12762 * class.cs (MethodData.Emit): Refactor the code so symbolic
12763 information is generated for destructors; For some reasons we
12764 were taking a code path that did not generate symbolic information
12767 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12769 * class.cs: Create a Constructor.CheckBase method that
12770 takes care of all validation type code. The method
12771 contains some code that was moved from Define.
12773 It also includes new code that checks for duplicate ctors.
12774 This fixes bug #55148.
12776 2004-03-09 Joshua Tauberer <tauberer@for.net>
12778 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12779 a { ... }-style array creation invokes EmitStaticInitializers
12780 which is not good for reference-type arrays. String, decimal
12781 and now null constants (NullCast) are not counted toward
12782 static initializers.
12784 2004-03-05 Martin Baulig <martin@ximian.com>
12786 * location.cs (SourceFile.HasLineDirective): New public field;
12787 specifies whether the file contains or is referenced by a "#line"
12789 (Location.DefineSymbolDocuments): Ignore source files which
12790 either contain or are referenced by a "#line" directive.
12792 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12794 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12795 direct access to our parent, so check the method inline there.
12797 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12799 * expression.cs (Invocation.EmitCall): Miguel's last commit
12800 caused a regression. If you had:
12805 In Foo the implict this would be null.
12807 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12809 * expression.cs (Invocation.EmitCall): If the method is not
12810 virtual, do not emit a CallVirt to it, use Call.
12812 * typemanager.cs (GetFullNameSignature): Improve the method to
12813 cope with ".ctor" and replace it with the type name.
12815 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12816 as an argument the ConstructorBuilder where it is being defined,
12817 to catch the recursive constructor invocations.
12819 2004-03-16 Martin Baulig <martin@ximian.com>
12821 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12822 ConstructedType, call ResolveType() on it to get the type rather
12823 than just using `expr.Type'.
12825 2004-03-16 Martin Baulig <martin@ximian.com>
12827 * generics.cs (ConstructedType.GetMemberAccess): Take the
12828 EmitContext instead on the TypeExpr and use
12829 ec.TypeContainer.CurrentType/ec.ContainerType.
12831 2004-03-16 Martin Baulig <martin@ximian.com>
12833 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12834 parameters before aliases.
12836 2004-03-16 Martin Baulig <martin@ximian.com>
12838 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12839 New oublic function; checks whether two generic instances may become
12840 equal under some instantiations (26.3.1).
12842 * class.cs (TypeContainer.Define): Call
12843 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12846 2004-03-16 Martin Baulig <martin@ximian.com>
12848 * class.cs (TypeContainer.GetClassBases): Moved
12849 Error_TypeParameterAsBase() here and also check whether the base
12850 class is not an attribute.
12852 2004-03-16 Martin Baulig <martin@ximian.com>
12854 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12856 2004-03-16 Martin Baulig <martin@ximian.com>
12858 * class.cs (Error_TypeParameterAsBase): Use correct error number
12861 2004-03-16 Martin Baulig <martin@ximian.com>
12863 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12866 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12869 2004-03-15 Martin Baulig <martin@ximian.com>
12871 * typemanager.cs (TypeManager.GetFullName): New public method.
12872 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12873 argument; only return members with the correct number of type
12875 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12876 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12877 whether the number of type arguments matches.
12879 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12880 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12882 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12883 field; it's set by the protected .ctor when we're actually a
12884 GenericMemberAccess.
12885 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12886 arguments and pass it to MemberLookupFinal ().
12888 * ecore.cs (Expression.MemberLookup): Added `int
12889 num_type_arguments' argument; only return members with the correct
12890 number of type arguments.
12891 (Expression.MemberLookupFailed): Check whether the MemberLookup
12892 failed because we did not have the correct number of type
12893 arguments; report CS0305 in this case.
12895 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12896 `e.ResolveAsTypeTerminal()' already did so.
12898 2004-03-15 Martin Baulig <martin@ximian.com>
12900 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12901 we're a ConstructedType; in this case, the caller must report an
12902 error (for instance CS0131).
12904 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12905 (TypeArguments.Resolve): Actually report errors here.
12907 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12909 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12910 `set_indexer_name' to the pending bits (one per type).
12912 We fixed a bug today that was picking the wrong method to
12913 override, since for properties the existing InterfaceMethod code
12914 basically ignored the method name. Now we make sure that the
12915 method name is one of the valid indexer names.
12917 2004-03-15 Martin Baulig <martin@ximian.com>
12919 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12920 for generic instances.
12922 2004-03-13 Martin Baulig <martin@ximian.com>
12924 * class.cs (TypeContainer.DefineType): Call
12925 TypeManager.AddUserType() immediately after creating the
12926 TypeBuilder; pass all type parameters when creating the
12929 * decl.cs (DeclSpace.FindNestedType): New public method.
12930 (DeclSpace.FindType): Added `int num_type_args' argument; only
12931 return types with the correct number of type parameters.
12932 (DeclSpace.CountTypeParams): New public property.
12934 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
12935 the number of type parameters; defaults to zero.
12937 * generic.cs (TypeArguments.Count): New public property.
12938 (ConstructedType.DoResolveAsTypeStep): First call
12939 ds.FindNestedType() to find out whether we're nested in the
12940 current generic type; in this case, we inherit all type parameters
12941 from the current class.
12943 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
12944 num_type_args' argument.
12945 (RootContext.LookupType): Added overloaded version which takes the
12946 number of type arguments; only return types with the correct
12947 number of type arguments.
12949 * typemanager.cs (TypeManager.CheckGeneric): New public function;
12950 checks whether `Type t' has `int num_type_args'.
12952 2004-03-13 Martin Baulig <martin@ximian.com>
12954 * generic.cs (GenericMethod.DefineType): New method; calls
12955 DefineType() on all the type parameters.
12957 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
12958 (MethodData.Define): If we're a generic method, call
12959 GenericMethod.DefineType() to define the type parameters.
12961 2004-03-10 Martin Baulig <martin@ximian.com>
12963 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
12964 instead of IsAssignableFrom.
12966 2004-03-10 Martin Baulig <martin@ximian.com>
12968 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
12970 * support.cs (ParameterData.HasArrayParameter): New property.
12971 (ReflectionParameters.ctor): Take a MethodBase instead of a
12972 ParameterInfo[]. If we have any type parameters, get the generic
12973 method definition and ask it whether we have variable arguments.
12975 2004-02-26 Miguel de Icaza <miguel@ximian.com>
12977 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
12978 routines to check if a type is an enumerable/enumerator allow
12979 classes that implement the IEnumerable or IEnumerator interfaces.
12981 * class.cs (Property, Operator): Implement IIteratorContainer, and
12982 implement SetYields.
12984 (Property.Define): Do the block swapping for get_methods in the
12985 context of iterators. We need to check if Properties also
12986 include indexers or not.
12988 (Operator): Assign the Block before invoking the
12989 OperatorMethod.Define, so we can trigger the Iterator code
12992 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
12993 Property and Operator classes are not created when we parse the
12994 declarator but until we have the block completed, so we use a
12995 singleton SimpleIteratorContainer.Simple to flag whether the
12996 SetYields has been invoked.
12998 We propagate this setting then to the Property or the Operator to
12999 allow the `yield' to function.
13001 2004-02-25 Marek Safar <marek.safar@seznam.cz>
13003 * codegen.cs: Implemented attribute support for modules.
13004 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
13005 Assembly/Module functionality.
13007 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
13008 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
13009 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
13011 2004-02-16 Marek Safar <marek.safar@seznam.cz>
13013 * interface.cs (FindMembers): The operation is performed on all base
13014 interfaces and not only on the first. It is required for future CLS Compliance patch.
13016 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
13018 * statement.cs, codegen.cs:
13019 This patch deals with patterns such as:
13021 public class List : IEnumerable {
13023 public MyEnumerator GetEnumerator () {
13024 return new MyEnumerator(this);
13027 IEnumerator IEnumerable.GetEnumerator () {
13031 public struct MyEnumerator : IEnumerator {
13036 Before, there were a few things we did wrong:
13037 1) we would emit callvirt on a struct, which is illegal
13038 2) we emited ldarg when we needed to emit ldarga
13039 3) we would mistakenly call the interface methods on an enumerator
13040 type that derived from IEnumerator and was in another assembly. For example:
13042 public class MyEnumerator : IEnumerator
13044 Would have the interface methods called, even if there were public impls of the
13045 method. In a struct, this lead to invalid IL code.
13047 2004-02-11 Marek Safar <marek.safar@seznam.cz>
13049 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
13052 * delegate.cs (Define): Fixed crash when delegate type is undefined.
13054 2004-02-11 Miguel de Icaza <miguel@ximian.com>
13056 * cs-parser.jay: Fix small regression: we were not testing V2
13057 compiler features correctly.
13059 * interface.cs: If the emit context is null, then create one
13061 2004-02-09 Marek Safar <marek.safar@seznam.cz>
13063 * decl.cs (GetSignatureForError): New virtual method to get full name
13064 for error messages.
13066 * attribute.cs (IAttributeSupport): New interface for attribute setting.
13067 Now it is possible to rewrite ApplyAttributes method to be less if/else.
13069 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
13070 Duplicated members and code in these classes has been removed.
13071 Better encapsulation in these classes.
13073 2004-02-07 Miguel de Icaza <miguel@ximian.com>
13075 * assign.cs (Assign.DoResolve): When dealing with compound
13076 assignments, there is a new rule in ECMA C# 2.4 (might have been
13077 there before, but it is documented here) that states that in:
13081 If b is of type int, and the `op' is a shift-operator, then the
13082 above is evaluated as:
13086 * expression.cs (Binary.ResolveOperator): Instead of testing for
13087 int/uint/long/ulong, try to implicitly convert to any of those
13088 types and use that in pointer arithmetic.
13090 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
13091 method to print information for from the type, not from the
13092 null-method we were given.
13094 2004-02-01 Duncan Mak <duncan@ximian.com>
13096 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
13097 parsing for cmd, fixes bug #53694.
13099 2004-02-04 Marek Safar <marek.safar@seznam.cz>
13101 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
13102 in the member name duplication tests. Property and operator name duplication
13103 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
13105 2004-02-03 Marek Safar <marek.safar@seznam.cz>
13107 * interface.cs (PopulateMethod): Fixed crash when interface method
13108 returns not existing type (error test cs0246-3.cs).
13110 2004-02-02 Ravi Pratap M <ravi@ximian.com>
13112 * cs-parser.jay (interface_accessors): Re-write actions to also
13113 store attributes attached to get and set methods. Fix spelling
13116 (inteface_property_declaration): Modify accordingly.
13118 (InterfaceAccessorInfo): New helper class to store information to pass
13119 around between rules that use interface_accessors.
13121 * interface.cs (Emit): Apply attributes on the get and set
13122 accessors of properties and indexers too.
13124 * attribute.cs (ApplyAttributes): Modify accordingly to use the
13125 right MethodBuilder when applying attributes to the get and set accessors.
13127 2004-01-31 Miguel de Icaza <miguel@ximian.com>
13129 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
13131 2004-01-26 Miguel de Icaza <miguel@ximian.com>
13133 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
13135 2004-01-25 Miguel de Icaza <miguel@ximian.com>
13137 * cs-parser.jay: Remove YIELD token, instead use the new grammar
13138 changes that treat `yield' specially when present before `break'
13139 or `return' tokens.
13141 * cs-tokenizer.cs: yield is no longer a keyword.
13143 2004-01-23 Marek Safar <marek.safar@seznam.cz>
13145 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
13146 setting for default constructors.
13147 For default constructors are almost every time set wrong Modifier. The
13148 generated IL code has been alright. But inside mcs this values was
13149 wrong and this was reason why several of my CLS Compliance tests
13152 2004-02-27 Martin Baulig <martin@ximian.com>
13154 * generics.cs (ConstructedType.ResolveType): Make the nested type
13155 stuff actually work.
13157 2004-02-25 Martin Baulig <martin@ximian.com>
13159 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
13160 property; returns the type parameters just from the current type,
13161 ie. with the ones from outer classes.
13162 (DeclSpace.LookupGeneric): First search in the current class, then
13164 (DeclSpace.initialize_type_params): When hiding a type parameter
13165 from an outer class, put it into the `type_param_list' anyways.
13167 * expression.cs (MemberAccess.expr): Made this field protected.
13169 * class.cs (TypeContainer.Define): The `CurrentType' just contains
13170 the type parameters from the current class.
13172 * generic.cs (ConstructedType.ResolveType): Support nested generic
13173 types by taking the type parameters which we inherit from outer
13174 classes into account.
13175 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
13176 support for nested generic types.
13178 2004-02-23 Martin Baulig <martin@ximian.com>
13180 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
13181 field and check whether we're nested inside a generic type.
13182 (DeclSpace.ResolveType): If we're resolving to a generic type
13183 definition, create a ConstructedType and return its resolved type.
13184 (DeclSpace.initialize_type_params): New private method;
13185 initializes the `type_param_list' field from the type parameters
13186 from this and all enclosing classes.
13187 (DeclSpace.TypeParameters): Call initialize_type_params() unless
13188 we're already initialized.
13190 2004-02-23 Martin Baulig <martin@ximian.com>
13192 * class.cs (Method.Define): Create the generic method before
13193 calling DoDefine().
13194 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
13195 the TypeContainer one); we use this for generic methods.
13197 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
13198 parent's TypeBuilder.
13200 2004-02-18 Martin Baulig <martin@ximian.com>
13202 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
13203 to check for equality.
13205 2004-02-05 Martin Baulig <martin@ximian.com>
13207 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
13208 `ec.TypeContainer.CurrentType', use it instead of
13209 `ec.ContainerType' to check whether we're in the type's ctor.
13211 2004-01-29 Martin Baulig <martin@ximian.com>
13213 * expression.cs (Invocation.DoResolve): If we're a
13214 `ConstructedType', then we're actually a generic method, so
13215 rewrite the expr as a GenericMemberAccess.
13217 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
13218 here; manually parse it into a string.
13220 2004-01-28 Martin Baulig <martin@ximian.com>
13222 * typemanager.cs (TypeManager.IsEqual): New static method.
13223 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
13224 check for equality instead of using `=='.
13226 2004-01-26 Martin Baulig <martin@ximian.com>
13228 * decl.cs (DeclSpace.CurrentType): New public field.
13230 * expression.cs (This.ResolveBase): If we have an
13231 `ec.TypeContainer.CurrentType', use it instead of
13232 `ec.ContainerType'.
13234 * class.cs (TypeContainer.DefineType): If we're a generic type,
13235 create the `CurrentType' (unresolved).
13236 (TypeContainer.GenericType): New private field.
13237 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
13238 it and store it in `GenericType' before creating the MemberCache.
13239 (TypeContainer.GetMembers): If we have a `GenericType', call
13240 TypeManager.FindMembers() on it.
13242 * interface.cs (Interface.GenericType): New private field.
13243 (Interface.DefineType): If we're a generic type, create the
13244 `CurrentType' (unresolved).
13245 (Interface.DefineMembers): If we have a `CurrentType', resolve it
13246 and store it in `GenericType' before creating the MemberCache.
13247 (Interface.GetMembers): If we have a `GenericType', call
13248 TypeManager.FindMembers() on it.
13250 2004-01-22 Martin Baulig <martin@ximian.com>
13252 * cs-parser.jay (namespace_or_type_name): Return an Expression,
13253 not a QualifiedIdentifier. This is what `type_name_expression'
13254 was previously doing.
13255 (type_name_expression): Removed; the code is now in
13256 `namespace_or_type_name'.
13257 (qualified_identifier): Removed, use `namespace_or_type_name'
13259 (QualifiedIdentifier): Removed this class.
13261 2004-01-22 Martin Baulig <martin@ximian.com>
13263 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
13264 not a string as alias name.
13266 2004-01-21 Miguel de Icaza <miguel@ximian.com>
13268 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
13269 #52730 bug, and instead compute correctly the need to use a
13270 temporary variable when requesting an address based on the
13271 static/instace modified of the field and the constructor.
13273 2004-01-21 Martin Baulig <martin@ximian.com>
13275 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
13276 class and namespace before looking up aliases. Fixes #52517.
13278 2004-01-21 Martin Baulig <martin@ximian.com>
13280 * flowanalysis.cs (UsageVector.Merge): Allow variables being
13281 assinged in a 'try'; fixes exception4.cs.
13283 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13284 * class.cs : Implemented parameter-less constructor for TypeContainer
13286 * decl.cs: Attributes are now stored here. New property OptAttributes
13288 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
13290 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
13292 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13294 * typemanager.cs (CSharpSignature): Now reports also inner class name.
13295 (CSharpSignature): New method for indexer and property signature.
13297 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13299 * pending.cs (IsVirtualFilter): Faster implementation.
13301 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13303 * typemanager.cs: Avoid inclusion of same assembly more than once.
13305 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13307 * cs-parser.jay: Fixed problem where the last assembly attribute
13308 has been applied also to following declaration (class, struct, etc.)
13310 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13312 * class.cs: Added error CS0538, CS0539 reporting.
13313 Fixed crash on Microsoft runtime when field type is void.
13315 * cs-parser.jay: Added error CS0537 reporting.
13317 * pending.cs: Added error CS0535 reporting.
13318 Improved error report for errors CS0536, CS0534.
13320 2004-01-20 Miguel de Icaza <miguel@ximian.com>
13322 Merge a few bits from the Anonymous Method MCS tree.
13324 * statement.cs (ToplevelBlock): New class for toplevel methods,
13325 will hold anonymous methods, lifted variables.
13327 * cs-parser.jay: Create toplevel blocks for delegates and for
13328 regular blocks of code.
13330 2004-01-20 Martin Baulig <martin@ximian.com>
13332 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
13333 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
13334 and `NeedExplicitReturn'; added `IsLastStatement'.
13335 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
13336 have a `ReturnLabel' or we're not unreachable.
13338 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
13339 child's reachability; don't just override ours with it. Fixes
13340 #58058 (lluis's example).
13341 (FlowBranching): Added public InTryOrCatch(), InCatch(),
13342 InFinally(), InLoop(), InSwitch() and
13343 BreakCrossesTryCatchBoundary() methods.
13345 * statement.cs (Return): Do all error checking in Resolve().
13346 Unless we are the last statement in a top-level block, always
13347 create a return label and jump to it.
13348 (Break, Continue): Do all error checking in Resolve(); also make
13349 sure we aren't leaving a `finally'.
13350 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
13351 statement in a top-level block.
13352 (Block.Flags): Added `IsDestructor'.
13353 (Block.IsDestructor): New public property.
13355 2004-01-20 Martin Baulig <martin@ximian.com>
13357 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
13359 2004-01-20 Martin Baulig <martin@ximian.com>
13361 * statement.cs (Statement.ResolveUnreachable): New public method.
13362 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
13363 (Block.Resolve): Resolve unreachable statements.
13365 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13367 * expression.cs: We need to fix the case where we do
13368 not have a temp variable here.
13370 * assign.cs: Only expression compound assignments need
13371 temporary variables.
13373 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13375 * flowanalysis.cs: Reduce memory allocation in a few ways:
13376 - A block with no variables should not allocate a bit
13378 - A method with no out parameters does not need any tracking
13379 for assignment of the parameters, so we need not allocate
13382 public readonly Type[] VariableTypes;
13383 public readonly string[] VariableNames;
13384 Are redundant. The data is already stored in the variable
13385 map, so we need not allocate another array for it.
13386 - We need to add alot of checks for if (params | locals) == null
13387 due to the first two changes.
13389 2004-01-18 Miguel de Icaza <miguel@ximian.com>
13391 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
13392 implement IMemoryLocation, we store a copy on a local variable and
13393 take the address of it. Patch from Benjamin Jemlich
13395 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
13396 to use a special "type_name_expression" rule which reduces the
13397 number of "QualifiedIdentifier" classes created, and instead
13398 directly creates MemberAccess expressions.
13400 2004-01-17 Miguel de Icaza <miguel@ximian.com>
13402 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
13403 that fixes #52853. Null literal assignment to ValueType
13405 * class.cs (MethodData.Emit): Instead of checking the name of the
13406 method to determine if its a destructor, create a new derived
13407 class from Method called Destructor, and test for that.
13409 * cs-parser.jay: Create a Destructor object instead of a Method.
13411 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
13415 2004-01-16 Miguel de Icaza <miguel@ximian.com>
13417 * expression.cs (Binary.ResolveOperator): Perform an implicit
13418 conversion from MethodGroups to their delegate types on the
13419 Addition operation.
13421 * delegate.cs: Introduce a new class DelegateCreation that is the
13422 base class for `NewDelegate' and `ImplicitDelegateCreation',
13423 factor some code in here.
13425 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
13426 conversion from MethodGroups to compatible delegate types.
13428 * ecore.cs (Expression.Resolve): Do not flag error 654
13429 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
13430 we allow conversions from MethodGroups to delegate types now.
13432 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
13433 assignments in v2 either.
13435 2004-01-10 Miguel de Icaza <miguel@ximian.com>
13437 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
13438 static read-only fields in ctors.
13440 Applied patch from Benjamin Jemlich
13442 * expression.cs (UnaryMutator): Avoid leaking local variables.
13444 2004-01-09 Miguel de Icaza <miguel@ximian.com>
13446 * cs-tokenizer.cs (IsCastToken): Allow the various native types
13447 here to return true, as they can be used like this:
13449 (XXX) int.MEMBER ()
13451 Fixed 49836 and all the other dups
13453 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
13455 * driver.cs: Implement /win32res and /win32icon.
13457 2004-01-08 Miguel de Icaza <miguel@ximian.com>
13459 * cs-parser.jay: Add a rule to improve error handling for the
13460 common mistake of placing modifiers after the type.
13462 2004-01-07 Miguel de Icaza <miguel@ximian.com>
13464 * cs-parser.jay (interface_event_declaration): Catch
13465 initialization of events on interfaces, and report cs0068
13467 * cs-parser.jay (interface_event_declaration): Catch
13468 initialization of events.
13470 * ecore.cs: Better report missing constructors.
13472 * expression.cs (Binary.ResolveOperator): My previous bug fix had
13473 the error reporting done in the wrong place. Fix.
13475 * expression.cs (Binary.ResolveOperator): Catch the
13476 operator + (E x, E y) error earlier, and later allow for implicit
13477 conversions in operator +/- (E e, U x) from U to the underlying
13480 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
13481 52596, if the container class is abstract, the default constructor
13482 is protected otherwise its public (before, we were always public).
13484 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
13487 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
13488 Jemlich that fixes bug #52597, MCS was generating invalid code for
13489 idisposable structs. Thanks to Ben for following up with this
13492 2004-01-06 Miguel de Icaza <miguel@ximian.com>
13494 * driver.cs: Allow assemblies without code to be generated, fixes
13497 2004-01-07 Nick Drochak <ndrochak@gol.com>
13499 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
13501 2004-01-05 Miguel de Icaza <miguel@ximian.com>
13503 * cs-parser.jay: Add rules to improve error reporting if fields or
13504 methods are declared at the namespace level (error 116)
13506 * Add rules to catch event add/remove
13508 2004-01-04 David Sheldon <dave-mono@earth.li>
13510 * expression.cs: Added matching ")" to error message for
13513 2004-01-03 Todd Berman <tberman@gentoo.org>
13515 * ecore.cs, attribute.cs:
13516 Applying fix from #52429.
13518 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13520 * ecore.cs, expression.cs, statement.cs:
13521 Total rewrite of how we handle branching. We
13522 now handle complex boolean expressions with fewer
13523 jumps. As well if (x == 0) no longer emits a ceq.
13525 if (x is Foo) is much faster now, because we generate
13528 Overall, we get a pretty big improvement on our benchmark
13529 tests. The code we generate is smaller and more readable.
13531 I did a full two-stage bootstrap. The patch was reviewed
13532 by Martin and Miguel.
13534 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13536 * cs-parser.jay: Make primary_expression not take a QI.
13537 we dont need this because the member_access rule covers
13538 us here. So we replace the rule with just IDENTIFIER.
13540 This has two good effects. First, we remove a s/r conflict.
13541 Second, we allocate many fewer QualifiedIdentifier objects.
13543 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13545 * attribute.cs: Handle MarshalAs attributes as pseudo, and
13546 set the correct information via SRE. This prevents
13547 hanging on the MS runtime. Fixes #29374.
13549 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13551 * convert.cs: correctly handle conversions to value types
13552 from Enum and ValueType as unboxing conversions.
13554 Fixes bug #52569. Patch by Benjamin Jemlich.
13556 2004-01-02 Ravi Pratap <ravi@ximian.com>
13558 * expression.cs (BetterConversion): Prefer int -> uint
13559 over int -> ulong (csc's behaviour). This fixed bug #52046.
13561 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
13563 * decl.cs (MemberCache.FindMembers): now returns a
13566 * typemanager.cs: In general, go with with ^^.
13567 (CopyNewMethods): take an IList.
13568 (RealMemberLookup): Only allocate an arraylist
13569 if we copy from two sets of methods.
13571 This change basically does two things:
13572 1) Fewer array lists allocated due to CopyNewMethods.
13573 2) the explicit cast in MemberList costed ALOT.
13575 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13577 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13578 a hashtable to avoid needless string allocations when an identifier is
13579 used more than once (the common case).
13581 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13583 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13584 is broken, it will not return anything. So, we
13585 have to use the information we have in mcs to
13588 * typemanager.cs: Add a cache for GetInterfaces,
13589 since this will now be used more often (due to ^^)
13591 (GetExplicitInterfaces) New method that gets the
13592 declared, not effective, interfaces on a type
13593 builder (eg, if you have interface IFoo, interface
13594 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13597 This patch makes MCS able to bootstrap itself on
13600 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13602 * expression.cs: Remove the Nop's that Miguel put
13605 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13607 * report.cs, codegen.cs: Give the real stack trace to
13608 the error when an exception is thrown.
13610 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13612 * decl.cs: only allocate hashtables for ifaces if
13615 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13617 * expression.cs: fix the error from cs0121-2.cs
13618 (a parent interface has two child interfaces that
13619 have a function with the same name and 0 params
13620 and the function is called through the parent).
13622 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13624 * class.cs, rootcontext.cs, typmanager.cs: do not
13627 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13629 * codegen.cs: remove stack for the ec flow branching.
13630 It is already a linked list, so no need.
13632 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13634 * Makefile: Allow custom profiler here.
13636 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13638 * typemanager.cs (LookupType):
13639 - Use a static char [], because split takes
13640 a param array for args, so it was allocating
13642 - Do not store true in a hashtable, it boxes.
13644 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13646 * flowanalysis.cs: bytify common enums.
13648 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13650 * modifiers.cs: Add a new set of flags for the
13651 flags allowed on explicit interface impls.
13652 * cs-parser.jay: catch the use of modifiers in
13653 interfaces correctly.
13654 * class.cs: catch private void IFoo.Blah ().
13656 All related to bug #50572.
13658 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13660 * decl.cs: Rewrite the consistant accessability checking.
13661 Accessability is not linear, it must be implemented in
13662 a tableish way. Fixes #49704.
13664 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13666 * expression.cs: Handle negation in a checked context.
13667 We must use subtraction from zero. Fixes #38674.
13669 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13671 * class.cs: Ignore static void main in DLLs.
13672 * rootcontext.cs: Handle the target type here,
13673 since we are have to access it from class.cs
13674 * driver.cs: account for the above.
13676 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13678 * report.cs: Give line numbers and files if available.
13680 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13682 * driver.cs: Implement /addmodule.
13684 * typemanager.cs: Change 'modules' field so it now contains Modules not
13687 2003-12-20 Martin Baulig <martin@ximian.com>
13689 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13690 (FieldBase.IsAssigned): Removed this field.
13691 (FieldBase.SetAssigned): New public method.
13692 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13694 2003-12-20 Martin Baulig <martin@ximian.com>
13696 * expression.cs (LocalVariableReference.DoResolve): Don't set
13697 `vi.Used' if we're called from DoResolveLValue().
13699 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13700 returns the usage vector it just merged into the current one -
13701 pass this one to UsageWarning().
13702 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13703 of the `EmitContext', don't call this recursively on our children.
13705 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13707 * driver.cs: Implement /target:module.
13709 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13711 * support.cs (CharArrayHashtable): New helper class.
13713 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13714 char arrays, not strings, so we can avoid creating a string in
13715 consume_identifier if the identifier is a keyword.
13717 2003-12-16 Martin Baulig <martin@ximian.com>
13719 * statement.cs (LocalInfo.Assigned): Removed this property.
13720 (LocalInfo.Flags): Removed `Assigned'.
13721 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13722 and uses flow analysis.
13723 (Block.UsageWarning): Made this method private.
13724 (Block.Resolve): Call UsageWarning() if appropriate.
13726 * expression.cs (LocalVariableReference.DoResolve): Always set
13727 LocalInfo.Used here.
13729 2003-12-13 Martin Baulig <martin@ximian.com>
13731 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13732 any value here; we're now using flow analysis to figure out
13733 whether a statement/block returns a value.
13735 2003-12-13 Martin Baulig <martin@ximian.com>
13737 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13739 (FlowBranching.MergeFinally): Don't call
13740 `branching.CheckOutParameters()' here, this is called in
13742 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13743 when adding the `finally' vector.
13745 2003-12-13 Martin Baulig <martin@ximian.com>
13748 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13749 actually work and also fix #48962.
13751 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13753 * decl.cs: Do not check System.Object for nested types,
13754 since we know it does not have any. Big bang for buck:
13757 Run 1: 8.35 seconds
13758 Run 2: 8.32 seconds
13759 corlib: 17.99 seconds
13761 Run 1: 8.17 seconds
13762 Run 2: 8.17 seconds
13763 corlib: 17.39 seconds
13765 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13767 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13768 time we are returning 0 members, so we save alot here.
13770 2003-12-11 Martin Baulig <martin@ximian.com>
13772 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13773 `MergeChild()', also just take the `FlowBranching' as argument;
13774 call Merge() on it and return the result.
13775 (FlowBranching.Merge): We don't need to do anything if we just
13778 2003-12-11 Martin Baulig <martin@ximian.com>
13780 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13781 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13782 Maurer for this idea.
13784 2003-12-11 Martin Baulig <martin@ximian.com>
13786 * flowanalysis.cs (MergeResult): This class is now gone; we now
13787 use the `UsageVector' for this. The reason for this is that if a
13788 branching just has one sibling, we don't need to "merge" them at
13789 all - that's the next step to do.
13790 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13793 2003-12-11 Martin Baulig <martin@ximian.com>
13795 Reworked flow analyis and made it more precise and bug-free. The
13796 most important change is that we're now using a special `Reachability'
13797 class instead of having "magic" meanings of `FlowReturns'. I'll
13798 do some more cleanups and optimizations and also add some more
13799 documentation this week.
13801 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13802 largely reworked this class.
13803 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13804 the new `Reachability' class instead of having "magic" values here.
13805 (FlowBranching): We're now using an instance of `Reachability'
13806 instead of having separate `Returns', `Breaks' etc. fields.
13808 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13809 based on flow analysis; ignore the return value of block.Emit ().
13811 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13813 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13814 if they are private.
13816 2003-12-09 Martin Baulig <martin@ximian.com>
13818 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13819 call them directly on the UsageVector.
13821 2003-12-09 Martin Baulig <martin@ximian.com>
13823 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13824 Changed return type from `FlowReturns' to `Reachability'.
13826 2003-12-09 Martin Baulig <martin@ximian.com>
13828 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13829 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13830 `Reachable' fields with a single `Reachability' one.
13832 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13834 * class.cs (FindMembers): Remove foreach's.
13839 Run 1: 8.74 seconds
13840 Run 2: 8.71 seconds
13843 Run 1: 8.64 seconds
13844 Run 2: 8.58 seconds
13847 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13852 This patch does a few things:
13853 1. EmptyStatement is now a singleton, so it is never reallocated.
13854 2. All blah is EmptyStatement constructs have been changed to
13855 blah == EmptyStatement.Value, which is much faster and valid
13856 now that EmptyStatement is a singleton.
13857 3. When resolving a block, rather than allocating a new array for
13858 the non-empty statements, empty statements are replaced with
13859 EmptyStatement.Value
13860 4. Some recursive functions have been made non-recursive.
13861 Mainly the performance impact is from (3), however (1) and (2) are needed for
13862 this to work. (4) does not make a big difference in normal situations, however
13863 it makes the profile look saner.
13868 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13869 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13870 Total memory allocated: 56397 KB
13873 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13874 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13875 Total memory allocated: 55666 KB
13877 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13879 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13880 than the hashtable in a hashtable version
13882 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13883 we always end up concating a string. This results in a huge perf
13884 loss, because many strings have to be tracked by the GC. In this
13885 patch, we first use a hashtable that works with two keys, so that
13886 the strings do not need to be concat'ed.
13890 Run 1: 8.74 seconds
13891 Run 2: 8.71 seconds
13894 Run 1: 8.65 seconds
13895 Run 2: 8.56 seconds
13897 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13899 * Makefile: Add a new target `do-time' that does a quick and simple
13900 profile, leaving easy to parse output.
13902 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13904 * codegen.cs (Init): Create the dynamic assembly with
13905 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13907 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13909 * support.cs: Make the PtrHashtable use only one
13910 instance of its comparer.
13912 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13914 * typemanager.cs: Fix lookup of GetNamespaces.
13916 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13918 * expression.cs: Removed redundant line.
13920 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
13921 ArrayLists, use for loops with bounds.
13923 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
13926 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
13927 arraylists, use for loop with bounds.
13929 The above three changes give us a 0.071 second performance
13930 improvement out of 3.294 seconds down to 3.223. On my machine
13931 the above changes reduced the memory usage by 1,387 KB during
13932 compiler bootstrap.
13934 * cs-parser.jay (QualifiedIdentifier): New class used to represent
13935 QualifiedIdentifiers. Before we created a new string through
13936 concatenation, and mostly later on, the result would be
13937 manipulated by DecomposeQI through string manipulation.
13939 This reduced the compiler memory usage for bootstrapping from
13940 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
13941 compile times in 0.05 seconds.
13943 2003-11-28 Dick Porter <dick@ximian.com>
13945 * support.cs: Do string compares with the Invariant culture.
13953 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
13954 the comparison is done with the Invariant culture.
13956 2003-11-27 Miguel de Icaza <miguel@ximian.com>
13958 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
13959 GetEnumerator method.
13961 (ProbeCollectionType): Iterate starting at the most specific type
13962 upwards looking for a GetEnumerator
13964 * expression.cs: Shift count can be up to 31 for int/uint and 63
13967 2003-11-26 Miguel de Icaza <miguel@ximian.com>
13969 * statement.cs (Block.LookupLabel): Also look for the label on the
13970 children blocks. Use a hash table to keep track of visited
13973 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
13974 we actually did transform the other operand, otherwise fall back
13975 to the common codepath that casts to long.
13977 * cs-tokenizer.cs: Use the same code pattern as the int case.
13978 Maybe I should do the parsing myself, and avoid depending on the
13979 Parse routines to get this done.
13981 2003-11-25 Miguel de Icaza <miguel@ximian.com>
13983 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13984 which fixes bug 51347. This time test it.
13986 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
13987 attributes for example can not tell the difference between these.
13988 The difference was only a syntax feature of the language.
13990 * attribute.cs: Apply attributes to delegates.
13992 * delegate.cs: Call the apply attributes method.
13994 2003-11-24 Miguel de Icaza <miguel@ximian.com>
13996 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
13997 comparing 0 vs Byte.MinValue, not the value
13999 (ImplicitConversionRequired): When reporting a conversion error,
14000 use error 31 to print out the constant error instead of the
14003 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
14004 which fixes bug 51347.
14006 2003-11-22 Miguel de Icaza <miguel@ximian.com>
14008 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
14009 which fixes the -warnaserror command line option.
14011 2003-11-21 Miguel de Icaza <miguel@ximian.com>
14013 * cfold.cs (DoNumericPromotions): During constant folding of
14014 additions on UIntConstant, special case intconstants with
14015 IntConstants like we do on the expression binary operator.
14017 2003-11-12 Miguel de Icaza <miguel@ximian.com>
14019 * convert.cs (ImplicitReferenceConversion): We were missing a case
14020 (System.Enum are not value types or class types, so we need to
14021 classify them separatedly).
14023 * driver.cs: We do not support error 2007.
14025 2003-11-12 Jackson Harper <jackson@ximian.com>
14027 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
14028 system directory. Also use the full file name so users can
14029 libraries names mscorlib-o-tron.dll in a non system dir.
14031 2004-01-04 David Sheldon <dave-mono@earth.li>
14033 * expression.cs: Added matching ")" to error message for CS0077.
14035 2003-12-19 Martin Baulig <martin@ximian.com>
14037 * typemanager.cs (TypeManager.IsEqualGenericType): New public
14038 static method; see documentation in the method.
14039 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
14041 * convert.cs (Convert.ImplicitReferenceConversion,
14042 Convert.ImplicitReferenceConversionExists): Add support for
14043 generic type declarations; see gen-36.cs.
14045 2003-12-19 Martin Baulig <martin@ximian.com>
14047 * pending.cs (Pending.InterfaceMethod): Use
14048 `Type.IsAssignableFrom()' instead of `=='.
14050 2003-12-18 Martin Baulig <martin@ximian.com>
14052 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
14055 * convert.cs (Convert.ImplicitStandardConversionExists): Use
14056 `expr_type.Equals (target_type)' instead of `=='.
14058 2003-12-08 Martin Baulig <martin@ximian.com>
14060 * generics.cs (Constraints.Types): Removed.
14061 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
14063 (Constraints.ResolveTypes): New public method; resolves the
14064 TypeExpr's to Type's.
14065 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
14066 longer takes the constraints.
14067 (TypeParameter.DefineMethod): Likewise.
14068 (TypeParameter.DefineType): New public method. Calls
14069 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
14072 2003-12-08 Martin Baulig <martin@ximian.com>
14074 * convert.cs (Convert.ImplicitConversionStandard): Use
14075 `expr_type.Equals (target_type)' instead of `=='.
14077 2003-12-08 Martin Baulig <martin@ximian.com>
14079 * typemanager.cs (TypeManager.GetReferenceType): Call
14080 `Type.MakeByRefType ()'.
14082 2003-12-08 Martin Baulig <martin@ximian.com>
14084 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
14085 just has some special meaning in some situations. For instance,
14086 it is allowed to use `where' as the name of a variable etc.
14088 2003-12-04 Martin Baulig <martin@ximian.com>
14090 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14091 `Type.MakeArrayType()' for array types.
14093 2003-11-18 Miguel de Icaza <miguel@ximian.com>
14095 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
14098 (SizeOf.DoResolve): assign the `type_queried' field. This gets
14101 2003-11-16 Martin Baulig <martin@ximian.com>
14103 * codegen.cs (EmitContext.IsGeneric): Removed.
14105 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
14106 ResolveGeneric() on the DeclSpace.
14108 2003-11-16 Martin Baulig <martin@ximian.com>
14110 * generic.cs (TypeArguments.Resolve):
14111 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
14112 `ResolveType()' on it to get the Type.
14114 2003-11-15 Martin Baulig <martin@ximian.com>
14116 * generic.cs (ConstructedType.GetInterfaces): Override this.
14118 2003-11-14 Martin Baulig <martin@ximian.com>
14120 * interface.cs (Interface.DefineType): Define all type parameters
14121 before adding the interfaces we inherit.
14123 2003-11-11 Martin Baulig <martin@ximian.com>
14125 * generic.cs (ConstructedType.ResolveType): Always call
14126 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
14128 2003-11-10 Martin Baulig <martin@ximian.com>
14130 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
14131 (TypeManager.InitCoreTypes): Initialize them here, but instead of
14132 calling `ResolveType()' on them, directly assign their `Type'.
14134 2003-11-08 Martin Baulig <martin@ximian.com>
14136 * generic.cs (ConstructedType): Override `IsClass' etc.
14138 2003-11-08 Martin Baulig <martin@ximian.com>
14140 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
14141 return value and the `out parent' parameter.
14142 (TypeContainer.DefineType): Moved the CS0644 check into
14143 GetClassBases(). Don't pass the interface types to the
14144 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
14145 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
14147 * ecore.cs (TypeExpr.IsAttribute): New property.
14148 (TypeExpr.GetInterfaces): New method.
14150 * interface.cs (Interface.GetInterfaceTypeByName): Return a
14151 TypeExpr instead of a Type.
14152 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
14153 (Interface.DefineType): Don't pass the interface types to the
14154 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
14155 them later and then call `TypeBulider.AddInterfaceImplementation()'.
14157 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
14158 instead of a `Type[]'.
14159 (TypeManager.RegisterBuilder): Likewise.
14160 (TypeManager.AddUserInterface): Likewise.
14161 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
14162 `Type[]' and also return a `TypeExpr[]'.
14163 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
14165 2003-11-08 Martin Baulig <martin@ximian.com>
14167 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
14170 2003-11-08 Martin Baulig <martin@ximian.com>
14172 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
14173 TypeManager.ResolveExpressionTypes().
14175 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
14176 instead of an Expression.
14177 (TypeExpr): This is now an abstract base class for `TypeExpression'.
14178 (TypeExpression): New public class; formerly known as `TypeExpr'.
14180 * expression.cs (ComposedCast): Derive from TypeExpr.
14182 * typemanager.cs (TypeManager.system_*_expr): These are now
14183 TypExpr's instead of Expression's.
14184 (TypeManager.ResolveExpressionTypes): New public static function;
14185 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
14188 2003-11-06 Miguel de Icaza <miguel@ximian.com>
14190 * expression.cs (New.DoResolve): Do not dereference value that
14191 might be a null return.
14193 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
14194 sure that the constant value has the right type. Fixes an
14195 unreported bug, similar to 50425.
14197 * const.cs (Const.LookupConstantValue): Call
14198 ImplicitStandardConversionExists before doing a conversion to
14199 avoid havng the TypeManager.ChangeType do conversions.
14201 Reduced the number of casts used
14203 (Const.ChangeType): New routine to enable reuse of the constant
14204 type changing code from statement.
14206 * typemanager.cs (ChangeType): Move common initialization to
14207 static global variables.
14211 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
14212 every value type to go through, even if it was void. Fix that.
14214 * cs-tokenizer.cs: Use is_identifier_start_character on the start
14215 character of the define, and the is_identifier_part_character for
14216 the rest of the string.
14218 2003-11-05 Miguel de Icaza <miguel@ximian.com>
14220 * expression.cs (UnaryMutator.EmitCode): When I updated
14221 LocalVariableReference.DoResolve, I overdid it, and dropped an
14222 optimization done on local variable references.
14224 2003-11-04 Miguel de Icaza <miguel@ximian.com>
14226 * ecore.cs: Convert the return from Ldlen into an int.
14228 2003-10-20 Miguel de Icaza <miguel@ximian.com>
14230 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
14231 the accessibility, this is a special case for toplevel non-public
14232 classes (internal for instance).
14234 2003-10-20 Nick Drochak <ndrochak@gol.com>
14236 * ecore.cs: Fix typo and build. Needed another right paren.
14238 2003-10-19 Miguel de Icaza <miguel@ximian.com>
14240 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
14241 `internal' case regular and protected, but not allowing protected
14242 to be evaluated later. Bug 49840
14244 2003-10-15 Miguel de Icaza <miguel@ximian.com>
14246 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
14247 to kb.Nlast, and not the kb.nFirst to isolate the switch
14250 Extract the underlying type, so enumerations of long/ulong are
14251 treated like long/ulong.
14253 2003-10-14 Miguel de Icaza <miguel@ximian.com>
14255 * expression.cs (New): Overload the meaning of RequestedType to
14256 track the possible creation of the NewDelegate type, since
14257 DoResolve is invoked more than once for new constructors on field
14260 See bugs: #48800 and #37014
14262 * cs-parser.jay (declare_local_constants): Take an arraylist
14263 instead of a single constant.
14265 (local_constant_declaration): It should take a
14266 constant_declarators, not a constant_declarator. Fixes 49487
14268 * convert.cs: Fix error report.
14270 2003-10-13 Jackson Harper <jackson@ximian.com>
14272 * typemanager.cs (TypeToCoreType): Add float and double this fixes
14275 2003-11-03 Martin Baulig <martin@ximian.com>
14277 * expression.cs (ArrayAccess.GetStoreOpcode): Added
14278 `out bool has_type_arg'; if set, we need to pass the type to
14280 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
14281 Stelem_Any/Ldelem_Any for generic parameters.
14283 2003-11-02 Martin Baulig <martin@ximian.com>
14285 * expression.cs (Invocation.EmitCall): Use
14286 `TypeManager.IsValueType()' to check whether it's a value type.
14287 Don't set `struct_call' when calling a method on a type parameter.
14289 2003-11-02 Martin Baulig <martin@ximian.com>
14291 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
14292 and removed the TypeBuilder argument.
14294 * typemanager.cs (TypeManager.IsValueType): Return
14295 `t.IsGenericParameter || t.IsValueType'.
14297 2003-10-25 Martin Baulig <martin@ximian.com>
14299 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
14300 call ConstructedType.Resolve() on it.
14302 * generic.cs (ConstructedType.Resolve): Set `type' on success.
14304 2003-10-25 Martin Baulig <martin@ximian.com>
14306 * class.cs (TypeContainer.GetClassBases): Changed
14307 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
14308 CS8214 reporting here.
14309 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
14310 instead of a `Type' for our parent. In case of a recursive
14311 declaration (see tests/gen-23.cs for an example), our parent is a
14312 ConstructedType and it doesn't have its type set. So, first
14313 create our own TypeBuilder, then call constructed.Resolve() to get
14314 the parent's type and finally TypeBuilder.SetParent() it.
14316 * ecore.cs (TypeExpr.Name): New public virtual property.
14319 (ConstructedType): We're now a TypeExpr and not just an Expression.
14320 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
14321 arguments here; this is done later.
14322 (ConstructedType.Resolve): New public method to resolve the type
14323 arguments and bind them.
14325 2003-10-21 Martin Baulig <martin@ximian.com>
14327 * convert.cs: Use `TypeManager.IsValueType' instead of
14328 'type.IsValueType' everywhere.
14330 * typemanager.cs (TypeManager.IsValueType): Return true for type
14331 parameters. The reason for this is that we need to box a type
14332 parameter when converting it to a reference type.
14334 * cs-parser.jay: Added support for default value expressions.
14336 * generics.cs (DefaultValueExpression): New public class.
14338 2003-10-17 Martin Baulig <martin@ximian.com>
14340 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
14341 TypeContainer so we can also use this for Interfaces.
14342 (TypeParameter.Resolve): Likewise.
14344 * interface.cs (Interface.DefineType): Added support for generic
14347 * cs-parser.jay: Added support for generic structs and interfaces.
14349 2003-10-17 Martin Baulig <martin@ximian.com>
14351 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
14352 call generic methods :-)
14354 2003-10-16 Martin Baulig <martin@ximian.com>
14356 * cs-parser.jay (namespace_or_type_name): Only create a
14357 GenericMemberAccess if we actually have type arguments.
14359 2003-10-13 Martin Baulig <martin@ximian.com>
14361 * class.cs (Method.Define): If we're a generic method, call
14362 TypeBuilder.DefineGenericMethod () before resolving
14364 (MethodData): Added .ctor which takes an additional MethodBuilder
14365 argument; this is used for generic methods.
14366 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
14367 we already have a MethodBuilder.
14369 2003-10-10 Martin Baulig <martin@ximian.com>
14371 * class.cs (Method): Added .ctor which takes a `GenericMethod'
14372 instead of a `DeclSpace'. This is used for generic methods.
14374 * cs-parser.jay (method_header): Added support for generic
14375 methods; create a `GenericMethod' instance and pass it to the
14376 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
14377 parameters and locals.
14379 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
14380 since we already have the location. Check whether we're a generic
14381 type declaration or a generic method and create the correct type
14384 * generic.cs (TypeParameter.DefineMethod): New public method.
14385 (GenericMethod): New public class; derives from DeclSpace and is
14386 used for generic methods.
14388 2003-10-09 Martin Baulig <martin@ximian.com>
14390 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
14392 (MethodCore.DoDefineParameters): Removed the TypeContainer
14393 argument; use the DeclSpace which was passed to the .ctor instead.
14394 (MethodCore.CheckParameter): Take a DeclSpace instead of a
14395 TypeContainer; we only need a DeclSpace here.
14397 2003-10-09 Martin Baulig <martin@ximian.com>
14399 * class.cs (MethodData): Added additional `DeclSpace ds' argument
14401 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
14402 EmitContext's .ctor.
14404 2003-10-09 Martin Baulig <martin@ximian.com>
14406 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
14407 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
14408 AsAccessible(), moved them as well.
14410 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
14412 2003-10-07 Miguel de Icaza <miguel@ximian.com>
14414 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
14415 generation for >=, as spotted by Paolo, bug 48679.
14416 Patch from David Waite.
14418 * cs-tokenizer.cs: Add handling for #pragma.
14420 * cs-parser.jay: Allow for both yield and yield return in the
14421 syntax. The anti-cobolization of C# fight will go on!
14423 * class.cs (TypeBuilder.DefineType): Catch error condition here
14424 (Parent.DefineType erroring out and returning null).
14426 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14427 coping with enumerations variables, we were mistakenly processing
14428 them as a regular value type instead of built-in types. Fixes the
14431 * typemanager.cs (IsBuiltinOrEnum): New method.
14433 2003-09-30 Miguel de Icaza <miguel@ximian.com>
14435 * cs-parser.jay: Upgrade: yield now needs the return clause.
14437 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
14439 * cs-parser.jay : Renamed yyName to yyNames related to jay.
14441 2003-09-29 Martin Baulig <martin@ximian.com>
14443 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
14444 inflated generic methods.
14446 * generics.cs (ConstructedType): Distinguish between open and
14447 closed constructed types; correctly resolve the arguments.
14449 2003-09-22 Martin Baulig <martin@ximian.com>
14451 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
14452 all type arguments meet their constraints.
14454 2003-09-19 Martin Baulig <martin@ximian.com>
14456 * decl.cs (MemberCache.SetupCacheForInterface): Take a
14457 `MemberCache parent' argument. Normally, an interface doesn't
14458 have a parent type except System.Object, but we use this in gmcs
14459 for generic type parameters.
14461 2003-09-18 Martin Baulig <martin@ximian.com>
14463 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
14464 on `type.IsInterface'; don't check whether the type has a parent
14465 to determine whether it's an interface.
14467 2003-09-17 Martin Baulig <martin@ximian.com>
14469 * generic.cs (ConstructedType.ToString): Always use `name' as the
14472 2003-09-15 Martin Baulig <martin@ximian.com>
14474 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
14476 * generic.cs (Constraints.Resolve): New public method; this is
14477 called to resolve the constraint types and to check whether all
14478 the constraints are correct.
14479 (Constraints.Types): New public property.
14480 (TypeParameter.Resolve): New public method; resolves all the
14481 type's constraints.
14483 * class.cs (TypeContainer.DefineType): Call
14484 TypeParameter.Resolve() before actually defining the type.
14486 2003-09-15 Martin Baulig <martin@ximian.com>
14488 * class.cs (TypeContainer.DefineType): Added an error flag to
14489 avoid reporting duplicate CS0146's ("class definition is
14492 * driver.cs (Driver.MainDriver): Abort if
14493 RootContext.ResolveTree() reported any errors.
14495 2003-09-07 Martin Baulig <martin@ximian.com>
14497 * report.cs (Error, Warning): Added overloaded versions which take
14498 a `params object[] args' and call String.Format().
14500 2003-09-07 Martin Baulig <martin@ximian.com>
14502 * decl.cs (DeclSpace..ctor): Don't call
14503 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
14504 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
14505 (DeclSpace.RecordDecl): New method.
14507 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
14509 2003-09-02 Ravi Pratap <ravi@ximian.com>
14511 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
14512 value attributes to be applied to ParameterBuilders.
14514 * class.cs (MethodCore.LabelParameters): Make static and more
14515 generic so that it can be used from other places - like interface
14516 methods, for instance.
14518 * interface.cs (Interface.Emit): Call LabelParameters before
14519 emitting attributes on the InterfaceMethod.
14521 2003-09-07 Martin Baulig <martin@ximian.com>
14523 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
14524 if the number of type parameters doesn't match.
14526 2003-09-04 Martin Baulig <martin@ximian.com>
14528 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
14529 for arrays of generic type params (ie. `!0[]').
14531 2003-09-04 Martin Baulig <martin@ximian.com>
14533 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
14536 2003-09-04 Martin Baulig <martin@ximian.com>
14538 * decl.cs (DeclSpace.LookupGeneric): New method.
14539 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
14542 * generic.cs (TypeParameterExpr): Take a TypeParameter as
14543 argument, not just a string.
14544 (TypeParameter.Define): New public method; this is called to
14545 actually define the generic parameter; after this, you can use the
14546 new `Type' property to get the type.
14548 2003-09-04 Martin Baulig <martin@ximian.com>
14550 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
14551 is now an ArrayList; initialize the result of the `TypeParameters'
14553 (DeclSpace.GetGenericData): Removed.
14554 (DeclSpace.LookupGeneric): Temporarily removed; we need to
14555 implement this in a different way.
14556 (DeclSpace.GetTypeParameters): Removed; there's now a
14557 `TypeParameters' property.
14558 (DeclSpace.TypeParameters): New public property.
14560 * generic.cs (Constraints): Make this class public.
14561 (TypeParameter): New public class.
14563 2003-09-04 Martin Baulig <martin@ximian.com>
14565 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14566 generic parameters.
14568 * class.cs (TypeContainer.DefineType): Call
14569 TypeBuilder.DefineGenericParameter () on all generic parameters if
14570 this is a generic type.
14572 2003-08-28 Martin Baulig <martin@ximian.com>
14574 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14577 * sample-hello.cs: Compile this with gmcs: "gmcs
14578 /r:sample-stack.dll sample-hello.cs".
14580 2003-08-28 Martin Baulig <martin@ximian.com>
14582 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14583 the parameters to the generic type.
14585 2003-08-28 Martin Baulig <martin@ximian.com>
14587 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14589 2003-08-28 Martin Baulig <martin@ximian.com>
14591 * cs-parser.jay (opt_type_argument_list): Use
14592 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14593 (primary_expression): Replace `qualified_identifier' with `type_name'.
14594 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14596 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14597 parser to check whether it is syntactically a type parameter list;
14598 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14601 2003-08-26 Martin Baulig <martin@ximian.com>
14603 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14604 resolving aliases; fixes #47927.
14606 2003-08-26 Martin Baulig <martin@ximian.com>
14608 * statement.cs (Using.DoResolve): This is internally emitting a
14609 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14610 do not always return. Fixes #47681.
14612 2003-08-26 Martin Baulig <martin@ximian.com>
14614 * decl.cs (MemberCore): Moved WarningNotHiding(),
14615 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14617 (AdditionResult): Make this nested in DeclSpace.
14618 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14619 argument; call NamespaceEntry.Define() unless we're nested in a
14622 * namespace.cs (Namespace.DefineName): New public function. This
14623 is called from DeclSpace's .ctor to add
14624 (Namespace.Lookup): Include DeclSpaces in the lookup.
14626 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14628 * const.cs (Const): Derive from MemberBase, not MemberCore.
14630 2003-08-25 Martin Baulig <martin@ximian.com>
14632 * convert.cs (Convert.ExplicitReferenceConversion): When
14633 converting from an interface type to a class, unbox if the target
14634 type is a struct type. Fixes #47822.
14636 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14638 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14641 2003-08-22 Martin Baulig <martin@ximian.com>
14643 * class.cs (TypeManager.DefineType): When defining a nested type,
14644 call DefineType() on our parent; fixes #47801.
14646 2003-08-22 Martin Baulig <martin@ximian.com>
14648 * class.cs (MethodData.Define): While checking if a method is an
14649 interface implementation, improve the test a bit more to fix #47654.
14651 2003-08-22 Martin Baulig <martin@ximian.com>
14653 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14654 correctly; fixes #47722.
14656 2003-08-22 Martin Baulig <martin@ximian.com>
14658 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14659 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14661 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14663 2003-08-22 Martin Baulig <martin@ximian.com>
14665 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14666 can only be assigned in static constructors. Fixes #47161.
14668 2003-08-22 Martin Baulig <martin@ximian.com>
14670 Rewrote and improved the flow analysis code.
14672 * flowbranching.cs (FlowBranching): Make this class abstract.
14673 (FlowBranching.CreateBranching): New static function to create a
14674 new flow branching.
14675 (FlowBranchingBlock, FlowBranchingException): New classes.
14676 (FlowBranching.UsageVector.Type): New public readonly field.
14677 (FlowBranching.UsageVector.Breaks): Removed the setter.
14678 (FlowBranching.UsageVector.Returns): Removed the setter.
14679 (FlowBranching.UsageVector): Added Break(), Return(),
14680 NeverReachable() and Throw() methods to modify the reachability.
14681 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14682 done by FlowBranching.Merge().
14683 (FlowBranching.UsageVector.MergeChild): New method; merges the
14684 merge result into the current vector.
14685 (FlowBranching.Merge): New abstract method to merge a branching.
14687 2003-08-12 Martin Baulig <martin@ximian.com>
14689 * expression.cs (Indirection.CacheTemporaries): Create the
14690 LocalTemporary with the pointer type, not its element type.
14692 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14694 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14695 token was a keyword or not.
14697 Add `error' options where an IDENTIFIER was expected; Provide
14698 CheckToken and CheckIdentifierToken convenience error reporting
14701 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14703 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14704 NameSpaceEntry NameSpaceEntry.
14706 (LookupInterfaceOrClass): Avoid creating a full qualified name
14707 from namespace and name: avoid doing lookups when we know the
14708 namespace is non-existant. Use new Tree.LookupByNamespace which
14709 looks up DeclSpaces based on their namespace, name pair.
14711 * driver.cs: Provide a new `parser verbose' to display the
14712 exception thrown during parsing. This is turned off by default
14713 now, so the output of a failure from mcs is more graceful.
14715 * namespace.cs: Track all the namespaces defined in a hashtable
14718 (IsNamespace): New method
14720 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14722 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14723 we know that we need to concatenate (full typename can never be
14728 * statement.cs: Use a bitfield; Do not initialize to null things
14729 which are done by the constructor by default.
14731 * cs-parser.jay: bug fix, parameter was 4, not 3.
14733 * expression.cs: Just use the property;
14735 * statement.cs: No need for GetVariableInfo method.
14737 2003-08-08 Martin Baulig <martin@ximian.com>
14739 * flowanalysis.cs (FlowReturns): This is now nested in the
14740 `FlowBranching' class.
14741 (MyBitVector): Moved this here from statement.cs.
14742 (FlowBranching.SiblingType): New enum type.
14743 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14745 2003-08-07 Martin Baulig <martin@ximian.com>
14747 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14748 `FlowBranching' class and called `BranchingType'.
14750 2003-08-07 Martin Baulig <martin@ximian.com>
14752 * flowanalysis.cs: Moved all the control flow analysis code into
14755 2003-08-07 Martin Baulig <martin@ximian.com>
14757 * assign.cs (Assign.DoResolve): `target' must either be an
14758 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14761 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14763 * expression.cs (BinaryMethod): This kind of expression is created by the
14764 Binary class if it determines that the operator has to be handled
14767 (BinaryDelegate): This kind of expression is created if we are
14768 dealing with a + or - operator on delegates.
14770 (Binary): remove method, argumetns, and DelegateOperator: when
14771 dealing with methods,
14773 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14775 * statement.cs (Block): use bitfields for the three extra booleans
14776 we had in use. Remove unused topblock parameter.
14778 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14780 * assign.cs: Drop extra unneeded tests.
14782 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14784 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14786 * statement.cs (Foreach): Use VariableStorage instead of
14789 * codegen.cs (VariableStorage): New class used by clients that
14790 require a variable stored: locals or fields for variables that
14791 need to live across yield.
14793 Maybe provide a convenience api for EmitThis+EmitLoad?
14795 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14798 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14800 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14801 RemapParameterLValue): New methods that are used to turn a
14802 precomputed FieldInfo into an expression like this:
14806 The idea is to use this instead of making LocalVariableReference
14807 have more than one meaning.
14809 * cs-parser.jay: Add error production to BASE.
14811 * ecore.cs: Deal with TypeManager.GetField returning null, which
14812 is now a valid return value.
14814 (FieldExprNoAddress): New expression for Fields whose address can
14817 * expression.cs (LocalVariableReference): During the resolve
14818 phases, create new expressions if we are in a remapping context.
14819 Remove code that dealt with remapping here.
14821 (ParameterReference): same.
14823 (ProxyInstance): New expression, like the `This' expression, but
14824 it is born fully resolved. We know what we are doing, so remove
14825 the errors that are targeted to user-provided uses of `this'.
14827 * statement.cs (Foreach): our variable is now stored as an
14828 Expression; During resolution, follow the protocol, dont just
14829 assume it will return this.
14831 2003-08-06 Martin Baulig <martin@ximian.com>
14833 * support.cs (SeekableStreamReader.cs): New public class.
14835 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14836 SeekableStreamReader instead of the normal StreamReader.
14838 2003-08-04 Martin Baulig <martin@ximian.com>
14840 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14841 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14842 deambiguate casts and delegate invocations.
14843 (parenthesized_expression): Use the new tokens to ensure this is
14844 not a cast of method invocation.
14846 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14847 when reading a `)' and Deambiguate_CloseParens () was previously
14850 * expression.cs (ParenthesizedExpression): New class. This is
14851 just used for the CS0075 test.
14852 (Binary.DoResolve): Check for CS0075.
14854 2003-07-29 Ravi Pratap <ravi@ximian.com>
14856 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14857 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14858 reference comparison.
14860 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14861 examine the ReturnType for equality - this is necessary in the
14862 cases of implicit and explicit operators whose signature also
14863 includes the return type.
14865 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14867 * namespace.cs: Cache the result of the namespace computation,
14868 instead of computing it every time.
14870 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14872 * decl.cs: Use a global arraylist that we reuse over invocations
14873 to avoid excesive memory consumption. Reduces memory usage on an
14874 mcs compile by one meg (45 average).
14876 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14877 private, work around that.
14879 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14881 * literal.cs (IntLiteral): Define Zero and One static literals.
14883 * cs-parser.jay (integer_literal): use static literals to reduce
14884 memory usage for the most used literals (0, 1 and -1). 211kb
14885 reduced in memory usage.
14887 Replace all calls to `new ArrayList' with `new
14888 ArrayList(4)' which is a good average number for most allocations,
14889 and also requires only 16 bytes of memory for its buffer by
14892 This reduced MCS memory usage in seven megabytes for the RSS after
14895 2003-07-28 Ravi Pratap <ravi@ximian.com>
14897 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14898 handle params methods the correct way by forming only one
14899 applicable set with params and normal methods in them. Earlier we
14900 were looking at params methods only if we found no normal methods
14901 which was not the correct thing to do.
14903 (Invocation.BetterFunction): Take separate arguments indicating
14904 when candidate and the best method are params methods in their
14907 This fixes bugs #43367 and #46199.
14909 * attribute.cs: Documentation updates.
14911 (CheckAttribute): Rename to CheckAttributeTarget.
14912 (GetValidPlaces): Rename to GetValidTargets.
14914 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14915 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14919 2003-07-28 Miguel de Icaza <miguel@ximian.com>
14921 * codegen.cs: Compute IsGeneric correctly.
14923 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
14926 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
14927 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
14928 regressions, and I was chasing more bugs than I required.
14930 * interface.cs: Use expressions for base type names (like classes
14931 and structs have been doing for a while now), and resolve that.
14932 This patch should probably go into head as well.
14934 This makes it one less user of FindType.
14936 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14938 This compiler can not self host currently. Need to fix that.
14940 * Makefile: compile to `gmcs.exe'
14942 * driver.cs: Turn on v2 by default on gmcs.
14944 * generic.cs (ConstructedType): Does no longer take a container
14945 type argument; That will be taken care of later.
14947 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
14948 Use SimpleName to resolve for now, so we can continue the work on
14949 the parser, until we get Type.GetType that understands generics.
14951 (ConstructedType.ToString): Implement
14953 (TypeArguments.Resolve): Resolve the child expressions as types.
14955 * cs-parser.jay: Rename interface_constraints to
14956 type_parameter_constraints
14958 (namespace_or_type_name): Only use constructed types for the basic
14959 construction, we will deal with identifier<...> later.
14961 (type/type_name): No longer call DecomposeQI, as
14962 namespace_or_type_name is always decoded now.
14964 2003-07-22 Ravi Pratap <ravi@ximian.com>
14966 * expression.cs (Invocation.OverloadResolve): Follow the spec more
14967 closely: we eliminate methods in base types when we have an
14968 applicable method in a top-level type.
14970 Please see section 14.5.5.1 for an exact description of what goes
14973 This fixes bug #45127 and a host of other related to corlib compilation.
14975 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
14976 array is the method corresponding to the top-level type (this is
14977 because of the changes made to icall.c) so we change this
14980 (MethodGroupExpr.Name): This too.
14982 * typemanager.cs (GetElementType): New method which does the right
14983 thing when compiling corlib.
14985 * everywhere: Make use of the above in the relevant places.
14987 2003-07-22 Martin Baulig <martin@ximian.com>
14989 * cs-parser.jay (invocation_expression): Moved
14990 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
14991 `cast_expression', but create a InvocationOrCast which later
14992 resolves to either an Invocation or a Cast.
14994 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
14995 method; call this before EmitStatement() to make sure that this
14996 expression can be used as a statement.
14998 * expression.cs (InvocationOrCast): New class; resolves to either
14999 an Invocation or a Cast.
15001 * statement.cs (StatementExpression): Call ResolveStatement() on
15002 the ExpressionStatement before emitting it.
15004 2003-07-21 Martin Baulig <martin@ximian.com>
15006 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
15007 `ref' and `out' attributes match; fixes #46220.
15008 (MemberAccess.ResolveMemberAccess): You can't reference a type
15009 through an expression; fixes #33180.
15010 (Indexers.GetIndexersForType): Don't return the indexers from
15011 interfaces the class implements; fixes #46502.
15013 2003-07-21 Martin Baulig <martin@ximian.com>
15015 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
15016 CS0661 checks; fixes bug #30442.
15018 2003-07-21 Martin Baulig <martin@ximian.com>
15020 * decl.cs (AdditionResult): Added `Error'.
15022 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
15024 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
15025 cs0031.cs actually work.
15027 2003-07-20 Miguel de Icaza <miguel@ximian.com>
15029 * cs-parser.jay (namespace_name): do not use
15030 namespace_or_type_name, use qualified_identifier, because
15031 namespace_or_type_name will soon return a composed expression
15032 instead of a string.
15034 (namespace_or_type_name): Instead of returning a string, now this
15035 production returns an expression.
15037 * codegen.cs (EmitContext): Setup IsGeneric property based on
15038 whether our DeclSpace is generic, our the method is generic.
15040 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
15041 the method is generic.
15043 * cs-parser.jay (type_arguments, opt_type_argument_list,
15044 type_parameters, type_parameter_list, opt_type_parameter_list,
15045 type_parameter,, opt_type_parameter_constraints_clauses,
15046 type_parameter_constraints_clauses,
15047 type_parameter_constraint_clause, type_parameter_constraint,
15048 interface_constraints): Add new production
15050 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
15051 DeclSpace is generic or not.
15053 (DeclSpace.SetParameterInfo): New routine, used to set the
15054 parameter info for a type.
15056 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
15057 returns a GenericTypeExpr
15059 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
15060 generic, lookup the generic argument.
15062 * attribute.cs: Do not allow TypeParameterExpressions in
15065 * class.cs: Do not allow the Main method to be defined in a
15068 * expression.cs (SizeOf): Do not allow generic types to be used as
15069 arguments to sizeof.
15071 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
15072 it: whether a type is generic or not. Only works for types we are
15073 currently building for now.
15075 2003-07-20 Martin Baulig <martin@ximian.com>
15077 * namespace.cs: Fixed that bug which caused a crash when compiling
15078 the debugger's GUI.
15080 2003-07-20 Miguel de Icaza <miguel@ximian.com>
15082 * typemanager.cs (LookupTypeReflection): Never expose types which
15083 are NotPublic, NestedPrivate, NestedAssembly, or
15084 NestedFamANDAssem. We used to return these, and later do a check
15085 that would report a meaningful error, but the problem is that we
15086 would not get the real match, if there was a name override.
15088 2003-07-18 Miguel de Icaza <miguel@ximian.com>
15090 * namespace.cs (Namespace, Name): Do not compute the namespace
15091 name dynamically, compute it in the constructor. This reduced
15092 memory usage by 1697 KB.
15094 * driver.cs: Use --pause to pause at the end.
15096 2003-07-17 Peter Williams <peter@newton.cx>
15098 * Makefile: Change the name of the test target so that it doesn't
15099 conflict with the recursive test target.
15101 2003-07-17 Miguel de Icaza <miguel@ximian.com>
15103 * expression.cs (LocalVariableReference.Emit, EmitAssign,
15104 AddressOf): Do not use EmitThis, that was wrong, use the actual
15107 2003-07-15 Miguel de Icaza <miguel@ximian.com>
15109 * class.cs (MethodData.Define): While checking if a method is an
15110 interface implementation, improve the test: If we are not public
15111 (use new test here: use the computed MethodAttributes directly,
15112 instead of the parsed modifier flags) check if the `implementing'
15113 method comes from an interface or not.
15115 * pending.cs (VerifyPendingMethods): Slightly better error
15118 * makefile: add test target that does the mcs bootstrap.
15120 2003-07-16 Ravi Pratap <ravi@ximian.com>
15122 * interface.cs (Define): Do nothing here since there are no
15123 members to populate etc. Move the attribute emission out of here
15124 since this was just totally the wrong place to put it. Attribute
15125 application happens during the 'Emit' phase, not in the 'Define'
15128 (Emit): Add this method and move the attribute emission here
15130 * rootcontext.cs (EmitCode): Call the Emit method on interface
15133 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15135 * expression.cs (OverloadResolve): Report error only if Location
15136 is not 'Null' which means that there was a probe going on.
15138 2003-07-14 Martin Baulig <martin@ximian.com>
15140 * expression.cs (ConditionalLogicalOperator): New public class to
15141 implement user defined conditional logical operators.
15142 This is section 14.11.2 in the spec and bug #40505.
15144 2003-07-14 Martin Baulig <martin@ximian.com>
15146 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
15148 2003-07-14 Martin Baulig <martin@ximian.com>
15150 * codegen.cs (EmitContext.InFixedInitializer): New public field.
15152 * ecore.cs (IVariable.VerifyFixed): New interface method.
15154 * expression.cs (Unary.ResolveOperator): When resolving the `&'
15155 operator, check whether the variable is actually fixed. Fixes bug
15156 #36055. Set a variable definitely assigned when taking its
15157 address as required by the spec.
15159 * statement.cs (LocalInfo.IsFixed): New field.
15160 (LocalInfo.MakePinned): Set `IsFixed' to true.
15162 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15164 * attribute.cs (Attribute.Resolve): While doing a Member lookup
15165 for .ctors, ensure that we only ask for members declared in the
15166 attribute type (BindingFlags.DeclaredOnly).
15170 * expression.cs (Error_WrongNumArguments): Report error 1501
15171 correctly the way CSC does.
15173 2003-07-13 Martin Baulig <martin@ximian.com>
15175 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
15176 lookup on the fully qualified name, to make things like "X.X" work
15177 where "X.X" is a fully qualified type name, but we also have a
15178 namespace "X" in the using list. Fixes #41975.
15180 2003-07-13 Martin Baulig <martin@ximian.com>
15182 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
15183 function. If we're a CompoundAssign, we need to create an embedded
15184 CompoundAssign, not an embedded Assign.
15185 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
15188 2003-07-13 Martin Baulig <martin@ximian.com>
15190 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
15191 work to fix bug #46088.
15193 2003-07-13 Ravi Pratap <ravi@ximian.com>
15195 * class.cs (Operator.Emit): Do not emit attributes here - it is
15196 taken care of by the Method class that we delegate too. This takes
15197 care of bug #45876.
15199 2003-07-10 Martin Baulig <martin@ximian.com>
15201 * expression.cs (TypeOfVoid): New class.
15202 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
15204 2003-07-10 Martin Baulig <martin@ximian.com>
15206 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
15209 2003-07-10 Martin Baulig <martin@ximian.com>
15211 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
15212 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
15214 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
15216 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
15218 2003-07-10 Martin Baulig <martin@ximian.com>
15220 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
15221 of decimal. Fixes #42850.
15223 NOTE: I also fixed the created byte blob, but this doesn't work on
15224 the MS runtime and csc never produces any byte blobs for decimal
15227 2003-07-10 Martin Baulig <martin@ximian.com>
15229 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
15230 structs; fixes #32068.
15231 (Block.AddChildVariableNames): Fixed #44302.
15233 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15235 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
15237 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15239 * attribute.cs: And this test is onger needed.
15241 2003-07-08 Martin Baulig <martin@ximian.com>
15243 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
15244 inaccessible types. Fixes #36313.
15246 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
15248 * namespace.cs (NamespaceEntry): Create implicit entries for all
15249 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
15250 implicit entries for N1.N2 and N1.
15252 2003-07-08 Martin Baulig <martin@ximian.com>
15254 Rewrote the handling of namespaces to fix a lot of the issues
15255 wrt. `using' aliases etc.
15257 * namespace.cs (Namespace): Splitted this class into a
15258 per-assembly `Namespace' and a per-file `NamespaceEntry'.
15260 * typemanager.cs (TypeManager.IsNamespace): Removed.
15261 (TypeManager.ComputeNamespaces): Only compute namespaces from
15262 loaded assemblies here, not the namespaces from the assembly we're
15263 currently compiling.
15265 2003-07-08 Martin Baulig <martin@ximian.com>
15267 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
15269 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15271 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
15274 I thought about the memory savings here, but LookupTypeReflection
15275 is used under already very constrained scenarios. Compiling
15276 corlib or mcs only exposes one hit, so it would not really reduce
15277 any memory consumption.
15279 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15281 * typemanager.cs: fixes bug #45889 by only adding public types from
15282 other assemblies to the list of known types.
15284 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15286 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
15287 on the type we resolved.
15289 2003-07-05 Martin Baulig <martin@ximian.com>
15291 * pending.cs (PendingImplementation.ParentImplements): Don't
15292 create the proxy if the parent is abstract.
15294 * class.cs (TypeContainer.DefineIndexers): Process explicit
15295 interface implementations first. Fixes #37714.
15297 2003-07-04 Miguel de Icaza <miguel@ximian.com>
15299 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
15300 defined recursively; but since we modify the input parameters
15301 (left is set to `this' temporarily), we reset this value if the
15302 left_is_explicit is false, which gives the original semantics to
15305 * literal.cs (NullPointer): new class used to represent a null
15306 literal in a pointer context.
15308 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
15309 type is a pointer, use a NullPointer object instead of a
15310 NullLiteral. Closes 43687
15312 (ExplicitConversion): Convert pointer values using
15313 the conv opcode to the proper type.
15315 * ecore.cs (New): change ValueTypeVariable property into a method,
15316 that returns whether the valuetype is suitable for being used.
15318 * expression.cs (Binary.DoNumericPromotions): Only return if we
15319 the int constant was a valid uint, and we can return both left and
15320 right as uints. If not, we continue processing, to trigger the
15321 type conversion. This fixes 39018.
15323 * statement.cs (Block.EmitMeta): During constant resolution, set
15324 the CurrentBlock property on the emitcontext, so that we resolve
15325 constants propertly.
15327 2003-07-02 Martin Baulig <martin@ximian.com>
15329 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
15330 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
15332 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
15333 than emitting it here.
15335 * statement.cs: Fixed some more flow analysis bugs.
15337 2003-07-02 Martin Baulig <martin@ximian.com>
15339 * class.cs (MethodData.Define): When implementing interface
15340 methods, set Final unless we're Virtual.
15342 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
15343 check work for interface methods.
15345 2003-07-01 Martin Baulig <martin@ximian.com>
15347 * ecore.cs (EmitContext.This): Replaced this property with a
15348 GetThis() method which takes a Location argument. This ensures
15349 that we get the correct error location for a CS0188.
15351 2003-07-01 Miguel de Icaza <miguel@ximian.com>
15353 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
15354 ImplicitStandardConversion.
15356 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
15358 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
15360 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
15363 2003-06-30 Miguel de Icaza <miguel@ximian.com>
15365 * class.cs (Constructor.Define): Turn off initlocals for unsafe
15368 (MethodData.Define): Turn off initlocals for unsafe methods.
15370 2003-06-29 Miguel de Icaza <miguel@ximian.com>
15372 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
15373 complete; Fixes #37521.
15375 * delegate.cs: Use Modifiers.TypeAttr to compute the
15376 TypeAttributes, instead of rolling our own. This makes the flags
15377 correct for the delegates.
15379 2003-06-28 Miguel de Icaza <miguel@ximian.com>
15381 * class.cs (Constructor.Define): Set the private flag for static
15382 constructors as well.
15384 * cs-parser.jay (statement_expression): Set the return value to
15385 null, to avoid a crash when we catch an error.
15387 2003-06-24 Miguel de Icaza <miguel@ximian.com>
15389 * cs-parser.jay: Applied patch from Jackson that adds support for
15390 extern and unsafe modifiers to destructor declarations.
15392 * expression.cs: Report error 21 if the user is trying to index a
15395 * driver.cs: Add an error message, suggested by the bug report.
15397 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
15398 if we do not have a ": this ()" constructor initializer. Fixes 45149
15400 2003-06-14 Miguel de Icaza <miguel@ximian.com>
15402 * namespace.cs: Add some information to reduce FAQs.
15404 2003-06-13 Miguel de Icaza <miguel@ximian.com>
15406 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
15407 underlying enumeration types. Fixes #43915.
15409 * expression.cs: Treat ushort/short as legal values to be used in
15410 bitwise operations.
15412 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
15414 * delegate.cs: transfer custom attributes for paramenters from
15415 the delegate declaration to Invoke and BeginInvoke.
15417 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
15419 * attribute.cs: handle custom marshalers and emit marshal info
15422 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
15424 * makefile.gnu: Added anonymous.cs to the compiler sources.
15426 2003-05-28 Miguel de Icaza <miguel@ximian.com>
15428 * iterators.cs: Change the name of the proxy class to include two
15431 * cs-parser.jay: Update grammar to include anonymous methods.
15433 * anonymous.cs: new file.
15435 2003-05-27 Miguel de Icaza <miguel@ximian.com>
15437 * class.cs (Field.Define): Add missing test for pointers and
15440 2003-05-27 Ravi Pratap <ravi@ximian.com>
15442 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
15443 we use the stobj opcode.
15445 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
15446 since it wasn't the correct fix.
15448 It still is puzzling that we are required to use stobj for IntPtr
15449 which seems to be a ValueType.
15451 2003-05-26 Miguel de Icaza <miguel@ximian.com>
15453 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
15454 during regular simple name resolution. Now, the trick is that
15455 instead of returning for processing the simplename, we do a
15456 TypeManager.LookupType (ie, a rooted lookup as opposed to a
15457 contextual lookup type). If a match is found, return that, if
15458 not, return for further composition.
15460 This fixes long-standing 30485.
15462 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15463 using the address to initialize an object, do an Stobj instead of
15464 using the regular Stelem.
15466 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
15467 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
15468 Because if we are a BaseIndexerAccess that value will be true.
15471 * statement.cs (GotoCase.Resolve): Return after reporting an
15472 error, do not attempt to continue.
15474 * expression.cs (PointerArithmetic.Emit): If our operand is a
15475 long, convert our constants to match the operand before
15476 multiplying. Convert to I type before adding. Fixes 43670.
15478 2003-05-14 Ravi Pratap <ravi@ximian.com>
15480 * enum.cs (ImplicitConversionExists) : Rename to
15481 ImplicitEnumConversionExists to remove ambiguity.
15483 * ecore.cs (NullCast): New type of cast expression class which
15484 basically is very similar to EmptyCast with the difference being
15485 it still is a constant since it is used only to cast a null to
15487 (eg. (string) null)
15489 * convert.cs (ImplicitReferenceConversion): When casting a null
15490 literal, we return a NullCast.
15492 * literal.cs (NullLiteralTyped): Remove - I don't see why this
15493 should be around anymore.
15495 The renaming (reported was slightly wrong). Corrections:
15497 ConvertImplicitStandard -> ImplicitConversionStandard
15498 ConvertExplicitStandard -> ExplicitConversionStandard
15500 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
15501 before passing them in !
15503 * convert.cs (ImplicitConversionStandard): When comparing for
15504 equal expr and target types, ensure that expr is not a
15507 In general, we must not be checking (expr_type ==
15508 target_type) in the top level conversion methods
15509 (ImplicitConversion, ExplicitConversion etc). This checking is
15510 done in the methods that they delegate to.
15512 2003-05-20 Miguel de Icaza <miguel@ximian.com>
15514 * convert.cs: Move Error_CannotConvertType,
15515 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
15516 ImplicitNumericConversion, ImplicitConversionExists,
15517 ImplicitUserConversionExists, StandardConversionExists,
15518 FindMostEncompassedType, FindMostSpecificSource,
15519 FindMostSpecificTarget, ImplicitUserConversion,
15520 ExplicitUserConversion, GetConversionOperators,
15521 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
15522 TryImplicitIntConversion, Error_CannotConvertImplicit,
15523 ConvertImplicitRequired, ConvertNumericExplicit,
15524 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
15525 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
15528 Perform the following renames:
15530 StandardConversionExists -> ImplicitStandardConversionExists
15531 ConvertImplicit -> ImplicitConversion
15532 ConvertImplicitStandard -> ImplicitStandardConversion
15533 TryImplicitIntConversion -> ImplicitIntConversion
15534 ConvertImplicitRequired -> ImplicitConversionRequired
15535 ConvertNumericExplicit -> ExplicitNumericConversion
15536 ConvertReferenceExplicit -> ExplicitReferenceConversion
15537 ConvertExplicit -> ExplicitConversion
15538 ConvertExplicitStandard -> ExplicitStandardConversion
15540 2003-05-19 Martin Baulig <martin@ximian.com>
15542 * statement.cs (TypeInfo.StructInfo): Made this type protected.
15543 (TypeInfo): Added support for structs having structs as fields.
15545 * ecore.cs (FieldExpr): Implement IVariable.
15546 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
15547 VariableInfo for the field.
15549 2003-05-18 Martin Baulig <martin@ximian.com>
15551 * expression.cs (This.DoResolve): Report a CS0027 if we're
15552 emitting a field initializer.
15554 2003-05-18 Martin Baulig <martin@ximian.com>
15556 * expression.cs (This.ResolveBase): New public function.
15557 (This.DoResolve): Check for CS0188.
15559 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
15562 * ecore.cs (MethodGroupExpr.DoResolve): Set the
15563 `instance_expression' to null if we don't have any non-static
15566 2003-05-18 Martin Baulig <martin@ximian.com>
15568 Reworked the way how local variables and parameters are handled by
15569 the flow analysis code.
15571 * statement.cs (TypeInfo, VariableMap): New public classes.
15572 (VariableInfo): New public class. This is now responsible for
15573 checking whether a variable has been assigned. It is used for
15574 parameters and local variables.
15575 (Block.EmitMeta): Take the InternalParameters as argument; compute
15576 the layout of the flow vectors here.
15577 (Block.LocalMap, Block.ParameterMap): New public properties.
15578 (FlowBranching): The .ctor doesn't get the InternalParameters
15579 anymore since Block.EmitMeta() now computes the layout of the flow
15581 (MyStructInfo): This class is now known as `StructInfo' and nested
15582 in `TypeInfo'; we don't access this directly anymore.
15584 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15585 property and removed IsAssigned(), IsFieldAssigned(),
15586 SetAssigned() and SetFieldAssigned(); we now call them on the
15587 VariableInfo so we don't need to duplicate this code everywhere.
15589 * expression.cs (ParameterReference): Added `Block block' argument
15591 (LocalVariableReference, ParameterReference, This): The new
15592 VariableInfo class is now responsible for all the definite
15595 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15596 IsParameterAssigned, SetParameterAssigned): Removed.
15598 2003-05-18 Martin Baulig <martin@ximian.com>
15600 * typemanager.cs (InitCoreTypes): Try calling
15601 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15602 the 3-args-version. Corlib now also needs our `void_type'.
15603 (GetMethod): Added overloaded version which takes an optional
15604 `bool report_errors' to allow lookups of optional methods.
15606 2003-05-12 Martin Baulig <martin@ximian.com>
15608 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15609 only used for locals and not for parameters.
15611 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15613 * support.cs (InternalParameters.ParameterType): Return the
15614 ExternalType of the parameter.
15616 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15619 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15621 * class.cs (MethodData.Define): Do not set the `newslot' on
15622 interface members, if they are also flagged as "override".
15624 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15625 better code for ++i and i++. This only works for static fields
15626 and local variables.
15628 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15629 want to pull the DeclSpace out of the builder_to_declspace instead
15630 of the TypeBuilder (like in TypeContainer.FindMembers).
15632 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15633 instead of LookupTypeContainer. Fixes the crash on .NET for
15634 looking up interface members.
15636 * const.cs: Create our own emit context during the Definition
15637 stage, so that constants are evaluated in the proper context, when
15638 a recursive definition happens.
15640 2003-05-11 Martin Baulig <martin@ximian.com>
15642 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15643 new block for a switch section.
15644 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15645 the adding/lookup in the switch block. Fixes #39828.
15647 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15649 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15650 functionality: I needed to convert the data after I had performed
15651 the add/sub operation into the operands type size.
15653 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15654 pass the type for the box operation, otherwise the resulting
15655 object would have been of type object.
15657 (BoxedCast): Add constructor to specify the type to box as.
15659 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15661 * iterators.cs: I was reusing the `count' variable inadvertently,
15662 take steps to not allow this to happen.
15664 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15666 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15667 by creating an array at the point where the params starts and
15668 putting all those arguments there, then adjusting the size of the
15671 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15673 * expression.cs (New.AddressOf): Implement interface
15674 IMemoryLocation. This is used when the `new' operator is used in
15675 the context of an invocation to a method on a value type.
15677 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15680 * namespace.cs: Also check the using aliases here.
15682 * driver.cs: Move the test for using validity after the types have
15683 been entered, so we do a single pass that also includes the using
15686 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15687 in the regular case. CreateSiblingForFinally is doing extra
15690 * attribute.cs (GetAttributeArgumentExpression): Store the result
15691 on an out value, and use the return value to indicate failure
15692 instead of using null (which is a valid return for Constant.GetValue).
15694 * statement.cs: Perform the analysis flow for the increment
15695 portion after the statement, because this will be the real flow of
15696 execution. Fixes #42385
15698 * codegen.cs (EmitContext.EmitArgument,
15699 EmitContext.EmitStoreArgument): New helper functions when the
15700 RemapToProxy flag is set.
15702 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15705 Add support for remapping parameters.
15707 * iterators.cs: Propagate parameter values; Store parameter
15708 values in the proxy classes.
15710 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15712 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15713 need a proxy reference; I do not know what I was thinking
15715 * cs-parser.jay (constructor_initializer): catch another error,
15716 and display nice message.
15718 (field_declaration): catch void field declaration
15719 to flag a better error.
15721 * class.cs (MemberBase.CheckBase): Report an error instead of a
15722 warning if a new protected member is declared in a struct.
15723 (Field.Define): catch the error of readonly/volatile.
15725 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15727 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15728 volatile variable is taken
15730 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15732 * statement.cs (Fixed.Resolve): Report an error if we are not in
15735 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15737 * typemanager.cs: reuse the code that handles type clashes for
15738 delegates and enumerations.
15740 * class.cs (Report28): Always report.
15742 * expression.cs (EncodeAsAttribute): Allow nulls here.
15744 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15746 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15747 the functionality for testing whether an expression is valid for
15748 an attribute here. Also handle the case of arrays of elements
15751 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15752 encoding a linear array into an array of objects that are suitable
15753 to be passed to an CustomAttributeBuilder.
15755 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15757 * ecore.cs: (FieldExpr): Handle field remapping here.
15759 * iteratators.cs: Pass the instance variable (if the method is an
15760 instance method) to the constructors, so we can access the field
15761 variables on the class.
15763 TODO: Test this with structs. I think the THIS variable on
15764 structs might have to be a pointer, and not a refenrece
15766 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15768 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15769 local variables to fields in a proxy class.
15771 * iterators.cs (PopulateProxy): Rename our internal fields to
15773 Create a <THIS> field if we are an instance method, so we can
15774 reference our parent container variables.
15775 (MapVariable): Called back from the EmitContext code to enter a
15776 new variable to field mapping into the proxy class (we just create
15780 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15781 for using the remapped locals to fields.
15783 I placed the code here, because that gives the same semantics to
15784 local variables, and only changes the Emit code.
15786 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15787 statements inside iterators.
15788 (VariableInfo): Add a FieldBuilder for the cases when we are
15789 remapping local variables to fields in a proxy class
15791 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15792 current_block != null.
15794 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15795 not cope with strings, as it has been moved to the
15796 TableSwitchEmit. Fixed bug in switch generation.
15798 * expression.cs (New.DoResolve): Provide more context for the user
15799 when reporting an error.
15801 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15804 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15805 check the permissions for it. Note than in a type-resolution
15806 context the check was already present in DeclSpace.ResolveType,
15807 but was missing from the MemberAccess.
15809 (ArrayCreation.CheckIndices): warn if the user has
15810 more nested levels of expressions, but there are no more
15811 dimensions specified. Avoids crash on bug 41906.
15813 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15815 * statement.cs (Block): replace Implicit bool, for a generic
15817 New flag: `Unchecked'. This is used during the EmitMeta phase
15818 (which is out-of-line with the regular Resolve/Emit process for a
15819 statement, as this is done ahead of time, but still gets a chance
15820 to call constant resolve).
15822 (Block.Flags): new enum for adding a new flag.
15824 (Block.EmitMeta): track the state of unchecked.
15826 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15827 to enable constant resolution to work there as well.
15829 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15831 * typemanager.cs (ienumerable_type): Also look up
15832 System.Collections.IEnumerable.
15834 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15836 TODO: Test more than one conditional per method.
15838 * class.cs (Indexer.Define): Report the location where the user is
15839 referencing the unsupported feature.
15841 (MethodData): Overload the use of `conditionals' to
15842 minimize the creation of needless ArrayLists. This saves roughly
15843 212kb on my machine.
15845 (Method): Implement the new IIteratorContainer interface.
15846 (Method.SetYields): Implement the method by setting the ModFlags
15847 to contain METHOD_YIELDS.
15849 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15850 which just got set to null.
15852 * iterators.cs: New file.
15854 (Yield, YieldBreak): New statements.
15856 * statement.cs (Return.Resolve): Flag an error if we are used in
15857 an iterator method.
15859 * codegen.cs (InIterator): New flag set if the code is being
15860 compiled in an iterator method.
15862 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15863 internal modifier, and we just use it to avoid adding extra
15864 fields, as this is seldom used.
15866 * cs-parser.jay: Add yield_statement (yield and yield break).
15868 * driver.cs: New flag -v2 to turn on version 2 features.
15870 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15871 hashtable when v2 is enabled.
15873 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15875 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15876 there is already a namespace defined with this name.
15878 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15879 people upgraded their corlibs.
15881 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15882 always use fully qualified types, no need to use the compiler
15885 (TypeManager.IsNamespace): Use binarysearch.
15887 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15888 AddDelegate): I did not quite use the new IsValid API properly: I
15889 have to pass the short-name and the fullname. I was passing only
15890 the basename instead of the fullname sometimes.
15892 (TypeContainer.DefineType): call NamespaceClash.
15894 * interface.cs (Interface.DefineType): use NamespaceClash before
15897 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15900 * enum.cs: (Enum.DefineType): use NamespaceClash before
15903 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15904 speed increase. First, use the negative_hits cache when we get a
15905 negative. Second, add the type with its full original name
15906 instead of the new . and + encoded name (reflection uses + to
15907 separate type from a nested type). Use LookupTypeReflection
15908 directly which bypasses the type->name hashtable (that we already
15909 know does not contain the type.
15911 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15912 location/container type.
15914 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15916 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15918 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15920 * delegate.cs (NewDelegate.Resolve): Test whether an instance
15921 method is being referenced in the method group from a static
15922 context, and report error 120 if so.
15924 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
15927 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
15928 is created, we create the A namespace).
15930 * cs-parser.jay: A namespace also introduces a DeclarationFound.
15933 2003-04-18 Miguel de Icaza <miguel@ximian.com>
15935 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
15936 invocation to ModuleBuilder.GetType with the same values will
15937 return a new type instance, so we need to cache its return
15940 * expression.cs (Binary.ResolveOperator): Only allow the compare
15941 operators on enums if they are of the same type.
15943 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
15944 types of ValueType on their own case. Before we were giving them
15945 the same treatment as objects.
15947 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
15948 fullname. Short name is used to compare against container name.
15949 Fullname is used to check against defined namespace names.
15951 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
15952 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
15954 (Method.CheckBase): Call parent.
15955 (MemberBase.CheckBase): Check for protected members on sealed
15957 (PropertyBase.CheckBase): Call parent.
15958 (Field.Define): Call parent.
15960 * report.cs: Negative error codes are now mapped to 8000 - code,
15961 so that the display is render more nicely.
15963 * typemanager.cs: Do not use try/catch, instead report a regular
15966 (GetPointerType, GetReferenceType): These methods provide
15967 mechanisms to obtain the T* and T& from a T. We had the code
15968 previously scattered around the code base, and it also used
15969 TypeManager.LookupType that would go through plenty of caches.
15970 This one goes directly to the type source.
15972 In some places we did the Type.GetType followed by
15973 ModuleBuilder.GetType, but not in others, so this unifies the
15974 processing as well.
15976 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
15977 statements now that we have namespace information.
15979 * typemanager.cs (IsNamespace): New method, returns whether the
15980 string presented is a namespace or not.
15982 (ComputeNamespaces): New public entry point, computes the list of
15983 available namespaces, using the GetNamespaces API call in Mono, or
15984 the slower version in MS.NET.
15986 Now before we start the semantic analysis phase, we have a
15987 complete list of namespaces including everything that the user has
15990 Deleted old code to cache namespaces in .nsc files.
15992 2003-04-17 Miguel de Icaza <miguel@ximian.com>
15994 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
15995 class/struct location definition Location for the implicit
15996 constructor location.
15998 (Operator.Define): Use the location of the operator for the
15999 implicit Method definition.
16001 (Constructor.Emit): use the constructor location for the implicit
16002 base initializer constructor.
16004 * ecore.cs: Remove ITypeExpression. This interface is now gone,
16005 and the Expression class now contains two new methods:
16007 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
16008 isolate type lookup from the rest of the resolution process.
16010 Since we use Expressions to hold type definitions due to the way
16011 we parse the input we have historically overloaded Resolve to
16012 perform the Type lookups if a special flag is passed. Now this is
16013 eliminated and two methods take their place.
16015 The differences in the two methods between xStep and xTerminal is
16016 that xStep is involved in our current lookup system that uses
16017 SimpleNames to compose a name, while xTerminal is used just to
16018 catch the case where the simplename lookup failed.
16020 2003-04-16 Miguel de Icaza <miguel@ximian.com>
16022 * expression.cs (ResolveMemberAccess): Remove redundant code.
16023 TypeExpr expressions are always born fully resolved.
16025 * interface.cs (PopulateMethod): Do not lookup the types twice.
16026 We were doing it once during SemanticAnalysis and once during
16029 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
16030 in local variable type definitions, were being returned as a
16031 SimpleName (we decomposed everything into a string), that is
16032 because primary_expression was being used instead of a type in the
16033 grammar (reduce/reduce conflicts).
16035 The part that was wrong is that we converted the expression into a
16036 string (an oversimplification in one hand, compounded with primary
16037 expressions doing string concatenation).
16043 Would return "A.B.C[]" as a SimpleName. This stopped things like
16044 using clauses from working on this particular context. And a type
16045 was being matched directly against "A.B.C[]".
16047 We now use the correct approach, and allow for ComposedCast to be
16048 part of the unary expression. So the "A.B.C []" become a composed
16049 cast of "A.B.C" (as a nested group of MemberAccess with a
16050 SimpleName at the end) plus the rank composition "[]".
16054 2003-04-10 Miguel de Icaza <miguel@ximian.com>
16056 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
16057 for the access level checking.
16059 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
16060 `TypeContainer container', because I kept getting confused when I
16061 was debugging this code.
16063 * expression.cs (Indexers): Instead of tracking getters/setters,
16064 we now track them in parallel. We create one arraylist less, but
16065 most importantly it is possible now for the LValue code to find a
16066 matching get for a set.
16068 (IndexerAccess.DoResolveLValue): Update the code.
16069 GetIndexersForType has been modified already to extract all the
16070 indexers from a type. The code assumed it did not.
16072 Also make the code set the correct return type for the indexer.
16073 This was fixed a long time ago for properties, but was missing for
16074 indexers. It used to be void_type.
16076 (Binary.Emit): Test first for doubles instead of
16077 floats, as they are more common.
16079 (Binary.EmitBranchable): Use the .un version of the branch opcodes
16080 when dealing with floats and the <=, >= operators. This fixes bug
16083 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
16084 to load the array value by emitting a load on the foreach variable
16085 type. This was incorrect.
16087 We now emit the code to load an element using the the array
16088 variable type, and then we emit the conversion operator.
16092 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
16094 * attribute.cs: Avoid allocation of ArrayLists in the common case.
16096 2003-04-09 Miguel de Icaza <miguel@ximian.com>
16098 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
16099 test for protection before we test for signatures.
16101 (MethodSignature.ToString): implement.
16103 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
16104 to the case where we reduced into a LongConstant.
16106 * decl.cs (CheckAccessLevel): If the type is an array, we can not
16107 depend on whether the information is acurrate, because the
16108 Microsoft runtime will always claim that the array type is public,
16109 regardless of the real state.
16111 If the type is a pointer, another problem happens: the type is
16112 reported as non-public in Microsoft.
16114 In both cases we have to call CheckAccessLevel recursively with
16115 the underlying type as the argument to be tested.
16117 2003-04-08 Miguel de Icaza <miguel@ximian.com>
16119 * assign.cs (Assign.Emit): If we are dealing with a compound
16120 assignment expression, we should use the code path that stores the
16121 intermediate result in a temporary value. This fixes #40903.
16123 *expression.cs (Indirection.ToString): Provide ToString method for
16126 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
16128 * class.cs: Null out fields holding references to Block objects so
16129 they can be garbage collected.
16131 * expression.cs (OverloadResolve): Remove unused local.
16133 2003-04-07 Martin Baulig <martin@ximian.com>
16135 * codegen.cs (EmitContext.CurrentFile): New public field.
16136 (EmitContext.Mark): Use the CurrentFile to check whether the
16137 location is in the correct file.
16138 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
16140 2003-04-07 Martin Baulig <martin@ximian.com>
16142 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
16144 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
16145 location. [FIXME: The location argument which gets passed to this
16146 method is sometimes wrong!]
16148 2003-04-07 Nick Drochak <ndrochak@gol.com>
16150 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
16152 2003-04-07 Miguel de Icaza <miguel@ximian.com>
16154 * expression.cs (Indirection.EmitAssign): We were using the
16155 temporary, but returning immediately instead of continuing the
16158 2003-04-06 Martin Baulig <martin@ximian.com>
16160 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
16161 if it's a nested child, but also deriving from the outer class.
16164 * typemanager.cs (IsNestedChildOf): Make this work if it's a
16165 nested child, but also deriving from the outer class. See
16167 (FilterWithClosure): We may access private members of the outer
16168 class if we're a nested child and deriving from the outer class.
16169 (RealMemberLookup): Only set `closure_private_ok' if the
16170 `original_bf' contained BindingFlags.NonPublic.
16172 2003-04-05 Martin Baulig <martin@ximian.com>
16174 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
16175 probe if its a type parameter, and if so, flag an error.
16177 * decl.cs: Move here the SetParameterInfo code from class.cs.
16178 Handle IsGeneric here.
16180 Handle a variety of errors in the parameter info definition.
16182 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
16183 type parameters here.
16185 * cs-parser.jay (class_declaration): report errors for parameters
16188 2003-01-21 Miguel de Icaza <miguel@ximian.com>
16190 * generic.cs: New file, contains support code for generics.
16192 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
16193 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
16195 Update parser for the above removals.
16197 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
16198 now taken care of in the parser.
16200 2003-04-02 Miguel de Icaza <miguel@ximian.com>
16202 * class.cs (Event.Define): Do not allow abstract events to have
16205 2003-04-01 Miguel de Icaza <miguel@ximian.com>
16207 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
16208 block in event declarations.
16210 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
16211 value type, get its address.
16213 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
16214 leaving a class on the stack instead of a boolean value (int
16215 0/1). Change the code so we compare against null, and then the
16216 result against zero.
16218 * class.cs (TypeContainer.GetClassBases): We were checking for the
16219 parent class being sealed too late.
16221 * expression.cs (Binary.Emit): For <= and >= when dealing with
16222 floating point values, use cgt.un and clt.un instead of cgt and
16225 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
16227 * statement.cs: Apply the same optimization as MS: skip the
16228 GetEnumerator returning an IEnumerator, and use the one returning a
16229 CharEnumerator instead. This allows us to avoid the try-finally block
16232 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
16234 * cs-parser.jay: Attributes cannot be applied to
16235 namespaces. Fixes #40473
16237 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16240 (Add*): check if the name is valid using the full name for constants,
16241 fields, properties and events.
16243 2003-03-28 Miguel de Icaza <miguel@ximian.com>
16245 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
16246 char constants to be part of the enumeration.
16248 * expression.cs (Conditional.DoResolve): Add support for operator
16249 true. Implements the missing functionality from 14.12
16251 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
16252 operator true/false as required by the spec.
16254 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
16255 implicit conversion to boolean.
16257 * statement.cs (Statement.ResolveBoolean): A boolean expression is
16258 also one where the type implements `operator true'.
16260 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
16261 get an expression that will invoke operator true based on an
16264 (GetConversionOperators): Removed the hack that called op_True
16267 (Expression.ResolveBoolean): Move this from Statement.
16269 2003-03-17 Miguel de Icaza <miguel@ximian.com>
16271 * ecore.cs (FieldExpr): do not allow initialization of initonly
16272 fields on derived classes
16274 2003-03-13 Martin Baulig <martin@ximian.com>
16276 * statement.cs (Block.Emit): Call ig.BeginScope() and
16277 ig.EndScope() when compiling with debugging info; call
16278 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
16280 2003-03-08 Miguel de Icaza <miguel@ximian.com>
16282 * expression.cs (Indexers): Do not construct immediately, allow
16283 for new members to be appended as we go. Fixes 38143
16285 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16287 * expression.cs: save/restore context when resolving an unchecked
16290 2003-03-05 Miguel de Icaza <miguel@ximian.com>
16292 * cfold.cs: Catch division by zero in modulus operator during
16295 2003-03-03 Miguel de Icaza <miguel@ximian.com>
16297 * interface.cs (Interface.DefineMembers): Avoid defining members
16300 2003-02-27 Miguel de Icaza <miguel@ximian.com>
16302 * driver.cs: handle the +/- options for -noconfig
16304 * statement.cs (Unckeched.Resolve): Also track the state of
16305 unchecked in the Resolve phase.
16307 2003-02-27 Martin Baulig <martin@ximian.com>
16309 * ecore.cs (Expression.MemberLookup): Don't create a
16310 MethodGroupExpr for something which is not a method. Fixes #38291.
16312 2003-02-25 Miguel de Icaza <miguel@ximian.com>
16314 * class.cs (MemberBase.CheckParameters): Also check that the type
16315 is unmanaged if it is a pointer.
16317 * expression.cs (SizeOf.Resolve): Add location information.
16319 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
16320 a managed type is declared.
16322 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
16323 parameter modifiers as well. Fixes bug 38606
16325 * class.cs: Very sad. Am backing out the speed up changes
16326 introduced by the ArrayList -> Array in the TypeContainer, as they
16327 were not actually that much faster, and introduced a bug (no error
16328 reports on duplicated methods).
16330 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
16331 source first, this will guarantee that we have a valid expression
16332 before calling in lower levels functions that will require a
16333 resolved object. Then use this original_source in the
16334 target.ResolveLValue instead of the original source that was
16337 Another change. Use target.Resolve instead of LValueResolve.
16338 Although we are resolving for LValues, we will let the Assign code
16339 take care of that (it will be called again from Resolve). This
16340 basically allows code like this:
16342 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
16343 class Y { void A (X x) { x [0] += o; }
16345 The problem was that the indexer was trying to resolve for
16346 set_Item (idx, object o) and never finding one. The real set_Item
16347 was set_Item (idx, X). By delaying the process we get the right
16352 2003-02-23 Martin Baulig <martin@ximian.com>
16354 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
16355 while calling DoEmit ().
16357 * codegen.cs (EmitContext.Mark): Don't mark locations in other
16358 source files; if you use the #line directive inside a method, the
16359 compiler stops emitting line numbers for the debugger until it
16360 reaches the end of the method or another #line directive which
16361 restores the original file.
16363 2003-02-23 Martin Baulig <martin@ximian.com>
16365 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
16367 2003-02-23 Martin Baulig <martin@ximian.com>
16369 * statement.cs (Block.AddChildVariableNames): We need to call this
16370 recursively, not just for our immediate children.
16372 2003-02-23 Martin Baulig <martin@ximian.com>
16374 * class.cs (Event.Define): Always make the field private, like csc does.
16376 * typemanager.cs (TypeManager.RealMemberLookup): Make events
16377 actually work, fixes bug #37521.
16379 2003-02-23 Miguel de Icaza <miguel@ximian.com>
16381 * delegate.cs: When creating the various temporary "Parameters"
16382 classes, make sure that we call the ComputeAndDefineParameterTypes
16383 on those new parameters (just like we do with the formal ones), to
16384 allow them to be resolved in the context of the DeclSpace.
16386 This fixes the bug that Dick observed in Bugzilla #38530.
16388 2003-02-22 Miguel de Icaza <miguel@ximian.com>
16390 * expression.cs (ResolveMemberAccess): When resolving a constant,
16391 do not attempt to pull a constant if the value was not able to
16392 generate a valid constant.
16394 * const.cs (LookupConstantValue): Do not report more errors than required.
16396 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16398 * expression.cs: fixes bug #38328.
16400 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16402 * class.cs: Changed all the various members that can be part of a
16403 class from being an ArrayList to be an Array of the right type.
16404 During the DefineType type_list, interface_list, delegate_list and
16405 enum_list are turned into types, interfaces, delegates and enums
16408 And during the member population, indexer_list, event_list,
16409 constant_list, field_list, instance_constructor_list, method_list,
16410 operator_list and property_list are turned into their real arrays.
16412 Although we could probably perform this operation earlier, for
16413 good error reporting we need to keep the lists and remove the
16414 lists for longer than required.
16416 This optimization was triggered by Paolo profiling the compiler
16417 speed on the output of `gen-sample-program.pl' perl script.
16419 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
16420 not crash in methods like MemberLookupFailed that use this field.
16422 This problem arises when the compiler fails to resolve a type
16423 during interface type definition for example.
16425 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16427 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
16428 inherit from System.Object, so we have to stop at null, not only
16429 when reaching System.Object.
16431 2003-02-17 Miguel de Icaza <miguel@ximian.com>
16433 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
16434 DeclaredOnly because the parent indexer might have had a different
16435 name, but did not loop until the top of the hierarchy was reached.
16437 The problem this one fixes is 35492: when a class implemented an
16438 indexer from an interface, we were getting the interface method
16439 (which was abstract) and we were flagging an error (can not invoke
16442 This also keeps bug 33089 functioning, and test-148 functioning.
16444 * typemanager.cs (IsSpecialMethod): The correct way of figuring
16445 out if a method is special is to see if it is declared in a
16446 property or event, or whether it is one of the predefined operator
16447 names. This should fix correctly #36804.
16449 2003-02-15 Miguel de Icaza <miguel@ximian.com>
16451 The goal here is to remove the dependency on EmptyCast.Peel ().
16452 Killing it completely.
16454 The problem is that currently in a number of places where
16455 constants are expected, we have to "probe" for an EmptyCast, and
16456 Peel, which is not the correct thing to do, as this will be
16457 repetitive and will likely lead to errors.
16459 The idea is to remove any EmptyCasts that are used in casts that
16460 can be reduced to constants, so we only have to cope with
16463 This bug hunt was triggered by Bug 37363 and the desire to remove
16464 the duplicate pattern where we were "peeling" emptycasts to check
16465 whether they were constants. Now constants will always be
16468 * ecore.cs: Use an enumconstant here instead of wrapping with
16471 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
16472 throwing me off. By handling this we can get rid of a few hacks.
16474 * statement.cs (Switch): Removed Peel() code.
16476 2003-02-14 Miguel de Icaza <miguel@ximian.com>
16478 * class.cs: Location information for error 508
16480 * expression.cs (New.DoResolve): Add a guard against double
16481 resolution of an expression.
16483 The New DoResolve might be called twice when initializing field
16484 expressions (see EmitFieldInitializers, the call to
16485 GetInitializerExpression will perform a resolve on the expression,
16486 and later the assign will trigger another resolution
16488 This leads to bugs (#37014)
16490 * delegate.cs: The signature for EndInvoke should contain any ref
16491 or out parameters as well. We were not doing this in the past.
16493 * class.cs (Field.Define): Do not overwrite the type definition
16494 inside the `volatile' group. Turns out that volatile enumerations
16495 were changing the type here to perform a validity test, which
16498 2003-02-12 Miguel de Icaza <miguel@ximian.com>
16500 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
16501 and structs, we do not want to load the instance variable
16503 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
16504 enum_type has to be handled like an object reference (implicit
16505 conversions exists from this to object), but the regular IsClass
16506 and IsValueType tests will never return true for this one.
16508 Also we use TypeManager.IsValueType instead of type.IsValueType,
16509 just for consistency with the rest of the code (this is only
16510 needed if we ever use the construct exposed by test-180.cs inside
16511 corlib, which we dont today).
16513 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
16515 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
16518 2003-02-09 Martin Baulig <martin@ximian.com>
16520 * namespace.cs (Namespace..ctor): Added SourceFile argument.
16521 (Namespace.DefineNamespaces): New static public method; this is
16522 called when we're compiling with debugging to add all namespaces
16523 to the symbol file.
16525 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
16526 pass it to the Namespace's .ctor.
16528 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
16529 and MethodBase arguments; pass the namespace ID to the symwriter;
16530 pass the MethodBase instead of the token to the symwriter.
16531 (SymbolWriter.DefineNamespace): New method to add a namespace to
16534 2003-02-09 Martin Baulig <martin@ximian.com>
16536 * symbolwriter.cs: New file. This is a wrapper around
16537 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
16538 methods here in near future.
16540 2003-02-09 Martin Baulig <martin@ximian.com>
16542 * codegen.cs (EmitContext.Mark): Just pass the arguments to
16543 ILGenerator.MarkSequencePoint() which are actually used by the
16546 2003-02-09 Martin Baulig <martin@ximian.com>
16548 * location.cs (SourceFile): New public sealed class. This
16549 contains the name and an index which is used in the location's token.
16550 (Location): Reserve an appropriate number of bits in the token for
16551 the source file instead of walking over that list, this gives us a
16552 really huge performance improvement when compiling with debugging.
16554 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
16555 `SourceFile' argument instead of a string.
16556 (Driver.ProcessFile): Add all the files via Location.AddFile(),
16557 but don't parse/tokenize here, we need to generate the list of all
16558 source files before we do that.
16559 (Driver.ProcessFiles): New static function. Parses/tokenizes all
16562 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
16563 instead of a string.
16565 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16568 2003-02-09 Martin Baulig <martin@ximian.com>
16570 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16571 filename on `#line default'.
16573 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16575 * statement.cs: don't clear the pinned var when the fixed statement
16576 returns from the method (fixes bug#37752).
16578 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16580 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16583 2003-02-07 Martin Baulig <martin@ximian.com>
16585 * driver.cs: Removed the `--debug-args' command line argument.
16587 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16588 automatically by the AsssemblyBuilder.
16589 (CodeGen.InitializeSymbolWriter): We don't need to call any
16590 initialization function on the symbol writer anymore. This method
16591 doesn't take any arguments.
16593 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16595 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16596 from referenced assemblies as well.
16598 2003-02-02 Martin Baulig <martin@ximian.com>
16600 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16602 2003-02-02 Martin Baulig <martin@ximian.com>
16604 * class.cs (Constructor.Emit): Open the symbol writer before
16605 emitting the constructor initializer.
16606 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16607 single-stepping through constructor initializers.
16609 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16611 * class.cs: Handle error 549: do not allow virtual methods in
16614 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16616 * decl.cs: Check access levels when resolving types
16618 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16620 * statement.cs: Add parameters and locals set in catch blocks that might
16621 return to set vector
16623 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16625 * class.cs (Operator): Set the SpecialName flags for operators.
16627 * expression.cs (Invocation.DoResolve): Only block calls to
16628 accessors and operators on SpecialName methods.
16630 (Cast.TryReduce): Handle conversions from char constants.
16633 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16635 * statement.cs: small memory and time optimization in FlowBranching.
16637 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16639 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16640 problem that the last fix but in the other sid (Set).
16642 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16643 access when there is no indexer in the hierarchy.
16645 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16647 * class.cs: Combine some if statements.
16649 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16651 * driver.cs: fixed bug #37187.
16653 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16655 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16656 any indexer, it's needed to build a list with all the indexers in the
16657 hierarchy (AllGetters), else we have problems. Fixes #35653.
16659 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16661 * class.cs (MethodData.Define): It is wrong for an interface
16662 implementation to be static in both cases: explicit and implicit.
16663 We were only handling this in one case.
16665 Improve the if situation there to not have negations.
16667 * class.cs (Field.Define): Turns out that we do not need to check
16668 the unsafe bit on field definition, only on usage. Remove the test.
16670 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16672 * driver.cs: use assembly.Location instead of Codebase (the latest
16673 patch made mcs fail when using MS assemblies).
16675 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16677 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16678 get the path to *corlib.dll.
16680 2003-01-21 Nick Drochak <ndrochak@gol.com>
16684 * typemanager.cs: Remove compiler warnings
16686 2003-01-20 Duncan Mak <duncan@ximian.com>
16688 * AssemblyInfo.cs: Bump the version number to 0.19.
16690 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16692 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16694 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16696 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16698 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16700 * cs-parser.jay: Small fix: we were not comparing the constructor
16701 name correctly. Thanks to Zoltan for the initial pointer.
16703 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16705 * cs-tokenizer.cs: Set file name when specified with #line
16707 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16709 * cs-parser.jay: Only perform the constructor checks here if we
16710 are named like the class; This will help provider a better
16711 error. The constructor path is taken when a type definition is
16712 not found, but most likely the user forgot to add the type, so
16713 report that rather than the constructor error.
16715 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16717 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16720 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16722 * cs-parser.jay: Add cleanup call.
16724 2003-01-13 Duncan Mak <duncan@ximian.com>
16726 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16727 consistent with other methods.
16729 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16731 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16733 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16735 * attribute.cs: only set GuidAttr to true when we have a
16738 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16742 * typemanager.cs: fixes to allow mcs compile corlib with the new
16743 Type.IsSubclassOf fix.
16745 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16747 * expression.cs (LocalVariableReference.DoResolve): Classify a
16748 constant as a value, not as a variable. Also, set the type for
16751 * cs-parser.jay (fixed_statement): take a type instead of a
16752 pointer_type, so we can produce a better error message later.
16754 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16757 (For.DoEmit): Make inifinite loops have a
16758 non-conditional branch back.
16760 (Fixed.DoEmit): First populate the pinned variables, then emit the
16761 statement, then clear the variables. Before I was emitting the
16762 code once for each fixed piece.
16765 2003-01-08 Martin Baulig <martin@ximian.com>
16767 * statement.cs (FlowBranching.MergeChild): A break in a
16768 SWITCH_SECTION does not leave a loop. Fixes #36155.
16770 2003-01-08 Martin Baulig <martin@ximian.com>
16772 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16773 lives in the same number space than `param_map'. Fixes #36154.
16775 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16777 * cs-parser.jay (constructor_declaration): Set the
16778 Constructor.ModFlags before probing for it. This makes the
16779 compiler report 514, 515 and 132 (the code was there, but got
16782 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16783 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16784 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16786 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16788 * enum.cs: create the enum static fields using the enum type.
16790 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16792 * class.cs: don't try to create the ParamBuilder for the return
16793 type if it's not needed (and handle it breaking for the ms runtime
16796 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16798 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16800 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16802 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16803 the command. This showed up while compiling the JANET source
16804 code, which used \r as its only newline separator.
16806 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16808 * class.cs (Method.Define): If we are an operator (because it
16809 reuses our code), then set the SpecialName and HideBySig. #36128
16811 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16813 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16814 exception, report error 120 `object reference required'.
16816 * driver.cs: Add --pause option, used during to measure the size
16817 of the process as it goes with --timestamp.
16819 * expression.cs (Invocation.DoResolve): Do not allow methods with
16820 SpecialName to be invoked.
16822 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16824 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16825 number before adding it.
16827 2002-12-21 Ravi Pratap <ravi@ximian.com>
16829 * ecore.cs (StandardImplicitConversion): When in an unsafe
16830 context, we allow conversion between void * to any other pointer
16831 type. This fixes bug #35973.
16833 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16835 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16836 is not thrown when extensionless outputs are used
16838 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16840 * rootcontext.cs: fixed compilation of corlib.
16842 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16844 * attribute.cs (Attributes.Contains): Add new method.
16846 * class.cs (MethodCore.LabelParameters): if the parameter is an
16847 `out' parameter, check that no attribute `[In]' has been passed.
16849 * enum.cs: Handle the `value__' name in an enumeration.
16851 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16853 * decl.cs: Added special case to allow overrides on "protected
16856 2002-12-18 Ravi Pratap <ravi@ximian.com>
16858 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16859 since it makes much more sense.
16861 (Attributes.ctor): Don't require a Location parameter.
16863 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16865 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16866 since we already have that information per attribute.
16868 * everywhere : make appropriate changes.
16870 * class.cs (LabelParameters): Write the code which actually
16871 applies attributes to the return type. We can't do this on the MS
16872 .NET runtime so we flag a warning in the case an exception is
16875 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16877 * const.cs: Handle implicit null conversions here too.
16879 2002-12-17 Ravi Pratap <ravi@ximian.com>
16881 * class.cs (MethodCore.LabelParameters): Remove the extra
16882 Type [] parameter since it is completely unnecessary. Instead
16883 pass in the method's attributes so that we can extract
16884 the "return" attribute.
16886 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16888 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16889 of ignoring it and letting the compile continue.
16891 * typemanager.cs (ChangeType): use an extra argument to return an
16892 error condition instead of throwing an exception.
16894 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16896 * expression.cs (Unary.TryReduce): mimic the code for the regular
16897 code path. Perform an implicit cast in the cases where we can
16898 implicitly convert to one of the integral types, and then reduce
16899 based on that constant. This fixes bug #35483.
16901 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16903 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16905 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16907 * namespace.cs: fixed bug #35489.
16909 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16911 * class.cs: Remove some dead code.
16913 * cs-parser.jay: Estimate the number of methods needed
16914 (RootContext.MethodCount);
16916 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16917 numbers instead of StringBuilders.
16919 * support.cs (PtrHashtable): Add constructor with initial size;
16920 We can now reduce reallocations of the method table.
16922 2002-12-10 Ravi Pratap <ravi@ximian.com>
16924 * attribute.cs (ApplyAttributes): Keep track of the emitted
16925 attributes on a per-target basis. This fixes bug #35413.
16927 2002-12-10 Miguel de Icaza <miguel@ximian.com>
16929 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
16930 default to the Windows 1252 encoding.
16932 (UnixParseOption): Support version, thanks to Alp for the missing
16935 * AssemblyInfo.cs: Add nice assembly information.
16937 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
16940 * cs-parser.jay: Allow a trailing comma before the close bracked
16941 in the attribute_section production.
16943 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
16944 address of the instance was being taken, I will take this out,
16945 because we take the address of the object immediately here.
16947 2002-12-09 Ravi Pratap <ravi@ximian.com>
16949 * typemanager.cs (AreMultipleAllowed): Take care of the most
16950 obvious case where attribute type is not in the current assembly -
16953 2002-12-08 Miguel de Icaza <miguel@ximian.com>
16955 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
16956 definitions, instead of doing that afterwards.
16958 Also we use a nice little hack, depending on the constructor, we
16959 know if we are a "composed" name or a simple name. Hence, we
16960 avoid the IndexOf test, and we avoid
16962 * codegen.cs: Add code to assist in a bug reporter to track down
16963 the source of a compiler crash.
16965 2002-12-07 Ravi Pratap <ravi@ximian.com>
16967 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
16968 types have been emitted for a given element and flag an error
16969 if something which does not have AllowMultiple set is used more
16972 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
16973 attribute types and their corresponding AllowMultiple properties
16975 (AreMultipleAllowed): Check the property for a given type.
16977 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
16978 property in the case we have a TypeContainer.
16980 (Attributes.AddAttribute): Detect duplicates and just skip on
16981 adding them. This trivial fix catches a pretty gross error in our
16982 attribute emission - global attributes were being emitted twice!
16984 Bugzilla bug #33187 is now fixed.
16986 2002-12-06 Miguel de Icaza <miguel@ximian.com>
16988 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
16989 instead of pp_and).
16991 * expression.cs (Binary.ResolveOperator): I can only use the
16992 Concat (string, string, string) and Concat (string, string,
16993 string, string) if the child is actually a concatenation of
16996 2002-12-04 Miguel de Icaza <miguel@ximian.com>
16998 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
16999 context where we need a 2-character lookahead.
17001 * pending.cs (PendingImplementation): Rework so we can keep track
17002 of interface types all the time, and flag those which were
17003 implemented by parents as optional.
17005 2002-12-03 Miguel de Icaza <miguel@ximian.com>
17007 * expression.cs (Binary.ResolveOperator): Use
17008 String.Concat(string,string,string) or
17009 String.Concat(string,string,string,string) when possible.
17011 * typemanager: More helper methods.
17014 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
17016 * pending.cs: remove the bogus return from GetMissingInterfaces()
17017 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
17019 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17021 * namespace.cs: avoid duplicated 'using xxx' being added to
17022 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
17023 when we get more than one 'using' statement for the same namespace.
17024 Report a CS0105 warning for it.
17026 2002-11-30 Miguel de Icaza <miguel@ximian.com>
17028 * cs-tokenizer.cs (consume_identifier): use read directly, instead
17029 of calling getChar/putback, uses internal knowledge of it.
17031 (xtoken): Reorder tokenizer so most common patterns are checked
17032 first. This reduces the compilation time in another 5% (from 8.11s
17033 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
17035 The parsing time is 22% of the compilation in mcs, and from that
17036 64% is spent on the tokenization process.
17038 I tried using a binary search for keywords, but this is slower
17039 than the hashtable. Another option would be to do a couple of
17042 * Not use a StringBuilder, instead use an array of chars,
17043 with a set value. Notice that this way we could catch
17044 the 645 error without having to do it *afterwards*.
17046 * We could write a hand-parser to avoid the hashtable
17047 compares altogether.
17049 The identifier consumption process takes 37% of the tokenization
17050 time. Another 15% is spent on is_number. 56% of the time spent
17051 on is_number is spent on Int64.Parse:
17053 * We could probably choose based on the string length to
17054 use Int32.Parse or Int64.Parse and avoid all the 64-bit
17057 Another 3% is spend on wrapping `xtoken' in the `token' function.
17059 Handle 0xa0 as whitespace (#34752)
17061 2002-11-26 Miguel de Icaza <miguel@ximian.com>
17063 * typemanager.cs (IsCLRType): New routine to tell whether a type
17064 is one of the builtin types.
17066 Maybe it needs to use TypeCodes to be faster. Maybe we could use
17067 typecode in more places instead of doing pointer comparissions.
17068 We could leverage some knowledge about the way the typecodes are
17071 New code to cache namespaces in assemblies, it is currently not
17072 invoked, to be used soon.
17074 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
17076 * expression.cs (Binary.ResolveOperator): specially handle
17077 strings, and do not perform user-defined operator overloading for
17080 2002-11-24 Miguel de Icaza <miguel@ximian.com>
17082 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
17083 internalcall as it is a pretty simple operation; Avoid whenever
17084 possible to call Char.IsLetter.
17086 (consume_identifier): Cut by half the number of
17087 hashtable calls by merging the is_keyword and GetKeyword behavior.
17089 Do not short-circuit, because if we do, we
17090 report errors (ie, #if false && true would produce an invalid
17094 2002-11-24 Martin Baulig <martin@ximian.com>
17096 * expression.cs (Cast.TryReduce): If we're in checked syntax,
17097 check constant ranges and report a CS0221. Fixes #33186.
17099 2002-11-24 Martin Baulig <martin@ximian.com>
17101 * cs-parser.jay: Make this work for uninitialized variable
17102 declarations in the `for' initializer. Fixes #32416.
17104 2002-11-24 Martin Baulig <martin@ximian.com>
17106 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
17107 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
17109 2002-11-24 Martin Baulig <martin@ximian.com>
17111 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
17112 argument; if true, we also check for user-defined conversions.
17113 This is only needed if both arguments are of a user-defined type.
17114 Fixes #30443, added test-175.cs.
17115 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
17117 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
17119 2002-11-24 Martin Baulig <martin@ximian.com>
17121 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
17122 function to get the store opcode.
17123 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
17124 only emit the Ldelema if the store opcode is Stobj. You must run
17125 both test-34 and test-167 to test this. Fixes #34529.
17127 2002-11-23 Martin Baulig <martin@ximian.com>
17129 * ecore.cs (Expression.MemberLookup): Added additional
17130 `qualifier_type' argument which is used when we're being called
17131 from MemberAccess.DoResolve() and null if we're called from a
17133 (Expression.MemberLookupFailed): New method to report errors; this
17134 does the CS1540 check and reports the correct error message.
17136 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
17137 argument for the CS1540 check and redone the way how we're dealing
17138 with private members. See the comment in the source code for details.
17139 (FilterWithClosure): Reverted this back to revision 1.197; renamed
17140 `closure_start_type' to `closure_qualifier_type' and check whether
17141 it's not null. It was not this filter being broken, it was just
17142 being called with the wrong arguments.
17144 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
17145 and pass it the correct `qualifier_type'; this also does the error
17148 2002-11-22 Miguel de Icaza <miguel@ximian.com>
17150 * expression.cs (Invocation.EmitParams): If the we are dealing
17151 with a non-built-in value type, load its address as well.
17153 (ArrayCreation): Use a a pretty constant instead
17154 of the hardcoded value 2. Use 6 instead of 2 for the number of
17155 static initializers.
17157 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
17158 because they are not really value types, just glorified integers.
17160 * driver.cs: Do not append .exe, the CSC compiler does not do it.
17162 * ecore.cs: Remove redundant code for enumerations, make them use
17163 the same code path as everything else, fixes the casting issue
17164 with enumerations in Windows.Forms.
17166 * attribute.cs: Do only cast to string if it is a string, the
17167 validation happens later.
17169 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
17170 people upgrade their corlibs.
17172 * ecore.cs: Oops, enumerations were not following the entire code path
17174 2002-11-21 Miguel de Icaza <miguel@ximian.com>
17176 * typemanager.cs (FilterWithClosure): Commented out the test for
17177 1540 in typemanager.cs, as it has problems when accessing
17178 protected methods from a parent class (see test-174.cs).
17180 * attribute.cs (Attribute.ValidateGuid): new method.
17181 (Attribute.Resolve): Use above.
17183 2002-11-19 Miguel de Icaza <miguel@ximian.com>
17185 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
17187 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
17188 handling for enumerations, as we only needed the TypeContainer
17189 functionality to begin with (this is required for the fix below to
17190 work for enums that reference constants in a container class for
17193 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
17195 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
17196 a valid TypeBuilder to perform lookups on.o
17198 * class.cs (InheritableMemberSignatureCompare): Use true in the
17199 call to GetGetMethod and GetSetMethod, because we are comparing
17200 the signature, and we need to get the methods *even* if they are
17203 (PropertyBase.CheckBase): ditto.
17205 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
17206 GotoCase.Resolve): Use Peel on EmpytCasts.
17208 * ecore.cs (EmptyCast): drop child, add Peel method.
17210 2002-11-17 Martin Baulig <martin@ximian.com>
17212 * ecore.cs (EmptyCast.Child): New public property.
17214 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
17215 label resolved to an EmptyCast. Fixes #34162.
17216 (GotoCase.Resolve): Likewise.
17217 (Block.EmitMeta): Likewise.
17219 2002-11-17 Martin Baulig <martin@ximian.com>
17221 * expression.cs (Invocation.BetterConversion): Prefer int over
17222 uint; short over ushort; long over ulong for integer literals.
17223 Use ImplicitConversionExists instead of StandardConversionExists
17224 since we also need to check for user-defined implicit conversions.
17225 Fixes #34165. Added test-173.cs.
17227 2002-11-16 Martin Baulig <martin@ximian.com>
17229 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
17230 with the `true' and `false' literals. Fixes #33151.
17232 2002-11-16 Martin Baulig <martin@ximian.com>
17234 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
17235 October 22nd; don't do the cs1540 check for static members.
17237 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
17238 now using our own filter here and doing the cs1540 check again.
17240 2002-11-16 Martin Baulig <martin@ximian.com>
17242 * support.cs (InternalParameters): Don't crash if we don't have
17243 any fixed parameters. Fixes #33532.
17245 2002-11-16 Martin Baulig <martin@ximian.com>
17247 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
17248 when looking up static methods to make this work on Windows.
17251 2002-11-16 Martin Baulig <martin@ximian.com>
17253 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
17254 a setter rather than using PropertyInfo.CanWrite.
17256 2002-11-15 Nick Drochak <ndrochak@gol.com>
17258 * class.cs: Allow acces to block member by subclasses. Fixes build
17261 2002-11-14 Martin Baulig <martin@ximian.com>
17263 * class.cs (Constructor.Emit): Added the extern/block check.
17266 2002-11-14 Martin Baulig <martin@ximian.com>
17268 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
17269 iteration while looking for indexers, this is needed because the
17270 indexer may have a different name in our base classes. Fixed the
17271 error reporting (no indexers at all, not get accessor, no
17272 overloaded match). Fixes bug #33089.
17273 (IndexerAccess.DoResolveLValue): Likewise.
17275 2002-11-14 Martin Baulig <martin@ximian.com>
17277 * class.cs (PropertyBase.CheckBase): Make this work for multiple
17278 indexers. Fixes the first part of bug #33089.
17279 (MethodSignature.InheritableMemberSignatureCompare): Added support
17282 2002-11-13 Ravi Pratap <ravi@ximian.com>
17284 * attribute.cs (Attribute.Resolve): Catch the
17285 NullReferenceException and report it since it isn't supposed to
17288 2002-11-12 Miguel de Icaza <miguel@ximian.com>
17290 * expression.cs (Binary.EmitBranchable): Also handle the cases for
17291 LogicalOr and LogicalAnd that can benefit from recursively
17292 handling EmitBranchable. The code now should be nice for Paolo.
17294 2002-11-08 Miguel de Icaza <miguel@ximian.com>
17296 * typemanager.cs (LookupType): Added a negative-hit hashtable for
17297 the Type lookups, as we perform quite a number of lookups on
17298 non-Types. This can be removed once we can deterministically tell
17299 whether we have a type or a namespace in advance.
17301 But this might require special hacks from our corlib.
17305 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
17306 and double which avoids a conversion from an integer to a double.
17308 * expression.cs: tiny optimization, avoid calling IsConstant,
17309 because it effectively performs the lookup twice.
17311 2002-11-06 Miguel de Icaza <miguel@ximian.com>
17313 But a bogus return here to keep the semantics of the old code
17314 until the Mono runtime is fixed.
17316 * pending.cs (GetMissingInterfaces): New method used to remove all
17317 the interfaces that are already implemented by our parent
17318 classes from the list of pending methods.
17320 * interface.cs: Add checks for calls after ResolveTypeExpr.
17322 2002-11-05 Miguel de Icaza <miguel@ximian.com>
17324 * class.cs (Class.Emit): Report warning 67: event not used if the
17325 warning level is beyond 3.
17327 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
17328 being a NullLiteral.
17330 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
17333 * class.cs (TypeContainer.GetClassBases): Cover a missing code
17334 path that might fail if a type can not be resolved.
17336 * expression.cs (Binary.Emit): Emit unsigned versions of the
17339 * driver.cs: use error 5.
17341 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
17343 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
17345 2002-11-01 Miguel de Icaza <miguel@ximian.com>
17347 * cs-parser.jay (switch_section): A beautiful patch from Martin
17348 Baulig that fixed 33094.
17350 2002-10-31 Miguel de Icaza <miguel@ximian.com>
17352 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
17353 Check whether the base is abstract and report an error if so.
17355 * expression.cs (IndexerAccess.DoResolveLValue,
17356 IndexerAccess.DoResolve): ditto.
17358 (Invocation.DoResolve): ditto.
17360 (Invocation.FullMethodDesc): Improve the report string.
17362 * statement.cs (Block): Eliminate IsVariableDefined as it is
17363 basically just a wrapper for GetVariableInfo.
17365 * ecore.cs (SimpleName): Use new
17367 * support.cs (ReflectionParamter.ParameterType): We unwrap the
17368 type, as we return the actual parameter ref/unref state on a
17371 2002-10-30 Miguel de Icaza <miguel@ximian.com>
17373 * support.cs: Return proper flags REF/OUT fixing the previous
17376 * expression.cs: Reverted last patch, that was wrong. Is_ref is
17377 not used to mean `ref' but `ref or out' in ParameterReference
17379 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
17380 full type signature instead of calling TypeManger.CSharpName
17383 * support.cs (InternalParameters.ParameterDesc): Do not compare
17384 directly to the modflags, because REF/OUT will actually be bitsets
17387 * delegate.cs (VerifyMethod): Check also the modifiers.
17389 * cs-tokenizer.cs: Fix bug where floating point values with an
17390 exponent where a sign was missing was ignored.
17392 * driver.cs: Allow multiple assemblies to be specified in a single
17395 2002-10-28 Miguel de Icaza <miguel@ximian.com>
17397 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
17398 because identifiers after a parenthesis would end up in this kind
17399 of production, and we needed to desamiguate it for having casts
17402 (UserDefinedType *) xxx
17404 2002-10-24 Miguel de Icaza <miguel@ximian.com>
17406 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
17407 we should set on the Bindingflags.NonPublic, but not turn on
17408 private_ok. private_ok controls whether a Private member is
17409 returned (this is chekced on the filter routine), while the
17410 BindingFlags.NonPublic just controls whether private/protected
17411 will be allowed. This fixes the problem part of the problem of
17412 private properties being allowed to be used in derived classes.
17414 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
17415 so we can call the children DoResolveLValue method (this will
17416 properly signal errors on lvalue assignments to base properties)
17418 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
17419 getter are null, and we have a property info, we know that this
17420 happened because the lookup failed, so we report an error 122 for
17421 protection level violation.
17423 We also silently return if setter and getter are null in the
17424 resolve functions, this condition only happens if we have flagged
17425 the error before. This is the other half of the problem.
17427 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
17428 not have accessibility information, that is why we were returning
17429 true in the filter function in typemanager.cs.
17431 To properly report 122 (property is inaccessible because of its
17432 protection level) correctly, we report this error in ResolveAccess
17433 by failing if both the setter and the getter are lacking (ie, the
17436 DoResolve and DoLResolve have been modified to check for both
17437 setter/getter being null and returning silently, the reason being
17438 that I did not want to put the knowledge about this error in upper
17441 int old = Report.Errors;
17442 x = new PropertyExpr (...);
17443 if (old != Report.Errors)
17448 So the property expr is returned, but it is invalid, so the error
17449 will be flagged during the resolve process.
17451 * class.cs: Remove InheritablePropertySignatureCompare from the
17452 class, as we no longer depend on the property signature to compute
17453 whether it is possible to implement a method or not.
17455 The reason is that calling PropertyInfo.GetGetMethod will return
17456 null (in .NET, in Mono it works, and we should change this), in
17457 cases where the Get Method does not exist in that particular
17462 class X { public virtual int A { get { return 1; } } }
17464 class Z : Y { public override int A { get { return 2; } } }
17466 Would fail in Z because the parent (Y) would not have the property
17467 defined. So we avoid this completely now (because the alternative
17468 fix was ugly and slow), and we now depend exclusively on the
17471 (PropertyBase.CheckBase): Use a method-base mechanism to find our
17472 reference method, instead of using the property.
17474 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
17475 routines are gone now.
17477 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
17478 names, they were incorrectly named.
17480 * cs-tokenizer.cs: Return are more gentle token on failure.
17482 * pending.cs (PendingImplementation.InterfaceMethod): This routine
17483 had an out-of-sync index variable, which caused it to remove from
17484 the list of pending methods the wrong method sometimes.
17486 2002-10-22 Miguel de Icaza <miguel@ximian.com>
17488 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
17489 CanWrite, because those refer to this particular instance of the
17490 property, and do not take into account the fact that we can
17491 override single members of a property.
17493 Constructor requires an EmitContext. The resolution process does
17494 not happen here, but we need to compute the accessors before,
17495 because the resolution does not always happen for properties.
17497 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
17498 subclass, before we did not update this flag, but we did update
17501 (GetAccessors): Drop this routine, as it did not work in the
17502 presence of partially overwritten set/get methods.
17504 Notice that this broke the cs1540 detection, but that will require
17507 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17511 * driver.cs: issue a warning instead of an error if we don't support
17512 debugging for the platform. Also ignore a couple of errors that may
17513 arise when trying to write the symbols. Undo my previous patch.
17515 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17517 * driver.cs: ignore /debug switch except for Unix platforms.
17519 2002-10-23 Nick Drochak <ndrochak@gol.com>
17521 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
17523 2002-10-21 Miguel de Icaza <miguel@ximian.com>
17525 * driver.cs: Do not make mcs-debug conditional, so we do not break
17526 builds that use it.
17528 * statement.cs (UsageVector.MergeChildren): I would like Martin to
17529 review this patch. But basically after all the children variables
17530 have been merged, the value of "Breaks" was not being set to
17531 new_breaks for Switch blocks. I think that it should be set after
17532 it has executed. Currently I set this to the value of new_breaks,
17533 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
17534 conservative, but I do not understand this code very well.
17536 I did not break anything in the build, so that is good ;-)
17538 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
17540 2002-10-20 Mark Crichton <crichton@gimp.org>
17542 * cfold.cs: Fixed compile blocker. Really fixed it this time.
17544 2002-10-20 Nick Drochak <ndrochak@gol.com>
17546 * cfold.cs: Fixed compile blocker.
17548 2002-10-20 Miguel de Icaza <miguel@ximian.com>
17550 * driver.cs: I was chekcing the key, not the file.
17552 2002-10-19 Ravi Pratap <ravi@ximian.com>
17554 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
17555 message that we were generating - we just need to silently return
17558 2002-10-19 Miguel de Icaza <miguel@ximian.com>
17560 * class.cs (Event.Define): Change my previous commit, as this
17561 breaks the debugger. This is a temporary hack, as it seems like
17562 the compiler is generating events incorrectly to begin with.
17564 * expression.cs (Binary.ResolveOperator): Added support for
17565 "U operator - (E x, E y)"
17567 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17570 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17571 init-only variables, but this path did not take into account that
17572 there might be also instance readonly variables. Correct this
17575 This fixes bug 32253
17577 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17580 * driver.cs: Change the extension for modules to `netmodule'
17582 * cs-parser.jay: Improved slightly the location tracking for
17583 the debugger symbols.
17585 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17586 modifiers that were specified instead of the hardcoded value
17587 (FamAndAssem). This was basically ignoring the static modifier,
17588 and others. Fixes 32429.
17590 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17591 fixed a bug in the process (32476)
17593 * expression.cs (ArrayAccess.EmitAssign): Patch from
17594 hwang_rob@yahoo.ca that fixes bug 31834.3
17596 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17598 * driver.cs: Make the module extension .netmodule.
17600 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17602 * driver.cs: Report an error if the resource file is not found
17603 instead of crashing.
17605 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17606 false, like Emit does.
17608 2002-10-16 Nick Drochak <ndrochak@gol.com>
17610 * typemanager.cs: Remove unused private member. Also reported mcs
17611 bug to report this as a warning like csc.
17613 2002-10-15 Martin Baulig <martin@gnome.org>
17615 * statement.cs (Statement.Emit): Made this a virtual method; emits
17616 the line number info and calls DoEmit().
17617 (Statement.DoEmit): New protected abstract method, formerly knows
17618 as Statement.Emit().
17620 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17622 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17624 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17625 have fixed a remaining problem: not every AddXXXX was adding a
17626 fully qualified name.
17628 Now everyone registers a fully qualified name in the DeclSpace as
17629 being defined instead of the partial name.
17631 Downsides: we are slower than we need to be due to the excess
17632 copies and the names being registered this way.
17634 The reason for this is that we currently depend (on the corlib
17635 bootstrap for instance) that types are fully qualified, because
17636 we dump all the types in the namespace, and we should really have
17637 types inserted into the proper namespace, so we can only store the
17638 basenames in the defined_names array.
17640 2002-10-10 Martin Baulig <martin@gnome.org>
17642 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17643 from bug #31834, see the bug report for a testcase which is
17646 2002-10-10 Martin Baulig <martin@gnome.org>
17648 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17649 flow analysis code for this.
17651 * statement.cs (Do, While, For): Tell the flow analysis code about
17653 (FlowBranching.UsageVector): Added support for infinite loops.
17654 (Block.Resolve): Moved the dead code elimination here and use flow
17657 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17659 * class.cs (Field.Define): Catch cycles on struct type
17662 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17663 fields if the fields are static. We only need to check instance
17666 * expression.cs (As.DoResolve): Test for reference type.
17668 * statement.cs (Using.ResolveExpression): Use
17669 ConvertImplicitRequired, not ConvertImplicit which reports an
17671 (Using.ResolveLocalVariableDecls): ditto.
17673 * expression.cs (Binary.ResolveOperator): Report errors in a few
17674 places where we had to.
17676 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17678 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17680 * expression.cs: Use StoreFromPtr instead of extracting the type
17681 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17683 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17684 an enumeration value to a System.Enum, but System.Enum is not a
17685 value type, but an class type, so we need to box.
17687 (Expression.ConvertExplicit): One codepath could return
17688 errors but not flag them. Fix this. Fixes #31853
17690 * parameter.cs (Resolve): Do not allow void as a parameter type.
17692 2002-10-06 Martin Baulig <martin@gnome.org>
17694 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17695 if it's a class type and not a struct. Fixes #31815.
17697 2002-10-06 Martin Baulig <martin@gnome.org>
17699 * statement.cs: Reworked the flow analysis code a bit to make it
17700 usable for dead code elimination.
17702 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17704 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17706 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17708 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17709 to fix the test 165, will investigate deeper.
17711 2002-10-04 Martin Baulig <martin@gnome.org>
17713 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17714 finally blocks actually work.
17715 (Try.Resolve): We don't need to create a sibling for `finally' if
17716 there is no finally block.
17718 2002-10-04 Martin Baulig <martin@gnome.org>
17720 * class.cs (Constructor.Define): The default accessibility for a
17721 non-default constructor is private, not public.
17723 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17725 * class.cs (Constructor): Make AllowedModifiers public, add
17728 * cs-parser.jay: Perform the modifiers test here, as the
17729 constructor for the Constructor class usually receives a zero
17730 because of the way we create it (first we create, later we
17731 customize, and we were never checking the modifiers).
17733 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17734 is a version of LookupTypeReflection that includes the type-name
17735 cache. This can be used as a fast path for functions that know
17736 the fully qualified name and are only calling into *.GetType() to
17737 obtain a composed type.
17739 This is also used by TypeManager.LookupType during its type
17742 (LookupType): We now also track the real type name, as sometimes
17743 we can get a quey for the real type name from things like
17744 ComposedCast. This fixes bug 31422.
17746 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17747 complete type fullname, it does not have to go through the type
17748 resolution system to obtain the composed version of the type (for
17749 obtaining arrays or pointers).
17751 (Conditional.Emit): Use the EmitBoolExpression to
17752 generate nicer code, as requested by Paolo.
17754 (ArrayCreation.CheckIndices): Use the patch from
17755 hwang_rob@yahoo.ca to validate the array initializers.
17757 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17759 * class.cs (ConstructorInitializer.Emit): simplify code by using
17760 Invocation.EmitCall, and at the same time, fix the bugs in calling
17761 parent constructors that took variable arguments.
17763 * ecore.cs (Expression.ConvertNumericExplicit,
17764 Expression.ImplicitNumericConversion): Remove the code that
17765 manually wrapped decimal (InternalTypeConstructor call is now gone
17768 * expression.cs (Cast.TryReduce): Also handle decimal types when
17769 trying to perform a constant fold on the type.
17771 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17773 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17774 that only turned off an error report, and did nothing else.
17776 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17778 * driver.cs: Handle and ignore /fullpaths
17780 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17782 * expression.cs (Binary.ResolveOperator): Catch the case where
17783 DoNumericPromotions returns true,
17785 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17787 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17789 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17792 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17794 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17795 conversion exists, but it is also required that the conversion be
17796 performed. This manifested in "(Type64Enum) 2".
17798 * class.cs (TypeManager.AddMethod): The fix is not to change
17799 AddEnum, because that one was using a fully qualified name (every
17800 DeclSpace derivative does), but to change the AddMethod routine
17801 that was using an un-namespaced name. This now correctly reports
17802 the duplicated name.
17804 Revert patch until I can properly fix it. The issue
17805 is that we have a shared Type space across all namespaces
17806 currently, which is wrong.
17808 Options include making the Namespace a DeclSpace, and merge
17809 current_namespace/current_container in the parser.
17811 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17813 * cs-parser.jay: Improve error reporting when we get a different
17814 kind of expression in local_variable_type and
17815 local_variable_pointer_type.
17817 Propagate this to avoid missleading errors being reported.
17819 * ecore.cs (ImplicitReferenceConversion): treat
17820 TypeManager.value_type as a target just like object_type. As
17825 Is valid, and needs to result in the int 1 being boxed before it
17826 is assigned to the value type v.
17828 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17829 to validate the enumeration name.
17831 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17832 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17833 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17835 * ecore.cs (TryImplicitIntConversion): When doing an
17836 implicit-enumeration-conversion, check if the type is 64-bits and
17837 perform a conversion before passing to EnumConstant.
17839 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17841 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17842 report ambiguous type references. Unlike the MS version, we
17843 report what the ambiguity is. Innovation at work ;-)
17845 (DeclSpace.FindType): Require a location argument to
17846 display when we display an ambiguous error.
17848 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17850 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17852 * expression.cs (EmitDynamicInitializers): Apply patch from
17853 hwang_rob@yahoo.ca that fixes the order in which we emit our
17856 2002-09-21 Martin Baulig <martin@gnome.org>
17858 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17859 delegate takes no arguments.
17861 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17863 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17866 * expression.cs: Extract the underlying type.
17868 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17870 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17872 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17874 * class.cs (TypeContainer.DefineType): We can not use the nice
17875 PackingSize with the size set to 1 DefineType method, because it
17876 will not allow us to define the interfaces that the struct
17879 This completes the fixing of bug 27287
17881 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17882 means also structs. This fixes part of the problem.
17883 (Expresion.ImplicitReferenceConversionExists): ditto.
17885 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17886 error if there were no errors reported during the type lookup
17887 process, to avoid duplicates or redundant errors. Without this
17888 you would get an ambiguous errors plus a type not found. We have
17889 beaten the user enough with the first error.
17891 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17894 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17895 during the resolution process, stop the lookup, this avoids
17896 repeated error reports (same error twice).
17898 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17900 * typemanager.cs (LookupType): Redo the type lookup code to match
17901 the needs of System.Reflection.
17903 The issue is that System.Reflection requires references to nested
17904 types to begin with a "+" sign instead of a dot. So toplevel
17905 types look like: "NameSpace.TopLevelClass", and nested ones look
17906 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17909 2002-09-19 Martin Baulig <martin@gnome.org>
17911 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17912 says that a method always returns or always throws an exception,
17913 don't report the CS0161.
17915 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17916 set `Returns = new_returns'.
17918 2002-09-19 Martin Baulig <martin@gnome.org>
17920 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
17921 to an enum constant, check for a CS0176.
17923 2002-09-18 Miguel de Icaza <miguel@ximian.com>
17925 * class.cs (TypeContainer.CheckPairedOperators): Now we check
17926 for operators that must be in pairs and report errors.
17928 * ecore.cs (SimpleName.DoResolveType): During the initial type
17929 resolution process, when we define types recursively, we must
17930 check first for types in our current scope before we perform
17931 lookups in the enclosing scopes.
17933 * expression.cs (MakeByteBlob): Handle Decimal blobs.
17935 (Invocation.VerifyArgumentsCompat): Call
17936 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
17937 I thought we were supposed to always call this, but there are a
17938 few places in the code where we dont do it.
17940 2002-09-17 Miguel de Icaza <miguel@ximian.com>
17942 * driver.cs: Add support in -linkres and -resource to specify the
17943 name of the identifier.
17945 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17947 * ecore.cs (StandardConversionExists): Sync with the conversion
17948 code: allow anything-* to void* conversions.
17950 (FindMostSpecificSource): Use an Expression argument
17951 instead of a Type, because we might be handed over a Literal which
17952 gets a few more implicit conversions that plain types do not. So
17953 this information was being lost.
17955 Also, we drop the temporary type-holder expression when not
17958 2002-09-17 Martin Baulig <martin@gnome.org>
17960 * class.cs (PropertyBase.CheckBase): Don't check the base class if
17961 this is an explicit interface implementation.
17963 2002-09-17 Martin Baulig <martin@gnome.org>
17965 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
17966 different `IndexerName' attributes.
17968 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
17969 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
17970 virtual CommonResolve().
17972 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17974 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
17975 and convert that to the UnderlyingType.
17977 * statement.cs (Foreach.Resolve): Indexers are just like variables
17978 or PropertyAccesses.
17980 * cs-tokenizer.cs (consume_string): Track line numbers and columns
17981 inside quoted strings, we were not doing this before.
17983 2002-09-16 Martin Baulig <martin@gnome.org>
17985 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
17986 resolve it. This is needed for the definite assignment check of the
17987 instance expression, fixes bug #29846.
17988 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
17990 2002-09-16 Nick Drochak <ndrochak@gol.com>
17992 * parameter.cs: Fix compile error. Cannot reference static member
17993 from an instance object. Is this an mcs bug?
17995 2002-09-14 Martin Baulig <martin@gnome.org>
17997 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
17998 multiple times. Fixes bug #30295, added test-166.cs.
18000 2002-09-14 Martin Baulig <martin@gnome.org>
18002 * statement.cs (Block.Emit): Don't emit unreachable code.
18003 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
18004 `break' statements.
18005 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
18007 2002-09-14 Martin Baulig <martin@gnome.org>
18009 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
18012 2002-09-14 Martin Baulig <martin@gnome.org>
18014 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
18015 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
18016 be false on the ms runtime.
18018 2002-09-13 Martin Baulig <martin@gnome.org>
18020 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
18021 the CS0038 error message.
18023 2002-09-12 Miguel de Icaza <miguel@ximian.com>
18025 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
18026 constant inside, return it.
18028 2002-09-12 Martin Baulig <martin@gnome.org>
18030 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
18031 implicit conversion can be done between enum types.
18033 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
18034 check whether an implicit conversion to the current enum's UnderlyingType
18035 exists and report an error if not.
18037 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
18038 without debugging support.
18040 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
18041 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
18043 2002-09-12 Martin Baulig <martin@gnome.org>
18045 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
18047 * ecore.cs (IMemberExpr.DeclaringType): New property.
18048 (SimpleName.SimpleNameResolve): Check whether we're accessing a
18049 nonstatic member of an outer type (CS0038).
18051 2002-09-11 Miguel de Icaza <miguel@ximian.com>
18053 * driver.cs: Activate the using-error detector at warning level
18054 4 (at least for MS-compatible APIs).
18056 * namespace.cs (VerifyUsing): Small buglett fix.
18058 * pending.cs (PendingImplementation): pass the container pointer.
18060 * interface.cs (GetMethods): Allow for recursive definition. Long
18061 term, I would like to move every type to support recursive
18062 definitions, not the current ordering mechanism that we have right
18065 The situation is this: Attributes are handled before interfaces,
18066 so we can apply attributes to interfaces. But some attributes
18067 implement interfaces, we will now handle the simple cases
18068 (recursive definitions will just get an error).
18070 * parameter.cs: Only invalidate types at the end if we fail to
18073 2002-09-09 Martin Baulig <martin@gnome.org>
18075 * ecore.cs (PropertyExpr.Emit): Also check for
18076 TypeManager.system_int_array_get_length so this'll also work when
18077 compiling corlib. Fixes #30003.
18079 2002-09-09 Martin Baulig <martin@gnome.org>
18081 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
18082 and throw an exception if we can't get the type's size. Fixed #30040,
18085 2002-09-09 Martin Baulig <martin@gnome.org>
18087 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
18089 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
18090 context. Fixes bug #30027.
18092 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
18093 virtual functions. Fixes bug #30043, added test-164.cs.
18095 2002-09-08 Ravi Pratap <ravi@ximian.com>
18097 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
18099 2002-09-08 Nick Drochak <ndrochak@gol.com>
18101 * driver.cs: Use an object to get the windows codepage since it's not a
18104 2002-09-08 Miguel de Icaza <miguel@ximian.com>
18106 * statement.cs (For.Emit): for infinite loops (test == null)
18107 return whether there is a break inside, not always "true".
18109 * namespace.cs (UsingEntry): New struct to hold the name of the
18110 using definition, the location where it is defined, and whether it
18111 has been used in a successful type lookup.
18113 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
18118 2002-09-06 Ravi Pratap <ravi@ximian.com>
18120 * attribute.cs : Fix incorrect code which relied on catching
18121 a NullReferenceException to detect a null being passed in
18122 where an object was expected.
18124 2002-09-06 Miguel de Icaza <miguel@ximian.com>
18126 * statement.cs (Try): flag the catch variable as assigned
18128 * expression.cs (Cast): Simplified by using ResolveType instead of
18129 manually resolving.
18131 * statement.cs (Catch): Fix bug by using ResolveType.
18133 2002-09-06 Ravi Pratap <ravi@ximian.com>
18135 * expression.cs (BetterConversion): Special case for when we have
18136 a NullLiteral as the argument and we have to choose between string
18137 and object types - we choose string the way csc does.
18139 * attribute.cs (Attribute.Resolve): Catch the
18140 NullReferenceException and report error #182 since the Mono
18141 runtime no more has the bug and having this exception raised means
18142 we tried to select a constructor which takes an object and is
18145 2002-09-05 Ravi Pratap <ravi@ximian.com>
18147 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
18148 message (1502, 1503) when we can't locate a method after overload
18149 resolution. This is much more informative and closes the bug
18152 * interface.cs (PopulateMethod): Return if there are no argument
18153 types. Fixes a NullReferenceException bug.
18155 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
18156 expressions too. Previously we were checking only in one place for
18157 positional arguments leaving out named arguments.
18159 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
18160 type to the enum type is not allowed. Remove code corresponding to
18163 (ConvertNumericExplicit): Allow explicit conversions from
18164 the underlying type to enum type. This precisely follows the spec
18165 and closes a bug filed by Gonzalo.
18167 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18170 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
18172 2002-09-03 Miguel de Icaza <miguel@ximian.com>
18174 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
18175 it was important that we stored the right value after the
18176 reduction in `converted'.
18178 2002-09-04 Martin Baulig <martin@gnome.org>
18180 * location.cs (Location.SymbolDocument): Use full pathnames for the
18183 2002-08-30 Miguel de Icaza <miguel@ximian.com>
18185 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
18186 of the expression resolve mechanism, because that will catch the
18187 SimpleName error failures.
18189 (Conditional): If we can not resolve the
18190 expression, return, do not crash.
18192 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18195 (location): display token name instead of its number.
18197 2002-08-28 Martin Baulig <martin@gnome.org>
18199 * expression.cs (Binary.ResolveOperator): Don't silently return
18200 but return an error if an operator cannot be applied between two
18203 2002-08-28 Martin Baulig <martin@gnome.org>
18205 * class.cs (Constructor.Define): Set the permission attributes
18206 correctly instead of making all constructors public.
18208 2002-08-28 Martin Baulig <martin@gnome.org>
18210 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
18211 for private members before reporting a CS0103; if we find anything,
18214 2002-08-28 Martin Baulig <martin@gnome.org>
18216 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
18217 to check whether `closure_start_type == closure_invocation_type',
18218 we also need to check whether `m.DeclaringType == closure_invocation_type'
18219 before bypassing the permission checks. We might be accessing
18220 protected/private members from the base class.
18221 (TypeManager.RealMemberLookup): Only set private_ok if private
18222 members were requested via BindingFlags.NonPublic.
18224 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
18226 * expression.cs (MemberAccess.ResolveMemberAccess): Set
18227 MethodGroupExpr.IsExplicitImpl if appropriate.
18228 (Invocation.DoResolve): Don't report the CS0120 for explicit
18229 interface implementations.
18231 2002-08-27 Martin Baulig <martin@gnome.org>
18233 * expression.cs (Invocation.DoResolve): If this is a static
18234 method and we don't have an InstanceExpression, we must report
18237 2002-08-25 Martin Baulig <martin@gnome.org>
18239 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
18240 `==' between a valuetype and an object.
18242 2002-08-25 Miguel de Icaza <miguel@ximian.com>
18244 * ecore.cs (TypeExpr): Provide a ToString method.
18246 2002-08-24 Martin Baulig <martin@gnome.org>
18248 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
18249 now called proggie.dbg and it's a binary file.
18251 2002-08-23 Martin Baulig <martin@gnome.org>
18253 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
18255 2002-08-23 Martin Baulig <martin@gnome.org>
18257 * struct.cs (MyStructInfo.ctor): Make this work with empty
18258 structs; it's not allowed to use foreach() on null.
18260 2002-08-23 Martin Baulig <martin@gnome.org>
18262 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
18263 writer the full pathname of the generated assembly.
18265 2002-08-23 Martin Baulig <martin@gnome.org>
18267 * statements.cs (FlowBranching.UsageVector.MergeChildren):
18268 A `finally' block never returns or breaks; improved handling of
18271 2002-08-23 Martin Baulig <martin@gnome.org>
18273 * statement.cs (Throw.Resolve): Allow `throw null'.
18275 2002-08-23 Martin Baulig <martin@gnome.org>
18277 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
18278 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
18279 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
18280 MemberLookup would return a wrong event if this is an explicit
18281 interface implementation and the class has an event with the same
18284 2002-08-23 Martin Baulig <martin@gnome.org>
18286 * statement.cs (Block.AddChildVariableNames): New public method.
18287 (Block.AddChildVariableName): Likewise.
18288 (Block.IsVariableNameUsedInChildBlock): Likewise.
18289 (Block.AddVariable): Check whether a variable name has already
18290 been used in a child block.
18292 * cs-parser.jay (declare_local_variables): Mark all variable names
18293 from the current block as being used in a child block in the
18296 2002-08-23 Martin Baulig <martin@gnome.org>
18298 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
18299 find the symbol writer.
18301 * driver.cs: csc also allows the arguments to /define being
18302 separated by commas, not only by semicolons.
18304 2002-08-23 Martin Baulig <martin@gnome.org>
18306 * interface.cs (Interface.GetMembers): Added static check for events.
18308 2002-08-15 Martin Baulig <martin@gnome.org>
18310 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
18311 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
18313 * ecore.cs (Expression.MemberLookup): Added documentation and explained
18314 why the MethodData.EmitDestructor() change was necessary.
18316 2002-08-20 Martin Baulig <martin@gnome.org>
18318 * class.cs (TypeContainer.FindMembers): Added static check for events.
18320 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
18322 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
18323 use Type.GetEvents(), not Type.FindMembers().
18325 2002-08-20 Martin Baulig <martin@gnome.org>
18327 * decl.cs (MemberCache): Added a special method cache which will
18328 be used for method-only searched. This ensures that a method
18329 search will return a MethodInfo with the correct ReflectedType for
18332 2002-08-20 Martin Baulig <martin@gnome.org>
18334 * decl.cs (DeclSpace.FindMembers): Made this public.
18336 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18338 * delegate.cs: fixed build on windows.
18339 [FIXME: Filed as bug #29150: MCS must report these errors.]
18341 2002-08-19 Ravi Pratap <ravi@ximian.com>
18343 * ecore.cs (StandardConversionExists): Return a false
18344 if we are trying to convert the void type to anything else
18345 since that is not allowed.
18347 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
18348 we flag error 70 in the event an event is trying to be accessed
18349 directly from outside the declaring type.
18351 2002-08-20 Martin Baulig <martin@gnome.org>
18353 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
18354 MemberCache from typemanager.cs to decl.cs.
18356 2002-08-19 Martin Baulig <martin@gnome.org>
18358 * class.cs (TypeContainer): Implement IMemberContainer.
18359 (TypeContainer.DefineMembers): Create the MemberCache.
18360 (TypeContainer.FindMembers): Do better BindingFlags checking; only
18361 return public members if BindingFlags.Public was given, check
18362 whether members are static.
18364 2002-08-16 Martin Baulig <martin@gnome.org>
18366 * decl.cs (DeclSpace.Define): Splitted this in Define and
18367 DefineMembers. DefineMembers is called first and initializes the
18370 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
18371 DefineMembers() on all our DeclSpaces.
18373 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
18374 but call DefineMembers() on all nested interfaces. We call their
18375 Define() in our new Define() function.
18377 * interface.cs (Interface): Implement IMemberContainer.
18378 (Interface.Define): Moved all code except the attribute stuf to
18380 (Interface.DefineMembers): Initialize the member cache.
18382 * typemanager.cs (IMemberFinder): Removed this interface, we don't
18383 need this anymore since we can use MemberCache.FindMembers directly.
18385 2002-08-19 Martin Baulig <martin@gnome.org>
18387 * typemanager.cs (MemberCache): When creating the cache for an
18388 interface type, add all inherited members.
18389 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
18390 to `out bool used_cache' and documented it.
18391 (TypeManager.MemberLookup): If we already used the cache in the first
18392 iteration, we don't need to do the interfaces check.
18394 2002-08-19 Martin Baulig <martin@gnome.org>
18396 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
18397 here from IMemberFinder and don't implement this interface anymore.
18398 (DeclSpace.MemberCache): Moved here from IMemberFinder.
18400 * typemanager.cs (IMemberFinder): This interface is now only used by
18401 classes which actually support the member cache.
18402 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
18403 since we only put DeclSpaces into this Hashtable.
18404 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
18405 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
18407 2002-08-16 Martin Baulig <martin@gnome.org>
18409 * typemanager.cs (ICachingMemberFinder): Removed.
18410 (IMemberFinder.MemberCache): New property.
18411 (TypeManager.FindMembers): Merged this with RealFindMembers().
18412 This function will never be called from TypeManager.MemberLookup()
18413 so we can't use the cache here, just the IMemberFinder.
18414 (TypeManager.MemberLookup_FindMembers): Check whether the
18415 IMemberFinder has a MemberCache and call the cache's FindMembers
18417 (MemberCache): Rewrote larger parts of this yet another time and
18418 cleaned it up a bit.
18420 2002-08-15 Miguel de Icaza <miguel@ximian.com>
18422 * driver.cs (LoadArgs): Support quoting.
18424 (Usage): Show the CSC-like command line arguments.
18426 Improved a few error messages.
18428 2002-08-15 Martin Baulig <martin@gnome.org>
18430 * typemanager.cs (IMemberContainer.Type): New property.
18431 (IMemberContainer.IsInterface): New property.
18433 The following changes are conditional to BROKEN_RUNTIME, which is
18434 defined at the top of the file.
18436 * typemanager.cs (MemberCache.MemberCache): Don't add the base
18437 class'es members, but add all members from TypeHandle.ObjectType
18438 if we're an interface.
18439 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
18440 is the current type.
18441 (MemberCache.CacheEntry.Container): Removed this field.
18442 (TypeHandle.GetMembers): Include inherited members.
18444 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18446 * typemanager.cs: fixed compilation and added a comment on a field that
18449 2002-08-15 Martin Baulig <martin@gnome.org>
18451 * class.cs (ConstructorInitializer.Resolve): In the
18452 Expression.MemberLookup call, use the queried_type as
18455 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
18456 declared' attribute, it's always true.
18457 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
18458 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
18459 temporary wrapper for FindMembers which tells MemberLookup whether
18460 members from the base classes are included in the return value.
18461 This will go away soon.
18462 (TypeManager.MemberLookup): Use this temporary hack here; once the
18463 new MemberCache is completed, we don't need to do the DeclaredOnly
18464 looping here anymore since the MemberCache will take care of this.
18465 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
18466 (MemberCache): When creating the MemberCache for a class, get
18467 members from the current class and all its base classes.
18468 (MemberCache.CacheEntry.Container): New field. This is a
18469 temporary hack until the Mono runtime is fixed to distinguish
18470 between ReflectedType and DeclaringType. It allows us to use MCS
18471 with both the MS runtime and the unfixed Mono runtime without
18472 problems and without accecting performance.
18473 (MemberCache.SearchMembers): The DeclaredOnly looping from
18474 TypeManager.MemberLookup is now done here.
18476 2002-08-14 Martin Baulig <martin@gnome.org>
18478 * statement.cs (MyStructInfo.MyStructInfo): Don't call
18479 Type.GetFields on dynamic types but get the fields from the
18480 corresponding TypeContainer.
18481 (MyStructInfo.GetStructInfo): Added check for enum types.
18483 * typemanager.cs (MemberList.IsSynchronized): Implemented.
18484 (MemberList.SyncRoot): Implemented.
18485 (TypeManager.FilterWithClosure): No need to check permissions if
18486 closure_start_type == closure_invocation_type, don't crash if
18487 closure_invocation_type is null.
18489 2002-08-13 Martin Baulig <martin@gnome.org>
18491 Rewrote TypeContainer.FindMembers to use a member cache. This
18492 gives us a speed increase of about 35% for the self-hosting MCS
18493 build and of about 15-20% for the class libs (both on GNU/Linux).
18495 * report.cs (Timer): New class to get enhanced profiling. This
18496 whole class is "TIMER" conditional since it remarkably slows down
18499 * class.cs (MemberList): New class. This is an IList wrapper
18500 which we're now using instead of passing MemberInfo[]'s around to
18501 avoid copying this array unnecessarily.
18502 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
18503 (ICachingMemberFinder, IMemberContainer): New interface.
18504 (TypeManager.FilterWithClosure): If `criteria' is null, the name
18505 has already been checked, otherwise use it for the name comparision.
18506 (TypeManager.FindMembers): Renamed to RealMemberFinder and
18507 provided wrapper which tries to use ICachingMemberFinder.FindMembers
18508 if possible. Returns a MemberList, not a MemberInfo [].
18509 (TypeHandle): New class, implements IMemberContainer. We create
18510 one instance of this class per type, it contains a MemberCache
18511 which is used to do the member lookups.
18512 (MemberCache): New class. Each instance of this class contains
18513 all members of a type and a name-based hash table.
18514 (MemberCache.FindMembers): This is our new member lookup
18515 function. First, it looks up all members of the requested name in
18516 the hash table. Then, it walks this list and sorts out all
18517 applicable members and returns them.
18519 2002-08-13 Martin Baulig <martin@gnome.org>
18521 In addition to a nice code cleanup, this gives us a performance
18522 increase of about 1.4% on GNU/Linux - not much, but it's already
18523 half a second for the self-hosting MCS compilation.
18525 * typemanager.cs (IMemberFinder): New interface. It is used by
18526 TypeManager.FindMembers to call FindMembers on a TypeContainer,
18527 Enum, Delegate or Interface.
18528 (TypeManager.finder_to_member_finder): New PtrHashtable.
18529 (TypeManager.finder_to_container): Removed.
18530 (TypeManager.finder_to_delegate): Removed.
18531 (TypeManager.finder_to_interface): Removed.
18532 (TypeManager.finder_to_enum): Removed.
18534 * interface.cs (Interface): Implement IMemberFinder.
18536 * delegate.cs (Delegate): Implement IMemberFinder.
18538 * enum.cs (Enum): Implement IMemberFinder.
18540 * class.cs (TypeContainer): Implement IMemberFinder.
18542 2002-08-12 Martin Baulig <martin@gnome.org>
18544 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
18546 2002-08-12 Martin Baulig <martin@gnome.org>
18548 * ecore.cs (ITypeExpression): New interface for expressions which
18550 (TypeExpression): Renamed to TypeLookupExpression.
18551 (Expression.DoResolve): If we're doing a types-only lookup, the
18552 expression must implement the ITypeExpression interface and we
18553 call DoResolveType() on it.
18554 (SimpleName): Implement the new ITypeExpression interface.
18555 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
18556 hack, the situation that we're only looking up types can't happen
18557 anymore when this method is called. Moved the type lookup code to
18558 DoResolveType() and call it.
18559 (SimpleName.DoResolveType): This ITypeExpression interface method
18560 is now doing the types-only lookup.
18561 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
18562 (ResolveFlags): Added MaskExprClass.
18564 * expression.cs (MemberAccess): Implement the ITypeExpression
18566 (MemberAccess.DoResolve): Added support for a types-only lookup
18567 when we're called via ITypeExpression.DoResolveType().
18568 (ComposedCast): Implement the ITypeExpression interface.
18570 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18571 Expression.Resolve() with ResolveFlags.Type instead.
18573 2002-08-12 Martin Baulig <martin@gnome.org>
18575 * interface.cs (Interface.Define): Apply attributes.
18577 * attribute.cs (Attribute.ApplyAttributes): Added support for
18578 interface attributes.
18580 2002-08-11 Martin Baulig <martin@gnome.org>
18582 * statement.cs (Block.Emit): Only check the "this" variable if we
18583 do not always throw an exception.
18585 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18586 whether the property has a set accessor.
18588 2002-08-11 Martin Baulig <martin@gnome.org>
18590 Added control flow analysis support for structs.
18592 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18593 with control flow analysis turned off.
18594 (IVariable): New interface.
18595 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18596 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18597 (FieldExpr.DoResolve): Resolve the instance expression with flow
18598 analysis turned off and do the definite assignment check after the
18599 resolving when we know what the expression will resolve to.
18601 * expression.cs (LocalVariableReference, ParameterReference):
18602 Implement the new IVariable interface, only call the flow analysis
18603 code if ec.DoFlowAnalysis is true.
18604 (This): Added constructor which takes a Block argument. Implement
18605 the new IVariable interface.
18606 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18607 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18608 This does the definite assignment checks for struct members.
18610 * class.cs (Constructor.Emit): If this is a non-static `struct'
18611 constructor which doesn't have any initializer, call
18612 Block.AddThisVariable() to tell the flow analysis code that all
18613 struct elements must be initialized before control returns from
18616 * statement.cs (MyStructInfo): New public class.
18617 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18618 argument to this indexer. If non-zero, check an individual struct
18619 member, not the whole struct.
18620 (FlowBranching.CheckOutParameters): Check struct members.
18621 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18622 overloaded versions of these methods which take an additional
18623 `int field_idx' argument to check struct members.
18624 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18625 overloaded versions of these methods which take an additional
18626 `string field_name' argument to check struct member.s
18627 (VariableInfo): Implement the IVariable interface.
18628 (VariableInfo.StructInfo): New public property. Returns the
18629 MyStructInfo instance of the variable if it's a struct or null.
18630 (Block.AddThisVariable): New public method. This is called from
18631 Constructor.Emit() for non-static `struct' constructor which do
18632 not have any initializer. It creates a special variable for the
18633 "this" instance variable which will be checked by the flow
18634 analysis code to ensure that all of the struct's fields are
18635 initialized before control returns from the constructor.
18636 (UsageVector): Added support for struct members. If a
18637 variable/parameter is a struct with N members, we reserve a slot
18638 in the usage vector for each member. A struct is considered fully
18639 initialized if either the struct itself (slot 0) or all its
18640 members are initialized.
18642 2002-08-08 Martin Baulig <martin@gnome.org>
18644 * driver.cs (Driver.MainDriver): Only report an error CS5001
18645 if there were no compilation errors.
18647 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18648 `UnsafeContext' property to determine whether the parent is in
18649 unsafe context rather than checking the parent's ModFlags:
18650 classes nested in an unsafe class are unsafe as well.
18652 2002-08-08 Martin Baulig <martin@gnome.org>
18654 * statement.cs (UsageVector.MergeChildren): Distinguish between
18655 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18656 we return. Added test17() and test18() to test-154.cs.
18658 2002-08-08 Martin Baulig <martin@gnome.org>
18660 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18661 Family access, make sure the invoking type isn't a subclass of the
18662 queried type (that'd be a CS1540).
18664 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18665 this method which takes an additional `Type invocation_type'.
18667 * expression.cs (BaseAccess.DoResolve): Use the base type as
18668 invocation and query type.
18669 (MemberAccess.DoResolve): If the lookup failed and we're about to
18670 report a CS0122, try a lookup with the ec.ContainerType - if this
18671 succeeds, we must report a CS1540.
18673 2002-08-08 Martin Baulig <martin@gnome.org>
18675 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18676 (MethodGroupExpr): Implement the IMemberExpr interface.
18678 * expression (MemberAccess.ResolveMemberAccess): No need to have
18679 any special code for MethodGroupExprs anymore, they're now
18682 2002-08-08 Martin Baulig <martin@gnome.org>
18684 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18685 Family, FamANDAssem and FamORAssem permissions.
18686 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18688 2002-08-08 Martin Baulig <martin@gnome.org>
18690 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18691 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18694 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18696 * driver.cs: implemented /resource option to embed managed resources.
18698 2002-08-07 Martin Baulig <martin@gnome.org>
18700 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18701 (FieldBase.HasFieldInitializer): New public property.
18702 (FieldBase.GetInitializerExpression): New public method. Resolves and
18703 returns the field initializer and makes sure it is only resolved once.
18704 (TypeContainer.EmitFieldInitializers): Call
18705 FieldBase.GetInitializerExpression to get the initializer, this ensures
18706 that it isn't resolved multiple times.
18708 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18709 the resolving process (SimpleName/MemberLookup) that we're currently
18710 emitting a field initializer (which must not access any instance members,
18711 this is an error CS0236).
18713 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18714 argument, if the `IsFieldInitializer' flag is set, we must report and
18715 error CS0236 and not an error CS0120.
18717 2002-08-07 Martin Baulig <martin@gnome.org>
18719 * ecore.cs (IMemberExpr): New public interface.
18720 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18721 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18722 if the expression is an IMemberExpr.
18724 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18725 to be null, implicitly default to `this' if we're non-static in
18726 this case. Simplified the code a lot by using the new IMemberExpr
18727 interface. Also fixed bug #28176 here.
18729 2002-08-06 Martin Baulig <martin@gnome.org>
18731 * cs-parser.jay (SimpleLookup): Removed. We need to create
18732 ParameterReferences during semantic analysis so that we can do a
18733 type-only search when resolving Cast, TypeOf and SizeOf.
18734 (block): Pass the `current_local_parameters' to the Block's
18737 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18738 argument to the constructor.
18739 (ConstructorInitializer.Resolve): Create a temporary implicit
18740 block with the parameters.
18742 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18743 references here if we aren't doing a type-only search.
18745 * statement.cs (Block): Added constructor which takes a
18746 `Parameters parameters' argument.
18747 (Block.Parameters): New public property.
18749 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18750 to `Parameters' and made it public readonly.
18752 2002-08-06 Martin Baulig <martin@gnome.org>
18754 * ecore.cs (Expression.Warning): Made this public as well.
18756 * report.cs (Report.Debug): Print the contents of collections.
18758 2002-08-06 Martin Baulig <martin@gnome.org>
18760 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18761 used to tell Resolve() which kinds of expressions it may return.
18762 (Expression.Resolve): Added overloaded version of this method which
18763 takes a `ResolveFlags flags' argument. This can be used to tell
18764 Resolve() which kinds of expressions it may return. Reports a
18766 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18767 ResolveFlags.SimpleName.
18768 (Expression.Error118): Added overloaded version of this method which
18769 takes a `ResolveFlags flags' argument. It uses the flags to determine
18770 which kinds of expressions are allowed.
18772 * expression.cs (Argument.ResolveMethodGroup): New public method.
18773 Resolves an argument, but allows a MethodGroup to be returned.
18774 This is used when invoking a delegate.
18776 * TODO: Updated a bit.
18778 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18780 Fixed compilation with csc.
18782 * ecore.cs: Expression.Error made public. Is this correct? Should
18783 Warning be made public too?
18785 * expression.cs: use ea.Location instead of ea.loc.
18786 [FIXME: Filed as bug #28607: MCS must report these errors.]
18788 2002-08-06 Martin Baulig <martin@gnome.org>
18790 * ecore.cs (Expression.loc): Moved the location here instead of
18791 duplicating it in all derived classes.
18792 (Expression.Location): New public property.
18793 (Expression.Error, Expression.Warning): Made them non-static and
18794 removed the location argument.
18795 (Expression.Warning): Added overloaded version which takes an
18796 `int level' argument.
18797 (Expression.Error118): Make this non-static and removed the
18798 expression and location arguments.
18799 (TypeExpr): Added location argument to the constructor.
18801 * expression.cs (StaticCallExpr): Added location argument to
18803 (Indirection, PointerArithmetic): Likewise.
18804 (CheckedExpr, UnCheckedExpr): Likewise.
18805 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18806 (StringPtr): Likewise.
18809 2002-08-05 Martin Baulig <martin@gnome.org>
18811 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18813 * assign.cs (Assign.DoResolve): Check whether the source
18814 expression is a value or variable.
18816 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18817 while resolving the corresponding blocks.
18819 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18820 an error, don't silently return null.
18822 * statement.cs (Block.AddVariable): Do the error reporting here
18823 and distinguish between CS0128 and CS0136.
18824 (Block.DoResolve): Report all unused labels (warning CS0164).
18825 (LabeledStatement): Pass the location to the constructor.
18826 (LabeledStatement.HasBeenReferenced): New property.
18827 (LabeledStatement.Resolve): Set it to true here.
18829 * statement.cs (Return.Emit): Return success even after reporting
18830 a type mismatch error (CS0126 or CS0127), this is what csc does and
18831 it avoids confusing the users with any consecutive errors.
18833 2002-08-05 Martin Baulig <martin@gnome.org>
18835 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18837 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18839 * expression.cs (MemberAccess.DoResolve): Silently return if an
18840 error has already been reported.
18842 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18843 error has already been reported.
18845 2002-08-05 Martin Baulig <martin@gnome.org>
18847 * statement.cs (UsageVector): Only initialize the `parameters'
18848 vector if we actually have any "out" parameters.
18850 2002-08-05 Martin Baulig <martin@gnome.org>
18852 * expression.cs (Binary.ResolveOperator): When combining delegates,
18853 they must have the same type.
18855 2002-08-05 Martin Baulig <martin@gnome.org>
18857 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18858 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18859 work with the ms runtime and we also don't need it: if we're a
18860 PropertyBuilder and not in the `indexer_arguments' hash, then we
18861 are a property and not an indexer.
18863 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18864 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18865 since the latter one doesn't work with the ms runtime.
18867 2002-08-03 Martin Baulig <martin@gnome.org>
18869 Fixed bugs #27998 and #22735.
18871 * class.cs (Method.IsOperator): New public field.
18872 (Method.CheckBase): Report CS0111 if there's already a method
18873 with the same parameters in the current class. Report CS0508 when
18874 attempting to change the return type of an inherited method.
18875 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18876 and it's not marked abstract or extern.
18877 (PropertyBase): New abstract base class for Property and Indexer.
18878 (PropertyBase.CheckBase): Moved here from Property and made it work
18880 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18881 the same so we can reuse it there.
18882 (Property, Indexer): Derive from PropertyBase.
18883 (MethodSignature.inheritable_property_signature_filter): New delegate
18884 to find properties and indexers.
18886 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18887 argument and improved error reporting.
18889 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18890 EmptyReadOnlyParameters and made it a property.
18892 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18893 version of this method which takes a `PropertyInfo indexer'.
18894 (TypeManager.RegisterIndexer): New method.
18896 * class.cs: Added myself as author of this file :-)
18898 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18900 * class.cs: fixed compilation on windoze.
18902 2002-08-03 Martin Baulig <martin@gnome.org>
18904 * interface.cs (Interface.GetInterfaceBases): Check whether all
18905 base interfaces are at least as accessible than the current one.
18907 * class.cs (TypeContainer.GetClassBases): Check whether base types
18908 are at least as accessible than the current type.
18909 (TypeContainer.AsAccessible): Implemented and made non-static.
18910 (MemberBase.CheckParameters): Report errors if the accessibility
18913 * delegate.cs (Delegate.Delegate): The default visibility is
18914 internal for top-level types and private for nested types.
18915 (Delegate.Define): Report errors if the accessibility checks fail.
18917 * enum.cs (Enum.Enum): The default visibility is internal for
18918 top-level types and private for nested types.
18919 (Enum.DefineType): Compute the correct visibility.
18921 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
18922 function which takes a `bool is_toplevel' instead of a TypeContainer.
18924 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
18927 2002-08-02 Martin Baulig <martin@gnome.org>
18929 * expression.cs (LocalVariableReferenc): Added constructor which
18930 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
18931 (LocalVariableReference.IsReadOnly): New property.
18932 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
18933 variable is readonly, use our own readonly flag to do this; you can
18934 use the new constructor to get a writable reference to a read-only
18937 * cs-parser.jay (foreach_statement, using_statement): Get a writable
18938 reference to the local variable.
18940 2002-08-01 Miguel de Icaza <miguel@ximian.com>
18942 * rootcontext.cs (ResolveCore): Also include System.Exception
18944 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
18945 we reach an EmptyStatement.
18947 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
18950 * expression.cs (Binary.ResolveOperator): Check error result in
18953 use brtrue/brfalse directly and avoid compares to null.
18955 2002-08-02 Martin Baulig <martin@gnome.org>
18957 * class.cs (TypeContainer.Define): Define all nested interfaces here.
18958 Fixes bug #28407, added test-155.cs.
18960 2002-08-01 Martin Baulig <martin@gnome.org>
18962 * class.cs (Event.EmitDefaultMethod): Make this work with static
18963 events. Fixes #28311, added verify-3.cs.
18965 2002-08-01 Martin Baulig <martin@gnome.org>
18967 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
18968 `is_disposable' fields.
18969 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
18970 `hm.is_disposable' if we're using the collection pattern.
18971 (Foreach.EmitCollectionForeach): Use the correct type for the
18972 enumerator's local variable, only emit the try/finally block if
18973 necessary (fixes #27713).
18975 2002-08-01 Martin Baulig <martin@gnome.org>
18977 * ecore.cs (Expression.report118): Renamed to Error118 and made
18980 * statement.cs (Throw.Resolve): Check whether the expression is of
18981 the correct type (CS0118) and whether the type derives from
18982 System.Exception (CS0155).
18983 (Catch.Resolve): New method. Do the type lookup here and check
18984 whether it derives from System.Exception (CS0155).
18985 (Catch.CatchType, Catch.IsGeneral): New public properties.
18987 * typemanager.cs (TypeManager.exception_type): Added.
18989 2002-07-31 Miguel de Icaza <miguel@ximian.com>
18991 * driver.cs: Updated About function.
18993 2002-07-31 Martin Baulig <martin@gnome.org>
18995 Implemented Control Flow Analysis.
18997 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
18998 (EmitContext.CurrentBranching): Added.
18999 (EmitContext.StartFlowBranching): Added.
19000 (EmitContext.EndFlowBranching): Added.
19001 (EmitContext.KillFlowBranching): Added.
19002 (EmitContext.IsVariableAssigned): Added.
19003 (EmitContext.SetVariableAssigned): Added.
19004 (EmitContext.IsParameterAssigned): Added.
19005 (EmitContext.SetParameterAssigned): Added.
19006 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
19007 Added control flow analysis stuff here.
19009 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
19010 resolve the expression as lvalue.
19011 (LocalVariableReference.DoResolve): Check whether the variable has
19012 already been assigned.
19013 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
19014 the parameter as assigned here.
19015 (ParameterReference.DoResolve): Check whether the parameter has already
19017 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
19018 expression as lvalue.
19020 * statement.cs (FlowBranching): New class for the flow analysis code.
19021 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
19022 (LabeledStatement.IsDefined): New public property.
19023 (LabeledStatement.AddUsageVector): New public method to tell flow
19024 analyis that the label may be reached via a forward jump.
19025 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
19027 (VariableInfo.Number): New public field. This is used by flow analysis
19028 to number all locals of a block.
19029 (Block.CountVariables): New public property. This is the number of
19030 local variables in this block (including the locals from all parent
19032 (Block.EmitMeta): Number all the variables.
19034 * statement.cs: Added flow analysis support to all classes.
19036 2002-07-31 Martin Baulig <martin@gnome.org>
19038 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
19039 To get debugging messages, compile mcs with /define:MCS_DEBUG and
19040 then use this argument.
19042 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
19044 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
19045 use this to specify /define options.
19047 2002-07-29 Martin Baulig <martin@gnome.org>
19049 * statement.cs (Fixed): Moved all code that does variable lookups
19050 and resolvings from Emit to Resolve.
19052 * statement.cs (For): Moved all code that does variable lookups
19053 and resolvings from Emit to Resolve.
19055 * statement.cs (Using): Moved all code that does variable lookups
19056 and resolvings from Emit to Resolve.
19058 2002-07-29 Martin Baulig <martin@gnome.org>
19060 * attribute.cs (Attribute.Resolve): Explicitly catch a
19061 System.NullReferenceException when creating the
19062 CustromAttributeBuilder and report a different warning message.
19064 2002-07-29 Martin Baulig <martin@gnome.org>
19066 * support.cs (ParameterData.ParameterName): Added method to
19067 get the name of a parameter.
19069 * typemanager.cs (TypeManager.IsValueType): New public method.
19071 2002-07-29 Martin Baulig <martin@gnome.org>
19073 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
19074 is a flag which specifies that it's either ref or out.
19075 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
19076 the out parameter to `out Parameter.Modifier mod', also set the
19077 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
19079 * support.cs (InternalParameters.ParameterModifier): Distinguish
19080 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19081 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19083 * expression.cs (Argument.GetParameterModifier): Distinguish
19084 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19085 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19087 2002-07-29 Martin Baulig <martin@gnome.org>
19089 * expression.cs (ParameterReference.ParameterReference): Added
19090 `Location loc' argument to the constructor.
19092 * cs-parser.jay: Pass location to ParameterReference.
19094 2002-07-28 Miguel de Icaza <miguel@ximian.com>
19096 * statement.cs (Try): Initialize the location.
19098 * cs-parser.jay: pass location to Try.
19100 * expression.cs (Unary.Reduce): Change the prototype to return
19101 whether a constant fold could be performed or not. The result is
19102 returned in an out parameters. In the case of Indirection and
19103 AddressOf, we want to perform the full tests.
19105 2002-07-26 Miguel de Icaza <miguel@ximian.com>
19107 * statement.cs (Statement.Emit): Flag dead code.
19109 2002-07-27 Andrew Birkett <andy@nobugs.org>
19111 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
19113 2002-07-27 Martin Baulig <martin@gnome.org>
19115 * class.cs (MethodData.Define): Put back call to
19116 TypeManager.AddMethod(), accidentally commented this out.
19118 * report.cs (Debug): New public method to print debugging information,
19119 this is `[Conditional ("DEBUG")]'.
19121 2002-07-26 Martin Baulig <martin@gnome.org>
19123 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
19124 (switch_statement): Push the current_block to the switch_stack and
19125 pop it again when we're done with the switch.
19126 (switch_section): The new block is a child of the current_block.
19127 Fixes bug #24007, added test-152.cs.
19129 2002-07-27 Martin Baulig <martin@gnome.org>
19131 * expression.cs (Invocation.EmitArguments): When calling a varargs
19132 function with only its fixed arguments, we need to pass an empty
19135 2002-07-27 Martin Baulig <martin@gnome.org>
19137 Mono 0.13 has been released.
19139 2002-07-25 Miguel de Icaza <miguel@ximian.com>
19141 * driver.cs: Rename --resource to --linkres, because that is what
19142 we do currently, we dont support --resource yet.
19144 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
19146 2002-07-25 Martin Baulig <martin@gnome.org>
19148 * class.cs (MethodData): New public class. This is a `method builder'
19149 class for a method or one accessor of a Property/Indexer/Event.
19150 (MethodData.GetMethodFlags): Moved here from MemberBase.
19151 (MethodData.ApplyAttributes): Likewise.
19152 (MethodData.ApplyObsoleteAttribute): Likewise.
19153 (MethodData.ApplyConditionalAttribute): Likewise.
19154 (MethodData.ApplyDllImportAttribute): Likewise.
19155 (MethodData.CheckAbstractAndExternal): Likewise.
19156 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
19157 (MethodData.Emit): Formerly known as Method.Emit().
19158 (MemberBase): Moved everything which was specific to a single
19159 accessor/method to MethodData.
19160 (Method): Create a new MethodData and call Define() and Emit() on it.
19161 (Property, Indexer, Event): Create a new MethodData objects for each
19162 accessor and call Define() and Emit() on them.
19164 2002-07-25 Martin Baulig <martin@gnome.org>
19166 Made MethodCore derive from MemberBase to reuse the code from there.
19167 MemberBase now also checks for attributes.
19169 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
19170 (MemberBase.GetMethodFlags): Moved here from class Method and marked
19172 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
19173 `CallingConventions cc' and `Attributes opt_attrs' arguments.
19174 (MemberBase.ApplyAttributes): New virtual method; applies the
19175 attributes to a method or accessor.
19176 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
19177 (MemberBase.ApplyConditionalAttribute): Likewise.
19178 (MemberBase.ApplyDllImportAttribute): Likewise.
19179 (MemberBase.CheckAbstractAndExternal): Likewise.
19180 (MethodCore.ParameterTypes): This is now a property instead of a
19181 method, it's initialized from DoDefineParameters().
19182 (MethodCore.ParameterInfo): Removed the set accessor.
19183 (MethodCore.DoDefineParameters): New protected virtual method to
19184 initialize ParameterTypes and ParameterInfo.
19185 (Method.GetReturnType): We can now simply return the MemberType.
19186 (Method.GetMethodFlags): Override the MemberBase version and add
19187 the conditional flags.
19188 (Method.CheckBase): Moved some code from Define() here, call
19189 DoDefineParameters() here.
19190 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
19191 here to avoid some larger code duplication.
19192 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
19193 ensure that abstract and external accessors don't declare a body.
19195 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
19196 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
19197 lookup in the attribute's parent classes, so we need to abort as soon
19198 as we found the first match.
19199 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
19200 the attribute has no arguments.
19202 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
19205 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19207 * cs-parser.jay: reverted previous patch.
19209 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19211 * cs-parser.jay: fixed bug #22119.
19213 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19215 * attribute.cs: fixed compilation. The error was:
19216 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
19217 be assigned to before control leaves the current method."
19218 [FIXME: Filed as bug #28186: MCS must report this error.]
19220 2002-07-25 Martin Baulig <martin@gnome.org>
19222 * attribute.cs (Attribute.Conditional_GetConditionName): New static
19223 method to pull the condition name ouf of a Conditional attribute.
19224 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
19225 the obsolete message and error flag out of an Obsolete attribute.
19227 * class.cs (Method.GetMethodFlags): New public method to get the
19228 TypeManager.MethodFlags for this method.
19229 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
19231 (Method.Define): Get and apply the Obsolete and Conditional attributes;
19232 if we're overriding a virtual function, set the new private variable
19233 `parent_method'; call the new TypeManager.AddMethod().
19235 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
19236 the MethodBuilder and the Method in a PtrHashtable.
19237 (TypeManager.builder_to_method): Added for this purpose.
19238 (TypeManager.MethodFlags): Added IsObsoleteError.
19239 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
19240 Obsolete and Conditional arguments in MethodBuilders. If we discover
19241 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
19242 the message from the attribute.
19244 2002-07-24 Martin Baulig <martin@gnome.org>
19246 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
19247 preprocessor directives, ensure that the argument to #define/#undef is
19248 exactly one identifier and that it's actually an identifier.
19250 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
19253 2002-07-24 Martin Baulig <martin@gnome.org>
19255 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
19256 initialize it to TypeManager.object_type in the constructor.
19257 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
19258 of the `hm.get_current' method if we're using the collection pattern.
19259 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
19260 for the explicit conversion to make it work when we're using the collection
19261 pattern and the `Current' property has a different return type than `object'.
19264 2002-07-24 Martin Baulig <martin@gnome.org>
19266 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
19267 does not match, but don't report any errors. This method is called in
19268 order for all methods in a MethodGroupExpr until a matching method is
19269 found, so we don't want to bail out if the first method doesn't match.
19270 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
19271 matches, report the 123. Fixes #28070.
19273 2002-07-24 Martin Baulig <martin@gnome.org>
19275 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
19276 TypeManager.TypeToCoreType() to the top of the method so the
19277 following equality checks will work. Fixes #28107.
19279 2002-07-24 Martin Baulig <martin@gnome.org>
19281 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
19282 operand is of type uint, and the other operand is of type sbyte,
19283 short or int, the operands are converted to type long." -
19284 Actually do what this comment already told us. Fixes bug #28106,
19287 2002-07-24 Martin Baulig <martin@gnome.org>
19289 * class.cs (MethodBase): New abstract class. This is now a base
19290 class for Property, Indexer and Event to avoid some code duplication
19291 in their Define() and DefineMethods() methods.
19292 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
19293 generic methods for Define() and DefineMethods().
19294 (FieldBase): Derive from MemberBase, not MemberCore.
19295 (Property): Derive from MemberBase, not MemberCore.
19296 (Property.DefineMethod): Moved all the code from this method to the
19297 new MethodBase.DefineAccessor(), just call it with appropriate
19299 (Property.Define): Call the new Property.DoDefine(), this does some
19300 sanity checks and we don't need to duplicate the code everywhere.
19301 (Event): Derive from MemberBase, not MemberCore.
19302 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
19303 accessors, this will also make them work with interface events.
19304 (Indexer): Derive from MemberBase, not MemberCore.
19305 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
19306 (Indexer.Define): Use the new MethodBase functions.
19308 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
19309 argument to the constructor.
19310 (Interface.FindMembers): Added support for interface events.
19311 (Interface.PopluateEvent): Implemented.
19313 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
19315 2002-07-22 Miguel de Icaza <miguel@ximian.com>
19317 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
19318 but this is required to check for a method name being the same as
19319 the containing class.
19323 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19325 * interface.cs: initialize variable.
19327 2002-07-23 Martin Baulig <martin@gnome.org>
19329 Implemented the IndexerName attribute in interfaces.
19331 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
19332 name if this is an explicit interface implementation.
19333 (Indexer.InterfaceIndexerName): New public variable. If we're
19334 implementing an interface indexer, this is the IndexerName in that
19335 interface. Otherwise, it's the IndexerName.
19336 (Indexer.DefineMethod): If we're implementing interface indexer,
19337 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
19338 and Pending.ImplementIndexer methods.
19339 (Indexer.Define): Also define the PropertyBuilder if we're
19340 implementing an interface indexer and this is neither an explicit
19341 interface implementation nor do the IndexerName match the one in
19344 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
19345 If a method is defined here, then we always need to create a proxy
19346 for it. This is used when implementing interface indexers.
19347 (Pending.IsInterfaceIndexer): New public method.
19348 (Pending.ImplementIndexer): New public method.
19349 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
19350 This is used when implementing interface indexers to define a proxy
19352 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
19353 define a proxy if necessary.
19355 * interface.cs (Interface.IndexerName): New public variable.
19356 (Interface.PopulateIndexer): Set the IndexerName.
19357 (Interface.DefineIndexers): New private method. Populate all the
19358 indexers and make sure their IndexerNames match.
19360 * typemanager.cs (IndexerPropertyName): Added support for interface
19363 2002-07-22 Martin Baulig <martin@gnome.org>
19365 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
19366 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
19367 ret if HasReturnLabel.
19368 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
19371 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
19372 and set the ec.LoopBeginTryCatchLevel.
19373 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
19374 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
19375 the current ec.TryCatchLevel, the branch goes out of an exception
19376 block. In this case, we need to use Leave and not Br.
19378 2002-07-22 Martin Baulig <martin@gnome.org>
19380 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
19381 block unless the block does not always return or it is contained in
19382 another try { ... } catch { ... } block. Fixes bug #26506.
19383 Added verify-1.cs to the test suite.
19385 2002-07-22 Martin Baulig <martin@gnome.org>
19387 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
19388 then we do not always return. Fixes bug #24985.
19390 2002-07-22 Martin Baulig <martin@gnome.org>
19392 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
19393 lookup on a per-class level; ie. walk up the class hierarchy until we
19394 found at least one applicable method, then choose the best among them.
19395 Fixes bug #24463 and test-29.cs.
19397 2002-07-22 Martin Baulig <martin@gnome.org>
19399 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
19400 return types of the methods. The return type is not part of the
19401 signature and we must not check it to make the `new' modifier work.
19402 Fixes bug #27999, also added test-147.cs.
19403 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
19405 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
19406 on the method's return type.
19408 2002-07-21 Martin Baulig <martin@gnome.org>
19410 * assign.cs: Make this work if the rightmost source is a constant and
19411 we need to do an implicit type conversion. Also adding a few more tests
19412 to test-38.cs which should have caught this.
19414 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
19415 target in the makefile for this. The makefile.gnu is primarily intended
19416 for end-users who don't want to debug the compiler.
19418 2002-07-21 Martin Baulig <martin@gnome.org>
19420 * assign.cs: Improved the Assign class so it can now handle embedded
19421 assignments (X = Y = Z = something). As a side-effect this'll now also
19422 consume less local variables. test-38.cs now passes with MCS, added
19423 a few new test cases to that test.
19425 2002-07-20 Martin Baulig <martin@gnome.org>
19427 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
19428 instructions. Fixes bug #27977, also added test-146.cs.
19430 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19432 * cs-tokenizer.cs: fixed getHex ().
19434 2002-07-19 Martin Baulig <martin@gnome.org>
19436 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
19437 not Type.GetType() to lookup the array type. This is needed when
19438 we're constructing an array of a user-defined type.
19439 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
19440 single-dimensional arrays, but also for single-dimensial arrays of
19443 2002-07-19 Martin Baulig <martin@gnome.org>
19445 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
19446 this function is called, it's not allowed to share LocalBuilders
19447 among ILGenerators.
19449 2002-07-19 Martin Baulig <martin@gnome.org>
19451 * expression.cs (Argument.Resolve): Report an error 118 when trying
19452 to pass a type as argument.
19454 2002-07-18 Martin Baulig <martin@gnome.org>
19456 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
19457 Conv_R_Un for the signed `long' type.
19459 2002-07-15 Miguel de Icaza <miguel@ximian.com>
19461 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
19462 `expr' for the temporary result, as that will fail if we do
19463 multiple resolves on the same expression.
19465 2002-07-05 Miguel de Icaza <miguel@ximian.com>
19467 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
19468 ec.TypeContainer for looking up aliases.
19470 * class.cs (TypeContainer): Remove LookupAlias from here.
19472 * decl.cs (DeclSpace); Move here.
19474 2002-07-01 Miguel de Icaza <miguel@ximian.com>
19476 * class.cs (FindMembers): Only call filter if the constructor
19477 bulider is not null.
19479 Also handle delegates in `NestedTypes' now. Now we will perform
19480 type lookups using the standard resolution process. This also
19483 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
19484 This uses Expressions (the limited kind that can be parsed by the
19485 tree) instead of strings.
19487 * expression.cs (ComposedCast.ToString): Implement, used to flag
19488 errors since now we have to render expressions.
19490 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
19493 * ecore.cs (SimpleName.ToString): ditto.
19495 * cs-parser.jay: Instead of using strings to assemble types, use
19496 Expressions to assemble the type (using SimpleName, ComposedCast,
19497 MemberAccess). This should fix the type lookups in declarations,
19498 because we were using a different code path for this.
19500 * statement.cs (Block.Resolve): Continue processing statements
19501 even when there is an error.
19503 2002-07-17 Miguel de Icaza <miguel@ximian.com>
19505 * class.cs (Event.Define): Also remove the `remove' method from
19506 the list of pending items.
19508 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
19509 generate more compact code.
19511 2002-07-17 Martin Baulig <martin@gnome.org>
19513 * const.cs (Const.LookupConstantValue): Add support for constant
19514 `unchecked' and `checked' expressions.
19515 Also adding test case test-140.cs for this.
19517 2002-07-17 Martin Baulig <martin@gnome.org>
19519 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
19520 check whether mi.ReturnType implements the IEnumerator interface; the
19521 `==' and the IsAssignableFrom() will fail in this situation.
19523 2002-07-16 Ravi Pratap <ravi@ximian.com>
19525 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
19528 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19530 * expression.cs: fixed bug #27811.
19532 2002-07-14 Miguel de Icaza <miguel@ximian.com>
19534 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
19535 Molaro: when we are a ref, the value already contains a pointer
19536 value, do not take the address of it.
19538 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19539 * removed mb-parser.jay and mb-tokenizer.cs
19541 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19543 * expression.cs: check against the building corlib void type.
19545 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
19547 * ecore.cs: fix for valuetype static readonly fields: when
19548 initializing them, we need their address, not the address of a copy.
19550 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
19552 * typemanager.cs: register also enum_type in corlib.
19554 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19556 * class.cs: allow calling this (but not base) initializers in structs.
19558 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
19560 * ecore.cs: make sure we compare against the building base types
19563 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
19565 * typemanager.cs: fix TypeToCoreType() to handle void and object
19566 (corlib gets no more typerefs after this change).
19568 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19570 * expression.cs (ArrayCreation.EmitArrayArguments): use
19571 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19573 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19574 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19575 array indexes, the runtime actually forbids them.
19577 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19578 for array arguments here.
19580 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19581 instead of the default for ValueTypes.
19583 (New.DoEmit): Use IsValueType instead of
19584 IsSubclassOf (value_type)
19585 (New.DoResolve): ditto.
19586 (Invocation.EmitCall): ditto.
19588 * assign.cs (Assign): ditto.
19590 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19591 Statements *are* currently doing part of their resolution during
19594 Expressions do always resolve during resolve, but statements are
19595 only required to propagate resolution to their children.
19597 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19599 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19601 (LoadAssembly): Do not add the dll if it is already specified
19603 (MainDriver): Add the System directory to the link path at the end,
19604 after all the other -L arguments.
19606 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19607 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19608 ldelem.u1) and using the opposite for sbytes.
19610 This fixes Digger, and we can finally run it.
19612 * driver.cs (UnixParseOption): Move the option parsing here.
19613 (CSCParseOption): Implement CSC-like parsing of options.
19615 We now support both modes of operation, the old Unix way, and the
19616 new CSC-like way. This should help those who wanted to make cross
19617 platform makefiles.
19619 The only thing broken is that /r:, /reference: and /lib: are not
19620 implemented, because I want to make those have the same semantics
19621 as the CSC compiler has, and kill once and for all the confussion
19622 around this. Will be doing this tomorrow.
19624 * statement.cs (Unsafe.Resolve): The state is checked during
19625 resolve, not emit, so we have to set the flags for IsUnsfe here.
19627 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19629 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19630 not catch the Error_ObjectRefRequired in SimpleName (as it is
19631 possible to have a class/instance variable name that later gets
19632 deambiguated), we have to check this here.
19634 2002-07-10 Ravi Pratap <ravi@ximian.com>
19636 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19637 make static and put into Expression.
19639 (Event.Define): Register the private field of the event with the
19640 TypeManager so that GetFieldFromEvent can get at it.
19642 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19643 keep track of the private field associated with an event which
19646 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19649 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19651 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19653 * expression.cs (Binary.EmitBranchable): this routine emits the
19654 Binary expression in a branchable context. This basically means:
19655 we need to branch somewhere, not just get the value on the stack.
19657 This works together with Statement.EmitBoolExpression.
19659 * statement.cs (Statement.EmitBoolExpression): Use
19662 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19664 * statement.cs (For): Reduce the number of jumps in loops.
19666 (For): Implement loop inversion for the For statement.
19668 (Break): We can be breaking out of a Try/Catch controlled section
19669 (foreach might have an implicit try/catch clause), so we need to
19670 use Leave instead of Br.
19672 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19673 now). If the instace expression supports IMemoryLocation, we use
19674 the AddressOf method from the IMemoryLocation to extract the
19675 address instead of emitting the instance.
19677 This showed up with `This', as we were emitting the instance
19678 always (Emit) instead of the Address of This. Particularly
19679 interesting when This is a value type, as we dont want the Emit
19680 effect (which was to load the object).
19682 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19684 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19686 * statement.cs (Checked): Set the CheckedState during the resolve
19687 process too, as the ConvCast operations track the checked state on
19688 the resolve process, and not emit.
19690 * cs-parser.jay (namespace_member_declaration): Flag that we have
19691 found a declaration when we do. This is used to flag error 1529
19693 * driver.cs: Report ok when we display the help only.
19695 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19697 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19699 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19701 * cs-tokenizer.cs (define): We also have to track locally the
19702 defines. AllDefines is just used for the Conditional Attribute,
19703 but we also need the local defines for the current source code.
19705 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19707 * statement.cs (While, For, Do): These loops can exit through a
19708 Break statement, use this information to tell whether the
19709 statement is the last piece of code.
19711 (Break): Flag that we break.
19713 * codegen.cs (EmitContexts): New `Breaks' state variable.
19715 2002-07-03 Martin Baulig <martin@gnome.org>
19717 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19718 modifiers in method declarations in structs. Otherwise, you won't
19719 be able to override things like Object.Equals().
19721 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19723 * class.cs (Method, Property, Indexer): Do not allow the public
19724 modifier to be used in explicit interface implementations.
19726 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19727 override modifiers in method declarations in structs
19729 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19731 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19732 integer or real overflow, report an error
19734 2002-07-02 Martin Baulig <martin@gnome.org>
19736 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19737 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19738 to tell the runtime about our newly created System.Object and
19739 System.ValueType types.
19741 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19743 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19744 struct instead of Ldarg/Starg.
19746 2002-07-02 Martin Baulig <martin@gnome.org>
19748 * expression.cs (Indirection.Indirection): Call
19749 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19751 2002-07-02 Martin Baulig <martin@gnome.org>
19753 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19754 ValueType, call TypeManager.TypeToCoreType() on it.
19755 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19756 the OpCodes.Newarr argument.
19758 2002-07-02 Martin Baulig <martin@gnome.org>
19760 * expression.cs (Invocation.EmitCall): When compiling corlib,
19761 replace all calls to the system's System.Array type to calls to
19762 the newly created one.
19764 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19765 System.Array methods.
19766 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19767 from the system's System.Array type which must be replaced.
19769 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19771 * typemanager.cs: load unverifiable_code_ctor so we can build
19772 corlib using the correct type. Avoid using GetTypeCode() with
19774 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19775 TypeManager.object_type to allow building corlib.
19777 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19779 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19781 2002-07-01 Martin Baulig <martin@gnome.org>
19783 * class.cs: Make the last change actually work, we need to check
19784 whether `ifaces != null' to avoid a crash.
19786 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19788 * class.cs: when we build structs without fields that implement
19789 interfaces, we need to add the interfaces separately, since there is
19790 no API to both set the size and add the interfaces at type creation
19793 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19795 * expression.cs: the dimension arguments to the array constructors
19796 need to be converted if they are a long.
19798 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19800 * class.cs: don't emit ldarg.0 if there is no parent constructor
19801 (fixes showstopper for corlib).
19803 2002-06-29 Martin Baulig <martin@gnome.org>
19805 MCS now compiles corlib on GNU/Linux :-)
19807 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19808 ie. check for MethodImplOptions.InternalCall.
19810 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19811 and TypeManager.attribute_type are null, so we must explicitly check
19812 whether parent is not null to find out whether it's an attribute type.
19813 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19814 and SetBuilder, not only if the property is neither abstract nor external.
19815 This is necessary to set the MethodImplOptions on the accessor methods.
19816 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19817 SetBuilder, see Property.Emit().
19819 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19820 populate "System.Object", "System.ValueType" and "System.Attribute" since
19821 they've already been populated from BootCorlib_PopulateCoreTypes().
19823 2002-06-29 Martin Baulig <martin@gnome.org>
19825 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19826 is the NullLiteral, we also need to make sure that target_type is not
19829 2002-06-29 Martin Baulig <martin@gnome.org>
19831 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19832 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19833 before calling BootstrapCorlib_ResolveDelegate ().
19835 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19837 * statement.cs: fixed build-breaker. All tests passed ok.
19839 2002-06-27 Martin Baulig <martin@gnome.org>
19841 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19842 for System.Decimal when compiling corlib.
19844 2002-06-27 Martin Baulig <martin@gnome.org>
19846 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19847 switch blocks which contain nothing but a default clause.
19849 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19851 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19853 2002-06-27 Martin Baulig <martin@gnome.org>
19855 * ecore.cs (PropertyExpr.PropertyExpr): Call
19856 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19858 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19859 is already a TypeBuilder.
19861 2002-06-27 Martin Baulig <martin@gnome.org>
19863 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19864 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19865 the "from an array-type to System.Array" case. This makes it work
19866 when compiling corlib.
19868 2002-06-27 Martin Baulig <martin@gnome.org>
19870 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19871 non-static PropertyExpr, set its InstanceExpression. This makes
19872 the `ICollection.Count' property work in System/Array.cs.
19874 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19876 * driver.cs: Made error handling more consistent. Errors now
19877 tracked by Report class, so many methods which used to return int
19878 now return void. Main() now prints success/failure and
19879 errors/warnings message.
19881 Renamed '--probe' compiler argument to '--expect-error'. Removed
19882 the magic number return values (123 and 124). Now, if the
19883 expected error occurs, the compiler exits with success (exit value
19884 0). If the compilation completes without seeing that particular
19885 error, the compiler exits with failure (exit value 1). The
19886 makefile in mcs/errors has been changed to handle the new behaviour.
19888 * report.cs: Made 'expected error' number a property and renamed
19889 it from 'Probe' to 'ExpectedError'.
19891 * genericparser.cs: Removed error handling support, since it is
19892 now all done by Report class.
19894 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19895 class, so parse() no longer returns an int.
19897 * namespace.cs: Use Report.Error instead of GenericParser.error
19899 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19901 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19902 TypeContainer.AddOperator): At the front of the list put the
19903 explicit implementations, so they get resolved/defined first.
19905 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19907 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19908 interface type is implemented by this TypeContainer. Used during
19909 explicit interface implementation.
19911 (Property.Define, Indexer.Define, Method.Define): Validate that
19912 the given interface in the explicit implementation is one of the
19913 base classes for the containing type.
19915 Also if we are explicitly implementing an interface, but there is
19916 no match in the pending implementation table, report an error.
19918 (Property.Define): Only define the property if we are
19919 not explicitly implementing a property from an interface. Use the
19920 correct name also for those properties (the same CSC uses,
19921 although that is really not needed).
19923 (Property.Emit): Do not emit attributes for explicitly implemented
19924 properties, as there is no TypeBuilder.
19926 (Indexer.Emit): ditto.
19928 Hiding then means that we do not really *implement* a pending
19929 implementation, which makes code fail.
19931 2002-06-22 Martin Baulig <martin@gnome.org>
19933 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
19934 the return value of Object.GetType(). [FIXME: we need to do this whenever
19935 we get a type back from the reflection library].
19937 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
19939 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
19941 2002-06-20 Miguel de Icaza <miguel@ximian.com>
19943 * attribute.cs: Return null if we can not look up the type.
19945 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
19946 the interface types found.
19948 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
19949 interface types found.
19951 * typemanager.cs (GetInterfaces): Make this routine returns alll
19952 the interfaces and work around the lame differences between
19953 System.Type and System.Reflection.Emit.TypeBuilder in the results
19954 result for GetInterfaces.
19956 (ExpandInterfaces): Given an array of interface types, expand and
19957 eliminate repeated ocurrences of an interface. This expands in
19958 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
19961 2002-06-21 Martin Baulig <martin@gnome.org>
19963 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
19966 2002-06-21 Martin Baulig <martin@gnome.org>
19968 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
19969 and called with one of the core types, return the corresponding typebuilder for
19972 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
19975 2002-06-21 Martin Baulig <martin@gnome.org>
19977 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
19978 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
19979 (Expression.ConvertReferenceExplicit): Likewise.
19981 * expression.cs (ElementAccess.DoResolve): Likewise.
19982 (ElementAccess.DoResolveLValue): Likewise.
19984 2002-06-10 Martin Baulig <martin@gnome.org>
19986 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
19987 add the "value" parameter to the parameter list.
19989 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
19992 2002-06-19 Miguel de Icaza <miguel@ximian.com>
19994 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
19995 the argument to an int, uint, long or ulong, per the spec. Also
19996 catch negative constants in array creation.
19998 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
20000 * class.cs: do not allow the same interface to appear twice in
20001 the definition list.
20003 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
20005 * ecore.cs: don't use ldlen with System.Array.
20007 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
20009 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
20011 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
20013 * modifiers.cs: produce correct field attributes for protected
20014 internal. Easy fix so miguel can work on ther harder stuff:-)
20016 2002-06-18 Miguel de Icaza <miguel@ximian.com>
20018 * pending.cs: New file. Move the code from class.cs here.
20019 Support clearning the pending flag for all methods (when not doing
20020 explicit interface implementation).
20022 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
20024 * rootcontext.cs: added a couple more types needed to bootstrap.
20026 2002-06-17 Miguel de Icaza <miguel@ximian.com>
20028 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
20029 constructor in the type, instead of any constructor in the type
20030 hierarchy. Thanks to Paolo for finding this bug (it showed up as
20031 a bug in the Mono runtime when applying the params attribute).
20033 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20034 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
20036 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
20038 * expression.cs (Unary.ResolveOperator): Use TypeManager
20039 to resolve the type.
20041 2002-06-13 Ravi Pratap <ravi@ximian.com>
20043 * cs-parser.jay (enum_member_declaration): Pass in the attributes
20046 * enum.cs (AddEnumMember): Add support to store the attributes associated
20047 with each member too.
20049 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
20050 field builders too - this takes care of the enum member case.
20052 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
20054 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
20055 address-of operator on both value types and pointers.
20057 2002-06-10 Martin Baulig <martin@gnome.org>
20059 * interface.cs (Interface.PopulateIndexer): Add the indexer's
20060 PropertyBuilder to the `property_builders' list.
20062 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
20063 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
20064 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
20065 find any indexers which are inherited from an interface.
20067 2002-06-09 Martin Baulig <martin@gnome.org>
20069 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
20070 the same type as the constant if necessary. There's also a test-130.cs
20073 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
20075 * typemanager.cs (TypeManager.ChangeType): Previously known as
20076 Enum.ChangeEnumType().
20078 2002-06-09 Martin Baulig <martin@gnome.org>
20080 * expression.cs (Cast.TryReduce): Added support for consts.
20082 2002-06-08 Ravi Pratap <ravi@ximian.com>
20084 * class.cs (Accessor): Hold attributes information so we can pass
20087 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
20088 Modify to pass in attributes attached to the methods.
20090 (add_accessor_declaration, remove_accessor_declaration): Ditto.
20092 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
20093 to handle the Accessor kind :-)
20095 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
20097 2002-06-08 Martin Baulig <martin@gnome.org>
20099 * expression.cs (Unary.TryReduceNegative): Added support for
20102 2002-06-08 Martin Baulig <martin@gnome.org>
20104 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
20105 name can't be found in the `defined_names' - the caller will do a
20106 MemberLookup in this case and thus find methods in System.Enum
20107 such as Enum.IsDefined().
20109 2002-06-08 Martin Baulig <martin@gnome.org>
20111 * enum.cs (Enum.ChangeEnumType): This is a custom version of
20112 Convert.ChangeType() which works with TypeBuilder created types.
20113 (Enum.LookupEnumValue, Enum.Define): Use it here.
20115 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
20116 `TypeBuilder.BaseType != null' check.
20117 (TypeContainer.FindMembers): Only lookup parent members if we
20118 actually have a parent.
20119 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
20120 (ConstructorInitializer.Resolve): Likewise.
20122 * interface.cs (Interface.FindMembers): Added
20123 `TypeBuilder.BaseType != null' check.
20125 * rootcontext.cs (RootContext.ResolveCore): Added
20126 "System.Runtime.CompilerServices.IndexerNameAttribute" to
20127 classes_second_stage.
20129 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
20130 debug_type and trace_type when compiling with --nostdlib.
20132 2002-06-07 Martin Baulig <martin@gnome.org>
20134 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
20135 (AddField): Set it to true when adding a non-static field.
20136 (DefineType): Use `have_nonstatic_fields' to find out whether we
20137 have non-static fields, not `Fields != null'.
20139 2002-06-02 Miguel de Icaza <miguel@ximian.com>
20141 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
20142 dereferencing a null on the static-field code path)
20144 2002-05-30 Martin Baulig <martin@gnome.org>
20146 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
20147 to take command line arguments. Use reflection to call the new
20148 custom `Initialize' function on the symbol writer and pass it the
20149 command line arguments.
20151 * driver.cs (--debug-args): New command line argument to pass command
20152 line arguments to the symbol writer.
20154 2002-05-28 Miguel de Icaza <miguel@ximian.com>
20156 * assign.cs (DoResolve): Forgot to do the implicit conversion to
20157 the target type for indexers and properties. Thanks to Joe for
20160 2002-05-27 Miguel de Icaza <miguel@ximian.com>
20162 * typemanager.cs (MethodFlags): returns the method flags
20163 (Obsolete/ShouldIgnore) that control warning emission and whether
20164 the invocation should be made, or ignored.
20166 * expression.cs (Invocation.Emit): Remove previous hack, we should
20167 not do this on matching a base type, we should do this based on an attribute
20169 Only emit calls to System.Diagnostics.Debug and
20170 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
20171 on the command line.
20173 * rootcontext.cs: Global settings for tracing and debugging.
20175 * cs-tokenizer.cs (define): New utility function to track
20176 defines. Set the global settings for TRACE and DEBUG if found.
20178 2002-05-25 Ravi Pratap <ravi@ximian.com>
20180 * interface.cs (Populate*): Pass in the TypeContainer as well as
20181 the DeclSpace as parameters so that we can create EmitContexts and
20182 then use that to apply attributes etc.
20184 (PopulateMethod, PopulateEvent, PopulateProperty)
20185 (PopulateIndexer): Apply attributes everywhere.
20187 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
20190 (ApplyAttributes): Update accordingly.
20192 We now apply interface attributes for all members too.
20194 2002-05-26 Miguel de Icaza <miguel@ximian.com>
20196 * class.cs (Indexer.Define); Correctly check if we are explicit
20197 implementation (instead of checking the Name for a ".", we
20198 directly look up if the InterfaceType was specified).
20200 Delay the creation of the PropertyBuilder.
20202 Only create the PropertyBuilder if we are not an explicit
20203 interface implementation. This means that explicit interface
20204 implementation members do not participate in regular function
20205 lookups, and hence fixes another major ambiguity problem in
20206 overload resolution (that was the visible effect).
20208 (DefineMethod): Return whether we are doing an interface
20211 * typemanager.cs: Temporary hack until we get attributes in
20212 interfaces (Ravi is working on that) and we get IndexerName
20213 support in interfaces.
20215 * interface.cs: Register the indexers as properties.
20217 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
20218 warning, I have verified that this is a bug in the .NET runtime
20219 (JavaScript suffers of the same problem).
20221 * typemanager.cs (MemberLookup): When looking up members for
20222 interfaces, the parent of an interface is the implicit
20223 System.Object (so we succeed in searches of Object methods in an
20224 interface method invocation. Example: IEnumerable x; x.ToString
20227 2002-05-25 Miguel de Icaza <miguel@ximian.com>
20229 * class.cs (Event): Events should also register if they do
20230 implement the methods that an interface requires.
20232 * typemanager.cs (MemberLookup); use the new GetInterfaces
20235 (GetInterfaces): The code used to lookup interfaces for a type is
20236 used in more than one place, factor it here.
20238 * driver.cs: Track the errors at the bottom of the file, we kept
20241 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
20242 instance if the method we are calling is static!
20244 2002-05-24 Miguel de Icaza <miguel@ximian.com>
20246 * attribute.cs (ApplyAttributes): Make this function filter out
20247 the IndexerName attribute (as that attribute in reality is never
20248 applied) and return the string constant for the IndexerName
20251 * class.cs (TypeContainer.Emit): Validate that all the indexers
20252 have the same IndexerName attribute, and if so, set the
20253 DefaultName attribute on the class.
20255 * typemanager.cs: The return value might contain other stuff (not
20256 only methods). For instance, consider a method with an "Item"
20257 property and an Item method.
20259 * class.cs: If there is a problem with the parameter types,
20262 2002-05-24 Ravi Pratap <ravi@ximian.com>
20264 * ecore.cs (ImplicitConversionExists): Wrapper function which also
20265 looks at user defined conversion after making a call to
20266 StandardConversionExists - we need this for overload resolution.
20268 * expression.cs : Update accordingly the various method calls.
20270 This fixes 2 bugs filed against implicit user defined conversions
20272 2002-05-22 Miguel de Icaza <miguel@ximian.com>
20274 * statement.cs: Track the result of the assignment.
20276 2002-05-21 Miguel de Icaza <miguel@ximian.com>
20278 * expression.cs (MemberAccess): Improved error reporting for
20279 inaccessible members.
20281 2002-05-22 Martin Baulig <martin@gnome.org>
20283 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
20284 itself with debugging support.
20286 2002-05-22 Martin Baulig <martin@gnome.org>
20288 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
20289 Removed, this isn't needed anymore.
20291 2002-05-20 Martin Baulig <martin@gnome.org>
20293 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
20294 be underlying type for an enum.
20296 2002-05-20 Miguel de Icaza <miguel@ximian.com>
20298 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
20299 that splits out the loading of just the core types.
20301 * rootcontext.cs (ResolveCore): Split the struct resolution in
20302 two, so we can load the enumeration underlying types before any
20305 * expression.cs (Is): Bandaid until we fix properly Switch (see
20306 bug #24985 for details).
20308 * typemanager.cs (ImplementsInterface): The hashtable will contain
20309 a null if there are no interfaces implemented.
20311 2002-05-18 Miguel de Icaza <miguel@ximian.com>
20313 * cs-parser.jay (indexer_declarator): It is fine to have array
20316 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20318 * typemanager.cs: (RegisterBuilder): New function used to register
20319 TypeBuilders that implement interfaces. Since
20320 TypeBuilder.GetInterfaces (as usual) does not work with lame
20322 (AddUserType): register interfaces.
20324 (ImplementsInterface): Use the builder_to_ifaces hash if we are
20325 dealing with TypeBuilder. Also, arrays are showing up as
20326 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
20327 methods can not be invoked on them!
20329 * ecore.cs (ExplicitReferenceConversionExists): Made public.
20330 (ImplicitReferenceConversionExists): Split out from
20331 StandardConversionExists.
20333 * expression.cs (As): We were only implementing one of the three
20334 cases for the as operator. We now implement them all.
20335 (Is): Implement the various other cases for Is as well.
20337 * typemanager.cs (CACHE): New define used to control if we want or
20338 not the FindMembers cache. Seems to have a negative impact on
20339 performance currently
20341 (MemberLookup): Nested types have full acess to
20342 enclosing type members
20344 Remove code that coped with instance/static returns for events, we
20345 now catch this in RealFindMembers.
20347 (RealFindMembers): only perform static lookup if the instance
20348 lookup did not return a type or an event.
20350 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20352 * assign.cs (CompoundAssign): We pass more semantic information
20353 now to Compound Assignments than we did before: now we have all
20354 the information at hand, and now we resolve the target *before* we
20355 do the expression expansion, which allows the "CacheValue" method
20356 to have the effect we intended (before, a [x] += 1 would generate
20357 two differen ArrayAccess expressions from the ElementAccess,
20358 during the resolution process).
20360 (CompoundAssign.DoResolve): Resolve target and original_source here.
20362 2002-05-16 Miguel de Icaza <miguel@ximian.com>
20364 * expression.cs (ArrayAccess): dropped debugging information.
20366 * typemanager.cs: Small bug fix: I was always returning i_members,
20367 instead of one of i_members or s_members (depending on which had
20370 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
20371 method is invoked before any code generation takes place, and it
20372 is a mechanism to inform that the expression will be invoked more
20373 than once, and that the method should use temporary values to
20374 avoid having side effects
20376 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
20378 * ecore.cs (Expression.CacheTemporaries): Provide empty default
20381 * expression.cs (Indirection, ArrayAccess): Add support for
20382 CacheTemporaries in these two bad boys.
20384 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
20385 ldobj or ldind_ref.
20386 (StoreFromPtr): Handle stobj as well.
20388 * expression.cs (UnaryMutator): Share more code.
20390 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
20391 down: I was not tracking the Filter function as well, which
20392 was affecting the results of the cache.
20394 2002-05-15 Miguel de Icaza <miguel@ximian.com>
20396 * attribute.cs: Remove the hack to handle the CharSet property on
20399 2002-05-14 Miguel de Icaza <miguel@ximian.com>
20401 * attribute.cs (DoResolve): More uglyness, we now only try to
20402 resolve the attribute partially, to extract the CharSet
20403 information (only if we are a StructLayout attribute). Otherwise
20405 (GetExtraTypeInfo): Add some code to conditionally kill in the
20406 future this. I am more and more convinced that the .NET
20407 framework has special code to handle the attribute setting on
20410 * expression.cs (IsParamsMethodApplicable): Revert my previous
20411 foreach change here, it was wrong.
20413 2002-05-13 Miguel de Icaza <miguel@ximian.com>
20415 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
20416 (pp_expr): do not abort on unknown input, just return.
20417 (eval): abort if there are pending chars.
20419 * attribute.cs (Attribute.Resolve): Positional parameters are
20420 optional. Deal with that case.
20422 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
20423 the Ansi/Unicode/Auto information for the type.
20425 (TypeContainer.DefineType): instantiate the EmitContext here, as
20426 we will be using it during the type definition (to resolve
20427 attributes) and during the emit phase.
20429 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
20430 to pull type information out of the attributes
20432 (Attribute.Resolve): track the constructor builder, and allow for
20433 multiple invocations (structs and classes will use this).
20435 * ecore.cs (MemberLookupFinal): new version with all the
20436 parameters customizable.
20438 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
20439 constructors. Return if the result value is null (as the error
20440 would have been flagged already by MemberLookupFinal)
20442 Do not allow instances of abstract classes or interfaces to be
20445 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
20446 We have to compare the assembly property here when dealing with
20447 FamANDAssem and Assembly access modifiers, because we might be
20448 creating an assembly from *modules* (that means that we are not
20449 getting TypeBuilders for types defined in other modules that are
20450 part of this assembly).
20452 (Method.Emit): If the method is marked abstract and has a body,
20455 (TypeContainer.DefineMembers): If both the defined member and the
20456 parent name match are methods, then do not emit any warnings: let
20457 the Method.Define routine take care of flagging warnings. But if
20458 there is a mismatch (method overrides something else, or method is
20459 overriwritten by something, then emit warning).
20461 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
20462 set to null, this means `do not check for the return type on the
20465 (Method.Define): set the return type for the method signature to
20466 null, so that we get methods with the same name and parameters and
20467 different return types. This is used to flag warning 114 (you are
20468 hiding a method, and you probably want to use the new/override
20471 * typemanager.cs (MemberLookup): Implemented proper access
20472 control, closing a long standing set of bug reports. The problem
20473 was that the Framework only has two bits: Public and NonPublic,
20474 and NonPublic includes private and protected methods, but we need
20475 to enforce the FamANDAssem, FamOrAssem and Family.
20477 2002-05-11 Miguel de Icaza <miguel@ximian.com>
20479 * statement.cs (GotoCase): Return true: Ammounts to giving up
20480 knowledge on whether we return or not, and letting the other case
20481 be responsible for it.
20483 2002-05-10 Miguel de Icaza <miguel@ximian.com>
20485 * driver.cs: Do not load directories for each file processed, only
20486 do it if there is a pattern.
20488 * ecore.cs: Report readonly assigns here as well, as we might have
20489 been resolved only by MemberAccess.
20491 (SimpleName.SimpleNameResolve): Also be useful for LValue
20492 resolution. We need this to propagate assign to local readonly variables
20494 * typemanager.cs: Use a ptrhashtable for the criteria, because we
20495 do not want to reuse potential criteria memory.
20497 * class.cs (MyEventBuilder): Set reflected_type;
20499 * ecore.cs (Constantify): Added support for constifying bools.
20501 (RootContext.LookupType): Added a cache for values looked up in
20502 the declaration space.
20504 * typemanager.cs (FindMembers): Now is a front-end to
20505 RealFindMembers, and provides a two-level hashtable-based cache to
20508 15% performance improvement: from 22.5 to 19.2 seconds.
20510 * expression.cs (IsParamsMethodApplicable): use foreach.
20511 (Invocation.DoResolve): ditto.
20512 (New.DoResolve): ditto.
20513 (ArrayCreation.DoResolve): ditto.
20515 * ecore.cs (FindMostEncompassingType): use foreach.
20517 * delegate.cs (NewDelegate.DoResolve): Use foreach
20519 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
20520 (RemoveMethods): use foreach.
20522 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
20523 nested foreach statements instead of for, and also break out of
20524 the inner loop once a match is found.
20526 (Invocation.OverloadResolve): Use foreach, simplify the code.
20528 2002-05-08 Miguel de Icaza <miguel@ximian.com>
20530 * cfold.cs (BinaryFold): During an enumeration evaluation context,
20531 we actually unwrap the expression to allow for extra information
20534 * expression.cs: Use Shr_Un on unsigned operations.
20536 2002-05-08 Ravi Pratap <ravi@ximian.com>
20538 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
20539 applicable operators was not being considered correctly. This closes
20540 the bug Miguel reported.
20542 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
20544 * attribute.cs: check that the type derives from System.Attribute
20545 and report the correct error in that case (moved the duplicate code to
20546 its own method, too).
20548 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
20550 * attribute.cs: lookup attribute type name as the spec says: first the
20551 bare attribute name and then name + "Attribute" (nant compiles with
20552 mcs after this fix).
20554 2002-05-07 Miguel de Icaza <miguel@ximian.com>
20556 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
20557 Because of the way we parse things, we should try to see if a
20558 UIntConstant can fit in an integer.
20560 2002-05-07 Ravi Pratap <ravi@ximian.com>
20562 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
20563 when we are in an explicit context.
20565 (ConvertReferenceExplicit): When converting from Iface type S to Class
20566 T make sure the rules are implemented as an OR.
20568 * parameter.cs (ParameterType): Make it a property for now although the
20569 purpose really isn't anything immediate.
20571 * expression.cs (Is*Applicable): Do better checking on the parameter type
20572 of a ref/out parameter. The ones from the system assemblies are already
20573 marked with the correct type so we don't need to do any correction.
20575 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20576 the object type is standard too so include that.
20578 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20580 * ecore.cs (StandardConversionExists): Augment with missing code:
20581 deal with IntConstant, LongConstants and Enumerations.
20583 * assign.cs: Report the error, instead of failing silently
20585 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20586 typecontainer that they are declared, because the
20587 typecontainer/namespace will have the list of using clauses that
20588 need to be applied.
20590 Assembly Attributes were escaping the normal registration
20593 (EmitCode): Apply attributes within an EmitContext that represents
20594 the container they were declared on.
20596 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20598 2002-05-06 Ravi Pratap <ravi@ximian.com>
20600 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20601 Revamp completely - make much cleaner as we now operate only
20604 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20605 to implement the logic detailed in the spec more correctly.
20607 (UserDefinedConversion): Update accordingly.
20609 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20611 * statement.cs: Return flow analysis information up.
20613 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20616 (token): Do not consume an extra character before calling
20619 2002-05-06 Piers Haken <piersh@friskit.com>
20621 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20623 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20625 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20626 EmitContext during the instance constructor initializer
20627 resolution, to stop access to instance variables.
20629 This is mandated by the spec, last paragraph of the `constructor
20630 initializers' section.
20632 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20634 * cs-parser.jay, class.cs (Accessor): new class used to represent
20635 an accessor (get or set). In the past we used `null' to represent
20636 a missing accessor. But this is ambiguous because there was no
20637 way to tell in abstract indexers/properties if one of them was
20640 Now there is a way of addressing that.
20642 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20643 instead of FindMembers.
20645 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20646 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20648 * attribute.cs: Treat indexers and properties as the same in terms
20649 of applying attributes
20651 * ecore.cs (FindMostEncompassedType): Use statically initialized
20652 EmptyExpressions()s like we do elsewhere to avoid creating useless
20653 objects (and we take this out of the tight loop).
20655 (GetConversionOperators): Move the code to extract the actual
20656 operators to a separate routine to clean things up.
20658 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20660 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20661 events are always registered FieldBuilders.
20663 * class.cs (FieldBase): New class shared by Fields
20665 * delegate.cs: If we are a toplevel delegate, use our full name.
20666 If we are a nested delegate, then only use our tail name.
20668 2002-05-02 Ravi Pratap <ravi@ximian.com>
20670 * expression.cs (IsApplicable): Ensure that we add the "&" to
20671 ref/out types before comparing it with the type of the argument.
20673 (IsParamsMethodApplicable): Ditto.
20675 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20678 * delegate.cs : Handle the case when we have more than one applicable
20679 method. Flag an error only when we finish checking all.
20681 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20683 * expression.cs: Add support for boolean static initializers.
20685 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20687 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20689 * parameter.cs (ComputeParameterTypes,
20690 ComputeAndDefineParameterTypes): Better error handling: now we
20691 clear the `types' cache if we fail during any of the type lookups.
20692 We also return the status code correctly to our caller
20694 * delegate.cs: If we fail to define a delegate, abort the extra
20697 * expression.cs (Binary.ResolveOperator): for
20698 operator==(object,object) and operator !=(object, object) we also
20699 have to verify that there is an implicit conversion from one to
20702 (ArrayAccess.DoResolve): Array Access can operate on
20705 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20707 * assign.cs (CompoundAssign): A new class used as a "flag" that
20708 the assignment actually is happening as part of a compound
20709 assignment operator.
20711 During compound assignment, a few new rules exist to enable things
20718 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20719 to the type of x) if y is implicitly convertible to the type of x,
20720 and the operator is a builtin operator and the return type of the
20721 operator is explicitly convertible to the type of x.
20723 * rootcontext.cs: Reset warning level to 2. 4 catches various
20724 "interesting" features in mcs, we must clean this up at some
20725 point, but currently am trying to kill other bugs ;-)
20727 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20728 in container classes as well.
20730 * expression.cs (Binary.ResolveOperator): Handle string case
20731 before anything else (as operator overloading does emit an error
20732 before doing anything else).
20734 This code could go away when we move to a table driven model, but
20735 i could not come up with a good plan last night.
20737 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20739 * typemanager.cs (CSharpName): reimplementation using regex.
20740 * class.cs: added null check for fields in Emit
20741 * rootcontext.cs: set warninglevel to 4
20743 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20745 * typemanager.cs (CSharpName): reimplemented with Lupus
20748 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20750 * statement.cs (If): correclty implement Resolve, because we were
20751 not catching sem errors in there. The same process is needed
20753 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20756 (Statement.Warning_DeadCodeFound): Factorize code.
20757 (While): Report dead code here too.
20759 (Statement): Added Resolve virtual method to allow
20760 for resolution split from the emit code.
20762 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20764 * statement.cs (EmitBoolExpression): No longer try to resolve the
20766 (MakeBoolean): New utility function that resolve, implicitly
20767 converts to boolean and tags the expression.
20770 (If, Do): Implement dead code elimination.
20771 (While): Implement loop inversion
20773 (Do, While, For, If): Resolve the expression prior to calling our
20776 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20779 - added method Report28 (warning: program has more than one entry point)
20780 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20781 - modified method Method.Define, the part at the end of the method
20783 * rootcontext.cs: added static public Location EntryPointLocation;
20785 * ../errors/cs0028.cs : Add test case for the above warning.
20788 - modified method CSharpName to allow arrays of primitive type to
20789 be printed nicely (e.g. instead of System.Int32[][] it now prints
20791 - added method CSharpSignature: returns the signature of a method
20792 in string format to be used in reporting errors, warnings, etc.
20794 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20797 2002-04-26 Ravi Pratap <ravi@ximian.com>
20799 * delegate.cs (Define): Fix extremely silly bug where I was
20800 setting the type of the 'object' parameter of the BeginInvoke
20801 method to System.IAsyncResult instead of System.Object ;-)
20803 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20805 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20808 (Constructor.Emit): return if we fail to initialize the
20809 constructor. Another door closed!
20811 * expression.cs (New.DoResolve): Improve error message (from -6 to
20812 1501). Use DeclaredOnly lookup to find the exact constructor.
20814 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20815 loop. This is useful.
20817 * cs-parser.jay: Adjust the default parameters so that destructors
20818 have the proper signature.
20820 2002-04-26 Martin Baulig <martin@gnome.org>
20822 * driver.cs (LoadAssembly): If `assembly' contains any characters
20823 which are only valid in path names and not in assembly names
20824 (currently slash, backslash and point), use Assembly.LoadFrom ()
20825 instead of Assembly.Load () on the `assembly' (before iteration
20826 over the link_paths).
20828 2002-04-26 Martin Baulig <martin@gnome.org>
20830 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20832 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20834 * class.cs (Property): use the new typemanager.MemberLookup
20836 (TypeContainer.MemberLookup): Implement using the
20837 TypeManager.MemberLookup now.
20839 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20840 and return MemberInfos, so that these can be used without an
20841 EmitContext (what we had before).
20843 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20845 * expression.cs: Fix the case where the argument to params if the
20846 type of the params. I omitted handling this before. Fixed
20848 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20850 * driver.cs: Call BootCorlib_PopulateCoreType
20852 * class.cs (Property.CheckBase): Check for properties only, not
20855 * interface.cs: Temporary hack: try/catch around the
20856 CustomAttributeBuilder, because I am getting an exception that I
20859 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20860 types whose definitions are required to be there (attributes are
20861 defined before standard types).
20863 Compute definitions as we boot the various types, as they are used
20864 immediately (value_type class will need object_type, but if we do
20865 not initialize object_type, we will pass a null, which will let
20866 the runtime pick the System.Object from the existing corlib, which
20867 is not what we want).
20869 2002-04-22 Patrik Torstensson <totte@labs2.com>
20871 * cs-tokenizer.cs: fixed a number of trim() issues.
20873 2002-04-22 Ravi Pratap <ravi@ximian.com>
20875 * expression.cs (Argument.Type): Ensure that we return the correct
20876 type when we have out or ref parameters [in which case we
20879 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20881 * class.cs (Property, Indexer): Allow extern modifier in there.
20883 * typemanager.cs (InitBaseTypes): Initializes object_type and
20884 value_type, since those will be used early on during the bootstrap
20885 process to compile corlib.
20887 (InitCoreTypes): Move code from here to InitBaseTypes.
20889 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20891 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20892 single-dimension arrays as using the ldlen opcode.
20894 Daniel Lewis discovered this optimization.
20896 * typemanager.cs: Add signature for System.Array::get_Length
20898 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20900 * statement.cs: report the error when the foreach does not apply to an
20901 array nor a collection.
20903 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20905 * expression.cs: Add implicit conversions to the operator ~.
20907 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20909 * typemanager.cs: Locate the decimal constructor.
20911 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20913 * attribute.cs: use the new property of TypeOf.
20914 * expression.cs: added 'get' property around typearg.
20916 These changes fix a build breaker reported by NickD. Is this the
20917 correct way to fix? If not, please, revert my changes and make it
20920 2002-04-17 Miguel de Icaza <miguel@ximian.com>
20922 * attribute.cs: Add support for typeof in attribute invocations.
20923 I am not sure that this is right though.
20925 2002-04-14 Duncan Mak <duncan@ximian.com>
20927 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
20928 Binary.Operator.Division case.
20930 2002-04-13 Ravi Pratap <ravi@ximian.com>
20932 * class.cs (DefineType): Ensure that we do a proper check on
20933 attribute types and also register it with the TypeManager.
20935 (TypeContainer.Targets): The default for attribute types is
20936 AttributeTargets.All.
20938 * attribute.cs (ApplyAttributes): Registering the attribute type
20939 is done elsewhere, not when we discover we have a Usage attribute.
20941 2002-04-12 Ravi Pratap <ravi@ximian.com>
20943 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
20944 and get rid of is_delegate parameter.
20946 * everywhere : update.
20948 2002-04-12 Ravi Pratap <ravi@ximian.com>
20950 * cs-parser.jay (compilation_unit): Revamp completely to use
20951 some new ideas that I got from Rhys' grammar to solve the problems
20952 with assembly level attributes.
20954 (outer_declaration): New grammar production.
20956 (attribute_sections): Add.
20958 (opt_attributes): Base on attribute_sections
20960 (namespace_declaration): Allow opt_attributes to tackle the case
20961 when we have assembly level attributes - we are clever in this
20964 * attribute.cs (ApplyAttributes): Do not worry about assembly
20965 attributes in the non-global context.
20967 * rootcontext.cs (AddGlobalAttributes): Go back to using this
20968 instead of SetGlobalAttributes.
20970 * class.cs, rootcontext.cs : Ensure we define and generate
20971 attribute types before anything else.
20973 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
20974 and flag the new error -20 for the case when the attribute type
20975 does not have valid targets specified. csc does not catch this.
20977 * ../errors/errors.txt : update for error # -20
20979 2002-04-11 Ravi Pratap <ravi@ximian.com>
20981 * support.cs (InternalParameters.ParameterModifier): Do some null
20982 checking and return sane values.
20984 * class.cs (Method.Define): If we are a PInvoke method, ensure
20985 that we are static and extern. Report error # 601
20987 * ../errors/cs0601.cs : Add test case for the above error.
20989 2002-04-07 Ravi Pratap <ravi@ximian.com>
20991 * rootcontext.cs (attribute_types): We need to keep type of
20992 all attribute types separately and emit code for them first.
20994 (RegisterAttribute) : Implement.
20996 * class.cs (DefineType): Check if the current Type is a custom
20997 attribute type and register it accordingly.
20999 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
21000 adding the first attribute twice and rename to
21002 (SetGlobalAttributes): this.
21004 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
21007 * attribute.cs (ApplyAttributes): Take an additional argument telling us
21008 if we are processing global arguments. Hmm, I am unsure of this.
21010 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21012 * expression.cs: added static array of strings to avoid calling
21013 Enum.ToString () for Operator in Binary. Significant recover of
21016 2002-04-10 Miguel de Icaza <miguel@ximian.com>
21018 * class.cs (FindMembers): Allow the Builders of the various
21019 members to be null. If they are skip them. This only happens
21020 during the PInvoke declaration.
21022 2002-04-09 Miguel de Icaza <miguel@ximian.com>
21024 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
21025 failure, so we do not keep going afterwards.
21027 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
21028 wanted to pass `false' as the `is_delegate' argument. If this is
21029 the case, why not use delegate_type == null to mean `is_delegate =
21030 false' and anything else as is_delegate = true.
21032 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
21034 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
21035 code for the section, not the beginning of the tests.
21037 2002-04-08 Miguel de Icaza <miguel@ximian.com>
21039 * cfold.cs: Handle operator + (Enum x, Underlying x)
21041 * expression.cs (Binary): same. Warn about errors where we have
21042 Enum/Enum in operator + as well.
21044 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
21047 - added support for switch(bool)
21048 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
21049 - add TableSwitchEmit() to handle table-based switch statements
21051 2002-04-05 Ravi Pratap <ravi@ximian.com>
21053 * expression.cs (Invocation.OverloadResolve): Factor out code which
21054 does parameter compatibility checking with arguments so that we can
21055 re-use the code even from Delegate.VerifyApplicability
21057 (VerifyArgumentsCompat): Move above code here.
21059 * delegate.cs (VerifyApplicability): Get rid of duplicate code
21060 and instead make a call to the above method.
21062 2002-03-31 Ravi Pratap <ravi@ximian.com>
21064 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
21065 We use it to keep track of classes which are attribute types.
21067 2002-04-02 Miguel de Icaza <miguel@ximian.com>
21069 * delegate.cs (Delegate.Define): Correctly define the types in the
21070 presence of fixed and array parameters.
21072 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
21075 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
21076 include NonPublic after the first iteration.
21078 * class.cs (Indexer.CheckBase): Only check if both parents are
21081 * cs-parser.jay (accessor_body): If empty, set to null.
21083 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
21084 same code path here to resolve constants names that we did have in
21085 MemberAccess.DoResolve. There is too much code duplicated here.
21087 2002-04-01 Miguel de Icaza <miguel@ximian.com>
21089 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
21091 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
21094 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
21095 tokens, numbers and strings.
21097 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
21100 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
21101 asyncronous parameters and the regular parameters.
21103 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
21104 specify the target directory.
21106 * expression.cs: (This.DoResolve): Simplify
21107 (As.Emit): Optimize, do not generate IsInst if the expression is
21108 always of the given type.
21110 (Is.DoResolve): Bug fix, we were reporting both always/never for
21113 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
21114 creating too many unnecessary arrays.
21116 2002-03-31 Miguel de Icaza <miguel@ximian.com>
21118 * class.cs (EmitFieldInitializer): Use Assign expression to assign
21119 fields instead of rolling our own initializer. Takes care of all
21120 implicit conversions, and drops unnecessary static checks/argument.
21122 2002-03-31 Dick Porter <dick@ximian.com>
21124 * driver.cs: use the GetDirectories() return values properly, and
21125 use "/" as path separator.
21127 2002-03-30 Miguel de Icaza <miguel@ximian.com>
21129 * expression.cs (Unary): Optimize - - expr into expr.
21130 (Binary): Optimize a + (-b) into a -b.
21132 * codegen.cs (CodeGen): Made all methods static.
21134 2002-03-29 Miguel de Icaza <miguel@ximian.com>
21138 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
21139 TypeBuilder property.
21141 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
21144 * tree.cs: Removed the various RecordXXXX, and replaced with a
21145 single RecordDecl. Removed all the accessor methods, and just
21146 left a single access point Type
21148 * enum.cs: Rename DefineEnum to DefineType.
21150 * decl.cs: New abstract method `DefineType' used to unify the
21151 Defines for Enumerations, Interfaces, TypeContainers and
21154 (FindType): Moved LookupInterfaceOrClass here. Moved the
21155 LookupBaseClasses method that used to live in class.cs and
21156 interface.cs here, and renamed to FindType.
21158 * delegate.cs: Implement DefineType. Take advantage of the
21159 refactored pattern for locating the parent builder without taking
21160 the parent_builder argument (which we know does not work if we are
21161 nested, and triggering a toplevel definition).
21163 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21165 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
21166 accessibility of a member has changed during override and report
21169 * class.cs (Method.Define, Property.Define): Only complain on
21170 overrides if the method is private, any other accessibility is
21171 fine (and since we just checked the permission is the same, we are
21174 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
21175 and elif are processed always. The other pre-processing
21176 directives are only processed if we are "taking" the path
21178 2002-03-29 Martin Baulig <martin@gnome.org>
21180 * class.cs (Method.Emit): Only emit symbolic debugging info if the
21181 current location is not Null.
21183 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
21184 a separate method so we can profile it.
21186 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
21187 `span.Seconds' are just seconds, but no minutes or hours.
21188 (MainDriver): Profile the CodeGen.SaveSymbols calls.
21190 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21192 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
21193 Remove the gratuitous set of Final:
21195 // If an interface implementation, then we can set Final.
21196 if (((flags & MethodAttributes.Abstract) == 0) &&
21197 implementing.DeclaringType.IsInterface)
21198 flags |= MethodAttributes.Final;
21200 I do not know what I was smoking when I used that.
21203 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
21204 step into fixing the name resolution issues for delegates and
21205 unifying the toplevel name resolution.
21207 2002-03-28 Martin Baulig <martin@gnome.org>
21209 * class.cs (Method.Emit): If we have a symbol writer, call its
21210 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
21211 tell it about the current method.
21213 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
21214 writer that we're going to emit the first byte of IL code for a new
21215 statement (a new source line).
21216 (EmitContext.EmitTopBlock): If we have a symbol writer, call
21217 EmitContext.Mark() before emitting any code.
21219 * location.cs (SymbolDocument): Return null when we're Null.
21221 * statement.cs (Statement): Moved the `Location loc' variable here.
21222 (Statement.EmitBoolExpression): If we have a symbol writer, call
21223 ec.Mark() before emitting any code to tell it that we're at the
21224 beginning of a new statement.
21225 (StatementExpression): Added `Location' argument to the constructor.
21226 (Block): Added public readonly variable `StartLocation' and public
21227 variable `EndLocation'. The latter is to be set using SetEndLocation().
21228 (Block): Added constructor which takes a start and end location.
21229 (Block.SetEndLocation): New method. This sets the end location.
21230 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
21231 local variables we create.
21232 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
21233 each statement and do also mark the begin and end of the block.
21235 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
21236 tell it the current lexer.Location, use Location.Null for the end of the
21238 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
21239 current block, set its end location using SetEndLocation().
21240 (statement_expression): StatementExpression constructor now takes the
21241 lexer.Location as additional argument.
21242 (for_statement, declare_local_variables): Likewise.
21243 (declare_local_variables): When creating a new implicit block, use the
21244 new Block constructor and pass it the lexer.Location.
21246 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21248 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
21249 members also on the parent interfaces recursively.
21251 2002-03-27 Miguel de Icaza <miguel@ximian.com>
21253 * report.cs: Use new formats, since Gonzalo finished the missing
21256 * expression.cs (Binary.ResolveOperator): added missing operator|
21257 operator& and operator^ for bool/bool.
21259 * cs-parser.jay: CheckDef now takes a Location argument that is
21260 used to report errors more precisly (instead of reporting the end
21261 of a definition, we try to track something which is a lot closer
21262 to the source of the problem).
21264 * cs-tokenizer.cs: Track global token use, so we can properly flag
21265 the use of #define/#undef after the first token has been seen.
21267 Also, rename the reportXXXX to Error_DescriptiveName
21269 * decl.cs (DeclSpace.IsTopLevel): Move property here from
21270 TypeContainer, so that Enum and Interface can use this too.
21272 * class.cs (TypeContainer.LookupInterfaceOrClass,
21273 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
21274 `builder' argument. Typically this was used to pass the parent
21275 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
21278 The problem is that a nested class could trigger the definition of
21279 a toplevel class, and the builder would be obviously wrong in that
21282 So we drop this argument, and we compute dynamically the
21283 TypeBuilder/ModuleBuilder (the correct information was available
21284 to us anyways from DeclSpace.Parent)
21286 * interface.cs (Interface.DefineInterface): Drop builder
21287 parameter cleanup like class.cs
21289 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
21292 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
21295 (Try.Emit): Propagate the returns value from the statement.
21297 (Return.Emit): Even if we are leavning
21299 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
21301 * modifiers.cs: Fix the computation of MethodAttributes flags.
21303 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
21305 * driver.cs: allow compilation of files that start with '/'.
21306 Add a default case when checking the argument of --target.
21308 2002-03-25 Miguel de Icaza <miguel@ximian.com>
21310 * interface.cs: Implement the same search algorithm for types in
21311 the interface code.
21313 * delegate.cs: Do not allow multiple definition.
21315 * Recovered ChangeLog that got accidentally amputated
21317 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
21319 * rootcontext.cs: Load manually enum to allow core classes to
21320 contain enumerations.
21322 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
21323 Update to new static methods in TypeManager.
21325 * typemanager.cs (GetMethod, GetConstructor): Use our
21326 implementation of FindMembers to find the members, since during
21327 corlib compilation, the types are TypeBuilders and GetMethod and
21328 GetConstructor do not work.
21330 Make all methods in TypeManager static.
21332 (InitCodeHelpers): Split the functionality from
21333 the InitCodeTypes function.
21335 * driver.cs: Call InitCodeHelpers after we have populated the
21338 * cs-parser.jay (delegate_declaration): we did not used to compute
21339 the delegate name correctly for void delegates.
21341 2002-03-24 Miguel de Icaza <miguel@ximian.com>
21343 * rootcontext.cs (RootContext): Init the interface_resolve_order
21344 and type_container_resolve_order always.
21346 (ResolveCore, BootstrapCorlib_ResolveClass,
21347 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
21348 compiler when compiling with --nostdlib
21350 * class.cs (TypeContainer.DefineType): Check that our parent is
21351 not null. This test is most important when we are bootstraping
21354 * codegen.cs: Split out the symbol writing code.
21356 2002-03-25 Martin Baulig <martin@gnome.org>
21358 * driver.cs (-g): Made -g an alias for --debug.
21360 2002-03-24 Martin Baulig <martin@gnome.org>
21362 * codegen.cs (SymbolWriter): New public variable. Returns the
21363 current symbol writer.
21364 (CodeGen): Added `bool want_debugging_support' argument to the
21365 constructor. If true, tell the ModuleBuild that we want debugging
21366 support and ask it for the ISymbolWriter.
21367 (Save): If we have a symbol writer, call it's Close() method after
21368 saving the assembly.
21370 * driver.c (--debug): New command line argument to create a
21371 debugger information file.
21373 * location.cs (SymbolDocument): New public property. Returns an
21374 ISymbolDocumentWriter object for the current source file or null
21375 if we don't have a symbol writer.
21377 2002-03-21 Miguel de Icaza <miguel@ximian.com>
21379 * driver.cs (LoadAssembly): Correctly return when all the paths
21380 have been tried and not before.
21382 * statement.cs (Switch.Emit): return the actual coverage for this
21383 statement (returns/not-returns)
21385 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
21386 switch of the statement if we are the last switch section. That
21387 kills two problems: try/catch problems (we used to emit an empty
21388 nop at the end) and switch statements where all branches would
21391 2002-03-19 Miguel de Icaza <miguel@ximian.com>
21393 * driver.cs: Add default assemblies (the equivalent to the
21394 Microsoft CSC.RSP file)
21396 * cs-tokenizer.cs: When updating `cols and setting it to zero,
21397 also update tokens_seen and set it to false.
21399 * driver.cs: Implement --recurse for Mike.
21401 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
21402 correctly splitting out the paths.
21404 2002-03-18 Miguel de Icaza <miguel@ximian.com>
21406 * interface.cs (Interface.PopulateProperty): Instead of using
21407 `parent' as the declaration space for the set parameters, use
21410 * support.cs (InternalParameters): InternalParameters constructor
21411 takes a DeclSpace instead of a TypeContainer.
21413 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
21414 types are being initialized, load the address of it before calling
21417 (New): Provide a mechanism to disable the generation of local
21418 value type temporaries when the caller will be providing us with
21419 an address to store it.
21421 (ArrayCreation.EmitDynamicInitializers): Use it.
21423 2002-03-17 Miguel de Icaza <miguel@ximian.com>
21425 * expression.cs (Invocation.EmitArguments): Only probe for array
21426 property if there is more than one argument. Sorry about that.
21428 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
21429 empty param arrays.
21431 * class.cs (Method.LabelParameters): Fix incorrect code path that
21432 prevented the `ParamArrayAttribute' from being applied to the
21435 2002-03-16 Miguel de Icaza <miguel@ximian.com>
21437 * support.cs (ReflectionParameters): Correctly compute whether the
21438 last argument is a params array. Fixes the problem with
21441 * typemanager.cs: Make the assemblies array always be non-null
21442 (empty, but non-null)
21444 * tree.cs (RecordDecl): New function that abstracts the recording
21445 of names. This reports error 101, and provides a pointer to the
21446 previous declaration. Fixes a crash in the compiler.
21448 * cs-parser.jay (constructor_declaration): Update to new grammar,
21449 and provide a constructor_body that can be empty.
21451 2002-03-15 Miguel de Icaza <miguel@ximian.com>
21453 * driver.cs: Add support for --resources.
21455 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
21456 Make all types for the various array helper methods be integer.
21458 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
21459 CheckState to ConvCast.
21461 (ConvCast): Now it takes a `checked' state argument, to avoid
21462 depending on the emit context for the conversion, and just using
21463 the resolve time setting.
21465 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
21466 instead of Invocation.EmitArguments. We do not emit the original
21467 arguments, instead we emit those which have been converted to
21468 unsigned int expressions.
21470 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
21472 * codegen.cs: ditto.
21474 * expression.cs (LocalVariableReference): Drop the use of the
21475 Store function that depended on the variable index.
21477 * statement.cs (VariableInfo): Drop the `Idx' property from this
21478 class, as this is not taking into account the indexes for
21479 temporaries tat we generate during the execution, getting the
21482 * class.cs: First emit class initializers, then call the parent
21485 * expression.cs (Binary): Fix opcode emision.
21486 (UnaryMutator.EmitCode): Support checked code generation
21488 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
21489 matches for events for both the Static and Instance scans,
21490 pointing to the same element. Fix that.
21492 2002-03-14 Miguel de Icaza <miguel@ximian.com>
21494 * rootcontext.cs (ResolveTree): Always set the
21495 interface_resolve_order, because nested interfaces will be calling
21498 * class.cs (GetInterfaceOrClass): Track the same resolution
21499 process used by TypeManager.LookupType. This fixes the nested
21500 type lookups in class declarations (separate path from
21503 (TypeContainer.DefineType): Also define nested interfaces.
21504 (TypeContainer.RegisterOrder): New public function used to
21505 register the order in which child interfaces need to be closed.
21507 Nested interfaces need to be closed after their parents have been
21510 * interface.cs (InterfaceAttr): Put all the logic for computing
21511 the interface attribute here.
21513 (DefineInterface): Register our interface order with the
21514 RootContext or with the TypeContainer depending on the case.
21516 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21518 * cs-parser.jay: rework foreach statement to work with the new
21519 changes to the policy on SimpleNames.
21521 * report.cs: support Stacktrace on warnings as well.
21523 * makefile: drop --unsafe and /unsafe from the compile.
21525 2002-03-13 Ravi Pratap <ravi@ximian.com>
21527 * ecore.cs (StandardConversionExists): Modify to take an Expression
21528 as the first parameter. Ensure we do null -> reference type conversion
21531 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
21532 temporary Expression objects.
21534 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
21536 * interface.cs: workaround bug in method overloading resolution
21537 (there is already a bugzilla bug for it).
21539 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21541 We could also solve this problem by having a separate path for
21542 performing type lookups, instead of DoResolve, we could have a
21543 ResolveType entry point, and only participating pieces of the
21544 production (simplename, deref, array) would implement this.
21546 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
21547 signal SimpleName to only resolve type names and not attempt to
21548 resolve anything else.
21550 * expression.cs (Cast): Set the flag.
21552 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
21554 * class.cs: Only report 108 if there is no `new' modifier.
21556 * cs-parser.jay: rework foreach statement to work with the new
21557 changes to the policy on SimpleNames.
21559 * report.cs: support Stacktrace on warnings as well.
21561 * makefile: drop --unsafe and /unsafe from the compile.
21563 2002-03-11 Miguel de Icaza <miguel@ximian.com>
21565 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21566 lookups here, instead of doing that at parse time. This means
21567 that our grammar will not introduce `LocalVariableReferences' as
21568 expressions at this point. That solves the problem of code like
21572 static void Main ()
21576 This is only half the fix. The full fix requires parameters to
21577 also be handled in this way.
21579 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21580 makes the use more obvious of the DeclSpace. The
21581 ec.TypeContainer.TypeBuilder is now only used to pull the
21582 TypeBuilder for it.
21584 My theory is that I can get rid of the TypeBuilder completely from
21585 the EmitContext, and have typecasts where it is used (from
21586 DeclSpace to where it matters).
21588 The only pending problem is that the code that implements Aliases
21589 is on TypeContainer, and probably should go in DeclSpace.
21591 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21592 lookups here, instead of doing that at parse time. This means
21593 that our grammar will not introduce `LocalVariableReferences' as
21594 expressions at this point. That solves the problem of code like
21598 static void Main ()
21602 This is only half the fix. The full fix requires parameters to
21603 also be handled in this way.
21605 * class.cs (Property.DefineMethod): When implementing an interface
21606 method, set newslot, when implementing an abstract method, do not
21607 set the flag (before we tried never setting it, or always setting
21608 it, which is the difference).
21609 (Indexer.DefineMethod): same.
21610 (Method.DefineMethod): same.
21612 * ecore.cs: Only set the status used flag if we get back a Field.
21614 * attribute.cs: Temporary hack, so Paolo can keep working.
21616 2002-03-08 Ravi Pratap <ravi@ximian.com>
21618 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21619 the unmanaged type in the case we have a MarshalAs attribute.
21621 (Resolve): Handle the case when we are parsing the special MarshalAs
21622 attribute [we need to store the unmanaged type to use later]
21624 * typemanager.cs (marshal_as_attr_type): Built in type for the
21625 MarshalAs Attribute.
21627 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21628 on parameters and accordingly set the marshalling info.
21630 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21632 * class.cs: Optimizing slightly by removing redundant code after
21633 we switched to the `NoTypes' return value.
21634 (Property.DefineMethod): use NoTypes here too.
21636 This fixes the bug I introduced in my last batch of changes.
21638 2002-03-05 Ravi Pratap <ravi@ximian.com>
21640 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21642 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21643 Enums since those are types too.
21645 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21647 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21648 thanks to a call during the lookup process.
21650 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21652 * statement.cs (Foreach): Lots of work to accomodate a particular
21653 kind of foreach statement that I had not kept in mind. It is
21654 possible to have foreachs on classes that provide a GetEnumerator
21655 method that return objects that implement the "pattern" for using
21656 a foreach, there is no need to support GetEnumerator
21659 This is needed to compile nant.
21661 * decl.cs: Only report 114 if the member is not `Finalize' and if
21662 the warning level is at least 2.
21664 * class.cs: Moved the compare function from Method to
21667 (MethodSignature.InheritableMemberSignatureCompare): Add new
21668 filter function that is used to extract inheritable methods from a
21671 (Method.Define): Use the new `inheritable_method_signature_filter'
21674 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21677 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21679 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21681 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21683 * expression.cs: Pass location information to
21684 ConvertImplicitStandard.
21686 * class.cs: Added debugging code to track return values from
21689 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21691 * expression.cs (Is.DoResolve): If either side of the `is' is an
21692 interface, do not flag the warning.
21694 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21697 * report.cs: Allow for --fatal to be used with --probe.
21699 * typemanager.cs (NoTypes): Move the definition for the empty Type
21702 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21704 (TypeContainer.DefineProxy): New function used to proxy to parent
21705 implementations when implementing interfaces.
21706 (TypeContainer.ParentImplements): used to lookup if our parent
21707 implements a public function that is required by an interface.
21708 (TypeContainer.VerifyPendingMethods): Hook this up.
21710 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21711 `modules' and `assemblies' arraylists into arrays. We only grow
21712 these are the very early start up of the program, so this improves
21713 the speedof LookupType (nicely measured).
21715 * expression.cs (MakeByteBlob): Replaced unsafe code with
21716 BitConverter, as suggested by Paolo.
21718 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21719 folding of string concatenation, but if either side is a string,
21720 and the other is not, then return null, and let the runtime use
21721 the concatenation on the string plus the object (using
21722 `Object.ToString').
21724 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21726 Constant Folding has been implemented now.
21728 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21729 the error instead on types that are not supported in one's
21732 * constant.cs (Constant and all children): New set of functions to
21733 perform implict and explicit conversions.
21735 * ecore.cs (EnumConstant): Implement the new functions to perform
21736 conversion by proxying to the child expression.
21738 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21739 own separate setting that can not be turned off from the command
21740 line using --unchecked or --checked and is only controlled using
21741 the checked/unchecked statements and expressions. This setting is
21742 used by the constant folder to flag errors.
21744 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21745 ConstantCheckState as well.
21747 During Resolve, they also have to flag the state, because the
21748 constant folder runs completely in the Resolve phase.
21750 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21753 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21755 * cfold.cs: New file, this file contains the constant folder.
21757 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21758 argument to track whether we are using the resulting address to
21759 load or store a value and provide better error messages.
21761 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21762 new AddressOf arguments.
21764 * statement.cs (Foreach.EmitCollectionForeach): Update
21766 * expression.cs (Argument.Emit): Call AddressOf with proper
21767 arguments to track usage.
21769 (New.DoEmit): Call AddressOf with new arguments.
21771 (Unary.Emit): Adjust AddressOf call.
21773 2002-03-01 Ravi Pratap <ravi@ximian.com>
21775 * cs-parser.jay (member_access): Change the case for pre-defined types
21776 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21779 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21782 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21783 essentially like methods and apply attributes like MethodImplOptions to them too.
21785 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21788 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21789 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21792 * Update code everywhere accordingly.
21794 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21796 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21798 2002-02-28 Ravi Pratap <ravi@ximian.com>
21800 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21801 try performing lookups against those instead of jumping straight into using
21802 the 'using' clauses.
21804 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21806 (LookupType): Perform lookups in implicit parents too.
21808 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21809 sequence as RootContext.LookupType.
21811 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21812 the various cases of namespace lookups into this method.
21814 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21816 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21817 in positional arguments)
21819 * class.cs (Operator): Update the AllowedModifiers to contain
21822 * cs-parser.jay: Update operator declaration to allow for the
21823 operator body to be empty.
21825 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21828 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21830 * class.cs (Method.Emit): Label parameters.
21832 * driver.cs: Return 1 or 0 as the program exit code.
21834 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21836 * expression.cs: Special case the `null' object when trying to
21837 auto-compute the type, as anything can be explicitly converted to
21840 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21841 spotting this Paolo.
21843 (Expression.ImplicitNumericConversion): Perform comparissions of
21844 the type using the underlying type in the case of an enumeration
21845 rather than using the enumeration type for the compare.
21847 Cope with the underlying == type case, which is not possible to
21850 (Expression.ConvertNumericExplicit): Perform comparissions of
21851 the type using the underlying type in the case of an enumeration
21852 rather than using the enumeration type for the compare.
21854 * driver.cs: If the user does not supply an extension, assume .exe
21856 * cs-parser.jay (if_statement): Rewrote so that we can track the
21857 location for the if statement.
21859 * expression.cs (Binary.ConstantFold): Only concat strings when
21860 the operation is "+", not everything ;-)
21862 * statement.cs (Statement.EmitBoolExpression): Take a location
21864 (If, While, Do): Track location.
21866 * expression.cs (Binary.ResolveOperator): In the object + string
21867 case, I was missing a call to ConvertImplicit
21869 2002-02-25 Ravi Pratap <ravi@ximian.com>
21871 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21872 Location arguments. Ensure we use RootContext.LookupType to do our work
21873 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21875 * interface.cs (PopulateMethod): Handle the type of the parameter being
21878 * expression.cs (Invocation.BetterFunction): Handle the case when we
21879 have a params method with no fixed arguments and a call is made with no
21882 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21884 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21885 the verbatim-string-literal
21887 * support.cs (InternalParameters.ParameterModifier): handle null
21889 (InternalParameters.ParameterType): ditto.
21891 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21892 duplicating the name of the variable parameter.
21893 (GetParameterByName): Fix bug where we were not looking up array
21894 paramters if they were the only present (thanks Paolo!).
21895 (GetParameterInfo): We only have an empty set of types if both
21896 fixed and array are set to null.
21897 (GetParameterInfo-idx): Handle FixedParameter == null
21899 * cs-parser.jay: Handle the case where there is no catch
21900 statements (missing null test).
21902 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21904 * driver.cs (MainDriver): Be conservative on our command line
21907 Catch DirectoryNotFoundException when calling GetFiles.
21909 (SplitPathAndPattern): Used to split the input specification into
21910 a path and a pattern that we can feed to Directory.GetFiles.
21912 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21914 * statement.cs (Fixed): Implement the last case of the Fixed
21915 statement (string handling).
21917 * expression.cs (StringPtr): New class used to return a char * to
21918 a string; Used by the Fixed statement.
21920 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
21922 * expression.cs (Binary.ResolveOperator): Remove redundant
21923 MemberLookup pn parent type.
21924 Optimize union call, we do not need a union if the types are the same.
21925 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
21928 Specialize the use of MemberLookup everywhere, instead of using
21929 the default settings.
21931 (StackAlloc): Implement stackalloc keyword.
21933 * cs-parser.jay: Add rule to parse stackalloc.
21935 * driver.cs: Handle /h, /help, /?
21937 * expression.cs (MakeByteBlob): Removed the hacks we had in place
21938 before we supported unsafe code.
21940 * makefile: add --unsafe to the self compilation of mcs.
21942 2002-02-20 Miguel de Icaza <miguel@ximian.com>
21944 * expression.cs (PointerArithmetic): New class that is used to
21945 perform pointer arithmetic.
21946 (Binary.Resolve): Handle pointer arithmetic
21947 Handle pointer comparission.
21948 (ArrayPtr): Utility expression class that is used to take the
21949 address of an array.
21951 (ElementAccess): Implement array access for pointers
21953 * statement.cs (Fixed): Implement fixed statement for arrays, we
21954 are missing one more case before we are done.
21956 * expression.cs (Indirection): Implement EmitAssign and set the
21957 ExprClass to Variable. This allows pointer dereferences to be
21958 treated as variables, and to have values assigned to them.
21960 * ecore.cs (Expression.StoreFromPtr): New utility function to
21961 store values dereferencing.
21963 2002-02-20 Ravi Pratap <ravi@ximian.com>
21965 * expression.cs (Binary.ResolveOperator): Ensure that we are
21966 not trying to operate on a void type - this fixes the reported
21969 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
21970 the parent implementation is sealed.
21972 * ../errors/cs0239.cs : Add.
21974 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
21976 * typemanager.cs (unverifiable_code_type): Corresponds to
21977 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
21978 which have unsafe code in them.
21980 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
21983 2002-02-19 Miguel de Icaza <miguel@ximian.com>
21985 * cs-tokenizer.cs: Add support for @"litreal strings"
21987 Make tokenizer accept pre-processor directives
21988 on any column (remove the old C-like limitation).
21990 * rootcontext.cs (EmitCode): Emit any global attributes.
21991 (AddGlobalAttributes): Used to keep track of assembly attributes.
21993 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
21995 * cs-parser.jay: Add support for global attributes.
21997 2002-02-17 Miguel de Icaza <miguel@ximian.com>
21999 * expression.cs (Indirection): New helper class. Unary will
22000 create Indirection classes to be able to implement the
22001 IMemoryLocation interface on it.
22003 2002-02-16 Miguel de Icaza <miguel@ximian.com>
22005 * cs-parser.jay (fixed_statement): reference the right statement.
22007 * statement.cs (Fixed.Emit): Finish implementing the fixed
22008 statement for the &x case.
22010 2002-02-14 Miguel de Icaza <miguel@ximian.com>
22012 * class.cs (Property.Define, Method.Define): Remove newslot when
22015 * modifiers.cs: My use of NewSlot when `Abstract' was set was
22016 wrong. NewSlot should only be used if the `new' keyword is present.
22018 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
22019 locating our system dir. Sorry about this.
22021 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22023 * driver.cs (GetSystemDir): Compute correctly the location of our
22024 system assemblies. I was using the compiler directory instead of
22025 the library directory.
22027 2002-02-13 Ravi Pratap <ravi@ximian.com>
22029 * expression.cs (BetterFunction): Put back in what Miguel commented out
22030 since it is the correct fix. The problem is elsewhere ;-)
22032 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
22033 parameters of the parms method are themselves compatible or not !
22035 (StandardConversionExists): Fix very dangerous bug where we were forgetting
22036 to check that a class implements an interface before saying that an implicit
22037 conversion was allowed. Use ImplementsInterface to do the checking.
22039 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22041 * class.cs (Method.Define): Track whether we are an explicit
22042 implementation or not. And only call DefineMethodOverride if we
22043 are an explicit implementation.
22045 (Property.DefineMethod): Ditto.
22047 2002-02-11 Ravi Pratap <ravi@ximian.com>
22049 * expression.cs (BetterFunction): Catch hideous bug which was
22050 preventing us from detecting ambiguous calls due to implicit casts i.e
22053 2002-01-29 Miguel de Icaza <miguel@ximian.com>
22055 * support.cs (Pair): Remove un-needed method. I figured why I was
22056 getting the error in cs-parser.jay, the variable in a foreach loop
22057 is readonly, and the compiler does not really treat this as a variable.
22059 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
22060 instead of EQUALS in grammar.
22062 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
22064 * expression.cs (Unary.DoResolve): Check whether the argument is
22067 2002-01-28 Miguel de Icaza <miguel@ximian.com>
22069 * support.cs: Api for Pair to set a value. Despite the fact that
22070 the variables are public the MS C# compiler refuses to compile
22071 code that accesses the field if the variable is part of a foreach
22074 * statement.cs (Fixed): Begin implementation of the fixed
22077 (Block.AddVariable): Return the VariableInfo on success and null
22078 on failure instead of true/false.
22080 * cs-parser.jay (foreach): Catch errors on variables already
22081 defined (we were ignoring this value before) and properly unwind
22082 the block hierarchy
22084 (fixed_statement): grammar for the fixed statement.
22086 2002-01-25 Miguel de Icaza <miguel@ximian.com>
22088 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
22089 pointer types to be incretemented.
22091 (SizeOf): Implement.
22093 * cs-parser.jay (pointer_member_access): Implement
22094 expr->IDENTIFIER production.
22096 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
22097 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
22100 (Unary): Implement indirection.
22102 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
22103 use in non-unsafe context).
22105 (SimpleName.DoResolve): Check for pointers in field access on safe
22108 (Expression.LoadFromPtr): Factor the load-indirect code in this
22109 function. This was duplicated in UnboxCast and ParameterReference
22111 2002-01-24 Miguel de Icaza <miguel@ximian.com>
22113 * expression.cs (ComposedCast): report an error if a pointer cast
22114 is used in a safe region.
22116 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
22117 pointer type casts in unsafe context.
22119 * codegen.cs (EmitContext): Set up IsUnsafe.
22121 * cs-parser.jay (non_expression_type): Add productions for pointer
22124 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
22125 code. We should not use force into static mode if the method is
22126 not virtual. Fixes bug in MIS
22128 * statement.cs (Do.Emit, While.Emit, For.Emit,
22129 Statement.EmitBoolExpression): Add support to Do and While to
22130 propagate infinite loop as `I do return' semantics.
22132 Improve the For case to also test for boolean constants.
22134 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
22135 to the list of attributes we can add.
22137 Remove `EmitContext' argument.
22139 * class.cs (Method.Define): Apply parameter attributes.
22140 (Constructor.Define): Apply parameter attributes.
22141 (MethodCore.LabelParameters): Move here the core of labeling
22144 * support.cs (ReflectionParameters.ParameterModifier,
22145 InternalParameters.ParameterModifier): Use IsByRef on the type and
22146 only return the OUT bit for these parameters instead of in/out/ref
22149 This is because I miss-understood things. The ParameterInfo.IsIn
22150 and IsOut represent whether the parameter has the [In] and [Out]
22153 2002-01-22 Miguel de Icaza <miguel@ximian.com>
22155 * ecore.cs (FieldExpr.Emit): Release temporaries.
22157 * assign.cs (LocalTemporary.Release): new function.
22159 * codegen.cs (EmitContext.GetTemporaryStorage,
22160 EmitContext.FreeTemporaryStorage): Rework the way we deal with
22161 temporary storage. Now we can "put back" localbuilders when we
22164 2002-01-21 Miguel de Icaza <miguel@ximian.com>
22166 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
22167 need to make a copy of the variable to generate verifiable code.
22169 2002-01-19 Miguel de Icaza <miguel@ximian.com>
22171 * driver.cs: Compute dynamically the system directory.
22173 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
22174 Slower, but more generally useful. Used by the abstract
22175 registering implementation.
22177 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
22178 the rules for the special rule on Type/instances. First check if
22179 we have the same name, and if so, try that special static path
22180 rather than the instance path.
22182 2002-01-18 Miguel de Icaza <miguel@ximian.com>
22184 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
22187 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
22188 Enum, ValueType, Delegate or Array for non-corlib compiles.
22190 * cs-tokenizer.cs: Catch long identifiers (645)
22192 * typemanager.cs (IndexerPropetyName): Ravi never tested this
22195 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
22196 fix, we were returning too early, so we were not registering
22197 pending methods from abstract classes.
22199 Do not register pending methods if the class is abstract.
22201 * expression.cs (Conditional.DoResolve): Report circular implicit
22202 conversions when we neecd to compute it for conditional
22205 (Is.DoResolve): If the expression is always of the provided type,
22206 flag warning 183. If the expression can not ever be of the
22207 provided type flag warning 184.
22209 * class.cs: Catch 169 as well.
22211 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
22214 2002-01-18 Nick Drochak <ndrochak@gol.com>
22216 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
22218 2002-01-17 Miguel de Icaza <miguel@ximian.com>
22220 * interface.cs: (PopulateMethod): Check for pointers being defined
22221 only if the unsafe context is active.
22222 (PopulateProperty): ditto.
22223 (PopulateIndexer): ditto.
22225 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
22226 specified. If pointers are present, make sure that they are
22227 present in an unsafe context.
22228 (Constructor, Constructor.Define): ditto.
22229 (Field, Field.Define): ditto.
22230 (Property, Property.Define): ditto.
22231 (Event, Event.Define): ditto.
22233 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
22234 hashtable if there are classes or structs defined.
22236 * expression.cs (LocalVariableReference.DoResolve): Simplify this
22237 code, as the constant resolution moved.
22239 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
22240 the metadata, so we can flag error 133.
22242 * decl.cs (MemberCore.UnsafeOK): New function to test that a
22243 pointer is being declared in an unsafe context.
22245 2002-01-16 Miguel de Icaza <miguel@ximian.com>
22247 * modifiers.cs (Modifiers.Check): Require a Location argument.
22248 Report error 227 for Unsafe use.
22250 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
22252 * statement.cs (For.Emit): If the test is null, then report that
22253 we do `return', as we wont reach anything afterwards.
22255 (Switch.SwitchGoverningType): Track the expression that matched
22258 * driver.cs: Allow negative numbers as an error code to flag.
22260 * cs-parser.jay: Handle 1551.
22262 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
22264 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22266 * cs-parser.jay: Report 1518 (type declaration can only contain
22267 class, struct, interface, enum or delegate)
22269 (switch_label): Report 1523 (keywords `case' or `default' must
22272 (opt_switch_sections): Report 1522 (empty switch)
22274 * driver.cs: Report 1515 (response file specified multiple times)
22275 Report 1516 (Source file specified multiple times).
22277 * expression.cs (Argument.Resolve): Signal 1510
22279 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
22280 access not allowed in static code)
22282 2002-01-11 Ravi Pratap <ravi@ximian.com>
22284 * typemanager.cs (IsPointerType): Utility method which we are going
22287 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
22288 the object type, so we take care of that.
22290 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
22292 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
22293 added to non-params parameters :-)
22295 * typemanager.cs (CSharpName): Include 'void' type too.
22297 (void_ptr_type): Include in the set of core types.
22299 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
22302 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
22305 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
22306 completely forgotten about it.
22308 2002-01-10 Ravi Pratap <ravi@ximian.com>
22310 * cs-parser.jay (pointer_type): Add. This begins our implementation
22311 of parsing rules for unsafe code.
22313 (unsafe_statement): Implement.
22315 (embedded_statement): Modify to include the above.
22317 * statement.cs (Unsafe): Implement new class for unsafe blocks.
22319 * codegen.cs (EmitContext.InUnsafe): Add. This determines
22320 if the current context is an unsafe one.
22322 * cs-parser.jay (local_variable_pointer_type): Since local variable types
22323 are handled differently, we need separate rules for them.
22325 (local_variable_declaration): Update to use local_variable_pointer_type
22326 to allow variable declarations of unmanaged pointer types.
22328 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
22329 in unsafe contexts.
22331 * ../errors/cs0214.cs : Add.
22333 2002-01-16 Nick Drochak <ndrochak@gol.com>
22335 * makefile: remove 'response' file when cleaning.
22337 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22339 * cs-parser.jay: Report 1524.
22341 2002-01-14 Miguel de Icaza <miguel@ximian.com>
22343 * typemanager.cs (RegisterMethod): drop checking if we have
22344 registered this from here
22346 2002-01-12 Miguel de Icaza <miguel@ximian.com>
22348 * class.cs (Method.EmitDestructor): Implement calling our base
22351 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
22352 value of InFinally.
22354 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
22355 this routine and will wrap the call in a try/catch block. Deal
22358 2002-01-11 Miguel de Icaza <miguel@ximian.com>
22360 * ecore.cs (Expression.MemberLookup): instead of taking a
22361 parameter `same_type' that was used to tell whether we could
22362 access private members we compute our containing type from the
22365 (FieldExpr): Added partial support for volatile fields. This does
22366 not work for volatile fields exposed from assemblies, as I can not
22367 figure out how to extract the modreq from it.
22369 Updated all the source files to use this.
22371 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
22372 because it is referenced by MemberLookup very often.
22374 2002-01-09 Ravi Pratap <ravi@ximian.com>
22376 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
22377 TypeBuilder.GetCustomAttributes to retrieve what we need.
22379 Get rid of redundant default_member_attr_type as this is the same as
22380 default_member_type which already exists.
22382 * interface.cs, attribute.cs : Update accordingly.
22384 2002-01-08 Miguel de Icaza <miguel@ximian.com>
22386 * typemanager.cs: Enable IndexerPropertyName again. It does not
22387 work for TYpeBuilders though. Ravi, can you please fix this?
22389 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
22391 * expression.cs (Argument.Emit): Handle the case of ref objects
22392 being passed to ref functions;
22394 (ParameterReference.EmitLoad): Loads the content of the pointer
22395 without dereferencing.
22397 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22399 * cs-tokenizer.cs: Implemented the pre-processing expressions.
22401 2002-01-08 Ravi Pratap <ravi@ximian.com>
22403 * class.cs (Indexer.DefineMethod): Incorporate the interface
22404 type in the name of the method if we are doing explicit interface
22407 * expression.cs (ConversionExists): Remove as it is completely obsolete.
22409 (BetterConversion): Fix extremely trivial bug where we were referring to
22410 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
22413 * ../errors/bug16.cs : Add although we have fixed it.
22415 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22417 * expression.cs (BaseIndexer): Begin implementation.
22419 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
22421 * cs-parser.jay (indexer_declarator): Use qualified_identifier
22422 production directly to remove a shift/reduce, and implement
22423 explicit interface implementation.
22425 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
22426 after a floating point suffix.
22428 * expression.cs (DoNumericPromotions): Improved the conversion for
22429 uint/uint. If we have a constant, we avoid doing a typecast to a
22432 * class.cs (Indexer): Implement explicit interface implementation
22435 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
22437 * class.cs: make the default instance constructor public and hidebysig.
22439 2001-01-03 Ravi Pratap <ravi@ximian.com>
22441 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
22442 so we can call it from elsewhere.
22444 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
22445 we emit it internally if the class has a defined indexer; otherwise the user
22446 emits it by decorating the class definition with the DefaultMemberAttribute.
22448 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
22449 attribute is not used on a type which defines an indexer.
22451 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
22452 character when we skip whitespace.
22454 * ../errors/cs0646.cs : Add.
22456 2002-01-03 Miguel de Icaza <miguel@ximian.com>
22458 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
22461 * makefile: Add practical target `mcs3.exe' which builds the third
22462 generation compiler.
22464 * expression.cs (New): Fix structures constructor calling.
22466 * class.cs (Property, Method, Indexer): Emit Final flag on the
22467 method if we are an interface implementation and we are not
22470 * ecore.cs (PropertyExpr): New public field `IsBase', tells
22471 whether this property is referencing a `base' method.
22473 * expression.cs (Invocation.EmitCall): take an extra argument:
22474 is_base, this is used to determine whether the `call' or
22475 `callvirt' opcode should be used.
22478 * delegate.cs: update EmitCall.
22480 * class.cs (Method.Define): Set NewSlot for the cases where we are
22481 not implementing an interface method.
22483 (Property.Define): ditto.
22485 2002-01-02 Miguel de Icaza <miguel@ximian.com>
22487 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
22488 'r'. Allows mcs to parse itself fully.
22490 2002-01-02 Ravi Pratap <ravi@ximian.com>
22492 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
22493 of the number of initializers that require the InitializeArray method.
22495 (CheckIndices): Store the Expression in all cases - not the plain value. Also
22496 update the above field where necessary.
22498 (MakeByteBlob): Update accordingly.
22500 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
22503 (EmitDynamicInitializers): Update in accordance with the new optimization.
22505 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
22506 same OpCode applies.
22508 * cs-parser.jay : Fix some glaring errors I introduced.
22510 2002-01-01 Ravi Pratap <ravi@ximian.com>
22512 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
22513 so that we can check for name clashes there too.
22515 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
22516 for interface indexers.
22518 * interfaces.cs (Define): Emit the default member attribute.
22520 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
22521 variable was being referred to while setting the value ;-)
22523 2002-01-01 Miguel de Icaza <miguel@ximian.com>
22525 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
22526 byte-by-byte information when we know the data is zero.
22528 Make the block always a multiple of 4, because
22529 DefineInitializedData has a bug.
22531 * assign.cs: Fix, we should assign from the temporary, not from
22534 * expression.cs (MakeByteBlob): Fix my incorrect code.
22536 2001-12-31 Miguel de Icaza <miguel@ximian.com>
22538 * typemanager.cs (EnumToUnderlying): This function is used to get
22539 the underlying type from an enumeration, because it does not
22542 * constant.cs: Use the I4_S form for values between -128 and 127.
22544 * statement.cs (Block.LookupLabel): Looks up a label.
22545 (Block): Drop support for labeled blocks.
22547 (LabeledStatement): New kind of statement that represents a label
22550 (Goto): Finally implement this bad boy.
22552 * cs-parser.jay: Update to reflect new mechanism to implement
22555 2001-12-30 Miguel de Icaza <miguel@ximian.com>
22557 * codegen.cs (EmitContext.This): a codegen property that keeps the
22558 a single instance of this instead of creating many different this
22561 * delegate.cs (Delegate.DoResolve): Update to use the property;
22563 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
22565 * expression.cs (BaseAccess.DoResolve): Ditto.
22567 2001-12-29 Ravi Pratap <ravi@ximian.com>
22569 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22570 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22572 (InitCoreTypes): Update accordingly.
22574 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22575 so we can quickly store the state.
22577 (ApplyAttributes): Set the correct implementation flags
22578 for InternalCall methods.
22580 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22582 * expression.cs (EmitCall): if a method is not virtual, then do
22583 not use callvirt on it.
22585 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22586 user defined stuff) requires the use of stobj, which takes an
22587 address on the stack instead of an array and an index. So emit
22588 the Ldelema operation for it.
22590 (EmitStoreOpcode): Use stobj for valuetypes.
22592 (UnaryMutator.EmitCode): Use the right 1 value depending on
22593 whether we are dealing with int64/uint64, float or doubles.
22595 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22596 constructors that I implemented last night.
22598 (Constructor.IsDefault): Fix to work properly for static
22601 * cs-parser.jay (CheckDef): report method signature errors.
22602 Update error number 103 to be 132.
22604 * decl.cs: New AdditionResult enumeration value: MethodExists.
22605 Although we do this check for methods later on in the semantic
22606 analysis, catching repeated default constructors is so easy that
22607 we catch these here.
22609 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22612 (ParameterReference.EmitAssign, Emit): handle
22615 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22616 (ArrayAccess.EmitStoreOpcode): ditto.
22618 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22620 * expression.cs (MakeByteBlob): Complete all the missing types
22621 (uint, short, ushort, byte, sbyte)
22623 * class.cs: Only init instance field initializers on instance
22626 Rename `constructors' to instance_constructors.
22628 (TypeContainer.AddConstructor): Only add constructors to the list
22629 if it is not static.
22631 Make sure that we handle default_static_constructor independently
22632 everywhere where we handle instance_constructors
22634 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22636 * class.cs: Do not lookup or create a base initializer for a
22637 static constructor.
22639 (ConstructorInitializer.Resolve): use the proper type to lookup
22642 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22644 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22647 * decl.cs: CloseType is now an virtual method, the default
22648 implementation just closes this type.
22650 2001-12-28 Ravi Pratap <ravi@ximian.com>
22652 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22653 to PreserveSig by default. Also emit HideBySig on such methods.
22655 Basically, set the defaults to standard values.
22657 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22658 argument, if candidate is better, it can't be worse than the best !
22660 (Invocation): Re-write bits to differentiate between methods being
22661 applicable in their expanded form and their normal form - for params
22664 Get rid of use_standard everywhere as only standard conversions are allowed
22665 in overload resolution.
22667 More spec conformance.
22669 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22671 * driver.cs: Add --timestamp, to see where the compiler spends
22674 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22675 `this' in static code.
22677 (SimpleName.DoResolve): Implement in terms of a helper function
22678 that allows static-references to be passed upstream to
22681 (Expression.ResolveWithSimpleName): Resolve specially simple
22682 names when called by MemberAccess to implement the special
22685 (Expression.ImplicitReferenceConversion): Handle conversions from
22686 Null to reference types before others, as Null's type is
22689 * expression.cs (Invocation.EmitCall): Handle the special case of
22690 calling methods declared on a reference type from a ValueType
22691 (Base classes System.Object and System.Enum)
22693 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22694 the left hand side is a TypeExpr, not on every enumeration.
22696 (Binary.Resolve): If types are reference types, then do a cast to
22697 object on operators != and == of both arguments.
22699 * typemanager.cs (FindMembers): Extract instance and static
22700 members if requested.
22702 * interface.cs (PopulateProperty): Use void_type instead of null
22703 as the return type for the setter method.
22705 (PopulateIndexer): ditto.
22707 2001-12-27 Ravi Pratap <ravi@ximian.com>
22709 * support.cs (ReflectionParameters): Fix minor bug where we
22710 were examining the wrong parameter for the ParamArray attribute.
22712 Cope with requests for the type of the parameter at position
22713 greater than the params parameter's. We now return the element
22714 type of the params array as that makes more sense.
22716 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22717 accordingly as we no longer have to extract the element type
22720 (Invocation.OverloadResolve): Update.
22722 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22724 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22725 against IEnumerator, test whether the return value is a descendant
22726 of the IEnumerator interface.
22728 * class.cs (Indexer.Define): Use an auxiliary method to implement
22729 the other bits of the method definition. Begin support for
22730 explicit interface implementation.
22732 (Property.DefineMethod): Use TypeManager.void_type instead of null
22733 for an empty return value.
22735 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22737 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22738 dealing with a FieldExpr which is composed of a FieldBuilder, in
22739 the code path we did extract the constant, but we should have
22740 obtained the underlying value to be able to cast it (otherwise we
22741 end up in an infinite loop, this is what Ravi was running into).
22743 (ArrayCreation.UpdateIndices): Arrays might be empty.
22745 (MemberAccess.ResolveMemberAccess): Add support for section
22746 14.5.4.1 that deals with the special case of E.I when E is a type
22747 and something else, that I can be a reference to a static member.
22749 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22750 handle a particular array type to create byte blobs, it is just
22751 something we dont generate byteblobs for.
22753 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22756 * location.cs (Push): remove the key from the hashtable that we
22757 are about to add. This happens for empty files.
22759 * driver.cs: Dispose files after we have parsed them.
22761 (tokenize): new function that only runs the tokenizer on its
22762 input, for speed testing.
22764 2001-12-26 Ravi Pratap <ravi@ximian.com>
22766 * class.cs (Event.Define): Define the private field only if there
22767 are no accessors defined.
22769 * expression.cs (ResolveMemberAccess): If there is no associated
22770 field with the event, that means we have an event defined with its
22771 own accessors and we should flag error cs0070 since transforming
22772 ourselves into a field is not valid in that case.
22774 * ecore.cs (SimpleName.DoResolve): Same as above.
22776 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22777 and charset to sane values.
22779 2001-12-25 Ravi Pratap <ravi@ximian.com>
22781 * assign.cs (DoResolve): Perform check on events only if they
22782 are being accessed outside the declaring type.
22784 * cs-parser.jay (event_declarations): Update rules to correctly
22785 set the type of the implicit parameter etc.
22787 (add_accessor, remove_accessor): Set current local parameters.
22789 * expression.cs (Binary): For delegate addition and subtraction,
22790 cast the return value from the method into the appropriate delegate
22793 2001-12-24 Ravi Pratap <ravi@ximian.com>
22795 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22796 of these as the workaround is unnecessary.
22798 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22799 delegate data - none of that is needed at all.
22801 Re-write bits to extract the instance expression and the delegate method
22804 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22807 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22808 of attaching attributes instead of duplicating code everywhere.
22810 * everywhere : Update code to do attribute emission using the above method.
22812 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22814 * expression.cs (IsParamsMethodApplicable): if there are not
22815 parameters, return immediately.
22817 * ecore.cs: The 0 literal can be implicity converted to an enum
22820 (SimpleName.DoResolve): First lookup the type, then lookup the
22823 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22824 want to get its address. If the InstanceExpression is not
22825 addressable, store the result in a temporary variable, then get
22828 * codegen.cs: Only display 219 errors on warning level or above.
22830 * expression.cs (ArrayAccess): Make it implement the
22831 IMemoryLocation interface.
22833 (Binary.DoResolve): handle the operator == (object a, object b)
22834 and operator != (object a, object b) without incurring into a
22835 BoxedCast (because 5 != o should never be performed).
22837 Handle binary enumerator operators.
22839 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22840 value type, otherwise use Ldelem_ref.
22842 Use precomputed names;
22844 (AddressOf): Implement address of
22846 * cs-parser.jay (labeled_statement): Fix recursive block
22847 addition by reworking the production.
22849 * expression.cs (New.DoEmit): New has a special case:
22851 If we are dealing with a ValueType, we have a few
22852 situations to deal with:
22854 * The target of New is a ValueType variable, that is
22855 easy, we just pass this as the variable reference
22857 * The target of New is being passed as an argument,
22858 to a boxing operation or a function that takes a
22861 In this case, we need to create a temporary variable
22862 that is the argument of New.
22865 2001-12-23 Ravi Pratap <ravi@ximian.com>
22867 * rootcontext.cs (LookupType): Check that current_type is not null before
22868 going about looking at nested types.
22870 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22871 not implement the IAssignMethod interface any more.
22873 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22874 where we tranform them into FieldExprs if they are being resolved from within
22875 the declaring type.
22877 * ecore.cs (SimpleName.DoResolve): Do the same here.
22879 * assign.cs (DoResolve, Emit): Clean up code considerably.
22881 * ../errors/bug10.cs : Add.
22883 * ../errors/cs0070.cs : Add.
22885 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22887 * assign.cs : Get rid of EventIsLocal everywhere.
22889 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22891 * ecore.cs (ConvertIntLiteral): finished the implementation.
22893 * statement.cs (SwitchLabel): Convert the value we are using as a
22894 key before looking up the table.
22896 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22898 * codegen.cs (EmitTopBlock): Require a Location argument now.
22900 * cs-parser.jay (constructor_declarator): We need to setup
22901 current_local_parameters before we parse the
22902 opt_constructor_initializer, to allow the variables to be bound
22903 to the constructor arguments.
22905 * rootcontext.cs (LookupType): First lookup nested classes in our
22906 class and our parents before we go looking outside our class.
22908 * expression.cs (ConstantFold): Extract/debox the values at the
22911 * rootcontext.cs (EmitCode): Resolve the constants first before we
22912 resolve the types. This is not really needed, but it helps debugging.
22914 * statement.cs: report location.
22916 * cs-parser.jay: pass location to throw statement.
22918 * driver.cs: Small bug fix.
22920 * report.cs: Updated format to be 4-zero filled digits.
22922 2001-12-22 Ravi Pratap <ravi@ximian.com>
22924 * expression.cs (CheckIndices): Fix minor bug where the wrong
22925 variable was being referred to ;-)
22927 (DoEmit): Do not call EmitStaticInitializers when the
22928 underlying type is System.Object.
22930 2001-12-21 Ravi Pratap <ravi@ximian.com>
22932 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
22933 and do the usual workaround for SRE.
22935 * class.cs (MyEventBuilder.EventType): New member to get at the type
22936 of the event, quickly.
22938 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
22940 * assign.cs (Assign.DoResolve): Handle the case when the target
22941 is an EventExpr and perform the necessary checks.
22943 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
22946 (SimpleName.MemberStaticCheck): Include check for EventExpr.
22948 (EventExpr): Set the type in the constructor itself since we
22949 are meant to be born fully resolved.
22951 (EventExpr.Define): Revert code I wrote earlier.
22953 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
22954 instance expression is null. The instance expression is a This in that case
22955 or a null, depending on whether it is a static method or not.
22957 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
22958 refers to more than one method.
22960 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
22961 and accordingly flag errors.
22963 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22965 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
22967 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22969 * location.cs (ToString): Provide useful rutine.
22971 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22973 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
22974 objects, return the actual integral boxed.
22976 * statement.cs (SwitchLabel): define an ILLabel for each
22979 (Switch.CheckSwitch): If the value is a Literal, extract
22980 the underlying literal.
22982 Also in the unused hashtable we had, add the SwitchLabel so we can
22983 quickly look this value up.
22985 * constant.cs: Implement a bunch of new constants. Rewrite
22986 Literal based on this. Made changes everywhere to adapt to this.
22988 * expression.cs (Expression.MakeByteBlob): Optimize routine by
22989 dereferencing array only once, and also copes with enumrations.
22991 bytes are two bytes wide, not one.
22993 (Cast): Perform constant conversions.
22995 * ecore.cs (TryImplicitIntConversion): Return literals instead of
22996 wrappers to the literals here.
22998 * expression.cs (DoNumericPromotions): long literals can converted
22999 to ulong implicity (this is taken care of elsewhere, but I was
23000 missing this spot).
23002 * ecore.cs (Expression.Literalize): Make the return type Literal,
23003 to improve type checking.
23005 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
23007 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23009 * literal.cs: Revert code from ravi that checked the bounds. The
23010 bounds are sane by the definition of the type itself.
23012 * typemanager.cs: Fix implementation of ImplementsInterface. We
23013 need to actually look up in our parent hierarchy for interfaces
23016 * const.cs: Use the underlying type for enumerations
23018 * delegate.cs: Compute the basename for the delegate creation,
23019 that should fix the delegate test case, and restore the correct
23020 Type Lookup semantics in rootcontext
23022 * rootcontext.cs: Revert Ravi's last patch. The correct way of
23023 referencing a nested type with the Reflection API is using the "+"
23026 * cs-parser.jay: Do not require EOF token at the end.
23028 2001-12-20 Ravi Pratap <ravi@ximian.com>
23030 * rootcontext.cs (LookupType): Concatenate type names with
23031 a '.' instead of a '+' The test suite passes again.
23033 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
23034 field of the enumeration.
23036 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
23037 the case when the member is an EventExpr.
23039 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
23040 static has an associated instance expression.
23042 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
23044 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
23046 * class.cs (Event.Define): Register event and perform appropriate checks
23049 We define the Add and Remove methods even if the use provides none because
23050 in that case, we provide default implementations ourselves.
23052 Define a private field of the type of the event. This is done by the CSC compiler
23053 and we should be doing it too ;-)
23055 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
23056 More methods we use in code we generate.
23058 (multicast_delegate_type, delegate_type): Two separate types since the distinction
23061 (InitCoreTypes): Update accordingly for the above.
23063 * class.cs (Event.Emit): Generate code for default accessors that we provide
23065 (EmitDefaultMethod): Do the job in the above.
23067 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
23070 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23072 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
23073 builders even if we were missing one.
23075 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
23076 pass the Basename as our class name instead of the Name. The
23077 basename will be correctly composed for us.
23079 * parameter.cs (Paramters): Now takes a Location argument.
23081 * decl.cs (DeclSpace.LookupType): Removed convenience function and
23082 make all the code call directly LookupType in RootContext and take
23083 this chance to pass the Location information everywhere.
23085 * Everywhere: pass Location information.
23087 2001-12-19 Miguel de Icaza <miguel@ximian.com>
23089 * class.cs (Constructor.Define): Updated way of detecting the
23090 length of the parameters.
23092 (TypeContainer.DefineType): Use basename as the type name for
23095 (TypeContainer.Define): Do not recursively define types here, as
23096 definition is taken care in order by the RootContext.
23098 * tree.cs: Keep track of namespaces in a per-file basis.
23100 * parameter.cs (Parameter.ComputeSignature): Update to use
23103 (Parameters.GetSignature): ditto.
23105 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
23106 instead of a TypeContainer.
23108 (Interface.SemanticAnalysis): Use `this' instead of our parent to
23109 resolve names. Because we need to be resolve in our context, not
23112 * driver.cs: Implement response files.
23114 * class.cs (TypeContainer.DefineType): If we are defined, do not
23115 redefine ourselves.
23117 (Event.Emit): Emit the code for add/remove handlers.
23118 (Event.Define): Save the MethodBuilders for add/remove.
23120 * typemanager.cs: Use pair here too.
23122 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
23123 DictionaryEntry requires the first argument to be non-null.
23125 (enum_declaration): Compute full name for registering the
23128 (delegate_declaration): Instead of using
23129 formal_parameter_list, use opt_formal_parameter_list as the list
23132 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
23133 (EventParsing): New property that controls whether `add' and
23134 `remove' are returned as tokens or identifiers (for events);
23136 2001-12-19 Ravi Pratap <ravi@ximian.com>
23138 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
23139 use MyEventBuilder only and let it wrap the real builder for us.
23141 (MyEventBuilder): Revamp constructor etc.
23143 Implement all operations that we perform on EventBuilder in precisely the same
23146 (FindMembers): Update to use the EventBuilder member.
23148 (Event.Emit): Update accordingly.
23150 2001-12-18 Ravi Pratap <ravi@ximian.com>
23152 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
23153 by calling the appropriate methods.
23155 (GetCustomAttributes): Make stubs as they cannot possibly do anything
23158 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
23160 2001-12-17 Ravi Pratap <ravi@ximian.com>
23162 * delegate.cs (Delegate.Populate): Check that the return type
23163 and various parameters types are indeed accessible.
23165 * class.cs (Constructor.Define): Same here.
23167 (Field.Define): Ditto.
23169 (Event.Define): Ditto.
23171 (Operator.Define): Check that the underlying Method defined itself
23172 correctly - so it's MethodBuilder should not be null.
23174 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
23175 expression happens to be null.
23177 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
23178 members but as of now we don't seem to be able to do anything really useful with it.
23180 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
23181 not the EventBuilder.
23183 2001-12-18 Miguel de Icaza <miguel@ximian.com>
23185 * cs-tokenizer.cs: Add support for defines.
23186 Add support for #if, #elif, #else, #endif
23188 (eval_var): evaluates a variable.
23189 (eval): stubbed for evaluating functions.
23191 * cs-parser.jay: Pass the defines information
23193 * driver.cs: Add --define command line option.
23195 * decl.cs: Move MemberCore here.
23197 Make it the base class for DeclSpace. This allows us to catch and
23198 report 108 and 109 for everything now.
23200 * class.cs (TypeContainer.Define): Extract all the members
23201 before populating and emit the warning 108 (new keyword required
23202 to override) instead of having each member implement this.
23204 (MemberCore.Define): New abstract method, we will be using this in
23205 the warning reporting engine in Populate.
23207 (Operator.Define): Adjust to new MemberCore protocol.
23209 * const.cs (Const): This does not derive from Expression, it is a
23210 temporary object we use to create fields, it is a MemberCore.
23212 * class.cs (Method.Define): Allow the entry point to be in a
23215 * driver.cs: Rewrite the argument handler to clean it up a bit.
23217 * rootcontext.cs: Made it just an auxiliary namespace feature by
23218 making everything static.
23220 * driver.cs: Adapt code to use RootContext type name instead of
23223 * delegate.cs: Remove RootContext argument.
23225 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
23228 * class.cs (Event.Define): The lookup can fail.
23230 * cs-tokenizer.cs: Begin implementation of pre-procesor.
23232 * expression.cs: Resolve the this instance before invoking the code.
23234 2001-12-17 Miguel de Icaza <miguel@ximian.com>
23236 * cs-parser.jay: Add a production in element_access that allows
23237 the thing to become a "type" reference. This way we can parse
23238 things like "(string [])" as a type.
23240 Note that this still does not handle the more complex rules of
23244 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
23246 * ecore.cs: (CopyNewMethods): new utility function used to
23247 assemble the list of methods from running FindMembers.
23249 (MemberLookup): Rework FindMembers so that
23251 2001-12-16 Miguel de Icaza <miguel@ximian.com>
23253 * class.cs (TypeContainer): Remove Delegates who fail to be
23256 * delegate.cs (Populate): Verify that we dont get null return
23257 values. TODO: Check for AsAccessible.
23259 * cs-parser.jay: Use basename to emit error 574 (destructor should
23260 have the same name as container class), not the full name.
23262 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
23263 possible representation.
23265 Also implements integer type suffixes U and L.
23267 2001-12-15 Miguel de Icaza <miguel@ximian.com>
23269 * expression.cs (ArrayCreation.DoResolve): We need to do the
23270 argument resolution *always*.
23272 * decl.cs: Make this hold the namespace. Hold the root context as
23274 (LookupType): Move here.
23276 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
23278 * location.cs (Row, Name): Fixed the code, it was always returning
23279 references to the first file.
23281 * interface.cs: Register properties defined through interfaces.
23283 * driver.cs: Add support for globbing on the command line
23285 * class.cs (Field): Make it derive from MemberCore as well.
23288 2001-12-15 Ravi Pratap <ravi@ximian.com>
23290 * class.cs (Event::Define): Check that the type of the event is a delegate
23291 type else flag error #66.
23293 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
23296 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
23297 values of EntryPoint, CharSet etc etc.
23299 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
23301 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
23302 be null and we should ignore this. I am not sure if this is really clean. Apparently,
23303 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
23304 which needs this to do its work.
23306 * ../errors/cs0066.cs : Add.
23308 2001-12-14 Miguel de Icaza <miguel@ximian.com>
23310 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
23313 * class.cs: (MethodSignature.MethodSignature): Removed hack that
23314 clears out the parameters field.
23315 (MemberSignatureCompare): Cleanup
23317 (MemberCore): New base class used to share code between MethodCore
23320 (RegisterRequiredImplementations) BindingFlags.Public requires
23321 either BindingFlags.Instace or Static. Use instance here.
23323 (Property): Refactored code to cope better with the full spec.
23325 * parameter.cs (GetParameterInfo): Return an empty array instead
23328 * class.cs (Property): Abstract or extern properties have no bodies.
23330 * parameter.cs (GetParameterInfo): return a zero-sized array.
23332 * class.cs (TypeContainer.MethodModifiersValid): Move all the
23333 method modifier validation to the typecontainer so we can reuse
23334 this on properties.
23336 (MethodCore.ParameterTypes): return an empty sized array of types.
23338 (Property.Define): Test property modifier validity.
23340 Add tests for sealed/override too.
23342 (Method.Emit): abstract or extern methods have no bodies.
23344 2001-12-14 Ravi Pratap <ravi@ximian.com>
23346 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
23349 (Method::Define, ::Emit): Modify accordingly.
23351 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
23353 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
23355 * makefile: Pass in /unsafe.
23357 2001-12-13 Miguel de Icaza <miguel@ximian.com>
23359 * class.cs (MakeKey): Kill routine.
23361 * class.cs (TypeContainer.Define): Correctly define explicit
23362 method implementations (they require the full interface name plus
23365 * typemanager.cs: Deply the PtrHashtable here and stop using the
23366 lame keys. Things work so much better.
23368 This of course broke everyone who depended on `RegisterMethod' to
23369 do the `test for existance' test. This has to be done elsewhere.
23371 * support.cs (PtrHashtable): A hashtable that avoid comparing with
23372 the object stupid Equals method (because, that like fails all over
23373 the place). We still do not use it.
23375 * class.cs (TypeContainer.SetRequiredInterface,
23376 TypeContainer.RequireMethods): Killed these two routines and moved
23377 all the functionality to RegisterRequiredImplementations.
23379 (TypeContainer.RegisterRequiredImplementations): This routine now
23380 registers all the implementations required in an array for the
23381 interfaces and abstract methods. We use an array of structures
23382 which can be computed ahead of time to reduce memory usage and we
23383 also assume that lookups are cheap as most classes will not
23384 implement too many interfaces.
23386 We also avoid creating too many MethodSignatures.
23388 (TypeContainer.IsInterfaceMethod): Update and optionally does not
23389 clear the "pending" bit if we find that there are problems with
23392 (TypeContainer.VerifyPendingMethods): Update to report errors of
23393 methods that look like implementations but are not.
23395 (TypeContainer.Define): Add support for explicit interface method
23398 2001-12-12 Miguel de Icaza <miguel@ximian.com>
23400 * typemanager.cs: Keep track of the parameters here instead of
23401 being a feature of the TypeContainer.
23403 * class.cs: Drop the registration of parameters here, as
23404 InterfaceMethods are also interface declarations.
23406 * delegate.cs: Register methods with the TypeManager not only with
23407 the TypeContainer. This code was buggy.
23409 * interface.cs: Full registation here.
23411 2001-12-11 Miguel de Icaza <miguel@ximian.com>
23413 * expression.cs: Remove reducer for binary expressions, it can not
23416 * const.cs: Put here the code that used to go into constant.cs
23418 * constant.cs: Put here the code for constants, this is a new base
23419 class for Literals.
23421 * literal.cs: Make Literal derive from Constant.
23423 2001-12-09 Miguel de Icaza <miguel@ximian.com>
23425 * statement.cs (Return.Emit): Report error 157 if the user
23426 attempts to return from a finally block.
23428 (Return.Emit): Instead of emitting a return, jump to the end of
23431 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
23432 LocalBuilder to store the result of the function. ReturnLabel is
23433 the target where we jump.
23436 2001-12-09 Radek Doulik <rodo@ximian.com>
23438 * cs-parser.jay: remember alias in current namespace
23440 * ecore.cs (SimpleName::DoResolve): use aliases for types or
23443 * class.cs (LookupAlias): lookup alias in my_namespace
23445 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
23447 (LookupAlias): lookup alias in this and if needed in parent
23450 2001-12-08 Miguel de Icaza <miguel@ximian.com>
23454 * rootcontext.cs: (ModuleBuilder) Made static, first step into
23455 making things static. I need this to avoid passing the
23456 TypeContainer when calling ParameterType.
23458 * support.cs (InternalParameters.ParameterType): Remove ugly hack
23459 that did string manipulation to compute the type and then call
23460 GetType. Use Parameter.ParameterType instead.
23462 * cs-tokenizer.cs: Consume the suffix for floating values.
23464 * expression.cs (ParameterReference): figure out whether this is a
23465 reference parameter or not. Kill an extra variable by computing
23466 the arg_idx during emission.
23468 * parameter.cs (Parameters.GetParameterInfo): New overloaded
23469 function that returns whether a parameter is an out/ref value or not.
23471 (Parameter.ParameterType): The type of the parameter (base,
23472 without ref/out applied).
23474 (Parameter.Resolve): Perform resolution here.
23475 (Parameter.ExternalType): The full type (with ref/out applied).
23477 * statement.cs (Using.Emit, Using.EmitExpression): Implement
23478 support for expressions on the using statement.
23480 2001-12-07 Miguel de Icaza <miguel@ximian.com>
23482 * statement.cs (Using.EmitLocalVariableDecls): Split the
23483 localvariable handling of the using statement.
23485 (Block.EmitMeta): Keep track of variable count across blocks. We
23486 were reusing slots on separate branches of blocks.
23488 (Try.Emit): Emit the general code block, we were not emitting it.
23490 Check the type of the declaration to be an IDisposable or
23491 something that can be implicity converted to it.
23493 Emit conversions if required.
23495 * ecore.cs (EmptyExpression): New utility class.
23496 (Expression.ImplicitConversionExists): New utility function.
23498 2001-12-06 Miguel de Icaza <miguel@ximian.com>
23500 * statement.cs (Using): Implement.
23502 * expression.cs (LocalVariableReference): Support read only variables.
23504 * statement.cs: Remove the explicit emit for the Leave opcode.
23505 (VariableInfo): Add a readonly field.
23507 2001-12-05 Miguel de Icaza <miguel@ximian.com>
23509 * ecore.cs (ConvCast): new class used to encapsulate the various
23510 explicit integer conversions that works in both checked and
23511 unchecked contexts.
23513 (Expression.ConvertNumericExplicit): Use new ConvCast class to
23514 properly generate the overflow opcodes.
23516 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23518 * statement.cs: The correct type for the EmptyExpression is the
23519 element_type, not the variable type. Ravi pointed this out.
23521 2001-12-04 Ravi Pratap <ravi@ximian.com>
23523 * class.cs (Method::Define): Handle PInvoke methods specially
23524 by using DefinePInvokeMethod instead of the usual one.
23526 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
23527 above to do the task of extracting information and defining the method.
23529 2001-12-04 Ravi Pratap <ravi@ximian.com>
23531 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
23532 of the condition for string type.
23534 (Emit): Move that here.
23536 (ArrayCreation::CheckIndices): Keep string literals in their expression
23539 (EmitDynamicInitializers): Handle strings appropriately.
23541 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23543 * codegen.cs (EmitContext): Replace multiple variables with a
23544 single pointer to the current Switch statement.
23546 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
23549 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23553 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
23556 (Foreach.Emit): Foreach on arrays was not setting
23557 up the loop variables (for break/continue).
23559 (GotoCase): Semi-implented.
23561 2001-12-03 Ravi Pratap <ravi@ximian.com>
23563 * attribute.cs (CheckAttribute): Handle system attributes by using
23564 Attribute.GetAttributes to examine information we need.
23566 (GetValidPlaces): Same here.
23568 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23570 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23572 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23574 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23576 (Method::Emit): Handle the case when we are a PInvoke method.
23578 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23580 * expression.cs: Use ResolveWithSimpleName on compound names.
23582 2001-12-02 Ravi Pratap <ravi@ximian.com>
23584 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23585 before trying to reduce it.
23587 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23589 * constant.cs (LookupConstantValue): Implement.
23591 (EmitConstant): Use the above in emitting the constant.
23593 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23594 that are user-defined by doing a LookupConstantValue on them.
23596 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23599 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23601 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23603 (BaseAccess.DoResolve): Implement.
23605 (MemberAccess.DoResolve): Split this routine into a
23606 ResolveMemberAccess routine that can be used independently
23608 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23610 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23611 As that share bits of the implementation. Is returns a boolean,
23612 while As returns the Type that is being probed.
23614 2001-12-01 Ravi Pratap <ravi@ximian.com>
23616 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23617 instead of a Literal - much easier.
23619 (EnumInTransit): Remove - utterly useless :-)
23621 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23623 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23625 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23626 chain when we have no associated expression.
23628 2001-11-30 Ravi Pratap <ravi@ximian.com>
23630 * constant.cs (Define): Use Location while reporting the errror.
23632 Also emit a warning when 'new' is used and there is no inherited
23635 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23638 (LookupEnumValue): Implement to lookup an enum member's value and define it
23641 (Populate): Re-write accordingly to use the above routine.
23643 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23645 * expression.cs (This): Fix prototype for DoResolveLValue to
23646 override the base class DoResolveLValue.
23648 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23651 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23652 (we need to load the address of the field here). This fixes
23655 (FieldExpr.DoResolveLValue): Call the DoResolve
23656 function to initialize the Instance expression.
23658 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23659 correctly the GetEnumerator operation on a value type.
23661 * cs-parser.jay: Add more simple parsing error catches.
23663 * statement.cs (Switch): Add support for string switches.
23664 Handle null specially.
23666 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23668 2001-11-28 Ravi Pratap <ravi@ximian.com>
23670 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23672 (declare_local_constant): New helper function.
23674 * statement.cs (AddConstant): Keep a separate record of constants
23676 (IsConstant): Implement to determine if a variable is a constant.
23678 (GetConstantExpression): Implement.
23680 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23682 * statement.cs (IsVariableDefined): Re-write.
23684 2001-11-27 Ravi Pratap <ravi@ximian.com>
23686 * class.cs (TypeContainer::FindMembers): Look for constants
23687 in the case when we are looking for MemberTypes.Field
23689 * expression.cs (MemberAccess::DoResolve): Check that in the
23690 case we are a FieldExpr and a Literal, we are not being accessed
23691 by an instance reference.
23693 * cs-parser.jay (local_constant_declaration): Implement.
23695 (declaration_statement): Implement for constant declarations.
23697 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23699 * statement.cs (Switch): Catch double defaults.
23701 (Switch): More work on the switch() statement
23702 implementation. It works for integral values now, need to finish
23706 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23708 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23709 integer literals into other integer literals. To be used by
23712 2001-11-24 Ravi Pratap <ravi@ximian.com>
23714 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23717 (EmitDynamicInitializers): Cope with the above since we extract data
23718 directly from ArrayData now.
23720 (ExpectInitializers): Keep track of whether initializers are mandatory
23723 (Bounds): Make it a hashtable to prevent the same dimension being
23724 recorded for every element in that dimension.
23726 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23729 Also fix bug which was causing the indices to be emitted in the reverse
23732 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23734 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23735 unfinished. They do not work, because the underlying code is
23738 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23740 * cs-parser.jay: Remove bogus fixme.
23742 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23743 on Switch statement.
23745 2001-11-23 Ravi Pratap <ravi@ximian.com>
23747 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23750 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23751 parameter. Apparently, any expression is allowed.
23753 (ValidateInitializers): Update accordingly.
23755 (CheckIndices): Fix some tricky bugs thanks to recursion.
23757 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23758 I was being completely brain-dead.
23760 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23761 and re-write acordingly.
23763 (DelegateInvocation): Re-write accordingly.
23765 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23767 (MakeByteBlob): Handle types more correctly.
23769 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23770 initialization from expressions but it is incomplete because I am a complete
23773 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23775 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23776 on If. Basically, we have to return `true' (ie, we do return to
23777 our caller) only if both branches of the if return.
23779 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23780 short-circuit operators, handle them as short circuit operators.
23782 (Cast.DoResolve): Resolve type.
23783 (Cast.Cast): Take an expression as the target type.
23785 * cs-parser.jay (cast_expression): Remove old hack that only
23786 allowed a limited set of types to be handled. Now we take a
23787 unary_expression and we resolve to a type during semantic
23790 Use the grammar productions from Rhys to handle casts (this is
23791 not complete like Rhys syntax yet, we fail to handle that corner
23792 case that C# has regarding (-x), but we will get there.
23794 2001-11-22 Ravi Pratap <ravi@ximian.com>
23796 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23797 field which is an array type.
23799 * cs-parser.jay (declare_local_variables): Support array initialization too.
23801 * typemanager.cs (MakeKey): Implement.
23803 (everywhere): Use the above appropriately.
23805 * cs-parser.jay (for_statement): Update for array initialization while
23806 declaring variables.
23808 * ecore.cs : The error message was correct, it's the variable's names that
23809 were misleading ;-) Make the code more readable.
23811 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23812 the correct type etc.
23814 (ConvertExplicit): Handle Enum types by examining the underlying type.
23816 2001-11-21 Ravi Pratap <ravi@ximian.com>
23818 * parameter.cs (GetCallingConvention): Always return
23819 CallingConventions.Standard for now.
23821 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23823 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23824 and `r' after calling DoNumericPromotions.
23826 * ecore.cs: Fix error message (the types were in the wrong order).
23828 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23829 BindingFlags.Instance as well
23831 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23832 implicit int literal conversion in an empty cast so that we
23833 propagate the right type upstream.
23835 (UnboxCast): new class used to unbox value types.
23836 (Expression.ConvertExplicit): Add explicit type conversions done
23839 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23840 the target type before applying the implicit LongLiterals to ULong
23843 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23845 * cs-parser.jay (for_statement): Reworked the way For works: now
23846 we declare manually any variables that are introduced in
23847 for_initializer to solve the problem of having out-of-band code
23848 emition (that is what got for broken).
23850 (declaration_statement): Perform the actual variable declaration
23851 that used to be done in local_variable_declaration here.
23853 (local_variable_declaration): Do not declare anything, just pass
23854 the information on a DictionaryEntry
23856 2001-11-20 Ravi Pratap <ravi@ximian.com>
23858 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23859 re-write of the logic to now make it recursive.
23861 (UpdateIndices): Re-write accordingly.
23863 Store element data in a separate ArrayData list in the above methods.
23865 (MakeByteBlob): Implement to dump the array data into a byte array.
23867 2001-11-19 Ravi Pratap <ravi@ximian.com>
23869 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23872 * constant.cs (Define): Implement.
23874 (EmitConstant): Re-write fully.
23876 Pass in location info.
23878 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23881 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23882 DictionaryEntry since we need location info too.
23884 (constant_declaration): Update accordingly.
23886 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23887 code into another method : UpdateIndices.
23889 2001-11-18 Ravi Pratap <ravi@ximian.com>
23891 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23892 some type checking etc.
23894 2001-11-17 Ravi Pratap <ravi@ximian.com>
23896 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23897 bits to provide dimension info if the user skips doing that.
23899 Update second constructor to store the rank correctly.
23901 2001-11-16 Ravi Pratap <ravi@ximian.com>
23903 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23904 and try to implement.
23906 * ../errors/cs0150.cs : Add.
23908 * ../errors/cs0178.cs : Add.
23910 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23912 * statement.cs: Implement foreach on multi-dimensional arrays.
23914 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23915 name of the params argument.
23917 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23918 initializing the array.
23920 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
23921 we can use this elsewhere.
23923 * statement.cs: Finish implementation of foreach for single
23926 * cs-parser.jay: Use an out-of-band stack to pass information
23927 around, I wonder why I need this.
23929 foreach_block: Make the new foreach_block the current_block.
23931 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
23932 function used to return a static Parameters structure. Used for
23933 empty parameters, as those are created very frequently.
23935 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
23937 2001-11-15 Ravi Pratap <ravi@ximian.com>
23939 * interface.cs : Default modifier is private, not public. The
23940 make verify test passes again.
23942 2001-11-15 Ravi Pratap <ravi@ximian.com>
23944 * support.cs (ReflectionParameters): Fix logic to determine
23945 whether the last parameter is a params one. Test 9 passes again.
23947 * delegate.cs (Populate): Register the builders we define with
23948 RegisterParameterForBuilder. Test 19 passes again.
23950 * cs-parser.jay (property_declaration): Reference $6 instead
23951 of $$ to get at the location.
23953 (indexer_declaration): Similar stuff.
23955 (attribute): Ditto.
23957 * class.cs (Property): Register parameters for the Get and Set methods
23958 if they exist. Test 23 passes again.
23960 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
23961 call to EmitArguments as we are sure there aren't any params arguments.
23962 Test 32 passes again.
23964 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
23965 IndexOutOfRangeException.
23967 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
23968 Test 33 now passes again.
23970 2001-11-15 Miguel de Icaza <miguel@ximian.com>
23972 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
23973 broke a bunch of things. Will have to come up with a better way
23974 of tracking locations.
23976 * statement.cs: Implemented foreach for single dimension arrays.
23978 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23980 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
23981 an error. This removes the lookup from the critical path.
23983 * cs-parser.jay: Removed use of temporary_loc, which is completely
23986 2001-11-14 Miguel de Icaza <miguel@ximian.com>
23988 * support.cs (ReflectionParameters.ParameterModifier): Report
23989 whether the argument is a PARAMS argument or not.
23991 * class.cs: Set the attribute `ParamArrayAttribute' on the
23992 parameter argument.
23994 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
23995 and cons_param_array_attribute (ConstructorInfo for
23996 ParamArrayAttribute).,
23998 * codegen.cs: Emit the return using the `Return' statement, that
23999 way we can report the error correctly for missing return values.
24001 * class.cs (Method.Emit): Clean up.
24003 * expression.cs (Argument.Resolve): Take another argument: the
24004 location where this argument is used. Notice that this is not
24005 part of the "Argument" class as to reduce the size of the
24006 structure (we know the approximate location anyways).
24008 Test if the argument is a variable-reference, if not, then
24009 complain with a 206.
24011 (Argument.Emit): Emit addresses of variables.
24013 (Argument.FullDesc): Simplify.
24015 (Invocation.DoResolve): Update for Argument.Resolve.
24017 (ElementAccess.DoResolve): ditto.
24019 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
24020 method should be virtual, as this method is always virtual.
24022 (NewDelegate.DoResolve): Update for Argument.Resolve.
24024 * class.cs (ConstructorInitializer.DoResolve): ditto.
24026 * attribute.cs (Attribute.Resolve): ditto.
24028 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24030 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
24032 * expression.cs (ParameterReference): Drop IStackStorage and implement
24033 IAssignMethod instead.
24035 (LocalVariableReference): ditto.
24037 * ecore.cs (FieldExpr): Drop IStackStorage and implement
24038 IAssignMethod instead.
24040 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24042 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
24043 enumerations that are used in heavily used structures derive from
24044 byte in a laughable and pathetic attempt to reduce memory usage.
24045 This is the kind of pre-optimzations that you should not do at
24046 home without adult supervision.
24048 * expression.cs (UnaryMutator): New class, used to handle ++ and
24049 -- separatedly from the other unary operators. Cleans up the
24050 code, and kills the ExpressionStatement dependency in Unary.
24052 (Unary): Removed `method' and `Arguments' from this class, making
24053 it smaller, and moving it all to SimpleCall, so I can reuse this
24054 code in other locations and avoid creating a lot of transient data
24055 strucutres when not required.
24057 * cs-parser.jay: Adjust for new changes.
24059 2001-11-11 Miguel de Icaza <miguel@ximian.com>
24061 * enum.cs (Enum.Populate): If there is a failure during
24064 * cs-parser.jay (opt_enum_base): we used to catch type errors
24065 here, but this is really incorrect. The type error should be
24066 catched during semantic analysis.
24068 2001-12-11 Ravi Pratap <ravi@ximian.com>
24070 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
24071 current_local_parameters as expected since I, in my stupidity, had forgotten
24074 * attribute.cs (GetValidPlaces): Fix stupid bug.
24076 * class.cs (Method::Emit): Perform check on applicability of attributes.
24078 (Constructor::Emit): Ditto.
24080 (Field::Emit): Ditto.
24082 (Field.Location): Store location information.
24084 (Property, Event, Indexer, Operator): Ditto.
24086 * cs-parser.jay (field_declaration): Pass in location for each field.
24088 * ../errors/cs0592.cs : Add.
24090 2001-11-12 Ravi Pratap <ravi@ximian.com>
24092 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
24094 (InitCoreTypes): Update accordingly.
24096 (RegisterAttrType, LookupAttr): Implement.
24098 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
24099 info about the same.
24101 (Resolve): Update to populate the above as necessary.
24103 (Error592): Helper.
24105 (GetValidPlaces): Helper to the above.
24107 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
24109 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
24111 2001-11-12 Ravi Pratap <ravi@ximian.com>
24113 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
24115 * ../errors/cs0617.cs : Add.
24117 2001-11-11 Ravi Pratap <ravi@ximian.com>
24119 * enum.cs (Emit): Rename to Populate to be more consistent with what
24120 we expect it to do and when exactly it is called.
24122 * class.cs, rootcontext.cs : Update accordingly.
24124 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
24125 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
24127 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
24129 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
24130 of a fieldinfo using the above, when dealing with a FieldBuilder.
24132 2001-11-10 Ravi Pratap <ravi@ximian.com>
24134 * ../errors/cs0031.cs : Add.
24136 * ../errors/cs1008.cs : Add.
24138 * ../errrors/cs0543.cs : Add.
24140 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
24143 (FindMembers): Implement.
24145 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
24146 enums and delegates too.
24148 (enum_types): Rename to builder_to_enum.
24150 (delegate_types): Rename to builder_to_delegate.
24152 * delegate.cs (FindMembers): Implement.
24154 2001-11-09 Ravi Pratap <ravi@ximian.com>
24156 * typemanager.cs (IsEnumType): Implement.
24158 * enum.cs (Emit): Re-write parts to account for the underlying type
24159 better and perform checking etc.
24161 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
24162 of the underlying type.
24164 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
24167 * enum.cs (error31): Helper to report error #31.
24169 * cs-parser.jay (enum_declaration): Store location of each member too.
24171 * enum.cs (member_to_location): New hashtable.
24173 (AddEnumMember): Update location hashtable.
24175 (Emit): Use the location of each member while reporting errors.
24177 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24179 * cs-parser.jay: A for_initializer if is a
24180 local_variable_declaration really ammount to have an implicit
24181 block with the variable declaration and no initializer for for.
24183 * statement.cs (For.Emit): Cope with null initializers.
24185 This fixes the infinite loop on for initializers.
24187 2001-11-08 Miguel de Icaza <miguel@ximian.com>
24189 * enum.cs: More cleanup.
24191 * ecore.cs: Remove dead code.
24193 * class.cs (Property.Emit): More simplification.
24194 (Event.Emit): ditto.
24196 Reworked to have less levels of indentation.
24198 2001-11-08 Ravi Pratap <ravi@ximian.com>
24200 * class.cs (Property): Emit attributes.
24210 * enum.cs (Emit): Ditto.
24212 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
24215 * class.cs (Field, Event, etc.): Move attribute generation into the
24216 Emit method everywhere.
24218 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
24219 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
24220 as we had no way of defining nested enums !
24222 * rootcontext.cs : Adjust code accordingly.
24224 * typemanager.cs (AddEnumType): To keep track of enum types separately.
24226 2001-11-07 Ravi Pratap <ravi@ximian.com>
24228 * expression.cs (EvalConstantExpression): Move into ecore.cs
24230 * enum.cs (Enum): Rename some members and make them public and readonly
24231 according to our convention.
24233 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
24236 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
24238 (Enum::Emit): Write a simple version for now which doesn't try to compute
24239 expressions. I shall modify this to be more robust in just a while.
24241 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
24243 (TypeContainer::CloseType): Create the Enum types too.
24245 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
24247 * expression.cs (EvalConstantExpression): Get rid of completely.
24249 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
24250 user-defined values and other cases.
24252 (IsValidEnumLiteral): Helper function.
24254 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
24255 out there in the case we had a literal FieldExpr.
24257 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
24259 (Literalize): Revamp a bit to take two arguments.
24261 (EnumLiteral): New class which derives from Literal to wrap enum literals.
24263 2001-11-06 Ravi Pratap <ravi@ximian.com>
24265 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
24267 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
24269 (Resolve): Use the above to ensure we have proper initializers.
24271 2001-11-05 Ravi Pratap <ravi@ximian.com>
24273 * expression.cs (Expression::EvalConstantExpression): New method to
24274 evaluate constant expressions.
24276 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
24278 2001-11-07 Miguel de Icaza <miguel@ximian.com>
24280 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
24283 (Binary.ResolveOperator): Handle operator != (object a, object b)
24284 and operator == (object a, object b);
24286 (Binary.DoNumericPromotions): Indicate whether the numeric
24287 promotion was possible.
24289 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
24292 Made the ArrayAccess implement interface IAssignMethod instead of
24293 IStackStore as the order in which arguments are passed reflects
24296 * assign.cs: Instead of using expr.ExprClass to select the way of
24297 assinging, probe for the IStackStore/IAssignMethod interfaces.
24299 * typemanager.cs: Load InitializeArray definition.
24301 * rootcontext.cs (RootContext.MakeStaticData): Used to define
24302 static data that can be used to initialize arrays.
24304 2001-11-05 Miguel de Icaza <miguel@ximian.com>
24306 * expression.cs: Handle operator== and operator!= for booleans.
24308 (Conditioal.Reduce): Implement reducer for the ?: operator.
24310 (Conditional.Resolve): Implement dead code elimination.
24312 (Binary.Resolve): Catch string literals and return a new
24313 concatenated string.
24315 (Unary.Reduce): Implement reduction of unary expressions.
24317 * ecore.cs: Split out the expression core handling here.
24319 (Expression.Reduce): New method used to perform constant folding
24320 and CSE. This is needed to support constant-expressions.
24322 * statement.cs (Statement.EmitBoolExpression): Pass true and false
24323 targets, and optimize for !x.
24325 2001-11-04 Ravi Pratap <ravi@ximian.com>
24327 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
24328 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
24329 set custom atttributes.
24331 * literal.cs (Literal::GetValue): New abstract method to return the actual
24332 value of the literal, cast as an object.
24334 (*Literal): Implement GetValue method.
24336 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
24337 expressions to the arraylist but objects of type Argument.
24339 * class.cs (TypeContainer::Emit): Emit our attributes too.
24341 (Method::Emit, Constructor::Emit): Ditto.
24343 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
24344 to be ignoring earlier.
24346 2001-11-03 Ravi Pratap <ravi@ximian.com>
24348 * attribute.cs (AttributeSection::Define): Implement to do the business
24349 of constructing a CustomAttributeBuilder.
24351 (Attribute): New trivial class. Increases readability of code.
24353 * cs-parser.jay : Update accordingly.
24355 (positional_argument_list, named_argument_list, named_argument): New rules
24357 (attribute_arguments): Use the above so that we are more correct.
24359 2001-11-02 Ravi Pratap <ravi@ximian.com>
24361 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
24362 to perform all checks for a method with a params parameter.
24364 (Invocation::OverloadResolve): Update to use the above method and therefore
24365 cope correctly with params method invocations.
24367 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
24370 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
24371 constructors in our parent too because we can't afford to miss out on
24374 * attribute.cs (AttributeSection): New name for the class Attribute
24376 Other trivial changes to improve readability.
24378 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
24379 use the new class names.
24381 2001-11-01 Ravi Pratap <ravi@ximian.com>
24383 * class.cs (Method::Define): Complete definition for params types too
24385 (Indexer::Define): Ditto.
24387 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
24388 Cope everywhere with a request for info about the array parameter.
24390 2001-11-01 Ravi Pratap <ravi@ximian.com>
24392 * tree.cs (RecordNamespace): Fix up to check for the correct key.
24394 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
24395 local_variable_type to extract the string corresponding to the type.
24397 (local_variable_type): Fixup the action to use the new helper method.
24399 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
24402 * expression.cs : Clean out code which uses the above.
24404 2001-10-31 Ravi Pratap <ravi@ximian.com>
24406 * typemanager.cs (RegisterMethod): Check if we already have an existing key
24407 and bale out if necessary by returning a false.
24409 (RegisterProperty): Ditto.
24411 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
24412 and print out appropriate error messages.
24414 * interface.cs (everywhere): Ditto.
24416 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
24417 location to constructor.
24419 * class.cs (Property, Event, Indexer): Update accordingly.
24421 * ../errors/cs111.cs : Added.
24423 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
24424 of a method, as laid down by the spec.
24426 (Invocation::OverloadResolve): Use the above method.
24428 2001-10-31 Ravi Pratap <ravi@ximian.com>
24430 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
24431 now take a TypeContainer and a Parameters object.
24433 (ParameterData): Modify return type of ParameterModifier method to be
24434 Parameter.Modifier and not a string.
24436 (ReflectionParameters, InternalParameters): Update accordingly.
24438 * expression.cs (Argument::GetParameterModifier): Same here.
24440 * support.cs (InternalParameters::ParameterType): Find a better way of determining
24441 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
24442 symbol in it at all so maybe this is only for now.
24444 2001-10-30 Ravi Pratap <ravi@ximian.com>
24446 * support.cs (InternalParameters): Constructor now takes an extra argument
24447 which is the actual Parameters class.
24449 (ParameterDesc): Update to provide info on ref/out modifiers.
24451 * class.cs (everywhere): Update call to InternalParameters to pass in
24452 the second argument too.
24454 * support.cs (ParameterData): Add ParameterModifier, which is a method
24455 to return the modifier info [ref/out etc]
24457 (InternalParameters, ReflectionParameters): Implement the above.
24459 * expression.cs (Argument::ParameterModifier): Similar function to return
24460 info about the argument's modifiers.
24462 (Invocation::OverloadResolve): Update to take into account matching modifiers
24465 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
24466 a new SetFormalParameters object which we pass to InternalParameters.
24468 2001-10-30 Ravi Pratap <ravi@ximian.com>
24470 * expression.cs (NewArray): Merge into the ArrayCreation class.
24472 2001-10-29 Ravi Pratap <ravi@ximian.com>
24474 * expression.cs (NewArray): Merge classes NewBuiltinArray and
24475 NewUserdefinedArray into one as there wasn't much of a use in having
24478 * expression.cs (Argument): Change field's name to ArgType from Type.
24480 (Type): New readonly property which returns the proper type, taking into
24481 account ref/out modifiers.
24483 (everywhere): Adjust code accordingly for the above.
24485 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
24486 whether we are emitting for a ref or out parameter.
24488 * expression.cs (Argument::Emit): Use the above field to set the state.
24490 (LocalVariableReference::Emit): Update to honour the flag and emit the
24493 * parameter.cs (Attributes): Set the correct flags for ref parameters.
24495 * expression.cs (Argument::FullDesc): New function to provide a full desc.
24497 * support.cs (ParameterData): Add method ParameterDesc to the interface.
24499 (ReflectionParameters, InternalParameters): Implement the above method.
24501 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
24504 (Invocation::FullMethodDesc): Ditto.
24506 2001-10-29 Miguel de Icaza <miguel@ximian.com>
24508 * cs-parser.jay: Add extra production for the second form of array
24511 * expression.cs (ArrayCreation): Update to reflect the above
24514 * Small changes to prepare for Array initialization.
24516 2001-10-28 Miguel de Icaza <miguel@ximian.com>
24518 * typemanager.cs (ImplementsInterface): interface might be null;
24519 Deal with this problem;
24521 Also, we do store negative hits on the cache (null values), so use
24522 this instead of calling t.GetInterfaces on the type everytime.
24524 2001-10-28 Ravi Pratap <ravi@ximian.com>
24526 * typemanager.cs (IsBuiltinType): New method to help determine the same.
24528 * expression.cs (New::DoResolve): Get rid of array creation code and instead
24529 split functionality out into different classes.
24531 (New::FormArrayType): Move into NewBuiltinArray.
24533 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
24536 (NewBuiltinArray): New class to handle creation of built-in arrays.
24538 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
24539 account creation of one-dimensional arrays.
24541 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
24543 (NewUserdefinedArray::DoResolve): Implement.
24545 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
24547 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
24548 we maintain inside the TypeManager. This is necessary to perform lookups on the
24551 (LookupType): Update to perform GetType on the module builders too.
24553 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
24555 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
24557 2001-10-23 Ravi Pratap <ravi@ximian.com>
24559 * expression.cs (New::DoResolve): Implement guts of array creation.
24561 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
24563 2001-10-27 Miguel de Icaza <miguel@ximian.com>
24565 * expression.cs: Fix bug I introduced lsat night that broke
24568 (Expression.Resolve): Report a 246 error (can not resolve name)
24569 if we find a SimpleName in the stream.
24571 (Expression.ResolveLValue): Ditto.
24573 (Expression.ResolveWithSimpleName): This function is a variant of
24574 ResolveName, this one allows SimpleNames to be returned without a
24575 warning. The only consumer of SimpleNames is MemberAccess
24577 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24579 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24580 might arrive here. I have my doubts that this is correct.
24582 * statement.cs (Lock): Implement lock statement.
24584 * cs-parser.jay: Small fixes to support `lock' and `using'
24586 * cs-tokenizer.cs: Remove extra space
24588 * driver.cs: New flag --checked, allows to turn on integer math
24591 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24592 Threading.Monitor.Exit
24594 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24596 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24597 Expression Class to be IndexerAccess.
24599 Notice that Indexer::DoResolve sets the eclass to Value.
24601 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24603 * class.cs (TypeContainer::Emit): Emit code for indexers.
24605 * assign.cs (IAssignMethod): New interface implemented by Indexers
24606 and Properties for handling assignment.
24608 (Assign::Emit): Simplify and reuse code.
24610 * expression.cs (IndexerAccess, PropertyExpr): Implement
24611 IAssignMethod, clean up old code.
24613 2001-10-22 Ravi Pratap <ravi@ximian.com>
24615 * typemanager.cs (ImplementsInterface): New method to determine if a type
24616 implements a given interface. Provides a nice cache too.
24618 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24621 (ConvertReferenceExplicit): Ditto.
24623 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24624 various methods, with correct names etc.
24626 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24627 Operator.UnaryNegation.
24629 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24630 we have a unary plus or minus operator.
24632 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24635 * everywhere : update accordingly.
24637 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24640 * class.cs (Method::Define): For the case where we are implementing a method
24641 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24642 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24644 2001-10-21 Ravi Pratap <ravi@ximian.com>
24646 * interface.cs (FindMembers): Implement to work around S.R.E
24649 * typemanager.cs (IsInterfaceType): Implement.
24651 (FindMembers): Update to handle interface types too.
24653 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24654 use IsAssignableFrom as that is not correct - it doesn't work.
24656 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24657 and accordingly override EmitStatement.
24659 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24660 using the correct logic :-)
24662 2001-10-19 Ravi Pratap <ravi@ximian.com>
24664 * ../errors/cs-11.cs : Add to demonstrate error -11
24666 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24668 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24669 then pass this as a hint to ResolveLValue.
24671 * expression.cs (FieldExpr): Add Location information
24673 (FieldExpr::LValueResolve): Report assignment to readonly
24676 (Expression::ExprClassFromMemberInfo): Pass location information.
24678 (Expression::ResolveLValue): Add new method that resolves an
24681 (Expression::DoResolveLValue): Default invocation calls
24684 (Indexers): New class used to keep track of indexers in a given
24687 (IStackStore): Renamed from LValue, as it did not really describe
24688 what this did. Also ResolveLValue is gone from this interface and
24689 now is part of Expression.
24691 (ElementAccess): Depending on the element access type
24693 * typemanager.cs: Add `indexer_name_type' as a Core type
24694 (System.Runtime.CompilerServices.IndexerNameAttribute)
24696 * statement.cs (Goto): Take a location.
24698 2001-10-18 Ravi Pratap <ravi@ximian.com>
24700 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24701 if two delegates are compatible.
24703 (NewDelegate::DoResolve): Update to take care of the case when
24704 we instantiate a delegate from another delegate.
24706 * typemanager.cs (FindMembers): Don't even try to look up members
24707 of Delegate types for now.
24709 2001-10-18 Ravi Pratap <ravi@ximian.com>
24711 * delegate.cs (NewDelegate): New class to take care of delegate
24714 * expression.cs (New): Split the delegate related code out into
24715 the NewDelegate class.
24717 * delegate.cs (DelegateInvocation): New class to handle delegate
24720 * expression.cs (Invocation): Split out delegate related code into
24721 the DelegateInvocation class.
24723 2001-10-17 Ravi Pratap <ravi@ximian.com>
24725 * expression.cs (New::DoResolve): Implement delegate creation fully
24726 and according to the spec.
24728 (New::DoEmit): Update to handle delegates differently.
24730 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24731 because of which we were printing out arguments in reverse order !
24733 * delegate.cs (VerifyMethod): Implement to check if the given method
24734 matches the delegate.
24736 (FullDelegateDesc): Implement.
24738 (VerifyApplicability): Implement.
24740 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24741 delegate invocations too.
24743 (Invocation::Emit): Ditto.
24745 * ../errors/cs1593.cs : Added.
24747 * ../errors/cs1594.cs : Added.
24749 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24751 2001-10-16 Ravi Pratap <ravi@ximian.com>
24753 * typemanager.cs (intptr_type): Core type for System.IntPtr
24755 (InitCoreTypes): Update for the same.
24757 (iasyncresult_type, asynccallback_type): Ditto.
24759 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24762 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24765 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24766 the builders for the 4 members of a delegate type :-)
24768 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24771 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24773 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24775 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24777 * statement.cs (Break::Emit): Implement.
24778 (Continue::Emit): Implement.
24780 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24781 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24782 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24783 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24786 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24787 properties that track the label for the current loop (begin of the
24788 loop and end of the loop).
24790 2001-10-15 Ravi Pratap <ravi@ximian.com>
24792 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24793 use of emitting anything at all.
24795 * class.cs, rootcontext.cs : Get rid of calls to the same.
24797 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24799 (Populate): Define the constructor correctly and set the implementation
24802 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24805 (AddDelegateType): Implement.
24807 (IsDelegateType): Implement helper method.
24809 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24811 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24812 and accordingly handle it.
24814 * delegate.cs (Populate): Take TypeContainer argument.
24815 Implement bits to define the Invoke method. However, I still haven't figured out
24816 how to take care of the native int bit :-(
24818 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24819 Qualify the name of the delegate, not its return type !
24821 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24824 (StandardConversionExists): Checking for array types turns out to be recursive.
24826 (ConvertReferenceExplicit): Implement array conversion.
24828 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24830 2001-10-12 Ravi Pratap <ravi@ximian.com>
24832 * cs-parser.jay (delegate_declaration): Store the fully qualified
24833 name as it is a type declaration.
24835 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24838 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24839 as TypeContainer::DefineType.
24841 (Populate): Method in which all the definition of the various methods (Invoke)
24844 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24847 (CloseDelegate): Finally creates the delegate.
24849 * class.cs (TypeContainer::DefineType): Update to define delegates.
24850 (Populate, Emit and CloseType): Do the same thing here too.
24852 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24853 delegates in all these operations.
24855 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24857 * expression.cs: LocalTemporary: a new expression used to
24858 reference a temporary that has been created.
24860 * assign.cs: Handle PropertyAccess back here, so that we can
24861 provide the proper semantic access to properties.
24863 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24864 a few more explicit conversions.
24866 * modifiers.cs: `NEW' modifier maps to HideBySig.
24868 * expression.cs (PropertyExpr): Make this into an
24869 ExpressionStatement, and support the EmitStatement code path.
24871 Perform get/set error checking, clean up the interface.
24873 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24874 them into toplevel access objects.
24876 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24878 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24881 * typemanager.cs: Keep track here of our PropertyBuilders again to
24882 work around lameness in SRE.
24884 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24886 * expression.cs (LValue::LValueResolve): New method in the
24887 interface, used to perform a second resolution pass for LValues.
24889 (This::DoResolve): Catch the use of this in static methods.
24891 (This::LValueResolve): Implement.
24893 (This::Store): Remove warning, assigning to `this' in structures
24896 (Invocation::Emit): Deal with invocation of
24897 methods on value types. We need to pass the address to structure
24898 methods rather than the object itself. (The equivalent code to
24899 emit "this" for structures leaves the entire structure on the
24900 stack instead of a pointer to it).
24902 (ParameterReference::DoResolve): Compute the real index for the
24903 argument based on whether the method takes or not a `this' pointer
24904 (ie, the method is static).
24906 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24907 value types returned from functions when we need to invoke a
24908 method on the sturcture.
24911 2001-10-11 Ravi Pratap <ravi@ximian.com>
24913 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24914 defining the type in the Modulebuilder or Typebuilder. This is to take
24915 care of nested types which need to be defined on the TypeBuilder using
24916 DefineNestedMethod.
24918 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24919 methods in RootContext, only ported to be part of TypeContainer.
24921 (TypeContainer::GetInterfaceOrClass): Ditto.
24923 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
24925 * interface.cs (Interface::DefineInterface): New method. Does exactly
24926 what RootContext.CreateInterface did earlier, only it takes care of nested types
24929 (Interface::GetInterfaces): Move from RootContext here and port.
24931 (Interface::GetInterfaceByName): Same here.
24933 * rootcontext.cs (ResolveTree): Re-write.
24935 (PopulateTypes): Re-write.
24937 * class.cs (TypeContainer::Populate): Populate nested types too.
24938 (TypeContainer::Emit): Emit nested members too.
24940 * typemanager.cs (AddUserType): Do not make use of the FullName property,
24941 instead just use the name argument passed in as it is already fully
24944 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
24945 to TypeContainer mapping to see if a type is user-defined.
24947 * class.cs (TypeContainer::CloseType): Implement.
24949 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
24950 the default constructor.
24952 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
24955 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
24957 * interface.cs (CloseType): Create the type here.
24959 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
24962 Remove all the methods which are now in TypeContainer.
24964 2001-10-10 Ravi Pratap <ravi@ximian.com>
24966 * delegate.cs (Define): Re-write bits to define the delegate
24969 2001-10-10 Miguel de Icaza <miguel@ximian.com>
24971 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
24973 * expression.cs (ImplicitReferenceConversion): handle null as well
24974 as a source to convert to any reference type.
24976 * statement.cs (Return): Perform any implicit conversions to
24977 expected return type.
24979 Validate use of return statement.
24981 * codegen.cs (EmitContext): Pass the expected return type here.
24983 * class.cs (Method, Constructor, Property): Pass expected return
24984 type to EmitContext.
24986 2001-10-09 Miguel de Icaza <miguel@ximian.com>
24988 * expression.cs: Make DoResolve take an EmitContext instead of a
24991 Replaced `l' and `location' for `loc', for consistency.
24993 (Error, Warning): Remove unneeded Tc argument.
24995 * assign.cs, literal.cs, constant.cs: Update to new calling
24998 * codegen.cs: EmitContext now contains a flag indicating whether
24999 code is being generated in a static method or not.
25001 * cs-parser.jay: DecomposeQI, new function that replaces the old
25002 QualifiedIdentifier. Now we always decompose the assembled
25003 strings from qualified_identifier productions into a group of
25006 2001-10-08 Miguel de Icaza <miguel@ximian.com>
25008 * rootcontext.cs: Deal with field-less struct types correctly now
25009 by passing the size option to Define Type.
25011 * class.cs: Removed hack that created one static field.
25013 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25015 * statement.cs: Moved most of the code generation here.
25017 2001-10-09 Ravi Pratap <ravi@ximian.com>
25019 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
25022 (ElementAccess): Remove useless bits for now - keep checks as the spec
25025 2001-10-08 Ravi Pratap <ravi@ximian.com>
25027 * expression.cs (ElementAccess::DoResolve): Remove my crap code
25028 and start performing checks according to the spec.
25030 2001-10-07 Ravi Pratap <ravi@ximian.com>
25032 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
25033 rank_specifiers instead.
25035 (rank_specifiers): Change the order in which the rank specifiers are stored
25037 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
25039 * expression.cs (ElementAccess): Implement the LValue interface too.
25041 2001-10-06 Ravi Pratap <ravi@ximian.com>
25043 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
25044 except that user defined conversions are not included.
25046 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
25047 perform the conversion of the return type, if necessary.
25049 (New::DoResolve): Check whether we are creating an array or an object
25050 and accordingly do the needful.
25052 (New::Emit): Same here.
25054 (New::DoResolve): Implement guts of array creation.
25056 (New::FormLookupType): Helper function.
25058 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25060 * codegen.cs: Removed most of the code generation here, and move the
25061 corresponding code generation bits to the statement classes.
25063 Added support for try/catch/finalize and throw.
25065 * cs-parser.jay: Added support for try/catch/finalize.
25067 * class.cs: Catch static methods having the flags override,
25068 virtual or abstract.
25070 * expression.cs (UserCast): This user cast was not really doing
25071 what it was supposed to do. Which is to be born in fully resolved
25072 state. Parts of the resolution were being performed at Emit time!
25076 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25078 * expression.cs: Implicity convert the result from UserCast.
25080 2001-10-05 Ravi Pratap <ravi@ximian.com>
25082 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
25083 prevented it from working correctly.
25085 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
25086 merely ConvertImplicit.
25088 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25090 * typemanager.cs: Make the LookupTypeContainer function static,
25091 and not per-instance.
25093 * class.cs: Make static FindMembers (the one that takes a Type
25096 * codegen.cs: Add EmitForeach here.
25098 * cs-parser.jay: Make foreach a toplevel object instead of the
25099 inline expansion, as we need to perform semantic analysis on it.
25101 2001-10-05 Ravi Pratap <ravi@ximian.com>
25103 * expression.cs (Expression::ImplicitUserConversion): Rename to
25104 UserDefinedConversion.
25106 (Expression::UserDefinedConversion): Take an extra argument specifying
25107 whether we look for explicit user conversions too.
25109 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
25111 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
25113 (ExplicitUserConversion): Make it a call to UserDefinedConversion
25114 with the appropriate arguments.
25116 * cs-parser.jay (cast_expression): Record location too.
25118 * expression.cs (Cast): Record location info.
25120 (Expression::ConvertExplicit): Take location argument.
25122 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
25123 to determine if we are doing explicit conversions.
25125 (UserCast::Emit): Update accordingly.
25127 (Expression::ConvertExplicit): Report an error if everything fails.
25129 * ../errors/cs0030.cs : Add.
25131 2001-10-04 Miguel de Icaza <miguel@ximian.com>
25133 * modifiers.cs: If the ABSTRACT keyword is present, also set the
25134 virtual and newslot bits.
25136 * class.cs (TypeContainer::RegisterRequiredImplementations):
25137 Record methods we need.
25139 (TypeContainer::MakeKey): Helper function to make keys for
25140 MethodBases, since the Methodbase key is useless.
25142 (TypeContainer::Populate): Call RegisterRequiredImplementations
25143 before defining the methods.
25145 Create a mapping for method_builders_to_methods ahead of time
25146 instead of inside a tight loop.
25148 (::RequireMethods): Accept an object as the data to set into the
25149 hashtable so we can report interface vs abstract method mismatch.
25151 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25153 * report.cs: Make all of it static.
25155 * rootcontext.cs: Drop object_type and value_type computations, as
25156 we have those in the TypeManager anyways.
25158 Drop report instance variable too, now it is a global.
25160 * driver.cs: Use try/catch on command line handling.
25162 Add --probe option to debug the error reporting system with a test
25165 * report.cs: Add support for exiting program when a probe
25166 condition is reached.
25168 2001-10-03 Ravi Pratap <ravi@ximian.com>
25170 * expression.cs (Binary::DoNumericPromotions): Fix the case when
25171 we do a forcible conversion regardless of type, to check if
25172 ForceConversion returns a null.
25174 (Binary::error19): Use location to report error.
25176 (Unary::error23): Use location here too.
25178 * ../errors/cs0019.cs : Check in.
25180 * ../errors/cs0023.cs : Check in.
25182 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
25183 case of a non-null MethodInfo object with a length of 0 !
25185 (Binary::ResolveOperator): Flag error if overload resolution fails to find
25186 an applicable member - according to the spec :-)
25187 Also fix logic to find members in base types.
25189 (Unary::ResolveOperator): Same here.
25191 (Unary::report23): Change name to error23 and make first argument a TypeContainer
25192 as I was getting thoroughly confused between this and error19 :-)
25194 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
25195 (::FindMostEncompassedType): Implement.
25196 (::FindMostEncompassingType): Implement.
25197 (::StandardConversionExists): Implement.
25199 (UserImplicitCast): Re-vamp. We now need info about most specific
25200 source and target types so that we can do the necessary conversions.
25202 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
25203 mathematical union with no duplicates.
25205 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25207 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
25208 in order from base classes to child classes, so that we can in
25209 child classes look up in our parent for method names and
25210 attributes (required for handling abstract, virtual, new, override
25211 constructs: we need to instrospect our base class, and if we dont
25212 populate the classes in order, the introspection might be
25213 incorrect. For example, a method could query its parent before
25214 the parent has any methods and would determine that the parent has
25215 no abstract methods (while it could have had them)).
25217 (RootContext::CreateType): Record the order in which we define the
25220 2001-10-02 Miguel de Icaza <miguel@ximian.com>
25222 * class.cs (TypeContainer::Populate): Also method definitions can
25223 fail now, keep track of this.
25225 (TypeContainer::FindMembers): Implement support for
25226 DeclaredOnly/noDeclaredOnly flag.
25228 (Constructor::Emit) Return the ConstructorBuilder.
25230 (Method::Emit) Return the MethodBuilder.
25231 Check for abstract or virtual methods to be public.
25233 * rootcontext.cs (RootContext::CreateType): Register all the
25234 abstract methods required for the class to be complete and the
25235 interface methods that must be implemented.
25237 * cs-parser.jay: Report error 501 (method requires body if it is
25238 not marked abstract or extern).
25240 * expression.cs (TypeOf::Emit): Implement.
25242 * typemanager.cs: runtime_handle_type, new global type.
25244 * class.cs (Property::Emit): Generate code for properties.
25246 2001-10-02 Ravi Pratap <ravi@ximian.com>
25248 * expression.cs (Unary::ResolveOperator): Find operators on base type
25249 too - we now conform exactly to the spec.
25251 (Binary::ResolveOperator): Same here.
25253 * class.cs (Operator::Define): Fix minor quirk in the tests.
25255 * ../errors/cs0215.cs : Added.
25257 * ../errors/cs0556.cs : Added.
25259 * ../errors/cs0555.cs : Added.
25261 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25263 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
25264 single integer which is really efficient
25266 2001-10-01 Ravi Pratap <ravi@ximian.com>
25268 * expression.cs (Expression::ImplicitUserConversion): Use location
25269 even in the case when we are examining True operators.
25271 * class.cs (Operator::Define): Perform extensive checks to conform
25272 with the rules for operator overloading in the spec.
25274 * expression.cs (Expression::ImplicitReferenceConversion): Implement
25275 some of the other conversions mentioned in the spec.
25277 * typemanager.cs (array_type): New static member for the System.Array built-in
25280 (cloneable_interface): For System.ICloneable interface.
25282 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
25283 we start resolving the tree and populating types.
25285 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
25287 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25289 * expression.cs (Expression::ExprClassFromMemberInfo,
25290 Expression::Literalize): Create literal expressions from
25291 FieldInfos which are literals.
25293 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
25294 type casts, because they were wrong. The test suite in tests
25297 (ImplicitNumericConversion): ushort to ulong requires a widening
25300 Int32 constant to long requires widening cast as well.
25302 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
25303 for integers because the type on the stack is not i4.
25305 2001-09-30 Miguel de Icaza <miguel@ximian.com>
25307 * expression.cs (report118): require location argument.
25309 * parameter.cs: Do not dereference potential null value.
25311 * class.cs: Catch methods that lack the `new' keyword when
25312 overriding a name. Report warnings when `new' is used without
25313 anything being there to override.
25315 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
25317 * class.cs: Only add constructor to hashtable if it is non-null
25318 (as now constructors can fail on define).
25320 (TypeManager, Class, Struct): Take location arguments.
25322 Catch field instance initialization in structs as errors.
25324 accepting_filter: a new filter for FindMembers that is static so
25325 that we dont create an instance per invocation.
25327 (Constructor::Define): Catch errors where a struct constructor is
25330 * cs-parser.jay: Pass location information for various new
25333 * delegate.cs (Delegate): take a location argument.
25335 * driver.cs: Do not call EmitCode if there were problesm in the
25336 Definition of the types, as many Builders wont be there.
25338 * decl.cs (Decl::Decl): Require a location argument.
25340 * cs-tokenizer.cs: Handle properly hex constants that can not fit
25341 into integers, and find the most appropiate integer for it.
25343 * literal.cs: Implement ULongLiteral.
25345 * rootcontext.cs: Provide better information about the location of
25346 failure when CreateType fails.
25348 2001-09-29 Miguel de Icaza <miguel@ximian.com>
25350 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
25353 * expression.cs (Binary::CheckShiftArguments): Add missing type
25355 (Binary::ResolveOperator): Add type to the logical and and logical
25356 or, Bitwise And/Or and Exclusive Or code paths, it was missing
25359 (Binary::DoNumericPromotions): In the case where either argument
25360 is ulong (and most signed types combined with ulong cause an
25361 error) perform implicit integer constant conversions as well.
25363 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25365 * expression.cs (UserImplicitCast): Method should always be
25367 (Invocation::BetterConversion): Simplified test for IntLiteral.
25369 (Expression::ImplicitNumericConversion): Split this routine out.
25370 Put the code that performs implicit constant integer conversions
25373 (Expression::Resolve): Become a wrapper around DoResolve so we can
25374 check eclass and type being set after resolve.
25376 (Invocation::Badness): Remove this dead function
25378 (Binary::ResolveOperator): Do not compute the expensive argumnets
25379 unless we have a union for it.
25381 (Probe::Emit): Is needs to do an isinst and then
25382 compare against null.
25384 (::CanConvert): Added Location argument. If the Location argument
25385 is null (Location.Null), then we do not report errors. This is
25386 used by the `probe' mechanism of the Explicit conversion. We do
25387 not want to generate an error for something that the user
25388 explicitly requested to be casted. But the pipeline for an
25389 explicit cast first tests for potential implicit casts.
25391 So for now, if the Location is null, it means `Probe only' to
25392 avoid adding another argument. Might have to revise this
25395 (ClassCast): New class used to type cast objects into arbitrary
25396 classes (used in Explicit Reference Conversions).
25398 Implement `as' as well.
25400 Reverted all the patches from Ravi below: they were broken:
25402 * The use of `level' as a mechanism to stop recursive
25403 invocations is wrong. That was there just to catch the
25404 bug with a strack trace but not as a way of addressing
25407 To fix the problem we have to *understand* what is going
25408 on and the interactions and come up with a plan, not
25409 just get things going.
25411 * The use of the type conversion cache that I proposed
25412 last night had an open topic: How does this work across
25413 protection domains. A user defined conversion might not
25414 be public in the location where we are applying the
25415 conversion, a different conversion might be selected
25416 (ie, private A->B (better) but public B->A (worse),
25417 inside A, A->B applies, but outside it, B->A will
25420 * On top of that (ie, even if the above is solved),
25421 conversions in a cache need to be abstract. Ie, `To
25422 convert from an Int to a Short use an OpcodeCast', not
25423 `To convert from an Int to a Short use the OpcodeCast on
25424 the variable 5' (which is what this patch was doing).
25426 2001-09-28 Ravi Pratap <ravi@ximian.com>
25428 * expression.cs (Invocation::ConversionExists): Re-write to use
25429 the conversion cache
25431 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
25432 cache all conversions done, not just user-defined ones.
25434 (Invocation::BetterConversion): The real culprit. Use ConversionExists
25435 to determine if a conversion exists instead of acutually trying to
25436 perform the conversion. It's faster too.
25438 (Expression::ConvertExplicit): Modify to use ConversionExists to check
25439 and only then attempt the implicit conversion.
25441 2001-09-28 Ravi Pratap <ravi@ximian.com>
25443 * expression.cs (ConvertImplicit): Use a cache for conversions
25444 already found. Check level of recursion and bail out if necessary.
25446 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25448 * typemanager.cs (string_concat_string_string, string_concat_object_object):
25449 Export standard methods that we expect for string operations.
25451 * statement.cs (Block::UsageWarning): Track usage of variables and
25452 report the errors for not used variables.
25454 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
25457 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25459 * codegen.cs: remove unnneded code
25461 * expression.cs: Removed BuiltinTypeAccess class
25463 Fix the order in which implicit conversions are
25466 The previous fixed dropped support for boxed conversions (adding a
25467 test to the test suite now)
25469 (UserImplicitCast::CanConvert): Remove test for source being null,
25470 that code is broken. We should not feed a null to begin with, if
25471 we do, then we should track the bug where the problem originates
25472 and not try to cover it up here.
25474 Return a resolved expression of type UserImplicitCast on success
25475 rather than true/false. Ravi: this is what I was talking about,
25476 the pattern is to use a static method as a "constructor" for
25479 Also, do not create arguments until the very last minute,
25480 otherwise we always create the arguments even for lookups that
25481 will never be performed.
25483 (UserImplicitCast::Resolve): Eliminate, objects of type
25484 UserImplicitCast are born in a fully resolved state.
25486 * typemanager.cs (InitCoreTypes): Init also value_type
25487 (System.ValueType).
25489 * expression.cs (Cast::Resolve): First resolve the child expression.
25491 (LValue): Add new method AddressOf to be used by
25494 Change the argument of Store to take an EmitContext instead of an
25495 ILGenerator, because things like FieldExpr need to be able to call
25496 their children expression to generate the instance code.
25498 (Expression::Error, Expression::Warning): Sugar functions for
25501 (Expression::MemberLookup): Accept a TypeContainer instead of a
25502 Report as the first argument.
25504 (Expression::ResolvePrimary): Killed. I still want to improve
25505 this as currently the code is just not right.
25507 (Expression::ResolveMemberAccess): Simplify, but it is still
25510 (Unary::Resolve): Catch errors in AddressOf operators.
25512 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
25513 index to a byte for the short-version, or the compiler will choose
25514 the wrong Emit call, which generates the wrong data.
25516 (ParameterReference::Emit, ::Store): same.
25518 (FieldExpr::AddressOf): Implement.
25520 * typemanager.cs: TypeManager: made public variable instead of
25523 * driver.cs: document --fatal.
25525 * report.cs (ErrorMessage, WarningMessage): new names for the old
25526 Error and Warning classes.
25528 * cs-parser.jay (member_access): Turn built-in access to types
25529 into a normal simplename
25531 2001-09-27 Ravi Pratap <ravi@ximian.com>
25533 * expression.cs (Invocation::BetterConversion): Fix to cope
25534 with q being null, since this was introducing a bug.
25536 * expression.cs (ConvertImplicit): Do built-in conversions first.
25538 2001-09-27 Ravi Pratap <ravi@ximian.com>
25540 * expression.cs (UserImplicitCast::Resolve): Fix bug.
25542 2001-09-27 Ravi Pratap <ravi@ximian.com>
25544 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
25545 I had introduced long ago (what's new ?).
25547 * expression.cs (UserImplicitCast::CanConvert): Static method to do
25548 the work of all the checking.
25549 (ConvertImplicit): Call CanConvert and only then create object if necessary.
25550 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
25552 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
25553 that is the right way.
25555 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
25556 overloading resolution. Use everywhere instead of cutting and pasting code.
25558 (Binary::ResolveOperator): Use MakeUnionSet.
25560 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
25561 we have to convert to bool types. Not complete yet.
25563 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25565 * typemanager.cs (TypeManager::CSharpName): support ushort.
25567 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25568 to provide an expression that performsn an implicit constant int
25569 conversion (section 6.1.6).
25570 (Expression::ConvertImplicitRequired): Reworked to include
25571 implicit constant expression conversions.
25573 (Expression::ConvertNumericExplicit): Finished.
25575 (Invocation::Emit): If InstanceExpression is null, then it means
25576 that we perform a call on this.
25578 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25580 * expression.cs (Unary::Emit): Remove some dead code.
25581 (Probe): Implement Resolve and Emit for `is'.
25582 (Expression::ConvertImplicitRequired): Attempt to do constant
25583 expression conversions here. Maybe should be moved to
25584 ConvertImplicit, but I am not sure.
25585 (Expression::ImplicitLongConstantConversionPossible,
25586 Expression::ImplicitIntConstantConversionPossible): New functions
25587 that tell whether is it possible to apply an implicit constant
25588 expression conversion.
25590 (ConvertNumericExplicit): Started work on explicit numeric
25593 * cs-parser.jay: Update operator constants.
25595 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25596 (Parameters::GetSignature): Hook up VerifyArgs here.
25597 (Parameters::VerifyArgs): Verifies that no two arguments have the
25600 * class.cs (Operator): Update the operator names to reflect the
25601 ones that the spec expects (as we are just stringizing the
25604 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25605 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25606 previous usage did only work for our methods.
25607 (Expression::ConvertImplicit): Handle decimal implicit numeric
25608 conversions as well.
25609 (Expression::InternalTypeConstructor): Used to invoke constructors
25610 on internal types for default promotions.
25612 (Unary::Emit): Implement special handling for the pre/post
25613 increment/decrement for overloaded operators, as they need to have
25614 the same semantics as the other operators.
25616 (Binary::ResolveOperator): ditto.
25617 (Invocation::ConversionExists): ditto.
25618 (UserImplicitCast::Resolve): ditto.
25620 2001-09-26 Ravi Pratap <ravi@ximian.com>
25622 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25623 operator, return after emitting body. Regression tests pass again !
25625 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25626 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25627 (Invocation::OverloadResolve): Ditto.
25628 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25630 * everywhere : update calls to the above methods accordingly.
25632 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25634 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25636 * expression.cs (ExpressionStatement): New base class used for
25637 expressions that can appear in statements, so that we can provide
25638 an alternate path to generate expression that do not leave a value
25641 (Expression::Emit, and all the derivatives): We no longer return
25642 whether a value is left on the stack or not. Every expression
25643 after being emitted leaves a single value on the stack.
25645 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25646 facilties of ExpressionStatement if possible.
25648 * cs-parser.jay: Update statement_expression.
25650 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25652 * driver.cs: Change the wording of message
25654 2001-09-25 Ravi Pratap <ravi@ximian.com>
25656 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25657 the type of the expression to the return type of the method if
25658 we have an overloaded operator match ! The regression tests pass again !
25659 (Unary::ResolveOperator): Ditto.
25661 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25662 to find "op_Implicit", not "implicit" ;-)
25663 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25664 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25666 * everywhere : Correct calls to the above accordingly.
25668 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25669 (ConvertImplicit): Do user-defined conversion if it exists.
25671 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25673 * assign.cs: track location.
25674 (Resolve): Use implicit conversions on assignment.
25676 * literal.cs: Oops. Not good, Emit of short access values should
25677 pass (Bytes) or the wrong argument will be selected.
25679 * expression.cs (Unary::Emit): Emit code for -expr.
25681 (Unary::ResolveOperator): Handle `Substract' for non-constants
25682 (substract from zero from the non-constants).
25683 Deal with Doubles as well.
25685 (Expression::ConvertImplicitRequired): New routine that reports an
25686 error if no implicit conversion exists.
25688 (Invocation::OverloadResolve): Store the converted implicit
25689 expressions if we make them
25691 2001-09-24 Ravi Pratap <ravi@ximian.com>
25693 * class.cs (ConstructorInitializer): Take a Location argument.
25694 (ConstructorBaseInitializer): Same here.
25695 (ConstructorThisInitializer): Same here.
25697 * cs-parser.jay : Update all calls accordingly.
25699 * expression.cs (Unary, Binary, New): Take location argument.
25700 Update accordingly everywhere.
25702 * cs-parser.jay : Update all calls to the above to take a location
25705 * class.cs : Ditto.
25707 2001-09-24 Ravi Pratap <ravi@ximian.com>
25709 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25710 (Invocation::BetterConversion): Same here
25711 (Invocation::ConversionExists): Ditto.
25713 (Invocation::ConversionExists): Implement.
25715 2001-09-22 Ravi Pratap <ravi@ximian.com>
25717 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25718 Also take an additional TypeContainer argument.
25720 * All over : Pass in TypeContainer as argument to OverloadResolve.
25722 * typemanager.cs (CSharpName): Update to check for the string type and return
25725 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25728 2001-09-21 Ravi Pratap <ravi@ximian.com>
25730 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25731 (Invocation::BetterFunction): Implement.
25732 (Invocation::BetterConversion): Implement.
25733 (Invocation::ConversionExists): Skeleton, no implementation yet.
25735 Okay, things work fine !
25737 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25739 * typemanager.cs: declare and load enum_type, delegate_type and
25742 * expression.cs (Expression::Emit): Now emit returns a value that
25743 tells whether a value is left on the stack or not. This strategy
25744 might be reveted tomorrow with a mechanism that would address
25745 multiple assignments.
25746 (Expression::report118): Utility routine to report mismatches on
25749 (Unary::Report23): Report impossible type/operator combination
25752 (Unary::IsIncrementableNumber): Whether the type can be
25753 incremented or decremented with add.
25754 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25756 (Unary::ResolveOperator): Implement ++, !, ~,
25758 (Invocation::Emit): Deal with new Emit convetion.
25760 * All Expression derivatives: Updated their Emit method to return
25761 whether they leave values on the stack or not.
25763 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25764 stack for expressions that are statements.
25766 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25768 * expression.cs (LValue): New interface. Must be implemented by
25770 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25773 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25774 interface for generating code, simplifies the code.
25776 2001-09-20 Ravi Pratap <ravi@ximian.com>
25778 * expression.cs (everywhere): Comment out return statements in ::Resolve
25779 methods to avoid the warnings.
25781 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25783 * driver.cs (parse): Report error 2001 if we can not open the
25786 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25789 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25792 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25793 otherwise nested blocks end up with the same index.
25795 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25797 * expression.cs: Instead of having FIXMEs in the Resolve
25798 functions, throw exceptions so it is obvious that we are facing a
25801 * cs-parser.jay (invocation_expression): Pass Location information.
25803 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25804 Use a basename for those routines because .NET does not like paths
25807 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25810 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25812 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25813 are loading the correct data types (throws an exception if not).
25814 (TypeManager::InitCoreTypes): Use CoreLookupType
25816 * expression.cs (Unary::ResolveOperator): return the child
25817 expression for expressions which are just +expr.
25818 (Unary::ResolveOperator): Return negative literals for -LITERAL
25819 expressions (otherwise they are Unary {Literal}).
25820 (Invocation::Badness): Take into account `Implicit constant
25821 expression conversions'.
25823 * literal.cs (LongLiteral): Implement long literal class.
25824 (IntLiteral): export the `Value' of the intliteral.
25826 2001-09-19 Ravi Pratap <ravi@ximian.com>
25828 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25830 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25831 instead of 'Operator'
25833 * expression.cs (Binary::ResolveOperator): Update accordingly.
25834 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25837 * cs-parser.jay (unary_expression): Update to use the new names.
25839 * gen-treedump.cs (GetUnary): Same here.
25841 * expression.cs (Unary::Resolve): Implement.
25842 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25843 operators are found instead of making noise ;-)
25844 (Unary::ResolveOperator): New method to do precisely the same thing which
25845 Binary::ResolveOperator does for Binary expressions.
25846 (Unary.method, .Arguments): Add.
25847 (Unary::OperName): Implement.
25848 (Unary::ForceConversion): Copy and Paste !
25850 * class.cs (Operator::Define): Fix a small bug for the case when we have
25853 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25854 for the inbuilt operators. Only overloading works for now ;-)
25856 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25858 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25859 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25861 * expression.cs (This::Emit): Implement.
25862 (This::Resolve): Implement.
25863 (TypeOf:Resolve): Implement.
25864 (Expression::ResolveSimpleName): Add an implicit this to instance
25866 (MemberAccess::Resolve): Deal with Parameters and Fields.
25867 Bind instance variable to Field expressions.
25868 (FieldExpr::Instance): New field used to track the expression that
25869 represents the object instance.
25870 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25872 (FieldExpr::Emit): Implement.
25874 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25875 the last instruction contains a return opcode to avoid generating
25876 the last `ret' instruction (this generates correct code, and it is
25877 nice to pass the peverify output).
25879 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25880 initializer for static and instance variables.
25881 (Constructor::Emit): Allow initializer to be null in the case of
25882 static constructors. Only emit initializer for instance
25885 (TypeContainer::FindMembers): Return a null array if there are no
25888 Also fix the code for the MemberTypes.Method branch, as it was not
25889 scanning that for operators (or tried to access null variables before).
25891 * assign.cs (Assign::Emit): Handle instance and static fields.
25895 * driver.cs: Stop compilation if there are parse errors.
25897 * cs-parser.jay (constructor_declaration): Provide default base
25898 initializer for non-static constructors.
25899 (constructor_declarator): Do not provide a default base
25900 initializers if none was specified.
25901 Catch the fact that constructors should not have parameters.
25903 * class.cs: Do not emit parent class initializers for static
25904 constructors, that should be flagged as an error.
25906 2001-09-18 Ravi Pratap <ravi@ximian.com>
25908 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25909 Move back code into TypeContainer::Populate.
25911 2001-09-18 Ravi Pratap <ravi@ximian.com>
25913 * class.cs (TypeContainer::AddConstructor): Fix the check to
25914 compare against Name, not Basename.
25915 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25917 * cs-parser.jay : Update accordingly.
25919 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25920 for methods, don't forget to look into the operators too.
25921 (RegisterMethodBuilder): Helper method to take care of this for
25922 methods, constructors and operators.
25923 (Operator::Define): Completely revamp.
25924 (Operator.OperatorMethod, MethodName): New fields.
25925 (TypeContainer::Populate): Move the registering of builders into
25926 RegisterMethodBuilder.
25927 (Operator::Emit): Re-write.
25929 * expression.cs (Binary::Emit): Comment out code path to emit method
25930 invocation stuff for the case when we have a user defined operator. I am
25931 just not able to get it right !
25933 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25935 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
25938 (Expression::MemberLookup): Provide a version that allows to
25939 specify the MemberTypes and BindingFlags.
25941 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
25942 so it was not fetching variable information from outer blocks.
25944 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
25945 Beforefieldinit as it was buggy.
25947 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
25948 that Ravi put here.
25950 * class.cs (Constructor::Emit): Only emit if block is not null.
25951 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
25952 deal with this by semantically definining it as if the user had
25955 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
25956 constructors as we now "emit" them at a higher level.
25958 (TypeContainer::DefineDefaultConstructor): Used to define the
25959 default constructors if none was provided.
25961 (ConstructorInitializer): Add methods Resolve and Emit.
25963 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
25965 2001-09-17 Ravi Pratap <ravi@ximian.com>
25967 * class.cs (TypeContainer::EmitDefaultConstructor): Register
25968 the default constructor builder with our hashtable for methodbuilders
25971 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
25972 and argument_count is 0 in which case we have a match.
25973 (Binary::ResolveOperator): More null checking and miscellaneous coding
25976 2001-09-17 Ravi Pratap <ravi@ximian.com>
25978 * rootcontext.cs (IsNameSpace): Compare against null.
25980 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
25982 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
25983 and Unary::Operator.
25985 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
25988 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
25989 we have overloaded operators.
25990 (Binary::ResolveOperator): Implement the part which does the operator overload
25993 * class.cs (Operator::Emit): Implement.
25994 (TypeContainer::Emit): Emit the operators we have too.
25996 * expression.cs (Binary::Emit): Update to emit the appropriate code for
25997 the case when we have a user-defined operator.
25999 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26001 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
26003 2001-09-16 Ravi Pratap <ravi@ximian.com>
26005 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
26006 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
26007 (Constructor::Emit): Implement.
26008 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
26009 if we have no work to do.
26010 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
26013 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
26014 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
26016 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
26019 2001-09-15 Ravi Pratap <ravi@ximian.com>
26021 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
26023 (Tree::RecordNamespace): Method to do what the name says ;-)
26024 (Tree::Namespaces): Property to get at the namespaces hashtable.
26026 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
26029 * rootcontext.cs (IsNamespace): Fixed it :-)
26031 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26033 * class.cs (TypeContainer::FindMembers): Add support for
26035 (MethodCore): New class that encapsulates both the shared aspects
26036 of a Constructor and a Method.
26037 (Method, Constructor): Factored pieces into MethodCore.
26039 * driver.cs: Added --fatal which makes errors throw exceptions.
26040 Load System assembly as well as part of the standard library.
26042 * report.cs: Allow throwing exceptions on errors for debugging.
26044 * modifiers.cs: Do not use `parent', instead use the real type
26045 container to evaluate permission settings.
26047 * class.cs: Put Ravi's patch back in. He is right, and we will
26048 have to cope with the
26050 2001-09-14 Ravi Pratap <ravi@ximian.com>
26052 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
26053 FamORAssem, not FamANDAssem.
26055 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26057 * driver.cs: Added --parse option that only parses its input files
26060 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
26061 incorrect. IsTopLevel is not used to tell whether an object is
26062 root_types or not (that can be achieved by testing this ==
26063 root_types). But to see if this is a top-level *class* (not
26064 necessarly our "toplevel" container).
26066 2001-09-14 Ravi Pratap <ravi@ximian.com>
26068 * enum.cs (Enum::Define): Modify to call the Lookup method on the
26069 parent instead of a direct call to GetType.
26071 2001-09-14 Ravi Pratap <ravi@ximian.com>
26073 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
26074 Modifiers.TypeAttr. This should just be a call to that method.
26076 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
26077 object so that we can determine if we are top-level or not.
26079 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
26082 * enum.cs (Enum::Define): Ditto.
26084 * modifiers.cs (FieldAttr): Re-write.
26086 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
26087 (TypeContainer::HaveStaticConstructor): New property to provide access
26088 to precisely that info.
26090 * modifiers.cs (MethodAttr): Re-write.
26091 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
26093 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
26094 of top-level types as claimed.
26096 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26098 * expression.cs (MemberLookup): Fruitless attempt to lookup
26099 constructors. Maybe I need to emit default constructors? That
26100 might be it (currently .NET emits this for me automatically).
26101 (Invocation::OverloadResolve): Cope with Arguments == null.
26102 (Invocation::EmitArguments): new function, shared by the new
26103 constructor and us.
26104 (Invocation::Emit): Handle static and instance methods. Emit
26105 proper call instruction for virtual or non-virtual invocations.
26106 (New::Emit): Implement.
26107 (New::Resolve): Implement.
26108 (MemberAccess:Resolve): Implement.
26109 (MethodGroupExpr::InstanceExpression): used conforming to the spec
26110 to track instances.
26111 (FieldExpr::Resolve): Set type.
26113 * support.cs: Handle empty arguments.
26115 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
26116 SimpleLookup): Auxiliary routines to help parse a qualifier
26119 Update qualifier_identifier rule.
26121 * codegen.cs: Removed debugging messages.
26123 * class.cs: Make this a global thing, this acts just as a "key" to
26124 objects that we might have around.
26126 (Populate): Only initialize method_builders_to_methods once.
26128 * expression.cs (PropertyExpr): Initialize type from the
26131 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
26132 Resolve pattern. Attempt to implicitly convert value to boolean.
26135 * expression.cs: Set the type for the int32/int32 argument case.
26136 (Binary::ResolveOperator): Set the return type to boolean for
26137 comparission operators
26139 * typemanager.cs: Remove debugging print code.
26141 (Invocation::Resolve): resolve type.
26143 * class.cs: Allocate a MemberInfo of the correct size, as the code
26144 elsewhere depends on the test to reflect the correct contents.
26146 (Method::) Keep track of parameters, due to System.Reflection holes
26148 (TypeContainer::Populate): Keep track of MethodBuilders to Method
26151 (TypeContainer::FindMembers): Use ArrayList and then copy an array
26152 of the exact size and return that.
26154 (Class::LookupMethodByBuilder): New function that maps
26155 MethodBuilders to its methods. Required to locate the information
26156 on methods because System.Reflection bit us again.
26158 * support.cs: New file, contains an interface ParameterData and
26159 two implementations: ReflectionParameters and InternalParameters
26160 used to access Parameter information. We will need to grow this
26163 * expression.cs (Invocation::GetParameterData): implement a cache
26164 and a wrapper around the ParameterData creation for methods.
26165 (Invocation::OverloadResolve): Use new code.
26167 2001-09-13 Ravi Pratap <ravi@ximian.com>
26169 * class.cs (TypeContainer::EmitField): Remove and move into
26170 (Field::Define): here and modify accordingly.
26171 (Field.FieldBuilder): New member.
26172 (TypeContainer::Populate): Update accordingly.
26173 (TypeContainer::FindMembers): Implement.
26175 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26177 * statement.cs: (VariableInfo::VariableType): New field to be
26178 initialized with the full type once it is resolved.
26180 2001-09-12 Miguel de Icaza <miguel@ximian.com>
26182 * parameter.cs (GetParameterInfo): Use a type cache to compute
26183 things only once, and to reuse this information
26185 * expression.cs (LocalVariableReference::Emit): Implement.
26186 (OpcodeCast::Emit): fix.
26188 (ParameterReference::Resolve): Implement.
26189 (ParameterReference::Emit): Implement.
26191 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
26192 that are expressions need to stay as Expressions.
26194 * typemanager.cs (CSharpName): Returns the C# name of a type if
26197 * expression.cs (Expression::ConvertImplicit): New function that
26198 implements implicit type conversions.
26200 (Expression::ImplicitReferenceConversion): Implements implicit
26201 reference conversions.
26203 (EmptyCast): New type for transparent casts.
26205 (OpcodeCast): New type for casts of types that are performed with
26206 a sequence of bytecodes.
26208 (BoxedCast): New type used for casting value types into reference
26209 types. Emits a box opcode.
26211 (Binary::DoNumericPromotions): Implements numeric promotions of
26212 and computation of the Binary::Type.
26214 (Binary::EmitBranchable): Optimization.
26216 (Binary::Emit): Implement code emission for expressions.
26218 * typemanager.cs (TypeManager): Added two new core types: sbyte
26221 2001-09-12 Ravi Pratap <ravi@ximian.com>
26223 * class.cs (TypeContainer::FindMembers): Method which does exactly
26224 what Type.FindMembers does, only we don't have to use reflection. No
26225 implementation yet.
26227 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
26228 typecontainer objects as we need to get at them.
26229 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
26231 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
26232 typecontainer object.
26234 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
26235 of just a Report object.
26237 2001-09-11 Ravi Pratap <ravi@ximian.com>
26239 * class.cs (Event::Define): Go back to using the prefixes "add_" and
26241 (TypeContainer::Populate): Now define the delegates of the type too.
26242 (TypeContainer.Delegates): Property to access the list of delegates defined
26245 * delegates.cs (Delegate::Define): Implement partially.
26247 * modifiers.cs (TypeAttr): Handle more flags.
26249 2001-09-11 Ravi Pratap <ravi@ximian.com>
26251 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
26253 (Operator::Define): Re-write logic to get types by using the LookupType method
26254 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
26255 (Indexer::Define): Ditto.
26256 (Event::Define): Ditto.
26257 (Property::Define): Ditto.
26259 2001-09-10 Ravi Pratap <ravi@ximian.com>
26261 * class.cs (TypeContainer::Populate): Now define operators too.
26262 (TypeContainer.Operators): New property to access the list of operators
26264 (Operator.OperatorMethodBuilder): New member to hold the method builder
26265 for the operator we are defining.
26266 (Operator::Define): Implement.
26268 2001-09-10 Ravi Pratap <ravi@ximian.com>
26270 * class.cs (Event::Define): Make the prefixes of the accessor methods
26271 addOn_ and removeOn_
26273 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
26274 of the location being passed in too. Ideally, this should go later since all
26275 error reporting should be done through the Report object.
26277 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
26278 (Populate): Iterate thru the indexers we have and define them too.
26279 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
26280 for the get and set accessors.
26281 (Indexer::Define): Implement.
26283 2001-09-09 Miguel de Icaza <miguel@ximian.com>
26285 * expression.cs (Binary::Resolve): Beginning of it. I scratched
26286 my previous implementation, did not work.
26288 * typemanager.cs: Add a couple of missing types (the longs).
26290 * literal.cs: Use TypeManager.bool_type instead of getting it.
26292 * expression.cs (EventExpr): New kind of expressions.
26293 (Expressio::ExprClassFromMemberInfo): finish
26295 2001-09-08 Miguel de Icaza <miguel@ximian.com>
26297 * assign.cs: Emit stores to static fields differently.
26299 2001-09-08 Ravi Pratap <ravi@ximian.com>
26301 * Merge in changes and adjust code to tackle conflicts. Backed out my
26302 code in Assign::Resolve ;-)
26304 2001-09-08 Ravi Pratap <ravi@ximian.com>
26306 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
26307 instead Report.Error and also pass in the location.
26308 (CSharpParser::Lexer): New readonly property to return the reference
26309 to the Tokenizer object.
26310 (declare_local_variables): Use Report.Error with location instead of plain
26314 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
26315 (Operator.CheckBinaryOperator): Ditto.
26317 * cs-parser.jay (operator_declarator): Update accordingly.
26319 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
26320 (CheckBinaryOperator): Same here.
26322 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
26323 on the name without any prefixes of namespace names etc. This is because we
26324 already might have something already fully qualified like
26325 'System.Console.WriteLine'
26327 * assign.cs (Resolve): Begin implementation. Stuck ;-)
26329 2001-09-07 Ravi Pratap <ravi@ximian.com>
26331 * cs-tokenizer.cs (location): Return a string which also contains
26334 * expression.cs (ElementAccess): New class for expressions of the
26335 type 'element access.'
26336 (BaseAccess): New class for expressions of the type 'base access.'
26337 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
26340 * cs-parser.jay (element_access): Implement action.
26341 (base_access): Implement actions.
26342 (checked_expression, unchecked_expression): Implement.
26344 * cs-parser.jay (local_variable_type): Correct and implement.
26345 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
26347 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
26349 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
26350 name and the specifiers.
26352 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
26354 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
26355 making them all public ;-)
26357 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
26360 2001-09-07 Miguel de Icaza <miguel@ximian.com>
26362 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
26364 (FieldExpr, PropertyExprs): New resolved expressions.
26365 (SimpleName::MemberStaticCheck): Perform static checks for access
26366 to non-static fields on static methods. Maybe this should be
26367 generalized for MemberAccesses.
26368 (SimpleName::ResolveSimpleName): More work on simple name
26371 * cs-parser.jay (primary_expression/qualified_identifier): track
26372 the parameter index.
26374 * codegen.cs (CodeGen::Save): Catch save exception, report error.
26375 (EmitContext::EmitBoolExpression): Chain to expression generation
26376 instead of temporary hack.
26377 (::EmitStatementExpression): Put generic expression code generation.
26379 * assign.cs (Assign::Emit): Implement variable assignments to
26380 local variables, parameters and fields.
26382 2001-09-06 Miguel de Icaza <miguel@ximian.com>
26384 * statement.cs (Block::GetVariableInfo): New method, returns the
26385 VariableInfo for a variable name in a block.
26386 (Block::GetVariableType): Implement in terms of GetVariableInfo
26388 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
26389 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
26391 2001-09-06 Ravi Pratap <ravi@ximian.com>
26393 * cs-parser.jay (operator_declaration): Continue on my quest : update
26394 to take attributes argument.
26395 (event_declaration): Ditto.
26396 (enum_declaration): Ditto.
26397 (indexer_declaration): Ditto.
26399 * class.cs (Operator::Operator): Update constructor accordingly.
26400 (Event::Event): Ditto.
26402 * delegate.cs (Delegate::Delegate): Same here.
26404 * enum.cs (Enum::Enum): Same here.
26406 2001-09-05 Ravi Pratap <ravi@ximian.com>
26408 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
26410 * ../tests/cs0658.cs : New file to demonstrate error 0658.
26412 * attribute.cs (Attributes): New class to encapsulate all attributes which were
26413 being passed around as an arraylist.
26414 (Attributes::AddAttribute): Method to add attribute sections.
26416 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
26417 (struct_declaration): Update accordingly.
26418 (constant_declaration): Update.
26419 (field_declaration): Update.
26420 (method_header): Update.
26421 (fixed_parameter): Update.
26422 (parameter_array): Ditto.
26423 (property_declaration): Ditto.
26424 (destructor_declaration): Ditto.
26426 * class.cs (Struct::Struct): Update constructors accordingly.
26427 (Class::Class): Ditto.
26428 (Field::Field): Ditto.
26429 (Method::Method): Ditto.
26430 (Property::Property): Ditto.
26431 (TypeContainer::OptAttribute): update property's return type.
26433 * interface.cs (Interface.opt_attributes): New member.
26434 (Interface::Interface): Update to take the extra Attributes argument.
26436 * parameter.cs (Parameter::Parameter): Ditto.
26438 * constant.cs (Constant::Constant): Ditto.
26440 * interface.cs (InterfaceMemberBase): New OptAttributes field.
26441 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
26442 the attributes as a parameter.
26443 (InterfaceProperty): Update constructor call.
26444 (InterfaceEvent): Ditto.
26445 (InterfaceMethod): Ditto.
26446 (InterfaceIndexer): Ditto.
26448 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
26449 pass the attributes too.
26450 (interface_event_declaration): Ditto.
26451 (interface_property_declaration): Ditto.
26452 (interface_method_declaration): Ditto.
26453 (interface_declaration): Ditto.
26455 2001-09-05 Miguel de Icaza <miguel@ximian.com>
26457 * class.cs (Method::Define): Track the "static Main" definition to
26458 create an entry point.
26460 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
26461 EntryPoint if we find it.
26463 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
26464 (EmitContext::ig): Make this variable public.
26466 * driver.cs: Make the default output file be the first file name
26467 with the .exe extension.
26469 Detect empty compilations
26471 Handle various kinds of output targets. Handle --target and
26472 rename -t to --dumper.
26474 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
26475 methods inherited from Expression return now an Expression. This
26476 will is used during the tree rewriting as we resolve them during
26479 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
26480 the spec. Missing entirely is the information about
26481 accessability of elements of it.
26483 (Expression::ExprClassFromMemberInfo): New constructor for
26484 Expressions that creates a fully initialized Expression based on
26485 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
26488 (Invocation::Resolve): Begin implementing resolution of invocations.
26490 * literal.cs (StringLiteral): Implement Emit.
26492 2001-09-05 Ravi Pratap <ravi@ximian.com>
26494 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
26497 2001-09-04 Ravi Pratap <ravi@ximian.com>
26499 * cs-parser.jay (attribute_arguments): Implement actions.
26500 (attribute): Fix bug in production. Implement action.
26501 (attribute_list): Implement.
26502 (attribute_target): Implement.
26503 (attribute_target_specifier, opt_target_specifier): Implement
26504 (CheckAttributeTarget): New method to check if the attribute target
26506 (attribute_section): Implement.
26507 (opt_attributes): Implement.
26509 * attribute.cs : New file to handle attributes.
26510 (Attribute): Class to hold attribute info.
26512 * cs-parser.jay (opt_attribute_target_specifier): Remove production
26513 (attribute_section): Modify production to use 2 different rules to
26514 achieve the same thing. 1 s/r conflict down !
26515 Clean out commented, useless, non-reducing dimension_separator rules.
26517 * class.cs (TypeContainer.attributes): New member to hold list
26518 of attributes for a type.
26519 (Struct::Struct): Modify to take one more argument, the attribute list.
26520 (Class::Class): Ditto.
26521 (Field::Field): Ditto.
26522 (Method::Method): Ditto.
26523 (Property::Property): Ditto.
26525 * cs-parser.jay (struct_declaration): Update constructor call to
26526 pass in the attributes too.
26527 (class_declaration): Ditto.
26528 (constant_declaration): Ditto.
26529 (field_declaration): Ditto.
26530 (method_header): Ditto.
26531 (fixed_parameter): Ditto.
26532 (parameter_array): Ditto.
26533 (property_declaration): Ditto.
26535 * constant.cs (Constant::Constant): Update constructor similarly.
26536 Use System.Collections.
26538 * parameter.cs (Parameter::Parameter): Update as above.
26540 2001-09-02 Ravi Pratap <ravi@ximian.com>
26542 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
26543 (TypeContainer.delegates): New member to hold list of delegates.
26545 * cs-parser.jay (delegate_declaration): Implement the action correctly
26546 this time as I seem to be on crack ;-)
26548 2001-09-02 Miguel de Icaza <miguel@ximian.com>
26550 * rootcontext.cs (RootContext::IsNamespace): new function, used to
26551 tell whether an identifier represents a namespace.
26553 * expression.cs (NamespaceExpr): A namespace expression, used only
26554 temporarly during expression resolution.
26555 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
26556 utility functions to resolve names on expressions.
26558 2001-09-01 Miguel de Icaza <miguel@ximian.com>
26560 * codegen.cs: Add hook for StatementExpressions.
26562 * class.cs: Fix inverted test for static flag in methods.
26564 2001-09-02 Ravi Pratap <ravi@ximian.com>
26566 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26567 to make it coincide with MS' number.
26568 (Operator::CheckBinaryOperator): Ditto.
26570 * ../errors/errors.txt : Remove error numbers added earlier.
26572 * ../errors/cs1019.cs : Test case for error # 1019
26574 * ../errros/cs1020.cs : Test case for error # 1020
26576 * cs-parser.jay : Clean out commented cruft.
26577 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26578 used anywhere - non-reducing rule.
26579 (namespace_declarations): Non-reducing rule - comment out.
26581 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26582 with TypeContainer::AddEnum.
26584 * delegate.cs : New file for delegate handling classes.
26585 (Delegate): Class for declaring delegates.
26587 * makefile : Update.
26589 * cs-parser.jay (delegate_declaration): Implement.
26591 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26593 * class.cs (Event::Define): Implement.
26594 (Event.EventBuilder): New member.
26596 * class.cs (TypeContainer::Populate): Update to define all enums and events
26598 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26599 readonly fields for all these cases ?
26601 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26603 * class.cs (Property): Revamp to use the convention of making fields readonly.
26604 Accordingly modify code elsewhere.
26606 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26607 the Define method of the Property class.
26609 * class.cs : Clean up applied patch and update references to variables etc. Fix
26611 (TypeContainer::Populate): Update to define all the properties we have. Also
26612 define all enumerations.
26614 * enum.cs (Define): Implement.
26616 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26618 * cs-parser.jay (overloadable_operator): The semantic value is an
26619 enum of the Operator class.
26620 (operator_declarator): Implement actions.
26621 (operator_declaration): Implement.
26623 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26624 validity of definitions.
26625 (Operator::CheckBinaryOperator): Static method to check for binary operators
26626 (TypeContainer::AddOperator): New method to add an operator to a type.
26628 * cs-parser.jay (indexer_declaration): Added line to actually call the
26629 AddIndexer method so it gets added ;-)
26631 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26632 already taken care of by the MS compiler ?
26634 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26636 * class.cs (Operator): New class for operator declarations.
26637 (Operator::OpType): Enum for the various operators.
26639 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26641 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26642 ostensibly handle this in semantic analysis.
26644 * cs-parser.jay (general_catch_clause): Comment out
26645 (specific_catch_clauses, specific_catch_clause): Ditto.
26646 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26647 (catch_args, opt_catch_args): New productions.
26648 (catch_clause): Rewrite to use the new productions above
26649 (catch_clauses): Modify accordingly.
26650 (opt_catch_clauses): New production to use in try_statement
26651 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26652 and re-write the code in the actions to extract the specific and
26653 general catch clauses by being a little smart ;-)
26655 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26656 Hooray, try and catch statements parse fine !
26658 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26660 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26661 string from the hashtable of variables.
26663 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26664 I end up making that mistake ;-)
26665 (catch_clauses): Fixed gross error which made Key and Value of the
26666 DictionaryEntry the same : $1 !!
26668 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26670 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26672 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26673 when the add and remove accessors are specified.
26675 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26677 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26678 information about indexer_declarator.
26679 (indexer_declarator): Implement actions.
26680 (parsing_indexer): New local boolean used to keep track of whether
26681 we are parsing indexers or properties. This is necessary because
26682 implicit_parameters come into picture even for the get accessor in the
26683 case of an indexer.
26684 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26686 * class.cs (Indexer): New class for indexer declarations.
26687 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26688 (TypeContainer::indexers): New member to hold list of indexers for the
26691 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26693 * cs-parser.jay (add_accessor_declaration): Implement action.
26694 (remove_accessor_declaration): Implement action.
26695 (event_accessors_declaration): Implement
26696 (variable_declarators): swap statements for first rule - trivial.
26698 * class.cs (Event): New class to hold information about event
26700 (TypeContainer::AddEvent): New method to add an event to a type
26701 (TypeContainer::events): New member to hold list of events.
26703 * cs-parser.jay (event_declaration): Implement actions.
26705 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26707 * cs-parser.jay (dim_separators): Implement. Make it a string
26708 concatenating all the commas together, just as they appear.
26709 (opt_dim_separators): Modify accordingly
26710 (rank_specifiers): Update accordingly. Basically do the same
26711 thing - instead, collect the brackets here.
26712 (opt_rank_sepcifiers): Modify accordingly.
26713 (array_type): Modify to actually return the complete type string
26714 instead of ignoring the rank_specifiers.
26715 (expression_list): Implement to collect the expressions
26716 (variable_initializer): Implement. We make it a list of expressions
26717 essentially so that we can handle the array_initializer case neatly too.
26718 (variable_initializer_list): Implement.
26719 (array_initializer): Make it a list of variable_initializers
26720 (opt_array_initializer): Modify accordingly.
26722 * expression.cs (New::NType): Add enumeration to help us
26723 keep track of whether we have an object/delegate creation
26724 or an array creation.
26725 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26726 members to hold data about array creation.
26727 (New:New): Modify to update NewType
26728 (New:New): New Overloaded contructor for the array creation
26731 * cs-parser.jay (array_creation_expression): Implement to call
26732 the overloaded New constructor.
26734 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26736 * class.cs (TypeContainer::Constructors): Return member
26737 constructors instead of returning null.
26739 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26741 * typemanager.cs (InitCoreTypes): Initialize the various core
26742 types after we have populated the type manager with the user
26743 defined types (this distinction will be important later while
26744 compiling corlib.dll)
26746 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26747 on Expression Classification. Now all expressions have a method
26748 `Resolve' and a method `Emit'.
26750 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26751 generation from working. Also add some temporary debugging
26754 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26756 * codegen.cs: Lots of code generation pieces. This is only the
26757 beginning, will continue tomorrow with more touches of polish. We
26758 handle the fundamentals of if, while, do, for, return. Others are
26759 trickier and I need to start working on invocations soon.
26761 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26764 * codegen.cs (EmitContext): New struct, used during code
26765 emission to keep a context. Most of the code generation will be
26768 * cs-parser.jay: Add embedded blocks to the list of statements of
26769 this block. So code generation proceeds in a top down fashion.
26771 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26773 * statement.cs: Add support for multiple child blocks.
26775 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26777 * codegen.cs (EmitCode): New function, will emit the code for a
26778 Block of code given a TypeContainer and its ILGenerator.
26780 * statement.cs (Block): Standard public readonly optimization.
26781 (Block::Block constructors): Link children.
26782 (Block::Child): Child Linker.
26783 (Block::EmitVariables): Emits IL variable declarations.
26785 * class.cs: Drop support for MethodGroups here, delay until
26787 (Method::): Applied the same simplification that I did before, and
26788 move from Properties to public readonly fields.
26789 (Method::ParameterTypes): Returns the parameter types for the
26790 function, and implements a cache that will be useful later when I
26791 do error checking and the semantic analysis on the methods is
26793 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26794 and made a method, optional argument tells whether this is a class
26795 or a structure to apply the `has-this' bit.
26796 (Method::GetCallingConvention): Implement, returns the calling
26798 (Method::Define): Defines the type, a second pass is performed
26799 later to populate the methods.
26801 (Constructor::ParameterTypes): implement a cache similar to the
26802 one on Method::ParameterTypes, useful later when we do semantic
26805 (TypeContainer::EmitMethod): New method. Emits methods.
26807 * expression.cs: Removed MethodGroup class from here.
26809 * parameter.cs (Parameters::GetCallingConvention): new method.
26811 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26813 * class.cs (TypeContainer::Populate): Drop RootContext from the
26816 (Constructor::CallingConvention): Returns the calling convention.
26817 (Constructor::ParameterTypes): Returns the constructor parameter
26820 (TypeContainer::AddConstructor): Keep track of default constructor
26821 and the default static constructor.
26823 (Constructor::) Another class that starts using `public readonly'
26824 instead of properties.
26826 (Constructor::IsDefault): Whether this is a default constructor.
26828 (Field::) use readonly public fields instead of properties also.
26830 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26831 track of static constructors; If none is used, turn on
26832 BeforeFieldInit in the TypeAttributes.
26834 * cs-parser.jay (opt_argument_list): now the return can be null
26835 for the cases where there are no arguments.
26837 (constructor_declarator): If there is no implicit `base' or
26838 `this', then invoke the default parent constructor.
26840 * modifiers.cs (MethodAttr): New static function maps a set of
26841 modifiers flags into a MethodAttributes enum
26842 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26843 MethodAttr, TypeAttr to represent the various mappings where the
26844 modifiers are used.
26845 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26847 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26849 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26852 * interface.cs (PopulateIndexer): Implemented the code generator
26853 for interface indexers.
26855 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26857 * interface.cs (InterfaceMemberBase): Now we track the new status
26860 (PopulateProperty): Implement property population. Woohoo! Got
26861 Methods and Properties going today.
26863 Removed all the properties for interfaces, and replaced them with
26864 `public readonly' fields.
26866 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26868 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26869 initialize their hashtables/arraylists only when they are needed
26870 instead of doing this always.
26872 * parameter.cs: Handle refs and out parameters.
26874 * cs-parser.jay: Use an ArrayList to construct the arguments
26875 instead of the ParameterCollection, and then cast that to a
26878 * parameter.cs: Drop the use of ParameterCollection and use
26879 instead arrays of Parameters.
26881 (GetParameterInfo): Use the Type, not the Name when resolving
26884 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26886 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26887 and instead use public readonly fields.
26889 * class.cs: Put back walking code for type containers.
26891 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26893 * class.cs (MakeConstant): Code to define constants.
26895 * rootcontext.cs (LookupType): New function. Used to locate types
26898 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26900 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26901 this System.Reflection code is. Kudos to Microsoft
26903 * typemanager.cs: Implement a type cache and avoid loading all
26904 types at boot time. Wrap in LookupType the internals. This made
26905 the compiler so much faster. Wow. I rule!
26907 * driver.cs: Make sure we always load mscorlib first (for
26908 debugging purposes, nothing really important).
26910 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26911 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26913 * rootcontext.cs: Lookup types on their namespace; Lookup types
26914 on namespaces that have been imported using the `using' keyword.
26916 * class.cs (TypeContainer::TypeAttr): Virtualize.
26917 (Class::TypeAttr): Return attributes suitable for this bad boy.
26918 (Struct::TypeAttr): ditto.
26919 Handle nested classes.
26920 (TypeContainer::) Remove all the type visiting code, it is now
26921 replaced with the rootcontext.cs code
26923 * rootcontext.cs (GetClassBases): Added support for structs.
26925 2001-08-06 Miguel de Icaza <miguel@ximian.com>
26927 * interface.cs, statement.cs, class.cs, parameter.cs,
26928 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
26929 Drop use of TypeRefs, and use strings instead.
26931 2001-08-04 Miguel de Icaza <miguel@ximian.com>
26935 * class.cs (Struct::Struct): set the SEALED flags after
26936 checking the modifiers.
26937 (TypeContainer::TypeAttr): new property, returns the
26938 TypeAttributes for a class.
26940 * cs-parser.jay (type_list): Oops, list production was creating a
26941 new list of base types.
26943 * rootcontext.cs (StdLib): New property.
26944 (GetInterfaceTypeByName): returns an interface by type name, and
26945 encapsulates error handling here.
26946 (GetInterfaces): simplified.
26947 (ResolveTree): Encapsulated all the tree resolution here.
26948 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
26951 * driver.cs: Add support for --nostdlib, to avoid loading the
26952 default assemblies.
26953 (Main): Do not put tree resolution here.
26955 * rootcontext.cs: Beginning of the class resolution.
26957 2001-08-03 Miguel de Icaza <miguel@ximian.com>
26959 * rootcontext.cs: Provide better error reporting.
26961 * cs-parser.jay (interface_base): set our $$ to be interfaces.
26963 * rootcontext.cs (CreateInterface): Handle the case where there
26964 are no parent interfaces.
26966 (CloseTypes): Routine to flush types at the end.
26967 (CreateInterface): Track types.
26968 (GetInterfaces): Returns an array of Types from the list of
26969 defined interfaces.
26971 * typemanager.c (AddUserType): Mechanism to track user types (puts
26972 the type on the global type hash, and allows us to close it at the
26975 2001-08-02 Miguel de Icaza <miguel@ximian.com>
26977 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
26978 RecordInterface instead.
26980 * cs-parser.jay: Updated to reflect changes above.
26982 * decl.cs (Definition): Keep track of the TypeBuilder type that
26983 represents this type here. Not sure we will use it in the long
26984 run, but wont hurt for now.
26986 * driver.cs: Smaller changes to accomodate the new code.
26988 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
26991 * rootcontext.cs (CreateInterface): New method, used to create
26992 the System.TypeBuilder type for interfaces.
26993 (ResolveInterfaces): new entry point to resolve the interface
26995 (CodeGen): Property, used to keep track of the code generator.
26997 2001-07-26 Miguel de Icaza <miguel@ximian.com>
26999 * cs-parser.jay: Add a second production for delegate_declaration
27002 (enum_body): Put an opt_comma here instead of putting it on
27003 enum_body or enum_member_declarations so we can handle trailing
27004 commas on enumeration members. Gets rid of a shift/reduce.
27006 (type_list): Need a COMMA in the middle.
27008 (indexer_declaration): Tell tokenizer to recognize get/set
27010 * Remove old targets.
27012 * Re-add the parser target.
27014 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27016 * cs-parser.jay: Add precendence rules for a number of operators
27017 ot reduce the number of shift/reduce conflicts in the grammar.
27019 2001-07-17 Miguel de Icaza <miguel@ximian.com>
27021 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
27024 Get rid of old crufty code.
27026 * rootcontext.cs: Use this to keep track of the parsed
27027 representation and the defined types available to the program.
27029 * gen-treedump.cs: adjust for new convention.
27031 * type.cs: Split out the type manager, and the assembly builder
27034 * typemanager.cs: the type manager will live here now.
27036 * cil-codegen.cs: And the code generator here.
27038 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
27040 * makefile: Fixed up for easy making.
27042 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27044 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
27047 (unary_expression): Expand pre_increment_expression and
27048 post_decrement_expression to reduce a shift/reduce.
27050 2001-07-11 Simon Cozens
27052 * cs-tokenizer.cs: Hex numbers should begin with a 0.
27054 Improve allow_keyword_as_indent name.
27056 2001-06-19 Miguel de Icaza <miguel@ximian.com>
27058 * Adjustments for Beta2.
27060 2001-06-13 Miguel de Icaza <miguel@ximian.com>
27062 * decl.cs: Added `Define' abstract method.
27063 (InTransit): new property, used to catch recursive definitions.
27065 * interface.cs: Implement `Define'.
27067 * modifiers.cs: Map Modifiers.constants to
27068 System.Reflection.TypeAttribute flags.
27070 * class.cs: Keep track of types and user-defined types.
27071 (BuilderInit): New method for creating an assembly
27072 (ResolveType): New function to launch the resolution process, only
27073 used by interfaces for now.
27075 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
27076 that are inserted into the name space.
27078 2001-06-08 Miguel de Icaza <miguel@ximian.com>
27080 * ARGH. I have screwed up my tree so many times due to the use of
27081 rsync rather than using CVS. Going to fix this at once.
27083 * driver.cs: Objetify driver. Load assemblies, use assemblies to
27086 2001-06-07 Miguel de Icaza <miguel@ximian.com>
27088 * Experiment successful: Use System.Type rather that our own
27091 2001-05-25 Miguel de Icaza <miguel@ximian.com>
27093 * cs-parser.jay: Removed nsAliases from here.
27095 Use new namespaces, handle `using XXX;'
27097 * namespace.cs: Reimplemented namespace handling, use a recursive
27098 definition of the class. Now we can keep track of using clauses
27099 and catch invalid using clauses.
27101 2001-05-24 Miguel de Icaza <miguel@ximian.com>
27103 * gen-treedump.cs: Adapted for all the renaming.
27105 * expression.cs (Expression): this class now has a Type property
27106 which returns an expression Type.
27108 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
27109 `Type', as this has a different meaning now in the base
27111 2001-05-22 Miguel de Icaza <miguel@ximian.com>
27113 * interface.cs, class.cs: Removed from all the sources the
27114 references to signature computation, as we can not do method
27115 signature computation during the parsing time, as we are not
27116 trying to solve at that point distinguishing:
27120 void a (NS.Blah x) {}
27123 Which depending on the context might be valid or not, as we do not
27124 know if Blah is the same thing as NS.Blah at that point.
27126 * Redid everything so the code uses TypeRefs now instead of
27127 Types. TypeRefs are just temporary type placeholders, that need
27128 to be resolved. They initially have a pointer to a string and the
27129 current scope in which they are used. This is used later by the
27130 compiler to resolve the reference to an actual Type.
27132 * DeclSpace is no longer a CIR.Type, and neither are
27133 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
27134 are all DeclSpaces, but no Types.
27136 * type.cs (TypeRefManager): This implements the TypeRef manager,
27137 which keeps track of all the types that need to be resolved after
27138 the parsing has finished.
27140 2001-05-13 Miguel de Icaza <miguel@ximian.com>
27142 * ARGH. We are going to have to store `foreach' as a class rather
27143 than resolving it, as we need to verify error 1579 after name
27144 resolution. *OR* we could keep a flag that says `This request to
27145 IEnumerator comes from a foreach statement' which we can then use
27146 to generate the error.
27148 2001-05-10 Miguel de Icaza <miguel@ximian.com>
27150 * class.cs (TypeContainer.AddMethod): we now add methods to the
27151 MethodGroup instead of the method hashtable.
27153 * expression.cs: Add MethodGroup abstraction, which gets us one
27154 step closer to the specification in the way we handle method
27157 * cs-parser.jay (primary_expression): qualified_identifier now
27158 tried to match up an identifier to a local variable reference or
27159 to a parameter reference.
27161 current_local_parameters is now a parser global variable that
27162 points to the current parameters for the block, used during name
27165 (property_declaration): Now creates an implicit `value' argument to
27168 2001-05-09 Miguel de Icaza <miguel@ximian.com>
27170 * parameter.cs: Do not use `param' arguments as part of the
27171 signature, per the spec.
27173 2001-05-08 Miguel de Icaza <miguel@ximian.com>
27175 * decl.cs: Base class for classes, structs and interfaces. This
27176 is the "Declaration Space"
27178 * cs-parser.jay: Use CheckDef for checking declaration errors
27179 instead of having one on each function.
27181 * class.cs: Factor out some code for handling error handling in
27182 accordance to the "Declarations" section in the "Basic Concepts"
27183 chapter in the ECMA C# spec.
27185 * interface.cs: Make all interface member classes derive from
27186 InterfaceMemberBase.
27188 2001-05-07 Miguel de Icaza <miguel@ximian.com>
27190 * Many things: all interfaces are parsed and generated in
27191 gen-treedump. Support for member variables, constructors,
27192 destructors, properties, constants is there.
27194 Beginning of the IL backend, but very little done, just there for
27197 2001-04-29 Miguel de Icaza <miguel@ximian.com>
27199 * cs-parser.jay: Fix labeled statement.
27201 * cs-tokenizer.cs (escape): Escape " and ' always.
27202 ref_line, ref_name: keep track of the line/filename as instructed
27203 by #line by the compiler.
27206 2001-04-27 Miguel de Icaza <miguel@ximian.com>
27208 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
27209 to match the values in System.CodeDOM.
27211 Divid renamed to Divide.
27213 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
27215 (Statements.set): remove.
27217 * System.CodeDOM/CodeCatchClause.cs: always have a valid
27220 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
27221 falseStatements always have valid values.
27223 * cs-parser.jay: Use System.CodeDOM now.